- Devel - libvirt List Archives

[libvirt] Release of libvirt-0.9.8
by Daniel Veillard 12 Dec '11

12 Dec '11

One month exactly after the previous release, 0.9.8 is available at ftp://libvirt.org/libvirt/ This release is a balanced mix of new features, improvements and various bug fixes, and with a higher than usual amount of portability fixes: Features: - Add support for QEMU 1.0 (Jiri Denemark) - Add PPC cpu driver. (Prerna Saxena) - Add new API virDomain{Set, Get}BlockIoTune (Lei Li) - block_resize: Define the new API (Osier Yang) - Add a public API to invoke suspend/resume on the host (Srivatsa S. Bhat) - various improvements for LXC containers (Daniel P. Berrange) - Define keepalive protocol and add virConnectIsAlive API (Jiri Denemark) - Add support for STP filtering (Stefan Berger) - Add support for VLAN filtering (Stefan Berger) Documentation: - Add documentation for <disk><source type="dir"> (Christophe Fergeau) - Fix typo in virDomainResume API doc (Christophe Fergeau) - maint: fix improper use of 'an' (Eric Blake) - virsh: translate net-info help (Eric Blake) - maint: typo fixes (Eric Blake) - virsh: Fix typos in man page (Jiri Denemark) - rpc: Fix a typo in virNetClientSendNonBlock documentation (Jiri Denemark) - docs: fix grammar of capabilities (Eric Blake) - Documentation about chains' priorities, lists of elements etc. (Stefan Berger) Portability: - spec: don't use chkconfig --list (Eric Blake) - build: fix build with older libxml2 (Eric Blake) - Conditionalize daemonPath decl for Win32 which lacks UNIX sockets (Daniel P. Berrange) - build: reduce warnings from older gcc (Eric Blake) - Fix incorrect symbols for virtime.h module breaking Mingw32 (Daniel P. Berrange) - build: fix build on Cygwin (Eric Blake) - build: fix build at -O2 on rawhide (Eric Blake) - Fix build for platforms lacking struct ifreq (Daniel P. Berrange) - build: fix 'make dist' without dtrace (Eric Blake) - Don't use undocumented __isleap macro (Daniel P. Berrange) - virnetsocket: pass XAUTORITY for ssh connection (Christian Franke) - Fix build on Mingw32 wrt export of virNetServerGetDBusConn (Daniel P. Berrange) - build: fix compile error with no macvtap (Eric Blake) - Fix build with polkit0 (Jim Fehlig) - Fix strchr call triggering gcc 4.3 & 4.4 bug (Stefan Berger) - PATCH: Fix build without MACVTAP (Michael Wood) - util: fix compile error on debian (Eli Qiao) - Disable numactl on ARM architectures too (Daniel P. Berrange) - Add libvirt confdir to files section in mingw32 spec (Daniel P. Berrange) - build: fix mingw build of gnulib openpty (Eric Blake) Bug Fixes: - Fix updating of haveTheBuck in RPC client to be race-free (Daniel P. Berrange) - Prevent crash of libvirtd when attaching to existing qemu process (Jim Fehlig) - qemu: Ignore shutdown event from destroyed domain (Jiri Denemark) - remote_driver: don't fail if keepalive check fails (Guido Günther) - command: handle empty buffer argument correctly (Eric Blake) - client: Check if other thread claims it has the buck before claiming it. (Peter Krempa) - Avoid crash in shunloadtest (Daniel P. Berrange) - Fix a logic error for setting block I/O (Lei Li) - virsh: Allow other escape characters for console (Michal Privoznik) - bridge_driver: Don't define network if XML contains more IPv4 adreses. (Peter Krempa) - virsh: Fix possible deadlock when virsh is about to exit (Jiri Denemark) - util: Plug memory leak on virNetDevMacVLanCreateWithVPortProfile() error path (Alex Jia) - util: Plug memory leak on virNetDevBridgeGet() sucessful path (Alex Jia) - uml: Plug memory leak on umlStartVMDaemon() error path (Alex Jia) - rpc: Plug memory leak on virNetClientSendInternal() error path (Alex Jia) - conf: Plug memory leak on virDomainDefParseXML() error path (Alex Jia) - qemu: Plug memory leak onqemuProcessWaitForMonitor() error path (Alex Jia) - conf: reject duplicate paths in device weights (Eric Blake) - Make logging async signal safe wrt time stamp generation (Daniel P. Berrange) - Don't mark suspend as active until we know it is running (Daniel P. Berrange) - util: avoid null deref on qcowXGetBackingStore (Alex Jia) - virsh: correct return value error (Alex Jia) - qemu: fix blkiotune --live --config (Eric Blake) - lxc: Fix suspend/resume with freezer cgroup (Jiri Denemark) - rpc: Really send non-blocking calls while waiting for another call (Jiri Denemark) - util: fix thinko in runIO (Paolo Bonzini) - storage: Skip socket and fifo on pool-start (Michal Privoznik) - conf: Don't drop console definition on domain restart (Michal Privoznik) - qemu: Avoid dereference of NULL pointer (Peter Krempa) - nwfilter: Initialize virNWFilterAddIpAddrForIfname return variable (Michal Privoznik) - Fix disabling of virtual port profile code on old hosts (Daniel P. Berrange) - Fix uninitialized variable in NWfilter IP learning code (Daniel P. Berrange) - storage: Fallback to use lvchange first if lvremove fails (Chang Liu) - conf: don't modify cpu set string during parsing (Eric Blake) - qemu: don't release network actual device twice (Roopa Prabhu) - tests: avoid xend ABRT crash report (Eric Blake) - Fix use of uninitialized variable in QEMU driver (Daniel P. Berrange) - snapshot: refuse to generate names for non-regular backing files (Eric Blake) - fix a bug in remoteSerializeTypedParameters (Hu Tao) - Don't return a fatal error if receiving unexpected stream data (Daniel P. Berrange) - Fix handling of stream EOF (Daniel P. Berrange) - storage: forbid rebuilding existing disk storage pools (Guido Günther) - qemu: fix domjobabort regression (Eric Blake) - fix two bugs in bridge_driver.c (Hu Tao) - nwfilter: avoid failure with noexec /tmp (Eric Blake) - lxc: free error object to avoid memory leak (Alex Jia) - lxc: free 'ttyFDs' array on return from lxcVmStart (Alex Jia) Improvements: - npiv: Expose fabric_name outside (Osier Yang) - Improve error reporting when libvirtd is not installed (Daniel P. Berrange) - spec: fix sanlock dependency (Eric Blake) - spec: add dmidecode as prereq (Eric Blake) - examples: Update event tests for shutdown event (Jiri Denemark) - qemu: Rework handling of shutdown event (Jiri Denemark) - python: Expose binding for virNodeGetMemoryStats() (Peter Krempa) - python: Expose binding for virNodeGetCPUStats() (Peter Krempa) - build: require more tools from maintainers (Eric Blake) - apparmor: allow tunnelled migrations. (Serge Hallyn) - Update of filters to handle multiple IP addresses (Stefan Berger) - build: update to latest gnulib (Eric Blake) - build: properly skip tests (Eric Blake) - spec: mark directories in /var/run as ghosts (Eric Blake) - qemu: filter blkio 0-device-weight at two other places (Hu Tao) - qemu: amend existing table of device weights (Eric Blake) - virsh: fix setting weight and device-weights at the same time (Hu Tao) - Add tests for blkdeviotune (Lei Li) - Support virDomain{Set, Get}BlockIoTune in the python API (Lei Li) - Enable the blkdeviotune command in virsh (Lei Li) - Implement virDomain{Set, Get}BlockIoTune for the qemu driver (Lei Li) - Support block I/O throttle in XML (Lei Li) - Add virDomain{Set, Get}BlockIoTune support to the remote driver (Lei Li) - Fix leak build config file path (Daniel P. Berrange) - Add internal APIs for dealing with time (Daniel P. Berrange) - Remove obsolete virGetPMCapabilities sym from private symbols file (Daniel P. Berrange) - Add suspend info to Xen, LXC and UML hypervisor capabilities (Daniel P. Berrange) - Remove pointless strdup in node suspend code (Daniel P. Berrange) - Do lazy init of host PM features (Daniel P. Berrange) - Remove powerMgmt_valid field from capabilities struct (Daniel P. Berrange) - Add export of node suspend capabilities APIs (Daniel P. Berrange) - Move suspend capabilities APIs out of util.h into virnodesuspend.c (Daniel P. Berrange) - Rename suspend capabilities APIs (Daniel P. Berrange) - Sanitize virDiscoverHostPMFeature to return a boolean (Daniel P. Berrange) - Move the virHostPMCapability enum helpers into capabilities.c (Daniel P. Berrange) - Fix capabilities XML to use generic terms for suspend targets (Daniel P. Berrange) - Remove internal only virHostPMCapability enum (Daniel P. Berrange) - Fix values of PM target type constants (Daniel P. Berrange) - blkiotune: add qemu support for blkiotune.device_weight (Hu Tao) - blkiotune: add interface for blkiotune.device_weight (Hu Tao) - qemu, lxc: drop redundant checks (Eric Blake) - API: prevent query of --live and --config at once (Eric Blake) - build: fix typo in last patch (Eric Blake) - block_resize: Update test file for RPC (Osier Yang) - block_resize: Expose the new API to virsh (Osier Yang) - block_resize: Implement qemu driver method (Osier Yang) - block_resize: Implement qemu monitor functions (Osier Yang) - block_resize: Wire up the remote protocol (Osier Yang) - examples: Correct the example command to use testnode.xml (Osier Yang) - Add virsh command to initiate suspend on the host (Srivatsa S. Bhat) - Implement the core API to suspend/resume the host (Srivatsa S. Bhat) - Add the remote protocol implementation for virNodeSuspendForDuration (Srivatsa S. Bhat) - Add 'Hybrid-Suspend' power management discovery for the host (Srivatsa S. Bhat) - virsh: Don't traverse childless nodes in vshNodeIsSuperset (Michal Privoznik) - conf: make virt-xml-validate work with vbox domains (Lorin Hochstein) - conf: Improve incorrect root element error messages (Michal Privoznik) - Refactor initial LXC mem tune / device ACL code (Daniel P. Berrange) - Add support for blkio tuning of LXC containers (Daniel P. Berrange) - Add support for CPU quota/period to LXC driver (Daniel P. Berrange) - Support CPU placement in LXC driver (Daniel P. Berrange) - Support NUMA memory placement for LXC containers (Daniel P. Berrange) - storage: Refetch file status after open (Michal Privoznik) - Fix version numbers for isAlive and setKeepAlive driver APIs (Jiri Denemark) - build: Properly generate and check virkeepaliveprotocol-structs (Jiri Denemark) - examples: Use virConnectOpenAuth in events-c (Jiri Denemark) - qemu: Cancel p2p migration when connection breaks (Jiri Denemark) - qemu: Add support for keepalive messages during p2p migration (Jiri Denemark) - Add keepalive support into domain-events examples (Jiri Denemark) - Implement virConnectIsAlive in all drivers (Jiri Denemark) - Introduce virConnectIsAlive API (Jiri Denemark) - Implement keepalive protocol in remote driver (Jiri Denemark) - Add support for async close of client RPC socket (Jiri Denemark) - Implement keepalive protocol in libvirt daemon (Jiri Denemark) - virsh: Always run event loop (Jiri Denemark) - Introduce virConnectSetKeepAlive (Jiri Denemark) - Implement common keepalive handling (Jiri Denemark) - rpc: Add some debug messages to virNetClient (Jiri Denemark) - rpc: Fix handling of non-blocking calls that could not be sent (Jiri Denemark) - rpc: Pass the buck only to the first available thread (Jiri Denemark) - nwfilter: remove virConnectPtr from internal API calls (Stefan Berger) - API: prefer 'disk' over 'block' or 'path' (Eric Blake) - blockstats: support lookup by path in blockstats (Eric Blake) - virsh: Increase device-detach intelligence (Michal Prívozník) - Enable detection of multiple IP addresses (Stefan Berger) - fix error message when using wrong URI alias (Eli Qiao) - Pass additional parameter into applyDHCPOnly function (Stefan Berger) - nwfilter: use shell variable to invoke 'ip(6)tables' command (Stefan Berger) - nwfilter: use shell variable to invoke 'ebtables' command (Stefan Berger) - Improve error reporting of failures to apply filtering rules (Stefan Berger) - Add documentation for STP filtering support (Stefan Berger) - Add test cases for STP traffic filtering (Stefan Berger) - Add a 'mac' chain (Stefan Berger) - Add strings.h include to capabilities.h for ffs() function prototype (Daniel P. Berrange) - build: Update AUTHORS (Osier Yang) - Export KVM Host Power Management capabilities (Srivatsa S. Bhat) - qemu: Copy console definition from serial (Michal Privoznik) - storage: Skips backingStore of virtual snapshot lv (Osier Yang) - Add documentation for VLAN filtering support (Stefan Berger) - Add test cases for VLAN traffic filtering (Stefan Berger) - Don't copy sexpr node value that is an empty string (Jim Fehlig) - enable cgroup cpuset by default (Hu Tao) - tests: test recent hash addition (Eric Blake) - Add test cases for parsing of list values (Stefan Berger) - Extend NWFilter parameter parser to cope with lists of values (Stefan Berger) - Create rules for each member of a list (Stefan Berger) - Rework value part of name-value pairs (Stefan Berger) - Add test cases (Stefan Berger) - Interleave jumping into chains with filtering rules in 'root' table (Stefan Berger) - Extend rule priorities into negative numbers (Stefan Berger) - Enable chains with names having a known prefix (Stefan Berger) - Extend the filter XML to support priorities of chains (Stefan Berger) - Use the actual names of chains in data structure (Stefan Berger) - Use scripting for cleaning and renaming of chains (Stefan Berger) - Make filter creation in root table more flexible (Stefan Berger) - Introduce an internal priority for chains (Stefan Berger) - Add function to get hash table's key/value pairs (Stefan Berger) - Add support for systemd init service (Daniel P. Berrange) - Add support for interfaces with type=direct to LXC (Daniel P. Berrange) - Allow creation of plain macvlan devices (Daniel P. Berrange) - Refactor LXC network setup to allow future enhancements (Daniel P. Berrange) - Add missing 'const' annotations for internal domain conf helpers (Daniel P. Berrange) - qemu: Generate -numa option (Bharata B Rao) - XML definitions for guest NUMA and parsing routines (Bharata B Rao) - virsh: add iface-bridge and iface-unbridge commands (Laine Stump) - Allow non-blocking message sending on virNetClient (Daniel P. Berrange) - Refactor code for enabling/disabling I/O callback in remote client (Daniel P. Berrange) - Split virNetClientSend into 2 methods (Daniel P. Berrange) - Refactor code for passing the buck in the remote client (Daniel P. Berrange) - Explicitly track whether the buck is held in remote client (Daniel P. Berrange) - Remove all linked list handling from remote client event loop (Daniel P. Berrange) - util: Add netdev helper functions to private symbols (Eli Qiao) - qemu/rbd: improve rbd device specification (Sage Weil) - maint: fix build (Stefan Berger) - Fix error reporting in port profile parsing/formatting APIs (Daniel P. Berrange) - API: add trivial qemu support for VIR_TYPED_PARAM_STRING (Eric Blake) - API: remote support for VIR_TYPED_PARAM_STRING (Eric Blake) - API: add VIR_TYPED_PARAM_STRING (Eric Blake) - maint: use mailmap, not AUTHORS, for secondary addresses (Eric Blake) - maint: fix make syntax-check (Stefan Berger) - nwfilter: simplify execution of ebiptables scripts (Eric Blake) - Remove usage of brctl command line tool (Daniel P. Berrange) - Add an API for retrieving the MAC address of an interface (Daniel P. Berrange) - Expose MTU management APIs (Daniel P. Berrange) - Turn two int parameters into bools in bridge APIs (Daniel P. Berrange) - Make all brXXX APIs raise errors, instead of returning errnos (Daniel P. Berrange) - build: allow for local gnulib diffs (Eric Blake) - qemu: Fix improper error message for disk detaching (Osier Yang) - virsh: Add VSH_OFLAG_EMPTY_OK for attach-disk command (Xu He Jie) Cleanups: - Remove time APIs from src/util/util.h (Daniel P. Berrange) - bandwidth: Fix funky identation (Michal Privoznik) - qemu: fix a const-correctness issue (Eric Blake) - build: fix accidental POTFILES.in regression (Eric Blake) - Fix up ordering of private symbols file (Daniel P. Berrange) - Move ifaceMacvtapLinkDump and ifaceGetNthParent functions (Daniel P. Berrange) - Move functions for dealing with physical/virtual devices (Daniel P. Berrange) - Rename APIs for dealing with virtual/physical functions (Daniel P. Berrange) - Move virNetDevValidateConfig to virnetdev.c (Daniel P. Berrange) - Rename ifaceCheck to virNetDevValidateConfig (Daniel P. Berrange) - Move virNetDevGetIPv4Address to virnetdev.c (Daniel P. Berrange) - Rename ifaceGetIPAddress to virNetDevGetIPv4Address (Daniel P. Berrange) - Move virNetDevGetIndex & virNetDevGetVLanID to virnetdev.c (Daniel P. Berrange) - Rename ifaceGetIndex and ifaceGetVLAN (Daniel P. Berrange) - Move MAC address replacement functions to virnetdev.c (Daniel P. Berrange) - Rename interface MAC address replacement APIs (Daniel P. Berrange) - Move the low level macvlan creation APIs (Daniel P. Berrange) - Rename low level macvlan creation APIs (Daniel P. Berrange) - Rename high level macvlan creation APIs (Daniel P. Berrange) - Rename and split the macvtap.c file (Daniel P. Berrange) - Rename Macvtap management APIs (Daniel P. Berrange) - Remove ifaceSetMac and ifaceGetMac APIs (Daniel P. Berrange) - Remove ifaceUp, ifaceDown, ifaceCtrl & ifaceIsUp APIs (Daniel P. Berrange) - Move LXC veth.c code into shared utility APIs (Daniel P. Berrange) - Rename the LXC veth management APIs and delete duplicated APIs (Daniel P. Berrange) - Split src/util/network.{c,h} into 5 pieces (Daniel P. Berrange) - Rename virVirtualPortProfileParams & APIs (Daniel P. Berrange) - build: drop useless dirent.h includes (Eric Blake) - xenapi: remove unused variable (Eric Blake) - Remove code instantiating filters on direct interfaces (Stefan Berger) - Adjust naming of network device bandwidth management APIs (Daniel P. Berrange) - Santize naming of socket address APIs (Daniel P. Berrange) - Split bridge.h into three separate files (Daniel P. Berrange) - Rename all brXXXX APIs to follow new convention (Daniel P. Berrange) - Remove 'brControl' object (Daniel P. Berrange) Thanks again to everybody who contributed to this release, with patches, ideas, documentation or reporting issues ! Let's not forget the translation teams at transifex [1] with special kudos for ukainian who have 100% complete localization if I believe transifex statistics :-) Daniel [1] https://www.transifex.net/projects/p/libvirt/resource/strings/ -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

3 2

Re: [libvirt] virsh console giving Error
by Amit Tewari 12 Dec '11

12 Dec '11

Hi, I am using libvirt 0.9.7 -----Original Message----- From: Kashyap Chamarthy [mailto:kchamart@redhat.com] Sent: Monday, December 12, 2011 12:32 PM To: Amit Tewari Cc: libvir-list(a)redhat.com Subject: Re: [libvirt] virsh console giving Error On 12/12/2011 12:16 PM, Amit Tewari wrote: > Hi all, > > Following is my test environment > > Host os= rhel6.1 > > Guest os=rhel6.1 > > Hypervisor - kvm > > > > I have a created a guest machine using virt-install command. And it has created guest > successfully. > > But now when I issue following command > > #virsh console guest > > > > Following error is displayed - > > > > "Error: internal error character device (null) is not using a PTY" > > > > Please let me no how can I avoid this error. You have not specified what distribution, version of libvirt are you using. First, can you ensure if you have serial console set up in your guest by checking if you have the below directives in your guest kernel's command line options (in /etc/grub.conf) ---- console=tty0 console=ttyS0,115200 ---- If not, you can add it by running the below (ensure the guest is shut-off): # virt-edit guest /etc/grub.conf 'virt-edit' tool comes with libguestfs-tools-c package. -- /kashyap > > > > Regards > > Amit Tewari > > > > -- > libvir-list mailing list > libvir-list(a)redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list DISCLAIMER: ----------------------------------------------------------------------------------------------------------------------- The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. It shall not attach any liability on the originator or NECHCL or its affiliates. Any views or opinions presented in this email are solely those of the author and may not necessarily reflect the opinions of NECHCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. . -----------------------------------------------------------------------------------------------------------------------

4 3

[libvirt] make uninstall fails
by Dave Allan 12 Dec '11

12 Dec '11

Hey all, I just noticed that make uninstall from the git HEAD fails: rmdir /etc/sasl2/ rmdir: failed to remove `/etc/sasl2/': Directory not empty it's correct that /etc/sasl2 should not be removed, as it has other files in it, so I think this removal should be more targeted, although I haven't investigated what should be removed when uninstalling. Dave

4 5

[libvirt] [PATCH] qemu: Disable EOF processing during qemuDomainDestroy
by Jiri Denemark 12 Dec '11

12 Dec '11

When destroying a domain qemuDomainDestroy kills its qemu process and starts a new job, which means it unlocks the domain object and locks it again after some time. Although the object is usually unlocked for a pretty short time, chances are another thread processing an EOF event on qemu monitor is able to lock the object first and does all the cleanup by itself. This leads to wrong shutoff reason and lifecycle event detail and virDomainDestroy API incorrectly reporting failure to destroy an inactive domain. Reported by Charlie Smurthwaite. --- src/qemu/qemu_domain.h | 1 + src/qemu/qemu_driver.c | 10 ++++++++++ src/qemu/qemu_process.c | 22 +++++++++++++++------- 3 files changed, 26 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index e8bcab3..35f9440 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -110,6 +110,7 @@ struct _qemuDomainObjPrivate { bool monError; unsigned long long monStart; bool gotShutdown; + bool beingDestroyed; char *pidfile; int nvcpupids; diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 10a289e..ceb9f47 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1678,6 +1678,7 @@ qemuDomainDestroyFlags(virDomainPtr dom, virDomainObjPtr vm; int ret = -1; virDomainEventPtr event = NULL; + qemuDomainObjPrivatePtr priv; virCheckFlags(0, -1); @@ -1691,6 +1692,8 @@ qemuDomainDestroyFlags(virDomainPtr dom, goto cleanup; } + priv = vm->privateData; + qemuDomainSetFakeReboot(driver, vm, false); /* Although qemuProcessStop does this already, there may @@ -1700,9 +1703,16 @@ qemuDomainDestroyFlags(virDomainPtr dom, */ qemuProcessKill(vm, false); + /* We need to prevent monitor EOF callback from doing our work (and sending + * misleading events) while the vm is unlocked inside BeginJob API + */ + priv->beingDestroyed = true; + if (qemuDomainObjBeginJobWithDriver(driver, vm, QEMU_JOB_DESTROY) < 0) goto cleanup; + priv->beingDestroyed = false; + if (!virDomainObjIsActive(vm)) { qemuReportError(VIR_ERR_OPERATION_INVALID, "%s", _("domain is not running")); diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index d4271d0..9123f4c 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -128,14 +128,18 @@ qemuProcessHandleMonitorEOF(qemuMonitorPtr mon ATTRIBUTE_UNUSED, qemuDriverLock(driver); virDomainObjLock(vm); + priv = vm->privateData; + + if (priv->beingDestroyed) { + VIR_DEBUG("Domain is being destroyed, EOF is expected"); + goto unlock; + } + if (!virDomainObjIsActive(vm)) { VIR_DEBUG("Domain %p is not active, ignoring EOF", vm); - virDomainObjUnlock(vm); - qemuDriverUnlock(driver); - return; + goto unlock; } - priv = vm->privateData; if (priv->monJSON && !priv->gotShutdown) { VIR_DEBUG("Monitor connection to '%s' closed without SHUTDOWN event; " "assuming the domain crashed", vm->def->name); @@ -150,11 +154,15 @@ qemuProcessHandleMonitorEOF(qemuMonitorPtr mon ATTRIBUTE_UNUSED, qemuProcessStop(driver, vm, 0, stopReason); virDomainAuditStop(vm, auditReason); - if (!vm->persistent) + if (!vm->persistent) { qemuDomainRemoveInactive(driver, vm); - else - virDomainObjUnlock(vm); + goto cleanup; + } +unlock: + virDomainObjUnlock(vm); + +cleanup: if (event) qemuDomainEventQueue(driver, event); qemuDriverUnlock(driver); -- 1.7.8

2 2

[libvirt] [libvirt-glib 1/2] Fix gvir_config_domain_disk_set_target_bus API
by Christophe Fergeau 12 Dec '11

12 Dec '11

The bus type is actually an enum, let's reflect that in libvirt-gconfig API --- libvirt-gconfig/libvirt-gconfig-domain-disk.c | 8 ++++++-- libvirt-gconfig/libvirt-gconfig-domain-disk.h | 13 ++++++++++++- libvirt-gconfig/libvirt-gconfig.sym | 1 + libvirt-gconfig/tests/test-domain-create.c | 2 +- 4 files changed, 20 insertions(+), 4 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-disk.c b/libvirt-gconfig/libvirt-gconfig-domain-disk.c index 502cf43..b52f4a5 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-disk.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-disk.c @@ -159,14 +159,18 @@ void gvir_config_domain_disk_set_driver_type(GVirConfigDomainDisk *disk, } void gvir_config_domain_disk_set_target_bus(GVirConfigDomainDisk *disk, - const char *bus) + GVirConfigDomainDiskBus bus) { GVirConfigObject *node; g_return_if_fail(GVIR_IS_CONFIG_DOMAIN_DISK(disk)); node = gvir_config_object_add_child(GVIR_CONFIG_OBJECT(disk), "target"); g_return_if_fail(GVIR_IS_CONFIG_OBJECT(node)); - gvir_config_object_set_attribute(node, "bus", bus, NULL); + gvir_config_object_set_attribute_with_type(node, + "bus", + GVIR_TYPE_CONFIG_DOMAIN_DISK_BUS, + bus, + NULL); g_object_unref(G_OBJECT(node)); } diff --git a/libvirt-gconfig/libvirt-gconfig-domain-disk.h b/libvirt-gconfig/libvirt-gconfig-domain-disk.h index b90b2bc..bc63dfe 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-disk.h +++ b/libvirt-gconfig/libvirt-gconfig-domain-disk.h @@ -64,6 +64,17 @@ typedef enum { } GVirConfigDomainDiskType; typedef enum { + GVIR_CONFIG_DOMAIN_DISK_BUS_IDE, + GVIR_CONFIG_DOMAIN_DISK_BUS_FDC, + GVIR_CONFIG_DOMAIN_DISK_BUS_SCSI, + GVIR_CONFIG_DOMAIN_DISK_BUS_VIRTIO, + GVIR_CONFIG_DOMAIN_DISK_BUS_XEN, + GVIR_CONFIG_DOMAIN_DISK_BUS_USB, + GVIR_CONFIG_DOMAIN_DISK_BUS_UML, + GVIR_CONFIG_DOMAIN_DISK_BUS_SATA +} GVirConfigDomainDiskBus; + +typedef enum { GVIR_CONFIG_DOMAIN_DISK_GUEST_DEVICE_DISK, GVIR_CONFIG_DOMAIN_DISK_GUEST_DEVICE_FLOPPY, GVIR_CONFIG_DOMAIN_DISK_GUEST_DEVICE_CDROM @@ -94,7 +105,7 @@ void gvir_config_domain_disk_set_driver_name(GVirConfigDomainDisk *disk, void gvir_config_domain_disk_set_driver_type(GVirConfigDomainDisk *disk, const char *driver_type); void gvir_config_domain_disk_set_target_bus(GVirConfigDomainDisk *disk, - const char *bus); + GVirConfigDomainDiskBus bus); void gvir_config_domain_disk_set_target_dev(GVirConfigDomainDisk *disk, const char *dev); G_END_DECLS diff --git a/libvirt-gconfig/libvirt-gconfig.sym b/libvirt-gconfig/libvirt-gconfig.sym index 6adc2c2..d0c35d2 100644 --- a/libvirt-gconfig/libvirt-gconfig.sym +++ b/libvirt-gconfig/libvirt-gconfig.sym @@ -54,6 +54,7 @@ LIBVIRT_GCONFIG_0.0.1 { gvir_config_domain_device_get_type; gvir_config_domain_disk_get_type; + gvir_config_domain_disk_bus_get_type; gvir_config_domain_disk_guest_device_type_get_type; gvir_config_domain_disk_snapshot_type_get_type; gvir_config_domain_disk_type_get_type; diff --git a/libvirt-gconfig/tests/test-domain-create.c b/libvirt-gconfig/tests/test-domain-create.c index 42aa09b..ea3a3ea 100644 --- a/libvirt-gconfig/tests/test-domain-create.c +++ b/libvirt-gconfig/tests/test-domain-create.c @@ -100,7 +100,7 @@ int main(void) gvir_config_domain_disk_set_source(disk, "/tmp/foo/bar"); gvir_config_domain_disk_set_driver_name(disk, "qemu"); gvir_config_domain_disk_set_driver_type(disk, "qcow2"); - gvir_config_domain_disk_set_target_bus(disk, "ide"); + gvir_config_domain_disk_set_target_bus(disk, GVIR_CONFIG_DOMAIN_DISK_BUS_IDE); gvir_config_domain_disk_set_target_dev(disk, "hda"); devices = g_list_append(devices, GVIR_CONFIG_DOMAIN_DEVICE(disk)); -- 1.7.7.3

2 3

[libvirt] Expand GVirConfigDomainInterface a bit
by Christophe Fergeau 12 Dec '11

12 Dec '11

Hi, This patch series add setters for the GVirConfigDomainInterface properties which are common to all classes deriving from GVirConfigDomainInterface. It also adds GVirConfigDomainInterfaceUser so that it's possible to create <interface type="user"> nodes. Christophe

2 3

[libvirt] [PATCH] virsh: Free returned MIME type string
by Michal Privoznik 12 Dec '11

12 Dec '11

In terms of documentation to virDomainScreenshot, caller MUST free returned value. But virsh was not. --- Pushing under trivial rule. tools/virsh.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index d859b3a..d58b827 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -3097,6 +3097,7 @@ cleanup: if (st) virStreamFree(st); VIR_FORCE_CLOSE(fd); + VIR_FREE(mime); return ret; } -- 1.7.3.4

1 0

[libvirt] [PATCH] storage: Activate/deactivate logical volumes only on local node
by Osier Yang 12 Dec '11

12 Dec '11

From: Rommer <rommer(a)active.by> Current "-ay | -an" has problems on pool starting/refreshing if the volumes are clustered. Rommer has posted a patch to list 2 months ago. https://www.redhat.com/archives/libvir-list/2011-October/msg01116.html But IMO we shouldn't skip the inactived vols. So this is a squashed patch by Rommer. Signed-off-by: Rommer <rommer(a)active.by> --- src/storage/storage_backend_logical.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_backend_logical.c index 1420ede..6a235f6 100644 --- a/src/storage/storage_backend_logical.c +++ b/src/storage/storage_backend_logical.c @@ -51,7 +51,7 @@ virStorageBackendLogicalSetActive(virStoragePoolObjPtr pool, const char *cmdargv[4]; cmdargv[0] = VGCHANGE; - cmdargv[1] = on ? "-ay" : "-an"; + cmdargv[1] = on ? "-aly" : "-aln"; cmdargv[2] = pool->def->source.name; cmdargv[3] = NULL; -- 1.7.1

2 3

[libvirt] [PATCH v2 0/4] Interface pools and passthrough mode
by Shradha Shah 12 Dec '11

12 Dec '11

Interface Pools and Passthrough mode: Current Method: The passthrough mode uses a macvtap direct connection to connect each guest to the network. The physical interface to be used is picked from among those listed in <interface> sub elements of the <forward> element. The current specification for <forward> extends to allow 0 or more <interface> sub-elements: Example: <forward mode='passthrough' dev='eth10'/> <interface dev='eth10'/> <interface dev='eth12'/> <interface dev='eth18'/> <interface dev='eth20'/> </forward> However with an ethernet card with 64 VF's or more, the above method gets tedious on the system. On the other hand, just parameterizing a string (eth%d) is inadequate, eg, when there are multiple non-contiguous ranges. Proposed Method: The 4 patches provided: i) Introduce a new element 'pf' to implicitly create an interface pool of all the Virtual Functions attached to the specified Physical Function. ii) Modify the networkAllocateActualDevice, networkNotifyActualDevice and networkReleaseActualDevice API to use the above mentioned interface pool in the passthrough mode. Hence Libvirt will now support both the methods mentioned below: * Explicit interface list. App inputs: <forward mode='passthrough'> <interface dev='eth10'/> <interface dev='eth11'/> <interface dev='eth12'/> <interface dev='eth13'/> </forward> libvirt does not change XML * Automatically interface list from PF. App inputs: <forward mode='passthrough'> <pf dev='eth0'/> </forward> libvirt expands XML to be <forward mode='passthrough'> <pf dev='eth0'/> <interface dev='eth10'/> <interface dev='eth11'/> <interface dev='eth12'/> <interface dev='eth13'/> </forward> In the above case we need to differentiate between the implicit and explicit interface pool, which can be done by comparing the dumpxml from active and inactive domains. This will need the addition of the flag VIR_NETWORK_XML_INACTIVE to virNetworkGetXMLDesc() as mentioned in a previous suggestion. I will post this as a separate patch series. Shradha Shah (4): Added function pciSysfsFile to enable access to the PCI SYSFS files. Added Function virNetDevGetVirtualFunctions Adding the element pf to network xml. Functionality to implicitly get interface pool from SR-IOV PF. docs/schemas/network.rng | 7 +++ src/conf/network_conf.c | 69 ++++++++++++++++++++++++++++++-- src/conf/network_conf.h | 3 + src/network/bridge_driver.c | 93 +++++++++++++++++++++++++++++++++--------- src/util/pci.c | 39 ++++++++++++++++++ src/util/pci.h | 7 +++ src/util/virnetdev.c | 83 ++++++++++++++++++++++++++++++++++++++ src/util/virnetdev.h | 6 +++ 8 files changed, 283 insertions(+), 24 deletions(-) -- 1.7.4.4

1 4

[libvirt] [PATCH] security: don't try to label network disks
by Josh Durgin 12 Dec '11

12 Dec '11

Network disks don't have paths to be resolved or files to be checked for ownership. ee3efc41e6233e625aa03003bf3127319ccd546f checked this for some image label functions, but was partially reverted in a refactor. This finishes adding the check to each security driver's set and restore label methods for images. Signed-off-by: Josh Durgin <josh.durgin(a)dreamhost.com> --- src/security/security_apparmor.c | 3 +++ src/security/security_dac.c | 6 ++++++ src/security/security_selinux.c | 3 +++ 3 files changed, 12 insertions(+), 0 deletions(-) diff --git a/src/security/security_apparmor.c b/src/security/security_apparmor.c index db7e7dc..3a01a21 100644 --- a/src/security/security_apparmor.c +++ b/src/security/security_apparmor.c @@ -606,6 +606,9 @@ AppArmorRestoreSecurityImageLabel(virSecurityManagerPtr mgr, virDomainObjPtr vm, virDomainDiskDefPtr disk ATTRIBUTE_UNUSED) { + if (disk->type == VIR_DOMAIN_DISK_TYPE_NETWORK) + return 0; + return reload_profile(mgr, vm, NULL, false); } diff --git a/src/security/security_dac.c b/src/security/security_dac.c index 0e75319..9f8a320 100644 --- a/src/security/security_dac.c +++ b/src/security/security_dac.c @@ -180,6 +180,9 @@ virSecurityDACSetSecurityImageLabel(virSecurityManagerPtr mgr, if (!priv->dynamicOwnership) return 0; + if (disk->type == VIR_DOMAIN_DISK_TYPE_NETWORK) + return 0; + return virDomainDiskDefForeachPath(disk, virSecurityManagerGetAllowDiskFormatProbing(mgr), false, @@ -199,6 +202,9 @@ virSecurityDACRestoreSecurityImageLabelInt(virSecurityManagerPtr mgr, if (!priv->dynamicOwnership) return 0; + if (disk->type == VIR_DOMAIN_DISK_TYPE_NETWORK) + return 0; + /* Don't restore labels on readoly/shared disks, because * other VMs may still be accessing these * Alternatively we could iterate over all running diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 78c0d45..6ef61c7 100644 --- a/src/security/security_selinux.c +++ b/src/security/security_selinux.c @@ -636,6 +636,9 @@ SELinuxSetSecurityImageLabel(virSecurityManagerPtr mgr, if (secdef->norelabel) return 0; + if (disk->type == VIR_DOMAIN_DISK_TYPE_NETWORK) + return 0; + return virDomainDiskDefForeachPath(disk, allowDiskFormatProbing, true, -- 1.7.1

3 2