- Devel - libvirt List Archives

[libvirt] Would it make sense to have a <disk device='logicalvolume'>?
by Francesco Pretto 10 Jan '12

10 Jan '12

The questions is this: 1) would it make sense to expose a block device in the host to be mapped like a "logical volume" in the guest (I mean: not actually exposing it as a physical disk)? 2) Is there any existing hypervisor that could be made to work like this? Example scenario: Just suppose I have a real logical volume in the *host* called "/dev/mapper/domain0_home" (it could be any block device, but this would be a real useful configuration). Consider the following hypothetical libvirt configuration: <disk type='block' device='lv'> <source dev='/dev/mapper/domain0_home'/> <target dev='home' bus='virtio'/> </disk> 'lv' stands for "logicavolume". The block device should be automatically mapped in the *guest* as "/dev/mapper/home", and not advertised as a physical disk.

2 5

[libvirt] [PATCH 0/2] VirtFS fixes needed for supporting fs driver in VMM
by Deepak C Shetty 10 Jan '12

10 Jan '12

These are the libvirt changes needed to ensure that the virt-manager changes done for supporting fs driver work well. --- Deepak C Shetty (2): Set default fs driver when not provided in input xml Do not generate security_model when fs driver is anything but 'path' src/conf/domain_conf.c | 15 +++++++++++---- src/qemu/qemu_command.c | 15 +++++++++------ 2 files changed, 20 insertions(+), 10 deletions(-) -- Signature

2 9

[libvirt] [PATCH] Docs: Document Android application using libvirt
by Michal Privoznik 10 Jan '12

10 Jan '12

This is acutally a patch for VM Manager for Android. https://www.redhat.com/archives/libvirt-users/2011-November/msg00076.html --- docs/apps.html.in | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/docs/apps.html.in b/docs/apps.html.in index 8d27b70..29bebbd 100644 --- a/docs/apps.html.in +++ b/docs/apps.html.in @@ -348,5 +348,16 @@ </dd> </dl> + <h2><a name="mobile">Mobile applications</a></h2> + + <dl> + <dt><a href="https://market.android.com/details?id=vm.manager">VM Manager</a></dt> + <dd> + VM Manager is VM (libvirt) manager (over SSH) application. VM Manager + is an application for libvirt VM / Domain management over SSH. + Please keep in mind that this software is under heavy development. + </dd> + </dl> + </body> </html> -- 1.7.3.4

2 2

[libvirt] [PATCH] npiv: Auto-generate WWN if it's not specified
by Osier Yang 10 Jan '12

10 Jan '12

The auto-generated WWN comply with the new addressing schema of WWN: <quote> the first nibble is either hex 5 or 6 followed by a 3-byte vendor identifier and 36 bits for a vendor-specified serial number. </quote> We choose hex 5 for the first nibble. And use Qumranet's OUI (00:1A:4A) as the 3-byte vendor indentifier. The last 36 bits are auto-generated. --- src/conf/node_device_conf.c | 35 ++++++++++++++++++----------------- src/libvirt_private.syms | 1 + src/util/util.c | 20 ++++++++++++++++++++ src/util/util.h | 1 + 4 files changed, 40 insertions(+), 17 deletions(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index d9dc9ac..e7cc243 100644 --- a/src/conf/node_device_conf.c +++ b/src/conf/node_device_conf.c @@ -63,19 +63,12 @@ VIR_ENUM_IMPL(virNodeDevHBACap, VIR_NODE_DEV_CAP_HBA_LAST, static int virNodeDevCapsDefParseString(const char *xpath, xmlXPathContextPtr ctxt, - char **string, - virNodeDeviceDefPtr def, - const char *missing_error_fmt) + char **string) { char *s; - s = virXPathString(xpath, ctxt); - if (s == NULL) { - virNodeDeviceReportError(VIR_ERR_INTERNAL_ERROR, - missing_error_fmt, - def->name); + if (!(s = virXPathString(xpath, ctxt))) return -1; - } *string = s; return 0; @@ -763,18 +756,26 @@ virNodeDevCapScsiHostParseXML(xmlXPathContextPtr ctxt, if (virNodeDevCapsDefParseString("string(./wwnn[1])", ctxt, - &data->scsi_host.wwnn, - def, - _("no WWNN supplied for '%s'")) < 0) { - goto out; + &data->scsi_host.wwnn) < 0) { + if (virGenerateWWN(&data->scsi_host.wwnn) < 0) { + virNodeDeviceReportError(VIR_ERR_INTERNAL_ERROR, + _("no WWNN supplied for '%s', and " + "auto-generation failed"), + def->name); + goto out; + } } if (virNodeDevCapsDefParseString("string(./wwpn[1])", ctxt, - &data->scsi_host.wwpn, - def, - _("no WWPN supplied for '%s'")) < 0) { - goto out; + &data->scsi_host.wwpn) < 0) { + if (virGenerateWWN(&data->scsi_host.wwpn) < 0) { + virNodeDeviceReportError(VIR_ERR_INTERNAL_ERROR, + _("no WWPN supplied for '%s', and " + "auto-generation failed"), + def->name); + goto out; + } } ctxt->node = orignode2; diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index ac2c52e..3b3b322 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1100,6 +1100,7 @@ virFileWriteStr; virFindFileInPath; virFormatMacAddr; virGenerateMacAddr; +virGenerateWWN; virGetGroupID; virGetHostname; virGetUserDirectory; diff --git a/src/util/util.c b/src/util/util.c index 6f46d53..e6f4559 100644 --- a/src/util/util.c +++ b/src/util/util.c @@ -1837,6 +1837,26 @@ void virGenerateMacAddr(const unsigned char *prefix, addr[5] = virRandom(256); } +#define QUMRANET_OUI "001a4a" + +int virGenerateWWN(char **wwn) { + int suffix[5]; + + suffix[0] = virRandom(16); + suffix[1] = virRandom(256); + suffix[2] = virRandom(256); + suffix[3] = virRandom(256); + suffix[4] = virRandom(256); + + if (virAsprintf(wwn, "%x%s%x%02x%02x%02x%02x", 0x5, QUMRANET_OUI, + suffix[0], suffix[1], suffix[2], + suffix[3], suffix[4]) < 0) { + virReportOOMError(); + return -1; + } + + return 0; +} int virEnumFromString(const char *const*types, unsigned int ntypes, diff --git a/src/util/util.h b/src/util/util.h index c9c785b..d7a0840 100644 --- a/src/util/util.h +++ b/src/util/util.h @@ -186,6 +186,7 @@ void virFormatMacAddr(const unsigned char *addr, char *str); void virGenerateMacAddr(const unsigned char *prefix, unsigned char *addr); +int virGenerateWWN(char **wwn); int virDiskNameToIndex(const char* str); char *virIndexToDiskName(int idx, const char *prefix); -- 1.7.7.3

1 0

[libvirt] [test-API][PATCH] Add domain event type "Shutdown"
by Wayne Sun 10 Jan '12

10 Jan '12

* domain have 7 event types, add the missing shutdown type * shutdown only have 1 detail type 'Finished' --- repos/domain/eventhandler.py | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/repos/domain/eventhandler.py b/repos/domain/eventhandler.py index cdbba90..7d8b635 100644 --- a/repos/domain/eventhandler.py +++ b/repos/domain/eventhandler.py @@ -48,16 +48,18 @@ def eventToString(event): "Suspended", "Resumed", "Stopped" ); + "Shutdown" ); return eventStrings[event]; def detailToString(event, detail): eventStrings = ( ( "Added", "Updated" ), - ( "Removed" ), + ( "Removed", ), ( "Booted", "Migrated", "Restored", "Snapshot" ), ( "Paused", "Migrated", "IOError", "Watchdog" ), ( "Unpaused", "Migrated"), ( "Shutdown", "Destroyed", "Crashed", "Migrated", "Saved", "Failed", "Snapshot") + ( "Finished", ) ) return eventStrings[event][detail] -- 1.7.1

2 1

[libvirt] [PATCH] PolicyKit: Check auth before asking client to obtain it
by Jim Fehlig 09 Jan '12

09 Jan '12

I previously mentioned [1] a PolicyKit issue where libvirt would proceed with authentication even though polkit-auth failed: testusr xen134:~> virsh list --all Attempting to obtain authorization for org.libvirt.unix.manage. polkit-grant-helper: given auth type (8 -> yes) is bogus Failed to obtain authorization for org.libvirt.unix.manage. Id Name State ---------------------------------- 0 Domain-0 running - sles11sp1-pv shut off AFAICT, libvirt attempts to obtain a privilege it already has, causing polkit-auth to fail with above message. Instead of calling obtain and then checking auth, IMO the workflow should be for the server to check auth first, and if that fails ask the client to obtain it and check again. This workflow also allows for checking only successful exit of polkit-auth in virConnectAuthGainPolkit(). [1] https://www.redhat.com/archives/libvir-list/2011-December/msg00837.html --- src/libvirt.c | 2 +- src/remote/remote_driver.c | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index feb3ca6..9e04a38 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -119,7 +119,7 @@ static int virConnectAuthGainPolkit(const char *privilege) { cmd = virCommandNewArgList(POLKIT_AUTH, "--obtain", privilege, NULL); if (virCommandRun(cmd, &status) < 0 || - status > 1) + status > 0) goto cleanup; ret = 0; diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 7580477..e28840b 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -3121,6 +3121,14 @@ remoteAuthPolkit (virConnectPtr conn, struct private_data *priv, }; VIR_DEBUG("Client initialize PolicyKit-0 authentication"); + /* Check auth first and if it succeeds we are done. */ + memset (&ret, 0, sizeof ret); + if (call (conn, priv, 0, REMOTE_PROC_AUTH_POLKIT, + (xdrproc_t) xdr_void, (char *)NULL, + (xdrproc_t) xdr_remote_auth_polkit_ret, (char *) &ret) == 0) + goto out; + + /* Auth failed. Ask client to obtain it and check again. */ if (auth && auth->cb) { /* Check if the necessary credential type for PolicyKit is supported */ for (i = 0 ; i < auth->ncredtype ; i++) { @@ -3138,9 +3146,11 @@ remoteAuthPolkit (virConnectPtr conn, struct private_data *priv, } } else { VIR_DEBUG("Client auth callback does not support PolicyKit"); + return -1; } } else { VIR_DEBUG("No auth callback provided"); + return -1; } memset (&ret, 0, sizeof ret); @@ -3150,6 +3160,7 @@ remoteAuthPolkit (virConnectPtr conn, struct private_data *priv, return -1; /* virError already set by call */ } +out: VIR_DEBUG("PolicyKit-0 authentication complete"); return 0; } -- 1.7.7

3 4

[libvirt] [PATCH 0/2] nwfilter: Compare filters for equality when updating
by Stefan Berger 09 Jan '12

09 Jan '12

When a filter is updated, compare it and the original one for equality so that unnecessary instantiations of rules can be avoided. Regards, Stefan

1 2

[libvirt] ANNOUNCE: libvirt Perl binding Sys::Virt, release 0.9.9
by Daniel P. Berrange 09 Jan '12

09 Jan '12

I'm happy to announce that the libvirt Perl binding, Sys::Virt, release 0.9.9 is now available for download: http://search.cpan.org/CPAN/authors/id/D/DA/DANBERR/Sys-Virt-0.9.9.tar.gz In this release 0.9.9: - Add all new APIs in libvirt 0.9.9 - Fix crash in get_hostname - Fix docs typos & nesting screwups - Add example for calculating CPU utilization of host - Update META.yml with correct license info - Add missing dep on Time::HiRes - Convert CHANGES file to Changes & format to comply with Test::CPAN::Changes The module homepage, where online documentation, and historical downloads can be found is: http://search.cpan.org/dist/Sys-Virt/ Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

1 0

[libvirt] [PATCHv2 0/2] qemu: add new disk device='lun' for bus='virtio' & type='block'
by Laine Stump 09 Jan '12

09 Jan '12

This patch series supercedes an earlier series: https://www.redhat.com/archives/libvir-list/2011-December/msg00990.html Just before posting those patches (and leaving for 10 days of holiday), Paolo Bonzini suggested an alternate XML representation (noted in that original message), which has since been discussed and agreed on as the proper way to go. These new patches implement that alternate method: <disk type='block' device='disk' dev='/dev/sda'>  <disk type='block' device='lun' dev='/dev/sda'>

5 13

[libvirt] FOSDEM 2012, libvirt related talks
by Daniel P. Berrange 09 Jan '12

09 Jan '12

As Mark mentioned [1] a month or 2 back, there is a dedicated Virt & Cloud dev room at FOSDEM this year. I'm pleased to say that I will be attending, giving a talk titled "Building application sandboxes on top of LXC and KVM with libvirt" At this talk I will be introducing the libvirt-sandbox toolkit that I have been working on recently: http://libvirt.org/git/?p=libvirt-sandbox.git There will also be a talk by Richard Jones on the topic of libguestfs http://libguestfs.org/ and talks by people representing the oVirt & OpenStack projects, both of which use libvirt in their foundations. So it should be an interesting event to attend for people who are interested in open source virtualization technology, in particular libvirt, KVM & LXC . For further information visit the FOSDEM website: http://fosdem.org/2012/ Regards, Daniel [1] https://www.redhat.com/archives/libvir-list/2011-November/msg00575.html -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

1 0