- Devel - libvirt List Archives

[libvirt] [PATCH v2] Cleanup of the quick dirty fix from last week
by Martin Kletzander 29 Feb '12

29 Feb '12

Just a cleanup of commit 32f881c6c42f94da70a3782fe20a058fe3dc39cc. --- src/lxc/lxc_container.c | 17 +++++++++++------ 1 files changed, 11 insertions(+), 6 deletions(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index e93fda5..2282eb0 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -449,8 +449,6 @@ static int lxcContainerMountBasicFS(const char *srcprefix, bool pivotRoot) char *opts = NULL; #if HAVE_SELINUX security_context_t con; -#else - bool con = false; #endif VIR_DEBUG("Mounting basic filesystems %s pivotRoot=%d", NULLSTR(srcprefix), pivotRoot); @@ -511,10 +509,17 @@ static int lxcContainerMountBasicFS(const char *srcprefix, bool pivotRoot) * tmpfs is limited to 64kb, since we only have device nodes in there * and don't want to DOS the entire OS RAM usage */ - if (virAsprintf(&opts, "mode=755,size=65536%s%s%s", - con ? ",context=\"" : "", - con ? (const char *)con : "", - con ? "\"" : "") < 0) { + +#if HAVE_SELINUX + if (con) + ignore_value(virAsprintf(&opts, + "mode=755,size=65536,context=\"%s\"", + (const char *)con)); + else +#endif + opts = strdup("mode=755,size=65536"); + + if (!opts) { virReportOOMError(); goto cleanup; } -- 1.7.3.4

3 2

[libvirt] [PATCH 0/2] Implement sysinfo for PowerPC, improve its behaviour on x86.
by Prerna 29 Feb '12

29 Feb '12

This series of patches implements the following: Patch 1/2 : Implement sysinfo for PowerPC. OnPowerPC, sysinfo is obtained by reading /proc/cpuinfo since dmidecode is not available. Patch 2/2 : Based on Eric's suggestion (http://www.redhat.com/archives/libvir-list/2012-February/msg00509.html) Allow x86 to read host system's processor information from /proc/cpuinfo in the event dmidecode is not available. Changelog: * Patch 1: Rebased and cleanups done. * Patch 2: New. -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

4 10

[libvirt] [PATCH 0/2] qemu: Add pre-migration hook
by Jiri Denemark 29 Feb '12

29 Feb '12

Current dxml parameter of virDomainMigrate{,ToURI}2 requires the caller to have deep knowlege of the environment on the target machine. In some cases, this may be impractical or even impossible to achieve. By adding per-migration hook which may filter incoming domain XML and change it appropriately called during the Prepare phase the destination host may filter incoming domain XMLs and change them to fit local environment. For example, such hook may relocate disk images. The hook is not allowed to make guest-visible changes to a domain XML. Jiri Denemark (2): hooks: Add support for capturing hook output qemu: Add pre-migration hook daemon/libvirtd.c | 6 +++--- docs/hooks.html.in | 35 +++++++++++++++++++++++------------ src/lxc/lxc_driver.c | 6 ++++-- src/qemu/qemu_migration.c | 40 ++++++++++++++++++++++++++++++++++++++++ src/qemu/qemu_process.c | 12 ++++++++---- src/util/hooks.c | 25 ++++++++++++++++++++----- src/util/hooks.h | 3 ++- 7 files changed, 100 insertions(+), 27 deletions(-) -- 1.7.8.5

2 5

[libvirt] [PATCHv2] Error out when using SPICE TLS with spice_tls=0
by Christophe Fergeau 29 Feb '12

29 Feb '12

It's possible to disable SPICE TLS in qemu.conf. When this happens, libvirt ignores any SPICE TLS port or x509 directory that may have been set when it builds the qemu command line to use. However, it's not ignoring the secure channels that may have been set and adds tls-channel arguments to qemu command line. Current qemu versions don't report an error when this happens, and try to use TLS for the specified channels. Before this patch <domain type='kvm'> <name>auto-tls-port</name> <memory>65536</memory> <os> <type arch='x86_64' machine='pc'>hvm</type> </os> <devices> <graphics type='spice' port='5900' tlsPort='-1' autoport='yes' listen='0' ke <listen type='address' address='0'/> <channel name='main' mode='secure'/> <channel name='inputs' mode='secure'/> </graphics> </devices> </domain> generates -spice port=5900,addr=0,disable-ticketing,tls-channel=main,tls-channel=inputs and starts QEMU. After this patch, an error is reported if a TLS port is set in the XML or if secure channels are specified but TLS is disabled in qemu.conf. This is the behaviour the oVirt people (where I spotted this issue) said they would expect. This fixes bug #790436 --- src/qemu/qemu_command.c | 12 +++++++++++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 5a34504..4f3e61e 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -5231,7 +5231,12 @@ qemuBuildCommandLine(virConnectPtr conn, virBufferAsprintf(&opt, "port=%u", def->graphics[0]->data.spice.port); - if (driver->spiceTLS && def->graphics[0]->data.spice.tlsPort != -1) + if (def->graphics[0]->data.spice.tlsPort != -1) + if (!driver->spiceTLS) { + qemuReportError(VIR_ERR_XML_ERROR, + _("spice TLS port set in XML configuration, but TLS is disabled in qemu.conf")); + goto error; + } virBufferAsprintf(&opt, ",tls-port=%u", def->graphics[0]->data.spice.tlsPort); switch (virDomainGraphicsListenGetType(def->graphics[0], 0)) { @@ -5287,6 +5292,11 @@ qemuBuildCommandLine(virConnectPtr conn, int mode = def->graphics[0]->data.spice.channels[i]; switch (mode) { case VIR_DOMAIN_GRAPHICS_SPICE_CHANNEL_MODE_SECURE: + if (!driver->spiceTLS) { + qemuReportError(VIR_ERR_XML_ERROR, + _("spice secure channels set in XML configuration, but TLS is disabled in qemu.conf")); + goto error; + } virBufferAsprintf(&opt, ",tls-channel=%s", virDomainGraphicsSpiceChannelNameTypeToString(i)); break; -- 1.7.7.6

4 4

[libvirt] [PATCH 0/4] libvirt-guests: improve behavior of the guests script
by Peter Krempa 29 Feb '12

29 Feb '12

This patchset tweaks the libvirt guest script to enable parallel shutdown of guests and fix some bugs that appeared through time. Peter Krempa (4): libvirt-guests: Add documentation and clean up to use virsh's improved list libvirt-guests: Don't try to do a managed-save of transient guests libvirt-guests: Check if URI is reachable before launching commands libvirt-guests: Add parallel startup and shutdown of guests tools/libvirt-guests.init.sh | 261 ++++++++++++++++++++++++++++++++++++------ tools/libvirt-guests.sysconf | 10 ++- 2 files changed, 235 insertions(+), 36 deletions(-) -- 1.7.3.4

2 9

[libvirt] [PATCH] storage: fix typo
by Michal Privoznik 29 Feb '12

29 Feb '12

* src/storage/storage_driver.c (storageVolumeWipeInternal): s/ pfitzner33/pfitzner33/. --- src/storage/storage_driver.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 540e5d7..9130a40 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -1937,7 +1937,7 @@ storageVolumeWipeInternal(virStorageVolDefPtr def, alg_char = "pfitzner7"; break; case VIR_STORAGE_VOL_WIPE_ALG_PFITZNER33: - alg_char = " pfitzner33"; + alg_char = "pfitzner33"; break; case VIR_STORAGE_VOL_WIPE_ALG_RANDOM: alg_char = "random"; -- 1.7.3.4

2 2

[libvirt] [PATCH] qemu: Don't emit tls-port spice option if port is -1
by Jiri Denemark 29 Feb '12

29 Feb '12

Bug introduced by commit eda0fc7a. --- src/qemu/qemu_command.c | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 01adf0d..5e0ca95 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -5345,13 +5345,16 @@ qemuBuildCommandLine(virConnectPtr conn, virBufferAsprintf(&opt, "port=%u", def->graphics[0]->data.spice.port); - if (def->graphics[0]->data.spice.tlsPort != -1) + if (def->graphics[0]->data.spice.tlsPort != -1) { if (!driver->spiceTLS) { qemuReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("spice TLS port set in XML configuration, but TLS is disabled in qemu.conf")); + _("spice TLS port set in XML configuration," + " but TLS is disabled in qemu.conf")); goto error; } - virBufferAsprintf(&opt, ",tls-port=%u", def->graphics[0]->data.spice.tlsPort); + virBufferAsprintf(&opt, ",tls-port=%u", + def->graphics[0]->data.spice.tlsPort); + } switch (virDomainGraphicsListenGetType(def->graphics[0], 0)) { case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS: -- 1.7.8.5

3 4

[libvirt] Fwd: Re: [libvirt-users] [need your help] Sys::Virt
by Alex Jia 29 Feb '12

29 Feb '12

Hi all, Anybody has the same experience? Evaggelos need your help. Thanks & Regards, Alex > # uname -a > Linux mylaptop 3.2.7-1-ARCH #1 SMP PREEMPT Tue Feb 21 16:59:04 UTC > 2012 i686 Intel(R) Core(TM)2 CPU T5600 @ 1.83GHz GenuineIntel > GNU/Linux > > # perl -v > This is perl 5, version 14, subversion 2 (v5.14.2) built for > i686-linux-thread-multi > > # libvirt 0.9.10-1 > # libxml-enno-1.02 > # XML-XPathEngine-0.13 > # XML-DOM-XPath-0.14 > # CPAN-Changes-0.18 > > # perl-test-pod-coverage 1.08-2 > # perl-time-hires 1.9725-1 > # perl-xml-xpath 1.13-6 > # perl-test-pod 1.45-1 > > # gcc --version > gcc (GCC) 4.6.2 20120120 (prerelease) > > Plz advice > > Evaggelos Balaskas - Unix System Engineer > http://gr.linkedin.com/in/evaggelosbalaskas -------- Original Message -------- Subject: Re: [libvirt-users] Sys::Virt Date: Sun, 26 Feb 2012 21:59:16 -0500 (EST) From: Alex Jia <ajia(a)redhat.com> To: ebalaskas(a)ebalaskas.gr CC: libvirt-users(a)redhat.com Hi Evaggelos, I used latest libvirt-perl git tree, then compile it on RHEL, however, I haven't met the issue, everything is okay for me, so I want to know your platform and compilation environment. Is it okay to compile latest libvirt-perl for you? % git clone git://libvirt.org/libvirt-perl.git % perl Makefile.PL % make ----- Original Message ----- From: "Evaggelos Balaskas"<ebalaskas(a)ebalaskas.gr> To: libvirt-users(a)redhat.com Sent: Sunday, February 26, 2012 12:59:30 AM Subject: [libvirt-users] Sys::Virt Can anyone help me: $ perl Makefile.PL Checking if your kit is complete... Looks good Writing Makefile for Sys::Virt Writing MYMETA.yml and MYMETA.json $ make /usr/bin/perl "-Iblib/arch" "-Iblib/lib" perl-Sys-Virt.spec.PL perl-Sys-Virt.spec make: *** [perl-Sys-Virt.spec] Segmentation fault make: *** Deleting file `perl-Sys-Virt.spec' Evaggelos Balaskas - Unix System Engineer http://gr.linkedin.com/in/evaggelosbalaskas _______________________________________________ libvirt-users mailing list libvirt-users(a)redhat.com https://www.redhat.com/mailman/listinfo/libvirt-users _______________________________________________ libvirt-users mailing list libvirt-users(a)redhat.com https://www.redhat.com/mailman/listinfo/libvirt-users

1 0

[libvirt] [PATCH] docs: comments wiping supported algorithms
by Alex Jia 29 Feb '12

29 Feb '12

The current scrub version doesn't support pfitzner7, pfitzner33 and schneier patterns on RHEL, we should comment it in virsh man page. * tools/virsh.pod: update wiping algorithms docs. Signed-off-by: Alex Jia <ajia(a)redhat.com> --- tools/virsh.pod | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index c306a38..eba9389 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -2081,6 +2081,8 @@ B<Supported algorithms> pfitzner33 - Roy Pfitzner's 33-random-pass method: random x33. random - 1-pass pattern: random. +B<Note>: Not all algorithms of wiping are expected to work, it depends on concrete B<srub> version. + =item B<vol-dumpxml> [I<--pool> I<pool-or-uuid>] I<vol-name-or-key-or-path> Output the volume information as an XML dump to stdout. -- 1.7.1

3 5

[libvirt] [PATCH] util: fix a typo
by Alex Jia 29 Feb '12

29 Feb '12

* src/util/event_poll.c: (virEventPollRunOnce): s/imeout/timeout/. Signed-off-by: Alex Jia <ajia(a)redhat.com> --- src/util/event_poll.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/util/event_poll.c b/src/util/event_poll.c index 30dec74..038e75f 100644 --- a/src/util/event_poll.c +++ b/src/util/event_poll.c @@ -615,7 +615,7 @@ int virEventPollRunOnce(void) { retry: PROBE(EVENT_POLL_RUN, - "nhandles=%d imeout=%d", + "nhandles=%d timeout=%d", nfds, timeout); ret = poll(fds, nfds, timeout); if (ret < 0) { -- 1.7.1

2 2