- Devel - libvirt List Archives

[libvirt] [PATCH] test: fix segfault in networkxml2argvtest
by Laine Stump 05 Apr '12

05 Apr '12

This bug resolves https://bugzilla.redhat.com/show_bug.cgi?id=810100 rpm builds for i686 were failing with a segfault in networkxml2argvtest. Running under valgrind showed that a region of memory was being referenced after it had been freed (as the result of realloc - see the valgrind report in the BZ). The problem (in replaceTokens() - added in commit 22ec60, meaning this bug was in 0.9.10 and 0.9.11) was that the pointers token_start and token_end were being computed based on the value of *buf, then *buf was being realloc'ed (potentially moving it), then token_start and token_end were used without recomputing them to account for movement of *buf. The solution is to change the code so that token_start and token_end are offsets into *buf rather than pointers. This way there is only a single pointer to the buffer, and nothing needs readjusting after a realloc. (You may note that some uses of token_start/token_end didn't need to be changed to add in "*buf +" - that's because there ended up being a +*buf and -*buf which canceled each other out). DV gets the credit for finding this bug and pointing out the valgrind report. --- tests/networkxml2argvtest.c | 13 +++++++------ 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/tests/networkxml2argvtest.c b/tests/networkxml2argvtest.c index cf00181..87519e4 100644 --- a/tests/networkxml2argvtest.c +++ b/tests/networkxml2argvtest.c @@ -18,18 +18,19 @@ /* Replace all occurrences of @token in @buf by @replacement and adjust size of * @buf accordingly. Returns 0 on success and -1 on out-of-memory errors. */ static int replaceTokens(char **buf, const char *token, const char *replacement) { - char *token_start, *token_end; + size_t token_start, token_end; size_t buf_len, rest_len; const size_t token_len = strlen(token); const size_t replacement_len = strlen(replacement); const int diff = replacement_len - token_len; buf_len = rest_len = strlen(*buf) + 1; - token_end = *buf; + token_end = 0; for (;;) { - token_start = strstr(token_end, token); - if (token_start == NULL) + char *match = strstr(*buf + token_end, token); + if (match == NULL) break; + token_start = match - *buf; rest_len -= token_start + token_len - token_end; token_end = token_start + token_len; buf_len += diff; @@ -37,8 +38,8 @@ static int replaceTokens(char **buf, const char *token, const char *replacement) if (VIR_REALLOC_N(*buf, buf_len) < 0) return -1; if (diff != 0) - memmove(token_end + diff, token_end, rest_len); - memcpy(token_start, replacement, replacement_len); + memmove(*buf + token_end + diff, *buf + token_end, rest_len); + memcpy(*buf + token_start, replacement, replacement_len); token_end += diff; } /* if diff < 0, we could shrink the buffer here... */ -- 1.7.7.6

3 2

[libvirt] [test-API] RFC: Stabilization of libvirt-test-API
by Martin Kletzander 05 Apr '12

05 Apr '12

Hi everyone, following our minutes, I'd like to start a discussion on what should be done with libvirt-test-API so we can say it's stable and usable. I would like to stress out that everything mentioned here is just an opinion and I don't mean to talk down to someone as it may have seemed earlier. I think we should get some ideas from everyone, mostly QE as they will be (are) the ones using this the most (if I understood correctly), and then I'll be happy to help getting the code to the agreed status. I was thinking about this from the wrong way probably and changing the angle from what I look at it (and knowing there is some deadline) makes me think of few levels of changes, which when introduced, could speed up the test development and code understandability. So here are the things I would like to do definitely (the optional things follow later on): - fix hard-coded options into real options (e.g. commit 65449e) - fix some env_* and util* code (functions duplicated with different behavior) - fix or remove harmful and pointless code (at this point, when creating domain on remote machine, be prepared for the test to fail with any other user then root and with root, have backup of both local and remote '/root/.ssh' directories as the contents will be erased!) - fix method names for the {connect,domain,etc.}API (get_host_name vs. lookupByUUID etc.) The optional things: - get rid of classes in lib and make just few utility functions covering *only* the methods that do something else than call the same method in underlying class from the libvirt module. - get rid of the new exception (I don't see any other difference than in the name, which can make a difference in "except:" clause, but it's converted everywhere) - be able to share variables between tests (connection object and anything else) - introduce new config file for tests (.ini format, can be parsed by ConfigParser, same as env.cfg, define variables used throughout the test specifications - update the documentation - use some python code style (PEP-8?), make use of True/False, None - eliminate duplicated (and x-plicated) code (append_path in all the files, etc.) I have all of these figured out, so I'm willing to discuss all of them, but in most cases changing it in the current code seems very time-consumable to me. Please, feel free to comment on any of these, add yours, discuss, shout at me, etc. =) Regards, Martin P.S.: I don't see any point in sending my patches until some of these points are resolved as that could mean rewriting more code.

5 10

[libvirt] [PATCH 1/3] Move linux specific symbol to src/libvirt_linux.syms
by Daniel P. Berrange 05 Apr '12

05 Apr '12

From: "Daniel P. Berrange" <berrange(a)redhat.com> linuxNodeInfoCPUPopulate is not built on Mingw32 so should be in libvirt_linux.syms, not libvirt_private.syms Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- src/libvirt_linux.syms | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/libvirt_linux.syms b/src/libvirt_linux.syms index 018c892..2258739 100644 --- a/src/libvirt_linux.syms +++ b/src/libvirt_linux.syms @@ -6,3 +6,6 @@ # stats_linux.h linuxDomainInterfaceStats; xenLinuxDomainBlockStats; + +# nodeinfo.h +linuxNodeInfoCPUPopulate; -- 1.7.7.6

4 9

[libvirt] [PATCH V2] nwfilter: Add support for ipset
by Stefan Berger 05 Apr '12

05 Apr '12

This patch adds support for the recent ipset iptables extension to libvirt's nwfilter subsystem. Ipset allows to maintain 'sets' of IP addresses, ports and other packet parameters and allows for faster lookup (in the order of O(1) vs. O(n)) and rule evaluation to achieve higher throughput than what can be achieved with individual iptables rules. On the command line iptables supports ipset using iptables ... -m set --match-set <ipset name> <flags> -j ... where 'ipset name' is the name of a previously created ipset and flags is a comma-separated list of up to 6 flags. Flags use 'src' and 'dst' for selecting IP addresses, ports etc. from the source or destination part of a packet. So a concrete example may look like this: iptables -A INPUT -m set --match-set test src,src -j ACCEPT Since ipset management is quite complex, the idea was to leave ipset management outside of libvirt but still allow users to reference an ipset. The user would have to make sure the ipset is available once the VM is started so that the iptables rule(s) referencing the ipset can be created. Using XML to describe an ipset in an nwfilter rule would then look as follows: <rule action='accept' direction='in'> <all ipset='test' ipsetflags='src,src'/> </rule> The two parameters on the command line are also the two distinct XML attributes 'ipset' and 'ipsetflags'. FYI: Here is the man page for ipset: https://ipset.netfilter.org/ipset.man.html Regards, Stefan --- v2: - split ipset description into ipset and ipsetflags attribute - improved on documentation --- docs/formatnwfilter.html.in | 64 ++++++++++++++ docs/schemas/nwfilter.rng | 23 +++++ src/conf/nwfilter_conf.c | 135 +++++++++++++++++++++++++++++- src/conf/nwfilter_conf.h | 12 ++ src/nwfilter/nwfilter_ebiptables_driver.c | 71 +++++++++++++++ tests/nwfilterxml2xmlin/ipset-test.xml | 15 +++ tests/nwfilterxml2xmlout/ipset-test.xml | 15 +++ tests/nwfilterxml2xmltest.c | 2 8 files changed, 332 insertions(+), 5 deletions(-) Index: libvirt/src/conf/nwfilter_conf.c =================================================================== --- libvirt.orig/src/conf/nwfilter_conf.c +++ libvirt/src/conf/nwfilter_conf.c @@ -183,6 +183,8 @@ static const char dstportstart_str[] = " static const char dstportend_str[] = "dstportend"; static const char dscp_str[] = "dscp"; static const char state_str[] = "state"; +static const char ipset_str[] = "ipset"; +static const char ipsetflags_str[] = "ipsetflags"; #define SRCMACADDR srcmacaddr_str #define SRCMACMASK srcmacmask_str @@ -206,6 +208,8 @@ static const char state_str[] = " #define DSTPORTEND dstportend_str #define DSCP dscp_str #define STATE state_str +#define IPSET ipset_str +#define IPSETFLAGS ipsetflags_str /** @@ -980,6 +984,97 @@ tcpFlagsFormatter(virBufferPtr buf, return true; } +static bool +ipsetValidator(enum attrDatatype datatype ATTRIBUTE_UNUSED, union data *val, + virNWFilterRuleDefPtr nwf ATTRIBUTE_UNUSED, + nwItemDesc *item) +{ + const char *errmsg = NULL; + + if (virStrcpy(item->u.ipset.setname, val->c, + sizeof(item->u.ipset.setname)) == NULL) { + errmsg = _("ipset name is too long"); + goto arg_err_exit; + } + + if (item->u.ipset.setname[strspn(item->u.ipset.setname, + VALID_IPSETNAME)] != 0) { + errmsg = _("ipset name contains invalid characters"); + goto arg_err_exit; + } + + return true; + +arg_err_exit: + virNWFilterReportError(VIR_ERR_INVALID_ARG, + "%s", errmsg); + return false; +} + +static bool +ipsetFormatter(virBufferPtr buf, + virNWFilterRuleDefPtr nwf ATTRIBUTE_UNUSED, + nwItemDesc *item) +{ + virBufferAdd(buf, item->u.ipset.setname, -1); + + return true; +} + +static bool +ipsetFlagsValidator(enum attrDatatype datatype ATTRIBUTE_UNUSED, union data *val, + virNWFilterRuleDefPtr nwf ATTRIBUTE_UNUSED, nwItemDesc *item) +{ + const char *errmsg = NULL; + size_t idx = 0; + + item->u.ipset.numFlags = 0; + item->u.ipset.flags = 0; + + errmsg = _("malformed ipset flags"); + + while (item->u.ipset.numFlags < 6) { + if (STRCASEEQLEN(&val->c[idx], "src", 3)) { + item->u.ipset.flags |= (1 << item->u.ipset.numFlags); + } else if (!STRCASEEQLEN(&val->c[idx], "dst", 3)) { + goto arg_err_exit; + } + item->u.ipset.numFlags++; + idx += 3; + if (val->c[idx] != ',') + break; + idx++; + } + + if (val->c[idx] != '\0') + goto arg_err_exit; + + return true; + +arg_err_exit: + virNWFilterReportError(VIR_ERR_INVALID_ARG, + "%s", errmsg); + return false; +} + +static bool +ipsetFlagsFormatter(virBufferPtr buf, + virNWFilterRuleDefPtr nwf ATTRIBUTE_UNUSED, + nwItemDesc *item) +{ + uint8_t ctr; + + for (ctr = 0; ctr < item->u.ipset.numFlags; ctr++) { + if (ctr != 0) + virBufferAddLit(buf, ","); + if ((item->u.ipset.flags & (1 << ctr))) + virBufferAddLit(buf, "src"); + else + virBufferAddLit(buf, "dst"); + } + + return true; +} #define COMMON_MAC_PROPS(STRUCT) \ {\ @@ -1411,6 +1506,20 @@ static const virXMLAttr2Struct ipv6Attri .dataIdx = offsetof(virNWFilterRuleDef, p.STRUCT.ipHdr.dataState),\ .validator = stateValidator,\ .formatter = stateFormatter,\ + },\ + {\ + .name = IPSET,\ + .datatype = DATATYPE_STRING,\ + .dataIdx = offsetof(virNWFilterRuleDef, p.STRUCT.ipHdr.dataIPSet),\ + .validator = ipsetValidator,\ + .formatter = ipsetFormatter,\ + },\ + {\ + .name = IPSETFLAGS,\ + .datatype = DATATYPE_IPSETFLAGS,\ + .dataIdx = offsetof(virNWFilterRuleDef, p.STRUCT.ipHdr.dataIPSetFlags),\ + .validator = ipsetFlagsValidator,\ + .formatter = ipsetFlagsFormatter,\ } #define COMMON_PORT_PROPS(STRUCT) \ @@ -1853,6 +1962,7 @@ virNWFilterRuleDetailsParse(xmlNodePtr n break; case DATATYPE_STRING: + case DATATYPE_IPSETFLAGS: if (!validator) { /* not supported */ rc = -1; @@ -1964,6 +2074,19 @@ err_exit: goto cleanup; } +static void +virNWFilterRuleDefFixupIPSet(ipHdrDataDefPtr ipHdr) +{ + if (HAS_ENTRY_ITEM(&ipHdr->dataIPSet) && + !HAS_ENTRY_ITEM(&ipHdr->dataIPSetFlags)) { + ipHdr->dataIPSetFlags.flags = NWFILTER_ENTRY_ITEM_FLAG_EXISTS; + ipHdr->dataIPSetFlags.u.ipset.numFlags = 1; + ipHdr->dataIPSetFlags.u.ipset.flags = 1; + } else { + ipHdr->dataIPSet.flags = 0; + ipHdr->dataIPSetFlags.flags = 0; + } +} static void virNWFilterRuleDefFixup(virNWFilterRuleDefPtr rule) @@ -2017,6 +2140,7 @@ virNWFilterRuleDefFixup(virNWFilterRuleD rule->p.ipHdrFilter.ipHdr.dataSrcIPAddr); COPY_NEG_SIGN(rule->p.ipHdrFilter.ipHdr.dataDstIPMask, rule->p.ipHdrFilter.ipHdr.dataDstIPAddr); + virNWFilterRuleDefFixupIPSet(&rule->p.ipHdrFilter.ipHdr); break; case VIR_NWFILTER_RULE_PROTOCOL_IPV6: @@ -2024,6 +2148,7 @@ virNWFilterRuleDefFixup(virNWFilterRuleD rule->p.ipv6HdrFilter.ipHdr.dataSrcIPAddr); COPY_NEG_SIGN(rule->p.ipv6HdrFilter.ipHdr.dataDstIPMask, rule->p.ipv6HdrFilter.ipHdr.dataDstIPAddr); + virNWFilterRuleDefFixupIPSet(&rule->p.ipv6HdrFilter.ipHdr); break; case VIR_NWFILTER_RULE_PROTOCOL_ARP: @@ -2047,6 +2172,7 @@ virNWFilterRuleDefFixup(virNWFilterRuleD rule->p.tcpHdrFilter.portData.dataSrcPortStart); COPY_NEG_SIGN(rule->p.tcpHdrFilter.portData.dataDstPortEnd, rule->p.tcpHdrFilter.portData.dataSrcPortStart); + virNWFilterRuleDefFixupIPSet(&rule->p.tcpHdrFilter.ipHdr); break; case VIR_NWFILTER_RULE_PROTOCOL_UDP: @@ -2065,6 +2191,7 @@ virNWFilterRuleDefFixup(virNWFilterRuleD rule->p.udpHdrFilter.portData.dataSrcPortStart); COPY_NEG_SIGN(rule->p.udpHdrFilter.portData.dataDstPortEnd, rule->p.udpHdrFilter.portData.dataSrcPortStart); + virNWFilterRuleDefFixupIPSet(&rule->p.udpHdrFilter.ipHdr); break; case VIR_NWFILTER_RULE_PROTOCOL_UDPLITE: @@ -2077,6 +2204,7 @@ virNWFilterRuleDefFixup(virNWFilterRuleD rule->p.udpliteHdrFilter.ipHdr.dataSrcIPFrom); COPY_NEG_SIGN(rule->p.udpliteHdrFilter.ipHdr.dataDstIPTo, rule->p.udpliteHdrFilter.ipHdr.dataDstIPFrom); + virNWFilterRuleDefFixupIPSet(&rule->p.udpliteHdrFilter.ipHdr); break; case VIR_NWFILTER_RULE_PROTOCOL_ESP: @@ -2089,6 +2217,7 @@ virNWFilterRuleDefFixup(virNWFilterRuleD rule->p.espHdrFilter.ipHdr.dataSrcIPFrom); COPY_NEG_SIGN(rule->p.espHdrFilter.ipHdr.dataDstIPTo, rule->p.espHdrFilter.ipHdr.dataDstIPFrom); + virNWFilterRuleDefFixupIPSet(&rule->p.espHdrFilter.ipHdr); break; case VIR_NWFILTER_RULE_PROTOCOL_AH: @@ -2101,6 +2230,7 @@ virNWFilterRuleDefFixup(virNWFilterRuleD rule->p.ahHdrFilter.ipHdr.dataSrcIPFrom); COPY_NEG_SIGN(rule->p.ahHdrFilter.ipHdr.dataDstIPTo, rule->p.ahHdrFilter.ipHdr.dataDstIPFrom); + virNWFilterRuleDefFixupIPSet(&rule->p.ahHdrFilter.ipHdr); break; case VIR_NWFILTER_RULE_PROTOCOL_SCTP: @@ -2119,6 +2249,7 @@ virNWFilterRuleDefFixup(virNWFilterRuleD rule->p.sctpHdrFilter.portData.dataSrcPortStart); COPY_NEG_SIGN(rule->p.sctpHdrFilter.portData.dataDstPortEnd, rule->p.sctpHdrFilter.portData.dataSrcPortStart); + virNWFilterRuleDefFixupIPSet(&rule->p.sctpHdrFilter.ipHdr); break; case VIR_NWFILTER_RULE_PROTOCOL_ICMP: @@ -2133,6 +2264,7 @@ virNWFilterRuleDefFixup(virNWFilterRuleD rule->p.icmpHdrFilter.ipHdr.dataDstIPFrom); COPY_NEG_SIGN(rule->p.icmpHdrFilter.dataICMPCode, rule->p.icmpHdrFilter.dataICMPType); + virNWFilterRuleDefFixupIPSet(&rule->p.icmpHdrFilter.ipHdr); break; case VIR_NWFILTER_RULE_PROTOCOL_ALL: @@ -2156,6 +2288,7 @@ virNWFilterRuleDefFixup(virNWFilterRuleD rule->p.igmpHdrFilter.ipHdr.dataSrcIPFrom); COPY_NEG_SIGN(rule->p.igmpHdrFilter.ipHdr.dataDstIPTo, rule->p.igmpHdrFilter.ipHdr.dataDstIPFrom); + virNWFilterRuleDefFixupIPSet(&rule->p.igmpHdrFilter.ipHdr); break; case VIR_NWFILTER_RULE_PROTOCOL_LAST: @@ -3120,7 +3253,7 @@ virNWFilterRuleDefDetailsFormat(virBuffe virBufferAsprintf(buf, " %s='", att[i].name); - if (att[i].formatter) { + if (att[i].formatter && !(flags & NWFILTER_ENTRY_ITEM_FLAG_HAS_VAR)) { if (!att[i].formatter(buf, def, item)) { virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, _("formatter for %s %s reported error"), Index: libvirt/src/conf/nwfilter_conf.h =================================================================== --- libvirt.orig/src/conf/nwfilter_conf.h +++ libvirt/src/conf/nwfilter_conf.h @@ -103,8 +103,9 @@ enum attrDatatype { DATATYPE_BOOLEAN = (1 << 12), DATATYPE_UINT32 = (1 << 13), DATATYPE_UINT32_HEX = (1 << 14), + DATATYPE_IPSETFLAGS = (1 << 15), - DATATYPE_LAST = (1 << 15), + DATATYPE_LAST = (1 << 16), }; # define NWFILTER_MAC_BGA "01:80:c2:00:00:00" @@ -136,9 +137,16 @@ struct _nwItemDesc { uint8_t mask; uint8_t flags; } tcpFlags; + struct { + char setname[32]; + uint8_t numFlags; + uint8_t flags; + } ipset; } u; }; +# define VALID_IPSETNAME \ + "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789_.:-+ " typedef struct _ethHdrDataDef ethHdrDataDef; typedef ethHdrDataDef *ethHdrDataDefPtr; @@ -232,6 +240,8 @@ struct _ipHdrDataDef { nwItemDesc dataState; nwItemDesc dataConnlimitAbove; nwItemDesc dataComment; + nwItemDesc dataIPSet; + nwItemDesc dataIPSetFlags; }; Index: libvirt/src/nwfilter/nwfilter_ebiptables_driver.c =================================================================== --- libvirt.orig/src/nwfilter/nwfilter_ebiptables_driver.c +++ libvirt/src/nwfilter/nwfilter_ebiptables_driver.c @@ -256,10 +256,13 @@ static int _printDataType(virNWFilterVarCombIterPtr vars, char *buf, int bufsize, nwItemDescPtr item, - bool asHex) + bool asHex, bool directionIn) { int done; char *data; + uint8_t ctr; + virBuffer vb = VIR_BUFFER_INITIALIZER; + char *flags; if (printVar(vars, buf, bufsize, item, &done) < 0) return -1; @@ -346,6 +349,40 @@ _printDataType(virNWFilterVarCombIterPtr } break; + case DATATYPE_IPSETFLAGS: + for (ctr = 0; ctr < item->u.ipset.numFlags; ctr++) { + if (ctr != 0) + virBufferAddLit(&vb, ","); + if ((item->u.ipset.flags & (1 << ctr))) { + if (directionIn) + virBufferAddLit(&vb, "dst"); + else + virBufferAddLit(&vb, "src"); + } else { + if (directionIn) + virBufferAddLit(&vb, "src"); + else + virBufferAddLit(&vb, "dst"); + } + } + + if (virBufferError(&vb)) { + virReportOOMError(); + virBufferFreeAndReset(&vb); + return -1; + } + + flags = virBufferContentAndReset(&vb); + + if (snprintf(buf, bufsize, "%s", flags) >= bufsize) { + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("Buffer too small for IPSETFLAGS type")); + VIR_FREE(flags); + return -1; + } + VIR_FREE(flags); + break; + default: virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, _("Unhandled datatype %x"), item->datatype); @@ -362,16 +399,23 @@ printDataType(virNWFilterVarCombIterPtr char *buf, int bufsize, nwItemDescPtr item) { - return _printDataType(vars, buf, bufsize, item, 0); + return _printDataType(vars, buf, bufsize, item, 0, 0); } +static int +printDataTypeDirection(virNWFilterVarCombIterPtr vars, + char *buf, int bufsize, + nwItemDescPtr item, bool directionIn) +{ + return _printDataType(vars, buf, bufsize, item, 0, directionIn); +} static int printDataTypeAsHex(virNWFilterVarCombIterPtr vars, char *buf, int bufsize, nwItemDescPtr item) { - return _printDataType(vars, buf, bufsize, item, 1); + return _printDataType(vars, buf, bufsize, item, 1, 0); } @@ -927,6 +971,7 @@ iptablesHandleIpHdr(virBufferPtr buf, char ipaddr[INET6_ADDRSTRLEN], number[MAX(INT_BUFSIZE_BOUND(uint32_t), INT_BUFSIZE_BOUND(int))]; + char str[200]; const char *src = "--source"; const char *dst = "--destination"; const char *srcrange = "--src-range"; @@ -938,6 +983,26 @@ iptablesHandleIpHdr(virBufferPtr buf, dstrange = "--src-range"; } + if (HAS_ENTRY_ITEM(&ipHdr->dataIPSet) && + HAS_ENTRY_ITEM(&ipHdr->dataIPSetFlags)) { + + if (printDataType(vars, + str, sizeof(str), + &ipHdr->dataIPSet) < 0) + goto err_exit; + + virBufferAsprintf(afterStateMatch, + " -m set --match-set \"%s\" ", + str); + + if (printDataTypeDirection(vars, + str, sizeof(str), + &ipHdr->dataIPSetFlags, directionIn) < 0) + goto err_exit; + + virBufferAdd(afterStateMatch, str, -1); + } + if (HAS_ENTRY_ITEM(&ipHdr->dataSrcIPAddr)) { if (printDataType(vars, Index: libvirt/docs/schemas/nwfilter.rng =================================================================== --- libvirt.orig/docs/schemas/nwfilter.rng +++ libvirt/docs/schemas/nwfilter.rng @@ -485,6 +485,14 @@ <ref name="stateflags-type"/> </attribute> </optional> + <optional> + <attribute name="ipset"> + <ref name="ipset-type"/> + </attribute> + <attribute name="ipsetflags"> + <ref name="ipsetflags-type"/> + </attribute> + </optional> </interleave> </define> @@ -1060,4 +1068,19 @@ <param name="pattern">((SYN|ACK|URG|PSH|FIN|RST)(,(SYN|ACK|URG|PSH|FIN|RST))*|ALL|NONE)/((SYN|ACK|URG|PSH|FIN|RST)(,(SYN|ACK|URG|PSH|FIN|RST))*|ALL|NONE)</param> </data> </define> + + <define name='ipset-type'> + <choice> + <ref name="variable-name-type"/> + <data type="string"> + <param name="pattern">[a-zA-Z0-9_\.:\-\+]{1,31}</param> + </data> + </choice> + </define> + + <define name='ipsetflags-type'> + <data type="string"> + <param name="pattern">(src|dst)(,(src|dst)){0,5}</param> + </data> + </define> </grammar> Index: libvirt/tests/nwfilterxml2xmlin/ipset-test.xml =================================================================== --- /dev/null +++ libvirt/tests/nwfilterxml2xmlin/ipset-test.xml @@ -0,0 +1,15 @@ +<filter name='testcase' chain='root'> + <uuid>5c6d49af-b071-6127-b4ec-6f8ed4b55335</uuid> + <rule action='accept' direction='out'> + <all ipset='test' ipsetflags='src,dst' /> + </rule> + <rule action='accept' direction='in'> + <all ipset='test' ipsetflags='SRC,DST,SRC' /> + </rule> + <rule action='accept' direction='in'> + <all ipset='test:_.-+' ipsetflags='SRC,dSt,SRC' /> + </rule> + <rule action='accept' direction='in'> + <all ipset='$IPSETNAME' ipsetflags='src,dst' /> + </rule> +</filter> Index: libvirt/tests/nwfilterxml2xmlout/ipset-test.xml =================================================================== --- /dev/null +++ libvirt/tests/nwfilterxml2xmlout/ipset-test.xml @@ -0,0 +1,15 @@ +<filter name='testcase' chain='root'> + <uuid>5c6d49af-b071-6127-b4ec-6f8ed4b55335</uuid> + <rule action='accept' direction='out' priority='500'> + <all ipset='test' ipsetflags='src,dst'/> + </rule> + <rule action='accept' direction='in' priority='500'> + <all ipset='test' ipsetflags='src,dst,src'/> + </rule> + <rule action='accept' direction='in' priority='500'> + <all ipset='test:_.-+' ipsetflags='src,dst,src'/> + </rule> + <rule action='accept' direction='in' priority='500'> + <all ipset='$IPSETNAME' ipsetflags='src,dst'/> + </rule> +</filter> Index: libvirt/tests/nwfilterxml2xmltest.c =================================================================== --- libvirt.orig/tests/nwfilterxml2xmltest.c +++ libvirt/tests/nwfilterxml2xmltest.c @@ -157,6 +157,8 @@ mymain(void) DO_TEST("iter-test2", false); DO_TEST("iter-test3", false); + DO_TEST("ipset-test", false); + return ret==0 ? EXIT_SUCCESS : EXIT_FAILURE; } Index: libvirt/docs/formatnwfilter.html.in =================================================================== --- libvirt.orig/docs/formatnwfilter.html.in +++ libvirt/docs/formatnwfilter.html.in @@ -528,6 +528,10 @@ <li>IPV6_MASK: IPv6 mask in numbers format (FFFF:FFFF:FC00::) or CIDR mask (0-128)</li> <li>STRING: A string</li> <li>BOOLEAN: 'true', 'yes', '1' or 'false', 'no', '0'</li> + <li>IPSETFLAGS: The source and destination flags of the ipset described + by up to 6 'src' or 'dst' elements selecting features from either + the source or destination part of the packet header; example: + src,src,dst</li> </ul> @@ -1169,6 +1173,16 @@ <td>STRING</td> <td>TCP-only: format of mask/flags with mask and flags each being a comma separated list of SYN,ACK,URG,PSH,FIN,RST or NONE or ALL</td> </tr> + <tr> + <td>ipset (Since 0.9.11)</td> + <td>STRING</td> + <td>The name of an IPSet managed outside of libvirt</td> + </tr> + <tr> + <td>ipsetflags (Since 0.9.11)</td> + <td>IPSETFLAGS</td> + <td>flags for the IPSet; requires ipset attributed</td> + </tr> </table> @@ -1269,6 +1283,16 @@ <td>STRING</td> <td>comma separated list of NEW,ESTABLISHED,RELATED,INVALID or NONE</td> </tr> + <tr> + <td>ipset (Since 0.9.11)</td> + <td>STRING</td> + <td>The name of an IPSet managed outside of libvirt</td> + </tr> + <tr> + <td>ipsetflags (Since 0.9.11)</td> + <td>IPSETFLAGS</td> + <td>flags for the IPSet; requires ipset attributed</td> + </tr> </table> @@ -1358,6 +1382,16 @@ <td>STRING</td> <td>comma separated list of NEW,ESTABLISHED,RELATED,INVALID or NONE</td> </tr> + <tr> + <td>ipset (Since 0.9.11)</td> + <td>STRING</td> + <td>The name of an IPSet managed outside of libvirt</td> + </tr> + <tr> + <td>ipsetflags (Since 0.9.11)</td> + <td>IPSETFLAGS</td> + <td>flags for the IPSet; requires ipset attributed</td> + </tr> </table> @@ -1459,6 +1493,16 @@ <td>STRING</td> <td>TCP-only: format of mask/flags with mask and flags each being a comma separated list of SYN,ACK,URG,PSH,FIN,RST or NONE or ALL</td> </tr> + <tr> + <td>ipset (Since 0.9.11)</td> + <td>STRING</td> + <td>The name of an IPSet managed outside of libvirt</td> + </tr> + <tr> + <td>ipsetflags (Since 0.9.11)</td> + <td>IPSETFLAGS</td> + <td>flags for the IPSet; requires ipset attributed</td> + </tr> </table> @@ -1545,6 +1589,16 @@ <td>STRING</td> <td>comma separated list of NEW,ESTABLISHED,RELATED,INVALID or NONE</td> </tr> + <tr> + <td>ipset (Since 0.9.11)</td> + <td>STRING</td> + <td>The name of an IPSet managed outside of libvirt</td> + </tr> + <tr> + <td>ipsetflags (Since 0.9.11)</td> + <td>IPSETFLAGS</td> + <td>flags for the IPSet; requires ipset attributed</td> + </tr> </table> @@ -1619,6 +1673,16 @@ <td>STRING</td> <td>comma separated list of NEW,ESTABLISHED,RELATED,INVALID or NONE</td> </tr> + <tr> + <td>ipset (Since 0.9.11)</td> + <td>STRING</td> + <td>The name of an IPSet managed outside of libvirt</td> + </tr> + <tr> + <td>ipsetflags (Since 0.9.11)</td> + <td>IPSETFLAGS</td> + <td>flags for the IPSet; requires ipset attributed</td> + </tr> </table>

1 0

[libvirt] patch for openvz driver to support vzctl 3.1
by Ilja Livenson 04 Apr '12

04 Apr '12

Hi, there was a recent update of vzctl from openvz, which made openvz driver crash: https://www.redhat.com/archives/libvirt-users/2012-March/msg00203.html Not sure about the correct procedure, but the patch is very simple and is shown here: https://bugzilla.redhat.com/show_bug.cgi?id=809895 . Basically, openvz dropped strict version numbering (3.1 vs 3.1.0), which caused parsing to fail. cheers, Ilya

2 1

[libvirt] problems starting several qemu VMS simultaneously
by Serge Hallyn 04 Apr '12

04 Apr '12

Hi, I grabbed today's git head of libvirt. Created a VM (clean install of ubuntu oneiric, installed through virt-manager), and cloned it 3 times. Then I did serge@ubuntu:~$ for i in `seq 1 4`; do virsh start o$i > /tmp/o$i 2>&1 & done [1] 12184 [2] 12185 [3] 12186 [4] 12187 serge@ubuntu:~$ virsh list error: Failed to list active domains error: End of file while reading data: Input/output error serge@ubuntu:~$ virsh list Id Name State ---------------------------------------------------- 5 o2 shut off 7 o3 shut off 8 o4 shut off [1] Exit 1 virsh start o$i > /tmp/o$i 2>&1 [2] Done virsh start o$i > /tmp/o$i 2>&1 serge@ubuntu:~$ virsh list Id Name State ---------------------------------------------------- 5 o2 running 7 o3 running 8 o4 running [3]- Done virsh start o$i > /tmp/o$i 2>&1 [4]+ Done virsh start o$i > /tmp/o$i 2>&1 serge@ubuntu:~$ cat /tmp/o1 error: Failed to start domain o1 error: Unable to wait for child process: Bad file descriptor It's quite reproducible. An ubuntu bug report was filed at https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/961217 It's also very reminiscent of some lxc startup handshake issues which have been fixed. You can find the last chunk of the log file at http://people.canonical.com/~serge/libvirtd-parallel-startup.log -serge

2 4

[libvirt] [PATCH] Don't install sysctl file on non-Linux hosts
by Daniel P. Berrange 04 Apr '12

04 Apr '12

From: "Daniel P. Berrange" <berrange(a)redhat.com> * configure.ac: Set WITH_SYSCTL only on Linux hosts * daemon/Makefile.am: Conditionalize install-sysctl using WITH_SYSCTL Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> Cc: Jason Helfman <jhelfman(a)e-e.com> --- configure.ac | 25 +++++++++++++++++++++++++ daemon/Makefile.am | 5 +++++ 2 files changed, 30 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index 0e83019..3f5b3ff 100644 --- a/configure.ac +++ b/configure.ac @@ -403,6 +403,31 @@ AM_CONDITIONAL([LIBVIRT_INIT_SCRIPT_UPSTART], test "$init_upstart" = "yes") AM_CONDITIONAL([LIBVIRT_INIT_SCRIPT_SYSTEMD], test "$init_systemd" = "yes") AC_MSG_RESULT($with_init_script) + +AC_MSG_CHECKING([for whether to install sysctl config]) +AC_ARG_WITH([sysctl], + [AC_HELP_STRING([--with-sysctl@<:@=yes/no@:>@], + [Whether to install sysctl configs @<:@default=auto@:>@])], + [],[with_sysctl=check]) + +if test "$with_sysctl" = "yes" || test "$with_sysctl" = "check" +then + case $host in + *-*-linux*) + with_sysctl=yes + ;; + **) + if test "$with_sysctl" = "yes"; then + AC_MSG_ERROR([No sysctl configuration supported for $host]) + else + with_sysctl=no + fi + ;; + esac +fi +AM_CONDITIONAL([WITH_SYSCTL], test "$with_sysctl" = "yes") +AC_MSG_RESULT($with_sysctl) + dnl RHEL-5 has a peculiar version of Xen, which requires some special casing AC_ARG_WITH([rhel5-api], [AC_HELP_STRING([--with-rhel5-api=@<:@ARG@:>@], diff --git a/daemon/Makefile.am b/daemon/Makefile.am index db4abf5..391cd99 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -256,6 +256,7 @@ uninstall-sysconfig: rm -f $(DESTDIR)$(sysconfdir)/sysconfig/libvirtd rmdir $(DESTDIR)$(sysconfdir)/sysconfig || : +if WITH_SYSCTL install-sysctl: $(MKDIR_P) $(DESTDIR)$(sysconfdir)/sysctl.d $(INSTALL_DATA) $(srcdir)/libvirtd.sysctl \ @@ -264,6 +265,10 @@ install-sysctl: uninstall-sysctl: rm -f $(DESTDIR)$(sysconfdir)/sysctl.d/libvirtd rmdir $(DESTDIR)$(sysconfdir)/sysctl.d || : +else +install-sysctl: +uninstall-sysctl: +endif if LIBVIRT_INIT_SCRIPT_RED_HAT -- 1.7.7.6

3 2

[libvirt] [test-API PATCH 0/3] Console tests
by Peter Krempa 04 Apr '12

04 Apr '12

This series adds two tests that check interactions with the domain's console. As a helper the first patch contains a new exception that signalizes a test error other than raised by libvirt. The two tests are not contained in any test cases yet, as they require a specific VM configuration to work correctly. Peter Krempa (3): utils: Add exception for general test errors repo: Add test for mutualy exclusive console access repo: Add test for console input and output operations repos/domain/console_io.py | 76 +++++++++++++++++++++++++++++++++++ repos/domain/console_mutex.py | 89 +++++++++++++++++++++++++++++++++++++++++ utils/Python/testError.py | 26 ++++++++++++ 3 files changed, 191 insertions(+), 0 deletions(-) create mode 100644 repos/domain/console_io.py create mode 100644 repos/domain/console_mutex.py create mode 100644 utils/Python/testError.py -- 1.7.3.4

2 7

[libvirt] Release of libvirt-0.9.11
by Daniel Veillard 04 Apr '12

04 Apr '12

So as stated last week I made the release today. It is available from the ftp: ftp://libvirt.org/libvirt/libvirt-0.9.11.tar.gz along with Fedora 16 rpms I signed. And the release is tagged in the tree so normal development can resume :-) The release is rather big, which is not surprizing since in includes 6 weeks of developments instead of the 4 as usual. BTW considering the rate of the push I still think we should keep a monthly release schedule, this is way higher than most other projects but as long as the people doing the packaging and pushes downstream think it's okay I guess everyone benefits from a shorter cycle (well as long as we don't break API/features !) It is sometime difficult to separate from what to label as an improvement and what to label really as a new feature, in any case there was plenty of both in this release, along with a copious dose of bug fixes: Features: - Add support for the suspend event (Osier Yang) - Add support for event tray moved of removable disks (Osier Yang) - qemu: Support numad (Osier Yang) - cpustats: API, improvements and qemu support (KAMEZAWA Hiroyuki and Eric Blake) - qemu: support type='hostdev' network devices at domain start (Laine Stump) - Introduce virDomainPMWakeup API (Michal Privoznik) - network: support Open vSwitch (Ansis Atteka) - a number of snapshot improvements (Eric Blake) Portability: - build: fix build on cygwin (Eric Blake) - build: fix mingw ssize_t, syntax check (Eric Blake) - Disable build of commandhelper & ssh on Win32 (Daniel P. Berrange) - build: avoid 'devname' for BSD (Eric Blake) - build: avoid frame size error when building without -O2 (Laine Stump) - spec: Add missed dependancy for numad (Osier Yang) - util: fix build mingw (and all non-linux) build failure (Laine Stump) - Build error on OSX in src/util/virnetlink.c (Duncan Rance) - Fix build after commit e3ba4025 (Jim Fehlig) - build: Fix build with dtrace + apparmor (Jiri Denemark) - build: fix output of pid values (Eric Blake) - avoid global variable shadowed (Hu Tao) - lxc: Cleaner fix for compilation without SELinux (Martin Kletzander) - Fix compilation on MacOS X (Lincoln Myers) Documentation: - snapshot: fix virsh docs (Eric Blake) - Expand docs for timer tick policy (Daniel P. Berrange) - Add documentation for new attribute tray of disk target (Osier Yang) - Clarify virsh freecell manpage entry (Dave Allan) - fix typo (Zhou Peng) - Clarify what documentation is being referenced (Dave Allan) - Minor docs fix (Martin Kletzander) - libvirt: fix comment typo (Alex Jia) - fix usage example on setting log levels (Eric Blake) - use correct terminology for 1024 bytes (Eric Blake) - Fix typo (Osier Yang) - Fix typo in domain XML documentation (Christophe Fergeau) - storage: fix typo (Michal Privoznik) - comments wiping supported algorithms (Alex Jia) - Fix libvirt name in qemu commandline namespace URL (Michal Privoznik) - virsh: Break long lines in virsh.pod (Osier Yang) - Update bug reporting page (Dave Allan) - lib: Fix function documentation for virConnectListDomains (Peter Krempa) - virsh: Fix docs for list command (Peter Krempa) Bug fixes: - qemu: Start nested job in qemuDomainCheckEjectableMedia (Jiri Denemark) - qemu: fix memory leak in virDomainGetVcpus (Laine Stump) - conf: allow fuzz in XML with cur balloon > max (Eric Blake) - qemu: reflect any memory rounding back to xml (Eric Blake) - qemu: support live change of the bridge used by a guest network device (Hendrik Schwartke) - qemu_agent: Issue guest-sync prior to every command (Michal Privoznik) - conf: Prevent crash of libvirtd without channel target name (Alex Jia) - fix a deadlock when qemu cannot start (Wen Congyang) - qemu: Make migration fail when port profile association fails on the dst host (Christian Benvenuti) - virsh: plug memory leaks on failure path (Alex Jia) - snapshot: don't pass NULL to QMP command creation (Eric Blake) - qemu: Avoid entering monitor with locked driver (Jiri Denemark) - Leave all child processes running when stopping systemd service (Daniel P. Berrange) - python: Avoid memory leaks on libvirt_virNodeGetCPUStats (Alex Jia) - qemu: Avoid dangling migration-out job when client dies (Jiri Denemark) - qemu: Avoid dangling migration-in job on shutoff domains (Jiri Denemark) - qemu: Use unlimited speed when migrating to file (Jiri Denemark) - python: Avoid memory leaks on libvirt_virNodeGetMemoryStats (Alex Jia) - conf: forbid use of multicast mac addresses (Laine Stump) - conf: return immediately on error in dhcp host element (Laine Stump) - util: fail attempts to use same mac address for guest and tap (Laine Stump) - snapshot: make quiesce a bit safer (Eric Blake) - virConfGetValue: Fixed NULL pointer check (Martin Kletzander) - Fix handling of blkio deviceWeight empty string (Daniel P. Berrange) - remote: Fix migration leaks (Osier Yang) - lib: Don't access configuration if none is present (Peter Krempa) - qemuDomainDetachPciDiskDevice: Free allocated cgroup (Michal Privoznik) - virsh: fix invalid free (Alex Jia) - qemu: Reverse condition in qemuDomainCheckDiskPresence (Michal Privoznik) - qemu: fix segfault when detaching non-existent network device (Guannan Ren) - qemu: Fix (managed)save and snapshots with host mode CPU (Jiri Denemark) - qemu: support disk filenames with comma (Eric Blake) - Fix a few typo in translated strings (Daniel Veillard) - qemuBuildCommandLine: Don't add tlsPort if none set (Michal Privoznik) - qemu: eliminate memory leak in qemuDomainUpdateDeviceConfig (Laine Stump) - util: eliminate device object leaks related to virDomain*Remove*() (Laine Stump) - qemu: don't 'remove' hostdev objects from domain if operation fails (Laine Stump) - util: Don't overflow on errno in virFileAccessibleAs (Michal Privoznik) - sanlock: Use STREQ_NULLABLE instead of STREQ on strings that may be null (Peter Krempa) - qemu: Fix startupPolicy for snapshot-revert (Michal Privoznik) - rpc: allow truncated return for virDomainGetCPUStats (Eric Blake) - conf: fix error log with "address address" (Laine Stump) - Ensure max_id is initialized in linuxParseCPUmap() (Daniel P. Berrange) - util: eliminate crash in virNetDevMacVLanCreateWithVPortProfile (Laine Stump) - rpc: Fix client crash on connection close (Jiri Denemark) - Correct a check for capacity arg of storageVolumeResize() (Zeeshan Ali (Khattak)) - qemu: Don't emit tls-port spice option if port is -1 (Jiri Denemark) - libxl: eliminate memory leak in libxmlDomainModifyDeviceFlags (Laine Stump) - qemu: fix cleanup of bridge during failure of qemuDomainAttachNetDevice (Laine Stump) - qemu: unescape HMP commands before converting them to json (Josh Durgin) - virsh: fix informational message in iface-bridge command (Laine Stump) - virterror: Misleading error message when name is missing (Benjamin Cama) - util: Fix virFileAccessibleAs return path from parent (Michal Privoznik) - qemu: Prevent crash of libvirtd without guest agent (Alex Jia) - qemu: Unlock monitor when connecting to dest qemu fails (Jiri Denemark) - qemu: Fix segfault when host CPU is empty (Jiri Denemark) - Fix polkit0 authentication (Jim Fehlig) - snapshot: fix snapshot deletion use-after-free (Eric Blake) - daemon: fix logic bug with virAsprintf (Eric Blake) - daemon: plug memory leak (Eric Blake) - Fix typos in API XML file paths (Daniel P. Berrange) Improvements: - Xen: Fix <clock> handling (Philipp Hahn) - Support clock=variable relative to localtime (Philipp Hahn) - python: improve conversion validation (Eric Blake) - Fix client only RPM build & other misc RPM problems (Daniel P. Berrange) - virnetdevtap: Don't check for flags in virNetDevTapCreateFlags (Michal Privoznik) - Consistent style for usage of sizeof operator (Daniel P. Berrange) - Don't redefine the CPU comparison constants in CPU test (Daniel P. Berrange) - Fix some format specifiers for size_t vs ssize_t (Daniel P. Berrange) - build: silence recent syntax check violations (Eric Blake) - private.syms: Add virNetDevMacVLanRestartWithVPortProfile (Zhou Peng) - Set default name for SPICE agent channel (Christophe Fergeau) - python: make python APIs use these helper functions (Guannan Ren) - python: Add new helper functions for python to C integral conversion (Guannan Ren) - Enable all warnings permanently & default to -Werror for GIT builds (Daniel P. Berrange) - Enable build of test suite programs by default for GIT checkouts (Daniel P. Berrange) - Change the default of mdns_adv to false (Stef Walter) - Add LXC XML files to schema test & fix problems this uncovers (Daniel P. Berrange) - Add support for setting init argv for LXC (Daniel P. Berrange) - Detect location fo selinux mount point (Daniel P. Berrange) - qemu,util: on restart of libvirt restart vepa callbacks (D. Herrendoerfer) - build: fix "missing initializer" error in qemu_process.c (Laine Stump) - build: fix "missing initializer" errors in virsh.c (Laine Stump) - Added syntax-check rule for return with parentheses (Martin Kletzander) - Cleanup for a return statement in source files (Martin Kletzander) - Fix and test round-trip of query parameters (Eric Blake) - snapshot: improve qemu handling of reused snapshot targets (Eric Blake) - snapshot: wire up qemu transaction command (Eric Blake) - snapshot: add support for qemu transaction command (Eric Blake) - snapshot: rudimentary qemu support for atomic disk snapshot (Eric Blake) - snapshot: make offline qemu snapshots atomic (Eric Blake) - snapshot: add atomic create flag (Eric Blake) - snapshot: add qemu capability for 'transaction' command (Eric Blake) - build: fix incorrect enum declaration (Eric Blake) - Add qemu support for ppc64 on FC16 or above for rpm packaging (Li Zhang) - Fix typo s/virURIFormatQuery/virURIFormatParams/ (Daniel P. Berrange) - qemu: Update domain status to running while wakeup event is emitted (Osier Yang) - qemu: Update domain state to pmsuspended while suspend event occurs (Osier Yang) - New domain state pmsuspended (Osier Yang) - Add support for the wakeup event (Osier Yang) - qemu: Update tray status while tray moved event is emitted (Osier Yang) - qemu: Prohibit setting tray status as open for block type disk (Osier Yang) - qemu: Do not start with source for removable disks if tray is open (Osier Yang) - conf: Parse and for the tray attribute (Osier Yang) - Implement sysinfo on PowerPC. (Prerna Saxena) - Lookup auth credentials in config file before prompting (Daniel P. Berrange) - Refactor code prompting for SASL credentials (Daniel P. Berrange) - Add helper API for finding auth file path (Daniel P. Berrange) - Rename virRequest{Username,Password} to virAuthGet{Username,Password} (Daniel P. Berrange) - Rename src/util/authhelper.[ch] to src/util/virauth.[ch] (Daniel P. Berrange) - Add a virKeyfilePtr object for parsing '.ini' files (Daniel P. Berrange) - Convert drivers over to use virURIPtr for query params (Daniel P. Berrange) - Store parsed query parameters directly in the virURIPtr struct (Daniel P. Berrange) - Use a libvirt custom struct for virURIPtr (Daniel P. Berrange) - Centralize error reporting for URI parsing/formatting problems (Daniel P. Berrange) - s/xmlURIPtr/virURIPtr/ in virURIFormat impl (Daniel P. Berrange) - Use virURIFree instead of xmlFreeURI (Daniel P. Berrange) - Add test case for virURIPtr classs (Daniel P. Berrange) - python: add virDomainGetCPUStats python binding API (Guannan Ren) - qemu: Make autodestroy utilize connection close callbacks (Jiri Denemark) - qemu: Add connection close callbacks (Jiri Denemark) - qemu: Add support for domain cleanup callbacks (Jiri Denemark) - python: always include config.h first (Eric Blake) - Cpu mapping cleanup (Martin Kletzander) - virsh: trim aliases from -h output (Eric Blake) - Add support for forcing a private network namespace for LXC guests (Daniel P. Berrange) - Emit graphics events when a SPICE client connects/disconnects (Laine Stump) - numad: Fix typo and warning (Osier Yang) - Add container_uuid env variable to LXC guests (Daniel P. Berrange) - Allow overriding default URI in config file (Daniel P. Berrange) - virsh: A bit smarter attach-disk (Osier Yang) - qemu: Use scsi-block for lun passthrough instead of scsi-disk (Osier Yang) - cpu: Add cpu definition for Intel Sandy Bridge cpu type (Peter Krempa) - Added support for AMD Bulldozer CPU (Martin Kletzander) - graphics: Cleanup port policy (Michal Privoznik) - cpustats: report user and sys times (Eric Blake) - qemuxml2argvtest: Pass some additional flags to graphics-spice-agentmouse (Michal Privoznik) - qemu: spice agent-mouse support (Peng Zhou) - virsh: Use option alias for outmoded "--persistent" (Osier Yang) - util: consolidate duplicated error messages in pci.c (Laine Stump) - qemu: support persistent hotplug of <hostdev> devices (Laine Stump) - util: standardize return from functions calling virNetlinkCommand (Laine Stump) - util: make virDomainLeaseDefFree global (Laine Stump) - util: consolidate duplicated error messages in virnetlink.c (Laine Stump) - util: log error on OOM in virNetDevOpenvswitchAddPort (Laine Stump) - Attach vm-id to Open vSwitch interfaces. (Ansis Atteka) - util: whitespace change to virNetDevOpenvswitchAddPort (Laine Stump) - util: add stub pciConfigAddressToSysfsFile for non-linux platforms (Laine Stump) - rpc: generalize solution for VPATH builds (Eric Blake) - xml: Clean up schemas to use shared data types instead of local (Peter Krempa) - qemu: Don't parse device twice in attach/detach (Michal Privoznik) - virsh: improve memory unit parsing (Eric Blake) - virsh: improve storage unit parsing (Eric Blake) - virsh: add command aliases, and rename nodedev-detach (Eric Blake) - virsh: use option aliases (Eric Blake) - virsh: add option aliases (Eric Blake) - xml: allow scaled memory on input (Eric Blake) - xml: use better types for memory values (Eric Blake) - xml: use long long internally, to centralize overflow checks (Eric Blake) - xml: drop unenforced minimum memory limit from RNG (Eric Blake) - storage: support more scaling suffixes (Eric Blake) - xml: output memory unit for clarity (Eric Blake) - xml: share 'unit' in RNG (Eric Blake) - util: new function for scaling numbers (Eric Blake) - api: add overflow error (Eric Blake) - cpu-stats command shows cpu statistics information of a domain. (KAMEZAWA Hiroyuki) - qemu driver for virDomainGetCPUstats using cpuacct cgroup. (KAMEZAWA Hiroyuki) - add nodeGetCPUmap() for getting available CPU IDs in a cpumap. (KAMEZAWA Hiroyuki) - qemu: install port profile and mac address on netdev hostdevs (Roopa Prabhu) - util: Changes to support portprofiles for hostdevs (Roopa Prabhu) - util: support functions for mac/portprofile associations on hostdev (Roopa Prabhu) - util: two new pci util functions (Roopa Prabhu) - qemu: support type=hostdev network device live hotplug attach/detach (Laine Stump) - qemu: use virDomainNetRemove instead of inline code (Laine Stump) - conf: change virDomainNetRemove from static to global (Laine Stump) - conf: parse/format type='hostdev' network interfaces (Laine Stump) - qemu: refactor hotplug detach of hostdevs (Laine Stump) - qemu: re-order functions in qemu_hotplug.c (Laine Stump) - conf: hostdev utility functions (Laine Stump) - conf: put subsys part of virDomainHostdevDef into its own struct (Laine Stump) - conf: give each hostdevdef a parent pointer (Laine Stump) - conf: HostdevDef parse/format helper functions (Laine Stump) - conf: make hostdev info a separate object (Laine Stump) - conf: add device pointer to args of virDomainDeviceInfoIterate callback (Laine Stump) - qemu: rename virDomainDeviceInfoPtr variables to avoid confusion (Laine Stump) - conf: reorder static functions in domain_conf.c (Laine Stump) - conf: relocate virDomainDeviceDef and virDomainHostdevDef (Laine Stump) - conf: add missing device types to virDomainDevice(Type|Def) (Laine Stump) - blockResize: add flag for bytes (Eric Blake) - qemu: Shared or readonly disks are always safe wrt migration (Jiri Denemark) - libvirt-guests: Add parallel startup and shutdown of guests (Peter Krempa) - Fix type and add missed comment for diskChange callback (Osier Yang) - cpu: Add new flag supported by qemu to the cpu definition (Peter Krempa) - util: combine bools in virNetDevTapCreateInBridgePort into flags (Laine Stump) - util: centralize tap device MAC address 1st byte "0xFE" modification (Ansis Atteka) - build: use correct type for pid and similar types (Eric Blake) - build: prohibit cross-inclusion (Eric Blake) - virsh: expose partial pull (Eric Blake) - qemu: pass block pull backing file to monitor (Eric Blake) - qemu: require json for block jobs (Eric Blake) - fix alphabetical order of virNetlink functions in symbol file (Laine Stump) - build: update to latest gnulib (Eric Blake) - Add de-association handling to macvlan code (D. Herrendoerfer) - util: Add netlink event handling to virnetlink.c (D. Herrendoerfer) - Support for cpu64-rhel* qemu cpu models (Martin Kletzander) - libvirt-guests: Check if URI is reachable before launching commands (Peter Krempa) - libvirt-guests: Don't try to do a managed-save of transient guests (Peter Krempa) - libvirt-guests: Add documentation and clean up to use virsh's improved list (Peter Krempa) - qemu: Add pre-migration hook (Jiri Denemark) - hooks: Add support for capturing hook output (Jiri Denemark) - util: fix a typo (Alex Jia) - storage: fix a typo (Alex Jia) - Do not include binaries in EXTRA_DIST (Daniel Veillard) - virsh: New command cmdChangeMedia (Osier Yang) - virsh: Use vshFindDisk and vshPrepareDiskXML in cmdDetachDisk (Osier Yang) - virsh: Two new helper functions for disk device changes (Osier Yang) - tests: Add tests for virtio-scsi and ibmvscsi controllers (Osier Yang) - qemu: Build command line for the new address format (Osier Yang) - qemu: New cap flag to indicate if channel is supported by scsi-disk (Osier Yang) - conf: Introduce new attribute for device address format (Osier Yang) - conf: Add helper function to look up disk controller model (Osier Yang) - qemu: add virtio-scsi controller model (Paolo Bonzini) - qemu: add ibmvscsi controller model (Paolo Bonzini) - qemu: Add ability to abort existing console while creating new one (Peter Krempa) - util: Add helpers for safe domain console operations (Peter Krempa) - fdstream: Add internal callback on stream close (Peter Krempa) - fdstream: Emit stream abort callback even if poll() doesnt. (Peter Krempa) - virsh: add support for VIR_DOMAIN_CONSOLE_* flags (Peter Krempa) - Add flags for virDomainOpenConsole (Peter Krempa) - pidfile: Make checking binary path in virPidFileRead optional (Peter Krempa) - qemu: Implement virDomainPMWakeup API (Michal Privoznik) - virsh: Expose virDomainPMWakeup (Michal Privoznik) - Fixed URI parsing (Martin Kletzander) - Workaround python header file insanity (Daniel P. Berrange) - Improve error reporting when virsh console is run without a TTY (Daniel P. Berrange) - Error out when using SPICE TLS with spice_tls=0 (Christophe Fergeau) - vmx: Better Workstation vmx handling (Jean-Baptiste Rouault) - qemu: nicer error message on failed graceful destroy (Eric Blake) - qemu: Forbid migration with cache != none (Jiri Denemark) - Introduce virStorageFileIsClusterFS (Jiri Denemark) - virsh: Add --unsafe option to migrate command (Jiri Denemark) - Add support for unsafe migration (Jiri Denemark) - configure: Define program name if not found (Michal Privoznik) - virsh: Enhance list command to ease creation of shell scripts (Peter Krempa) - vmware: implement domainXMLFromNative (Jean-Baptiste Rouault) - esx: Correctly disable HTTP Expect header usage of libcurl (Matthias Bolte) - caps: Improve error if passed an unknown arch (Cole Robinson) - spec: use ix86 macros (Peter Robinson) - nwfilter: improved logging during driver initialization (Stefan Berger) - storage: Allow runtime detection of scrub (Michal Privoznik) - Fix build with polkit0 (Jim Fehlig) - python: Expose virDomain{G,S}etInterfaceParameters APIs in python binding (Alex Jia) - conf: rename virDomainNetGetActualDirectVirtPortProfile (Laine Stump) - qemu: increase the timeout before sending SIGKILL to qemu process (Laine Stump) - qemu: drop driver lock while trying to terminate qemu process (Laine Stump) - qemu: Implement DomainPMSuspendForDuration (Michal Privoznik) - qemu: Set capabilities based on supported monitor commands (Michal Privoznik) - Install API XML desc to a standard location (Daniel P. Berrange) - qemu: make block io tuning smarter (Eric Blake) Cleanups: - Fix typos and spacing in messages. (Yuri Chornoivan) - qemu: eliminate nested switch, simplify code (Laine Stump) - Fix typo in previous patch (Daniel P. Berrange) - build: drop obsolete qparams test (Eric Blake) - build: drop a painfully long gnulib test (Eric Blake) - Removed more AMD-specific features from cpu64-rhel* models (Martin Kletzander) - conf: eliminate redundant VIR_ALLOC of 1st element of network DNS hosts. (Laine Stump) - remove daemon/probes.h from .gitignore (Laine Stump) - sanlock: Fix condition left crippled while debugging (Peter Krempa) - qemu: Fix indention (Osier Yang) - daemon: Remove deprecated HAL from init script dependencies (Peter Krempa) - util: remove unneeded #include in virrandom.c (Laine Stump) - util: wrap virnetlink.c to 80 columns (Laine Stump) - Fixed service handling in specfile (Martin Kletzander) So thanks everybody for this massive amount of work, be it bug reports, patches, documentation, portability, everybody should enjoy that release now ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

3 4

[libvirt] Create domain using libvirt-php
by Ali Raza Memon 04 Apr '12

04 Apr '12

Hello...! I want to create a new domain using libvirt-php, and after creating I want to start it. I have seen this to create new domain: libvirt_domain_new($conn, $name, $arch, $memMB, $maxmemMB, $vcpus, $iso_image, $disks, $networks, $flags) So in the above sysntax what should I pass in $iso_image? $disk? $networks and $flag?? Please give me a complete example that can solve my problem. Thanks..

2 1