- Devel - libvirt List Archives

[libvirt] [PATCHv3 0/4] util: fix libvirtd startup failure due to netlink error
by Laine Stump 07 May '12

07 May '12

The initial patch in this series is the same as the single patch I provided before, but in addition there are 3 new patches that take care of the fallout from 1/4 by: 2/4) removing hard-coding of the src nl_pid when virNetLinkCommand is sending a message 3/4) adding a helper function to retrieve the local nl_pid from a libnl socket and 4/4) using that value when appropriate (I think). As before, I'm unable to fully test this myself, so I won't push unless/until I get verification it works.

3 10

[libvirt] [PATCH] openvz: simplify openvzDomainDefineCmd by using virCommandPtr
by Guido Günther 07 May '12

07 May '12

--- While working on setting filesystem quotas I came accross this and I figured I'll send this in advance because of the diffstat. Cheers, -- Guido src/openvz/openvz_driver.c | 79 +++++++++++--------------------------------- 1 file changed, 19 insertions(+), 60 deletions(-) diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index 91f5d49..8cceed6 100644 --- a/src/openvz/openvz_driver.c +++ b/src/openvz/openvz_driver.c @@ -100,68 +100,31 @@ static void cmdExecFree(const char *cmdExec[]) /* generate arguments to create OpenVZ container return -1 - error 0 - OK + Caller has to free the cmd */ -static int -openvzDomainDefineCmd(const char *args[], - int maxarg, virDomainDefPtr vmdef) +static virCommandPtr +openvzDomainDefineCmd(virDomainDefPtr vmdef) { - int narg; - - for (narg = 0; narg < maxarg; narg++) - args[narg] = NULL; + virCommandPtr cmd = virCommandNewArgList(VZCTL, + "--quiet", + "create", + NULL); if (vmdef == NULL) { openvzError(VIR_ERR_INTERNAL_ERROR, "%s", _("Container is not defined")); - return -1; + virCommandFree(cmd); + return NULL; } -#define ADD_ARG(thisarg) \ - do { \ - if (narg >= maxarg) \ - goto no_memory; \ - args[narg++] = thisarg; \ - } while (0) - -#define ADD_ARG_LIT(thisarg) \ - do { \ - if (narg >= maxarg) \ - goto no_memory; \ - if ((args[narg++] = strdup(thisarg)) == NULL) \ - goto no_memory; \ - } while (0) - - narg = 0; - ADD_ARG_LIT(VZCTL); - ADD_ARG_LIT("--quiet"); - ADD_ARG_LIT("create"); - - ADD_ARG_LIT(vmdef->name); - ADD_ARG_LIT("--name"); - ADD_ARG_LIT(vmdef->name); + virCommandAddArgList(cmd, vmdef->name, "--name", vmdef->name, NULL); if (vmdef->nfss == 1 && vmdef->fss[0]->type == VIR_DOMAIN_FS_TYPE_TEMPLATE) { - ADD_ARG_LIT("--ostemplate"); - ADD_ARG_LIT(vmdef->fss[0]->src); - } -#if 0 - if ((vmdef->profile && *(vmdef->profile))) { - ADD_ARG_LIT("--config"); - ADD_ARG_LIT(vmdef->profile); + virCommandAddArgList(cmd, "--ostemplate", vmdef->fss[0]->src, NULL); } -#endif - ADD_ARG(NULL); - return 0; - -no_memory: - openvzError(VIR_ERR_INTERNAL_ERROR, - _("Could not put argument to %s"), VZCTL); - return -1; - -#undef ADD_ARG -#undef ADD_ARG_LIT + return cmd; } @@ -170,8 +133,7 @@ static int openvzSetInitialConfig(virDomainDefPtr vmdef) int ret = -1; int vpsid; char * confdir = NULL; - const char *prog[OPENVZ_MAX_ARG]; - prog[0] = NULL; + virCommandPtr cmd = NULL; if (vmdef->nfss > 1) { openvzError(VIR_ERR_INTERNAL_ERROR, "%s", @@ -210,24 +172,21 @@ static int openvzSetInitialConfig(virDomainDefPtr vmdef) _("Could not set the source dir for the filesystem")); goto cleanup; } - } - else - { - if (openvzDomainDefineCmd(prog, OPENVZ_MAX_ARG, vmdef) < 0) { - VIR_ERROR(_("Error creating command for container")); + } else { + cmd = openvzDomainDefineCmd(vmdef); + if (cmd == NULL) goto cleanup; - } - if (virRun(prog, NULL) < 0) { + if (virCommandRun(cmd, NULL) < 0) goto cleanup; - } } ret = 0; cleanup: VIR_FREE(confdir); - cmdExecFree(prog); + virCommandFree(cmd); + return ret; } -- 1.7.10

2 2

[libvirt] [PATCH] docs: Add 'maintenance releases' link in 'News' sidebar
by Cole Robinson 07 May '12

07 May '12

Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- docs/sitemap.html.in | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/docs/sitemap.html.in b/docs/sitemap.html.in index 8f58d46..206040c 100644 --- a/docs/sitemap.html.in +++ b/docs/sitemap.html.in @@ -13,8 +13,14 @@ Details of new features and bugs fixed in each release <ul> <li> + <a href="http://wiki.libvirt.org/page/Maintenance_Releases">Maintenance Releases</a> + Details about libvirt maintenance releases + </li> + </ul> + <ul> + <li> <a href="http://libvirt.org/git/?p=libvirt.git;a=log">Git log</a> - Latest commit messages from the source repository + Latest commit messages from the source repository </li> </ul> </li> -- 1.7.7.6

2 2

[libvirt] [PATCH] rpm: Handle different source URLs for maint releases
by Cole Robinson 07 May '12

07 May '12

Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- libvirt.spec.in | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index e7e0a55..95d8af4 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -276,10 +276,14 @@ Version: @VERSION@ Release: 1%{?dist}%{?extra_release} License: LGPLv2+ Group: Development/Libraries -Source: http://libvirt.org/sources/libvirt-%{version}.tar.gz BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root URL: http://libvirt.org/ +%if %(echo %{version} | grep -o \\. | wc -l) == 3 +%define mainturl stable_updates/ +%endif +Source: http://libvirt.org/sources/%{?mainturl}libvirt-%{version}.tar.gz + %if %{with_libvirtd} Requires: libvirt-daemon = %{version}-%{release} %if %{with_network} -- 1.7.7.6

2 2

[libvirt] [PATCH 0/2] Fix migration to older versions of libvirt
by Jiri Denemark 07 May '12

07 May '12

This series deals with migrating to older versions of libvirt broken by unconditionally added USB controller into domain XML. Jiri Denemark (2): qemu: Don't use virDomainDefFormat* directly qemu: Emit compatible XML when migrating a domain src/qemu/qemu_domain.c | 88 ++++++++++++++++++++++++++++++++++++++++----- src/qemu/qemu_domain.h | 15 ++++++-- src/qemu/qemu_driver.c | 26 ++++++++------ src/qemu/qemu_migration.c | 30 +++++++++------ src/qemu/qemu_process.c | 8 ++-- 5 files changed, 128 insertions(+), 39 deletions(-) -- 1.7.8.6

2 5

[libvirt] Submission Deadline Extension
by VHPC 12 06 May '12

06 May '12

we apologize if you receive multiple copies of this CFP =================================================================== CALL FOR PAPERS 7th Workshop on Virtualization in High-Performance Cloud Computing VHPC '12 as part of Euro-Par 2012, Rhodes Island, Greece =================================================================== Date: August 28, 2012 Workshop URL: http://vhpc.org SUBMISSION DEADLINE: June 11, 2012 - Full paper submission (extended) SCOPE: Virtualization has become a common abstraction layer in modern data centers, enabling resource owners to manage complex infrastructure independently of their applications. Conjointly, virtualization is becoming a driving technology for a manifold of industry grade IT services. The cloud concept includes the notion of a separation between resource owners and users, adding services such as hosted application frameworks and queueing. Utilizing the same infrastructure, clouds carry significant potential for use in high-performance scientific computing. The ability of clouds to provide for requests and releases of vast computing resources dynamically and close to the marginal cost of providing the services is unprecedented in the history of scientific and commercial computing. Distributed computing concepts that leverage federated resource access are popular within the grid community, but have not seen previously desired deployed levels so far. Also, many of the scientific data centers have not adopted virtualization or cloud concepts yet. This workshop aims to bring together industrial providers with the scientific community in order to foster discussion, collaboration and mutual exchange of knowledge and experience. The workshop will be one day in length, composed of 20 min paper presentations, each followed by 10 min discussion sections. Presentations may be accompanied by interactive demonstrations. TOPICS Topics of interest include, but are not limited to: Higher-level cloud architectures, focusing on issues such as: - Languages for describing highly-distributed compute jobs - Workload characterization for VM-based environments - Optimized communication libraries/protocols in the cloud - Cross-layer optimization of numeric algorithms on VM infrastructure - System and process/bytecode VM convergence - Cloud frameworks and API sets - Checkpointing/migration of large compute jobs - Instrumentation interfaces and languages - VMM performance (auto-)tuning on various load types - Cloud reliability, fault-tolerance, and security - Software as a Service (SaaS) architectures - Research and education use cases - Virtualization in cloud, cluster and grid environments - Cross-layer VM optimizations - Cloud use cases including optimizations - VM-based cloud performance modelling - Performance and cost modelling Lower-level design challenges for Hypervisors, VM-aware I/O devices, hardware accelerators or filesystems in VM environments, especially: - Cloud, grid and distributed filesystems - Hardware for I/O virtualization (storage/network/accelerators) - Storage and network I/O subsystems in virtualized environments - Novel software approaches to I/O virtualization - Paravirtualized I/O subsystems for modified/unmodified guests - Virtualization-aware cluster interconnects - Direct device assignment - NUMA-aware subsystems in virtualized environments - Hardware Accelerators in virtualization (GPUs/FPGAs) - Hardware extensions for virtualization - VMMs/Hypervisors for embedded systems Data Center management methods, including: - QoS and and service levels - VM cloud and cluster distribution algorithms - VM load-balancing in Clouds - Hypervisor extensions and tools for cluster and grid computing - Fault tolerant VM environments - Virtual machine monitor platforms - Management, deployment and monitoring of VM-based environments - Cluster provisioning in the Cloud PAPER SUBMISSION Papers submitted to the workshop will be reviewed by at least two members of the program committee and external reviewers. Submissions should include abstract, key words, the e-mail address of the corresponding author, and must not exceed 10 pages, including tables and figures at a main font size no smaller than 11 point. Submission of a paper should be regarded as a commitment that, should the paper be accepted, at least one of the authors will register and attend the conference to present the work. Accepted papers will be published in the Springer LNCS series - the format must be according to the Springer LNCS Style. Initial submissions are in PDF; authors of accepted papers will be requested to provide source files. Format Guidelines: http://www.springer.de/comp/lncs/authors.html Style template: ftp://ftp.springer.de/pub/tex/latex/llncs/latex2e/llncs2e.zip Abstract Submission Link: http://edas.info/newPaper.php?c=11943 IMPORTANT DATES Rolling abstract submission June 11, 2012 - Full paper submission (extended) June 29, 2012 - Acceptance notification July 20, 2012 - Camera-ready version due August 28, 2012 - Workshop Date CHAIR Michael Alexander (chair), TU Wien, Austria Gianluigi Zanetti (co-chair), CRS4, Italy Anastassios Nanos (co-chair), NTUA, Greece PROGRAM COMMITTEE Paolo Anedda, CRS4, Italy Giovanni Busonera, CRS4, Italy Brad Calder, Microsoft, USA Roberto Canonico, University of Napoli Federico II, Italy Tommaso Cucinotta, Alcatel-Lucent Bell Labs, Ireland Werner Fischer, Thomas-Krenn AG, Germany William Gardner, University of Guelph, USA Marcus Hardt, Forschungszentrum Karlsruhe, Germany Sverre Jarp, CERN, Switzerland Shantenu Jha, Louisiana State University, USA Xuxian Jiang, NC State, USA Nectarios Koziris, National Technical University of Athens, Greece Simone Leo, CRS4, Italy Ignacio Llorente, Universidad Complutense de Madrid, Spain Naoya Maruyama, Tokyo Institute of Technology, Japan Jean-Marc Menaud, Ecole des Mines de Nantes, France Dimitrios Nikolopoulos, Foundation for Research&Technology Hellas, Greece Jose Renato Santos, HP Labs, USA Walter Schwaiger, TU Wien, Austria Yoshio Turner, HP Labs, USA Kurt Tutschku, University of Vienna, Austria Lizhe Wang, Indiana University, USA Chao-Tung Yang, Tunghai University, Taiwan DURATION: Workshop Duration is one day. GENERAL INFORMATION The workshop will be held as part of Euro-Par 2012. Euro-Par 2012: http://europar2012.cti.gr/

1 0

[libvirt] [PATCH] qemu: don't modify domain on failed blockiotune
by Eric Blake 04 May '12

04 May '12

If you have a qemu build that lacks the blockio tune monitor command, then this command: $ virsh blkdeviotune rhel6u2 hda --total_bytes_sec 1000 error: Unable to change block I/O throttle error: internal error Unexpected error fails as expected (well, the error message is lousy), but the next dumpxml shows that the domain was modified anyway. Worse, that means if you save the domain then restore it, the restore will likely fail due to throttling being unsupported, even though no throttling should even be active because the monitor command failed in the first place. * src/qemu/qemu_driver.c (qemuDomainSetBlockIoTune): Check for error before making modification permanent. --- src/qemu/qemu_driver.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index a36c348..2fde15b 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -12011,9 +12011,9 @@ qemuDomainSetBlockIoTune(virDomainPtr dom, qemuDomainObjEnterMonitorWithDriver(driver, vm); ret = qemuMonitorSetBlockIoThrottle(priv->mon, device, &info); qemuDomainObjExitMonitorWithDriver(driver, vm); - vm->def->disks[idx]->blkdeviotune = info; if (ret < 0) goto endjob; + vm->def->disks[idx]->blkdeviotune = info; } if (flags & VIR_DOMAIN_AFFECT_CONFIG) { -- 1.7.7.6

2 4

[libvirt] [PATCHv2] util: fix libvirtd startup failure due to netlink error
by Laine Stump 04 May '12

04 May '12

This solves the problem detailed in: https://bugzilla.redhat.com/show_bug.cgi?id=816465 and further detailed in https://www.redhat.com/archives/libvir-list/2012-May/msg00202.htm A short explanation is included in the comments of the patch itself. Even with ACK, I will wait to push this until I have verification that it does not break lldpad<-->libvirtd communication (if it does, I may need to use the nl_handle allocated during virNetlinkStartup() for virNetlinkEventServiceStart()). --- daemon/libvirtd.c | 6 +++++ src/libvirt_private.syms | 2 ++ src/util/virnetlink.c | 67 +++++++++++++++++++++++++++++++++++++++++++++- src/util/virnetlink.h | 5 +++- 4 files changed, 78 insertions(+), 2 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index b098f6a..5d57b50 100644 --- a/daemon/libvirtd.c +++ b/daemon/libvirtd.c @@ -1007,6 +1007,11 @@ int main(int argc, char **argv) { goto cleanup; } + if (virNetlinkStartup() < 0) { + ret = VIR_DAEMON_ERR_INIT; + goto cleanup; + } + if (!(srv = virNetServerNew(config->min_workers, config->max_workers, config->prio_workers, @@ -1143,6 +1148,7 @@ cleanup: virNetServerProgramFree(qemuProgram); virNetServerClose(srv); virNetServerFree(srv); + virNetlinkShutdown(); if (statuswrite != -1) { if (ret != 0) { /* Tell parent of daemon what failed */ diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index d4038b2..e911774 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1330,6 +1330,8 @@ virNetlinkEventRemoveClient; virNetlinkEventServiceIsRunning; virNetlinkEventServiceStop; virNetlinkEventServiceStart; +virNetlinkShutdown; +virNetlinkStartup; # virnetmessage.h diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index b2e9d51..a249e94 100644 --- a/src/util/virnetlink.c +++ b/src/util/virnetlink.c @@ -1,5 +1,5 @@ /* - * Copyright (C) 2010-2011 Red Hat, Inc. + * Copyright (C) 2010-2012 Red Hat, Inc. * Copyright (C) 2010-2012 IBM Corporation * * This library is free software; you can redistribute it and/or @@ -88,10 +88,63 @@ static int nextWatch = 1; # define NETLINK_EVENT_ALLOC_EXTENT 10 static virNetlinkEventSrvPrivatePtr server = NULL; +static struct nl_handle *placeholder_nlhandle = NULL; /* Function definitions */ /** + * virNetlinkStartup: + * + * Perform any initialization that needs to take place before the + * program starts up worker threads. This is currently used to assure + * that an nl_handle is allocated prior to any attempts to bind a + * netlink socket. For a discussion of why this is necessary, please + * see the following email message: + * + * https://www.redhat.com/archives/libvir-list/2012-May/msg00202.html + * + * The short version is that, without this placeholder allocation of + * an nl_handle that is never used, it is possible for nl_connect() in + * one thread to collide with a direct bind() of a netlink socket in + * another thread, leading to failure of the operation (which could + * lead to failure of libvirtd to start). Since getaddrinfo() (used by + * libvirtd in virSocketAddrParse, which is called quite frequently + * during startup) directly calls bind() on a netlink socket, this is + * actually a very common occurence (15-20% failure rate on some + * hardware). + * + * Returns 0 on success, -1 on failure. + */ +int +virNetlinkStartup(void) +{ + if (placeholder_nlhandle) + return 0; + placeholder_nlhandle = nl_handle_alloc(); + if (!placeholder_nlhandle) { + virReportSystemError(errno, "%s", + _("cannot allocate placeholder nlhandle for netlink")); + return -1; + } + return 0; +} + +/** + * virNetlinkShutdown: + * + * Undo any initialization done by virNetlinkStartup. This currently + * destroys the placeholder nl_handle. + */ +void +virNetlinkShutdown(void) +{ + if (placeholder_nlhandle) { + nl_handle_destroy(placeholder_nlhandle); + placeholder_nlhandle = NULL; + } +} + +/** * virNetlinkCommand: * @nlmsg: pointer to netlink message * @respbuf: pointer to pointer where response buffer will be allocated @@ -535,6 +588,18 @@ static const char *unsupported = N_("libnl was not available at build time"); static const char *unsupported = N_("not supported on non-linux platforms"); # endif +int +virNetlinkStartup(void) +{ + return 0; +} + +void +virNetlinkShutdown(void) +{ + return; +} + int virNetlinkCommand(struct nl_msg *nl_msg ATTRIBUTE_UNUSED, unsigned char **respbuf ATTRIBUTE_UNUSED, unsigned int *respbuflen ATTRIBUTE_UNUSED, diff --git a/src/util/virnetlink.h b/src/util/virnetlink.h index a72612e..93df59a 100644 --- a/src/util/virnetlink.h +++ b/src/util/virnetlink.h @@ -1,5 +1,5 @@ /* - * Copyright (C) 2010-2011 Red Hat, Inc. + * Copyright (C) 2010-2012 Red Hat, Inc. * Copyright (C) 2010-2012 IBM Corporation * * This library is free software; you can redistribute it and/or @@ -35,6 +35,9 @@ struct nlattr; # endif /* __linux__ */ +int virNetlinkStartup(void); +void virNetlinkShutdown(void); + int virNetlinkCommand(struct nl_msg *nl_msg, unsigned char **respbuf, unsigned int *respbuflen, int nl_pid); -- 1.7.10

4 5

[libvirt] [PATCH V2 0/2] Various coverity fixes
by Stefan Berger 04 May '12

04 May '12

Coverity fixes from a previous post split into individual patches. Regards, Stefan

2 4

Re: [libvirt] Virsh Command Reference -- Feedback
by Eric Blake 04 May '12

04 May '12

[adding the mailing list] On 04/24/2012 09:02 PM, Justin Clift wrote: > On 20/04/2012, at 11:58 PM, Robert Urban wrote: >> Hello, >> >> at the bottom of >> >> http://libvirt.org/sources/virshcmdref/html-single/ >> >> someone has written "we need feedback!", so I thought I'd give you a little feedback. >> >> I suggest deleting everything and replacing it with the string "Needs to be written". It would save people a lot of time that might be under the mistaken impression that there is anything of use to be found here. > > Ouch, guess that means you didn't find the few pages that actually have been done? > > The Virsh Command Reference was an effort that started some time ago when I was > working on the Libvirt team. But, it's not received much attention since I > moved teams. A few external contributors have updated or expanded things here > and there. > > Don't suppose you'd be interested in helping get it in shape? As you kinda point > out, the present version of it kinda sucks. :( All help appreciated. :) Reiterating this point to a wider audience. Is there anyone willing to help with improving our documentation? -- Eric Blake eblake(a)redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org

1 0