- Devel - libvirt List Archives

[libvirt] [libvirt-glib] Add missing domain OS type enums
by Zeeshan Ali (Khattak) 14 May '12

14 May '12

From: "Zeeshan Ali (Khattak)" <zeeshanak(a)gnome.org> --- libvirt-gconfig/libvirt-gconfig-domain-os.h | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-os.h b/libvirt-gconfig/libvirt-gconfig-domain-os.h index 44b8bdd..832e275 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-os.h +++ b/libvirt-gconfig/libvirt-gconfig-domain-os.h @@ -59,7 +59,9 @@ struct _GVirConfigDomainOsClass typedef enum { GVIR_CONFIG_DOMAIN_OS_TYPE_HVM, GVIR_CONFIG_DOMAIN_OS_TYPE_LINUX, - GVIR_CONFIG_DOMAIN_OS_TYPE_EXE + GVIR_CONFIG_DOMAIN_OS_TYPE_EXE, + GVIR_CONFIG_DOMAIN_OS_TYPE_XEN, + GVIR_CONFIG_DOMAIN_OS_TYPE_UML } GVirConfigDomainOsType; typedef enum { -- 1.7.7.6

2 2

[libvirt] [PATCH 0/6] Improve security driver support for LXC
by Daniel P. Berrange 14 May '12

14 May '12

This series aims to improve the SELinux security driver support for LXC. First it allows the SELinux driver to load different configuration for LXC, vs SELinux. Second it makes the LXC code use the security drivers for figuring out mount options. The code was originally written by Dan Walsh, but split into a 6 part patch series & made to follow coding standards by myself.

4 19

[libvirt] Re-2: [Patch] Libvirt - Fix locking for readonly devices
by David Weber 14 May '12

14 May '12

> On Tue, May 08, 2012 at 09:41:02AM +0000, David Weber wrote: > > Hi, > > > > I'm currently working on getting sanlock into Debian/Ubuntu. > > While testing, I noticed that I wasn't able to add a readonly > > or shared device: "internal error unsupported > > configuration: Readonly leases are not supported". > > > > After looking into the source, it seems to be the following > > situation: > > - Libvirt passes every device to the sanlock plugin, even if > > it is readonly > > - The sanlock plugin rejects to add a lease for the readonly > > device, returning an error so the machine starts to fail > > > > The attached patch rejects passing readonly and shared devices > > to the lock-plugin so they shouldn't be a problem anymore. > > This isn't good - the lock manager implementation must be the > one to decide what todo with readonly & shared disks. The sanlock > plugin, however, does not currently support readonly/shared leases > hence why it rejects them. We could probably add a config param > to allow readonly/shared leases to be skipped by the sanlock plugin. Thanks for clarification. I've attached an updated patch which adds such a config param. It works but I can't test live-migration at the moment. But as far as I understood it shouldn't be a problem. David ---------------------------------------------------------------- commit 5a1546f328b166871fbf0e0556b5a2aafba93d63 Author: David Weber <wb(a)munzinger.de> Date: Mon May 14 09:43:27 2012 +0200 Add ignore param for readonly and shared disk in sanlock diff --git a/src/locking/lock_driver_sanlock.c b/src/locking/lock_driver_sanlock.c index d344d6a..57b688a 100644 --- a/src/locking/lock_driver_sanlock.c +++ b/src/locking/lock_driver_sanlock.c struct _virLockManagerSanlockDriver { bool requireLeaseForDisks; int hostID; bool autoDiskLease; + bool ignoreReadonlyShared; char *autoDiskLeasePath; }; static int virLockManagerSanlockLoadConfig(const char *configFile) CHECK_TYPE("auto_disk_leases", VIR_CONF_LONG); if (p) driver->autoDiskLease = p->l; + p = virConfGetValue(conf, "ignore_readonly_and_shared_disks"); + CHECK_TYPE("ignore_readonly_and_shared_disks", VIR_CONF_LONG); + if (p) driver->ignoreReadonlyShared = p->l; + p = virConfGetValue(conf, "disk_lease_dir"); CHECK_TYPE("disk_lease_dir", VIR_CONF_STRING); if (p && p->str) { static int virLockManagerSanlockAddResource(virLockManagerPtr lock, SANLK_MAX_RESOURCES); return -1; } + + if (((flags & VIR_LOCK_MANAGER_RESOURCE_READONLY) || + (flags &VIR_LOCK_MANAGER_RESOURCE_SHARED)) && + (driver->ignoreReadonlyShared)) { + return 0; + } if (flags & VIR_LOCK_MANAGER_RESOURCE_READONLY) { virLockError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", diff --git a/src/locking/sanlock.conf b/src/locking/sanlock.conf index efc35ee..5429522 100644 --- a/src/locking/sanlock.conf +++ b/src/locking/sanlock.conf # to enabled, otherwise it defaults to disabled. # #require_lease_for_disks = 1 + +# +# Ignore readonly and shared disks as they aren't supportet yet +# +#ignore_readonly_and_shared_disks = 1 To: berrange(a)redhat.com Cc: libvir-list(a)redhat.com sanlock-devel(a)lists.fedorahosted.org

2 1

[libvirt] [PATCHv2 1/1] Assign spapr-vio address type to ibmvscsi controller
by Li Zhang 14 May '12

14 May '12

For pseries guest, the default controller model is ibmvscsi controller, this controller only can work on spapr-vio address. This patch is to assign spapr-vio address type to ibmvscsi controller. Signed-off-by: Li Zhang <zhlcindy(a)linux.vnet.ibm.com> --- src/qemu/qemu_command.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 117542f..2c6495a 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -779,6 +779,7 @@ qemuAssignSpaprVIOAddress(virDomainDefPtr def, virDomainDeviceInfoPtr info, int qemuDomainAssignSpaprVIOAddresses(virDomainDefPtr def) { int i, rc; + int model; /* Default values match QEMU. See spapr_(llan|vscsi|vty).c */ @@ -790,10 +791,17 @@ int qemuDomainAssignSpaprVIOAddresses(virDomainDefPtr def) } for (i = 0 ; i < def->ncontrollers; i++) { - rc = qemuAssignSpaprVIOAddress(def, &def->controllers[i]->info, + model = def->controllers[i]->model; + if (model == -1 && + def->controllers[i]->type == VIR_DOMAIN_CONTROLLER_TYPE_SCSI) + model = qemuDefaultScsiControllerModel(def); + if (model == VIR_DOMAIN_CONTROLLER_MODEL_SCSI_IBMVSCSI) { + def->controllers[i]->info.type = VIR_DOMAIN_DEVICE_ADDRESS_TYPE_SPAPRVIO; + rc = qemuAssignSpaprVIOAddress(def, &def->controllers[i]->info, 0x2000ul); - if (rc) - return rc; + if (rc) + return rc; + } } for (i = 0 ; i < def->nserials; i++) { -- 1.7.9.5

3 4

[libvirt] [PATCH] esx: Fix memory leaks in error paths related to transferred ownership
by Matthias Bolte 13 May '12

13 May '12

Appending an item to a list transfers ownership of that item to the list owner. But an error can occur in between item allocation and appending it to the list. In this case the item has to be freed explicitly. This was not done in some special cases resulting in possible memory leaks. Reported by Coverity. --- This is actually a v2 for this patch https://www.redhat.com/archives/libvir-list/2012-May/msg00115.html src/esx/esx_driver.c | 16 ++++++++++-- src/esx/esx_vi.c | 63 ++++++++++++++++++++++++++++++++++++++++++-------- 2 files changed, 66 insertions(+), 13 deletions(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index d9f53f7..b3f1948 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -3489,6 +3489,7 @@ esxDomainSetAutostart(virDomainPtr domain, int autostart) esxVI_AutoStartPowerInfo *powerInfoList = NULL; esxVI_AutoStartPowerInfo *powerInfo = NULL; esxVI_AutoStartPowerInfo *newPowerInfo = NULL; + bool newPowerInfo_isAppended = false; if (esxVI_EnsureSession(priv->primary) < 0) { return -1; @@ -3546,9 +3547,7 @@ esxDomainSetAutostart(virDomainPtr domain, int autostart) if (esxVI_AutoStartPowerInfo_Alloc(&newPowerInfo) < 0 || esxVI_Int_Alloc(&newPowerInfo->startOrder) < 0 || esxVI_Int_Alloc(&newPowerInfo->startDelay) < 0 || - esxVI_Int_Alloc(&newPowerInfo->stopDelay) < 0 || - esxVI_AutoStartPowerInfo_AppendToList(&spec->powerInfo, - newPowerInfo) < 0) { + esxVI_Int_Alloc(&newPowerInfo->stopDelay) < 0) { goto cleanup; } @@ -3560,6 +3559,13 @@ esxDomainSetAutostart(virDomainPtr domain, int autostart) newPowerInfo->stopDelay->value = -1; /* use system default */ newPowerInfo->stopAction = (char *)"none"; + if (esxVI_AutoStartPowerInfo_AppendToList(&spec->powerInfo, + newPowerInfo) < 0) { + goto cleanup; + } + + newPowerInfo_isAppended = true; + if (esxVI_ReconfigureAutostart (priv->primary, priv->primary->hostSystem->configManager->autoStartManager, @@ -3581,6 +3587,10 @@ esxDomainSetAutostart(virDomainPtr domain, int autostart) esxVI_AutoStartDefaults_Free(&defaults); esxVI_AutoStartPowerInfo_Free(&powerInfoList); + if (!newPowerInfo_isAppended) { + esxVI_AutoStartPowerInfo_Free(&newPowerInfo); + } + return result; } diff --git a/src/esx/esx_vi.c b/src/esx/esx_vi.c index 42e0976..5b5ab69 100644 --- a/src/esx/esx_vi.c +++ b/src/esx/esx_vi.c @@ -1882,7 +1882,9 @@ esxVI_LookupObjectContentByType(esxVI_Context *ctx, { int result = -1; esxVI_ObjectSpec *objectSpec = NULL; + bool objectSpec_isAppended = false; esxVI_PropertySpec *propertySpec = NULL; + bool propertySpec_isAppended = false; esxVI_PropertyFilterSpec *propertyFilterSpec = NULL; if (objectContentList == NULL || *objectContentList != NULL) { @@ -1951,10 +1953,20 @@ esxVI_LookupObjectContentByType(esxVI_Context *ctx, if (esxVI_PropertyFilterSpec_Alloc(&propertyFilterSpec) < 0 || esxVI_PropertySpec_AppendToList(&propertyFilterSpec->propSet, - propertySpec) < 0 || - esxVI_ObjectSpec_AppendToList(&propertyFilterSpec->objectSet, - objectSpec) < 0 || - esxVI_RetrieveProperties(ctx, propertyFilterSpec, + propertySpec) < 0) { + goto cleanup; + } + + propertySpec_isAppended = true; + + if (esxVI_ObjectSpec_AppendToList(&propertyFilterSpec->objectSet, + objectSpec) < 0) { + goto cleanup; + } + + objectSpec_isAppended = true; + + if (esxVI_RetrieveProperties(ctx, propertyFilterSpec, objectContentList) < 0) { goto cleanup; } @@ -1994,13 +2006,24 @@ esxVI_LookupObjectContentByType(esxVI_Context *ctx, * Remove values given by the caller from the data structures to prevent * them from being freed by the call to esxVI_PropertyFilterSpec_Free(). */ - objectSpec->obj = NULL; - objectSpec->selectSet = NULL; + if (objectSpec != NULL) { + objectSpec->obj = NULL; + objectSpec->selectSet = NULL; + } + if (propertySpec != NULL) { propertySpec->type = NULL; propertySpec->pathSet = NULL; } + if (!objectSpec_isAppended) { + esxVI_ObjectSpec_Free(&objectSpec); + } + + if (!propertySpec_isAppended) { + esxVI_PropertySpec_Free(&propertySpec); + } + esxVI_PropertyFilterSpec_Free(&propertyFilterSpec); return result; @@ -3885,7 +3908,9 @@ esxVI_WaitForTaskCompletion(esxVI_Context *ctx, { int result = -1; esxVI_ObjectSpec *objectSpec = NULL; + bool objectSpec_isAppended = false; esxVI_PropertySpec *propertySpec = NULL; + bool propertySpec_isAppended = false; esxVI_PropertyFilterSpec *propertyFilterSpec = NULL; esxVI_ManagedObjectReference *propertyFilter = NULL; char *version = NULL; @@ -3927,10 +3952,20 @@ esxVI_WaitForTaskCompletion(esxVI_Context *ctx, "info.state") < 0 || esxVI_PropertyFilterSpec_Alloc(&propertyFilterSpec) < 0 || esxVI_PropertySpec_AppendToList(&propertyFilterSpec->propSet, - propertySpec) < 0 || - esxVI_ObjectSpec_AppendToList(&propertyFilterSpec->objectSet, - objectSpec) < 0 || - esxVI_CreateFilter(ctx, propertyFilterSpec, esxVI_Boolean_True, + propertySpec) < 0) { + goto cleanup; + } + + propertySpec_isAppended = true; + + if (esxVI_ObjectSpec_AppendToList(&propertyFilterSpec->objectSet, + objectSpec) < 0) { + goto cleanup; + } + + objectSpec_isAppended = true; + + if (esxVI_CreateFilter(ctx, propertyFilterSpec, esxVI_Boolean_True, &propertyFilter) < 0) { goto cleanup; } @@ -4066,6 +4101,14 @@ esxVI_WaitForTaskCompletion(esxVI_Context *ctx, propertySpec->type = NULL; } + if (!objectSpec_isAppended) { + esxVI_ObjectSpec_Free(&objectSpec); + } + + if (!propertySpec_isAppended) { + esxVI_PropertySpec_Free(&propertySpec); + } + esxVI_PropertyFilterSpec_Free(&propertyFilterSpec); esxVI_ManagedObjectReference_Free(&propertyFilter); VIR_FREE(version); -- 1.7.4.1

2 2

[libvirt] [RFC PATCH] Add Qemu Network Helper
by rmarwah＠linux.vnet.ibm.com 11 May '12

11 May '12

From: Richa Marwaha <rmarwah(a)linux.vnet.ibm.com> QEMU has a new feature which allows QEMU to execute under an unprivileged user ID and still be able to add a tap device to a Linux network bridge. Below is the link to the QEMU patches for the bridge helper feature: http://lists.gnu.org/archive/html/qemu-devel/2012-01/msg03562.html The existing libvirt tap network device support for adding a tap device to a bridge (-netdev tap) works only when connected to a libvirtd instance running as the privileged system account 'root'. When connected to a libvirtd instance running as an unprivileged user (ie. using the session URI) creation of the tap device fails as follows: error: Failed to start domain F14_64 error: Unable to create tap device vnet%d: Operation not permitted With this support, creating a tap device in the above scenario will be possible. Additionally, hot attaching a tap device to a bridge while running when connected to a libvirtd instance running as an unprivileged user will be possible. Signed-off-by: Richa Marwaha <rmarwah(a)linux.vnet.ibm.com> Signed-off-by: Corey Bryant<coreyb(a)linux.vnet.ibm.com> --- src/qemu/qemu_command.c | 38 +++++++++++++++++++++++++------------- src/qemu/qemu_command.h | 1 + src/qemu/qemu_hotplug.c | 19 +++++++++++-------- 3 files changed, 37 insertions(+), 21 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 117542f..daa5381 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -2745,6 +2745,7 @@ error: char * qemuBuildHostNetStr(virDomainNetDefPtr net, + struct qemud_driver *driver, char type_sep, int vlan, const char *tapfd, @@ -2753,6 +2754,7 @@ qemuBuildHostNetStr(virDomainNetDefPtr net, bool is_tap = false; virBuffer buf = VIR_BUFFER_INITIALIZER; enum virDomainNetType netType = virDomainNetGetActualType(net); + const char *brname = NULL; if (net->script && netType != VIR_DOMAIN_NET_TYPE_ETHERNET) { qemuReportError(VIR_ERR_CONFIG_UNSUPPORTED, @@ -2762,8 +2764,15 @@ qemuBuildHostNetStr(virDomainNetDefPtr net, } switch (netType) { - case VIR_DOMAIN_NET_TYPE_NETWORK: case VIR_DOMAIN_NET_TYPE_BRIDGE: + if (!driver->privileged) { + brname = virDomainNetGetActualBridgeName(net); + virBufferAsprintf(&buf, "bridge%cbr=%s", type_sep, brname); + type_sep = ','; + is_tap = true; + break; + } + case VIR_DOMAIN_NET_TYPE_NETWORK: case VIR_DOMAIN_NET_TYPE_DIRECT: virBufferAsprintf(&buf, "tap%cfd=%s", type_sep, tapfd); type_sep = ','; @@ -4865,7 +4874,7 @@ qemuBuildCommandLine(virConnectPtr conn, for (i = 0 ; i < def->nnets ; i++) { virDomainNetDefPtr net = def->nets[i]; char *nic, *host; - char tapfd_name[50]; + char tapfd_name[50] = ""; char vhostfd_name[50] = ""; int vlan; int bootindex = bootNet; @@ -4902,17 +4911,20 @@ qemuBuildCommandLine(virConnectPtr conn, if (actualType == VIR_DOMAIN_NET_TYPE_NETWORK || actualType == VIR_DOMAIN_NET_TYPE_BRIDGE) { - int tapfd = qemuNetworkIfaceConnect(def, conn, driver, net, - qemuCaps); - if (tapfd < 0) - goto error; + if (actualType == VIR_DOMAIN_NET_TYPE_NETWORK || + driver->privileged) { + int tapfd = qemuNetworkIfaceConnect(def, conn, driver, net, + qemuCaps); + if (tapfd < 0) + goto error; - last_good_net = i; - virCommandTransferFD(cmd, tapfd); + last_good_net = i; + virCommandTransferFD(cmd, tapfd); - if (snprintf(tapfd_name, sizeof(tapfd_name), "%d", - tapfd) >= sizeof(tapfd_name)) - goto no_memory; + if (snprintf(tapfd_name, sizeof(tapfd_name), "%d", + tapfd) >= sizeof(tapfd_name)) + goto no_memory; + } } else if (actualType == VIR_DOMAIN_NET_TYPE_DIRECT) { int tapfd = qemuPhysIfaceConnect(def, driver, net, qemuCaps, vmop); @@ -4955,7 +4967,7 @@ qemuBuildCommandLine(virConnectPtr conn, if (qemuCapsGet(qemuCaps, QEMU_CAPS_NETDEV) && qemuCapsGet(qemuCaps, QEMU_CAPS_DEVICE)) { virCommandAddArg(cmd, "-netdev"); - if (!(host = qemuBuildHostNetStr(net, ',', vlan, + if (!(host = qemuBuildHostNetStr(net, driver, ',', vlan, tapfd_name, vhostfd_name))) goto error; virCommandAddArg(cmd, host); @@ -4978,7 +4990,7 @@ qemuBuildCommandLine(virConnectPtr conn, if (!(qemuCapsGet(qemuCaps, QEMU_CAPS_NETDEV) && qemuCapsGet(qemuCaps, QEMU_CAPS_DEVICE))) { virCommandAddArg(cmd, "-net"); - if (!(host = qemuBuildHostNetStr(net, ',', vlan, + if (!(host = qemuBuildHostNetStr(net, driver, ',', vlan, tapfd_name, vhostfd_name))) goto error; virCommandAddArg(cmd, host); diff --git a/src/qemu/qemu_command.h b/src/qemu/qemu_command.h index 1eafeb3..04240bc 100644 --- a/src/qemu/qemu_command.h +++ b/src/qemu/qemu_command.h @@ -62,6 +62,7 @@ qemuBuildChrDeviceStr (virDomainChrDefPtr serial, /* With vlan == -1, use netdev syntax, else old hostnet */ char * qemuBuildHostNetStr(virDomainNetDefPtr net, + struct qemud_driver *driver, char type_sep, int vlan, const char *tapfd, diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index ad31eba..7f8b1e4 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -699,12 +699,15 @@ int qemuDomainAttachNetDevice(virConnectPtr conn, if (actualType == VIR_DOMAIN_NET_TYPE_BRIDGE || actualType == VIR_DOMAIN_NET_TYPE_NETWORK) { - if ((tapfd = qemuNetworkIfaceConnect(vm->def, conn, driver, net, - priv->qemuCaps)) < 0) - goto cleanup; - iface_connected = true; - if (qemuOpenVhostNet(vm->def, net, priv->qemuCaps, &vhostfd) < 0) - goto cleanup; + if (actualType == VIR_DOMAIN_NET_TYPE_NETWORK || + driver->privileged) { + if ((tapfd = qemuNetworkIfaceConnect(vm->def, conn, driver, net, + priv->qemuCaps)) < 0) + goto cleanup; + iface_connected = true; + if (qemuOpenVhostNet(vm->def, net, priv->qemuCaps, &vhostfd) < 0) + goto cleanup; + } } else if (actualType == VIR_DOMAIN_NET_TYPE_DIRECT) { if ((tapfd = qemuPhysIfaceConnect(vm->def, driver, net, priv->qemuCaps, @@ -752,11 +755,11 @@ int qemuDomainAttachNetDevice(virConnectPtr conn, if (qemuCapsGet(priv->qemuCaps, QEMU_CAPS_NETDEV) && qemuCapsGet(priv->qemuCaps, QEMU_CAPS_DEVICE)) { - if (!(netstr = qemuBuildHostNetStr(net, ',', + if (!(netstr = qemuBuildHostNetStr(net, driver, ',', -1, tapfd_name, vhostfd_name))) goto cleanup; } else { - if (!(netstr = qemuBuildHostNetStr(net, ' ', + if (!(netstr = qemuBuildHostNetStr(net, driver, ' ', vlan, tapfd_name, vhostfd_name))) goto cleanup; } -- 1.7.1

2 2

[libvirt] [PATCH] Mount fresh instance of sysfs in LXC
by Daniel P. Berrange 11 May '12

11 May '12

From: "Daniel P. Berrange" <berrange(a)redhat.com> Currently to make sysfs readonly, we remount the existing instance and then bind it readonly. Unfortunately this means sysfs is still showing device objects wrt the host OS namespace. We need it to reflect the container namespace, so we must mount a completely new instance of it. * src/lxc/lxc_container.c: Mount fresh sysfs instance --- src/lxc/lxc_container.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index b953646..77d33e1 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -441,8 +441,7 @@ static int lxcContainerMountBasicFS(lxc_child_argv_t *argv, const char *srcprefi { false, "proc", "/proc", "proc", NULL, MS_NOSUID|MS_NOEXEC|MS_NODEV }, { false, "/proc/sys", "/proc/sys", NULL, NULL, MS_BIND }, { false, "/proc/sys", "/proc/sys", NULL, NULL, MS_BIND|MS_REMOUNT|MS_RDONLY }, - { true, "/sys", "/sys", NULL, NULL, MS_BIND }, - { true, "/sys", "/sys", NULL, NULL, MS_BIND|MS_REMOUNT|MS_RDONLY }, + { false, "sysfs", "/sys", "sysfs", NULL, MS_NOSUID|MS_NOEXEC|MS_NODEV|MS_RDONLY }, #if HAVE_SELINUX { true, SELINUX_MOUNT, SELINUX_MOUNT, NULL, NULL, MS_BIND }, { true, SELINUX_MOUNT, SELINUX_MOUNT, NULL, NULL, MS_BIND|MS_REMOUNT|MS_RDONLY }, -- 1.7.10.1

3 3

[libvirt] [libvirt-glib] Make memory-handling more explicit in API doc
by Christophe Fergeau 11 May '12

11 May '12

Explain how the return value of the (transfer full) methods should be freed. I also made some cosmetic changes in the API doc of some of the files as I was modifying them. --- libvirt-gconfig/libvirt-gconfig-domain-os.c | 11 ++- libvirt-gconfig/libvirt-gconfig-domain.c | 28 ++++-- libvirt-gobject/libvirt-gobject-connection.c | 94 +++++++++++++------- libvirt-gobject/libvirt-gobject-domain-device.c | 8 +- libvirt-gobject/libvirt-gobject-domain-disk.c | 4 +- libvirt-gobject/libvirt-gobject-domain-interface.c | 4 +- libvirt-gobject/libvirt-gobject-domain-snapshot.c | 4 +- libvirt-gobject/libvirt-gobject-domain.c | 16 ++-- libvirt-gobject/libvirt-gobject-interface.c | 3 +- libvirt-gobject/libvirt-gobject-manager.c | 8 +- libvirt-gobject/libvirt-gobject-network-filter.c | 4 +- libvirt-gobject/libvirt-gobject-network.c | 3 +- libvirt-gobject/libvirt-gobject-node-device.c | 4 +- libvirt-gobject/libvirt-gobject-secret.c | 4 +- libvirt-gobject/libvirt-gobject-storage-pool.c | 19 ++-- libvirt-gobject/libvirt-gobject-storage-vol.c | 6 +- 16 files changed, 157 insertions(+), 63 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-os.c b/libvirt-gconfig/libvirt-gconfig-domain-os.c index 6e3cabd..9a1648a 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-os.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-os.c @@ -83,6 +83,7 @@ void gvir_config_domain_os_set_os_type(GVirConfigDomainOs *os, /** * gvir_config_domain_os_set_kernel: + * @os: a #GVirConfigDomainOs * @kernel: (allow-none): The kernel path */ void gvir_config_domain_os_set_kernel(GVirConfigDomainOs *os, @@ -94,6 +95,7 @@ void gvir_config_domain_os_set_kernel(GVirConfigDomainOs *os, /** * gvir_config_domain_os_set_ramdisk: + * @os: a #GVirConfigDomainOs * @ramdisk: (allow-none): The ramdisk path */ void gvir_config_domain_os_set_ramdisk(GVirConfigDomainOs *os, @@ -105,6 +107,7 @@ void gvir_config_domain_os_set_ramdisk(GVirConfigDomainOs *os, /** * gvir_config_domain_os_set_cmdline: + * @os: a #GVirConfigDomainOs * @cmdline: (allow-none): The direct boot commandline */ void gvir_config_domain_os_set_cmdline(GVirConfigDomainOs *os, @@ -116,6 +119,7 @@ void gvir_config_domain_os_set_cmdline(GVirConfigDomainOs *os, /** * gvir_config_domain_os_set_init: + * @os: a #GVirConfigDomainOs * @init: (allow-none): */ void gvir_config_domain_os_set_init(GVirConfigDomainOs *os, @@ -127,6 +131,7 @@ void gvir_config_domain_os_set_init(GVirConfigDomainOs *os, /** * gvir_config_domain_os_set_loader: + * @os: a #GVirConfigDomainOs * @loader: (allow-none): */ void gvir_config_domain_os_set_loader(GVirConfigDomainOs *os, @@ -183,6 +188,7 @@ void gvir_config_domain_os_set_smbios_mode(GVirConfigDomainOs *os, /** * gvir_config_domain_os_set_boot_devices: + * @os: a #GVirConfigDomainOs * @boot_devices: (in) (element-type LibvirtGConfig.DomainOsBootDevice): */ void gvir_config_domain_os_set_boot_devices(GVirConfigDomainOs *os, GList *boot_devices) @@ -246,8 +252,11 @@ static gboolean add_boot_device(xmlNodePtr node, gpointer opaque) /** * gvir_config_domain_os_get_boot_devices: + * @os: a #GVirConfigDomainOs * - * Gets the list of devices attached to @os + * Gets the list of devices attached to @os. The returned list should be + * freed with g_list_free(), after its elements have been unreffed with + * g_object_unref(). * * Returns: (element-type LibvirtGConfig.DomainOsBootDevice) (transfer full): * a newly allocated #GList of #GVirConfigDomainOsBootDevice. diff --git a/libvirt-gconfig/libvirt-gconfig-domain.c b/libvirt-gconfig/libvirt-gconfig-domain.c index 9076a76..b6b43f0 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain.c +++ b/libvirt-gconfig/libvirt-gconfig-domain.c @@ -206,6 +206,7 @@ const char *gvir_config_domain_get_name(GVirConfigDomain *domain) /** * gvir_config_domain_set_name: + * @domain: a #GVirConfigDomain * @name: (allow-none): */ void gvir_config_domain_set_name(GVirConfigDomain *domain, const char *name) @@ -223,6 +224,7 @@ const char *gvir_config_domain_get_description(GVirConfigDomain *domain) /** * gvir_config_domain_set_description: + * @domain: a #GVirConfigDomain * @description: (allow-none): */ void gvir_config_domain_set_description(GVirConfigDomain *domain, const char *description) @@ -234,7 +236,7 @@ void gvir_config_domain_set_description(GVirConfigDomain *domain, const char *de /** * gvir_config_domain_get_memory: - * @domain: A domain configuration object. + * @domain: a #GVirConfigDomain * * Returns: amount of RAM in kilobytes (i.e. blocks of 1024 bytes). */ @@ -246,7 +248,7 @@ guint64 gvir_config_domain_get_memory(GVirConfigDomain *domain) /** * gvir_config_domain_set_memory: - * @domain: A domain configuration object. + * @domain: a #GVirConfigDomain * @memory: The amount of RAM in kilobytes. * * Sets the amount of RAM allocated to @domain in kilobytes (i.e. blocks of 1024 bytes). @@ -285,8 +287,11 @@ static gboolean add_feature(xmlNodePtr node, gpointer opaque) /** * gvir_config_domain_get_features: + * @domain: a #GVirConfigDomain * - * Returns: (transfer full): + * Returns: (transfer full): The returned list should be freed with + * g_strfreev() when no longer needed. + */ GStrv gvir_config_domain_get_features(GVirConfigDomain *domain) { @@ -323,6 +328,7 @@ void gvir_config_domain_set_features(GVirConfigDomain *domain, /** * gvir_config_domain_set_clock: + * @domain: a #GVirConfigDomain * @klock: (allow-none): */ void gvir_config_domain_set_clock(GVirConfigDomain *domain, @@ -338,10 +344,12 @@ void gvir_config_domain_set_clock(GVirConfigDomain *domain, /** * gvir_config_domain_get_os: + * @domain: a #GVirConfigDomain * * Gets the operating system configuration of @domain * - * Returns: (transfer full): + * Returns: (transfer full): A #GVirConfigDomainOs. The returned + * object should be unreffed with g_object_unref() when no longer needed. */ GVirConfigDomainOs *gvir_config_domain_get_os(GVirConfigDomain *domain) { @@ -358,7 +366,8 @@ GVirConfigDomainOs *gvir_config_domain_get_os(GVirConfigDomain *domain) /** * gvir_config_domain_set_os: - * @os: (allow-none): + * @domain: a #GVirConfigDomain + * @os: (allow-none): the os configuration to set */ void gvir_config_domain_set_os(GVirConfigDomain *domain, GVirConfigDomainOs *os) @@ -373,7 +382,8 @@ void gvir_config_domain_set_os(GVirConfigDomain *domain, /** * gvir_config_domain_set_seclabel: - * @seclabel: (allow-none): + * @domain: a #GVirConfigDomain + * @seclabel: (allow-none): the security label configuration to set */ void gvir_config_domain_set_seclabel(GVirConfigDomain *domain, GVirConfigDomainSeclabel *seclabel) @@ -410,6 +420,7 @@ void gvir_config_domain_set_lifecycle(GVirConfigDomain *domain, /** * gvir_config_domain_set_devices: + * @domain: a #GVirConfigDomain * @devices: (in) (element-type LibvirtGConfig.DomainDevice): */ void gvir_config_domain_set_devices(GVirConfigDomain *domain, @@ -480,8 +491,11 @@ static gboolean add_device(xmlNodePtr node, gpointer opaque) /** * gvir_config_domain_get_devices: + * @domain: a #GVirConfigDomain * - * Gets the list of devices attached to @domain + * Gets the list of devices attached to @domain. The returned list should + * be freed with g_list_free(), after its elements have been unreffed with + * g_object_unref(). * * Returns: (element-type LibvirtGConfig.DomainDevice) (transfer full): * a newly allocated #GList of #GVirConfigDomainDevice. diff --git a/libvirt-gobject/libvirt-gobject-connection.c b/libvirt-gobject/libvirt-gobject-connection.c index 6469ebc..b12669d 100644 --- a/libvirt-gobject/libvirt-gobject-connection.c +++ b/libvirt-gobject/libvirt-gobject-connection.c @@ -400,7 +400,7 @@ static int domain_event_cb(virConnectPtr conn G_GNUC_UNUSED, /** * gvir_connection_open: - * @conn: the connection + * @conn: a #GVirConnection * @cancellable: (allow-none)(transfer none): cancellation object */ gboolean gvir_connection_open(GVirConnection *conn, @@ -474,7 +474,7 @@ gvir_connection_open_helper(GSimpleAsyncResult *res, /** * gvir_connection_open_async: - * @conn: the connection + * @conn: a #GVirConnection * @cancellable: (allow-none)(transfer none): cancellation object * @callback: (scope async): completion callback * @user_data: (closure): opaque data for callback @@ -500,7 +500,7 @@ void gvir_connection_open_async(GVirConnection *conn, /** * gvir_connection_open_finish: - * @conn: the connection + * @conn: a #GVirConnection * @result: (transfer none): async method result */ gboolean gvir_connection_open_finish(GVirConnection *conn, @@ -606,7 +606,7 @@ error: /** * gvir_connection_fetch_domains: - * @conn: the connection + * @conn: a #GVirConnection * @cancellable: (allow-none)(transfer none): cancellation object */ gboolean gvir_connection_fetch_domains(GVirConnection *conn, @@ -735,7 +735,7 @@ cleanup: /** * gvir_connection_fetch_storage_pools: - * @conn: the connection + * @conn: a #GVirConnection * @cancellable: (allow-none)(transfer none): cancellation object */ gboolean gvir_connection_fetch_storage_pools(GVirConnection *conn, @@ -879,7 +879,7 @@ gvir_connection_fetch_domains_helper(GSimpleAsyncResult *res, /** * gvir_connection_fetch_domains_async: - * @conn: the connection + * @conn: a #GVirConnection * @cancellable: (allow-none)(transfer none): cancellation object * @callback: (scope async): completion callback * @user_data: (closure): opaque data for callback @@ -904,7 +904,7 @@ void gvir_connection_fetch_domains_async(GVirConnection *conn, /** * gvir_connection_fetch_domains_finish: - * @conn: the connection + * @conn: a #GVirConnection * @result: (transfer none): async method result */ gboolean gvir_connection_fetch_domains_finish(GVirConnection *conn, @@ -938,7 +938,7 @@ gvir_connection_fetch_pools_helper(GSimpleAsyncResult *res, /** * gvir_connection_fetch_storage_pools_async: - * @conn: the connection + * @conn: a #GVirConnection * @cancellable: (allow-none)(transfer none): cancellation object * @callback: (scope async): completion callback * @user_data: (closure): opaque data for callback @@ -963,7 +963,7 @@ void gvir_connection_fetch_storage_pools_async(GVirConnection *conn, /** * gvir_connection_fetch_storage_pools_finish: - * @conn: the connection + * @conn: a #GVirConnection * @result: (transfer none): async method result */ gboolean gvir_connection_fetch_storage_pools_finish(GVirConnection *conn, @@ -994,8 +994,13 @@ static void gvir_domain_ref(gpointer obj, gpointer ignore G_GNUC_UNUSED) /** * gvir_connection_get_domains: + * @conn: a #GVirConnection * - * Return value: (element-type LibvirtGObject.Domain) (transfer full): List of #GVirDomain + * Gets a list of the domains available through @conn. + * + * Return value: (element-type LibvirtGObject.Domain) (transfer full): List + * of #GVirDomain. The returned list should be freed with g_list_free(), + * after its elements have been unreffed with g_object_unref(). */ GList *gvir_connection_get_domains(GVirConnection *conn) { @@ -1014,9 +1019,14 @@ GList *gvir_connection_get_domains(GVirConnection *conn) /** * gvir_connection_get_storage_pools: + * @conn: a #GVirConnection + * + * Gets a list of the storage pools available through @conn. * * Return value: (element-type LibvirtGObject.StoragePool) (transfer full): List - * of #GVirStoragePool + * of #GVirStoragePool. The returned list should be freed with + * g_list_free(), after its elements have been unreffed with + * g_object_unref(). */ GList *gvir_connection_get_storage_pools(GVirConnection *conn) { @@ -1035,9 +1045,11 @@ GList *gvir_connection_get_storage_pools(GVirConnection *conn) /** * gvir_connection_get_domain: + * @conn: a #GVirConnection * @uuid: uuid string of the requested domain * - * Return value: (transfer full): the #GVirDomain, or NULL + * Return value: (transfer full): the #GVirDomain, or NULL. The returned + * object should be unreffed with g_object_unref() when no longer needed. */ GVirDomain *gvir_connection_get_domain(GVirConnection *conn, const gchar *uuid) @@ -1054,9 +1066,11 @@ GVirDomain *gvir_connection_get_domain(GVirConnection *conn, /** * gvir_connection_get_storage_pool: + * @conn: a #GVirConnection * @uuid: uuid string of the requested storage pool * - * Return value: (transfer full): the #GVirStoragePool, or NULL + * Return value: (transfer full): the #GVirStoragePool, or NULL. The returned + * object should be unreffed with g_object_unref() when no longer needed. */ GVirStoragePool *gvir_connection_get_storage_pool(GVirConnection *conn, const gchar *uuid) @@ -1075,9 +1089,11 @@ GVirStoragePool *gvir_connection_get_storage_pool(GVirConnection *conn, /** * gvir_connection_find_domain_by_id: + * @conn: a #GVirConnection * @id: id of the requested domain * - * Return value: (transfer full): the #GVirDomain, or NULL + * Return value: (transfer full): the #GVirDomain, or NULL. The returned + * object should be unreffed with g_object_unref() when no longer needed. */ GVirDomain *gvir_connection_find_domain_by_id(GVirConnection *conn, gint id) @@ -1107,9 +1123,11 @@ GVirDomain *gvir_connection_find_domain_by_id(GVirConnection *conn, /** * gvir_connection_find_domain_by_name: + * @conn: a #GVirConnection * @name: name of the requested domain * - * Return value: (transfer full): the #GVirDomain, or NULL + * Return value: (transfer full): the #GVirDomain, or NULL. The returned + * object should be unreffed with g_object_unref() when no longer needed. */ GVirDomain *gvir_connection_find_domain_by_name(GVirConnection *conn, const gchar *name) @@ -1141,9 +1159,11 @@ GVirDomain *gvir_connection_find_domain_by_name(GVirConnection *conn, /** * gvir_connection_find_storage_pool_by_name: + * @conn: a #GVirConnection * @name: name of the requested storage pool * - * Return value: (transfer full): the #GVirStoragePool, or NULL + * Return value: (transfer full): the #GVirStoragePool, or NULL. The returned + * object should be unreffed with g_object_unref() when no longer needed. */ GVirStoragePool *gvir_connection_find_storage_pool_by_name(GVirConnection *conn, const gchar *name) @@ -1193,9 +1213,11 @@ G_DEFINE_BOXED_TYPE(GVirConnectionHandle, gvir_connection_handle, /** * gvir_connection_get_stream: + * @conn: a #GVirConnection * @flags: flags to use for the stream * - * Return value: (transfer full): a #GVirStream stream, or NULL + * Return value: (transfer full): a #GVirStream stream, or NULL.The returned + * object should be unreffed with g_object_unref() when no longer needed. */ GVirStream *gvir_connection_get_stream(GVirConnection *self, guint flags) @@ -1215,13 +1237,15 @@ GVirStream *gvir_connection_get_stream(GVirConnection *self, /** * gvir_connection_create_domain: - * @conn: the connection on which to create the domain + * @conn: a #GVirConnection on which to create the domain * @conf: the configuration for the new domain * * Create the configuration file for a new persistent domain. * The returned domain will initially be in the shutoff state. * - * Returns: (transfer full): the newly created domain + * Returns: (transfer full): the newly created domain, or NULL if an error + * occurred. The returned object should be unreffed with g_object_unref() + * when no longer needed. */ GVirDomain *gvir_connection_create_domain(GVirConnection *conn, GVirConfigDomain *conf, @@ -1261,13 +1285,15 @@ GVirDomain *gvir_connection_create_domain(GVirConnection *conn, /** * gvir_connection_start_domain: - * @conn: the connection on which to create the domain + * @conn: a #GVirConnection on which to create the domain * @conf: the configuration for the new domain * * Start a new transient domain without persistent configuration. * The returned domain will initially be running. * - * Returns: (transfer full): the newly created domain + * Returns: (transfer full): the newly created domain, or NULL if an error + * occurred. The returned object should be unreffed with g_object_unref() + * when no longer needed. */ GVirDomain *gvir_connection_start_domain(GVirConnection *conn, GVirConfigDomain *conf, @@ -1308,12 +1334,14 @@ GVirDomain *gvir_connection_start_domain(GVirConnection *conn, /** * gvir_connection_create_storage_pool: - * @conn: the connection on which to create the pool + * @conn: a #GVirConnection on which to create the pool * @conf: the configuration for the new storage pool * @flags: the flags * @err: return location for any #GError * - * Returns: (transfer full): the newly created storage pool + * Returns: (transfer full): the newly created storage pool, or NULL if an + * error occurred. The returned list should be freed with g_list_free(), + * after its elements have been unreffed with g_object_unref(). */ GVirStoragePool *gvir_connection_create_storage_pool (GVirConnection *conn, @@ -1352,10 +1380,12 @@ GVirStoragePool *gvir_connection_create_storage_pool /** * gvir_connection_get_node_info: - * @conn: the connection + * @conn: a #GVirConnection * @err: return location for any #GError * - * Returns: (transfer full): the info + * Returns: (transfer full): the info, or NULL if an error occurred. The + * returned object should be unreffed with g_object_unref() when no longer + * needed. */ GVirNodeInfo *gvir_connection_get_node_info(GVirConnection *conn, GError **err) @@ -1386,10 +1416,12 @@ GVirNodeInfo *gvir_connection_get_node_info(GVirConnection *conn, /** * gvir_connection_get_capabilities: - * @conn: the connection + * @conn: a #GVirConnection * @err: return location for any #GError * - * Return value: (transfer full): a #GVirConfigCapabilities or NULL + * Return value: (transfer full): a #GVirConfigCapabilities or NULL. The + * returned object should be unreffed with g_object_unref() when no longer + * needed. */ GVirConfigCapabilities *gvir_connection_get_capabilities(GVirConnection *conn, GError **err) @@ -1436,7 +1468,7 @@ gvir_connection_get_capabilities_helper(GSimpleAsyncResult *res, /** * gvir_connection_get_capabilities_async: - * @conn: the connection + * @conn: a #GVirConnection * @cancellable: (allow-none)(transfer none): cancellation object * @callback: (scope async): completion callback * @user_data: (closure): opaque data for callback @@ -1461,10 +1493,12 @@ void gvir_connection_get_capabilities_async(GVirConnection *conn, /** * gvir_connection_get_capabilities_finish: - * @conn: the connection + * @conn: a #GVirConnection * @result: (transfer none): async method result * - * Return value: (transfer full): a #GVirConfigCapabilities or NULL. + * Return value: (transfer full): a #GVirConfigCapabilities or NULL. The + * returned object should be unreffed with g_object_unref() when no longer + * needed. */ GVirConfigCapabilities * gvir_connection_get_capabilities_finish(GVirConnection *conn, diff --git a/libvirt-gobject/libvirt-gobject-domain-device.c b/libvirt-gobject/libvirt-gobject-domain-device.c index db50c09..9a65468 100644 --- a/libvirt-gobject/libvirt-gobject-domain-device.c +++ b/libvirt-gobject/libvirt-gobject-domain-device.c @@ -161,7 +161,9 @@ virDomainPtr gvir_domain_device_get_domain_handle(GVirDomainDevice *self) * gvir_domain_device_get_domain: * @device: the domain device * - * Returns: (transfer full): the associated domain + * Returns: (transfer full): the associated domain. The returned object + * should be unreffed with g_object_unref() when no longer needed. + */ GVirDomain *gvir_domain_device_get_domain(GVirDomainDevice *device) { @@ -172,7 +174,9 @@ GVirDomain *gvir_domain_device_get_domain(GVirDomainDevice *device) * gvir_domain_device_get_config: * @device: the domain device * - * Returns: (transfer full): the config + * Returns: (transfer full): the config. The returned object should be + * unreffed with g_object_unref() when no longer needed. + */ GVirConfigDomainDevice *gvir_domain_device_get_config(GVirDomainDevice *device) { diff --git a/libvirt-gobject/libvirt-gobject-domain-disk.c b/libvirt-gobject/libvirt-gobject-domain-disk.c index fb85328..607e26c 100644 --- a/libvirt-gobject/libvirt-gobject-domain-disk.c +++ b/libvirt-gobject/libvirt-gobject-domain-disk.c @@ -112,7 +112,9 @@ static const gchar *gvir_domain_disk_get_path(GVirDomainDisk *self) * within the stats structure may be returned as -1, which indicates * that the hypervisor does not support that particular statistic. * - * Returns: (transfer full): the stats or %NULL in case of error + * Returns: (transfer full): the stats or %NULL in case of error.The + * returned object should be unreffed with g_object_unref() when no longer + * needed. **/ GVirDomainDiskStats *gvir_domain_disk_get_stats(GVirDomainDisk *self, GError **err) { diff --git a/libvirt-gobject/libvirt-gobject-domain-interface.c b/libvirt-gobject/libvirt-gobject-domain-interface.c index 9f4b30d..7087cbc 100644 --- a/libvirt-gobject/libvirt-gobject-domain-interface.c +++ b/libvirt-gobject/libvirt-gobject-domain-interface.c @@ -114,7 +114,9 @@ static const gchar *gvir_domain_interface_get_path(GVirDomainInterface *self) * within the stats structure may be returned as -1, which indicates * that the hypervisor does not support that particular statistic. * - * Returns: (transfer full): the stats or %NULL in case of error + * Returns: (transfer full): the stats or %NULL in case of error. The + * returned object should be unreffed with g_object_unref() when no longer + * needed. **/ GVirDomainInterfaceStats *gvir_domain_interface_get_stats(GVirDomainInterface *self, GError **err) { diff --git a/libvirt-gobject/libvirt-gobject-domain-snapshot.c b/libvirt-gobject/libvirt-gobject-domain-snapshot.c index dbf0c51..d06d4d5 100644 --- a/libvirt-gobject/libvirt-gobject-domain-snapshot.c +++ b/libvirt-gobject/libvirt-gobject-domain-snapshot.c @@ -185,7 +185,9 @@ const gchar *gvir_domain_snapshot_get_name(GVirDomainSnapshot *snapshot) * @snapshot: the domain_snapshot * @flags: the flags * - * Returns: (transfer full): the config + * Returns: (transfer full): the config. The returned object should be + * unreffed with g_object_unref() when no longer needed. + */ GVirConfigDomainSnapshot *gvir_domain_snapshot_get_config (GVirDomainSnapshot *snapshot, diff --git a/libvirt-gobject/libvirt-gobject-domain.c b/libvirt-gobject/libvirt-gobject-domain.c index e5113d4..9be568a 100644 --- a/libvirt-gobject/libvirt-gobject-domain.c +++ b/libvirt-gobject/libvirt-gobject-domain.c @@ -455,7 +455,8 @@ gboolean gvir_domain_reboot(GVirDomain *dom, * @dom: the domain * @flags: the flags * - * Returns: (transfer full): the config + * Returns: (transfer full): the config. The returned object should be + * unreffed with g_object_unref() when no longer needed. */ GVirConfigDomain *gvir_domain_get_config(GVirDomain *dom, guint flags, @@ -549,7 +550,8 @@ gboolean gvir_domain_set_config(GVirDomain *domain, * gvir_domain_get_info: * @dom: the domain * - * Returns: (transfer full): the info + * Returns: (transfer full): the info. The returned object should be + * unreffed with g_object_unref() when no longer needed. */ GVirDomainInfo *gvir_domain_get_info(GVirDomain *dom, GError **err) @@ -631,7 +633,8 @@ void gvir_domain_get_info_async(GVirDomain *dom, * * Finishes the operation started by #gvir_domain_get_info_async. * - * Returns: (transfer full): the info + * Returns: (transfer full): the info. The returned object should be + * unreffed with g_object_unref() when no longer needed. */ GVirDomainInfo *gvir_domain_get_info_finish(GVirDomain *dom, GAsyncResult *result, @@ -661,7 +664,8 @@ GVirDomainInfo *gvir_domain_get_info_finish(GVirDomain *dom, * @monitor_id: monitor ID to take screenshot from * @flags: extra flags, currently unused * - * Returns: (transfer full): mime-type of the image format, or NULL upon error. + * Returns: (transfer full): a newly allocated string containing the + * mime-type of the image format, or NULL upon error. */ gchar *gvir_domain_screenshot(GVirDomain *dom, GVirStream *stream, @@ -958,7 +962,9 @@ gboolean gvir_domain_get_saved(GVirDomain *dom) * @domain: the domain * @err: place-holder for possible errors, or NULL * - * Gets the list of devices attached to @domain + * Gets the list of devices attached to @domain. The returned list should + * be freed with g_list_free(), after its elements have been unreffed with + * g_object_unref(). * * Returns: (element-type LibvirtGObject.DomainDevice) (transfer full): a newly * allocated #GList of #GVirDomainDevice. diff --git a/libvirt-gobject/libvirt-gobject-interface.c b/libvirt-gobject/libvirt-gobject-interface.c index a8e299c..883cf92 100644 --- a/libvirt-gobject/libvirt-gobject-interface.c +++ b/libvirt-gobject/libvirt-gobject-interface.c @@ -177,7 +177,8 @@ const gchar *gvir_interface_get_name(GVirInterface *iface) * @flags: the flags * @err: Place-holder for possible errors * - * Returns: (transfer full): the config + * Returns: (transfer full): the config. The returned object should be + * unreffed with g_object_unref() when no longer needed. */ GVirConfigInterface *gvir_interface_get_config(GVirInterface *iface, guint flags, diff --git a/libvirt-gobject/libvirt-gobject-manager.c b/libvirt-gobject/libvirt-gobject-manager.c index 010e8da..c44e711 100644 --- a/libvirt-gobject/libvirt-gobject-manager.c +++ b/libvirt-gobject/libvirt-gobject-manager.c @@ -161,7 +161,9 @@ void gvir_manager_remove_connection(GVirManager *man, /** * gvir_manager_get_connections: * - * Returns: (transfer full)(element-type GVirConnection): the connections + * Returns: (transfer full)(element-type GVirConnection): the connections. + * The returned list should be freed with g_list_free(), after its elements + * have been unreffed with g_object_unref(). */ GList *gvir_manager_get_connections(GVirManager *man) { @@ -181,7 +183,9 @@ GList *gvir_manager_get_connections(GVirManager *man) /** * gvir_manager_find_connection_by_uri: * - * Returns: (transfer full)(allow-none): the connection,or NULL + * Returns: (transfer full)(allow-none): the connection,or NULL. The + * returned object should be unreffed with g_object_unref() when no longer + * needed. */ GVirConnection *gvir_manager_find_connection_by_uri(GVirManager *man, const gchar *uri) diff --git a/libvirt-gobject/libvirt-gobject-network-filter.c b/libvirt-gobject/libvirt-gobject-network-filter.c index 103174b..b3db236 100644 --- a/libvirt-gobject/libvirt-gobject-network-filter.c +++ b/libvirt-gobject/libvirt-gobject-network-filter.c @@ -208,7 +208,9 @@ const gchar *gvir_network_filter_get_uuid(GVirNetworkFilter *filter) * @flags: the flags * @err: Place-holder for possible errors * - * Returns: (transfer full): the config + * Returns: (transfer full): the config. The returned object should be + * unreffed with g_object_unref() when no longer needed. + */ GVirConfigNetworkFilter *gvir_network_filter_get_config (GVirNetworkFilter *filter, diff --git a/libvirt-gobject/libvirt-gobject-network.c b/libvirt-gobject/libvirt-gobject-network.c index 2d195d9..17378ec 100644 --- a/libvirt-gobject/libvirt-gobject-network.c +++ b/libvirt-gobject/libvirt-gobject-network.c @@ -205,7 +205,8 @@ const gchar *gvir_network_get_uuid(GVirNetwork *network) * @flags: the flags * @err: Place-holder for possible errors * - * Returns: (transfer full): the config + * Returns: (transfer full): the config. The returned object should be + * unreffed with g_object_unref() when no longer needed. */ GVirConfigNetwork *gvir_network_get_config(GVirNetwork *network, guint flags, diff --git a/libvirt-gobject/libvirt-gobject-node-device.c b/libvirt-gobject/libvirt-gobject-node-device.c index 6f81f1a..0a4b6a6 100644 --- a/libvirt-gobject/libvirt-gobject-node-device.c +++ b/libvirt-gobject/libvirt-gobject-node-device.c @@ -177,7 +177,9 @@ const gchar *gvir_node_device_get_name(GVirNodeDevice *device) * @flags: the flags * @err: Place-holder for possible errors * - * Returns: (transfer full): the config + * Returns: (transfer full): the config. The returned object should be + * unreffed with g_object_unref() when no longer needed. + */ GVirConfigNodeDevice *gvir_node_device_get_config(GVirNodeDevice *device, guint flags, diff --git a/libvirt-gobject/libvirt-gobject-secret.c b/libvirt-gobject/libvirt-gobject-secret.c index 299fdca..b0aff13 100644 --- a/libvirt-gobject/libvirt-gobject-secret.c +++ b/libvirt-gobject/libvirt-gobject-secret.c @@ -193,7 +193,9 @@ const gchar *gvir_secret_get_uuid(GVirSecret *secret) * @flags: the flags * @err: Place-holder for possible errors * - * Returns: (transfer full): the config + * Returns: (transfer full): the config. The returned object should be + * unreffed with g_object_unref() when no longer needed. + */ GVirConfigSecret *gvir_secret_get_config(GVirSecret *secret, guint flags, diff --git a/libvirt-gobject/libvirt-gobject-storage-pool.c b/libvirt-gobject/libvirt-gobject-storage-pool.c index f09f122..e79c8e5 100644 --- a/libvirt-gobject/libvirt-gobject-storage-pool.c +++ b/libvirt-gobject/libvirt-gobject-storage-pool.c @@ -237,7 +237,8 @@ const gchar *gvir_storage_pool_get_uuid(GVirStoragePool *pool) * @flags: the flags * @err: Place-holder for possible errors * - * Returns: (transfer full): the config + * Returns: (transfer full): the config. The returned object should be + * unreffed with g_object_unref() when no longer needed. */ GVirConfigStoragePool *gvir_storage_pool_get_config(GVirStoragePool *pool, guint flags, @@ -264,7 +265,8 @@ GVirConfigStoragePool *gvir_storage_pool_get_config(GVirStoragePool *pool, * @pool: the storage_pool * @err: Place-holder for possible errors * - * Returns: (transfer full): the info + * Returns: (transfer full): the info. The returned object should be + * unreffed with g_object_unref() when no longer needed. */ GVirStoragePoolInfo *gvir_storage_pool_get_info(GVirStoragePool *pool, GError **err) @@ -486,8 +488,10 @@ static void gvir_storage_vol_ref(gpointer obj, gpointer ignore G_GNUC_UNUSED) * gvir_storage_pool_get_volumes: * @pool: the storage pool * - * Return value: (element-type LibvirtGObject.StorageVol) (transfer full): List - * of #GVirStorageVol + * Return value: (element-type LibvirtGObject.StorageVol) (transfer full): + * List of #GVirStorageVol. The returned list should be freed with + * g_list_free(), after its elements have been unreffed with + * g_object_unref(). */ GList *gvir_storage_pool_get_volumes(GVirStoragePool *pool) { @@ -509,7 +513,9 @@ GList *gvir_storage_pool_get_volumes(GVirStoragePool *pool) * @pool: the storage pool * @name: Name of the requested storage volume * - * Return value: (transfer full): the #GVirStorageVol, or NULL + * Return value: (transfer full): the #GVirStorageVol, or NULL. The + * returned object should be unreffed with g_object_unref() when no longer + * needed. */ GVirStorageVol *gvir_storage_pool_get_volume(GVirStoragePool *pool, const gchar *name) @@ -532,7 +538,8 @@ GVirStorageVol *gvir_storage_pool_get_volume(GVirStoragePool *pool, * @conf: the configuration for the new volume * @err: Place-holder for possible errors * - * Returns: (transfer full): the newly created volume + * Returns: (transfer full): the newly created volume. The returned object + * should be unreffed with g_object_unref() when no longer needed. */ GVirStorageVol *gvir_storage_pool_create_volume (GVirStoragePool *pool, diff --git a/libvirt-gobject/libvirt-gobject-storage-vol.c b/libvirt-gobject/libvirt-gobject-storage-vol.c index cd02b38..9e59576 100644 --- a/libvirt-gobject/libvirt-gobject-storage-vol.c +++ b/libvirt-gobject/libvirt-gobject-storage-vol.c @@ -227,7 +227,8 @@ const gchar *gvir_storage_vol_get_path(GVirStorageVol *vol, GError **error) * @flags: the flags * @err: Place-holder for possible errors * - * Returns: (transfer full): the config + * Returns: (transfer full): the config. The returned object should be + * unreffed with g_object_unref() when no longer needed. */ GVirConfigStorageVol *gvir_storage_vol_get_config(GVirStorageVol *vol, guint flags, @@ -254,7 +255,8 @@ GVirConfigStorageVol *gvir_storage_vol_get_config(GVirStorageVol *vol, * @vol: the storage_vol * @err: Place-holder for possible errors * - * Returns: (transfer full): the info + * Returns: (transfer full): the info. The returned object should be + * unreffed with g_object_unref() when no longer needed. */ GVirStorageVolInfo *gvir_storage_vol_get_info(GVirStorageVol *vol, GError **err) -- 1.7.10.1

2 1

[libvirt] [PATCH] virsh: Allow users to reedit rejected XML
by Michal Privoznik 11 May '12

11 May '12

If users {net-,pool-,}edit but make a mistake in XML all changes are permanently lost. However, if virsh is running in interactive mode we can as user if he wants to re-edit the file and correct the mistakes. --- tools/console.c | 40 +++++++++++++++++++++++++--------------- tools/console.h | 1 + tools/virsh.c | 41 +++++++++++++++++++++++++++++++++++------ 3 files changed, 61 insertions(+), 21 deletions(-) diff --git a/tools/console.c b/tools/console.c index 34fde05..90e54e3 100644 --- a/tools/console.c +++ b/tools/console.c @@ -298,13 +298,36 @@ vshGetEscapeChar(const char *s) return *s; } +int vshMakeStdinRaw(struct termios *ttyattr, bool report_errors) { + struct termios rawattr; + + if (tcgetattr(STDIN_FILENO, ttyattr) < 0) { + if (report_errors) + VIR_ERROR(_("unable to get tty attributes: %s"), + strerror(errno)); + return -1; + } + + rawattr = *ttyattr; + cfmakeraw(&rawattr); + + if (tcsetattr(STDIN_FILENO, TCSAFLUSH, &rawattr) < 0) { + if (report_errors) + VIR_ERROR(_("unable to set tty attributes: %s"), + strerror(errno)); + return -1; + } + + return 0; +} + int vshRunConsole(virDomainPtr dom, const char *dev_name, const char *escape_seq, unsigned int flags) { int ret = -1; - struct termios ttyattr, rawattr; + struct termios ttyattr; void (*old_sigquit)(int); void (*old_sigterm)(int); void (*old_sigint)(int); @@ -317,21 +340,8 @@ int vshRunConsole(virDomainPtr dom, result in it being echoed back already), and also ensure Ctrl-C, etc is blocked, and misc other bits */ - if (tcgetattr(STDIN_FILENO, &ttyattr) < 0) { - VIR_ERROR(_("unable to get tty attributes: %s"), - strerror(errno)); - return -1; - } - - rawattr = ttyattr; - cfmakeraw(&rawattr); - - if (tcsetattr(STDIN_FILENO, TCSAFLUSH, &rawattr) < 0) { - VIR_ERROR(_("unable to set tty attributes: %s"), - strerror(errno)); + if (vshMakeStdinRaw(&ttyattr, true) < 0) goto resettty; - } - /* Trap all common signals so that we can safely restore the original terminal settings on STDIN before the diff --git a/tools/console.h b/tools/console.h index 2b5440c..97c97cd 100644 --- a/tools/console.h +++ b/tools/console.h @@ -30,6 +30,7 @@ int vshRunConsole(virDomainPtr dom, const char *escape_seq, unsigned int flags); +int vshMakeStdinRaw(struct termios *ttyattr, bool report_errors); # endif /* !WIN32 */ #endif /* __VIR_CONSOLE_H__ */ diff --git a/tools/virsh.c b/tools/virsh.c index dd9292a..3537e2e 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -33,6 +33,7 @@ #include <signal.h> #include <poll.h> #include <strings.h> +#include <termios.h> #include <libxml/parser.h> #include <libxml/tree.h> @@ -15806,11 +15807,14 @@ cmdEdit (vshControl *ctl, const vshCmd *cmd) { bool ret = false; virDomainPtr dom = NULL; + virDomainPtr dom_edited = NULL; char *tmp = NULL; char *doc = NULL; char *doc_edited = NULL; char *doc_reread = NULL; unsigned int flags = VIR_DOMAIN_XML_SECURE | VIR_DOMAIN_XML_INACTIVE; + int c = 0; + struct termios ttyattr; if (!vshConnectionUsability(ctl, ctl->conn)) goto cleanup; @@ -15828,6 +15832,7 @@ cmdEdit (vshControl *ctl, const vshCmd *cmd) tmp = editWriteToTempFile (ctl, doc); if (!tmp) goto cleanup; +reedit: /* Start the editor. */ if (editFile (ctl, tmp) == -1) goto cleanup; @@ -15858,19 +15863,43 @@ cmdEdit (vshControl *ctl, const vshCmd *cmd) } /* Everything checks out, so redefine the domain. */ - virDomainFree (dom); - dom = virDomainDefineXML(ctl->conn, doc_edited); - if (!dom) - goto cleanup; + dom_edited = virDomainDefineXML(ctl->conn, doc_edited); + if (!dom_edited) { + /* Redefine failed. If we are in interactive mode ask user + * if he wants to re-edit the XML. */ + if (!ctl->imode || + vshMakeStdinRaw(&ttyattr, false) < 0) + goto cleanup; + + virshReportError(ctl); + + while (true) { + vshPrint(ctl, "\rFailed. Try again? (y/Y/n/N) [Y]:"); + c = getchar(); + c = c_toupper(c); + if (c == '\n' || c == '\r' || c == 'Y' || c == 'N') + break; + } + + tcsetattr(STDIN_FILENO, TCSAFLUSH, &ttyattr); + + if (c == 'N') + goto cleanup; + + vshPrint(ctl, "\r\n"); + goto reedit; + } vshPrint (ctl, _("Domain %s XML configuration edited.\n"), virDomainGetName(dom)); ret = true; - cleanup: +cleanup: if (dom) - virDomainFree (dom); + virDomainFree(dom); + if (dom_edited) + virDomainFree(dom_edited); VIR_FREE(doc); VIR_FREE(doc_edited); -- 1.7.8.5

5 9

[libvirt] [PATCHv2 0/3] Fix output of virsh vcpuinfo after cpu hotplug
by Peter Krempa 11 May '12

11 May '12

A respin of the series fixing guest rollback, a memory leak and making the vCPU thread re-detection safe to use with older qemu versions. Peter Krempa (3): qemu: Refactor qemuDomainSetVcpusFlags qemu: Re-detect virtual cpu threads after cpu hot (un)plug. qemu: Don't skip detection of virtual cpu's on non KVM targets src/qemu/qemu_driver.c | 55 ++++++++++++++++++++++++++++++++-------------- src/qemu/qemu_process.c | 21 ++++++----------- 2 files changed, 46 insertions(+), 30 deletions(-) -- 1.7.3.4

2 7