- Devel - libvirt List Archives

[libvirt] [PATCH 0/3] openvz: allow for runtime quota updates
by Guido Günther 06 Jun '12

06 Jun '12

Hi, attached patches allow to change disk quota at runtime. This can later be extended to update network configuration as well. The patch revealed a problem of the openvz driver in genral: the openvzLoadDomains only reads the on disk configuration but doesn't check if running domains have (non persistent) diverging values due to openvz calls without the "--save" option but that's part of another patch. Cheers, -- Guido Guido Günther (3): Introduce virDomainFSIndexByName openvz: add persist parameter to openvzSetDiskQuota openvz: wire up domainUpdateDeviceFlags src/conf/domain_conf.c | 16 +++++++ src/conf/domain_conf.h | 1 + src/openvz/openvz_driver.c | 105 ++++++++++++++++++++++++++++++++++++++++++-- 3 files changed, 118 insertions(+), 4 deletions(-) -- 1.7.10

2 6

Re: [libvirt] How to add custom tag to the libvirt xml file for a new feature of the VM
by Eric Blake 06 Jun '12

06 Jun '12

[re-adding the list] On 06/05/2012 09:53 PM, Yashwanth K P wrote: >>> I am working on libvirt development and I wanted to add a custom tag to >>> the libvirt xml to add a new feature to the VM. I am having trouble >>> getting started with this. It would be really helpful if you can help me >>> get started with this and guide me on what part of the source code that >>> has to be modified to achieve the goal. >> It would help if we knew more information about what you wanted. >> > What I would like to do is that I want to add a new tag to the xml file > which which when parsed should have an effect on the cpuset value of the > vcpu tag. Thus starting the VM with a particular set of CPUs to run on. > I am not sure on to implement this since I am new to development by > making changes in the source code. It would be really helpful if u guide > me to achive the goal. This is already possible, via the 'cpuset' attribute of the top-level <vcpu> element: http://libvirt.org/formatdomain.html#elementsCPUAllocation -- Eric Blake eblake(a)redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org

1 0

[libvirt] Looking for libvirt for RHEL 6.1 to provide Memory related metrics.
by Roy, Kallol 06 Jun '12

06 Jun '12

Hello All, Can some one let me know if we have the latest libvirt version for RHEL 6.1 which would provided me Memory related counters/metrics. The latest libvirt which I found was on Fedora. Any pointer or expected dates of libvirt release on RHEL would be highly appreciated. Thanks and Regards, _____________________________________________________________________ Kallol Roy "Be kinder than necessary, for everyone you meet is fighting some kind of battle."

1 0

[libvirt] [PATCH] daemon: Do not lose storage driver
by Osier Yang 06 Jun '12

06 Jun '12

Per WITH_STORAGE_DIR is always defined as long as libvirtd is built, it's fine to use it as the condition. --- daemon/libvirtd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index c74cd43..7db02e3 100644 --- a/daemon/libvirtd.c +++ b/daemon/libvirtd.c @@ -366,7 +366,7 @@ static void daemonInitialize(void) # ifdef WITH_NETWORK virDriverLoadModule("network"); # endif -# ifdef WITH_STORAGE +# ifdef WITH_STORAGE_DIR virDriverLoadModule("storage"); # endif # ifdef WITH_NODE_DEVICES -- 1.7.7.3

2 3

[libvirt] [Fwd: error: this function is not supported by the connection driver : virConnectNumOfStoragePool]
by Onkar 05 Jun '12

05 Jun '12

Hello All, Any idea on this issue ? Regards, Onkar -------- Forwarded Message -------- From: Onkar <kernzap(a)gmail.com> To: libvir-list <libvir-list(a)redhat.com> Subject: error: this function is not supported by the connection driver : virConnectNumOfStoragePool Date: Wed, 30 May 2012 21:29:42 +0530 Hello, I configured libvirt like this ./configure --prefix=/ --exec-prefix=/usr/ --libdir=/usr/lib64/ --with-storage-dir --with-storage-dir --with-storage-dir --with-storage-dir --with-storage-dir --with-storage-dir --with-storage-dir --with-storage-dir --with-qemu --with-libvirtd --with-selinux --with-network --with-libblkid and then, make -j4 make install and then # virsh list --all Id Name State ---------------------------------------------------- - vm1 shut off # virsh pool-list --all error: Failed to list active pools error: this function is not supported by the connection driver: virConnectNumOfStoragePools getting this error , any clues on why is this error ? Regards, Onkar

4 4

[libvirt] Schedule of next release
by Daniel Veillard 05 Jun '12

05 Jun '12

I just looked and we are at 142 patches since the 0.9.12 release. If we were to keep the 1 month between releases schedule we would need to enter freeze at the end of the week, and that mean a relatively small release next. So I suggests to delay the release by 2 more weeks which also has the advantage to get back to the end of the month deadline which is easy to remember. So unless there is a pressing issue to make a release soon which I don't know about, let's plan to enter freeze around Jun 22 for a release at the end of month. As a note it seems that the rate of changes to libvirt is decreasing a bit (see http://veillard.com/commits_by_year_month.png which I generated at the end of may with gitstats) so maybe we should start planning for slighty longuer release cycles. Let's see how the trend evolves, but I doubt the rate wil increase over the summer :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

2 1

[libvirt] [PATCH v3 0/2] Rework RPC message buffer
by Michal Privoznik 05 Jun '12

05 Jun '12

This patch set tries to fix corner cases where libvirt runs on huge system, e.g. 4K CPU monster. In these cases, capabilities XML is enormously big, as we are transferring info about each singe CPU core (to which NUMA node it belongs, etc.). This XML is bigger than our RPC limit, therefore users cannot get it as it is dropped on server, leaving them with inability to connect. Therefore we need to increase those limits (whole RPC message and RPC string). However, simple lifting up will work, but increase mem usage. Therefore I've reworked RPC buffer handling: changed it from 'statically' to dynamically allocated. So in most cases - when small messages are sent - this will even decrease our memory consumption. Leaving us flexible for corner cases described above. On the other hand, I realize we've had our history with RPC breakage. So I think I'll require more than 1 ACK before pushing. (I guess Eric's ACK still holds) diff to v2: -suggestions from Eric's review included diff to v1: -couple of fixes (1/2) -increased other limits as well (2/2) Michal Privoznik (2): rpc: Switch to dynamically allocated message buffer rpc: Size up RPC limits src/libvirt.c | 2 + src/remote/remote_protocol.x | 20 +- src/rpc/virnetclient.c | 16 ++- src/rpc/virnetmessage.c | 12 ++- src/rpc/virnetmessage.h | 5 +- src/rpc/virnetprotocol.x | 6 +- src/rpc/virnetserverclient.c | 24 +++- tests/virnetmessagetest.c | 393 +++++++++++++++++++++++------------------- 8 files changed, 281 insertions(+), 197 deletions(-) -- 1.7.8.5

2 4

[libvirt] [PATCH] build: fix 'make distcheck' issues
by Eric Blake 05 Jun '12

05 Jun '12

We have a distributed file depending on a generated file, which is a no-no for a VPATH build from a read-only source tree (no wonder 'make distcheck' gives us precisely that situation): File `libvirt_driver_remote.la' does not exist. File `libvirt_driver_remote_la-remote_driver.lo' does not exist. Prerequisite `libvirt_probes.h' is newer than target `../../src/remote/remote_protocol.h'. Must remake target `../../src/remote/remote_protocol.h'. Invoking recipe from Makefile:7464 to update target `../../src/remote/remote_protocol.h'. make[3]: Entering directory `/home/remote/eblake/libvirt-tmp2/build/libvirt-0.9.12/_build/src' GEN ../../src/remote/remote_protocol.h cannot create ../../src/remote/remote_protocol.h: Permission denied at ../../src/rpc/genprotocol.pl line 31. make[3]: *** [../../src/remote/remote_protocol.h] Error 13 Rather than making distributed .c files depend on generated files, we really want to ensure that compilation into .lo files is not attempted until the generated files are present, done by this patch. After that fix, the next issue was that make treats './foo' and 'foo' differently in determining whether an implicit %foo rule is applicable. Also, the output for using the .aug test files was a bit verbose. After fixing that, the next error is related to the docs directory, where the tarball is missing a stamp file and thus tries to regenerate files that are already present: GEN ../../docs/apibuild.py.stamp Traceback (most recent call last): File "../../docs/apibuild.py", line 2511, in <module> rebuild("libvirt") File "../../docs/apibuild.py", line 2495, in rebuild builder.serialize() File "../../docs/apibuild.py", line 2424, in serialize output = open(filename, "w") IOError: [Errno 13] Permission denied: '../../docs/libvirt-api.xml' make[5]: *** [../../docs/apibuild.py.stamp] Error 1 and fixing that exposed another case of a distributed file (generated html) depending on a built file (libvirt.h). * src/Makefile.am ($(srcdir)/remote/remote_driver.c): Change... (libvirt_driver_remote_la-remote_driver.lo): ...to the real dependency. ($(builddir)/locking/%-sanlock.conf): Drop $(builddir), so that rule gets run in time for test_libvirt_sanlock.aug. (test_libvir*.aug): Cater to silent build. (conf_DATA): Don't ship qemu-sanlock.conf in the tarball, since it is trivial to regenerate. * docs/Makefile.am (EXTRA_DIST): Ship our stamp file. ($(APIBUILD_STAMP)): Don't depend on generated file. --- Painfully tested by running 'make distcheck' for each tweak until I got it to pass. However, I'd like a review before pushing. docs/Makefile.am | 5 ++++- src/Makefile.am | 15 ++++++++------- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index a03ca3e..88407b1 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -202,11 +202,14 @@ python_generated_files = \ APIBUILD=$(srcdir)/apibuild.py APIBUILD_STAMP=$(APIBUILD).stamp +EXTRA_DIST += $(APIBUILD_STAMP) $(python_generated_files): $(APIBUILD_STAMP) $(APIBUILD_STAMP): $(srcdir)/apibuild.py \ - $(srcdir)/../include/libvirt/*.h \ + $(srcdir)/../include/libvirt/libvirt.h.in \ + $(srcdir)/../include/libvirt/libvirt-qemu.h \ + $(srcdir)/../include/libvirt/virterror.h \ $(srcdir)/../src/libvirt.c \ $(srcdir)/../src/libvirt-qemu.c \ $(srcdir)/../src/util/virterror.c diff --git a/src/Makefile.am b/src/Makefile.am index 781c547..7b21317 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -649,7 +649,8 @@ libvirt_driver_remote_la_LIBADD = $(GNUTLS_LIBS) \ libvirt-net-rpc.la libvirt_driver_remote_la_SOURCES = $(REMOTE_DRIVER_SOURCES) -$(srcdir)/remote/remote_driver.c: $(REMOTE_DRIVER_GENERATED) +REMOTE_DRIVER_PREREQS = $(REMOTE_DRIVER_GENERATED) +%remote_driver.lo: $(REMOTE_DRIVER_PREREQS) endif WITH_REMOTE @@ -1125,7 +1126,7 @@ EXTRA_DIST += $(top_srcdir)/build-aux/augeas-gentest.pl if WITH_QEMU test_libvirtd_qemu.aug: qemu/test_libvirtd_qemu.aug.in \ $(srcdir)/qemu/qemu.conf $(AUG_GENTEST) - $(AUG_GENTEST) $(srcdir)/qemu/qemu.conf $< $@ + $(AM_V_GEN)$(AUG_GENTEST) $(srcdir)/qemu/qemu.conf $< $@ check-augeas-qemu: test_libvirtd_qemu.aug $(AM_V_GEN)if test -x '$(AUGPARSE)'; then \ @@ -1138,7 +1139,7 @@ endif if WITH_LXC test_libvirtd_lxc.aug: lxc/test_libvirtd_lxc.aug.in \ $(srcdir)/lxc/lxc.conf $(AUG_GENTEST) - $(AUG_GENTEST) $(srcdir)/lxc/lxc.conf $< $@ + $(AM_V_GEN)$(AUG_GENTEST) $(srcdir)/lxc/lxc.conf $< $@ check-augeas-lxc: test_libvirtd_lxc.aug $(AM_V_GEN)if test -x '$(AUGPARSE)'; then \ @@ -1150,7 +1151,7 @@ endif test_libvirt_sanlock.aug: locking/test_libvirt_sanlock.aug.in \ locking/qemu-sanlock.conf $(AUG_GENTEST) - $(AUG_GENTEST) locking/qemu-sanlock.conf $< $@ + $(AM_V_GEN)$(AUG_GENTEST) locking/qemu-sanlock.conf $< $@ check-augeas-sanlock: test_libvirt_sanlock.aug $(AM_V_GEN)if test -x '$(AUGPARSE)'; then \ @@ -1287,7 +1288,7 @@ libvirt_la_BUILT_LIBADD += libvirt_probes.lo libvirt_la_DEPENDENCIES += libvirt_probes.lo libvirt_probes.o nodist_libvirt_la_SOURCES = libvirt_probes.h if WITH_REMOTE -$(REMOTE_DRIVER_GENERATED): libvirt_probes.h +REMOTE_DRIVER_PREREQS += libvirt_probes.h endif WITH_REMOTE BUILT_SOURCES += libvirt_probes.h libvirt_probes.stp libvirt_functions.stp @@ -1361,12 +1362,12 @@ augeas_DATA += locking/libvirt_sanlock.aug augeastest_DATA += test_libvirt_sanlock.aug CLEANFILES += test_libvirt_sanlock.aug -$(builddir)/locking/%-sanlock.conf: $(srcdir)/locking/sanlock.conf +locking/%-sanlock.conf: $(srcdir)/locking/sanlock.conf $(AM_V_GEN)$(MKDIR_P) locking ; \ cp $< $@ if WITH_QEMU -conf_DATA += locking/qemu-sanlock.conf +nodist_conf_DATA = locking/qemu-sanlock.conf BUILT_SOURCES += locking/qemu-sanlock.conf DISTCLEANFILES += locking/qemu-sanlock.conf endif -- 1.7.7.6

2 2

[libvirt] How to add custom tag to the libvirt xml file for a new feature of the VM
by Yashwanth K P 05 Jun '12

05 Jun '12

Hello, I am working on libvirt development and I wanted to add a custom tag to the libvirt xml to add a new feature to the VM. I am having trouble getting started with this. It would be really helpful if you can help me get started with this and guide me on what part of the source code that has to be modified to achieve the goal. Thanks in advance. Regards, Yashwanth KP

2 1

[libvirt] [PATCH] tests: Refresh qemu-1.1.0 data
by Jiri Denemark 05 Jun '12

05 Jun '12

QEMU 1.1.0 has been officially released. With 1.1.0 QEMU went back to three-digits version even for the initial release and I renamed the data files to match this fact. They were generated with qemu-system-x86_64 -help >tests/qemuhelpdata/qemu-1.1.0 qemu-system-x86_64 \ -device ? \ -device pci-assign,? \ -device virtio-blk-pci,? \ -device virtio-net-pci,? \ -device scsi-disk,? 2>tests/qemuhelpdata/qemu-1.1.0-device --- Pushed as trivial. tests/qemuhelpdata/{qemu-1.1 => qemu-1.1.0} | 2 +- tests/qemuhelpdata/{qemu-1.1-device => qemu-1.1.0-device} | 2 +- tests/qemuhelptest.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) rename tests/qemuhelpdata/{qemu-1.1 => qemu-1.1.0} (99%) rename tests/qemuhelpdata/{qemu-1.1-device => qemu-1.1.0-device} (100%) diff --git a/tests/qemuhelpdata/qemu-1.1 b/tests/qemuhelpdata/qemu-1.1.0 similarity index 99% rename from tests/qemuhelpdata/qemu-1.1 rename to tests/qemuhelpdata/qemu-1.1.0 index 79bc8ba..761eb67 100644 --- a/tests/qemuhelpdata/qemu-1.1 +++ b/tests/qemuhelpdata/qemu-1.1.0 @@ -1,4 +1,4 @@ -QEMU emulator version 1.0.92, Copyright (c) 2003-2008 Fabrice Bellard +QEMU emulator version 1.1.0, Copyright (c) 2003-2008 Fabrice Bellard usage: qemu-system-x86_64 [options] [disk_image] 'disk_image' is a raw hard disk image for IDE hard disk 0 diff --git a/tests/qemuhelpdata/qemu-1.1-device b/tests/qemuhelpdata/qemu-1.1.0-device similarity index 100% rename from tests/qemuhelpdata/qemu-1.1-device rename to tests/qemuhelpdata/qemu-1.1.0-device index 64aacba..abbf850 100644 --- a/tests/qemuhelpdata/qemu-1.1-device +++ b/tests/qemuhelpdata/qemu-1.1.0-device @@ -101,11 +101,11 @@ virtio-blk-pci.opt_io_size=uint32 virtio-blk-pci.bootindex=int32 virtio-blk-pci.discard_granularity=uint32 virtio-blk-pci.serial=string +virtio-blk-pci.scsi=on/off virtio-blk-pci.ioeventfd=on/off virtio-blk-pci.vectors=uint32 virtio-blk-pci.indirect_desc=on/off virtio-blk-pci.event_idx=on/off -virtio-blk-pci.scsi=on/off virtio-blk-pci.addr=pci-devfn virtio-blk-pci.romfile=string virtio-blk-pci.rombar=uint32 diff --git a/tests/qemuhelptest.c b/tests/qemuhelptest.c index 46cc973..b7192c0 100644 --- a/tests/qemuhelptest.c +++ b/tests/qemuhelptest.c @@ -678,7 +678,7 @@ mymain(void) QEMU_CAPS_SCSI_BLOCK, QEMU_CAPS_SCSI_CD, QEMU_CAPS_IDE_CD); - DO_TEST("qemu-1.1", 1000092, 0, 0, + DO_TEST("qemu-1.1.0", 1001000, 0, 0, QEMU_CAPS_VNC_COLON, QEMU_CAPS_NO_REBOOT, QEMU_CAPS_DRIVE, -- 1.7.10.2

1 0