- Devel - libvirt List Archives

[libvirt] [PATCHv2 0/9] API to list all domains
by Peter Krempa 10 Jun '12

10 Jun '12

Second version of the atomic listing API. This version includes fixes and enhancements after Eric's review: - Enhanced documentation - NULL element at the end of the list - filtering flags and filter support - helper function to ease implementation across drivers - implementation to most of the drivers - enhancement of the virsh helper that now supports filter simulation For some of the drivers I don't have means to test the implementation apart from compiling it. Please beaware of those. Peter Krempa (9): lib: Add public api to enable atomic listing of guest python: add API exports for virConnectListAllDomains() remote: implement remote protocol for virConnectListAllDomains() conf: Add helper for listing domains on drivers supporting virDomainObj drivers: Implement virListAllDomains for drivers using virDomainObj vbox: Add support for virDomainList hyperv: Add implementation for virConnectListAllDomains() esx: Add implementation for virConnectListAllDomains() virsh: add support for virConnectListAllDomains and clean up cmdList daemon/remote.c | 52 ++++ include/libvirt/libvirt.h.in | 36 +++- python/generator.py | 1 + python/libvirt-override-api.xml | 12 +- python/libvirt-override-virConnect.py | 12 + python/libvirt-override.c | 47 ++++- src/Makefile.am | 6 +- src/conf/virdomainlist.c | 214 +++++++++++++++ src/conf/virdomainlist.h | 36 +++ src/driver.h | 11 +- src/esx/esx_driver.c | 108 ++++++++ src/hyperv/hyperv_driver.c | 95 +++++++ src/libvirt.c | 122 +++++++++- src/libvirt_private.syms | 5 + src/libvirt_public.syms | 5 + src/libxl/libxl_driver.c | 33 +++ src/lxc/lxc_driver.c | 32 +++ src/openvz/openvz_driver.c | 30 ++ src/qemu/qemu_driver.c | 87 ++++++- src/remote/remote_driver.c | 63 +++++ src/remote/remote_protocol.x | 14 +- src/remote_protocol-structs | 12 + src/test/test_driver.c | 31 +++ src/uml/uml_driver.c | 31 +++ src/vbox/vbox_tmpl.c | 133 ++++++++++ src/vmware/vmware_driver.c | 31 +++ tools/virsh.c | 469 +++++++++++++++++++++------------ 27 files changed, 1536 insertions(+), 192 deletions(-) create mode 100644 src/conf/virdomainlist.c create mode 100644 src/conf/virdomainlist.h -- 1.7.3.4

2 21

[libvirt] Compiling out SSL support - status?
by Chris Van Heuveln 08 Jun '12

08 Jun '12

Hi, I want to remove TLS from libvirt (0.8.4). I ran across this earlier thread on the same topic: http://www.redhat.com/archives/libvir-list/2012-January/msg00479.html ...just curious if any further development occurred in this area since then? ie, support for a --without-gnutls compiler option. Thanks, Chris

2 2

[libvirt] [PATCH] Only check for cluster fs if we're using a filesystem
by Guido Günther 08 Jun '12

08 Jun '12

otherwise migration fails for e.g. network filesystems like sheepdog with: error: Invalid relative path 'virt-name': Invalid argument while we should fail with: Migration may lead to data corruption if disks use cache != none References: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=676328 https://www.redhat.com/archives/libvirt-users/2012-May/msg00088.html --- src/qemu/qemu_migration.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index b58380b..a1fb962 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -840,10 +840,13 @@ qemuMigrationIsSafe(virDomainDefPtr def) !disk->readonly && disk->cachemode != VIR_DOMAIN_DISK_CACHE_DISABLE) { int cfs; - if ((cfs = virStorageFileIsClusterFS(disk->src)) == 1) - continue; - else if (cfs < 0) - return false; + + if (disk->type == VIR_DOMAIN_DISK_TYPE_FILE) { + if ((cfs = virStorageFileIsClusterFS(disk->src)) == 1) + continue; + else if (cfs < 0) + return false; + } qemuReportError(VIR_ERR_MIGRATE_UNSAFE, "%s", _("Migration may lead to data corruption if disks" -- 1.7.10

2 2

[libvirt] libvirt Application Development Guide - revival
by Scott Radvan 08 Jun '12

08 Jun '12

Hi list, I write virtualization docs for Red Hat and would like to maintain this guide[1] - it's in need of a bit of attention. I have publican and the publican brand up and running, and have already cloned the git repo, but I would appreciate some help on how to get commit access, or any other pertinent info I should be aware of before getting started. Any comments on the guide (ideas for new sections, future trends for libvirt app development, parts that are plain wrong) would be more than welcome! A Red Hat Bugzilla component is set up for this guide: doc-Libvirt_Application_Development_Guide (under the Red Hat Enterprise Linux 6 product). Thanks for your help, [1] http://libvirt.org/devguide.html -- Scott Radvan Content Author II Platform (Virtualization) Red Hat APAC

3 2

[libvirt] [PATCH] snapshot: add virDomainSnapshotRef API
by Eric Blake 08 Jun '12

08 Jun '12

virDomainSnapshotPtr has a refcount member, but no one was able to use it. Furthermore, all of our other vir*Ptr objects have a *Ref method to match their *Free method. Thankfully, this is client-side only, so we can use this new function regardless of how old the server side is! (I have future patches to virsh that want to use it.) * include/libvirt/libvirt.h.in (virDomainSnapshotRef): Declare. * src/libvirt.c (virDomainSnapshotRef): Implement it. * src/libvirt_public.syms (LIBVIRT_0.9.13): Export it. --- include/libvirt/libvirt.h.in | 1 + src/libvirt.c | 33 +++++++++++++++++++++++++++++++++ src/libvirt_public.syms | 5 +++++ 3 files changed, 39 insertions(+) diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index da3ce29..fcb6695 100644 --- a/include/libvirt/libvirt.h.in +++ b/include/libvirt/libvirt.h.in @@ -3424,6 +3424,7 @@ typedef enum { int virDomainSnapshotDelete(virDomainSnapshotPtr snapshot, unsigned int flags); +int virDomainSnapshotRef(virDomainSnapshotPtr snapshot); int virDomainSnapshotFree(virDomainSnapshotPtr snapshot); /* diff --git a/src/libvirt.c b/src/libvirt.c index 6386ed4..00358d6 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -17487,6 +17487,39 @@ error: } /** + * virDomainSnapshotRef: + * @snapshot: the snapshot to hold a reference on + * + * Increment the reference count on the snapshot. For each + * additional call to this method, there shall be a corresponding + * call to virDomainSnapshotFree to release the reference count, once + * the caller no longer needs the reference to this object. + * + * This method is typically useful for applications where multiple + * threads are using a connection, and it is required that the + * connection and domain remain open until all threads have finished + * using the snapshot. ie, each new thread using a snapshot would + * increment the reference count. + * + * Returns 0 in case of success and -1 in case of failure. + */ +int +virDomainSnapshotRef(virDomainSnapshotPtr snapshot) +{ + if ((!VIR_IS_DOMAIN_SNAPSHOT(snapshot))) { + virLibDomainSnapshotError(VIR_ERR_INVALID_DOMAIN_SNAPSHOT, + __FUNCTION__); + virDispatchError(NULL); + return -1; + } + virMutexLock(&snapshot->domain->conn->lock); + VIR_DEBUG("snapshot=%p, refs=%d", snapshot, snapshot->refs); + snapshot->refs++; + virMutexUnlock(&snapshot->domain->conn->lock); + return 0; +} + +/** * virDomainSnapshotFree: * @snapshot: a domain snapshot object * diff --git a/src/libvirt_public.syms b/src/libvirt_public.syms index 46c13fb..ba61595 100644 --- a/src/libvirt_public.syms +++ b/src/libvirt_public.syms @@ -534,4 +534,9 @@ LIBVIRT_0.9.11 { virDomainPMWakeup; } LIBVIRT_0.9.10; +LIBVIRT_0.9.13 { + global: + virDomainSnapshotRef; +} LIBVIRT_0.9.11; + # .... define new API here using predicted next version number .... -- 1.7.10.2

2 2

Re: [libvirt] [Qemu-devel] [PATCH v2 0/4] file descriptor passing using passfd
by Corey Bryant 08 Jun '12

08 Jun '12

Please review this patch series if you could. I apologize for sending it more than once. Thanks! -- Regards, Corey On 06/08/2012 11:42 AM, Corey Bryant wrote: > libvirt's sVirt security driver provides SELinux MAC isolation for > Qemu guest processes and their corresponding image files. In other > words, sVirt uses SELinux to prevent a QEMU process from opening > files that do not belong to it. > > sVirt provides this support by labeling guests and resources with > security labels that are stored in file system extended attributes. > Some file systems, such as NFS, do not support the extended > attribute security namespace, and therefore cannot support sVirt > isolation. > > A solution to this problem is to provide fd passing support, where > libvirt opens files and passes file descriptors to QEMU. This, > along with SELinux policy to prevent QEMU from opening files, can > provide image file isolation for NFS files stored on the same NFS > mount. > > This patch series adds the passfd QMP monitor command, which allows > an fd to be passed via SCM_RIGHTS, and returns the received file > descriptor. Support is also added to the block layer to allow QEMU > to dup the fd when the filename is of the /dev/fd/X format. This > is useful if MAC policy prevents QEMU from opening specific types > of files. > > One nice thing about this approach is that no new SELinux policy is > required to prevent open of NFS files (files with type nfs_t). The > virt_use_nfs boolean type simply needs to be set to false, and open > will be prevented (and dup will be allowed). For example: > > # setsebool virt_use_nfs 0 > # getsebool virt_use_nfs > virt_use_nfs --> off > > Corey Bryant (4): > qapi: Convert getfd and closefd > qapi: Add passfd QMP command > osdep: Enable qemu_open to dup pre-opened fd > block: Convert open calls to qemu_open > > block/raw-posix.c | 18 +++++++++--------- > block/raw-win32.c | 4 ++-- > block/vdi.c | 5 +++-- > block/vmdk.c | 21 +++++++++------------ > block/vpc.c | 2 +- > block/vvfat.c | 21 +++++++++++---------- > hmp-commands.hx | 6 ++---- > hmp.c | 18 ++++++++++++++++++ > hmp.h | 2 ++ > monitor.c | 36 ++++++++++++++++++++---------------- > osdep.c | 13 +++++++++++++ > qapi-schema.json | 44 ++++++++++++++++++++++++++++++++++++++++++++ > qmp-commands.hx | 33 +++++++++++++++++++++++++++++---- > 13 files changed, 163 insertions(+), 60 deletions(-) >

1 0

Re: [libvirt] [Qemu-devel] [PATCH v2 0/4] file descriptor passing using passfd
by Corey Bryant 08 Jun '12

08 Jun '12

Please ignore this series as well. Something is amiss. I'll be resending. -- Regards, Corey On 06/08/2012 10:53 AM, Corey Bryant wrote: > libvirt's sVirt security driver provides SELinux MAC isolation for > Qemu guest processes and their corresponding image files. In other > words, sVirt uses SELinux to prevent a QEMU process from opening > files that do not belong to it. > > sVirt provides this support by labeling guests and resources with > security labels that are stored in file system extended attributes. > Some file systems, such as NFS, do not support the extended > attribute security namespace, and therefore cannot support sVirt > isolation. > > A solution to this problem is to provide fd passing support, where > libvirt opens files and passes file descriptors to QEMU. This, > along with SELinux policy to prevent QEMU from opening files, can > provide image file isolation for NFS files stored on the same NFS > mount. > > This patch series adds the passfd QMP monitor command, which allows > an fd to be passed via SCM_RIGHTS, and returns the received file > descriptor. Support is also added to the block layer to allow QEMU > to dup the fd when the filename is of the /dev/fd/X format. This > is useful if MAC policy prevents QEMU from opening specific types > of files. > > One nice thing about this approach is that no new SELinux policy is > required to prevent open of NFS files (files with type nfs_t). The > virt_use_nfs boolean type simply needs to be set to false, and open > will be prevented (and dup will be allowed). For example: > > # setsebool virt_use_nfs 0 > # getsebool virt_use_nfs > virt_use_nfs --> off > > Corey Bryant (4): > qapi: Convert getfd and closefd > qapi: Add passfd QMP command > osdep: Enable qemu_open to dup pre-opened fd > block: Convert open calls to qemu_open > > block/raw-posix.c | 18 +++++++++--------- > block/raw-win32.c | 4 ++-- > block/vdi.c | 5 +++-- > block/vmdk.c | 21 +++++++++------------ > block/vpc.c | 2 +- > block/vvfat.c | 21 +++++++++++---------- > hmp-commands.hx | 6 ++---- > hmp.c | 18 ++++++++++++++++++ > hmp.h | 2 ++ > monitor.c | 36 ++++++++++++++++++++---------------- > osdep.c | 13 +++++++++++++ > qapi-schema.json | 44 ++++++++++++++++++++++++++++++++++++++++++++ > qmp-commands.hx | 33 +++++++++++++++++++++++++++++---- > 13 files changed, 163 insertions(+), 60 deletions(-) > -- Regards, Corey

1 0

Re: [libvirt] [Qemu-devel] [PATCH v2 0/4] file descriptor passing using passfd
by Corey Bryant 08 Jun '12

08 Jun '12

Please ignore this series. Something is amiss. I'll be resending. -- Regards, Corey On 06/08/2012 10:49 AM, Corey Bryant wrote: > libvirt's sVirt security driver provides SELinux MAC isolation for > Qemu guest processes and their corresponding image files. In other > words, sVirt uses SELinux to prevent a QEMU process from opening > files that do not belong to it. > > sVirt provides this support by labeling guests and resources with > security labels that are stored in file system extended attributes. > Some file systems, such as NFS, do not support the extended > attribute security namespace, and therefore cannot support sVirt > isolation. > > A solution to this problem is to provide fd passing support, where > libvirt opens files and passes file descriptors to QEMU. This, > along with SELinux policy to prevent QEMU from opening files, can > provide image file isolation for NFS files stored on the same NFS > mount. > > This patch series adds the passfd QMP monitor command, which allows > an fd to be passed via SCM_RIGHTS, and returns the received file > descriptor. Support is also added to the block layer to allow QEMU > to dup the fd when the filename is of the /dev/fd/X format. This > is useful if MAC policy prevents QEMU from opening specific types > of files. > > One nice thing about this approach is that no new SELinux policy is > required to prevent open of NFS files (files with type nfs_t). The > virt_use_nfs boolean type simply needs to be set to false, and open > will be prevented (and dup will be allowed). For example: > > # setsebool virt_use_nfs 0 > # getsebool virt_use_nfs > virt_use_nfs --> off > > Corey Bryant (4): > qapi: Convert getfd and closefd > qapi: Add passfd QMP command > osdep: Enable qemu_open to dup pre-opened fd > block: Convert open calls to qemu_open > > block/raw-posix.c | 18 +++++++++--------- > block/raw-win32.c | 4 ++-- > block/vdi.c | 5 +++-- > block/vmdk.c | 21 +++++++++------------ > block/vpc.c | 2 +- > block/vvfat.c | 21 +++++++++++---------- > hmp-commands.hx | 6 ++---- > hmp.c | 18 ++++++++++++++++++ > hmp.h | 2 ++ > monitor.c | 36 ++++++++++++++++++++---------------- > osdep.c | 13 +++++++++++++ > qapi-schema.json | 44 ++++++++++++++++++++++++++++++++++++++++++++ > qmp-commands.hx | 33 +++++++++++++++++++++++++++++---- > 13 files changed, 163 insertions(+), 60 deletions(-) > -- Regards, Corey

1 0

[libvirt] pointless time-consuming test 'virsh-all'
by Eric Blake 08 Jun '12

08 Jun '12

The command 'make -C tests check' takes forever, because it is calling this lengthy virsh command and ignoring the failures: $ time tools/virsh -c test:///default connect error: Failed to connect to the hypervisor error: Failed to connect socket to '/run/user/eblake/libvirt/libvirt-sock': No such file or directory real 0m21.070s user 0m0.027s sys 0m0.036s The test looks quite broken - ALL it is currently doing is wasting 21 seconds on this one iteration, because it ignores output and exit status (what else _is_ there, besides effects to the file system)? Any volunteers to clean this test up into something that actually does something useful? -- Eric Blake eblake(a)redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org

5 9

[libvirt] daemon: Install libvirtd under 'bin' not 'sbin'
by Zeeshan Ali (Khattak) 08 Jun '12

08 Jun '12

From: "Zeeshan Ali (Khattak)" <zeeshanak(a)gnome.org> This binary is not admin-only at all and launching it as normal user is a supported use case: session. --- daemon/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemon/Makefile.am b/daemon/Makefile.am index fbb0ae1..472e523 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -70,7 +70,7 @@ if WITH_LIBVIRTD man8_MANS = libvirtd.8 -sbin_PROGRAMS = libvirtd +bin_PROGRAMS = libvirtd confdir = $(sysconfdir)/libvirt/ conf_DATA = libvirtd.conf -- 1.7.10.2

4 7