- Devel - libvirt List Archives

[libvirt] [PATCH] error: Fix macro checking for NULL arguments
by Peter Krempa 19 Jun '12

19 Jun '12

Macro virCheckNullArgGoto is supposed to check for NULL argument but checks non-NULL instead. --- src/internal.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/internal.h b/src/internal.h index 1b1598b..b09609e 100644 --- a/src/internal.h +++ b/src/internal.h @@ -241,21 +241,21 @@ # define virCheckNonNullArgReturn(argname, retval) \ do { \ if (argname == NULL) { \ virReportInvalidNullArg(argname); \ return retval; \ } \ } while (0) # define virCheckNullArgGoto(argname, label) \ do { \ - if (argname == NULL) { \ + if (argname != NULL) { \ virReportInvalidNullArg(argname); \ goto label; \ } \ } while (0) # define virCheckNonNullArgGoto(argname, label) \ do { \ if (argname == NULL) { \ virReportInvalidNonNullArg(argname); \ goto label; \ } \ -- 1.7.8.6

2 4

Re: [libvirt] ask for help to explain the network about tap
by Yong Sheng Gong 19 Jun '12

19 Jun '12

Can any one help? thanks -----Yong Sheng Gong/China/IBM wrote: ----- To: Eric Blake <eblake(a)redhat.com> From: Yong Sheng Gong/China/IBM Date: 06/17/2012 11:11AM Cc: libvir-list(a)redhat.com Subject: Re: [libvirt] ask for help to explain the network about tap Hi Eric, Thanks for the reply. I have a new question. I found I cannot ping the VM with predefined tap device in domain xml from other host(means the machine other than the hyper visor is running on): <interface type='ethernet'> <mac address='f6:19:e0:6c:84:c3'/> <script path=''/> <target dev='tap10'/> <alias name='net0'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> </interface> But I can ping the VM with libvirtd defined tap device in domain xml from other host: <interface type='bridge'> <mac address='52:54:00:e4:2e:c1'/> <source bridge='br200'/> <target dev='vnet0'/> <model type='virtio'/> <alias name='net0'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> </interface> [root@robinlinux ~]# brctl show bridge name bridge id STP enabled interfaces br100 8000.0021cc6d4440 no eth0 br200 8000.0021cc6d4443 no eth0.1000 gw200 tap10 vnet0 And I can ping both of VMs from local host. What does libvirtd do to allow the bridge to forward the packet to the tap device attached by target VM? As far as I know all the packets destined to the bridge's ports from outside will be consumed by bridge itself, not xmit to particular port. Thanks Yong Sheng Gong -----Eric Blake <eblake(a)redhat.com> wrote: ----- To: Yong Sheng Gong/China/IBM@IBMCN From: Eric Blake <eblake(a)redhat.com> Date: 06/15/2012 12:36PM Cc: libvir-list(a)redhat.com Subject: Re: [libvirt] ask for help to explain the network about tap On 06/14/2012 08:49 PM, Yong Sheng Gong wrote: > > Hi, > I don't know who helps qemu-kvm to create and open the tap file and when if I define an interface of a kvm vm like: > <interface type='bridge'> > <mac address='52:54:00:e4:2e:c1'/> > <source bridge='br200'/> > <model type='virtio'/> > <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> > </interface> > > The qemu-kvm process's command line will be: <snip> > > Note the -netdev tap,fd=24 That's libvirtd that opened the tap file, and passed it by inheritance to the new qemu process. Unfortunately, this means that you can't recreate the same qemu process without also opening the tap device yourself the same way that libvirtd would do it. But this approach of fd passing is essential to security, since libvirtd intentionally removes capabilities that prevent qemu from opening the tap itself, so libvirtd must pass in the fd pre-opened. Did you have specific questions about which functions in libvirt source code open the tap device? Also, note that libvirtd will issue an audit log event for every tapfd that it opens and gives to qemu. The fd number is unpredictable, but the fact that an fd was opened as backed by a tap device is pretty easy to follow in the audit logs. -- Eric Blake eblake(a)redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org [attachment "signature.asc" removed by Yong Sheng Gong/China/IBM]

1 0

[libvirt] [PATCH] virsh: make domiftune interface help string consistent
by Martin Kletzander 19 Jun '12

19 Jun '12

Append '(MAC Address)' after the help string of domiftune virsh command as it takes the same type of argument as domif-{get,set}link which have it specified. --- Pushed under 'trivial' rule. tools/virsh.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 1e1de39..fffa482 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -2019,7 +2019,7 @@ static const vshCmdInfo info_domiftune[] = { static const vshCmdOptDef opts_domiftune[] = { {"domain", VSH_OT_DATA, VSH_OFLAG_REQ, N_("domain name, id or uuid")}, - {"interface", VSH_OT_DATA, VSH_OFLAG_REQ, N_("interface device")}, + {"interface", VSH_OT_DATA, VSH_OFLAG_REQ, N_("interface device (MAC Address)")}, {"inbound", VSH_OT_DATA, VSH_OFLAG_NONE, N_("control domain's incoming traffics")}, {"outbound", VSH_OT_DATA, VSH_OFLAG_NONE, N_("control domain's outgoing traffics")}, {"config", VSH_OT_BOOL, VSH_OFLAG_NONE, N_("affect next boot")}, -- 1.7.8.6

1 0

[libvirt] [sandbox][PATCH] Typo and example fix
by Radu Caragea 19 Jun '12

19 Jun '12

I fixed a typo in the strace debug feature, if you specified LIBVIRT_SANDBOX_STRACE=poll it would write "strace =poll" in the kernel command line and consequently it wouldn't get picked up because of that extra space. Also, the example virt-sandbox.py was a bit outdated so I updated it. The shell.py doesn't work as it has serial1 hardcoded for qemu. I haven't checked the rest.

2 1

[libvirt] [PATCH] add handling EINTR to test example of event loop
by lvroyce＠linux.vnet.ibm.com 19 Jun '12

19 Jun '12

From: lvroyce <lvroyce(a)linux.vnet.ibm.com> some system call and signal will interrupt poll, making event loop stops and fails to react events and keepalive message from libvirt. adding handling EINTR to poll to make it more robust Signed-off-by: lvroyce <lvroyce(a)linux.vnet.ibm.com> --- examples/domain-events/events-python/event-test.py | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/examples/domain-events/events-python/event-test.py b/examples/domain-events/events-python/event-test.py index 96dc268..b446c21 100644 --- a/examples/domain-events/events-python/event-test.py +++ b/examples/domain-events/events-python/event-test.py @@ -188,7 +188,13 @@ class virEventLoopPure: sleep = (next - now) / 1000.0 debug("Poll with a sleep of %d" % sleep) - events = self.poll.poll(sleep) + try: + events = self.poll.poll(sleep) + except select.error, e: + self.runningPoll = False + if not e.errno in (errno.EINTR, errno.EAGAIN): + raise + return # Dispatch any file handle events that occurred for (fd, revents) in events: -- 1.7.7.6

3 3

[libvirt] [PATCH 02/02] libvirt-java add domain flags and error constants up to 0.9, 2
by Stefan Majer 19 Jun '12

19 Jun '12

-- Stefan Majer

1 0

[libvirt] [PATCH 01/02] libvirt-java add domain flags and error constants up to 0.9, 2
by Stefan Majer 19 Jun '12

19 Jun '12

-- Stefan Majer

1 0

[libvirt] [PATCH v2] LXC: avoid useless duplicate memory free
by Gao feng 19 Jun '12

19 Jun '12

when lxcContainerIdentifyCGroups failed, the memory it allocated has been freed, so we should not free this memory again in lxcContainerSetupPivortRoot and lxcContainerSetupExtraMounts. Signed-off-by: Gao feng <gaofeng(a)cn.fujitsu.com> --- src/lxc/lxc_container.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 9045a7d..24b1017 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -1323,7 +1323,7 @@ static int lxcContainerSetupPivotRoot(virDomainDefPtr vmDef, /* Before pivoting we need to identify any * cgroups controllers that are mounted */ if (lxcContainerIdentifyCGroups(&mounts, &nmounts) < 0) - goto cleanup; + return -1; /* Gives us a private root, leaving all parent OS mounts on /.oldroot */ if (lxcContainerPivotRoot(root) < 0) @@ -1406,7 +1406,7 @@ static int lxcContainerSetupExtraMounts(virDomainDefPtr vmDef, /* Before replacing /sys we need to identify any * cgroups controllers that are mounted */ if (lxcContainerIdentifyCGroups(&mounts, &nmounts) < 0) - goto cleanup; + return -1; /* Gets rid of any existing stuff under /proc, since we need new * namespace aware versions of those. We must do /proc second -- 1.7.7.6

2 2

[libvirt] [PATCHv2] adding handling EINTR to poll to make it more robust
by lvroyce＠linux.vnet.ibm.com 19 Jun '12

19 Jun '12

From: Royce Lv <lvroyce(a)linux.vnet.ibm.com> some system call and signal will interrupt poll, making event loop stops and fails to react events and keepalive message from libvirt. adding handling EINTR to poll to make it more robust Signed-off-by: Royce Lv <lvroyce(a)linux.vnet.ibm.com> --- examples/domain-events/events-python/event-test.py | 95 +++++++++++--------- 1 files changed, 51 insertions(+), 44 deletions(-) diff --git a/examples/domain-events/events-python/event-test.py b/examples/domain-events/events-python/event-test.py index 96dc268..7832d13 100644 --- a/examples/domain-events/events-python/event-test.py +++ b/examples/domain-events/events-python/event-test.py @@ -2,9 +2,9 @@ # # # -################################################################################# +############################################################################## # Start off by implementing a general purpose event loop for anyones use -################################################################################# +############################################################################## import sys import getopt @@ -27,11 +27,14 @@ import threading use_pure_python_event_loop = True do_debug = False + + def debug(msg): global do_debug if do_debug: print msg + # # This general purpose event loop will support waiting for file handle # I/O and errors events, as well as scheduling repeatable timers with @@ -97,7 +100,6 @@ class virEventLoopPure: self.cb(self.timer, self.opaque) - def __init__(self): self.poll = select.poll() self.pipetrick = os.pipe() @@ -178,48 +180,53 @@ class virEventLoopPure: def run_once(self): sleep = -1 self.runningPoll = True - next = self.next_timeout() - debug("Next timeout due at %d" % next) - if next > 0: - now = int(time.time() * 1000) - if now >= next: - sleep = 0 - else: - sleep = (next - now) / 1000.0 - - debug("Poll with a sleep of %d" % sleep) - events = self.poll.poll(sleep) - - # Dispatch any file handle events that occurred - for (fd, revents) in events: - # See if the events was from the self-pipe - # telling us to wakup. if so, then discard - # the data just continue - if fd == self.pipetrick[0]: - self.pendingWakeup = False - data = os.read(fd, 1) - continue - - h = self.get_handle_by_fd(fd) - if h: - debug("Dispatch fd %d handle %d events %d" % (fd, h.get_id(), revents)) - h.dispatch(self.events_from_poll(revents)) + try: + next = self.next_timeout() + debug("Next timeout due at %d" % next) + if next > 0: + now = int(time.time() * 1000) + if now >= next: + sleep = 0 + else: + sleep = (next - now) / 1000.0 + + debug("Poll with a sleep of %d" % sleep) + events = self.poll.poll(sleep) + + # Dispatch any file handle events that occurred + for (fd, revents) in events: + # See if the events was from the self-pipe + # telling us to wakup. if so, then discard + # the data just continue + if fd == self.pipetrick[0]: + self.pendingWakeup = False + data = os.read(fd, 1) + continue + + h = self.get_handle_by_fd(fd) + if h: + debug("Dispatch fd %d handle %d events %d" % (fd, h.get_id(), revents)) + h.dispatch(self.events_from_poll(revents)) - now = int(time.time() * 1000) - for t in self.timers: - interval = t.get_interval() - if interval < 0: - continue - - want = t.get_last_fired() + interval - # Deduct 20ms, since schedular timeslice - # means we could be ever so slightly early - if now >= (want-20): - debug("Dispatch timer %d now %s want %s" % (t.get_id(), str(now), str(want))) - t.set_last_fired(now) - t.dispatch() - - self.runningPoll = False + now = int(time.time() * 1000) + for t in self.timers: + interval = t.get_interval() + if interval < 0: + continue + + want = t.get_last_fired() + interval + # Deduct 20ms, since schedular timeslice + # means we could be ever so slightly early + if now >= (want-20): + debug("Dispatch timer %d now %s want %s" % (t.get_id(), str(now), str(want))) + t.set_last_fired(now) + t.dispatch() + + except (os.error, select.error), e: + if e.errno != errno.EINTR: + raise + finally: + self.runningPoll = False # Actually the event loop forever -- 1.7.7.6

1 0

[libvirt] pool-create/pool-create-as should include build pool then start?
by Zhimou Peng 19 Jun '12

19 Jun '12

Hi all, According to https://bugzilla.redhat.com/show_bug.cgi?id=830056#c5, i think we should talk about this: Description If pool environment is not built, pool-create/pool-create-as will always fail. I think pool-create should build the pool. Version qemu-kvm-0.12.1.2-2.295.el6.x86_64 kernel-2.6.32-276.el6.x86_64 libvirt-0.9.10-21.el6.x86_64 Steps For example: dir pool virsh # pool-create dirpool.xml error: Failed to create pool from dirpool.xml error: cannot open path '/var/lib/libvirt/dir': No such file or directory disk pool virsh # pool-create diskpool.xml error: Failed to create pool from diskpool.xml error: internal error Child process (/usr/libexec/libvirt_parthelper /dev/sdb) status unexpected: exit status 2 fs pool virsh # pool-create fspool.xml error: Failed to create pool from fspool.xml error: internal error Child process (/bin/mount -t ext4 /dev/sda7 /var/lib/libvirt/images/fspool) status unexpected: exit status 32 Steps are the same of other pools

2 2