- Devel - libvirt List Archives

[libvirt] Different mac address used in libvirtd
by Yong Sheng Gong 19 Jul '12

19 Jul '12

Hi, I found libvirtd will create vnet0 with a different mac other than the one defined in domain file. The mac in Domain file will be used by qemu-kvm. I want to know how libvirtd decides the mac for vnet0, Who can give me a hint about the location of the libvirtd codes which does this work? I cannot find how the libvirtd translates the mac from one defined in domain file to vnet0's one in src/util/bridge.c: brSetInterfaceMac() Thanks Yong Sheng Gong [root@robinlinux eclipsecdt]# virsh dumpxml 2 <domain type='kvm' id='2'> <name>instance-00000002</name> <uuid>03e9993b-eafa-4021-b929-4a51ce9635d5</uuid> <memory>524288</memory> <currentMemory>524288</currentMemory> <vcpu>1</vcpu> <os> <type arch='x86_64' machine='pc-0.14'>hvm</type> <kernel>/var/lib/nova/instances/instance-00000002/kernel</kernel> <initrd>/var/lib/nova/instances/instance-00000002/ramdisk</initrd> <cmdline>root=/dev/vda console=ttyS0</cmdline> <boot dev='hd'/> </os> <features> <acpi/> </features> <clock offset='utc'> <timer name='pit' tickpolicy='delay'/> <timer name='rtc' tickpolicy='catchup'/> </clock> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>destroy</on_crash> <devices> <emulator>/usr/libexec/qemu-kvm</emulator> <disk type='file' device='disk'> <driver name='qemu' type='qcow2' cache='none'/> <source file='/var/lib/nova/instances/instance-00000002/disk'/> <target dev='vda' bus='virtio'/> <alias name='virtio-disk0'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/> </disk> <interface type='bridge'> <mac address='fa:16:3e:28:64:c2'/> <source bridge='br100'/> <target dev='vnet0'/> <filterref filter='nova-instance-instance-00000002-fa163e2864c2'> <parameter name='DHCPSERVER' value='10.0.1.1'/> <parameter name='PROJNET' value='10.0.1.0'/> <parameter name='PROJMASK' value='255.255.255.0'/> <parameter name='IP' value='10.0.1.2'/> </filterref> <alias name='net0'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> </interface> <serial type='file'> <source path='/var/lib/nova/instances/instance-00000002/console.log'/> <target port='0'/> <alias name='serial0'/> </serial> <serial type='pty'> <source path='/dev/pts/1'/> <target port='1'/> <alias name='serial1'/> </serial> <console type='file'> <source path='/var/lib/nova/instances/instance-00000002/console.log'/> <target type='serial' port='0'/> <alias name='serial0'/> </console> <input type='tablet' bus='usb'> <alias name='input0'/> </input> <input type='mouse' bus='ps2'/> <graphics type='vnc' port='5900' autoport='yes' listen='127.0.0.1' keymap='en-us'> <listen type='address' address='127.0.0.1'/> </graphics> <video> <model type='cirrus' vram='9216' heads='1'/> <alias name='video0'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/> </video> <memballoon model='virtio'> <alias name='balloon0'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/> </memballoon> </devices> </domain> [root@robinlinux eclipsecdt]# ifconfig vnet0 vnet0 Link encap:Ethernet HWaddr FE:16:3E:28:64:C2 inet6 addr: fe80::fc16:3eff:fe28:64c2/64 Scope:Link UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:553 errors:0 dropped:0 overruns:0 frame:0 TX packets:1485 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:500 RX bytes:136360 (133.1 KiB) TX bytes:280590 (274.0 KiB)

3 2

[libvirt] [PATCH] Fix Xen driver to have sensible error messages
by Daniel P. Berrange 19 Jul '12

19 Jul '12

From: "Daniel P. Berrange" <berrange(a)redhat.com> The Xen driver had a number of error reports which passed a constant string without format specifiers and was missing "%s". Furthermore the errors were related to failing system calls, but virReportSystemError was not used. So the only useful piece of info (the errno) was being discarded --- cfg.mk | 2 +- src/xen/xen_hypervisor.c | 114 ++++++++++++++++++++++------------------------ 2 files changed, 55 insertions(+), 61 deletions(-) diff --git a/cfg.mk b/cfg.mk index 4225336..46331fd 100644 --- a/cfg.mk +++ b/cfg.mk @@ -540,6 +540,7 @@ msg_gen_function += virReportError msg_gen_function += virReportErrorHelper msg_gen_function += virReportSystemError msg_gen_function += virSecurityReportError +msg_gen_function += virXenError msg_gen_function += virXenInotifyError msg_gen_function += virXenStoreError msg_gen_function += virXendError @@ -552,7 +553,6 @@ msg_gen_function += xenXMError # so that they are translatable. # msg_gen_function += fprintf # msg_gen_function += testError -# msg_gen_function += virXenError # msg_gen_function += vshPrint # msg_gen_function += vshError diff --git a/src/xen/xen_hypervisor.c b/src/xen/xen_hypervisor.c index b4ec579..9747010 100644 --- a/src/xen/xen_hypervisor.c +++ b/src/xen/xen_hypervisor.c @@ -526,9 +526,15 @@ static int lock_pages(void *addr, size_t len) { #ifdef __linux__ - return mlock(addr, len); + if (mlock(addr, len) < 0) { + virReportSystemError(errno, + _("Unable to lock %zu bytes of memory"), + len); + return -1; + } + return 0; #elif defined(__sun) - return 0; + return 0; #endif } @@ -536,9 +542,15 @@ static int unlock_pages(void *addr, size_t len) { #ifdef __linux__ - return munlock(addr, len); + if (munlock(addr, len) < 0) { + virReportSystemError(errno, + _("Unable to unlock %zu bytes of memory"), + len); + return -1; + } + return 0; #elif defined(__sun) - return 0; + return 0; #endif } @@ -900,21 +912,18 @@ xenHypervisorDoV0Op(int handle, xen_op_v0 * op) hc.op = __HYPERVISOR_dom0_op; hc.arg[0] = (unsigned long) op; - if (lock_pages(op, sizeof(dom0_op_t)) < 0) { - virXenError(VIR_ERR_XEN_CALL, " locking"); + if (lock_pages(op, sizeof(dom0_op_t)) < 0) return -1; - } ret = ioctl(handle, xen_ioctl_hypercall_cmd, (unsigned long) &hc); if (ret < 0) { - virXenError(VIR_ERR_XEN_CALL, " ioctl %d", - xen_ioctl_hypercall_cmd); + virReportSystemError(errno, + _("Unable to issue hypervisor ioctl %d"), + xen_ioctl_hypercall_cmd); } - if (unlock_pages(op, sizeof(dom0_op_t)) < 0) { - virXenError(VIR_ERR_XEN_CALL, " releasing"); + if (unlock_pages(op, sizeof(dom0_op_t)) < 0) ret = -1; - } if (ret < 0) return -1; @@ -942,21 +951,18 @@ xenHypervisorDoV1Op(int handle, xen_op_v1* op) hc.op = __HYPERVISOR_dom0_op; hc.arg[0] = (unsigned long) op; - if (lock_pages(op, sizeof(dom0_op_t)) < 0) { - virXenError(VIR_ERR_XEN_CALL, " locking"); + if (lock_pages(op, sizeof(dom0_op_t)) < 0) return -1; - } ret = ioctl(handle, xen_ioctl_hypercall_cmd, (unsigned long) &hc); if (ret < 0) { - virXenError(VIR_ERR_XEN_CALL, " ioctl %d", - xen_ioctl_hypercall_cmd); + virReportSystemError(errno, + _("Unable to issue hypervisor ioctl %d"), + xen_ioctl_hypercall_cmd); } - if (unlock_pages(op, sizeof(dom0_op_t)) < 0) { - virXenError(VIR_ERR_XEN_CALL, " releasing"); + if (unlock_pages(op, sizeof(dom0_op_t)) < 0) ret = -1; - } if (ret < 0) return -1; @@ -985,21 +991,18 @@ xenHypervisorDoV2Sys(int handle, xen_op_v2_sys* op) hc.op = __HYPERVISOR_sysctl; hc.arg[0] = (unsigned long) op; - if (lock_pages(op, sizeof(dom0_op_t)) < 0) { - virXenError(VIR_ERR_XEN_CALL, " locking"); + if (lock_pages(op, sizeof(dom0_op_t)) < 0) return -1; - } ret = ioctl(handle, xen_ioctl_hypercall_cmd, (unsigned long) &hc); if (ret < 0) { - virXenError(VIR_ERR_XEN_CALL, " sys ioctl %d", - xen_ioctl_hypercall_cmd); + virReportSystemError(errno, + _("Unable to issue hypervisor ioctl %d"), + xen_ioctl_hypercall_cmd); } - if (unlock_pages(op, sizeof(dom0_op_t)) < 0) { - virXenError(VIR_ERR_XEN_CALL, " releasing"); + if (unlock_pages(op, sizeof(dom0_op_t)) < 0) ret = -1; - } if (ret < 0) return -1; @@ -1028,21 +1031,18 @@ xenHypervisorDoV2Dom(int handle, xen_op_v2_dom* op) hc.op = __HYPERVISOR_domctl; hc.arg[0] = (unsigned long) op; - if (lock_pages(op, sizeof(dom0_op_t)) < 0) { - virXenError(VIR_ERR_XEN_CALL, " locking"); + if (lock_pages(op, sizeof(dom0_op_t)) < 0) return -1; - } ret = ioctl(handle, xen_ioctl_hypercall_cmd, (unsigned long) &hc); if (ret < 0) { - virXenError(VIR_ERR_XEN_CALL, " ioctl %d", - xen_ioctl_hypercall_cmd); + virReportSystemError(errno, + _("Unable to issue hypervisor ioctl %d"), + xen_ioctl_hypercall_cmd); } - if (unlock_pages(op, sizeof(dom0_op_t)) < 0) { - virXenError(VIR_ERR_XEN_CALL, " releasing"); + if (unlock_pages(op, sizeof(dom0_op_t)) < 0) ret = -1; - } if (ret < 0) return -1; @@ -1068,10 +1068,9 @@ virXen_getdomaininfolist(int handle, int first_domain, int maxids, int ret = -1; if (lock_pages(XEN_GETDOMAININFOLIST_DATA(dominfos), - XEN_GETDOMAININFO_SIZE * maxids) < 0) { - virXenError(VIR_ERR_XEN_CALL, " locking"); + XEN_GETDOMAININFO_SIZE * maxids) < 0) return -1; - } + if (hv_versions.hypervisor > 1) { xen_op_v2_sys op; @@ -1123,10 +1122,9 @@ virXen_getdomaininfolist(int handle, int first_domain, int maxids, ret = op.u.getdomaininfolist.num_domains; } if (unlock_pages(XEN_GETDOMAININFOLIST_DATA(dominfos), - XEN_GETDOMAININFO_SIZE * maxids) < 0) { - virXenError(VIR_ERR_XEN_CALL, " release"); + XEN_GETDOMAININFO_SIZE * maxids) < 0) ret = -1; - } + return ret; } @@ -1747,10 +1745,9 @@ virXen_setvcpumap(int handle, int id, unsigned int vcpu, if (hv_versions.hypervisor > 1) { xen_op_v2_dom op; - if (lock_pages(cpumap, maplen) < 0) { - virXenError(VIR_ERR_XEN_CALL, " locking"); + if (lock_pages(cpumap, maplen) < 0) return -1; - } + memset(&op, 0, sizeof(op)); op.cmd = XEN_V2_OP_SETVCPUMAP; op.domain = (domid_t) id; @@ -1782,10 +1779,8 @@ virXen_setvcpumap(int handle, int id, unsigned int vcpu, ret = xenHypervisorDoV2Dom(handle, &op); VIR_FREE(new); - if (unlock_pages(cpumap, maplen) < 0) { - virXenError(VIR_ERR_XEN_CALL, " release"); + if (unlock_pages(cpumap, maplen) < 0) ret = -1; - } } else { cpumap_t xen_cpumap; /* limited to 64 CPUs in old hypervisors */ uint64_t *pm = &xen_cpumap; @@ -1879,10 +1874,9 @@ virXen_getvcpusinfo(int handle, int id, unsigned int vcpu, virVcpuInfoPtr ipt, ipt->cpu = op.u.getvcpuinfod5.online ? (int)op.u.getvcpuinfod5.cpu : -1; } if ((cpumap != NULL) && (maplen > 0)) { - if (lock_pages(cpumap, maplen) < 0) { - virXenError(VIR_ERR_XEN_CALL, " locking"); + if (lock_pages(cpumap, maplen) < 0) return -1; - } + memset(cpumap, 0, maplen); memset(&op, 0, sizeof(op)); op.cmd = XEN_V2_OP_GETVCPUMAP; @@ -1897,10 +1891,8 @@ virXen_getvcpusinfo(int handle, int id, unsigned int vcpu, virVcpuInfoPtr ipt, op.u.getvcpumapd5.cpumap.nr_cpus = maplen * 8; } ret = xenHypervisorDoV2Dom(handle, &op); - if (unlock_pages(cpumap, maplen) < 0) { - virXenError(VIR_ERR_XEN_CALL, " release"); + if (unlock_pages(cpumap, maplen) < 0) ret = -1; - } } } else { int mapl = maplen; @@ -2079,8 +2071,9 @@ xenHypervisorInit(struct xenHypervisorVersions *override_versions) */ hv_versions.hypervisor = -1; - virXenError(VIR_ERR_XEN_CALL, " ioctl %lu", - (unsigned long) IOCTL_PRIVCMD_HYPERCALL); + virReportSystemError(errno, + _("Unable to issue hypervisor ioctl %lu"), + (unsigned long)IOCTL_PRIVCMD_HYPERCALL); VIR_FORCE_CLOSE(fd); in_init = 0; return -1; @@ -2178,14 +2171,15 @@ xenHypervisorInit(struct xenHypervisorVersions *override_versions) goto done; } + /* * we failed to make the getdomaininfolist hypercall */ - - VIR_DEBUG("Failed to find any Xen hypervisor method"); hv_versions.hypervisor = -1; - virXenError(VIR_ERR_XEN_CALL, " ioctl %lu", - (unsigned long)IOCTL_PRIVCMD_HYPERCALL); + virReportSystemError(errno, + _("Unable to issue hypervisor ioctl %lu"), + (unsigned long)IOCTL_PRIVCMD_HYPERCALL); + VIR_DEBUG("Failed to find any Xen hypervisor method"); VIR_FORCE_CLOSE(fd); in_init = 0; VIR_FREE(ipt); -- 1.7.10.4

2 1

[libvirt] [PATCH] qemu: Set reasonable RSS limit on domain startup
by Michal Privoznik 19 Jul '12

19 Jul '12

If there's a memory leak in qemu or qemu is exploited the host's system will sooner or later start trashing instead of killing the bad process. This however has impact on performance and other guests as well. Therefore we should set a reasonable RSS limit even when user hasn't set any. It's better to be secure by default. --- src/qemu/qemu_cgroup.c | 73 +++++++++++++++++++++++++++--------------------- 1 files changed, 41 insertions(+), 32 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index e39f5e1..2c158c1 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -339,42 +339,51 @@ int qemuSetupCgroup(struct qemud_driver *driver, } } - if (vm->def->mem.hard_limit != 0 || - vm->def->mem.soft_limit != 0 || - vm->def->mem.swap_hard_limit != 0) { - if (qemuCgroupControllerActive(driver, VIR_CGROUP_CONTROLLER_MEMORY)) { - if (vm->def->mem.hard_limit != 0) { - rc = virCgroupSetMemoryHardLimit(cgroup, vm->def->mem.hard_limit); - if (rc != 0) { - virReportSystemError(-rc, - _("Unable to set memory hard limit for domain %s"), - vm->def->name); - goto cleanup; - } - } - if (vm->def->mem.soft_limit != 0) { - rc = virCgroupSetMemorySoftLimit(cgroup, vm->def->mem.soft_limit); - if (rc != 0) { - virReportSystemError(-rc, - _("Unable to set memory soft limit for domain %s"), - vm->def->name); - goto cleanup; - } + if (qemuCgroupControllerActive(driver, VIR_CGROUP_CONTROLLER_MEMORY)) { + unsigned long long hard_limit = vm->def->mem.hard_limit; + + if (!hard_limit) { + /* If there is no hard_limit set, set a reasonable + * one to avoid system trashing caused by exploited qemu. + * As 'reasonable limit' has been chosen: + * (1 + k) * (domain memory) + F + * where k = 0.02 and F = 200MB. */ + hard_limit = vm->def->mem.max_balloon * 1.02 + 204800; + } + + rc = virCgroupSetMemoryHardLimit(cgroup, hard_limit); + if (rc != 0) { + virReportSystemError(-rc, + _("Unable to set memory hard limit for domain %s"), + vm->def->name); + goto cleanup; + } + if (vm->def->mem.soft_limit != 0) { + rc = virCgroupSetMemorySoftLimit(cgroup, vm->def->mem.soft_limit); + if (rc != 0) { + virReportSystemError(-rc, + _("Unable to set memory soft limit for domain %s"), + vm->def->name); + goto cleanup; } + } - if (vm->def->mem.swap_hard_limit != 0) { - rc = virCgroupSetMemSwapHardLimit(cgroup, vm->def->mem.swap_hard_limit); - if (rc != 0) { - virReportSystemError(-rc, - _("Unable to set swap hard limit for domain %s"), - vm->def->name); - goto cleanup; - } + if (vm->def->mem.swap_hard_limit != 0) { + rc = virCgroupSetMemSwapHardLimit(cgroup, vm->def->mem.swap_hard_limit); + if (rc != 0) { + virReportSystemError(-rc, + _("Unable to set swap hard limit for domain %s"), + vm->def->name); + goto cleanup; } - } else { - qemuReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("Memory cgroup is not available on this host")); } + } else if (vm->def->mem.hard_limit != 0 || + vm->def->mem.soft_limit != 0 || + vm->def->mem.swap_hard_limit != 0) { + qemuReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Memory cgroup is not available on this host")); + } else { + VIR_WARN("Could not autoset a RSS limit for domain %s", vm->def->name); } if (vm->def->cputune.shares != 0) { -- 1.7.8.6

6 5

[libvirt] libvirt qemu cgroup problem
by faicker mo 19 Jul '12

19 Jul '12

I want to use the cgroup with libvirt+qemu. The VM runs well. But the libvirt report error, here is the libvirt debug info: 2012-07-19 09:40:10.726+0000: 32341: debug : virCgroupNew:603 : New group / 2012-07-19 09:40:10.726+0000: 32341: info : qemudStartup:597 : Unable to create cgroup for driver: No such device or address 2012-07-19 09:40:10.726+0000: 32341: debug : virLockManagerNopInit:35 : version=1000000 configFile=(null) flags=0 2012-07-19 09:40:10.726+0000: 32341: info : qemudLoadDriverConfig:332 : Configured cgroup controller 'cpu' 2012-07-19 09:40:10.726+0000: 32341: info : qemudLoadDriverConfig:332 : Configured cgroup controller 'cpuacct' 2012-07-19 09:40:10.726+0000: 32341: info : qemudLoadDriverConfig:332 : Configured cgroup controller 'cpuset' 2012-07-19 09:40:10.726+0000: 32341: info : qemudLoadDriverConfig:332 : Configured cgroup controller 'memory' 2012-07-19 09:40:10.726+0000: 32341: info : qemudLoadDriverConfig:332 : Configured cgroup controller 'devices' 2012-07-19 09:40:10.726+0000: 32341: info : qemudLoadDriverConfig:332 : Configured cgroup controller 'blkio' I can't find the /sys/fs/cgroup dir or any other dir? virsh blkiotune test error: Unable to get blkio parameters error: Requested operation is not valid: blkio cgroup isn't mounted ------ thank you.

1 0

[libvirt] [PATCH v2] Per-guest configurable user/group for QEMU processes
by Marcelo Cerri 19 Jul '12

19 Jul '12

This is a v2 patch series that updates the libvirt's security driver mechanism to support per-guest configurable user and group for QEMU processes running together with other security drivers, such as SELinux and AppArmor. Comments and feedbacks are welcome.

4 14

[libvirt] Unable to startVM in Power PC
by B Veera-B37207 19 Jul '12

19 Jul '12

Hi, Here is my xml file <domain type='qemu' xmlns:qemu='http://libvirt.org/schemas/domain/qemu/1.0'> <name>Test</name> <uuid>aaec5748-56a9-e2fe-655c-c08ca3a4c097</uuid> <memory unit='KiB'>65536</memory> <currentMemory unit='KiB'>65536</currentMemory> <vcpu placement='static'>1</vcpu> <os> <type arch='i686' machine='ppce500v2'>hvm</type> <kernel>/boot/uImage-p2020rdb.bin</kernel> <initrd>/home/root/guest.rootfs.ext2.gz</initrd> <cmdline>root=/dev/ram rw console=ttyS0,115200</cmdline> </os> <features> <acpi/> </features> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>destroy</on_crash> <devices> <emulator>/usr/bin/qemu-system-ppc</emulator> <interface type='ethernet'> <mac address='52:54:00:dd:fa:40'/> <script path='/home/root/qemu-ifup'/> <model type='virtio'/> </interface> <serial type='tcp'> <source mode='bind' host='' service='4444'/> <protocol type='raw'/> <target port='0'/> </serial> <console type='tcp'> <source mode='bind' host='' service='4444'/> <protocol type='raw'/> <target type='serial' port='0'/> </console> <memballoon model='virtio'/> </devices> <qemu:commandline> <qemu:arg value='200M'/> <qemu:arg value='-mem-path'/> <qemu:arg value='/var/lib/hugetlbfs/pagesize-4MB'/> <qemu:arg value='-dtb'/> <qemu:arg value='/usr/share/qemu/ppce500v2.dtb'/> </qemu:commandline> </domain> While starting VM I am getting following error root@p2020rdb:~# virsh start Test error: Failed to start domain Test error: Unable to read from monitor: Connection reset by peer ############################# Test.log Log file ############ ################ LC_ALL=C PATH=/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/sbin:/sbin HOME=/home/root USER=root LOGNAME=root /usr/bin/qemu-system-ppc -name Test -S -M ppce500v2 -m 256 -smp 1,sockets=1,cores=1,threads=1 -uuid aaec5748-56a9-e2fe-655c-c08ca3a4c097 -nographic -nodefconfig -nodefaults -chardev socket,id=charmonitor,path=/usr/local/var/lib/libvirt/qemu/Test.monitor,server,nowait -mon chardev=charmonitor,id=monitor,mode=control -rtc base=utc -no-shutdown -kernel /boot/uImage-p2020rdb.bin -initrd /home/root/guest.rootfs.ext2.gz -append root=/dev/ram rw console=ttyS0,115200 -device piix3-usb-uhci,id=usb,bus=pci,addr=0x1.0x2 -netdev tap,script=/home/root/qemu-ifup,id=hostnet0 -device virtio-net-pci,netdev=hostnet0,id=net0,mac=52:54:00:dd:fa:40,bus=pci,addr=0x3 -chardev socket,id=charserial0,host=,port=4444,server,nowait -device isa-serial,chardev=charserial0,id=serial0 -device virtio-balloon-pci,id=balloon0,bus=pci,addr=0x4 -mem-path /var/lib/hugetlbfs/pagesize-4MB -dtb /usr/share/qemu/ppce500v2.dtb Domain id=24 is tainted: high-privileges Domain id=24 is tainted: custom-argv Domain id=24 is tainted: shell-scripts qemu-system-ppc: -device piix3-usb-uhci,id=usb,bus=pci,addr=0x1.0x2: Bus 'pci' not found 2012-07-19 09:06:25.215+0000: shutting down Please help me regarding this issue Regards, Veera.

1 0

[libvirt] [PATCH 00/16] Misc fixes and refactoring of LXC driver
by Daniel P. Berrange 19 Jul '12

19 Jul '12

The first 7 patches in this series are a set of misc fixes I identified while working on the LXC driver code. The remaining 9 patches heavily re-arrange, re-factor and re-name the LXC driver code. The intent is to make the code layout closer in style to the QEMU driver, to facilitate its future growth in size & complexity

3 33

[libvirt] [PATCH libvirt-glib] gobject: add GVir.DomainXMLFlags binding
by Marc-André Lureau 19 Jul '12

19 Jul '12

--- libvirt-gobject/libvirt-gobject-domain.c | 2 +- libvirt-gobject/libvirt-gobject-domain.h | 14 ++++++++++++++ libvirt-gobject/libvirt-gobject.sym | 5 +++++ 3 files changed, 20 insertions(+), 1 deletion(-) diff --git a/libvirt-gobject/libvirt-gobject-domain.c b/libvirt-gobject/libvirt-gobject-domain.c index e14190c..ba8e12b 100644 --- a/libvirt-gobject/libvirt-gobject-domain.c +++ b/libvirt-gobject/libvirt-gobject-domain.c @@ -709,7 +709,7 @@ gboolean gvir_domain_save_to_file_finish(GVirDomain *dom, /** * gvir_domain_get_config: * @dom: the domain - * @flags: the flags + * @flags: the %GVirDomainXMLFlags flags * * Returns: (transfer full): the config. The returned object should be * unreffed with g_object_unref() when no longer needed. diff --git a/libvirt-gobject/libvirt-gobject-domain.h b/libvirt-gobject/libvirt-gobject-domain.h index 8f17799..70e7e37 100644 --- a/libvirt-gobject/libvirt-gobject-domain.h +++ b/libvirt-gobject/libvirt-gobject-domain.h @@ -102,6 +102,20 @@ typedef enum { GVIR_DOMAIN_DELETE_SNAPSHOTS_METADATA = VIR_DOMAIN_UNDEFINE_SNAPSHOTS_METADATA, } GVirDomainDeleteFlags; +/** + * GVirDomainXMLFlags: + * @GVIR_DOMAIN_XML_NONE: No flags + * @GVIR_DOMAIN_XML_SECURE: Dump security sensitive information too + * @GVIR_DOMAIN_XML_INACTIVE: Dump inactive domain information + * @GVIR_DOMAIN_XML_UPDATE_CPU: Update guest CPU requirements according to host CPU + */ +typedef enum { + GVIR_DOMAIN_XML_NONE = 0, + GVIR_DOMAIN_XML_SECURE = VIR_DOMAIN_XML_SECURE, + GVIR_DOMAIN_XML_INACTIVE = VIR_DOMAIN_XML_INACTIVE, + GVIR_DOMAIN_XML_UPDATE_CPU = VIR_DOMAIN_XML_UPDATE_CPU, +} GVirDomainXMLFlags; + typedef struct _GVirDomainInfo GVirDomainInfo; struct _GVirDomainInfo { diff --git a/libvirt-gobject/libvirt-gobject.sym b/libvirt-gobject/libvirt-gobject.sym index 60478d1..cc602d3 100644 --- a/libvirt-gobject/libvirt-gobject.sym +++ b/libvirt-gobject/libvirt-gobject.sym @@ -175,4 +175,9 @@ LIBVIRT_GOBJECT_0.0.9 { gvir_domain_start_finish; } LIBVIRT_GOBJECT_0.0.8; +LIBVIRT_GOBJECT_0.1.1 { + global: + gvir_domain_xml_flags_get_type; +} LIBVIRT_GOBJECT_0.0.9; + # .... define new API here using predicted next version number .... -- 1.7.10.4

2 1

[libvirt] Libvirt on power pc
by B Veera-B37207 19 Jul '12

19 Jul '12

Hi, Using command line I am able to bring up VM Here is the command: "qemu-system-ppc -enable-kvm -m 512M -mem-path /var/lib/hugetlbfs/pagesize-4MB -nographic -M ppce500v2 -kernel /boot/uImage-p2020rdb.bin -initrd ./guest.rootfs.ext2.gz -append "root=/dev/ram rw console=ttyS0,115200" -serial tcp::4444,server,telnet -dtb /usr/share/qemu/ppce500v2.dtb -net nic,model=virtio -net tap,script=/home/root/qemu-ifup" Can anybody let me know the libvirt xml format for above command. Regards, Veera.

2 1

[libvirt] [PATCH] rpc: remove trailing carriage return character in error string
by Guannan Ren 19 Jul '12

19 Jul '12

If the error message string ends with '\r\n', it is not enough to remove '\n' only which leads to messed string. Example, after three time incorrect password input, virsh command virsh -c qemu://remoteserver/system will report error like: : Connection reset by peerey,gssapi-keyex,gssapi-with-mic,password). it should be: Permission denied (publickey,gssapi-keyex,gssapi-with-mic,password). : Connection reset by peer The terminal interprets '\r' as "move the cursor back to the start of the current line", so we have to remove the character if it exists. --- src/rpc/virnetsocket.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c index 08dfbb0..8385d88 100644 --- a/src/rpc/virnetsocket.c +++ b/src/rpc/virnetsocket.c @@ -985,8 +985,14 @@ reread: virFileReadLimFD(sock->errfd, 1024, &errout) >= 0 && errout != NULL) { size_t elen = strlen(errout); - if (elen && errout[elen-1] == '\n') + if (elen && errout[elen-1] == '\n') { errout[elen-1] = '\0'; + + /* remove trailing '\r' if it exists */ + if (elen-1 && errout[elen-2] == '\r') { + errout[elen-2] = '\0'; + } + } } if (ret < 0) { -- 1.7.7.5

2 4