- Devel - libvirt List Archives

[libvirt] ESX: failure while performing "CastFromAnyType"
by Ata E Husain Bohra 21 Jul '12

21 Jul '12

Hi All, I am trying to extend “iscsi” support for iSCSI driver, currently am stuck at getting iSCSI target list from the hypervisor. I am using hostSystem object (propertyNameList is set to “config.storageDevice.hostBusAdapter”) to retrieve list of “HostHostBusAdapter” from ESX, but the call fails to perform “CastFromAnyType” from ObjectContent –> HostHostBusAdapter. The esx_vi_generator.input object definition looks like this: object HostHostBusAdapter String key o String device r Int bus r String status r String model r String driver o String pci o end esx_vi_generaor.py is modified as follows: "HostHostBusAdapter" : Object.FEATURE__ANY_TYPE | Object.FEATURE__LIST, Using gdb, I see the failure occurs at: esx/esx_vi.c:esxVI_List_CastFromAnyType(..) line 1631: .. if (esxVI_AnyType_Deserialize(childNode, &childAnyType) < 0 || castFromAnyTypeFunc(childAnyType, &item) < 0 || esxVI_List_Append(list, item) < 0) { goto cleanup; } .. In one of my earlier patches (subject: Add routines to interface driver) I patched esx_vi_generator.py to deserialize “string list”; as the patch is still under review I manually applied the branch to this branch but no change (did not expect change as structure does not contain any list object). I am wondering what else is missing to make it work. Any suggestion how to debug/fix this issue is highly appreciated. Thanks! Ata

3 5

[libvirt] [PATCH 0/2] vmx: handle shared folders
by Jean-Baptiste Rouault 21 Jul '12

21 Jul '12

The following patches add support for shared folders for VMware domains Jean-Baptiste Rouault (2): vmx: handle shared folders formatting vmx: handle shared folders parsing src/vmx/vmx.c | 193 +++++++++++++++++++++++++++- src/vmx/vmx.h | 5 + tests/vmx2xmldata/vmx2xml-sharedfolder.vmx | 9 ++ tests/vmx2xmldata/vmx2xml-sharedfolder.xml | 22 ++++ tests/vmx2xmltest.c | 2 + tests/xml2vmxdata/xml2vmx-sharedfolder.vmx | 18 +++ tests/xml2vmxdata/xml2vmx-sharedfolder.xml | 14 ++ tests/xml2vmxtest.c | 2 + 8 files changed, 263 insertions(+), 2 deletions(-) create mode 100644 tests/vmx2xmldata/vmx2xml-sharedfolder.vmx create mode 100644 tests/vmx2xmldata/vmx2xml-sharedfolder.xml create mode 100644 tests/xml2vmxdata/xml2vmx-sharedfolder.vmx create mode 100644 tests/xml2vmxdata/xml2vmx-sharedfolder.xml -- 1.7.10.4

2 4

[libvirt] [PATCH 00/13] Introduce a virObject module fo reference counting
by Daniel P. Berrange 20 Jul '12

20 Jul '12

Last year Hu Tao posted a series which introduced a virObject type and converted the QEMU driver to use this for some of its objects https://www.redhat.com/archives/libvir-list/2011-April/msg00316.html While the idea was generally encouraged, the impl was never updated with review feedback, although some of the atomic ops code was updated and merged. This series is an attempt to address the same problem. The significant things in this series - Instead of storing a 'destroy' pointer in virObject itself, introduce a separate 'virClass' concept. As we add more functionality to virObject, the benefit of not duplicating class-level data in each object instance will be great - The virObject APIs take a 'void *' instead of virObjectPtr to avoid the need to litter the code with casts, albeit at a slight loss in compile time type safety checking - Replace our current atomic ops code with GLib's impl which is more complete, in particular it has Win32 support - Add a macro to facilitate creating one-time init functions usig virOnce - Convert all our public API objects to use this new code - Convert all code in src/rpc, src/conf and src/qemu to the new object APIs In the future the things I plan to do are - Add a mutex to virObject - nearly all subclasses make use of a mutex, so it makes sense to provide one in the base class - Add generic support for callbacks. Currently each module deals with callbacks in a rather adhoc fashion. THis will create something similar in concept to GLib's 'signal' capabilities, though somewhat simpler. .gitignore | 1 configure.ac | 59 ++ daemon/libvirtd.c | 27 - daemon/remote.c | 8 daemon/stream.c | 19 src/Makefile.am | 7 src/conf/domain_conf.c | 59 -- src/conf/domain_conf.h | 8 src/conf/domain_event.c | 8 src/datatypes.c | 999 ++++++++------------------------------ src/datatypes.h | 264 +++------- src/libvirt.c | 131 +--- src/libvirt_atomic.syms | 3 src/libvirt_private.syms | 42 - src/libvirt_probes.d | 31 - src/libxl/libxl_driver.c | 6 src/lxc/lxc_controller.c | 8 src/nwfilter/nwfilter_dhcpsnoop.c | 48 - src/openvz/openvz_conf.c | 17 src/phyp/phyp_driver.c | 14 src/qemu/qemu_agent.c | 86 +-- src/qemu/qemu_agent.h | 3 src/qemu/qemu_command.c | 2 src/qemu/qemu_domain.c | 49 - src/qemu/qemu_domain.h | 8 src/qemu/qemu_driver.c | 2 src/qemu/qemu_migration.c | 34 - src/qemu/qemu_migration.h | 4 src/qemu/qemu_monitor.c | 97 +-- src/qemu/qemu_monitor.h | 3 src/qemu/qemu_process.c | 52 - src/remote/remote_driver.c | 26 src/rpc/gendispatch.pl | 4 src/rpc/virkeepalive.c | 73 +- src/rpc/virkeepalive.h | 4 src/rpc/virnetclient.c | 117 +--- src/rpc/virnetclient.h | 4 src/rpc/virnetclientprogram.c | 43 - src/rpc/virnetclientprogram.h | 5 src/rpc/virnetclientstream.c | 65 +- src/rpc/virnetclientstream.h | 5 src/rpc/virnetsaslcontext.c | 106 +--- src/rpc/virnetsaslcontext.h | 8 src/rpc/virnetserver.c | 82 +-- src/rpc/virnetserver.h | 5 src/rpc/virnetserverclient.c | 134 ++--- src/rpc/virnetserverclient.h | 5 src/rpc/virnetserverprogram.c | 49 - src/rpc/virnetserverprogram.h | 8 src/rpc/virnetserverservice.c | 97 +-- src/rpc/virnetserverservice.h | 5 src/rpc/virnetsocket.c | 85 +-- src/rpc/virnetsocket.h | 3 src/rpc/virnettlscontext.c | 110 +--- src/rpc/virnettlscontext.h | 10 src/storage/storage_driver.c | 4 src/util/logging.c | 54 -- src/util/logging.h | 2 src/util/threads.h | 49 + src/util/viratomic.c | 35 + src/util/viratomic.h | 424 +++++++++++++--- src/util/virfile.c | 4 src/util/virnodesuspend.c | 25 src/util/virnodesuspend.h | 1 src/util/virobject.c | 203 +++++++ src/util/virobject.h | 60 ++ src/vbox/vbox_tmpl.c | 2 src/vmware/vmware_conf.c | 4 src/xen/xend_internal.c | 4 tests/Makefile.am | 5 tests/qemuxml2argvtest.c | 21 tests/qemuxmlnstest.c | 2 tests/sexpr2xmltest.c | 2 tests/viratomictest.c | 180 ++++++ tests/virnetsockettest.c | 26 tests/virnettlscontexttest.c | 10 tests/xmconfigtest.c | 4 77 files changed, 2105 insertions(+), 2168 deletions(-)

3 41

[libvirt] [PATCH 2/2] Use ATTRIBUTE_UNUSED for unused variable.
by Ata E Husain Bohra 20 Jul '12

20 Jul '12

--- src/esx/esx_interface_driver.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/esx/esx_interface_driver.c b/src/esx/esx_interface_driver.c index b1ba5e2..01caed0 100644 --- a/src/esx/esx_interface_driver.c +++ b/src/esx/esx_interface_driver.c @@ -107,10 +107,8 @@ cleanup: static int -esxNumOfDefinedInterfaces(virConnectPtr conn) +esxNumOfDefinedInterfaces(virConnectPtr conn ATTRIBUTE_UNUSED) { - conn->interfacePrivateData = NULL; - // ESX interfaces are always active return 0; } @@ -162,14 +160,10 @@ esxListInterfaces(virConnectPtr conn, char **names, int maxnames) static int -esxListDefinedInterfaces(virConnectPtr conn, char **names, int maxnames) +esxListDefinedInterfaces(virConnectPtr conn ATTRIBUTE_UNUSED, + char **names ATTRIBUTE_UNUSED, + int maxnames ATTRIBUTE_UNUSED) { - conn->interfacePrivateData = conn->privateData; - *names = NULL; - - /* keeps compiler happy */ - VIR_DEBUG("max interfaces: %d", maxnames); - // ESX interfaces are always active return 0; } -- 1.7.9.5

1 0

[libvirt] [PATCH v3 0/2] ESX: Add routines to interface driver
by Ata E Husain Bohra 20 Jul '12

20 Jul '12

Repost of https://www.redhat.com/archives/libvir-list/2012-July/msg00990.html. Thanks Eric for pointing the message-ID issue with earlier post. Ata E Husain Bohra (2): ESX: Add routines to interface driver Use ATTRIBUTE_UNUSED for unused variable. src/esx/esx_interface_driver.c | 500 +++++++++++++++++++++++++++++++++++++++- src/esx/esx_vi.c | 126 ++++++++++ src/esx/esx_vi.h | 10 + src/esx/esx_vi_generator.input | 227 ++++++++++++++++++ src/esx/esx_vi_generator.py | 31 ++- src/esx/esx_vi_types.c | 18 +- 6 files changed, 907 insertions(+), 5 deletions(-) -- 1.7.9.5

1 0

[libvirt] [PATCH] tests: avoid seclabeltest crash
by Eric Blake 20 Jul '12

20 Jul '12

Commit a56c347 introduced a use of random numbers into seclabel handling, but failed to initialize the random number generator in the testsuite. * tests/seclabeltest.c (main): Initialize randomness. --- Pushing under the build-breaker rule to avoid a SIGSEGV. I don't know if Dan's pending patches for one-shot initializer cleanups will be impacted or make this harder to forget in the future. tests/seclabeltest.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tests/seclabeltest.c b/tests/seclabeltest.c index 2f65ec1..7283ca1 100644 --- a/tests/seclabeltest.c +++ b/tests/seclabeltest.c @@ -6,6 +6,7 @@ #include <string.h> #include <errno.h> #include "security/security_driver.h" +#include "virrandom.h" int main (int argc ATTRIBUTE_UNUSED, char **argv ATTRIBUTE_UNUSED) @@ -13,10 +14,14 @@ main (int argc ATTRIBUTE_UNUSED, char **argv ATTRIBUTE_UNUSED) virSecurityManagerPtr mgr; const char *doi, *model; + if (virThreadInitialize() < 0 || + virRandomInitialize(time(NULL) ^ getpid())) + exit(1); + mgr = virSecurityManagerNew(NULL, "QEMU", false, true, false); if (mgr == NULL) { fprintf (stderr, "Failed to start security driver"); - exit (-1); + exit(1); } model = virSecurityManagerGetModel(mgr); @@ -24,7 +29,7 @@ main (int argc ATTRIBUTE_UNUSED, char **argv ATTRIBUTE_UNUSED) { fprintf (stderr, "Failed to copy secModel model: %s", strerror (errno)); - exit (-1); + exit(1); } doi = virSecurityManagerGetDOI(mgr); @@ -32,7 +37,7 @@ main (int argc ATTRIBUTE_UNUSED, char **argv ATTRIBUTE_UNUSED) { fprintf (stderr, "Failed to copy secModel DOI: %s", strerror (errno)); - exit (-1); + exit(1); } virSecurityManagerFree(mgr); -- 1.7.10.4

1 0

[libvirt] [PATCHv2 0/5] Allow to query a guest's hostname
by Guido Günther 20 Jul '12

20 Jul '12

The following patches allow to query a guest's hostname. Once we also have support to set the hostname via the domain's xml we can also print it in "virsh dominfo" by default so I left it out for now. I left the version at 0.9.14. It'd be happy to change this ot 0.10 should we settle for that one. Changes since last time: * drop patch to print hostname in "virsh list" * add remote protocoll support * Addressed Eric's style comments * openvzVEGetStringParam: Let virCommandRun do the error printing and missing error handling * Don't return empty hostnames but raise VIR_ERR_OPERATION_FAILED instead Cheers, -- Guido Guido Günther (5): Add virDomainGetHostname virsh: Add domhostname remote: Provide RPC call for domainGetHostname openvz: Add openvzVEGetStringParam openvz: Implement domainGetHostname include/libvirt/libvirt.h.in | 2 ++ src/driver.h | 6 ++++++ src/libvirt.c | 45 ++++++++++++++++++++++++++++++++++++++++++ src/libvirt_openvz.syms | 2 +- src/libvirt_public.syms | 5 +++++ src/openvz/openvz_driver.c | 42 +++++++++++++++++++++++++++++++++++++++ src/openvz/openvz_util.c | 32 ++++++++++++++++++++++++++++++ src/openvz/openvz_util.h | 1 + src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 12 ++++++++++- src/remote_protocol-structs | 8 ++++++++ tools/virsh.c | 44 +++++++++++++++++++++++++++++++++++++++++ tools/virsh.pod | 4 ++++ 13 files changed, 202 insertions(+), 2 deletions(-) -- 1.7.10.4

3 13

[libvirt] [PATCH v2 0/3] Misc changes to SELinux driver
by Daniel P. Berrange 20 Jul '12

20 Jul '12

This is a repost of https://www.redhat.com/archives/libvir-list/2012-May/msg01186.html No changes except to rebase.

2 8

[libvirt] [PATCH 1/5] Add public API to register a callback to be invoked on connection close
by Daniel P. Berrange 20 Jul '12

20 Jul '12

From: "Daniel P. Berrange" <berrange(a)redhat.com> Define a new virConnectSetCloseCallback() public API which allows registering a callback to be invoked when the connection to a hypervisor is closed. The callback is provided with the reason for the close, which may be 'error', 'eof' or 'keepalive'. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- include/libvirt/libvirt.h.in | 40 +++++++++++++++++++++++-------- src/datatypes.c | 4 ++++ src/datatypes.h | 5 ++++ src/libvirt.c | 53 ++++++++++++++++++++++++++++++++++++++++++ src/libvirt_public.syms | 6 +++++ 5 files changed, 98 insertions(+), 10 deletions(-) diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index e34438c..74b3f90 100644 --- a/include/libvirt/libvirt.h.in +++ b/include/libvirt/libvirt.h.in @@ -49,6 +49,17 @@ extern "C" { * defines VIR_ENUM_SENTINELS. Enumerations for bit values do not * have a *_LAST value, but additional bits may be defined. */ +/* + * virFreeCallback: + * @opaque: opaque user data provided at registration + * + * Type for a domain event callback when the event is deregistered and + * need to be freed, @opaque is provided along with the callback at + * registration time + */ +typedef void (*virFreeCallback)(void *opaque); + + /** * virConnect: * @@ -1148,6 +1159,25 @@ int virConnectSetKeepAlive(virConnectPtr conn, int interval, unsigned int count); +typedef enum { + VIR_CONNECT_CLOSE_REASON_ERROR = 1, /* Misc I/O error */ + VIR_CONNECT_CLOSE_REASON_EOF = 2, /* End-of-file from server */ + VIR_CONNECT_CLOSE_REASON_KEEPALIVE = 3, /* Keepalive timer triggered */ + VIR_CONNECT_CLOSE_REASON_CLIENT = 4, /* Client requested it */ + +# ifdef VIR_ENUM_SENTINELS + VIR_CONNECT_CLOSE_REASON_LAST +# endif +} virConnectCloseReason; + +typedef void (*virConnectCloseFunc)(virConnectPtr conn, + int reason, + void *opaque); + +int virConnectSetCloseCallback(virConnectPtr conn, + virConnectCloseFunc cb, + void *opaque, + virFreeCallback freecb); /* * Capabilities of the connection / driver. @@ -2861,16 +2891,6 @@ typedef int (*virConnectDomainEventCallback)(virConnectPtr conn, int detail, void *opaque); -/* - * virFreeCallback: - * @opaque: opaque user data provided at registration - * - * Type for a domain event callback when the event is deregistered and - * need to be freed, @opaque is provided along with the callback at - * registration time - */ -typedef void (*virFreeCallback)(void *opaque); - int virConnectDomainEventRegister(virConnectPtr conn, virConnectDomainEventCallback cb, void *opaque, diff --git a/src/datatypes.c b/src/datatypes.c index d718170..5d415b8 100644 --- a/src/datatypes.c +++ b/src/datatypes.c @@ -115,6 +115,10 @@ virReleaseConnect(virConnectPtr conn) { virMutexLock(&conn->lock); + if (conn->closeOpaque && + conn->closeFreeCallback) + conn->closeFreeCallback(conn->closeOpaque); + virResetError(&conn->err); virURIFree(conn->uri); diff --git a/src/datatypes.h b/src/datatypes.h index fc284d2..af054ac 100644 --- a/src/datatypes.h +++ b/src/datatypes.h @@ -187,6 +187,11 @@ struct _virConnect { virErrorFunc handler; /* associated handlet */ void *userData; /* the user data */ + /* Per-connection close callback */ + virConnectCloseFunc closeCallback; + void *closeOpaque; + virFreeCallback closeFreeCallback; + int refs; /* reference count */ }; diff --git a/src/libvirt.c b/src/libvirt.c index df78e8a..8acb87f 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -18613,6 +18613,59 @@ error: /** + * virConnectSetCloseCallback: + * @conn: pointer to connection object + * @cb: callback to invoke upon close + * @opaque: user data to pass to @cb + * @freecb: callback to free @opaque + * + * Registers a callback to be invoked when the connection + * is closed. This callback is invoked when there is any + * condition that causes the socket connection to the + * hypervisor to be closed. + * + * This function is only applicable to hypervisor drivers + * which maintain a persistent open connection. Drivers + * which open a new connection for every operation will + * not invoke this. + * + * The @freecb must not invoke any other libvirt public + * APIs, since it is not called from a re-entrant safe + * context. + * + * Returns 0 on success, -1 on error + */ +int virConnectSetCloseCallback(virConnectPtr conn, + virConnectCloseFunc cb, + void *opaque, + virFreeCallback freecb) +{ + VIR_DEBUG("conn=%p", conn); + + virResetLastError(); + + if (!VIR_IS_CONNECT(conn)) { + virLibConnError(VIR_ERR_INVALID_CONN, __FUNCTION__); + virDispatchError(NULL); + return -1; + } + + virMutexLock(&conn->lock); + + if (conn->closeOpaque && + conn->closeFreeCallback) + conn->closeFreeCallback(conn->closeOpaque); + + conn->closeCallback = cb; + conn->closeOpaque = opaque; + conn->closeFreeCallback = freecb; + + virMutexUnlock(&conn->lock); + + return 0; +} + +/** * virDomainSetBlockIoTune: * @dom: pointer to domain object * @disk: path to the block device, or device shorthand diff --git a/src/libvirt_public.syms b/src/libvirt_public.syms index 2913a81..dab8725 100644 --- a/src/libvirt_public.syms +++ b/src/libvirt_public.syms @@ -544,4 +544,10 @@ LIBVIRT_0.9.13 { virDomainSnapshotRef; } LIBVIRT_0.9.11; + +LIBVIRT_0.9.14 { + global: + virConnectSetCloseCallback; +} LIBVIRT_0.9.13; + # .... define new API here using predicted next version number .... -- 1.7.10.4

2 15

[libvirt] [PATCH 0/3] Updates for Xen error reporting
by Daniel P. Berrange 20 Jul '12

20 Jul '12

This is an update of the previous patch to make Xen use virReportError. Before that can be done, some cleanup in Xen was required

2 6