- Devel - libvirt List Archives

[libvirt] [PATCH] spec: Add runtime requirement for libssh2
by Peter Krempa 16 Oct '12

16 Oct '12

libssh2 unfortunately doesn't support symbol versioning so RPM can't figure out what version is needed for the currently installed libvirt package. This patch adds a runtime requirement, so that the correct version of libssh2 can be installed along with libvirt. --- libvirt.spec.in | 1 + 1 file changed, 1 insertion(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index 75623eb..bc6a1af 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -500,6 +500,7 @@ BuildRequires: libcap-ng-devel >= 0.5.0 %if %{with_phyp} || %{with_libssh2_transport} %if %{with_libssh2_transport} BuildRequires: libssh2-devel >= 1.3.0 +Requires: libssh2 >= 1.3.0 %else BuildRequires: libssh2-devel %endif -- 1.7.12.3

2 1

[libvirt] [PATCH] selinux: Use raw contexts 2
by Martin Kletzander 16 Oct '12

16 Oct '12

In commit 9674f2c637114fa6ac0680fe5658a41a62bb34a8, I forgot to change selabel_lookup with the other functions, so this one-liner does exactly that. --- src/security/security_selinux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 10135ed..e6fba21 100644 --- a/src/security/security_selinux.c +++ b/src/security/security_selinux.c @@ -861,7 +861,7 @@ getContext(const char *newpath, mode_t mode, security_context_t *fcon) if (handle == NULL) return -1; - ret = selabel_lookup(handle, fcon, newpath, mode); + ret = selabel_lookup_raw(handle, fcon, newpath, mode); selabel_close(handle); return ret; #else -- 1.7.12.3

2 2

[libvirt] Connection using Java
by Felipe Oliveira Gutierrez 16 Oct '12

16 Oct '12

Hi, I am using java to connect to the xen, but my class is throwing a exception. Does anyone know what is happening? public class TestConnection { public static void main(String[] args) { Connect conn = null; try { conn = new Connect("xen+ssh://root@192.XXX.XXX.XX/", true); libvir: RPC error : End of file while reading data: nc: invalid option -- 'U' nc -h for help: Input/output error exception caught:org.libvirt.LibvirtException: End of file while reading data: nc: invalid option -- 'U' nc -h for help: Input/output error level:VIR_ERR_ERROR code:VIR_ERR_SYSTEM_ERROR domain:VIR_FROM_RPC hasConn:false hasDom:false hasNet:false message:End of file while reading data: nc: invalid option -- 'U' nc -h for help: Input/output error str1:%s str2:End of file while reading data: nc: invalid option -- 'U' nc -h for help: Input/output error str3:null int1:-1 int2:-1 Thanks, Felipe -- *-- Felipe Oliveira Gutierrez* *-- **lipe.82(a)gmail.com* <lipe.82(a)gmail.com> *-- https://sites.google.com/site/lipe82/Home/diaadia*

3 3

[libvirt] CPU utilization between physical CPU and virtual CPU in KVM
by Dennis Chen 16 Oct '12

16 Oct '12

Hi All, I am confused by the following observed scenario: In my 4-CPU (KVM supported, 2 core with 2 thread for each) host machine box, I create only one VM with 3-vCPU through virsh/libvirt tools and also I pin this VM process to the physical processor 3. I guess the CPU utilization for the processor 3 will not exceed 100%, then I create 3 process (dead loop-- while(1);) and bind each of them to vCPU[0-2] respectively, through the "top -c" command in VM environment, I can see the CPU utilization for each of the vCPU is about 100%, but interesting, I found that the CPU utilization of processor 3 in the host machine is about 300% with "toc -c" command. why does a single process bound to a CPU can get ~300% cpu bandwidth in this case, does the kernel scheduler dispatch the idle cycle capacity of the CPUs to the virtual CPU of the VM, other word, the scheduler knows the vCPU info in the VM process? For the same case, if I create another 4 new dead-loop processes and bind them to the physical CPU[0-3] equally, then I find the vCPU0/1 in VM will not be 100%, eg. 32%, (I think the scheduler in the guest OS doesn't know it's running in a virtual environment, so the utilization of the vCPU will not change to adapt to the physical processor utilization, but it did, why? -org-gnu

1 1

[libvirt] necessary to limit container's network bandwidth when use physical nic in container?
by Gao feng 16 Oct '12

16 Oct '12

we can use tc to limit container's network bandwidth when the container uses veth device. because one of the veth devices will be seen in the host.so we can set tc rules on this device on the host. I want to know if it's necessary to limit container's network bandwidth when the container uses a physical nic device. because this nic device is only used by this container. And if this is necessary,Be there any good idea? Thanks!

3 4

[libvirt] Proposed libguestfs API for implementing libvirt virConnectOpenAuth
by Richard W.M. Jones 15 Oct '12

15 Oct '12

As in the example code below. static void do_auth (guestfs_h *g, void *opaque, uint64_t event, int event_handle, int flags, const char *buf, size_t buf_len, const uint64_t *array, size_t array_len) { char **creds; size_t i; char *prompt; char *reply; size_t replylen; // buf will be the libvirt URI. It is always \0-terminated so // buf_len can be ignored in this case. printf ("Authentication required for libvirt connection '%s'\n", buf); // Ask libguestfs what credentials libvirt is demanding. creds = guestfs_get_libvirt_requested_credentials (g); // Now ask the user for answers. for (i = 0; creds[i] != NULL; ++i) { if (strcmp (creds[i], "authname") == 0 || strcmp (creds[i], "passphrase") == 0) { prompt = guestfs_get_libvirt_requested_credential_prompt (g, i); printf ("%s: ", prompt); free (prompt); // ... // Input from user is in 'reply', length 'replylen' (bytes). guestfs_set_libvirt_requested_credential (g, i, reply, replylen); } free (creds[i]); } free (creds); // On return from this function (libguestfs event), the libvirt // event returns too. } // ... { guestfs_h *g; char *creds[] = { "authname", "passphrase", NULL }; g = guestfs_create (); guestfs_set_libvirt_supported_credentials (g, creds); guestfs_set_event_callback (g, do_auth, GUESTFS_EVENT_LIBVIRT_AUTH, 0, NULL); // An example of a function that would open a libvirt connection: guestfs_add_domain (g, "dom", GUESTFS_ADD_DOMAIN_LIBVIRTURI, "qemu:///system", -1); } ---------------------------------------------------------------------- By the way, some of the virt tools can open multiple connections to libvirt, and it is architecturally hard to change this: https://www.redhat.com/archives/libguestfs/2012-October/msg00065.html Does libvirt (or policy kit?) provide any mechanism for caching these credentials within the same process, so that we don't have to provide the same creds back to libvirt for multiple connections? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://et.redhat.com/~rjones/virt-df/

3 5

[libvirt] [PATCH V1] qemu-attach: Calculate index value if not already specified
by Supriya Kannery 15 Oct '12

15 Oct '12

virsh qemu-attach fails if user has not specified values for index/unit/bus for a drive in qemu commandline. Set default values instead of returning error. Signed-off-by: Supriya Kannery <supriyak(a)linux.vnet.ibm.com> --- src/qemu/qemu_command.c | 10 ---------- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 09f412e..8ba67a1 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -7130,16 +7130,6 @@ qemuParseCommandLineDisk(virCapsPtr caps, def->bus == VIR_DOMAIN_DISK_BUS_VIRTIO) idx = nvirtiodisk; - if (idx == -1 && - unitid == -1 && - busid == -1) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("missing index/unit/bus parameter in drive '%s'"), val); - virDomainDiskDefFree(def); - def = NULL; - goto cleanup; - } - if (idx == -1) { if (unitid == -1) unitid = 0;

1 0

[libvirt] [PATCH] (failed) virConnectOpenAuth: Add VIR_CONNECT_NO_DEFAULT_ERROR_HANDLER flag.
by Richard W.M. Jones 15 Oct '12

15 Oct '12

Well, it was a good idea, but the patch doesn't work. Apparently along their open paths, drivers don't set errors in the newly created handle, but in the global handler instead (hence the errors still get printed to stderr). How much I hate virterror ... Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org

3 4

[libvirt] [PATCH] maint: drop spurious semicolons
by Eric Blake 15 Oct '12

15 Oct '12

Detected with: git grep ';;$' -- '**/*.[ch]' * src/network/bridge_driver.c (networkRadvdConfContents): Fix harmless typo. * src/phyp/phyp_driver.c (phypUUIDTable_Pull): Likewise. * src/qemu/qemu_monitor_json.c (qemuMonitorJSONDriveDel): Likewise. --- Pushing under the trivial rule. src/network/bridge_driver.c | 2 +- src/phyp/phyp_driver.c | 2 +- src/qemu/qemu_monitor_json.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 0c4b0b0..5578373 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -981,7 +981,7 @@ networkRestartDhcpDaemon(virNetworkObjPtr network) static int networkRadvdConfContents(virNetworkObjPtr network, char **configstr) { - virBuffer configbuf = VIR_BUFFER_INITIALIZER;; + virBuffer configbuf = VIR_BUFFER_INITIALIZER; int ret = -1, ii; virNetworkIpDefPtr ipdef; bool v6present = false; diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index a1724ca..a3885a7 100644 --- a/src/phyp/phyp_driver.c +++ b/src/phyp/phyp_driver.c @@ -736,7 +736,7 @@ phypUUIDTable_Pull(virConnectPtr conn) if (!channel) { if (libssh2_session_last_errno(session) != LIBSSH2_ERROR_EAGAIN) { - goto err;; + goto err; } else { waitsocket(sock, session); } diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index c35948e..2daf8ea 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -3068,7 +3068,7 @@ int qemuMonitorJSONDriveDel(qemuMonitorPtr mon, _("deleting disk is not supported. " "This may leak data if disk is reassigned")); ret = 1; - virResetLastError();; + virResetLastError(); } } } else if (qemuMonitorJSONHasError(reply, "DeviceNotFound")) { -- 1.7.11.7

1 0

[libvirt] [PATCH 3/3] Take the forwarding family into account
by Benjamin Cama 15 Oct '12

15 Oct '12

Only add iptables rules for this family, and also only check for forwarding for this family. --- src/network/bridge_driver.c | 27 +++++++++++++++++++++------ 1 files changed, 21 insertions(+), 6 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index e3e8dc2..6bd4217 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -1788,7 +1788,9 @@ networkAddIptablesRules(struct network_driver *driver, return -1; for (ii = 0; - (ipdef = virNetworkDefGetIpByIndex(network->def, AF_UNSPEC, ii)); + (ipdef = virNetworkDefGetIpByIndex(network->def, + network->def->forwardFamily, + ii)); ii++) { /* Add address-specific iptables rules */ if (networkAddIpSpecificIptablesRules(driver, network, ipdef) < 0) { @@ -1803,7 +1805,9 @@ err: * added for previous IP addresses. */ while ((--ii >= 0) && - (ipdef = virNetworkDefGetIpByIndex(network->def, AF_UNSPEC, ii))) { + (ipdef = virNetworkDefGetIpByIndex(network->def, + network->def->forwardFamily, + ii))) { networkRemoveIpSpecificIptablesRules(driver, network, ipdef); } networkRemoveGeneralIptablesRules(driver, network); @@ -1819,7 +1823,9 @@ networkRemoveIptablesRules(struct network_driver *driver, virNetworkIpDefPtr ipdef; for (ii = 0; - (ipdef = virNetworkDefGetIpByIndex(network->def, AF_UNSPEC, ii)); + (ipdef = virNetworkDefGetIpByIndex(network->def, + network->def->forwardFamily, + ii)); ii++) { networkRemoveIpSpecificIptablesRules(driver, network, ipdef); } @@ -2173,9 +2179,18 @@ networkStartNetworkVirtual(struct network_driver *driver, goto err2; /* If forwardType != NONE, check for IP forwarding */ - if (network->def->forwardType != VIR_NETWORK_FORWARD_NONE && - networkCheckIpForwarding(v4present, v6present) < 0) { - goto err3; + if (network->def->forwardType != VIR_NETWORK_FORWARD_NONE) { + if (network->def->forwardFamily) { + /* if forwardFamily is set, we have at least a corresponding + * family's address + */ + if (networkCheckIpForwarding(network->def->forwardFamily == AF_INET, + network->def->forwardFamily == AF_INET6) < 0) + goto err3; + } else { + if (networkCheckIpForwarding(v4present, v6present) < 0) + goto err3; + } } -- 1.7.2.5

2 1