- Devel - libvirt List Archives

[libvirt] virsh "net-create" explanation
by Bilal Ahmad 28 Dec '12

28 Dec '12

Hi all, I am new to libvirt and started looking at the source code. While tracing back the virsh command "net-create", I got stuck into a loop and I would really like someone to explain how this works. In the virsh-network.c, from: network = virNetworkCreateXML(ctl->conn, buffer); I traced back to: if (conn->networkDriver && conn->networkDriver->networkCreateXML) { virNetworkPtr ret; ret = conn->networkDriver->networkCreateXML(conn, xmlDesc); Then I traced back to the following struct to find how networkCreateXML is working: struct _virNetworkDriver { const char * name; /* the name of the driver */ virDrvOpen open; virDrvClose close; virDrvNumOfNetworks numOfNetworks; virDrvListNetworks listNetworks; virDrvNumOfDefinedNetworks numOfDefinedNetworks; virDrvListDefinedNetworks listDefinedNetworks; virDrvListAllNetworks listAllNetworks; virDrvNetworkLookupByUUID networkLookupByUUID; virDrvNetworkLookupByName networkLookupByName; virDrvNetworkCreateXML networkCreateXML; >From the above code, I located the definition of virDrvNetworkCreateXML and found the following: typedef virNetworkPtr (*virDrvNetworkCreateXML) (virConnectPtr conn, const char *xmlDesc); This is where I am unable to trace back to any other code. Can someone please explain the code with typedef above and where is the definition of the function this function pointer is pointing to? I want to get to the root of the networkCreateXML function and how it exactly works. Can someone please explain? Thanks a lot, Bilal

3 2

[libvirt] [PATCH] python: Adapt to virevent rename
by Michal Privoznik 28 Dec '12

28 Dec '12

With our recent renames under src/util/* we forgot to adapt python wrapper code generator. This results in some methods being not exposed: $ python examples/domain-events/events-python/event-test.py Using uri:qemu:///system Traceback (most recent call last): File "examples/domain-events/events-python/event-test.py", line 585, in <module> main() File "examples/domain-events/events-python/event-test.py", line 543, in main virEventLoopPureStart() File "examples/domain-events/events-python/event-test.py", line 416, in virEventLoopPureStart virEventLoopPureRegister() File "examples/domain-events/events-python/event-test.py", line 397, in virEventLoopPureRegister libvirt.virEventRegisterImpl(virEventAddHandleImpl, AttributeError: 'module' object has no attribute 'virEventRegisterImpl' --- Pushed under trivial rule. python/generator.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/generator.py b/python/generator.py index e9b9270..bae4edc 100755 --- a/python/generator.py +++ b/python/generator.py @@ -132,7 +132,7 @@ class docParser(xml.sax.handler.ContentHandler): if tag == 'function': if self.function != None: if (self.function_module == "libvirt" or - self.function_module == "event" or + self.function_module == "virevent" or self.function_module == "virterror"): function(self.function, self.function_descr, self.function_return, self.function_args, -- 1.8.0.2

1 0

[libvirt] [test-API][PATCH] Add volume upload and download cases
by Wayne Sun 28 Dec '12

28 Dec '12

* test download storage volumes using storage download API. * test upload storage volumes using storage upload API. For upload case, only raw volume format is supported, other format will fail. The offset and length value should be chosen from 0 and 1048576, because upload size is set as 1M. * both case use blocking stream. * sample conf is added. Signed-off-by: Wayne Sun <gsun(a)redhat.com> --- cases/storage_vol_upload_download.conf | 127 ++++++++++++++++++++++ repos/storage/vol_download.py | 157 +++++++++++++++++++++++++++ repos/storage/vol_upload.py | 183 ++++++++++++++++++++++++++++++++ 3 files changed, 467 insertions(+), 0 deletions(-) create mode 100644 cases/storage_vol_upload_download.conf create mode 100644 repos/storage/vol_download.py create mode 100644 repos/storage/vol_upload.py diff --git a/cases/storage_vol_upload_download.conf b/cases/storage_vol_upload_download.conf new file mode 100644 index 0000000..b393814 --- /dev/null +++ b/cases/storage_vol_upload_download.conf @@ -0,0 +1,127 @@ +storage:create_dir_pool + poolname + $defaultpoolname + +storage:vol_upload + poolname + $defaultpoolname + volname + $defaultvolumename + capacity + 10M + volformat + raw + offset + 0 + length + 0 +clean + +storage:vol_upload + poolname + $defaultpoolname + volname + $defaultvolumename + capacity + 10M + volformat + raw + offset + 1048576 + length + 0 +clean + +storage:vol_upload + poolname + $defaultpoolname + volname + $defaultvolumename + capacity + 10M + volformat + raw + offset + 0 + length + 1048576 +clean + +storage:vol_upload + poolname + $defaultpoolname + volname + $defaultvolumename + capacity + 10M + volformat + raw + offset + 1048576 + length + 1048576 +clean + +storage:vol_download + poolname + $defaultpoolname + volname + $defaultvolumename + capacity + 50M + volformat + raw + offset + 0 + length + 0 +clean + +storage:vol_download + poolname + $defaultpoolname + volname + $defaultvolumename + capacity + 50M + volformat + qcow2 + offset + 1048576 + length + 0 +clean + +storage:vol_download + poolname + $defaultpoolname + volname + $defaultvolumename + capacity + 50M + volformat + qed + offset + 0 + length + 1048576 +clean + +storage:vol_download + poolname + $defaultpoolname + volname + $defaultvolumename + capacity + 50M + volformat + raw + offset + 1048576 + length + 1048576 +clean + +storage:destroy_pool + poolname + $defaultpoolname diff --git a/repos/storage/vol_download.py b/repos/storage/vol_download.py new file mode 100644 index 0000000..839bc8a --- /dev/null +++ b/repos/storage/vol_download.py @@ -0,0 +1,157 @@ +#!/usr/bin/env python +# storage volume download testing + +import os +import string +import hashlib +from xml.dom import minidom + +import libvirt +from libvirt import libvirtError + +from src import sharedmod +from utils import utils + +required_params = ('poolname', 'volname', 'volformat', 'capacity', 'offset', + 'length',) +optional_params = {'xml' : 'xmls/dir_volume.xml', + } + +def get_pool_path(poolobj): + """ get pool xml description + """ + poolxml = poolobj.XMLDesc(0) + + logger.debug("the xml description of pool is %s" % poolxml) + + doc = minidom.parseString(poolxml) + path_element = doc.getElementsByTagName('path')[0] + textnode = path_element.childNodes[0] + path_value = textnode.data + + return path_value + +def write_file(path, capacity): + """write test data to file + """ + logger.info("write %s data into file %s" % (capacity, path)) + out = utils.get_capacity_suffix_size(capacity) + f = open(path, 'w') + datastr = ''.join(string.lowercase + string.uppercase + + string.digits + '.' + '\n') + repeat = out['capacity_byte'] / 64 + data = ''.join(repeat * datastr) + f.write(data) + f.close() + +def digest(path, offset, length): + """read data from file with length bytes, begin at offset + and return md5 hexdigest + """ + f = open(path, 'r') + f.seek(offset) + m = hashlib.md5() + done = 0 + + while True: + want = 1024 + if length and length - done < want: + want = length - done + outstr = f.read(want) + got = len(outstr) + if got == 0: + break + done += got + m.update(outstr) + + logger.debug("total %s bytes data is readed" % done) + + f.close() + return m.hexdigest() + +def handler(stream, data, file_): + return file_.write(data) + +def vol_download(params): + """test volume download and check""" + + global logger + logger = params['logger'] + poolname = params['poolname'] + volname = params['volname'] + volformat = params['volformat'] + offset = int(params['offset']) + length = int(params['length']) + capacity = params['capacity'] + xmlstr = params['xml'] + + logger.info("the poolname is %s, volname is %s, volformat is %s" % + (poolname, volname, volformat)) + logger.info("download offset is: %s" % offset) + logger.info("the data length to download is: %s" % length) + + conn = sharedmod.libvirtobj['conn'] + try: + poolobj = conn.storagePoolLookupByName(poolname) + path_value = get_pool_path(poolobj) + volume_path = path_value + "/" + volname + + xmlstr = xmlstr.replace('VOLPATH', volume_path) + xmlstr = xmlstr.replace('SUFFIX', capacity[-1]) + xmlstr = xmlstr.replace('CAP', capacity[:-1]) + logger.debug("volume xml:\n%s" % xmlstr) + + logger.info("create %s raw volume" % volname) + vol = poolobj.createXML(xmlstr, 0) + + write_file(volume_path, capacity) + origdigest = digest(volume_path, offset, length) + logger.debug("the md5 hex digest of data read from %s is: %s" % + (volume_path, origdigest)) + + st = conn.newStream(0) + + test_path = path_value + "/" + "vol_test" + + f = open(test_path, 'w') + logger.info("start download") + vol.download(st, offset, length, 0) + logger.info("downloaded all data") + st.recvAll(handler, f) + logger.info("finished stream") + st.finish() + f.close() + + newdigest = digest(test_path, 0, 0) + logger.debug("the md5 hex digest of data read from %s is: %s" % + (test_path, newdigest)) + + if origdigest == newdigest: + logger.info("file digests match, download succeed") + else: + logger.error("file digests not match, download failed") + return 1 + + except libvirtError, e: + logger.error("libvirt call failed: " + str(e)) + return 1 + + return 0 + +def vol_download_clean(params): + """clean testing environment""" + poolname = params['poolname'] + volname = params['volname'] + + conn = sharedmod.libvirtobj['conn'] + poolobj = conn.storagePoolLookupByName(poolname) + path_value = get_pool_path(poolobj) + test_path = path_value + "/" + "vol_test" + + vol = poolobj.storageVolLookupByName(volname) + vol.delete(0) + + if os.path.exists(test_path): + os.unlink(test_path) + + return 0 diff --git a/repos/storage/vol_upload.py b/repos/storage/vol_upload.py new file mode 100644 index 0000000..42af06f --- /dev/null +++ b/repos/storage/vol_upload.py @@ -0,0 +1,183 @@ +#!/usr/bin/env python +# storage volume upload testing, only raw format volume is +# supported, other format might fail. offset and length can +# only be chosen in 0 and 1048576. + +import os +import string +import hashlib +from xml.dom import minidom + +import libvirt +from libvirt import libvirtError + +from src import sharedmod + +required_params = ('poolname', 'volname', 'volformat', 'capacity', + 'offset', 'length',) +optional_params = {'xml' : 'xmls/dir_volume.xml', + } + +def get_pool_path(poolobj): + """ get pool xml description + """ + poolxml = poolobj.XMLDesc(0) + + logger.debug("the xml description of pool is %s" % poolxml) + + doc = minidom.parseString(poolxml) + path_element = doc.getElementsByTagName('path')[0] + textnode = path_element.childNodes[0] + path_value = textnode.data + + return path_value + +def write_file(path): + """write 1M test data to file + """ + logger.info("write data into file %s" % path) + f = open(path, 'w') + datastr = ''.join(string.lowercase + string.uppercase + + string.digits + '.' + '\n') + data = ''.join(16384 * datastr) + f.write(data) + f.close() + +def digest(path, offset, length): + """read data from file with length bytes, begin at offset + and return md5 hexdigest + """ + f = open(path, 'r') + f.seek(offset) + m = hashlib.md5() + done = 0 + + while True: + want = 1024 + if length and length - done < want: + want = length - done + outstr = f.read(want) + got = len(outstr) + if got == 0: + break + done += got + m.update(outstr) + + logger.debug("total %s bytes data is readed" % done) + + f.close() + return m.hexdigest() + +def handler(stream, data, file_): + return file_.read(data) + +def vol_upload(params): + """test volume download and check""" + + global logger + logger = params['logger'] + poolname = params['poolname'] + volname = params['volname'] + volformat = params['volformat'] + offset = int(params['offset']) + length = int(params['length']) + capacity = params['capacity'] + xmlstr = params['xml'] + + logger.info("the poolname is %s, volname is %s, volformat is %s" % + (poolname, volname, volformat)) + logger.info("upload offset is: %s" % offset) + logger.info("the data length to upload is: %s" % length) + + conn = sharedmod.libvirtobj['conn'] + try: + poolobj = conn.storagePoolLookupByName(poolname) + path_value = get_pool_path(poolobj) + volume_path = path_value + "/" + volname + + xmlstr = xmlstr.replace('VOLPATH', volume_path) + xmlstr = xmlstr.replace('SUFFIX', capacity[-1]) + xmlstr = xmlstr.replace('CAP', capacity[:-1]) + logger.debug("volume xml:\n%s" % xmlstr) + + logger.info("create %s raw volume" % volname) + vol = poolobj.createXML(xmlstr, 0) + + test_path = path_value + "/" + "vol_test" + write_file(test_path) + olddigest = digest(test_path, 0, 0) + logger.debug("the old file digest is: %s" % olddigest) + + if offset: + origdigestpre = digest(volume_path, 0, offset) + else: + origdigestpre = '' + logger.debug("the original pre region digest is: %s" % origdigestpre) + + origdigestpost = digest(volume_path, offset + 1024 * 1024, 0) + logger.debug("the original post region digest is: %s" % origdigestpost) + + st = conn.newStream(0) + + f = open(test_path, 'r') + logger.info("start upload") + vol.upload(st, offset, length, 0) + logger.info("sent all data") + st.sendAll(handler, f) + logger.info("finished stream") + st.finish() + f.close() + + newdigest = digest(volume_path, offset, 1024 * 1024) + logger.debug("the new file digest is: %s" % olddigest) + + if offset: + newdigestpre = digest(volume_path, 0, offset) + else: + newdigestpre = '' + logger.debug("the new pre region digest is: %s" % origdigestpre) + + newdigestpost = digest(volume_path, offset + 1024 * 1024, 0) + logger.debug("the new post region digest is: %s" % origdigestpost) + + if newdigestpre == origdigestpre: + logger.info("file pre region digests match") + else: + logger.error("file pre region digests not match") + return 1 + + if olddigest == newdigest: + logger.info("file digests match") + else: + logger.error("file digests not match") + return 1 + + if newdigestpost == origdigestpost: + logger.info("file post region digests match") + else: + logger.error("file post region digests not match") + return 1 + + except libvirtError, e: + logger.error("libvirt call failed: " + str(e)) + return 1 + + return 0 + +def vol_upload_clean(params): + """clean testing environment""" + poolname = params['poolname'] + volname = params['volname'] + + conn = sharedmod.libvirtobj['conn'] + poolobj = conn.storagePoolLookupByName(poolname) + path_value = get_pool_path(poolobj) + test_path = path_value + "/" + "vol_test" + + vol = poolobj.storageVolLookupByName(volname) + vol.delete(0) + + if os.path.exists(test_path): + os.unlink(test_path) + + return 0 -- 1.7.1

1 0

[libvirt] [PATCH 0/6] Fix multiple problems while dealing with transient networks
by Peter Krempa 28 Dec '12

28 Dec '12

This series fixes a few issues when dealing with transient networks: 1) Check for multiple DHCP sections is added also to transient networks 2) Create and clean up dnsmasq config files when dealing with transient networks 3) Add support for making network transient with undefine 4) a few cleanups Peter Krempa (6): conf: net: Fix helper for applying new network definition net: Change argument type of virNetworkObjIsDuplicate() net: Move creation of dnsmasq hosts file to function starting dnsmasq net: Remove dnsmasq and radvd files also when destroying transient nets net: Re-use checks when creating transient networks net: Add support for changing persistent networks to transient src/conf/network_conf.c | 4 +- src/conf/network_conf.h | 2 +- src/network/bridge_driver.c | 261 +++++++++++++++++++++++--------------------- 3 files changed, 138 insertions(+), 129 deletions(-) -- 1.7.12.4

4 30

Re: [libvirt] [Users] Vdsm/libvir error during deploy
by Dan Kenigsberg 27 Dec '12

27 Dec '12

On Mon, Dec 24, 2012 at 02:18:48PM +0100, Joop wrote: > Dan Kenigsberg wrote: > >Which version of libvirt is installed on your host? > > > libvirt-1.0.1-2.fc17.x86_64 > libvirt-client-1.0.1-2.fc17.x86_64 > libvirt-daemon-1.0.1-2.fc17.x86_64 > libvirt-daemon-config-network-1.0.1-2.fc17.x86_64 > libvirt-daemon-config-nwfilter-1.0.1-2.fc17.x86_64 > libvirt-daemon-driver-interface-1.0.1-2.fc17.x86_64 > libvirt-daemon-driver-lxc-1.0.1-2.fc17.x86_64 > libvirt-daemon-driver-network-1.0.1-2.fc17.x86_64 > libvirt-daemon-driver-nodedev-1.0.1-2.fc17.x86_64 > libvirt-daemon-driver-nwfilter-1.0.1-2.fc17.x86_64 > libvirt-daemon-driver-qemu-1.0.1-2.fc17.x86_64 > libvirt-daemon-driver-secret-1.0.1-2.fc17.x86_64 > libvirt-daemon-driver-storage-1.0.1-2.fc17.x86_64 > libvirt-daemon-driver-uml-1.0.1-2.fc17.x86_64 > libvirt-daemon-driver-xen-1.0.1-2.fc17.x86_64 > libvirt-lock-sanlock-1.0.1-2.fc17.x86_64 > libvirt-python-1.0.1-2.fc17.x86_64 > > From virt-preview repo > [fedora-virt-preview] > name=Virtualization packages from Rawhide built for latest Fedora > baseurl=http://fedorapeople.org/groups/virt/virt-preview/fedora-$releasever… > enabled=1 > skip_if_unavailable=1 > gpgcheck=0 > > >What is the output of the following python script on your machine? Mine > >says "1". Could it be that your libvirt says "0"? > > > >============= > > > >from vdsm import libvirtconnection > > > >conn = libvirtconnection.get() > >netXml = """<network> > > <name>test</name> > > <forward mode='passthrough'> > > <interface dev='em1'/> > > </forward> > ></network> > >""" > > > >net = conn.networkDefineXML(netXml) > >net.create() > >print net.isPersistent() > >net.destroy() > >net.undefine() > > > > > 0 > libvir: Network Driver error : Network not found: no network with > matching uuid > Traceback (most recent call last): > File "test.py", line 16, in <module> > net.undefine() > File "/usr/lib64/python2.7/site-packages/libvirt.py", line 2154, in > undefine > if ret == -1: raise libvirtError ('virNetworkUndefine() failed', > net=self) > libvirt.libvirtError: Network not found: no network with matching uuid > > So '0' :-(( > Suppose that error isn't good either. > Should I downgrade to an earlier version of libvirt? Please try. My guess is that this is a libvirt bug added by http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=0211fd6e04cdc402da2081… in libvirt 1.0.1. More authoritative answer is expected by those added to the CC line.

3 4

[libvirt] [PATCH] ESX: append CURL headers to fix serviceContent entities
by Ata E Husain Bohra 26 Dec '12

26 Dec '12

It seems with current SOAP header the call to retrieve "serviceContent" object does not populate all available references (for instance: ovfManager). The host exposes details of these Managed Object References (MoBs) if header is appended with "SOAPACtion" field. Ata E Husain Bohra (1): ESX: append CURL headers to fix serviceContent entities src/esx/esx_vi.c | 2 ++ src/esx/esx_vi_generator.input | 3 +++ 2 files changed, 5 insertions(+) -- 1.7.9.5

1 0

[libvirt] [jenkins@libvirt.sigxcpu.org: Build failed in Jenkins: libvirt-check #419]
by Guido Günther 25 Dec '12

25 Dec '12

Hi, it seems one of these commits 5411e7e176dcbb65591cb97ec128b5fd0f365805 473011334ccd93e8efbb67f2561f1d4e54d212ae 392c192240566d9e167d2b5a1022092d8f7e045c broke "make check" as seen on http://honk.sigxcpu.org:8001/job/libvirt-check/417/console output attached. I can't look into this in more right now though. Cheers, -- Guido P.S.: the libvirt-tck check is also currently broken but that's probably a fallout of the above.

3 7

[libvirt] [PATCH 0/2] Use more of qemuDomObjFromDomain
by Michal Privoznik 24 Dec '12

24 Dec '12

I know we are in the freeze so I will push this after upstream is thaw. Michal Privoznik (2): qemu: Relax locking in DomainHasManagedSaveImage and DomainMonitorCommand qemu: Convert some APIs to use qemuDomObjFromDomain src/qemu/qemu_driver.c | 478 +++++------------------------------------------ 1 files changed, 51 insertions(+), 427 deletions(-) -- 1.7.8.6

2 7

[libvirt] libvirt will wait 20 minutes or hang when the network interface down
by Benjamin Wang (gendwang) 24 Dec '12

24 Dec '12

Hi, I find that when the network interface is down. In most scenarios, the libvirt will wait 20 minutes and report the exception. In seldom scenarios, the polling thread will hang even if the network is recovered. The following is the formal description from libcurl website: http://curl.haxx.se/docs/faq.html (Section "4.19 Why doesn't cURL return an error when the network cable is unplugged?") The following is the similar case about thread hand: http://curl.haxx.se/mail/lib-2010-07/0108.html For "wait 20 minutes", although this is the TCP normal mechanism, but if a server manages tons of thousands of devices by libvirt. When 1000 devices are down, This could cause thread leak for a long period. For thread hang, this could cause thread leak forever. I tried to add the following codes in esx_vi.c. It seems that these code can avoid the above issues. Would you give your comments? if (curl->headers == NULL) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Could not build CURL header list")); return -1; } + curl_easy_setopt(curl->handle, CURLOPT_LOW_SPEED_LIMIT, 10); + curl_easy_setopt(curl->handle, CURLOPT_LOW_SPEED_TIME, 120); curl_easy_setopt(curl->handle, CURLOPT_USERAGENT, "libvirt-esx"); curl_easy_setopt(curl->handle, CURLOPT_HEADER, 0); curl_easy_setopt(curl->handle, CURLOPT_FOLLOWLOCATION, 0); curl_easy_setopt(curl->handle, CURLOPT_SSL_VERIFYPEER, B.R. Benjamin Wang

2 2

[libvirt] [PATCH 0/8] Fix PowerPC CPU driver
by Jiri Denemark 22 Dec '12

22 Dec '12

Current PowerPC driver is too complicated and mostly wrong as it was apparently created from x86 driver and not properly addapted for PowerPC architecture. More details about the issues are described in individual patches. Jiri Denemark (8): cpu: Introduce cpuModelIsAllowed internal API cpu: Make comparing PowerPC CPUs easier to read cpu: Fix PowerPCNodeData cpu: Fix loading PowerPC vendor from cpu_map.xml cpu: Reimplement PowerPCBaseline cpu: Reimplement PowerPCDecode cpu: Remove hardcoded list of PowerPC models cpu: Rename PowerPCUpdate and PowerPCDataFree functions src/cpu/cpu.c | 17 ++ src/cpu/cpu.h | 5 + src/cpu/cpu_generic.c | 19 +-- src/cpu/cpu_map.xml | 12 +- src/cpu/cpu_powerpc.c | 462 +++++++++++++++++--------------------------------- src/cpu/cpu_x86.c | 11 +- 6 files changed, 193 insertions(+), 333 deletions(-) -- 1.8.0.2

3 17