- Devel - libvirt List Archives

[libvirt] [Libvirt][Sheepdog]How to test Sheepdog patch
by harryxiyou 28 Jan '13

28 Jan '13

Hi Morita and other developers, I have done following jobs. 1, git clone git://libvirt.org/libvirt.git 2, cd libvirt 3, git reset --hard 036ad50 4, ./autogen.sh 5, make NOTE: step 3 calls back to Morita's patch for Libvirt version, which is here http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=036ad5052b43fe9f0d197e… After step 5, i have following questions. 1, I am not clear about how to test Sheepdog. Actually, i just wanna study Sheepdog driver, then i will program our driver for Libvirt. 2, I am not clear about how Sheepdog, Libvirt and QEMU communicate with each other. Before my test for Sheepdog patch for Libvirt, i have to build Sheepdog, Libvirt and QEMU environment, right? Morita, i have seen your patch for Libvirt but i do not find it calls for Sheepdog functions, so it does not have to build Sheepdog environment, right? -- Thanks Harry Wei

2 2

[libvirt] [Sheepdog][Libvirt]How should i test sheepdog in libvirt
by harryxiyou 27 Jan '13

27 Jan '13

Hi Morita, I just wanna test if sheepdog works well in libvirt. I am not sure if i can only use libvirt environment to finish this test? Or maybe i should also set up QEMU/Sheepdog/Openstack environment, right? I have done following jobs. 1, git clone git://libvirt.org/libvirt.git 2, cd libvirt 3, git reset --hard v0.9.13 4, ./autogen.sh && make NOTE: Step 3 just call back to libvirt version 0.9.13, which you, Morita, patched for Libvirt at around this version. (Your patch is here http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=036ad5052b43fe9f0d197e…) I just wanna study the original patch for libvirt. After step 4, if i can use tool virsh(under libvirt/tools dir) to test sheepdog driver? Therefore, i am not sure how i should use tool virsh to test if Sheepdog driver works well in libvirt. If i can finish this test only with libvirt ENV.?(Or also should set up QEMU/Sheepdog/Openstack environment) How should i do next step? Could anyone give me some suggestions? Thanks in advance ;-) -- Thanks Harry Wei

2 7

[libvirt] [Libvirt][QEMU]The relationships between Libvirt and QEMU indetails
by harryxiyou 27 Jan '13

27 Jan '13

Hi Daniel and other developers, We have programed a HLFS(HDFS based Log-Structured FileSystem) driver for QEMU, which you can see it here. http://cloudxy.googlecode.com/svn/trunk/hlfs/patches/hlfs_driver_for_qemu_1… And i have tested in QEMU environment, which works well for us. Now, we wanna add a HLFS driver(Volume storage) for Libvirt(The same as Sheepdog) but i am not sure how to test HLFS driver for Libvirt. How could i know if the HLFS driver for Libvirt works well? I guess libvirt uses qemu interfaces(QEMU way) to finish the real jobs like create/delete volumes. I wanna use command 'virsh' to finish them, which the logical procedure like this: virsh --> libvirt client --> libvirt server --> QEMU Therefore, 'virsh' cannot work for me. I do not know how to test it with command 'virsh' solely. Or maybe i must build QEMU environment for this test, right? In brief, i am not clear about the relationships between Libvirt and QEMU. How do they(QEMU and Libvirt) communicate with each other? How could i test create/delete volumes of Sheepdog/HLFS only with Libvirt environment? Could anyone give me some suggestions? Thanks in advance;-) -- Thanks Harry Wei

1 0

[libvirt] [PATCH] virlog: remove old code comment
by Doug Goldstein 27 Jan '13

27 Jan '13

Setting the log output prefix to 0 is not supported and in fact results in the following message: warning : virLogParseOutputs:1021 : Ignoring invalid log output setting. --- src/util/virlog.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index acd42c1..24ec9d3 100644 --- a/src/util/virlog.c +++ b/src/util/virlog.c @@ -1261,7 +1261,6 @@ static int virLogAddOutputToJournald(int priority) * x:file:file_path * output to a file, with the given filepath * In all case the x prefix is the minimal level, acting as a filter - * 0: everything * 1: DEBUG * 2: INFO * 3: WARNING -- 1.7.12.4

2 1

[libvirt] [PATCH 0/7] Introduce virCommandDoAsyncIO
by Michal Privoznik 27 Jan '13

27 Jan '13

Currently, if we want to use IO with asynchronous command we have to copy code from virFileWrapperFd to misuse our event loop for reading and writing to the command. However, we can extend our virCommand implementation to automatically set things up. Michal Privoznik (7): virCommand: Introduce virCommandDoAsyncIO Introduce event loop to commandtest tests: Create test for virCommandDoAsyncIO virFileWrapperFd: Switch to new virCommandDoAsyncIO qemu: Catch stderr of image decompression binary qemu: Catch stderr of image compression binary qemu: Destroy domain on decompression binary error src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 9 +- src/qemu/qemu_migration.c | 9 +- src/util/vircommand.c | 214 ++++++++++++++++++++++++++++++++++++++++++-- src/util/vircommand.h | 1 + src/util/virfile.c | 82 +---------------- tests/commanddata/test3.log | 2 +- tests/commandtest.c | 136 ++++++++++++++++++++++++++++ 8 files changed, 365 insertions(+), 89 deletions(-) -- 1.8.0.2

2 15

[libvirt] qemu kvm-pit device arg missing?
by Doug Goldstein 27 Jan '13

27 Jan '13

With a domain defined with the following: <clock offset='utc'> <timer name='pit' tickpolicy='delay'/> <timer name='rtc' tickpolicy='catchup'/> </clock> The following define is set: VIR_DOMAIN_TIMER_TICKPOLICY_DELAY for VIR_DOMAIN_TIMER_NAME_PIT. And VIR_DOMAIN_TIMER_TICKPOLICY_CATCHUP for VIR_DOMAIN_TIMER_NAME_RTC. I see where for the RTC we'll set -rtc,driftfix=slew (well -rtc,base=X,driftfix=slew) or -rtc-td-hack for older qemu's. But for the kvm-pit, we pass with qemu{,-kvm} 1.1 and lower -no-kvm-pit-reinjection but with qemu{,-kvm} 1.2 the QEMU_CAPS_NO_KVM_PIT is not set, nor detected via QMP so nothing is ever passed. I even looked through the QMP commands passed once the process is started and there doesn't seem to be anything passed. I was expecting with qemu{,-kvm} 1.2 and newer to see -device kvm-pit,lost_tick_policy=discard appear on the command line but didn't. Am I missing something? Or is this command line argument not necessary any longer? -- Doug Goldstein

1 0

[libvirt] [PATCH] Make python objects inherit from 'object' base class
by Daniel P. Berrange 26 Jan '13

26 Jan '13

From: "Daniel P. Berrange" <berrange(a)redhat.com> As of python >= 2.2, it is recommended that all objects inherit from the 'object' base class. We already require python >= 2.3 for libvirt for thread macro support, so we should follow this best practice. See also http://stackoverflow.com/questions/4015417/python-class-inherits-object This is motivated the patch Rich just did for libguestfs https://www.redhat.com/archives/libguestfs/2013-January/msg00063.html Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- python/generator.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/generator.py b/python/generator.py index f853d77..a079fc5 100755 --- a/python/generator.py +++ b/python/generator.py @@ -1413,7 +1413,7 @@ def buildWrappers(module): classes.write(" %s.__init__(self, _obj=_obj)\n\n" % ( classes_ancestor[classname])) else: - classes.write("class %s:\n" % (classname)) + classes.write("class %s(object):\n" % (classname)) if classname in [ "virDomain", "virNetwork", "virInterface", "virStoragePool", "virStorageVol", "virNodeDevice", "virSecret","virStream", "virNWFilter" ]: -- 1.8.1

3 2

[libvirt] [PATCH 0/2] Resolve Coverity issues in vbox_tmpl.c
by John Ferlan 26 Jan '13

26 Jan '13

This pair of patches resolves what amount to false positives in the vbox_tmpl.c code relating to attempts to dereference NULL in the 2002 VBOX_API_VERSION call to 'vboxIIDFromUUID()'. It also removes "false postives" from the various VBOX_UTF*_FREE() macros. Some code paths checked if the arg was valid prior to calling free. That triggered Coverity into tagging other uses of the variables where the check wasn't performed. While these changes resolve the Coverity issues there still exists a "problem" where the VBOX_UTF<n>_TO_UTF<m> macros don't check the return status from the called function nor does the code that uses the macros always check the returned arg2 for validity (125 occurrances). John Ferlan (2): vbox: Address false positive for NULL dereference vbox: Adjust the UTF FREE macros src/vbox/vbox_tmpl.c | 77 ++++++++++++++++++++++++++-------------------------- 1 file changed, 38 insertions(+), 39 deletions(-) -- 1.7.11.7

2 5

[libvirt] [PATCH] Make sure we only abort without libcurl if $with_esx = yes
by Guido Günther 25 Jan '13

25 Jan '13

--- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 712918f..4bd3c3e 100644 --- a/configure.ac +++ b/configure.ac @@ -1810,7 +1810,7 @@ dnl check for (ESX) dnl if test "$with_curl" != "yes" ; then - if test "$with_esx" = "check"; then + if test "$with_esx" != "yes"; then with_esx=no else AC_MSG_ERROR([Curl is required for the ESX driver]) -- 1.7.10.4

2 2

[libvirt] [PATCH] virsh: Add --print-xml flag for attach-disk command
by Peter Krempa 25 Jan '13

25 Jan '13

The flag causes the XML of the disk that would be attached to be printed instead. --- tools/virsh-domain.c | 46 ++++++++++++++++++++++++++++------------------ tools/virsh.pod | 5 ++++- 2 files changed, 32 insertions(+), 19 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 026dac1..829e475 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -317,6 +317,12 @@ static const vshCmdOptDef opts_attach_disk[] = { .flags = 0, .help = N_("use multifunction pci under specified address") }, + {.name = "print-xml", + .type = VSH_OT_BOOL, + .flags = 0, + .help = N_("print XML document rather than attach the disk") + }, + {.name = NULL} }; @@ -480,11 +486,11 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd) unsigned int flags; const char *stype = NULL; virBuffer buf = VIR_BUFFER_INITIALIZER; - char *xml; + char *xml = NULL; struct stat st; if (!(dom = vshCommandOptDomain(ctl, cmd, NULL))) - goto cleanup; + return false; if (vshCommandOptString(cmd, "source", &source) <= 0) goto cleanup; @@ -620,27 +626,31 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd) xml = virBufferContentAndReset(&buf); - if (vshCommandOptBool(cmd, "config")) { - flags = VIR_DOMAIN_AFFECT_CONFIG; - if (virDomainIsActive(dom) == 1) - flags |= VIR_DOMAIN_AFFECT_LIVE; - ret = virDomainAttachDeviceFlags(dom, xml, flags); - } else { - ret = virDomainAttachDevice(dom, xml); - } - - VIR_FREE(xml); + if (!vshCommandOptBool(cmd, "print-xml")) { + if (vshCommandOptBool(cmd, "config")) { + flags = VIR_DOMAIN_AFFECT_CONFIG; + if (virDomainIsActive(dom) == 1) + flags |= VIR_DOMAIN_AFFECT_LIVE; + ret = virDomainAttachDeviceFlags(dom, xml, flags); + } else { + ret = virDomainAttachDevice(dom, xml); + } - if (ret != 0) { - vshError(ctl, "%s", _("Failed to attach disk")); + if (ret != 0) { + vshError(ctl, "%s", _("Failed to attach disk")); + goto cleanup; + } else { + vshPrint(ctl, "%s", _("Disk attached successfully\n")); + } } else { - vshPrint(ctl, "%s", _("Disk attached successfully\n")); - functionReturn = true; + vshPrint(ctl, "%s", xml); } + functionReturn = true; + cleanup: - if (dom) - virDomainFree(dom); + VIR_FREE(xml); + virDomainFree(dom); virBufferFreeAndReset(&buf); return functionReturn; } diff --git a/tools/virsh.pod b/tools/virsh.pod index e2a2aec..fd0f762 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -1787,7 +1787,7 @@ needed if the device does not use managed mode. [I<--driver driver>] [I<--subdriver subdriver>] [I<--cache cache>] [I<--type type>] [I<--mode mode>] [I<--config>] [I<--sourcetype soucetype>] [I<--serial serial>] [I<--shareable>] [I<--rawio>] [I<--address address>] -[I<--multifunction>] +[I<--multifunction>] [I<--print-xml>] Attach a new disk device to the domain. I<source> is path for the files and devices. I<target> controls the bus or @@ -1817,6 +1817,9 @@ scsi:controller.bus.unit or ide:controller.bus.unit. I<multifunction> indicates specified pci address is a multifunction pci device address. +If I<--print-xml> is specified, then the XML of the disk that would be attached +is printed instead. + =item B<attach-interface> I<domain> I<type> I<source> [I<--target target>] [I<--mac mac>] [I<--script script>] [I<--model model>] [I<--config>] [I<--inbound average,peak,burst>] [I<--outbound average,peak,burst>] -- 1.8.1.1

3 3