- Devel - libvirt List Archives

[libvirt] [PATCH v5] qemu: Allow migration over IPv6
by Ján Tomko 02 Apr '13

02 Apr '13

Allow migration over IPv6 by listening on [::] instead of 0.0.0.0 when QEMU supports it (QEMU_CAPS_IPV6_MIGRATION) and there is at least one v6 address configured on the system. Use virURIParse in qemuMigrationPrepareDirect to allow parsing IPv6 addresses, which would cause an 'incorrect :port' error message before. Move setting of migrateFrom from qemuMigrationPrepare{Direct,Tunnel} after domain XML parsing, since we need the QEMU binary path from it to get its capabilities. Bug: https://bugzilla.redhat.com/show_bug.cgi?id=846013 --- diff to v4: Always listen on IPv6 if it's available. Don't add a migration flag. v4: https://www.redhat.com/archives/libvir-list/2013-March/msg01213.html discussion: https://www.redhat.com/archives/libvir-list/2013-March/msg00515.html src/qemu/qemu_capabilities.c | 6 +++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_migration.c | 104 +++++++++++++++++++++++++++++++++---------- tests/qemuhelptest.c | 9 ++-- 4 files changed, 93 insertions(+), 27 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 3840b41..1e1da4d 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -213,6 +213,8 @@ VIR_ENUM_IMPL(virQEMUCaps, QEMU_CAPS_LAST, "virtio-ccw", "dtb", "megasas", + + "ipv6-migration", /* 135 */ ); struct _virQEMUCaps { @@ -1181,6 +1183,9 @@ virQEMUCapsComputeCmdFlags(const char *help, if (version >= 11000) virQEMUCapsSet(qemuCaps, QEMU_CAPS_CPU_HOST); + if (version >= 1001000) + virQEMUCapsSet(qemuCaps, QEMU_CAPS_IPV6_MIGRATION); + if (version >= 1002000) virQEMUCapsSet(qemuCaps, QEMU_CAPS_DEVICE_VIDEO_PRIMARY); return 0; @@ -2317,6 +2322,7 @@ virQEMUCapsInitQMPBasic(virQEMUCapsPtr qemuCaps) virQEMUCapsSet(qemuCaps, QEMU_CAPS_SECCOMP_SANDBOX); virQEMUCapsSet(qemuCaps, QEMU_CAPS_NO_KVM_PIT); virQEMUCapsSet(qemuCaps, QEMU_CAPS_DTB); + virQEMUCapsSet(qemuCaps, QEMU_CAPS_IPV6_MIGRATION); } diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h index 7101f67..2ccc7c2 100644 --- a/src/qemu/qemu_capabilities.h +++ b/src/qemu/qemu_capabilities.h @@ -174,6 +174,7 @@ enum virQEMUCapsFlags { QEMU_CAPS_VIRTIO_CCW = 132, /* -device virtio-*-ccw */ QEMU_CAPS_DTB = 133, /* -dtb file */ QEMU_CAPS_SCSI_MEGASAS = 134, /* -device megasas */ + QEMU_CAPS_IPV6_MIGRATION = 135, /* -incoming [::] */ QEMU_CAPS_LAST, /* this must always be the last item */ }; diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 537b834..867c7f1 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -22,6 +22,8 @@ #include <config.h> +#include <netdb.h> +#include <sys/socket.h> #include <sys/time.h> #ifdef WITH_GNUTLS # include <gnutls/gnutls.h> @@ -1104,12 +1106,12 @@ error: */ static int qemuMigrationStartNBDServer(virQEMUDriverPtr driver, - virDomainObjPtr vm) + virDomainObjPtr vm, + const char *listenAddr) { int ret = -1; qemuDomainObjPrivatePtr priv = vm->privateData; unsigned short port = 0; - const char *listenAddr = "0.0.0.0"; char *diskAlias = NULL; size_t i; @@ -1980,8 +1982,8 @@ qemuMigrationPrepareAny(virQEMUDriverPtr driver, int *cookieoutlen, const char *dname, const char *dom_xml, - const char *migrateFrom, virStreamPtr st, + unsigned int port, unsigned long flags) { virDomainDefPtr def = NULL; @@ -1997,6 +1999,8 @@ qemuMigrationPrepareAny(virQEMUDriverPtr driver, char *xmlout = NULL; unsigned int cookieFlags; virCapsPtr caps = NULL; + const char *listenAddr = NULL; + char *migrateFrom = NULL; if (virTimeMillisNow(&now) < 0) return -1; @@ -2084,6 +2088,45 @@ qemuMigrationPrepareAny(virQEMUDriverPtr driver, } } + if (tunnel) { + /* QEMU will be started with -incoming stdio + * (which qemu_command might convert to exec:cat or fd:n) + */ + if (!(migrateFrom = strdup("stdio"))) { + virReportOOMError(); + goto cleanup; + } + } else { + virQEMUCapsPtr qemuCaps = NULL; + struct addrinfo *info = NULL; + struct addrinfo hints = { .ai_flags = AI_ADDRCONFIG, + .ai_socktype = SOCK_STREAM }; + + if (!(qemuCaps = virQEMUCapsCacheLookupCopy(driver->qemuCapsCache, + def->emulator))) + goto cleanup; + + /* Listen on :: instead of 0.0.0.0 if QEMU understands it + * and there is at least one IPv6 address configured + */ + if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_IPV6_MIGRATION) && + getaddrinfo("::", NULL, &hints, &info) == 0) { + freeaddrinfo(info); + listenAddr = "[::]"; + } else { + listenAddr = "0.0.0.0"; + } + virObjectUnref(qemuCaps); + + /* QEMU will be started with -incoming [::]:port + * or -incoming 0.0.0.0:port + */ + if (virAsprintf(&migrateFrom, "tcp:%s:%d", listenAddr, port) < 0) { + virReportOOMError(); + goto cleanup; + } + } + if (!(vm = virDomainObjListAdd(driver->domains, driver->xmlconf, def, @@ -2172,7 +2215,7 @@ done: if (flags & VIR_MIGRATE_TUNNELLED) VIR_DEBUG("NBD in tunnelled migration is currently not supported"); else { - if (qemuMigrationStartNBDServer(driver, vm) < 0) { + if (qemuMigrationStartNBDServer(driver, vm, listenAddr) < 0) { /* error already reported */ goto endjob; } @@ -2213,6 +2256,7 @@ done: ret = 0; cleanup: + VIR_FREE(migrateFrom); VIR_FREE(origname); VIR_FREE(xmlout); virDomainDefFree(def); @@ -2270,12 +2314,9 @@ qemuMigrationPrepareTunnel(virQEMUDriverPtr driver, driver, dconn, NULLSTR(cookiein), cookieinlen, cookieout, cookieoutlen, st, NULLSTR(dname), dom_xml, flags); - /* QEMU will be started with -incoming stdio (which qemu_command might - * convert to exec:cat or fd:n) - */ ret = qemuMigrationPrepareAny(driver, dconn, cookiein, cookieinlen, cookieout, cookieoutlen, dname, dom_xml, - "stdio", st, flags); + st, 0, flags); return ret; } @@ -2296,9 +2337,10 @@ qemuMigrationPrepareDirect(virQEMUDriverPtr driver, static int port = 0; int this_port; char *hostname = NULL; - char migrateFrom [64]; const char *p; + char *uri_str = NULL; int ret = -1; + virURIPtr uri; VIR_DEBUG("driver=%p, dconn=%p, cookiein=%s, cookieinlen=%d, " "cookieout=%p, cookieoutlen=%p, uri_in=%s, uri_out=%p, " @@ -2347,16 +2389,39 @@ qemuMigrationPrepareDirect(virQEMUDriverPtr driver, * URI when passing it to the qemu monitor, so bad * characters in hostname part don't matter. */ - if (!STRPREFIX(uri_in, "tcp:")) { + if (!(p = STRSKIP(uri_in, "tcp:"))) { virReportError(VIR_ERR_INVALID_ARG, "%s", _("only tcp URIs are supported for KVM/QEMU" " migrations")); goto cleanup; } - /* Get the port number. */ - p = strrchr(uri_in, ':'); - if (p == strchr(uri_in, ':')) { + /* Convert uri_in to well-formed URI with // after tcp: */ + if (!(STRPREFIX(uri_in, "tcp://"))) { + if (virAsprintf(&uri_str, "tcp://%s", p) < 0) { + virReportOOMError(); + goto cleanup; + } + } + + uri = virURIParse(uri_str ? uri_str : uri_in); + VIR_FREE(uri_str); + + if (uri == NULL) { + virReportError(VIR_ERR_INVALID_ARG, _("unable to parse URI: %s"), + uri_in); + goto cleanup; + } + + if (uri->server == NULL) { + virReportError(VIR_ERR_INVALID_ARG, _("missing host in migration" + " URI: %s"), uri_in); + goto cleanup; + } else { + hostname = uri->server; + } + + if (uri->port == 0) { /* Generate a port */ this_port = QEMUD_MIGRATION_FIRST_PORT + port++; if (port == QEMUD_MIGRATION_NUM_PORTS) @@ -2369,25 +2434,16 @@ qemuMigrationPrepareDirect(virQEMUDriverPtr driver, } } else { - p++; /* definitely has a ':' in it, see above */ - this_port = virParseNumber(&p); - if (this_port == -1 || p-uri_in != strlen(uri_in)) { - virReportError(VIR_ERR_INVALID_ARG, - "%s", _("URI ended with incorrect ':port'")); - goto cleanup; - } + this_port = uri->port; } } if (*uri_out) VIR_DEBUG("Generated uri_out=%s", *uri_out); - /* QEMU will be started with -incoming tcp:0.0.0.0:port */ - snprintf(migrateFrom, sizeof(migrateFrom), "tcp:0.0.0.0:%d", this_port); - ret = qemuMigrationPrepareAny(driver, dconn, cookiein, cookieinlen, cookieout, cookieoutlen, dname, dom_xml, - migrateFrom, NULL, flags); + NULL, this_port, flags); cleanup: VIR_FREE(hostname); if (ret != 0) diff --git a/tests/qemuhelptest.c b/tests/qemuhelptest.c index a28109a..05bb8a6 100644 --- a/tests/qemuhelptest.c +++ b/tests/qemuhelptest.c @@ -812,7 +812,8 @@ mymain(void) QEMU_CAPS_DEVICE_VMWARE_SVGA, QEMU_CAPS_DEVICE_USB_SERIAL, QEMU_CAPS_DEVICE_USB_NET, - QEMU_CAPS_DTB); + QEMU_CAPS_DTB, + QEMU_CAPS_IPV6_MIGRATION); DO_TEST("qemu-1.2.0", 1002000, 0, 0, QEMU_CAPS_VNC_COLON, QEMU_CAPS_NO_REBOOT, @@ -913,7 +914,8 @@ mymain(void) QEMU_CAPS_DEVICE_USB_SERIAL, QEMU_CAPS_DEVICE_USB_NET, QEMU_CAPS_DTB, - QEMU_CAPS_SCSI_MEGASAS); + QEMU_CAPS_SCSI_MEGASAS, + QEMU_CAPS_IPV6_MIGRATION); DO_TEST("qemu-kvm-1.2.0", 1002000, 1, 0, QEMU_CAPS_VNC_COLON, QEMU_CAPS_NO_REBOOT, @@ -1019,7 +1021,8 @@ mymain(void) QEMU_CAPS_DEVICE_USB_SERIAL, QEMU_CAPS_DEVICE_USB_NET, QEMU_CAPS_DTB, - QEMU_CAPS_SCSI_MEGASAS); + QEMU_CAPS_SCSI_MEGASAS, + QEMU_CAPS_IPV6_MIGRATION); return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -- 1.8.1.5

2 2

[libvirt] [PATCH] qemu: Support multiple queue virtio-scsi
by Osier Yang 02 Apr '13

02 Apr '13

This introduce a new attribute "num_queues" (same with the good name QEMU uses) for virtio-scsi controller. An example of the XML: <controller type='scsi' index='0' model='virtio-scsi' num_queues='8'/> The corresponding QEMU command line: -device virtio-scsi-pci,id=scsi0,num_queues=8,bus=pci.0,addr=0x3 \ --- docs/formatdomain.html.in | 9 +++++--- docs/schemas/domaincommon.rng | 5 +++++ src/conf/domain_conf.c | 13 +++++++++++ src/conf/domain_conf.h | 1 + src/qemu/qemu_command.c | 11 +++++++++ .../qemuxml2argv-disk-virtio-scsi-num_queues.args | 8 +++++++ .../qemuxml2argv-disk-virtio-scsi-num_queues.xml | 26 ++++++++++++++++++++++ tests/qemuxml2argvtest.c | 3 +++ tests/qemuxml2xmltest.c | 1 + 9 files changed, 74 insertions(+), 3 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-virtio-scsi-num_queues.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-virtio-scsi-num_queues.xml diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index cf382e8..262f1ac 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -2092,10 +2092,13 @@ controller. A "scsi" controller has an optional attribute <code>model</code>, which is one of "auto", "buslogic", "ibmvscsi", "lsilogic", "lsisas1068", "lsisas1078", "virtio-scsi" or - "vmpvscsi". A "usb" controller has an optional attribute + "vmpvscsi". The attribute <code>num_queues</code> + (<span class="since">1.0.5 (QEMU and KVM only)</span>) is to specify + the number of queues for the controller, it should match the number + of vCPUs. A "usb" controller has an optional attribute <code>model</code>, which is one of "piix3-uhci", "piix4-uhci", "ehci", - "ich9-ehci1", "ich9-uhci1", "ich9-uhci2", "ich9-uhci3", - "vt82c686b-uhci", "pci-ohci" or "nec-xhci". Additionally, + "ich9-ehci1", "ich9-uhci1", "ich9-uhci2", "ich9-uhci3", "vt82c686b-uhci", + "pci-ohci" or "nec-xhci". Additionally, <span class="since">since 0.10.0</span>, if the USB bus needs to be explicitly disabled for the guest, <code>model='none'</code> may be used. The PowerPC64 "spapr-vio" addresses do not have an associated controller. diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 8d7e6db..089be6c 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -1407,6 +1407,11 @@ </attribute> </optional> <optional> + <attribute name="num_queues"> + <ref name="unsignedInt"/> + </attribute> + </optional> + <optional> <ref name="usbmaster"/> </optional> <optional> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index f3fca7f..e9d6b8b 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -4825,6 +4825,7 @@ virDomainControllerDefParseXML(xmlNodePtr node, char *type = NULL; char *idx = NULL; char *model = NULL; + char *num_queues = NULL; if (VIR_ALLOC(def) < 0) { virReportOOMError(); @@ -4860,6 +4861,14 @@ virDomainControllerDefParseXML(xmlNodePtr node, def->model = -1; } + if ((num_queues = virXMLPropString(node, "num_queues"))) { + if (virStrToLong_ui(num_queues, NULL, 10, &def->num_queues) < 0) { + virReportError(VIR_ERR_XML_ERROR, + _("Malformed 'num_queues' value '%s'"), num_queues); + goto error; + } + } + if (virDomainDeviceInfoParseXML(node, NULL, &def->info, flags) < 0) goto error; @@ -4937,6 +4946,7 @@ cleanup: VIR_FREE(type); VIR_FREE(idx); VIR_FREE(model); + VIR_FREE(num_queues); return def; @@ -13037,6 +13047,9 @@ virDomainControllerDefFormat(virBufferPtr buf, virBufferEscapeString(buf, " model='%s'", model); } + if (def->num_queues) + virBufferAsprintf(buf, " num_queues='%u'", def->num_queues); + switch (def->type) { case VIR_DOMAIN_CONTROLLER_TYPE_VIRTIO_SERIAL: if (def->opts.vioserial.ports != -1) { diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index edddf25..8e79961 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -728,6 +728,7 @@ struct _virDomainControllerDef { int type; int idx; int model; /* -1 == undef */ + unsigned int num_queues; union { virDomainVirtioSerialOpts vioserial; } opts; diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index a0c278f..bc7beff 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3530,6 +3530,14 @@ qemuBuildControllerDevStr(virDomainDefPtr domainDef, virBuffer buf = VIR_BUFFER_INITIALIZER; int model; + if (def->num_queues && + !(def->type == VIR_DOMAIN_CONTROLLER_TYPE_SCSI && + def->model == VIR_DOMAIN_CONTROLLER_MODEL_SCSI_VIRTIO_SCSI)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("'num_queues' is only supported by virtio-scsi controller")); + return NULL; + } + switch (def->type) { case VIR_DOMAIN_CONTROLLER_TYPE_SCSI: model = def->model; @@ -3613,6 +3621,9 @@ qemuBuildControllerDevStr(virDomainDefPtr domainDef, goto error; } + if (def->num_queues) + virBufferAsprintf(&buf, ",num_queues=%u", def->num_queues); + if (qemuBuildDeviceAddressStr(&buf, &def->info, qemuCaps) < 0) goto error; diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-virtio-scsi-num_queues.args b/tests/qemuxml2argvdata/qemuxml2argv-disk-virtio-scsi-num_queues.args new file mode 100644 index 0000000..8d46799 --- /dev/null +++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-virtio-scsi-num_queues.args @@ -0,0 +1,8 @@ +LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test \ +/usr/bin/qemu -S -M pc -m 214 -smp 8 -nographic -nodefconfig -nodefaults \ +-monitor unix:/tmp/test-monitor,server,nowait -no-acpi -boot c \ +-device virtio-scsi-pci,id=scsi0,num_queues=8,bus=pci.0,addr=0x3 \ +-usb \ +-drive file=/dev/HostVG/QEMUGuest1,if=none,id=drive-scsi0-0-0-0 \ +-device scsi-disk,bus=scsi0.0,channel=0,scsi-id=0,lun=0,drive=drive-scsi0-0-0-0,id=scsi0-0-0-0 \ +-device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x4 diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-virtio-scsi-num_queues.xml b/tests/qemuxml2argvdata/qemuxml2argv-disk-virtio-scsi-num_queues.xml new file mode 100644 index 0000000..dfa9cf1 --- /dev/null +++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-virtio-scsi-num_queues.xml @@ -0,0 +1,26 @@ +<domain type='qemu'> + <name>QEMUGuest1</name> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> + <memory unit='KiB'>219136</memory> + <currentMemory unit='KiB'>219136</currentMemory> + <vcpu placement='static'>8</vcpu> + <os> + <type arch='i686' machine='pc'>hvm</type> + <boot dev='hd'/> + </os> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <emulator>/usr/bin/qemu</emulator> + <disk type='block' device='disk'> + <source dev='/dev/HostVG/QEMUGuest1'/> + <target dev='sdb' bus='scsi'/> + <address type='drive' controller='0' bus='0' target='0' unit='0'/> + </disk> + <controller type='usb' index='0'/> + <controller type='scsi' index='0' model='virtio-scsi' num_queues='8'/> + <memballoon model='virtio'/> + </devices> +</domain> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 38787ac..055d935 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -550,6 +550,9 @@ mymain(void) DO_TEST("disk-scsi-virtio-scsi", QEMU_CAPS_DRIVE, QEMU_CAPS_DEVICE, QEMU_CAPS_NODEFCONFIG, QEMU_CAPS_VIRTIO_SCSI); + DO_TEST("disk-virtio-scsi-num_queues", + QEMU_CAPS_DRIVE, QEMU_CAPS_DEVICE, QEMU_CAPS_NODEFCONFIG, + QEMU_CAPS_VIRTIO_SCSI); DO_TEST("disk-scsi-megasas", QEMU_CAPS_DRIVE, QEMU_CAPS_DEVICE, QEMU_CAPS_NODEFCONFIG, QEMU_CAPS_SCSI_MEGASAS); diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index ba9aa96..e5056f1 100644 --- a/tests/qemuxml2xmltest.c +++ b/tests/qemuxml2xmltest.c @@ -179,6 +179,7 @@ mymain(void) DO_TEST("disk-scsi-device"); DO_TEST("disk-scsi-vscsi"); DO_TEST("disk-scsi-virtio-scsi"); + DO_TEST("disk-virtio-scsi-num_queues"); DO_TEST("disk-scsi-megasas"); DO_TEST_FULL("disk-mirror", false, WHEN_ACTIVE); DO_TEST_FULL("disk-mirror", true, WHEN_INACTIVE); -- 1.8.1.4

3 4

[libvirt] Release of libvirt-1.0.4
by Daniel Veillard 02 Apr '13

02 Apr '13

As planned I tagged the release in git and pushed the new version to the usual place as tarball and rpms: ftp://libvirt.org/libvirt/ I hesited a bit in pushing the patchset from Peter fixing the memory corruption bug, but since it seems hard to reproduce and the amount of change was a bit too large to push just before a release, I prefered delaying it until after 1.0.4 . This release is a bit smaller than usual at around 200 patches but that's not surprizing considering the shrter timeframe since 1.0.3. This includes an homogenous set of features, improvements and bug fixes, plus updates for localization of ukrainian (100%), japanese (100%), French (12%) and Gujarati (78%) Features: - qemu: support passthrough for iscsi disks (Paolo Bonzini) - various S390 improvements (Viktor Mihajlovski) - various LXC bugs fixes and improvements (Daniel P. Berrange, Gao feng) - Add API for thread cancellation (Daniel P. Berrange) Documentation: - Fix truncated sentence in RDP 'multiUser' attribute (Christophe Fergeau) - Remove the redundant parentheses in migrate help (Yanbing Du) - virsh: Fix docs for "virsh setmaxmem" (Peter Krempa) - util: fix virAllocVar's comment (Ján Tomko) - clarify virsh net commands (Gene Czarcinski) - storage: Fix grammar (Philipp Hahn) - Fix /pool/storage/name documentation (Christophe Fergeau) - Fix /pool/storage/directory@path documentation (Christophe Fergeau) - Fix snapshot-create-as syntax in help output (Martin Kletzander) - Update to COPYING.LIB to latest LGPLv2.1 copy (Christophe Fergeau) - Fix a copy & paste error for virsh dump help (Yanbing Du) - Clarify semantics of sparse storage volumes (Jiri Denemark) Portability: - virutil: Fix compilation on non-linux platforms (Michal Privoznik) - Fix linkage of virt-aa-helper with numa library (Daniel P. Berrange) - Don't fail if SELinux is diabled (Guido Günther) - Fix --without-libvirtd builds (Doug Goldstein) - lxc: include sys/stat.h (Guido Günther) - Ensure GET_VLAN_VID_CMD is always defined (Daniel P. Berrange) - Don't import loop.h unless HAVE_DECL_LO_FLAGS_AUTOCLEAR is defined (Daniel P. Berrange) Bug Fixes: - virsh: don't call virSecretFree on NULL (Ján Tomko) - storage: Avoid double virCommandFree in virStorageBackendLogicalDeletePool (Martin Kletzander) - nodedev: invert virIsCapableFCHost return value (Ján Tomko) - security_manager.c: Append seclabel iff generated (Michal Privoznik) - security: Don't add seclabel of type none if there's already a seclabel (Michal Privoznik) - security_manager: Don't manipulate domain XML in virDomainDefGetSecurityLabelDef (Michal Privoznik) - conf: fix memory leak of class_id bitmap (Guannan Ren) - uml:release config object when uml driver shutdown (Guannan Ren) - qemu:release qemu config object when qemu driver shutdown (Guannan Ren) - net: use newer iptables syntax (Stefan Seyfried) - remote: Don't call NULL closeFreeCallback (Viktor Mihajlovski) - rpc: Fix client crash when server drops connection (Jiri Denemark) - conf: fix a failure when detaching a usb device (Guannan Ren) - qemu: Don't set address type too early during virtio disk hotplug (Guido Günther) - virsh: error out on non-numeric timeout values (Ján Tomko) - qemu: Set migration FD blocking (Michal Privoznik) - util: Fix bug of managing vport (Osier Yang) - nodedev: Fix the improper logic when enumerating SRIOV VF (Osier Yang) - lxc: Prevent shutting down the host (Martin Kletzander) - Ensure root filesystem is mounted if a file/block mount. (Daniel P. Berrange) - Fix thread safety in LXC callback handling (Daniel P. Berrange) - Remove bogus filtering from virDomainGetRootFilesystem (Daniel P. Berrange) - Fix parsing of bond interface XML (Jim Fehlig) - virsh: don't print --(null) in vol-name and vol-pool (Ján Tomko) - Fix free of uninitialized value in LXC numad setup (Daniel P. Berrange) - Correct invalid RNG schemas (Martin Kletzander) - python: Fix emulatorpin API bindings (Peter Krempa) - qemu: Un-mark volume as mirrored/copied if blockjob copy fails (Peter Krempa) - Fix initialization of virIdentityPtr thread locals (Daniel P. Berrange) - qemu: Add the new disk src into shared disk table when updating disk (Osier Yang) - python: fix bindings that don't raise an exception (Guannan Ren) - Fix typos s/HAVE_SELINUX/WITH_SELINUX/ (Daniel P. Berrange) - fix TLS error with virNetServerClientCreateIdentity (Olivia Yin) - storage: fix unlikely memory leak in rbd backend (Laine Stump) - Do not prematurely close loop devices in LXC controller (Daniel P. Berrange) - qemu: Fix startupPolicy regression (Jiri Denemark) - qemu: do not support non-network disks without -drive (Paolo Bonzini) - Fix size probing for VDI images (Ján Tomko) - Fix memory leak on OOM in virSecuritySELinuxMCSFind (Daniel P. Berrange) - Avoid closing uninitialized FDs when LXC startup fails (Daniel P. Berrange) - Prevent streams from becoming libvirtd controlling TTY (Daniel P. Berrange) - util: escapes special characters in VIR_LOG_REGEX (Guannan Ren) - Daemonize fuse thread in libvirt_lxc (Daniel P. Berrange) - Fix missing error dispatch in virDomainLxcEnterNamespace (Daniel P. Berrange) - Fix query of LXC security label (Daniel P. Berrange) - qemu_driver: Try KVM_CAP_MAX_VCPUS only if defined (Michal Privoznik) - Add missing break in LXC loop device setup (Daniel P. Berrange) - qemu: Avoid NULL dereference in qemuSharedDiskEntryFree (Jiri Denemark) - qemu: Fix retrieval of maximum number of vCPUs on KVM hosts (Peter Krempa) - virsh: fix snapshot-create with no xmlfile (Ján Tomko) - lxc: Init activeUsbHostdevs (Guido Günther) - bandwidth: Require network QoS if interface uses 'floor' (Michal Privoznik) - qemuDomainBlockStatsFlags: Guard disk lookup with a domain job (Michal Privoznik) - Fix crash parsing RNG device specification (Daniel P. Berrange) - Resolve valgrind error (John Ferlan) - storage: Cleanup logical volume creation code (Jiri Denemark) - qemu: update domain live xml for virsh memtune with --live flag (Guannan Ren) - util: fix a integer boundary error (Guannan Ren) Improvements: - util: Fix the conflict type for virIsCapableFCHost (Osier Yang) - libvirt_private.syms: Correctly export seclabel APIs (Michal Privoznik) - log: Separate thread ID from timestemp in ring buffer (Jiri Denemark) - virsh: Correct DESCRIPTION for virsh help blockcopy (Yanbing Du) - Fix virConnectOpen.*() name requirements (Martin Kletzander) - virsh: Let the compiler check usage of all fields in vshCmdOptType enum (Peter Krempa) - python: set default value to optional arguments (Guannan Ren) - libvirt-guests: newline between output sentences (Eric Blake) - nodedev: Abstract nodeDeviceVportCreateDelete as util function (Osier Yang) - nodedev: Dump max vports and vports in use for HBA's XML (Osier Yang) - nodedev: Refactor the helpers (Osier Yang) - nodedev: Use access instead of stat (Osier Yang) - util: Add one helper virReadFCHost to read the value of fc_host entry (Osier Yang) - nodedev: Introduce two new flags for listAll API (Osier Yang) - nodedev: Remove the unused enum (Osier Yang) - Mount temporary devpts on /var/lib/libvirt/lxc/$NAME.devpts (Daniel P. Berrange) - Move FUSE mount to /var/lib/libvirt/lxc/$NAME.fuse (Daniel P. Berrange) - viralloc: Export virAllocTest* (Michal Privoznik) - qemu: add support for LSI MegaRAID SAS1078 (aka megasas) SCSI controller (Paolo Bonzini) - qemu: pass iscsi authorization credentials (Paolo Bonzini) - domain: parse XML for iscsi authorization credentials (Paolo Bonzini) - secret: add iscsi to possible usage types (Paolo Bonzini) - domain: make port optional for network disks (Paolo Bonzini) - qemu: add support for libiscsi (Paolo Bonzini) - make: regenerate bindings when <classname>.py changes (Guannan Ren) - python: treat flags as default argument with value 0 (Guannan Ren) - virsh-snapshot: Simplify cleanup path in cmdSnapshotEdit (Peter Krempa) - virsh-snapshot: Use the mutually exclusive params macro in cmdSnapshotEdit (Peter Krempa) - virsh-snapshot: Refactor cmdSnapshotCurrent (Peter Krempa) - virsh-domain: Fix flag name in error message to match the check (Peter Krempa) - virsh-host: Refactor cmdFreecell (Peter Krempa) - virsh-snapshot: Refactor virsh snapshot-list (Peter Krempa) - virsh: Introduce macros to reject mutually exclusive arguments (Peter Krempa) - qemu: s/VIR_ERR_NO_SUPPORT/VIR_ERR_OPERATION_UNSUPPORTED (Michal Privoznik) - domain: add support for iscsi network disks (Paolo Bonzini) - cgroup: export virCgroupRemoveRecursively (Gao feng) - doc/schema: disk storage volume formats (Philipp Hahn) - doc/schema: Support iqn for storage pools (Philipp Hahn) - doc/schema: add ocfs2 for disk vol (Philipp Hahn) - LXC: add cpuset cgroup support for lxc (Gao feng) - NUMA: cleanup for numa related codes (Gao feng) - LXC: allow uses advisory nodeset from querying numad (Gao feng) - rename qemuGetNumadAdvice to virNumaGetAutoPlacementAdvice (Gao feng) - selinux: deal with dtb file (Olivia Yin) - qemu: add dtb option support (Olivia Yin) - conf: support <dtb> tag in XML domain file (Olivia Yin) - rename tests/conftest.c (Gene Czarcinski) - Setup LXC cgroups in two phases (Daniel P. Berrange) - Set the current client identity during API call dispatch (Daniel P. Berrange) - Add ability to get a virIdentity from a virNetServerClientPtr (Daniel P. Berrange) - Add API to get the system identity (Daniel P. Berrange) - Add APIs for associating a virIdentityPtr with the current thread (Daniel P. Berrange) - Define internal APIs for managing identities (Daniel P. Berrange) - Add APIs to get at more client security data (Daniel P. Berrange) - qemu: support URI syntax for NBD (Paolo Bonzini) - qemu: support NBD with Unix sockets (Paolo Bonzini) - qemu: support named nbd exports (Paolo Bonzini) - qemu: rewrite NBD command-line builder and parser (Paolo Bonzini) - qemu: test NBD command-line builder and parser (Paolo Bonzini) - util: portably check for unchanged uid (Eric Blake) - Make vshDebug work when parsing parameters (Martin Kletzander) - Remove contiguous CPU indexes assumption (Li Zhang) - audit: Audit resources used by VirtIO RNG (Peter Krempa) - S390: Testcases for virtio-scsi and virtio-rng (Viktor Mihajlovski) - S390: Enable virtio-scsi and virtio-rng (Viktor Mihajlovski) - qemu: Rename virtio-scsi capability (Viktor Mihajlovski) - util: fix clear_emulator_capabilities=0 (Laine Stump) - Fix deps for generating RPC dispatch code (Daniel P. Berrange) - Fix generation of systemtap probes for RPC protocols (Daniel P. Berrange) - Re-add DTrace probes on 'dispose' functions (Daniel P. Berrange) - Fix parsing of SELinux ranges without a category (Daniel P. Berrange) - Separate MCS range parsing from MCS range checking (Daniel P. Berrange) - virtio-rng: Add rate limiting options for virtio-RNG (Peter Krempa) - S390: Testcases for virtio-ccw machines (Viktor Mihajlovski) - S390: Add hotplug support for s390 virtio devices (J.B. Joret) - S390: QEMU driver support for CCW addresses (Viktor Mihajlovski) - S390: domain_conf support for CCW (Viktor Mihajlovski) - S390: Documentation for CCW address type (Viktor Mihajlovski) - Use separate symbol file for GNUTLS symbols (Daniel P. Berrange) - Apply security label when entering LXC namespaces (Daniel P. Berrange) - virCaps: conf: start splitting out irrelevat data (Peter Krempa) - Remove hack using existance of an 'identity' string to disable auth (Daniel P. Berrange) - Convert HAVE_SELINUX to WITH_SELINUX (Guido Günther) - capabilities: add NUMA memory information (Dusty Mabe) - apparmor: use AppArmorSetFDLabel for both imageFD and tapFD (Guannan Ren) - Include pid namespace inode in LXC audit messages (Daniel P. Berrange) - Add support for disks backed by plain files in LXC (Daniel P. Berrange) - Refactor loop device setup code in LXC (Daniel P. Berrange) - Convert QEMU driver to use virLogProbablyLogMessage (Daniel P. Berrange) - Improve LXC startup error reporting (Daniel P. Berrange) - Add method for checking if a string is (probably) a log message (Daniel P. Berrange) - Use VIR_MASS_CLOSE in LXC container startup (Daniel P. Berrange) - Fix conditional build of virNetDevSetupControlFull (Daniel P. Berrange) - Rename 'daemon' param to 'binary' in virNetClientNewUNIX (Daniel P. Berrange) - Rename 'clone' to 'clonevol' to avoid name clash with clone() syscall (Daniel P. Berrange) - viralloc: use consistent naming (Eric Blake) - rng: allow default device in RNG grammar (Eric Blake) - build: avoid shadowing a function name (Eric Blake) - conf: Report errors on cputune parameter parsing (Peter Krempa) - conf: Make virDomainDeviceInfoIterate usable without os type (Peter Krempa) - virsh-snapshot: Add ability to print only snapshot names (Peter Krempa) Cleanups: - python:remove semicolon in python code (Guannan Ren) - Clean redundant code about VCPU string checking (Li Zhang) - Cleanup useless flags specifications (Martin Kletzander) - nodeinfo: don't define nodeGetCellMemory if it isn't ever used (Hu Tao) - virsh-domain: Remove unused vshCompleteXMLFromDomain (Peter Krempa) - sheepdog: Adjust logic to break while loop to avoid Coverity error (John Ferlan) - libxl_driver: Resolve Coverity errors (John Ferlan) - libxl_conf: Resolve Coverity issue with call to regcomp() (John Ferlan) - conf: whitespace cleanups and refactors with no semantic impact (Peter Krempa) thanks everybody for your contributions for this release ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

4 10

[libvirt] [PATCH] virsh: Add a helper to parse cpulist
by Osier Yang 02 Apr '13

02 Apr '13

vcpupin and emulatorpin use same code to parse the cpulist, this abstracts the same code as a helper. Along with various code style fixes, and error improvement (only error "Physical CPU %d doesn't exist" if the specified CPU exceed the range, no "cpulist: Invalid format", see the following for an example of the error prior to this patch). % virsh vcpupin 4 0 0-8 error: Physical CPU 4 doesn't exist. error: cpulist: Invalid format. --- tools/virsh-domain.c | 278 ++++++++++++++++++++------------------------------- 1 file changed, 106 insertions(+), 172 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index d1e6f9d..0fe2a51 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -5460,6 +5460,97 @@ vshPrintPinInfo(unsigned char *cpumaps, size_t cpumaplen, return true; } +static unsigned char * +virParseCPUList(vshControl *ctl, const char *cpulist, + int maxcpu, size_t cpumaplen) +{ + unsigned char *cpumap = NULL; + const char *cur; + bool unuse = false; + int i, cpu, lastcpu; + + cpumap = vshCalloc(ctl, cpumaplen, sizeof(*cpumap)); + + /* Parse cpulist */ + cur = cpulist; + if (*cur == 'r') { + for (cpu = 0; cpu < maxcpu; cpu++) + VIR_USE_CPU(cpumap, cpu); + return cpumap; + } else if (*cur == 0) { + goto error; + } + + while (*cur != 0) { + /* The char '^' denotes exclusive */ + if (*cur == '^') { + cur++; + unuse = true; + } + + /* Parse physical CPU number */ + if (!c_isdigit(*cur)) + goto error; + + if ((cpu = virParseNumber(&cur)) < 0) + goto error; + + if (cpu >= maxcpu) { + vshError(ctl, _("Physical CPU %d doesn't exist."), cpu); + goto cleanup; + } + + virSkipSpaces(&cur); + + if (*cur == ',' || *cur == 0) { + if (unuse) + VIR_UNUSE_CPU(cpumap, cpu); + else + VIR_USE_CPU(cpumap, cpu); + } else if (*cur == '-') { + /* The char '-' denotes range */ + if (unuse) + goto error; + cur++; + virSkipSpaces(&cur); + + /* Parse the end of range */ + lastcpu = virParseNumber(&cur); + + if (lastcpu < cpu) + goto error; + + if (lastcpu >= maxcpu) { + vshError(ctl, _("Physical CPU %d doesn't exist."), maxcpu); + goto cleanup; + } + + for (i = cpu; i <= lastcpu; i++) + VIR_USE_CPU(cpumap, i); + + virSkipSpaces(&cur); + } + + if (*cur == ',') { + cur++; + virSkipSpaces(&cur); + unuse = false; + } else if (*cur == 0) { + break; + } else { + goto error; + } + } + + return cpumap; + +error: + vshError(ctl, "%s", _("cpulist: Invalid format.")); +cleanup: + VIR_FREE(cpumap); + return NULL; +} + static bool cmdVcpuPin(vshControl *ctl, const vshCmd *cmd) { @@ -5467,13 +5558,11 @@ cmdVcpuPin(vshControl *ctl, const vshCmd *cmd) virDomainPtr dom; int vcpu = -1; const char *cpulist = NULL; - bool ret = true; + bool ret = false; unsigned char *cpumap = NULL; unsigned char *cpumaps = NULL; size_t cpumaplen; - int i, cpu, lastcpu, maxcpu, ncpus; - bool unuse = false; - const char *cur; + int i, maxcpu, ncpus; bool config = vshCommandOptBool(cmd, "config"); bool live = vshCommandOptBool(cmd, "live"); bool current = vshCommandOptBool(cmd, "current"); @@ -5545,7 +5634,6 @@ cmdVcpuPin(vshControl *ctl, const vshCmd *cmd) vshPrint(ctl, "%s %s\n", _("VCPU:"), _("CPU Affinity")); vshPrint(ctl, "----------------------------------\n"); for (i = 0; i < ncpus; i++) { - if (vcpu != -1 && i != vcpu) continue; @@ -5556,105 +5644,28 @@ cmdVcpuPin(vshControl *ctl, const vshCmd *cmd) break; } - } else { - ret = false; } VIR_FREE(cpumaps); goto cleanup; } /* Pin mode: pinning specified vcpu to specified physical cpus*/ - - cpumap = vshCalloc(ctl, cpumaplen, sizeof(*cpumap)); - /* Parse cpulist */ - cur = cpulist; - if (*cur == 0) { - goto parse_error; - } else if (*cur == 'r') { - for (cpu = 0; cpu < maxcpu; cpu++) - VIR_USE_CPU(cpumap, cpu); - cur = ""; - } - - while (*cur != 0) { - - /* the char '^' denotes exclusive */ - if (*cur == '^') { - cur++; - unuse = true; - } - - /* parse physical CPU number */ - if (!c_isdigit(*cur)) - goto parse_error; - cpu = virParseNumber(&cur); - if (cpu < 0) { - goto parse_error; - } - if (cpu >= maxcpu) { - vshError(ctl, _("Physical CPU %d doesn't exist."), cpu); - goto parse_error; - } - virSkipSpaces(&cur); - - if (*cur == ',' || *cur == 0) { - if (unuse) { - VIR_UNUSE_CPU(cpumap, cpu); - } else { - VIR_USE_CPU(cpumap, cpu); - } - } else if (*cur == '-') { - /* the char '-' denotes range */ - if (unuse) { - goto parse_error; - } - cur++; - virSkipSpaces(&cur); - /* parse the end of range */ - lastcpu = virParseNumber(&cur); - if (lastcpu < cpu) { - goto parse_error; - } - if (lastcpu >= maxcpu) { - vshError(ctl, _("Physical CPU %d doesn't exist."), maxcpu); - goto parse_error; - } - for (i = cpu; i <= lastcpu; i++) { - VIR_USE_CPU(cpumap, i); - } - virSkipSpaces(&cur); - } - - if (*cur == ',') { - cur++; - virSkipSpaces(&cur); - unuse = false; - } else if (*cur == 0) { - break; - } else { - goto parse_error; - } - } + if (!(cpumap = virParseCPUList(ctl, cpulist, maxcpu, cpumaplen))) + goto cleanup; if (flags == -1) { - if (virDomainPinVcpu(dom, vcpu, cpumap, cpumaplen) != 0) { - ret = false; - } + if (virDomainPinVcpu(dom, vcpu, cpumap, cpumaplen) != 0) + goto cleanup; } else { - if (virDomainPinVcpuFlags(dom, vcpu, cpumap, cpumaplen, flags) != 0) { - ret = false; - } + if (virDomainPinVcpuFlags(dom, vcpu, cpumap, cpumaplen, flags) != 0) + goto cleanup; } + ret = true; cleanup: VIR_FREE(cpumap); virDomainFree(dom); return ret; - -parse_error: - vshError(ctl, "%s", _("cpulist: Invalid format.")); - ret = false; - goto cleanup; } /* @@ -5701,13 +5712,11 @@ cmdEmulatorPin(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom; const char *cpulist = NULL; - bool ret = true; + bool ret = false; unsigned char *cpumap = NULL; unsigned char *cpumaps = NULL; size_t cpumaplen; - int i, cpu, lastcpu, maxcpu; - bool unuse = false; - const char *cur; + int maxcpu; bool config = vshCommandOptBool(cmd, "config"); bool live = vshCommandOptBool(cmd, "live"); bool current = vshCommandOptBool(cmd, "current"); @@ -5761,101 +5770,26 @@ cmdEmulatorPin(vshControl *ctl, const vshCmd *cmd) vshPrint(ctl, " *: "); ret = vshPrintPinInfo(cpumaps, cpumaplen, maxcpu, 0); vshPrint(ctl, "\n"); - } else { - ret = false; } VIR_FREE(cpumaps); goto cleanup; } /* Pin mode: pinning emulator threads to specified physical cpus*/ - - cpumap = vshCalloc(ctl, cpumaplen, sizeof(*cpumap)); - /* Parse cpulist */ - cur = cpulist; - if (*cur == 0) { - goto parse_error; - } else if (*cur == 'r') { - for (cpu = 0; cpu < maxcpu; cpu++) - VIR_USE_CPU(cpumap, cpu); - cur = ""; - } - - while (*cur != 0) { - - /* the char '^' denotes exclusive */ - if (*cur == '^') { - cur++; - unuse = true; - } - - /* parse physical CPU number */ - if (!c_isdigit(*cur)) - goto parse_error; - cpu = virParseNumber(&cur); - if (cpu < 0) { - goto parse_error; - } - if (cpu >= maxcpu) { - vshError(ctl, _("Physical CPU %d doesn't exist."), cpu); - goto parse_error; - } - virSkipSpaces(&cur); - - if (*cur == ',' || *cur == 0) { - if (unuse) { - VIR_UNUSE_CPU(cpumap, cpu); - } else { - VIR_USE_CPU(cpumap, cpu); - } - } else if (*cur == '-') { - /* the char '-' denotes range */ - if (unuse) { - goto parse_error; - } - cur++; - virSkipSpaces(&cur); - /* parse the end of range */ - lastcpu = virParseNumber(&cur); - if (lastcpu < cpu) { - goto parse_error; - } - if (lastcpu >= maxcpu) { - vshError(ctl, _("Physical CPU %d doesn't exist."), maxcpu); - goto parse_error; - } - for (i = cpu; i <= lastcpu; i++) { - VIR_USE_CPU(cpumap, i); - } - virSkipSpaces(&cur); - } - - if (*cur == ',') { - cur++; - virSkipSpaces(&cur); - unuse = false; - } else if (*cur == 0) { - break; - } else { - goto parse_error; - } - } + if (!(cpumap = virParseCPUList(ctl, cpulist, maxcpu, cpumaplen))) + goto cleanup; if (flags == -1) flags = VIR_DOMAIN_AFFECT_LIVE; if (virDomainPinEmulator(dom, cpumap, cpumaplen, flags) != 0) - ret = false; + goto cleanup; + ret = true; cleanup: VIR_FREE(cpumap); virDomainFree(dom); return ret; - -parse_error: - vshError(ctl, "%s", _("cpulist: Invalid format.")); - ret = false; - goto cleanup; } /* -- 1.8.1.4

3 5

[libvirt] [PATCH] Resolve valgrind failure
by John Ferlan 02 Apr '13

02 Apr '13

Code added by commit id '523207fe8' TEST: qemuxml2argvtest ........................................ 40 ........................................ 80 ........................................ 120 ........................................ 160 ........................................ 200 ........................................ 240 ................................. 273 OK ==30993== 39 bytes in 1 blocks are definitely lost in loss record 33 of 87 ==30993== at 0x4A0887C: malloc (vg_replace_malloc.c:270) ==30993== by 0x41E501: fakeSecretGetValue (qemuxml2argvtest.c:33) ==30993== by 0x427591: qemuBuildDriveURIString (qemu_command.c:2571) ==30993== by 0x42C502: qemuBuildDriveStr (qemu_command.c:2627) ==30993== by 0x4335FC: qemuBuildCommandLine (qemu_command.c:6443) ==30993== by 0x41E8A0: testCompareXMLToArgvHelper (qemuxml2argvtest.c:154 ==30993== by 0x41FE8F: virtTestRun (testutils.c:157) ==30993== by 0x418BE3: mymain (qemuxml2argvtest.c:506) ==30993== by 0x4204CA: virtTestMain (testutils.c:719) ==30993== by 0x38D6821A04: (below main) (in /usr/lib64/libc-2.16.so) ==30993== ==30993== 46 bytes in 1 blocks are definitely lost in loss record 64 of 87 ==30993== at 0x4A0887C: malloc (vg_replace_malloc.c:270) ==30993== by 0x38D690A167: __vasprintf_chk (in /usr/lib64/libc-2.16.so) ==30993== by 0x4CB28E7: virVasprintf (stdio2.h:210) ==30993== by 0x4CB29A3: virAsprintf (virutil.c:2017) ==30993== by 0x4275B4: qemuBuildDriveURIString (qemu_command.c:2580) ==30993== by 0x42C502: qemuBuildDriveStr (qemu_command.c:2627) ==30993== by 0x4335FC: qemuBuildCommandLine (qemu_command.c:6443) ==30993== by 0x41E8A0: testCompareXMLToArgvHelper (qemuxml2argvtest.c:154 ==30993== by 0x41FE8F: virtTestRun (testutils.c:157) ==30993== by 0x418BE3: mymain (qemuxml2argvtest.c:506) ==30993== by 0x4204CA: virtTestMain (testutils.c:719) ==30993== by 0x38D6821A04: (below main) (in /usr/lib64/libc-2.16.so) ==30993== ==30993== 385 (56 direct, 329 indirect) bytes in 1 blocks are definitely los ==30993== at 0x4A06B6F: calloc (vg_replace_malloc.c:593) ==30993== by 0x4C6B2CF: virAllocN (viralloc.c:152) ==30993== by 0x4C9C7EB: virObjectNew (virobject.c:191) ==30993== by 0x4D21810: virGetSecret (datatypes.c:642) ==30993== by 0x41E5D5: fakeSecretLookupByUsage (qemuxml2argvtest.c:51) ==30993== by 0x4D4BEC5: virSecretLookupByUsage (libvirt.c:15295) ==30993== by 0x4276A9: qemuBuildDriveURIString (qemu_command.c:2565) ==30993== by 0x42C502: qemuBuildDriveStr (qemu_command.c:2627) ==30993== by 0x4335FC: qemuBuildCommandLine (qemu_command.c:6443) ==30993== by 0x41E8A0: testCompareXMLToArgvHelper (qemuxml2argvtest.c:154 ==30993== by 0x41FE8F: virtTestRun (testutils.c:157) ==30993== by 0x418BE3: mymain (qemuxml2argvtest.c:506) ==30993== PASS: qemuxml2argvtest Interesting side note is that running the test singularly via 'make -C tests check TESTS=qemuxml2argvtest' didn't trip the valgrind error; however, running during 'make -C tests valgrind' did cause the error to be seen. --- src/qemu/qemu_command.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index a0c278f..0f6a5a1 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -2604,6 +2604,9 @@ cleanup: VIR_FREE(tmpscheme); VIR_FREE(volimg); VIR_FREE(sock); + virObjectUnref(sec); + VIR_FREE(secret); + VIR_FREE(user); return ret; -- 1.8.1.4

2 2

[libvirt] [PATCHv5 00/11] Introduce driver specific XML parsing callbacks
by Peter Krempa 01 Apr '13

01 Apr '13

This series now splits out everything unrelated from the virCaps object. See notes in individual patches for change summary. This series now contains 2 renaming patches that were suggested by Eric and Laine. Peter Krempa (11): conf: Add post XML parse callbacks and prepare for cleaning of virCaps conf callback: Rearrange function parameters qemu: Record the default NIC model in the domain XML virCaps: get rid of "defaultInitPath" value in the virCaps struct virCaps: get rid of defaultDiskDriverName virCaps: get rid of emulatorRequired virCaps: get rid of defaultDiskDriverType virCaps: get rid of hasWideScsiBus virCaps: get rid of macPrefix field virCaps: get rid of defaultConsoleTargetType callback maint: Rename xmlconf to xmlopt and virDomainXMLConfing to virDomainXMLOption src/conf/capabilities.c | 24 - src/conf/capabilities.h | 23 - src/conf/domain_conf.c | 658 ++++++++++++--------- src/conf/domain_conf.h | 103 ++-- src/conf/snapshot_conf.c | 4 +- src/conf/snapshot_conf.h | 2 +- src/esx/esx_driver.c | 32 +- src/esx/esx_private.h | 2 +- src/libvirt_private.syms | 10 +- src/libvirt_vmx.syms | 1 + src/libxl/libxl_conf.c | 13 - src/libxl/libxl_conf.h | 2 +- src/libxl/libxl_driver.c | 101 ++-- src/lxc/lxc_conf.c | 21 +- src/lxc/lxc_conf.h | 4 +- src/lxc/lxc_controller.c | 10 +- src/lxc/lxc_domain.c | 34 ++ src/lxc/lxc_domain.h | 1 + src/lxc/lxc_driver.c | 71 ++- src/lxc/lxc_process.c | 8 +- src/openvz/openvz_conf.c | 16 +- src/openvz/openvz_conf.h | 2 +- src/openvz/openvz_driver.c | 64 +- src/parallels/parallels_driver.c | 37 +- src/parallels/parallels_utils.h | 2 +- src/phyp/phyp_driver.c | 24 +- src/phyp/phyp_driver.h | 2 +- src/qemu/qemu_capabilities.c | 19 - src/qemu/qemu_command.c | 27 +- src/qemu/qemu_command.h | 6 +- src/qemu/qemu_conf.c | 16 +- src/qemu/qemu_conf.h | 5 +- src/qemu/qemu_domain.c | 98 ++- src/qemu/qemu_domain.h | 1 + src/qemu/qemu_driver.c | 147 +++-- src/qemu/qemu_migration.c | 21 +- src/qemu/qemu_process.c | 34 +- src/security/virt-aa-helper.c | 19 +- src/test/test_driver.c | 69 +-- src/uml/uml_conf.c | 9 - src/uml/uml_conf.h | 2 +- src/uml/uml_driver.c | 69 ++- src/vbox/vbox_tmpl.c | 33 +- src/vmware/vmware_conf.c | 21 +- src/vmware/vmware_conf.h | 2 +- src/vmware/vmware_driver.c | 24 +- src/vmx/vmx.c | 39 +- src/vmx/vmx.h | 12 +- src/xen/xen_driver.c | 37 +- src/xen/xen_driver.h | 4 +- src/xen/xen_hypervisor.c | 13 - src/xen/xend_internal.c | 20 +- src/xen/xm_internal.c | 16 +- src/xenapi/xenapi_driver.c | 40 +- src/xenapi/xenapi_driver_private.h | 2 +- tests/domainsnapshotxml2xmltest.c | 6 +- tests/lxcxml2xmldata/lxc-hostdev.xml | 1 + tests/lxcxml2xmldata/lxc-systemd.xml | 1 + tests/lxcxml2xmltest.c | 8 +- tests/qemuargv2xmltest.c | 6 +- tests/qemumonitorjsontest.c | 28 +- tests/qemumonitortestutils.c | 4 +- tests/qemumonitortestutils.h | 2 +- ...qemuxml2argv-disk-drive-network-nbd-export.args | 3 +- .../qemuxml2argv-disk-drive-network-nbd-export.xml | 1 + ...ml2argv-disk-drive-network-nbd-ipv6-export.args | 3 +- ...xml2argv-disk-drive-network-nbd-ipv6-export.xml | 1 + .../qemuxml2argv-disk-drive-network-nbd-ipv6.args | 3 +- .../qemuxml2argv-disk-drive-network-nbd-ipv6.xml | 1 + .../qemuxml2argv-disk-drive-network-nbd-unix.args | 3 +- .../qemuxml2argv-disk-drive-network-nbd-unix.xml | 1 + .../qemuxml2argv-disk-drive-network-nbd.args | 5 +- .../qemuxml2argv-disk-drive-network-nbd.xml | 1 + .../qemuxml2argv-disk-drive-network-rbd-auth.args | 2 +- .../qemuxml2argv-disk-drive-network-rbd-ipv6.args | 2 +- .../qemuxml2argv-disk-drive-network-rbd-ipv6.xml | 1 + .../qemuxml2argv-disk-drive-network-rbd.args | 2 +- .../qemuxml2argv-disk-drive-network-rbd.xml | 1 + .../qemuxml2argv-disk-drive-network-sheepdog.args | 3 +- .../qemuxml2argv-disk-drive-network-sheepdog.xml | 1 + .../qemuxml2argv-net-bandwidth.xml | 1 + .../qemuxml2argvdata/qemuxml2argv-net-client.args | 4 +- .../qemuxml2argv-net-eth-ifname.args | 4 +- .../qemuxml2argv-net-eth-ifname.xml | 1 + .../qemuxml2argv-net-eth-names.args | 8 +- tests/qemuxml2argvdata/qemuxml2argv-net-eth.args | 4 +- tests/qemuxml2argvdata/qemuxml2argv-net-eth.xml | 1 + .../qemuxml2argvdata/qemuxml2argv-net-hostdev.xml | 1 + tests/qemuxml2argvdata/qemuxml2argv-net-mcast.args | 4 +- .../qemuxml2argv-net-openvswitch.xml | 1 + .../qemuxml2argvdata/qemuxml2argv-net-server.args | 4 +- tests/qemuxml2argvdata/qemuxml2argv-net-user.args | 3 +- tests/qemuxml2argvdata/qemuxml2argv-net-user.xml | 1 + .../qemuxml2argv-net-virtio-network-portgroup.xml | 2 + tests/qemuxml2argvtest.c | 6 +- .../qemuxml2xmlout-graphics-spice-timeout.xml | 1 + tests/qemuxml2xmltest.c | 6 +- tests/qemuxmlnstest.c | 6 +- tests/securityselinuxlabeltest.c | 6 +- tests/testutilslxc.c | 9 - tests/testutilsqemu.c | 11 - tests/testutilsqemu.h | 2 +- tests/testutilsxen.c | 16 - tests/testutilsxen.h | 2 - tests/vmx2xmltest.c | 17 +- tests/xmconfigtest.c | 8 +- tests/xml2sexprtest.c | 9 +- tests/xml2vmxtest.c | 19 +- 108 files changed, 1273 insertions(+), 1050 deletions(-) -- 1.8.1.5

2 13

[libvirt] [PATCH v2] test: Return Libvirt logo as domain screenshot
by Michal Privoznik 01 Apr '13

01 Apr '13

This is just a bare Easter Egg. Whenever user run virDomainScreenshot over a domain in test driver, he'll get the Libvirt PNG logo in return. --- docs/Makefile.am | 1 + src/test/test_driver.c | 24 ++++++++++++++++++++++++ 2 files changed, 25 insertions(+) diff --git a/docs/Makefile.am b/docs/Makefile.am index 7583772..b5d7575 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -287,6 +287,7 @@ install-data-local: for file in $(devhelphtml) $(devhelppng) $(devhelpcss); do \ $(INSTALL) -m 0644 $(srcdir)/$${file} $(DESTDIR)$(DEVHELP_DIR) ; \ done + $(INSTALL_DATA) $(srcdir)/../docs/libvirtLogo.png $(DESTDIR)$(pkgdatadir) uninstall-local: for h in $(apihtml); do rm $(DESTDIR)$(HTML_DIR)/$$h; done diff --git a/src/test/test_driver.c b/src/test/test_driver.c index c5fffb9..4dbd775 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -39,11 +39,13 @@ #include "virutil.h" #include "viruuid.h" #include "capabilities.h" +#include "configmake.h" #include "viralloc.h" #include "network_conf.h" #include "interface_conf.h" #include "domain_conf.h" #include "domain_event.h" +#include "fdstream.h" #include "storage_conf.h" #include "node_device_conf.h" #include "virxml.h" @@ -5773,6 +5775,27 @@ cleanup: return ret; } +static char * +testDomainScreenshot(virDomainPtr dom ATTRIBUTE_UNUSED, + virStreamPtr st, + unsigned int screen ATTRIBUTE_UNUSED, + unsigned int flags) +{ + char *ret = NULL; + + virCheckFlags(0, NULL); + + if (!(ret = strdup("image/png"))) { + virReportOOMError(); + return NULL; + } + + if (virFDStreamOpenFile(st, PKGDATADIR "/libvirtLogo.png", 0, 0, O_RDONLY < 0)) + VIR_FREE(ret); + + return ret; +} + static virDriver testDriver = { .no = VIR_DRV_TEST, @@ -5843,6 +5866,7 @@ static virDriver testDriver = { .domainEventDeregisterAny = testDomainEventDeregisterAny, /* 0.8.0 */ .isAlive = testIsAlive, /* 0.9.8 */ .nodeGetCPUMap = testNodeGetCPUMap, /* 1.0.0 */ + .domainScreenshot = testDomainScreenshot, /* 1.0.5 */ }; static virNetworkDriver testNetworkDriver = { -- 1.8.1.5

2 1

[libvirt] The problems of default settings
by Li Zhang 01 Apr '13

01 Apr '13

Hi all, I am recently considering about the default setting for different platforms. Currently, there is no good way to fix the default setting for PPC64 platform. For example, we prefer pseries on PPC64 as the default machine type users don't need to specify it. I am thinking about the solutions. 1. One solution I am thinking about is to create template xml files for different platforms. But if users give their own configuration XML files, how to keep the preferred configurations in domain definition. I think this solution should be better in management tools, for example, ovirt or openstack. After management tools can generate its own configuration files with different default settings, libvirt can help create according to XML files. 2. Another solution is to use hook in libvirt. But it seems that we need to use hook daemon. Is it complex to use? I am not familiar with hook. Any suggestion is appreciated. Thanks. :) --Li

2 1

[libvirt] migrate qemu domains
by Yin Olivia-R63875 01 Apr '13

01 Apr '13

Hi, I tried to migrate qemu domains between same two Freescale PPC platforms. 1) Migrate test domain from Host1(10.193.20.109) to Host2(10.193.20.181). root@ppc-host1:~# virsh migrate test qemu+tls://10.193.20.181/system or root@ppc-host2:~# virsh -c qemu+tls://10.193.20.109/system migrate test qemu:///system I waited for a while and finally got error message as below: error: Unable to read from monitor: Connection reset by peer Exactly, when waiting (I guess during migration), the migrated domain is pasued on both source and destination nodes. root@ppc-host1:~# virsh -c qemu:///system list --all Id Name State ---------------------------------------------------- 5 test paused And meanwhile, the destination domain is also paused when waiting root@ppc-host2:~# virsh -c qemu:///system list --all Id Name State ---------------------------------------------------- 2 test paused Finally, the migrated domain on source node is shut off. root@ppc-host1:~# virsh -c qemu:///system list --all Id Name State ---------------------------------------------------- - test shut off But can't find any domain on destination node any longer. root@ppc-host2:~# virsh -c qemu:///system list --all Id Name State ---------------------------------------------------- As I know qemu-system-ppc doesn't support live migration on Freescale PPC platform yet. My question is whether it depends on qemu implementation to migrate qemu hypervisor with libvirt? >From the above experiment, it seemed that migration happened but not succeeded finally. Best Regards, Olivia

2 2

[libvirt] [PATCHv4 0/9] Introduce driver specific callbacks and get rid of irrelevant data in virCaps
by Peter Krempa 31 Mar '13

31 Mar '13

This series now splits out almost everything from the virCaps object (except for the defaultConsoleTargetType callback that I will post later as It requires more tweaking). See notes in individual patches for change summary. Peter Krempa (9): conf: Add post XML parse callbacks and prepare for cleaning of virCaps qemu: Record the default NIC model in the domain XML virCaps: get rid of "defaultInitPath" value in the virCaps struct virCaps: get rid of defaultDiskDriverName virCaps: get rid of emulatorRequired conf: Enforce ranges on cputune variables virCaps: remove defaultDiskDriverType from the struct virCaps: Get rid of hasWideScsiBus virCaps: get rid of macPrefix field src/conf/capabilities.c | 24 --- src/conf/capabilities.h | 20 -- src/conf/domain_conf.c | 239 ++++++++++++++++----- src/conf/domain_conf.h | 40 +++- src/esx/esx_driver.c | 13 +- src/libvirt_private.syms | 6 +- src/libvirt_vmx.syms | 2 + src/libxl/libxl_conf.c | 2 - src/libxl/libxl_driver.c | 13 +- src/lxc/lxc_conf.c | 11 +- src/lxc/lxc_domain.c | 17 ++ src/lxc/lxc_domain.h | 1 + src/lxc/lxc_driver.c | 6 +- src/openvz/openvz_conf.c | 4 +- src/openvz/openvz_driver.c | 32 ++- src/parallels/parallels_driver.c | 12 +- src/phyp/phyp_driver.c | 10 +- src/qemu/qemu_capabilities.c | 6 - src/qemu/qemu_command.c | 15 +- src/qemu/qemu_conf.c | 14 +- src/qemu/qemu_conf.h | 3 +- src/qemu/qemu_domain.c | 89 ++++++++ src/qemu/qemu_domain.h | 1 + src/qemu/qemu_driver.c | 13 +- src/security/virt-aa-helper.c | 2 +- src/test/test_driver.c | 2 +- src/uml/uml_driver.c | 7 +- src/vbox/vbox_tmpl.c | 18 +- src/vmware/vmware_conf.c | 4 +- src/vmware/vmware_driver.c | 8 +- src/vmx/vmx.c | 39 ++-- src/vmx/vmx.h | 12 +- src/xen/xen_driver.c | 7 +- src/xen/xen_hypervisor.c | 2 - src/xen/xend_internal.c | 6 +- src/xen/xm_internal.c | 2 + src/xenapi/xenapi_driver.c | 2 +- tests/domainsnapshotxml2xmltest.c | 2 +- tests/lxcxml2xmldata/lxc-hostdev.xml | 1 + tests/lxcxml2xmldata/lxc-systemd.xml | 1 + tests/qemuargv2xmltest.c | 2 +- tests/qemumonitorjsontest.c | 2 +- .../qemuxml2argv-disk-drive-network-nbd.args | 5 +- .../qemuxml2argv-disk-drive-network-nbd.xml | 1 + .../qemuxml2argv-disk-drive-network-rbd-auth.args | 2 +- .../qemuxml2argv-disk-drive-network-rbd-ipv6.args | 2 +- .../qemuxml2argv-disk-drive-network-rbd-ipv6.xml | 1 + .../qemuxml2argv-disk-drive-network-rbd.args | 2 +- .../qemuxml2argv-disk-drive-network-rbd.xml | 1 + .../qemuxml2argv-disk-drive-network-sheepdog.args | 3 +- .../qemuxml2argv-disk-drive-network-sheepdog.xml | 1 + .../qemuxml2argv-net-bandwidth.xml | 1 + .../qemuxml2argvdata/qemuxml2argv-net-client.args | 4 +- .../qemuxml2argv-net-eth-ifname.args | 4 +- .../qemuxml2argv-net-eth-ifname.xml | 1 + .../qemuxml2argv-net-eth-names.args | 8 +- tests/qemuxml2argvdata/qemuxml2argv-net-eth.args | 4 +- tests/qemuxml2argvdata/qemuxml2argv-net-eth.xml | 1 + .../qemuxml2argvdata/qemuxml2argv-net-hostdev.xml | 1 + tests/qemuxml2argvdata/qemuxml2argv-net-mcast.args | 4 +- .../qemuxml2argv-net-openvswitch.xml | 1 + .../qemuxml2argvdata/qemuxml2argv-net-server.args | 4 +- tests/qemuxml2argvdata/qemuxml2argv-net-user.args | 3 +- tests/qemuxml2argvdata/qemuxml2argv-net-user.xml | 1 + .../qemuxml2argv-net-virtio-network-portgroup.xml | 2 + tests/qemuxml2argvtest.c | 2 +- .../qemuxml2xmlout-graphics-spice-timeout.xml | 1 + tests/qemuxml2xmltest.c | 2 +- tests/qemuxmlnstest.c | 2 +- tests/securityselinuxlabeltest.c | 2 +- tests/testutilsxen.c | 2 +- tests/vmx2xmltest.c | 11 +- tests/xml2vmxtest.c | 8 +- 73 files changed, 548 insertions(+), 251 deletions(-) -- 1.8.1.5

3 28