- Devel - libvirt List Archives

[libvirt] [PATCH] Use unsigned int instead of unsigned
by Osier Yang 15 Apr '13

15 Apr '13

Though they are the same thing, mixed use of them is uncomfortable. "unsigned" is used a lot in old codes, this just tries to change the ones in utils. --- src/util/virpci.c | 65 +++++++++++++++++++++++++++++-------------------------- src/util/virpci.h | 24 ++++++++++---------- 2 files changed, 46 insertions(+), 43 deletions(-) diff --git a/src/util/virpci.c b/src/util/virpci.c index caf1d40..d94ff54 100644 --- a/src/util/virpci.c +++ b/src/util/virpci.c @@ -51,18 +51,18 @@ #define SRIOV_ERROR -1 struct _virPCIDevice { - unsigned domain; - unsigned bus; - unsigned slot; - unsigned function; + unsigned int domain; + unsigned int bus; + unsigned int slot; + unsigned int function; char name[PCI_ADDR_LEN]; /* domain:bus:slot.function */ char id[PCI_ID_LEN]; /* product vendor */ char *path; const char *used_by; /* The domain which uses the device */ - unsigned pcie_cap_pos; - unsigned pci_pm_cap_pos; + unsigned int pcie_cap_pos; + unsigned int pci_pm_cap_pos; bool has_flr; bool has_pm_reset; bool managed; @@ -76,7 +76,7 @@ struct _virPCIDevice { struct _virPCIDeviceList { virObjectLockable parent; - unsigned count; + unsigned int count; virPCIDevicePtr *devs; }; @@ -222,9 +222,9 @@ virPCIDeviceConfigClose(virPCIDevicePtr dev, int cfgfd) static int virPCIDeviceRead(virPCIDevicePtr dev, int cfgfd, - unsigned pos, + unsigned int pos, uint8_t *buf, - unsigned buflen) + unsigned int buflen) { memset(buf, 0, buflen); @@ -239,7 +239,7 @@ virPCIDeviceRead(virPCIDevicePtr dev, } static uint8_t -virPCIDeviceRead8(virPCIDevicePtr dev, int cfgfd, unsigned pos) +virPCIDeviceRead8(virPCIDevicePtr dev, int cfgfd, unsigned int pos) { uint8_t buf; virPCIDeviceRead(dev, cfgfd, pos, &buf, sizeof(buf)); @@ -247,7 +247,7 @@ virPCIDeviceRead8(virPCIDevicePtr dev, int cfgfd, unsigned pos) } static uint16_t -virPCIDeviceRead16(virPCIDevicePtr dev, int cfgfd, unsigned pos) +virPCIDeviceRead16(virPCIDevicePtr dev, int cfgfd, unsigned int pos) { uint8_t buf[2]; virPCIDeviceRead(dev, cfgfd, pos, &buf[0], sizeof(buf)); @@ -255,7 +255,7 @@ virPCIDeviceRead16(virPCIDevicePtr dev, int cfgfd, unsigned pos) } static uint32_t -virPCIDeviceRead32(virPCIDevicePtr dev, int cfgfd, unsigned pos) +virPCIDeviceRead32(virPCIDevicePtr dev, int cfgfd, unsigned int pos) { uint8_t buf[4]; virPCIDeviceRead(dev, cfgfd, pos, &buf[0], sizeof(buf)); @@ -265,9 +265,9 @@ virPCIDeviceRead32(virPCIDevicePtr dev, int cfgfd, unsigned pos) static int virPCIDeviceWrite(virPCIDevicePtr dev, int cfgfd, - unsigned pos, + unsigned int pos, uint8_t *buf, - unsigned buflen) + unsigned int buflen) { if (lseek(cfgfd, pos, SEEK_SET) != pos || safewrite(cfgfd, buf, buflen) != buflen) { @@ -280,14 +280,14 @@ virPCIDeviceWrite(virPCIDevicePtr dev, } static void -virPCIDeviceWrite16(virPCIDevicePtr dev, int cfgfd, unsigned pos, uint16_t val) +virPCIDeviceWrite16(virPCIDevicePtr dev, int cfgfd, unsigned int pos, uint16_t val) { uint8_t buf[2] = { (val >> 0), (val >> 8) }; virPCIDeviceWrite(dev, cfgfd, pos, &buf[0], sizeof(buf)); } static void -virPCIDeviceWrite32(virPCIDevicePtr dev, int cfgfd, unsigned pos, uint32_t val) +virPCIDeviceWrite32(virPCIDevicePtr dev, int cfgfd, unsigned int pos, uint32_t val) { uint8_t buf[4] = { (val >> 0), (val >> 8), (val >> 16), (val >> 24) }; virPCIDeviceWrite(dev, cfgfd, pos, &buf[0], sizeof(buf)); @@ -370,7 +370,9 @@ virPCIDeviceIterDevices(virPCIDeviceIterPredicate predicate, } static uint8_t -virPCIDeviceFindCapabilityOffset(virPCIDevicePtr dev, int cfgfd, unsigned capability) +virPCIDeviceFindCapabilityOffset(virPCIDevicePtr dev, + int cfgfd, + unsigned int capability) { uint16_t status; uint8_t pos; @@ -407,7 +409,7 @@ virPCIDeviceFindCapabilityOffset(virPCIDevicePtr dev, int cfgfd, unsigned capabi static unsigned int virPCIDeviceFindExtendedCapabilityOffset(virPCIDevicePtr dev, int cfgfd, - unsigned capability) + unsigned int capability) { int ttl; unsigned int pos; @@ -496,7 +498,7 @@ virPCIDeviceDetectFunctionLevelReset(virPCIDevicePtr dev, int cfgfd) * and that a D3hot->D0 transition will results in a full * internal reset, not just a soft reset. */ -static unsigned +static unsigned int virPCIDeviceDetectPowerManagementReset(virPCIDevicePtr dev, int cfgfd) { if (dev->pci_pm_cap_pos) { @@ -1341,10 +1343,10 @@ virPCIDeviceReadID(virPCIDevicePtr dev, const char *id_name) } int -virPCIGetAddrString(unsigned domain, - unsigned bus, - unsigned slot, - unsigned function, +virPCIGetAddrString(unsigned int domain, + unsigned int bus, + unsigned int slot, + unsigned int function, char **pciConfigAddr) { virPCIDevicePtr dev = NULL; @@ -1365,10 +1367,10 @@ cleanup: } virPCIDevicePtr -virPCIDeviceNew(unsigned domain, - unsigned bus, - unsigned slot, - unsigned function) +virPCIDeviceNew(unsigned int domain, + unsigned int bus, + unsigned int slot, + unsigned int function) { virPCIDevicePtr dev; char *vendor = NULL; @@ -1458,12 +1460,13 @@ void virPCIDeviceSetManaged(virPCIDevicePtr dev, bool managed) dev->managed = managed; } -unsigned virPCIDeviceGetManaged(virPCIDevicePtr dev) +unsigned int +virPCIDeviceGetManaged(virPCIDevicePtr dev) { return dev->managed; } -unsigned +unsigned int virPCIDeviceGetUnbindFromStub(virPCIDevicePtr dev) { return dev->unbind_from_stub; @@ -1475,7 +1478,7 @@ virPCIDeviceSetUnbindFromStub(virPCIDevicePtr dev, bool unbind) dev->unbind_from_stub = unbind; } -unsigned +unsigned int virPCIDeviceGetRemoveSlot(virPCIDevicePtr dev) { return dev->remove_slot; @@ -1487,7 +1490,7 @@ virPCIDeviceSetRemoveSlot(virPCIDevicePtr dev, bool remove_slot) dev->remove_slot = remove_slot; } -unsigned +unsigned int virPCIDeviceGetReprobe(virPCIDevicePtr dev) { return dev->reprobe; diff --git a/src/util/virpci.h b/src/util/virpci.h index 0c4a8d2..67bee3d 100644 --- a/src/util/virpci.h +++ b/src/util/virpci.h @@ -41,10 +41,10 @@ struct _virPCIDeviceAddress { unsigned int function; }; -virPCIDevicePtr virPCIDeviceNew(unsigned domain, - unsigned bus, - unsigned slot, - unsigned function); +virPCIDevicePtr virPCIDeviceNew(unsigned int domain, + unsigned int bus, + unsigned int slot, + unsigned int function); void virPCIDeviceFree(virPCIDevicePtr dev); const char *virPCIDeviceGetName(virPCIDevicePtr dev); @@ -62,17 +62,17 @@ int virPCIDeviceReset(virPCIDevicePtr dev, void virPCIDeviceSetManaged(virPCIDevice *dev, bool managed); -unsigned virPCIDeviceGetManaged(virPCIDevice *dev); +unsigned int virPCIDeviceGetManaged(virPCIDevice *dev); void virPCIDeviceSetUsedBy(virPCIDevice *dev, const char *used_by); const char *virPCIDeviceGetUsedBy(virPCIDevice *dev); -unsigned virPCIDeviceGetUnbindFromStub(virPCIDevicePtr dev); +unsigned int virPCIDeviceGetUnbindFromStub(virPCIDevicePtr dev); void virPCIDeviceSetUnbindFromStub(virPCIDevice *dev, bool unbind); -unsigned virPCIDeviceGetRemoveSlot(virPCIDevicePtr dev); +unsigned int virPCIDeviceGetRemoveSlot(virPCIDevicePtr dev); void virPCIDeviceSetRemoveSlot(virPCIDevice *dev, bool remove_slot); -unsigned virPCIDeviceGetReprobe(virPCIDevicePtr dev); +unsigned int virPCIDeviceGetReprobe(virPCIDevicePtr dev); void virPCIDeviceSetReprobe(virPCIDevice *dev, bool reprobe); void virPCIDeviceReattachInit(virPCIDevice *dev); @@ -135,10 +135,10 @@ int virPCIGetSysfsFile(char *virPCIDeviceName, char **pci_sysfs_device_link) ATTRIBUTE_RETURN_CHECK; -int virPCIGetAddrString(unsigned domain, - unsigned bus, - unsigned slot, - unsigned function, +int virPCIGetAddrString(unsigned int domain, + unsigned int bus, + unsigned int slot, + unsigned int function, char **pciConfigAddr) ATTRIBUTE_NONNULL(5) ATTRIBUTE_RETURN_CHECK; -- 1.8.1.4

2 3

[libvirt] [PATCH] Do more complete initialization of libgcrypt
by Daniel P. Berrange 15 Apr '13

15 Apr '13

From: "Daniel P. Berrange" <berrange(a)redhat.com> If libvirt makes any gcry_control() calls, then this prevents gnutls for doing any initialization. As such we must take care to do full initialization of libcrypt on a par with what gnutls would have done. In particular we must disable "sec mem" for cases where the user does not have mlock() permission. We also skip our init of libgcrypt if something else (ie the app using libvirt) has beaten us to it. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- src/libvirt.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index c5221f5..7c0a873 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -409,8 +409,14 @@ virGlobalInit(void) goto error; #ifdef WITH_GNUTLS - gcry_control(GCRYCTL_SET_THREAD_CBS, &virTLSThreadImpl); - gcry_check_version(NULL); + if (gcry_control(GCRYCTL_ANY_INITIALIZATION_P) == 0) { + gcry_control(GCRYCTL_SET_THREAD_CBS, &virTLSThreadImpl); + gcry_check_version(NULL); + + gcry_control(GCRYCTL_DISABLE_SECMEM, NULL, 0); + gcry_control(GCRYCTL_INITIALIZATION_FINISHED, NULL, 0); + gcry_control(GCRYCTL_ENABLE_QUICK_RANDOM, 0); + } #endif virLogSetFromEnv(); -- 1.8.1.4

3 5

[libvirt] [PATCH 0/1] qemu: Add Secure Shell (ssh) network block device.
by Richard W.M. Jones 15 Apr '13

15 Apr '13

This patch allows you to use the qemu Secure Shell (ssh) block device. This is not upstream yet, but you can find my latest version here: http://lists.nongnu.org/archive/html/qemu-devel/2013-04/threads.html#01703 This patch lets you specify a ssh device like this: <disk type='network' device='disk'> <source protocol='ssh' name='/remote/path/to/disk/image'> <host name='remote-server.example.com'/> </source> <driver name='qemu' type='raw'/> <target dev='vda' bus='virtio'/> </disk> Patched qemu will connect to remote-server.example.com using libssh2, and access /remote/path/to/disk/image using the sftp protocol. This works for both read and write. Of course, since you'll have to use a patched qemu, you will also need to fiddle with the <emulator> setting. One current problem with this patch is that you have to manually set the SSH_AUTH_SOCK environment variable to point at your ssh-agent (since qemu's ssh block device requires ssh-agent authentication). I added the following to my XML, your value will be different: <qemu:commandline> <qemu:env name="SSH_AUTH_SOCK" value="/tmp/ssh-DThteVfEeOq3/agent.1773" /> </qemu:commandline> Some shortcomings: - Does not allow you to specify the host_key_check parameter. - No tests. - Not sure how best to deal with the ssh-agent authentication socket problem. Use libvirt secrets? If so, how? - I did not test if you can specify an alternate remote user. - I did not test (or care) if parsing qemu command lines works. Rich.

2 7

[libvirt] [PATCH 0/2] Domain object lookup improvements
by Peter Krempa 15 Apr '13

15 Apr '13

This series finishes refactoring of domain object retrieval in the qemu driver and improves error message if the domain object can't be found. This is a prequel for changing of the locking model of virDomain objects. Peter Krempa (2): qemu: Refactor lookup of domain object qemu: Report also domain name in error message when domain object wasn't found src/qemu/qemu_driver.c | 343 +++++++++++-------------------------------------- 1 file changed, 75 insertions(+), 268 deletions(-) -- 1.8.1.5

2 5

[libvirt] [PATCH v4 1/2] Add USB option capability
by Li Zhang 15 Apr '13

15 Apr '13

From: Li Zhang <zhlcindy(a)linux.vnet.ibm.com> To avoid the collision for creating USB controllers in machine->init() and -device xx command line, it needs to set usb=off to avoid one USB controller created in machine->init(). So that libvirt can use -device or -usb to create USB controller sucessfully. So QEMU_CAPS_MACHINE_USB_OPT capability is added, and it is for QEMU v1.3.0 onwards which supports USB option. Signed-off-by: Li Zhang <zhlcindy(a)linux.vnet.ibm.com> --- v4 -> v3: * Add one new test case for USB option * Rebase it with latest version v3 -> v2: * Set QEMU_CAPS_MACHINE_USB_OPT with help string v2 -> v1: * Rename QEMU_CAPS_USB_OPT to QEMU_CAPS_MACHINE_USB_OPT suggested by Daniel * Corret QEMU version with v1.3.0 suggested by Daniel src/qemu/qemu_capabilities.c | 9 +++++++++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 6 ++++++ 3 files changed, 16 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 50712b0..07cda1f 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -216,6 +216,7 @@ VIR_ENUM_IMPL(virQEMUCaps, QEMU_CAPS_LAST, "ipv6-migration", /* 135 */ "machine-opt", + "machine-usb-opt", ); struct _virQEMUCaps { @@ -1078,6 +1079,10 @@ virQEMUCapsComputeCmdFlags(const char *help, if (strstr(help, "-machine")) virQEMUCapsSet(qemuCaps, QEMU_CAPS_MACHINE_OPT); + /* USB option is supported v1.3.0 onwards */ + if (qemuCaps->version >= 1003000) + virQEMUCapsSet(qemuCaps, QEMU_CAPS_MACHINE_USB_OPT); + /* * Handling of -incoming arg with varying features * -incoming tcp (kvm >= 79, qemu >= 0.10.0) @@ -2435,6 +2440,10 @@ virQEMUCapsInitQMP(virQEMUCapsPtr qemuCaps, virQEMUCapsInitQMPBasic(qemuCaps); + /* USB option is supported v1.3.0 onwards */ + if (qemuCaps->version >= 1003000) + virQEMUCapsSet(qemuCaps, QEMU_CAPS_MACHINE_USB_OPT); + if (!(archstr = qemuMonitorGetTargetArch(mon))) goto cleanup; diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h index b2dc588..9f24d6a 100644 --- a/src/qemu/qemu_capabilities.h +++ b/src/qemu/qemu_capabilities.h @@ -176,6 +176,7 @@ enum virQEMUCapsFlags { QEMU_CAPS_SCSI_MEGASAS = 134, /* -device megasas */ QEMU_CAPS_IPV6_MIGRATION = 135, /* -incoming [::] */ QEMU_CAPS_MACHINE_OPT = 136, /* -machine xxxx*/ + QEMU_CAPS_MACHINE_USB_OPT = 137, /* -machine xxx,usb=on/off */ QEMU_CAPS_LAST, /* this must always be the last item */ }; diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 53caba5..d051056 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -5234,6 +5234,12 @@ qemuBuildMachineArgStr(virCommandPtr cmd, virCommandAddArg(cmd, "-machine"); virBufferAdd(&buf, def->os.machine, -1); + /* To avoid the collision of creating USB controllers when calling + * machine->init in QEMU, it needs to set usb=off + */ + if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_MACHINE_USB_OPT)) + virBufferAsprintf(&buf, ",usb=off"); + if (def->mem.dump_core) { if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_DUMP_GUEST_CORE)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", -- 1.8.1.4

2 9

[libvirt] [PATCH 0/4] cleanup: Use bool type instead of bitfield - More
by Osier Yang 13 Apr '13

13 Apr '13

Which are missed with pattern ": 1" in the previous cleanup series. After these, all the bitfield use under src/conf/ are destroyed, except the ones which are required by the existing APIs. Osier Yang (4): cleanup: Change datatype of accel's members to boolean cleanup: Change datatype of graphic's members to boolean cleanup: Change datatype of usbdev->allow to boolean cleanup: Change datatype of net->stp to boolean src/conf/domain_conf.c | 44 ++++++++++++++++++++-------------------- src/conf/domain_conf.h | 20 +++++++++--------- src/conf/network_conf.c | 2 +- src/conf/network_conf.h | 2 +- src/parallels/parallels_driver.c | 4 ++-- src/qemu/qemu_command.c | 6 +++--- src/vbox/vbox_tmpl.c | 6 +++--- src/vmx/vmx.c | 4 ++-- src/xenxs/xen_sxpr.c | 4 ++-- src/xenxs/xen_xm.c | 2 +- 10 files changed, 47 insertions(+), 47 deletions(-) -- 1.8.1.4

3 9

[libvirt] [RFC] Fix https://bugzilla.redhat.com/show_bug.cgi?id=461931
by harryxiyou 13 Apr '13

13 Apr '13

Hi Osier, >From the actual bug messages like fowllowing Actual results: Traceback (most recent call last): File "/usr/share/virt-manager/virtManager/createvol.py", line 191, in _async_vol_create poolobj = self.vol.install(meter=meter) File "/usr/lib/python2.5/site-packages/virtinst/Storage.py", line 893, in install (self.name, str(e))) RuntimeError: Couldn't create storage volume 'virt-stor-dir-bochs.img': '/usr/bin/qemu-img exited with non-zero status 1 and signal 0' It seems that libvirt calls command 'qemu-img' to create a volume of bochs but it failed. So the problem may no matter with Libvirt itself. I am not sure if qemu supports to create a volume of bochs. Or something wrong with QEMU? -- Thanks Harry Wei

2 3

[libvirt] [PATCH v6 00/11] Add support for guests with TPM passthrough device
by Stefan Berger 12 Apr '13

12 Apr '13

Hello! The following set of patches adds support to libvirt for adding a TPM passthrough device to a QEMU guest. Support for this was recently accepted into QEMU. This set of patches borrows a lot from the recently added support for rng's. Regards, Stefan --- v5->v6: - followed tree to 039a3283 - simplified virTPMFindCancelPath in 4/11 following D. Berrange's comments v4->v5: - followed tree to b83b31d8 - addressed D. Berrange's comments on patches 4, 7, 10, 11 & nit on 6 - droped code to parse QEMU cmd line with TPM since this requires editing of the resulting XML v3->v4: - followed tree to ce65b435 - followed comments on v3 v2->v3: - followed tree to 03122d7b - some nits I found fixed v1->v2: - Followed Daniel Berrange's comments (except for the one on de-consolidating the JSON monitor code)

3 20

[libvirt] [libvirt-designer v3] Add Vala API
by Zeeshan Ali (Khattak) 12 Apr '13

12 Apr '13

From: "Zeeshan Ali (Khattak)" <zeeshanak(a)gnome.org> This is mostly (modified) copy&paste from libvirt-glib. --- v3: Added .metadata file to correct init functions vapi. Makefile.am | 2 +- configure.ac | 37 +++++++++++++++++++++++++++++++++++++ vapi/LibvirtDesigner-1.0.metadata | 2 ++ vapi/Makefile.am | 28 ++++++++++++++++++++++++++++ vapi/libvirt-designer-1.0.deps | 2 ++ 5 files changed, 70 insertions(+), 1 deletion(-) create mode 100644 vapi/LibvirtDesigner-1.0.metadata create mode 100644 vapi/Makefile.am create mode 100644 vapi/libvirt-designer-1.0.deps diff --git a/Makefile.am b/Makefile.am index 7801b63..b928f83 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,5 +1,5 @@ -SUBDIRS = libvirt-designer examples docs +SUBDIRS = libvirt-designer vapi examples docs ACLOCAL_AMFLAGS = -I m4 diff --git a/configure.ac b/configure.ac index a9c5c34..c999826 100644 --- a/configure.ac +++ b/configure.ac @@ -71,10 +71,46 @@ if test "x$enable_examples" != "xno" ; then fi AM_CONDITIONAL(WITH_EXAMPLES, [test "x$enable_examples" = "xyes"]) +AC_ARG_ENABLE([vala], + AS_HELP_STRING([--enable-vala], [enable Vala binding generation]), + [], [enable_vala=check]) +if test "x$enable_introspection" = "xyes" ; then + if test "x$enable_vala" != "xno" ; then + AC_PATH_PROG(VAPIGEN, vapigen, no) + if test "x$VAPIGEN" == "xno"; then + if test "x$enable_vala" == "xcheck" ; then + enable_vala=no + else + AC_MSG_ERROR([Cannot find the "vapigen" binary in your PATH]) + fi + fi + AC_SUBST(VAPIGEN) + fi + if test "x$enable_vala" != "xno" ; then + AC_MSG_CHECKING([$VAPIGEN support for --metadatadir]) + $VAPIGEN --help | grep metadatadir 1>/dev/null 2>&1 + if test $? != 0 ; then + if test "x$enable_vala" == "xcheck" ; then + enable_vala=no + AC_MSG_RESULT([no]) + else + AC_MSG_ERROR(["vapigen" binary in your PATH is too old (< 0.13)]) + fi + else + AC_MSG_RESULT([no]) + fi + fi + if test "x$enable_vala" = "xcheck" ; then + enable_vala=yes + fi +fi +AM_CONDITIONAL([WITH_VALA], [test "x$enable_vala" = "xyes"]) + AC_OUTPUT(Makefile libvirt-designer/Makefile libvirt-designer.spec libvirt-designer-1.0.pc + vapi/Makefile docs/Makefile examples/Makefile) @@ -83,6 +119,7 @@ AC_MSG_NOTICE([Configuration summary]) AC_MSG_NOTICE([=====================]) AC_MSG_NOTICE([]) AC_MSG_NOTICE([]) +AC_MSG_NOTICE([ Vala API: $enable_vala]) AC_MSG_NOTICE([ examples: $enable_examples]) AC_MSG_NOTICE([]) AC_MSG_NOTICE([]) diff --git a/vapi/LibvirtDesigner-1.0.metadata b/vapi/LibvirtDesigner-1.0.metadata new file mode 100644 index 0000000..44f6726 --- /dev/null +++ b/vapi/LibvirtDesigner-1.0.metadata @@ -0,0 +1,2 @@ +init.argv unowned +init_check.argv unowned diff --git a/vapi/Makefile.am b/vapi/Makefile.am new file mode 100644 index 0000000..6136216 --- /dev/null +++ b/vapi/Makefile.am @@ -0,0 +1,28 @@ +NULL = + +if WITH_VALA +vapidir = $(datadir)/vala/vapi +vapi_DATA = \ + libvirt-designer-1.0.deps \ + libvirt-designer-1.0.vapi \ + $(NULL) + +libvirt-designer-1.0.vapi: $(top_builddir)/libvirt-designer/LibvirtDesigner-1.0.gir + $(AM_V_GEN)$(VAPIGEN) \ + --vapidir=$(builddir) \ + --pkg gio-2.0 \ + --pkg libosinfo-1.0 \ + --pkg libvirt-gconfig-1.0 \ + --library libvirt-designer-1.0 \ + --metadatadir=$(srcdir) \ + $< +endif + +CLEANFILES = \ + libvirt-designer-1.0.vapi \ + $(NULL) + +EXTRA_DIST = \ + LibvirtDesigner-1.0.metadata \ + libvirt-designer-1.0.deps \ + $(NULL) diff --git a/vapi/libvirt-designer-1.0.deps b/vapi/libvirt-designer-1.0.deps new file mode 100644 index 0000000..ba30bfd --- /dev/null +++ b/vapi/libvirt-designer-1.0.deps @@ -0,0 +1,2 @@ +libosinfo-1.0 +libvirt-gconfig-1.0 -- 1.8.1.4

2 2

[libvirt] Shared desktop: grant permission to start/stop/pause/resume guests only
by Thorsten Hesemeyer 12 Apr '13

12 Apr '13

Hi all, for a shared desktop configuration, is there an option to grant the permission to start, stop, pause or resume the kvm guest only? User roles in shared desktop environment configuration: Power user - fully manage libvirt / KVM guests Regular user - start, stop, pause and resume libvirt / KVM guests In other words, we are looking for an opportunity to: a) prevent regular users from modifying the libvirt / kvm guest but b) enable them to start, stop, pause, resume libvirt / kvm guests Currently I see two options: a) No specific libvirt permission: Regular users cannot start a virtual guest (without help). If users forget to shutdown the kvm client and try to poweroff the Linux system, they are asked for an admin/management user password to stop the virtual machine. So they need help to shutdown their machine - not good. b) Enable libvirt manage via policy kit: "manage" permission can be granted via overruling the default org.libvirt.unix.manage policy kit action. The manage right enables to modify the libvirt / kvm guest, which is too much in our case. Is there an option to grant the start/stop/pause/resume permission only? Does libvirt offer this kind of granularity? Kind regards, Thorsten Hesemeyer

4 3