- Devel - libvirt List Archives

Re: [libvirt] [virt-tools-list] Q on virsh attach-disk , why no network disk ?
by Cole Robinson 23 May '13

23 May '13

On 05/22/2013 08:55 AM, Deepak C Shetty wrote: > Hi All, > I was looking at virsh attach-disk and i see the below > [snip] > > DESCRIPTION > Attach new disk device. > > OPTIONS > [--domain] <string> domain name, id or uuid > [--source] <string> source of disk device > [--target] <string> target of disk device > ... > ... > > *--sourcetype <string> type of source (block|file)* > [/snip] > > I was wondering why the sourcetype only support block|file only ? What if i > wanted to add a network (disk type=network) based drive ? Is this a constraint > of virsh or QEMU itself doesn't allow hotplu of network block device disk ? > virsh questions go to libvirt-list, CC'd. It's just a missing feature, not a deliberate omission. Patches welcome. - Cole

2 1

[libvirt] [PATCH 1/3] umlConnectTapDevice: initialize tapfd variable
by Michal Privoznik 23 May '13

23 May '13

There is possibility to jump to 'cleanup' label without tapfd variable being initialized. In the label, VIR_FORCE_CLOSE(tapfd) is called which can have fatal consequences. --- src/uml/uml_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/uml/uml_conf.c b/src/uml/uml_conf.c index a4088f2..38dcfbb 100644 --- a/src/uml/uml_conf.c +++ b/src/uml/uml_conf.c @@ -109,7 +109,7 @@ umlConnectTapDevice(virConnectPtr conn, const char *bridge) { bool template_ifname = false; - int tapfd; + int tapfd = -1; if (!net->ifname || STRPREFIX(net->ifname, VIR_NET_GENERATED_PREFIX) || -- 1.8.2.1

2 5

[libvirt] [PATCH v2 00/11] Refactor Xen driver to support ACL work
by Daniel P. Berrange 23 May '13

23 May '13

From: "Daniel P. Berrange" <berrange(a)redhat.com> The Xen driver currently is a really horrible mess, in particular with the way iterates over sub-drivers calling each one in turn, until one magically works. For each operation there is always a clear rule for which sub-driver must be used. Thus instead of blindly iterating over all drivers, we can directly invoke the correct sub-driver. This highlights that quite alot of code is in fact completely unreachable / used & can be deleted. The second big issue is that the Xen sub-drivers will randomly use either the 'id', 'name' or 'uuid' from the virDomainPtr object. If the user provides a malicious virDomainPtr instance, it is possible to have a 'id' referring to domain A, a 'name' referring to domain B and a 'uuid' referring to domain C. This makes doing reliable access control checks difficult. To ensure we have a consistent triple, use the 'uuid' from virDomainPtr to lookup the guest with the hypervisor and return a virDomainDefPtr where only the name/id/uuid are filled out. Use this in the all the subdrivers isolating them from the public virDomainPtr object. The top level Xen driver will then be able to do access control checks on the virDomainDefPtr instances. In v2: - Merged all patches removing the sub-driver iteration concept - Rebased to latest git Daniel P. Berrange (11): Convert Xen domain lookup driver methods to use virDomainDefPtr Convert Xen domain lifecycle driver methods to use virDomainDefPtr Convert Xen domain property driver methods to use virDomainDefPtr Convert Xen domain managed save driver methods to use virDomainDefPtr Convert Xen domain start/migration APIs to use virDomainDefPtr Convert Xen domain VCPU driver methods to use virDomainDefPtr Convert Xen domain device hotplug driver methods to use virDomainDefPtr Convert Xen domain autostart driver methods to use virDomainDefPtr Convert Xen domain scheduler driver methods to use virDomainDefPtr Convert Xen domain stats/peek driver methods to use virDomainDefPtr Convert Xen domain core dump driver methods to use virDomainDefPtr src/conf/domain_conf.c | 24 ++ src/conf/domain_conf.h | 4 + src/libvirt_private.syms | 1 + src/xen/block_stats.c | 6 +- src/xen/block_stats.h | 2 +- src/xen/xen_driver.c | 781 ++++++++++++++++++++++++++++++++++++----------- src/xen/xen_hypervisor.c | 131 ++++---- src/xen/xen_hypervisor.h | 60 ++-- src/xen/xen_inotify.c | 14 +- src/xen/xend_internal.c | 469 ++++++++++++++-------------- src/xen/xend_internal.h | 127 +++++--- src/xen/xm_internal.c | 224 +++++++------- src/xen/xm_internal.h | 71 +++-- 13 files changed, 1230 insertions(+), 684 deletions(-) -- 1.8.1.4

4 29

[libvirt] [PATCHv4 0/4] Multiple TX queue support
by Michal Privoznik 23 May '13

23 May '13

Fixed version with Laine's comments worked in [1]. Moreover, most of the patches joined together. Patches 2, 3 and 5 has been ACKed already. BTW, patch 4 is really a different to patch 3. The only thing they share is a commit message body. Kernel and subsequently QEMU learned multiple transmit queues a while ago. The feature has a nice advantage, it allows a single guest to transmit multiple flows of network data using multiple CPUs simultaneously which increase traffic bandwidth. A lot. The documentation how to use this is available at [2] or [3]. 1: https://www.redhat.com/archives/libvir-list/2013-May/msg01196.html 2: https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/tree/Docume… 3: http://git.qemu.org/?p=qemu.git;a=blob;f=qemu-options.hx;hb=HEAD#l1363 Michal Privoznik (4): Introduce /domain/devices/interface/driver/@queues attribute qemu: Move interface cmd line construction into a separate function qemu: Adapt qemuBuildInterfaceCommandLine to to multiqueue net qemu: Enable multiqueue network docs/formatdomain.html.in | 12 +- docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c | 15 + src/conf/domain_conf.h | 1 + src/network/bridge_driver.c | 2 +- src/qemu/qemu_command.c | 462 +++++++++++++-------- src/qemu/qemu_command.h | 13 +- src/qemu/qemu_hotplug.c | 113 +++-- src/qemu/qemu_monitor.c | 78 ++-- src/qemu/qemu_monitor.h | 8 +- src/uml/uml_conf.c | 5 +- src/util/virnetdevtap.c | 113 ++--- src/util/virnetdevtap.h | 2 + .../qemuxml2argvdata/qemuxml2argv-vhost_queues.xml | 51 +++ tests/qemuxml2xmltest.c | 1 + 15 files changed, 593 insertions(+), 288 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-vhost_queues.xml -- 1.8.2.1

3 10

[libvirt] [PATCH] virsh: Fix virDomainFree for NULL domain in blkdeviotune
by Martin Kletzander 23 May '13

23 May '13

Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- Notes: Pushed as 'trivial' tools/virsh-domain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index bc42408..0402aef 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -1130,7 +1130,8 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) cleanup: virTypedParamsFree(params, nparams); - virDomainFree(dom); + if (dom) + virDomainFree(dom); return ret; save_error: -- 1.8.2.1

1 0

[libvirt] [PATCH] Fix the build failure
by Osier Yang 23 May '13

23 May '13

Commit 16251193afdc forgot to include "virstring.h". Pushed under build-breaker rule. --- src/rpc/virnetservermdns.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/rpc/virnetservermdns.c b/src/rpc/virnetservermdns.c index 68d5e4e..4b3c19a 100644 --- a/src/rpc/virnetservermdns.c +++ b/src/rpc/virnetservermdns.c @@ -45,6 +45,7 @@ #include "viralloc.h" #include "virerror.h" #include "virlog.h" +#include "virstring.h" #define VIR_FROM_THIS VIR_FROM_RPC -- 1.8.1.4

1 0

[libvirt] Schedule for next release ?
by Daniel Veillard 23 May '13

23 May '13

It seems that if we want to have the release at the end of the month we ought to enter freeze next Monday the 27 for a release on the 3rd (I may have a hard time making the release on Friday 31 or w.e.). Is there any problem with freezing next Monday ? If not let's proceed that way, in that case 1.0.6 will be out on Monday 3rd June ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

3 2

[libvirt] [PATCH 0/7 v2] Fixes for cgroup setting.
by Osier Yang 23 May '13

23 May '13

/8 ~ 5/8 are refactorings, real fixes are 6/8, 7/8. v1 - v2: * Only rebasing Osier Yang (7): qemu: Abstract the code for blkio controller setting into a helper qemu: Abstract code for memory controller setting into a helper qemu: Abstract code for devices controller setting into a helper qemu: Abstract code for cpuset controller setting into a helper qemu: Abstract code for the cpu controller setting into a helper qemu: Set cpuset.cpus for domain process qemu: Prohibit getting the numa parameters if mode is not strict src/qemu/qemu_cgroup.c | 556 +++++++++++++++++++++++++++++-------------------- src/qemu/qemu_driver.c | 11 +- 2 files changed, 340 insertions(+), 227 deletions(-) -- 1.8.1.4

3 23

[libvirt] [test-API][PATCH] Add env check function for memory_params_live
by Wayne Sun 23 May '13

23 May '13

In this case, domain memory cgroup path is hardcoded and fail the case after cgroup path changed recently. To avoid such failure, add check function for lscgroup command before run this case, if check fail then skip this case. Signed-off-by: Wayne Sun <gsun(a)redhat.com> --- repos/domain/memory_params_live.py | 36 ++++++++++++++++++++++++++++++------ 1 file changed, 30 insertions(+), 6 deletions(-) diff --git a/repos/domain/memory_params_live.py b/repos/domain/memory_params_live.py index 44fb8b4..280792a 100644 --- a/repos/domain/memory_params_live.py +++ b/repos/domain/memory_params_live.py @@ -4,6 +4,7 @@ import os import math +import commands from xml.dom import minidom import libvirt @@ -15,27 +16,35 @@ required_params = ('guestname', 'hard_limit', 'soft_limit', 'swap_hard_limit', ) optional_params = {} UNLIMITED = 9007199254740991 -CGROUP_PATH = "/cgroup/memory/libvirt/qemu" +CGROUP_PATH = "/cgroup/" def get_cgroup_setting(guestname): """get domain memory parameters in cgroup """ if os.path.exists(CGROUP_PATH): - cgroup_path = "%s/%s" % (CGROUP_PATH, guestname) + cgroup_path = CGROUP_PATH else: - cgroup_path = "/sys/fs%s/%s" % (CGROUP_PATH, guestname) + cgroup_path = "/sys/fs%s" % CGROUP_PATH - f = open("%s/memory.limit_in_bytes" % cgroup_path) + cmd = "lscgroup | grep %s | grep memory:" % guestname + ret, out = commands.getstatusoutput(cmd) + if ret: + logger.error(out) + return 1 + else: + mem_cgroup_path = "%s%s" % (cgroup_path, out.replace(':', '')) + + f = open("%s/memory.limit_in_bytes" % mem_cgroup_path) hard = int(f.read()) logger.info("memory.limit_in_bytes value is %s" % hard) f.close() - f = open("%s/memory.soft_limit_in_bytes" % cgroup_path) + f = open("%s/memory.soft_limit_in_bytes" % mem_cgroup_path) soft = int(f.read()) logger.info("memory.soft_limit_in_bytes value is %s" % soft) f.close() - f = open("%s/memory.memsw.limit_in_bytes" % cgroup_path) + f = open("%s/memory.memsw.limit_in_bytes" % mem_cgroup_path) swap = int(f.read()) logger.info("memory.memsw.limit_in_bytes value is %s" % swap) f.close() @@ -98,6 +107,10 @@ def memory_params_live(params): logger.info("check memory parameters in cgroup") ret = get_cgroup_setting(guestname) + if ret == 1: + logger.error("fail to get domain memory cgroup setting") + return 1 + for i in param_dict.keys(): if math.fabs(param_dict[i] - ret[i]) > 1: logger.error("%s value not match with cgroup setting" % i) @@ -110,3 +123,14 @@ def memory_params_live(params): return 1 return 0 + +def memory_params_live_check(params): + """check lscgroup packages + """ + logger = params['logger'] + cmd = 'lscgroup' + ret, out = commands.getstatusoutput(cmd) + if ret and 'command not found' in out: + logger.error(out) + logger.error("package libcgroup or libcgroup-tools is not installed") + return 1 -- 1.8.2.1

2 2

[libvirt] Remove OPTION section in output of 'virsh help command' if no option exists.
by Zhang Xiaohe 23 May '13

23 May '13

Don't print 'OPTION' if there's no options. Just behaves as DESCRIPTION does. This mostly affects 'interface' command group. Signed-off-by: Zhang Xiaohe <zhangxh(a)cn.fujitsu.com> Reported-by: Li Yang <liyang.fnst(a)cn.fujitsu.com> --- tools/virsh.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index ecb7bd4..7c60800 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -1270,7 +1270,9 @@ vshCmddefHelp(vshControl *ctl, const char *cmdname) if (def->opts) { const vshCmdOptDef *opt; - fputs(_("\n OPTIONS\n"), stdout); + /* Print the option only if there are options */ + if (def->opts->name) + fputs(_("\n OPTIONS\n"), stdout); for (opt = def->opts; opt->name; opt++) { switch (opt->type) { case VSH_OT_BOOL: -- 1.7.1

2 2