- Devel - libvirt List Archives

[libvirt] [PATCH] Set process ID in system identity
by Daniel P. Berrange 24 Jun '13

24 Jun '13

From: "Daniel P. Berrange" <berrange(a)redhat.com> When creating a virIdentityPtr for the system identity, include the current process ID as an attribute. --- src/util/viridentity.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/util/viridentity.c b/src/util/viridentity.c index 034a12a..6d93d0f 100644 --- a/src/util/viridentity.c +++ b/src/util/viridentity.c @@ -139,6 +139,13 @@ virIdentityPtr virIdentityGetSystem(void) #if WITH_SELINUX security_context_t con; #endif + char *processid = NULL; + + if (virAsprintf(&processid, "%llu", + (unsigned long long)getpid()) < 0) { + virReportOOMError(); + goto cleanup; + } if (!(username = virGetUserName(getuid()))) goto cleanup; @@ -176,11 +183,16 @@ virIdentityPtr virIdentityGetSystem(void) VIR_IDENTITY_ATTR_SELINUX_CONTEXT, seccontext) < 0) goto error; + if (virIdentitySetAttr(ret, + VIR_IDENTITY_ATTR_UNIX_PROCESS_ID, + processid) < 0) + goto error; cleanup: VIR_FREE(username); VIR_FREE(groupname); VIR_FREE(seccontext); + VIR_FREE(processid); return ret; error: -- 1.8.1.4

3 2

[libvirt] [PATCH 00/19] Fine grained access control for libvirt APIs
by Daniel P. Berrange 24 Jun '13

24 Jun '13

From: "Daniel P. Berrange" <berrange(a)redhat.com> This is a repost of http://www.redhat.com/archives/libvir-list/2012-May/msg00090.html Most of the early patches in that series are now merged. What is left is the actual access control work. The first patches setup the infrastructure and provide two drivers (policy kit and selinux). The remaining patches add access control checks to all the public APIs in each driver. The final patch adds a test case to validate that every driver API impl has an access control check present. Still todo - Optimize the polkit driver by making direct dbus calls instead of spawning the polkit helper program - Add filtering of returned objects from the various vir*List* APIs - Finish adding acl checks to the legacy Xen driver in about 6 apis. - Write a standalone access control driver as alternative to polkit - Audit permission names & groups to ensure we have an optimial set of permissions defined to cover all our APIs. Daniel P. Berrange (19): Define basic internal API for access control Set conn->driver before running driver connectOpen method Setup default access control manager in libvirtd Add a policy kit access control driver Add an SELinux access control driver Add ACL annotations to all RPC messages Auto-generate helpers for checking access control rules Add ACL checks into the QEMU driver Add ACL checks into the LXC driver Add ACL checks into the UML driver Add ACL checks into the Xen driver Add ACL checks into the libxl driver Add ACL checks into the storage driver Add ACL checks into the network driver Add ACL checks into the interface driver Add ACL checks into the node device driver Add ACL checks into the nwfilter driver Add ACL checks into the secrets driver Add validation that all APIs contain ACL checks .gitignore | 10 + daemon/Makefile.am | 1 + daemon/libvirtd-config.c | 4 + daemon/libvirtd-config.h | 2 + daemon/libvirtd.aug | 1 + daemon/libvirtd.c | 28 +- daemon/libvirtd.conf | 9 + daemon/test_libvirtd.aug.in | 4 + include/libvirt/virterror.h | 4 + m4/virt-compile-warnings.m4 | 1 + m4/virt-selinux.m4 | 2 + po/POTFILES.in | 3 + src/Makefile.am | 187 ++++++++- src/access/genpolkit.pl | 119 ++++++ src/access/viraccessdriver.h | 89 ++++ src/access/viraccessdrivernop.c | 118 ++++++ src/access/viraccessdrivernop.h | 28 ++ src/access/viraccessdriverpolkit.c | 399 ++++++++++++++++++ src/access/viraccessdriverpolkit.h | 28 ++ src/access/viraccessdriverselinux.c | 565 +++++++++++++++++++++++++ src/access/viraccessdriverselinux.h | 28 ++ src/access/viraccessdriverstack.c | 285 +++++++++++++ src/access/viraccessdriverstack.h | 32 ++ src/access/viraccessmanager.c | 351 ++++++++++++++++ src/access/viraccessmanager.h | 91 ++++ src/access/viraccessperm.c | 84 ++++ src/access/viraccessperm.h | 647 +++++++++++++++++++++++++++++ src/check-aclrules.pl | 144 +++++++ src/interface/interface_backend_netcf.c | 115 +++++ src/interface/interface_backend_udev.c | 85 +++- src/internal.h | 4 + src/libvirt.c | 11 +- src/libvirt_private.syms | 37 ++ src/libxl/libxl_driver.c | 187 ++++++++- src/locking/lock_protocol.x | 8 + src/lxc/lxc_driver.c | 219 +++++++++- src/network/bridge_driver.c | 61 +++ src/node_device/node_device_driver.c | 36 ++ src/nwfilter/nwfilter_driver.c | 26 ++ src/qemu/qemu_driver.c | 716 ++++++++++++++++++++++++++++---- src/remote/lxc_protocol.x | 1 + src/remote/qemu_protocol.x | 4 + src/remote/remote_protocol.x | 406 ++++++++++++++++++ src/rpc/gendispatch.pl | 211 +++++++++- src/secret/secret_driver.c | 31 ++ src/storage/storage_driver.c | 155 ++++++- src/uml/uml_driver.c | 174 +++++++- src/util/virerror.c | 8 + src/util/virlog.c | 3 +- src/util/virlog.h | 1 + src/xen/xen_driver.c | 217 +++++++++- 51 files changed, 5827 insertions(+), 153 deletions(-) create mode 100755 src/access/genpolkit.pl create mode 100644 src/access/viraccessdriver.h create mode 100644 src/access/viraccessdrivernop.c create mode 100644 src/access/viraccessdrivernop.h create mode 100644 src/access/viraccessdriverpolkit.c create mode 100644 src/access/viraccessdriverpolkit.h create mode 100644 src/access/viraccessdriverselinux.c create mode 100644 src/access/viraccessdriverselinux.h create mode 100644 src/access/viraccessdriverstack.c create mode 100644 src/access/viraccessdriverstack.h create mode 100644 src/access/viraccessmanager.c create mode 100644 src/access/viraccessmanager.h create mode 100644 src/access/viraccessperm.c create mode 100644 src/access/viraccessperm.h create mode 100644 src/check-aclrules.pl -- 1.8.1.4

2 27

[libvirt] [PATCH] bugfix: virNetDevBridgeSetSTPDelay on BSD
by Roman Bogorodskiy 24 Jun '13

24 Jun '13

virNetDevBridgeSetSTPDelay accepts delay in milliseconds, but BSD implementation was expecting seconds. Therefore, it was working correctly only with delay == 0. --- src/util/virnetdevbridge.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/util/virnetdevbridge.c b/src/util/virnetdevbridge.c index ffcb4a4..9d95374 100644 --- a/src/util/virnetdevbridge.c +++ b/src/util/virnetdevbridge.c @@ -593,10 +593,11 @@ int virNetDevBridgeSetSTPDelay(const char *brname, int delay) { struct ifbrparam param; + u_long delay_seconds = delay / 1000; /* FreeBSD doesn't allow setting STP delay < 4 */ - delay = delay < 4 ? 4 : delay; - param.ifbrp_fwddelay = ((u_long)delay) & 0xff; + delay_seconds = delay_seconds < 4 ? 4 : delay_seconds; + param.ifbrp_fwddelay = delay_seconds & 0xff; if (virNetDevBridgeCmd(brname, BRDGSFD, &param, sizeof(param)) < 0) { virReportSystemError(errno, -- 1.8.2.3

2 2

[libvirt] [PATCH] qemu: check if block I/O limits fit into long long
by Ján Tomko 24 Jun '13

24 Jun '13

We can only pass values up to LLONG_MAX through JSON and QEMU checks if the int64_t number is not negative at startup since 1.5.0. https://bugzilla.redhat.com/show_bug.cgi?id=974010 --- src/qemu/qemu_driver.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 3d9457f..b4b66aa 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -14099,6 +14099,13 @@ qemuDomainSetBlockIoTune(virDomainPtr dom, for (i = 0; i < nparams; i++) { virTypedParameterPtr param = &params[i]; + if (param->value.ul > LLONG_MAX) { + virReportError(VIR_ERR_OVERFLOW, + _("block I/O throttle limit value must" + " be less than %llu"), LLONG_MAX); + goto endjob; + } + if (STREQ(param->field, VIR_DOMAIN_BLOCK_IOTUNE_TOTAL_BYTES_SEC)) { info.total_bytes_sec = param->value.ul; set_bytes = true; -- 1.8.1.5

2 2

[libvirt] [PATCH 0/2] security: Save labels of resources before libvirt changing them for restoring.
by yangdongsheng 24 Jun '13

24 Jun '13

Hi ALL: There is a confusing issue in svirt. If sec_type is dynamic or relabel is yes in VM, when VM stopped, the label of image will be restored to a default label on the path, but not my expected label what it was before VM is started. Example: #virsh dumpxml virt-tests-vm1 ... <disk type='file' device='disk'> <driver name='qemu' type='raw' cache='none'/> <source file='/libvirt_autotest_root/images/fedora17.img'/> <target dev='hda' bus='ide'/> <address type='drive' controller='0' bus='0' target='0' unit='0'/> </disk> ... <seclabel type='dynamic' model='selinux' relabel='yes'/> ... # ll /libvirt_autotest_root/images/fedora17.img -Z -rwxr-xr-x. root root *system_u:object_r:svirt_image_t:s0* /libvirt_autotest_root/images/fedora17.img # virsh start virt-tests-vm1 Domain virt-tests-vm1 started # virsh destroy virt-tests-vm1 Domain virt-tests-vm1 destroyed # ll /libvirt_autotest_root/images/fedora17.img -Z -rwxr-xr-x. root root *system_u:object_r:default_t:s0* /libvirt_autotest_root/images/fedora17.img Label is changed from svirt_image_t to default_t. And the svirt_image_t is accessable for svirt_t process but default_t is not. This patch instroduce a struct named _virSecuritySELinuxBackupContext to save the path and the label before libvirt changing them. And labels will be restored to path in VM being stopped. yangdongsheng (2): util: Introduce virStrcmp into virstring. security: Save contexts of resources for restoring it. src/security/security_selinux.c | 229 +++++++++++++++++++++++++++++++++++++-- src/util/virstring.c | 14 +++ src/util/virstring.h | 2 + 3 files changed, 238 insertions(+), 7 deletions(-) -- 1.7.10.1

4 6

[libvirt] [PATCH v7 0/6] libvirt supports Guest Panicked
by Chen Fan 24 Jun '13

24 Jun '13

Changes: v6-v7: implement the rename-restart behavior. v5-v6: Refactor the patches, and fix the incorrect indentation and name. v4-v5: 1. fix the incorrect indentation and explanation (of some reasons). v3-v4: 1. Supports the dumpcore options of the oncrash element in the XML. 2. Move the previous code to processWatchdogEvent(). v2-v3: 1. split into 3 patches v1-v2: 1. fix the incorrect domain state: paused -> crashed, when crash the guest while libvirt isn't running, then restart libvirtd. Chen Fan (6): libvirt: Define domain crash event types qemu: Refactor the processwatchdogEvent code that can make the driver workpool more generalized qemu: Need to use qemuProcessShutdownOrReboot(), so we defined it at qemu_process.h qemu: Implement 'oncrash' events when guest panicked qemu: Implement 'oncrash' coredump events when guest panicked qemu: Implement oncrash 'rename-resart' event when guest panicked examples/domain-events/events-c/event-test.c | 10 + include/libvirt/libvirt.h.in | 16 ++ src/conf/domain_conf.c | 12 +- src/qemu/qemu_domain.h | 11 +- src/qemu/qemu_driver.c | 289 ++++++++++++++++++++++++--- src/qemu/qemu_monitor.c | 14 +- src/qemu/qemu_monitor.h | 4 + src/qemu/qemu_monitor_json.c | 7 + src/qemu/qemu_process.c | 60 +++++- src/qemu/qemu_process.h | 3 + tools/virsh-domain-monitor.c | 8 + 11 files changed, 395 insertions(+), 39 deletions(-) -- 1.8.1.4

3 9

[libvirt] [PATCH v5 0/5] Add qcow2 extensions support
by Ján Tomko 24 Jun '13

24 Jun '13

Since QEMU 1.1 qcow2 supports a features bitfield, allowing to implement additional features without breaking compatibility with older QEMU versions. The version header on-disk is bumped to 3, however the format name is still 'qcow2', not 'qcow3' (which is what I used in v2). v5: Use [0-9]+.[0-9]+ for compat value and enforce it in XML. Fix broken rebase (error vs. cleanup labels). Check if the specified feature is available with the current compat level. v4: rebased https://www.redhat.com/archives/libvir-list/2013-June/msg00427.html v3: https://www.redhat.com/archives/libvir-list/2013-May/msg01179.html v2: https://www.redhat.com/archives/libvir-list/2013-February/msg00212.html qcow2 vs. qcow3 discussion: https://www.redhat.com/archives/libvir-list/2013-March/msg00094.html Ján Tomko (5): util: add support for qcow2v3 image detection conf: add features to volume target XML storage: add support for creating qcow2 images with extensions conf: add features to snapshot disk XML qemu: add qcow2 extension support to inactive external snapshots docs/formatsnapshot.html.in | 5 + docs/formatstorage.html.in | 20 +++ docs/schemas/Makefile.am | 1 + docs/schemas/domainsnapshot.rng | 7 + docs/schemas/storagefilefeatures.rng | 24 ++++ docs/schemas/storagevol.rng | 7 + libvirt.spec.in | 1 + mingw-libvirt.spec.in | 2 + src/conf/snapshot_conf.c | 84 +++++++++++ src/conf/snapshot_conf.h | 2 + src/conf/storage_conf.c | 78 +++++++++++ src/conf/storage_conf.h | 7 +- src/libvirt_private.syms | 2 + src/qemu/qemu_driver.c | 88 ++++++++++-- src/storage/storage_backend.c | 62 ++++++++- src/storage/storage_backend_fs.c | 10 ++ src/util/virstoragefile.c | 169 ++++++++++++++++++----- src/util/virstoragefile.h | 12 ++ tests/domainsnapshotxml2xmlin/disk_snapshot.xml | 5 + tests/domainsnapshotxml2xmlout/disk_snapshot.xml | 4 + tests/storagevolxml2argvdata/qcow2-1.1.argv | 1 + tests/storagevolxml2argvdata/qcow2-lazy.argv | 1 + tests/storagevolxml2argvdata/vol-qcow2-1.1.xml | 32 +++++ tests/storagevolxml2argvdata/vol-qcow2-lazy.xml | 35 +++++ tests/storagevolxml2argvtest.c | 2 + tests/storagevolxml2xmlin/vol-qcow2-1.1.xml | 32 +++++ tests/storagevolxml2xmlin/vol-qcow2-lazy.xml | 35 +++++ tests/storagevolxml2xmlout/vol-qcow2-1.1.xml | 33 +++++ tests/storagevolxml2xmlout/vol-qcow2-lazy.xml | 35 +++++ tests/storagevolxml2xmltest.c | 2 + 30 files changed, 737 insertions(+), 61 deletions(-) create mode 100644 docs/schemas/storagefilefeatures.rng create mode 100644 tests/storagevolxml2argvdata/qcow2-1.1.argv create mode 100644 tests/storagevolxml2argvdata/qcow2-lazy.argv create mode 100644 tests/storagevolxml2argvdata/vol-qcow2-1.1.xml create mode 100644 tests/storagevolxml2argvdata/vol-qcow2-lazy.xml create mode 100644 tests/storagevolxml2xmlin/vol-qcow2-1.1.xml create mode 100644 tests/storagevolxml2xmlin/vol-qcow2-lazy.xml create mode 100644 tests/storagevolxml2xmlout/vol-qcow2-1.1.xml create mode 100644 tests/storagevolxml2xmlout/vol-qcow2-lazy.xml -- 1.8.1.5

4 13

[libvirt] [PATCH] Get rid of useless VIR_STORAGE_FILE_FEATURE_NONE
by Ján Tomko 24 Jun '13

24 Jun '13

It's not used anywhere except for the switch in virStorageBackendCreateQemuImgOpts, where leaving it in causes a dead code coverity warning and omitting it breaks compilation because of unhandled enum value. Introduced by 6298f74. --- Pushed as trivial. src/storage/storage_backend.c | 2 +- src/util/virstoragefile.h | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c index 27a0a4f..ae25c89 100644 --- a/src/storage/storage_backend.c +++ b/src/storage/storage_backend.c @@ -666,7 +666,7 @@ virStorageBackendCreateQemuImgOpts(char **opts, goto error; } break; - case VIR_STORAGE_FILE_FEATURE_NONE: + case VIR_STORAGE_FILE_FEATURE_LAST: ; } diff --git a/src/util/virstoragefile.h b/src/util/virstoragefile.h index a848fd0..4cb47e6 100644 --- a/src/util/virstoragefile.h +++ b/src/util/virstoragefile.h @@ -53,8 +53,7 @@ enum virStorageFileFormat { VIR_ENUM_DECL(virStorageFileFormat); enum virStorageFileFeature { - VIR_STORAGE_FILE_FEATURE_NONE = -1, - VIR_STORAGE_FILE_FEATURE_LAZY_REFCOUNTS, + VIR_STORAGE_FILE_FEATURE_LAZY_REFCOUNTS = 0, VIR_STORAGE_FILE_FEATURE_LAST }; -- 1.8.1.5

1 0

[libvirt] Investigate VM via Libvirt API
by Yaniv Hadad 23 Jun '13

23 Jun '13

Hi All, I am Java developer that want to start working with Libvirt API. My first target is to investigate Host + all his instances. (CPU,Storage,Network,State,Name..etc.) Can some one give me good code example or article for that purpose. I prefer to use Java , but , python is also good for this target Thanks Yaniv Hadad Servers & Network Group, IBM R&D Labs in Israel Software Devloper yanivh(a)il.ibm.com, +972-4-829-65947 Fax: +972-4-829-6111, Cell: +972-50-4078908

2 2

[libvirt] [PATCH 0/2] Implement virConnectGetSysinfo in libxl and xen drivers
by Jim Fehlig 21 Jun '13

21 Jun '13

While discussing a recent libxl patch, we realized virConnectGetSysinfo was never implemented in the libxl and legacy xen drivers. This small series provides an implementation for these drivers. Jim Fehlig (2): libxl: Implement virConnectGetSysinfo xen: Implement virConnectGetSysinfo src/libxl/libxl_conf.h | 1 + src/libxl/libxl_driver.c | 29 +++++++++++++++++++++++++++++ src/xen/xen_driver.c | 37 ++++++++++++++++++++++++++++++++++++- 3 files changed, 66 insertions(+), 1 deletions(-) -- 1.7.7

2 5