- Devel - libvirt List Archives

[libvirt] Libvirt : Bootstrap fails for local gnulib
by chandrashekar shastri 03 Jul '13

03 Jul '13

Hi All, The Libvirt compliation fails to bootstarp for local gnulib. We do not have outbound access for the test machines. So, we ll pull the gnulib from and copy to the test machines. When we run ./bootstrap --no-git --gnulib-srcdir=/path/to/local, below is the error: ./bootstrap: Bootstrapping from checked-out libvirt sources... ./bootstrap: consider installing git-merge-changelog from gnulib ./bootstrap: getting gnulib files... fatal: Needed a single revision Unable to find current revision in submodule path '.gnulib' If we run autogen.sh it tries to pull from git though the $GNULIB_SRCDIR is exported with the local gnulib. ./autogen.sh '--no-git' I am going to run ./configure with no arguments - if you wish to pass any to it, please specify them on the ./autogen.sh command line. running bootstrap --no-git... ./bootstrap: Bootstrapping from checked-out libvirt sources... ./bootstrap: consider installing git-merge-changelog from gnulib ./bootstrap: getting gnulib files... fatal: Unable to look up git.sv.gnu.org (port 9418) (Name or service not known) Unable to fetch in submodule path '.gnulib' Failed to bootstrap, please investigate. Please provide us the workaround for the same. Thanks, Chandrashekar

2 2

[libvirt] [PATCH] maint: update to latest gnulib
by Eric Blake 03 Jul '13

03 Jul '13

The latest mingw headers on Fedora 19 fail to build with gnulib without an update. Meanwhile, now that upstream gnulib has better handling of -W probing for clang, we can drop some of our own solutions in favor of upstream; thus this reverts commit c1634100, "Correctly detect warning flags with clang". * .gnulib: Update to latest, for mingw and clang. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Pushing under the build-breaker rule. * .gnulib a363f4e...f40e61e (41): > update from texinfo > ignore-value: port to gcc -pedantic > extern-inline: port to gcc -std=c89 > doc: document extern-inline > doc: chatter less > fflush, fseeko: port to musl cross-compiles > msvc-inval: port to mingw-w64 > getcwd-lgpl: port to Tru64 > autoupdate > tests: port large-fd POSIX spawn tests to OS X > autoupdate > tests/nap.h: use an adaptive delay to avoid ctime update issues > sig2str: port to C++ > docs: mention cygwin shortcoming in <sys/un.h> > vasnprintf: silence mingw compiler warning > c-ctype, regex, verify: port to gcc -std=c90 -pedantic > regex: adapt to locking regime instead of depending on pthread > getgroups: document portability issues > test-lchown, test-chown: also skip test if lchown/chown fails with EPERM > regex: fix dfa race in multithreaded uses > malloca: port to compilers that reject size-zero arrays > parse-datetime, tests: don't use "string" + int > argmatch: port to C++ > argp: typo fix > autoupdate > manywarnings: update for GCC 4.8.0 > spawn-tests, sys_socket-tests, sys_wait-tests: port to clang > getaddrinfo-tests: port --enable-gcc-warnings to clang > thread: port --enable-gcc-warnings to clang > stdio: use __REDIRECT for fwrite, fwrite_unlocked > stdio: port --enable-gcc-warnings to clang > sig2str: port --enable-gcc-warnings to clang > obstack: port --enable-gcc-warnings to clang > memchr2: port --enable-gcc-warnings to clang > mbsstr: port --enable-gcc-warnings to clang > malloca: port --enable-gcc-warnings to clang > inttostr: port --enable-gcc-warnings to clang > warnings: port to clang > quotearg: do not read beyond end of buffer > lock: work around pthread recursive mutexes bug in Mac OS X 10.6 > mkdir-p: remove assumptions about umask and mode .gnulib | 2 +- m4/virt-compile-warnings.m4 | 22 ---------------------- 2 files changed, 1 insertion(+), 23 deletions(-) diff --git a/.gnulib b/.gnulib index a363f4e..f40e61e 160000 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit a363f4ed4a0e69187c97686ac44502c49c7f4b3d +Subproject commit f40e61ea0c4940b027aade7dd48948aa93f133a4 diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4 index ce4e244..c6794b7 100644 --- a/m4/virt-compile-warnings.m4 +++ b/m4/virt-compile-warnings.m4 @@ -60,18 +60,6 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[ # gcc 4.4.6 complains this is C++ only; gcc 4.7.0 implies this from -Wall dontwarn="$dontwarn -Wenum-compare" - # clang rather horribly ignores unknown warning flags by - # default. Thus to get gl_WARN_ADD to reliably detect - # flags, we need to set '-Werror -Wunknown-warning-option' - # in CFLAGS while probing support - WARN_CFLAGS= - orig_CFLAGS="$CFLAGS" - gl_WARN_ADD([-Wunknown-warning-option]) - if test -n "$WARN_CFLAGS" ; then - WARN_CFLAGS= - CFLAGS="-Werror -Wunknown-warning-option $CFLAGS" - fi - # gcc 4.2 treats attribute(format) as an implicit attribute(nonnull), # which triggers spurious warnings for our usage AC_CACHE_CHECK([whether gcc -Wformat allows NULL strings], @@ -197,13 +185,6 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[ dnl gl_WARN_ADD([-fstack-protector]) gl_WARN_ADD([-fstack-protector-all]) gl_WARN_ADD([--param=ssp-buffer-size=4]) - dnl Even though it supports it, clang complains about - dnl use of --param=ssp-buffer-size=4 unless used with - dnl the -c arg. It doesn't like it when used with args - dnl that just link together .o files. Unfortunately - dnl we can't avoid that with automake, so we must turn - dnl off the following clang specific warning - gl_WARN_ADD([-Wno-unused-command-line-argument]) ;; *-*-freebsd*) dnl FreeBSD ships old gcc 4.2.1 which doesn't handle @@ -244,7 +225,4 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[ AC_DEFINE_UNQUOTED([BROKEN_GCC_WLOGICALOP], 1, [Define to 1 if gcc -Wlogical-op reports false positives on strchr]) fi - - # Remove stuff we set for clang - CFLAGS="$orig_CFLAGS" ]) -- 1.8.1.4

1 0

[libvirt] [PATCH glib] Add API to access device alias names
by Daniel P. Berrange 03 Jul '13

03 Jul '13

From: "Daniel P. Berrange" <berrange(a)redhat.com> Add gvir_config_domain_device_get_alias to read the <alias name="foo"/> XML in each device. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- libvirt-gconfig/libvirt-gconfig-domain-device.c | 9 +++++++++ libvirt-gconfig/libvirt-gconfig-domain-device.h | 2 ++ libvirt-gconfig/libvirt-gconfig.sym | 2 ++ 3 files changed, 13 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-device.c b/libvirt-gconfig/libvirt-gconfig-domain-device.c index 81e8765..7c97a0f 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-device.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-device.c @@ -109,3 +109,12 @@ unimplemented: g_debug("Parsing of '%s' device nodes is unimplemented", tree->name); return NULL; } + + +const gchar *gvir_config_domain_device_get_alias(GVirConfigDomainDevice *dev) +{ + g_return_val_if_fail(GVIR_CONFIG_IS_DOMAIN_DEVICE(dev), NULL); + + return gvir_config_object_get_attribute(GVIR_CONFIG_OBJECT(dev), + "alias", "name"); +} diff --git a/libvirt-gconfig/libvirt-gconfig-domain-device.h b/libvirt-gconfig/libvirt-gconfig-domain-device.h index de4c3f7..2344ebe 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-device.h +++ b/libvirt-gconfig/libvirt-gconfig-domain-device.h @@ -59,6 +59,8 @@ struct _GVirConfigDomainDeviceClass GType gvir_config_domain_device_get_type(void); +const gchar *gvir_config_domain_device_get_alias(GVirConfigDomainDevice *dev); + G_END_DECLS #endif /* __LIBVIRT_GCONFIG_DOMAIN_DEVICE_H__ */ diff --git a/libvirt-gconfig/libvirt-gconfig.sym b/libvirt-gconfig/libvirt-gconfig.sym index 2847570..32f57d9 100644 --- a/libvirt-gconfig/libvirt-gconfig.sym +++ b/libvirt-gconfig/libvirt-gconfig.sym @@ -560,6 +560,8 @@ LIBVIRT_GCONFIG_0.1.7 { gvir_config_domain_chardev_source_pty_get_path; gvir_config_domain_chardev_get_source; + + gvir_config_domain_device_get_alias; } LIBVIRT_GCONFIG_0.1.6; # .... define new API here using predicted next version number .... -- 1.8.2.1

2 1

[libvirt] [PATCH glib] Add APIs to access chardev source information
by Daniel P. Berrange 03 Jul '13

03 Jul '13

From: "Daniel P. Berrange" <berrange(a)redhat.com> Enable apps to determine the current source path of a chardev with a pty based source. --- .../libvirt-gconfig-domain-chardev-source-pty.c | 23 +++++++++++++++++++++ .../libvirt-gconfig-domain-chardev-source-pty.h | 2 ++ .../libvirt-gconfig-domain-chardev-source.c | 21 +++++++++++++++++++ libvirt-gconfig/libvirt-gconfig-domain-chardev.c | 24 ++++++++++++++++++++++ libvirt-gconfig/libvirt-gconfig-domain-chardev.h | 3 +++ libvirt-gconfig/libvirt-gconfig-object-private.h | 2 ++ libvirt-gconfig/libvirt-gconfig-object.c | 8 ++++++++ libvirt-gconfig/libvirt-gconfig.sym | 3 +++ 8 files changed, 86 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-pty.c b/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-pty.c index d24385e..a965417 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-pty.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-pty.c @@ -24,6 +24,7 @@ #include "libvirt-gconfig/libvirt-gconfig.h" #include "libvirt-gconfig/libvirt-gconfig-private.h" +#include "libvirt-gconfig/libvirt-gconfig-domain-chardev-source-private.h" #define GVIR_CONFIG_DOMAIN_CHARDEV_SOURCE_PTY_GET_PRIVATE(obj) \ (G_TYPE_INSTANCE_GET_PRIVATE((obj), GVIR_CONFIG_TYPE_DOMAIN_CHARDEV_SOURCE_PTY, GVirConfigDomainChardevSourcePtyPrivate)) @@ -82,6 +83,19 @@ GVirConfigDomainChardevSourcePty *gvir_config_domain_chardev_source_pty_new_from return GVIR_CONFIG_DOMAIN_CHARDEV_SOURCE_PTY(object); } +GVirConfigDomainChardevSource * +gvir_config_domain_chardev_source_pty_new_from_tree(GVirConfigXmlDoc *doc, + xmlNodePtr tree) +{ + GVirConfigObject *object; + + object = gvir_config_object_new_from_tree(GVIR_CONFIG_TYPE_DOMAIN_CHARDEV_SOURCE_PTY, + doc, NULL, tree); + + return GVIR_CONFIG_DOMAIN_CHARDEV_SOURCE(object); +} + + void gvir_config_domain_chardev_source_pty_set_path(GVirConfigDomainChardevSourcePty *pty, const char *path) { @@ -92,3 +106,12 @@ void gvir_config_domain_chardev_source_pty_set_path(GVirConfigDomainChardevSourc "path", path); } + + +const gchar * gvir_config_domain_chardev_source_pty_get_path(GVirConfigDomainChardevSourcePty *pty) +{ + g_return_val_if_fail(GVIR_CONFIG_IS_DOMAIN_CHARDEV_SOURCE_PTY(pty), NULL); + + return gvir_config_object_get_attribute(GVIR_CONFIG_OBJECT(pty), + "source", "path"); +} diff --git a/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-pty.h b/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-pty.h index 96e05bc..fab3811 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-pty.h +++ b/libvirt-gconfig/libvirt-gconfig-domain-chardev-source-pty.h @@ -65,6 +65,8 @@ GVirConfigDomainChardevSourcePty *gvir_config_domain_chardev_source_pty_new_from void gvir_config_domain_chardev_source_pty_set_path(GVirConfigDomainChardevSourcePty *pty, const char *path); +const gchar * gvir_config_domain_chardev_source_pty_get_path(GVirConfigDomainChardevSourcePty *pty); + G_END_DECLS #endif /* __LIBVIRT_GCONFIG_DOMAIN_CHARDEV_SOURCE_PTY_H__ */ diff --git a/libvirt-gconfig/libvirt-gconfig-domain-chardev-source.c b/libvirt-gconfig/libvirt-gconfig-domain-chardev-source.c index c34a3c8..bbb4c75 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-chardev-source.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-chardev-source.c @@ -23,6 +23,8 @@ #include <config.h> #include "libvirt-gconfig/libvirt-gconfig.h" +#include "libvirt-gconfig/libvirt-gconfig-private.h" +#include "libvirt-gconfig/libvirt-gconfig-domain-chardev-source-private.h" #define GVIR_CONFIG_DOMAIN_CHARDEV_SOURCE_GET_PRIVATE(obj) \ (G_TYPE_INSTANCE_GET_PRIVATE((obj), GVIR_CONFIG_TYPE_DOMAIN_CHARDEV_SOURCE, GVirConfigDomainChardevSourcePrivate)) @@ -47,3 +49,22 @@ static void gvir_config_domain_chardev_source_init(GVirConfigDomainChardevSource source->priv = GVIR_CONFIG_DOMAIN_CHARDEV_SOURCE_GET_PRIVATE(source); } + +G_GNUC_INTERNAL GVirConfigDomainChardevSource * +gvir_config_domain_chardev_source_new_from_tree(GVirConfigXmlDoc *doc, + xmlNodePtr tree) +{ + const gchar *type; + + g_return_val_if_fail(GVIR_CONFIG_IS_XML_DOC(doc), NULL); + g_return_val_if_fail(tree != NULL, NULL); + g_return_val_if_fail(tree->name != NULL, NULL); + + type = gvir_config_xml_get_attribute_content(tree, "type"); + + if (g_str_equal(type, "pty")) + return gvir_config_domain_chardev_source_pty_new_from_tree(doc, tree); + + g_debug("Unknown chardev source type: %s", type); + return NULL; +} diff --git a/libvirt-gconfig/libvirt-gconfig-domain-chardev.c b/libvirt-gconfig/libvirt-gconfig-domain-chardev.c index e20e597..bdb97dd 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-chardev.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-chardev.c @@ -24,6 +24,7 @@ #include "libvirt-gconfig/libvirt-gconfig.h" #include "libvirt-gconfig/libvirt-gconfig-private.h" +#include "libvirt-gconfig/libvirt-gconfig-domain-chardev-source-private.h" #define GVIR_CONFIG_DOMAIN_CHARDEV_GET_PRIVATE(obj) \ (G_TYPE_INSTANCE_GET_PRIVATE((obj), GVIR_CONFIG_TYPE_DOMAIN_CHARDEV, GVirConfigDomainChardevPrivate)) @@ -86,3 +87,26 @@ void gvir_config_domain_chardev_set_source(GVirConfigDomainChardev *chardev, prepend_prop(chardev_node, new_attr); } } + + +/** + * gvir_config_domain_chardev_get_source: + * @chardev: a #GVirConfigDomainChardev + * + * Gets the source for the chardev + * + * Returns: (transfer full): the chardev source + */ +GVirConfigDomainChardevSource * +gvir_config_domain_chardev_get_source(GVirConfigDomainChardev *chardev) +{ + GVirConfigXmlDoc *doc; + xmlNodePtr tree; + + doc = gvir_config_object_get_xml_doc(GVIR_CONFIG_OBJECT(chardev)); + tree = gvir_config_object_get_xml_node(GVIR_CONFIG_OBJECT(chardev)); + + return gvir_config_domain_chardev_source_new_from_tree(doc, + tree); +} + diff --git a/libvirt-gconfig/libvirt-gconfig-domain-chardev.h b/libvirt-gconfig/libvirt-gconfig-domain-chardev.h index 23a2f43..7fdccc3 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-chardev.h +++ b/libvirt-gconfig/libvirt-gconfig-domain-chardev.h @@ -63,6 +63,9 @@ GType gvir_config_domain_chardev_get_type(void); void gvir_config_domain_chardev_set_source(GVirConfigDomainChardev *chardev, GVirConfigDomainChardevSource *source); +GVirConfigDomainChardevSource * +gvir_config_domain_chardev_get_source(GVirConfigDomainChardev *chardev); + G_END_DECLS #endif /* __LIBVIRT_GCONFIG_DOMAIN_CHARDEV_H__ */ diff --git a/libvirt-gconfig/libvirt-gconfig-object-private.h b/libvirt-gconfig/libvirt-gconfig-object-private.h index 9baac66..2ec358b 100644 --- a/libvirt-gconfig/libvirt-gconfig-object-private.h +++ b/libvirt-gconfig/libvirt-gconfig-object-private.h @@ -30,6 +30,8 @@ GVirConfigObject *gvir_config_object_new_from_tree(GType type, GVirConfigXmlDoc *doc, const char *schema, xmlNodePtr tree); + +GVirConfigXmlDoc *gvir_config_object_get_xml_doc(GVirConfigObject *config); xmlNodePtr gvir_config_object_get_xml_node(GVirConfigObject *config); const char *gvir_config_object_get_node_content(GVirConfigObject *object, const char *node_name); diff --git a/libvirt-gconfig/libvirt-gconfig-object.c b/libvirt-gconfig/libvirt-gconfig-object.c index 9e3b5f2..8971a5b 100644 --- a/libvirt-gconfig/libvirt-gconfig-object.c +++ b/libvirt-gconfig/libvirt-gconfig-object.c @@ -274,6 +274,14 @@ const gchar *gvir_config_object_get_schema(GVirConfigObject *config) return config->priv->schema; } + +G_GNUC_INTERNAL GVirConfigXmlDoc * +gvir_config_object_get_xml_doc(GVirConfigObject *config) +{ + return config->priv->doc; +} + + /* FIXME: will we always have one xmlNode per GConfig object? */ /* FIXME: need to return the right node from subclasses */ /* NB: the xmlNodePtr must not be freed by the caller */ diff --git a/libvirt-gconfig/libvirt-gconfig.sym b/libvirt-gconfig/libvirt-gconfig.sym index f8c7cdd..2847570 100644 --- a/libvirt-gconfig/libvirt-gconfig.sym +++ b/libvirt-gconfig/libvirt-gconfig.sym @@ -557,6 +557,9 @@ LIBVIRT_GCONFIG_0.1.7 { gvir_config_storage_pool_target_get_path; gvir_config_storage_pool_target_get_permissions; + + gvir_config_domain_chardev_source_pty_get_path; + gvir_config_domain_chardev_get_source; } LIBVIRT_GCONFIG_0.1.6; # .... define new API here using predicted next version number .... -- 1.8.2.1

2 1

[libvirt] [PATCH] Put virt-sanlock-cleanup into section 8
by Guido Günther 03 Jul '13

03 Jul '13

as indicates by the filename. --- tools/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/Makefile.am b/tools/Makefile.am index 1dac7c1..644a86d 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -99,7 +99,8 @@ virt-sanlock-cleanup: virt-sanlock-cleanup.in Makefile || (rm $@ && exit 1) && chmod +x $@ virt-sanlock-cleanup.8: virt-sanlock-cleanup.in $(top_srcdir)/configure.ac - $(AM_V_GEN)$(POD2MAN) --name VIRT-SANLOCK-CLEANUP $< $(srcdir)/$@ \ + $(AM_V_GEN)$(POD2MAN) --name VIRT-SANLOCK-CLEANUP --section=8 \ + $< $(srcdir)/$@ \ && if grep 'POD ERROR' $(srcdir)/$@ ; then \ rm $(srcdir)/$@; exit 1; fi -- 1.8.3.1

3 5

[libvirt] [PATCH 0/2] Finish dual graphics support
by Martin Kletzander 03 Jul '13

03 Jul '13

We added support for dula <graphics>, but there were places in the code which still needed to be adapted. Two tiny patches seem to fix it all. Tested, works fine. Martin Kletzander (2): qemu: Don't miss errors when changing graphics passwords qemu: Allow seamless migration for domains with multiple graphics src/qemu/qemu_migration.c | 29 ++++++++++++++++++----------- src/qemu/qemu_process.c | 6 +++--- 2 files changed, 21 insertions(+), 14 deletions(-) -- 1.8.2.1

3 6

[libvirt] How to get the host network stats
by Zhang, Yijing 03 Jul '13

03 Jul '13

Hello there, I want to find how to get the host's network stats by using libvirt. I found one from PHP API reference which is called libvirt_domain_interface_stats, I'm guessing it's for guest since it's 'domain'. However, I'm not really sure. Looking forward to hear the answers from you guys. Thank you, Tracey

3 2

[libvirt] [PATCH v3 00/12] Add user namespace support for libvirt lxc
by Gao feng 03 Jul '13

03 Jul '13

This patchset try to add userns support for libvirt lxc. Since userns is nearly completed in linux-3.9, the old kernel doesn't support userns, I add some New XML elements to let people decide if enable userns.The userns is enabled only when user configure the XML. The format of user namespace related XML file like below: <idmap> <uid start='0' target='1000' count='10'> <gid start='0' target='1000' count='10'> </idmap> it means the user in container (which uid:gid is 0:0) will be mapped to the user in host (uid:gid is 1000:1000), count is used to form an u/gid range: The users in container which uid in [start, start + count -1] will be mapped. You can have multiple lines to map differnet id ranges, caution, you must make sure the root user of container has been mapped. This patchset also does the below jobs. 1, Because the uninit userns has no right to create devices, we should create devices for container on host. 2, Changes the owner of fuse and tty device. Change from v2: 1, Mount tmpfs on /stateDir/domain.dev 2, Create devices under /stateDir/doamin.dev/ 3, Mount Move the /.oldroot/stateDir/doamin.dev/ on the /dev/ of container 4, Enhance the configuration, disallow the semi configuration Gao feng (12): LXC: Introduce New XML element for user namespace LXC: enable user namespace only when user set the uidmap LXC: sort the uidmap/gidmap of domain LXC: introduce virLXCControllerSetupUserns and lxcContainerSetID LXC: Creating devices for container on host side LXC: Move creating /dev/ptmx to virLXCControllerSetupDevPTS LXC: fuse: Change files owner to the root user of container LXC: controller: change the owner of tty devices to the root user of container LXC: controller: change the owner of /dev to the root user of container LXC: controller: change the owner of devices created on host LXC: controller: change the owner of /dev/pts and ptmx to the root of container LXC: introduce virLXCControllerChown docs/formatdomain.html.in | 23 ++++ docs/schemas/domaincommon.rng | 31 +++++ src/conf/domain_conf.c | 115 ++++++++++++++++++ src/conf/domain_conf.h | 22 ++++ src/lxc/lxc_container.c | 183 ++++++++++++++-------------- src/lxc/lxc_controller.c | 271 +++++++++++++++++++++++++++++++++++++++++- src/lxc/lxc_fuse.c | 6 + 7 files changed, 557 insertions(+), 94 deletions(-) -- 1.8.1.4

6 49

[libvirt] [PATCH] LXC: blkio: allow to setup weight_device
by Gao feng 03 Jul '13

03 Jul '13

libivrt lxc can only set generic weight for container, This patch allows user to setup per device blkio weigh for container. Signed-off-by: Gao feng <gaofeng(a)cn.fujitsu.com> --- src/lxc/lxc_cgroup.c | 26 ++++++++++++++++++++------ 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/src/lxc/lxc_cgroup.c b/src/lxc/lxc_cgroup.c index 5c8acb3..4443b83 100644 --- a/src/lxc/lxc_cgroup.c +++ b/src/lxc/lxc_cgroup.c @@ -123,21 +123,35 @@ cleanup: static int virLXCCgroupSetupBlkioTune(virDomainDefPtr def, virCgroupPtr cgroup) { - int ret = -1; + int i, rc; if (def->blkio.weight) { - int rc = virCgroupSetBlkioWeight(cgroup, def->blkio.weight); + rc = virCgroupSetBlkioWeight(cgroup, def->blkio.weight); if (rc != 0) { virReportSystemError(-rc, _("Unable to set Blkio weight for domain %s"), def->name); - goto cleanup; + return -1; } } - ret = 0; -cleanup: - return ret; + if (def->blkio.ndevices) { + for (i = 0; i < def->blkio.ndevices; i++) { + virBlkioDeviceWeightPtr dw = &def->blkio.devices[i]; + if (!dw->weight) + continue; + rc = virCgroupSetBlkioDeviceWeight(cgroup, dw->path, dw->weight); + if (rc != 0) { + virReportSystemError(-rc, + _("Unable to set io device weight " + "for domain %s"), + def->name); + return -1; + } + } + } + + return 0; } -- 1.8.1.4

2 1

[libvirt] Memory access API
by Marek Marczykowski-Górecki 03 Jul '13

03 Jul '13

Hi, Is there any zero-copy VM memory access API in libvirt? I see only virDomainMemoryPeek function, which copy some memory from VM and do not permit VM memory modifications. What I'm looking for is xen xc_map_foreign_pages or xc_gnttab_map_domain_grant_refs equivalent/wrapper. IOW map memory pages to dom0 address space, without copy. I know that not every hypervisor supports it, but it is useful to build a high-performance communication channel on top of it. -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab

2 1