- Devel - libvirt List Archives

[libvirt] [PATCH 0/9] Fix corner cases in nodedev detach and reattach
by Jiri Denemark 20 Jan '14

20 Jan '14

https://bugzilla.redhat.com/show_bug.cgi?id=1046919 The first two patches fix bugs in PCI device handling code, the third patch provides a nice error message when nodedev detach is not supported and the rest are tests for testing the bugs fixed in the first two patches. Jincheng Miao (1): qemu: Don't detach devices if passthrough doesn't work Jiri Denemark (8): pci: Make reattach work for unbound devices pci: Fix failure paths in detach virpcitest: Show PCI device tested by each test pci: Publish some internal code for virpcitest virpcimock: Mock /sys/bus/pci/drivers_probe virpcitest: More tests for device detach and reattach virpcimock: Add PCI driver which always fails virpcitest: Test virPCIDeviceDetach failure src/libvirt_private.syms | 2 + src/qemu/qemu_driver.c | 32 +++++--- src/util/virpci.c | 121 +++++++++++++++++----------- src/util/virpci.h | 5 ++ tests/virpcimock.c | 76 ++++++++++++------ tests/virpcitest.c | 199 ++++++++++++++++++++++++++++++++++++++++++++++- 6 files changed, 355 insertions(+), 80 deletions(-) -- 1.8.5.3

2 21

[libvirt] [PATCH 0/6] Add BlkIO and CPU/mem stat API implementations for lxc
by Thorsten Behrens 20 Jan '14

20 Jan '14

This patch set adds block io, memory and domain cpu statistics API slot implementations to the LXC driver, in order to get linux container monitoring and accounting a bit closer to qemu standards. The last patch is a tad quirky (happy to hear suggestions on alternative ways), in that it widens the permissible value set at the .domainBlockStats slot: for lxc guests, it is relatively likely to have zero disk devices, since host filesystems can be used via passthrough bind mounts. Therefore, passing the null ptr or the zero-length string as device path, is interpreted as 'return summary stats for the entire domains's block io'. Thorsten Behrens (6): Add util virCgroupGetBlkioIo*Serviced methods. Implement domainMemoryStats API slot for LXC driver. Make qemuGetDomainTotalCPUStats a virCgroup function. Implement domainGetCPUStats for lxc driver. Implemet lxcDomainBlockStats for lxc driver Widening API change - accept empty path for virDomainBlockStats src/libvirt.c | 1 - src/libvirt_private.syms | 3 + src/lxc/lxc_driver.c | 245 ++++++++++++++++++++++++++++++++++++++++++ src/qemu/qemu_driver.c | 56 +--------- src/remote/remote_driver.c | 2 + src/test/test_driver.c | 2 + src/util/vircgroup.c | 261 +++++++++++++++++++++++++++++++++++++++++++++ src/util/vircgroup.h | 17 +++ src/xen/xen_driver.c | 2 + 9 files changed, 536 insertions(+), 53 deletions(-) -- 1.8.4

2 14

[libvirt] Help out
by Giorgio Zoppi 20 Jan '14

20 Jan '14

Hi all, how could I help out? Is there a bug list or a todo list? Are u able to pin a virtualization sandbox to a given processor? Best Regards, Giorgio

2 1

[libvirt] [libvirt-glib] Fix GVirConfigDomainTimerPit parent class/object
by Christophe Fergeau 18 Jan '14

18 Jan '14

GVirConfigDomainTimerPit is correctly define as inheriting from GVirConfigDomainTimer in the G_DEFINE_TYPE macro, but it only embeds GVirConfigObject/GVirConfigObjectClass structs. This is an ABI break as this changes the size of the GVirConfigDomainTimerPit/GVirConfigDomainTimerPitClass structs However, since these structs only have non-public members, users of the library will not be trying to access fields of the struct past the first field (which is the one which changed size). This would also be an issue if anything had subclassed GVirConfigDomainTimerPit, which is unlikely at this point. All in all, it's imo more convenient to silently fix this without an soname bump. I've tested that GNOME Boxes built with an older version of libvirt-gconfig still generates the correct GVirConfigDomainTimerPit elements when using a version of libvirt-gconfig with this patch. --- libvirt-gconfig/libvirt-gconfig-domain-timer-pit.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-timer-pit.h b/libvirt-gconfig/libvirt-gconfig-domain-timer-pit.h index b644c52..7802ac4 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-timer-pit.h +++ b/libvirt-gconfig/libvirt-gconfig-domain-timer-pit.h @@ -42,7 +42,7 @@ typedef struct _GVirConfigDomainTimerPitClass GVirConfigDomainTimerPitClass; struct _GVirConfigDomainTimerPit { - GVirConfigObject parent; + GVirConfigDomainTimer parent; GVirConfigDomainTimerPitPrivate *priv; @@ -51,7 +51,7 @@ struct _GVirConfigDomainTimerPit struct _GVirConfigDomainTimerPitClass { - GVirConfigObjectClass parent_class; + GVirConfigDomainTimerClass parent_class; gpointer padding[20]; }; -- 1.8.4.2

2 1

[libvirt] [libvirt-glib 0/4] Add API to build <timer name="hpet" present="no"/>
by Christophe Fergeau 18 Jan '14

18 Jan '14

This series allows to generate <timer name="hpet" present="no"/> using libvirt-gconfig. This is a prerequisite for fixing this Boxes bug https://bugzilla.gnome.org/show_bug.cgi?id=722293 Patch 2/4 doesn't anything to do in this series, but this was easy to implement after 1/4 so I slipped it there. Christophe

2 10

[libvirt] [PATCH] doc: Add missing space in <clock> documentation
by Christophe Fergeau 17 Jan '14

17 Jan '14

--- Pushed under the trivial rule. docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 68860ef..80d9495 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -1348,7 +1348,7 @@ </dl> <p> A <code>clock</code> may have zero or more - <code>timer</code>sub-elements. <span class="since">Since + <code>timer</code> sub-elements. <span class="since">Since 0.8.0</span> </p> </dd> -- 1.8.4.2

1 0

[libvirt] [PATCH] build: add $(prefix) to SYSTEMD_UNIT_DIR
by Laine Stump 17 Jan '14

17 Jan '14

I noticed this problem when adding systemd support to netcf, because I setup the configure.ac to automatically prefer using systemd over initscripts when possible - although I had copied the install-data-local target from the example of libvirt's "libvirt-guests" service more or less verbatim, "make distcheck" would fail because it was trying to install the service file directly into /lib/systemd/system rather than into /home/user/some/unimportant/name/lib/systemd/system. This is caused by the install/uninstall rules for the systemd unit files relying on $(DESTDIR) pointing the installed files to the right place, but in reality $(DESTDIR) is empty during this part of make distcheck - it instead sets $(prefix) with the toplevel directory used for its test build/install/uninstall cycle. (This problem hasn't been seen when running "make distcheck" in libvirt because libvirt will never build/install systemd support unless explicitly told to do so on the configure commandline, and "make distcheck" doesn't put the "--with-initscript=..." option on the configure commandline.) I verified that the same problem does exist in libvirt by modifying libvirt's configure.ac to set: init_systemd=yes with_init_script=systemd+redhat This forces a build/install of the systemd unit files during distcheck, which yields an error like this: /usr/bin/install -c -m 644 virtlockd.service \ /lib/systemd/system/ libtool: install: warning: relinking `libvirt-qemu.la' /usr/bin/install: cannot remove '/lib/systemd/system/virtlockd.service': Permission denied make[4]: *** [install-systemd] Error 1 After adding $(prefix) to all the definitions of SYSTEMD_UNIT_DIR, make distcheck now completes successfully with the modified configure.ac, and the above lines change to something like this: /usr/bin/install -c -m 644 virtlockd.service \ /home/laine/devel/libvirt/libvirt-1.2.1/_inst/lib/systemd/system/ --- daemon/Makefile.am | 4 ++-- src/Makefile.am | 4 ++-- tools/Makefile.am | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/daemon/Makefile.am b/daemon/Makefile.am index e5c5db8..00221ab 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -1,6 +1,6 @@ ## Process this file with automake to produce Makefile.in -## Copyright (C) 2005-2013 Red Hat, Inc. +## Copyright (C) 2005-2014 Red Hat, Inc. ## ## This library is free software; you can redistribute it and/or ## modify it under the terms of the GNU Lesser General Public @@ -387,7 +387,7 @@ endif ! LIBVIRT_INIT_SCRIPT_UPSTART if LIBVIRT_INIT_SCRIPT_SYSTEMD -SYSTEMD_UNIT_DIR = /lib/systemd/system +SYSTEMD_UNIT_DIR = $(prefix)/lib/systemd/system BUILT_SOURCES += libvirtd.service install-init-systemd: install-sysconfig libvirtd.service diff --git a/src/Makefile.am b/src/Makefile.am index 57e163f..8f77658 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1,6 +1,6 @@ ## Process this file with automake to produce Makefile.in -## Copyright (C) 2005-2013 Red Hat, Inc. +## Copyright (C) 2005-2014 Red Hat, Inc. ## ## This library is free software; you can redistribute it and/or ## modify it under the terms of the GNU Lesser General Public @@ -2220,7 +2220,7 @@ EXTRA_DIST += \ if WITH_LIBVIRTD if LIBVIRT_INIT_SCRIPT_SYSTEMD -SYSTEMD_UNIT_DIR = /lib/systemd/system +SYSTEMD_UNIT_DIR = $(prefix)/lib/systemd/system BUILT_SOURCES += virtlockd.service virtlockd.socket DISTCLEANFILES += virtlockd.service virtlockd.socket diff --git a/tools/Makefile.am b/tools/Makefile.am index 256a8f3..6847f13 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -1,4 +1,4 @@ -## Copyright (C) 2005-2013 Red Hat, Inc. +## Copyright (C) 2005-2014 Red Hat, Inc. ## ## This library is free software; you can redistribute it and/or ## modify it under the terms of the GNU Lesser General Public @@ -306,7 +306,7 @@ libvirt-guests.init: libvirt-guests.init.in libvirt-guests.sh EXTRA_DIST += libvirt-guests.service.in -SYSTEMD_UNIT_DIR = /lib/systemd/system +SYSTEMD_UNIT_DIR = $(prefix)/lib/systemd/system if LIBVIRT_INIT_SCRIPT_SYSTEMD install-systemd: libvirt-guests.service install-sysconfig libvirt-guests.sh -- 1.8.4.2

2 1

[libvirt] [libvirt-security-notice PATCH] templates: Include charset info in <head/>
by Michal Privoznik 17 Jan '14

17 Jan '14

Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- templates/lsn2html.xsl | 3 ++- templates/lsn2indexhtml.xsl | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/templates/lsn2html.xsl b/templates/lsn2html.xsl index aaac6e8..46501ab 100644 --- a/templates/lsn2html.xsl +++ b/templates/lsn2html.xsl @@ -21,7 +21,8 @@ <html> <head> <title>Libvirt Security Notice: LSN-<xsl:value-of select="lsn:id"/></title> - <link rel="stylesheet" type="text/css" href="../main.css" /> + <link rel="stylesheet" type="text/css" href="../main.css" /> + <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /> </head> <body> <h1>Libvirt Security Notice: LSN-<xsl:value-of select="lsn:id"/></h1> diff --git a/templates/lsn2indexhtml.xsl b/templates/lsn2indexhtml.xsl index 3573ac3..2e6f9c2 100644 --- a/templates/lsn2indexhtml.xsl +++ b/templates/lsn2indexhtml.xsl @@ -12,7 +12,8 @@ <html> <head> <title>Libvirt Security Notice Index</title> - <link rel="stylesheet" type="text/css" href="main.css" /> + <link rel="stylesheet" type="text/css" href="main.css" /> + <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /> </head> <body> <h1>Libvirt Security Notice Index</h1> -- 1.8.5.2

2 2

[libvirt] Libvirt Security Notices
by Daniel P. Berrange 17 Jan '14

17 Jan '14

Hi Folks, After much work I've finally got a formal Libvirt Security Notice (LSN) setup worked out. Every security issue that is reported & confirmed on the libvirt security mailing list will have a formal LSN prepared. This is a simple XML document containing metadata & other information about the issue we deem relevant. Initially this will be private if there is an embargo applied. Once the issue is made public, will the LSN notices will be added to the following public GIT repository: http://libvirt.org/git/?p=libvirt-security-notice.git;a=summary This GIT repository is used to populate a new public website http://security.libvirt.org/ A plain text rendering of the LSN will also be sent to the mailing list libvirt-announce(a)redhat.com Every issue is available in text, html and xml formats eg http://security.libvirt.org/2014/0002.txt http://security.libvirt.org/2014/0002.html http://security.libvirt.org/2014/0002.xml If anyone backports a fix for a security issue to various -maint branches, the LSN notice in GIT should be updated with GIT hash of the backports. If a maint release is created, the tag should also be added to the LSN. After countless hours investigation I have populated the repository with a list of all historical issues in libvirt that I'm aware of. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

2 1

[libvirt] Add GVirConfigDomainDiskDriver
by Christophe Fergeau 17 Jan '14

17 Jan '14

Hey, I wanted to add support in libvirt-gconfig for the 'discard' attribute of the disk driver node. If I follow the way the API is currently done, it would be an additional method to GVirConfigDomainDisk. However, there are quite a few attributes attached to the disk driver node, so I felt it was preferrable to have a dedicated GVirConfigDomainDiskDriver class. This also matches better other places of libvirt-gconfig API. I've implemented support for most of the attributes of the disk driver node, as a result the corresponding methods in GVirConfigDomainDisk have been deprecated. Christophe

4 18