- Devel - libvirt List Archives

[libvirt] Parse commandline for -device option
by Hong-Hua.Yin＠freescale.com 04 Jun '14

04 Jun '14

Hi Maintainers, Currently libvirt could only parse commandline for several legacy devices. For example, -pcidevice: qemuParseCommandLinePCI() -usbdevice: qemuParseCommandLineUSB() It also provides test cases for host device assignment. DO_TEST("hostdev-usb-address"); DO_TEST("hostdev-pci-address"); But for other hostdev with -device option, it failed to convert into <hostdev> tag. -device vfio-pci,host=06:12.5,id=hostdev0,bus=pci.0,addr=0x3 $ virsh domxml-from-native qemu-argv kvm.args >kvm.xml <qemu:commandline> <qemu:arg value='-device'/> <qemu:arg value='vfio-pci,host=06:12.5,id=hostdev0,bus=pci.0,addr=0x3'/> </qemu:commandline> Expected XML file should like below: <hostdev mode='subsystem' type='pci' managed='yes'> <driver name='vfio'/> <source> <address domain='0x0000' bus='0x06' slot='0x12' function='0x5'/> </source> </hostdev> Maybe it is not very critical. Is it complicated to add support to -device option in function qemuParseCommandLine()? Do you have any thought or plan about it? Best Regards, Olivia

3 2

[libvirt] Problem connecting to hypervisor.
by Vikas Kokare 04 Jun '14

04 Jun '14

I am trying to establish a connection (using virsh command) to a couple of hypervisor hosts, both on SLES 11.3 environments. The host from where i am making both the connections is a SLES 10.4 instance. *kvmh911351246:~ # virsh -c qemu+ssh://9.113.51.247:22/system <http://9.113.51.247:22/system>libvir: XML-RPC error : authentication requirederror: failed to connect to the hypervisor* The SSH authentication to hypervisor host 9.113.51.247 has already been established. *kvmh911351246:~ # ssh root(a)9.113.51.247 <root(a)9.113.51.247>Last login: Tue Jun 3 11:31:56 2014 from scm-kvmh2-rhel6 SLES11-51-247:~ #* Hence the cause of the authentication failure is not clear. The second connection to another SLES 11.3 host looks like *virsh # connect qemu+ssh://9.121.58.19:22/system <http://9.121.58.19:22/system> bash: socat: command not foundlibvir: Remote error : socket closed unexpectedlyerror: Failed to connect to the hypervisor* where the cause of the error is entirely different. The libvirt packages available on these environments are *9.113.51.247 (SLES 11.3)* *libvirt-cim-0.5.12-0.7.16libvirt-1.0.5.1-0.7.10libvirt-python-1.0.5.1-0.7.10libvirt-client-32bit-1.0.5.1-0.7.10 libvirt-lock-sanlock-1.0.5.1-0.7.10libvirt-client-1.0.5.1-0.7.10* *9.121.58.19 (SLES 11.3)* *libvirt-cim-0.5.12-0.7.16libvirt-client-1.0.5.1-0.7.10libvirt-python-1.0.5.1-0.7.10 libvirt-1.0.5.1-0.7.10* *9.113.51.246 ( SLES 10.4)* *libvirt-python-0.3.3-18.22.1libvirt-devel-0.3.3-18.22.1libvirt-0.3.3-18.22.1* How can these connection failures be debugged? Is there a way to know more information about them?

2 1

[libvirt] [PATCH] virnuma: Check for numa_bitmask_isbitset presence
by Michal Privoznik 04 Jun '14

04 Jun '14

On some systems, libnuma can be present but it's so ancient that it misses some symbols that virNumaGetDistances() needs. To be more precise: numa_bitmask_isbitset() and numa_nodes_ptr are the symbols in question. Fortunately, they were both introduced in the same release so it's sufficient for us to check for only one of them. And the winner is numa_bitmask_isbitset(). Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Notes: While this is a build breaker, it's not that critical. Come on - who runs libvirt from git on stable enterprise systems? I'm sending it to know if the check for numa_bitmask_isbitset() is in the right place or should be moved to a different file. m4/virt-numactl.m4 | 4 ++ src/util/virnuma.c | 135 +++++++++++++++++++++++++++-------------------------- 2 files changed, 73 insertions(+), 66 deletions(-) diff --git a/m4/virt-numactl.m4 b/m4/virt-numactl.m4 index 1dcb029..fa66d24 100644 --- a/m4/virt-numactl.m4 +++ b/m4/virt-numactl.m4 @@ -19,6 +19,10 @@ dnl AC_DEFUN([LIBVIRT_CHECK_NUMACTL],[ LIBVIRT_CHECK_LIB([NUMACTL], [numa], [numa_available], [numa.h]) + AC_CHECK_LIB([numa], [numa_bitmask_isbitset], [have_numa_bitmask_isbitset=yes]) + if test "$have_numa_bitmask_isbitset" = "yes"; then + AC_DEFINE_UNQUOTED([HAVE_NUMA_BITMASK_ISBITSET], 1, [whether numa_bitmask_isbitset is available]) + fi ]) AC_DEFUN([LIBVIRT_RESULT_NUMACTL],[ diff --git a/src/util/virnuma.c b/src/util/virnuma.c index 042844b..f979f49 100644 --- a/src/util/virnuma.c +++ b/src/util/virnuma.c @@ -217,61 +217,6 @@ virNumaGetMaxNode(void) /** - * virNumaGetDistances: - * @node: identifier of the requested NUMA node - * @distances: array of distances to sibling nodes - * @ndistances: size of @distances - * - * Get array of distances to sibling nodes from @node. If a - * distances[x] equals to zero, the node x is not enabled or - * doesn't exist. As a special case, if @node itself refers to - * disabled or nonexistent NUMA node, then @distances and - * @ndistances are set to NULL and zero respectively. - * - * The distances are a bit of magic. For a local node the value - * is 10, for remote it's typically 20 meaning that time penalty - * for accessing a remote node is two time bigger than when - * accessing a local node. - * - * Returns 0 on success, -1 otherwise. - */ -int -virNumaGetDistances(int node, - int **distances, - int *ndistances) -{ - int ret = -1; - int max_node; - size_t i; - - if (!numa_bitmask_isbitset(numa_nodes_ptr, node)) { - VIR_DEBUG("Node %d does not exist", node); - *distances = NULL; - *ndistances = 0; - return 0; - } - - if ((max_node = virNumaGetMaxNode()) < 0) - goto cleanup; - - if (VIR_ALLOC_N(*distances, max_node) < 0) - goto cleanup; - - *ndistances = max_node + 1; - - for (i = 0; i<= max_node; i++) { - if (!numa_bitmask_isbitset(numa_nodes_ptr, i)) - continue; - - (*distances)[i] = numa_distance(node, i); - } - - ret = 0; - cleanup: - return ret; -} - -/** * virNumaGetNodeMemory: * @node: identifier of the requested NUMA node * @memsize: returns the total size of memory in the NUMA node @@ -443,17 +388,6 @@ virNumaGetNodeCPUs(int node ATTRIBUTE_UNUSED, _("NUMA isn't available on this host")); return -1; } - -int -virNumaGetDistances(int node ATTRIBUTE_UNUSED, - int **distances, - int *ndistances) -{ - *distances = NULL; - *ndistances = 0; - VIR_DEBUG("NUMA isn't available on this host"); - return 0; -} #endif @@ -469,3 +403,72 @@ virNumaGetMaxCPUs(void) { return NUMA_MAX_N_CPUS; } + + +#ifdef HAVE_NUMA_BITMASK_ISBITSET +/** + * virNumaGetDistances: + * @node: identifier of the requested NUMA node + * @distances: array of distances to sibling nodes + * @ndistances: size of @distances + * + * Get array of distances to sibling nodes from @node. If a + * distances[x] equals to zero, the node x is not enabled or + * doesn't exist. As a special case, if @node itself refers to + * disabled or nonexistent NUMA node, then @distances and + * @ndistances are set to NULL and zero respectively. + * + * The distances are a bit of magic. For a local node the value + * is 10, for remote it's typically 20 meaning that time penalty + * for accessing a remote node is two time bigger than when + * accessing a local node. + * + * Returns 0 on success, -1 otherwise. + */ +int +virNumaGetDistances(int node, + int **distances, + int *ndistances) +{ + int ret = -1; + int max_node; + size_t i; + + if (!numa_bitmask_isbitset(numa_nodes_ptr, node)) { + VIR_DEBUG("Node %d does not exist", node); + *distances = NULL; + *ndistances = 0; + return 0; + } + + if ((max_node = virNumaGetMaxNode()) < 0) + goto cleanup; + + if (VIR_ALLOC_N(*distances, max_node) < 0) + goto cleanup; + + *ndistances = max_node + 1; + + for (i = 0; i<= max_node; i++) { + if (!numa_bitmask_isbitset(numa_nodes_ptr, i)) + continue; + + (*distances)[i] = numa_distance(node, i); + } + + ret = 0; + cleanup: + return ret; +} +#else +int +virNumaGetDistances(int node ATTRIBUTE_UNUSED, + int **distances, + int *ndistances) +{ + *distances = NULL; + *ndistances = 0; + VIR_DEBUG("NUMA isn't available on this host"); + return 0; +} +#endif -- 2.0.0

2 1

[libvirt] [RFC] Atomic Operations
by Tucker DiNapoli 04 Jun '14

04 Jun '14

I'm working on job control which involves a lot of locking and unlocking, often for operations that could be done atomically. I use the existing atomic integer operations in viratomic.h where possible, but there are a lot of parameters involved in jobs (such as time, thread id's, progress information, etc) which don't fit in an integer. I have several ideas of ways to update the existing integer atomic operations to support more types. The easiest way (at least regarding code) would be to use an existing atomic operations library. My suggestion would be the libatomic_ops library, which is licensed under an MIT style license and could be added to the source tree as a git submodule (similar to the way gnulib is) or a specific version could be used and the library source itself added to the git repository. The library can be found at https://github.com/ivmai/libatomic_ops/ . The other way of augmenting atomic operations would be to extend the existing viratomic.h file to support additional types. Personally I have experience working with GCC atomic operations and could implement that myself, but I wouldn't be able to implement the windows versions. Again I think the easiest and most maintainable way of supporting atomic operations is via an external library, but I am not sure of the feasibility of adding another dependency to libvirt. In general atomic operations are an optimization, but they can help make multithreaded programming easier and I think libvirt would be enhanced by having more comprehensive support for atomic operations. Tucker DiNapoli

3 2

[libvirt] [libvirt-sandbox] virt-sandbox-service: fixed /lib/ into /usr/lib for searching unit files
by Cédric Bosdonnat 04 Jun '14

04 Jun '14

--- bin/virt-sandbox-service | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service index 2dcbfb8..9ed37e0 100755 --- a/bin/virt-sandbox-service +++ b/bin/virt-sandbox-service @@ -1071,7 +1071,7 @@ class CheckUnit(argparse.Action): src = "/etc/systemd/system/" + unit if os.path.exists(src): return src - src = "/lib/systemd/system/" + unit + src = "/usr/lib/systemd/system/" + unit if os.path.exists(src): return src return None -- 1.8.4.5

4 7

[libvirt] [PATCH] virnuma: Implement virNumaGetDistances stub for non-NUMA
by Michal Privoznik 04 Jun '14

04 Jun '14

In case the libvirt is built without numactl support, we're missing the virNumaGetDistances() stub so the linking fails: CCLD libvirt_lxc libvirt_lxc-nodeinfo.o: In function `virNodeCapsGetSiblingInfo': /home/zippy/tmp/libvirt.git/src/nodeinfo.c:1763: undefined reference to `virNumaGetDistances' collect2: error: ld returned 1 exit status make[3]: *** [libvirt_lxc] Error 1 The issue was introduced in 77c830d8c4. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Notes: Pushing under build-breaker and trivial rules. src/util/virnuma.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/util/virnuma.c b/src/util/virnuma.c index e8ceec8..042844b 100644 --- a/src/util/virnuma.c +++ b/src/util/virnuma.c @@ -443,6 +443,17 @@ virNumaGetNodeCPUs(int node ATTRIBUTE_UNUSED, _("NUMA isn't available on this host")); return -1; } + +int +virNumaGetDistances(int node ATTRIBUTE_UNUSED, + int **distances, + int *ndistances) +{ + *distances = NULL; + *ndistances = 0; + VIR_DEBUG("NUMA isn't available on this host"); + return 0; +} #endif -- 2.0.0

1 0

[libvirt] [libvirt-glib] spec: Move .vapi files to -devel RPMs
by Christophe Fergeau 04 Jun '14

04 Jun '14

.vapi files are only needed when building vala programs using libvirt-glib, so they belong to the -devel RPMs, not to the non-devel RPMs which only hold files needed at runtime. --- libvirt-glib.spec.in | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libvirt-glib.spec.in b/libvirt-glib.spec.in index f467767..202e624 100644 --- a/libvirt-glib.spec.in +++ b/libvirt-glib.spec.in @@ -162,28 +162,18 @@ rm -rf $RPM_BUILD_ROOT %if %{with_introspection} %{_libdir}/girepository-1.0/LibvirtGLib-1.0.typelib %endif -%if %{with_vala} -%{_datadir}/vala/vapi/libvirt-glib-1.0.vapi -%endif %files -n libvirt-gconfig %{_libdir}/libvirt-gconfig-1.0.so.* %if %{with_introspection} %{_libdir}/girepository-1.0/LibvirtGConfig-1.0.typelib %endif -%if %{with_vala} -%{_datadir}/vala/vapi/libvirt-gconfig-1.0.vapi -%endif %files -n libvirt-gobject %{_libdir}/libvirt-gobject-1.0.so.* %if %{with_introspection} %{_libdir}/girepository-1.0/LibvirtGObject-1.0.typelib %endif -%if %{with_vala} -%{_datadir}/vala/vapi/libvirt-gobject-1.0.deps -%{_datadir}/vala/vapi/libvirt-gobject-1.0.vapi -%endif %files devel %defattr(-,root,root,-) @@ -198,6 +188,9 @@ rm -rf $RPM_BUILD_ROOT %{_datadir}/gir-1.0/LibvirtGLib-1.0.gir %endif %{_datadir}/gtk-doc/html/Libvirt-glib +%if %{with_vala} +%{_datadir}/vala/vapi/libvirt-glib-1.0.vapi +%endif %files -n libvirt-gconfig-devel %defattr(-,root,root,-) @@ -212,6 +205,9 @@ rm -rf $RPM_BUILD_ROOT %{_datadir}/gir-1.0/LibvirtGConfig-1.0.gir %endif %{_datadir}/gtk-doc/html/Libvirt-gconfig +%if %{with_vala} +%{_datadir}/vala/vapi/libvirt-gconfig-1.0.vapi +%endif %files -n libvirt-gobject-devel %defattr(-,root,root,-) @@ -226,6 +222,10 @@ rm -rf $RPM_BUILD_ROOT %{_datadir}/gir-1.0/LibvirtGObject-1.0.gir %endif %{_datadir}/gtk-doc/html/Libvirt-gobject +%if %{with_vala} +%{_datadir}/vala/vapi/libvirt-gobject-1.0.deps +%{_datadir}/vala/vapi/libvirt-gobject-1.0.vapi +%endif %if %{with_python} %files python -- 1.9.3

2 2

[libvirt] [PATCH] build: fix race in vapi/ subdirectory
by Michael Catanzaro 04 Jun '14

04 Jun '14

libvirt-gobject-1.0.vapi depends on libvirt-gconfig-1.0.vapi --- vapi/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vapi/Makefile.am b/vapi/Makefile.am index 0154104..af10e98 100644 --- a/vapi/Makefile.am +++ b/vapi/Makefile.am @@ -17,7 +17,7 @@ libvirt-glib-1.0.vapi: $(top_builddir)/libvirt-glib/LibvirtGLib-1.0.gir --library libvirt-glib-1.0 \ $< -libvirt-gobject-1.0.vapi: $(top_builddir)/libvirt-gobject/LibvirtGObject-1.0.gir libvirt-glib-1.0.vapi +libvirt-gobject-1.0.vapi: $(top_builddir)/libvirt-gobject/LibvirtGObject-1.0.gir libvirt-glib-1.0.vapi libvirt-gconfig-1.0.vapi $(AM_V_GEN)$(VAPIGEN) \ --vapidir=$(builddir) \ --pkg gobject-2.0 \ -- 1.9.3

3 6

[libvirt] [PATCH v2 0/4] Testing libvirt XML -> libxl_domain_config conversion
by Daniel P. Berrange 03 Jun '14

03 Jun '14

Version 2 of: https://www.redhat.com/archives/libvir-list/2014-May/msg01102.html This tests the conversion of libvirt XML to libxl_domain_config objects by the libvirt libxl driver. Changed in v2: - Compare the parsed JSON object model instead of strcmp() on the string-ified JSON document - To cope with new additions between Xen 4.3 and 4.4 - Ignore case where actual JSON object has gained new keys. This copes with fact that '/c_info' gained a new key called 'pvh' in 4.4 - Ignore case where actual JSON value has changed from 'null' to a non-'null' value type. This copes with fact that the element at /b_info/device_model_version changed from 'null' to a specific value by default in 4.4. - Use libxl_domain_config_to_json instead of libxl_json.h functions, and disable test if running on Xen version which lacks this function (eg 4.2) - Isolate VNC port allocator from host TCP ports so a predictable VNC port is always in the config. Daniel P. Berrange (4): util: Introduce virJSONStringCompare for JSON doc comparisons util: Allow port allocator to skip bind() check tests: Add more test suite mock helpers libxl: Add a test suite for libxl option generator configure.ac | 2 + src/libvirt_private.syms | 1 + src/libxl/libxl_driver.c | 3 +- src/qemu/qemu_driver.c | 9 +- src/util/virjson.c | 185 ++++++++++++++++++++++++++++++++++ src/util/virjson.h | 22 +++++ src/util/virportallocator.c | 14 ++- src/util/virportallocator.h | 7 +- tests/Makefile.am | 25 ++++- tests/libxlxml2jsondata/minimal.json | 172 ++++++++++++++++++++++++++++++++ tests/libxlxml2jsondata/minimal.xml | 36 +++++++ tests/libxlxml2jsontest.c | 186 +++++++++++++++++++++++++++++++++++ tests/virfirewalltest.c | 4 +- tests/virmock.h | 54 +++++++--- tests/virmocklibxl.c | 87 ++++++++++++++++ tests/virportallocatortest.c | 4 +- tests/virsystemdtest.c | 4 +- 17 files changed, 786 insertions(+), 29 deletions(-) create mode 100644 tests/libxlxml2jsondata/minimal.json create mode 100644 tests/libxlxml2jsondata/minimal.xml create mode 100644 tests/libxlxml2jsontest.c create mode 100644 tests/virmocklibxl.c -- 1.9.3

2 8

[libvirt] [PATCH v2 0/2] Expose distance between host NUMA nodes
by Michal Privoznik 03 Jun '14

03 Jun '14

diff to v1: -slight change in the XML format -added description to distances value Michal Privoznik (2): virnuma: Introduce virNumaGetDistances virCaps: Expose distance between host NUMA nodes docs/schemas/capability.rng | 15 +++++++++++ src/conf/capabilities.c | 19 +++++++++++++- src/conf/capabilities.h | 13 +++++++++- src/libvirt_private.syms | 1 + src/libxl/libxl_conf.c | 4 +-- src/nodeinfo.c | 61 ++++++++++++++++++++++++++++++++++++++++++--- src/test/test_driver.c | 2 +- src/util/virnuma.c | 55 ++++++++++++++++++++++++++++++++++++++++ src/util/virnuma.h | 3 +++ src/xen/xend_internal.c | 3 ++- tests/vircapstest.c | 4 +-- 11 files changed, 169 insertions(+), 11 deletions(-) -- 2.0.0

2 4