- Devel - libvirt List Archives

[libvirt] [PATCH v2 00/24] Drop network driver lock
by Michal Privoznik 09 Mar '15

09 Mar '15

Yet another version. This time with: 1) Peter's review worked in 2) Even more patches, that allow even more parallelism. With my test program [1], I've been able to go from 56s to 23s. 1: https://www.redhat.com/archives/libvir-list/2015-February/msg01214.html Michal Privoznik (24): network_conf: Introduce virNetworkObjListForEach network_conf: Introduce virNetworkObjListGetNames network_conf: Introduce virNetworkObjListNumOfNetworks network_conf: Introduce virNetworkObjListPrune bridge_driver: Adapt to new virNetworkObjList accessors test_driver: Adapt to new virNetworkObjList accessors parallels_network: Adapt to new virNetworkObjList accessors network_conf: Turn virNetworkObjList into virObject network_conf: Turn struct _virNetworkObjList private network_conf: Make virNetworkObj actually virObject virNetworkObjList: Derive from virObjectLockableClass network_conf: Introduce virNetworkObjEndAPI bridge_driver: Use virNetworkObjEndAPI test_driver: Use virNetworkObjEndAPI parallels_network: Use virNetworkObjEndAPI network_conf: Introduce locked versions of lookup functions virNetworkObjListPtr: Make APIs self-locking virNetworkObjFindBy*: Return an reference to found object bridge_driver: Drop networkDriverLock() from almost everywhere test_driver: Drop testDriverLock() from almost everywhere parallels_network: Drop parallelsDriverLock() from everywhere. bridge_driver: Use more of networkObjFromNetwork virNetworkObjUnsetDefTransient: Lock object list if needed virNetworkObjFindBy*: Don't lock all networks in the list cfg.mk | 3 - src/conf/network_conf.c | 422 +++++++++++++++++++++++++------- src/conf/network_conf.h | 52 ++-- src/libvirt_private.syms | 13 +- src/network/bridge_driver.c | 500 ++++++++++++++------------------------ src/parallels/parallels_network.c | 135 +++------- src/test/test_driver.c | 185 +++----------- tests/networkxml2conftest.c | 4 +- tests/objectlocking.ml | 2 - 9 files changed, 634 insertions(+), 682 deletions(-) -- 2.0.5

3 58

[libvirt] [RFC PATCH v2 0/4] Enable spapr-pci-vfio-host-bridge controllers for VFIO passthrough support
by Shivaprasad G Bhat 09 Mar '15

09 Mar '15

The following series of patches enable spapr-pci-vfio-host-bridge controllers on PPC64-pseries machine which is required for supporting host device passthrough using VFIO. There were some initial enablement work on the same at http://www.redhat.com/archives/libvir-list/2013-September/msg00838.html. On pseries(ppc64), the vfio host devices(will refer as hostdevs here on) cannot be assigned to the default emulated pci-host-bus(phb) controller(like the default pci.0). The hostdevs goto spapr-pci-vfio-host-bridge. The hostdevs belonging to the same iommu group share the same spapr-pci-vfio-host-bridge. Henceforth, new spapr-pci-host-bridge needs to be added for every hostdev belonging to any new iommu group. The hostdevs should be attached to their respective spapr-pci-vfio-host-bridge. Libvirt today adds all the devices to the default pci domain. The patch series take care to add the new controller. A new pci domain in the guest per controller is created. The hostdevs get their pci address in the respective domain. The patch series taskes care of device addressing in vfio hostdevs, SR-IOV interfaces and network interfaces from SRIOV virtual function pools. Reference: ====== v1: http://www.redhat.com/archives/libvir-list/2014-October/msg00500.html Changes Since v1: * Some minor code clean up and rebase to latest code base after review with Prerna * Patch 2 : Added logic to remove redundant spapr-vfio controllers. * : Moved domaincommon.rng from Patch 4 to Patch 2. --- Shivaprasad G Bhat (4): qemu: Add SPAPR_VFIO_HOST_BRIDGE capability for PPC platform qemu: parse spapr-vfio-pci controller from xml qemu: assign addresses for spapr vfio hostdevices and generate cli qemu: add test case for spapr-pci-vfio-host-bridge docs/schemas/domaincommon.rng | 28 ++ src/bhyve/bhyve_domain.c | 2 src/conf/domain_addr.c | 8 - src/conf/domain_addr.h | 2 src/conf/domain_conf.c | 165 +++++++++++- src/conf/domain_conf.h | 19 + src/libvirt_private.syms | 2 src/qemu/qemu_capabilities.c | 2 src/qemu/qemu_capabilities.h | 1 src/qemu/qemu_command.c | 276 +++++++++++++++++++- src/qemu/qemu_command.h | 17 + src/qemu/qemu_domain.c | 12 - src/qemu/qemu_driver.c | 6 tests/qemuhotplugtest.c | 2 .../qemuxml2argv-hostdev-spapr-vfio.args | 20 + .../qemuxml2argv-hostdev-spapr-vfio.xml | 75 +++++ tests/qemuxml2argvtest.c | 8 + 17 files changed, 609 insertions(+), 36 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-spapr-vfio.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-spapr-vfio.xml -- Signature

3 10

[libvirt] [PATCHv2 0/7] Automaticaly fill <memory> element for NUMA enabled guests
by Peter Krempa 09 Mar '15

09 Mar '15

This series changes the behavior of the <memory> element in case the guest has NUMA enabled and fills automatically the sum of sizes of numa nodes instead of relying on the user passing correct data. Peter Krempa (7): qemu: Forbid setting maximum memory size with the API with NUMA enabled qemu: lxc: Clarify error message when setting current memory conf: Replace access to def->mem.max_balloon with accessor functions phyp: Fix error messages mentioning memory qemu: command: Add helper to align memory sizes conf: numa: Add helper to count total memory size configured in NUMA conf: Automatically use NUMA memory size in case NUMA is enabled src/conf/domain_conf.c | 72 +++++++++++++++++++--- src/conf/domain_conf.h | 4 ++ src/conf/numa_conf.c | 13 ++++ src/conf/numa_conf.h | 2 + src/hyperv/hyperv_driver.c | 2 +- src/libvirt_private.syms | 4 ++ src/libxl/libxl_conf.c | 2 +- src/libxl/libxl_driver.c | 8 +-- src/lxc/lxc_cgroup.c | 2 +- src/lxc/lxc_driver.c | 28 +++++---- src/lxc/lxc_fuse.c | 4 +- src/lxc/lxc_native.c | 4 +- src/openvz/openvz_driver.c | 2 +- src/parallels/parallels_driver.c | 2 +- src/parallels/parallels_sdk.c | 12 ++-- src/phyp/phyp_driver.c | 15 +++-- src/qemu/qemu_command.c | 23 ++++--- src/qemu/qemu_domain.c | 21 +++++++ src/qemu/qemu_domain.h | 2 + src/qemu/qemu_driver.c | 49 ++++++++++----- src/qemu/qemu_hotplug.c | 8 ++- src/qemu/qemu_process.c | 2 +- src/test/test_driver.c | 8 +-- src/uml/uml_driver.c | 8 +-- src/vbox/vbox_common.c | 4 +- src/vmware/vmware_driver.c | 2 +- src/vmx/vmx.c | 12 ++-- src/xen/xm_internal.c | 14 ++--- src/xenapi/xenapi_driver.c | 2 +- src/xenapi/xenapi_utils.c | 4 +- src/xenconfig/xen_common.c | 8 ++- src/xenconfig/xen_sxpr.c | 9 +-- .../qemuxml2argv-numatune-memnode.args | 2 +- 33 files changed, 243 insertions(+), 111 deletions(-) -- 2.2.2

2 21

[libvirt] ANNOUNCE: Oz 0.13.0 release
by Chris Lalancette 07 Mar '15

07 Mar '15

All, I'm pleased to announce release 0.13.0 of Oz. Oz is a program for doing automated installation of guest operating systems with limited input from the user. Release 0.13.0 is a bugfix and feature release for Oz. Some of the highlights between Oz 0.12.0 and 0.13.0 are: - For Fedora, if the user specifies a version, but that isn't supported yet, try the last supported version (in this case), as that will often work. - Fix a regression where we forgot to force the qcow2 image type - Allow installs that use more than one installation device - Add support for RHEL 6.5 - Rename OEL-6 to OL-6 - Add support for Ubuntu 14.04 - Add Windows 8.1 support - Add CentOS-7 support - Add the ability to specify kernel parameters in the TDL - Make sure to remove dhcp leases from guests after the install - Fix support for FreeBSD - Add in support for TDL "precommands"; these are commands that are run *before* package installation - Fix up file locking - Add support for RHEL 5.11 - Remove Ubuntu ssh keys at the end of installation - Add support for Ubuntu 14.10 - Add support for XInclude, for merging various TDLs together - Add Fedora 21 support - Add support for ppc64 and ppc64le A tarball and zipfile of this release is available on the Github releases page: https://github.com/clalancette/oz/releases . Packages for Fedora-20, Fedora-21, Fedora-22, EPEL-6, and EPEL-7 have been built in Koji and will eventually make their way to stable. Instructions on how to get and use Oz are available at http://github.com/clalancette/oz/wiki . If you have questions or comments about Oz, please feel free to contact me at clalancette at gmail.com, or open up an issue on the github page: http://github.com/clalancette/oz/issues . Thanks to everyone who contributed to this release through bug reports, patches, and suggestions for improvement. Chris Lalancette

1 0

[libvirt] [PATCH 0/2] Add some tiny tests for latest commits
by Martin Kletzander 06 Mar '15

06 Mar '15

Two commits (hashes mentioned in commit messages) were added lately without tests and I feel like both deserve one, so here goes. Martin Kletzander (2): tests: Add test for virtio-mmio address type tests: Add test for os interleaving ...=> qemuxml2argv-aarch64-aavmf-virtio-mmio.args} | 4 ++-- ... => qemuxml2argv-aarch64-aavmf-virtio-mmio.xml} | 27 +++++++++++----------- ...l => qemuxml2argv-bios-nvram-os-interleave.xml} | 2 +- tests/qemuxml2argvtest.c | 4 ++++ .../qemuxml2xmlout-bios-nvram-os-interleave.xml} | 0 tests/qemuxml2xmltest.c | 2 ++ 6 files changed, 23 insertions(+), 16 deletions(-) copy tests/qemuxml2argvdata/{qemuxml2argv-aarch64-virt-virtio.args => qemuxml2argv-aarch64-aavmf-virtio-mmio.args} (85%) copy tests/qemuxml2argvdata/{qemuxml2argv-aarch64-virt-virtio.xml => qemuxml2argv-aarch64-aavmf-virtio-mmio.xml} (68%) copy tests/qemuxml2argvdata/{qemuxml2argv-bios-nvram.xml => qemuxml2argv-bios-nvram-os-interleave.xml} (100%) copy tests/{qemuxml2argvdata/qemuxml2argv-bios-nvram.xml => qemuxml2xmloutdata/qemuxml2xmlout-bios-nvram-os-interleave.xml} (100%) -- 2.3.0

2 3

[libvirt] [PATCH v4 0/9] Introduce display of IOThreads Information
by John Ferlan 06 Mar '15

06 Mar '15

v3: http://www.redhat.com/archives/libvir-list/2015-February/msg00593.html Changes since v3: (from code reviews) - Updated to use 1.2.14 not 1.2.13 - Change struct from virDomainIOThreadsInfo to virDomainIOThreadInfo - Remove the resources and nresources from virDomainIOThreadInfo and of course all associated code as well as changing the remote struct from iothreads_* to iothread_ - Create separate routines for virDomainGetIOThreadsInfo, virDomainGetIOThreadPin, and virDomainPinIOThread... and of course all the accompanying code - Use EnterMonitor instead of EnterMonitorAsync Still need to generate a v3 of the python code, but I'll wait for this to be reviewed first. John Ferlan (9): Implement public API for virDomainGetIOThreadsInfo remote: Implement the remote plumbing for virDomainGetIOThreadsInfo qemu: Implement the qemu driver fetch for IOThreads virsh: Add 'iothreadsinfo' command Implement public API for getting/setting specific IOThread pinning remote: Plumbing for getting/setting specific IOThread pinning domain: Introduce virDomainIOThreadsPin{Add|Del} qemu: Add support to get/set specific IOThread pinning data virsh: Add iothreadpin command daemon/remote.c | 123 ++++++++- include/libvirt/libvirt-domain.h | 41 ++- src/conf/domain_conf.c | 64 +++++ src/conf/domain_conf.h | 10 + src/driver-hypervisor.h | 24 +- src/libvirt-domain.c | 227 ++++++++++++++++- src/libvirt_private.syms | 2 + src/libvirt_public.syms | 8 + src/qemu/qemu_driver.c | 526 +++++++++++++++++++++++++++++++++++++++ src/remote/remote_driver.c | 143 ++++++++++- src/remote/remote_protocol.x | 61 ++++- src/remote_protocol-structs | 43 ++++ src/rpc/gendispatch.pl | 2 + tools/virsh-domain.c | 216 ++++++++++++++++ tools/virsh.pod | 38 +++ 15 files changed, 1521 insertions(+), 7 deletions(-) -- 2.1.0

3 21

[libvirt] ANNOUNCE: Libvirt Designer version 0.0.2 released
by Daniel P. Berrange 06 Mar '15

06 Mar '15

I'm pleased to announce the second release of the libvirt designer library, version 0.0.2 ftp://ftp.libvirt.org/libvirt/designer/libvirt-designer-0.0.2.tar.gz The release is signed ftp://ftp.libvirt.org/libvirt/designer/libvirt-designer-0.0.2.tar.gz.asc with the GPG key having the fingerprint DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R) In this release: - Bumped soname & version for ABI change - Remove use of deprecated libosinfo calls - Fix various memory leaks - Treat errors loading the libosinfo DB as non-fatal as some data may be successfully loaded - Improve building of libosinfo short-id from libvirt capabilities information - Expose the libosinfo DB object via a property on the domain object - Don't set PKG_CONFIG_PATH for g-ir-scanner - Auto-generate list of AUTHORS - Avoid redefining _FORTIFY_SOURCE macro - Fix & add gtk-doc introspection annotation - Add Vala APi binding - Add support for floppy & CDROM devices - Use libvirt style libtool versioning csheme - Add API to set list of installed drivers - Add API for querying supported devices - Remove many bogus assumptions in disk bus handling - Populate clock settings, input devices & console - Add API for enabling sound devices - Add AP ifor enabling choice of graphics backends - Add SPICE agent if using SPICE - Add API for enabling USB redirection - Add API for enabling smartcard devices - Add API for enabling video devices - Import latest compiler warnings from gnulib - Avoid using deprecated libvirt-gconfig APIs - Rename virtxml binary to virt-designer - Add API for choosing network backend type - Add further test cases for validing domain builder - Always build test programs The libvirt-designer library builds on top of the libvirt-gconfig and libosinfo libraries, to provide an API that assists applications in building guest domain configurations based on libosinfo policy. The intention is that it be usable from applications such as virt-manager and GNOME boxes which currently duplicate this kind of policy based configuration logic between them. It is still at an early experimental stage of development so it is liable to have further ABI incompatible changes in future releases, which will require recompiling applications and possibly source level changes too. Thanks to all the people who contributed towards this new release. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

1 0

[libvirt] [PATCH v2 0/3] unify memtune value representation in libvirt
by Pavel Hrdina 06 Mar '15

06 Mar '15

The first patch rewrites virsh memtune command to accept 0 as valid value instead of ignoring it. In the second patch I'll introduce a simple helper to crop the *_limit values to VIR_DOMAIN_MEMORY_PARAM_UNLIMITED as its used several times while reading values from cgroups and also a helper to check whether the memory limits are set or not. The last patch actually changes the internal representation of unlimited memtune settings. More detailed description is in commit message. My motivation to change it completely is to prevent future bugs with those limits. Pavel Hrdina (3): virsh: fix memtune to also accept 0 as valid value virutil: introduce helper functions for memory limits memtune: change the way how we store unlimited value docs/formatdomain.html.in | 4 +- src/conf/domain_conf.c | 75 +++++++++++++++---- src/libvirt-domain.c | 3 + src/libvirt_private.syms | 3 +- src/lxc/lxc_cgroup.c | 18 ++--- src/lxc/lxc_driver.c | 7 +- src/lxc/lxc_fuse.c | 12 ++-- src/lxc/lxc_native.c | 6 +- src/openvz/openvz_conf.c | 4 +- src/openvz/openvz_driver.c | 4 +- src/qemu/qemu_cgroup.c | 24 +++---- src/qemu/qemu_command.c | 8 ++- src/qemu/qemu_driver.c | 10 +-- src/qemu/qemu_hotplug.c | 2 +- src/qemu/qemu_migration.c | 5 +- src/util/virutil.c | 47 ++++++------ src/util/virutil.h | 5 +- tests/qemuxml2argvdata/qemuxml2argv-memtune.xml | 2 +- .../qemuxml2xmloutdata/qemuxml2xmlout-memtune.xml | 2 +- tools/virsh-domain.c | 83 ++++++++++------------ 20 files changed, 185 insertions(+), 139 deletions(-) -- 2.0.5

2 8

[libvirt] expose via api event about changing domain metadata
by Vasiliy Tolstov 06 Mar '15

06 Mar '15

Hello. I have in domain metadata some info that i need , but now i need to notify when the info changed. Does it possible to add even about changing domain metadata like other events (http://libvirt.org/html/libvirt-libvirt-domain.html#virDomainEventID) -- Vasiliy Tolstov, e-mail: v.tolstov(a)selfip.ru jabber: vase(a)selfip.ru

2 2

[libvirt] [PATCH v2 1/3] utils: Implement virCommandPassFDGetFDIndex
by Stefan Berger 06 Mar '15

06 Mar '15

Implement virCommandPassFDGetFDIndex to determine the index a given file descriptor will have when passed to the child process. Signed-off-by: Stefan Berger <stefanb(a)linux.vnet.ibm.com> --- src/libvirt_private.syms | 1 + src/util/vircommand.c | 24 ++++++++++++++++++++++++ src/util/vircommand.h | 3 +++ 3 files changed, 28 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 6028002..96cfbf2 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1214,6 +1214,7 @@ virCommandNewArgList; virCommandNewArgs; virCommandNonblockingFDs; virCommandPassFD; +virCommandPassFDGetFDIndex; virCommandPassListenFDs; virCommandRawStatus; virCommandRequireHandshake; diff --git a/src/util/vircommand.c b/src/util/vircommand.c index 6527d85..648f5ed 100644 --- a/src/util/vircommand.c +++ b/src/util/vircommand.c @@ -1019,6 +1019,30 @@ virCommandPassListenFDs(virCommandPtr cmd) cmd->flags |= VIR_EXEC_LISTEN_FDS; } +/* + * virCommandPassFDGetFDIndex: + * @cmd: pointer to virCommand + * @fd: FD to get index of + * + * Determine the index of the FD in the transfer set. + * + * Returns index >= 0 if @set contains @fd, + * -1 otherwise. + */ +int +virCommandPassFDGetFDIndex(virCommandPtr cmd, int fd) +{ + size_t i = 0; + + while (i < cmd->npassfd) { + if (cmd->passfd[i].fd == fd) + return i; + i++; + } + + return -1; +} + /** * virCommandSetPidFile: * @cmd: the command to modify diff --git a/src/util/vircommand.h b/src/util/vircommand.h index bf65de4..198da2f 100644 --- a/src/util/vircommand.h +++ b/src/util/vircommand.h @@ -62,6 +62,9 @@ void virCommandPassFD(virCommandPtr cmd, void virCommandPassListenFDs(virCommandPtr cmd); +int virCommandPassFDGetFDIndex(virCommandPtr cmd, + int fd); + void virCommandSetPidFile(virCommandPtr cmd, const char *pidfile) ATTRIBUTE_NONNULL(2); -- 1.9.3

2 4