- Devel - libvirt List Archives

[libvirt] [PATCH] vircgroup: Fix build issue on mingw
by John Ferlan 27 Mar '15

27 Mar '15

Commit id 'ba1dfc5' added virCgroupSetCpusetMemoryMigrate and virCgroupGetCpusetMemoryMigrate, but did not add the corresponding entry points into the "#else /* !VIR_CGROUP_SUPPORTED */" section Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Not pushing as a build break since I'm not 100% it fixes the issue eblake mentions in his review of a recent cgroup series. src/util/vircgroup.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 0a2e729..093a146 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -4420,6 +4420,26 @@ virCgroupGetCpusetMems(virCgroupPtr group ATTRIBUTE_UNUSED, int +virCgroupSetCpusetMemoryMigrate(virCgroupPtr group ATTRIBUTE_UNUSED, + bool migrate ATTRIBUTE_UNUSED) +{ + virReportSystemError(ENOSYS, "%s", + _("Control groups not supported on this platform")); + return -1; +} + + +int +virCgroupGetCpusetMemoryMigrate(virCgroupPtr group ATTRIBUTE_UNUSED, + bool *migrate ATTRIBUTE_UNUSED) +{ + virReportSystemError(ENOSYS, "%s", + _("Control groups not supported on this platform")); + return -1; +} + + +int virCgroupSetCpusetCpus(virCgroupPtr group ATTRIBUTE_UNUSED, const char *cpus ATTRIBUTE_UNUSED) { -- 2.1.0

2 2

Re: [libvirt] bug#20082: new warning from ar on rawhide systems
by Eric Blake 27 Mar '15

27 Mar '15

[redirecting to libvirt; a continuation of https://www.redhat.com/archives/libvir-list/2015-February/msg01227.html] On 03/27/2015 02:43 PM, Pavel Raiskup wrote: > [+cc back libtool bug; as fixing automake does not seem to be enough] > >> >> Hmm. How hard is it to change ARFLAGS to 'cr' instead of the default of >> 'cru', so that projects that want to silence the warning now can do so >> without waiting on automake to catch up? (Remember, the warning is live >> on rawhide systems now, and even if we release a new automake with a >> patch to change the default, there are TONS of packages built with older >> automake that will still warn until such time as autoreconf is run on >> those packages to update them to the newer automake) > > Agreed here, while trying to look at possible patch, I found that libtool > historically does not respect automake's ARFLAGS, it has its own AR_FLAGS: > http://lists.gnu.org/archive/html/libtool/2008-05/msg00050.html > So fixing automake does not help for libtool-enabled projects, and, in some > situations users could need AR_FLAGS=X ARFLAGS=X, but yes - still easy to > define on per-project basis. > > FTR, Libtool uses AR_FLAGS from ~2000 (commit 8300de4c54e6f04f0d), automake > ARFLAGS from ~2003 (commit a71b3490639831ca). > Given the discussion on automake/libtool lists, I'm going to play with a patch that just sets AR[_]FLAGS to 'cr' to shut up the compilation warnings on rawhide. Anyone see a problem with that plan? -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org

1 0

[libvirt] [PATCH 0/2] really fix qemucaps2xmltest
by Pavel Hrdina 27 Mar '15

27 Mar '15

Pavel Hrdina (2): Revert "qemucaps2xmltest: fix test to successfully run without kvm support" tests: introduce qemucaps2xmlmock tests/Makefile.am | 7 +++++++ tests/qemucaps2xmlmock.c | 33 +++++++++++++++++++++++++++++++++ tests/qemucaps2xmltest.c | 6 +++--- 3 files changed, 43 insertions(+), 3 deletions(-) create mode 100644 tests/qemucaps2xmlmock.c -- 2.0.5

2 4

[libvirt] [PATCH] virnetlink: fix build error
by Pavel Hrdina 27 Mar '15

27 Mar '15

Commint 0473b45cc introduced new function virNetlinkDelLink, but in it's counterpart for non-linux platform there should be ATTRIBUTE_UNUSED instead of ATTRIBUTE_UNSUPPORTED. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- Pushed under build-breaker rule. src/util/virnetlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index 86c9c9c..0052ef9 100644 --- a/src/util/virnetlink.c +++ b/src/util/virnetlink.c @@ -886,7 +886,7 @@ int virNetlinkCommand(struct nl_msg *nl_msg ATTRIBUTE_UNUSED, int -virNetlinkDelLink(const char *ifname ATTRIBUTE_UNSUPPORTED) +virNetlinkDelLink(const char *ifname ATTRIBUTE_UNUSED) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _(unsupported)); return -1; -- 2.0.5

2 1

[libvirt] [PATCH 0/2] vshPrintPinInfo cleanups
by Ján Tomko 27 Mar '15

27 Mar '15

Ján Tomko (2): Fix indentation in cmdVcpuPin Rewrite vshPrintPinInfo tools/virsh-domain.c | 55 ++++++++++++++++------------------------------------ 1 file changed, 17 insertions(+), 38 deletions(-) -- 2.0.5

2 3

[libvirt] [PATCH v4 0/3] Parallels disk device attach
by Alexander Burluka 27 Mar '15

27 Mar '15

This patchset implements disk device attachment and allows OpenStack to attach volumes to Parallels-driven instances. Parallels Cloud Server SDK supports live attachment of disk devices and virtual interfaces cards. Alexander Burluka (3): Parallels: remove disk serial number check Parallels: implement domainAttachDeviceFlags Parallels: implemented domainAttachDevice

2 4

Re: [libvirt] iscsi multipath failure with "libvirtError: Failed to open file '/dev/mapper/Mar': No such file or directory"
by Stefan Hajnoczi 27 Mar '15

27 Mar '15

On Mon, Mar 23, 2015 at 10:14:31PM +0530, mad Engineer wrote: > hello All, > I know the issue is related to libvirt,but i dont know > where to ask. The libvirt mailing list is the place to ask libvirt questions. I have CCed it. > i have centos 6.6 running KVM as compute node in openstack icehouse > > when i try to attach volume to instance it shows > > 2596: error : virStorageFileGetMetadataRecurse:952 : Failed to open > file '/dev/mapper/Mar': No such file or directory > > in libvirt log > > This does not always happen when it happens no one will be able to > attach volume to instance > > > using EMC VNX as storage backend. > > > multipath.conf > > > # Skip the files uner /dev that are definitely not FC/iSCSI devices > # Different system may need different customization > devnode "^(ram|raw|loop|fd|md|dm-|sr|scd|st)[0-9]*" > devnode "^hd[a-z][0-9]*" > devnode "^cciss!c[0-9]d[0-9]*[p[0-9]*]" > > # Skip LUNZ device from VNX > device { > vendor "DGC" > product "LUNZ" > } > } > > defaults { > user_friendly_names no > flush_on_last_del yes > } > > devices { > # Device attributed for EMC CLARiiON and VNX series ALUA > device { > vendor "DGC" > product ".*" > product_blacklist "LUNZ" > path_grouping_policy group_by_prio > path_selector "round-robin 0" > path_checker emc_clariion > features "1 queue_if_no_path" > hardware_handler "1 alua" > prio alua > failback immediate > } > } > > > Can any one help me with this issue You may need to check dmesg or logs related to the EMC storage. In particular, check for LUNs going offline, coming online, or the multipath device changing state. Stefan

1 0

[libvirt] [PATCH v3 0/3] Parallels disk device attach
by Alexander Burluka 27 Mar '15

27 Mar '15

This patchset implements disk device attachment and allows OpenStack to attach volumes to Parallels-driven instances. Parallels Cloud Server SDK supports live attachment of disk devices and virtual interfaces cards. Alexander Burluka (3): Parallels: remove disk serial number check Parallels: implement domainAttachDeviceFlags Parallels: implemented domainAttachDevice

2 4

[libvirt] [PATCH v2 0/3] Parallels disk device attach
by Alexander Burluka 27 Mar '15

27 Mar '15

This patchset implements disk device attachment and allows OpenStack to attach volumes to Parallels-driven instances. Parallels Cloud Server SDK supports live attachment of disk devices and virtual interfaces cards. Alexander Burluka (3): Parallels: remove disk serial number check Parallels: implement domainAttachDeviceFlags Parallels: implemented domainAttachDevice

3 5

[libvirt] [PATCH] qemu: end the job when try to blockcopy to non-file destination
by Shanzhi Yu 27 Mar '15

27 Mar '15

Blockcopy to non-file destination is not supported according the code while a 'goto endjob' is missed after check the destination which lead qemu try to do drive-mirror. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1206406 Signed-off-by: Shanzhi Yu <shyu(a)redhat.com> --- src/qemu/qemu_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index db4f0b4..f07e4fb 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -16642,6 +16642,7 @@ qemuDomainBlockCopyCommon(virDomainObjPtr vm, if (!virStorageSourceIsLocalStorage(mirror)) { virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", _("non-file destination not supported yet")); + goto endjob; } if (stat(mirror->path, &st) < 0) { if (errno != ENOENT) { -- 2.1.0

2 1