- Devel - libvirt List Archives

[PATCH] ZFS: fix incorrect volsize,refreservation on zvol creation
by George Melikov 03 May '26

03 May '26

From: George Melikov <mail(a)gmelikov.ru> Reproduce: ```bash # Order is crucial here, if we create zvol with name which won't be last - we'll get size from different zvol root@minime:~# virsh vol-list rpool Name Path ---------------------------------------------------------------------------------------------------- da52bdd9-eb75-5746-a2ce-a511067914f5 /dev/zvol/rpool/disks/da52bdd9-eb75-5746-a2ce-a511067914f5 faafd0f9-33c8-5b23-990c-fa7b4bfe8dcf /dev/zvol/rpool/disks/faafd0f9-33c8-5b23-990c-fa7b4bfe8dcf # Create zvol with name which will be before `faaf...` root@minime:~# cat > /tmp/vol <volume> <name>eeee</name> <capacity>4294967296</capacity> <allocation>4294967296</allocation> </volume> root@minime:~# virsh vol-create rpool /tmp/vol Vol eeee created from /tmp/vol root@minime:~# virsh vol-list rpool Name Path ---------------------------------------------------------------------------------------------------- da52bdd9-eb75-5746-a2ce-a511067914f5 /dev/zvol/rpool/disks/da52bdd9-eb75-5746-a2ce-a511067914f5 eeee /dev/zvol/rpool/disks/eeee faafd0f9-33c8-5b23-990c-fa7b4bfe8dcf /dev/zvol/rpool/disks/faafd0f9-33c8-5b23-990c-fa7b4bfe8dcf # Here we've got Capacity from last zvol (ordered by name) root@minime:~# virsh vol-info --pool rpool eeee Name: eeee Type: block Capacity: 10.00 GiB Allocation: 0.00 B # Full refresh fixes it root@minime:~# virsh pool-refresh --pool rpool Pool rpool refreshed root@minime:~# virsh vol-info --pool rpool eeee Name: eeee Type: block Capacity: 4.00 GiB Allocation: 4.06 GiB ``` Fix is trivial: check zvol by name and return early if this is different zvol. Signed-off-by: George Melikov <mail(a)gmelikov.ru> --- src/storage/storage_backend_zfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/storage/storage_backend_zfs.c b/src/storage/storage_backend_zfs.c index 33434d0cac..2cb555a6e6 100644 --- a/src/storage/storage_backend_zfs.c +++ b/src/storage/storage_backend_zfs.c @@ -132,8 +132,10 @@ virStorageBackendZFSParseVol(virStoragePoolObj *pool, if (vol == NULL) volume = virStorageVolDefFindByName(pool, vol_name); - else + else if (STREQ(vol_name, vol->name)) volume = vol; + else + return 0; if (volume == NULL) { volume = g_new0(virStorageVolDef, 1); -- 2.53.0

2 1

Release of libvirt-12.3.0
by Jiri Denemark 02 May '26

02 May '26

The 12.3.0 release of both libvirt and libvirt-python is tagged and signed tarballs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is greatly appreciated. * New features * bhyve: Add blkiotune support The bhyve driver now supports guest I/O throttling configuration:: <blkiotune> <device> <path>*</path> <read_iops_sec>20000</read_iops_sec> <write_iops_sec>20000</write_iops_sec> <read_bytes_sec>10000</read_bytes_sec> <write_bytes_sec>10000</write_bytes_sec> </device> </blkiotune> It uses the ``rctl(4)`` framework to apply these limits. * bhyve: Implement ``virDomainInterfaceAddresses()`` and ``virDomainGetHostname()`` The bhyve driver now implements APIs allowing to fetch address of VM's interfaces (accessible via ``virsh domifaddr``) and the hostname of the VM (``virsh domhostname``). * hyperv: Implement ``virDomainGetGuestInfo()`` The hyperv driver now implements API for fetching guest information (``virsh guestinfo``). * Improvements * security: Don't error out on security labels of type='none' Previously, libvirt reported an error if a domain with seclabel of type='none' (meaning do not take this security model into account for this domain) was being started and the model wasn't available (for instance, in case of SELinux it was disabled at boot). * Allow for multiple PCI root buses, not just for a single one numbered '0' `virPCIDeviceReset()` and `virPCIDeviceIsBehindSwitchLackingACS()` no longer use a hardcoded check (e.g bus == 0 ) to determine if a device is attached to a "root bus". This allows for better support on more complex PCI topologies. * Add mechanism to prevent accidental shrink of device with ``virsh blockresize`` A new flag ``VIR_DOMAIN_BLOCK_RESIZE_EXTEND`` was introduced which prevents accidental shrinking of the block device of the VM. The flag is exposed as ``virsh blockresize --extend``. * Expose ``MemAvailable`` field from kernel's meminfo as ``VIR_NODE_MEMORY_STATS_AVAILABLE`` * Bug fixes * virnetdevmacvlan: Wait for udev to settle after creating macvtap When starting a domain with a macvtap device (or when hotplugging one), libvirt creates the device and opens its ``/dev`` representation in order to set it according to the ``<interface/>`` XML (e.g. MAC address, queues, etc.). But if the system is under heavy load, it might happen that after the device creation the udev daemon was triggered, but did not have enough time to set the ``/dev`` representation fully. This may result in various misconfiguration or even failed ``open()``. Therefore, libvirt waits after device creation for udev daemon to settle down. * apparmor: Don't drop macvtap devices from profile on blockjobs Enjoy. Jirka

1 0

[PATCH 0/4] Fix vcpu stats present for inactive VMs and allow virsh completion while daemon is down
by Peter Krempa 30 Apr '26

30 Apr '26

Two things that annoyed me while I tried to reply to a mail. Peter Krempa (4): qemuDomainGetStatsCpuProc: Don't fetch stats for inactive VMs virProcessGetStatInfo: Improve debug message vsh: Suppress attempts to write to stderr when it was closed in 'cmdComplete' vsh: cmdComplete: Don't exit when connecting to the daemon fails src/qemu/qemu_driver.c | 3 +++ src/util/virprocess.c | 4 ++-- tools/vsh.c | 12 ++++++++++-- tools/vsh.h | 2 ++ 4 files changed, 17 insertions(+), 4 deletions(-) -- 2.54.0

2 6

Entering freeze for libvirt-12.3.0
by Jiri Denemark 29 Apr '26

29 Apr '26

I have just tagged v12.3.0-rc1 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Jirka

1 1

[PATCH] NEWS: multi pci root bus complex support
by ehanoc 29 Apr '26

29 Apr '26

From: Bruno Martins <ehanoc(a)protonmail.com> Signed-off-by: Bruno Martins <ehanoc(a)protonmail.com> --- NEWS.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 56e344776b..65a8388607 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -41,6 +41,13 @@ v12.3.0 (unreleased) * **Improvements** + * Allow for multiple PCI root buses, not just for a single one numbered '0' + + `virPCIDeviceReset()` and `virPCIDeviceIsBehindSwitchLackingACS()` no longer + use a hardcoded check (e.g bus == 0 ) to determine if a device is attached + to a "root bus". This allows for better support on more complex PCI topologies. + + * **Bug fixes** -- 2.47.3

3 2

doc: virDomainInterfaceStats, virDomainMemoryStats: allowed domain states not documented
by Claudio Fontana 29 Apr '26

29 Apr '26

Hello, at least for virDomainInterfaceStats() and virDomainMemoryStats() they actually seem to fail when called on a non active domain (for example a shutoff domain). It would be beneficial to document clearly which domain states are allowed when calling the APIS in https://libvirt.org/html/libvirt-libvirt-domain.html because it can be also reasonable to assume, for example, that a call would just return empty values when the domain is not active. It is not 100% clear from the code either, because the domain state is not enforced at the core libvirt level, but rather by the QEMU driver implementation: qemuDomainInterfaceStats(): ... if (virDomainObjCheckActive(vm) < 0) goto cleanup; qemuDomainMemoryStatsInternal(): ... if (virDomainObjCheckActive(vm) < 0) return -1; so could a different driver decide that InterfaceStats or MemoryStats calls _are_ allowed for shutoff domains, possibly returning empty values, or latest run results, or ...? If it is 100% the case that these APIs are for active domains only, I think it could be documented in the APIs; not finding it there could make one assume that these are fine to call, especially since others _are_ documented in terms of active/inactivey: virDomainAddIOThread virDomainAttachDevice virDomainDelIOThread virDomainDelThrottleGroup virDomainGetBlockInfo virDomainPinVcpu virDomainGetIOThreadInfo virDomainGetJobInfo (this is the best because it explicitly says "return an error if the domain is not active" virDomainGetJobStats (same virtuous description) virDomainGetMaxVcpus virDomainGetSecurityLabel virDomainGetSecurityLabelList virDomainGetVcpus (not great: "This call may fail on an inactive domain" May? Depending on what? Driver?) virDomainGetVcpusFlags virDomainPinEmulator (again "may fail if domain is not alive" - is it really conditional, as opposed to "will fail for transient domains"?) virDomainPinVcpu ("can only be called on an active domain" -> would be better to say "returns an error if the domain is not active") virDomainSetMemoryFlags ("will wail if domain is not active") -Ok, clear. virDomainSetMemoryStatsPeriod (same) virDomainSetVcpus virDomainSetVcpusFlags virDomainSuspend (but not very clear: "Suspends an active domain". Does it return an error if the domain is not active? Or just do nothing?) virDomainUndefine virDomainUndefineFlags Maybe a good bite-sized task to queue that can create a lot of value. I would suggest an additional table generated for each API mentioning allowed domain states, or something to that effect. Thanks, -- Claudio Fontana Engineering Manager Virtualization, SUSE Labs Core SUSE Software Solutions Italy Srl

2 1

[PATCH] NEWS: Document features/improvements/bug fixes I've participated in
by Michal Privoznik 29 Apr '26

29 Apr '26

From: Michal Privoznik <mprivozn(a)redhat.com> There are some features/improvements/bug fixes I've either contributed or reviewed/merged. Document them for upcoming release. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- NEWS.rst | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 56e344776b..699077afd6 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -39,10 +39,33 @@ v12.3.0 (unreleased) VM's interfaces (accessible via ``virsh domifaddr``) and the hostname of the VM (``virsh domhostname``). + * hyperv: Implement ``virDomainGetGuestInfo()`` + + The hyperv driver now implements API for fetching guest information + (``virsh guestinfo``). + * **Improvements** + * security: Don't error out on security labels of type='none' + + Previously, libvirt reported an error if a domain with seclabel of + type='none' (meaning do not take this security model into account for this + domain) was being started and the model wasn't available (for instance, in + case of SELinux it was disabled at boot). + * **Bug fixes** + * virnetdevmacvlan: Wait for udev to settle after creating macvtap + + When starting a domain with a macvtap device (or when hotplugging one), + libvirt creates the device and opens its ``/dev`` representation in order + to set it according to the ``<interface/>`` XML (e.g. MAC address, queues, + etc.). But if the system is under heavy load, it might happen that after + the device creation the udev daemon was triggered, but did not have enough + time to set the ``/dev`` representation fully. This may result in various + misconfiguration or even failed ``open()``. Therefore, libvirt waits after + device creation for udev daemon to settle down. + v12.2.0 (2026-04-01) ==================== -- 2.53.0

2 1

[PATCH] NEWS: Mention apparmor fix, new memory stats and block resize improvement
by Peter Krempa 28 Apr '26

28 Apr '26

From: Peter Krempa <pkrempa(a)redhat.com> Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 56e344776b..cacc023966 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -41,8 +41,18 @@ v12.3.0 (unreleased) * **Improvements** + * Add mechanism to prevent accidental shrink of device with ``virsh blockresize`` + + A new flag ``VIR_DOMAIN_BLOCK_RESIZE_EXTEND`` was introduced which prevents + accidental shrinking of the block device of the VM. The flag is exposed + as ``virsh blockresize --extend``. + + * Expose ``MemAvailable`` field from kernel's meminfo as ``VIR_NODE_MEMORY_STATS_AVAILABLE`` + * **Bug fixes** + * apparmor: Don't drop macvtap devices from profile on blockjobs + v12.2.0 (2026-04-01) ==================== -- 2.53.0

2 1

[PATCH v2 0/5] qemu: support async live vCPU unplug
by Akash Kulhalli 28 Apr '26

28 Apr '26

This series adds support for asynchronous live vCPU unplug in the QEMU driver. For live vCPU unplug libvirt currently waits only for a short synchronous completion window. If the unplug completes later there is no dedicated event reporting successful removal of the vCPU. This series adds a new domain event for successful unplug completion and extends the public APIs to allow requesting asynchronous unplug. As recommended, this changeset is split into five parts- Patch 1 adds the new event and the required public/internal plumbing. Patch 2 wires the event into the existing QEMU unplug completion path. Patch 3 adds the internal QEMU plumbing needed to skip waiting for unplug completion, but leaves it unused for now. Patches 4 and 5 then expose the new behaviour through virDomainSetVcpusFlags() and virDomainSetVcpu() together with the corresponding virsh changes. The new public flags are limited to live unplug. Rejected unplug requests continue to be reported via device-removal-failed. Changes from v1: - split the original patch into five pieces separating event plumbing, event emission, internal helper changes, virDomainSetVcpusFlags(), and virDomainSetVcpu() - rename VIR_DOMAIN_VCPU_ASYNC to VIR_DOMAIN_VCPU_ASYNC_UNPLUG - add a dedicated virDomainSetVcpuBehaviour enum with VIR_DOMAIN_SETVCPU_ASYNC_UNPLUG for virDomainSetVcpu() - add virsh manpage documentation for the new --async option - this flag is a no-op if the action does not involve a live vcpu hot-unplug, and has been documented as such for the relevant functions Akash Kulhalli (5): conf,remote: add vcpu-removed domain event qemu: emit vcpu-removed event on unplug completion qemu: thread async vcpu unplug through internal helpers API/qemu: add async unplug flag to virDomainSetVcpusFlags API/qemu: add async unplug flag to virDomainSetVcpu Related discussion: RFC: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/2J53… v1: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/2J3V…

2 10

[PATCH] virNetDevOpenvswitchInterfaceStats: Add 'ifname' to error messages
by Peter Krempa 28 Apr '26

28 Apr '26

From: Peter Krempa <pkrempa(a)redhat.com> Report the interface name which caused the error. Resolves: https://redhat.atlassian.net/browse/RHEL-170993 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/util/virnetdevopenvswitch.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/util/virnetdevopenvswitch.c b/src/util/virnetdevopenvswitch.c index 868d6d26ba..d6457f35a0 100644 --- a/src/util/virnetdevopenvswitch.c +++ b/src/util/virnetdevopenvswitch.c @@ -403,8 +403,8 @@ virNetDevOpenvswitchInterfaceStats(const char *ifname, STREQ_NULLABLE(output, "")) { /* no ovs-vsctl or interface 'ifname' doesn't exists in ovs */ virReportError(VIR_ERR_INTERNAL_ERROR, - _("Interface not found: %1$s"), - NULLSTR(errbuf)); + _("Interface '%1$s' not found: %2$s"), + ifname, NULLSTR(errbuf)); return -1; } @@ -419,8 +419,9 @@ virNetDevOpenvswitchInterfaceStats(const char *ifname, stats->tx_packets == -1 && stats->tx_errs == -1 && stats->tx_drop == -1) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Interface doesn't have any statistics")); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Interface '%1$s' doesn't have any statistics"), + ifname); return -1; } -- 2.53.0

2 2