- Devel - libvirt List Archives

[PATCH] qemu: blockcommit: Fix placement of qemuDomainDiskBlockJobIsSupported
by Peter Krempa 08 Jun '20

08 Jun '20

Commit b50a8354f6d added call to qemuDomainDiskBlockJobIsSupported prior to filling the 'disk' variable resulting in a crash when attempting a block commit. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index dd9ae30bb5..88517ba6a7 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -18504,9 +18504,6 @@ qemuDomainBlockCommit(virDomainPtr dom, if (virDomainObjCheckActive(vm) < 0) goto endjob; - if (!qemuDomainDiskBlockJobIsSupported(vm, disk)) - goto endjob; - blockdev = virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKDEV); /* Convert bandwidth MiB to bytes, if necessary */ @@ -18523,6 +18520,9 @@ qemuDomainBlockCommit(virDomainPtr dom, if (!(disk = qemuDomainDiskByName(vm->def, path))) goto endjob; + if (!qemuDomainDiskBlockJobIsSupported(vm, disk)) + goto endjob; + if (virStorageSourceIsEmpty(disk->src)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("disk %s has no source file to be committed"), -- 2.26.2

2 1

[libvirt PATCH 0/4] po: misc fixes after conversion to weblate
by Daniel P. Berrangé 08 Jun '20

08 Jun '20

A bunch of random stuff that was missed in my first series converting to weblate. Daniel P. Berrangé (4): po: update docs to refer to Weblate instead of Zanata po: remove obsolete zanata push/pull rules po: remove obsolete zanata config file po: fix update-po target to take account of libvirt.pot in srcdir README.rst | 3 ++ docs/contribute.html.in | 4 +- docs/hacking.rst | 10 ++-- po/Makefile.am | 23 ++------- po/README.rst | 111 +++++++++++----------------------------- po/zanata.xml | 7 --- 6 files changed, 46 insertions(+), 112 deletions(-) delete mode 100644 po/zanata.xml -- 2.26.2

2 5

[libvirt PATCH] gitlab-ci: Enable FreeBSD native builds
by Erik Skultety 05 Jun '20

05 Jun '20

The runners have already been registered to the libvirt gitlab CI, we just need to enable building on them. Apart from adding respective CI job labels, the native job had to be tweaked so that the build dir inside the git repo is deleted before the build runs to always star with a clean environment, this results in a NOP on in the container workloads. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- .gitlab-ci.yml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 7113a1283c..33b83b0bb3 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -25,6 +25,7 @@ stages: before_script: - *script_variables script: + - rm -rf build - mkdir build - cd build - ../autogen.sh || (cat config.log && exit 1) @@ -109,6 +110,16 @@ x64-ubuntu-2004: <<: *native_build_default_job_definition image: quay.io/libvirt/buildenv-libvirt-ubuntu-2004:latest +x64-freebsd-11: + <<: *native_build_default_job_definition + tags: + - freebsd-11 + +x64-freebsd-12: + <<: *native_build_default_job_definition + tags: + - freebsd-12 + # Cross compiled build jobs -- 2.26.2

1 0

Minor typo on https://libvirt.org/kbase/backing_chains.html
by Roland Clobus 05 Jun '20

05 Jun '20

Hello all, I've found a minor typo on https://libvirt.org/kbase/backing_chains.html In the section 'Manual image creation' the word 'create' was missing from the command line: Current: qemu-img -f qcow2 -F qcow2 -b $BACKING_IMAGE_PATH $IMAGE_PATH Corrected: qemu-img create -f qcow2 -F qcow2 -b $BACKING_IMAGE_PATH $IMAGE_PATH With kind regards, Roland Clobus

3 2

[libvirt PATCH] docs: backing chains: fix qemu-img invocation
by Ján Tomko 05 Jun '20

05 Jun '20

The example was missing the 'create' command. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> Reported-by: Roland Clobus <rclobus(a)rclobus.nl> --- Pushed as trivial. docs/kbase/backing_chains.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/kbase/backing_chains.rst b/docs/kbase/backing_chains.rst index c112f2bc82..c3de37f4d1 100644 --- a/docs/kbase/backing_chains.rst +++ b/docs/kbase/backing_chains.rst @@ -120,7 +120,7 @@ means that the **-F** parameter of ``qemu-img`` must always be used. :: - qemu-img -f qcow2 -F qcow2 -b $BACKING_IMAGE_PATH $IMAGE_PATH + qemu-img create -f qcow2 -F qcow2 -b $BACKING_IMAGE_PATH $IMAGE_PATH Note that if ``$BACKING_IMAGE_PATH`` is relative the path is considered relative to the location of ``$IMAGE_PATH``. -- 2.25.4

1 0

[libvirt PATCH v2 0/3] news: Convert to reStructuredText
by Andrea Bolognani 05 Jun '20

05 Jun '20

browse: https://gitlab.com/abologna/libvirt/-/tree/news-convert-cleanup git fetch: https://gitlab.com/abologna/libvirt.git news-convert-cleanup Changes since [v1] * use '*' for all bullet points, regardless of how deep they're nested; * patches 1/5 and 2/5 have been pushed. [v1] https://www.redhat.com/archives/libvir-list/2020-June/msg00061.html Andrea Bolognani (3): news: Output reStructuredText for the ASCII version news: Convert to reStructuredText news: Add information about old releases Makefile.am | 22 +- NEWS.rst | 4077 ++++++++++++++++++++++++++++ docs/Makefile.am | 27 +- docs/libvirt.css | 15 - docs/news-2005.html.in | 28 - docs/news-2006.html.in | 354 --- docs/news-2007.html.in | 534 ---- docs/news-2008.html.in | 580 ---- docs/news-2009.html.in | 1603 ----------- docs/news-2010.html.in | 2218 --------------- docs/news-2011.html.in | 3314 ----------------------- docs/news-2012.html.in | 3012 --------------------- docs/news-2013.html.in | 3675 ------------------------- docs/news-2014.html.in | 3418 ------------------------ docs/news-2015.html.in | 2864 -------------------- docs/news-2016.html.in | 3740 -------------------------- docs/news-ascii.xsl | 69 - docs/news-html.xsl | 106 - docs/news.rng | 72 - docs/news.xml | 5473 -------------------------------------- scripts/reformat-news.py | 102 - tests/virschematest.c | 2 - 22 files changed, 4089 insertions(+), 31216 deletions(-) create mode 100644 NEWS.rst delete mode 100644 docs/news-2005.html.in delete mode 100644 docs/news-2006.html.in delete mode 100644 docs/news-2007.html.in delete mode 100644 docs/news-2008.html.in delete mode 100644 docs/news-2009.html.in delete mode 100644 docs/news-2010.html.in delete mode 100644 docs/news-2011.html.in delete mode 100644 docs/news-2012.html.in delete mode 100644 docs/news-2013.html.in delete mode 100644 docs/news-2014.html.in delete mode 100644 docs/news-2015.html.in delete mode 100644 docs/news-2016.html.in delete mode 100644 docs/news-ascii.xsl delete mode 100644 docs/news-html.xsl delete mode 100644 docs/news.rng delete mode 100644 docs/news.xml delete mode 100755 scripts/reformat-news.py -- 2.25.4

2 4

Handling merge requests from Weblate translation
by Daniel P. Berrangé 05 Jun '20

05 Jun '20

The libvirt project is now converted to use Weblate for translation. Weblate has its own fork of libvirt git repos. With weblate managing translations, NEVER, under any circumstances should anyone change the .po files in libvirt.git directly. This will result in merge conflicts with Weblate that need tedious manual resolution. Any .po file changes must always be done via the Weblate UI. Changes made in the weblate UI are not committed to its fork immediately. Weblate will wait upto 24 hours before committing. It will keep changes by each translator as separate commits, and will add SoB lines to them. When it has commits ready, it opens a merge request in GitLab. If it has more commits later and the merge request is still open, it will just push to the pre-existing merge request instead of opening a new one. What this means is that if we immediately approve & merge a weblate merge request, it'll likely open a new one the very next day. I don't think we want to be opening & closing 30 merge requests a month for translations. Thus I'm suggesting that we leave weblate merge requests open to accumulate new commits. Only approve & merge them during the freeze period. Any time we update the libvirt.pot, weblate will msgmerge all the .po files and submit them back to libvirt. These are going to be quite large commits. My intention is to only update the libvirt.pot at the time that we start the release freeze period. This leaves a week to receive new translations, during which time libvirt strings shouldn't be changing much anyway, since we're in bugfix only mode. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|

1 0

[libvirt PATCH] qemu: fix typo s/readaehad/readahead/
by Daniel P. Berrangé 05 Jun '20

05 Jun '20

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as trivial typo fix src/qemu/qemu_domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 10f16e9b3b..3239ac1a52 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -5281,7 +5281,7 @@ qemuDomainValidateStorageSource(virStorageSourcePtr src, src->protocol != VIR_STORAGE_NET_PROTOCOL_FTP && src->protocol != VIR_STORAGE_NET_PROTOCOL_FTPS)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("readaehad is supported only with HTTP(S)/FTP(s) protocols")); + _("readahead is supported only with HTTP(S)/FTP(s) protocols")); return -1; } -- 2.26.2

1 0

[PATCH 0/5] qemu: Prefer -numa cpu over -numa node,cpus=
by Michal Privoznik 05 Jun '20

05 Jun '20

Another round of patches to catch up with the latest command line building recommendations. This time, the winner is: -numa cpu Thing is, the way vCPUs are assigned to NUMA nodes is not very deterministic right now. QEMU relies on this weird mapping where firstly threads are iterated over, then cores, then (possibly) dies and then sockets. So they came up with a better schema: -numa cpu,node-id=N,socket-id=S,die-id=D,core-id=C,thread-id=T where everything is specified on the command line. Long story short, some QEMU code is copied over to keep status quo (or, whatever you want). It was buried down down (include/hw/i386/topology.h). I wanted to allow users configure the vCPU topology too, but then decided not to because neither Libvirt nor QEMU can really guarantee the topology will look the same in the guest (at least in my testing with cpu mode='host-passthrough' it didn't). Or, what you're proposing? I can post them as a follow up if needed. Michal Prívozník (5): qemuBuildNumaArgStr: Move vars into loops qemuBuildNumaArgStr: Use g_autofree on @nodeBackends qemuBuildNumaArgStr: Separate out old style of building CPU list qemu: Prefer -numa cpu over -numa node,cpus= virCPUDefParseXML: Parse uint using virXPathUInt src/conf/cpu_conf.c | 14 +- src/qemu/qemu_command.c | 168 +++++++++++++++--- .../hugepages-nvdimm.x86_64-latest.args | 4 +- ...memory-default-hugepage.x86_64-latest.args | 10 +- .../memfd-memory-numa.x86_64-latest.args | 10 +- ...y-hotplug-nvdimm-access.x86_64-latest.args | 4 +- ...ry-hotplug-nvdimm-align.x86_64-latest.args | 4 +- ...ry-hotplug-nvdimm-label.x86_64-latest.args | 4 +- ...ory-hotplug-nvdimm-pmem.x86_64-latest.args | 4 +- ...ory-hotplug-nvdimm-ppc64.ppc64-latest.args | 4 +- ...hotplug-nvdimm-readonly.x86_64-latest.args | 4 +- .../memory-hotplug-nvdimm.x86_64-latest.args | 4 +- ...vhost-user-fs-fd-memory.x86_64-latest.args | 4 +- ...vhost-user-fs-hugepages.x86_64-latest.args | 4 +- ...host-user-gpu-secondary.x86_64-latest.args | 3 +- .../vhost-user-vga.x86_64-latest.args | 3 +- 16 files changed, 195 insertions(+), 53 deletions(-) -- 2.26.2

2 14

[PATCH] numa: forbid '-numa node, mem' for 5.1 and newer machine types
by Igor Mammedov 05 Jun '20

05 Jun '20

Deprecation period is run out and it's a time to flip the switch introduced by cd5ff8333a. Disable legacy option for new machine types (since 5.1) and amend documentation. '-numa node,memdev' shall be used instead of disabled option with new machine types. Signed-off-by: Igor Mammedov <imammedo(a)redhat.com> --- - rebased on top of current master - move compat mode from 4.2 to 5.0 CC: peter.maydell(a)linaro.org CC: ehabkost(a)redhat.com CC: marcel.apfelbaum(a)gmail.com CC: mst(a)redhat.com CC: pbonzini(a)redhat.com CC: rth(a)twiddle.net CC: david(a)gibson.dropbear.id.au CC: libvir-list(a)redhat.com CC: qemu-arm(a)nongnu.org CC: qemu-ppc(a)nongnu.org --- docs/system/deprecated.rst | 17 ----------------- hw/arm/virt.c | 2 +- hw/core/numa.c | 6 ++++++ hw/i386/pc.c | 1 - hw/i386/pc_piix.c | 1 + hw/i386/pc_q35.c | 1 + hw/ppc/spapr.c | 2 +- qemu-options.hx | 9 +++++---- 8 files changed, 15 insertions(+), 24 deletions(-) diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index f0061f94aa..57edc075c2 100644 --- a/docs/system/deprecated.rst +++ b/docs/system/deprecated.rst @@ -101,23 +101,6 @@ error in the future. The ``-realtime mlock=on|off`` argument has been replaced by the ``-overcommit mem-lock=on|off`` argument. -``-numa node,mem=``\ *size* (since 4.1) -''''''''''''''''''''''''''''''''''''''' - -The parameter ``mem`` of ``-numa node`` is used to assign a part of -guest RAM to a NUMA node. But when using it, it's impossible to manage specified -RAM chunk on the host side (like bind it to a host node, setting bind policy, ...), -so guest end-ups with the fake NUMA configuration with suboptiomal performance. -However since 2014 there is an alternative way to assign RAM to a NUMA node -using parameter ``memdev``, which does the same as ``mem`` and adds -means to actualy manage node RAM on the host side. Use parameter ``memdev`` -with *memory-backend-ram* backend as an replacement for parameter ``mem`` -to achieve the same fake NUMA effect or a properly configured -*memory-backend-file* backend to actually benefit from NUMA configuration. -In future new machine versions will not accept the option but it will still -work with old machine types. User can check QAPI schema to see if the legacy -option is supported by looking at MachineInfo::numa-mem-supported property. - ``-numa`` node (without memory specified) (since 4.1) ''''''''''''''''''''''''''''''''''''''''''''''''''''' diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 37462a6f78..063d4703f7 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -2262,7 +2262,6 @@ static void virt_machine_class_init(ObjectClass *oc, void *data) hc->pre_plug = virt_machine_device_pre_plug_cb; hc->plug = virt_machine_device_plug_cb; hc->unplug_request = virt_machine_device_unplug_request_cb; - mc->numa_mem_supported = true; mc->nvdimm_supported = true; mc->auto_enable_numa_with_memhp = true; mc->default_ram_id = "mach-virt.ram"; @@ -2375,6 +2374,7 @@ DEFINE_VIRT_MACHINE_AS_LATEST(5, 1) static void virt_machine_5_0_options(MachineClass *mc) { virt_machine_5_1_options(mc); + mc->numa_mem_supported = true; } DEFINE_VIRT_MACHINE(5, 0) diff --git a/hw/core/numa.c b/hw/core/numa.c index 316bc50d75..05be412e59 100644 --- a/hw/core/numa.c +++ b/hw/core/numa.c @@ -117,6 +117,12 @@ static void parse_numa_node(MachineState *ms, NumaNodeOptions *node, } if (node->has_mem) { + if (!mc->numa_mem_supported) { + error_setg(errp, "Parameter -numa node,mem is not supported by this" + " machine type. Use -numa node,memdev instead"); + return; + } + numa_info[nodenr].node_mem = node->mem; if (!qtest_enabled()) { warn_report("Parameter -numa node,mem is deprecated," diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 2128f3d6fe..a86136069c 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1960,7 +1960,6 @@ static void pc_machine_class_init(ObjectClass *oc, void *data) hc->unplug = pc_machine_device_unplug_cb; mc->default_cpu_type = TARGET_DEFAULT_CPU_TYPE; mc->nvdimm_supported = true; - mc->numa_mem_supported = true; mc->default_ram_id = "pc.ram"; object_class_property_add(oc, PC_MACHINE_DEVMEM_REGION_SIZE, "int", diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index f66e1d73ce..8955436efa 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -438,6 +438,7 @@ static void pc_i440fx_5_0_machine_options(MachineClass *m) pc_i440fx_5_1_machine_options(m); m->alias = NULL; m->is_default = false; + m->numa_mem_supported = true; compat_props_add(m->compat_props, hw_compat_5_0, hw_compat_5_0_len); compat_props_add(m->compat_props, pc_compat_5_0, pc_compat_5_0_len); } diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index 4ba8ac8774..af6b32adb7 100644 --- a/hw/i386/pc_q35.c +++ b/hw/i386/pc_q35.c @@ -366,6 +366,7 @@ static void pc_q35_5_0_machine_options(MachineClass *m) { pc_q35_5_1_machine_options(m); m->alias = NULL; + m->numa_mem_supported = true; compat_props_add(m->compat_props, hw_compat_5_0, hw_compat_5_0_len); compat_props_add(m->compat_props, pc_compat_5_0, pc_compat_5_0_len); } diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 3b1a5ed865..210d61d1b3 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -4511,7 +4511,6 @@ static void spapr_machine_class_init(ObjectClass *oc, void *data) * in which LMBs are represented and hot-added */ mc->numa_mem_align_shift = 28; - mc->numa_mem_supported = true; mc->auto_enable_numa = true; smc->default_caps.caps[SPAPR_CAP_HTM] = SPAPR_CAP_OFF; @@ -4599,6 +4598,7 @@ static void spapr_machine_5_0_class_options(MachineClass *mc) { spapr_machine_5_1_class_options(mc); compat_props_add(mc->compat_props, hw_compat_5_0, hw_compat_5_0_len); + mc->numa_mem_supported = true; } DEFINE_SPAPR_MACHINE(5_0, "5.0", false); diff --git a/qemu-options.hx b/qemu-options.hx index 93bde2bbc8..196f468786 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -239,10 +239,11 @@ SRST -numa node,nodeid=0 -numa node,nodeid=1 \ -numa cpu,node-id=0,socket-id=0 -numa cpu,node-id=1,socket-id=1 - '\ ``mem``\ ' assigns a given RAM amount to a node. '\ ``memdev``\ ' - assigns RAM from a given memory backend device to a node. If - '\ ``mem``\ ' and '\ ``memdev``\ ' are omitted in all nodes, RAM is - split equally between them. + Legacy '\ ``mem``\ ' assigns a given RAM amount to a node (not supported + for 5.1 and newer machine types). '\ ``memdev``\ ' assigns RAM from + a given memory backend device to a node. If '\ ``mem``\ ' and + '\ ``memdev``\ ' are omitted in all nodes, RAM is split equally between them. + '\ ``mem``\ ' and '\ ``memdev``\ ' are mutually exclusive. Furthermore, if one node uses '\ ``memdev``\ ', all of them have to -- 2.18.4

3 3

Disable some unit tests
by Ani Sinha 05 Jun '20

05 Jun '20

Hi : Is there a recommended way to disable some unit tests in Libvirt ? We some broken tests which we want to fix incrementally but while we do that, we want to keep running other non-broken tests. thanks Ani

1 0

[libvirt PATCH] gitlab: fix potfile job for new location
by Daniel P. Berrangé 04 Jun '20

04 Jun '20

Since we're storing the libvirt.pot file in git now, we should pull from the source dir, not the build dir. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as CI fix .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 149334ed6f..7113a1283c 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -210,7 +210,7 @@ potfile: - $MAKE -C src generated-sources - $MAKE -C po libvirt.pot - cd .. - - mv build/po/libvirt.pot libvirt.pot + - cp po/libvirt.pot libvirt.pot image: quay.io/libvirt/buildenv-libvirt-centos-8:latest artifacts: expose_as: 'Potfile' -- 2.26.2

1 0

[libvirt PATCH] qemu: don't reject interface update when switching to/from bridged network
by Laine Stump 04 Jun '20

04 Jun '20

If virDomainUpdateDeviceFlags() was used to update an <interface>, and the interface type changed from type='network' where the network was an unmanaged bridge (so actualType == bridge) to type='bridge' (i.e. actualType *also* == bridge), the update would fail due to the perceived change in type. In practice it is okay to switch between any interface types that end up using a tap device, since libvirt just needs to attach the device to a new bridge. But in this case we were erroneously rejecting it due to a conditional that was too restrictive. This is what the code was doing: if (old->type != new->type) [allow update] else if ((oldActual == bridge and newActual == network) || (oldActual == network and newActual == bridge)) { [allow update] else [error] In the case described above though, old->type and new->type don't match, but oldActual and newActual are both 'bridge', so we get an error. This patch changes the inner conditional so that any combination of 'network' and 'bridge' for oldActual and newActual, since they both use a tap device connected to a bridge. Signed-off-by: Laine Stump <laine(a)redhat.com> --- src/qemu/qemu_hotplug.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index a5d57702eb..dc3bd8245f 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -3770,15 +3770,15 @@ qemuDomainChangeNet(virQEMUDriverPtr driver, * where this can only require a minor (or even no) change, * but in most cases we need to do a full reconnection. * - * If we switch (in either direction) between type='bridge' - * and type='network' (for a traditional managed virtual - * network that uses a host bridge, i.e. forward - * mode='route|nat'), we just need to change the bridge. + * As long as both the new and old types use a tap device + * connected to a host bridge (ie VIR_DOMAIN_NET_TYPE_NETWORK + * or VIR_DOMAIN_NET_TYPE_BRIDGE), we just need to connect to + * the new bridge. */ - if ((oldType == VIR_DOMAIN_NET_TYPE_NETWORK && - newType == VIR_DOMAIN_NET_TYPE_BRIDGE) || - (oldType == VIR_DOMAIN_NET_TYPE_BRIDGE && - newType == VIR_DOMAIN_NET_TYPE_NETWORK)) { + if ((oldType == VIR_DOMAIN_NET_TYPE_NETWORK || + oldType == VIR_DOMAIN_NET_TYPE_BRIDGE) && + (newType == VIR_DOMAIN_NET_TYPE_NETWORK || + newType == VIR_DOMAIN_NET_TYPE_BRIDGE)) { needBridgeChange = true; -- 2.25.4

3 2

[libvirt PATCH] conf: fix alignment in virObjectEvent to be 8 not 4 bytes
by Daniel P. Berrangé 04 Jun '20

04 Jun '20

The previous fix accidentally picked up a debug change that put alignment back at 4, not 8, bytes as it claimed: commit 37ae0426420a2f682cc96ee457a8cae9c0db27d3 Author: Daniel P. Berrangé <berrange(a)redhat.com> Date: Wed Jun 3 11:18:23 2020 +0100 conf: force 8 byte alignment for virObjectEvent Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed under the face-palm build breaker fix rule src/conf/object_event_private.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/object_event_private.h b/src/conf/object_event_private.h index 126464a9a5..80af043b9b 100644 --- a/src/conf/object_event_private.h +++ b/src/conf/object_event_private.h @@ -42,7 +42,7 @@ typedef void virConnectObjectEventGenericCallback cb, void *cbopaque); -struct __attribute__((aligned(4))) _virObjectEvent { +struct __attribute__((aligned(8))) _virObjectEvent { virObject parent; int eventID; virObjectMeta meta; -- 2.26.2

1 0

[PATCH] conf: force 8 byte alignment for virObjectEvent
by Daniel P. Berrangé 04 Jun '20

04 Jun '20

We need to be able to cast from virObjectEventPtr to one of its many subclasses. Some of these subclasses have 8 byte alignment on 32-bit platforms, but virObjectEventPtr only has 4 byte alignment. Previously the virObject base class had 8 byte alignment but this dropped to 4 byte when converted to inherit from GObject. This introduces cast alignment warnings on 32-bit: ../../src/conf/domain_event.c: In function 'virDomainEventDispatchDefaultFunc': ../../src/conf/domain_event.c:1656:30: error: cast increases required alignment of target type [-Werror=cast-align] 1656 | rtcChangeEvent = (virDomainEventRTCChangePtr)event; | ^ ../../src/conf/domain_event.c:1785:34: error: cast increases required alignment of target type [-Werror=cast-align] 1785 | balloonChangeEvent = (virDomainEventBalloonChangePtr)event; | ^ ../../src/conf/domain_event.c:1896:35: error: cast increases required alignment of target type [-Werror=cast-align] 1896 | blockThresholdEvent = (virDomainEventBlockThresholdPtr)event; | ^ ../../src/conf/domain_event.c: In function 'virDomainQemuMonitorEventDispatchFunc': ../../src/conf/domain_event.c:1974:24: error: cast increases required alignment of target type [-Werror=cast-align] 1974 | qemuMonitorEvent = (virDomainQemuMonitorEventPtr)event; | ^ ../../src/conf/domain_event.c: In function 'virDomainQemuMonitorEventFilter': ../../src/conf/domain_event.c:2179:20: error: cast increases required alignment of target type [-Werror=cast-align] 2179 | monitorEvent = (virDomainQemuMonitorEventPtr) event; | ^ Forcing 8-byte alignment on virObjectEventPtr removes the alignment increase during casts to subclasses. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Technically a build-breaker, but since we don't have any existing usage of __attribute__((aligned)), I wanted to get a second opinion on this approach. One alternative approach would be to switch one of the current "int" fields in virObjectEvent to "long long". src/conf/object_event_private.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/object_event_private.h b/src/conf/object_event_private.h index b31441c53a..126464a9a5 100644 --- a/src/conf/object_event_private.h +++ b/src/conf/object_event_private.h @@ -42,7 +42,7 @@ typedef void virConnectObjectEventGenericCallback cb, void *cbopaque); -struct _virObjectEvent { +struct __attribute__((aligned(4))) _virObjectEvent { virObject parent; int eventID; virObjectMeta meta; -- 2.24.1

5 4

[libvirt PATCH] gitdm: Add missing entries
by Andrea Bolognani 04 Jun '20

04 Jun '20

A few new individuals have contributed to libvirt since the last time the gitdm configuration was updated. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- docs/gitdm/groups/unaffiliated | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/gitdm/groups/unaffiliated b/docs/gitdm/groups/unaffiliated index a58731a683..6e9de7084a 100644 --- a/docs/gitdm/groups/unaffiliated +++ b/docs/gitdm/groups/unaffiliated @@ -14,6 +14,7 @@ gmx.de googlemail.com hotmail.com mail.ru +outlook.com pobox.com protonmail.com riseup.net @@ -39,6 +40,8 @@ bigon(a)bigon.be bugzilla.redhat.simon(a)arlott.org cardoe(a)cardoe.com charles(a)dyfis.net +cky(a)cky.nz +contact(a)puzio.waw.pl d.herrendoerfer(a)herrendoerfer.name dan(a)danny.cz debfx(a)fobos.de @@ -53,6 +56,7 @@ ibaldo(a)adinet.com.uy igor47(a)moomers.org infos(a)nafets.de intrigeri(a)boum.org +jaak(a)ristioja.ee james410(a)cowgill.org.uk james(a)shubin.ca jasper(a)humppa.nl -- 2.25.4

2 1

[PATCH 00/40] convert virObjects to GObject
by Rafael Fonseca 04 Jun '20

04 Jun '20

This patch series convert various simple instances of virObject to a GObject equivalent. virLockableObject and virObjects which are subclassed will be covered in future patchsets. New in v3: - merge *Dispose back into *Finalize - rebased on top of master Rafael Fonseca (40): util: virresctrl: convert classes to GObject conf: capabilities: convert virCaps to GOBject qemu: convert virQEMUCaps to GObject util: add function to unref array of GObjects rpc: convert virNetClientProgram to GObject rpc: convert virNetServerProgram to GObject conf: convert virDomainXMLOption to GObject bhyve: convert bhyveMonitor to GObject bhyve: convert virBhyveDriverConfig to GObject rpc: convert virNetServerService to GObject conf: convert virDomainCapsCPUModels to GObject util: convert dnsmasqCaps to GObject conf: convert virDomainChrSourceDef to GObject rpc: gendispatch: prepare for GObject conversion admin: convert virAdmServer to GObject admin: convert virAdmClient to GObject datatypes: convert virDomainCheckpoint to GObject datatypes: convert virDomainSnapshot to GObject datatypes: convert virNWFilter to GObject datatypes: convert virNWFilterBinding to GObject datatypes: convert virNetwork to GObject datatypes: convert virNetworkPort to GObject datatypes: convert virInterface to GObject datatypes: convert virStoragePool to GObject datatypes: convert virStorageVol to GObject datatypes: convert virNodeDevice to GObject datatypes: convert virSecret to GObject datatypes: convert virStream to GObject datatypes: convert virDomain to GObject rpc: gendispatch: use g_autoptr where possible conf: convert virNetworkXMLOption to GObject lxc: convert virLXCDriverConfig to GObject libxl: convert libxlDriverConfig to GObject hypervisor: convert virHostdevManager to GObject libxl: convert libxlMigrationDstArgs to GObject qemu: convert qemuBlockJobData to GObject qemu: convert virQEMUDriverConfig to GObject conf: convert virDomain*Private to GObject conf: convert virSaveCookie to GObject util: convert virStorageSource to GObject src/admin/admin_remote.c | 9 +- src/admin/libvirt-admin.c | 4 +- src/admin/libvirt_admin_private.syms | 4 +- src/bhyve/bhyve_capabilities.c | 19 +- src/bhyve/bhyve_conf.c | 36 +- src/bhyve/bhyve_driver.c | 33 +- src/bhyve/bhyve_monitor.c | 37 +- src/bhyve/bhyve_monitor.h | 3 +- src/bhyve/bhyve_utils.h | 11 +- src/conf/capabilities.c | 41 +- src/conf/capabilities.h | 6 +- src/conf/domain_capabilities.c | 48 +- src/conf/domain_capabilities.h | 10 +- src/conf/domain_conf.c | 117 ++--- src/conf/domain_conf.h | 36 +- src/conf/domain_event.c | 58 +-- src/conf/network_conf.c | 24 +- src/conf/network_conf.h | 12 +- src/conf/network_event.c | 7 +- src/conf/node_device_event.c | 11 +- src/conf/node_device_util.c | 4 +- src/conf/secret_event.c | 15 +- src/conf/snapshot_conf.c | 2 +- src/conf/snapshot_conf.h | 2 +- src/conf/storage_capabilities.c | 4 +- src/conf/storage_event.c | 15 +- src/conf/virchrdev.c | 4 +- src/conf/virconftypes.h | 3 +- src/conf/virdomaincheckpointobjlist.c | 7 +- src/conf/virdomainsnapshotobjlist.c | 7 +- src/conf/virinterfaceobj.c | 5 +- src/conf/virnetworkobj.c | 10 +- src/conf/virnodedeviceobj.c | 3 +- src/conf/virnwfilterbindingobjlist.c | 2 +- src/conf/virnwfilterobj.c | 7 +- src/conf/virsavecookie.c | 10 +- src/conf/virsavecookie.h | 14 +- src/conf/virsecretobj.c | 2 +- src/conf/virstorageobj.c | 4 +- src/datatypes.c | 658 +++++++++++++++--------- src/datatypes.h | 219 ++++---- src/esx/esx_driver.c | 33 +- src/hyperv/hyperv_driver.c | 8 +- src/hypervisor/virhostdev.c | 31 +- src/hypervisor/virhostdev.h | 13 +- src/interface/interface_backend_netcf.c | 7 +- src/interface/interface_backend_udev.c | 8 +- src/libvirt-domain-checkpoint.c | 7 +- src/libvirt-domain-snapshot.c | 7 +- src/libvirt-domain.c | 6 +- src/libvirt-interface.c | 6 +- src/libvirt-network.c | 14 +- src/libvirt-nodedev.c | 6 +- src/libvirt-nwfilter.c | 14 +- src/libvirt-secret.c | 7 +- src/libvirt-storage.c | 12 +- src/libvirt-stream.c | 7 +- src/libvirt_private.syms | 35 +- src/libxl/libxl_capabilities.c | 19 +- src/libxl/libxl_conf.c | 56 +- src/libxl/libxl_conf.h | 12 +- src/libxl/libxl_driver.c | 175 +++---- src/libxl/libxl_migration.c | 92 ++-- src/libxl/xen_common.c | 3 +- src/locking/lock_daemon.c | 28 +- src/locking/lock_driver_lockd.c | 19 +- src/locking/sanlock_helper.c | 5 +- src/logging/log_daemon.c | 28 +- src/logging/log_manager.c | 15 +- src/lxc/lxc_conf.c | 46 +- src/lxc/lxc_conf.h | 10 +- src/lxc/lxc_controller.c | 20 +- src/lxc/lxc_driver.c | 98 ++-- src/lxc/lxc_monitor.c | 2 +- src/lxc/lxc_process.c | 35 +- src/network/bridge_driver.c | 24 +- src/nwfilter/nwfilter_driver.c | 3 +- src/openvz/openvz_conf.c | 8 +- src/qemu/qemu_blockjob.c | 119 ++--- src/qemu/qemu_blockjob.h | 15 +- src/qemu/qemu_capabilities.c | 165 +++--- src/qemu/qemu_capabilities.h | 9 +- src/qemu/qemu_conf.c | 42 +- src/qemu/qemu_conf.h | 19 +- src/qemu/qemu_domain.c | 436 +++++++--------- src/qemu/qemu_domain.h | 157 ++++-- src/qemu/qemu_driver.c | 34 +- src/qemu/qemu_hotplug.c | 3 +- src/qemu/qemu_migration.c | 34 +- src/qemu/qemu_process.c | 20 +- src/qemu/qemu_virtiofs.c | 12 +- src/remote/remote_daemon.c | 52 +- src/remote/remote_daemon_dispatch.c | 188 +++---- src/remote/remote_daemon_stream.c | 6 +- src/remote/remote_driver.c | 178 +++---- src/rpc/gendispatch.pl | 90 ++-- src/rpc/virnetclient.c | 7 +- src/rpc/virnetclientprogram.c | 29 +- src/rpc/virnetclientprogram.h | 10 +- src/rpc/virnetclientstream.c | 4 +- src/rpc/virnetserver.c | 21 +- src/rpc/virnetserverprogram.c | 30 +- src/rpc/virnetserverprogram.h | 17 +- src/rpc/virnetserverservice.c | 87 ++-- src/security/virt-aa-helper.c | 9 +- src/storage/storage_backend.c | 3 +- src/storage/storage_driver.c | 7 +- src/storage/storage_util.c | 4 +- src/test/test_driver.c | 33 +- src/util/virdnsmasq.c | 56 +- src/util/virdnsmasq.h | 6 +- src/util/virfdstream.c | 4 +- src/util/virfilecache.c | 43 +- src/util/virfilecache.h | 12 +- src/util/virobject.c | 24 + src/util/virobject.h | 4 + src/util/virresctrl.c | 155 +++--- src/util/virresctrl.h | 15 +- src/util/virsecret.c | 3 +- src/util/virstoragefile.c | 42 +- src/util/virstoragefile.h | 9 +- src/vbox/vbox_common.c | 19 +- src/vmware/vmware_conf.c | 13 +- src/vz/vz_driver.c | 33 +- src/vz/vz_sdk.c | 22 +- tests/bhyveargv2xmltest.c | 4 +- tests/bhyvexml2argvtest.c | 4 +- tests/bhyvexml2xmltest.c | 4 +- tests/cputest.c | 48 +- tests/domaincapstest.c | 5 +- tests/domainconftest.c | 4 +- tests/genericxml2xmltest.c | 4 +- tests/networkxml2conftest.c | 10 +- tests/networkxml2xmltest.c | 3 +- tests/openvzutilstest.c | 4 +- tests/qemublocktest.c | 3 +- tests/qemucapabilitiestest.c | 9 +- tests/qemucaps2xmltest.c | 29 +- tests/qemucapsprobe.c | 4 +- tests/qemuhotplugtest.c | 6 +- tests/qemumemlocktest.c | 3 +- tests/testutils.c | 4 +- tests/testutilslxc.c | 22 +- tests/testutilsqemu.c | 31 +- tests/testutilsxen.c | 7 +- tests/vircaps2xmltest.c | 6 +- tests/vircapstest.c | 14 +- tests/virfilecachetest.c | 69 ++- tests/virnetdaemontest.c | 4 +- tests/virresctrltest.c | 6 +- tests/vmx2xmltest.c | 10 +- tests/xml2vmxtest.c | 12 +- 152 files changed, 2411 insertions(+), 2660 deletions(-) -- 2.26.2

3 55

[PATCH 0/6] Expose QEMU's -fw_cfg
by Michal Privoznik 03 Jun '20

03 Jun '20

There was a discussion whether to do this or not: https://www.redhat.com/archives/libvir-list/2020-May/msg00954.html Before you start reviewing, naming is hard and I was unable to come up with a good element names and place, so suggestions are more than welcome! Michal Prívozník (6): domain_conf: Format NS always last conf: Add firmware blob configuration qemu: Validate firmware blob configuration qemu: Introduce fw_cfg capability secdrivers: Relabel firmware config files qemu: Generate command line for -fw_cfg docs/formatdomain.html.in | 30 +++++ docs/schemas/domaincommon.rng | 24 ++++ src/conf/domain_conf.c | 114 +++++++++++++++++- src/conf/domain_conf.h | 11 ++ src/conf/virconftypes.h | 3 + src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_command.c | 38 ++++++ src/qemu/qemu_validate.c | 38 ++++++ src/security/security_dac.c | 14 +++ src/security/security_selinux.c | 13 ++ src/security/virt-aa-helper.c | 6 + .../caps_2.10.0.aarch64.xml | 1 + .../caps_2.10.0.ppc64.xml | 1 + .../caps_2.10.0.s390x.xml | 1 + .../caps_2.10.0.x86_64.xml | 1 + .../caps_2.11.0.s390x.xml | 1 + .../caps_2.11.0.x86_64.xml | 1 + .../caps_2.12.0.aarch64.xml | 1 + .../caps_2.12.0.ppc64.xml | 1 + .../caps_2.12.0.s390x.xml | 1 + .../caps_2.12.0.x86_64.xml | 1 + .../caps_2.4.0.x86_64.xml | 1 + .../caps_2.5.0.x86_64.xml | 1 + .../caps_2.6.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_2.6.0.ppc64.xml | 1 + .../caps_2.6.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_2.7.0.s390x.xml | 1 + .../caps_2.7.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_2.8.0.s390x.xml | 1 + .../caps_2.8.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_2.9.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_2.9.0.s390x.xml | 1 + .../caps_2.9.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 1 + .../caps_3.0.0.riscv32.xml | 1 + .../caps_3.0.0.riscv64.xml | 1 + .../qemucapabilitiesdata/caps_3.0.0.s390x.xml | 1 + .../caps_3.0.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1 + .../caps_3.1.0.x86_64.xml | 1 + .../caps_4.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 + .../caps_4.0.0.riscv32.xml | 1 + .../caps_4.0.0.riscv64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 1 + .../caps_4.0.0.x86_64.xml | 1 + .../caps_4.1.0.x86_64.xml | 1 + .../caps_4.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 + .../caps_4.2.0.x86_64.xml | 1 + .../caps_5.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 + .../caps_5.0.0.riscv64.xml | 1 + .../caps_5.0.0.x86_64.xml | 1 + .../caps_5.1.0.x86_64.xml | 1 + tests/qemuxml2argvdata/fw_cfg.args | 32 +++++ tests/qemuxml2argvdata/fw_cfg.xml | 40 ++++++ tests/qemuxml2argvtest.c | 1 + tests/qemuxml2xmloutdata/fw_cfg.xml | 1 + tests/qemuxml2xmltest.c | 1 + 62 files changed, 413 insertions(+), 5 deletions(-) create mode 100644 tests/qemuxml2argvdata/fw_cfg.args create mode 100644 tests/qemuxml2argvdata/fw_cfg.xml create mode 120000 tests/qemuxml2xmloutdata/fw_cfg.xml -- 2.26.2

2 7

[PATCH] autogen.sh: Restore --no-git (avoid git submodule update)
by Ian Jackson 03 Jun '20

03 Jun '20

Prior to 2621d48f005a "gnulib: delete all gnulib integration", one could pass ./autogen.sh --no-git to prevent the libvirt build system from running git submodule update. This feature is needed by systems like the Xen Project CI which want to explicitly control the revisions of every tree. These will typically arrange to initialise the submodules check out the right version of everything, and then expect the build system not to mess with it any more. Despite to the old documentation comments referring only to gnulib, the --no-git feature is required not only because of gnulib but also because of the other submodule, src/keycodemapdb. (And in any case, even if it were no longer required because all the submodules were removed, it ought ideally to have been retained as a no-op for compaibility reasons.) So restore the --no-git feature. Because of the way the argument parsing of autogen.sh works, it is easiest to recognise this option only if it comes first. This works for the Xen Project CI, which has always passed this option first. If something else is using this option (and hasn't introduced a different workaround in the meantime), not in the first position, then perhaps a more sophisticated approach will be needed. But I think this will do for now. Signed-off-by: Ian Jackson <ian.jackson(a)eu.citrix.com> --- autogen.sh | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/autogen.sh b/autogen.sh index 4e1bbceb0a..1c98273452 100755 --- a/autogen.sh +++ b/autogen.sh @@ -1,5 +1,10 @@ #!/bin/sh # Run this to generate all the initial makefiles, etc. +# +# THe following options must come first. All other or subsequent +# arguments are passed to configure: +# --no-git skip `git submodule update --init` + test -n "$srcdir" || srcdir=$(dirname "$0") test -n "$srcdir" || srcdir=. @@ -13,7 +18,11 @@ cd "$srcdir" exit 1 } -git submodule update --init || exit 1 +if [ "x$1" = x--no-git ]; then + shift +else + git submodule update --init || exit 1 +fi autoreconf --verbose --force --install || exit 1 -- 2.11.0

4 7

[PATCH] libxl: Normalize MAC address in device conf when hotplugging a netdev
by Jim Fehlig 03 Jun '20

03 Jun '20

Similar to commit 6c17606b7cc, normalize the MAC addresses in persistent and live device config to avoid a different MAC address for the device once the VM is rebooted and persistent config takes affect. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- src/libxl/libxl_driver.c | 56 +++++++++++++++++++++++++++++++++------- 1 file changed, 46 insertions(+), 10 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 63ec0a2188..a80bc3fe3a 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -4096,6 +4096,31 @@ libxlDomainUpdateDeviceConfig(virDomainDefPtr vmdef, virDomainDeviceDefPtr dev) } +static void +libxlDomainAttachDeviceNormalize(const virDomainDeviceDef *devConf, + virDomainDeviceDefPtr devLive) +{ + /* + * Fixup anything that needs to be identical in the live and + * config versions of DeviceDef, but might not be. Do this by + * changing the contents of devLive. This is done after all + * post-parse tweaks and validation, so be very careful about what + * changes are made. + */ + + /* MAC address should be identical in both DeviceDefs, but if it + * wasn't specified in the XML, and was instead autogenerated, it + * will be different for the two since they are each the result of + * a separate parser call. If it *was* specified, it will already + * be the same, so copying does no harm. + */ + + if (devConf->type == VIR_DOMAIN_DEVICE_NET) + virMacAddrSet(&devLive->data.net->mac, &devConf->data.net->mac); + +} + + static int libxlDomainAttachDeviceFlags(virDomainPtr dom, const char *xml, unsigned int flags) @@ -4104,7 +4129,9 @@ libxlDomainAttachDeviceFlags(virDomainPtr dom, const char *xml, libxlDriverConfigPtr cfg = libxlDriverConfigGet(driver); virDomainObjPtr vm = NULL; virDomainDefPtr vmdef = NULL; - virDomainDeviceDefPtr dev = NULL; + virDomainDeviceDefPtr devConf = NULL; + virDomainDeviceDef devConfSave = { 0 }; + virDomainDeviceDefPtr devLive = NULL; int ret = -1; virCheckFlags(VIR_DOMAIN_DEVICE_MODIFY_LIVE | @@ -4123,28 +4150,36 @@ libxlDomainAttachDeviceFlags(virDomainPtr dom, const char *xml, goto endjob; if (flags & VIR_DOMAIN_DEVICE_MODIFY_CONFIG) { - if (!(dev = virDomainDeviceDefParse(xml, vm->def, - driver->xmlopt, NULL, - VIR_DOMAIN_DEF_PARSE_INACTIVE))) + if (!(devConf = virDomainDeviceDefParse(xml, vm->def, + driver->xmlopt, NULL, + VIR_DOMAIN_DEF_PARSE_INACTIVE))) goto endjob; /* Make a copy for updated domain. */ if (!(vmdef = virDomainObjCopyPersistentDef(vm, driver->xmlopt, NULL))) goto endjob; - if (libxlDomainAttachDeviceConfig(vmdef, dev) < 0) + /* + * devConf will be NULLed out by + * libxlDomainAttachDeviceConfig(), so save it for later use by + * libxlDomainAttachDeviceNormalize() + */ + devConfSave = *devConf; + + if (libxlDomainAttachDeviceConfig(vmdef, devConf) < 0) goto endjob; } if (flags & VIR_DOMAIN_DEVICE_MODIFY_LIVE) { - /* If dev exists it was created to modify the domain config. Free it. */ - virDomainDeviceDefFree(dev); - if (!(dev = virDomainDeviceDefParse(xml, vm->def, + if (!(devLive = virDomainDeviceDefParse(xml, vm->def, driver->xmlopt, NULL, VIR_DOMAIN_DEF_PARSE_INACTIVE))) goto endjob; - if (libxlDomainAttachDeviceLive(driver, vm, dev) < 0) + if (flags & VIR_DOMAIN_AFFECT_CONFIG) + libxlDomainAttachDeviceNormalize(&devConfSave, devLive); + + if (libxlDomainAttachDeviceLive(driver, vm, devLive) < 0) goto endjob; /* @@ -4171,7 +4206,8 @@ libxlDomainAttachDeviceFlags(virDomainPtr dom, const char *xml, cleanup: virDomainDefFree(vmdef); - virDomainDeviceDefFree(dev); + virDomainDeviceDefFree(devConf); + virDomainDeviceDefFree(devLive); virDomainObjEndAPI(&vm); virObjectUnref(cfg); return ret; -- 2.26.0

2 2

[libvirt PATCH 0/5] news: Convert to reStructuredText
by Andrea Bolognani 03 Jun '20

03 Jun '20

Rationale in patch 4/5, in case that diffstat is not enough of a selling point for you ;) Some of the patches in this series are __heavily__ snipped. browse: https://gitlab.com/abologna/libvirt/-/tree/news-convert-cleanup git fetch: https://gitlab.com/abologna/libvirt.git news-convert-cleanup Andrea Bolognani (5): docs: Fix dot_rst_html_in definition news: Point to GitLab for full git log news: Output reStructuredText for the ASCII version news: Convert to reStructuredText news: Add information about old releases Makefile.am | 22 +- NEWS.rst | 4077 ++++++++++++++++++++++++++++ docs/Makefile.am | 27 +- docs/libvirt.css | 15 - docs/news-2005.html.in | 28 - docs/news-2006.html.in | 354 --- docs/news-2007.html.in | 534 ---- docs/news-2008.html.in | 580 ---- docs/news-2009.html.in | 1603 ----------- docs/news-2010.html.in | 2218 --------------- docs/news-2011.html.in | 3314 ----------------------- docs/news-2012.html.in | 3012 --------------------- docs/news-2013.html.in | 3675 ------------------------- docs/news-2014.html.in | 3418 ------------------------ docs/news-2015.html.in | 2864 -------------------- docs/news-2016.html.in | 3740 -------------------------- docs/news-ascii.xsl | 69 - docs/news-html.xsl | 106 - docs/news.rng | 72 - docs/news.xml | 5473 -------------------------------------- scripts/reformat-news.py | 102 - tests/virschematest.c | 2 - 22 files changed, 4089 insertions(+), 31216 deletions(-) create mode 100644 NEWS.rst delete mode 100644 docs/news-2005.html.in delete mode 100644 docs/news-2006.html.in delete mode 100644 docs/news-2007.html.in delete mode 100644 docs/news-2008.html.in delete mode 100644 docs/news-2009.html.in delete mode 100644 docs/news-2010.html.in delete mode 100644 docs/news-2011.html.in delete mode 100644 docs/news-2012.html.in delete mode 100644 docs/news-2013.html.in delete mode 100644 docs/news-2014.html.in delete mode 100644 docs/news-2015.html.in delete mode 100644 docs/news-2016.html.in delete mode 100644 docs/news-ascii.xsl delete mode 100644 docs/news-html.xsl delete mode 100644 docs/news.rng delete mode 100644 docs/news.xml delete mode 100755 scripts/reformat-news.py -- 2.25.4

2 13

[PATCH 0/2] Use more of VIR_XPATH_NODE_AUTORESTORE
by Michal Privoznik 03 Jun '20

03 Jun '20

2 4

[libvirt PATCH 0/7] po: updates to switch over to use of Weblate
by Daniel P. Berrangé 03 Jun '20

03 Jun '20

The Fedora translation team has stopped using Zanata because the software itself is dead upstream. In its place is the Weblate platform. In theory we should have been able to work with Weblate in the same way as we did for Zanata, pushing a pot file periodically, and pulling .po files periodically. In practice this fails for libvirt.git because Weblates RPC API doesn't scale sufficiently well. It will frequently throw errors with the large libvirt.pot file and it gets slower at an exponential rate as you add more languages. Weblate has another mode of operating though which is way more common, whereby it directly pulls a .pot from your git repo, and then directly pushes .po files back, either using a trusted SSH key, or by opening a merge request for GitLab/GitHub/etc. This is the mode we're going to have to use in libvirt projects. Compared to what we're currently doing with Zanata the downsides are: - We have to store libvirt.pot in git and refresh it periodically - The .po files are only partially minimized, as while they have locations stripped, they still contain non-translated msgids The plussides are - We don't have to interact with Weblate at all, only the libvirt git repo - We'll be able to use the normal meson i18n integration, merely by calling i18n.gettext(meson.project_name(), args: ['--sort-output'], preset: 'glib') I'm intending to open discussion with weblate maintainers to see if either of those two downsides can be eliminated via feature enhancements to Weblate. In the meanwhile we just have to accept them, as otherwise we're not going to get any translations since Zanata is dead. Daniel P. Berrangé (7): po: switch to using LINGUAS file for list of languages po: delete empty translations po: refresh to drop unused translations po: rename the .mini.po files to have just a .po suffix po: generate .pot file with strings in alphabetical order po: stop stripping non-translated strings from po files po: go back to storing the .pot file in git Makefile.am | 1 - po/LINGUAS | 42 + po/Makefile.am | 50 +- po/af.mini.po | 19 - po/am.mini.po | 19 - po/anp.mini.po | 19 - po/ar.mini.po | 23 - po/{as.mini.po => as.po} | 402 +- po/ast.mini.po | 19 - po/bal.mini.po | 19 - po/be.mini.po | 20 - po/{bg.mini.po => bg.po} | 5 +- po/bn.mini.po | 21 - po/{bn_IN.mini.po => bn_IN.po} | 126 +- po/bo.mini.po | 19 - po/br.mini.po | 19 - po/brx.mini.po | 19 - po/{bs.mini.po => bs.po} | 5 +- po/{ca.mini.po => ca.po} | 15 +- po/{cs.mini.po => cs.po} | 523 +- po/cy.mini.po | 23 - po/{da.mini.po => da.po} | 5 +- po/{de.mini.po => de.po} | 408 +- po/de_CH.mini.po | 19 - po/{el.mini.po => el.po} | 2 +- po/{en_GB.mini.po => en_GB.po} | 402 +- po/eo.mini.po | 19 - po/{es.mini.po => es.po} | 409 +- po/et.mini.po | 21 - po/eu.mini.po | 21 - po/fa.mini.po | 19 - po/{fi.mini.po => fi.po} | 26 +- po/fil.mini.po | 19 - po/{fr.mini.po => fr.po} | 75 +- po/fur.mini.po | 19 - po/ga.mini.po | 20 - po/gl.mini.po | 21 - po/{gu.mini.po => gu.po} | 408 +- po/he.mini.po | 21 - po/{hi.mini.po => hi.po} | 300 +- po/hr.mini.po | 20 - po/{hu.mini.po => hu.po} | 5 +- po/ia.mini.po | 19 - po/{id.mini.po => id.po} | 2 +- po/ilo.mini.po | 19 - po/is.mini.po | 21 - po/{it.mini.po => it.po} | 175 +- po/{ja.mini.po => ja.po} | 407 +- po/ka.mini.po | 21 - po/kk.mini.po | 19 - po/km.mini.po | 19 - po/{kn.mini.po => kn.po} | 407 +- po/{ko.mini.po => ko.po} | 240 +- po/kw.mini.po | 20 - po/kw(a)kkcor.mini.po | 20 - po/kw(a)uccor.mini.po | 20 - po/kw_GB.mini.po | 20 - po/ky.mini.po | 19 - po/libvirt.pot | 48582 +++++++++++++++++++++++++ po/lt.mini.po | 22 - po/lv.mini.po | 22 - po/mai.mini.po | 19 - po/{mk.mini.po => mk.po} | 5 +- po/{ml.mini.po => ml.po} | 402 +- po/mn.mini.po | 19 - po/{mr.mini.po => mr.po} | 434 +- po/{ms.mini.po => ms.po} | 2 +- po/my.mini.po | 19 - po/{nb.mini.po => nb.po} | 5 +- po/nds.mini.po | 19 - po/ne.mini.po | 19 - po/{nl.mini.po => nl.po} | 215 +- po/nn.mini.po | 21 - po/nso.mini.po | 21 - po/{or.mini.po => or.po} | 375 +- po/{pa.mini.po => pa.po} | 402 +- po/{pl.mini.po => pl.po} | 239 +- po/{pt.mini.po => pt.po} | 5 +- po/{pt_BR.mini.po => pt_BR.po} | 407 +- po/ro.mini.po | 22 - po/{ru.mini.po => ru.po} | 376 +- po/si.mini.po | 21 - po/sk.mini.po | 21 - po/sl.mini.po | 22 - po/sq.mini.po | 23 - po/{sr.mini.po => sr.po} | 16 +- po/{sr(a)latin.mini.po => sr(a)latin.po} | 16 +- po/{sv.mini.po => sv.po} | 105 +- po/{ta.mini.po => ta.po} | 407 +- po/{te.mini.po => te.po} | 402 +- po/tg.mini.po | 19 - po/th.mini.po | 21 - po/tr.mini.po | 21 - po/tw.mini.po | 19 - po/{uk.mini.po => uk.po} | 534 +- po/ur.mini.po | 21 - po/{vi.mini.po => vi.po} | 193 +- po/wba.mini.po | 19 - po/yo.mini.po | 19 - po/{zh_CN.mini.po => zh_CN.po} | 421 +- po/zh_HK.mini.po | 19 - po/{zh_TW.mini.po => zh_TW.po} | 9 +- po/zu.mini.po | 21 - scripts/minimize-po.py | 54 - 104 files changed, 48678 insertions(+), 10512 deletions(-) create mode 100644 po/LINGUAS delete mode 100644 po/af.mini.po delete mode 100644 po/am.mini.po delete mode 100644 po/anp.mini.po delete mode 100644 po/ar.mini.po rename po/{as.mini.po => as.po} (98%) delete mode 100644 po/ast.mini.po delete mode 100644 po/bal.mini.po delete mode 100644 po/be.mini.po rename po/{bg.mini.po => bg.po} (99%) delete mode 100644 po/bn.mini.po rename po/{bn_IN.mini.po => bn_IN.po} (98%) delete mode 100644 po/bo.mini.po delete mode 100644 po/br.mini.po delete mode 100644 po/brx.mini.po rename po/{bs.mini.po => bs.po} (99%) rename po/{ca.mini.po => ca.po} (99%) rename po/{cs.mini.po => cs.po} (98%) delete mode 100644 po/cy.mini.po rename po/{da.mini.po => da.po} (99%) rename po/{de.mini.po => de.po} (97%) delete mode 100644 po/de_CH.mini.po rename po/{el.mini.po => el.po} (99%) rename po/{en_GB.mini.po => en_GB.po} (97%) delete mode 100644 po/eo.mini.po rename po/{es.mini.po => es.po} (97%) delete mode 100644 po/et.mini.po delete mode 100644 po/eu.mini.po delete mode 100644 po/fa.mini.po rename po/{fi.mini.po => fi.po} (98%) delete mode 100644 po/fil.mini.po rename po/{fr.mini.po => fr.po} (98%) delete mode 100644 po/fur.mini.po delete mode 100644 po/ga.mini.po delete mode 100644 po/gl.mini.po rename po/{gu.mini.po => gu.po} (97%) delete mode 100644 po/he.mini.po rename po/{hi.mini.po => hi.po} (97%) delete mode 100644 po/hr.mini.po rename po/{hu.mini.po => hu.po} (99%) delete mode 100644 po/ia.mini.po rename po/{id.mini.po => id.po} (99%) delete mode 100644 po/ilo.mini.po delete mode 100644 po/is.mini.po rename po/{it.mini.po => it.po} (96%) rename po/{ja.mini.po => ja.po} (97%) delete mode 100644 po/ka.mini.po delete mode 100644 po/kk.mini.po delete mode 100644 po/km.mini.po rename po/{kn.mini.po => kn.po} (97%) rename po/{ko.mini.po => ko.po} (97%) delete mode 100644 po/kw.mini.po delete mode 100644 po/kw(a)kkcor.mini.po delete mode 100644 po/kw(a)uccor.mini.po delete mode 100644 po/kw_GB.mini.po delete mode 100644 po/ky.mini.po create mode 100644 po/libvirt.pot delete mode 100644 po/lt.mini.po delete mode 100644 po/lv.mini.po delete mode 100644 po/mai.mini.po rename po/{mk.mini.po => mk.po} (99%) rename po/{ml.mini.po => ml.po} (97%) delete mode 100644 po/mn.mini.po rename po/{mr.mini.po => mr.po} (98%) rename po/{ms.mini.po => ms.po} (98%) delete mode 100644 po/my.mini.po rename po/{nb.mini.po => nb.po} (98%) delete mode 100644 po/nds.mini.po delete mode 100644 po/ne.mini.po rename po/{nl.mini.po => nl.po} (97%) delete mode 100644 po/nn.mini.po delete mode 100644 po/nso.mini.po rename po/{or.mini.po => or.po} (97%) rename po/{pa.mini.po => pa.po} (97%) rename po/{pl.mini.po => pl.po} (97%) rename po/{pt.mini.po => pt.po} (99%) rename po/{pt_BR.mini.po => pt_BR.po} (97%) delete mode 100644 po/ro.mini.po rename po/{ru.mini.po => ru.po} (98%) delete mode 100644 po/si.mini.po delete mode 100644 po/sk.mini.po delete mode 100644 po/sl.mini.po delete mode 100644 po/sq.mini.po rename po/{sr.mini.po => sr.po} (99%) rename po/{sr(a)latin.mini.po => sr(a)latin.po} (99%) rename po/{sv.mini.po => sv.po} (95%) rename po/{ta.mini.po => ta.po} (98%) rename po/{te.mini.po => te.po} (97%) delete mode 100644 po/tg.mini.po delete mode 100644 po/th.mini.po delete mode 100644 po/tr.mini.po delete mode 100644 po/tw.mini.po rename po/{uk.mini.po => uk.po} (98%) delete mode 100644 po/ur.mini.po rename po/{vi.mini.po => vi.po} (97%) delete mode 100644 po/wba.mini.po delete mode 100644 po/yo.mini.po rename po/{zh_CN.mini.po => zh_CN.po} (98%) delete mode 100644 po/zh_HK.mini.po rename po/{zh_TW.mini.po => zh_TW.po} (99%) delete mode 100644 po/zu.mini.po delete mode 100755 scripts/minimize-po.py -- 2.26.2

2 8

[libvirt PATCH] tools: libvirt-guests: correctly check shutdown value
by Ján Tomko 03 Jun '20

03 Jun '20

The variable cleanup introduced a typo. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> Fixes: 08071ec0f113bb1fe8dcc263cb6bf87529e8b76b Reported-by: Bronek Kozicki Closes: https://gitlab.com/libvirt/libvirt/-/issues/27 --- Pushed as trivial. tools/libvirt-guests.sh.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libvirt-guests.sh.in b/tools/libvirt-guests.sh.in index 7af24dab3b..534c4d5e0f 100644 --- a/tools/libvirt-guests.sh.in +++ b/tools/libvirt-guests.sh.in @@ -444,7 +444,7 @@ stop() { # last stop was not followed by start [ -f "$LISTFILE" ] && return 0 - if [ "/x$ON_SHUTDOWN" = xshutdown ]; then + if [ "x$ON_SHUTDOWN" = xshutdown ]; then suspending=false if [ $SHUTDOWN_TIMEOUT -lt 0 ]; then gettext "SHUTDOWN_TIMEOUT must be equal or greater than 0" -- 2.25.4

1 0

[PATCH] virsysinfo: Parse OEM strings
by Michal Privoznik 03 Jun '20

03 Jun '20

Setting OEM strings for a domain was introduced in v4.1.0-rc1~315. However, any application that wanted to use them (e.g. to point to an URL where a config file is stored) had to 'dmidecode -u --oem-string N' (where N is index of the string). Well, we can expose them under our <sysinfo/> XML and if the domain is running Libvirt inside it can be obtained using virConnectGetSysinfo() API. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/util/virsysinfo.c | 60 ++++++++++++++++++++++++++++- tests/sysinfodata/x86sysinfo.data | 10 +++++ tests/sysinfodata/x86sysinfo.expect | 10 +++++ 3 files changed, 79 insertions(+), 1 deletion(-) diff --git a/src/util/virsysinfo.c b/src/util/virsysinfo.c index 41f4d1cff9..94f7ca8811 100644 --- a/src/util/virsysinfo.c +++ b/src/util/virsysinfo.c @@ -919,6 +919,61 @@ virSysinfoParseX86Chassis(const char *base, } +static int +virSysinfoParseOEMStrings(const char *base, + virSysinfoOEMStringsDefPtr *stringsRet) +{ + virSysinfoOEMStringsDefPtr strings = NULL; + int ret = -1; + const char *cur; + + if (!(cur = strstr(base, "OEM Strings"))) + return 0; + + if (VIR_ALLOC(strings) < 0) + return -1; + + while ((cur = strstr(cur, "String "))) { + char *eol; + + cur += 7; + + if (!(eol = strchr(cur, '\n'))) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("Malformed output of dmidecode")); + goto cleanup; + } + + while (g_ascii_isdigit(*cur)) + cur++; + + if (*cur != ':') { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("Malformed output of dmidecode")); + goto cleanup; + } + + cur += 2; + + virSkipSpacesBackwards(cur, &eol); + if (!eol) + continue; + + if (VIR_EXPAND_N(strings->values, strings->nvalues, 1) < 0) + goto cleanup; + + strings->values[strings->nvalues - 1] = g_strndup(cur, eol - cur); + } + + *stringsRet = g_steal_pointer(&strings); + ret = 0; + + cleanup: + virSysinfoOEMStringsDefFree(strings); + return ret; +} + + static int virSysinfoParseX86Processor(const char *base, virSysinfoDefPtr ret) { @@ -1132,7 +1187,7 @@ virSysinfoReadDMI(void) return NULL; } - cmd = virCommandNewArgList(path, "-q", "-t", "0,1,2,3,4,17", NULL); + cmd = virCommandNewArgList(path, "-q", "-t", "0,1,2,3,4,11,17", NULL); VIR_FREE(path); virCommandSetOutputBuffer(cmd, &outbuf); if (virCommandRun(cmd, NULL) < 0) @@ -1155,6 +1210,9 @@ virSysinfoReadDMI(void) if (virSysinfoParseX86Chassis(outbuf, &ret->chassis) < 0) goto error; + if (virSysinfoParseOEMStrings(outbuf, &ret->oemStrings) < 0) + goto error; + ret->nprocessor = 0; ret->processor = NULL; if (virSysinfoParseX86Processor(outbuf, ret) < 0) diff --git a/tests/sysinfodata/x86sysinfo.data b/tests/sysinfodata/x86sysinfo.data index 426261041d..5615e144fb 100644 --- a/tests/sysinfodata/x86sysinfo.data +++ b/tests/sysinfodata/x86sysinfo.data @@ -81,3 +81,13 @@ Memory Device Serial Number: 29057112 Asset Tag: 0839 Part Number: IMSH2GS13A1F1C-10F + +OEM Strings + String 1: Default string + String 2: Default string + String 3: MIAMI + String 4: Default string + String 5: FFFFFFFFFFFFF + String 6: FFFFFFFFFFFFF + String 7: FFFFFFFFFFFFF + String 8: Default string diff --git a/tests/sysinfodata/x86sysinfo.expect b/tests/sysinfodata/x86sysinfo.expect index fcdd790cbd..118cc4277e 100644 --- a/tests/sysinfodata/x86sysinfo.expect +++ b/tests/sysinfodata/x86sysinfo.expect @@ -50,4 +50,14 @@ <entry name='serial_number'>29057112</entry> <entry name='part_number'>IMSH2GS13A1F1C-10F</entry> </memory_device> + <oemStrings> + <entry>Default string</entry> + <entry>Default string</entry> + <entry>MIAMI</entry> + <entry>Default string</entry> + <entry>FFFFFFFFFFFFF</entry> + <entry>FFFFFFFFFFFFF</entry> + <entry>FFFFFFFFFFFFF</entry> + <entry>Default string</entry> + </oemStrings> </sysinfo> -- 2.26.2

2 4

[libvirt PATCH 0/3] Point to our gitlab.com repos more
by Ján Tomko 03 Jun '20

03 Jun '20

Ján Tomko (3): docs: csharp: remove outdated comment docs: virshcmdref: change repo URL to GitLab docs: point to GitLab as the primary git hosting ChangeLog | 4 ++-- docs/aclpolkit.html.in | 2 +- docs/bindings.html.in | 2 +- docs/csharp.html.in | 25 ++----------------------- docs/dbus.html.in | 12 ++---------- docs/hacking.rst | 4 ++-- docs/java.html.in | 12 ++---------- docs/php.html.in | 10 ++-------- docs/securityprocess.html.in | 2 +- docs/testapi.html.in | 2 +- docs/testsuites.html.in | 4 ++-- docs/testtck.html.in | 2 +- docs/virshcmdref.html.in | 16 ++-------------- 13 files changed, 21 insertions(+), 76 deletions(-) -- 2.25.4

2 5

[libvirt PATCH 0/2] lxc: remove most use of libvirt allocation APIs
by Daniel P. Berrangé 03 Jun '20

03 Jun '20

This removes VIR_ALLOC / VIR_FREE and friends, but not the VIR_*_ELEMENT API usage. Daniel P. Berrangé (2): lxc: replace VIR_FREE with g_autofree / g_free lxc: replace VIR_ALLOC/REALLOC with g_new0/renew src/lxc/lxc_cgroup.c | 15 +-- src/lxc/lxc_conf.c | 19 ++- src/lxc/lxc_container.c | 262 ++++++++++++++------------------------- src/lxc/lxc_controller.c | 148 ++++++++-------------- src/lxc/lxc_domain.c | 40 +++--- src/lxc/lxc_driver.c | 89 ++++++------- src/lxc/lxc_fuse.c | 14 +-- src/lxc/lxc_fuse.h | 1 + src/lxc/lxc_hostdev.c | 1 - src/lxc/lxc_monitor.c | 9 +- src/lxc/lxc_native.c | 81 ++++++------ src/lxc/lxc_process.c | 135 ++++++++------------ 12 files changed, 306 insertions(+), 508 deletions(-) -- 2.24.1

4 5

[PATCH] qemucapabilitiestest: Bump qemu-5.1 capabilities for x86_64
by Peter Krempa 03 Jun '20

03 Jun '20

QEMU added the machine types for the 5.1 release so let's update them. Other notable changes are 'cpu-throttle-tailslow' migration property, 'zlib' compression for qcow2 images and absrtact socket support. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- As usual, I'll be refreshing this until the release so that we always have fresh capabilities to prevent any surprises with deprecation and big updates. .../domaincapsdata/qemu_5.1.0-q35.x86_64.xml | 2 +- .../domaincapsdata/qemu_5.1.0-tcg.x86_64.xml | 2 +- tests/domaincapsdata/qemu_5.1.0.x86_64.xml | 2 +- .../caps_5.1.0.x86_64.replies | 357 +++++++++++------- .../caps_5.1.0.x86_64.xml | 14 +- 5 files changed, 237 insertions(+), 140 deletions(-) diff --git a/tests/domaincapsdata/qemu_5.1.0-q35.x86_64.xml b/tests/domaincapsdata/qemu_5.1.0-q35.x86_64.xml index e152f7dec5..996461fb0f 100644 --- a/tests/domaincapsdata/qemu_5.1.0-q35.x86_64.xml +++ b/tests/domaincapsdata/qemu_5.1.0-q35.x86_64.xml @@ -1,7 +1,7 @@ <domainCapabilities> <path>/usr/bin/qemu-system-x86_64</path> <domain>kvm</domain> - <machine>pc-q35-5.0</machine> + <machine>pc-q35-5.1</machine> <arch>x86_64</arch> <vcpu max='288'/> <iothreads supported='yes'/> diff --git a/tests/domaincapsdata/qemu_5.1.0-tcg.x86_64.xml b/tests/domaincapsdata/qemu_5.1.0-tcg.x86_64.xml index a0eeed7c2d..e4801b2750 100644 --- a/tests/domaincapsdata/qemu_5.1.0-tcg.x86_64.xml +++ b/tests/domaincapsdata/qemu_5.1.0-tcg.x86_64.xml @@ -1,7 +1,7 @@ <domainCapabilities> <path>/usr/bin/qemu-system-x86_64</path> <domain>qemu</domain> - <machine>pc-i440fx-5.0</machine> + <machine>pc-i440fx-5.1</machine> <arch>x86_64</arch> <vcpu max='255'/> <iothreads supported='yes'/> diff --git a/tests/domaincapsdata/qemu_5.1.0.x86_64.xml b/tests/domaincapsdata/qemu_5.1.0.x86_64.xml index bc842730a0..e95fcec8bc 100644 --- a/tests/domaincapsdata/qemu_5.1.0.x86_64.xml +++ b/tests/domaincapsdata/qemu_5.1.0.x86_64.xml @@ -1,7 +1,7 @@ <domainCapabilities> <path>/usr/bin/qemu-system-x86_64</path> <domain>kvm</domain> - <machine>pc-i440fx-5.0</machine> + <machine>pc-i440fx-5.1</machine> <arch>x86_64</arch> <vcpu max='255'/> <iothreads supported='yes'/> diff --git a/tests/qemucapabilitiesdata/caps_5.1.0.x86_64.replies b/tests/qemucapabilitiesdata/caps_5.1.0.x86_64.replies index e26a74921f..c44cff7e50 100644 --- a/tests/qemucapabilitiesdata/caps_5.1.0.x86_64.replies +++ b/tests/qemucapabilitiesdata/caps_5.1.0.x86_64.replies @@ -21,7 +21,7 @@ "minor": 0, "major": 5 }, - "package": "v5.0.0-34-g648db19685" + "package": "v5.0.0-870-g5cc7a54c2e" }, "id": "libvirt-2" } @@ -618,10 +618,6 @@ { "return": [ - { - "name": "ich9-usb-uhci5", - "parent": "pci-uhci-usb" - }, { "name": "pcie-pci-bridge", "parent": "base-pci-bridge" @@ -662,6 +658,10 @@ "name": "Denverton-x86_64-cpu", "parent": "x86_64-cpu" }, + { + "name": "virtio-rng-device", + "parent": "virtio-device" + }, { "name": "filter-buffer", "parent": "netfilter" @@ -671,8 +671,8 @@ "parent": "usb-device" }, { - "name": "pci-bridge", - "parent": "base-pci-bridge" + "name": "ich9-usb-uhci5", + "parent": "pci-uhci-usb" }, { "name": "pci-ipmi-bt", @@ -691,8 +691,8 @@ "parent": "pci-vga" }, { - "name": "virtio-rng-device", - "parent": "virtio-device" + "name": "pcm3680_pci", + "parent": "pci-device" }, { "name": "Haswell-v1-x86_64-cpu", @@ -703,8 +703,8 @@ "parent": "pci-device" }, { - "name": "core2duo-x86_64-cpu", - "parent": "x86_64-cpu" + "name": "pci-bridge", + "parent": "base-pci-bridge" }, { "name": "kvm-pit", @@ -723,8 +723,8 @@ "parent": "virtio-device" }, { - "name": "pcm3680_pci", - "parent": "pci-device" + "name": "core2duo-x86_64-cpu", + "parent": "x86_64-cpu" }, { "name": "virtio-blk-pci-transitional", @@ -1086,14 +1086,14 @@ "name": "pxb-pcie", "parent": "pci-device" }, - { - "name": "Haswell-IBRS-x86_64-cpu", - "parent": "x86_64-cpu" - }, { "name": "virtio-scsi-device", "parent": "virtio-scsi-common" }, + { + "name": "Haswell-IBRS-x86_64-cpu", + "parent": "x86_64-cpu" + }, { "name": "input-barrier", "parent": "object" @@ -1690,6 +1690,10 @@ "name": "Dhyana-v1-x86_64-cpu", "parent": "x86_64-cpu" }, + { + "name": "pc-i440fx-5.1-machine", + "parent": "generic-pc-machine" + }, { "name": "sysbus-fdc", "parent": "base-sysbus-fdc" @@ -1859,8 +1863,8 @@ "parent": "megasas-base" }, { - "name": "vmcoreinfo", - "parent": "device" + "name": "chardev-braille", + "parent": "chardev" }, { "name": "virtio-iommu-pci", @@ -1871,12 +1875,12 @@ "parent": "x86_64-cpu" }, { - "name": "tpci200", - "parent": "pci-device" + "name": "vmcoreinfo", + "parent": "device" }, { - "name": "chardev-braille", - "parent": "chardev" + "name": "tpci200", + "parent": "pci-device" }, { "name": "rocker", @@ -1914,6 +1918,10 @@ "name": "qemu-console", "parent": "object" }, + { + "name": "chardev-socket", + "parent": "chardev" + }, { "name": "input-linux", "parent": "object" @@ -1962,14 +1970,14 @@ "name": "cs4231a", "parent": "isa-device" }, - { - "name": "chardev-socket", - "parent": "chardev" - }, { "name": "scsi-hd", "parent": "scsi-disk-base" }, + { + "name": "clock", + "parent": "object" + }, { "name": "usb-kbd", "parent": "usb-hid" @@ -1998,6 +2006,10 @@ "name": "virtio-net-device", "parent": "virtio-device" }, + { + "name": "ccid-card-emulated", + "parent": "ccid-card" + }, { "name": "pc-q35-2.9-machine", "parent": "generic-pc-machine" @@ -2027,15 +2039,15 @@ "parent": "virtio-iommu-device-base" }, { - "name": "ccid-card-emulated", - "parent": "ccid-card" + "name": "pc-i440fx-1.7-machine", + "parent": "generic-pc-machine" }, { "name": "Westmere-v2-x86_64-cpu", "parent": "x86_64-cpu" }, { - "name": "pc-i440fx-1.7-machine", + "name": "pc-q35-5.1-machine", "parent": "generic-pc-machine" }, { @@ -2138,14 +2150,14 @@ "name": "pc-dimm", "parent": "device" }, - { - "name": "virtio-balloon-pci-non-transitional", - "parent": "virtio-balloon-pci-base" - }, { "name": "virtio-net-pci-transitional", "parent": "virtio-net-pci-base" }, + { + "name": "virtio-balloon-pci-non-transitional", + "parent": "virtio-balloon-pci-base" + }, { "name": "ipmi-bmc-sim", "parent": "ipmi-bmc" @@ -8013,6 +8025,15 @@ "cpu-max": 288, "deprecated": false }, + { + "hotpluggable-cpus": true, + "name": "pc-q35-5.1", + "numa-mem-supported": true, + "default-cpu-type": "qemu64-x86_64-cpu", + "cpu-max": 288, + "deprecated": false, + "alias": "q35" + }, { "hotpluggable-cpus": true, "name": "pc-i440fx-1.7", @@ -8077,6 +8098,16 @@ "cpu-max": 255, "deprecated": false }, + { + "hotpluggable-cpus": true, + "name": "pc-i440fx-5.1", + "numa-mem-supported": true, + "default-cpu-type": "qemu64-x86_64-cpu", + "is-default": true, + "cpu-max": 255, + "deprecated": false, + "alias": "pc" + }, { "hotpluggable-cpus": true, "name": "pc-i440fx-2.9", @@ -8171,8 +8202,7 @@ "numa-mem-supported": true, "default-cpu-type": "qemu64-x86_64-cpu", "cpu-max": 288, - "deprecated": false, - "alias": "q35" + "deprecated": false }, { "hotpluggable-cpus": true, @@ -8243,10 +8273,8 @@ "name": "pc-i440fx-5.0", "numa-mem-supported": true, "default-cpu-type": "qemu64-x86_64-cpu", - "is-default": true, "cpu-max": 255, - "deprecated": false, - "alias": "pc" + "deprecated": false }, { "hotpluggable-cpus": true, @@ -10852,6 +10880,15 @@ }, { "parameters": [ + { + "name": "abstract", + "type": "boolean" + }, + { + "name": "tight", + "default": "on", + "type": "boolean" + }, { "name": "logappend", "type": "boolean" @@ -16185,6 +16222,11 @@ "default": null, "type": "int" }, + { + "name": "cpu-throttle-tailslow", + "default": null, + "type": "bool" + }, { "name": "tls-creds", "default": null, @@ -16316,6 +16358,11 @@ "default": null, "type": "int" }, + { + "name": "cpu-throttle-tailslow", + "default": null, + "type": "bool" + }, { "name": "tls-creds", "default": null, @@ -21208,6 +21255,10 @@ "name": "cache-miss-rate", "type": "number" }, + { + "name": "encoding-rate", + "type": "number" + }, { "name": "overflow", "type": "int" @@ -22789,6 +22840,11 @@ "name": "refcount-bits", "default": null, "type": "int" + }, + { + "name": "compression-type", + "default": null, + "type": "499" } ], "meta-type": "object" @@ -22870,7 +22926,7 @@ { "name": "redundancy", "default": null, - "type": "499" + "type": "500" }, { "name": "object-size", @@ -22937,7 +22993,7 @@ { "name": "subformat", "default": null, - "type": "500" + "type": "501" }, { "name": "block-state-zero", @@ -22966,7 +23022,7 @@ { "name": "subformat", "default": null, - "type": "501" + "type": "502" }, { "name": "backing-file", @@ -22976,7 +23032,7 @@ { "name": "adapter-type", "default": null, - "type": "502" + "type": "503" }, { "name": "hwversion", @@ -23005,7 +23061,7 @@ { "name": "subformat", "default": null, - "type": "503" + "type": "504" }, { "name": "force-size", @@ -23101,7 +23157,7 @@ "members": [ { "name": "data", - "type": "504" + "type": "505" } ], "meta-type": "object" @@ -23111,7 +23167,7 @@ "members": [ { "name": "data", - "type": "505" + "type": "506" } ], "meta-type": "object" @@ -23121,7 +23177,7 @@ "members": [ { "name": "data", - "type": "506" + "type": "507" } ], "meta-type": "object" @@ -23131,7 +23187,7 @@ "members": [ { "name": "data", - "type": "507" + "type": "508" } ], "meta-type": "object" @@ -23141,7 +23197,7 @@ "members": [ { "name": "data", - "type": "508" + "type": "509" } ], "meta-type": "object" @@ -23151,7 +23207,7 @@ "members": [ { "name": "data", - "type": "509" + "type": "510" } ], "meta-type": "object" @@ -23161,7 +23217,7 @@ "members": [ { "name": "data", - "type": "510" + "type": "511" } ], "meta-type": "object" @@ -23171,7 +23227,7 @@ "members": [ { "name": "data", - "type": "511" + "type": "512" } ], "meta-type": "object" @@ -23181,7 +23237,7 @@ "members": [ { "name": "data", - "type": "512" + "type": "513" } ], "meta-type": "object" @@ -23191,7 +23247,7 @@ "members": [ { "name": "data", - "type": "513" + "type": "514" } ], "meta-type": "object" @@ -23201,7 +23257,7 @@ "members": [ { "name": "data", - "type": "514" + "type": "515" } ], "meta-type": "object" @@ -23234,7 +23290,7 @@ "members": [ { "name": "data", - "type": "515" + "type": "516" } ], "meta-type": "object" @@ -23244,7 +23300,7 @@ "members": [ { "name": "data", - "type": "516" + "type": "517" } ], "meta-type": "object" @@ -23272,7 +23328,7 @@ "members": [ { "name": "data", - "type": "517" + "type": "518" } ], "meta-type": "object" @@ -23292,7 +23348,7 @@ "members": [ { "name": "data", - "type": "518" + "type": "519" } ], "meta-type": "object" @@ -23302,7 +23358,7 @@ "members": [ { "name": "data", - "type": "519" + "type": "520" } ], "meta-type": "object" @@ -23312,7 +23368,7 @@ "members": [ { "name": "data", - "type": "520" + "type": "521" } ], "meta-type": "object" @@ -23333,6 +23389,16 @@ { "name": "path", "type": "str" + }, + { + "name": "tight", + "default": null, + "type": "bool" + }, + { + "name": "abstract", + "default": null, + "type": "bool" } ], "meta-type": "object" @@ -23374,7 +23440,7 @@ "members": [ { "name": "data", - "type": "521" + "type": "522" } ], "meta-type": "object" @@ -23639,7 +23705,7 @@ "members": [ { "name": "bus", - "type": "522" + "type": "523" }, { "name": "devices", @@ -23783,7 +23849,7 @@ "members": [ { "name": "data", - "type": "523" + "type": "524" } ], "meta-type": "object" @@ -23793,7 +23859,7 @@ "members": [ { "name": "data", - "type": "524" + "type": "525" } ], "meta-type": "object" @@ -23803,7 +23869,7 @@ "members": [ { "name": "data", - "type": "525" + "type": "526" } ], "meta-type": "object" @@ -23998,7 +24064,7 @@ "members": [ { "name": "type", - "type": "526" + "type": "527" }, { "name": "hash", @@ -24077,13 +24143,13 @@ }, { "case": "luks", - "type": "528" + "type": "529" } ], "members": [ { "name": "format", - "type": "527" + "type": "528" } ], "meta-type": "object" @@ -24098,27 +24164,34 @@ }, { "name": "499", + "meta-type": "enum", + "values": [ + "zlib" + ] + }, + { + "name": "500", "tag": "type", "variants": [ { "case": "full", - "type": "530" + "type": "531" }, { "case": "erasure-coded", - "type": "531" + "type": "532" } ], "members": [ { "name": "type", - "type": "529" + "type": "530" } ], "meta-type": "object" }, { - "name": "500", + "name": "501", "meta-type": "enum", "values": [ "dynamic", @@ -24126,7 +24199,7 @@ ] }, { - "name": "501", + "name": "502", "meta-type": "enum", "values": [ "monolithicSparse", @@ -24137,7 +24210,7 @@ ] }, { - "name": "502", + "name": "503", "meta-type": "enum", "values": [ "ide", @@ -24147,7 +24220,7 @@ ] }, { - "name": "503", + "name": "504", "meta-type": "enum", "values": [ "dynamic", @@ -24155,7 +24228,7 @@ ] }, { - "name": "504", + "name": "505", "members": [ { "name": "logfile", @@ -24185,7 +24258,7 @@ "meta-type": "object" }, { - "name": "505", + "name": "506", "members": [ { "name": "logfile", @@ -24205,7 +24278,7 @@ "meta-type": "object" }, { - "name": "506", + "name": "507", "members": [ { "name": "logfile", @@ -24270,7 +24343,7 @@ "meta-type": "object" }, { - "name": "507", + "name": "508", "members": [ { "name": "logfile", @@ -24295,7 +24368,7 @@ "meta-type": "object" }, { - "name": "508", + "name": "509", "members": [ { "name": "logfile", @@ -24311,7 +24384,7 @@ "meta-type": "object" }, { - "name": "509", + "name": "510", "members": [ { "name": "logfile", @@ -24331,7 +24404,7 @@ "meta-type": "object" }, { - "name": "510", + "name": "511", "members": [ { "name": "logfile", @@ -24352,7 +24425,7 @@ "meta-type": "object" }, { - "name": "511", + "name": "512", "members": [ { "name": "logfile", @@ -24372,7 +24445,7 @@ "meta-type": "object" }, { - "name": "512", + "name": "513", "members": [ { "name": "logfile", @@ -24392,7 +24465,7 @@ "meta-type": "object" }, { - "name": "513", + "name": "514", "members": [ { "name": "logfile", @@ -24428,7 +24501,7 @@ "meta-type": "object" }, { - "name": "514", + "name": "515", "members": [ { "name": "logfile", @@ -24449,7 +24522,7 @@ "meta-type": "object" }, { - "name": "515", + "name": "516", "members": [ { "name": "path", @@ -24465,7 +24538,7 @@ "meta-type": "object" }, { - "name": "516", + "name": "517", "members": [ { "name": "chardev", @@ -24475,7 +24548,7 @@ "meta-type": "object" }, { - "name": "517", + "name": "518", "meta-type": "enum", "values": [ "unmapped", @@ -24629,7 +24702,7 @@ ] }, { - "name": "518", + "name": "519", "members": [ { "name": "key", @@ -24643,11 +24716,11 @@ "meta-type": "object" }, { - "name": "519", + "name": "520", "members": [ { "name": "button", - "type": "532" + "type": "533" }, { "name": "down", @@ -24657,11 +24730,11 @@ "meta-type": "object" }, { - "name": "520", + "name": "521", "members": [ { "name": "axis", - "type": "533" + "type": "534" }, { "name": "value", @@ -24671,13 +24744,13 @@ "meta-type": "object" }, { - "name": "521", + "name": "522", "members": [ ], "meta-type": "object" }, { - "name": "522", + "name": "523", "members": [ { "name": "number", @@ -24693,21 +24766,21 @@ }, { "name": "io_range", - "type": "534" + "type": "535" }, { "name": "memory_range", - "type": "534" + "type": "535" }, { "name": "prefetchable_range", - "type": "534" + "type": "535" } ], "meta-type": "object" }, { - "name": "523", + "name": "524", "members": [ { "name": "compat", @@ -24740,18 +24813,22 @@ { "name": "encrypt", "default": null, - "type": "535" + "type": "536" }, { "name": "bitmaps", "default": null, - "type": "[536]" + "type": "[537]" + }, + { + "name": "compression-type", + "type": "499" } ], "meta-type": "object" }, { - "name": "524", + "name": "525", "members": [ { "name": "create-type", @@ -24773,7 +24850,7 @@ "meta-type": "object" }, { - "name": "525", + "name": "526", "members": [ { "name": "cipher-alg", @@ -24810,13 +24887,13 @@ }, { "name": "slots", - "type": "[537]" + "type": "[538]" } ], "meta-type": "object" }, { - "name": "526", + "name": "527", "meta-type": "enum", "values": [ "md5", @@ -24824,7 +24901,7 @@ ] }, { - "name": "527", + "name": "528", "meta-type": "enum", "values": [ "qcow", @@ -24832,7 +24909,7 @@ ] }, { - "name": "528", + "name": "529", "members": [ { "name": "key-secret", @@ -24873,7 +24950,7 @@ "meta-type": "object" }, { - "name": "529", + "name": "530", "meta-type": "enum", "values": [ "full", @@ -24881,7 +24958,7 @@ ] }, { - "name": "530", + "name": "531", "members": [ { "name": "copies", @@ -24891,7 +24968,7 @@ "meta-type": "object" }, { - "name": "531", + "name": "532", "members": [ { "name": "data-strips", @@ -24905,7 +24982,7 @@ "meta-type": "object" }, { - "name": "532", + "name": "533", "meta-type": "enum", "values": [ "left", @@ -24918,7 +24995,7 @@ ] }, { - "name": "533", + "name": "534", "meta-type": "enum", "values": [ "x", @@ -24926,7 +25003,7 @@ ] }, { - "name": "534", + "name": "535", "members": [ { "name": "base", @@ -24940,12 +25017,12 @@ "meta-type": "object" }, { - "name": "535", + "name": "536", "tag": "format", "variants": [ { "case": "luks", - "type": "525" + "type": "526" }, { "case": "aes", @@ -24961,12 +25038,12 @@ "meta-type": "object" }, { - "name": "[536]", - "element-type": "536", + "name": "[537]", + "element-type": "537", "meta-type": "array" }, { - "name": "536", + "name": "537", "members": [ { "name": "name", @@ -24978,7 +25055,7 @@ }, { "name": "flags", - "type": "[538]" + "type": "[539]" } ], "meta-type": "object" @@ -24989,12 +25066,12 @@ "meta-type": "array" }, { - "name": "[537]", - "element-type": "537", + "name": "[538]", + "element-type": "538", "meta-type": "array" }, { - "name": "537", + "name": "538", "members": [ { "name": "active", @@ -25018,12 +25095,12 @@ "meta-type": "object" }, { - "name": "[538]", - "element-type": "538", + "name": "[539]", + "element-type": "539", "meta-type": "array" }, { - "name": "538", + "name": "539", "meta-type": "enum", "values": [ "in-use", @@ -28558,6 +28635,15 @@ "cpu-max": 288, "deprecated": false }, + { + "hotpluggable-cpus": true, + "name": "pc-q35-5.1", + "numa-mem-supported": true, + "default-cpu-type": "qemu64-x86_64-cpu", + "cpu-max": 288, + "deprecated": false, + "alias": "q35" + }, { "hotpluggable-cpus": true, "name": "pc-i440fx-1.7", @@ -28622,6 +28708,16 @@ "cpu-max": 255, "deprecated": false }, + { + "hotpluggable-cpus": true, + "name": "pc-i440fx-5.1", + "numa-mem-supported": true, + "default-cpu-type": "qemu64-x86_64-cpu", + "is-default": true, + "cpu-max": 255, + "deprecated": false, + "alias": "pc" + }, { "hotpluggable-cpus": true, "name": "pc-i440fx-2.9", @@ -28716,8 +28812,7 @@ "numa-mem-supported": true, "default-cpu-type": "qemu64-x86_64-cpu", "cpu-max": 288, - "deprecated": false, - "alias": "q35" + "deprecated": false }, { "hotpluggable-cpus": true, @@ -28788,10 +28883,8 @@ "name": "pc-i440fx-5.0", "numa-mem-supported": true, "default-cpu-type": "qemu64-x86_64-cpu", - "is-default": true, "cpu-max": 255, - "deprecated": false, - "alias": "pc" + "deprecated": false }, { "hotpluggable-cpus": true, diff --git a/tests/qemucapabilitiesdata/caps_5.1.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_5.1.0.x86_64.xml index c2bc121f73..3f538628b3 100644 --- a/tests/qemucapabilitiesdata/caps_5.1.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_5.1.0.x86_64.xml @@ -237,7 +237,7 @@ <version>5000050</version> <kvmVersion>0</kvmVersion> <microcodeVersion>43100242</microcodeVersion> - <package>v5.0.0-34-g648db19685</package> + <package>v5.0.0-870-g5cc7a54c2e</package> <arch>x86_64</arch> <hostCPU type='kvm' model='base' migratability='yes'> <property name='vmx-entry-load-rtit-ctl' type='boolean' value='false'/> @@ -1328,7 +1328,7 @@ </cpu> <cpu type='kvm' name='486-v1' typename='486-v1-x86_64-cpu' usable='yes'/> <cpu type='kvm' name='486' typename='486-x86_64-cpu' usable='yes'/> - <machine type='kvm' name='pc-i440fx-5.0' alias='pc' hotplugCpus='yes' maxCpus='255' default='yes' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> + <machine type='kvm' name='pc-i440fx-5.1' alias='pc' hotplugCpus='yes' maxCpus='255' default='yes' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='kvm' name='pc-i440fx-2.12' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='kvm' name='pc-i440fx-2.0' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='kvm' name='pc-q35-4.2' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> @@ -1341,6 +1341,7 @@ <machine type='kvm' name='pc-i440fx-2.7' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='kvm' name='pc-q35-2.4' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='kvm' name='pc-q35-2.10' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> + <machine type='kvm' name='pc-q35-5.1' alias='q35' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='kvm' name='pc-i440fx-1.7' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='kvm' name='pc-q35-2.9' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='kvm' name='pc-i440fx-2.11' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> @@ -1360,7 +1361,7 @@ <machine type='kvm' name='pc-i440fx-2.6' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='kvm' name='pc-q35-4.0.1' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='kvm' name='pc-i440fx-1.6' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> - <machine type='kvm' name='pc-q35-5.0' alias='q35' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> + <machine type='kvm' name='pc-q35-5.0' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='kvm' name='pc-q35-2.8' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='kvm' name='pc-i440fx-2.10' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='kvm' name='pc-q35-3.0' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> @@ -1369,6 +1370,7 @@ <machine type='kvm' name='pc-i440fx-2.3' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='kvm' name='pc-1.2' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='kvm' name='pc-i440fx-4.0' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> + <machine type='kvm' name='pc-i440fx-5.0' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='kvm' name='pc-i440fx-2.8' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='kvm' name='pc-q35-2.5' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='kvm' name='pc-i440fx-3.0' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> @@ -2970,7 +2972,7 @@ </cpu> <cpu type='tcg' name='486-v1' typename='486-v1-x86_64-cpu' usable='yes'/> <cpu type='tcg' name='486' typename='486-x86_64-cpu' usable='yes'/> - <machine type='tcg' name='pc-i440fx-5.0' alias='pc' hotplugCpus='yes' maxCpus='255' default='yes' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> + <machine type='tcg' name='pc-i440fx-5.1' alias='pc' hotplugCpus='yes' maxCpus='255' default='yes' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='tcg' name='pc-i440fx-2.12' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='tcg' name='pc-i440fx-2.0' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='tcg' name='pc-q35-4.2' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> @@ -2983,6 +2985,7 @@ <machine type='tcg' name='pc-i440fx-2.7' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='tcg' name='pc-q35-2.4' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='tcg' name='pc-q35-2.10' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> + <machine type='tcg' name='pc-q35-5.1' alias='q35' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='tcg' name='pc-i440fx-1.7' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='tcg' name='pc-q35-2.9' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='tcg' name='pc-i440fx-2.11' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> @@ -3002,7 +3005,7 @@ <machine type='tcg' name='pc-i440fx-2.6' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='tcg' name='pc-q35-4.0.1' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='tcg' name='pc-i440fx-1.6' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> - <machine type='tcg' name='pc-q35-5.0' alias='q35' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> + <machine type='tcg' name='pc-q35-5.0' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='tcg' name='pc-q35-2.8' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='tcg' name='pc-i440fx-2.10' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='tcg' name='pc-q35-3.0' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> @@ -3011,6 +3014,7 @@ <machine type='tcg' name='pc-i440fx-2.3' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='tcg' name='pc-1.2' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='tcg' name='pc-i440fx-4.0' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> + <machine type='tcg' name='pc-i440fx-5.0' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='tcg' name='pc-i440fx-2.8' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='tcg' name='pc-q35-2.5' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> <machine type='tcg' name='pc-i440fx-3.0' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes'/> -- 2.26.2

3 9

[libvirt PATCH 0/5] ci: Use GitLab container registry
by Andrea Bolognani 02 Jun '20

02 Jun '20

Branch: https://gitlab.com/abologna/libvirt/-/tree/ci-full-gitlab-registry Pipeline: https://gitlab.com/abologna/libvirt/pipelines/150891361 This is what we're already doing with the subprojects we've migrated to GitLab CI and, as of earlier today, all projects under the libosinfo umbrella. Once this is merged, we can stop publishing container images on Quay and archive the libvirt-dockerfiles repository. Patch 3/5 has been trimmed in order to comply with the size limits of the mailing list. You can grab the unabridged version with $ git fetch https://gitlab.com/abologna/libvirt ci-full-gitlab-registry Andrea Bolognani (5): ci: Use variables to build image names ci: Add 'other' stage ci: Use GitLab container registry ci: Update build system integration ci: Improve CI_IMAGE_TAG handling .gitlab-ci.yml | 314 ++++++++++++++++-- ci/Makefile | 23 +- ci/containers/README.rst | 14 + ci/containers/ci-centos-7.Dockerfile | 137 ++++++++ ci/containers/ci-centos-8.Dockerfile | 108 ++++++ .../ci-debian-10-cross-aarch64.Dockerfile | 122 +++++++ .../ci-debian-10-cross-armv6l.Dockerfile | 120 +++++++ .../ci-debian-10-cross-armv7l.Dockerfile | 121 +++++++ .../ci-debian-10-cross-i686.Dockerfile | 121 +++++++ .../ci-debian-10-cross-mips.Dockerfile | 121 +++++++ .../ci-debian-10-cross-mips64el.Dockerfile | 121 +++++++ .../ci-debian-10-cross-mipsel.Dockerfile | 121 +++++++ .../ci-debian-10-cross-ppc64le.Dockerfile | 121 +++++++ .../ci-debian-10-cross-s390x.Dockerfile | 121 +++++++ ci/containers/ci-debian-10.Dockerfile | 112 +++++++ .../ci-debian-9-cross-aarch64.Dockerfile | 126 +++++++ .../ci-debian-9-cross-armv6l.Dockerfile | 124 +++++++ .../ci-debian-9-cross-armv7l.Dockerfile | 125 +++++++ .../ci-debian-9-cross-mips.Dockerfile | 125 +++++++ .../ci-debian-9-cross-mips64el.Dockerfile | 125 +++++++ .../ci-debian-9-cross-mipsel.Dockerfile | 125 +++++++ .../ci-debian-9-cross-ppc64le.Dockerfile | 125 +++++++ .../ci-debian-9-cross-s390x.Dockerfile | 125 +++++++ ci/containers/ci-debian-9.Dockerfile | 116 +++++++ .../ci-debian-sid-cross-aarch64.Dockerfile | 122 +++++++ .../ci-debian-sid-cross-armv6l.Dockerfile | 120 +++++++ .../ci-debian-sid-cross-armv7l.Dockerfile | 121 +++++++ .../ci-debian-sid-cross-i686.Dockerfile | 121 +++++++ .../ci-debian-sid-cross-mips.Dockerfile | 121 +++++++ .../ci-debian-sid-cross-mips64el.Dockerfile | 121 +++++++ .../ci-debian-sid-cross-mipsel.Dockerfile | 120 +++++++ .../ci-debian-sid-cross-ppc64le.Dockerfile | 121 +++++++ .../ci-debian-sid-cross-s390x.Dockerfile | 121 +++++++ ci/containers/ci-debian-sid.Dockerfile | 112 +++++++ ci/containers/ci-fedora-31.Dockerfile | 109 ++++++ ci/containers/ci-fedora-32.Dockerfile | 109 ++++++ ...ci-fedora-rawhide-cross-mingw32.Dockerfile | 129 +++++++ ...ci-fedora-rawhide-cross-mingw64.Dockerfile | 129 +++++++ ci/containers/ci-fedora-rawhide.Dockerfile | 110 ++++++ ci/containers/ci-opensuse-151.Dockerfile | 109 ++++++ ci/containers/ci-ubuntu-1804.Dockerfile | 117 +++++++ ci/containers/ci-ubuntu-2004.Dockerfile | 113 +++++++ ci/containers/refresh | 43 +++ ci/list-images.sh | 24 +- 44 files changed, 5054 insertions(+), 51 deletions(-) create mode 100644 ci/containers/README.rst create mode 100644 ci/containers/ci-centos-7.Dockerfile create mode 100644 ci/containers/ci-centos-8.Dockerfile create mode 100644 ci/containers/ci-debian-10-cross-aarch64.Dockerfile create mode 100644 ci/containers/ci-debian-10-cross-armv6l.Dockerfile create mode 100644 ci/containers/ci-debian-10-cross-armv7l.Dockerfile create mode 100644 ci/containers/ci-debian-10-cross-i686.Dockerfile create mode 100644 ci/containers/ci-debian-10-cross-mips.Dockerfile create mode 100644 ci/containers/ci-debian-10-cross-mips64el.Dockerfile create mode 100644 ci/containers/ci-debian-10-cross-mipsel.Dockerfile create mode 100644 ci/containers/ci-debian-10-cross-ppc64le.Dockerfile create mode 100644 ci/containers/ci-debian-10-cross-s390x.Dockerfile create mode 100644 ci/containers/ci-debian-10.Dockerfile create mode 100644 ci/containers/ci-debian-9-cross-aarch64.Dockerfile create mode 100644 ci/containers/ci-debian-9-cross-armv6l.Dockerfile create mode 100644 ci/containers/ci-debian-9-cross-armv7l.Dockerfile create mode 100644 ci/containers/ci-debian-9-cross-mips.Dockerfile create mode 100644 ci/containers/ci-debian-9-cross-mips64el.Dockerfile create mode 100644 ci/containers/ci-debian-9-cross-mipsel.Dockerfile create mode 100644 ci/containers/ci-debian-9-cross-ppc64le.Dockerfile create mode 100644 ci/containers/ci-debian-9-cross-s390x.Dockerfile create mode 100644 ci/containers/ci-debian-9.Dockerfile create mode 100644 ci/containers/ci-debian-sid-cross-aarch64.Dockerfile create mode 100644 ci/containers/ci-debian-sid-cross-armv6l.Dockerfile create mode 100644 ci/containers/ci-debian-sid-cross-armv7l.Dockerfile create mode 100644 ci/containers/ci-debian-sid-cross-i686.Dockerfile create mode 100644 ci/containers/ci-debian-sid-cross-mips.Dockerfile create mode 100644 ci/containers/ci-debian-sid-cross-mips64el.Dockerfile create mode 100644 ci/containers/ci-debian-sid-cross-mipsel.Dockerfile create mode 100644 ci/containers/ci-debian-sid-cross-ppc64le.Dockerfile create mode 100644 ci/containers/ci-debian-sid-cross-s390x.Dockerfile create mode 100644 ci/containers/ci-debian-sid.Dockerfile create mode 100644 ci/containers/ci-fedora-31.Dockerfile create mode 100644 ci/containers/ci-fedora-32.Dockerfile create mode 100644 ci/containers/ci-fedora-rawhide-cross-mingw32.Dockerfile create mode 100644 ci/containers/ci-fedora-rawhide-cross-mingw64.Dockerfile create mode 100644 ci/containers/ci-fedora-rawhide.Dockerfile create mode 100644 ci/containers/ci-opensuse-151.Dockerfile create mode 100644 ci/containers/ci-ubuntu-1804.Dockerfile create mode 100644 ci/containers/ci-ubuntu-2004.Dockerfile create mode 100755 ci/containers/refresh -- 2.25.4

3 24

libvirt 6.4.0 is available
by Daniel Veillard 02 Jun '20

02 Jun '20

I made the release earlier, it is tagged in git and signed source tarball and rpm are available at the usual place: https://libvirt.org/sources/ I didn't push an RC2 this week end as there was no code change from RC1 only a bug fix made its way yesterday. I also pushed a python binding 6.4.0 release that can be found at: https://libvirt.org/sources/python/ There isn't that much detail about the release in the news file, obviously a decent amount of bug fixes and improvements though: Improvements: - qemu: stricter validation for disk type='lun' The 'lun' type is meant for SCSI command passthrough, which can't be achieved if qemu's block layer features are used. Disk type='lun' is now allowed only when the format is 'raw' and no other block layer features are requested. Bug fixes: - qemu: fixed regression in network device hotplug with new qemu versions Starting from QEMU-5.0 it's required to conform to strict schema when hotplugging network devices. Libvirt didn't conform to the schema so in versions prior to 6.4.0 network device hotplug fails in certain cases. This version fixes it and adds stricter testing to prevent further issues. Thanks everybody for your help with this release, enjoy and stay safe ! Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

2 1

[PATCH 0/3] Rmove support of tftp storage protocol
by Han Han 02 Jun '20

02 Jun '20

Let's drop tftp support since it is ususabled before or after QEMU v2.8 [1]. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1372143 Han Han (3): docs: Remove tftp protocol support from docs src: Remove tftp network storage support news: Remove support for tftp storage protocol docs/formatdomain.html.in | 10 +--------- docs/news.xml | 11 +++++++++++ docs/schemas/domaincommon.rng | 1 - src/libxl/libxl_conf.c | 1 - src/libxl/xen_xl.c | 1 - src/qemu/qemu_block.c | 3 --- src/qemu/qemu_command.c | 1 - src/qemu/qemu_domain.c | 11 ----------- src/qemu/qemu_driver.c | 3 --- src/util/virstoragefile.c | 6 ------ src/util/virstoragefile.h | 1 - 11 files changed, 12 insertions(+), 37 deletions(-) -- 2.25.0

4 9

[libvirt PATCH] maint: Post-release version bump to 6.5.0
by Andrea Bolognani 02 Jun '20

02 Jun '20

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. configure.ac | 2 +- docs/news.xml | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 73dc9f841c..6c8ac2f04b 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@ dnl You should have received a copy of the GNU Lesser General Public dnl License along with this library. If not, see dnl <http://www.gnu.org/licenses/>. -AC_INIT([libvirt], [6.4.0], [libvir-list(a)redhat.com] [], [https://libvirt.org] +AC_INIT([libvirt], [6.5.0], [libvir-list(a)redhat.com] [], [https://libvirt.org] if test $srcdir = "." then diff --git a/docs/news.xml b/docs/news.xml index f040d18f96..18d96af048 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -42,6 +42,14 @@ --> <libvirt> + <release version="v6.5.0" date="unreleased"> + <section title="New features"> + </section> + <section title="Improvements"> + </section> + <section title="Bug fixes"> + </section> + </release> <release version="v6.4.0" date="2020-06-02"> <section title="New features"> <change> -- 2.25.4

1 0

[libvirt PATCH] news: Update for libvirt 6.4.0
by Andrea Bolognani 02 Jun '20

02 Jun '20

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- docs/news.xml | 45 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 104babbae7..956af3036b 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -44,6 +44,24 @@ <libvirt> <release version="v6.4.0" date="unreleased"> <section title="New features"> + <change> + <summary> + qemu: Add support for pvscsi controllers + </summary> + <description> + pvscsi is the VMware paravirtualized SCSI controller, which has been + supported in QEMU for a number of years. + </description> + </change> + <change> + <summary> + cpu: Report model information for ARM CPUs + </summary> + <description> + <code>virsh capabilities</code> will now include information about + the host CPU when run on ARM machines. + </description> + </change> </section> <section title="Improvements"> <change> @@ -71,6 +89,33 @@ further issues. </description> </change> + <change> + <summary> + remote: Look up libxl driver correctly + </summary> + <description> + This makes <code>xen://</code> connection URIs usable in split daemon + mode. + </description> + </change> + <change> + <summary> + systemd: Start libvirtd after firewalld/iptables services + </summary> + <description> + This solves an issue where iptables rules and chains created by + libvirtd would get removed by a service started after it. + </description> + </change> + <change> + <summary> + network: Re-create iptables chains on firewalld restart + </summary> + <description> + firewalld resets all iptables rules and chains on restart, and this + includes deleting those created by libvirt. + </description> + </change> </section> </release> <release version="v6.3.0" date="2020-05-05"> -- 2.25.4

2 1

[PATCH] qemu: hotplug: Fix the condition check for net->downscript
by Yi Wang 01 Jun '20

01 Jun '20

From: Liao Pingfang <liao.pingfang(a)zte.com.cn> According to the context, here we are checking net->downscript's validity, Signed-off-by: Liao Pingfang <liao.pingfang(a)zte.com.cn> --- src/qemu/qemu_hotplug.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index d1a2be1..8c99dfc 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -4672,9 +4672,8 @@ qemuDomainRemoveNetDevice(virQEMUDriverPtr driver, virDomainNetReleaseActualDevice(conn, vm->def, net); else VIR_WARN("Unable to release network device '%s'", NULLSTR(net->ifname)); - } else if (net->type == VIR_DOMAIN_NET_TYPE_ETHERNET) { - if (net->script) - virNetDevRunEthernetScript(net->ifname, net->downscript); + } else if (net->type == VIR_DOMAIN_NET_TYPE_ETHERNET && net->downscript) { + virNetDevRunEthernetScript(net->ifname, net->downscript); } virDomainNetDefFree(net); return 0; -- 2.9.5

2 2

[libvirt PATCH] docs: use multiple header levels in virtiofs doc
by Daniel P. Berrangé 01 Jun '20

01 Jun '20

The heading overline should only be used for the overall document title, any subsequent headings should be underline only. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/kbase/virtiofs.rst | 4 ---- 1 file changed, 4 deletions(-) diff --git a/docs/kbase/virtiofs.rst b/docs/kbase/virtiofs.rst index 18d568af1b..dea8e79f83 100644 --- a/docs/kbase/virtiofs.rst +++ b/docs/kbase/virtiofs.rst @@ -4,7 +4,6 @@ Sharing files with Virtio-FS .. contents:: -========= Virtio-FS ========= @@ -14,7 +13,6 @@ is designed to offer local file system semantics and performance. See https://virtio-fs.gitlab.io/ -========== Host setup ========== @@ -45,7 +43,6 @@ Either of the following: # virsh allocpages 2M 1024 -=========== Guest setup =========== @@ -132,7 +129,6 @@ Guest setup Note: this requires virtiofs support in the guest kernel (Linux v5.4 or later) -=================== Optional parameters =================== -- 2.26.2

2 1

[libvirt PATCH] docs: Fixed incorrect XML attribute name in virtio kbase
by Ján Tomko 01 Jun '20

01 Jun '20

From: Jaak Ristioja <jaak(a)ristioja.ee> Signed-off-by: Jaak Ristioja <jaak(a)ristioja.ee> --- Pushed by danpb under the trivial rule from https://gitlab.com/libvirt/libvirt/-/merge_requests/2 docs/kbase/virtiofs.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/kbase/virtiofs.rst b/docs/kbase/virtiofs.rst index 68fbafcf37..18d568af1b 100644 --- a/docs/kbase/virtiofs.rst +++ b/docs/kbase/virtiofs.rst @@ -143,5 +143,5 @@ More optional elements can be specified <driver type='virtiofs' queue='1024'/> <binary path='/usr/libexec/virtiofsd' xattr='on'> <cache mode='always'/> - <lock posix_lock='on' flock='on'/> + <lock posix='on' flock='on'/> </binary> -- 2.25.4

1 0

[PATCH 0/6] Add Security Guest doc and check for capabilities cache validation
by Boris Fiuczynski 28 May '20

28 May '20

This series introduces the concept of a 'Secure Guest' feature which covers on s390 IBM Secure Execution and on x86 AMD Secure Encrypted Virtualization. Besides adding documentation for IBM Secure Execution it also adds checks during validation of the qemu capabilities cache. These checks per architecture can be performed for IBM Secure Execution on s390 and AMD Secure Encrypted Virtualization on AMD x86 CPUs (both checks implemented in this series). For s390 the verification consists of: - checking if /sys/firmware/uv is available: meaning the HW facility is available and the host OS supports it; - checking if the kernel cmdline contains 'prot_virt=1': meaning the host OS wants to use the feature. For AMD Secure Encrypted Virtualization the verification consists of: - checking if /sys/module/kvm_amd/parameters/sev contains the value '1': meaning SEV is enabled in the host kernel; - checking if the kernel cmdline contains 'mem_encrypt=on': meaning SME memory encryption feature on the host is enabled Whenever the availability of the feature does not match the secure guest flag in the cache then libvirt will re-build it in order to pick up the new set of capabilities available. Additionally, this series adds the same aforementioned checks to the virt-host-validate tool to facilitate the manual verification process for users. Boris Fiuczynski (2): tools: secure guest check on s390 in virt-host-validate tools: secure guest check for AMD in virt-host-validate Paulo de Rezende Pinatti (3): util: introduce a parser for kernel cmdline arguments qemu: check if s390 secure guest support is enabled qemu: check if AMD secure guest support is enabled Viktor Mihajlovski (1): docs: Describe protected virtualization guest setup docs/kbase.html.in | 3 + docs/kbase/launch_security_sev.rst | 9 +- docs/kbase/s390_protected_virt.rst | 189 +++++++++++++++++++++++++++++ src/libvirt_private.syms | 2 + src/qemu/qemu_capabilities.c | 83 +++++++++++++ src/util/virutil.c | 173 ++++++++++++++++++++++++++ src/util/virutil.h | 18 +++ tests/utiltest.c | 130 ++++++++++++++++++++ tools/virt-host-validate-common.c | 90 +++++++++++++- tools/virt-host-validate-common.h | 5 + tools/virt-host-validate-qemu.c | 4 + 11 files changed, 701 insertions(+), 5 deletions(-) create mode 100644 docs/kbase/s390_protected_virt.rst -- 2.25.1

4 28

[PATCH v2] qemu: Skip pre-creation of NVMe disks
by Michal Privoznik 28 May '20

28 May '20

Upon migration with disks, libvirt determines if each disk exists on the destination and tries to pre-create missing ones. Well, NVMe disks can't be pre-created, but they can be checked for presence. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1823639 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Technically, this is a v2 of: https://www.redhat.com/archives/libvir-list/2020-May/msg00253.html but I've taken what I'm suggesting in a BZ comment and posting it as a patch. src/qemu/qemu_migration.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 02e8271e42..7ee5b5eda8 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -315,6 +315,7 @@ qemuMigrationDstPrecreateStorage(virDomainObjPtr vm, for (i = 0; i < nbd->ndisks; i++) { virDomainDiskDefPtr disk; const char *diskSrcPath; + g_autofree char *nvmePath = NULL; VIR_DEBUG("Looking up disk target '%s' (capacity=%llu)", nbd->disks[i].target, nbd->disks[i].capacity); @@ -326,7 +327,12 @@ qemuMigrationDstPrecreateStorage(virDomainObjPtr vm, goto cleanup; } - diskSrcPath = virDomainDiskGetSource(disk); + if (disk->src->type == VIR_STORAGE_TYPE_NVME) { + virPCIDeviceAddressGetSysfsFile(&disk->src->nvme->pciAddr, &nvmePath); + diskSrcPath = nvmePath; + } else { + diskSrcPath = virDomainDiskGetSource(disk); + } /* Skip disks we don't want to migrate and already existing disks. */ if (!qemuMigrationAnyCopyDisk(disk, nmigrate_disks, migrate_disks) || -- 2.26.2

2 1

[PATCH] news: Document 'netdev_add' regression and disk type='lun' changes
by Peter Krempa 28 May '20

28 May '20

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- docs/news.xml | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 67fb85377d..104babbae7 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -46,8 +46,31 @@ <section title="New features"> </section> <section title="Improvements"> + <change> + <summary> + qemu: stricter validation for disk type='lun' + </summary> + <description> + The 'lun' type is meant for SCSI command passthrough, which can't be + achieved if qemu's block layer features are used. Disk type='lun' is now + allowed only when the format is 'raw' and no other block layer features + are requested. + </description> + </change> </section> <section title="Bug fixes"> + <change> + <summary> + qemu: fixed regression in network device hotplug with new qemu versions + </summary> + <description> + Starting from QEMU-5.0 it's required to conform to strict schema when + hotplugging network devices. Libvirt didn't conform to the schema so + in versions prior to 6.4.0 network device hotplug fails in certain + cases. This version fixes it and adds stricter testing to prevent + further issues. + </description> + </change> </section> </release> <release version="v6.3.0" date="2020-05-05"> -- 2.26.2

2 1

[GSoC'20]: Student Introduction
by PRAKHAR BANSAL 28 May '20

28 May '20

Hello Everyone, I am Prakhar Bansal, Google Summer of Code Student from Iowa State University, USA. In the next few months, I will be working on the Project " Libvirt Support For Jailhouse Hypervisor" under the guidance of my mentors Michal Privoznik and Jan Kiszka. This project aims to add support for Jailhouse( partitioning hypervisor based on Linux) in the Libvirt API to make it easier to use this hypervisor using the well known Libvirt API or through various applications using Libvirt. I am available on IRC with a nickname as prakhar. Thanks, Prakhar

1 1

Entering freeze for libvirt-6.4.0
by Daniel Veillard 27 May '20

27 May '20

We are getting at the end of the month and Monday is closed here, so I though it was better to roll RC1 even if I had not yet announced the release plan, I assume it's better than skipping by a few days. So it is there, I tagged it in git head and pushed signed tarball and source rpm to the usual place: https://libvirt.org/sources/ I seems to work in my limited testing and there is only a few red spots on the CI https://ci.centos.org/view/libvirt/ but TBH that doesn't look critical. Please give it a try, I will try to roll RC2 on Friday, then assuming everything looks fine 6.4.0 could go out on Tuesday, thanks in advance, Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[PATCH v5 00/10] Introducing TPM Proxy device support for PPC64
by Daniel Henrique Barboza 27 May '20

27 May '20

changes in v5: - rebased and fixed commits to master at d265171b5784 - moved two TPMs validation from domain_conf.c (patch 05) to qemu_domain.c (patch 06) Gitlab tree: https://gitlab.com/danielhb/libvirt/tree/spapr_tpm_proxy_v5 v4 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00814.html v3 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00642.html v2 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00604.html v1 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00604.html Daniel Henrique Barboza (10): docs: documentation and schema for the new TPM Proxy model qemu: Extend QEMU capabilities with 'spapr-tpm-proxy' qemu_extdevice.c: remove unneeded 'ret' variable qemu_tpm, security, tests: change 'switch' clauses for 'if' conf, qemu, security, tests: introducing 'def->tpms' array qemu: add validations after TPM Proxy model introduction tests: add XML schema tests for the TPM Proxy device qemu: build command line for the TPM Proxy device tests/qemuxml2argvtest.c: add TPM Proxy command line tests docs/news.xml: update for the new TPM Proxy device docs/formatdomain.html.in | 19 ++++- docs/news.xml | 17 +++++ docs/schemas/domaincommon.rng | 1 + src/conf/domain_audit.c | 4 +- src/conf/domain_conf.c | 50 +++++++----- src/conf/domain_conf.h | 6 +- src/qemu/qemu_alias.c | 9 ++- src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_cgroup.c | 10 ++- src/qemu/qemu_command.c | 59 +++++++++++--- src/qemu/qemu_domain.c | 68 ++++++++++++++--- src/qemu/qemu_domain_address.c | 11 ++- src/qemu/qemu_extdevice.c | 24 +++--- src/qemu/qemu_tpm.c | 76 +++++++++---------- src/qemu/qemu_validate.c | 19 +++++ src/security/security_dac.c | 8 +- src/security/security_selinux.c | 44 +++++------ src/security/virt-aa-helper.c | 14 ++-- .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 + tests/qemuxml2argvdata/ppc64-tpm-double.xml | 34 +++++++++ .../ppc64-tpmproxy-double.xml | 38 ++++++++++ .../ppc64-tpmproxy-single.ppc64-latest.args | 34 +++++++++ .../ppc64-tpmproxy-single.xml | 33 ++++++++ .../ppc64-tpmproxy-with-tpm.ppc64-latest.args | 37 +++++++++ .../ppc64-tpmproxy-with-tpm.xml | 36 +++++++++ tests/qemuxml2argvtest.c | 33 +++++--- .../ppc64-tpmproxy-single.ppc64-latest.xml | 42 ++++++++++ .../ppc64-tpmproxy-with-tpm.ppc64-latest.xml | 46 +++++++++++ tests/qemuxml2xmltest.c | 2 + 31 files changed, 631 insertions(+), 152 deletions(-) create mode 100644 tests/qemuxml2argvdata/ppc64-tpm-double.xml create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-double.xml create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-single.ppc64-latest.args create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-single.xml create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-with-tpm.ppc64-latest.args create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-with-tpm.xml create mode 100644 tests/qemuxml2xmloutdata/ppc64-tpmproxy-single.ppc64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/ppc64-tpmproxy-with-tpm.ppc64-latest.xml -- 2.26.2

3 16

[PULL 00/14] mips-hw-next patches for 2020-05-26
by Philippe Mathieu-Daudé 27 May '20

27 May '20

The following changes since commit 8f72c75cfc9b3c84a9b5e7a58ee5e471cb2f19c8: Merge remote-tracking branch 'remotes/kraxel/tags/audio-20200526-pull-reque= st' into staging (2020-05-26 10:59:01 +0100) are available in the Git repository at: https://gitlab.com/philmd/qemu.git tags/mips-hw-next-20200526 for you to fetch changes up to 97d8974620053db5754af808583de70380f73a10: MAINTAINERS: Change Aleksandar Rikalo's email address (2020-05-26 13:21:12 = +0200) ---------------------------------------------------------------- MIPS hardware updates - MAINTAINERS updated to welcome Huacai Chen and Jiaxun Yang, and update Aleksandar Rikalo's email address, - Trivial improvements in the Bonito64 North Bridge and the Fuloong 2e machine, - MIPS Machines names unified without 'mips_' prefix. CI: https://travis-ci.org/github/philmd/qemu/builds/691247975 ---------------------------------------------------------------- Aleksandar Markovic (3): hw/mips: Rename malta/mipssim/r4k/jazz files hw/mips/malta: Add some logging for bad register offset cases MAINTAINERS: Change Aleksandar Rikalo's email address Huacai Chen (1): MAINTAINERS: Add Huacai Chen as fuloong2e co-maintainer Philippe Mathieu-Daud=C3=A9 (10): hw/pci-host: Use CONFIG_PCI_BONITO to select the Bonito North Bridge hw/pci-host/bonito: Fix DPRINTF() format strings hw/pci-host/bonito: Map peripheral using physical address hw/pci-host/bonito: Map all the Bonito64 I/O range hw/pci-host/bonito: Map the different PCI ranges more detailed hw/pci-host/bonito: Better describe the I/O CS regions hw/pci-host/bonito: Set the Config register reset value with FIELD_DP32 hw/mips/fuloong2e: Move code and update a comment hw/mips/fuloong2e: Fix typo in Fuloong machine name hw/mips/mips_int: De-duplicate KVM interrupt delivery docs/system/deprecated.rst | 5 ++ docs/system/target-mips.rst | 2 +- default-configs/mips64el-softmmu.mak | 2 +- hw/isa/vt82c686.c | 2 +- hw/mips/{mips_fulong2e.c =3D> fuloong2e.c} | 48 ++++++------- hw/mips/{mips_jazz.c =3D> jazz.c} | 0 hw/mips/{mips_malta.c =3D> malta.c} | 14 ++-- hw/mips/mips_int.c | 11 +-- hw/mips/{mips_mipssim.c =3D> mipssim.c} | 0 hw/mips/{mips_r4k.c =3D> r4k.c} | 0 hw/pci-host/bonito.c | 87 +++++++++++++++++++----- tests/qtest/endianness-test.c | 2 +- .mailmap | 3 +- MAINTAINERS | 26 +++---- hw/mips/Kconfig | 3 +- hw/mips/Makefile.objs | 10 +-- hw/pci-host/Kconfig | 5 ++ hw/pci-host/Makefile.objs | 2 +- 18 files changed, 142 insertions(+), 80 deletions(-) rename hw/mips/{mips_fulong2e.c =3D> fuloong2e.c} (91%) rename hw/mips/{mips_jazz.c =3D> jazz.c} (100%) rename hw/mips/{mips_malta.c =3D> malta.c} (99%) rename hw/mips/{mips_mipssim.c =3D> mipssim.c} (100%) rename hw/mips/{mips_r4k.c =3D> r4k.c} (100%) --=20 2.21.3

2 15

[PATCH v2] security: don't fail if built without attr support
by Christian Ehrhardt 27 May '20

27 May '20

If built without attr support removing any image will trigger qemuBlockRemoveImageMetadata (the one that emits the warning) -> qemuSecurityMoveImageMetadata -> virSecurityManagerMoveImageMetadata -> virSecurityDACMoveImageMetadata -> virSecurityDACMoveImageMetadataHelper -> virProcessRunInFork (spawns subprocess) -> virSecurityMoveRememberedLabel In there due to !HAVE_LIBATTR virFileGetXAttrQuiet will return ENOSYS and from there the chain will error out. That is wrong and looks like: libvirtd[6320]: internal error: child reported (status=125): libvirtd[6320]: Unable to remove disk metadata on vm testguest from /var/lib/uvtool/libvirt/images/testguest.qcow (disk target vda) This change makes virSecurityDACMoveImageMetadataHelper and virSecuritySELinuxMoveImageMetadataHelper accept that error code gracefully and in that sense it is an extension of: 5214b2f1a3f "security: Don't skip label restore on file systems lacking XATTRs" which does the same for other call chains into the virFile*XAttr functions. Signed-off-by: Christian Ehrhardt <christian.ehrhardt(a)canonical.com> Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/security/security_dac.c | 6 ++++++ src/security/security_selinux.c | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/src/security/security_dac.c b/src/security/security_dac.c index bdc2d7edf3..7b95a6f86d 100644 --- a/src/security/security_dac.c +++ b/src/security/security_dac.c @@ -1117,6 +1117,12 @@ virSecurityDACMoveImageMetadataHelper(pid_t pid G_GNUC_UNUSED, ret = virSecurityMoveRememberedLabel(SECURITY_DAC_NAME, data->src, data->dst); virSecurityManagerMetadataUnlock(data->mgr, &state); + + if (ret == -2) { + /* Libvirt built without XATTRS */ + ret = 0; + } + return ret; } diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 9a929debe1..7bb7c2b7b1 100644 --- a/src/security/security_selinux.c +++ b/src/security/security_selinux.c @@ -1975,6 +1975,12 @@ virSecuritySELinuxMoveImageMetadataHelper(pid_t pid G_GNUC_UNUSED, ret = virSecurityMoveRememberedLabel(SECURITY_SELINUX_NAME, data->src, data->dst); virSecurityManagerMetadataUnlock(data->mgr, &state); + + if (ret == -2) { + /* Libvirt built without XATTRS */ + ret = 0; + } + return ret; } -- 2.26.0

1 1

[PATCH 00/14] hw/mips: patch queue for 2020-05-26
by Philippe Mathieu-Daudé 27 May '20

27 May '20

Hi, This is the current state of my hw/mips/next tree. - MAINTAINERS updated to welcome Huacai Chen and Jiaxun Yang, and update Aleksandar Rikalo's email address, - Trivial improvements in the Bonito64 North Bridge and the Fuloong 2e machine, - MIPS Machines names unified without 'mips_' prefix. The following patches need review: - #6 "hw/pci-host/bonito: Map the different PCI ranges more detailled" - #10 "hw/mips/fuloong2e: Fix typo in Fuloong machine name" Aleksandar Markovic (3): hw/mips: Rename malta/mipssim/r4k/jazz files hw/mips/malta: Add some logging for bad register offset cases MAINTAINERS: Change Aleksandar Rikalo's email address Huacai Chen (1): MAINTAINERS: Add Huacai Chen as fuloong2e co-maintainer Philippe Mathieu-Daudé (10): hw/pci-host: Use CONFIG_PCI_BONITO to select the Bonito North Bridge hw/pci-host/bonito: Fix DPRINTF() format strings hw/pci-host/bonito: Map peripheral using physical address hw/pci-host/bonito: Map all the Bonito64 I/O range hw/pci-host/bonito: Map the different PCI ranges more detailled hw/pci-host/bonito: Better describe the I/O CS regions hw/pci-host/bonito: Set the Config register reset value with FIELD_DP32 hw/mips/fuloong2e: Move code and update a comment hw/mips/fuloong2e: Fix typo in Fuloong machine name hw/mips/mips_int: De-duplicate KVM interrupt delivery docs/system/deprecated.rst | 5 ++ docs/system/target-mips.rst | 2 +- default-configs/mips64el-softmmu.mak | 2 +- hw/isa/vt82c686.c | 2 +- hw/mips/{mips_fulong2e.c => fuloong2e.c} | 48 ++++++------- hw/mips/{mips_jazz.c => jazz.c} | 0 hw/mips/{mips_malta.c => malta.c} | 14 ++-- hw/mips/mips_int.c | 11 +-- hw/mips/{mips_mipssim.c => mipssim.c} | 0 hw/mips/{mips_r4k.c => r4k.c} | 0 hw/pci-host/bonito.c | 87 +++++++++++++++++++----- tests/qtest/endianness-test.c | 2 +- .mailmap | 3 +- MAINTAINERS | 26 +++---- hw/mips/Kconfig | 3 +- hw/mips/Makefile.objs | 10 +-- hw/pci-host/Kconfig | 5 ++ hw/pci-host/Makefile.objs | 2 +- 18 files changed, 142 insertions(+), 80 deletions(-) rename hw/mips/{mips_fulong2e.c => fuloong2e.c} (91%) rename hw/mips/{mips_jazz.c => jazz.c} (100%) rename hw/mips/{mips_malta.c => malta.c} (99%) rename hw/mips/{mips_mipssim.c => mipssim.c} (100%) rename hw/mips/{mips_r4k.c => r4k.c} (100%) -- 2.21.3

3 29

[PATCH v2.1 0/3] Support network interface downscript
by Chen Hanxiao 26 May '20

26 May '20

QEMU has the ability to run a script when a NIC is brought up and down. Libvirt only enables use of the up script at this time. This series add support for postscript when NIC is down/detached. Chen Hanxiao (3): interface: introduce downscript downscript: add support for booting and hotplug interface news: add description about downscript docs/formatdomain.html.in | 6 ++- docs/news.xml | 10 +++++ docs/schemas/domaincommon.rng | 8 ++++ src/conf/domain_conf.c | 9 ++++ src/conf/domain_conf.h | 1 + src/qemu/qemu_extdevice.c | 4 ++ src/qemu/qemu_hotplug.c | 3 ++ tests/qemuxml2argvdata/downscript.xml | 60 +++++++++++++++++++++++++ tests/qemuxml2xmloutdata/downscript.xml | 60 +++++++++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 10 files changed, 161 insertions(+), 1 deletion(-) create mode 100644 tests/qemuxml2argvdata/downscript.xml create mode 100644 tests/qemuxml2xmloutdata/downscript.xml -- 2.23.0

2 6

[PATCH 0/8] qemu: Use memory-backend-* for regular guest memory
by Michal Privoznik 26 May '20

26 May '20

DISCLAIMER: These patches depend on a yet not merged QEMU patch: https://lists.nongnu.org/archive/html/qemu-devel/2020-05/msg07255.html This is another round of patches that are adapting Libvirt to new QEMU command line so that they can deprecate the old one. See 8/8 for explanation. Michal Prívozník (8): qemuBuildMemoryBackendProps: Move @prealloc setting to backend agnostic part qemuBuildMemoryBackendProps: Respect //memoryBacking/allocation/@mode=immediate qemuBuildMemoryBackendProps: Prealloc mem for memfd backend qemuBuildMemoryBackendProps: Fix const correctness qemu: Introduce QEMU_CAPS_MACHINE_MEMORY_BACKEND qemu: Track default-ram-id machine attribute qemucapabilitiestest: Update 5.1.0 data qemu: Use memory-backend-* for regular guest memory src/qemu/qemu_capabilities.c | 42 ++- src/qemu/qemu_capabilities.h | 6 + src/qemu/qemu_capspriv.h | 3 +- src/qemu/qemu_command.c | 98 ++++-- src/qemu/qemu_command.h | 4 +- src/qemu/qemu_monitor.c | 1 + src/qemu/qemu_monitor.h | 1 + src/qemu/qemu_monitor_json.c | 11 + .../caps_5.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 + .../caps_5.0.0.riscv64.xml | 1 + .../caps_5.0.0.x86_64.xml | 1 + .../caps_5.1.0.x86_64.replies | 280 ++++++++++++------ .../caps_5.1.0.x86_64.xml | 181 +++++------ .../blkdeviotune-group-num.x86_64-latest.args | 3 +- ...blkdeviotune-max-length.x86_64-latest.args | 3 +- .../blkdeviotune-max.x86_64-latest.args | 3 +- .../channel-unix-guestfwd.x86_64-latest.args | 3 +- .../console-virtio-unix.x86_64-latest.args | 3 +- .../controller-virtio-scsi.x86_64-latest.args | 3 +- ...-Icelake-Server-pconfig.x86_64-latest.args | 3 +- .../cpu-translation.x86_64-latest.args | 3 +- .../disk-aio-io_uring.x86_64-latest.args | 3 +- .../disk-aio.x86_64-latest.args | 3 +- ...-backing-chains-noindex.x86_64-latest.args | 3 +- .../disk-cache.x86_64-latest.args | 4 +- .../disk-cdrom-bus-other.x86_64-latest.args | 3 +- ...m-empty-network-invalid.x86_64-latest.args | 3 +- .../disk-cdrom-network.x86_64-latest.args | 3 +- .../disk-cdrom-tray.x86_64-latest.args | 3 +- .../disk-cdrom.x86_64-latest.args | 3 +- .../disk-copy_on_read.x86_64-latest.args | 3 +- .../disk-detect-zeroes.x86_64-latest.args | 3 +- .../disk-discard.x86_64-latest.args | 3 +- .../disk-error-policy.x86_64-latest.args | 3 +- .../disk-floppy-q35-2_11.x86_64-latest.args | 4 +- .../disk-floppy-q35-2_9.x86_64-latest.args | 4 +- .../disk-floppy.x86_64-latest.args | 3 +- .../disk-network-gluster.x86_64-latest.args | 3 +- .../disk-network-http.x86_64-latest.args | 3 +- .../disk-network-iscsi.x86_64-latest.args | 3 +- .../disk-network-nbd.x86_64-latest.args | 3 +- .../disk-network-rbd.x86_64-latest.args | 3 +- .../disk-network-sheepdog.x86_64-latest.args | 3 +- ...isk-network-source-auth.x86_64-latest.args | 3 +- .../disk-network-tlsx509.x86_64-latest.args | 3 +- .../disk-nvme.x86_64-latest.args | 3 +- .../disk-readonly-disk.x86_64-latest.args | 3 +- .../disk-scsi-device-auto.x86_64-latest.args | 3 +- .../disk-scsi.x86_64-latest.args | 3 +- .../disk-shared.x86_64-latest.args | 3 +- .../disk-slices.x86_64-latest.args | 3 +- ...irtio-scsi-reservations.x86_64-latest.args | 3 +- .../eoi-disabled.x86_64-latest.args | 3 +- .../eoi-enabled.x86_64-latest.args | 3 +- .../floppy-drive-fat.x86_64-latest.args | 3 +- .../qemuxml2argvdata/fs9p.x86_64-latest.args | 3 +- .../genid-auto.x86_64-latest.args | 3 +- .../qemuxml2argvdata/genid.x86_64-latest.args | 3 +- ...egl-headless-rendernode.x86_64-latest.args | 3 +- .../graphics-egl-headless.x86_64-latest.args | 3 +- ...pice-gl-auto-rendernode.x86_64-latest.args | 3 +- ...graphics-vnc-tls-secret.x86_64-latest.args | 3 +- .../graphics-vnc-tls.x86_64-latest.args | 3 +- ...tdev-mdev-display-ramfb.x86_64-latest.args | 3 +- ...play-spice-egl-headless.x86_64-latest.args | 3 +- ...ev-display-spice-opengl.x86_64-latest.args | 3 +- ...isplay-vnc-egl-headless.x86_64-latest.args | 3 +- ...ostdev-mdev-display-vnc.x86_64-latest.args | 3 +- .../qemuxml2argvdata/hugepages-memaccess.args | 30 +- .../hugepages-memaccess2.args | 12 +- .../hugepages-numa-nodeset-part.args | 5 +- .../hugepages-numa-nodeset.args | 20 +- .../hugepages-nvdimm.x86_64-latest.args | 15 +- tests/qemuxml2argvdata/hugepages-shared.args | 24 +- .../hyperv-off.x86_64-latest.args | 3 +- .../hyperv-panic.x86_64-latest.args | 3 +- .../hyperv-stimer-direct.x86_64-latest.args | 3 +- .../hyperv.x86_64-latest.args | 3 +- ...ntel-iommu-caching-mode.x86_64-latest.args | 4 +- ...ntel-iommu-device-iotlb.x86_64-latest.args | 4 +- .../intel-iommu-eim.x86_64-latest.args | 4 +- .../intel-iommu.x86_64-latest.args | 3 +- ...threads-virtio-scsi-pci.x86_64-latest.args | 3 +- .../kvmclock+eoi-disabled.x86_64-latest.args | 3 +- ...luks-disks-source-qcow2.x86_64-latest.args | 4 +- ...memory-default-hugepage.x86_64-latest.args | 8 +- .../memfd-memory-numa.x86_64-latest.args | 8 +- .../memory-hotplug-dimm-addr.args | 6 +- .../qemuxml2argvdata/memory-hotplug-dimm.args | 6 +- ...y-hotplug-nvdimm-access.x86_64-latest.args | 8 +- ...ry-hotplug-nvdimm-align.x86_64-latest.args | 8 +- ...ry-hotplug-nvdimm-label.x86_64-latest.args | 8 +- ...ory-hotplug-nvdimm-pmem.x86_64-latest.args | 8 +- ...ory-hotplug-nvdimm-ppc64.ppc64-latest.args | 2 +- ...hotplug-nvdimm-readonly.x86_64-latest.args | 8 +- .../memory-hotplug-nvdimm.x86_64-latest.args | 6 +- .../mlock-off.x86_64-latest.args | 3 +- .../mlock-on.x86_64-latest.args | 3 +- .../net-vhostuser.x86_64-latest.args | 3 +- .../os-firmware-bios.x86_64-latest.args | 4 +- ...os-firmware-efi-secboot.x86_64-latest.args | 4 +- .../os-firmware-efi.x86_64-latest.args | 4 +- .../qemuxml2argvdata/pages-dimm-discard.args | 4 +- .../parallel-unix-chardev.x86_64-latest.args | 3 +- ...cie-root-port-nohotplug.x86_64-latest.args | 3 +- .../pv-spinlock-disabled.x86_64-latest.args | 3 +- .../pv-spinlock-enabled.x86_64-latest.args | 3 +- .../qemu-ns.x86_64-latest.args | 3 +- .../serial-unix-chardev.x86_64-latest.args | 3 +- ...rtcard-passthrough-unix.x86_64-latest.args | 3 +- .../tpm-emulator-tpm2-enc.x86_64-latest.args | 4 +- .../tpm-emulator-tpm2.x86_64-latest.args | 4 +- .../tpm-emulator.x86_64-latest.args | 4 +- .../tpm-passthrough-crb.x86_64-latest.args | 4 +- .../tpm-passthrough.x86_64-latest.args | 4 +- .../tseg-explicit-size.x86_64-latest.args | 4 +- .../usb-redir-unix.x86_64-latest.args | 3 +- tests/qemuxml2argvdata/user-aliases.args | 16 +- ...vhost-user-fs-fd-memory.x86_64-latest.args | 4 +- ...vhost-user-fs-hugepages.x86_64-latest.args | 10 +- ...host-user-gpu-secondary.x86_64-latest.args | 3 +- .../vhost-user-vga.x86_64-latest.args | 3 +- .../vhost-vsock-auto.x86_64-latest.args | 4 +- .../vhost-vsock.x86_64-latest.args | 3 +- ...eo-bochs-display-device.x86_64-latest.args | 3 +- ...video-qxl-device-vram64.x86_64-latest.args | 3 +- ...o-qxl-sec-device-vram64.x86_64-latest.args | 3 +- ...eo-ramfb-display-device.x86_64-latest.args | 3 +- .../virtio-9p-multidevs.x86_64-latest.args | 3 +- ...virtio-non-transitional.x86_64-latest.args | 3 +- ...-options-controller-ats.x86_64-latest.args | 3 +- ...ptions-controller-iommu.x86_64-latest.args | 3 +- ...tions-controller-packed.x86_64-latest.args | 3 +- ...virtio-options-disk-ats.x86_64-latest.args | 3 +- ...rtio-options-disk-iommu.x86_64-latest.args | 3 +- ...tio-options-disk-packed.x86_64-latest.args | 3 +- .../virtio-options-fs-ats.x86_64-latest.args | 3 +- ...virtio-options-fs-iommu.x86_64-latest.args | 3 +- ...irtio-options-fs-packed.x86_64-latest.args | 3 +- ...irtio-options-input-ats.x86_64-latest.args | 3 +- ...tio-options-input-iommu.x86_64-latest.args | 3 +- ...io-options-input-packed.x86_64-latest.args | 3 +- ...-options-memballoon-ats.x86_64-latest.args | 3 +- ...ptions-memballoon-iommu.x86_64-latest.args | 3 +- ...tions-memballoon-packed.x86_64-latest.args | 3 +- .../virtio-options-net-ats.x86_64-latest.args | 3 +- ...irtio-options-net-iommu.x86_64-latest.args | 3 +- ...rtio-options-net-packed.x86_64-latest.args | 3 +- .../virtio-options-rng-ats.x86_64-latest.args | 3 +- ...irtio-options-rng-iommu.x86_64-latest.args | 3 +- ...rtio-options-rng-packed.x86_64-latest.args | 3 +- ...irtio-options-video-ats.x86_64-latest.args | 3 +- ...tio-options-video-iommu.x86_64-latest.args | 3 +- ...io-options-video-packed.x86_64-latest.args | 3 +- .../virtio-options.x86_64-latest.args | 3 +- .../virtio-rng-builtin.x86_64-latest.args | 3 +- .../virtio-rng-egd-unix.x86_64-latest.args | 3 +- .../virtio-transitional.x86_64-latest.args | 3 +- ...-default-cpu-kvm-pc-4.2.x86_64-latest.args | 4 +- ...default-cpu-kvm-q35-4.2.x86_64-latest.args | 4 +- ...-default-cpu-tcg-pc-4.2.x86_64-latest.args | 4 +- ...default-cpu-tcg-q35-4.2.x86_64-latest.args | 4 +- .../x86_64-pc-graphics.x86_64-latest.args | 3 +- .../x86_64-pc-headless.x86_64-latest.args | 3 +- .../x86_64-q35-graphics.x86_64-latest.args | 3 +- .../x86_64-q35-headless.x86_64-latest.args | 3 +- tests/testutilsqemu.c | 15 +- 168 files changed, 843 insertions(+), 436 deletions(-) -- 2.26.2

1 8

[libvirt PATCH] cpu_map: Distribute x86_Cooperlake.xml
by Jiri Denemark 26 May '20

26 May '20

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- I will push this as a build breaker once https://gitlab.com/jirkade/libvirt/pipelines/149651008 pipeline succeeds. src/cpu_map/Makefile.inc.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/cpu_map/Makefile.inc.am b/src/cpu_map/Makefile.inc.am index 5d9190e27d..62403d2ed0 100644 --- a/src/cpu_map/Makefile.inc.am +++ b/src/cpu_map/Makefile.inc.am @@ -29,6 +29,7 @@ cpumap_DATA = \ cpu_map/x86_Cascadelake-Server.xml \ cpu_map/x86_Cascadelake-Server-noTSX.xml \ cpu_map/x86_Conroe.xml \ + cpu_map/x86_Cooperlake.xml \ cpu_map/x86_core2duo.xml \ cpu_map/x86_coreduo.xml \ cpu_map/x86_cpu64-rhel5.xml \ -- 2.26.2

2 1

[PATCH] Don't require secdrivers to implement .domainMoveImageMetadata
by Michal Privoznik 26 May '20

26 May '20

The AppArmor secdriver does not use labels to grant access to resources. Therefore, it doesn't use XATTRs and hence it lacks implementation of .domainMoveImageMetadata callback. This leads to a harmless but needless error message appearing in the logs: virSecurityManagerMoveImageMetadata:476 : this function is not supported by the connection driver: virSecurityManagerMoveImageMetadata Closes: https://gitlab.com/libvirt/libvirt/-/issues/25 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/security/security_manager.c | 3 +-- src/security/security_nop.c | 10 ---------- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/src/security/security_manager.c b/src/security/security_manager.c index 2dea294784..b1237d63b6 100644 --- a/src/security/security_manager.c +++ b/src/security/security_manager.c @@ -473,8 +473,7 @@ virSecurityManagerMoveImageMetadata(virSecurityManagerPtr mgr, return ret; } - virReportUnsupportedError(); - return -1; + return 0; } diff --git a/src/security/security_nop.c b/src/security/security_nop.c index c1856eb421..d5f715b916 100644 --- a/src/security/security_nop.c +++ b/src/security/security_nop.c @@ -225,15 +225,6 @@ virSecurityDomainSetImageLabelNop(virSecurityManagerPtr mgr G_GNUC_UNUSED, return 0; } -static int -virSecurityDomainMoveImageMetadataNop(virSecurityManagerPtr mgr G_GNUC_UNUSED, - pid_t pid G_GNUC_UNUSED, - virStorageSourcePtr src G_GNUC_UNUSED, - virStorageSourcePtr dst G_GNUC_UNUSED) -{ - return 0; -} - static int virSecurityDomainSetMemoryLabelNop(virSecurityManagerPtr mgr G_GNUC_UNUSED, virDomainDefPtr def G_GNUC_UNUSED, @@ -290,7 +281,6 @@ virSecurityDriver virSecurityDriverNop = { .domainSetSecurityImageLabel = virSecurityDomainSetImageLabelNop, .domainRestoreSecurityImageLabel = virSecurityDomainRestoreImageLabelNop, - .domainMoveImageMetadata = virSecurityDomainMoveImageMetadataNop, .domainSetSecurityMemoryLabel = virSecurityDomainSetMemoryLabelNop, .domainRestoreSecurityMemoryLabel = virSecurityDomainRestoreMemoryLabelNop, -- 2.26.2

3 8

[PATCH] security: don't fail if built without attr support
by Christian Ehrhardt 26 May '20

26 May '20

If built without attr support removing any image will trigger qemuBlockRemoveImageMetadata (the one that emits the warning) -> qemuSecurityMoveImageMetadata -> virSecurityManagerMoveImageMetadata -> virSecurityDACMoveImageMetadata -> virSecurityDACMoveImageMetadataHelper -> virProcessRunInFork (spawns subprocess) -> virSecurityMoveRememberedLabel In there due to !HAVE_LIBATTR virFileGetXAttrQuiet will return ENOSYS and from there the chain will error out. That is wrong and looks like: libvirtd[6320]: internal error: child reported (status=125): libvirtd[6320]: Unable to remove disk metadata on vm testguest from /var/lib/uvtool/libvirt/images/testguest.qcow (disk target vda) This change makes virSecurityDACMoveImageMetadataHelper accept that error code gracefully and in that sense it is an extension of: 5214b2f1a3f "security: Don't skip label restore on file systems lacking XATTRs" which does the same for other call chains into the virFile*XAttr functions. Signed-off-by: Christian Ehrhardt <christian.ehrhardt(a)canonical.com> --- src/security/security_dac.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/security/security_dac.c b/src/security/security_dac.c index bdc2d7edf3..7b95a6f86d 100644 --- a/src/security/security_dac.c +++ b/src/security/security_dac.c @@ -1117,6 +1117,12 @@ virSecurityDACMoveImageMetadataHelper(pid_t pid G_GNUC_UNUSED, ret = virSecurityMoveRememberedLabel(SECURITY_DAC_NAME, data->src, data->dst); virSecurityManagerMetadataUnlock(data->mgr, &state); + + if (ret == -2) { + /* Libvirt built without XATTRS */ + ret = 0; + } + return ret; } -- 2.26.0

2 1

[libvirt PATCH] scripts: Fix E741 that pycodesyle is pointing out during syntax-check
by Erik Skultety 26 May '20

26 May '20

With newer pycodestyle 2.6.0 (which is part of flake8-3.8.2) reports the following pep violation during syntax-check: ../scripts/check-remote-protocol.py:95:9: E741 ambiguous variable name 'l' for l in err.strip().split("\n") On all the distros we test on, this hasn't occurred yet, but with the future update of flake8 it likely would. The fix is easy, just name the variable appropriately. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- The weird thing is that E741 checking has been in pycodestyle since 2.1.0 [1], we now have 2.5.0 and yet only 2.6.0 is complaining about it [1] https://pycodestyle.pycqa.org/en/latest/developer.html#id8 scripts/check-remote-protocol.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/check-remote-protocol.py b/scripts/check-remote-protocol.py index 25caa19563..cf9e3f84a1 100644 --- a/scripts/check-remote-protocol.py +++ b/scripts/check-remote-protocol.py @@ -92,8 +92,8 @@ if out == "" or pdwtagsproc.returncode != 0: else: print("WARNING: exit code %d, pdwtags appears broken:" % pdwtagsproc.returncode, file=sys.stderr) - for l in err.strip().split("\n"): - print("WARNING: %s" % l, file=sys.stderr) + for line in err.strip().split("\n"): + print("WARNING: %s" % line, file=sys.stderr) print("WARNING: skipping the remote protocol test", file=sys.stderr) sys.exit(0) -- 2.25.4

3 4

"http://libvirt.org/schemas/domain/qemu/1.0" returns 404 error
by Yan Fu 26 May '20

26 May '20

Hello everyone, The XML namespace request website can not be accessed with 404 error: http://libvirt.org/schemas/domain/qemu/1.0 Could anyone help to fix it please? Thanks, Yan Fu

2 1

[PATCH v2 0/3] Support network interface downscript
by Chen Hanxiao 25 May '20

25 May '20

QEMU has the ability to run a script when a NIC is brought up and down. Libvirt only enables use of the up script at this time. This series add support for postscript when NIC is down/detached. Chen Hanxiao (3): interface: introduce downscript downscript: add support for booting and hotplug interface downscript: docs: add docs and news docs/formatdomain.html.in | 6 ++- docs/news.xml | 10 +++++ docs/schemas/domaincommon.rng | 8 ++++ src/conf/domain_conf.c | 9 ++++ src/conf/domain_conf.h | 1 + src/qemu/qemu_extdevice.c | 4 ++ src/qemu/qemu_hotplug.c | 3 ++ tests/qemuxml2argvdata/downscript.xml | 60 +++++++++++++++++++++++++ tests/qemuxml2xmloutdata/downscript.xml | 60 +++++++++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 10 files changed, 161 insertions(+), 1 deletion(-) create mode 100644 tests/qemuxml2argvdata/downscript.xml create mode 100644 tests/qemuxml2xmloutdata/downscript.xml -- 2.23.0

2 4

[PATCH v2 0/1] qemuProcessRefreshCPU: skip 'host-model' code
by Daniel Henrique Barboza 25 May '20

25 May '20

changes in v2: - resending only patch 5/5 - changed the 'if' placement to qemuProcessRefreshCPU as suggested by Jiri Denemark - changed the commit msg to reflect the new intention of the patch link to v1: https://www.redhat.com/archives/libvir-list/2020-May/msg01049.html Daniel Henrique Barboza (1): qemuProcessRefreshCPU: skip 'host-model' logic for pSeries guests src/qemu/qemu_process.c | 9 +++++++++ 1 file changed, 9 insertions(+) -- 2.26.2

2 2

[libvirt PATCH 0/6] qemu: Invalidate capabilities when host CPU changes
by Jiri Denemark 25 May '20

25 May '20

The host CPU related info stored in the capabilities cache is no longer valid after the host CPU changes. This is not a frequent situation in real world, but it can easily happen in nested scenarios when a disk image is started with various CPUs. https://bugzilla.redhat.com/show_bug.cgi?id=1778819 Jiri Denemark (6): util: Define g_autoptr callback for FILE hostcpu: Introduce virHostCPUGetSignature hostcpu: Implement virHostCPUGetSignature for x86 hostcpu: Implement virHostCPUGetSignature for ppc64 hostcpu: Implement virHostCPUGetSignature for s390 qemu: Invalidate capabilities when host CPU changes src/libvirt_private.syms | 2 + src/qemu/qemu_capabilities.c | 24 ++++ src/qemu/qemu_capspriv.h | 1 + src/util/virfile.h | 1 + src/util/virhostcpu.c | 111 ++++++++++++++++++ src/util/virhostcpu.h | 2 + src/util/virhostcpupriv.h | 4 + tests/qemucapsprobe.c | 2 +- .../linux-ppc64-deconf-cpus.signature | 1 + .../linux-ppc64-subcores1.signature | 1 + .../linux-ppc64-subcores2.signature | 1 + .../linux-ppc64-subcores3.signature | 1 + .../linux-s390x-with-frequency.signature | 1 + .../linux-x86_64-test1.signature | 1 + .../linux-x86_64-test2.signature | 1 + .../linux-x86_64-test3.signature | 1 + .../linux-x86_64-test4.signature | 1 + .../linux-x86_64-test5.signature | 1 + .../linux-x86_64-test6.signature | 1 + .../linux-x86_64-test7.signature | 1 + .../linux-x86_64-test8.signature | 1 + .../linux-x86_64-with-die.signature | 1 + tests/virhostcputest.c | 42 ++++++- 23 files changed, 201 insertions(+), 2 deletions(-) create mode 100644 tests/virhostcpudata/linux-ppc64-deconf-cpus.signature create mode 100644 tests/virhostcpudata/linux-ppc64-subcores1.signature create mode 100644 tests/virhostcpudata/linux-ppc64-subcores2.signature create mode 100644 tests/virhostcpudata/linux-ppc64-subcores3.signature create mode 100644 tests/virhostcpudata/linux-s390x-with-frequency.signature create mode 100644 tests/virhostcpudata/linux-x86_64-test1.signature create mode 100644 tests/virhostcpudata/linux-x86_64-test2.signature create mode 100644 tests/virhostcpudata/linux-x86_64-test3.signature create mode 100644 tests/virhostcpudata/linux-x86_64-test4.signature create mode 100644 tests/virhostcpudata/linux-x86_64-test5.signature create mode 100644 tests/virhostcpudata/linux-x86_64-test6.signature create mode 100644 tests/virhostcpudata/linux-x86_64-test7.signature create mode 100644 tests/virhostcpudata/linux-x86_64-test8.signature create mode 100644 tests/virhostcpudata/linux-x86_64-with-die.signature -- 2.26.2

4 12

[PATCH 0/5] qemuProcessUpdateCPU: do not change 'fallback' for pSeries guests
by Daniel Henrique Barboza 25 May '20

25 May '20

Hi, Patch 5/5 contains a fix for [1]. The first 4 patches are g_auto() cleanups I made along the way while investigating the bug. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1660711 Daniel Henrique Barboza (5): cpu_conf.c: modernize virCPUDefCopyWithoutModel and virCPUDefCopy cpu_arm.c: modernize virCPUarmUpdate cpu_s390.c: modernize virCPUs390Update qemu_process.c: modernize qemuProcessUpdateCPU code path qemuProcessUpdateCPU: do not change 'fallback' to ALLOW for pSeries guests src/conf/cpu_conf.c | 22 +++++----------- src/cpu/cpu_arm.c | 14 ++++------ src/cpu/cpu_s390.c | 18 +++++-------- src/qemu/qemu_process.c | 58 +++++++++++++++++------------------------ 4 files changed, 43 insertions(+), 69 deletions(-) -- 2.26.2

2 11

[libvirt PATCH 0/3] cpu_map: Add Cooperlake x86 CPU model
by Jiri Denemark 25 May '20

25 May '20

Jiri Denemark (3): cputest: Add data for Cooperlake CPU cpu_map: Add pschange-mc-no bit in IA32_ARCH_CAPABILITIES MSR cpu_map: Add Cooperlake x86 CPU model src/cpu_map/index.xml | 1 + src/cpu_map/x86_Cooperlake.xml | 90 + src/cpu_map/x86_features.xml | 3 + tests/cputest.c | 1 + .../x86_64-cpuid-Cooperlake-disabled.xml | 7 + .../x86_64-cpuid-Cooperlake-enabled.xml | 11 + .../x86_64-cpuid-Cooperlake-guest.xml | 32 + .../x86_64-cpuid-Cooperlake-host.xml | 33 + .../x86_64-cpuid-Cooperlake-json.xml | 15 + .../cputestdata/x86_64-cpuid-Cooperlake.json | 1574 +++++++++++++++++ tests/cputestdata/x86_64-cpuid-Cooperlake.sig | 4 + tests/cputestdata/x86_64-cpuid-Cooperlake.xml | 68 + .../x86_64-cpuid-Core-i7-8550U-enabled.xml | 2 +- .../x86_64-cpuid-Core-i7-8550U-guest.xml | 1 + .../x86_64-cpuid-Core-i7-8550U-host.xml | 1 + .../x86_64-cpuid-Core-i7-8550U-json.xml | 1 + ...64-cpuid-Ryzen-9-3900X-12-Core-enabled.xml | 2 +- ...6_64-cpuid-Ryzen-9-3900X-12-Core-guest.xml | 1 + ...86_64-cpuid-Ryzen-9-3900X-12-Core-host.xml | 1 + ...86_64-cpuid-Ryzen-9-3900X-12-Core-json.xml | 1 + ...86_64-cpuid-Xeon-Platinum-9242-enabled.xml | 2 +- .../x86_64-cpuid-Xeon-Platinum-9242-json.xml | 1 + .../domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.0.0-q35.x86_64.xml | 2 + .../domaincapsdata/qemu_5.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.x86_64.xml | 2 + .../domaincapsdata/qemu_5.1.0-q35.x86_64.xml | 2 + .../domaincapsdata/qemu_5.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_5.1.0.x86_64.xml | 2 + 30 files changed, 1861 insertions(+), 3 deletions(-) create mode 100644 src/cpu_map/x86_Cooperlake.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Cooperlake-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Cooperlake-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Cooperlake-guest.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Cooperlake-host.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Cooperlake-json.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Cooperlake.json create mode 100644 tests/cputestdata/x86_64-cpuid-Cooperlake.sig create mode 100644 tests/cputestdata/x86_64-cpuid-Cooperlake.xml -- 2.26.2

2 4

[PATCH 0/3] Support network interface downscript
by Chen Hanxiao 25 May '20

25 May '20

QEMU has the ability to run a script when a NIC is brought up and down. Libvirt only enables use of the up script at this time. This series add support for postscript when NIC is down/detached. Chen Hanxiao (3): downscript: Support network interface downscript downscript: add test case doc: downscript: updating the documentation docs/formatdomain.html.in | 6 ++- docs/schemas/domaincommon.rng | 8 ++++ src/conf/domain_conf.c | 9 ++++ src/conf/domain_conf.h | 1 + src/qemu/qemu_extdevice.c | 4 ++ src/qemu/qemu_hotplug.c | 6 +++ tests/qemuxml2argvdata/downscript.xml | 60 +++++++++++++++++++++++++ tests/qemuxml2xmloutdata/downscript.xml | 60 +++++++++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 9 files changed, 154 insertions(+), 1 deletion(-) create mode 100644 tests/qemuxml2argvdata/downscript.xml create mode 100644 tests/qemuxml2xmloutdata/downscript.xml -- 2.23.0

2 7

[PATCH v2 1/3] libxl: Add 'permissive' option for PCI devices
by Marek Marczykowski-Górecki 22 May '20

22 May '20

From: Simon Gaiser <simon(a)invisiblethingslab.com> By setting the permissive flag the Xen guest access to the PCI config space is not filtered. This might be a security risk, but it's required for some devices and the IOMMU and interrupt remapping should (mostly?) contain it. Because of it (and that the attribute is Xen only), in an example include "permissive='no'" - to not expose users copying from documentation to extra risk. Example usage: <devices> ... <hostdev mode='subsystem' type='pci' managed='yes' permissive='yes'> <source> <address domain='0x0000' bus='0x06' slot='0x02' function='0x0'/> </source> </hostdev> </devices> Signed-off-by: Simon Gaiser <simon(a)invisiblethingslab.com> Signed-off-by: Marek Marczykowski-Górecki <marmarek(a)invisiblethingslab.com> --- Changes in v2: - improve documentation (version info, example) - update schema - use virTristateBool - add a test - improve commit message - news entry --- docs/formatdomain.html.in | 7 +++++-- docs/news.xml | 11 +++++++++++- docs/schemas/domaincommon.rng | 10 ++++++++++- src/conf/domain_conf.c | 19 +++++++++++++++++++- src/conf/domain_conf.h | 1 +- src/libxl/libxl_conf.c | 1 +- tests/libxlxml2domconfigdata/moredevs-hvm.json | 6 ++++++- tests/libxlxml2domconfigdata/moredevs-hvm.xml | 5 +++++- 8 files changed, 58 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index c530573..0d1146e 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -4987,7 +4987,7 @@ <pre> ... <devices> - <hostdev mode='subsystem' type='pci' managed='yes'> + <hostdev mode='subsystem' type='pci' managed='yes' permissive='no'> <source> <address domain='0x0000' bus='0x06' slot='0x02' function='0x0'/> </source> @@ -5082,7 +5082,10 @@ (or <code>virsh nodedev-detach</code> before starting the guest or hot-plugging the device and <code>virNodeDeviceReAttach</code> (or <code>virsh nodedev-reattach</code>) after hot-unplug or - stopping the guest. + stopping the guest. When <code>permissive</code> + (<span class="since">since 6.3.0, Xen only</span>) is "yes" + the pci config space access will not be filtered. This might be + a security issue. The default is "no". </dd> <dt><code>scsi</code></dt> <dd>For SCSI devices, user is responsible to make sure the device diff --git a/docs/news.xml b/docs/news.xml index 5835013..a8e992a 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -109,6 +109,17 @@ and/or fine tuned per individual host. </description> </change> + <change> + <summary> + xen: Add support for 'permissive' PCI device option + </summary> + <description> + <code>permissive</code> is a Xen-specific PCI device option that + disables config space write filtering. It is needed for proper + functioning of some devices using non-standard config space + registers. + </description> + </change> </section> <section title="Improvements"> </section> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 7f18e5b..5a71222 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -3065,6 +3065,11 @@ <ref name="virYesNo"/> </attribute> </optional> + <optional> + <attribute name="permissive"> + <ref name="virYesNo"/> + </attribute> + </optional> <interleave> <element name="source"> <optional> @@ -4899,6 +4904,11 @@ <ref name="virYesNo"/> </attribute> </optional> + <optional> + <attribute name="permissive"> + <ref name="virYesNo"/> + </attribute> + </optional> <choice> <ref name="hostdevsubsyspci"/> <ref name="hostdevsubsysusb"/> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 89cd8c5..fe1a864 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8434,6 +8434,7 @@ virDomainHostdevDefParseXMLSubsys(xmlNodePtr node, virDomainHostdevSubsysSCSIVHostPtr scsihostsrc = &def->source.subsys.u.scsi_host; virDomainHostdevSubsysMediatedDevPtr mdevsrc = &def->source.subsys.u.mdev; g_autofree char *managed = NULL; + g_autofree char *permissive = NULL; g_autofree char *sgio = NULL; g_autofree char *rawio = NULL; g_autofree char *backendStr = NULL; @@ -8449,6 +8450,15 @@ virDomainHostdevDefParseXMLSubsys(xmlNodePtr node, if ((managed = virXMLPropString(node, "managed")) != NULL) ignore_value(virStringParseYesNo(managed, &def->managed)); + if ((permissive = virXMLPropString(node, "permissive")) != NULL) { + if ((def->permissive = virTristateBoolTypeFromString(permissive)) < 0) { + virReportError(VIR_ERR_XML_ERROR, + _("unknown hostdev permissive setting '%s'"), + permissive); + return -1; + } + } + sgio = virXMLPropString(node, "sgio"); rawio = virXMLPropString(node, "rawio"); model = virXMLPropString(node, "model"); @@ -26091,6 +26101,9 @@ virDomainActualNetDefFormat(virBufferPtr buf, virDomainHostdevDefPtr hostdef = virDomainNetGetActualHostdev(def); if (hostdef && hostdef->managed) virBufferAddLit(buf, " managed='yes'"); + if (hostdef && hostdef->permissive) + virBufferAsprintf(buf, " permissive='%s'", + virTristateBoolTypeToString(hostdef->permissive)); } if (def->trustGuestRxFilters) virBufferAsprintf(buf, " trustGuestRxFilters='%s'", @@ -26279,6 +26292,9 @@ virDomainNetDefFormat(virBufferPtr buf, virBufferAsprintf(buf, "<interface type='%s'", typeStr); if (hostdef && hostdef->managed) virBufferAddLit(buf, " managed='yes'"); + if (hostdef && hostdef->permissive) + virBufferAsprintf(buf, " permissive='%s'", + virTristateBoolTypeToString(hostdef->permissive)); if (def->trustGuestRxFilters) virBufferAsprintf(buf, " trustGuestRxFilters='%s'", virTristateBoolTypeToString(def->trustGuestRxFilters)); @@ -28063,6 +28079,9 @@ virDomainHostdevDefFormat(virBufferPtr buf, if (def->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) { virBufferAsprintf(buf, " managed='%s'", def->managed ? "yes" : "no"); + if (def->permissive) + virBufferAsprintf(buf, " permissive='%s'", + virTristateBoolTypeToString(def->permissive)); if (def->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI && scsisrc->sgio) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index ecb80ef..24ec03c 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -345,6 +345,7 @@ struct _virDomainHostdevDef { bool missing; bool readonly; bool shareable; + virTristateBool permissive; union { virDomainHostdevSubsys subsys; virDomainHostdevCaps caps; diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 458dfc2..23dd0e4 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -2284,6 +2284,7 @@ libxlMakePCI(virDomainHostdevDefPtr hostdev, libxl_device_pci *pcidev) pcidev->bus = pcisrc->addr.bus; pcidev->dev = pcisrc->addr.slot; pcidev->func = pcisrc->addr.function; + pcidev->permissive = hostdev->permissive == VIR_TRISTATE_BOOL_YES; return 0; } diff --git a/tests/libxlxml2domconfigdata/moredevs-hvm.json b/tests/libxlxml2domconfigdata/moredevs-hvm.json index 7bfd68b..474aa2c 100644 --- a/tests/libxlxml2domconfigdata/moredevs-hvm.json +++ b/tests/libxlxml2domconfigdata/moredevs-hvm.json @@ -88,6 +88,12 @@ "dev": 16, "bus": 10, "rdm_policy": "invalid" + }, + { + "dev": 8, + "bus": 10, + "permissive": true, + "rdm_policy": "invalid" } ], "vfbs": [ diff --git a/tests/libxlxml2domconfigdata/moredevs-hvm.xml b/tests/libxlxml2domconfigdata/moredevs-hvm.xml index f7eb09f..1b6b738 100644 --- a/tests/libxlxml2domconfigdata/moredevs-hvm.xml +++ b/tests/libxlxml2domconfigdata/moredevs-hvm.xml @@ -48,6 +48,11 @@ <address type='pci' domain='0x0000' bus='0x0a' slot='0x10' function='0x0'/> </source> </interface> + <hostdev mode='subsystem' type='pci' managed='yes' permissive='yes'> + <source> + <address domain='0x0000' bus='0x0a' slot='0x08' function='0x0'/> + </source> + </hostdev> <graphics type='vnc'/> <video> <model type='cirrus' vram='8192' heads='1' primary='yes'/> base-commit: c3ace7e234ccd43d5a008d93e122e6d47cd58e17 -- git-series 0.9.1

3 7

[PATCH] docs: Fix a typo in formatdomain.html
by Han Han 22 May '20

22 May '20

Signed-off-by: Han Han <hhan(a)redhat.com> --- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 23eb0292..05a1ed45 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -7039,7 +7039,7 @@ qemu-kvm -net nic,model=? /dev/null <input type='keyboard' bus='virtio'/> <input type='tablet' bus='virtio'/> <input type='passthrough' bus='virtio'> - <source evdev='/dev/input/event1/> + <source evdev='/dev/input/event1'/> </input> </devices> ...</pre> -- 2.25.0

2 1

[libvirt PATCH 0/2] Fix some nodedev documentation
by Jonathon Jongsma 22 May '20

22 May '20

In response to a comment by Daniel Berrange about documentation on my previous patch series, I noticed that the node device xml format documentation appears to be split between two different pages. It seems better to document the schema fully on the formatdomain page and refer to it from the other page. Another small patch fixes a documentation error. Jonathon Jongsma (2): docs: Fix names for PF and VF PCI device capabilities docs: Document full node device xml in formatnode.html.in docs/drvnodedev.html.in | 127 ++++------------------------------------ docs/formatnode.html.in | 74 +++++++++++++++++++++-- 2 files changed, 83 insertions(+), 118 deletions(-) -- 2.21.3

2 5

[libvirt PATCH] docs: drvnodedev: Fix a few closing XML elements in the examples
by Erik Skultety 22 May '20

22 May '20

Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- Pushed as trivial. docs/drvnodedev.html.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/drvnodedev.html.in b/docs/drvnodedev.html.in index 71a8a57b0c..a9c86f9fc7 100644 --- a/docs/drvnodedev.html.in +++ b/docs/drvnodedev.html.in @@ -184,7 +184,7 @@ <address domain='0x0000' bus='0x04' slot='0x00' function='0x0'/> </capability> ... -<device></pre> +</device></pre> <h3><a id="MDEVCap">MDEV capability</a></h3> <p> @@ -300,8 +300,8 @@ <capability type='mdev'> <type id='nvidia-11'/> <iommuGroup number='12'/> - <capability/> -<device/></pre> + </capability> +</device></pre> <p> The support of mediated device's framework in libvirt's node device driver -- 2.25.4

1 0

[libvirt PATCH 0/4] scripts: improve API docs handing of enums
by Daniel P. Berrangé 22 May '20

22 May '20

In attempting to refactor the Go API bindings to be partially auto-generated, I'm encountering missing information in the enum descriptions. The effects of this series are shown in this diff: --- libvirt-api.xml 2020-05-19 12:47:22.003489289 +0100 +++ docs/libvirt-api.xml 2020-05-19 12:47:27.156476186 +0100 @@ -1,4 +1,4 @@ -<?xml version=3D"1.0" encoding=3D"ISO-8859-1"?> +<?xml version=3D"1.0" encoding=3D"UTF-8"?> <api name=3D'libvirt'> <files> <file name=3D'libvirt-domain-checkpoint'> @@ -2089,13 +2089,13 @@ </file> </files> <symbols> - <macro name=3D'LIBVIR_CHECK_VERSION' file=3D'libvirt-common'> + <macro name=3D'LIBVIR_CHECK_VERSION' file=3D'libvirt-common' params=3D'm= ajor,minor,micro' raw=3D'((major) * 1000000 + (minor) * 1000 + (micro) <=3D L= IBVIR_VERSION_NUMBER)'> <info><![CDATA[Macro for developers to easily check what version of th= e library their code is compiling against. e.g. #if LIBVIR_CHECK_VERSION(1,1,= 3) // some code that only works in 1.1.3 and newer #endif]]></info> <arg name=3D'major' info=3D'major component of the version number'/> <arg name=3D'minor' info=3D'minor component of the version number'/> <arg name=3D'micro' info=3D'micro component of the version number'/> </macro> - <macro name=3D'LIBVIR_VERSION_NUMBER' file=3D'libvirt-common'> + <macro name=3D'LIBVIR_VERSION_NUMBER' file=3D'libvirt-common' raw=3D'600= 4000'> <info><![CDATA[Macro providing the version of the library as version *= 1,000,000 + minor * 1000 + micro]]></info> </macro> <macro name=3D'VIR_CONNECT_IDENTITY_GROUP_NAME' file=3D'libvirt-host' st= ring=3D'group-name'> @@ -2125,25 +2125,25 @@ <macro name=3D'VIR_CONNECT_IDENTITY_X509_DISTINGUISHED_NAME' file=3D'lib= virt-host' string=3D'x509-distinguished-name'> <info><![CDATA[The TLS x509 certificate distinguished named as VIR_TYP= ED_PARAM_STRING]]></info> </macro> - <macro name=3D'VIR_COPY_CPUMAP' file=3D'libvirt-domain'> + <macro name=3D'VIR_COPY_CPUMAP' file=3D'libvirt-domain' params=3D'cpumap= s,maplen,vcpu,cpumap' raw=3D'memcpy(cpumap, VIR_GET_CPUMAP(cpumaps, maplen, v= cpu), maplen)'> <info><![CDATA[This macro is to be used in conjunction with virDomainG= etVcpus() and virDomainPinVcpu() APIs. VIR_COPY_CPUMAP macro extracts the cpu= map of the specified vcpu from cpumaps array and copies it into cpumap to be = used later by virDomainPinVcpu() API.]]></info> <arg name=3D'cpumaps' info=3D'pointer to an array of cpumap (in 8-bit = bytes) (IN)'/> <arg name=3D'maplen' info=3D'the length (in bytes) of one cpumap'/> <arg name=3D'vcpu' info=3D'the virtual CPU number'/> <arg name=3D'cpumap' info=3D'pointer to a cpumap (in 8-bit bytes) (OUT= ) This cpumap must be previously allocated by the caller (ie: malloc(maplen))= '/> </macro> - <macro name=3D'VIR_CPU_MAPLEN' file=3D'libvirt-domain'> + <macro name=3D'VIR_CPU_MAPLEN' file=3D'libvirt-domain' params=3D'cpu' ra= w=3D''> <info><![CDATA[This macro is to be used in conjunction with virDomainP= inVcpu() API. It returns the length (in bytes) required to store the complete= CPU map between a single virtual & all physical CPUs of a domain.]]></info> <arg name=3D'cpu' info=3D'number of physical CPUs'/> </macro> - <macro name=3D'VIR_CPU_USABLE' file=3D'libvirt-domain'> + <macro name=3D'VIR_CPU_USABLE' file=3D'libvirt-domain' params=3D'cpumaps= ,maplen,vcpu,cpu' raw=3D'VIR_CPU_USED(VIR_GET_CPUMAP(cpumaps, maplen, vcpu), = cpu)'> <info><![CDATA[This macro is to be used in conjunction with virDomainG= etVcpus() API. VIR_CPU_USABLE macro returns a non-zero value (true) if the cp= u is usable by the vcpu, and 0 otherwise.]]></info> <arg name=3D'cpumaps' info=3D'pointer to an array of cpumap (in 8-bit = bytes) (IN)'/> <arg name=3D'maplen' info=3D'the length (in bytes) of one cpumap'/> <arg name=3D'vcpu' info=3D'the virtual CPU number'/> <arg name=3D'cpu' info=3D'the physical CPU number'/> </macro> - <macro name=3D'VIR_CPU_USED' file=3D'libvirt-domain'> + <macro name=3D'VIR_CPU_USED' file=3D'libvirt-domain' params=3D'cpumap,cp= u' raw=3D'((cpumap)[(cpu) / 8] & (1 << ((cpu) % 8)))'> <info><![CDATA[This macro can be used in conjunction with virNodeGetCP= UMap() API. It returns non-zero if the bit of the related CPU is set.]]></inf= o> <arg name=3D'cpumap' info=3D'pointer to a bit map of real CPUs (in 8-b= it bytes) (IN)'/> <arg name=3D'cpu' info=3D'the physical CPU number'/> @@ -2184,7 +2184,7 @@ <macro name=3D'VIR_DOMAIN_BLKIO_DEVICE_WRITE_IOPS' file=3D'libvirt-domai= n' string=3D'device_write_iops_sec'> <info><![CDATA[Macro for the blkio tunable throttle.write_iops_device:= it represents the number of writing the block device per second, as a string= . The string is parsed as a series of /path/to/device, write_iops elements, s= eparated by ','.]]></info> </macro> - <macro name=3D'VIR_DOMAIN_BLKIO_FIELD_LENGTH' file=3D'libvirt-domain'> + <macro name=3D'VIR_DOMAIN_BLKIO_FIELD_LENGTH' file=3D'libvirt-domain' ra= w=3D'VIR_TYPED_PARAM_FIELD_LENGTH'> <info><![CDATA[Macro providing the field length of virBlkioParameter. = Provided for backwards compatibility; VIR_TYPED_PARAM_FIELD_LENGTH is the pr= eferred value since 0.9.2.]]></info> </macro> <macro name=3D'VIR_DOMAIN_BLKIO_WEIGHT' file=3D'libvirt-domain' string= =3D'weight'> @@ -2262,7 +2262,7 @@ <macro name=3D'VIR_DOMAIN_BLOCK_STATS_ERRS' file=3D'libvirt-domain' stri= ng=3D'errs'> <info><![CDATA[In Xen this returns the mysterious 'oo_req', as an llon= g.]]></info> </macro> - <macro name=3D'VIR_DOMAIN_BLOCK_STATS_FIELD_LENGTH' file=3D'libvirt-doma= in'> + <macro name=3D'VIR_DOMAIN_BLOCK_STATS_FIELD_LENGTH' file=3D'libvirt-doma= in' raw=3D'VIR_TYPED_PARAM_FIELD_LENGTH'> <info><![CDATA[Macro providing the field length of parameter names whe= n using virDomainBlockStatsFlags().]]></info> </macro> <macro name=3D'VIR_DOMAIN_BLOCK_STATS_FLUSH_REQ' file=3D'libvirt-domain'= string=3D'flush_operations'> @@ -2301,7 +2301,7 @@ <macro name=3D'VIR_DOMAIN_CPU_STATS_VCPUTIME' file=3D'libvirt-domain' st= ring=3D'vcpu_time'> <info><![CDATA[vcpu usage in nanoseconds (cpu_time excluding hyperviso= r time), as a ullong]]></info> </macro> - <macro name=3D'VIR_DOMAIN_EVENT_CALLBACK' file=3D'libvirt-domain'> + <macro name=3D'VIR_DOMAIN_EVENT_CALLBACK' file=3D'libvirt-domain' params= =3D'cb' raw=3D''> <info><![CDATA[Used to cast the event specific callback into the gener= ic one for use for virConnectDomainEventRegisterAny()]]></info> </macro> <macro name=3D'VIR_DOMAIN_IOTHREAD_POLL_GROW' file=3D'libvirt-domain' st= ring=3D'poll_grow'> @@ -2421,7 +2421,7 @@ <macro name=3D'VIR_DOMAIN_LAUNCH_SECURITY_SEV_MEASUREMENT' file=3D'libvi= rt-domain' string=3D'sev-measurement'> <info><![CDATA[Macro represents the launch measurement of the SEV gues= t, as VIR_TYPED_PARAM_STRING.]]></info> </macro> - <macro name=3D'VIR_DOMAIN_MEMORY_FIELD_LENGTH' file=3D'libvirt-domain'> + <macro name=3D'VIR_DOMAIN_MEMORY_FIELD_LENGTH' file=3D'libvirt-domain' r= aw=3D'VIR_TYPED_PARAM_FIELD_LENGTH'> <info><![CDATA[Macro providing the field length of virMemoryParameter.= Provided for backwards compatibility; VIR_TYPED_PARAM_FIELD_LENGTH is the p= referred value since 0.9.2.]]></info> </macro> <macro name=3D'VIR_DOMAIN_MEMORY_HARD_LIMIT' file=3D'libvirt-domain' str= ing=3D'hard_limit'> @@ -2430,7 +2430,7 @@ <macro name=3D'VIR_DOMAIN_MEMORY_MIN_GUARANTEE' file=3D'libvirt-domain' = string=3D'min_guarantee'> <info><![CDATA[Macro for the memory tunable min_guarantee: it represen= ts the minimum memory guaranteed to be reserved for the guest, as a ullong.]]= ></info> </macro> - <macro name=3D'VIR_DOMAIN_MEMORY_PARAM_UNLIMITED' file=3D'libvirt-domain= '> + <macro name=3D'VIR_DOMAIN_MEMORY_PARAM_UNLIMITED' file=3D'libvirt-domain= ' raw=3D'9007199254740991LL /* =3D INT64_MAX >> 10 */'> <info><![CDATA[Macro providing the virMemoryParameter value that indic= ates "unlimited"]]></info> </macro> <macro name=3D'VIR_DOMAIN_MEMORY_SOFT_LIMIT' file=3D'libvirt-domain' str= ing=3D'soft_limit'> @@ -2487,10 +2487,10 @@ <macro name=3D'VIR_DOMAIN_SCHEDULER_WEIGHT' file=3D'libvirt-domain' stri= ng=3D'weight'> <info><![CDATA[Macro represents the relative weight, when using the c= redit scheduler, as a uint.]]></info> </macro> - <macro name=3D'VIR_DOMAIN_SCHED_FIELD_LENGTH' file=3D'libvirt-domain'> + <macro name=3D'VIR_DOMAIN_SCHED_FIELD_LENGTH' file=3D'libvirt-domain' ra= w=3D'VIR_TYPED_PARAM_FIELD_LENGTH'> <info><![CDATA[Macro providing the field length of virSchedParameter. = Provided for backwards compatibility; VIR_TYPED_PARAM_FIELD_LENGTH is the pr= eferred value since 0.9.2.]]></info> </macro> - <macro name=3D'VIR_DOMAIN_SEND_KEY_MAX_KEYS' file=3D'libvirt-domain'> + <macro name=3D'VIR_DOMAIN_SEND_KEY_MAX_KEYS' file=3D'libvirt-domain' raw= =3D'16'> <info><![CDATA[Maximum number of keycodes that can be sent in one virD= omainSendKey() call.]]></info> </macro> <macro name=3D'VIR_DOMAIN_TUNABLE_BLKDEV_DISK' file=3D'libvirt-domain' s= tring=3D'blkdeviotune.disk'> @@ -2592,13 +2592,13 @@ <macro name=3D'VIR_DOMAIN_TUNABLE_CPU_VCPU_QUOTA' file=3D'libvirt-domain= ' string=3D'cputune.vcpu_quota'> <info><![CDATA[Macro represents the maximum bandwidth to be used withi= n a period for vcpus only, when using the posix scheduler, as VIR_TYPED_PARAM= _LLONG.]]></info> </macro> - <macro name=3D'VIR_GET_CPUMAP' file=3D'libvirt-domain'> + <macro name=3D'VIR_GET_CPUMAP' file=3D'libvirt-domain' params=3D'cpumaps= ,maplen,vcpu' raw=3D'(&((cpumaps)[(vcpu) * (maplen)]))'> <info><![CDATA[This macro is to be used in conjunction with virDomainG= etVcpus() and virDomainPinVcpu() APIs. VIR_GET_CPUMAP macro returns a pointer= to the cpumap of the specified vcpu from cpumaps array.]]></info> <arg name=3D'cpumaps' info=3D'pointer to an array of cpumap (in 8-bit = bytes) (IN)'/> <arg name=3D'maplen' info=3D'the length (in bytes) of one cpumap'/> <arg name=3D'vcpu' info=3D'the virtual CPU number'/> </macro> - <macro name=3D'VIR_KEYCODE_SET_RFB' file=3D'libvirt-domain'> + <macro name=3D'VIR_KEYCODE_SET_RFB' file=3D'libvirt-domain' raw=3D'VIR_K= EYCODE_SET_QNUM'> <info><![CDATA[Compatibility alias for VIR_KEYCODE_SET_QNUM, which rep= laced it since 4.2.0.]]></info> </macro> <macro name=3D'VIR_MIGRATE_PARAM_AUTO_CONVERGE_INCREMENT' file=3D'libvir= t-domain' string=3D'auto_converge.increment'> @@ -2658,7 +2658,7 @@ <macro name=3D'VIR_MIGRATE_PARAM_URI' file=3D'libvirt-domain' string=3D'= migrate_uri'> <info><![CDATA[virDomainMigrate* params field: URI to use for initiati= ng domain migration as VIR_TYPED_PARAM_STRING. It takes a hypervisor specific= format. The uri_transports element of the hypervisor capabilities XML includ= es details of the supported URI schemes. When omitted libvirt will auto-gener= ate suitable default URI. It is typically only necessary to specify this URI = if the destination host has multiple interfaces and a specific interface is r= equired to transmit migration data. This field may not be used when VIR_MIGR= ATE_TUNNELLED flag is set.]]></info> </macro> - <macro name=3D'VIR_NETWORK_EVENT_CALLBACK' file=3D'libvirt-network'> + <macro name=3D'VIR_NETWORK_EVENT_CALLBACK' file=3D'libvirt-network' para= ms=3D'cb' raw=3D''> <info><![CDATA[Used to cast the event specific callback into the gener= ic one for use for virConnectNetworkEventRegisterAny()]]></info> </macro> <macro name=3D'VIR_NETWORK_PORT_BANDWIDTH_IN_AVERAGE' file=3D'libvirt-ne= twork' string=3D'inbound.average'> @@ -2682,11 +2682,11 @@ <macro name=3D'VIR_NETWORK_PORT_BANDWIDTH_OUT_PEAK' file=3D'libvirt-netw= ork' string=3D'outbound.peak'> <info><![CDATA[Macro represents the outbound peak of NIC bandwidth, as= a uint.]]></info> </macro> - <macro name=3D'VIR_NODEINFO_MAXCPUS' file=3D'libvirt-host'> + <macro name=3D'VIR_NODEINFO_MAXCPUS' file=3D'libvirt-host' params=3D'nod= einfo' raw=3D''> <info><![CDATA[This macro is to calculate the total number of CPUs sup= ported but not necessary active in the host.]]></info> <arg name=3D'nodeinfo' info=3D'virNodeInfo instance'/> </macro> - <macro name=3D'VIR_NODE_CPU_STATS_FIELD_LENGTH' file=3D'libvirt-host'> + <macro name=3D'VIR_NODE_CPU_STATS_FIELD_LENGTH' file=3D'libvirt-host' ra= w=3D'80'> <info><![CDATA[Macro providing the field length of virNodeCPUStats]]><= /info> </macro> <macro name=3D'VIR_NODE_CPU_STATS_IDLE' file=3D'libvirt-host' string=3D'= idle'> @@ -2707,7 +2707,7 @@ <macro name=3D'VIR_NODE_CPU_STATS_UTILIZATION' file=3D'libvirt-host' str= ing=3D'utilization'> <info><![CDATA[The CPU utilization of a node. The usage value is in pe= rcent and 100% represents all CPUs of the node.]]></info> </macro> - <macro name=3D'VIR_NODE_DEVICE_EVENT_CALLBACK' file=3D'libvirt-nodedev'> + <macro name=3D'VIR_NODE_DEVICE_EVENT_CALLBACK' file=3D'libvirt-nodedev' = params=3D'cb' raw=3D'((virConnectNodeDeviceEventGenericCallback)(cb))'> <info><![CDATA[Used to cast the event specific callback into the gener= ic one for use for virConnectNodeDeviceEventRegisterAny()]]></info> </macro> <macro name=3D'VIR_NODE_MEMORY_SHARED_FULL_SCANS' file=3D'libvirt-host' = string=3D'shm_full_scans'> @@ -2740,7 +2740,7 @@ <macro name=3D'VIR_NODE_MEMORY_STATS_CACHED' file=3D'libvirt-host' strin= g=3D'cached'> <info><![CDATA[Macro for the cached memory: On Linux, it is only retur= ned in case of VIR_NODE_MEMORY_STATS_ALL_CELLS.]]></info> </macro> - <macro name=3D'VIR_NODE_MEMORY_STATS_FIELD_LENGTH' file=3D'libvirt-host'> + <macro name=3D'VIR_NODE_MEMORY_STATS_FIELD_LENGTH' file=3D'libvirt-host'= raw=3D'80'> <info><![CDATA[Macro providing the field length of virNodeMemoryStats]= ]></info> </macro> <macro name=3D'VIR_NODE_MEMORY_STATS_FREE' file=3D'libvirt-host' string= =3D'free'> @@ -2827,45 +2827,45 @@ <macro name=3D'VIR_PERF_PARAM_TASK_CLOCK' file=3D'libvirt-domain' string= =3D'task_clock'> <info><![CDATA[Macro for typed parameter name that represents task_clo= ck perf event which can be used to measure the count of task clock time by ap= plications running on the platform. It corresponds to the "perf.task_clock" f= ield in the *Stats APIs.]]></info> </macro> - <macro name=3D'VIR_SECRET_EVENT_CALLBACK' file=3D'libvirt-secret'> + <macro name=3D'VIR_SECRET_EVENT_CALLBACK' file=3D'libvirt-secret' params= =3D'cb' raw=3D'((virConnectSecretEventGenericCallback)(cb))'> <info><![CDATA[Used to cast the event specific callback into the gener= ic one for use for virConnectSecretEventRegisterAny()]]></info> </macro> - <macro name=3D'VIR_SECURITY_DOI_BUFLEN' file=3D'libvirt-host'> + <macro name=3D'VIR_SECURITY_DOI_BUFLEN' file=3D'libvirt-host' raw=3D'(25= 6 + 1)'> <info><![CDATA[Macro providing the maximum length of the virSecurityMo= del doi string.]]></info> </macro> - <macro name=3D'VIR_SECURITY_LABEL_BUFLEN' file=3D'libvirt-host'> + <macro name=3D'VIR_SECURITY_LABEL_BUFLEN' file=3D'libvirt-host' raw=3D'(= 4096 + 1)'> <info><![CDATA[Macro providing the maximum length of the virSecurityLa= bel label string. Note that this value is based on that used by Labeled NFS.]= ]></info> </macro> - <macro name=3D'VIR_SECURITY_MODEL_BUFLEN' file=3D'libvirt-host'> + <macro name=3D'VIR_SECURITY_MODEL_BUFLEN' file=3D'libvirt-host' raw=3D'(= 256 + 1)'> <info><![CDATA[Macro providing the maximum length of the virSecurityMo= del model string.]]></info> </macro> - <macro name=3D'VIR_STORAGE_POOL_EVENT_CALLBACK' file=3D'libvirt-storage'> + <macro name=3D'VIR_STORAGE_POOL_EVENT_CALLBACK' file=3D'libvirt-storage'= params=3D'cb' raw=3D'((virConnectStoragePoolEventGenericCallback)(cb))'> <info><![CDATA[Used to cast the event specific callback into the gener= ic one for use for virConnectStoragePoolEventRegisterAny()]]></info> </macro> - <macro name=3D'VIR_TYPED_PARAM_FIELD_LENGTH' file=3D'libvirt-common'> + <macro name=3D'VIR_TYPED_PARAM_FIELD_LENGTH' file=3D'libvirt-common' raw= =3D'80'> <info><![CDATA[Macro providing the field length of virTypedParameter n= ame]]></info> </macro> - <macro name=3D'VIR_UNUSE_CPU' file=3D'libvirt-domain'> + <macro name=3D'VIR_UNUSE_CPU' file=3D'libvirt-domain' params=3D'cpumap,c= pu' raw=3D'((cpumap)[(cpu) / 8] &=3D ~(1 << ((cpu) % 8)))'> <info><![CDATA[This macro is to be used in conjunction with virDomainP= inVcpu() API. It resets the bit (CPU not usable) of the related cpu in cpumap= .]]></info> <arg name=3D'cpumap' info=3D'pointer to a bit map of real CPUs (in 8-b= it bytes) (IN/OUT)'/> <arg name=3D'cpu' info=3D'the physical CPU number'/> </macro> - <macro name=3D'VIR_USE_CPU' file=3D'libvirt-domain'> + <macro name=3D'VIR_USE_CPU' file=3D'libvirt-domain' params=3D'cpumap,cpu= ' raw=3D'((cpumap)[(cpu) / 8] |=3D (1 << ((cpu) % 8)))'> <info><![CDATA[This macro is to be used in conjunction with virDomainP= inVcpu() API. It sets the bit (CPU usable) of the related cpu in cpumap.]]></= info> <arg name=3D'cpumap' info=3D'pointer to a bit map of real CPUs (in 8-b= it bytes) (IN/OUT)'/> <arg name=3D'cpu' info=3D'the physical CPU number'/> </macro> - <macro name=3D'VIR_UUID_BUFLEN' file=3D'libvirt-host'> + <macro name=3D'VIR_UUID_BUFLEN' file=3D'libvirt-host' raw=3D'(16)'> <info><![CDATA[This macro provides the length of the buffer required f= or virDomainGetUUID()]]></info> </macro> - <macro name=3D'VIR_UUID_STRING_BUFLEN' file=3D'libvirt-host'> + <macro name=3D'VIR_UUID_STRING_BUFLEN' file=3D'libvirt-host' raw=3D'(36+= 1)'> <info><![CDATA[This macro provides the length of the buffer required f= or virDomainGetUUIDString()]]></info> </macro> - <macro name=3D'_virBlkioParameter' file=3D'libvirt-domain'> + <macro name=3D'_virBlkioParameter' file=3D'libvirt-domain' raw=3D'_virTy= pedParameter'> </macro> - <macro name=3D'_virMemoryParameter' file=3D'libvirt-domain'> + <macro name=3D'_virMemoryParameter' file=3D'libvirt-domain' raw=3D'_virT= ypedParameter'> </macro> - <macro name=3D'_virSchedParameter' file=3D'libvirt-domain'> + <macro name=3D'_virSchedParameter' file=3D'libvirt-domain' raw=3D'_virTy= pedParameter'> </macro> <enum name=3D'VIR_CONNECT_BASELINE_CPU_EXPAND_FEATURES' file=3D'libvirt-= host' value=3D'1' value_hex=3D'0x1' value_bitshift=3D'0' type=3D'virConnectBa= selineCPUFlags' info=3D'show all features'/> <enum name=3D'VIR_CONNECT_BASELINE_CPU_MIGRATABLE' file=3D'libvirt-host'= value=3D'2' value_hex=3D'0x2' value_bitshift=3D'1' type=3D'virConnectBaselin= eCPUFlags' info=3D'filter out non-migratable features'/> Daniel P. Berrang=C3=A9 (4): scripts: use UTF-8 for API XML files scripts: fix tokenizing of enum parameters in API builder scripts: emit enum parameters in API build description scripts: emit raw enum value in API build description scripts/apibuild.py | 47 ++++++++++++++++++++++++++++++++++++++------- 1 file changed, 40 insertions(+), 7 deletions(-) --=20 2.26.2

2 9

[PATCH] testCompareXMLToArgvValidateSchema: Construct @vm from scratch
by Michal Privoznik 22 May '20

22 May '20

Currently, the @vm is passed in as an argument and testCompareXMLToArgvCreateArgs() is called over it which means under the hood qemuProcessPrepareDomain() is called. But at the point where ValidateSchema() is called, the domain object is already 'prepared', i.e. all device aliases are assigned and so on. But our code is not prepared to 'prepare' a domain twice - it simply overwrites all the pointers leading to a memory leak. Fortunately, this is only the problem of this test. Resolve this by constructing the domain object from scratch. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tests/qemuxml2argvtest.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 4f613e8f1a..3103cac884 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -482,16 +482,17 @@ testCompareXMLToArgvCreateArgs(virQEMUDriverPtr drv, static int testCompareXMLToArgvValidateSchema(virQEMUDriverPtr drv, - virDomainObjPtr vm, const char *migrateURI, struct testQemuInfo *info, unsigned int flags) { VIR_AUTOSTRINGLIST args = NULL; + g_autoptr(virDomainObj) vm = NULL; size_t nargs = 0; size_t i; g_autoptr(virHashTable) schema = NULL; g_autoptr(virCommand) cmd = NULL; + unsigned int parseFlags = info->parseFlags; if (info->schemafile) schema = testQEMUSchemaLoad(info->schemafile); @@ -504,6 +505,15 @@ testCompareXMLToArgvValidateSchema(virQEMUDriverPtr drv, if (!schema) return 0; + if (!(vm = virDomainObjNew(driver.xmlopt))) + return -1; + + parseFlags |= VIR_DOMAIN_DEF_PARSE_INACTIVE; + if (!(vm->def = virDomainDefParseFile(info->infile, + driver.xmlopt, + NULL, parseFlags))) + return -1; + if (!(cmd = testCompareXMLToArgvCreateArgs(drv, vm, migrateURI, info, flags, true))) return -1; @@ -651,7 +661,7 @@ testCompareXMLToArgv(const void *data) goto cleanup; } - if (testCompareXMLToArgvValidateSchema(&driver, vm, migrateURI, info, flags) < 0) + if (testCompareXMLToArgvValidateSchema(&driver, migrateURI, info, flags) < 0) goto cleanup; if (!(actualargv = virCommandToString(cmd, false))) -- 2.26.2

2 1

[libvirt PATCH 0/6] src: make virObject inherit from GObject
by Daniel P. Berrangé 21 May '20

21 May '20

This series attempts to make the conversion from virObject to GObject less dangerous, by making the former inherit from the latter. The way we setup inheritance with virObject means we have to make some moderately gross games with registering virClass instances as GObjectClass instances. Empirically it seems to work and pass the basic TCK test suite. Ultimately virObject should be deleted entirely, so the gross bits shouldn't live too long. Daniel P. Berrangé (6): qemu: stop checking virObjectUnref return value src: make virObjectUnref return void test: allocate numa cells separately from driver src: don't include ref count in debug messages / probes src: don't use VIR_FREE on an object allocation src: make virObject inherit from GObject src/admin/libvirt-admin.c | 7 +- src/datatypes.c | 26 ++++ src/datatypes.h | 6 + src/interface/interface_backend_netcf.c | 7 +- src/libvirt-domain-checkpoint.c | 3 +- src/libvirt-domain-snapshot.c | 3 +- src/libvirt-domain.c | 2 +- src/libvirt-host.c | 2 +- src/libvirt-interface.c | 2 +- src/libvirt-network.c | 6 +- src/libvirt-nodedev.c | 2 +- src/libvirt-nwfilter.c | 6 +- src/libvirt-secret.c | 3 +- src/libvirt-storage.c | 4 +- src/libvirt-stream.c | 3 +- src/libvirt.c | 4 +- src/libvirt_qemu_probes.d | 8 +- src/qemu/qemu_domain.c | 4 +- src/qemu/qemu_monitor.c | 21 +++- src/qemu/qemu_monitor.h | 3 + src/qemu/qemu_process.c | 30 ++--- src/rpc/virnettlscontext.c | 5 +- src/test/test_driver.c | 15 ++- src/util/virfdstream.c | 6 +- src/util/virobject.c | 150 ++++++++++++++---------- src/util/virobject.h | 27 ++--- src/vbox/vbox_common.c | 10 +- 27 files changed, 210 insertions(+), 155 deletions(-) -- 2.24.1

3 9

[PATCH v2 00/13] audio: deprecate -soundhw
by Gerd Hoffmann 21 May '20

21 May '20

v2: - use g_assert_not_reached() for stubs. - add deprecation notice. Gerd Hoffmann (13): stubs: add isa_create_simple stubs: add pci_create_simple audio: add deprecated_register_soundhw audio: deprecate -soundhw ac97 audio: deprecate -soundhw es1370 audio: deprecate -soundhw adlib audio: deprecate -soundhw cs4231a audio: deprecate -soundhw gus audio: deprecate -soundhw sb16 audio: deprecate -soundhw hda audio: deprecate -soundhw pcspk audio: add soundhw deprecation notice [RFC] audio: try use onboard audiodev for pcspk include/hw/audio/soundhw.h | 2 ++ hw/audio/ac97.c | 9 ++------- hw/audio/adlib.c | 8 +------- hw/audio/cs4231a.c | 8 +------- hw/audio/es1370.c | 9 ++------- hw/audio/gus.c | 8 +------- hw/audio/intel-hda.c | 3 +++ hw/audio/pcspk.c | 27 ++++++++++++++++++++++++--- hw/audio/sb16.c | 9 ++------- hw/audio/soundhw.c | 24 +++++++++++++++++++++++- qdev-monitor.c | 2 ++ stubs/isa-bus.c | 7 +++++++ stubs/pci-bus.c | 7 +++++++ docs/system/deprecated.rst | 9 +++++++++ stubs/Makefile.objs | 2 ++ 15 files changed, 88 insertions(+), 46 deletions(-) create mode 100644 stubs/isa-bus.c create mode 100644 stubs/pci-bus.c -- 2.18.4

5 23

[PATCH v4 00/10] Introducing TPM Proxy device support for PPC64
by Daniel Henrique Barboza 21 May '20

21 May '20

changes in v4: - patch 1: added missing <code> tags - comma-escaped the path string in qemu_command.c (patch 8) - moved validations not-XML-parsing related from domain_conf.c to qemu_validate.c - new patches 3 and 4: cleanups - patch 5 (former 3): changed the approach to use a def->tpms array instead of def->tpmproxy pointer - new patch 6: qemu_validate changes to not clog patch 5 with changes - added Jano's and Stefan's r-b when applicable v3 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00642.html v2 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00604.html v1 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00604.html Daniel Henrique Barboza (10): docs: documentation and schema for the new TPM Proxy model qemu: Extend QEMU capabilities with 'spapr-tpm-proxy' qemu_extdevice.c: remove unneeded 'ret' variable qemu_tpm, security, tests: change 'switch' clauses for 'if' conf, qemu, security, tests: introducing 'def->tpms' array qemu_validate.c: add validation for TPM Proxy model tests: add XML schema tests for the TPM Proxy device qemu: build command line for the TPM Proxy device tests/qemuxml2argvtest.c: add TPM Proxy command line tests docs/news.xml: update for the new TPM Proxy device docs/formatdomain.html.in | 19 ++++- docs/news.xml | 17 +++++ docs/schemas/domaincommon.rng | 1 + src/conf/domain_audit.c | 4 +- src/conf/domain_conf.c | 72 +++++++++++++----- src/conf/domain_conf.h | 6 +- src/qemu/qemu_alias.c | 9 ++- src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_cgroup.c | 10 ++- src/qemu/qemu_command.c | 59 +++++++++++--- src/qemu/qemu_domain.c | 31 +++++--- src/qemu/qemu_domain_address.c | 11 ++- src/qemu/qemu_extdevice.c | 24 +++--- src/qemu/qemu_tpm.c | 76 +++++++++---------- src/qemu/qemu_validate.c | 19 +++++ src/security/security_dac.c | 8 +- src/security/security_selinux.c | 44 +++++------ src/security/virt-aa-helper.c | 14 ++-- .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 + tests/qemuxml2argvdata/ppc64-tpm-double.xml | 34 +++++++++ .../ppc64-tpmproxy-double.xml | 38 ++++++++++ .../ppc64-tpmproxy-single.ppc64-latest.args | 34 +++++++++ .../ppc64-tpmproxy-single.xml | 33 ++++++++ .../ppc64-tpmproxy-with-tpm.ppc64-latest.args | 37 +++++++++ .../ppc64-tpmproxy-with-tpm.xml | 36 +++++++++ tests/qemuxml2argvtest.c | 33 +++++--- .../ppc64-tpmproxy-single.ppc64-latest.xml | 42 ++++++++++ .../ppc64-tpmproxy-with-tpm.ppc64-latest.xml | 46 +++++++++++ tests/qemuxml2xmltest.c | 2 + 31 files changed, 616 insertions(+), 152 deletions(-) create mode 100644 tests/qemuxml2argvdata/ppc64-tpm-double.xml create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-double.xml create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-single.ppc64-latest.args create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-single.xml create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-with-tpm.ppc64-latest.args create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-with-tpm.xml create mode 100644 tests/qemuxml2xmloutdata/ppc64-tpmproxy-single.ppc64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/ppc64-tpmproxy-with-tpm.ppc64-latest.xml -- 2.26.2

2 12

[PATCH v2 0/2] introduces qemu_job_wait_time option
by MIKI Nobuhiro 21 May '20

21 May '20

This series introduces qemu_job_wait_time option to configuration file. MIKI Nobuhiro (2): conf: Add qemu_job_wait_time option news: add support for qemu_job_wait_time configuration docs/news.xml | 9 +++++++++ src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf | 3 +++ src/qemu/qemu_conf.c | 3 +++ src/qemu/qemu_conf.h | 2 ++ src/qemu/qemu_domain.c | 7 ++----- src/qemu/test_libvirtd_qemu.aug.in | 1 + 7 files changed, 21 insertions(+), 5 deletions(-) -- 1.8.3.1

2 4

[PATCH v3 00/21] PCI Multifunction hotplug/unplug support
by Daniel Henrique Barboza 20 May '20

20 May '20

This is the v3 of the same support sent to the mailing list a few months ago. No major changes were made. Refer to the v2 cover letter for a general view of the design used across the patches. Changes in v3: - rebase to master at d265171b5784 - minor typo fixes link to v2: https://www.redhat.com/archives/libvir-list/2020-January/msg01377.html link to v1: https://www.redhat.com/archives/libvir-list/2020-January/msg01377.html Daniel Henrique Barboza (4): utils: PCI multifunction detection helpers qemu_hotplug.c: tune unplugTimeout for multifunction detach qemu_hotplug: do not hotplug/hotunplug 'unassigned' hostdevs qemu_hotplug.c: use enhanced multifunction unplug if available Shivaprasad G Bhat (17): qemu: address: Separate the slots into multiple aggregates virhostdev: Introduce virHostdevPCIDevicesBelongToSameSlot qemu: address: Enable auto addressing multifunction cards conf: qemu: validate multifunction hostdevice domain configs conf: Add helper to get active functions of a slot of domain qemu: hostdev: Move the hostdev preparation to a separate function qemu: hotplug: Move the detach of PCI device to the beginning of live hotplug qemu: hotplug: move assignment outside qemuDomainAttachHostPCIDevice Introduce virDomainDeviceDefParseXMLMany Introduce qemuDomainDeviceParseXMLMany qemu: refactor qemuDomain[Attach|Detach]DeviceConfig qemu: refactor qemuDomain[Attach|Detach]DeviceLive qemu: hotplug: Queue and wait for multiple devices domain: addr: Introduce virDomainPCIAddressEnsureMultifunctionAddress qemu: hotplug: Implement multifunction device hotplug qemu: hotplug: Prevent updates to multifunction device qemu: hotplug: Implement multifunction device unplug src/conf/device_conf.h | 7 + src/conf/domain_addr.c | 130 +++++- src/conf/domain_addr.h | 43 +- src/conf/domain_conf.c | 224 ++++++++- src/conf/domain_conf.h | 38 ++ src/hypervisor/virhostdev.c | 29 ++ src/hypervisor/virhostdev.h | 2 + src/libvirt_private.syms | 10 + src/qemu/qemu_domain.c | 75 +++ src/qemu/qemu_domain.h | 21 +- src/qemu/qemu_domain_address.c | 311 ++++++++++++- src/qemu/qemu_domain_address.h | 17 + src/qemu/qemu_driver.c | 243 +++++++--- src/qemu/qemu_hotplug.c | 431 +++++++++++++++--- src/qemu/qemu_hotplug.h | 14 + src/qemu/qemu_validate.c | 56 +++ src/qemu/qemu_validate.h | 1 + src/util/virpci.c | 17 + src/util/virpci.h | 4 + tests/qemuhotplugtest.c | 66 ++- ...emuhotplug-multifunction-hostdev-pci-2.xml | 14 + ...plug-multifunction-hostdev-pci-partial.xml | 27 ++ .../qemuhotplug-multifunction-hostdev-pci.xml | 26 ++ ...live+multifunction-hostdev-pci-partial.xml | 82 ++++ ...ug-base-live+multifunction-hostdev-pci.xml | 82 ++++ ...-base-live+multifunction-hostdev-pci-2.xml | 59 +++ ...es-base-live+multifunction-hostdev-pci.xml | 69 +++ .../hostdev-pci-address-unassigned.args | 9 +- .../hostdev-pci-multifunction.args | 18 +- .../hostdev-pci-multifunction.xml | 8 +- .../hostdev-pci-no-primary-function.xml | 23 + .../hostdev-pci-validate.args | 30 ++ .../qemuxml2argvdata/hostdev-pci-validate.xml | 29 ++ .../qemuxml2argvdata/pseries-hostdevs-1.args | 5 +- .../qemuxml2argvdata/pseries-hostdevs-3.args | 5 +- tests/qemuxml2argvtest.c | 14 +- .../hostdev-pci-address-unassigned.xml | 8 +- .../hostdev-pci-multifunction.xml | 24 +- .../qemuxml2xmloutdata/pseries-hostdevs-1.xml | 4 +- .../qemuxml2xmloutdata/pseries-hostdevs-3.xml | 4 +- tests/virpcitestdata/0005-90-01.1.config | Bin 256 -> 256 bytes tests/virpcitestdata/0005-90-01.2.config | Bin 256 -> 256 bytes tests/virpcitestdata/0005-90-01.3.config | Bin 0 -> 256 bytes 43 files changed, 2022 insertions(+), 257 deletions(-) create mode 100644 tests/qemuhotplugtestdevices/qemuhotplug-multifunction-hostdev-pci-2.xml create mode 100644 tests/qemuhotplugtestdevices/qemuhotplug-multifunction-hostdev-pci-partial.xml create mode 100644 tests/qemuhotplugtestdevices/qemuhotplug-multifunction-hostdev-pci.xml create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-base-live+multifunction-hostdev-pci-partial.xml create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-base-live+multifunction-hostdev-pci.xml create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-pseries-base-live+multifunction-hostdev-pci-2.xml create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-pseries-base-live+multifunction-hostdev-pci.xml create mode 100644 tests/qemuxml2argvdata/hostdev-pci-no-primary-function.xml create mode 100644 tests/qemuxml2argvdata/hostdev-pci-validate.args create mode 100644 tests/qemuxml2argvdata/hostdev-pci-validate.xml create mode 100644 tests/virpcitestdata/0005-90-01.3.config -- 2.26.2

1 21

Exposing -fw_cfg?
by Michal Privoznik 20 May '20

20 May '20

List, QEMU has capability to inject various blobs into firmware that configure how firmware configures itself. However, it can be also used to passthrough a specific file into the guest. For instance: -fw_cfg value=name=opt/com.example,file=/tmp/ign will make the /tmp/ign file accessible in the guest under: /sys/firmware/qemu_fw_cfg/by_name/opt/com.example/raw the @name is important here as it defines what knob is touched. For instance, /opt/ovmf tweaks OVMF, /bootorder changes the boot order, and so on. But, if the @name is in /opt/reverse.fully.qualified.domain form than this is a blob that is exposed into the guest and does not affect ACPI, SMBIOS, ... And IMO this is what makes the interface horrible. While I definitely would not expose the FW configuration knobs (we already provide a way to configure things like bootroder), the file passthrough is actually used. So far I have found out that RHCOS uses it to give the guest so called ignition file (for the sake of argument we can assume it's like a kickstart that the OS reads on the first boot and configures itself up), but there are some other potential users (for users it looks intriguing, it's a simple API that makes a file show up at well defined location inside the guest). Therefore I vouch for exposing the file passthorugh (and definitely do not mention firmware in the element or docs in any way, to not encourage users to use FW tweaking mode). However, before I design something, I'd like to hear your opinion. Michal

3 4

[libvirt PATCH 0/6] Add ability to create mediated devices in libvirt
by Jonathon Jongsma 20 May '20

20 May '20

This is the first portion of an effort to support persistent mediated devices with libvirt. This first series simply enables creating and destroying non-persistent mediated devices via the virNodeDeviceCreateXML() and virNodeDeviceDestroy() functions. The 'mdevctl' utility[1] provides the backend implementation. [1] https://github.com/mdevctl/mdevctl Jonathon Jongsma (6): nodedev: factor out nodeDeviceHasCapability() nodedev: add support for mdev attributes nodedev: refactor nodeDeviceFindNewDevice() nodedev: store mdev UUID in mdev caps nodedev: add mdev support to virNodeDeviceCreateXML() nodedev: add mdev support to virNodeDeviceDestroy() docs/schemas/nodedev.rng | 6 + libvirt.spec.in | 3 + m4/virt-external-programs.m4 | 3 + src/conf/node_device_conf.c | 59 ++++- src/conf/node_device_conf.h | 3 + src/conf/virnodedeviceobj.c | 34 +++ src/conf/virnodedeviceobj.h | 3 + src/libvirt_private.syms | 3 + src/node_device/node_device_driver.c | 326 ++++++++++++++++++++++++--- src/node_device/node_device_udev.c | 5 +- src/util/virmdev.c | 12 + src/util/virmdev.h | 11 + 12 files changed, 425 insertions(+), 43 deletions(-) -- 2.21.1

4 19

[PATCH trivial v2 1/1] logging.html.in: fix number of output formats available
by Daniel Henrique Barboza 20 May '20

20 May '20

There are 4 formats available (x:stderr, x:syslog:name, x:file:file_path, x:journald), not 3. Use "the following" instead of the actual number to avoid the need to update the number every time a new form is added/removed. Suggested-by: Pino Toscano <ptoscano(a)redhat.com> Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com> --- docs/logging.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/logging.html.in b/docs/logging.html.in index 65c13e8a19..3ff0dd3eb6 100644 --- a/docs/logging.html.in +++ b/docs/logging.html.in @@ -124,7 +124,7 @@ x:name</pre> priority level, messages that match that filter will still be logged, while others will not. In order to see those messages, you must also have an output defined that includes the priority level of your filter.</p> - <p>The format for an output can be one of those 3 forms:</p> + <p>The format for an output can be one of the following forms:</p> <ul> <li><code>x:stderr</code> output goes to stderr</li> <li><code>x:syslog:name</code> use syslog for the output and use the -- 2.26.2

2 1

[PATCH 0/3] qemu: Emit an event on lease attach/detach
by Michal Privoznik 20 May '20

20 May '20

*** BLURB HERE *** Michal Prívozník (3): qemuDomainAttachDeviceLive: Rework event emitting Introduce VIR_DOMAIN_EVENT_ID_LEASE_CHANGE qemu: Emit an event on lease attach/detach examples/c/misc/event-test.c | 37 ++++++++++ include/libvirt/libvirt-domain.h | 37 ++++++++++ src/conf/domain_event.c | 100 ++++++++++++++++++++++++++++ src/conf/domain_event.h | 16 +++++ src/libvirt_private.syms | 2 + src/qemu/qemu_driver.c | 45 +++++++------ src/qemu/qemu_hotplug.c | 9 +++ src/remote/remote_daemon_dispatch.c | 37 ++++++++++ src/remote/remote_driver.c | 34 ++++++++++ src/remote/remote_protocol.x | 18 ++++- src/remote_protocol-structs | 8 +++ tools/virsh-domain.c | 34 ++++++++++ 12 files changed, 355 insertions(+), 22 deletions(-) -- 2.26.2

1 3

[PATCH trivial 1/1] logging.html.in: fix number of output formats available
by Daniel Henrique Barboza 19 May '20

19 May '20

There are 4 formats available (x:stderr, x:syslog:name, x:file:file_path, x:journald), not 3. Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com> --- docs/logging.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/logging.html.in b/docs/logging.html.in index 65c13e8a19..9f320b439e 100644 --- a/docs/logging.html.in +++ b/docs/logging.html.in @@ -124,7 +124,7 @@ x:name</pre> priority level, messages that match that filter will still be logged, while others will not. In order to see those messages, you must also have an output defined that includes the priority level of your filter.</p> - <p>The format for an output can be one of those 3 forms:</p> + <p>The format for an output can be one of those 4 forms:</p> <ul> <li><code>x:stderr</code> output goes to stderr</li> <li><code>x:syslog:name</code> use syslog for the output and use the -- 2.26.2

2 2

Re: Question: How do I discard any changes for the device which is set by blockdev option?
by Eric Blake 19 May '20

19 May '20

On 5/19/20 12:56 PM, Masayoshi Mizuma wrote: > Hello, > > I would like to discard any changes while the qemu guest OS is done. > I can do that with snapshot and drive option. > However, snapshot option doesn't work for the device which set by > blockdev option like as: > > $QEMU --enable-kvm \ > -m 1024 \ > -nographic \ > -serial mon:stdio \ > -blockdev driver=file,node-name=mydisk,filename=/mnt/fedora.qcow2 \ > -blockdev driver=qcow2,node-name=vda,file=mydisk \ > -device virtio-blk-pci,drive=vda,bootindex=1 \ > -snapshot > > I would like to use blockdev option to set the device because > libvirt uses blockdev option for disk element. > > If there's no way to do so, does that make sense to get available > snapshot option to blockdev as well? If that makes sense, I'll try to > implement that. > > As for qcow2, I think we can do such things to use qemu-img snapshot > command, for example save the original image and restore the image > after the qemu guest OS is shutdowned. However, it may be complecated > for user. I would like the simple way like as snapshot/drive option... > > If I'm missing something, let me know. > Sounds like a repeat of this thread: https://lists.gnu.org/archive/html/qemu-devel/2020-01/msg06144.html where the consensus is yes, -blockdev and -snapshot are incompatible, libvirt has plans to use the <transient/> tag to behave the same as what -snapshot does (but no one has implemented it yet), and in the meantime, it is possible to force libvirt to avoid -blockdev if you still need to supply -snapshot behind libvirt's back. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

2 1

[PATCH 00/15] tests: qemu: Detect deprecation in the QMP schema (deprecation part 1)
by Peter Krempa 19 May '20

19 May '20

Recent qemu versions started adding the 'deprecated' feature to commands and fields. Use this data to validate that our code doesn't rely on deprecated commands. It turns out that we still use some old migration commands (See 14/15) and add validator to catch anything deprecated early. Peter Krempa (15): testQemuHotplugCpuPrepare: Allow unused monitor commands only on failure testutilsqemuschema: Introduce testQEMUSchemaValidateCommand qemuMonitorTestProcessCommandDefaultValidate: Use testQEMUSchemaValidateCommand qemuMonitorTestProcessCommandDefaultValidate: Clean up return value use qemumonitortestutils: Introduce qemuMonitorTestSkipDeprecatedValidation testutilsqemuschema: Use automatic variable clearing where possible testutilsqemuschema: Pass in 'schema' and 'debug' variables to workers in a struct testQEMUSchemaValidate(Command): Allow skipping validation of deprecated fields testQemuHotplugCpuPrepare: Allow deprecated commands for non-modern cpu hotplug test qemumonitorjsontest: Add infrastructure for generated tests of deprecated commands testQemuMonitorJSONqemuMonitorJSONQueryCPUs: Split off test for query-cpus-fast qemumonitorjsontest: Allow use of deprecated 'query-cpus' qemumonitorjsontest: Allow use of deprecated 'cpu-add' and 'change' command qemumonitorjsontest: Mark recently deprecated migration command in our tests testQEMUSchemaValidate*: Reject usage of fields with 'deprecated' set tests/qemublocktest.c | 14 +- tests/qemuhotplugtest.c | 11 +- tests/qemumonitorjsontest.c | 67 +++++-- tests/qemumonitortestutils.c | 66 ++++--- tests/qemumonitortestutils.h | 2 + tests/testutilsqemuschema.c | 334 ++++++++++++++++++++++------------- tests/testutilsqemuschema.h | 9 + 7 files changed, 325 insertions(+), 178 deletions(-) -- 2.26.2

2 30

[PATCH] qemu: do not allow /dev/rtc or /dev/hpet access via the devices cgroup
by Paolo Bonzini 19 May '20

19 May '20

The RTC and HPET modes for the QEMU emulation tick have been dropped almost 9 years ago, in commit 25f3151ece1d5881826232bebccc21b588d4e03e. Do not allow them in the devices cgroup policy. Signed-off-by: Paolo Bonzini <pbonzini(a)redhat.com> --- docs/drvqemu.html.in | 1 - src/qemu/qemu.conf | 1 - src/qemu/qemu_cgroup.c | 1 - src/qemu/test_libvirtd_qemu.aug.in | 2 -- 4 files changed, 5 deletions(-) diff --git a/docs/drvqemu.html.in b/docs/drvqemu.html.in index afc4ddf56d..b6d731bb59 100644 --- a/docs/drvqemu.html.in +++ b/docs/drvqemu.html.in @@ -484,7 +484,6 @@ chmod o+x /path/to/directory /dev/null, /dev/full, /dev/zero, /dev/random, /dev/urandom, /dev/ptmx, /dev/kvm, -/dev/rtc, /dev/hpet </pre> <p> diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf index abdbf07fec..d7a3f40e78 100644 --- a/src/qemu/qemu.conf +++ b/src/qemu/qemu.conf @@ -495,7 +495,6 @@ # "/dev/null", "/dev/full", "/dev/zero", # "/dev/random", "/dev/urandom", # "/dev/ptmx", "/dev/kvm", -# "/dev/rtc","/dev/hpet" #] # # RDMA migration requires the following extra files to be added to the list: diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 2e019b64af..d92202f847 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -47,7 +47,6 @@ const char *const defaultDeviceACL[] = { "/dev/null", "/dev/full", "/dev/zero", "/dev/random", "/dev/urandom", "/dev/ptmx", "/dev/kvm", - "/dev/rtc", "/dev/hpet", NULL, }; #define DEVICE_PTY_MAJOR 136 diff --git a/src/qemu/test_libvirtd_qemu.aug.in b/src/qemu/test_libvirtd_qemu.aug.in index 19da591aae..e533b9f551 100644 --- a/src/qemu/test_libvirtd_qemu.aug.in +++ b/src/qemu/test_libvirtd_qemu.aug.in @@ -61,8 +61,6 @@ module Test_libvirtd_qemu = { "5" = "/dev/urandom" } { "6" = "/dev/ptmx" } { "7" = "/dev/kvm" } - { "8" = "/dev/rtc" } - { "9" = "/dev/hpet" } } { "save_image_format" = "raw" } { "dump_image_format" = "raw" } -- 2.25.4

3 4

[PATCH v2] README.rst: Replace the installation instructions with link to compiling.html.
by Yi Wang 19 May '20

19 May '20

From: Liao Pingfang <liao.pingfang(a)zte.com.cn> Remove the installation instructions from README.rst, and add the link to compiling.html. Signed-off-by: Liao Pingfang <liao.pingfang(a)zte.com.cn> --- Changes in v2: use compiling.html replace the installation instructions README.rst | 26 ++------------------------ 1 file changed, 2 insertions(+), 24 deletions(-) diff --git a/README.rst b/README.rst index cdcc97b..5d6ca55 100644 --- a/README.rst +++ b/README.rst @@ -45,31 +45,9 @@ and ``COPYING`` for full license terms & conditions. Installation ============ -Libvirt uses the GNU Autotools build system, so in general can be built -and installed with the usual commands, however, we mandate to have the -build directory different than the source directory. For example, to build -in a manner that is suitable for installing as root, use: - -:: - - $ mkdir build && cd build - $ ../configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var - $ make - $ sudo make install - -While to build & install as an unprivileged user - -:: - - $ mkdir build && cd build - $ ../configure --prefix=$HOME/usr - $ make - $ make install - -The libvirt code relies on a large number of 3rd party libraries. These will -be detected during execution of the ``configure`` script and a summary printed -which lists any missing (optional) dependencies. +Instructions on building and installing libvirt can be found on the website: +https://libvirt.org/compiling.html Contributing ============ -- 2.9.5

2 1

[libvirt PATCH] qemu: conf: fix stray comma
by Ján Tomko 19 May '20

19 May '20

The qemu.conf change broke our augeas test: qemu/test_libvirtd_qemu.aug:96.3-203.1:exception thrown in test qemu/test_libvirtd_qemu.aug:96.8-.34:exception: Iterated lens matched less than it should Lens: ../../src/qemu/libvirtd_qemu.aug:170.13-.43: Last match: ../../src/qemu/libvirtd_qemu.aug:18.52-.113: Not matching: ../../src/qemu/libvirtd_qemu.aug:12.19-.31: Error encountered at 48:27 (1615 characters into string) <\n "/dev/ptmx", "/dev/kvm"|=|,\n]\nsave_image_format = "raw> Fixes: ab5ba57012e9e6ab4f55afdeecd1813dd3ca916b Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed as a trivial build fix src/qemu/qemu.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf index d7a3f40e78..404961c53e 100644 --- a/src/qemu/qemu.conf +++ b/src/qemu/qemu.conf @@ -494,7 +494,7 @@ #cgroup_device_acl = [ # "/dev/null", "/dev/full", "/dev/zero", # "/dev/random", "/dev/urandom", -# "/dev/ptmx", "/dev/kvm", +# "/dev/ptmx", "/dev/kvm" #] # # RDMA migration requires the following extra files to be added to the list: -- 2.25.4

1 0

[PATCH 0/2] Introduce GitLab CI and merge requests
by Daniel P. Berrangé 18 May '20

18 May '20

In v2: - Use ubuntu for publishing pages build Daniel P. Berrangé (2): gitlab: introduce CI jobs for building content gitlab: add CONTRIBUTING.rst file to indicate use of merge requests .gitlab-ci.yml | 126 +++++++++++++++++++++++++++ .gitpublish | 4 - CONTRIBUTING.rst | 28 ++++++ Makefile | 7 +- ci/libvirt-centos-7.Dockerfile | 83 ++++++++++++++++++ ci/libvirt-debian-10.Dockerfile | 53 +++++++++++ ci/libvirt-debian-9.Dockerfile | 56 ++++++++++++ ci/libvirt-debian-sid.Dockerfile | 53 +++++++++++ ci/libvirt-fedora-31.Dockerfile | 50 +++++++++++ ci/libvirt-fedora-32.Dockerfile | 50 +++++++++++ ci/libvirt-fedora-rawhide.Dockerfile | 51 +++++++++++ ci/libvirt-ubuntu-1804.Dockerfile | 56 ++++++++++++ ci/libvirt-ubuntu-2004.Dockerfile | 53 +++++++++++ ci/refresh | 22 +++++ 14 files changed, 685 insertions(+), 7 deletions(-) delete mode 100644 .gitpublish create mode 100644 CONTRIBUTING.rst create mode 100644 ci/libvirt-centos-7.Dockerfile create mode 100644 ci/libvirt-debian-10.Dockerfile create mode 100644 ci/libvirt-debian-9.Dockerfile create mode 100644 ci/libvirt-debian-sid.Dockerfile create mode 100644 ci/libvirt-fedora-31.Dockerfile create mode 100644 ci/libvirt-fedora-32.Dockerfile create mode 100644 ci/libvirt-fedora-rawhide.Dockerfile create mode 100644 ci/libvirt-ubuntu-1804.Dockerfile create mode 100644 ci/libvirt-ubuntu-2004.Dockerfile create mode 100755 ci/refresh -- 2.26.2

2 5

[PATCH 00/21] Fix compatibility with netdev-add in qemu-5.0
by Peter Krempa 18 May '20

18 May '20

This is based on top of tests: qemu: Detect deprecation in the QMP schema (deprecation part 1) https://www.redhat.com/archives/libvir-list/2020-April/msg01444.html Both can be fetched at: git fetch https://gitlab.com/pipo.sk/libvirt.git netdev_add-validate QEMU-5.0 released a fully QAPIfied 'netdev_add' command. Since we didn't format the arguments in a way qemu now thinks we should do them network device hotplug broke. Fix it by modifying our internals slightly and add some testing. This series also adds schema testing of -blockdev arguments and prepares for a simple addition of schema testing for arguments of -device and -object if qemu ever finishes the qapification of those. Theoretically we can even do it pre-emtptively but it's almost guaranteed to fail at least for -device. I just hope that qemu let's us know in advance as -device will be harder. Note that if the loading of the schema in the tests I've added will be deemed to be slow I'll add caching. Peter Krempa (21): qemu: domain: Forbid unsupported 'tftp' protocol and handle tests qemuMonitorJSONParseKeywords: remove constant argument qemuBuildChannelsCommandLine: Use typecasted switch for channel type qemuBuildChannelsCommandLine: Extract common formatting of 'chardev' qemuBuildChannelChrDeviceStr: Remove formatting of properties for -netdev qemuBuildHostNetStr: Stop using 'ipv6-net' convenience argument virQEMUBuildCommandLineJSON: Allow skipping certain keys virQEMUBuildCommandLineJSON: Add possibility for using 'on/off' instead of 'yes/no' virCommand: Introduce virCommandGetArgList util: json: Introduce virJSONValueObjectAppendStringPrintf testCompareXMLToArgv: Split out preparation and command formatting qemuMonitorJSON(Add|Remove)Netdev: Refactor cleanup util: virqemu: Introduce virQEMUBuildNetdevCommandlineFromJSON qemu: command: Generate -netdev command line via JSON->cmdline conversion virQEMUBuildNetdevCommandlineFromJSON: Prepare for quirky 'guestfwd' qemuBuildChannelGuestfwdNetdevProps: Convert to generating JSON props qemuMonitorAddNetdev: Convert to the native JSON props object qemu: Prepare for testing of 'netdev_add' props via qemuxml2argvtest testQEMUSchemaLoad: Rename to testQEMUSchemaLoadLatest testutilsqemuschema: Allow loading non-latest schema qemuxml2argvtest: Add QAPI/QMP schema validation for -blockdev and -netdev src/libvirt_private.syms | 3 + src/qemu/qemu_command.c | 289 +++++++++++------- src/qemu/qemu_command.h | 22 +- src/qemu/qemu_domain.c | 10 + src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_hotplug.c | 31 +- src/qemu/qemu_monitor.c | 8 +- src/qemu/qemu_monitor.h | 2 +- src/qemu/qemu_monitor_json.c | 76 ++--- src/qemu/qemu_monitor_json.h | 2 +- src/qemu/qemu_process.c | 11 +- src/qemu/qemu_process.h | 1 + src/util/vircommand.c | 23 ++ src/util/vircommand.h | 1 + src/util/virjson.c | 17 ++ src/util/virjson.h | 2 + src/util/virqemu.c | 119 +++++++- src/util/virqemu.h | 18 +- tests/Makefile.am | 2 +- tests/qemublocktest.c | 2 +- tests/qemucommandutiltest.c | 2 +- tests/qemuhotplugtest.c | 2 +- tests/qemumonitorjsontest.c | 6 +- .../qemuxml2argvdata/disk-cdrom-network.args | 3 - .../disk-cdrom-network.x86_64-2.12.0.args | 3 - .../disk-cdrom-network.x86_64-latest.args | 17 +- tests/qemuxml2argvdata/disk-cdrom-network.xml | 9 - tests/qemuxml2argvdata/net-user-addr.args | 3 +- tests/qemuxml2argvtest.c | 236 +++++++++----- tests/testutilsqemu.c | 5 + tests/testutilsqemu.h | 1 + tests/testutilsqemuschema.c | 66 ++-- tests/testutilsqemuschema.h | 5 +- 33 files changed, 667 insertions(+), 332 deletions(-) -- 2.26.2

2 43

[libvirt PATCH 0/2] fix a leak in virQEMUDriverConfigLoadMemoryEntry
by Ján Tomko 18 May '20

18 May '20

Thanks to valgrind Ján Tomko (2): qemu: do not leak the directory in virQEMUDriverConfigLoadMemoryEntry qemu: only return two values in virQEMUDriverConfigLoadMemoryEntry src/qemu/qemu_conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.25.4

2 3

[PATCH v2] qemuProcessStop: Reattach NVMe disks a domain is mirroring into
by Michal Privoznik 18 May '20

18 May '20

In v5.10.0-rc1~42 (which was later fixed in v6.0.0-rc1~487) I am removing XATTRs for a file that QEMU is mirroring a disk into but it is killed meanwhile. Well, we can call qemuSecurityRestoreImageLabel() which will not only remove XATTRs but also use them to restore the original owner of the file. Moreover, if the mirror destination is not a file but a NVMe disk, then call qemuHostdevReAttachOneNVMeDisk() to reattach the NVMe back to the host. All of this would be done by blockjob code when the job finishes, but in this case the job won't finish - QEMU is killed meanwhile. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1825785 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- v2 of: https://www.redhat.com/archives/libvir-list/2020-May/msg00210.html diff to v1: - per Peter's review, instead of calling qemuDomainStorageSourceAccessRevoke() call only some functions it would call. src/qemu/qemu_process.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 8ea470f75f..65d51e58c9 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -7604,8 +7604,13 @@ void qemuProcessStop(virQEMUDriverPtr driver, for (i = 0; i < def->ndisks; i++) { virDomainDiskDefPtr disk = def->disks[i]; - if (disk->mirror) - qemuBlockRemoveImageMetadata(driver, vm, disk->dst, disk->mirror); + if (disk->mirror) { + if (qemuSecurityRestoreImageLabel(driver, vm, disk->mirror, false) < 0) + VIR_WARN("Unable to restore security label on %s", disk->dst); + + if (virStorageSourceChainHasNVMe(disk->mirror)) + qemuHostdevReAttachOneNVMeDisk(driver, vm->def->name, disk->mirror); + } qemuBlockRemoveImageMetadata(driver, vm, disk->dst, disk->src); } -- 2.26.2

2 1

[libvirt PATCH v2 00/10] qemu: block: basic implementation of deletion of external snapshots
by Pavel Mores 18 May '20

18 May '20

Deleting external snapshots has been unimplemented so far. This series aims to enable limited functionality in that direction, handling just the common cases for now. The intention is to subsequently build upon this to eventually cover the more complex/exotic cases as well. It works by blockcommitting the snapshot to be deleted into its parent. Handles both deleting children as well and deleting children only (by committing the children into the snapshot referred to by snapshot-delete argument). If the necessary block commit operations turns out to be active (the snapshot referred to by snapshot-delete argument is current, or deleting children is requested) pivot is performed as well. This implemetation is limited to the straightforward case which assumes no branching snapshot chains below the snapshot to be deleted, and the current snapshot has to be the leaf of the (linear) chain starting at the snapshot to be deleted. These requirements are checked and enforced at the top of qemuDomainSnapshotDeleteExternal(). They might even be too restrictive for the case where deletion of children is not requested as in that case, requiring that the parent of the snapshot to be deleted not be a branching point in snapshot tree should be enough. The above limitations do not appear too severe under the current state of matters where a major source of branching snapshot structures, snapshot-revert, is not even implemented for external snapshots yet. The only other known cause of branching in external snapshots thus seems to be if a user creates branching by manually creating snapshot images and metadata and applies them using snapshot-create --redefine. Also, the snapshot images involved basically have to be files. This does not seem overly limiting either, at least for the time being, because it's a limitation shared with the underlying blockcommit code. Just as the existing code, the new code ultimately relies on virStorageFileChainLookup() as its image comparison and look-up engine and is affected by its limitaions. At any rate, this work should be understood as just a first step to a full support of deleting external snapshots. The first 5 commits of this series are just refactors used by the last 5 commits which actually implement snapshot deletion. However, the qemuDomainBlockCommit() refactor (the initial 2 commits of this series) was affected by a rather hairy merge on rebasing to the current master and although I tried to do my best to get the merge right I still feel a careful review is in order for these two commits. Pavel Mores (10): qemu: block: factor implementation out of qemuDomainBlockCommit() qemu: block: refactor blockcommit so that it's callable with storage sources qemu: block: factor implementation out of qemuDomainBlockJobAbort() conf: rename virDomainMomentFindLeaf() to virDomainMomentObjListFindLeaf() conf: add virDomainMomentFindLeaf() which operates on virDomainMomentObjPtr qemu: block: add function to collect blockcommit params and verify them qemu: block: add function to launch all prepared blockcommits qemu: block: add function to wait for blockcommits and collect results qemu: block: add external snapshot-delete top-level algorithm qemu: block: add actual invocation of external snapshot-delete src/conf/virdomaincheckpointobjlist.c | 2 +- src/conf/virdomainmomentobjlist.c | 27 +- src/conf/virdomainmomentobjlist.h | 3 +- src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 552 ++++++++++++++++++++++---- 5 files changed, 485 insertions(+), 100 deletions(-) -- 2.24.1

2 15

[PATCH] RFC: Support network interface downscript
by Chen Hanxiao 18 May '20

18 May '20

https://gitlab.com/libvirt/libvirt/-/issues/13 Add support for downscript: <interface type='ethernet'> <mac address='00:11:22:33:44:55'/> <script path='/etc/qemu-ifup'/> <downscript path='/path/to/my/downscript'/> </interface> But -net ...,script=/etc/qemu-ifup has some limitation: https://github.com/qemu/qemu/blob/035b448b84f3557206abc44d786c5d3db2638f7d/… Maybe virNetDevRunEthernetScript is another choice. Signed-off-by: Chen Hanxiao <chen_han_xiao(a)126.com> --- src/conf/domain_conf.c | 7 +++++++ src/conf/domain_conf.h | 1 + src/qemu/qemu_extdevice.c | 2 ++ 3 files changed, 10 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index c201fc9..5cb39a3 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -2520,6 +2520,7 @@ virDomainNetDefClear(virDomainNetDefPtr def) VIR_FREE(def->teaming.persistent); VIR_FREE(def->virtPortProfile); VIR_FREE(def->script); + VIR_FREE(def->downscript); VIR_FREE(def->domain_name); VIR_FREE(def->ifname); VIR_FREE(def->ifname_guest); @@ -11977,6 +11978,7 @@ virDomainNetDefParseXML(virDomainXMLOptionPtr xmlopt, g_autofree char *ifname_guest = NULL; g_autofree char *ifname_guest_actual = NULL; g_autofree char *script = NULL; + g_autofree char *downscript = NULL; g_autofree char *address = NULL; g_autofree char *port = NULL; g_autofree char *localaddr = NULL; @@ -12149,6 +12151,9 @@ virDomainNetDefParseXML(virDomainXMLOptionPtr xmlopt, } else if (!script && virXMLNodeNameEqual(cur, "script")) { script = virXMLPropString(cur, "path"); + } else if (!downscript && + virXMLNodeNameEqual(cur, "downscript")) { + downscript = virXMLPropString(cur, "path"); } else if (!domain_name && virXMLNodeNameEqual(cur, "backenddomain")) { domain_name = virXMLPropString(cur, "name"); @@ -12482,6 +12487,8 @@ virDomainNetDefParseXML(virDomainXMLOptionPtr xmlopt, if (script != NULL) def->script = g_steal_pointer(&script); + if (downscript != NULL) + def->downscript = g_steal_pointer(&downscript); if (domain_name != NULL) def->domain_name = g_steal_pointer(&domain_name); if (ifname != NULL) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index ddc75d8..e152c59 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -1055,6 +1055,7 @@ struct _virDomainNetDef { unsigned long sndbuf; } tune; char *script; + char *downscript; char *domain_name; /* backend domain name */ char *ifname; /* interface name on the host (<target dev='x'/>) */ int managed_tap; /* enum virTristateBool - ABSENT == YES */ diff --git a/src/qemu/qemu_extdevice.c b/src/qemu/qemu_extdevice.c index 2096272..f8e440a 100644 --- a/src/qemu/qemu_extdevice.c +++ b/src/qemu/qemu_extdevice.c @@ -234,6 +234,8 @@ qemuExtDevicesStop(virQEMUDriverPtr driver, if (slirp) qemuSlirpStop(slirp, vm, driver, net); + if (net->downscript) + virNetDevRunEthernetScript(net->ifname, net->downscript); } for (i = 0; i < def->nfss; i++) { -- 1.8.3.1

2 1

[PATCH] Unlock the storage pool objects after looking it up
by Yi Li 18 May '20

18 May '20

The lock should be released. Signed-off-by: Yi Li <yili(a)winhong.com> --- src/conf/virstorageobj.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/conf/virstorageobj.c b/src/conf/virstorageobj.c index 13b75b648d..9f24ae67ca 100644 --- a/src/conf/virstorageobj.c +++ b/src/conf/virstorageobj.c @@ -2077,8 +2077,10 @@ virStoragePoolObjListExport(virConnectPtr conn, virObjectRWLockRead(poolobjs); - if (pools && VIR_ALLOC_N(data.pools, virHashSize(poolobjs->objs) + 1) < 0) - goto error; + if (pools && VIR_ALLOC_N(data.pools, virHashSize(poolobjs->objs) + 1) < 0) { + virObjectRWUnlock(poolobjs); + return -1; + } virHashForEach(poolobjs->objs, virStoragePoolObjListExportCallback, &data); virObjectRWUnlock(poolobjs); -- 2.25.3

4 5

[PATCH trivial 1/1] qemu_alias.c: fix qemuAssingDeviceMemballoonAlias() typo
by Daniel Henrique Barboza 18 May '20

18 May '20

Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com> --- src/qemu/qemu_alias.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_alias.c b/src/qemu/qemu_alias.c index b0ea62af39..d6527cb046 100644 --- a/src/qemu/qemu_alias.c +++ b/src/qemu/qemu_alias.c @@ -390,7 +390,7 @@ qemuAssignDeviceSmartcardAlias(virDomainSmartcardDefPtr smartcard, static int -qemuAssingDeviceMemballoonAlias(virDomainMemballoonDefPtr memballoon, +qemuAssignDeviceMemballoonAlias(virDomainMemballoonDefPtr memballoon, int idx) { if (memballoon->info.alias) @@ -662,7 +662,7 @@ qemuAssignDeviceAliases(virDomainDefPtr def, virQEMUCapsPtr qemuCaps) } if (def->memballoon && def->memballoon->model != VIR_DOMAIN_MEMBALLOON_MODEL_NONE) { - if (qemuAssingDeviceMemballoonAlias(def->memballoon, 0) < 0) + if (qemuAssignDeviceMemballoonAlias(def->memballoon, 0) < 0) return -1; } for (i = 0; i < def->nrngs; i++) { -- 2.26.2

2 1

[PATCH v3 0/9] Introducing TPM Proxy device support for PPC64
by Daniel Henrique Barboza 16 May '20

16 May '20

changes in v3 after reviews from Stefan Berger: - new patch 4: trivial change to allow g_autoptr() with virDomainTPMDefPtr - patch 5 (former 4): added g_autoptr(), removed VIR_FREE() calls - changed wording in patches 1 and 9 (former 8) to make it clear for users that this new device brings no benefits unless the guest is running on specialized PPC64 hardware - fixed identation in patch 6 (former 5). Added Stefan's r-b v2 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00604.html v1 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00604.html Daniel Henrique Barboza (9): docs: documentation and schema for the new TPM Proxy model qemu: Extend QEMU capabilities with 'spapr-tpm-proxy' conf, qemu: adding 'tpmproxy' in domain definition conf, domain: register AUTOPTR_CLEANUP_FUNC for virDomainTPMDef domain_conf.c: XML parsing for VIR_DOMAIN_TPM_MODEL_SPAPR_PROXY tests: add XML schema tests for the TPM Proxy device qemu: build command line for the TPM Proxy device tests/qemuxml2argvtest.c: add TPM Proxy command line tests docs/news.xml: update for the new TPM Proxy device docs/formatdomain.html.in | 18 +++++- docs/news.xml | 17 +++++ docs/schemas/domaincommon.rng | 1 + src/conf/domain_audit.c | 3 + src/conf/domain_conf.c | 63 +++++++++++++++++-- src/conf/domain_conf.h | 3 + src/qemu/qemu_alias.c | 16 +++++ src/qemu/qemu_capabilities.c | 4 ++ src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_cgroup.c | 12 +++- src/qemu/qemu_command.c | 21 +++++++ src/qemu/qemu_domain.c | 9 +-- src/qemu/qemu_validate.c | 12 ++++ src/security/security_dac.c | 14 +++++ src/security/security_selinux.c | 11 ++++ .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 + tests/qemuxml2argvdata/ppc64-tpm-double.xml | 34 ++++++++++ .../ppc64-tpmproxy-double.xml | 38 +++++++++++ .../ppc64-tpmproxy-single.ppc64-latest.args | 34 ++++++++++ .../ppc64-tpmproxy-single.xml | 33 ++++++++++ .../ppc64-tpmproxy-with-tpm.ppc64-latest.args | 37 +++++++++++ .../ppc64-tpmproxy-with-tpm.xml | 36 +++++++++++ tests/qemuxml2argvtest.c | 15 +++++ .../ppc64-tpmproxy-single.ppc64-latest.xml | 42 +++++++++++++ .../ppc64-tpmproxy-with-tpm.ppc64-latest.xml | 46 ++++++++++++++ tests/qemuxml2xmltest.c | 2 + 27 files changed, 514 insertions(+), 12 deletions(-) create mode 100644 tests/qemuxml2argvdata/ppc64-tpm-double.xml create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-double.xml create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-single.ppc64-latest.args create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-single.xml create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-with-tpm.ppc64-latest.args create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-with-tpm.xml create mode 100644 tests/qemuxml2xmloutdata/ppc64-tpmproxy-single.ppc64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/ppc64-tpmproxy-with-tpm.ppc64-latest.xml -- 2.26.2

3 21

[libvirt PATCH] qemu: prevent attempts to detach a device on a controller with hotplug='off'
by Laine Stump 16 May '20

16 May '20

Although the original patches to support controllers with hotplug='off' were checking during hotplug/attach requests that the device was being plugged into a PCI controller that didn't have hotplug disabled, but I forgot to do the same for device detach (the main impetus for adding the feature was to prevent unplugs originating from within the guest, so it slipped my mind). So although the guest OS was ultimately unable to honor the unplug request, libvirt could still be used to make such a request, and since device attach/detach are asynchronous operations, the caller to libvirt would receive a success status back (the device would stubbornly/correctly remain in the domain status XML however) This patch remedies that, by looking at the controller for the device in the detach request, and immediately failing the operation if that controller has hotplug=off. r changes. Lines starting Signed-off-by: Laine Stump <laine(a)redhat.com> --- src/qemu/qemu_hotplug.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index ab5a7aef84..5fe125b1a7 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -5891,6 +5891,33 @@ qemuDomainDetachDeviceLive(virDomainObjPtr vm, return -1; } + if (info->type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) { + int controllerIdx = virDomainControllerFind(vm->def, + VIR_DOMAIN_CONTROLLER_TYPE_PCI, + info->addr.pci.bus); + if (controllerIdx < 0) { + virReportError(VIR_ERR_OPERATION_FAILED, + _("cannot hot unplug %s device with PCI guest address: " + VIR_PCI_DEVICE_ADDRESS_FMT + " - controller not found"), + virDomainDeviceTypeToString(detach.type), + info->addr.pci.domain, info->addr.pci.bus, + info->addr.pci.slot, info->addr.pci.function); + return -1; + } + + if (vm->def->controllers[controllerIdx]->opts.pciopts.hotplug + == VIR_TRISTATE_SWITCH_OFF) { + virReportError(VIR_ERR_OPERATION_FAILED, + _("cannot hot unplug %s device with PCI guest address: " + VIR_PCI_DEVICE_ADDRESS_FMT + " - not allowed by controller"), + virDomainDeviceTypeToString(detach.type), + info->addr.pci.domain, info->addr.pci.bus, + info->addr.pci.slot, info->addr.pci.function); + return -1; + } + } /* * Issue the qemu monitor command to delete the device (based on * its alias), and optionally wait a short time in case the -- 2.25.4

3 2

Firmware auto-select limitation
by GUOQING LI 15 May '20

15 May '20

Hi everyone and Martin I would like to confirm the conversation we had in regard the possible limitation of firmware auto-select feature that’s been released since v5.20. I recall you saying that there were a lot of issues with auto select and later they shipped it into a Json file , it still didn’t solve all the problems, did it? Is it better to explicitly specify the loader and nvram path than using auto-select ? Just today, I encountered the issue of using firmware=“efi” on libvirt 5.4.0 I am running Ubuntu eoan 19.10, I am wondering how did it happen. Detailed error Error starting domain: internal error: process exited while connecting to monitor: 2020-05-15T14:19:06.033267Z qemu-system-x86_64: -drive file=/usr/share/OVMF/OVMF_CODE.fd,if=pflash,format=raw,unit=0,readonly=on: Failed to lock byte 100 Traceback (most recent call last): File "/usr/share/virt-manager/virtManager/asyncjob.py", line 75, in cb_wrapper callback(asyncjob, *args, **kwargs) File "/usr/share/virt-manager/virtManager/asyncjob.py", line 111, in tmpcb callback(*args, **kwargs) File "/usr/share/virt-manager/virtManager/object/libvirtobject.py", line 66, in newfn ret = fn(self, *args, **kwargs) File "/usr/share/virt-manager/virtManager/object/domain.py", line 1279, in startup self._backend.create() File "/usr/lib/python3/dist-packages/libvirt.py", line 1080, in create if ret == -1: raise libvirtError ('virDomainCreate() failed', dom=self) libvirt.libvirtError: internal error: process exited while connecting to monitor: 2020-05-15T14:19:06.033267Z qemu-system-x86_64: -drive file=/usr/share/OVMF/OVMF_CODE.fd,if=pflash,format=raw,unit=0,readonly=on: Failed to lock byte 100

3 2

[PATCH v2 0/3] qemu: Use -numa memdev= if -numa mem= is unavailable
by Michal Privoznik 15 May '20

15 May '20

v2 of: https://www.redhat.com/archives/libvir-list/2020-May/msg00490.html diff to v1: - different approach used. I completely forgot about the discussion we had, but after Dan pointed it out to me, it clicked. Michal Prívozník (3): qemu: Track numa-mem-supported machine attribute qemuBuildNumaArgStr: Switch order of if() and for() qemuBuildNumaArgStr: Use modern -numa memdev= if old -numa mem= is unsupported src/qemu/qemu_capabilities.c | 44 ++- src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_capspriv.h | 3 +- src/qemu/qemu_command.c | 17 +- src/qemu/qemu_monitor.h | 1 + src/qemu/qemu_monitor_json.c | 11 + .../caps_1.5.3.x86_64.xml | 60 ++-- .../caps_1.6.0.x86_64.xml | 68 ++--- .../caps_1.7.0.x86_64.xml | 76 ++--- .../caps_2.1.1.x86_64.xml | 92 +++--- .../caps_2.10.0.aarch64.xml | 204 +++++++------- .../caps_2.10.0.ppc64.xml | 84 +++--- .../caps_2.10.0.s390x.xml | 28 +- .../caps_2.10.0.x86_64.xml | 140 +++++----- .../caps_2.11.0.s390x.xml | 32 +-- .../caps_2.11.0.x86_64.xml | 140 +++++----- .../caps_2.12.0.aarch64.xml | 228 +++++++-------- .../caps_2.12.0.ppc64.xml | 100 +++---- .../caps_2.12.0.s390x.xml | 36 +-- .../caps_2.12.0.x86_64.xml | 148 +++++----- .../caps_2.4.0.x86_64.xml | 116 ++++---- .../caps_2.5.0.x86_64.xml | 124 ++++---- .../caps_2.6.0.aarch64.xml | 164 +++++------ .../qemucapabilitiesdata/caps_2.6.0.ppc64.xml | 60 ++-- .../caps_2.6.0.x86_64.xml | 100 +++---- .../qemucapabilitiesdata/caps_2.7.0.s390x.xml | 16 +- .../caps_2.7.0.x86_64.xml | 108 +++---- .../qemucapabilitiesdata/caps_2.8.0.s390x.xml | 20 +- .../caps_2.8.0.x86_64.xml | 124 ++++---- .../qemucapabilitiesdata/caps_2.9.0.ppc64.xml | 80 +++--- .../qemucapabilitiesdata/caps_2.9.0.s390x.xml | 24 +- .../caps_2.9.0.x86_64.xml | 132 ++++----- .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 104 +++---- .../caps_3.0.0.riscv32.xml | 10 +- .../caps_3.0.0.riscv64.xml | 10 +- .../qemucapabilitiesdata/caps_3.0.0.s390x.xml | 40 +-- .../caps_3.0.0.x86_64.xml | 156 +++++------ .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 108 +++---- .../caps_3.1.0.x86_64.xml | 164 +++++------ .../caps_4.0.0.aarch64.xml | 264 +++++++++--------- .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 112 ++++---- .../caps_4.0.0.riscv32.xml | 10 +- .../caps_4.0.0.riscv64.xml | 10 +- .../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 48 ++-- .../caps_4.0.0.x86_64.xml | 164 +++++------ .../caps_4.1.0.x86_64.xml | 176 ++++++------ .../caps_4.2.0.aarch64.xml | 52 ++-- .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 72 ++--- .../caps_4.2.0.x86_64.xml | 184 ++++++------ .../caps_5.0.0.aarch64.xml | 52 ++-- .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 76 ++--- .../caps_5.0.0.x86_64.xml | 176 ++++++------ .../caps_5.1.0.x86_64.xml | 176 ++++++------ tests/testutilsqemu.c | 6 +- 54 files changed, 2408 insertions(+), 2345 deletions(-) -- 2.26.2

2 7

[libvirt PATCH] docs: Update after libvirt-ruby repository rename
by Andrea Bolognani 15 May '20

15 May '20

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. docs/ci.rst | 10 +++++----- docs/downloads.html.in | 8 ++++---- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/docs/ci.rst b/docs/ci.rst index fe59b98923..2a8788d0d7 100644 --- a/docs/ci.rst +++ b/docs/ci.rst @@ -76,16 +76,16 @@ Language bindings :target: https://gitlab.com/libvirt/libvirt-python/pipelines :alt: libvirt-python pipeline status + * - libvirt-ruby + - .. image:: https://gitlab.com/libvirt/libvirt-ruby/badges/master/pipeline.svg + :target: https://gitlab.com/libvirt/libvirt-ruby/pipelines + :alt: libvirt-ruby pipeline status + * - libvirt-rust - .. image:: https://gitlab.com/libvirt/libvirt-rust/badges/master/pipeline.svg :target: https://gitlab.com/libvirt/libvirt-rust/pipelines :alt: libvirt-rust pipeline status - * - ruby-libvirt - - .. image:: https://gitlab.com/libvirt/ruby-libvirt/badges/master/pipeline.svg - :target: https://gitlab.com/libvirt/ruby-libvirt/pipelines - :alt: ruby-libvirt pipeline status - Object mappings --------------- diff --git a/docs/downloads.html.in b/docs/downloads.html.in index 506c2669b4..24ee27cc5c 100644 --- a/docs/downloads.html.in +++ b/docs/downloads.html.in @@ -179,14 +179,14 @@ <a href="https://libvirt.org/sources/ruby/">libvirt</a> </td> <td> - <a href="https://gitlab.com/libvirt/ruby-libvirt">gitlab</a> + <a href="https://gitlab.com/libvirt/libvirt-ruby">gitlab</a> </td> <td> - <a href="https://gitlab.com/libvirt/ruby-libvirt/-/issues">issues</a> + <a href="https://gitlab.com/libvirt/libvirt-ruby/-/issues">issues</a> </td> <td class="gitmirror"> - <a href="https://libvirt.org/git/?p=ruby-libvirt.git;a=summary">libvirt</a> - <a href="https://github.com/libvirt/ruby-libvirt">github</a> + <a href="https://libvirt.org/git/?p=libvirt-ruby.git;a=summary">libvirt</a> + <a href="https://github.com/libvirt/libvirt-ruby">github</a> </td> <td></td> </tr> -- 2.25.4

1 0

[libvirt-ruby PATCH v2 0/4] Introduce GitLab CI and merge requests
by Daniel P. Berrangé 15 May '20

15 May '20

In v2: - Renamed repo - Change way we conditionalize build rules Daniel P. Berrangé (4): doc: update for new git repo name and hosting gitlab: introduce CI jobs testing git master & distro libvirt gitlab: add CONTRIBUTING.rst file to indicate use of merge requests Remove obsolete mercurial ignore file .gitlab-ci.yml | 169 +++++++++++++++++++++++++++ .gitpublish | 4 - .hgignore | 7 -- CONTRIBUTING.rst | 28 +++++ ci/README.rst | 14 +++ ci/libvirt-centos-7.Dockerfile | 86 ++++++++++++++ ci/libvirt-centos-8.Dockerfile | 64 ++++++++++ ci/libvirt-debian-10.Dockerfile | 56 +++++++++ ci/libvirt-debian-9.Dockerfile | 59 ++++++++++ ci/libvirt-debian-sid.Dockerfile | 56 +++++++++ ci/libvirt-fedora-31.Dockerfile | 53 +++++++++ ci/libvirt-fedora-32.Dockerfile | 53 +++++++++ ci/libvirt-fedora-rawhide.Dockerfile | 54 +++++++++ ci/libvirt-opensuse-151.Dockerfile | 55 +++++++++ ci/libvirt-ubuntu-1804.Dockerfile | 59 ++++++++++ ci/libvirt-ubuntu-2004.Dockerfile | 56 +++++++++ ci/refresh | 27 +++++ doc/site/downloads.html | 12 +- doc/site/index.html | 2 +- 19 files changed, 892 insertions(+), 22 deletions(-) delete mode 100644 .gitpublish delete mode 100644 .hgignore create mode 100644 CONTRIBUTING.rst create mode 100644 ci/README.rst create mode 100644 ci/libvirt-centos-7.Dockerfile create mode 100644 ci/libvirt-centos-8.Dockerfile create mode 100644 ci/libvirt-debian-10.Dockerfile create mode 100644 ci/libvirt-debian-9.Dockerfile create mode 100644 ci/libvirt-debian-sid.Dockerfile create mode 100644 ci/libvirt-fedora-31.Dockerfile create mode 100644 ci/libvirt-fedora-32.Dockerfile create mode 100644 ci/libvirt-fedora-rawhide.Dockerfile create mode 100644 ci/libvirt-opensuse-151.Dockerfile create mode 100644 ci/libvirt-ubuntu-1804.Dockerfile create mode 100644 ci/libvirt-ubuntu-2004.Dockerfile create mode 100755 ci/refresh -- 2.26.2

2 7

[libvirt-java PATCH v2 0/2] Introduce GitLab CI and merge requests
by Daniel P. Berrangé 15 May '20

15 May '20

In v2: - Use different approach for conditional job rules - Use ubuntu for long term git job Daniel P. Berrangé (2): gitlab: introduce CI jobs testing git master & distro libvirt gitlab: add CONTRIBUTING.rst file to indicate use of merge requests .gitlab-ci.yml | 171 +++++++++++++++++++++++++++ .gitpublish | 4 - CONTRIBUTING.rst | 28 +++++ ci/README.rst | 14 +++ ci/libvirt-centos-7.Dockerfile | 88 ++++++++++++++ ci/libvirt-centos-8.Dockerfile | 55 +++++++++ ci/libvirt-debian-10.Dockerfile | 58 +++++++++ ci/libvirt-debian-9.Dockerfile | 61 ++++++++++ ci/libvirt-debian-sid.Dockerfile | 58 +++++++++ ci/libvirt-fedora-31.Dockerfile | 55 +++++++++ ci/libvirt-fedora-32.Dockerfile | 55 +++++++++ ci/libvirt-fedora-rawhide.Dockerfile | 56 +++++++++ ci/libvirt-opensuse-151.Dockerfile | 57 +++++++++ ci/libvirt-ubuntu-1804.Dockerfile | 61 ++++++++++ ci/libvirt-ubuntu-2004.Dockerfile | 68 +++++++++++ ci/refresh | 27 +++++ 16 files changed, 912 insertions(+), 4 deletions(-) delete mode 100644 .gitpublish create mode 100644 CONTRIBUTING.rst create mode 100644 ci/README.rst create mode 100644 ci/libvirt-centos-7.Dockerfile create mode 100644 ci/libvirt-centos-8.Dockerfile create mode 100644 ci/libvirt-debian-10.Dockerfile create mode 100644 ci/libvirt-debian-9.Dockerfile create mode 100644 ci/libvirt-debian-sid.Dockerfile create mode 100644 ci/libvirt-fedora-31.Dockerfile create mode 100644 ci/libvirt-fedora-32.Dockerfile create mode 100644 ci/libvirt-fedora-rawhide.Dockerfile create mode 100644 ci/libvirt-opensuse-151.Dockerfile create mode 100644 ci/libvirt-ubuntu-1804.Dockerfile create mode 100644 ci/libvirt-ubuntu-2004.Dockerfile create mode 100755 ci/refresh -- 2.26.2

2 3

[libvirt-ci PATCH] guests: don't force user to create a config.yaml file
by Daniel P. Berrangé 15 May '20

15 May '20

Only the "install" command requires a per-user config.yaml with a password set. We should not require this for the other commands to be run. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- guests/lcitool | 51 +++++++++++++++++++++++++------------------------- 1 file changed, 25 insertions(+), 26 deletions(-) diff --git a/guests/lcitool b/guests/lcitool index 27aee7b..1f093d0 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -138,11 +138,15 @@ class Config: with open(os.path.join(base, "config.yaml"), "r") as fp: self.values = yaml.safe_load(fp) + user_config_path = self._get_config_file("config.yaml") + if not os.path.exists(user_config_path): + return + try: - with open(self._get_config_file("config.yaml"), "r") as fp: + with open(user_config_path, "r") as fp: user_config = yaml.safe_load(fp) except Exception as e: - raise Exception("Missing or invalid config.yaml file: {}".format(e)) + raise Exception("Invalid config.yaml file: {}".format(e)) if user_config is None: raise Exception("Missing or invalid config.yaml file") @@ -181,20 +185,13 @@ class Config: if k not in known_keys: del _dict[k] - def _validate_section(self, config, section, mandatory_keys): + def _validate_section(self, config, section): # remove keys we don't recognize self._remove_unknown_keys(config[section], self.values[section].keys()) - # check that the mandatory keys are present and non-empty - for key in mandatory_keys: - if config.get(section).get(key) is None: - raise Exception(("Missing or empty value for mandatory key" - "'{}.{}'").format(section, key)) - # check that all keys have values assigned and of the right type for key in config[section].keys(): - # mandatory keys were already checked, so this covers optional keys if config[section][key] is None: raise Exception( "Missing value for '{}.{}'".format(section, key) @@ -209,22 +206,6 @@ class Config: # delete sections we don't recognize self._remove_unknown_keys(config, self.values.keys()) - if "install" not in config: - raise Exception("Missing mandatory section 'install'") - - self._validate_section(config, "install", ["root_password"]) - - # we only need this for the gitlab check below, if 'flavor' is missing - # that's okay, we'll provide a default later - flavor = config["install"].get("flavor") - if flavor is not None and flavor not in ["test", "jenkins", "gitlab"]: - raise Exception( - "Invalid value '{}' for 'install.flavor'".format(flavor) - ) - - if flavor == "gitlab": - self._validate_section(config, "gitlab", ["runner_secret"]) - def _update(self, values): self.values["install"].update(values["install"]) @@ -561,10 +542,28 @@ class Application: for project in self._projects.expand_pattern("all"): print(project) + def _validate_install_config(self, config): + if config.values["install"].get("root_password") is None: + raise Exception("Missing mandatory install.root_password config.yaml parameter") + + # we only need this for the gitlab check below, if 'flavor' is missing + # that's okay, we'll provide a default later + flavor = config.values["install"].get("flavor") + if flavor is not None and flavor not in ["test", "jenkins", "gitlab"]: + raise Exception( + "Invalid value '{}' for 'install.flavor'".format(flavor) + ) + + if flavor == "gitlab": + if config.values["gitlab"].get("runner_secret") is None: + raise Exception("Missing mandatory gitlab.runner_secret config.yaml parameter") + def _action_install(self, args): base = Util.get_base() config = self._config + self._validate_install_config(config) + for host in self._inventory.expand_pattern(args.hosts): facts = self._inventory.get_facts(host) -- 2.26.2

2 1

[PATCH] README: Replace "configure" with "autogen.sh" for correct installation
by Yi Wang 15 May '20

15 May '20

From: LiaoPingfang <liao.pingfang(a)zte.com.cn> First of all, there is no "configure" file. We need use autogen.sh at first to create "configure" file. Then in autogen.sh "configure" will be executed according to user as root or non-root. Signed-off-by: Liao Pingfang <liao.pingfang(a)zte.com.cn> --- README.rst | 4 ++-- autogen.sh | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/README.rst b/README.rst index cdcc97b..82b4b31 100644 --- a/README.rst +++ b/README.rst @@ -53,7 +53,7 @@ in a manner that is suitable for installing as root, use: :: $ mkdir build && cd build - $ ../configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var + $ ../autogen.sh $ make $ sudo make install @@ -62,7 +62,7 @@ While to build & install as an unprivileged user :: $ mkdir build && cd build - $ ../configure --prefix=$HOME/usr + $ ../autogen.sh $ make $ make install diff --git a/autogen.sh b/autogen.sh index 4e1bbce..3c119e1 100755 --- a/autogen.sh +++ b/autogen.sh @@ -27,6 +27,10 @@ if test "x$1" = "x--system"; then libdir=$prefix/lib64 fi EXTRA_ARGS="--prefix=$prefix --sysconfdir=$sysconfdir --localstatedir=$localstatedir --libdir=$libdir" + if [ "$HOME" != "/root" ]; then + prefix=$HOME/usr + EXTRA_ARGS="--prefix=$prefix" + fi fi cd "$olddir" -- 2.9.5

5 6

[libvirt PATCH] cpu_arm: Drop unused variable
by Jiri Denemark 15 May '20

15 May '20

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- Pushed. It is trivial and should fix the build on FreeBSD. src/cpu/cpu_arm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/cpu/cpu_arm.c b/src/cpu/cpu_arm.c index 66f6942ab9..6f6c6a1479 100644 --- a/src/cpu/cpu_arm.c +++ b/src/cpu/cpu_arm.c @@ -325,7 +325,6 @@ virCPUarmModelParse(xmlXPathContextPtr ctxt, { virCPUarmMapPtr map = data; g_autoptr(virCPUarmModel) model = NULL; - g_autofree xmlNodePtr *nodes = NULL; g_autofree char *vendor = NULL; model = g_new0(virCPUarmModel, 1); -- 2.26.2

1 0

[libvirt PATCH] docs: document proper enum for guest agent timeout
by Tomáš Golembiovský 15 May '20

15 May '20

The documented enum and its values do not exits. The real enum has slightly different name. Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com> --- src/libvirt-domain.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index a12809c2d5..37f864b7b0 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -12550,13 +12550,13 @@ int virDomainGetLaunchSecurityInfo(virDomainPtr domain, * Set how long to wait for a response from guest agent commands. By default, * agent commands block forever waiting for a response. * - * @timeout must be a value from virDomainAgentCommandTimeoutValues or + * @timeout must be a value from virDomainAgentResponseTimeoutValues or * positive: * - * VIR_DOMAIN_AGENT_COMMAND_TIMEOUT_BLOCK(-2): meaning to block forever + * VIR_DOMAIN_AGENT_RESPONSE_TIMEOUT_BLOCK(-2): meaning to block forever * waiting for a result. - * VIR_DOMAIN_AGENT_COMMAND_TIMEOUT_DEFAULT(-1): use default timeout value. - * VIR_DOMAIN_AGENT_COMMAND_TIMEOUT_NOWAIT(0): does not wait. + * VIR_DOMAIN_AGENT_RESPONSE_TIMEOUT_DEFAULT(-1): use default timeout value. + * VIR_DOMAIN_AGENT_RESPONSE_TIMEOUT_NOWAIT(0): does not wait. * positive value: wait for @timeout seconds * * Returns 0 on success, -1 on failure -- 2.25.0

2 1

[libvirt PATCH] qemu: reject readonly attribute for virtiofs
by Ján Tomko 15 May '20

15 May '20

This is not yet supported by virtiofsd. Fixes #23 Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/qemu/qemu_validate.c | 5 +++ .../vhost-user-fs-readonly.xml | 44 +++++++++++++++++++ tests/qemuxml2argvtest.c | 1 + 3 files changed, 50 insertions(+) create mode 100644 tests/qemuxml2argvdata/vhost-user-fs-readonly.xml diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index fde1892d42..ac22270104 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -3418,6 +3418,11 @@ qemuValidateDomainDeviceDefFS(virDomainFSDefPtr fs, return -1; case VIR_DOMAIN_FS_DRIVER_TYPE_VIRTIOFS: + if (fs->readonly) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("virtiofs does not yet supported read-only mode")); + return -1; + } if (!driver->privileged) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("virtiofs is not yet supported in session mode")); diff --git a/tests/qemuxml2argvdata/vhost-user-fs-readonly.xml b/tests/qemuxml2argvdata/vhost-user-fs-readonly.xml new file mode 100644 index 0000000000..003ed41eb3 --- /dev/null +++ b/tests/qemuxml2argvdata/vhost-user-fs-readonly.xml @@ -0,0 +1,44 @@ +<domain type='kvm'> + <name>guest</name> + <uuid>126f2720-6f8e-45ab-a886-ec9277079a67</uuid> + <memory unit='KiB'>14680064</memory> + <currentMemory unit='KiB'>14680064</currentMemory> + <memoryBacking> + <source type='file'/> + <access mode='shared'/> + </memoryBacking> + <vcpu placement='static'>2</vcpu> + <os> + <type arch='x86_64' machine='pc'>hvm</type> + <boot dev='hd'/> + </os> + <cpu mode='custom' match='exact' check='none'> + <model fallback='forbid'>qemu64</model> + <numa> + <cell id='0' cpus='0-1' memory='14680064' unit='KiB' memAccess='shared'/> + </numa> + </cpu> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <emulator>/usr/bin/qemu-system-x86_64</emulator> + <controller type='usb' index='0' model='none'/> + <controller type='pci' index='0' model='pci-root'/> + <filesystem type='mount' accessmode='passthrough'> + <driver type='virtiofs' queue='1024'/> + <binary path='/usr/libexec/virtiofsd' xattr='on'> + <cache mode='always'/> + <lock posix='off' flock='off'/> + </binary> + <source dir='/path'/> + <target dir='mount_tag'/> + <readonly/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/> + </filesystem> + <input type='mouse' bus='ps2'/> + <input type='keyboard' bus='ps2'/> + <memballoon model='none'/> + </devices> +</domain> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 4ab664a846..8cbf3f8daf 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -3171,6 +3171,7 @@ mymain(void) DO_TEST_CAPS_LATEST("vhost-user-fs-fd-memory"); DO_TEST_CAPS_LATEST("vhost-user-fs-hugepages"); + DO_TEsT_CAPS_LATEST_PARSE_ERROR("vhost-user-fs-readonly"); DO_TEST("riscv64-virt", QEMU_CAPS_DEVICE_VIRTIO_MMIO); -- 2.25.4

6 17

[PATCH V5 0/4] Introduce getHost support for ARM CPU driver
by Zhenyu Zheng 15 May '20

15 May '20

Introduce getHost support for ARM CPU driver. First add some data about commonly used ARM CPU models, and their vendors into cpu_map, then added some helper methods as callbacks to load them. Read and parse vendor_id, part_id and CPU flags of local CPU from corresponding registers. Signed-off-by: Zhenyu Zheng <zheng.zhenyu(a)outlook.com> Zhenyu Zheng (4): cpu: Introduce virCPUarmData and related struts cpu: Add helper functions to parse vendor and model cpu: Introduce getHost support for ARM CPU driver cpu_map: Introduce ARM cpu models src/cpu/Makefile.inc.am | 1 + src/cpu/cpu.h | 2 + src/cpu/cpu_arm.c | 399 +++++++++++++++++++++++++++++- src/cpu/cpu_arm_data.h | 32 +++ src/cpu_map/Makefile.inc.am | 7 + src/cpu_map/arm_Falkor.xml | 6 + src/cpu_map/arm_Kunpeng-920.xml | 6 + src/cpu_map/arm_ThunderX299xx.xml | 6 + src/cpu_map/arm_cortex-a53.xml | 6 + src/cpu_map/arm_cortex-a57.xml | 6 + src/cpu_map/arm_cortex-a72.xml | 6 + src/cpu_map/arm_vendors.xml | 14 ++ src/cpu_map/index.xml | 15 ++ 13 files changed, 505 insertions(+), 1 deletion(-) create mode 100644 src/cpu/cpu_arm_data.h create mode 100644 src/cpu_map/arm_Falkor.xml create mode 100644 src/cpu_map/arm_Kunpeng-920.xml create mode 100644 src/cpu_map/arm_ThunderX299xx.xml create mode 100644 src/cpu_map/arm_cortex-a53.xml create mode 100644 src/cpu_map/arm_cortex-a57.xml create mode 100644 src/cpu_map/arm_cortex-a72.xml create mode 100644 src/cpu_map/arm_vendors.xml -- 2.20.1

2 1