- Devel - libvirt List Archives

[libvirt PATCH] rpm: include aarch64 & riscv64 in systemtap 64-bit arch tapset rename
by Daniel P. Berrangé 05 Oct '20

05 Oct '20

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 682d43c290..d13aae5cf5 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1261,7 +1261,7 @@ rm -f $RPM_BUILD_ROOT%{_datadir}/augeas/lenses/tests/test_libvirtd_libxl.aug # Copied into libvirt-docs subpackage eventually mv $RPM_BUILD_ROOT%{_datadir}/doc/libvirt libvirt-docs -%ifarch %{power64} s390x x86_64 +%ifarch %{power64} s390x x86_64 aarch64 riscv64 mv $RPM_BUILD_ROOT%{_datadir}/systemtap/tapset/libvirt_probes.stp \ $RPM_BUILD_ROOT%{_datadir}/systemtap/tapset/libvirt_probes-64.stp -- 2.26.2

3 2

[PATCH V4] Modify virCPUarmCompare to perform compare actions
by Zhenyu Zheng 05 Oct '20

05 Oct '20

Modify virCPUarmCompare in cpu_arm.c to perform compare action. This patch only adds host to host CPU compare, the rest cases remains the same. This is useful for source and destination host compare during migrations to avoid migration between different CPU models that have different CPU freatures. Signed-off-by: Zhenyu Zheng <zheng.zhenyu(a)outlook.com> --- src/cpu/cpu_arm.c | 39 ++++++++++++++++++++++++++++++++++++--- 1 file changed, 36 insertions(+), 3 deletions(-) diff --git a/src/cpu/cpu_arm.c b/src/cpu/cpu_arm.c index 939a3b8390..64bd0f03c2 100644 --- a/src/cpu/cpu_arm.c +++ b/src/cpu/cpu_arm.c @@ -463,10 +463,43 @@ virCPUarmBaseline(virCPUDefPtr *cpus, } static virCPUCompareResult -virCPUarmCompare(virCPUDefPtr host G_GNUC_UNUSED, - virCPUDefPtr cpu G_GNUC_UNUSED, - bool failMessages G_GNUC_UNUSED) +virCPUarmCompare(virCPUDefPtr host, + virCPUDefPtr cpu, + bool failIncompatible +) { + /* Only support host to host CPU compare for ARM*/ + if (cpu->type != VIR_CPU_TYPE_HOST) + return VIR_CPU_COMPARE_IDENTICAL; + + if (!host || !host->model) { + if (failIncompatible) { + virReportError(VIR_ERR_CPU_INCOMPATIBLE, "%s", + _("unknown host CPU")); + return VIR_CPU_COMPARE_ERROR; + } else { + VIR_WARN("unknown host CPU"); + return VIR_CPU_COMPARE_INCOMPATIBLE; + } + } + + /* Compare vendor and model to check if CPUs are identical */ + if (STRNEQ_NULLABLE(host->vendor, cpu->vendor) || + STRNEQ_NULLABLE(host->model, cpu->model)) { + VIR_DEBUG("Host CPU model does not match required CPU " + "vendor %s or(and) model %s", + NULLSTR(cpu->vendor), NULLSTR(cpu->model)); + + if (failIncompatible) { + virReportError(VIR_ERR_CPU_INCOMPATIBLE, + _("Host CPU model does not match required CPU " + "vendor %s or(and) model %s"), + NULLSTR(cpu->vendor), NULLSTR(cpu->model)); + return VIR_CPU_COMPARE_ERROR; + } else { + return VIR_CPU_COMPARE_INCOMPATIBLE; + } + } return VIR_CPU_COMPARE_IDENTICAL; } -- 2.20.1

3 2

[PATCH] tests: cover disk, interface <backenddomain>
by Cole Robinson 05 Oct '20

05 Oct '20

There is present no XML test coverage for this. Add genericxml parse + formatting coverage. Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- .../device-backenddomain.xml | 30 +++++++++++++++++++ .../device-backenddomain.xml | 1 + tests/genericxml2xmltest.c | 1 + 3 files changed, 32 insertions(+) create mode 100644 tests/genericxml2xmlindata/device-backenddomain.xml create mode 120000 tests/genericxml2xmloutdata/device-backenddomain.xml diff --git a/tests/genericxml2xmlindata/device-backenddomain.xml b/tests/genericxml2xmlindata/device-backenddomain.xml new file mode 100644 index 0000000000..8e89c7fec3 --- /dev/null +++ b/tests/genericxml2xmlindata/device-backenddomain.xml @@ -0,0 +1,30 @@ +<domain type='qemu'> + <name>foo</name> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> + <memory unit='KiB'>219136</memory> + <currentMemory unit='KiB'>219136</currentMemory> + <vcpu placement='static'>1</vcpu> + <os> + <type arch='i686' machine='pc'>hvm</type> + <boot dev='hd'/> + </os> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <disk type='block' device='disk'> + <driver name='qemu' type='raw'/> + <source dev='/dev/HostVG/QEMUGuest1'/> + <backenddomain name='bar'/> + <target dev='hda' bus='ide'/> + <address type='drive' controller='0' bus='0' target='0' unit='0'/> + </disk> + <controller type='ide' index='0'/> + <interface type='bridge'> + <mac address='aa:bb:cc:dd:ee:ff'/> + <source bridge='br0'/> + <backenddomain name='foo'/> + </interface> + </devices> +</domain> diff --git a/tests/genericxml2xmloutdata/device-backenddomain.xml b/tests/genericxml2xmloutdata/device-backenddomain.xml new file mode 120000 index 0000000000..f19471e3b5 --- /dev/null +++ b/tests/genericxml2xmloutdata/device-backenddomain.xml @@ -0,0 +1 @@ +../genericxml2xmlindata/device-backenddomain.xml \ No newline at end of file diff --git a/tests/genericxml2xmltest.c b/tests/genericxml2xmltest.c index 102abfdec2..5110bfba86 100644 --- a/tests/genericxml2xmltest.c +++ b/tests/genericxml2xmltest.c @@ -233,6 +233,7 @@ mymain(void) DO_TEST("launch-security-sev"); DO_TEST_DIFFERENT("cputune"); + DO_TEST("device-backenddomain"); #define DO_TEST_BACKUP_FULL(name, intrnl) \ do { \ -- 2.28.0

2 1

[PATCH 0/1] qemu: Add support for free-page-reporting
by Nico Pache 05 Oct '20

05 Oct '20

gitlab issue: https://gitlab.com/libvirt/libvirt/-/issues/79 The virtio-balloon device now has the ability to report free pages back to the hypervisor for reuse by other programs. This kernel feature allows for more stable and resource friendly systems. This feature is available in QEMU and is enabled with free-page-reporting=on default virt setting should be off but the user should be able to enable it. Nico Pache (1): Optional free-page-reporting can be enabled/disabled for memballon device of model 'virtio'. docs/formatdomain.rst | 6 ++++++ docs/schemas/domaincommon.rng | 5 +++++ src/conf/domain_conf.c | 21 +++++++++++++++++++ src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 4 +++- src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 5 +++++ src/qemu/qemu_validate.c | 7 +++++++ .../caps_5.1.0.x86_64.xml | 1 + .../caps_5.2.0.x86_64.xml | 1 + 10 files changed, 51 insertions(+), 1 deletion(-) -- 2.18.4

4 6

[PATCH v2 0/4] Add support for QEMU's 'fmode' and 'dmode'
by Brian Turek 05 Oct '20

05 Oct '20

This second version of the patch incorporates Peter Krempa's feedback by tweaking a few things in the code and, more importantly, splitting up the singular large patch into smaller patches. Brian Turek (4): qemu: capabilities: add QEMU_CAPS_FSDEV_CREATEMODE qemu: add support for 'fmode' and 'dmode' options qemu: add schema 'fmode' and 'dmode' options qemu: add docs for 'fmode' and 'dmode' options docs/formatdomain.rst | 12 ++++ docs/schemas/domaincommon.rng | 16 +++++ src/conf/domain_conf.c | 27 ++++++++ src/conf/domain_conf.h | 2 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 6 ++ src/qemu/qemu_validate.c | 18 ++++++ .../caps_2.10.0.aarch64.xml | 1 + .../caps_2.10.0.ppc64.xml | 1 + .../caps_2.10.0.s390x.xml | 1 + .../caps_2.10.0.x86_64.xml | 1 + .../caps_2.11.0.s390x.xml | 1 + .../caps_2.11.0.x86_64.xml | 1 + .../caps_2.12.0.aarch64.xml | 1 + .../caps_2.12.0.ppc64.xml | 1 + .../caps_2.12.0.s390x.xml | 1 + .../caps_2.12.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 1 + .../caps_3.0.0.riscv32.xml | 1 + .../caps_3.0.0.riscv64.xml | 1 + .../qemucapabilitiesdata/caps_3.0.0.s390x.xml | 1 + .../caps_3.0.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1 + .../caps_3.1.0.x86_64.xml | 1 + .../caps_4.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 + .../caps_4.0.0.riscv32.xml | 1 + .../caps_4.0.0.riscv64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 1 + .../caps_4.0.0.x86_64.xml | 1 + .../caps_4.1.0.x86_64.xml | 1 + .../caps_4.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 + .../caps_4.2.0.x86_64.xml | 1 + .../caps_5.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 + .../caps_5.0.0.riscv64.xml | 1 + .../caps_5.0.0.x86_64.xml | 1 + .../caps_5.1.0.x86_64.xml | 1 + .../caps_5.2.0.x86_64.xml | 1 + .../virtio-9p-createmode.x86_64-latest.args | 45 ++++++++++++++ .../qemuxml2argvdata/virtio-9p-createmode.xml | 58 ++++++++++++++++++ .../virtio-9p-createmode.x86_64-latest.xml | 61 +++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 46 files changed, 283 insertions(+) create mode 100644 tests/qemuxml2argvdata/virtio-9p-createmode.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/virtio-9p-createmode.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-9p-createmode.x86_64-latest.xml -- 2.25.1

1 5

[libvirt PATCH 1/2] esx: call freeaddrinfo earlier in esxUtil_ResolveHostname
by Pino Toscano 05 Oct '20

05 Oct '20

Call freeaddrinfo() as soon as @result is not needed anymore, i.e. right after getnameinfo(); this avoids calling freeaddrinfo() in two branches. Signed-off-by: Pino Toscano <ptoscano(a)redhat.com> --- src/esx/esx_util.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/esx/esx_util.c b/src/esx/esx_util.c index 9100873326..555158f953 100644 --- a/src/esx/esx_util.c +++ b/src/esx/esx_util.c @@ -310,17 +310,15 @@ esxUtil_ResolveHostname(const char *hostname, errcode = getnameinfo(result->ai_addr, result->ai_addrlen, ipAddress, ipAddress_length, NULL, 0, NI_NUMERICHOST); + freeaddrinfo(result); if (errcode != 0) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Formatting IP address for host '%s' failed: %s"), hostname, gai_strerror(errcode)); - freeaddrinfo(result); return -1; } - freeaddrinfo(result); - return 0; } -- 2.26.2

2 3

[PATCH] docs/submitting-patches: add reference to DCO
by Mauro Matteo Cascella 05 Oct '20

05 Oct '20

Signed-off-by: Mauro Matteo Cascella <mcascell(a)redhat.com> --- docs/submitting-patches.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/submitting-patches.rst b/docs/submitting-patches.rst index 17b072655d..3ce8b347a0 100644 --- a/docs/submitting-patches.rst +++ b/docs/submitting-patches.rst @@ -22,7 +22,8 @@ patch. However, the usual workflow of libvirt developer is: (hack, committing any changes along the way) More hints on compiling can be found `here <compiling.html>`__. -When you want to post your patches: +Make sure to `sign off <hacking.html#developer-certificate-of-origin>`__ +your commit(s). When you want to post your patches: :: -- 2.26.2

2 2

[python-libvirt] RFC:PEP 484 type annotation - how to continue
by Philipp Hahn 05 Oct '20

05 Oct '20

Hello, currently my Merge Quests <https://gitlab.com/libvirt/libvirt-python/-/merge_requests/9> is stuck because there are some open technical discussions: 1. The Python binding consists of two layers: - libvirtmod* is the low-level C-like API, which mostly is just a thin wrapper around the C-library. It is generated from the API.xml files - The high-level libvirt* modules, providing an object oriented API, which is also generated from the API.xml files. In both cases there are many exceptions defines via libvirt*-override-api.xml or coded in generator.py: - skip_impl: Generate Python code, but skip C implementation - custom_function: Generate neither C nor Python code - hand crafted code - skip_function: Generate neither C nor Python code - not used at all - function_skip_python_impl: Generate C code, but skip python impl Previously the functions listed in "skip_impl" were also duplicated in the "libvirt-*override-api.xml" files, which is somehow hard to maintain. With d19699e48ce9c17481f94b4dc0715e18e05d5adb I removed all those names from "skip_impl", which are also listed in the overrides and added code to add them back when "generator.py" is invoked. For this to work I had to change several "files" attributes to start with "python", which looks okay to me, but still would like to get verified. 2. The low-level library works mostly with bytes, but the high-level Python API uses nested Lists, Tuples and Dicts. To get most out of the Python static type annotations the input and output parameters should be modled in as much detail as possible. This requires to store those types somewhere. My current 46592e28124858ed863bceba65c3dafa2bbb02cd adds some often used types to generator.py and then references them from the overrides.xml: > + 'PyListSecret': ('', 'List["virSecret"]', '', ''), > + 'PyDictAny': ('', 'Dict[str, Any]', '', ''), > + <return type='PyListSecret' info='the list of secrets or None in case of error'/> This still is very painful as there are many "used-once" types, which still must be declared and used in two places. So far the "return" type was used for the "C" type and currently I mis-use it for referencing it for my Python types. This doesn't look right, so I would prefer adding a new attribute which can be used to override the Python type. This also would probably nicely fit with functions like "virDomainOpenConsole", when "dev_name" is optional and can be "None", which the current type hint requires a "string". Is extending the libvirt*-override-api.xml files okay or must this be coordinated with the other parts of the project? Thank you for your time Philipp Hahn -- Philipp Hahn Open Source Software Engineer Univention GmbH be open. Mary-Somerville-Str. 1 D-28359 Bremen 📞 +49-421-22232-57 🖶 +49-421-22232-99 ✉️ hahn(a)univention.de 🌐 https://www.univention.de/ Geschäftsführer: Peter H. Ganten HRB 20755 Amtsgericht Bremen Steuer-Nr.: 71-597-02876

2 1

[libvirt PATCH] rpm: drop ia64, sparc64 and alpha architectures
by Daniel P. Berrangé 05 Oct '20

05 Oct '20

None of these arches are relevant to current Fedora or RHEL distros. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- libvirt.spec.in | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index aa2bc84be9..682d43c290 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -97,8 +97,8 @@ # Finally set the OS / architecture specific special cases -# Xen is available only on i386 x86_64 ia64 -%ifnarch %{ix86} x86_64 ia64 +# Xen is available only on i386 x86_64 +%ifnarch %{ix86} x86_64 %define with_libxl 0 %endif @@ -438,7 +438,7 @@ Requires: iproute-tc %endif Requires: polkit >= 0.112 -%ifarch %{ix86} x86_64 ia64 +%ifarch %{ix86} x86_64 # For virConnectGetSysinfo Requires: dmidecode %endif @@ -1261,7 +1261,7 @@ rm -f $RPM_BUILD_ROOT%{_datadir}/augeas/lenses/tests/test_libvirtd_libxl.aug # Copied into libvirt-docs subpackage eventually mv $RPM_BUILD_ROOT%{_datadir}/doc/libvirt libvirt-docs -%ifarch %{power64} s390x x86_64 ia64 alpha sparc64 +%ifarch %{power64} s390x x86_64 mv $RPM_BUILD_ROOT%{_datadir}/systemtap/tapset/libvirt_probes.stp \ $RPM_BUILD_ROOT%{_datadir}/systemtap/tapset/libvirt_probes-64.stp -- 2.26.2

2 1

[PATCH v2 0/7] virbitmaptest: Refactor and modernize
by Peter Krempa 05 Oct '20

05 Oct '20

This was split out from my series refactoring the virbitmap util module to address review feedback. Patches 1-5 are new, patches 6-7 were already part of the refactor but needed to be modified to fit on top of the changes needed to comply with review requirements. Peter Krempa (7): virbitmaptest: Split up test12 virbitmaptest: Split up test4 virbitmaptest: Use separate output strings in 'test5' virbitmaptest: Turn 'TEST_MAP' macro into a helper function virbitmaptest: Refactor checks in 'test6' virbitmaptest: Use g_auto(free) for cleanup virbitmaptest: Remove unnecessary error/cleanup labels tests/virbitmaptest.c | 512 ++++++++++++++++++------------------------ 1 file changed, 224 insertions(+), 288 deletions(-) -- 2.26.2

2 14

[libvirt PATCH 0/9] Make unknown XML elements fail CPU comparison
by Tim Wiederhake 05 Oct '20

05 Oct '20

We currently ignore unknown elements in the CPU XML description, e.g. with virsh cpu-compare and hypervisor-cpu-compare. This makes '<cpu><faeture name=3D"..."/></cpu>' (note the typo in "faeture") semantically identic to '<cpu/>'. No error is reported. This series adds checks for unrecognized attributes and elements in the "<cpu>" element, catching this kind of mistake. V1: https://www.redhat.com/archives/libvir-list/2020-September/msg00933.html Changed: * Factored out Schema defintion of different cpu elements * Performing validation against actual schema * Add "--validate" option to virsh [hypervisor-]cpu-compare to opt-in to vali= dation * Drive-by: Unify quotation style in docs/schemas/* Tim Wiederhake (9): schema: Unify apostrophe and quotation mark usage schema: Move host cpu definition to cputypes.rng schema: Move guest cpu definition to cputypes.rng schema: Add schema for guest or host cpu definition util: Allow validation for single XML node cpu: Validate XML virsh: Add "validate" argument to [hypervisor-]cpu-compare tests: cpu: Allow passing flags to cpuTestLoadXML tests: Add tests for unknown elements and attributes in cpu defintion docs/schemas/basictypes.rng | 82 +-- docs/schemas/capability.rng | 466 ++++++--------- docs/schemas/cpu.rng | 12 + docs/schemas/cputypes.rng | 117 +++- docs/schemas/domain.rng | 10 +- docs/schemas/domainbackup.rng | 178 +++--- docs/schemas/domaincaps.rng | 236 ++++---- docs/schemas/domaincheckpoint.rng | 62 +- docs/schemas/domaincommon.rng | 431 +++++++------- docs/schemas/domainsnapshot.rng | 104 ++-- docs/schemas/interface.rng | 6 +- docs/schemas/meson.build | 1 + docs/schemas/network.rng | 44 +- docs/schemas/networkcommon.rng | 26 +- docs/schemas/networkport.rng | 6 +- docs/schemas/nodedev.rng | 464 +++++++-------- docs/schemas/nwfilter.rng | 32 +- docs/schemas/nwfilterbinding.rng | 4 +- docs/schemas/secret.rng | 70 +-- docs/schemas/storagecommon.rng | 110 ++-- docs/schemas/storagepool.rng | 584 +++++++++---------- docs/schemas/storagepoolcaps.rng | 64 +- docs/schemas/storagevol.rng | 150 ++--- include/libvirt/libvirt-host.h | 1 + src/bhyve/bhyve_driver.c | 7 +- src/conf/cpu_conf.c | 28 +- src/conf/cpu_conf.h | 6 +- src/conf/domain_conf.c | 3 +- src/cpu/cpu.c | 5 +- src/cpu/cpu.h | 3 +- src/libxl/libxl_driver.c | 7 +- src/qemu/qemu_domain.c | 5 +- src/qemu/qemu_driver.c | 18 +- src/qemu/qemu_migration_cookie.c | 3 +- src/util/virxml.c | 15 + src/util/virxml.h | 6 + tests/cputest.c | 52 +- tests/cputestdata/x86_64-bogus-attribute.xml | 2 + tests/cputestdata/x86_64-bogus-element.xml | 3 + tools/virsh-host.c | 14 + 40 files changed, 1773 insertions(+), 1664 deletions(-) create mode 100644 docs/schemas/cpu.rng create mode 100644 tests/cputestdata/x86_64-bogus-attribute.xml create mode 100644 tests/cputestdata/x86_64-bogus-element.xml --=20 2.26.2

4 30

[libvirt PATCH v2] docs: use "::" instead of ".. code-block::"
by Daniel P. Berrangé 05 Oct '20

05 Oct '20

The former is a short hand for the latter and is already widely used in the docs. Using the short hand avoids incompatibility with the alternate impl of rst2html5. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Changed in v2: - Simplify to use "::" instead of adding a language to ".. code-block::" because the latter didn't work on macOS builds due to problems with pygments integration in homebrew docs/manpages/libvirtd.rst | 4 +- docs/manpages/virsh.rst | 582 ++++++++++++++--------------- docs/manpages/virt-admin.rst | 52 +-- docs/manpages/virt-login-shell.rst | 8 +- docs/manpages/virtlockd.rst | 4 +- docs/manpages/virtlogd.rst | 4 +- 6 files changed, 327 insertions(+), 327 deletions(-) diff --git a/docs/manpages/libvirtd.rst b/docs/manpages/libvirtd.rst index c88e2dd7e1..cd9976c5e4 100644 --- a/docs/manpages/libvirtd.rst +++ b/docs/manpages/libvirtd.rst @@ -199,7 +199,7 @@ EXAMPLES To retrieve the version of libvirtd: -.. code-block:: +:: # libvirtd --version libvirtd (libvirt) 0.8.2 @@ -207,7 +207,7 @@ To retrieve the version of libvirtd: To start libvirtd, instructing it to daemonize and create a PID file: -.. code-block:: +:: # libvirtd -d # ls -la @RUNSTATEDIR@/libvirtd.pid diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index 9ac379a4b8..c855269041 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -38,7 +38,7 @@ KVM, LXC, OpenVZ, VirtualBox and VMware ESX. The basic structure of most virsh usage is: -.. code-block:: +:: virsh [OPTION]... <command> <domain> [ARG]... @@ -185,7 +185,7 @@ historical reasons, some commands default to bytes, while other commands default to kibibytes). The following case-insensitive suffixes can be used to select a specific scale: -.. code-block:: +:: b, byte byte 1 KB kilobyte 1,000 @@ -214,7 +214,7 @@ help **Syntax:** -.. code-block:: +:: help [command-or-group] @@ -228,7 +228,7 @@ group as an option. For example: **Example 1:** -.. code-block:: +:: virsh # help host @@ -250,7 +250,7 @@ option instead. For example: **Example 2:** -.. code-block:: +:: virsh # help list NAME @@ -272,7 +272,7 @@ quit, exit **Syntax:** -.. code-block:: +:: quit exit @@ -286,7 +286,7 @@ version **Syntax:** -.. code-block:: +:: version [--daemon] @@ -296,7 +296,7 @@ is included in the output. **Example:** -.. code-block:: +:: $ virsh version Compiled against library: libvirt 1.2.3 @@ -317,7 +317,7 @@ cd **Syntax:** -.. code-block:: +:: cd [directory] @@ -334,7 +334,7 @@ pwd **Syntax:** -.. code-block:: +:: pwd @@ -347,7 +347,7 @@ connect **Syntax:** -.. code-block:: +:: connect [URI] [--readonly] @@ -388,7 +388,7 @@ uri **Syntax:** -.. code-block:: +:: uri @@ -400,7 +400,7 @@ hostname **Syntax:** -.. code-block:: +:: hostname @@ -412,7 +412,7 @@ sysinfo **Syntax:** -.. code-block:: +:: sysinfo @@ -424,7 +424,7 @@ nodeinfo **Syntax:** -.. code-block:: +:: nodeinfo @@ -440,7 +440,7 @@ nodecpumap **Syntax:** -.. code-block:: +:: nodecpumap [--pretty] @@ -456,7 +456,7 @@ nodecpustats **Syntax:** -.. code-block:: +:: nodecpustats [cpu] [--percent] @@ -471,7 +471,7 @@ nodememstats **Syntax:** -.. code-block:: +:: nodememstats [cell] @@ -484,7 +484,7 @@ nodesuspend **Syntax:** -.. code-block:: +:: nodesuspend [target] [duration] @@ -503,7 +503,7 @@ node-memory-tune **Syntax:** -.. code-block:: +:: node-memory-tune [shm-pages-to-scan] [shm-sleep-millisecs] [shm-merge-across-nodes] @@ -525,7 +525,7 @@ capabilities **Syntax:** -.. code-block:: +:: capabilities @@ -545,7 +545,7 @@ domcapabilities **Syntax:** -.. code-block:: +:: domcapabilities [virttype] [emulatorbin] [arch] [machine] @@ -588,7 +588,7 @@ pool-capabilities **Syntax:** -.. code-block:: +:: pool-capabilities @@ -605,7 +605,7 @@ inject-nmi **Syntax:** -.. code-block:: +:: inject-nmi domain @@ -617,7 +617,7 @@ list **Syntax:** -.. code-block:: +:: list [--inactive | --all] [--managed-save] [--title] @@ -637,7 +637,7 @@ specified it prints out information about running domains. An example format for the list is as follows: -.. code-block:: +:: ``virsh`` list Id Name State @@ -775,7 +775,7 @@ printed in an extra column. This flag is usable only with the default **Example 2:** -.. code-block:: +:: $ virsh list --title Id Name State Title @@ -790,7 +790,7 @@ freecell **Syntax:** -.. code-block:: +:: freecell [{ [--cellno] cellno | --all }] @@ -809,7 +809,7 @@ freepages **Syntax:** -.. code-block:: +:: freepages [{ [--cellno] cellno [--pagesize] pagesize | --all }] @@ -824,7 +824,7 @@ allocpages **Syntax:** -.. code-block:: +:: allocpages [--pagesize] pagesize [--pagecount] pagecount [[--cellno] cellno] [--add] [--all] @@ -843,7 +843,7 @@ cpu-baseline **Syntax:** -.. code-block:: +:: cpu-baseline FILE [--features] [--migratable] @@ -864,7 +864,7 @@ cpu-compare **Syntax:** -.. code-block:: +:: cpu-compare FILE [--error] @@ -890,7 +890,7 @@ cpu-models **Syntax:** -.. code-block:: +:: cpu-models arch @@ -909,7 +909,7 @@ echo **Syntax:** -.. code-block:: +:: echo [--shell] [--xml] [err...] [arg...] @@ -926,7 +926,7 @@ hypervisor-cpu-compare **Syntax:** -.. code-block:: +:: hypervisor-cpu-compare FILE [virttype] [emulator] [arch] [machine] [--error] @@ -958,7 +958,7 @@ hypervisor-cpu-baseline **Syntax:** -.. code-block:: +:: hypervisor-cpu-baseline FILE [virttype] [emulator] [arch] [machine] [--features] [--migratable] @@ -1005,7 +1005,7 @@ autostart **Syntax:** -.. code-block:: +:: autostart [--disable] domain @@ -1020,7 +1020,7 @@ blkdeviotune **Syntax:** -.. code-block:: +:: blkdeviotune domain device [[--config] [--live] | [--current]] [[total-bytes-sec] | [read-bytes-sec] [write-bytes-sec]] @@ -1103,7 +1103,7 @@ blkiotune **Syntax:** -.. code-block:: +:: blkiotune domain [--weight weight] [--device-weights device-weights] [--device-read-iops-sec device-read-iops-sec] @@ -1165,7 +1165,7 @@ blockcommit **Syntax:** -.. code-block:: +:: blockcommit domain path [bandwidth] [--bytes] [base] [--shallow] [top] [--delete] [--keep-relative] @@ -1223,7 +1223,7 @@ blockcopy **Syntax:** -.. code-block:: +:: blockcopy domain path { dest [format] [--blockdev] | --xml file } [--shallow] [--reuse-external] [bandwidth] @@ -1295,7 +1295,7 @@ blockjob **Syntax:** -.. code-block:: +:: blockjob domain path { [--abort] [--async] [--pivot] | [--info] [--raw] [--bytes] | [bandwidth] } @@ -1345,7 +1345,7 @@ blockpull **Syntax:** -.. code-block:: +:: blockpull domain path [bandwidth] [--bytes] [base] [--wait [--verbose] [--timeout seconds] [--async]] @@ -1386,7 +1386,7 @@ blockresize **Syntax:** -.. code-block:: +:: blockresize domain path size @@ -1407,7 +1407,7 @@ console **Syntax:** -.. code-block:: +:: console domain [devname] [--safe] [--force] @@ -1428,7 +1428,7 @@ cpu-stats **Syntax:** -.. code-block:: +:: cpu-stats domain [--total] [start] [count] @@ -1444,7 +1444,7 @@ create **Syntax:** -.. code-block:: +:: create FILE [--console] [--paused] [--autodestroy] [--pass-fds N,M,...] [--validate] @@ -1475,7 +1475,7 @@ is only supported with container based virtualization. #. prepare a template from an existing domain (skip directly to 3a if writing one from scratch) - .. code-block:: + :: # virsh dumpxml <domain> > domain.xml @@ -1484,7 +1484,7 @@ is only supported with container based virtualization. a. DO CHANGE! <name> and <uuid> (<uuid> can also be removed), or b. DON'T CHANGE! either <name> or <uuid> - .. code-block:: + :: # $EDITOR domain.xml @@ -1495,7 +1495,7 @@ is only supported with container based virtualization. b. an existing persistent guest will run with a modified one-time configuration - .. code-block:: + :: # virsh create domain.xml @@ -1505,7 +1505,7 @@ define **Syntax:** -.. code-block:: +:: define FILE [--validate] @@ -1521,7 +1521,7 @@ desc **Syntax:** -.. code-block:: +:: desc domain [[--live] [--config] | [--current]] [--title] [--edit] [--new-desc @@ -1553,7 +1553,7 @@ destroy **Syntax:** -.. code-block:: +:: destroy domain [--graceful] @@ -1581,7 +1581,7 @@ domblkerror **Syntax:** -.. code-block:: +:: domblkerror domain @@ -1597,7 +1597,7 @@ domblkinfo **Syntax:** -.. code-block:: +:: domblkinfo domain [block-device --all] [--human] @@ -1617,7 +1617,7 @@ domblklist **Syntax:** -.. code-block:: +:: domblklist domain [--inactive] [--details] @@ -1637,7 +1637,7 @@ domblkstat **Syntax:** -.. code-block:: +:: domblkstat domain [block-device] [--human] @@ -1674,7 +1674,7 @@ domblkthreshold **Syntax:** -.. code-block:: +:: domblkthreshold domain dev threshold @@ -1689,7 +1689,7 @@ domcontrol **Syntax:** -.. code-block:: +:: domcontrol domain @@ -1703,7 +1703,7 @@ domdisplay **Syntax:** -.. code-block:: +:: domdisplay domain [--include-password] [[--type] type] [--all] @@ -1720,7 +1720,7 @@ domfsfreeze **Syntax:** -.. code-block:: +:: domfsfreeze domain [[--mountpoint] mountpoint...] @@ -1742,7 +1742,7 @@ domfsinfo **Syntax:** -.. code-block:: +:: domfsinfo domain @@ -1759,7 +1759,7 @@ domfsthaw **Syntax:** -.. code-block:: +:: domfsthaw domain [[--mountpoint] mountpoint...] @@ -1776,7 +1776,7 @@ domfstrim **Syntax:** -.. code-block:: +:: domfstrim domain [--minimum bytes] [--mountpoint mountPoint] @@ -1797,7 +1797,7 @@ domhostname **Syntax:** -.. code-block:: +:: domhostname domain [--source lease|agent] @@ -1814,7 +1814,7 @@ domid **Syntax:** -.. code-block:: +:: domid domain-name-or-uuid @@ -1826,7 +1826,7 @@ domif-getlink **Syntax:** -.. code-block:: +:: domif-getlink domain interface-device [--config] @@ -1842,7 +1842,7 @@ domif-setlink **Syntax:** -.. code-block:: +:: domif-setlink domain interface-device state [--config] @@ -1858,7 +1858,7 @@ domifaddr **Syntax:** -.. code-block:: +:: domifaddr domain [interface] [--full] [--source lease|agent|arp] @@ -1885,7 +1885,7 @@ backup-begin **Syntax:** -.. code-block:: +:: backup-begin domain [backupxml] [checkpointxml] [--reuse-external] @@ -1919,7 +1919,7 @@ backup-dumpxml **Syntax:** -.. code-block:: +:: backup-dumpxml domain @@ -1931,7 +1931,7 @@ domiflist **Syntax:** -.. code-block:: +:: domiflist domain [--inactive] @@ -1948,7 +1948,7 @@ domifstat **Syntax:** -.. code-block:: +:: domifstat domain interface-device @@ -1965,7 +1965,7 @@ domiftune **Syntax:** -.. code-block:: +:: domiftune domain interface-device [[--config] [--live] | [--current]] [*--inbound average,peak,burst,floor*] @@ -2000,7 +2000,7 @@ dominfo **Syntax:** -.. code-block:: +:: dominfo domain @@ -2012,7 +2012,7 @@ domjobabort **Syntax:** -.. code-block:: +:: domjobabort domain @@ -2024,7 +2024,7 @@ domjobinfo **Syntax:** -.. code-block:: +:: domjobinfo domain [--completed [--keep-completed]] [--anystats] [--rawstats] @@ -2051,7 +2051,7 @@ dommemstat **Syntax:** -.. code-block:: +:: dommemstat domain [--period seconds] [[--config] [--live] | [--current]] @@ -2106,7 +2106,7 @@ domname **Syntax:** -.. code-block:: +:: domname domain-id-or-uuid @@ -2118,7 +2118,7 @@ dompmsuspend **Syntax:** -.. code-block:: +:: dompmsuspend domain target [--duration] @@ -2149,7 +2149,7 @@ dompmwakeup **Syntax:** -.. code-block:: +:: dompmwakeup domain @@ -2164,7 +2164,7 @@ domrename **Syntax:** -.. code-block:: +:: domrename domain new-name @@ -2179,7 +2179,7 @@ domstate **Syntax:** -.. code-block:: +:: domstate domain [--reason] @@ -2192,7 +2192,7 @@ domstats **Syntax:** -.. code-block:: +:: domstats [--raw] [--enforce] [--backing] [--nowait] [--state] [--cpu-total] [--balloon] [--vcpu] [--interface] @@ -2426,7 +2426,7 @@ domtime **Syntax:** -.. code-block:: +:: domtime domain { [--now] [--pretty] [--sync] [--time time] } @@ -2451,7 +2451,7 @@ domuuid **Syntax:** -.. code-block:: +:: domuuid domain-name-or-id @@ -2463,7 +2463,7 @@ domxml-from-native **Syntax:** -.. code-block:: +:: domxml-from-native format config @@ -2481,7 +2481,7 @@ domxml-to-native **Syntax:** -.. code-block:: +:: domxml-to-native format { [--xml] xml | --domain domain-name-or-id-or-uuid } @@ -2496,7 +2496,7 @@ dump **Syntax:** -.. code-block:: +:: dump domain corefilepath [--bypass-cache] { [--live] | [--crash] | [--reset] } @@ -2538,7 +2538,7 @@ dumpxml **Syntax:** -.. code-block:: +:: dumpxml domain [--inactive] [--security-info] [--update-cpu] [--migratable] @@ -2559,7 +2559,7 @@ edit **Syntax:** -.. code-block:: +:: edit domain @@ -2568,7 +2568,7 @@ next boot of the guest. This is equivalent to: -.. code-block:: +:: virsh dumpxml --inactive --security-info domain > domain.xml vi domain.xml (or make changes with your other text editor) @@ -2585,7 +2585,7 @@ emulatorpin **Syntax:** -.. code-block:: +:: emulatorpin domain [cpulist] [[--live] [--config] | [--current]] @@ -2608,7 +2608,7 @@ event **Syntax:** -.. code-block:: +:: event {[domain] { event | --all } [--loop] [--timeout seconds] [--timestamp] | --list} @@ -2635,7 +2635,7 @@ guest-agent-timeout **Syntax:** -.. code-block:: +:: guest-agent-timeout domain [--timeout value] @@ -2655,7 +2655,7 @@ guestinfo **Syntax:** -.. code-block:: +:: guestinfo domain [--user] [--os] [--timezone] [--hostname] [--filesystem] @@ -2731,7 +2731,7 @@ guestvcpus **Syntax:** -.. code-block:: +:: guestvcpus domain [[--enable] | [--disable]] [cpulist] @@ -2750,7 +2750,7 @@ iothreadadd **Syntax:** -.. code-block:: +:: iothreadadd domain iothread_id [[--config] [--live] | [--current]] @@ -2770,7 +2770,7 @@ iothreaddel **Syntax:** -.. code-block:: +:: iothreaddel domain iothread_id [[--config] [--live] | [--current]] @@ -2792,7 +2792,7 @@ iothreadinfo **Syntax:** -.. code-block:: +:: iothreadinfo domain [[--live] [--config] | [--current]] @@ -2813,7 +2813,7 @@ iothreadpin **Syntax:** -.. code-block:: +:: iothreadpin domain iothread cpulist [[--live] [--config] | [--current]] @@ -2846,7 +2846,7 @@ iothreadset **Syntax:** -.. code-block:: +:: iothreadset domain iothread_id [[--poll-max-ns ns] [--poll-grow factor] [--poll-shrink divisor]] @@ -2878,7 +2878,7 @@ managedsave **Syntax:** -.. code-block:: +:: managedsave domain [--bypass-cache] [{--running | --paused}] [--verbose] @@ -2907,7 +2907,7 @@ managedsave-define **Syntax:** -.. code-block:: +:: managedsave-define domain xml [{--running | --paused}] @@ -2927,7 +2927,7 @@ managedsave-dumpxml **Syntax:** -.. code-block:: +:: managedsave-dumpxml domain [--security-info] @@ -2941,7 +2941,7 @@ managedsave-edit **Syntax:** -.. code-block:: +:: managedsave-edit domain [{--running | --paused}] @@ -2955,7 +2955,7 @@ will allow overriding which state the ``restore`` should use. This is equivalent to: -.. code-block:: +:: virsh managedsave-dumpxml domain-name > state-file.xml vi state-file.xml (or make changes with your other text editor) @@ -2972,7 +2972,7 @@ managedsave-remove **Syntax:** -.. code-block:: +:: managedsave-remove domain @@ -2985,7 +2985,7 @@ maxvcpus **Syntax:** -.. code-block:: +:: maxvcpus [type] @@ -2999,7 +2999,7 @@ memtune **Syntax:** -.. code-block:: +:: memtune domain [--hard-limit size] [--soft-limit size] [--swap-hard-limit size] [--min-guarantee size] [[--config] [--live] | [--current]] @@ -3058,7 +3058,7 @@ metadata **Syntax:** -.. code-block:: +:: metadata domain [[--live] [--config] | [--current]] [--edit] [uri] [key] [set] [--remove] @@ -3097,7 +3097,7 @@ migrate **Syntax:** -.. code-block:: +:: migrate [--live] [--offline] [--direct] [--p2p [--tunnelled]] [--persistent] [--undefinesource] [--suspend] [--copy-storage-all] @@ -3240,7 +3240,7 @@ and/or libvirt does not have network access to the remote side you can use a UNIX transport in the URI and specify a socket path in the query, for example with the qemu driver you could use this: -.. code-block:: +:: qemu+unix:///system?socket=/path/to/socket @@ -3274,7 +3274,7 @@ There are a few scenarios where specifying *migrateuri* may help: should not guess a *migrateuri* and it should be specified using UNIX socket path URI: -.. code-block:: +:: unix:///path/to/socket @@ -3289,7 +3289,7 @@ connected to and needs to connect through a proxy, *graphicsuri* may be used to specify the address the client should connect to. The URI is formed as follows: -.. code-block:: +:: protocol://hostname[:port]/[?parameters] @@ -3297,7 +3297,7 @@ where protocol is either "spice" or "vnc" and parameters is a list of protocol specific parameters separated by '&'. Currently recognized parameters are "tlsPort" and "tlsSubject". For example, -.. code-block:: +:: spice://target.host.com:1234/?tlsPort=4567 @@ -3327,7 +3327,7 @@ migrate-compcache **Syntax:** -.. code-block:: +:: migrate-compcache domain [--size bytes] @@ -3347,7 +3347,7 @@ migrate-getmaxdowntime **Syntax:** -.. code-block:: +:: migrate-getmaxdowntime domain @@ -3362,7 +3362,7 @@ migrate-getspeed **Syntax:** -.. code-block:: +:: migrate-getspeed domain [--postcopy] @@ -3376,7 +3376,7 @@ migrate-postcopy **Syntax:** -.. code-block:: +:: migrate-postcopy domain @@ -3389,7 +3389,7 @@ migrate-setmaxdowntime **Syntax:** -.. code-block:: +:: migrate-setmaxdowntime domain downtime @@ -3403,7 +3403,7 @@ migrate-setspeed **Syntax:** -.. code-block:: +:: migrate-setspeed domain bandwidth [--postcopy] @@ -3421,7 +3421,7 @@ numatune **Syntax:** -.. code-block:: +:: numatune domain [--mode mode] [--nodeset nodeset] [[--config] [--live] | [--current]] @@ -3459,7 +3459,7 @@ perf **Syntax:** -.. code-block:: +:: perf domain [--enable eventSpec] [--disable eventSpec] [[--config] [--live] | [--current]] @@ -3548,7 +3548,7 @@ reboot **Syntax:** -.. code-block:: +:: reboot domain [--mode MODE-LIST] @@ -3574,7 +3574,7 @@ reset **Syntax:** -.. code-block:: +:: reset domain @@ -3590,7 +3590,7 @@ restore **Syntax:** -.. code-block:: +:: restore state-file [--bypass-cache] [--xml file] [{--running | --paused}] @@ -3622,7 +3622,7 @@ resume **Syntax:** -.. code-block:: +:: resume domain @@ -3636,7 +3636,7 @@ save **Syntax:** -.. code-block:: +:: save domain state-file [--bypass-cache] [--xml file] [{--running | --paused}] [--verbose] @@ -3680,7 +3680,7 @@ save-image-define **Syntax:** -.. code-block:: +:: save-image-define file xml [{--running | --paused}] @@ -3702,7 +3702,7 @@ save-image-dumpxml **Syntax:** -.. code-block:: +:: save-image-dumpxml file [--security-info] @@ -3716,7 +3716,7 @@ save-image-edit **Syntax:** -.. code-block:: +:: save-image-edit file [{--running | --paused}] @@ -3730,7 +3730,7 @@ will allow overriding which state the ``restore`` should use. This is equivalent to: -.. code-block:: +:: virsh save-image-dumpxml state-file > state-file.xml vi state-file.xml (or make changes with your other text editor) @@ -3747,7 +3747,7 @@ schedinfo **Syntax:** -.. code-block:: +:: schedinfo domain [[--config] [--live] | [--current]] [[--set] parameter=value]... schedinfo [--weight number] [--cap number] domain @@ -3790,7 +3790,7 @@ screenshot **Syntax:** -.. code-block:: +:: screenshot domain [imagefilepath] [--screen screenID] @@ -3807,7 +3807,7 @@ send-key **Syntax:** -.. code-block:: +:: send-key domain [--codeset codeset] [--holdtime holdtime] keycode... @@ -3904,7 +3904,7 @@ distinct keypresses, you must use multiple send-key invocations. **Examples:** -.. code-block:: +:: # send three strokes 'k', 'e', 'y', using xt codeset. these # are all pressed simultaneously and may be received by the guest @@ -3924,7 +3924,7 @@ send-process-signal **Syntax:** -.. code-block:: +:: send-process-signal domain-id pid signame @@ -3935,7 +3935,7 @@ domain namespace. The *signame* argument may be either an integer signal constant number, or one of the symbolic names: -.. code-block:: +:: "nop", "hup", "int", "quit", "ill", "trap", "abrt", "bus", "fpe", "kill", @@ -3955,7 +3955,7 @@ may be in uppercase or lowercase. **Examples:** -.. code-block:: +:: virsh send-process-signal myguest 1 15 virsh send-process-signal myguest 1 term @@ -3968,7 +3968,7 @@ set-lifecycle-action **Syntax:** -.. code-block:: +:: set-lifecycle-action domain type action [[--config] [--live] | [--current]] @@ -3985,7 +3985,7 @@ set-user-password **Syntax:** -.. code-block:: +:: set-user-password domain user password [--encrypted] @@ -4003,7 +4003,7 @@ setmaxmem **Syntax:** -.. code-block:: +:: setmaxmem domain size [[--config] [--live] | [--current]] @@ -4035,7 +4035,7 @@ setmem **Syntax:** -.. code-block:: +:: setmem domain size [[--config] [--live] | [--current]] @@ -4071,7 +4071,7 @@ setvcpus **Syntax:** -.. code-block:: +:: setvcpus domain count [--maximum] [[--config] [--live] | [--current]] [--guest] [--hotpluggable] @@ -4123,7 +4123,7 @@ setvcpu **Syntax:** -.. code-block:: +:: setvcpu domain vcpulist [--enable] | [--disable] [[--live] [--config] | [--current]] @@ -4151,7 +4151,7 @@ shutdown **Syntax:** -.. code-block:: +:: shutdown domain [--mode MODE-LIST] @@ -4183,7 +4183,7 @@ start **Syntax:** -.. code-block:: +:: start domain-name-or-uuid [--console] [--paused] [--autodestroy] [--bypass-cache] [--force-boot] @@ -4212,7 +4212,7 @@ suspend **Syntax:** -.. code-block:: +:: suspend domain @@ -4225,7 +4225,7 @@ ttyconsole **Syntax:** -.. code-block:: +:: ttyconsole domain @@ -4238,7 +4238,7 @@ undefine **Syntax:** -.. code-block:: +:: undefine domain [--managed-save] [--snapshots-metadata] [--checkpoints-metadata] [--nvram] [--keep-nvram] @@ -4304,7 +4304,7 @@ vcpucount **Syntax:** -.. code-block:: +:: vcpucount domain [{--maximum | --active} {--config | --live | --current}] [--guest] @@ -4335,7 +4335,7 @@ vcpuinfo **Syntax:** -.. code-block:: +:: vcpuinfo domain [--pretty] @@ -4346,7 +4346,7 @@ With *--pretty*, cpu affinities are shown as ranges. **Example:** -.. code-block:: +:: $ virsh vcpuinfo fedora VCPU: 0 @@ -4399,7 +4399,7 @@ vcpupin **Syntax:** -.. code-block:: +:: vcpupin domain [vcpu] [cpulist] [[--live] [--config] | [--current]] @@ -4428,7 +4428,7 @@ vncdisplay **Syntax:** -.. code-block:: +:: vncdisplay domain @@ -4451,7 +4451,7 @@ attach-device **Syntax:** -.. code-block:: +:: attach-device domain FILE [[[--live] [--config] | [--current]] | [--persistent]] @@ -4488,7 +4488,7 @@ attach-disk **Syntax:** -.. code-block:: +:: attach-disk domain source target [[[--live] [--config] | [--current]] | [--persistent]] [--targetbus bus] @@ -4556,7 +4556,7 @@ attach-interface **Syntax:** -.. code-block:: +:: attach-interface domain type source [[[--live] [--config] | [--current]] | [--persistent]] @@ -4648,7 +4648,7 @@ detach-device **Syntax:** -.. code-block:: +:: detach-device domain FILE [[[--live] [--config] | [--current]] | [--persistent]] @@ -4695,7 +4695,7 @@ detach-device-alias **Syntax:** -.. code-block:: +:: detach-device-alias domain alias [[[--live] [--config] | [--current]]]] @@ -4717,7 +4717,7 @@ detach-disk **Syntax:** -.. code-block:: +:: detach-disk domain target [[[--live] [--config] | [--current]] | [--persistent]] [--print-xml] @@ -4751,7 +4751,7 @@ detach-interface **Syntax:** -.. code-block:: +:: detach-interface domain type [--mac mac] [[[--live] [--config] | [--current]] | [--persistent]] @@ -4784,7 +4784,7 @@ update-device **Syntax:** -.. code-block:: +:: update-device domain file [--force] [[[--live] [--config] | [--current]] | [--persistent]] @@ -4819,7 +4819,7 @@ change-media **Syntax:** -.. code-block:: +:: change-media domain path [--eject] [--insert] [--update] [source] [--force] [[--live] [--config] | @@ -4889,7 +4889,7 @@ nodedev-create **Syntax:** -.. code-block:: +:: nodedev-create FILE @@ -4905,7 +4905,7 @@ nodedev-destroy **Syntax:** -.. code-block:: +:: nodedev-destroy device @@ -4920,7 +4920,7 @@ nodedev-detach **Syntax:** -.. code-block:: +:: nodedev-detach nodedev [--driver backend_driver] @@ -4940,7 +4940,7 @@ nodedev-dumpxml **Syntax:** -.. code-block:: +:: nodedev-dumpxml device @@ -4957,7 +4957,7 @@ nodedev-list **Syntax:** -.. code-block:: +:: nodedev-list cap --tree @@ -4976,7 +4976,7 @@ nodedev-reattach **Syntax:** -.. code-block:: +:: nodedev-reattach nodedev @@ -4991,7 +4991,7 @@ nodedev-reset **Syntax:** -.. code-block:: +:: nodedev-reset nodedev @@ -5006,7 +5006,7 @@ nodedev-event **Syntax:** -.. code-block:: +:: nodedev-event {[nodedev] event [--loop] [--timeout seconds] [--timestamp] | --list} @@ -5042,7 +5042,7 @@ net-autostart **Syntax:** -.. code-block:: +:: net-autostart network [--disable] @@ -5055,7 +5055,7 @@ net-create **Syntax:** -.. code-block:: +:: net-create file @@ -5070,7 +5070,7 @@ net-define **Syntax:** -.. code-block:: +:: net-define file @@ -5083,7 +5083,7 @@ net-destroy **Syntax:** -.. code-block:: +:: net-destroy network @@ -5096,7 +5096,7 @@ net-dumpxml **Syntax:** -.. code-block:: +:: net-dumpxml network [--inactive] @@ -5111,7 +5111,7 @@ net-edit **Syntax:** -.. code-block:: +:: net-edit network @@ -5119,7 +5119,7 @@ Edit the XML configuration file for a network. This is equivalent to: -.. code-block:: +:: virsh net-dumpxml --inactive network > network.xml vi network.xml (or make changes with your other text editor) @@ -5136,7 +5136,7 @@ net-event **Syntax:** -.. code-block:: +:: net-event {[network] event [--loop] [--timeout seconds] [--timestamp] | --list} @@ -5161,7 +5161,7 @@ net-info **Syntax:** -.. code-block:: +:: net-info network @@ -5173,7 +5173,7 @@ net-list **Syntax:** -.. code-block:: +:: net-list [--inactive | --all] { [--table] | --name | --uuid } @@ -5204,7 +5204,7 @@ net-name **Syntax:** -.. code-block:: +:: net-name network-UUID @@ -5216,7 +5216,7 @@ net-start **Syntax:** -.. code-block:: +:: net-start network @@ -5228,7 +5228,7 @@ net-undefine **Syntax:** -.. code-block:: +:: net-undefine network @@ -5241,7 +5241,7 @@ net-uuid **Syntax:** -.. code-block:: +:: net-uuid network-name @@ -5253,7 +5253,7 @@ net-update **Syntax:** -.. code-block:: +:: net-update network command section xml [--parent-index index] [[--live] [--config] | [--current]] @@ -5301,7 +5301,7 @@ net-dhcp-leases **Syntax:** -.. code-block:: +:: net-dhcp-leases network [mac] @@ -5326,7 +5326,7 @@ net-port-list **Syntax:** -.. code-block:: +:: net-port-list { [--table] | --uuid } network @@ -5343,7 +5343,7 @@ net-port-create **Syntax:** -.. code-block:: +:: net-port-create network file @@ -5356,7 +5356,7 @@ net-port-dumpxml **Syntax:** -.. code-block:: +:: net-port-dumpxml network port @@ -5368,7 +5368,7 @@ net-port-delete **Syntax:** -.. code-block:: +:: net-port-delete network port @@ -5397,7 +5397,7 @@ iface-bridge **Syntax:** -.. code-block:: +:: iface-bridge interface bridge [--no-stp] [delay] [--no-start] @@ -5416,7 +5416,7 @@ iface-define **Syntax:** -.. code-block:: +:: iface-define file @@ -5429,7 +5429,7 @@ iface-destroy **Syntax:** -.. code-block:: +:: iface-destroy interface @@ -5442,7 +5442,7 @@ iface-dumpxml **Syntax:** -.. code-block:: +:: iface-dumpxml interface [--inactive] @@ -5456,7 +5456,7 @@ iface-edit **Syntax:** -.. code-block:: +:: iface-edit interface @@ -5464,7 +5464,7 @@ Edit the XML configuration file for a host interface. This is equivalent to: -.. code-block:: +:: virsh iface-dumpxml iface > iface.xml vi iface.xml (or make changes with your other text editor) @@ -5481,7 +5481,7 @@ iface-list **Syntax:** -.. code-block:: +:: iface-list [--inactive | --all] @@ -5495,7 +5495,7 @@ iface-name **Syntax:** -.. code-block:: +:: iface-name interface @@ -5510,7 +5510,7 @@ iface-mac **Syntax:** -.. code-block:: +:: iface-mac interface @@ -5524,7 +5524,7 @@ iface-start **Syntax:** -.. code-block:: +:: iface-start interface @@ -5536,7 +5536,7 @@ iface-unbridge **Syntax:** -.. code-block:: +:: iface-unbridge bridge [--no-start] @@ -5554,7 +5554,7 @@ iface-undefine **Syntax:** -.. code-block:: +:: iface-undefine interface @@ -5566,7 +5566,7 @@ iface-begin **Syntax:** -.. code-block:: +:: iface-begin @@ -5584,7 +5584,7 @@ iface-commit **Syntax:** -.. code-block:: +:: iface-commit @@ -5598,7 +5598,7 @@ iface-rollback **Syntax:** -.. code-block:: +:: iface-rollback @@ -5624,7 +5624,7 @@ find-storage-pool-sources **Syntax:** -.. code-block:: +:: find-storage-pool-sources type [srcSpec] @@ -5662,7 +5662,7 @@ find-pool-sources-as **Syntax:** -.. code-block:: +:: find-storage-pool-sources-as type [host] [port] [initiator] @@ -5686,7 +5686,7 @@ pool-autostart **Syntax:** -.. code-block:: +:: pool-autostart pool-or-uuid [--disable] @@ -5698,7 +5698,7 @@ pool-build **Syntax:** -.. code-block:: +:: pool-build pool-or-uuid [--overwrite] [--no-overwrite] @@ -5740,7 +5740,7 @@ pool-create **Syntax:** -.. code-block:: +:: pool-create file [--build] [[--overwrite] | [--no-overwrite]] @@ -5758,7 +5758,7 @@ pool-create-as **Syntax:** -.. code-block:: +:: pool-create-as name type [--source-host hostname] [--source-path path] [--source-dev path] @@ -5848,7 +5848,7 @@ pool-define **Syntax:** -.. code-block:: +:: pool-define file @@ -5861,7 +5861,7 @@ pool-define-as **Syntax:** -.. code-block:: +:: pool-define-as name type [--source-host hostname] [--source-path path] [--source-dev path] @@ -5887,7 +5887,7 @@ pool-destroy **Syntax:** -.. code-block:: +:: pool-destroy pool-or-uuid @@ -5902,7 +5902,7 @@ pool-delete **Syntax:** -.. code-block:: +:: pool-delete pool-or-uuid @@ -5916,7 +5916,7 @@ pool-dumpxml **Syntax:** -.. code-block:: +:: pool-dumpxml [--inactive] pool-or-uuid @@ -5930,7 +5930,7 @@ pool-edit **Syntax:** -.. code-block:: +:: pool-edit pool-or-uuid @@ -5938,7 +5938,7 @@ Edit the XML configuration file for a storage pool. This is equivalent to: -.. code-block:: +:: virsh pool-dumpxml pool > pool.xml vi pool.xml (or make changes with your other text editor) @@ -5955,7 +5955,7 @@ pool-info **Syntax:** -.. code-block:: +:: pool-info [--bytes] pool-or-uuid @@ -5968,7 +5968,7 @@ pool-list **Syntax:** -.. code-block:: +:: pool-list [--inactive] [--all] [--persistent] [--transient] @@ -6008,7 +6008,7 @@ pool-name **Syntax:** -.. code-block:: +:: pool-name uuid @@ -6020,7 +6020,7 @@ pool-refresh **Syntax:** -.. code-block:: +:: pool-refresh pool-or-uuid @@ -6032,7 +6032,7 @@ pool-start **Syntax:** -.. code-block:: +:: pool-start pool-or-uuid [--build] [[--overwrite] | [--no-overwrite]] @@ -6060,7 +6060,7 @@ pool-undefine **Syntax:** -.. code-block:: +:: pool-undefine pool-or-uuid @@ -6072,7 +6072,7 @@ pool-uuid **Syntax:** -.. code-block:: +:: pool-uuid pool @@ -6084,7 +6084,7 @@ pool-event **Syntax:** -.. code-block:: +:: pool-event {[pool] event [--loop] [--timeout seconds] [--timestamp] | --list} @@ -6112,7 +6112,7 @@ vol-create **Syntax:** -.. code-block:: +:: vol-create pool-or-uuid FILE [--prealloc-metadata] @@ -6131,7 +6131,7 @@ only slightly higher initial disk space usage. **Example:** -.. code-block:: +:: virsh vol-dumpxml --pool storagepool1 appvolume1 > newvolume.xml vi newvolume.xml (or make changes with your other text editor) @@ -6143,7 +6143,7 @@ vol-create-from **Syntax:** -.. code-block:: +:: vol-create-from pool-or-uuid FILE vol-name-or-key-or-path [--inputpool pool-or-uuid] [--prealloc-metadata] [--reflink] @@ -6174,7 +6174,7 @@ vol-create-as **Syntax:** -.. code-block:: +:: vol-create-as pool-or-uuid name capacity [--allocation size] [--format string] [--backing-vol vol-name-or-key-or-path] @@ -6223,7 +6223,7 @@ vol-clone **Syntax:** -.. code-block:: +:: vol-clone vol-name-or-key-or-path name [--pool pool-or-uuid] [--prealloc-metadata] [--reflink] @@ -6256,7 +6256,7 @@ vol-delete **Syntax:** -.. code-block:: +:: vol-delete vol-name-or-key-or-path [--pool pool-or-uuid] [--delete-snapshots] @@ -6280,7 +6280,7 @@ vol-upload **Syntax:** -.. code-block:: +:: vol-upload vol-name-or-key-or-path local-file [--pool pool-or-uuid] [--offset bytes] @@ -6318,7 +6318,7 @@ vol-download **Syntax:** -.. code-block:: +:: vol-download vol-name-or-key-or-path local-file [--pool pool-or-uuid] [--offset bytes] [--length bytes] @@ -6349,7 +6349,7 @@ vol-wipe **Syntax:** -.. code-block:: +:: vol-wipe vol-name-or-key-or-path [--pool pool-or-uuid] [--algorithm algorithm] @@ -6408,7 +6408,7 @@ vol-dumpxml **Syntax:** -.. code-block:: +:: vol-dumpxml vol-name-or-key-or-path [--pool pool-or-uuid] @@ -6428,7 +6428,7 @@ vol-info **Syntax:** -.. code-block:: +:: vol-info vol-name-or-key-or-path [--pool pool-or-uuid] [--bytes] [--physical] @@ -6457,7 +6457,7 @@ vol-list **Syntax:** -.. code-block:: +:: vol-list [--pool pool-or-uuid] [--details] @@ -6474,7 +6474,7 @@ vol-pool **Syntax:** -.. code-block:: +:: vol-pool vol-key-or-path [--uuid] @@ -6492,7 +6492,7 @@ vol-path **Syntax:** -.. code-block:: +:: vol-path vol-name-or-key [--pool pool-or-uuid] @@ -6511,7 +6511,7 @@ vol-name **Syntax:** -.. code-block:: +:: vol-name vol-key-or-path @@ -6525,7 +6525,7 @@ vol-key **Syntax:** -.. code-block:: +:: vol-key vol-name-or-path [--pool pool-or-uuid] @@ -6545,7 +6545,7 @@ vol-resize **Syntax:** -.. code-block:: +:: vol-resize vol-name-or-path capacity [--pool pool-or-uuid] [--allocate] [--delta] [--shrink] @@ -6590,7 +6590,7 @@ secret-define **Syntax:** -.. code-block:: +:: secret-define file @@ -6605,7 +6605,7 @@ secret-dumpxml **Syntax:** -.. code-block:: +:: secret-dumpxml secret @@ -6617,7 +6617,7 @@ secret-event **Syntax:** -.. code-block:: +:: secret-event {[secret] event [--loop] [--timeout seconds] [--timestamp] | --list} @@ -6642,7 +6642,7 @@ secret-set-value **Syntax:** -.. code-block:: +:: secret-set-value secret (--file filename [--plain] | --interactive | base64) @@ -6665,7 +6665,7 @@ secret-get-value **Syntax:** -.. code-block:: +:: secret-get-value [--plain] secret @@ -6682,7 +6682,7 @@ secret-undefine **Syntax:** -.. code-block:: +:: secret-undefine secret @@ -6696,7 +6696,7 @@ secret-list **Syntax:** -.. code-block:: +:: secret-list [--ephemeral] [--no-ephemeral] [--private] [--no-private] @@ -6723,7 +6723,7 @@ snapshot-create **Syntax:** -.. code-block:: +:: snapshot-create domain [xmlfile] {[--redefine [--current]] | [--no-metadata] [--halt] [--disk-only] [--reuse-external] @@ -6804,7 +6804,7 @@ snapshot-create-as **Syntax:** -.. code-block:: +:: snapshot-create-as domain {[--print-xml] [--no-metadata] [--halt] [--reuse-external]} [name] @@ -6843,7 +6843,7 @@ all three of *domain*, *name*, and *description* are also present. For example, a diskspec of "vda,snapshot=external,file=/path/to,,new" results in the following XML: -.. code-block:: +:: <disk name='vda' snapshot='external'> <source file='/path/to,new'/> @@ -6886,7 +6886,7 @@ snapshot-current **Syntax:** -.. code-block:: +:: snapshot-current domain {[--name] | [--security-info] | [snapshotname]} @@ -6905,7 +6905,7 @@ snapshot-edit **Syntax:** -.. code-block:: +:: snapshot-edit domain [snapshotname] [--current] {[--rename] | [--clone]} @@ -6917,7 +6917,7 @@ snapshot. This is equivalent to: -.. code-block:: +:: virsh snapshot-dumpxml dom name > snapshot.xml vi snapshot.xml (or make changes with your other text editor) @@ -6942,7 +6942,7 @@ snapshot-info **Syntax:** -.. code-block:: +:: snapshot-info domain {snapshot | --current} @@ -6955,7 +6955,7 @@ snapshot-list **Syntax:** -.. code-block:: +:: snapshot-list domain [--metadata] [--no-metadata] [{--parent | --roots | [{--tree | --name}]}] [--topological] @@ -7024,7 +7024,7 @@ snapshot-dumpxml **Syntax:** -.. code-block:: +:: snapshot-dumpxml domain snapshot [--security-info] @@ -7038,7 +7038,7 @@ snapshot-parent **Syntax:** -.. code-block:: +:: snapshot-parent domain {snapshot | --current} @@ -7051,7 +7051,7 @@ snapshot-revert **Syntax:** -.. code-block:: +:: snapshot-revert domain {snapshot | --current} [{--running | --paused}] [--force] @@ -7101,7 +7101,7 @@ snapshot-delete **Syntax:** -.. code-block:: +:: snapshot-delete domain {snapshot | --current} [--metadata] [{--children | --children-only}] @@ -7135,7 +7135,7 @@ checkpoint-create **Syntax:** -.. code-block:: +:: checkpoint-create domain [xmlfile] { --redefine | [--quiesce]} @@ -7174,7 +7174,7 @@ checkpoint-create-as **Syntax:** -.. code-block:: +:: checkpoint-create-as domain [--print-xml] [name] [description] [--quiesce] [--diskspec] diskspec]... @@ -7194,7 +7194,7 @@ all three of *domain*, *name*, and *description* are also present. For example, a diskspec of "vda,checkpoint=bitmap,bitmap=map1" results in the following XML: -.. code-block:: +:: <disk name='vda' checkpoint='bitmap' bitmap='map1'/> @@ -7212,7 +7212,7 @@ checkpoint-edit **Syntax:** -.. code-block:: +:: checkpoint-edit domain checkpointname @@ -7220,7 +7220,7 @@ Edit the XML configuration file for *checkpointname* of a domain. This is equivalent to: -.. code-block:: +:: virsh checkpoint-dumpxml dom name > checkpoint.xml vi checkpoint.xml (or make changes with your other text editor) @@ -7238,7 +7238,7 @@ checkpoint-info **Syntax:** -.. code-block:: +:: checkpoint-info domain checkpoint @@ -7250,7 +7250,7 @@ checkpoint-list **Syntax:** -.. code-block:: +:: checkpoint-list domain [{--parent | --roots | [{--tree | --name}]}] [--topological] @@ -7296,7 +7296,7 @@ checkpoint-dumpxml **Syntax:** -.. code-block:: +:: checkpoint-dumpxml domain checkpoint [--security-info] [--no-domain] [--size] @@ -7316,7 +7316,7 @@ checkpoint-parent **Syntax:** -.. code-block:: +:: checkpoint-parent domain checkpoint @@ -7328,7 +7328,7 @@ checkpoint-delete **Syntax:** -.. code-block:: +:: checkpoint-delete domain checkpoint [--metadata] [{--children | --children-only}] @@ -7365,7 +7365,7 @@ nwfilter-define **Syntax:** -.. code-block:: +:: nwfilter-define xmlfile @@ -7382,7 +7382,7 @@ nwfilter-undefine **Syntax:** -.. code-block:: +:: nwfilter-undefine nwfilter-name @@ -7395,7 +7395,7 @@ nwfilter-list **Syntax:** -.. code-block:: +:: nwfilter-list @@ -7407,7 +7407,7 @@ nwfilter-dumpxml **Syntax:** -.. code-block:: +:: nwfilter-dumpxml nwfilter-name @@ -7419,7 +7419,7 @@ nwfilter-edit **Syntax:** -.. code-block:: +:: nwfilter-edit nwfilter-name @@ -7427,7 +7427,7 @@ Edit the XML of a network filter. This is equivalent to: -.. code-block:: +:: virsh nwfilter-dumpxml myfilter > myfilter.xml vi myfilter.xml (or make changes with your other text editor) @@ -7458,7 +7458,7 @@ nwfilter-binding-create **Syntax:** -.. code-block:: +:: nwfilter-binding-create xmlfile @@ -7477,7 +7477,7 @@ nwfilter-binding-delete **Syntax:** -.. code-block:: +:: nwfilter-binding-delete port-name @@ -7495,7 +7495,7 @@ nwfilter-binding-list **Syntax:** -.. code-block:: +:: nwfilter-binding-list @@ -7507,7 +7507,7 @@ nwfilter-binding-dumpxml **Syntax:** -.. code-block:: +:: nwfilter-binding-dumpxml port-name @@ -7531,7 +7531,7 @@ qemu-attach **Syntax:** -.. code-block:: +:: qemu-attach pid @@ -7540,7 +7540,7 @@ The QEMU process must have been created with a monitor connection using the UNIX driver. Ideally the process will also have had the '-name' argument specified. -.. code-block:: +:: $ qemu-kvm -cdrom ~/demo.iso \ -monitor unix:/tmp/demo,server,nowait \ @@ -7561,7 +7561,7 @@ qemu-monitor-command **Syntax:** -.. code-block:: +:: qemu-monitor-command domain { [--hmp] | [--pretty] [--return-value] } command... @@ -7588,7 +7588,7 @@ qemu-agent-command **Syntax:** -.. code-block:: +:: qemu-agent-command domain [--timeout seconds | --async | --block] command... @@ -7606,7 +7606,7 @@ qemu-monitor-event **Syntax:** -.. code-block:: +:: qemu-monitor-event [domain] [--event event-name] [--loop] [--timeout seconds] [--pretty] [--regex] [--no-case] @@ -7637,7 +7637,7 @@ lxc-enter-namespace **Syntax:** -.. code-block:: +:: lxc-enter-namespace domain [--noseclabel] -- /path/to/binary [arg1, [arg2, ...]] diff --git a/docs/manpages/virt-admin.rst b/docs/manpages/virt-admin.rst index d5cb23a1c5..940a38bfce 100644 --- a/docs/manpages/virt-admin.rst +++ b/docs/manpages/virt-admin.rst @@ -28,7 +28,7 @@ as for monitoring and managing all clients connected to the daemon. The basic structure of most virt-admin usage is: -.. code-block:: +:: virt-admin [OPTION]... <command> [ARG]... @@ -107,7 +107,7 @@ help **Syntax:** -.. code-block:: +:: help [command-or-group] @@ -124,7 +124,7 @@ quit, exit **Syntax:** -.. code-block:: +:: quit exit @@ -136,7 +136,7 @@ version **Syntax:** -.. code-block:: +:: version @@ -146,7 +146,7 @@ the version of the daemon. **Example:** -.. code-block:: +:: $ virt-admin version Compiled against library: libvirt 1.2.21 @@ -160,7 +160,7 @@ cd **Syntax:** -.. code-block:: +:: cd [directory] @@ -175,7 +175,7 @@ pwd **Syntax:** -.. code-block:: +:: pwd @@ -187,7 +187,7 @@ connect **Syntax:** -.. code-block:: +:: connect [URI] @@ -206,7 +206,7 @@ uri **Syntax:** -.. code-block:: +:: uri @@ -230,7 +230,7 @@ server-list **Syntax:** -.. code-block:: +:: server-list @@ -243,7 +243,7 @@ daemon-log-filters **Syntax:** -.. code-block:: +:: daemon-log-filters [--filters string] @@ -264,7 +264,7 @@ space. Each filter must conform to the form described in detail by To define a filter which suppresses all e.g. 'virObjectUnref' DEBUG messages, use the following: -.. code-block:: +:: $ virt-admin daemon-log-filters "4:util.object" @@ -277,7 +277,7 @@ daemon-log-outouts **Syntax:** -.. code-block:: +:: daemon-log-outputs [--outputs string] @@ -298,13 +298,13 @@ space. Each output must conform to the form described in detail by To replace the current setting for logging outputs with one that writes to a file while logging errors only, the following could be used: -.. code-block:: +:: $ virt-admin daemon-log-outputs "4:file:<absolute_path_to_the_file>" To define multiple outputs at once they need to be delimited by spaces: -.. code-block:: +:: $ virt-admin daemon-log-outputs "4:stderr 2:syslog:<msg_ident>" @@ -320,7 +320,7 @@ server-threadpool-info **Syntax:** -.. code-block:: +:: server-threadpool-info server @@ -355,7 +355,7 @@ that, unlike tasks carried out by normal workers, are within libvirt's full control and libvirt guarantees that such a task cannot hang, thus will always finish. An example of such a task this would be destroying a domain: -.. code-block:: +:: $ virsh destroy <domain>. @@ -365,7 +365,7 @@ server-threadpool-set **Syntax:** -.. code-block:: +:: server-threadpool-set server [--min-workers count] [--max-workers count] [--priority-workers count] @@ -394,7 +394,7 @@ server-clients-info **Syntax:** -.. code-block:: +:: server-clients-info server @@ -407,7 +407,7 @@ runtime values, more specifically, the current number of clients connected to **Example:** -.. code-block:: +:: # virt-admin server-clients-info libvirtd nclients_max : 120 @@ -421,7 +421,7 @@ server-clients-set **Syntax:** -.. code-block:: +:: server-clients-set server [--max-clients count] [--max-unauth-clients count] @@ -447,7 +447,7 @@ server-update-tls **Syntax:** -.. code-block:: +:: server-update-tls server @@ -474,7 +474,7 @@ client-list **Syntax:** -.. code-block:: +:: client-list server @@ -488,7 +488,7 @@ client-info **Syntax:** -.. code-block:: +:: client-info server client @@ -504,7 +504,7 @@ enabled within daemon). **Examples:** -.. code-block:: +:: # virt-admin client-info libvirtd 1 id : 1 @@ -530,7 +530,7 @@ client-disconnect **Syntax:** -.. code-block:: +:: client-disconnect server client diff --git a/docs/manpages/virt-login-shell.rst b/docs/manpages/virt-login-shell.rst index 3833a3e912..bc0215294b 100644 --- a/docs/manpages/virt-login-shell.rst +++ b/docs/manpages/virt-login-shell.rst @@ -29,7 +29,7 @@ configured in ``/etc/libvirt/virt-login-shell.conf``. The basic structure of most ``virt-login-shell`` usage is: -.. code-block:: +:: virt-login-shell @@ -58,7 +58,7 @@ By default, ``virt-login-shell`` will execute the ``/bin/sh`` program for the user. You can modify this behaviour by defining the shell variable in ``/etc/libvirt/virt-login-shell.conf``. e.g. -.. code-block:: +:: shell = [ "/bin/bash" ] @@ -68,7 +68,7 @@ detect the shell from ``/etc/password`` inside the container. This should only be done if the container has a separate ``/etc`` directory from the host, otherwise it will end up recursively invoking ``virt-login-shell``. e.g. -.. code-block:: +:: auto_shell = 1 @@ -77,7 +77,7 @@ By default no users are allowed to use virt-login-shell, if you want to allow certain users to use virt-login-shell, you need to modify the allowed_users variable in /etc/libvirt/virt-login-shell.conf. e.g. -.. code-block:: +:: allowed_users = [ "tom", "dick", "harry" ] diff --git a/docs/manpages/virtlockd.rst b/docs/manpages/virtlockd.rst index ea37b25d05..8ca231d14f 100644 --- a/docs/manpages/virtlockd.rst +++ b/docs/manpages/virtlockd.rst @@ -120,14 +120,14 @@ EXAMPLES To retrieve the version of ``virtlockd``: -.. code-block:: +:: # virtlockd --version virtlockd (libvirt) 1.1.1 To start ``virtlockd``, instructing it to daemonize and create a PID file: -.. code-block:: +:: # virtlockd -d # ls -la @RUNSTATEDIR@/virtlockd.pid diff --git a/docs/manpages/virtlogd.rst b/docs/manpages/virtlogd.rst index edf8288230..4b749fe18e 100644 --- a/docs/manpages/virtlogd.rst +++ b/docs/manpages/virtlogd.rst @@ -121,14 +121,14 @@ EXAMPLES To retrieve the version of ``virtlogd``: -.. code-block:: +:: # virtlogd --version virtlogd (libvirt) 1.1.1 To start ``virtlogd``, instructing it to daemonize and create a PID file: -.. code-block:: +:: # virtlogd -d # ls -la @RUNSTATEDIR@/virtlogd.pid -- 2.26.2

2 1

[libvirt PATCH 0/4] vbox: use g_new0 (glib chronicles)
by Ján Tomko 05 Oct '20

05 Oct '20

Ján Tomko (4): vbox: use g_new0 in vboxDumpAudio vbox: invert condition in vboxSnapshotGetReadOnlyDisks vbox: refactor vboxNetworkGetXMLDesc a bit vbox: use g_new0 instead of VIR_ALLOC src/vbox/vbox_common.c | 119 ++++++++++++---------------------- src/vbox/vbox_network.c | 107 ++++++++++++++---------------- src/vbox/vbox_snapshot_conf.c | 48 ++++++-------- 3 files changed, 110 insertions(+), 164 deletions(-) -- 2.26.2

2 9

[libvirt PATCH 0/4] vz: use g_new0 (glib chronicles)
by Ján Tomko 05 Oct '20

05 Oct '20

Ján Tomko (4): vz: separate if conditions in vzEatCookie vz: vzEatCookie: use distinct 'tmp' variables vz: vzEatCookie: separate allocation vz: use g_new0 instead of VIR_ALLOC src/vz/vz_driver.c | 49 ++++++++++++++++++++++------------------------ src/vz/vz_sdk.c | 46 +++++++++++++------------------------------ src/vz/vz_utils.c | 3 +-- 3 files changed, 38 insertions(+), 60 deletions(-) -- 2.26.2

2 5

[libvirt PATCH] vmware: use g_new0 instead of VIR_ALLOC (glib chronicles)
by Ján Tomko 05 Oct '20

05 Oct '20

Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/vmware/vmware_driver.c | 6 ++--- src/vmx/vmx.c | 46 ++++++++++---------------------------- 2 files changed, 14 insertions(+), 38 deletions(-) diff --git a/src/vmware/vmware_driver.c b/src/vmware/vmware_driver.c index e82edf2a11..087664a341 100644 --- a/src/vmware/vmware_driver.c +++ b/src/vmware/vmware_driver.c @@ -97,8 +97,7 @@ vmwareDataAllocFunc(void *opaque G_GNUC_UNUSED) { vmwareDomainPtr dom; - if (VIR_ALLOC(dom) < 0) - return NULL; + dom = g_new0(vmwareDomain, 1); dom->vmxPath = NULL; dom->gui = true; @@ -184,8 +183,7 @@ vmwareConnectOpen(virConnectPtr conn, /* We now know the URI is definitely for this driver, so beyond * here, don't return DECLINED, always use ERROR */ - if (VIR_ALLOC(driver) < 0) - return VIR_DRV_OPEN_ERROR; + driver = g_new0(struct vmware_driver, 1); /* Find vmrun, which is what this driver uses to communicate to * the VMware hypervisor. We look this up first since we use it diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 9894d5c0ce..0e8a690d0d 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -637,8 +637,7 @@ virVMXEscapeHex(const char *string, char escape, const char *special) ++length; } - if (VIR_ALLOC_N(escaped, length) < 0) - return NULL; + escaped = g_new0(char, length); tmp1 = string; /* reading from this one */ tmp2 = escaped; /* writing to this one */ @@ -1150,8 +1149,7 @@ virVMXGatherSCSIControllers(virVMXContext *ctx, virDomainDefPtr def, int count = 0; int *autodetectedModels; - if (VIR_ALLOC_N(autodetectedModels, def->ndisks) < 0) - return -1; + autodetectedModels = g_new0(int, def->ndisks); for (i = 0; i < def->ncontrollers; ++i) { controller = def->controllers[i]; @@ -1611,9 +1609,7 @@ virVMXParseConfig(virVMXContext *ctx, /* FIXME */ /* def:graphics */ - if (VIR_ALLOC_N(def->graphics, 1) < 0) - goto cleanup; - + def->graphics = g_new0(virDomainGraphicsDefPtr, 1); def->ngraphics = 0; if (virVMXParseVNC(conf, &def->graphics[def->ngraphics]) < 0) @@ -1623,9 +1619,7 @@ virVMXParseConfig(virVMXContext *ctx, ++def->ngraphics; /* def:disks: 4 * 15 scsi + 2 * 2 ide + 2 floppy = 66 */ - if (VIR_ALLOC_N(def->disks, 66) < 0) - goto cleanup; - + def->disks = g_new0(virDomainDiskDefPtr, 66); def->ndisks = 0; /* def:disks (scsi) */ @@ -1733,9 +1727,7 @@ virVMXParseConfig(virVMXContext *ctx, if (sharedFolder_maxNum > 0) { int number; - if (VIR_ALLOC_N(def->fss, sharedFolder_maxNum) < 0) - goto cleanup; - + def->fss = g_new0(virDomainFSDefPtr, sharedFolder_maxNum); def->nfss = 0; for (number = 0; number < sharedFolder_maxNum; ++number) { @@ -1767,9 +1759,7 @@ virVMXParseConfig(virVMXContext *ctx, /* FIXME */ /* def:videos */ - if (VIR_ALLOC_N(def->videos, 1) < 0) - goto cleanup; - + def->videos = g_new0(virDomainVideoDefPtr, 1); def->nvideos = 0; if (virVMXParseSVGA(conf, &def->videos[def->nvideos]) < 0) @@ -1784,9 +1774,7 @@ virVMXParseConfig(virVMXContext *ctx, /* FIXME */ /* def:serials */ - if (VIR_ALLOC_N(def->serials, 4) < 0) - goto cleanup; - + def->serials = g_new0(virDomainChrDefPtr, 4); def->nserials = 0; for (port = 0; port < 4; ++port) { @@ -1800,9 +1788,7 @@ virVMXParseConfig(virVMXContext *ctx, } /* def:parallels */ - if (VIR_ALLOC_N(def->parallels, 3) < 0) - goto cleanup; - + def->parallels = g_new0(virDomainChrDefPtr, 3); def->nparallels = 0; for (port = 0; port < 3; ++port) { @@ -1819,10 +1805,7 @@ virVMXParseConfig(virVMXContext *ctx, if (ctx->datacenterPath || ctx->moref) { struct virVMXDomainDefNamespaceData *nsdata = NULL; - if (VIR_ALLOC(nsdata) < 0) { - virVMXDomainDefNamespaceFree(nsdata); - goto cleanup; - } + nsdata = g_new0(struct virVMXDomainDefNamespaceData, 1); nsdata->datacenterPath = g_strdup(ctx->datacenterPath); @@ -1891,9 +1874,7 @@ virVMXParseVNC(virConfPtr conf, virDomainGraphicsDefPtr *def) if (! enabled) return 0; - if (VIR_ALLOC(*def) < 0) - goto failure; - + *def = g_new0(virDomainGraphicsDef, 1); (*def)->type = VIR_DOMAIN_GRAPHICS_TYPE_VNC; if (virVMXGetConfigLong(conf, "RemoteDisplay.vnc.port", &port, -1, @@ -2588,8 +2569,7 @@ virVMXParseEthernet(virConfPtr conf, int controller, virDomainNetDefPtr *def) if (! present/* && ! startConnected*/) return 0; - if (VIR_ALLOC(*def) < 0) - return -1; + *def = g_new0(virDomainNetDef, 1); /* vmx:connectionType -> def:type */ if (virVMXGetConfigString(conf, connectionType_name, &connectionType, @@ -3040,9 +3020,7 @@ virVMXParseSVGA(virConfPtr conf, virDomainVideoDefPtr *def) return -1; } - if (VIR_ALLOC(*def) < 0) - return -1; - + *def = g_new0(virDomainVideoDef, 1); (*def)->type = VIR_DOMAIN_VIDEO_TYPE_VMVGA; /* vmx:vramSize */ -- 2.26.2

2 1

[libvirt PATCH] API: discourage usage of non-ListAll APIs
by Ján Tomko 05 Oct '20

05 Oct '20

They require the caller to provide the maximum number of array elements upfront, leading to either incomplete results or violations of the zero-one-infinity rule. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/libvirt-domain-snapshot.c | 6 ++++-- src/libvirt-domain.c | 8 ++++---- src/libvirt-interface.c | 6 ++++-- src/libvirt-network.c | 6 ++++-- src/libvirt-nodedev.c | 3 ++- src/libvirt-nwfilter.c | 3 +++ src/libvirt-secret.c | 3 +++ src/libvirt-storage.c | 9 ++++++--- 8 files changed, 30 insertions(+), 14 deletions(-) diff --git a/src/libvirt-domain-snapshot.c b/src/libvirt-domain-snapshot.c index f856e5b9b8..74d5e16281 100644 --- a/src/libvirt-domain-snapshot.c +++ b/src/libvirt-domain-snapshot.c @@ -378,8 +378,10 @@ virDomainSnapshotNum(virDomainPtr domain, unsigned int flags) * snapshots were listed if the return is less than @nameslen. Likewise, * you should be prepared for virDomainSnapshotLookupByName() to fail when * converting a name from this call into a snapshot object, if another - * connection deletes the snapshot in the meantime. For more control over - * the results, see virDomainListAllSnapshots(). + * connection deletes the snapshot in the meantime. + * + * The use of this function in new code is discouraged. Instead, use + * virDomainListAllSnapshots(). * * Returns the number of domain snapshots found or -1 in case of error. * The caller is responsible to call free() for each member of the array. diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 415482a526..03eca1196a 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -41,8 +41,8 @@ VIR_LOG_INIT("libvirt.domain"); * * Collect the list of active domains, and store their IDs in array @ids * - * For inactive domains, see virConnectListDefinedDomains(). For more - * control over the results, see virConnectListAllDomains(). + * The use of this function in new code is discouraged. Instead, use + * virConnectListAllDomains(). * * Returns the number of domains found or -1 in case of error. Note that * this command is inherently racy; a domain can be started between a @@ -6366,8 +6366,8 @@ virConnectNumOfDefinedDomains(virConnectPtr conn) * list the defined but inactive domains, stores the pointers to the names * in @names * - * For active domains, see virConnectListDomains(). For more control over - * the results, see virConnectListAllDomains(). + * The use of this function in new code is discouraged. Instead, use + * virConnectListAllDomains(). * * Returns the number of names provided in the array or -1 in case of error. * Note that this command is inherently racy; a domain can be defined between diff --git a/src/libvirt-interface.c b/src/libvirt-interface.c index 5eb5980483..271f21b7b5 100644 --- a/src/libvirt-interface.c +++ b/src/libvirt-interface.c @@ -150,7 +150,8 @@ virConnectNumOfInterfaces(virConnectPtr conn) * Collect the list of active physical host interfaces, * and store their names in @names * - * For more control over the results, see virConnectListAllInterfaces(). + * The use of this function in new code is discouraged. Instead, use + * virConnectListAllInterfaces(). * * Returns the number of interfaces found or -1 in case of error. Note that * this command is inherently racy; a interface can be started between a call @@ -227,7 +228,8 @@ virConnectNumOfDefinedInterfaces(virConnectPtr conn) * Collect the list of defined (inactive) physical host interfaces, * and store their names in @names. * - * For more control over the results, see virConnectListAllInterfaces(). + * The use of this function in new code is discouraged. Instead, use + * virConnectListAllInterfaces(). * * Returns the number of names provided in the array or -1 in case of error. * Note that this command is inherently racy; a interface can be defined between diff --git a/src/libvirt-network.c b/src/libvirt-network.c index f691b672c7..e6ea66a234 100644 --- a/src/libvirt-network.c +++ b/src/libvirt-network.c @@ -159,7 +159,8 @@ virConnectNumOfNetworks(virConnectPtr conn) * * Collect the list of active networks, and store their names in @names * - * For more control over the results, see virConnectListAllNetworks(). + * The use of this function in new code is discouraged. Instead, use + * virConnectListAllNetworks(). * * Returns the number of networks found or -1 in case of error. Note that * this command is inherently racy; a network can be started between a call @@ -235,7 +236,8 @@ virConnectNumOfDefinedNetworks(virConnectPtr conn) * * list the inactive networks, stores the pointers to the names in @names * - * For more control over the results, see virConnectListAllNetworks(). + * The use of this function in new code is discouraged. Instead, use + * virConnectListAllNetworks(). * * Returns the number of names provided in the array or -1 in case of error. * Note that this command is inherently racy; a network can be defined between diff --git a/src/libvirt-nodedev.c b/src/libvirt-nodedev.c index 28765b9c30..6b1e03c531 100644 --- a/src/libvirt-nodedev.c +++ b/src/libvirt-nodedev.c @@ -151,7 +151,8 @@ virConnectListAllNodeDevices(virConnectPtr conn, * * Collect the list of node devices, and store their names in @names * - * For more control over the results, see virConnectListAllNodeDevices(). + * The use of this function in new code is discouraged. Instead, use + * virConnectListAllNodeDevices(). * * If the optional 'cap' argument is non-NULL, then the count * will be restricted to devices with the specified capability diff --git a/src/libvirt-nwfilter.c b/src/libvirt-nwfilter.c index e299385895..11397f2f4c 100644 --- a/src/libvirt-nwfilter.c +++ b/src/libvirt-nwfilter.c @@ -117,6 +117,9 @@ virConnectListAllNWFilters(virConnectPtr conn, * * Collect the list of network filters, and store their names in @names * + * The use of this function in new code is discouraged. Instead, use + * virConnectListALLNWFilters(). + * * Returns the number of network filters found or -1 in case of error */ int diff --git a/src/libvirt-secret.c b/src/libvirt-secret.c index 75d40f53dc..c836a09ce7 100644 --- a/src/libvirt-secret.c +++ b/src/libvirt-secret.c @@ -156,6 +156,9 @@ virConnectListAllSecrets(virConnectPtr conn, * * List UUIDs of defined secrets, store pointers to names in uuids. * + * The use of this function in new code is discouraged. Instead, use + * virConnectListAllSecrets(). + * * Returns the number of UUIDs provided in the array, or -1 on failure. */ int diff --git a/src/libvirt-storage.c b/src/libvirt-storage.c index 2a7cdca234..6b2f612cac 100644 --- a/src/libvirt-storage.c +++ b/src/libvirt-storage.c @@ -179,7 +179,8 @@ virConnectNumOfStoragePools(virConnectPtr conn) * If there are more than maxnames, the remaining names will be silently * ignored. * - * For more control over the results, see virConnectListAllStoragePools(). + * The use of this function in new code is discouraged. Instead, use + * virConnectListAllStoragePools(). * * Returns the number of pools found or -1 in case of error. Note that * this command is inherently racy; a pool can be started between a call to @@ -259,7 +260,8 @@ virConnectNumOfDefinedStoragePools(virConnectPtr conn) * If there are more than maxnames, the remaining names will be silently * ignored. * - * For more control over the results, see virConnectListAllStoragePools(). + * The use of this function in new code is discouraged. Instead, use + * virConnectListAllStoragePools(). * * Returns the number of names provided in the array or -1 in case of error. * Note that this command is inherently racy; a pool can be defined between @@ -1254,7 +1256,8 @@ virStoragePoolNumOfVolumes(virStoragePoolPtr pool) * Fetch list of storage volume names, limiting to * at most maxnames. * - * To list the volume objects directly, see virStoragePoolListAllVolumes(). + * The use of this function in new code is discouraged. Instead, use + * virStoragePoolListAllVolumes(). * * Returns the number of names fetched, or -1 on error */ -- 2.26.2

2 1

[PATCH 00/15] virbitmap: Refactor bitmap allocation
by Peter Krempa 05 Oct '20

05 Oct '20

Peter Krempa (15): virQEMUCapsFlagsString: Remove unused function virBitmapToString: Remove unused 'prefix' and 'trim' arguments virBitmapToString|virBitmapNewString: Clarify semantics of the 'string' virBitmapToString: Properly handle empty bitmaps virbitmaptest: test13: Refactor memory cleanup virbitmaptest: Use g_auto(free) for cleanup virbitmaptest: Remove unnecessary error/cleanup labels util: virbitmap: Don't forbid 0 size bitmap virbitmaptest: Add few more cases for virBitmapToString virBitmapNewQuiet: Don't fail on unlikely overflow scenario util: bitmap: Remove virBitmapNewQuiet virBitmapNew: Don't force return value check util: bitmp: Remove virBitmapNewEmpty qemuSlirpNew: Use g_new0 to allocate the slirp object virBitmapNew: Don't check return value src/conf/capabilities.c | 7 +- src/conf/checkpoint_conf.c | 3 +- src/conf/domain_addr.c | 6 +- src/conf/domain_conf.c | 12 +- src/conf/node_device_conf.c | 6 +- src/conf/numa_conf.c | 2 +- src/conf/storage_conf.c | 3 +- src/conf/virnetworkobj.c | 3 +- src/libvirt_private.syms | 2 - src/libxl/libxl_capabilities.c | 4 - src/libxl/libxl_driver.c | 6 +- src/lxc/lxc_controller.c | 3 - src/qemu/qemu_capabilities.c | 9 +- src/qemu/qemu_capabilities.h | 2 - src/qemu/qemu_conf.c | 3 +- src/qemu/qemu_domain_address.c | 5 +- src/qemu/qemu_driver.c | 11 +- src/qemu/qemu_hotplug.c | 3 +- src/qemu/qemu_migration_cookie.c | 5 +- src/qemu/qemu_migration_params.c | 12 +- src/qemu/qemu_monitor.c | 3 +- src/qemu/qemu_namespace.c | 5 +- src/qemu/qemu_process.c | 5 +- src/qemu/qemu_slirp.c | 7 +- src/qemu/qemu_snapshot.c | 3 +- src/test/test_driver.c | 12 +- src/util/virbitmap.c | 102 +++----- src/util/virbitmap.h | 6 +- src/util/vircommand.c | 3 +- src/util/virdnsmasq.c | 7 +- src/util/virhostcpu.c | 14 +- src/util/virjson.c | 3 +- src/util/virnetdev.c | 3 +- src/util/virnuma.c | 8 +- src/util/virportallocator.c | 6 +- src/util/virprocess.c | 6 +- src/util/virresctrl.c | 12 +- src/util/virstoragefile.c | 3 +- src/util/virtpm.c | 2 +- src/vmx/vmx.c | 2 - src/vz/vz_sdk.c | 3 +- tests/qemumonitorjsontest.c | 3 - tests/testutils.c | 11 +- tests/virbitmaptest.c | 410 +++++++++++++----------------- tools/virsh-domain.c | 9 +- tools/virt-host-validate-common.c | 4 +- 46 files changed, 271 insertions(+), 488 deletions(-) -- 2.26.2

2 39

[PATCH] rpm: Simplify qemu+kvm conditionals and eliminate duplication
by Neal Gompa 05 Oct '20

05 Oct '20

The conditionals for enabling qemu+kvm were unnecessarily complex. In practice, there were far fewer cases where the functionality would be disabled than what the conditional logic expressed, and this change simplifies it to the realistic set of options. Signed-off-by: Neal Gompa <ngompa13(a)gmail.com> --- libvirt.spec.in | 49 +++++++++++++++++++++++-------------------------- 1 file changed, 23 insertions(+), 26 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index c4a7c30737..6940066de9 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -20,31 +20,12 @@ %define with_qemu_tcg %{with_qemu} -%define qemu_kvm_arches %{ix86} x86_64 - -%if 0%{?fedora} - %define qemu_kvm_arches %{ix86} x86_64 %{power64} s390x %{arm} aarch64 -%endif - -%if 0%{?rhel} - %define with_qemu_tcg 0 - %define qemu_kvm_arches x86_64 %{power64} aarch64 s390x -%endif - # On RHEL 7 and older macro _vpath_builddir is not defined. %if 0%{?rhel} && 0%{?rhel} <= 7 %define _vpath_builddir %{_target_platform} %endif -%ifarch %{qemu_kvm_arches} - %define with_qemu_kvm %{with_qemu} -%else - %define with_qemu_kvm 0 -%endif - -%if ! %{with_qemu_tcg} && ! %{with_qemu_kvm} - %define with_qemu 0 -%endif +%define with_qemu_kvm %{with_qemu} # Then the hypervisor drivers that run outside libvirtd, in libvirt.so %define with_openvz 0%{!?_without_openvz:1} @@ -61,12 +42,6 @@ %endif %define with_storage_gluster 0%{!?_without_storage_gluster:1} -%ifnarch %{qemu_kvm_arches} - # gluster is only built where qemu driver is enabled on RHEL 8 - %if 0%{?rhel} >= 8 - %define with_storage_gluster 0 - %endif -%endif %define with_numactl 0%{!?_without_numactl:1} @@ -97,6 +72,11 @@ # Finally set the OS / architecture specific special cases +# KVM is available on most architectures +%ifnarch %{ix86} x86_64 %{power64} s390x %{arm} aarch64 + %define with_qemu_kvm 0 +%endif + # Xen is available only on i386 x86_64 ia64 %ifnarch %{ix86} x86_64 ia64 %define with_libxl 0 @@ -122,6 +102,23 @@ %define with_storage_rbd 0 %endif +# RHEL does not ship qemu-tcg +%if 0%{?rhel} + %define with_qemu_tcg 0 +%endif + +# In the event that qemu-tcg and qemu-kvm are unavailable, don't ship qemu +%if ! %{with_qemu_tcg} && ! %{with_qemu_kvm} + %define with_qemu 0 +%endif + +%if ! %{with_qemu_kvm} + # gluster is only built where qemu driver is enabled on RHEL 8 + %if 0%{?rhel} >= 8 + %define with_storage_gluster 0 + %endif +%endif + # RHEL doesn't ship OpenVZ, VBox, PowerHypervisor, # VMware, libxenlight (Xen 4.1 and newer), # or HyperV. -- 2.26.2

2 2

[PATCH] qemu: Taint cpu host-passthrough only after migration
by Cole Robinson 05 Oct '20

05 Oct '20

>From a discussion last year[1], Dan recommended libvirt drop the tain flag for cpu host-passthrough, unless the VM has been migrated. This repurposes the existing host-cpu taint flag to do just that. [1]: https://www.redhat.com/archives/virt-tools-list/2019-February/msg00041.html https://bugzilla.redhat.com/show_bug.cgi?id=1673098 Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- src/conf/domain_conf.h | 2 +- src/qemu/qemu_domain.c | 7 +++++-- src/qemu/qemu_domain.h | 3 ++- src/qemu/qemu_process.c | 2 +- 4 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 9a44315519..450686dfb5 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2736,7 +2736,7 @@ typedef enum { VIR_DOMAIN_TAINT_SHELL_SCRIPTS, /* Network configuration using opaque shell scripts */ VIR_DOMAIN_TAINT_DISK_PROBING, /* Relying on potentially unsafe disk format probing */ VIR_DOMAIN_TAINT_EXTERNAL_LAUNCH, /* Externally launched guest domain */ - VIR_DOMAIN_TAINT_HOST_CPU, /* Host CPU passthrough in use */ + VIR_DOMAIN_TAINT_HOST_CPU, /* Host CPU passthrough in use after migration */ VIR_DOMAIN_TAINT_HOOK, /* Domain (possibly) changed via hook script */ VIR_DOMAIN_TAINT_CDROM_PASSTHROUGH,/* CDROM passthrough */ VIR_DOMAIN_TAINT_CUSTOM_DTB, /* Custom device tree blob was specified */ diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 0331fd55e0..ed4bdbd7fb 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -6115,7 +6115,8 @@ void qemuDomainObjTaint(virQEMUDriverPtr driver, void qemuDomainObjCheckTaint(virQEMUDriverPtr driver, virDomainObjPtr obj, - qemuDomainLogContextPtr logCtxt) + qemuDomainLogContextPtr logCtxt, + bool incomingMigration) { size_t i; g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(driver); @@ -6144,7 +6145,9 @@ void qemuDomainObjCheckTaint(virQEMUDriverPtr driver, VIR_DOMAIN_TAINT_CUSTOM_HYPERVISOR_FEATURE, logCtxt); } - if (obj->def->cpu && obj->def->cpu->mode == VIR_CPU_MODE_HOST_PASSTHROUGH) + if (obj->def->cpu && + obj->def->cpu->mode == VIR_CPU_MODE_HOST_PASSTHROUGH && + incomingMigration) qemuDomainObjTaint(driver, obj, VIR_DOMAIN_TAINT_HOST_CPU, logCtxt); for (i = 0; i < obj->def->ndisks; i++) diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index ec776ced72..9bf32e16c9 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -567,7 +567,8 @@ void qemuDomainObjTaint(virQEMUDriverPtr driver, void qemuDomainObjCheckTaint(virQEMUDriverPtr driver, virDomainObjPtr obj, - qemuDomainLogContextPtr logCtxt); + qemuDomainLogContextPtr logCtxt, + bool incomingMigration); void qemuDomainObjCheckDiskTaint(virQEMUDriverPtr driver, virDomainObjPtr obj, virDomainDiskDefPtr disk, diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 9122069cc9..57d764014a 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -6856,7 +6856,7 @@ qemuProcessLaunch(virConnectPtr conn, qemuLogOperation(vm, "starting up", cmd, logCtxt); - qemuDomainObjCheckTaint(driver, vm, logCtxt); + qemuDomainObjCheckTaint(driver, vm, logCtxt, incoming != NULL); qemuDomainLogContextMarkPosition(logCtxt); -- 2.28.0

2 1

[libvirt PATCH] news: move section about downscript to v6.4.0
by Ján Tomko 05 Oct '20

05 Oct '20

The feature was merged in v6.3.0-175-g61ba6f09b1 Signed-off-by: Ján Tomko <jtomko(a)redhat.com> Fixes: 4eda71a8d05d968e73ab9b0fdc8a90123c57d39e --- NEWS.rst | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index f6074d9fe8..5da6174e42 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -404,6 +404,12 @@ v6.4.0 (2020-06-02) ``virsh capabilities`` will now include information about the host CPU when run on ARM machines. + * qemu: support network interface downscript + + QEMU has the ability to run a script when a NIC is brought up and down. + Libvirt only enables use of the up script. Now add support for postscript + when NIC is down/detached. + * **Improvements** * qemu: stricter validation for disk type='lun' @@ -454,12 +460,6 @@ v6.3.0 (2020-05-05) * **New features** - * qemu: support network interface downscript - - QEMU has the ability to run a script when a NIC is brought up and down. - Libvirt only enables use of the up script. Now add support for postscript - when NIC is down/detached. - * qemu: support disabling hotplug/unplug of PCIe devices libvirt can now set the "hotplug" option for pcie-root-ports and -- 2.26.2

2 1

[libvirt PATCH] API: virDomainLookupByID: s/UUId/UUID/
by Ján Tomko 05 Oct '20

05 Oct '20

Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/libvirt-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 415482a526..a7266ccd88 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -284,7 +284,7 @@ virDomainCreateLinux(virConnectPtr conn, const char *xmlDesc, * * Try to find a domain based on the hypervisor ID number * Note that this won't work for inactive domains which have an ID of -1, - * in that case a lookup based on the Name or UUId need to be done instead. + * in that case a lookup based on the Name or UUID need to be done instead. * * virDomainFree should be used to free the resources after the * domain object is no longer needed. -- 2.26.2

2 1

[PATCH 0/8] hyperv: implement new APIs & more
by mcoleman＠datto.com 05 Oct '20

05 Oct '20

From: Matt Coleman <matt(a)datto.com> These patches fix a couple bugs, consolidate duplicate code, and implement several APIs. Currently, some interactions with Hyper-V systems fail when the system is not configured for the "en-US" locale. Additionally, some CPU names also contain the clock frequency, making it too long for _virNodeInfo.model. The first two patches fix these bugs. The second two patches clean up the code a little: one moves repeated operations into new helper functions; the other replaces the generic "get WMI class list" functions with a macro. The last four patches implement the following APIs in the Hyper-V driver: * virConnectGetCapabilities() * virConnectGetMaxVcpus() * virConnectGetVersion() * virDomainGetAutostart() Matt Coleman (8): hyperv: make Msvm_ComputerSystem WQL queries locale agnostic hyperv: fix nodeGetInfo failures caused by long CPU names hyperv: break out common lookups into separate functions hyperv: replace generic WMI class list helpers with a macro hyperv: implement connectGetCapabilities hyperv: implement connectGetMaxVcpus hyperv: implement connectGetVersion hyperv: implement domainGetAutostart NEWS.rst | 10 + src/hyperv/hyperv_driver.c | 691 ++++++++++++++++++-------- src/hyperv/hyperv_private.h | 2 + src/hyperv/hyperv_wmi.c | 87 +--- src/hyperv/hyperv_wmi.h | 34 +- src/hyperv/hyperv_wmi_classes.h | 4 +- src/hyperv/hyperv_wmi_generator.input | 2 +- 7 files changed, 524 insertions(+), 306 deletions(-) -- 2.27.0

4 20

[PATCH 0/4] docs: formatdomain: misc fixes
by Cole Robinson 04 Oct '20

04 Oct '20

A collection of formatdomain fixes that I've noticed over the past few months Cole Robinson (4): docs: formatdomain: remove doubled filesystem <driver> docs: formatdomain: fix incorrect 'Vsock' heading indent docs: formatdomain: fix net downscript 'since' docs: formatdomain: add spicevmc <redirdev> example docs/formatdomain.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.28.0

2 8

[libvirt PATCH] tests: fix incorrect free of GVariant in our GLib mock functions
by Pavel Hrdina 04 Oct '20

04 Oct '20

GLib implementation of g_dbus_connection_call_sync() calls g_variant_ref_sink() on the passed @parameters to make sure they have proper reference. If the original reference is floating the g_dbus_connection_call_sync() consumes it, but if it's normal reference it will just add another one. Our mock functions were only freeing the @parameters which is incorrect and doesn't reflect how the real implementation works. Reported-by: Cole Robinson <crobinso(a)redhat.com> Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- tests/networkxml2firewalltest.c | 4 +++- tests/virfirewalltest.c | 3 +++ tests/virpolkittest.c | 3 +++ tests/virsystemdtest.c | 4 +++- 4 files changed, 12 insertions(+), 2 deletions(-) diff --git a/tests/networkxml2firewalltest.c b/tests/networkxml2firewalltest.c index e0244f508e..3496445f0d 100644 --- a/tests/networkxml2firewalltest.c +++ b/tests/networkxml2firewalltest.c @@ -60,8 +60,10 @@ VIR_MOCK_WRAP_RET_ARGS(g_dbus_connection_call_sync, GCancellable *, cancellable, GError **, error) { - if (parameters) + if (parameters) { + g_variant_ref_sink(parameters); g_variant_unref(parameters); + } VIR_MOCK_REAL_INIT(g_dbus_connection_call_sync); diff --git a/tests/virfirewalltest.c b/tests/virfirewalltest.c index 607638e9d0..646b999d96 100644 --- a/tests/virfirewalltest.c +++ b/tests/virfirewalltest.c @@ -79,6 +79,9 @@ VIR_MOCK_WRAP_RET_ARGS(g_dbus_connection_call_sync, GVariant *reply = NULL; g_autoptr(GVariant) params = parameters; + if (params) + g_variant_ref_sink(params); + VIR_MOCK_REAL_INIT(g_dbus_connection_call_sync); if (STREQ(bus_name, "org.freedesktop.DBus") && diff --git a/tests/virpolkittest.c b/tests/virpolkittest.c index 011d83a506..b7cbe28466 100644 --- a/tests/virpolkittest.c +++ b/tests/virpolkittest.c @@ -52,6 +52,9 @@ VIR_MOCK_WRAP_RET_ARGS(g_dbus_connection_call_sync, GVariant *reply = NULL; g_autoptr(GVariant) params = parameters; + if (params) + g_variant_ref_sink(params); + VIR_MOCK_REAL_INIT(g_dbus_connection_call_sync); if (STREQ(bus_name, "org.freedesktop.PolicyKit1") && diff --git a/tests/virsystemdtest.c b/tests/virsystemdtest.c index c1411d7c05..bd0ca51140 100644 --- a/tests/virsystemdtest.c +++ b/tests/virsystemdtest.c @@ -54,8 +54,10 @@ VIR_MOCK_WRAP_RET_ARGS(g_dbus_connection_call_sync, { GVariant *reply = NULL; - if (parameters) + if (parameters) { + g_variant_ref_sink(parameters); g_variant_unref(parameters); + } VIR_MOCK_REAL_INIT(g_dbus_connection_call_sync); -- 2.26.2

3 2

[PATCH 1/1] vircommand.c: write child pidfile before process tuning in virExec()
by Daniel Henrique Barboza 02 Oct '20

02 Oct '20

When VIR_EXEC_DAEMON is true and cmd->pidfile exists, the parent will expect the pidfile to be written before exiting, sitting tight in a saferead() call waiting. The child then does process tuning (via virProcessSet* functions) before writing the pidfile. Problem is that these tunings can fail, and trigger a 'fork_error' jump, before cmd->pidfile is written. The result is that the process was aborted in the child, but the parent is still hang in the saferead() call. This behavior can be reproduced by trying to create and execute a QEMU guest in user mode (e.g. using qemu:///session as non-root). virProcessSetMaxMemLock() will fail if the spawned libvirtd user process does not have CAP_SYS_RESOURCE capability. setrlimit() will fail, and a 'fork_error' jump is triggered before cmd->pidfile is written. The parent will hung in saferead() indefinitely. From the user perspective, 'virsh start <guest>' will hang up indefinitely. CTRL+C can be used to retrieve the terminal, but any subsequent 'virsh' call will also hang because the previous libvirtd user process is still there. We can fix this by moving all virProcessSet*() tuning functions to be executed after cmd->pidfile is taken care of. In the case mentioned above, this would be the result of 'virsh start' after this patch: error: Failed to start domain vm1 error: internal error: Process exited prior to exec: libvirt: error : cannot limit locked memory to 79691776: Operation not permitted Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1882093 Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com> --- src/util/vircommand.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/util/vircommand.c b/src/util/vircommand.c index 76f7eb9a3d..0475e22db6 100644 --- a/src/util/vircommand.c +++ b/src/util/vircommand.c @@ -787,15 +787,6 @@ virExec(virCommandPtr cmd) } } - if (virProcessSetMaxMemLock(0, cmd->maxMemLock) < 0) - goto fork_error; - if (virProcessSetMaxProcesses(0, cmd->maxProcesses) < 0) - goto fork_error; - if (virProcessSetMaxFiles(0, cmd->maxFiles) < 0) - goto fork_error; - if (cmd->setMaxCore && - virProcessSetMaxCoreSize(0, cmd->maxCore) < 0) - goto fork_error; if (cmd->pidfile) { int pidfilefd = -1; char c; @@ -820,6 +811,16 @@ virExec(virCommandPtr cmd) /* pidfilefd is intentionally leaked. */ } + if (virProcessSetMaxMemLock(0, cmd->maxMemLock) < 0) + goto fork_error; + if (virProcessSetMaxProcesses(0, cmd->maxProcesses) < 0) + goto fork_error; + if (virProcessSetMaxFiles(0, cmd->maxFiles) < 0) + goto fork_error; + if (cmd->setMaxCore && + virProcessSetMaxCoreSize(0, cmd->maxCore) < 0) + goto fork_error; + if (cmd->hook) { VIR_DEBUG("Run hook %p %p", cmd->hook, cmd->opaque); ret = cmd->hook(cmd->opaque); -- 2.26.2

3 5

[libvirt PATCH 0/5] misc spelling errors reported by codespell
by Daniel P. Berrangé 02 Oct '20

02 Oct '20

2 8

[PATCH] NEWS: mention CVE-2020-25637 in v6.8.0 release notes
by Mauro Matteo Cascella 02 Oct '20

02 Oct '20

--- NEWS.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index de46cac8c5..f6074d9fe8 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -27,6 +27,14 @@ v6.9.0 (unreleased) v6.8.0 (2020-10-01) =================== +* **Security** + + * qemu: double free in qemuAgentGetInterfaces() in qemu_agent.c + + Clients connecting to the read-write socket with limited ACL permissions + may be able to crash the libvirt daemon, resulting in a denial of service, + or potentially escalate their privileges on the system. CVE-2020-25637. + * **New features** * xen: Add ``writeFiltering`` attribute for PCI devices -- 2.26.2

2 2

[PATCH 0/6] virBitmapCopy: Refactor to prevent failures
by Peter Krempa 02 Oct '20

02 Oct '20

Note that this applies on top of my previous series dealing with bitmaps. Peter Krempa (6): virBitmapNewCopy: Reimplement bitmap copying to prevent failure Don't check return value of virBitmapNewCopy Use 'virBitmapNewCopy' instead of 'virBitmapCopy' util: virbitmap: Remove virBitmapCopy virDomainResctrlNew: Refactor allocation to remove 'cleanup' label qemuDomainFilterHotplugVcpuEntities: Refactor memory freeing to remove 'cleanup' label src/conf/capabilities.c | 6 ++---- src/conf/domain_conf.c | 19 ++++-------------- src/conf/numa_conf.c | 4 ++-- src/libvirt_private.syms | 1 - src/qemu/qemu_capabilities.c | 3 ++- src/qemu/qemu_driver.c | 13 +++---------- src/qemu/qemu_hotplug.c | 20 ++++++------------- src/qemu/qemu_migration_cookie.c | 3 --- src/qemu/qemu_process.c | 3 +-- src/test/test_driver.c | 5 +---- src/util/virbitmap.c | 33 ++------------------------------ src/util/virbitmap.h | 6 ------ src/util/virresctrl.c | 4 ++-- src/util/virstoragefile.c | 5 ++--- 14 files changed, 27 insertions(+), 98 deletions(-) -- 2.26.2

2 12

[PATCH 00/20] qemu: migration_cookie: Refactor and modernize
by Peter Krempa 02 Oct '20

02 Oct '20

Note that this applies on top of the recent bitmap refactors Peter Krempa (20): qemu: migration_cookie: Extract parsing/validation of mandatory features qemuMigrationCookieXMLParse: Switch to single-purpose temporary variables qemuMigrationCookieXMLParse: Check domain element count more defensively qemuMigrationCookieXMLParse: Decrease scope of 'nodes' and use automatic freeing qemuMigrationCookieXMLParse: Remove comment mentioning that error was already set qemuMigrationCookieXMLParse: Remove 'error' label qemuMigrationCookieGraphicsXMLFormat: Use 'virXMLFormatElement' qemuMigrationCookieNetworkXMLFormat: Refactor XML formatting qemuMigrationCookieXMLFormat: Extract formatting of NBD qemuDomainExtractTLSSubject: Refactor memory handling qemu: migration_cookie: Register 'autoptr' functions for internal types qemuMigrationCookieGraphicsSpiceAlloc: Refactor memory handling qemuMigrationCookieNetworkAlloc: Refactor memory handling qemuMigrationCookieXMLFormat: Refactor memory handling qemuMigrationCookieNetworkXMLParse: Refactor memory handling qemuMigrationCookieNBDXMLParse: Refactor memory handling qemuMigrationCookieCapsXMLParse: Refactor memory handling qemuMigrationCookieAddCaps: Use 'g_new0' instead of VIR_ALLOC qemuMigrationCookieXMLParse: Avoid VIR_FREE when parsing lockstate qemu: migration_cookie: s/VIR_FREE/g_free/ src/qemu/qemu_migration_cookie.c | 493 ++++++++++++++----------------- 1 file changed, 214 insertions(+), 279 deletions(-) -- 2.26.2

2 21

virsystemdtest segfault on ppc64
by Cole Robinson 02 Oct '20

02 Oct '20

I'm seeing failures building libvirt 6.8.0 rpm on fedora 32, 33, and rawhide. virsystemdtest is segfaulting on ppc64. https://kojipkgs.fedoraproject.org//work/tasks/5494/52595494/build.log The output from the failed tests: 74/160 libvirt / virsystemdtest FAIL 0.44s (killed by signal 11 SIGSEGV) --- command --- 17:14:09 abs_srcdir='/builddir/build/BUILD/libvirt-6.8.0/tests' abs_top_srcdir='/builddir/build/BUILD/libvirt-6.8.0' VIR_TEST_EXPENSIVE='1' LIBVIRT_AUTOSTART='0' abs_top_builddir='/builddir/build/BUILD/libvirt-6.8.0/ppc64le-redhat-linux-gnu' LC_ALL='C' abs_builddir='/builddir/build/BUILD/libvirt-6.8.0/ppc64le-redhat-linux-gnu/tests' /builddir/build/BUILD/libvirt-6.8.0/ppc64le-redhat-linux-gnu/tests/virsystemdtest --- stderr --- TEST: virsystemdtest (process:3397099): GLib-CRITICAL **: 17:14:09.137: g_atomic_ref_count_dec: assertion 'g_atomic_int_get (arc) > 0' failed . (process:3397099): GLib-CRITICAL **: 17:14:09.137: g_atomic_ref_count_dec: assertion 'g_atomic_int_get (arc) > 0' failed . (process:3397099): GLib-CRITICAL **: 17:14:09.137: g_atomic_ref_count_dec: assertion 'g_atomic_int_get (arc) > 0' failed . (process:3397099): GLib-CRITICAL **: 17:14:09.137: g_atomic_ref_count_dec: assertion 'g_atomic_int_get (arc) > 0' failed . (process:3397099): GLib-CRITICAL **: 17:14:09.137: g_atomic_ref_count_dec: assertion 'g_atomic_int_get (arc) > 0' failed . (process:3397099): GLib-CRITICAL **: 17:14:09.137: g_atomic_ref_count_dec: assertion 'g_atomic_int_get (arc) > 0' failed . (process:3397099): GLib-CRITICAL **: 17:14:09.137: g_atomic_ref_count_dec: assertion 'g_atomic_int_get (arc) > 0' failed . (process:3397099): GLib-CRITICAL **: 17:14:09.137: g_atomic_ref_count_dec: assertion 'g_atomic_int_get (arc) > 0' failed ..... (process:3397099): GLib-CRITICAL **: 17:14:09.138: g_atomic_ref_count_dec: assertion 'g_atomic_int_get (arc) > 0' failed . (process:3397099): GLib-CRITICAL **: 17:14:09.138: g_atomic_ref_count_dec: assertion 'g_atomic_int_get (arc) > 0' failed . (process:3397099): GLib-CRITICAL **: 17:14:09.138: g_atomic_ref_count_dec: assertion 'g_atomic_int_get (arc) > 0' failed . (process:3397099): GLib-CRITICAL **: 17:14:09.138: g_atomic_ref_count_dec: assertion 'g_atomic_int_get (arc) > 0' failed . ------- Full log written to /builddir/build/BUILD/libvirt-6.8.0/ppc64le-redhat-linux-gnu/meson-logs/testlog.txt RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.Yh8pF5 (%check) Bad exit status from /var/tmp/rpm-tmp.Yh8pF5 (%check) Child return code was: 1 Thanks, Cole

4 4

[PATCH 0/5] GDBus and memleak fixes
by Michal Privoznik 02 Oct '20

02 Oct '20

The first patch fixes issue raised by Cole here: https://www.redhat.com/archives/libvir-list/2020-October/msg00037.html The second one sets the environment variable which will cause our tests fail should we run into similar problem. To see it in action just switch order with patch 1/5 and observe test suite failing. The last two patches fix memleaks I've found during debugging the original problem. https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/197284472 Michal Prívozník (5): lib: Don't unref message passed to virGDBusCallMethod{WithFD}() tests: Set G_DEBUG environment variable virfirewalltest: Don't duplicate string when adding it onto stringlist vmx; Free @checkMACAddress in virVMXParseEthernet() NEWS: Document recent GLib DBus fix NEWS.rst | 6 ++++++ src/rpc/virnetdaemon.c | 4 ++-- src/util/virfirewalld.c | 16 ++++++++-------- src/util/virgdbus.c | 29 ++++++++++++++++++++--------- src/util/virgdbus.h | 4 ++-- src/util/virpolkit.c | 4 ++-- src/util/virsystemd.c | 23 ++++++++--------------- src/vmx/vmx.c | 1 + tests/meson.build | 1 + tests/virfirewalltest.c | 2 +- 10 files changed, 51 insertions(+), 39 deletions(-) -- 2.26.2

3 11

[libvirt PATCH] build: remove old macvtap and virtualport leftovers
by Pino Toscano 02 Oct '20

02 Oct '20

Followup of commit a79e7639daffac04b088378e6c79854fcac292f3 and commit 7556ab139fd2e503ac26ee232ab273f1ec027c21. Signed-off-by: Pino Toscano <ptoscano(a)redhat.com> --- meson.build | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/meson.build b/meson.build index 257e4452a1..a5ce8e17a8 100644 --- a/meson.build +++ b/meson.build @@ -1503,10 +1503,6 @@ elif get_option('firewalld_zone').enabled() error('You must have firewalld support enabled to enable firewalld_zone') endif -if conf.has('WITH_MACVTAP') and not conf.has('WITH_LIBNL') - error('libnl3-devel is required for macvtap support') -endif - if (pkcheck_prog.found() or get_option('polkit').enabled()) conf.set('WITH_POLKIT', 1) endif @@ -1515,10 +1511,6 @@ if udev_dep.found() and not pciaccess_dep.found() error('You must install the pciaccess module to build with udev') endif -if conf.has('WITH_VIRTUALPORT') and not conf.has('WITH_MACVTAP') - error('macvtap is required for virtualport support') -endif - # build driver options @@ -2388,7 +2380,6 @@ libs_summary = { 'libssh': libssh_dep.found(), 'libssh2': libssh2_dep.found(), 'libxml': libxml_dep.found(), - 'macvtap': conf.has('WITH_MACVTAP'), 'netcf': netcf_dep.found(), 'NLS': have_gnu_gettext_tools, 'nss': conf.has('WITH_NSS'), @@ -2403,7 +2394,6 @@ libs_summary = { 'sasl': sasl_dep.found(), 'selinux': selinux_dep.found(), 'udev': udev_dep.found(), - 'virtualport': conf.has('WITH_VIRTUALPORT'), 'xdr': xdr_dep.found(), 'yajl': yajl_dep.found(), } -- 2.26.2

2 1

[PATCH 0/1] Add support for QEMU's 'fmode' and 'dmode'
by Brian Turek 02 Oct '20

02 Oct '20

This patch exposes QEMU's 9pfs's 'fmode' and 'dmode flags options. I followed Ján Tomko's advice from his reply to my email to the mailing list yesterday and heavily based this on the patches that added 'multidev' support. The only part I am unsure of is whether modifying all of the 'caps' files was necessary or if only a certain few needed changing. Brian Turek (1): qemu: add support for 'fmode' and 'dmode' docs/formatdomain.rst | 12 ++++ docs/schemas/domaincommon.rng | 16 +++++ src/conf/domain_conf.c | 43 +++++++++++++ src/conf/domain_conf.h | 2 + src/qemu/qemu_capabilities.c | 4 ++ src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_command.c | 6 ++ src/qemu/qemu_validate.c | 26 ++++++++ .../caps_2.10.0.aarch64.xml | 2 + .../caps_2.10.0.ppc64.xml | 2 + .../caps_2.10.0.s390x.xml | 2 + .../caps_2.10.0.x86_64.xml | 2 + .../caps_2.11.0.s390x.xml | 2 + .../caps_2.11.0.x86_64.xml | 2 + .../caps_2.12.0.aarch64.xml | 2 + .../caps_2.12.0.ppc64.xml | 2 + .../caps_2.12.0.s390x.xml | 2 + .../caps_2.12.0.x86_64.xml | 2 + .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 2 + .../caps_3.0.0.riscv32.xml | 2 + .../caps_3.0.0.riscv64.xml | 2 + .../qemucapabilitiesdata/caps_3.0.0.s390x.xml | 2 + .../caps_3.0.0.x86_64.xml | 2 + .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 2 + .../caps_3.1.0.x86_64.xml | 2 + .../caps_4.0.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 2 + .../caps_4.0.0.riscv32.xml | 2 + .../caps_4.0.0.riscv64.xml | 2 + .../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 2 + .../caps_4.0.0.x86_64.xml | 2 + .../caps_4.1.0.x86_64.xml | 2 + .../caps_4.2.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 2 + .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 2 + .../caps_4.2.0.x86_64.xml | 2 + .../caps_5.0.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 2 + .../caps_5.0.0.riscv64.xml | 2 + .../caps_5.0.0.x86_64.xml | 2 + .../caps_5.1.0.x86_64.xml | 2 + .../caps_5.2.0.x86_64.xml | 2 + .../virtio-9p-fmodedmode.x86_64-latest.args | 48 +++++++++++++++ .../qemuxml2argvdata/virtio-9p-fmodedmode.xml | 58 ++++++++++++++++++ .../virtio-9p-fmodedmode.x86_64-latest.xml | 61 +++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 46 files changed, 347 insertions(+) create mode 100644 tests/qemuxml2argvdata/virtio-9p-fmodedmode.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/virtio-9p-fmodedmode.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-9p-fmodedmode.x86_64-latest.xml -- 2.25.1

2 2

[libvirt PATCH v4 0/6] Add support for vDPA network devices
by Jonathon Jongsma 02 Oct '20

02 Oct '20

vDPA network devices allow high-performance networking in a virtual machine by providing a wire-speed data path. These devices require a vendor-specific host driver but the data path follows the virtio specification. The support for vDPA devices was recently added to qemu. This allows libvirt to support these devices. This patchset requires that the device is configured on the host with the appropriate vendor-specific driver. This will create a chardev on the host at e.g. /dev/vhost-vdpa-0. That chardev path can then be used to define a new interface with type=3D'vdpa'. Changes in v4: - rebased to latest master - added hotplug support - report vdpa devices in node device list Jonathon Jongsma (6): conf: Add support for vDPA network devices qemu: add vhost-vdpa capability qemu: add vdpa support qemu: add monitor functions for handling file descriptors qemu: support hotplug of vdpa devices Include vdpa devices in node device list docs/formatdomain.rst | 24 +++ docs/schemas/domaincommon.rng | 15 ++ include/libvirt/libvirt-nodedev.h | 1 + src/conf/domain_conf.c | 31 ++++ src/conf/domain_conf.h | 4 + src/conf/netdev_bandwidth_conf.c | 1 + src/conf/node_device_conf.c | 5 + src/conf/node_device_conf.h | 4 +- src/conf/virnodedeviceobj.c | 4 +- src/libxl/libxl_conf.c | 1 + src/libxl/xen_common.c | 1 + src/lxc/lxc_controller.c | 1 + src/lxc/lxc_driver.c | 3 + src/lxc/lxc_process.c | 1 + src/node_device/node_device_udev.c | 16 ++ src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_command.c | 36 +++- src/qemu/qemu_command.h | 3 +- src/qemu/qemu_domain.c | 6 +- src/qemu/qemu_hotplug.c | 73 +++++++- src/qemu/qemu_interface.c | 25 +++ src/qemu/qemu_interface.h | 2 + src/qemu/qemu_migration.c | 10 +- src/qemu/qemu_monitor.c | 93 ++++++++++ src/qemu/qemu_monitor.h | 41 +++++ src/qemu/qemu_monitor_json.c | 173 ++++++++++++++++++ src/qemu/qemu_monitor_json.h | 12 ++ src/qemu/qemu_process.c | 2 + src/qemu/qemu_validate.c | 15 ++ src/vmx/vmx.c | 1 + .../caps_5.1.0.x86_64.xml | 1 + .../caps_5.2.0.x86_64.xml | 1 + tests/qemuhotplugmock.c | 9 + tests/qemuhotplugtest.c | 16 ++ .../qemuhotplug-interface-vdpa.xml | 4 + .../qemuhotplug-base-live+interface-vdpa.xml | 57 ++++++ .../net-vdpa.x86_64-latest.args | 37 ++++ tests/qemuxml2argvdata/net-vdpa.xml | 28 +++ tests/qemuxml2argvmock.c | 11 +- tests/qemuxml2argvtest.c | 1 + tests/qemuxml2xmloutdata/net-vdpa.xml | 34 ++++ tests/qemuxml2xmltest.c | 1 + tools/virsh-domain.c | 1 + tools/virsh-nodedev.c | 3 + 45 files changed, 799 insertions(+), 16 deletions(-) create mode 100644 tests/qemuhotplugtestdevices/qemuhotplug-interface-vdpa.x= ml create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-base-live+interf= ace-vdpa.xml create mode 100644 tests/qemuxml2argvdata/net-vdpa.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/net-vdpa.xml create mode 100644 tests/qemuxml2xmloutdata/net-vdpa.xml --=20 2.26.2

3 15

[PATCH 0/9] various build flag related fixes
by Laine Stump 01 Oct '20

01 Oct '20

These patches eliminate a few build flags that were necessary back 10 years ago when their associated features had been newly added to the kernel, but are now pointless (because all supported Linuxes have the feature) (1-6), makes it possible to to a successful (and usable, albeit limited in some ways) build on a system that doesn't have libnl3-devel installed (7-8) (macvtap and interface type='hostdev' don't work, but standard tap devices do), and removes a duplicated identifier check that I noticed in meson.build (9). Laine Stump (9): util: remove useless check for IFLA_VF_MAX util: remove extraneous defined(__linux__) when checking for WITH_LIBNL build: eliminate useless WITH_VIRTUALPORT check build: remove check for MACVLAN_MODE_PASSTHRU build: simplify check for WITH_MACVTAP build: eliminate WITH_MACVTAP flag util: fix Linux build when libnl-devel isn't available util: provide non-netlink/libnl alternative for virNetDevGetMaster() build: remove duplicate check for GET_VLAN_VID_CMD libvirt.spec.in | 1 - meson.build | 30 ------------------------ src/util/virnetdev.c | 40 ++++++++++++++++++++++++++------ src/util/virnetdevbridge.c | 6 ++--- src/util/virnetdevip.c | 6 ++--- src/util/virnetdevmacvlan.c | 11 +++------ src/util/virnetdevvportprofile.c | 8 +++---- src/util/virnetlink.c | 4 ++-- src/util/virnetlink.h | 4 ++-- tools/virsh.c | 3 --- 10 files changed, 50 insertions(+), 63 deletions(-) -- 2.26.2

4 18

[libvirt PATCH] Revert "Also look for dmi information in /sys/class"
by Ján Tomko 01 Oct '20

01 Oct '20

Assume nobody runs current libvirt on kernels such as 2.6.26. Kernel commit 9f9c9cbb60576a1518d0bf93fb8e499cffccf377 (released in 3.8) mentions the new path and I believe it was added by: commit 948af1f0bbc8526448e8cbe3f8d3bf211bdf5181 firmware: Basic dmi-sysfs support (released in 2.6.39), but I cannot figure out how all that kernel automagic works. This reverts commit 4c81b0fdc57b23d80b1b4752cd6143d15c02e9c8 Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/node_device/node_device_udev.c | 13 +++++-------- src/node_device/node_device_udev.h | 1 - 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c index 2d0ca27fc6..29a7eaa07c 100644 --- a/src/node_device/node_device_udev.c +++ b/src/node_device/node_device_udev.c @@ -1731,14 +1731,11 @@ udevGetDMIData(virNodeDevCapSystemPtr syscap) device = udev_device_new_from_syspath(udev, DMI_DEVPATH); if (device == NULL) { - device = udev_device_new_from_syspath(udev, DMI_DEVPATH_FALLBACK); - if (device == NULL) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Failed to get udev device for syspath '%s' or '%s'"), - DMI_DEVPATH, DMI_DEVPATH_FALLBACK); - virObjectUnlock(priv); - return; - } + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Failed to get udev device for syspath '%s'"), + DMI_DEVPATH); + virObjectUnlock(priv); + return; } virObjectUnlock(priv); diff --git a/src/node_device/node_device_udev.h b/src/node_device/node_device_udev.h index 996677dfe0..eab22a9182 100644 --- a/src/node_device/node_device_udev.h +++ b/src/node_device/node_device_udev.h @@ -24,4 +24,3 @@ #define SYSFS_DATA_SIZE 4096 #define DMI_DEVPATH "/sys/devices/virtual/dmi/id" -#define DMI_DEVPATH_FALLBACK "/sys/class/dmi/id" -- 2.26.2

2 1

[PATCH 0/3] logging: fix a couple of issues
by Nikolay Shirokovskiy 01 Oct '20

01 Oct '20

The code fixed in the first actual patch is quite venerable so I made up a synthetic test to show issue/test it is fixed. Test covers both issues. Initially I got /tmp/virtlogd-test size of only 2048 and after the first fix I saw actual endless loop. Nikolay Shirokovskiy (3): DO NOT APPLY: code to show logging issues logging: read all bytes on EOF in event handler logging: fix endless loop on EOF src/logging/log_handler.c | 10 ++++++---- src/qemu/qemu_process.c | 35 +++++++++++++++++++++++++++++++++++ 2 files changed, 41 insertions(+), 4 deletions(-) -- 1.8.3.1

2 5

[libvirt PATCH 0/6] Resurrect glib-adoption.rst
by Ján Tomko 01 Oct '20

01 Oct '20

Ján Tomko (6): Revert "docs: Drop glib-adoption.rst" docs: build glib-adoption.html docs: glib-adoption: remove stuff we alredy removed docs: glib-adoption: split into sections docs: glib-adoption: add links to GLib documentation docs: glib-adoption: add string arrays and objects docs/glib-adoption.rst | 54 ++++++++++++++++++++++++++++++++++++++++++ docs/hacking.rst | 1 + docs/meson.build | 1 + 3 files changed, 56 insertions(+) create mode 100644 docs/glib-adoption.rst -- 2.26.2

2 8

[libvirt PATCH 0/2] use g_new0 more: libxl, locking (glib chronicles)
by Ján Tomko 01 Oct '20

01 Oct '20

Ján Tomko (2): libxl: prefer g_new0 to VIR_ALLOC locking: prefer g_new0 to VIR_ALLOC src/libxl/libxl_capabilities.c | 13 ++-- src/libxl/libxl_conf.c | 48 ++++-------- src/libxl/libxl_domain.c | 19 ++--- src/libxl/libxl_driver.c | 20 ++--- src/libxl/libxl_migration.c | 21 ++--- src/libxl/xen_common.c | 122 +++++++++--------------------- src/libxl/xen_xl.c | 85 +++++++-------------- src/libxl/xen_xm.c | 9 +-- src/locking/lock_daemon.c | 9 +-- src/locking/lock_daemon_config.c | 3 +- src/locking/lock_driver_lockd.c | 7 +- src/locking/lock_driver_sanlock.c | 10 +-- src/locking/lock_manager.c | 6 +- 13 files changed, 117 insertions(+), 255 deletions(-) -- 2.26.2

2 3

[libvirt PATCH 0/3] Use g_new0 more (glib chronicles)
by Ján Tomko 01 Oct '20

01 Oct '20

In this episode, src/logging and src/rpc get converted. Ján Tomko (3): logging: use g_new0 instead of VIR_ALLOC gendispatch: use g_new0 instead of VIR_ALLOC rpc: use g_new0 instead of VIR_ALLOC src/logging/log_daemon.c | 9 +++------ src/logging/log_daemon_config.c | 3 +-- src/logging/log_handler.c | 9 +++------ src/logging/log_manager.c | 3 +-- src/rpc/gendispatch.pl | 16 +++++++--------- src/rpc/virnetclient.c | 6 ++---- src/rpc/virnetclientprogram.c | 10 ++++------ src/rpc/virnetdaemon.c | 3 +-- src/rpc/virnetlibsshsession.c | 3 +-- src/rpc/virnetmessage.c | 23 +++++++++++++++-------- src/rpc/virnetserver.c | 3 +-- src/rpc/virnetserverclient.c | 24 ++++++------------------ src/rpc/virnetserverprogram.c | 6 ++---- src/rpc/virnetserverservice.c | 9 +++------ src/rpc/virnetsocket.c | 3 +-- src/rpc/virnetsshsession.c | 8 ++------ src/rpc/virnettlscontext.c | 4 +--- 17 files changed, 54 insertions(+), 88 deletions(-) -- 2.26.2

2 5

[PATCH] util: remove compile time tests for IFF_VNET_HDR/IFF_MULTI_QUEUE
by Daniel P. Berrangé 01 Oct '20

01 Oct '20

The former has been present since commit f43798c27684ab925adde7d8acc34c78c6e50df8 Author: Rusty Russell <rusty(a)rustcorp.com.au> Date: Thu Jul 3 03:48:02 2008 -0700 tun: Allow GSO using virtio_net_hdr and the latter since commit bbb009941efaece3898910a862f6d23aa55d6ba8 Author: Jason Wang <jasowang(a)redhat.com> Date: Wed Oct 31 19:45:59 2012 +0000 tuntap: introduce multiqueue flags these are old enough that they can be assumed present in all Linux platforms we support. The tap device creation code changed is specific to Linux, with a separate impl for non-Linux platforms. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/util/virnetdevtap.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/util/virnetdevtap.c b/src/util/virnetdevtap.c index 77c4d1c52c..1738f48a5f 100644 --- a/src/util/virnetdevtap.c +++ b/src/util/virnetdevtap.c @@ -292,20 +292,11 @@ int virNetDevTapCreate(char **ifname, ifr.ifr_flags = IFF_TAP | IFF_NO_PI; /* If tapfdSize is greater than one, request multiqueue */ - if (tapfdSize > 1) { -# ifdef IFF_MULTI_QUEUE + if (tapfdSize > 1) ifr.ifr_flags |= IFF_MULTI_QUEUE; -# else - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Multiqueue devices are not supported on this system")); - goto cleanup; -# endif - } -# ifdef IFF_VNET_HDR if (flags & VIR_NETDEV_TAP_CREATE_VNET_HDR) ifr.ifr_flags |= IFF_VNET_HDR; -# endif if (virStrcpyStatic(ifr.ifr_name, *ifname) < 0) { virReportSystemError(ERANGE, -- 2.26.2

2 1

[PATCH] qemuxml2xmloutdata: Make more symlinks
by Michal Privoznik 01 Oct '20

01 Oct '20

I've found two files under qemuxml2xmloutdata/ that are the same as in qemuxml2argvdata/. Replace them with symlinks. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tests/qemuxml2xmloutdata/downscript.xml | 61 +------------------ .../video-qxl-resolution.xml | 43 +------------ 2 files changed, 2 insertions(+), 102 deletions(-) mode change 100644 => 120000 tests/qemuxml2xmloutdata/downscript.xml mode change 100644 => 120000 tests/qemuxml2xmloutdata/video-qxl-resolution.xml diff --git a/tests/qemuxml2xmloutdata/downscript.xml b/tests/qemuxml2xmloutdata/downscript.xml deleted file mode 100644 index 4d0fb1beab..0000000000 --- a/tests/qemuxml2xmloutdata/downscript.xml +++ /dev/null @@ -1,60 +0,0 @@ -<domain type='qemu'> - <name>QEMUGuest1</name> - <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> - <memory unit='KiB'>219136</memory> - <currentMemory unit='KiB'>219136</currentMemory> - <vcpu placement='static'>1</vcpu> - <os> - <type arch='x86_64' machine='pc'>hvm</type> - <boot dev='hd'/> - </os> - <cpu mode='custom' match='exact' check='none'> - <model fallback='forbid'>qemu64</model> - </cpu> - <clock offset='utc'/> - <on_poweroff>destroy</on_poweroff> - <on_reboot>restart</on_reboot> - <on_crash>destroy</on_crash> - <devices> - <emulator>/usr/bin/qemu-system-x86_64</emulator> - <disk type='file' device='disk'> - <driver name='qemu' type='raw'/> - <source file='/var/lib/libvirt/images/img1'/> - <target dev='vda' bus='virtio'/> - <address type='pci' domain='0x0000' bus='0x00' slot='0x0a' function='0x0'/> - </disk> - <controller type='usb' index='0' model='piix3-uhci'> - <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x2'/> - </controller> - <controller type='ide' index='0'> - <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/> - </controller> - <controller type='pci' index='0' model='pci-root'/> - <controller type='virtio-serial' index='0'> - <address type='pci' domain='0x0000' bus='0x00' slot='0x09' function='0x0'/> - </controller> - <filesystem type='mount' accessmode='passthrough'> - <source dir='/export/fs1'/> - <target dir='fs1'/> - <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> - </filesystem> - <filesystem type='mount' accessmode='mapped'> - <driver type='path'/> - <source dir='/export/fs2'/> - <target dir='fs2'/> - <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/> - </filesystem> - <interface type='ethernet'> - <mac address='52:54:00:f6:66:88'/> - <script path='/home/ifup.sh'/> - <downscript path='/home/ifdown.sh'/> - <model type='virtio'/> - <address type='pci' domain='0x0000' bus='0x00' slot='0x0b' function='0x0'/> - </interface> - <input type='mouse' bus='ps2'/> - <input type='keyboard' bus='ps2'/> - <memballoon model='virtio'> - <address type='pci' domain='0x0000' bus='0x00' slot='0x0c' function='0x0'/> - </memballoon> - </devices> -</domain> diff --git a/tests/qemuxml2xmloutdata/downscript.xml b/tests/qemuxml2xmloutdata/downscript.xml new file mode 120000 index 0000000000..5edee5a7c4 --- /dev/null +++ b/tests/qemuxml2xmloutdata/downscript.xml @@ -0,0 +1 @@ +../qemuxml2argvdata/downscript.xml \ No newline at end of file diff --git a/tests/qemuxml2xmloutdata/video-qxl-resolution.xml b/tests/qemuxml2xmloutdata/video-qxl-resolution.xml deleted file mode 100644 index e693cbce47..0000000000 --- a/tests/qemuxml2xmloutdata/video-qxl-resolution.xml +++ /dev/null @@ -1,42 +0,0 @@ -<domain type='qemu'> - <name>QEMUGuest1</name> - <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> - <memory unit='KiB'>219136</memory> - <currentMemory unit='KiB'>219136</currentMemory> - <vcpu placement='static'>1</vcpu> - <os> - <type arch='i686' machine='pc'>hvm</type> - <boot dev='hd'/> - </os> - <clock offset='utc'/> - <on_poweroff>destroy</on_poweroff> - <on_reboot>restart</on_reboot> - <on_crash>destroy</on_crash> - <devices> - <emulator>/usr/bin/qemu-system-i386</emulator> - <disk type='block' device='disk'> - <driver name='qemu' type='raw'/> - <source dev='/dev/HostVG/QEMUGuest1'/> - <target dev='hda' bus='ide'/> - <address type='drive' controller='0' bus='0' target='0' unit='0'/> - </disk> - <controller type='usb' index='0'> - <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x2'/> - </controller> - <controller type='ide' index='0'> - <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/> - </controller> - <controller type='pci' index='0' model='pci-root'/> - <input type='mouse' bus='ps2'/> - <input type='keyboard' bus='ps2'/> - <video> - <model type='qxl' ram='65536' vram='65536' vgamem='8192' heads='1' primary='yes'> - <resolution x='1280' y='720'/> - </model> - <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/> - </video> - <memballoon model='virtio'> - <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> - </memballoon> - </devices> -</domain> diff --git a/tests/qemuxml2xmloutdata/video-qxl-resolution.xml b/tests/qemuxml2xmloutdata/video-qxl-resolution.xml new file mode 120000 index 0000000000..f2d0595dda --- /dev/null +++ b/tests/qemuxml2xmloutdata/video-qxl-resolution.xml @@ -0,0 +1 @@ +../qemuxml2argvdata/video-qxl-resolution.xml \ No newline at end of file -- 2.26.2

2 1

[PATCH] NEWS: Mention <transient/> disk support for qemu
by Peter Krempa 01 Oct '20

01 Oct '20

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 7663cf4208..56ccfefe4a 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -13,6 +13,12 @@ v6.9.0 (unreleased) * **New features** + * qemu: Implement support for ``<transient/>`` disks + + VM's based on the QEMU hypervisor now can use ``<transient/>`` option for + local file-backed disks to configure a disk which discards changes to the + disk which happened while it was active. + * **Improvements** * **Bug fixes** -- 2.26.2

2 1

[rust PATCH] add list_volumes function
by rodolpheche 01 Oct '20

01 Oct '20

--- src/storage_pool.rs | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/src/storage_pool.rs b/src/storage_pool.rs index 96258f0..ad0a51a 100644 --- a/src/storage_pool.rs +++ b/src/storage_pool.rs @@ -18,7 +18,7 @@ extern crate libc; -use std::str; +use std::{ptr, str}; use connect::sys::virConnectPtr; use storage_vol::sys::virStorageVolPtr; @@ -101,6 +101,11 @@ extern "C" { info: sys::virStoragePoolInfoPtr, ) -> libc::c_int; fn virStoragePoolNumOfVolumes(ptr: sys::virStoragePoolPtr) -> libc::c_int; + fn virStoragePoolListVolumes( + ptr: sys::virStoragePoolPtr, + names: *mut *mut libc::c_char, + maxnames: libc::c_int, + ) -> libc::c_int; } pub type StoragePoolXMLFlags = self::libc::c_uint; @@ -276,6 +281,22 @@ impl StoragePool { } } + pub fn list_volumes(&self) -> Result<Vec<String>, Error> { + unsafe { + let mut names: [*mut libc::c_char; 1024] = [ptr::null_mut(); 1024]; + let size = virStoragePoolListVolumes(self.as_ptr(), names.as_mut_ptr(), 1024); + if size == -1 { + return Err(Error::new()); + } + + let mut array: Vec<String> = Vec::new(); + for x in 0..size as usize { + array.push(c_chars_to_string!(names[x])); + } + return Ok(array); + } + } + pub fn get_uuid_string(&self) -> Result<String, Error> { unsafe { let mut uuid: [libc::c_char; 37] = [0; 37]; -- 2.28.0

2 1

[libvirt PATCH 0/6] conf: split some funcs out of virDomainDefParseXML
by Ján Tomko 01 Oct '20

01 Oct '20

Ján Tomko (6): conf: split out virDomainDefParseIDs conf: split out virDomainDefParseMemory conf: introduce virDomainDefTunablesParse conf: introduce virDomainDefLifecycleParse conf: introduce virDomainDefClockParse conf: introduce virDomainDefControllersParse src/conf/domain_conf.c | 728 ++++++++++++++++++++++++----------------- 1 file changed, 419 insertions(+), 309 deletions(-) -- 2.26.2

2 7

[PATCH 0/2] qemu: Use .hostdevice attribute for usb-host
by Michal Privoznik 01 Oct '20

01 Oct '20

See 2/2 for explanation why we need this. Also, .hostdevice uses qemu_open() under the hood which enables Libvirt to pass FD instead of /dev/bus/usb/... path. However, qemu_open() does not support getfd style of passing FD (which is what we use), but so called FD sets which require some more work. I'm working on it as we speak but I figured, let's fix this bug first and post FD passing after that. For curious ones, here is the raw, unclean version with FD sets: https://gitlab.com/MichalPrivoznik/libvirt/-/commits/qemu_hostdev_alt/ Michal Prívozník (2): qemu_capabilities: Add QEMU_CAPS_USB_HOST_HOSTDEVICE qemu: Use .hostdevice attribute for usb-host src/qemu/qemu_capabilities.c | 10 ++ src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_command.c | 21 ++- .../caps_1.5.3.x86_64.replies | 126 ++++++++++++-- .../caps_1.6.0.x86_64.replies | 126 ++++++++++++-- .../caps_1.7.0.x86_64.replies | 126 ++++++++++++-- .../caps_2.1.1.x86_64.replies | 126 ++++++++++++-- .../caps_2.10.0.aarch64.replies | 134 +++++++++++++-- .../caps_2.10.0.ppc64.replies | 130 ++++++++++++-- .../caps_2.10.0.s390x.replies | 134 +++++++++++++-- .../caps_2.10.0.x86_64.replies | 146 +++++++++++++--- .../caps_2.11.0.s390x.replies | 134 +++++++++++++-- .../caps_2.11.0.x86_64.replies | 146 +++++++++++++--- .../caps_2.12.0.aarch64.replies | 150 +++++++++++++--- .../caps_2.12.0.ppc64.replies | 142 ++++++++++++--- .../caps_2.12.0.s390x.replies | 142 ++++++++++++--- .../caps_2.12.0.x86_64.replies | 162 ++++++++++++++---- .../caps_2.4.0.x86_64.replies | 126 ++++++++++++-- .../caps_2.5.0.x86_64.replies | 130 ++++++++++++-- .../caps_2.6.0.aarch64.replies | 134 +++++++++++++-- .../caps_2.6.0.ppc64.replies | 130 ++++++++++++-- .../caps_2.6.0.x86_64.replies | 130 ++++++++++++-- .../caps_2.7.0.s390x.replies | 130 ++++++++++++-- .../caps_2.7.0.x86_64.replies | 130 ++++++++++++-- .../caps_2.8.0.s390x.replies | 134 +++++++++++++-- .../caps_2.8.0.x86_64.replies | 130 ++++++++++++-- .../caps_2.9.0.ppc64.replies | 130 ++++++++++++-- .../caps_2.9.0.s390x.replies | 134 +++++++++++++-- .../caps_2.9.0.x86_64.replies | 146 +++++++++++++--- .../caps_3.0.0.ppc64.replies | 142 ++++++++++++--- .../caps_3.0.0.riscv32.replies | 138 +++++++++++++-- .../caps_3.0.0.riscv64.replies | 138 +++++++++++++-- .../caps_3.0.0.s390x.replies | 142 ++++++++++++--- .../caps_3.0.0.x86_64.replies | 162 ++++++++++++++---- .../caps_3.1.0.ppc64.replies | 142 ++++++++++++--- .../caps_3.1.0.x86_64.replies | 162 ++++++++++++++---- .../caps_4.0.0.aarch64.replies | 150 +++++++++++++--- .../caps_4.0.0.ppc64.replies | 142 ++++++++++++--- .../caps_4.0.0.riscv32.replies | 138 +++++++++++++-- .../caps_4.0.0.riscv64.replies | 138 +++++++++++++-- .../caps_4.0.0.s390x.replies | 142 ++++++++++++--- .../caps_4.0.0.x86_64.replies | 162 ++++++++++++++---- .../caps_4.1.0.x86_64.replies | 154 ++++++++++++++--- .../caps_4.2.0.aarch64.replies | 154 ++++++++++++++--- .../caps_4.2.0.ppc64.replies | 142 ++++++++++++--- .../caps_4.2.0.s390x.replies | 142 ++++++++++++--- .../caps_4.2.0.x86_64.replies | 154 ++++++++++++++--- .../caps_5.0.0.aarch64.replies | 154 ++++++++++++++--- .../caps_5.0.0.ppc64.replies | 142 ++++++++++++--- .../caps_5.0.0.riscv64.replies | 138 +++++++++++++-- .../caps_5.0.0.x86_64.replies | 154 ++++++++++++++--- .../caps_5.1.0.x86_64.replies | 158 ++++++++++++++--- .../caps_5.1.0.x86_64.xml | 1 + .../caps_5.2.0.x86_64.replies | 158 ++++++++++++++--- .../caps_5.2.0.x86_64.xml | 1 + 55 files changed, 6110 insertions(+), 982 deletions(-) -- 2.26.2

4 6

Release of libvirt-6.8.0
by Jiri Denemark 01 Oct '20

01 Oct '20

The 6.8.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://libvirt.org/sources/ https://libvirt.org/sources/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing any other feedback. Your work is greatly appreciated. * New features * xen: Add ``writeFiltering`` attribute for PCI devices By default Xen filters guest writes to the PCI configuration space of a PCI hostdev, which may cause problems for some devices. The ``writeFiltering`` attribute of the device's ``<source>`` element can be used to disable the filtering and allow all guest writes to the configuration space. * bhyve: Support setting the framebuffer resolution Libvirt can now set the framebuffer's "w" and "h" parameters using the ``resolution`` element. * bhyve: Support VNC password authentication Libvirt can now probe whether the bhyve binary supports VNC password authentication. In case it does, a VNC password can now be passed using the ``passwd`` attribute on the ``<graphics>`` element. * remote: ``virt-ssh-helper`` replaces ``nc`` for SSH tunnelling Libvirt now provides a ``virt-ssh-helper`` binary on the server side. The libvirt remote client will use this binary for setting up an SSH tunnelled connection to hosts. If not present, it will transparently fallback to the traditional ``nc`` tunnel. The new binary makes it possible for libvirt to transparently connect across hosts even if libvirt is built with a different installation prefix on the client vs server. It also enables remote access to the unprivileged per-user libvirt daemons (e.g. using a URI such as ``qemu+ssh://hostname/session``). The only requirement is that ``virt-ssh-helper`` is present in ``$PATH`` of the remote host. * esx: implement few APIs The ``virConnectListAllNetworks()``, ``virDomainGetHostname()``, and ``virDomainInterfaceAddresses()`` (only for ``VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_AGENT`` source) APIs were implemented in the esx driver. * Improvements * qemu: Allow migration over UNIX sockets QEMU migration can now be performed completely over UNIX sockets. This is useful for containerised scenarios and can be used in both peer2peer and direct migrations. * dbus: Use GLib implementation instead of libdbus Adopting GLib DBus implementation simplifies our code as libdbus provides low-level APIs where we had to have a lot of helper functions. With this change we also remove dependency on libdbus and possibly fix all the DBus related libvirtd crashes seen over the time. * Re-introduce NVDIMM auto-alignment for pSeries Guests The auto-alignment logic was removed in v6.7.0 in favor of requiring the size provided by the user to be already aligned; however, this had the unintended consequence of breaking some existing guests. v6.8.0 restores the previous behavior with an improvement: it also reflects the auto-aligned value in the domain XML. * qemu: Preserve qcow2 cluster size after external snapshots The new overlay image which is installed on top of the current chain when taking an external snapshot now preserves the cluser size of the original top image to preserve any performance tuning done on the original image. * Bug fixes * qemu: Various (i)SCSI backed hostdev fixes (i)SCSI backed hostdevs now work again with an arbitrarily long user-specified device alias and also honor the 'readonly' property after a recent rewrite. * Removed features * node_device: Remove HAL node device backend HAL is deprecated on all supported OS so there is no need to keep it in libvirt. udev backend is used on Linux OSes and devd can be eventually implemented as replacement for FreeBSD. Enjoy. Jirka

1 0

[PATCH 0/3] get rid of virDomainNetDefClear()
by Laine Stump 01 Oct '20

01 Oct '20

While looking for something else, I noticed that there were only 2 callers to virDomainNetDefClear(), and one of those was virDomain NetDefFree(). virDomainNetDefClear() necessarily has a lot of VIR_FREE() in it that couldn't be changed to g_free() (because it's possible the object will be used after it is cleared). This series eliminates the actual practical usage of virDomainNetDefClear() by just creating a new object instead of clearing and re-using the old object, then moves the contents of virDomainNetDefClear() into virDomainNetDefFree(), and finally changes all the uses of VIR_FREE() to g_free() (now that it's safe to do so). Laine Stump (3): qemu: eliminate use of virDomainNetDefClear() in qemuConnectDomainXMLToNative() conf: eliminate virDomainNetDefClear() conf: use g_free() instead of VIR_FREE in virDomainNetDefFree() src/conf/domain_conf.c | 51 +++++++++++++++++----------------------- src/conf/domain_conf.h | 1 - src/libvirt_private.syms | 1 - src/qemu/qemu_driver.c | 26 +++++++++----------- 4 files changed, 33 insertions(+), 46 deletions(-) -- 2.26.2

2 4

[libvirt PATCH] cpu_map: Add EPYC-Rome model
by Markus Schade 30 Sep '20

30 Sep '20

Signed-off-by: Markus Schade <markus.schade(a)hetzner.com> --- src/cpu_map/index.xml | 1 + src/cpu_map/meson.build | 1 + src/cpu_map/x86_EPYC-Rome.xml | 81 + tests/cputest.c | 1 + ...86_64-cpuid-EPYC-7502-32-Core-disabled.xml | 9 + ...x86_64-cpuid-EPYC-7502-32-Core-enabled.xml | 11 + .../x86_64-cpuid-EPYC-7502-32-Core-guest.xml | 35 + .../x86_64-cpuid-EPYC-7502-32-Core-host.xml | 36 + .../x86_64-cpuid-EPYC-7502-32-Core-json.xml | 24 + .../x86_64-cpuid-EPYC-7502-32-Core.json | 1910 +++++++++++++++++ .../x86_64-cpuid-EPYC-7502-32-Core.sig | 4 + .../x86_64-cpuid-EPYC-7502-32-Core.xml | 66 + ...4-cpuid-Ryzen-9-3900X-12-Core-disabled.xml | 1 - ...64-cpuid-Ryzen-9-3900X-12-Core-enabled.xml | 2 +- ...6_64-cpuid-Ryzen-9-3900X-12-Core-guest.xml | 9 +- ...86_64-cpuid-Ryzen-9-3900X-12-Core-host.xml | 9 +- ...86_64-cpuid-Ryzen-9-3900X-12-Core-json.xml | 8 +- .../x86_64-cpuid-Ryzen-9-3900X-12-Core.json | 23 + .../x86_64-cpuid-Ryzen-9-3900X-12-Core.xml | 12 +- 19 files changed, 2212 insertions(+), 31 deletions(-) create mode 100644 src/cpu_map/x86_EPYC-Rome.xml create mode 100644 tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml create mode 100644 tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml create mode 100644 tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-json.xml create mode 100644 tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core.json create mode 100644 tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core.sig create mode 100644 tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core.xml diff --git a/src/cpu_map/index.xml b/src/cpu_map/index.xml index 1486a29c65..fec01f324c 100644 --- a/src/cpu_map/index.xml +++ b/src/cpu_map/index.xml @@ -66,6 +66,7 @@ <include filename="x86_Opteron_G5.xml"/> <include filename="x86_EPYC.xml"/> <include filename="x86_EPYC-IBPB.xml"/> + <include filename="x86_EPYC-Rome.xml"/>  <include filename="x86_Dhyana.xml"/> diff --git a/src/cpu_map/meson.build b/src/cpu_map/meson.build index 19daa7157b..b86612b6e0 100644 --- a/src/cpu_map/meson.build +++ b/src/cpu_map/meson.build @@ -32,6 +32,7 @@ cpumap_data = [ 'x86_Dhyana.xml', 'x86_EPYC-IBPB.xml', 'x86_EPYC.xml', + 'x86_EPYC-Rome.xml', 'x86_features.xml', 'x86_Haswell-IBRS.xml', 'x86_Haswell-noTSX-IBRS.xml', diff --git a/src/cpu_map/x86_EPYC-Rome.xml b/src/cpu_map/x86_EPYC-Rome.xml new file mode 100644 index 0000000000..41d4123917 --- /dev/null +++ b/src/cpu_map/x86_EPYC-Rome.xml @@ -0,0 +1,81 @@ +<cpus> + <model name='EPYC-Rome'> + <decode host='on' guest='on'/> + <signature family='23' model='49'/> + <vendor name='AMD'/> + <feature name='3dnowprefetch'/> + <feature name='abm'/> + <feature name='adx'/> + <feature name='aes'/> + <feature name='amd-stibp'/> + <feature name='apic'/> + <feature name='arat'/> + <feature name='avx'/> + <feature name='avx2'/> + <feature name='bmi1'/> + <feature name='bmi2'/> + <feature name='clflush'/> + <feature name='clflushopt'/> + <feature name='clwb'/> + <feature name='clzero'/> + <feature name='cmov'/> + <feature name='cr8legacy'/> + <feature name='cx16'/> + <feature name='cx8'/> + <feature name='de'/> + <feature name='f16c'/> + <feature name='fma'/> + <feature name='fpu'/> + <feature name='fsgsbase'/> + <feature name='fxsr'/> + <feature name='fxsr_opt'/> + <feature name='ibpb'/> + <feature name='lahf_lm'/> + <feature name='lm'/> + <feature name='mca'/> + <feature name='mce'/> + <feature name='misalignsse'/> + <feature name='mmx'/> + <feature name='mmxext'/> + <feature name='monitor'/> + <feature name='movbe'/> + <feature name='msr'/> + <feature name='mtrr'/> + <feature name='nx'/> + <feature name='osvw'/> + <feature name='pae'/> + <feature name='pat'/> + <feature name='pclmuldq'/> + <feature name='pdpe1gb'/> + <feature name='perfctr_core'/> + <feature name='pge'/> + <feature name='pni'/> + <feature name='popcnt'/> + <feature name='pse'/> + <feature name='pse36'/> + <feature name='rdpid'/> + <feature name='rdrand'/> + <feature name='rdseed'/> + <feature name='rdtscp'/> + <feature name='sep'/> + <feature name='sha-ni'/> + <feature name='smap'/> + <feature name='smep'/> + <feature name='sse'/> + <feature name='sse2'/> + <feature name='sse4.1'/> + <feature name='sse4.2'/> + <feature name='sse4a'/> + <feature name='ssse3'/> + <feature name='svm'/> + <feature name='syscall'/> + <feature name='tsc'/> + <feature name='vme'/> + <feature name='wbnoinvd'/> + <feature name='xgetbv1'/> + <feature name='xsave'/> + <feature name='xsavec'/> + <feature name='xsaveerptr'/> + <feature name='xsaveopt'/> + </model> +</cpus> diff --git a/tests/cputest.c b/tests/cputest.c index 383da94938..53674f2b9a 100644 --- a/tests/cputest.c +++ b/tests/cputest.c @@ -1244,6 +1244,7 @@ mymain(void) DO_TEST_CPUID(VIR_ARCH_X86_64, "Hygon-C86-7185-32-core", JSON_HOST); DO_TEST_CPUID(VIR_ARCH_X86_64, "EPYC-7601-32-Core", JSON_HOST); DO_TEST_CPUID(VIR_ARCH_X86_64, "EPYC-7601-32-Core-ibpb", JSON_MODELS_REQUIRED); + DO_TEST_CPUID(VIR_ARCH_X86_64, "EPYC-7502-32-Core", JSON_MODELS); DO_TEST_CPUID(VIR_ARCH_X86_64, "FX-8150", JSON_NONE); DO_TEST_CPUID(VIR_ARCH_X86_64, "Opteron-1352", JSON_NONE); DO_TEST_CPUID(VIR_ARCH_X86_64, "Opteron-2350", JSON_HOST); diff --git a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-disabled.xml b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-disabled.xml new file mode 100644 index 0000000000..ca71b9efb5 --- /dev/null +++ b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-disabled.xml @@ -0,0 +1,9 @@ + +<cpudata arch='x86'> + <cpuid eax_in='0x00000001' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x08000008' edx='0x10000000'/> + <cpuid eax_in='0x00000007' ecx_in='0x00' eax='0x00000000' ebx='0x00001000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x0000000f' ecx_in='0x01' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000006'/> + <cpuid eax_in='0x80000001' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x01423408' edx='0x00000000'/> + <cpuid eax_in='0x80000007' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000100'/> + <cpuid eax_in='0x8000000a' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x000014f6'/> +</cpudata> diff --git a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-enabled.xml b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-enabled.xml new file mode 100644 index 0000000000..09a9952c27 --- /dev/null +++ b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-enabled.xml @@ -0,0 +1,11 @@ + +<cpudata arch='x86'> + <cpuid eax_in='0x00000001' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0xf7f83203' edx='0x078bfbff'/> + <cpuid eax_in='0x00000006' ecx_in='0x00' eax='0x00000004' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x00000007' ecx_in='0x00' eax='0x00000000' ebx='0x219c01ab' ecx='0x00400004' edx='0xac000000'/> + <cpuid eax_in='0x0000000d' ecx_in='0x01' eax='0x0000000f' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x80000001' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x008003f7' edx='0x2e500800'/> + <cpuid eax_in='0x80000008' ecx_in='0x00' eax='0x00000000' ebx='0x03009205' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x8000000a' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000009'/> + <msr index='0x10a' edx='0x00000000' eax='0x00000069'/> +</cpudata> diff --git a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml new file mode 100644 index 0000000000..a49ef46f52 --- /dev/null +++ b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml @@ -0,0 +1,35 @@ +<cpu mode='custom' match='exact'> + <model fallback='forbid'>EPYC-Rome</model> + <vendor>AMD</vendor> + <feature policy='require' name='ht'/> + <feature policy='require' name='osxsave'/> + <feature policy='require' name='cmt'/> + <feature policy='require' name='umip'/> + <feature policy='require' name='xsaves'/> + <feature policy='require' name='mbm_total'/> + <feature policy='require' name='mbm_local'/> + <feature policy='require' name='cmp_legacy'/> + <feature policy='require' name='extapic'/> + <feature policy='require' name='ibs'/> + <feature policy='require' name='skinit'/> + <feature policy='require' name='wdt'/> + <feature policy='require' name='tce'/> + <feature policy='require' name='topoext'/> + <feature policy='require' name='perfctr_nb'/> + <feature policy='require' name='invtsc'/> + <feature policy='require' name='amd-ssbd'/> + <feature policy='require' name='npt'/> + <feature policy='require' name='lbrv'/> + <feature policy='require' name='svm-lock'/> + <feature policy='require' name='nrip-save'/> + <feature policy='require' name='tsc-scale'/> + <feature policy='require' name='vmcb-clean'/> + <feature policy='require' name='flushbyasid'/> + <feature policy='require' name='decodeassists'/> + <feature policy='require' name='pause-filter'/> + <feature policy='require' name='pfthreshold'/> + <feature policy='require' name='rdctl-no'/> + <feature policy='require' name='skip-l1dfl-vmentry'/> + <feature policy='require' name='mds-no'/> + <feature policy='require' name='pschange-mc-no'/> +</cpu> diff --git a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml new file mode 100644 index 0000000000..e9aea3339a --- /dev/null +++ b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml @@ -0,0 +1,36 @@ +<cpu> + <arch>x86_64</arch> + <model>EPYC-Rome</model> + <vendor>AMD</vendor> + <feature name='ht'/> + <feature name='osxsave'/> + <feature name='cmt'/> + <feature name='umip'/> + <feature name='xsaves'/> + <feature name='mbm_total'/> + <feature name='mbm_local'/> + <feature name='cmp_legacy'/> + <feature name='extapic'/> + <feature name='ibs'/> + <feature name='skinit'/> + <feature name='wdt'/> + <feature name='tce'/> + <feature name='topoext'/> + <feature name='perfctr_nb'/> + <feature name='invtsc'/> + <feature name='amd-ssbd'/> + <feature name='npt'/> + <feature name='lbrv'/> + <feature name='svm-lock'/> + <feature name='nrip-save'/> + <feature name='tsc-scale'/> + <feature name='vmcb-clean'/> + <feature name='flushbyasid'/> + <feature name='decodeassists'/> + <feature name='pause-filter'/> + <feature name='pfthreshold'/> + <feature name='rdctl-no'/> + <feature name='skip-l1dfl-vmentry'/> + <feature name='mds-no'/> + <feature name='pschange-mc-no'/> +</cpu> diff --git a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-json.xml b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-json.xml new file mode 100644 index 0000000000..e402b77eed --- /dev/null +++ b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-json.xml @@ -0,0 +1,24 @@ +<cpu mode='custom' match='exact'> + <model fallback='forbid'>EPYC-Rome</model> + <vendor>AMD</vendor> + <feature policy='require' name='x2apic'/> + <feature policy='require' name='tsc-deadline'/> + <feature policy='require' name='hypervisor'/> + <feature policy='require' name='tsc_adjust'/> + <feature policy='require' name='umip'/> + <feature policy='require' name='spec-ctrl'/> + <feature policy='require' name='stibp'/> + <feature policy='require' name='arch-capabilities'/> + <feature policy='require' name='ssbd'/> + <feature policy='require' name='xsaves'/> + <feature policy='require' name='cmp_legacy'/> + <feature policy='require' name='amd-ssbd'/> + <feature policy='require' name='virt-ssbd'/> + <feature policy='require' name='npt'/> + <feature policy='require' name='nrip-save'/> + <feature policy='require' name='rdctl-no'/> + <feature policy='require' name='skip-l1dfl-vmentry'/> + <feature policy='require' name='mds-no'/> + <feature policy='require' name='pschange-mc-no'/> + <feature policy='disable' name='monitor'/> +</cpu> diff --git a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core.json b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core.json new file mode 100644 index 0000000000..7942096dad --- /dev/null +++ b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core.json @@ -0,0 +1,1910 @@ +{ + "return": { + "model": { + "name": "base", + "props": { + "phys-bits": 0, + "vmx-entry-load-rtit-ctl": false, + "core-id": -1, + "xlevel": 2147483679, + "cmov": true, + "ia64": false, + "ssb-no": false, + "aes": true, + "vmx-apicv-xapic": false, + "mmx": true, + "arat": true, + "rdpid": true, + "vmx-page-walk-5": false, + "vmx-page-walk-4": false, + "vmx-desc-exit": false, + "gfni": false, + "ibrs-all": false, + "pause-filter": false, + "xsavec": true, + "intel-pt": false, + "vmx-cr8-store-exit": false, + "hv-frequencies": false, + "tsc-frequency": 0, + "vmx-rdseed-exit": false, + "xd": true, + "x-intel-pt-auto-level": true, + "hv-vendor-id": "", + "vmx-eptp-switching": false, + "kvm_asyncpf": true, + "kvm-asyncpf": true, + "perfctr_core": true, + "perfctr-core": true, + "mpx": false, + "avx512cd": false, + "pbe": false, + "decodeassists": false, + "vmx-exit-clear-bndcfgs": false, + "vmx-exit-load-efer": false, + "sse4_1": true, + "sse4-1": true, + "sse4.1": true, + "legacy-cache": true, + "family": 23, + "vmx-vmwrite-vmexit-fields": false, + "vmx-vnmi": false, + "vmx-true-ctls": false, + "host-phys-bits-limit": 0, + "vmx-ept-execonly": false, + "vmx-exit-save-efer": false, + "vmx-invept-all-context": false, + "vmware-cpuid-freq": true, + "wbnoinvd": true, + "avx512f": false, + "hv-runtime": false, + "hv-stimer-direct": false, + "xcrypt": false, + "mce": true, + "mca": true, + "msr": true, + "thread-id": -1, + "vmx-exit-load-pat": false, + "vmx-intr-exit": false, + "min-level": 16, + "vmx-flexpriority": false, + "xgetbv1": true, + "cid": false, + "hv-relaxed": false, + "hv-crash": false, + "avx512-bf16": false, + "ds": false, + "fxsr": true, + "vmx-cr8-load-exit": false, + "xsaveopt": true, + "vmx-apicv-vid": false, + "vmx-exit-save-pat": false, + "tsx-ctrl": false, + "xtpr": false, + "vmx-ple": false, + "hv-evmcs": false, + "avx512-vpopcntdq": false, + "phe": false, + "avx512vl": false, + "extapic": false, + "vmx-vmfunc": false, + "3dnowprefetch": true, + "vmx-activity-shutdown": false, + "avx512vbmi2": false, + "cr8legacy": true, + "vmx-encls-exit": false, + "stibp": true, + "vmx-msr-bitmap": false, + "cpuid-0xb": true, + "xcrypt-en": false, + "vmx-mwait-exit": false, + "kvm_pv_eoi": true, + "vmx-pml": false, + "apic-id": 4294967295, + "vmx-nmi-exit": false, + "vmx-invept-single-context-noglobals": false, + "pn": false, + "rsba": false, + "dca": false, + "hv-ipi": false, + "vmx-unrestricted-guest": false, + "vendor": "AuthenticAMD", + "vmx-cr3-store-noexit": false, + "pku": false, + "smx": false, + "cmp-legacy": true, + "cmp_legacy": true, + "node-id": -1, + "avx512-4fmaps": false, + "vmcb_clean": false, + "vmcb-clean": false, + "hle": false, + "amd-no-ssb": false, + "3dnowext": false, + "npt": true, + "rdctl-no": true, + "vmx-invvpid": false, + "memory": "/machine/unattached/system[0]", + "clwb": true, + "lbrv": false, + "adx": true, + "ss": false, + "pni": true, + "svm_lock": false, + "svm-lock": false, + "pfthreshold": false, + "smap": true, + "smep": true, + "vmx-invpcid-exit": false, + "x2apic": true, + "avx512vnni": false, + "avx512vbmi": false, + "vmx-apicv-x2apic": false, + "hv-stimer": false, + "kvm-pv-sched-yield": true, + "x-hv-synic-kvm-only": false, + "vmx-invlpg-exit": false, + "vmx-invvpid-all-context": false, + "i64": true, + "vmx-activity-hlt": false, + "flushbyasid": false, + "f16c": true, + "vmx-exit-ack-intr": false, + "ace2-en": false, + "pae": true, + "pat": true, + "sse": true, + "die-id": -1, + "vmx-tsc-offset": false, + "phe-en": false, + "kvm_nopiodelay": true, + "kvm-nopiodelay": true, + "tm": false, + "kvmclock-stable-bit": true, + "vmx-rdtsc-exit": false, + "hypervisor": true, + "vmx-rdtscp-exit": false, + "socket-id": -1, + "mds-no": true, + "pcommit": false, + "vmx-vpid": false, + "syscall": true, + "level": 16, + "x-migrate-smi-count": true, + "avx512dq": false, + "svm": true, + "full-cpuid-auto-level": true, + "hv-reset": false, + "invtsc": false, + "vmx-monitor-exit": false, + "sse3": true, + "sse2": true, + "ssbd": true, + "vmx-wbinvd-exit": false, + "est": false, + "kvm-poll-control": true, + "kvm_poll_control": true, + "avx512ifma": false, + "tm2": false, + "kvm-pv-eoi": true, + "kvm-pv-ipi": true, + "cx8": true, + "vmx-invvpid-single-addr": false, + "waitpkg": false, + "cldemote": false, + "vmx-ept": false, + "hv-reenlightenment": false, + "kvm_mmu": false, + "kvm-mmu": false, + "sse4-2": true, + "sse4.2": true, + "sse4_2": true, + "pge": true, + "fill-mtrr-mask": true, + "avx512bitalg": false, + "vmx-entry-load-bndcfgs": false, + "nodeid_msr": false, + "pdcm": false, + "vmx-exit-clear-rtit-ctl": false, + "model": 49, + "movbe": true, + "nrip_save": true, + "nrip-save": true, + "vmx-pause-exit": false, + "ssse3": true, + "kvm_pv_unhalt": true, + "sse4a": true, + "invpcid": false, + "pdpe1gb": true, + "tsc-deadline": true, + "skip-l1dfl-vmentry": true, + "vmx-exit-load-perf-global-ctrl": false, + "fma": true, + "cx16": true, + "de": true, + "enforce": false, + "stepping": 0, + "xsave": true, + "clflush": true, + "skinit": false, + "tsc": true, + "tce": false, + "fpu": true, + "ds-cpl": false, + "ds_cpl": false, + "ibs": false, + "host-phys-bits": false, + "fma4": false, + "vmx-exit-nosave-debugctl": false, + "vmx-invept": false, + "la57": false, + "osvw": true, + "check": true, + "hv-spinlocks": 4294967295, + "pmu": false, + "vmx-eptad": false, + "vmx-entry-noload-debugctl": false, + "pmm": false, + "apic": true, + "spec-ctrl": true, + "vmx-posted-intr": false, + "vmx-apicv-register": false, + "min-xlevel2": 0, + "tsc-adjust": true, + "tsc_adjust": true, + "kvm-steal-time": true, + "kvm_steal_time": true, + "kvmclock": true, + "vmx-zero-len-inject": false, + "l3-cache": true, + "pschange-mc-no": true, + "vmx-rdrand-exit": false, + "lwp": false, + "hv-passthrough": false, + "amd-ssbd": true, + "ibpb": true, + "xop": false, + "core-capability": false, + "avx": true, + "vmx-invept-single-context": false, + "movdiri": false, + "avx512bw": false, + "acpi": false, + "ace2": false, + "hv-vapic": false, + "fsgsbase": true, + "vmx-ept-1gb": false, + "vmx-ept-2mb": false, + "ht": false, + "vmx-io-exit": false, + "nx": true, + "pclmulqdq": true, + "mmxext": true, + "popcnt": true, + "vaes": false, + "xsaves": true, + "movdir64b": false, + "tcg-cpuid": true, + "vmx-shadow-vmcs": false, + "lm": true, + "vmx-exit-save-preemption-timer": false, + "vmx-entry-load-pat": false, + "vmx-entry-load-perf-global-ctrl": false, + "vmx-io-bitmap": false, + "vmx-store-lma": false, + "umip": true, + "vmx-movdr-exit": false, + "avx2": true, + "pse": true, + "pclmuldq": true, + "sep": true, + "vmx-cr3-load-noexit": false, + "virt-ssbd": true, + "x-hv-max-vps": -1, + "nodeid-msr": false, + "md-clear": false, + "kvm": true, + "split-lock-detect": false, + "misalignsse": true, + "min-xlevel": 2147483679, + "realized": false, + "kvm-pv-unhalt": true, + "bmi2": true, + "bmi1": true, + "tsc_scale": false, + "tsc-scale": false, + "topoext": false, + "hv-vpindex": false, + "hv-no-nonarch-coresharing": "off", + "amd-stibp": true, + "ucode-rev": 0, + "vmx-preemption-timer": false, + "xlevel2": 0, + "clflushopt": true, + "vmx-vnmi-pending": false, + "kvm-no-smi-migration": false, + "monitor": false, + "vmx-vintr-pending": false, + "avx512er": false, + "pmm-en": false, + "taa-no": false, + "pcid": false, + "vmx-secondary-ctls": false, + "arch-capabilities": true, + "vmx-xsaves": false, + "clzero": true, + "3dnow": false, + "erms": false, + "x-force-features": false, + "vmx-entry-ia32e-mode": false, + "lahf-lm": true, + "lahf_lm": true, + "vmx-ins-outs": false, + "vpclmulqdq": false, + "hv-synic": false, + "xstore": false, + "fxsr-opt": true, + "fxsr_opt": true, + "rtm": false, + "kvm-hint-dedicated": false, + "lmce": false, + "hv-time": false, + "perfctr_nb": false, + "perfctr-nb": false, + "hv-tlbflush": false, + "ffxsr": true, + "rdrand": true, + "rdseed": true, + "avx512-4vnniw": false, + "vme": true, + "vmx": false, + "dtes64": false, + "mtrr": true, + "rdtscp": true, + "xsaveerptr": true, + "pse36": true, + "kvm-pv-tlb-flush": true, + "vmx-activity-wait-sipi": false, + "tbm": false, + "vmx-rdpmc-exit": false, + "wdt": false, + "level-func7": 0, + "vmx-entry-load-efer": false, + "vmx-mtf": false, + "pause_filter": false, + "model-id": "AMD EPYC 7502 32-Core Processor ", + "sha-ni": true, + "abm": true, + "vmx-ept-advanced-exitinfo": false, + "avx512pf": false, + "vmx-hlt-exit": false, + "xstore-en": false + } + } + }, + "id": "model-expansion" +} + +{ + "return": [ + { + "name": "max", + "typename": "max-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": false + }, + { + "name": "host", + "typename": "host-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": false + }, + { + "name": "base", + "typename": "base-x86_64-cpu", + "unavailable-features": [], + "static": true, + "migration-safe": true + }, + { + "name": "qemu64-v1", + "typename": "qemu64-v1-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": true + }, + { + "name": "qemu64", + "typename": "qemu64-x86_64-cpu", + "unavailable-features": [], + "alias-of": "qemu64-v1", + "static": false, + "migration-safe": true + }, + { + "name": "qemu32-v1", + "typename": "qemu32-v1-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": true + }, + { + "name": "qemu32", + "typename": "qemu32-x86_64-cpu", + "unavailable-features": [], + "alias-of": "qemu32-v1", + "static": false, + "migration-safe": true + }, + { + "name": "phenom-v1", + "typename": "phenom-v1-x86_64-cpu", + "unavailable-features": [ + "3dnowext", + "3dnow" + ], + "static": false, + "migration-safe": true + }, + { + "name": "phenom", + "typename": "phenom-x86_64-cpu", + "unavailable-features": [ + "3dnowext", + "3dnow" + ], + "alias-of": "phenom-v1", + "static": false, + "migration-safe": true + }, + { + "name": "pentium3-v1", + "typename": "pentium3-v1-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": true + }, + { + "name": "pentium3", + "typename": "pentium3-x86_64-cpu", + "unavailable-features": [], + "alias-of": "pentium3-v1", + "static": false, + "migration-safe": true + }, + { + "name": "pentium2-v1", + "typename": "pentium2-v1-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": true + }, + { + "name": "pentium2", + "typename": "pentium2-x86_64-cpu", + "unavailable-features": [], + "alias-of": "pentium2-v1", + "static": false, + "migration-safe": true + }, + { + "name": "pentium-v1", + "typename": "pentium-v1-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": true + }, + { + "name": "pentium", + "typename": "pentium-x86_64-cpu", + "unavailable-features": [], + "alias-of": "pentium-v1", + "static": false, + "migration-safe": true + }, + { + "name": "n270-v1", + "typename": "n270-v1-x86_64-cpu", + "unavailable-features": [ + "ss" + ], + "static": false, + "migration-safe": true + }, + { + "name": "n270", + "typename": "n270-x86_64-cpu", + "unavailable-features": [ + "ss" + ], + "alias-of": "n270-v1", + "static": false, + "migration-safe": true + }, + { + "name": "kvm64-v1", + "typename": "kvm64-v1-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": true + }, + { + "name": "kvm64", + "typename": "kvm64-x86_64-cpu", + "unavailable-features": [], + "alias-of": "kvm64-v1", + "static": false, + "migration-safe": true + }, + { + "name": "kvm32-v1", + "typename": "kvm32-v1-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": true + }, + { + "name": "kvm32", + "typename": "kvm32-x86_64-cpu", + "unavailable-features": [], + "alias-of": "kvm32-v1", + "static": false, + "migration-safe": true + }, + { + "name": "coreduo-v1", + "typename": "coreduo-v1-x86_64-cpu", + "unavailable-features": [ + "ss" + ], + "static": false, + "migration-safe": true + }, + { + "name": "coreduo", + "typename": "coreduo-x86_64-cpu", + "unavailable-features": [ + "ss" + ], + "alias-of": "coreduo-v1", + "static": false, + "migration-safe": true + }, + { + "name": "core2duo-v1", + "typename": "core2duo-v1-x86_64-cpu", + "unavailable-features": [ + "ss" + ], + "static": false, + "migration-safe": true + }, + { + "name": "core2duo", + "typename": "core2duo-x86_64-cpu", + "unavailable-features": [ + "ss" + ], + "alias-of": "core2duo-v1", + "static": false, + "migration-safe": true + }, + { + "name": "athlon-v1", + "typename": "athlon-v1-x86_64-cpu", + "unavailable-features": [ + "3dnowext", + "3dnow" + ], + "static": false, + "migration-safe": true + }, + { + "name": "athlon", + "typename": "athlon-x86_64-cpu", + "unavailable-features": [ + "3dnowext", + "3dnow" + ], + "alias-of": "athlon-v1", + "static": false, + "migration-safe": true + }, + { + "name": "Westmere-v2", + "typename": "Westmere-v2-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": true + }, + { + "name": "Westmere-v1", + "typename": "Westmere-v1-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": true + }, + { + "name": "Westmere-IBRS", + "typename": "Westmere-IBRS-x86_64-cpu", + "unavailable-features": [], + "alias-of": "Westmere-v2", + "static": false, + "migration-safe": true + }, + { + "name": "Westmere", + "typename": "Westmere-x86_64-cpu", + "unavailable-features": [], + "alias-of": "Westmere-v1", + "static": false, + "migration-safe": true + }, + { + "name": "Snowridge-v2", + "typename": "Snowridge-v2-x86_64-cpu", + "unavailable-features": [ + "erms", + "gfni", + "cldemote", + "movdiri", + "movdir64b", + "core-capability", + "split-lock-detect" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Snowridge-v1", + "typename": "Snowridge-v1-x86_64-cpu", + "unavailable-features": [ + "erms", + "mpx", + "gfni", + "cldemote", + "movdiri", + "movdir64b", + "core-capability", + "mpx", + "mpx", + "split-lock-detect" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Snowridge", + "typename": "Snowridge-x86_64-cpu", + "unavailable-features": [ + "erms", + "mpx", + "gfni", + "cldemote", + "movdiri", + "movdir64b", + "core-capability", + "mpx", + "mpx", + "split-lock-detect" + ], + "alias-of": "Snowridge-v1", + "static": false, + "migration-safe": true + }, + { + "name": "Skylake-Server-v3", + "typename": "Skylake-Server-v3-x86_64-cpu", + "unavailable-features": [ + "pcid", + "erms", + "invpcid", + "avx512f", + "avx512dq", + "avx512cd", + "avx512bw", + "avx512vl", + "pku", + "avx512f", + "avx512f", + "avx512f", + "pku" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Skylake-Server-v2", + "typename": "Skylake-Server-v2-x86_64-cpu", + "unavailable-features": [ + "pcid", + "hle", + "erms", + "invpcid", + "rtm", + "avx512f", + "avx512dq", + "avx512cd", + "avx512bw", + "avx512vl", + "pku", + "avx512f", + "avx512f", + "avx512f", + "pku" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Skylake-Server-v1", + "typename": "Skylake-Server-v1-x86_64-cpu", + "unavailable-features": [ + "pcid", + "hle", + "erms", + "invpcid", + "rtm", + "avx512f", + "avx512dq", + "avx512cd", + "avx512bw", + "avx512vl", + "pku", + "avx512f", + "avx512f", + "avx512f", + "pku" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Skylake-Server-noTSX-IBRS", + "typename": "Skylake-Server-noTSX-IBRS-x86_64-cpu", + "unavailable-features": [ + "pcid", + "erms", + "invpcid", + "avx512f", + "avx512dq", + "avx512cd", + "avx512bw", + "avx512vl", + "pku", + "avx512f", + "avx512f", + "avx512f", + "pku" + ], + "alias-of": "Skylake-Server-v3", + "static": false, + "migration-safe": true + }, + { + "name": "Skylake-Server-IBRS", + "typename": "Skylake-Server-IBRS-x86_64-cpu", + "unavailable-features": [ + "pcid", + "hle", + "erms", + "invpcid", + "rtm", + "avx512f", + "avx512dq", + "avx512cd", + "avx512bw", + "avx512vl", + "pku", + "avx512f", + "avx512f", + "avx512f", + "pku" + ], + "alias-of": "Skylake-Server-v2", + "static": false, + "migration-safe": true + }, + { + "name": "Skylake-Server", + "typename": "Skylake-Server-x86_64-cpu", + "unavailable-features": [ + "pcid", + "hle", + "erms", + "invpcid", + "rtm", + "avx512f", + "avx512dq", + "avx512cd", + "avx512bw", + "avx512vl", + "pku", + "avx512f", + "avx512f", + "avx512f", + "pku" + ], + "alias-of": "Skylake-Server-v1", + "static": false, + "migration-safe": true + }, + { + "name": "Skylake-Client-v3", + "typename": "Skylake-Client-v3-x86_64-cpu", + "unavailable-features": [ + "pcid", + "erms", + "invpcid" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Skylake-Client-v2", + "typename": "Skylake-Client-v2-x86_64-cpu", + "unavailable-features": [ + "pcid", + "hle", + "erms", + "invpcid", + "rtm" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Skylake-Client-v1", + "typename": "Skylake-Client-v1-x86_64-cpu", + "unavailable-features": [ + "pcid", + "hle", + "erms", + "invpcid", + "rtm" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Skylake-Client-noTSX-IBRS", + "typename": "Skylake-Client-noTSX-IBRS-x86_64-cpu", + "unavailable-features": [ + "pcid", + "erms", + "invpcid" + ], + "alias-of": "Skylake-Client-v3", + "static": false, + "migration-safe": true + }, + { + "name": "Skylake-Client-IBRS", + "typename": "Skylake-Client-IBRS-x86_64-cpu", + "unavailable-features": [ + "pcid", + "hle", + "erms", + "invpcid", + "rtm" + ], + "alias-of": "Skylake-Client-v2", + "static": false, + "migration-safe": true + }, + { + "name": "Skylake-Client", + "typename": "Skylake-Client-x86_64-cpu", + "unavailable-features": [ + "pcid", + "hle", + "erms", + "invpcid", + "rtm" + ], + "alias-of": "Skylake-Client-v1", + "static": false, + "migration-safe": true + }, + { + "name": "SandyBridge-v2", + "typename": "SandyBridge-v2-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": true + }, + { + "name": "SandyBridge-v1", + "typename": "SandyBridge-v1-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": true + }, + { + "name": "SandyBridge-IBRS", + "typename": "SandyBridge-IBRS-x86_64-cpu", + "unavailable-features": [], + "alias-of": "SandyBridge-v2", + "static": false, + "migration-safe": true + }, + { + "name": "SandyBridge", + "typename": "SandyBridge-x86_64-cpu", + "unavailable-features": [], + "alias-of": "SandyBridge-v1", + "static": false, + "migration-safe": true + }, + { + "name": "Penryn-v1", + "typename": "Penryn-v1-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": true + }, + { + "name": "Penryn", + "typename": "Penryn-x86_64-cpu", + "unavailable-features": [], + "alias-of": "Penryn-v1", + "static": false, + "migration-safe": true + }, + { + "name": "Opteron_G5-v1", + "typename": "Opteron_G5-v1-x86_64-cpu", + "unavailable-features": [ + "xop", + "fma4", + "tbm" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Opteron_G5", + "typename": "Opteron_G5-x86_64-cpu", + "unavailable-features": [ + "xop", + "fma4", + "tbm" + ], + "alias-of": "Opteron_G5-v1", + "static": false, + "migration-safe": true + }, + { + "name": "Opteron_G4-v1", + "typename": "Opteron_G4-v1-x86_64-cpu", + "unavailable-features": [ + "xop", + "fma4" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Opteron_G4", + "typename": "Opteron_G4-x86_64-cpu", + "unavailable-features": [ + "xop", + "fma4" + ], + "alias-of": "Opteron_G4-v1", + "static": false, + "migration-safe": true + }, + { + "name": "Opteron_G3-v1", + "typename": "Opteron_G3-v1-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": true + }, + { + "name": "Opteron_G3", + "typename": "Opteron_G3-x86_64-cpu", + "unavailable-features": [], + "alias-of": "Opteron_G3-v1", + "static": false, + "migration-safe": true + }, + { + "name": "Opteron_G2-v1", + "typename": "Opteron_G2-v1-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": true + }, + { + "name": "Opteron_G2", + "typename": "Opteron_G2-x86_64-cpu", + "unavailable-features": [], + "alias-of": "Opteron_G2-v1", + "static": false, + "migration-safe": true + }, + { + "name": "Opteron_G1-v1", + "typename": "Opteron_G1-v1-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": true + }, + { + "name": "Opteron_G1", + "typename": "Opteron_G1-x86_64-cpu", + "unavailable-features": [], + "alias-of": "Opteron_G1-v1", + "static": false, + "migration-safe": true + }, + { + "name": "Nehalem-v2", + "typename": "Nehalem-v2-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": true + }, + { + "name": "Nehalem-v1", + "typename": "Nehalem-v1-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": true + }, + { + "name": "Nehalem-IBRS", + "typename": "Nehalem-IBRS-x86_64-cpu", + "unavailable-features": [], + "alias-of": "Nehalem-v2", + "static": false, + "migration-safe": true + }, + { + "name": "Nehalem", + "typename": "Nehalem-x86_64-cpu", + "unavailable-features": [], + "alias-of": "Nehalem-v1", + "static": false, + "migration-safe": true + }, + { + "name": "KnightsMill-v1", + "typename": "KnightsMill-v1-x86_64-cpu", + "unavailable-features": [ + "ss", + "erms", + "avx512f", + "avx512pf", + "avx512er", + "avx512cd", + "avx512-vpopcntdq", + "avx512-4vnniw", + "avx512-4fmaps", + "avx512f", + "avx512f", + "avx512f" + ], + "static": false, + "migration-safe": true + }, + { + "name": "KnightsMill", + "typename": "KnightsMill-x86_64-cpu", + "unavailable-features": [ + "ss", + "erms", + "avx512f", + "avx512pf", + "avx512er", + "avx512cd", + "avx512-vpopcntdq", + "avx512-4vnniw", + "avx512-4fmaps", + "avx512f", + "avx512f", + "avx512f" + ], + "alias-of": "KnightsMill-v1", + "static": false, + "migration-safe": true + }, + { + "name": "IvyBridge-v2", + "typename": "IvyBridge-v2-x86_64-cpu", + "unavailable-features": [ + "erms" + ], + "static": false, + "migration-safe": true + }, + { + "name": "IvyBridge-v1", + "typename": "IvyBridge-v1-x86_64-cpu", + "unavailable-features": [ + "erms" + ], + "static": false, + "migration-safe": true + }, + { + "name": "IvyBridge-IBRS", + "typename": "IvyBridge-IBRS-x86_64-cpu", + "unavailable-features": [ + "erms" + ], + "alias-of": "IvyBridge-v2", + "static": false, + "migration-safe": true + }, + { + "name": "IvyBridge", + "typename": "IvyBridge-x86_64-cpu", + "unavailable-features": [ + "erms" + ], + "alias-of": "IvyBridge-v1", + "static": false, + "migration-safe": true + }, + { + "name": "Icelake-Server-v3", + "typename": "Icelake-Server-v3-x86_64-cpu", + "unavailable-features": [ + "pcid", + "erms", + "invpcid", + "avx512f", + "avx512dq", + "avx512cd", + "avx512bw", + "avx512vl", + "avx512vbmi", + "pku", + "avx512vbmi2", + "gfni", + "vaes", + "vpclmulqdq", + "avx512vnni", + "avx512bitalg", + "avx512-vpopcntdq", + "la57", + "avx512f", + "avx512f", + "avx512f", + "pku", + "ibrs-all", + "taa-no" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Icelake-Server-v2", + "typename": "Icelake-Server-v2-x86_64-cpu", + "unavailable-features": [ + "pcid", + "erms", + "invpcid", + "avx512f", + "avx512dq", + "avx512cd", + "avx512bw", + "avx512vl", + "avx512vbmi", + "pku", + "avx512vbmi2", + "gfni", + "vaes", + "vpclmulqdq", + "avx512vnni", + "avx512bitalg", + "avx512-vpopcntdq", + "la57", + "avx512f", + "avx512f", + "avx512f", + "pku" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Icelake-Server-v1", + "typename": "Icelake-Server-v1-x86_64-cpu", + "unavailable-features": [ + "pcid", + "hle", + "erms", + "invpcid", + "rtm", + "avx512f", + "avx512dq", + "avx512cd", + "avx512bw", + "avx512vl", + "avx512vbmi", + "pku", + "avx512vbmi2", + "gfni", + "vaes", + "vpclmulqdq", + "avx512vnni", + "avx512bitalg", + "avx512-vpopcntdq", + "la57", + "avx512f", + "avx512f", + "avx512f", + "pku" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Icelake-Server-noTSX", + "typename": "Icelake-Server-noTSX-x86_64-cpu", + "unavailable-features": [ + "pcid", + "erms", + "invpcid", + "avx512f", + "avx512dq", + "avx512cd", + "avx512bw", + "avx512vl", + "avx512vbmi", + "pku", + "avx512vbmi2", + "gfni", + "vaes", + "vpclmulqdq", + "avx512vnni", + "avx512bitalg", + "avx512-vpopcntdq", + "la57", + "avx512f", + "avx512f", + "avx512f", + "pku" + ], + "alias-of": "Icelake-Server-v2", + "static": false, + "migration-safe": true + }, + { + "name": "Icelake-Server", + "typename": "Icelake-Server-x86_64-cpu", + "unavailable-features": [ + "pcid", + "hle", + "erms", + "invpcid", + "rtm", + "avx512f", + "avx512dq", + "avx512cd", + "avx512bw", + "avx512vl", + "avx512vbmi", + "pku", + "avx512vbmi2", + "gfni", + "vaes", + "vpclmulqdq", + "avx512vnni", + "avx512bitalg", + "avx512-vpopcntdq", + "la57", + "avx512f", + "avx512f", + "avx512f", + "pku" + ], + "alias-of": "Icelake-Server-v1", + "static": false, + "migration-safe": true + }, + { + "name": "Icelake-Client-v2", + "typename": "Icelake-Client-v2-x86_64-cpu", + "unavailable-features": [ + "pcid", + "erms", + "invpcid", + "avx512vbmi", + "pku", + "avx512vbmi2", + "gfni", + "vaes", + "vpclmulqdq", + "avx512vnni", + "avx512bitalg", + "avx512-vpopcntdq", + "pku" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Icelake-Client-v1", + "typename": "Icelake-Client-v1-x86_64-cpu", + "unavailable-features": [ + "pcid", + "hle", + "erms", + "invpcid", + "rtm", + "avx512vbmi", + "pku", + "avx512vbmi2", + "gfni", + "vaes", + "vpclmulqdq", + "avx512vnni", + "avx512bitalg", + "avx512-vpopcntdq", + "pku" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Icelake-Client-noTSX", + "typename": "Icelake-Client-noTSX-x86_64-cpu", + "unavailable-features": [ + "pcid", + "erms", + "invpcid", + "avx512vbmi", + "pku", + "avx512vbmi2", + "gfni", + "vaes", + "vpclmulqdq", + "avx512vnni", + "avx512bitalg", + "avx512-vpopcntdq", + "pku" + ], + "alias-of": "Icelake-Client-v2", + "static": false, + "migration-safe": true + }, + { + "name": "Icelake-Client", + "typename": "Icelake-Client-x86_64-cpu", + "unavailable-features": [ + "pcid", + "hle", + "erms", + "invpcid", + "rtm", + "avx512vbmi", + "pku", + "avx512vbmi2", + "gfni", + "vaes", + "vpclmulqdq", + "avx512vnni", + "avx512bitalg", + "avx512-vpopcntdq", + "pku" + ], + "alias-of": "Icelake-Client-v1", + "static": false, + "migration-safe": true + }, + { + "name": "Haswell-v4", + "typename": "Haswell-v4-x86_64-cpu", + "unavailable-features": [ + "pcid", + "erms", + "invpcid" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Haswell-v3", + "typename": "Haswell-v3-x86_64-cpu", + "unavailable-features": [ + "pcid", + "hle", + "erms", + "invpcid", + "rtm" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Haswell-v2", + "typename": "Haswell-v2-x86_64-cpu", + "unavailable-features": [ + "pcid", + "erms", + "invpcid" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Haswell-v1", + "typename": "Haswell-v1-x86_64-cpu", + "unavailable-features": [ + "pcid", + "hle", + "erms", + "invpcid", + "rtm" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Haswell-noTSX-IBRS", + "typename": "Haswell-noTSX-IBRS-x86_64-cpu", + "unavailable-features": [ + "pcid", + "erms", + "invpcid" + ], + "alias-of": "Haswell-v4", + "static": false, + "migration-safe": true + }, + { + "name": "Haswell-noTSX", + "typename": "Haswell-noTSX-x86_64-cpu", + "unavailable-features": [ + "pcid", + "erms", + "invpcid" + ], + "alias-of": "Haswell-v2", + "static": false, + "migration-safe": true + }, + { + "name": "Haswell-IBRS", + "typename": "Haswell-IBRS-x86_64-cpu", + "unavailable-features": [ + "pcid", + "hle", + "erms", + "invpcid", + "rtm" + ], + "alias-of": "Haswell-v3", + "static": false, + "migration-safe": true + }, + { + "name": "Haswell", + "typename": "Haswell-x86_64-cpu", + "unavailable-features": [ + "pcid", + "hle", + "erms", + "invpcid", + "rtm" + ], + "alias-of": "Haswell-v1", + "static": false, + "migration-safe": true + }, + { + "name": "EPYC-v3", + "typename": "EPYC-v3-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": true + }, + { + "name": "EPYC-v2", + "typename": "EPYC-v2-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": true + }, + { + "name": "EPYC-v1", + "typename": "EPYC-v1-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": true + }, + { + "name": "EPYC-Rome-v1", + "typename": "EPYC-Rome-v1-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": true + }, + { + "name": "EPYC-Rome", + "typename": "EPYC-Rome-x86_64-cpu", + "unavailable-features": [], + "alias-of": "EPYC-Rome-v1", + "static": false, + "migration-safe": true + }, + { + "name": "EPYC-IBPB", + "typename": "EPYC-IBPB-x86_64-cpu", + "unavailable-features": [], + "alias-of": "EPYC-v2", + "static": false, + "migration-safe": true + }, + { + "name": "EPYC", + "typename": "EPYC-x86_64-cpu", + "unavailable-features": [], + "alias-of": "EPYC-v1", + "static": false, + "migration-safe": true + }, + { + "name": "Dhyana-v1", + "typename": "Dhyana-v1-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": true + }, + { + "name": "Dhyana", + "typename": "Dhyana-x86_64-cpu", + "unavailable-features": [], + "alias-of": "Dhyana-v1", + "static": false, + "migration-safe": true + }, + { + "name": "Denverton-v2", + "typename": "Denverton-v2-x86_64-cpu", + "unavailable-features": [ + "erms" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Denverton-v1", + "typename": "Denverton-v1-x86_64-cpu", + "unavailable-features": [ + "erms", + "mpx", + "mpx", + "mpx" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Denverton", + "typename": "Denverton-x86_64-cpu", + "unavailable-features": [ + "erms", + "mpx", + "mpx", + "mpx" + ], + "alias-of": "Denverton-v1", + "static": false, + "migration-safe": true + }, + { + "name": "Cooperlake-v1", + "typename": "Cooperlake-v1-x86_64-cpu", + "unavailable-features": [ + "pcid", + "hle", + "erms", + "invpcid", + "rtm", + "avx512f", + "avx512dq", + "avx512cd", + "avx512bw", + "avx512vl", + "pku", + "avx512vnni", + "avx512-bf16", + "avx512f", + "avx512f", + "avx512f", + "pku", + "ibrs-all", + "taa-no" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Cooperlake", + "typename": "Cooperlake-x86_64-cpu", + "unavailable-features": [ + "pcid", + "hle", + "erms", + "invpcid", + "rtm", + "avx512f", + "avx512dq", + "avx512cd", + "avx512bw", + "avx512vl", + "pku", + "avx512vnni", + "avx512-bf16", + "avx512f", + "avx512f", + "avx512f", + "pku", + "ibrs-all", + "taa-no" + ], + "alias-of": "Cooperlake-v1", + "static": false, + "migration-safe": true + }, + { + "name": "Conroe-v1", + "typename": "Conroe-v1-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": true + }, + { + "name": "Conroe", + "typename": "Conroe-x86_64-cpu", + "unavailable-features": [], + "alias-of": "Conroe-v1", + "static": false, + "migration-safe": true + }, + { + "name": "Cascadelake-Server-v3", + "typename": "Cascadelake-Server-v3-x86_64-cpu", + "unavailable-features": [ + "pcid", + "erms", + "invpcid", + "avx512f", + "avx512dq", + "avx512cd", + "avx512bw", + "avx512vl", + "pku", + "avx512vnni", + "avx512f", + "avx512f", + "avx512f", + "pku", + "ibrs-all" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Cascadelake-Server-v2", + "typename": "Cascadelake-Server-v2-x86_64-cpu", + "unavailable-features": [ + "pcid", + "hle", + "erms", + "invpcid", + "rtm", + "avx512f", + "avx512dq", + "avx512cd", + "avx512bw", + "avx512vl", + "pku", + "avx512vnni", + "avx512f", + "avx512f", + "avx512f", + "pku", + "ibrs-all" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Cascadelake-Server-v1", + "typename": "Cascadelake-Server-v1-x86_64-cpu", + "unavailable-features": [ + "pcid", + "hle", + "erms", + "invpcid", + "rtm", + "avx512f", + "avx512dq", + "avx512cd", + "avx512bw", + "avx512vl", + "pku", + "avx512vnni", + "avx512f", + "avx512f", + "avx512f", + "pku" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Cascadelake-Server-noTSX", + "typename": "Cascadelake-Server-noTSX-x86_64-cpu", + "unavailable-features": [ + "pcid", + "erms", + "invpcid", + "avx512f", + "avx512dq", + "avx512cd", + "avx512bw", + "avx512vl", + "pku", + "avx512vnni", + "avx512f", + "avx512f", + "avx512f", + "pku", + "ibrs-all" + ], + "alias-of": "Cascadelake-Server-v3", + "static": false, + "migration-safe": true + }, + { + "name": "Cascadelake-Server", + "typename": "Cascadelake-Server-x86_64-cpu", + "unavailable-features": [ + "pcid", + "hle", + "erms", + "invpcid", + "rtm", + "avx512f", + "avx512dq", + "avx512cd", + "avx512bw", + "avx512vl", + "pku", + "avx512vnni", + "avx512f", + "avx512f", + "avx512f", + "pku" + ], + "alias-of": "Cascadelake-Server-v1", + "static": false, + "migration-safe": true + }, + { + "name": "Broadwell-v4", + "typename": "Broadwell-v4-x86_64-cpu", + "unavailable-features": [ + "pcid", + "erms", + "invpcid" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Broadwell-v3", + "typename": "Broadwell-v3-x86_64-cpu", + "unavailable-features": [ + "pcid", + "hle", + "erms", + "invpcid", + "rtm" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Broadwell-v2", + "typename": "Broadwell-v2-x86_64-cpu", + "unavailable-features": [ + "pcid", + "erms", + "invpcid" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Broadwell-v1", + "typename": "Broadwell-v1-x86_64-cpu", + "unavailable-features": [ + "pcid", + "hle", + "erms", + "invpcid", + "rtm" + ], + "static": false, + "migration-safe": true + }, + { + "name": "Broadwell-noTSX-IBRS", + "typename": "Broadwell-noTSX-IBRS-x86_64-cpu", + "unavailable-features": [ + "pcid", + "erms", + "invpcid" + ], + "alias-of": "Broadwell-v4", + "static": false, + "migration-safe": true + }, + { + "name": "Broadwell-noTSX", + "typename": "Broadwell-noTSX-x86_64-cpu", + "unavailable-features": [ + "pcid", + "erms", + "invpcid" + ], + "alias-of": "Broadwell-v2", + "static": false, + "migration-safe": true + }, + { + "name": "Broadwell-IBRS", + "typename": "Broadwell-IBRS-x86_64-cpu", + "unavailable-features": [ + "pcid", + "hle", + "erms", + "invpcid", + "rtm" + ], + "alias-of": "Broadwell-v3", + "static": false, + "migration-safe": true + }, + { + "name": "Broadwell", + "typename": "Broadwell-x86_64-cpu", + "unavailable-features": [ + "pcid", + "hle", + "erms", + "invpcid", + "rtm" + ], + "alias-of": "Broadwell-v1", + "static": false, + "migration-safe": true + }, + { + "name": "486-v1", + "typename": "486-v1-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": true + }, + { + "name": "486", + "typename": "486-x86_64-cpu", + "unavailable-features": [], + "alias-of": "486-v1", + "static": false, + "migration-safe": true + } + ], + "id": "definitions" +} diff --git a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core.sig b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core.sig new file mode 100644 index 0000000000..cf54739de9 --- /dev/null +++ b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core.sig @@ -0,0 +1,4 @@ +830f10 +family: 23 (0x17) +model: 49 (0x31) +stepping: 0 (0x00) diff --git a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core.xml b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core.xml new file mode 100644 index 0000000000..fc4fd433dd --- /dev/null +++ b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core.xml @@ -0,0 +1,66 @@ + +<cpudata arch='x86'> + <cpuid eax_in='0x00000000' ecx_in='0x00' eax='0x00000010' ebx='0x68747541' ecx='0x444d4163' edx='0x69746e65'/> + <cpuid eax_in='0x00000001' ecx_in='0x00' eax='0x00830f10' ebx='0x18400800' ecx='0x7ed8320b' edx='0x178bfbff'/> + <cpuid eax_in='0x00000002' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x00000003' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x00000005' ecx_in='0x00' eax='0x00000040' ebx='0x00000040' ecx='0x00000003' edx='0x00000011'/> + <cpuid eax_in='0x00000006' ecx_in='0x00' eax='0x00000004' ebx='0x00000000' ecx='0x00000001' edx='0x00000000'/> + <cpuid eax_in='0x00000007' ecx_in='0x00' eax='0x00000000' ebx='0x219c91a9' ecx='0x00400004' edx='0x00000000'/> + <cpuid eax_in='0x00000008' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x00000009' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x0000000a' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x0000000b' ecx_in='0x00' eax='0x00000001' ebx='0x00000002' ecx='0x00000100' edx='0x00000018'/> + <cpuid eax_in='0x0000000b' ecx_in='0x01' eax='0x00000007' ebx='0x00000040' ecx='0x00000201' edx='0x00000018'/> + <cpuid eax_in='0x0000000c' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x0000000d' ecx_in='0x00' eax='0x00000207' ebx='0x00000340' ecx='0x00000380' edx='0x00000000'/> + <cpuid eax_in='0x0000000d' ecx_in='0x01' eax='0x0000000f' ebx='0x00000340' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x0000000d' ecx_in='0x02' eax='0x00000100' ebx='0x00000240' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x0000000d' ecx_in='0x09' eax='0x00000040' ebx='0x00000340' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x0000000e' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x0000000f' ecx_in='0x00' eax='0x00000000' ebx='0x000000ff' ecx='0x00000000' edx='0x00000002'/> + <cpuid eax_in='0x0000000f' ecx_in='0x01' eax='0x00000000' ebx='0x00000040' ecx='0x000000ff' edx='0x00000007'/> + <cpuid eax_in='0x00000010' ecx_in='0x00' eax='0x00000000' ebx='0x00000002' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x00000010' ecx_in='0x01' eax='0x0000000f' ebx='0x00000000' ecx='0x00000004' edx='0x0000000f'/> + <cpuid eax_in='0x20000000' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x80000000' ecx_in='0x00' eax='0x80000020' ebx='0x68747541' ecx='0x444d4163' edx='0x69746e65'/> + <cpuid eax_in='0x80000001' ecx_in='0x00' eax='0x00830f10' ebx='0x40000000' ecx='0x75c237ff' edx='0x2fd3fbff'/> + <cpuid eax_in='0x80000002' ecx_in='0x00' eax='0x20444d41' ebx='0x43595045' ecx='0x30353720' edx='0x32332032'/> + <cpuid eax_in='0x80000003' ecx_in='0x00' eax='0x726f432d' ebx='0x72502065' ecx='0x7365636f' edx='0x20726f73'/> + <cpuid eax_in='0x80000004' ecx_in='0x00' eax='0x20202020' ebx='0x20202020' ecx='0x20202020' edx='0x00202020'/> + <cpuid eax_in='0x80000005' ecx_in='0x00' eax='0xff40ff40' ebx='0xff40ff40' ecx='0x20080140' edx='0x20080140'/> + <cpuid eax_in='0x80000006' ecx_in='0x00' eax='0x48006400' ebx='0x68006400' ecx='0x02006140' edx='0x04009140'/> + <cpuid eax_in='0x80000007' ecx_in='0x00' eax='0x00000000' ebx='0x0000001b' ecx='0x00000000' edx='0x00006799'/> + <cpuid eax_in='0x80000008' ecx_in='0x00' eax='0x00003030' ebx='0x018cf757' ecx='0x0000703f' edx='0x00010000'/> + <cpuid eax_in='0x80000009' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x8000000a' ecx_in='0x00' eax='0x00000001' ebx='0x00008000' ecx='0x00000000' edx='0x0013bcff'/> + <cpuid eax_in='0x8000000b' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x8000000c' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x8000000d' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x8000000e' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x8000000f' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x80000010' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x80000011' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x80000012' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x80000013' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x80000014' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x80000015' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x80000016' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x80000017' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x80000018' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x80000019' ecx_in='0x00' eax='0xf040f040' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x8000001a' ecx_in='0x00' eax='0x00000006' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x8000001b' ecx_in='0x00' eax='0x000003ff' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x8000001c' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x8000001d' ecx_in='0x00' eax='0x00004121' ebx='0x01c0003f' ecx='0x0000003f' edx='0x00000000'/> + <cpuid eax_in='0x8000001d' ecx_in='0x01' eax='0x00004122' ebx='0x01c0003f' ecx='0x0000003f' edx='0x00000000'/> + <cpuid eax_in='0x8000001d' ecx_in='0x02' eax='0x00004143' ebx='0x01c0003f' ecx='0x000003ff' edx='0x00000002'/> + <cpuid eax_in='0x8000001d' ecx_in='0x03' eax='0x0001c163' ebx='0x03c0003f' ecx='0x00003fff' edx='0x00000001'/> + <cpuid eax_in='0x8000001e' ecx_in='0x00' eax='0x00000018' ebx='0x0000010c' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x8000001f' ecx_in='0x00' eax='0x0001000f' ebx='0x0000016f' ecx='0x000001fd' edx='0x00000001'/> + <cpuid eax_in='0x80000020' ecx_in='0x00' eax='0x00000000' ebx='0x00000002' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x80000020' ecx_in='0x01' eax='0x0000000b' ebx='0x00000000' ecx='0x00000000' edx='0x0000000f'/> + <cpuid eax_in='0x80860000' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0xc0000000' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> + <msr index='0x10a' edx='0x00000000' eax='0x00000069'/> +</cpudata> diff --git a/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-disabled.xml b/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-disabled.xml index 869659cc80..ca71b9efb5 100644 --- a/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-disabled.xml +++ b/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-disabled.xml @@ -5,6 +5,5 @@ <cpuid eax_in='0x0000000f' ecx_in='0x01' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000006'/> <cpuid eax_in='0x80000001' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x01423408' edx='0x00000000'/> <cpuid eax_in='0x80000007' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000100'/> - <cpuid eax_in='0x80000008' ecx_in='0x00' eax='0x00000000' ebx='0x00008000' ecx='0x00000000' edx='0x00000000'/> <cpuid eax_in='0x8000000a' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x000014f6'/> </cpudata> diff --git a/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-enabled.xml b/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-enabled.xml index 7458db25ab..55f41693d9 100644 --- a/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-enabled.xml +++ b/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-enabled.xml @@ -5,7 +5,7 @@ <cpuid eax_in='0x00000007' ecx_in='0x00' eax='0x00000000' ebx='0x219c01ab' ecx='0x00400004' edx='0xa8000000'/> <cpuid eax_in='0x0000000d' ecx_in='0x01' eax='0x0000000f' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> <cpuid eax_in='0x80000001' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x008003f7' edx='0x2e500800'/> - <cpuid eax_in='0x80000008' ecx_in='0x00' eax='0x00000000' ebx='0x03001205' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x80000008' ecx_in='0x00' eax='0x00000000' ebx='0x03009205' ecx='0x00000000' edx='0x00000000'/> <cpuid eax_in='0x8000000a' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000009'/> <msr index='0x10a' edx='0x00000000' eax='0x00000069'/> </cpudata> diff --git a/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-guest.xml b/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-guest.xml index 1320f65a58..a49ef46f52 100644 --- a/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-guest.xml +++ b/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-guest.xml @@ -1,12 +1,10 @@ <cpu mode='custom' match='exact'> - <model fallback='forbid'>EPYC-IBPB</model> + <model fallback='forbid'>EPYC-Rome</model> <vendor>AMD</vendor> <feature policy='require' name='ht'/> <feature policy='require' name='osxsave'/> <feature policy='require' name='cmt'/> - <feature policy='require' name='clwb'/> <feature policy='require' name='umip'/> - <feature policy='require' name='rdpid'/> <feature policy='require' name='xsaves'/> <feature policy='require' name='mbm_total'/> <feature policy='require' name='mbm_local'/> @@ -17,13 +15,8 @@ <feature policy='require' name='wdt'/> <feature policy='require' name='tce'/> <feature policy='require' name='topoext'/> - <feature policy='require' name='perfctr_core'/> <feature policy='require' name='perfctr_nb'/> <feature policy='require' name='invtsc'/> - <feature policy='require' name='clzero'/> - <feature policy='require' name='xsaveerptr'/> - <feature policy='require' name='wbnoinvd'/> - <feature policy='require' name='amd-stibp'/> <feature policy='require' name='amd-ssbd'/> <feature policy='require' name='npt'/> <feature policy='require' name='lbrv'/> diff --git a/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-host.xml b/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-host.xml index 37905ec812..e9aea3339a 100644 --- a/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-host.xml +++ b/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-host.xml @@ -1,13 +1,11 @@ <cpu> <arch>x86_64</arch> - <model>EPYC-IBPB</model> + <model>EPYC-Rome</model> <vendor>AMD</vendor> <feature name='ht'/> <feature name='osxsave'/> <feature name='cmt'/> - <feature name='clwb'/> <feature name='umip'/> - <feature name='rdpid'/> <feature name='xsaves'/> <feature name='mbm_total'/> <feature name='mbm_local'/> @@ -18,13 +16,8 @@ <feature name='wdt'/> <feature name='tce'/> <feature name='topoext'/> - <feature name='perfctr_core'/> <feature name='perfctr_nb'/> <feature name='invtsc'/> - <feature name='clzero'/> - <feature name='xsaveerptr'/> - <feature name='wbnoinvd'/> - <feature name='amd-stibp'/> <feature name='amd-ssbd'/> <feature name='npt'/> <feature name='lbrv'/> diff --git a/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-json.xml b/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-json.xml index fba378e030..5b83c04d3f 100644 --- a/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-json.xml +++ b/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-json.xml @@ -1,22 +1,16 @@ <cpu mode='custom' match='exact'> - <model fallback='forbid'>EPYC-IBPB</model> + <model fallback='forbid'>EPYC-Rome</model> <vendor>AMD</vendor> <feature policy='require' name='x2apic'/> <feature policy='require' name='tsc-deadline'/> <feature policy='require' name='hypervisor'/> <feature policy='require' name='tsc_adjust'/> - <feature policy='require' name='clwb'/> <feature policy='require' name='umip'/> - <feature policy='require' name='rdpid'/> <feature policy='require' name='stibp'/> <feature policy='require' name='arch-capabilities'/> <feature policy='require' name='ssbd'/> <feature policy='require' name='xsaves'/> <feature policy='require' name='cmp_legacy'/> - <feature policy='require' name='perfctr_core'/> - <feature policy='require' name='clzero'/> - <feature policy='require' name='xsaveerptr'/> - <feature policy='require' name='wbnoinvd'/> <feature policy='require' name='amd-ssbd'/> <feature policy='require' name='virt-ssbd'/> <feature policy='require' name='npt'/> diff --git a/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core.json b/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core.json index fbdf1a794a..9ecc965e53 100644 --- a/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core.json +++ b/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core.json @@ -313,6 +313,7 @@ "tsc_scale": false, "tsc-scale": false, "topoext": false, + "amd-stibp": true, "hv-vpindex": false, "hv-no-nonarch-coresharing": "off", "vmx-preemption-timer": false, @@ -1501,6 +1502,13 @@ "static": false, "migration-safe": true }, + { + "name": "EPYC-v3", + "typename": "EPYC-v3-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": true + }, { "name": "EPYC-v2", "typename": "EPYC-v2-x86_64-cpu", @@ -1515,6 +1523,21 @@ "static": false, "migration-safe": true }, + { + "name": "EPYC-Rome-v1", + "typename": "EPYC-Rome-v1-x86_64-cpu", + "unavailable-features": [], + "static": false, + "migration-safe": true + }, + { + "name": "EPYC-Rome", + "typename": "EPYC-Rome-x86_64-cpu", + "unavailable-features": [], + "alias-of": "EPYC-Rome-v1", + "static": false, + "migration-safe": true + }, { "name": "EPYC-IBPB", "typename": "EPYC-IBPB-x86_64-cpu", diff --git a/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core.xml b/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core.xml index c8db5e3e10..40abc48762 100644 --- a/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core.xml +++ b/tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core.xml @@ -1,7 +1,7 @@  <cpudata arch='x86'> <cpuid eax_in='0x00000000' ecx_in='0x00' eax='0x00000010' ebx='0x68747541' ecx='0x444d4163' edx='0x69746e65'/> - <cpuid eax_in='0x00000001' ecx_in='0x00' eax='0x00870f10' ebx='0x10180800' ecx='0x7ed8320b' edx='0x178bfbff'/> + <cpuid eax_in='0x00000001' ecx_in='0x00' eax='0x00870f10' ebx='0x0a180800' ecx='0x7ed8320b' edx='0x178bfbff'/> <cpuid eax_in='0x00000002' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> <cpuid eax_in='0x00000003' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> <cpuid eax_in='0x00000005' ecx_in='0x00' eax='0x00000040' ebx='0x00000040' ecx='0x00000003' edx='0x00000011'/> @@ -10,8 +10,8 @@ <cpuid eax_in='0x00000008' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> <cpuid eax_in='0x00000009' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> <cpuid eax_in='0x0000000a' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> - <cpuid eax_in='0x0000000b' ecx_in='0x00' eax='0x00000001' ebx='0x00000002' ecx='0x00000100' edx='0x00000010'/> - <cpuid eax_in='0x0000000b' ecx_in='0x01' eax='0x00000007' ebx='0x00000018' ecx='0x00000201' edx='0x00000010'/> + <cpuid eax_in='0x0000000b' ecx_in='0x00' eax='0x00000001' ebx='0x00000002' ecx='0x00000100' edx='0x0000000a'/> + <cpuid eax_in='0x0000000b' ecx_in='0x01' eax='0x00000007' ebx='0x00000018' ecx='0x00000201' edx='0x0000000a'/> <cpuid eax_in='0x0000000c' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000000'/> <cpuid eax_in='0x0000000d' ecx_in='0x00' eax='0x00000207' ebx='0x00000340' ecx='0x00000380' edx='0x00000000'/> <cpuid eax_in='0x0000000d' ecx_in='0x01' eax='0x0000000f' ebx='0x00000340' ecx='0x00000000' edx='0x00000000'/> @@ -26,8 +26,8 @@ <cpuid eax_in='0x80000000' ecx_in='0x00' eax='0x80000020' ebx='0x68747541' ecx='0x444d4163' edx='0x69746e65'/> <cpuid eax_in='0x80000001' ecx_in='0x00' eax='0x00870f10' ebx='0x20000000' ecx='0x75c237ff' edx='0x2fd3fbff'/> <cpuid eax_in='0x80000002' ecx_in='0x00' eax='0x20444d41' ebx='0x657a7952' ecx='0x2039206e' edx='0x30303933'/> - <cpuid eax_in='0x80000003' ecx_in='0x00' eax='0x32312058' ebx='0x726f432d' ecx='0x72502065' edx='0x7365636f'/> - <cpuid eax_in='0x80000004' ecx_in='0x00' eax='0x20726f73' ebx='0x20202020' ecx='0x20202020' edx='0x00202020'/> + <cpuid eax_in='0x80000003' ecx_in='0x00' eax='0x2d323120' ebx='0x65726f43' ecx='0x6f725020' edx='0x73736563'/> + <cpuid eax_in='0x80000004' ecx_in='0x00' eax='0x2020726f' ebx='0x20202020' ecx='0x20202020' edx='0x00202020'/> <cpuid eax_in='0x80000005' ecx_in='0x00' eax='0xff40ff40' ebx='0xff40ff40' ecx='0x20080140' edx='0x20080140'/> <cpuid eax_in='0x80000006' ecx_in='0x00' eax='0x48006400' ebx='0x68006400' ecx='0x02006140' edx='0x02009140'/> <cpuid eax_in='0x80000007' ecx_in='0x00' eax='0x00000000' ebx='0x0000001b' ecx='0x00000000' edx='0x00006799'/> @@ -56,7 +56,7 @@ <cpuid eax_in='0x8000001d' ecx_in='0x01' eax='0x00004122' ebx='0x01c0003f' ecx='0x0000003f' edx='0x00000000'/> <cpuid eax_in='0x8000001d' ecx_in='0x02' eax='0x00004143' ebx='0x01c0003f' ecx='0x000003ff' edx='0x00000002'/> <cpuid eax_in='0x8000001d' ecx_in='0x03' eax='0x00014163' ebx='0x03c0003f' ecx='0x00003fff' edx='0x00000001'/> - <cpuid eax_in='0x8000001e' ecx_in='0x00' eax='0x00000010' ebx='0x00000108' ecx='0x00000000' edx='0x00000000'/> + <cpuid eax_in='0x8000001e' ecx_in='0x00' eax='0x0000000a' ebx='0x00000105' ecx='0x00000000' edx='0x00000000'/> <cpuid eax_in='0x8000001f' ecx_in='0x00' eax='0x0001000f' ebx='0x0000016f' ecx='0x000001fd' edx='0x00000001'/> <cpuid eax_in='0x80000020' ecx_in='0x00' eax='0x00000000' ebx='0x00000002' ecx='0x00000000' edx='0x00000000'/> <cpuid eax_in='0x80000020' ecx_in='0x01' eax='0x0000000b' ebx='0x00000000' ecx='0x00000000' edx='0x0000000f'/> -- 2.26.2

2 1

[PATCH 0/6] qemu: migration: Rename and refactor migration cookie/parser formatter
by Peter Krempa 30 Sep '20

30 Sep '20

Peter Krempa (6): qemu: migration: Rename qemuMigrationBakeCookie to qemuMigrationCookieFormat qemuMigrationCookieNew: Refactor allocation and cleanup qemuMigrationCookieNew: Export qemuMigrationSrcBeginPhase: Use qemuMigrationCookieNew qemuMigrationCookieXMLFormatStr: Remove qemu: migration: Rename qemuMigrationEatCookie to qemuMigrationCookieParse src/qemu/qemu_migration.c | 69 +++++++++++++------------- src/qemu/qemu_migration_cookie.c | 85 ++++++++++++++------------------ src/qemu/qemu_migration_cookie.h | 32 ++++++------ 3 files changed, 88 insertions(+), 98 deletions(-) -- 2.26.2

3 13

RFE - Add support for QEMU's 9pfs's fmode/dmode options
by Brian Turek 30 Sep '20

30 Sep '20

Hello All, I recently ran into problems with the default very restrictive permissions for files that are created via 9pfs host/guest shares (600 for files, 700 for directories). QEMU added two new-ish flags, fmode and dmode, to its 9pfs implementation so that users are able to control these exact permissions. Would it be possible to expose these two flags via the domain XML? I made an issue on the libvirt Gitlab ( https://gitlab.com/libvirt/libvirt/-/issues/80) but it appears mailing list posts may be preferred. Thank you

2 1

Renaming the 'master' branch
by Ján Tomko 30 Sep '20

30 Sep '20

According to latest fashion trends, it is possible to rename the default branch. Can we rename it to 'main'? It's one less syllable and two letters shorter. Jano

3 3

[PATCH] virDomainNumaFillCPUsInNode: Skip over NUMA nodes without vCPUs
by Michal Privoznik 30 Sep '20

30 Sep '20

After v6.5.0-rc1~148 we started to rectify vCPU to guest NUMA assignment - if there is a vCPU not assigned to any guest NUMA node it is automatically assigned to node #0. A month later I've made it possible to define guest NUMA nodes without vCPUs (v6.6.0-rc1~250) - this is needed because of HMAT. As a part of that I fixed all callers of virDomainNumaGetNodeCpumask() (which returns a bitmap of vCPUs for given node) to handle case when NULL is returned (i.e. no vCPUs assigned to given node). But of course my patch was written before aforementioned vCPU rectify patch but merged afterwards and hence I missed the virDomainNumaFillCPUsInNode() caller. And because we are dealing with a NULL pointer, of course this leads to a crash. Just try to define a domain with at least two NUMA nodes and no vCPU assignment to any of the nodes. Fixes: a26f61ee0cffa421b87ef568002b684dd8025432 Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1880289 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/conf/numa_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c index bfa312215c..cc6c77f105 100644 --- a/src/conf/numa_conf.c +++ b/src/conf/numa_conf.c @@ -1816,7 +1816,7 @@ virDomainNumaFillCPUsInNode(virDomainNumaPtr numa, for (i = 0; i < numa->nmem_nodes; i++) { virBitmapPtr nodeCpus = virDomainNumaGetNodeCpumask(numa, i); - if (i == node) + if (i == node || !nodeCpus) continue; virBitmapSubtract(maxCPUsBitmap, nodeCpus); -- 2.26.2

2 1

Re: [libvirt PATCH] cpu_map: Add EPYC-Rome model
by Markus Schade 30 Sep '20

30 Sep '20

Okay, that did not go as expected. Anyway This patch add the qemu EPYC-Rome model and includes cpuid data from an EPYC 7502 system as well as updated cpuid information from a Ryzen 9 3900 system. Since the EPYC 7502 and the Ryzen 9 are pretty much identical, the latter could be dropped as there is no corresponding qemu model. Markus

2 2

[libvirt PATCH 0/7] use g_new0 more: volume two (glib chronicles)
by Ján Tomko 29 Sep '20

29 Sep '20

Ján Tomko (7): bhyve: use g_new0 instead of VIR_ALLOC* esx: use g_new0 instead of VIR_ALLOC* hyperv: use g_new0 instead of VIR_ALLOC* interface: use g_new0 instead of VIR_ALLOC* src: libvirt-stream: use g_new0 instead of VIR_ALLOC* storage: scsi: invert logic in createVport storage: use g_new0 instead of VIR_ALLOC* src/bhyve/bhyve_capabilities.c | 3 +- src/bhyve/bhyve_domain.c | 9 ++---- src/bhyve/bhyve_driver.c | 3 +- src/bhyve/bhyve_parse_command.c | 7 ++--- src/esx/esx_driver.c | 14 ++++----- src/esx/esx_network_driver.c | 17 ++++------- src/esx/esx_storage_backend_iscsi.c | 3 +- src/esx/esx_storage_backend_vmfs.c | 8 ++--- src/esx/esx_stream.c | 6 ++-- src/esx/esx_util.c | 3 +- src/esx/esx_vi.c | 12 +++----- src/esx/esx_vi_types.c | 3 +- src/hyperv/hyperv_driver.c | 13 ++++----- src/hyperv/hyperv_util.c | 3 +- src/hyperv/hyperv_wmi.c | 13 ++------- src/interface/interface_backend_netcf.c | 16 ++++------ src/interface/interface_backend_udev.c | 22 +++++--------- src/libvirt-stream.c | 12 +++----- src/storage/storage_backend_disk.c | 6 ++-- src/storage/storage_backend_fs.c | 8 ++--- src/storage/storage_backend_gluster.c | 12 +++----- src/storage/storage_backend_iscsi.c | 8 ++--- src/storage/storage_backend_iscsi_direct.c | 13 ++++----- src/storage/storage_backend_logical.c | 6 ++-- src/storage/storage_backend_mpath.c | 3 +- src/storage/storage_backend_rbd.c | 29 +++++++----------- src/storage/storage_backend_scsi.c | 17 +++++------ src/storage/storage_backend_sheepdog.c | 3 +- src/storage/storage_backend_zfs.c | 3 +- src/storage/storage_driver.c | 14 +++------ src/storage/storage_file_fs.c | 3 +- src/storage/storage_file_gluster.c | 6 ++-- src/storage/storage_util.c | 34 ++++++++-------------- 33 files changed, 117 insertions(+), 215 deletions(-) -- 2.26.2

3 15

[libvirt PATCH 0/2] fix compat with other rst2html5 tool impl
by Daniel P. Berrangé 29 Sep '20

29 Sep '20

Daniel P. Berrangé (2): ci: introduce pygments package to install docs: specify "sh" as the language for code-block directives .gitlab-ci.yml | 2 +- ci/cirrus/build.yml | 6 +- ci/cirrus/libvirt-freebsd-11.vars | 5 +- ci/cirrus/libvirt-freebsd-12.vars | 5 +- ci/cirrus/libvirt-macos-1015.vars | 6 +- ci/cirrus/refresh | 2 +- ci/containers/libvirt-centos-7.Dockerfile | 1 + ci/containers/libvirt-centos-8.Dockerfile | 1 + .../libvirt-centos-stream.Dockerfile | 1 + ...libvirt-debian-10-cross-aarch64.Dockerfile | 1 + .../libvirt-debian-10-cross-armv6l.Dockerfile | 1 + .../libvirt-debian-10-cross-armv7l.Dockerfile | 1 + .../libvirt-debian-10-cross-i686.Dockerfile | 1 + .../libvirt-debian-10-cross-mips.Dockerfile | 1 + ...ibvirt-debian-10-cross-mips64el.Dockerfile | 1 + .../libvirt-debian-10-cross-mipsel.Dockerfile | 1 + ...libvirt-debian-10-cross-ppc64le.Dockerfile | 1 + .../libvirt-debian-10-cross-s390x.Dockerfile | 1 + ci/containers/libvirt-debian-10.Dockerfile | 1 + ...ibvirt-debian-sid-cross-aarch64.Dockerfile | 1 + ...libvirt-debian-sid-cross-armv6l.Dockerfile | 1 + ...libvirt-debian-sid-cross-armv7l.Dockerfile | 1 + .../libvirt-debian-sid-cross-i686.Dockerfile | 1 + ...bvirt-debian-sid-cross-mips64el.Dockerfile | 1 + ...libvirt-debian-sid-cross-mipsel.Dockerfile | 1 + ...ibvirt-debian-sid-cross-ppc64le.Dockerfile | 1 + .../libvirt-debian-sid-cross-s390x.Dockerfile | 1 + ci/containers/libvirt-debian-sid.Dockerfile | 1 + ci/containers/libvirt-fedora-31.Dockerfile | 1 + ci/containers/libvirt-fedora-32.Dockerfile | 1 + ...rt-fedora-rawhide-cross-mingw32.Dockerfile | 1 + ...rt-fedora-rawhide-cross-mingw64.Dockerfile | 1 + .../libvirt-fedora-rawhide.Dockerfile | 1 + ci/containers/libvirt-opensuse-151.Dockerfile | 1 + ci/containers/libvirt-ubuntu-1804.Dockerfile | 1 + ci/containers/libvirt-ubuntu-2004.Dockerfile | 1 + docs/manpages/libvirtd.rst | 4 +- docs/manpages/virsh.rst | 582 +++++++++--------- docs/manpages/virt-admin.rst | 52 +- docs/manpages/virtlockd.rst | 4 +- docs/manpages/virtlogd.rst | 4 +- 41 files changed, 366 insertions(+), 336 deletions(-) -- 2.26.2

2 4

[PATCH] docs: bhyve: document sound device and VNC bits
by Roman Bogorodskiy 29 Sep '20

29 Sep '20

* Document sound device support, * Document VNC password configuration and framebuffer resolution. Signed-off-by: Roman Bogorodskiy <bogorodskiy(a)gmail.com> --- docs/drvbhyve.html.in | 47 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) diff --git a/docs/drvbhyve.html.in b/docs/drvbhyve.html.in index ca511eeccd..cffb63f1ad 100644 --- a/docs/drvbhyve.html.in +++ b/docs/drvbhyve.html.in @@ -389,6 +389,30 @@ it with the <code>port</code> attribute):</p> <graphics type='vnc' autoport='yes'> </pre> +<p><span class="since">Since 6.8.0</span>, it's possible to set framebuffer resolution +using the <code>resolution</code> sub-element:</p> + +<pre> + <video> + <model type='gop' heads='1' primary='yes'> + <resolution x='800' y='600'/> + </model> + </video> +</pre> + +<p><span class="since">Since 6.8.0</span>, VNC server can be configured to use +password based authentication:</p> + +<pre> + <graphics type='vnc' port='5904' passwd='foobar'> + <listen type='address' address='127.0.0.1'/> + </graphics> +</pre> + +<p>Note: VNC password authentication is known to be cryptographically weak. +Additionally, the password is passed as a command line argument in clear text. +Make sure you understand the risks associated with this feature before using it.</p> + <h3><a id="clockconfig">Clock configuration</a></h3> <p>Originally bhyve supported only localtime for RTC. Support for UTC time was introduced in @@ -432,6 +456,29 @@ supports Intel e1000 network adapter emulation. It's supported in libvirt ... </pre> +<h3><a id="sound">Sound device</a></h3> + +<p>As of <a href="https://svnweb.freebsd.org/changeset/base/349355">r349355</a> bhyve +supports sound device emulation. It's supported in libvirt +<span class="since">since 6.7.0</span>.</p> + +<pre> +... + <sound model='ich7'> + <audio id='1'/> + </sound> + <audio id='1' type='oss'> + <input dev='/dev/dsp0'/> + <output dev='/dev/dsp0'/> + </audio> +... +</pre> + +<p>Here, the <code>sound</code> element specifies the sound device as it's exposed +to the guest, with <code>ich7</code> being the only supported model now, +and the <code>audio</code> element specifies how the guest device is mapped +to the host sound device.</p> + <h3><a id="wired">Wiring guest memory</a></h3> <p><span class="since">Since 4.4.0</span>, it's possible to specify that guest memory should -- 2.27.0

2 3

Entering freeze for libvirt-6.8.0
by Jiri Denemark 29 Sep '20

29 Sep '20

I have just tagged v6.8.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Thanks, Jirka

6 10

[PULL v4 09/48] cphp: remove deprecated cpu-add command(s)
by Michael S. Tsirkin 29 Sep '20

29 Sep '20

From: Igor Mammedov <imammedo(a)redhat.com> These were deprecated since 4.0, remove both HMP and QMP variants. Users should use device_add command instead. To get list of possible CPUs and options, use 'info hotpluggable-cpus' HMP or query-hotpluggable-cpus QMP command. Signed-off-by: Igor Mammedov <imammedo(a)redhat.com> Reviewed-by: Thomas Huth <thuth(a)redhat.com> Acked-by: Dr. David Alan Gilbert <dgilbert(a)redhat.com> Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com> Acked-by: Cornelia Huck <cohuck(a)redhat.com> Message-Id: <20200915120403.1074579-1-imammedo(a)redhat.com> Reviewed-by: Michael S. Tsirkin <mst(a)redhat.com> Signed-off-by: Michael S. Tsirkin <mst(a)redhat.com> --- qapi/machine.json | 24 --------- include/hw/boards.h | 1 - include/hw/i386/pc.h | 1 - include/monitor/hmp.h | 1 - hw/core/machine-hmp-cmds.c | 12 ----- hw/core/machine-qmp-cmds.c | 12 ----- hw/i386/pc.c | 27 ---------- hw/i386/pc_piix.c | 1 - hw/s390x/s390-virtio-ccw.c | 12 ----- tests/qtest/cpu-plug-test.c | 100 ++++-------------------------------- tests/qtest/test-hmp.c | 1 - docs/system/deprecated.rst | 25 +++++---- hmp-commands.hx | 15 ------ 13 files changed, 21 insertions(+), 211 deletions(-) diff --git a/qapi/machine.json b/qapi/machine.json index 0ac1880e4a..d8ed096e9a 100644 --- a/qapi/machine.json +++ b/qapi/machine.json @@ -307,30 +307,6 @@ ## { 'command': 'query-cpus-fast', 'returns': [ 'CpuInfoFast' ] } -## -# @cpu-add: -# -# Adds CPU with specified ID. -# -# @id: ID of CPU to be created, valid values [0..max_cpus) -# -# Features: -# @deprecated: This command is deprecated. Use `device_add` instead. -# See the `query-hotpluggable-cpus` command for details. -# -# Returns: Nothing on success -# -# Since: 1.5 -# -# Example: -# -# -> { "execute": "cpu-add", "arguments": { "id": 2 } } -# <- { "return": {} } -# -## -{ 'command': 'cpu-add', 'data': {'id': 'int'}, - 'features': [ 'deprecated' ] } - ## # @MachineInfo: # diff --git a/include/hw/boards.h b/include/hw/boards.h index 56aa1ca335..482d2833f6 100644 --- a/include/hw/boards.h +++ b/include/hw/boards.h @@ -168,7 +168,6 @@ struct MachineClass { void (*init)(MachineState *state); void (*reset)(MachineState *state); void (*wakeup)(MachineState *state); - void (*hot_add_cpu)(MachineState *state, const int64_t id, Error **errp); int (*kvm_type)(MachineState *machine, const char *arg); void (*smp_parse)(MachineState *ms, QemuOpts *opts); diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index b2da2c8d2b..c71b02cafd 100644 --- a/include/hw/i386/pc.h +++ b/include/hw/i386/pc.h @@ -132,7 +132,6 @@ extern int fd_bootchk; void pc_acpi_smi_interrupt(void *opaque, int irq, int level); -void pc_hot_add_cpu(MachineState *ms, const int64_t id, Error **errp); void pc_smp_parse(MachineState *ms, QemuOpts *opts); void pc_guest_info_init(PCMachineState *pcms); diff --git a/include/monitor/hmp.h b/include/monitor/hmp.h index c986cfd28b..642e9e91f9 100644 --- a/include/monitor/hmp.h +++ b/include/monitor/hmp.h @@ -89,7 +89,6 @@ void hmp_chardev_add(Monitor *mon, const QDict *qdict); void hmp_chardev_change(Monitor *mon, const QDict *qdict); void hmp_chardev_remove(Monitor *mon, const QDict *qdict); void hmp_chardev_send_break(Monitor *mon, const QDict *qdict); -void hmp_cpu_add(Monitor *mon, const QDict *qdict); void hmp_object_add(Monitor *mon, const QDict *qdict); void hmp_object_del(Monitor *mon, const QDict *qdict); void hmp_info_memdev(Monitor *mon, const QDict *qdict); diff --git a/hw/core/machine-hmp-cmds.c b/hw/core/machine-hmp-cmds.c index 39999c47c5..f4092b98cc 100644 --- a/hw/core/machine-hmp-cmds.c +++ b/hw/core/machine-hmp-cmds.c @@ -46,18 +46,6 @@ void hmp_info_cpus(Monitor *mon, const QDict *qdict) qapi_free_CpuInfoFastList(cpu_list); } -void hmp_cpu_add(Monitor *mon, const QDict *qdict) -{ - int cpuid; - Error *err = NULL; - - error_report("cpu_add is deprecated, please use device_add instead"); - - cpuid = qdict_get_int(qdict, "id"); - qmp_cpu_add(cpuid, &err); - hmp_handle_error(mon, err); -} - void hmp_hotpluggable_cpus(Monitor *mon, const QDict *qdict) { Error *err = NULL; diff --git a/hw/core/machine-qmp-cmds.c b/hw/core/machine-qmp-cmds.c index 21551221ad..5362c80a18 100644 --- a/hw/core/machine-qmp-cmds.c +++ b/hw/core/machine-qmp-cmds.c @@ -284,18 +284,6 @@ HotpluggableCPUList *qmp_query_hotpluggable_cpus(Error **errp) return machine_query_hotpluggable_cpus(ms); } -void qmp_cpu_add(int64_t id, Error **errp) -{ - MachineClass *mc; - - mc = MACHINE_GET_CLASS(current_machine); - if (mc->hot_add_cpu) { - mc->hot_add_cpu(current_machine, id, errp); - } else { - error_setg(errp, "Not supported"); - } -} - void qmp_set_numa_node(NumaOptions *cmd, Error **errp) { if (!runstate_check(RUN_STATE_PRECONFIG)) { diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 1e2ab5ebe7..50e8317342 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -769,32 +769,6 @@ void pc_smp_parse(MachineState *ms, QemuOpts *opts) } } -void pc_hot_add_cpu(MachineState *ms, const int64_t id, Error **errp) -{ - X86MachineState *x86ms = X86_MACHINE(ms); - int64_t apic_id = x86_cpu_apic_id_from_index(x86ms, id); - Error *local_err = NULL; - - if (id < 0) { - error_setg(errp, "Invalid CPU id: %" PRIi64, id); - return; - } - - if (apic_id >= ACPI_CPU_HOTPLUG_ID_LIMIT) { - error_setg(errp, "Unable to add CPU: %" PRIi64 - ", resulting APIC ID (%" PRIi64 ") is too large", - id, apic_id); - return; - } - - - x86_cpu_new(X86_MACHINE(ms), apic_id, &local_err); - if (local_err) { - error_propagate(errp, local_err); - return; - } -} - static void pc_machine_done(Notifier *notifier, void *data) { @@ -1691,7 +1665,6 @@ static void pc_machine_class_init(ObjectClass *oc, void *data) mc->auto_enable_numa_with_memdev = true; mc->has_hotpluggable_cpus = true; mc->default_boot_order = "cad"; - mc->hot_add_cpu = pc_hot_add_cpu; mc->smp_parse = pc_smp_parse; mc->block_default_type = IF_IDE; mc->max_cpus = 255; diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 6f3e78bb60..2d8413a0ce 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -752,7 +752,6 @@ static void pc_i440fx_1_4_machine_options(MachineClass *m) { pc_i440fx_1_5_machine_options(m); m->hw_version = "1.4.0"; - m->hot_add_cpu = NULL; compat_props_add(m->compat_props, pc_compat_1_4, pc_compat_1_4_len); } diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index 3106bbea33..28266a3a35 100644 --- a/hw/s390x/s390-virtio-ccw.c +++ b/hw/s390x/s390-virtio-ccw.c @@ -553,17 +553,6 @@ static HotplugHandler *s390_get_hotplug_handler(MachineState *machine, return NULL; } -static void s390_hot_add_cpu(MachineState *machine, - const int64_t id, Error **errp) -{ - ObjectClass *oc; - - g_assert(machine->possible_cpus->cpus[0].cpu); - oc = OBJECT_CLASS(CPU_GET_CLASS(machine->possible_cpus->cpus[0].cpu)); - - s390x_new_cpu(object_class_get_name(oc), id, errp); -} - static void s390_nmi(NMIState *n, int cpu_index, Error **errp) { CPUState *cs = qemu_get_cpu(cpu_index); @@ -604,7 +593,6 @@ static void ccw_machine_class_init(ObjectClass *oc, void *data) s390mc->hpage_1m_allowed = true; mc->init = ccw_init; mc->reset = s390_machine_reset; - mc->hot_add_cpu = s390_hot_add_cpu; mc->block_default_type = IF_VIRTIO; mc->no_cdrom = 1; mc->no_floppy = 1; diff --git a/tests/qtest/cpu-plug-test.c b/tests/qtest/cpu-plug-test.c index e8ffbbce4b..a1c689414b 100644 --- a/tests/qtest/cpu-plug-test.c +++ b/tests/qtest/cpu-plug-test.c @@ -25,54 +25,6 @@ struct PlugTestData { }; typedef struct PlugTestData PlugTestData; -static void test_plug_with_cpu_add(gconstpointer data) -{ - const PlugTestData *s = data; - char *args; - QDict *response; - unsigned int i; - - args = g_strdup_printf("-machine %s -cpu %s " - "-smp 1,sockets=%u,cores=%u,threads=%u,maxcpus=%u", - s->machine, s->cpu_model, - s->sockets, s->cores, s->threads, s->maxcpus); - qtest_start(args); - - for (i = 1; i < s->maxcpus; i++) { - response = qmp("{ 'execute': 'cpu-add'," - " 'arguments': { 'id': %d } }", i); - g_assert(response); - g_assert(!qdict_haskey(response, "error")); - qobject_unref(response); - } - - qtest_end(); - g_free(args); -} - -static void test_plug_without_cpu_add(gconstpointer data) -{ - const PlugTestData *s = data; - char *args; - QDict *response; - - args = g_strdup_printf("-machine %s -cpu %s " - "-smp 1,sockets=%u,cores=%u,threads=%u,maxcpus=%u", - s->machine, s->cpu_model, - s->sockets, s->cores, s->threads, s->maxcpus); - qtest_start(args); - - response = qmp("{ 'execute': 'cpu-add'," - " 'arguments': { 'id': %d } }", - s->sockets * s->cores * s->threads); - g_assert(response); - g_assert(qdict_haskey(response, "error")); - qobject_unref(response); - - qtest_end(); - g_free(args); -} - static void test_plug_with_device_add(gconstpointer data) { const PlugTestData *td = data; @@ -144,36 +96,13 @@ static void add_pc_test_case(const char *mname) data->cores = 3; data->threads = 2; data->maxcpus = data->sockets * data->cores * data->threads; - if (g_str_has_suffix(mname, "-1.4") || - (strcmp(mname, "pc-1.3") == 0) || - (strcmp(mname, "pc-1.2") == 0) || - (strcmp(mname, "pc-1.1") == 0) || - (strcmp(mname, "pc-1.0") == 0)) { - path = g_strdup_printf("cpu-plug/%s/init/%ux%ux%u&maxcpus=%u", - mname, data->sockets, data->cores, - data->threads, data->maxcpus); - qtest_add_data_func_full(path, data, test_plug_without_cpu_add, - test_data_free); - g_free(path); - } else { - PlugTestData *data2 = g_memdup(data, sizeof(PlugTestData)); - data2->machine = g_strdup(data->machine); - data2->device_model = g_strdup(data->device_model); - - path = g_strdup_printf("cpu-plug/%s/cpu-add/%ux%ux%u&maxcpus=%u", - mname, data->sockets, data->cores, - data->threads, data->maxcpus); - qtest_add_data_func_full(path, data, test_plug_with_cpu_add, - test_data_free); - g_free(path); - path = g_strdup_printf("cpu-plug/%s/device-add/%ux%ux%u&maxcpus=%u", - mname, data2->sockets, data2->cores, - data2->threads, data2->maxcpus); - qtest_add_data_func_full(path, data2, test_plug_with_device_add, - test_data_free); - g_free(path); - } + path = g_strdup_printf("cpu-plug/%s/device-add/%ux%ux%u&maxcpus=%u", + mname, data->sockets, data->cores, + data->threads, data->maxcpus); + qtest_add_data_func_full(path, data, test_plug_with_device_add, + test_data_free); + g_free(path); } static void add_pseries_test_case(const char *mname) @@ -205,7 +134,7 @@ static void add_pseries_test_case(const char *mname) static void add_s390x_test_case(const char *mname) { char *path; - PlugTestData *data, *data2; + PlugTestData *data; if (!g_str_has_prefix(mname, "s390-ccw-virtio-")) { return; @@ -220,21 +149,10 @@ static void add_s390x_test_case(const char *mname) data->threads = 1; data->maxcpus = data->sockets * data->cores * data->threads; - data2 = g_memdup(data, sizeof(PlugTestData)); - data2->machine = g_strdup(data->machine); - data2->device_model = g_strdup(data->device_model); - - path = g_strdup_printf("cpu-plug/%s/cpu-add/%ux%ux%u&maxcpus=%u", + path = g_strdup_printf("cpu-plug/%s/device-add/%ux%ux%u&maxcpus=%u", mname, data->sockets, data->cores, data->threads, data->maxcpus); - qtest_add_data_func_full(path, data, test_plug_with_cpu_add, - test_data_free); - g_free(path); - - path = g_strdup_printf("cpu-plug/%s/device-add/%ux%ux%u&maxcpus=%u", - mname, data2->sockets, data2->cores, - data2->threads, data2->maxcpus); - qtest_add_data_func_full(path, data2, test_plug_with_device_add, + qtest_add_data_func_full(path, data, test_plug_with_device_add, test_data_free); g_free(path); } diff --git a/tests/qtest/test-hmp.c b/tests/qtest/test-hmp.c index aea1384bac..94a8023173 100644 --- a/tests/qtest/test-hmp.c +++ b/tests/qtest/test-hmp.c @@ -27,7 +27,6 @@ static const char *hmp_cmds[] = { "chardev-change testchardev1 ringbuf", "chardev-remove testchardev1", "commit all", - "cpu-add 1", "cpu 0", "device_add ?", "device_add usb-mouse,id=mouse1", diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index 17aa74531c..5326141cee 100644 --- a/docs/system/deprecated.rst +++ b/docs/system/deprecated.rst @@ -272,13 +272,6 @@ The ``query-cpus`` command is replaced by the ``query-cpus-fast`` command. The ``arch`` output member of the ``query-cpus-fast`` command is replaced by the ``target`` output member. -``cpu-add`` (since 4.0) -''''''''''''''''''''''' - -Use ``device_add`` for hotplugging vCPUs instead of ``cpu-add``. See -documentation of ``query-hotpluggable-cpus`` for additional -details. - ``query-events`` (since 4.0) '''''''''''''''''''''''''''' @@ -294,12 +287,6 @@ the 'wait' field, which is only applicable to sockets in server mode Human Monitor Protocol (HMP) commands ------------------------------------- -``cpu-add`` (since 4.0) -''''''''''''''''''''''' - -Use ``device_add`` for hotplugging vCPUs instead of ``cpu-add``. See -documentation of ``query-hotpluggable-cpus`` for additional details. - ``acl_show``, ``acl_reset``, ``acl_policy``, ``acl_add``, ``acl_remove`` (since 4.0.0) '''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' @@ -517,6 +504,12 @@ QEMU Machine Protocol (QMP) commands The "autoload" parameter has been ignored since 2.12.0. All bitmaps are automatically loaded from qcow2 images. +``cpu-add`` (removed in 5.2) +'''''''''''''''''''''''''''' + +Use ``device_add`` for hotplugging vCPUs instead of ``cpu-add``. See +documentation of ``query-hotpluggable-cpus`` for additional details. + Human Monitor Protocol (HMP) commands ------------------------------------- @@ -526,6 +519,12 @@ The ``hub_id`` parameter of ``hostfwd_add`` / ``hostfwd_remove`` (removed in 5.0 The ``[hub_id name]`` parameter tuple of the 'hostfwd_add' and 'hostfwd_remove' HMP commands has been replaced by ``netdev_id``. +``cpu-add`` (removed in 5.2) +'''''''''''''''''''''''''''' + +Use ``device_add`` for hotplugging vCPUs instead of ``cpu-add``. See +documentation of ``query-hotpluggable-cpus`` for additional details. + Guest Emulator ISAs ------------------- diff --git a/hmp-commands.hx b/hmp-commands.hx index 27c4bbe0f2..1088d64503 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1761,21 +1761,6 @@ SRST Executes a qemu-io command on the given block device. ERST - { - .name = "cpu-add", - .args_type = "id:i", - .params = "id", - .help = "add cpu (deprecated, use device_add instead)", - .cmd = hmp_cpu_add, - }, - -SRST -``cpu-add`` *id* - Add CPU with id *id*. This command is deprecated, please - +use ``device_add`` instead. For details, refer to - 'docs/cpu-hotplug.rst'. -ERST - { .name = "qom-list", .args_type = "path:s?", -- MST

1 0

handling Hyper-V automatic startup values
by Matt Coleman 28 Sep '20

28 Sep '20

Hello, I’m implementing some new functionality in the Hyper-V driver and could use some input on how I should handle automatic startup values. Microsoft’s Msvm_VirtualSystemSettingData class stores this setting in a property named AutomaticStartupAction: https://docs.microsoft.com/en-us/windows/win32/hyperv_v2/msvm-virtualsystem… This property has several possible values with different meanings: * 2 means “None.”, which represents that the VM will not automatically start at boot. This corresponds to libvirt’s domainGetAutostart outputting boolean false. * 3 means “Restart if previously active.” This will start the machine at boot if it was running when the host was shut down or unexpectedly powered off. It appears libvirt does not have a way to represent this. * 4 means “Always start.” This corresponds to libvirt’s domainGetAutostart outputting boolean true. * 5 through 32768 are reserved. I’m unsure how to handle the value 3, since libvirt treats this setting as a boolean... The domainGetAutostart function places the value in an int: * https://gitlab.com/libvirt/libvirt/-/blob/master/src/driver-hypervisor.h#L1… * https://gitlab.com/libvirt/libvirt/-/blob/master/src/driver-hypervisor.h#L4… However, virDomainGetAutostart’s docblock says that it will be treated as a boolean: https://gitlab.com/libvirt/libvirt/-/blob/master/src/libvirt-domain.c#L6690… Its usage in `virsh dominfo` confirms that: https://gitlab.com/libvirt/libvirt/-/blob/master/tools/virsh-domain-monitor… I haven’t investigated how other languages' bindings treat the field. Currently, my code treats anything over 2 as autostart being enabled (although, perhaps I should ignore 5+). I feel like that pretty closely represents the VM’s configuration, since it will autostart in certain cases and it definitely isn’t configured to never autostart. For 3 (“Restart if previously active.”), it could be argued that libvirt should only say that autostart is enabled when the VM is running. This would more closely represent what the VM’s runtime behavior will be, since `virsh list —autostart` would show you which VMs would boot if the hypervisor rebooted at that point in time. However, it could be considered confusing because the VM’s configuration would appear to change depending on whether or not it was running. Ultimately, it seems like libvirt’s concept of autostart functionality needs to be extended. Along those lines, it was pointed out on IRC that libvirt lacks the ability to represent hypervisors’ host shutdown activities: > danpb: we should introduce a <on_hoststop>..</on_hoststop> lifecycle action in the XML to express what actions to take on host shutdown and one of those actions can be “stop-and-restart-on-next-boot” Hyper-V has a separate setting, AutomaticShutdownAction, which governs the actions taken when the host stops: * 2 means “Turn off.” This abruptly powers off the VM. * 3 means “Save state.” This saves the running VM’s state to disk. * 4 means “Shutdown.” The performs a clean shutdown of the VM. * 5 through 32768 are reserved. It seems to me that the two settings complement each other but cover different functionality. I feel like 3 (“Restart if previously active.”) is more closely related to startup activities than the host stopping. Since it seems like more pervasive changes are needed, I’d prefer to commit something “good enough” for the Hyper-V driver and then refine it along with the rest of the drivers. Should I make domainGetAutostart only output true for Hyper-V VMs configured with AutomaticStartupAction=3 when they are running? Or, should I leave it as I currently have it (2 = autostart is disabled; 3+ = autostart is enabled)? Thanks for your time and input, and apologies for how long this got. Matt

2 2

[PATCH] tests: qemucapabilities: Update capabilities for qemu-5.2 dev cycle
by Peter Krempa 28 Sep '20

28 Sep '20

Mid-cycle caps resync. Notable change is that virtio-blk enables multiqueue by default and the addition of 'calc-dirty-rate'/'query-dirty-rate' QMP commands. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- .../caps_5.2.0.x86_64.replies | 2898 +++++++++-------- 1 file changed, 1494 insertions(+), 1404 deletions(-) diff --git a/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.replies b/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.replies index fb6f6477d9..a4b723ceb6 100644 --- a/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.replies +++ b/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.replies @@ -240,6 +240,12 @@ { "name": "transaction" }, + { + "name": "query-dirty-rate" + }, + { + "name": "calc-dirty-rate" + }, { "name": "migrate-pause" }, @@ -625,6 +631,10 @@ "name": "vhost-user-vsock-device", "parent": "vhost-vsock-common" }, + { + "name": "virtio-blk-pci-transitional", + "parent": "virtio-blk-pci-base" + }, { "name": "pcie-pci-bridge", "parent": "base-pci-bridge" @@ -633,10 +643,6 @@ "name": "pc-q35-2.11-machine", "parent": "generic-pc-machine" }, - { - "name": "virtio-crypto-device", - "parent": "virtio-device" - }, { "name": "isa-applesmc", "parent": "isa-device" @@ -654,16 +660,16 @@ "parent": "bus" }, { - "name": "Denverton-x86_64-cpu", - "parent": "x86_64-cpu" + "name": "virtio-crypto-device", + "parent": "virtio-device" }, { "name": "chardev-testdev", "parent": "chardev" }, { - "name": "usb-wacom-tablet", - "parent": "usb-device" + "name": "Denverton-x86_64-cpu", + "parent": "x86_64-cpu" }, { "name": "pci-ipmi-bt", @@ -682,8 +688,8 @@ "parent": "netfilter" }, { - "name": "Icelake-Server-v1-x86_64-cpu", - "parent": "x86_64-cpu" + "name": "usb-wacom-tablet", + "parent": "usb-device" }, { "name": "ich9-usb-uhci6", @@ -721,14 +727,14 @@ "name": "sev-guest", "parent": "object" }, - { - "name": "core2duo-x86_64-cpu", - "parent": "x86_64-cpu" - }, { "name": "ich9-usb-uhci5", "parent": "pci-uhci-usb" }, + { + "name": "core2duo-x86_64-cpu", + "parent": "x86_64-cpu" + }, { "name": "pcm3680_pci", "parent": "pci-device" @@ -773,6 +779,10 @@ "name": "usb-hub", "parent": "usb-device" }, + { + "name": "chardev-serial", + "parent": "chardev-fd" + }, { "name": "virtio-blk-device", "parent": "virtio-device" @@ -813,30 +823,26 @@ "name": "qtest-accel", "parent": "accel" }, - { - "name": "chardev-serial", - "parent": "chardev-fd" - }, { "name": "vhost-user-vsock-pci", "parent": "vhost-user-vsock-pci-base" }, { - "name": "Icelake-Client-v2-x86_64-cpu", - "parent": "x86_64-cpu" + "name": "ich9-usb-uhci1", + "parent": "pci-uhci-usb" }, { "name": "pc-i440fx-5.0-machine", "parent": "generic-pc-machine" }, - { - "name": "ich9-usb-uhci1", - "parent": "pci-uhci-usb" - }, { "name": "scsi-generic", "parent": "scsi-device" }, + { + "name": "Icelake-Client-v2-x86_64-cpu", + "parent": "x86_64-cpu" + }, { "name": "kvmclock", "parent": "sys-bus-device" @@ -897,6 +903,10 @@ "name": "virtio-serial-bus", "parent": "bus" }, + { + "name": "vhost-scsi-pci", + "parent": "vhost-scsi-pci-base" + }, { "name": "usb-host", "parent": "usb-device" @@ -922,8 +932,8 @@ "parent": "generic-pc-machine" }, { - "name": "vhost-scsi-pci", - "parent": "vhost-scsi-pci-base" + "name": "acpi-ged", + "parent": "sys-bus-device" }, { "name": "isa-ipmi-bt", @@ -941,14 +951,14 @@ "name": "pci-ipmi-kcs", "parent": "pci-device" }, - { - "name": "xio3130-downstream", - "parent": "pcie-slot" - }, { "name": "intel-iommu-iommu-memory-region", "parent": "qemu:iommu-memory-region" }, + { + "name": "xio3130-downstream", + "parent": "pcie-slot" + }, { "name": "vhost-user-vsock-pci-non-transitional", "parent": "vhost-user-vsock-pci-base" @@ -957,14 +967,14 @@ "name": "pc-i440fx-2.3-machine", "parent": "generic-pc-machine" }, - { - "name": "microvm-machine", - "parent": "x86-machine" - }, { "name": "PCI", "parent": "bus" }, + { + "name": "microvm-machine", + "parent": "x86-machine" + }, { "name": "sdhci-bus", "parent": "sd-bus" @@ -1121,10 +1131,6 @@ "name": "i82557b", "parent": "pci-device" }, - { - "name": "chardev-memory", - "parent": "chardev-ringbuf" - }, { "name": "i82557a", "parent": "pci-device" @@ -1137,6 +1143,10 @@ "name": "vmmouse", "parent": "isa-device" }, + { + "name": "chardev-udp", + "parent": "chardev" + }, { "name": "pc-q35-2.8-machine", "parent": "generic-pc-machine" @@ -1162,8 +1172,8 @@ "parent": "x86_64-cpu" }, { - "name": "chardev-udp", - "parent": "chardev" + "name": "chardev-memory", + "parent": "chardev-ringbuf" }, { "name": "EPYC-Rome-v1-x86_64-cpu", @@ -1213,14 +1223,14 @@ "name": "virtio-9p-pci-non-transitional", "parent": "virtio-9p-pci-base" }, - { - "name": "memory-backend-file", - "parent": "memory-backend" - }, { "name": "Nehalem-v2-x86_64-cpu", "parent": "x86_64-cpu" }, + { + "name": "memory-backend-file", + "parent": "memory-backend" + }, { "name": "vhost-vsock-device", "parent": "vhost-vsock-common" @@ -1281,6 +1291,10 @@ "name": "tcg-accel", "parent": "accel" }, + { + "name": "piix4-ide", + "parent": "pci-ide" + }, { "name": "virtio-balloon-pci", "parent": "virtio-balloon-pci-base" @@ -1305,6 +1319,14 @@ "name": "athlon-v1-x86_64-cpu", "parent": "x86_64-cpu" }, + { + "name": "acpi-ged-x86", + "parent": "acpi-ged" + }, + { + "name": "ES1370", + "parent": "pci-device" + }, { "name": "i82551", "parent": "pci-device" @@ -1322,8 +1344,8 @@ "parent": "x86_64-cpu" }, { - "name": "pc-i440fx-2.6-machine", - "parent": "generic-pc-machine" + "name": "nvme", + "parent": "pci-device" }, { "name": "SandyBridge-x86_64-cpu", @@ -1334,17 +1356,13 @@ "parent": "pci-device" }, { - "name": "piix4-ide", - "parent": "pci-ide" + "name": "pc-i440fx-2.6-machine", + "parent": "generic-pc-machine" }, { "name": "mioe3680_pci", "parent": "pci-device" }, - { - "name": "nvme", - "parent": "pci-device" - }, { "name": "vhost-user-backend", "parent": "object" @@ -1358,17 +1376,13 @@ "parent": "base-xhci" }, { - "name": "ES1370", - "parent": "pci-device" + "name": "kvm-apic", + "parent": "apic-common" }, { "name": "Conroe-v1-x86_64-cpu", "parent": "x86_64-cpu" }, - { - "name": "kvm-apic", - "parent": "apic-common" - }, { "name": "isa-pit", "parent": "pit-common" @@ -1405,14 +1419,14 @@ "name": "virtio-crypto-pci", "parent": "virtio-crypto-pci-base-type" }, - { - "name": "i8042", - "parent": "isa-device" - }, { "name": "iothread", "parent": "object" }, + { + "name": "i8042", + "parent": "isa-device" + }, { "name": "virtio-iommu-pci-transitional", "parent": "virtio-iommu-device-base" @@ -1449,6 +1463,10 @@ "name": "core2duo-v1-x86_64-cpu", "parent": "x86_64-cpu" }, + { + "name": "virtio-rng-pci-non-transitional", + "parent": "virtio-rng-pci-base" + }, { "name": "cirrus-vga", "parent": "pci-device" @@ -1465,17 +1483,13 @@ "name": "pc-i440fx-2.1-machine", "parent": "generic-pc-machine" }, - { - "name": "virtio-serial-pci", - "parent": "virtio-serial-pci-base" - }, { "name": "i82559er", "parent": "pci-device" }, { - "name": "virtio-rng-pci-non-transitional", - "parent": "virtio-rng-pci-base" + "name": "virtio-serial-pci", + "parent": "virtio-serial-pci-base" }, { "name": "Skylake-Client-x86_64-cpu", @@ -1485,10 +1499,6 @@ "name": "Opteron_G3-x86_64-cpu", "parent": "x86_64-cpu" }, - { - "name": "isa-ide", - "parent": "isa-device" - }, { "name": "container", "parent": "object" @@ -1513,6 +1523,10 @@ "name": "vmport", "parent": "isa-device" }, + { + "name": "isa-ide", + "parent": "isa-device" + }, { "name": "am53c974", "parent": "pci-device" @@ -1533,14 +1547,14 @@ "name": "e1000-82545em", "parent": "e1000-base" }, - { - "name": "pxb-pcie-bus", - "parent": "PCIE" - }, { "name": "sdhci-pci", "parent": "pci-device" }, + { + "name": "pxb-pcie-bus", + "parent": "PCIE" + }, { "name": "vhost-user-scsi", "parent": "vhost-scsi-common" @@ -1838,8 +1852,8 @@ "parent": "x86_64-cpu" }, { - "name": "qio-net-listener", - "parent": "object" + "name": "qio-channel-websock", + "parent": "qio-channel" }, { "name": "pc-q35-4.1-machine", @@ -1862,8 +1876,8 @@ "parent": "x86_64-cpu" }, { - "name": "qio-channel-websock", - "parent": "qio-channel" + "name": "qio-net-listener", + "parent": "object" }, { "name": "edu", @@ -1942,8 +1956,8 @@ "parent": "chardev" }, { - "name": "clock", - "parent": "object" + "name": "virtio-net-device", + "parent": "virtio-device" }, { "name": "Haswell-v2-x86_64-cpu", @@ -1978,8 +1992,8 @@ "parent": "sys-bus-device" }, { - "name": "secret", - "parent": "secret_common" + "name": "clock", + "parent": "object" }, { "name": "virtconsole", @@ -2002,8 +2016,8 @@ "parent": "scsi-disk-base" }, { - "name": "Cascadelake-Server-noTSX-x86_64-cpu", - "parent": "x86_64-cpu" + "name": "secret", + "parent": "secret_common" }, { "name": "usb-kbd", @@ -2014,20 +2028,20 @@ "parent": "isa-device" }, { - "name": "virtio-net-device", - "parent": "virtio-device" + "name": "usb-mtp", + "parent": "usb-device" }, { "name": "filter-replay", "parent": "netfilter" }, { - "name": "input-linux", - "parent": "object" + "name": "Cascadelake-Server-noTSX-x86_64-cpu", + "parent": "x86_64-cpu" }, { - "name": "usb-mtp", - "parent": "usb-device" + "name": "input-linux", + "parent": "object" }, { "name": "pc-q35-2.9-machine", @@ -2181,14 +2195,14 @@ "name": "pc-dimm", "parent": "device" }, - { - "name": "virtio-net-pci-transitional", - "parent": "virtio-net-pci-base" - }, { "name": "virtio-balloon-pci-non-transitional", "parent": "virtio-balloon-pci-base" }, + { + "name": "virtio-net-pci-transitional", + "parent": "virtio-net-pci-base" + }, { "name": "ipmi-bmc-sim", "parent": "ipmi-bmc" @@ -2249,14 +2263,14 @@ "name": "colo-compare", "parent": "object" }, - { - "name": "virtio-mmio", - "parent": "sys-bus-device" - }, { "name": "pxb-bus", "parent": "PCI" }, + { + "name": "virtio-mmio", + "parent": "sys-bus-device" + }, { "name": "pentium2-x86_64-cpu", "parent": "x86_64-cpu" @@ -2297,6 +2311,10 @@ "name": "Nehalem-v1-x86_64-cpu", "parent": "x86_64-cpu" }, + { + "name": "authz-simple", + "parent": "authz" + }, { "name": "Opteron_G2-x86_64-cpu", "parent": "x86_64-cpu" @@ -2309,14 +2327,14 @@ "name": "vhost-user-blk-pci", "parent": "vhost-user-blk-pci-base" }, - { - "name": "authz-simple", - "parent": "authz" - }, { "name": "fw_cfg_io", "parent": "fw_cfg" }, + { + "name": "pc-1.1-machine", + "parent": "generic-pc-machine" + }, { "name": "intel-iommu", "parent": "x86-iommu" @@ -2334,8 +2352,8 @@ "parent": "x86_64-cpu" }, { - "name": "pc-1.1-machine", - "parent": "generic-pc-machine" + "name": "u2f-passthru", + "parent": "u2f-key" }, { "name": "Snowridge-x86_64-cpu", @@ -2473,14 +2491,14 @@ "name": "vhost-user-gpu", "parent": "virtio-gpu-base" }, - { - "name": "pentium-v1-x86_64-cpu", - "parent": "x86_64-cpu" - }, { "name": "hda-duplex", "parent": "hda-audio" }, + { + "name": "pentium-v1-x86_64-cpu", + "parent": "x86_64-cpu" + }, { "name": "amd-iommu-iommu-memory-region", "parent": "qemu:iommu-memory-region" @@ -2489,6 +2507,10 @@ "name": "can-bus", "parent": "object" }, + { + "name": "virtio-balloon-device", + "parent": "virtio-device" + }, { "name": "cfi.pflash01", "parent": "sys-bus-device" @@ -2501,10 +2523,6 @@ "name": "Cooperlake-v1-x86_64-cpu", "parent": "x86_64-cpu" }, - { - "name": "virtio-balloon-device", - "parent": "virtio-device" - }, { "name": "isa-parallel", "parent": "isa-device" @@ -2558,20 +2576,20 @@ "parent": "rng-backend" }, { - "name": "ivshmem-doorbell", - "parent": "ivshmem-common" + "name": "Cascadelake-Server-x86_64-cpu", + "parent": "x86_64-cpu" }, { "name": "i82558b", "parent": "pci-device" }, { - "name": "qxl-vga", - "parent": "pci-qxl" + "name": "ivshmem-doorbell", + "parent": "ivshmem-common" }, { - "name": "Cascadelake-Server-x86_64-cpu", - "parent": "x86_64-cpu" + "name": "qxl-vga", + "parent": "pci-qxl" }, { "name": "virtio-iommu-device", @@ -2753,16 +2771,16 @@ "name": "kvm64-v1-x86_64-cpu", "parent": "x86_64-cpu" }, - { - "name": "scsi-block", - "parent": "scsi-disk-base" - }, { "name": "mptsas1068", "parent": "pci-device" }, { - "name": "Snowridge-v1-x86_64-cpu", + "name": "scsi-block", + "parent": "scsi-disk-base" + }, + { + "name": "Snowridge-v1-x86_64-cpu", "parent": "x86_64-cpu" }, { @@ -2849,14 +2867,14 @@ "name": "qio-channel-tls", "parent": "qio-channel" }, - { - "name": "virtio-blk-pci-transitional", - "parent": "virtio-blk-pci-base" - }, { "name": "virtio-vga", "parent": "virtio-vga-base-type" }, + { + "name": "Icelake-Server-v1-x86_64-cpu", + "parent": "x86_64-cpu" + }, { "name": "authz-pam", "parent": "authz" @@ -3045,7 +3063,7 @@ "type": "uint32" }, { - "default-value": 1, + "default-value": 65535, "name": "num-queues", "type": "uint16" }, @@ -3778,7 +3796,7 @@ "type": "bool" }, { - "default-value": 1, + "default-value": 4294967295, "name": "num_queues", "type": "uint32" }, @@ -4458,6 +4476,11 @@ "name": "disable_s3", "type": "uint8" }, + { + "default-value": true, + "name": "acpi-root-pci-hotplug", + "type": "bool" + }, { "default-value": true, "name": "memory-hotplug-support", @@ -4553,33 +4576,37 @@ "name": "x-config-reg-migration-enabled", "type": "bool" }, + { + "name": "pci-hole-end", + "type": "uint32" + }, { "default-value": 2147483648, "name": "pci-hole64-size", "type": "size" }, + { + "name": "pci-hole64-start", + "type": "uint64" + }, { "default-value": 0, "name": "short_root_bus", "type": "uint32" }, + { + "name": "pci-hole64-end", + "type": "uint64" + }, { "default-value": true, "name": "x-pci-hole64-fix", "type": "bool" }, { - "name": "pci-hole-end", + "name": "pci-hole-start", "type": "uint32" }, - { - "name": "pci-hole64-start", - "type": "uint64" - }, - { - "name": "pci-hole64-end", - "type": "uint64" - }, { "name": "pci-conf-idx[0]", "type": "child<qemu:memory-region>" @@ -4587,10 +4614,6 @@ { "name": "pci-conf-data[0]", "type": "child<qemu:memory-region>" - }, - { - "name": "pci-hole-start", - "type": "uint32" } ], "id": "libvirt-18" @@ -6484,6 +6507,10 @@ "name": "memory", "type": "link<qemu:memory-region>" }, + { + "name": "start-powered-off", + "type": "bool" + }, { "name": "legacy-memory", "type": "str" @@ -8144,6 +8171,14 @@ "deprecated": false, "default-ram-id": "pc.ram" }, + { + "hotpluggable-cpus": false, + "name": "none", + "numa-mem-supported": false, + "cpu-max": 1, + "deprecated": false, + "default-ram-id": "ram" + }, { "hotpluggable-cpus": true, "name": "pc-1.1", @@ -8153,14 +8188,6 @@ "deprecated": true, "default-ram-id": "pc.ram" }, - { - "hotpluggable-cpus": false, - "name": "none", - "numa-mem-supported": false, - "cpu-max": 1, - "deprecated": false, - "default-ram-id": "ram" - }, { "hotpluggable-cpus": true, "name": "pc-i440fx-2.7", @@ -10284,13 +10311,97 @@ }, { "parameters": [ + { + "name": "audiodev", + "type": "string" + }, + { + "name": "non-adaptive", + "type": "boolean" + }, + { + "name": "lossy", + "type": "boolean" + }, + { + "name": "sasl-authz", + "type": "string" + }, + { + "name": "tls-authz", + "type": "string" + }, + { + "name": "acl", + "type": "boolean" + }, + { + "name": "sasl", + "type": "boolean" + }, + { + "name": "key-delay-ms", + "type": "number" + }, + { + "name": "lock-key-sync", + "type": "boolean" + }, + { + "name": "reverse", + "type": "boolean" + }, + { + "name": "password", + "type": "boolean" + }, + { + "name": "ipv6", + "type": "boolean" + }, + { + "name": "ipv4", + "type": "boolean" + }, + { + "name": "to", + "type": "number" + }, + { + "name": "connections", + "type": "number" + }, + { + "name": "head", + "type": "number" + }, + { + "name": "display", + "type": "string" + }, + { + "name": "share", + "type": "string" + }, + { + "name": "tls-creds", + "type": "string" + }, + { + "name": "websocket", + "type": "string" + }, + { + "name": "vnc", + "type": "string" + } ], - "option": "acpi" + "option": "vnc" }, { "parameters": [ ], - "option": "smbios" + "option": "acpi" }, { "parameters": [ @@ -10421,6 +10532,36 @@ ], "option": "spice" }, + { + "parameters": [ + { + "name": "resourcecontrol", + "type": "string" + }, + { + "name": "spawn", + "type": "string" + }, + { + "name": "elevateprivileges", + "type": "string" + }, + { + "name": "obsolete", + "type": "string" + }, + { + "name": "enable", + "type": "boolean" + } + ], + "option": "sandbox" + }, + { + "parameters": [ + ], + "option": "smbios" + }, { "parameters": [ { @@ -10613,192 +10754,78 @@ { "parameters": [ { - "name": "audiodev", + "name": "gen_id", + "help": "Sets id of the object generating the fw_cfg blob to be inserted", "type": "string" }, { - "name": "non-adaptive", - "type": "boolean" - }, - { - "name": "lossy", - "type": "boolean" + "name": "string", + "help": "Sets content of the blob to be inserted from a string", + "type": "string" }, { - "name": "sasl-authz", + "name": "file", + "help": "Sets the name of the file from which the fw_cfg blob will be loaded", "type": "string" }, { - "name": "tls-authz", + "name": "name", + "help": "Sets the fw_cfg name of the blob to be inserted", "type": "string" - }, + } + ], + "option": "fw_cfg" + }, + { + "parameters": [ + ], + "option": "" + }, + { + "parameters": [ { - "name": "acl", - "type": "boolean" + "name": "rrsnapshot", + "type": "string" }, { - "name": "sasl", - "type": "boolean" + "name": "rrfile", + "type": "string" }, { - "name": "key-delay-ms", - "type": "number" + "name": "rr", + "type": "string" }, { - "name": "lock-key-sync", + "name": "sleep", "type": "boolean" }, { - "name": "reverse", + "name": "align", "type": "boolean" }, { - "name": "password", - "type": "boolean" - }, + "name": "shift", + "type": "string" + } + ], + "option": "icount" + }, + { + "parameters": [ + ], + "option": "numa" + }, + { + "parameters": [ { - "name": "ipv6", + "name": "debug-threads", + "help": "When enabled, name the individual threads; defaults off.\nNOTE: The thread names are for debugging and not a\nstable API.", "type": "boolean" }, { - "name": "ipv4", - "type": "boolean" - }, - { - "name": "to", - "type": "number" - }, - { - "name": "connections", - "type": "number" - }, - { - "name": "head", - "type": "number" - }, - { - "name": "display", - "type": "string" - }, - { - "name": "share", - "type": "string" - }, - { - "name": "tls-creds", - "type": "string" - }, - { - "name": "websocket", - "type": "string" - }, - { - "name": "vnc", - "type": "string" - } - ], - "option": "vnc" - }, - { - "parameters": [ - { - "name": "resourcecontrol", - "type": "string" - }, - { - "name": "spawn", - "type": "string" - }, - { - "name": "elevateprivileges", - "type": "string" - }, - { - "name": "obsolete", - "type": "string" - }, - { - "name": "enable", - "type": "boolean" - } - ], - "option": "sandbox" - }, - { - "parameters": [ - { - "name": "gen_id", - "help": "Sets id of the object generating the fw_cfg blob to be inserted", - "type": "string" - }, - { - "name": "string", - "help": "Sets content of the blob to be inserted from a string", - "type": "string" - }, - { - "name": "file", - "help": "Sets the name of the file from which the fw_cfg blob will be loaded", - "type": "string" - }, - { - "name": "name", - "help": "Sets the fw_cfg name of the blob to be inserted", - "type": "string" - } - ], - "option": "fw_cfg" - }, - { - "parameters": [ - ], - "option": "" - }, - { - "parameters": [ - { - "name": "rrsnapshot", - "type": "string" - }, - { - "name": "rrfile", - "type": "string" - }, - { - "name": "rr", - "type": "string" - }, - { - "name": "sleep", - "type": "boolean" - }, - { - "name": "align", - "type": "boolean" - }, - { - "name": "shift", - "type": "string" - } - ], - "option": "icount" - }, - { - "parameters": [ - ], - "option": "numa" - }, - { - "parameters": [ - { - "name": "debug-threads", - "help": "When enabled, name the individual threads; defaults off.\nNOTE: The thread names are for debugging and not a\nstable API.", - "type": "boolean" - }, - { - "name": "process", - "help": "Sets the name of the QEMU process, as shown in top etc", - "type": "string" + "name": "process", + "help": "Sets the name of the QEMU process, as shown in top etc", + "type": "string" }, { "name": "guest", @@ -12562,44 +12589,56 @@ "arg-type": "150" }, { - "name": "transaction", + "name": "calc-dirty-rate", "ret-type": "0", "meta-type": "command", "arg-type": "151" }, + { + "name": "query-dirty-rate", + "ret-type": "152", + "meta-type": "command", + "arg-type": "0" + }, + { + "name": "transaction", + "ret-type": "0", + "meta-type": "command", + "arg-type": "153" + }, { "name": "trace-event-get-state", - "ret-type": "[153]", + "ret-type": "[155]", "meta-type": "command", - "arg-type": "152" + "arg-type": "154" }, { "name": "trace-event-set-state", "ret-type": "0", "meta-type": "command", - "arg-type": "154" + "arg-type": "156" }, { "name": "qmp_capabilities", "ret-type": "0", "meta-type": "command", - "arg-type": "155" + "arg-type": "157" }, { "name": "query-version", - "ret-type": "156", + "ret-type": "158", "meta-type": "command", "arg-type": "0" }, { "name": "query-commands", - "ret-type": "[157]", + "ret-type": "[159]", "meta-type": "command", "arg-type": "0" }, { "name": "query-events", - "ret-type": "[158]", + "ret-type": "[160]", "meta-type": "command", "arg-type": "0", "features": [ @@ -12614,78 +12653,78 @@ }, { "name": "query-qmp-schema", - "ret-type": "[159]", + "ret-type": "[161]", "meta-type": "command", "arg-type": "0" }, { "name": "qom-list", - "ret-type": "[161]", + "ret-type": "[163]", "meta-type": "command", - "arg-type": "160" + "arg-type": "162" }, { "name": "qom-get", "ret-type": "any", "meta-type": "command", - "arg-type": "162" + "arg-type": "164" }, { "name": "qom-set", "ret-type": "0", "meta-type": "command", - "arg-type": "163" + "arg-type": "165" }, { "name": "qom-list-types", - "ret-type": "[165]", + "ret-type": "[167]", "meta-type": "command", - "arg-type": "164" + "arg-type": "166" }, { "name": "qom-list-properties", - "ret-type": "[161]", + "ret-type": "[163]", "meta-type": "command", - "arg-type": "166" + "arg-type": "168" }, { "name": "object-add", "ret-type": "0", "meta-type": "command", - "arg-type": "167" + "arg-type": "169" }, { "name": "object-del", "ret-type": "0", "meta-type": "command", - "arg-type": "168" + "arg-type": "170" }, { "name": "device-list-properties", - "ret-type": "[161]", + "ret-type": "[163]", "meta-type": "command", - "arg-type": "169" + "arg-type": "171" }, { "name": "device_add", "ret-type": "0", "meta-type": "command", - "arg-type": "170" + "arg-type": "172" }, { "name": "device_del", "ret-type": "0", "meta-type": "command", - "arg-type": "171" + "arg-type": "173" }, { "name": "DEVICE_DELETED", "meta-type": "event", - "arg-type": "172" + "arg-type": "174" }, { "name": "query-cpus", - "ret-type": "[173]", + "ret-type": "[175]", "meta-type": "command", "arg-type": "0", "features": [ @@ -12694,7 +12733,7 @@ }, { "name": "query-cpus-fast", - "ret-type": "[174]", + "ret-type": "[176]", "meta-type": "command", "arg-type": "0" }, @@ -12702,38 +12741,38 @@ "name": "cpu-add", "ret-type": "0", "meta-type": "command", - "arg-type": "175", + "arg-type": "177", "features": [ "deprecated" ] }, { "name": "query-machines", - "ret-type": "[176]", + "ret-type": "[178]", "meta-type": "command", "arg-type": "0" }, { "name": "query-current-machine", - "ret-type": "177", + "ret-type": "179", "meta-type": "command", "arg-type": "0" }, { "name": "query-target", - "ret-type": "178", + "ret-type": "180", "meta-type": "command", "arg-type": "0" }, { "name": "query-memdev", - "ret-type": "[179]", + "ret-type": "[181]", "meta-type": "command", "arg-type": "0" }, { "name": "query-hotpluggable-cpus", - "ret-type": "[180]", + "ret-type": "[182]", "meta-type": "command", "arg-type": "0" }, @@ -12741,17 +12780,17 @@ "name": "set-numa-node", "ret-type": "0", "meta-type": "command", - "arg-type": "181" + "arg-type": "183" }, { "name": "query-cpu-model-expansion", - "ret-type": "187", + "ret-type": "189", "meta-type": "command", - "arg-type": "186" + "arg-type": "188" }, { "name": "query-cpu-definitions", - "ret-type": "[188]", + "ret-type": "[190]", "meta-type": "command", "arg-type": "0" }, @@ -12759,46 +12798,46 @@ "name": "add_client", "ret-type": "0", "meta-type": "command", - "arg-type": "189" + "arg-type": "191" }, { "name": "query-name", - "ret-type": "190", + "ret-type": "192", "meta-type": "command", "arg-type": "0" }, { "name": "query-kvm", - "ret-type": "191", + "ret-type": "193", "meta-type": "command", "arg-type": "0" }, { "name": "query-uuid", - "ret-type": "192", + "ret-type": "194", "meta-type": "command", "arg-type": "0" }, { "name": "query-iothreads", - "ret-type": "[193]", + "ret-type": "[195]", "meta-type": "command", "arg-type": "0" }, { "name": "query-balloon", - "ret-type": "194", + "ret-type": "196", "meta-type": "command", "arg-type": "0" }, { "name": "BALLOON_CHANGE", "meta-type": "event", - "arg-type": "195" + "arg-type": "197" }, { "name": "query-pci", - "ret-type": "[196]", + "ret-type": "[198]", "meta-type": "command", "arg-type": "0" }, @@ -12824,13 +12863,13 @@ "name": "memsave", "ret-type": "0", "meta-type": "command", - "arg-type": "197" + "arg-type": "199" }, { "name": "pmemsave", "ret-type": "0", "meta-type": "command", - "arg-type": "198" + "arg-type": "200" }, { "name": "cont", @@ -12860,13 +12899,13 @@ "name": "balloon", "ret-type": "0", "meta-type": "command", - "arg-type": "199" + "arg-type": "201" }, { "name": "human-monitor-command", "ret-type": "str", "meta-type": "command", - "arg-type": "200", + "arg-type": "202", "features": [ "savevm-monitor-nodes" ] @@ -12875,7 +12914,7 @@ "name": "change", "ret-type": "0", "meta-type": "command", - "arg-type": "201", + "arg-type": "203", "features": [ "deprecated" ] @@ -12884,93 +12923,93 @@ "name": "xen-set-global-dirty-log", "ret-type": "0", "meta-type": "command", - "arg-type": "202" + "arg-type": "204" }, { "name": "getfd", "ret-type": "0", "meta-type": "command", - "arg-type": "203" + "arg-type": "205" }, { "name": "closefd", "ret-type": "0", "meta-type": "command", - "arg-type": "204" + "arg-type": "206" }, { "name": "query-memory-size-summary", - "ret-type": "205", + "ret-type": "207", "meta-type": "command", "arg-type": "0" }, { "name": "add-fd", - "ret-type": "207", + "ret-type": "209", "meta-type": "command", - "arg-type": "206" + "arg-type": "208" }, { "name": "remove-fd", "ret-type": "0", "meta-type": "command", - "arg-type": "208" + "arg-type": "210" }, { "name": "query-fdsets", - "ret-type": "[209]", + "ret-type": "[211]", "meta-type": "command", "arg-type": "0" }, { "name": "query-command-line-options", - "ret-type": "[211]", + "ret-type": "[213]", "meta-type": "command", - "arg-type": "210" + "arg-type": "212" }, { "name": "query-memory-devices", - "ret-type": "[212]", + "ret-type": "[214]", "meta-type": "command", "arg-type": "0" }, { "name": "MEMORY_DEVICE_SIZE_CHANGE", "meta-type": "event", - "arg-type": "213" + "arg-type": "215" }, { "name": "MEM_UNPLUG_ERROR", "meta-type": "event", - "arg-type": "214" + "arg-type": "216" }, { "name": "query-acpi-ospm-status", - "ret-type": "[215]", + "ret-type": "[217]", "meta-type": "command", "arg-type": "0" }, { "name": "ACPI_DEVICE_OST", "meta-type": "event", - "arg-type": "216" + "arg-type": "218" }, { "name": "xen-load-devices-state", "ret-type": "0", "meta-type": "command", - "arg-type": "217" + "arg-type": "219" }, { "name": "query-vm-generation-id", - "ret-type": "218", + "ret-type": "220", "meta-type": "command", "arg-type": "0" }, { "name": "RTC_CHANGE", "meta-type": "event", - "arg-type": "219" + "arg-type": "221" }, { "name": "rtc-reset-reinjection", @@ -12980,19 +13019,19 @@ }, { "name": "query-sev", - "ret-type": "220", + "ret-type": "222", "meta-type": "command", "arg-type": "0" }, { "name": "query-sev-launch-measure", - "ret-type": "221", + "ret-type": "223", "meta-type": "command", "arg-type": "0" }, { "name": "query-sev-capabilities", - "ret-type": "222", + "ret-type": "224", "meta-type": "command", "arg-type": "0" }, @@ -13015,7 +13054,7 @@ }, { "name": "status", - "type": "225" + "type": "227" } ], "meta-type": "object" @@ -13029,7 +13068,7 @@ }, { "name": "reason", - "type": "226" + "type": "228" } ], "meta-type": "object" @@ -13043,7 +13082,7 @@ }, { "name": "reason", - "type": "226" + "type": "228" } ], "meta-type": "object" @@ -13053,7 +13092,7 @@ "members": [ { "name": "action", - "type": "227" + "type": "229" } ], "meta-type": "object" @@ -13063,7 +13102,7 @@ "members": [ { "name": "action", - "type": "227" + "type": "229" } ], "meta-type": "object" @@ -13073,12 +13112,12 @@ "members": [ { "name": "action", - "type": "228" + "type": "230" }, { "name": "info", "default": null, - "type": "229" + "type": "231" } ], "meta-type": "object" @@ -13088,12 +13127,12 @@ "members": [ { "name": "action", - "type": "228" + "type": "230" }, { "name": "info", "default": null, - "type": "229" + "type": "231" } ], "meta-type": "object" @@ -13236,7 +13275,7 @@ { "name": "read-only-mode", "default": null, - "type": "230" + "type": "232" } ], "meta-type": "object" @@ -13458,12 +13497,12 @@ { "name": "io-status", "default": null, - "type": "231" + "type": "233" }, { "name": "dirty-bitmaps", "default": null, - "type": "[232]", + "type": "[234]", "features": [ "deprecated" ] @@ -13507,12 +13546,12 @@ }, { "name": "stats", - "type": "233" + "type": "235" }, { "name": "driver-specific", "default": null, - "type": "234" + "type": "236" }, { "name": "parent", @@ -13565,7 +13604,7 @@ }, { "name": "io-status", - "type": "231" + "type": "233" }, { "name": "ready", @@ -13573,7 +13612,7 @@ }, { "name": "status", - "type": "235" + "type": "237" }, { "name": "auto-finalize", @@ -13661,7 +13700,7 @@ { "name": "mode", "default": null, - "type": "236" + "type": "238" } ], "meta-type": "object" @@ -13749,7 +13788,7 @@ { "name": "on-error", "default": null, - "type": "237" + "type": "239" }, { "name": "filter-node-name", @@ -13783,7 +13822,7 @@ }, { "name": "sync", - "type": "238" + "type": "240" }, { "name": "speed", @@ -13798,7 +13837,7 @@ { "name": "bitmap-mode", "default": null, - "type": "239" + "type": "241" }, { "name": "compress", @@ -13808,12 +13847,12 @@ { "name": "on-source-error", "default": null, - "type": "237" + "type": "239" }, { "name": "on-target-error", "default": null, - "type": "237" + "type": "239" }, { "name": "auto-finalize", @@ -13842,7 +13881,7 @@ { "name": "mode", "default": null, - "type": "236" + "type": "238" } ], "meta-type": "object" @@ -13861,7 +13900,7 @@ }, { "name": "sync", - "type": "238" + "type": "240" }, { "name": "speed", @@ -13876,7 +13915,7 @@ { "name": "bitmap-mode", "default": null, - "type": "239" + "type": "241" }, { "name": "compress", @@ -13886,12 +13925,12 @@ { "name": "on-source-error", "default": null, - "type": "237" + "type": "239" }, { "name": "on-target-error", "default": null, - "type": "237" + "type": "239" }, { "name": "auto-finalize", @@ -13973,7 +14012,7 @@ }, { "name": "detect_zeroes", - "type": "240" + "type": "242" }, { "name": "bps", @@ -14001,7 +14040,7 @@ }, { "name": "image", - "type": "241" + "type": "243" }, { "name": "bps_max", @@ -14075,7 +14114,7 @@ }, { "name": "cache", - "type": "242" + "type": "244" }, { "name": "write_threshold", @@ -14084,7 +14123,7 @@ { "name": "dirty-bitmaps", "default": null, - "type": "[232]" + "type": "[234]" } ], "meta-type": "object" @@ -14094,11 +14133,11 @@ "members": [ { "name": "nodes", - "type": "[243]" + "type": "[245]" }, { "name": "edges", - "type": "[244]" + "type": "[246]" } ], "meta-type": "object" @@ -14136,12 +14175,12 @@ }, { "name": "sync", - "type": "238" + "type": "240" }, { "name": "mode", "default": null, - "type": "236" + "type": "238" }, { "name": "speed", @@ -14161,12 +14200,12 @@ { "name": "on-source-error", "default": null, - "type": "237" + "type": "239" }, { "name": "on-target-error", "default": null, - "type": "237" + "type": "239" }, { "name": "unmap", @@ -14176,7 +14215,7 @@ { "name": "copy-mode", "default": null, - "type": "245" + "type": "247" }, { "name": "auto-finalize", @@ -14247,7 +14286,7 @@ }, { "name": "bitmaps", - "type": "[246]" + "type": "[248]" } ], "meta-type": "object" @@ -14285,7 +14324,7 @@ }, { "name": "sync", - "type": "238" + "type": "240" }, { "name": "speed", @@ -14305,12 +14344,12 @@ { "name": "on-source-error", "default": null, - "type": "237" + "type": "239" }, { "name": "on-target-error", "default": null, - "type": "237" + "type": "239" }, { "name": "filter-node-name", @@ -14320,7 +14359,7 @@ { "name": "copy-mode", "default": null, - "type": "245" + "type": "247" }, { "name": "auto-finalize", @@ -14370,7 +14409,7 @@ { "name": "on-error", "default": null, - "type": "237" + "type": "239" }, { "name": "auto-finalize", @@ -14470,169 +14509,169 @@ "variants": [ { "case": "blkdebug", - "type": "250" + "type": "252" }, { "case": "blklogwrites", - "type": "251" + "type": "253" }, { "case": "blkverify", - "type": "252" + "type": "254" }, { "case": "blkreplay", - "type": "253" + "type": "255" }, { "case": "bochs", - "type": "254" + "type": "256" }, { "case": "cloop", - "type": "254" + "type": "256" }, { "case": "compress", - "type": "254" + "type": "256" }, { "case": "copy-on-read", - "type": "254" + "type": "256" }, { "case": "dmg", - "type": "254" + "type": "256" }, { "case": "file", - "type": "255" + "type": "257" }, { "case": "ftp", - "type": "256" + "type": "258" }, { "case": "ftps", - "type": "257" + "type": "259" }, { "case": "gluster", - "type": "258" + "type": "260" }, { "case": "host_cdrom", - "type": "255" + "type": "257" }, { "case": "host_device", - "type": "255" + "type": "257" }, { "case": "http", - "type": "259" + "type": "261" }, { "case": "https", - "type": "260" + "type": "262" }, { "case": "iscsi", - "type": "261" + "type": "263" }, { "case": "luks", - "type": "262" + "type": "264" }, { "case": "nbd", - "type": "263" + "type": "265" }, { "case": "nfs", - "type": "264" + "type": "266" }, { "case": "null-aio", - "type": "265" + "type": "267" }, { "case": "null-co", - "type": "265" + "type": "267" }, { "case": "nvme", - "type": "266" + "type": "268" }, { "case": "parallels", - "type": "254" + "type": "256" }, { "case": "qcow2", - "type": "267" + "type": "269" }, { "case": "qcow", - "type": "268" + "type": "270" }, { "case": "qed", - "type": "269" + "type": "271" }, { "case": "quorum", - "type": "270" + "type": "272" }, { "case": "raw", - "type": "271" + "type": "273" }, { "case": "rbd", - "type": "272" + "type": "274" }, { "case": "replication", - "type": "273" + "type": "275" }, { "case": "sheepdog", - "type": "274" + "type": "276" }, { "case": "ssh", - "type": "275" + "type": "277" }, { "case": "throttle", - "type": "276" + "type": "278" }, { "case": "vdi", - "type": "254" + "type": "256" }, { "case": "vhdx", - "type": "254" + "type": "256" }, { "case": "vmdk", - "type": "269" + "type": "271" }, { "case": "vpc", - "type": "254" + "type": "256" }, { "case": "vvfat", - "type": "277" + "type": "279" } ], "members": [ { "name": "driver", - "type": "247" + "type": "249" }, { "name": "node-name", @@ -14642,12 +14681,12 @@ { "name": "discard", "default": null, - "type": "248" + "type": "250" }, { "name": "cache", "default": null, - "type": "249" + "type": "251" }, { "name": "read-only", @@ -14667,7 +14706,7 @@ { "name": "detect-zeroes", "default": null, - "type": "240" + "type": "242" } ], "meta-type": "object" @@ -14691,7 +14730,7 @@ }, { "name": "options", - "type": "278" + "type": "280" } ], "meta-type": "object" @@ -14709,7 +14748,7 @@ }, { "name": "options", - "type": "279" + "type": "281" }, { "name": "force", @@ -14766,11 +14805,11 @@ }, { "name": "operation", - "type": "280" + "type": "282" }, { "name": "action", - "type": "281" + "type": "283" }, { "name": "nospace", @@ -14789,7 +14828,7 @@ "members": [ { "name": "type", - "type": "282" + "type": "284" }, { "name": "device", @@ -14820,7 +14859,7 @@ "members": [ { "name": "type", - "type": "282" + "type": "284" }, { "name": "device", @@ -14850,11 +14889,11 @@ }, { "name": "operation", - "type": "280" + "type": "282" }, { "name": "action", - "type": "281" + "type": "283" } ], "meta-type": "object" @@ -14864,7 +14903,7 @@ "members": [ { "name": "type", - "type": "282" + "type": "284" }, { "name": "device", @@ -14890,7 +14929,7 @@ "members": [ { "name": "type", - "type": "282" + "type": "284" }, { "name": "id", @@ -14960,7 +14999,7 @@ }, { "name": "iothread", - "type": "283" + "type": "285" }, { "name": "force", @@ -14975,7 +15014,7 @@ "members": [ { "name": "addr", - "type": "284" + "type": "286" }, { "name": "tls-creds", @@ -15030,7 +15069,7 @@ { "name": "mode", "default": null, - "type": "285" + "type": "287" } ], "meta-type": "object" @@ -15058,7 +15097,7 @@ "members": [ { "name": "type", - "type": "286" + "type": "288" }, { "name": "error", @@ -15157,7 +15196,7 @@ }, { "name": "status", - "type": "235" + "type": "237" } ], "meta-type": "object" @@ -15236,11 +15275,11 @@ }, { "name": "type", - "type": "282" + "type": "284" }, { "name": "status", - "type": "235" + "type": "237" }, { "name": "current-progress", @@ -15310,7 +15349,7 @@ { "name": "format", "default": null, - "type": "287" + "type": "289" } ], "meta-type": "object" @@ -15329,7 +15368,7 @@ { "name": "format", "default": null, - "type": "287" + "type": "289" } ], "meta-type": "object" @@ -15348,7 +15387,7 @@ }, { "name": "backend", - "type": "288" + "type": "290" } ], "meta-type": "object" @@ -15373,7 +15412,7 @@ }, { "name": "backend", - "type": "288" + "type": "290" } ], "meta-type": "object" @@ -15441,7 +15480,7 @@ { "name": "format", "default": null, - "type": "289" + "type": "291" } ], "meta-type": "object" @@ -15451,7 +15490,7 @@ "members": [ { "name": "status", - "type": "290" + "type": "292" }, { "name": "completed", @@ -15484,7 +15523,7 @@ "members": [ { "name": "formats", - "type": "[289]" + "type": "[291]" } ], "meta-type": "object" @@ -15509,47 +15548,47 @@ "variants": [ { "case": "nic", - "type": "292" + "type": "294" }, { "case": "user", - "type": "293" + "type": "295" }, { "case": "tap", - "type": "294" + "type": "296" }, { "case": "l2tpv3", - "type": "295" + "type": "297" }, { "case": "socket", - "type": "296" + "type": "298" }, { "case": "vde", - "type": "297" + "type": "299" }, { "case": "bridge", - "type": "298" + "type": "300" }, { "case": "hubport", - "type": "299" + "type": "301" }, { "case": "netmap", - "type": "300" + "type": "302" }, { "case": "vhost-user", - "type": "301" + "type": "303" }, { "case": "vhost-vdpa", - "type": "302" + "type": "304" }, { "case": "none", @@ -15563,7 +15602,7 @@ }, { "name": "type", - "type": "291" + "type": "293" } ], "meta-type": "object" @@ -15607,15 +15646,15 @@ }, { "name": "multicast", - "type": "303" + "type": "305" }, { "name": "unicast", - "type": "303" + "type": "305" }, { "name": "vlan", - "type": "303" + "type": "305" }, { "name": "broadcast-allowed", @@ -15791,11 +15830,11 @@ }, { "name": "duplex", - "type": "304" + "type": "306" }, { "name": "autoneg", - "type": "305" + "type": "307" } ], "meta-type": "object" @@ -15833,15 +15872,15 @@ }, { "name": "key", - "type": "306" + "type": "308" }, { "name": "mask", - "type": "307" + "type": "309" }, { "name": "action", - "type": "308" + "type": "310" } ], "meta-type": "object" @@ -15980,7 +16019,7 @@ }, { "name": "options", - "type": "309" + "type": "311" } ], "meta-type": "object" @@ -16076,12 +16115,12 @@ }, { "name": "mouse-mode", - "type": "310" + "type": "312" }, { "name": "channels", "default": null, - "type": "[311]" + "type": "[313]" } ], "meta-type": "object" @@ -16091,11 +16130,11 @@ "members": [ { "name": "server", - "type": "312" + "type": "314" }, { "name": "client", - "type": "312" + "type": "314" } ], "meta-type": "object" @@ -16105,11 +16144,11 @@ "members": [ { "name": "server", - "type": "313" + "type": "315" }, { "name": "client", - "type": "311" + "type": "313" } ], "meta-type": "object" @@ -16119,11 +16158,11 @@ "members": [ { "name": "server", - "type": "312" + "type": "314" }, { "name": "client", - "type": "312" + "type": "314" } ], "meta-type": "object" @@ -16143,7 +16182,7 @@ { "name": "family", "default": null, - "type": "314" + "type": "316" }, { "name": "service", @@ -16158,7 +16197,7 @@ { "name": "clients", "default": null, - "type": "[315]" + "type": "[317]" } ], "meta-type": "object" @@ -16177,20 +16216,20 @@ }, { "name": "server", - "type": "[316]" + "type": "[318]" }, { "name": "clients", - "type": "[315]" + "type": "[317]" }, { "name": "auth", - "type": "317" + "type": "319" }, { "name": "vencrypt", "default": null, - "type": "318" + "type": "320" }, { "name": "display", @@ -16215,11 +16254,11 @@ "members": [ { "name": "server", - "type": "319" + "type": "321" }, { "name": "client", - "type": "320" + "type": "322" } ], "meta-type": "object" @@ -16229,11 +16268,11 @@ "members": [ { "name": "server", - "type": "319" + "type": "321" }, { "name": "client", - "type": "315" + "type": "317" } ], "meta-type": "object" @@ -16243,11 +16282,11 @@ "members": [ { "name": "server", - "type": "319" + "type": "321" }, { "name": "client", - "type": "315" + "type": "317" } ], "meta-type": "object" @@ -16284,7 +16323,7 @@ "members": [ { "name": "keys", - "type": "[321]" + "type": "[323]" }, { "name": "hold-time", @@ -16309,7 +16348,7 @@ }, { "name": "events", - "type": "[322]" + "type": "[324]" } ], "meta-type": "object" @@ -16320,15 +16359,15 @@ "variants": [ { "case": "gtk", - "type": "325" + "type": "327" }, { "case": "curses", - "type": "326" + "type": "328" }, { "case": "egl-headless", - "type": "327" + "type": "329" }, { "case": "default", @@ -16354,7 +16393,7 @@ "members": [ { "name": "type", - "type": "323" + "type": "325" }, { "name": "full-screen", @@ -16374,7 +16413,7 @@ { "name": "gl", "default": null, - "type": "324" + "type": "326" } ], "meta-type": "object" @@ -16385,22 +16424,22 @@ { "name": "status", "default": null, - "type": "328" + "type": "330" }, { "name": "ram", "default": null, - "type": "329" + "type": "331" }, { "name": "disk", "default": null, - "type": "329" + "type": "331" }, { "name": "xbzrle-cache", "default": null, - "type": "330" + "type": "332" }, { "name": "total-time", @@ -16445,12 +16484,12 @@ { "name": "compression", "default": null, - "type": "331" + "type": "333" }, { "name": "socket-address", "default": null, - "type": "[332]" + "type": "[334]" } ], "meta-type": "object" @@ -16475,7 +16514,7 @@ "members": [ { "name": "capability", - "type": "333" + "type": "335" }, { "name": "state", @@ -16550,17 +16589,17 @@ { "name": "tls-creds", "default": null, - "type": "283" + "type": "285" }, { "name": "tls-hostname", "default": null, - "type": "283" + "type": "285" }, { "name": "tls-authz", "default": null, - "type": "283" + "type": "285" }, { "name": "max-bandwidth", @@ -16605,7 +16644,7 @@ { "name": "multifd-compression", "default": null, - "type": "334" + "type": "336" }, { "name": "multifd-zlib-level", @@ -16620,7 +16659,7 @@ { "name": "block-bitmap-mapping", "default": null, - "type": "[335]" + "type": "[337]" } ], "meta-type": "object" @@ -16746,7 +16785,7 @@ { "name": "multifd-compression", "default": null, - "type": "334" + "type": "336" }, { "name": "multifd-zlib-level", @@ -16761,7 +16800,7 @@ { "name": "block-bitmap-mapping", "default": null, - "type": "[335]" + "type": "[337]" } ], "meta-type": "object" @@ -16800,7 +16839,7 @@ "members": [ { "name": "status", - "type": "328" + "type": "330" } ], "meta-type": "object" @@ -16820,11 +16859,11 @@ "members": [ { "name": "mode", - "type": "336" + "type": "338" }, { "name": "reason", - "type": "337" + "type": "339" } ], "meta-type": "object" @@ -16834,7 +16873,7 @@ "members": [ { "name": "state", - "type": "328" + "type": "330" } ], "meta-type": "object" @@ -16968,15 +17007,15 @@ "members": [ { "name": "mode", - "type": "336" + "type": "338" }, { "name": "last-mode", - "type": "336" + "type": "338" }, { "name": "reason", - "type": "337" + "type": "339" } ], "meta-type": "object" @@ -17003,21 +17042,53 @@ }, { "name": "151", + "members": [ + { + "name": "calc-time", + "type": "int" + } + ], + "meta-type": "object" + }, + { + "name": "152", + "members": [ + { + "name": "dirty-rate", + "type": "int" + }, + { + "name": "status", + "type": "340" + }, + { + "name": "start-time", + "type": "int" + }, + { + "name": "calc-time", + "type": "int" + } + ], + "meta-type": "object" + }, + { + "name": "153", "members": [ { "name": "actions", - "type": "[338]" + "type": "[341]" }, { "name": "properties", "default": null, - "type": "339" + "type": "342" } ], "meta-type": "object" }, { - "name": "152", + "name": "154", "members": [ { "name": "name", @@ -17032,12 +17103,12 @@ "meta-type": "object" }, { - "name": "[153]", - "element-type": "153", + "name": "[155]", + "element-type": "155", "meta-type": "array" }, { - "name": "153", + "name": "155", "members": [ { "name": "name", @@ -17045,7 +17116,7 @@ }, { "name": "state", - "type": "340" + "type": "343" }, { "name": "vcpu", @@ -17055,7 +17126,7 @@ "meta-type": "object" }, { - "name": "154", + "name": "156", "members": [ { "name": "name", @@ -17079,22 +17150,22 @@ "meta-type": "object" }, { - "name": "155", + "name": "157", "members": [ { "name": "enable", "default": null, - "type": "[341]" + "type": "[344]" } ], "meta-type": "object" }, { - "name": "156", + "name": "158", "members": [ { "name": "qemu", - "type": "342" + "type": "345" }, { "name": "package", @@ -17104,12 +17175,12 @@ "meta-type": "object" }, { - "name": "[157]", - "element-type": "157", + "name": "[159]", + "element-type": "159", "meta-type": "array" }, { - "name": "157", + "name": "159", "members": [ { "name": "name", @@ -17119,12 +17190,12 @@ "meta-type": "object" }, { - "name": "[158]", - "element-type": "158", + "name": "[160]", + "element-type": "160", "meta-type": "array" }, { - "name": "158", + "name": "160", "members": [ { "name": "name", @@ -17134,41 +17205,41 @@ "meta-type": "object" }, { - "name": "[159]", - "element-type": "159", + "name": "[161]", + "element-type": "161", "meta-type": "array" }, { - "name": "159", + "name": "161", "tag": "meta-type", "variants": [ { "case": "builtin", - "type": "344" + "type": "347" }, { "case": "enum", - "type": "345" + "type": "348" }, { "case": "array", - "type": "346" + "type": "349" }, { "case": "object", - "type": "347" + "type": "350" }, { "case": "alternate", - "type": "348" + "type": "351" }, { "case": "command", - "type": "349" + "type": "352" }, { "case": "event", - "type": "350" + "type": "353" } ], "members": [ @@ -17178,7 +17249,7 @@ }, { "name": "meta-type", - "type": "343" + "type": "346" }, { "name": "features", @@ -17189,7 +17260,7 @@ "meta-type": "object" }, { - "name": "160", + "name": "162", "members": [ { "name": "path", @@ -17199,12 +17270,12 @@ "meta-type": "object" }, { - "name": "[161]", - "element-type": "161", + "name": "[163]", + "element-type": "163", "meta-type": "array" }, { - "name": "161", + "name": "163", "members": [ { "name": "name", @@ -17228,7 +17299,7 @@ "meta-type": "object" }, { - "name": "162", + "name": "164", "members": [ { "name": "path", @@ -17247,7 +17318,7 @@ "meta-type": "builtin" }, { - "name": "163", + "name": "165", "members": [ { "name": "path", @@ -17265,7 +17336,7 @@ "meta-type": "object" }, { - "name": "164", + "name": "166", "members": [ { "name": "implements", @@ -17281,12 +17352,12 @@ "meta-type": "object" }, { - "name": "[165]", - "element-type": "165", + "name": "[167]", + "element-type": "167", "meta-type": "array" }, { - "name": "165", + "name": "167", "members": [ { "name": "name", @@ -17306,7 +17377,7 @@ "meta-type": "object" }, { - "name": "166", + "name": "168", "members": [ { "name": "typename", @@ -17316,7 +17387,7 @@ "meta-type": "object" }, { - "name": "167", + "name": "169", "members": [ { "name": "qom-type", @@ -17335,7 +17406,7 @@ "meta-type": "object" }, { - "name": "168", + "name": "170", "members": [ { "name": "id", @@ -17345,7 +17416,7 @@ "meta-type": "object" }, { - "name": "169", + "name": "171", "members": [ { "name": "typename", @@ -17355,7 +17426,7 @@ "meta-type": "object" }, { - "name": "170", + "name": "172", "members": [ { "name": "driver", @@ -17375,7 +17446,7 @@ "meta-type": "object" }, { - "name": "171", + "name": "173", "members": [ { "name": "id", @@ -17385,7 +17456,7 @@ "meta-type": "object" }, { - "name": "172", + "name": "174", "members": [ { "name": "device", @@ -17400,41 +17471,41 @@ "meta-type": "object" }, { - "name": "[173]", - "element-type": "173", + "name": "[175]", + "element-type": "175", "meta-type": "array" }, { - "name": "173", + "name": "175", "tag": "arch", "variants": [ { "case": "x86", - "type": "353" + "type": "356" }, { "case": "sparc", - "type": "354" + "type": "357" }, { "case": "ppc", - "type": "355" + "type": "358" }, { "case": "mips", - "type": "356" + "type": "359" }, { "case": "tricore", - "type": "357" + "type": "360" }, { "case": "s390", - "type": "358" + "type": "361" }, { "case": "riscv", - "type": "359" + "type": "362" }, { "case": "other", @@ -17465,27 +17536,27 @@ { "name": "props", "default": null, - "type": "351" + "type": "354" }, { "name": "arch", - "type": "352" + "type": "355" } ], "meta-type": "object" }, { - "name": "[174]", - "element-type": "174", + "name": "[176]", + "element-type": "176", "meta-type": "array" }, { - "name": "174", + "name": "176", "tag": "target", "variants": [ { "case": "s390x", - "type": "358" + "type": "361" }, { "case": "aarch64", @@ -17632,24 +17703,24 @@ { "name": "props", "default": null, - "type": "351" + "type": "354" }, { "name": "arch", - "type": "352", + "type": "355", "features": [ "deprecated" ] }, { "name": "target", - "type": "360" + "type": "363" } ], "meta-type": "object" }, { - "name": "175", + "name": "177", "members": [ { "name": "id", @@ -17659,12 +17730,12 @@ "meta-type": "object" }, { - "name": "[176]", - "element-type": "176", + "name": "[178]", + "element-type": "178", "meta-type": "array" }, { - "name": "176", + "name": "178", "members": [ { "name": "name", @@ -17710,7 +17781,7 @@ "meta-type": "object" }, { - "name": "177", + "name": "179", "members": [ { "name": "wakeup-suspend-support", @@ -17720,22 +17791,22 @@ "meta-type": "object" }, { - "name": "178", + "name": "180", "members": [ { "name": "arch", - "type": "360" + "type": "363" } ], "meta-type": "object" }, { - "name": "[179]", - "element-type": "179", + "name": "[181]", + "element-type": "181", "meta-type": "array" }, { - "name": "179", + "name": "181", "members": [ { "name": "id", @@ -17764,18 +17835,18 @@ }, { "name": "policy", - "type": "361" + "type": "364" } ], "meta-type": "object" }, { - "name": "[180]", - "element-type": "180", + "name": "[182]", + "element-type": "182", "meta-type": "array" }, { - "name": "180", + "name": "182", "members": [ { "name": "type", @@ -17787,7 +17858,7 @@ }, { "name": "props", - "type": "351" + "type": "354" }, { "name": "qom-path", @@ -17798,69 +17869,69 @@ "meta-type": "object" }, { - "name": "181", + "name": "183", "tag": "type", "variants": [ { "case": "node", - "type": "363" + "type": "366" }, { "case": "dist", - "type": "364" + "type": "367" }, { "case": "cpu", - "type": "365" + "type": "368" }, { "case": "hmat-lb", - "type": "366" + "type": "369" }, { "case": "hmat-cache", - "type": "367" + "type": "370" } ], "members": [ { "name": "type", - "type": "362" + "type": "365" } ], "meta-type": "object" }, { - "name": "186", + "name": "188", "members": [ { "name": "type", - "type": "370" + "type": "373" }, { "name": "model", - "type": "368" + "type": "371" } ], "meta-type": "object" }, { - "name": "187", + "name": "189", "members": [ { "name": "model", - "type": "368" + "type": "371" } ], "meta-type": "object" }, { - "name": "[188]", - "element-type": "188", + "name": "[190]", + "element-type": "190", "meta-type": "array" }, { - "name": "188", + "name": "190", "members": [ { "name": "name", @@ -17893,7 +17964,7 @@ "meta-type": "object" }, { - "name": "189", + "name": "191", "members": [ { "name": "protocol", @@ -17917,7 +17988,7 @@ "meta-type": "object" }, { - "name": "190", + "name": "192", "members": [ { "name": "name", @@ -17928,7 +17999,7 @@ "meta-type": "object" }, { - "name": "191", + "name": "193", "members": [ { "name": "enabled", @@ -17942,7 +18013,7 @@ "meta-type": "object" }, { - "name": "192", + "name": "194", "members": [ { "name": "UUID", @@ -17952,12 +18023,12 @@ "meta-type": "object" }, { - "name": "[193]", - "element-type": "193", + "name": "[195]", + "element-type": "195", "meta-type": "array" }, { - "name": "193", + "name": "195", "members": [ { "name": "id", @@ -17983,7 +18054,7 @@ "meta-type": "object" }, { - "name": "194", + "name": "196", "members": [ { "name": "actual", @@ -17993,7 +18064,7 @@ "meta-type": "object" }, { - "name": "195", + "name": "197", "members": [ { "name": "actual", @@ -18003,12 +18074,12 @@ "meta-type": "object" }, { - "name": "[196]", - "element-type": "196", + "name": "[198]", + "element-type": "198", "meta-type": "array" }, { - "name": "196", + "name": "198", "members": [ { "name": "bus", @@ -18016,13 +18087,13 @@ }, { "name": "devices", - "type": "[371]" + "type": "[374]" } ], "meta-type": "object" }, { - "name": "197", + "name": "199", "members": [ { "name": "val", @@ -18045,7 +18116,7 @@ "meta-type": "object" }, { - "name": "198", + "name": "200", "members": [ { "name": "val", @@ -18063,7 +18134,7 @@ "meta-type": "object" }, { - "name": "199", + "name": "201", "members": [ { "name": "value", @@ -18073,7 +18144,7 @@ "meta-type": "object" }, { - "name": "200", + "name": "202", "members": [ { "name": "command-line", @@ -18088,7 +18159,7 @@ "meta-type": "object" }, { - "name": "201", + "name": "203", "members": [ { "name": "device", @@ -18107,7 +18178,7 @@ "meta-type": "object" }, { - "name": "202", + "name": "204", "members": [ { "name": "enable", @@ -18117,7 +18188,7 @@ "meta-type": "object" }, { - "name": "203", + "name": "205", "members": [ { "name": "fdname", @@ -18127,7 +18198,7 @@ "meta-type": "object" }, { - "name": "204", + "name": "206", "members": [ { "name": "fdname", @@ -18137,7 +18208,7 @@ "meta-type": "object" }, { - "name": "205", + "name": "207", "members": [ { "name": "base-memory", @@ -18152,7 +18223,7 @@ "meta-type": "object" }, { - "name": "206", + "name": "208", "members": [ { "name": "fdset-id", @@ -18168,7 +18239,7 @@ "meta-type": "object" }, { - "name": "207", + "name": "209", "members": [ { "name": "fdset-id", @@ -18182,7 +18253,7 @@ "meta-type": "object" }, { - "name": "208", + "name": "210", "members": [ { "name": "fdset-id", @@ -18197,12 +18268,12 @@ "meta-type": "object" }, { - "name": "[209]", - "element-type": "209", + "name": "[211]", + "element-type": "211", "meta-type": "array" }, { - "name": "209", + "name": "211", "members": [ { "name": "fdset-id", @@ -18210,13 +18281,13 @@ }, { "name": "fds", - "type": "[372]" + "type": "[375]" } ], "meta-type": "object" }, { - "name": "210", + "name": "212", "members": [ { "name": "option", @@ -18227,12 +18298,12 @@ "meta-type": "object" }, { - "name": "[211]", - "element-type": "211", + "name": "[213]", + "element-type": "213", "meta-type": "array" }, { - "name": "211", + "name": "213", "members": [ { "name": "option", @@ -18240,47 +18311,47 @@ }, { "name": "parameters", - "type": "[373]" + "type": "[376]" } ], "meta-type": "object" }, { - "name": "[212]", - "element-type": "212", + "name": "[214]", + "element-type": "214", "meta-type": "array" }, { - "name": "212", + "name": "214", "tag": "type", "variants": [ { "case": "dimm", - "type": "375" + "type": "378" }, { "case": "nvdimm", - "type": "375" + "type": "378" }, { "case": "virtio-pmem", - "type": "376" + "type": "379" }, { "case": "virtio-mem", - "type": "377" + "type": "380" } ], "members": [ { "name": "type", - "type": "374" + "type": "377" } ], "meta-type": "object" }, { - "name": "213", + "name": "215", "members": [ { "name": "id", @@ -18295,7 +18366,7 @@ "meta-type": "object" }, { - "name": "214", + "name": "216", "members": [ { "name": "device", @@ -18309,12 +18380,12 @@ "meta-type": "object" }, { - "name": "[215]", - "element-type": "215", + "name": "[217]", + "element-type": "217", "meta-type": "array" }, { - "name": "215", + "name": "217", "members": [ { "name": "device", @@ -18327,7 +18398,7 @@ }, { "name": "slot-type", - "type": "378" + "type": "381" }, { "name": "source", @@ -18341,17 +18412,17 @@ "meta-type": "object" }, { - "name": "216", + "name": "218", "members": [ { "name": "info", - "type": "215" + "type": "217" } ], "meta-type": "object" }, { - "name": "217", + "name": "219", "members": [ { "name": "filename", @@ -18361,7 +18432,7 @@ "meta-type": "object" }, { - "name": "218", + "name": "220", "members": [ { "name": "guid", @@ -18371,7 +18442,7 @@ "meta-type": "object" }, { - "name": "219", + "name": "221", "members": [ { "name": "offset", @@ -18381,7 +18452,7 @@ "meta-type": "object" }, { - "name": "220", + "name": "222", "members": [ { "name": "enabled", @@ -18405,7 +18476,7 @@ }, { "name": "state", - "type": "379" + "type": "382" }, { "name": "handle", @@ -18415,7 +18486,7 @@ "meta-type": "object" }, { - "name": "221", + "name": "223", "members": [ { "name": "data", @@ -18425,7 +18496,7 @@ "meta-type": "object" }, { - "name": "222", + "name": "224", "members": [ { "name": "pdh", @@ -18452,7 +18523,7 @@ "meta-type": "builtin" }, { - "name": "225", + "name": "227", "meta-type": "enum", "values": [ "debug", @@ -18475,7 +18546,7 @@ ] }, { - "name": "226", + "name": "228", "meta-type": "enum", "values": [ "none", @@ -18491,7 +18562,7 @@ ] }, { - "name": "227", + "name": "229", "meta-type": "enum", "values": [ "reset", @@ -18504,7 +18575,7 @@ ] }, { - "name": "228", + "name": "230", "meta-type": "enum", "values": [ "pause", @@ -18513,28 +18584,28 @@ ] }, { - "name": "229", + "name": "231", "tag": "type", "variants": [ { "case": "hyper-v", - "type": "381" + "type": "384" }, { "case": "s390", - "type": "382" + "type": "385" } ], "members": [ { "name": "type", - "type": "380" + "type": "383" } ], "meta-type": "object" }, { - "name": "230", + "name": "232", "meta-type": "enum", "values": [ "retain", @@ -18548,7 +18619,7 @@ "meta-type": "array" }, { - "name": "231", + "name": "233", "meta-type": "enum", "values": [ "ok", @@ -18557,12 +18628,12 @@ ] }, { - "name": "[232]", - "element-type": "232", + "name": "[234]", + "element-type": "234", "meta-type": "array" }, { - "name": "232", + "name": "234", "members": [ { "name": "name", @@ -18587,7 +18658,7 @@ }, { "name": "status", - "type": "383", + "type": "386", "features": [ "deprecated" ] @@ -18605,7 +18676,7 @@ "meta-type": "object" }, { - "name": "233", + "name": "235", "members": [ { "name": "rd_bytes", @@ -18714,37 +18785,37 @@ }, { "name": "timed_stats", - "type": "[384]" + "type": "[387]" }, { "name": "rd_latency_histogram", "default": null, - "type": "385" + "type": "388" }, { "name": "wr_latency_histogram", "default": null, - "type": "385" + "type": "388" }, { "name": "flush_latency_histogram", "default": null, - "type": "385" + "type": "388" } ], "meta-type": "object" }, { - "name": "234", + "name": "236", "tag": "driver", "variants": [ { "case": "file", - "type": "386" + "type": "389" }, { "case": "host_device", - "type": "386" + "type": "389" }, { "case": "blkdebug", @@ -18902,13 +18973,13 @@ "members": [ { "name": "driver", - "type": "247" + "type": "249" } ], "meta-type": "object" }, { - "name": "235", + "name": "237", "meta-type": "enum", "values": [ "undefined", @@ -18925,7 +18996,7 @@ ] }, { - "name": "236", + "name": "238", "meta-type": "enum", "values": [ "existing", @@ -18933,7 +19004,7 @@ ] }, { - "name": "237", + "name": "239", "meta-type": "enum", "values": [ "report", @@ -18944,7 +19015,7 @@ ] }, { - "name": "238", + "name": "240", "meta-type": "enum", "values": [ "top", @@ -18955,7 +19026,7 @@ ] }, { - "name": "239", + "name": "241", "meta-type": "enum", "values": [ "on-success", @@ -18964,7 +19035,7 @@ ] }, { - "name": "240", + "name": "242", "meta-type": "enum", "values": [ "off", @@ -18973,7 +19044,7 @@ ] }, { - "name": "241", + "name": "243", "members": [ { "name": "filename", @@ -19035,18 +19106,18 @@ { "name": "backing-image", "default": null, - "type": "241" + "type": "243" }, { "name": "format-specific", "default": null, - "type": "387" + "type": "390" } ], "meta-type": "object" }, { - "name": "242", + "name": "244", "members": [ { "name": "writeback", @@ -19064,12 +19135,12 @@ "meta-type": "object" }, { - "name": "[243]", - "element-type": "243", + "name": "[245]", + "element-type": "245", "meta-type": "array" }, { - "name": "243", + "name": "245", "members": [ { "name": "id", @@ -19077,7 +19148,7 @@ }, { "name": "type", - "type": "388" + "type": "391" }, { "name": "name", @@ -19087,12 +19158,12 @@ "meta-type": "object" }, { - "name": "[244]", - "element-type": "244", + "name": "[246]", + "element-type": "246", "meta-type": "array" }, { - "name": "244", + "name": "246", "members": [ { "name": "parent", @@ -19108,17 +19179,17 @@ }, { "name": "perm", - "type": "[389]" + "type": "[392]" }, { "name": "shared-perm", - "type": "[389]" + "type": "[392]" } ], "meta-type": "object" }, { - "name": "245", + "name": "247", "meta-type": "enum", "values": [ "background", @@ -19126,12 +19197,12 @@ ] }, { - "name": "[246]", - "element-type": "246", + "name": "[248]", + "element-type": "248", "meta-type": "array" }, { - "name": "246", + "name": "248", "members": [ { "type": "str" @@ -19143,7 +19214,7 @@ "meta-type": "alternate" }, { - "name": "247", + "name": "249", "meta-type": "enum", "values": [ "blkdebug", @@ -19189,7 +19260,7 @@ ] }, { - "name": "248", + "name": "250", "meta-type": "enum", "values": [ "ignore", @@ -19197,7 +19268,7 @@ ] }, { - "name": "249", + "name": "251", "members": [ { "name": "direct", @@ -19213,11 +19284,11 @@ "meta-type": "object" }, { - "name": "250", + "name": "252", "members": [ { "name": "image", - "type": "390" + "type": "393" }, { "name": "config", @@ -19257,36 +19328,36 @@ { "name": "inject-error", "default": null, - "type": "[391]" + "type": "[394]" }, { "name": "set-state", "default": null, - "type": "[392]" + "type": "[395]" }, { "name": "take-child-perms", "default": null, - "type": "[389]" + "type": "[392]" }, { "name": "unshare-child-perms", "default": null, - "type": "[389]" + "type": "[392]" } ], "meta-type": "object" }, { - "name": "251", + "name": "253", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "log", - "type": "390" + "type": "393" }, { "name": "log-sector-size", @@ -19307,41 +19378,41 @@ "meta-type": "object" }, { - "name": "252", + "name": "254", "members": [ { "name": "test", - "type": "390" + "type": "393" }, { "name": "raw", - "type": "390" + "type": "393" } ], "meta-type": "object" }, { - "name": "253", + "name": "255", "members": [ { "name": "image", - "type": "390" + "type": "393" } ], "meta-type": "object" }, { - "name": "254", + "name": "256", "members": [ { "name": "file", - "type": "390" + "type": "393" } ], "meta-type": "object" }, { - "name": "255", + "name": "257", "members": [ { "name": "filename", @@ -19355,12 +19426,12 @@ { "name": "locking", "default": null, - "type": "393" + "type": "396" }, { "name": "aio", "default": null, - "type": "394" + "type": "397" }, { "name": "drop-cache", @@ -19379,7 +19450,7 @@ ] }, { - "name": "256", + "name": "258", "members": [ { "name": "url", @@ -19419,7 +19490,7 @@ "meta-type": "object" }, { - "name": "257", + "name": "259", "members": [ { "name": "url", @@ -19464,7 +19535,7 @@ "meta-type": "object" }, { - "name": "258", + "name": "260", "members": [ { "name": "volume", @@ -19476,7 +19547,7 @@ }, { "name": "server", - "type": "[332]" + "type": "[334]" }, { "name": "debug", @@ -19492,7 +19563,7 @@ "meta-type": "object" }, { - "name": "259", + "name": "261", "members": [ { "name": "url", @@ -19542,7 +19613,7 @@ "meta-type": "object" }, { - "name": "260", + "name": "262", "members": [ { "name": "url", @@ -19597,11 +19668,11 @@ "meta-type": "object" }, { - "name": "261", + "name": "263", "members": [ { "name": "transport", - "type": "395" + "type": "398" }, { "name": "portal", @@ -19634,7 +19705,7 @@ { "name": "header-digest", "default": null, - "type": "396" + "type": "399" }, { "name": "timeout", @@ -19645,11 +19716,11 @@ "meta-type": "object" }, { - "name": "262", + "name": "264", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "key-secret", @@ -19660,11 +19731,11 @@ "meta-type": "object" }, { - "name": "263", + "name": "265", "members": [ { "name": "server", - "type": "332" + "type": "334" }, { "name": "export", @@ -19690,11 +19761,11 @@ "meta-type": "object" }, { - "name": "264", + "name": "266", "members": [ { "name": "server", - "type": "397" + "type": "400" }, { "name": "path", @@ -19734,7 +19805,7 @@ "meta-type": "object" }, { - "name": "265", + "name": "267", "members": [ { "name": "size", @@ -19755,7 +19826,7 @@ "meta-type": "object" }, { - "name": "266", + "name": "268", "members": [ { "name": "device", @@ -19769,16 +19840,16 @@ "meta-type": "object" }, { - "name": "267", + "name": "269", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "backing", "default": null, - "type": "398" + "type": "401" }, { "name": "lazy-refcounts", @@ -19803,7 +19874,7 @@ { "name": "overlap-check", "default": null, - "type": "399" + "type": "402" }, { "name": "cache-size", @@ -19833,53 +19904,53 @@ { "name": "encrypt", "default": null, - "type": "400" + "type": "403" }, { "name": "data-file", "default": null, - "type": "390" + "type": "393" } ], "meta-type": "object" }, { - "name": "268", + "name": "270", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "backing", "default": null, - "type": "398" + "type": "401" }, { "name": "encrypt", "default": null, - "type": "401" + "type": "404" } ], "meta-type": "object" }, { - "name": "269", + "name": "271", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "backing", "default": null, - "type": "398" + "type": "401" } ], "meta-type": "object" }, { - "name": "270", + "name": "272", "members": [ { "name": "blkverify", @@ -19888,7 +19959,7 @@ }, { "name": "children", - "type": "[390]" + "type": "[393]" }, { "name": "vote-threshold", @@ -19902,17 +19973,17 @@ { "name": "read-pattern", "default": null, - "type": "402" + "type": "405" } ], "meta-type": "object" }, { - "name": "271", + "name": "273", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "offset", @@ -19928,7 +19999,7 @@ "meta-type": "object" }, { - "name": "272", + "name": "274", "members": [ { "name": "pool", @@ -19961,7 +20032,7 @@ { "name": "auth-client-required", "default": null, - "type": "[403]" + "type": "[406]" }, { "name": "key-secret", @@ -19971,21 +20042,21 @@ { "name": "server", "default": null, - "type": "[404]" + "type": "[407]" } ], "meta-type": "object" }, { - "name": "273", + "name": "275", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "mode", - "type": "405" + "type": "408" }, { "name": "top-id", @@ -19996,11 +20067,11 @@ "meta-type": "object" }, { - "name": "274", + "name": "276", "members": [ { "name": "server", - "type": "332" + "type": "334" }, { "name": "vdi", @@ -20020,11 +20091,11 @@ "meta-type": "object" }, { - "name": "275", + "name": "277", "members": [ { "name": "server", - "type": "406" + "type": "409" }, { "name": "path", @@ -20038,13 +20109,13 @@ { "name": "host-key-check", "default": null, - "type": "407" + "type": "410" } ], "meta-type": "object" }, { - "name": "276", + "name": "278", "members": [ { "name": "throttle-group", @@ -20052,13 +20123,13 @@ }, { "name": "file", - "type": "390" + "type": "393" } ], "meta-type": "object" }, { - "name": "277", + "name": "279", "members": [ { "name": "dir", @@ -20088,68 +20159,68 @@ "meta-type": "object" }, { - "name": "278", + "name": "280", "tag": "driver", "variants": [ { "case": "file", - "type": "408" + "type": "411" }, { "case": "gluster", - "type": "409" + "type": "412" }, { "case": "luks", - "type": "410" + "type": "413" }, { "case": "nfs", - "type": "411" + "type": "414" }, { "case": "parallels", - "type": "412" + "type": "415" }, { "case": "qcow", - "type": "413" + "type": "416" }, { "case": "qcow2", - "type": "414" + "type": "417" }, { "case": "qed", - "type": "415" + "type": "418" }, { "case": "rbd", - "type": "416" + "type": "419" }, { "case": "sheepdog", - "type": "417" + "type": "420" }, { "case": "ssh", - "type": "418" + "type": "421" }, { "case": "vdi", - "type": "419" + "type": "422" }, { "case": "vhdx", - "type": "420" + "type": "423" }, { "case": "vmdk", - "type": "421" + "type": "424" }, { "case": "vpc", - "type": "422" + "type": "425" }, { "case": "blkdebug", @@ -20255,22 +20326,22 @@ "members": [ { "name": "driver", - "type": "247" + "type": "249" } ], "meta-type": "object" }, { - "name": "279", + "name": "281", "tag": "driver", "variants": [ { "case": "luks", - "type": "423" + "type": "426" }, { "case": "qcow2", - "type": "424" + "type": "427" }, { "case": "blkdebug", @@ -20428,13 +20499,13 @@ "members": [ { "name": "driver", - "type": "247" + "type": "249" } ], "meta-type": "object" }, { - "name": "280", + "name": "282", "meta-type": "enum", "values": [ "read", @@ -20442,7 +20513,7 @@ ] }, { - "name": "281", + "name": "283", "meta-type": "enum", "values": [ "ignore", @@ -20451,7 +20522,7 @@ ] }, { - "name": "282", + "name": "284", "meta-type": "enum", "values": [ "commit", @@ -20463,7 +20534,7 @@ ] }, { - "name": "283", + "name": "285", "members": [ { "type": "str" @@ -20475,36 +20546,36 @@ "meta-type": "alternate" }, { - "name": "284", + "name": "286", "tag": "type", "variants": [ { "case": "inet", - "type": "426" + "type": "429" }, { "case": "unix", - "type": "427" + "type": "430" }, { "case": "vsock", - "type": "428" + "type": "431" }, { "case": "fd", - "type": "429" + "type": "432" } ], "members": [ { "name": "type", - "type": "425" + "type": "428" } ], "meta-type": "object" }, { - "name": "285", + "name": "287", "meta-type": "enum", "values": [ "safe", @@ -20512,7 +20583,7 @@ ] }, { - "name": "286", + "name": "288", "meta-type": "enum", "values": [ "read", @@ -20521,7 +20592,7 @@ ] }, { - "name": "287", + "name": "289", "meta-type": "enum", "values": [ "utf8", @@ -20529,100 +20600,100 @@ ] }, { - "name": "288", + "name": "290", "tag": "type", "variants": [ { "case": "file", - "type": "431" + "type": "434" }, { "case": "serial", - "type": "432" + "type": "435" }, { "case": "parallel", - "type": "432" + "type": "435" }, { "case": "pipe", - "type": "432" + "type": "435" }, { "case": "socket", - "type": "433" + "type": "436" }, { "case": "udp", - "type": "434" + "type": "437" }, { "case": "pty", - "type": "435" + "type": "438" }, { "case": "null", - "type": "435" + "type": "438" }, { "case": "mux", - "type": "436" + "type": "439" }, { "case": "msmouse", - "type": "435" + "type": "438" }, { "case": "wctablet", - "type": "435" + "type": "438" }, { "case": "braille", - "type": "435" + "type": "438" }, { "case": "testdev", - "type": "435" + "type": "438" }, { "case": "stdio", - "type": "437" + "type": "440" }, { "case": "console", - "type": "435" + "type": "438" }, { "case": "spicevmc", - "type": "438" + "type": "441" }, { "case": "spiceport", - "type": "439" + "type": "442" }, { "case": "vc", - "type": "440" + "type": "443" }, { "case": "ringbuf", - "type": "441" + "type": "444" }, { "case": "memory", - "type": "441" + "type": "444" } ], "members": [ { "name": "type", - "type": "430" + "type": "433" } ], "meta-type": "object" }, { - "name": "289", + "name": "291", "meta-type": "enum", "values": [ "elf", @@ -20633,7 +20704,7 @@ ] }, { - "name": "290", + "name": "292", "meta-type": "enum", "values": [ "none", @@ -20643,12 +20714,12 @@ ] }, { - "name": "[289]", - "element-type": "289", + "name": "[291]", + "element-type": "291", "meta-type": "array" }, { - "name": "291", + "name": "293", "meta-type": "enum", "values": [ "none", @@ -20666,7 +20737,7 @@ ] }, { - "name": "292", + "name": "294", "members": [ { "name": "netdev", @@ -20697,7 +20768,7 @@ "meta-type": "object" }, { - "name": "293", + "name": "295", "members": [ { "name": "hostname", @@ -20757,7 +20828,7 @@ { "name": "dnssearch", "default": null, - "type": "[442]" + "type": "[445]" }, { "name": "domainname", @@ -20797,12 +20868,12 @@ { "name": "hostfwd", "default": null, - "type": "[442]" + "type": "[445]" }, { "name": "guestfwd", "default": null, - "type": "[442]" + "type": "[445]" }, { "name": "tftp-server-name", @@ -20813,7 +20884,7 @@ "meta-type": "object" }, { - "name": "294", + "name": "296", "members": [ { "name": "ifname", @@ -20894,7 +20965,7 @@ "meta-type": "object" }, { - "name": "295", + "name": "297", "members": [ { "name": "src", @@ -20967,7 +21038,7 @@ "meta-type": "object" }, { - "name": "296", + "name": "298", "members": [ { "name": "fd", @@ -21003,7 +21074,7 @@ "meta-type": "object" }, { - "name": "297", + "name": "299", "members": [ { "name": "sock", @@ -21029,7 +21100,7 @@ "meta-type": "object" }, { - "name": "298", + "name": "300", "members": [ { "name": "br", @@ -21045,7 +21116,7 @@ "meta-type": "object" }, { - "name": "299", + "name": "301", "members": [ { "name": "hubid", @@ -21060,7 +21131,7 @@ "meta-type": "object" }, { - "name": "300", + "name": "302", "members": [ { "name": "ifname", @@ -21075,7 +21146,7 @@ "meta-type": "object" }, { - "name": "301", + "name": "303", "members": [ { "name": "chardev", @@ -21095,7 +21166,7 @@ "meta-type": "object" }, { - "name": "302", + "name": "304", "members": [ { "name": "vhostdev", @@ -21111,7 +21182,7 @@ "meta-type": "object" }, { - "name": "303", + "name": "305", "meta-type": "enum", "values": [ "normal", @@ -21125,7 +21196,7 @@ "meta-type": "array" }, { - "name": "304", + "name": "306", "meta-type": "enum", "values": [ "half", @@ -21133,7 +21204,7 @@ ] }, { - "name": "305", + "name": "307", "meta-type": "enum", "values": [ "off", @@ -21141,7 +21212,7 @@ ] }, { - "name": "306", + "name": "308", "members": [ { "name": "priority", @@ -21200,7 +21271,7 @@ "meta-type": "object" }, { - "name": "307", + "name": "309", "members": [ { "name": "in-pport", @@ -21241,7 +21312,7 @@ "meta-type": "object" }, { - "name": "308", + "name": "310", "members": [ { "name": "goto-tbl", @@ -21277,28 +21348,28 @@ "meta-type": "object" }, { - "name": "309", + "name": "311", "tag": "type", "variants": [ { "case": "passthrough", - "type": "444" + "type": "447" }, { "case": "emulator", - "type": "445" + "type": "448" } ], "members": [ { "name": "type", - "type": "443" + "type": "446" } ], "meta-type": "object" }, { - "name": "310", + "name": "312", "meta-type": "enum", "values": [ "client", @@ -21307,12 +21378,12 @@ ] }, { - "name": "[311]", - "element-type": "311", + "name": "[313]", + "element-type": "313", "meta-type": "array" }, { - "name": "311", + "name": "313", "members": [ { "name": "host", @@ -21324,7 +21395,7 @@ }, { "name": "family", - "type": "314" + "type": "316" }, { "name": "connection-id", @@ -21346,7 +21417,7 @@ "meta-type": "object" }, { - "name": "312", + "name": "314", "members": [ { "name": "host", @@ -21358,13 +21429,13 @@ }, { "name": "family", - "type": "314" + "type": "316" } ], "meta-type": "object" }, { - "name": "313", + "name": "315", "members": [ { "name": "host", @@ -21376,7 +21447,7 @@ }, { "name": "family", - "type": "314" + "type": "316" }, { "name": "auth", @@ -21387,7 +21458,7 @@ "meta-type": "object" }, { - "name": "314", + "name": "316", "meta-type": "enum", "values": [ "ipv4", @@ -21398,12 +21469,12 @@ ] }, { - "name": "[315]", - "element-type": "315", + "name": "[317]", + "element-type": "317", "meta-type": "array" }, { - "name": "315", + "name": "317", "members": [ { "name": "host", @@ -21415,7 +21486,7 @@ }, { "name": "family", - "type": "314" + "type": "316" }, { "name": "websocket", @@ -21435,12 +21506,12 @@ "meta-type": "object" }, { - "name": "[316]", - "element-type": "316", + "name": "[318]", + "element-type": "318", "meta-type": "array" }, { - "name": "316", + "name": "318", "members": [ { "name": "host", @@ -21452,7 +21523,7 @@ }, { "name": "family", - "type": "314" + "type": "316" }, { "name": "websocket", @@ -21460,18 +21531,18 @@ }, { "name": "auth", - "type": "317" + "type": "319" }, { "name": "vencrypt", "default": null, - "type": "318" + "type": "320" } ], "meta-type": "object" }, { - "name": "317", + "name": "319", "meta-type": "enum", "values": [ "none", @@ -21486,7 +21557,7 @@ ] }, { - "name": "318", + "name": "320", "meta-type": "enum", "values": [ "plain", @@ -21501,7 +21572,7 @@ ] }, { - "name": "319", + "name": "321", "members": [ { "name": "host", @@ -21513,7 +21584,7 @@ }, { "name": "family", - "type": "314" + "type": "316" }, { "name": "websocket", @@ -21528,7 +21599,7 @@ "meta-type": "object" }, { - "name": "320", + "name": "322", "members": [ { "name": "host", @@ -21540,7 +21611,7 @@ }, { "name": "family", - "type": "314" + "type": "316" }, { "name": "websocket", @@ -21550,67 +21621,67 @@ "meta-type": "object" }, { - "name": "[321]", - "element-type": "321", + "name": "[323]", + "element-type": "323", "meta-type": "array" }, { - "name": "321", + "name": "323", "tag": "type", "variants": [ { "case": "number", - "type": "447" + "type": "450" }, { "case": "qcode", - "type": "448" + "type": "451" } ], "members": [ { "name": "type", - "type": "446" + "type": "449" } ], "meta-type": "object" }, { - "name": "[322]", - "element-type": "322", + "name": "[324]", + "element-type": "324", "meta-type": "array" }, { - "name": "322", + "name": "324", "tag": "type", "variants": [ { "case": "key", - "type": "450" + "type": "453" }, { "case": "btn", - "type": "451" + "type": "454" }, { "case": "rel", - "type": "452" + "type": "455" }, { "case": "abs", - "type": "452" + "type": "455" } ], "members": [ { "name": "type", - "type": "449" + "type": "452" } ], "meta-type": "object" }, { - "name": "323", + "name": "325", "meta-type": "enum", "values": [ "default", @@ -21624,7 +21695,7 @@ ] }, { - "name": "324", + "name": "326", "meta-type": "enum", "values": [ "off", @@ -21634,7 +21705,7 @@ ] }, { - "name": "325", + "name": "327", "members": [ { "name": "grab-on-hover", @@ -21650,7 +21721,7 @@ "meta-type": "object" }, { - "name": "326", + "name": "328", "members": [ { "name": "charset", @@ -21661,7 +21732,7 @@ "meta-type": "object" }, { - "name": "327", + "name": "329", "members": [ { "name": "rendernode", @@ -21672,7 +21743,7 @@ "meta-type": "object" }, { - "name": "328", + "name": "330", "meta-type": "enum", "values": [ "none", @@ -21692,7 +21763,7 @@ ] }, { - "name": "329", + "name": "331", "members": [ { "name": "transferred", @@ -21754,7 +21825,7 @@ "meta-type": "object" }, { - "name": "330", + "name": "332", "members": [ { "name": "cache-size", @@ -21788,7 +21859,7 @@ "meta-type": "object" }, { - "name": "331", + "name": "333", "members": [ { "name": "pages", @@ -21814,41 +21885,41 @@ "meta-type": "object" }, { - "name": "[332]", - "element-type": "332", + "name": "[334]", + "element-type": "334", "meta-type": "array" }, { - "name": "332", + "name": "334", "tag": "type", "variants": [ { "case": "inet", - "type": "406" + "type": "409" }, { "case": "unix", - "type": "454" + "type": "457" }, { "case": "vsock", - "type": "455" + "type": "458" }, { "case": "fd", - "type": "442" + "type": "445" } ], "members": [ { "name": "type", - "type": "453" + "type": "456" } ], "meta-type": "object" }, { - "name": "333", + "name": "335", "meta-type": "enum", "values": [ "xbzrle", @@ -21872,7 +21943,7 @@ ] }, { - "name": "334", + "name": "336", "meta-type": "enum", "values": [ "none", @@ -21880,12 +21951,12 @@ ] }, { - "name": "[335]", - "element-type": "335", + "name": "[337]", + "element-type": "337", "meta-type": "array" }, { - "name": "335", + "name": "337", "members": [ { "name": "node-name", @@ -21897,13 +21968,13 @@ }, { "name": "bitmaps", - "type": "[456]" + "type": "[459]" } ], "meta-type": "object" }, { - "name": "336", + "name": "338", "meta-type": "enum", "values": [ "none", @@ -21912,7 +21983,7 @@ ] }, { - "name": "337", + "name": "339", "meta-type": "enum", "values": [ "none", @@ -21927,84 +21998,93 @@ "meta-type": "builtin" }, { - "name": "[338]", - "element-type": "338", + "name": "340", + "meta-type": "enum", + "values": [ + "unstarted", + "measuring", + "measured" + ] + }, + { + "name": "[341]", + "element-type": "341", "meta-type": "array" }, { - "name": "338", + "name": "341", "tag": "type", "variants": [ { "case": "abort", - "type": "458" + "type": "461" }, { "case": "block-dirty-bitmap-add", - "type": "459" + "type": "462" }, { "case": "block-dirty-bitmap-remove", - "type": "460" + "type": "463" }, { "case": "block-dirty-bitmap-clear", - "type": "460" + "type": "463" }, { "case": "block-dirty-bitmap-enable", - "type": "460" + "type": "463" }, { "case": "block-dirty-bitmap-disable", - "type": "460" + "type": "463" }, { "case": "block-dirty-bitmap-merge", - "type": "461" + "type": "464" }, { "case": "blockdev-backup", - "type": "462" + "type": "465" }, { "case": "blockdev-snapshot", - "type": "463" + "type": "466" }, { "case": "blockdev-snapshot-internal-sync", - "type": "464" + "type": "467" }, { "case": "blockdev-snapshot-sync", - "type": "465" + "type": "468" }, { "case": "drive-backup", - "type": "466" + "type": "469" } ], "members": [ { "name": "type", - "type": "457" + "type": "460" } ], "meta-type": "object" }, { - "name": "339", + "name": "342", "members": [ { "name": "completion-mode", "default": null, - "type": "467" + "type": "470" } ], "meta-type": "object" }, { - "name": "340", + "name": "343", "meta-type": "enum", "values": [ "unavailable", @@ -22013,19 +22093,19 @@ ] }, { - "name": "[341]", - "element-type": "341", + "name": "[344]", + "element-type": "344", "meta-type": "array" }, { - "name": "341", + "name": "344", "meta-type": "enum", "values": [ "oob" ] }, { - "name": "342", + "name": "345", "members": [ { "name": "major", @@ -22043,7 +22123,7 @@ "meta-type": "object" }, { - "name": "343", + "name": "346", "meta-type": "enum", "values": [ "builtin", @@ -22056,17 +22136,17 @@ ] }, { - "name": "344", + "name": "347", "members": [ { "name": "json-type", - "type": "468" + "type": "471" } ], "meta-type": "object" }, { - "name": "345", + "name": "348", "members": [ { "name": "values", @@ -22076,7 +22156,7 @@ "meta-type": "object" }, { - "name": "346", + "name": "349", "members": [ { "name": "element-type", @@ -22086,11 +22166,11 @@ "meta-type": "object" }, { - "name": "347", + "name": "350", "members": [ { "name": "members", - "type": "[469]" + "type": "[472]" }, { "name": "tag", @@ -22100,23 +22180,23 @@ { "name": "variants", "default": null, - "type": "[470]" + "type": "[473]" } ], "meta-type": "object" }, { - "name": "348", + "name": "351", "members": [ { "name": "members", - "type": "[471]" + "type": "[474]" } ], "meta-type": "object" }, { - "name": "349", + "name": "352", "members": [ { "name": "arg-type", @@ -22135,7 +22215,7 @@ "meta-type": "object" }, { - "name": "350", + "name": "353", "members": [ { "name": "arg-type", @@ -22145,7 +22225,7 @@ "meta-type": "object" }, { - "name": "351", + "name": "354", "members": [ { "name": "node-id", @@ -22176,7 +22256,7 @@ "meta-type": "object" }, { - "name": "352", + "name": "355", "meta-type": "enum", "values": [ "x86", @@ -22190,7 +22270,7 @@ ] }, { - "name": "353", + "name": "356", "members": [ { "name": "pc", @@ -22200,7 +22280,7 @@ "meta-type": "object" }, { - "name": "354", + "name": "357", "members": [ { "name": "pc", @@ -22214,7 +22294,7 @@ "meta-type": "object" }, { - "name": "355", + "name": "358", "members": [ { "name": "nip", @@ -22224,7 +22304,7 @@ "meta-type": "object" }, { - "name": "356", + "name": "359", "members": [ { "name": "PC", @@ -22234,7 +22314,7 @@ "meta-type": "object" }, { - "name": "357", + "name": "360", "members": [ { "name": "PC", @@ -22244,17 +22324,17 @@ "meta-type": "object" }, { - "name": "358", + "name": "361", "members": [ { "name": "cpu-state", - "type": "472" + "type": "475" } ], "meta-type": "object" }, { - "name": "359", + "name": "362", "members": [ { "name": "pc", @@ -22264,7 +22344,7 @@ "meta-type": "object" }, { - "name": "360", + "name": "363", "meta-type": "enum", "values": [ "aarch64", @@ -22303,7 +22383,7 @@ ] }, { - "name": "361", + "name": "364", "meta-type": "enum", "values": [ "default", @@ -22313,7 +22393,7 @@ ] }, { - "name": "362", + "name": "365", "meta-type": "enum", "values": [ "node", @@ -22324,7 +22404,7 @@ ] }, { - "name": "363", + "name": "366", "members": [ { "name": "nodeid", @@ -22355,7 +22435,7 @@ "meta-type": "object" }, { - "name": "364", + "name": "367", "members": [ { "name": "src", @@ -22373,7 +22453,7 @@ "meta-type": "object" }, { - "name": "365", + "name": "368", "members": [ { "name": "node-id", @@ -22404,7 +22484,7 @@ "meta-type": "object" }, { - "name": "366", + "name": "369", "members": [ { "name": "initiator", @@ -22416,11 +22496,11 @@ }, { "name": "hierarchy", - "type": "473" + "type": "476" }, { "name": "data-type", - "type": "474" + "type": "477" }, { "name": "latency", @@ -22436,7 +22516,7 @@ "meta-type": "object" }, { - "name": "367", + "name": "370", "members": [ { "name": "node-id", @@ -22452,11 +22532,11 @@ }, { "name": "associativity", - "type": "475" + "type": "478" }, { "name": "policy", - "type": "476" + "type": "479" }, { "name": "line", @@ -22466,7 +22546,7 @@ "meta-type": "object" }, { - "name": "368", + "name": "371", "members": [ { "name": "name", @@ -22481,7 +22561,7 @@ "meta-type": "object" }, { - "name": "369", + "name": "372", "meta-type": "enum", "values": [ "incompatible", @@ -22491,7 +22571,7 @@ ] }, { - "name": "370", + "name": "373", "meta-type": "enum", "values": [ "static", @@ -22499,12 +22579,12 @@ ] }, { - "name": "[371]", - "element-type": "371", + "name": "[374]", + "element-type": "374", "meta-type": "array" }, { - "name": "371", + "name": "374", "members": [ { "name": "bus", @@ -22520,11 +22600,11 @@ }, { "name": "class_info", - "type": "477" + "type": "480" }, { "name": "id", - "type": "478" + "type": "481" }, { "name": "irq", @@ -22542,22 +22622,22 @@ { "name": "pci_bridge", "default": null, - "type": "479" + "type": "482" }, { "name": "regions", - "type": "[480]" + "type": "[483]" } ], "meta-type": "object" }, { - "name": "[372]", - "element-type": "372", + "name": "[375]", + "element-type": "375", "meta-type": "array" }, { - "name": "372", + "name": "375", "members": [ { "name": "fd", @@ -22572,12 +22652,12 @@ "meta-type": "object" }, { - "name": "[373]", - "element-type": "373", + "name": "[376]", + "element-type": "376", "meta-type": "array" }, { - "name": "373", + "name": "376", "members": [ { "name": "name", @@ -22585,7 +22665,7 @@ }, { "name": "type", - "type": "481" + "type": "484" }, { "name": "help", @@ -22601,7 +22681,7 @@ "meta-type": "object" }, { - "name": "374", + "name": "377", "meta-type": "enum", "values": [ "dimm", @@ -22611,37 +22691,37 @@ ] }, { - "name": "375", + "name": "378", "members": [ { "name": "data", - "type": "482" + "type": "485" } ], "meta-type": "object" }, { - "name": "376", + "name": "379", "members": [ { "name": "data", - "type": "483" + "type": "486" } ], "meta-type": "object" }, { - "name": "377", + "name": "380", "members": [ { "name": "data", - "type": "484" + "type": "487" } ], "meta-type": "object" }, { - "name": "378", + "name": "381", "meta-type": "enum", "values": [ "DIMM", @@ -22649,7 +22729,7 @@ ] }, { - "name": "379", + "name": "382", "meta-type": "enum", "values": [ "uninit", @@ -22661,7 +22741,7 @@ ] }, { - "name": "380", + "name": "383", "meta-type": "enum", "values": [ "hyper-v", @@ -22669,7 +22749,7 @@ ] }, { - "name": "381", + "name": "384", "members": [ { "name": "arg1", @@ -22695,7 +22775,7 @@ "meta-type": "object" }, { - "name": "382", + "name": "385", "members": [ { "name": "core", @@ -22711,13 +22791,13 @@ }, { "name": "reason", - "type": "485" + "type": "488" } ], "meta-type": "object" }, { - "name": "383", + "name": "386", "meta-type": "enum", "values": [ "active", @@ -22728,12 +22808,12 @@ ] }, { - "name": "[384]", - "element-type": "384", + "name": "[387]", + "element-type": "387", "meta-type": "array" }, { - "name": "384", + "name": "387", "members": [ { "name": "interval_length", @@ -22787,7 +22867,7 @@ "meta-type": "object" }, { - "name": "385", + "name": "388", "members": [ { "name": "boundaries", @@ -22801,7 +22881,7 @@ "meta-type": "object" }, { - "name": "386", + "name": "389", "members": [ { "name": "discard-nb-ok", @@ -22824,32 +22904,32 @@ "meta-type": "array" }, { - "name": "387", + "name": "390", "tag": "type", "variants": [ { "case": "qcow2", - "type": "487" + "type": "490" }, { "case": "vmdk", - "type": "488" + "type": "491" }, { "case": "luks", - "type": "489" + "type": "492" } ], "members": [ { "name": "type", - "type": "486" + "type": "489" } ], "meta-type": "object" }, { - "name": "388", + "name": "391", "meta-type": "enum", "values": [ "block-backend", @@ -22858,12 +22938,12 @@ ] }, { - "name": "[389]", - "element-type": "389", + "name": "[392]", + "element-type": "392", "meta-type": "array" }, { - "name": "389", + "name": "392", "meta-type": "enum", "values": [ "consistent-read", @@ -22874,7 +22954,7 @@ ] }, { - "name": "390", + "name": "393", "members": [ { "type": "48" @@ -22886,16 +22966,16 @@ "meta-type": "alternate" }, { - "name": "[391]", - "element-type": "391", + "name": "[394]", + "element-type": "394", "meta-type": "array" }, { - "name": "391", + "name": "394", "members": [ { "name": "event", - "type": "490" + "type": "493" }, { "name": "state", @@ -22905,7 +22985,7 @@ { "name": "iotype", "default": null, - "type": "491" + "type": "494" }, { "name": "errno", @@ -22931,16 +23011,16 @@ "meta-type": "object" }, { - "name": "[392]", - "element-type": "392", + "name": "[395]", + "element-type": "395", "meta-type": "array" }, { - "name": "392", + "name": "395", "members": [ { "name": "event", - "type": "490" + "type": "493" }, { "name": "state", @@ -22955,7 +23035,7 @@ "meta-type": "object" }, { - "name": "393", + "name": "396", "meta-type": "enum", "values": [ "auto", @@ -22964,7 +23044,7 @@ ] }, { - "name": "394", + "name": "397", "meta-type": "enum", "values": [ "threads", @@ -22973,7 +23053,7 @@ ] }, { - "name": "395", + "name": "398", "meta-type": "enum", "values": [ "tcp", @@ -22981,7 +23061,7 @@ ] }, { - "name": "396", + "name": "399", "meta-type": "enum", "values": [ "crc32c", @@ -22991,11 +23071,11 @@ ] }, { - "name": "397", + "name": "400", "members": [ { "name": "type", - "type": "492" + "type": "495" }, { "name": "host", @@ -23005,7 +23085,7 @@ "meta-type": "object" }, { - "name": "398", + "name": "401", "members": [ { "type": "48" @@ -23020,62 +23100,62 @@ "meta-type": "alternate" }, { - "name": "399", + "name": "402", "members": [ { - "type": "493" + "type": "496" }, { - "type": "494" + "type": "497" } ], "meta-type": "alternate" }, { - "name": "400", + "name": "403", "tag": "format", "variants": [ { "case": "aes", - "type": "496" + "type": "499" }, { "case": "luks", - "type": "497" + "type": "500" } ], "members": [ { "name": "format", - "type": "495" + "type": "498" } ], "meta-type": "object" }, { - "name": "401", + "name": "404", "tag": "format", "variants": [ { "case": "aes", - "type": "496" + "type": "499" } ], "members": [ { "name": "format", - "type": "498" + "type": "501" } ], "meta-type": "object" }, { - "name": "[390]", - "element-type": "390", + "name": "[393]", + "element-type": "393", "meta-type": "array" }, { - "name": "402", + "name": "405", "meta-type": "enum", "values": [ "quorum", @@ -23083,12 +23163,12 @@ ] }, { - "name": "[403]", - "element-type": "403", + "name": "[406]", + "element-type": "406", "meta-type": "array" }, { - "name": "403", + "name": "406", "meta-type": "enum", "values": [ "cephx", @@ -23096,12 +23176,12 @@ ] }, { - "name": "[404]", - "element-type": "404", + "name": "[407]", + "element-type": "407", "meta-type": "array" }, { - "name": "404", + "name": "407", "members": [ { "name": "host", @@ -23115,7 +23195,7 @@ "meta-type": "object" }, { - "name": "405", + "name": "408", "meta-type": "enum", "values": [ "primary", @@ -23123,7 +23203,7 @@ ] }, { - "name": "406", + "name": "409", "members": [ { "name": "host", @@ -23162,12 +23242,12 @@ "meta-type": "object" }, { - "name": "407", + "name": "410", "tag": "mode", "variants": [ { "case": "hash", - "type": "500" + "type": "503" }, { "case": "none", @@ -23181,13 +23261,13 @@ "members": [ { "name": "mode", - "type": "499" + "type": "502" } ], "meta-type": "object" }, { - "name": "408", + "name": "411", "members": [ { "name": "filename", @@ -23200,7 +23280,7 @@ { "name": "preallocation", "default": null, - "type": "501" + "type": "504" }, { "name": "nocow", @@ -23216,11 +23296,11 @@ "meta-type": "object" }, { - "name": "409", + "name": "412", "members": [ { "name": "location", - "type": "258" + "type": "260" }, { "name": "size", @@ -23229,13 +23309,13 @@ { "name": "preallocation", "default": null, - "type": "501" + "type": "504" } ], "meta-type": "object" }, { - "name": "410", + "name": "413", "members": [ { "name": "key-secret", @@ -23245,27 +23325,27 @@ { "name": "cipher-alg", "default": null, - "type": "502" + "type": "505" }, { "name": "cipher-mode", "default": null, - "type": "503" + "type": "506" }, { "name": "ivgen-alg", "default": null, - "type": "504" + "type": "507" }, { "name": "ivgen-hash-alg", "default": null, - "type": "505" + "type": "508" }, { "name": "hash-alg", "default": null, - "type": "505" + "type": "508" }, { "name": "iter-time", @@ -23274,7 +23354,7 @@ }, { "name": "file", - "type": "390" + "type": "393" }, { "name": "size", @@ -23283,17 +23363,17 @@ { "name": "preallocation", "default": null, - "type": "501" + "type": "504" } ], "meta-type": "object" }, { - "name": "411", + "name": "414", "members": [ { "name": "location", - "type": "264" + "type": "266" }, { "name": "size", @@ -23303,11 +23383,11 @@ "meta-type": "object" }, { - "name": "412", + "name": "415", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "size", @@ -23322,11 +23402,11 @@ "meta-type": "object" }, { - "name": "413", + "name": "416", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "size", @@ -23340,28 +23420,33 @@ { "name": "encrypt", "default": null, - "type": "506" + "type": "509" } ], "meta-type": "object" }, { - "name": "414", + "name": "417", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "data-file", "default": null, - "type": "390" + "type": "393" }, { "name": "data-file-raw", "default": null, "type": "bool" }, + { + "name": "extended-l2", + "default": null, + "type": "bool" + }, { "name": "size", "type": "int" @@ -23369,7 +23454,7 @@ { "name": "version", "default": null, - "type": "507" + "type": "510" }, { "name": "backing-file", @@ -23379,12 +23464,12 @@ { "name": "backing-fmt", "default": null, - "type": "247" + "type": "249" }, { "name": "encrypt", "default": null, - "type": "506" + "type": "509" }, { "name": "cluster-size", @@ -23394,7 +23479,7 @@ { "name": "preallocation", "default": null, - "type": "501" + "type": "504" }, { "name": "lazy-refcounts", @@ -23409,17 +23494,17 @@ { "name": "compression-type", "default": null, - "type": "508" + "type": "511" } ], "meta-type": "object" }, { - "name": "415", + "name": "418", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "size", @@ -23433,7 +23518,7 @@ { "name": "backing-fmt", "default": null, - "type": "247" + "type": "249" }, { "name": "cluster-size", @@ -23449,11 +23534,11 @@ "meta-type": "object" }, { - "name": "416", + "name": "419", "members": [ { "name": "location", - "type": "272" + "type": "274" }, { "name": "size", @@ -23468,11 +23553,11 @@ "meta-type": "object" }, { - "name": "417", + "name": "420", "members": [ { "name": "location", - "type": "274" + "type": "276" }, { "name": "size", @@ -23486,12 +23571,12 @@ { "name": "preallocation", "default": null, - "type": "501" + "type": "504" }, { "name": "redundancy", "default": null, - "type": "509" + "type": "512" }, { "name": "object-size", @@ -23502,11 +23587,11 @@ "meta-type": "object" }, { - "name": "418", + "name": "421", "members": [ { "name": "location", - "type": "275" + "type": "277" }, { "name": "size", @@ -23516,11 +23601,11 @@ "meta-type": "object" }, { - "name": "419", + "name": "422", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "size", @@ -23529,17 +23614,17 @@ { "name": "preallocation", "default": null, - "type": "501" + "type": "504" } ], "meta-type": "object" }, { - "name": "420", + "name": "423", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "size", @@ -23558,7 +23643,7 @@ { "name": "subformat", "default": null, - "type": "510" + "type": "513" }, { "name": "block-state-zero", @@ -23569,11 +23654,11 @@ "meta-type": "object" }, { - "name": "421", + "name": "424", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "size", @@ -23582,12 +23667,12 @@ { "name": "extents", "default": null, - "type": "[390]" + "type": "[393]" }, { "name": "subformat", "default": null, - "type": "511" + "type": "514" }, { "name": "backing-file", @@ -23597,7 +23682,7 @@ { "name": "adapter-type", "default": null, - "type": "512" + "type": "515" }, { "name": "hwversion", @@ -23613,11 +23698,11 @@ "meta-type": "object" }, { - "name": "422", + "name": "425", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "size", @@ -23626,7 +23711,7 @@ { "name": "subformat", "default": null, - "type": "513" + "type": "516" }, { "name": "force-size", @@ -23637,11 +23722,11 @@ "meta-type": "object" }, { - "name": "423", + "name": "426", "members": [ { "name": "state", - "type": "514" + "type": "517" }, { "name": "new-secret", @@ -23672,12 +23757,12 @@ "meta-type": "object" }, { - "name": "424", + "name": "427", "members": [ { "name": "encrypt", "default": null, - "type": "515" + "type": "518" } ], "meta-type": "object" @@ -23688,7 +23773,7 @@ "meta-type": "builtin" }, { - "name": "425", + "name": "428", "meta-type": "enum", "values": [ "inet", @@ -23698,47 +23783,47 @@ ] }, { - "name": "426", + "name": "429", "members": [ { "name": "data", - "type": "406" + "type": "409" } ], "meta-type": "object" }, { - "name": "427", + "name": "430", "members": [ { "name": "data", - "type": "454" + "type": "457" } ], "meta-type": "object" }, { - "name": "428", + "name": "431", "members": [ { "name": "data", - "type": "455" + "type": "458" } ], "meta-type": "object" }, { - "name": "429", + "name": "432", "members": [ { "name": "data", - "type": "442" + "type": "445" } ], "meta-type": "object" }, { - "name": "430", + "name": "433", "meta-type": "enum", "values": [ "file", @@ -23764,122 +23849,122 @@ ] }, { - "name": "431", + "name": "434", "members": [ { "name": "data", - "type": "516" + "type": "519" } ], "meta-type": "object" }, { - "name": "432", + "name": "435", "members": [ { "name": "data", - "type": "517" + "type": "520" } ], "meta-type": "object" }, { - "name": "433", + "name": "436", "members": [ { "name": "data", - "type": "518" + "type": "521" } ], "meta-type": "object" }, { - "name": "434", + "name": "437", "members": [ { "name": "data", - "type": "519" + "type": "522" } ], "meta-type": "object" }, { - "name": "435", + "name": "438", "members": [ { "name": "data", - "type": "520" + "type": "523" } ], "meta-type": "object" }, { - "name": "436", + "name": "439", "members": [ { "name": "data", - "type": "521" + "type": "524" } ], "meta-type": "object" }, { - "name": "437", + "name": "440", "members": [ { "name": "data", - "type": "522" + "type": "525" } ], "meta-type": "object" }, { - "name": "438", + "name": "441", "members": [ { "name": "data", - "type": "523" + "type": "526" } ], "meta-type": "object" }, { - "name": "439", + "name": "442", "members": [ { "name": "data", - "type": "524" + "type": "527" } ], "meta-type": "object" }, { - "name": "440", + "name": "443", "members": [ { "name": "data", - "type": "525" + "type": "528" } ], "meta-type": "object" }, { - "name": "441", + "name": "444", "members": [ { "name": "data", - "type": "526" + "type": "529" } ], "meta-type": "object" }, { - "name": "[442]", - "element-type": "442", + "name": "[445]", + "element-type": "445", "meta-type": "array" }, { - "name": "442", + "name": "445", "members": [ { "name": "str", @@ -23889,7 +23974,7 @@ "meta-type": "object" }, { - "name": "443", + "name": "446", "meta-type": "enum", "values": [ "passthrough", @@ -23897,27 +23982,27 @@ ] }, { - "name": "444", + "name": "447", "members": [ { "name": "data", - "type": "527" + "type": "530" } ], "meta-type": "object" }, { - "name": "445", + "name": "448", "members": [ { "name": "data", - "type": "528" + "type": "531" } ], "meta-type": "object" }, { - "name": "446", + "name": "449", "meta-type": "enum", "values": [ "number", @@ -23925,7 +24010,7 @@ ] }, { - "name": "447", + "name": "450", "members": [ { "name": "data", @@ -23935,17 +24020,17 @@ "meta-type": "object" }, { - "name": "448", + "name": "451", "members": [ { "name": "data", - "type": "529" + "type": "532" } ], "meta-type": "object" }, { - "name": "449", + "name": "452", "meta-type": "enum", "values": [ "key", @@ -23955,37 +24040,37 @@ ] }, { - "name": "450", + "name": "453", "members": [ { "name": "data", - "type": "530" + "type": "533" } ], "meta-type": "object" }, { - "name": "451", + "name": "454", "members": [ { "name": "data", - "type": "531" + "type": "534" } ], "meta-type": "object" }, { - "name": "452", + "name": "455", "members": [ { "name": "data", - "type": "532" + "type": "535" } ], "meta-type": "object" }, { - "name": "453", + "name": "456", "meta-type": "enum", "values": [ "inet", @@ -23995,7 +24080,7 @@ ] }, { - "name": "454", + "name": "457", "members": [ { "name": "path", @@ -24015,7 +24100,7 @@ "meta-type": "object" }, { - "name": "455", + "name": "458", "members": [ { "name": "cid", @@ -24029,12 +24114,12 @@ "meta-type": "object" }, { - "name": "[456]", - "element-type": "456", + "name": "[459]", + "element-type": "459", "meta-type": "array" }, { - "name": "456", + "name": "459", "members": [ { "name": "name", @@ -24048,7 +24133,7 @@ "meta-type": "object" }, { - "name": "457", + "name": "460", "meta-type": "enum", "values": [ "abort", @@ -24066,17 +24151,17 @@ ] }, { - "name": "458", + "name": "461", "members": [ { "name": "data", - "type": "533" + "type": "536" } ], "meta-type": "object" }, { - "name": "459", + "name": "462", "members": [ { "name": "data", @@ -24086,7 +24171,7 @@ "meta-type": "object" }, { - "name": "460", + "name": "463", "members": [ { "name": "data", @@ -24096,7 +24181,7 @@ "meta-type": "object" }, { - "name": "461", + "name": "464", "members": [ { "name": "data", @@ -24106,7 +24191,7 @@ "meta-type": "object" }, { - "name": "462", + "name": "465", "members": [ { "name": "data", @@ -24116,7 +24201,7 @@ "meta-type": "object" }, { - "name": "463", + "name": "466", "members": [ { "name": "data", @@ -24126,7 +24211,7 @@ "meta-type": "object" }, { - "name": "464", + "name": "467", "members": [ { "name": "data", @@ -24136,7 +24221,7 @@ "meta-type": "object" }, { - "name": "465", + "name": "468", "members": [ { "name": "data", @@ -24146,7 +24231,7 @@ "meta-type": "object" }, { - "name": "466", + "name": "469", "members": [ { "name": "data", @@ -24156,7 +24241,7 @@ "meta-type": "object" }, { - "name": "467", + "name": "470", "meta-type": "enum", "values": [ "individual", @@ -24164,7 +24249,7 @@ ] }, { - "name": "468", + "name": "471", "meta-type": "enum", "values": [ "string", @@ -24178,12 +24263,12 @@ ] }, { - "name": "[469]", - "element-type": "469", + "name": "[472]", + "element-type": "472", "meta-type": "array" }, { - "name": "469", + "name": "472", "members": [ { "name": "name", @@ -24207,12 +24292,12 @@ "meta-type": "object" }, { - "name": "[470]", - "element-type": "470", + "name": "[473]", + "element-type": "473", "meta-type": "array" }, { - "name": "470", + "name": "473", "members": [ { "name": "case", @@ -24226,12 +24311,12 @@ "meta-type": "object" }, { - "name": "[471]", - "element-type": "471", + "name": "[474]", + "element-type": "474", "meta-type": "array" }, { - "name": "471", + "name": "474", "members": [ { "name": "type", @@ -24241,7 +24326,7 @@ "meta-type": "object" }, { - "name": "472", + "name": "475", "meta-type": "enum", "values": [ "uninitialized", @@ -24252,7 +24337,7 @@ ] }, { - "name": "473", + "name": "476", "meta-type": "enum", "values": [ "memory", @@ -24262,7 +24347,7 @@ ] }, { - "name": "474", + "name": "477", "meta-type": "enum", "values": [ "access-latency", @@ -24274,7 +24359,7 @@ ] }, { - "name": "475", + "name": "478", "meta-type": "enum", "values": [ "none", @@ -24283,7 +24368,7 @@ ] }, { - "name": "476", + "name": "479", "meta-type": "enum", "values": [ "none", @@ -24292,7 +24377,7 @@ ] }, { - "name": "477", + "name": "480", "members": [ { "name": "desc", @@ -24307,7 +24392,7 @@ "meta-type": "object" }, { - "name": "478", + "name": "481", "members": [ { "name": "device", @@ -24331,27 +24416,27 @@ "meta-type": "object" }, { - "name": "479", + "name": "482", "members": [ { "name": "bus", - "type": "534" + "type": "537" }, { "name": "devices", "default": null, - "type": "[371]" + "type": "[374]" } ], "meta-type": "object" }, { - "name": "[480]", - "element-type": "480", + "name": "[483]", + "element-type": "483", "meta-type": "array" }, { - "name": "480", + "name": "483", "members": [ { "name": "bar", @@ -24383,7 +24468,7 @@ "meta-type": "object" }, { - "name": "481", + "name": "484", "meta-type": "enum", "values": [ "string", @@ -24393,7 +24478,7 @@ ] }, { - "name": "482", + "name": "485", "members": [ { "name": "id", @@ -24432,7 +24517,7 @@ "meta-type": "object" }, { - "name": "483", + "name": "486", "members": [ { "name": "id", @@ -24455,7 +24540,7 @@ "meta-type": "object" }, { - "name": "484", + "name": "487", "members": [ { "name": "id", @@ -24494,7 +24579,7 @@ "meta-type": "object" }, { - "name": "485", + "name": "488", "meta-type": "enum", "values": [ "unknown", @@ -24505,7 +24590,7 @@ ] }, { - "name": "486", + "name": "489", "meta-type": "enum", "values": [ "qcow2", @@ -24514,37 +24599,37 @@ ] }, { - "name": "487", + "name": "490", "members": [ { "name": "data", - "type": "535" + "type": "538" } ], "meta-type": "object" }, { - "name": "488", + "name": "491", "members": [ { "name": "data", - "type": "536" + "type": "539" } ], "meta-type": "object" }, { - "name": "489", + "name": "492", "members": [ { "name": "data", - "type": "537" + "type": "540" } ], "meta-type": "object" }, { - "name": "490", + "name": "493", "meta-type": "enum", "values": [ "l1_update", @@ -24598,7 +24683,7 @@ ] }, { - "name": "491", + "name": "494", "meta-type": "enum", "values": [ "read", @@ -24610,19 +24695,19 @@ ] }, { - "name": "492", + "name": "495", "meta-type": "enum", "values": [ "inet" ] }, { - "name": "493", + "name": "496", "members": [ { "name": "template", "default": null, - "type": "494" + "type": "497" }, { "name": "main-header", @@ -24673,7 +24758,7 @@ "meta-type": "object" }, { - "name": "494", + "name": "497", "meta-type": "enum", "values": [ "none", @@ -24683,7 +24768,7 @@ ] }, { - "name": "495", + "name": "498", "meta-type": "enum", "values": [ "aes", @@ -24691,7 +24776,7 @@ ] }, { - "name": "496", + "name": "499", "members": [ { "name": "key-secret", @@ -24702,7 +24787,7 @@ "meta-type": "object" }, { - "name": "497", + "name": "500", "members": [ { "name": "key-secret", @@ -24713,14 +24798,14 @@ "meta-type": "object" }, { - "name": "498", + "name": "501", "meta-type": "enum", "values": [ "aes" ] }, { - "name": "499", + "name": "502", "meta-type": "enum", "values": [ "none", @@ -24729,11 +24814,11 @@ ] }, { - "name": "500", + "name": "503", "members": [ { "name": "type", - "type": "538" + "type": "541" }, { "name": "hash", @@ -24743,7 +24828,7 @@ "meta-type": "object" }, { - "name": "501", + "name": "504", "meta-type": "enum", "values": [ "off", @@ -24753,7 +24838,7 @@ ] }, { - "name": "502", + "name": "505", "meta-type": "enum", "values": [ "aes-128", @@ -24771,7 +24856,7 @@ ] }, { - "name": "503", + "name": "506", "meta-type": "enum", "values": [ "ecb", @@ -24781,7 +24866,7 @@ ] }, { - "name": "504", + "name": "507", "meta-type": "enum", "values": [ "plain", @@ -24790,7 +24875,7 @@ ] }, { - "name": "505", + "name": "508", "meta-type": "enum", "values": [ "md5", @@ -24803,28 +24888,28 @@ ] }, { - "name": "506", + "name": "509", "tag": "format", "variants": [ { "case": "qcow", - "type": "496" + "type": "499" }, { "case": "luks", - "type": "540" + "type": "543" } ], "members": [ { "name": "format", - "type": "539" + "type": "542" } ], "meta-type": "object" }, { - "name": "507", + "name": "510", "meta-type": "enum", "values": [ "v2", @@ -24832,35 +24917,35 @@ ] }, { - "name": "508", + "name": "511", "meta-type": "enum", "values": [ "zlib" ] }, { - "name": "509", + "name": "512", "tag": "type", "variants": [ { "case": "full", - "type": "542" + "type": "545" }, { "case": "erasure-coded", - "type": "543" + "type": "546" } ], "members": [ { "name": "type", - "type": "541" + "type": "544" } ], "meta-type": "object" }, { - "name": "510", + "name": "513", "meta-type": "enum", "values": [ "dynamic", @@ -24868,7 +24953,7 @@ ] }, { - "name": "511", + "name": "514", "meta-type": "enum", "values": [ "monolithicSparse", @@ -24879,7 +24964,7 @@ ] }, { - "name": "512", + "name": "515", "meta-type": "enum", "values": [ "ide", @@ -24889,7 +24974,7 @@ ] }, { - "name": "513", + "name": "516", "meta-type": "enum", "values": [ "dynamic", @@ -24897,7 +24982,7 @@ ] }, { - "name": "514", + "name": "517", "meta-type": "enum", "values": [ "active", @@ -24905,12 +24990,12 @@ ] }, { - "name": "515", + "name": "518", "tag": "format", "variants": [ { "case": "luks", - "type": "544" + "type": "547" }, { "case": "qcow", @@ -24920,13 +25005,13 @@ "members": [ { "name": "format", - "type": "539" + "type": "542" } ], "meta-type": "object" }, { - "name": "516", + "name": "519", "members": [ { "name": "logfile", @@ -24956,7 +25041,7 @@ "meta-type": "object" }, { - "name": "517", + "name": "520", "members": [ { "name": "logfile", @@ -24976,7 +25061,7 @@ "meta-type": "object" }, { - "name": "518", + "name": "521", "members": [ { "name": "logfile", @@ -24990,7 +25075,7 @@ }, { "name": "addr", - "type": "284" + "type": "286" }, { "name": "tls-creds", @@ -25041,7 +25126,7 @@ "meta-type": "object" }, { - "name": "519", + "name": "522", "members": [ { "name": "logfile", @@ -25055,18 +25140,18 @@ }, { "name": "remote", - "type": "284" + "type": "286" }, { "name": "local", "default": null, - "type": "284" + "type": "286" } ], "meta-type": "object" }, { - "name": "520", + "name": "523", "members": [ { "name": "logfile", @@ -25082,7 +25167,7 @@ "meta-type": "object" }, { - "name": "521", + "name": "524", "members": [ { "name": "logfile", @@ -25102,7 +25187,7 @@ "meta-type": "object" }, { - "name": "522", + "name": "525", "members": [ { "name": "logfile", @@ -25123,7 +25208,7 @@ "meta-type": "object" }, { - "name": "523", + "name": "526", "members": [ { "name": "logfile", @@ -25143,7 +25228,7 @@ "meta-type": "object" }, { - "name": "524", + "name": "527", "members": [ { "name": "logfile", @@ -25163,7 +25248,7 @@ "meta-type": "object" }, { - "name": "525", + "name": "528", "members": [ { "name": "logfile", @@ -25199,7 +25284,7 @@ "meta-type": "object" }, { - "name": "526", + "name": "529", "members": [ { "name": "logfile", @@ -25220,7 +25305,7 @@ "meta-type": "object" }, { - "name": "527", + "name": "530", "members": [ { "name": "path", @@ -25236,7 +25321,7 @@ "meta-type": "object" }, { - "name": "528", + "name": "531", "members": [ { "name": "chardev", @@ -25246,7 +25331,7 @@ "meta-type": "object" }, { - "name": "529", + "name": "532", "meta-type": "enum", "values": [ "unmapped", @@ -25400,11 +25485,11 @@ ] }, { - "name": "530", + "name": "533", "members": [ { "name": "key", - "type": "321" + "type": "323" }, { "name": "down", @@ -25414,11 +25499,11 @@ "meta-type": "object" }, { - "name": "531", + "name": "534", "members": [ { "name": "button", - "type": "545" + "type": "548" }, { "name": "down", @@ -25428,11 +25513,11 @@ "meta-type": "object" }, { - "name": "532", + "name": "535", "members": [ { "name": "axis", - "type": "546" + "type": "549" }, { "name": "value", @@ -25442,13 +25527,13 @@ "meta-type": "object" }, { - "name": "533", + "name": "536", "members": [ ], "meta-type": "object" }, { - "name": "534", + "name": "537", "members": [ { "name": "number", @@ -25464,21 +25549,21 @@ }, { "name": "io_range", - "type": "547" + "type": "550" }, { "name": "memory_range", - "type": "547" + "type": "550" }, { "name": "prefetchable_range", - "type": "547" + "type": "550" } ], "meta-type": "object" }, { - "name": "535", + "name": "538", "members": [ { "name": "compat", @@ -25494,6 +25579,11 @@ "default": null, "type": "bool" }, + { + "name": "extended-l2", + "default": null, + "type": "bool" + }, { "name": "lazy-refcounts", "default": null, @@ -25511,22 +25601,22 @@ { "name": "encrypt", "default": null, - "type": "548" + "type": "551" }, { "name": "bitmaps", "default": null, - "type": "[549]" + "type": "[552]" }, { "name": "compression-type", - "type": "508" + "type": "511" } ], "meta-type": "object" }, { - "name": "536", + "name": "539", "members": [ { "name": "create-type", @@ -25542,34 +25632,34 @@ }, { "name": "extents", - "type": "[241]" + "type": "[243]" } ], "meta-type": "object" }, { - "name": "537", + "name": "540", "members": [ { "name": "cipher-alg", - "type": "502" + "type": "505" }, { "name": "cipher-mode", - "type": "503" + "type": "506" }, { "name": "ivgen-alg", - "type": "504" + "type": "507" }, { "name": "ivgen-hash-alg", "default": null, - "type": "505" + "type": "508" }, { "name": "hash-alg", - "type": "505" + "type": "508" }, { "name": "payload-offset", @@ -25585,13 +25675,13 @@ }, { "name": "slots", - "type": "[550]" + "type": "[553]" } ], "meta-type": "object" }, { - "name": "538", + "name": "541", "meta-type": "enum", "values": [ "md5", @@ -25599,7 +25689,7 @@ ] }, { - "name": "539", + "name": "542", "meta-type": "enum", "values": [ "qcow", @@ -25607,7 +25697,7 @@ ] }, { - "name": "540", + "name": "543", "members": [ { "name": "key-secret", @@ -25617,27 +25707,27 @@ { "name": "cipher-alg", "default": null, - "type": "502" + "type": "505" }, { "name": "cipher-mode", "default": null, - "type": "503" + "type": "506" }, { "name": "ivgen-alg", "default": null, - "type": "504" + "type": "507" }, { "name": "ivgen-hash-alg", "default": null, - "type": "505" + "type": "508" }, { "name": "hash-alg", "default": null, - "type": "505" + "type": "508" }, { "name": "iter-time", @@ -25648,7 +25738,7 @@ "meta-type": "object" }, { - "name": "541", + "name": "544", "meta-type": "enum", "values": [ "full", @@ -25656,7 +25746,7 @@ ] }, { - "name": "542", + "name": "545", "members": [ { "name": "copies", @@ -25666,7 +25756,7 @@ "meta-type": "object" }, { - "name": "543", + "name": "546", "members": [ { "name": "data-strips", @@ -25680,11 +25770,11 @@ "meta-type": "object" }, { - "name": "544", + "name": "547", "members": [ { "name": "state", - "type": "514" + "type": "517" }, { "name": "new-secret", @@ -25715,7 +25805,7 @@ "meta-type": "object" }, { - "name": "545", + "name": "548", "meta-type": "enum", "values": [ "left", @@ -25728,7 +25818,7 @@ ] }, { - "name": "546", + "name": "549", "meta-type": "enum", "values": [ "x", @@ -25736,7 +25826,7 @@ ] }, { - "name": "547", + "name": "550", "members": [ { "name": "base", @@ -25750,12 +25840,12 @@ "meta-type": "object" }, { - "name": "548", + "name": "551", "tag": "format", "variants": [ { "case": "luks", - "type": "537" + "type": "540" }, { "case": "aes", @@ -25765,18 +25855,18 @@ "members": [ { "name": "format", - "type": "495" + "type": "498" } ], "meta-type": "object" }, { - "name": "[549]", - "element-type": "549", + "name": "[552]", + "element-type": "552", "meta-type": "array" }, { - "name": "549", + "name": "552", "members": [ { "name": "name", @@ -25788,23 +25878,23 @@ }, { "name": "flags", - "type": "[551]" + "type": "[554]" } ], "meta-type": "object" }, { - "name": "[241]", - "element-type": "241", + "name": "[243]", + "element-type": "243", "meta-type": "array" }, { - "name": "[550]", - "element-type": "550", + "name": "[553]", + "element-type": "553", "meta-type": "array" }, { - "name": "550", + "name": "553", "members": [ { "name": "active", @@ -25828,12 +25918,12 @@ "meta-type": "object" }, { - "name": "[551]", - "element-type": "551", + "name": "[554]", + "element-type": "554", "meta-type": "array" }, { - "name": "551", + "name": "554", "meta-type": "enum", "values": [ "in-use", @@ -29482,6 +29572,14 @@ "deprecated": false, "default-ram-id": "pc.ram" }, + { + "hotpluggable-cpus": false, + "name": "none", + "numa-mem-supported": false, + "cpu-max": 1, + "deprecated": false, + "default-ram-id": "ram" + }, { "hotpluggable-cpus": true, "name": "pc-1.1", @@ -29491,14 +29589,6 @@ "deprecated": true, "default-ram-id": "pc.ram" }, - { - "hotpluggable-cpus": false, - "name": "none", - "numa-mem-supported": false, - "cpu-max": 1, - "deprecated": false, - "default-ram-id": "ram" - }, { "hotpluggable-cpus": true, "name": "pc-i440fx-2.7", -- 2.26.2

2 1

recommendations for handling Hyper-V version number
by Matt Coleman 28 Sep '20

28 Sep '20

Hello again, Hyper-V version numbers are not compatible with the encoding used in virParseVersionString: https://gitlab.com/libvirt/libvirt/-/blob/master/src/util/virutil.c#L246 For example, the Windows Server 2016 Hyper-V version is 10.0.14393.0, so its “micro” is over 14 times larger than the encoding allows. My current workaround is to truncate it to something that works (E.G. 10.0.143), but that's clearly less than ideal. Is the output of virParseVersionString stored on disk at any point? Would changing its output type from unsigned long to unsigned long long cause any compatibility issues? That would allow “minor” and “micro” to be up to 6 digits each and would be a quick, easy change. Thanks, Matt

4 6

[PATCH v4 00/11] qemu: Add <transient/> disk support
by Peter Krempa 25 Sep '20

25 Sep '20

This version: - is rebased on top of current refactors - has more strict rules in the validation - adds tests - fixes bug with disk-unplug Masayoshi Mizuma (5): qemu: Block blockjobs when transient disk option is enabled qemu: Block disk hotplug when transient disk option is enabled qemu: Block migration when transient disk option is enabled qemu: process: Handle transient disks on VM startup qemu: validate: Allow <transient/> disks Peter Krempa (6): virDomainSnapshotDiskDefFree: Export and register as autoptr func qemu: prepare cleanup for <transient/> disk overlays qemu: snapshot: Introduce helpers for creating overlays on <transient/> disks qemu: hotplug: Remove overlay of <transient> disk on disk unplug tests: qemuxml2argv: Fix and enable 'disk-transient' case TODO: Add news entry TODO | 0 docs/formatdomain.rst | 5 +- src/conf/snapshot_conf.h | 5 + src/conf/snapshot_conf_priv.h | 3 - src/qemu/qemu_domain.c | 9 ++ src/qemu/qemu_domain.h | 4 + src/qemu/qemu_hotplug.c | 15 +++ src/qemu/qemu_migration.c | 10 ++ src/qemu/qemu_process.c | 27 ++++++ src/qemu/qemu_snapshot.c | 91 ++++++++++++++++++- src/qemu/qemu_snapshot.h | 5 + src/qemu/qemu_validate.c | 56 ++++++++++-- .../disk-transient.x86_64-4.1.0.err | 1 + .../disk-transient.x86_64-latest.args | 42 +++++++++ tests/qemuxml2argvdata/disk-transient.xml | 4 +- tests/qemuxml2argvtest.c | 2 + 16 files changed, 265 insertions(+), 14 deletions(-) create mode 100644 TODO create mode 100644 tests/qemuxml2argvdata/disk-transient.x86_64-4.1.0.err create mode 100644 tests/qemuxml2argvdata/disk-transient.x86_64-latest.args -- 2.26.2

4 21

[PATCH] NEWS: Mention qcow2 cluster size being preserved accross snapshots and iSCSI hostdev fixes
by Peter Krempa 25 Sep '20

25 Sep '20

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index e992fbe471..97417033f4 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -55,8 +55,20 @@ v6.8.0 (unreleased) the previous behavior with an improvement: it also reflects the auto-aligned value in the domain XML. + * qemu: Preserve qcow2 cluster size after external snapshots + + The new overlay image which is installed on top of the current chain when + taking an external snapshot now preserves the cluser size of the original + top image to preserve any performance tuning done on the original image. + * **Bug fixes** + * qemu: Various (i)SCSI backed hostdev fixes + + (i)SCSI backed hostdevs now work again with an arbitrarily long + user-specified device alias and also honor the 'readonly' property after a + recent rewrite. + * **Removed features** * node_device: Remove HAL node device backend -- 2.26.2

2 1

[PATCH] qemu: clear residual QMP caps processes during QEMU driver initialization
by Bihong Yu 25 Sep '20

25 Sep '20

>From c328ff62b11d58553fd2032a85fd3295e009b3d3 Mon Sep 17 00:00:00 2001 From: Bihong Yu <yubihong(a)huawei.com> Date: Fri, 17 Jul 2020 16:55:12 +0800 Subject: [PATCH] qemu: clear residual QMP caps processes during QEMU driver initialization In some cases, the QMP capabilities processes possible residue. So we need to clear the residual QMP caps processes during starting libvirt. Signed-off-by:Bihong Yu <yubihong(a)huawei.com> --- src/qemu/qemu_driver.c | 2 ++ src/qemu/qemu_process.c | 40 ++++++++++++++++++++++++++++++++++++++++ src/qemu/qemu_process.h | 2 ++ 3 files changed, 44 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index d185666..d627fd7 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -889,6 +889,8 @@ qemuStateInitialize(bool privileged, run_gid = cfg->group; } + qemuProcessQMPClear(cfg->libDir); + qemu_driver->qemuCapsCache = virQEMUCapsCacheNew(cfg->libDir, cfg->cacheDir, run_uid, diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 70fc24b..d545e3e 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -8312,6 +8312,46 @@ static qemuMonitorCallbacks callbacks = { }; +/** + * qemuProcessQMPClear + * + * Try to kill residual QMP caps processes + */ +void +qemuProcessQMPClear(const char *libDir) +{ + virErrorPtr orig_err; + DIR *dirp = NULL; + struct dirent *dp; + + if (!virFileExists(libDir)) + return; + + if (virDirOpen(&dirp, libDir) < 0) + return; + + virErrorPreserveLast(&orig_err); + while (virDirRead(dirp, &dp, libDir) > 0) { + g_autofree char *qmp_uniqDir = NULL; + g_autofree char *qmp_pidfile = NULL; + + if (!STRPREFIX(dp->d_name, "qmp-")) + continue; + + qmp_uniqDir = g_strdup_printf("%s/%s", libDir, dp->d_name); + qmp_pidfile = g_strdup_printf("%s/%s", qmp_uniqDir, "qmp.pid"); + + ignore_value(virPidFileForceCleanupPath(qmp_pidfile)); + + if (qmp_uniqDir) + rmdir(qmp_uniqDir); + } + virErrorRestore(&orig_err); + + VIR_DIR_CLOSE(dirp); +} + + static void qemuProcessQMPStop(qemuProcessQMPPtr proc) { diff --git a/src/qemu/qemu_process.h b/src/qemu/qemu_process.h index 15e67b9..b039e6c 100644 --- a/src/qemu/qemu_process.h +++ b/src/qemu/qemu_process.h @@ -233,6 +233,8 @@ qemuProcessQMPPtr qemuProcessQMPNew(const char *binary, gid_t runGid, bool forceTCG); +void qemuProcessQMPClear(const char *libDir); + void qemuProcessQMPFree(qemuProcessQMPPtr proc); int qemuProcessQMPStart(qemuProcessQMPPtr proc); -- 1.8.3.1

3 7

Help on Meson build Error
by Wei Wang 25 Sep '20

25 Sep '20

Seems it didn't appear on the mailing list, resent it. Hi folks, I'm trying to build libvirt using meson with the latest upstream libvirt, but the compilation fails: (followed on https://libvirt.org/compiling.html, not sure if any dependencies are missed. I checked, src/util/libvirt_util.a.p does not exist.) FAILED: src/util/libvirt_util.a.p/glibcompat.c.o .... In file included from ../src/util/glibcompat.c:19: ./config.h:1026:10: fatal error: config-post.h: No such file or directory FAILED: src/util/libvirt_util.a.p/virfirmware.c.o In file included from ../src/util/virarch.c:22: ./config.h:1026:10: fatal error: config-post.h: No such file or directory FAILED: src/util/libvirt_util.a.p/viraudit.c.o In file included from ../src/util/viraudit.c:22: ./config.h:1026:10: fatal error: config-post.h: No such file or directory Any help is appreciated. Thanks, Wei

4 20

[libvirt PATCH] gitdm: add more individual contributors
by Pino Toscano 25 Sep '20

25 Sep '20

Signed-off-by: Pino Toscano <ptoscano(a)redhat.com> --- docs/gitdm/groups/unaffiliated | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/docs/gitdm/groups/unaffiliated b/docs/gitdm/groups/unaffiliated index 5f867fc5e4..1ca7eee81f 100644 --- a/docs/gitdm/groups/unaffiliated +++ b/docs/gitdm/groups/unaffiliated @@ -14,6 +14,7 @@ gmx.de googlemail.com hotmail.com mail.ru +mailbox.org outlook.com pobox.com protonmail.com @@ -43,11 +44,14 @@ cky(a)cky.nz contact(a)puzio.waw.pl d.herrendoerfer(a)herrendoerfer.name dan(a)danny.cz +davem(a)davemloft.net debfx(a)fobos.de eike(a)sf-mail.de exo(a)tty.sk +fedora(a)borsoi.fr fritz(a)fritz-elfert.de gene(a)czarc.net +git(a)ryandesign.com gordon(a)dragonsdawn.net gregor(a)kopka.net heathpetersen(a)kandre.com @@ -59,9 +63,11 @@ jaak(a)ristioja.ee james410(a)cowgill.org.uk james(a)shubin.ca jasper(a)humppa.nl +jean-baptiste(a)holcroft.fr jeremy(a)goop.org jk(a)ozlabs.org jwm(a)horde.net +kevin(a)kevinlocke.name klaus(a)ethgen.de lacos(a)caesar.elte.hu lenaic(a)lhuard.fr.eu.org @@ -71,6 +77,7 @@ marti(a)juffo.org max(a)rfc2324.org michael(a)ellerman.id.au mike(a)very.puzzling.org +milo(a)milo.name n0ano(a)n0ano.com neil(a)aldur.co.uk nobody(a)nowhere.ws @@ -81,11 +88,14 @@ richard(a)nod.at rmy(a)tigress.co.uk ruben(a)rubenkerkhof.com rufo(a)rufoa.com +scott-libvirt(a)shambarger.net +shemminger(a)vyatta.com slawek(a)kaplonski.pl soulxu(a)soulxu-thinkpad-t410.(none) stybla(a)turnovfree.net tai(a)rakugaki.org thomas(a)scripty.at +toscano.pino(a)tiscali.it v.tolstov(a)selfip.ru ville.skytta(a)iki.fi vincent(a)bernat.im -- 2.26.2

2 1

[libvirt PATCH] meson: drop HTML4 variants of rst2html
by Daniel P. Berrangé 25 Sep '20

25 Sep '20

We stopped supportin Ubuntu 16.04 earlier in the year, so there is no reason to keep the HTML4 variants of rst2html around. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- meson.build | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/meson.build b/meson.build index bc52079809..2e57a435df 100644 --- a/meson.build +++ b/meson.build @@ -898,8 +898,7 @@ required_programs = [ required_programs_groups = [ {'name':'rpcgen', 'prog':['rpcgen', 'portable-rpcgen']}, - # Drop the rst2html (aka HTML4) variants once we stop supporting Ubuntu 16.04 (Xenial) - {'name':'rst2html', 'prog':['rst2html5', 'rst2html5.py', 'rst2html5-3', 'rst2html', 'rst2html.py', 'rst2html-3']}, + {'name':'rst2html', 'prog':['rst2html5', 'rst2html5.py', 'rst2html5-3']}, {'name':'rst2man', 'prog':['rst2man', 'rst2man.py', 'rst2man-3']}, ] -- 2.26.2

3 2

[PATCH] meson: don't check for libutil.h except on FreeBSD
by Daniel P. Berrangé 25 Sep '20

25 Sep '20

The libutil.h we are after is explicitly only something we want on FreeBSD, we don't want to accidentally pick up this header on other platforms as it can lead to build failures. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- meson.build | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 4d42468a51..bc52079809 100644 --- a/meson.build +++ b/meson.build @@ -685,7 +685,6 @@ headers = [ 'asm/hwcap.h', 'ifaddrs.h', 'libtasn1.h', - 'libutil.h', 'linux/kvm.h', 'linux/magic.h', 'mntent.h', @@ -711,6 +710,10 @@ if host_machine.system() == 'linux' headers += 'linux/devlink.h' endif +if host_machine.system() == 'freebsd' + headers += 'libutil.h' +endif + foreach name : headers if cc.has_header(name) conf.set('WITH_@0@'.format(name.underscorify().to_upper()), 1) -- 2.26.2

3 2

[libvirt PATCH 0/5] Use g_new0 more (glib chronicles)
by Ján Tomko 24 Sep '20

24 Sep '20

Remove VIR_ALLOC* from tools/ (with the exception of vsh*alloc, which will be cleaned up later) and some random subdirs from src/ Ján Tomko (5): node_device: use g_new0 instead of VIR_ALLOC* openvz: use g_new0 instead of VIR_ALLOC* secret: use g_new0 instead of VIR_ALLOC* security: use g_new0 instead of VIR_ALLOC* tools: use g_new0 instead of VIR_ALLOC* src/node_device/node_device_udev.c | 27 +++++++++------------------ src/openvz/openvz_conf.c | 12 ++++-------- src/openvz/openvz_driver.c | 3 +-- src/secret/secret_driver.c | 3 +-- src/security/security_apparmor.c | 3 +-- src/security/security_dac.c | 9 +++------ src/security/security_manager.c | 14 +++++--------- src/security/security_selinux.c | 9 +++------ src/security/security_stack.c | 6 ++---- tools/virsh-domain-monitor.c | 11 +++-------- tools/virsh-domain.c | 26 ++++++++------------------ tools/virt-admin-completer.c | 12 +----------- tools/virt-login-shell-helper.c | 13 ++++--------- tools/vsh-table.c | 21 +++++++-------------- tools/vsh.c | 5 +---- 15 files changed, 53 insertions(+), 121 deletions(-) -- 2.26.2

2 10

[PATCH FOR 6.8.0] libxl: Don't free def member of virDomainObj
by Jim Fehlig 24 Sep '20

24 Sep '20

The refactoring in commit de49d5bad3 accidentally dropped the statement setting def to NULL after successfully adding it to the virDomainObjList, causing it to be freed while still in use. The resulting memory corruption caused unpredictable behavior, often resulting in a libvirtd crash. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- Unpredictable is an understatement! When running monolithic libvirtd with both qemu and xen drviers enabled, qemu crashed while initializing. Recall it is initialized after xen. Thread 17 "daemon-init" received signal SIGSEGV, Segmentation fault. #0 0x00007f32e5fbe9e3 in _int_malloc () at /lib64/libc.so.6 #1 0x00007f32e5fbf6e0 in _int_realloc () at /lib64/libc.so.6 #2 0x00007f32e5fc0729 in realloc () at /lib64/libc.so.6 #3 0x00007f32e6dc21b8 in g_realloc () at /usr/lib64/libglib-2.0.so.0 #4 0x00007f32e7532090 in virReallocN (ptrptr=0x7f329affcad8, size=1, count=1403) at ../src/util/viralloc.c:91 #5 0x00007f32e75530c7 in virCommandProcessIO (cmd=0x7f328807ff40) at ../src/util/vircommand.c:2271 #6 0x00007f32e7553a6a in virCommandRun (cmd=0x7f328807ff40, exitstatus=0x0) at ../src/util/vircommand.c:2451 #7 0x00007f32e75dde73 in virSysinfoReadDMI () at ../src/util/virsysinfo.c:1237 #8 0x00007f32e75de0cb in virSysinfoRead () at ../src/util/virsysinfo.c:1294 #9 0x00007f32a240b69d in qemuStateInitialize (privileged=true, root=0x0, callback=0x56453a0b3e97 <daemonInhibitCallback>, opaque=0x56453b000030) at ../src/qemu/qemu_driver.c:658 #10 0x00007f32e7832350 in virStateInitialize (privileged=true, mandatory=false, root=0x0, callback=0x56453a0b3e97 <daemonInhibitCallback>, opaque=0x56453b000030) at ../src/libvirt.c:656 #11 0x000056453a0b4175 in daemonRunStateInit (opaque=0x56453b000030) at ../src/remote/remote_daemon.c:596 src/libxl/libxl_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 083738871d..571b70f982 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -627,6 +627,7 @@ libxlAddDom0(libxlDriverPrivatePtr driver) NULL))) goto cleanup; + def = NULL; vm->persistent = 1; virDomainObjSetState(vm, VIR_DOMAIN_RUNNING, VIR_DOMAIN_RUNNING_BOOTED); } -- 2.28.0

3 2

[RFC DOCUMENT 00/12] kubevirt-and-kvm: Add documents
by Andrea Bolognani 24 Sep '20

24 Sep '20

Hello there! Several weeks ago, a group of Red Hatters working on the virtualization stack (primarily QEMU and libvirt) started a conversation with developers from the KubeVirt project with the goal of better understanding and documenting the interactions between the two. Specifically, we were interested in integration pain points, with the underlying ideas being that only once those issues are understood it becomes possible to look for solutions, and that better communication would naturally lead to improvements on both sides. This series of documents was born out of that conversation. We're sharing them with the QEMU and libvirt communities in the hope that they can be a valuable resource for understanding how the projects they're working on are consumed by higher-level tools, and what challenges are encountered in the process. Note that, while the documents describe a number of potential directions for things like development of new components, that's all just brainstorming that naturally occurred as we were learning new things: the actual design process should, and will, happen on the upstream lists. Right now the documents live in their own little git repository[1], but the expectation is that eventually they will find a suitable long-term home. The most likely candidate right now is the main KubeVirt repository, but if you have other locations in mind please do speak up! I'm also aware of the fact that this delivery mechanism is fairly unconventional, but I thought it would be the best way to spark a discussion around these topics with the QEMU and libvirt developers. Last but not least, please keep in mind that the documents are a work in progress, and polish has been applied to them unevenly: while the information presented is, to the best of our knowledge, all accurate, some parts are in a rougher state than others. Improvements will hopefully come over time - and if you feel like helping out in making that happen, it would certainly be appreciated! Looking forward to your feedback :) [1] https://gitlab.com/abologna/kubevirt-and-kvm -- Andrea Bolognani / Red Hat / Virtualization

2 14

[libvirt PATCH] news: document recent esx API implementations
by Pino Toscano 24 Sep '20

24 Sep '20

Signed-off-by: Pino Toscano <ptoscano(a)redhat.com> --- NEWS.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index e992fbe471..7c723e6610 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -32,6 +32,13 @@ v6.8.0 (unreleased) can now be passed using the ``passwd`` attribute on the ``<graphics>`` element. + * esx: implement few APIs + + The ``virConnectListAllNetworks()``, ``virDomainGetHostname()``, and + ``virDomainInterfaceAddresses()`` (only for + ``VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_AGENT`` source) APIs were implemented + in the esx driver. + * **Improvements** * qemu: Allow migration over UNIX sockets -- 2.26.2

2 1

[libvirt PATCH] news: add note about new virt-ssh-helper binary
by Daniel P. Berrangé 24 Sep '20

24 Sep '20

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- NEWS.rst | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index e992fbe471..13d2ff1d2f 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -32,6 +32,19 @@ v6.8.0 (unreleased) can now be passed using the ``passwd`` attribute on the ``<graphics>`` element. + * remote: ``virt-ssh-helper`` replaces ``nc`` for SSH tunnelling + + Libvirt now provides a ``virt-ssh-helper`` binary on the server + side. The libvirt remote client will use this binary for setting + up an SSH tunnelled connection to hosts. If not present, it will + transparently fallback to the traditional ``nc`` tunnel. The new + binary makes it possible for libvirt to transparently connect + across hosts even if libvirt is built with a different installation + prefix on the client vs server. It also enables remote access to + the unprivileged per-user libvirt daemons(eg using a URI such as + ``qemu+ssh://hostname/session``. The only requirement is that + ``virt-ssh-helper`` is present in $PATH of the remote host. + * **Improvements** * qemu: Allow migration over UNIX sockets -- 2.26.2

2 1

[libvirt PATCH v4 00/11] remote: introduce a custom netcat impl for ssh tunnelling
by Daniel P. Berrangé 24 Sep '20

24 Sep '20

We have long had a problem with use of netcat for ssh tunnelling because there's no guarantee the UNIX socket path the client builds will match the UNIX socket path the remote host uses. We don't even allow session mode SSH tunnelling for this reason. We also can't easily auto-spawn libvirtd in session mode. With the introduction of modular daemons we also have potential for two completely different UNIX socket paths even for system mode, and the client can't know which to use. The solution to all these problems is to introduce a custom netcat impl. Instead passing the UNIX socket path, we pass the libvirt driver URI. The custom netcat then decides which socket path to use based on the remote build host environment. We still have to support netcat for interoperability with legacy libvirt versions, but we can default to the new virt-nc. v4: Now with many fixed bugs to make it actually work v3: Now with more meson and less autotools ! Daniel P. Berrangé (11): rpc: merge logic for generating remote SSH shell script remote: push logic for default netcat binary into common helper remote: split off enums into separate source file remote: split out function for parsing URI scheme remote: parse the remote transport string earlier remote: split out function for constructing socket path remote: extract logic for determining daemon to connect to remote: introduce virt-ssh-helper binary rpc: switch order of args in virNetClientNewSSH rpc: use new virt-ssh-helper binary for remote tunnelling remote: fix error reporting for invalid daemon mode build-aux/syntax-check.mk | 2 +- docs/uri.html.in | 24 +- libvirt.spec.in | 2 + po/POTFILES.in | 2 + src/libvirt_remote.syms | 1 + src/remote/meson.build | 18 ++ src/remote/remote_driver.c | 331 +++++-------------------- src/remote/remote_sockets.c | 277 +++++++++++++++++++++ src/remote/remote_sockets.h | 70 ++++++ src/remote/remote_ssh_helper.c | 425 +++++++++++++++++++++++++++++++++ src/rpc/virnetclient.c | 167 +++++++++---- src/rpc/virnetclient.h | 29 ++- src/rpc/virnetsocket.c | 37 +-- src/rpc/virnetsocket.h | 4 +- tests/virnetsockettest.c | 12 +- 15 files changed, 1030 insertions(+), 371 deletions(-) create mode 100644 src/remote/remote_sockets.c create mode 100644 src/remote/remote_sockets.h create mode 100644 src/remote/remote_ssh_helper.c -- 2.26.2

3 14

[PATCH V3] Modify virCPUarmCompare to perform compare actions
by Zhenyu Zheng 24 Sep '20

24 Sep '20

Modify virCPUarmCompare in cpu_arm.c to perform compare action. This patch only adds host to host CPU compare, the rest cases remains the same. This is useful for source and destination host compare during migrations to avoid migration between different CPU models that have different CPU freatures. Signed-off-by: Zhenyu Zheng <zheng.zhenyu(a)outlook.com> --- src/cpu/cpu_arm.c | 43 +++++++++++++++++++++++++++++++++++++++---- 1 file changed, 39 insertions(+), 4 deletions(-) diff --git a/src/cpu/cpu_arm.c b/src/cpu/cpu_arm.c index 939a3b8390..b420b14e86 100644 --- a/src/cpu/cpu_arm.c +++ b/src/cpu/cpu_arm.c @@ -463,11 +463,46 @@ virCPUarmBaseline(virCPUDefPtr *cpus, } static virCPUCompareResult -virCPUarmCompare(virCPUDefPtr host G_GNUC_UNUSED, - virCPUDefPtr cpu G_GNUC_UNUSED, - bool failMessages G_GNUC_UNUSED) +virCPUarmCompare(virCPUDefPtr host, + virCPUDefPtr cpu, + bool failIncompatible +) { - return VIR_CPU_COMPARE_IDENTICAL; + virCPUCompareResult ret = VIR_CPU_COMPARE_IDENTICAL; + + /* Only support host to host CPU compare for ARM*/ + if (cpu->type != VIR_CPU_TYPE_HOST) + return ret; + + if (!host || !host->model) { + if (failIncompatible) { + virReportError(VIR_ERR_CPU_INCOMPATIBLE, "%s", + _("unknown host CPU")); + ret = VIR_CPU_COMPARE_ERROR; + } else { + VIR_WARN("unknown host CPU"); + ret = VIR_CPU_COMPARE_INCOMPATIBLE; + } + return ret; + } + + /* Compare vendor and model to check if CPUs are identical */ + if (STRNEQ(host->vendor, cpu->vendor) || + STRNEQ(host->model, cpu->model)) { + VIR_DEBUG("Host CPU model does not match required CPU model %s", + cpu->model); + + if (failIncompatible) { + ret = VIR_CPU_COMPARE_ERROR; + virReportError(VIR_ERR_CPU_INCOMPATIBLE, + _("Host CPU model does not match required CPU model %s"), + cpu->model); + } else { + ret = VIR_CPU_COMPARE_INCOMPATIBLE; + } + } + + return ret; } static int -- 2.20.1

3 3

[PATCH v1 1/2] qemu: driver: use model name "host" for mode "host-passthrough"
by Collin Walling 24 Sep '20

24 Sep '20

When executing the hypervisor-cpu-compare/baseline commands and the XML file contains a CPU definition using host-passthrough and no model name, the commands will fail and return an error message from the QMP response. Let's fix this by checking for host-passthrough and a missing model name after the CPU definition has been converted from XML. If these conditions are matched, then the CPU definition's model name will be set to "host". Signed-off-by: Collin Walling <walling(a)linux.ibm.com> --- src/qemu/qemu_driver.c | 41 +++++++++++++++++++++++++++++++---------- 1 file changed, 31 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 1cecef01f7..427d2419f3 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -12281,6 +12281,26 @@ qemuConnectCPUModelComparison(virQEMUCapsPtr qemuCaps, } +static int +qemuConnectCheckCPUModel(virCPUDefPtr cpu) +{ + if (!cpu->model) { + /* + * On some architectures a model name is never present + * for the host-passthrough mode, so default it to "host" + */ + if (cpu->mode == VIR_CPU_MODE_HOST_PASSTHROUGH) { + cpu->model = g_strdup("host"); + } else { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("cpu parameter is missing a model name")); + return -1; + } + } + return 0; +} + + static int qemuConnectCompareHypervisorCPU(virConnectPtr conn, const char *emulator, @@ -12336,15 +12356,9 @@ qemuConnectCompareHypervisorCPU(virConnectPtr conn, if (virCPUDefParseXMLString(xmlCPU, VIR_CPU_TYPE_AUTO, &cpu) < 0) goto cleanup; - if (!cpu->model) { - if (cpu->mode == VIR_CPU_MODE_HOST_PASSTHROUGH) { - cpu->model = g_strdup("host"); - } else { - virReportError(VIR_ERR_INVALID_ARG, "%s", - _("cpu parameter is missing a model name")); - goto cleanup; - } - } + if (qemuConnectCheckCPUModel(cpu) < 0) + goto cleanup; + ret = qemuConnectCPUModelComparison(qemuCaps, cfg->libDir, cfg->user, cfg->group, hvCPU, cpu, failIncompatible); @@ -12470,10 +12484,17 @@ qemuConnectCPUModelBaseline(virQEMUCapsPtr qemuCaps, if (VIR_ALLOC(baseline) < 0) return NULL; - if (virCPUDefCopyModel(baseline, cpus[0], false)) + if (qemuConnectCheckCPUModel(cpus[0]) < 0) + return NULL; + + if (virCPUDefCopyModel(baseline, cpus[0], false) < 0) return NULL; for (i = 1; i < ncpus; i++) { + + if (qemuConnectCheckCPUModel(cpus[i]) < 0) + return NULL; + if (qemuMonitorGetCPUModelBaseline(proc->mon, baseline, cpus[i], &result) < 0) return NULL; -- 2.26.2

2 4

[PATCH] virDomainNetFindIdx: add support for CCW addresses
by Cornelia Huck 24 Sep '20

24 Sep '20

Allow to match with CCW addresses in addition to PCI addresses (and MAC addresses). Signed-off-by: Cornelia Huck <cohuck(a)redhat.com> --- src/conf/device_conf.c | 12 ++++++++++++ src/conf/device_conf.h | 3 +++ src/conf/domain_conf.c | 23 ++++++++++++++++++++++- src/libvirt_private.syms | 1 + 4 files changed, 38 insertions(+), 1 deletion(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 9398191dfd84..87bf32bbc685 100644 --- a/src/conf/device_conf.c +++ b/src/conf/device_conf.c @@ -341,6 +341,18 @@ virDomainDeviceCCWAddressParseXML(xmlNodePtr node, return 0; } +bool +virDomainDeviceCCWAddressEqual(virDomainDeviceCCWAddressPtr addr1, + virDomainDeviceCCWAddressPtr addr2) +{ + if (addr1->cssid == addr2->cssid && + addr1->ssid == addr2->ssid && + addr1->devno == addr2->devno) { + return true; + } + return false; +} + int virDomainDeviceDriveAddressParseXML(xmlNodePtr node, virDomainDeviceDriveAddressPtr addr) diff --git a/src/conf/device_conf.h b/src/conf/device_conf.h index d7395f220174..a51bdf10ee6e 100644 --- a/src/conf/device_conf.h +++ b/src/conf/device_conf.h @@ -207,6 +207,9 @@ void virPCIDeviceAddressFormat(virBufferPtr buf, bool virDomainDeviceCCWAddressIsValid(virDomainDeviceCCWAddressPtr addr); int virDomainDeviceCCWAddressParseXML(xmlNodePtr node, virDomainDeviceCCWAddressPtr addr); +bool virDomainDeviceCCWAddressEqual(virDomainDeviceCCWAddressPtr addr1, + virDomainDeviceCCWAddressPtr addr2); +#define VIR_CCW_DEVICE_ADDRESS_FMT "%x.%x.%04x" int virDomainDeviceDriveAddressParseXML(xmlNodePtr node, virDomainDeviceDriveAddressPtr addr); diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 8d30557bdcbe..a91dbd4aa95b 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -17816,6 +17816,8 @@ virDomainNetFindIdx(virDomainDefPtr def, virDomainNetDefPtr net) bool MACAddrSpecified = !net->mac_generated; bool PCIAddrSpecified = virDomainDeviceAddressIsValid(&net->info, VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI); + bool CCWAddrSpecified = virDomainDeviceAddressIsValid(&net->info, + VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW); for (i = 0; i < def->nnets; i++) { if (MACAddrSpecified && @@ -17827,9 +17829,14 @@ virDomainNetFindIdx(virDomainDefPtr def, virDomainNetDefPtr net) &net->info.addr.pci)) continue; + if (CCWAddrSpecified && + !virDomainDeviceCCWAddressEqual(&def->nets[i]->info.addr.ccw, + &net->info.addr.ccw)) + continue; + if (matchidx >= 0) { /* there were multiple matches on mac address, and no - * qualifying guest-side PCI address was given, so we must + * qualifying guest-side PCI/CCW address was given, so we must * fail (NB: a USB address isn't adequate, since it may * specify only vendor and product ID, and there may be * multiples of those. @@ -17859,6 +17866,14 @@ virDomainNetFindIdx(virDomainDefPtr def, virDomainNetDefPtr net) net->info.addr.pci.bus, net->info.addr.pci.slot, net->info.addr.pci.function); + } else if (MACAddrSpecified && CCWAddrSpecified) { + virReportError(VIR_ERR_DEVICE_MISSING, + _("no device matching MAC address %s found on " + VIR_CCW_DEVICE_ADDRESS_FMT), + virMacAddrFormat(&net->mac, mac), + net->info.addr.ccw.cssid, + net->info.addr.ccw.ssid, + net->info.addr.ccw.devno); } else if (PCIAddrSpecified) { virReportError(VIR_ERR_DEVICE_MISSING, _("no device found on " VIR_PCI_DEVICE_ADDRESS_FMT), @@ -17866,6 +17881,12 @@ virDomainNetFindIdx(virDomainDefPtr def, virDomainNetDefPtr net) net->info.addr.pci.bus, net->info.addr.pci.slot, net->info.addr.pci.function); + } else if (CCWAddrSpecified) { + virReportError(VIR_ERR_DEVICE_MISSING, + _("no device found on " VIR_CCW_DEVICE_ADDRESS_FMT), + net->info.addr.ccw.cssid, + net->info.addr.ccw.ssid, + net->info.addr.ccw.devno); } else if (MACAddrSpecified) { virReportError(VIR_ERR_DEVICE_MISSING, _("no device matching MAC address %s found"), diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 1db9970cca08..6bcbfa667d0e 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -128,6 +128,7 @@ virDeviceInfoPCIAddressIsWanted; virDomainDeviceAddressIsValid; virDomainDeviceAddressTypeToString; virDomainDeviceCcidAddressParseXML; +virDomainDeviceCCWAddressEqual; virDomainDeviceCCWAddressIsValid; virDomainDeviceCCWAddressParseXML; virDomainDeviceDriveAddressParseXML; -- 2.25.4

2 1

[PATCH] qemuxml2argvtest: Append newline to tested error messages
by Peter Krempa 24 Sep '20

24 Sep '20

'virTestCompareToFile' automatically fixes newline if it is not present in the input string but is present in the file. In this case we need to append the erorr messages with a newline so that VIR_TEST_REGENERATE_OUTPUT produces files which will pass syntax-check. Fixes: 9ec77eef2df Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- tests/qemuxml2argvtest.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index a3c91fd5de..2b97eb80a4 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -621,9 +621,11 @@ testCompareXMLToArgv(const void *data) VIR_TEST_DEBUG("no error was reported for expected parse error"); goto cleanup; } - if (flags & FLAG_EXPECT_PARSE_ERROR && - virTestCompareToFile(err->message, info->errfile) >= 0) - goto ok; + if (flags & FLAG_EXPECT_PARSE_ERROR) { + g_autofree char *tmperr = g_strdup_printf("%s\n", NULLSTR(err->message)); + if (virTestCompareToFile(tmperr, info->errfile) >= 0) + goto ok; + } goto cleanup; } if (flags & FLAG_EXPECT_PARSE_ERROR) { @@ -663,9 +665,11 @@ testCompareXMLToArgv(const void *data) VIR_TEST_DEBUG("no error was reported for expected failure"); goto cleanup; } - if (flags & FLAG_EXPECT_FAILURE && - virTestCompareToFile(err->message, info->errfile) >= 0) - goto ok; + if (flags & FLAG_EXPECT_FAILURE) { + g_autofree char *tmperr = g_strdup_printf("%s\n", NULLSTR(err->message)); + if (virTestCompareToFile(tmperr, info->errfile) >= 0) + goto ok; + } goto cleanup; } if (flags & FLAG_EXPECT_FAILURE) { -- 2.26.2

2 1

[PATCH] cpu_map: Add EPYC-Rome model
by Markus Schade 24 Sep '20

24 Sep '20

Hi everyone, I'd like to add support for the EPYC-Rome CPU model from qemu. The following patch adds the model to cpu_map. While this allows to use the model, I am aware that some tests are required as well. However I am not certain what exactly is needed. I am happy to provide CPU flags or any required information from an EPYC 7502 system Signed-off-by: Markus Schade <markus.schade(a)hetzner.com> diff --git a/src/cpu_map/index.xml b/src/cpu_map/index.xml index 1486a29c65..fec01f324c 100644 --- a/src/cpu_map/index.xml +++ b/src/cpu_map/index.xml @@ -66,6 +66,7 @@ <include filename="x86_Opteron_G5.xml"/> <include filename="x86_EPYC.xml"/> <include filename="x86_EPYC-IBPB.xml"/> + <include filename="x86_EPYC-Rome.xml"/>  <include filename="x86_Dhyana.xml"/> diff --git a/src/cpu_map/meson.build b/src/cpu_map/meson.build index 19daa7157b..b86612b6e0 100644 --- a/src/cpu_map/meson.build +++ b/src/cpu_map/meson.build @@ -32,6 +32,7 @@ cpumap_data = [ 'x86_Dhyana.xml', 'x86_EPYC-IBPB.xml', 'x86_EPYC.xml', + 'x86_EPYC-Rome.xml', 'x86_features.xml', 'x86_Haswell-IBRS.xml', 'x86_Haswell-noTSX-IBRS.xml', diff --git a/src/cpu_map/x86_EPYC-Rome.xml b/src/cpu_map/x86_EPYC-Rome.xml new file mode 100644 index 0000000000..41d4123917 --- /dev/null +++ b/src/cpu_map/x86_EPYC-Rome.xml @@ -0,0 +1,81 @@ +<cpus> + <model name='EPYC-Rome'> + <decode host='on' guest='on'/> + <signature family='23' model='49'/> + <vendor name='AMD'/> + <feature name='3dnowprefetch'/> + <feature name='abm'/> + <feature name='adx'/> + <feature name='aes'/> + <feature name='amd-stibp'/> + <feature name='apic'/> + <feature name='arat'/> + <feature name='avx'/> + <feature name='avx2'/> + <feature name='bmi1'/> + <feature name='bmi2'/> + <feature name='clflush'/> + <feature name='clflushopt'/> + <feature name='clwb'/> + <feature name='clzero'/> + <feature name='cmov'/> + <feature name='cr8legacy'/> + <feature name='cx16'/> + <feature name='cx8'/> + <feature name='de'/> + <feature name='f16c'/> + <feature name='fma'/> + <feature name='fpu'/> + <feature name='fsgsbase'/> + <feature name='fxsr'/> + <feature name='fxsr_opt'/> + <feature name='ibpb'/> + <feature name='lahf_lm'/> + <feature name='lm'/> + <feature name='mca'/> + <feature name='mce'/> + <feature name='misalignsse'/> + <feature name='mmx'/> + <feature name='mmxext'/> + <feature name='monitor'/> + <feature name='movbe'/> + <feature name='msr'/> + <feature name='mtrr'/> + <feature name='nx'/> + <feature name='osvw'/> + <feature name='pae'/> + <feature name='pat'/> + <feature name='pclmuldq'/> + <feature name='pdpe1gb'/> + <feature name='perfctr_core'/> + <feature name='pge'/> + <feature name='pni'/> + <feature name='popcnt'/> + <feature name='pse'/> + <feature name='pse36'/> + <feature name='rdpid'/> + <feature name='rdrand'/> + <feature name='rdseed'/> + <feature name='rdtscp'/> + <feature name='sep'/> + <feature name='sha-ni'/> + <feature name='smap'/> + <feature name='smep'/> + <feature name='sse'/> + <feature name='sse2'/> + <feature name='sse4.1'/> + <feature name='sse4.2'/> + <feature name='sse4a'/> + <feature name='ssse3'/> + <feature name='svm'/> + <feature name='syscall'/> + <feature name='tsc'/> + <feature name='vme'/> + <feature name='wbnoinvd'/> + <feature name='xgetbv1'/> + <feature name='xsave'/> + <feature name='xsavec'/> + <feature name='xsaveerptr'/> + <feature name='xsaveopt'/> + </model> +</cpus>

2 1

[PATCH] util: stop probing for IFF_VNET_HDR
by Daniel P. Berrangé 24 Sep '20

24 Sep '20

This flag was added by Linux with: commit f43798c27684ab925adde7d8acc34c78c6e50df8 Author: Rusty Russell <rusty(a)rustcorp.com.au> Date: Thu Jul 3 03:48:02 2008 -0700 tun: Allow GSO using virtio_net_hdr so we can assume all Linux distros we support have this flag available and thus the compile time check is sufficient. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/util/virnetdevtap.c | 63 +---------------------------------------- 1 file changed, 1 insertion(+), 62 deletions(-) diff --git a/src/util/virnetdevtap.c b/src/util/virnetdevtap.c index cbce5c71b7..77c4d1c52c 100644 --- a/src/util/virnetdevtap.c +++ b/src/util/virnetdevtap.c @@ -183,66 +183,6 @@ virNetDevTapGetRealDeviceName(char *ifname G_GNUC_UNUSED) } -/** - * virNetDevProbeVnetHdr: - * @tapfd: a tun/tap file descriptor - * - * Check whether it is safe to enable the IFF_VNET_HDR flag on the - * tap interface. - * - * Setting IFF_VNET_HDR enables QEMU's virtio_net driver to allow - * guests to pass larger (GSO) packets, with partial checksums, to - * the host. This greatly increases the achievable throughput. - * - * It is only useful to enable this when we're setting up a virtio - * interface. And it is only *safe* to enable it when we know for - * sure that a) qemu has support for IFF_VNET_HDR and b) the running - * kernel implements the TUNGETIFF ioctl(), which qemu needs to query - * the supplied tapfd. - * - * Returns 1 if VnetHdr is supported, 0 if not supported - */ -#ifdef IFF_VNET_HDR -static int -virNetDevProbeVnetHdr(int tapfd) -{ -# if defined(IFF_VNET_HDR) && defined(TUNGETFEATURES) && defined(TUNGETIFF) - unsigned int features; - struct ifreq dummy; - - if (ioctl(tapfd, TUNGETFEATURES, &features) != 0) { - VIR_INFO("Not enabling IFF_VNET_HDR; " - "TUNGETFEATURES ioctl() not implemented"); - return 0; - } - - if (!(features & IFF_VNET_HDR)) { - VIR_INFO("Not enabling IFF_VNET_HDR; " - "TUNGETFEATURES ioctl() reports no IFF_VNET_HDR"); - return 0; - } - - /* The kernel will always return -1 at this point. - * If TUNGETIFF is not implemented then errno == EBADFD. - */ - if (ioctl(tapfd, TUNGETIFF, &dummy) != -1 || errno != EBADFD) { - VIR_INFO("Not enabling IFF_VNET_HDR; " - "TUNGETIFF ioctl() not implemented"); - return 0; - } - - VIR_INFO("Enabling IFF_VNET_HDR"); - - return 1; -# else - (void) tapfd; - VIR_INFO("Not enabling IFF_VNET_HDR; disabled at build time"); - return 0; -# endif -} -#endif - - #ifdef TUNSETIFF /** * virNetDevTapGenerateName: @@ -363,8 +303,7 @@ int virNetDevTapCreate(char **ifname, } # ifdef IFF_VNET_HDR - if ((flags & VIR_NETDEV_TAP_CREATE_VNET_HDR) && - virNetDevProbeVnetHdr(fd)) + if (flags & VIR_NETDEV_TAP_CREATE_VNET_HDR) ifr.ifr_flags |= IFF_VNET_HDR; # endif -- 2.26.2

2 2

[PATCH 0/2] qemuSnapshotDiskContext(Cleanup|New): fix few bugs
by Peter Krempa 24 Sep '20

24 Sep '20

Oops. Peter Krempa (2): qemuSnapshotDiskContextCleanup: Don't leak snapctxt qemuSnapshotDiskContextNew: Don't set 'ndd' src/qemu/qemu_snapshot.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.26.2

2 3

[PATCH 0/6] qemu: snapshot: Refactors prior to introduction of <transient> disk support
by Peter Krempa 24 Sep '20

24 Sep '20

We'll be installing overlays on top of <transient> disks via the snapshot code. Prepare some aspects. Peter Krempa (6): qemu: snapshot: Rename 'qemuSnapshotCreateDiskActive' to 'qemuSnapshotCreateActiveExternalDisks' qemuSnapshotDiskUpdateSource: Extract 'driver' and 'blockdev' from 'vm' qemuSnapshotDiskPrepare/Cleanup: simplify passing of 'driver' and 'blockdev' qemu: snapshot: Introduce qemuSnapshotDiskContext qemuSnapshotCreateActiveExternalDisks: Extract actual snapshot creation to 'qemuSnapshotDiskCreate' qemuSnapshotDiskPrepare: rename to qemuSnapshotDiskPrepareActiveExternal src/qemu/qemu_snapshot.c | 215 ++++++++++++++++++++++----------------- 1 file changed, 124 insertions(+), 91 deletions(-) -- 2.26.2

2 8

[libvirt PATCH 00/14] Various cleanups
by Ján Tomko 24 Sep '20

24 Sep '20

Some reported by cppcheck, maybe even Coverity, the rest I noticed while looking at the code. Ján Tomko (14): tools: virshCheckpointListCollect: remove unused names vbox: remove VBoxCGlueTerm vbox: StartMachine: overwrite ret less often Remove pointless assignments Remove pointless initializations virsh: virshStreamSourceSkip: remove unused 'off' Do not check whether unsigned variables are negative libxl: remove unused 'bits' from struct guest_arch api: virDomainMemoryStats: use 'ret' variable storage: createFileDir: remove useless 'err' variable storage: createFileDir: use less ternary operators vbox: reduce variable scope in vboxDumpStorageControllers storage: storageBackendWipeLocal: reduce variable scope Reduce scope of some variables examples/c/admin/logging.c | 2 +- src/libvirt-domain.c | 8 ++--- src/libvirt-host.c | 4 +-- src/libxl/libxl_capabilities.c | 1 - src/libxl/libxl_driver.c | 2 +- src/node_device/node_device_driver.c | 3 +- src/openvz/openvz_driver.c | 2 +- src/storage/storage_backend_mpath.c | 3 +- src/storage/storage_util.c | 33 ++++++++++---------- src/test/test_driver.c | 2 +- src/vbox/vbox_XPCOMCGlue.c | 19 ------------ src/vbox/vbox_XPCOMCGlue.h | 1 - src/vbox/vbox_common.c | 46 +++++++++++++--------------- tests/virnumamock.c | 2 +- tests/virrandommock.c | 2 +- tools/virsh-checkpoint.c | 5 --- tools/virsh-pool.c | 3 +- tools/virsh-util.c | 3 +- 18 files changed, 53 insertions(+), 88 deletions(-) -- 2.26.2

3 30

[PATCH] tests: Adjust libxlxml2domconfigtest to work with Xen < 4.10
by Jim Fehlig 24 Sep '20

24 Sep '20

Commit f253dc90f5 introduced a test regression in environments with Xen < 4.10. The logic in libxl_conf.c correctly maps ACPI and APIC from virDomainObj to libxl_domain_conf based on LIBXL_HAVE_BUILDINFO_APIC, but the tests did not account for the different libxl_domain_conf JSON representations. One approach to fixing the test regression is to duplicate JSON test data files, having one set for Xen <= 4.9 and another for Xen 4.10 and greater. To avoid duplicate data files, this patch takes the approach of modifying the libxl_domain_conf object based on LIBXL_HAVE_BUILDINFO_APIC, before retrieving the JSON representation. It allows using the same test data files for all supported versions of Xen by adjusting the intermediate form of libxl_domain_conf object as needed. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- tests/libxlxml2domconfigtest.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/tests/libxlxml2domconfigtest.c b/tests/libxlxml2domconfigtest.c index c4d5db9a7b..d58be1211b 100644 --- a/tests/libxlxml2domconfigtest.c +++ b/tests/libxlxml2domconfigtest.c @@ -97,6 +97,20 @@ testCompareXMLToDomConfig(const char *xmlfile, "Failed to create libxl_domain_config from JSON doc"); goto cleanup; } + + /* + * In order to have common test files between Xen 4.9 and newer Xen versions, + * tweak the expected libxl_domain_config object before getting a json + * representation. + */ +# ifndef LIBXL_HAVE_BUILDINFO_APIC + if (expectconfig.c_info.type == LIBXL_DOMAIN_TYPE_HVM) { + libxl_defbool_unset(&expectconfig.b_info.acpi); + libxl_defbool_set(&expectconfig.b_info.u.hvm.apic, true); + libxl_defbool_set(&expectconfig.b_info.u.hvm.acpi, true); + } +# endif + if (!(expectjson = libxl_domain_config_to_json(cfg->ctx, &expectconfig))) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", "Failed to retrieve JSON doc for libxl_domain_config"); -- 2.28.0

2 1

[libvirt PATCH v2] qemu: substitute missing model name for host-passthrough
by Tim Wiederhake 24 Sep '20

24 Sep '20

From: Collin Walling <walling(a)linux.ibm.com> Before: $ uname -m s390x $ cat passthrough-cpu.xml <cpu check="none" mode="host-passthrough" /> $ virsh hypervisor-cpu-compare passthrough-cpu.xml error: Failed to compare hypervisor CPU with passthrough-cpu.xml error: internal error: unable to execute QEMU command 'query-cpu-model-comp arison': Invalid parameter type for 'modelb.name', expected: string After: $ virsh hypervisor-cpu-compare passthrough-cpu.xml CPU described in passthrough-cpu.xml is identical to the CPU provided by hy pervisor on the host Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com> --- src/qemu/qemu_driver.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index ae715c01d7..1cecef01f7 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -12336,6 +12336,15 @@ qemuConnectCompareHypervisorCPU(virConnectPtr conn, if (virCPUDefParseXMLString(xmlCPU, VIR_CPU_TYPE_AUTO, &cpu) < 0) goto cleanup; + if (!cpu->model) { + if (cpu->mode == VIR_CPU_MODE_HOST_PASSTHROUGH) { + cpu->model = g_strdup("host"); + } else { + virReportError(VIR_ERR_INVALID_ARG, "%s", + _("cpu parameter is missing a model name")); + goto cleanup; + } + } ret = qemuConnectCPUModelComparison(qemuCaps, cfg->libDir, cfg->user, cfg->group, hvCPU, cpu, failIncompatible); -- 2.26.2

3 6

[PATCH] apparmor: Allow /usr/libexec for libxl-save-helper and pygrub
by Jim Fehlig 24 Sep '20

24 Sep '20

Like other distros, openSUSE Tumbleweed recently changed libexecdir from /usr/lib to /usr/libexec. Add it as an allowed path for libxl-save-helper and pygrub. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- I considered including /usr/lib64, but I don't think any distros are installing xen libexecdir targets to /usr/lib64. Happy to include it if I'm wrong :-). src/security/apparmor/usr.sbin.libvirtd.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/security/apparmor/usr.sbin.libvirtd.in b/src/security/apparmor/usr.sbin.libvirtd.in index f2030764cd..bf4563e1e8 100644 --- a/src/security/apparmor/usr.sbin.libvirtd.in +++ b/src/security/apparmor/usr.sbin.libvirtd.in @@ -86,8 +86,8 @@ profile libvirtd @sbindir@/libvirtd flags=(attach_disconnected) { /{usr/,}lib/udev/scsi_id PUx, /usr/{lib,lib64}/xen-common/bin/xen-toolstack PUx, /usr/{lib,lib64}/xen/bin/* Ux, - /usr/lib/xen-*/bin/libxl-save-helper PUx, - /usr/lib/xen-*/bin/pygrub PUx, + /usr/{lib,libexec}/xen-*/bin/libxl-save-helper PUx, + /usr/{lib,libexec}/xen-*/bin/pygrub PUx, /usr/{lib,lib64,lib/qemu,libexec}/vhost-user-gpu PUx, /usr/{lib,lib64,lib/qemu,libexec}/virtiofsd PUx, -- 2.28.0

3 6

[PATCH] RFC: fix error message in virMigrate3 if connection is broken
by Nikolay Shirokovskiy 24 Sep '20

24 Sep '20

Currently virDomainMigrate3 reports "this function is not supported by the connection driver: virDomainMigrate3" if connection to destination for example is broken. This is a bit misleading. This is a result of we treat errors as unsupported feature in VIR_DRV_SUPPORTS_FEATURE macro. So let's handle errors instead. In order to keep logic clean as before there are new helper functions virDrvSupportsFeature/virDrvNSupportsFeature. They allow to keep if/else if structure of feature tests. I guess all the other occurences of VIR_DRV_SUPPORTS_FEATURE need to be replaced with one these new helper functions so that we detect error early and not have issues similar to virDomainMigrate3. I'm going to fix the other places if this RFC is approved. --- src/datatypes.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++ src/datatypes.h | 7 +++++ src/libvirt-domain.c | 76 +++++++++++++++++++++++++++++++--------------------- 3 files changed, 123 insertions(+), 30 deletions(-) diff --git a/src/datatypes.c b/src/datatypes.c index 1db38c5..3fb71f4 100644 --- a/src/datatypes.c +++ b/src/datatypes.c @@ -1257,3 +1257,73 @@ virAdmClientDispose(void *obj) virObjectUnref(clt->srv); } + + +/* + * Tests if feature is supported by connection. If testing failed + * due to error then function returns true as well and set @err flag + * to true. Thus positive result should be checked for an error. + * If @err is already set to true then no checking is done and + * the function returns true immediately so that previous error + * is not overwritten. + * + * Returns: + * true feature is supported or testing hit error + * false feature is not supported + */ +bool +virDrvSupportsFeature(virConnectPtr conn, + virDrvFeature feature, + bool *err) +{ + int rc; + + if (*err) + return true; + + if (!conn->driver->connectSupportsFeature) + return false; + + if ((rc = conn->driver->connectSupportsFeature(conn, feature)) < 0) { + *err = true; + return true; + } + + return rc > 0 ? true : false; +} + + +/* + * Tests if feature is NOT supported by connection. If testing failed + * due to error then function returns true as well and set @err flag + * to true. Thus positive result should be checked for an error. + * If @err is already set to true then no checking is done and + * the function returns true immediately so that previous error + * is not overwritten. + * + * Note that this function is not merge negation of virDrvSupportsFeature. + * + * Returns: + * true feature is not supported or testing hit error + * false feature is supported + */ +bool +virDrvNSupportsFeature(virConnectPtr conn, + virDrvFeature feature, + bool *err) +{ + int rc; + + if (*err) + return true; + + if (!conn->driver->connectSupportsFeature) + return true; + + if ((rc = conn->driver->connectSupportsFeature(conn, feature)) < 0) { + *err = true; + return true; + } + + return rc > 0 ? false : true; +} diff --git a/src/datatypes.h b/src/datatypes.h index ade3779..e468d92 100644 --- a/src/datatypes.h +++ b/src/datatypes.h @@ -871,3 +871,10 @@ int virAdmConnectCloseCallbackDataRegister(virAdmConnectCloseCallbackDataPtr cbd virFreeCallback freecb); int virAdmConnectCloseCallbackDataUnregister(virAdmConnectCloseCallbackDataPtr cbdata, virAdmConnectCloseFunc cb); + +bool virDrvSupportsFeature(virConnectPtr conn, + virDrvFeature feature, + bool *err); +bool virDrvNSupportsFeature(virConnectPtr conn, + virDrvFeature feature, + bool *err); diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index cde86c7..f4f626a 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -3846,6 +3846,7 @@ virDomainMigrate3(virDomainPtr domain, const char *dname = NULL; const char *dxml = NULL; unsigned long long bandwidth = 0; + bool err = false; VIR_DOMAIN_DEBUG(domain, "dconn=%p, params=%p, nparms=%u flags=0x%x", dconn, params, nparams, flags); @@ -3878,18 +3879,20 @@ virDomainMigrate3(virDomainPtr domain, } if (flags & VIR_MIGRATE_OFFLINE) { - if (!VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, - VIR_DRV_FEATURE_MIGRATION_OFFLINE)) { - virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", - _("offline migration is not supported by " - "the source host")); + if (virDrvNSupportsFeature(domain->conn, + VIR_DRV_FEATURE_MIGRATION_OFFLINE, &err)) { + if (!err) + virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", + _("offline migration is not supported by " + "the source host")); goto error; } - if (!VIR_DRV_SUPPORTS_FEATURE(dconn->driver, dconn, - VIR_DRV_FEATURE_MIGRATION_OFFLINE)) { - virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", - _("offline migration is not supported by " - "the destination host")); + if (virDrvNSupportsFeature(dconn, + VIR_DRV_FEATURE_MIGRATION_OFFLINE, &err)) { + if (!err) + virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", + _("offline migration is not supported by " + "the destination host")); goto error; } } @@ -3900,20 +3903,25 @@ virDomainMigrate3(virDomainPtr domain, * migration from newer source to an older destination that * rejects the flag. */ if (flags & VIR_MIGRATE_CHANGE_PROTECTION && - !VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, - VIR_DRV_FEATURE_MIGRATE_CHANGE_PROTECTION)) { - virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", - _("cannot enforce change protection")); + virDrvNSupportsFeature(domain->conn, + VIR_DRV_FEATURE_MIGRATE_CHANGE_PROTECTION, + &err)) { + if (!err) + virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", + _("cannot enforce change protection")); goto error; } flags &= ~VIR_MIGRATE_CHANGE_PROTECTION; /* Prefer extensible API but fall back to older migration APIs if params * only contains parameters which were supported by the older API. */ - if (VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, - VIR_DRV_FEATURE_MIGRATION_PARAMS) && - VIR_DRV_SUPPORTS_FEATURE(dconn->driver, dconn, - VIR_DRV_FEATURE_MIGRATION_PARAMS)) { + if (virDrvSupportsFeature(domain->conn, + VIR_DRV_FEATURE_MIGRATION_PARAMS, &err) && + virDrvSupportsFeature(dconn, + VIR_DRV_FEATURE_MIGRATION_PARAMS, &err)) { + if (err) + goto error; + VIR_DEBUG("Using migration protocol 3 with extensible parameters"); ddomain = virDomainMigrateVersion3Params(domain, dconn, params, nparams, flags); @@ -3939,17 +3947,22 @@ virDomainMigrate3(virDomainPtr domain, goto error; } - if (VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, - VIR_DRV_FEATURE_MIGRATION_V3) && - VIR_DRV_SUPPORTS_FEATURE(dconn->driver, dconn, - VIR_DRV_FEATURE_MIGRATION_V3)) { + if (virDrvSupportsFeature(domain->conn, + VIR_DRV_FEATURE_MIGRATION_V3, &err) && + virDrvSupportsFeature(dconn, VIR_DRV_FEATURE_MIGRATION_V3, &err)) { + if (err) + goto error; + VIR_DEBUG("Using migration protocol 3"); ddomain = virDomainMigrateVersion3(domain, dconn, dxml, flags, dname, uri, bandwidth); - } else if (VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, - VIR_DRV_FEATURE_MIGRATION_V2) && - VIR_DRV_SUPPORTS_FEATURE(dconn->driver, dconn, - VIR_DRV_FEATURE_MIGRATION_V2)) { + } else if (virDrvSupportsFeature(domain->conn, + VIR_DRV_FEATURE_MIGRATION_V2, &err) && + virDrvSupportsFeature(dconn, + VIR_DRV_FEATURE_MIGRATION_V2, &err)) { + if (err) + goto error; + VIR_DEBUG("Using migration protocol 2"); if (dxml) { virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", @@ -3959,10 +3972,13 @@ virDomainMigrate3(virDomainPtr domain, } ddomain = virDomainMigrateVersion2(domain, dconn, flags, dname, uri, bandwidth); - } else if (VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, - VIR_DRV_FEATURE_MIGRATION_V1) && - VIR_DRV_SUPPORTS_FEATURE(dconn->driver, dconn, - VIR_DRV_FEATURE_MIGRATION_V1)) { + } else if (virDrvSupportsFeature(domain->conn, + VIR_DRV_FEATURE_MIGRATION_V1, &err) && + virDrvSupportsFeature(dconn, + VIR_DRV_FEATURE_MIGRATION_V1, &err)) { + if (err) + goto error; + VIR_DEBUG("Using migration protocol 1"); if (dxml) { virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", -- 1.8.3.1

2 2

[PATCH] libxl: use b_info->{acpi,acpi} when available
by Marek Marczykowski-Górecki 24 Sep '20

24 Sep '20

b_info->u.hvm.{acpi,apic} are deprecated. But also, on recent libxl version (4.14) the old one seems to be broken. While libxl part should be fixed too, update the usage here and at some point drop support for the old version. b_info->acpi was added in Xen 4.8 b_info->apic was added in Xen 4.10 Xen 4.10 is the oldest version that still has security support (until December 2020). Signed-off-by: Marek Marczykowski-Górecki <marmarek(a)invisiblethingslab.com> --- src/libxl/libxl_conf.c | 13 +++++++++++++ tests/libxlxml2domconfigdata/basic-hvm.json | 4 ++-- tests/libxlxml2domconfigdata/cpu-shares-hvm.json | 4 ++-- .../libxlxml2domconfigdata/fullvirt-acpi-slic.json | 4 ++-- .../fullvirt-cpuid-legacy-nest.json | 4 ++-- tests/libxlxml2domconfigdata/fullvirt-cpuid.json | 4 ++-- .../max-eventchannels-hvm.json | 4 ++-- tests/libxlxml2domconfigdata/max-gntframes-hvm.json | 4 ++-- tests/libxlxml2domconfigdata/moredevs-hvm.json | 4 ++-- .../libxlxml2domconfigdata/variable-clock-hvm.json | 4 ++-- .../vnuma-hvm-legacy-nest.json | 4 ++-- tests/libxlxml2domconfigdata/vnuma-hvm.json | 4 ++-- 12 files changed, 35 insertions(+), 22 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index befd5eb965..5b729a019a 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -508,12 +508,25 @@ libxlMakeDomBuildInfo(virDomainDefPtr def, libxl_defbool_set(&b_info->u.hvm.pae, def->features[VIR_DOMAIN_FEATURE_PAE] == VIR_TRISTATE_SWITCH_ON); +#ifdef LIBXL_HAVE_BUILDINFO_APIC + libxl_defbool_set(&b_info->apic, + def->features[VIR_DOMAIN_FEATURE_APIC] == + VIR_TRISTATE_SWITCH_ON); + /* + * Strictly speaking b_info->acpi was introduced earlier (Xen 4.8), but + * there is no separate #define in libxl.h. + */ + libxl_defbool_set(&b_info->acpi, + def->features[VIR_DOMAIN_FEATURE_ACPI] == + VIR_TRISTATE_SWITCH_ON); +#else libxl_defbool_set(&b_info->u.hvm.apic, def->features[VIR_DOMAIN_FEATURE_APIC] == VIR_TRISTATE_SWITCH_ON); libxl_defbool_set(&b_info->u.hvm.acpi, def->features[VIR_DOMAIN_FEATURE_ACPI] == VIR_TRISTATE_SWITCH_ON); +#endif /* copy SLIC table path to acpi_firmware */ if (def->os.slic_table) diff --git a/tests/libxlxml2domconfigdata/basic-hvm.json b/tests/libxlxml2domconfigdata/basic-hvm.json index ccd5853854..87f8cb7d8a 100644 --- a/tests/libxlxml2domconfigdata/basic-hvm.json +++ b/tests/libxlxml2domconfigdata/basic-hvm.json @@ -21,10 +21,10 @@ "sched_params": { }, + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "vga": { "kind": "cirrus" }, diff --git a/tests/libxlxml2domconfigdata/cpu-shares-hvm.json b/tests/libxlxml2domconfigdata/cpu-shares-hvm.json index 2e647eada2..2aa97e88c5 100644 --- a/tests/libxlxml2domconfigdata/cpu-shares-hvm.json +++ b/tests/libxlxml2domconfigdata/cpu-shares-hvm.json @@ -21,10 +21,10 @@ "sched_params": { "weight": 1500 }, + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "vga": { "kind": "cirrus" }, diff --git a/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json b/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json index f16b4a971a..a2d46797aa 100644 --- a/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json +++ b/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json @@ -14,10 +14,10 @@ "shadow_memkb": 5656, "sched_params": { }, + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "acpi_firmware": "/path/to/slic.dat", "nographic": "True", "vga": { diff --git a/tests/libxlxml2domconfigdata/fullvirt-cpuid-legacy-nest.json b/tests/libxlxml2domconfigdata/fullvirt-cpuid-legacy-nest.json index 0944476151..6290655c20 100644 --- a/tests/libxlxml2domconfigdata/fullvirt-cpuid-legacy-nest.json +++ b/tests/libxlxml2domconfigdata/fullvirt-cpuid-legacy-nest.json @@ -21,10 +21,10 @@ ], "sched_params": { }, + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "nested_hvm": "False", "nographic": "True", "vga": { diff --git a/tests/libxlxml2domconfigdata/fullvirt-cpuid.json b/tests/libxlxml2domconfigdata/fullvirt-cpuid.json index ddc423bca7..811a4f0ac7 100644 --- a/tests/libxlxml2domconfigdata/fullvirt-cpuid.json +++ b/tests/libxlxml2domconfigdata/fullvirt-cpuid.json @@ -22,10 +22,10 @@ "sched_params": { }, "nested_hvm": "False", + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "nographic": "True", "vga": { "kind": "none" diff --git a/tests/libxlxml2domconfigdata/max-eventchannels-hvm.json b/tests/libxlxml2domconfigdata/max-eventchannels-hvm.json index d5b351beb5..4a5b0ca65f 100644 --- a/tests/libxlxml2domconfigdata/max-eventchannels-hvm.json +++ b/tests/libxlxml2domconfigdata/max-eventchannels-hvm.json @@ -22,10 +22,10 @@ "sched_params": { }, + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "vga": { "kind": "cirrus" }, diff --git a/tests/libxlxml2domconfigdata/max-gntframes-hvm.json b/tests/libxlxml2domconfigdata/max-gntframes-hvm.json index ef602f09fc..2883d057ff 100644 --- a/tests/libxlxml2domconfigdata/max-gntframes-hvm.json +++ b/tests/libxlxml2domconfigdata/max-gntframes-hvm.json @@ -22,10 +22,10 @@ "sched_params": { }, + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "vga": { "kind": "cirrus" }, diff --git a/tests/libxlxml2domconfigdata/moredevs-hvm.json b/tests/libxlxml2domconfigdata/moredevs-hvm.json index 474aa2cef6..58cf32a8d4 100644 --- a/tests/libxlxml2domconfigdata/moredevs-hvm.json +++ b/tests/libxlxml2domconfigdata/moredevs-hvm.json @@ -23,10 +23,10 @@ "sched_params": { }, + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "hpet": "True", "vga": { "kind": "cirrus" diff --git a/tests/libxlxml2domconfigdata/variable-clock-hvm.json b/tests/libxlxml2domconfigdata/variable-clock-hvm.json index 69be9c64cb..9a25d51da2 100644 --- a/tests/libxlxml2domconfigdata/variable-clock-hvm.json +++ b/tests/libxlxml2domconfigdata/variable-clock-hvm.json @@ -23,10 +23,10 @@ "sched_params": { }, + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "vga": { "kind": "cirrus" }, diff --git a/tests/libxlxml2domconfigdata/vnuma-hvm-legacy-nest.json b/tests/libxlxml2domconfigdata/vnuma-hvm-legacy-nest.json index 3b2fc5f40f..6cda8d0252 100644 --- a/tests/libxlxml2domconfigdata/vnuma-hvm-legacy-nest.json +++ b/tests/libxlxml2domconfigdata/vnuma-hvm-legacy-nest.json @@ -109,10 +109,10 @@ "sched_params": { }, + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "nested_hvm": "True", "vga": { "kind": "cirrus" diff --git a/tests/libxlxml2domconfigdata/vnuma-hvm.json b/tests/libxlxml2domconfigdata/vnuma-hvm.json index 02c10a9deb..f578ccd3d3 100644 --- a/tests/libxlxml2domconfigdata/vnuma-hvm.json +++ b/tests/libxlxml2domconfigdata/vnuma-hvm.json @@ -110,10 +110,10 @@ }, "nested_hvm": "True", + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "vga": { "kind": "cirrus" }, -- 2.25.4

5 10

Help on meson build
by Wei Wang 24 Sep '20

24 Sep '20

Hi folks, I'm trying to build libvirt using meson with the latest upstream libvirt, but the compilation fails: (followed on https://libvirt.org/compiling.html, not sure if any dependencies are missed) FAILED: src/util/libvirt_util.a.p/glibcompat.c.o .... In file included from ../src/util/glibcompat.c:19: ./config.h:1026:10: fatal error: config-post.h: No such file or directory FAILED: src/util/libvirt_util.a.p/virfirmware.c.o In file included from ../src/util/virarch.c:22: ./config.h:1026:10: fatal error: config-post.h: No such file or directory FAILED: src/util/libvirt_util.a.p/viraudit.c.o In file included from ../src/util/viraudit.c:22: ./config.h:1026:10: fatal error: config-post.h: No such file or directory Any help is appreciated. Thanks, Wei

1 0

[PATCH v2 0/6] qemu: Use memory-backend-* for regular guest memory
by Michal Privoznik 23 Sep '20

23 Sep '20

v2 of: https://www.redhat.com/archives/libvir-list/2020-September/msg00023.html diff to v1: - I've dropped the capability (patch 5/7 in the original set) and am relying on qemu providing default-ram-id. I've tested migration from a daemon with these patches to a daemon without and also vice versa and it worked. Michal Prívozník (6): qemuBuildMemoryBackendProps: Move @prealloc setting to backend agnostic part qemuBuildMemoryBackendProps: Respect //memoryBacking/allocation/@mode=immediate qemuBuildMemoryBackendProps: Prealloc mem for memfd backend qemuBuildMemoryBackendProps: Fix const correctness qemu: Track default-ram-id machine attribute qemu: Use memory-backend-* for regular guest memory src/qemu/qemu_capabilities.c | 35 +++- src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_capspriv.h | 3 +- src/qemu/qemu_command.c | 96 +++++++-- src/qemu/qemu_command.h | 4 +- src/qemu/qemu_monitor.c | 1 + src/qemu/qemu_monitor.h | 1 + src/qemu/qemu_monitor_json.c | 11 + .../caps_5.2.0.x86_64.xml | 196 +++++++++--------- .../blkdeviotune-group-num.x86_64-latest.args | 3 +- ...blkdeviotune-max-length.x86_64-latest.args | 3 +- .../blkdeviotune-max.x86_64-latest.args | 3 +- .../channel-unix-guestfwd.x86_64-latest.args | 3 +- .../console-virtio-unix.x86_64-latest.args | 3 +- .../controller-virtio-scsi.x86_64-latest.args | 3 +- ...-Icelake-Server-pconfig.x86_64-latest.args | 3 +- .../cpu-translation.x86_64-latest.args | 3 +- .../cputune-cpuset-big-id.x86_64-latest.args | 3 +- .../disk-aio-io_uring.x86_64-latest.args | 3 +- .../disk-aio.x86_64-latest.args | 3 +- ...-backing-chains-noindex.x86_64-latest.args | 3 +- .../disk-cache.x86_64-latest.args | 4 +- .../disk-cdrom-bus-other.x86_64-latest.args | 3 +- ...m-empty-network-invalid.x86_64-latest.args | 3 +- .../disk-cdrom-network.x86_64-latest.args | 3 +- .../disk-cdrom-tray.x86_64-latest.args | 3 +- .../disk-cdrom.x86_64-latest.args | 3 +- .../disk-copy_on_read.x86_64-latest.args | 3 +- .../disk-detect-zeroes.x86_64-latest.args | 3 +- .../disk-discard.x86_64-latest.args | 3 +- .../disk-error-policy.x86_64-latest.args | 3 +- .../disk-floppy-q35-2_11.x86_64-latest.args | 4 +- .../disk-floppy-q35-2_9.x86_64-latest.args | 4 +- .../disk-floppy.x86_64-latest.args | 3 +- .../disk-network-gluster.x86_64-latest.args | 3 +- .../disk-network-http.x86_64-latest.args | 3 +- .../disk-network-iscsi.x86_64-latest.args | 3 +- .../disk-network-nbd.x86_64-latest.args | 3 +- .../disk-network-rbd.x86_64-latest.args | 3 +- .../disk-network-sheepdog.x86_64-latest.args | 3 +- ...isk-network-source-auth.x86_64-latest.args | 3 +- ...isk-network-tlsx509-nbd.x86_64-latest.args | 3 +- .../disk-nvme.x86_64-latest.args | 3 +- .../disk-readonly-disk.x86_64-latest.args | 3 +- .../disk-scsi-device-auto.x86_64-latest.args | 3 +- .../disk-scsi.x86_64-latest.args | 3 +- .../disk-shared.x86_64-latest.args | 3 +- .../disk-slices.x86_64-latest.args | 3 +- ...irtio-scsi-reservations.x86_64-latest.args | 3 +- .../eoi-disabled.x86_64-latest.args | 3 +- .../eoi-enabled.x86_64-latest.args | 3 +- .../floppy-drive-fat.x86_64-latest.args | 3 +- .../qemuxml2argvdata/fs9p.x86_64-latest.args | 3 +- .../genid-auto.x86_64-latest.args | 3 +- .../qemuxml2argvdata/genid.x86_64-latest.args | 3 +- ...egl-headless-rendernode.x86_64-latest.args | 3 +- .../graphics-egl-headless.x86_64-latest.args | 3 +- ...pice-gl-auto-rendernode.x86_64-latest.args | 3 +- ...graphics-vnc-tls-secret.x86_64-latest.args | 3 +- .../graphics-vnc-tls.x86_64-latest.args | 3 +- ...tdev-mdev-display-ramfb.x86_64-latest.args | 3 +- ...play-spice-egl-headless.x86_64-latest.args | 3 +- ...ev-display-spice-opengl.x86_64-latest.args | 3 +- ...isplay-vnc-egl-headless.x86_64-latest.args | 3 +- ...ostdev-mdev-display-vnc.x86_64-latest.args | 3 +- .../hostdev-scsi-lsi.x86_64-latest.args | 3 +- ...ostdev-scsi-virtio-scsi.x86_64-latest.args | 3 +- .../qemuxml2argvdata/hugepages-memaccess.args | 30 +-- .../hugepages-memaccess2.args | 12 +- .../hugepages-numa-nodeset-part.args | 5 +- .../hugepages-numa-nodeset.args | 20 +- .../hugepages-nvdimm.x86_64-latest.args | 15 +- tests/qemuxml2argvdata/hugepages-shared.args | 24 +-- .../hyperv-off.x86_64-latest.args | 3 +- .../hyperv-panic.x86_64-latest.args | 3 +- .../hyperv-stimer-direct.x86_64-latest.args | 3 +- .../hyperv.x86_64-latest.args | 3 +- .../intel-iommu-aw-bits.x86_64-latest.args | 4 +- ...ntel-iommu-caching-mode.x86_64-latest.args | 4 +- ...ntel-iommu-device-iotlb.x86_64-latest.args | 4 +- .../intel-iommu-eim.x86_64-latest.args | 4 +- .../intel-iommu.x86_64-latest.args | 3 +- ...threads-virtio-scsi-pci.x86_64-latest.args | 3 +- .../kvmclock+eoi-disabled.x86_64-latest.args | 3 +- ...luks-disks-source-qcow2.x86_64-latest.args | 4 +- ...memory-default-hugepage.x86_64-latest.args | 8 +- .../memfd-memory-numa.x86_64-latest.args | 8 +- .../memory-hotplug-dimm-addr.args | 6 +- .../qemuxml2argvdata/memory-hotplug-dimm.args | 6 +- ...y-hotplug-nvdimm-access.x86_64-latest.args | 8 +- ...ry-hotplug-nvdimm-align.x86_64-latest.args | 8 +- ...ry-hotplug-nvdimm-label.x86_64-latest.args | 8 +- ...ory-hotplug-nvdimm-pmem.x86_64-latest.args | 8 +- ...ory-hotplug-nvdimm-ppc64.ppc64-latest.args | 2 +- ...hotplug-nvdimm-readonly.x86_64-latest.args | 8 +- .../memory-hotplug-nvdimm.x86_64-latest.args | 6 +- .../mlock-off.x86_64-latest.args | 3 +- .../mlock-on.x86_64-latest.args | 3 +- .../net-vhostuser.x86_64-latest.args | 3 +- .../numatune-hmat.x86_64-latest.args | 4 +- .../os-firmware-bios.x86_64-latest.args | 4 +- ...os-firmware-efi-secboot.x86_64-latest.args | 4 +- .../os-firmware-efi.x86_64-latest.args | 4 +- .../qemuxml2argvdata/pages-dimm-discard.args | 4 +- .../parallel-unix-chardev.x86_64-latest.args | 3 +- ...cie-root-port-nohotplug.x86_64-latest.args | 3 +- .../pv-spinlock-disabled.x86_64-latest.args | 3 +- .../pv-spinlock-enabled.x86_64-latest.args | 3 +- .../qemu-ns.x86_64-latest.args | 3 +- .../serial-unix-chardev.x86_64-latest.args | 3 +- ...rtcard-passthrough-unix.x86_64-latest.args | 3 +- .../tpm-emulator-tpm2-enc.x86_64-latest.args | 4 +- .../tpm-emulator-tpm2.x86_64-latest.args | 4 +- .../tpm-emulator.x86_64-latest.args | 4 +- .../tpm-passthrough-crb.x86_64-latest.args | 4 +- .../tpm-passthrough.x86_64-latest.args | 4 +- .../tseg-explicit-size.x86_64-latest.args | 4 +- .../usb-redir-unix.x86_64-latest.args | 3 +- tests/qemuxml2argvdata/user-aliases.args | 16 +- ...vhost-user-fs-fd-memory.x86_64-latest.args | 4 +- ...vhost-user-fs-hugepages.x86_64-latest.args | 10 +- ...host-user-gpu-secondary.x86_64-latest.args | 3 +- .../vhost-user-vga.x86_64-latest.args | 3 +- .../vhost-vsock-auto.x86_64-latest.args | 4 +- .../vhost-vsock.x86_64-latest.args | 3 +- ...eo-bochs-display-device.x86_64-latest.args | 3 +- ...video-qxl-device-vram64.x86_64-latest.args | 3 +- ...o-qxl-sec-device-vram64.x86_64-latest.args | 3 +- ...eo-ramfb-display-device.x86_64-latest.args | 3 +- .../virtio-9p-multidevs.x86_64-latest.args | 3 +- ...virtio-non-transitional.x86_64-latest.args | 3 +- ...-options-controller-ats.x86_64-latest.args | 3 +- ...ptions-controller-iommu.x86_64-latest.args | 3 +- ...tions-controller-packed.x86_64-latest.args | 3 +- ...virtio-options-disk-ats.x86_64-latest.args | 3 +- ...rtio-options-disk-iommu.x86_64-latest.args | 3 +- ...tio-options-disk-packed.x86_64-latest.args | 3 +- .../virtio-options-fs-ats.x86_64-latest.args | 3 +- ...virtio-options-fs-iommu.x86_64-latest.args | 3 +- ...irtio-options-fs-packed.x86_64-latest.args | 3 +- ...irtio-options-input-ats.x86_64-latest.args | 3 +- ...tio-options-input-iommu.x86_64-latest.args | 3 +- ...io-options-input-packed.x86_64-latest.args | 3 +- ...-options-memballoon-ats.x86_64-latest.args | 3 +- ...ptions-memballoon-iommu.x86_64-latest.args | 3 +- ...tions-memballoon-packed.x86_64-latest.args | 3 +- .../virtio-options-net-ats.x86_64-latest.args | 3 +- ...irtio-options-net-iommu.x86_64-latest.args | 3 +- ...rtio-options-net-packed.x86_64-latest.args | 3 +- .../virtio-options-rng-ats.x86_64-latest.args | 3 +- ...irtio-options-rng-iommu.x86_64-latest.args | 3 +- ...rtio-options-rng-packed.x86_64-latest.args | 3 +- ...irtio-options-video-ats.x86_64-latest.args | 3 +- ...tio-options-video-iommu.x86_64-latest.args | 3 +- ...io-options-video-packed.x86_64-latest.args | 3 +- .../virtio-options.x86_64-latest.args | 3 +- .../virtio-rng-builtin.x86_64-latest.args | 3 +- .../virtio-rng-egd-unix.x86_64-latest.args | 3 +- .../virtio-transitional.x86_64-latest.args | 3 +- ...-default-cpu-kvm-pc-4.2.x86_64-latest.args | 4 +- ...default-cpu-kvm-q35-4.2.x86_64-latest.args | 4 +- ...-default-cpu-tcg-pc-4.2.x86_64-latest.args | 4 +- ...default-cpu-tcg-q35-4.2.x86_64-latest.args | 4 +- .../x86_64-pc-graphics.x86_64-latest.args | 3 +- .../x86_64-pc-headless.x86_64-latest.args | 3 +- .../x86_64-q35-graphics.x86_64-latest.args | 3 +- .../x86_64-q35-headless.x86_64-latest.args | 3 +- tests/testutilsqemu.c | 24 ++- 168 files changed, 667 insertions(+), 357 deletions(-) -- 2.26.2

2 7

[PATCH v1] qemu: monitor: substitute missing model name for host-passthrough
by Collin Walling 23 Sep '20

23 Sep '20

When executing the hypervisor-cpu-compare/baseline commands and the XML file contains a CPU definition using host-passthrough and no model name, the commands will fail and return an error message from the QMP response. Let's fix this by checking for host-passthrough and a missing model name when converting a CPU definition to a JSON object. If these conditions are matched, then the JSON object will be constructed using "host" as the model name. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1850680 Signed-off-by: Collin Walling <walling(a)linux.ibm.com> --- src/qemu/qemu_monitor_json.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 3070c1e6b3..448a3a9356 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -5804,9 +5804,20 @@ qemuMonitorJSONMakeCPUModel(virCPUDefPtr cpu, { virJSONValuePtr model = virJSONValueNewObject(); virJSONValuePtr props = NULL; + const char *model_name = cpu->model; size_t i; - if (virJSONValueObjectAppendString(model, "name", cpu->model) < 0) + if (!model_name) { + if (cpu->mode == VIR_CPU_MODE_HOST_PASSTHROUGH) { + model_name = "host"; + } else { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("cpu parameter is missing a model name")); + goto error; + } + } + + if (virJSONValueObjectAppendString(model, "name", model_name) < 0) goto error; if (cpu->nfeatures || !migratable) { -- 2.26.2

4 8

[PATCH] xen: Don't add dom0 twice on driver reload
by Jim Fehlig 23 Sep '20

23 Sep '20

When the xen driver loads, it probes libxl for some info about dom0 and adds it to the virDomainObjList. The driver then looks for any domains in stateDir and if they are still alive adds them to the list as well. This logic is a bit flawed wrt handling driver reload and causes the following error internal error: unexpected domain Domain-0 already exists A simple fix is to load all domains from stateDir first and then only add dom0 if needed. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- src/libxl/libxl_driver.c | 46 +++++++++++++++++++++++----------------- 1 file changed, 26 insertions(+), 20 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 161a6882f3..083738871d 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -604,27 +604,33 @@ libxlAddDom0(libxlDriverPrivatePtr driver) goto cleanup; } - if (!(def = virDomainDefNew())) - goto cleanup; + /* + * On a driver reload dom0 will already exist. On host restart it must + * created. + */ + if ((vm = virDomainObjListFindByID(driver->domains, 0)) == NULL) { + if (!(def = virDomainDefNew())) + goto cleanup; - def->id = 0; - def->virtType = VIR_DOMAIN_VIRT_XEN; - def->name = g_strdup("Domain-0"); + def->id = 0; + def->virtType = VIR_DOMAIN_VIRT_XEN; + def->name = g_strdup("Domain-0"); - def->os.type = VIR_DOMAIN_OSTYPE_XEN; + def->os.type = VIR_DOMAIN_OSTYPE_XEN; - if (virUUIDParse("00000000-0000-0000-0000-000000000000", def->uuid) < 0) - goto cleanup; + if (virUUIDParse("00000000-0000-0000-0000-000000000000", def->uuid) < 0) + goto cleanup; - if (!(vm = virDomainObjListAdd(driver->domains, def, - driver->xmlopt, - 0, - NULL))) - goto cleanup; - def = NULL; + if (!(vm = virDomainObjListAdd(driver->domains, def, + driver->xmlopt, + 0, + NULL))) + goto cleanup; + + vm->persistent = 1; + virDomainObjSetState(vm, VIR_DOMAIN_RUNNING, VIR_DOMAIN_RUNNING_BOOTED); + } - vm->persistent = 1; - virDomainObjSetState(vm, VIR_DOMAIN_RUNNING, VIR_DOMAIN_RUNNING_BOOTED); if (virDomainDefSetVcpusMax(vm->def, d_info.vcpu_max_id + 1, driver->xmlopt)) goto cleanup; @@ -783,10 +789,6 @@ libxlStateInitialize(bool privileged, if (!(libxl_driver->xmlopt = libxlCreateXMLConf(libxl_driver))) goto error; - /* Add Domain-0 */ - if (libxlAddDom0(libxl_driver) < 0) - goto error; - /* Load running domains first. */ if (virDomainObjListLoadAllConfigs(libxl_driver->domains, cfg->stateDir, @@ -796,6 +798,10 @@ libxlStateInitialize(bool privileged, NULL, NULL) < 0) goto error; + /* Add Domain-0 */ + if (libxlAddDom0(libxl_driver) < 0) + goto error; + libxlReconnectDomains(libxl_driver); /* Then inactive persistent configs */ -- 2.28.0

2 1

[PATCH 00/13] virStorageSourceNew failure handling and virDomainSnapshotAlignDisks refactors
by Peter Krempa 23 Sep '20

23 Sep '20

A set of patches that prevent failures from virStorageSourceNew and refactor virDomainSnapshotAlignDisks for better readability. Peter Krempa (13): virStorageSourceNew: Abort on failure virStorageVolDefParseXML: Use g_steal_pointer qemuDomainBlockRebase: Replace ternary operator with if/else qemuSnapshotCreateInactiveExternal: Don't access 'idx' of snapshot virDomainSnapshotAlignDisks: Refactor cleanup virDomainSnapshotAlignDisks: Rename 'def' -> 'snapdef' virDomainSnapshotAlignDisks: Rename 'disk' -> 'snapdisk' virDomainSnapshotAlignDisks: Add 'domdef' local variable virDomainSnapshotAlignDisks: Extract domain disk definition to a local variable virDomainSnapshotAlignDisks: remove unnecessary 'tmp' variable virDomainSnapshotAlignDisks: clarify handing of snapshot location virDomainSnapshotAlignDisks: refactor extension to all disks virDomainSnapshotDiskDef: Remove 'idx' field src/conf/backup_conf.c | 7 +- src/conf/domain_conf.c | 21 ++-- src/conf/snapshot_conf.c | 160 +++++++++++--------------- src/conf/snapshot_conf.h | 1 - src/conf/storage_conf.c | 8 +- src/qemu/qemu_domain.c | 21 ++-- src/qemu/qemu_driver.c | 18 ++- src/qemu/qemu_migration.c | 7 +- src/qemu/qemu_snapshot.c | 7 +- src/storage/storage_backend_gluster.c | 5 +- src/storage/storage_backend_logical.c | 4 +- src/storage/storage_util.c | 10 +- src/util/virstoragefile.c | 32 ++---- tests/qemublocktest.c | 16 +-- tests/virstoragetest.c | 5 +- 15 files changed, 121 insertions(+), 201 deletions(-) -- 2.26.2

3 28

[libvirt PATCHv3] tests: build SELinux tests (glib chronicles?)
by Ján Tomko 23 Sep '20

23 Sep '20

We set WITH_LIBATTR in meson.build, not WITH_ATTR. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> Fixes: 3ace72965c3b11fc763f781ae7ce3ca29dd36507 --- tests/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/meson.build b/tests/meson.build index 31e8d66c7a..cb720f3afe 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -477,7 +477,7 @@ if conf.has('WITH_REMOTE') endif if conf.has('WITH_SECDRIVER_SELINUX') - if conf.has('WITH_ATTR') + if conf.has('WITH_LIBATTR') tests += [ { 'name': 'securityselinuxtest' }, { 'name': 'viridentitytest' }, @@ -485,7 +485,7 @@ if conf.has('WITH_SECDRIVER_SELINUX') if conf.has('WITH_QEMU') tests += [ - { 'name': 'securityselinuxlabeltest', 'link_whole': [ test_utils_qemu_lib ] }, + { 'name': 'securityselinuxlabeltest', 'link_with': [ test_qemu_driver_lib ], 'link_whole': [ test_utils_qemu_lib ] }, ] endif endif -- 2.26.2

2 1

[libvirt PATCH] util: do not unref event thread after joining it
by Ján Tomko 23 Sep '20

23 Sep '20

==295055== Invalid read of size 4 ==295055== at 0x4DA4AE4: g_thread_unref (in /usr/lib64/libglib-2.0.so.0.6400.5) ==295055== by 0x491D5FA: vir_event_thread_finalize (vireventthread.c:47) ==295055== by 0x4E6BCFF: g_object_unref (in /usr/lib64/libgobject-2.0.so.0.6400.5) ==295055== by 0x22F35CF4: qemuProcessQMPFree (qemu_process.c:8525) ==295055== by 0x22E71B58: glib_autoptr_clear_qemuProcessQMP (qemu_process.h:237) ... ==295055== by 0x22E98A29: qemuDomainPostParseDataAlloc (qemu_domain.c:5476) ==295055== by 0x49ABF83: virDomainDefPostParse (domain_conf.c:6023) ==295055== Address 0x2acb1c68 is 24 bytes inside a block of size 88 free'd ==295055== at 0x483B9F5: free (vg_replace_malloc.c:538) ==295055== by 0x4D80A4C: g_free (in /usr/lib64/libglib-2.0.so.0.6400.5) ... ==295055== by 0x491D5F1: vir_event_thread_finalize (vireventthread.c:46) ==295055== by 0x4E6BCFF: g_object_unref (in /usr/lib64/libgobject-2.0.so.0.6400.5) ==295055== by 0x22F35CF4: qemuProcessQMPFree (qemu_process.c:8525) ==295055== by 0x22E71B58: glib_autoptr_clear_qemuProcessQMP (qemu_process.h:237) ... ==295055== Block was alloc'd at ==295055== at 0x483A809: malloc (vg_replace_malloc.c:307) ==295055== by 0x4D80958: g_malloc (in /usr/lib64/libglib-2.0.so.0.6400.5) ... ==295055== by 0x4DA4C32: g_thread_try_new (in /usr/lib64/libglib-2.0.so.0.6400.5) ==295055== by 0x491D3BC: virEventThreadStart (vireventthread.c:159) ==295055== by 0x491D3BC: virEventThreadNew (vireventthread.c:185) ... Signed-off-by: Ján Tomko <jtomko(a)redhat.com> Fixes: f4fc3db9204407874181117085756c9ced78adad --- src/util/vireventthread.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/util/vireventthread.c b/src/util/vireventthread.c index 1bca2aa57a..8342f420f6 100644 --- a/src/util/vireventthread.c +++ b/src/util/vireventthread.c @@ -44,7 +44,6 @@ vir_event_thread_finalize(GObject *object) if (evt->thread) { g_main_loop_quit(evt->loop); g_thread_join(evt->thread); - g_thread_unref(evt->thread); } g_main_loop_unref(evt->loop); -- 2.26.2

2 1

[libvirt PATCH] virnetdaemon: fix memory leak in virNetDaemonCallInhibit
by Pavel Hrdina 23 Sep '20

23 Sep '20

g_variant_new() returns a weak reference which can be consumed by passing to other g_variant* functions or to g_dbus_connection_call* functions. This make it possible to call g_variant_new() directly as argument to the functions above. Because this might be confusing I explicitly call g_variant_ref_sink() to make it normal reference in both virGDBusCallMethod() and virGDBusCallMethodWithFD() so the caller is always responsible for the data. Reported-by: Peter Krempa <pkrempa(a)redhat.com> Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/rpc/virnetdaemon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rpc/virnetdaemon.c b/src/rpc/virnetdaemon.c index f3a5e9f75c..2e01244f74 100644 --- a/src/rpc/virnetdaemon.c +++ b/src/rpc/virnetdaemon.c @@ -469,7 +469,7 @@ virNetDaemonCallInhibit(virNetDaemonPtr dmn, { g_autoptr(GVariant) reply = NULL; g_autoptr(GUnixFDList) replyFD = NULL; - GVariant *message = NULL; + g_autoptr(GVariant) message = NULL; GDBusConnection *systemBus; int fd; int rc; -- 2.26.2

3 2

[libvirt PATCH] util/virgdbus: fix memory leak in virGDBusIsServiceInList
by Pavel Hrdina 23 Sep '20

23 Sep '20

g_variant_iter_loop() handles freeing all arguments unless we break out of the loop, in that case we have to free them manually. Reported-by: Peter Krempa <pkrempa(a)redhat.com> Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/util/virgdbus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/util/virgdbus.c b/src/util/virgdbus.c index cd9ca8d5d6..4360a6acff 100644 --- a/src/util/virgdbus.c +++ b/src/util/virgdbus.c @@ -359,8 +359,10 @@ virGDBusIsServiceInList(const char *listMethod, g_variant_get(reply, "(as)", &iter); while (g_variant_iter_loop(iter, "s", &str)) { - if (STREQ(str, name)) + if (STREQ(str, name)) { + g_free(str); return 0; + } } return -2; -- 2.26.2

2 1

[libvirt PATCHv2 0/2] tests: switch to g_new0 (glib chronicles)
by Ján Tomko 23 Sep '20

23 Sep '20

2 4

[PATCH v2 0/2] block: deprecate the sheepdog driver
by Daniel P. Berrangé 23 Sep '20

23 Sep '20

2 years back I proposed dropping the sheepdog mailing list from the MAINTAINERS file, but somehow the patch never got picked up: https://lists.gnu.org/archive/html/qemu-block/2018-03/msg01048.html So here I am with the same patch again. This time I go further and deprecate the sheepdog driver entirely. See the rationale in the second patch commit message. Daniel P. Berrangé (2): block: drop moderated sheepdog mailing list from MAINTAINERS file block: deprecate the sheepdog block driver MAINTAINERS | 1 - block/sheepdog.c | 15 +++++++++++++++ configure | 5 +++-- docs/system/deprecated.rst | 9 +++++++++ 4 files changed, 27 insertions(+), 3 deletions(-) -- 2.26.2

8 14