- Devel - libvirt List Archives

[PATCH 0/4] Add qemu support setting qos via ovs on ovs interface
by zhangjl02 29 Jun '21

29 Jun '21

Now libvirt use tc rules to manage interface's qos. But when a interface is created by ovs, there is no qos setting result in ovs database. Therefore, qos of ovs port should be set via ovs management command. We add a function to tell whether a port definition is an ovs managed virtual port. Change default qdisc rules, which return 0 directly if the port is ovs managed(When the ovs port is set noqueue, qos config on this port will not work). Add ovs management function of setting and cleaning qos. Then check if the port is an ovs managed port during its life cycle, and call the ovs management function to set or clean qos settings. zhangjl02 (4): qemu: interface: add qemuDomainDefIsOvsport qemu: interface: add virNetDevOpenvswitchInterfaceSetQos and virNetDevOpenvswitchInterfaceClearQos qemu: interface: remove setting noqueue for ovs port qemu: interface: check and use ovs command to set qos of ovs managed port src/libvirt_private.syms | 2 + src/qemu/qemu_command.c | 10 +- src/qemu/qemu_domain.c | 15 ++ src/qemu/qemu_domain.h | 3 + src/qemu/qemu_driver.c | 21 ++- src/qemu/qemu_hotplug.c | 39 +++-- src/qemu/qemu_process.c | 11 +- src/util/virnetdevopenvswitch.c | 269 ++++++++++++++++++++++++++++++++ src/util/virnetdevopenvswitch.h | 11 ++ 9 files changed, 365 insertions(+), 16 deletions(-) -- 2.30.2.windows.1

2 8

[PATCH v2 0/3] Implement virDomainGetMessages for test driver
by Luke Yue 29 Jun '21

29 Jun '21

Implement virDomainGetMessages API for test driver. v2: Introduce testDomainObjCheckTaint to test the API. Luke Yue (3): test_driver: Implement virDomainGetMessages test_driver: Introduce testDomainObjCheckTaint tests: Add messages for virshtest src/test/test_driver.c | 110 +++++++++++++++++++++++++++++++++++++++++ tests/virshtest.c | 2 + 2 files changed, 112 insertions(+) -- 2.32.0

2 10

Entering freeze for libvirt-7.5.0
by Jiri Denemark 29 Jun '21

29 Jun '21

I have just tagged v7.5.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Thanks, Jirka

1 1

[PATCH 0/2] virSetUIDGIDWithCaps: Two small improvements
by Michal Privoznik 28 Jun '21

28 Jun '21

The first one fixes a problem I've started seeing with RHEL-9 and the other is just removal of check for tautology. Michal Prívozník (2): virSetUIDGIDWithCaps: Don't drop CAP_SETPCAP right away virSetUIDGIDWithCaps: Assume PR_CAPBSET_DROP is always defined src/util/virutil.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) -- 2.31.1

2 4

[PATCH] NEWS: Update for 7.5.0
by Peter Krempa 28 Jun '21

28 Jun '21

Mention fixing of disk iothread validation and the disk serial truncation state. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 2c7180cb95..3da2047d36 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -22,8 +22,19 @@ v7.5.0 (unreleased) * **Improvements** + * docs: Document disk serial truncation status quo + + Disk ``<serial>`` is being truncated by qemu before passed to the guest. + Since it's impossible to fix it without running into further regressions + the documentation was improved to document the intricacies. + * **Bug fixes** + * qemu: Fixed validation of disk ``iothread`` configuration + + The validation of ``iotrhead`` config was previously moved to a place where + it caused bogus errors when address wasn't allocated when hotplugging a + disk. The check is now removed as it wasn't actually necessary at all. v7.4.0 (2021-06-01) =================== -- 2.31.1

2 1

[RFCv3 00/25] RFC: Generate parsexml/formatbuf functions based on directives
by Shi Lei 28 Jun '21

28 Jun '21

V2 here: [https://listman.redhat.com/archives/libvir-list/2020-September/msg00204.html] Differ from V2: * Add tests for xmlgen to illustrate all the different features we can use and make sure its proper functions in the future. * Add docs/xmlgen.rst to explain the usage of all directives and the tool itself. * Now xmlgen can check whether the first item of enum ends with _NONE, _DEFAULT or _ABSENT and generate proper code. So we no longer need to add extra 'default' item for enum. * Now xmlgen can provide extra [tips] when we execute its command-line to show generated code for preview. * Enable/disable hooks by macros rather than by special directives. * Add virStrToBoolYesNo/virStrToBoolTrueFalse/virStrToBoolOnOff and explicitly check both the true and false values. * Stronger check for python3-clang and libclang.so to make sure it can work. * Add python3-clang to the libvirt.spec.in and the mingw-libvirt.spec.in. Thanks! Shi Lei (25): scripts: Add a tool to generate xml parse/format functions maint: Check python3-clang and libclang maint: Call xmlgen automatically when c-head-files change docs: Add xmlgen.rst to explain how to use it build-aux: Only check *.[ch] for sc_prohibit_useless_translation tests: Add tests for xmlgen util: Add some xml-helper-functions to cooperate with xmlgen util: Add helper aliases and functions for 'bool' and 'time_t' to cooperate with xmlgen util: Add parsexml/formatbuf helper functions for virSocketAddr util: Add virUUID type and parse/format functions conf: Extract error-checking code from virNetworkDNSTxtDefParseXML conf: Replace virNetworkDNSTxtDefParseXML(hardcoded) with namesake(generated) conf: Generate virNetworkDNSTxtDefFormatBuf conf: Extract error-checking code from virNetworkDNSSrvDefParseXML conf: Replace virNetworkDNSSrvDefParseXML(hardcoded) with namesake(generated) conf: Generate virNetworkDNSSrvDefFormatBuf conf: Extract error-checking code from virNetworkDNSHostDefParseXML conf: Replace virNetworkDNSHostDefParseXML(hardcoded) with namesake(generated) conf: Generate virNetworkDNSHostDefFormatBuf conf: Extract virNetworkDNSForwarderParseXML from virNetworkDNSParseXML conf: Replace virNetworkDNSForwarderParseXML(hardcoded) with namesake(generated) conf: Generate virNetworkDNSForwarderFormatBuf conf: Extract error-checking code from virNetworkDNSDefParseXML conf: Replace virNetworkDNSDefParseXML(hardcoded) with namesake(generated) conf: Generate virNetworkDNSDefFormatBuf build-aux/syntax-check.mk | 2 +- docs/meson.build | 1 + docs/xmlgen.rst | 684 +++++++++++++ libvirt.spec.in | 1 + meson.build | 10 + mingw-libvirt.spec.in | 1 + po/POTFILES.in | 2 + scripts/meson.build | 8 + scripts/xmlgen/directive.py | 1192 ++++++++++++++++++++++ scripts/xmlgen/go | 29 + scripts/xmlgen/main.py | 534 ++++++++++ scripts/xmlgen/utils.py | 121 +++ src/conf/meson.build | 37 + src/conf/network_conf.c | 463 ++------- src/conf/network_conf.h | 59 +- src/internal.h | 8 + src/libvirt_private.syms | 13 + src/meson.build | 6 + src/util/meson.build | 36 + src/util/virbuffer.c | 44 + src/util/virbuffer.h | 8 +- src/util/virsocketaddr.c | 42 + src/util/virsocketaddr.h | 23 +- src/util/virstring.c | 102 ++ src/util/virstring.h | 15 + src/util/viruuid.c | 31 + src/util/viruuid.h | 18 + src/util/virxml.c | 120 +++ src/util/virxml.h | 6 + tests/meson.build | 3 + tests/xmlgenin/conf/array.h | 17 + tests/xmlgenin/conf/empty.h | 7 + tests/xmlgenin/conf/enum-first-item.h | 12 + tests/xmlgenin/conf/external.h | 9 + tests/xmlgenin/conf/genformat-separate.h | 11 + tests/xmlgenin/conf/genformat.h | 11 + tests/xmlgenin/conf/genparse.h | 11 + tests/xmlgenin/conf/namespace.h | 12 + tests/xmlgenin/conf/required.h | 9 + tests/xmlgenin/conf/skipparse.h | 10 + tests/xmlgenin/conf/specify.h | 13 + tests/xmlgenin/conf/xmlattr.h | 10 + tests/xmlgenin/conf/xmlelem.h | 10 + tests/xmlgenin/conf/xmlgroup.h | 8 + tests/xmlgenin/conf/xmlswitch.h | 17 + tests/xmlgenin/util/enums.h | 58 ++ tests/xmlgenin/util/structs.h | 67 ++ tests/xmlgenout/array.txt | 364 +++++++ tests/xmlgenout/empty.txt | 181 ++++ tests/xmlgenout/enum-first-item.txt | 297 ++++++ tests/xmlgenout/external.txt | 205 ++++ tests/xmlgenout/genformat-separate.txt | 190 ++++ tests/xmlgenout/genformat.txt | 142 +++ tests/xmlgenout/genparse.txt | 154 +++ tests/xmlgenout/namespace.txt | 222 ++++ tests/xmlgenout/required.txt | 236 +++++ tests/xmlgenout/skipparse.txt | 223 ++++ tests/xmlgenout/specify.txt | 291 ++++++ tests/xmlgenout/xmlattr.txt | 252 +++++ tests/xmlgenout/xmlelem.txt | 243 +++++ tests/xmlgenout/xmlgroup.txt | 204 ++++ tests/xmlgenout/xmlswitch.txt | 470 +++++++++ tests/xmlgentest.c | 107 ++ tools/meson.build | 3 + 64 files changed, 7289 insertions(+), 406 deletions(-) create mode 100644 docs/xmlgen.rst create mode 100644 scripts/xmlgen/directive.py create mode 100755 scripts/xmlgen/go create mode 100755 scripts/xmlgen/main.py create mode 100644 scripts/xmlgen/utils.py create mode 100644 tests/xmlgenin/conf/array.h create mode 100644 tests/xmlgenin/conf/empty.h create mode 100644 tests/xmlgenin/conf/enum-first-item.h create mode 100644 tests/xmlgenin/conf/external.h create mode 100644 tests/xmlgenin/conf/genformat-separate.h create mode 100644 tests/xmlgenin/conf/genformat.h create mode 100644 tests/xmlgenin/conf/genparse.h create mode 100644 tests/xmlgenin/conf/namespace.h create mode 100644 tests/xmlgenin/conf/required.h create mode 100644 tests/xmlgenin/conf/skipparse.h create mode 100644 tests/xmlgenin/conf/specify.h create mode 100644 tests/xmlgenin/conf/xmlattr.h create mode 100644 tests/xmlgenin/conf/xmlelem.h create mode 100644 tests/xmlgenin/conf/xmlgroup.h create mode 100644 tests/xmlgenin/conf/xmlswitch.h create mode 100644 tests/xmlgenin/util/enums.h create mode 100644 tests/xmlgenin/util/structs.h create mode 100644 tests/xmlgenout/array.txt create mode 100644 tests/xmlgenout/empty.txt create mode 100644 tests/xmlgenout/enum-first-item.txt create mode 100644 tests/xmlgenout/external.txt create mode 100644 tests/xmlgenout/genformat-separate.txt create mode 100644 tests/xmlgenout/genformat.txt create mode 100644 tests/xmlgenout/genparse.txt create mode 100644 tests/xmlgenout/namespace.txt create mode 100644 tests/xmlgenout/required.txt create mode 100644 tests/xmlgenout/skipparse.txt create mode 100644 tests/xmlgenout/specify.txt create mode 100644 tests/xmlgenout/xmlattr.txt create mode 100644 tests/xmlgenout/xmlelem.txt create mode 100644 tests/xmlgenout/xmlgroup.txt create mode 100644 tests/xmlgenout/xmlswitch.txt create mode 100644 tests/xmlgentest.c -- 2.25.1

1 26

[libvirt PATCH 0/3] spec: misc cleanups
by Daniel P. Berrangé 25 Jun '21

25 Jun '21

This will be pushed to git master from https://gitlab.com/libvirt/libvirt/-/merge_requests/94 once CI completes. Zbigniew Jędrzejewski-Szmek (3): spec: drop/update dependencies on systemd-{units,sysv} spec: avoid repeated calls to systemd macros and binaries spec: avoid rpm warning about macro in comment libvirt.spec.in | 60 +++++++++++++++++++++++++------------------------ 1 file changed, 31 insertions(+), 29 deletions(-) -- 2.31.1

1 3

[PATCH V2 0/4] Apparmor: Add profiles for hypervisor daemons
by Jim Fehlig 25 Jun '21

25 Jun '21

and other improvements. V2 of https://listman.redhat.com/archives/libvir-list/2021-June/msg00456.html Changes since V1: Removed many unneeded capabilities. I used the 'audit' qualifier as suggested by cboltz to verify which capabilities were actually used. It's a difficult task though, as it is nearly impossible for one person to exercise a driver in all the ways thousands of users will push it :-). I was able to whittle the virtxend profile quite a bit since xen doesn't need a lot in the way of host capabilities. Removed patch containing the virtlxcd profile since I'm unable to start any lxc domains with virtlxcd. Added patches to squelch denial messages from the virt-aa-helper profile. Jim Fehlig (4): Apparmor: Add profile for virtqemud Apparmor: Add profile for virtxend Apparmor: Allow reading libnl's classid file Apparmor: Allow reading /etc/ssl/openssl.cnf src/security/apparmor/libvirt-qemu | 5 + src/security/apparmor/meson.build | 2 + .../usr.lib.libvirt.virt-aa-helper.in | 4 +- src/security/apparmor/usr.sbin.virtqemud.in | 135 ++++++++++++++++++ src/security/apparmor/usr.sbin.virtxend.in | 53 +++++++ 5 files changed, 198 insertions(+), 1 deletion(-) create mode 100644 src/security/apparmor/usr.sbin.virtqemud.in create mode 100644 src/security/apparmor/usr.sbin.virtxend.in -- 2.31.1

4 12

[PATCH] tests: qemucapabilities: Bump test data for qemu-6.1 on x86_64
by Peter Krempa 24 Jun '21

24 Jun '21

Update the caps data for the upcoming qemu version. Notable changes are: - 'query-sev-attestation-report' command added - 'sample-pages' members for dirty rate calculation added - 'qtest' device added - 'share' member added to query-memdev and 'reserve' members added to query-memdev/memory-backend-[file,memfd,ram] - 'qemu-vdagent' chardev added - 'mptcp' toggle added to inet servers - 'zstd' compression for qcow2 - new cpu models: - "Snowridge-v3" - "Skylake-Server-v5" - "Skylake-Client-v4" - "Icelake-Server-v5" - "Icelake-Client-v3" - "Dhyana-v2" - "Denverton-v3" - "Cooperlake-v2" - "Cascadelake-Server-v5" - 'avx-vnni' added to some existing cpu models - 'model-id' is now being reported as the host cpu again rather than QEMU TCG as I've noted in previous bump Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- .../caps_6.1.0.x86_64.replies | 3663 ++++++++++------- .../caps_6.1.0.x86_64.xml | 366 +- 2 files changed, 2525 insertions(+), 1504 deletions(-) diff --git a/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.replies b/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.replies index 9291840bd2..2217e1331c 100644 --- a/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.replies +++ b/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.replies @@ -21,7 +21,7 @@ "minor": 0, "major": 6 }, - "package": "v6.0.0-540-g6005ee07c3" + "package": "v6.0.0-1820-g0add99ea3e" }, "id": "libvirt-2" } [...] Trimmed for brevity. Full version: https://gitlab.com/pipo.sk/libvirt/-/commit/9fd3bc550ff91d6340d1c0316b46fb0… diff --git a/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml index 1937b88a4d..f173daf788 100644 --- a/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml @@ -263,7 +263,7 @@ <version>6000050</version> <kvmVersion>0</kvmVersion> <microcodeVersion>43100243</microcodeVersion> - <package>v6.0.0-540-g6005ee07c3</package> + <package>v6.0.0-1820-g0add99ea3e</package> <arch>x86_64</arch> <hostCPU type='kvm' model='base' migratability='yes'> <property name='vmx-entry-load-rtit-ctl' type='boolean' value='false'/> @@ -297,7 +297,7 @@ <property name='vmx-exit-load-efer' type='boolean' value='false'/> <property name='vmx-exit-clear-bndcfgs' type='boolean' value='false'/> <property name='sse4.1' type='boolean' value='true' migratable='yes'/> - <property name='family' type='number' value='6'/> + <property name='family' type='number' value='23'/> <property name='intel-pt-lip' type='boolean' value='false'/> <property name='vmx-vmwrite-vmexit-fields' type='boolean' value='false'/> <property name='kvm-asyncpf-int' type='boolean' value='true' migratable='yes'/> @@ -314,7 +314,7 @@ <property name='xcrypt' type='boolean' value='false'/> <property name='vmx-exit-load-pat' type='boolean' value='false'/> <property name='vmx-intr-exit' type='boolean' value='false'/> - <property name='min-level' type='number' value='13'/> + <property name='min-level' type='number' value='16'/> <property name='vmx-flexpriority' type='boolean' value='false'/> <property name='xgetbv1' type='boolean' value='true' migratable='yes'/> <property name='cid' type='boolean' value='false'/> @@ -359,6 +359,7 @@ <property name='avx512-4fmaps' type='boolean' value='false'/> <property name='vmcb-clean' type='boolean' value='false'/> <property name='hle' type='boolean' value='false'/> + <property name='avx-vnni' type='boolean' value='false'/> <property name='3dnowext' type='boolean' value='false'/> <property name='amd-no-ssb' type='boolean' value='false'/> <property name='npt' type='boolean' value='false'/> @@ -427,7 +428,7 @@ <property name='pdcm' type='boolean' value='false'/> <property name='vmx-entry-load-bndcfgs' type='boolean' value='false'/> <property name='vmx-exit-clear-rtit-ctl' type='boolean' value='false'/> - <property name='model' type='number' value='6'/> + <property name='model' type='number' value='113'/> <property name='movbe' type='boolean' value='true' migratable='yes'/> <property name='nrip-save' type='boolean' value='false'/> <property name='ssse3' type='boolean' value='true' migratable='yes'/> @@ -442,7 +443,7 @@ <property name='fma' type='boolean' value='true' migratable='yes'/> <property name='cx16' type='boolean' value='true' migratable='yes'/> <property name='de' type='boolean' value='true' migratable='yes'/> - <property name='stepping' type='number' value='3'/> + <property name='stepping' type='number' value='0'/> <property name='xsave' type='boolean' value='true' migratable='yes'/> <property name='clflush' type='boolean' value='true' migratable='yes'/> <property name='skinit' type='boolean' value='false'/> @@ -516,7 +517,7 @@ <property name='md-clear' type='boolean' value='false'/> <property name='misalignsse' type='boolean' value='true' migratable='yes'/> <property name='split-lock-detect' type='boolean' value='false'/> - <property name='min-xlevel' type='number' value='2147483656'/> + <property name='min-xlevel' type='number' value='2147483679'/> <property name='bmi1' type='boolean' value='true' migratable='yes'/> <property name='bmi2' type='boolean' value='true' migratable='yes'/> <property name='kvm-pv-unhalt' type='boolean' value='true' migratable='yes'/> @@ -568,7 +569,7 @@ <property name='vmx-rdpmc-exit' type='boolean' value='false'/> <property name='vmx-mtf' type='boolean' value='false'/> <property name='vmx-entry-load-efer' type='boolean' value='false'/> - <property name='model-id' type='string' value='QEMU TCG CPU version 2.5+'/> + <property name='model-id' type='string' value='AMD Ryzen 9 3900X 12-Core Processor '/> <property name='sha-ni' type='boolean' value='true' migratable='yes'/> <property name='vmx-exit-load-pkrs' type='boolean' value='false'/> <property name='abm' type='boolean' value='true' migratable='yes'/> @@ -636,6 +637,16 @@ <blocker name='spec-ctrl'/> </cpu> <cpu type='kvm' name='Westmere' typename='Westmere-x86_64-cpu' usable='yes'/> + <cpu type='kvm' name='Snowridge-v3' typename='Snowridge-v3-x86_64-cpu' usable='no'> + <blocker name='erms'/> + <blocker name='gfni'/> + <blocker name='cldemote'/> + <blocker name='movdiri'/> + <blocker name='movdir64b'/> + <blocker name='spec-ctrl'/> + <blocker name='core-capability'/> + <blocker name='split-lock-detect'/> + </cpu> <cpu type='kvm' name='Snowridge-v2' typename='Snowridge-v2-x86_64-cpu' usable='no'> <blocker name='erms'/> <blocker name='gfni'/> @@ -672,6 +683,22 @@ <blocker name='mpx'/> <blocker name='split-lock-detect'/> </cpu> + <cpu type='kvm' name='Skylake-Server-v5' typename='Skylake-Server-v5-x86_64-cpu' usable='no'> + <blocker name='pcid'/> + <blocker name='erms'/> + <blocker name='invpcid'/> + <blocker name='avx512f'/> + <blocker name='avx512dq'/> + <blocker name='avx512cd'/> + <blocker name='avx512bw'/> + <blocker name='avx512vl'/> + <blocker name='pku'/> + <blocker name='spec-ctrl'/> + <blocker name='avx512f'/> + <blocker name='avx512f'/> + <blocker name='avx512f'/> + <blocker name='pku'/> + </cpu> <cpu type='kvm' name='Skylake-Server-v4' typename='Skylake-Server-v4-x86_64-cpu' usable='no'> <blocker name='pcid'/> <blocker name='erms'/> @@ -790,6 +817,12 @@ <blocker name='avx512f'/> <blocker name='pku'/> </cpu> + <cpu type='kvm' name='Skylake-Client-v4' typename='Skylake-Client-v4-x86_64-cpu' usable='no'> + <blocker name='pcid'/> + <blocker name='erms'/> + <blocker name='invpcid'/> + <blocker name='spec-ctrl'/> + </cpu> <cpu type='kvm' name='Skylake-Client-v3' typename='Skylake-Client-v3-x86_64-cpu' usable='no'> <blocker name='pcid'/> <blocker name='erms'/> @@ -916,6 +949,35 @@ <cpu type='kvm' name='IvyBridge' typename='IvyBridge-x86_64-cpu' usable='no'> <blocker name='erms'/> </cpu> + <cpu type='kvm' name='Icelake-Server-v5' typename='Icelake-Server-v5-x86_64-cpu' usable='no'> + <blocker name='pcid'/> + <blocker name='erms'/> + <blocker name='invpcid'/> + <blocker name='avx512f'/> + <blocker name='avx512dq'/> + <blocker name='avx512ifma'/> + <blocker name='avx512cd'/> + <blocker name='avx512bw'/> + <blocker name='avx512vl'/> + <blocker name='avx512vbmi'/> + <blocker name='pku'/> + <blocker name='avx512vbmi2'/> + <blocker name='gfni'/> + <blocker name='vaes'/> + <blocker name='vpclmulqdq'/> + <blocker name='avx512vnni'/> + <blocker name='avx512bitalg'/> + <blocker name='avx512-vpopcntdq'/> + <blocker name='la57'/> + <blocker name='fsrm'/> + <blocker name='spec-ctrl'/> + <blocker name='avx512f'/> + <blocker name='avx512f'/> + <blocker name='avx512f'/> + <blocker name='pku'/> + <blocker name='ibrs-all'/> + <blocker name='taa-no'/> + </cpu> <cpu type='kvm' name='Icelake-Server-v4' typename='Icelake-Server-v4-x86_64-cpu' usable='no'> <blocker name='pcid'/> <blocker name='erms'/> @@ -1076,6 +1138,22 @@ <blocker name='avx512f'/> <blocker name='pku'/> </cpu> + <cpu type='kvm' name='Icelake-Client-v3' typename='Icelake-Client-v3-x86_64-cpu' usable='no' deprecated='yes'> + <blocker name='pcid'/> + <blocker name='erms'/> + <blocker name='invpcid'/> + <blocker name='avx512vbmi'/> + <blocker name='pku'/> + <blocker name='avx512vbmi2'/> + <blocker name='gfni'/> + <blocker name='vaes'/> + <blocker name='vpclmulqdq'/> + <blocker name='avx512vnni'/> + <blocker name='avx512bitalg'/> + <blocker name='avx512-vpopcntdq'/> + <blocker name='spec-ctrl'/> + <blocker name='pku'/> + </cpu> <cpu type='kvm' name='Icelake-Client-v2' typename='Icelake-Client-v2-x86_64-cpu' usable='no' deprecated='yes'> <blocker name='pcid'/> <blocker name='erms'/> @@ -1224,8 +1302,13 @@ </cpu> <cpu type='kvm' name='EPYC-IBPB' typename='EPYC-IBPB-x86_64-cpu' usable='yes'/> <cpu type='kvm' name='EPYC' typename='EPYC-x86_64-cpu' usable='yes'/> + <cpu type='kvm' name='Dhyana-v2' typename='Dhyana-v2-x86_64-cpu' usable='yes'/> <cpu type='kvm' name='Dhyana-v1' typename='Dhyana-v1-x86_64-cpu' usable='yes'/> <cpu type='kvm' name='Dhyana' typename='Dhyana-x86_64-cpu' usable='yes'/> + <cpu type='kvm' name='Denverton-v3' typename='Denverton-v3-x86_64-cpu' usable='no'> + <blocker name='erms'/> + <blocker name='spec-ctrl'/> + </cpu> <cpu type='kvm' name='Denverton-v2' typename='Denverton-v2-x86_64-cpu' usable='no'> <blocker name='erms'/> <blocker name='spec-ctrl'/> @@ -1244,6 +1327,29 @@ <blocker name='mpx'/> <blocker name='mpx'/> </cpu> + <cpu type='kvm' name='Cooperlake-v2' typename='Cooperlake-v2-x86_64-cpu' usable='no'> + <blocker name='pcid'/> + <blocker name='hle'/> + <blocker name='erms'/> + <blocker name='invpcid'/> + <blocker name='rtm'/> + <blocker name='avx512f'/> + <blocker name='avx512dq'/> + <blocker name='avx512cd'/> + <blocker name='avx512bw'/> + <blocker name='avx512vl'/> + <blocker name='pku'/> + <blocker name='avx512vnni'/> + <blocker name='spec-ctrl'/> + <blocker name='avx-vnni'/> + <blocker name='avx512-bf16'/> + <blocker name='avx512f'/> + <blocker name='avx512f'/> + <blocker name='avx512f'/> + <blocker name='pku'/> + <blocker name='ibrs-all'/> + <blocker name='taa-no'/> + </cpu> <cpu type='kvm' name='Cooperlake-v1' typename='Cooperlake-v1-x86_64-cpu' usable='no'> <blocker name='pcid'/> <blocker name='hle'/> @@ -1258,6 +1364,7 @@ <blocker name='pku'/> <blocker name='avx512vnni'/> <blocker name='spec-ctrl'/> + <blocker name='avx-vnni'/> <blocker name='avx512-bf16'/> <blocker name='avx512f'/> <blocker name='avx512f'/> @@ -1280,6 +1387,7 @@ <blocker name='pku'/> <blocker name='avx512vnni'/> <blocker name='spec-ctrl'/> + <blocker name='avx-vnni'/> <blocker name='avx512-bf16'/> <blocker name='avx512f'/> <blocker name='avx512f'/> @@ -1290,6 +1398,24 @@ </cpu> <cpu type='kvm' name='Conroe-v1' typename='Conroe-v1-x86_64-cpu' usable='yes'/> <cpu type='kvm' name='Conroe' typename='Conroe-x86_64-cpu' usable='yes'/> + <cpu type='kvm' name='Cascadelake-Server-v5' typename='Cascadelake-Server-v5-x86_64-cpu' usable='no'> + <blocker name='pcid'/> + <blocker name='erms'/> + <blocker name='invpcid'/> + <blocker name='avx512f'/> + <blocker name='avx512dq'/> + <blocker name='avx512cd'/> + <blocker name='avx512bw'/> + <blocker name='avx512vl'/> + <blocker name='pku'/> + <blocker name='avx512vnni'/> + <blocker name='spec-ctrl'/> + <blocker name='avx512f'/> + <blocker name='avx512f'/> + <blocker name='avx512f'/> + <blocker name='pku'/> + <blocker name='ibrs-all'/> + </cpu> <cpu type='kvm' name='Cascadelake-Server-v4' typename='Cascadelake-Server-v4-x86_64-cpu' usable='no'> <blocker name='pcid'/> <blocker name='erms'/> @@ -1472,9 +1598,9 @@ <machine type='kvm' name='pc-q35-2.4' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='kvm' name='pc-q35-2.10' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='kvm' name='x-remote' maxCpus='1'/> + <machine type='kvm' name='pc-i440fx-1.7' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='kvm' name='pc-q35-5.1' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' defaultRAMid='pc.ram'/> <machine type='kvm' name='pc-q35-2.9' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> - <machine type='kvm' name='pc-i440fx-1.7' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='kvm' name='pc-i440fx-2.11' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='kvm' name='pc-q35-3.1' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='kvm' name='pc-q35-4.1' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> @@ -1538,7 +1664,7 @@ <property name='vmx-exit-load-efer' type='boolean' value='false'/> <property name='vmx-exit-clear-bndcfgs' type='boolean' value='false'/> <property name='sse4.1' type='boolean' value='true' migratable='yes'/> - <property name='family' type='number' value='6'/> + <property name='family' type='number' value='15'/> <property name='intel-pt-lip' type='boolean' value='false'/> <property name='vmx-vmwrite-vmexit-fields' type='boolean' value='false'/> <property name='kvm-asyncpf-int' type='boolean' value='false'/> @@ -1600,6 +1726,7 @@ <property name='avx512-4fmaps' type='boolean' value='false'/> <property name='vmcb-clean' type='boolean' value='false'/> <property name='hle' type='boolean' value='false'/> + <property name='avx-vnni' type='boolean' value='false'/> <property name='3dnowext' type='boolean' value='true' migratable='yes'/> <property name='amd-no-ssb' type='boolean' value='false'/> <property name='npt' type='boolean' value='true' migratable='yes'/> @@ -1668,7 +1795,7 @@ <property name='pdcm' type='boolean' value='false'/> <property name='vmx-entry-load-bndcfgs' type='boolean' value='false'/> <property name='vmx-exit-clear-rtit-ctl' type='boolean' value='false'/> - <property name='model' type='number' value='6'/> + <property name='model' type='number' value='107'/> <property name='movbe' type='boolean' value='true' migratable='yes'/> <property name='nrip-save' type='boolean' value='false'/> <property name='ssse3' type='boolean' value='true' migratable='yes'/> @@ -1683,7 +1810,7 @@ <property name='fma' type='boolean' value='false'/> <property name='cx16' type='boolean' value='true' migratable='yes'/> <property name='de' type='boolean' value='true' migratable='yes'/> - <property name='stepping' type='number' value='3'/> + <property name='stepping' type='number' value='1'/> <property name='xsave' type='boolean' value='true' migratable='yes'/> <property name='clflush' type='boolean' value='true' migratable='yes'/> <property name='skinit' type='boolean' value='false'/> @@ -1859,6 +1986,25 @@ <blocker name='spec-ctrl'/> </cpu> <cpu type='tcg' name='Westmere' typename='Westmere-x86_64-cpu' usable='yes'/> + <cpu type='tcg' name='Snowridge-v3' typename='Snowridge-v3-x86_64-cpu' usable='no'> + <blocker name='x2apic'/> + <blocker name='tsc-deadline'/> + <blocker name='rdseed'/> + <blocker name='sha-ni'/> + <blocker name='umip'/> + <blocker name='gfni'/> + <blocker name='cldemote'/> + <blocker name='movdiri'/> + <blocker name='movdir64b'/> + <blocker name='spec-ctrl'/> + <blocker name='arch-capabilities'/> + <blocker name='core-capability'/> + <blocker name='ssbd'/> + <blocker name='3dnowprefetch'/> + <blocker name='xsavec'/> + <blocker name='xsaves'/> + <blocker name='split-lock-detect'/> + </cpu> <cpu type='tcg' name='Snowridge-v2' typename='Snowridge-v2-x86_64-cpu' usable='no'> <blocker name='x2apic'/> <blocker name='tsc-deadline'/> @@ -1913,6 +2059,26 @@ <blocker name='xsavec'/> <blocker name='split-lock-detect'/> </cpu> + <cpu type='tcg' name='Skylake-Server-v5' typename='Skylake-Server-v5-x86_64-cpu' usable='no'> + <blocker name='fma'/> + <blocker name='pcid'/> + <blocker name='x2apic'/> + <blocker name='tsc-deadline'/> + <blocker name='avx'/> + <blocker name='f16c'/> + <blocker name='avx2'/> + <blocker name='invpcid'/> + <blocker name='avx512f'/> + <blocker name='avx512dq'/> + <blocker name='rdseed'/> + <blocker name='avx512cd'/> + <blocker name='avx512bw'/> + <blocker name='avx512vl'/> + <blocker name='spec-ctrl'/> + <blocker name='3dnowprefetch'/> + <blocker name='xsavec'/> + <blocker name='xsaves'/> + </cpu> <cpu type='tcg' name='Skylake-Server-v4' typename='Skylake-Server-v4-x86_64-cpu' usable='no'> <blocker name='fma'/> <blocker name='pcid'/> @@ -2052,6 +2218,21 @@ <blocker name='3dnowprefetch'/> <blocker name='xsavec'/> </cpu> + <cpu type='tcg' name='Skylake-Client-v4' typename='Skylake-Client-v4-x86_64-cpu' usable='no'> + <blocker name='fma'/> + <blocker name='pcid'/> + <blocker name='x2apic'/> + <blocker name='tsc-deadline'/> + <blocker name='avx'/> + <blocker name='f16c'/> + <blocker name='avx2'/> + <blocker name='invpcid'/> + <blocker name='rdseed'/> + <blocker name='spec-ctrl'/> + <blocker name='3dnowprefetch'/> + <blocker name='xsavec'/> + <blocker name='xsaves'/> + </cpu> <cpu type='tcg' name='Skylake-Client-v3' typename='Skylake-Client-v3-x86_64-cpu' usable='no'> <blocker name='fma'/> <blocker name='pcid'/> @@ -2282,6 +2463,48 @@ <blocker name='avx'/> <blocker name='f16c'/> </cpu> + <cpu type='tcg' name='Icelake-Server-v5' typename='Icelake-Server-v5-x86_64-cpu' usable='no'> + <blocker name='fma'/> + <blocker name='pcid'/> + <blocker name='x2apic'/> + <blocker name='tsc-deadline'/> + <blocker name='avx'/> + <blocker name='f16c'/> + <blocker name='avx2'/> + <blocker name='invpcid'/> + <blocker name='avx512f'/> + <blocker name='avx512dq'/> + <blocker name='rdseed'/> + <blocker name='avx512ifma'/> + <blocker name='avx512cd'/> + <blocker name='sha-ni'/> + <blocker name='avx512bw'/> + <blocker name='avx512vl'/> + <blocker name='avx512vbmi'/> + <blocker name='umip'/> + <blocker name='avx512vbmi2'/> + <blocker name='gfni'/> + <blocker name='vaes'/> + <blocker name='vpclmulqdq'/> + <blocker name='avx512vnni'/> + <blocker name='avx512bitalg'/> + <blocker name='avx512-vpopcntdq'/> + <blocker name='rdpid'/> + <blocker name='fsrm'/> + <blocker name='spec-ctrl'/> + <blocker name='arch-capabilities'/> + <blocker name='ssbd'/> + <blocker name='3dnowprefetch'/> + <blocker name='wbnoinvd'/> + <blocker name='xsavec'/> + <blocker name='xsaves'/> + <blocker name='rdctl-no'/> + <blocker name='ibrs-all'/> + <blocker name='skip-l1dfl-vmentry'/> + <blocker name='mds-no'/> + <blocker name='pschange-mc-no'/> + <blocker name='taa-no'/> + </cpu> <cpu type='tcg' name='Icelake-Server-v4' typename='Icelake-Server-v4-x86_64-cpu' usable='no'> <blocker name='fma'/> <blocker name='pcid'/> @@ -2484,6 +2707,32 @@ <blocker name='wbnoinvd'/> <blocker name='xsavec'/> </cpu> + <cpu type='tcg' name='Icelake-Client-v3' typename='Icelake-Client-v3-x86_64-cpu' usable='no' deprecated='yes'> + <blocker name='fma'/> + <blocker name='pcid'/> + <blocker name='x2apic'/> + <blocker name='tsc-deadline'/> + <blocker name='avx'/> + <blocker name='f16c'/> + <blocker name='avx2'/> + <blocker name='invpcid'/> + <blocker name='rdseed'/> + <blocker name='avx512vbmi'/> + <blocker name='umip'/> + <blocker name='avx512vbmi2'/> + <blocker name='gfni'/> + <blocker name='vaes'/> + <blocker name='vpclmulqdq'/> + <blocker name='avx512vnni'/> + <blocker name='avx512bitalg'/> + <blocker name='avx512-vpopcntdq'/> + <blocker name='spec-ctrl'/> + <blocker name='ssbd'/> + <blocker name='3dnowprefetch'/> + <blocker name='wbnoinvd'/> + <blocker name='xsavec'/> + <blocker name='xsaves'/> + </cpu> <cpu type='tcg' name='Icelake-Client-v2' typename='Icelake-Client-v2-x86_64-cpu' usable='no' deprecated='yes'> <blocker name='fma'/> <blocker name='pcid'/> @@ -2896,6 +3145,22 @@ <blocker name='nrip-save'/> <blocker name='xsavec'/> </cpu> + <cpu type='tcg' name='Dhyana-v2' typename='Dhyana-v2-x86_64-cpu' usable='no'> + <blocker name='fma'/> + <blocker name='avx'/> + <blocker name='f16c'/> + <blocker name='avx2'/> + <blocker name='rdseed'/> + <blocker name='fxsr-opt'/> + <blocker name='misalignsse'/> + <blocker name='3dnowprefetch'/> + <blocker name='osvw'/> + <blocker name='topoext'/> + <blocker name='ibpb'/> + <blocker name='nrip-save'/> + <blocker name='xsavec'/> + <blocker name='xsaves'/> + </cpu> <cpu type='tcg' name='Dhyana-v1' typename='Dhyana-v1-x86_64-cpu' usable='no'> <blocker name='fma'/> <blocker name='avx'/> @@ -2926,6 +3191,20 @@ <blocker name='nrip-save'/> <blocker name='xsavec'/> </cpu> + <cpu type='tcg' name='Denverton-v3' typename='Denverton-v3-x86_64-cpu' usable='no'> + <blocker name='x2apic'/> + <blocker name='tsc-deadline'/> + <blocker name='rdseed'/> + <blocker name='sha-ni'/> + <blocker name='spec-ctrl'/> + <blocker name='arch-capabilities'/> + <blocker name='ssbd'/> + <blocker name='3dnowprefetch'/> + <blocker name='xsavec'/> + <blocker name='xsaves'/> + <blocker name='rdctl-no'/> + <blocker name='skip-l1dfl-vmentry'/> + </cpu> <cpu type='tcg' name='Denverton-v2' typename='Denverton-v2-x86_64-cpu' usable='no'> <blocker name='x2apic'/> <blocker name='tsc-deadline'/> @@ -2965,6 +3244,40 @@ <blocker name='rdctl-no'/> <blocker name='skip-l1dfl-vmentry'/> </cpu> + <cpu type='tcg' name='Cooperlake-v2' typename='Cooperlake-v2-x86_64-cpu' usable='no'> + <blocker name='fma'/> + <blocker name='pcid'/> + <blocker name='x2apic'/> + <blocker name='tsc-deadline'/> + <blocker name='avx'/> + <blocker name='f16c'/> + <blocker name='hle'/> + <blocker name='avx2'/> + <blocker name='invpcid'/> + <blocker name='rtm'/> + <blocker name='avx512f'/> + <blocker name='avx512dq'/> + <blocker name='rdseed'/> + <blocker name='avx512cd'/> + <blocker name='avx512bw'/> + <blocker name='avx512vl'/> + <blocker name='avx512vnni'/> + <blocker name='spec-ctrl'/> + <blocker name='stibp'/> + <blocker name='arch-capabilities'/> + <blocker name='ssbd'/> + <blocker name='avx-vnni'/> + <blocker name='avx512-bf16'/> + <blocker name='3dnowprefetch'/> + <blocker name='xsavec'/> + <blocker name='xsaves'/> + <blocker name='rdctl-no'/> + <blocker name='ibrs-all'/> + <blocker name='skip-l1dfl-vmentry'/> + <blocker name='mds-no'/> + <blocker name='pschange-mc-no'/> + <blocker name='taa-no'/> + </cpu> <cpu type='tcg' name='Cooperlake-v1' typename='Cooperlake-v1-x86_64-cpu' usable='no'> <blocker name='fma'/> <blocker name='pcid'/> @@ -2987,6 +3300,7 @@ <blocker name='stibp'/> <blocker name='arch-capabilities'/> <blocker name='ssbd'/> + <blocker name='avx-vnni'/> <blocker name='avx512-bf16'/> <blocker name='3dnowprefetch'/> <blocker name='xsavec'/> @@ -3019,6 +3333,7 @@ <blocker name='stibp'/> <blocker name='arch-capabilities'/> <blocker name='ssbd'/> + <blocker name='avx-vnni'/> <blocker name='avx512-bf16'/> <blocker name='3dnowprefetch'/> <blocker name='xsavec'/> @@ -3031,6 +3346,33 @@ </cpu> <cpu type='tcg' name='Conroe-v1' typename='Conroe-v1-x86_64-cpu' usable='yes'/> <cpu type='tcg' name='Conroe' typename='Conroe-x86_64-cpu' usable='yes'/> + <cpu type='tcg' name='Cascadelake-Server-v5' typename='Cascadelake-Server-v5-x86_64-cpu' usable='no'> + <blocker name='fma'/> + <blocker name='pcid'/> + <blocker name='x2apic'/> + <blocker name='tsc-deadline'/> + <blocker name='avx'/> + <blocker name='f16c'/> + <blocker name='avx2'/> + <blocker name='invpcid'/> + <blocker name='avx512f'/> + <blocker name='avx512dq'/> + <blocker name='rdseed'/> + <blocker name='avx512cd'/> + <blocker name='avx512bw'/> + <blocker name='avx512vl'/> + <blocker name='avx512vnni'/> + <blocker name='spec-ctrl'/> + <blocker name='arch-capabilities'/> + <blocker name='ssbd'/> + <blocker name='3dnowprefetch'/> + <blocker name='xsavec'/> + <blocker name='xsaves'/> + <blocker name='rdctl-no'/> + <blocker name='ibrs-all'/> + <blocker name='skip-l1dfl-vmentry'/> + <blocker name='mds-no'/> + </cpu> <cpu type='tcg' name='Cascadelake-Server-v4' typename='Cascadelake-Server-v4-x86_64-cpu' usable='no'> <blocker name='fma'/> <blocker name='pcid'/> @@ -3309,9 +3651,9 @@ <machine type='tcg' name='pc-q35-2.4' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='tcg' name='pc-q35-2.10' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='tcg' name='x-remote' maxCpus='1'/> + <machine type='tcg' name='pc-i440fx-1.7' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='tcg' name='pc-q35-5.1' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' defaultRAMid='pc.ram'/> <machine type='tcg' name='pc-q35-2.9' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> - <machine type='tcg' name='pc-i440fx-1.7' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='tcg' name='pc-i440fx-2.11' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='tcg' name='pc-q35-3.1' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='tcg' name='pc-q35-4.1' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> -- 2.31.1

2 1

[PATCH] test_driver: Implement virDomainGetSecurityLabelList
by Luke Yue 24 Jun '21

24 Jun '21

Signed-off-by: Luke Yue <lukedyue(a)gmail.com> --- src/test/test_driver.c | 41 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 611ec6d7ec..ae1b8ebc23 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -136,6 +136,7 @@ VIR_ONCE_GLOBAL_INIT(testDriver); #define TEST_MODEL "i686" #define TEST_EMULATOR "/usr/bin/test-hv" +#define TEST_SECURITY_LABEL_LIST_LENGTH 2 static const virNodeInfo defaultNodeInfo = { TEST_MODEL, @@ -5037,6 +5038,45 @@ testDomainGetSecurityLabel(virDomainPtr dom, return ret; } +static int +testDomainGetSecurityLabelList(virDomainPtr dom, + virSecurityLabelPtr* seclabels) +{ + virDomainObj *vm; + size_t i; + int ret = -1; + + if (!(vm = testDomObjFromDomain(dom))) + return -1; + + if (!virDomainObjIsActive(vm)) { + /* No seclabels */ + *seclabels = NULL; + ret = 0; + } else { + int len = TEST_SECURITY_LABEL_LIST_LENGTH; + + (*seclabels) = g_new0(virSecurityLabel, len); + memset(*seclabels, 0, sizeof(**seclabels) * len); + + /* Fill the array */ + for (i = 0; i < len; i++) { + if (virStrcpyStatic(seclabels[i]->label, "libvirt-test") < 0) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("security label exceeds maximum: %zu"), + sizeof(seclabels[i]->label) - 1); + VIR_FREE(*seclabels); + goto cleanup; + } + } + ret = len; + } + + cleanup: + virDomainObjEndAPI(&vm); + return ret; +} + static int testNodeGetSecurityModel(virConnectPtr conn, virSecurityModelPtr secmodel) @@ -9357,6 +9397,7 @@ static virHypervisorDriver testHypervisorDriver = { .domainGetVcpuPinInfo = testDomainGetVcpuPinInfo, /* 1.2.18 */ .domainGetMaxVcpus = testDomainGetMaxVcpus, /* 0.7.3 */ .domainGetSecurityLabel = testDomainGetSecurityLabel, /* 7.5.0 */ + .domainGetSecurityLabelList = testDomainGetSecurityLabelList, /* 7.5.0 */ .nodeGetSecurityModel = testNodeGetSecurityModel, /* 7.5.0 */ .domainGetXMLDesc = testDomainGetXMLDesc, /* 0.1.4 */ .domainSetMemoryParameters = testDomainSetMemoryParameters, /* 5.6.0 */ -- 2.32.0

2 4

[PATCH] test_driver: Implement virDomainGetMessages
by Luke Yue 24 Jun '21

24 Jun '21

Signed-off-by: Luke Yue <lukedyue(a)gmail.com> --- src/test/test_driver.c | 53 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 53 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index ae1b8ebc23..a7ea05464d 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -9331,6 +9331,58 @@ testDomainCheckpointDelete(virDomainCheckpointPtr checkpoint, return ret; } +static int +testDomainGetMessages(virDomainPtr dom, + char ***msgs, + unsigned int flags) +{ + virDomainObj *vm = NULL; + int rv = -1; + size_t i, n; + int nmsgs; + + virCheckFlags(VIR_DOMAIN_MESSAGE_DEPRECATION | + VIR_DOMAIN_MESSAGE_TAINTING, -1); + + if (!(vm = testDomObjFromDomain(dom))) + return -1; + + *msgs = NULL; + nmsgs = 0; + n = 0; + + if (!flags || (flags & VIR_DOMAIN_MESSAGE_TAINTING)) { + nmsgs += __builtin_popcount(vm->taint); + *msgs = g_renew(char *, *msgs, nmsgs+1); + + for (i = 0; i < VIR_DOMAIN_TAINT_LAST; i++) { + if (vm->taint & (1 << i)) { + (*msgs)[n++] = g_strdup_printf( + _("tainted: %s"), + _(virDomainTaintMessageTypeToString(i))); + } + } + } + + if (!flags || (flags & VIR_DOMAIN_MESSAGE_DEPRECATION)) { + nmsgs += vm->ndeprecations; + *msgs = g_renew(char *, *msgs, nmsgs+1); + + for (i = 0; i < vm->ndeprecations; i++) { + (*msgs)[n++] = g_strdup_printf( + _("deprecated configuration: %s"), + vm->deprecations[i]); + } + } + + (*msgs)[nmsgs] = NULL; + + rv = nmsgs; + + virDomainObjEndAPI(&vm); + return rv; +} + /* * Test driver */ @@ -9489,6 +9541,7 @@ static virHypervisorDriver testHypervisorDriver = { .domainCheckpointLookupByName = testDomainCheckpointLookupByName, /* 5.6.0 */ .domainCheckpointGetParent = testDomainCheckpointGetParent, /* 5.6.0 */ .domainCheckpointDelete = testDomainCheckpointDelete, /* 5.6.0 */ + .domainGetMessages = testDomainGetMessages, /* 7.5.0 */ }; static virNetworkDriver testNetworkDriver = { -- 2.32.0

2 4

[libvirt PATCH] spec: Drop libiscsi support in RHEL-9
by Jiri Denemark 24 Jun '21

24 Jun '21

https://bugzilla.redhat.com/show_bug.cgi?id=1975677 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- libvirt.spec.in | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index b8a698e81e..c1ccd2f74e 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -85,6 +85,10 @@ %endif %define with_storage_iscsi_direct 0%{!?_without_storage_iscsi_direct:1} +# libiscsi has been dropped in RHEL-9 +%if 0%{?rhel} > 8 + %define with_storage_iscsi_direct 0 +%endif # Other optional features %define with_numactl 0%{!?_without_numactl:1} -- 2.32.0

2 1

[libvirt PATCH 0/7] Enable autostarting mediated devices
by Jonathon Jongsma 23 Jun '21

23 Jun '21

This series replaces the initial patch that was recently reverted. It implements the autostart feature using a new virNodeDeviceGet/SetAutostart() API that is consistent with how other libvirt objects handle autostart. It also adds a counterpart virsh command nodedev-autostart. In order to easily check the 'autostart' status of the device (since it is no longer part of the device xml), a new virsh command is introduced: nodedev-info. This also presents a few more basic bits of information about the device, including 'active' and 'persistent' status, which requires exposing new APIs on the node device: IsActive() and IsPersistent(). These APIs are consistent with existing libvirt objects. Jonathon Jongsma (7): api: add virNodeDevice(Get|Set)Autostart() nodedev: implement virNodeDevice(Get|Set)Autostart() nodedev: Add tests for mdevctl autostart command virsh: add nodedev-autostart api: add virNodeDeviceIsPersistent()/IsActive() nodedev: Implement virNodeDeviceIsPersistent()/IsActive() virsh: add nodedev-info docs/manpages/virsh.rst | 27 +++ include/libvirt/libvirt-nodedev.h | 10 ++ src/conf/virnodedeviceobj.c | 16 ++ src/conf/virnodedeviceobj.h | 6 + src/driver-nodedev.h | 18 ++ src/libvirt-nodedev.c | 141 +++++++++++++++ src/libvirt_private.syms | 2 + src/libvirt_public.syms | 6 + src/node_device/node_device_driver.c | 166 ++++++++++++++++++ src/node_device/node_device_driver.h | 19 ++ src/node_device/node_device_udev.c | 30 +++- src/remote/remote_driver.c | 6 +- src/remote/remote_protocol.x | 59 ++++++- src/remote_protocol-structs | 26 +++ .../nodedevmdevctldata/mdevctl-autostart.argv | 8 + tests/nodedevmdevctltest.c | 54 ++++++ tools/virsh-nodedev.c | 139 +++++++++++++++ 17 files changed, 727 insertions(+), 6 deletions(-) create mode 100644 tests/nodedevmdevctldata/mdevctl-autostart.argv -- 2.31.1

3 25

[PATCH v2 0/4] Ring support (Libvirt)
by huangy81＠chinatelecom.cn 23 Jun '21

23 Jun '21

From: Hyman Huang(黄勇) <huangy81(a)chinatelecom.cn> v2 - split patchset into 4 patches - leave out the tcg case when building commandline. - handle the VIR_DOMAIN_KVM_DIRTY_RING case independently in , virDomainFeatureDefParse and virDomainDefFeaturesCheckABIStability, do not integrate it with other cases... - add dirty ring size check in virDomainDefFeaturesCheckABIStability - modify zero checks on integers of dirty ring size in a explicit way. - set the default value of dirty ring size in a post-parser callback. - check the absence of kvm_feature in a explicit way. - code clean of virTristateSwitchTypeToString function. this version's modification base on Peter's advices mostly, thanks a lot, please review ! Best Regards ! Hyman Huang(黄勇) v1 since qemu has introduced a dirty ring feature in 6.1.0, may be it's the right time to introduce dirty ring in libvirt meanwhile. this patch add feature named 'dirty-ring', which enable dirty ring feature when starting vm. to try this out, three things has done in this patchset: - introduce QEMU_CAPS_ACCEL so the the libvirt can use it to select the right option when specifying the accelerator type. - switch the option "-machine accel=xxx" to "-accel xxx" when specifying accelerator type once libvirt build QEMU command line, so that dirty-ring-size property can be passed to qemu when start vm. - introduce dirty_ring_size to hold the ring size configured by user and pass dirty_ring_size when building qemu commandline if dirty ring feature enabled. though dirty ring is per-cpu logically, the size of dirty ring is registered by 'struct kvm' in QEMU. so we would like to place the dirty_ring_size as a property of vm in Libvirt as the QEMU do. the dirty ring feature is disabled by default, and if enabled, the default value of ring size if 4096 if size not configured. for more details about dirty ring and "-accel" option, please refer to: https://lore.kernel.org/qemu-devel/20210108165050.406906-10-peterx@redhat.c… https://lore.kernel.org/qemu-devel/3aa73987-40e8-3619-0723-9f17f73850bd@red… please review, Thanks! Best Regards ! Hyman Huang(黄勇) (4): qemu_capabilities: introduce QEMU_CAPS_ACCEL qemu_command: switch accelerator option to new style conf: introduce dirty_ring_size in struct "_virDomainDef" qemu: support dirty ring feature docs/formatdomain.rst | 16 +++--- docs/schemas/domaincommon.rng | 10 ++++ src/conf/domain_conf.c | 66 ++++++++++++++++++++++ src/conf/domain_conf.h | 4 ++ src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 42 +++++++++++++- tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_3.0.0.riscv32.xml | 1 + tests/qemucapabilitiesdata/caps_3.0.0.riscv64.xml | 1 + tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.riscv32.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.riscv64.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_4.1.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_5.0.0.riscv64.xml | 1 + tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_5.1.0.sparc.xml | 1 + tests/qemucapabilitiesdata/caps_5.1.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_5.2.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_5.2.0.riscv64.xml | 1 + tests/qemucapabilitiesdata/caps_5.2.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_6.0.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml | 1 + ...64-default-cpu-kvm-virt-4.2.aarch64-latest.args | 3 +- .../aarch64-features-sve.aarch64-latest.args | 3 +- .../channel-unix-guestfwd.x86_64-latest.args | 3 +- .../clock-timer-armvtimer.aarch64-latest.args | 3 +- .../console-virtio-unix.x86_64-latest.args | 3 +- .../cpu-Icelake-Server-pconfig.x86_64-3.1.0.args | 3 +- .../cpu-Icelake-Server-pconfig.x86_64-latest.args | 3 +- .../cpu-tsc-frequency.x86_64-4.0.0.args | 3 +- .../cpu-tsc-high-frequency.x86_64-latest.args | 3 +- .../default-video-type-aarch64.aarch64-latest.args | 3 +- .../default-video-type-ppc64.ppc64-latest.args | 3 +- .../default-video-type-s390x.s390x-latest.args | 3 +- .../disk-cdrom-network.x86_64-2.12.0.args | 3 +- .../disk-cdrom-network.x86_64-latest.args | 3 +- .../disk-network-http.x86_64-latest.args | 3 +- .../hugepages-memaccess3.x86_64-latest.args | 3 +- .../intel-iommu-aw-bits.x86_64-latest.args | 3 +- .../intel-iommu-caching-mode.x86_64-latest.args | 3 +- .../intel-iommu-device-iotlb.x86_64-latest.args | 3 +- .../intel-iommu-eim.x86_64-latest.args | 3 +- ...ty-sev-missing-platform-info.x86_64-2.12.0.args | 3 +- .../launch-security-sev.x86_64-2.12.0.args | 3 +- .../launch-security-sev.x86_64-6.0.0.args | 3 +- ...emfd-memory-default-hugepage.x86_64-latest.args | 3 +- .../memfd-memory-numa.x86_64-latest.args | 3 +- .../memory-hotplug-virtio-pmem.x86_64-5.2.0.args | 3 +- .../memory-hotplug-virtio-pmem.x86_64-latest.args | 3 +- .../os-firmware-bios.x86_64-latest.args | 3 +- ...irmware-efi-no-enrolled-keys.x86_64-latest.args | 3 +- .../os-firmware-efi-secboot.x86_64-latest.args | 3 +- .../os-firmware-efi.x86_64-latest.args | 3 +- .../parallel-unix-chardev.x86_64-latest.args | 3 +- ...4-default-cpu-kvm-pseries-2.7.ppc64-latest.args | 3 +- ...4-default-cpu-kvm-pseries-3.1.ppc64-latest.args | 3 +- ...4-default-cpu-kvm-pseries-4.2.ppc64-latest.args | 3 +- ...efault-cpu-kvm-ccw-virtio-2.7.s390x-latest.args | 3 +- ...efault-cpu-kvm-ccw-virtio-4.2.s390x-latest.args | 3 +- .../smartcard-passthrough-unix.x86_64-latest.args | 3 +- .../usb-redir-unix.x86_64-latest.args | 3 +- .../vhost-user-fs-fd-memory.x86_64-latest.args | 3 +- .../virtio-rng-builtin.x86_64-5.2.0.args | 3 +- .../virtio-rng-builtin.x86_64-latest.args | 3 +- .../virtio-rng-egd-unix.x86_64-5.2.0.args | 3 +- .../virtio-rng-egd-unix.x86_64-latest.args | 3 +- ...86_64-default-cpu-kvm-pc-4.2.x86_64-latest.args | 3 +- ...6_64-default-cpu-kvm-q35-4.2.x86_64-latest.args | 3 +- 91 files changed, 263 insertions(+), 54 deletions(-) -- 1.8.3.1

1 4

[PATCH] build: fix logic for enabling libssh/libssh2 checks
by Daniel P. Berrangé 23 Jun '21

23 Jun '21

When 'driver_remote' is 'auto', the 'enabled()' method does not evaluate to true, causing the libssh/libssh2 checks to be skipped. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 9caae5521b..1fab424fde 100644 --- a/meson.build +++ b/meson.build @@ -1005,7 +1005,7 @@ else endif libssh_version = '0.7' -if get_option('driver_remote').enabled() +if not get_option('driver_remote').disabled() libssh_dep = dependency('libssh', version: '>=' + libssh_version, required: get_option('libssh')) if libssh_dep.found() conf.set('WITH_LIBSSH', 1) @@ -1028,7 +1028,7 @@ else endif libssh2_version = '1.3' -if get_option('driver_remote').enabled() +if not get_option('driver_remote').disabled() libssh2_dep = dependency('libssh2', version: '>=' + libssh2_version, required: get_option('libssh2')) if libssh2_dep.found() conf.set('WITH_SSH2', 1) -- 2.31.1

2 1

[PATCH] rpc: prefer SHA256 host key fingerprint with new libssh
by Daniel P. Berrangé 23 Jun '21

23 Jun '21

The host key fingerprint for SSH servers is used in a scenario where cryptographic strength is important. We should thus be defaulting to use of SHA256 where available. We only need SHA1 for Ubuntu 18.04 which does not have libssh >= 0.8.1 Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/rpc/virnetlibsshsession.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/rpc/virnetlibsshsession.c b/src/rpc/virnetlibsshsession.c index 50ace5f41d..22d54c99be 100644 --- a/src/rpc/virnetlibsshsession.c +++ b/src/rpc/virnetlibsshsession.c @@ -39,6 +39,12 @@ VIR_LOG_INIT("rpc.netlibsshsession"); #define VIR_NET_LIBSSH_BUFFER_SIZE 1024 +#if LIBSSH_VERSION_INT < SSH_VERSION_INT(0, 8, 1) +# define VIR_SSH_HOSTKEY_HASH SSH_PUBLICKEY_HASH_SHA1 +#else +# define VIR_SSH_HOSTKEY_HASH SSH_PUBLICKEY_HASH_SHA256 +#endif + /* TRACE_LIBSSH=<level> enables tracing in libssh itself. * The meaning of <level> is described here: * https://api.libssh.org/master/group__libssh__log.html @@ -203,9 +209,10 @@ virLibsshServerKeyAsString(virNetLibsshSession *sess) return NULL; } - /* calculate remote key hash, using SHA1 algorithm that is - * usual in OpenSSH. The returned value must be freed */ - ret = ssh_get_publickey_hash(key, SSH_PUBLICKEY_HASH_SHA1, + /* calculate remote key hash, using SHA256 algorithm that is + * the default in modern OpenSSH, fallback to SHA1 for older + * libssh. The returned value must be freed */ + ret = ssh_get_publickey_hash(key, VIR_SSH_HOSTKEY_HASH, &keyhash, &keyhashlen); ssh_key_free(key); if (ret < 0) { -- 2.31.1

2 1

[PATCH v2] ci: Also perform package upgrades on macOS and FreeBSD
by Martin Kletzander 23 Jun '21

23 Jun '21

The base OS image might include outdated contents, and we don't want to get spurious failures caused by bugs that have already been fixed in the respective packages. This is particularly important on macOS, because 'brew install foo' will fail if 'foo' is already installed but outdated: upgrading all packages first ensures we never run into this scenario. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- .gitlab-ci.yml | 4 ++++ ci/cirrus/build.yml | 1 + 2 files changed, 5 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 3fa616261e93..3cb6ff5e6b26 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -115,6 +115,7 @@ stages: -e "s|[@]CIRRUS_VM_IMAGE_SELECTOR@|$CIRRUS_VM_IMAGE_SELECTOR|g" -e "s|[@]CIRRUS_VM_IMAGE_NAME@|$CIRRUS_VM_IMAGE_NAME|g" -e "s|[@]UPDATE_COMMAND@|$UPDATE_COMMAND|g" + -e "s|[@]UPGRADE_COMMAND@|$UPGRADE_COMMAND|g" -e "s|[@]INSTALL_COMMAND@|$INSTALL_COMMAND|g" -e "s|[@]PATH@|$PATH_EXTRA${PATH_EXTRA:+:}\$PATH|g" -e "s|[@]PKG_CONFIG_PATH@|$PKG_CONFIG_PATH|g" @@ -423,6 +424,7 @@ x64-freebsd-12-build: CIRRUS_VM_IMAGE_SELECTOR: image_family CIRRUS_VM_IMAGE_NAME: freebsd-12-2 UPDATE_COMMAND: pkg update + UPGRADE_COMMAND: pkg upgrade -y INSTALL_COMMAND: pkg install -y x64-freebsd-13-build: @@ -433,6 +435,7 @@ x64-freebsd-13-build: CIRRUS_VM_IMAGE_SELECTOR: image_family CIRRUS_VM_IMAGE_NAME: freebsd-13-0 UPDATE_COMMAND: pkg update + UPGRADE_COMMAND: pkg upgrade -y INSTALL_COMMAND: pkg install -y x64-macos-11-build: @@ -443,6 +446,7 @@ x64-macos-11-build: CIRRUS_VM_IMAGE_SELECTOR: image CIRRUS_VM_IMAGE_NAME: big-sur-base UPDATE_COMMAND: brew update + UPGRADE_COMMAND: brew upgrade INSTALL_COMMAND: brew install PATH_EXTRA: /usr/local/opt/ccache/libexec:/usr/local/opt/gettext/bin:/usr/local/opt/libpcap/bin:/usr/local/opt/libxslt/bin:/usr/local/opt/rpcgen/bin PKG_CONFIG_PATH: /usr/local/opt/curl/lib/pkgconfig:/usr/local/opt/libpcap/lib/pkgconfig:/usr/local/opt/libxml2/lib/pkgconfig:/usr/local/opt/ncurses/lib/pkgconfig:/usr/local/opt/readline/lib/pkgconfig diff --git a/ci/cirrus/build.yml b/ci/cirrus/build.yml index 39c17dc08a43..867d5f297b7e 100644 --- a/ci/cirrus/build.yml +++ b/ci/cirrus/build.yml @@ -15,6 +15,7 @@ env: build_task: install_script: - @UPDATE_COMMAND@ + - @UPGRADE_COMMAND@ - @INSTALL_COMMAND@ @PKGS@ - if test -n "@PYPI_PKGS@" ; then @PIP3@ install @PYPI_PKGS@ ; fi clone_script: -- 2.32.0

2 1

[PATCH v2] ui: Make the DisplayType enum entries conditional
by Thomas Huth 23 Jun '21

23 Jun '21

Libvirt's "domcapabilities" command has a way to state whether certain graphic frontends are available in QEMU or not. Originally, libvirt looked at the "--help" output of the QEMU binary to determine whether SDL was available or not (by looking for the "-sdl" parameter in the help text), but since libvirt stopped doing this analysis of the help text, the detection of SDL is currently broken, see: https://bugzilla.redhat.com/show_bug.cgi?id=1790902 QEMU should provide a way via the QMP interface instead. A simple way, without introducing additional commands, is to make the DisplayType enum entries conditional, so that the enum only contains the entries if the corresponding CONFIG_xxx switches have been set. This of course only gives an indication which possibilities have been enabled during compile-time of QEMU (and does not take into account whether modules are later available or not for example - for this we'd need a separate command), but anyway, this should already be good enough for the above bug ticket, and it's a good idea anyway to make the QMP interface conditional here, so let's simply do it. Signed-off-by: Thomas Huth <thuth(a)redhat.com> --- v2: Make gtk, curses and egl also conditional qapi/ui.json | 23 +++++++++++++++++------ softmmu/vl.c | 20 +++++++++++++++++--- ui/console.c | 8 +++++++- 3 files changed, 41 insertions(+), 10 deletions(-) diff --git a/qapi/ui.json b/qapi/ui.json index 1052ca9c38..6a667a0abf 100644 --- a/qapi/ui.json +++ b/qapi/ui.json @@ -1126,9 +1126,16 @@ # ## { 'enum' : 'DisplayType', - 'data' : [ 'default', 'none', 'gtk', 'sdl', - 'egl-headless', 'curses', 'cocoa', - 'spice-app'] } + 'data' : [ + { 'name': 'default' }, + { 'name': 'none' }, + { 'name': 'gtk', 'if': 'defined(CONFIG_GTK)' }, + { 'name': 'sdl', 'if': 'defined(CONFIG_SDL)' }, + { 'name': 'egl-headless', + 'if': 'defined(CONFIG_OPENGL) && defined(CONFIG_GBM)' }, + { 'name': 'curses', 'if': 'defined(CONFIG_CURSES)' }, + { 'name': 'cocoa', 'if': 'defined(CONFIG_COCOA)' }, + { 'name': 'spice-app', 'if': 'defined(CONFIG_SPICE)'} ] } ## # @DisplayOptions: @@ -1152,9 +1159,13 @@ '*show-cursor' : 'bool', '*gl' : 'DisplayGLMode' }, 'discriminator' : 'type', - 'data' : { 'gtk' : 'DisplayGTK', - 'curses' : 'DisplayCurses', - 'egl-headless' : 'DisplayEGLHeadless'} } + 'data' : { + 'gtk': { 'type': 'DisplayGTK', 'if': 'defined(CONFIG_GTK)' }, + 'curses': { 'type': 'DisplayCurses', 'if': 'defined(CONFIG_CURSES)' }, + 'egl-headless': { 'type': 'DisplayEGLHeadless', + 'if': 'defined(CONFIG_OPENGL) && defined(CONFIG_GBM)' } + } +} ## # @query-display-options: diff --git a/softmmu/vl.c b/softmmu/vl.c index 326c1e9080..fc103c2cb2 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -1068,6 +1068,7 @@ static void parse_display(const char *p) * Not clear yet what happens to them long-term. Should * replaced by something better or deprecated and dropped. */ +#if defined(CONFIG_SDL) dpy.type = DISPLAY_TYPE_SDL; while (*opts) { const char *nextopt; @@ -1131,6 +1132,10 @@ static void parse_display(const char *p) } opts = nextopt; } +#else + error_report("SDL display supported is not available in this binary"); + exit(1); +#endif } else if (strstart(p, "vnc", &opts)) { /* * vnc isn't a (local) DisplayType but a protocol for remote @@ -1867,13 +1872,22 @@ static void qemu_apply_machine_options(void) static void qemu_create_early_backends(void) { MachineClass *machine_class = MACHINE_GET_CLASS(current_machine); +#if defined(CONFIG_SDL) + const bool use_sdl = (dpy.type == DISPLAY_TYPE_SDL); +#else + const bool use_sdl = false; +#endif +#if defined(CONFIG_GTK) + const bool use_gtk = (dpy.type == DISPLAY_TYPE_GTK); +#else + const bool use_gtk = false; +#endif - if ((alt_grab || ctrl_grab) && dpy.type != DISPLAY_TYPE_SDL) { + if ((alt_grab || ctrl_grab) && !use_sdl) { error_report("-alt-grab and -ctrl-grab are only valid " "for SDL, ignoring option"); } - if (dpy.has_window_close && - (dpy.type != DISPLAY_TYPE_GTK && dpy.type != DISPLAY_TYPE_SDL)) { + if (dpy.has_window_close && !use_gtk && !use_sdl) { error_report("-no-quit is only valid for GTK and SDL, " "ignoring option"); } diff --git a/ui/console.c b/ui/console.c index 2de5f4105b..1103b65314 100644 --- a/ui/console.c +++ b/ui/console.c @@ -2370,13 +2370,19 @@ void qemu_display_register(QemuDisplay *ui) bool qemu_display_find_default(DisplayOptions *opts) { static DisplayType prio[] = { +#if defined(CONFIG_GTK) DISPLAY_TYPE_GTK, +#endif +#if defined(CONFIG_SDL) DISPLAY_TYPE_SDL, +#endif +#if defined(CONFIG_COCOA) DISPLAY_TYPE_COCOA +#endif }; int i; - for (i = 0; i < ARRAY_SIZE(prio); i++) { + for (i = 0; i < (int)ARRAY_SIZE(prio); i++) { if (dpys[prio[i]] == NULL) { ui_module_load_one(DisplayType_str(prio[i])); } -- 2.27.0

2 1

[PATCH] ci: Also perform `brew upgrade` on MacOS
by Martin Kletzander 23 Jun '21

23 Jun '21

Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- @Andrea: if you have a good explanation you'd like to put in the commit message, I'd me glad to add it (or you can do that as well). Thanks .gitlab-ci.yml | 2 ++ ci/cirrus/build.yml | 1 + 2 files changed, 3 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index b5930a0a46d5..6097047d9215 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -115,6 +115,7 @@ stages: -e "s|[@]CIRRUS_VM_IMAGE_SELECTOR@|$CIRRUS_VM_IMAGE_SELECTOR|g" -e "s|[@]CIRRUS_VM_IMAGE_NAME@|$CIRRUS_VM_IMAGE_NAME|g" -e "s|[@]UPDATE_COMMAND@|$UPDATE_COMMAND|g" + -e "s|[@]UPGRADE_COMMAND@|$UPGRADE_COMMAND|g" -e "s|[@]INSTALL_COMMAND@|$INSTALL_COMMAND|g" -e "s|[@]PATH@|$PATH_EXTRA${PATH_EXTRA:+:}\$PATH|g" -e "s|[@]PKG_CONFIG_PATH@|$PKG_CONFIG_PATH|g" @@ -443,6 +444,7 @@ x64-macos-11-build: CIRRUS_VM_IMAGE_SELECTOR: image CIRRUS_VM_IMAGE_NAME: big-sur-base UPDATE_COMMAND: brew update + UPGRADE_COMMAND: brew upgrade INSTALL_COMMAND: brew install PATH_EXTRA: /usr/local/opt/ccache/libexec:/usr/local/opt/gettext/bin:/usr/local/opt/libpcap/bin:/usr/local/opt/libxslt/bin:/usr/local/opt/rpcgen/bin PKG_CONFIG_PATH: /usr/local/opt/curl/lib/pkgconfig:/usr/local/opt/libpcap/lib/pkgconfig:/usr/local/opt/libxml2/lib/pkgconfig:/usr/local/opt/ncurses/lib/pkgconfig:/usr/local/opt/readline/lib/pkgconfig diff --git a/ci/cirrus/build.yml b/ci/cirrus/build.yml index 39c17dc08a43..867d5f297b7e 100644 --- a/ci/cirrus/build.yml +++ b/ci/cirrus/build.yml @@ -15,6 +15,7 @@ env: build_task: install_script: - @UPDATE_COMMAND@ + - @UPGRADE_COMMAND@ - @INSTALL_COMMAND@ @PKGS@ - if test -n "@PYPI_PKGS@" ; then @PIP3@ install @PYPI_PKGS@ ; fi clone_script: -- 2.31.1

2 5

[libvirt PATCH 00/16] Refactor virDomainFeaturesDefParse
by Tim Wiederhake 23 Jun '21

23 Jun '21

Some refactoring in preparation for adding support for qemu's "hv-passthrough" and the yet-to-be-merged "hv-defaults". Tim Wiederhake (16): virDomainFeaturesDefParse: Factor out HyperV parsing into separate function virDomainFeaturesHyperVDefParse: Inline hyperv/stimer parsing virDomainFeaturesHyperVDefParse: Remove ctxt virDomainFeaturesHyperVDefParse: Remove tautological "if" virDomainFeaturesDefParse: Factor out KVM parsing into separate function virDomainFeaturesKVMDefParse: Remove ctxt virDomainFeaturesKVMDefParse: Remove tautological "switch" virDomainFeaturesKVMDefParse: Remove tautological "if" virDomainFeaturesDefParse: Factor out XEN parsing into separate function virDomainFeaturesXENDefParse: Remove ctxt virDomainFeaturesXENDefParse: Remove tautological "if" virDomainFeaturesDefParse: Inline SMM parsing virDomainFeaturesDefParse: Inline MSRS parsing virDomainFeaturesDefParse: Factor out capabilities parsing into separate function virDomainFeaturesCapabilitiesDefParse: Remove ctxt virDomainFeaturesDefParse: Simplify APIC parsing src/conf/domain_conf.c | 557 ++++++++++++++++++++++------------------- 1 file changed, 296 insertions(+), 261 deletions(-) -- 2.31.1

2 17

[libvirt PATCH 0/3] wait longer for virtiofsd to exit (virtio-fs epopee)
by Ján Tomko 23 Jun '21

23 Jun '21

See patch 2/3. Ján Tomko (3): Introduce virPidFileForceCleanupPathDelay qemu: wait more for virtiofsd to exit util: fix typo src/libvirt_private.syms | 1 + src/qemu/qemu_virtiofs.c | 2 +- src/util/virpidfile.c | 16 +++++++++++++++- src/util/virpidfile.h | 2 ++ src/util/virprocess.c | 2 +- 5 files changed, 20 insertions(+), 3 deletions(-) -- 2.31.1

4 7

[libvirt PATCH] docs: Fix some typos
by Tim Wiederhake 22 Jun '21

22 Jun '21

Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com> --- docs/kbase/live_full_disk_backup.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/kbase/live_full_disk_backup.rst b/docs/kbase/live_full_disk_backup.rst index 1605ec05d2..562a9e87b0 100644 --- a/docs/kbase/live_full_disk_backup.rst +++ b/docs/kbase/live_full_disk_backup.rst @@ -97,7 +97,7 @@ virDomainBackupBegin() API: Assuming a guest with a single disk image, create a temporary live QCOW2 overlay (commonly called as "external snapshot") to track the live guest writes. Then backup the original disk image while the guest (live QEMU) keeps writing to the temporary -overlay. Finally, perform the "active block-commit" opertion to +overlay. Finally, perform the "active block-commit" operation to live-merge the temporary overlay disk contents into the original image — i.e. the backing file — and "pivot" the live QEMU process to point to it. @@ -138,7 +138,7 @@ it. you have to explicitly clean the libvirt metadata using ``virsh snapshot-delete vm1 --metadata [name|--current]``. -#. Now, take a backup the orignal image, ``base.raw``, to a different +#. Now, take a backup the original image, ``base.raw``, to a different location using ``cp`` or ``rsync``:: $ cp /var/lib/libvirt/images/base.raw -- 2.31.1

2 1

[RFC PATCH 0/7] LIBVIRT: X86: TDX support
by Zhenzhong Duan 22 Jun '21

22 Jun '21

* What's TDX? TDX stands for Trust Domain Extensions which isolates VMs from the virtual-machine manager (VMM)/hypervisor and any other software on the platform. To support TDX, multiple software components, not only KVM but also QEMU, guest Linux and virtual bios, need to be updated. For more details, please check link[1], there are TDX spec links and public repository link at github for each software component. This patchset is another software component to extend libvirt to support TDX, with which one can start a VM from high level rather than running qemu directly. * The goal of this RFC patch The purpose of this post is to get feedback early on high level design issue of libvirt enhancement for TDX. Referenced much on AMD SEV implemention at link[2]. * Patch organization - patch 1-2: Support query of TDX capabilities. - patch 3-6: Add a new xml element 'TrustDomain' for TDX support. - patch 7: Sure kvmSupportsSecureGuest cache updated. Using these patches we have succesfully booted and tested a guest both with and without TDX enabled. [1] https://lkml.org/lkml/2020/11/16/1106 [2] https://github.com/codomania/libvirt/commits/v9 Zhenzhong Duan (7): qemu: provide support to query the TDX capabilities conf: expose TDX feature in domain capabilities conf: introduce TrustDomain element in domain qemu: add support to launch TDX guest qemu: add support to TDVF firmware loader qemu: force special features enabled for TDX guest qemu: Check if INTEL Trust Domain Extention support is enabled docs/formatdomaincaps.html.in | 16 ++++ docs/schemas/domaincaps.rng | 9 ++ docs/schemas/domaincommon.rng | 19 ++++ src/conf/domain_capabilities.c | 22 +++++ src/conf/domain_capabilities.h | 11 +++ src/conf/domain_conf.c | 90 ++++++++++++++++++ src/conf/domain_conf.h | 16 ++++ src/conf/virconftypes.h | 2 + src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 63 ++++++++++++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 39 ++++++++ src/qemu/qemu_monitor.c | 8 ++ src/qemu/qemu_monitor.h | 3 + src/qemu/qemu_monitor_json.c | 53 +++++++++++ src/qemu/qemu_monitor_json.h | 3 + src/qemu/qemu_validate.c | 14 +++ tests/domaincapsdata/bhyve_basic.x86_64.xml | 1 + tests/domaincapsdata/bhyve_fbuf.x86_64.xml | 1 + tests/domaincapsdata/bhyve_uefi.x86_64.xml | 1 + tests/domaincapsdata/empty.xml | 1 + tests/domaincapsdata/libxl-xenfv.xml | 1 + tests/domaincapsdata/libxl-xenpv.xml | 1 + .../domaincapsdata/qemu_2.11.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.11.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.11.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.11.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.12.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.12.0-tcg.x86_64.xml | 1 + .../qemu_2.12.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.12.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.4.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.4.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.4.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.5.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.5.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.5.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.6.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.6.0-tcg.x86_64.xml | 1 + .../qemu_2.6.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.6.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.6.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_2.6.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.7.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.7.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.7.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.7.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.8.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.8.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.8.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.8.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.9.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.9.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.9.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_2.9.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.9.0.x86_64.xml | 1 + .../domaincapsdata/qemu_3.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_3.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_3.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_3.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_3.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_3.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_3.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_3.1.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_3.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_4.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.0.0-tcg.x86_64.xml | 1 + .../qemu_4.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_4.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 1 + .../qemu_4.2.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.0.0-tcg.x86_64.xml | 1 + .../qemu_5.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_5.1.0.sparc.xml | 1 + tests/domaincapsdata/qemu_5.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.2.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.2.0-tcg.x86_64.xml | 1 + .../qemu_5.2.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_5.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_6.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_6.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_6.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_6.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_6.1.0.x86_64.xml | 1 + .../genericxml2xmlindata/trust-domain-tdx.xml | 22 +++++ tests/genericxml2xmltest.c | 1 + .../.trust-domain-tdx.xml.swo | Bin 0 -> 12288 bytes tests/qemuxml2argvdata/trust-domain-tdx.args | 32 +++++++ tests/qemuxml2argvdata/trust-domain-tdx.xml | 37 +++++++ tests/qemuxml2argvtest.c | 3 + 115 files changed, 557 insertions(+) create mode 100644 tests/genericxml2xmlindata/trust-domain-tdx.xml create mode 100644 tests/qemuxml2argvdata/.trust-domain-tdx.xml.swo create mode 100644 tests/qemuxml2argvdata/trust-domain-tdx.args create mode 100644 tests/qemuxml2argvdata/trust-domain-tdx.xml -- 2.25.1

6 28

[PATCH 0/2] Dirty Ring support (Libvirt)
by huangy81＠chinatelecom.cn 21 Jun '21

21 Jun '21

From: Hyman Huang(黄勇) <huangy81(a)chinatelecom.cn> since qemu has introduced a dirty ring feature in 6.1.0, may be it's the right time to introduce dirty ring in libvirt meanwhile. this patch add feature named 'dirty-ring', which enable dirty ring feature when starting vm. to try this out, three things has done in this patchset: - introduce QEMU_CAPS_ACCEL so the the libvirt can use it to select the right option when specifying the accelerator type. - switch the option "-machine accel=xxx" to "-accel xxx" when specifying accelerator type once libvirt build QEMU command line, so that dirty-ring-size property can be passed to qemu when start vm. - introduce dirty_ring_size to hold the ring size configured by user and pass dirty_ring_size when building qemu commandline if dirty ring feature enabled. though dirty ring is per-cpu logically, the size of dirty ring is registered by 'struct kvm' in QEMU. so we would like to place the dirty_ring_size as a property of vm in Libvirt as the QEMU do. the dirty ring feature is disabled by default, and if enabled, the default value of ring size if 4096 if size not configured. for more details about dirty ring and "-accel" option, please refer to: https://lore.kernel.org/qemu-devel/20210108165050.406906-10-peterx@redhat.c… https://lore.kernel.org/qemu-devel/3aa73987-40e8-3619-0723-9f17f73850bd@red… please review, Thanks! Best Regards ! Hyman Huang(黄勇) (2): qemu_capabilities: Introduce QEMU_CAPS_ACCEL qemu: support dirty ring feature docs/formatdomain.rst | 16 ++-- docs/schemas/domaincommon.rng | 10 ++ src/conf/domain_conf.c | 43 +++++++++ src/conf/domain_conf.h | 4 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 103 ++++++++++++++++++--- tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_3.0.0.riscv32.xml | 1 + tests/qemucapabilitiesdata/caps_3.0.0.riscv64.xml | 1 + tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.riscv32.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.riscv64.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_4.1.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_5.0.0.riscv64.xml | 1 + tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_5.1.0.sparc.xml | 1 + tests/qemucapabilitiesdata/caps_5.1.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_5.2.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_5.2.0.riscv64.xml | 1 + tests/qemucapabilitiesdata/caps_5.2.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_6.0.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml | 1 + ...64-default-cpu-kvm-virt-4.2.aarch64-latest.args | 3 +- ...64-default-cpu-tcg-virt-4.2.aarch64-latest.args | 3 +- .../aarch64-features-sve.aarch64-latest.args | 3 +- .../aarch64-os-firmware-efi.aarch64-latest.args | 3 +- .../aarch64-tpm.aarch64-latest.args | 3 +- .../aarch64-virt-graphics.aarch64-latest.args | 3 +- .../aarch64-virt-headless.aarch64-latest.args | 3 +- .../audio-alsa-best.x86_64-latest.args | 3 +- .../audio-alsa-full.x86_64-latest.args | 3 +- .../audio-alsa-minimal.x86_64-latest.args | 3 +- .../audio-coreaudio-best.x86_64-latest.args | 3 +- .../audio-coreaudio-full.x86_64-latest.args | 3 +- .../audio-coreaudio-minimal.x86_64-latest.args | 3 +- .../audio-default-nographics.x86_64-latest.args | 3 +- .../audio-default-sdl.x86_64-latest.args | 3 +- .../audio-default-spice.x86_64-latest.args | 3 +- .../audio-default-vnc.x86_64-latest.args | 3 +- .../audio-file-best.x86_64-latest.args | 3 +- .../audio-file-full.x86_64-latest.args | 3 +- .../audio-file-minimal.x86_64-latest.args | 3 +- .../audio-jack-full.x86_64-latest.args | 3 +- .../audio-jack-minimal.x86_64-latest.args | 3 +- .../audio-many-backends.x86_64-latest.args | 3 +- .../audio-none-best.x86_64-latest.args | 3 +- .../audio-none-full.x86_64-latest.args | 3 +- .../audio-none-minimal.x86_64-latest.args | 3 +- .../audio-oss-best.x86_64-latest.args | 3 +- .../audio-oss-full.x86_64-latest.args | 3 +- .../audio-oss-minimal.x86_64-latest.args | 3 +- .../audio-pulseaudio-best.x86_64-latest.args | 3 +- .../audio-pulseaudio-full.x86_64-latest.args | 3 +- .../audio-pulseaudio-minimal.x86_64-latest.args | 3 +- .../audio-sdl-best.x86_64-latest.args | 3 +- .../audio-sdl-full.x86_64-latest.args | 3 +- .../audio-sdl-minimal.x86_64-latest.args | 3 +- .../audio-spice-best.x86_64-latest.args | 3 +- .../audio-spice-full.x86_64-latest.args | 3 +- .../audio-spice-minimal.x86_64-latest.args | 3 +- .../blkdeviotune-group-num.x86_64-4.1.0.args | 3 +- .../blkdeviotune-group-num.x86_64-latest.args | 3 +- .../blkdeviotune-max-length.x86_64-4.1.0.args | 3 +- .../blkdeviotune-max-length.x86_64-latest.args | 3 +- .../blkdeviotune-max.x86_64-4.1.0.args | 3 +- .../blkdeviotune-max.x86_64-latest.args | 3 +- .../channel-unix-guestfwd.x86_64-latest.args | 3 +- .../clock-timer-armvtimer.aarch64-latest.args | 3 +- .../console-sclp.s390x-latest.args | 3 +- .../console-virtio-unix.x86_64-latest.args | 3 +- .../controller-virtio-scsi.x86_64-latest.args | 3 +- .../cpu-Icelake-Server-pconfig.x86_64-3.1.0.args | 3 +- .../cpu-Icelake-Server-pconfig.x86_64-latest.args | 3 +- .../cpu-host-model-cmt.x86_64-4.0.0.args | 3 +- .../cpu-translation.x86_64-4.0.0.args | 3 +- .../cpu-translation.x86_64-latest.args | 3 +- .../cpu-tsc-frequency.x86_64-4.0.0.args | 3 +- .../cpu-tsc-high-frequency.x86_64-latest.args | 3 +- .../cputune-cpuset-big-id.x86_64-latest.args | 3 +- .../default-video-type-aarch64.aarch64-latest.args | 3 +- .../default-video-type-ppc64.ppc64-latest.args | 3 +- .../default-video-type-riscv64.riscv64-latest.args | 3 +- .../default-video-type-s390x.s390x-latest.args | 3 +- .../devices-acpi-index.x86_64-latest.args | 3 +- .../disk-aio-io_uring.x86_64-latest.args | 3 +- tests/qemuxml2argvdata/disk-aio.x86_64-2.12.0.args | 3 +- tests/qemuxml2argvdata/disk-aio.x86_64-latest.args | 3 +- .../disk-arm-virtio-sd.aarch64-4.0.0.args | 3 +- .../disk-arm-virtio-sd.aarch64-latest.args | 3 +- .../disk-backing-chains-noindex.x86_64-2.12.0.args | 3 +- .../disk-backing-chains-noindex.x86_64-latest.args | 3 +- .../qemuxml2argvdata/disk-cache.x86_64-2.12.0.args | 3 +- .../qemuxml2argvdata/disk-cache.x86_64-latest.args | 3 +- .../disk-cdrom-bus-other.x86_64-latest.args | 3 +- ...-cdrom-empty-network-invalid.x86_64-latest.args | 3 +- .../disk-cdrom-network.x86_64-2.12.0.args | 3 +- .../disk-cdrom-network.x86_64-latest.args | 3 +- .../disk-cdrom-tray.x86_64-2.12.0.args | 3 +- .../disk-cdrom-tray.x86_64-latest.args | 3 +- .../qemuxml2argvdata/disk-cdrom.x86_64-2.12.0.args | 3 +- .../qemuxml2argvdata/disk-cdrom.x86_64-latest.args | 3 +- .../disk-copy_on_read.x86_64-2.12.0.args | 3 +- .../disk-copy_on_read.x86_64-latest.args | 3 +- .../disk-detect-zeroes.x86_64-2.12.0.args | 3 +- .../disk-detect-zeroes.x86_64-latest.args | 3 +- .../disk-discard.x86_64-4.1.0.args | 3 +- .../disk-discard.x86_64-latest.args | 3 +- .../disk-error-policy-s390x.s390x-2.12.0.args | 3 +- .../disk-error-policy-s390x.s390x-latest.args | 3 +- .../disk-error-policy.x86_64-2.12.0.args | 3 +- .../disk-error-policy.x86_64-latest.args | 3 +- .../disk-floppy-q35-2_11.x86_64-2.12.0.args | 3 +- .../disk-floppy-q35-2_11.x86_64-latest.args | 3 +- .../disk-floppy-q35-2_9.x86_64-2.12.0.args | 3 +- .../disk-floppy-q35-2_9.x86_64-latest.args | 3 +- .../disk-floppy.x86_64-2.12.0.args | 3 +- .../disk-floppy.x86_64-latest.args | 3 +- .../disk-metadata-cache.x86_64-latest.args | 3 +- .../disk-network-gluster.x86_64-2.12.0.args | 3 +- .../disk-network-gluster.x86_64-latest.args | 3 +- .../disk-network-http.x86_64-latest.args | 3 +- .../disk-network-iscsi.x86_64-2.12.0.args | 3 +- .../disk-network-iscsi.x86_64-latest.args | 3 +- .../disk-network-nbd.x86_64-2.12.0.args | 3 +- .../disk-network-nbd.x86_64-latest.args | 3 +- .../disk-network-nfs.x86_64-latest.args | 3 +- .../disk-network-rbd.x86_64-2.12.0.args | 3 +- .../disk-network-rbd.x86_64-latest.args | 3 +- .../disk-network-sheepdog.x86_64-2.12.0.args | 3 +- .../disk-network-sheepdog.x86_64-6.0.0.args | 3 +- .../disk-network-source-auth.x86_64-2.12.0.args | 3 +- .../disk-network-source-auth.x86_64-latest.args | 3 +- .../disk-network-tlsx509-nbd.x86_64-2.12.0.args | 3 +- .../disk-network-tlsx509-nbd.x86_64-5.2.0.args | 3 +- .../disk-network-tlsx509-nbd.x86_64-latest.args | 3 +- .../disk-network-tlsx509-vxhs.x86_64-2.12.0.args | 3 +- .../disk-network-tlsx509-vxhs.x86_64-5.0.0.args | 3 +- .../qemuxml2argvdata/disk-nvme.x86_64-latest.args | 3 +- .../disk-readonly-disk.x86_64-2.12.0.args | 3 +- .../disk-readonly-disk.x86_64-latest.args | 3 +- .../disk-rotation.x86_64-latest.args | 3 +- .../disk-scsi-device-auto.x86_64-latest.args | 3 +- .../qemuxml2argvdata/disk-scsi.x86_64-latest.args | 3 +- .../disk-shared.x86_64-2.12.0.args | 3 +- .../disk-shared.x86_64-latest.args | 3 +- .../disk-slices.x86_64-latest.args | 3 +- .../disk-transient.x86_64-latest.args | 3 +- .../disk-vhostuser.x86_64-latest.args | 3 +- ...isk-virtio-scsi-reservations.x86_64-2.12.0.args | 3 +- ...disk-virtio-scsi-reservations.x86_64-5.2.0.args | 3 +- ...isk-virtio-scsi-reservations.x86_64-latest.args | 3 +- .../eoi-disabled.x86_64-4.0.0.args | 3 +- .../eoi-disabled.x86_64-latest.args | 3 +- .../qemuxml2argvdata/eoi-enabled.x86_64-4.0.0.args | 3 +- .../eoi-enabled.x86_64-latest.args | 3 +- .../fips-enabled.x86_64-5.1.0.args | 3 +- .../fips-enabled.x86_64-latest.args | 3 +- .../floppy-drive-fat.x86_64-2.12.0.args | 3 +- .../floppy-drive-fat.x86_64-latest.args | 3 +- tests/qemuxml2argvdata/fs9p-ccw.s390x-latest.args | 3 +- tests/qemuxml2argvdata/fs9p.x86_64-latest.args | 3 +- .../qemuxml2argvdata/genid-auto.x86_64-latest.args | 3 +- tests/qemuxml2argvdata/genid.x86_64-latest.args | 3 +- ...hics-egl-headless-rendernode.x86_64-latest.args | 3 +- .../graphics-egl-headless.x86_64-latest.args | 3 +- ...ics-spice-gl-auto-rendernode.x86_64-latest.args | 3 +- .../graphics-vnc-power.x86_64-latest.args | 3 +- .../graphics-vnc-tls-secret.x86_64-5.2.0.args | 3 +- .../graphics-vnc-tls-secret.x86_64-latest.args | 3 +- .../graphics-vnc-tls.x86_64-latest.args | 3 +- .../hostdev-mdev-display-ramfb.x86_64-latest.args | 3 +- ...v-display-spice-egl-headless.x86_64-latest.args | 3 +- ...ev-mdev-display-spice-opengl.x86_64-latest.args | 3 +- ...dev-display-vnc-egl-headless.x86_64-latest.args | 3 +- .../hostdev-mdev-display-vnc.x86_64-latest.args | 3 +- .../hostdev-scsi-lsi.x86_64-4.1.0.args | 3 +- .../hostdev-scsi-lsi.x86_64-latest.args | 3 +- .../hostdev-scsi-virtio-scsi.x86_64-4.1.0.args | 3 +- .../hostdev-scsi-virtio-scsi.x86_64-latest.args | 3 +- .../hostdev-subsys-mdev-vfio-ap.s390x-latest.args | 3 +- ...dev-subsys-mdev-vfio-ccw-boot.s390x-latest.args | 3 +- .../hugepages-memaccess3.x86_64-latest.args | 3 +- .../hugepages-nvdimm.x86_64-latest.args | 3 +- .../qemuxml2argvdata/hyperv-off.x86_64-4.0.0.args | 3 +- .../qemuxml2argvdata/hyperv-off.x86_64-latest.args | 3 +- .../hyperv-panic.x86_64-4.0.0.args | 3 +- .../hyperv-panic.x86_64-latest.args | 3 +- .../hyperv-stimer-direct.x86_64-latest.args | 3 +- tests/qemuxml2argvdata/hyperv.x86_64-4.0.0.args | 3 +- tests/qemuxml2argvdata/hyperv.x86_64-latest.args | 3 +- .../input-linux.x86_64-latest.args | 3 +- .../intel-iommu-aw-bits.x86_64-latest.args | 3 +- .../intel-iommu-caching-mode.x86_64-latest.args | 3 +- .../intel-iommu-device-iotlb.x86_64-latest.args | 3 +- .../intel-iommu-eim.x86_64-latest.args | 3 +- .../intel-iommu.x86_64-latest.args | 3 +- .../iommu-smmuv3.aarch64-latest.args | 3 +- .../iothreads-virtio-scsi-ccw.s390x-latest.args | 3 +- .../iothreads-virtio-scsi-pci.x86_64-5.2.0.args | 3 +- .../iothreads-virtio-scsi-pci.x86_64-latest.args | 3 +- .../kvmclock+eoi-disabled.x86_64-4.0.0.args | 3 +- .../kvmclock+eoi-disabled.x86_64-latest.args | 3 +- ...ty-sev-missing-platform-info.x86_64-2.12.0.args | 3 +- .../launch-security-sev.x86_64-2.12.0.args | 3 +- .../launch-security-sev.x86_64-6.0.0.args | 3 +- .../luks-disks-source-qcow2.x86_64-5.2.0.args | 3 +- .../luks-disks-source-qcow2.x86_64-latest.args | 3 +- ...emfd-memory-default-hugepage.x86_64-latest.args | 3 +- .../memfd-memory-numa.x86_64-latest.args | 3 +- ...memory-hotplug-nvdimm-access.x86_64-latest.args | 3 +- .../memory-hotplug-nvdimm-align.x86_64-5.2.0.args | 3 +- .../memory-hotplug-nvdimm-align.x86_64-latest.args | 3 +- .../memory-hotplug-nvdimm-label.x86_64-5.2.0.args | 3 +- .../memory-hotplug-nvdimm-label.x86_64-latest.args | 3 +- .../memory-hotplug-nvdimm-pmem.x86_64-5.2.0.args | 3 +- .../memory-hotplug-nvdimm-pmem.x86_64-latest.args | 3 +- ...emory-hotplug-nvdimm-readonly.x86_64-5.2.0.args | 3 +- ...mory-hotplug-nvdimm-readonly.x86_64-latest.args | 3 +- .../memory-hotplug-nvdimm.x86_64-latest.args | 3 +- .../memory-hotplug-virtio-pmem.x86_64-5.2.0.args | 3 +- .../memory-hotplug-virtio-pmem.x86_64-latest.args | 3 +- tests/qemuxml2argvdata/mlock-off.x86_64-3.0.0.args | 3 +- .../qemuxml2argvdata/mlock-off.x86_64-latest.args | 3 +- tests/qemuxml2argvdata/mlock-on.x86_64-3.0.0.args | 3 +- tests/qemuxml2argvdata/mlock-on.x86_64-latest.args | 3 +- tests/qemuxml2argvdata/net-user.x86_64-4.0.0.args | 3 +- tests/qemuxml2argvdata/net-vdpa.x86_64-latest.args | 3 +- .../net-vhostuser.x86_64-latest.args | 3 +- .../numatune-hmat.x86_64-latest.args | 3 +- ...une-memnode-restrictive-mode.x86_64-latest.args | 3 +- .../numatune-memnode.x86_64-5.2.0.args | 3 +- .../numatune-memnode.x86_64-latest.args | 3 +- .../os-firmware-bios.x86_64-latest.args | 3 +- ...irmware-efi-no-enrolled-keys.x86_64-latest.args | 3 +- .../os-firmware-efi-secboot.x86_64-latest.args | 3 +- .../os-firmware-efi.x86_64-latest.args | 3 +- .../parallel-unix-chardev.x86_64-latest.args | 3 +- .../pcie-root-port-nohotplug.x86_64-latest.args | 3 +- ...4-default-cpu-kvm-pseries-2.7.ppc64-latest.args | 3 +- ...4-default-cpu-kvm-pseries-3.1.ppc64-latest.args | 3 +- ...4-default-cpu-kvm-pseries-4.2.ppc64-latest.args | 3 +- ...4-default-cpu-tcg-pseries-2.7.ppc64-latest.args | 3 +- ...4-default-cpu-tcg-pseries-3.1.ppc64-latest.args | 3 +- ...4-default-cpu-tcg-pseries-4.2.ppc64-latest.args | 3 +- .../ppc64-pseries-graphics.ppc64-latest.args | 3 +- .../ppc64-pseries-headless.ppc64-latest.args | 3 +- .../ppc64-tpmproxy-single.ppc64-latest.args | 3 +- .../ppc64-tpmproxy-with-tpm.ppc64-latest.args | 3 +- .../pv-spinlock-disabled.x86_64-4.0.0.args | 3 +- .../pv-spinlock-disabled.x86_64-latest.args | 3 +- .../pv-spinlock-enabled.x86_64-4.0.0.args | 3 +- .../pv-spinlock-enabled.x86_64-latest.args | 3 +- tests/qemuxml2argvdata/qemu-ns.x86_64-4.0.0.args | 3 +- tests/qemuxml2argvdata/qemu-ns.x86_64-latest.args | 3 +- .../riscv64-virt-graphics.riscv64-latest.args | 3 +- .../riscv64-virt-headless.riscv64-latest.args | 3 +- ...90-allow-bogus-usb-controller.s390x-latest.args | 3 +- .../s390-allow-bogus-usb-none.s390x-latest.args | 3 +- ...efault-cpu-kvm-ccw-virtio-2.7.s390x-latest.args | 3 +- ...efault-cpu-kvm-ccw-virtio-4.2.s390x-latest.args | 3 +- ...efault-cpu-tcg-ccw-virtio-2.7.s390x-latest.args | 3 +- ...efault-cpu-tcg-ccw-virtio-4.2.s390x-latest.args | 3 +- .../s390x-ccw-graphics.s390x-latest.args | 3 +- .../s390x-ccw-headless.s390x-latest.args | 3 +- .../serial-unix-chardev.x86_64-latest.args | 3 +- .../smartcard-passthrough-unix.x86_64-latest.args | 3 +- .../tpm-emulator-spapr.ppc64-latest.args | 3 +- .../tpm-emulator-tpm2-enc.x86_64-latest.args | 3 +- .../tpm-emulator-tpm2-pstate.x86_64-latest.args | 3 +- .../tpm-emulator-tpm2.x86_64-latest.args | 3 +- .../tpm-emulator.x86_64-latest.args | 3 +- .../tpm-passthrough-crb.x86_64-latest.args | 3 +- .../tpm-passthrough.x86_64-latest.args | 3 +- .../tseg-explicit-size.x86_64-latest.args | 3 +- .../usb-redir-unix.x86_64-latest.args | 3 +- .../vhost-user-fs-fd-memory.x86_64-latest.args | 3 +- .../vhost-user-fs-hugepages.x86_64-latest.args | 3 +- .../vhost-user-gpu-secondary.x86_64-latest.args | 3 +- .../vhost-user-vga.x86_64-latest.args | 3 +- .../vhost-vsock-auto.x86_64-latest.args | 3 +- .../vhost-vsock-ccw-auto.s390x-latest.args | 3 +- .../vhost-vsock-ccw-iommu.s390x-latest.args | 3 +- .../vhost-vsock-ccw.s390x-latest.args | 3 +- .../vhost-vsock.x86_64-latest.args | 3 +- .../video-bochs-display-device.x86_64-latest.args | 3 +- .../video-qxl-device-vram64.x86_64-latest.args | 3 +- .../video-qxl-sec-device-vram64.x86_64-latest.args | 3 +- .../video-ramfb-display-device.x86_64-latest.args | 3 +- .../video-virtio-vga-gpu-gl.x86_64-latest.args | 3 +- .../virtio-9p-createmode.x86_64-latest.args | 3 +- .../virtio-9p-multidevs.x86_64-latest.args | 3 +- .../virtio-non-transitional.x86_64-3.1.0.args | 3 +- .../virtio-non-transitional.x86_64-latest.args | 3 +- ...irtio-options-controller-ats.x86_64-latest.args | 3 +- ...tio-options-controller-iommu.x86_64-latest.args | 3 +- ...io-options-controller-packed.x86_64-latest.args | 3 +- .../virtio-options-disk-ats.x86_64-latest.args | 3 +- .../virtio-options-disk-iommu.x86_64-latest.args | 3 +- .../virtio-options-disk-packed.x86_64-latest.args | 3 +- .../virtio-options-fs-ats.x86_64-latest.args | 3 +- .../virtio-options-fs-iommu.x86_64-latest.args | 3 +- .../virtio-options-fs-packed.x86_64-latest.args | 3 +- .../virtio-options-input-ats.x86_64-latest.args | 3 +- .../virtio-options-input-iommu.x86_64-latest.args | 3 +- .../virtio-options-input-packed.x86_64-latest.args | 3 +- ...irtio-options-memballoon-ats.x86_64-latest.args | 3 +- ...emballoon-freepage-reporting.x86_64-latest.args | 3 +- ...tio-options-memballoon-iommu.x86_64-latest.args | 3 +- ...io-options-memballoon-packed.x86_64-latest.args | 3 +- .../virtio-options-net-ats.x86_64-latest.args | 3 +- .../virtio-options-net-iommu.x86_64-latest.args | 3 +- .../virtio-options-net-packed.x86_64-latest.args | 3 +- .../virtio-options-rng-ats.x86_64-latest.args | 3 +- .../virtio-options-rng-iommu.x86_64-latest.args | 3 +- .../virtio-options-rng-packed.x86_64-latest.args | 3 +- .../virtio-options-video-ats.x86_64-latest.args | 3 +- .../virtio-options-video-iommu.x86_64-latest.args | 3 +- .../virtio-options-video-packed.x86_64-latest.args | 3 +- .../virtio-options.x86_64-latest.args | 3 +- .../virtio-rng-builtin.x86_64-5.2.0.args | 3 +- .../virtio-rng-builtin.x86_64-latest.args | 3 +- .../virtio-rng-egd-unix.x86_64-5.2.0.args | 3 +- .../virtio-rng-egd-unix.x86_64-latest.args | 3 +- .../virtio-transitional.x86_64-3.1.0.args | 3 +- .../virtio-transitional.x86_64-latest.args | 3 +- .../watchdog-diag288.s390x-latest.args | 3 +- ...86_64-default-cpu-kvm-pc-4.2.x86_64-latest.args | 3 +- ...6_64-default-cpu-kvm-q35-4.2.x86_64-latest.args | 3 +- ...86_64-default-cpu-tcg-pc-4.2.x86_64-latest.args | 3 +- ...6_64-default-cpu-tcg-q35-4.2.x86_64-latest.args | 3 +- .../x86_64-pc-graphics.x86_64-latest.args | 3 +- .../x86_64-pc-headless.x86_64-latest.args | 3 +- .../x86_64-q35-graphics.x86_64-latest.args | 3 +- .../x86_64-q35-headless.x86_64-latest.args | 3 +- 357 files changed, 820 insertions(+), 333 deletions(-) -- 1.8.3.1

3 4

[PATCH] chValidateDomainDeviceDef: Remove per-device-type error messages
by Peter Krempa 21 Jun '21

21 Jun '21

Vast majority of device types is not supported by the Cloud-Hypervisor driver. Simplify the error reporting by using virDomainDeviceTypeToString. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/ch/ch_domain.c | 90 +++++++--------------------------------------- 1 file changed, 12 insertions(+), 78 deletions(-) diff --git a/src/ch/ch_domain.c b/src/ch/ch_domain.c index 3495ee22ff..780a46ba00 100644 --- a/src/ch/ch_domain.c +++ b/src/ch/ch_domain.c @@ -203,117 +203,51 @@ chValidateDomainDeviceDef(const virDomainDeviceDef *dev, void *opaque G_GNUC_UNUSED, void *parseOpaque G_GNUC_UNUSED) { - int ret = -1; - switch ((virDomainDeviceType)dev->type) { case VIR_DOMAIN_DEVICE_DISK: - ret = 0; + case VIR_DOMAIN_DEVICE_NET: + case VIR_DOMAIN_DEVICE_MEMORY: + case VIR_DOMAIN_DEVICE_VSOCK: break; + case VIR_DOMAIN_DEVICE_LEASE: - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support lease")); - break; case VIR_DOMAIN_DEVICE_FS: - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support fs")); - break; - case VIR_DOMAIN_DEVICE_NET: - ret = 0; - break; case VIR_DOMAIN_DEVICE_INPUT: - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support input")); - break; case VIR_DOMAIN_DEVICE_SOUND: - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support sound")); - break; case VIR_DOMAIN_DEVICE_VIDEO: - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support video")); - break; case VIR_DOMAIN_DEVICE_HOSTDEV: - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support hostdev")); - break; case VIR_DOMAIN_DEVICE_WATCHDOG: - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support watchdog")); - break; case VIR_DOMAIN_DEVICE_CONTROLLER: - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support controller")); - break; case VIR_DOMAIN_DEVICE_GRAPHICS: - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support graphics")); - break; case VIR_DOMAIN_DEVICE_HUB: - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support hub")); - break; case VIR_DOMAIN_DEVICE_REDIRDEV: - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support redirdev")); - break; case VIR_DOMAIN_DEVICE_SMARTCARD: - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support smartcard")); - break; case VIR_DOMAIN_DEVICE_CHR: - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support chr")); - break; case VIR_DOMAIN_DEVICE_MEMBALLOON: - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support memballoon")); - break; case VIR_DOMAIN_DEVICE_NVRAM: - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support nvram")); - break; case VIR_DOMAIN_DEVICE_RNG: - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support rng")); - break; case VIR_DOMAIN_DEVICE_SHMEM: - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support shmem")); - break; case VIR_DOMAIN_DEVICE_TPM: - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support tpm")); - break; case VIR_DOMAIN_DEVICE_PANIC: - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support panic")); - break; - case VIR_DOMAIN_DEVICE_MEMORY: - ret = 0; - break; case VIR_DOMAIN_DEVICE_IOMMU: - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support iommu")); - break; - case VIR_DOMAIN_DEVICE_VSOCK: - ret = 0; - break; case VIR_DOMAIN_DEVICE_AUDIO: - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support audio")); - break; + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Cloud-Hypervisor doesn't support '%s' device"), + virDomainDeviceTypeToString(dev->type)); + return -1; + case VIR_DOMAIN_DEVICE_NONE: virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("unexpected VIR_DOMAIN_DEVICE_NONE")); - break; + return -1; case VIR_DOMAIN_DEVICE_LAST: default: virReportEnumRangeError(virDomainDeviceType, dev->type); - break; + return -1; } - return ret; + return 0; } virDomainDefParserConfig virCHDriverDomainDefParserConfig = { -- 2.31.1

2 1

[libvirt PATCH] virresctrl: fix starting VMs with cputune.memorytune specified
by Pavel Hrdina 21 Jun '21

21 Jun '21

When removing check for return value of VIR_EXPAND_N this place was incorrectly modified causing failure to start a VM with cputune memorytune configured with useless error message: error: Failed to start domain 'vm1' error: An error occurred, but the cause is unknown Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1973094 Fixes: 7d2fd6ef0163a939adb7ce0f0fad3b7654c340de Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/util/virresctrl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c index a03113d4d6..35e92022db 100644 --- a/src/util/virresctrl.c +++ b/src/util/virresctrl.c @@ -1437,7 +1437,6 @@ virResctrlAllocParseProcessMemoryBandwidth(virResctrlInfo *resctrl, if (alloc->mem_bw->nbandwidths <= id) { VIR_EXPAND_N(alloc->mem_bw->bandwidths, alloc->mem_bw->nbandwidths, id - alloc->mem_bw->nbandwidths + 1); - return -1; } if (!alloc->mem_bw->bandwidths[id]) alloc->mem_bw->bandwidths[id] = g_new0(unsigned int, 1); -- 2.31.1

3 2

[PATCHv2] ch_domain: Add handler for virDomainDeviceDefValidateCallback
by William Douglas 21 Jun '21

21 Jun '21

Instead of trying to match devices passed in based on the monitor detecting the number of devices that were used in the domain definition, use the deviceValidateCallback to evaluate if unsupported devices are used. This allows the compiler to detect when new device types are added that need to be checked. Signed-off-by: William Douglas <william.douglas(a)intel.com> --- The only change from the previous version was to switch to use the XML validation callback based on the great explanations from Michal and Peter. --- src/ch/ch_domain.c | 120 +++++++++++++++++++++++++++++++++++++++++++ src/ch/ch_monitor.c | 122 -------------------------------------------- 2 files changed, 120 insertions(+), 122 deletions(-) diff --git a/src/ch/ch_domain.c b/src/ch/ch_domain.c index f9a6f3f31d..3495ee22ff 100644 --- a/src/ch/ch_domain.c +++ b/src/ch/ch_domain.c @@ -197,7 +197,127 @@ virCHDomainDefPostParse(virDomainDef *def, return 0; } +static int +chValidateDomainDeviceDef(const virDomainDeviceDef *dev, + const virDomainDef *def G_GNUC_UNUSED, + void *opaque G_GNUC_UNUSED, + void *parseOpaque G_GNUC_UNUSED) +{ + int ret = -1; + + switch ((virDomainDeviceType)dev->type) { + case VIR_DOMAIN_DEVICE_DISK: + ret = 0; + break; + case VIR_DOMAIN_DEVICE_LEASE: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support lease")); + break; + case VIR_DOMAIN_DEVICE_FS: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support fs")); + break; + case VIR_DOMAIN_DEVICE_NET: + ret = 0; + break; + case VIR_DOMAIN_DEVICE_INPUT: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support input")); + break; + case VIR_DOMAIN_DEVICE_SOUND: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support sound")); + break; + case VIR_DOMAIN_DEVICE_VIDEO: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support video")); + break; + case VIR_DOMAIN_DEVICE_HOSTDEV: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support hostdev")); + break; + case VIR_DOMAIN_DEVICE_WATCHDOG: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support watchdog")); + break; + case VIR_DOMAIN_DEVICE_CONTROLLER: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support controller")); + break; + case VIR_DOMAIN_DEVICE_GRAPHICS: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support graphics")); + break; + case VIR_DOMAIN_DEVICE_HUB: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support hub")); + break; + case VIR_DOMAIN_DEVICE_REDIRDEV: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support redirdev")); + break; + case VIR_DOMAIN_DEVICE_SMARTCARD: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support smartcard")); + break; + case VIR_DOMAIN_DEVICE_CHR: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support chr")); + break; + case VIR_DOMAIN_DEVICE_MEMBALLOON: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support memballoon")); + break; + case VIR_DOMAIN_DEVICE_NVRAM: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support nvram")); + break; + case VIR_DOMAIN_DEVICE_RNG: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support rng")); + break; + case VIR_DOMAIN_DEVICE_SHMEM: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support shmem")); + break; + case VIR_DOMAIN_DEVICE_TPM: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support tpm")); + break; + case VIR_DOMAIN_DEVICE_PANIC: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support panic")); + break; + case VIR_DOMAIN_DEVICE_MEMORY: + ret = 0; + break; + case VIR_DOMAIN_DEVICE_IOMMU: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support iommu")); + break; + case VIR_DOMAIN_DEVICE_VSOCK: + ret = 0; + break; + case VIR_DOMAIN_DEVICE_AUDIO: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support audio")); + break; + case VIR_DOMAIN_DEVICE_NONE: + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("unexpected VIR_DOMAIN_DEVICE_NONE")); + break; + + case VIR_DOMAIN_DEVICE_LAST: + default: + virReportEnumRangeError(virDomainDeviceType, dev->type); + break; + } + + return ret; +} + virDomainDefParserConfig virCHDriverDomainDefParserConfig = { .domainPostParseBasicCallback = virCHDomainDefPostParseBasic, .domainPostParseCallback = virCHDomainDefPostParse, + .deviceValidateCallback = chValidateDomainDeviceDef, }; diff --git a/src/ch/ch_monitor.c b/src/ch/ch_monitor.c index 87520a2639..1648d05017 100644 --- a/src/ch/ch_monitor.c +++ b/src/ch/ch_monitor.c @@ -359,125 +359,6 @@ virCHMonitorBuildNetsJson(virJSONValue *content, virDomainDef *vmdef) return -1; } -static int -virCHMonitorDetectUnsupportedDevices(virDomainDef *vmdef) -{ - int ret = 0; - - if (vmdef->ngraphics > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support graphics")); - ret = 1; - } - if (vmdef->ncontrollers > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support controllers")); - ret = 1; - } - if (vmdef->nfss > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support fss")); - ret = 1; - } - if (vmdef->ninputs > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support inputs")); - ret = 1; - } - if (vmdef->nsounds > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support sounds")); - ret = 1; - } - if (vmdef->naudios > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support audios")); - ret = 1; - } - if (vmdef->nvideos > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support videos")); - ret = 1; - } - if (vmdef->nhostdevs > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support hostdevs")); - ret = 1; - } - if (vmdef->nredirdevs > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support redirdevs")); - ret = 1; - } - if (vmdef->nsmartcards > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support smartcards")); - ret = 1; - } - if (vmdef->nserials > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support serials")); - ret = 1; - } - if (vmdef->nparallels > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support parallels")); - ret = 1; - } - if (vmdef->nchannels > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support channels")); - ret = 1; - } - if (vmdef->nconsoles > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support consoles")); - ret = 1; - } - if (vmdef->nleases > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support leases")); - ret = 1; - } - if (vmdef->nhubs > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support hubs")); - ret = 1; - } - if (vmdef->nseclabels > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support seclabels")); - ret = 1; - } - if (vmdef->nrngs > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support rngs")); - ret = 1; - } - if (vmdef->nshmems > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support shmems")); - ret = 1; - } - if (vmdef->nmems > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support mems")); - ret = 1; - } - if (vmdef->npanics > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support panics")); - ret = 1; - } - if (vmdef->nsysinfo > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support sysinfo")); - ret = 1; - } - - return ret; -} - static int virCHMonitorBuildVMJson(virDomainDef *vmdef, char **jsonstr) { @@ -490,9 +371,6 @@ virCHMonitorBuildVMJson(virDomainDef *vmdef, char **jsonstr) goto cleanup; } - if (virCHMonitorDetectUnsupportedDevices(vmdef)) - goto cleanup; - if (virCHMonitorBuildCPUJson(content, vmdef) < 0) goto cleanup; -- 2.31.1

2 1

[PATCH 0/2] Xen: Fallout from minimum supported version bump
by Jim Fehlig 18 Jun '21

18 Jun '21

Patch 1 removes the use of LIBXL_HAVE_* that are present in Xen >= 4.9. Patch 2 mentions the version bump in News. Thanks danpb for a little prodding to take a closer look at potential code reduction! After following through with the exersice, it proved to be a bit more than I expected. Jim Fehlig (2): Xen: Remove unneeded LIBXL_HAVE_* ifdefs News: Mention bump in minimum supported Xen version NEWS.rst | 7 ++++++ src/libxl/libxl_capabilities.c | 14 ++--------- src/libxl/libxl_capabilities.h | 2 -- src/libxl/libxl_conf.c | 45 ---------------------------------- src/libxl/libxl_domain.c | 20 +-------------- src/libxl/libxl_driver.c | 29 +--------------------- src/libxl/xen_xl.c | 24 ++---------------- tests/domaincapsmock.c | 11 --------- tests/libxlxml2domconfigtest.c | 6 ----- tests/xlconfigtest.c | 12 --------- 10 files changed, 13 insertions(+), 157 deletions(-) -- 2.31.1

3 5

Add options to device xml to skip reattach of pci passthrough devices.
by Manish Mishra 18 Jun '21

18 Jun '21

Hi Everyone, We want to add extra options to device xml to skip reattach of pci passthrough devices. Following is xml format for pci passthrough devices added to domain as of now. <hostdev mode='subsystem' type='pci' managed='yes'> <source> <address domain='0x0000' bus='0x00' slot='0x1a' function='0x7'/> </source> </hostdev> When we pass managed=’yes’ flag through xml, libvirt takes responsibility of detaching device on domain(guest VM) start and reattaching on domain shutdown. We observed some issues where guest VM shutdown may take long time, blocked for reattach operation on pci passthrough device. As domain lock is held during this time it also makes libvirt mostly inactive as it blocks even basic operations like (virsh list). Reattaching of device to host can block due to reasons like buggy driver or initialization of device itself can take long time in some cases. We want to pass following extra options to resolve this: 1. skipReAttach (optional flag) In some cases we do not need to reattach device to host as it may be reserved only for guests, with this flag we can skip reattach operation on host. We do not want to modify managed flag to avoid regression, so thinking of adding new optional flag. 1. reAttachDriverName (optional flag) Name of driver to which we want to attach instead of default, to avoid reattaching to buggy driver. Currently libvirt asks host to auto selects driver for device. Yes we can use managed=’no’ but in that case user has to take responsibility of detaching device before starting domain which we do not want. Please let us know your views on this. Thanks Manish Mishra

4 4

[libvirt PATCH 0/4] remote: switch to modular daemons by default
by Daniel P. Berrangé 18 Jun '21

18 Jun '21

This series first improves driver probing when using modular daemons. Currently when URI is NULL, we connect to virtproxyd and it looks at which UNIX sockets exist and what binaries exist, to decide which modular hypervisor daemon to connect to. This means the common case results in all traffic going via virtproxyd. Moving the logic out of virtproxyd into the remote client means we can avoid using virtproxyd by default. With this, we can now switch to the modular daemons by default. The latter change primarily impacts how autostart works When running as root we simply connect to whatever UNIX socket exists and rely on systemd to autostart if needed. Whether the UNIX sockets are for the modular daemon or libvirt doesn't matter - we'll look for both. Defaults are dependent on the distros' systemd presets. I intend to get Fedora / RHEL-9 presets changed to use the modular daemons. When running as non-root, we again try to connect to whatever UNIX socket exists, whethe a modular daemon or libvirtd. When no socket exists though, we need to pick a daemon to start and that's where the meson default setting toggle comes into effect, so we prefer spawning modular daemons now and don't spawn libvirtd. Daniel P. Berrangé (4): remote: extract logic for probing for modular daemons remote: add support for probing drivers with modular daemons remote: remove probing logic from virtproxyd dispatcher remote: switch to auto-spawn modular daemons by default meson.build | 6 +- meson_options.txt | 2 +- src/libvirt_remote.syms | 5 + src/remote/remote_daemon_dispatch.c | 130 +------------------ src/remote/remote_sockets.c | 192 ++++++++++++++++++++++++++-- src/remote/remote_sockets.h | 7 + 6 files changed, 202 insertions(+), 140 deletions(-) -- 2.31.1

3 9

[PATCH] remote: fix prefix for libxl Xen driver
by Daniel P. Berrangé 18 Jun '21

18 Jun '21

The libxl driver supports xen:///system URLs and the daemon socket uses 'virtxend' as the socket prefix. Reported-by: Jim Fehlig <jfehlig(a)suse.com> Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/remote/remote_daemon_dispatch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon_dispatch.c index 838f4a925f..dd797a81f7 100644 --- a/src/remote/remote_daemon_dispatch.c +++ b/src/remote/remote_daemon_dispatch.c @@ -2021,7 +2021,7 @@ remoteDispatchProbeURI(bool readonly, * calls in daemonInitialize */ const char *drivers[] = { # ifdef WITH_LIBXL - "libxl", + "xen", # endif # ifdef WITH_QEMU "qemu", -- 2.31.1

2 1

[PATCH v2 0/4] Support for launchSecurity type s390-pv
by Boris Fiuczynski 18 Jun '21

18 Jun '21

This patch series introduces the launch security type s390-pv. Specifying s390-pv as launch security type in an s390 domain prepares for running the guest in protected virtualization secure mode, also known as IBM Secure Execution. diff to v1: - Rebased to current master - Added verification check for confidential-guest-support capability *** BLURB HERE *** Boris Fiuczynski (4): conf: refactor launch security to allow more types qemu: add s390-pv-guest capability conf: add s390-pv as launch security type docs: add s390-pv documentation docs/formatdomain.rst | 7 + docs/kbase/s390_protected_virt.rst | 55 +++++- docs/schemas/domaincommon.rng | 13 +- src/conf/domain_conf.c | 164 +++++++++++------- src/conf/domain_conf.h | 14 +- src/conf/virconftypes.h | 2 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_cgroup.c | 4 +- src/qemu/qemu_command.c | 69 +++++++- src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_firmware.c | 8 +- src/qemu/qemu_namespace.c | 21 ++- src/qemu/qemu_process.c | 36 +++- src/qemu/qemu_validate.c | 31 +++- src/security/security_dac.c | 4 +- .../launch-security-s390-pv-ignore-policy.xml | 24 +++ .../launch-security-s390-pv.xml | 18 ++ .../launch-security-s390-pv-ignore-policy.xml | 1 + tests/genericxml2xmltest.c | 2 + .../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 1 + ...ty-s390-pv-ignore-policy.s390x-latest.args | 35 ++++ .../launch-security-s390-pv-ignore-policy.xml | 33 ++++ .../launch-security-s390-pv.s390x-latest.args | 35 ++++ .../launch-security-s390-pv.xml | 30 ++++ ...urity-sev-missing-policy.x86_64-2.12.0.err | 1 + .../launch-security-sev-missing-policy.xml | 34 ++++ tests/qemuxml2argvtest.c | 4 + 28 files changed, 543 insertions(+), 108 deletions(-) create mode 100644 tests/genericxml2xmlindata/launch-security-s390-pv-ignore-policy.xml create mode 100644 tests/genericxml2xmlindata/launch-security-s390-pv.xml create mode 120000 tests/genericxml2xmloutdata/launch-security-s390-pv-ignore-policy.xml create mode 100644 tests/qemuxml2argvdata/launch-security-s390-pv-ignore-policy.s390x-latest.args create mode 100644 tests/qemuxml2argvdata/launch-security-s390-pv-ignore-policy.xml create mode 100644 tests/qemuxml2argvdata/launch-security-s390-pv.s390x-latest.args create mode 100644 tests/qemuxml2argvdata/launch-security-s390-pv.xml create mode 100644 tests/qemuxml2argvdata/launch-security-sev-missing-policy.x86_64-2.12.0.err create mode 100644 tests/qemuxml2argvdata/launch-security-sev-missing-policy.xml -- 2.30.2

2 5

[PATCH 0/4] storage_backend_iscsi_direct: Refactor string list use and cleanup
by Peter Krempa 18 Jun '21

18 Jun '21

Peter Krempa (4): conf: storage: Introduce virStoragePoolSourceListFree virStorageBackendISCSIDirectFindPoolSources: Use allocated virStoragePoolSourceList virISCSIDirectUpdateTargets: Rework to simplify cleanup and return GStrv virStorageBackendISCSIDirectFindPoolSources: Rework cleanup src/conf/storage_conf.c | 16 ++++ src/conf/storage_conf.h | 5 ++ src/libvirt_private.syms | 1 + src/storage/storage_backend_iscsi_direct.c | 87 +++++++++------------- 4 files changed, 56 insertions(+), 53 deletions(-) -- 2.31.1

2 6

Plans for the next release
by Jiri Denemark 18 Jun '21

18 Jun '21

We are getting close to the next release of libvirt. To aim for the release on Jul 01 I suggest entering the freeze on Friday Jun 25 and tagging RC2 on Tuesday Jun 29. I hope this works for everyone. Jirka

1 0

[PATCH] ch_domain: Add handler for virDomainDeviceDefPostParseCallback
by William Douglas 18 Jun '21

18 Jun '21

Instead of trying to match devices passed in based on the monitor detecting the number of devices that were used in the domain definition, use the devicesPostParseCallback to evaluate if unsupported devices are used. This allows the compiler to detect when new device types are added that need to be checked. Signed-off-by: William Douglas <william.douglas(a)intel.com> --- src/ch/ch_domain.c | 121 +++++++++++++++++++++++++++++++++++++++++++ src/ch/ch_monitor.c | 122 -------------------------------------------- 2 files changed, 121 insertions(+), 122 deletions(-) diff --git a/src/ch/ch_domain.c b/src/ch/ch_domain.c index f9a6f3f31d..02ca5ea06c 100644 --- a/src/ch/ch_domain.c +++ b/src/ch/ch_domain.c @@ -197,7 +197,128 @@ virCHDomainDefPostParse(virDomainDef *def, return 0; } +static int +virCHDomainDeviceDefPostParse(virDomainDeviceDef *dev, + const virDomainDef *def G_GNUC_UNUSED, + unsigned int parseFlags G_GNUC_UNUSED, + void *opaque G_GNUC_UNUSED, + void *parseOpaque G_GNUC_UNUSED) +{ + int ret = -1; + + switch ((virDomainDeviceType)dev->type) { + case VIR_DOMAIN_DEVICE_DISK: + ret = 0; + break; + case VIR_DOMAIN_DEVICE_LEASE: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support lease")); + break; + case VIR_DOMAIN_DEVICE_FS: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support fs")); + break; + case VIR_DOMAIN_DEVICE_NET: + ret = 0; + break; + case VIR_DOMAIN_DEVICE_INPUT: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support input")); + break; + case VIR_DOMAIN_DEVICE_SOUND: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support sound")); + break; + case VIR_DOMAIN_DEVICE_VIDEO: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support video")); + break; + case VIR_DOMAIN_DEVICE_HOSTDEV: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support hostdev")); + break; + case VIR_DOMAIN_DEVICE_WATCHDOG: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support watchdog")); + break; + case VIR_DOMAIN_DEVICE_CONTROLLER: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support controller")); + break; + case VIR_DOMAIN_DEVICE_GRAPHICS: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support graphics")); + break; + case VIR_DOMAIN_DEVICE_HUB: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support hub")); + break; + case VIR_DOMAIN_DEVICE_REDIRDEV: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support redirdev")); + break; + case VIR_DOMAIN_DEVICE_SMARTCARD: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support smartcard")); + break; + case VIR_DOMAIN_DEVICE_CHR: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support chr")); + break; + case VIR_DOMAIN_DEVICE_MEMBALLOON: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support memballoon")); + break; + case VIR_DOMAIN_DEVICE_NVRAM: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support nvram")); + break; + case VIR_DOMAIN_DEVICE_RNG: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support rng")); + break; + case VIR_DOMAIN_DEVICE_SHMEM: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support shmem")); + break; + case VIR_DOMAIN_DEVICE_TPM: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support tpm")); + break; + case VIR_DOMAIN_DEVICE_PANIC: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support panic")); + break; + case VIR_DOMAIN_DEVICE_MEMORY: + ret = 0; + break; + case VIR_DOMAIN_DEVICE_IOMMU: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support iommu")); + break; + case VIR_DOMAIN_DEVICE_VSOCK: + ret = 0; + break; + case VIR_DOMAIN_DEVICE_AUDIO: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Cloud-Hypervisor doesn't support audio")); + break; + case VIR_DOMAIN_DEVICE_NONE: + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("unexpected VIR_DOMAIN_DEVICE_NONE")); + break; + + case VIR_DOMAIN_DEVICE_LAST: + default: + virReportEnumRangeError(virDomainDeviceType, dev->type); + break; + } + + return ret; +} + virDomainDefParserConfig virCHDriverDomainDefParserConfig = { .domainPostParseBasicCallback = virCHDomainDefPostParseBasic, .domainPostParseCallback = virCHDomainDefPostParse, + .devicesPostParseCallback = virCHDomainDeviceDefPostParse, }; diff --git a/src/ch/ch_monitor.c b/src/ch/ch_monitor.c index 87520a2639..1648d05017 100644 --- a/src/ch/ch_monitor.c +++ b/src/ch/ch_monitor.c @@ -359,125 +359,6 @@ virCHMonitorBuildNetsJson(virJSONValue *content, virDomainDef *vmdef) return -1; } -static int -virCHMonitorDetectUnsupportedDevices(virDomainDef *vmdef) -{ - int ret = 0; - - if (vmdef->ngraphics > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support graphics")); - ret = 1; - } - if (vmdef->ncontrollers > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support controllers")); - ret = 1; - } - if (vmdef->nfss > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support fss")); - ret = 1; - } - if (vmdef->ninputs > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support inputs")); - ret = 1; - } - if (vmdef->nsounds > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support sounds")); - ret = 1; - } - if (vmdef->naudios > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support audios")); - ret = 1; - } - if (vmdef->nvideos > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support videos")); - ret = 1; - } - if (vmdef->nhostdevs > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support hostdevs")); - ret = 1; - } - if (vmdef->nredirdevs > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support redirdevs")); - ret = 1; - } - if (vmdef->nsmartcards > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support smartcards")); - ret = 1; - } - if (vmdef->nserials > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support serials")); - ret = 1; - } - if (vmdef->nparallels > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support parallels")); - ret = 1; - } - if (vmdef->nchannels > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support channels")); - ret = 1; - } - if (vmdef->nconsoles > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support consoles")); - ret = 1; - } - if (vmdef->nleases > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support leases")); - ret = 1; - } - if (vmdef->nhubs > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support hubs")); - ret = 1; - } - if (vmdef->nseclabels > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support seclabels")); - ret = 1; - } - if (vmdef->nrngs > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support rngs")); - ret = 1; - } - if (vmdef->nshmems > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support shmems")); - ret = 1; - } - if (vmdef->nmems > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support mems")); - ret = 1; - } - if (vmdef->npanics > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support panics")); - ret = 1; - } - if (vmdef->nsysinfo > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Cloud-Hypervisor doesn't support sysinfo")); - ret = 1; - } - - return ret; -} - static int virCHMonitorBuildVMJson(virDomainDef *vmdef, char **jsonstr) { @@ -490,9 +371,6 @@ virCHMonitorBuildVMJson(virDomainDef *vmdef, char **jsonstr) goto cleanup; } - if (virCHMonitorDetectUnsupportedDevices(vmdef)) - goto cleanup; - if (virCHMonitorBuildCPUJson(content, vmdef) < 0) goto cleanup; -- 2.31.1

4 8

[PATCH v2 00/14] news update since v6.9 to v7.0
by Han Han 18 Jun '21

18 Jun '21

Diff from v1: - Drop the news "Introduce VIR_DOMAIN_CHECKPOINT_REDEFINE_VALIDATE flag" - Move the news of virt-aa-helper to bug fix part - Update some descriptions of news v1: https://listman.redhat.com/archives/libvir-list/2021-April/msg00456.html Thanks for the advice from Peter Krempa and Erik Skultety. Han Han (14): news: make SEV attrs 'cbitpos' & 'reducedPhysBits' optional news: support device stats collection for SR-IOV VF hostdev news: virt-aa-helper: allow guest to create hard links for mounted 9pfs paths news: cpu_map: Add EPYC-Rome cpu model news: cpu: Support for XML validation in cpu comparison logging: allow max_len=0 to disable log rollover news: qemu: Set noqueue qdisc for TAP devices news: qemu: Introduce virtio free page reporting feature news: qemu: virtiofs can be used without NUMA nodes news: qemu: Add 'fmode' and 'dmode' options for 9pfs news: Introduce "migrate_tls_force" to qemu.conf qemu: support kvm-poll-control performance hint news: cpu_map: Add Snowridge cpu model news: qemu: Add support for NFS disk protocol NEWS.rst | 74 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 74 insertions(+) -- 2.31.1

1 18

[PATCH v1] meson: fix xenstore and xentoollog detection
by Olaf Hering 17 Jun '21

17 Jun '21

A xenstore.pc and xentoollog.pc exists only since Xen 4.9. Fixes commit fe7c07adac30994dd042515e1076e195128e15cd Signed-off-by: Olaf Hering <olaf(a)aepfle.de> --- meson.build | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index 04c229d7f4..f3ff57d336 100644 --- a/meson.build +++ b/meson.build @@ -1500,14 +1500,22 @@ if not get_option('driver_libxl').disabled() and conf.has('WITH_LIBVIRTD') endif xl_util_dep = dependency('xlutil') - xen_store_dep = dependency('xenstore') + # xenstore.pc exists since Xen 4.9 + if libxl_dep.version().version_compare('>=4.9.0') + xen_store_dep = dependency('xenstore') + else + xen_store_dep = cc.find_library('xenstore') + endif # xtl_* infrastructure is in libxentoollog since Xen 4.7 previously # it was in libxenctrl. - if libxl_dep.version().version_compare('>=4.7.0') + # xentoollog.pc exists since Xen 4.9 + if libxl_dep.version().version_compare('>=4.9.0') xtl_link_dep = dependency('xentoollog') + elif libxl_dep.version().version_compare('>=4.7.0') + xtl_link_dep = cc.find_library('xentoollog') else - xtl_link_dep = dependency('xenctrl') + xtl_link_dep = cc.find_library('xenctrl') endif if libxl_dep.version().version_compare('>=4.13.0')

4 12

[PATCH v3 00/15] Introduce virtio-mem <memory/> model
by Michal Privoznik 17 Jun '21

17 Jun '21

v3 of: https://listman.redhat.com/archives/libvir-list/2021-February/msg00961.html diff to v2: - Dropped code that forbade use of virtio-mem and memballoon at the same time; - This meant that I had to adjust memory accounting, qemuDomainSetMemoryFlags() - see patches 11/15 and 12/15 which are new. - Fixed small nits raised by Peter in his review of v2 Michal Prívozník (15): virhostmem: Introduce virHostMemGetTHPSize() qemu_process: Deduplicate code in qemuProcessNeedHugepagesPath() qemu_process: Drop needless check in qemuProcessNeedMemoryBackingPath() qemu_capabilities: Introduce QEMU_CAPS_DEVICE_VIRTIO_MEM_PCI conf: Introduce virtio-mem <memory/> model qemu: Build command line for virtio-mem qemu: Wire up <memory/> live update qemu: Wire up MEMORY_DEVICE_SIZE_CHANGE event Introduce MEMORY_DEVICE_SIZE_CHANGE event qemu: Refresh the actual size of virtio-mem on monitor reconnect qemu: Account for both memballoon and virtio-mem qemuDomainSetMemoryFlags: Take virtio-mem into consideration virsh: Introduce update-memory-device command news: document recent virtio memory addition kbase: Document virtio-mem NEWS.rst | 7 + docs/formatdomain.rst | 45 +++- docs/kbase/index.rst | 4 + docs/kbase/memorydevices.rst | 150 +++++++++++ docs/kbase/meson.build | 1 + docs/manpages/virsh.rst | 30 +++ docs/schemas/domaincommon.rng | 16 ++ examples/c/misc/event-test.c | 17 ++ include/libvirt/libvirt-domain.h | 23 ++ src/conf/domain_conf.c | 115 ++++++++- src/conf/domain_conf.h | 15 ++ src/conf/domain_event.c | 84 +++++++ src/conf/domain_event.h | 10 + src/conf/domain_validate.c | 39 +++ src/libvirt_private.syms | 5 + src/qemu/qemu_alias.c | 10 +- src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 13 +- src/qemu/qemu_domain.c | 50 +++- src/qemu/qemu_domain.h | 1 + src/qemu/qemu_domain_address.c | 38 ++- src/qemu/qemu_driver.c | 233 +++++++++++++++++- src/qemu/qemu_hotplug.c | 18 ++ src/qemu/qemu_hotplug.h | 5 + src/qemu/qemu_monitor.c | 37 +++ src/qemu/qemu_monitor.h | 27 ++ src/qemu/qemu_monitor_json.c | 97 ++++++-- src/qemu/qemu_monitor_json.h | 5 + src/qemu/qemu_process.c | 118 ++++++++- src/qemu/qemu_validate.c | 8 + src/remote/remote_daemon_dispatch.c | 30 +++ src/remote/remote_driver.c | 32 +++ src/remote/remote_protocol.x | 15 +- src/remote_protocol-structs | 7 + src/security/security_apparmor.c | 1 + src/security/security_dac.c | 2 + src/security/security_selinux.c | 2 + src/util/virhostmem.c | 63 +++++ src/util/virhostmem.h | 3 + tests/domaincapsmock.c | 9 + .../caps_5.1.0.x86_64.xml | 1 + .../caps_5.2.0.x86_64.xml | 1 + .../caps_6.0.0.x86_64.xml | 1 + ...mory-hotplug-virtio-mem.x86_64-latest.args | 49 ++++ .../memory-hotplug-virtio-mem.xml | 67 +++++ tests/qemuxml2argvtest.c | 1 + ...emory-hotplug-virtio-mem.x86_64-latest.xml | 1 + tests/qemuxml2xmltest.c | 1 + tools/virsh-domain.c | 169 +++++++++++++ 50 files changed, 1612 insertions(+), 67 deletions(-) create mode 100644 docs/kbase/memorydevices.rst create mode 100644 tests/qemuxml2argvdata/memory-hotplug-virtio-mem.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/memory-hotplug-virtio-mem.xml create mode 120000 tests/qemuxml2xmloutdata/memory-hotplug-virtio-mem.x86_64-latest.xml -- 2.26.2

4 22

[PATCH 0/7] qemu: snapshot: Fix removal of output files on failure
by Peter Krempa 17 Jun '21

17 Jun '21

Peter Krempa (7): qemuSnapshotPrepareDiskExternal: Move temp variables into the block using them qemuSnapshotPrepareDiskExternal: Avoid condition squashing qemuSnapshotPrepareDiskExternal: Reject creation of block devices sooner qemuSnapshotPrepareDiskExternal: Enforce match between snapshot type and existing file type qemuSnapshotPrepareDiskExternal: Refactor existing file check conf: snapshot: rename variable holding memory snapshot file location qemuSnapshotCreateActiveExternal: Don't unlink memory snapshot image if it was existing before src/conf/snapshot_conf.c | 10 +++---- src/conf/snapshot_conf.h | 2 +- src/qemu/qemu_snapshot.c | 56 +++++++++++++++++++++++++++++----------- 3 files changed, 47 insertions(+), 21 deletions(-) -- 2.31.1

2 8

[PATCH 0/8] security_dac: Couple of cleanups
by Michal Privoznik 17 Jun '21

17 Jun '21

I've started looking at how we could fix the following bug: https://bugzilla.redhat.com/show_bug.cgi?id=1786222 Long story short, we are not using just async signal safe functions in a forked off thread that runs chown() from within the domain's private namespace. Hence, we ran into a deadlock (although the case of the bug the deadlock is in glibc not gluster). So far I don't have any fix, but I have couple of cleanups. Michal Prívozník (8): security_dac: Use g_autofree security_dac: Introduce virSecurityDACChownItemFree() security_dac: Introduce g_autoptr for virSecurityDACChownList security_dac: Don't check for !priv in virSecurityDACSetOwnershipInternal() virSecurityDACSetOwnershipInternal: Drop dead code virSecurityDACSetOwnershipInternal: Don't overwrite @path argument virSecurityDACSetOwnershipInternal: Fix WIN32 code qemu: Deduplicate code in qemuSecurityChownCallback() src/qemu/qemu_driver.c | 22 +--- src/security/security_dac.c | 201 ++++++++++++++------------------ src/security/security_manager.h | 13 ++- 3 files changed, 98 insertions(+), 138 deletions(-) -- 2.31.1

2 10

Libvirt hit a issue when do VM migration
by 梁朝军 17 Jun '21

17 Jun '21

Hi All, Who can give me a help? I hit another issue when do vm migration? Libvirt throw out the error like below "libvirt: Domain Config error : unsupported configuration: vcpu enable order of vCPU '0' differs between source and destination definitions” The cup information is defined VM domain on source host is like: <vcpu placement='static'>2</vcpu> <vcpus> <vcpu id='0' enabled='yes' hotpluggable='no' order='1'/> <vcpu id='1' enabled='yes' hotpluggable='no' order='2'/> </vcpus> <cputune> <vcpupin vcpu='0' cpuset='42'/> <vcpupin vcpu='1' cpuset='43'/> </cputune> The distinction host previews generate xml for VM like: <vcpu placement='static'>2</vcpu> <vcpus> <vcpu id='0' enabled='yes' hotpluggable='no' order='1'/> <vcpu id='1' enabled='yes' hotpluggable='no' order='2'/> </vcpus> <cputune> <vcpupin vcpu='0' cpuset='42'/> <vcpupin vcpu='1' cpuset='43'/> </cputune> What’t wrong with it? Or I missing some actions in configurations regarding the migration Thanks a lot !

2 1

[PATCH 1/1] domain_validate.c: fix virDomainDefFSValidate() when fs->dst is NULL
by Daniel Henrique Barboza 17 Jun '21

17 Jun '21

Commit 56dcdec1ac81 ("conf: reject duplicate virtiofs tags") added validation code to reject duplicated virtiofs tags. But the <target> element is not always present, meaning that fs->dst can be NULL at that point. If there is no "<target>" tag then the validation will fail in virHashAddEntry() because fs->dst will be NULL. This is tested in qemuxml2xml vhost-user-fs-sock, which is since then not passing: 1020) QEMU XML-2-XML-inactive vhost-user-fs-sock ... Expected result code=0 but received code=1 FAILED 1021) QEMU XML-2-XML-active vhost-user-fs-sock ... Expected result code=0 but received code=1 FAILED The '<target>' tag is not mandatory, so let's consider that fs->dst being NULL is a feasible scenario an adapt virDomainDefFSValidate() accordingly. Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com> --- src/conf/domain_validate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 9422b00964..cf8b43b845 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -1504,7 +1504,7 @@ virDomainDefFSValidate(const virDomainDef *def) for (i = 0; i < def->nfss; i++) { const virDomainFSDef *fs = def->fss[i]; - if (fs->fsdriver != VIR_DOMAIN_FS_DRIVER_TYPE_VIRTIOFS) + if (fs->fsdriver != VIR_DOMAIN_FS_DRIVER_TYPE_VIRTIOFS || !fs->dst) continue; if (virHashHasEntry(dsts, fs->dst)) { -- 2.31.1

3 3

[libvirt PATCH] qemu_hotplug: don't forget to add hostdev interfaces to the interface list
by Laine Stump 17 Jun '21

17 Jun '21

Originally qemuDomainAttachNetDevice() would wait until the cleanup at the very end of the function to add newly hotplugged interfaces to the domain's nets list. commit 7b8bec4560 modified it to add the new interface to the nets list earlier (but not all the way at the beginning of the function either, because there are some operations (PCI address assignment in particular) that need the new device to not yet be visible in the domaindef). But hostdev interfaces short-circuit past most of the body of qemuDomainAttachNetDevice() (since none of it applies to hostdev interfaces). In the past that was okay, but since the line that adds the new interface to the domaindef's nets list is in that "most of the body", after that commit hotplugged hostdev interfaces are no longer being properly added to the domaindef nets list, so they don't show up in the status XML or the virsh domiflist output. It really *is* important to add interfaces to the nets list earlier, so we can't revert commit 7b8bec4560, and we also can't move the insert to common code *earlier* in the function, so instead this patch duplicates the VIR_APPEND_ELEMENT_COPY() just before the code path for hostdev interfaces jumps to cleanup. Resolves: https://bugzilla.redhat.com/1972991 Fixes: 7b8bec45601b6570f6a7413e94d291986d2663f1 (any other tags I should add?) Signed-off-by: Laine Stump <laine(a)redhat.com> --- src/qemu/qemu_hotplug.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 0640cdd9f7..e323edc2e8 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -1230,10 +1230,21 @@ qemuDomainAttachNetDevice(virQEMUDriver *driver, /* This is really a "smart hostdev", so it should be attached * as a hostdev (the hostdev code will reach over into the * netdev-specific code as appropriate), then also added to - * the nets list (see cleanup:) if successful. + * the nets list if successful. */ - ret = qemuDomainAttachHostDevice(driver, vm, - virDomainNetGetActualHostdev(net)); + if (qemuDomainAttachHostDevice(driver, vm, + virDomainNetGetActualHostdev(net)) < 0) { + goto cleanup; + } + if (VIR_APPEND_ELEMENT_COPY(vm->def->nets, vm->def->nnets, net) < 0) + goto cleanup; + + /* the rest of the setup doesn't apply to hostdev interfaces, so + * we can skip straight to the cleanup (nothing there applies to + * hostdev interfaces either, but it might in the future, so we + * may as well be consistent) + */ + ret = 0; goto cleanup; } -- 2.31.1

2 1

[libvirt PATCHv2 0/2] Small virtiofs fixes (virtio-fs epopee)
by Ján Tomko 17 Jun '21

17 Jun '21

Ján Tomko (2): conf: move filesystem target validation conf: require target for external virtiofsd docs/formatdomain.rst | 1 + docs/kbase/virtiofs.rst | 1 + src/conf/domain_conf.c | 6 ------ src/conf/domain_validate.c | 10 ++++++++++ tests/qemuxml2argvdata/vhost-user-fs-sock.xml | 1 + 5 files changed, 13 insertions(+), 6 deletions(-) -- 2.31.1

3 6

[PATCH] qemu: Don't set NVRAM label when creating it
by Michal Privoznik 16 Jun '21

16 Jun '21

The NVRAM label is set in qemuSecuritySetAllLabel(). There's no need to set its label upfront. In fact, setting it twice creates an imbalance because it's unset only once which mangles seclabel remembering. However, plain removal of the qemuSecurityDomainSetPathLabel() undoes the fix for the original bug (when dynamic ownership is off then the NVRAM is not created with cfg->user and cfg->group but as root:root). Therefore, we have to switch to virFileOpenAs() and pass cfg->user and cfg->group and VIR_FILE_OPEN_FORCE_OWNER flag. There's no need to pass VIR_FILE_OPEN_FORCE_MODE because the file will be created with the proper mode. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1969347 Fixes: bcdaa91a27b5b2d103535270a6a287efe6cd8bfb Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_process.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index c37687f249..2b03b0ab98 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -4538,16 +4538,19 @@ qemuPrepareNVRAM(virQEMUDriver *driver, goto cleanup; } - if ((dstFD = qemuDomainOpenFile(driver, vm, loader->nvram, - O_WRONLY | O_CREAT | O_EXCL, - NULL)) < 0) + if ((dstFD = virFileOpenAs(loader->nvram, + O_WRONLY | O_CREAT | O_EXCL, + S_IRUSR | S_IWUSR, + cfg->user, cfg->group, + VIR_FILE_OPEN_FORCE_OWNER)) < 0) { + virReportSystemError(-dstFD, + _("Failed to create file '%s'"), + loader->nvram); goto cleanup; + } created = true; - if (qemuSecurityDomainSetPathLabel(driver, vm, loader->nvram, false) < 0) - goto cleanup; - do { char buf[1024]; -- 2.31.1

2 1

[PATCH 0/3] Apparmor: Add profiles for hypervisor daemons
by Jim Fehlig 16 Jun '21

16 Jun '21

This series is a first attempt at creating apparmor profiles for the modular daemons. It introduces profiles for virt{lxc,qemu,xen}d, which AFAIK are the only hypervisors supported by apparmor. The profiles are copies of the libvirtd profile, with all the non hypervisor-specific rules removed. E.g. qemu related rules removed from the virtxend profile and vice versa. Likely more rules could be trimmed from the xen and lxc profiles. I'll need to investigate how the apparmor tools can help identify such rules. So far things look okay with apparmor and modular daemons. One issue I have yet to resolve is interaction between dnsmasq and libvirt_leaseshelper. Trying to start e.g. the default network results in the following apparmor denial type=AVC msg=audit(1623791662.885:655): apparmor="DENIED" operation="exec" profile="/usr/sbin/dnsmasq" name="/usr/lib/libvirt_leaseshelper" pid=8154 comm="sh" requested_mask="x" denied_mask="x" fsuid=0 ouid=0 Perhaps some apparmor experts can make better sense of that error than me :-). It would be nice to avoid adjusting the dnsmasq profile, which is not in the libvirt project, if possible. I noticed a few more denial messages that I _think_ are unrelated to modular daemons, which also need further investigation type=AVC msg=audit(1623797296.856:593): apparmor="DENIED" operation="open" profile="virt-aa-helper" name="/etc/ssl/openssl.cnf" pid=6511 comm="virt-aa-helper" requested_mask="r" denied_mask="r" fsuid=0 ouid=0 type=AVC msg=audit(1623797296.856:594): apparmor="DENIED" operation="open" profile="virt-aa-helper" name="/etc/libnl/classid" pid=6511 comm="virt-aa-helper" requested_mask="r" denied_mask="r" fsuid=0 ouid=0 t type=AVC msg=audit(1623797297.732:623): apparmor="DENIED" operation="open" profile="libvirt-481c2d22-76d5-404b-a4b0-dc2069c7e19e" name="/etc/libnl/classid" pid=6539 comm="qemu-system-x86" requested_mask="r" denied_mask="r" fsuid=107 ouid=0 Jim Fehlig (3): Apparmor: Add profile for virtqemud Apparmor: Add profile for virtlxcd Apparmor: Add profile for virtxend src/security/apparmor/libvirt-lxc | 4 +- src/security/apparmor/libvirt-qemu | 6 + src/security/apparmor/meson.build | 3 + src/security/apparmor/usr.sbin.virtlxcd.in | 89 +++++++++++++ src/security/apparmor/usr.sbin.virtqemud.in | 135 ++++++++++++++++++++ src/security/apparmor/usr.sbin.virtxend.in | 78 +++++++++++ 6 files changed, 314 insertions(+), 1 deletion(-) create mode 100644 src/security/apparmor/usr.sbin.virtlxcd.in create mode 100644 src/security/apparmor/usr.sbin.virtqemud.in create mode 100644 src/security/apparmor/usr.sbin.virtxend.in -- 2.31.1

2 7

Migration capabilities is not reset after the libvirtd service restart
by Huangzhichao 16 Jun '21

16 Jun '21

Hi Everyone, We find migration capabilities is not reset after restarting libvirtd, it would cause problem in the following scene: Version: libvirt release 7.4.0 Step 1. create a VM and query migration capabilities, mark the return content as "Cap A". Step 2. stop the source libvirtd service when executing live migration, then migration failed. Step 3. restart the source libvirtd service, then query migration capabilities, mark the return content as "Cap B". "Cap A" is different from "Cap B", because the source libvirtd service would set migration capabilities when executing live migration. We find that there is a patch may cause this problem. Link: https://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=a1dec315c9ad87a198245… When we roll back this patch, "CAP A" would be the same as "CAP B". Do you have any suggestion ? Thanks.

2 1

[libvirt PATCH 0/3] Small virtiofs fixes (virtio-fs epopee)
by Ján Tomko 16 Jun '21

16 Jun '21

Today we fix a bug: https://bugzilla.redhat.com/show_bug.cgi?id=1969232 and an issue: https://gitlab.com/libvirt/libvirt/-/issues/178 Ján Tomko (3): conf: require target for external virtiofsd docs: fix filesystem schema indentation conf: reject duplicate virtiofs tags docs/formatdomain.rst | 1 + docs/kbase/virtiofs.rst | 1 + docs/schemas/domaincommon.rng | 32 +++++++++---------- src/conf/domain_conf.c | 2 +- src/conf/domain_validate.c | 30 +++++++++++++++++ tests/qemuxml2argvdata/vhost-user-fs-sock.xml | 1 + 6 files changed, 50 insertions(+), 17 deletions(-) -- 2.31.1

2 6

[libvirt PATCH] qemu_hotplug: Report VIR_ERR_DEVICE_MISSING when device is not found
by Lee Yarwood 16 Jun '21

16 Jun '21

126db34a81bc9f9f9710408f88cceaa1e34bbbd7 had previously switched various flows over to this from VIR_ERR_OPERATION_FAILED. This change simply does the same for qemuDomainDetachPrepDisk, qemuDomainDetachPrepInput and qemuDomainDetachPrepVsock to allow management apps to centralise their error handling on just VIR_ERR_DEVICE_MISSING for missing devices during a detach. --- src/qemu/qemu_hotplug.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 0640cdd9f7..68bd92cf13 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -5322,7 +5322,7 @@ qemuDomainDetachPrepDisk(virDomainObj *vm, int idx; if ((idx = qemuFindDisk(vm->def, match->dst)) < 0) { - virReportError(VIR_ERR_OPERATION_FAILED, + virReportError(VIR_ERR_DEVICE_MISSING, _("disk %s not found"), match->dst); return -1; } @@ -5819,7 +5819,7 @@ qemuDomainDetachPrepInput(virDomainObj *vm, int idx; if ((idx = virDomainInputDefFind(vm->def, match)) < 0) { - virReportError(VIR_ERR_OPERATION_FAILED, "%s", + virReportError(VIR_ERR_DEVICE_MISSING, "%s", _("matching input device not found")); return -1; } @@ -5855,7 +5855,7 @@ qemuDomainDetachPrepVsock(virDomainObj *vm, *detach = vsock = vm->def->vsock; if (!vsock || !virDomainVsockDefEquals(match, vsock)) { - virReportError(VIR_ERR_OPERATION_FAILED, "%s", + virReportError(VIR_ERR_DEVICE_MISSING, "%s", _("matching vsock device not found")); return -1; } -- 2.31.1

2 3

[libvirt] [PATCH v2 0/5] virsh bash completion improvement
by Lin Ma 16 Jun '21

16 Jun '21

v1 -> v2: * 01-08 were merged, So remove them. * Reworked virshStorageVolKeyCompleter to avoid leaking objects. Thanks to Michal Privoznik for helping reviewing these patches. Lin Ma (5): virsh-pool: Remove static from virshStoragePoolList{Free,Collect} virsh-volume: Introduce virshStorageVolKeyCompleter virsh-volume: Add macros VIRSH_COMMON_OPT_VOL_* virsh-volume: Apply virshStorageVolKeyCompleter to vol-{name,pool} commands virsh-volume: Apply virshStorageVolNameCompleter to vol-{key,path} commands tools/virsh-completer-volume.c | 47 ++++++++++++++++++++++++++ tools/virsh-completer-volume.h | 5 +++ tools/virsh-pool.c | 10 ++---- tools/virsh-pool.h | 11 +++++++ tools/virsh-volume.c | 60 ++++++++++++++++------------------ 5 files changed, 94 insertions(+), 39 deletions(-) -- 2.26.2

2 7

[PATCH 0/3] qemu: Handle the egl-headless capability properly
by Peter Krempa 16 Jun '21

16 Jun '21

Similarly to my previous series dealing with SDL graphics, 'egl-headless' should be getting exactly the same treatment. Peter Krempa (3): qemu: capabilities: Un-retire QEMU_CAPS_EGL_HEADLESS tests: qemuxml2*: Add QEMU_CAPS_EGL_HEADLESS to fake-caps tests using egl-headless graphics qemu: capabilities: Fill SDL graphics support only when it's really supported src/qemu/qemu_capabilities.c | 8 ++++++-- src/qemu/qemu_capabilities.h | 2 +- tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_3.0.0.riscv32.xml | 1 + tests/qemucapabilitiesdata/caps_3.0.0.riscv64.xml | 1 + tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.riscv32.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.riscv64.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_4.1.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_5.0.0.riscv64.xml | 1 + tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_5.1.0.sparc.xml | 1 + tests/qemucapabilitiesdata/caps_5.1.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_5.2.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_5.2.0.riscv64.xml | 1 + tests/qemucapabilitiesdata/caps_5.2.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_6.0.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml | 1 + tests/qemuxml2argvtest.c | 9 ++++++--- tests/qemuxml2xmltest.c | 8 +++++--- 42 files changed, 56 insertions(+), 9 deletions(-) -- 2.31.1

2 7

[PATCH] gitlab-ci: Don't build docs in 'sanitizer' jobs
by Peter Krempa 16 Jun '21

16 Jun '21

Docs are not sanitized, thus there's no point in building them. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index b5930a0a46..3fa616261e 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -86,7 +86,7 @@ stages: before_script: - *script_variables script: - - meson build --werror -Db_lundef=false -Db_sanitize="$SANITIZER" + - meson build --werror -Ddocs=disabled -Db_lundef=false -Db_sanitize="$SANITIZER" - ninja -C build; - ninja -C build test; -- 2.31.1

2 1

[PATCH 00/22] Fix hotplug of disks with iothreads and s390 cruft cleanup
by Peter Krempa 15 Jun '21

15 Jun '21

This series consists of 3 parts: Part 1, patches 1-3: These are fixes to the virCommand->string conversion, namely two bugs: - VIR_TEST_REGENERATE_OUTPUT would produce new files with missing end newline - memleak in bhyves xml->native conversion Part 2, patches 4 - 21: Removal of 's390-virtio' machine and the corresponding addressing type. This was removed in qemu 2.6. The exploration started because the last patch was for a strange reason checking the address type and I needed to know if indeed 'virtio-s390' addresses don't support iothreads. Turns out the whole thing can be deleted. Part 3, patch 22: Hotplug of disks with iothreads is broken because the code was moved prior to address asignment and didn't account for missing address. Let's remove the whole check as it turned out to be pointless. Peter Krempa (22): util: command: Introduce virCommandToStringBuf qemuxml2arvtest: Ensure newline at the end of generated .args files bhyveConnectDomainXMLToNative: Fix memory leak in incorrect virCommandToString usage tests: qemuxml2argv: Modernize 'watchdog-diag288' test tests: qemuxml2argv: Modernize 'console-sclp' test tests: qemuxml2argv: Remove redundant tests for the obsolete 'virtio-390' machine tests: qemuxml2argv: Modernize 's390-allow-bogus-usb-none' test tests: qemuxml2xml: Modernize 's390-defaultconsole' case tests: qemuxml2argv: Modernize 's390-allow-bogus-usb-controller' test qemu: domain: Remove hack for 's390-virtio' machine tests: Remove 's390-virtio' machine caps faking qemu: capabilities: Remove probing of 'virtio-*-s390' devices qemu: capabilities: Don't probe device properties for 'virtio-*-s390' devices qemuxml2argvtest: Use other bus capability for 'non-x86_64-timer-error' case qemu: Always reject 'virtio-s390' addresses qemu: Remove last uses of QEMU_CAPS_VIRTIO_S390 qemuxml2*test: Remove QEMU_CAPS_VIRTIO_S390 flag qemu: capabilities: Retire QEMU_CAPS_VIRTIO_S390 qemu: Drop handling of devices with VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_S390 qemuValidateDomainDeviceDefAddress: Add validation of CCW address qemuDomainCheckCCWS390AddressSupport: Remove duplicated checker qemu: validate: Don't check bus type in qemuValidateDomainDeviceDefDiskIOThreads src/bhyve/bhyve_driver.c | 4 +- src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 10 -- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c | 10 +- src/qemu/qemu_domain.c | 44 ----- src/qemu/qemu_domain.h | 6 - src/qemu/qemu_domain_address.c | 17 +- src/qemu/qemu_domain_address.h | 3 +- src/qemu/qemu_hotplug.c | 17 +- src/qemu/qemu_validate.c | 48 ++--- src/util/vircommand.c | 50 ++++-- src/util/vircommand.h | 4 + .../caps_2.11.0.s390x.replies | 108 +++++------ .../caps_2.11.0.x86_64.replies | 152 +++++++--------- .../caps_2.12.0.aarch64.replies | 132 ++++++-------- .../caps_2.12.0.ppc64.replies | 124 ++++++------- .../caps_2.12.0.s390x.replies | 116 ++++++------ .../caps_2.12.0.x86_64.replies | 168 ++++++++---------- .../caps_3.0.0.ppc64.replies | 124 ++++++------- .../caps_3.0.0.riscv32.replies | 100 +++++------ .../caps_3.0.0.riscv64.replies | 100 +++++------ .../caps_3.0.0.s390x.replies | 120 ++++++------- .../caps_3.0.0.x86_64.replies | 168 ++++++++---------- .../caps_3.1.0.ppc64.replies | 124 ++++++------- .../caps_3.1.0.x86_64.replies | 168 ++++++++---------- .../caps_4.0.0.aarch64.replies | 136 +++++++------- .../caps_4.0.0.ppc64.replies | 132 ++++++-------- .../caps_4.0.0.riscv32.replies | 128 ++++++------- .../caps_4.0.0.riscv64.replies | 128 ++++++------- .../caps_4.0.0.s390x.replies | 120 ++++++------- .../caps_4.0.0.x86_64.replies | 168 ++++++++---------- .../caps_4.1.0.x86_64.replies | 160 ++++++++--------- .../caps_4.2.0.aarch64.replies | 144 +++++++-------- .../caps_4.2.0.ppc64.replies | 132 ++++++-------- .../caps_4.2.0.s390x.replies | 124 ++++++------- .../caps_4.2.0.x86_64.replies | 164 ++++++++--------- .../caps_5.0.0.aarch64.replies | 144 +++++++-------- .../caps_5.0.0.ppc64.replies | 140 +++++++-------- .../caps_5.0.0.riscv64.replies | 132 ++++++-------- .../caps_5.0.0.x86_64.replies | 164 ++++++++--------- .../caps_5.1.0.x86_64.replies | 164 ++++++++--------- .../caps_5.2.0.aarch64.replies | 148 +++++++-------- .../caps_5.2.0.ppc64.replies | 140 +++++++-------- .../caps_5.2.0.riscv64.replies | 132 ++++++-------- .../caps_5.2.0.s390x.replies | 124 ++++++------- .../caps_5.2.0.x86_64.replies | 164 ++++++++--------- .../caps_6.0.0.s390x.replies | 124 ++++++------- .../caps_6.0.0.x86_64.replies | 164 ++++++++--------- .../caps_6.1.0.x86_64.replies | 164 ++++++++--------- tests/qemuxml2argvdata/console-sclp.args | 28 --- .../console-sclp.s390x-latest.args | 36 ++++ tests/qemuxml2argvdata/console-sclp.xml | 2 +- .../qemuxml2argvdata/console-virtio-s390.args | 29 --- .../qemuxml2argvdata/console-virtio-s390.xml | 24 --- tests/qemuxml2argvdata/disk-virtio-s390.args | 26 --- tests/qemuxml2argvdata/disk-virtio-s390.xml | 22 --- tests/qemuxml2argvdata/net-virtio-s390.args | 26 --- tests/qemuxml2argvdata/net-virtio-s390.xml | 22 --- .../s390-allow-bogus-usb-controller.args | 31 ---- ...low-bogus-usb-controller.s390x-latest.args | 39 ++++ .../s390-allow-bogus-usb-controller.xml | 2 +- .../s390-allow-bogus-usb-none.args | 31 ---- ...390-allow-bogus-usb-none.s390x-latest.args | 39 ++++ .../s390-allow-bogus-usb-none.xml | 2 +- .../qemuxml2argvdata/s390-defaultconsole.xml | 2 +- tests/qemuxml2argvdata/watchdog-diag288.args | 28 --- .../watchdog-diag288.s390x-latest.args | 36 ++++ tests/qemuxml2argvdata/watchdog-diag288.xml | 2 +- tests/qemuxml2argvtest.c | 125 +++++-------- ...l => s390-defaultconsole.s390x-latest.xml} | 4 +- tests/qemuxml2xmltest.c | 27 +-- tests/testutilsqemu.c | 2 +- tests/vircapstest.c | 4 - 74 files changed, 2562 insertions(+), 3387 deletions(-) delete mode 100644 tests/qemuxml2argvdata/console-sclp.args create mode 100644 tests/qemuxml2argvdata/console-sclp.s390x-latest.args delete mode 100644 tests/qemuxml2argvdata/console-virtio-s390.args delete mode 100644 tests/qemuxml2argvdata/console-virtio-s390.xml delete mode 100644 tests/qemuxml2argvdata/disk-virtio-s390.args delete mode 100644 tests/qemuxml2argvdata/disk-virtio-s390.xml delete mode 100644 tests/qemuxml2argvdata/net-virtio-s390.args delete mode 100644 tests/qemuxml2argvdata/net-virtio-s390.xml delete mode 100644 tests/qemuxml2argvdata/s390-allow-bogus-usb-controller.args create mode 100644 tests/qemuxml2argvdata/s390-allow-bogus-usb-controller.s390x-latest.args delete mode 100644 tests/qemuxml2argvdata/s390-allow-bogus-usb-none.args create mode 100644 tests/qemuxml2argvdata/s390-allow-bogus-usb-none.s390x-latest.args delete mode 100644 tests/qemuxml2argvdata/watchdog-diag288.args create mode 100644 tests/qemuxml2argvdata/watchdog-diag288.s390x-latest.args rename tests/qemuxml2xmloutdata/{s390-defaultconsole.xml => s390-defaultconsole.s390x-latest.xml} (82%) -- 2.31.1

4 26

[libvirt PATCH 0/3] mdev tweaks
by Jonathon Jongsma 15 Jun '21

15 Jun '21

A few minor fixes to mdev support in the nodedev driver Jonathon Jongsma (3): nodedev: Remove useless device name from error message nodedev: Handle NULL command variable nodedev: handle mdevctl errors consistently src/node_device/node_device_driver.c | 45 ++++++++++++++-------------- 1 file changed, 23 insertions(+), 22 deletions(-) -- 2.31.1

2 6

[PATCH] virFindFileInPath: Don't pass NULL to g_canonicalize_filename()
by Michal Privoznik 15 Jun '21

15 Jun '21

If given file is not found in $PATH then g_find_program_in_path() returns NULL. However, g_canonicalize_filename() does not accept NULL as input. Fixes: 65c2901906b5e2d707f9184ff3719a5375bab427 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/util/virfile.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/util/virfile.c b/src/util/virfile.c index c302202573..4f98b011be 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -1667,6 +1667,8 @@ virFindFileInPath(const char *file) return NULL; path = g_find_program_in_path(file); + if (!path) + return NULL; /* Workaround for a bug in g_find_program_in_path() not returning absolute * path as documented. This has been fixed in -- 2.31.1

2 1

[PACH 0/2] virStorageBackendRBDGetVolNames: Fix memory leak and clean up
by Peter Krempa 15 Jun '21

15 Jun '21

Peter Krempa (2): virStorageBackendRBDGetVolNames: Fix memory leak in 'rbd_list2' version virStorageBackendRBDGetVolNames: Refactor cleanup in 'rbd_list' version src/storage/storage_backend_rbd.c | 28 +++++++++------------------- 1 file changed, 9 insertions(+), 19 deletions(-) -- 2.31.1

2 4

[PATCH 0/4] qemu: Handle the SDL capability properly
by Peter Krempa 15 Jun '21

15 Jun '21

Thomas' recent qemu patch strives to add proper detectability of SDL support: https://listman.redhat.com/archives/libvir-list/2021-June/msg00398.html This series is the libvirt counterpart. Note that all capability files we have for now claim support so the actual effect of this patch will be seen just later. Peter Krempa (4): qemu: capabilities: Introduce QEMU_CAPS_QUERY_DISPLAY_OPTIONS qemu: capabilities: Un-retire QEMU_CAPS_SDL tests: qemuxml2*: Add QEMU_CAPS_SDL to fake-caps tests using SDL graphics qemu: capabilities: Fill SDL graphics support only when it's really supported src/qemu/qemu_capabilities.c | 11 ++++++++++- src/qemu/qemu_capabilities.h | 3 ++- tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_3.0.0.riscv32.xml | 1 + tests/qemucapabilitiesdata/caps_3.0.0.riscv64.xml | 1 + tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xml | 2 ++ tests/qemucapabilitiesdata/caps_4.0.0.aarch64.xml | 2 ++ tests/qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 2 ++ tests/qemucapabilitiesdata/caps_4.0.0.riscv32.xml | 2 ++ tests/qemucapabilitiesdata/caps_4.0.0.riscv64.xml | 2 ++ tests/qemucapabilitiesdata/caps_4.0.0.s390x.xml | 2 ++ tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml | 2 ++ tests/qemucapabilitiesdata/caps_4.1.0.x86_64.xml | 2 ++ tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml | 2 ++ tests/qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 2 ++ tests/qemucapabilitiesdata/caps_4.2.0.s390x.xml | 2 ++ tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml | 2 ++ tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml | 2 ++ tests/qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 2 ++ tests/qemucapabilitiesdata/caps_5.0.0.riscv64.xml | 2 ++ tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml | 2 ++ tests/qemucapabilitiesdata/caps_5.1.0.sparc.xml | 2 ++ tests/qemucapabilitiesdata/caps_5.1.0.x86_64.xml | 2 ++ tests/qemucapabilitiesdata/caps_5.2.0.aarch64.xml | 2 ++ tests/qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 2 ++ tests/qemucapabilitiesdata/caps_5.2.0.riscv64.xml | 2 ++ tests/qemucapabilitiesdata/caps_5.2.0.s390x.xml | 2 ++ tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml | 2 ++ tests/qemucapabilitiesdata/caps_6.0.0.s390x.xml | 2 ++ tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml | 2 ++ tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml | 2 ++ tests/qemuxml2argvtest.c | 9 +++++---- tests/qemuxml2xmltest.c | 7 ++++--- 42 files changed, 85 insertions(+), 9 deletions(-) -- 2.31.1

3 7

[PATCH 00/13] String list handling cleanup in qemu capabilities code
by Peter Krempa 15 Jun '21

15 Jun '21

Peter Krempa (13): qemuMonitorJSONParsePropsList: Refactor cleanup qemuMonitorJSONGetObjectProps: Refactor cleanup qemuMonitorJSONGetMigrationCapabilities: Refactor cleanup qemuMonitorJSONGetCommands: Refactor cleanup qemuMonitorJSONGetStringArray: Refactor cleanup qemuMonitorJSONGetObjectTypes: Refactor cleanup testQemuMonitorJSONGetCommands: Refactor cleanup testQemuMonitorJSONGetTPMModels: Refactor cleanup qemu: capabilities: Use g_auto(GStrv) instead of virStringListFreeCount virQEMUCapsProcessStringFlags: Don't require 'nvalues' virQEMUCapsProbeQMPTPM: Refactor handling of string lists qemuMonitorJSONGetStringArray: Don't return element count qemuMonitorJSONGetStringListProperty: Don't return element count src/qemu/qemu_capabilities.c | 82 ++++++++------------- src/qemu/qemu_monitor_json.c | 138 ++++++++++++----------------------- tests/qemumonitorjsontest.c | 46 ++++-------- 3 files changed, 96 insertions(+), 170 deletions(-) -- 2.31.1

2 14

[PATCH] syntax-check: Only prohibit empty first lines in non-empty files
by Martin Kletzander 15 Jun '21

15 Jun '21

Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- build-aux/syntax-check.mk | 5 +++-- src/esx/README | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 1037d10cd279..eda89f40add3 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -978,7 +978,8 @@ sc_require_locale_h: sc_prohibit_empty_first_line: @$(VC_LIST_EXCEPT) | xargs awk 'BEGIN { fail=0; } \ - FNR == 1 { if ($$0 == "") { print FILENAME ":1:"; fail=1; } } \ + FNR == 1 { maybe_fail = $$0 == ""; } \ + FNR == 2 { if (maybe_fail == 1) { print FILENAME ":1:"; fail=1; } } \ END { if (fail == 1) { \ print "$(ME): Prohibited empty first line" > "/dev/stderr"; \ } exit fail; }' @@ -1835,7 +1836,7 @@ exclude_file_name_regexp--sc_prohibit_mixed_case_abbreviations = \ ^src/(vbox/vbox_CAPI.*.h|esx/esx_vi.(c|h)|esx/esx_storage_backend_iscsi.c)$$ exclude_file_name_regexp--sc_prohibit_empty_first_line = \ - ^(src/esx/README|tests/(vmwarever|virhostcpu|vircaps2xml)data/.*)$$ + ^tests/vmwareverdata/fusion-5.0.3.txt$$ exclude_file_name_regexp--sc_prohibit_useless_translation = \ ^tests/virpolkittest.c diff --git a/src/esx/README b/src/esx/README index 372227cc9c76..cc52d9e3282a 100644 --- a/src/esx/README +++ b/src/esx/README @@ -1,4 +1,3 @@ - Some links to relevant documentation ==================================== -- 2.31.1

2 1

[PATCH] docs: add a link to Gitlab on the contributing page
by Simon Chopin 15 Jun '21

15 Jun '21

I expect to find a link to the repositories when clicking on "Contribute", this patch fixes this. The wording is directly inspired by the one on the hacking page. Signed-off-by: Simon Chopin <chopin.simon(a)gmail.com> --- docs/contribute.html.in | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/contribute.html.in b/docs/contribute.html.in index d2001053fc..790114a56d 100644 --- a/docs/contribute.html.in +++ b/docs/contribute.html.in @@ -31,9 +31,10 @@ <ul> - <li>Software development. The core library / daemon (and - thus the bulk of coding) is written in C, but there are - language bindings written in Python, Perl, Java, Ruby, + <li>Software development. The official upstream code are + kept in various <a href="https://gitlab.com/libvirt/">Git repositories</a>. + The core library / daemon (and thus the bulk of coding) is written in C, + but there are language bindings written in Python, Perl, Java, Ruby, Php, OCaml and Go. There are also higher level wrappers mapping libvirt into other object frameworks, such GLib, CIM and SNMP. For those interested in working on the core parts of base-commit: 55ea45acc99c549c7757efe954aacc33ad30a8ef -- 2.32.0

2 1

[PATCH v2 00/10] capabilities: Expose HMAT
by Michal Privoznik 15 Jun '21

15 Jun '21

v2 of: https://listman.redhat.com/archives/libvir-list/2021-May/msg00878.html Patches 01-08/10 were already ACKed by Martin. But I'm sending them for completeness. diff to v1: - Switched from "access0" to "access1" when digging out bandwidth/latency info. Long story short, Linux kernel does not expose the whole interconnection table and from the documentation it looks like access1 being slightly better than access0. - Fixed recursive symlinks problem in tests. In v1 I've copied the structure from sysfs where symlinks do create loops. I don't recall why is that problem for us though. OTOH, my code does not rely on something being a symlink anyway. Michal Prívozník (10): tests: glib-ify vircaps2xmltest schemas: Allow zero <cpu/> for capabilities capabilities: Separate <cpu/> formatting into a function numa_conf: Rename virDomainCache* to virNumaCache* numa_conf: Expose virNumaCache formatter capabilities: Expose NUMA memory side cache numa_conf: Rename virDomainNumaInterconnect* to virNumaInterconnect* numa_conf: Expose virNumaInterconnect formatter capabilities: Expose NUMA interconnects vircaps2xmltest: Introduce HMAT test case build-aux/syntax-check.mk | 2 +- docs/schemas/capability.rng | 11 +- src/conf/capabilities.c | 395 ++++++++++++++++-- src/conf/capabilities.h | 5 +- src/conf/numa_conf.c | 244 +++++------ src/conf/numa_conf.h | 81 ++-- src/libvirt_private.syms | 14 +- src/libxl/libxl_capabilities.c | 3 +- src/qemu/qemu_command.c | 30 +- src/test/test_driver.c | 3 +- tests/testutils.c | 3 +- .../system/cpu/cpu0/cache/index0/level | 1 + .../system/cpu/cpu0/cache/index1/level | 1 + .../system/cpu/cpu0/cache/index2/level | 1 + .../system/cpu/cpu0/cache/index3/id | 1 + .../system/cpu/cpu0/cache/index3/level | 1 + .../cpu/cpu0/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu0/cache/index3/size | 1 + .../system/cpu/cpu0/cache/index3/type | 1 + .../system/cpu/cpu0/topology/core_id | 1 + .../system/cpu/cpu0/topology/die_id | 1 + .../cpu/cpu0/topology/physical_package_id | 1 + .../cpu/cpu0/topology/thread_siblings_list | 1 + .../system/cpu/cpu1/cache/index0/level | 1 + .../system/cpu/cpu1/cache/index1/level | 1 + .../system/cpu/cpu1/cache/index2/level | 1 + .../system/cpu/cpu1/cache/index3/id | 1 + .../system/cpu/cpu1/cache/index3/level | 1 + .../cpu/cpu1/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu1/cache/index3/size | 1 + .../system/cpu/cpu1/cache/index3/type | 1 + .../system/cpu/cpu1/topology/core_id | 1 + .../system/cpu/cpu1/topology/die_id | 1 + .../cpu/cpu1/topology/physical_package_id | 1 + .../cpu/cpu1/topology/thread_siblings_list | 1 + .../system/cpu/cpu10/cache/index0/level | 1 + .../system/cpu/cpu10/cache/index1/level | 1 + .../system/cpu/cpu10/cache/index2/level | 1 + .../system/cpu/cpu10/cache/index3/id | 1 + .../system/cpu/cpu10/cache/index3/level | 1 + .../cpu/cpu10/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu10/cache/index3/size | 1 + .../system/cpu/cpu10/cache/index3/type | 1 + .../system/cpu/cpu10/topology/core_id | 1 + .../system/cpu/cpu10/topology/die_id | 1 + .../cpu/cpu10/topology/physical_package_id | 1 + .../cpu/cpu10/topology/thread_siblings_list | 1 + .../system/cpu/cpu11/cache/index0/level | 1 + .../system/cpu/cpu11/cache/index1/level | 1 + .../system/cpu/cpu11/cache/index2/level | 1 + .../system/cpu/cpu11/cache/index3/id | 1 + .../system/cpu/cpu11/cache/index3/level | 1 + .../cpu/cpu11/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu11/cache/index3/size | 1 + .../system/cpu/cpu11/cache/index3/type | 1 + .../system/cpu/cpu11/topology/core_id | 1 + .../system/cpu/cpu11/topology/die_id | 1 + .../cpu/cpu11/topology/physical_package_id | 1 + .../cpu/cpu11/topology/thread_siblings_list | 1 + .../system/cpu/cpu12/cache/index0/level | 1 + .../system/cpu/cpu12/cache/index1/level | 1 + .../system/cpu/cpu12/cache/index2/level | 1 + .../system/cpu/cpu12/cache/index3/id | 1 + .../system/cpu/cpu12/cache/index3/level | 1 + .../cpu/cpu12/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu12/cache/index3/size | 1 + .../system/cpu/cpu12/cache/index3/type | 1 + .../system/cpu/cpu12/topology/core_id | 1 + .../system/cpu/cpu12/topology/die_id | 1 + .../cpu/cpu12/topology/physical_package_id | 1 + .../cpu/cpu12/topology/thread_siblings_list | 1 + .../system/cpu/cpu13/cache/index0/level | 1 + .../system/cpu/cpu13/cache/index1/level | 1 + .../system/cpu/cpu13/cache/index2/level | 1 + .../system/cpu/cpu13/cache/index3/id | 1 + .../system/cpu/cpu13/cache/index3/level | 1 + .../cpu/cpu13/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu13/cache/index3/size | 1 + .../system/cpu/cpu13/cache/index3/type | 1 + .../system/cpu/cpu13/topology/core_id | 1 + .../system/cpu/cpu13/topology/die_id | 1 + .../cpu/cpu13/topology/physical_package_id | 1 + .../cpu/cpu13/topology/thread_siblings_list | 1 + .../system/cpu/cpu14/cache/index0/level | 1 + .../system/cpu/cpu14/cache/index1/level | 1 + .../system/cpu/cpu14/cache/index2/level | 1 + .../system/cpu/cpu14/cache/index3/id | 1 + .../system/cpu/cpu14/cache/index3/level | 1 + .../cpu/cpu14/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu14/cache/index3/size | 1 + .../system/cpu/cpu14/cache/index3/type | 1 + .../system/cpu/cpu14/topology/core_id | 1 + .../system/cpu/cpu14/topology/die_id | 1 + .../cpu/cpu14/topology/physical_package_id | 1 + .../cpu/cpu14/topology/thread_siblings_list | 1 + .../system/cpu/cpu15/cache/index0/level | 1 + .../system/cpu/cpu15/cache/index1/level | 1 + .../system/cpu/cpu15/cache/index2/level | 1 + .../system/cpu/cpu15/cache/index3/id | 1 + .../system/cpu/cpu15/cache/index3/level | 1 + .../cpu/cpu15/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu15/cache/index3/size | 1 + .../system/cpu/cpu15/cache/index3/type | 1 + .../system/cpu/cpu15/topology/core_id | 1 + .../system/cpu/cpu15/topology/die_id | 1 + .../cpu/cpu15/topology/physical_package_id | 1 + .../cpu/cpu15/topology/thread_siblings_list | 1 + .../system/cpu/cpu16/cache/index0/level | 1 + .../system/cpu/cpu16/cache/index1/level | 1 + .../system/cpu/cpu16/cache/index2/level | 1 + .../system/cpu/cpu16/cache/index3/id | 1 + .../system/cpu/cpu16/cache/index3/level | 1 + .../cpu/cpu16/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu16/cache/index3/size | 1 + .../system/cpu/cpu16/cache/index3/type | 1 + .../system/cpu/cpu16/topology/core_id | 1 + .../system/cpu/cpu16/topology/die_id | 1 + .../cpu/cpu16/topology/physical_package_id | 1 + .../cpu/cpu16/topology/thread_siblings_list | 1 + .../system/cpu/cpu17/cache/index0/level | 1 + .../system/cpu/cpu17/cache/index1/level | 1 + .../system/cpu/cpu17/cache/index2/level | 1 + .../system/cpu/cpu17/cache/index3/id | 1 + .../system/cpu/cpu17/cache/index3/level | 1 + .../cpu/cpu17/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu17/cache/index3/size | 1 + .../system/cpu/cpu17/cache/index3/type | 1 + .../system/cpu/cpu17/topology/core_id | 1 + .../system/cpu/cpu17/topology/die_id | 1 + .../cpu/cpu17/topology/physical_package_id | 1 + .../cpu/cpu17/topology/thread_siblings_list | 1 + .../system/cpu/cpu18/cache/index0/level | 1 + .../system/cpu/cpu18/cache/index1/level | 1 + .../system/cpu/cpu18/cache/index2/level | 1 + .../system/cpu/cpu18/cache/index3/id | 1 + .../system/cpu/cpu18/cache/index3/level | 1 + .../cpu/cpu18/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu18/cache/index3/size | 1 + .../system/cpu/cpu18/cache/index3/type | 1 + .../system/cpu/cpu18/topology/core_id | 1 + .../system/cpu/cpu18/topology/die_id | 1 + .../cpu/cpu18/topology/physical_package_id | 1 + .../cpu/cpu18/topology/thread_siblings_list | 1 + .../system/cpu/cpu19/cache/index0/level | 1 + .../system/cpu/cpu19/cache/index1/level | 1 + .../system/cpu/cpu19/cache/index2/level | 1 + .../system/cpu/cpu19/cache/index3/id | 1 + .../system/cpu/cpu19/cache/index3/level | 1 + .../cpu/cpu19/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu19/cache/index3/size | 1 + .../system/cpu/cpu19/cache/index3/type | 1 + .../system/cpu/cpu19/topology/core_id | 1 + .../system/cpu/cpu19/topology/die_id | 1 + .../cpu/cpu19/topology/physical_package_id | 1 + .../cpu/cpu19/topology/thread_siblings_list | 1 + .../system/cpu/cpu2/cache/index0/level | 1 + .../system/cpu/cpu2/cache/index1/level | 1 + .../system/cpu/cpu2/cache/index2/level | 1 + .../system/cpu/cpu2/cache/index3/id | 1 + .../system/cpu/cpu2/cache/index3/level | 1 + .../cpu/cpu2/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu2/cache/index3/size | 1 + .../system/cpu/cpu2/cache/index3/type | 1 + .../system/cpu/cpu2/topology/core_id | 1 + .../system/cpu/cpu2/topology/die_id | 1 + .../cpu/cpu2/topology/physical_package_id | 1 + .../cpu/cpu2/topology/thread_siblings_list | 1 + .../system/cpu/cpu20/cache/index0/level | 1 + .../system/cpu/cpu20/cache/index1/level | 1 + .../system/cpu/cpu20/cache/index2/level | 1 + .../system/cpu/cpu20/cache/index3/id | 1 + .../system/cpu/cpu20/cache/index3/level | 1 + .../cpu/cpu20/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu20/cache/index3/size | 1 + .../system/cpu/cpu20/cache/index3/type | 1 + .../system/cpu/cpu20/topology/core_id | 1 + .../system/cpu/cpu20/topology/die_id | 1 + .../cpu/cpu20/topology/physical_package_id | 1 + .../cpu/cpu20/topology/thread_siblings_list | 1 + .../system/cpu/cpu21/cache/index0/level | 1 + .../system/cpu/cpu21/cache/index1/level | 1 + .../system/cpu/cpu21/cache/index2/level | 1 + .../system/cpu/cpu21/cache/index3/id | 1 + .../system/cpu/cpu21/cache/index3/level | 1 + .../cpu/cpu21/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu21/cache/index3/size | 1 + .../system/cpu/cpu21/cache/index3/type | 1 + .../system/cpu/cpu21/topology/core_id | 1 + .../system/cpu/cpu21/topology/die_id | 1 + .../cpu/cpu21/topology/physical_package_id | 1 + .../cpu/cpu21/topology/thread_siblings_list | 1 + .../system/cpu/cpu22/cache/index0/level | 1 + .../system/cpu/cpu22/cache/index1/level | 1 + .../system/cpu/cpu22/cache/index2/level | 1 + .../system/cpu/cpu22/cache/index3/id | 1 + .../system/cpu/cpu22/cache/index3/level | 1 + .../cpu/cpu22/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu22/cache/index3/size | 1 + .../system/cpu/cpu22/cache/index3/type | 1 + .../system/cpu/cpu22/topology/core_id | 1 + .../system/cpu/cpu22/topology/die_id | 1 + .../cpu/cpu22/topology/physical_package_id | 1 + .../cpu/cpu22/topology/thread_siblings_list | 1 + .../system/cpu/cpu23/cache/index0/level | 1 + .../system/cpu/cpu23/cache/index1/level | 1 + .../system/cpu/cpu23/cache/index2/level | 1 + .../system/cpu/cpu23/cache/index3/id | 1 + .../system/cpu/cpu23/cache/index3/level | 1 + .../cpu/cpu23/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu23/cache/index3/size | 1 + .../system/cpu/cpu23/cache/index3/type | 1 + .../system/cpu/cpu23/topology/core_id | 1 + .../system/cpu/cpu23/topology/die_id | 1 + .../cpu/cpu23/topology/physical_package_id | 1 + .../cpu/cpu23/topology/thread_siblings_list | 1 + .../system/cpu/cpu3/cache/index0/level | 1 + .../system/cpu/cpu3/cache/index1/level | 1 + .../system/cpu/cpu3/cache/index2/level | 1 + .../system/cpu/cpu3/cache/index3/id | 1 + .../system/cpu/cpu3/cache/index3/level | 1 + .../cpu/cpu3/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu3/cache/index3/size | 1 + .../system/cpu/cpu3/cache/index3/type | 1 + .../system/cpu/cpu3/topology/core_id | 1 + .../system/cpu/cpu3/topology/die_id | 1 + .../cpu/cpu3/topology/physical_package_id | 1 + .../cpu/cpu3/topology/thread_siblings_list | 1 + .../system/cpu/cpu4/cache/index0/level | 1 + .../system/cpu/cpu4/cache/index1/level | 1 + .../system/cpu/cpu4/cache/index2/level | 1 + .../system/cpu/cpu4/cache/index3/id | 1 + .../system/cpu/cpu4/cache/index3/level | 1 + .../cpu/cpu4/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu4/cache/index3/size | 1 + .../system/cpu/cpu4/cache/index3/type | 1 + .../system/cpu/cpu4/topology/core_id | 1 + .../system/cpu/cpu4/topology/die_id | 1 + .../cpu/cpu4/topology/physical_package_id | 1 + .../cpu/cpu4/topology/thread_siblings_list | 1 + .../system/cpu/cpu5/cache/index0/level | 1 + .../system/cpu/cpu5/cache/index1/level | 1 + .../system/cpu/cpu5/cache/index2/level | 1 + .../system/cpu/cpu5/cache/index3/id | 1 + .../system/cpu/cpu5/cache/index3/level | 1 + .../cpu/cpu5/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu5/cache/index3/size | 1 + .../system/cpu/cpu5/cache/index3/type | 1 + .../system/cpu/cpu5/topology/core_id | 1 + .../system/cpu/cpu5/topology/die_id | 1 + .../cpu/cpu5/topology/physical_package_id | 1 + .../cpu/cpu5/topology/thread_siblings_list | 1 + .../system/cpu/cpu6/cache/index0/level | 1 + .../system/cpu/cpu6/cache/index1/level | 1 + .../system/cpu/cpu6/cache/index2/level | 1 + .../system/cpu/cpu6/cache/index3/id | 1 + .../system/cpu/cpu6/cache/index3/level | 1 + .../cpu/cpu6/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu6/cache/index3/size | 1 + .../system/cpu/cpu6/cache/index3/type | 1 + .../system/cpu/cpu6/topology/core_id | 1 + .../system/cpu/cpu6/topology/die_id | 1 + .../cpu/cpu6/topology/physical_package_id | 1 + .../cpu/cpu6/topology/thread_siblings_list | 1 + .../system/cpu/cpu7/cache/index0/level | 1 + .../system/cpu/cpu7/cache/index1/level | 1 + .../system/cpu/cpu7/cache/index2/level | 1 + .../system/cpu/cpu7/cache/index3/id | 1 + .../system/cpu/cpu7/cache/index3/level | 1 + .../cpu/cpu7/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu7/cache/index3/size | 1 + .../system/cpu/cpu7/cache/index3/type | 1 + .../system/cpu/cpu7/topology/core_id | 1 + .../system/cpu/cpu7/topology/die_id | 1 + .../cpu/cpu7/topology/physical_package_id | 1 + .../cpu/cpu7/topology/thread_siblings_list | 1 + .../system/cpu/cpu8/cache/index0/level | 1 + .../system/cpu/cpu8/cache/index1/level | 1 + .../system/cpu/cpu8/cache/index2/level | 1 + .../system/cpu/cpu8/cache/index3/id | 1 + .../system/cpu/cpu8/cache/index3/level | 1 + .../cpu/cpu8/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu8/cache/index3/size | 1 + .../system/cpu/cpu8/cache/index3/type | 1 + .../system/cpu/cpu8/topology/core_id | 1 + .../system/cpu/cpu8/topology/die_id | 1 + .../cpu/cpu8/topology/physical_package_id | 1 + .../cpu/cpu8/topology/thread_siblings_list | 1 + .../system/cpu/cpu9/cache/index0/level | 1 + .../system/cpu/cpu9/cache/index1/level | 1 + .../system/cpu/cpu9/cache/index2/level | 1 + .../system/cpu/cpu9/cache/index3/id | 1 + .../system/cpu/cpu9/cache/index3/level | 1 + .../cpu/cpu9/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu9/cache/index3/size | 1 + .../system/cpu/cpu9/cache/index3/type | 1 + .../system/cpu/cpu9/topology/core_id | 1 + .../system/cpu/cpu9/topology/die_id | 1 + .../cpu/cpu9/topology/physical_package_id | 1 + .../cpu/cpu9/topology/thread_siblings_list | 1 + .../linux-hmat/system/cpu/online | 1 + .../node/node0/access1/initiators/node0 | 0 .../node0/access1/initiators/read_bandwidth | 1 + .../node0/access1/initiators/read_latency | 1 + .../node0/access1/initiators/write_bandwidth | 1 + .../node0/access1/initiators/write_latency | 1 + .../system/node/node0/access1/targets/node0 | 0 .../system/node/node0/access1/targets/node1 | 1 + .../linux-hmat/system/node/node0/cpulist | 1 + .../linux-hmat/system/node/node0/distance | 1 + .../hugepages-1048576kB/free_hugepages | 1 + .../hugepages-1048576kB/nr_hugepages | 1 + .../hugepages-1048576kB/surplus_hugepages | 1 + .../hugepages/hugepages-2048kB/free_hugepages | 1 + .../hugepages/hugepages-2048kB/nr_hugepages | 1 + .../hugepages-2048kB/surplus_hugepages | 1 + .../node0/memory_side_cache/index1/indexing | 1 + .../node0/memory_side_cache/index1/line_size | 1 + .../node/node0/memory_side_cache/index1/size | 1 + .../memory_side_cache/index1/write_policy | 1 + .../node0/memory_side_cache/index2/indexing | 1 + .../node0/memory_side_cache/index2/line_size | 1 + .../node/node0/memory_side_cache/index2/size | 1 + .../memory_side_cache/index2/write_policy | 1 + .../node/node1/access1/initiators/node0 | 0 .../node1/access1/initiators/read_bandwidth | 1 + .../node1/access1/initiators/read_latency | 1 + .../node1/access1/initiators/write_bandwidth | 1 + .../node1/access1/initiators/write_latency | 1 + .../linux-hmat/system/node/node1/cpulist | 1 + .../linux-hmat/system/node/node1/distance | 1 + .../hugepages-1048576kB/free_hugepages | 1 + .../hugepages-1048576kB/nr_hugepages | 1 + .../hugepages-1048576kB/surplus_hugepages | 1 + .../hugepages/hugepages-2048kB/free_hugepages | 1 + .../hugepages/hugepages-2048kB/nr_hugepages | 1 + .../hugepages-2048kB/surplus_hugepages | 1 + .../node1/memory_side_cache/index1/indexing | 1 + .../node1/memory_side_cache/index1/line_size | 1 + .../node/node1/memory_side_cache/index1/size | 1 + .../memory_side_cache/index1/write_policy | 1 + .../linux-hmat/system/node/online | 1 + tests/vircaps2xmldata/vircaps-x86_64-hmat.xml | 105 +++++ tests/vircaps2xmltest.c | 33 +- 343 files changed, 1034 insertions(+), 222 deletions(-) create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu0/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu0/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu0/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu0/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu0/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu0/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu0/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu0/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu0/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu0/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu0/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu0/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu1/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu1/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu1/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu1/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu1/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu1/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu1/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu1/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu1/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu1/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu1/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu1/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu10/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu10/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu10/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu10/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu10/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu10/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu10/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu10/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu10/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu10/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu10/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu10/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu11/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu11/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu11/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu11/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu11/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu11/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu11/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu11/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu11/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu11/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu11/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu11/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu12/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu12/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu12/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu12/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu12/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu12/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu12/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu12/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu12/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu12/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu12/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu12/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu13/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu13/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu13/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu13/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu13/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu13/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu13/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu13/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu13/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu13/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu13/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu13/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu14/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu14/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu14/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu14/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu14/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu14/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu14/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu14/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu14/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu14/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu14/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu14/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu15/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu15/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu15/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu15/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu15/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu15/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu15/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu15/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu15/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu15/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu15/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu15/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu16/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu16/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu16/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu16/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu16/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu16/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu16/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu16/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu16/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu16/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu16/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu16/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu17/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu17/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu17/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu17/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu17/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu17/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu17/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu17/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu17/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu17/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu17/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu17/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu18/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu18/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu18/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu18/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu18/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu18/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu18/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu18/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu18/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu18/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu18/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu18/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu19/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu19/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu19/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu19/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu19/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu19/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu19/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu19/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu19/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu19/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu19/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu19/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu2/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu2/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu2/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu2/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu2/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu2/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu2/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu2/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu2/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu2/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu2/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu2/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu20/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu20/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu20/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu20/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu20/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu20/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu20/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu20/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu20/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu20/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu20/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu20/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu21/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu21/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu21/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu21/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu21/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu21/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu21/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu21/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu21/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu21/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu21/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu21/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu22/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu22/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu22/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu22/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu22/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu22/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu22/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu22/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu22/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu22/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu22/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu22/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu23/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu23/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu23/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu23/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu23/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu23/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu23/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu23/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu23/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu23/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu23/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu23/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu3/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu3/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu3/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu3/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu3/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu3/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu3/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu3/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu3/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu3/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu3/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu3/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu4/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu4/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu4/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu4/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu4/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu4/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu4/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu4/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu4/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu4/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu4/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu4/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu5/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu5/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu5/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu5/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu5/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu5/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu5/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu5/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu5/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu5/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu5/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu5/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu6/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu6/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu6/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu6/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu6/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu6/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu6/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu6/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu6/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu6/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu6/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu6/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu7/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu7/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu7/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu7/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu7/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu7/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu7/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu7/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu7/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu7/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu7/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu7/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu8/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu8/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu8/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu8/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu8/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu8/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu8/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu8/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu8/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu8/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu8/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu8/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu9/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu9/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu9/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu9/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu9/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu9/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu9/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu9/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu9/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu9/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu9/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu9/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/online create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/access1/initiators/node0 create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/access1/initiators/read_bandwidth create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/access1/initiators/read_latency create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/access1/initiators/write_bandwidth create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/access1/initiators/write_latency create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/access1/targets/node0 create mode 120000 tests/vircaps2xmldata/linux-hmat/system/node/node0/access1/targets/node1 create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/cpulist create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/distance create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/hugepages/hugepages-1048576kB/free_hugepages create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/hugepages/hugepages-1048576kB/nr_hugepages create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/hugepages/hugepages-1048576kB/surplus_hugepages create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/hugepages/hugepages-2048kB/free_hugepages create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/hugepages/hugepages-2048kB/nr_hugepages create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/hugepages/hugepages-2048kB/surplus_hugepages create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/memory_side_cache/index1/indexing create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/memory_side_cache/index1/line_size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/memory_side_cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/memory_side_cache/index1/write_policy create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/memory_side_cache/index2/indexing create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/memory_side_cache/index2/line_size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/memory_side_cache/index2/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/memory_side_cache/index2/write_policy create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/access1/initiators/node0 create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/access1/initiators/read_bandwidth create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/access1/initiators/read_latency create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/access1/initiators/write_bandwidth create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/access1/initiators/write_latency create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/cpulist create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/distance create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/hugepages/hugepages-1048576kB/free_hugepages create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/hugepages/hugepages-1048576kB/nr_hugepages create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/hugepages/hugepages-1048576kB/surplus_hugepages create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/hugepages/hugepages-2048kB/free_hugepages create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/hugepages/hugepages-2048kB/nr_hugepages create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/hugepages/hugepages-2048kB/surplus_hugepages create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/memory_side_cache/index1/indexing create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/memory_side_cache/index1/line_size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/memory_side_cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/memory_side_cache/index1/write_policy create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/online create mode 100644 tests/vircaps2xmldata/vircaps-x86_64-hmat.xml -- 2.31.1

3 13

[libvirt] [PATCH 00/12] virsh bash completion improvement
by Lin Ma 15 Jun '21

15 Jun '21

Lin Ma (12): virsh: Add comp-methods completion to migrate command virsh: Use VIR_ENUM_* for --target argument in cmdNodeSuspend virsh: Add target completion to nodesuspend command virsh: Use VIR_ENUM_* for --target argument in cmdDomPMSuspend virsh: Add target completion to dompmsuspend command virsh: Add format completion to blockcopy command virsh-pool: Add virshPoolTypeCompleter in macro VIRSH_COMMON_OPT_POOL_X_AS virsh-pool: Remove static from virshStoragePoolList{Free,Collect} virsh-volume: Introduce virshStorageVolKeyCompleter virsh-volume: Add macros VIRSH_COMMON_OPT_VOL_* virsh-volume: Apply virshStorageVolKeyCompleter to vol-{name,pool} commands virsh-volume: Apply virshStorageVolNameCompleter to vol-{key,path} commands tools/virsh-completer-domain.c | 37 +++++++++++++++++++++ tools/virsh-completer-domain.h | 11 +++++++ tools/virsh-completer-host.c | 20 ++++++++++++ tools/virsh-completer-host.h | 4 +++ tools/virsh-completer-volume.c | 53 ++++++++++++++++++++++++++++++ tools/virsh-completer-volume.h | 5 +++ tools/virsh-domain.c | 14 ++++---- tools/virsh-domain.h | 1 + tools/virsh-host.c | 18 +++++----- tools/virsh-host.h | 3 ++ tools/virsh-pool.c | 11 ++----- tools/virsh-pool.h | 11 +++++++ tools/virsh-volume.c | 60 ++++++++++++++++------------------ 13 files changed, 193 insertions(+), 55 deletions(-) -- 2.26.2

3 15

[libvirt PATCH v2 0/6] use confidential-guest-support if available
by Pavel Hrdina 15 Jun '21

15 Jun '21

Changes in v2: - patch 1 split into two separate patches - AMD SEV bits added into 6.0.0 caps instead of 6.1.0 - launch-security-sev qemuxml2argv will use 'pc' machine type Pavel Hrdina (6): qemu_capabilities: introduce confidential-guest-support capability qemu_capabilities: detect if confidential-guest-support is available qemu_command: use confidential-guest-support if available tests: add AMD SEV bits into qemu-6.0.0 replies tests: use newer machine in qemuxml2argv launch-security-sev tests: add launch-security-sev test with latest capabilities src/qemu/qemu_capabilities.c | 14 +- src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_command.c | 9 +- .../domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 5 +- .../domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 5 +- tests/domaincapsdata/qemu_6.0.0.x86_64.xml | 5 +- .../caps_2.12.0.aarch64.replies | 137 ++++++++++++++-- .../caps_2.12.0.ppc64.replies | 133 +++++++++++++-- .../caps_2.12.0.s390x.replies | 137 ++++++++++++++-- .../caps_2.12.0.x86_64.replies | 153 +++++++++++++++--- .../caps_3.0.0.ppc64.replies | 133 +++++++++++++-- .../caps_3.0.0.riscv32.replies | 129 ++++++++++++++- .../caps_3.0.0.riscv64.replies | 129 ++++++++++++++- .../caps_3.0.0.s390x.replies | 137 ++++++++++++++-- .../caps_3.0.0.x86_64.replies | 153 +++++++++++++++--- .../caps_3.1.0.ppc64.replies | 133 +++++++++++++-- .../caps_3.1.0.x86_64.replies | 153 +++++++++++++++--- .../caps_4.0.0.aarch64.replies | 137 ++++++++++++++-- .../caps_4.0.0.ppc64.replies | 133 +++++++++++++-- .../caps_4.0.0.riscv32.replies | 129 ++++++++++++++- .../caps_4.0.0.riscv64.replies | 129 ++++++++++++++- .../caps_4.0.0.s390x.replies | 137 ++++++++++++++-- .../caps_4.0.0.x86_64.replies | 153 +++++++++++++++--- .../caps_4.1.0.x86_64.replies | 145 +++++++++++++++-- .../caps_4.2.0.aarch64.replies | 141 ++++++++++++++-- .../caps_4.2.0.ppc64.replies | 133 +++++++++++++-- .../caps_4.2.0.s390x.replies | 137 ++++++++++++++-- .../caps_4.2.0.x86_64.replies | 145 +++++++++++++++-- .../caps_5.0.0.aarch64.replies | 126 +++++++++++++-- .../caps_5.0.0.ppc64.replies | 118 ++++++++++++-- .../caps_5.0.0.riscv64.replies | 114 ++++++++++++- .../caps_5.0.0.x86_64.replies | 130 +++++++++++++-- .../caps_5.1.0.sparc.replies | 114 ++++++++++++- .../caps_5.1.0.x86_64.replies | 130 +++++++++++++-- .../caps_5.2.0.aarch64.replies | 121 ++++++++++++-- .../caps_5.2.0.ppc64.replies | 113 +++++++++++-- .../caps_5.2.0.riscv64.replies | 109 ++++++++++++- .../caps_5.2.0.s390x.replies | 117 ++++++++++++-- .../caps_5.2.0.x86_64.replies | 125 ++++++++++++-- .../caps_6.0.0.s390x.replies | 130 +++++++++++++-- .../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 1 + .../caps_6.0.0.x86_64.replies | 148 ++++++++++++++--- .../caps_6.0.0.x86_64.xml | 8 + .../caps_6.1.0.x86_64.replies | 138 ++++++++++++++-- .../caps_6.1.0.x86_64.xml | 1 + .../launch-security-sev.x86_64-2.12.0.args | 2 +- .../launch-security-sev.x86_64-6.0.0.args | 36 +++++ .../qemuxml2argvdata/launch-security-sev.xml | 2 +- tests/qemuxml2argvtest.c | 1 + 49 files changed, 4403 insertions(+), 468 deletions(-) create mode 100644 tests/qemuxml2argvdata/launch-security-sev.x86_64-6.0.0.args -- 2.31.1

2 10

[PATCH 0/2] test_driver: Implement some Security related APIs
by Luke Yue 15 Jun '21

15 Jun '21

Luke Yue (2): test_driver: Implement virNodeGetSecurityModel test_driver: Implement virDomainGetSecurityLabel src/test/test_driver.c | 63 ++++++++++++++++++++++++++++++++++++++++++ tests/virshtest.c | 4 +++ 2 files changed, 67 insertions(+) -- 2.31.1

2 4

[PATCH v2 0/2] Replace some libvirt handling function with GLib APIs
by Luke Yue 15 Jun '21

15 Jun '21

Compared to original: - Ensure the virFindFileInPath() return an absolute path (tried to use glibcompat, failed to solve some Windows related issue) - Just remove virFileAbsPath() and use g_canonicalize_filename() instead Luke Yue (2): Replace virFileAbsPath() with g_canonicalize_filename() virfile: Simplify virFindFileInPath() with g_find_program_in_path() src/libvirt-domain.c | 16 +++++----- src/libvirt_private.syms | 1 - src/util/virfile.c | 69 ++-------------------------------------- src/util/virfile.h | 3 -- src/util/virlog.c | 2 +- 5 files changed, 12 insertions(+), 79 deletions(-) -- 2.31.1

2 4

[libvirt PATCH 0/5] use confidential-guest-support if available
by Pavel Hrdina 14 Jun '21

14 Jun '21

Pavel Hrdina (5): qemu_capabilities: detect if confidential-guest-support is available qemu_command: use confidential-guest-support if available tests: add AMD SEV bits into qemu-6.1.0 replies tests: use newer machine in qemuxml2argv launch-security-sev tests: add launch-security-sev test with latest capabilities src/qemu/qemu_capabilities.c | 14 +- src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_command.c | 9 +- .../domaincapsdata/qemu_6.1.0-q35.x86_64.xml | 5 +- .../domaincapsdata/qemu_6.1.0-tcg.x86_64.xml | 5 +- tests/domaincapsdata/qemu_6.1.0.x86_64.xml | 5 +- .../caps_2.12.0.aarch64.replies | 137 ++++++++++++++-- .../caps_2.12.0.ppc64.replies | 133 +++++++++++++-- .../caps_2.12.0.s390x.replies | 137 ++++++++++++++-- .../caps_2.12.0.x86_64.replies | 153 +++++++++++++++--- .../caps_3.0.0.ppc64.replies | 133 +++++++++++++-- .../caps_3.0.0.riscv32.replies | 129 ++++++++++++++- .../caps_3.0.0.riscv64.replies | 129 ++++++++++++++- .../caps_3.0.0.s390x.replies | 137 ++++++++++++++-- .../caps_3.0.0.x86_64.replies | 153 +++++++++++++++--- .../caps_3.1.0.ppc64.replies | 133 +++++++++++++-- .../caps_3.1.0.x86_64.replies | 153 +++++++++++++++--- .../caps_4.0.0.aarch64.replies | 137 ++++++++++++++-- .../caps_4.0.0.ppc64.replies | 133 +++++++++++++-- .../caps_4.0.0.riscv32.replies | 129 ++++++++++++++- .../caps_4.0.0.riscv64.replies | 129 ++++++++++++++- .../caps_4.0.0.s390x.replies | 137 ++++++++++++++-- .../caps_4.0.0.x86_64.replies | 153 +++++++++++++++--- .../caps_4.1.0.x86_64.replies | 145 +++++++++++++++-- .../caps_4.2.0.aarch64.replies | 141 ++++++++++++++-- .../caps_4.2.0.ppc64.replies | 133 +++++++++++++-- .../caps_4.2.0.s390x.replies | 137 ++++++++++++++-- .../caps_4.2.0.x86_64.replies | 145 +++++++++++++++-- .../caps_5.0.0.aarch64.replies | 126 +++++++++++++-- .../caps_5.0.0.ppc64.replies | 118 ++++++++++++-- .../caps_5.0.0.riscv64.replies | 114 ++++++++++++- .../caps_5.0.0.x86_64.replies | 130 +++++++++++++-- .../caps_5.1.0.sparc.replies | 114 ++++++++++++- .../caps_5.1.0.x86_64.replies | 130 +++++++++++++-- .../caps_5.2.0.aarch64.replies | 121 ++++++++++++-- .../caps_5.2.0.ppc64.replies | 113 +++++++++++-- .../caps_5.2.0.riscv64.replies | 109 ++++++++++++- .../caps_5.2.0.s390x.replies | 117 ++++++++++++-- .../caps_5.2.0.x86_64.replies | 125 ++++++++++++-- .../caps_6.0.0.s390x.replies | 130 +++++++++++++-- .../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 1 + .../caps_6.0.0.x86_64.replies | 138 ++++++++++++++-- .../caps_6.0.0.x86_64.xml | 1 + .../caps_6.1.0.x86_64.replies | 148 ++++++++++++++--- .../caps_6.1.0.x86_64.xml | 8 + .../launch-security-sev.x86_64-2.12.0.args | 2 +- .../launch-security-sev.x86_64-latest.args | 36 +++++ .../qemuxml2argvdata/launch-security-sev.xml | 2 +- tests/qemuxml2argvtest.c | 1 + 49 files changed, 4403 insertions(+), 468 deletions(-) create mode 100644 tests/qemuxml2argvdata/launch-security-sev.x86_64-latest.args -- 2.31.1

2 13

[PATCH 0/3] Couple of cleanups
by Michal Privoznik 14 Jun '21

14 Jun '21

I've noticed these while reviewing Tim's asan patches. Michal Prívozník (3): Don't call qsort() over NULL tests: Don't pass INT_MAX to virFileReadAll() src: Use 1U for bit shifting src/conf/capabilities.c | 6 ++++-- src/conf/domain_capabilities.h | 2 +- src/cpu/cpu_x86.c | 10 +++++----- src/security/security_manager.c | 3 ++- tests/networkxml2firewalltest.c | 2 +- tests/testutils.c | 4 ++-- tools/nss/libvirt_nss.c | 3 ++- 7 files changed, 17 insertions(+), 13 deletions(-) -- 2.31.1

5 13

[libvirt PATCH] qemu_firmware: select correct firmware for AMD SEV-ES
by Pavel Hrdina 14 Jun '21

14 Jun '21

When using firmware auto-selection and user enables AMD SEV-ES we need to pick correct firmware that actually supports it. This can be detected by having `amd-sev-es` in the firmware JSON description. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/qemu/qemu_firmware.c | 28 ++++++++++++++++++++++++---- 1 file changed, 24 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c index 2aeac635da..8d10497717 100644 --- a/src/qemu/qemu_firmware.c +++ b/src/qemu/qemu_firmware.c @@ -129,6 +129,7 @@ typedef enum { QEMU_FIRMWARE_FEATURE_ACPI_S3, QEMU_FIRMWARE_FEATURE_ACPI_S4, QEMU_FIRMWARE_FEATURE_AMD_SEV, + QEMU_FIRMWARE_FEATURE_AMD_SEV_ES, QEMU_FIRMWARE_FEATURE_ENROLLED_KEYS, QEMU_FIRMWARE_FEATURE_REQUIRES_SMM, QEMU_FIRMWARE_FEATURE_SECURE_BOOT, @@ -145,6 +146,7 @@ VIR_ENUM_IMPL(qemuFirmwareFeature, "acpi-s3", "acpi-s4", "amd-sev", + "amd-sev-es", "enrolled-keys", "requires-smm", "secure-boot", @@ -913,6 +915,9 @@ qemuFirmwareOSInterfaceTypeFromOsDefFirmware(int fw) } +#define VIR_QEMU_FIRMWARE_AMD_SEV_ES_POLICY (1 << 2) + + static bool qemuFirmwareMatchDomain(const virDomainDef *def, const qemuFirmware *fw, @@ -924,6 +929,7 @@ qemuFirmwareMatchDomain(const virDomainDef *def, bool supportsS4 = false; bool requiresSMM = false; bool supportsSEV = false; + bool supportsSEVES = false; bool supportsSecureBoot = false; bool hasEnrolledKeys = false; int reqSecureBoot; @@ -972,6 +978,11 @@ qemuFirmwareMatchDomain(const virDomainDef *def, case QEMU_FIRMWARE_FEATURE_AMD_SEV: supportsSEV = true; break; + + case QEMU_FIRMWARE_FEATURE_AMD_SEV_ES: + supportsSEVES = true; + break; + case QEMU_FIRMWARE_FEATURE_REQUIRES_SMM: requiresSMM = true; break; @@ -1043,10 +1054,16 @@ qemuFirmwareMatchDomain(const virDomainDef *def, } if (def->sev && - def->sev->sectype == VIR_DOMAIN_LAUNCH_SECURITY_SEV && - !supportsSEV) { - VIR_DEBUG("Domain requires SEV, firmware '%s' doesn't support it", path); - return false; + def->sev->sectype == VIR_DOMAIN_LAUNCH_SECURITY_SEV) { + if (!supportsSEV) { + VIR_DEBUG("Domain requires SEV, firmware '%s' doesn't support it", path); + return false; + } + + if (def->sev->policy & VIR_QEMU_FIRMWARE_AMD_SEV_ES_POLICY && !supportsSEVES) { + VIR_DEBUG("Domain requires SEV-ES, firmware '%s' doesn't support it", path); + return false; + } } VIR_DEBUG("Firmware '%s' matches domain requirements", path); @@ -1148,6 +1165,7 @@ qemuFirmwareEnableFeatures(virQEMUDriver *driver, case QEMU_FIRMWARE_FEATURE_ACPI_S3: case QEMU_FIRMWARE_FEATURE_ACPI_S4: case QEMU_FIRMWARE_FEATURE_AMD_SEV: + case QEMU_FIRMWARE_FEATURE_AMD_SEV_ES: case QEMU_FIRMWARE_FEATURE_ENROLLED_KEYS: case QEMU_FIRMWARE_FEATURE_SECURE_BOOT: case QEMU_FIRMWARE_FEATURE_VERBOSE_DYNAMIC: @@ -1181,6 +1199,7 @@ qemuFirmwareSanityCheck(const qemuFirmware *fw, case QEMU_FIRMWARE_FEATURE_ACPI_S3: case QEMU_FIRMWARE_FEATURE_ACPI_S4: case QEMU_FIRMWARE_FEATURE_AMD_SEV: + case QEMU_FIRMWARE_FEATURE_AMD_SEV_ES: case QEMU_FIRMWARE_FEATURE_ENROLLED_KEYS: case QEMU_FIRMWARE_FEATURE_VERBOSE_DYNAMIC: case QEMU_FIRMWARE_FEATURE_VERBOSE_STATIC: @@ -1412,6 +1431,7 @@ qemuFirmwareGetSupported(const char *machine, case QEMU_FIRMWARE_FEATURE_ACPI_S3: case QEMU_FIRMWARE_FEATURE_ACPI_S4: case QEMU_FIRMWARE_FEATURE_AMD_SEV: + case QEMU_FIRMWARE_FEATURE_AMD_SEV_ES: case QEMU_FIRMWARE_FEATURE_ENROLLED_KEYS: case QEMU_FIRMWARE_FEATURE_SECURE_BOOT: case QEMU_FIRMWARE_FEATURE_VERBOSE_DYNAMIC: -- 2.31.1

2 2

[libvirt PATCH v2 0/7] Enable sanitizers
by Tim Wiederhake 14 Jun '21

14 Jun '21

This series enables and adds AddressSanitizer and UndefinedBehaviorSanitizer builds to the CI. See: https://clang.llvm.org/docs/AddressSanitizer.html and https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html These sanitizers already found some issues in libvirt, e.g. 4eb7c621985dad4de911ec394ac628bd1a5b29ab, 1294de209cee6643511265c7e2d4283c047cf652, 8b8c91f487592c6c067847ca59dde405ca17573f, or 1c34211c22de28127a509edbf2cf2f44cb0d891e. There exist two more relevant sanitizers, ThreadSanitizer and MemorySanitizer. Unfortunately, those two require an instrumented build of all dependencies, including libc, to work correctly. Note that clang and gcc have different implementations of these sanitizers, hence the introduction of two new jobs to the CI. The latter one issues a warning about the use of LD_PRELOAD in `virTestMain`, which in this particular case can be safely ignored by setting `ASAN_OPTIONS` to verify_asan_link_order=0` for the gcc build. Changes since V1: Incorporated changes suggested by Pavel, except for #6 (now #7): The statement in https://listman.redhat.com/archives/libvir-list/2021-May/msg00070.html on the sanitizers working with Fedora 33 is wrong, I was fooled by caching. The bug described there is present in Fedora 33, 34, and Rawhide. Cheers, Tim Tim Wiederhake (7): meson: Allow larger stack frames when instrumenting meson: Allow undefined symbols when sanitizers are enabled tests: virfilemock: realpath: Allow non-null second parameter openvz: Add missing symbols to libvirt_openvz.syms tests: openvzutilstest: Remove duplicate linking with libvirt_openvz.a virt-aa-helper: Remove duplicate linking with src/datatypes.o ci: Enable address and undefined behavior sanitizers .gitlab-ci.yml | 35 +++++++++++++++++++++++++++++++++++ build-aux/syntax-check.mk | 2 +- meson.build | 14 ++++++++++---- src/libvirt_openvz.syms | 2 ++ src/security/meson.build | 1 - tests/meson.build | 2 +- tests/virfilemock.c | 20 ++++++++++++-------- 7 files changed, 61 insertions(+), 15 deletions(-) -- 2.26.3

5 16

[PATCH 0/7] qemu: Rework qemuBuildDeviceVideoStr() slightly
by Michal Privoznik 11 Jun '21

11 Jun '21

The most important patch is 7/7, IMO. The rest is just prep work. Michal Prívozník (7): qemuDomainSupportsVideoVga: Fix const correctness qemuBuildDeviceVideoStr: Separate out video module selection qemuDeviceVideoGetModel: Deduplicate a check qemu_command: Switch from VIR_ENUM_IMPL(qemuDeviceVideo) to explicit switch() qemu_command: Switch from VIR_ENUM_IMPL(qemuDeviceVideoSecondary) to explicit switch() qemuBuildDeviceVideoStr: Move logic wrapping qemuBuildVirtioDevStr() into qemuDeviceVideoGetModel() qemuBuildDeviceVideoStr: Don't overwrite @model src/qemu/qemu_command.c | 159 +++++++++++++++++++++++++--------------- src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_domain.h | 2 +- 3 files changed, 102 insertions(+), 61 deletions(-) -- 2.31.1

2 11

[PATCH v2 0/6] qemu: Adapt to virtio*gl* devices
by Han Han 11 Jun '21

11 Jun '21

Diff from v1: - Leave qemuBuildVirtioDevStr() unmodified - New patch: qemu_validate: Validate virtio*gl* devices for 3d accerlation - Use DO_TEST_CAPS_LATEST instead of DO_TEST - Save video-virtio-vga-gpu-gl.x86_64-latest.xml as the sym link of tests/qemuxml2argvdata/video-virtio-vga-gpu-gl.xml v1: https://listman.redhat.com/archives/libvir-list/2021-June/msg00181.html Han Han (6): qemu_capabilities: Add QEMU_CAPS_VIRTIO_GPU_GL_PCI qemu_capabilities: Add QEMU_CAPS_VIRTIO_VGA_GL qemu_validate: Validate virtio*gl* devices for 3d accerlation qemu: Adapt to virtio-gpu-gl-pci device qemu: Adapt to virtio-vga-gl device tests: Tests for virtio-vga-gl and virtio-gpu-gl-pci device src/qemu/qemu_capabilities.c | 4 ++ src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_command.c | 8 ++++ src/qemu/qemu_validate.c | 4 +- .../caps_6.1.0.x86_64.xml | 2 + ...video-virtio-vga-gpu-gl.x86_64-latest.args | 35 ++++++++++++++ .../video-virtio-vga-gpu-gl.xml | 46 +++++++++++++++++++ tests/qemuxml2argvtest.c | 1 + .../video-virtio-vga-gpu-gl.x86_64-latest.xml | 1 + tests/qemuxml2xmltest.c | 1 + 10 files changed, 103 insertions(+), 1 deletion(-) create mode 100644 tests/qemuxml2argvdata/video-virtio-vga-gpu-gl.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/video-virtio-vga-gpu-gl.xml create mode 120000 tests/qemuxml2xmloutdata/video-virtio-vga-gpu-gl.x86_64-latest.xml -- 2.31.1

2 13

[libvirt PATCH] cpu_map: Add cpu feature avx-vnni
by Tim Wiederhake 11 Jun '21

11 Jun '21

"avx-vvni" was introduced to qemu in commit c1826ea6a052084f2e6a0bae9dd5932a727df039, adding it Cooperlake. This feature is currently not used by any libvirt CPU models, but its addition silences a warning from sync_qemu_i386.py: ``` warning: Unknown feature 'CPUID_7_1_EAX_AVX_VNNI' warning: Feature unknown to libvirt: CPUID_7_1_EAX_AVX_VNNI ``` Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com> --- src/cpu_map/sync_qemu_i386.py | 1 + src/cpu_map/x86_features.xml | 3 +++ 2 files changed, 4 insertions(+) diff --git a/src/cpu_map/sync_qemu_i386.py b/src/cpu_map/sync_qemu_i386.py index 92bb58f75b..4dd9f3b84d 100755 --- a/src/cpu_map/sync_qemu_i386.py +++ b/src/cpu_map/sync_qemu_i386.py @@ -73,6 +73,7 @@ def translate_feature(name): "CPUID_7_0_EDX_SPEC_CTRL_SSBD": "ssbd", "CPUID_7_0_EDX_STIBP": "stibp", "CPUID_7_1_EAX_AVX512_BF16": "avx512-bf16", + "CPUID_7_1_EAX_AVX_VNNI": "avx-vnni", "CPUID_8000_0008_EBX_AMD_SSBD": "amd-ssbd", "CPUID_8000_0008_EBX_CLZERO": "clzero", "CPUID_8000_0008_EBX_IBPB": "ibpb", diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index e98b84f3ef..4cf3ff0804 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -363,6 +363,9 @@ <cpuid eax_in='0x07' ecx_in='0x00' edx='0x80000000'/> </feature> + <feature name='avx-vnni'> + <cpuid eax_in='0x07' ecx_in='0x01' eax='0x00000010'/> + </feature> <feature name='avx512-bf16'> <cpuid eax_in='0x07' ecx_in='0x01' eax='0x00000020'/> </feature> -- 2.31.1

2 1

[libvirt PATCH v2 0/7] Enable autostarting mediated devices
by Jonathon Jongsma 10 Jun '21

10 Jun '21

This series replaces the initial patch that was recently reverted. It implements the autostart feature using a new virNodeDeviceGet/SetAutostart() API that is consistent with how other libvirt objects handle autostart. It also adds a counterpart virsh command nodedev-autostart. In order to easily check the 'autostart' status of the device (since it is no longer part of the device xml), a new virsh command is introduced: nodedev-info. This also presents a few more basic bits of information about the device, including 'active' and 'persistent' status, which requires exposing new APIs on the node device: IsActive() and IsPersistent(). These APIs are consistent with existing libvirt objects. Changes in version 2: - Parse the autostart property from mdevctl output. - only re-sending patch 2/7, all others were already ACKED Jonathon Jongsma (7): api: add virNodeDevice(Get|Set)Autostart() nodedev: implement virNodeDevice(Get|Set)Autostart() nodedev: Add tests for mdevctl autostart command virsh: add nodedev-autostart api: add virNodeDeviceIsPersistent()/IsActive() nodedev: Implement virNodeDeviceIsPersistent()/IsActive() virsh: add nodedev-info docs/manpages/virsh.rst | 27 +++ include/libvirt/libvirt-nodedev.h | 10 + src/conf/node_device_conf.h | 1 + src/conf/virnodedeviceobj.c | 16 ++ src/conf/virnodedeviceobj.h | 6 + src/driver-nodedev.h | 18 ++ src/libvirt-nodedev.c | 141 ++++++++++++++ src/libvirt_private.syms | 2 + src/libvirt_public.syms | 6 + src/node_device/node_device_driver.c | 183 +++++++++++++++++- src/node_device/node_device_driver.h | 19 ++ src/node_device/node_device_udev.c | 30 ++- src/remote/remote_driver.c | 6 +- src/remote/remote_protocol.x | 59 +++++- src/remote_protocol-structs | 26 +++ .../nodedevmdevctldata/mdevctl-autostart.argv | 8 + tests/nodedevmdevctltest.c | 54 ++++++ tools/virsh-nodedev.c | 139 +++++++++++++ 18 files changed, 744 insertions(+), 7 deletions(-) create mode 100644 tests/nodedevmdevctldata/mdevctl-autostart.argv -- 2.31.1

1 2

[RFC QEMU PATCH] ui: Make the DisplayType enum entries conditional
by Thomas Huth 10 Jun '21

10 Jun '21

Libvirt's "domcapabilities" command has a way to state whether certain graphic frontends are available in QEMU or not. Originally, libvirt looked at the "--help" output of the QEMU binary to determine whether SDL was available or not (by looking for the "-sdl" parameter in the help text), but since libvirt stopped doing this analysis of the help text, the detection of SDL is currently broken, see: https://bugzilla.redhat.com/show_bug.cgi?id=1790902 QEMU should provide a way via the QMP interface instead. The simplest way, without introducing additional commands, is to make the DisplayType enum entries conditional, so that the enum only contains the entries if the corresponding CONFIG_xxx switches have been set. Unfortunately, this only works for sdl, cocoa and spice, since gtk, egl-headless and curses are hard-wired in the "data" section of the DisplayOptions, and thus unfortunately always have to be defined. Signed-off-by: Thomas Huth <thuth(a)redhat.com> --- qapi/ui.json | 12 +++++++++--- ui/console.c | 4 ++++ 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/qapi/ui.json b/qapi/ui.json index 1052ca9c38..c4f44cfe50 100644 --- a/qapi/ui.json +++ b/qapi/ui.json @@ -1126,9 +1126,15 @@ # ## { 'enum' : 'DisplayType', - 'data' : [ 'default', 'none', 'gtk', 'sdl', - 'egl-headless', 'curses', 'cocoa', - 'spice-app'] } + 'data' : [ + { 'name': 'default' }, + { 'name': 'none' }, + { 'name': 'gtk' }, + { 'name': 'sdl', 'if': 'defined(CONFIG_SDL)' }, + { 'name': 'egl-headless' }, + { 'name': 'curses' }, + { 'name': 'cocoa', 'if': 'defined(CONFIG_COCOA)' }, + { 'name': 'spice-app', 'if': 'defined(CONFIG_SPICE)'} ] } ## # @DisplayOptions: diff --git a/ui/console.c b/ui/console.c index 2de5f4105b..954f7162c3 100644 --- a/ui/console.c +++ b/ui/console.c @@ -2371,8 +2371,12 @@ bool qemu_display_find_default(DisplayOptions *opts) { static DisplayType prio[] = { DISPLAY_TYPE_GTK, +#if defined(CONFIG_SDL) DISPLAY_TYPE_SDL, +#endif +#if defined(CONFIG_COCOA) DISPLAY_TYPE_COCOA +#endif }; int i; -- 2.27.0

4 11

[PATCH] domain_conf: Use virXMLFormatElement() more
by Michal Privoznik 09 Jun '21

09 Jun '21

I've identified some places (mostly by looking for virBufferUse()) that can use virXMLFormatElement() instead of open coded version of it. I'm sure there are many more places that could use the same treatment. Let's cure them some other time. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Based on Dan's series he posted earlier today: https://listman.redhat.com/archives/libvir-list/2021-June/msg00060.html src/conf/domain_conf.c | 74 +++++++++++++++--------------------------- 1 file changed, 27 insertions(+), 47 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 7b9de2e92d..139cdfc0a7 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -25177,6 +25177,7 @@ virDomainSmartcardDefFormat(virBuffer *buf, { const char *mode = virDomainSmartcardTypeToString(def->type); g_auto(virBuffer) childBuf = VIR_BUFFER_INIT_CHILD(buf); + g_auto(virBuffer) attrBuf = VIR_BUFFER_INITIALIZER; size_t i; if (!mode) { @@ -25209,19 +25210,13 @@ virDomainSmartcardDefFormat(virBuffer *buf, } virDomainDeviceInfoFormat(&childBuf, &def->info, flags); - virBufferAsprintf(buf, "<smartcard mode='%s'", mode); + virBufferAsprintf(&attrBuf, " mode='%s'", mode); if (def->type == VIR_DOMAIN_SMARTCARD_TYPE_PASSTHROUGH && - virDomainChrAttrsDefFormat(buf, def->data.passthru, false) < 0) { + virDomainChrAttrsDefFormat(&attrBuf, def->data.passthru, false) < 0) { return -1; } - if (virBufferUse(&childBuf)) { - virBufferAddLit(buf, ">\n"); - virBufferAddBuffer(buf, &childBuf); - virBufferAddLit(buf, "</smartcard>\n"); - } else { - virBufferAddLit(buf, "/>\n"); - } + virXMLFormatElement(buf, "smartcard", &attrBuf, &childBuf); return 0; } @@ -25300,6 +25295,7 @@ virDomainSoundDefFormat(virBuffer *buf, { const char *model = virDomainSoundModelTypeToString(def->model); g_auto(virBuffer) childBuf = VIR_BUFFER_INIT_CHILD(buf); + g_auto(virBuffer) attrBuf = VIR_BUFFER_INITIALIZER; size_t i; if (!model) { @@ -25316,14 +25312,9 @@ virDomainSoundDefFormat(virBuffer *buf, virDomainDeviceInfoFormat(&childBuf, &def->info, flags); - virBufferAsprintf(buf, "<sound model='%s'", model); - if (virBufferUse(&childBuf)) { - virBufferAddLit(buf, ">\n"); - virBufferAddBuffer(buf, &childBuf); - virBufferAddLit(buf, "</sound>\n"); - } else { - virBufferAddLit(buf, "/>\n"); - } + virBufferAsprintf(&attrBuf, " model='%s'", model); + + virXMLFormatElement(buf, "sound", &attrBuf, &childBuf); return 0; } @@ -25453,6 +25444,7 @@ virDomainAudioDefFormat(virBuffer *buf, virDomainAudioDef *def) { g_auto(virBuffer) childBuf = VIR_BUFFER_INIT_CHILD(buf); + g_auto(virBuffer) attrBuf = VIR_BUFFER_INITIALIZER; g_auto(virBuffer) inputBuf = VIR_BUFFER_INITIALIZER; g_auto(virBuffer) outputBuf = VIR_BUFFER_INITIALIZER; const char *type = virDomainAudioTypeTypeToString(def->type); @@ -25463,10 +25455,10 @@ virDomainAudioDefFormat(virBuffer *buf, return -1; } - virBufferAsprintf(buf, "<audio id='%d' type='%s'", def->id, type); + virBufferAsprintf(&attrBuf, " id='%d' type='%s'", def->id, type); if (def->timerPeriod) - virBufferAsprintf(buf, " timerPeriod='%u'", def->timerPeriod); + virBufferAsprintf(&attrBuf, " timerPeriod='%u'", def->timerPeriod); switch (def->type) { case VIR_DOMAIN_AUDIO_TYPE_NONE: @@ -25489,20 +25481,20 @@ virDomainAudioDefFormat(virBuffer *buf, case VIR_DOMAIN_AUDIO_TYPE_OSS: if (def->backend.oss.tryMMap) - virBufferAsprintf(buf, " tryMMap='%s'", + virBufferAsprintf(&attrBuf, " tryMMap='%s'", virTristateBoolTypeToString(def->backend.oss.tryMMap)); if (def->backend.oss.exclusive) - virBufferAsprintf(buf, " exclusive='%s'", + virBufferAsprintf(&attrBuf, " exclusive='%s'", virTristateBoolTypeToString(def->backend.oss.exclusive)); if (def->backend.oss.dspPolicySet) - virBufferAsprintf(buf, " dspPolicy='%d'", def->backend.oss.dspPolicy); + virBufferAsprintf(&attrBuf, " dspPolicy='%d'", def->backend.oss.dspPolicy); virDomainAudioOSSFormat(&def->backend.oss.input, &inputBuf); virDomainAudioOSSFormat(&def->backend.oss.output, &outputBuf); break; case VIR_DOMAIN_AUDIO_TYPE_PULSEAUDIO: - virBufferEscapeString(buf, " serverName='%s'", + virBufferEscapeString(&attrBuf, " serverName='%s'", def->backend.pulseaudio.serverName); virDomainAudioPulseAudioFormat(&def->backend.pulseaudio.input, &inputBuf); @@ -25511,7 +25503,7 @@ virDomainAudioDefFormat(virBuffer *buf, case VIR_DOMAIN_AUDIO_TYPE_SDL: if (def->backend.sdl.driver) - virBufferAsprintf(buf, " driver='%s'", + virBufferAsprintf(&attrBuf, " driver='%s'", virDomainAudioSDLDriverTypeToString( def->backend.sdl.driver)); @@ -25523,7 +25515,7 @@ virDomainAudioDefFormat(virBuffer *buf, break; case VIR_DOMAIN_AUDIO_TYPE_FILE: - virBufferEscapeString(buf, " path='%s'", def->backend.file.path); + virBufferEscapeString(&attrBuf, " path='%s'", def->backend.file.path); break; case VIR_DOMAIN_AUDIO_TYPE_LAST: @@ -25535,13 +25527,7 @@ virDomainAudioDefFormat(virBuffer *buf, virDomainAudioCommonFormat(&def->input, &childBuf, &inputBuf, "input"); virDomainAudioCommonFormat(&def->output, &childBuf, &outputBuf, "output"); - if (virBufferUse(&childBuf)) { - virBufferAddLit(buf, ">\n"); - virBufferAddBuffer(buf, &childBuf); - virBufferAddLit(buf, "</audio>\n"); - } else { - virBufferAddLit(buf, "/>\n"); - } + virXMLFormatElement(buf, "audio", &attrBuf, &childBuf); return 0; } @@ -27002,6 +26988,7 @@ virDomainCachetuneDefFormat(virBuffer *buf, unsigned int flags) { g_auto(virBuffer) childrenBuf = VIR_BUFFER_INIT_CHILD(buf); + g_auto(virBuffer) attrBuf = VIR_BUFFER_INITIALIZER; size_t i = 0; g_autofree char *vcpus = NULL; @@ -27024,19 +27011,17 @@ virDomainCachetuneDefFormat(virBuffer *buf, if (!vcpus) return -1; - virBufferAsprintf(buf, "<cachetune vcpus='%s'", vcpus); + virBufferAsprintf(&attrBuf, " vcpus='%s'", vcpus); if (!(flags & VIR_DOMAIN_DEF_FORMAT_INACTIVE)) { const char *alloc_id = virResctrlAllocGetID(resctrl->alloc); if (!alloc_id) return -1; - virBufferAsprintf(buf, " id='%s'", alloc_id); + virBufferAsprintf(&attrBuf, " id='%s'", alloc_id); } - virBufferAddLit(buf, ">\n"); - virBufferAddBuffer(buf, &childrenBuf); - virBufferAddLit(buf, "</cachetune>\n"); + virXMLFormatElement(buf, "cachetune", &attrBuf, &childrenBuf); return 0; } @@ -27062,6 +27047,7 @@ virDomainMemorytuneDefFormat(virBuffer *buf, unsigned int flags) { g_auto(virBuffer) childrenBuf = VIR_BUFFER_INIT_CHILD(buf); + g_auto(virBuffer) attrBuf = VIR_BUFFER_INITIALIZER; g_autofree char *vcpus = NULL; size_t i = 0; @@ -27084,19 +27070,17 @@ virDomainMemorytuneDefFormat(virBuffer *buf, if (!vcpus) return -1; - virBufferAsprintf(buf, "<memorytune vcpus='%s'", vcpus); + virBufferAsprintf(&attrBuf, " vcpus='%s'", vcpus); if (!(flags & VIR_DOMAIN_DEF_FORMAT_INACTIVE)) { const char *alloc_id = virResctrlAllocGetID(resctrl->alloc); if (!alloc_id) return -1; - virBufferAsprintf(buf, " id='%s'", alloc_id); + virBufferAsprintf(&attrBuf, " id='%s'", alloc_id); } - virBufferAddLit(buf, ">\n"); - virBufferAddBuffer(buf, &childrenBuf); - virBufferAddLit(buf, "</memorytune>\n"); + virXMLFormatElement(buf, "memorytune", &attrBuf, &childrenBuf); return 0; } @@ -27213,11 +27197,7 @@ virDomainCputuneDefFormat(virBuffer *buf, for (i = 0; i < def->nresctrls; i++) virDomainMemorytuneDefFormat(&childrenBuf, def->resctrls[i], flags); - if (virBufferUse(&childrenBuf)) { - virBufferAddLit(buf, "<cputune>\n"); - virBufferAddBuffer(buf, &childrenBuf); - virBufferAddLit(buf, "</cputune>\n"); - } + virXMLFormatElement(buf, "cputune", NULL, &childrenBuf); return 0; } -- 2.31.1

2 1

[PATCH] docs: switch ci status page to use Go -module repos
by Daniel P. Berrangé 09 Jun '21

09 Jun '21

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/ci.rst | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/ci.rst b/docs/ci.rst index b321a67bd9..71418d74bf 100644 --- a/docs/ci.rst +++ b/docs/ci.rst @@ -50,10 +50,10 @@ Language bindings :target: https://gitlab.com/libvirt/libvirt-csharp/pipelines :alt: libvirt-csharp pipeline status - * - libvirt-go - - .. image:: https://gitlab.com/libvirt/libvirt-go/badges/master/pipeline.svg - :target: https://gitlab.com/libvirt/libvirt-go/pipelines - :alt: libvirt-go pipeline status + * - libvirt-go-module + - .. image:: https://gitlab.com/libvirt/libvirt-go-module/badges/master/pipeline.svg + :target: https://gitlab.com/libvirt/libvirt-go-module/pipelines + :alt: libvirt-go-module pipeline status * - libvirt-java - .. image:: https://gitlab.com/libvirt/libvirt-java/badges/master/pipeline.svg @@ -116,10 +116,10 @@ Object mappings :target: https://gitlab.com/libvirt/libvirt-glib/pipelines :alt: libvirt-glib pipeline status - * - libvirt-go-xml - - .. image:: https://gitlab.com/libvirt/libvirt-go-xml/badges/master/pipeline.svg - :target: https://gitlab.com/libvirt/libvirt-go-xml/pipelines - :alt: libvirt-go-xml pipeline status + * - libvirt-go-xml-module + - .. image:: https://gitlab.com/libvirt/libvirt-go-xml-module/badges/master/pipeline.svg + :target: https://gitlab.com/libvirt/libvirt-go-xml-module/pipelines + :alt: libvirt-go-xml-module pipeline status * - libvirt-snmp - .. image:: https://gitlab.com/libvirt/libvirt-snmp/badges/master/pipeline.svg -- 2.31.1

2 1

[libvirt PATCH] cpu_map: sync_qemu_i386.py: Remove superfluous semicolon
by Tim Wiederhake 09 Jun '21

09 Jun '21

The semicolon in question makes the pipeline fail over a style checker complaint. Introduced-in: 360b8eb2d2cb1b6a8c9a78fa2c5be31dd7c74487 Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com> --- src/cpu_map/sync_qemu_i386.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cpu_map/sync_qemu_i386.py b/src/cpu_map/sync_qemu_i386.py index fbf1edf5d0..92bb58f75b 100755 --- a/src/cpu_map/sync_qemu_i386.py +++ b/src/cpu_map/sync_qemu_i386.py @@ -209,7 +209,7 @@ def read_builtin_x86_defs(filename): raise RuntimeError("begin mark not found") match = begin_mark.match(line) if match: - break; + break match = shorthand.match(line) if match: # TCG definitions are irrelevant for cpu models -- 2.31.1

3 2

[PATCH] virt-host-validate: Fix IOMMU output on aarch64
by Fabiano Fidêncio 09 Jun '21

09 Jun '21

virt-host-validate should print "Checking for device assignment IOMMU support" for all architectures, not only for Intel / AMD. This is the output without the patch: ``` [fidencio@dentola libvirt]$ virt-host-validate QEMU: comprobando if device /dev/kvm exists : PASA QEMU: comprobando if device /dev/kvm is accessible : PASA QEMU: comprobando if device /dev/vhost-net exists : PASA QEMU: comprobando if device /dev/net/tun exists : PASA QEMU: comprobando for cgroup 'cpu' controller support : PASA QEMU: comprobando for cgroup 'cpuacct' controller support : PASA QEMU: comprobando for cgroup 'cpuset' controller support : PASA QEMU: comprobando for cgroup 'memory' controller support : PASA QEMU: comprobando for cgroup 'devices' controller support : ADVERTENCIA (Enable 'devices' in kernel Kconfig file or mount/enable cgroup controller in your system) QEMU: comprobando for cgroup 'blkio' controller support : PASA ADVERTENCIA (Unknown if this platform has IOMMU support) QEMU: comprobando for secure guest support : ADVERTENCIA (Unknown if this platform has Secure Guest support) ``` This is the output with the patch: ``` [fidencio@dentola libvirt]$ ./build/tools/virt-host-validate QEMU: Checking if device /dev/kvm exists : PASS QEMU: Checking if device /dev/kvm is accessible : PASS QEMU: Checking if device /dev/vhost-net exists : PASS QEMU: Checking if device /dev/net/tun exists : PASS QEMU: Checking for cgroup 'cpu' controller support : PASS QEMU: Checking for cgroup 'cpuacct' controller support : PASS QEMU: Checking for cgroup 'cpuset' controller support : PASS QEMU: Checking for cgroup 'memory' controller support : PASS QEMU: Checking for cgroup 'devices' controller support : WARN (Enable 'devices' in kernel Kconfig file or mount/enable cgroup controller in your system) QEMU: Checking for cgroup 'blkio' controller support : PASS QEMU: Checking for device assignment IOMMU support : WARN (Unknown if this platform has IOMMU support) QEMU: Checking for secure guest support : WARN (Unknown if this platform has Secure Guest support) ``` Signed-off-by: Fabiano Fidêncio <fabiano(a)fidencio.org> --- This is a follow-up on https://listman.redhat.com/archives/libvir-list/2021-June/msg00190.html --- tools/virt-host-validate-common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virt-host-validate-common.c b/tools/virt-host-validate-common.c index 9412bb7514..ee22a88b31 100644 --- a/tools/virt-host-validate-common.c +++ b/tools/virt-host-validate-common.c @@ -335,6 +335,8 @@ int virHostValidateIOMMU(const char *hvname, struct dirent *dent; int rc; + virHostMsgCheck(hvname, "%s", _("for device assignment IOMMU support")); + flags = virHostValidateGetCPUFlags(); if (flags && virBitmapIsBitSet(flags, VIR_HOST_VALIDATE_CPU_FLAG_VMX)) @@ -345,7 +347,6 @@ int virHostValidateIOMMU(const char *hvname, virBitmapFree(flags); if (isIntel) { - virHostMsgCheck(hvname, "%s", _("for device assignment IOMMU support")); if (access("/sys/firmware/acpi/tables/DMAR", F_OK) == 0) { virHostMsgPass(); bootarg = "intel_iommu=on"; @@ -357,7 +358,6 @@ int virHostValidateIOMMU(const char *hvname, return VIR_HOST_VALIDATE_FAILURE(level); } } else if (isAMD) { - virHostMsgCheck(hvname, "%s", _("for device assignment IOMMU support")); if (access("/sys/firmware/acpi/tables/IVRS", F_OK) == 0) { virHostMsgPass(); bootarg = "iommu=pt iommu=1"; -- 2.31.1

2 3

[libvirt PATCH 0/2] Update sync_qemu_i386.py tool for changes in QEMU
by Tim Wiederhake 09 Jun '21

09 Jun '21

QEMU commit e11fd68996fb27c040552320f01a7d30a15a7cc1 changed a line that was used by our tool as marker. Commit 1 prepares for the change, commit 2 actually makes the required adjustment. Cheers, Tim Tim Wiederhake (2): cpu_map: sync_qemu_i386.py: Use regex to look for begin mark cpu_map: sync_qemu_i386.py: Allow begin mark to contain `const` src/cpu_map/sync_qemu_i386.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) -- 2.26.3

2 3

[libvirt PATCH 0/4] Support autostart for mediated devices
by Jonathon Jongsma 09 Jun '21

09 Jun '21

This is a short patch series based on an initial patch from Boris Fiuczynski that I massaged a little bit and added a few additional patches. This allows you to define mediated devices in libvirt which are started automatically at boot or parent device plugin. Boris Fiuczynski (1): nodedev: support auto-start property for mdevs Jonathon Jongsma (3): test: move nodedev xml2xml output to a separate dir tests: nodedevxml2xmltest: test more mdev files docs: nodedev: document mdev uuid property docs/formatnode.html.in | 14 ++++++++ docs/schemas/nodedev.rng | 11 +++++++ src/conf/node_device_conf.c | 20 ++++++++++- src/conf/node_device_conf.h | 12 +++++++ src/libvirt_private.syms | 2 ++ src/node_device/node_device_driver.c | 7 +++- .../mdevctl-list-multiple.out.xml | 4 +++ tests/nodedevschemadata/mdev_autostart.xml | 10 ++++++ tests/nodedevschemadata/mdev_manual.xml | 10 ++++++ tests/nodedevxml2xmlout/DVD_GCC_4247N.xml | 15 +++++++++ tests/nodedevxml2xmlout/DVD_with_media.xml | 18 ++++++++++ tests/nodedevxml2xmlout/ap_07_0038.xml | 9 +++++ tests/nodedevxml2xmlout/ap_card07.xml | 8 +++++ tests/nodedevxml2xmlout/ap_matrix.xml | 7 ++++ .../ap_matrix_mdev_types.xml | 14 ++++++++ tests/nodedevxml2xmlout/ccw_0_0_ffff.xml | 10 ++++++ tests/nodedevxml2xmlout/computer.xml | 16 +++++++++ .../css_0_0_fffe_mdev_types.xml | 17 ++++++++++ tests/nodedevxml2xmlout/css_0_0_ffff.xml | 10 ++++++ tests/nodedevxml2xmlout/drm_renderD129.xml | 10 ++++++ ...v_3627463d_b7f0_4fea_b468_f1da537d301b.xml | 9 +++++ tests/nodedevxml2xmlout/mdev_autostart.xml | 11 +++++++ ...v_d069d019_36ea_4111_8f0a_8c9a70e21366.xml | 10 ++++++ ...v_d2441d39_495e_4243_ad9f_beb3f14c23d9.xml | 11 +++++++ ...v_ee0b88c4_f554_4dc1_809d_b2a01e8e48ad.xml | 10 ++++++ ...v_fedc4916_1ca8_49ac_b176_871d16c13076.xml | 10 ++++++ tests/nodedevxml2xmlout/mdev_manual.xml | 11 +++++++ .../net_00_13_02_b9_f9_d3.xml | 21 ++++++++++++ .../net_00_15_58_2f_e9_55.xml | 21 ++++++++++++ .../pci_0000_00_02_0_header_type.xml | 16 +++++++++ .../pci_0000_00_1c_0_header_type.xml | 21 ++++++++++++ .../pci_0000_02_10_7_mdev_types.xml | 33 +++++++++++++++++++ .../pci_0000_02_10_7_sriov.xml | 24 ++++++++++++++ .../pci_0000_02_10_7_sriov_pf_vfs_all.xml | 29 ++++++++++++++++ ...0_02_10_7_sriov_pf_vfs_all_header_type.xml | 31 +++++++++++++++++ .../pci_0000_02_10_7_sriov_vfs.xml | 27 +++++++++++++++ ..._0000_02_10_7_sriov_zero_vfs_max_count.xml | 22 +++++++++++++ tests/nodedevxml2xmlout/pci_1002_71c4.xml | 14 ++++++++ .../pci_8086_0c0c_snd_hda_intel.xml | 17 ++++++++++ .../pci_8086_10c9_sriov_pf.xml | 18 ++++++++++ .../pci_8086_27c5_scsi_host.xml | 7 ++++ .../pci_8086_27c5_scsi_host_0.xml | 7 ++++ .../pci_8086_27c5_scsi_host_0_unique_id.xml | 8 +++++ ...i_8086_27c5_scsi_host_scsi_device_lun0.xml | 11 +++++++ .../pci_8086_27c5_scsi_host_scsi_host.xml | 7 ++++ .../pci_8086_4238_pcie_wireless.xml | 27 +++++++++++++++ tests/nodedevxml2xmlout/scsi_target0_0_0.xml | 7 ++++ tests/nodedevxml2xmlout/scsi_target1_0_0.xml | 12 +++++++ ...rial_3600c0ff000d7a2a5d463ff4902000000.xml | 19 +++++++++++ ...al_SATA_HTS721010G9SA00_MPCZ12Y0GNGWSE.xml | 14 ++++++++ .../usb_device_1d6b_1_0000_00_1d_0.xml | 10 ++++++ .../usb_device_1d6b_1_0000_00_1d_0_if0.xml | 10 ++++++ tests/nodedevxml2xmltest.c | 17 +++++++--- 53 files changed, 739 insertions(+), 7 deletions(-) create mode 100644 tests/nodedevschemadata/mdev_autostart.xml create mode 100644 tests/nodedevschemadata/mdev_manual.xml create mode 100644 tests/nodedevxml2xmlout/DVD_GCC_4247N.xml create mode 100644 tests/nodedevxml2xmlout/DVD_with_media.xml create mode 100644 tests/nodedevxml2xmlout/ap_07_0038.xml create mode 100644 tests/nodedevxml2xmlout/ap_card07.xml create mode 100644 tests/nodedevxml2xmlout/ap_matrix.xml create mode 100644 tests/nodedevxml2xmlout/ap_matrix_mdev_types.xml create mode 100644 tests/nodedevxml2xmlout/ccw_0_0_ffff.xml create mode 100644 tests/nodedevxml2xmlout/computer.xml create mode 100644 tests/nodedevxml2xmlout/css_0_0_fffe_mdev_types.xml create mode 100644 tests/nodedevxml2xmlout/css_0_0_ffff.xml create mode 100644 tests/nodedevxml2xmlout/drm_renderD129.xml create mode 100644 tests/nodedevxml2xmlout/mdev_3627463d_b7f0_4fea_b468_f1da537d301b.xml create mode 100644 tests/nodedevxml2xmlout/mdev_autostart.xml create mode 100644 tests/nodedevxml2xmlout/mdev_d069d019_36ea_4111_8f0a_8c9a70e21366.xml create mode 100644 tests/nodedevxml2xmlout/mdev_d2441d39_495e_4243_ad9f_beb3f14c23d9.xml create mode 100644 tests/nodedevxml2xmlout/mdev_ee0b88c4_f554_4dc1_809d_b2a01e8e48ad.xml create mode 100644 tests/nodedevxml2xmlout/mdev_fedc4916_1ca8_49ac_b176_871d16c13076.xml create mode 100644 tests/nodedevxml2xmlout/mdev_manual.xml create mode 100644 tests/nodedevxml2xmlout/net_00_13_02_b9_f9_d3.xml create mode 100644 tests/nodedevxml2xmlout/net_00_15_58_2f_e9_55.xml create mode 100644 tests/nodedevxml2xmlout/pci_0000_00_02_0_header_type.xml create mode 100644 tests/nodedevxml2xmlout/pci_0000_00_1c_0_header_type.xml create mode 100644 tests/nodedevxml2xmlout/pci_0000_02_10_7_mdev_types.xml create mode 100644 tests/nodedevxml2xmlout/pci_0000_02_10_7_sriov.xml create mode 100644 tests/nodedevxml2xmlout/pci_0000_02_10_7_sriov_pf_vfs_all.xml create mode 100644 tests/nodedevxml2xmlout/pci_0000_02_10_7_sriov_pf_vfs_all_header_type.xml create mode 100644 tests/nodedevxml2xmlout/pci_0000_02_10_7_sriov_vfs.xml create mode 100644 tests/nodedevxml2xmlout/pci_0000_02_10_7_sriov_zero_vfs_max_count.xml create mode 100644 tests/nodedevxml2xmlout/pci_1002_71c4.xml create mode 100644 tests/nodedevxml2xmlout/pci_8086_0c0c_snd_hda_intel.xml create mode 100644 tests/nodedevxml2xmlout/pci_8086_10c9_sriov_pf.xml create mode 100644 tests/nodedevxml2xmlout/pci_8086_27c5_scsi_host.xml create mode 100644 tests/nodedevxml2xmlout/pci_8086_27c5_scsi_host_0.xml create mode 100644 tests/nodedevxml2xmlout/pci_8086_27c5_scsi_host_0_unique_id.xml create mode 100644 tests/nodedevxml2xmlout/pci_8086_27c5_scsi_host_scsi_device_lun0.xml create mode 100644 tests/nodedevxml2xmlout/pci_8086_27c5_scsi_host_scsi_host.xml create mode 100644 tests/nodedevxml2xmlout/pci_8086_4238_pcie_wireless.xml create mode 100644 tests/nodedevxml2xmlout/scsi_target0_0_0.xml create mode 100644 tests/nodedevxml2xmlout/scsi_target1_0_0.xml create mode 100644 tests/nodedevxml2xmlout/storage_serial_3600c0ff000d7a2a5d463ff4902000000.xml create mode 100644 tests/nodedevxml2xmlout/storage_serial_SATA_HTS721010G9SA00_MPCZ12Y0GNGWSE.xml create mode 100644 tests/nodedevxml2xmlout/usb_device_1d6b_1_0000_00_1d_0.xml create mode 100644 tests/nodedevxml2xmlout/usb_device_1d6b_1_0000_00_1d_0_if0.xml -- 2.31.1

6 16

[PATCH 0/5] qemu: Adapt to virtio-gpu-gl-pci and virtio-vga-gl
by Han Han 09 Jun '21

09 Jun '21

The virgl property of virtio-gpu-pci&virtio-vga will be replaced by virtio-gpu-gl-pci&virtio-vga-gl in QEMU 6.1. Adapt to that update. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/167 https://bugzilla.redhat.com/show_bug.cgi?id=1967356 Han Han (5): qemu_capabilities: Add QEMU_CAPS_VIRTIO_GPU_GL_PCI qemu: Adapt to virtio-gpu-gl-pci device when available qemu_capabilities: Add QEMU_CAPS_VIRTIO_VGA_GL qemu: Adapt to virtio-vga-gl device tests: Tests for virtio-vga-gl and virtio-gpu-gl-pci device src/qemu/qemu_capabilities.c | 4 ++ src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_command.c | 11 ++++- .../caps_6.1.0.x86_64.xml | 2 + .../video-virtio-vga-gpu-gl.args | 29 +++++++++++++ .../video-virtio-vga-gpu-gl.xml | 34 +++++++++++++++ tests/qemuxml2argvtest.c | 6 +++ .../video-virtio-vga-gpu-gl.xml | 43 +++++++++++++++++++ tests/qemuxml2xmltest.c | 6 +++ 9 files changed, 136 insertions(+), 1 deletion(-) create mode 100644 tests/qemuxml2argvdata/video-virtio-vga-gpu-gl.args create mode 100644 tests/qemuxml2argvdata/video-virtio-vga-gpu-gl.xml create mode 100644 tests/qemuxml2xmloutdata/video-virtio-vga-gpu-gl.xml -- 2.31.1

3 12

[PATCH 0/5] virth-host-validate: Couple of cleanups
by Michal Privoznik 08 Jun '21

08 Jun '21

I've noticed couple of bugs/problems while reviewing Fabiano's patch. Here are fixes. Michal Prívozník (5): virt-host-validate: Initialize the error object virt-host-validate: Report an error if failed to detect CGroups virt-host-validate: Turn failure to read /proc/cmdline into an error virt-host-validate: Call VIR_HOST_VALIDATE_FAILURE() more frequently virHostValidateSecureGuests: Drop useless 'return 0' at the end tools/virt-host-validate-common.c | 28 +++++++++++++++------------- tools/virt-host-validate.c | 6 +++++- 2 files changed, 20 insertions(+), 14 deletions(-) -- 2.31.1

3 9

[PATCH] apparmor: Add denied capabilities
by Jim Fehlig 08 Jun '21

08 Jun '21

The audit log contains the following denials from libvirtd apparmor="DENIED" operation="capable" profile="libvirtd" pid=6012 comm="daemon-init" capability=17 capname="sys_rawio" apparmor="DENIED" operation="capable" profile="libvirtd" pid=6012 comm="rpc-worker" capability=39 capname="bpf" apparmor="DENIED" operation="capable" profile="libvirtd" pid=6012 comm="rpc-worker" capability=38 capname="perfmon" Squelch the denials and allow the capabilities in the libvirtd apparmor profile. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- I'm not really sure when these denials first started appearing, nor have I noticed any problems they are causing. Likely I have not exercised the affected functionality. src/security/apparmor/usr.sbin.libvirtd.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/security/apparmor/usr.sbin.libvirtd.in b/src/security/apparmor/usr.sbin.libvirtd.in index bf4563e1e8..928782b709 100644 --- a/src/security/apparmor/usr.sbin.libvirtd.in +++ b/src/security/apparmor/usr.sbin.libvirtd.in @@ -25,6 +25,9 @@ profile libvirtd @sbindir@/libvirtd flags=(attach_disconnected) { capability fsetid, capability audit_write, capability ipc_lock, + capability sys_rawio, + capability bpf, + capability perfmon, # Needed for vfio capability sys_resource, -- 2.31.1

3 4

[PATCH] storage: Don't overwrite error in virISCSIDirectDisconnect()
by Michal Privoznik 08 Jun '21

08 Jun '21

The iscsi-direct storage pool backend works merely like this: a connection is established to the target (usually done via virStorageBackendISCSIDirectSetConnection()), intended action is executed (e.g. reporting LUNs, volume wiping), and at the end the connection is closed via virISCSIDirectDisconnect(). The problem is that virISCSIDirectDisconnect() reports its own errors which may overwrite error that occurred during LUN reporting, or volume wiping or whatever. To fix this, use virErrorPreserveLast() + virErrorRestore() combo, which either preserves previously reported error message, or is NOP if there's no error reported. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1797879 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/storage/storage_backend_iscsi_direct.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/src/storage/storage_backend_iscsi_direct.c b/src/storage/storage_backend_iscsi_direct.c index 0bff1882b9..e4a14c3fd6 100644 --- a/src/storage/storage_backend_iscsi_direct.c +++ b/src/storage/storage_backend_iscsi_direct.c @@ -391,19 +391,28 @@ virISCSIDirectReportLuns(virStoragePoolObj *pool, static int virISCSIDirectDisconnect(struct iscsi_context *iscsi) { + virErrorPtr orig_err; + int ret = -1; + + virErrorPreserveLast(&orig_err); + if (iscsi_logout_sync(iscsi) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Failed to logout: %s"), iscsi_get_error(iscsi)); - return -1; + goto cleanup; } if (iscsi_disconnect(iscsi) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Failed to disconnect: %s"), iscsi_get_error(iscsi)); - return -1; + goto cleanup; } - return 0; + + ret = 0; + cleanup: + virErrorRestore(&orig_err); + return ret; } static int -- 2.31.1

2 1

[PATCH 0/2] Another round of CH driver fixes
by Michal Privoznik 08 Jun '21

08 Jun '21

*** BLURB HERE *** Michal Prívozník (2): ch_driver: Avoid driver double free virCHDriverConfig: Drop @uri member src/ch/ch_conf.c | 1 - src/ch/ch_conf.h | 1 - src/ch/ch_driver.c | 2 +- 3 files changed, 1 insertion(+), 3 deletions(-) -- 2.31.1

2 3

[PATCH] meson.build: Compile with -Walloca
by Thomas Huth 08 Jun '21

08 Jun '21

We are already compiling libvirt with -Wvla - so it does not make too much sense to still allow people to use alloca() instead. Thus put it on the list of things we want to warn about. Fortunately, there is currently no warning with this flag, so the current sources should be clean. Signed-off-by: Thomas Huth <thuth(a)redhat.com> --- meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/meson.build b/meson.build index 40c841e777..a97efdf8f4 100644 --- a/meson.build +++ b/meson.build @@ -234,6 +234,7 @@ cc_flags += [ '-Waddress-of-packed-member', '-Waggressive-loop-optimizations', '-Walloc-size-larger-than=@0@'.format(alloc_max.stdout().strip()), + '-Walloca', '-Warray-bounds=2', '-Wattribute-alias=2', '-Wattribute-warning', -- 2.27.0

3 2

[PATCH] meson.build: Remove the -Wvla-larger-then flag
by Thomas Huth 08 Jun '21

08 Jun '21

The flag has a typo in it, it's "...-than=..." and not "...-then=...", so this was in fact never used. Since we're also using -Wvla (without size), we should already get warnings about any variable length arrays anyway, so the additional "-Wvla-larger-than" does not make much sense and thus we can simply drop this. Signed-off-by: Thomas Huth <thuth(a)redhat.com> --- meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/meson.build b/meson.build index 4f23f9104e..40c841e777 100644 --- a/meson.build +++ b/meson.build @@ -390,7 +390,6 @@ cc_flags += [ '-Wvariadic-macros', '-Wvector-operation-performance', '-Wvla', - '-Wvla-larger-then=4031', '-Wvolatile-register-var', '-Wwrite-strings', ] -- 2.27.0

4 4

[PATCH 0/3] libxl: A few firmware improvments
by Jim Fehlig 08 Jun '21

08 Jun '21

Upstream ovmf will be removing support for Xen in the traditional ovmf package, moving it to a separate OvmfXen package https://bugzilla.tianocore.org/show_bug.cgi?id=2122 This motivated me to verify the impact on libvirt+ovmf+xen. Fortunately it is minimal since the new OvmfXen package is basically a reduced version of the traditional package. I.e. it should contain everything the traditional package contains and thus is binary compatible and should not affect existing guests using the traditional package. Indeed my initial testing has shown this to be true. While testing I cooked up a few improvements to the libxl driver firmware handling, including adding support for automatic firmware selection. Thanks for review/comments! Jim Fehlig (3): libxl: Introduce domain def validate callback libxl: Forbid domain definition with secure boot enabled libxl: Support firmware autoselection src/libxl/libxl_conf.c | 17 ++++++++++++-- src/libxl/libxl_domain.c | 49 ++++++++++++++++++++++++++++++++-------- 2 files changed, 54 insertions(+), 12 deletions(-) -- 2.31.1

2 4

[libvirt PATCH] meson: Ask rst2html to strip comments
by Andrea Bolognani 08 Jun '21

08 Jun '21

They can be problematic: in particular, the rst files generated by keycodemapdb's keymap-gen contain things like To re-generate, run: keymap-gen --lang=rst --title=virkeycode-osx [...] which result in xsltproc later choking with [1/12] Generating virkeyname-osx.html with a meson_exe.py custom command FAILED: docs/manpages/virkeyname-osx.html /usr/bin/meson --internal exe --capture docs/manpages/virkeyname-osx.html \ /usr/bin/xsltproc [...] --nonet ../docs/subsite.xsl docs/manpages/virkeyname-osx.html.in docs/manpages/virkeyname-osx.html.in:17: parser error : Double hyphen within comment: keymap-gen --lang=rst --title=virkeyname-osx [...] ^ Stripping comments avoids the issue entirely. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- docs/manpages/meson.build | 2 +- docs/meson.build | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/manpages/meson.build b/docs/manpages/meson.build index 0fa93fad89..eda0aa8441 100644 --- a/docs/manpages/meson.build +++ b/docs/manpages/meson.build @@ -118,7 +118,7 @@ foreach data : docs_man_files html_in_file, input: rst_file, output: html_in_file, - command: [ rst2html_prog, '--stylesheet=', '--strict', '@INPUT@' ], + command: [ rst2html_prog, '--strip-comments', '--stylesheet=', '--strict', '@INPUT@' ], capture: true, ) diff --git a/docs/meson.build b/docs/meson.build index f550629d8e..c94a3c7f13 100644 --- a/docs/meson.build +++ b/docs/meson.build @@ -185,7 +185,7 @@ docs_admin_api_xml = docs_api_generated[3] docs_rst2html_gen = generator( rst2html_prog, output: '@BASENAME@.html.in', - arguments: [ '--stylesheet=', '--strict', '@INPUT@' ], + arguments: [ '--strip-comments', '--stylesheet=', '--strict', '@INPUT@' ], capture: true, ) -- 2.31.1

4 6

[libvirt PATCH] openvswitch: don't delete existing OVS port prior to recreating same port
by Laine Stump 08 Jun '21

08 Jun '21

Connecting a tap device to an Open vSwitch is done by adding a "port" to the switch with the ovs-vsctl "add-port" command. The port will have the same name as the tap device, but it is a separate entity, and can survive beyond the destruction of the tap device (although under normal circumstances the port will be deleted around the same time the tap device is deleted). This makes it possible for a port of a particular name to already exist at the time libvirt calls ovs-vsctl to add that port. The original commit of Open vSwitch support (commit df81004632, libvirt 0.9.10, Feb. 2012) used the "--may-exist" option to the add-port command to indicate that a port of the desired name might already exist, and that it was okay to simply re-use this port (rather than failing with an error message). Then in commit 33445ce8446d9 (libvirt 1.2.7, April 2014) the command was changed to use "--if-exists del-port blah" instead of "--may-exist". The reason given was that there was a bug in OVS where a stale port would be unusable even though it still existed; the workaround was to forcibly delete any existing port prior to adding the new port (of the same name). This is the ovs-vsctl command still in use by libvirt today. It recently came up in the discussion of a bug concerning guest packet loss during OpenStack upgrades (https://bugzilla.redhat.com/1963164) that the bug in OVS that necessitated the del-port workaround was fixed quite a long time ago (August 2015): https://github.com/openvswitch/ovs/commit/e21c6643a02c6b446d2fbdfde366ea303… thus rendering the workaround in libvirt unnecessary. The assertion in that discussion is that this workaround is now the cause of the packet loss being experienced during OpenStack upgrades. I'm not convinced this is the case, but it does appear that there is no reason to carry this workaround in libvirt any longer, so this patch reverts the code back to the original behavior (using "--may-exist" instead of "--if-exists del-port"). Signed-off-by: Laine Stump <laine(a)redhat.com> --- In an attempt to sabotage my own patch, I will point out that this makes it a possibility that libvirt could end up using an OVS port created by "someone else" who may have set it up in some way that renders the guest network connection unusable, e.g. if the port had been created with flow filters or something. On the other hand 1) the "someone else" in this scenario would need to have all the same privileges that would also permit them to mess up the connection after it had been created (so there is no *extra* security risk), and 2) this could possibly be *desired* (although difficult for libvirt to support) behavior in the case someone needed libvirt-managed guest network connections to use extra capabilities not directly supported in libvirt's config; additionally pre-creating the OVS port could provide a method of getting the network connection into a usable state (i.e. forwarding traffic) much sooner. src/util/virnetdevopenvswitch.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virnetdevopenvswitch.c b/src/util/virnetdevopenvswitch.c index 21ee4bdd42..eac68d9556 100644 --- a/src/util/virnetdevopenvswitch.c +++ b/src/util/virnetdevopenvswitch.c @@ -155,8 +155,8 @@ int virNetDevOpenvswitchAddPort(const char *brname, const char *ifname, } cmd = virNetDevOpenvswitchCreateCmd(); - virCommandAddArgList(cmd, "--", "--if-exists", "del-port", - ifname, "--", "add-port", brname, ifname, NULL); + virCommandAddArgList(cmd, "--", "--may-exist", + "add-port", brname, ifname, NULL); virNetDevOpenvswitchConstructVlans(cmd, virtVlan); -- 2.31.1

2 1

[PATCH v2] tools: only fail validations if VIR_HOST_VALIDATE_FAIL is set
by Fabiano Fidêncio 08 Jun '21

08 Jun '21

Currently `virt-host-validate` will fail whenever one of its calls fail, regardless of virHostValidateLevel set. This behaviour is not optimal and makes it not exactly reliable as a command line tool as other tools or scripts using it would have to check its output to figure out whether something really failed or if a warning was mistakenly treated as failure. With this change, the behaviour of whether to fail or not, is defined by the caller of those functions, based on the virHostValidateLevel passed to them. https://gitlab.com/libvirt/libvirt/-/issues/175 Signed-off-by: Fabiano Fidêncio <fabiano(a)fidencio.org> --- Changes since v1: * Replace the `goto out;` and the `out` labels by the `VIR_HOST_VALIDATE_FAILURE` macro --- tools/virt-host-validate-common.c | 30 +++++++++++++++--------------- tools/virt-host-validate-common.h | 14 ++++++++++++++ 2 files changed, 29 insertions(+), 15 deletions(-) diff --git a/tools/virt-host-validate-common.c b/tools/virt-host-validate-common.c index 6dd851f07d..9412bb7514 100644 --- a/tools/virt-host-validate-common.c +++ b/tools/virt-host-validate-common.c @@ -142,7 +142,7 @@ int virHostValidateDeviceExists(const char *hvname, if (access(dev_name, F_OK) < 0) { virHostMsgFail(level, "%s", hint); - return -1; + return VIR_HOST_VALIDATE_FAILURE(level); } virHostMsgPass(); @@ -159,7 +159,7 @@ int virHostValidateDeviceAccessible(const char *hvname, if (access(dev_name, R_OK|W_OK) < 0) { virHostMsgFail(level, "%s", hint); - return -1; + return VIR_HOST_VALIDATE_FAILURE(level); } virHostMsgPass(); @@ -180,7 +180,7 @@ int virHostValidateNamespace(const char *hvname, if (access(nspath, F_OK) < 0) { virHostMsgFail(level, "%s", hint); - return -1; + return VIR_HOST_VALIDATE_FAILURE(level); } virHostMsgPass(); @@ -264,17 +264,17 @@ int virHostValidateLinuxKernel(const char *hvname, if (STRNEQ(uts.sysname, "Linux")) { virHostMsgFail(level, "%s", hint); - return -1; + return VIR_HOST_VALIDATE_FAILURE(level); } if (virParseVersionString(uts.release, &thisversion, true) < 0) { virHostMsgFail(level, "%s", hint); - return -1; + return VIR_HOST_VALIDATE_FAILURE(level); } if (thisversion < version) { virHostMsgFail(level, "%s", hint); - return -1; + return VIR_HOST_VALIDATE_FAILURE(level); } else { virHostMsgPass(); return 0; @@ -291,7 +291,7 @@ int virHostValidateCGroupControllers(const char *hvname, size_t i; if (virCgroupNew("/", -1, &group) < 0) - return -1; + return VIR_HOST_VALIDATE_FAILURE(level); for (i = 0; i < VIR_CGROUP_CONTROLLER_LAST; i++) { int flag = 1 << i; @@ -303,7 +303,7 @@ int virHostValidateCGroupControllers(const char *hvname, virHostMsgCheck(hvname, "for cgroup '%s' controller support", cg_name); if (!virCgroupHasController(group, i)) { - ret = -1; + ret = VIR_HOST_VALIDATE_FAILURE(level); virHostMsgFail(level, "Enable '%s' in kernel Kconfig file or " "mount/enable cgroup controller in your system", cg_name); @@ -320,7 +320,7 @@ int virHostValidateCGroupControllers(const char *hvname G_GNUC_UNUSED, virHostValidateLevel level) { virHostMsgFail(level, "%s", "This platform does not support cgroups"); - return -1; + return VIR_HOST_VALIDATE_FAILURE(level); } #endif /* !__linux__ */ @@ -354,7 +354,7 @@ int virHostValidateIOMMU(const char *hvname, "No ACPI DMAR table found, IOMMU either " "disabled in BIOS or not supported by this " "hardware platform"); - return -1; + return VIR_HOST_VALIDATE_FAILURE(level); } } else if (isAMD) { virHostMsgCheck(hvname, "%s", _("for device assignment IOMMU support")); @@ -366,7 +366,7 @@ int virHostValidateIOMMU(const char *hvname, "No ACPI IVRS table found, IOMMU either " "disabled in BIOS or not supported by this " "hardware platform"); - return -1; + return VIR_HOST_VALIDATE_FAILURE(level); } } else if (ARCH_IS_PPC64(arch)) { /* Empty Block */ @@ -385,7 +385,7 @@ int virHostValidateIOMMU(const char *hvname, } else { virHostMsgFail(level, "Unknown if this platform has IOMMU support"); - return -1; + return VIR_HOST_VALIDATE_FAILURE(level); } @@ -404,7 +404,7 @@ int virHostValidateIOMMU(const char *hvname, "Add %s to kernel cmdline arguments", bootarg); else virHostMsgFail(level, "IOMMU capability not compiled into kernel."); - return -1; + return VIR_HOST_VALIDATE_FAILURE(level); } virHostMsgPass(); return 0; @@ -468,7 +468,7 @@ int virHostValidateSecureGuests(const char *hvname, } if (virFileReadValueString(&cmdline, "/proc/cmdline") < 0) - return -1; + return VIR_HOST_VALIDATE_FAILURE(level); /* we're prefix matching rather than equality matching here, because * kernel would treat even something like prot_virt='yFOO' as @@ -516,7 +516,7 @@ int virHostValidateSecureGuests(const char *hvname, } else { virHostMsgFail(level, "Unknown if this platform has Secure Guest support"); - return -1; + return VIR_HOST_VALIDATE_FAILURE(level); } return 0; diff --git a/tools/virt-host-validate-common.h b/tools/virt-host-validate-common.h index 08a9997f5f..9334fa8588 100644 --- a/tools/virt-host-validate-common.h +++ b/tools/virt-host-validate-common.h @@ -45,6 +45,20 @@ typedef enum { VIR_ENUM_DECL(virHostValidateCPUFlag); +/** + * VIR_HOST_VALIDATE_FAILURE + * @level: the virHostValidateLevel to be checked + * + * This macro is to be used in to return a failures based on the + * virHostValidateLevel use in the function. + * + * If the virHostValidateLevel is VIR_HOST_VALIDATE_FAIL, -1 is returned. + * 0 is returned otherwise (as the virHosValidateLevel is then either a + * Warn or a Note). + */ + +#define VIR_HOST_VALIDATE_FAILURE(level) (level == VIR_HOST_VALIDATE_FAIL) ? -1 : 0 + void virHostMsgSetQuiet(bool quietFlag); void virHostMsgCheck(const char *prefix, -- 2.31.1

2 2

[libvirt PATCH v3] docs: introduce stubs for new libvirt Go packages
by Daniel P. Berrangé 07 Jun '21

07 Jun '21

Currently we expose libvirt Go packages at libvirt.org/libvirt-go libvirt.org/libvirt-go-xml These packages have not supported Go modules historically and when we tried to introduce modules, we hit the problem that we're not using semver for versioning. The only way around this is to introduce new packages under a different namespace, that will have the exact same code, but be tagged with a different version numbering scheme. This change proposes: libvirt.org/go/libvirt libvirt.org/go/libvirtxml Note the hyphen is removed so that the import basename matches the Go package name. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/go/libvirt.rst | 19 +++++++++++++++ docs/go/libvirtxml.rst | 16 +++++++++++++ docs/go/meson.build | 53 +++++++++++++++++++++++++++++++++++++++++ docs/libvirt-go-xml.rst | 24 ++++++++++++++----- docs/libvirt-go.rst | 23 ++++++++++++++---- docs/meson.build | 1 + 6 files changed, 125 insertions(+), 11 deletions(-) create mode 100644 docs/go/libvirt.rst create mode 100644 docs/go/libvirtxml.rst create mode 100644 docs/go/meson.build diff --git a/docs/go/libvirt.rst b/docs/go/libvirt.rst new file mode 100644 index 0000000000..6a1344ad3e --- /dev/null +++ b/docs/go/libvirt.rst @@ -0,0 +1,19 @@ +========================================= +Libvirt Go Language API (with Go modules) +========================================= + +The `Go <https://golang.org/>`__ package ``libvirt.org/go/libvirt`` provides +`CGo <https://golang.org/cmd/cgo/>`__ binding from the OS native Libvirt API. + +This package replaces the obsolete `libvirt.org/libvirt-go +<../libvirt-go.html>`__ package in order to switch to using `semver +<https://semver.org/>`__ and `Go modules <https://golang.org/ref/mod>`__. +Aside from the changed import path and versioning scheme, the API is fully +compatible with the legacy package. + +In general the Go representation is a direct 1-1 mapping from native API +concepts to Go, so the native API documentation should serve as a reference +for most behaviour. + +For details of Go specific behaviour consult the +`Go package documentation <https://pkg.go.dev/libvirt.org/go/libvirt>`__. diff --git a/docs/go/libvirtxml.rst b/docs/go/libvirtxml.rst new file mode 100644 index 0000000000..5407d609f2 --- /dev/null +++ b/docs/go/libvirtxml.rst @@ -0,0 +1,16 @@ +============================================ +Libvirt Go XML parsing API (with Go modules) +============================================ + +The `Go <https://golang.org/>`__ package ``libvirt.org/go/libvirtxml`` provides +annotated Go struct definitions for parsing (and formatting) XML documents used +with libvirt APIs. + +This package replaces the obsolete `libvirt.org/libvirt-go-xml +<../libvirt-go-xml.html>`__ package in order to switch to using `semver +<https://semver.org/>`__ and `Go modules <https://golang.org/ref/mod>`__. +Aside from the changed import path and versioning scheme, the API is fully +compatible with the original package. + +For details of Go specific behaviour consult the +`Go package documentation <https://pkg.go.dev/libvirt.org/go/libvirtxml>`__. diff --git a/docs/go/meson.build b/docs/go/meson.build new file mode 100644 index 0000000000..d2accd322b --- /dev/null +++ b/docs/go/meson.build @@ -0,0 +1,53 @@ +docs_go_files = [ + 'libvirt', + 'libvirtxml', +] + +html_xslt_gen_xslt = subsite_xsl +html_xslt_gen_install_dir = docs_html_dir / 'go' +html_xslt_gen = [] + +foreach name : docs_go_files + rst_file = '@0@.rst'.format(name) + + html_xslt_gen += { + 'name': name, + 'file': docs_rst2html_gen.process(rst_file), + 'source': 'docs' / 'go' / rst_file, + } +endforeach + +# keep the XSLT processing code block in sync with docs/meson.build + +# --- begin of XSLT processing --- + +foreach data : html_xslt_gen + html_filename = data['name'] + '.html' + + html_file = custom_target( + html_filename, + input: data.get('file', data['name'] + '.html.in'), + output: html_filename, + command: [ + xsltproc_prog, + '--stringparam', 'pagesrc', data.get('source', ''), + '--stringparam', 'builddir', meson.build_root(), + '--stringparam', 'timestamp', docs_timestamp, + '--nonet', + html_xslt_gen_xslt, + '@INPUT@', + ], + depends: data.get('depends', []), + depend_files: [ page_xsl ], + capture: true, + install: true, + install_dir: html_xslt_gen_install_dir, + ) + + install_web_deps += html_file + install_web_files += html_file.full_path() + ':' + html_xslt_gen_install_dir +endforeach + +html_xslt_gen = [] + +# --- end of XSLT processing --- diff --git a/docs/libvirt-go-xml.rst b/docs/libvirt-go-xml.rst index 995fdd2b07..43ebf50765 100644 --- a/docs/libvirt-go-xml.rst +++ b/docs/libvirt-go-xml.rst @@ -1,10 +1,22 @@ -========================== -Libvirt Go XML parsing API -========================== +=================================================== +Obsolete libvirt Go XML parsing API (no Go modules) +=================================================== -The `Go <https://golang.org/>`__ package ``libvirt.org/libvirt-go-xml`` provides -annotated Go struct definitions for parsing (and formatting) XML documents used -with libvirt APIs. +This obsolete `Go <https://golang.org/>`__ package ``libvirt.org/libvirt-go-xml`` +provided annotated Go struct definitions for parsing (and formatting) XML +documents used with libvirt APIs. + +This package is replaced by the new `libvirt.org/go/libvirtxml +<go/libvirtxml.html>`__ package in order to switch to using `semver +<https://semver.org/>`__ and `Go modules <https://golang.org/ref/mod>`__. +Aside from the changed import path and versioning scheme, the new package API +is fully compatible with this legacy package. + +Software currently using this package will keep working, but no further +development will take place. libvirt XML scheme elements/attributes introduced +after 7.4.0 will never be available. Authors are strongly recommended to switch +imports to point to the new package, to prepare for future Go toolchains +which will mandate Go module support and semver. For details of Go specific behaviour consult the `Go package documentation <https://pkg.go.dev/libvirt.org/libvirt-go-xml>`__. diff --git a/docs/libvirt-go.rst b/docs/libvirt-go.rst index f2d3f80fb2..7dd78b5f6e 100644 --- a/docs/libvirt-go.rst +++ b/docs/libvirt-go.rst @@ -1,9 +1,22 @@ -======================= -Libvirt Go Language API -======================= +================================================ +Obsolete libvirt Go Language API (no Go modules) +================================================ -The `Go <https://golang.org/>`__ package ``libvirt.org/libvirt-go`` provides -`CGo <https://golang.org/cmd/cgo/>`__ binding from the OS native Libvirt API. +This obsolete `Go <https://golang.org/>`__ package ``libvirt.org/libvirt-go`` +provided `CGo <https://golang.org/cmd/cgo/>`__ binding from the OS native +Libvirt API. + +This package is replaced by the new `libvirt.org/go/libvirt <go/libvirt.html>`__ +package in order to switch to using `semver <https://semver.org/>`__ and +`Go modules <https://golang.org/ref/mod>`__. Aside from the changed +import path and versioning scheme, the new package API is fully compatible +with this legacy package. + +Software currently using this package will keep working, but no further +development will take place. libvirt APIs/constants introduced after +7.4.0 will never be available. Authors are strongly recommended to switch +imports to point to the new package, to prepare for future Go toolchains +which will mandate Go module support and semver. In general the Go representation is a direct 1-1 mapping from native API concepts to Go, so the native API documentation should serve as a reference diff --git a/docs/meson.build b/docs/meson.build index bee0d80d53..4497f7270f 100644 --- a/docs/meson.build +++ b/docs/meson.build @@ -297,6 +297,7 @@ html_xslt_gen = [] # --- end of XSLT processing --- subdir('fonts') +subdir('go') subdir('html') subdir('internals') subdir('js') -- 2.31.1

2 1

[PATCH v8 0/3] qemu: Support rbd namespace
by Han Han 07 Jun '21

07 Jun '21

Diff from v7: - Squash a commit - Rebase to latest code v7: https://listman.redhat.com/archives/libvir-list/2020-November/msg00480.html Han Han (3): qemu_capabilities: Add QEMU_CAPS_RBD_NAMESPACE conf: Support to parse rbd namespace from source name qemu: Implement rbd namespace to the source name attribute docs/formatdomain.rst | 16 ++++++ src/conf/domain_conf.c | 47 +++++++++++++++-- src/conf/storage_source_conf.c | 2 + src/conf/storage_source_conf.h | 1 + src/qemu/qemu_block.c | 1 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_domain.c | 8 +++ .../caps_5.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 + .../caps_5.0.0.riscv64.xml | 1 + .../caps_5.0.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_5.1.0.sparc.xml | 1 + .../caps_5.1.0.x86_64.xml | 1 + .../caps_5.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 1 + .../caps_5.2.0.riscv64.xml | 1 + .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 1 + .../caps_5.2.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 1 + .../caps_6.0.0.x86_64.xml | 1 + .../caps_6.1.0.x86_64.xml | 1 + ...k-network-rbd-namespace.x86_64-latest.args | 38 ++++++++++++++ .../disk-network-rbd-namespace.xml | 40 +++++++++++++++ tests/qemuxml2argvtest.c | 1 + ...sk-network-rbd-namespace.x86_64-latest.xml | 50 +++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 27 files changed, 218 insertions(+), 4 deletions(-) create mode 100644 tests/qemuxml2argvdata/disk-network-rbd-namespace.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/disk-network-rbd-namespace.xml create mode 100644 tests/qemuxml2xmloutdata/disk-network-rbd-namespace.x86_64-latest.xml -- 2.31.1

2 7

[PATCH] remote: remove/annotate unused variables
by Daniel P. Berrangé 07 Jun '21

07 Jun '21

Fixes commit 48f66cfe3ee51baf64f06f1f89dda52af6f4d9d6 Fixes commit fcdcf8f70cf5d6657086e2889124d0e1a7332a29 Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/remote/remote_driver.c | 3 --- src/rpc/virnetsocket.c | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index da672b0d00..c03c68ec30 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -729,9 +729,6 @@ doRemoteOpen(virConnectPtr conn, virConf *conf, unsigned int flags) { -#ifndef WIN32 - g_autofree char *daemonPath = NULL; -#endif g_autofree char *tls_priority = NULL; g_autofree char *name = NULL; g_autofree char *command = NULL; diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c index c3fae8b626..212089520d 100644 --- a/src/rpc/virnetsocket.c +++ b/src/rpc/virnetsocket.c @@ -774,7 +774,7 @@ int virNetSocketNewConnectUNIX(const char *path, } #else int virNetSocketNewConnectUNIX(const char *path G_GNUC_UNUSED, - const char *spawnDaemonPath, + const char *spawnDaemonPath G_GNUC_UNUSED, virNetSocket **retsock G_GNUC_UNUSED) { virReportSystemError(ENOSYS, "%s", -- 2.31.1

2 1

[PATCH] ch: set driver to NULL after freeing it
by Daniel P. Berrangé 07 Jun '21

07 Jun '21

If the chStateInitialize method fails, we call chStateCleanup which free's all global state. It fails to set the global 'ch_driver' to NULL, however, so a later attempt to open the cloud hypervisor driver will succeed and then crash attempting to access freed memory. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/ch/ch_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c index 8c458a20bd..1ee33817f9 100644 --- a/src/ch/ch_driver.c +++ b/src/ch/ch_driver.c @@ -827,6 +827,7 @@ static int chStateCleanup(void) virObjectUnref(ch_driver->config); virMutexDestroy(&ch_driver->lock); g_free(ch_driver); + ch_driver = NULL; return 0; } -- 2.31.1

2 1

[libvirt PATCH] docs: virtiofs: describe memfd memory backend
by Stefan Hajnoczi 07 Jun '21

07 Jun '21

Nowadays memfd is the most convenient memory backend for vhost-user devices. Compared to file-backend memory and hugepages, there is no need to worry about configuring the location of the shm directory or allocating hugepages. Cc: Michal Prívozník <mprivozn(a)redhat.com> Cc: Ján Tomko <jtomko(a)redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha(a)gmail.com> --- docs/kbase/virtiofs.rst | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/docs/kbase/virtiofs.rst b/docs/kbase/virtiofs.rst index 740b08d50d..8cf7567bf8 100644 --- a/docs/kbase/virtiofs.rst +++ b/docs/kbase/virtiofs.rst @@ -29,7 +29,11 @@ NUMA. As of QEMU 5.0.0 and libvirt 6.9.0, it is possible to specify the memory backend without NUMA (using the so called memobject interface). -Either of the following: +One of the following: + +* Use memfd memory + + No host setup is required when using the Linux memfd memory backend. * Use file-backed memory @@ -75,7 +79,20 @@ Guest setup #. Specify the memory backend - Either of the following: + One of the following: + + * memfd memory + + :: + + <domain> + ... + <memoryBacking> + <source type='memfd'/> + <access mode='shared'/> + </memoryBacking> + ... + </domain> * File-backed memory -- 2.31.1

2 1

[libvirt] [PATCH 0/2] virsh: Add coredump format completion to dump
by Lin Ma 07 Jun '21

07 Jun '21

Lin Ma (2): virsh: Use VIR_ENUM_* for --format argument in doDump virsh: Add coredump format completion to dump command tools/virsh-completer-domain.c | 19 +++++++++++++++++++ tools/virsh-completer-domain.h | 5 +++++ tools/virsh-domain.c | 28 ++++++++++++++-------------- tools/virsh-domain.h | 1 + 4 files changed, 39 insertions(+), 14 deletions(-) -- 2.26.2

2 4

[PATCH v1 00/10] capabilities: Expose HMAT
by Michal Privoznik 07 Jun '21

07 Jun '21

We allow configuring HMAT for domains since v6.6.0-rc1~249 (and friends). Basically, HMAT is more fine grained description of interconnects of NUMA nodes than basic NUMA distances. The former describes bandwidths and latencies while the latter is some dimensionless and normalized number. Anyway, mgmt apps did not really know what values to set for HMAT because we are not exposing them in capabilities because we were waiting on kernel to expose them. And it just did. In 09/10 I'm describing sysfs interface briefly and also mention that there's no interpretation of links to memory side caches, yet. I'm talking to kernel developers so we might get some movement there. But also, I'm not sure whether it's worth the effort OR if there really is a machine that has separate links to main memory and caches. Here's link to ACPI spec: https://uefi.org/sites/default/files/resources/ACPI_6_2.pdf Look for "5.2.27.4 System Locality Latency and Bandwidth Information Structure". And here's link to sysfs docs: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Doc… Michal Prívozník (10): tests: glib-ify vircaps2xmltest schemas: Allow zero <cpu/> for capabilities capabilities: Separate <cpu/> formatting into a function numa_conf: Rename virDomainCache* to virNumaCache* numa_conf: Expose virNumaCache formatter capabilities: Expose NUMA memory side cache numa_conf: Rename virDomainNumaInterconnect* to virNumaInterconnect* numa_conf: Expose virNumaInterconnect formatter capabilities: Expose NUMA interconnects vircaps2xmltest: Introduce HMAT test case build-aux/syntax-check.mk | 2 +- docs/schemas/capability.rng | 11 +- src/conf/capabilities.c | 388 ++++++++++++++++-- src/conf/capabilities.h | 5 +- src/conf/numa_conf.c | 244 +++++------ src/conf/numa_conf.h | 81 ++-- src/libvirt_private.syms | 14 +- src/libxl/libxl_capabilities.c | 3 +- src/qemu/qemu_command.c | 30 +- src/test/test_driver.c | 3 +- tests/testutils.c | 3 +- .../system/cpu/cpu0/cache/index0/level | 1 + .../system/cpu/cpu0/cache/index1/level | 1 + .../system/cpu/cpu0/cache/index2/level | 1 + .../system/cpu/cpu0/cache/index3/id | 1 + .../system/cpu/cpu0/cache/index3/level | 1 + .../cpu/cpu0/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu0/cache/index3/size | 1 + .../system/cpu/cpu0/cache/index3/type | 1 + .../system/cpu/cpu0/topology/core_id | 1 + .../system/cpu/cpu0/topology/die_id | 1 + .../cpu/cpu0/topology/physical_package_id | 1 + .../cpu/cpu0/topology/thread_siblings_list | 1 + .../system/cpu/cpu1/cache/index0/level | 1 + .../system/cpu/cpu1/cache/index1/level | 1 + .../system/cpu/cpu1/cache/index2/level | 1 + .../system/cpu/cpu1/cache/index3/id | 1 + .../system/cpu/cpu1/cache/index3/level | 1 + .../cpu/cpu1/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu1/cache/index3/size | 1 + .../system/cpu/cpu1/cache/index3/type | 1 + .../system/cpu/cpu1/topology/core_id | 1 + .../system/cpu/cpu1/topology/die_id | 1 + .../cpu/cpu1/topology/physical_package_id | 1 + .../cpu/cpu1/topology/thread_siblings_list | 1 + .../system/cpu/cpu10/cache/index0/level | 1 + .../system/cpu/cpu10/cache/index1/level | 1 + .../system/cpu/cpu10/cache/index2/level | 1 + .../system/cpu/cpu10/cache/index3/id | 1 + .../system/cpu/cpu10/cache/index3/level | 1 + .../cpu/cpu10/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu10/cache/index3/size | 1 + .../system/cpu/cpu10/cache/index3/type | 1 + .../system/cpu/cpu10/topology/core_id | 1 + .../system/cpu/cpu10/topology/die_id | 1 + .../cpu/cpu10/topology/physical_package_id | 1 + .../cpu/cpu10/topology/thread_siblings_list | 1 + .../system/cpu/cpu11/cache/index0/level | 1 + .../system/cpu/cpu11/cache/index1/level | 1 + .../system/cpu/cpu11/cache/index2/level | 1 + .../system/cpu/cpu11/cache/index3/id | 1 + .../system/cpu/cpu11/cache/index3/level | 1 + .../cpu/cpu11/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu11/cache/index3/size | 1 + .../system/cpu/cpu11/cache/index3/type | 1 + .../system/cpu/cpu11/topology/core_id | 1 + .../system/cpu/cpu11/topology/die_id | 1 + .../cpu/cpu11/topology/physical_package_id | 1 + .../cpu/cpu11/topology/thread_siblings_list | 1 + .../system/cpu/cpu12/cache/index0/level | 1 + .../system/cpu/cpu12/cache/index1/level | 1 + .../system/cpu/cpu12/cache/index2/level | 1 + .../system/cpu/cpu12/cache/index3/id | 1 + .../system/cpu/cpu12/cache/index3/level | 1 + .../cpu/cpu12/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu12/cache/index3/size | 1 + .../system/cpu/cpu12/cache/index3/type | 1 + .../system/cpu/cpu12/topology/core_id | 1 + .../system/cpu/cpu12/topology/die_id | 1 + .../cpu/cpu12/topology/physical_package_id | 1 + .../cpu/cpu12/topology/thread_siblings_list | 1 + .../system/cpu/cpu13/cache/index0/level | 1 + .../system/cpu/cpu13/cache/index1/level | 1 + .../system/cpu/cpu13/cache/index2/level | 1 + .../system/cpu/cpu13/cache/index3/id | 1 + .../system/cpu/cpu13/cache/index3/level | 1 + .../cpu/cpu13/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu13/cache/index3/size | 1 + .../system/cpu/cpu13/cache/index3/type | 1 + .../system/cpu/cpu13/topology/core_id | 1 + .../system/cpu/cpu13/topology/die_id | 1 + .../cpu/cpu13/topology/physical_package_id | 1 + .../cpu/cpu13/topology/thread_siblings_list | 1 + .../system/cpu/cpu14/cache/index0/level | 1 + .../system/cpu/cpu14/cache/index1/level | 1 + .../system/cpu/cpu14/cache/index2/level | 1 + .../system/cpu/cpu14/cache/index3/id | 1 + .../system/cpu/cpu14/cache/index3/level | 1 + .../cpu/cpu14/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu14/cache/index3/size | 1 + .../system/cpu/cpu14/cache/index3/type | 1 + .../system/cpu/cpu14/topology/core_id | 1 + .../system/cpu/cpu14/topology/die_id | 1 + .../cpu/cpu14/topology/physical_package_id | 1 + .../cpu/cpu14/topology/thread_siblings_list | 1 + .../system/cpu/cpu15/cache/index0/level | 1 + .../system/cpu/cpu15/cache/index1/level | 1 + .../system/cpu/cpu15/cache/index2/level | 1 + .../system/cpu/cpu15/cache/index3/id | 1 + .../system/cpu/cpu15/cache/index3/level | 1 + .../cpu/cpu15/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu15/cache/index3/size | 1 + .../system/cpu/cpu15/cache/index3/type | 1 + .../system/cpu/cpu15/topology/core_id | 1 + .../system/cpu/cpu15/topology/die_id | 1 + .../cpu/cpu15/topology/physical_package_id | 1 + .../cpu/cpu15/topology/thread_siblings_list | 1 + .../system/cpu/cpu16/cache/index0/level | 1 + .../system/cpu/cpu16/cache/index1/level | 1 + .../system/cpu/cpu16/cache/index2/level | 1 + .../system/cpu/cpu16/cache/index3/id | 1 + .../system/cpu/cpu16/cache/index3/level | 1 + .../cpu/cpu16/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu16/cache/index3/size | 1 + .../system/cpu/cpu16/cache/index3/type | 1 + .../system/cpu/cpu16/topology/core_id | 1 + .../system/cpu/cpu16/topology/die_id | 1 + .../cpu/cpu16/topology/physical_package_id | 1 + .../cpu/cpu16/topology/thread_siblings_list | 1 + .../system/cpu/cpu17/cache/index0/level | 1 + .../system/cpu/cpu17/cache/index1/level | 1 + .../system/cpu/cpu17/cache/index2/level | 1 + .../system/cpu/cpu17/cache/index3/id | 1 + .../system/cpu/cpu17/cache/index3/level | 1 + .../cpu/cpu17/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu17/cache/index3/size | 1 + .../system/cpu/cpu17/cache/index3/type | 1 + .../system/cpu/cpu17/topology/core_id | 1 + .../system/cpu/cpu17/topology/die_id | 1 + .../cpu/cpu17/topology/physical_package_id | 1 + .../cpu/cpu17/topology/thread_siblings_list | 1 + .../system/cpu/cpu18/cache/index0/level | 1 + .../system/cpu/cpu18/cache/index1/level | 1 + .../system/cpu/cpu18/cache/index2/level | 1 + .../system/cpu/cpu18/cache/index3/id | 1 + .../system/cpu/cpu18/cache/index3/level | 1 + .../cpu/cpu18/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu18/cache/index3/size | 1 + .../system/cpu/cpu18/cache/index3/type | 1 + .../system/cpu/cpu18/topology/core_id | 1 + .../system/cpu/cpu18/topology/die_id | 1 + .../cpu/cpu18/topology/physical_package_id | 1 + .../cpu/cpu18/topology/thread_siblings_list | 1 + .../system/cpu/cpu19/cache/index0/level | 1 + .../system/cpu/cpu19/cache/index1/level | 1 + .../system/cpu/cpu19/cache/index2/level | 1 + .../system/cpu/cpu19/cache/index3/id | 1 + .../system/cpu/cpu19/cache/index3/level | 1 + .../cpu/cpu19/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu19/cache/index3/size | 1 + .../system/cpu/cpu19/cache/index3/type | 1 + .../system/cpu/cpu19/topology/core_id | 1 + .../system/cpu/cpu19/topology/die_id | 1 + .../cpu/cpu19/topology/physical_package_id | 1 + .../cpu/cpu19/topology/thread_siblings_list | 1 + .../system/cpu/cpu2/cache/index0/level | 1 + .../system/cpu/cpu2/cache/index1/level | 1 + .../system/cpu/cpu2/cache/index2/level | 1 + .../system/cpu/cpu2/cache/index3/id | 1 + .../system/cpu/cpu2/cache/index3/level | 1 + .../cpu/cpu2/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu2/cache/index3/size | 1 + .../system/cpu/cpu2/cache/index3/type | 1 + .../system/cpu/cpu2/topology/core_id | 1 + .../system/cpu/cpu2/topology/die_id | 1 + .../cpu/cpu2/topology/physical_package_id | 1 + .../cpu/cpu2/topology/thread_siblings_list | 1 + .../system/cpu/cpu20/cache/index0/level | 1 + .../system/cpu/cpu20/cache/index1/level | 1 + .../system/cpu/cpu20/cache/index2/level | 1 + .../system/cpu/cpu20/cache/index3/id | 1 + .../system/cpu/cpu20/cache/index3/level | 1 + .../cpu/cpu20/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu20/cache/index3/size | 1 + .../system/cpu/cpu20/cache/index3/type | 1 + .../system/cpu/cpu20/topology/core_id | 1 + .../system/cpu/cpu20/topology/die_id | 1 + .../cpu/cpu20/topology/physical_package_id | 1 + .../cpu/cpu20/topology/thread_siblings_list | 1 + .../system/cpu/cpu21/cache/index0/level | 1 + .../system/cpu/cpu21/cache/index1/level | 1 + .../system/cpu/cpu21/cache/index2/level | 1 + .../system/cpu/cpu21/cache/index3/id | 1 + .../system/cpu/cpu21/cache/index3/level | 1 + .../cpu/cpu21/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu21/cache/index3/size | 1 + .../system/cpu/cpu21/cache/index3/type | 1 + .../system/cpu/cpu21/topology/core_id | 1 + .../system/cpu/cpu21/topology/die_id | 1 + .../cpu/cpu21/topology/physical_package_id | 1 + .../cpu/cpu21/topology/thread_siblings_list | 1 + .../system/cpu/cpu22/cache/index0/level | 1 + .../system/cpu/cpu22/cache/index1/level | 1 + .../system/cpu/cpu22/cache/index2/level | 1 + .../system/cpu/cpu22/cache/index3/id | 1 + .../system/cpu/cpu22/cache/index3/level | 1 + .../cpu/cpu22/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu22/cache/index3/size | 1 + .../system/cpu/cpu22/cache/index3/type | 1 + .../system/cpu/cpu22/topology/core_id | 1 + .../system/cpu/cpu22/topology/die_id | 1 + .../cpu/cpu22/topology/physical_package_id | 1 + .../cpu/cpu22/topology/thread_siblings_list | 1 + .../system/cpu/cpu23/cache/index0/level | 1 + .../system/cpu/cpu23/cache/index1/level | 1 + .../system/cpu/cpu23/cache/index2/level | 1 + .../system/cpu/cpu23/cache/index3/id | 1 + .../system/cpu/cpu23/cache/index3/level | 1 + .../cpu/cpu23/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu23/cache/index3/size | 1 + .../system/cpu/cpu23/cache/index3/type | 1 + .../system/cpu/cpu23/topology/core_id | 1 + .../system/cpu/cpu23/topology/die_id | 1 + .../cpu/cpu23/topology/physical_package_id | 1 + .../cpu/cpu23/topology/thread_siblings_list | 1 + .../system/cpu/cpu3/cache/index0/level | 1 + .../system/cpu/cpu3/cache/index1/level | 1 + .../system/cpu/cpu3/cache/index2/level | 1 + .../system/cpu/cpu3/cache/index3/id | 1 + .../system/cpu/cpu3/cache/index3/level | 1 + .../cpu/cpu3/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu3/cache/index3/size | 1 + .../system/cpu/cpu3/cache/index3/type | 1 + .../system/cpu/cpu3/topology/core_id | 1 + .../system/cpu/cpu3/topology/die_id | 1 + .../cpu/cpu3/topology/physical_package_id | 1 + .../cpu/cpu3/topology/thread_siblings_list | 1 + .../system/cpu/cpu4/cache/index0/level | 1 + .../system/cpu/cpu4/cache/index1/level | 1 + .../system/cpu/cpu4/cache/index2/level | 1 + .../system/cpu/cpu4/cache/index3/id | 1 + .../system/cpu/cpu4/cache/index3/level | 1 + .../cpu/cpu4/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu4/cache/index3/size | 1 + .../system/cpu/cpu4/cache/index3/type | 1 + .../system/cpu/cpu4/topology/core_id | 1 + .../system/cpu/cpu4/topology/die_id | 1 + .../cpu/cpu4/topology/physical_package_id | 1 + .../cpu/cpu4/topology/thread_siblings_list | 1 + .../system/cpu/cpu5/cache/index0/level | 1 + .../system/cpu/cpu5/cache/index1/level | 1 + .../system/cpu/cpu5/cache/index2/level | 1 + .../system/cpu/cpu5/cache/index3/id | 1 + .../system/cpu/cpu5/cache/index3/level | 1 + .../cpu/cpu5/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu5/cache/index3/size | 1 + .../system/cpu/cpu5/cache/index3/type | 1 + .../system/cpu/cpu5/topology/core_id | 1 + .../system/cpu/cpu5/topology/die_id | 1 + .../cpu/cpu5/topology/physical_package_id | 1 + .../cpu/cpu5/topology/thread_siblings_list | 1 + .../system/cpu/cpu6/cache/index0/level | 1 + .../system/cpu/cpu6/cache/index1/level | 1 + .../system/cpu/cpu6/cache/index2/level | 1 + .../system/cpu/cpu6/cache/index3/id | 1 + .../system/cpu/cpu6/cache/index3/level | 1 + .../cpu/cpu6/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu6/cache/index3/size | 1 + .../system/cpu/cpu6/cache/index3/type | 1 + .../system/cpu/cpu6/topology/core_id | 1 + .../system/cpu/cpu6/topology/die_id | 1 + .../cpu/cpu6/topology/physical_package_id | 1 + .../cpu/cpu6/topology/thread_siblings_list | 1 + .../system/cpu/cpu7/cache/index0/level | 1 + .../system/cpu/cpu7/cache/index1/level | 1 + .../system/cpu/cpu7/cache/index2/level | 1 + .../system/cpu/cpu7/cache/index3/id | 1 + .../system/cpu/cpu7/cache/index3/level | 1 + .../cpu/cpu7/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu7/cache/index3/size | 1 + .../system/cpu/cpu7/cache/index3/type | 1 + .../system/cpu/cpu7/topology/core_id | 1 + .../system/cpu/cpu7/topology/die_id | 1 + .../cpu/cpu7/topology/physical_package_id | 1 + .../cpu/cpu7/topology/thread_siblings_list | 1 + .../system/cpu/cpu8/cache/index0/level | 1 + .../system/cpu/cpu8/cache/index1/level | 1 + .../system/cpu/cpu8/cache/index2/level | 1 + .../system/cpu/cpu8/cache/index3/id | 1 + .../system/cpu/cpu8/cache/index3/level | 1 + .../cpu/cpu8/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu8/cache/index3/size | 1 + .../system/cpu/cpu8/cache/index3/type | 1 + .../system/cpu/cpu8/topology/core_id | 1 + .../system/cpu/cpu8/topology/die_id | 1 + .../cpu/cpu8/topology/physical_package_id | 1 + .../cpu/cpu8/topology/thread_siblings_list | 1 + .../system/cpu/cpu9/cache/index0/level | 1 + .../system/cpu/cpu9/cache/index1/level | 1 + .../system/cpu/cpu9/cache/index2/level | 1 + .../system/cpu/cpu9/cache/index3/id | 1 + .../system/cpu/cpu9/cache/index3/level | 1 + .../cpu/cpu9/cache/index3/shared_cpu_list | 1 + .../system/cpu/cpu9/cache/index3/size | 1 + .../system/cpu/cpu9/cache/index3/type | 1 + .../system/cpu/cpu9/topology/core_id | 1 + .../system/cpu/cpu9/topology/die_id | 1 + .../cpu/cpu9/topology/physical_package_id | 1 + .../cpu/cpu9/topology/thread_siblings_list | 1 + .../linux-hmat/system/cpu/online | 1 + .../node/node0/access0/initiators/node0 | 1 + .../node0/access0/initiators/read_bandwidth | 1 + .../node0/access0/initiators/read_latency | 1 + .../node0/access0/initiators/write_bandwidth | 1 + .../node0/access0/initiators/write_latency | 1 + .../system/node/node0/access0/targets/node0 | 1 + .../system/node/node0/access0/targets/node1 | 1 + .../node/node0/access1/initiators/node0 | 1 + .../node0/access1/initiators/read_bandwidth | 1 + .../node0/access1/initiators/read_latency | 1 + .../node0/access1/initiators/write_bandwidth | 1 + .../node0/access1/initiators/write_latency | 1 + .../system/node/node0/access1/targets/node0 | 1 + .../system/node/node0/access1/targets/node1 | 1 + .../linux-hmat/system/node/node0/cpulist | 1 + .../linux-hmat/system/node/node0/distance | 1 + .../hugepages-1048576kB/free_hugepages | 1 + .../hugepages-1048576kB/nr_hugepages | 1 + .../hugepages-1048576kB/surplus_hugepages | 1 + .../hugepages/hugepages-2048kB/free_hugepages | 1 + .../hugepages/hugepages-2048kB/nr_hugepages | 1 + .../hugepages-2048kB/surplus_hugepages | 1 + .../node0/memory_side_cache/index1/indexing | 1 + .../node0/memory_side_cache/index1/line_size | 1 + .../node/node0/memory_side_cache/index1/size | 1 + .../memory_side_cache/index1/write_policy | 1 + .../node0/memory_side_cache/index2/indexing | 1 + .../node0/memory_side_cache/index2/line_size | 1 + .../node/node0/memory_side_cache/index2/size | 1 + .../memory_side_cache/index2/write_policy | 1 + .../node/node1/access0/initiators/node0 | 1 + .../node1/access0/initiators/read_bandwidth | 1 + .../node1/access0/initiators/read_latency | 1 + .../node1/access0/initiators/write_bandwidth | 1 + .../node1/access0/initiators/write_latency | 1 + .../node/node1/access1/initiators/node0 | 1 + .../node1/access1/initiators/read_bandwidth | 1 + .../node1/access1/initiators/read_latency | 1 + .../node1/access1/initiators/write_bandwidth | 1 + .../node1/access1/initiators/write_latency | 1 + .../linux-hmat/system/node/node1/cpulist | 1 + .../linux-hmat/system/node/node1/distance | 1 + .../hugepages-1048576kB/free_hugepages | 1 + .../hugepages-1048576kB/nr_hugepages | 1 + .../hugepages-1048576kB/surplus_hugepages | 1 + .../hugepages/hugepages-2048kB/free_hugepages | 1 + .../hugepages/hugepages-2048kB/nr_hugepages | 1 + .../hugepages-2048kB/surplus_hugepages | 1 + .../node1/memory_side_cache/index1/indexing | 1 + .../node1/memory_side_cache/index1/line_size | 1 + .../node/node1/memory_side_cache/index1/size | 1 + .../memory_side_cache/index1/write_policy | 1 + .../linux-hmat/system/node/online | 1 + tests/vircaps2xmldata/vircaps-x86_64-hmat.xml | 105 +++++ tests/vircaps2xmltest.c | 33 +- 355 files changed, 1042 insertions(+), 222 deletions(-) create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu0/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu0/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu0/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu0/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu0/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu0/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu0/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu0/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu0/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu0/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu0/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu0/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu1/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu1/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu1/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu1/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu1/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu1/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu1/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu1/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu1/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu1/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu1/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu1/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu10/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu10/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu10/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu10/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu10/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu10/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu10/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu10/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu10/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu10/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu10/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu10/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu11/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu11/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu11/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu11/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu11/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu11/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu11/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu11/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu11/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu11/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu11/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu11/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu12/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu12/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu12/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu12/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu12/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu12/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu12/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu12/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu12/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu12/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu12/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu12/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu13/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu13/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu13/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu13/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu13/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu13/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu13/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu13/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu13/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu13/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu13/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu13/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu14/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu14/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu14/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu14/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu14/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu14/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu14/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu14/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu14/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu14/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu14/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu14/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu15/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu15/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu15/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu15/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu15/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu15/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu15/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu15/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu15/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu15/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu15/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu15/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu16/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu16/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu16/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu16/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu16/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu16/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu16/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu16/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu16/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu16/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu16/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu16/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu17/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu17/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu17/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu17/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu17/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu17/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu17/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu17/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu17/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu17/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu17/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu17/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu18/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu18/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu18/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu18/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu18/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu18/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu18/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu18/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu18/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu18/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu18/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu18/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu19/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu19/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu19/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu19/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu19/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu19/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu19/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu19/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu19/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu19/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu19/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu19/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu2/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu2/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu2/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu2/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu2/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu2/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu2/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu2/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu2/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu2/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu2/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu2/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu20/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu20/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu20/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu20/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu20/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu20/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu20/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu20/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu20/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu20/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu20/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu20/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu21/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu21/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu21/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu21/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu21/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu21/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu21/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu21/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu21/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu21/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu21/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu21/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu22/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu22/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu22/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu22/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu22/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu22/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu22/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu22/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu22/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu22/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu22/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu22/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu23/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu23/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu23/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu23/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu23/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu23/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu23/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu23/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu23/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu23/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu23/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu23/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu3/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu3/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu3/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu3/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu3/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu3/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu3/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu3/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu3/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu3/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu3/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu3/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu4/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu4/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu4/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu4/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu4/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu4/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu4/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu4/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu4/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu4/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu4/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu4/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu5/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu5/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu5/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu5/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu5/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu5/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu5/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu5/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu5/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu5/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu5/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu5/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu6/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu6/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu6/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu6/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu6/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu6/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu6/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu6/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu6/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu6/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu6/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu6/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu7/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu7/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu7/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu7/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu7/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu7/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu7/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu7/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu7/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu7/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu7/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu7/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu8/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu8/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu8/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu8/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu8/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu8/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu8/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu8/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu8/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu8/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu8/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu8/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu9/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu9/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu9/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu9/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu9/cache/index3/level create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu9/cache/index3/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu9/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu9/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu9/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu9/topology/die_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu9/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/cpu9/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-hmat/system/cpu/online create mode 120000 tests/vircaps2xmldata/linux-hmat/system/node/node0/access0/initiators/node0 create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/access0/initiators/read_bandwidth create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/access0/initiators/read_latency create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/access0/initiators/write_bandwidth create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/access0/initiators/write_latency create mode 120000 tests/vircaps2xmldata/linux-hmat/system/node/node0/access0/targets/node0 create mode 120000 tests/vircaps2xmldata/linux-hmat/system/node/node0/access0/targets/node1 create mode 120000 tests/vircaps2xmldata/linux-hmat/system/node/node0/access1/initiators/node0 create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/access1/initiators/read_bandwidth create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/access1/initiators/read_latency create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/access1/initiators/write_bandwidth create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/access1/initiators/write_latency create mode 120000 tests/vircaps2xmldata/linux-hmat/system/node/node0/access1/targets/node0 create mode 120000 tests/vircaps2xmldata/linux-hmat/system/node/node0/access1/targets/node1 create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/cpulist create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/distance create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/hugepages/hugepages-1048576kB/free_hugepages create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/hugepages/hugepages-1048576kB/nr_hugepages create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/hugepages/hugepages-1048576kB/surplus_hugepages create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/hugepages/hugepages-2048kB/free_hugepages create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/hugepages/hugepages-2048kB/nr_hugepages create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/hugepages/hugepages-2048kB/surplus_hugepages create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/memory_side_cache/index1/indexing create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/memory_side_cache/index1/line_size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/memory_side_cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/memory_side_cache/index1/write_policy create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/memory_side_cache/index2/indexing create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/memory_side_cache/index2/line_size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/memory_side_cache/index2/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node0/memory_side_cache/index2/write_policy create mode 120000 tests/vircaps2xmldata/linux-hmat/system/node/node1/access0/initiators/node0 create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/access0/initiators/read_bandwidth create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/access0/initiators/read_latency create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/access0/initiators/write_bandwidth create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/access0/initiators/write_latency create mode 120000 tests/vircaps2xmldata/linux-hmat/system/node/node1/access1/initiators/node0 create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/access1/initiators/read_bandwidth create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/access1/initiators/read_latency create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/access1/initiators/write_bandwidth create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/access1/initiators/write_latency create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/cpulist create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/distance create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/hugepages/hugepages-1048576kB/free_hugepages create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/hugepages/hugepages-1048576kB/nr_hugepages create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/hugepages/hugepages-1048576kB/surplus_hugepages create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/hugepages/hugepages-2048kB/free_hugepages create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/hugepages/hugepages-2048kB/nr_hugepages create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/hugepages/hugepages-2048kB/surplus_hugepages create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/memory_side_cache/index1/indexing create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/memory_side_cache/index1/line_size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/memory_side_cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/node1/memory_side_cache/index1/write_policy create mode 100644 tests/vircaps2xmldata/linux-hmat/system/node/online create mode 100644 tests/vircaps2xmldata/vircaps-x86_64-hmat.xml -- 2.31.1

3 16

[PATCH] tools: only fail validations if VIR_HOST_VALIDATE_FAIL is set
by Fabiano Fidêncio 07 Jun '21

07 Jun '21

Currently `virt-host-validate` will fail whenever one of its calls fail, regardless of virHostValidateLevel set. This behaviour is not optimal and makes it not exactly reliable as a command line tool as other tools or scripts using it would have to check its output to figure out whether something really failed or if a warning was mistakenly treated as failure. With this change, the behaviour of whether to fail or not, is defined by the caller of those functions, based on the virHostValidateLevel passed to them. Signed-off-by: Fabiano Fidêncio <fabiano(a)fidencio.org> --- tools/virt-host-validate-common.c | 129 ++++++++++++++++++++++-------- 1 file changed, 94 insertions(+), 35 deletions(-) diff --git a/tools/virt-host-validate-common.c b/tools/virt-host-validate-common.c index 6dd851f07d..2bf97bad75 100644 --- a/tools/virt-host-validate-common.c +++ b/tools/virt-host-validate-common.c @@ -138,15 +138,21 @@ int virHostValidateDeviceExists(const char *hvname, virHostValidateLevel level, const char *hint) { + int ret = 0; + virHostMsgCheck(hvname, "if device %s exists", dev_name); if (access(dev_name, F_OK) < 0) { virHostMsgFail(level, "%s", hint); - return -1; + if (level == VIR_HOST_VALIDATE_FAIL) + ret = -1; + goto out; } virHostMsgPass(); - return 0; + + out: + return ret; } @@ -155,15 +161,21 @@ int virHostValidateDeviceAccessible(const char *hvname, virHostValidateLevel level, const char *hint) { + int ret = 0; + virHostMsgCheck(hvname, "if device %s is accessible", dev_name); if (access(dev_name, R_OK|W_OK) < 0) { virHostMsgFail(level, "%s", hint); - return -1; + if (level == VIR_HOST_VALIDATE_FAIL) + ret = -1; + goto out; } virHostMsgPass(); - return 0; + + out: + return ret; } @@ -173,6 +185,7 @@ int virHostValidateNamespace(const char *hvname, const char *hint) { char nspath[100]; + int ret = 0; virHostMsgCheck(hvname, "for namespace %s", ns_name); @@ -180,11 +193,15 @@ int virHostValidateNamespace(const char *hvname, if (access(nspath, F_OK) < 0) { virHostMsgFail(level, "%s", hint); - return -1; + if (level == VIR_HOST_VALIDATE_FAIL) + ret = -1; + goto out; } virHostMsgPass(); - return 0; + + out: + return ret; } @@ -254,6 +271,7 @@ int virHostValidateLinuxKernel(const char *hvname, { struct utsname uts; unsigned long thisversion; + int ret = 0; uname(&uts); @@ -264,21 +282,29 @@ int virHostValidateLinuxKernel(const char *hvname, if (STRNEQ(uts.sysname, "Linux")) { virHostMsgFail(level, "%s", hint); - return -1; + if (level == VIR_HOST_VALIDATE_FAIL) + ret = -1; + goto out; } if (virParseVersionString(uts.release, &thisversion, true) < 0) { virHostMsgFail(level, "%s", hint); - return -1; + if (level == VIR_HOST_VALIDATE_FAIL) + ret = -1; + goto out; } if (thisversion < version) { virHostMsgFail(level, "%s", hint); - return -1; - } else { - virHostMsgPass(); - return 0; + if (level == VIR_HOST_VALIDATE_FAIL) + ret = -1; + goto out; } + + virHostMsgPass(); + + out: + return ret; } #ifdef __linux__ @@ -290,8 +316,11 @@ int virHostValidateCGroupControllers(const char *hvname, int ret = 0; size_t i; - if (virCgroupNew("/", -1, &group) < 0) - return -1; + if (virCgroupNew("/", -1, &group) < 0) { + if (level == VIR_HOST_VALIDATE_FAIL) + ret = -1; + goto out; + } for (i = 0; i < VIR_CGROUP_CONTROLLER_LAST; i++) { int flag = 1 << i; @@ -303,7 +332,8 @@ int virHostValidateCGroupControllers(const char *hvname, virHostMsgCheck(hvname, "for cgroup '%s' controller support", cg_name); if (!virCgroupHasController(group, i)) { - ret = -1; + if (level == VIR_HOST_VALIDATE_FAIL) + ret = -1; virHostMsgFail(level, "Enable '%s' in kernel Kconfig file or " "mount/enable cgroup controller in your system", cg_name); @@ -312,6 +342,7 @@ int virHostValidateCGroupControllers(const char *hvname, } } + out: return ret; } #else /* !__linux__ */ @@ -319,8 +350,13 @@ int virHostValidateCGroupControllers(const char *hvname G_GNUC_UNUSED, int controllers G_GNUC_UNUSED, virHostValidateLevel level) { + int ret = 0; + virHostMsgFail(level, "%s", "This platform does not support cgroups"); - return -1; + if (level == VIR_HOST_VALIDATE_FAIL) + ret = -1; + + return ret; } #endif /* !__linux__ */ @@ -334,6 +370,7 @@ int virHostValidateIOMMU(const char *hvname, virArch arch = virArchFromHost(); struct dirent *dent; int rc; + int ret = 0; flags = virHostValidateGetCPUFlags(); @@ -354,7 +391,9 @@ int virHostValidateIOMMU(const char *hvname, "No ACPI DMAR table found, IOMMU either " "disabled in BIOS or not supported by this " "hardware platform"); - return -1; + if (level == VIR_HOST_VALIDATE_FAIL) + ret = -1; + goto out; } } else if (isAMD) { virHostMsgCheck(hvname, "%s", _("for device assignment IOMMU support")); @@ -366,7 +405,9 @@ int virHostValidateIOMMU(const char *hvname, "No ACPI IVRS table found, IOMMU either " "disabled in BIOS or not supported by this " "hardware platform"); - return -1; + if (level == VIR_HOST_VALIDATE_FAIL) + ret = -1; + goto out; } } else if (ARCH_IS_PPC64(arch)) { /* Empty Block */ @@ -378,23 +419,25 @@ int virHostValidateIOMMU(const char *hvname, * no PCI devices the directory is still there but is * empty. */ if (!virDirOpen(&dir, "/sys/bus/pci/devices")) - return 0; + goto out; rc = virDirRead(dir, &dent, NULL); if (rc <= 0) - return 0; + goto out; } else { virHostMsgFail(level, "Unknown if this platform has IOMMU support"); - return -1; + if (level == VIR_HOST_VALIDATE_FAIL) + ret = -1; + goto out; } /* We can only check on newer kernels with iommu groups & vfio */ if (stat("/sys/kernel/iommu_groups", &sb) < 0) - return 0; + goto out; if (!S_ISDIR(sb.st_mode)) - return 0; + goto out; virHostMsgCheck(hvname, "%s", _("if IOMMU is enabled by kernel")); if (sb.st_nlink <= 2) { @@ -404,10 +447,16 @@ int virHostValidateIOMMU(const char *hvname, "Add %s to kernel cmdline arguments", bootarg); else virHostMsgFail(level, "IOMMU capability not compiled into kernel."); - return -1; + if (level == VIR_HOST_VALIDATE_FAIL) + ret = -1; + goto out; + } + virHostMsgPass(); - return 0; + + out: + return ret; } @@ -448,6 +497,7 @@ int virHostValidateSecureGuests(const char *hvname, g_autofree char *cmdline = NULL; static const char *kIBMValues[] = {"y", "Y", "on", "ON", "oN", "On", "1"}; g_autofree char *mod_value = NULL; + int ret = 0; flags = virHostValidateGetCPUFlags(); @@ -464,12 +514,15 @@ int virHostValidateSecureGuests(const char *hvname, if (!virFileIsDir("/sys/firmware/uv")) { virHostMsgFail(level, "IBM Secure Execution not supported by " "the currently used kernel"); - return 0; + goto out; } - if (virFileReadValueString(&cmdline, "/proc/cmdline") < 0) - return -1; - + if (virFileReadValueString(&cmdline, "/proc/cmdline") < 0) { + if (level == VIR_HOST_VALIDATE_FAIL) { + ret = -1; + goto out; + } + } /* we're prefix matching rather than equality matching here, because * kernel would treat even something like prot_virt='yFOO' as * enabled @@ -479,7 +532,8 @@ int virHostValidateSecureGuests(const char *hvname, VIR_KERNEL_CMDLINE_FLAGS_SEARCH_FIRST | VIR_KERNEL_CMDLINE_FLAGS_CMP_PREFIX)) { virHostMsgPass(); - return 1; + ret = 1; + goto out; } else { virHostMsgFail(level, "IBM Secure Execution appears to be disabled " @@ -494,7 +548,7 @@ int virHostValidateSecureGuests(const char *hvname, if (virFileReadValueString(&mod_value, "/sys/module/kvm_amd/parameters/sev") < 0) { virHostMsgFail(level, "AMD Secure Encrypted Virtualization not " "supported by the currently used kernel"); - return 0; + goto out; } if (mod_value[0] != '1') { @@ -502,12 +556,13 @@ int virHostValidateSecureGuests(const char *hvname, "AMD Secure Encrypted Virtualization appears to be " "disabled in kernel. Add kvm_amd.sev=1 " "to the kernel cmdline arguments"); - return 0; + goto out; } if (virFileExists("/dev/sev")) { virHostMsgPass(); - return 1; + ret = 1; + goto out; } else { virHostMsgFail(level, "AMD Secure Encrypted Virtualization appears to be " @@ -516,8 +571,12 @@ int virHostValidateSecureGuests(const char *hvname, } else { virHostMsgFail(level, "Unknown if this platform has Secure Guest support"); - return -1; + if (level == VIR_HOST_VALIDATE_FAIL) + ret = -1; + goto out; + } - return 0; + out: + return ret; } -- 2.31.1

2 3

[PATCH 0/3] Couple of build fixes
by Michal Privoznik 07 Jun '21

07 Jun '21

Here's pipeline: https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/315940894 I have not merged these yet. I'll give others a chance to fix my grammar :-) Michal Prívozník (3): doRemoteOpen: Drop @daemonPath virnetsocket: Mark @spawnDaemonPath of virNetSocketNewConnectUNIX() unused remoteGetUNIXSocket: Complete variable rename for WIN32 src/remote/remote_driver.c | 3 --- src/remote/remote_sockets.c | 2 +- src/rpc/virnetsocket.c | 2 +- 3 files changed, 2 insertions(+), 5 deletions(-) -- 2.31.1

3 5