- Devel - libvirt List Archives

[PATCH] qemu: monitor: Remove disabled debug infrastructure
by Peter Krempa 03 Jan '22

03 Jan '22

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_monitor.c | 44 ----------------------------------------- 1 file changed, 44 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index dda6ae9796..32e4ff1191 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -56,9 +56,6 @@ VIR_LOG_INIT("qemu.qemu_monitor"); -#define DEBUG_IO 0 -#define DEBUG_RAW_IO 0 - /* We read from QEMU until seeing a \r\n pair to indicate a * completed reply or event. To avoid memory denial-of-service * though, we must have a size limit on amount of data we @@ -210,25 +207,6 @@ VIR_ENUM_IMPL(qemuMonitorMemoryFailureAction, "ignore", "inject", "fatal", "reset"); -#if DEBUG_RAW_IO -static char * -qemuMonitorEscapeNonPrintable(const char *text) -{ - size_t i; - g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; - for (i = 0; text[i] != '\0'; i++) { - if (g_ascii_isprint(text[i]) || - text[i] == '\n' || - (text[i] == '\r' && text[i + 1] == '\n')) - virBufferAddChar(&buf, text[i]); - else - virBufferAsprintf(&buf, "0x%02x", text[i]); - } - return virBufferContentAndReset(&buf); -} -#endif - - static void qemuMonitorDispose(void *obj) { @@ -329,17 +307,6 @@ qemuMonitorIOProcess(qemuMonitor *mon) if (mon->msg && mon->msg->txOffset == mon->msg->txLength) msg = mon->msg; -#if DEBUG_IO -# if DEBUG_RAW_IO - char *str1 = qemuMonitorEscapeNonPrintable(msg ? msg->txBuffer : ""); - char *str2 = qemuMonitorEscapeNonPrintable(mon->buffer); - VIR_ERROR(_("Process %d %p %p [[[[%s]]][[[%s]]]"), (int)mon->bufferOffset, mon->msg, msg, str1, str2); - VIR_FREE(str1); - VIR_FREE(str2); -# else - VIR_DEBUG("Process %d", (int)mon->bufferOffset); -# endif -#endif PROBE_QUIET(QEMU_MONITOR_IO_PROCESS, "mon=%p buf=%s len=%zu", mon, mon->buffer, mon->bufferOffset); @@ -360,10 +327,6 @@ qemuMonitorIOProcess(qemuMonitor *mon) VIR_FREE(mon->buffer); mon->bufferOffset = mon->bufferLength = 0; } -#if DEBUG_IO - VIR_DEBUG("Process done %d used %d", (int)mon->bufferOffset, len); -#endif - /* As the monitor mutex was unlocked in qemuMonitorJSONIOProcess() * while dealing with qemu event, mon->msg could be changed which * means the above 'msg' may be invalid, thus we use 'mon->msg' here */ @@ -505,10 +468,6 @@ qemuMonitorIORead(qemuMonitor *mon) mon->buffer[mon->bufferOffset] = '\0'; } -#if DEBUG_IO - VIR_DEBUG("Now read %d bytes of data", (int)mon->bufferOffset); -#endif - return ret; } @@ -535,9 +494,6 @@ qemuMonitorIO(GSocket *socket G_GNUC_UNUSED, /* lock access to the monitor and protect fd */ virObjectLock(mon); -#if DEBUG_IO - VIR_DEBUG("Monitor %p I/O on socket %p cond %d", mon, socket, cond); -#endif if (mon->fd == -1 || !mon->watch) { virObjectUnlock(mon); virObjectUnref(mon); -- 2.31.1

2 1

CDROM hotplug not supported even with usb bus
by Tianren Zhang 03 Jan '22

03 Jan '22

Hi, I am using libvirt-4.5.0 + qemu-kvm-ev-2.12.0 and I have a question about the cdrom function of libvirt. When I tried to attach a CD ROM, it rejected the operation showing "cdrom/floppy device hotplug isn't supported". I understand that it should be rejected when the IDE bus is used, but the hotplug with USB bus is totally feasible, as it's also supported in qemu, in this case, should it be allowed for hotplug? I have not tried the newest version of libvirt yet, but looking at the upstream source code it seems that there is no change regarding this issue. Thank you, Tianren Zhang

2 1

[PATCH] virnettlscontext: Generate longer DH keys
by Michal Privoznik 03 Jan '22

03 Jan '22

Currently, we generate 2048 bits long DH keys. This may look enough, but it's not very future proof. When system crypto policy is tightened only 3072 or longer keys are valid. From CRYPTO-POLICIES(7): FUTURE A conservative security policy that is believed to withstand any near-term future attacks. ... • DH params size: >= 3072 • RSA keys size: >= 3072 This policy corresponds to GNUTLS_SEC_PARAM_HIGH parameters. Therefore, pass that to gnutls_sec_param_to_pk_bits() to get longer key. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Technically, this is a v2 of: https://listman.redhat.com/archives/libvir-list/2021-December/msg00827.html and was already reviewed. I'm sending it here because I've split the original patch into two. The first one, which switches to gnutls_sec_param_to_pk_bits() usage is merged. The second one (this one) which lengthens the key is not. src/rpc/virnettlscontext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rpc/virnettlscontext.c b/src/rpc/virnettlscontext.c index 55da485f96..f0b1e8f9c1 100644 --- a/src/rpc/virnettlscontext.c +++ b/src/rpc/virnettlscontext.c @@ -718,7 +718,7 @@ static virNetTLSContext *virNetTLSContextNew(const char *cacert, if (isServer) { unsigned int bits = 0; - bits = gnutls_sec_param_to_pk_bits(GNUTLS_PK_DH, GNUTLS_SEC_PARAM_MEDIUM); + bits = gnutls_sec_param_to_pk_bits(GNUTLS_PK_DH, GNUTLS_SEC_PARAM_HIGH); if (bits == 0) { virReportError(VIR_ERR_SYSTEM_ERROR, "%s", _("Unable to get key length for diffie-hellman parameters")); -- 2.34.1

2 1

[libvirt PATCH 0/3] tests: virtimetest: Skip more tests near year's end
by Andrea Bolognani 03 Jan '22

03 Jan '22

Failed pipeline: https://gitlab.com/libvirt/libvirt/-/pipelines/439750804 Fixed pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/439847251 Andrea Bolognani (3): tests: virtimetest: Move comment tests: virtimetest: Skip more tests near year's end tests: virtimetest: Mention GLib version containing fix tests/virtimetest.c | 58 ++++++++++++++++++++++----------------------- 1 file changed, 28 insertions(+), 30 deletions(-) -- 2.31.1

2 5

[libvirt PATCH] spec: Drop BuildRequires on ZFS
by Andrea Bolognani 03 Jan '22

03 Jan '22

We're no longer performing build time detection. Fixes: 506c3a39d6e645c8414c278ceaba97935f90cb95 Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- libvirt.spec.in | 6 ------ 1 file changed, 6 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 7bd74da2c9..9e24ba92ff 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -320,12 +320,6 @@ BuildRequires: glusterfs-devel >= 3.4.1 %if %{with_storage_sheepdog} BuildRequires: sheepdog %endif -%if %{with_storage_zfs} -# Support any conforming implementation of zfs. On stock Fedora -# this is zfs-fuse, but could be zfsonlinux upstream RPMs -BuildRequires: /sbin/zfs -BuildRequires: /sbin/zpool -%endif %if %{with_numactl} # For QEMU/LXC numa info BuildRequires: numactl-devel -- 2.31.1

2 1

[libvirt PATCH] meson: Don't require the parted command at build time
by Andrea Bolognani 03 Jan '22

03 Jan '22

We need libparted to be available at build time otherwise we can't link against it; we don't, however, need the parted command to be present until runtime and, just as is the case for other commands, we already perform a lookup through the virCommand API so making sure it's available at build time is unnecessary. This doesn't make any difference for platform such as Fedora and CentOS, where both the library and the command are in the same package, but others like Debian, Ubuntu and openSUSE have separate packages for the two components and this change means that we can install one less package at build time. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/437853370 meson.build | 8 -------- src/storage/storage_backend_disk.c | 2 ++ src/storage/storage_util.c | 2 ++ 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/meson.build b/meson.build index 57561adf51..be51af1934 100644 --- a/meson.build +++ b/meson.build @@ -1043,14 +1043,6 @@ endif libparted_version = '1.8.0' libparted_dep = dependency('libparted', version: '>=' + libparted_version, required: false) -if libparted_dep.found() - parted_prog = find_program('parted', required: false, dirs: libvirt_sbin_path) - if parted_prog.found() - conf.set_quoted('PARTED', parted_prog.path()) - else - libparted_dep = dependency('', required: false) - endif -endif libpcap_version = '1.5.0' if not get_option('libpcap').disabled() diff --git a/src/storage/storage_backend_disk.c b/src/storage/storage_backend_disk.c index 97554e2576..be8a535570 100644 --- a/src/storage/storage_backend_disk.c +++ b/src/storage/storage_backend_disk.c @@ -40,6 +40,8 @@ VIR_LOG_INIT("storage.storage_backend_disk"); #define SECTOR_SIZE 512 +#define PARTED "parted" + static bool virStorageVolPartFindExtended(virStorageVolDef *def, const void *opaque G_GNUC_UNUSED) diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index 03874d6ca3..728710153e 100644 --- a/src/storage/storage_util.c +++ b/src/storage/storage_util.c @@ -85,6 +85,8 @@ VIR_LOG_INIT("storage.storage_util"); # define S_IRWXUGO (S_IRWXU | S_IRWXG | S_IRWXO) #endif +#define PARTED "parted" + /* virStorageBackendNamespaceInit: * @poolType: virStoragePoolType * @xmlns: Storage Pool specific namespace callback methods -- 2.31.1

2 1

how to change nic's tx/rx ring size inside vm
by longguang.yue 31 Dec '21

31 Dec '21

Hi, all: my environment is qemu-kvm-6.0.0, 4.18.0-240, libvirt 7.4.0. vm is configured like this queues='4' rx_queue_size='1024' tx_queue_size='1024'. inside vm i can not change nic's ring size. changing tx leads to error 'Cannot set device ring parameters: Operation not supported'. changing rx leads to error 'rx unmodified, ignoring. no ring parameters changed, aborting' how to make it work and confirm what current value is? thanks

1 1

[libvirt PATCH] spec: Demote netcat to Recommends
by Andrea Bolognani 24 Dec '21

24 Dec '21

It is only needed if compatibility with clients using libvirt 6.9.0 is required, and can be uninstalled otherwise. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- libvirt.spec.in | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 7bd74da2c9..0180b4200c 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -402,8 +402,12 @@ Summary: Server side daemon and supporting files for libvirt library # The client side, i.e. shared libs are in a subpackage Requires: %{name}-libs = %{version}-%{release} -# (client invokes 'nc' against the UNIX socket on the server) -Requires: /usr/bin/nc +# netcat is needed on the server side so that clients that have +# libvirt < 6.9.0 can connect, but newer versions will prefer +# virt-ssh-helper. Making this a Recommends means that it gets +# installed by default, but can still be removed if compatibility +# with old clients is not required +Recommends: /usr/bin/nc # for modprobe of pci devices Requires: module-init-tools -- 2.31.1

2 1

[PATCH] docs: Fix indentation in shell snippet
by Andrea Bolognani 24 Dec '21

24 Dec '21

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. docs/daemons.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/daemons.rst b/docs/daemons.rst index 8a05ee77a7..c8ae3b0cef 100644 --- a/docs/daemons.rst +++ b/docs/daemons.rst @@ -402,7 +402,7 @@ host first. systemctl unmask virt${drv}d{,-ro,-admin}.socket systemctl enable virt${drv}d.service systemctl enable virt${drv}d{,-ro,-admin}.socket - done + done #. Start the sockets for the same set of daemons. There is no need to start the services as they will get started when the first socket connection is @@ -413,7 +413,7 @@ host first. $ for drv in qemu network nodedev nwfilter secret storage do systemctl start virt${drv}d{,-ro,-admin}.socket - done + done #. If connections from remote hosts need to be supported the proxy daemon must be enabled and started -- 2.31.1

1 0

[PATCH 0/5] tests: Tool for programatic modification of qemucapabilitiesdata/*.replies
by Peter Krempa 23 Dec '21

23 Dec '21

I was asked multiple times how to automate modification of the qemu capability dumps. I wrote a tool [1] that allowed doing that. Unfortunately as it wasn't in the repo it was not avalilable. Now I've finally set out to finish it. It masquerades as a test in default mode checking the ordering and numbering of the caps dump files as in the past there were few cases where manual edits broke it. In update mode it allows modification of the replies and gives few examples to do so. There's a lot of possible things users would want to do so there's no way around actually writing some code but it should be easier this way. Since this now does also numbering, the AWK/shell script 'qemucapsfixreplies' can be removed. [1]: Okay, okay. Copy&paste'd few bits from various places into one messy C file and didn't bother with memory cleanup. But it worked. Peter Krempa (5): util: json: Introduce virJSONValueObjectReplaceValue tests: qemumonitortestutils.h: Reformat header file qemumonitortestutils: Extract parser for the monitor conversation dump file tests: Tool for programatic modification of qemucapabilitiesdata/*.replies tests: Remove 'qemucapsfixreplies' src/libvirt_private.syms | 1 + src/util/virjson.c | 20 +++ src/util/virjson.h | 6 + tests/domaincapstest.c | 3 +- tests/meson.build | 1 + tests/qemucapabilitiesnumbering.c | 242 ++++++++++++++++++++++++++++++ tests/qemucapabilitiestest.c | 4 +- tests/qemucapsfixreplies | 26 ---- tests/qemumonitortestutils.c | 123 ++++++++++----- tests/qemumonitortestutils.h | 149 +++++++++++------- 10 files changed, 453 insertions(+), 122 deletions(-) create mode 100644 tests/qemucapabilitiesnumbering.c delete mode 100755 tests/qemucapsfixreplies -- 2.31.1

2 6

[PATCH] ci: Refresh dockerfiles
by Peter Krempa 22 Dec '21

22 Dec '21

Apart from some churn, the important is the removal of 'netcf-devel' from the fedora rawhide container. Update to state as of 174fe4999204afcae (libvirt-ci). Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- Pushed as trivial. It makes CI green again. .../debian-10-cross-aarch64.Dockerfile | 18 +++++++++--------- .../debian-10-cross-armv6l.Dockerfile | 18 +++++++++--------- .../debian-10-cross-armv7l.Dockerfile | 18 +++++++++--------- ci/containers/debian-10-cross-i686.Dockerfile | 18 +++++++++--------- ci/containers/debian-10-cross-mips.Dockerfile | 18 +++++++++--------- .../debian-10-cross-mips64el.Dockerfile | 18 +++++++++--------- .../debian-10-cross-mipsel.Dockerfile | 18 +++++++++--------- .../debian-10-cross-ppc64le.Dockerfile | 18 +++++++++--------- ci/containers/debian-10-cross-s390x.Dockerfile | 18 +++++++++--------- .../debian-11-cross-aarch64.Dockerfile | 12 ++++++------ .../debian-11-cross-armv6l.Dockerfile | 12 ++++++------ .../debian-11-cross-armv7l.Dockerfile | 12 ++++++------ ci/containers/debian-11-cross-i686.Dockerfile | 12 ++++++------ .../debian-11-cross-mips64el.Dockerfile | 12 ++++++------ .../debian-11-cross-mipsel.Dockerfile | 12 ++++++------ .../debian-11-cross-ppc64le.Dockerfile | 12 ++++++------ ci/containers/debian-11-cross-s390x.Dockerfile | 12 ++++++------ .../debian-sid-cross-aarch64.Dockerfile | 12 ++++++------ .../debian-sid-cross-armv6l.Dockerfile | 12 ++++++------ .../debian-sid-cross-armv7l.Dockerfile | 12 ++++++------ ci/containers/debian-sid-cross-i686.Dockerfile | 12 ++++++------ .../debian-sid-cross-mips64el.Dockerfile | 12 ++++++------ .../debian-sid-cross-mipsel.Dockerfile | 12 ++++++------ .../debian-sid-cross-ppc64le.Dockerfile | 12 ++++++------ .../debian-sid-cross-s390x.Dockerfile | 12 ++++++------ .../fedora-35-cross-mingw32.Dockerfile | 12 ++++++------ .../fedora-35-cross-mingw64.Dockerfile | 12 ++++++------ .../fedora-rawhide-cross-mingw32.Dockerfile | 12 ++++++------ .../fedora-rawhide-cross-mingw64.Dockerfile | 12 ++++++------ ci/containers/fedora-rawhide.Dockerfile | 1 - 30 files changed, 201 insertions(+), 202 deletions(-) diff --git a/ci/containers/debian-10-cross-aarch64.Dockerfile b/ci/containers/debian-10-cross-aarch64.Dockerfile index 38013eb84b..cfbf5bb48f 100644 --- a/ci/containers/debian-10-cross-aarch64.Dockerfile +++ b/ci/containers/debian-10-cross-aarch64.Dockerfile @@ -56,6 +56,15 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ dpkg-reconfigure locales +RUN pip3 install \ + meson==0.56.0 + +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN export DEBIAN_FRONTEND=noninteractive && \ dpkg --add-architecture arm64 && \ eatmydata apt-get update && \ @@ -117,14 +126,5 @@ endian = 'little'" > /usr/local/share/meson/cross/aarch64-linux-gnu && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/aarch64-linux-gnu-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/aarch64-linux-gnu-gcc -RUN pip3 install \ - meson==0.56.0 - -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "aarch64-linux-gnu" ENV MESON_OPTS "--cross-file=aarch64-linux-gnu" diff --git a/ci/containers/debian-10-cross-armv6l.Dockerfile b/ci/containers/debian-10-cross-armv6l.Dockerfile index f9bfa031fa..3308ac2e10 100644 --- a/ci/containers/debian-10-cross-armv6l.Dockerfile +++ b/ci/containers/debian-10-cross-armv6l.Dockerfile @@ -56,6 +56,15 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ dpkg-reconfigure locales +RUN pip3 install \ + meson==0.56.0 + +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN export DEBIAN_FRONTEND=noninteractive && \ dpkg --add-architecture armel && \ eatmydata apt-get update && \ @@ -116,14 +125,5 @@ endian = 'little'" > /usr/local/share/meson/cross/arm-linux-gnueabi && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/arm-linux-gnueabi-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/arm-linux-gnueabi-gcc -RUN pip3 install \ - meson==0.56.0 - -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "arm-linux-gnueabi" ENV MESON_OPTS "--cross-file=arm-linux-gnueabi" diff --git a/ci/containers/debian-10-cross-armv7l.Dockerfile b/ci/containers/debian-10-cross-armv7l.Dockerfile index 0ddb3c65f5..0dcd8ee1d7 100644 --- a/ci/containers/debian-10-cross-armv7l.Dockerfile +++ b/ci/containers/debian-10-cross-armv7l.Dockerfile @@ -56,6 +56,15 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ dpkg-reconfigure locales +RUN pip3 install \ + meson==0.56.0 + +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN export DEBIAN_FRONTEND=noninteractive && \ dpkg --add-architecture armhf && \ eatmydata apt-get update && \ @@ -117,14 +126,5 @@ endian = 'little'" > /usr/local/share/meson/cross/arm-linux-gnueabihf && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/arm-linux-gnueabihf-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/arm-linux-gnueabihf-gcc -RUN pip3 install \ - meson==0.56.0 - -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "arm-linux-gnueabihf" ENV MESON_OPTS "--cross-file=arm-linux-gnueabihf" diff --git a/ci/containers/debian-10-cross-i686.Dockerfile b/ci/containers/debian-10-cross-i686.Dockerfile index da14c20b3a..8806dff0c3 100644 --- a/ci/containers/debian-10-cross-i686.Dockerfile +++ b/ci/containers/debian-10-cross-i686.Dockerfile @@ -56,6 +56,15 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ dpkg-reconfigure locales +RUN pip3 install \ + meson==0.56.0 + +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN export DEBIAN_FRONTEND=noninteractive && \ dpkg --add-architecture i386 && \ eatmydata apt-get update && \ @@ -116,14 +125,5 @@ endian = 'little'" > /usr/local/share/meson/cross/i686-linux-gnu && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/i686-linux-gnu-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/i686-linux-gnu-gcc -RUN pip3 install \ - meson==0.56.0 - -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "i686-linux-gnu" ENV MESON_OPTS "--cross-file=i686-linux-gnu" diff --git a/ci/containers/debian-10-cross-mips.Dockerfile b/ci/containers/debian-10-cross-mips.Dockerfile index efaf7a155b..edc54fe1ac 100644 --- a/ci/containers/debian-10-cross-mips.Dockerfile +++ b/ci/containers/debian-10-cross-mips.Dockerfile @@ -56,6 +56,15 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ dpkg-reconfigure locales +RUN pip3 install \ + meson==0.56.0 + +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN export DEBIAN_FRONTEND=noninteractive && \ dpkg --add-architecture mips && \ eatmydata apt-get update && \ @@ -116,14 +125,5 @@ endian = 'big'" > /usr/local/share/meson/cross/mips-linux-gnu && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/mips-linux-gnu-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/mips-linux-gnu-gcc -RUN pip3 install \ - meson==0.56.0 - -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "mips-linux-gnu" ENV MESON_OPTS "--cross-file=mips-linux-gnu" diff --git a/ci/containers/debian-10-cross-mips64el.Dockerfile b/ci/containers/debian-10-cross-mips64el.Dockerfile index 896a730ebe..d988d82fbf 100644 --- a/ci/containers/debian-10-cross-mips64el.Dockerfile +++ b/ci/containers/debian-10-cross-mips64el.Dockerfile @@ -56,6 +56,15 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ dpkg-reconfigure locales +RUN pip3 install \ + meson==0.56.0 + +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN export DEBIAN_FRONTEND=noninteractive && \ dpkg --add-architecture mips64el && \ eatmydata apt-get update && \ @@ -116,14 +125,5 @@ endian = 'little'" > /usr/local/share/meson/cross/mips64el-linux-gnuabi64 && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/mips64el-linux-gnuabi64-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/mips64el-linux-gnuabi64-gcc -RUN pip3 install \ - meson==0.56.0 - -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "mips64el-linux-gnuabi64" ENV MESON_OPTS "--cross-file=mips64el-linux-gnuabi64" diff --git a/ci/containers/debian-10-cross-mipsel.Dockerfile b/ci/containers/debian-10-cross-mipsel.Dockerfile index d50c2bcc8a..455edcae3c 100644 --- a/ci/containers/debian-10-cross-mipsel.Dockerfile +++ b/ci/containers/debian-10-cross-mipsel.Dockerfile @@ -56,6 +56,15 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ dpkg-reconfigure locales +RUN pip3 install \ + meson==0.56.0 + +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN export DEBIAN_FRONTEND=noninteractive && \ dpkg --add-architecture mipsel && \ eatmydata apt-get update && \ @@ -116,14 +125,5 @@ endian = 'little'" > /usr/local/share/meson/cross/mipsel-linux-gnu && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/mipsel-linux-gnu-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/mipsel-linux-gnu-gcc -RUN pip3 install \ - meson==0.56.0 - -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "mipsel-linux-gnu" ENV MESON_OPTS "--cross-file=mipsel-linux-gnu" diff --git a/ci/containers/debian-10-cross-ppc64le.Dockerfile b/ci/containers/debian-10-cross-ppc64le.Dockerfile index 8cbea4bee8..ad380052c9 100644 --- a/ci/containers/debian-10-cross-ppc64le.Dockerfile +++ b/ci/containers/debian-10-cross-ppc64le.Dockerfile @@ -56,6 +56,15 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ dpkg-reconfigure locales +RUN pip3 install \ + meson==0.56.0 + +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN export DEBIAN_FRONTEND=noninteractive && \ dpkg --add-architecture ppc64el && \ eatmydata apt-get update && \ @@ -116,14 +125,5 @@ endian = 'little'" > /usr/local/share/meson/cross/powerpc64le-linux-gnu && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/powerpc64le-linux-gnu-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/powerpc64le-linux-gnu-gcc -RUN pip3 install \ - meson==0.56.0 - -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "powerpc64le-linux-gnu" ENV MESON_OPTS "--cross-file=powerpc64le-linux-gnu" diff --git a/ci/containers/debian-10-cross-s390x.Dockerfile b/ci/containers/debian-10-cross-s390x.Dockerfile index 3ad9a772c8..faeb450569 100644 --- a/ci/containers/debian-10-cross-s390x.Dockerfile +++ b/ci/containers/debian-10-cross-s390x.Dockerfile @@ -56,6 +56,15 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ dpkg-reconfigure locales +RUN pip3 install \ + meson==0.56.0 + +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN export DEBIAN_FRONTEND=noninteractive && \ dpkg --add-architecture s390x && \ eatmydata apt-get update && \ @@ -116,14 +125,5 @@ endian = 'big'" > /usr/local/share/meson/cross/s390x-linux-gnu && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/s390x-linux-gnu-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/s390x-linux-gnu-gcc -RUN pip3 install \ - meson==0.56.0 - -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "s390x-linux-gnu" ENV MESON_OPTS "--cross-file=s390x-linux-gnu" diff --git a/ci/containers/debian-11-cross-aarch64.Dockerfile b/ci/containers/debian-11-cross-aarch64.Dockerfile index a8b5ff293c..1d6ca0dd76 100644 --- a/ci/containers/debian-11-cross-aarch64.Dockerfile +++ b/ci/containers/debian-11-cross-aarch64.Dockerfile @@ -55,6 +55,12 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ dpkg-reconfigure locales +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN export DEBIAN_FRONTEND=noninteractive && \ dpkg --add-architecture arm64 && \ eatmydata apt-get update && \ @@ -116,11 +122,5 @@ endian = 'little'" > /usr/local/share/meson/cross/aarch64-linux-gnu && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/aarch64-linux-gnu-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/aarch64-linux-gnu-gcc -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "aarch64-linux-gnu" ENV MESON_OPTS "--cross-file=aarch64-linux-gnu" diff --git a/ci/containers/debian-11-cross-armv6l.Dockerfile b/ci/containers/debian-11-cross-armv6l.Dockerfile index 53c6759085..6ad97f9034 100644 --- a/ci/containers/debian-11-cross-armv6l.Dockerfile +++ b/ci/containers/debian-11-cross-armv6l.Dockerfile @@ -55,6 +55,12 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ dpkg-reconfigure locales +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN export DEBIAN_FRONTEND=noninteractive && \ dpkg --add-architecture armel && \ eatmydata apt-get update && \ @@ -115,11 +121,5 @@ endian = 'little'" > /usr/local/share/meson/cross/arm-linux-gnueabi && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/arm-linux-gnueabi-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/arm-linux-gnueabi-gcc -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "arm-linux-gnueabi" ENV MESON_OPTS "--cross-file=arm-linux-gnueabi" diff --git a/ci/containers/debian-11-cross-armv7l.Dockerfile b/ci/containers/debian-11-cross-armv7l.Dockerfile index 4d41db399f..28bcf1b655 100644 --- a/ci/containers/debian-11-cross-armv7l.Dockerfile +++ b/ci/containers/debian-11-cross-armv7l.Dockerfile @@ -55,6 +55,12 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ dpkg-reconfigure locales +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN export DEBIAN_FRONTEND=noninteractive && \ dpkg --add-architecture armhf && \ eatmydata apt-get update && \ @@ -116,11 +122,5 @@ endian = 'little'" > /usr/local/share/meson/cross/arm-linux-gnueabihf && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/arm-linux-gnueabihf-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/arm-linux-gnueabihf-gcc -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "arm-linux-gnueabihf" ENV MESON_OPTS "--cross-file=arm-linux-gnueabihf" diff --git a/ci/containers/debian-11-cross-i686.Dockerfile b/ci/containers/debian-11-cross-i686.Dockerfile index 0693c03e48..f7be68ed45 100644 --- a/ci/containers/debian-11-cross-i686.Dockerfile +++ b/ci/containers/debian-11-cross-i686.Dockerfile @@ -55,6 +55,12 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ dpkg-reconfigure locales +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN export DEBIAN_FRONTEND=noninteractive && \ dpkg --add-architecture i386 && \ eatmydata apt-get update && \ @@ -115,11 +121,5 @@ endian = 'little'" > /usr/local/share/meson/cross/i686-linux-gnu && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/i686-linux-gnu-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/i686-linux-gnu-gcc -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "i686-linux-gnu" ENV MESON_OPTS "--cross-file=i686-linux-gnu" diff --git a/ci/containers/debian-11-cross-mips64el.Dockerfile b/ci/containers/debian-11-cross-mips64el.Dockerfile index 0c2e4b6cc7..3e98e52874 100644 --- a/ci/containers/debian-11-cross-mips64el.Dockerfile +++ b/ci/containers/debian-11-cross-mips64el.Dockerfile @@ -55,6 +55,12 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ dpkg-reconfigure locales +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN export DEBIAN_FRONTEND=noninteractive && \ dpkg --add-architecture mips64el && \ eatmydata apt-get update && \ @@ -115,11 +121,5 @@ endian = 'little'" > /usr/local/share/meson/cross/mips64el-linux-gnuabi64 && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/mips64el-linux-gnuabi64-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/mips64el-linux-gnuabi64-gcc -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "mips64el-linux-gnuabi64" ENV MESON_OPTS "--cross-file=mips64el-linux-gnuabi64" diff --git a/ci/containers/debian-11-cross-mipsel.Dockerfile b/ci/containers/debian-11-cross-mipsel.Dockerfile index 5a5c4c2a35..165612b747 100644 --- a/ci/containers/debian-11-cross-mipsel.Dockerfile +++ b/ci/containers/debian-11-cross-mipsel.Dockerfile @@ -55,6 +55,12 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ dpkg-reconfigure locales +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN export DEBIAN_FRONTEND=noninteractive && \ dpkg --add-architecture mipsel && \ eatmydata apt-get update && \ @@ -115,11 +121,5 @@ endian = 'little'" > /usr/local/share/meson/cross/mipsel-linux-gnu && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/mipsel-linux-gnu-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/mipsel-linux-gnu-gcc -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "mipsel-linux-gnu" ENV MESON_OPTS "--cross-file=mipsel-linux-gnu" diff --git a/ci/containers/debian-11-cross-ppc64le.Dockerfile b/ci/containers/debian-11-cross-ppc64le.Dockerfile index fdbe884a5c..d8706863c4 100644 --- a/ci/containers/debian-11-cross-ppc64le.Dockerfile +++ b/ci/containers/debian-11-cross-ppc64le.Dockerfile @@ -55,6 +55,12 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ dpkg-reconfigure locales +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN export DEBIAN_FRONTEND=noninteractive && \ dpkg --add-architecture ppc64el && \ eatmydata apt-get update && \ @@ -115,11 +121,5 @@ endian = 'little'" > /usr/local/share/meson/cross/powerpc64le-linux-gnu && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/powerpc64le-linux-gnu-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/powerpc64le-linux-gnu-gcc -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "powerpc64le-linux-gnu" ENV MESON_OPTS "--cross-file=powerpc64le-linux-gnu" diff --git a/ci/containers/debian-11-cross-s390x.Dockerfile b/ci/containers/debian-11-cross-s390x.Dockerfile index be4981d22f..4f699ee2b5 100644 --- a/ci/containers/debian-11-cross-s390x.Dockerfile +++ b/ci/containers/debian-11-cross-s390x.Dockerfile @@ -55,6 +55,12 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ dpkg-reconfigure locales +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN export DEBIAN_FRONTEND=noninteractive && \ dpkg --add-architecture s390x && \ eatmydata apt-get update && \ @@ -115,11 +121,5 @@ endian = 'big'" > /usr/local/share/meson/cross/s390x-linux-gnu && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/s390x-linux-gnu-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/s390x-linux-gnu-gcc -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "s390x-linux-gnu" ENV MESON_OPTS "--cross-file=s390x-linux-gnu" diff --git a/ci/containers/debian-sid-cross-aarch64.Dockerfile b/ci/containers/debian-sid-cross-aarch64.Dockerfile index 883a5fe526..eac0c95c88 100644 --- a/ci/containers/debian-sid-cross-aarch64.Dockerfile +++ b/ci/containers/debian-sid-cross-aarch64.Dockerfile @@ -55,6 +55,12 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ dpkg-reconfigure locales +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN export DEBIAN_FRONTEND=noninteractive && \ dpkg --add-architecture arm64 && \ eatmydata apt-get update && \ @@ -116,11 +122,5 @@ endian = 'little'" > /usr/local/share/meson/cross/aarch64-linux-gnu && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/aarch64-linux-gnu-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/aarch64-linux-gnu-gcc -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "aarch64-linux-gnu" ENV MESON_OPTS "--cross-file=aarch64-linux-gnu" diff --git a/ci/containers/debian-sid-cross-armv6l.Dockerfile b/ci/containers/debian-sid-cross-armv6l.Dockerfile index 418b5295b4..5b53d741dd 100644 --- a/ci/containers/debian-sid-cross-armv6l.Dockerfile +++ b/ci/containers/debian-sid-cross-armv6l.Dockerfile @@ -55,6 +55,12 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ dpkg-reconfigure locales +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN export DEBIAN_FRONTEND=noninteractive && \ dpkg --add-architecture armel && \ eatmydata apt-get update && \ @@ -115,11 +121,5 @@ endian = 'little'" > /usr/local/share/meson/cross/arm-linux-gnueabi && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/arm-linux-gnueabi-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/arm-linux-gnueabi-gcc -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "arm-linux-gnueabi" ENV MESON_OPTS "--cross-file=arm-linux-gnueabi" diff --git a/ci/containers/debian-sid-cross-armv7l.Dockerfile b/ci/containers/debian-sid-cross-armv7l.Dockerfile index 8116ee3475..2eae6f073b 100644 --- a/ci/containers/debian-sid-cross-armv7l.Dockerfile +++ b/ci/containers/debian-sid-cross-armv7l.Dockerfile @@ -55,6 +55,12 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ dpkg-reconfigure locales +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN export DEBIAN_FRONTEND=noninteractive && \ dpkg --add-architecture armhf && \ eatmydata apt-get update && \ @@ -116,11 +122,5 @@ endian = 'little'" > /usr/local/share/meson/cross/arm-linux-gnueabihf && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/arm-linux-gnueabihf-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/arm-linux-gnueabihf-gcc -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "arm-linux-gnueabihf" ENV MESON_OPTS "--cross-file=arm-linux-gnueabihf" diff --git a/ci/containers/debian-sid-cross-i686.Dockerfile b/ci/containers/debian-sid-cross-i686.Dockerfile index 63f770a366..3b9f6ba389 100644 --- a/ci/containers/debian-sid-cross-i686.Dockerfile +++ b/ci/containers/debian-sid-cross-i686.Dockerfile @@ -55,6 +55,12 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ dpkg-reconfigure locales +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN export DEBIAN_FRONTEND=noninteractive && \ dpkg --add-architecture i386 && \ eatmydata apt-get update && \ @@ -115,11 +121,5 @@ endian = 'little'" > /usr/local/share/meson/cross/i686-linux-gnu && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/i686-linux-gnu-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/i686-linux-gnu-gcc -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "i686-linux-gnu" ENV MESON_OPTS "--cross-file=i686-linux-gnu" diff --git a/ci/containers/debian-sid-cross-mips64el.Dockerfile b/ci/containers/debian-sid-cross-mips64el.Dockerfile index fb7b02ce88..0d90f002ae 100644 --- a/ci/containers/debian-sid-cross-mips64el.Dockerfile +++ b/ci/containers/debian-sid-cross-mips64el.Dockerfile @@ -55,6 +55,12 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ dpkg-reconfigure locales +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN export DEBIAN_FRONTEND=noninteractive && \ dpkg --add-architecture mips64el && \ eatmydata apt-get update && \ @@ -115,11 +121,5 @@ endian = 'little'" > /usr/local/share/meson/cross/mips64el-linux-gnuabi64 && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/mips64el-linux-gnuabi64-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/mips64el-linux-gnuabi64-gcc -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "mips64el-linux-gnuabi64" ENV MESON_OPTS "--cross-file=mips64el-linux-gnuabi64" diff --git a/ci/containers/debian-sid-cross-mipsel.Dockerfile b/ci/containers/debian-sid-cross-mipsel.Dockerfile index 6c2d871a08..e29ca9eee3 100644 --- a/ci/containers/debian-sid-cross-mipsel.Dockerfile +++ b/ci/containers/debian-sid-cross-mipsel.Dockerfile @@ -55,6 +55,12 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ dpkg-reconfigure locales +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN export DEBIAN_FRONTEND=noninteractive && \ dpkg --add-architecture mipsel && \ eatmydata apt-get update && \ @@ -115,11 +121,5 @@ endian = 'little'" > /usr/local/share/meson/cross/mipsel-linux-gnu && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/mipsel-linux-gnu-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/mipsel-linux-gnu-gcc -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "mipsel-linux-gnu" ENV MESON_OPTS "--cross-file=mipsel-linux-gnu" diff --git a/ci/containers/debian-sid-cross-ppc64le.Dockerfile b/ci/containers/debian-sid-cross-ppc64le.Dockerfile index abcf271072..5707c8a57d 100644 --- a/ci/containers/debian-sid-cross-ppc64le.Dockerfile +++ b/ci/containers/debian-sid-cross-ppc64le.Dockerfile @@ -55,6 +55,12 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ dpkg-reconfigure locales +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN export DEBIAN_FRONTEND=noninteractive && \ dpkg --add-architecture ppc64el && \ eatmydata apt-get update && \ @@ -115,11 +121,5 @@ endian = 'little'" > /usr/local/share/meson/cross/powerpc64le-linux-gnu && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/powerpc64le-linux-gnu-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/powerpc64le-linux-gnu-gcc -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "powerpc64le-linux-gnu" ENV MESON_OPTS "--cross-file=powerpc64le-linux-gnu" diff --git a/ci/containers/debian-sid-cross-s390x.Dockerfile b/ci/containers/debian-sid-cross-s390x.Dockerfile index 00a999a284..25aa6513cc 100644 --- a/ci/containers/debian-sid-cross-s390x.Dockerfile +++ b/ci/containers/debian-sid-cross-s390x.Dockerfile @@ -55,6 +55,12 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ dpkg-reconfigure locales +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN export DEBIAN_FRONTEND=noninteractive && \ dpkg --add-architecture s390x && \ eatmydata apt-get update && \ @@ -115,11 +121,5 @@ endian = 'big'" > /usr/local/share/meson/cross/s390x-linux-gnu && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/s390x-linux-gnu-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/s390x-linux-gnu-gcc -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "s390x-linux-gnu" ENV MESON_OPTS "--cross-file=s390x-linux-gnu" diff --git a/ci/containers/fedora-35-cross-mingw32.Dockerfile b/ci/containers/fedora-35-cross-mingw32.Dockerfile index 0a26a1f9bd..de514525c6 100644 --- a/ci/containers/fedora-35-cross-mingw32.Dockerfile +++ b/ci/containers/fedora-35-cross-mingw32.Dockerfile @@ -62,6 +62,12 @@ exec "$@"' > /usr/bin/nosync && \ nosync dnf autoremove -y && \ nosync dnf clean all -y +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN nosync dnf install -y \ mingw32-curl \ mingw32-dbus \ @@ -82,11 +88,5 @@ RUN nosync dnf install -y \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/i686-w64-mingw32-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/i686-w64-mingw32-gcc -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "i686-w64-mingw32" ENV MESON_OPTS "--cross-file=/usr/share/mingw/toolchain-mingw32.meson" diff --git a/ci/containers/fedora-35-cross-mingw64.Dockerfile b/ci/containers/fedora-35-cross-mingw64.Dockerfile index e2a3ba9d6d..34dd93ccd9 100644 --- a/ci/containers/fedora-35-cross-mingw64.Dockerfile +++ b/ci/containers/fedora-35-cross-mingw64.Dockerfile @@ -62,6 +62,12 @@ exec "$@"' > /usr/bin/nosync && \ nosync dnf autoremove -y && \ nosync dnf clean all -y +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN nosync dnf install -y \ mingw64-curl \ mingw64-dbus \ @@ -82,11 +88,5 @@ RUN nosync dnf install -y \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/x86_64-w64-mingw32-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/x86_64-w64-mingw32-gcc -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "x86_64-w64-mingw32" ENV MESON_OPTS "--cross-file=/usr/share/mingw/toolchain-mingw64.meson" diff --git a/ci/containers/fedora-rawhide-cross-mingw32.Dockerfile b/ci/containers/fedora-rawhide-cross-mingw32.Dockerfile index 31006b8092..f8eb7abe7e 100644 --- a/ci/containers/fedora-rawhide-cross-mingw32.Dockerfile +++ b/ci/containers/fedora-rawhide-cross-mingw32.Dockerfile @@ -63,6 +63,12 @@ exec "$@"' > /usr/bin/nosync && \ nosync dnf autoremove -y && \ nosync dnf clean all -y +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN nosync dnf install -y \ mingw32-curl \ mingw32-dbus \ @@ -83,11 +89,5 @@ RUN nosync dnf install -y \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/i686-w64-mingw32-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/i686-w64-mingw32-gcc -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "i686-w64-mingw32" ENV MESON_OPTS "--cross-file=/usr/share/mingw/toolchain-mingw32.meson" diff --git a/ci/containers/fedora-rawhide-cross-mingw64.Dockerfile b/ci/containers/fedora-rawhide-cross-mingw64.Dockerfile index c9b01984b5..feec913384 100644 --- a/ci/containers/fedora-rawhide-cross-mingw64.Dockerfile +++ b/ci/containers/fedora-rawhide-cross-mingw64.Dockerfile @@ -63,6 +63,12 @@ exec "$@"' > /usr/bin/nosync && \ nosync dnf autoremove -y && \ nosync dnf clean all -y +ENV LANG "en_US.UTF-8" +ENV MAKE "/usr/bin/make" +ENV NINJA "/usr/bin/ninja" +ENV PYTHON "/usr/bin/python3" +ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" + RUN nosync dnf install -y \ mingw64-curl \ mingw64-dbus \ @@ -83,11 +89,5 @@ RUN nosync dnf install -y \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/x86_64-w64-mingw32-cc && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/x86_64-w64-mingw32-gcc -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" - ENV ABI "x86_64-w64-mingw32" ENV MESON_OPTS "--cross-file=/usr/share/mingw/toolchain-mingw64.meson" diff --git a/ci/containers/fedora-rawhide.Dockerfile b/ci/containers/fedora-rawhide.Dockerfile index 97476535b9..ff18e89e66 100644 --- a/ci/containers/fedora-rawhide.Dockerfile +++ b/ci/containers/fedora-rawhide.Dockerfile @@ -72,7 +72,6 @@ exec "$@"' > /usr/bin/nosync && \ lvm2 \ make \ meson \ - netcf-devel \ nfs-utils \ ninja-build \ numactl-devel \ -- 2.31.1

1 0

[PATCH RFC v2 0/4] blockdev-replace
by Vladimir Sementsov-Ogievskiy 22 Dec '21

22 Dec '21

Hi all! v2: 1. Let's start with minimal functionality: replace only one specific child. 2. Explicit type of parent: qdev / export / driver Hmm, 'driver' is for BlockDriverState.. Any better idea? I don't want to call it "node" or even "block-node", as finally, devices and exports are kind of nodes too in the whole block graph.. 3. I think it's better to start with x- prefix Plans for v3: - add tests of filter insertion and removing - add qmp transaction support Vladimir Sementsov-Ogievskiy (4): block-backend: blk_root(): drop const specifier on return type block/export: add blk_by_export_id() block: make bdrv_find_child() function public qapi: add blockdev-replace command qapi/block.json | 61 ++++++++++++++++++++++++++++++++++ include/block/block_int.h | 1 + include/sysemu/block-backend.h | 3 +- block.c | 13 ++++++++ block/block-backend.c | 2 +- block/export/export.c | 18 ++++++++++ block/qapi-sysemu.c | 56 +++++++++++++++++++++++++++++++ blockdev.c | 14 -------- 8 files changed, 152 insertions(+), 16 deletions(-) -- 2.31.1

1 4

[libvirt PATCH v2] qemu: Fix typo in comment
by Tim Wiederhake 22 Dec '21

22 Dec '21

Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com> --- src/qemu/qemu_monitor_json.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index a3d6eca569..8870b5f8ee 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -8217,7 +8217,7 @@ qemuMonitorJSONGetSEVMeasurement(qemuMonitor *mon) /** - * Retrive info about the SEV setup, returning those fields that + * Retrieve info about the SEV setup, returning those fields that * are required to do a launch attestation, as per * * HMAC(0x04 || API_MAJOR || API_MINOR || BUILD || GCTX.POLICY || GCTX.LD || MNONCE; GCTX.TIK) -- 2.31.1

3 2

[PATCH 0/6] json helper cleanups
by Peter Krempa 22 Dec '21

22 Dec '21

Peter Krempa (6): qemuBlockStorageSourceGetRBDProps: Simplify generation of auth modes Replace open coded virJSONValueArrayAppendString util: json: Don't copy string in virJSONValueNewString util: json: Open-code only call of virJSONValueNewStringLen util: json: Remove virJSONValueIsNull/virJSONValueObjectIsNull util: virjson.h: Reformat headers to conform with new style src/libvirt_private.syms | 3 - src/qemu/qemu_agent.c | 4 +- src/qemu/qemu_block.c | 10 +- src/util/virjson.c | 57 +------ src/util/virjson.h | 315 +++++++++++++++++++++++++++------------ src/util/virmacmap.c | 4 +- tests/virjsontest.c | 4 +- 7 files changed, 231 insertions(+), 166 deletions(-) -- 2.31.1

3 8

[PATCH] docs: Remove dependency on external resources
by Andrea Bolognani 21 Dec '21

21 Dec '21

The internals/eventloop document uses two images for illustrative purposes, but unlike other graphics included in the documentation these are not part of libvirt.git but rather were added to libvirt-media.git with commit fae5622074cf5e18d190496f8a43260c614599b2 Author: Michal Privoznik <mprivozn(a)redhat.com> Date: Mon Jun 6 17:27:50 2016 +0200 Add two event loop images These images are going to be used in our documentation of the event loop. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> https://gitlab.com/libvirt/libvirt-media/-/commit/fae5622074cf5e18d190496f8… and are requested directly from there. Specifically, the URLs point to the libvirt.org mirror of libvirt-media.git instead of the primary repository hosted on GitLab. Import the images into libvirt.git so that the website doesn't rely on external resources and can, if desired, be browsed entirely offline from installed packages. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Redacted to strip binary and binary-adjacent blobs. Full patch: https://gitlab.com/abologna/libvirt/-/commit/684805e3cf65ab3bb93a92ada3b720… docs/event_loop_simple.png | Bin 0 -> 16043 bytes docs/event_loop_simple.svg | 398 +++++++++++++++++ docs/event_loop_worker.png | Bin 0 -> 29696 bytes docs/event_loop_worker.svg | 708 +++++++++++++++++++++++++++++++ docs/internals/eventloop.html.in | 4 +- docs/meson.build | 2 + 6 files changed, 1110 insertions(+), 2 deletions(-) create mode 100644 docs/event_loop_simple.png create mode 100644 docs/event_loop_simple.svg create mode 100644 docs/event_loop_worker.png create mode 100644 docs/event_loop_worker.svg diff --git a/docs/event_loop_simple.png b/docs/event_loop_simple.png new file mode 100644 index 0000000000000000000000000000000000000000..daf4338a16bc1051aca0ca1c7ea13baa4e7179f1 [... PNG stuff here ...] diff --git a/docs/event_loop_simple.svg b/docs/event_loop_simple.svg new file mode 100644 index 0000000000..be25005002 [... SVG stuff here ...] diff --git a/docs/event_loop_worker.png b/docs/event_loop_worker.png new file mode 100644 index 0000000000000000000000000000000000000000..1bec1ea598b2806fea24ab25dc825c9055c76ee6 [... PNG stuff here ...] diff --git a/docs/event_loop_worker.svg b/docs/event_loop_worker.svg new file mode 100644 index 0000000000..d824e2d585 [... SVG stuff here ...] diff --git a/docs/internals/eventloop.html.in b/docs/internals/eventloop.html.in index 3e62d5ca53..aa22ba15cd 100644 --- a/docs/internals/eventloop.html.in +++ b/docs/internals/eventloop.html.in @@ -29,7 +29,7 @@ not waiting for direct user input and have no graphical interface. Such as Libvirt.</p> - <img alt="event loop" src="https://libvirt.org/git/?p=libvirt-media.git;a=blob_plain;f=png/event_loop_…"/> + <img alt="event loop" src="../event_loop_simple.png"/> <p>In Libvirt this approach is used in combination with <code>poll(2)</code> as all the communication with its @@ -70,7 +70,7 @@ acceptable for Libvirt. Therefore we have came up with the following solution.</p> - <img alt="event loop" src="https://libvirt.org/git/?p=libvirt-media.git;a=blob_plain;f=png/event_loop_…"/> + <img alt="event loop" src="../event_loop_worker.png"/> <p>The event loop does only necessary minimum and hand over message processing to another thread. In fact, there can be diff --git a/docs/meson.build b/docs/meson.build index 3aabb52950..3e708acf0e 100644 --- a/docs/meson.build +++ b/docs/meson.build @@ -10,6 +10,8 @@ docs_assets = [ 'android-chrome-256x256.png', 'apple-touch-icon.png', 'browserconfig.xml', + 'event_loop_simple.png', + 'event_loop_worker.png', 'favicon.ico', 'favicon-16x16.png', 'favicon-32x32.png', -- 2.31.1

3 8

[libvirt PATCH 0/2] docs: Move all images to a subdirectory
by Andrea Bolognani 21 Dec '21

21 Dec '21

Andrea Bolognani (2): docs: Drop structures.svg docs: Move all images to a subdirectory docs/api.rst | 6 +- docs/goals.html.in | 2 +- docs/{ => images}/event_loop_simple.png | Bin docs/{ => images}/event_loop_simple.svg | 0 docs/{ => images}/event_loop_worker.png | Bin docs/{ => images}/event_loop_worker.svg | 0 docs/{ => images}/libvirt-daemon-arch.png | Bin docs/{ => images}/libvirt-daemon-arch.svg | 0 docs/{ => images}/libvirt-driver-arch.png | Bin docs/{ => images}/libvirt-driver-arch.svg | 0 docs/{ => images}/libvirt-object-model.png | Bin docs/{ => images}/libvirt-object-model.svg | 0 .../libvirt-virConnect-example.png | Bin .../libvirt-virConnect-example.svg | 0 docs/images/meson.build | 24 +++ .../{ => images}/migration-managed-direct.png | Bin .../{ => images}/migration-managed-direct.svg | 0 docs/{ => images}/migration-managed-p2p.png | Bin docs/{ => images}/migration-managed-p2p.svg | 0 docs/{ => images}/migration-native.png | Bin docs/{ => images}/migration-native.svg | 0 docs/{ => images}/migration-tunnel.png | Bin docs/{ => images}/migration-tunnel.svg | 0 .../migration-unmanaged-direct.png | Bin .../migration-unmanaged-direct.svg | 0 docs/{ => images}/node.gif | Bin docs/{ => images}/node.svg | 0 docs/internals.html.in | 2 +- docs/internals/eventloop.html.in | 4 +- docs/meson.build | 13 +- docs/migration.rst | 10 +- docs/structures.svg | 187 ------------------ 32 files changed, 37 insertions(+), 211 deletions(-) rename docs/{ => images}/event_loop_simple.png (100%) rename docs/{ => images}/event_loop_simple.svg (100%) rename docs/{ => images}/event_loop_worker.png (100%) rename docs/{ => images}/event_loop_worker.svg (100%) rename docs/{ => images}/libvirt-daemon-arch.png (100%) rename docs/{ => images}/libvirt-daemon-arch.svg (100%) rename docs/{ => images}/libvirt-driver-arch.png (100%) rename docs/{ => images}/libvirt-driver-arch.svg (100%) rename docs/{ => images}/libvirt-object-model.png (100%) rename docs/{ => images}/libvirt-object-model.svg (100%) rename docs/{ => images}/libvirt-virConnect-example.png (100%) rename docs/{ => images}/libvirt-virConnect-example.svg (100%) create mode 100644 docs/images/meson.build rename docs/{ => images}/migration-managed-direct.png (100%) rename docs/{ => images}/migration-managed-direct.svg (100%) rename docs/{ => images}/migration-managed-p2p.png (100%) rename docs/{ => images}/migration-managed-p2p.svg (100%) rename docs/{ => images}/migration-native.png (100%) rename docs/{ => images}/migration-native.svg (100%) rename docs/{ => images}/migration-tunnel.png (100%) rename docs/{ => images}/migration-tunnel.svg (100%) rename docs/{ => images}/migration-unmanaged-direct.png (100%) rename docs/{ => images}/migration-unmanaged-direct.svg (100%) rename docs/{ => images}/node.gif (100%) rename docs/{ => images}/node.svg (100%) delete mode 100644 docs/structures.svg -- 2.31.1

2 4

[PATCH 0/7] qemu: Add support for qcow2's 'extended-l2' feature
by Peter Krempa 21 Dec '21

21 Dec '21

Peter Krempa (7): docs: formatstorage: Convert to RST storage: Introduce 'extended_l2' feature for storage volume qcow2GetFeatures: Extract population of features bitmap storage_file_probe: Add support for probing qcow2's incompatible features qemuBlockStorageSourceCreateGetFormatPropsQcow2: Add support for 'extended-l2' feature qemu: monitor: Extract whether qcow2 image uses extended L2 allocation data qemuBlockStorageSourceCreateDetectSize: Propagate 'extended_l2' feature to new overlays docs/formatstorage.html.in | 1000 ----------------- docs/formatstorage.rst | 827 ++++++++++++++ docs/meson.build | 2 +- docs/schemas/storagecommon.rng | 5 + src/conf/storage_source_conf.c | 1 + src/conf/storage_source_conf.h | 1 + src/qemu/qemu_block.c | 20 +- src/qemu/qemu_monitor.h | 3 + src/qemu/qemu_monitor_json.c | 10 +- src/storage/storage_util.c | 11 + src/storage_file/storage_file_probe.c | 61 +- .../qcow2-clusterSize.argv | 2 +- .../vol-qcow2-clusterSize.xml | 3 + .../vol-qcow2-clusterSize.xml | 4 + 14 files changed, 929 insertions(+), 1021 deletions(-) delete mode 100644 docs/formatstorage.html.in create mode 100644 docs/formatstorage.rst -- 2.31.1

2 15

[PATCH V3 0/4] Add virDomainSetLaunchSecurityState API
by Jim Fehlig 21 Dec '21

21 Dec '21

V3 of https://listman.redhat.com/archives/libvir-list/2021-December/msg00366.html Like V1 and V2, this series is compile-tested only. I plan to work on functional testing soon. Unlike previous versions, this one got little self-scrutiny since I wanted to get it posted to the list for feedback on questions regarding 4/4. Changes since V2: - Add test case in qemumonitorjsontest - Add virsh implementation Jim Fehlig (4): libvirt: Introduce virDomainSetLaunchSecurityState public API remote: Add RPC support for the virDomainSetLaunchSecurityState API qemu: Implement the virDomainSetLaunchSecurityState API tools: Add domsetlaunchsecstate virsh command docs/manpages/virsh.rst | 25 ++++++++ include/libvirt/libvirt-domain.h | 36 +++++++++++ src/driver-hypervisor.h | 7 ++ src/libvirt-domain.c | 62 ++++++++++++++++++ src/libvirt_public.syms | 5 ++ src/qemu/qemu_driver.c | 88 +++++++++++++++++++++++++ src/qemu/qemu_monitor.c | 14 ++++ src/qemu/qemu_monitor.h | 7 ++ src/qemu/qemu_monitor_json.c | 45 +++++++++++++ src/qemu/qemu_monitor_json.h | 6 ++ src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 17 ++++- src/remote_protocol-structs | 9 +++ tests/qemumonitorjsontest.c | 3 + tools/virsh-domain.c | 107 +++++++++++++++++++++++++++++++ 15 files changed, 431 insertions(+), 1 deletion(-) -- 2.34.1

3 10

[PATCH v2 00/12] Add riscv kvm accel support
by Yifei Jiang 20 Dec '21

20 Dec '21

This series adds both riscv32 and riscv64 kvm support, and implements migration based on riscv. Because of RISC-V KVM has been merged into the Linux master, so this series are changed from RFC to patch. Several steps to use this: 1. Build emulation $ ./configure --target-list=riscv64-softmmu $ make -j$(nproc) 2. Build kernel 3. Build QEMU VM Cross built in riscv toolchain. $ PKG_CONFIG_LIBDIR=<toolchain pkgconfig path> $ export PKG_CONFIG_SYSROOT_DIR=<toolchain sysroot path> $ ./configure --target-list=riscv64-softmmu --enable-kvm \ --cross-prefix=riscv64-linux-gnu- --disable-libiscsi --disable-glusterfs \ --disable-libusb --disable-usb-redir --audio-drv-list= --disable-opengl \ --disable-libxml2 $ make -j$(nproc) 4. Start emulation $ ./qemu-system-riscv64 -M virt -m 4096M -cpu rv64,x-h=true -nographic \ -name guest=riscv-hyp,debug-threads=on \ -smp 4 \ -bios ./fw_jump.bin \ -kernel ./Image \ -drive file=./hyp.img,format=raw,id=hd0 \ -device virtio-blk-device,drive=hd0 \ -append "root=/dev/vda rw console=ttyS0 earlycon=sbi" 5. Start kvm-acceled QEMU VM in emulation $ ./qemu-system-riscv64 -M virt,accel=kvm -m 1024M -cpu host -nographic \ -name guest=riscv-guset \ -smp 2 \ -bios none \ -kernel ./Image \ -drive file=./guest.img,format=raw,id=hd0 \ -device virtio-blk-device,drive=hd0 \ -append "root=/dev/vda rw console=ttyS0 earlycon=sbi" Changes since patch v1 - Rebase on recent commit a216e7cf119c91ffdf5931834a1a030ebea40d70 - Sync-up headers with Linux-5.16-rc4. - Fixbug in kvm_arch_init_vcpu. - Create a macro for get and put regs csr. - Start kernel directly when kvm_enabled. - Use riscv_cpu_set_irq to inject KVM interrupts. - Use the Semihosting Console API for RISC-V kvm handle sbi. - Update vmstate_riscv_cpu version id. Placing kvm_timer into a subsection. Changes since RFC v6 - Rebase on recent commit 8627edfb3f1fca24a96a0954148885c3241c10f8 - Sync-up headers with Linux-5.16-rc1 Changes since RFC v5 - Rebase on QEMU v6.1.0-rc1 and kvm-riscv linux v19. - Move kvm interrupt setting to riscv_cpu_update_mip(). - Replace __u64 with uint64_t. Changes since RFC v4 - Rebase on QEMU v6.0.0-rc2 and kvm-riscv linux v17. - Remove time scaling support as software solution is incomplete. Because it will cause unacceptable performance degradation. and We will post a better solution. - Revise according to Alistair's review comments. - Remove compile time XLEN checks in kvm_riscv_reg_id - Surround TYPE_RISCV_CPU_HOST definition by CONFIG_KVM and share it between RV32 and RV64. - Add kvm-stub.c for reduce unnecessary compilation checks. - Add riscv_setup_direct_kernel() to direct boot kernel for KVM. Changes since RFC v3 - Rebase on QEMU v5.2.0-rc2 and kvm-riscv linux v15. - Add time scaling support(New patches 13, 14 and 15). - Fix the bug that guest vm can't reboot. Changes since RFC v2 - Fix checkpatch error at target/riscv/sbi_ecall_interface.h. - Add riscv migration support. Changes since RFC v1 - Add separate SBI ecall interface header. - Add riscv32 kvm accel support. Yifei Jiang (12): update-linux-headers: Add asm-riscv/kvm.h target/riscv: Add target/riscv/kvm.c to place the public kvm interface target/riscv: Implement function kvm_arch_init_vcpu target/riscv: Implement kvm_arch_get_registers target/riscv: Implement kvm_arch_put_registers target/riscv: Support start kernel directly by KVM target/riscv: Support setting external interrupt by KVM target/riscv: Handle KVM_EXIT_RISCV_SBI exit target/riscv: Add host cpu type target/riscv: Add kvm_riscv_get/put_regs_timer target/riscv: Implement virtual time adjusting with vm state changing target/riscv: Support virtual time context synchronization hw/riscv/boot.c | 11 + hw/riscv/virt.c | 54 ++- include/hw/riscv/boot.h | 1 + linux-headers/asm-riscv/kvm.h | 128 +++++++ linux-headers/linux/kvm.h | 8 + meson.build | 2 + target/riscv/cpu.c | 29 +- target/riscv/cpu.h | 11 + target/riscv/kvm-stub.c | 30 ++ target/riscv/kvm.c | 528 +++++++++++++++++++++++++++++ target/riscv/kvm_riscv.h | 25 ++ target/riscv/machine.c | 37 +- target/riscv/meson.build | 1 + target/riscv/sbi_ecall_interface.h | 72 ++++ 14 files changed, 918 insertions(+), 19 deletions(-) create mode 100644 linux-headers/asm-riscv/kvm.h create mode 100644 target/riscv/kvm-stub.c create mode 100644 target/riscv/kvm.c create mode 100644 target/riscv/kvm_riscv.h create mode 100644 target/riscv/sbi_ecall_interface.h -- 2.19.1

4 27

[PATCH 0/7] Polkit tty agent fixes
by Martin Kletzander 17 Dec '21

17 Dec '21

Apart from fixing bz 1945501 [0] there are some small changes/fixes to some of the polkit code. [0] https://bugzilla.redhat.com/show_bug.cgi?id=1945501 Martin Kletzander (7): virsh: Remove needless variable util: Tiny reword fix in comment util: Add virPolkitAgentAvailable virsh: Do not try connecting first time without polkit agent util: Report errors in all code paths in virPolkitAgentCreate util: Check for pkttyagent availability properly util: Make client-side polkit work even with polkit disabled src/libvirt_private.syms | 1 + src/util/virpolkit.c | 202 ++++++++++++++++++++++----------------- src/util/virpolkit.h | 1 + tools/virsh.c | 14 ++- 4 files changed, 127 insertions(+), 91 deletions(-) -- 2.34.0

5 34

[PATCH] virt-host-validate: Fix IOMMU output on S390
by Boris Fiuczynski 17 Dec '21

17 Dec '21

Commit 93e9e92c1e eliminated the option for skipping but left code in the s390 check which makes use of a skip. This leads to an output without result destroying the correct format. e.g. QEMU: Checking for hardware virtualization : PASS QEMU: Checking if device /dev/kvm exists : PASS QEMU: Checking if device /dev/kvm is accessible : PASS QEMU: Checking if device /dev/vhost-net exists : PASS QEMU: Checking if device /dev/net/tun exists : PASS QEMU: Checking for cgroup 'cpu' controller support : PASS QEMU: Checking for cgroup 'cpuacct' controller support : PASS QEMU: Checking for cgroup 'cpuset' controller support : PASS QEMU: Checking for cgroup 'memory' controller support : PASS QEMU: Checking for cgroup 'devices' controller support : PASS QEMU: Checking for cgroup 'blkio' controller support : PASS QEMU: Checking for device assignment IOMMU support : QEMU: Checking for secure guest support : PASS Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com> --- tools/virt-host-validate-common.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/tools/virt-host-validate-common.c b/tools/virt-host-validate-common.c index 647ed7b48b..1cb9d206b5 100644 --- a/tools/virt-host-validate-common.c +++ b/tools/virt-host-validate-common.c @@ -378,11 +378,17 @@ int virHostValidateIOMMU(const char *hvname, * devices (which is quite usual on s390x). If there are * no PCI devices the directory is still there but is * empty. */ - if (!virDirOpen(&dir, "/sys/bus/pci/devices")) - return 0; + if (!virDirOpen(&dir, "/sys/bus/pci/devices")) { + virHostMsgFail(VIR_HOST_VALIDATE_NOTE, + "Skipped - PCI support disabled"); + return VIR_HOST_VALIDATE_FAILURE(VIR_HOST_VALIDATE_NOTE); + } rc = virDirRead(dir, &dent, NULL); - if (rc <= 0) - return 0; + if (rc <= 0) { + virHostMsgFail(VIR_HOST_VALIDATE_NOTE, + "Skipped - No PCI devices are online"); + return VIR_HOST_VALIDATE_FAILURE(VIR_HOST_VALIDATE_NOTE); + } virHostMsgPass(); } else { virHostMsgFail(level, -- 2.31.1

2 1

[PATCH v5 0/3] remove sysconfig files
by Olaf Hering 17 Dec '21

17 Dec '21

fix path to sysconfig file in NEWS.rst (jfehlig) rebased to 85574319952af2cf538d185bd58e4ed3edc7a3e8 Olaf Hering (3): libvirt.spec: relocate pre script of daemon-driver-qemu remove sysconfig files NEWS: mention removal of sysconfig NEWS.rst | 10 +++ docs/daemons.rst | 20 +++++ docs/remote.html.in | 6 +- libvirt.spec.in | 99 +++++++++++++++++-------- src/ch/meson.build | 5 -- src/ch/virtchd.service.in | 1 + src/ch/virtchd.sysconf | 3 - src/interface/meson.build | 5 -- src/interface/virtinterfaced.service.in | 1 + src/interface/virtinterfaced.sysconf | 3 - src/libxl/meson.build | 5 -- src/libxl/virtxend.service.in | 1 + src/libxl/virtxend.sysconf | 3 - src/locking/meson.build | 5 -- src/locking/virtlockd.service.in | 1 + src/locking/virtlockd.sysconf | 3 - src/logging/meson.build | 5 -- src/logging/virtlogd.sysconf | 3 - src/lxc/meson.build | 5 -- src/lxc/virtlxcd.service.in | 1 + src/lxc/virtlxcd.sysconf | 3 - src/meson.build | 16 ---- src/network/meson.build | 5 -- src/network/virtnetworkd.service.in | 1 + src/network/virtnetworkd.sysconf | 3 - src/node_device/meson.build | 5 -- src/node_device/virtnodedevd.service.in | 1 + src/node_device/virtnodedevd.sysconf | 3 - src/nwfilter/meson.build | 5 -- src/nwfilter/virtnwfilterd.service.in | 1 + src/nwfilter/virtnwfilterd.sysconf | 3 - src/qemu/meson.build | 5 -- src/qemu/virtqemud.service.in | 7 ++ src/qemu/virtqemud.sysconf | 12 --- src/remote/libvirtd.service.in | 7 ++ src/remote/libvirtd.sysconf | 21 ------ src/remote/meson.build | 10 --- src/remote/virtproxyd.service.in | 1 + src/remote/virtproxyd.sysconf | 3 - src/secret/meson.build | 5 -- src/secret/virtsecretd.service.in | 1 + src/secret/virtsecretd.sysconf | 3 - src/storage/meson.build | 5 -- src/storage/virtstoraged.service.in | 1 + src/storage/virtstoraged.sysconf | 3 - src/vbox/meson.build | 5 -- src/vbox/virtvboxd.service.in | 1 + src/vbox/virtvboxd.sysconf | 3 - src/vz/meson.build | 5 -- src/vz/virtvzd.service.in | 1 + src/vz/virtvzd.sysconf | 3 - tools/libvirt-guests.sh.in | 40 ++++++++++ tools/libvirt-guests.sysconf | 50 ------------- tools/meson.build | 6 -- 54 files changed, 167 insertions(+), 262 deletions(-) delete mode 100644 src/ch/virtchd.sysconf delete mode 100644 src/interface/virtinterfaced.sysconf delete mode 100644 src/libxl/virtxend.sysconf delete mode 100644 src/locking/virtlockd.sysconf delete mode 100644 src/logging/virtlogd.sysconf delete mode 100644 src/lxc/virtlxcd.sysconf delete mode 100644 src/network/virtnetworkd.sysconf delete mode 100644 src/node_device/virtnodedevd.sysconf delete mode 100644 src/nwfilter/virtnwfilterd.sysconf delete mode 100644 src/qemu/virtqemud.sysconf delete mode 100644 src/remote/libvirtd.sysconf delete mode 100644 src/remote/virtproxyd.sysconf delete mode 100644 src/secret/virtsecretd.sysconf delete mode 100644 src/storage/virtstoraged.sysconf delete mode 100644 src/vbox/virtvboxd.sysconf delete mode 100644 src/vz/virtvzd.sysconf delete mode 100644 tools/libvirt-guests.sysconf

3 6

[PATCH 0/4] vsh-table: Various small improvements
by Michal Privoznik 17 Dec '21

17 Dec '21

*** BLURB HERE *** Michal Prívozník (4): vshtabletest: Fix potential memleak vsh-table: Hide vshTableRow typedef vsh-table.h: Modernize declarations vsh-table: Ensure NULL terminated arguments to vshTable*() tests/vshtabletest.c | 6 ++++-- tools/vsh-table.c | 1 + tools/vsh-table.h | 22 ++++++++++++++++------ 3 files changed, 21 insertions(+), 8 deletions(-) -- 2.32.0

2 5

[PATCH v2 0/6] qemu: Explicitly forbid live changing nodeset for strict numatune
by Michal Privoznik 17 Dec '21

17 Dec '21

v2 of: https://listman.redhat.com/archives/libvir-list/2021-December/msg00708.html diff to v1: - Wrote documentation, per Pavel's request - Wrote a completer Michal Prívozník (6): manpages: Document 'restrictive' mode for numatune virsh-completer: Provide completer for numatune --mode qemu: Allow VIR_DOMAIN_NUMATUNE_MEM_RESTRICTIVE in qemuDomainSetNumaParamsLive() qemu: Explicitly forbid live changing nodeset for strict numatune qemu_command: do use host-nodes for system memory NEWS: Document recent numatune change NEWS.rst | 8 ++++ docs/formatdomain.rst | 3 ++ docs/manpages/virsh.rst | 10 ++--- src/libvirt-domain.c | 7 ++++ src/qemu/qemu_command.c | 3 +- src/qemu/qemu_driver.c | 37 +++++++++++++------ .../numatune-system-memory.x86_64-latest.args | 2 +- tools/virsh-completer-domain.c | 20 ++++++++++ tools/virsh-completer-domain.h | 5 +++ tools/virsh-domain.c | 1 + 10 files changed, 76 insertions(+), 20 deletions(-) -- 2.32.0

4 10

[PATCH] qemucapabilitiesdata: Fix command name in caps_3.0.0.ppc64.replies
by Michal Privoznik 17 Dec '21

17 Dec '21

Under the qemucapabilitiesdata we have a replies file for QEMU-3.0.0.ppc64. At least we think so. In fact, the file contains replies from a development snapshot release that predates 3.0.0 (specifically it's v2.12.0-1689-g518d23a) and as such does not reflect any change that was made to QEMU after the snapshot and before the official relase. One of such changes was renaming 'exit-preconfig' command to 'x-exit-preconfig' (QEMU commit v3.0.0-rc1~21^2~3). Ideally, we would just regenerate capabilities using the official release but since this is a PPC64 machine and pretty old version anyway let's just fix the command name. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tests/qemucapabilitiesdata/caps_3.0.0.ppc64.replies | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemucapabilitiesdata/caps_3.0.0.ppc64.replies b/tests/qemucapabilitiesdata/caps_3.0.0.ppc64.replies index 3df67b71de..c12ee7814e 100644 --- a/tests/qemucapabilitiesdata/caps_3.0.0.ppc64.replies +++ b/tests/qemucapabilitiesdata/caps_3.0.0.ppc64.replies @@ -1296,7 +1296,7 @@ "arg-type": "0" }, { - "name": "exit-preconfig", + "name": "x-exit-preconfig", "ret-type": "0", "allow-oob": false, "allow-preconfig": true, @@ -12327,7 +12327,7 @@ "name": "system_wakeup" }, { - "name": "exit-preconfig" + "name": "x-exit-preconfig" }, { "name": "cont" -- 2.32.0

2 1

[PATCH] qemuGetSEVInfoToParams: Reformat to standard coding style
by Peter Krempa 16 Dec '21

16 Dec '21

The function was formatted weirdly which prompted additions to conform to the unusual style. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_driver.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index bae8b7c39b..372e1360b5 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -19901,30 +19901,30 @@ qemuGetSEVInfoToParams(virQEMUCaps *qemuCaps, virCheckFlags(VIR_TYPED_PARAM_STRING_OKAY, -1); if (virTypedParamsAddString(&sevParams, &n, &maxpar, - VIR_NODE_SEV_PDH, sev->pdh) < 0) + VIR_NODE_SEV_PDH, sev->pdh) < 0) return -1; if (virTypedParamsAddString(&sevParams, &n, &maxpar, - VIR_NODE_SEV_CERT_CHAIN, sev->cert_chain) < 0) + VIR_NODE_SEV_CERT_CHAIN, sev->cert_chain) < 0) goto cleanup; if (virTypedParamsAddUInt(&sevParams, &n, &maxpar, - VIR_NODE_SEV_CBITPOS, sev->cbitpos) < 0) + VIR_NODE_SEV_CBITPOS, sev->cbitpos) < 0) goto cleanup; if (virTypedParamsAddUInt(&sevParams, &n, &maxpar, - VIR_NODE_SEV_REDUCED_PHYS_BITS, - sev->reduced_phys_bits) < 0) + VIR_NODE_SEV_REDUCED_PHYS_BITS, + sev->reduced_phys_bits) < 0) goto cleanup; if (virTypedParamsAddUInt(&sevParams, &n, &maxpar, - VIR_NODE_SEV_MAX_GUESTS, - sev->max_guests) < 0) + VIR_NODE_SEV_MAX_GUESTS, + sev->max_guests) < 0) goto cleanup; if (virTypedParamsAddUInt(&sevParams, &n, &maxpar, - VIR_NODE_SEV_MAX_ES_GUESTS, - sev->max_es_guests) < 0) + VIR_NODE_SEV_MAX_ES_GUESTS, + sev->max_es_guests) < 0) goto cleanup; *params = g_steal_pointer(&sevParams); -- 2.31.1

2 1

[PATCH 0/3] qemu: Explicitly forbid changing nodeset for strict numatune
by Michal Privoznik 16 Dec '21

16 Dec '21

See 2/3 for explanation. Michal Prívozník (3): qemu: Allow VIR_DOMAIN_NUMATUNE_MEM_RESTRICTIVE in qemuDomainSetNumaParamsLive() qemu: Explicitly forbid changing nodeset for strict numatune qemu_command: do use host-nodes for system memory src/qemu/qemu_command.c | 3 +- src/qemu/qemu_driver.c | 37 +++++++++++++------ .../numatune-system-memory.x86_64-latest.args | 2 +- 3 files changed, 27 insertions(+), 15 deletions(-) -- 2.32.0

3 5

[PATCH 0/2] conf: Don't crash when one of disks is missing
by Peter Krempa 16 Dec '21

16 Dec '21

Peter Krempa (2): virDomainDiskInsert: Don't access NULL disk target qemuxml2argvtest: disk-missing-target: Add two disks with same bus src/conf/domain_conf.c | 1 + tests/qemuxml2argvdata/disk-missing-target-invalid.xml | 3 +++ 2 files changed, 4 insertions(+) -- 2.31.1

2 3

[libvirt PATCH] qemu: validate VNC password length
by Daniel P. Berrangé 16 Dec '21

16 Dec '21

The VNC password authentication scheme is quite horrendous in that it takes the user password and directly uses it as a DES case. DES is a byte 8 keyed cipher, so the VNC password can never be more than 8 characters long. Anything over that length will be silently dropped. We should validate this length restriction when accepting user XML configs and report an error. For the global VNC password we don't really want to break daemon startup by reporting an error, but logging a warning is worthwhile. https://bugzilla.redhat.com/show_bug.cgi?id=1506689 Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/qemu/qemu_conf.c | 6 ++++++ src/qemu/qemu_validate.c | 8 ++++++++ 2 files changed, 14 insertions(+) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 7eb04e66a0..6077457ff4 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -451,6 +451,12 @@ virQEMUDriverConfigLoadVNCEntry(virQEMUDriverConfig *cfg, if (virConfGetValueBool(conf, "vnc_allow_host_audio", &cfg->vncAllowHostAudio) < 0) return -1; + if (cfg->vncPassword && + strlen(cfg->vncPassword) > 8) { + VIR_WARN("VNC password is %zu characters long, only 8 permitted, truncating", + strlen(cfg->vncPassword)); + cfg->vncPassword[8] = '\0'; + } return 0; } diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index f9a195e991..46b40303f6 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -4109,6 +4109,14 @@ qemuValidateDomainDeviceDefVNCGraphics(const virDomainGraphicsDef *graphics, return -1; } + if (graphics->data.vnc.auth.passwd && + strlen(graphics->data.vnc.auth.passwd) > 8) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("VNC password is %zu characters long, only 8 permitted"), + strlen(graphics->data.vnc.auth.passwd)); + return -1; + } + return 0; } -- 2.33.1

2 1

[libvirt PATCH] qemu: qemu_command: clean up includes
by Ján Tomko 16 Dec '21

16 Dec '21

Over time, the code using them got split into other files. (Mostly qemu_interface.c and qemu_process.c) Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/qemu/qemu_command.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 6d00105b24..b9105aa10b 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -22,7 +22,6 @@ #include <config.h> #include "qemu_command.h" -#include "qemu_hostdev.h" #include "qemu_capabilities.h" #include "qemu_dbus.h" #include "qemu_interface.h" @@ -30,14 +29,11 @@ #include "qemu_security.h" #include "qemu_slirp.h" #include "qemu_block.h" -#include "cpu/cpu.h" #include "viralloc.h" #include "virlog.h" #include "virarch.h" #include "virerror.h" #include "virfile.h" -#include "virnetdev.h" -#include "virnetdevbridge.h" #include "virqemu.h" #include "virstring.h" #include "virtime.h" @@ -50,7 +46,6 @@ #include "snapshot_conf.h" #include "storage_conf.h" #include "secret_conf.h" -#include "virnetdevtap.h" #include "virnetdevopenvswitch.h" #include "device_conf.h" #include "storage_source_conf.h" @@ -60,11 +55,6 @@ #include "virgic.h" #include "virmdev.h" #include "virdomainsnapshotobjlist.h" -#if defined(__linux__) -# include <linux/capability.h> -#endif -#include "logging/log_manager.h" -#include "logging/log_protocol.h" #include "virutil.h" #include "virsecureerase.h" -- 2.31.1

2 1

[PATCH] qemu: fix missing cleanup on error in qemuSaveImageStartVM
by Ani Sinha 16 Dec '21

16 Dec '21

Commit 52521de8332c2323bd ("qemu: Use qemuDomainSaveStatus") replaced a call to virDomainObjSave() with qemuDomainSaveStatus() as a part of cleanup. Since qemuDomainSaveStatus() does not indicate any failure through its return code, the error handling cleanup code got eliminated in the process. Thus upon failure, we will no longer killing the started qemu process. This commit fixes this by reverting the change that was introduced with the above commit. Fixes: 52521de8332c2323bd ("qemu: Use qemuDomainSaveStatus") Signed-off-by: Ani Sinha <ani(a)anisinha.ca> --- src/qemu/qemu_saveimage.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_saveimage.c b/src/qemu/qemu_saveimage.c index 28d6098dd8..557ee2cd21 100644 --- a/src/qemu/qemu_saveimage.c +++ b/src/qemu/qemu_saveimage.c @@ -586,6 +586,7 @@ qemuSaveImageStartVM(virConnectPtr conn, VIR_AUTOCLOSE intermediatefd = -1; g_autoptr(virCommand) cmd = NULL; g_autofree char *errbuf = NULL; + g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(driver); virQEMUSaveHeader *header = &data->header; g_autoptr(qemuDomainSaveCookie) cookie = NULL; int rc = 0; @@ -679,7 +680,10 @@ qemuSaveImageStartVM(virConnectPtr conn, "%s", _("failed to resume domain")); goto cleanup; } - qemuDomainSaveStatus(vm); + if (virDomainObjSave(vm, driver->xmlopt, cfg->stateDir) < 0) { + VIR_WARN("Failed to save status on vm %s", vm->def->name); + goto cleanup; + } } else { int detail = (start_paused ? VIR_DOMAIN_EVENT_SUSPENDED_PAUSED : VIR_DOMAIN_EVENT_SUSPENDED_RESTORED); -- 2.25.1

2 2

[libvirt PATCH v4 0/3] Support SEV direct kernel boot
by Daniel P. Berrangé 16 Dec '21

16 Dec '21

This is the left over pieces from the rest fo the previous SEV series. In this version I've changed the way we probe for capabilities and also changed the way we set the capabilities in the test suite so we don't rely on them being generated on an AMD SEV host. Daniel P. Berrangé (3): conf: add support for setting SEV kernel hashes qemu: probe for sev-guest.kernel-hashes property qemu: format sev-guest.kernel-hashes property docs/formatdomain.rst | 7 +++- docs/schemas/domaincommon.rng | 5 +++ src/conf/domain_conf.c | 8 ++++ src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 7 ++++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 1 + src/qemu/qemu_validate.c | 7 ++++ .../caps_6.2.0.x86_64.replies | 5 +++ .../caps_6.2.0.x86_64.xml | 1 + ...nch-security-sev-direct.x86_64-latest.args | 40 +++++++++++++++++++ .../launch-security-sev-direct.xml | 39 ++++++++++++++++++ tests/qemuxml2argvtest.c | 5 +++ tests/testutilsqemu.c | 15 ++++--- 14 files changed, 136 insertions(+), 6 deletions(-) create mode 100644 tests/qemuxml2argvdata/launch-security-sev-direct.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/launch-security-sev-direct.xml -- 2.33.1

2 5

[PATCH v4 0/3] remove sysconfig files
by Olaf Hering 16 Dec '21

16 Dec '21

rebased to 359e9f5cf4526eff630d803f68df9733abaef419 Olaf Hering (3): libvirt.spec: relocate pre script of daemon-driver-qemu remove sysconfig files NEWS: mention removal of sysconfig NEWS.rst | 10 +++ docs/daemons.rst | 20 +++++ docs/remote.html.in | 6 +- libvirt.spec.in | 99 +++++++++++++++++-------- src/ch/meson.build | 5 -- src/ch/virtchd.service.in | 1 + src/ch/virtchd.sysconf | 3 - src/interface/meson.build | 5 -- src/interface/virtinterfaced.service.in | 1 + src/interface/virtinterfaced.sysconf | 3 - src/libxl/meson.build | 5 -- src/libxl/virtxend.service.in | 1 + src/libxl/virtxend.sysconf | 3 - src/locking/meson.build | 5 -- src/locking/virtlockd.service.in | 1 + src/locking/virtlockd.sysconf | 3 - src/logging/meson.build | 5 -- src/logging/virtlogd.sysconf | 3 - src/lxc/meson.build | 5 -- src/lxc/virtlxcd.service.in | 1 + src/lxc/virtlxcd.sysconf | 3 - src/meson.build | 16 ---- src/network/meson.build | 5 -- src/network/virtnetworkd.service.in | 1 + src/network/virtnetworkd.sysconf | 3 - src/node_device/meson.build | 5 -- src/node_device/virtnodedevd.service.in | 1 + src/node_device/virtnodedevd.sysconf | 3 - src/nwfilter/meson.build | 5 -- src/nwfilter/virtnwfilterd.service.in | 1 + src/nwfilter/virtnwfilterd.sysconf | 3 - src/qemu/meson.build | 5 -- src/qemu/virtqemud.service.in | 7 ++ src/qemu/virtqemud.sysconf | 12 --- src/remote/libvirtd.service.in | 7 ++ src/remote/libvirtd.sysconf | 21 ------ src/remote/meson.build | 10 --- src/remote/virtproxyd.service.in | 1 + src/remote/virtproxyd.sysconf | 3 - src/secret/meson.build | 5 -- src/secret/virtsecretd.service.in | 1 + src/secret/virtsecretd.sysconf | 3 - src/storage/meson.build | 5 -- src/storage/virtstoraged.service.in | 1 + src/storage/virtstoraged.sysconf | 3 - src/vbox/meson.build | 5 -- src/vbox/virtvboxd.service.in | 1 + src/vbox/virtvboxd.sysconf | 3 - src/vz/meson.build | 5 -- src/vz/virtvzd.service.in | 1 + src/vz/virtvzd.sysconf | 3 - tools/libvirt-guests.sh.in | 40 ++++++++++ tools/libvirt-guests.sysconf | 50 ------------- tools/meson.build | 6 -- 54 files changed, 167 insertions(+), 262 deletions(-) delete mode 100644 src/ch/virtchd.sysconf delete mode 100644 src/interface/virtinterfaced.sysconf delete mode 100644 src/libxl/virtxend.sysconf delete mode 100644 src/locking/virtlockd.sysconf delete mode 100644 src/logging/virtlogd.sysconf delete mode 100644 src/lxc/virtlxcd.sysconf delete mode 100644 src/network/virtnetworkd.sysconf delete mode 100644 src/node_device/virtnodedevd.sysconf delete mode 100644 src/nwfilter/virtnwfilterd.sysconf delete mode 100644 src/qemu/virtqemud.sysconf delete mode 100644 src/remote/libvirtd.sysconf delete mode 100644 src/remote/virtproxyd.sysconf delete mode 100644 src/secret/virtsecretd.sysconf delete mode 100644 src/storage/virtstoraged.sysconf delete mode 100644 src/vbox/virtvboxd.sysconf delete mode 100644 src/vz/virtvzd.sysconf delete mode 100644 tools/libvirt-guests.sysconf

2 5

[libvirt PATCH 0/2] qemu: Use qemuDomainSaveStatus
by Jiri Denemark 15 Dec '21

15 Dec '21

Jiri Denemark (2): qemu: Use qemuDomainSaveStatus qemu: Drop driver parameter from qemuDomainSetFakeReboot src/qemu/qemu_domain.c | 12 ++--- src/qemu/qemu_domain.h | 3 +- src/qemu/qemu_driver.c | 14 +++--- src/qemu/qemu_migration.c | 9 +--- src/qemu/qemu_process.c | 98 ++++++++------------------------------- src/qemu/qemu_process.h | 3 +- src/qemu/qemu_saveimage.c | 6 +-- 7 files changed, 35 insertions(+), 110 deletions(-) -- 2.34.1

3 4

[PATCH] qemucapstest: Update qemu capabilities probe dump for qemu-6.2 release
by Peter Krempa 15 Dec '21

15 Dec '21

qemu-6.2 is out, update the caps dump for the final time. Notable changes: - 'unstable' feature flag for various QMP schema entries - 'aio-max-batch' iothread property - 'kernel-hashes' knob for the 'sev-guest' object - 'native-hotplug' of 'pcie-root-port' is now unstable again - 'page-sampling/dirty-ring/dirty-bitmap' mode for 'calc-dirty-rate' - 'toolsversion' field for the 'vmdk' disk format driver - CPU changes resulting in 'core-capability' being present on the cpu of the machine this dump was done on Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- .../caps_6.2.0.x86_64.replies | 2687 +++++++++-------- .../caps_6.2.0.x86_64.xml | 6 +- 2 files changed, 1495 insertions(+), 1198 deletions(-) diff --git a/tests/qemucapabilitiesdata/caps_6.2.0.x86_64.replies b/tests/qemucapabilitiesdata/caps_6.2.0.x86_64.replies index 69d3b1b12a..29b8e4e8d2 100644 --- a/tests/qemucapabilitiesdata/caps_6.2.0.x86_64.replies +++ b/tests/qemucapabilitiesdata/caps_6.2.0.x86_64.replies @@ -17,11 +17,11 @@ { "return": { "qemu": { - "micro": 50, - "minor": 1, + "micro": 0, + "minor": 2, "major": 6 }, - "package": "v6.1.0-1735-gc52d69e7db" + "package": "v6.2.0" }, "id": "libvirt-2" } @@ -242,7 +242,10 @@ "name": "drive-backup", "ret-type": "0", "meta-type": "command", - "arg-type": "30" + "arg-type": "30", + "features": [ + "deprecated" + ] }, { "name": "blockdev-backup", @@ -260,7 +263,10 @@ "name": "x-debug-query-block-graph", "ret-type": "34", "meta-type": "command", - "arg-type": "0" + "arg-type": "0", + "features": [ + "unstable" + ] }, { "name": "drive-mirror", @@ -308,7 +314,10 @@ "name": "x-debug-block-dirty-bitmap-sha256", "ret-type": "39", "meta-type": "command", - "arg-type": "37" + "arg-type": "37", + "features": [ + "unstable" + ] }, { "name": "blockdev-mirror", @@ -392,7 +401,10 @@ "name": "x-blockdev-amend", "ret-type": "0", "meta-type": "command", - "arg-type": "53" + "arg-type": "53", + "features": [ + "unstable" + ] }, { "name": "BLOCK_IMAGE_CORRUPTED", @@ -444,13 +456,19 @@ "name": "x-blockdev-change", "ret-type": "0", "meta-type": "command", - "arg-type": "63" + "arg-type": "63", + "features": [ + "unstable" + ] }, { "name": "x-blockdev-set-iothread", "ret-type": "0", "meta-type": "command", - "arg-type": "64" + "arg-type": "64", + "features": [ + "unstable" + ] }, { "name": "QUORUM_FAILURE", @@ -905,7 +923,10 @@ "name": "x-colo-lost-heartbeat", "ret-type": "0", "meta-type": "command", - "arg-type": "0" + "arg-type": "0", + "features": [ + "unstable" + ] }, { "name": "migrate_cancel", @@ -1281,21 +1302,102 @@ "deprecated" ] }, + { + "name": "x-query-irq", + "ret-type": "203", + "meta-type": "command", + "arg-type": "0", + "features": [ + "unstable" + ] + }, + { + "name": "x-query-jit", + "ret-type": "203", + "meta-type": "command", + "arg-type": "0", + "features": [ + "unstable" + ] + }, + { + "name": "x-query-numa", + "ret-type": "203", + "meta-type": "command", + "arg-type": "0", + "features": [ + "unstable" + ] + }, + { + "name": "x-query-opcount", + "ret-type": "203", + "meta-type": "command", + "arg-type": "0", + "features": [ + "unstable" + ] + }, + { + "name": "x-query-profile", + "ret-type": "203", + "meta-type": "command", + "arg-type": "0", + "features": [ + "unstable" + ] + }, + { + "name": "x-query-ramblock", + "ret-type": "203", + "meta-type": "command", + "arg-type": "0", + "features": [ + "unstable" + ] + }, + { + "name": "x-query-rdma", + "ret-type": "203", + "meta-type": "command", + "arg-type": "0", + "features": [ + "unstable" + ] + }, + { + "name": "x-query-roms", + "ret-type": "203", + "meta-type": "command", + "arg-type": "0", + "features": [ + "unstable" + ] + }, + { + "name": "x-query-usb", + "ret-type": "203", + "meta-type": "command", + "arg-type": "0", + "features": [ + "unstable" + ] + }, { "name": "query-cpu-model-expansion", - "ret-type": "208", + "ret-type": "209", "meta-type": "command", - "arg-type": "207" + "arg-type": "208" }, { "name": "query-cpu-definitions", - "ret-type": "[209]", + "ret-type": "[210]", "meta-type": "command", "arg-type": "0" }, { "name": "query-replay", - "ret-type": "210", + "ret-type": "211", "meta-type": "command", "arg-type": "0" }, @@ -1303,7 +1405,7 @@ "name": "replay-break", "ret-type": "0", "meta-type": "command", - "arg-type": "211" + "arg-type": "212" }, { "name": "replay-delete-break", @@ -1315,18 +1417,18 @@ "name": "replay-seek", "ret-type": "0", "meta-type": "command", - "arg-type": "212" + "arg-type": "213" }, { "name": "yank", "ret-type": "0", "allow-oob": true, "meta-type": "command", - "arg-type": "213" + "arg-type": "214" }, { "name": "query-yank", - "ret-type": "[214]", + "ret-type": "[215]", "allow-oob": true, "meta-type": "command", "arg-type": "0" @@ -1335,17 +1437,17 @@ "name": "add_client", "ret-type": "0", "meta-type": "command", - "arg-type": "215" + "arg-type": "216" }, { "name": "query-name", - "ret-type": "216", + "ret-type": "217", "meta-type": "command", "arg-type": "0" }, { "name": "query-iothreads", - "ret-type": "[217]", + "ret-type": "[218]", "meta-type": "command", "arg-type": "0" }, @@ -1365,13 +1467,16 @@ "name": "x-exit-preconfig", "ret-type": "0", "meta-type": "command", - "arg-type": "0" + "arg-type": "0", + "features": [ + "unstable" + ] }, { "name": "human-monitor-command", "ret-type": "str", "meta-type": "command", - "arg-type": "218", + "arg-type": "219", "features": [ "savevm-monitor-nodes" ] @@ -1380,42 +1485,42 @@ "name": "getfd", "ret-type": "0", "meta-type": "command", - "arg-type": "219" + "arg-type": "220" }, { "name": "closefd", "ret-type": "0", "meta-type": "command", - "arg-type": "220" + "arg-type": "221" }, { "name": "add-fd", - "ret-type": "222", + "ret-type": "223", "meta-type": "command", - "arg-type": "221" + "arg-type": "222" }, { "name": "remove-fd", "ret-type": "0", "meta-type": "command", - "arg-type": "223" + "arg-type": "224" }, { "name": "query-fdsets", - "ret-type": "[224]", + "ret-type": "[225]", "meta-type": "command", "arg-type": "0" }, { "name": "query-command-line-options", - "ret-type": "[226]", + "ret-type": "[227]", "meta-type": "command", - "arg-type": "225" + "arg-type": "226" }, { "name": "RTC_CHANGE", "meta-type": "event", - "arg-type": "227" + "arg-type": "228" }, { "name": "rtc-reset-reinjection", @@ -1425,19 +1530,19 @@ }, { "name": "query-sev", - "ret-type": "228", + "ret-type": "229", "meta-type": "command", "arg-type": "0" }, { "name": "query-sev-launch-measure", - "ret-type": "229", + "ret-type": "230", "meta-type": "command", "arg-type": "0" }, { "name": "query-sev-capabilities", - "ret-type": "230", + "ret-type": "231", "meta-type": "command", "arg-type": "0" }, @@ -1445,40 +1550,40 @@ "name": "sev-inject-launch-secret", "ret-type": "0", "meta-type": "command", - "arg-type": "231" + "arg-type": "232" }, { "name": "query-sev-attestation-report", - "ret-type": "233", + "ret-type": "234", "meta-type": "command", - "arg-type": "232" + "arg-type": "233" }, { "name": "query-sgx", - "ret-type": "236", + "ret-type": "237", "meta-type": "command", "arg-type": "0" }, { "name": "query-sgx-capabilities", - "ret-type": "236", + "ret-type": "237", "meta-type": "command", "arg-type": "0" }, { "name": "query-acpi-ospm-status", - "ret-type": "[237]", + "ret-type": "[238]", "meta-type": "command", "arg-type": "0" }, { "name": "ACPI_DEVICE_OST", "meta-type": "event", - "arg-type": "238" + "arg-type": "239" }, { "name": "query-pci", - "ret-type": "[239]", + "ret-type": "[240]", "meta-type": "command", "arg-type": "0" }, @@ -1501,7 +1606,7 @@ }, { "name": "status", - "type": "240" + "type": "241" } ], "meta-type": "object" @@ -1515,7 +1620,7 @@ }, { "name": "reason", - "type": "241" + "type": "242" } ], "meta-type": "object" @@ -1529,7 +1634,7 @@ }, { "name": "reason", - "type": "241" + "type": "242" } ], "meta-type": "object" @@ -1539,7 +1644,7 @@ "members": [ { "name": "action", - "type": "242" + "type": "243" } ], "meta-type": "object" @@ -1549,7 +1654,7 @@ "members": [ { "name": "action", - "type": "242" + "type": "243" } ], "meta-type": "object" @@ -1560,22 +1665,22 @@ { "name": "reboot", "default": null, - "type": "243" + "type": "244" }, { "name": "shutdown", "default": null, - "type": "244" + "type": "245" }, { "name": "panic", "default": null, - "type": "245" + "type": "246" }, { "name": "watchdog", "default": null, - "type": "242" + "type": "243" } ], "meta-type": "object" @@ -1585,12 +1690,12 @@ "members": [ { "name": "action", - "type": "246" + "type": "247" }, { "name": "info", "default": null, - "type": "247" + "type": "248" } ], "meta-type": "object" @@ -1600,12 +1705,12 @@ "members": [ { "name": "action", - "type": "246" + "type": "247" }, { "name": "info", "default": null, - "type": "247" + "type": "248" } ], "meta-type": "object" @@ -1615,15 +1720,15 @@ "members": [ { "name": "recipient", - "type": "248" + "type": "249" }, { "name": "action", - "type": "249" + "type": "250" }, { "name": "flags", - "type": "250" + "type": "251" } ], "meta-type": "object" @@ -1766,7 +1871,7 @@ { "name": "read-only-mode", "default": null, - "type": "251" + "type": "252" } ], "meta-type": "object" @@ -1988,7 +2093,7 @@ { "name": "io-status", "default": null, - "type": "252" + "type": "253" } ], "meta-type": "object" @@ -2029,12 +2134,12 @@ }, { "name": "stats", - "type": "253" + "type": "254" }, { "name": "driver-specific", "default": null, - "type": "254" + "type": "255" }, { "name": "parent", @@ -2087,7 +2192,7 @@ }, { "name": "io-status", - "type": "252" + "type": "253" }, { "name": "ready", @@ -2095,7 +2200,7 @@ }, { "name": "status", - "type": "255" + "type": "256" }, { "name": "auto-finalize", @@ -2163,7 +2268,7 @@ { "name": "mode", "default": null, - "type": "256" + "type": "257" } ], "meta-type": "object" @@ -2251,7 +2356,7 @@ { "name": "on-error", "default": null, - "type": "257" + "type": "258" }, { "name": "filter-node-name", @@ -2285,7 +2390,7 @@ }, { "name": "sync", - "type": "258" + "type": "259" }, { "name": "speed", @@ -2300,7 +2405,7 @@ { "name": "bitmap-mode", "default": null, - "type": "259" + "type": "260" }, { "name": "compress", @@ -2310,12 +2415,12 @@ { "name": "on-source-error", "default": null, - "type": "257" + "type": "258" }, { "name": "on-target-error", "default": null, - "type": "257" + "type": "258" }, { "name": "auto-finalize", @@ -2335,7 +2440,10 @@ { "name": "x-perf", "default": null, - "type": "260" + "type": "261", + "features": [ + "unstable" + ] }, { "name": "target", @@ -2349,7 +2457,7 @@ { "name": "mode", "default": null, - "type": "256" + "type": "257" } ], "meta-type": "object" @@ -2368,7 +2476,7 @@ }, { "name": "sync", - "type": "258" + "type": "259" }, { "name": "speed", @@ -2383,7 +2491,7 @@ { "name": "bitmap-mode", "default": null, - "type": "259" + "type": "260" }, { "name": "compress", @@ -2393,12 +2501,12 @@ { "name": "on-source-error", "default": null, - "type": "257" + "type": "258" }, { "name": "on-target-error", "default": null, - "type": "257" + "type": "258" }, { "name": "auto-finalize", @@ -2418,7 +2526,10 @@ { "name": "x-perf", "default": null, - "type": "260" + "type": "261", + "features": [ + "unstable" + ] }, { "name": "target", @@ -2478,7 +2589,7 @@ }, { "name": "detect_zeroes", - "type": "261" + "type": "262" }, { "name": "bps", @@ -2506,7 +2617,7 @@ }, { "name": "image", - "type": "262" + "type": "263" }, { "name": "bps_max", @@ -2580,7 +2691,7 @@ }, { "name": "cache", - "type": "263" + "type": "264" }, { "name": "write_threshold", @@ -2589,7 +2700,7 @@ { "name": "dirty-bitmaps", "default": null, - "type": "[264]" + "type": "[265]" } ], "meta-type": "object" @@ -2599,11 +2710,11 @@ "members": [ { "name": "nodes", - "type": "[265]" + "type": "[266]" }, { "name": "edges", - "type": "[266]" + "type": "[267]" } ], "meta-type": "object" @@ -2641,12 +2752,12 @@ }, { "name": "sync", - "type": "258" + "type": "259" }, { "name": "mode", "default": null, - "type": "256" + "type": "257" }, { "name": "speed", @@ -2666,12 +2777,12 @@ { "name": "on-source-error", "default": null, - "type": "257" + "type": "258" }, { "name": "on-target-error", "default": null, - "type": "257" + "type": "258" }, { "name": "unmap", @@ -2681,7 +2792,7 @@ { "name": "copy-mode", "default": null, - "type": "267" + "type": "268" }, { "name": "auto-finalize", @@ -2752,7 +2863,7 @@ }, { "name": "bitmaps", - "type": "[268]" + "type": "[269]" } ], "meta-type": "object" @@ -2790,7 +2901,7 @@ }, { "name": "sync", - "type": "258" + "type": "259" }, { "name": "speed", @@ -2810,12 +2921,12 @@ { "name": "on-source-error", "default": null, - "type": "257" + "type": "258" }, { "name": "on-target-error", "default": null, - "type": "257" + "type": "258" }, { "name": "filter-node-name", @@ -2825,7 +2936,7 @@ { "name": "copy-mode", "default": null, - "type": "267" + "type": "268" }, { "name": "auto-finalize", @@ -2880,7 +2991,7 @@ { "name": "on-error", "default": null, - "type": "257" + "type": "258" }, { "name": "filter-node-name", @@ -2985,173 +3096,173 @@ "variants": [ { "case": "blkdebug", - "type": "272" + "type": "273" }, { "case": "blklogwrites", - "type": "273" + "type": "274" }, { "case": "blkverify", - "type": "274" + "type": "275" }, { "case": "blkreplay", - "type": "275" + "type": "276" }, { "case": "bochs", - "type": "276" + "type": "277" }, { "case": "cloop", - "type": "276" + "type": "277" }, { "case": "compress", - "type": "276" + "type": "277" }, { "case": "copy-before-write", - "type": "277" + "type": "278" }, { "case": "copy-on-read", - "type": "278" + "type": "279" }, { "case": "dmg", - "type": "276" + "type": "277" }, { "case": "file", - "type": "279" + "type": "280" }, { "case": "ftp", - "type": "280" + "type": "281" }, { "case": "ftps", - "type": "281" + "type": "282" }, { "case": "gluster", - "type": "282" + "type": "283" }, { "case": "host_cdrom", - "type": "279" + "type": "280" }, { "case": "host_device", - "type": "279" + "type": "280" }, { "case": "http", - "type": "283" + "type": "284" }, { "case": "https", - "type": "284" + "type": "285" }, { "case": "iscsi", - "type": "285" + "type": "286" }, { "case": "luks", - "type": "286" + "type": "287" }, { "case": "nbd", - "type": "287" + "type": "288" }, { "case": "nfs", - "type": "288" + "type": "289" }, { "case": "null-aio", - "type": "289" + "type": "290" }, { "case": "null-co", - "type": "289" + "type": "290" }, { "case": "nvme", - "type": "290" + "type": "291" }, { "case": "parallels", - "type": "276" + "type": "277" }, { "case": "preallocate", - "type": "291" + "type": "292" }, { "case": "qcow2", - "type": "292" + "type": "293" }, { "case": "qcow", - "type": "293" + "type": "294" }, { "case": "qed", - "type": "294" + "type": "295" }, { "case": "quorum", - "type": "295" + "type": "296" }, { "case": "raw", - "type": "296" + "type": "297" }, { "case": "rbd", - "type": "297" + "type": "298" }, { "case": "replication", - "type": "298" + "type": "299" }, { "case": "ssh", - "type": "299" + "type": "300" }, { "case": "throttle", - "type": "300" + "type": "301" }, { "case": "vdi", - "type": "276" + "type": "277" }, { "case": "vhdx", - "type": "276" + "type": "277" }, { "case": "vmdk", - "type": "294" + "type": "295" }, { "case": "vpc", - "type": "276" + "type": "277" }, { "case": "vvfat", - "type": "301" + "type": "302" } ], "members": [ { "name": "driver", - "type": "269" + "type": "270" }, { "name": "node-name", @@ -3161,12 +3272,12 @@ { "name": "discard", "default": null, - "type": "270" + "type": "271" }, { "name": "cache", "default": null, - "type": "271" + "type": "272" }, { "name": "read-only", @@ -3186,7 +3297,7 @@ { "name": "detect-zeroes", "default": null, - "type": "261" + "type": "262" } ], "meta-type": "object" @@ -3220,7 +3331,7 @@ }, { "name": "options", - "type": "302" + "type": "303" } ], "meta-type": "object" @@ -3238,7 +3349,7 @@ }, { "name": "options", - "type": "303" + "type": "304" }, { "name": "force", @@ -3295,11 +3406,11 @@ }, { "name": "operation", - "type": "304" + "type": "305" }, { "name": "action", - "type": "305" + "type": "306" }, { "name": "nospace", @@ -3318,7 +3429,7 @@ "members": [ { "name": "type", - "type": "306" + "type": "307" }, { "name": "device", @@ -3349,7 +3460,7 @@ "members": [ { "name": "type", - "type": "306" + "type": "307" }, { "name": "device", @@ -3379,11 +3490,11 @@ }, { "name": "operation", - "type": "304" + "type": "305" }, { "name": "action", - "type": "305" + "type": "306" } ], "meta-type": "object" @@ -3393,7 +3504,7 @@ "members": [ { "name": "type", - "type": "306" + "type": "307" }, { "name": "device", @@ -3419,7 +3530,7 @@ "members": [ { "name": "type", - "type": "306" + "type": "307" }, { "name": "id", @@ -3489,7 +3600,7 @@ }, { "name": "iothread", - "type": "307" + "type": "308" }, { "name": "force", @@ -3522,7 +3633,7 @@ "members": [ { "name": "type", - "type": "308" + "type": "309" }, { "name": "error", @@ -3626,7 +3737,7 @@ }, { "name": "status", - "type": "255" + "type": "256" } ], "meta-type": "object" @@ -3705,11 +3816,11 @@ }, { "name": "type", - "type": "306" + "type": "307" }, { "name": "status", - "type": "255" + "type": "256" }, { "name": "current-progress", @@ -3732,7 +3843,7 @@ "members": [ { "name": "addr", - "type": "309" + "type": "310" }, { "name": "tls-creds", @@ -3792,7 +3903,7 @@ { "name": "mode", "default": null, - "type": "310" + "type": "311" } ], "meta-type": "object" @@ -3803,17 +3914,17 @@ "variants": [ { "case": "nbd", - "type": "312" + "type": "313" }, { "case": "vhost-user-blk", - "type": "313" + "type": "314" } ], "members": [ { "name": "type", - "type": "311" + "type": "312" }, { "name": "id", @@ -3856,7 +3967,7 @@ { "name": "mode", "default": null, - "type": "310" + "type": "311" } ], "meta-type": "object" @@ -3885,7 +3996,7 @@ }, { "name": "type", - "type": "311" + "type": "312" }, { "name": "node-name", @@ -3950,7 +4061,7 @@ { "name": "format", "default": null, - "type": "315" + "type": "316" } ], "meta-type": "object" @@ -3969,7 +4080,7 @@ { "name": "format", "default": null, - "type": "315" + "type": "316" } ], "meta-type": "object" @@ -3988,7 +4099,7 @@ }, { "name": "backend", - "type": "316" + "type": "317" } ], "meta-type": "object" @@ -4013,7 +4124,7 @@ }, { "name": "backend", - "type": "316" + "type": "317" } ], "meta-type": "object" @@ -4081,7 +4192,7 @@ { "name": "format", "default": null, - "type": "317" + "type": "318" } ], "meta-type": "object" @@ -4091,7 +4202,7 @@ "members": [ { "name": "status", - "type": "318" + "type": "319" }, { "name": "completed", @@ -4124,7 +4235,7 @@ "members": [ { "name": "formats", - "type": "[317]" + "type": "[318]" } ], "meta-type": "object" @@ -4149,47 +4260,47 @@ "variants": [ { "case": "nic", - "type": "320" + "type": "321" }, { "case": "user", - "type": "321" + "type": "322" }, { "case": "tap", - "type": "322" + "type": "323" }, { "case": "l2tpv3", - "type": "323" + "type": "324" }, { "case": "socket", - "type": "324" + "type": "325" }, { "case": "vde", - "type": "325" + "type": "326" }, { "case": "bridge", - "type": "326" + "type": "327" }, { "case": "hubport", - "type": "327" + "type": "328" }, { "case": "netmap", - "type": "328" + "type": "329" }, { "case": "vhost-user", - "type": "329" + "type": "330" }, { "case": "vhost-vdpa", - "type": "330" + "type": "331" }, { "case": "none", @@ -4203,7 +4314,7 @@ }, { "name": "type", - "type": "319" + "type": "320" } ], "meta-type": "object" @@ -4247,15 +4358,15 @@ }, { "name": "multicast", - "type": "331" + "type": "332" }, { "name": "unicast", - "type": "331" + "type": "332" }, { "name": "vlan", - "type": "331" + "type": "332" }, { "name": "broadcast-allowed", @@ -4431,11 +4542,11 @@ }, { "name": "duplex", - "type": "332" + "type": "333" }, { "name": "autoneg", - "type": "333" + "type": "334" } ], "meta-type": "object" @@ -4473,15 +4584,15 @@ }, { "name": "key", - "type": "334" + "type": "335" }, { "name": "mask", - "type": "335" + "type": "336" }, { "name": "action", - "type": "336" + "type": "337" } ], "meta-type": "object" @@ -4639,7 +4750,7 @@ }, { "name": "options", - "type": "337" + "type": "338" } ], "meta-type": "object" @@ -4735,12 +4846,12 @@ }, { "name": "mouse-mode", - "type": "338" + "type": "339" }, { "name": "channels", "default": null, - "type": "[339]" + "type": "[340]" } ], "meta-type": "object" @@ -4750,11 +4861,11 @@ "members": [ { "name": "server", - "type": "340" + "type": "341" }, { "name": "client", - "type": "340" + "type": "341" } ], "meta-type": "object" @@ -4764,11 +4875,11 @@ "members": [ { "name": "server", - "type": "341" + "type": "342" }, { "name": "client", - "type": "339" + "type": "340" } ], "meta-type": "object" @@ -4778,11 +4889,11 @@ "members": [ { "name": "server", - "type": "340" + "type": "341" }, { "name": "client", - "type": "340" + "type": "341" } ], "meta-type": "object" @@ -4802,7 +4913,7 @@ { "name": "family", "default": null, - "type": "342" + "type": "343" }, { "name": "service", @@ -4817,7 +4928,7 @@ { "name": "clients", "default": null, - "type": "[343]" + "type": "[344]" } ], "meta-type": "object" @@ -4836,20 +4947,20 @@ }, { "name": "server", - "type": "[344]" + "type": "[345]" }, { "name": "clients", - "type": "[343]" + "type": "[344]" }, { "name": "auth", - "type": "345" + "type": "346" }, { "name": "vencrypt", "default": null, - "type": "346" + "type": "347" }, { "name": "display", @@ -4874,11 +4985,11 @@ "members": [ { "name": "server", - "type": "347" + "type": "348" }, { "name": "client", - "type": "348" + "type": "349" } ], "meta-type": "object" @@ -4888,11 +4999,11 @@ "members": [ { "name": "server", - "type": "347" + "type": "348" }, { "name": "client", - "type": "343" + "type": "344" } ], "meta-type": "object" @@ -4902,11 +5013,11 @@ "members": [ { "name": "server", - "type": "347" + "type": "348" }, { "name": "client", - "type": "343" + "type": "344" } ], "meta-type": "object" @@ -4943,7 +5054,7 @@ "members": [ { "name": "keys", - "type": "[349]" + "type": "[350]" }, { "name": "hold-time", @@ -4968,7 +5079,7 @@ }, { "name": "events", - "type": "[350]" + "type": "[351]" } ], "meta-type": "object" @@ -4979,11 +5090,11 @@ "variants": [ { "case": "curses", - "type": "354" + "type": "355" }, { "case": "egl-headless", - "type": "355" + "type": "356" }, { "case": "default", @@ -5005,7 +5116,7 @@ "members": [ { "name": "type", - "type": "351" + "type": "352" }, { "name": "full-screen", @@ -5025,7 +5136,7 @@ { "name": "gl", "default": null, - "type": "352" + "type": "353" } ], "meta-type": "object" @@ -5036,13 +5147,13 @@ "variants": [ { "case": "vnc", - "type": "357" + "type": "358" } ], "members": [ { "name": "type", - "type": "356" + "type": "357" } ], "meta-type": "object" @@ -5053,27 +5164,27 @@ { "name": "status", "default": null, - "type": "358" + "type": "359" }, { "name": "ram", "default": null, - "type": "359" + "type": "360" }, { "name": "disk", "default": null, - "type": "359" + "type": "360" }, { "name": "vfio", "default": null, - "type": "360" + "type": "361" }, { "name": "xbzrle-cache", "default": null, - "type": "361" + "type": "362" }, { "name": "total-time", @@ -5123,12 +5234,12 @@ { "name": "compression", "default": null, - "type": "362" + "type": "363" }, { "name": "socket-address", "default": null, - "type": "[363]" + "type": "[364]" } ], "meta-type": "object" @@ -5153,7 +5264,7 @@ "members": [ { "name": "capability", - "type": "364" + "type": "365" }, { "name": "state", @@ -5228,17 +5339,17 @@ { "name": "tls-creds", "default": null, - "type": "307" + "type": "308" }, { "name": "tls-hostname", "default": null, - "type": "307" + "type": "308" }, { "name": "tls-authz", "default": null, - "type": "307" + "type": "308" }, { "name": "max-bandwidth", @@ -5253,7 +5364,10 @@ { "name": "x-checkpoint-delay", "default": null, - "type": "int" + "type": "int", + "features": [ + "unstable" + ] }, { "name": "block-incremental", @@ -5283,7 +5397,7 @@ { "name": "multifd-compression", "default": null, - "type": "365" + "type": "366" }, { "name": "multifd-zlib-level", @@ -5298,7 +5412,7 @@ { "name": "block-bitmap-mapping", "default": null, - "type": "[366]" + "type": "[367]" } ], "meta-type": "object" @@ -5394,7 +5508,10 @@ { "name": "x-checkpoint-delay", "default": null, - "type": "int" + "type": "int", + "features": [ + "unstable" + ] }, { "name": "block-incremental", @@ -5424,7 +5541,7 @@ { "name": "multifd-compression", "default": null, - "type": "365" + "type": "366" }, { "name": "multifd-zlib-level", @@ -5439,7 +5556,7 @@ { "name": "block-bitmap-mapping", "default": null, - "type": "[366]" + "type": "[367]" } ], "meta-type": "object" @@ -5478,7 +5595,7 @@ "members": [ { "name": "status", - "type": "358" + "type": "359" } ], "meta-type": "object" @@ -5498,11 +5615,11 @@ "members": [ { "name": "mode", - "type": "367" + "type": "368" }, { "name": "reason", - "type": "368" + "type": "369" } ], "meta-type": "object" @@ -5512,7 +5629,7 @@ "members": [ { "name": "state", - "type": "358" + "type": "359" } ], "meta-type": "object" @@ -5631,15 +5748,15 @@ "members": [ { "name": "mode", - "type": "367" + "type": "368" }, { "name": "last-mode", - "type": "367" + "type": "368" }, { "name": "reason", - "type": "368" + "type": "369" } ], "meta-type": "object" @@ -5675,6 +5792,11 @@ "name": "sample-pages", "default": null, "type": "int" + }, + { + "name": "mode", + "default": null, + "type": "370" } ], "meta-type": "object" @@ -5689,7 +5811,7 @@ }, { "name": "status", - "type": "369" + "type": "371" }, { "name": "start-time", @@ -5702,6 +5824,15 @@ { "name": "sample-pages", "type": "int" + }, + { + "name": "mode", + "type": "370" + }, + { + "name": "vcpu-dirty-rate", + "default": null, + "type": "[372]" } ], "meta-type": "object" @@ -5773,12 +5904,12 @@ "members": [ { "name": "actions", - "type": "[370]" + "type": "[373]" }, { "name": "properties", "default": null, - "type": "371" + "type": "374" } ], "meta-type": "object" @@ -5812,7 +5943,7 @@ }, { "name": "state", - "type": "372" + "type": "375" }, { "name": "vcpu", @@ -5851,7 +5982,7 @@ { "name": "enable", "default": null, - "type": "[373]" + "type": "[376]" } ], "meta-type": "object" @@ -5861,7 +5992,7 @@ "members": [ { "name": "qemu", - "type": "374" + "type": "377" }, { "name": "package", @@ -5896,31 +6027,31 @@ "variants": [ { "case": "builtin", - "type": "376" + "type": "379" }, { "case": "enum", - "type": "377" + "type": "380" }, { "case": "array", - "type": "378" + "type": "381" }, { "case": "object", - "type": "379" + "type": "382" }, { "case": "alternate", - "type": "380" + "type": "383" }, { "case": "command", - "type": "381" + "type": "384" }, { "case": "event", - "type": "382" + "type": "385" } ], "members": [ @@ -5930,7 +6061,7 @@ }, { "name": "meta-type", - "type": "375" + "type": "378" }, { "name": "features", @@ -6073,151 +6204,151 @@ "variants": [ { "case": "authz-list", - "type": "384" + "type": "387" }, { "case": "authz-listfile", - "type": "385" + "type": "388" }, { "case": "authz-pam", - "type": "386" + "type": "389" }, { "case": "authz-simple", - "type": "387" + "type": "390" }, { "case": "can-host-socketcan", - "type": "388" + "type": "391" }, { "case": "colo-compare", - "type": "389" + "type": "392" }, { "case": "cryptodev-backend", - "type": "390" + "type": "393" }, { "case": "cryptodev-backend-builtin", - "type": "390" + "type": "393" }, { "case": "cryptodev-vhost-user", - "type": "391" + "type": "394" }, { "case": "dbus-vmstate", - "type": "392" + "type": "395" }, { "case": "filter-buffer", - "type": "393" + "type": "396" }, { "case": "filter-dump", - "type": "394" + "type": "397" }, { "case": "filter-mirror", - "type": "395" + "type": "398" }, { "case": "filter-redirector", - "type": "396" + "type": "399" }, { "case": "filter-replay", - "type": "397" + "type": "400" }, { "case": "filter-rewriter", - "type": "398" + "type": "401" }, { "case": "input-barrier", - "type": "399" + "type": "402" }, { "case": "input-linux", - "type": "400" + "type": "403" }, { "case": "iothread", - "type": "401" + "type": "404" }, { "case": "memory-backend-epc", - "type": "402" + "type": "405" }, { "case": "memory-backend-file", - "type": "403" + "type": "406" }, { "case": "memory-backend-memfd", - "type": "404" + "type": "407" }, { "case": "memory-backend-ram", - "type": "405" + "type": "408" }, { "case": "pr-manager-helper", - "type": "406" + "type": "409" }, { "case": "qtest", - "type": "407" + "type": "410" }, { "case": "rng-builtin", - "type": "408" + "type": "411" }, { "case": "rng-egd", - "type": "409" + "type": "412" }, { "case": "rng-random", - "type": "410" + "type": "413" }, { "case": "secret", - "type": "411" + "type": "414" }, { "case": "secret_keyring", - "type": "412" + "type": "415" }, { "case": "sev-guest", - "type": "413" + "type": "416" }, { "case": "throttle-group", - "type": "414" + "type": "417" }, { "case": "tls-creds-anon", - "type": "415" + "type": "418" }, { "case": "tls-creds-psk", - "type": "416" + "type": "419" }, { "case": "tls-creds-x509", - "type": "417" + "type": "420" }, { "case": "tls-cipher-suites", - "type": "418" + "type": "421" }, { "case": "x-remote-object", - "type": "419" + "type": "422" }, { "case": "can-bus", @@ -6235,7 +6366,7 @@ "members": [ { "name": "qom-type", - "type": "383" + "type": "386" }, { "name": "id", @@ -6335,7 +6466,7 @@ "variants": [ { "case": "s390x", - "type": "422" + "type": "425" }, { "case": "aarch64", @@ -6470,11 +6601,11 @@ { "name": "props", "default": null, - "type": "420" + "type": "423" }, { "name": "target", - "type": "421" + "type": "424" } ], "meta-type": "object" @@ -6545,7 +6676,7 @@ "members": [ { "name": "arch", - "type": "421" + "type": "424" } ], "meta-type": "object" @@ -6669,7 +6800,7 @@ }, { "name": "policy", - "type": "423" + "type": "426" } ], "meta-type": "object" @@ -6692,7 +6823,7 @@ }, { "name": "props", - "type": "420" + "type": "423" }, { "name": "qom-path", @@ -6708,29 +6839,29 @@ "variants": [ { "case": "node", - "type": "425" + "type": "428" }, { "case": "dist", - "type": "426" + "type": "429" }, { "case": "cpu", - "type": "427" + "type": "430" }, { "case": "hmat-lb", - "type": "428" + "type": "431" }, { "case": "hmat-cache", - "type": "429" + "type": "432" } ], "members": [ { "name": "type", - "type": "424" + "type": "427" } ], "meta-type": "object" @@ -6791,29 +6922,29 @@ "variants": [ { "case": "dimm", - "type": "431" + "type": "434" }, { "case": "nvdimm", - "type": "431" + "type": "434" }, { "case": "virtio-pmem", - "type": "432" + "type": "435" }, { "case": "virtio-mem", - "type": "433" + "type": "436" }, { "case": "sgx-epc", - "type": "434" + "type": "437" } ], "members": [ { "name": "type", - "type": "430" + "type": "433" } ], "meta-type": "object" @@ -6852,36 +6983,46 @@ "meta-type": "object" }, { - "name": "207", + "name": "203", + "members": [ + { + "name": "human-readable-text", + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "208", "members": [ { "name": "type", - "type": "437" + "type": "440" }, { "name": "model", - "type": "435" + "type": "438" } ], "meta-type": "object" }, { - "name": "208", + "name": "209", "members": [ { "name": "model", - "type": "435" + "type": "438" } ], "meta-type": "object" }, { - "name": "[209]", - "element-type": "209", + "name": "[210]", + "element-type": "210", "meta-type": "array" }, { - "name": "209", + "name": "210", "members": [ { "name": "name", @@ -6918,11 +7059,11 @@ "meta-type": "object" }, { - "name": "210", + "name": "211", "members": [ { "name": "mode", - "type": "438" + "type": "441" }, { "name": "filename", @@ -6937,7 +7078,7 @@ "meta-type": "object" }, { - "name": "211", + "name": "212", "members": [ { "name": "icount", @@ -6947,7 +7088,7 @@ "meta-type": "object" }, { - "name": "212", + "name": "213", "members": [ { "name": "icount", @@ -6957,31 +7098,31 @@ "meta-type": "object" }, { - "name": "213", + "name": "214", "members": [ { "name": "instances", - "type": "[214]" + "type": "[215]" } ], "meta-type": "object" }, { - "name": "[214]", - "element-type": "214", + "name": "[215]", + "element-type": "215", "meta-type": "array" }, { - "name": "214", + "name": "215", "tag": "type", "variants": [ { "case": "block-node", - "type": "440" + "type": "443" }, { "case": "chardev", - "type": "441" + "type": "444" }, { "case": "migration", @@ -6991,13 +7132,13 @@ "members": [ { "name": "type", - "type": "439" + "type": "442" } ], "meta-type": "object" }, { - "name": "215", + "name": "216", "members": [ { "name": "protocol", @@ -7021,7 +7162,7 @@ "meta-type": "object" }, { - "name": "216", + "name": "217", "members": [ { "name": "name", @@ -7032,12 +7173,12 @@ "meta-type": "object" }, { - "name": "[217]", - "element-type": "217", + "name": "[218]", + "element-type": "218", "meta-type": "array" }, { - "name": "217", + "name": "218", "members": [ { "name": "id", @@ -7067,7 +7208,7 @@ "meta-type": "object" }, { - "name": "218", + "name": "219", "members": [ { "name": "command-line", @@ -7082,7 +7223,7 @@ "meta-type": "object" }, { - "name": "219", + "name": "220", "members": [ { "name": "fdname", @@ -7092,7 +7233,7 @@ "meta-type": "object" }, { - "name": "220", + "name": "221", "members": [ { "name": "fdname", @@ -7102,7 +7243,7 @@ "meta-type": "object" }, { - "name": "221", + "name": "222", "members": [ { "name": "fdset-id", @@ -7118,7 +7259,7 @@ "meta-type": "object" }, { - "name": "222", + "name": "223", "members": [ { "name": "fdset-id", @@ -7132,7 +7273,7 @@ "meta-type": "object" }, { - "name": "223", + "name": "224", "members": [ { "name": "fdset-id", @@ -7147,12 +7288,12 @@ "meta-type": "object" }, { - "name": "[224]", - "element-type": "224", + "name": "[225]", + "element-type": "225", "meta-type": "array" }, { - "name": "224", + "name": "225", "members": [ { "name": "fdset-id", @@ -7160,13 +7301,13 @@ }, { "name": "fds", - "type": "[442]" + "type": "[445]" } ], "meta-type": "object" }, { - "name": "225", + "name": "226", "members": [ { "name": "option", @@ -7177,12 +7318,12 @@ "meta-type": "object" }, { - "name": "[226]", - "element-type": "226", + "name": "[227]", + "element-type": "227", "meta-type": "array" }, { - "name": "226", + "name": "227", "members": [ { "name": "option", @@ -7190,13 +7331,13 @@ }, { "name": "parameters", - "type": "[443]" + "type": "[446]" } ], "meta-type": "object" }, { - "name": "227", + "name": "228", "members": [ { "name": "offset", @@ -7206,7 +7347,7 @@ "meta-type": "object" }, { - "name": "228", + "name": "229", "members": [ { "name": "enabled", @@ -7230,7 +7371,7 @@ }, { "name": "state", - "type": "444" + "type": "447" }, { "name": "handle", @@ -7240,7 +7381,7 @@ "meta-type": "object" }, { - "name": "229", + "name": "230", "members": [ { "name": "data", @@ -7250,7 +7391,7 @@ "meta-type": "object" }, { - "name": "230", + "name": "231", "members": [ { "name": "pdh", @@ -7272,7 +7413,7 @@ "meta-type": "object" }, { - "name": "231", + "name": "232", "members": [ { "name": "packet-header", @@ -7291,7 +7432,7 @@ "meta-type": "object" }, { - "name": "232", + "name": "233", "members": [ { "name": "mnonce", @@ -7301,7 +7442,7 @@ "meta-type": "object" }, { - "name": "233", + "name": "234", "members": [ { "name": "data", @@ -7311,7 +7452,7 @@ "meta-type": "object" }, { - "name": "236", + "name": "237", "members": [ { "name": "sgx", @@ -7337,12 +7478,12 @@ "meta-type": "object" }, { - "name": "[237]", - "element-type": "237", + "name": "[238]", + "element-type": "238", "meta-type": "array" }, { - "name": "237", + "name": "238", "members": [ { "name": "device", @@ -7355,7 +7496,7 @@ }, { "name": "slot-type", - "type": "445" + "type": "448" }, { "name": "source", @@ -7369,22 +7510,22 @@ "meta-type": "object" }, { - "name": "238", + "name": "239", "members": [ { "name": "info", - "type": "237" + "type": "238" } ], "meta-type": "object" }, { - "name": "[239]", - "element-type": "239", + "name": "[240]", + "element-type": "240", "meta-type": "array" }, { - "name": "239", + "name": "240", "members": [ { "name": "bus", @@ -7392,7 +7533,7 @@ }, { "name": "devices", - "type": "[446]" + "type": "[449]" } ], "meta-type": "object" @@ -7403,7 +7544,7 @@ "meta-type": "builtin" }, { - "name": "240", + "name": "241", "members": [ { "name": "debug" @@ -7475,7 +7616,7 @@ ] }, { - "name": "241", + "name": "242", "members": [ { "name": "none" @@ -7523,7 +7664,7 @@ ] }, { - "name": "242", + "name": "243", "members": [ { "name": "reset" @@ -7559,7 +7700,7 @@ ] }, { - "name": "243", + "name": "244", "members": [ { "name": "reset" @@ -7575,7 +7716,7 @@ ] }, { - "name": "244", + "name": "245", "members": [ { "name": "poweroff" @@ -7591,7 +7732,7 @@ ] }, { - "name": "245", + "name": "246", "members": [ { "name": "pause" @@ -7611,7 +7752,7 @@ ] }, { - "name": "246", + "name": "247", "members": [ { "name": "pause" @@ -7631,28 +7772,28 @@ ] }, { - "name": "247", + "name": "248", "tag": "type", "variants": [ { "case": "hyper-v", - "type": "448" + "type": "451" }, { "case": "s390", - "type": "449" + "type": "452" } ], "members": [ { "name": "type", - "type": "447" + "type": "450" } ], "meta-type": "object" }, { - "name": "248", + "name": "249", "members": [ { "name": "hypervisor" @@ -7668,7 +7809,7 @@ ] }, { - "name": "249", + "name": "250", "members": [ { "name": "ignore" @@ -7692,7 +7833,7 @@ ] }, { - "name": "250", + "name": "251", "members": [ { "name": "action-required", @@ -7706,7 +7847,7 @@ "meta-type": "object" }, { - "name": "251", + "name": "252", "members": [ { "name": "retain" @@ -7736,7 +7877,7 @@ "meta-type": "array" }, { - "name": "252", + "name": "253", "members": [ { "name": "ok" @@ -7756,7 +7897,7 @@ ] }, { - "name": "253", + "name": "254", "members": [ { "name": "rd_bytes", @@ -7865,41 +8006,41 @@ }, { "name": "timed_stats", - "type": "[450]" + "type": "[453]" }, { "name": "rd_latency_histogram", "default": null, - "type": "451" + "type": "454" }, { "name": "wr_latency_histogram", "default": null, - "type": "451" + "type": "454" }, { "name": "flush_latency_histogram", "default": null, - "type": "451" + "type": "454" } ], "meta-type": "object" }, { - "name": "254", + "name": "255", "tag": "driver", "variants": [ { "case": "file", - "type": "452" + "type": "455" }, { "case": "host_device", - "type": "452" + "type": "455" }, { "case": "nvme", - "type": "453" + "type": "456" }, { "case": "blkdebug", @@ -8057,13 +8198,13 @@ "members": [ { "name": "driver", - "type": "269" + "type": "270" } ], "meta-type": "object" }, { - "name": "255", + "name": "256", "members": [ { "name": "undefined" @@ -8115,7 +8256,7 @@ ] }, { - "name": "256", + "name": "257", "members": [ { "name": "existing" @@ -8131,7 +8272,7 @@ ] }, { - "name": "257", + "name": "258", "members": [ { "name": "report" @@ -8159,7 +8300,7 @@ ] }, { - "name": "258", + "name": "259", "members": [ { "name": "top" @@ -8187,7 +8328,7 @@ ] }, { - "name": "259", + "name": "260", "members": [ { "name": "on-success" @@ -8207,7 +8348,7 @@ ] }, { - "name": "260", + "name": "261", "members": [ { "name": "use-copy-range", @@ -8228,7 +8369,7 @@ "meta-type": "object" }, { - "name": "261", + "name": "262", "members": [ { "name": "off" @@ -8248,7 +8389,7 @@ ] }, { - "name": "262", + "name": "263", "members": [ { "name": "filename", @@ -8310,18 +8451,18 @@ { "name": "backing-image", "default": null, - "type": "262" + "type": "263" }, { "name": "format-specific", "default": null, - "type": "454" + "type": "457" } ], "meta-type": "object" }, { - "name": "263", + "name": "264", "members": [ { "name": "writeback", @@ -8339,12 +8480,12 @@ "meta-type": "object" }, { - "name": "[264]", - "element-type": "264", + "name": "[265]", + "element-type": "265", "meta-type": "array" }, { - "name": "264", + "name": "265", "members": [ { "name": "name", @@ -8380,12 +8521,12 @@ "meta-type": "object" }, { - "name": "[265]", - "element-type": "265", + "name": "[266]", + "element-type": "266", "meta-type": "array" }, { - "name": "265", + "name": "266", "members": [ { "name": "id", @@ -8393,7 +8534,7 @@ }, { "name": "type", - "type": "455" + "type": "458" }, { "name": "name", @@ -8403,12 +8544,12 @@ "meta-type": "object" }, { - "name": "[266]", - "element-type": "266", + "name": "[267]", + "element-type": "267", "meta-type": "array" }, { - "name": "266", + "name": "267", "members": [ { "name": "parent", @@ -8424,17 +8565,17 @@ }, { "name": "perm", - "type": "[456]" + "type": "[459]" }, { "name": "shared-perm", - "type": "[456]" + "type": "[459]" } ], "meta-type": "object" }, { - "name": "267", + "name": "268", "members": [ { "name": "background" @@ -8450,12 +8591,12 @@ ] }, { - "name": "[268]", - "element-type": "268", + "name": "[269]", + "element-type": "269", "meta-type": "array" }, { - "name": "268", + "name": "269", "members": [ { "type": "str" @@ -8467,7 +8608,7 @@ "meta-type": "alternate" }, { - "name": "269", + "name": "270", "members": [ { "name": "blkdebug" @@ -8639,7 +8780,7 @@ ] }, { - "name": "270", + "name": "271", "members": [ { "name": "ignore" @@ -8655,7 +8796,7 @@ ] }, { - "name": "271", + "name": "272", "members": [ { "name": "direct", @@ -8671,11 +8812,11 @@ "meta-type": "object" }, { - "name": "272", + "name": "273", "members": [ { "name": "image", - "type": "457" + "type": "460" }, { "name": "config", @@ -8715,36 +8856,36 @@ { "name": "inject-error", "default": null, - "type": "[458]" + "type": "[461]" }, { "name": "set-state", "default": null, - "type": "[459]" + "type": "[462]" }, { "name": "take-child-perms", "default": null, - "type": "[456]" + "type": "[459]" }, { "name": "unshare-child-perms", "default": null, - "type": "[456]" + "type": "[459]" } ], "meta-type": "object" }, { - "name": "273", + "name": "274", "members": [ { "name": "file", - "type": "457" + "type": "460" }, { "name": "log", - "type": "457" + "type": "460" }, { "name": "log-sector-size", @@ -8765,59 +8906,59 @@ "meta-type": "object" }, { - "name": "274", + "name": "275", "members": [ { "name": "test", - "type": "457" + "type": "460" }, { "name": "raw", - "type": "457" + "type": "460" } ], "meta-type": "object" }, { - "name": "275", + "name": "276", "members": [ { "name": "image", - "type": "457" + "type": "460" } ], "meta-type": "object" }, { - "name": "276", + "name": "277", "members": [ { "name": "file", - "type": "457" + "type": "460" } ], "meta-type": "object" }, { - "name": "277", + "name": "278", "members": [ { "name": "file", - "type": "457" + "type": "460" }, { "name": "target", - "type": "457" + "type": "460" } ], "meta-type": "object" }, { - "name": "278", + "name": "279", "members": [ { "name": "file", - "type": "457" + "type": "460" }, { "name": "bottom", @@ -8828,7 +8969,7 @@ "meta-type": "object" }, { - "name": "279", + "name": "280", "members": [ { "name": "filename", @@ -8842,12 +8983,17 @@ { "name": "locking", "default": null, - "type": "460" + "type": "463" }, { "name": "aio", "default": null, - "type": "461" + "type": "464" + }, + { + "name": "aio-max-batch", + "default": null, + "type": "int" }, { "name": "drop-cache", @@ -8857,7 +9003,10 @@ { "name": "x-check-cache-dropped", "default": null, - "type": "bool" + "type": "bool", + "features": [ + "unstable" + ] } ], "meta-type": "object", @@ -8866,7 +9015,7 @@ ] }, { - "name": "280", + "name": "281", "members": [ { "name": "url", @@ -8906,7 +9055,7 @@ "meta-type": "object" }, { - "name": "281", + "name": "282", "members": [ { "name": "url", @@ -8951,7 +9100,7 @@ "meta-type": "object" }, { - "name": "282", + "name": "283", "members": [ { "name": "volume", @@ -8963,7 +9112,7 @@ }, { "name": "server", - "type": "[363]" + "type": "[364]" }, { "name": "debug", @@ -8979,7 +9128,7 @@ "meta-type": "object" }, { - "name": "283", + "name": "284", "members": [ { "name": "url", @@ -9029,7 +9178,7 @@ "meta-type": "object" }, { - "name": "284", + "name": "285", "members": [ { "name": "url", @@ -9084,11 +9233,11 @@ "meta-type": "object" }, { - "name": "285", + "name": "286", "members": [ { "name": "transport", - "type": "462" + "type": "465" }, { "name": "portal", @@ -9121,7 +9270,7 @@ { "name": "header-digest", "default": null, - "type": "463" + "type": "466" }, { "name": "timeout", @@ -9132,11 +9281,11 @@ "meta-type": "object" }, { - "name": "286", + "name": "287", "members": [ { "name": "file", - "type": "457" + "type": "460" }, { "name": "key-secret", @@ -9147,11 +9296,11 @@ "meta-type": "object" }, { - "name": "287", + "name": "288", "members": [ { "name": "server", - "type": "363" + "type": "364" }, { "name": "export", @@ -9166,7 +9315,10 @@ { "name": "x-dirty-bitmap", "default": null, - "type": "str" + "type": "str", + "features": [ + "unstable" + ] }, { "name": "reconnect-delay", @@ -9177,11 +9329,11 @@ "meta-type": "object" }, { - "name": "288", + "name": "289", "members": [ { "name": "server", - "type": "464" + "type": "467" }, { "name": "path", @@ -9221,7 +9373,7 @@ "meta-type": "object" }, { - "name": "289", + "name": "290", "members": [ { "name": "size", @@ -9242,7 +9394,7 @@ "meta-type": "object" }, { - "name": "290", + "name": "291", "members": [ { "name": "device", @@ -9256,11 +9408,11 @@ "meta-type": "object" }, { - "name": "291", + "name": "292", "members": [ { "name": "file", - "type": "457" + "type": "460" }, { "name": "prealloc-align", @@ -9276,16 +9428,16 @@ "meta-type": "object" }, { - "name": "292", + "name": "293", "members": [ { "name": "file", - "type": "457" + "type": "460" }, { "name": "backing", "default": null, - "type": "465" + "type": "468" }, { "name": "lazy-refcounts", @@ -9310,7 +9462,7 @@ { "name": "overlap-check", "default": null, - "type": "466" + "type": "469" }, { "name": "cache-size", @@ -9340,53 +9492,53 @@ { "name": "encrypt", "default": null, - "type": "467" + "type": "470" }, { "name": "data-file", "default": null, - "type": "457" + "type": "460" } ], "meta-type": "object" }, { - "name": "293", + "name": "294", "members": [ { "name": "file", - "type": "457" + "type": "460" }, { "name": "backing", "default": null, - "type": "465" + "type": "468" }, { "name": "encrypt", "default": null, - "type": "468" + "type": "471" } ], "meta-type": "object" }, { - "name": "294", + "name": "295", "members": [ { "name": "file", - "type": "457" + "type": "460" }, { "name": "backing", "default": null, - "type": "465" + "type": "468" } ], "meta-type": "object" }, { - "name": "295", + "name": "296", "members": [ { "name": "blkverify", @@ -9395,7 +9547,7 @@ }, { "name": "children", - "type": "[457]" + "type": "[460]" }, { "name": "vote-threshold", @@ -9409,17 +9561,17 @@ { "name": "read-pattern", "default": null, - "type": "469" + "type": "472" } ], "meta-type": "object" }, { - "name": "296", + "name": "297", "members": [ { "name": "file", - "type": "457" + "type": "460" }, { "name": "offset", @@ -9435,7 +9587,7 @@ "meta-type": "object" }, { - "name": "297", + "name": "298", "members": [ { "name": "pool", @@ -9463,7 +9615,7 @@ { "name": "encrypt", "default": null, - "type": "470" + "type": "473" }, { "name": "user", @@ -9473,7 +9625,7 @@ { "name": "auth-client-required", "default": null, - "type": "[471]" + "type": "[474]" }, { "name": "key-secret", @@ -9483,21 +9635,21 @@ { "name": "server", "default": null, - "type": "[472]" + "type": "[475]" } ], "meta-type": "object" }, { - "name": "298", + "name": "299", "members": [ { "name": "file", - "type": "457" + "type": "460" }, { "name": "mode", - "type": "473" + "type": "476" }, { "name": "top-id", @@ -9508,11 +9660,11 @@ "meta-type": "object" }, { - "name": "299", + "name": "300", "members": [ { "name": "server", - "type": "474" + "type": "477" }, { "name": "path", @@ -9526,13 +9678,13 @@ { "name": "host-key-check", "default": null, - "type": "475" + "type": "478" } ], "meta-type": "object" }, { - "name": "300", + "name": "301", "members": [ { "name": "throttle-group", @@ -9540,13 +9692,13 @@ }, { "name": "file", - "type": "457" + "type": "460" } ], "meta-type": "object" }, { - "name": "301", + "name": "302", "members": [ { "name": "dir", @@ -9581,64 +9733,64 @@ "meta-type": "array" }, { - "name": "302", + "name": "303", "tag": "driver", "variants": [ { "case": "file", - "type": "476" + "type": "479" }, { "case": "gluster", - "type": "477" + "type": "480" }, { "case": "luks", - "type": "478" + "type": "481" }, { "case": "nfs", - "type": "479" + "type": "482" }, { "case": "parallels", - "type": "480" + "type": "483" }, { "case": "qcow", - "type": "481" + "type": "484" }, { "case": "qcow2", - "type": "482" + "type": "485" }, { "case": "qed", - "type": "483" + "type": "486" }, { "case": "rbd", - "type": "484" + "type": "487" }, { "case": "ssh", - "type": "485" + "type": "488" }, { "case": "vdi", - "type": "486" + "type": "489" }, { "case": "vhdx", - "type": "487" + "type": "490" }, { "case": "vmdk", - "type": "488" + "type": "491" }, { "case": "vpc", - "type": "489" + "type": "492" }, { "case": "blkdebug", @@ -9752,22 +9904,22 @@ "members": [ { "name": "driver", - "type": "269" + "type": "270" } ], "meta-type": "object" }, { - "name": "303", + "name": "304", "tag": "driver", "variants": [ { "case": "luks", - "type": "490" + "type": "493" }, { "case": "qcow2", - "type": "491" + "type": "494" }, { "case": "blkdebug", @@ -9929,13 +10081,13 @@ "members": [ { "name": "driver", - "type": "269" + "type": "270" } ], "meta-type": "object" }, { - "name": "304", + "name": "305", "members": [ { "name": "read" @@ -9951,7 +10103,7 @@ ] }, { - "name": "305", + "name": "306", "members": [ { "name": "ignore" @@ -9971,7 +10123,7 @@ ] }, { - "name": "306", + "name": "307", "members": [ { "name": "commit" @@ -10015,7 +10167,7 @@ ] }, { - "name": "307", + "name": "308", "members": [ { "type": "str" @@ -10027,7 +10179,7 @@ "meta-type": "alternate" }, { - "name": "308", + "name": "309", "members": [ { "name": "read" @@ -10047,36 +10199,36 @@ ] }, { - "name": "309", + "name": "310", "tag": "type", "variants": [ { "case": "inet", - "type": "493" + "type": "496" }, { "case": "unix", - "type": "494" + "type": "497" }, { "case": "vsock", - "type": "495" + "type": "498" }, { "case": "fd", - "type": "496" + "type": "499" } ], "members": [ { "name": "type", - "type": "492" + "type": "495" } ], "meta-type": "object" }, { - "name": "310", + "name": "311", "members": [ { "name": "safe" @@ -10092,7 +10244,7 @@ ] }, { - "name": "311", + "name": "312", "members": [ { "name": "nbd" @@ -10108,7 +10260,7 @@ ] }, { - "name": "312", + "name": "313", "members": [ { "name": "name", @@ -10134,11 +10286,11 @@ "meta-type": "object" }, { - "name": "313", + "name": "314", "members": [ { "name": "addr", - "type": "363" + "type": "364" }, { "name": "logical-block-size", @@ -10154,7 +10306,7 @@ "meta-type": "object" }, { - "name": "315", + "name": "316", "members": [ { "name": "utf8" @@ -10170,104 +10322,104 @@ ] }, { - "name": "316", + "name": "317", "tag": "type", "variants": [ { "case": "file", - "type": "499" + "type": "502" }, { "case": "serial", - "type": "500" + "type": "503" }, { "case": "parallel", - "type": "500" + "type": "503" }, { "case": "pipe", - "type": "500" + "type": "503" }, { "case": "socket", - "type": "501" + "type": "504" }, { "case": "udp", - "type": "502" + "type": "505" }, { "case": "pty", - "type": "503" + "type": "506" }, { "case": "null", - "type": "503" + "type": "506" }, { "case": "mux", - "type": "504" + "type": "507" }, { "case": "msmouse", - "type": "503" + "type": "506" }, { "case": "wctablet", - "type": "503" + "type": "506" }, { "case": "braille", - "type": "503" + "type": "506" }, { "case": "testdev", - "type": "503" + "type": "506" }, { "case": "stdio", - "type": "505" + "type": "508" }, { "case": "console", - "type": "503" + "type": "506" }, { "case": "spicevmc", - "type": "506" + "type": "509" }, { "case": "spiceport", - "type": "507" + "type": "510" }, { "case": "qemu-vdagent", - "type": "508" + "type": "511" }, { "case": "vc", - "type": "509" + "type": "512" }, { "case": "ringbuf", - "type": "510" + "type": "513" }, { "case": "memory", - "type": "510" + "type": "513" } ], "members": [ { "name": "type", - "type": "498" + "type": "501" } ], "meta-type": "object" }, { - "name": "317", + "name": "318", "members": [ { "name": "elf" @@ -10295,7 +10447,7 @@ ] }, { - "name": "318", + "name": "319", "members": [ { "name": "none" @@ -10319,12 +10471,12 @@ ] }, { - "name": "[317]", - "element-type": "317", + "name": "[318]", + "element-type": "318", "meta-type": "array" }, { - "name": "319", + "name": "320", "members": [ { "name": "none" @@ -10380,7 +10532,7 @@ ] }, { - "name": "320", + "name": "321", "members": [ { "name": "netdev", @@ -10411,7 +10563,7 @@ "meta-type": "object" }, { - "name": "321", + "name": "322", "members": [ { "name": "hostname", @@ -10471,7 +10623,7 @@ { "name": "dnssearch", "default": null, - "type": "[511]" + "type": "[514]" }, { "name": "domainname", @@ -10511,12 +10663,12 @@ { "name": "hostfwd", "default": null, - "type": "[511]" + "type": "[514]" }, { "name": "guestfwd", "default": null, - "type": "[511]" + "type": "[514]" }, { "name": "tftp-server-name", @@ -10527,7 +10679,7 @@ "meta-type": "object" }, { - "name": "322", + "name": "323", "members": [ { "name": "ifname", @@ -10608,7 +10760,7 @@ "meta-type": "object" }, { - "name": "323", + "name": "324", "members": [ { "name": "src", @@ -10681,7 +10833,7 @@ "meta-type": "object" }, { - "name": "324", + "name": "325", "members": [ { "name": "fd", @@ -10717,7 +10869,7 @@ "meta-type": "object" }, { - "name": "325", + "name": "326", "members": [ { "name": "sock", @@ -10743,7 +10895,7 @@ "meta-type": "object" }, { - "name": "326", + "name": "327", "members": [ { "name": "br", @@ -10759,7 +10911,7 @@ "meta-type": "object" }, { - "name": "327", + "name": "328", "members": [ { "name": "hubid", @@ -10774,7 +10926,7 @@ "meta-type": "object" }, { - "name": "328", + "name": "329", "members": [ { "name": "ifname", @@ -10789,7 +10941,7 @@ "meta-type": "object" }, { - "name": "329", + "name": "330", "members": [ { "name": "chardev", @@ -10809,7 +10961,7 @@ "meta-type": "object" }, { - "name": "330", + "name": "331", "members": [ { "name": "vhostdev", @@ -10825,7 +10977,7 @@ "meta-type": "object" }, { - "name": "331", + "name": "332", "members": [ { "name": "normal" @@ -10850,7 +11002,7 @@ "meta-type": "array" }, { - "name": "332", + "name": "333", "members": [ { "name": "half" @@ -10866,7 +11018,7 @@ ] }, { - "name": "333", + "name": "334", "members": [ { "name": "off" @@ -10882,7 +11034,7 @@ ] }, { - "name": "334", + "name": "335", "members": [ { "name": "priority", @@ -10941,7 +11093,7 @@ "meta-type": "object" }, { - "name": "335", + "name": "336", "members": [ { "name": "in-pport", @@ -10982,7 +11134,7 @@ "meta-type": "object" }, { - "name": "336", + "name": "337", "members": [ { "name": "goto-tbl", @@ -11018,16 +11170,16 @@ "meta-type": "object" }, { - "name": "337", + "name": "338", "tag": "type", "variants": [ { "case": "passthrough", - "type": "512" + "type": "515" }, { "case": "emulator", - "type": "513" + "type": "516" } ], "members": [ @@ -11039,7 +11191,7 @@ "meta-type": "object" }, { - "name": "338", + "name": "339", "members": [ { "name": "client" @@ -11059,12 +11211,12 @@ ] }, { - "name": "[339]", - "element-type": "339", + "name": "[340]", + "element-type": "340", "meta-type": "array" }, { - "name": "339", + "name": "340", "members": [ { "name": "host", @@ -11076,7 +11228,7 @@ }, { "name": "family", - "type": "342" + "type": "343" }, { "name": "connection-id", @@ -11098,7 +11250,7 @@ "meta-type": "object" }, { - "name": "340", + "name": "341", "members": [ { "name": "host", @@ -11110,13 +11262,13 @@ }, { "name": "family", - "type": "342" + "type": "343" } ], "meta-type": "object" }, { - "name": "341", + "name": "342", "members": [ { "name": "host", @@ -11128,7 +11280,7 @@ }, { "name": "family", - "type": "342" + "type": "343" }, { "name": "auth", @@ -11139,7 +11291,7 @@ "meta-type": "object" }, { - "name": "342", + "name": "343", "members": [ { "name": "ipv4" @@ -11167,12 +11319,12 @@ ] }, { - "name": "[343]", - "element-type": "343", + "name": "[344]", + "element-type": "344", "meta-type": "array" }, { - "name": "343", + "name": "344", "members": [ { "name": "host", @@ -11184,7 +11336,7 @@ }, { "name": "family", - "type": "342" + "type": "343" }, { "name": "websocket", @@ -11204,12 +11356,12 @@ "meta-type": "object" }, { - "name": "[344]", - "element-type": "344", + "name": "[345]", + "element-type": "345", "meta-type": "array" }, { - "name": "344", + "name": "345", "members": [ { "name": "host", @@ -11221,7 +11373,7 @@ }, { "name": "family", - "type": "342" + "type": "343" }, { "name": "websocket", @@ -11229,18 +11381,18 @@ }, { "name": "auth", - "type": "345" + "type": "346" }, { "name": "vencrypt", "default": null, - "type": "346" + "type": "347" } ], "meta-type": "object" }, { - "name": "345", + "name": "346", "members": [ { "name": "none" @@ -11284,7 +11436,7 @@ ] }, { - "name": "346", + "name": "347", "members": [ { "name": "plain" @@ -11328,7 +11480,7 @@ ] }, { - "name": "347", + "name": "348", "members": [ { "name": "host", @@ -11340,7 +11492,7 @@ }, { "name": "family", - "type": "342" + "type": "343" }, { "name": "websocket", @@ -11355,7 +11507,7 @@ "meta-type": "object" }, { - "name": "348", + "name": "349", "members": [ { "name": "host", @@ -11367,7 +11519,7 @@ }, { "name": "family", - "type": "342" + "type": "343" }, { "name": "websocket", @@ -11377,67 +11529,67 @@ "meta-type": "object" }, { - "name": "[349]", - "element-type": "349", + "name": "[350]", + "element-type": "350", "meta-type": "array" }, { - "name": "349", + "name": "350", "tag": "type", "variants": [ { "case": "number", - "type": "515" + "type": "518" }, { "case": "qcode", - "type": "516" + "type": "519" } ], "members": [ { "name": "type", - "type": "514" + "type": "517" } ], "meta-type": "object" }, { - "name": "[350]", - "element-type": "350", + "name": "[351]", + "element-type": "351", "meta-type": "array" }, { - "name": "350", + "name": "351", "tag": "type", "variants": [ { "case": "key", - "type": "518" + "type": "521" }, { "case": "btn", - "type": "519" + "type": "522" }, { "case": "rel", - "type": "520" + "type": "523" }, { "case": "abs", - "type": "520" + "type": "523" } ], "members": [ { "name": "type", - "type": "517" + "type": "520" } ], "meta-type": "object" }, { - "name": "351", + "name": "352", "members": [ { "name": "default" @@ -11469,7 +11621,7 @@ ] }, { - "name": "352", + "name": "353", "members": [ { "name": "off" @@ -11493,7 +11645,7 @@ ] }, { - "name": "353", + "name": "354", "members": [ { "name": "grab-on-hover", @@ -11509,7 +11661,7 @@ "meta-type": "object" }, { - "name": "354", + "name": "355", "members": [ { "name": "charset", @@ -11520,7 +11672,7 @@ "meta-type": "object" }, { - "name": "355", + "name": "356", "members": [ { "name": "rendernode", @@ -11531,7 +11683,7 @@ "meta-type": "object" }, { - "name": "356", + "name": "357", "members": [ { "name": "vnc" @@ -11543,7 +11695,7 @@ ] }, { - "name": "357", + "name": "358", "members": [ { "name": "tls-certs", @@ -11554,7 +11706,7 @@ "meta-type": "object" }, { - "name": "358", + "name": "359", "members": [ { "name": "none" @@ -11618,7 +11770,7 @@ ] }, { - "name": "359", + "name": "360", "members": [ { "name": "transferred", @@ -11680,7 +11832,7 @@ "meta-type": "object" }, { - "name": "360", + "name": "361", "members": [ { "name": "transferred", @@ -11690,7 +11842,7 @@ "meta-type": "object" }, { - "name": "361", + "name": "362", "members": [ { "name": "cache-size", @@ -11724,7 +11876,7 @@ "meta-type": "object" }, { - "name": "362", + "name": "363", "members": [ { "name": "pages", @@ -11750,41 +11902,41 @@ "meta-type": "object" }, { - "name": "[363]", - "element-type": "363", + "name": "[364]", + "element-type": "364", "meta-type": "array" }, { - "name": "363", + "name": "364", "tag": "type", "variants": [ { "case": "inet", - "type": "474" + "type": "477" }, { "case": "unix", - "type": "521" + "type": "524" }, { "case": "vsock", - "type": "522" + "type": "525" }, { "case": "fd", - "type": "511" + "type": "514" } ], "members": [ { "name": "type", - "type": "492" + "type": "495" } ], "meta-type": "object" }, { - "name": "364", + "name": "365", "members": [ { "name": "xbzrle" @@ -11808,7 +11960,10 @@ "name": "postcopy-ram" }, { - "name": "x-colo" + "name": "x-colo", + "features": [ + "unstable" + ] }, { "name": "release-ram" @@ -11835,7 +11990,10 @@ "name": "late-block-activate" }, { - "name": "x-ignore-shared" + "name": "x-ignore-shared", + "features": [ + "unstable" + ] }, { "name": "validate-uuid" @@ -11868,7 +12026,7 @@ ] }, { - "name": "365", + "name": "366", "members": [ { "name": "none" @@ -11888,12 +12046,12 @@ ] }, { - "name": "[366]", - "element-type": "366", + "name": "[367]", + "element-type": "367", "meta-type": "array" }, { - "name": "366", + "name": "367", "members": [ { "name": "node-name", @@ -11905,13 +12063,13 @@ }, { "name": "bitmaps", - "type": "[523]" + "type": "[526]" } ], "meta-type": "object" }, { - "name": "367", + "name": "368", "members": [ { "name": "none" @@ -11931,7 +12089,7 @@ ] }, { - "name": "368", + "name": "369", "members": [ { "name": "none" @@ -11955,7 +12113,27 @@ ] }, { - "name": "369", + "name": "370", + "members": [ + { + "name": "page-sampling" + }, + { + "name": "dirty-ring" + }, + { + "name": "dirty-bitmap" + } + ], + "meta-type": "enum", + "values": [ + "page-sampling", + "dirty-ring", + "dirty-bitmap" + ] + }, + { + "name": "371", "members": [ { "name": "unstarted" @@ -11975,84 +12153,103 @@ ] }, { - "name": "[370]", - "element-type": "370", + "name": "[372]", + "element-type": "372", "meta-type": "array" }, { - "name": "370", + "name": "372", + "members": [ + { + "name": "id", + "type": "int" + }, + { + "name": "dirty-rate", + "type": "int" + } + ], + "meta-type": "object" + }, + { + "name": "[373]", + "element-type": "373", + "meta-type": "array" + }, + { + "name": "373", "tag": "type", "variants": [ { "case": "abort", - "type": "525" + "type": "528" }, { "case": "block-dirty-bitmap-add", - "type": "526" + "type": "529" }, { "case": "block-dirty-bitmap-remove", - "type": "527" + "type": "530" }, { "case": "block-dirty-bitmap-clear", - "type": "527" + "type": "530" }, { "case": "block-dirty-bitmap-enable", - "type": "527" + "type": "530" }, { "case": "block-dirty-bitmap-disable", - "type": "527" + "type": "530" }, { "case": "block-dirty-bitmap-merge", - "type": "528" + "type": "531" }, { "case": "blockdev-backup", - "type": "529" + "type": "532" }, { "case": "blockdev-snapshot", - "type": "530" + "type": "533" }, { "case": "blockdev-snapshot-internal-sync", - "type": "531" + "type": "534" }, { "case": "blockdev-snapshot-sync", - "type": "532" + "type": "535" }, { "case": "drive-backup", - "type": "533" + "type": "536" } ], "members": [ { "name": "type", - "type": "524" + "type": "527" } ], "meta-type": "object" }, { - "name": "371", + "name": "374", "members": [ { "name": "completion-mode", "default": null, - "type": "534" + "type": "537" } ], "meta-type": "object" }, { - "name": "372", + "name": "375", "members": [ { "name": "unavailable" @@ -12072,12 +12269,12 @@ ] }, { - "name": "[373]", - "element-type": "373", + "name": "[376]", + "element-type": "376", "meta-type": "array" }, { - "name": "373", + "name": "376", "members": [ { "name": "oob" @@ -12089,7 +12286,7 @@ ] }, { - "name": "374", + "name": "377", "members": [ { "name": "major", @@ -12107,7 +12304,7 @@ "meta-type": "object" }, { - "name": "375", + "name": "378", "members": [ { "name": "builtin" @@ -12143,21 +12340,21 @@ ] }, { - "name": "376", + "name": "379", "members": [ { "name": "json-type", - "type": "535" + "type": "538" } ], "meta-type": "object" }, { - "name": "377", + "name": "380", "members": [ { "name": "members", - "type": "[536]" + "type": "[539]" }, { "name": "values", @@ -12170,7 +12367,7 @@ "meta-type": "object" }, { - "name": "378", + "name": "381", "members": [ { "name": "element-type", @@ -12180,11 +12377,11 @@ "meta-type": "object" }, { - "name": "379", + "name": "382", "members": [ { "name": "members", - "type": "[537]" + "type": "[540]" }, { "name": "tag", @@ -12194,23 +12391,23 @@ { "name": "variants", "default": null, - "type": "[538]" + "type": "[541]" } ], "meta-type": "object" }, { - "name": "380", + "name": "383", "members": [ { "name": "members", - "type": "[539]" + "type": "[542]" } ], "meta-type": "object" }, { - "name": "381", + "name": "384", "members": [ { "name": "arg-type", @@ -12229,7 +12426,7 @@ "meta-type": "object" }, { - "name": "382", + "name": "385", "members": [ { "name": "arg-type", @@ -12239,7 +12436,7 @@ "meta-type": "object" }, { - "name": "383", + "name": "386", "members": [ { "name": "authz-list" @@ -12359,7 +12556,10 @@ "name": "tls-cipher-suites" }, { - "name": "x-remote-object" + "name": "x-remote-object", + "features": [ + "unstable" + ] } ], "meta-type": "enum", @@ -12407,23 +12607,23 @@ ] }, { - "name": "384", + "name": "387", "members": [ { "name": "policy", "default": null, - "type": "540" + "type": "543" }, { "name": "rules", "default": null, - "type": "[541]" + "type": "[544]" } ], "meta-type": "object" }, { - "name": "385", + "name": "388", "members": [ { "name": "filename", @@ -12438,7 +12638,7 @@ "meta-type": "object" }, { - "name": "386", + "name": "389", "members": [ { "name": "service", @@ -12448,7 +12648,7 @@ "meta-type": "object" }, { - "name": "387", + "name": "390", "members": [ { "name": "identity", @@ -12458,7 +12658,7 @@ "meta-type": "object" }, { - "name": "388", + "name": "391", "members": [ { "name": "if", @@ -12472,7 +12672,7 @@ "meta-type": "object" }, { - "name": "389", + "name": "392", "members": [ { "name": "primary_in", @@ -12519,7 +12719,7 @@ "meta-type": "object" }, { - "name": "390", + "name": "393", "members": [ { "name": "queues", @@ -12530,7 +12730,7 @@ "meta-type": "object" }, { - "name": "391", + "name": "394", "members": [ { "name": "queues", @@ -12545,7 +12745,7 @@ "meta-type": "object" }, { - "name": "392", + "name": "395", "members": [ { "name": "addr", @@ -12560,7 +12760,7 @@ "meta-type": "object" }, { - "name": "393", + "name": "396", "members": [ { "name": "netdev", @@ -12569,7 +12769,7 @@ { "name": "queue", "default": null, - "type": "542" + "type": "545" }, { "name": "status", @@ -12584,7 +12784,7 @@ { "name": "insert", "default": null, - "type": "543" + "type": "546" }, { "name": "interval", @@ -12594,7 +12794,7 @@ "meta-type": "object" }, { - "name": "394", + "name": "397", "members": [ { "name": "netdev", @@ -12603,7 +12803,7 @@ { "name": "queue", "default": null, - "type": "542" + "type": "545" }, { "name": "status", @@ -12618,7 +12818,7 @@ { "name": "insert", "default": null, - "type": "543" + "type": "546" }, { "name": "file", @@ -12633,7 +12833,7 @@ "meta-type": "object" }, { - "name": "395", + "name": "398", "members": [ { "name": "netdev", @@ -12642,7 +12842,7 @@ { "name": "queue", "default": null, - "type": "542" + "type": "545" }, { "name": "status", @@ -12657,7 +12857,7 @@ { "name": "insert", "default": null, - "type": "543" + "type": "546" }, { "name": "outdev", @@ -12672,7 +12872,7 @@ "meta-type": "object" }, { - "name": "396", + "name": "399", "members": [ { "name": "netdev", @@ -12681,7 +12881,7 @@ { "name": "queue", "default": null, - "type": "542" + "type": "545" }, { "name": "status", @@ -12696,7 +12896,7 @@ { "name": "insert", "default": null, - "type": "543" + "type": "546" }, { "name": "indev", @@ -12717,7 +12917,7 @@ "meta-type": "object" }, { - "name": "397", + "name": "400", "members": [ { "name": "netdev", @@ -12726,7 +12926,7 @@ { "name": "queue", "default": null, - "type": "542" + "type": "545" }, { "name": "status", @@ -12741,13 +12941,13 @@ { "name": "insert", "default": null, - "type": "543" + "type": "546" } ], "meta-type": "object" }, { - "name": "398", + "name": "401", "members": [ { "name": "netdev", @@ -12756,7 +12956,7 @@ { "name": "queue", "default": null, - "type": "542" + "type": "545" }, { "name": "status", @@ -12771,7 +12971,7 @@ { "name": "insert", "default": null, - "type": "543" + "type": "546" }, { "name": "vnet_hdr_support", @@ -12782,7 +12982,7 @@ "meta-type": "object" }, { - "name": "399", + "name": "402", "members": [ { "name": "name", @@ -12822,7 +13022,7 @@ "meta-type": "object" }, { - "name": "400", + "name": "403", "members": [ { "name": "evdev", @@ -12841,13 +13041,13 @@ { "name": "grab-toggle", "default": null, - "type": "544" + "type": "547" } ], "meta-type": "object" }, { - "name": "401", + "name": "404", "members": [ { "name": "poll-max-ns", @@ -12873,7 +13073,7 @@ "meta-type": "object" }, { - "name": "402", + "name": "405", "members": [ { "name": "dump", @@ -12893,7 +13093,7 @@ { "name": "policy", "default": null, - "type": "423" + "type": "426" }, { "name": "prealloc", @@ -12928,7 +13128,7 @@ "meta-type": "object" }, { - "name": "403", + "name": "406", "members": [ { "name": "dump", @@ -12948,7 +13148,7 @@ { "name": "policy", "default": null, - "type": "423" + "type": "426" }, { "name": "prealloc", @@ -13007,7 +13207,7 @@ "meta-type": "object" }, { - "name": "404", + "name": "407", "members": [ { "name": "dump", @@ -13027,7 +13227,7 @@ { "name": "policy", "default": null, - "type": "423" + "type": "426" }, { "name": "prealloc", @@ -13077,7 +13277,7 @@ "meta-type": "object" }, { - "name": "405", + "name": "408", "members": [ { "name": "dump", @@ -13097,7 +13297,7 @@ { "name": "policy", "default": null, - "type": "423" + "type": "426" }, { "name": "prealloc", @@ -13132,7 +13332,7 @@ "meta-type": "object" }, { - "name": "406", + "name": "409", "members": [ { "name": "path", @@ -13142,7 +13342,7 @@ "meta-type": "object" }, { - "name": "407", + "name": "410", "members": [ { "name": "chardev", @@ -13157,7 +13357,7 @@ "meta-type": "object" }, { - "name": "408", + "name": "411", "members": [ { "name": "opened", @@ -13171,7 +13371,7 @@ "meta-type": "object" }, { - "name": "409", + "name": "412", "members": [ { "name": "opened", @@ -13189,7 +13389,7 @@ "meta-type": "object" }, { - "name": "410", + "name": "413", "members": [ { "name": "opened", @@ -13208,7 +13408,7 @@ "meta-type": "object" }, { - "name": "411", + "name": "414", "members": [ { "name": "loaded", @@ -13221,7 +13421,7 @@ { "name": "format", "default": null, - "type": "545" + "type": "548" }, { "name": "keyid", @@ -13247,7 +13447,7 @@ "meta-type": "object" }, { - "name": "412", + "name": "415", "members": [ { "name": "loaded", @@ -13260,7 +13460,7 @@ { "name": "format", "default": null, - "type": "545" + "type": "548" }, { "name": "keyid", @@ -13280,7 +13480,7 @@ "meta-type": "object" }, { - "name": "413", + "name": "416", "members": [ { "name": "sev-device", @@ -13315,118 +13515,180 @@ { "name": "reduced-phys-bits", "type": "int" + }, + { + "name": "kernel-hashes", + "default": null, + "type": "bool" } ], "meta-type": "object" }, { - "name": "414", + "name": "417", "members": [ { "name": "limits", "default": null, - "type": "546" + "type": "549" }, { "name": "x-iops-total", "default": null, - "type": "int" + "type": "int", + "features": [ + "unstable" + ] }, { "name": "x-iops-total-max", "default": null, - "type": "int" + "type": "int", + "features": [ + "unstable" + ] }, { "name": "x-iops-total-max-length", "default": null, - "type": "int" + "type": "int", + "features": [ + "unstable" + ] }, { "name": "x-iops-read", "default": null, - "type": "int" + "type": "int", + "features": [ + "unstable" + ] }, { "name": "x-iops-read-max", "default": null, - "type": "int" + "type": "int", + "features": [ + "unstable" + ] }, { "name": "x-iops-read-max-length", "default": null, - "type": "int" + "type": "int", + "features": [ + "unstable" + ] }, { "name": "x-iops-write", "default": null, - "type": "int" + "type": "int", + "features": [ + "unstable" + ] }, { "name": "x-iops-write-max", "default": null, - "type": "int" + "type": "int", + "features": [ + "unstable" + ] }, { "name": "x-iops-write-max-length", "default": null, - "type": "int" + "type": "int", + "features": [ + "unstable" + ] }, { "name": "x-bps-total", "default": null, - "type": "int" + "type": "int", + "features": [ + "unstable" + ] }, { "name": "x-bps-total-max", "default": null, - "type": "int" + "type": "int", + "features": [ + "unstable" + ] }, { "name": "x-bps-total-max-length", "default": null, - "type": "int" + "type": "int", + "features": [ + "unstable" + ] }, { "name": "x-bps-read", "default": null, - "type": "int" + "type": "int", + "features": [ + "unstable" + ] }, { "name": "x-bps-read-max", "default": null, - "type": "int" + "type": "int", + "features": [ + "unstable" + ] }, { "name": "x-bps-read-max-length", "default": null, - "type": "int" + "type": "int", + "features": [ + "unstable" + ] }, { "name": "x-bps-write", "default": null, - "type": "int" + "type": "int", + "features": [ + "unstable" + ] }, { "name": "x-bps-write-max", "default": null, - "type": "int" + "type": "int", + "features": [ + "unstable" + ] }, { "name": "x-bps-write-max-length", "default": null, - "type": "int" + "type": "int", + "features": [ + "unstable" + ] }, { "name": "x-iops-size", "default": null, - "type": "int" + "type": "int", + "features": [ + "unstable" + ] } ], "meta-type": "object" }, { - "name": "415", + "name": "418", "members": [ { "name": "verify-peer", @@ -13441,7 +13703,7 @@ { "name": "endpoint", "default": null, - "type": "547" + "type": "550" }, { "name": "priority", @@ -13460,7 +13722,7 @@ "meta-type": "object" }, { - "name": "416", + "name": "419", "members": [ { "name": "verify-peer", @@ -13475,7 +13737,7 @@ { "name": "endpoint", "default": null, - "type": "547" + "type": "550" }, { "name": "priority", @@ -13499,7 +13761,7 @@ "meta-type": "object" }, { - "name": "417", + "name": "420", "members": [ { "name": "verify-peer", @@ -13514,7 +13776,7 @@ { "name": "endpoint", "default": null, - "type": "547" + "type": "550" }, { "name": "priority", @@ -13543,7 +13805,7 @@ "meta-type": "object" }, { - "name": "418", + "name": "421", "members": [ { "name": "verify-peer", @@ -13558,7 +13820,7 @@ { "name": "endpoint", "default": null, - "type": "547" + "type": "550" }, { "name": "priority", @@ -13569,7 +13831,7 @@ "meta-type": "object" }, { - "name": "419", + "name": "422", "members": [ { "name": "fd", @@ -13583,7 +13845,7 @@ "meta-type": "object" }, { - "name": "420", + "name": "423", "members": [ { "name": "node-id", @@ -13614,7 +13876,7 @@ "meta-type": "object" }, { - "name": "421", + "name": "424", "members": [ { "name": "aarch64" @@ -13742,17 +14004,17 @@ ] }, { - "name": "422", + "name": "425", "members": [ { "name": "cpu-state", - "type": "548" + "type": "551" } ], "meta-type": "object" }, { - "name": "423", + "name": "426", "members": [ { "name": "default" @@ -13776,7 +14038,7 @@ ] }, { - "name": "424", + "name": "427", "members": [ { "name": "node" @@ -13804,7 +14066,7 @@ ] }, { - "name": "425", + "name": "428", "members": [ { "name": "nodeid", @@ -13835,7 +14097,7 @@ "meta-type": "object" }, { - "name": "426", + "name": "429", "members": [ { "name": "src", @@ -13853,7 +14115,7 @@ "meta-type": "object" }, { - "name": "427", + "name": "430", "members": [ { "name": "node-id", @@ -13884,7 +14146,7 @@ "meta-type": "object" }, { - "name": "428", + "name": "431", "members": [ { "name": "initiator", @@ -13896,11 +14158,11 @@ }, { "name": "hierarchy", - "type": "549" + "type": "552" }, { "name": "data-type", - "type": "550" + "type": "553" }, { "name": "latency", @@ -13916,7 +14178,7 @@ "meta-type": "object" }, { - "name": "429", + "name": "432", "members": [ { "name": "node-id", @@ -13932,11 +14194,11 @@ }, { "name": "associativity", - "type": "551" + "type": "554" }, { "name": "policy", - "type": "552" + "type": "555" }, { "name": "line", @@ -13946,7 +14208,7 @@ "meta-type": "object" }, { - "name": "430", + "name": "433", "members": [ { "name": "dimm" @@ -13974,47 +14236,47 @@ ] }, { - "name": "431", + "name": "434", "members": [ { "name": "data", - "type": "553" + "type": "556" } ], "meta-type": "object" }, { - "name": "432", + "name": "435", "members": [ { "name": "data", - "type": "554" + "type": "557" } ], "meta-type": "object" }, { - "name": "433", + "name": "436", "members": [ { "name": "data", - "type": "555" + "type": "558" } ], "meta-type": "object" }, { - "name": "434", + "name": "437", "members": [ { "name": "data", - "type": "556" + "type": "559" } ], "meta-type": "object" }, { - "name": "435", + "name": "438", "members": [ { "name": "name", @@ -14029,7 +14291,7 @@ "meta-type": "object" }, { - "name": "436", + "name": "439", "members": [ { "name": "incompatible" @@ -14053,7 +14315,7 @@ ] }, { - "name": "437", + "name": "440", "members": [ { "name": "static" @@ -14069,7 +14331,7 @@ ] }, { - "name": "438", + "name": "441", "members": [ { "name": "none" @@ -14089,7 +14351,7 @@ ] }, { - "name": "439", + "name": "442", "members": [ { "name": "block-node" @@ -14109,7 +14371,7 @@ ] }, { - "name": "440", + "name": "443", "members": [ { "name": "node-name", @@ -14119,7 +14381,7 @@ "meta-type": "object" }, { - "name": "441", + "name": "444", "members": [ { "name": "id", @@ -14129,12 +14391,12 @@ "meta-type": "object" }, { - "name": "[442]", - "element-type": "442", + "name": "[445]", + "element-type": "445", "meta-type": "array" }, { - "name": "442", + "name": "445", "members": [ { "name": "fd", @@ -14149,12 +14411,12 @@ "meta-type": "object" }, { - "name": "[443]", - "element-type": "443", + "name": "[446]", + "element-type": "446", "meta-type": "array" }, { - "name": "443", + "name": "446", "members": [ { "name": "name", @@ -14162,7 +14424,7 @@ }, { "name": "type", - "type": "557" + "type": "560" }, { "name": "help", @@ -14178,7 +14440,7 @@ "meta-type": "object" }, { - "name": "444", + "name": "447", "members": [ { "name": "uninit" @@ -14210,7 +14472,7 @@ ] }, { - "name": "445", + "name": "448", "members": [ { "name": "DIMM" @@ -14226,12 +14488,12 @@ ] }, { - "name": "[446]", - "element-type": "446", + "name": "[449]", + "element-type": "449", "meta-type": "array" }, { - "name": "446", + "name": "449", "members": [ { "name": "bus", @@ -14247,11 +14509,11 @@ }, { "name": "class_info", - "type": "558" + "type": "561" }, { "name": "id", - "type": "559" + "type": "562" }, { "name": "irq", @@ -14269,17 +14531,17 @@ { "name": "pci_bridge", "default": null, - "type": "560" + "type": "563" }, { "name": "regions", - "type": "[561]" + "type": "[564]" } ], "meta-type": "object" }, { - "name": "447", + "name": "450", "members": [ { "name": "hyper-v" @@ -14295,7 +14557,7 @@ ] }, { - "name": "448", + "name": "451", "members": [ { "name": "arg1", @@ -14321,7 +14583,7 @@ "meta-type": "object" }, { - "name": "449", + "name": "452", "members": [ { "name": "core", @@ -14337,18 +14599,18 @@ }, { "name": "reason", - "type": "562" + "type": "565" } ], "meta-type": "object" }, { - "name": "[450]", - "element-type": "450", + "name": "[453]", + "element-type": "453", "meta-type": "array" }, { - "name": "450", + "name": "453", "members": [ { "name": "interval_length", @@ -14402,7 +14664,7 @@ "meta-type": "object" }, { - "name": "451", + "name": "454", "members": [ { "name": "boundaries", @@ -14416,7 +14678,7 @@ "meta-type": "object" }, { - "name": "452", + "name": "455", "members": [ { "name": "discard-nb-ok", @@ -14434,7 +14696,7 @@ "meta-type": "object" }, { - "name": "453", + "name": "456", "members": [ { "name": "completion-errors", @@ -14457,36 +14719,36 @@ "meta-type": "array" }, { - "name": "454", + "name": "457", "tag": "type", "variants": [ { "case": "qcow2", - "type": "564" + "type": "567" }, { "case": "vmdk", - "type": "565" + "type": "568" }, { "case": "luks", - "type": "566" + "type": "569" }, { "case": "rbd", - "type": "567" + "type": "570" } ], "members": [ { "name": "type", - "type": "563" + "type": "566" } ], "meta-type": "object" }, { - "name": "455", + "name": "458", "members": [ { "name": "block-backend" @@ -14506,12 +14768,12 @@ ] }, { - "name": "[456]", - "element-type": "456", + "name": "[459]", + "element-type": "459", "meta-type": "array" }, { - "name": "456", + "name": "459", "members": [ { "name": "consistent-read" @@ -14539,7 +14801,7 @@ ] }, { - "name": "457", + "name": "460", "members": [ { "type": "49" @@ -14551,16 +14813,16 @@ "meta-type": "alternate" }, { - "name": "[458]", - "element-type": "458", + "name": "[461]", + "element-type": "461", "meta-type": "array" }, { - "name": "458", + "name": "461", "members": [ { "name": "event", - "type": "568" + "type": "571" }, { "name": "state", @@ -14570,7 +14832,7 @@ { "name": "iotype", "default": null, - "type": "569" + "type": "572" }, { "name": "errno", @@ -14596,16 +14858,16 @@ "meta-type": "object" }, { - "name": "[459]", - "element-type": "459", + "name": "[462]", + "element-type": "462", "meta-type": "array" }, { - "name": "459", + "name": "462", "members": [ { "name": "event", - "type": "568" + "type": "571" }, { "name": "state", @@ -14620,7 +14882,7 @@ "meta-type": "object" }, { - "name": "460", + "name": "463", "members": [ { "name": "auto" @@ -14640,7 +14902,7 @@ ] }, { - "name": "461", + "name": "464", "members": [ { "name": "threads" @@ -14660,7 +14922,7 @@ ] }, { - "name": "462", + "name": "465", "members": [ { "name": "tcp" @@ -14676,7 +14938,7 @@ ] }, { - "name": "463", + "name": "466", "members": [ { "name": "crc32c" @@ -14700,11 +14962,11 @@ ] }, { - "name": "464", + "name": "467", "members": [ { "name": "type", - "type": "570" + "type": "573" }, { "name": "host", @@ -14714,7 +14976,7 @@ "meta-type": "object" }, { - "name": "465", + "name": "468", "members": [ { "type": "49" @@ -14729,62 +14991,62 @@ "meta-type": "alternate" }, { - "name": "466", + "name": "469", "members": [ { - "type": "571" + "type": "574" }, { - "type": "572" + "type": "575" } ], "meta-type": "alternate" }, { - "name": "467", + "name": "470", "tag": "format", "variants": [ { "case": "aes", - "type": "574" + "type": "577" }, { "case": "luks", - "type": "575" + "type": "578" } ], "members": [ { "name": "format", - "type": "573" + "type": "576" } ], "meta-type": "object" }, { - "name": "468", + "name": "471", "tag": "format", "variants": [ { "case": "aes", - "type": "574" + "type": "577" } ], "members": [ { "name": "format", - "type": "576" + "type": "579" } ], "meta-type": "object" }, { - "name": "[457]", - "element-type": "457", + "name": "[460]", + "element-type": "460", "meta-type": "array" }, { - "name": "469", + "name": "472", "members": [ { "name": "quorum" @@ -14800,33 +15062,33 @@ ] }, { - "name": "470", + "name": "473", "tag": "format", "variants": [ { "case": "luks", - "type": "578" + "type": "581" }, { "case": "luks2", - "type": "579" + "type": "582" } ], "members": [ { "name": "format", - "type": "577" + "type": "580" } ], "meta-type": "object" }, { - "name": "[471]", - "element-type": "471", + "name": "[474]", + "element-type": "474", "meta-type": "array" }, { - "name": "471", + "name": "474", "members": [ { "name": "cephx" @@ -14842,12 +15104,12 @@ ] }, { - "name": "[472]", - "element-type": "472", + "name": "[475]", + "element-type": "475", "meta-type": "array" }, { - "name": "472", + "name": "475", "members": [ { "name": "host", @@ -14861,7 +15123,7 @@ "meta-type": "object" }, { - "name": "473", + "name": "476", "members": [ { "name": "primary" @@ -14877,7 +15139,7 @@ ] }, { - "name": "474", + "name": "477", "members": [ { "name": "host", @@ -14921,12 +15183,12 @@ "meta-type": "object" }, { - "name": "475", + "name": "478", "tag": "mode", "variants": [ { "case": "hash", - "type": "581" + "type": "584" }, { "case": "none", @@ -14940,13 +15202,13 @@ "members": [ { "name": "mode", - "type": "580" + "type": "583" } ], "meta-type": "object" }, { - "name": "476", + "name": "479", "members": [ { "name": "filename", @@ -14959,7 +15221,7 @@ { "name": "preallocation", "default": null, - "type": "582" + "type": "585" }, { "name": "nocow", @@ -14975,11 +15237,11 @@ "meta-type": "object" }, { - "name": "477", + "name": "480", "members": [ { "name": "location", - "type": "282" + "type": "283" }, { "name": "size", @@ -14988,13 +15250,13 @@ { "name": "preallocation", "default": null, - "type": "582" + "type": "585" } ], "meta-type": "object" }, { - "name": "478", + "name": "481", "members": [ { "name": "key-secret", @@ -15004,27 +15266,27 @@ { "name": "cipher-alg", "default": null, - "type": "583" + "type": "586" }, { "name": "cipher-mode", "default": null, - "type": "584" + "type": "587" }, { "name": "ivgen-alg", "default": null, - "type": "585" + "type": "588" }, { "name": "ivgen-hash-alg", "default": null, - "type": "586" + "type": "589" }, { "name": "hash-alg", "default": null, - "type": "586" + "type": "589" }, { "name": "iter-time", @@ -15033,7 +15295,7 @@ }, { "name": "file", - "type": "457" + "type": "460" }, { "name": "size", @@ -15042,17 +15304,17 @@ { "name": "preallocation", "default": null, - "type": "582" + "type": "585" } ], "meta-type": "object" }, { - "name": "479", + "name": "482", "members": [ { "name": "location", - "type": "288" + "type": "289" }, { "name": "size", @@ -15062,11 +15324,11 @@ "meta-type": "object" }, { - "name": "480", + "name": "483", "members": [ { "name": "file", - "type": "457" + "type": "460" }, { "name": "size", @@ -15081,11 +15343,11 @@ "meta-type": "object" }, { - "name": "481", + "name": "484", "members": [ { "name": "file", - "type": "457" + "type": "460" }, { "name": "size", @@ -15099,22 +15361,22 @@ { "name": "encrypt", "default": null, - "type": "587" + "type": "590" } ], "meta-type": "object" }, { - "name": "482", + "name": "485", "members": [ { "name": "file", - "type": "457" + "type": "460" }, { "name": "data-file", "default": null, - "type": "457" + "type": "460" }, { "name": "data-file-raw", @@ -15133,7 +15395,7 @@ { "name": "version", "default": null, - "type": "588" + "type": "591" }, { "name": "backing-file", @@ -15143,12 +15405,12 @@ { "name": "backing-fmt", "default": null, - "type": "269" + "type": "270" }, { "name": "encrypt", "default": null, - "type": "587" + "type": "590" }, { "name": "cluster-size", @@ -15158,7 +15420,7 @@ { "name": "preallocation", "default": null, - "type": "582" + "type": "585" }, { "name": "lazy-refcounts", @@ -15173,17 +15435,17 @@ { "name": "compression-type", "default": null, - "type": "589" + "type": "592" } ], "meta-type": "object" }, { - "name": "483", + "name": "486", "members": [ { "name": "file", - "type": "457" + "type": "460" }, { "name": "size", @@ -15197,7 +15459,7 @@ { "name": "backing-fmt", "default": null, - "type": "269" + "type": "270" }, { "name": "cluster-size", @@ -15213,11 +15475,11 @@ "meta-type": "object" }, { - "name": "484", + "name": "487", "members": [ { "name": "location", - "type": "297" + "type": "298" }, { "name": "size", @@ -15231,17 +15493,17 @@ { "name": "encrypt", "default": null, - "type": "590" + "type": "593" } ], "meta-type": "object" }, { - "name": "485", + "name": "488", "members": [ { "name": "location", - "type": "299" + "type": "300" }, { "name": "size", @@ -15251,11 +15513,11 @@ "meta-type": "object" }, { - "name": "486", + "name": "489", "members": [ { "name": "file", - "type": "457" + "type": "460" }, { "name": "size", @@ -15264,17 +15526,17 @@ { "name": "preallocation", "default": null, - "type": "582" + "type": "585" } ], "meta-type": "object" }, { - "name": "487", + "name": "490", "members": [ { "name": "file", - "type": "457" + "type": "460" }, { "name": "size", @@ -15293,7 +15555,7 @@ { "name": "subformat", "default": null, - "type": "591" + "type": "594" }, { "name": "block-state-zero", @@ -15304,11 +15566,11 @@ "meta-type": "object" }, { - "name": "488", + "name": "491", "members": [ { "name": "file", - "type": "457" + "type": "460" }, { "name": "size", @@ -15317,12 +15579,12 @@ { "name": "extents", "default": null, - "type": "[457]" + "type": "[460]" }, { "name": "subformat", "default": null, - "type": "592" + "type": "595" }, { "name": "backing-file", @@ -15332,13 +15594,18 @@ { "name": "adapter-type", "default": null, - "type": "593" + "type": "596" }, { "name": "hwversion", "default": null, "type": "str" }, + { + "name": "toolsversion", + "default": null, + "type": "str" + }, { "name": "zeroed-grain", "default": null, @@ -15348,11 +15615,11 @@ "meta-type": "object" }, { - "name": "489", + "name": "492", "members": [ { "name": "file", - "type": "457" + "type": "460" }, { "name": "size", @@ -15361,7 +15628,7 @@ { "name": "subformat", "default": null, - "type": "594" + "type": "597" }, { "name": "force-size", @@ -15372,11 +15639,11 @@ "meta-type": "object" }, { - "name": "490", + "name": "493", "members": [ { "name": "state", - "type": "595" + "type": "598" }, { "name": "new-secret", @@ -15407,12 +15674,12 @@ "meta-type": "object" }, { - "name": "491", + "name": "494", "members": [ { "name": "encrypt", "default": null, - "type": "596" + "type": "599" } ], "meta-type": "object" @@ -15423,7 +15690,7 @@ "meta-type": "builtin" }, { - "name": "492", + "name": "495", "members": [ { "name": "inet" @@ -15447,47 +15714,47 @@ ] }, { - "name": "493", + "name": "496", "members": [ { "name": "data", - "type": "474" + "type": "477" } ], "meta-type": "object" }, { - "name": "494", + "name": "497", "members": [ { "name": "data", - "type": "521" + "type": "524" } ], "meta-type": "object" }, { - "name": "495", + "name": "498", "members": [ { "name": "data", - "type": "522" + "type": "525" } ], "meta-type": "object" }, { - "name": "496", + "name": "499", "members": [ { "name": "data", - "type": "511" + "type": "514" } ], "meta-type": "object" }, { - "name": "497", + "name": "500", "members": [ { "name": "off" @@ -15507,7 +15774,7 @@ ] }, { - "name": "498", + "name": "501", "members": [ { "name": "file" @@ -15599,132 +15866,132 @@ ] }, { - "name": "499", + "name": "502", "members": [ { "name": "data", - "type": "597" + "type": "600" } ], "meta-type": "object" }, { - "name": "500", + "name": "503", "members": [ { "name": "data", - "type": "598" + "type": "601" } ], "meta-type": "object" }, { - "name": "501", + "name": "504", "members": [ { "name": "data", - "type": "599" + "type": "602" } ], "meta-type": "object" }, { - "name": "502", + "name": "505", "members": [ { "name": "data", - "type": "600" + "type": "603" } ], "meta-type": "object" }, { - "name": "503", + "name": "506", "members": [ { "name": "data", - "type": "601" + "type": "604" } ], "meta-type": "object" }, { - "name": "504", + "name": "507", "members": [ { "name": "data", - "type": "602" + "type": "605" } ], "meta-type": "object" }, { - "name": "505", + "name": "508", "members": [ { "name": "data", - "type": "603" + "type": "606" } ], "meta-type": "object" }, { - "name": "506", + "name": "509", "members": [ { "name": "data", - "type": "604" + "type": "607" } ], "meta-type": "object" }, { - "name": "507", + "name": "510", "members": [ { "name": "data", - "type": "605" + "type": "608" } ], "meta-type": "object" }, { - "name": "508", + "name": "511", "members": [ { "name": "data", - "type": "606" + "type": "609" } ], "meta-type": "object" }, { - "name": "509", + "name": "512", "members": [ { "name": "data", - "type": "607" + "type": "610" } ], "meta-type": "object" }, { - "name": "510", + "name": "513", "members": [ { "name": "data", - "type": "608" + "type": "611" } ], "meta-type": "object" }, { - "name": "[511]", - "element-type": "511", + "name": "[514]", + "element-type": "514", "meta-type": "array" }, { - "name": "511", + "name": "514", "members": [ { "name": "str", @@ -15734,27 +16001,27 @@ "meta-type": "object" }, { - "name": "512", + "name": "515", "members": [ { "name": "data", - "type": "609" + "type": "612" } ], "meta-type": "object" }, { - "name": "513", + "name": "516", "members": [ { "name": "data", - "type": "610" + "type": "613" } ], "meta-type": "object" }, { - "name": "514", + "name": "517", "members": [ { "name": "number" @@ -15770,7 +16037,7 @@ ] }, { - "name": "515", + "name": "518", "members": [ { "name": "data", @@ -15780,17 +16047,17 @@ "meta-type": "object" }, { - "name": "516", + "name": "519", "members": [ { "name": "data", - "type": "611" + "type": "614" } ], "meta-type": "object" }, { - "name": "517", + "name": "520", "members": [ { "name": "key" @@ -15814,31 +16081,31 @@ ] }, { - "name": "518", + "name": "521", "members": [ { "name": "data", - "type": "612" + "type": "615" } ], "meta-type": "object" }, { - "name": "519", + "name": "522", "members": [ { "name": "data", - "type": "613" + "type": "616" } ], "meta-type": "object" }, { - "name": "520", + "name": "523", "members": [ { "name": "data", - "type": "614" + "type": "617" } ], "meta-type": "object" @@ -15849,7 +16116,7 @@ "meta-type": "builtin" }, { - "name": "521", + "name": "524", "members": [ { "name": "path", @@ -15869,7 +16136,7 @@ "meta-type": "object" }, { - "name": "522", + "name": "525", "members": [ { "name": "cid", @@ -15883,12 +16150,12 @@ "meta-type": "object" }, { - "name": "[523]", - "element-type": "523", + "name": "[526]", + "element-type": "526", "meta-type": "array" }, { - "name": "523", + "name": "526", "members": [ { "name": "name", @@ -15901,13 +16168,13 @@ { "name": "transform", "default": null, - "type": "615" + "type": "618" } ], "meta-type": "object" }, { - "name": "524", + "name": "527", "members": [ { "name": "abort" @@ -15943,7 +16210,10 @@ "name": "blockdev-snapshot-sync" }, { - "name": "drive-backup" + "name": "drive-backup", + "features": [ + "deprecated" + ] } ], "meta-type": "enum", @@ -15963,17 +16233,17 @@ ] }, { - "name": "525", + "name": "528", "members": [ { "name": "data", - "type": "616" + "type": "619" } ], "meta-type": "object" }, { - "name": "526", + "name": "529", "members": [ { "name": "data", @@ -15983,7 +16253,7 @@ "meta-type": "object" }, { - "name": "527", + "name": "530", "members": [ { "name": "data", @@ -15993,7 +16263,7 @@ "meta-type": "object" }, { - "name": "528", + "name": "531", "members": [ { "name": "data", @@ -16003,7 +16273,7 @@ "meta-type": "object" }, { - "name": "529", + "name": "532", "members": [ { "name": "data", @@ -16013,7 +16283,7 @@ "meta-type": "object" }, { - "name": "530", + "name": "533", "members": [ { "name": "data", @@ -16023,7 +16293,7 @@ "meta-type": "object" }, { - "name": "531", + "name": "534", "members": [ { "name": "data", @@ -16033,7 +16303,7 @@ "meta-type": "object" }, { - "name": "532", + "name": "535", "members": [ { "name": "data", @@ -16043,7 +16313,7 @@ "meta-type": "object" }, { - "name": "533", + "name": "536", "members": [ { "name": "data", @@ -16053,7 +16323,7 @@ "meta-type": "object" }, { - "name": "534", + "name": "537", "members": [ { "name": "individual" @@ -16069,7 +16339,7 @@ ] }, { - "name": "535", + "name": "538", "members": [ { "name": "string" @@ -16109,12 +16379,12 @@ ] }, { - "name": "[536]", - "element-type": "536", + "name": "[539]", + "element-type": "539", "meta-type": "array" }, { - "name": "536", + "name": "539", "members": [ { "name": "name", @@ -16129,12 +16399,12 @@ "meta-type": "object" }, { - "name": "[537]", - "element-type": "537", + "name": "[540]", + "element-type": "540", "meta-type": "array" }, { - "name": "537", + "name": "540", "members": [ { "name": "name", @@ -16158,12 +16428,12 @@ "meta-type": "object" }, { - "name": "[538]", - "element-type": "538", + "name": "[541]", + "element-type": "541", "meta-type": "array" }, { - "name": "538", + "name": "541", "members": [ { "name": "case", @@ -16177,12 +16447,12 @@ "meta-type": "object" }, { - "name": "[539]", - "element-type": "539", + "name": "[542]", + "element-type": "542", "meta-type": "array" }, { - "name": "539", + "name": "542", "members": [ { "name": "type", @@ -16192,7 +16462,7 @@ "meta-type": "object" }, { - "name": "540", + "name": "543", "members": [ { "name": "deny" @@ -16208,12 +16478,12 @@ ] }, { - "name": "[541]", - "element-type": "541", + "name": "[544]", + "element-type": "544", "meta-type": "array" }, { - "name": "541", + "name": "544", "members": [ { "name": "match", @@ -16221,18 +16491,18 @@ }, { "name": "policy", - "type": "540" + "type": "543" }, { "name": "format", "default": null, - "type": "617" + "type": "620" } ], "meta-type": "object" }, { - "name": "542", + "name": "545", "members": [ { "name": "all" @@ -16252,7 +16522,7 @@ ] }, { - "name": "543", + "name": "546", "members": [ { "name": "before" @@ -16268,7 +16538,7 @@ ] }, { - "name": "544", + "name": "547", "members": [ { "name": "ctrl-ctrl" @@ -16300,7 +16570,7 @@ ] }, { - "name": "545", + "name": "548", "members": [ { "name": "raw" @@ -16316,7 +16586,7 @@ ] }, { - "name": "546", + "name": "549", "members": [ { "name": "iops-total", @@ -16417,7 +16687,7 @@ "meta-type": "object" }, { - "name": "547", + "name": "550", "members": [ { "name": "client" @@ -16433,7 +16703,7 @@ ] }, { - "name": "548", + "name": "551", "members": [ { "name": "uninitialized" @@ -16461,7 +16731,7 @@ ] }, { - "name": "549", + "name": "552", "members": [ { "name": "memory" @@ -16485,7 +16755,7 @@ ] }, { - "name": "550", + "name": "553", "members": [ { "name": "access-latency" @@ -16517,7 +16787,7 @@ ] }, { - "name": "551", + "name": "554", "members": [ { "name": "none" @@ -16537,7 +16807,7 @@ ] }, { - "name": "552", + "name": "555", "members": [ { "name": "none" @@ -16557,7 +16827,7 @@ ] }, { - "name": "553", + "name": "556", "members": [ { "name": "id", @@ -16596,7 +16866,7 @@ "meta-type": "object" }, { - "name": "554", + "name": "557", "members": [ { "name": "id", @@ -16619,7 +16889,7 @@ "meta-type": "object" }, { - "name": "555", + "name": "558", "members": [ { "name": "id", @@ -16658,7 +16928,7 @@ "meta-type": "object" }, { - "name": "556", + "name": "559", "members": [ { "name": "id", @@ -16681,7 +16951,7 @@ "meta-type": "object" }, { - "name": "557", + "name": "560", "members": [ { "name": "string" @@ -16705,7 +16975,7 @@ ] }, { - "name": "558", + "name": "561", "members": [ { "name": "desc", @@ -16720,7 +16990,7 @@ "meta-type": "object" }, { - "name": "559", + "name": "562", "members": [ { "name": "device", @@ -16744,27 +17014,27 @@ "meta-type": "object" }, { - "name": "560", + "name": "563", "members": [ { "name": "bus", - "type": "618" + "type": "621" }, { "name": "devices", "default": null, - "type": "[446]" + "type": "[449]" } ], "meta-type": "object" }, { - "name": "[561]", - "element-type": "561", + "name": "[564]", + "element-type": "564", "meta-type": "array" }, { - "name": "561", + "name": "564", "members": [ { "name": "bar", @@ -16796,7 +17066,7 @@ "meta-type": "object" }, { - "name": "562", + "name": "565", "members": [ { "name": "unknown" @@ -16824,7 +17094,7 @@ ] }, { - "name": "563", + "name": "566", "members": [ { "name": "qcow2" @@ -16848,47 +17118,47 @@ ] }, { - "name": "564", + "name": "567", "members": [ { "name": "data", - "type": "619" + "type": "622" } ], "meta-type": "object" }, { - "name": "565", + "name": "568", "members": [ { "name": "data", - "type": "620" + "type": "623" } ], "meta-type": "object" }, { - "name": "566", + "name": "569", "members": [ { "name": "data", - "type": "621" + "type": "624" } ], "meta-type": "object" }, { - "name": "567", + "name": "570", "members": [ { "name": "data", - "type": "622" + "type": "625" } ], "meta-type": "object" }, { - "name": "568", + "name": "571", "members": [ { "name": "l1_update" @@ -17088,7 +17358,7 @@ ] }, { - "name": "569", + "name": "572", "members": [ { "name": "read" @@ -17120,7 +17390,7 @@ ] }, { - "name": "570", + "name": "573", "members": [ { "name": "inet" @@ -17132,12 +17402,12 @@ ] }, { - "name": "571", + "name": "574", "members": [ { "name": "template", "default": null, - "type": "572" + "type": "575" }, { "name": "main-header", @@ -17188,7 +17458,7 @@ "meta-type": "object" }, { - "name": "572", + "name": "575", "members": [ { "name": "none" @@ -17212,7 +17482,7 @@ ] }, { - "name": "573", + "name": "576", "members": [ { "name": "aes" @@ -17228,7 +17498,7 @@ ] }, { - "name": "574", + "name": "577", "members": [ { "name": "key-secret", @@ -17239,7 +17509,7 @@ "meta-type": "object" }, { - "name": "575", + "name": "578", "members": [ { "name": "key-secret", @@ -17250,7 +17520,7 @@ "meta-type": "object" }, { - "name": "576", + "name": "579", "members": [ { "name": "aes" @@ -17262,7 +17532,7 @@ ] }, { - "name": "577", + "name": "580", "members": [ { "name": "luks" @@ -17278,7 +17548,7 @@ ] }, { - "name": "578", + "name": "581", "members": [ { "name": "key-secret", @@ -17288,7 +17558,7 @@ "meta-type": "object" }, { - "name": "579", + "name": "582", "members": [ { "name": "key-secret", @@ -17298,7 +17568,7 @@ "meta-type": "object" }, { - "name": "580", + "name": "583", "members": [ { "name": "none" @@ -17318,11 +17588,11 @@ ] }, { - "name": "581", + "name": "584", "members": [ { "name": "type", - "type": "623" + "type": "626" }, { "name": "hash", @@ -17332,7 +17602,7 @@ "meta-type": "object" }, { - "name": "582", + "name": "585", "members": [ { "name": "off" @@ -17356,7 +17626,7 @@ ] }, { - "name": "583", + "name": "586", "members": [ { "name": "aes-128" @@ -17412,7 +17682,7 @@ ] }, { - "name": "584", + "name": "587", "members": [ { "name": "ecb" @@ -17436,7 +17706,7 @@ ] }, { - "name": "585", + "name": "588", "members": [ { "name": "plain" @@ -17456,7 +17726,7 @@ ] }, { - "name": "586", + "name": "589", "members": [ { "name": "md5" @@ -17492,28 +17762,28 @@ ] }, { - "name": "587", + "name": "590", "tag": "format", "variants": [ { "case": "qcow", - "type": "574" + "type": "577" }, { "case": "luks", - "type": "625" + "type": "628" } ], "members": [ { "name": "format", - "type": "624" + "type": "627" } ], "meta-type": "object" }, { - "name": "588", + "name": "591", "members": [ { "name": "v2" @@ -17529,7 +17799,7 @@ ] }, { - "name": "589", + "name": "592", "members": [ { "name": "zlib" @@ -17545,28 +17815,28 @@ ] }, { - "name": "590", + "name": "593", "tag": "format", "variants": [ { "case": "luks", - "type": "626" + "type": "629" }, { "case": "luks2", - "type": "627" + "type": "630" } ], "members": [ { "name": "format", - "type": "577" + "type": "580" } ], "meta-type": "object" }, { - "name": "591", + "name": "594", "members": [ { "name": "dynamic" @@ -17582,7 +17852,7 @@ ] }, { - "name": "592", + "name": "595", "members": [ { "name": "monolithicSparse" @@ -17610,7 +17880,7 @@ ] }, { - "name": "593", + "name": "596", "members": [ { "name": "ide" @@ -17634,7 +17904,7 @@ ] }, { - "name": "594", + "name": "597", "members": [ { "name": "dynamic" @@ -17650,7 +17920,7 @@ ] }, { - "name": "595", + "name": "598", "members": [ { "name": "active" @@ -17666,12 +17936,12 @@ ] }, { - "name": "596", + "name": "599", "tag": "format", "variants": [ { "case": "luks", - "type": "628" + "type": "631" }, { "case": "qcow", @@ -17681,13 +17951,13 @@ "members": [ { "name": "format", - "type": "624" + "type": "627" } ], "meta-type": "object" }, { - "name": "597", + "name": "600", "members": [ { "name": "logfile", @@ -17717,7 +17987,7 @@ "meta-type": "object" }, { - "name": "598", + "name": "601", "members": [ { "name": "logfile", @@ -17737,7 +18007,7 @@ "meta-type": "object" }, { - "name": "599", + "name": "602", "members": [ { "name": "logfile", @@ -17751,7 +18021,7 @@ }, { "name": "addr", - "type": "309" + "type": "310" }, { "name": "tls-creds", @@ -17802,7 +18072,7 @@ "meta-type": "object" }, { - "name": "600", + "name": "603", "members": [ { "name": "logfile", @@ -17816,18 +18086,18 @@ }, { "name": "remote", - "type": "309" + "type": "310" }, { "name": "local", "default": null, - "type": "309" + "type": "310" } ], "meta-type": "object" }, { - "name": "601", + "name": "604", "members": [ { "name": "logfile", @@ -17843,7 +18113,7 @@ "meta-type": "object" }, { - "name": "602", + "name": "605", "members": [ { "name": "logfile", @@ -17863,7 +18133,7 @@ "meta-type": "object" }, { - "name": "603", + "name": "606", "members": [ { "name": "logfile", @@ -17884,7 +18154,7 @@ "meta-type": "object" }, { - "name": "604", + "name": "607", "members": [ { "name": "logfile", @@ -17904,7 +18174,7 @@ "meta-type": "object" }, { - "name": "605", + "name": "608", "members": [ { "name": "logfile", @@ -17924,7 +18194,7 @@ "meta-type": "object" }, { - "name": "606", + "name": "609", "members": [ { "name": "logfile", @@ -17950,7 +18220,7 @@ "meta-type": "object" }, { - "name": "607", + "name": "610", "members": [ { "name": "logfile", @@ -17986,7 +18256,7 @@ "meta-type": "object" }, { - "name": "608", + "name": "611", "members": [ { "name": "logfile", @@ -18007,7 +18277,7 @@ "meta-type": "object" }, { - "name": "609", + "name": "612", "members": [ { "name": "path", @@ -18023,7 +18293,7 @@ "meta-type": "object" }, { - "name": "610", + "name": "613", "members": [ { "name": "chardev", @@ -18033,7 +18303,7 @@ "meta-type": "object" }, { - "name": "611", + "name": "614", "members": [ { "name": "unmapped" @@ -18641,11 +18911,11 @@ ] }, { - "name": "612", + "name": "615", "members": [ { "name": "key", - "type": "349" + "type": "350" }, { "name": "down", @@ -18655,11 +18925,11 @@ "meta-type": "object" }, { - "name": "613", + "name": "616", "members": [ { "name": "button", - "type": "629" + "type": "632" }, { "name": "down", @@ -18669,11 +18939,11 @@ "meta-type": "object" }, { - "name": "614", + "name": "617", "members": [ { "name": "axis", - "type": "630" + "type": "633" }, { "name": "value", @@ -18683,7 +18953,7 @@ "meta-type": "object" }, { - "name": "615", + "name": "618", "members": [ { "name": "persistent", @@ -18694,13 +18964,13 @@ "meta-type": "object" }, { - "name": "616", + "name": "619", "members": [ ], "meta-type": "object" }, { - "name": "617", + "name": "620", "members": [ { "name": "exact" @@ -18716,7 +18986,7 @@ ] }, { - "name": "618", + "name": "621", "members": [ { "name": "number", @@ -18732,21 +19002,21 @@ }, { "name": "io_range", - "type": "631" + "type": "634" }, { "name": "memory_range", - "type": "631" + "type": "634" }, { "name": "prefetchable_range", - "type": "631" + "type": "634" } ], "meta-type": "object" }, { - "name": "619", + "name": "622", "members": [ { "name": "compat", @@ -18784,22 +19054,22 @@ { "name": "encrypt", "default": null, - "type": "632" + "type": "635" }, { "name": "bitmaps", "default": null, - "type": "[633]" + "type": "[636]" }, { "name": "compression-type", - "type": "589" + "type": "592" } ], "meta-type": "object" }, { - "name": "620", + "name": "623", "members": [ { "name": "create-type", @@ -18815,34 +19085,34 @@ }, { "name": "extents", - "type": "[262]" + "type": "[263]" } ], "meta-type": "object" }, { - "name": "621", + "name": "624", "members": [ { "name": "cipher-alg", - "type": "583" + "type": "586" }, { "name": "cipher-mode", - "type": "584" + "type": "587" }, { "name": "ivgen-alg", - "type": "585" + "type": "588" }, { "name": "ivgen-hash-alg", "default": null, - "type": "586" + "type": "589" }, { "name": "hash-alg", - "type": "586" + "type": "589" }, { "name": "payload-offset", @@ -18858,24 +19128,24 @@ }, { "name": "slots", - "type": "[634]" + "type": "[637]" } ], "meta-type": "object" }, { - "name": "622", + "name": "625", "members": [ { "name": "encryption-format", "default": null, - "type": "577" + "type": "580" } ], "meta-type": "object" }, { - "name": "623", + "name": "626", "members": [ { "name": "md5" @@ -18895,7 +19165,7 @@ ] }, { - "name": "624", + "name": "627", "members": [ { "name": "qcow" @@ -18911,7 +19181,7 @@ ] }, { - "name": "625", + "name": "628", "members": [ { "name": "key-secret", @@ -18921,27 +19191,27 @@ { "name": "cipher-alg", "default": null, - "type": "583" + "type": "586" }, { "name": "cipher-mode", "default": null, - "type": "584" + "type": "587" }, { "name": "ivgen-alg", "default": null, - "type": "585" + "type": "588" }, { "name": "ivgen-hash-alg", "default": null, - "type": "586" + "type": "589" }, { "name": "hash-alg", "default": null, - "type": "586" + "type": "589" }, { "name": "iter-time", @@ -18952,7 +19222,7 @@ "meta-type": "object" }, { - "name": "626", + "name": "629", "members": [ { "name": "key-secret", @@ -18961,13 +19231,13 @@ { "name": "cipher-alg", "default": null, - "type": "583" + "type": "586" } ], "meta-type": "object" }, { - "name": "627", + "name": "630", "members": [ { "name": "key-secret", @@ -18976,17 +19246,17 @@ { "name": "cipher-alg", "default": null, - "type": "583" + "type": "586" } ], "meta-type": "object" }, { - "name": "628", + "name": "631", "members": [ { "name": "state", - "type": "595" + "type": "598" }, { "name": "new-secret", @@ -19017,7 +19287,7 @@ "meta-type": "object" }, { - "name": "629", + "name": "632", "members": [ { "name": "left" @@ -19053,7 +19323,7 @@ ] }, { - "name": "630", + "name": "633", "members": [ { "name": "x" @@ -19069,7 +19339,7 @@ ] }, { - "name": "631", + "name": "634", "members": [ { "name": "base", @@ -19083,12 +19353,12 @@ "meta-type": "object" }, { - "name": "632", + "name": "635", "tag": "format", "variants": [ { "case": "luks", - "type": "621" + "type": "624" }, { "case": "aes", @@ -19098,18 +19368,18 @@ "members": [ { "name": "format", - "type": "573" + "type": "576" } ], "meta-type": "object" }, { - "name": "[633]", - "element-type": "633", + "name": "[636]", + "element-type": "636", "meta-type": "array" }, { - "name": "633", + "name": "636", "members": [ { "name": "name", @@ -19121,23 +19391,23 @@ }, { "name": "flags", - "type": "[635]" + "type": "[638]" } ], "meta-type": "object" }, { - "name": "[262]", - "element-type": "262", + "name": "[263]", + "element-type": "263", "meta-type": "array" }, { - "name": "[634]", - "element-type": "634", + "name": "[637]", + "element-type": "637", "meta-type": "array" }, { - "name": "634", + "name": "637", "members": [ { "name": "active", @@ -19161,12 +19431,12 @@ "meta-type": "object" }, { - "name": "[635]", - "element-type": "635", + "name": "[638]", + "element-type": "638", "meta-type": "array" }, { - "name": "635", + "name": "638", "members": [ { "name": "in-use" @@ -19288,6 +19558,33 @@ { "name": "query-cpu-model-expansion" }, + { + "name": "x-query-usb" + }, + { + "name": "x-query-roms" + }, + { + "name": "x-query-rdma" + }, + { + "name": "x-query-ramblock" + }, + { + "name": "x-query-profile" + }, + { + "name": "x-query-opcount" + }, + { + "name": "x-query-numa" + }, + { + "name": "x-query-jit" + }, + { + "name": "x-query-irq" + }, { "name": "query-memory-devices" }, @@ -25071,6 +25368,10 @@ "name": "gpe0_blk_len", "type": "uint32" }, + { + "name": "x-keep-pci-slot-hpc", + "type": "bool" + }, { "name": "sci_int", "type": "uint8" @@ -25837,12 +26138,12 @@ }, { "default-value": true, - "name": "native-hotplug", + "name": "hotplug", "type": "bool" }, { "default-value": true, - "name": "hotplug", + "name": "x-native-hotplug", "type": "bool" }, { @@ -28945,8 +29246,7 @@ "cldemote", "movdiri", "movdir64b", - "spec-ctrl", - "core-capability" + "spec-ctrl" ], "static": false, "migration-safe": true, @@ -33180,7 +33480,6 @@ "movdir64b", "spec-ctrl", "arch-capabilities", - "core-capability", "ssbd", "3dnowprefetch", "xsavec", diff --git a/tests/qemucapabilitiesdata/caps_6.2.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_6.2.0.x86_64.xml index 39179916c5..b8ed5e1bdb 100644 --- a/tests/qemucapabilitiesdata/caps_6.2.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_6.2.0.x86_64.xml @@ -240,10 +240,10 @@ <flag name='device.json'/> <flag name='query-dirty-rate'/> <flag name='rbd-encryption'/> - <version>6001050</version> + <version>6002000</version> <kvmVersion>0</kvmVersion> <microcodeVersion>43100244</microcodeVersion> - <package>v6.1.0-1735-gc52d69e7db</package> + <package>v6.2.0</package> <arch>x86_64</arch> <hostCPU type='kvm' model='base' migratability='yes'> <property name='vmx-entry-load-rtit-ctl' type='boolean' value='false'/> @@ -635,7 +635,6 @@ <blocker name='movdiri'/> <blocker name='movdir64b'/> <blocker name='spec-ctrl'/> - <blocker name='core-capability'/> </cpu> <cpu type='kvm' name='Snowridge-v3' typename='Snowridge-v3-x86_64-cpu' usable='no'> <blocker name='erms'/> @@ -2008,7 +2007,6 @@ <blocker name='movdir64b'/> <blocker name='spec-ctrl'/> <blocker name='arch-capabilities'/> - <blocker name='core-capability'/> <blocker name='ssbd'/> <blocker name='3dnowprefetch'/> <blocker name='xsavec'/> -- 2.31.1

2 1

[PATCH v1 0/7] Fix build without XDR library
by Michal Privoznik 15 Dec '21

15 Dec '21

It's not much that's left when no XDR library is found, but some users might want just stateless drivers. BTW: there is still one pending issue - if no XDR library is found then remote driver is turned off which in turn means libvirtd is turned off. Until here it makes sense. But what I don't understand is why qemu driver depends on libvirtd, since it has embed mode. Transitively, why any driver depends on libvird? Michal Prívozník (7): libvirt-stream: Don't require RPC module rpc: Separate out socket code into another static lib rpc: Build only when XDR is available logging: Build log manager only when RPC is available admin: Build only when RPC is available meson: Require XDR for wireshark meson: Detect XDR only when needed examples/c/admin/meson.build | 36 +++++----- meson.build | 47 ++++++------ src/admin/meson.build | 36 +++++----- src/libvirt-stream.c | 6 +- src/libvirt_logging.syms | 18 +++++ src/libvirt_private.syms | 9 --- src/libvirt_remote.syms | 56 --------------- src/libvirt_socket.syms | 65 +++++++++++++++++ src/logging/meson.build | 31 ++++---- src/meson.build | 98 ++++++++++++------------- src/rpc/meson.build | 136 ++++++++++++++++++++--------------- tools/meson.build | 44 ++++++------ 12 files changed, 322 insertions(+), 260 deletions(-) create mode 100644 src/libvirt_logging.syms create mode 100644 src/libvirt_socket.syms -- 2.32.0

2 8

[PATCH] qemu-options: Remove the deprecated -no-quit option
by Thomas Huth 15 Dec '21

15 Dec '21

This option was just a wrapper around the -display ...,window-close=off parameter, and the name "no-quit" is rather confusing compared to "window-close" (since there are still other means to quit the emulator), so let's remove this now. Signed-off-by: Thomas Huth <thuth(a)redhat.com> --- docs/about/deprecated.rst | 6 ------ docs/about/removed-features.rst | 7 +++++++ qemu-options.hx | 8 -------- softmmu/vl.c | 8 +------- 4 files changed, 8 insertions(+), 21 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 7f12f53713..6f85afdee4 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -134,12 +134,6 @@ specified. Use ``-display sdl,window-close=...`` instead (i.e. with a minus instead of an underscore between "window" and "close"). -``-no-quit`` (since 6.1) -'''''''''''''''''''''''' - -The ``-no-quit`` is a synonym for ``-display ...,window-close=off`` which -should be used instead. - ``-alt-grab`` and ``-display sdl,alt_grab=on`` (since 6.2) '''''''''''''''''''''''''''''''''''''''''''''''''''''''''' diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst index f92b8bd738..380a1b30ea 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -330,6 +330,13 @@ RISC-V firmware not booted by default (removed in 5.1) QEMU 5.1 changes the default behaviour from ``-bios none`` to ``-bios default`` for the RISC-V ``virt`` machine and ``sifive_u`` machine. +``-no-quit`` (removed in 7.0) +''''''''''''''''''''''''''''' + +The ``-no-quit`` was a synonym for ``-display ...,window-close=off`` which +should be used instead. + + QEMU Machine Protocol (QMP) commands ------------------------------------ diff --git a/qemu-options.hx b/qemu-options.hx index ae2c6dbbfc..e2b73f6e5d 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2002,14 +2002,6 @@ SRST ``-display sdl,grab-mod=rctrl`` instead. ERST -DEF("no-quit", 0, QEMU_OPTION_no_quit, - "-no-quit disable SDL/GTK window close capability (deprecated)\n", QEMU_ARCH_ALL) -SRST -``-no-quit`` - Disable window close capability (SDL and GTK only). This option is - deprecated, please use ``-display ...,window-close=off`` instead. -ERST - DEF("sdl", 0, QEMU_OPTION_sdl, "-sdl shorthand for -display sdl\n", QEMU_ARCH_ALL) SRST diff --git a/softmmu/vl.c b/softmmu/vl.c index 620a1f1367..163ab355f5 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -1938,7 +1938,7 @@ static void qemu_create_early_backends(void) "for SDL, ignoring option"); } if (dpy.has_window_close && !use_gtk && !use_sdl) { - error_report("-no-quit is only valid for GTK and SDL, " + error_report("window-close is only valid for GTK and SDL, " "ignoring option"); } @@ -3298,12 +3298,6 @@ void qemu_init(int argc, char **argv, char **envp) warn_report("-ctrl-grab is deprecated, please use " "-display sdl,grab-mod=rctrl instead."); break; - case QEMU_OPTION_no_quit: - dpy.has_window_close = true; - dpy.window_close = false; - warn_report("-no-quit is deprecated, please use " - "-display ...,window-close=off instead."); - break; case QEMU_OPTION_sdl: warn_report("-sdl is deprecated, use -display sdl instead."); #ifdef CONFIG_SDL -- 2.27.0

3 3

[libvirt PATCH 0/2] Addendum to hyperv-passthrough
by Tim Wiederhake 15 Dec '21

15 Dec '21

Spotted by Daniel. Patches were already merged though, hence this addendum. Tim Wiederhake (2): docs: domain: Clarify on the dangers of migrating with hyperv-passthrough enabled virDomainFeaturesHyperVDefParse: Compare hyperv mode docs/formatdomain.rst | 9 ++++++++- src/conf/domain_conf.c | 9 +++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) -- 2.31.1

2 4

[libvirt PATCH 00/17] Bump minimum dnsmasq version
by Ján Tomko 15 Dec '21

15 Dec '21

This bumps the minimum dnsmasq version to the point where we do not need capability probing, reducing it to a version check (which I will be happy to remove on request). Unless I missed something, this also means we no longer need to spawn radvd manually. Note that DNSMASQ_CAPS_BINDTODEVICE was the indication of a downstream mitigation of a CVE that should no longer be needed if we have --bind-dynamic Ján Tomko (17): util: dnsmasqCapsSetFromBuffer: use error label tests: do not test dnsmasq older than 2.67 util: dnsmasq: mandate at least version 2.67 network: assume DNSMASQ_DHCPv6_SUPPORT network: assume DNSMASQ_RA_SUPPORT util: remove DNSMASQ_RA_SUPPORT network: assume DNSMASQ_CAPS_BIND_DYNAMIC network: assume DNSMASQ_CAPS_RA_PARAM util: dnsmasq: delete assumed capability flags network: remove any code dealing with radvd network: driver: remove unused radvdStateDir variable conf: remove radvdPid from virNetworkObj build: do not search for radvd binary spec: do not require radvd util: remove dnsmasqCapsGetVersion util: dnsmasq: remove caps completely network: remove unused 'driver' parameter libvirt.spec.in | 2 - meson.build | 1 - src/conf/virnetworkobj.c | 16 - src/conf/virnetworkobj.h | 7 - src/libvirt_private.syms | 4 - src/network/bridge_driver.c | 459 ++---------------- src/network/bridge_driver_platform.h | 1 - src/util/virdnsmasq.c | 69 +-- src/util/virdnsmasq.h | 24 - .../networkxml2confdata/isolated-network.conf | 5 +- .../nat-network-dns-srv-record-minimal.conf | 10 +- .../nat-network-dns-srv-record.conf | 2 + .../nat-network-dns-txt-record.conf | 2 + .../nat-network-name-with-quotes.conf | 10 +- .../networkxml2confdata/netboot-network.conf | 4 +- .../netboot-proxy-network.conf | 4 +- tests/networkxml2conftest.c | 32 +- 17 files changed, 83 insertions(+), 569 deletions(-) -- 2.31.1

3 22

[libvirt PATCH] Fix some typos
by Tim Wiederhake 15 Dec '21

15 Dec '21

Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com> --- docs/manpages/virsh.rst | 2 +- src/qemu/qemu_domain.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index 275f416090..265725d214 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -3203,7 +3203,7 @@ host. By default only non-shared non-readonly images are transferred. Use *--migrate-disks* to explicitly specify a list of disk targets to transfer via the comma separated ``disk-list`` argument. With *--copy-storage-synchronous-writes* flag used the disk data migration will -synchronously handle guest disk writes to both the original soure and the +synchronously handle guest disk writes to both the original source and the destination to ensure that the disk migration converges at the price of possibly decreased burst performance. diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index 5474d1dccc..6586411919 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -344,7 +344,7 @@ struct _qemuDomainChrSourcePrivate { int fd; /* file descriptor of the chardev source */ int logfd; /* file descriptor of the logging source */ - bool wait; /* wait for incomming connections on chardev */ + bool wait; /* wait for incoming connections on chardev */ char *tlsCertPath; /* path to certificates if TLS is requested */ bool tlsVerify; /* whether server should verify client certificates */ -- 2.31.1

2 1

[libvirt PATCH 0/2] qemu: Add support for return-path migration capability
by Jiri Denemark 15 Dec '21

15 Dec '21

See 2/2 for more details about the capability. Jiri Denemark (2): qemu: Support enabling migration caps unless a flag is used qemu: Add support for return-path migration capability src/qemu/qemu_migration_params.c | 39 ++++++++++++++++++++++++-------- src/qemu/qemu_migration_params.h | 1 + 2 files changed, 31 insertions(+), 9 deletions(-) -- 2.34.1

2 4

[PATCH] rpm: don't start/stop -ro.socket units for virtlockd/virtlogd
by Daniel P. Berrangé 14 Dec '21

14 Dec '21

These daemons do not have any support for unprivileged readonly access, so we must not reference -ro.socket units in scripts. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- libvirt.spec.in | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 97030be407..e672fcc3a5 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1279,14 +1279,18 @@ then \ fi \ %libvirt_daemon_finish_restart %1 +# For daemons with only UNIX sockets %define libvirt_daemon_systemd_post() %systemd_post %1.socket %1-ro.socket %1-admin.socket %1.service - -%define libvirt_daemon_systemd_post_inet() %systemd_post %1.socket %1-ro.socket %1-admin.socket %1-tls.socket %1-tcp.socket %1.service - %define libvirt_daemon_systemd_preun() %systemd_preun %1.service %1-ro.socket %1-admin.socket %1.socket +# For daemons with UNIX and INET sockets +%define libvirt_daemon_systemd_post_inet() %systemd_post %1.socket %1-ro.socket %1-admin.socket %1-tls.socket %1-tcp.socket %1.service %define libvirt_daemon_systemd_preun_inet() %systemd_preun %1.service %1-ro.socket %1-admin.socket %1-tls.socket %1-tcp.socket %1.socket +# For daemons with only UNIX sockets and no unprivileged read-only access +%define libvirt_daemon_systemd_post_priv() %systemd_post %1.socket %1-admin.socket %1.service +%define libvirt_daemon_systemd_preun_priv() %systemd_preun %1.service %1-admin.socket %1.socket + %pre daemon # 'libvirt' group is just to allow password-less polkit access to # libvirtd. The uid number is irrelevant, so we use dynamic allocation @@ -1296,8 +1300,8 @@ getent group libvirt >/dev/null || groupadd -r libvirt exit 0 %post daemon -%libvirt_daemon_systemd_post virtlogd -%libvirt_daemon_systemd_post virtlockd +%libvirt_daemon_systemd_post_priv virtlogd +%libvirt_daemon_systemd_post_priv virtlockd %if %{with_modular_daemons} %libvirt_daemon_systemd_post_inet virtproxyd %else @@ -1313,8 +1317,8 @@ exit 0 %libvirt_daemon_systemd_preun_inet libvirtd %libvirt_daemon_systemd_preun_inet virtproxyd -%libvirt_daemon_systemd_preun virtlogd -%libvirt_daemon_systemd_preun virtlockd +%libvirt_daemon_systemd_preun_priv virtlogd +%libvirt_daemon_systemd_preun_priv virtlockd %postun daemon /bin/systemctl daemon-reload >/dev/null 2>&1 || : -- 2.33.1

2 1

[PATCH] rpm: fix typo in daemon name in %post/%preun scripts
by Daniel P. Berrangé 14 Dec '21

14 Dec '21

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- libvirt.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 32b4243d0a..97030be407 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1297,7 +1297,7 @@ exit 0 %post daemon %libvirt_daemon_systemd_post virtlogd -%libvirt_daemon_systemd_post virtlockdd +%libvirt_daemon_systemd_post virtlockd %if %{with_modular_daemons} %libvirt_daemon_systemd_post_inet virtproxyd %else @@ -1314,7 +1314,7 @@ exit 0 %libvirt_daemon_systemd_preun_inet libvirtd %libvirt_daemon_systemd_preun_inet virtproxyd %libvirt_daemon_systemd_preun virtlogd -%libvirt_daemon_systemd_preun virtlockdd +%libvirt_daemon_systemd_preun virtlockd %postun daemon /bin/systemctl daemon-reload >/dev/null 2>&1 || : -- 2.33.1

2 1

[libvirt PATCH 00/10] Enable hyperv-passthrough
by Tim Wiederhake 14 Dec '21

14 Dec '21

This series enables "hv-passthrough" in libvirt. See https://bugzilla.redhat.com/show_bug.cgi?id=1851249. Example usage in VM definition: <features> <hyperv mode='passthrough'/> </features> Tim Wiederhake (10): schema: Wrap hyperv element in choice and group schema: Add optional "mode" attribute to hyperv conf: domain: Define enum for HyperV mode virDomainFeaturesHyperVDefParse: Read attribute "mode" of element "hyperv" virDomainDefFormatFeatures: Write attribute "mode" of element "hyperv" docs: domain: Add documentation for "hyperv"'s new "mode" attribute conf: domain: Add hyperv passthrough mode schema: hyperv: Add mode "passthrough" tests: Add tests for hyperv-passthrough docs: domain: Add documentation for hyperv passthrough mode docs/formatdomain.rst | 13 +- docs/schemas/domaincommon.rng | 172 ++++++++++-------- src/conf/domain_conf.c | 23 ++- src/conf/domain_conf.h | 8 + src/qemu/qemu_command.c | 18 +- src/qemu/qemu_validate.c | 2 +- .../hyperv-passthrough.x86_64-6.1.0.args | 32 ++++ .../hyperv-passthrough.x86_64-latest.args | 32 ++++ tests/qemuxml2argvdata/hyperv-passthrough.xml | 27 +++ tests/qemuxml2argvtest.c | 2 + tests/qemuxml2xmloutdata/hyperv-off.xml | 2 +- .../qemuxml2xmloutdata/hyperv-passthrough.xml | 31 ++++ .../hyperv-stimer-direct.xml | 2 +- tests/qemuxml2xmloutdata/hyperv.xml | 2 +- tests/qemuxml2xmltest.c | 1 + 15 files changed, 277 insertions(+), 90 deletions(-) create mode 100644 tests/qemuxml2argvdata/hyperv-passthrough.x86_64-6.1.0.args create mode 100644 tests/qemuxml2argvdata/hyperv-passthrough.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/hyperv-passthrough.xml create mode 100644 tests/qemuxml2xmloutdata/hyperv-passthrough.xml -- 2.31.1

3 14

[libvirt PATCH 0/5] use g_auto for virCommand (Episode II.V: Goodbye, Galaxy!)
by Ján Tomko 14 Dec '21

14 Dec '21

Fear not, the end is near. Ján Tomko (5): docs: use g_auto in virCommand example util: dnsmasq: refactor CapsRefresh util: iscsi: use two vars in CreateIfaceIQN util: refactor virNodeSuspendSetNodeWakeup util: use g_auto in virNodeSuspendHelper docs/internals/command.html.in | 12 +++-------- src/util/virdnsmasq.c | 37 +++++++++++++++------------------- src/util/viriscsi.c | 34 +++++++++++++++---------------- src/util/virnodesuspend.c | 16 +++------------ 4 files changed, 39 insertions(+), 60 deletions(-) -- 2.31.1

3 7

[PATCH] libxl: Implement domainGetMessages API
by Jim Fehlig 14 Dec '21

14 Dec '21

Since commit 46783e6307a, the 'virsh dominfo' command calls virDomainGetMessages to report any messages from the domain. Hypervisors not implementing the API now get the following log message when clients invoke 'virsh dominfo' this function is not supported by the connection driver: virDomainGetMessages Although libxl currently does not support any tainting or deprecation messages, provide an implementation to squelch the previously unseen error message when collecting dominfo. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- src/libxl/libxl_driver.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index bc8598ea96..2d9385654c 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -6385,6 +6385,29 @@ libxlDomainGetMetadata(virDomainPtr dom, return ret; } +static int +libxlDomainGetMessages(virDomainPtr dom, + char ***msgs, + unsigned int flags) +{ + virDomainObj *vm = NULL; + int ret = -1; + + virCheckFlags(0, -1); + + if (!(vm = libxlDomObjFromDomain(dom))) + return -1; + + if (virDomainGetMessagesEnsureACL(dom->conn, vm->def) < 0) + goto cleanup; + + ret = virDomainObjGetMessages(vm, msgs, flags); + + cleanup: + virDomainObjEndAPI(&vm); + return ret; +} + static virHypervisorDriver libxlHypervisorDriver = { .name = LIBXL_DRIVER_EXTERNAL_NAME, .connectURIProbe = libxlConnectURIProbe, @@ -6498,6 +6521,7 @@ static virHypervisorDriver libxlHypervisorDriver = { .connectBaselineCPU = libxlConnectBaselineCPU, /* 2.3.0 */ .domainSetMetadata = libxlDomainSetMetadata, /* 5.7.0 */ .domainGetMetadata = libxlDomainGetMetadata, /* 5.7.0 */ + .domainGetMessages = libxlDomainGetMessages, /* 8.0.0 */ }; -- 2.34.1

4 6

[libvirt PATCH v3 00/13] Improve AMD SEV support
by Daniel P. Berrangé 14 Dec '21

14 Dec '21

This addresses a few issues in the AMD SEV support - Neither host or domain level SEV metadata is exposed in virsh commands - The domain launch security parameters don't expose enough info to validate the measurement - Support verified direct kernel boot - Report max SEV/SEV-ES guest counts The second point was the initial purpose of my work. Per the SEV API guide to calculate the measurement we need measurement = HMAC(0x04 || API_MAJOR || API_MINOR || BUILD || GCTX.POLICY || GCTX.LD || MNONCE; GCTX.TIK) The API_MINOR, API_MAJOR, BUILD values are things that are available from 'query-sev' QMP command and libvirt does not expose this info. This patch series adds them to virDomainGetLaunchSecurityParams alongside the measurement that we already report. So now the client can fetch this info and calculate an expected measurement to compare with the actual measurement they got. They will thus know if the guest is safe to inject secrets into, which is where Jim's recent patches come into play. In v3: - Refactor CPUID code so and mock it in test suite Daniel P. Berrangé (13): include: add new launch security parameters qemu: report error querying launch params for inactive guest qemu: add monitor APIs for query-sev qemu: report new launch security parameters tools: add 'domlaunchsecinfo' virsh command tools: add 'nodesevinfo' virsh command conf: extend domain capabilities for max SEV guest count include: define parameters for reporting SEV guest limits util: pull CPUID helper function out of CPU driver qemu: report max number of SEV guests conf: add support for setting SEV kernel hashes qemu: probe for sev-guest.kernel-hashes property qemu: format sev-guest.kernel-hashes property docs/formatdomain.rst | 7 +- docs/formatdomaincaps.html.in | 6 + docs/manpages/virsh.rst | 31 +++++ docs/schemas/domaincaps.rng | 6 + docs/schemas/domaincommon.rng | 5 + include/libvirt/libvirt-domain.h | 32 +++++ include/libvirt/libvirt-host.h | 16 +++ src/conf/domain_capabilities.c | 4 + src/conf/domain_capabilities.h | 2 + src/conf/domain_conf.c | 8 ++ src/conf/domain_conf.h | 1 + src/cpu/cpu_x86.c | 34 +----- src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 47 ++++++++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 1 + src/qemu/qemu_driver.c | 59 ++++++++-- src/qemu/qemu_monitor.c | 13 +++ src/qemu/qemu_monitor.h | 9 ++ src/qemu/qemu_monitor_json.c | 46 ++++++++ src/qemu/qemu_monitor_json.h | 9 ++ src/qemu/qemu_validate.c | 7 ++ src/util/virhostcpu.c | 58 ++++++++++ src/util/virhostcpu.h | 7 ++ .../domaincapsdata/qemu_2.12.0-q35.x86_64.xml | 2 + .../domaincapsdata/qemu_2.12.0-tcg.x86_64.xml | 2 + tests/domaincapsdata/qemu_2.12.0.x86_64.xml | 2 + .../domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 2 + .../domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 2 + tests/domaincapsdata/qemu_6.0.0.x86_64.xml | 2 + .../domaincapsdata/qemu_6.2.0-q35.x86_64.xml | 7 +- .../domaincapsdata/qemu_6.2.0-tcg.x86_64.xml | 7 +- tests/domaincapsdata/qemu_6.2.0.x86_64.xml | 7 +- .../caps_2.12.0.x86_64.replies | 97 ++++++++++++---- .../caps_3.0.0.x86_64.replies | 97 ++++++++++++---- .../caps_3.1.0.x86_64.replies | 97 ++++++++++++---- .../caps_4.0.0.x86_64.replies | 97 ++++++++++++---- .../caps_4.1.0.x86_64.replies | 89 ++++++++++---- .../caps_4.2.0.x86_64.replies | 89 ++++++++++---- .../caps_5.0.0.x86_64.replies | 89 ++++++++++---- .../caps_5.1.0.x86_64.replies | 89 ++++++++++---- .../caps_5.2.0.x86_64.replies | 89 ++++++++++---- .../caps_6.0.0.x86_64.replies | 89 ++++++++++---- .../caps_6.1.0.x86_64.replies | 89 ++++++++++---- .../caps_6.2.0.x86_64.replies | 109 ++++++++++++++---- .../caps_6.2.0.x86_64.xml | 8 ++ tests/qemumonitorjsontest.c | 43 +++++++ ...unch-security-sev-direct.x86_64-6.2.0.args | 40 +++++++ .../launch-security-sev-direct.xml | 39 +++++++ tests/qemuxml2argvtest.c | 1 + tests/testutilsqemu.c | 21 ++++ tools/virsh-domain.c | 53 +++++++++ tools/virsh-host.c | 45 ++++++++ 53 files changed, 1514 insertions(+), 299 deletions(-) create mode 100644 tests/qemuxml2argvdata/launch-security-sev-direct.x86_64-6.2.0.args create mode 100644 tests/qemuxml2argvdata/launch-security-sev-direct.xml -- 2.33.1

2 21

[PATCH v7 0/2] Dirty Ring support (Libvirt)
by huangy81＠chinatelecom.cn 14 Dec '21

14 Dec '21

From: "Hyman Huang(黄勇)" <huangy81(a)chinatelecom.cn> v7 - rebase on master - modify the following points according to the advice given by Peter 1. skip the -accel switch and reuse the existing commit d20ebdda2 'qemu: Switch to -accel' 2. remove the post-parse function and do the parse work in virDomainFeaturesKVMDefParse once for all 3. throw an error if "size" not specified when kvm-dirty-ring feature enabled in xml 4. fix the memory leak when parsing xml 5. use macro VIR_ROUND_UP_POWER_OF_TWO to check power-of-two 6. put error messages in one line 7. squash the last 2 commit into 1 8. add test for kvm-dirty-ring feature Thanks for the careful reviews made by Peter. Please review, Thanks! Hyman Ping for this series. I still keep thinking the dirty ring feature is something good to have for libvirt. qemu-6.1 has supported dirty ring feature and followed up with the commit 0e21bf24 "support dirtyrate at the granualrity of vcpu", which is a typical usage scenario of dirty ring. another usage scenario may be the implementation of per-vcpu auto-converge during live migration which is already being reviewed. so we can make full use of dirty ring feature if libvirt supports. and any corrections and comments about this series would be very appreciated. Please review, Thanks! Hyman v6 - rebase on master v5,v4: blank, just make v6 be the the latest version. v3 - rebase master and fix the confilict when apply "conf: introduce dirty_ring_size in struct "_virDomainDef" to current master. v2 - split patchset into 4 patches - leave out the tcg case when building commandline. - handle the VIR_DOMAIN_KVM_DIRTY_RING case independently in , virDomainFeatureDefParse and virDomainDefFeaturesCheckABIStability, do not integrate it with other cases... - add dirty ring size check in virDomainDefFeaturesCheckABIStability - modify zero checks on integers of dirty ring size in a explicit way. - set the default value of dirty ring size in a post-parser callback. - check the absence of kvm_feature in a explicit way. - code clean of virTristateSwitchTypeToString function. this version's modification base on Peter's advices mostly, thanks a lot, please review ! v1 since qemu has introduced a dirty ring feature in 6.1.0, may be it's the right time to introduce dirty ring in libvirt meanwhile. this patch add feature named 'dirty-ring', which enable dirty ring feature when starting vm. to try this out, three things has done in this patchset: - introduce QEMU_CAPS_ACCEL so the the libvirt can use it to select the right option when specifying the accelerator type. - switch the option "-machine accel=xxx" to "-accel xxx" when specifying accelerator type once libvirt build QEMU command line, so that dirty-ring-size property can be passed to qemu when start vm. - introduce dirty_ring_size to hold the ring size configured by user and pass dirty_ring_size when building qemu commandline if dirty ring feature enabled. though dirty ring is per-cpu logically, the size of dirty ring is registered by 'struct kvm' in QEMU. so we would like to place the dirty_ring_size as a property of vm in Libvirt as the QEMU do. the dirty ring feature is disabled by default, and if enabled, the default value of ring size if 4096 if size not configured. for more details about dirty ring and "-accel" option, please refer to: https://lore.kernel.org/qemu-devel/20210108165050.406906-10-peterx@redhat.c… https://lore.kernel.org/qemu-devel/3aa73987-40e8-3619-0723-9f17f73850bd@red… please review, Thanks! Best Regards ! Hyman Huang(黄勇) (2): qemu: support dirty ring feature tests: add test for kvm-dirty-ring feature docs/formatdomain.rst | 18 ++++--- docs/schemas/domaincommon.rng | 10 ++++ src/conf/domain_conf.c | 54 +++++++++++++++++++ src/conf/domain_conf.h | 4 ++ src/qemu/qemu_command.c | 12 +++++ tests/qemuxml2argvdata/kvm-features-off.xml | 1 + tests/qemuxml2argvdata/kvm-features.args | 2 +- tests/qemuxml2argvdata/kvm-features.xml | 1 + tests/qemuxml2xmloutdata/kvm-features-off.xml | 1 + tests/qemuxml2xmloutdata/kvm-features.xml | 1 + 10 files changed, 95 insertions(+), 9 deletions(-) -- 2.27.0

4 8

[libvirt][PATCH v8 0/5] Support query and use SGX
by Haibin Huang 14 Dec '21

14 Dec '21

This patch series provides support for enabling Intel's Software Guard Extensions (SGX) feature in guest VM. Giving the SGX support in QEMU be accepted and will be merged in two days Intel Software Guard Extensions (Intel SGX) is a set of instructions that increases the security of application code and data, giving them more protection from disclosure or modification. Developers can partition sensitive information into enclaves, which are areas of execution in memory with more security protection. The typical flow looks below at very high level: 1. Calls virConnectGetDomainCapabilities API to domain capabilities that includes the following SGX information. <feature> ... <sgx supported='yes'> <epc_size unit='KiB'>N</epc_size> </sgx> </feature> 2. User requests to start a guest calling virCreateXML() with SGX requirement. It should contain <devices> ... <memory model='sgx-epc'> <target> <size unit='KiB'>N</size> </target> </memory> ... </devices> Haibin Huang (2): Get SGX Capabilities from QEMU Transfer Qemu SGX Capabilities to XML Lin Yang (3): conf: Introduce SGX EPC element into device memory xml qemu: Add command-line to generate SGX EPC memory backend Add unit tests for guest VM creation command with SGX EPC docs/schemas/domaincaps.rng | 22 ++- docs/schemas/domaincommon.rng | 1 + src/conf/domain_capabilities.c | 29 ++++ src/conf/domain_capabilities.h | 13 ++ src/conf/domain_conf.c | 6 + src/conf/domain_conf.h | 1 + src/conf/domain_validate.c | 1 + src/libvirt_private.syms | 1 + src/qemu/qemu_alias.c | 6 +- src/qemu/qemu_capabilities.c | 143 +++++++++++++++++- src/qemu/qemu_capabilities.h | 4 + src/qemu/qemu_command.c | 41 ++++- src/qemu/qemu_domain.c | 12 +- src/qemu/qemu_domain_address.c | 6 + src/qemu/qemu_driver.c | 1 + src/qemu/qemu_monitor.c | 10 ++ src/qemu/qemu_monitor.h | 3 + src/qemu/qemu_monitor_json.c | 83 ++++++++++ src/qemu/qemu_monitor_json.h | 3 + src/qemu/qemu_process.c | 2 + src/qemu/qemu_validate.c | 8 + src/security/security_apparmor.c | 1 + src/security/security_dac.c | 2 + src/security/security_selinux.c | 2 + tests/domaincapsdata/bhyve_basic.x86_64.xml | 1 + tests/domaincapsdata/bhyve_fbuf.x86_64.xml | 1 + tests/domaincapsdata/bhyve_uefi.x86_64.xml | 1 + tests/domaincapsdata/empty.xml | 1 + tests/domaincapsdata/libxl-xenfv.xml | 1 + tests/domaincapsdata/libxl-xenpv.xml | 1 + .../domaincapsdata/qemu_2.11.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.11.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.11.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.11.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.12.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.12.0-tcg.x86_64.xml | 1 + .../qemu_2.12.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.12.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.4.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.4.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.4.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.5.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.5.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.5.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.6.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.6.0-tcg.x86_64.xml | 1 + .../qemu_2.6.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.6.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.6.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_2.6.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.7.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.7.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.7.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.7.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.8.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.8.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.8.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.8.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.9.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.9.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.9.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_2.9.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.9.0.x86_64.xml | 1 + .../domaincapsdata/qemu_3.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_3.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_3.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_3.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_3.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_3.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_3.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_3.1.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_3.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_4.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.0.0-tcg.x86_64.xml | 1 + .../qemu_4.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_4.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 1 + .../qemu_4.2.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.0.0-tcg.x86_64.xml | 1 + .../qemu_5.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_5.1.0.sparc.xml | 1 + tests/domaincapsdata/qemu_5.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.2.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.2.0-tcg.x86_64.xml | 1 + .../qemu_5.2.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_5.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 1 + .../qemu_6.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_6.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_6.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_6.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_6.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_6.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_6.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_6.2.0-q35.x86_64.xml | 4 + .../domaincapsdata/qemu_6.2.0-tcg.x86_64.xml | 4 + tests/domaincapsdata/qemu_6.2.0.x86_64.xml | 4 + .../caps_6.2.0.x86_64.replies | 22 ++- .../caps_6.2.0.x86_64.xml | 5 + .../sgx-epc.x86_64-6.2.0.args | 37 +++++ tests/qemuxml2argvdata/sgx-epc.xml | 36 +++++ tests/qemuxml2argvtest.c | 2 + 126 files changed, 597 insertions(+), 12 deletions(-) create mode 100644 tests/qemuxml2argvdata/sgx-epc.x86_64-6.2.0.args create mode 100644 tests/qemuxml2argvdata/sgx-epc.xml -- 2.17.1

3 9

[libvirt PATCH 00/20] use g_auto for virCommand (Episode II: The Sequel)
by Ján Tomko 14 Dec '21

14 Dec '21

TBD: docs/ and src/util Ján Tomko (20): openvz: refactor openvzExtractVersionInfo openvz: refactor openvzLoadDomains openvz: refactor openvzGetVEID openvz: refactor openvzDomainDefineCmd openvz: refactor openvzSetInitialConfig openvz: refactor openvzSetDiskQuota openvz: refactor openvzDomainSetNetwork openvz: refactor openvzConnectListDomains openvz: refactor openvzConnectListDefinedDomains openvz: refactor openvzDomainGetBarrierLimit openvz: refactor openvzDomainSetBarrierLimit openvz: refactor openvzGetVEStatus openvz: use g_auto in openvzDomainMigratePerform3Params openvz: refactor openvzVEGetStringParam vz: utils: use g_auto for virCommand vmware: refactor vmwareUpdateVMStatus vmware: use g_auto in vmwareLoadDomains vmware: refactor vmwareExtractVersion tests: use g_auto in testCompareXMLToConfFiles tests: storagevolxml2argvtest: do not reuse cmd src/openvz/openvz_conf.c | 62 ++++------- src/openvz/openvz_driver.c | 197 +++++++++++++-------------------- src/openvz/openvz_util.c | 23 ++-- src/vmware/vmware_conf.c | 33 ++---- src/vmware/vmware_driver.c | 19 +--- src/vz/vz_utils.c | 3 +- tests/networkxml2conftest.c | 5 +- tests/storagevolxml2argvtest.c | 4 +- 8 files changed, 125 insertions(+), 221 deletions(-) -- 2.31.1

2 21

[PATCH] conf: Turn virDomainDef.kvm_features into a struct
by Michal Privoznik 14 Dec '21

14 Dec '21

In future commits we will need to store not just an array of VIR_TRISTATE_SWITCH_* but also an additional integer. Follow the example of TCG and introduce a structure where both the array an integer can live. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/conf/domain_conf.c | 20 +++++++++++++------- src/conf/domain_conf.h | 7 ++++++- src/qemu/qemu_command.c | 8 ++++---- 3 files changed, 23 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b6249aa76f..07cbfa24bc 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -3713,6 +3713,7 @@ void virDomainDefFree(virDomainDef *def) g_free(def->emulator); g_free(def->description); g_free(def->title); + g_free(def->kvm_features); g_free(def->hyperv_vendor_id); g_free(def->tcg_features); @@ -17532,7 +17533,9 @@ static int virDomainFeaturesKVMDefParse(virDomainDef *def, xmlNodePtr node) { - def->features[VIR_DOMAIN_FEATURE_KVM] = VIR_TRISTATE_SWITCH_ON; + g_autofree virDomainFeatureKVM *kvm = NULL; + + kvm = g_new0(virDomainFeatureKVM, 1); node = xmlFirstElementChild(node); while (node) { @@ -17551,11 +17554,14 @@ virDomainFeaturesKVMDefParse(virDomainDef *def, &value) < 0) return -1; - def->kvm_features[feature] = value; + kvm->features[feature] = value; node = xmlNextElementSibling(node); } + def->features[VIR_DOMAIN_FEATURE_KVM] = VIR_TRISTATE_SWITCH_ON; + def->kvm_features = g_steal_pointer(&kvm); + return 0; } @@ -21803,13 +21809,13 @@ virDomainDefFeaturesCheckABIStability(virDomainDef *src, case VIR_DOMAIN_KVM_DEDICATED: case VIR_DOMAIN_KVM_POLLCONTROL: case VIR_DOMAIN_KVM_PVIPI: - if (src->kvm_features[i] != dst->kvm_features[i]) { + if (src->kvm_features->features[i] != dst->kvm_features->features[i]) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("State of KVM feature '%s' differs: " "source: '%s', destination: '%s'"), virDomainKVMTypeToString(i), - virTristateSwitchTypeToString(src->kvm_features[i]), - virTristateSwitchTypeToString(dst->kvm_features[i])); + virTristateSwitchTypeToString(src->kvm_features->features[i]), + virTristateSwitchTypeToString(dst->kvm_features->features[i])); return false; } @@ -27873,11 +27879,11 @@ virDomainDefFormatFeatures(virBuffer *buf, case VIR_DOMAIN_KVM_DEDICATED: case VIR_DOMAIN_KVM_POLLCONTROL: case VIR_DOMAIN_KVM_PVIPI: - if (def->kvm_features[j]) + if (def->kvm_features->features[j]) virBufferAsprintf(&childBuf, "<%s state='%s'/>\n", virDomainKVMTypeToString(j), virTristateSwitchTypeToString( - def->kvm_features[j])); + def->kvm_features->features[j])); break; case VIR_DOMAIN_KVM_LAST: diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index b410922f68..5613d621bb 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2263,6 +2263,11 @@ typedef enum { VIR_ENUM_DECL(virDomainIBS); +typedef struct _virDomainFeatureKVM virDomainFeatureKVM; +struct _virDomainFeatureKVM { + int features[VIR_DOMAIN_KVM_LAST]; +}; + typedef struct _virDomainFeatureTCG virDomainFeatureTCG; struct _virDomainFeatureTCG { unsigned long long tb_cache; /* Stored in KiB */ @@ -2819,7 +2824,7 @@ struct _virDomainDef { int features[VIR_DOMAIN_FEATURE_LAST]; int caps_features[VIR_DOMAIN_PROCES_CAPS_FEATURE_LAST]; int hyperv_features[VIR_DOMAIN_HYPERV_LAST]; - int kvm_features[VIR_DOMAIN_KVM_LAST]; + virDomainFeatureKVM *kvm_features; int msrs_features[VIR_DOMAIN_MSRS_LAST]; int xen_features[VIR_DOMAIN_XEN_LAST]; virDomainXenPassthroughMode xen_passthrough_mode; diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index ce22372749..7cdec9f910 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6765,22 +6765,22 @@ qemuBuildCpuCommandLine(virCommand *cmd, for (i = 0; i < VIR_DOMAIN_KVM_LAST; i++) { switch ((virDomainKVM) i) { case VIR_DOMAIN_KVM_HIDDEN: - if (def->kvm_features[i] == VIR_TRISTATE_SWITCH_ON) + if (def->kvm_features->features[i] == VIR_TRISTATE_SWITCH_ON) virBufferAddLit(&buf, ",kvm=off"); break; case VIR_DOMAIN_KVM_DEDICATED: - if (def->kvm_features[i] == VIR_TRISTATE_SWITCH_ON) + if (def->kvm_features->features[i] == VIR_TRISTATE_SWITCH_ON) virBufferAddLit(&buf, ",kvm-hint-dedicated=on"); break; case VIR_DOMAIN_KVM_POLLCONTROL: - if (def->kvm_features[i] == VIR_TRISTATE_SWITCH_ON) + if (def->kvm_features->features[i] == VIR_TRISTATE_SWITCH_ON) virBufferAddLit(&buf, ",kvm-poll-control=on"); break; case VIR_DOMAIN_KVM_PVIPI: - if (def->kvm_features[i] == VIR_TRISTATE_SWITCH_OFF) + if (def->kvm_features->features[i] == VIR_TRISTATE_SWITCH_OFF) virBufferAddLit(&buf, ",kvm-pv-ipi=off"); break; -- 2.32.0

2 1

[libvirt PATCH] examples: hellolibvirt: fix argc check
by Ján Tomko 14 Dec '21

14 Dec '21

https://gitlab.com/libvirt/libvirt/-/issues/255 Reported-by: Jeremy Alcim Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed as trivial. examples/c/misc/hellolibvirt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/examples/c/misc/hellolibvirt.c b/examples/c/misc/hellolibvirt.c index a598e01be2..39cefe934c 100644 --- a/examples/c/misc/hellolibvirt.c +++ b/examples/c/misc/hellolibvirt.c @@ -107,11 +107,12 @@ main(int argc, char *argv[]) { int ret = 0; virConnectPtr conn; - char *uri; + char *uri = NULL; printf("Attempting to connect to hypervisor\n"); - uri = (argc > 0 ? argv[1] : NULL); + if (argc > 1) + uri = argv[1]; /* virConnectOpenAuth is called here with all default parameters, * except, possibly, the URI of the hypervisor. */ -- 2.31.1

1 0

[PATCH v3 0/4] Introduce TCG domain features
by Michal Privoznik 13 Dec '21

13 Dec '21

v3 of: https://listman.redhat.com/archives/libvir-list/2021-November/msg00194.html Note, patches 1/4 and 2/4 from v2 were pushed already. diff to v2: - Split feature validation into a separate patch - Validate that the size is a multiple of MiB, because that's QEMU's granularity - Remembered to write NEWS entry - Worked in Peter's comments from v2 (mostly to make code more future proof) Michal Prívozník (4): conf: Introduce TCG domain features qemu: Validate TCG feature is enabled only for TCG domains qemu: Generate command line for tb-cache feature NEWS: Document TCG features NEWS.rst | 5 ++ docs/formatdomain.rst | 11 ++++ docs/schemas/domaincommon.rng | 15 ++++- src/conf/domain_conf.c | 58 ++++++++++++++++++- src/conf/domain_conf.h | 7 +++ src/qemu/qemu_command.c | 5 ++ src/qemu/qemu_validate.c | 17 ++++++ ...efault-cpu-tcg-features.x86_64-latest.args | 36 ++++++++++++ .../x86_64-default-cpu-tcg-features.xml | 56 ++++++++++++++++++ tests/qemuxml2argvtest.c | 1 + ...default-cpu-tcg-features.x86_64-latest.xml | 1 + tests/qemuxml2xmltest.c | 1 + 12 files changed, 210 insertions(+), 3 deletions(-) create mode 100644 tests/qemuxml2argvdata/x86_64-default-cpu-tcg-features.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/x86_64-default-cpu-tcg-features.xml create mode 120000 tests/qemuxml2xmloutdata/x86_64-default-cpu-tcg-features.x86_64-latest.xml -- 2.32.0

2 7

[libvirt PATCH 00/14] use g_auto for virCommand (Episode I: The End)
by Ján Tomko 13 Dec '21

13 Dec '21

A partial cleanup. The rest is in progress (TM) Ján Tomko (14): bhyve: refactor virBhyveProbeGrubCaps bhyve: refactor bhyveProbeCapsDeviceHelper bhyve: refactor bhyveProbeCapsFromHelp bhyve: refactor bhyveConnectDomainXMLToNative bhyve: use g_auto in virBhyveProcessStartImpl bhyve: use g_auto in virBhyveProcessStop bhyve: refactor virBhyveProcessBuildBhyveCmd lxc: use g_auto in lxcContainerChild lxc: refactor virLXCProcessBuildControllerCmd lxc: use g_auto for virCommand in virLXCProcessEnsureRootFS storage: logical: use two cmd vars in GetPoolSources storage: util: steal cmd in CreateQemuImgCmdFromVol security: apparmor: use automatic cleanup in load_profile qemu: use automatic cleanup for virCommand src/bhyve/bhyve_capabilities.c | 57 ++++++++++----------------- src/bhyve/bhyve_command.c | 36 ++++++++--------- src/bhyve/bhyve_driver.c | 28 ++++++------- src/bhyve/bhyve_process.c | 25 ++++-------- src/lxc/lxc_container.c | 3 +- src/lxc/lxc_process.c | 14 ++----- src/qemu/qemu_driver.c | 3 +- src/qemu/qemu_interface.c | 3 +- src/qemu/qemu_tpm.c | 4 +- src/security/security_apparmor.c | 15 ++----- src/storage/storage_backend_logical.c | 18 ++++----- src/storage/storage_util.c | 5 +-- 12 files changed, 78 insertions(+), 133 deletions(-) -- 2.31.1

2 15

[PATCH 0/3] split daemon: Support sparse streams
by Michal Privoznik 13 Dec '21

13 Dec '21

See 3/3 for explanation. Michal Prívozník (3): virStreamInData: Allow callback to not rewind the stream rpc: Introduce virNetClientStreamInData() remote_driver: Implement virStreamInData() callback src/libvirt-stream.c | 9 ++++- src/libvirt_remote.syms | 1 + src/remote/remote_daemon_stream.c | 8 ++-- src/remote/remote_driver.c | 26 +++++++++++++ src/rpc/virnetclientstream.c | 61 +++++++++++++++++++++++++++++++ src/rpc/virnetclientstream.h | 4 ++ 6 files changed, 105 insertions(+), 4 deletions(-) -- 2.32.0

3 11

[libvirt PATCH 0/8] Use g_auto for virCaps and LXCDriverConfig (glib chronicles)
by Ján Tomko 13 Dec '21

13 Dec '21

Pipeline in progress: https://gitlab.com/janotomko/libvirt/-/pipelines/427100328 Ján Tomko (8): lxc: fix error value of lxcNodeGetSecurityModel Use g_auto for freeing virCaps Use g_auto for stealing virCaps lxc: define cleanup function for virLXCDriverConfig lxc: use g_auto for virLXCDriverGetConfig lxc: remove cleanup from lxcNodeGetSecurityModel bhyve: bhyveConnectCompareCPU: remove cleanup label Remove empty cleanup sections src/bhyve/bhyve_driver.c | 46 ++++++---------- src/ch/ch_conf.c | 14 ++--- src/ch/ch_driver.c | 3 +- src/hyperv/hyperv_driver.c | 10 ++-- src/libxl/libxl_capabilities.c | 14 ++--- src/libxl/libxl_conf.c | 11 ++-- src/libxl/xen_common.c | 8 +-- src/libxl/xen_xl.c | 32 ++++------- src/lxc/lxc_conf.c | 18 +++---- src/lxc/lxc_conf.h | 2 + src/lxc/lxc_container.c | 12 ++--- src/lxc/lxc_driver.c | 97 ++++++++++++---------------------- src/lxc/lxc_native.c | 41 +++++--------- src/lxc/lxc_process.c | 44 +++++---------- src/test/test_driver.c | 14 ++--- src/util/vircgroup.c | 12 ++--- src/util/virfirmware.c | 18 +++---- src/vmware/vmware_conf.c | 5 +- src/vz/vz_driver.c | 20 +++---- tests/qemucaps2xmltest.c | 14 ++--- tests/testutilsxen.c | 5 +- tests/vboxsnapshotxmltest.c | 8 +-- tests/virconftest.c | 24 ++++----- tests/virfiletest.c | 14 ++--- tests/virstringtest.c | 16 +++--- 25 files changed, 174 insertions(+), 328 deletions(-) -- 2.31.1

2 10

[libvirt PATCH] qemu: qemuBuildChardevCommand: use chrSourcePriv unconditionally
by Ján Tomko 13 Dec '21

13 Dec '21

In the QEMU driver, we allocate private source data unconditionally for every chardev and the rest of the function just assumes it's there. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pointed out by Coverity. src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 613f7a5d2a..0017cf6ca7 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -1493,7 +1493,7 @@ qemuBuildChardevCommand(virCommand *cmd, * secinfo is added only to a TCP serial device during * qemuDomainSecretChardevPrepare. Subsequently called * functions can just check the config fields */ - if (chrSourcePriv && chrSourcePriv->secinfo) { + if (chrSourcePriv->secinfo) { if (qemuBuildObjectSecretCommandLine(cmd, chrSourcePriv->secinfo, qemuCaps) < 0) -- 2.31.1

2 1

[libvirt PATCH v2 00/12] Improve AMD SEV support
by Daniel P. Berrangé 13 Dec '21

13 Dec '21

This addresses a few issues in the AMD SEV support - Neither host or domain level SEV metadata is exposed in virsh commands - The domain launch security parameters don't expose enough info to validate the measurement - Support verified direct kernel boot - Report max SEV/SEV-ES guest counts The second point was the initial purpose of my work. Per the SEV API guide to calculate the measurement we need measurement = HMAC(0x04 || API_MAJOR || API_MINOR || BUILD || GCTX.POLICY || GCTX.LD || MNONCE; GCTX.TIK) The API_MINOR, API_MAJOR, BUILD values are things that are available from 'query-sev' QMP command and libvirt does not expose this info. This patch series adds them to virDomainGetLaunchSecurityParams alongside the measurement that we already report. So now the client can fetch this info and calculate an expected measurement to compare with the actual measurement they got. They will thus know if the guest is safe to inject secrets into, which is where Jim's recent patches come into play. Daniel P. Berrangé (12): include: add new launch security parameters qemu: report error querying launch params for inactive guest qemu: add monitor APIs for query-sev qemu: report new launch security parameters tools: add 'domlaunchsecinfo' virsh command tools: add 'nodesevinfo' virsh command conf: extend domain capabilities for max SEV guest count include: define parameters for reporting SEV guest limits qemu: report max number of SEV guests conf: add support for setting SEV kernel hashes qemu: probe for sev-guest.kernel-hashes property qemu: format sev-guest.kernel-hashes property docs/formatdomain.rst | 7 +- docs/formatdomaincaps.html.in | 6 + docs/manpages/virsh.rst | 31 +++++ docs/schemas/domaincaps.rng | 6 + docs/schemas/domaincommon.rng | 5 + include/libvirt/libvirt-domain.h | 32 +++++ include/libvirt/libvirt-host.h | 16 +++ src/conf/domain_capabilities.c | 4 + src/conf/domain_capabilities.h | 2 + src/conf/domain_conf.c | 8 ++ src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 46 ++++++++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 7 ++ src/qemu/qemu_driver.c | 59 ++++++++-- src/qemu/qemu_monitor.c | 13 +++ src/qemu/qemu_monitor.h | 9 ++ src/qemu/qemu_monitor_json.c | 46 ++++++++ src/qemu/qemu_monitor_json.h | 9 ++ src/qemu/qemu_validate.c | 8 ++ .../domaincapsdata/qemu_2.12.0-q35.x86_64.xml | 2 + .../domaincapsdata/qemu_2.12.0-tcg.x86_64.xml | 2 + tests/domaincapsdata/qemu_2.12.0.x86_64.xml | 2 + .../domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 2 + .../domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 2 + tests/domaincapsdata/qemu_6.0.0.x86_64.xml | 2 + .../domaincapsdata/qemu_6.2.0-q35.x86_64.xml | 7 +- .../domaincapsdata/qemu_6.2.0-tcg.x86_64.xml | 7 +- tests/domaincapsdata/qemu_6.2.0.x86_64.xml | 7 +- .../caps_2.12.0.x86_64.replies | 97 ++++++++++++---- .../caps_3.0.0.x86_64.replies | 97 ++++++++++++---- .../caps_3.1.0.x86_64.replies | 97 ++++++++++++---- .../caps_4.0.0.x86_64.replies | 97 ++++++++++++---- .../caps_4.1.0.x86_64.replies | 89 ++++++++++---- .../caps_4.2.0.x86_64.replies | 89 ++++++++++---- .../caps_5.0.0.x86_64.replies | 89 ++++++++++---- .../caps_5.1.0.x86_64.replies | 89 ++++++++++---- .../caps_5.2.0.x86_64.replies | 89 ++++++++++---- .../caps_6.0.0.x86_64.replies | 89 ++++++++++---- .../caps_6.1.0.x86_64.replies | 89 ++++++++++---- .../caps_6.2.0.x86_64.replies | 109 ++++++++++++++---- .../caps_6.2.0.x86_64.xml | 8 ++ tests/qemumonitorjsontest.c | 43 +++++++ ...unch-security-sev-direct.x86_64-6.2.0.args | 40 +++++++ .../launch-security-sev-direct.xml | 39 +++++++ tests/qemuxml2argvtest.c | 1 + tools/virsh-domain.c | 53 +++++++++ tools/virsh-host.c | 45 ++++++++ 48 files changed, 1427 insertions(+), 271 deletions(-) create mode 100644 tests/qemuxml2argvdata/launch-security-sev-direct.x86_64-6.2.0.args create mode 100644 tests/qemuxml2argvdata/launch-security-sev-direct.xml -- 2.33.1

2 24

[PATCH] qemuProcessPrepareHost: Create domain private dirs as early as possible
by Michal Privoznik 13 Dec '21

13 Dec '21

As of ff024b60cc3 we are opening chardevs before starting QEMU. However, we also doing that before domain private directories are created. This leaves us impossible to create guest agent socket which lives under priv->channelTargetDir. While creating the dirs can be moved just before qemuProcessPrepareHostBackendChardev() it's better to do it as the very first step so that this kind of error is prevented in future. Fixes: ff024b60cc39d5d41b1e68728a00a47e103ec4dd Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_process.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 4963ce383f..82d0af5549 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -7024,6 +7024,14 @@ qemuProcessPrepareHost(virQEMUDriver *driver, qemuDomainObjPrivate *priv = vm->privateData; g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(driver); + /* + * Create all per-domain directories in order to make sure domain + * with any possible seclabels can access it. + */ + if (qemuProcessMakeDir(driver, vm, priv->libDir) < 0 || + qemuProcessMakeDir(driver, vm, priv->channelTargetDir) < 0) + return -1; + if (qemuPrepareNVRAM(driver, vm) < 0) return -1; @@ -7085,14 +7093,6 @@ qemuProcessPrepareHost(virQEMUDriver *driver, return -1; } - /* - * Create all per-domain directories in order to make sure domain - * with any possible seclabels can access it. - */ - if (qemuProcessMakeDir(driver, vm, priv->libDir) < 0 || - qemuProcessMakeDir(driver, vm, priv->channelTargetDir) < 0) - return -1; - VIR_DEBUG("Write domain masterKey"); if (qemuDomainWriteMasterKeyFile(driver, vm) < 0) return -1; -- 2.32.0

4 3

[libvirt PATCH] nss: Use shared_library() for nss_libvirt_lib
by Andrea Bolognani 13 Dec '21

13 Dec '21

shared_module() is intended for shared objects that are loaded at runtime using dlopen() whereas NSS plugins need to be full-fledged shared libraries with, among other things, a proper SONAME. Meson seems to have become more strict about this recently, because libnss_libvirt.so.2 gets a SONAME when I build it with Meson 0.59.4 on Fedora 34 but doesn't when I use Meson 0.60.2 on Debian testing instead. Either way, shared_library() was always the right function to use for NSS plugins. Fixes: 36780c931900555706fd6db9fc2ce2b4cabf9045 Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- tools/nss/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/nss/meson.build b/tools/nss/meson.build index 198936f3d4..f77309ebca 100644 --- a/tools/nss/meson.build +++ b/tools/nss/meson.build @@ -59,7 +59,7 @@ nss_libvirt_guest_syms = '@0@@1@'.format( meson.current_source_dir() / nss_guest_sym_file, ) -nss_libvirt_lib = shared_module( +nss_libvirt_lib = shared_library( 'nss_libvirt', name_prefix: nss_prefix, name_suffix: 'so.@0@'.format(nss_so_ver), -- 2.31.1

3 2

[PATCH 00/24] chardev handling cleanups (chardev refactors part 2)
by Peter Krempa 13 Dec '21

13 Dec '21

In this part I'm cleaning up the command line generators and unifying them. Until now there were multiple custom -chardev generators in places where it was simpler to use it than the common code. This series fixes the common code to have sane API and refactors virtiofs, vhost-user-blk vhost-user-gpu and TPM code to use it. After this series we are left with 3 distinct generators for chardev properties: - commandline - commandline for capabilties probing - QMP After the refactors here we can finally also add DO_TEST_CAPS_LATEST of chardev tests without actually touching the host as part of the testsuite which was impossible before. In further parts the generators will be put into one place and prepared for upcoming qemu refactors. Peter Krempa (24): virDomainDeviceInfoIterateFlags: Export the symbol qemu: domain: Introduce helpers for initializing chardev backend of devices qemu: Move creation and opening of chardev backend FDs to host prepare step qemu: command: Remove unused QEMU_BUILD_CHARDEV_FILE_LOGD and QEMU_BUILD_CHARDEV_UNIX_FD_PASS qemu: command: remove the unused 'chardevStdioLogd' argument/variable qemu: domain: Refactor chardev definition preparing qemu: Store chardev 'wait' flag in chardev source private data qemuBuildChrChardevStr: Remove 'cdevflags' argument qemuBuildChrChardevStr: Remove unused arguments and clean up callers qemuxml2argvtest: Add DO_TEST_CAPS_LATEST versions for all character device tests qemuxml2argvtest: Add _LATEST version for 'name-escape' case qemuBuildConsoleCommandLine: Remove identical code qemuBuildChrChardevStr: Directly generate command line qemuBuildChardevCommand: Move earlier qemuBuildChardevCommand: Don't prefix alias qemuBuildChardevCommand: Split creation of the command and setup of other objects qemu: Store TLS config options for chardevs in qemuDomainChrSourcePrivate qemuBuildChardevCommand: Remove unused 'cfg' parameter qemu: Implement chardev source setup for disk qemu: Use qemuBuildChrChardevCommand for vhost-user disk backend qemu: Use qemuBuildChrChardevCommand for virtiofs backend chardev qemu: Use qemuBuildChrChardevCommand for vhost-user-gpu backend chardev qemu: Implement chardev source setup for tpm qemu: command: Use 'qemuBuildChrChardevCommand' to build TPM backend src/libvirt_private.syms | 1 + src/qemu/qemu_block.c | 1 - src/qemu/qemu_block.h | 1 - src/qemu/qemu_command.c | 1095 +++++++---------- src/qemu/qemu_command.h | 2 - src/qemu/qemu_domain.c | 258 +++- src/qemu/qemu_domain.h | 38 +- src/qemu/qemu_driver.c | 8 + src/qemu/qemu_hotplug.c | 3 - src/qemu/qemu_process.c | 264 +++- .../aarch64-tpm.aarch64-latest.args | 2 +- .../console-compat-auto.x86_64-latest.args | 39 + .../console-compat-chardev.x86_64-latest.args | 39 + .../console-compat.x86_64-latest.args | 38 + .../name-escape.x86_64-latest.args | 51 + ...arallel-parport-chardev.x86_64-latest.args | 39 + .../parallel-tcp-chardev.x86_64-latest.args | 39 + .../pci-serial-dev-chardev.x86_64-latest.args | 39 + .../ppc64-tpmproxy-with-tpm.ppc64-latest.args | 2 +- ...rial-dev-chardev-iobase.x86_64-latest.args | 39 + .../serial-dev-chardev.x86_64-latest.args | 39 + .../serial-file-chardev.x86_64-latest.args | 40 + .../serial-file-log.x86_64-latest.args | 40 + .../serial-many-chardev.x86_64-latest.args | 42 + .../serial-pty-chardev.x86_64-latest.args | 39 + ...erial-spiceport-nospice.x86_64-latest.args | 37 + .../serial-spiceport.x86_64-latest.args | 41 + .../serial-tcp-chardev.x86_64-latest.args | 39 + ...rial-tcp-telnet-chardev.x86_64-latest.args | 39 + ...p-tlsx509-chardev-notls.x86_64-latest.args | 41 + ...-tlsx509-chardev-verify.x86_64-latest.args | 42 + ...ial-tcp-tlsx509-chardev.x86_64-latest.args | 42 + ...-tlsx509-secret-chardev.x86_64-latest.args | 43 + .../serial-udp-chardev.x86_64-latest.args | 41 + ...rial-unix-missing-source.x86_64-latest.err | 1 + .../serial-vc-chardev.x86_64-latest.args | 39 + .../tpm-emulator-spapr.ppc64-latest.args | 2 +- .../tpm-emulator-tpm2-enc.x86_64-latest.args | 2 +- ...pm-emulator-tpm2-pstate.x86_64-latest.args | 2 +- .../tpm-emulator-tpm2.x86_64-latest.args | 2 +- .../tpm-emulator.x86_64-latest.args | 2 +- ...host-user-gpu-secondary.x86_64-latest.args | 2 +- ...irtio-options-video-ats.x86_64-latest.args | 2 +- ...tio-options-video-iommu.x86_64-latest.args | 2 +- ...io-options-video-packed.x86_64-latest.args | 2 +- tests/qemuxml2argvtest.c | 114 ++ 46 files changed, 1959 insertions(+), 776 deletions(-) create mode 100644 tests/qemuxml2argvdata/console-compat-auto.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/console-compat-chardev.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/console-compat.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/name-escape.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/parallel-parport-chardev.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/parallel-tcp-chardev.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/pci-serial-dev-chardev.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/serial-dev-chardev-iobase.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/serial-dev-chardev.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/serial-file-chardev.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/serial-file-log.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/serial-many-chardev.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/serial-pty-chardev.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/serial-spiceport-nospice.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/serial-spiceport.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/serial-tcp-chardev.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/serial-tcp-telnet-chardev.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/serial-tcp-tlsx509-chardev-notls.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/serial-tcp-tlsx509-chardev-verify.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/serial-tcp-tlsx509-chardev.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/serial-tcp-tlsx509-secret-chardev.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/serial-udp-chardev.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/serial-unix-missing-source.x86_64-latest.err create mode 100644 tests/qemuxml2argvdata/serial-vc-chardev.x86_64-latest.args -- 2.31.1

3 29

[libvirt PATCH 00/12] Clean up cruft in firewall/iptables code (in preparation for nftables)
by Laine Stump 13 Dec '21

13 Dec '21

These patches make no functional change, they just remove a bunch of cruft that accumulated over the years and is no longer needed. This is all in advance of adding support for native nftable support, but there is nothing nftables-specific being added here; I just wanted to get these cleanups out of way now so that the eventual nftables support patchset is smaller and less complicated. (NB: the concept of a "firewall backend" is being removed here, implying that it will no longer exist. This is not true, but the way that it will exist in the future will be different (per-firewall object rather than per-process) so almost all of the existing code won't be applicable anyway.) Laine Stump (12): network: eliminate code that uses default iptables chains util: rename/move iptablesFormatNetwork to virSocketAddrFormatWithPrefix util: rename iptables operators to something less generic tests: remove firewalld backend tests from virfirewalltest.c tests: remove unnecessary ret variables and cleanup labels tests: document why virgdbus must be mocked in networkxml2firewalltest.c util: eliminate pointless switch in virFirewallApplyRule util: simplify virFirewallBackendSynchronize() util: move and rename virFirewallBackendSynchronize() util: remove check for iptables binary during virFirewallInit util: remove currentBackend from virfirewall.c util: remove virFirewallOnceInit() src/libvirt_private.syms | 5 +- src/network/bridge_driver_linux.c | 37 +-- src/util/virfirewall.c | 143 +---------- src/util/virfirewall.h | 2 - src/util/virfirewalld.c | 43 ++++ src/util/virfirewalld.h | 2 + src/util/virfirewallpriv.h | 37 --- src/util/viriptables.c | 207 +++++++--------- src/util/viriptables.h | 2 - src/util/virsocketaddr.c | 44 ++++ src/util/virsocketaddr.h | 3 + tests/networkxml2firewalltest.c | 14 +- tests/nwfilterebiptablestest.c | 7 - tests/nwfilterxml2firewalltest.c | 8 +- tests/virfirewalltest.c | 390 ++++-------------------------- 15 files changed, 247 insertions(+), 697 deletions(-) delete mode 100644 src/util/virfirewallpriv.h -- 2.33.1

2 13

[PATCH] Fixes: #253
by JorhsonDeng 13 Dec '21

13 Dec '21

To resolve the bug: #253. The restore method should call the qemuProcessRefreshState method to refreash the state of the devices. --- src/qemu/qemu_process.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 6b83a571b9..ebd60a7b84 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -7703,14 +7703,11 @@ qemuProcessStart(virConnectPtr conn, if (incoming->deferredURI && qemuMigrationDstRun(driver, vm, incoming->deferredURI, asyncJob) < 0) goto stop; - } else { - /* Refresh state of devices from QEMU. During migration this happens - * in qemuMigrationDstFinish to ensure that state information is fully - * transferred. */ - if (qemuProcessRefreshState(driver, vm, asyncJob) < 0) - goto stop; } + if (qemuProcessRefreshState(driver, vm, asyncJob) < 0) + goto stop; + if (qemuProcessFinishStartup(driver, vm, asyncJob, !(flags & VIR_QEMU_PROCESS_START_PAUSED), incoming ? -- 2.27.0

3 2

[libvirt PATCH 0/6] Improve usage information and manual pages
by Andrea Bolognani 10 Dec '21

10 Dec '21

Each of the tools we ship as part of libvirt should display reasonable usage information when called without arguments and have an associated manual page. Andrea Bolognani (6): virt-ssh-helper: Don't use optind virt-ssh-helper: Improve usage information virt-ssh-helper: Add manual page virt-qemu-run: Improve usage information virt-qemu-run: Improve manual page virt-pki-query-dn: Add manual page docs/manpages/meson.build | 2 + docs/manpages/virt-pki-query-dn.rst | 91 +++++++++++++++++++++++++++ docs/manpages/virt-qemu-run.rst | 53 +++++++++------- docs/manpages/virt-ssh-helper.rst | 96 +++++++++++++++++++++++++++++ libvirt.spec.in | 2 + src/qemu/qemu_shim.c | 2 +- src/remote/remote_ssh_helper.c | 18 +++--- 7 files changed, 234 insertions(+), 30 deletions(-) create mode 100644 docs/manpages/virt-pki-query-dn.rst create mode 100644 docs/manpages/virt-ssh-helper.rst -- 2.31.1

2 15

[libvirt PATCH v2 00/17] cgroup and thread management in ch driver
by Praveen K Paladugu 10 Dec '21

10 Dec '21

I addressed all the open comments on the v1 patch set. In places where indentaion was hard to manage, I created explicit commits to apply correct indentation on files. Compared to v1, this version applies 2 code refactors: 1) some cgroup methods in src/qemu/qemu_cgroup.c were moved to src/hypervisor and shared with ch driver. 2) virProcessGetStatInfo, virProcessGetSchedInfo which were copied from qemu driver are moved to util and shared between qemu and ch drviers. Praveen K Paladugu (9): util: fix indentation in virprocess.c util: Helper functions to get process info ch_domain: fix indentation in ch_domain ch_driver: fix indentation in ch_driver ch_driver,ch_domain: vcpu info getter callbacks ch_monitor: fix indentation in ch_monitor.c qemu,hypervisor: refactor some cgroup mgmt methods ch_process: Setup emulator and iothread settings ch_driver: emulator threadinfo & pinning callbacks Vineeth Pillai (8): ch_domain: add virCHDomainGetMonitor helper method ch_domain: add methods to manage private vcpu data ch_driver: domainGetVcpuPinInfo and nodeGetCPUMap ch_monitor: Get nicindexes in prep for cgroup mgmt ch: methods for cgroup mgmt in ch driver ch_driver,ch_domain: vcpupin callback in ch driver ch_driver: enable typed param string for numatune ch_driver: add numatune callbacks for CH driver src/ch/ch_conf.c | 2 + src/ch/ch_conf.h | 6 +- src/ch/ch_domain.c | 302 ++++++--- src/ch/ch_domain.h | 32 +- src/ch/ch_driver.c | 1045 ++++++++++++++++++++++++++++---- src/ch/ch_monitor.c | 533 +++++++++++----- src/ch/ch_monitor.h | 60 +- src/ch/ch_process.c | 386 +++++++++++- src/ch/ch_process.h | 3 + src/ch/meson.build | 1 + src/hypervisor/domain_cgroup.c | 426 ++++++++++++- src/hypervisor/domain_cgroup.h | 52 ++ src/libvirt_private.syms | 12 + src/qemu/qemu_cgroup.c | 410 +------------ src/qemu/qemu_cgroup.h | 11 - src/qemu/qemu_driver.c | 130 +--- src/qemu/qemu_hotplug.c | 4 +- src/qemu/qemu_process.c | 17 +- src/util/virprocess.c | 609 +++++++++++-------- src/util/virprocess.h | 5 + 20 files changed, 2905 insertions(+), 1141 deletions(-) -- 2.27.0

2 28

[libvirt PATCH v3] qemu: Enable unprivileged userfaultfd for post-copy migration
by Jiri Denemark 10 Dec '21

10 Dec '21

Userfaultfd is by default allowed only for privileged processes. Since libvirt runs QEMU unprivileged, we need to enable unprivileged access to userfaultfd to enable post-copy migration. https://bugzilla.redhat.com/show_bug.cgi?id=1945420 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- Notes: If you wonder about the 60-* prefix of the installed sysctl file, we already install 60-libvirtd.conf so I think it makes sense to use the same prefix for all sysctl configuration installed by libvirt. Version 2: - setting unprivileged_userfaultfd only when it is not already enabled - virReportSystemError replaced with VIR_WARN Version 3: - set the knob via a sysctl conf file instead libvirt.spec.in | 1 + src/qemu/meson.build | 8 ++++++++ src/qemu/postcopy-migration.sysctl | 6 ++++++ 3 files changed, 15 insertions(+) create mode 100644 src/qemu/postcopy-migration.sysctl diff --git a/libvirt.spec.in b/libvirt.spec.in index 5a079cdaf3..3aa4cc75b5 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1859,6 +1859,7 @@ exit 0 %files daemon-driver-qemu %config(noreplace) %{_sysconfdir}/sysconfig/virtqemud %config(noreplace) %{_sysconfdir}/libvirt/virtqemud.conf +%config(noreplace) %{_prefix}/lib/sysctl.d/60-qemu-postcopy-migration.conf %{_datadir}/augeas/lenses/virtqemud.aug %{_datadir}/augeas/lenses/tests/test_virtqemud.aug %{_unitdir}/virtqemud.service diff --git a/src/qemu/meson.build b/src/qemu/meson.build index 3898d23877..66ef594006 100644 --- a/src/qemu/meson.build +++ b/src/qemu/meson.build @@ -170,6 +170,14 @@ if conf.has('WITH_QEMU') 'file': files('virtqemud.sysconf'), } + if conf.has('WITH_SYSCTL') + install_data( + 'postcopy-migration.sysctl', + install_dir: prefix / 'lib' / 'sysctl.d', + rename: [ '60-qemu-postcopy-migration.conf' ], + ) + endif + virt_install_dirs += [ localstatedir / 'lib' / 'libvirt' / 'qemu', runstatedir / 'libvirt' / 'qemu', diff --git a/src/qemu/postcopy-migration.sysctl b/src/qemu/postcopy-migration.sysctl new file mode 100644 index 0000000000..aa8f015ae0 --- /dev/null +++ b/src/qemu/postcopy-migration.sysctl @@ -0,0 +1,6 @@ +# This is needed to support post-copy migration for QEMU run by libvirt, +# i.e., unprivileged, as userfaultfd is by default only available to +# privileged processes. +# It can be safely overridden by a file in /etc/sysctl.d/ in case post-copy +# migration is not used on the host. +vm.unprivileged_userfaultfd = 1 -- 2.34.1

2 1

[libvirt PATCH] remote: Avoid crash in remoteSplitURIScheme()
by Andrea Bolognani 10 Dec '21

10 Dec '21

We need to make sure the URI scheme is present before passing it to strchr(), otherwise we're going to get $ virt-ssh-helper foo Segmentation fault (core dumped) Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- src/remote/remote_sockets.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/remote/remote_sockets.c b/src/remote/remote_sockets.c index 2979576680..c315b24d30 100644 --- a/src/remote/remote_sockets.c +++ b/src/remote/remote_sockets.c @@ -69,7 +69,15 @@ remoteSplitURIScheme(virURI *uri, char **driver, remoteDriverTransport *transport) { - char *p = strchr(uri->scheme, '+'); + char *p = NULL; + + if (!uri->scheme) { + virReportError(VIR_ERR_INVALID_ARG, "%s", + _("missing scheme for URI")); + return -1; + } + + p = strchr(uri->scheme, '+'); if (p) *driver = g_strndup(uri->scheme, p - uri->scheme); -- 2.31.1

3 5

[PATCH] Revert "lxc: controller: Fix container launch on cgroup v1"
by Michal Privoznik 10 Dec '21

10 Dec '21

Unfortunately, this fix breakes machinectl in a very nasty way, for instance 'machinectl shell' drops into the host shell. It's worse than being unable to start a container with CGroupsV1. Revert until a proper fix is figured out. This reverts commit 1b9ce05ce241a581d4e80228c92ceb0266f21f94. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/lxc/lxc_controller.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c index 039efcd7c7..7c593ee3a9 100644 --- a/src/lxc/lxc_controller.c +++ b/src/lxc/lxc_controller.c @@ -865,12 +865,12 @@ static int virLXCControllerSetupCgroupLimits(virLXCController *ctrl) nodeset = virDomainNumatuneGetNodeset(ctrl->def->numa, auto_nodeset, -1); if (!(ctrl->cgroup = virLXCCgroupCreate(ctrl->def, - getpid(), + ctrl->initpid, ctrl->nnicindexes, ctrl->nicindexes))) goto cleanup; - if (virCgroupAddMachineProcess(ctrl->cgroup, ctrl->initpid) < 0) + if (virCgroupAddMachineProcess(ctrl->cgroup, getpid()) < 0) goto cleanup; /* Add all qemu-nbd tasks to the cgroup */ -- 2.32.0

2 1

Issue labe improvements
by Peter Krempa 10 Dec '21

10 Dec '21

Hi, from time to time when I try to go through upstream issues I always feel that the labels we have are suboptimal and don't always allow to track the current state of the issue. Recently I've had a look at the qemu issues and found what I was lacking. Specifically I'm lacking the 'workflow' class of labels they use. I propose we adopt the following changes: 1) Convert the existing 'bug', 'enhancement', 'support', and 'discussion' labels into a set of scoped labels (again inspiration taken from qemu): kind::bug kind::enhancement kind::support kind::discussion kind::documentation This is mostly as the above kinds are mutually exclusive. 2) Introduce the workflow label similarly to what qemu uses: workflow::Confirmed/Triaged (<- confirmed for bugs, triaged for enhancements) workflow::Needs Info (replaces "needinfo") workflow::In progress (replaces "Doing") I'd also potentially like to have a 'Unconfirmed' state for when the bug has enough info, but it's unknown why it's happening. I want to specifically avoid the ambiguous "Triaged" when used on it's own. 3) Convert host-* labels into a scoped label. Hosts are usually mutually exclusive 4) Convert driver-* into scoped labels. Usually issues are not exceeding these boundaries 5) Remove the following unused or ambiguous labels: - critical - incident - Doing - To Do - gsoc::20* (all seem to be unused) I'm willing to go ahead and re-triage open stuff if nobody objects to the above changes.

4 3

[PATCH 0/2] remote_daemon: Set shutdown callbacks only after init is done
by Michal Privoznik 10 Dec '21

10 Dec '21

*** BLURB HERE *** Michal Prívozník (2): remote_daemon: Set shutdown callbacks only after init is done Revert "qemu: Avoid crash in qemuStateShutdownPrepare() and qemuStateShutdownWait()" src/qemu/qemu_driver.c | 6 ------ src/remote/remote_daemon.c | 7 ++++--- 2 files changed, 4 insertions(+), 9 deletions(-) -- 2.32.0

2 4

[PATCH V2 0/3] Add virDomainSetLaunchSecurityState API
by Jim Fehlig 10 Dec '21

10 Dec '21

V2 of https://listman.redhat.com/archives/libvir-list/2021-November/msg00980.html Like V1, this series is compile-tested only. I plan to work on functional testing soon, after wrapping up some tasks. Changes since V1: - Optional secret set address changed to unsigned long long - Improved documentation - Ensure VM is in paused state - Other small fixes Jim Fehlig (3): libvirt: Introduce virDomainSetLaunchSecurityState public API remote: Add RPC support for the virDomainSetLaunchSecurityState API qemu: Implement the virDomainSetLaunchSecurityState API include/libvirt/libvirt-domain.h | 35 +++++++++++++ src/driver-hypervisor.h | 7 +++ src/libvirt-domain.c | 62 ++++++++++++++++++++++ src/libvirt_public.syms | 5 ++ src/qemu/qemu_driver.c | 88 ++++++++++++++++++++++++++++++++ src/qemu/qemu_monitor.c | 14 +++++ src/qemu/qemu_monitor.h | 7 +++ src/qemu/qemu_monitor_json.c | 45 ++++++++++++++++ src/qemu/qemu_monitor_json.h | 6 +++ src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 17 +++++- src/remote_protocol-structs | 9 ++++ 12 files changed, 295 insertions(+), 1 deletion(-) -- 2.34.1

3 7

[PATCH v1 00/12] Add riscv kvm accel support
by Yifei Jiang 10 Dec '21

10 Dec '21

This series adds both riscv32 and riscv64 kvm support, and implements migration based on riscv. Because of RISC-V KVM has been merged into the Linux master, so this series are changed from RFC to patch v1. Several steps to use this: 1. Build emulation $ ./configure --target-list=riscv64-softmmu $ make -j$(nproc) 2. Build kernel 3. Build QEMU VM Cross built in riscv toolchain. $ PKG_CONFIG_LIBDIR=<toolchain pkgconfig path> $ export PKG_CONFIG_SYSROOT_DIR=<toolchain sysroot path> $ ./configure --target-list=riscv64-softmmu --enable-kvm \ --cross-prefix=riscv64-linux-gnu- --disable-libiscsi --disable-glusterfs \ --disable-libusb --disable-usb-redir --audio-drv-list= --disable-opengl \ --disable-libxml2 $ make -j$(nproc) 4. Start emulation $ ./qemu-system-riscv64 -M virt -m 4096M -cpu rv64,x-h=true -nographic \ -name guest=riscv-hyp,debug-threads=on \ -smp 4 \ -bios ./fw_jump.bin \ -kernel ./Image \ -drive file=./hyp.img,format=raw,id=hd0 \ -device virtio-blk-device,drive=hd0 \ -append "root=/dev/vda rw console=ttyS0 earlycon=sbi" 5. Start kvm-acceled QEMU VM in emulation $ ./qemu-system-riscv64 -M virt,accel=kvm -m 1024M -cpu host -nographic \ -name guest=riscv-guset \ -smp 2 \ -bios none \ -kernel ./Image \ -drive file=./guest.img,format=raw,id=hd0 \ -device virtio-blk-device,drive=hd0 \ -append "root=/dev/vda rw console=ttyS0 earlycon=sbi" Changes since RFC v6 - Rebase on recent commit 8627edfb3f1fca24a96a0954148885c3241c10f8 - Sync-up headers with Linux-5.16-rc1 Changes since RFC v5 - Rebase on QEMU v6.1.0-rc1 and kvm-riscv linux v19. - Move kvm interrupt setting to riscv_cpu_update_mip(). - Replace __u64 with uint64_t. Changes since RFC v4 - Rebase on QEMU v6.0.0-rc2 and kvm-riscv linux v17. - Remove time scaling support as software solution is incomplete. Because it will cause unacceptable performance degradation. and We will post a better solution. - Revise according to Alistair's review comments. - Remove compile time XLEN checks in kvm_riscv_reg_id - Surround TYPE_RISCV_CPU_HOST definition by CONFIG_KVM and share it between RV32 and RV64. - Add kvm-stub.c for reduce unnecessary compilation checks. - Add riscv_setup_direct_kernel() to direct boot kernel for KVM. Changes since RFC v3 - Rebase on QEMU v5.2.0-rc2 and kvm-riscv linux v15. - Add time scaling support(New patches 13, 14 and 15). - Fix the bug that guest vm can't reboot. Changes since RFC v2 - Fix checkpatch error at target/riscv/sbi_ecall_interface.h. - Add riscv migration support. Changes since RFC v1 - Add separate SBI ecall interface header. - Add riscv32 kvm accel support. Yifei Jiang (12): update-linux-headers: Add asm-riscv/kvm.h target/riscv: Add target/riscv/kvm.c to place the public kvm interface target/riscv: Implement function kvm_arch_init_vcpu target/riscv: Implement kvm_arch_get_registers target/riscv: Implement kvm_arch_put_registers target/riscv: Support start kernel directly by KVM target/riscv: Support setting external interrupt by KVM target/riscv: Handle KVM_EXIT_RISCV_SBI exit target/riscv: Add host cpu type target/riscv: Add kvm_riscv_get/put_regs_timer target/riscv: Implement virtual time adjusting with vm state changing target/riscv: Support virtual time context synchronization hw/riscv/boot.c | 11 + hw/riscv/virt.c | 7 + include/hw/riscv/boot.h | 1 + linux-headers/asm-riscv/kvm.h | 128 ++++++ linux-headers/linux/kvm.h | 8 + meson.build | 2 + target/riscv/cpu.c | 57 +++ target/riscv/cpu.h | 10 + target/riscv/cpu_helper.c | 27 -- target/riscv/kvm-stub.c | 30 ++ target/riscv/kvm.c | 610 +++++++++++++++++++++++++++++ target/riscv/kvm_riscv.h | 25 ++ target/riscv/machine.c | 14 + target/riscv/meson.build | 1 + target/riscv/sbi_ecall_interface.h | 72 ++++ 15 files changed, 976 insertions(+), 27 deletions(-) create mode 100644 linux-headers/asm-riscv/kvm.h create mode 100644 target/riscv/kvm-stub.c create mode 100644 target/riscv/kvm.c create mode 100644 target/riscv/kvm_riscv.h create mode 100644 target/riscv/sbi_ecall_interface.h -- 2.19.1

8 34

[PATCH] qemu_monitor_json.h: Unify header formatting
by Peter Krempa 10 Dec '21

10 Dec '21

Use the modern style and fix all offenders since new functions were already using the contemporary style. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_monitor_json.h | 957 ++++++++++++++++++++--------------- 1 file changed, 551 insertions(+), 406 deletions(-) diff --git a/src/qemu/qemu_monitor_json.h b/src/qemu/qemu_monitor_json.h index 0984717675..64064b0519 100644 --- a/src/qemu/qemu_monitor_json.h +++ b/src/qemu/qemu_monitor_json.h @@ -28,61 +28,82 @@ #include "cpu/cpu.h" #include "util/virgic.h" -int qemuMonitorJSONIOProcessLine(qemuMonitor *mon, - const char *line, - qemuMonitorMessage *msg) G_GNUC_NO_INLINE; - -int qemuMonitorJSONIOProcess(qemuMonitor *mon, - const char *data, - size_t len, - qemuMonitorMessage *msg); - -int qemuMonitorJSONHumanCommand(qemuMonitor *mon, - const char *cmd, - char **reply); - -int qemuMonitorJSONSetCapabilities(qemuMonitor *mon); - -int qemuMonitorJSONStartCPUs(qemuMonitor *mon); -int qemuMonitorJSONStopCPUs(qemuMonitor *mon); -int qemuMonitorJSONGetStatus(qemuMonitor *mon, - bool *running, - virDomainPausedReason *reason); - -int qemuMonitorJSONSystemPowerdown(qemuMonitor *mon); -int qemuMonitorJSONSystemReset(qemuMonitor *mon); - -int qemuMonitorJSONQueryCPUs(qemuMonitor *mon, - struct qemuMonitorQueryCpusEntry **entries, - size_t *nentries, - bool force, - bool fast); -int qemuMonitorJSONUpdateVideoMemorySize(qemuMonitor *mon, - virDomainVideoDef *video, - char *path); -int qemuMonitorJSONUpdateVideoVram64Size(qemuMonitor *mon, - virDomainVideoDef *video, - char *path); -int qemuMonitorJSONGetBalloonInfo(qemuMonitor *mon, - unsigned long long *currmem); -int qemuMonitorJSONGetMemoryStats(qemuMonitor *mon, - char *balloonpath, - virDomainMemoryStatPtr stats, - unsigned int nr_stats); -int qemuMonitorJSONSetMemoryStatsPeriod(qemuMonitor *mon, - char *balloonpath, - int period); -int qemuMonitorJSONGetBlockInfo(qemuMonitor *mon, - GHashTable *table); - -virJSONValue *qemuMonitorJSONQueryBlockstats(qemuMonitor *mon, - bool queryNodes); -int qemuMonitorJSONGetAllBlockStatsInfo(qemuMonitor *mon, - GHashTable *hash); -int qemuMonitorJSONBlockStatsUpdateCapacity(qemuMonitor *mon, - GHashTable *stats); -int qemuMonitorJSONBlockStatsUpdateCapacityBlockdev(qemuMonitor *mon, - GHashTable *stats); +int +qemuMonitorJSONIOProcessLine(qemuMonitor *mon, + const char *line, + qemuMonitorMessage *msg) + G_GNUC_NO_INLINE; + +int +qemuMonitorJSONIOProcess(qemuMonitor *mon, + const char *data, + size_t len, + qemuMonitorMessage *msg); + +int +qemuMonitorJSONHumanCommand(qemuMonitor *mon, + const char *cmd, + char **reply); + +int +qemuMonitorJSONSetCapabilities(qemuMonitor *mon); + +int +qemuMonitorJSONStartCPUs(qemuMonitor *mon); +int +qemuMonitorJSONStopCPUs(qemuMonitor *mon); +int +qemuMonitorJSONGetStatus(qemuMonitor *mon, + bool *running, + virDomainPausedReason *reason); + +int +qemuMonitorJSONSystemPowerdown(qemuMonitor *mon); +int +qemuMonitorJSONSystemReset(qemuMonitor *mon); + +int +qemuMonitorJSONQueryCPUs(qemuMonitor *mon, + struct qemuMonitorQueryCpusEntry **entries, + size_t *nentries, + bool force, + bool fast); +int +qemuMonitorJSONUpdateVideoMemorySize(qemuMonitor *mon, + virDomainVideoDef *video, + char *path); +int +qemuMonitorJSONUpdateVideoVram64Size(qemuMonitor *mon, + virDomainVideoDef *video, + char *path); +int +qemuMonitorJSONGetBalloonInfo(qemuMonitor *mon, + unsigned long long *currmem); +int +qemuMonitorJSONGetMemoryStats(qemuMonitor *mon, + char *balloonpath, + virDomainMemoryStatPtr stats, + unsigned int nr_stats); +int +qemuMonitorJSONSetMemoryStatsPeriod(qemuMonitor *mon, + char *balloonpath, + int period); +int +qemuMonitorJSONGetBlockInfo(qemuMonitor *mon, + GHashTable *table); + +virJSONValue * +qemuMonitorJSONQueryBlockstats(qemuMonitor *mon, + bool queryNodes); +int +qemuMonitorJSONGetAllBlockStatsInfo(qemuMonitor *mon, + GHashTable *hash); +int +qemuMonitorJSONBlockStatsUpdateCapacity(qemuMonitor *mon, + GHashTable *stats); +int +qemuMonitorJSONBlockStatsUpdateCapacityBlockdev(qemuMonitor *mon, + GHashTable *stats); GHashTable * qemuMonitorJSONBlockGetNamedNodeDataJSON(virJSONValue *nodes); @@ -91,236 +112,295 @@ GHashTable * qemuMonitorJSONBlockGetNamedNodeData(qemuMonitor *mon, bool supports_flat); -int qemuMonitorJSONBlockResize(qemuMonitor *mon, - const char *device, - const char *nodename, - unsigned long long size); - -int qemuMonitorJSONSetPassword(qemuMonitor *mon, - const char *protocol, - const char *password, - const char *action_if_connected); -int qemuMonitorJSONExpirePassword(qemuMonitor *mon, - const char *protocol, - const char *expire_time); -int qemuMonitorJSONSetBalloon(qemuMonitor *mon, - unsigned long long newmem); - -int qemuMonitorJSONEjectMedia(qemuMonitor *mon, - const char *dev_name, - bool force); -int qemuMonitorJSONChangeMedia(qemuMonitor *mon, - const char *dev_name, - const char *newmedia, - const char *format); - - -int qemuMonitorJSONSaveVirtualMemory(qemuMonitor *mon, - unsigned long long offset, - unsigned long long length, - const char *path); -int qemuMonitorJSONSavePhysicalMemory(qemuMonitor *mon, - unsigned long long offset, - unsigned long long length, - const char *path); - -int qemuMonitorJSONSetMigrationSpeed(qemuMonitor *mon, - unsigned long bandwidth); - -int qemuMonitorJSONSetMigrationDowntime(qemuMonitor *mon, - unsigned long long downtime); - -int qemuMonitorJSONGetMigrationCacheSize(qemuMonitor *mon, - unsigned long long *cacheSize); -int qemuMonitorJSONSetMigrationCacheSize(qemuMonitor *mon, - unsigned long long cacheSize); - -int qemuMonitorJSONGetMigrationParams(qemuMonitor *mon, - virJSONValue **params); -int qemuMonitorJSONSetMigrationParams(qemuMonitor *mon, - virJSONValue **params); +int +qemuMonitorJSONBlockResize(qemuMonitor *mon, + const char *device, + const char *nodename, + unsigned long long size); -int qemuMonitorJSONGetMigrationStats(qemuMonitor *mon, - qemuMonitorMigrationStats *stats, - char **error); +int +qemuMonitorJSONSetPassword(qemuMonitor *mon, + const char *protocol, + const char *password, + const char *action_if_connected); +int +qemuMonitorJSONExpirePassword(qemuMonitor *mon, + const char *protocol, + const char *expire_time); +int +qemuMonitorJSONSetBalloon(qemuMonitor *mon, + unsigned long long newmem); -int qemuMonitorJSONGetMigrationCapabilities(qemuMonitor *mon, - char ***capabilities); -int qemuMonitorJSONSetMigrationCapabilities(qemuMonitor *mon, - virJSONValue **caps); +int +qemuMonitorJSONEjectMedia(qemuMonitor *mon, + const char *dev_name, + bool force); +int +qemuMonitorJSONChangeMedia(qemuMonitor *mon, + const char *dev_name, + const char *newmedia, + const char *format); -int qemuMonitorJSONGetGICCapabilities(qemuMonitor *mon, - virGICCapability **capabilities); +int +qemuMonitorJSONSaveVirtualMemory(qemuMonitor *mon, + unsigned long long offset, + unsigned long long length, + const char *path); +int +qemuMonitorJSONSavePhysicalMemory(qemuMonitor *mon, + unsigned long long offset, + unsigned long long length, + const char *path); -int qemuMonitorJSONGetSEVCapabilities(qemuMonitor *mon, - virSEVCapability **capabilities); +int +qemuMonitorJSONSetMigrationSpeed(qemuMonitor *mon, + unsigned long bandwidth); -int qemuMonitorJSONMigrate(qemuMonitor *mon, - unsigned int flags, - const char *uri); -int qemuMonitorJSONGetSpiceMigrationStatus(qemuMonitor *mon, - bool *spice_migrated); +int +qemuMonitorJSONSetMigrationDowntime(qemuMonitor *mon, + unsigned long long downtime); +int +qemuMonitorJSONGetMigrationCacheSize(qemuMonitor *mon, + unsigned long long *cacheSize); +int +qemuMonitorJSONSetMigrationCacheSize(qemuMonitor *mon, + unsigned long long cacheSize); -int qemuMonitorJSONMigrateCancel(qemuMonitor *mon); +int +qemuMonitorJSONGetMigrationParams(qemuMonitor *mon, + virJSONValue **params); +int +qemuMonitorJSONSetMigrationParams(qemuMonitor *mon, + virJSONValue **params); -int qemuMonitorJSONQueryDump(qemuMonitor *mon, - qemuMonitorDumpStats *stats); +int +qemuMonitorJSONGetMigrationStats(qemuMonitor *mon, + qemuMonitorMigrationStats *stats, + char **error); + +int +qemuMonitorJSONGetMigrationCapabilities(qemuMonitor *mon, + char ***capabilities); +int +qemuMonitorJSONSetMigrationCapabilities(qemuMonitor *mon, + virJSONValue **caps); + +int +qemuMonitorJSONGetGICCapabilities(qemuMonitor *mon, + virGICCapability **capabilities); + +int +qemuMonitorJSONGetSEVCapabilities(qemuMonitor *mon, + virSEVCapability **capabilities); + +int +qemuMonitorJSONMigrate(qemuMonitor *mon, + unsigned int flags, + const char *uri); +int +qemuMonitorJSONGetSpiceMigrationStatus(qemuMonitor *mon, + bool *spice_migrated); -int qemuMonitorJSONGetDumpGuestMemoryCapability(qemuMonitor *mon, - const char *capability); -int qemuMonitorJSONDump(qemuMonitor *mon, - const char *protocol, - const char *dumpformat, - bool detach); +int +qemuMonitorJSONMigrateCancel(qemuMonitor *mon); + +int +qemuMonitorJSONQueryDump(qemuMonitor *mon, + qemuMonitorDumpStats *stats); + +int +qemuMonitorJSONGetDumpGuestMemoryCapability(qemuMonitor *mon, + const char *capability); -int qemuMonitorJSONGraphicsRelocate(qemuMonitor *mon, - int type, - const char *hostname, - int port, - int tlsPort, - const char *tlsSubject); +int +qemuMonitorJSONDump(qemuMonitor *mon, + const char *protocol, + const char *dumpformat, + bool detach); -int qemuMonitorJSONAddPCIHostDevice(qemuMonitor *mon, - virPCIDeviceAddress *hostAddr, - virPCIDeviceAddress *guestAddr); +int +qemuMonitorJSONGraphicsRelocate(qemuMonitor *mon, + int type, + const char *hostname, + int port, + int tlsPort, + const char *tlsSubject); -int qemuMonitorJSONAddPCIDisk(qemuMonitor *mon, - const char *path, - const char *bus, - virPCIDeviceAddress *guestAddr); +int +qemuMonitorJSONAddPCIHostDevice(qemuMonitor *mon, + virPCIDeviceAddress *hostAddr, + virPCIDeviceAddress *guestAddr); + +int +qemuMonitorJSONAddPCIDisk(qemuMonitor *mon, + const char *path, + const char *bus, + virPCIDeviceAddress *guestAddr); -int qemuMonitorJSONAddPCINetwork(qemuMonitor *mon, - const char *nicstr, - virPCIDeviceAddress *guestAddr); +int +qemuMonitorJSONAddPCINetwork(qemuMonitor *mon, + const char *nicstr, + virPCIDeviceAddress *guestAddr); -int qemuMonitorJSONRemovePCIDevice(qemuMonitor *mon, - virPCIDeviceAddress *guestAddr); +int +qemuMonitorJSONRemovePCIDevice(qemuMonitor *mon, + virPCIDeviceAddress *guestAddr); -int qemuMonitorJSONAddFileHandleToSet(qemuMonitor *mon, - int fd, - int fdset, - const char *opaque, - qemuMonitorAddFdInfo *info); +int +qemuMonitorJSONAddFileHandleToSet(qemuMonitor *mon, + int fd, + int fdset, + const char *opaque, + qemuMonitorAddFdInfo *info); -int qemuMonitorJSONRemoveFdset(qemuMonitor *mon, - int fdset); +int +qemuMonitorJSONRemoveFdset(qemuMonitor *mon, + int fdset); -int qemuMonitorJSONQueryFdsets(qemuMonitor *mon, - qemuMonitorFdsets **fdsets); +int +qemuMonitorJSONQueryFdsets(qemuMonitor *mon, + qemuMonitorFdsets **fdsets); -int qemuMonitorJSONSendFileHandle(qemuMonitor *mon, - const char *fdname, - int fd); +int +qemuMonitorJSONSendFileHandle(qemuMonitor *mon, + const char *fdname, + int fd); -int qemuMonitorJSONCloseFileHandle(qemuMonitor *mon, - const char *fdname); +int +qemuMonitorJSONCloseFileHandle(qemuMonitor *mon, + const char *fdname); -int qemuMonitorJSONAddNetdev(qemuMonitor *mon, - virJSONValue **props); +int +qemuMonitorJSONAddNetdev(qemuMonitor *mon, + virJSONValue **props); -int qemuMonitorJSONRemoveNetdev(qemuMonitor *mon, - const char *alias); +int +qemuMonitorJSONRemoveNetdev(qemuMonitor *mon, + const char *alias); -int qemuMonitorJSONQueryRxFilter(qemuMonitor *mon, const char *alias, - virNetDevRxFilter **filter); +int +qemuMonitorJSONQueryRxFilter(qemuMonitor *mon, + const char *alias, + virNetDevRxFilter **filter); -int qemuMonitorJSONGetChardevInfo(qemuMonitor *mon, - GHashTable *info); +int +qemuMonitorJSONGetChardevInfo(qemuMonitor *mon, + GHashTable *info); -int qemuMonitorJSONAttachPCIDiskController(qemuMonitor *mon, - const char *bus, - virPCIDeviceAddress *guestAddr); +int +qemuMonitorJSONAttachPCIDiskController(qemuMonitor *mon, + const char *bus, + virPCIDeviceAddress *guestAddr); -int qemuMonitorJSONAddDeviceProps(qemuMonitor *mon, - virJSONValue **props); +int +qemuMonitorJSONAddDeviceProps(qemuMonitor *mon, + virJSONValue **props); -int qemuMonitorJSONDelDevice(qemuMonitor *mon, - const char *devalias); +int +qemuMonitorJSONDelDevice(qemuMonitor *mon, + const char *devalias); -int qemuMonitorJSONAddObject(qemuMonitor *mon, - virJSONValue **props); +int +qemuMonitorJSONAddObject(qemuMonitor *mon, + virJSONValue **props); -int qemuMonitorJSONDelObject(qemuMonitor *mon, - const char *objalias, - bool report_error); +int +qemuMonitorJSONDelObject(qemuMonitor *mon, + const char *objalias, + bool report_error); -int qemuMonitorJSONTransaction(qemuMonitor *mon, virJSONValue **actions) +int +qemuMonitorJSONTransaction(qemuMonitor *mon, + virJSONValue **actions) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -int qemuMonitorJSONDriveMirror(qemuMonitor *mon, - const char *device, - const char *file, - const char *format, - unsigned long long speed, - unsigned int granularity, - unsigned long long buf_size, - bool shallow, - bool reuse) +int +qemuMonitorJSONDriveMirror(qemuMonitor *mon, + const char *device, + const char *file, + const char *format, + unsigned long long speed, + unsigned int granularity, + unsigned long long buf_size, + bool shallow, + bool reuse) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3); -int qemuMonitorJSONBlockdevMirror(qemuMonitor *mon, - const char *jobname, - bool persistjob, - const char *device, - const char *target, - unsigned long long speed, - unsigned int granularity, - unsigned long long buf_size, - bool shallow, - bool syncWrite) + +int +qemuMonitorJSONBlockdevMirror(qemuMonitor *mon, + const char *jobname, + bool persistjob, + const char *device, + const char *target, + unsigned long long speed, + unsigned int granularity, + unsigned long long buf_size, + bool shallow, + bool syncWrite) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(4) ATTRIBUTE_NONNULL(5); -int qemuMonitorJSONDrivePivot(qemuMonitor *mon, - const char *jobname) + +int +qemuMonitorJSONDrivePivot(qemuMonitor *mon, + const char *jobname) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -int qemuMonitorJSONBlockCommit(qemuMonitor *mon, - const char *device, - const char *jobname, - bool persistjob, - const char *top, - const char *topNode, - const char *base, - const char *baseNode, - const char *backingName, - unsigned long long bandwidth) +int +qemuMonitorJSONBlockCommit(qemuMonitor *mon, + const char *device, + const char *jobname, + bool persistjob, + const char *top, + const char *topNode, + const char *base, + const char *baseNode, + const char *backingName, + unsigned long long bandwidth) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -char *qemuMonitorJSONDiskNameLookup(qemuMonitor *mon, - const char *device, - virStorageSource *top, - virStorageSource *target) +char * +qemuMonitorJSONDiskNameLookup(qemuMonitor *mon, + const char *device, + virStorageSource *top, + virStorageSource *target) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(4); -int qemuMonitorJSONArbitraryCommand(qemuMonitor *mon, - const char *cmd_str, - char **reply_str); +int +qemuMonitorJSONArbitraryCommand(qemuMonitor *mon, + const char *cmd_str, + char **reply_str); -int qemuMonitorJSONInjectNMI(qemuMonitor *mon); +int +qemuMonitorJSONInjectNMI(qemuMonitor *mon); -int qemuMonitorJSONSendKey(qemuMonitor *mon, - unsigned int holdtime, - unsigned int *keycodes, - unsigned int nkeycodes); +int +qemuMonitorJSONSendKey(qemuMonitor *mon, + unsigned int holdtime, + unsigned int *keycodes, + unsigned int nkeycodes); -int qemuMonitorJSONScreendump(qemuMonitor *mon, - const char *device, - unsigned int head, - const char *file); - -int qemuMonitorJSONBlockStream(qemuMonitor *mon, - const char *device, - const char *jobname, - bool persistjob, - const char *base, - const char *baseNode, - const char *backingName, - unsigned long long speed) +int +qemuMonitorJSONScreendump(qemuMonitor *mon, + const char *device, + unsigned int head, + const char *file); + +int +qemuMonitorJSONBlockStream(qemuMonitor *mon, + const char *device, + const char *jobname, + bool persistjob, + const char *base, + const char *baseNode, + const char *backingName, + unsigned long long speed) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -int qemuMonitorJSONBlockJobCancel(qemuMonitor *mon, - const char *jobname, - bool force) +int +qemuMonitorJSONBlockJobCancel(qemuMonitor *mon, + const char *jobname, + bool force) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); int @@ -329,93 +409,114 @@ qemuMonitorJSONGetJobInfo(qemuMonitor *mon, size_t *njobs); -int qemuMonitorJSONBlockJobSetSpeed(qemuMonitor *mon, - const char *jobname, - unsigned long long speed) +int +qemuMonitorJSONBlockJobSetSpeed(qemuMonitor *mon, + const char *jobname, + unsigned long long speed) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -GHashTable *qemuMonitorJSONGetAllBlockJobInfo(qemuMonitor *mon, - bool rawjobname) +GHashTable * +qemuMonitorJSONGetAllBlockJobInfo(qemuMonitor *mon, + bool rawjobname) ATTRIBUTE_NONNULL(1); -int qemuMonitorJSONJobDismiss(qemuMonitor *mon, - const char *jobname) +int +qemuMonitorJSONJobDismiss(qemuMonitor *mon, + const char *jobname) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -int qemuMonitorJSONJobComplete(qemuMonitor *mon, - const char *jobname) +int +qemuMonitorJSONJobComplete(qemuMonitor *mon, + const char *jobname) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -int qemuMonitorJSONSetLink(qemuMonitor *mon, - const char *name, - virDomainNetInterfaceLinkState state); +int +qemuMonitorJSONSetLink(qemuMonitor *mon, + const char *name, + virDomainNetInterfaceLinkState state); -int qemuMonitorJSONOpenGraphics(qemuMonitor *mon, - const char *protocol, - const char *fdname, - bool skipauth); +int +qemuMonitorJSONOpenGraphics(qemuMonitor *mon, + const char *protocol, + const char *fdname, + bool skipauth); -int qemuMonitorJSONSetBlockIoThrottle(qemuMonitor *mon, - const char *drivealias, - const char *qomid, - virDomainBlockIoTuneInfo *info); +int +qemuMonitorJSONSetBlockIoThrottle(qemuMonitor *mon, + const char *drivealias, + const char *qomid, + virDomainBlockIoTuneInfo *info); -int qemuMonitorJSONGetBlockIoThrottle(qemuMonitor *mon, - const char *drivealias, - const char *qdevid, - virDomainBlockIoTuneInfo *reply); +int +qemuMonitorJSONGetBlockIoThrottle(qemuMonitor *mon, + const char *drivealias, + const char *qdevid, + virDomainBlockIoTuneInfo *reply); -int qemuMonitorJSONSystemWakeup(qemuMonitor *mon); +int +qemuMonitorJSONSystemWakeup(qemuMonitor *mon); -char *qemuMonitorJSONGetSEVMeasurement(qemuMonitor *mon); +char * +qemuMonitorJSONGetSEVMeasurement(qemuMonitor *mon); -int qemuMonitorJSONGetVersion(qemuMonitor *mon, - int *major, - int *minor, - int *micro, - char **package) +int +qemuMonitorJSONGetVersion(qemuMonitor *mon, + int *major, + int *minor, + int *micro, + char **package) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(4); -int qemuMonitorJSONGetMachines(qemuMonitor *mon, - qemuMonitorMachineInfo ***machines) +int +qemuMonitorJSONGetMachines(qemuMonitor *mon, + qemuMonitorMachineInfo ***machines) ATTRIBUTE_NONNULL(2); -int qemuMonitorJSONGetCPUDefinitions(qemuMonitor *mon, - qemuMonitorCPUDefs **cpuDefs) +int +qemuMonitorJSONGetCPUDefinitions(qemuMonitor *mon, + qemuMonitorCPUDefs **cpuDefs) ATTRIBUTE_NONNULL(2); -int qemuMonitorJSONGetCPUModelExpansion(qemuMonitor *mon, - qemuMonitorCPUModelExpansionType type, - virCPUDef *cpu, - bool migratable, - bool fail_no_props, - qemuMonitorCPUModelInfo **model_info) +int +qemuMonitorJSONGetCPUModelExpansion(qemuMonitor *mon, + qemuMonitorCPUModelExpansionType type, + virCPUDef *cpu, + bool migratable, + bool fail_no_props, + qemuMonitorCPUModelInfo **model_info) ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(6); -int qemuMonitorJSONGetCPUModelBaseline(qemuMonitor *mon, - virCPUDef *cpu_a, - virCPUDef *cpu_b, - qemuMonitorCPUModelInfo **baseline) +int +qemuMonitorJSONGetCPUModelBaseline(qemuMonitor *mon, + virCPUDef *cpu_a, + virCPUDef *cpu_b, + qemuMonitorCPUModelInfo **baseline) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(4); -int qemuMonitorJSONGetCPUModelComparison(qemuMonitor *mon, - virCPUDef *cpu_a, - virCPUDef *cpu_b, - char **result) +int +qemuMonitorJSONGetCPUModelComparison(qemuMonitor *mon, + virCPUDef *cpu_a, + virCPUDef *cpu_b, + char **result) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3); -int qemuMonitorJSONGetCommands(qemuMonitor *mon, - char ***commands) +int +qemuMonitorJSONGetCommands(qemuMonitor *mon, + char ***commands) ATTRIBUTE_NONNULL(2); -GHashTable *qemuMonitorJSONGetCommandLineOptions(qemuMonitor *mon); -int qemuMonitorJSONGetKVMState(qemuMonitor *mon, - bool *enabled, - bool *present) +GHashTable * +qemuMonitorJSONGetCommandLineOptions(qemuMonitor *mon); + +int +qemuMonitorJSONGetKVMState(qemuMonitor *mon, + bool *enabled, + bool *present) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3); -int qemuMonitorJSONGetObjectTypes(qemuMonitor *mon, - char ***types) +int +qemuMonitorJSONGetObjectTypes(qemuMonitor *mon, + char ***types) ATTRIBUTE_NONNULL(2); /* ListPath structures and API's are public only for qemumonitorjsontest */ @@ -425,12 +526,14 @@ struct _qemuMonitorJSONListPath { char *type; }; -int qemuMonitorJSONGetObjectListPaths(qemuMonitor *mon, - const char *path, - qemuMonitorJSONListPath ***paths) +int +qemuMonitorJSONGetObjectListPaths(qemuMonitor *mon, + const char *path, + qemuMonitorJSONListPath ***paths) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3); -void qemuMonitorJSONListPathFree(qemuMonitorJSONListPath *paths); +void +qemuMonitorJSONListPathFree(qemuMonitorJSONListPath *paths); /* ObjectProperty structures and Get/Set API's are public only * for qemumonitorjsontest @@ -462,166 +565,207 @@ struct _qemuMonitorJSONObjectProperty { } val; }; -int qemuMonitorJSONGetObjectProperty(qemuMonitor *mon, - const char *path, - const char *property, - qemuMonitorJSONObjectProperty *prop) +int +qemuMonitorJSONGetObjectProperty(qemuMonitor *mon, + const char *path, + const char *property, + qemuMonitorJSONObjectProperty *prop) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(4); -int qemuMonitorJSONSetObjectProperty(qemuMonitor *mon, - const char *path, - const char *property, - qemuMonitorJSONObjectProperty *prop) +int +qemuMonitorJSONSetObjectProperty(qemuMonitor *mon, + const char *path, + const char *property, + qemuMonitorJSONObjectProperty *prop) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(4); -GHashTable *qemuMonitorJSONGetDeviceProps(qemuMonitor *mon, - const char *device) +GHashTable * +qemuMonitorJSONGetDeviceProps(qemuMonitor *mon, + const char *device) ATTRIBUTE_NONNULL(2); -int qemuMonitorJSONGetObjectProps(qemuMonitor *mon, - const char *object, - char ***props) +int +qemuMonitorJSONGetObjectProps(qemuMonitor *mon, + const char *object, + char ***props) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3); -char *qemuMonitorJSONGetTargetArch(qemuMonitor *mon); - -int qemuMonitorJSONNBDServerStart(qemuMonitor *mon, - const virStorageNetHostDef *server, - const char *tls_alias); -int qemuMonitorJSONNBDServerAdd(qemuMonitor *mon, - const char *deviceID, - const char *export, - bool writable, - const char *bitmap); -int qemuMonitorJSONNBDServerStop(qemuMonitor *mon); - -int qemuMonitorJSONBlockExportAdd(qemuMonitor *mon, - virJSONValue **props); - -int qemuMonitorJSONGetTPMModels(qemuMonitor *mon, - char ***tpmmodels) + +char * +qemuMonitorJSONGetTargetArch(qemuMonitor *mon); + +int +qemuMonitorJSONNBDServerStart(qemuMonitor *mon, + const virStorageNetHostDef *server, + const char *tls_alias); +int +qemuMonitorJSONNBDServerAdd(qemuMonitor *mon, + const char *deviceID, + const char *export, + bool writable, + const char *bitmap); +int +qemuMonitorJSONNBDServerStop(qemuMonitor *mon); + +int +qemuMonitorJSONBlockExportAdd(qemuMonitor *mon, + virJSONValue **props); + +int +qemuMonitorJSONGetTPMModels(qemuMonitor *mon, + char ***tpmmodels) ATTRIBUTE_NONNULL(2); -int qemuMonitorJSONGetTPMTypes(qemuMonitor *mon, - char ***tpmtypes) +int +qemuMonitorJSONGetTPMTypes(qemuMonitor *mon, + char ***tpmtypes) ATTRIBUTE_NONNULL(2); -int qemuMonitorJSONAttachCharDev(qemuMonitor *mon, - const char *chrID, - virDomainChrSourceDef *chr); -int qemuMonitorJSONDetachCharDev(qemuMonitor *mon, - const char *chrID); +int +qemuMonitorJSONAttachCharDev(qemuMonitor *mon, + const char *chrID, + virDomainChrSourceDef *chr); +int +qemuMonitorJSONDetachCharDev(qemuMonitor *mon, + const char *chrID); -int qemuMonitorJSONGetDeviceAliases(qemuMonitor *mon, - char ***aliases); +int +qemuMonitorJSONGetDeviceAliases(qemuMonitor *mon, + char ***aliases); -int qemuMonitorJSONGetCPUx86Data(qemuMonitor *mon, - const char *property, - virCPUData **cpudata); +int +qemuMonitorJSONGetCPUx86Data(qemuMonitor *mon, + const char *property, + virCPUData **cpudata); -int qemuMonitorJSONGetGuestCPUx86(qemuMonitor *mon, - virCPUData **data, - virCPUData **disabled); +int +qemuMonitorJSONGetGuestCPUx86(qemuMonitor *mon, + virCPUData **data, + virCPUData **disabled); -int qemuMonitorJSONGetGuestCPU(qemuMonitor *mon, - virArch arch, - qemuMonitorCPUFeatureTranslationCallback translate, - void *opaque, - virCPUData **enabled, - virCPUData **disabled); +int +qemuMonitorJSONGetGuestCPU(qemuMonitor *mon, + virArch arch, + qemuMonitorCPUFeatureTranslationCallback translate, + void *opaque, + virCPUData **enabled, + virCPUData **disabled); -int qemuMonitorJSONRTCResetReinjection(qemuMonitor *mon); +int +qemuMonitorJSONRTCResetReinjection(qemuMonitor *mon); -int qemuMonitorJSONGetIOThreads(qemuMonitor *mon, - qemuMonitorIOThreadInfo ***iothreads, - int *niothreads) +int +qemuMonitorJSONGetIOThreads(qemuMonitor *mon, + qemuMonitorIOThreadInfo ***iothreads, + int *niothreads) ATTRIBUTE_NONNULL(2); -int qemuMonitorJSONSetIOThread(qemuMonitor *mon, - qemuMonitorIOThreadInfo *iothreadInfo) +int +qemuMonitorJSONSetIOThread(qemuMonitor *mon, + qemuMonitorIOThreadInfo *iothreadInfo) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -int qemuMonitorJSONGetMemoryDeviceInfo(qemuMonitor *mon, - GHashTable *info) +int +qemuMonitorJSONGetMemoryDeviceInfo(qemuMonitor *mon, + GHashTable *info) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -int qemuMonitorJSONFindLinkPath(qemuMonitor *mon, - const char *name, - const char *alias, - char **path) +int +qemuMonitorJSONFindLinkPath(qemuMonitor *mon, + const char *name, + const char *alias, + char **path) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(4); -int qemuMonitorJSONMigrateIncoming(qemuMonitor *mon, - const char *uri) +int +qemuMonitorJSONMigrateIncoming(qemuMonitor *mon, + const char *uri) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -int qemuMonitorJSONMigrateStartPostCopy(qemuMonitor *mon) +int +qemuMonitorJSONMigrateStartPostCopy(qemuMonitor *mon) ATTRIBUTE_NONNULL(1); -int qemuMonitorJSONMigrateContinue(qemuMonitor *mon, - qemuMonitorMigrationStatus status) +int +qemuMonitorJSONMigrateContinue(qemuMonitor *mon, + qemuMonitorMigrationStatus status) ATTRIBUTE_NONNULL(1); -int qemuMonitorJSONGetRTCTime(qemuMonitor *mon, - struct tm *tm) +int +qemuMonitorJSONGetRTCTime(qemuMonitor *mon, + struct tm *tm) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -int qemuMonitorJSONGetHotpluggableCPUs(qemuMonitor *mon, - struct qemuMonitorQueryHotpluggableCpusEntry **entries, - size_t *nentries) +int +qemuMonitorJSONGetHotpluggableCPUs(qemuMonitor *mon, + struct qemuMonitorQueryHotpluggableCpusEntry **entries, + size_t *nentries) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3); -virJSONValue *qemuMonitorJSONQueryQMPSchema(qemuMonitor *mon) +virJSONValue * +qemuMonitorJSONQueryQMPSchema(qemuMonitor *mon) ATTRIBUTE_NONNULL(1); -int qemuMonitorJSONSetBlockThreshold(qemuMonitor *mon, - const char *nodename, - unsigned long long threshold) +int +qemuMonitorJSONSetBlockThreshold(qemuMonitor *mon, + const char *nodename, + unsigned long long threshold) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -virJSONValue *qemuMonitorJSONQueryNamedBlockNodes(qemuMonitor *mon, - bool flat) +virJSONValue * +qemuMonitorJSONQueryNamedBlockNodes(qemuMonitor *mon, + bool flat) ATTRIBUTE_NONNULL(1); -int qemuMonitorJSONSetWatchdogAction(qemuMonitor *mon, - const char *action) +int +qemuMonitorJSONSetWatchdogAction(qemuMonitor *mon, + const char *action) ATTRIBUTE_NONNULL(1); -int qemuMonitorJSONBlockdevCreate(qemuMonitor *mon, - const char *jobname, - virJSONValue **props) +int +qemuMonitorJSONBlockdevCreate(qemuMonitor *mon, + const char *jobname, + virJSONValue **props) ATTRIBUTE_NONNULL(1); -int qemuMonitorJSONBlockdevAdd(qemuMonitor *mon, - virJSONValue **props) +int +qemuMonitorJSONBlockdevAdd(qemuMonitor *mon, + virJSONValue **props) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -int qemuMonitorJSONBlockdevReopen(qemuMonitor *mon, - virJSONValue **props) +int +qemuMonitorJSONBlockdevReopen(qemuMonitor *mon, + virJSONValue **props) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -int qemuMonitorJSONBlockdevDel(qemuMonitor *mon, - const char *nodename) +int +qemuMonitorJSONBlockdevDel(qemuMonitor *mon, + const char *nodename) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -int qemuMonitorJSONBlockdevTrayOpen(qemuMonitor *mon, - const char *id, - bool force) +int +qemuMonitorJSONBlockdevTrayOpen(qemuMonitor *mon, + const char *id, + bool force) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -int qemuMonitorJSONBlockdevTrayClose(qemuMonitor *mon, - const char *id) +int +qemuMonitorJSONBlockdevTrayClose(qemuMonitor *mon, + const char *id) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -int qemuMonitorJSONBlockdevMediumRemove(qemuMonitor *mon, - const char *id) +int +qemuMonitorJSONBlockdevMediumRemove(qemuMonitor *mon, + const char *id) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -int qemuMonitorJSONBlockdevMediumInsert(qemuMonitor *mon, - const char *id, - const char *nodename) +int +qemuMonitorJSONBlockdevMediumInsert(qemuMonitor *mon, + const char *id, + const char *nodename) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3); -int qemuMonitorJSONGetPRManagerInfo(qemuMonitor *mon, - GHashTable *info) +int +qemuMonitorJSONGetPRManagerInfo(qemuMonitor *mon, + GHashTable *info) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); int @@ -684,9 +828,10 @@ qemuMonitorJSONTransactionBackup(virJSONValue *actions, const char *bitmap, qemuMonitorTransactionBackupSyncMode syncmode); -int qemuMonitorJSONSetDBusVMStateIdList(qemuMonitor *mon, - const char *vmstatepath, - const char *idstr) +int +qemuMonitorJSONSetDBusVMStateIdList(qemuMonitor *mon, + const char *vmstatepath, + const char *idstr) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3); int -- 2.31.1

2 1

[libvirt PATCH 0/6] Improve AMD SEV support
by Daniel P. Berrangé 09 Dec '21

09 Dec '21

This addresses a few issues in the AMD SEV support - Neither host or domain level SEV metadata is exposed in virsh commands - The domain launch security parameters don't expose enough info to validate the measurement The second point was the real purpose of my work. Per the SEV API guide to calculate the measurement we need measurement = HMAC(0x04 || API_MAJOR || API_MINOR || BUILD || GCTX.POLICY || GCTX.LD || MNONCE; GCTX.TIK) The API_MINOR, API_MAJOR, BUILD values are things that are available from 'query-sev' QMP command and libvirt does not expose this info. This patch series adds them to virDomainGetLaunchSecurityParams alongside the measurement that we already report. So now the client can fetch this info and calculate an expected measurement to compare with the actual measurement they got. They will thus know if the guest is safe to inject secrets into, which is where Jim's recent patches come into play. Daniel P. Berrangé (6): include: add new launch security parameters qemu: report error querying launch params for inactive guest qemu: add monitor APIs for query-sev qemu: report new launch security parameters tools: add 'domlaunchsecinfo' virsh command tools: add 'nodesevinfo' virsh command include/libvirt/libvirt-domain.h | 32 +++++++++++++++++++ src/qemu/qemu_driver.c | 47 ++++++++++++++++++++++++---- src/qemu/qemu_monitor.c | 13 ++++++++ src/qemu/qemu_monitor.h | 9 ++++++ src/qemu/qemu_monitor_json.c | 45 +++++++++++++++++++++++++++ src/qemu/qemu_monitor_json.h | 8 +++++ tools/virsh-domain.c | 53 ++++++++++++++++++++++++++++++++ tools/virsh-host.c | 45 +++++++++++++++++++++++++++ 8 files changed, 246 insertions(+), 6 deletions(-) -- 2.33.1

2 14

[PATCH 00/36] virBitmap freeing cleanup
by Peter Krempa 09 Dec '21

09 Dec '21

Peter Krempa (36): virCapabilitiesInitCaches: Refactor freeing of temporary variables conf: capabilities: Clean up freeing of virBitmap virDomainSchedulerParse: Refactor cleanup virDomainNumatuneParseXML: Refactor cleanup virDomainDriverGetIOThreadsConfig: Automatically free virBitmap qemuDomainAssignMemorySlots: Refactor cleanup qemu: driver: Automatically free temporary virBitmap-s qemuDomainSelectHotplugVcpuEntities: Refactor cleanup qemuDomainSetVcpusInternal: Refactor cleanup qemuDomainSetVcpuInternal: Refactor cleanup qemuProcessValidateHotpluggableVcpus: Refactor cleanup qemuSnapshotCreateInactiveExternal: Automatically free temporary variables virHostCPUCountThreadSiblings: Refactor cleanup virHostCPUHasValidSubcoreConfiguration: Refactor cleanup virHostCPUParseNode: Use automatic memory freeing for virBitmap virCgroupGetPercpuStats: Refactor cleanup virshParseCPUList: Refactor cleanup virnumamock: Use automatic memory freeing for virBitmap test_virCapabilitiesGetCpusForNodemask: Refactor cleanup util: bitmap: Unexport 'virBitmapParseSeparator' virBitmapExpand: Remove return value virBitmapUnion: Remove return value virBitmapClearBitExpand: Remove return value virBitmapSetBitExpand: Remove return value virBitmapParseSeparator: Remove separator parsing capability virBitmapParseInternal: Allocate the bitmap in the caller util: bitmap: Unify parsing of bitmaps test_driver: Use automatic memory freeing for temporary virBitmaps lxcSetCpusetTune: Refactor memory clearing libxl_driver: Use automatic memory freeing for virBitmap libxlDomainGetNumaParameters: Don't clear a freshly allocated bitmap lxc_controller: Use automatic memory freeing for virBitmap virLXCControllerSetup(Resource|Cgroup)Limits: Refactor cleanup virt-host-validate-common: Use automatic memory freeing for virBitmap virt-host-validate-qemu: Use automatic memory freeing for virBitmap virHostCPUGetInfoPopulateLinux: Use automatic memory freeing for virBitmap src/conf/capabilities.c | 27 ++--- src/conf/domain_conf.c | 16 +-- src/conf/numa_conf.c | 55 ++++----- src/hypervisor/domain_driver.c | 7 +- src/libvirt_private.syms | 1 - src/libxl/libxl_driver.c | 7 +- src/lxc/lxc_controller.c | 39 +++--- src/lxc/lxc_native.c | 20 ++-- src/network/bridge_driver.c | 3 +- src/qemu/qemu_domain_address.c | 12 +- src/qemu/qemu_driver.c | 50 +++----- src/qemu/qemu_hotplug.c | 54 ++++----- src/qemu/qemu_process.c | 16 +-- src/qemu/qemu_snapshot.c | 12 +- src/test/test_driver.c | 17 +-- src/util/virbitmap.c | 190 ++++++++---------------------- src/util/virbitmap.h | 17 +-- src/util/vircgroup.c | 27 ++--- src/util/virhostcpu.c | 51 +++----- src/util/virnuma.c | 3 +- src/util/virqemu.c | 3 +- src/util/virtpm.c | 3 +- tests/testutils.c | 2 +- tests/virbitmaptest.c | 15 +-- tests/vircapstest.c | 19 +-- tests/virnumamock.c | 14 +-- tools/virsh-domain.c | 10 +- tools/virt-host-validate-common.c | 8 +- tools/virt-host-validate-qemu.c | 4 +- 29 files changed, 223 insertions(+), 479 deletions(-) -- 2.31.1

2 72

[PATCH] docs: Update more links to point to the new Go modules
by Andrea Bolognani 09 Dec '21

09 Dec '21

A couple of links were still pointing to the obsolete Go packages instead of the current module-aware ones. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. docs/bindings.rst | 2 +- docs/docs.html.in | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/bindings.rst b/docs/bindings.rst index c5b6b94519..81a4a67067 100644 --- a/docs/bindings.rst +++ b/docs/bindings.rst @@ -10,7 +10,7 @@ other languages: - **C#**: Arnaud Champion develops `C# bindings <csharp.html>`__. - **Go**: Daniel Berrange develops `Go - bindings <https://pkg.go.dev/libvirt.org/libvirt-go>`__. + bindings <https://pkg.go.dev/libvirt.org/go/libvirt>`__. - **Java**: Daniel Veillard develops `Java bindings <java.html>`__. diff --git a/docs/docs.html.in b/docs/docs.html.in index 22a43517ed..8132090762 100644 --- a/docs/docs.html.in +++ b/docs/docs.html.in @@ -83,7 +83,7 @@ <dt><a href="bindings.html">Language bindings and API modules</a></dt> <dd>Bindings of the libvirt API for <a href="csharp.html">c#</a>, - <a href="https://pkg.go.dev/libvirt.org/libvirt-go">go</a>, + <a href="https://pkg.go.dev/libvirt.org/go/libvirt">go</a>, <a href="java.html">java</a>, <a href="https://libvirt.org/ocaml/">ocaml</a>, <a href="https://search.cpan.org/dist/Sys-Virt/">perl</a>, -- 2.31.1

1 0

[PATCH] NEWS: Fix spacing between releases
by Andrea Bolognani 08 Dec '21

08 Dec '21

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. NEWS.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/NEWS.rst b/NEWS.rst index a4252d555d..6c8ac1d9f9 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -190,6 +190,7 @@ v7.8.0 (2021-10-01) active. This information can also be retrieved with the new virsh command ``nodedev-info``. + v7.7.0 (2021-09-01) =================== -- 2.31.1

1 0

can cgroup(cpu,mem) limit qemu and obtain right usage
by longguang.yue 08 Dec '21

08 Dec '21

Hi, all: kata runs qemu as a kubernetes pod and use cgroup to limit cpu/memory. my question are : 1. how libvirt obtain qemu's cpu and memory usage， how about non-root mode cpu usage? 2. if qemu is limited in cgroups , does that usage include non-root mode cpu usage? thanks

2 1

[libvirt PATCH] qemu: do not compare missing cpu data
by Ján Tomko 08 Dec '21

08 Dec '21

For x86, we invalidate qemu caps cache if the host CPUID changed. However other cpu drivers do not have the 'getHostData' function implemented. Skip the comparison if we do not have host CPUData available, since virCPUDataIsIdentical always returns an error in that case. https://bugzilla.redhat.com/show_bug.cgi?id=2030119 Fixes: 3bc6f46d305ed82f7314ffc4c2a66847b831a6bd Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/qemu/qemu_capabilities.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 0e6e73774a..51828ead53 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -4943,7 +4943,8 @@ virQEMUCapsIsValid(void *data, return false; } - if (virCPUDataIsIdentical(priv->cpuData, qemuCaps->cpuData) != + if (priv->cpuData && + virCPUDataIsIdentical(priv->cpuData, qemuCaps->cpuData) != VIR_CPU_COMPARE_IDENTICAL) { VIR_DEBUG("Outdated capabilities for '%s': host cpuid changed", qemuCaps->binary); -- 2.31.1

2 1

[PATCH] Add VM info to improve error log message for qemu monitor
by Rohit Kumar 08 Dec '21

08 Dec '21

This patch is to determine the VM which had IO or socket hangup error. Signed-off-by: Rohit Kumar <rohit.kumar3(a)nutanix.com> --- src/qemu/qemu_monitor.c | 46 +++++++++++++++++++++++++---------------- 1 file changed, 28 insertions(+), 18 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 75e0e4ed92..d36db280d9 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -530,13 +530,19 @@ qemuMonitorIO(GSocket *socket G_GNUC_UNUSED, qemuMonitor *mon = opaque; bool error = false; bool hangup = false; + virDomainObj *vm = mon->vm; + g_autofree char *vmName = NULL; + + if (vm != NULL && vm->def != NULL) { + vmName = g_strdup(vm->def->name); + } virObjectRef(mon); /* lock access to the monitor and protect fd */ virObjectLock(mon); #if DEBUG_IO - VIR_DEBUG("Monitor %p I/O on socket %p cond %d", mon, socket, cond); + VIR_DEBUG("Monitor %p I/O on socket %p cond %d vm=%p name=%s", mon, socket, cond, vm, NULLSTR(vmName)); #endif if (mon->fd == -1 || !mon->watch) { virObjectUnlock(mon); @@ -583,8 +589,8 @@ qemuMonitorIO(GSocket *socket G_GNUC_UNUSED, if (!error && !mon->goteof && cond & G_IO_ERR) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Invalid file descriptor while waiting for monitor")); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Invalid file descriptor while waiting for monitor vm_name=%s"), NULLSTR(vmName)); mon->goteof = true; } } @@ -609,13 +615,13 @@ qemuMonitorIO(GSocket *socket G_GNUC_UNUSED, virResetLastError(); } else { if (virGetLastErrorCode() == VIR_ERR_OK && !mon->goteof) - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Error while processing monitor IO")); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Error while processing monitor IO vm_name=%s"), NULLSTR(vmName)); virCopyLastError(&mon->lastError); virResetLastError(); } - VIR_DEBUG("Error on monitor %s", NULLSTR(mon->lastError.message)); + VIR_DEBUG("Error on monitor %s vm=%p name=%s", NULLSTR(mon->lastError.message), vm, NULLSTR(vmName)); /* If IO process resulted in an error & we have a message, * then wakeup that waiter */ if (mon->msg && !mon->msg->finished) { @@ -631,22 +637,20 @@ qemuMonitorIO(GSocket *socket G_GNUC_UNUSED, * will try to acquire the virDomainObj *mutex next */ if (mon->goteof) { qemuMonitorEofNotifyCallback eofNotify = mon->cb->eofNotify; - virDomainObj *vm = mon->vm; /* Make sure anyone waiting wakes up now */ virCondSignal(&mon->notify); virObjectUnlock(mon); - VIR_DEBUG("Triggering EOF callback"); + VIR_DEBUG("Triggering EOF callback vm=%p name=%s", vm, NULLSTR(vmName)); (eofNotify)(mon, vm, mon->callbackOpaque); virObjectUnref(mon); } else if (error) { qemuMonitorErrorNotifyCallback errorNotify = mon->cb->errorNotify; - virDomainObj *vm = mon->vm; /* Make sure anyone waiting wakes up now */ virCondSignal(&mon->notify); virObjectUnlock(mon); - VIR_DEBUG("Triggering error callback"); + VIR_DEBUG("Triggering error callback vm=%p name=%s", vm, NULLSTR(vmName)); (errorNotify)(mon, vm, mon->callbackOpaque); virObjectUnref(mon); } else { @@ -932,17 +936,23 @@ qemuMonitorSend(qemuMonitor *mon, qemuMonitorMessage *msg) { int ret = -1; + virDomainObj *vm = mon->vm; + g_autofree char *vmName = NULL; + + if (vm != NULL && vm->def != NULL) { + vmName = g_strdup(vm->def->name); + } /* Check whether qemu quit unexpectedly */ if (mon->lastError.code != VIR_ERR_OK) { - VIR_DEBUG("Attempt to send command while error is set %s", - NULLSTR(mon->lastError.message)); + VIR_DEBUG("Attempt to send command while error is set %s vm=%p name=%s", + NULLSTR(mon->lastError.message), vm, NULLSTR(vmName)); virSetError(&mon->lastError); return -1; } if (mon->goteof) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("End of file from qemu monitor")); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("End of file from qemu monitor vm_name=%s"), NULLSTR(vmName)); return -1; } @@ -955,15 +965,15 @@ qemuMonitorSend(qemuMonitor *mon, while (!mon->msg->finished) { if (virCondWait(&mon->notify, &mon->parent.lock) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Unable to wait on monitor condition")); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Unable to wait on monitor condition vm_name=%s"), NULLSTR(vmName)); goto cleanup; } } if (mon->lastError.code != VIR_ERR_OK) { - VIR_DEBUG("Send command resulted in error %s", - NULLSTR(mon->lastError.message)); + VIR_DEBUG("Send command resulted in error %s vm=%p name=%s", + NULLSTR(mon->lastError.message), vm, NULLSTR(vmName)); virSetError(&mon->lastError); goto cleanup; } -- 2.25.1

3 5

[PATCH 0/2] disk iomode validation cleanups
by Peter Krempa 07 Dec '21

07 Dec '21

Peter Krempa (2): qemuValidateDomainDeviceDefDiskFrontend: Fix error message if io='native' is unsupported qemuValidateDomainDeviceDefDiskFrontend: Aggregate disk iomode validation src/qemu/qemu_validate.c | 38 ++++++++++++++++++++++---------------- 1 file changed, 22 insertions(+), 16 deletions(-) -- 2.31.1

2 4

[libvirt PATCH v2] qemu: Enable unprivileged userfaultfd for post-copy migration
by Jiri Denemark 07 Dec '21

07 Dec '21

Userfaultfd is by default allowed only for privileged processes. Since libvirt runs QEMU unprivileged, we need to enable unprivileged access to userfaultfd before starting post-copy migration. Rather than providing a static sysctl configuration file, we set the sysctl knob in runtime once post-copy migration is requested. This way unprivileged_userfaultfd is only enabled once actually used. https://bugzilla.redhat.com/show_bug.cgi?id=1945420 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- Notes: Version 2: - setting unprivileged_userfaultfd only when it is not already enabled - virReportSystemError replaced with VIR_WARN src/qemu/qemu_migration_params.c | 42 ++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_params.c index dbc3219826..9ba4811242 100644 --- a/src/qemu/qemu_migration_params.c +++ b/src/qemu/qemu_migration_params.c @@ -804,6 +804,41 @@ qemuMigrationCapsToJSON(virBitmap *caps, } +/** + * qemuMigrationParamsEnableUserfaultfd + * + * Try to enable unprivileged userfaultfd unless it's missing or already + * enabled. Only a warning is logged when we cannot enable it, QEMU will + * report an error when enabling post-copy migration capability. + */ +static void +qemuMigrationParamsEnableUserfaultfd(void) +{ + const char *sysctl = "/proc/sys/vm/unprivileged_userfaultfd"; + g_autofree char *buf = NULL; + + if (!virFileExists(sysctl)) + return; + + if (virFileReadAll(sysctl, 10, &buf) < 0) { + VIR_WARN("Cannot read unprivileged userfaultfd state"); + return; + } + + if (STREQ(buf, "1\n")) { + VIR_DEBUG("Unprivileged userfaultfd already enabled"); + return; + } + + VIR_DEBUG("Enabling unprivileged userfaultfd for post-copy migration"); + + if (virFileWriteStr(sysctl, "1", 0) < 0) { + VIR_WARN("Failed to enable unprivileged userfaultfd: %s", + g_strerror(errno)); + } +} + + /** * qemuMigrationParamsApply * @driver: qemu driver @@ -839,6 +874,13 @@ qemuMigrationParamsApply(virQEMUDriver *driver, goto cleanup; } } else { + /* userfaultfd may only be enabled for privileged processes by default, + * we need to make sure QEMU can use it before enabling post-copy + * migration */ + if (virBitmapIsBitSet(priv->migrationCaps, QEMU_MIGRATION_CAP_POSTCOPY) && + virBitmapIsBitSet(migParams->caps, QEMU_MIGRATION_CAP_POSTCOPY)) + qemuMigrationParamsEnableUserfaultfd(); + if (!(caps = qemuMigrationCapsToJSON(priv->migrationCaps, migParams->caps))) goto cleanup; -- 2.34.1

3 3

[PATCH 0/3] Add virDomainSetLaunchSecurityState API
by Jim Fehlig 06 Dec '21

06 Dec '21

V1 series based on initial RFC found here https://listman.redhat.com/archives/libvir-list/2021-November/msg00460.html This series is compile tested only. Functional testing will require reserving the test machine, configuring it, and writing some form of functional test :-). Is anyone aware of functional tests for the existing SEV-related APIs? Also, it has been a while since I added a new API, so not sure about the current state of the language bindings. Are there any non-automated tasks to expose the API in the various bindings? Jim Fehlig (3): libvirt: Introduce virDomainSetLaunchSecurityState public API remote: Add RPC support for the virDomainSetLaunchSecurityState API qemu: Implement the virDomainSetLaunchSecurityState API include/libvirt/libvirt-domain.h | 35 ++++++++++++++ src/driver-hypervisor.h | 7 +++ src/libvirt-domain.c | 52 +++++++++++++++++++++ src/libvirt_public.syms | 5 ++ src/qemu/qemu_driver.c | 78 ++++++++++++++++++++++++++++++++ src/qemu/qemu_monitor.c | 12 +++++ src/qemu/qemu_monitor.h | 6 +++ src/qemu/qemu_monitor_json.c | 34 ++++++++++++++ src/qemu/qemu_monitor_json.h | 5 ++ src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 17 ++++++- src/remote_protocol-structs | 9 ++++ 12 files changed, 260 insertions(+), 1 deletion(-) -- 2.33.0

2 9

Re: [PATCH for-7.0] i386: Deprecate the -no-hpet QEMU command line option
by Thomas Huth 06 Dec '21

06 Dec '21

On 06/12/2021 09.40, Thomas Huth wrote: > The HPET setting has been turned into a machine property a while ago > already, so we should finally do the next step and deprecate the > legacy CLI option, too. > While we're at it, add a proper help text for the machine property, too. > > Signed-off-by: Thomas Huth <thuth(a)redhat.com> > --- > docs/about/deprecated.rst | 6 ++++++ > hw/i386/pc.c | 2 ++ > qemu-options.hx | 2 +- > softmmu/vl.c | 1 + > 4 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst > index 5693abb663..1dfe69aa6a 100644 > --- a/docs/about/deprecated.rst > +++ b/docs/about/deprecated.rst > @@ -198,6 +198,12 @@ form is preferred. > Using ``-drive if=none`` to configure the OTP device of the sifive_u > RISC-V machine is deprecated. Use ``-drive if=pflash`` instead. > > +``-no-hpet`` (since 7.0) > +'''''''''''''''''''''''' > + > +The HPET setting has been turned into a machine property. > +Use ``-machine hpet=off`` instead. [...] Forgot to CC: the libvirt folks, doing so now. Seems like libvirt is still using -no-hpet in some few spots, so I guess these would need to be changed first, before we could finally remove this option in QEMU? Thomas

3 5

[libvirt PATCH v2 0/2] Fix failure to find VF netdev names during virtual network start
by Laine Stump 06 Dec '21

06 Dec '21

The first patch resolves https://bugzilla.redhat.com/2025432, the 2nd simplifies lower level code in the same manner. V1 is here: https://listman.redhat.com/archives/libvir-list/2021-December/msg00000.html Change in V2: Rather than adding an extra bool to the arglist of virPCIGetVirtualFunctionsFull() (what I did in V1), just switch to sending the name of the netdev whose phys_port_id we want to match (called physPortNetDevName) (which will always be non-NULL in the cases where we want) rather than the phys_port_id itself (physPortID) (which may or may not be NULL). This way we don't need an extra arg (we can just check for physPortNetDevName != NULL), and the lower level function can call virNetDevGetPhysPortID() as needed. Also added a similar 2nd patch that pushes the call to virNetDevGetPhysPortID() down even further, into virPCIGetNetName(). This simplifies the callers, and concentrates all calls to virNetDevGetPhysPortID() into a single function (virPCIGetNetName(), duh). Laine Stump (2): util: fix erroneous requirement for phys_port_id to get ifname of a VF util: call virNetDevGetPhysPortID() in less places src/util/virnetdev.c | 24 +++----------------- src/util/virpci.c | 52 ++++++++++++++++++++++++++------------------ src/util/virpci.h | 4 ++-- 3 files changed, 36 insertions(+), 44 deletions(-) -- 2.33.1

2 3

[libvirt PATCH v2 00/15] WIP/RFC: add QEMU "-display dbus" support
by marcandre.lureau＠redhat.com 06 Dec '21

06 Dec '21

From: Marc-André Lureau <marcandre.lureau(a)redhat.com> Hi, This series implements supports for the upcoming QEMU "-display dbus" support. Development is still in progress, but I hope to land the QEMU support early in 6.3 (last version posted: https://patchew.org/QEMU/20211009210838.2219430-1-marcandre.lureau@redhat.c…) By default, libvirt will start a private VM bus (sharing and reusing the existing "vmstate" VM bus & code). The feature set should cover the needs to replace Spice as local client of choice, including 3daccel/dmabuf, audio, clipboard sharing, usb redirection, and arbitrary chardev/channels (for serial etc). The test Gtk4 client is also in progress, currently in development at https://gitlab.com/marcandre.lureau/qemu-display/. A few dependencies, such as zbus, require an upcoming release. virt-viewer & boxes will need a port to Gtk4 to make use of the shared widget. Comments welcome, as we can still adjust the QEMU side etc. thanks v2: after Michal review - split patches for conf & qemu changes - start D-Bus in qemuExtDevicesStart() - use symlinks for xml2xml tests - teach domdisplay to return a dbus URI - rebase & bug fixes Marc-André Lureau (15): qemu: add chardev-vdagent capability check qemu: add -display dbus capability check (to update to 6.3) conf: add <graphics type='dbus'> qemu: start the D-Bus daemon for the display qemu: add -display dbus support virsh: refactor/split cmdDomDisplay() virsh: report the D-Bus bus URI for domdisplay conf: add <audio type='dbus'> support qemu: add audio type 'dbus' conf: add dbus <clipboard> qemu: add dbus clipboard sharing conf: add <serial type='dbus'> qemu: add -chardev dbus support qemu: add usbredir type 'dbus' docs: document <graphics> type dbus docs/formatdomain.rst | 43 +- docs/schemas/basictypes.rng | 7 + docs/schemas/domaincommon.rng | 71 ++++ src/bhyve/bhyve_command.c | 1 + src/conf/domain_conf.c | 141 ++++++- src/conf/domain_conf.h | 15 + src/conf/domain_validate.c | 41 +- src/libxl/libxl_conf.c | 1 + src/qemu/qemu_capabilities.c | 6 + src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_command.c | 80 +++- src/qemu/qemu_domain.c | 1 + src/qemu/qemu_driver.c | 10 +- src/qemu/qemu_extdevice.c | 13 + src/qemu/qemu_hotplug.c | 1 + src/qemu/qemu_monitor_json.c | 10 + src/qemu/qemu_process.c | 40 +- src/qemu/qemu_validate.c | 33 ++ src/security/security_dac.c | 2 + src/vmx/vmx.c | 1 + .../domaincapsdata/qemu_6.2.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_6.2.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_6.2.0.x86_64.xml | 1 + .../caps_6.1.0.x86_64.xml | 1 + .../caps_6.2.0.aarch64.xml | 1 + .../caps_6.2.0.x86_64.replies | 10 +- .../caps_6.2.0.x86_64.xml | 2 + .../graphics-dbus-address.args | 30 ++ .../graphics-dbus-address.xml | 35 ++ .../qemuxml2argvdata/graphics-dbus-audio.args | 33 ++ .../qemuxml2argvdata/graphics-dbus-audio.xml | 45 +++ .../graphics-dbus-chardev.args | 32 ++ .../graphics-dbus-chardev.xml | 43 ++ .../graphics-dbus-clipboard.args | 31 ++ .../graphics-dbus-clipboard.xml | 35 ++ tests/qemuxml2argvdata/graphics-dbus-p2p.args | 30 ++ tests/qemuxml2argvdata/graphics-dbus-p2p.xml | 33 ++ .../graphics-dbus-usbredir.args | 34 ++ .../graphics-dbus-usbredir.xml | 30 ++ tests/qemuxml2argvdata/graphics-dbus.args | 30 ++ tests/qemuxml2argvdata/graphics-dbus.xml | 33 ++ tests/qemuxml2argvtest.c | 21 + .../graphics-dbus-address.xml | 1 + .../graphics-dbus-audio.xml | 1 + .../graphics-dbus-chardev.xml | 1 + .../graphics-dbus-clipboard.xml | 1 + .../qemuxml2xmloutdata/graphics-dbus-p2p.xml | 1 + tests/qemuxml2xmloutdata/graphics-dbus.xml | 1 + tests/qemuxml2xmltest.c | 20 + tools/virsh-domain.c | 366 +++++++++--------- 50 files changed, 1231 insertions(+), 192 deletions(-) create mode 100644 tests/qemuxml2argvdata/graphics-dbus-address.args create mode 100644 tests/qemuxml2argvdata/graphics-dbus-address.xml create mode 100644 tests/qemuxml2argvdata/graphics-dbus-audio.args create mode 100644 tests/qemuxml2argvdata/graphics-dbus-audio.xml create mode 100644 tests/qemuxml2argvdata/graphics-dbus-chardev.args create mode 100644 tests/qemuxml2argvdata/graphics-dbus-chardev.xml create mode 100644 tests/qemuxml2argvdata/graphics-dbus-clipboard.args create mode 100644 tests/qemuxml2argvdata/graphics-dbus-clipboard.xml create mode 100644 tests/qemuxml2argvdata/graphics-dbus-p2p.args create mode 100644 tests/qemuxml2argvdata/graphics-dbus-p2p.xml create mode 100644 tests/qemuxml2argvdata/graphics-dbus-usbredir.args create mode 100644 tests/qemuxml2argvdata/graphics-dbus-usbredir.xml create mode 100644 tests/qemuxml2argvdata/graphics-dbus.args create mode 100644 tests/qemuxml2argvdata/graphics-dbus.xml create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus-address.xml create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus-audio.xml create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus-chardev.xml create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus-clipboard.xml create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus-p2p.xml create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus.xml -- 2.34.1.8.g35151cf07204

4 19

[PATCH 00/17] qemu: Add support for blocking writes for the blockdev-mirror job
by Peter Krempa 03 Dec '21

03 Dec '21

Blocking writes ensure that the mirroring converges even when the guest is I/O intensive with a fast local storage and slow mirror. This patchset does it by introducing flags which use the blocking mode as it will have performance impact, and for guests which do I/O in bursts it might be detrimental to their performance. One could argue that both the copy job and migration have the expectations of actually using the copy so ensuring that it converges might be also something we'd want to do by default. This would obviously greatly simplify this series, but I didn't want to change the default. Peter Krempa (17): qemu: monitor: Avoid ternary operators in helpers for drive/blockdev-mirror qemuMonitorJSONHandleShutdown: Use virTristateBoolFromBool qemuMonitorJSONEjectMedia: Use a bool directly for constructing JSON with 'b' modifier qemuMonitorJSONMigrate: Extract flags prior to constructing command qemuMonitorJSONGraphicsRelocate: Clean up command argument construction qemu: monitor: Add support for 'write-blocking' copy mode for blockdev-mirror include: virDomainBlockCopyFlags: Convert to prefix comments virDomainBlockCopy: Introduce VIR_DOMAIN_BLOCK_COPY_SYNCHRONOUS_WRITES flag qemuDomainBlockCopy: Implement VIR_DOMAIN_BLOCK_COPY_SYNCHRONOUS_WRITES include: virDomainMigrateFlags: Remove "block alignment" whitespace man: virsh: Separate paragrapsh describing distinct flags VIR_REQUIRE_FLAG_(GOTO|RET): Add parens around arguments in expansion virDomainMigrate: Introduce VIR_MIGRATE_NON_SHARED_SYNCHRONOUS_WRITES flag qemu: migration: Implement VIR_MIGRATE_NON_SHARED_SYNCHRONOUS_WRITES docs: Convert 'migration' doc to RST docs: migration: Add a paragraph about non-shared storage migration NEWS: Mention synchronous copy job additions NEWS.rst | 12 + docs/manpages/virsh.rst | 45 +- docs/meson.build | 2 +- docs/migration.html.in | 688 ------------------------------- docs/migration.rst | 490 ++++++++++++++++++++++ include/libvirt/libvirt-domain.h | 63 +-- src/internal.h | 4 +- src/libvirt-domain.c | 26 ++ src/qemu/qemu_driver.c | 17 +- src/qemu/qemu_migration.c | 17 +- src/qemu/qemu_migration.h | 1 + src/qemu/qemu_monitor.c | 10 +- src/qemu/qemu_monitor.h | 3 +- src/qemu/qemu_monitor_json.c | 67 ++- src/qemu/qemu_monitor_json.h | 3 +- tests/qemumonitorjsontest.c | 2 +- tools/virsh-domain.c | 22 +- 17 files changed, 707 insertions(+), 765 deletions(-) delete mode 100644 docs/migration.html.in create mode 100644 docs/migration.rst -- 2.31.1

2 21

[PATCH 00/16] Clean up of virJSONValueFree usage and few related refactors
by Peter Krempa 03 Dec '21

03 Dec '21

Peter Krempa (16): qemu: hotplug: Use automatic freeing for virJSONValue qemuDomainHotplugAddIOThread: Automatically free virJSONValue qemuMonitorBlockdevCreate: Use double pointer instead of always consuming '@props' virLockDaemonClientPreExecRestart: Modernize JSON object construction virLockDaemonPostExecRestart: Automatically free temporary variables virLockDaemonPostExecRestart: Refactor cleanup virLogDaemonPostExecRestart: Use automatic freeing for variables virLogDaemonPostExecRestart: Refactor cleanup virCHProcessUpdateInfo: Automatically free virJSONValue tests/virnetdaemontest.c: testExecRestart: Automatically free virJSONValue-s qemuAgentGuestSync: Don't use goto for looping qemuMonitorJSONGetCPUModelExpansion: Don't use goto for looping qemuMonitorAddObject: Use g_clear_pointer for a free and reset operation qemuAgentIOProcessLine: refactor cleanup qemu: agent: Automatically free virJSONValue-s qemu: agent: Remove unneeded cleanup sections src/ch/ch_process.c | 4 +- src/locking/lock_daemon.c | 85 ++++------ src/logging/log_daemon.c | 42 ++--- src/qemu/qemu_agent.c | 304 ++++++++++++++++------------------- src/qemu/qemu_block.c | 3 +- src/qemu/qemu_driver.c | 3 +- src/qemu/qemu_hotplug.c | 13 +- src/qemu/qemu_monitor.c | 20 +-- src/qemu/qemu_monitor.h | 2 +- src/qemu/qemu_monitor_json.c | 79 +++++---- src/qemu/qemu_monitor_json.h | 2 +- tests/virnetdaemontest.c | 6 +- 12 files changed, 254 insertions(+), 309 deletions(-) -- 2.31.1

2 17

[libvirt PATCH] libxl: libxlLoggerFileFree: remove redundant NULL assignment
by Ján Tomko 03 Dec '21

03 Dec '21

The 'file' pointer is already zeroed in virFileFclose and never read again. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed as trivial. src/libxl/libxl_logger.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libxl/libxl_logger.c b/src/libxl/libxl_logger.c index 44ee5a95da..4708553f29 100644 --- a/src/libxl/libxl_logger.c +++ b/src/libxl/libxl_logger.c @@ -53,7 +53,6 @@ libxlLoggerFileFree(void *payload) { FILE *file = payload; VIR_FORCE_FCLOSE(file); - file = NULL; } G_GNUC_PRINTF(5, 0) static void -- 2.31.1

1 0

[libvirt PATCH] meson: Improve network driver enablement logic
by Andrea Bolognani 03 Dec '21

03 Dec '21

The Homebrew package explicitly enables this driver despite us disabling it by default on macOS, so it must be functional to at least some extent and certainly can't be causing any build failures. Additionally, if the user has explicitly asked for the network driver to be enabled but libvirtd is disabled for whatever reason, we should error out instead of silently disabling the network driver. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Homebrew formula showing that the network driver is explicitly enabled in the package: https://github.com/Homebrew/homebrew-core/blob/3aff61292a3ed16bc715ba23fc2f… Test pipeline showing that enabling the network driver by default on macOS doesn't result in build failures: https://gitlab.com/abologna/libvirt/-/pipelines/421956249 meson.build | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index ba2f0d21de..cea8bbfa0c 100644 --- a/meson.build +++ b/meson.build @@ -1645,10 +1645,10 @@ if not get_option('driver_ch').disabled() and host_machine.system() == 'linux' a endif endif -# there's no use compiling the network driver without the libvirt -# daemon, nor compiling it for macOS, where it breaks the compile -if not get_option('driver_network').disabled() and conf.has('WITH_LIBVIRTD') and host_machine.system() != 'darwin' +if not get_option('driver_network').disabled() and conf.has('WITH_LIBVIRTD') conf.set('WITH_NETWORK', 1) +elif get_option('driver_network').enabled() + error('libvirtd must be enabled to build the network driver') endif if udev_dep.found() and conf.has('WITH_LIBVIRTD') -- 2.31.1

2 1

[PATCH 0/3] lib: Use g_autoptr() for virDomainDef
by Michal Privoznik 03 Dec '21

03 Dec '21

*** BLURB HERE *** Michal Prívozník (3): virdomainobjlist: Use g_autofree lib: Use g_autoptr() for virDomainDef lib: Drop some needles labels src/bhyve/bhyve_driver.c | 15 +++----- src/bhyve/bhyve_parse_command.c | 23 +++++------- src/ch/ch_driver.c | 6 ++-- src/conf/domain_conf.c | 10 ++---- src/conf/virdomainobjlist.c | 33 ++++++------------ src/esx/esx_driver.c | 14 +++----- src/libxl/libxl_domain.c | 24 +++++-------- src/libxl/libxl_driver.c | 62 ++++++++++++--------------------- src/libxl/libxl_migration.c | 3 +- src/libxl/xen_xl.c | 34 ++++++++---------- src/libxl/xen_xm.c | 18 ++++------ src/lxc/lxc_driver.c | 24 +++++-------- src/lxc/lxc_native.c | 40 ++++++++++----------- src/openvz/openvz_conf.c | 3 +- src/openvz/openvz_driver.c | 9 ++--- src/qemu/qemu_saveimage.c | 21 ++++------- src/qemu/qemu_snapshot.c | 6 ++-- src/test/test_driver.c | 39 +++++++-------------- src/vbox/vbox_common.c | 14 +++----- src/vmware/vmware_conf.c | 6 ++-- src/vmware/vmware_driver.c | 10 ++---- src/vmx/vmx.c | 12 +++---- src/vz/vz_driver.c | 24 +++++-------- src/vz/vz_sdk.c | 41 ++++++++++------------ tests/securityselinuxtest.c | 8 ++--- 25 files changed, 182 insertions(+), 317 deletions(-) -- 2.32.0

2 6

[PATCH v2 0/4] Add an option to use virDomainGetSecurityLabelList and test it
by Luke Yue 03 Dec '21

03 Dec '21

diff to v1: - Add some variety when filling the test driver seclabels array - Split 2/3 in v1 to function patch and align output patch link to v1: https://listman.redhat.com/archives/libvir-list/2021-September/msg00015.html link to CI: https://gitlab.com/lukedyue/libvirt/-/pipelines/422002148 Luke Yue (4): test_driver: Implement virDomainGetSecurityLabelList virsh: Add '--full-seclabels' option for dominfo virsh: Realign some outputs tests: Add test for virDomainGetSecurityLabelList docs/manpages/virsh.rst | 5 ++- src/test/test_driver.c | 43 ++++++++++++++++++ tests/virsh-undefine | 8 ++-- tests/virshtest.c | 77 ++++++++++++++++---------------- tools/virsh-domain-monitor.c | 85 ++++++++++++++++++++++++------------ 5 files changed, 147 insertions(+), 71 deletions(-) -- 2.34.1

1 4

[PATCH v4 0/8] Implement detach device related APIs for test driver
by Luke Yue 03 Dec '21

03 Dec '21

diff to v3: - Add virDomainDeviceDefOperationsCallbacks to xmlopt for de-duplicating purpose - Add virDomainDeviceTypeFlags for de-duplicating purpose - Remove the memballoon helper function - Squash test_driver commits - Move test device xmls to generichotplugdata - Reimplement tests with internal APIs link to v3: https://listman.redhat.com/archives/libvir-list/2021-November/msg00288.html link to CI: https://gitlab.com/lukedyue/libvirt/-/pipelines/421921587 Luke Yue (8): conf: Introduce virDomainInputDefRemove and fix memory leak conf: Introduce virDomainDeviceDefOperationsCallbacks to xmlopt conf: Add virDomainDeviceTypeFlags and use it in various drivers conf: Add tpm helpers for future use domain_driver: extract DetachXXXDeviceConfig related functions and use them test_driver: Implement virDomainDetachDeviceFlags examples: xml: test: add xml for testing devices related APIs tests: Add generichotplugtest examples/xml/test/meson.build | 1 + examples/xml/test/testdomfc5.xml | 54 ++ examples/xml/test/testnodeinline.xml | 54 ++ src/bhyve/bhyve_domain.c | 2 +- src/ch/ch_conf.c | 2 +- src/conf/domain_conf.c | 572 +++++++++++++++++- src/conf/domain_conf.h | 135 ++++- src/conf/virconftypes.h | 2 + src/hyperv/hyperv_driver.c | 3 +- src/libvirt_private.syms | 21 + src/libxl/libxl_conf.c | 3 +- src/libxl/libxl_domain.c | 8 + src/libxl/libxl_domain.h | 1 + src/libxl/libxl_driver.c | 73 +-- src/lxc/lxc_conf.c | 3 +- src/lxc/lxc_domain.c | 7 + src/lxc/lxc_domain.h | 1 + src/lxc/lxc_driver.c | 62 +- src/openvz/openvz_conf.c | 2 +- src/qemu/qemu_conf.c | 3 +- src/qemu/qemu_domain.c | 39 ++ src/qemu/qemu_domain.h | 6 + src/qemu/qemu_driver.c | 204 +------ src/qemu/qemu_process.c | 2 +- src/security/virt-aa-helper.c | 2 +- src/test/test_driver.c | 197 +++++- src/vbox/vbox_common.c | 2 +- src/vmware/vmware_driver.c | 2 +- src/vmx/vmx.c | 2 +- src/vz/vz_driver.c | 2 +- tests/bhyveargv2xmltest.c | 2 +- .../generichotplug-controller.xml | 1 + .../generichotplug-disk-cdrom.xml | 5 + .../generichotplug-filesystem.xml | 6 + .../generichotplug-hostdev.xml | 5 + .../generichotplug-input.xml | 1 + .../generichotplug-interface.xml | 6 + .../generichotplug-lease.xml | 5 + .../generichotplug-memballoon.xml | 3 + .../generichotplug-memory.xml | 6 + .../generichotplugdata/generichotplug-rng.xml | 4 + .../generichotplug-shmem.xml | 4 + .../generichotplug-sound.xml | 3 + .../generichotplugdata/generichotplug-tpm.xml | 5 + .../generichotplug-vsock.xml | 3 + .../generichotplug-watchdog.xml | 1 + tests/generichotplugtest.c | 178 ++++++ tests/meson.build | 1 + tests/testutils.c | 2 +- 49 files changed, 1377 insertions(+), 331 deletions(-) create mode 100644 tests/generichotplugdata/generichotplug-controller.xml create mode 100644 tests/generichotplugdata/generichotplug-disk-cdrom.xml create mode 100644 tests/generichotplugdata/generichotplug-filesystem.xml create mode 100644 tests/generichotplugdata/generichotplug-hostdev.xml create mode 100644 tests/generichotplugdata/generichotplug-input.xml create mode 100644 tests/generichotplugdata/generichotplug-interface.xml create mode 100644 tests/generichotplugdata/generichotplug-lease.xml create mode 100644 tests/generichotplugdata/generichotplug-memballoon.xml create mode 100644 tests/generichotplugdata/generichotplug-memory.xml create mode 100644 tests/generichotplugdata/generichotplug-rng.xml create mode 100644 tests/generichotplugdata/generichotplug-shmem.xml create mode 100644 tests/generichotplugdata/generichotplug-sound.xml create mode 100644 tests/generichotplugdata/generichotplug-tpm.xml create mode 100644 tests/generichotplugdata/generichotplug-vsock.xml create mode 100644 tests/generichotplugdata/generichotplug-watchdog.xml create mode 100644 tests/generichotplugtest.c -- 2.34.1

1 8

Release of libvirt-7.10.0
by Jiri Denemark 03 Dec '21

03 Dec '21

The 7.10.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://libvirt.org/sources/ https://libvirt.org/sources/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is greatly appreciated. * New features * Added virt-pki-query-dn binary This binary helps users figure out the format of Distinguished Name from a certificate file the way that libvirt expects it in tls_allowed_dn_list option of libvirtd.conf configuration file * Improvements * qemu: Report guest interface information in ``virDomainGetGuestInfo`` Libvirt is now able to report interface information from the guest's perspective (using guest agent). * qemu: detect guest side errors during device removal Libvirt is now able to detect guest side errors during device removal by using the DEVICE_UNPLUG_GUEST_ERROR event, available in QEMU 6.2.0. * Minimum SSF setting The libvirtd.conf option tcp_min_ssf can be used to override the minimum permitted security strength factor for non-TLS remote connections. The current hardcoded minimum is 56 (single-DES) and will be raised to 112 in the future. Setting a minimum lower than 112 is not supported. * qemu: Report stats also for block copy destination and backup job scratch images The statistics are available via the bulk domain stats API. * Bug fixes * qemu: Don't format 'ramfb' attribute when disabled Fix a regression caused by the conversion to JSON -device arguments where 'ramfb' would be put on the commandline of 'vfio-pci' which doesn't have it, thus breaking VMs with a mediated host device. * qemu: Fix block copy and backup to encrypted storage An oversight in last release lead to a spurious error being reported when encrypted storage was requested for disk images which are not directly backing the disk, which is now fixed. Enjoy. Jirka

4 3

[PATCH] Fix reboot command for LXC containers
by joachim.falk＠jfalk.de 03 Dec '21

03 Dec '21

From: Joachim Falk <joachim.falk(a)gmx.de> The virNetDaemonQuit(dmn) command in virLXCControllerSignalChildIO triggers an early close of all clients of lxc_controller. Here, libvirtd itself is a client of this controller, and the client connection is used to notify libvirtd if a reboot of the container is required. However, the client connection was closed before such a status could be sent to libvirtd. To fix this bug, we will immediately send the reboot or shutdown status of the container to libvirtd, and only after client disconnect will we trigger virNetDaemonQuit. Fixes: #237 Bug: https://gitlab.com/libvirt/libvirt/-/issues/237 Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=991773 Signed-off-by: Joachim Falk <joachim.falk(a)gmx.de> --- src/lxc/lxc_controller.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c index 444f728af4..039efcd7c7 100644 --- a/src/lxc/lxc_controller.c +++ b/src/lxc/lxc_controller.c @@ -894,8 +894,10 @@ static void virLXCControllerClientCloseHook(virNetServerClient *client) virLXCController *ctrl = virNetServerClientGetPrivateData(client); VIR_DEBUG("Client %p has closed", client); - if (ctrl->client == client) + if (ctrl->client == client) { ctrl->client = NULL; + VIR_DEBUG("Client has gone away"); + } if (ctrl->inShutdown) { VIR_DEBUG("Arm timer to quit event loop"); virEventUpdateTimeout(ctrl->timerShutdown, 0); @@ -1006,8 +1008,11 @@ static int lxcControllerClearCapabilities(void) static bool wantReboot; static virMutex lock = VIR_MUTEX_INITIALIZER; +static int +virLXCControllerEventSendExit(virLXCController *ctrl, + int exitstatus); -static void virLXCControllerSignalChildIO(virNetDaemon *dmn, +static void virLXCControllerSignalChildIO(virNetDaemon *dmn G_GNUC_UNUSED, siginfo_t *info G_GNUC_UNUSED, void *opaque) { @@ -1018,7 +1023,6 @@ static void virLXCControllerSignalChildIO(virNetDaemon *dmn, ret = waitpid(-1, &status, WNOHANG); VIR_DEBUG("Got sig child %d vs %lld", ret, (long long)ctrl->initpid); if (ret == ctrl->initpid) { - virNetDaemonQuit(dmn); virMutexLock(&lock); if (WIFSIGNALED(status) && WTERMSIG(status) == SIGHUP) { @@ -1026,6 +1030,7 @@ static void virLXCControllerSignalChildIO(virNetDaemon *dmn, wantReboot = true; } virMutexUnlock(&lock); + virLXCControllerEventSendExit(ctrl, wantReboot ? 1 : 0); } } @@ -2276,9 +2281,10 @@ virLXCControllerEventSendExit(virLXCController *ctrl, VIR_DEBUG("Waiting for client to complete dispatch"); ctrl->inShutdown = true; virNetServerClientDelayedClose(ctrl->client); - virNetDaemonRun(ctrl->daemon); + } else { + VIR_DEBUG("Arm timer to quit event loop"); + virEventUpdateTimeout(ctrl->timerShutdown, 0); } - VIR_DEBUG("Client has gone away"); return 0; } @@ -2430,8 +2436,6 @@ virLXCControllerRun(virLXCController *ctrl) rc = virLXCControllerMain(ctrl); - virLXCControllerEventSendExit(ctrl, rc); - cleanup: VIR_FORCE_CLOSE(control[0]); VIR_FORCE_CLOSE(control[1]); -- 2.30.2

2 1

[PATCH] Fix reboot command for LXC containers
by Joachim Falk 02 Dec '21

02 Dec '21

The virNetDaemonQuit(dmn) command in virLXCControllerSignalChildIO triggers an early close of all clients of lxc_controller. Here, libvirtd itself is a client of this controller, and the client connection is used to notify libvirtd if a reboot of the container is required. However, the client connection was closed before such a status could be sent to libvirtd. To fix this bug, we will immediately send the reboot or shutdown status of the container to libvirtd, and only after client disconnect will we trigger virNetDaemonQuit. Fixes: #237 Bug: https://gitlab.com/libvirt/libvirt/-/issues/237 Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=991773 Signed-off-by: Joachim Falk <joachim.falk(a)gmx.de> --- src/lxc/lxc_controller.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c index 444f728af4..75107822ba 100644 --- a/src/lxc/lxc_controller.c +++ b/src/lxc/lxc_controller.c @@ -894,8 +894,10 @@ static void virLXCControllerClientCloseHook(virNetServerClient *client) virLXCController *ctrl = virNetServerClientGetPrivateData(client); VIR_DEBUG("Client %p has closed", client); - if (ctrl->client == client) + if (ctrl->client == client) { ctrl->client = NULL; + VIR_DEBUG("Client has gone away"); + } if (ctrl->inShutdown) { VIR_DEBUG("Arm timer to quit event loop"); virEventUpdateTimeout(ctrl->timerShutdown, 0); @@ -1006,6 +1008,9 @@ static int lxcControllerClearCapabilities(void) static bool wantReboot; static virMutex lock = VIR_MUTEX_INITIALIZER; +static int +virLXCControllerEventSendExit(virLXCController *ctrl, + int exitstatus); static void virLXCControllerSignalChildIO(virNetDaemon *dmn, siginfo_t *info G_GNUC_UNUSED, @@ -1015,10 +1020,10 @@ static void virLXCControllerSignalChildIO(virNetDaemon *dmn, int ret; int status; + ignore_value(dmn); ret = waitpid(-1, &status, WNOHANG); VIR_DEBUG("Got sig child %d vs %lld", ret, (long long)ctrl->initpid); if (ret == ctrl->initpid) { - virNetDaemonQuit(dmn); virMutexLock(&lock); if (WIFSIGNALED(status) && WTERMSIG(status) == SIGHUP) { @@ -1026,6 +1031,7 @@ static void virLXCControllerSignalChildIO(virNetDaemon *dmn, wantReboot = true; } virMutexUnlock(&lock); + virLXCControllerEventSendExit(ctrl, wantReboot ? 1 : 0); } } @@ -2276,9 +2282,10 @@ virLXCControllerEventSendExit(virLXCController *ctrl, VIR_DEBUG("Waiting for client to complete dispatch"); ctrl->inShutdown = true; virNetServerClientDelayedClose(ctrl->client); - virNetDaemonRun(ctrl->daemon); + } else { + VIR_DEBUG("Arm timer to quit event loop"); + virEventUpdateTimeout(ctrl->timerShutdown, 0); } - VIR_DEBUG("Client has gone away"); return 0; } @@ -2430,8 +2437,6 @@ virLXCControllerRun(virLXCController *ctrl) rc = virLXCControllerMain(ctrl); - virLXCControllerEventSendExit(ctrl, rc); - cleanup: VIR_FORCE_CLOSE(control[0]); VIR_FORCE_CLOSE(control[1]); -- 2.30.2

2 2

[libvirt PATCH 0/5] Add bus-lock-ratelimit
by Tim Wiederhake 02 Dec '21

02 Dec '21

This was introduced recently in QEMU, see https://bugzilla.redhat.com/show_bug.cgi?id=1982165: Bus locks disrupts overall performance since it blocks all other cores (which must wait for the bus lock to be released before their memory operations). For VMM, it can detect every bus lock acquired by guest VMs and induces a VM exit. So VMM can count the number/frequency of bus lock and take some throttling action or just kill the guest. Tim Wiederhake (5): conf: Add bus-lock-ratelimit qemu: Add bus-lock-ratelimit doc: schema: Add bus-lock-ratelimit to domain schema tests: Add tests for bus-lock-ratelimit doc: Document new bus-lock-ratelimit option docs/formatdomain.rst | 4 +++ docs/schemas/domaincommon.rng | 7 +++++ src/conf/domain_conf.c | 34 +++++++++++++++++++++++ src/conf/domain_conf.h | 2 ++ src/qemu/qemu_command.c | 4 +++ src/qemu/qemu_validate.c | 1 + tests/qemuxml2argvdata/kvm-features.args | 2 +- tests/qemuxml2argvdata/kvm-features.xml | 1 + tests/qemuxml2xmloutdata/kvm-features.xml | 1 + 9 files changed, 55 insertions(+), 1 deletion(-) -- 2.31.1

2 6

[libvirt PATCH 00/14] qemu snapshot revert cleanup and refactor
by Pavel Hrdina 02 Dec '21

02 Dec '21

Pavel Hrdina (14): qemu_snapshot: revert: fix incorrect jump to cleanup qemu_snapshot: revert: drop unused variable qemu_snapshot: revert: use g_autoptr qemu_snapshot: revert: jump to endjob instead of calling qemuProcessEndJob qemu_snapshot: revert: remove cleanup label qemu_snapshot: revert: move validation to separate function qemu_snapshot: revert: move config prepare code to separate function qemu_snapshot: revert: emit event right after they are created qemu_snapshot: revert: refactor cleanup section qemu_snapshot: revert: move saving metadata to separate function qemu_snapshot: revert: save metadata within qemu process job qemu_snapshot: revert: move active snapshot revert to separate function qemu_snapshot: revert: rename qemuSnapshotRevertInactive qemu_snapshot: revert: move inactive snapshot to separate function src/qemu/qemu_snapshot.c | 554 ++++++++++++++++++++++----------------- 1 file changed, 320 insertions(+), 234 deletions(-) -- 2.31.1

2 16

[libvirt PATCH] qemu: Enable unprivileged userfaultfd for post-copy migration
by Jiri Denemark 02 Dec '21

02 Dec '21

Userfaultfd is by default allowed only for privileged processes. Since libvirt runs QEMU unprivileged, we need to enable unprivileged access to userfaultfd before starting post-copy migration. Rather than providing a static sysctl configuration file, we set the sysctl knob in runtime once post-copy migration is requested. This way unprivileged_userfaultfd is only enabled once actually used. https://bugzilla.redhat.com/show_bug.cgi?id=1945420 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_migration_params.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_params.c index dbc3219826..a9449ed1ff 100644 --- a/src/qemu/qemu_migration_params.c +++ b/src/qemu/qemu_migration_params.c @@ -804,6 +804,24 @@ qemuMigrationCapsToJSON(virBitmap *caps, } +static void +qemuMigrationParamsEnableUserfaultfd(virDomainObj *vm) +{ + const char *sysctl = "/proc/sys/vm/unprivileged_userfaultfd"; + + if (!virFileExists(sysctl)) + return; + + VIR_DEBUG("Enabling unprivileged userfaultfd for post-copy migration of " + "domain %s", vm->def->name); + + if (virFileWriteStr(sysctl, "1", 0) < 0) { + virReportSystemError(errno, "%s", + _("failed to enable unprivileged userfaultfd")); + } +} + + /** * qemuMigrationParamsApply * @driver: qemu driver @@ -839,6 +857,13 @@ qemuMigrationParamsApply(virQEMUDriver *driver, goto cleanup; } } else { + /* userfaultfd may only be enabled for privileged processes by default, + * we need to make sure QEMU can use it before enabling post-copy + * migration */ + if (virBitmapIsBitSet(priv->migrationCaps, QEMU_MIGRATION_CAP_POSTCOPY) && + virBitmapIsBitSet(migParams->caps, QEMU_MIGRATION_CAP_POSTCOPY)) + qemuMigrationParamsEnableUserfaultfd(vm); + if (!(caps = qemuMigrationCapsToJSON(priv->migrationCaps, migParams->caps))) goto cleanup; -- 2.34.1

3 2

[PATCH 0/3] qemu: Simplify qemuDomainGetStats() related code
by Michal Privoznik 02 Dec '21

02 Dec '21

*** BLURB HERE *** Michal Prívozník (3): qemu: Drop comma after QEMU_CAPS_LAST in queryDirtyRateRequired[] qemu: prefer .requiredCaps for VIR_DOMAIN_STATS_IOTHREAD qemuConnectGetAllDomainStats: Simplify qemuDomainGetStats() error handling src/qemu/qemu_driver.c | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) -- 2.32.0

2 4