- Devel - libvirt List Archives

[Libvir] Migration support
by Simon Boulet 30 Mar '07

30 Mar '07

Hi, What is the status of migration support for Libvirt, either offline or live migration? My understanding of Libvirt is that it does not support connecting to remote nodes yet. Thank you Simon

3 2

[Libvir] [PATCH] XPath accessors cleanup
by Daniel Veillard 30 Mar '07

30 Mar '07

It a long time cleanup TODO, the XML parsing code of xml.c is invaded with libxml2 specific XPath lookup code, this patch defines 5 clearly isolated accessor functions and then fixes all the src/xml.c code to use those. IMHO this clearly improve readability and maintanability and I think I also found a couple of bugs in the process. The patch enclosed only fixes xml.c and xml.h, the next step is to chase other modules to apply the same treatment if needed. Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

2 2

[Libvir] [PATCH] Enable USB device setting information handling on virsh.
by Masayuki Sunou 29 Mar '07

29 Mar '07

Hi When domHVM started by virsh create, the information of USB setting is not saved by vish dumpxml. The reason is that USB setting is defined by Xen itself, not virsh. This patch enables USB device setting information handling on virsh create/virsh dumpxml. Signed-off-by: Masayuki Sunou <fj1826dm(a)aa.jp.fujitsu.com> Thanks, Masayuki Sunou Index: libvirt/src/xend_internal.c =================================================================== RCS file: /data/cvs/libvirt/src/xend_internal.c,v retrieving revision 1.99 diff -u -p -r1.99 xend_internal.c --- libvirt/src/xend_internal.c 6 Mar 2007 21:55:44 -0000 1.99 +++ libvirt/src/xend_internal.c 7 Mar 2007 08:28:55 -0000 @@ -1666,6 +1666,13 @@ xend_parse_sexp_desc(virConnectPtr conn, free(tty); } + tmp = sexpr_node(root, "domain/image/hvm/usbdevice"); + if ((tmp != NULL) && (tmp[0] != 0)) { + virBufferVSprintf(&buf, " <usb usbdevice='%s'/>\n", tmp); + } else if (sexpr_int(root, "domain/image/hvm/usb")) { + virBufferAdd(&buf, " <usb/>\n", 11 ); + } + virBufferAdd(&buf, " </devices>\n", 13); virBufferAdd(&buf, "</domain>\n", 10); Index: libvirt/src/xml.c =================================================================== RCS file: /data/cvs/libvirt/src/xml.c,v retrieving revision 1.62 diff -u -p -r1.62 xml.c --- libvirt/src/xml.c 6 Mar 2007 20:00:17 -0000 1.62 +++ libvirt/src/xml.c 7 Mar 2007 08:28:55 -0000 @@ -524,6 +524,20 @@ virDomainParseXMLOSDescHVM(virConnectPtr } xmlXPathFreeObject(obj); + obj = xmlXPathEval(BAD_CAST "/domain/devices/usb", ctxt); + if ((obj != NULL) && (obj->type == XPATH_NODESET) && + (obj->nodesetval != NULL) && (obj->nodesetval->nodeNr == 1)) { + virBufferAdd(buf, "(usb 1)", 7); + xmlXPathFreeObject(obj); + obj = xmlXPathEval(BAD_CAST "string(/domain/devices/usb/@usbdevice)", ctxt); + if ((obj != NULL) && (obj->type == XPATH_STRING) && + (obj->stringval != NULL) && (obj->stringval[0] != 0)) { + virBufferVSprintf(buf, "(usbdevice '%s')", obj->stringval); + } + } + if (obj) + xmlXPathFreeObject(obj); + virBufferAdd(buf, "))", 2); if (boot_dev)

4 10

[Libvir] [PATCH] Python bindings now generate exceptions for libvirt errors
by Richard W.M. Jones 28 Mar '07

28 Mar '07

Following on from this thread: https://www.redhat.com/archives/libvir-list/2007-March/thread.html#00341 The first attachment is a patch which changes the generated Python bindings so that they always raise an exception when an underlying error occurs in the C libvirt library. The second attachment is for information only (not to be applied) - it shows the differences in the generated file libvirtclass.py. I have checked each of these changes by hand against both the libvirt.c interface description and the C implementation of the Python bindings (libvir.c and libvirt-py.c), and each change seems correct. I have _not_ tested this against virt-manager. It is quite possible that virt-manager will cease to work if it wasn't checking the return values from affected functions carefully. I'll check this later today and supply a patch (to virt-manager) if necessary. I have some additional questions about the Python bindings, but I'll put those in a separate thread. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

4 15

[Libvir] A couple of questions about the Python bindings
by Richard W.M. Jones 28 Mar '07

28 Mar '07

virDomainGetUUIDString, virDomainPinVcpu, virNetworkGetUUIDString: These functions don't seem to check whether the parameters are correct. For example, virDomainGetUUIDString doesn't check if the buffer parameter passed from Python is large enough to take the UUID string. virDomainPinVcpu is just plain strange (but I guess that strangeness eminates from the Xen implementation), but it seems possible for the Python code to be wrong about the length of the Vcpu map (string). Shouldn't the length be taken from the string itself? virDomainUndefine, virNetworkUndefine: It's unclear from the libvirt documentation, but it sounds as if these functions invalidate (free) the virDomainPtr / virNetworkPtr object passed to them. (In fact, the Xen implementation of virDomainPtr at least _doesn't_ free it - is that a bug?) If this is the case, then the Python bindings ought to set self._o = None. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

3 2

[Libvir] [PATCH] Fix value of XEN_V2_OP_SETMAXMEM
by Masayuki Sunou 28 Mar '07

28 Mar '07

Hi Because the value of XEN_V2_OP_SETMAXMEM in xen_internal.c is wrong, virsh setmaxmem outputs error message. --> Both XEN_V2_OP_SETMAXMEM and XEN_V2_OP_GETVCPUINFO are set to 14, but XEN_V2_OP_SETMAXMEM should be set to 11. -------------------------------------------------------------------------------- # virsh setmaxmem 0 921600 libvir: Xen error : failed Xen syscall ioctl 8518692 -------------------------------------------------------------------------------- This patch sets the right value to XEN_V2_OP_SETMAXMEM. Signed-off-by: Masayuki Sunou <fj1826dm(a)aa.jp.fujitsu.com> Thanks, Masayuki Sunou. -------------------------------------------------------------------------------- Index: libvirt/src/xen_internal.c =================================================================== RCS file: /data/cvs/libvirt/src/xen_internal.c,v retrieving revision 1.67 diff -u -p -r1.67 xen_internal.c --- libvirt/src/xen_internal.c 23 Mar 2007 09:18:24 -0000 1.67 +++ libvirt/src/xen_internal.c 26 Mar 2007 00:09:35 -0000 @@ -280,7 +280,7 @@ typedef struct xen_v0_domainop xen_v0_do */ #define XEN_V0_OP_SETMAXMEM 28 #define XEN_V1_OP_SETMAXMEM 28 -#define XEN_V2_OP_SETMAXMEM 14 +#define XEN_V2_OP_SETMAXMEM 11 struct xen_v0_setmaxmem { domid_t domain; --------------------------------------------------------------------------------

2 3

[Libvir] [PATCH] Fix warn_unused_result when compiling with latest glibc
by Richard W.M. Jones 27 Mar '07

27 Mar '07

I'm not sure if this is the right way to solve this, but it is a way. Rich.

3 5

[Libvir] libvirt not compatible with Xen-unstable hypercall API ?
by Jerone Young 27 Mar '07

27 Mar '07

While trying to verify any potential problem between with libvirt & Xen PPC port. I've found that libvirt currently in CVS attempts to determine what hypercall version to follow, by looking at the hypervisior version. It determines that this is some arbitrary versioning "v2" of the hypercall api. This starts on line 1250 of xen_internal.c. This does not appear to be compatible with current Xen-Unstable from testing and trying to hack it up. Has any work been done toward making libvirt compatible with Xen-unstable that has not been included? Or is it waiting till the offical 3.0.5 release? We are attempting to ensure that Xen PPC works with libvirt. Though we have to use the latest hypercall api. Thanks, Jerone

4 5

[Libvir] [PATCH] pae/nonpae capabilities for paravirt xen guests
by David Lutterkort 26 Mar '07

26 Mar '07

I noticed that the guest capabilities on a xen dom0 always contain both the pae and nonpae feature - AFAIK, you can't mix pae/nonpae guests and hosts, and only one of the features should be there. The attached patch contains the obvious fix. David

4 5

[Libvir] don't clobber user-specified CFLAGS
by Jim Meyering 26 Mar '07

26 Mar '07

Building libvirt with CFLAGS=-g doesn't work as expected: gcc runs without -g. That was due to the following assignment that gives CFLAGS the value of an undefined variable. 2007-03-23 Jim Meyering <jim(a)meyering.net> * acinclude.m4: Remove bogus CFLAGS=$undefined_var assignment that would clobber any CFLAGS setting from e.g., ./autogen.sh CFLAGS=-g. Reported by David Lutterkort. Index: acinclude.m4 =================================================================== RCS file: /data/cvs/libvirt/acinclude.m4,v retrieving revision 1.3 diff -u -p -r1.3 acinclude.m4 --- acinclude.m4 21 Mar 2007 15:22:31 -0000 1.3 +++ acinclude.m4 23 Mar 2007 18:52:55 -0000 @@ -59,8 +59,6 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[ unset option unset try_compiler_flags - CFLAGS="$realsave_CFLAGS" - AC_ARG_ENABLE(iso-c, AC_HELP_STRING([--enable-iso-c], [Try to warn if code is not ISO C ]),,

2 1

[Libvir] [PATCH] Add the message when a little memory is set with setmaxmem.
by Masayuki Sunou 26 Mar '07

26 Mar '07

Hi The message which a cause of an error is hard to detect is displayed when "virsh setmaxmem" sets the maximum memory of an active domain less than Used Memory. -------------------------------------------------------------------------------- # virsh setmaxmem 0 4096 libvir: Xen error : failed Xen syscall ioctl 8518692 libvir: Xen Daemon error : POST operation failed: (xend.err "(22, 'Invalid argument')") libvir: error : library call virDomainSetMaxMemory failed, possibly not supported -------------------------------------------------------------------------------- This patch displays the message which is easier to detect the cause of an error to a user. -------------------------------------------------------------------------------- # virsh setmaxmem 0 4096 error: 4096 is less than current used memory. -------------------------------------------------------------------------------- Signed-off-by: Masayuki Sunou <fj1826dm(a)aa.jp.fujitsu.com> Thanks, Masayuki Sunou. -------------------------------------------------------------------------------- Index: libvirt/src/virsh.c =================================================================== RCS file: /data/cvs/libvirt/src/virsh.c,v retrieving revision 1.67 diff -u -p -r1.67 virsh.c --- libvirt/src/virsh.c 20 Mar 2007 15:31:46 -0000 1.67 +++ libvirt/src/virsh.c 22 Mar 2007 02:27:16 -0000 @@ -1493,6 +1493,7 @@ static int cmdSetmaxmem(vshControl * ctl, vshCmd * cmd) { virDomainPtr dom; + virDomainInfo info; int bytes; int ret = TRUE; @@ -1509,6 +1510,18 @@ cmdSetmaxmem(vshControl * ctl, vshCmd * return FALSE; } + if (virDomainGetID(dom) != ((unsigned int)-1)) { + if (virDomainGetInfo(dom, &info) != 0) { + virDomainFree(dom); + return FALSE; + } + if (bytes < info.memory) { + vshError(ctl, FALSE, _("%d is less than current used memory."), bytes); + virDomainFree(dom); + return FALSE; + } + } + if (virDomainSetMaxMemory(dom, bytes) != 0) { ret = FALSE; } --------------------------------------------------------------------------------

2 3

[Libvir] sprintf cleanup patch
by Daniel Veillard 23 Mar '07

23 Mar '07

Sprintf is potentially dangerous, so I replaced all instances with snprintf (even in cases where the usage was garanteed to be safe to have a coherent approach). Pending patch appended, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

2 1

[Libvir] Python bindings, errors & exceptions
by Richard W.M. Jones 23 Mar '07

23 Mar '07

I'm really confused about how the Python bindings are supposed to handle errors. Can someone explain how this is supposed to work? Case in point: currently virt-manager fails because conn.listNetworks () returns None, whereas virt-manager is expecting it to return a list of network objects. The code returns None because the underlying calls (either virConnectNumOfNetworks or virConnectListNetworks) is failing. The functions in question are: class virConnect: # libvirtclass.py # ... def listNetworks(self): """list the networks, stores the pointers to the names in @names """ ret = libvirtmod.virConnectListNetworks(self._o) return ret (the above code is automatically generated by generator.py), and: static PyObject * // libvir.c libvirt_virConnectListNetworks(PyObject *self ATTRIBUTE_UNUSED, PyObject *args) { PyObject *py_retval; char **names = NULL; int c_retval, i; virConnectPtr conn; PyObject *pyobj_conn; // ... c_retval = virConnectNumOfNetworks(conn); if (c_retval < 0) { Py_INCREF(Py_None); return (Py_None); } // ... py_retval = PyList_New(c_retval); if (names) { for (i = 0;i < c_retval;i++) { PyList_SetItem(py_retval, i, libvirt_constcharPtrWrap(names[i])); free(names[i]); } free(names); } return(py_retval); } (I've omitted some code to make the general idea clearer). The upshot is that if the underlying functions fail, at no point is an exception thrown. This is not always the case. For other functions which return C structure pointers (eg. libvirt.open which wraps virConnectOpen), the bindings automatically catch the invalid return and throw an exception. For example: def open(name): # libvirtclass.py """This function should be called first to get a connection to the Hypervisor and xen store """ ret = libvirtmod.virConnectOpen(name) if ret is None:raise libvirtError('virConnectOpen() failed') return virConnect(_obj=ret) It is my view that all errors in C code should turn into Python exceptions. One way to do that would be to have a Python virterror handler which just directly throws the exception. I don't know if this is safe because the exception would unwind through C code, and in some languages that is safe, in others it is not. Another way would be to have a Python virterror handler which remembers that an exception happened, and after each auto-generated function call we check this and raise the exception. Since I'm just starting out in Python, I don't know if there are thread or other issues with this. Comments would be welcome. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

3 6

[Libvir] [PATCH] Xen capabilities does not detect PAE properly
by Richard W.M. Jones 23 Mar '07

23 Mar '07

-- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

2 1

Re: [Libvir] [patch 1/5] iptables: fix invalid free
by Daniel Veillard 22 Mar '07

22 Mar '07

On Wed, Mar 21, 2007 at 12:47:58PM +0000, Mark McLoughlin wrote: > In iptablesContextNew(), make sure we don't try and free an invalid > pointer if one of the iptRulesNew() fails. > > Signed-off-by: Mark McLoughlin <markmc(a)redhat.com> > > Index: libvirt/qemud/iptables.c > =================================================================== > --- libvirt.orig/qemud/iptables.c > +++ libvirt/qemud/iptables.c > @@ -496,7 +496,7 @@ iptablesContextNew(void) > { > iptablesContext *ctx; > > - if (!(ctx = (iptablesContext *) malloc(sizeof (iptablesContext)))) > + if (!(ctx = (iptablesContext *) calloc(1, sizeof (iptablesContext)))) > return NULL; > > if (!(ctx->input_filter = iptRulesNew("filter", IPTABLES_PREFIX "INPUT"))) I usually prefer malloc + memset( , 0, ) , but this probably comes from libxml2 where I replaced malloc calls with specific wrappers (and I still have a TODO for this in libvirt though some part of libvirt are not linked to libxml2 I guess so that may make things a bit harder) What's the policy w.r.t. error reporting in qemud and libvirt related daemons in general ? I guess a failure to malloc or thisd kind of problems should be logged somewhere, right ? > @@ -518,9 +518,12 @@ iptablesContextNew(void) > void > iptablesContextFree(iptablesContext *ctx) > { > - iptRulesFree(ctx->input_filter); > - iptRulesFree(ctx->forward_filter); > - iptRulesFree(ctx->nat_postrouting); > + if (ctx->input_filter) > + iptRulesFree(ctx->input_filter); > + if (ctx->forward_filter) > + iptRulesFree(ctx->forward_filter); > + if (ctx->nat_postrouting) > + iptRulesFree(ctx->nat_postrouting); > free(ctx); > } The patch does the right thing, sounds good to me :-) Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

5 18

[Libvir] [PATCH] Xen capabilities - nul-terminate the token and a couple of cleanups
by Richard W.M. Jones 22 Mar '07

22 Mar '07

-- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

1 0

[Libvir] Fix buffer overflow in dumping XML
by Daniel P. Berrange 22 Mar '07

22 Mar '07

The new bufferContentAndFree() method used for the QEMU daemon rellocs the buffer size down to release memory held by the buffer which was never used for any data. Unfortunately it reallocs it 1 byte too small, so later uses of strlen()/strcpy() either magically work, or randomly append gargage or crash the daemon depending on the phase of the moon :-) Re-allocing the buffer to relase a few bytes memory isn't really an optimization since the caller is going to free the entire block a very short while later, so this patch simply removes the realloc call. As an aside, the virBuffer functions in src/xml.c and the buffer functions in qemud/buf.c are both flawed wrt to the way they call the Grow method. The method expects the len parameter to be extra bytes needed, but several of the callers pass in the total desired length, so it allocates too much memory. There are various other non-fatal flaws which need to be cleaned up in this code, but the attached patch just focuses on the current fatal buffer overflow for now. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 2

[Libvir] [PATCH] virsh vcpupin guards CPU not existing.
by Masayuki Sunou 22 Mar '07

22 Mar '07

Hi When CPU not existing is set to virsh vcpupin, CPU affinity is set to all CPU. -------------------------------------------------------------------------------- # virsh vcpuinfo 0 VCPU: 0 CPU: 0 State: blocked CPU time: 428.8s CPU Affinity: y- # virsh vcpupin 0 0 100 libvir: Xen error : failed Xen syscall ioctl -1208339792 # virsh vcpuinfo 0 VCPU: 0 CPU: 0 State: blocked CPU time: 429.6s CPU Affinity: yy -------------------------------------------------------------------------------- This patch returns an error, when CPU not existing is set to virsh vcpupin. -------------------------------------------------------------------------------- # virsh vcpupin 0 0 100 error: Physical CPU 100 doesn't exist. -------------------------------------------------------------------------------- Signed-off-by: Masayuki Sunou <fj1826dm(a)aa.jp.fujitsu.com> Thanks, Masayuki Sunou. -------------------------------------------------------------------------------- Index: src/virsh.c =================================================================== RCS file: /data/cvs/libvirt/src/virsh.c,v retrieving revision 1.67 diff -u -p -r1.67 virsh.c --- src/virsh.c 20 Mar 2007 15:31:46 -0000 1.67 +++ src/virsh.c 22 Mar 2007 06:05:14 -0000 @@ -1358,6 +1358,11 @@ cmdVcpupin(vshControl * ctl, vshCmd * cm if (cpu < VIR_NODEINFO_MAXCPUS(nodeinfo)) { VIR_USE_CPU(cpumap, cpu); + } else { + vshError(ctl, FALSE, _("Physical CPU %d doesn't exist."), cpu); + free(cpumap); + virDomainFree(dom); + return FALSE; } cpulist = index(cpulist, ','); if (cpulist) --------------------------------------------------------------------------------

2 1

[Libvir] [PATCH] Add Xen Interface Version Check
by Atsushi SAKAI 22 Mar '07

22 Mar '07

Add Xen Interface version Check XEN_SYSCTL_INTERFACE_VERSION XEN_DOMCTL_INTERFACE_VERSION Currently following distribution is considered. sys dom RHEL5.0 2 3 Fedora 7 2 4 Xen-unstable 3 5 Please check virVcpuInfoPtr ipt; error message is collect or not + fprintf(stderr, "Memory allocation failed at xenHypervisorIniti()\n"); Signed-off-by: Atsushi SAKAI <sakaia(a)jp.fujitsu.com> Thanks Atsushi SAKAI --- libvirt-0.2.1/src/xen_internal.c 2007-03-16 06:36:41.000000000 +0900 +++ libvirt-0.2.1.hyper/src/xen_internal.c 2007-03-19 19:09:08.000000000 +0900 @@ -655,7 +655,6 @@ return (0); } -#ifndef PROXY /** * xenHypervisorDoV2Dom: * @handle: the handle to the Xen hypervisor @@ -697,7 +696,6 @@ return (0); } -#endif /* PROXY */ /** * virXen_getdomaininfolist: @@ -1057,6 +1055,8 @@ } return(ret); } +#endif /* !PROXY*/ + /** * virXen_getvcpusinfo: * @handle: the hypervisor handle @@ -1169,7 +1169,6 @@ } return(ret); } -#endif /* !PROXY*/ /** * xenHypervisorInit: @@ -1184,6 +1183,7 @@ hypercall_t hc; v0_hypercall_t v0_hc; xen_getdomaininfo info; + virVcpuInfoPtr ipt; if (initialized) { if (hypervisor_version == -1) @@ -1291,15 +1291,47 @@ * or the old ones */ hypervisor_version = 2; - /* TODO: one probably will need to autodetect thse subversions too */ + + ipt = malloc(sizeof(virVcpuInfo)); + if (ipt == NULL){ +#ifdef DEBUG + fprintf(stderr, "Memory allocation failed at xenHypervisorIniti()\n"); +#endif + return(-1); + } + /* Currently consider RHEL5.0 Fedora7 and xen-unstable */ sys_interface_version = 2; /* XEN_SYSCTL_INTERFACE_VERSION */ - dom_interface_version = 3; /* XEN_DOMCTL_INTERFACE_VERSION */ if (virXen_getdomaininfo(fd, 0, &info) == 1) { + /* RHEL 5.0 */ + dom_interface_version = 3; /* XEN_DOMCTL_INTERFACE_VERSION */ + if (virXen_getvcpusinfo(fd, 0, 0, ipt, NULL, 0) == 0){ #ifdef DEBUG - fprintf(stderr, "Using hypervisor call v2, sys version 2\n"); + fprintf(stderr, "Using hypervisor call v2, sys ver2 dom ver3\n"); #endif - goto done; + goto done; + } + /* Fedora 7 */ + dom_interface_version = 4; /* XEN_DOMCTL_INTERFACE_VERSION */ + if (virXen_getvcpusinfo(fd, 0, 0, ipt, NULL, 0) == 0){ +#ifdef DEBUG + fprintf(stderr, "Using hypervisor call v2, sys ver2 dom ver4\n"); +#endif + goto done; + } } + + sys_interface_version = 3; /* XEN_SYSCTL_INTERFACE_VERSION */ + if (virXen_getdomaininfo(fd, 0, &info) == 1) { + /* xen-unstable */ + dom_interface_version = 5; /* XEN_DOMCTL_INTERFACE_VERSION */ + if (virXen_getvcpusinfo(fd, 0, 0, ipt, NULL, 0) == 0){ +#ifdef DEBUG + fprintf(stderr, "Using hypervisor call v2, sys ver3 dom ver5\n"); +#endif + goto done; + } + } + hypervisor_version = 1; sys_interface_version = -1; if (virXen_getdomaininfo(fd, 0, &info) == 1) {

2 4

[Libvir] QEMU networking XML docs summary
by Daniel P. Berrange 21 Mar '07

21 Mar '07

What follows is a summary of the ways in which you can setup QEMU networking 1. Userspace SLIRP stack Provides a virtual LAN with NAT to the outside world. The virtual network has DHCP & DNS services and will give the guest VM addresses starting from 10.0.2.15. The default router will be 10.0.2.2 and the DNS server will be 10.0.2.3. This networking is the only option for unprivileged users who need their VMS to have outgoing access. Example configs are: <interface type='user'/> <interface type='user'> <mac address="11:22:33:44:55:66:/> </interface> 2. Virtual network Provides a virtual network using a bridge device in the host. Depending on the virtual network configuration, the network may be totally isolated, NAT'ing to aan explicit network device, or NAT'ing to the default route. DHCP and DNS are provided on the virtual network in all cases and the IP range can be determined by examining the virtual network config with 'virsh net-dumpxml <network name>'. There is one virtual network called 'default' setup out of the box which does NAT'ing to the default route and has an IP range of 192.168.22.0/255.255.255.0. Each guest will have an associated tun device created with a name of vnetN, which can also be overriden with the <target> element. Example configs are <interface type='network'> <source network='default'/> </interface> <interface type='network'> <source network='default'/> <target dev='vnet7'/> <mac address="11:22:33:44:55:66:/> </interface> 3. Bridge to to LAN Provides a bridge from the VM directly onto the LAN. This assumes there is a bridge device on the host which has one or more of the hosts physical NICs enslaved. The guest VM will have an associated tun device created with a name of vnetN, which can also be overriden with the <target> element. The tun device will be enslaved to the bridge. The IP range / network configuration is whatever is used on the LAN. This provides the guest VM full incoming & outgoing net access just like a physical machine. Examples include <interface type='bridge'> <source dev='br0'/> </interface> <interface type='bridge'> <source dev='br0'/> <target dev='vnet7'/> <mac address="11:22:33:44:55:66:/> </interface> 4. Generic connection to LAN Provides a means for the administrator to execute an arbitrary script to connect the guest's network to the LAN. The guest will have a tun device created with a name of vnetN, which can also be overriden with the <target> element. After creating the tun device a shell script will be run which is expected to do whatever host network integration is required. By default this script is called /etc/qemu-ifup but can be overriden. <interface type='ethernet'/> <interface type='ethernet'> <target dev='vnet7'/> <script path='/etc/qemu-ifup-mynet'/> </interface> 5. Multicast tunnel A multicast group is setup to represent a virtual network. Any VMs whose network devices are in the same multicast group can talk to each other even across hosts. This mode is also available to unprivileged users. There is no default DNS or DHCP support and no outgoing network access. To provide outgoing network access, one of the VMs should have a 2nd NIC which is connected to one of the first 4 network types and do the appropriate routing. The multicast protocol is compatible with that used by user mode linux guests too. The source address used must be from the multicast address block <interface type='mcast'> <source address='230.0.0.1' port='5558'/> </interface> 6. TCP tunnel A TCP client/server architecture provides a virtual network. One VM provides the server end of the netowrk, all other VMS are configured as clients. All network traffic is routed between the VMs via the server. This mode is also available to unprivileged users. There is no default DNS or DHCP support and no outgoing network access. To provide outgoing network access, one of the VMs should have a 2nd NIC which is connected to one of the first 4 network types and do the appropriate routing. Example server config <interface type='server'> <source address='192.168.0.1' port='5558'/> </interface> Example client config <interface type='client'> <source address='192.168.0.1' port='5558'/> </interface> NB, options 2 -> 4 are also supported by Xen VMs, so it is possible to use these configs to have networking with both Xen & QEMU/KVMs connected to each other. Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 2

[Libvir] Persistence / re-instate of iptables rules
by Daniel P. Berrange 21 Mar '07

21 Mar '07

With the virtual networking capability we have to add various rules to the iptables chains to ensure that outgoing connections are forwarded + NATed to the physical LAN. Now if the user does 'service iptables restart' these rules are lost until you restart the VM. This obviously sucks. We've been exploring the possibility of adapting the Fedora / RHEL iptables scripts to allow user-defined chains which are automatically restored from a 'safe' config file during a restart. This is not present in FC6 / RHEL5 or even F6 yet, nor does it help non-Fedora userrs. We already have ability to add / remove rules from iptables, so I was wondering how hard it would be to list existing rules. From whence we can look at existing rules to see if our virtual network forwarding/NAT rules were missing. The idea being that a simple 'killall -SIGHUP libvirt_qemud' could trigger libvirt to check & re-add the iptables rules if missing. Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 1

Re: [Libvir] [patch 4/5] iptables: maintain rules in memory even when not writing to disk
by Daniel Veillard 21 Mar '07

21 Mar '07

On Wed, Mar 21, 2007 at 12:48:01PM +0000, Mark McLoughlin wrote: > Re-factor things a little for the next patch so that we maintain > the rules in memory even when we're not going to write them to > disk. [...] > if (!(r = (char **)realloc(rules->rules, sizeof(char *) * (rules->nrules+1)))) > return ENOMEM; Seems the rules tab is zeroed, but when you extend it you don't zeroe the new part of the array, but it may not give problem in practice (or a very hard one to track down ;-) Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

2 1

Re: [Libvir] [patch 2/5] iptables: use calloc() instead of malloc()/memset()
by Daniel Veillard 21 Mar '07

21 Mar '07

On Wed, Mar 21, 2007 at 12:47:59PM +0000, Mark McLoughlin wrote: > Replace a few instances of malloc() followed by memset(0) with > calloc() Humpf, that's just the opposite of the other parts of libvirt I wrote. Could you justify ? It's hard to catch it's a calloc or a malloc call, and hence notice if it was initialized or not. The extra memset line makes it clear, plus it will allow me more easilly to plug in libxml2 memory wrapper. I doubt the patch is related to other parts needed for the restart code it's just coding policy and IMHO different from teh rest of libvirt. Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

2 1

[Libvir] [patch 5/5] iptables: reload rules on SIGHUP
by Mark McLoughlin 21 Mar '07

21 Mar '07

As suggested by danpb, make libvirt_qemud handle SIGHUP by re-loading the iptables rules. Signed-off-by: Mark McLoughlin <markmc(a)redhat.com> Index: libvirt/qemud/iptables.c =================================================================== --- libvirt.orig/qemud/iptables.c +++ libvirt/qemud/iptables.c @@ -36,6 +36,8 @@ #include <sys/stat.h> #include <sys/wait.h> +#include "internal.h" + enum { ADD = 0, REMOVE @@ -48,11 +50,18 @@ enum { typedef struct { + char *rule; + char **argv; + int flipflop; +} iptRule; + +typedef struct +{ char *table; char *chain; - int nrules; - char **rules; + int nrules; + iptRule *rules; #ifdef IPTABLES_DIR @@ -73,7 +82,7 @@ struct _iptablesContext #ifdef IPTABLES_DIR static int writeRules(const char *path, - char * const *rules, + const iptRules *rules, int nrules) { char tmp[PATH_MAX]; @@ -96,7 +105,7 @@ writeRules(const char *path, } for (i = 0; i < nrules; i++) { - if (fputs(rules[i], f) == EOF || + if (fputs(rules[i].rule, f) == EOF || fputc('\n', f) == EOF) { fclose(f); if (istmp) @@ -173,19 +182,43 @@ buildPath(const char *table, } #endif /* IPTABLES_DIR */ -static int -iptRulesAppend(iptRules *rules, - const char *rule) +static void +iptRuleFree(iptRule *rule) { - char **r; + if (rule->rule) + free(rule->rule); + rule->rule = NULL; + + if (rule->argv) { + int i = 0; + while (rule->argv[i]) + free(rule->argv[i++]); + free(rule->argv); + rule->argv = NULL; + } +} - if (!(r = (char **)realloc(rules->rules, sizeof(char *) * (rules->nrules+1)))) +static int +iptRulesAppend(iptRules *rules, + char *rule, + char **argv, + int flipflop) +{ + iptRule *r; + + if (!(r = (iptRule *)realloc(rules->rules, sizeof(iptRule) * (rules->nrules+1)))) { + int i = 0; + while (argv[i]) + free(argv[i++]); + free(argv); return ENOMEM; + } rules->rules = r; - if (!(rules->rules[rules->nrules] = strdup(rule))) - return ENOMEM; + rules->rules[rules->nrules].rule = rule; + rules->rules[rules->nrules].argv = argv; + rules->rules[rules->nrules].flipflop = flipflop; rules->nrules++; @@ -211,17 +244,17 @@ iptRulesRemove(iptRules *rules, int i; for (i = 0; i < rules->nrules; i++) - if (!strcmp(rules->rules[i], strdup(rule))) + if (!strcmp(rules->rules[i].rule, strdup(rule))) break; if (i >= rules->nrules) return EINVAL; - free(rules->rules[i]); + iptRuleFree(&rules->rules[i]); memmove(&rules->rules[i], &rules->rules[i+1], - (rules->nrules - i - 1) * sizeof (char *)); + (rules->nrules - i - 1) * sizeof (iptRule)); rules->nrules--; @@ -253,16 +286,14 @@ iptRulesFree(iptRules *rules) } - for (i = 0; i < rules->nrules; i++) { - free(rules->rules[i]); - rules->rules[i] = NULL; - } - - rules->nrules = 0; - if (rules->rules) { + for (i = 0; i < rules->nrules; i++) + iptRuleFree(&rules->rules[i]); + free(rules->rules); rules->rules = NULL; + + rules->nrules = 0; } #ifdef IPTABLES_DIR @@ -480,10 +511,13 @@ iptablesAddRemoveRule(iptRules *rules, i (retval = iptablesAddRemoveChain(rules, action))) goto error; - if (action == ADD) - retval = iptRulesAppend(rules, rule); - else + if (action == ADD) { + retval = iptRulesAppend(rules, rule, argv, flipflop); + rule = NULL; + argv = NULL; + } else { retval = iptRulesRemove(rules, rule); + } error: if (rule) @@ -535,6 +569,45 @@ iptablesContextFree(iptablesContext *ctx free(ctx); } +static void +iptRulesReload(iptRules *rules) +{ + int i; + int retval; + + for (i = 0; i < rules->nrules; i++) { + iptRule *rule = &rules->rules[i]; + char *orig; + + orig = rule->argv[rule->flipflop]; + rule->argv[rule->flipflop] = (char *) "--delete"; + + if ((retval = iptablesSpawn(WITH_ERRORS, rule->argv))) + qemudLog(QEMUD_WARN, "Failed to remove iptables rule '%s' from chain '%s' in table '%s': %s", + rule->rule, rules->chain, rules->table, strerror(errno)); + + rule->argv[rule->flipflop] = orig; + } + + if ((retval = iptablesAddRemoveChain(rules, REMOVE)) || + (retval = iptablesAddRemoveChain(rules, ADD))) + qemudLog(QEMUD_WARN, "Failed to re-create chain '%s' in table '%s': %s", + rules->chain, rules->table, strerror(retval)); + + for (i = 0; i < rules->nrules; i++) + if ((retval = iptablesSpawn(WITH_ERRORS, rules->rules[i].argv))) + qemudLog(QEMUD_WARN, "Failed to add iptables rule '%s' to chain '%s' in table '%s': %s", + rules->rules[i].rule, rules->chain, rules->table, strerror(retval)); +} + +void +iptablesReloadRules(iptablesContext *ctx) +{ + iptRulesReload(ctx->input_filter); + iptRulesReload(ctx->forward_filter); + iptRulesReload(ctx->nat_postrouting); +} + static int iptablesInput(iptablesContext *ctx, const char *iface, Index: libvirt/qemud/iptables.h =================================================================== --- libvirt.orig/qemud/iptables.h +++ libvirt/qemud/iptables.h @@ -27,6 +27,8 @@ typedef struct _iptablesContext iptables iptablesContext *iptablesContextNew (void); void iptablesContextFree (iptablesContext *ctx); +void iptablesReloadRules (iptablesContext *ctx); + int iptablesAddTcpInput (iptablesContext *ctx, const char *iface, int port); Index: libvirt/qemud/qemud.c =================================================================== --- libvirt.orig/qemud/qemud.c +++ libvirt/qemud/qemud.c @@ -88,6 +88,11 @@ static int qemudDispatchSignal(struct qe case SIGHUP: qemudLog(QEMUD_INFO, "Reloading configuration on SIGHUP"); ret = qemudScanConfigs(server); + + if (server->iptables) { + qemudLog(QEMUD_INFO, "Reloading iptables rules"); + iptablesReloadRules(server->iptables); + } break; case SIGINT: --

1 0

[Libvir] [patch 4/5] iptables: maintain rules in memory even when not writing to disk
by Mark McLoughlin 21 Mar '07

21 Mar '07

Re-factor things a little for the next patch so that we maintain the rules in memory even when we're not going to write them to disk. Signed-off-by: Mark McLoughlin <markmc(a)redhat.com> Index: libvirt/qemud/iptables.c =================================================================== --- libvirt.orig/qemud/iptables.c +++ libvirt/qemud/iptables.c @@ -51,14 +51,14 @@ typedef struct char *table; char *chain; + int nrules; + char **rules; + #ifdef IPTABLES_DIR char dir[PATH_MAX]; char path[PATH_MAX]; - int nrules; - char **rules; - #endif /* IPTABLES_DIR */ } iptRules; @@ -171,13 +171,13 @@ buildPath(const char *table, else return 0; } +#endif /* IPTABLES_DIR */ static int iptRulesAppend(iptRules *rules, const char *rule) { char **r; - int err; if (!(r = (char **)realloc(rules->rules, sizeof(char *) * (rules->nrules+1)))) return ENOMEM; @@ -189,24 +189,29 @@ iptRulesAppend(iptRules *rules, rules->nrules++; - if ((err = ensureDir(rules->dir))) - return err; +#ifdef IPTABLES_DIR + { + int err; - if ((err = writeRules(rules->path, rules->rules, rules->nrules))) - return err; + if ((err = ensureDir(rules->dir))) + return err; + + if ((err = writeRules(rules->path, rules->rules, rules->nrules))) + return err; + } +#endif /* IPTABLES_DIR */ return 0; } static int iptRulesRemove(iptRules *rules, - const char *rule) + char *rule) { int i; - int err; for (i = 0; i < rules->nrules; i++) - if (!strcmp(rules->rules[i], rule)) + if (!strcmp(rules->rules[i], strdup(rule))) break; if (i >= rules->nrules) @@ -220,16 +225,23 @@ iptRulesRemove(iptRules *rules, rules->nrules--; - if ((err = writeRules(rules->path, rules->rules, rules->nrules))) - return err; +#ifdef IPTABLES_DIR + { + int err; + + if ((err = writeRules(rules->path, rules->rules, rules->nrules))) + return err; + } +#endif /* IPTABLES_DIR */ return 0; } -#endif /* IPTABLES_DIR */ static void iptRulesFree(iptRules *rules) { + int i; + if (rules->table) { free(rules->table); rules->table = NULL; @@ -240,25 +252,22 @@ iptRulesFree(iptRules *rules) rules->chain = NULL; } -#ifdef IPTABLES_DIR - { - int i; - rules->dir[0] = '\0'; - rules->path[0] = '\0'; - - for (i = 0; i < rules->nrules; i++) { - free(rules->rules[i]); - rules->rules[i] = NULL; - } + for (i = 0; i < rules->nrules; i++) { + free(rules->rules[i]); + rules->rules[i] = NULL; + } - rules->nrules = 0; + rules->nrules = 0; - if (rules->rules) { - free(rules->rules); - rules->rules = NULL; - } + if (rules->rules) { + free(rules->rules); + rules->rules = NULL; } + +#ifdef IPTABLES_DIR + rules->dir[0] = '\0'; + rules->path[0] = '\0'; #endif /* IPTABLES_DIR */ free(rules); @@ -279,15 +288,15 @@ iptRulesNew(const char *table, if (!(rules->chain = strdup(chain))) goto error; + rules->rules = NULL; + rules->nrules = 0; + #ifdef IPTABLES_DIR if (buildDir(table, rules->dir, sizeof(rules->dir))) goto error; if (buildPath(table, chain, rules->path, sizeof(rules->path))) goto error; - - rules->rules = NULL; - rules->nrules = 0; #endif /* IPTABLES_DIR */ return rules; @@ -464,12 +473,10 @@ iptablesAddRemoveRule(iptRules *rules, i (retval = iptablesAddRemoveChain(rules, action))) goto error; -#ifdef IPTABLES_DIR if (action == ADD) retval = iptRulesAppend(rules, rule); else retval = iptRulesRemove(rules, rule); -#endif /* IPTABLES_DIR */ error: if (rule) --

1 0

[Libvir] [patch 3/5] iptables: fix iptablesPhysdevForward()
by Mark McLoughlin 21 Mar '07

21 Mar '07

Remove the target interface parameter from iptablesPhysdevForward(). This rule is intended to allow frames to be forwarded across the bridge from the supplied bridge port. In this context, the --out parameter would match the outgoing bridge port, which will never be network->def->forwardDev. Signed-off-by: Mark McLoughlin <markmc(a)redhat.com> Index: libvirt/qemud/iptables.c =================================================================== --- libvirt.orig/qemud/iptables.c +++ libvirt/qemud/iptables.c @@ -577,41 +577,28 @@ iptablesRemoveUdpInput(iptablesContext * static int iptablesPhysdevForward(iptablesContext *ctx, const char *iface, - const char *target, int action) { - if (target && target[0]) { - return iptablesAddRemoveRule(ctx->forward_filter, - action, - "--match", "physdev", - "--physdev-in", iface, - "--out", target, - "--jump", "ACCEPT", - NULL); - } else { - return iptablesAddRemoveRule(ctx->forward_filter, - action, - "--match", "physdev", - "--physdev-in", iface, - "--jump", "ACCEPT", - NULL); - } + return iptablesAddRemoveRule(ctx->forward_filter, + action, + "--match", "physdev", + "--physdev-in", iface, + "--jump", "ACCEPT", + NULL); } int iptablesAddPhysdevForward(iptablesContext *ctx, - const char *iface, - const char *target) + const char *iface) { - return iptablesPhysdevForward(ctx, iface, target, ADD); + return iptablesPhysdevForward(ctx, iface, ADD); } int iptablesRemovePhysdevForward(iptablesContext *ctx, - const char *iface, - const char *target) + const char *iface) { - return iptablesPhysdevForward(ctx, iface, target, REMOVE); + return iptablesPhysdevForward(ctx, iface, REMOVE); } static int Index: libvirt/qemud/iptables.h =================================================================== --- libvirt.orig/qemud/iptables.h +++ libvirt/qemud/iptables.h @@ -42,11 +42,9 @@ int iptablesRemoveUdpInput int port); int iptablesAddPhysdevForward (iptablesContext *ctx, - const char *iface, - const char *target); + const char *iface); int iptablesRemovePhysdevForward (iptablesContext *ctx, - const char *iface, - const char *target); + const char *iface); int iptablesAddInterfaceForward (iptablesContext *ctx, const char *iface, Index: libvirt/qemud/conf.c =================================================================== --- libvirt.orig/qemud/conf.c +++ libvirt/qemud/conf.c @@ -1128,7 +1128,7 @@ qemudNetworkIfaceConnect(struct qemud_se } if (net->type == QEMUD_NET_NETWORK && network->def->forward) { - if ((err = iptablesAddPhysdevForward(server->iptables, ifname, network->def->forwardDev))) { + if ((err = iptablesAddPhysdevForward(server->iptables, ifname))) { qemudReportError(server, VIR_ERR_INTERNAL_ERROR, "Failed to add iptables rule to allow bridging from '%s' :%s", ifname, strerror(err)); @@ -1152,7 +1152,7 @@ qemudNetworkIfaceConnect(struct qemud_se no_memory: if (net->type == QEMUD_NET_NETWORK && network->def->forward) - iptablesRemovePhysdevForward(server->iptables, ifname, network->def->forwardDev); + iptablesRemovePhysdevForward(server->iptables, ifname); qemudReportError(server, VIR_ERR_NO_MEMORY, "tapfds"); error: if (retval) Index: libvirt/qemud/qemud.c =================================================================== --- libvirt.orig/qemud/qemud.c +++ libvirt/qemud/qemud.c @@ -1042,8 +1042,7 @@ qemudNetworkIfaceDisconnect(struct qemud return; } - if (network->def->forward) - iptablesRemovePhysdevForward(server->iptables, net->dst.network.ifname, network->def->forwardDev); + iptablesRemovePhysdevForward(server->iptables, net->dst.network.ifname); } int qemudShutdownVMDaemon(struct qemud_server *server, struct qemud_vm *vm) { @@ -1242,83 +1241,87 @@ qemudAddIptablesRules(struct qemud_serve } /* allow bridging from the bridge interface itself */ - if ((err = iptablesAddPhysdevForward(server->iptables, network->bridge, network->def->forwardDev))) { + if ((err = iptablesAddPhysdevForward(server->iptables, network->bridge))) { qemudReportError(server, VIR_ERR_INTERNAL_ERROR, "failed to add iptables rule to allow bridging from '%s' : %s\n", network->bridge, strerror(err)); goto err1; } - /* allow forwarding packets from the bridge interface */ - if ((err = iptablesAddInterfaceForward(server->iptables, network->bridge, network->def->forwardDev))) { + /* allow DHCP requests through to dnsmasq */ + if ((err = iptablesAddTcpInput(server->iptables, network->bridge, 67))) { qemudReportError(server, VIR_ERR_INTERNAL_ERROR, - "failed to add iptables rule to allow forwarding from '%s' : %s\n", + "failed to add iptables rule to allow DHCP requests from '%s' : %s\n", network->bridge, strerror(err)); goto err2; } - /* allow forwarding packets to the bridge interface if they are part of an existing connection */ - if ((err = iptablesAddStateForward(server->iptables, network->bridge, network->def->forwardDev))) { + if ((err = iptablesAddUdpInput(server->iptables, network->bridge, 67))) { qemudReportError(server, VIR_ERR_INTERNAL_ERROR, - "failed to add iptables rule to allow forwarding to '%s' : %s\n", + "failed to add iptables rule to allow DHCP requests from '%s' : %s\n", network->bridge, strerror(err)); goto err3; } - /* enable masquerading */ - if ((err = iptablesAddNonBridgedMasq(server->iptables, network->def->forwardDev))) { + /* allow DNS requests through to dnsmasq */ + if ((err = iptablesAddTcpInput(server->iptables, network->bridge, 53))) { qemudReportError(server, VIR_ERR_INTERNAL_ERROR, - "failed to add iptables rule to enable masquerading : %s\n", - strerror(err)); + "failed to add iptables rule to allow DNS requests from '%s' : %s\n", + network->bridge, strerror(err)); goto err4; } - /* allow DHCP requests through to dnsmasq */ - if ((err = iptablesAddTcpInput(server->iptables, network->bridge, 67))) { + if ((err = iptablesAddUdpInput(server->iptables, network->bridge, 53))) { qemudReportError(server, VIR_ERR_INTERNAL_ERROR, - "failed to add iptables rule to allow DHCP requests from '%s' : %s\n", + "failed to add iptables rule to allow DNS requests from '%s' : %s\n", network->bridge, strerror(err)); goto err5; } - if ((err = iptablesAddUdpInput(server->iptables, network->bridge, 67))) { + /* The remaining rules are only needed for IP forwarding */ + if (!network->def->forward) + return 1; + + /* allow forwarding packets from the bridge interface */ + if ((err = iptablesAddInterfaceForward(server->iptables, network->bridge, network->def->forwardDev))) { qemudReportError(server, VIR_ERR_INTERNAL_ERROR, - "failed to add iptables rule to allow DHCP requests from '%s' : %s\n", + "failed to add iptables rule to allow forwarding from '%s' : %s\n", network->bridge, strerror(err)); goto err6; } - /* allow DNS requests through to dnsmasq */ - if ((err = iptablesAddTcpInput(server->iptables, network->bridge, 53))) { + /* allow forwarding packets to the bridge interface if they are part of an existing connection */ + if ((err = iptablesAddStateForward(server->iptables, network->bridge, network->def->forwardDev))) { qemudReportError(server, VIR_ERR_INTERNAL_ERROR, - "failed to add iptables rule to allow DNS requests from '%s' : %s\n", + "failed to add iptables rule to allow forwarding to '%s' : %s\n", network->bridge, strerror(err)); goto err7; } - if ((err = iptablesAddUdpInput(server->iptables, network->bridge, 53))) { + /* enable masquerading */ + if ((err = iptablesAddNonBridgedMasq(server->iptables, network->def->forwardDev))) { qemudReportError(server, VIR_ERR_INTERNAL_ERROR, - "failed to add iptables rule to allow DNS requests from '%s' : %s\n", - network->bridge, strerror(err)); + "failed to add iptables rule to enable masquerading : %s\n", + strerror(err)); goto err8; } return 1; err8: - iptablesRemoveTcpInput(server->iptables, network->bridge, 53); + iptablesRemoveStateForward(server->iptables, network->bridge, network->def->forwardDev); err7: - iptablesRemoveUdpInput(server->iptables, network->bridge, 67); + iptablesRemoveInterfaceForward(server->iptables, network->bridge, network->def->forwardDev); err6: - iptablesRemoveTcpInput(server->iptables, network->bridge, 67); + iptablesRemoveUdpInput(server->iptables, network->bridge, 53); err5: - iptablesRemoveNonBridgedMasq(server->iptables, network->def->forwardDev); + iptablesRemoveTcpInput(server->iptables, network->bridge, 53); err4: - iptablesRemoveStateForward(server->iptables, network->bridge, network->def->forwardDev); + iptablesRemoveUdpInput(server->iptables, network->bridge, 67); err3: - iptablesRemoveInterfaceForward(server->iptables, network->bridge, network->def->forwardDev); + iptablesRemoveTcpInput(server->iptables, network->bridge, 67); err2: - iptablesRemovePhysdevForward(server->iptables, network->bridge, network->def->forwardDev); + iptablesRemovePhysdevForward(server->iptables, network->bridge); err1: return 0; } @@ -1327,15 +1330,15 @@ static void qemudRemoveIptablesRules(struct qemud_server *server, struct qemud_network *network) { if (network->def->forward) { - iptablesRemoveUdpInput(server->iptables, network->bridge, 53); - iptablesRemoveTcpInput(server->iptables, network->bridge, 53); - iptablesRemoveUdpInput(server->iptables, network->bridge, 67); - iptablesRemoveTcpInput(server->iptables, network->bridge, 67); iptablesRemoveNonBridgedMasq(server->iptables, network->def->forwardDev); iptablesRemoveStateForward(server->iptables, network->bridge, network->def->forwardDev); iptablesRemoveInterfaceForward(server->iptables, network->bridge, network->def->forwardDev); - iptablesRemovePhysdevForward(server->iptables, network->bridge, network->def->forwardDev); } + iptablesRemoveUdpInput(server->iptables, network->bridge, 53); + iptablesRemoveTcpInput(server->iptables, network->bridge, 53); + iptablesRemoveUdpInput(server->iptables, network->bridge, 67); + iptablesRemoveTcpInput(server->iptables, network->bridge, 67); + iptablesRemovePhysdevForward(server->iptables, network->bridge); } static int @@ -1412,8 +1415,7 @@ int qemudStartNetworkDaemon(struct qemud goto err_delbr; } - if (network->def->forward && - !qemudAddIptablesRules(server, network)) + if (!qemudAddIptablesRules(server, network)) goto err_delbr1; if (network->def->forward && --

1 0

[Libvir] [patch 2/5] iptables: use calloc() instead of malloc()/memset()
by Mark McLoughlin 21 Mar '07

21 Mar '07

Replace a few instances of malloc() followed by memset(0) with calloc() Signed-off-by: Mark McLoughlin <markmc(a)redhat.com> Index: libvirt/qemud/iptables.c =================================================================== --- libvirt.orig/qemud/iptables.c +++ libvirt/qemud/iptables.c @@ -270,11 +270,9 @@ iptRulesNew(const char *table, { iptRules *rules; - if (!(rules = (iptRules *)malloc(sizeof (iptRules)))) + if (!(rules = (iptRules *)calloc(1, sizeof (iptRules)))) return NULL; - memset (rules, 0, sizeof (iptRules)); - if (!(rules->table = strdup(table))) goto error; @@ -353,11 +351,9 @@ iptablesAddRemoveChain(iptRules *rules, 2 + /* --table foo */ 2; /* --new-chain bar */ - if (!(argv = (char **)malloc(sizeof(char *) * (n+1)))) + if (!(argv = (char **)calloc(n + 1, sizeof(char *)))) goto error; - memset(argv, 0, sizeof(char *) * (n + 1)); - n = 0; if (!(argv[n++] = strdup(IPTABLES_PATH))) @@ -413,14 +409,12 @@ iptablesAddRemoveRule(iptRules *rules, i va_end(args); - if (!(argv = (char **)malloc(sizeof(char *) * (n + 1)))) + if (!(argv = (char **)calloc(n + 1, sizeof(char *)))) goto error; if (!(rule = (char *)malloc(rulelen))) goto error; - memset(argv, 0, sizeof(char *) * (n + 1)); - n = 0; if (!(argv[n++] = strdup(IPTABLES_PATH))) --

1 0

[Libvir] [patch 1/5] iptables: fix invalid free
by Mark McLoughlin 21 Mar '07

21 Mar '07

In iptablesContextNew(), make sure we don't try and free an invalid pointer if one of the iptRulesNew() fails. Signed-off-by: Mark McLoughlin <markmc(a)redhat.com> Index: libvirt/qemud/iptables.c =================================================================== --- libvirt.orig/qemud/iptables.c +++ libvirt/qemud/iptables.c @@ -496,7 +496,7 @@ iptablesContextNew(void) { iptablesContext *ctx; - if (!(ctx = (iptablesContext *) malloc(sizeof (iptablesContext)))) + if (!(ctx = (iptablesContext *) calloc(1, sizeof (iptablesContext)))) return NULL; if (!(ctx->input_filter = iptRulesNew("filter", IPTABLES_PREFIX "INPUT"))) @@ -518,9 +518,12 @@ iptablesContextNew(void) void iptablesContextFree(iptablesContext *ctx) { - iptRulesFree(ctx->input_filter); - iptRulesFree(ctx->forward_filter); - iptRulesFree(ctx->nat_postrouting); + if (ctx->input_filter) + iptRulesFree(ctx->input_filter); + if (ctx->forward_filter) + iptRulesFree(ctx->forward_filter); + if (ctx->nat_postrouting) + iptRulesFree(ctx->nat_postrouting); free(ctx); } --

1 0

[Libvir] [patch 0/5] Misc. fixes to iptables support
by Mark McLoughlin 21 Mar '07

21 Mar '07

Hey, What follows is a few misc patches for qemud's iptables support. The main point is to add reload-on-HUP as suggested by danpb. Comments welcome .. Cheers, Mark. --

1 0

[Libvir] A whole tonne of networking fixes / enhancements
by Daniel P. Berrange 21 Mar '07

21 Mar '07

I've been testing the networking support and found various bugs / missing features that I thought we really need to have in the release - some of them impact the XML so we have to get this right now. - Build up in memory linked-list of network devices & disk devices in same order as they are listed in XML. Currently they are built up in reversed order, which makes the XML not be idempotent, and also means that if you have multiple NICs, what you think is eth0 ends up being eth4 and what you think is eth4 is eth0. This patch fixes the ordering to match XML. - Set the 'vlan' attribute in command line args to QEMU. This ensures that separate network devices are in fact separated. Previously if you had multiple NICs, QEMU connected them all to the same VLAN so any traffic on one NIC got sent to all NICs. Most definitely not what you want in any usual scenario, and created a traffic storm from the resultant network loops ! - Added support for networking of type='bridge'. This gives parity with equivalent Xen networking, eg <interface type='bridge'> <source dev='xenbr0'/> <target dev='vnet3'/> </interface> Will create a tap device called vnet3 and bridge it into xenbr0 - Added support for networking of type='ethernet'. This give parity with equivlent Xen networking, eg <interface type='ethernet'> <script path='/etc/qemu-ifup'/> <target dev='vnet5'/> </interface> Will create a tap device called vnet5 and run 'qemu-ifup' to setup its configuration. Think the various non-bridge Xen networking configs. - Added support for 'client', 'server', 'mcast' networking types. These are QEMU specific types, allowing unprivileged (or privileged) users to create virtual networks without TAP devices. eg two machines, one with <interface type='server'> <source address="127.0.0.1" port="5555"/> </interface> And the other with <interface type='client'> <source address="127.0.0.1" port="5555"/> </interface> Or both using multicast: <interface type='mcast'> <source address="230.0.0.1" port="5558"/> </interface> Both these options allow QEMU instancs on different physical machines to talk to each other. The multicast protocol is also compatible with the UserModeLinux multicast protocol. - Fix the 'type=network' config use the <target dev='vnet3'> element instead of a custom tapifname=vnet3 attribute - this gives consistent way to name tap devices that - most importantly - matches the Xen XML format for specifying vifname, eg <interface type='network'> <source network='default'/> <target dev='vnet2'/> </interface> Will create a tapdevice called vnet2 and connect it to the bridge device associated with the network 'default'. - Removed references to 'vde' - we're not using this explicitly - at some time in the future, we'll perhaps use VDE for doing virtual networking for unprivileged users where bridge devices are not available - Removed references to 'tap' network type - this is basically handled by the 'ethernet' network type to give XML compatability with the same functionality in the Xen backend. - The virtual network configuration currently always adds whole bunch of IPTables rules to the FORWARD/POSTROUTING chain which allow traffic from the virtual network to be masqueraded out through any active physical interface. This may be correct thing todo for the default network, but we also need the ability to create totally isolated networks (no forwarding at all), or directed networks (eg forwarding to an explicit physical device). To deal with this scenario I introduce a new element in the network XML called '<forward>'. If this is not present, then no forwarding rules are added at all. If it is present, but with no attributes then a generic rule allowing forwarding to any interface is added. If it is present and the 'dev' attribute is specific then forwarding is only allowed to that named interface. The default network XML thus now includes <forward/> So that by default we have a virtual network connected to all physical devices. - MAC addreses were not be autogenerated inside libvirt_qemud. If you don't provide a MAC address, QEMU (insanely) uses a hardcoded default. So all NICs end up with an identical MAC. We now always autogenerate a MAC address if not explicitly listed in XML. One final thing to be aware of - the Fedora Core 6 Xen kernel currently has totally fubar TCP checksum offland. So if you try to bridge a Xen guest into the libvirt virtual networking, it'll fail to get a DHCP address from dnsmasq. Even if you fix that by turning off TX checksums in Dom0, you'll get checksum failures for the actual TCP data transmission too. The only solution is to either upgrade the Dom0 kernel to a RHEL-5 vintage, or to also turn off checksumming in the guest. A new FC6 xen kernel is in the works which should hopefully fix this for real. With fixed kernel, I can easily setup virtual networks connecting both Xen PV, Xen FV and QEMU instances together. Anyway, the upshot of all this, is that we can now trivially create really complicated & fun networking layouts across QEMU & Xen, using a mixture of bridging, NAT, isolated LANs, and tunnelled VLANS :-) We really ought to document it a little though Since Mark is off on vacation for a while, I'd appreciate people taking a close look at this / actually giving it a try if you can. It is possible to create a totally isolated network using <network> <name>private</name> <uuid>d237ce44-8efa-452c-b8e6-1ae9cf53aeb1</uuid> <bridge name="virbr0" /> <ip address="192.168.122.1" netmask="255.255.255.0"> <dhcp> <range start="192.168.122.2" end="192.168.122.254" /> </dhcp> </ip> </network> And a QEMU guest with 5 (yes, 5) network cards <domain type='qemu'> <name>QEMUFirewall</name> <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> <memory>219200</memory> <currentMemory>219200</currentMemory> <vcpu>1</vcpu> <os> <type arch='i686' machine='pc'>hvm</type> <boot dev='hd'/> </os> <devices> <emulator>/usr/bin/qemu</emulator> <disk type='block' device='disk'> <source dev='/dev/HostVG/QEMUGuest1'/> <target dev='hda'/> </disk> <interface type='network'> <source network='private'/> <target dev='vnet1'/> </interface> <interface type='bridge'> <source dev='xenbr0'/> <target dev='vnet2'/> </interface> <interface type='ethernet'> <script path='/etc/dan-test-ifup'/> <target dev='vnet3'/> </interface> <interface type='server'> <source address="127.0.0.1" port="5555"/> </interface> <interface type='mcast'> <source address="230.0.0.1" port="5558"/> </interface> <graphics type='vnc' port='-1'/> </devices> </domain> In this XML, only eth1 is connected to the hosts public facing network. The other NICs are all on various private networks. So this QEMU guest is in essence a router/firewall box. eg, you could connected various other guests to the 'private' virtual network, and the only way they could reach the outside world is via this QEMU instance doing routing. Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 2

[Libvir] Turn on compiler buffer checks
by Daniel P. Berrange 21 Mar '07

21 Mar '07

Since testing the latest Fedora RPMs I've hit a number of buffer overflow issues which were caught by the extra compiler checks Fedora turns on. It would be much better if we caught these before release, so the attached patch modifies the configure script so that the following options are always turned on if the compiler supports them: -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -fasynchronous-unwind-tables Since all our production builds use these flags & the patch only enables them if the compiler has support I don't see any issue with having them turned on by default. In addition I altered the existing configure compiler flag checks so that every compiler flag we turned on is explicitly checked to see if supported by the current compiler rather than doing a crude $CC=gcc heuristic which doesn't take account of differing gcc version numbers. If we wanted super-extra paranoia we could also turn on -fstack-protector-all possibly only with --enable-compiler-warnings=maximum since it adds more non-trivial performance overhead Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 1

[Libvir] Fix for buffer overflow in network setup
by Daniel P. Berrange 20 Mar '07

20 Mar '07

There was a buffer overflow in teh code to deal with building command line arguments which was only exposed when the Fedora RPM builds uses the stack protector args to GCC. The attached patch increases the buffer size and uses snprintf() instead of sprintf(). BTW, if anyone is looking for a patch to write - removing all other calls to sprintf() would be a worthy task :-) Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 1

[Libvir] [PATCH] Add error message to virsh setmem/setmaxmem
by Masayuki Sunou 20 Mar '07

20 Mar '07

Hi Virsh setmem/setmaxmem doesn't output an error message when an invalid value is set to "bytes". This patch outputs an error message, when an invalid value is set as "bytes" of virsh setmem/setmaxmem. Signed-off-by: Masayuki Sunou <fj1826dm(a)aa.jp.fujitsu.com> Thanks, Masayuki Sunou. Index: src/virsh.c =================================================================== RCS file: /data/cvs/libvirt/src/virsh.c,v retrieving revision 1.66 diff -u -p -r1.66 virsh.c --- src/virsh.c 19 Mar 2007 14:20:30 -0000 1.66 +++ src/virsh.c 19 Mar 2007 23:29:14 -0000 @@ -1461,6 +1461,7 @@ cmdSetmem(vshControl * ctl, vshCmd * cmd bytes = vshCommandOptInt(cmd, "bytes", &bytes); if (bytes <= 0) { virDomainFree(dom); + vshError(ctl, FALSE, _("Invalid value of \"bytes\"")); return FALSE; } @@ -1504,6 +1505,7 @@ cmdSetmaxmem(vshControl * ctl, vshCmd * bytes = vshCommandOptInt(cmd, "bytes", &bytes); if (bytes <= 0) { virDomainFree(dom); + vshError(ctl, FALSE, _("Invalid value of \"bytes\"")); return FALSE; }

2 1

[Libvir] RPM upgrades interaction with default networking
by Daniel P. Berrange 20 Mar '07

20 Mar '07

I've been thinking about the tricky issue of RPM upgrades and how they interact with the new networking stuff and don't think we've currently got quite the optimal setup. The current approach is that 'make install' puts a default.xml file into /etc/libvirt/qemu/networks and also symlinks that file into the autostart directory. So if someone builds from tar.gz and does make install they'll get a default network config installed & turned on out of the box. This is fine for tar.gz scenario. When we build an RPM we also include the default.xml file in the /etc/libvirt/qemu/networks directory, as well as the autostart symlink. So anyone installing the libvirt RPM gets the default network, whether they're doing an upgrade or fresh install. This is reasonable for the new install, or the first time you upgrade to a new neworking-enabled libvirt. If you subsequently delete the default network, or turn off autostarting, then along comes the next libvirt RPM update and autostart gets turned back on, and/or the default network recreated. This will be considered to be rather unpleasant by many people because no matter what they do, they will always be given a virbr0, a dnsmasq process and a bunch of extra iptables rules whether they want them or not. So I think we need to figure out a way to deploy a default network out of the box, but at the same time ensure that if the turn it off / delete it, upgrades won't re-introduce it. Ideally if someone upgrades from FC6 -> FC7 they will also get the default network created (once only). One way we can address this is to put the default.xml into the docs directory /usr/share/doc/libvirt-X.Y.Z (or perhaps stuff is into a dir like /usr/share/libvirt instead) and then have a RPM %post script which copies it into /etc/libvirt/qemu/networks. If we make the %post script conditional on '$1 == 1' then it will only be run for completely new libvirt installs. This doesn't address the upgrade question though - so someone updating from FC6 -> FC7 won't get the default network. Perhaps we shouldn't worry about them ? Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

4 5

[Libvir] [PATCH] Check calls to printf-like functions (and some fixes)
by Richard W.M. Jones 20 Mar '07

20 Mar '07

* Check calls to printf-like functions (and some fixes) * Fix qemudDebug when debug not enabled * Fix TODO so it doesn't supply a semi-colon (and all calls to this macro) * Add vim/emacs local variables in several places AFAICS this doesn't break the Python API build script, which was the objection to Jim Meyerling's previous patch to do much the same (http://www.redhat.com/archives/libvir-list/2006-March/msg00065.html) Rich.

3 6

[Libvir] more printf-style function checking
by Jim Meyering 19 Mar '07

19 Mar '07

I had the first hunk of the following patch laying around, but when I updated/compiled today, it triggered a warning: virsh.c:3162: warning: format '%d' expects type 'int', but argument 6 has type 's ize_t' I've fixed it by using %lu, which is more likely to be the same width as size_t that %d, and by casting strlen's return val to the new, expected type. 2007-03-19 Jim Meyering <jim(a)meyering.net> Avoid printf-style format mismatch. * src/virsh.c (vshError): Use ATTRIBUTE_FORMAT. (_vshStrdup): Use %lu (not %d) for strlen, and cast the strlen return value to "unsigned long" to match the format. Index: src/virsh.c =================================================================== RCS file: /data/cvs/libvirt/src/virsh.c,v retrieving revision 1.65 diff -u -p -r1.65 virsh.c --- src/virsh.c 19 Mar 2007 09:46:13 -0000 1.65 +++ src/virsh.c 19 Mar 2007 14:03:10 -0000 @@ -179,8 +179,8 @@ typedef struct __vshControl { static vshCmdDef commands[]; -static void vshError(vshControl * ctl, int doexit, const char *format, - ...); +static void vshError(vshControl * ctl, int doexit, const char *format, ...) + ATTRIBUTE_FORMAT(printf, 3, 4); static int vshInit(vshControl * ctl); static int vshDeinit(vshControl * ctl); static void vshUsage(vshControl * ctl, const char *cmdname); @@ -3158,8 +3158,8 @@ _vshStrdup(vshControl * ctl, const char if ((x = strdup(s))) return x; - vshError(ctl, TRUE, _("%s: %d: failed to allocate %d bytes"), - filename, line, strlen(s)); + vshError(ctl, TRUE, _("%s: %d: failed to allocate %lu bytes"), + filename, line, (unsigned long)strlen(s)); return NULL; }

2 1

[Libvir] remove global variables from header files
by Jim Meyering 19 Mar '07

19 Mar '07

Hello, I compiled the latest-from-cvs libvirt and was surprised to see link failures. It was because I used -fno-common: .libs/libvirt_la-hash.o:(.bss+0x0): multiple definition of `virDomainFlags' .libs/libvirt_la-libvirt.o:(.bss+0x0): first defined here libvirt_qemud-buf.o:(.bss+0x0): multiple definition of `qemud_packet_type' libvirt_qemud-qemud.o:(.bss+0x0): first defined here libvirt_qemud-buf.o:(.bss+0x4): multiple definition of `qemud_domain_runstate' libvirt_qemud-qemud.o:(.bss+0x4): first defined here Those happen when more than one compilation unit contains a non-extern declaration of the same global variable. In each of the three cases, the name in question appears only at the point of declaration, so one could conceivably simply remove the name, leaving the anonymous "enum". But then there would be no way to declare a variable to be of that type, so I chose to reuse the name, making it the name of the enum. If name space pollution is an issue, and applications that use those headers won't need those types, then it'd be better to remove the names altogether. Here's a patch: 2007-03-19 Jim Meyering <jim(a)meyering.net> Remove global variables from header files. * qemud/protocol.h (qemud_domain_runstate): Declare a named enum and no variable, rather than a global variable of type "anonymous enum". (qemud_packet_type): Likewise. * src/internal.h (virDomainFlags): Likewise. Index: qemud/protocol.h =================================================================== RCS file: /data/cvs/libvirt/qemud/protocol.h,v retrieving revision 1.5 diff -u -p -r1.5 protocol.h --- qemud/protocol.h 15 Mar 2007 17:24:57 -0000 1.5 +++ qemud/protocol.h 19 Mar 2007 13:36:55 -0000 @@ -29,7 +29,7 @@ #include <net/if.h> /* for IF_NAMESIZE */ /* List of different packet types which can be sent */ -enum { +enum qemud_packet_type { QEMUD_PKT_FAILURE = 0, QEMUD_PKT_GET_VERSION, QEMUD_PKT_GET_NODEINFO, @@ -71,7 +71,7 @@ enum { QEMUD_PKT_GET_CAPABILITIES, QEMUD_PKT_MAX, -} qemud_packet_type; +}; #define QEMUD_PROTOCOL_VERSION_MAJOR 1 @@ -86,11 +86,11 @@ enum { #define QEMUD_MAX_ERROR_LEN 1024 /* Possible guest VM states */ -enum { +enum qemud_domain_runstate { QEMUD_STATE_RUNNING = 1, QEMUD_STATE_PAUSED, QEMUD_STATE_STOPPED, -} qemud_domain_runstate; +}; /* Each packets has at least a fixed size header. * Index: src/internal.h =================================================================== RCS file: /data/cvs/libvirt/src/internal.h,v retrieving revision 1.35 diff -u -p -r1.35 internal.h --- src/internal.h 16 Mar 2007 15:03:21 -0000 1.35 +++ src/internal.h 19 Mar 2007 13:36:55 -0000 @@ -155,10 +155,10 @@ struct _virConnect { * a set of special flag values associated to the domain */ -enum { +enum virDomainFlags { DOMAIN_IS_SHUTDOWN = (1 << 0), /* the domain is being shutdown */ DOMAIN_IS_DEFINED = (1 << 1) /* the domain is defined not running */ -} virDomainFlags; +}; /** * _virDomain:

2 1

[Libvir] [PATCH] Fix driver counting in virConnectOpen
by Atsushi SAKAI 19 Mar '07

19 Mar '07

Hi, I think virConnectOpen driver counting check is wrong. If we does not run libvirt_qemud, virsh does not run on root privilege. This restriction forces Xen user to run verbose libvirt_qemud. Signed-off-by: Atsushi SAKAI <sakaia(a)jp.fujitsu.com> Thanks Atsushi SAKAI diff -urpN libvirt-0.2.1/src/libvirt.c libvirt-0.2.1.check/src/libvirt.c --- libvirt-0.2.1/src/libvirt.c 2007-03-16 01:45:36.000000000 +0900 +++ libvirt-0.2.1.check/src/libvirt.c 2007-03-19 18:37:22.000000000 +0900 @@ -322,7 +322,7 @@ virConnectOpen(const char *name) } } - if (ret->nb_drivers == 0 || ret->nb_network_drivers == 0) { + if (ret->nb_drivers == 0 && ret->nb_network_drivers == 0) { /* we failed to find an adequate driver */ virLibConnError(NULL, VIR_ERR_NO_SUPPORT, name); goto failed; @@ -389,7 +389,7 @@ virConnectOpenReadOnly(const char *name) ret->networkDrivers[ret->nb_network_drivers++] = virNetworkDriverTab[i]; } } - if (ret->nb_drivers == 0) { + if (ret->nb_drivers == 0 && ret->nb_network_drivers == 0) { if (name == NULL) virLibConnError(NULL, VIR_ERR_NO_CONNECT, _("Xen Daemon or Xen Store"));

2 1

[Libvir] [PATCH] Guard a negative value of "virsh setmem" and "virsh setmexmem"
by Masayuki Sunou 19 Mar '07

19 Mar '07

Hi "virsh setmem" and "virsh setmexmem" have the problem of setting a very big value in the domain when -1 is set in the domain. As a result, I detected the problem of doing abnormal operation of Xen in 64bit machine. (virsh setmem) Therefore, I contribute the patch that corrects the argument of the function to guard a negative value. This treatment is based on setMemoryTarget(a)XendDomainInfo.py. Signed-off-by: Masayuki Sunou <fj1826dm(a)aa.jp.fujitsu.com> Thanks, Masayuki Sunou. ------------------------------------------------------------------------------- Index: include/libvirt/libvirt.h =================================================================== RCS file: /data/cvs/libvirt/include/libvirt/libvirt.h,v retrieving revision 1.41 diff -u -p -r1.41 libvirt.h --- include/libvirt/libvirt.h 15 Mar 2007 17:24:57 -0000 1.41 +++ include/libvirt/libvirt.h 16 Mar 2007 01:37:25 -0000 @@ -314,9 +314,9 @@ int virDomainGetUUIDString (virDomainP char * virDomainGetOSType (virDomainPtr domain); unsigned long virDomainGetMaxMemory (virDomainPtr domain); int virDomainSetMaxMemory (virDomainPtr domain, - unsigned long memory); + int memory); int virDomainSetMemory (virDomainPtr domain, - unsigned long memory); + int memory); int virDomainGetMaxVcpus (virDomainPtr domain); /* Index: include/libvirt/libvirt.h.in =================================================================== RCS file: /data/cvs/libvirt/include/libvirt/libvirt.h.in,v retrieving revision 1.26 diff -u -p -r1.26 libvirt.h.in --- include/libvirt/libvirt.h.in 15 Mar 2007 17:24:57 -0000 1.26 +++ include/libvirt/libvirt.h.in 16 Mar 2007 01:37:26 -0000 @@ -314,9 +314,9 @@ int virDomainGetUUIDString (virDomainP char * virDomainGetOSType (virDomainPtr domain); unsigned long virDomainGetMaxMemory (virDomainPtr domain); int virDomainSetMaxMemory (virDomainPtr domain, - unsigned long memory); + int memory); int virDomainSetMemory (virDomainPtr domain, - unsigned long memory); + int memory); int virDomainGetMaxVcpus (virDomainPtr domain); /* Index: src/libvirt.c =================================================================== RCS file: /data/cvs/libvirt/src/libvirt.c,v retrieving revision 1.63 diff -u -p -r1.63 libvirt.c --- src/libvirt.c 15 Mar 2007 17:24:57 -0000 1.63 +++ src/libvirt.c 16 Mar 2007 01:37:31 -0000 @@ -1499,7 +1499,7 @@ virDomainGetMaxMemory(virDomainPtr domai * Returns 0 in case of success and -1 in case of failure. */ int -virDomainSetMaxMemory(virDomainPtr domain, unsigned long memory) +virDomainSetMaxMemory(virDomainPtr domain, int memory) { int ret = -1 , i; virConnectPtr conn; @@ -1553,7 +1553,7 @@ virDomainSetMaxMemory(virDomainPtr domai * Returns 0 in case of success and -1 in case of failure. */ int -virDomainSetMemory(virDomainPtr domain, unsigned long memory) +virDomainSetMemory(virDomainPtr domain, int memory) { int ret = -1 , i; virConnectPtr conn; -------------------------------------------------------------------------------

2 3

[Libvir] [PATCH]Reprt error for a existing file
by Kazuki Mizushima 19 Mar '07

19 Mar '07

Hi, I make a patch which reports error for a existing file to prevent overwriting before the file. # ./virsh dump 1 a.dump error: file a.dump exists already # echo $? 1 # ./virsh save 1 a.save error: file a.save exists already # echo $? 1 As you know, we need to add this message item to libvirt/po. Signed-off-by: Kazuki Mizushima <mizushima.kazuk(a)jp.fujitsu.com> Thanks, Kazuki Mizushima Index: src/virsh.c =================================================================== RCS file: /data/cvs/libvirt/src/virsh.c,v retrieving revision 1.58 diff -u -p -r1.58 virsh.c --- src/virsh.c 2 Mar 2007 14:22:33 -0000 1.58 +++ src/virsh.c 5 Mar 2007 06:49:28 -0000 @@ -25,6 +25,7 @@ #include <getopt.h> #include <sys/types.h> #include <sys/time.h> +#include <sys/stat.h> #include <ctype.h> #include <fcntl.h> #include <locale.h> @@ -860,6 +861,7 @@ cmdSave(vshControl * ctl, vshCmd * cmd) virDomainPtr dom; char *name; char *to; + struct stat st; int ret = TRUE; if (!vshConnectionUsability(ctl, ctl->conn, TRUE)) @@ -871,6 +873,11 @@ cmdSave(vshControl * ctl, vshCmd * cmd) if (!(dom = vshCommandOptDomain(ctl, cmd, "domain", &name))) return FALSE; + if (stat(to, &st) == 0){ + vshError(ctl, FALSE, _("file %s exists already"), to); + return FALSE; + } + if (virDomainSave(dom, to) == 0) { vshPrint(ctl, _("Domain %s saved to %s\n"), name, to); } else { @@ -942,6 +949,7 @@ cmdDump(vshControl * ctl, vshCmd * cmd) virDomainPtr dom; char *name; char *to; + struct stat st; int ret = TRUE; if (!vshConnectionUsability(ctl, ctl->conn, TRUE)) @@ -953,6 +961,11 @@ cmdDump(vshControl * ctl, vshCmd * cmd) if (!(dom = vshCommandOptDomain(ctl, cmd, "domain", &name))) return FALSE; + if (stat(to, &st) == 0){ + vshError(ctl, FALSE, _("file %s exists already"), to); + return FALSE; + } + if (virDomainCoreDump(dom, to, 0) == 0) { vshPrint(ctl, _("Domain %s dumpd to %s\n"), name, to); } else {

3 8

[Libvir] Release of libvirt-0.2.1
by Daniel Veillard 16 Mar '07

16 Mar '07

A lot of work had accumulated in CVS, and it was really time for a new release, it's available from: ftp://libvirt.org/libvirt * Various internal cleanups (Richard Jones,Daniel Berrange,Mark McLoughlin) * Bug fixes: - libvirt_qemud daemon path (Daniel Berrange) - libvirt config directory (Daniel Berrange and Mark McLoughlin) - memory leak in qemud (Mark) - various fixes on network support (Mark) - avoid Xen domain zombies on device hotplug errors (Daniel Berrange) - various fixes on qemud (Mark) - argsparsing (Richard Jones) - virsh -t argument (Saori Fukuta) - avoid virsh crash on TAB key (Daniel Berrange) - detect xend operation failures (Kazuki Mizushima) - don't listen on null socket (Rich Jones) - read-only socket cleanup (Rich Jones) - use of vnc port 5900 (Nobuhiro Itou) - assorted networking fixes (Daniel Berrange) - shutoff and shutdown mismatches (Kazuki Mizushima) - unlimited memory handling (Atsushi SAKAI) - python binding fixes (Tatsuro Enokura) * Build and portability fixes: - IA64 fixes (Atsushi SAKAI) - dependancies and build (Daniel Berrange) - fix xend port detection (Daniel Berrange) - icompile time warnings (Mark) - avoid const related compiler warnings (Daniel Berrange) - automated builds (Daniel Berrange) - pointer/int mismatch (Richard Jones) - configure time selection of drivers - libvirt spec hacking (Daniel Berrange) * Add support for network autostart and init scripts (Mark McLoughlin) * New API virConnectGetCapabilities() to detect the virtualization capabilities of a host (Richard Jones) * Minor improvements: - qemud signal handling (Mark) - don't shutdown or reboot domain0 (Kazuki Mizushima) - QEmu version autodetection (Daniel Berrange) - network UUIDs (Mark) - speed up UUID domain lookups (Tatsuro Enokura and Daniel Berrange) - support for paused QEmu CPU (Daniel Berrange) - keymap VNC attribute support (Takahashi Tomohiro and Daniel Berrange) - maximum number of virtual CPU (Masayuki Sunou) - virtsh --readonly option (Rich Jones) - python bindings for new functions (Daniel Berrange) * Documentation updates especially on the XML formats Thanks to everybody who contributed to this release ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

1 0

[Libvir] [PATCH] Check calls to printf-like functions (and some fixes) (second version)
by Richard W.M. Jones 16 Mar '07

16 Mar '07

-- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

3 4

[Libvir] [PATCH] TODO macro shouldn't contain a semicolon
by Richard W.M. Jones 16 Mar '07

16 Mar '07

I don't think it's a good idea for macros which look like statements to behave differently from actual statements. This patch fixes the TODO macro in this way. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

1 0

[Libvir] libvirt.py has the two functions that names are the same.
by Tatsuro Enokura 16 Mar '07

16 Mar '07

Hi, When I used the lookupByName() function of libvirt.py, it failed with the following error messages. ------ Traceback (most recent call last): File "./virt-install.mod", line 569, in <module> main() File "./virt-install.mod", line 499, in main guest, hvm, conn) File "./virt-install.mod", line 187, in get_disks disk, size) File "./virt-install.mod", line 186, in <lambda> map(lambda d, s: get_disk(d, s, sparse, guest, hvm, conn), File "./virt-install.mod", line 131, in get_disk vm = conn.lookupByName(name) File "/usr/lib/python2.5/site-packages/libvirt.py", line 483, in lookupByName if ret is None:raise libvirtError('virNetworkLookupByName() failed', conn=self) libvirt.libvirtError: virNetworkLookupByName() failed ------ The lookupByName() function is the same name for domain and for network in libvirt.py. The lookupByUUIDstring() function is similar. I think that generator of libvirt.py's function is incorrect. Thanks, Tatsuro Enokura --- cat /usr/lib/python2.5/site-packages/libvirt.py .. snip .. def lookupByName(self, name): """Try to lookup a domain on the given hypervisor based on its name. """ ret = libvirtmod.virDomainLookupByName(self._o, name) if ret is None:raise libvirtError('virDomainLookupByName() failed', conn=self) __tmp = virDomain(_obj=ret) __tmp.ref = self return __tmp def lookupByName(self, name): """Try to lookup a network on the given hypervisor based on its name. """ ret = libvirtmod.virNetworkLookupByName(self._o, name) if ret is None:raise libvirtError('virNetworkLookupByName() failed', conn=self) __tmp = virNetwork(_obj=ret) __tmp.ref = self return __tmp def lookupByUUIDString(self, uuidstr): """Try to lookup a network on the given hypervisor based on its UUID. """ ret = libvirtmod.virNetworkLookupByUUIDString(self._o, uuidstr) if ret is None:raise libvirtError('virNetworkLookupByUUIDString() failed', conn=self) __tmp = virNetwork(_obj=ret) __tmp.ref = self return __tmp def lookupByUUIDString(self, uuidstr): """Try to lookup a domain on the given hypervisor based on its UUID. """ ret = libvirtmod.virDomainLookupByUUIDString(self._o, uuidstr) if ret is None:raise libvirtError('virDomainLookupByUUIDString() failed', conn=self) __tmp = virDomain(_obj=ret) __tmp.ref = self return __tmp .. snip .. --

2 3

[Libvir] [PATCH] Fix dom0 maxmem display for memmax not set case
by Atsushi SAKAI 16 Mar '07

16 Mar '07

Hi, This patch intends to fix dom0 maxmem display. If we do NOT set maximum memory, max_pages (in Xen) are set maximum value(0xFFFFFFFF). This display confuses user. For x86 cases, following data are shown on "virsh dominfo 0" (please case 4kb page size This case max_pages x 4 is output). Max memory: 4294967292 kB This patch fix as follows Max memory: no limit (This comment is taken from xentop :-)) This problem is already cared on xentop (Xen performance tool). Signed-off-by: Atsushi SAKAI <sakaia(a)jp.fujitsu.com> Thanks Atsushi SAKAI diff -urpN libvirt.orig/src/virsh.c libvirt/src/virsh.c --- libvirt.orig/src/virsh.c 2007-03-09 22:44:24.000000000 +0900 +++ libvirt/src/virsh.c 2007-03-15 20:13:04.000000000 +0900 @@ -1186,8 +1186,13 @@ cmdDominfo(vshControl * ctl, vshCmd * cm vshPrint(ctl, "%-15s %.1lfs\n", _("CPU time:"), cpuUsed); } - vshPrint(ctl, "%-15s %lu kB\n", _("Max memory:"), + if (info.maxMem != UINT_MAX) + vshPrint(ctl, "%-15s %lu kB\n", _("Max memory:"), info.maxMem); + else + vshPrint(ctl, "%-15s %-15s\n", _("Max memory:"), + _("no limit")); + vshPrint(ctl, "%-15s %lu kB\n", _("Used memory:"), info.memory); diff -urpN libvirt.orig/src/xen_internal.c libvirt/src/xen_internal.c --- libvirt.orig/src/xen_internal.c 2007-03-15 16:43:16.000000000 +0900 +++ libvirt/src/xen_internal.c 2007-03-15 19:38:17.000000000 +0900 @@ -1598,7 +1598,9 @@ xenHypervisorGetDomInfo(virConnectPtr co */ info->cpuTime = XEN_GETDOMAININFO_CPUTIME(dominfo); info->memory = XEN_GETDOMAININFO_TOT_PAGES(dominfo) * kb_per_pages; - info->maxMem = XEN_GETDOMAININFO_MAX_PAGES(dominfo) * kb_per_pages; + info->maxMem = XEN_GETDOMAININFO_MAX_PAGES(dominfo); + if(info->maxMem != UINT_MAX) + info->maxMem *= kb_per_pages; info->nrVirtCpu = XEN_GETDOMAININFO_CPUCOUNT(dominfo); return (0); }

2 3

[Libvir] [PATCH] Make libvirt build when xen-devel is not installed
by Hugh Brock 15 Mar '07

15 Mar '07

After the Capabilities patch went in, we discovered that although we could supposedly build libvirt without xen-devel installed, in fact we needed to be more aggressive with ifdefs (and conditionally turn off compilation of some tests that only test xen features). This patch makes it possible to compile libvirt with neither qemu nor xen-devel installed. Signed-off-by: Hugh Brock <hbrock(a)redhat.com> -- Red Hat Virtualization Group http://redhat.com/virtualization Hugh Brock | virt-manager http://virt-manager.org hbrock(a)redhat.com | virtualization library http://libvirt.org

2 1

[Libvir] virConnectGetCapabilities patch, 2007-03-15 (version 2)
by Richard W.M. Jones 15 Mar '07

15 Mar '07

This is the latest version of the capabilities patch, which should address all concerns which have been raised since the last version. Also attached, example XML produced by different backends. Note as before this has not been tested in the Xen case, because I don't have access to a working Xen machine (laptop still broken, desktop still lacking working SATA drivers, other desktop still lacking wired network...). Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759) <capabilities> <host> <cpu> <arch>x86_64</arch> </cpu> </host> <guest> <os_type>hvm</os_type> <arch name="x86_64"> <wordsize>64</wordsize> <emulator>/usr/bin/qemu-system-x86_64</emulator> <domain type="qemu"/> <machine>pc</machine> <machine>isapc</machine> <domain type="kqemu"/> <domain type="kvm"> <emulator>/usr/bin/qemu-kvm</emulator> </domain> </arch> </guest> <guest> <os_type>hvm</os_type> <arch name="i686"> <wordsize>32</wordsize> <emulator>/usr/bin/qemu</emulator> <domain type="qemu"/> <machine>pc</machine> <machine>isapc</machine> </arch> </guest> <guest> <os_type>hvm</os_type> <arch name="mips"> <wordsize>32</wordsize> <emulator>/usr/bin/qemu-system-mips</emulator> <domain type="qemu"/> <machine>mips</machine> </arch> </guest> <guest> <os_type>hvm</os_type> <arch name="mipsel"> <wordsize>32</wordsize> <emulator>/usr/bin/qemu-system-mipsel</emulator> <domain type="qemu"/> <machine>mips</machine> </arch> </guest> <guest> <os_type>hvm</os_type> <arch name="sparc"> <wordsize>32</wordsize> <emulator>/usr/bin/qemu-system-sparc</emulator> <domain type="qemu"/> <machine>sun4m</machine> </arch> </guest> <guest> <os_type>hvm</os_type> <arch name="ppc"> <wordsize>32</wordsize> <emulator>/usr/bin/qemu-system-ppc</emulator> <domain type="qemu"/> <machine>g3bw</machine> <machine>mac99</machine> <machine>prep</machine> </arch> </guest> </capabilities> <capabilities> <host> <cpu> <arch>x86_64</arch> </cpu> </host> <guest> <os_type>hvm</os_type> <arch name="x86_64"> <wordsize>64</wordsize> <emulator>/usr/bin/qemu-system-x86_64</emulator> <domain type="qemu"/> <machine>pc</machine> <machine>isapc</machine> </arch> </guest> <guest> <os_type>hvm</os_type> <arch name="i686"> <wordsize>32</wordsize> <emulator>/usr/bin/qemu</emulator> <domain type="qemu"/> <machine>pc</machine> <machine>isapc</machine> </arch> </guest> <guest> <os_type>hvm</os_type> <arch name="mips"> <wordsize>32</wordsize> <emulator>/usr/bin/qemu-system-mips</emulator> <domain type="qemu"/> <machine>mips</machine> </arch> </guest> <guest> <os_type>hvm</os_type> <arch name="mipsel"> <wordsize>32</wordsize> <emulator>/usr/bin/qemu-system-mipsel</emulator> <domain type="qemu"/> <machine>mips</machine> </arch> </guest> <guest> <os_type>hvm</os_type> <arch name="sparc"> <wordsize>32</wordsize> <emulator>/usr/bin/qemu-system-sparc</emulator> <domain type="qemu"/> <machine>sun4m</machine> </arch> </guest> <guest> <os_type>hvm</os_type> <arch name="ppc"> <wordsize>32</wordsize> <emulator>/usr/bin/qemu-system-ppc</emulator> <domain type="qemu"/> <machine>g3bw</machine> <machine>mac99</machine> <machine>prep</machine> </arch> </guest> </capabilities> <capabilities> <host> <cpu> <arch>i686</arch> <features> <pae/> <nonpae/> </features> </cpu> </host> <guest> <os_type>linux</os_type> <arch name="i686"> <wordsize>32</wordsize> <domain type="test"/> </arch> <features> <pae/> <nonpae/> </features> </guest> </capabilities>

1 0

[Libvir] Proposed XML format for capabilities, with examples [long]
by Richard W.M. Jones 15 Mar '07

15 Mar '07

Lots of people had various things to say about the first capabilities patches (see thread starting here: https://www.redhat.com/archives/libvir-list/2007-March/msg00153.html) So I thought I'd try to pull together ideas into a single thread, and post some information about what this is trying to achieve and some example proposed XML. Motivation ---------- At the moment there is a considerable amount of conditional code in libvirt clients. For example the following code from virt-manager (src/virtManager/create.py): if self.connection.get_type() == "QEMU": <------- 1 self.window.get_widget("virt-method-pv").set_sensitive(False) self.window.get_widget("virt-method-fv").set_active(True) self.window.get_widget("virt-method-fv-unsupported").hide() self.window.get_widget("virt-method-fv-disabled").hide() else: self.window.get_widget("virt-method-pv").set_sensitive(True) self.window.get_widget("virt-method-pv").set_active(True) if virtinst.util.is_hvm_capable(): <--------- 2 self.window.get_widget("virt-method-fv").set_sensitive(True) self.window.get_widget("virt-method-fv-unsupported").hide() self.window.get_widget("virt-method-fv-disabled").hide() This hopefully demonstrates two points which I'd like to fix: Firstly having code which requires knowledge of what a driver is capable of (line 1 above) is not scalable as we add more and more types of virtualisation (OpenVZ, VMWare, ...). Secondly the virtinst.util module does some probing to find out what the local hardware is capable of (line 2 above), and that won't work over remote connections. Thirdly, although you can only really connect to one driver at a time (except in the Xen case, but that's just weird), the <domain> description required by virDomainCreateLinux is to some extent driver-specific. So you need additional logic when creating domains, and for some of those (eg. qemu/kqemu/kvm) it's non-trivial and depends on information that you "just know" about the driver. The proposed new API ("virConnectGetCapabilities") would return an XML description of the capabilities of the driver / hypervisor. In the remote case, probing would be done on the remote machine. In either case the idea would be to remove conditional code from virt-manager, remove local hardware probing from virtinst, and provide some description of what optional features the <domain> XML supports. In the next two sections I'll analyse the problem areas in the current virtinst and virt-manager. You may want to skip the next two sections and go straight to the example XML. Analysis of virtinst -------------------- The main issue is with virtinst/util.py which contains the following functions which do local probing: (1) is_pae_capable: host supports PAE? Uses Linux-specific /proc/cpuinfo (2) is_hvm_capable: host supports HVM & enabled in Xen? Uses Xen-specific /sys/hypervisor/properties/capabilities (3) is_kqemu_capable: [Linux] kernel supports kqemu? Uses Linux-specific /dev/kqemu (4) is_kvm_capable: [Linux] kernel supports kvm? Uses Linux-specific /dev/kvm In virtinst/FullVirtGuest.py: (5) "emulator" and "loader" must be specified for Xen/QEMU and Xen guests respectively. They have architecture- and distro-specific paths which refer to files on the remote machine. In virtinst/ParaVirtGuest.py: (6) Uses "xm console" to connect to the console in the Xen case (but then this sort of paravirtualisation implies Xen). In virtinst/DistroManager.py: (7) We download the kernel and boot.iso files, and download and modify the initrd file. [Comment: I'm not sure that capabilities can solve this, but it does need to be fixed properly for the remote case to work]. Analysis of virt-manager ------------------------ In src/virtManager/create.py: (8) Tries to detect if VT-x/AMD-V is present in the hardware but disabled in the BIOS by doing some Xen-specific heuristics. (9) Paravirt and fullvirt dialogs are enabled based on the type of the connection (eg. if self.connection.get_type() == "QEMU" it disables paravirt). (10) CPU architecture combo box is enabled only for type == "QEMU". (11) Similarly, the "accelerate" checkbox is enabled only for type == "QEMU". [Comment: Dan tells me that this requirement comes about because kqemu is sometimes unreliable, so users need a way to disable it]. (12) Local media are required for FV installs. Also we use HAL to detect media inserted and removed. [Comment: Can be solved separately by abstracting storage]. In the *.glade files: (13) The list of CPU architectures for qemu is hard-coded in the interface description file. Other areas which are beyond the role of capabilities: * Remote console * Serial console * Saving images Proposed XML format ------------------- My thoughts are that capabilities need to return the following information about the underlying driver/hypervisor: * Host CPU flags (1,8) * List of guest architectures supported. For each of these: - Model of virtualised CPU (10,13) example: x86_64 - Name of the virtualised machine (if applic.) example: pc - Virtualised CPU features: PAE, ... - Fullvirt flag: can we run an unmodified OS as a guest? (2,9) or Paravirt: what sort of paravirt API does a guest need (eg. xen, pvops, VMI, ...)? - The <domain type='?'> for this guest example: kqemu - The <domain><os><type machine='?'> for this guest (if applic.) example: pc - Suggested emulator and loader paths (5) - Driver-specific flags which libvirt clients would not be required to understand, but could be used to enhance libvirt clients. examples: uses kqemu, uses kvm (3,4,11) (Notes: (a) I have flattened qemu's nested arch/machine list, because I there is not a natural hierarchy. (b) The guest architectures list is a Cartesian product, although at the moment the worst case (qemu) would only have about 14 entries. An alternate way to do this is discussed at the end. (c) The host CPU model is already provided by virNodeGetInfo). Example: Xen ------------ For Xen the primary source for capabilities are the files /sys/hypervisor/properties/capabilities and /proc/cpuinfo. A Xen driver might present the following description of its capabilities: <capabilities> <host> <cpu_flags> <cpu_flag> vmx </cpu_flag> <cpu_flag> pae </cpu_flag>  </cpu_flags> </host> <guest_architectures> <guest_architecture> <model> x86_64 </model> <paravirt> xen </paravirt> <domain_type> xen </domain_type> <emulator> /usr/lib/xen/bin/qemu-dm </emulator> </guest_architecture> <guest_architecture> <model> i686 </model> <pae/> <paravirt> xen </paravirt> <domain_type> xen </domain_type> <emulator> /usr/lib/xen/bin/qemu-dm </emulator> </guest_architecture> <guest_architecture> <model> i686 </model> <fullvirt/> <domain_type> xen </domain_type> <loader> /usr/lib/xen/boot/hvmloader </loader> <emulator> /usr/lib/xen/bin/qemu-dm </emulator> </guest_architecture> <guest_architecture> <model> i686 </model> <pae/> <fullvirt/> <domain_type> xen </domain_type> <loader> /usr/lib/xen/boot/hvmloader </loader> <emulator> /usr/lib/xen/bin/qemu-dm </emulator> </guest_architecture> <guest_architecture> <model> x86_64 </model> <fullvirt/> <domain_type> xen </domain_type> <loader> /usr/lib/xen/boot/hvmloader </loader> <emulator> /usr/lib/xen/bin/qemu-dm </emulator> </guest_architecture> </guest_architectures> </capabilities> Example: qemu + kqemu + kvm --------------------------- Qemu has by far the longest list of supported guest architectures. Out of the box it supports 10 distinct machine types and then you can add 4 extra machine types if the kernel can do kqemu and kvm, making 14 in all. Below I have abbreviated this list for clarity. <capabilities> <host> <cpu_flags> <cpu_flag> vmx </cpu_flag> <cpu_flag> pae </cpu_flag>  </cpu_flags> </host> <guest_architectures> <guest_architecture> <model> sparc </model> <machine> sun4m </machine> <fullvirt/> <domain_type> qemu </domain_type> <machine_type> sun4m </machine_type> <emulator> /usr/bin/qemu-system-sparc </emulator> </guest_architecture> <guest_architecture> <model> i686 </model> <machine> pc </machine> <fullvirt/> <domain_type> qemu </domain_type> <machine_type> pc </machine_type> <emulator> /usr/bin/qemu </emulator> </guest_architecture> <guest_architecture> <model> x86_64 </model> <machine> pc </machine> <fullvirt/> <domain_type> kqemu </domain_type> <machine_type> pc </machine_type> <emulator> /usr/bin/qemu </emulator> <qemu_uses_kqemu /> </guest_architecture> <guest_architecture> <model> x86_64 </model> <machine> pc </machine> <fullvirt/> <domain_type> kvm </domain_type> <machine_type> pc </machine_type> <emulator> /usr/bin/qemu-kvm </emulator> <qemu_uses_kvm /> </guest_architecture> </guest_architecture> </capabilities> Guest architectures: Cartesian product or UI builder? ----------------------------------------------------- Currently the list of guest architectures is a flat list, worst case 5 entries long for Xen and 14 entries long for qemu. Presenting this in user interfaces could be challenging. One suggestion is that the user interface looks like: [*] Show only fullvirt [*] Show only PC architectures [ ] Show 32 bit architectures [*] Show 64 bit architectures | Shorter list of architectures which match | the criteria checked above. | ... | Another is that we change the XML description so that it matches the UI. For instance: <guest_architecture> <models> <model> sparc </model> <model> ppc </model> ... Or: <pae> <can_enable/> <can_disable/> </pae> This is relatively easy to do with qemu, but the format of Xen's /sys/hypervisor/properties/capabilities makes it quite hard. i18n ---- Some proposed features may make translation challenging. For example qemu supports a whole list of machine types ("pc", "sun4m", etc.) and it would be nice for libvirt clients to be able to provide some sort of description for the user. It would not be wise to carry this description in the XML because it would not be possible to localise it. To avoid all libvirt clients duplicating and maintaining lists of machine types and descriptions, it may be worth adding a call to the API along the lines of: virConnectGetMachineDescription (const char *machine_name, const char *lang); (where lang == NULL would mean to use the current language). [EOF] -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

2 5

[Libvir] virConnectGetCapabilities patch, 2007-03-15
by Richard W.M. Jones 15 Mar '07

15 Mar '07

The latest version is attached. This should satisfy all concerns which have been raised with the previous versions. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

1 0

[Libvir] [PATCH]fix the judgment of the domain state between hypervisor and xend
by Kazuki Mizushima 15 Mar '07

15 Mar '07

Hi, According to the xm & virsh man page, I make a patch which fixes the judgment of the domain state between xenHypervisorDriver and xenDaemonDriver. Signed-off-by: Kazuki Mizushima <mizushima.kazuk(a)jp.fujitsu.com> Thanks, Kazuki Mizushima Index: xend_internal.c =================================================================== RCS file: /data/cvs/libvirt/src/xend_internal.c,v retrieving revision 1.101 diff -u -p -r1.101 xend_internal.c --- xend_internal.c 8 Mar 2007 14:12:06 -0000 1.101 +++ xend_internal.c 14 Mar 2007 10:42:16 -0000 @@ -1722,9 +1722,9 @@ sexpr_to_xend_domain_info(virDomainPtr d if (strchr(flags, 'c')) info->state = VIR_DOMAIN_CRASHED; else if (strchr(flags, 's')) - info->state = VIR_DOMAIN_SHUTDOWN; - else if (strchr(flags, 'd')) info->state = VIR_DOMAIN_SHUTOFF; + else if (strchr(flags, 'd')) + info->state = VIR_DOMAIN_SHUTDOWN; else if (strchr(flags, 'p')) info->state = VIR_DOMAIN_PAUSED; else if (strchr(flags, 'b'))

2 2

[Libvir] [PATCH] modular compilation of xen/qemu/test
by Daniel Veillard 14 Mar '07

14 Mar '07

The following patch adds 3 configure options to turn on or off the support for Xen, QEMU/KVM and the test driver, as the output of configure --help shows: ... --with-xen add XEN support (on) --with-qemu add QEMU/KVM support (on) --with-test add test driver support (on) ... It uses compile time flags, is not really intrusive, it just pointed out a few strangeness, one of which was fixed (a Xen include) and the remaining ones are: - xml.c doesn't depend on Xen except for virDomainXMLDevID calling xenStoreDomainGetNetworkID() - libvirt.c still calls xenDaemonDomainLookupByName_ids from virDomainGetUUID() , I'm not sure if this can be avoided In the tests directory, sexpr2xmltest.c and xmconfigtest.c still depends on code in xen specific modules, trying to add them without xen being present was more complex than the value it may add (it also makes the patch smaller to cut at the module level). Plan to commit this before the release, unless this raises a problem, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

2 1

[Libvir] Reliably detecting if Intel VT is disabled in the BIOS
by Richard W.M. Jones 14 Mar '07

14 Mar '07

VMXON is the instruction which turns on Intel VT extensions[1]. This instruction can be enabled and disabled by setting a bit in a CPU register. Moreover, this CPU register itself can be locked so that no changes can be made until the CPU is power-cycled. In detail, the register is the IA32_FEATURE_CONTROL (0x3A) MSR. The relevant bits are: bit 0 Lock bit (0 = unlocked, 1 = permanently locked) bit 1 Enable VMXON in Intel Safer Mode Extensions (SMX) bit 2 Enable VMXON in normal operation So to find out if VT is possible with the CPU, use CPUID (in practice, check if "vmx" is in /proc/cpuinfo flags). To find out if VT can be turned on in the host, check bit 2 in the above register. There is a handy tool called msr-tools[2] which you can use: # ./rdmsr 0x3a ff03 (bit 2 is clear, so VT is _not_ enabled on this host). It seems that the BIOS locks the register (by writing 1 to bit 0). To find out if the BIOS has locked the register, use rdmsr again and look at the lowest bit. In the example above you can see that the BIOS disabled VT and locked the register. Once the register is locked, the only way around it is to reboot. If the register is unlocked you can enable VT by writing a 1 to bit 2. If you don't want to use the msr-tools, then direct access to the register can be had through /dev/cpu/<id>/msr. For example this is an strace of rdmsr 0x3a: open("/dev/cpu/0/msr", O_RDONLY) = 3 pread(3, "\3\377\0\0\0\0\0\0", 8, 58) = 8 However you need to be root to open /dev/cpu/0/msr. On machines which don't support the IA32_FEATURE_CONTROL MSR you will get an EIO error: pread(3, 0x7ffff81ec810, 8, 58) = -1 EIO (Input/output error) Rich. Notes: [1] I don't think this is possible with AMD's Pacifica extensions. I'm not sure if it's possible to disable these in the BIOS & lock them. [2] http://www.kernel.org/pub/linux/utils/cpu/msr-tools/ Sources: * linux/drivers/kvm/vmx.c: function vmx_disabled_by_bios * "Intel® Trusted Execution Technology Preliminary Architecture Specification" section 2.1.2 (http://download.intel.com/technology/security/downloads/31516803.pdf) -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

1 0

[Libvir] [PATCH] Add virConnectGetCapabilities call to return the capabilities of the driver / hypervisor
by Richard W.M. Jones 13 Mar '07

13 Mar '07

This patch: * Adds virConnectGetCapabilities which returns an XML description of the capabilities of the driver or hypervisor under this connection (see below for more about the XML format). * Adds virsh capabilities command. * Checks the Python binding works. Caveats: * Xen implementation (in xen_internal.c) is not tested because I don't have a working Xen machine right now. QEMU, test and remote work however. Example: $ virsh -c test:///default capabilities | tidy -xml -i -q <capabilities> <domain> <type>test</type> </domain> <host_features></host_features> <guest_architectures> <guest_architecture> <model>i686</model> <bits>32</bits> <guest_features> <accelerated /> <pae /> </guest_features> </guest_architecture> </guest_architectures> </capabilities> $ virsh -c qemu:///session capabilities | tidy -xml -i -q <capabilities> <domain> <type>qemu</type> </domain> <guest_architectures> <guest_architecture> <model>i686</model> <bits>32</bits> <features> <emulated /> </features> </guest_architecture> <guest_architecture> <model>x86_64</model> <bits>64</bits> <features> <emulated /> </features> </guest_architecture> [... other archs deleted ...] </guest_architectures> </capabilities> XML format: The <capabilities> node contains information about the host and a list of supported architectures for guests. About the host we return: <domain> <type> The default type acceptable when creating a domain. <host_features> <hvm> Does the host CPU support HVM? <type> Type of HVM (eg. "vmx") <bios_setting> "enabled" or "disabled" About the guest architectures we can return: <guest_architecture> <model> The (virtualised) CPU <bits> Bits <domain> <type> If different from the default type (eg. for kqemu) <features> <hvm> Full virt guest? <accelerated> Accelerated (eg. Xen or kqemu) <emulated> Emulated (eg. qemu or bochs) (and a few other esoteric flags here) Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

4 13

[Libvir] virsh command is getting a connecting error
by Saori Fukuta 13 Mar '07

13 Mar '07

Hi, It was working fine on March 8th, but today it failed to do virsh command with an error message. # virsh list libvir: error : no support for hypervisor lt-virsh: error: failed to connect to the hypervisor This message is printed here because nb_network_drivers is 0. --- libvirt.c : virConnectOpen 317 if (ret->nb_drivers == 0 || ret->nb_network_drivers == 0) { 318 /* we failed to find an adequate driver */ 319 virLibConnError(NULL, VIR_ERR_NO_SUPPORT, name); 320 goto failed; 321 } I think the cause is because it failed to bind the socket at qemuOpenClientUNIX. --- qemu_internal.c : qemuOpenClientUNIX 232 /* 233 * now bind the socket to that address and listen on it 234 */ 235 if (connect(fd, (struct sockaddr *) &addr, sizeof(addr)) < 0) { They are setting members of sockaddr: {sun_family = 1, sun_path = "/usr/var/run/libvirt/qemud-sock", '\0'} and connect returned -1 with errno that was 2(ENOENT). Is there any problem? Please tell me how I can use current virsh command. Thanks, Saori Fukuta.

2 2

[Libvir] Inconsistent networking between Xen & QEMU
by Daniel P. Berrange 09 Mar '07

09 Mar '07

In Xen it is possible to configure a VIF to enslave with an arbitrary bridge device using a fragment of XML like: <interface type='bridge'> <source bridge='xenbr0'/> <mac address='00:16:3E:66:94:9C'/> </interface> In this example I've enslaved to xenbr0 which is created by the Xen networking script, but this will work with any bridge device really. In QEMU the only bridging is available via the 'virtual networks' support in libvirt, by referencing a named bridge. For example <interface type='network'> <source network='default'/> <mac address='00:16:3E:66:94:9C'/> </interface> Now 'default' is merely defined to be backed by a bridge device 'virbr0' (although it does not neccessary get backed by a bridge) so the basic impl is basically just enslaving a TAP device. Anyway, we now have two different syntaxes in the XML for defining what is more or less the same thing which is a real PITA for the tools. It is useful to have the distinct representations - one is for 'managed' bridges, and the other is for 'unmanaged' bridges - we can do some much more interesting things with managed bridges. To improve life for the tools though I'd like to do two things as a high priority - Support managed networks in Xen - we can simply lookup the bridge device associated with a network and tell Xen to use vif-bridge with this device. For the reverse Xen will tell us what bridge device a guest is using, and we can reverse lookup the corresponding network - Support non-managed networks in QEMU - we can simply enslave the QEMU tap device to an arbitrary user specific bridge device. Until one of these two options is done, its going to be a PITA to support networking across QEMU & Xen in virt-manager/virt-install. Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 10

[Libvir] [PATCH] Add a default network
by Mark McLoughlin 09 Mar '07

09 Mar '07

Hey, So, we want to install a default network which guests can connect to. This can be seen as e.g. a replacement for xenbr0 as the default bridge for xen guests. A few things concern me about the patch, see below for my thinking. However, I'm happy to punt on all of these issues for now and go ahead with the patch. 1) Ordering - we want the default network to have a predictable bridge name, so instead of relying on it being the first network and ending up auto-allocated vnet0, we use virbr0. The alternative is to actually have an ordering scheme, e.g. #define LIBVIRT_AUTOSTART_PRIORITY_DISABLE -1 #define LIBVIRT_AUTOSTART_PRIORITY_FIRST 0 #define LIBVIRT_AUTOSTART_PRIORITY_LAST 99 #define LIBVIRT_AUTOSTART_PRIORITY_DEFAULT 50 int virNetworkSetAutostart(virDomainPtr domain, int priority); autostart/00-default.xml -> ../default.xml autostart/99-MyNetwork.xml -> ../MyNetwork.xml Maybe that's useful, but probably moreso for guests than networks. The "virbr0" solution is fine, IMHO. 2) IP address choice - I've randomly chosen 192.168.122.1/24 as the IP address for the network, and this could happen to clash with an existing network. Since we masquerade outgoing traffic, I think the only problem this would cause in practice would be where the host machine is already on a 192.168.122/24 subnet and it could find itself connecting to a guest rather than another machine on the physical subnet. It's a default configuration choice which admins can change, and I don't see it causing huge problems in practice, so I'm not overly concerned. If it did turn out to be a problem, I'd probably add something like: <ip type="auto" /> But I'm not anxious to go down that route right now. 3) UUID generation - there's no UUID specified, so the default network will have a different UUID across reboots. We could trivially save the UUID at first boot, but we'd really need to put it in /var then. IMHO, it's something we can fix later if it turns out to be important. Cheers, Mark.

3 8

[Libvir] Restarting of libvirt_qemud daemon
by Daniel P. Berrange 09 Mar '07

09 Mar '07

Thinking about later RPM upgrades I think we need to think about whether it will be possible to restart the libvirt_qemud while guests & networks are running. There's a couple of issues: - We do waitpid() to cleanup qemu & dnsmasq processes when we stop domains & networks, or to detect when they crash. For the former, we could may they daemons to avoid waitpid() cleanup, but we'd still need waitpid to be able to detect shutdowns. There is also the issue of enumerating running instances. - We always try to re-create a bridge device at startup, even if it already exists. Likewise we always try to add the IPtables rules & start dnsmasq. We can easily detect if the bridge already exists. I think we can probably double check iptables rulles too., The tricky one is figuring out whether a dnsmasq instance is still running. Dealing with theses not only helps planned restarts, but will also make it possible start up the daemon again after a crash without having to kill off all guests & networks manually. So I think it is worth investigating what we can do to enable restarts. It might be worth waiting until we sort out whether we'll merge libvirt_qemud with the generic libvirtd remote daemon though so we don't have to do the work twice over. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

4 8

[Libvir] Stable UUID needed for default network
by Daniel P. Berrange 09 Mar '07

09 Mar '07

The UUID for the default network is not included in the example default config. So every time you restart the libvirt_qemud we get a randomly generated UUID. This isn't really in keeping with the idea of having a permanent UID :-) So I think we need to do two things: - In the 'make install' routine - if-and-only-if the $prefix/etc/libvirt/networks/default.xml file was newly installed, then stuff a random UUID into it, eg UUID=`uuidgen` sed -e "s,</name>,</name>\n <uuid>$UUID</uuid>," \ $prefix/etc/libvirt/networks/default.xml If the system doesn't have uuidgen, we can just ignore this step - In the RPM %post section we need to stuff in a UUID at install time if-and-only-if this is a new install - ie leave it alone during upgrades UUID=`uuidgen` sed -e "s,</name>,</name>\n <uuid>$UUID</uuid>," \ %(sysconfdir)/libvirt/networks/default.xml Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 1

[Libvir] Alternate dnsmasq command line args ?
by Daniel P. Berrange 09 Mar '07

09 Mar '07

Currently we launch dnsmasq with a command line looking like: dnsmasq --keep-in-foreground --bind-interfaces --pid-file --conf-file --except-interface lo --listen-address 192.168.122.1 --dhcp-range 192.168.122.2,192.168.122.254 This causes DNSMASQ to listen on any network interface configured with an IP address of '192.168.122.1', except for loopback. I know it would be kind of unusual, but it is possible two interface might be both configured with the same address. I think it may be safer if we explicitly tell it to use virbr0 instead eg --interface virbr0 --except-interface lo Yes, the --except-interface lo is still needed due to wierd ass dnsmasq rules which make it always use loopback unless you tell it not to. I'm also not clear why we use --conf-file - we're not actually telling it about any config file so this seems redundant ? Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 2

[Libvir] Generate python binding for network APIs
by Daniel P. Berrange 09 Mar '07

09 Mar '07

I was about to make use of the new networking APIs in virt-manager/virt-install when I discovered we don't have any python binding for it. Attached is the quickest patch I could write to support it - I basically copied all the virDomain related bits & s/Domain/Network/ throughout. A simple demo script works: #!/usr/bin/python import libvirt con = libvirt.open(None) n = con.listNetworks() print str(n) for name in n: net = con.lookupByName(name) print net.XMLDesc(0) print net.bridgeName() I think there are a couple more methods which need manual implementations though - eg UUIDString() is generated incorrectly - in fact the UUIDString() impl for virDomains is already broken, and so is the binding for VCPU pinning. Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 3

[Libvir] PATCH: Fix QEMU autostart/network behaviour
by Daniel P. Berrange 08 Mar '07

08 Mar '07

In my testing there appeared to be a couple of bugs with the QEMU driver and the interaction with networking - It was auto-starting the daemon even with qemu://system - It was opening the QEMU connection twice due to inverted check, and not opening it at all in the non-QEMU hv case. - Once that is fixed, then it SEGVs when using a Xen connection as uri->scheme is NULL That attached patch rectifies those flaws - Mark can you double check this just in case I've missed some edge case for the networking stuff - I have strace'd virsh when doing virsh list (as root & non-root) virsh --connect test://default list (as root & non-root) virsh --connect xen list (as root & non-root) virsh --connect qemu://session list (as non-root) virsh --connect qemu://system list (as root) virsh --connect qemu://session --readonly list (as non-root) virsh --connect qemu://system --readonly list (as root & non-root) And it appears to now be making the correct connectiosn to the QEMU daemons in all cases Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 1

[Libvir] [PATCH] libvirt.c: warning: dereferencing type-punned pointer will break strict-aliasing rules
by Richard W.M. Jones 08 Mar '07

08 Mar '07

I'm currently trying to get libvirt to compile with -Werror. One problem which came up early is the warning in $SUBJECT. The gcc info page (see -fstrict-aliasing) is pretty unclear about what exactly causes this problem, so the attached patch rewrites the code quite conservatively to avoid the problem. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

3 5

[Libvir] [RFC] Check host's minimum memory.
by Masayuki Sunou 08 Mar '07

08 Mar '07

Hi The minimum value of the memory guarded with virsh setmem is 4096KB(4MB). In general, when host's memory is set to 4MB, the host stops. Therefore, I propose the patch to which host's minimum value of the memory is guarded by 256MB. Signed-off-by: Masayuki Sunou <fj1826dm(a)aa.jp.fujitsu.com> Thanks, Masayuki Sunou. libvirt-0.2.0 -------------------------------------------------------------------------------- Index: libvirt/src/xend_internal.c =================================================================== RCS file: /data/cvs/libvirt/src/xend_internal.c,v retrieving revision 1.97 diff -u -p -r1.97 xend_internal.c --- libvirt/src/xend_internal.c 2 Mar 2007 20:19:08 -0000 1.97 +++ libvirt/src/xend_internal.c 6 Mar 2007 01:42:44 -0000 @@ -2243,6 +2243,9 @@ xenDaemonDomainSetMemory(virDomainPtr do if (domain->id < 0 && domain->conn->xendConfigVersion < 3) return(-1); + if (domain->id == 0 && memory < (256 * 1024)) + return(-1); + snprintf(buf, sizeof(buf), "%lu", memory >> 10); return xend_op(domain->conn, domain->name, "op", "mem_target_set", "target", buf, NULL); Index: libvirt/src/xm_internal.c =================================================================== RCS file: /data/cvs/libvirt/src/xm_internal.c,v retrieving revision 1.14 diff -u -p -r1.14 xm_internal.c --- libvirt/src/xm_internal.c 23 Feb 2007 08:51:30 -0000 1.14 +++ libvirt/src/xm_internal.c 6 Mar 2007 01:42:46 -0000 @@ -1025,6 +1025,9 @@ int xenXMDomainSetMemory(virDomainPtr do if (domain->id != -1) return (-1); + if (domain->id == 0 && memory < (256 * 1024)) + return(-1); + if (!(filename = virHashLookup(nameConfigMap, domain->name))) return (-1); Index: libvirt/src/xs_internal.c =================================================================== RCS file: /data/cvs/libvirt/src/xs_internal.c,v retrieving revision 1.32 diff -u -p -r1.32 xs_internal.c --- libvirt/src/xs_internal.c 23 Feb 2007 08:51:30 -0000 1.32 +++ libvirt/src/xs_internal.c 6 Mar 2007 01:42:46 -0000 @@ -434,6 +434,10 @@ xenStoreDomainSetMemory(virDomainPtr dom } if (domain->id == -1) return(-1); + + if (domain->id == 0 && memory < (256 * 1024)) + return(-1); + snprintf(value, 19, "%lu", memory); value[19] = 0; ret = virDomainDoStoreWrite(domain, "memory/target", &value[0]); --------------------------------------------------------------------------------

4 9

[Libvir] [PATCH] export virConf* symbols (second version)
by Richard W.M. Jones 08 Mar '07

08 Mar '07

Second version of that patch. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

3 3

[Libvir] [PATCH] Can specify VNC port number 5900
by Nobuhiro Itou 08 Mar '07

08 Mar '07

Hi The libvirt cannot specify VNC port number 5900. Currently if we specify the port 5900, The port number set to 5900+DomID. This patch fixes the port number from 5900+DomID to 5900 for this case. Signed-off-by: Nobuhiro Itou <fj0873gn(a)aa.jp.fujitsu.com> Thanks, Nobuhiro Itou. Index: xml.c =================================================================== RCS file: /data/cvs/libvirt/src/xml.c,v retrieving revision 1.62 diff -u -p -r1.62 xml.c --- xml.c 6 Mar 2007 20:00:17 -0000 1.62 +++ xml.c 8 Mar 2007 04:23:03 -0000 @@ -251,7 +251,7 @@ static int virDomainParseXMLGraphicsDesc long port = strtol((const char *)vncport, NULL, 10); if (port == -1) virBufferAdd(buf, "(vncunused 1)", 13); - else if (port > 5900) + else if (port >= 5900) virBufferVSprintf(buf, "(vncdisplay %d)", port - 5900); xmlFree(vncport); } @@ -315,7 +315,7 @@ static int virDomainParseXMLGraphicsDesc long port = strtol((const char *)vncport, NULL, 10); if (port == -1) virBufferAdd(buf, "(vncunused 1)", 13); - else if (port > 5900) + else if (port >= 5900) virBufferVSprintf(buf, "(vncdisplay %d)", port - 5900); xmlFree(vncport); }

3 2

[Libvir] [PATCH] check the maximum of virtual CPU
by Masayuki Sunou 08 Mar '07

08 Mar '07

Hi The maximum of virtual CPU is not guarded in virsh setvcpus now. Then, when 32767 was set to virtual CPU of virsh setvcpus, the problem that Xend became abnormal was detected. example: ---------------------------------------------------------------------- # virsh setvcpus 0 32767 libvir: Xen Daemon error : POST operation failed: (xend.err "(9, 'Bad file descriptor')") libvir: Xen error : failed Xen syscall ioctl 3166208 libvir: error : library call virDomainSetVcpus failed, possibly not supported # xm list -l Error: (9, 'Bad file descriptor') Usage: xm list [options] [Domain, ...] List information about all/some domains. -l, --long Output all VM details in SXP --label Include security labels --state=<state> Select only VMs with the specified state ---------------------------------------------------------------------- Therefore, I propose the correction that adjusts the maximum of virtual CPU to the same value as Xen. This patch is over 200lines. If you request, I am ready to repost it with split this patch. Signed-off-by: Masayuki Sunou <fj1826dm(a)aa.jp.fujitsu.com> Thanks, Masayuki Sunou. libvirt-0.2.0 ---------------------------------------------------------------------- diff -rup a/include/libvirt/libvirt.h b/include/libvirt/libvirt.h --- a/include/libvirt/libvirt.h 2007-02-23 17:51:30.000000000 +0900 +++ b/include/libvirt/libvirt.h 2007-03-01 03:02:20.000000000 +0900 @@ -233,6 +233,7 @@ int virConnectGetVersion (virConnectPt unsigned long *hvVer); int virNodeGetInfo (virConnectPtr conn, virNodeInfoPtr info); +int virGetCpuMax (virConnectPtr conn); /* * Gather list of running domains diff -rup a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in --- a/include/libvirt/libvirt.h.in 2007-02-23 17:51:30.000000000 +0900 +++ b/include/libvirt/libvirt.h.in 2007-03-01 03:02:50.000000000 +0900 @@ -233,6 +233,7 @@ int virConnectGetVersion (virConnectPt unsigned long *hvVer); int virNodeGetInfo (virConnectPtr conn, virNodeInfoPtr info); +int virGetCpuMax (virConnectPtr conn); /* * Gather list of running domains diff -rup a/src/driver.h b/src/driver.h --- a/src/driver.h 2007-02-23 17:51:30.000000000 +0900 +++ b/src/driver.h 2007-03-01 03:09:32.000000000 +0900 @@ -140,6 +140,8 @@ typedef int typedef int (*virDrvDomainSetAutostart) (virDomainPtr domain, int autostart); +typedef int + (*virDrvGetCpuMax) (void); typedef struct _virDriver virDriver; typedef virDriver *virDriverPtr; @@ -191,6 +193,7 @@ struct _virDriver { virDrvDomainDetachDevice domainDetachDevice; virDrvDomainGetAutostart domainGetAutostart; virDrvDomainSetAutostart domainSetAutostart; + virDrvGetCpuMax cpumax; }; typedef int diff -rup a/src/libvirt.c b/src/libvirt.c --- a/src/libvirt.c 2007-02-23 17:51:30.000000000 +0900 +++ b/src/libvirt.c 2007-03-01 02:16:49.000000000 +0900 @@ -1670,6 +1670,35 @@ virNodeGetInfo(virConnectPtr conn, virNo return(0); } +/** + * virDrvGetCpuMax: + * + * Returns the maximum of CPU defined by Hypervisor. + * + * Returns the maximum of CPU or 0 in case of error. + */ +int +virGetCpuMax(virConnectPtr conn) { + int i; + int ret = -1; + + if (!VIR_IS_CONNECT(conn)) { + virLibConnError(conn, VIR_ERR_INVALID_CONN, __FUNCTION__); + return (0); + } + + for (i = 0;i < conn->nb_drivers;i++) { + if ((conn->drivers[i] != NULL) && + (conn->drivers[i]->cpumax != NULL)) { + ret = conn->drivers[i]->cpumax(); + if (ret != 0) + return(ret); + } + } + virLibConnError(conn, VIR_ERR_CALL_FAILED, __FUNCTION__); + return (-1); +} + /************************************************************************ * * * Handling of defined but not running domains * diff -rup a/src/libvirt_sym.version b/src/libvirt_sym.version --- a/src/libvirt_sym.version 2007-02-23 17:51:30.000000000 +0900 +++ b/src/libvirt_sym.version 2007-03-01 02:17:18.000000000 +0900 @@ -52,6 +52,7 @@ virConnResetLastError; virDefaultErrorFunc; virNodeGetInfo; + virGetCpuMax; virDomainSetVcpus; virDomainPinVcpu; diff -rup a/src/proxy_internal.c b/src/proxy_internal.c --- a/src/proxy_internal.c 2007-02-23 17:51:30.000000000 +0900 +++ b/src/proxy_internal.c 2007-03-01 02:17:40.000000000 +0900 @@ -83,6 +83,7 @@ static virDriver xenProxyDriver = { NULL, /* domainDetachDevice */ NULL, /* domainGetAutostart */ NULL, /* domainSetAutostart */ + NULL, /* cpumax */ }; /** diff -rup a/src/qemu_internal.c b/src/qemu_internal.c --- a/src/qemu_internal.c 2007-02-23 21:46:35.000000000 +0900 +++ b/src/qemu_internal.c 2007-03-01 02:18:02.000000000 +0900 @@ -1200,6 +1200,7 @@ static virDriver qemuDriver = { NULL, /* domainDetachDevice */ qemuDomainGetAutostart, /* domainGetAutostart */ qemuDomainSetAutostart, /* domainSetAutostart */ + NULL, /* cpumax */ }; static virNetworkDriver qemuNetworkDriver = { diff -rup a/src/test.c b/src/test.c --- a/src/test.c 2007-02-23 17:51:30.000000000 +0900 +++ b/src/test.c 2007-03-01 02:18:53.000000000 +0900 @@ -127,6 +127,7 @@ static virDriver testDriver = { NULL, /* domainDetachDevice */ NULL, /* domainGetAutostart */ NULL, /* domainSetAutostart */ + NULL, /* cpumax */ }; typedef struct _testDev { diff -rup a/src/virsh.c b/src/virsh.c --- a/src/virsh.c 2007-02-28 00:35:50.000000000 +0900 +++ b/src/virsh.c 2007-03-01 02:19:59.000000000 +0900 @@ -1383,6 +1383,7 @@ cmdSetvcpus(vshControl * ctl, vshCmd * c { virDomainPtr dom; int count; + int maxcpu; int ret = TRUE; if (!vshConnectionUsability(ctl, ctl->conn, TRUE)) @@ -1397,6 +1398,18 @@ cmdSetvcpus(vshControl * ctl, vshCmd * c return FALSE; } + maxcpu = virGetCpuMax(ctl->conn); + if (!maxcpu) { + virDomainFree(dom); + return FALSE; + } + + if (count > maxcpu) { + vshError(ctl, FALSE, _("Too many virtual CPU's.")); + virDomainFree(dom); + return FALSE; + } + if (virDomainSetVcpus(dom, count) != 0) { ret = FALSE; } diff -rup a/src/xend_internal.c b/src/xend_internal.c --- a/src/xend_internal.c 2007-02-28 00:50:03.000000000 +0900 +++ b/src/xend_internal.c 2007-03-01 02:21:34.000000000 +0900 @@ -99,6 +99,7 @@ static virDriver xenDaemonDriver = { xenDaemonDetachDevice, /* domainDetachDevice */ NULL, /* domainGetAutostart */ NULL, /* domainSetAutostart */ + NULL, /* cpumax */ }; /** diff -rup a/src/xen_internal.c b/src/xen_internal.c --- a/src/xen_internal.c 2007-02-23 17:51:30.000000000 +0900 +++ b/src/xen_internal.c 2007-02-28 18:06:08.000000000 +0900 @@ -456,6 +456,7 @@ static virDriver xenHypervisorDriver = { NULL, /* domainDetachDevice */ NULL, /* domainGetAutostart */ NULL, /* domainSetAutostart */ + xenHypervisorGetCpuMax, /* cpumax */ }; #endif /* !PROXY */ @@ -1824,6 +1825,17 @@ xenHypervisorGetVcpus(virDomainPtr domai } #endif +/** + * xend_get_cpu_max: + * + * Returns the maximum of CPU defined by Xen. + */ +int +xenHypervisorGetCpuMax(void) +{ + return MAX_VIRT_CPUS; +} + /* * Local variables: * indent-tabs-mode: nil diff -rup a/src/xen_internal.h b/src/xen_internal.h --- a/src/xen_internal.h 2006-08-04 19:41:05.000000000 +0900 +++ b/src/xen_internal.h 2007-03-01 02:21:13.000000000 +0900 @@ -55,6 +55,7 @@ int xenHypervisorGetVcpus (virDomainPtr int maxinfo, unsigned char *cpumaps, int maplen); +int xenHypervisorGetCpuMax (void); #ifdef __cplusplus } diff -rup a/src/xm_internal.c b/src/xm_internal.c --- a/src/xm_internal.c 2007-02-23 17:51:30.000000000 +0900 +++ b/src/xm_internal.c 2007-03-01 02:23:54.000000000 +0900 @@ -108,6 +108,7 @@ static virDriver xenXMDriver = { NULL, /* domainDetachDevice */ NULL, /* domainGetAutostart */ NULL, /* domainSetAutostart */ + NULL, /* cpumax */ }; static void diff -rup a/src/xs_internal.c b/src/xs_internal.c --- a/src/xs_internal.c 2007-02-23 17:51:30.000000000 +0900 +++ b/src/xs_internal.c 2007-03-01 02:24:20.000000000 +0900 @@ -77,6 +77,7 @@ static virDriver xenStoreDriver = { NULL, /* domainDetachDevice */ NULL, /* domainGetAutostart */ NULL, /* domainSetAutostart */ + NULL, /* cpumax */ }; /**

5 14

[Libvir] Remote patch, 2007-02-28
by Richard W.M. Jones 08 Mar '07

08 Mar '07

http://www.annexia.org/tmp/libvirt-tls-20070228.patch Not an enormous amount of difference between this and the patch from two days ago. This patch correctly logs/audits new connections and fixes a whole collection of different bugs which used to happen when the server rejected a client connection. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

6 22

[Libvir] Reason for daemons?
by Shuveb Hussain 07 Mar '07

07 Mar '07

Hi, Any reason why actual requests are serviced by daemons? Is it just to increase the stability of the applications that link to libvirt or are there other reasons? I have started implementing OpenVZ support. Should I follow the same path and implement a daemon as well? Regards, -- Shuveb Hussain. I blog at http://binarykarma.org Spread the Karma.

2 1

[Libvir] [RFC] Host and guest capabilities
by Richard W.M. Jones 07 Mar '07

07 Mar '07

I've been looking into the parts of virtinst which try to probe the capabilities of the host directly, rather than being abstracted through libvirt (for example, opening and parsing /sys/hypervisor/properties/capabilities directly). Attached is a proposed API for probing the capabilities and supported guest architectures of the hypervisor / driver. I've implemented the virCapabilities part already. My original implementation of the guest architectures had virCapabilities containing a list of supported architectures, but that doesn't nearly cover the richness of what the underlying drivers could support, so I'm currently separating that out into a separate virConnectGetGuestArchitectures call. Let me know your opinions of this API. As an aside, the current virt-manager "choose paravirt / fullvirt" screen doesn't really capture the full, shall I say, ugliness of the possible choices for architecture, particularly when we add qemu, kqemu, and emulation in the mix. I suspect that presenting a list of architectures here, perhaps with some options to show only paravirt, show only fullvirt, show only accelerated ... Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

3 6

[Libvir] Patch: Fix documentation and code of virGetDomain function
by Richard W.M. Jones 07 Mar '07

07 Mar '07

It turns out that you _can't_ pass name=NULL to virGetDomain, despite what the docs say. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

5 6

[Libvir] About the 'virsh start'
by Yoshihiko Yaegashi 07 Mar '07

07 Mar '07

Hi, The command 'virsh start' fails under the following conditions. - architecture:x86_64 - PV domain (f7test2) - After the install are done I attach a xend.log to a message. Thanks Yaegashi [2007-03-07 07:11:12 xend 30702] DEBUG (SrvDomain:76) Starting domain fc7test2 False [2007-03-07 07:11:12 xend.XendDomainInfo 30702] DEBUG (XendDomainInfo:1288) XendDomainInfo.constructDomain [2007-03-07 07:11:12 xend.XendDomainInfo 30702] DEBUG (XendDomainInfo:1334) XendDomainInfo.initDomain: 71 256 [2007-03-07 07:11:12 xend 19603] DEBUG (XendBootloader:64) Launching bootloader as ['/usr/bin/pygrub', '-q', '--output=/var/run/xend/boot/xenbl.16058', '/dev/sda13']. [2007-03-07 07:11:12 xend 30702] DEBUG (balloon:127) Balloon: 717020 KiB free; need 358400; done. [2007-03-07 07:11:12 xend 30702] INFO (image:125) buildDomain os=linux dom=71 vcpus=1 [2007-03-07 07:11:12 xend 30702] DEBUG (image:194) domid = 71 [2007-03-07 07:11:12 xend 30702] DEBUG (image:195) memsize = 350 [2007-03-07 07:11:12 xend 30702] DEBUG (image:196) image = /var/run/xend/boot/boot_kernel.EMjGRe [2007-03-07 07:11:12 xend 30702] DEBUG (image:197) store_evtchn = 1 [2007-03-07 07:11:12 xend 30702] DEBUG (image:198) console_evtchn = 2 [2007-03-07 07:11:12 xend 30702] DEBUG (image:199) cmdline = ro root=/dev/VolGroup00/LogVol00 rhgb quiet [2007-03-07 07:11:12 xend 30702] DEBUG (image:200) ramdisk = /var/run/xend/boot/boot_ramdisk.tAzsxc [2007-03-07 07:11:12 xend 30702] DEBUG (image:201) vcpus = 1 [2007-03-07 07:11:12 xend 30702] DEBUG (image:202) features = [2007-03-07 07:11:13 xend.XendDomainInfo 30702] INFO (XendDomainInfo:1198) createDevice: vif : {'bridge': 'xenbr0', 'mac': '00:16:3e:08:28:23', 'script': 'vif-bridge', 'uuid': '8df737da-edfa-83e9-614b-61c7ba127165', 'backend': 0} [2007-03-07 07:11:13 xend 30702] DEBUG (DevController:115) DevController: writing {'backend-id': '0', 'mac': '00:16:3e:08:28:23', 'handle': '0', 'state': '1', 'backend': '/local/domain/0/backend/vif/71/0'} to /local/domain/71/device/vif/0. [2007-03-07 07:11:13 xend 30702] DEBUG (DevController:117) DevController: writing {'bridge': 'xenbr0', 'domain': 'fc7test2', 'handle': '0', 'uuid': '8df737da-edfa-83e9-614b-61c7ba127165', 'script': '/etc/xen/scripts/vif-bridge', 'state': '1', 'frontend': '/local/domain/71/device/vif/0', 'mac': '00:16:3e:08:28:23', 'online': '1', 'frontend-id': '71'} to /local/domain/0/backend/vif/71/0. [2007-03-07 07:11:13 xend.XendDomainInfo 30702] INFO (XendDomainInfo:1198) createDevice: vbd : {'uuid': 'd04e0343-9479-2279-4b51-0b284bdd7f4c', 'driver': 'paravirtualised', 'dev': 'xvda:disk', 'uname': 'phy:/dev/sda13', 'mode': 'w', 'backend': 0} [2007-03-07 07:11:13 xend 30702] DEBUG (DevController:115) DevController: writing {'backend-id': '0', 'virtual-device': '51712', 'device-type': 'disk', 'state': '1', 'backend': '/local/domain/0/backend/vbd/71/51712'} to /local/domain/71/device/vbd/51712. [2007-03-07 07:11:13 xend 30702] DEBUG (DevController:117) DevController: writing {'domain': 'fc7test2', 'frontend': '/local/domain/71/device/vbd/51712', 'uuid': 'd04e0343-9479-2279-4b51-0b284bdd7f4c', 'dev': 'xvda', 'state': '1', 'params': '/dev/sda13', 'mode': 'w', 'online': '1', 'frontend-id': '71', 'type': 'phy'} to /local/domain/0/backend/vbd/71/51712. [2007-03-07 07:11:13 xend.XendDomainInfo 30702] DEBUG (XendDomainInfo:1719) Storing VM details: {'on_xend_stop': 'ignore', 'shadow_memory': '0', 'uuid': 'ff828d32-70b2-53eb-4566-d08683974052', 'name': 'fc7test2', 'on_reboot': 'restart', 'start_time': '1173219073.18', 'on_poweroff': 'destroy', 'on_xend_start': 'ignore', 'on_crash': 'restart', 'xend/restart_count': '0', 'vcpus': '1', 'vcpu_avail': '1', 'memory': '350', 'image': "(linux (kernel /var/run/xend/boot/boot_kernel.EMjGRe) (ramdisk /var/run/xend/boot/boot_ramdisk.tAzsxc) (args 'ro root=/dev/VolGroup00/LogVol00 rhgb quiet'))", 'maxmem': '350'} [2007-03-07 07:11:13 xend.XendDomainInfo 30702] DEBUG (XendDomainInfo:731) Storing domain details: {'console/ring-ref': '419357', 'console/port': '2', 'name': 'fc7test2', 'console/limit': '1048576', 'vm': '/vm/ff828d32-70b2-53eb-4566-d08683974052', 'domid': '71', 'cpu/0/availability': 'online', 'memory/target': '358400', 'store/ring-ref': '419358', 'store/port': '1'} [2007-03-07 07:11:13 xend 30702] DEBUG (XendDomain:428) Adding Domain: 71 [2007-03-07 07:11:13 xend 30702] DEBUG (DevController:148) Waiting for devices vif. [2007-03-07 07:11:13 xend.XendDomainInfo 30702] DEBUG (XendDomainInfo:731) Storing domain details: {'console/ring-ref': '419357', 'console/port': '2', 'name': 'fc7test2', 'console/limit': '1048576', 'vm': '/vm/ff828d32-70b2-53eb-4566-d08683974052', 'domid': '71', 'cpu/0/availability': 'online', 'memory/target': '358400', 'store/ring-ref': '419358', 'store/port': '1'} [2007-03-07 07:11:13 xend.XendDomainInfo 30702] DEBUG (XendDomainInfo:798) XendDomainInfo.handleShutdownWatch [2007-03-07 07:11:13 xend 30702] DEBUG (DevController:153) Waiting for 0. [2007-03-07 07:11:13 xend 30702] DEBUG (DevController:522) hotplugStatusCallback /local/domain/0/backend/vif/71/0/hotplug-status. [2007-03-07 07:11:13 xend 30702] DEBUG (DevController:522) hotplugStatusCallback /local/domain/0/backend/vif/71/0/hotplug-status. [2007-03-07 07:11:13 xend 30702] DEBUG (DevController:536) hotplugStatusCallback 1. [2007-03-07 07:11:13 xend 30702] DEBUG (DevController:148) Waiting for devices usb. [2007-03-07 07:11:13 xend 30702] DEBUG (DevController:148) Waiting for devices vbd. [2007-03-07 07:11:13 xend 30702] DEBUG (DevController:153) Waiting for 51712. [2007-03-07 07:11:13 xend 30702] DEBUG (DevController:522) hotplugStatusCallback /local/domain/0/backend/vbd/71/51712/hotplug-status. [2007-03-07 07:11:13 xend 30702] DEBUG (DevController:522) hotplugStatusCallback /local/domain/0/backend/vbd/71/51712/hotplug-status. [2007-03-07 07:11:13 xend 30702] DEBUG (DevController:536) hotplugStatusCallback 1. [2007-03-07 07:11:13 xend 30702] DEBUG (DevController:148) Waiting for devices irq. [2007-03-07 07:11:13 xend 30702] DEBUG (DevController:148) Waiting for devices vkbd. [2007-03-07 07:11:13 xend 30702] DEBUG (DevController:148) Waiting for devices vfb. [2007-03-07 07:11:13 xend 30702] DEBUG (DevController:148) Waiting for devices pci. [2007-03-07 07:11:13 xend 30702] DEBUG (DevController:148) Waiting for devices ioports. [2007-03-07 07:11:13 xend 30702] DEBUG (DevController:148) Waiting for devices tap. [2007-03-07 07:11:13 xend 30702] DEBUG (DevController:148) Waiting for devices vtpm. [2007-03-07 07:11:17 xend.XendDomainInfo 30702] WARNING (XendDomainInfo:950) Domain has crashed: name=fc7test2 id=71. [2007-03-07 07:11:17 xend.XendDomainInfo 30702] DEBUG (XendDomainInfo:731) Storing domain details: {'console/ring-ref': '419357', 'console/port': '2', 'name': 'fc7test2', 'console/limit': '1048576', 'vm': '/vm/ff828d32-70b2-53eb-4566-d08683974052', 'domid': '71', 'cpu/0/availability': 'online', 'memory/target': '358400', 'store/ring-ref': '419358', 'store/port': '1'} [2007-03-07 07:11:17 xend.XendDomainInfo 30702] DEBUG (XendDomainInfo:731) Storing domain details: {'console/ring-ref': '419357', 'console/port': '2', 'name': 'fc7test2', 'console/limit': '1048576', 'vm': '/vm/ff828d32-70b2-53eb-4566-d08683974052', 'domid': '71', 'cpu/0/availability': 'online', 'memory/target': '358400', 'store/ring-ref': '419358', 'store/port': '1'} [2007-03-07 07:11:17 xend.XendDomainInfo 30702] DEBUG (XendDomainInfo:1495) XendDomainInfo.destroyDomain(71) [2007-03-07 07:11:17 xend.XendDomainInfo 30702] DEBUG (XendDomainInfo:94) XendDomainInfo.create(['domain', ['domid', 71], ['on_crash', 'restart'], ['memory', 350], ['uuid', 'ff828d32-70b2-53eb-4566-d08683974052'], ['bootloader_args', ''], ['name', 'fc7test2'], ['maxmem', 350], ['on_reboot', 'restart'], ['on_poweroff', 'destroy'], ['localtime', 0], ['vcpus', 1], ['bootloader', '/usr/bin/pygrub'], ['shadow_memory', 0], ['vcpu_avail', 1], ['cpu_weight', 256], ['cpu_cap', 0], ['features', ''], ['on_xend_start', 'ignore'], ['on_xend_stop', 'ignore'], ['start_time', 1173219073.1766889], ['cpu_time', 0.14879309900000001], ['online_vcpus', 1], ['image', ['linux', ['kernel', '/var/run/xend/boot/boot_kernel.EMjGRe'], ['ramdisk', '/var/run/xend/boot/boot_ramdisk.tAzsxc'], ['args', 'ro root=/dev/VolGroup00/LogVol00 rhgb quiet']]], ['status', 0], ['memory_dynamic_min', 350], ['memory_dynamic_max', 350], ['state', '----c-'], ['store_mfn', 419358], ['console_mfn', 419357], ['device', ['vif', ['bridge', 'xenbr0'], ['mac', '00:16:3e:08:28:23'], ['script', 'vif-bridge'], ['uuid', '8df737da-edfa-83e9-614b-61c7ba127165'], ['backend', 0]]], ['device', ['vbd', ['uname', 'phy:/dev/sda13'], ['uuid', 'd04e0343-9479-2279-4b51-0b284bdd7f4c'], ['mode', 'w'], ['dev', 'xvda:disk'], ['backend', 0]]]]) [2007-03-07 07:11:17 xend.XendConfig 30702] WARNING (XendConfig:607) Unconverted key: cpus [2007-03-07 07:11:17 xend.XendDomainInfo 30702] DEBUG (XendDomainInfo:1288) XendDomainInfo.constructDomain [2007-03-07 07:11:17 xend.XendDomainInfo 30702] DEBUG (XendDomainInfo:1334) XendDomainInfo.initDomain: 72 256 [2007-03-07 07:11:17 xend 19768] DEBUG (XendBootloader:64) Launching bootloader as ['/usr/bin/pygrub', '-q', '--output=/var/run/xend/boot/xenbl.1059', '/dev/sda13']. [2007-03-07 07:11:17 xend 30702] DEBUG (balloon:127) Balloon: 447020 KiB free; need 358400; done. [2007-03-07 07:11:17 xend 30702] INFO (image:125) buildDomain os=linux dom=72 vcpus=1 [2007-03-07 07:11:17 xend 30702] DEBUG (image:194) domid = 72 [2007-03-07 07:11:17 xend 30702] DEBUG (image:195) memsize = 350 [2007-03-07 07:11:17 xend 30702] DEBUG (image:196) image = /var/run/xend/boot/boot_kernel.yBt3-v [2007-03-07 07:11:17 xend 30702] DEBUG (image:197) store_evtchn = 1 [2007-03-07 07:11:17 xend 30702] DEBUG (image:198) console_evtchn = 2 [2007-03-07 07:11:17 xend 30702] DEBUG (image:199) cmdline = ro root=/dev/VolGroup00/LogVol00 rhgb quiet [2007-03-07 07:11:17 xend 30702] DEBUG (image:200) ramdisk = /var/run/xend/boot/boot_ramdisk.JK64t5 [2007-03-07 07:11:17 xend 30702] DEBUG (image:201) vcpus = 1 [2007-03-07 07:11:17 xend 30702] DEBUG (image:202) features = [2007-03-07 07:11:17 xend.XendDomainInfo 30702] INFO (XendDomainInfo:1198) createDevice: vif : {'bridge': 'xenbr0', 'mac': '00:16:3e:08:28:23', 'script': 'vif-bridge', 'uuid': '8df737da-edfa-83e9-614b-61c7ba127165', 'backend': 0} [2007-03-07 07:11:17 xend 30702] DEBUG (DevController:115) DevController: writing {'backend-id': '0', 'mac': '00:16:3e:08:28:23', 'handle': '0', 'state': '1', 'backend': '/local/domain/0/backend/vif/72/0'} to /local/domain/72/device/vif/0. [2007-03-07 07:11:17 xend 30702] DEBUG (DevController:117) DevController: writing {'bridge': 'xenbr0', 'domain': 'fc7test2', 'handle': '0', 'uuid': '8df737da-edfa-83e9-614b-61c7ba127165', 'script': '/etc/xen/scripts/vif-bridge', 'state': '1', 'frontend': '/local/domain/72/device/vif/0', 'mac': '00:16:3e:08:28:23', 'online': '1', 'frontend-id': '72'} to /local/domain/0/backend/vif/72/0. [2007-03-07 07:11:17 xend.XendDomainInfo 30702] INFO (XendDomainInfo:1198) createDevice: vbd : {'uuid': 'd04e0343-9479-2279-4b51-0b284bdd7f4c', 'driver': 'paravirtualised', 'dev': 'xvda:disk', 'uname': 'phy:/dev/sda13', 'mode': 'w', 'backend': 0} [2007-03-07 07:11:17 xend 30702] DEBUG (DevController:115) DevController: writing {'backend-id': '0', 'virtual-device': '51712', 'device-type': 'disk', 'state': '1', 'backend': '/local/domain/0/backend/vbd/72/51712'} to /local/domain/72/device/vbd/51712. [2007-03-07 07:11:17 xend 30702] DEBUG (DevController:117) DevController: writing {'domain': 'fc7test2', 'frontend': '/local/domain/72/device/vbd/51712', 'uuid': 'd04e0343-9479-2279-4b51-0b284bdd7f4c', 'dev': 'xvda', 'state': '1', 'params': '/dev/sda13', 'mode': 'w', 'online': '1', 'frontend-id': '72', 'type': 'phy'} to /local/domain/0/backend/vbd/72/51712. [2007-03-07 07:11:17 xend.XendDomainInfo 30702] DEBUG (XendDomainInfo:1719) Storing VM details: {'on_xend_stop': 'ignore', 'shadow_memory': '0', 'uuid': 'ff828d32-70b2-53eb-4566-d08683974052', 'name': 'fc7test2', 'on_reboot': 'restart', 'start_time': '1173219077.8', 'on_poweroff': 'destroy', 'on_xend_start': 'ignore', 'on_crash': 'restart', 'vcpus': '1', 'vcpu_avail': '1', 'memory': '350', 'image': "(linux (kernel /var/run/xend/boot/boot_kernel.yBt3-v) (ramdisk /var/run/xend/boot/boot_ramdisk.JK64t5) (args 'ro root=/dev/VolGroup00/LogVol00 rhgb quiet'))", 'maxmem': '350'} [2007-03-07 07:11:17 xend.XendDomainInfo 30702] DEBUG (XendDomainInfo:731) Storing domain details: {'console/ring-ref': '467281', 'console/port': '2', 'name': 'fc7test2', 'console/limit': '1048576', 'vm': '/vm/ff828d32-70b2-53eb-4566-d08683974052', 'domid': '72', 'cpu/0/availability': 'online', 'memory/target': '358400', 'store/ring-ref': '467282', 'store/port': '1'} [2007-03-07 07:11:17 xend 30702] DEBUG (XendDomain:428) Adding Domain: 72 [2007-03-07 07:11:17 xend.XendDomainInfo 30702] DEBUG (XendDomainInfo:731) Storing domain details: {'console/ring-ref': '467281', 'console/port': '2', 'name': 'fc7test2', 'console/limit': '1048576', 'vm': '/vm/ff828d32-70b2-53eb-4566-d08683974052', 'domid': '72', 'cpu/0/availability': 'online', 'memory/target': '358400', 'store/ring-ref': '467282', 'store/port': '1'} [2007-03-07 07:11:17 xend.XendDomainInfo 30702] DEBUG (XendDomainInfo:798) XendDomainInfo.handleShutdownWatch [2007-03-07 07:11:17 xend.XendDomainInfo 30702] DEBUG (XendDomainInfo:731) Storing domain details: {'console/ring-ref': '467281', 'console/port': '2', 'name': 'fc7test2', 'console/limit': '1048576', 'vm': '/vm/ff828d32-70b2-53eb-4566-d08683974052', 'domid': '72', 'cpu/0/availability': 'online', 'memory/target': '358400', 'store/ring-ref': '467282', 'store/port': '1'} [2007-03-07 07:11:17 xend.XendDomainInfo 30702] DEBUG (XendDomainInfo:731) Storing domain details: {'console/ring-ref': '467281', 'console/port': '2', 'name': 'fc7test2', 'console/limit': '1048576', 'vm': '/vm/ff828d32-70b2-53eb-4566-d08683974052', 'domid': '72', 'cpu/0/availability': 'online', 'memory/target': '358400', 'store/ring-ref': '467282', 'store/port': '1'} [2007-03-07 07:11:21 xend.XendDomainInfo 30702] WARNING (XendDomainInfo:950) Domain has crashed: name=fc7test2 id=72. [2007-03-07 07:11:21 xend.XendDomainInfo 30702] DEBUG (XendDomainInfo:731) Storing domain details: {'console/ring-ref': '467281', 'console/port': '2', 'name': 'fc7test2', 'console/limit': '1048576', 'vm': '/vm/ff828d32-70b2-53eb-4566-d08683974052', 'domid': '72', 'cpu/0/availability': 'online', 'memory/target': '358400', 'store/ring-ref': '467282', 'store/port': '1'} [2007-03-07 07:11:21 xend.XendDomainInfo 30702] ERROR (XendDomainInfo:1079) VM fc7test2 restarting too fast (4.709960 seconds since the last restart). Refusing to restart to avoid loops. [2007-03-07 07:11:21 xend.XendDomainInfo 30702] DEBUG (XendDomainInfo:1487) XendDomainInfo.destroy: domid=72 [2007-03-07 07:11:21 xend.XendDomainInfo 30702] DEBUG (XendDomainInfo:1495) XendDomainInfo.destroyDomain(72)

1 0

Re: [Libvir] [PATCH][RFC] Add --keymap option to virt-install
by Takahashi Tomohiro 07 Mar '07

07 Mar '07

Hi, Dan Thank you for committing a patch. I confirmed that I can use jp106 keyboard on HVM domain, and the keymap that is configured in the XML. when I used latest patch(revision 1.435). Thanks, Tomohiro Takahashi. > On Tue, Mar 06, 2007 at 03:21:16PM +0000, Daniel P. Berrange wrote: >> On Tue, Mar 06, 2007 at 10:00:08PM +0900, Takahashi Tomohiro wrote: >> > I would like to add --keymap option to virt-install in order to set up >> > jp106 keymap. Because I can't use jp106 keyboard. So, I made a patch >> > (notes:It relates python-virtinst) >> > >> > Usage: virt-install --keymap=ja >> > >> > I confirmed that I can use jp106 keyboard on HVM domain. >> > But didn't confirm PV domain. >> > >> > Please give me an advice, if you have it. >> >> I've been expecting someone to send this patch for quite a while :-) >> >> It all looks good to me, although all my keyboards are US english >> so my own testing will be limited to making sure the keymap gets >> passed through to the QEMU daemon correctly. For paravirt, I think >> you need to have Xen 3.0.5 to use keymap, but I'll double check >> that and then apply this. >> >> > @@ -1903,6 +1907,8 @@ virConfPtr xenXMParseXMLToConfig(virConn >> > len += 11 + strlen((const char*)vnclisten); >> > if (vncpasswd) >> > len += 11 + strlen((const char*)vncpasswd); >> > + if (keymap) >> > + len += 11 + strlen((const char*)keymap); >> > if ((val = malloc(len)) != NULL) { >> > strcpy(val, "type=vnc"); >> > if (vncunused) { >> >> A minor bug - the length is only 8, not 11, but I'll fix that when I >> commit, so don't worry about sending an updated patch. > > Ok, this is now committed - I also extended the XML generation code so > that it will report back the keymap that is configured in the XML > dump, as well as updating the test suite to check the handling. > > Dan. > -- > |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 > 2496 -=| > |=- Perl modules: > .cpan.org/~danberr/ -=| > |=- Projects: > at.net/~danielpb/ -=| > |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B > 505 -=| >

1 0

[Libvir] [PATCH] lots of warnings removed - libvirt can now compile with -Werror
by Richard W.M. Jones 06 Mar '07

06 Mar '07

For a completely clean build you need to also apply the previous patch[1]. Rich. [1] https://www.redhat.com/archives/libvir-list/2007-March/msg00030.html and see also Mark's reply. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

3 3

[Libvir] PATCH: Process QEMU monitor at startup
by Daniel P. Berrange 06 Mar '07

06 Mar '07

With the current QEMU driver we simply spawn the QEMU process and return to the caller immediately. If the QEMU process dies immediately for some reason the user will never no - their domain will simply never appear. To address this, the attached patch will spawn the QEMU process and then immeditely process stderr to look for the monitor PTY - or EOF indicating failure. If it finds the monitor it will also try to connect to it - if this fails in any way then the domain is terminated with extreme prejudice - we absolutely need the monitor connection for other operations to work. This should at least cause a 'Domain startup failed' message to be returned to the user although more work is needed to try and extract a useful error message from the stuff written to stderr. Also in this patch I have reversed the order in which file descriptors are added to the poll array. Currently they are added server, then client, then VMs. The trouble with this is that when processing the server event, if a new client is added to the daemon then processing of subsequent FDs is out of sync. Likewise if a client message causes a new VM to startup then processing of subsquent VM FDs is out of sync. Reversing the order trivially solves it, because VM FDs s are now processed before client FDs, and thus any new VMs started by a client don't mess things up. Likewise client FDs are processed before server FDs. A more robust long term fix would be to carry around some extra metadata instead of relying on ordering when dispatching events. Finally this patch also fixes the 'resume' operation, and allows for the VM state to be reported correctly - ie we can now report 'paused' as well as shutdown/running. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 9

[Libvir] [PATCH][RFC] Add --keymap option to virt-install
by Takahashi Tomohiro 06 Mar '07

06 Mar '07

Hi, I would like to add --keymap option to virt-install in order to set up jp106 keymap. Because I can't use jp106 keyboard. So, I made a patch (notes:It relates python-virtinst) Usage: virt-install --keymap=ja I confirmed that I can use jp106 keyboard on HVM domain. But didn't confirm PV domain. Please give me an advice, if you have it. Signed-off-by: Tomohiro Takahashi <takatom(a)jp.fujitsu.com> Thanks, Tomohiro Takahashi. ================================================================================== diff -uNrp ./libvirt.orig/src/xml.c ./libvirt/src/xml.c --- ./libvirt.orig/src/xml.c 2007-02-15 01:22:02.000000000 +0900 +++ ./libvirt/src/xml.c 2007-03-06 20:17:38.000000000 +0900 @@ -246,6 +246,7 @@ static int virDomainParseXMLGraphicsDesc xmlChar *vncport = xmlGetProp(node, BAD_CAST "port"); xmlChar *vnclisten = xmlGetProp(node, BAD_CAST "listen"); xmlChar *vncpasswd = xmlGetProp(node, BAD_CAST "passwd"); + xmlChar *keymap = xmlGetProp(node, BAD_CAST "keymap"); if (vncport != NULL) { long port = strtol((const char *)vncport, NULL, 10); if (port == -1) @@ -262,6 +263,10 @@ static int virDomainParseXMLGraphicsDesc virBufferVSprintf(buf, "(vncpasswd %s)", vncpasswd); xmlFree(vncpasswd); } + if (keymap != NULL) { + virBufferVSprintf(buf, "(keymap %s)", keymap); + xmlFree(keymap); + } } } xmlFree(graphics_type); @@ -305,6 +310,7 @@ static int virDomainParseXMLGraphicsDesc xmlChar *vncport = xmlGetProp(node, BAD_CAST "port"); xmlChar *vnclisten = xmlGetProp(node, BAD_CAST "listen"); xmlChar *vncpasswd = xmlGetProp(node, BAD_CAST "passwd"); + xmlChar *keymap = xmlGetProp(node, BAD_CAST "keymap"); if (vncport != NULL) { long port = strtol((const char *)vncport, NULL, 10); if (port == -1) @@ -321,6 +327,10 @@ static int virDomainParseXMLGraphicsDesc virBufferVSprintf(buf, "(vncpasswd %s)", vncpasswd); xmlFree(vncpasswd); } + if (keymap != NULL) { + virBufferVSprintf(buf, "(keymap %s)", keymap); + xmlFree(keymap); + } } virBufferAdd(buf, "))", 2); xmlFree(graphics_type); diff -uNrp ./libvirt.orig/src/xm_internal.c ./libvirt/src/xm_internal.c --- ./libvirt.orig/src/xm_internal.c 2007-02-23 17:51:30.000000000 +0900 +++ ./libvirt/src/xm_internal.c 2007-03-06 20:20:32.000000000 +0900 @@ -1863,6 +1863,9 @@ virConfPtr xenXMParseXMLToConfig(virConn if (xenXMConfigSetStringFromXPath(conn, conf, ctxt, "vncpasswd", "string(/domain/devices/graphics[@type='vnc']/@passwd)", 1, "cannot set the vncpasswd parameter") < 0) goto error; + if (xenXMConfigSetStringFromXPath(conn, conf, ctxt, "keymap", "string(/domain/devices/graphics[@type='vnc']/@keymap)", 1, + "cannot set the vncpasswd parameter") < 0) + goto error; /* XXX vncdisplay */ /* @@ -1894,6 +1897,7 @@ virConfPtr xenXMParseXMLToConfig(virConn xmlChar *vncport = xmlGetProp(obj->nodesetval->nodeTab[i], BAD_CAST "port"); xmlChar *vnclisten = xmlGetProp(obj->nodesetval->nodeTab[i], BAD_CAST "listen"); xmlChar *vncpasswd = xmlGetProp(obj->nodesetval->nodeTab[i], BAD_CAST "passwd"); + xmlChar *keymap = xmlGetProp(obj->nodesetval->nodeTab[i], BAD_CAST "keymap"); int vncunused = vncport ? (!strcmp((const char*)vncport, "-1") ? 1 : 0) : 1; if (vncunused) len += 12; @@ -1903,6 +1907,8 @@ virConfPtr xenXMParseXMLToConfig(virConn len += 11 + strlen((const char*)vnclisten); if (vncpasswd) len += 11 + strlen((const char*)vncpasswd); + if (keymap) + len += 11 + strlen((const char*)keymap); if ((val = malloc(len)) != NULL) { strcpy(val, "type=vnc"); if (vncunused) { @@ -1923,6 +1929,11 @@ virConfPtr xenXMParseXMLToConfig(virConn strcat(val, (const char*)vncpasswd); xmlFree(vncpasswd); } + if (keymap) { + strcat(val, ",keymap="); + strcat(val, (const char*)keymap); + xmlFree(keymap); + } } } xmlFree(type);

2 2

[Libvir] [PATCH] add global --readonly flag to virsh
by Richard W.M. Jones 06 Mar '07

06 Mar '07

The current vshInit function in virsh tries some dodgy heuristics to see if it should connect readonly or read/write to the hypervisor. Unfortunately these heuristics fail, eg. when you have a root-owned system-wide qemud, and a user trying to run virsh as non-root. This patch removes the heuristics and replaces them with a simple -r | --readonly flag on the command line. If omitted, we try to connect read/write, otherwise we try to connect readonly. Note that this doesn't affect the "connect" command in the shell, which still has its own --readonly flag that is completely separate from this new global flag. Rich.

2 2

[Libvir] [PATCH] unlink roSockname, not sockname
by Richard W.M. Jones 06 Mar '07

06 Mar '07

Very trivial fix, but necessary because it prevents the qemu proxy from restarting. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

2 1

[Libvir] Error when paravirtualization domain starts with virsh.
by Michel Gauthier 06 Mar '07

06 Mar '07

With the RHEL5 RC distribution on our IA64 platform (4 CPUs), when we use virsh to start a paravirtuailzation domain, we've got the following: virsh # list Id Name State ---------------------------------- 0 Domain-0 running virsh # create hndom2 Failed to get devices for domain hndom2 error: Failed to create domain from hndom2 virsh # list Id Name State ---------------------------------- 0 Domain-0 running 24 Domain-24 paused In spite of an error message, a domain named Domain-Id is created instead of the hndom2 domain. The corresponding XML configuration file is the following: <domain type="xen"> <name>hndom2</name> <os> <type>linux</type> <kernel>/boot/efi/efi/redhat/vmlinuz-2.6.18-8.el5xen</kernel> <root>/dev/hda1</root> <initrd>/boot/efi/efi/redhat/initrd-2.6.18-8.el5xenU.img</initrd> <cmdline>console=tty0 nomca 3 ide0=noprobe ide1=noprobe ide2=noprobe ide3=noprobe selinux=0</cmdline> </os> <memory>527360</memory> <currentMemory>393216</currentMemory> <vcpu>3</vcpu> <on_poweroff>restart</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>restart</on_crash> <devices> <disk type="block"> <driver name="phy"/> <source dev="/dev/sda5"/> <target dev="/dev/hda1"/> </disk> <interface type="bridge"> <source bridge=""/> </interface> </devices> </domain> If the <currentMemory> tag is suppressed from the XML configuration file, all is OK. This behaviour appears with the libvirt version 0.1.8 released with the RHEL5 RC, and also with the libvirt version 0.1.10. Are you aware of this problem? If you want some complementary infos (xend log), we can send it to you. Regards, Michel Gauthier.

3 3

[Libvir] [RFC] The idea of 'policy manager'
by ASANO Yuzuru 06 Mar '07

06 Mar '07

Hello, I summarized the idea about 'policy manager'. The purpose of 'policy manager' is to manage and to operate 'runtime policy' such as cpu pin/weight/cap. Please refer to the following thread about earlier argument about 'policy manager'. https://www.redhat.com/archives/libvir-list/2007-February/msg00211.html To implement the above mentioned features, I think that 'policy manager' need to be constructed by CLI and API. Is it all right in the following ideas? - About CLI At first, I think the following commands are necessary. ('xxx' means temporary command name) (1) xxx vcpupin <domain> <vcpu> <cpulist> : Same as virsh vcpupin <domain> <vcpu> <cpulist> command (2) xxx schedweight <domain> <weight> : Same as xm sched-credit -d <domain> -w <weight> command (3) xxx schedcap <domain> <cap> : Same as xm sched-credit -d <domain> -c <cap> command (4) xxx cpuoccupy <pcpu> <domains> : The domains specified by <domains> can use the <pcpu> in occupancy, and the other domains can't use it. (*) (5) xxx cpupolicy <domain> : Show the CPU runtime policy of <domain>. (*) When a running domain has vcpu pinned to only single pcpu, the other domains can't occupy the pcpu. In above mentioned (1)-(4), policy informations of not only running domains but also inactive domains are managed in the following API. - About API The main function which is necessary for API are as follows. o When CLI command is executed, the demanded processing is done by calling libvirt from API. o API preserves the specified by CLI command to a specific file. o When start/reboot domain command is executed by libvirt, API is called from libvirt and the domain is set the runtime policy. - TODO list o It is necessary to add new function into libvirt to change scheduler parameters (cpu weight/cap) previously. Any other thoughts from anyone? Regards, Yuzuru Asano.

1 0

[Libvir] [PATCH] qemuOpenConnection readonly parameter is not unused
by Richard W.M. Jones 05 Mar '07

05 Mar '07

2 1

[Libvir] [PATCH] patch for virsh domname <uuid> command error
by Tatsuro Enokura 02 Mar '07

02 Mar '07

Hi, Virsh domname <uuid> command for shut-off domain fails on xen-3.0.4. I think that xm_internal.c shoud be modified. But, it seems that xm_internal's structure isn't for xen-3.0.4, and shut-off domain's information is got from xend. I make a patch for xend_internal.c The attached patch resolve this issue in the following way: 1) If the domain's name can't be pulled out from the running domains list by uuid, request xend by "/xend/domains/<uuid>". 2) If the domain's data can be teken from xend, pull out the domain's name. Signed-off-by: Tatsuro Enokura <fj7716hz(a)aa.jp.fujitsu.com> Thanks, Tatsuro Enokura. Index: src/xend_internal.c (libvirt-0.2.0) =================================================================== --- xend_internal.c 2007-02-15 01:16:16.000000000 +0900 +++ xend_internal.c.new 2007-02-23 21:13:22.000000000 +0900 @@ -2759,6 +2759,8 @@ xenDaemonLookupByUUID(virConnectPtr conn char **tmp; unsigned char ident[VIR_UUID_BUFLEN]; int id = -1; + struct sexpr *root = NULL; + char *domname = NULL; names = xenDaemonListDomainsOld(conn); tmp = names; @@ -2779,6 +2781,26 @@ xenDaemonLookupByUUID(virConnectPtr conn } free(names); + if (name == NULL) { + char uuidstr[VIR_UUID_STRING_BUFLEN]; + memset(uuidstr, '\0', VIR_UUID_STRING_BUFLEN); + + snprintf(uuidstr, VIR_UUID_STRING_BUFLEN, + "%02x%02x%02x%02x-%02x%02x-%02x%02x-%02x%02x-%02x%02x%02x%02x%02x%02x", + uuid[0], uuid[1], uuid[2], uuid[3], + uuid[4], uuid[5], uuid[6], uuid[7], + uuid[8], uuid[9], uuid[10], uuid[11], + uuid[12], uuid[13], uuid[14], uuid[15]); + root = sexpr_get(conn, "/xend/domain/%s?detail=1", uuidstr); + if (root == NULL) + goto error; + domname = (char*)sexpr_node(root, "domain/name"); + if (domname == NULL) + goto error; + name = strdup(domname); + id = -1; + } + if (name == NULL) goto error; @@ -2793,6 +2815,8 @@ xenDaemonLookupByUUID(virConnectPtr conn return (ret); error: + if (root != NULL) + sexpr_free(root); if (name != NULL) free(name); return (NULL); ===================================================================

2 4

[Libvir] [PATCH]Report the error from xend for Domain-0
by Kazuki　Mizushima 02 Mar '07

02 Mar '07

Hi, When I test virsh subcommands, dump save, for Domain-0, It says following normal messages, but the processing is not done. #virsh dump 0 a Domain 0 dumpd to a #echo $? 0 #virsh save 0 a Domain 0 saved to a #echo $? 0 I made a patch which reports the error from xend like this. #virsh dump 0 a libvir: Xen Daemon error : POST operation failed: (xend.err 'Cannot save privileged domain 0') libvir: error : library call virDomainSave failed, possibly not supported error: Failed to save domain 0 to a # echo $? 1 #virsh dump 0 a libvir: Xen Daemon error : POST operation failed: (xend.err 'Cannot dump core for privileged domain 0') libvir: error : library call virDomainCoreDump failed, possibly not supported error: Failed to core dump domain 0 to a # echo $? 1 Signed-off-by: Kazuki Mizushima <mizushima.kazuk(a)jp.fujitsu.com> Thanks, Kazuki Mizushima Index: xend_internal.c (libvirt-0.2.0) ---------------------------------------------------------------------- --- ../../libvirt-0.2.0/src/xend_internal.c 2007-02-15 01:16:16.000000000 +0900 +++ xend_internal.c 2007-02-27 22:45:05.000000000 +0900 @@ -507,7 +507,10 @@ xend_post(virConnectPtr xend, const char if ((ret < 0) || (ret >= 300)) { virXendError(xend, VIR_ERR_POST_FAILED, content); - } else if ((ret = 202) && (strstr(content, "failed") != NULL)) { + } else if ((ret == 202) && (strstr(content, "failed") != NULL)) { + virXendError(xend, VIR_ERR_POST_FAILED, content); + ret = -1; + } else if ((ret == 202) && (strcasestr(content, "cannot") != NULL)) { virXendError(xend, VIR_ERR_POST_FAILED, content); ret = -1; } ----------------------------------------------------------------------

4 5

[Libvir] Warnings about GNU make extensions
by Richard W.M. Jones 01 Mar '07

01 Mar '07

I'm seeing the warnings below when compiling on Fedora Rawhide. src/Makefile.am:84: `%'-style pattern rules are a GNU make extension tests/Makefile.am:11: wildcard $(top_builddir: non-POSIX variable name tests/Makefile.am:11: (probably a GNU make extension) tests/confdata/Makefile.am:2: wildcard *.conf: non-POSIX variable name tests/confdata/Makefile.am:2: (probably a GNU make extension) tests/confdata/Makefile.am:2: wildcard *.out: non-POSIX variable name tests/confdata/Makefile.am:2: (probably a GNU make extension) tests/sexpr2xmldata/Makefile.am:2: wildcard *.xml: non-POSIX variable name tests/sexpr2xmldata/Makefile.am:2: (probably a GNU make extension) tests/sexpr2xmldata/Makefile.am:2: wildcard *.sexpr: non-POSIX variable name tests/sexpr2xmldata/Makefile.am:2: (probably a GNU make extension) tests/virshdata/Makefile.am:2: wildcard *.txt: non-POSIX variable name tests/virshdata/Makefile.am:2: (probably a GNU make extension) tests/xmconfigdata/Makefile.am:2: wildcard *.xml: non-POSIX variable name tests/xmconfigdata/Makefile.am:2: (probably a GNU make extension) tests/xmconfigdata/Makefile.am:2: wildcard *.cfg: non-POSIX variable name tests/xmconfigdata/Makefile.am:2: (probably a GNU make extension) tests/xml2sexprdata/Makefile.am:2: wildcard *.xml: non-POSIX variable name tests/xml2sexprdata/Makefile.am:2: (probably a GNU make extension) tests/xml2sexprdata/Makefile.am:2: wildcard *.sexpr: non-POSIX variable name tests/xml2sexprdata/Makefile.am:2: (probably a GNU make extension) Versions: $ make --version GNU Make 3.81 Copyright (C) 2006 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. This program built for x86_64-redhat-linux-gnu $ autoconf --version autoconf (GNU Autoconf) 2.61 Copyright (C) 2006 Free Software Foundation, Inc. This is free software. You may redistribute copies of it under the terms of the GNU General Public License <http://www.gnu.org/licenses/gpl.html>. There is NO WARRANTY, to the extent permitted by law. Written by David J. MacKenzie and Akim Demaille. $ automake --version automake (GNU automake) 1.10 Written by Tom Tromey <tromey(a)redhat.com> and Alexandre Duret-Lutz <adl(a)gnu.org>. Copyright 2006 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. Rich.

1 0

[Libvir] Patch: driver->open functions return declined or error status
by Richard W.M. Jones 01 Mar '07

01 Mar '07

I want to change the driver->open function so that as well as declining a name (returning -1 as now), it may also indicate that it accepts the name, but there is an error opening the name (-2). virConnectOpen fails in this second case, rather than going on and trying the next driver in sequence. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

3 3

[Libvir] ABI compatibility question: static strings returned from some functions
by Richard W.M. Jones 01 Mar '07

01 Mar '07

We have some functions such as virConnectGetType which are defined to return statically allocated strings: /** * virConnectGetType: * @conn: pointer to the hypervisor connection * * Get the name of the Hypervisor software used. * * Returns NULL in case of error, a static zero terminated string otherwise. */ const char * virConnectGetType(virConnectPtr conn) [...] This is all well and good in the typical local case, but when working over a remote connection the string we return is allocated and requires freeing at some point. Unfortunately I don't see a good thing to do in this case except to change the semantics of virConnectGetType, which arguably breaks ABI compatibility. Suggestions from anyone? Rich. garbage.collection++ -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

3 3

[Libvir] Patch: Driver private data
by Richard W.M. Jones 01 Mar '07

01 Mar '07

This patch is more aspirational than currently useful. Only the remote patch would use driver->private, but I think others should be changed to do so too. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

3 2

[Libvir] Request for libvirt/ChangeLog
by Atsushi SAKAI 01 Mar '07

01 Mar '07

Hi, Dan I have one request for libvirt/ChangeLog. Please add the submitter Mail address to libvirt/ChangeLog for ease of contribution counting. Or If you have any good Idea to get the contribution statistics, please notice me. If you consider this, I would be appreciate it. Thanks Atsushi SAKAI

3 4

[Libvir] Patch: include <locale.h> for setlocale
by Richard W.M. Jones 28 Feb '07

28 Feb '07

Very trivial, but useful for me because I'm trying to debug the remote stuff without -O, and without -O it turns out that libvirt doesn't compile. Rich. --------------------------------------- Index: proxy/libvirt_proxy.c =================================================================== RCS file: /data/cvs/libvirt/proxy/libvirt_proxy.c,v retrieving revision 1.12 diff -u -r1.12 libvirt_proxy.c --- proxy/libvirt_proxy.c 23 Jan 2007 14:39:45 -0000 1.12 +++ proxy/libvirt_proxy.c 28 Feb 2007 16:08:05 -0000 @@ -17,6 +17,7 @@ #include <sys/poll.h> #include <sys/socket.h> #include <sys/un.h> +#include <locale.h> #include "internal.h" #include "proxy_internal.h" #include "xen_internal.h" --------------------------------------- -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

2 2

[Libvir] Patch: export virConf* symbols
by Richard W.M. Jones 28 Feb '07

28 Feb '07

The standalone parts of libvirt (particularly libvirtd) use the configuration mini-lib. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

2 2

[Libvir] Patch: Define SYSCONFDIR symbol
by Richard W.M. Jones 28 Feb '07

28 Feb '07

-- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

2 2

[Libvir] Patch: tabstops
by Richard W.M. Jones 28 Feb '07

28 Feb '07

I've been slowly adding the Emacs & vi tabstop code to the end of files. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

1 0

[Libvir] VCPU mapping into the XML
by ASANO Yuzuru 28 Feb '07

28 Feb '07

Hello, I want to add the info of VCPU mapping into the XML, because we cannot manage VCPU mapping automatically when a domain starts or reboots. But in the following patch, the function written in "TODO" which I wanted has not been accepted. https://www.redhat.com/archives/libvir-list/2006-August/msg00015.html If I provided the patch managing VCPU mapping in the XML, do you accept it? Regards, Yuzuru Asano.

4 6

[Libvir] [PATCH] parsing virsh options is wrong
by Saori Fukuta 27 Feb '07

27 Feb '07

Hi, When I specified -t (or -q) option with virsh command, the result is something wrong. It is likely to be caused by the way to parse the virsh options. (example) I would like to know the node information with timing information. So, I try some cases. 1) virsh with "-t nodeinfo" ran virsh interactive terminal. Hmm, I didn't expect that... # virsh -t nodeinfo Welcome to virsh, the virtualization interactive terminal. Type: 'help' for help with commands 'quit' to quit virsh # 2) virsh with "-t aa nodeinfo" I got the node information with timing information. But what does "aa" option mean?? (Of course no meaning.) # virsh -t aa nodeinfo CPU model: i686 CPU(s): 2 CPU frequency: 1828 MHz CPU socket(s): 1 Core(s) per socket: 2 Thread(s) per core: 1 NUMA cell(s): 1 Memory size: 1037312 kB (Time: 2.821 ms) 3) virsh with "-t tt nodeinfo" ran virsh interactive terminal. What's the difference with "aa"? # virsh -t tt nodeinfo Welcome to virsh, the virtualization interactive terminal. Type: 'help' for help with commands 'quit' to quit virsh # I think the cause is missing a conditional before getopt_long at vshParseArgv and add to check whether "o->has_arg" is 1 or not. After the fix, I can use virsh options normally. (example) 1) virsh with "-t nodeinfo" # ./virsh -t nodeinfo CPU model: i686 CPU(s): 2 CPU frequency: 1828 MHz CPU socket(s): 1 Core(s) per socket: 2 Thread(s) per core: 1 NUMA cell(s): 1 Memory size: 1037312 kB (Time: 2.626 ms) 2) virsh with "-t aa nodeinfo" # ./virsh -t aa nodeinfo error: unknown command: 'aa' 3) virsh with "-t tt nodeinfo" # ./virsh -t tt nodeinfo error: unknown command: 'tt' Signed-off-by: Saori Fukuta <fukuta.saori(a)jp.fujitsu.com> Thanks, Saori Fukuta. Index: virsh.c =================================================================== RCS file: /data/cvs/libvirt/src/virsh.c,v retrieving revision 1.55 diff -u -p -r1.55 virsh.c --- virsh.c 23 Feb 2007 10:27:53 -0000 1.55 +++ virsh.c 27 Feb 2007 07:35:28 -0000 @@ -3344,12 +3344,14 @@ vshParseArgv(vshControl * ctl, int argc, int sz = strlen(last); for (o = opt; o->name; o++) { - if (sz == 2 && *(last + 1) == o->val) - /* valid virsh short option */ - valid = TRUE; - else if (sz > 2 && strcmp(o->name, last + 2) == 0) - /* valid virsh long option */ - valid = TRUE; + if (o->has_arg == 1){ + if (sz == 2 && *(last + 1) == o->val) + /* valid virsh short option */ + valid = TRUE; + else if (sz > 2 && strcmp(o->name, last + 2) == 0) + /* valid virsh long option */ + valid = TRUE; + } } } if (!valid) {

2 1

[Libvir] Linker dependancoes [Re: [kvm-devel] QEMU / KVM support in libvirt & virt-manager]
by Daniel P. Berrange 26 Feb '07

26 Feb '07

See this thread on kvm-devel for a question about link time dependancies in libvirt. I'm not sure what the optimal approach is for us to deal with this is - just something we should think about in an idle moment... ----- Forwarded message from Avi Kivity <avi(a)qumranet.com> ----- > Date: Sun, 25 Feb 2007 18:48:44 +0200 > From: Avi Kivity <avi(a)qumranet.com> > To: "Daniel P. Berrange" <berrange(a)redhat.com> > CC: kvm-devel(a)lists.sourceforge.net > Subject: Re: [kvm-devel] QEMU / KVM support in libvirt & virt-manager > > Daniel P. Berrange wrote: > > On Sun, Feb 25, 2007 at 07:32:58AM +0200, Avi Kivity wrote: > > > >> Daniel P. Berrange wrote: > >> > >>> FYI, as of libvirt 0.2.0 and virt-manager 0.3.1 there is now > >>> (experimental!) > >>> support for managing virtual machines running under QEMU or KVM > >>> virtualization > >>> platforms, as well as the existing Xen support. > >>> > >> Great; as I see it hit FC6-updates I'll give it a shot. > >> > >> One thing I saw is that it pulls in Xen as part of the dependencies; > >> perhaps a libvirt-xen and libvirt-kvm subpackage split is called for? > > > > Yeah, we've not figured out exactly how to address that dependancy > > issue yet - the libvirt.so has to link to libxenstore as part of the > > Xen driver, so even if you only want to manage QEMU instances we still > > end up pulling in Xen. We're certainly going to make it possible to > > turn off the Xen stuff at compile time. Not clear how we'd address the > > RPM dep issue though because the Fedora builds of libvirt will include > > both Xen & QEMU support. Perhaps we'll have to try a dlopen() approach. > > I would suggest a /usr/lib/libvirt/xen.so and a > /usr/lib/libvirt/qemu.so, which are enumerated by reading > /usr/lib/libvirt, and dlopen()ed by libvirt.so. Only > /usr/lib/libvirt/xen.so links to libxenstore. > > That way, a third party can add a backend by dropping a .so into > /usr/lib/libvirt, and libvirt.so itself has no backend-related > dependencies -- it doesn't know anything concrete about the backends, in > fact. ----- End forwarded message ----- Dan -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

4 3

[Libvir] Remote patch, 2007-02-26
by Richard W.M. Jones 26 Feb '07

26 Feb '07

I was really hoping to have a patch which could be applied out today. This isn't quite that patch, so my apologies. Nevertheless, this demonstrates what can be done, and works on a selection of the important libvirt API calls. http://www.annexia.org/tmp/libvirt-tls-20070226.patch List of things that need to be done: * Audit incoming IP addresses / virConnectOpen names to syslog. * GnuTLS handshake DoS fix (see danpb's email). * GnuTLS client crashing bug (I have a fix, just needs to be applied). * Complete the wrappers for the remaining API calls. * Testing(!) Apart from that list above, I'm hoping that this patch addresses everything that people have raised on list and privately about previous patches. If I've missed anything, let me know. Rich. ----------------------------------------- "screenshot" --- rjones@oirase:~/d/libvirt-remote$ src/virsh -c test://localhost/default nodeinfo proceeding with name = test:///default loading CA file demoCA/cacert.pem loading client cert and key from files 127001cert.pem and 127001key.pem CPU model: i686 CPU(s): 16 CPU frequency: 1400 MHz CPU socket(s): 2 Core(s) per socket: 2 Thread(s) per core: 2 NUMA cell(s): 2 Memory size: 3145728 kB rjones@oirase:~/d/libvirt-remote$ src/virsh -c test://localhost/default create tests/xmconfigdata/test-fullvirt-new-cdrom.xml proceeding with name = test:///default loading CA file demoCA/cacert.pem loading client cert and key from files 127001cert.pem and 127001key.pem Domain XenGuest2 created from tests/xmconfigdata/test-fullvirt-new-cdrom.xml rjones@oirase:~/d/libvirt-remote$ src/libvirtd -d libvir: error : failed to open /home/rjones/local/etc/libvirtd.conf for reading libvirtd: loading CA cert from demoCA/cacert.pem libvirtd: loading cert and key from servercert.pem and serverkey.pem libvirtd: TLS service listening on port 16514 libvirtd: Unix service listening on socket /home/rjones/local/var/run/libvirtd/socket libvirtd: create_mapping: xprt = 0x647680 libvirtd: lookup_connection: xprt = 0x647680 libvirtd: set_connection: xprt = 0x647680 libvirtd: lookup_connection: xprt = 0x647680 libvirtd: lookup_connection: xprt = 0x647680 libvirtd: set_connection: xprt = 0x647680 libvirtd: destroy_mapping: xprt = 0x647680 libvirtd: create_mapping: xprt = 0x647b20 libvirtd: lookup_connection: xprt = 0x647b20 libvirtd: set_connection: xprt = 0x647b20 libvirtd: lookup_connection: xprt = 0x647b20 libvirtd: lookup_connection: xprt = 0x647b20 libvirtd: set_connection: xprt = 0x647b20 libvirtd: destroy_mapping: xprt = 0x647b20 -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

1 0

Re: [Libvir] [patch 3/3] Use libuuid to generate UUIDs
by Daniel P. Berrange 26 Feb '07

26 Feb '07

On Mon, Feb 26, 2007 at 02:28:30PM +0000, Mark McLoughlin wrote: > If libuuid from e2fsprogs is available, we use that to > generate UUIDs. On the one hand I think its good to re-use existing libraries where they fullfill our needs, but then we need to keep a built-in impl of UUID generator for non-Linux systems which typically won't have a e2fsprogs available. So rather than maintaining two separate impls of the UUID code, which splits the testing coverage, I'd be inclined to just always use the builtin version. Guarenteeing consistent algorithm / semantics for UUID generation across all platforms. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 2

Re: [Libvir] [patch 1/3] Add UUID generation to qemud
by Richard W.M. Jones 26 Feb '07

26 Feb '07

Mark McLoughlin wrote: > +static int > +qemudGenerateRandomBytes(unsigned char *buf, > + int buflen) > +{ > + int fd; > + > + if ((fd = open("/dev/urandom", O_RDONLY)) < 0) > + return errno; > + > + while (buflen > 0) { > + int n; > + > + if ((n = read(fd, buf, buflen)) <= 0) { > + if (errno == EINTR) > + continue; > + close(fd); > + return n < 0 ? errno : ENODATA; > + } > + > + buf += n; > + buflen -= n; > + } > + > + close(fd); > + > + return 0; > +} This function would actually be quite useful as a generally available function. In the remote patch I have added the following to configure.in: dnl /dev/urandom AC_CHECK_FILES([/dev/urandom]) and then in C code I can write: #if HAVE__DEV_URANDOM /* NB double underscore */ // random blah blah #else // pseudorandom blah blah #endif Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

1 0

Re: [Libvir] [patch 0/3] Automatically generate UUIDs in qemud
by Richard W.M. Jones 26 Feb '07

26 Feb '07

Mark McLoughlin wrote: > Hey, > We currently require guests and networks to have a > UUID defined. This patch automatically generates a UUID > if one isn't supplied. > > This is needed because the default network we install > won't have a UUID assigned, since we'll want the UUID to be > different on different hosts. Good one. The remote patch makes some assumptions that UUID is always defined too. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

1 0

[Libvir] [patch 3/3] Use libuuid to generate UUIDs
by Mark McLoughlin 26 Feb '07

26 Feb '07

If libuuid from e2fsprogs is available, we use that to generate UUIDs. Signed-off-by: Mark McLoughlin <markmc(a)redhat.com> Index: libvirt/configure.in =================================================================== --- libvirt.orig/configure.in +++ libvirt/configure.in @@ -189,6 +189,22 @@ dnl AC_CHECK_HEADERS(linux/param.h linux/sockios.h linux/if_bridge.h linux/if_tun.h,, AC_MSG_ERROR([You must install kernel-headers in order to compile libvirt])) +dnl +dnl check for libuuid +dnl +AC_ARG_ENABLE(libuuid, + AC_HELP_STRING([--disable-libuuid], + [disable support for generating UUIDs using e2fsprogs libuuid [default=no]]),, + enable_libuuid=yes) + +if test "x$enable_libuuid" == "xyes" ; then + AC_CHECK_LIB(uuid, uuid_generate, + [AC_CHECK_HEADER(uuid/uuid.h, + AC_DEFINE(ENABLE_LIBUUID,, [enable generating UUIDs using libuuid]) + UUID_LIBS="-luuid" AC_SUBST(UUID_LIBS), + AC_MSG_ERROR([You must install libuuid in order to compile libvirt]))]) +fi + dnl ========================================================================== dnl find libxml2 library, borrowed from xmlsec dnl ========================================================================== Index: libvirt/qemud/Makefile.am =================================================================== --- libvirt.orig/qemud/Makefile.am +++ libvirt/qemud/Makefile.am @@ -16,7 +16,7 @@ libvirt_qemud_CFLAGS = \ -I$(top_srcdir)/include -I$(top_builddir)/include $(LIBXML_CFLAGS) \ -Wall -Wextra -DLOCAL_STATE_DIR="\"$(localstatedir)\"" \ -DSYSCONF_DIR="\"$(sysconfdir)\"" -libvirt_qemud_LDFLAGS = $(LIBXML_LIBS) $(SYSFS_LIBS) +libvirt_qemud_LDFLAGS = $(LIBXML_LIBS) $(SYSFS_LIBS) $(UUID_LIBS) libvirt_qemud_DEPENDENCIES = libvirt_qemud_LDADD = Index: libvirt/qemud/uuid.c =================================================================== --- libvirt.orig/qemud/uuid.c +++ libvirt/qemud/uuid.c @@ -23,6 +23,9 @@ #include "uuid.h" +#ifdef ENABLE_LIBUUID +#include <uuid/uuid.h> +#else #include <errno.h> #include <fcntl.h> #include <stdlib.h> @@ -34,6 +37,18 @@ #include "protocol.h" #include "internal.h" +#endif + +#ifdef ENABLE_LIBUUID + +int +qemudGenerateUUID(unsigned char *uuid) +{ + uuid_generate(uuid); + return 0; +} + +#else /* ENABLE_LIBUUID */ static int qemudGenerateRandomBytes(unsigned char *buf, @@ -89,6 +104,8 @@ qemudGenerateUUID(unsigned char *uuid) return qemudGeneratePseudoRandomBytes(uuid, QEMUD_UUID_RAW_LEN); } +#endif /* ENABLE_LIBUUID */ + int qemudParseUUID(const char *uuid, unsigned char *rawuuid) { const char *cur; --

1 0

[Libvir] [patch 2/3] Move qemudParseUUID() to uuid.
by Mark McLoughlin 26 Feb '07

26 Feb '07

Seems like the obvious place for it now ... Signed-off-by: Mark McLoughlin <markmc(a)redhat.com> Index: libvirt/qemud/conf.c =================================================================== --- libvirt.orig/qemud/conf.c +++ libvirt/qemud/conf.c @@ -47,54 +47,6 @@ #include "iptables.h" #include "uuid.h" -static int qemudParseUUID(const char *uuid, - unsigned char *rawuuid) { - const char *cur; - int i; - - /* - * do a liberal scan allowing '-' and ' ' anywhere between character - * pairs as long as there is 32 of them in the end. - */ - cur = uuid; - for (i = 0;i < 16;) { - rawuuid[i] = 0; - if (*cur == 0) - goto error; - if ((*cur == '-') || (*cur == ' ')) { - cur++; - continue; - } - if ((*cur >= '0') && (*cur <= '9')) - rawuuid[i] = *cur - '0'; - else if ((*cur >= 'a') && (*cur <= 'f')) - rawuuid[i] = *cur - 'a' + 10; - else if ((*cur >= 'A') && (*cur <= 'F')) - rawuuid[i] = *cur - 'A' + 10; - else - goto error; - rawuuid[i] *= 16; - cur++; - if (*cur == 0) - goto error; - if ((*cur >= '0') && (*cur <= '9')) - rawuuid[i] += *cur - '0'; - else if ((*cur >= 'a') && (*cur <= 'f')) - rawuuid[i] += *cur - 'a' + 10; - else if ((*cur >= 'A') && (*cur <= 'F')) - rawuuid[i] += *cur - 'A' + 10; - else - goto error; - i++; - cur++; - } - - return 0; - - error: - return -1; -} - /* Free all memory associated with a struct qemud_vm object */ void qemudFreeVMDef(struct qemud_vm_def *def) { struct qemud_vm_disk_def *disk = def->disks; Index: libvirt/qemud/uuid.c =================================================================== --- libvirt.orig/qemud/uuid.c +++ libvirt/qemud/uuid.c @@ -89,6 +89,54 @@ qemudGenerateUUID(unsigned char *uuid) return qemudGeneratePseudoRandomBytes(uuid, QEMUD_UUID_RAW_LEN); } +int +qemudParseUUID(const char *uuid, unsigned char *rawuuid) { + const char *cur; + int i; + + /* + * do a liberal scan allowing '-' and ' ' anywhere between character + * pairs as long as there is 32 of them in the end. + */ + cur = uuid; + for (i = 0;i < 16;) { + rawuuid[i] = 0; + if (*cur == 0) + goto error; + if ((*cur == '-') || (*cur == ' ')) { + cur++; + continue; + } + if ((*cur >= '0') && (*cur <= '9')) + rawuuid[i] = *cur - '0'; + else if ((*cur >= 'a') && (*cur <= 'f')) + rawuuid[i] = *cur - 'a' + 10; + else if ((*cur >= 'A') && (*cur <= 'F')) + rawuuid[i] = *cur - 'A' + 10; + else + goto error; + rawuuid[i] *= 16; + cur++; + if (*cur == 0) + goto error; + if ((*cur >= '0') && (*cur <= '9')) + rawuuid[i] += *cur - '0'; + else if ((*cur >= 'a') && (*cur <= 'f')) + rawuuid[i] += *cur - 'a' + 10; + else if ((*cur >= 'A') && (*cur <= 'F')) + rawuuid[i] += *cur - 'A' + 10; + else + goto error; + i++; + cur++; + } + + return 0; + + error: + return -1; +} + /* * Local variables: * indent-tabs-mode: nil Index: libvirt/qemud/uuid.h =================================================================== --- libvirt.orig/qemud/uuid.h +++ libvirt/qemud/uuid.h @@ -24,4 +24,7 @@ int qemudGenerateUUID(unsigned char *uuid); +int qemudParseUUID (const char *uuid, + unsigned char *rawuuid); + #endif /* __QEMUD_UUID_H__ */ --

1 0