- Devel - libvirt List Archives

[libvirt PATCH] Fix incorrect uses of g_clear_pointer() introduced in 8.1.0
by Mark Mielke 13 Jun '22

13 Jun '22

This is a partial revert of 87a43a907f0ad4897a28ad7c216bc70f37270b93. The change to use g_clear_pointer() in more places was accidentally applied to cases involving vir_g_source_unref(). In some cases, the ordering of g_source_destroy() and vir_g_source_unref() was reversed, which resulted in the source being marked as destroyed, after it is already unreferenced. This use-after-free case might work in many cases, but with versions of glibc older than 2.64.0 it may defer unref to run within the main thread to avoid a race condition, which creates a large distance between the g_source_unref() and g_source_destroy(). In some cases, the call to vir_g_source_unref() was replaced with a second call to g_source_destroy(), leading to a memory leak or worse. In our experience, the symptoms were that use of libvirt-python became slower over time, with OpenStack nova-compute initially taking around one second to periodically query the host PCI devices, and within an hour it was taking over a minute to complete the same operation, until it is was eventually running this query back-to-back, resulting in the nova-compute process consuming 100% of one CPU thread, losing its RabbitMQ connection frequently, and showing up as down to the control plane. --- src/qemu/qemu_agent.c | 3 ++- src/qemu/qemu_monitor.c | 3 ++- src/util/vireventglib.c | 12 ++++++++---- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index f57a8d5f25..e6e92c7dc4 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -452,8 +452,9 @@ static void qemuAgentUnregister(qemuAgent *agent) { if (agent->watch) { + g_source_destroy(agent->watch); vir_g_source_unref(agent->watch, agent->context); - g_clear_pointer(&agent->watch, g_source_destroy); + agent->watch = NULL; } } diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 37bcbde31e..32c993a941 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -794,8 +794,9 @@ void qemuMonitorUnregister(qemuMonitor *mon) { if (mon->watch) { + g_source_destroy(mon->watch); vir_g_source_unref(mon->watch, mon->context); - g_clear_pointer(&mon->watch, g_source_destroy); + mon->watch = NULL; } } diff --git a/src/util/vireventglib.c b/src/util/vireventglib.c index fc04d8f712..983787932f 100644 --- a/src/util/vireventglib.c +++ b/src/util/vireventglib.c @@ -228,7 +228,8 @@ virEventGLibHandleUpdate(int watch, VIR_DEBUG("Removed old handle source=%p", data->source); g_source_destroy(data->source); - g_clear_pointer(&data->source, g_source_destroy); + vir_g_source_unref(data->source, NULL); + data->source = NULL; data->events = 0; } @@ -275,8 +276,9 @@ virEventGLibHandleRemove(int watch) data, watch, data->fd); if (data->source != NULL) { + g_source_destroy(data->source); vir_g_source_unref(data->source, NULL); - g_clear_pointer(&data->source, g_source_destroy); + data->source = NULL; data->events = 0; } @@ -417,8 +419,9 @@ virEventGLibTimeoutUpdate(int timer, if (data->source == NULL) goto cleanup; + g_source_destroy(data->source); vir_g_source_unref(data->source, NULL); - g_clear_pointer(&data->source, g_source_destroy); + data->source = NULL; } cleanup: @@ -465,8 +468,9 @@ virEventGLibTimeoutRemove(int timer) data, timer); if (data->source != NULL) { + g_source_destroy(data->source); vir_g_source_unref(data->source, NULL); - g_clear_pointer(&data->source, g_source_destroy); + data->source = NULL; } /* since the actual timeout deletion is done asynchronously, a timeoutUpdate call may -- 2.36.1

2 3

[PATCH 0/2] Two <interface type='direct'/> related fixes
by Michal Privoznik 13 Jun '22

13 Jun '22

Except not really. Only the first one is strictly related to that type of <interface/>. The other one fixes a regression introduced in 8.4.0 and it just so happens that I'm able to reproduce it 100% on my (SRIOV-less) machine. Michal Prívozník (2): virNetDevSaveNetConfig: Pass mode to virFileWriteStr() qemuBuildInterfaceConnect: Initialize @tapfd array src/qemu/qemu_command.c | 2 ++ src/util/virnetdev.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) -- 2.35.1

4 7

[PATCH] spec: Xen arches have changed on Fedora 36+
by Cole Robinson 13 Jun '22

13 Jun '22

Latest fedora 36+ xen builds have dropped i686 and armv7hl builds. Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- libvirt.spec.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index 59d2f96709..c4ea02fc8e 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -21,6 +21,9 @@ %define arches_systemtap_64bit %{arches_64bit} %define arches_dmidecode %{arches_x86} %define arches_xen %{arches_x86} aarch64 +%if 0%{?fedora} >= 36 +%define arches_xen x86_64 aarch64 +%endif %define arches_vbox %{arches_x86} %define arches_ceph %{arches_64bit} %define arches_zfs %{arches_x86} %{power64} %{arm} -- 2.36.1

2 4

[PATCH] kbase: launch_security_sev: Break up overly long line
by Peter Krempa 13 Jun '22

13 Jun '22

Standard text is aligned to 80 colums in all .rst files. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- Pushed as trivial. docs/kbase/launch_security_sev.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/kbase/launch_security_sev.rst b/docs/kbase/launch_security_sev.rst index 51b3e14dbf..2734832487 100644 --- a/docs/kbase/launch_security_sev.rst +++ b/docs/kbase/launch_security_sev.rst @@ -295,9 +295,9 @@ In order to make virtio devices work, we need to use ``<driver iommu='on'/>`` inside the given device XML element in order to enable DMA API in the virtio driver. -Starting with QEMU 6.0.0 QEMU will set this for us by default. For earlier versions though, you will need to explicitly enable this in the device XML as follows: - -:: +Starting with QEMU 6.0.0 QEMU will set this for us by default. For earlier +versions though, you will need to explicitly enable this in the device XML as +follows:: # virsh edit <domain> <domain> -- 2.36.1

1 0

[libvirt PATCH 0/2] qemu: virtiofs: add --thread-pool-size option
by Ján Tomko 13 Jun '22

13 Jun '22

Ján Tomko (2): conf: virtiofs: add thread_pool element qemu: virtiofs: format --thread-pool-size docs/formatdomain.rst | 6 ++++++ src/conf/domain_conf.c | 14 ++++++++++++++ src/conf/domain_conf.h | 1 + src/conf/schemas/domaincommon.rng | 9 +++++++++ src/qemu/qemu_virtiofs.c | 4 ++++ tests/qemuxml2argvdata/vhost-user-fs-fd-memory.xml | 1 + 6 files changed, 35 insertions(+) -- 2.35.1

2 4

[PATCH] docs: kbase/launch_security_sev: QEMU 6.0+ sets iommu=on for us
by Cole Robinson 13 Jun '22

13 Jun '22

Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- docs/kbase/launch_security_sev.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/kbase/launch_security_sev.rst b/docs/kbase/launch_security_sev.rst index 3ebb01ad80..9f6330a1ca 100644 --- a/docs/kbase/launch_security_sev.rst +++ b/docs/kbase/launch_security_sev.rst @@ -295,6 +295,8 @@ In order to make virtio devices work, we need to use ``<driver iommu='on'/>`` inside the given device XML element in order to enable DMA API in the virtio driver. +QEMU 6.0 and later will `set this by default <https://gitlab.com/qemu-project/qemu/-/commit/9f88a7a3df>`__. For earlier QEMU versions, you will need to explicitly enable this in the device XML: + :: # virsh edit <domain> -- 2.36.1

2 2

[libvirt PATCH] util: Fix error reporting in virProcessSetMaxMemLock
by Jiri Denemark 10 Jun '22

10 Jun '22

Commit v7.1.0-136-g6a6d6bb520 refactored virProcessSetMaxMemLock by moving its part into a new virProcessSetLimit, but lost "return -1" on error; Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/util/virprocess.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/virprocess.c b/src/util/virprocess.c index 5ed0b5d0db..013afd91b4 100644 --- a/src/util/virprocess.c +++ b/src/util/virprocess.c @@ -926,6 +926,7 @@ virProcessSetMaxMemLock(pid_t pid, unsigned long long bytes) _("cannot limit locked memory " "of process %lld to %llu"), (long long int)pid, bytes); + return -1; } VIR_DEBUG("Locked memory for process %lld limited to %llu bytes", -- 2.35.1

2 2

[libvirt PATCH 0/3] firmware: Small fixes and cleanups
by Andrea Bolognani 10 Jun '22

10 Jun '22

Andrea Bolognani (3): vmx: Declare support for firmware autoselection conf: Fix virDomainDefOSValidate() qemu: Simplify handling of virTristateBool values src/conf/domain_validate.c | 6 +++--- src/qemu/qemu_firmware.c | 38 ++++++++++++++++---------------------- src/vmx/vmx.c | 1 + 3 files changed, 20 insertions(+), 25 deletions(-) -- 2.35.3

2 4

[libvirt PATCH v2 0/7] ci: Drop Fedora 34, add Fedora 36
by Andrea Bolognani 09 Jun '22

09 Jun '22

Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/548848259 Only patches 1-5 should be pushed until the issues outlined in https://listman.redhat.com/archives/libvir-list/2022-May/231851.html have been addressed. Changes from [v1] * handle integration tests separately; * don't stop publishing RPMs from the Fedora 35 job [v1] https://listman.redhat.com/archives/libvir-list/2022-May/231838.html Andrea Bolognani (7): ci: Drop Fedora 34 ci: Refresh generated files ci: Add Fedora 36 ci: Move MinGW jobs to Fedora 36 ci: Don't mark any Fedora 36 job as optional ci: Add Fedora 36 to integration tests ci: Move upstream QEMU integration test to Fedora 36 ...ile => fedora-36-cross-mingw32.Dockerfile} | 2 +- ...ile => fedora-36-cross-mingw64.Dockerfile} | 2 +- ...ora-34.Dockerfile => fedora-36.Dockerfile} | 3 +- ci/gitlab.yml | 767 +----------------- ci/gitlab/build-templates.yml | 45 + ci/gitlab/builds.yml | 406 +++++++++ ci/gitlab/container-templates.yml | 52 ++ ci/gitlab/containers.yml | 325 ++++++++ ci/gitlab/sanity-checks.yml | 18 + ci/integration.yml | 24 +- ci/manifest.yml | 5 +- 11 files changed, 869 insertions(+), 780 deletions(-) rename ci/containers/{fedora-35-cross-mingw32.Dockerfile => fedora-36-cross-mingw32.Dockerfile} (98%) rename ci/containers/{fedora-35-cross-mingw64.Dockerfile => fedora-36-cross-mingw64.Dockerfile} (98%) rename ci/containers/{fedora-34.Dockerfile => fedora-36.Dockerfile} (97%) create mode 100644 ci/gitlab/build-templates.yml create mode 100644 ci/gitlab/builds.yml create mode 100644 ci/gitlab/container-templates.yml create mode 100644 ci/gitlab/containers.yml create mode 100644 ci/gitlab/sanity-checks.yml -- 2.35.3

2 17

[libvirt PATCH 0/2] ci: Fixes to enable upstream QEMU integration tests on Fedora 36
by Erik Skultety 09 Jun '22

09 Jun '22

- CVE-2022-24765 handling (>= git-2.35.2) - SELinux relabel the QEMU installation from source Successful pipeline: https://gitlab.com/eskultety/libvirt/-/pipelines/557712098 Erik Skultety (2): ci: integration: SELinux relabel the QEMU we installed from git ci: integration: Set 'safe.directory' when installing QEMU from git ci/integration-template.yml | 6 ++++++ 1 file changed, 6 insertions(+) -- 2.36.1

3 9

[Questions] non-shared disk migration: jobs abort and bandwidth
by Han Han 09 Jun '22

09 Jun '22

Hi developers, Recently, I am researching migration with non-share disk(flags VIR_MIGRATE_NON_SHARED_DISK and VIR_MIGRATE_NON_SHARED_INC). As we know, the non-shared disk migration could have block jobs to copy the disk image from the src host to the dst host. So here are my questions for non-shared disk migration: q1. For the API virDomainMigrate3 with the bandwidth param, could it set the bandwidth of block jobs? q2. For the API virDomainMigrateSetMaxSpeed, could it set the bandwidth of block jobs? q3. For the domain job abort API virDomainAbortJob, could it stop the block job of non-shared disk migration? q4. For the block job bandwidth API virDomainBlockJobSetSpeed, could it set the block job of non-shared disk migration? q5. For the block job abort API virDomainBlockJobAbort, could it stop the block job of non-shared disk migration? Then I got the test results of libvirt-8.4.0-1.el9.x86_64 qemu-kvm-7.0.0-4.el9.x86_64: q1: The bandwidth limit of virDomainMigrate3 is effective to the blockjob: ➜ ~ virsh migrate OVMF qemu+ssh://root@hhan-rhel9--1/system --live --p2p --tls --tls-destination hhan-rhel9--1 --copy-storage-all --disks-uri tcp://hhan-rhel9--1:49156 --bandwidth 2 ➜ ~ virsh blockjob OVMF vda Block Copy: [ 0 %] Bandwidth limit: 2097152 bytes/s (2.000 MiB/s) q2: The virDomainMigrateSetMaxSpeed doesn't change the the bandwidth of block jobs. ➜ ~ virsh migrate-setspeed OVMF 8 ➜ ~ virsh blockjob OVMF vda Block Copy: [ 9 %] Bandwidth limit: 2097152 bytes/s (2.000 MiB/s) q3: The virDomainAbortJob could stop a block job of non-shared disk migration ➜ ~ virsh migrate OVMF qemu+ssh://root@hhan-rhel9--1/system --live --p2p --tls --tls-destination hhan-rhel9--1 --copy-storage-all --disks-uri tcp://hhan-rhel9--1:49156 --bandwidth 2 Then start a virsh event on another terminal: ➜ ~ virsh event --loop --all Abort the domain job: ➜ ~ virsh domjobabort OVMF The error "error: operation aborted: migration out: canceled by client" appears at the terminal of "virsh migrate" The terminal of "virsh event" shows the block job has been failed: event 'block-job' for domain 'OVMF': Block Copy for /var/lib/libvirt/images/OVMF.qcow2 failed event 'block-job-2' for domain 'OVMF': Block Copy for vda failed q4: The block job bandwidth of non-shared disk migration cannot be set by virDomainBlockJobSetSpeed: ➜ ~ virsh blockjob OVMF vda --bandwidth 10 error: Timed out during operation: cannot acquire state change lock (held by monitor=remoteDispatchDomainMigratePerform3Params) q5: The block job of non-shared disk migration cannot be aborted by virDomainBlockJobAbort: ➜ ~ virsh blockjob OVMF vda --abort error: Timed out during operation: cannot acquire state change lock (held by monitor=remoteDispatchDomainMigratePerform3Params) Are the results above expected? Here are my personal thoughts: For the bandwidth in q1 and q2, they are commented as migration bandwidth( https://gitlab.com/libvirt/libvirt/-/blob/master/include/libvirt/libvirt-do… , https://gitlab.com/libvirt/libvirt/-/blob/master/src/libvirt-domain.c#L9696 ), but one works for block jobs while one doesn't. So we should make the comment clear whether they are the bandwidth of VM migration or the bandwidth of migration with blockjobs. What's more, add a flag to virDomainMigrateMaxSpeedFlags to support set bandwidth to the blockjobs in migration. For q4 and q5, if we will not support to change the block job of non-shared disk migration by blockjob APIs, we should note that in the migration doc or the block job doc, to present the difference between this type of block job and the others.

2 2

[PATCH v2 00/15] qemu: Allow setting EventLoopBaseProperties
by Michal Privoznik 08 Jun '22

08 Jun '22

v2 of: https://listman.redhat.com/archives/libvir-list/2022-June/232118.html diff to v1: - switched from <mainloop/> to <defaultiothread/> - switched from long long to int for pool sizes (this means that the 02/16 patch from the original series that introduced virXMLPropLongLong() is no longer needed and thus not in this series). - Extended some docs - Hopefully, I've worked in all Peter's review points. Michal Prívozník (15): virml: Introduce VIR_XML_PROP_NONNEGATIVE flag virDomainDefParseIOThreads: Use g_autoptr() for @iothrid virDomainIOThreadIDDefArrayInit: Decrease scope of @iothrid conf: Move iothread formatter into a separate function conf: Introduce allocator for virDomainIOThreadIDDef conf: Introduce pool_min and pool_max attributes to IOThread qemu: Introduce QEMU_CAPS_IOTHREAD_THREAD_POOL_MAX qemu_validate: Check if QEMU's capable of setting iothread pool size qemu: Generate command line for IOThread pool size include: Introduce typed params for virDomainSetIOThreadParams wrt pool size qemu: Wire up new virDomainSetIOThreadParams parameters virsh: Wire up new virDomainSetIOThreadParams parameters conf: Expose QEMU's main loop object qemu_validate: Check if QEMU's capable of setting main loop pool size qemu: Generate command line for main-loop pool size docs/formatdomain.rst | 14 +- docs/manpages/virsh.rst | 7 +- include/libvirt/libvirt-domain.h | 22 +++ src/conf/domain_conf.c | 162 +++++++++++++++--- src/conf/domain_conf.h | 11 ++ src/conf/schemas/domaincommon.rng | 25 +++ src/conf/virconftypes.h | 2 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 26 ++- src/qemu/qemu_driver.c | 62 ++++++- src/qemu/qemu_monitor.h | 4 + src/qemu/qemu_monitor_json.c | 2 + src/qemu/qemu_validate.c | 33 ++++ src/util/virxml.c | 7 + src/util/virxml.h | 3 + .../caps_7.1.0.x86_64.xml | 1 + ...othreads-ids-pool-sizes.x86_64-latest.args | 45 +++++ .../iothreads-ids-pool-sizes.xml | 62 +++++++ tests/qemuxml2argvtest.c | 1 + ...iothreads-ids-pool-sizes.x86_64-latest.xml | 1 + tests/qemuxml2xmltest.c | 1 + tools/virsh-domain.c | 24 ++- 23 files changed, 480 insertions(+), 38 deletions(-) create mode 100644 tests/qemuxml2argvdata/iothreads-ids-pool-sizes.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/iothreads-ids-pool-sizes.xml create mode 120000 tests/qemuxml2xmloutdata/iothreads-ids-pool-sizes.x86_64-latest.xml -- 2.35.1

3 27

[PATCH] virsh: Check whether enough arguments was passed to iothreadset
by Michal Privoznik 08 Jun '22

08 Jun '22

Virsh has iothreadset command which allows setting various attributes of IOThreads. However, when the command is called without any arguments (besides domain and IOThread IDs), then @params stays NULL and is passed to virDomainSetIOThreadParams() which produces rather user unfriendly error message: error: params in virDomainSetIOThreadParams must not be NULL Introduce a check and produce better error message. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tools/virsh-domain.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 5c4a7d7b8d..cfdaac1942 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -7853,6 +7853,11 @@ cmdIOThreadSet(vshControl *ctl, const vshCmd *cmd) #undef VSH_IOTHREAD_SET_UINT_PARAMS + if (nparams == 0) { + vshError(ctl, _("Not enough arguments passed, nothing to set")); + goto cleanup; + } + if (virDomainSetIOThreadParams(dom, id, params, nparams, flags) < 0) goto cleanup; -- 2.35.1

4 3

[PATCH v2 00/30] Remove some unused includes
by Peng Liang 08 Jun '22

08 Jun '22

2 38

[libvirt PATCH] qemu: Improve error messages using qemuMigrationJobName
by Jiri Denemark 08 Jun '22

08 Jun '22

They were constructed from two separate strings using "%s: %s", which is ugly and does not work well with translations. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_migration.c | 52 ++++++++++++++++++++++----------------- 1 file changed, 30 insertions(+), 22 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 341395ac6d..849c25b168 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -1847,24 +1847,23 @@ qemuMigrationJobName(virDomainObj *vm) switch (priv->job.asyncJob) { case VIR_ASYNC_JOB_MIGRATION_OUT: - return _("migration out job"); + return _("migration out"); case VIR_ASYNC_JOB_SAVE: - return _("domain save job"); + return _("domain save"); case VIR_ASYNC_JOB_DUMP: - return _("domain core dump job"); - case VIR_ASYNC_JOB_NONE: - return _("undefined"); + return _("domain core dump"); case VIR_ASYNC_JOB_MIGRATION_IN: - return _("migration in job"); + return _("migration in"); case VIR_ASYNC_JOB_SNAPSHOT: - return _("snapshot job"); + return _("snapshot"); case VIR_ASYNC_JOB_START: - return _("start job"); + return _("start"); case VIR_ASYNC_JOB_BACKUP: - return _("backup job"); + return _("backup"); + case VIR_ASYNC_JOB_NONE: case VIR_ASYNC_JOB_LAST: default: - return _("job"); + return _("undefined"); } } @@ -1888,25 +1887,33 @@ qemuMigrationJobCheckStatus(virQEMUDriver *driver, switch (jobData->status) { case VIR_DOMAIN_JOB_STATUS_NONE: - virReportError(VIR_ERR_OPERATION_FAILED, _("%s: %s"), - qemuMigrationJobName(vm), _("is not active")); + virReportError(VIR_ERR_OPERATION_FAILED, + _("job '%s' is not active"), + qemuMigrationJobName(vm)); return -1; case VIR_DOMAIN_JOB_STATUS_FAILED: - virReportError(VIR_ERR_OPERATION_FAILED, _("%s: %s"), - qemuMigrationJobName(vm), - error ? error : _("unexpectedly failed")); + if (error) { + virReportError(VIR_ERR_OPERATION_FAILED, + _("job '%s' failed: %s"), + qemuMigrationJobName(vm), error); + } else { + virReportError(VIR_ERR_OPERATION_FAILED, + _("job '%s' unexpectedly failed"), + qemuMigrationJobName(vm)); + } return -1; case VIR_DOMAIN_JOB_STATUS_CANCELED: - virReportError(VIR_ERR_OPERATION_ABORTED, _("%s: %s"), - qemuMigrationJobName(vm), _("canceled by client")); + virReportError(VIR_ERR_OPERATION_ABORTED, + _("job '%s' canceled by client"), + qemuMigrationJobName(vm)); return -1; case VIR_DOMAIN_JOB_STATUS_POSTCOPY_PAUSED: - virReportError(VIR_ERR_OPERATION_FAILED, _("%s: %s"), - qemuMigrationJobName(vm), - _("post-copy phase failed")); + virReportError(VIR_ERR_OPERATION_FAILED, + _("job '%s' failed in post-copy phase"), + qemuMigrationJobName(vm)); return -1; case VIR_DOMAIN_JOB_STATUS_COMPLETED: @@ -1959,8 +1966,9 @@ qemuMigrationAnyCompleted(virQEMUDriver *driver, if (flags & QEMU_MIGRATION_COMPLETED_ABORT_ON_ERROR && virDomainObjGetState(vm, &pauseReason) == VIR_DOMAIN_PAUSED && pauseReason == VIR_DOMAIN_PAUSED_IOERROR) { - virReportError(VIR_ERR_OPERATION_FAILED, _("%s: %s"), - qemuMigrationJobName(vm), _("failed due to I/O error")); + virReportError(VIR_ERR_OPERATION_FAILED, + _("job '%s' failed due to I/O error"), + qemuMigrationJobName(vm)); goto error; } -- 2.35.1

2 1

[PATCH 00/16] qemu: Allow setting EventLoopBaseProperties
by Michal Privoznik 07 Jun '22

07 Jun '22

QEMU introduced a way to set minimal and maximal number of worker threads for its worker thread pools. Currently, only IOThreads and main loop pools have this ability. Nevertheless, setting these boundaries (and basically making QEMU spawn enough threads upfront) is crucial for real-time workloads where having to spawn a thread may lead to missing the time limit. Michal Prívozník (16): virml: Introduce VIR_XML_PROP_NONNEGATIVE flag virxml: Introduce virXMLPropLongLong() virDomainDefParseIOThreads: Use g_autoptr() for @iothrid virDomainIOThreadIDDefArrayInit: Decrease scope of @iothrid conf: Move iothread formatter into a separate function conf: Introduce allocator for virDomainIOThreadIDDef conf: Introduce pool_min and pool_max attributes to IOThread qemu: Introduce QEMU_CAPS_IOTHREAD_THREAD_POOL_MAX qemu_validate: Check if QEMU's capable of setting iothread pool size qemu: Generate command line for IOThread pool size include: Introduce typed params for virDomainSetIOThreadParams wrt pool size qemu: Wire up new virDomainSetIOThreadParams parameters virsh: Wire up new virDomainSetIOThreadParams parameters conf: Expose QEMU's main loop object qemu_validate: Check if QEMU's capable of setting main loop pool size qemu: Generate command line for main-loop pool size docs/formatdomain.rst | 11 +- docs/manpages/virsh.rst | 7 +- include/libvirt/libvirt-domain.h | 18 ++ src/conf/domain_conf.c | 154 +++++++++++++++--- src/conf/domain_conf.h | 11 ++ src/conf/schemas/domaincommon.rng | 25 +++ src/conf/virconftypes.h | 2 + src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 48 +++++- src/qemu/qemu_driver.c | 63 ++++++- src/qemu/qemu_monitor.h | 4 + src/qemu/qemu_monitor_json.c | 2 + src/qemu/qemu_validate.c | 44 +++++ src/util/virxml.c | 69 ++++++++ src/util/virxml.h | 12 ++ .../caps_7.1.0.x86_64.xml | 1 + ...othreads-ids-pool-sizes.x86_64-latest.args | 45 +++++ .../iothreads-ids-pool-sizes.xml | 62 +++++++ tests/qemuxml2argvtest.c | 1 + ...iothreads-ids-pool-sizes.x86_64-latest.xml | 1 + tests/qemuxml2xmltest.c | 1 + tools/virsh-domain.c | 24 ++- 24 files changed, 575 insertions(+), 34 deletions(-) create mode 100644 tests/qemuxml2argvdata/iothreads-ids-pool-sizes.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/iothreads-ids-pool-sizes.xml create mode 120000 tests/qemuxml2xmloutdata/iothreads-ids-pool-sizes.x86_64-latest.xml -- 2.35.1

4 37

[PATCH] qemucapabilitiestest: Update latest caps to 'v7.0.0-1512-gca127b3fc2'
by Peter Krempa 07 Jun '22

07 Jun '22

Notable changes: - Icelake-Client cpu model family removed: "Icelake-Client-noTSX-x86_64-cpu" "Icelake-Client-v1-x86_64-cpu" "Icelake-Client-v2-x86_64-cpu" "Icelake-Client-v3-x86_64-cpu" "Icelake-Client-x86_64-cpu" - 'zero-copy-send' migration feature added - display 'sdl' qapified - 'arch-lbr' cpu feature added - new HyperV enlightenments: 'hv-tlbflush-ext' 'hv-tlbflush-direct' 'hv-emsr-bitmap' 'hv-xmm-input' - 'none-machine' has two new properties: - "boot" described as "Boot configuration" - "memory" described as "Memory size configuration" - 'igd-passthrough-isa-bridge' is now Xen-only - CXL: Compute eXpress Link related devices: "CXL" "cxl-rp", "cxl-type3", "pxb-cxl", "pxb-cxl-bus", "pxb-cxl-host", - 'dma-translation' feature of 'intel-iommu' - 'vmcb-clean' cpu feature now migratable: - possibly due to host kernel upgrade - changes commandline generated for the 'cpu-host-model' case of qemuxml2argvtest Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- .../domaincapsdata/qemu_7.1.0-q35.x86_64.xml | 3 +- .../domaincapsdata/qemu_7.1.0-tcg.x86_64.xml | 2 - tests/domaincapsdata/qemu_7.1.0.x86_64.xml | 3 +- .../caps_7.1.0.x86_64.replies | 2369 ++++++++--------- .../caps_7.1.0.x86_64.xml | 215 +- .../cpu-host-model.x86_64-latest.args | 2 +- 6 files changed, 1096 insertions(+), 1498 deletions(-) diff --git a/tests/domaincapsdata/qemu_7.1.0-q35.x86_64.xml b/tests/domaincapsdata/qemu_7.1.0-q35.x86_64.xml index c1df755463..4e96c5104a 100644 --- a/tests/domaincapsdata/qemu_7.1.0-q35.x86_64.xml +++ b/tests/domaincapsdata/qemu_7.1.0-q35.x86_64.xml @@ -57,6 +57,7 @@ <feature policy='require' name='amd-ssbd'/> <feature policy='require' name='virt-ssbd'/> <feature policy='require' name='tsc-scale'/> + <feature policy='require' name='vmcb-clean'/> <feature policy='require' name='svme-addr-chk'/> <feature policy='require' name='rdctl-no'/> <feature policy='require' name='skip-l1dfl-vmentry'/> @@ -99,8 +100,6 @@ <model usable='no'>IvyBridge</model> <model usable='no'>Icelake-Server-noTSX</model> <model usable='no'>Icelake-Server</model> - <model usable='no' deprecated='yes'>Icelake-Client-noTSX</model> - <model usable='no' deprecated='yes'>Icelake-Client</model> <model usable='no'>Haswell-noTSX-IBRS</model> <model usable='no'>Haswell-noTSX</model> <model usable='no'>Haswell-IBRS</model> diff --git a/tests/domaincapsdata/qemu_7.1.0-tcg.x86_64.xml b/tests/domaincapsdata/qemu_7.1.0-tcg.x86_64.xml index 9cb254cac6..46542c8b5b 100644 --- a/tests/domaincapsdata/qemu_7.1.0-tcg.x86_64.xml +++ b/tests/domaincapsdata/qemu_7.1.0-tcg.x86_64.xml @@ -112,8 +112,6 @@ <model usable='no'>IvyBridge</model> <model usable='no'>Icelake-Server-noTSX</model> <model usable='no'>Icelake-Server</model> - <model usable='no' deprecated='yes'>Icelake-Client-noTSX</model> - <model usable='no' deprecated='yes'>Icelake-Client</model> <model usable='no'>Haswell-noTSX-IBRS</model> <model usable='no'>Haswell-noTSX</model> <model usable='no'>Haswell-IBRS</model> diff --git a/tests/domaincapsdata/qemu_7.1.0.x86_64.xml b/tests/domaincapsdata/qemu_7.1.0.x86_64.xml index dcadb1c279..02b43e318f 100644 --- a/tests/domaincapsdata/qemu_7.1.0.x86_64.xml +++ b/tests/domaincapsdata/qemu_7.1.0.x86_64.xml @@ -56,6 +56,7 @@ <feature policy='require' name='amd-ssbd'/> <feature policy='require' name='virt-ssbd'/> <feature policy='require' name='tsc-scale'/> + <feature policy='require' name='vmcb-clean'/> <feature policy='require' name='svme-addr-chk'/> <feature policy='require' name='rdctl-no'/> <feature policy='require' name='skip-l1dfl-vmentry'/> @@ -98,8 +99,6 @@ <model usable='no'>IvyBridge</model> <model usable='no'>Icelake-Server-noTSX</model> <model usable='no'>Icelake-Server</model> - <model usable='no' deprecated='yes'>Icelake-Client-noTSX</model> - <model usable='no' deprecated='yes'>Icelake-Client</model> <model usable='no'>Haswell-noTSX-IBRS</model> <model usable='no'>Haswell-noTSX</model> <model usable='no'>Haswell-IBRS</model> diff --git a/tests/qemucapabilitiesdata/caps_7.1.0.x86_64.replies b/tests/qemucapabilitiesdata/caps_7.1.0.x86_64.replies index 8444825cb7..61123d2d10 100644 --- a/tests/qemucapabilitiesdata/caps_7.1.0.x86_64.replies +++ b/tests/qemucapabilitiesdata/caps_7.1.0.x86_64.replies @@ -21,7 +21,7 @@ "minor": 0, "major": 7 }, - "package": "v7.0.0-930-g178bacb66d" + "package": "v7.0.0-1512-gca127b3fc2" }, "id": "libvirt-2" } @@ -4378,15 +4378,15 @@ }, { "name": "multicast", - "type": "333" + "type": "336" }, { "name": "unicast", - "type": "333" + "type": "336" }, { "name": "vlan", - "type": "333" + "type": "336" }, { "name": "broadcast-allowed", @@ -4562,11 +4562,11 @@ }, { "name": "duplex", - "type": "334" + "type": "337" }, { "name": "autoneg", - "type": "335" + "type": "338" } ], "meta-type": "object" @@ -4604,15 +4604,15 @@ }, { "name": "key", - "type": "336" + "type": "339" }, { "name": "mask", - "type": "337" + "type": "340" }, { "name": "action", - "type": "338" + "type": "341" } ], "meta-type": "object" @@ -4770,7 +4770,7 @@ }, { "name": "options", - "type": "339" + "type": "342" } ], "meta-type": "object" @@ -4781,7 +4781,7 @@ "variants": [ { "case": "vnc", - "type": "342" + "type": "345" }, { "case": "spice", @@ -4791,7 +4791,7 @@ "members": [ { "name": "protocol", - "type": "340" + "type": "343" }, { "name": "password", @@ -4800,7 +4800,7 @@ { "name": "connected", "default": null, - "type": "341" + "type": "344" } ], "meta-type": "object" @@ -4811,7 +4811,7 @@ "variants": [ { "case": "vnc", - "type": "343" + "type": "346" }, { "case": "spice", @@ -4821,7 +4821,7 @@ "members": [ { "name": "protocol", - "type": "340" + "type": "343" }, { "name": "time", @@ -4850,7 +4850,7 @@ { "name": "format", "default": null, - "type": "344" + "type": "347" } ], "meta-type": "object" @@ -4893,12 +4893,12 @@ }, { "name": "mouse-mode", - "type": "345" + "type": "348" }, { "name": "channels", "default": null, - "type": "[346]" + "type": "[349]" } ], "meta-type": "object" @@ -4908,11 +4908,11 @@ "members": [ { "name": "server", - "type": "347" + "type": "350" }, { "name": "client", - "type": "347" + "type": "350" } ], "meta-type": "object" @@ -4922,11 +4922,11 @@ "members": [ { "name": "server", - "type": "348" + "type": "351" }, { "name": "client", - "type": "346" + "type": "349" } ], "meta-type": "object" @@ -4936,11 +4936,11 @@ "members": [ { "name": "server", - "type": "347" + "type": "350" }, { "name": "client", - "type": "347" + "type": "350" } ], "meta-type": "object" @@ -4960,7 +4960,7 @@ { "name": "family", "default": null, - "type": "349" + "type": "352" }, { "name": "service", @@ -4975,7 +4975,7 @@ { "name": "clients", "default": null, - "type": "[350]" + "type": "[353]" } ], "meta-type": "object" @@ -4994,20 +4994,20 @@ }, { "name": "server", - "type": "[351]" + "type": "[354]" }, { "name": "clients", - "type": "[350]" + "type": "[353]" }, { "name": "auth", - "type": "352" + "type": "355" }, { "name": "vencrypt", "default": null, - "type": "353" + "type": "356" }, { "name": "display", @@ -5032,11 +5032,11 @@ "members": [ { "name": "server", - "type": "354" + "type": "357" }, { "name": "client", - "type": "355" + "type": "358" } ], "meta-type": "object" @@ -5046,11 +5046,11 @@ "members": [ { "name": "server", - "type": "354" + "type": "357" }, { "name": "client", - "type": "350" + "type": "353" } ], "meta-type": "object" @@ -5060,11 +5060,11 @@ "members": [ { "name": "server", - "type": "354" + "type": "357" }, { "name": "client", - "type": "350" + "type": "353" } ], "meta-type": "object" @@ -5101,7 +5101,7 @@ "members": [ { "name": "keys", - "type": "[356]" + "type": "[359]" }, { "name": "hold-time", @@ -5126,7 +5126,7 @@ }, { "name": "events", - "type": "[357]" + "type": "[360]" } ], "meta-type": "object" @@ -5137,26 +5137,26 @@ "variants": [ { "case": "curses", - "type": "362" + "type": "365" }, { "case": "egl-headless", - "type": "363" + "type": "366" }, { "case": "dbus", - "type": "364" + "type": "367" }, { - "case": "default", - "type": "0" + "case": "sdl", + "type": "368" }, { - "case": "none", + "case": "default", "type": "0" }, { - "case": "sdl", + "case": "none", "type": "0" }, { @@ -5167,7 +5167,7 @@ "members": [ { "name": "type", - "type": "358" + "type": "361" }, { "name": "full-screen", @@ -5187,7 +5187,7 @@ { "name": "gl", "default": null, - "type": "359" + "type": "362" } ], "meta-type": "object" @@ -5198,13 +5198,13 @@ "variants": [ { "case": "vnc", - "type": "366" + "type": "370" } ], "members": [ { "name": "type", - "type": "365" + "type": "369" } ], "meta-type": "object" @@ -5215,13 +5215,13 @@ "variants": [ { "case": "vnc", - "type": "368" + "type": "372" } ], "members": [ { "name": "type", - "type": "367" + "type": "371" } ], "meta-type": "object" @@ -5232,27 +5232,27 @@ { "name": "status", "default": null, - "type": "369" + "type": "373" }, { "name": "ram", "default": null, - "type": "370" + "type": "374" }, { "name": "disk", "default": null, - "type": "370" + "type": "374" }, { "name": "vfio", "default": null, - "type": "371" + "type": "375" }, { "name": "xbzrle-cache", "default": null, - "type": "372" + "type": "376" }, { "name": "total-time", @@ -5302,12 +5302,12 @@ { "name": "compression", "default": null, - "type": "373" + "type": "377" }, { "name": "socket-address", "default": null, - "type": "[374]" + "type": "[378]" } ], "meta-type": "object" @@ -5332,7 +5332,7 @@ "members": [ { "name": "capability", - "type": "375" + "type": "379" }, { "name": "state", @@ -5465,7 +5465,7 @@ { "name": "multifd-compression", "default": null, - "type": "376" + "type": "380" }, { "name": "multifd-zlib-level", @@ -5477,10 +5477,15 @@ "default": null, "type": "int" }, + { + "name": "zero-copy-send", + "default": null, + "type": "bool" + }, { "name": "block-bitmap-mapping", "default": null, - "type": "[377]" + "type": "[381]" } ], "meta-type": "object" @@ -5609,7 +5614,7 @@ { "name": "multifd-compression", "default": null, - "type": "376" + "type": "380" }, { "name": "multifd-zlib-level", @@ -5621,10 +5626,15 @@ "default": null, "type": "int" }, + { + "name": "zero-copy-send", + "default": null, + "type": "bool" + }, { "name": "block-bitmap-mapping", "default": null, - "type": "[377]" + "type": "[381]" } ], "meta-type": "object" @@ -5663,7 +5673,7 @@ "members": [ { "name": "status", - "type": "369" + "type": "373" } ], "meta-type": "object" @@ -5683,11 +5693,11 @@ "members": [ { "name": "mode", - "type": "378" + "type": "382" }, { "name": "reason", - "type": "379" + "type": "383" } ], "meta-type": "object" @@ -5697,7 +5707,7 @@ "members": [ { "name": "state", - "type": "369" + "type": "373" } ], "meta-type": "object" @@ -5816,15 +5826,15 @@ "members": [ { "name": "mode", - "type": "378" + "type": "382" }, { "name": "last-mode", - "type": "378" + "type": "382" }, { "name": "reason", - "type": "379" + "type": "383" } ], "meta-type": "object" @@ -5864,7 +5874,7 @@ { "name": "mode", "default": null, - "type": "380" + "type": "384" } ], "meta-type": "object" @@ -5879,7 +5889,7 @@ }, { "name": "status", - "type": "381" + "type": "385" }, { "name": "start-time", @@ -5895,12 +5905,12 @@ }, { "name": "mode", - "type": "380" + "type": "384" }, { "name": "vcpu-dirty-rate", "default": null, - "type": "[382]" + "type": "[386]" } ], "meta-type": "object" @@ -5972,12 +5982,12 @@ "members": [ { "name": "actions", - "type": "[383]" + "type": "[387]" }, { "name": "properties", "default": null, - "type": "384" + "type": "388" } ], "meta-type": "object" @@ -6011,7 +6021,7 @@ }, { "name": "state", - "type": "385" + "type": "389" }, { "name": "vcpu", @@ -6050,7 +6060,7 @@ { "name": "enable", "default": null, - "type": "[386]" + "type": "[390]" } ], "meta-type": "object" @@ -6060,7 +6070,7 @@ "members": [ { "name": "qemu", - "type": "387" + "type": "391" }, { "name": "package", @@ -6095,31 +6105,31 @@ "variants": [ { "case": "builtin", - "type": "389" + "type": "393" }, { "case": "enum", - "type": "390" + "type": "394" }, { "case": "array", - "type": "391" + "type": "395" }, { "case": "object", - "type": "392" + "type": "396" }, { "case": "alternate", - "type": "393" + "type": "397" }, { "case": "command", - "type": "394" + "type": "398" }, { "case": "event", - "type": "395" + "type": "399" } ], "members": [ @@ -6129,7 +6139,7 @@ }, { "name": "meta-type", - "type": "388" + "type": "392" }, { "name": "features", @@ -6272,155 +6282,155 @@ "variants": [ { "case": "authz-list", - "type": "397" + "type": "401" }, { "case": "authz-listfile", - "type": "398" + "type": "402" }, { "case": "authz-pam", - "type": "399" + "type": "403" }, { "case": "authz-simple", - "type": "400" + "type": "404" }, { "case": "can-host-socketcan", - "type": "401" + "type": "405" }, { "case": "colo-compare", - "type": "402" + "type": "406" }, { "case": "cryptodev-backend", - "type": "403" + "type": "407" }, { "case": "cryptodev-backend-builtin", - "type": "403" + "type": "407" }, { "case": "cryptodev-vhost-user", - "type": "404" + "type": "408" }, { "case": "dbus-vmstate", - "type": "405" + "type": "409" }, { "case": "filter-buffer", - "type": "406" + "type": "410" }, { "case": "filter-dump", - "type": "407" + "type": "411" }, { "case": "filter-mirror", - "type": "408" + "type": "412" }, { "case": "filter-redirector", - "type": "409" + "type": "413" }, { "case": "filter-replay", - "type": "410" + "type": "414" }, { "case": "filter-rewriter", - "type": "411" + "type": "415" }, { "case": "input-barrier", - "type": "412" + "type": "416" }, { "case": "input-linux", - "type": "413" + "type": "417" }, { "case": "iothread", - "type": "414" + "type": "418" }, { "case": "main-loop", - "type": "415" + "type": "419" }, { "case": "memory-backend-epc", - "type": "416" + "type": "420" }, { "case": "memory-backend-file", - "type": "417" + "type": "421" }, { "case": "memory-backend-memfd", - "type": "418" + "type": "422" }, { "case": "memory-backend-ram", - "type": "419" + "type": "423" }, { "case": "pr-manager-helper", - "type": "420" + "type": "424" }, { "case": "qtest", - "type": "421" + "type": "425" }, { "case": "rng-builtin", - "type": "422" + "type": "426" }, { "case": "rng-egd", - "type": "423" + "type": "427" }, { "case": "rng-random", - "type": "424" + "type": "428" }, { "case": "secret", - "type": "425" + "type": "429" }, { "case": "secret_keyring", - "type": "426" + "type": "430" }, { "case": "sev-guest", - "type": "427" + "type": "431" }, { "case": "throttle-group", - "type": "428" + "type": "432" }, { "case": "tls-creds-anon", - "type": "429" + "type": "433" }, { "case": "tls-creds-psk", - "type": "430" + "type": "434" }, { "case": "tls-creds-x509", - "type": "431" + "type": "435" }, { "case": "tls-cipher-suites", - "type": "432" + "type": "436" }, { "case": "x-remote-object", - "type": "433" + "type": "437" }, { "case": "can-bus", @@ -6438,7 +6448,7 @@ "members": [ { "name": "qom-type", - "type": "396" + "type": "400" }, { "name": "id", @@ -6538,7 +6548,7 @@ "variants": [ { "case": "s390x", - "type": "436" + "type": "440" }, { "case": "aarch64", @@ -6673,11 +6683,11 @@ { "name": "props", "default": null, - "type": "434" + "type": "438" }, { "name": "target", - "type": "435" + "type": "439" } ], "meta-type": "object" @@ -6748,7 +6758,7 @@ "members": [ { "name": "arch", - "type": "435" + "type": "439" } ], "meta-type": "object" @@ -6872,7 +6882,7 @@ }, { "name": "policy", - "type": "437" + "type": "441" } ], "meta-type": "object" @@ -6895,7 +6905,7 @@ }, { "name": "props", - "type": "434" + "type": "438" }, { "name": "qom-path", @@ -6911,29 +6921,29 @@ "variants": [ { "case": "node", - "type": "439" + "type": "443" }, { "case": "dist", - "type": "440" + "type": "444" }, { "case": "cpu", - "type": "441" + "type": "445" }, { "case": "hmat-lb", - "type": "442" + "type": "446" }, { "case": "hmat-cache", - "type": "443" + "type": "447" } ], "members": [ { "name": "type", - "type": "438" + "type": "442" } ], "meta-type": "object" @@ -6994,29 +7004,29 @@ "variants": [ { "case": "dimm", - "type": "445" + "type": "449" }, { "case": "nvdimm", - "type": "445" + "type": "449" }, { "case": "virtio-pmem", - "type": "446" + "type": "450" }, { "case": "virtio-mem", - "type": "447" + "type": "451" }, { "case": "sgx-epc", - "type": "448" + "type": "452" } ], "members": [ { "name": "type", - "type": "444" + "type": "448" } ], "meta-type": "object" @@ -7069,11 +7079,11 @@ "members": [ { "name": "type", - "type": "451" + "type": "455" }, { "name": "model", - "type": "449" + "type": "453" } ], "meta-type": "object" @@ -7083,7 +7093,7 @@ "members": [ { "name": "model", - "type": "449" + "type": "453" } ], "meta-type": "object" @@ -7135,7 +7145,7 @@ "members": [ { "name": "mode", - "type": "452" + "type": "456" }, { "name": "filename", @@ -7190,11 +7200,11 @@ "variants": [ { "case": "block-node", - "type": "454" + "type": "458" }, { "case": "chardev", - "type": "455" + "type": "459" }, { "case": "migration", @@ -7204,7 +7214,7 @@ "members": [ { "name": "type", - "type": "453" + "type": "457" } ], "meta-type": "object" @@ -7373,7 +7383,7 @@ }, { "name": "fds", - "type": "[456]" + "type": "[460]" } ], "meta-type": "object" @@ -7403,7 +7413,7 @@ }, { "name": "parameters", - "type": "[457]" + "type": "[461]" } ], "meta-type": "object" @@ -7447,7 +7457,7 @@ }, { "name": "state", - "type": "458" + "type": "462" }, { "name": "handle", @@ -7559,7 +7569,7 @@ }, { "name": "sections", - "type": "[459]" + "type": "[463]" } ], "meta-type": "object" @@ -7583,7 +7593,7 @@ }, { "name": "slot-type", - "type": "460" + "type": "464" }, { "name": "source", @@ -7620,7 +7630,7 @@ }, { "name": "devices", - "type": "[461]" + "type": "[465]" } ], "meta-type": "object" @@ -7864,17 +7874,17 @@ "variants": [ { "case": "hyper-v", - "type": "463" + "type": "467" }, { "case": "s390", - "type": "464" + "type": "468" } ], "members": [ { "name": "type", - "type": "462" + "type": "466" } ], "meta-type": "object" @@ -8093,22 +8103,22 @@ }, { "name": "timed_stats", - "type": "[465]" + "type": "[469]" }, { "name": "rd_latency_histogram", "default": null, - "type": "466" + "type": "470" }, { "name": "wr_latency_histogram", "default": null, - "type": "466" + "type": "470" }, { "name": "flush_latency_histogram", "default": null, - "type": "466" + "type": "470" } ], "meta-type": "object" @@ -8119,15 +8129,15 @@ "variants": [ { "case": "file", - "type": "467" + "type": "471" }, { "case": "host_device", - "type": "467" + "type": "471" }, { "case": "nvme", - "type": "468" + "type": "472" }, { "case": "blkdebug", @@ -8547,7 +8557,7 @@ { "name": "format-specific", "default": null, - "type": "469" + "type": "473" } ], "meta-type": "object" @@ -8625,7 +8635,7 @@ }, { "name": "type", - "type": "470" + "type": "474" }, { "name": "name", @@ -8656,11 +8666,11 @@ }, { "name": "perm", - "type": "[471]" + "type": "[475]" }, { "name": "shared-perm", - "type": "[471]" + "type": "[475]" } ], "meta-type": "object" @@ -8911,7 +8921,7 @@ "members": [ { "name": "image", - "type": "472" + "type": "476" }, { "name": "config", @@ -8951,22 +8961,22 @@ { "name": "inject-error", "default": null, - "type": "[473]" + "type": "[477]" }, { "name": "set-state", "default": null, - "type": "[474]" + "type": "[478]" }, { "name": "take-child-perms", "default": null, - "type": "[471]" + "type": "[475]" }, { "name": "unshare-child-perms", "default": null, - "type": "[471]" + "type": "[475]" } ], "meta-type": "object" @@ -8976,11 +8986,11 @@ "members": [ { "name": "file", - "type": "472" + "type": "476" }, { "name": "log", - "type": "472" + "type": "476" }, { "name": "log-sector-size", @@ -9005,11 +9015,11 @@ "members": [ { "name": "test", - "type": "472" + "type": "476" }, { "name": "raw", - "type": "472" + "type": "476" } ], "meta-type": "object" @@ -9019,7 +9029,7 @@ "members": [ { "name": "image", - "type": "472" + "type": "476" } ], "meta-type": "object" @@ -9029,7 +9039,7 @@ "members": [ { "name": "file", - "type": "472" + "type": "476" } ], "meta-type": "object" @@ -9039,11 +9049,11 @@ "members": [ { "name": "file", - "type": "472" + "type": "476" }, { "name": "target", - "type": "472" + "type": "476" }, { "name": "bitmap", @@ -9058,7 +9068,7 @@ "members": [ { "name": "file", - "type": "472" + "type": "476" }, { "name": "bottom", @@ -9083,12 +9093,12 @@ { "name": "locking", "default": null, - "type": "475" + "type": "479" }, { "name": "aio", "default": null, - "type": "476" + "type": "480" }, { "name": "aio-max-batch", @@ -9212,7 +9222,7 @@ }, { "name": "server", - "type": "[374]" + "type": "[378]" }, { "name": "debug", @@ -9337,7 +9347,7 @@ "members": [ { "name": "transport", - "type": "477" + "type": "481" }, { "name": "portal", @@ -9370,7 +9380,7 @@ { "name": "header-digest", "default": null, - "type": "478" + "type": "482" }, { "name": "timeout", @@ -9385,7 +9395,7 @@ "members": [ { "name": "file", - "type": "472" + "type": "476" }, { "name": "key-secret", @@ -9400,7 +9410,7 @@ "members": [ { "name": "server", - "type": "374" + "type": "378" }, { "name": "export", @@ -9443,7 +9453,7 @@ "members": [ { "name": "server", - "type": "479" + "type": "483" }, { "name": "path", @@ -9522,7 +9532,7 @@ "members": [ { "name": "file", - "type": "472" + "type": "476" }, { "name": "prealloc-align", @@ -9542,12 +9552,12 @@ "members": [ { "name": "file", - "type": "472" + "type": "476" }, { "name": "backing", "default": null, - "type": "480" + "type": "484" }, { "name": "lazy-refcounts", @@ -9572,7 +9582,7 @@ { "name": "overlap-check", "default": null, - "type": "481" + "type": "485" }, { "name": "cache-size", @@ -9602,12 +9612,12 @@ { "name": "encrypt", "default": null, - "type": "482" + "type": "486" }, { "name": "data-file", "default": null, - "type": "472" + "type": "476" } ], "meta-type": "object" @@ -9617,17 +9627,17 @@ "members": [ { "name": "file", - "type": "472" + "type": "476" }, { "name": "backing", "default": null, - "type": "480" + "type": "484" }, { "name": "encrypt", "default": null, - "type": "483" + "type": "487" } ], "meta-type": "object" @@ -9637,12 +9647,12 @@ "members": [ { "name": "file", - "type": "472" + "type": "476" }, { "name": "backing", "default": null, - "type": "480" + "type": "484" } ], "meta-type": "object" @@ -9657,7 +9667,7 @@ }, { "name": "children", - "type": "[472]" + "type": "[476]" }, { "name": "vote-threshold", @@ -9671,7 +9681,7 @@ { "name": "read-pattern", "default": null, - "type": "484" + "type": "488" } ], "meta-type": "object" @@ -9681,7 +9691,7 @@ "members": [ { "name": "file", - "type": "472" + "type": "476" }, { "name": "offset", @@ -9725,7 +9735,7 @@ { "name": "encrypt", "default": null, - "type": "485" + "type": "489" }, { "name": "user", @@ -9735,7 +9745,7 @@ { "name": "auth-client-required", "default": null, - "type": "[486]" + "type": "[490]" }, { "name": "key-secret", @@ -9745,7 +9755,7 @@ { "name": "server", "default": null, - "type": "[487]" + "type": "[491]" } ], "meta-type": "object" @@ -9755,11 +9765,11 @@ "members": [ { "name": "file", - "type": "472" + "type": "476" }, { "name": "mode", - "type": "488" + "type": "492" }, { "name": "top-id", @@ -9774,7 +9784,7 @@ "members": [ { "name": "server", - "type": "489" + "type": "493" }, { "name": "path", @@ -9788,7 +9798,7 @@ { "name": "host-key-check", "default": null, - "type": "490" + "type": "494" } ], "meta-type": "object" @@ -9802,7 +9812,7 @@ }, { "name": "file", - "type": "472" + "type": "476" } ], "meta-type": "object" @@ -9848,59 +9858,59 @@ "variants": [ { "case": "file", - "type": "491" + "type": "495" }, { "case": "gluster", - "type": "492" + "type": "496" }, { "case": "luks", - "type": "493" + "type": "497" }, { "case": "nfs", - "type": "494" + "type": "498" }, { "case": "parallels", - "type": "495" + "type": "499" }, { "case": "qcow", - "type": "496" + "type": "500" }, { "case": "qcow2", - "type": "497" + "type": "501" }, { "case": "qed", - "type": "498" + "type": "502" }, { "case": "rbd", - "type": "499" + "type": "503" }, { "case": "ssh", - "type": "500" + "type": "504" }, { "case": "vdi", - "type": "501" + "type": "505" }, { "case": "vhdx", - "type": "502" + "type": "506" }, { "case": "vmdk", - "type": "503" + "type": "507" }, { "case": "vpc", - "type": "504" + "type": "508" }, { "case": "blkdebug", @@ -10029,11 +10039,11 @@ "variants": [ { "case": "luks", - "type": "505" + "type": "509" }, { "case": "qcow2", - "type": "506" + "type": "510" }, { "case": "blkdebug", @@ -10322,25 +10332,25 @@ "variants": [ { "case": "inet", - "type": "508" + "type": "512" }, { "case": "unix", - "type": "509" + "type": "513" }, { "case": "vsock", - "type": "510" + "type": "514" }, { "case": "fd", - "type": "511" + "type": "515" } ], "members": [ { "name": "type", - "type": "507" + "type": "511" } ], "meta-type": "object" @@ -10412,7 +10422,7 @@ "members": [ { "name": "addr", - "type": "374" + "type": "378" }, { "name": "logical-block-size", @@ -10442,7 +10452,7 @@ { "name": "allow-other", "default": null, - "type": "512" + "type": "516" } ], "meta-type": "object" @@ -10469,97 +10479,97 @@ "variants": [ { "case": "file", - "type": "514" + "type": "518" }, { "case": "serial", - "type": "515" + "type": "519" }, { "case": "parallel", - "type": "515" + "type": "519" }, { "case": "pipe", - "type": "515" + "type": "519" }, { "case": "socket", - "type": "516" + "type": "520" }, { "case": "udp", - "type": "517" + "type": "521" }, { "case": "pty", - "type": "518" + "type": "522" }, { "case": "null", - "type": "518" + "type": "522" }, { "case": "mux", - "type": "519" + "type": "523" }, { "case": "msmouse", - "type": "518" + "type": "522" }, { "case": "wctablet", - "type": "518" + "type": "522" }, { "case": "braille", - "type": "518" + "type": "522" }, { "case": "testdev", - "type": "518" + "type": "522" }, { "case": "stdio", - "type": "520" + "type": "524" }, { "case": "console", - "type": "518" + "type": "522" }, { "case": "spicevmc", - "type": "521" + "type": "525" }, { "case": "spiceport", - "type": "522" + "type": "526" }, { "case": "qemu-vdagent", - "type": "523" + "type": "527" }, { "case": "dbus", - "type": "524" + "type": "528" }, { "case": "vc", - "type": "525" + "type": "529" }, { "case": "ringbuf", - "type": "526" + "type": "530" }, { "case": "memory", - "type": "526" + "type": "530" } ], "members": [ { "name": "type", - "type": "513" + "type": "517" } ], "meta-type": "object" @@ -10769,7 +10779,7 @@ { "name": "dnssearch", "default": null, - "type": "[527]" + "type": "[531]" }, { "name": "domainname", @@ -10809,12 +10819,12 @@ { "name": "hostfwd", "default": null, - "type": "[527]" + "type": "[531]" }, { "name": "guestfwd", "default": null, - "type": "[527]" + "type": "[531]" }, { "name": "tftp-server-name", @@ -11123,7 +11133,7 @@ "meta-type": "object" }, { - "name": "333", + "name": "336", "members": [ { "name": "normal" @@ -11148,7 +11158,7 @@ "meta-type": "array" }, { - "name": "334", + "name": "337", "members": [ { "name": "half" @@ -11164,7 +11174,7 @@ ] }, { - "name": "335", + "name": "338", "members": [ { "name": "off" @@ -11180,7 +11190,7 @@ ] }, { - "name": "336", + "name": "339", "members": [ { "name": "priority", @@ -11239,7 +11249,7 @@ "meta-type": "object" }, { - "name": "337", + "name": "340", "members": [ { "name": "in-pport", @@ -11280,7 +11290,7 @@ "meta-type": "object" }, { - "name": "338", + "name": "341", "members": [ { "name": "goto-tbl", @@ -11316,16 +11326,16 @@ "meta-type": "object" }, { - "name": "339", + "name": "342", "tag": "type", "variants": [ { "case": "passthrough", - "type": "528" + "type": "532" }, { "case": "emulator", - "type": "529" + "type": "533" } ], "members": [ @@ -11337,7 +11347,7 @@ "meta-type": "object" }, { - "name": "340", + "name": "343", "members": [ { "name": "vnc" @@ -11353,7 +11363,7 @@ ] }, { - "name": "341", + "name": "344", "members": [ { "name": "keep" @@ -11373,7 +11383,7 @@ ] }, { - "name": "342", + "name": "345", "members": [ { "name": "display", @@ -11384,7 +11394,7 @@ "meta-type": "object" }, { - "name": "343", + "name": "346", "members": [ { "name": "display", @@ -11395,7 +11405,7 @@ "meta-type": "object" }, { - "name": "344", + "name": "347", "members": [ { "name": "ppm" @@ -11411,7 +11421,7 @@ ] }, { - "name": "345", + "name": "348", "members": [ { "name": "client" @@ -11431,12 +11441,12 @@ ] }, { - "name": "[346]", - "element-type": "346", + "name": "[349]", + "element-type": "349", "meta-type": "array" }, { - "name": "346", + "name": "349", "members": [ { "name": "host", @@ -11448,7 +11458,7 @@ }, { "name": "family", - "type": "349" + "type": "352" }, { "name": "connection-id", @@ -11470,7 +11480,7 @@ "meta-type": "object" }, { - "name": "347", + "name": "350", "members": [ { "name": "host", @@ -11482,13 +11492,13 @@ }, { "name": "family", - "type": "349" + "type": "352" } ], "meta-type": "object" }, { - "name": "348", + "name": "351", "members": [ { "name": "host", @@ -11500,7 +11510,7 @@ }, { "name": "family", - "type": "349" + "type": "352" }, { "name": "auth", @@ -11511,7 +11521,7 @@ "meta-type": "object" }, { - "name": "349", + "name": "352", "members": [ { "name": "ipv4" @@ -11539,12 +11549,12 @@ ] }, { - "name": "[350]", - "element-type": "350", + "name": "[353]", + "element-type": "353", "meta-type": "array" }, { - "name": "350", + "name": "353", "members": [ { "name": "host", @@ -11556,7 +11566,7 @@ }, { "name": "family", - "type": "349" + "type": "352" }, { "name": "websocket", @@ -11576,12 +11586,12 @@ "meta-type": "object" }, { - "name": "[351]", - "element-type": "351", + "name": "[354]", + "element-type": "354", "meta-type": "array" }, { - "name": "351", + "name": "354", "members": [ { "name": "host", @@ -11593,7 +11603,7 @@ }, { "name": "family", - "type": "349" + "type": "352" }, { "name": "websocket", @@ -11601,18 +11611,18 @@ }, { "name": "auth", - "type": "352" + "type": "355" }, { "name": "vencrypt", "default": null, - "type": "353" + "type": "356" } ], "meta-type": "object" }, { - "name": "352", + "name": "355", "members": [ { "name": "none" @@ -11656,7 +11666,7 @@ ] }, { - "name": "353", + "name": "356", "members": [ { "name": "plain" @@ -11700,7 +11710,7 @@ ] }, { - "name": "354", + "name": "357", "members": [ { "name": "host", @@ -11712,7 +11722,7 @@ }, { "name": "family", - "type": "349" + "type": "352" }, { "name": "websocket", @@ -11727,7 +11737,7 @@ "meta-type": "object" }, { - "name": "355", + "name": "358", "members": [ { "name": "host", @@ -11739,7 +11749,7 @@ }, { "name": "family", - "type": "349" + "type": "352" }, { "name": "websocket", @@ -11749,67 +11759,67 @@ "meta-type": "object" }, { - "name": "[356]", - "element-type": "356", + "name": "[359]", + "element-type": "359", "meta-type": "array" }, { - "name": "356", + "name": "359", "tag": "type", "variants": [ { "case": "number", - "type": "531" + "type": "535" }, { "case": "qcode", - "type": "532" + "type": "536" } ], "members": [ { "name": "type", - "type": "530" + "type": "534" } ], "meta-type": "object" }, { - "name": "[357]", - "element-type": "357", + "name": "[360]", + "element-type": "360", "meta-type": "array" }, { - "name": "357", + "name": "360", "tag": "type", "variants": [ { "case": "key", - "type": "534" + "type": "538" }, { "case": "btn", - "type": "535" + "type": "539" }, { "case": "rel", - "type": "536" + "type": "540" }, { "case": "abs", - "type": "536" + "type": "540" } ], "members": [ { "name": "type", - "type": "533" + "type": "537" } ], "meta-type": "object" }, { - "name": "358", + "name": "361", "members": [ { "name": "default" @@ -11845,7 +11855,7 @@ ] }, { - "name": "359", + "name": "362", "members": [ { "name": "off" @@ -11869,7 +11879,7 @@ ] }, { - "name": "360", + "name": "363", "members": [ { "name": "grab-on-hover", @@ -11885,7 +11895,7 @@ "meta-type": "object" }, { - "name": "361", + "name": "364", "members": [ { "name": "left-command-key", @@ -11906,7 +11916,7 @@ "meta-type": "object" }, { - "name": "362", + "name": "365", "members": [ { "name": "charset", @@ -11917,7 +11927,7 @@ "meta-type": "object" }, { - "name": "363", + "name": "366", "members": [ { "name": "rendernode", @@ -11928,7 +11938,7 @@ "meta-type": "object" }, { - "name": "364", + "name": "367", "members": [ { "name": "rendernode", @@ -11954,7 +11964,18 @@ "meta-type": "object" }, { - "name": "365", + "name": "368", + "members": [ + { + "name": "grab-mod", + "default": null, + "type": "541" + } + ], + "meta-type": "object" + }, + { + "name": "369", "members": [ { "name": "vnc" @@ -11966,7 +11987,7 @@ ] }, { - "name": "366", + "name": "370", "members": [ { "name": "tls-certs", @@ -11977,7 +11998,7 @@ "meta-type": "object" }, { - "name": "367", + "name": "371", "members": [ { "name": "vnc" @@ -11989,18 +12010,18 @@ ] }, { - "name": "368", + "name": "372", "members": [ { "name": "addresses", "default": null, - "type": "[374]" + "type": "[378]" } ], "meta-type": "object" }, { - "name": "369", + "name": "373", "members": [ { "name": "none" @@ -12064,7 +12085,7 @@ ] }, { - "name": "370", + "name": "374", "members": [ { "name": "transferred", @@ -12138,7 +12159,7 @@ "meta-type": "object" }, { - "name": "371", + "name": "375", "members": [ { "name": "transferred", @@ -12148,7 +12169,7 @@ "meta-type": "object" }, { - "name": "372", + "name": "376", "members": [ { "name": "cache-size", @@ -12182,7 +12203,7 @@ "meta-type": "object" }, { - "name": "373", + "name": "377", "members": [ { "name": "pages", @@ -12208,41 +12229,41 @@ "meta-type": "object" }, { - "name": "[374]", - "element-type": "374", + "name": "[378]", + "element-type": "378", "meta-type": "array" }, { - "name": "374", + "name": "378", "tag": "type", "variants": [ { "case": "inet", - "type": "489" + "type": "493" }, { "case": "unix", - "type": "537" + "type": "542" }, { "case": "vsock", - "type": "538" + "type": "543" }, { "case": "fd", - "type": "527" + "type": "531" } ], "members": [ { "name": "type", - "type": "507" + "type": "511" } ], "meta-type": "object" }, { - "name": "375", + "name": "379", "members": [ { "name": "xbzrle" @@ -12332,7 +12353,7 @@ ] }, { - "name": "376", + "name": "380", "members": [ { "name": "none" @@ -12352,12 +12373,12 @@ ] }, { - "name": "[377]", - "element-type": "377", + "name": "[381]", + "element-type": "381", "meta-type": "array" }, { - "name": "377", + "name": "381", "members": [ { "name": "node-name", @@ -12369,13 +12390,13 @@ }, { "name": "bitmaps", - "type": "[539]" + "type": "[544]" } ], "meta-type": "object" }, { - "name": "378", + "name": "382", "members": [ { "name": "none" @@ -12395,7 +12416,7 @@ ] }, { - "name": "379", + "name": "383", "members": [ { "name": "none" @@ -12419,7 +12440,7 @@ ] }, { - "name": "380", + "name": "384", "members": [ { "name": "page-sampling" @@ -12439,7 +12460,7 @@ ] }, { - "name": "381", + "name": "385", "members": [ { "name": "unstarted" @@ -12459,12 +12480,12 @@ ] }, { - "name": "[382]", - "element-type": "382", + "name": "[386]", + "element-type": "386", "meta-type": "array" }, { - "name": "382", + "name": "386", "members": [ { "name": "id", @@ -12478,84 +12499,84 @@ "meta-type": "object" }, { - "name": "[383]", - "element-type": "383", + "name": "[387]", + "element-type": "387", "meta-type": "array" }, { - "name": "383", + "name": "387", "tag": "type", "variants": [ { "case": "abort", - "type": "541" + "type": "546" }, { "case": "block-dirty-bitmap-add", - "type": "542" + "type": "547" }, { "case": "block-dirty-bitmap-remove", - "type": "543" + "type": "548" }, { "case": "block-dirty-bitmap-clear", - "type": "543" + "type": "548" }, { "case": "block-dirty-bitmap-enable", - "type": "543" + "type": "548" }, { "case": "block-dirty-bitmap-disable", - "type": "543" + "type": "548" }, { "case": "block-dirty-bitmap-merge", - "type": "544" + "type": "549" }, { "case": "blockdev-backup", - "type": "545" + "type": "550" }, { "case": "blockdev-snapshot", - "type": "546" + "type": "551" }, { "case": "blockdev-snapshot-internal-sync", - "type": "547" + "type": "552" }, { "case": "blockdev-snapshot-sync", - "type": "548" + "type": "553" }, { "case": "drive-backup", - "type": "549" + "type": "554" } ], "members": [ { "name": "type", - "type": "540" + "type": "545" } ], "meta-type": "object" }, { - "name": "384", + "name": "388", "members": [ { "name": "completion-mode", "default": null, - "type": "550" + "type": "555" } ], "meta-type": "object" }, { - "name": "385", + "name": "389", "members": [ { "name": "unavailable" @@ -12575,12 +12596,12 @@ ] }, { - "name": "[386]", - "element-type": "386", + "name": "[390]", + "element-type": "390", "meta-type": "array" }, { - "name": "386", + "name": "390", "members": [ { "name": "oob" @@ -12592,7 +12613,7 @@ ] }, { - "name": "387", + "name": "391", "members": [ { "name": "major", @@ -12610,7 +12631,7 @@ "meta-type": "object" }, { - "name": "388", + "name": "392", "members": [ { "name": "builtin" @@ -12646,21 +12667,21 @@ ] }, { - "name": "389", + "name": "393", "members": [ { "name": "json-type", - "type": "551" + "type": "556" } ], "meta-type": "object" }, { - "name": "390", + "name": "394", "members": [ { "name": "members", - "type": "[552]" + "type": "[557]" }, { "name": "values", @@ -12673,7 +12694,7 @@ "meta-type": "object" }, { - "name": "391", + "name": "395", "members": [ { "name": "element-type", @@ -12683,11 +12704,11 @@ "meta-type": "object" }, { - "name": "392", + "name": "396", "members": [ { "name": "members", - "type": "[553]" + "type": "[558]" }, { "name": "tag", @@ -12697,23 +12718,23 @@ { "name": "variants", "default": null, - "type": "[554]" + "type": "[559]" } ], "meta-type": "object" }, { - "name": "393", + "name": "397", "members": [ { "name": "members", - "type": "[555]" + "type": "[560]" } ], "meta-type": "object" }, { - "name": "394", + "name": "398", "members": [ { "name": "arg-type", @@ -12732,7 +12753,7 @@ "meta-type": "object" }, { - "name": "395", + "name": "399", "members": [ { "name": "arg-type", @@ -12742,7 +12763,7 @@ "meta-type": "object" }, { - "name": "396", + "name": "400", "members": [ { "name": "authz-list" @@ -12917,23 +12938,23 @@ ] }, { - "name": "397", + "name": "401", "members": [ { "name": "policy", "default": null, - "type": "556" + "type": "561" }, { "name": "rules", "default": null, - "type": "[557]" + "type": "[562]" } ], "meta-type": "object" }, { - "name": "398", + "name": "402", "members": [ { "name": "filename", @@ -12948,7 +12969,7 @@ "meta-type": "object" }, { - "name": "399", + "name": "403", "members": [ { "name": "service", @@ -12958,7 +12979,7 @@ "meta-type": "object" }, { - "name": "400", + "name": "404", "members": [ { "name": "identity", @@ -12968,7 +12989,7 @@ "meta-type": "object" }, { - "name": "401", + "name": "405", "members": [ { "name": "if", @@ -12982,7 +13003,7 @@ "meta-type": "object" }, { - "name": "402", + "name": "406", "members": [ { "name": "primary_in", @@ -13029,7 +13050,7 @@ "meta-type": "object" }, { - "name": "403", + "name": "407", "members": [ { "name": "queues", @@ -13040,7 +13061,7 @@ "meta-type": "object" }, { - "name": "404", + "name": "408", "members": [ { "name": "queues", @@ -13055,7 +13076,7 @@ "meta-type": "object" }, { - "name": "405", + "name": "409", "members": [ { "name": "addr", @@ -13070,7 +13091,7 @@ "meta-type": "object" }, { - "name": "406", + "name": "410", "members": [ { "name": "netdev", @@ -13079,7 +13100,7 @@ { "name": "queue", "default": null, - "type": "558" + "type": "563" }, { "name": "status", @@ -13094,7 +13115,7 @@ { "name": "insert", "default": null, - "type": "559" + "type": "564" }, { "name": "interval", @@ -13104,7 +13125,7 @@ "meta-type": "object" }, { - "name": "407", + "name": "411", "members": [ { "name": "netdev", @@ -13113,7 +13134,7 @@ { "name": "queue", "default": null, - "type": "558" + "type": "563" }, { "name": "status", @@ -13128,7 +13149,7 @@ { "name": "insert", "default": null, - "type": "559" + "type": "564" }, { "name": "file", @@ -13143,7 +13164,7 @@ "meta-type": "object" }, { - "name": "408", + "name": "412", "members": [ { "name": "netdev", @@ -13152,7 +13173,7 @@ { "name": "queue", "default": null, - "type": "558" + "type": "563" }, { "name": "status", @@ -13167,7 +13188,7 @@ { "name": "insert", "default": null, - "type": "559" + "type": "564" }, { "name": "outdev", @@ -13182,7 +13203,7 @@ "meta-type": "object" }, { - "name": "409", + "name": "413", "members": [ { "name": "netdev", @@ -13191,7 +13212,7 @@ { "name": "queue", "default": null, - "type": "558" + "type": "563" }, { "name": "status", @@ -13206,7 +13227,7 @@ { "name": "insert", "default": null, - "type": "559" + "type": "564" }, { "name": "indev", @@ -13227,7 +13248,7 @@ "meta-type": "object" }, { - "name": "410", + "name": "414", "members": [ { "name": "netdev", @@ -13236,7 +13257,7 @@ { "name": "queue", "default": null, - "type": "558" + "type": "563" }, { "name": "status", @@ -13251,13 +13272,13 @@ { "name": "insert", "default": null, - "type": "559" + "type": "564" } ], "meta-type": "object" }, { - "name": "411", + "name": "415", "members": [ { "name": "netdev", @@ -13266,7 +13287,7 @@ { "name": "queue", "default": null, - "type": "558" + "type": "563" }, { "name": "status", @@ -13281,7 +13302,7 @@ { "name": "insert", "default": null, - "type": "559" + "type": "564" }, { "name": "vnet_hdr_support", @@ -13292,7 +13313,7 @@ "meta-type": "object" }, { - "name": "412", + "name": "416", "members": [ { "name": "name", @@ -13332,7 +13353,7 @@ "meta-type": "object" }, { - "name": "413", + "name": "417", "members": [ { "name": "evdev", @@ -13351,13 +13372,13 @@ { "name": "grab-toggle", "default": null, - "type": "560" + "type": "565" } ], "meta-type": "object" }, { - "name": "414", + "name": "418", "members": [ { "name": "aio-max-batch", @@ -13393,7 +13414,7 @@ "meta-type": "object" }, { - "name": "415", + "name": "419", "members": [ { "name": "aio-max-batch", @@ -13414,7 +13435,7 @@ "meta-type": "object" }, { - "name": "416", + "name": "420", "members": [ { "name": "dump", @@ -13434,7 +13455,7 @@ { "name": "policy", "default": null, - "type": "437" + "type": "441" }, { "name": "prealloc", @@ -13469,7 +13490,7 @@ "meta-type": "object" }, { - "name": "417", + "name": "421", "members": [ { "name": "dump", @@ -13489,7 +13510,7 @@ { "name": "policy", "default": null, - "type": "437" + "type": "441" }, { "name": "prealloc", @@ -13548,7 +13569,7 @@ "meta-type": "object" }, { - "name": "418", + "name": "422", "members": [ { "name": "dump", @@ -13568,7 +13589,7 @@ { "name": "policy", "default": null, - "type": "437" + "type": "441" }, { "name": "prealloc", @@ -13618,7 +13639,7 @@ "meta-type": "object" }, { - "name": "419", + "name": "423", "members": [ { "name": "dump", @@ -13638,7 +13659,7 @@ { "name": "policy", "default": null, - "type": "437" + "type": "441" }, { "name": "prealloc", @@ -13673,7 +13694,7 @@ "meta-type": "object" }, { - "name": "420", + "name": "424", "members": [ { "name": "path", @@ -13683,7 +13704,7 @@ "meta-type": "object" }, { - "name": "421", + "name": "425", "members": [ { "name": "chardev", @@ -13698,7 +13719,7 @@ "meta-type": "object" }, { - "name": "422", + "name": "426", "members": [ { "name": "opened", @@ -13712,7 +13733,7 @@ "meta-type": "object" }, { - "name": "423", + "name": "427", "members": [ { "name": "opened", @@ -13730,7 +13751,7 @@ "meta-type": "object" }, { - "name": "424", + "name": "428", "members": [ { "name": "opened", @@ -13749,7 +13770,7 @@ "meta-type": "object" }, { - "name": "425", + "name": "429", "members": [ { "name": "loaded", @@ -13762,7 +13783,7 @@ { "name": "format", "default": null, - "type": "561" + "type": "566" }, { "name": "keyid", @@ -13788,7 +13809,7 @@ "meta-type": "object" }, { - "name": "426", + "name": "430", "members": [ { "name": "loaded", @@ -13801,7 +13822,7 @@ { "name": "format", "default": null, - "type": "561" + "type": "566" }, { "name": "keyid", @@ -13821,7 +13842,7 @@ "meta-type": "object" }, { - "name": "427", + "name": "431", "members": [ { "name": "sev-device", @@ -13866,12 +13887,12 @@ "meta-type": "object" }, { - "name": "428", + "name": "432", "members": [ { "name": "limits", "default": null, - "type": "562" + "type": "567" }, { "name": "x-iops-total", @@ -14029,7 +14050,7 @@ "meta-type": "object" }, { - "name": "429", + "name": "433", "members": [ { "name": "verify-peer", @@ -14044,7 +14065,7 @@ { "name": "endpoint", "default": null, - "type": "563" + "type": "568" }, { "name": "priority", @@ -14063,7 +14084,7 @@ "meta-type": "object" }, { - "name": "430", + "name": "434", "members": [ { "name": "verify-peer", @@ -14078,7 +14099,7 @@ { "name": "endpoint", "default": null, - "type": "563" + "type": "568" }, { "name": "priority", @@ -14102,7 +14123,7 @@ "meta-type": "object" }, { - "name": "431", + "name": "435", "members": [ { "name": "verify-peer", @@ -14117,7 +14138,7 @@ { "name": "endpoint", "default": null, - "type": "563" + "type": "568" }, { "name": "priority", @@ -14146,7 +14167,7 @@ "meta-type": "object" }, { - "name": "432", + "name": "436", "members": [ { "name": "verify-peer", @@ -14161,7 +14182,7 @@ { "name": "endpoint", "default": null, - "type": "563" + "type": "568" }, { "name": "priority", @@ -14172,7 +14193,7 @@ "meta-type": "object" }, { - "name": "433", + "name": "437", "members": [ { "name": "fd", @@ -14186,7 +14207,7 @@ "meta-type": "object" }, { - "name": "434", + "name": "438", "members": [ { "name": "node-id", @@ -14222,7 +14243,7 @@ "meta-type": "object" }, { - "name": "435", + "name": "439", "members": [ { "name": "aarch64" @@ -14350,17 +14371,17 @@ ] }, { - "name": "436", + "name": "440", "members": [ { "name": "cpu-state", - "type": "564" + "type": "569" } ], "meta-type": "object" }, { - "name": "437", + "name": "441", "members": [ { "name": "default" @@ -14384,7 +14405,7 @@ ] }, { - "name": "438", + "name": "442", "members": [ { "name": "node" @@ -14412,7 +14433,7 @@ ] }, { - "name": "439", + "name": "443", "members": [ { "name": "nodeid", @@ -14443,7 +14464,7 @@ "meta-type": "object" }, { - "name": "440", + "name": "444", "members": [ { "name": "src", @@ -14461,7 +14482,7 @@ "meta-type": "object" }, { - "name": "441", + "name": "445", "members": [ { "name": "node-id", @@ -14497,7 +14518,7 @@ "meta-type": "object" }, { - "name": "442", + "name": "446", "members": [ { "name": "initiator", @@ -14509,11 +14530,11 @@ }, { "name": "hierarchy", - "type": "565" + "type": "570" }, { "name": "data-type", - "type": "566" + "type": "571" }, { "name": "latency", @@ -14529,7 +14550,7 @@ "meta-type": "object" }, { - "name": "443", + "name": "447", "members": [ { "name": "node-id", @@ -14545,11 +14566,11 @@ }, { "name": "associativity", - "type": "567" + "type": "572" }, { "name": "policy", - "type": "568" + "type": "573" }, { "name": "line", @@ -14559,7 +14580,7 @@ "meta-type": "object" }, { - "name": "444", + "name": "448", "members": [ { "name": "dimm" @@ -14587,47 +14608,47 @@ ] }, { - "name": "445", + "name": "449", "members": [ { "name": "data", - "type": "569" + "type": "574" } ], "meta-type": "object" }, { - "name": "446", + "name": "450", "members": [ { "name": "data", - "type": "570" + "type": "575" } ], "meta-type": "object" }, { - "name": "447", + "name": "451", "members": [ { "name": "data", - "type": "571" + "type": "576" } ], "meta-type": "object" }, { - "name": "448", + "name": "452", "members": [ { "name": "data", - "type": "572" + "type": "577" } ], "meta-type": "object" }, { - "name": "449", + "name": "453", "members": [ { "name": "name", @@ -14642,7 +14663,7 @@ "meta-type": "object" }, { - "name": "450", + "name": "454", "members": [ { "name": "incompatible" @@ -14666,7 +14687,7 @@ ] }, { - "name": "451", + "name": "455", "members": [ { "name": "static" @@ -14682,7 +14703,7 @@ ] }, { - "name": "452", + "name": "456", "members": [ { "name": "none" @@ -14702,7 +14723,7 @@ ] }, { - "name": "453", + "name": "457", "members": [ { "name": "block-node" @@ -14722,7 +14743,7 @@ ] }, { - "name": "454", + "name": "458", "members": [ { "name": "node-name", @@ -14732,7 +14753,7 @@ "meta-type": "object" }, { - "name": "455", + "name": "459", "members": [ { "name": "id", @@ -14742,12 +14763,12 @@ "meta-type": "object" }, { - "name": "[456]", - "element-type": "456", + "name": "[460]", + "element-type": "460", "meta-type": "array" }, { - "name": "456", + "name": "460", "members": [ { "name": "fd", @@ -14762,12 +14783,12 @@ "meta-type": "object" }, { - "name": "[457]", - "element-type": "457", + "name": "[461]", + "element-type": "461", "meta-type": "array" }, { - "name": "457", + "name": "461", "members": [ { "name": "name", @@ -14775,7 +14796,7 @@ }, { "name": "type", - "type": "573" + "type": "578" }, { "name": "help", @@ -14791,7 +14812,7 @@ "meta-type": "object" }, { - "name": "458", + "name": "462", "members": [ { "name": "uninit" @@ -14823,12 +14844,12 @@ ] }, { - "name": "[459]", - "element-type": "459", + "name": "[463]", + "element-type": "463", "meta-type": "array" }, { - "name": "459", + "name": "463", "members": [ { "name": "node", @@ -14842,7 +14863,7 @@ "meta-type": "object" }, { - "name": "460", + "name": "464", "members": [ { "name": "DIMM" @@ -14858,12 +14879,12 @@ ] }, { - "name": "[461]", - "element-type": "461", + "name": "[465]", + "element-type": "465", "meta-type": "array" }, { - "name": "461", + "name": "465", "members": [ { "name": "bus", @@ -14879,11 +14900,11 @@ }, { "name": "class_info", - "type": "574" + "type": "579" }, { "name": "id", - "type": "575" + "type": "580" }, { "name": "irq", @@ -14901,17 +14922,17 @@ { "name": "pci_bridge", "default": null, - "type": "576" + "type": "581" }, { "name": "regions", - "type": "[577]" + "type": "[582]" } ], "meta-type": "object" }, { - "name": "462", + "name": "466", "members": [ { "name": "hyper-v" @@ -14927,7 +14948,7 @@ ] }, { - "name": "463", + "name": "467", "members": [ { "name": "arg1", @@ -14953,7 +14974,7 @@ "meta-type": "object" }, { - "name": "464", + "name": "468", "members": [ { "name": "core", @@ -14969,18 +14990,18 @@ }, { "name": "reason", - "type": "578" + "type": "583" } ], "meta-type": "object" }, { - "name": "[465]", - "element-type": "465", + "name": "[469]", + "element-type": "469", "meta-type": "array" }, { - "name": "465", + "name": "469", "members": [ { "name": "interval_length", @@ -15034,7 +15055,7 @@ "meta-type": "object" }, { - "name": "466", + "name": "470", "members": [ { "name": "boundaries", @@ -15048,7 +15069,7 @@ "meta-type": "object" }, { - "name": "467", + "name": "471", "members": [ { "name": "discard-nb-ok", @@ -15066,7 +15087,7 @@ "meta-type": "object" }, { - "name": "468", + "name": "472", "members": [ { "name": "completion-errors", @@ -15089,36 +15110,36 @@ "meta-type": "array" }, { - "name": "469", + "name": "473", "tag": "type", "variants": [ { "case": "qcow2", - "type": "580" + "type": "585" }, { "case": "vmdk", - "type": "581" + "type": "586" }, { "case": "luks", - "type": "582" + "type": "587" }, { "case": "rbd", - "type": "583" + "type": "588" } ], "members": [ { "name": "type", - "type": "579" + "type": "584" } ], "meta-type": "object" }, { - "name": "470", + "name": "474", "members": [ { "name": "block-backend" @@ -15138,12 +15159,12 @@ ] }, { - "name": "[471]", - "element-type": "471", + "name": "[475]", + "element-type": "475", "meta-type": "array" }, { - "name": "471", + "name": "475", "members": [ { "name": "consistent-read" @@ -15167,7 +15188,7 @@ ] }, { - "name": "472", + "name": "476", "members": [ { "type": "49" @@ -15179,16 +15200,16 @@ "meta-type": "alternate" }, { - "name": "[473]", - "element-type": "473", + "name": "[477]", + "element-type": "477", "meta-type": "array" }, { - "name": "473", + "name": "477", "members": [ { "name": "event", - "type": "584" + "type": "589" }, { "name": "state", @@ -15198,7 +15219,7 @@ { "name": "iotype", "default": null, - "type": "585" + "type": "590" }, { "name": "errno", @@ -15224,16 +15245,16 @@ "meta-type": "object" }, { - "name": "[474]", - "element-type": "474", + "name": "[478]", + "element-type": "478", "meta-type": "array" }, { - "name": "474", + "name": "478", "members": [ { "name": "event", - "type": "584" + "type": "589" }, { "name": "state", @@ -15248,7 +15269,7 @@ "meta-type": "object" }, { - "name": "475", + "name": "479", "members": [ { "name": "auto" @@ -15268,7 +15289,7 @@ ] }, { - "name": "476", + "name": "480", "members": [ { "name": "threads" @@ -15288,7 +15309,7 @@ ] }, { - "name": "477", + "name": "481", "members": [ { "name": "tcp" @@ -15304,7 +15325,7 @@ ] }, { - "name": "478", + "name": "482", "members": [ { "name": "crc32c" @@ -15328,11 +15349,11 @@ ] }, { - "name": "479", + "name": "483", "members": [ { "name": "type", - "type": "586" + "type": "591" }, { "name": "host", @@ -15342,7 +15363,7 @@ "meta-type": "object" }, { - "name": "480", + "name": "484", "members": [ { "type": "49" @@ -15357,62 +15378,62 @@ "meta-type": "alternate" }, { - "name": "481", + "name": "485", "members": [ { - "type": "587" + "type": "592" }, { - "type": "588" + "type": "593" } ], "meta-type": "alternate" }, { - "name": "482", + "name": "486", "tag": "format", "variants": [ { "case": "aes", - "type": "590" + "type": "595" }, { "case": "luks", - "type": "591" + "type": "596" } ], "members": [ { "name": "format", - "type": "589" + "type": "594" } ], "meta-type": "object" }, { - "name": "483", + "name": "487", "tag": "format", "variants": [ { "case": "aes", - "type": "590" + "type": "595" } ], "members": [ { "name": "format", - "type": "592" + "type": "597" } ], "meta-type": "object" }, { - "name": "[472]", - "element-type": "472", + "name": "[476]", + "element-type": "476", "meta-type": "array" }, { - "name": "484", + "name": "488", "members": [ { "name": "quorum" @@ -15428,33 +15449,33 @@ ] }, { - "name": "485", + "name": "489", "tag": "format", "variants": [ { "case": "luks", - "type": "594" + "type": "599" }, { "case": "luks2", - "type": "595" + "type": "600" } ], "members": [ { "name": "format", - "type": "593" + "type": "598" } ], "meta-type": "object" }, { - "name": "[486]", - "element-type": "486", + "name": "[490]", + "element-type": "490", "meta-type": "array" }, { - "name": "486", + "name": "490", "members": [ { "name": "cephx" @@ -15470,12 +15491,12 @@ ] }, { - "name": "[487]", - "element-type": "487", + "name": "[491]", + "element-type": "491", "meta-type": "array" }, { - "name": "487", + "name": "491", "members": [ { "name": "host", @@ -15489,7 +15510,7 @@ "meta-type": "object" }, { - "name": "488", + "name": "492", "members": [ { "name": "primary" @@ -15505,7 +15526,7 @@ ] }, { - "name": "489", + "name": "493", "members": [ { "name": "host", @@ -15549,12 +15570,12 @@ "meta-type": "object" }, { - "name": "490", + "name": "494", "tag": "mode", "variants": [ { "case": "hash", - "type": "597" + "type": "602" }, { "case": "none", @@ -15568,13 +15589,13 @@ "members": [ { "name": "mode", - "type": "596" + "type": "601" } ], "meta-type": "object" }, { - "name": "491", + "name": "495", "members": [ { "name": "filename", @@ -15587,7 +15608,7 @@ { "name": "preallocation", "default": null, - "type": "598" + "type": "603" }, { "name": "nocow", @@ -15603,7 +15624,7 @@ "meta-type": "object" }, { - "name": "492", + "name": "496", "members": [ { "name": "location", @@ -15616,13 +15637,13 @@ { "name": "preallocation", "default": null, - "type": "598" + "type": "603" } ], "meta-type": "object" }, { - "name": "493", + "name": "497", "members": [ { "name": "key-secret", @@ -15632,27 +15653,27 @@ { "name": "cipher-alg", "default": null, - "type": "599" + "type": "604" }, { "name": "cipher-mode", "default": null, - "type": "600" + "type": "605" }, { "name": "ivgen-alg", "default": null, - "type": "601" + "type": "606" }, { "name": "ivgen-hash-alg", "default": null, - "type": "602" + "type": "607" }, { "name": "hash-alg", "default": null, - "type": "602" + "type": "607" }, { "name": "iter-time", @@ -15661,7 +15682,7 @@ }, { "name": "file", - "type": "472" + "type": "476" }, { "name": "size", @@ -15670,13 +15691,13 @@ { "name": "preallocation", "default": null, - "type": "598" + "type": "603" } ], "meta-type": "object" }, { - "name": "494", + "name": "498", "members": [ { "name": "location", @@ -15690,11 +15711,11 @@ "meta-type": "object" }, { - "name": "495", + "name": "499", "members": [ { "name": "file", - "type": "472" + "type": "476" }, { "name": "size", @@ -15709,11 +15730,11 @@ "meta-type": "object" }, { - "name": "496", + "name": "500", "members": [ { "name": "file", - "type": "472" + "type": "476" }, { "name": "size", @@ -15727,22 +15748,22 @@ { "name": "encrypt", "default": null, - "type": "603" + "type": "608" } ], "meta-type": "object" }, { - "name": "497", + "name": "501", "members": [ { "name": "file", - "type": "472" + "type": "476" }, { "name": "data-file", "default": null, - "type": "472" + "type": "476" }, { "name": "data-file-raw", @@ -15761,7 +15782,7 @@ { "name": "version", "default": null, - "type": "604" + "type": "609" }, { "name": "backing-file", @@ -15776,7 +15797,7 @@ { "name": "encrypt", "default": null, - "type": "603" + "type": "608" }, { "name": "cluster-size", @@ -15786,7 +15807,7 @@ { "name": "preallocation", "default": null, - "type": "598" + "type": "603" }, { "name": "lazy-refcounts", @@ -15801,17 +15822,17 @@ { "name": "compression-type", "default": null, - "type": "605" + "type": "610" } ], "meta-type": "object" }, { - "name": "498", + "name": "502", "members": [ { "name": "file", - "type": "472" + "type": "476" }, { "name": "size", @@ -15841,7 +15862,7 @@ "meta-type": "object" }, { - "name": "499", + "name": "503", "members": [ { "name": "location", @@ -15859,13 +15880,13 @@ { "name": "encrypt", "default": null, - "type": "606" + "type": "611" } ], "meta-type": "object" }, { - "name": "500", + "name": "504", "members": [ { "name": "location", @@ -15879,11 +15900,11 @@ "meta-type": "object" }, { - "name": "501", + "name": "505", "members": [ { "name": "file", - "type": "472" + "type": "476" }, { "name": "size", @@ -15892,17 +15913,17 @@ { "name": "preallocation", "default": null, - "type": "598" + "type": "603" } ], "meta-type": "object" }, { - "name": "502", + "name": "506", "members": [ { "name": "file", - "type": "472" + "type": "476" }, { "name": "size", @@ -15921,7 +15942,7 @@ { "name": "subformat", "default": null, - "type": "607" + "type": "612" }, { "name": "block-state-zero", @@ -15932,11 +15953,11 @@ "meta-type": "object" }, { - "name": "503", + "name": "507", "members": [ { "name": "file", - "type": "472" + "type": "476" }, { "name": "size", @@ -15945,12 +15966,12 @@ { "name": "extents", "default": null, - "type": "[472]" + "type": "[476]" }, { "name": "subformat", "default": null, - "type": "608" + "type": "613" }, { "name": "backing-file", @@ -15960,7 +15981,7 @@ { "name": "adapter-type", "default": null, - "type": "609" + "type": "614" }, { "name": "hwversion", @@ -15981,11 +16002,11 @@ "meta-type": "object" }, { - "name": "504", + "name": "508", "members": [ { "name": "file", - "type": "472" + "type": "476" }, { "name": "size", @@ -15994,7 +16015,7 @@ { "name": "subformat", "default": null, - "type": "610" + "type": "615" }, { "name": "force-size", @@ -16005,11 +16026,11 @@ "meta-type": "object" }, { - "name": "505", + "name": "509", "members": [ { "name": "state", - "type": "611" + "type": "616" }, { "name": "new-secret", @@ -16040,12 +16061,12 @@ "meta-type": "object" }, { - "name": "506", + "name": "510", "members": [ { "name": "encrypt", "default": null, - "type": "612" + "type": "617" } ], "meta-type": "object" @@ -16056,7 +16077,7 @@ "meta-type": "builtin" }, { - "name": "507", + "name": "511", "members": [ { "name": "inet" @@ -16080,47 +16101,47 @@ ] }, { - "name": "508", + "name": "512", "members": [ { "name": "data", - "type": "489" + "type": "493" } ], "meta-type": "object" }, { - "name": "509", + "name": "513", "members": [ { "name": "data", - "type": "537" + "type": "542" } ], "meta-type": "object" }, { - "name": "510", + "name": "514", "members": [ { "name": "data", - "type": "538" + "type": "543" } ], "meta-type": "object" }, { - "name": "511", + "name": "515", "members": [ { "name": "data", - "type": "527" + "type": "531" } ], "meta-type": "object" }, { - "name": "512", + "name": "516", "members": [ { "name": "off" @@ -16140,7 +16161,7 @@ ] }, { - "name": "513", + "name": "517", "members": [ { "name": "file" @@ -16236,142 +16257,142 @@ ] }, { - "name": "514", + "name": "518", "members": [ { "name": "data", - "type": "613" + "type": "618" } ], "meta-type": "object" }, { - "name": "515", + "name": "519", "members": [ { "name": "data", - "type": "614" + "type": "619" } ], "meta-type": "object" }, { - "name": "516", + "name": "520", "members": [ { "name": "data", - "type": "615" + "type": "620" } ], "meta-type": "object" }, { - "name": "517", + "name": "521", "members": [ { "name": "data", - "type": "616" + "type": "621" } ], "meta-type": "object" }, { - "name": "518", + "name": "522", "members": [ { "name": "data", - "type": "617" + "type": "622" } ], "meta-type": "object" }, { - "name": "519", + "name": "523", "members": [ { "name": "data", - "type": "618" + "type": "623" } ], "meta-type": "object" }, { - "name": "520", + "name": "524", "members": [ { "name": "data", - "type": "619" + "type": "624" } ], "meta-type": "object" }, { - "name": "521", + "name": "525", "members": [ { "name": "data", - "type": "620" + "type": "625" } ], "meta-type": "object" }, { - "name": "522", + "name": "526", "members": [ { "name": "data", - "type": "621" + "type": "626" } ], "meta-type": "object" }, { - "name": "523", + "name": "527", "members": [ { "name": "data", - "type": "622" + "type": "627" } ], "meta-type": "object" }, { - "name": "524", + "name": "528", "members": [ { "name": "data", - "type": "623" + "type": "628" } ], "meta-type": "object" }, { - "name": "525", + "name": "529", "members": [ { "name": "data", - "type": "624" + "type": "629" } ], "meta-type": "object" }, { - "name": "526", + "name": "530", "members": [ { "name": "data", - "type": "625" + "type": "630" } ], "meta-type": "object" }, { - "name": "[527]", - "element-type": "527", + "name": "[531]", + "element-type": "531", "meta-type": "array" }, { - "name": "527", + "name": "531", "members": [ { "name": "str", @@ -16381,27 +16402,27 @@ "meta-type": "object" }, { - "name": "528", + "name": "532", "members": [ { "name": "data", - "type": "626" + "type": "631" } ], "meta-type": "object" }, { - "name": "529", + "name": "533", "members": [ { "name": "data", - "type": "627" + "type": "632" } ], "meta-type": "object" }, { - "name": "530", + "name": "534", "members": [ { "name": "number" @@ -16417,7 +16438,7 @@ ] }, { - "name": "531", + "name": "535", "members": [ { "name": "data", @@ -16427,17 +16448,17 @@ "meta-type": "object" }, { - "name": "532", + "name": "536", "members": [ { "name": "data", - "type": "628" + "type": "633" } ], "meta-type": "object" }, { - "name": "533", + "name": "537", "members": [ { "name": "key" @@ -16461,42 +16482,62 @@ ] }, { - "name": "534", + "name": "538", "members": [ { "name": "data", - "type": "629" + "type": "634" } ], "meta-type": "object" }, { - "name": "535", + "name": "539", "members": [ { "name": "data", - "type": "630" + "type": "635" } ], "meta-type": "object" }, { - "name": "536", + "name": "540", "members": [ { "name": "data", - "type": "631" + "type": "636" } ], "meta-type": "object" }, + { + "name": "541", + "members": [ + { + "name": "lctrl-lalt" + }, + { + "name": "lshift-lctrl-lalt" + }, + { + "name": "rctrl" + } + ], + "meta-type": "enum", + "values": [ + "lctrl-lalt", + "lshift-lctrl-lalt", + "rctrl" + ] + }, { "name": "number", "json-type": "number", "meta-type": "builtin" }, { - "name": "537", + "name": "542", "members": [ { "name": "path", @@ -16516,7 +16557,7 @@ "meta-type": "object" }, { - "name": "538", + "name": "543", "members": [ { "name": "cid", @@ -16530,12 +16571,12 @@ "meta-type": "object" }, { - "name": "[539]", - "element-type": "539", + "name": "[544]", + "element-type": "544", "meta-type": "array" }, { - "name": "539", + "name": "544", "members": [ { "name": "name", @@ -16548,13 +16589,13 @@ { "name": "transform", "default": null, - "type": "632" + "type": "637" } ], "meta-type": "object" }, { - "name": "540", + "name": "545", "members": [ { "name": "abort" @@ -16613,17 +16654,17 @@ ] }, { - "name": "541", + "name": "546", "members": [ { "name": "data", - "type": "633" + "type": "638" } ], "meta-type": "object" }, { - "name": "542", + "name": "547", "members": [ { "name": "data", @@ -16633,7 +16674,7 @@ "meta-type": "object" }, { - "name": "543", + "name": "548", "members": [ { "name": "data", @@ -16643,7 +16684,7 @@ "meta-type": "object" }, { - "name": "544", + "name": "549", "members": [ { "name": "data", @@ -16653,7 +16694,7 @@ "meta-type": "object" }, { - "name": "545", + "name": "550", "members": [ { "name": "data", @@ -16663,7 +16704,7 @@ "meta-type": "object" }, { - "name": "546", + "name": "551", "members": [ { "name": "data", @@ -16673,7 +16714,7 @@ "meta-type": "object" }, { - "name": "547", + "name": "552", "members": [ { "name": "data", @@ -16683,7 +16724,7 @@ "meta-type": "object" }, { - "name": "548", + "name": "553", "members": [ { "name": "data", @@ -16693,7 +16734,7 @@ "meta-type": "object" }, { - "name": "549", + "name": "554", "members": [ { "name": "data", @@ -16703,7 +16744,7 @@ "meta-type": "object" }, { - "name": "550", + "name": "555", "members": [ { "name": "individual" @@ -16719,7 +16760,7 @@ ] }, { - "name": "551", + "name": "556", "members": [ { "name": "string" @@ -16759,12 +16800,12 @@ ] }, { - "name": "[552]", - "element-type": "552", + "name": "[557]", + "element-type": "557", "meta-type": "array" }, { - "name": "552", + "name": "557", "members": [ { "name": "name", @@ -16779,12 +16820,12 @@ "meta-type": "object" }, { - "name": "[553]", - "element-type": "553", + "name": "[558]", + "element-type": "558", "meta-type": "array" }, { - "name": "553", + "name": "558", "members": [ { "name": "name", @@ -16808,12 +16849,12 @@ "meta-type": "object" }, { - "name": "[554]", - "element-type": "554", + "name": "[559]", + "element-type": "559", "meta-type": "array" }, { - "name": "554", + "name": "559", "members": [ { "name": "case", @@ -16827,12 +16868,12 @@ "meta-type": "object" }, { - "name": "[555]", - "element-type": "555", + "name": "[560]", + "element-type": "560", "meta-type": "array" }, { - "name": "555", + "name": "560", "members": [ { "name": "type", @@ -16842,7 +16883,7 @@ "meta-type": "object" }, { - "name": "556", + "name": "561", "members": [ { "name": "deny" @@ -16858,12 +16899,12 @@ ] }, { - "name": "[557]", - "element-type": "557", + "name": "[562]", + "element-type": "562", "meta-type": "array" }, { - "name": "557", + "name": "562", "members": [ { "name": "match", @@ -16871,18 +16912,18 @@ }, { "name": "policy", - "type": "556" + "type": "561" }, { "name": "format", "default": null, - "type": "634" + "type": "639" } ], "meta-type": "object" }, { - "name": "558", + "name": "563", "members": [ { "name": "all" @@ -16902,7 +16943,7 @@ ] }, { - "name": "559", + "name": "564", "members": [ { "name": "before" @@ -16918,7 +16959,7 @@ ] }, { - "name": "560", + "name": "565", "members": [ { "name": "ctrl-ctrl" @@ -16950,7 +16991,7 @@ ] }, { - "name": "561", + "name": "566", "members": [ { "name": "raw" @@ -16966,7 +17007,7 @@ ] }, { - "name": "562", + "name": "567", "members": [ { "name": "iops-total", @@ -17067,7 +17108,7 @@ "meta-type": "object" }, { - "name": "563", + "name": "568", "members": [ { "name": "client" @@ -17083,7 +17124,7 @@ ] }, { - "name": "564", + "name": "569", "members": [ { "name": "uninitialized" @@ -17111,7 +17152,7 @@ ] }, { - "name": "565", + "name": "570", "members": [ { "name": "memory" @@ -17135,7 +17176,7 @@ ] }, { - "name": "566", + "name": "571", "members": [ { "name": "access-latency" @@ -17167,7 +17208,7 @@ ] }, { - "name": "567", + "name": "572", "members": [ { "name": "none" @@ -17187,7 +17228,7 @@ ] }, { - "name": "568", + "name": "573", "members": [ { "name": "none" @@ -17207,7 +17248,7 @@ ] }, { - "name": "569", + "name": "574", "members": [ { "name": "id", @@ -17246,7 +17287,7 @@ "meta-type": "object" }, { - "name": "570", + "name": "575", "members": [ { "name": "id", @@ -17269,7 +17310,7 @@ "meta-type": "object" }, { - "name": "571", + "name": "576", "members": [ { "name": "id", @@ -17308,7 +17349,7 @@ "meta-type": "object" }, { - "name": "572", + "name": "577", "members": [ { "name": "id", @@ -17335,7 +17376,7 @@ "meta-type": "object" }, { - "name": "573", + "name": "578", "members": [ { "name": "string" @@ -17359,7 +17400,7 @@ ] }, { - "name": "574", + "name": "579", "members": [ { "name": "desc", @@ -17374,7 +17415,7 @@ "meta-type": "object" }, { - "name": "575", + "name": "580", "members": [ { "name": "device", @@ -17398,27 +17439,27 @@ "meta-type": "object" }, { - "name": "576", + "name": "581", "members": [ { "name": "bus", - "type": "635" + "type": "640" }, { "name": "devices", "default": null, - "type": "[461]" + "type": "[465]" } ], "meta-type": "object" }, { - "name": "[577]", - "element-type": "577", + "name": "[582]", + "element-type": "582", "meta-type": "array" }, { - "name": "577", + "name": "582", "members": [ { "name": "bar", @@ -17450,7 +17491,7 @@ "meta-type": "object" }, { - "name": "578", + "name": "583", "members": [ { "name": "unknown" @@ -17478,7 +17519,7 @@ ] }, { - "name": "579", + "name": "584", "members": [ { "name": "qcow2" @@ -17502,47 +17543,47 @@ ] }, { - "name": "580", + "name": "585", "members": [ { "name": "data", - "type": "636" + "type": "641" } ], "meta-type": "object" }, { - "name": "581", + "name": "586", "members": [ { "name": "data", - "type": "637" + "type": "642" } ], "meta-type": "object" }, { - "name": "582", + "name": "587", "members": [ { "name": "data", - "type": "638" + "type": "643" } ], "meta-type": "object" }, { - "name": "583", + "name": "588", "members": [ { "name": "data", - "type": "639" + "type": "644" } ], "meta-type": "object" }, { - "name": "584", + "name": "589", "members": [ { "name": "l1_update" @@ -17742,7 +17783,7 @@ ] }, { - "name": "585", + "name": "590", "members": [ { "name": "read" @@ -17774,7 +17815,7 @@ ] }, { - "name": "586", + "name": "591", "members": [ { "name": "inet" @@ -17786,12 +17827,12 @@ ] }, { - "name": "587", + "name": "592", "members": [ { "name": "template", "default": null, - "type": "588" + "type": "593" }, { "name": "main-header", @@ -17842,7 +17883,7 @@ "meta-type": "object" }, { - "name": "588", + "name": "593", "members": [ { "name": "none" @@ -17866,7 +17907,7 @@ ] }, { - "name": "589", + "name": "594", "members": [ { "name": "aes" @@ -17882,7 +17923,7 @@ ] }, { - "name": "590", + "name": "595", "members": [ { "name": "key-secret", @@ -17893,7 +17934,7 @@ "meta-type": "object" }, { - "name": "591", + "name": "596", "members": [ { "name": "key-secret", @@ -17904,7 +17945,7 @@ "meta-type": "object" }, { - "name": "592", + "name": "597", "members": [ { "name": "aes" @@ -17916,7 +17957,7 @@ ] }, { - "name": "593", + "name": "598", "members": [ { "name": "luks" @@ -17932,7 +17973,7 @@ ] }, { - "name": "594", + "name": "599", "members": [ { "name": "key-secret", @@ -17942,7 +17983,7 @@ "meta-type": "object" }, { - "name": "595", + "name": "600", "members": [ { "name": "key-secret", @@ -17952,7 +17993,7 @@ "meta-type": "object" }, { - "name": "596", + "name": "601", "members": [ { "name": "none" @@ -17972,11 +18013,11 @@ ] }, { - "name": "597", + "name": "602", "members": [ { "name": "type", - "type": "640" + "type": "645" }, { "name": "hash", @@ -17986,7 +18027,7 @@ "meta-type": "object" }, { - "name": "598", + "name": "603", "members": [ { "name": "off" @@ -18010,7 +18051,7 @@ ] }, { - "name": "599", + "name": "604", "members": [ { "name": "aes-128" @@ -18066,7 +18107,7 @@ ] }, { - "name": "600", + "name": "605", "members": [ { "name": "ecb" @@ -18090,7 +18131,7 @@ ] }, { - "name": "601", + "name": "606", "members": [ { "name": "plain" @@ -18110,7 +18151,7 @@ ] }, { - "name": "602", + "name": "607", "members": [ { "name": "md5" @@ -18146,28 +18187,28 @@ ] }, { - "name": "603", + "name": "608", "tag": "format", "variants": [ { "case": "qcow", - "type": "590" + "type": "595" }, { "case": "luks", - "type": "642" + "type": "647" } ], "members": [ { "name": "format", - "type": "641" + "type": "646" } ], "meta-type": "object" }, { - "name": "604", + "name": "609", "members": [ { "name": "v2" @@ -18183,7 +18224,7 @@ ] }, { - "name": "605", + "name": "610", "members": [ { "name": "zlib" @@ -18199,28 +18240,28 @@ ] }, { - "name": "606", + "name": "611", "tag": "format", "variants": [ { "case": "luks", - "type": "643" + "type": "648" }, { "case": "luks2", - "type": "644" + "type": "649" } ], "members": [ { "name": "format", - "type": "593" + "type": "598" } ], "meta-type": "object" }, { - "name": "607", + "name": "612", "members": [ { "name": "dynamic" @@ -18236,7 +18277,7 @@ ] }, { - "name": "608", + "name": "613", "members": [ { "name": "monolithicSparse" @@ -18264,7 +18305,7 @@ ] }, { - "name": "609", + "name": "614", "members": [ { "name": "ide" @@ -18288,7 +18329,7 @@ ] }, { - "name": "610", + "name": "615", "members": [ { "name": "dynamic" @@ -18304,7 +18345,7 @@ ] }, { - "name": "611", + "name": "616", "members": [ { "name": "active" @@ -18320,12 +18361,12 @@ ] }, { - "name": "612", + "name": "617", "tag": "format", "variants": [ { "case": "luks", - "type": "645" + "type": "650" }, { "case": "qcow", @@ -18335,13 +18376,13 @@ "members": [ { "name": "format", - "type": "641" + "type": "646" } ], "meta-type": "object" }, { - "name": "613", + "name": "618", "members": [ { "name": "logfile", @@ -18371,7 +18412,7 @@ "meta-type": "object" }, { - "name": "614", + "name": "619", "members": [ { "name": "logfile", @@ -18391,7 +18432,7 @@ "meta-type": "object" }, { - "name": "615", + "name": "620", "members": [ { "name": "logfile", @@ -18456,7 +18497,7 @@ "meta-type": "object" }, { - "name": "616", + "name": "621", "members": [ { "name": "logfile", @@ -18481,7 +18522,7 @@ "meta-type": "object" }, { - "name": "617", + "name": "622", "members": [ { "name": "logfile", @@ -18497,7 +18538,7 @@ "meta-type": "object" }, { - "name": "618", + "name": "623", "members": [ { "name": "logfile", @@ -18517,7 +18558,7 @@ "meta-type": "object" }, { - "name": "619", + "name": "624", "members": [ { "name": "logfile", @@ -18538,7 +18579,7 @@ "meta-type": "object" }, { - "name": "620", + "name": "625", "members": [ { "name": "logfile", @@ -18558,7 +18599,7 @@ "meta-type": "object" }, { - "name": "621", + "name": "626", "members": [ { "name": "logfile", @@ -18578,7 +18619,7 @@ "meta-type": "object" }, { - "name": "622", + "name": "627", "members": [ { "name": "logfile", @@ -18604,7 +18645,7 @@ "meta-type": "object" }, { - "name": "623", + "name": "628", "members": [ { "name": "logfile", @@ -18624,7 +18665,7 @@ "meta-type": "object" }, { - "name": "624", + "name": "629", "members": [ { "name": "logfile", @@ -18660,7 +18701,7 @@ "meta-type": "object" }, { - "name": "625", + "name": "630", "members": [ { "name": "logfile", @@ -18681,7 +18722,7 @@ "meta-type": "object" }, { - "name": "626", + "name": "631", "members": [ { "name": "path", @@ -18697,7 +18738,7 @@ "meta-type": "object" }, { - "name": "627", + "name": "632", "members": [ { "name": "chardev", @@ -18707,7 +18748,7 @@ "meta-type": "object" }, { - "name": "628", + "name": "633", "members": [ { "name": "unmapped" @@ -19315,11 +19356,11 @@ ] }, { - "name": "629", + "name": "634", "members": [ { "name": "key", - "type": "356" + "type": "359" }, { "name": "down", @@ -19329,11 +19370,11 @@ "meta-type": "object" }, { - "name": "630", + "name": "635", "members": [ { "name": "button", - "type": "646" + "type": "651" }, { "name": "down", @@ -19343,11 +19384,11 @@ "meta-type": "object" }, { - "name": "631", + "name": "636", "members": [ { "name": "axis", - "type": "647" + "type": "652" }, { "name": "value", @@ -19357,7 +19398,7 @@ "meta-type": "object" }, { - "name": "632", + "name": "637", "members": [ { "name": "persistent", @@ -19368,13 +19409,13 @@ "meta-type": "object" }, { - "name": "633", + "name": "638", "members": [ ], "meta-type": "object" }, { - "name": "634", + "name": "639", "members": [ { "name": "exact" @@ -19390,7 +19431,7 @@ ] }, { - "name": "635", + "name": "640", "members": [ { "name": "number", @@ -19406,21 +19447,21 @@ }, { "name": "io_range", - "type": "648" + "type": "653" }, { "name": "memory_range", - "type": "648" + "type": "653" }, { "name": "prefetchable_range", - "type": "648" + "type": "653" } ], "meta-type": "object" }, { - "name": "636", + "name": "641", "members": [ { "name": "compat", @@ -19458,22 +19499,22 @@ { "name": "encrypt", "default": null, - "type": "649" + "type": "654" }, { "name": "bitmaps", "default": null, - "type": "[650]" + "type": "[655]" }, { "name": "compression-type", - "type": "605" + "type": "610" } ], "meta-type": "object" }, { - "name": "637", + "name": "642", "members": [ { "name": "create-type", @@ -19495,28 +19536,28 @@ "meta-type": "object" }, { - "name": "638", + "name": "643", "members": [ { "name": "cipher-alg", - "type": "599" + "type": "604" }, { "name": "cipher-mode", - "type": "600" + "type": "605" }, { "name": "ivgen-alg", - "type": "601" + "type": "606" }, { "name": "ivgen-hash-alg", "default": null, - "type": "602" + "type": "607" }, { "name": "hash-alg", - "type": "602" + "type": "607" }, { "name": "payload-offset", @@ -19532,24 +19573,24 @@ }, { "name": "slots", - "type": "[651]" + "type": "[656]" } ], "meta-type": "object" }, { - "name": "639", + "name": "644", "members": [ { "name": "encryption-format", "default": null, - "type": "593" + "type": "598" } ], "meta-type": "object" }, { - "name": "640", + "name": "645", "members": [ { "name": "md5" @@ -19569,7 +19610,7 @@ ] }, { - "name": "641", + "name": "646", "members": [ { "name": "qcow" @@ -19585,7 +19626,7 @@ ] }, { - "name": "642", + "name": "647", "members": [ { "name": "key-secret", @@ -19595,27 +19636,27 @@ { "name": "cipher-alg", "default": null, - "type": "599" + "type": "604" }, { "name": "cipher-mode", "default": null, - "type": "600" + "type": "605" }, { "name": "ivgen-alg", "default": null, - "type": "601" + "type": "606" }, { "name": "ivgen-hash-alg", "default": null, - "type": "602" + "type": "607" }, { "name": "hash-alg", "default": null, - "type": "602" + "type": "607" }, { "name": "iter-time", @@ -19626,7 +19667,7 @@ "meta-type": "object" }, { - "name": "643", + "name": "648", "members": [ { "name": "key-secret", @@ -19635,13 +19676,13 @@ { "name": "cipher-alg", "default": null, - "type": "599" + "type": "604" } ], "meta-type": "object" }, { - "name": "644", + "name": "649", "members": [ { "name": "key-secret", @@ -19650,17 +19691,17 @@ { "name": "cipher-alg", "default": null, - "type": "599" + "type": "604" } ], "meta-type": "object" }, { - "name": "645", + "name": "650", "members": [ { "name": "state", - "type": "611" + "type": "616" }, { "name": "new-secret", @@ -19691,7 +19732,7 @@ "meta-type": "object" }, { - "name": "646", + "name": "651", "members": [ { "name": "left" @@ -19735,7 +19776,7 @@ ] }, { - "name": "647", + "name": "652", "members": [ { "name": "x" @@ -19751,7 +19792,7 @@ ] }, { - "name": "648", + "name": "653", "members": [ { "name": "base", @@ -19765,12 +19806,12 @@ "meta-type": "object" }, { - "name": "649", + "name": "654", "tag": "format", "variants": [ { "case": "luks", - "type": "638" + "type": "643" }, { "case": "aes", @@ -19780,18 +19821,18 @@ "members": [ { "name": "format", - "type": "589" + "type": "594" } ], "meta-type": "object" }, { - "name": "[650]", - "element-type": "650", + "name": "[655]", + "element-type": "655", "meta-type": "array" }, { - "name": "650", + "name": "655", "members": [ { "name": "name", @@ -19803,7 +19844,7 @@ }, { "name": "flags", - "type": "[652]" + "type": "[657]" } ], "meta-type": "object" @@ -19814,12 +19855,12 @@ "meta-type": "array" }, { - "name": "[651]", - "element-type": "651", + "name": "[656]", + "element-type": "656", "meta-type": "array" }, { - "name": "651", + "name": "656", "members": [ { "name": "active", @@ -19843,12 +19884,12 @@ "meta-type": "object" }, { - "name": "[652]", - "element-type": "652", + "name": "[657]", + "element-type": "657", "meta-type": "array" }, { - "name": "652", + "name": "657", "members": [ { "name": "in-use" @@ -20529,6 +20570,10 @@ "name": "acpi-erst", "parent": "pci-device" }, + { + "name": "max-x86_64-cpu", + "parent": "x86_64-cpu" + }, { "name": "isa-applesmc", "parent": "isa-device" @@ -20566,20 +20611,20 @@ "parent": "x86_64-cpu" }, { - "name": "chardev-stdio", - "parent": "chardev-fd" + "name": "sev-guest", + "parent": "confidential-guest-support" }, { - "name": "pci-ipmi-bt", - "parent": "pci-device" + "name": "usb-wacom-tablet", + "parent": "usb-device" }, { "name": "filter-buffer", "parent": "netfilter" }, { - "name": "usb-wacom-tablet", - "parent": "usb-device" + "name": "pci-ipmi-bt", + "parent": "pci-device" }, { "name": "ich9-usb-uhci6", @@ -20614,8 +20659,8 @@ "parent": "generic-pc-machine" }, { - "name": "sev-guest", - "parent": "confidential-guest-support" + "name": "cxl-rp", + "parent": "pcie-root-port-base" }, { "name": "core2duo-x86_64-cpu", @@ -20633,14 +20678,14 @@ "name": "pc-q35-2.5-machine", "parent": "generic-pc-machine" }, - { - "name": "max-x86_64-cpu", - "parent": "x86_64-cpu" - }, { "name": "vmware-svga", "parent": "pci-device" }, + { + "name": "virtio-mmio-bus", + "parent": "virtio-bus" + }, { "name": "tpm-crb", "parent": "device" @@ -20650,21 +20695,21 @@ "parent": "ioapic-common" }, { - "name": "virtio-mmio-bus", - "parent": "virtio-bus" + "name": "gus", + "parent": "isa-device" }, { "name": "serial", "parent": "device" }, - { - "name": "gus", - "parent": "isa-device" - }, { "name": "ich9-usb-uhci4", "parent": "pci-uhci-usb" }, + { + "name": "pxb-cxl-host", + "parent": "pci-host-bridge" + }, { "name": "usb-hub", "parent": "usb-device" @@ -20685,10 +20730,6 @@ "name": "Opteron_G5-v1-x86_64-cpu", "parent": "x86_64-cpu" }, - { - "name": "Icelake-Client-x86_64-cpu", - "parent": "x86_64-cpu" - }, { "name": "chardev-wctablet", "parent": "chardev" @@ -20729,10 +20770,6 @@ "name": "ich9-usb-uhci1", "parent": "pci-uhci-usb" }, - { - "name": "Icelake-Client-v2-x86_64-cpu", - "parent": "x86_64-cpu" - }, { "name": "pc-i440fx-5.0-machine", "parent": "generic-pc-machine" @@ -20773,14 +20810,14 @@ "name": "n270-x86_64-cpu", "parent": "x86_64-cpu" }, - { - "name": "Cooperlake-x86_64-cpu", - "parent": "x86_64-cpu" - }, { "name": "pxb-host", "parent": "pci-host-bridge" }, + { + "name": "Cooperlake-x86_64-cpu", + "parent": "x86_64-cpu" + }, { "name": "virtio-9p-pci-transitional", "parent": "virtio-9p-pci-base" @@ -20829,10 +20866,6 @@ "name": "vhost-scsi-pci", "parent": "vhost-scsi-pci-base" }, - { - "name": "ICH9-LPC", - "parent": "pci-device" - }, { "name": "acpi-ged", "parent": "sys-bus-device" @@ -20846,8 +20879,8 @@ "parent": "virtio-gpu-pci-base-type" }, { - "name": "Snowridge-v3-x86_64-cpu", - "parent": "x86_64-cpu" + "name": "ICH9-LPC", + "parent": "pci-device" }, { "name": "pci-ipmi-kcs", @@ -20869,6 +20902,10 @@ "name": "pc-i440fx-2.3-machine", "parent": "generic-pc-machine" }, + { + "name": "Snowridge-v3-x86_64-cpu", + "parent": "x86_64-cpu" + }, { "name": "PCI", "parent": "bus" @@ -20889,10 +20926,6 @@ "name": "pci-serial-2x", "parent": "pci-device" }, - { - "name": "igd-passthrough-isa-bridge", - "parent": "pci-device" - }, { "name": "vhost-user-i2c-device", "parent": "virtio-device" @@ -20937,13 +20970,17 @@ "name": "Skylake-Client-v2-x86_64-cpu", "parent": "x86_64-cpu" }, + { + "name": "vhost-vsock-pci-non-transitional", + "parent": "vhost-vsock-pci-base" + }, { "name": "usb-net", "parent": "usb-device" }, { - "name": "vhost-vsock-pci-non-transitional", - "parent": "vhost-vsock-pci-base" + "name": "CXL", + "parent": "PCIE" }, { "name": "ich9-usb-ehci2", @@ -21241,6 +21278,10 @@ "name": "piix4-ide", "parent": "pci-ide" }, + { + "name": "ES1370", + "parent": "pci-device" + }, { "name": "virtio-balloon-pci", "parent": "virtio-balloon-pci-base" @@ -21266,9 +21307,13 @@ "parent": "acpi-ged" }, { - "name": "ES1370", + "name": "cxl-type3", "parent": "pci-device" }, + { + "name": "pc-i440fx-2.6-machine", + "parent": "generic-pc-machine" + }, { "name": "i82551", "parent": "pci-device" @@ -21285,10 +21330,6 @@ "name": "Icelake-Server-noTSX-x86_64-cpu", "parent": "x86_64-cpu" }, - { - "name": "pc-i440fx-2.6-machine", - "parent": "generic-pc-machine" - }, { "name": "SandyBridge-x86_64-cpu", "parent": "x86_64-cpu" @@ -21578,16 +21619,16 @@ "parent": "virtio-device" }, { - "name": "pc-i440fx-3.1-machine", - "parent": "generic-pc-machine" + "name": "Icelake-Server-x86_64-cpu", + "parent": "x86_64-cpu" }, { "name": "pci-serial-4x", "parent": "pci-device" }, { - "name": "Icelake-Server-x86_64-cpu", - "parent": "x86_64-cpu" + "name": "pc-i440fx-3.1-machine", + "parent": "generic-pc-machine" }, { "name": "sga", @@ -21857,10 +21898,6 @@ "name": "pc-i440fx-6.1-machine", "parent": "generic-pc-machine" }, - { - "name": "Icelake-Client-v1-x86_64-cpu", - "parent": "x86_64-cpu" - }, { "name": "vmcoreinfo", "parent": "device" @@ -22089,10 +22126,6 @@ "name": "pc-q35-2.10-machine", "parent": "generic-pc-machine" }, - { - "name": "Icelake-Client-v3-x86_64-cpu", - "parent": "x86_64-cpu" - }, { "name": "pc-i440fx-7.1-machine", "parent": "generic-pc-machine" @@ -22141,10 +22174,6 @@ "name": "PIIX3", "parent": "pci-piix3" }, - { - "name": "Icelake-Client-noTSX-x86_64-cpu", - "parent": "x86_64-cpu" - }, { "name": "pc-q35-2.4-machine", "parent": "generic-pc-machine" @@ -22173,6 +22202,10 @@ "name": "pc-dimm", "parent": "device" }, + { + "name": "pxb-cxl-bus", + "parent": "CXL" + }, { "name": "virtio-net-pci-transitional", "parent": "virtio-net-pci-base" @@ -22497,14 +22530,14 @@ "name": "vhost-user-gpu", "parent": "virtio-gpu-base" }, - { - "name": "hda-duplex", - "parent": "hda-audio" - }, { "name": "pentium-v1-x86_64-cpu", "parent": "x86_64-cpu" }, + { + "name": "hda-duplex", + "parent": "hda-audio" + }, { "name": "amd-iommu-iommu-memory-region", "parent": "iommu-memory-region" @@ -22853,6 +22886,10 @@ "name": "Dhyana-x86_64-cpu", "parent": "x86_64-cpu" }, + { + "name": "pxb-cxl", + "parent": "pci-device" + }, { "name": "piix3-ide-xen", "parent": "pci-ide" @@ -22865,6 +22902,10 @@ "name": "sd-bus", "parent": "bus" }, + { + "name": "virtio-vga", + "parent": "virtio-vga-base-type" + }, { "name": "filter-dump", "parent": "netfilter" @@ -22914,8 +22955,8 @@ "parent": "virtio-blk-pci-base" }, { - "name": "virtio-vga", - "parent": "virtio-vga-base-type" + "name": "chardev-stdio", + "parent": "chardev-fd" }, { "name": "authz-pam", @@ -26399,6 +26440,11 @@ "name": "x-buggy-eim", "type": "bool" }, + { + "default-value": true, + "name": "dma-translation", + "type": "bool" + }, { "default-value": true, "name": "dma-drain", @@ -27585,6 +27631,11 @@ "name": "vmx-vmfunc", "type": "bool" }, + { + "name": "hv-emsr-bitmap", + "description": "on/off", + "type": "bool" + }, { "name": "pse36", "type": "bool" @@ -27614,11 +27665,11 @@ "type": "bool" }, { - "name": "amd-stibp", + "name": "sgxlc", "type": "bool" }, { - "name": "sgxlc", + "name": "amd-stibp", "type": "bool" }, { @@ -27731,12 +27782,12 @@ "type": "bool" }, { - "name": "ssse3", + "name": "hv-runtime", + "description": "on/off", "type": "bool" }, { - "name": "hv-runtime", - "description": "on/off", + "name": "ssse3", "type": "bool" }, { @@ -27767,6 +27818,10 @@ "name": "avx512vbmi2", "type": "bool" }, + { + "name": "arch-lbr", + "type": "bool" + }, { "name": "vmx-vnmi-pending", "type": "bool" @@ -27974,8 +28029,7 @@ "type": "bool" }, { - "name": "hv-tlbflush", - "description": "on/off", + "name": "lwp", "type": "bool" }, { @@ -27983,7 +28037,8 @@ "type": "bool" }, { - "name": "lwp", + "name": "hv-tlbflush", + "description": "on/off", "type": "bool" }, { @@ -28114,6 +28169,10 @@ "name": "amx-int8", "type": "bool" }, + { + "name": "sgx1", + "type": "bool" + }, { "name": "vmx-rdpmc-exit", "type": "bool" @@ -28146,6 +28205,11 @@ "name": "intel-pt-lip", "type": "bool" }, + { + "name": "hv-tlbflush-direct", + "description": "on/off", + "type": "bool" + }, { "name": "avx512-bf16", "type": "bool" @@ -28263,11 +28327,11 @@ "type": "bool" }, { - "name": "avx512vl", + "name": "xstore-en", "type": "bool" }, { - "name": "xstore-en", + "name": "avx512vl", "type": "bool" }, { @@ -28371,10 +28435,6 @@ "name": "vmx-rdtsc-exit", "type": "bool" }, - { - "name": "vmx-entry-load-bndcfgs", - "type": "bool" - }, { "name": "vmx-activity-hlt", "type": "bool" @@ -28407,20 +28467,20 @@ "name": "hv-version-id-sbranch", "type": "uint8" }, - { - "name": "min-level", - "type": "uint32" - }, { "name": "crash-information", "type": "GuestPanicInformation" }, + { + "name": "min-level", + "type": "uint32" + }, { "name": "full-cpuid-auto-level", "type": "bool" }, { - "name": "extapic", + "name": "vmx-entry-load-bndcfgs", "type": "bool" }, { @@ -28428,27 +28488,27 @@ "type": "bool" }, { - "name": "ssb-no", + "name": "pclmulqdq", "type": "bool" }, { - "name": "msr", + "name": "xop", "type": "bool" }, { - "name": "kvm-pv-enforce-cpuid", + "name": "msr", "type": "bool" }, { - "name": "clflush", + "name": "kvm-pv-enforce-cpuid", "type": "bool" }, { - "name": "pclmulqdq", + "name": "ssb-no", "type": "bool" }, { - "name": "mpx", + "name": "clflush", "type": "bool" }, { @@ -28456,8 +28516,11 @@ "type": "uint32" }, { - "name": "hv-stimer", - "description": "on/off", + "name": "mpx", + "type": "bool" + }, + { + "name": "extapic", "type": "bool" }, { @@ -28469,7 +28532,8 @@ "type": "bool" }, { - "name": "xop", + "name": "hv-stimer", + "description": "on/off", "type": "bool" }, { @@ -28510,7 +28574,7 @@ "type": "bool" }, { - "name": "sgx1", + "name": "vmx-exit-load-pat", "type": "bool" }, { @@ -28526,7 +28590,8 @@ "type": "bool" }, { - "name": "vmx-exit-load-pat", + "name": "hv-tlbflush-ext", + "description": "on/off", "type": "bool" }, { @@ -28551,7 +28616,7 @@ "type": "bool" }, { - "name": "clzero", + "name": "sgx-exinfo", "type": "bool" }, { @@ -28563,15 +28628,15 @@ "type": "bool" }, { - "name": "sgx-exinfo", + "name": "legacy-cache", "type": "bool" }, { - "name": "legacy-cache", + "name": "sse", "type": "bool" }, { - "name": "sse", + "name": "clzero", "type": "bool" }, { @@ -28616,23 +28681,23 @@ "type": "bool" }, { - "name": "nrip-save", + "name": "vmx-rdrand-exit", "type": "bool" }, { - "name": "gfni", + "name": "nrip-save", "type": "bool" }, { - "name": "kvm-mmu", + "name": "gfni", "type": "bool" }, { - "name": "vmx-rdrand-exit", + "name": "kvm-mmu", "type": "bool" }, { - "name": "ace2", + "name": "kvm-msi-ext-dest-id", "type": "bool" }, { @@ -28652,7 +28717,7 @@ "type": "bool" }, { - "name": "sse2", + "name": "ace2", "type": "bool" }, { @@ -28664,7 +28729,7 @@ "type": "bool" }, { - "name": "kvm-msi-ext-dest-id", + "name": "topoext", "type": "bool" }, { @@ -28688,7 +28753,7 @@ "type": "bool" }, { - "name": "topoext", + "name": "sse2", "type": "bool" }, { @@ -28720,13 +28785,17 @@ "type": "bool" }, { - "name": "mmxext", + "name": "vmx-ple", "type": "bool" }, { - "name": "vmx-ple", + "name": "mmxext", "type": "bool" }, + { + "name": "lbr-fmt", + "type": "uint64" + }, { "name": "bus-lock-detect", "type": "bool" @@ -28804,13 +28873,18 @@ "type": "bool" }, { - "name": "xsave", + "name": "amx-tile", "type": "bool" }, { "name": "xtpr", "type": "bool" }, + { + "name": "hv-xmm-input", + "description": "on/off", + "type": "bool" + }, { "name": "vmx-tsc-offset", "type": "bool" @@ -28836,7 +28910,7 @@ "type": "strList" }, { - "name": "amx-tile", + "name": "xsave", "type": "bool" }, { @@ -29112,11 +29186,11 @@ "type": "int32" }, { - "name": "ss", + "name": "de", "type": "bool" }, { - "name": "de", + "name": "ss", "type": "bool" }, { @@ -29155,6 +29229,10 @@ "name": "nrip_save", "type": "bool" }, + { + "name": "lbr_fmt", + "type": "uint64" + }, { "name": "pclmuldq", "type": "bool" @@ -29820,6 +29898,16 @@ "description": "Overrides the \"compatible\" property of the dt root node", "type": "string" }, + { + "name": "boot", + "description": "Boot configuration", + "type": "BootConfiguration" + }, + { + "name": "memory", + "description": "Memory size configuration", + "type": "MemorySizeConfiguration" + }, { "name": "initrd", "description": "Linux initial ramdisk file", @@ -29873,7 +29961,7 @@ { "name": "memory-backend", "description": "Set RAM backendValid value is ID of hostmem based backend", - "type": "string" + "type": "link<memory-backend>" }, { "name": "dtb", @@ -31072,46 +31160,14 @@ "deprecated": false }, { - "name": "Icelake-Server-v1", - "typename": "Icelake-Server-v1-x86_64-cpu", - "unavailable-features": [ - "pcid", - "hle", - "erms", - "invpcid", - "rtm", - "avx512f", - "avx512dq", - "avx512cd", - "avx512bw", - "avx512vl", - "avx512vbmi", - "pku", - "avx512vbmi2", - "gfni", - "vaes", - "vpclmulqdq", - "avx512vnni", - "avx512bitalg", - "avx512-vpopcntdq", - "la57", - "spec-ctrl", - "avx512f", - "avx512f", - "avx512f", - "pku" - ], - "static": false, - "migration-safe": true, - "deprecated": false - }, - { - "name": "Icelake-Server-noTSX", - "typename": "Icelake-Server-noTSX-x86_64-cpu", + "name": "Icelake-Server-v1", + "typename": "Icelake-Server-v1-x86_64-cpu", "unavailable-features": [ "pcid", + "hle", "erms", "invpcid", + "rtm", "avx512f", "avx512dq", "avx512cd", @@ -31133,20 +31189,17 @@ "avx512f", "pku" ], - "alias-of": "Icelake-Server-v2", "static": false, "migration-safe": true, "deprecated": false }, { - "name": "Icelake-Server", - "typename": "Icelake-Server-x86_64-cpu", + "name": "Icelake-Server-noTSX", + "typename": "Icelake-Server-noTSX-x86_64-cpu", "unavailable-features": [ "pcid", - "hle", "erms", "invpcid", - "rtm", "avx512f", "avx512dq", "avx512cd", @@ -31168,115 +31221,25 @@ "avx512f", "pku" ], - "alias-of": "Icelake-Server-v1", + "alias-of": "Icelake-Server-v2", "static": false, "migration-safe": true, "deprecated": false }, { - "name": "Icelake-Client-v3", - "typename": "Icelake-Client-v3-x86_64-cpu", - "unavailable-features": [ - "pcid", - "erms", - "invpcid", - "avx512vbmi", - "pku", - "avx512vbmi2", - "gfni", - "vaes", - "vpclmulqdq", - "avx512vnni", - "avx512bitalg", - "avx512-vpopcntdq", - "spec-ctrl", - "pku" - ], - "static": false, - "migration-safe": true, - "deprecated": true - }, - { - "name": "Icelake-Client-v2", - "typename": "Icelake-Client-v2-x86_64-cpu", - "unavailable-features": [ - "pcid", - "erms", - "invpcid", - "avx512vbmi", - "pku", - "avx512vbmi2", - "gfni", - "vaes", - "vpclmulqdq", - "avx512vnni", - "avx512bitalg", - "avx512-vpopcntdq", - "spec-ctrl", - "pku" - ], - "static": false, - "migration-safe": true, - "deprecated": true - }, - { - "name": "Icelake-Client-v1", - "typename": "Icelake-Client-v1-x86_64-cpu", - "unavailable-features": [ - "pcid", - "hle", - "erms", - "invpcid", - "rtm", - "avx512vbmi", - "pku", - "avx512vbmi2", - "gfni", - "vaes", - "vpclmulqdq", - "avx512vnni", - "avx512bitalg", - "avx512-vpopcntdq", - "spec-ctrl", - "pku" - ], - "static": false, - "migration-safe": true, - "deprecated": true - }, - { - "name": "Icelake-Client-noTSX", - "typename": "Icelake-Client-noTSX-x86_64-cpu", - "unavailable-features": [ - "pcid", - "erms", - "invpcid", - "avx512vbmi", - "pku", - "avx512vbmi2", - "gfni", - "vaes", - "vpclmulqdq", - "avx512vnni", - "avx512bitalg", - "avx512-vpopcntdq", - "spec-ctrl", - "pku" - ], - "alias-of": "Icelake-Client-v2", - "static": false, - "migration-safe": true, - "deprecated": true - }, - { - "name": "Icelake-Client", - "typename": "Icelake-Client-x86_64-cpu", + "name": "Icelake-Server", + "typename": "Icelake-Server-x86_64-cpu", "unavailable-features": [ "pcid", "hle", "erms", "invpcid", "rtm", + "avx512f", + "avx512dq", + "avx512cd", + "avx512bw", + "avx512vl", "avx512vbmi", "pku", "avx512vbmi2", @@ -31286,13 +31249,17 @@ "avx512vnni", "avx512bitalg", "avx512-vpopcntdq", + "la57", "spec-ctrl", + "avx512f", + "avx512f", + "avx512f", "pku" ], - "alias-of": "Icelake-Client-v1", + "alias-of": "Icelake-Server-v1", "static": false, "migration-safe": true, - "deprecated": true + "deprecated": false }, { "name": "Haswell-v4", @@ -33561,6 +33528,7 @@ "avx512-bf16": false, "vmx-cr8-load-exit": false, "xsaveopt": true, + "arch-lbr": false, "vmx-apicv-vid": false, "vmx-exit-save-pat": false, "xtpr": false, @@ -33597,7 +33565,7 @@ "smx": false, "cmp-legacy": true, "avx512-4fmaps": false, - "vmcb-clean": false, + "vmcb-clean": true, "hle": false, "avx-vnni": false, "3dnowext": false, @@ -33912,6 +33880,7 @@ "avx512-bf16": false, "vmx-cr8-load-exit": false, "xsaveopt": true, + "arch-lbr": false, "vmx-apicv-vid": false, "vmx-exit-save-pat": false, "xtpr": false, @@ -33948,7 +33917,7 @@ "smx": false, "cmp-legacy": true, "avx512-4fmaps": false, - "vmcb-clean": false, + "vmcb-clean": true, "hle": false, "avx-vnni": false, "3dnowext": false, @@ -35674,168 +35643,6 @@ "migration-safe": true, "deprecated": false }, - { - "name": "Icelake-Client-v3", - "typename": "Icelake-Client-v3-x86_64-cpu", - "unavailable-features": [ - "fma", - "pcid", - "x2apic", - "tsc-deadline", - "avx", - "f16c", - "avx2", - "invpcid", - "rdseed", - "avx512vbmi", - "avx512vbmi2", - "gfni", - "vaes", - "vpclmulqdq", - "avx512vnni", - "avx512bitalg", - "avx512-vpopcntdq", - "spec-ctrl", - "ssbd", - "3dnowprefetch", - "wbnoinvd", - "xsavec", - "xsaves" - ], - "static": false, - "migration-safe": true, - "deprecated": true - }, - { - "name": "Icelake-Client-v2", - "typename": "Icelake-Client-v2-x86_64-cpu", - "unavailable-features": [ - "fma", - "pcid", - "x2apic", - "tsc-deadline", - "avx", - "f16c", - "avx2", - "invpcid", - "rdseed", - "avx512vbmi", - "avx512vbmi2", - "gfni", - "vaes", - "vpclmulqdq", - "avx512vnni", - "avx512bitalg", - "avx512-vpopcntdq", - "spec-ctrl", - "ssbd", - "3dnowprefetch", - "wbnoinvd", - "xsavec" - ], - "static": false, - "migration-safe": true, - "deprecated": true - }, - { - "name": "Icelake-Client-v1", - "typename": "Icelake-Client-v1-x86_64-cpu", - "unavailable-features": [ - "fma", - "pcid", - "x2apic", - "tsc-deadline", - "avx", - "f16c", - "hle", - "avx2", - "invpcid", - "rtm", - "rdseed", - "avx512vbmi", - "avx512vbmi2", - "gfni", - "vaes", - "vpclmulqdq", - "avx512vnni", - "avx512bitalg", - "avx512-vpopcntdq", - "spec-ctrl", - "ssbd", - "3dnowprefetch", - "wbnoinvd", - "xsavec" - ], - "static": false, - "migration-safe": true, - "deprecated": true - }, - { - "name": "Icelake-Client-noTSX", - "typename": "Icelake-Client-noTSX-x86_64-cpu", - "unavailable-features": [ - "fma", - "pcid", - "x2apic", - "tsc-deadline", - "avx", - "f16c", - "avx2", - "invpcid", - "rdseed", - "avx512vbmi", - "avx512vbmi2", - "gfni", - "vaes", - "vpclmulqdq", - "avx512vnni", - "avx512bitalg", - "avx512-vpopcntdq", - "spec-ctrl", - "ssbd", - "3dnowprefetch", - "wbnoinvd", - "xsavec" - ], - "alias-of": "Icelake-Client-v2", - "static": false, - "migration-safe": true, - "deprecated": true - }, - { - "name": "Icelake-Client", - "typename": "Icelake-Client-x86_64-cpu", - "unavailable-features": [ - "fma", - "pcid", - "x2apic", - "tsc-deadline", - "avx", - "f16c", - "hle", - "avx2", - "invpcid", - "rtm", - "rdseed", - "avx512vbmi", - "avx512vbmi2", - "gfni", - "vaes", - "vpclmulqdq", - "avx512vnni", - "avx512bitalg", - "avx512-vpopcntdq", - "spec-ctrl", - "ssbd", - "3dnowprefetch", - "wbnoinvd", - "xsavec" - ], - "alias-of": "Icelake-Client-v1", - "static": false, - "migration-safe": true, - "deprecated": true - }, { "name": "Haswell-v4", "typename": "Haswell-v4-x86_64-cpu", @@ -37057,6 +36864,7 @@ "avx512-bf16": false, "vmx-cr8-load-exit": false, "xsaveopt": true, + "arch-lbr": false, "vmx-apicv-vid": false, "vmx-exit-save-pat": false, "xtpr": false, @@ -37408,6 +37216,7 @@ "avx512-bf16": false, "vmx-cr8-load-exit": false, "xsaveopt": true, + "arch-lbr": false, "vmx-apicv-vid": false, "vmx-exit-save-pat": false, "xtpr": false, diff --git a/tests/qemucapabilitiesdata/caps_7.1.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_7.1.0.x86_64.xml index bdc613a54a..04ba103688 100644 --- a/tests/qemucapabilitiesdata/caps_7.1.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_7.1.0.x86_64.xml @@ -246,7 +246,7 @@ <version>7000050</version> <kvmVersion>0</kvmVersion> <microcodeVersion>43100244</microcodeVersion> - <package>v7.0.0-930-g178bacb66d</package> + <package>v7.0.0-1512-gca127b3fc2</package> <arch>x86_64</arch> <hostCPU type='kvm' model='base' migratability='yes'> <property name='vmx-entry-load-rtit-ctl' type='boolean' value='false'/> @@ -310,6 +310,7 @@ <property name='avx512-bf16' type='boolean' value='false'/> <property name='vmx-cr8-load-exit' type='boolean' value='false'/> <property name='xsaveopt' type='boolean' value='true' migratable='yes'/> + <property name='arch-lbr' type='boolean' value='false'/> <property name='vmx-apicv-vid' type='boolean' value='false'/> <property name='vmx-exit-save-pat' type='boolean' value='false'/> <property name='xtpr' type='boolean' value='false'/> @@ -346,7 +347,7 @@ <property name='smx' type='boolean' value='false'/> <property name='cmp-legacy' type='boolean' value='true' migratable='yes'/> <property name='avx512-4fmaps' type='boolean' value='false'/> - <property name='vmcb-clean' type='boolean' value='false'/> + <property name='vmcb-clean' type='boolean' value='true' migratable='yes'/> <property name='hle' type='boolean' value='false'/> <property name='avx-vnni' type='boolean' value='false'/> <property name='3dnowext' type='boolean' value='false'/> @@ -1173,90 +1174,6 @@ <blocker name='avx512f'/> <blocker name='pku'/> </cpu> - <cpu type='kvm' name='Icelake-Client-v3' typename='Icelake-Client-v3-x86_64-cpu' usable='no' deprecated='yes'> - <blocker name='pcid'/> - <blocker name='erms'/> - <blocker name='invpcid'/> - <blocker name='avx512vbmi'/> - <blocker name='pku'/> - <blocker name='avx512vbmi2'/> - <blocker name='gfni'/> - <blocker name='vaes'/> - <blocker name='vpclmulqdq'/> - <blocker name='avx512vnni'/> - <blocker name='avx512bitalg'/> - <blocker name='avx512-vpopcntdq'/> - <blocker name='spec-ctrl'/> - <blocker name='pku'/> - </cpu> - <cpu type='kvm' name='Icelake-Client-v2' typename='Icelake-Client-v2-x86_64-cpu' usable='no' deprecated='yes'> - <blocker name='pcid'/> - <blocker name='erms'/> - <blocker name='invpcid'/> - <blocker name='avx512vbmi'/> - <blocker name='pku'/> - <blocker name='avx512vbmi2'/> - <blocker name='gfni'/> - <blocker name='vaes'/> - <blocker name='vpclmulqdq'/> - <blocker name='avx512vnni'/> - <blocker name='avx512bitalg'/> - <blocker name='avx512-vpopcntdq'/> - <blocker name='spec-ctrl'/> - <blocker name='pku'/> - </cpu> - <cpu type='kvm' name='Icelake-Client-v1' typename='Icelake-Client-v1-x86_64-cpu' usable='no' deprecated='yes'> - <blocker name='pcid'/> - <blocker name='hle'/> - <blocker name='erms'/> - <blocker name='invpcid'/> - <blocker name='rtm'/> - <blocker name='avx512vbmi'/> - <blocker name='pku'/> - <blocker name='avx512vbmi2'/> - <blocker name='gfni'/> - <blocker name='vaes'/> - <blocker name='vpclmulqdq'/> - <blocker name='avx512vnni'/> - <blocker name='avx512bitalg'/> - <blocker name='avx512-vpopcntdq'/> - <blocker name='spec-ctrl'/> - <blocker name='pku'/> - </cpu> - <cpu type='kvm' name='Icelake-Client-noTSX' typename='Icelake-Client-noTSX-x86_64-cpu' usable='no' deprecated='yes'> - <blocker name='pcid'/> - <blocker name='erms'/> - <blocker name='invpcid'/> - <blocker name='avx512vbmi'/> - <blocker name='pku'/> - <blocker name='avx512vbmi2'/> - <blocker name='gfni'/> - <blocker name='vaes'/> - <blocker name='vpclmulqdq'/> - <blocker name='avx512vnni'/> - <blocker name='avx512bitalg'/> - <blocker name='avx512-vpopcntdq'/> - <blocker name='spec-ctrl'/> - <blocker name='pku'/> - </cpu> - <cpu type='kvm' name='Icelake-Client' typename='Icelake-Client-x86_64-cpu' usable='no' deprecated='yes'> - <blocker name='pcid'/> - <blocker name='hle'/> - <blocker name='erms'/> - <blocker name='invpcid'/> - <blocker name='rtm'/> - <blocker name='avx512vbmi'/> - <blocker name='pku'/> - <blocker name='avx512vbmi2'/> - <blocker name='gfni'/> - <blocker name='vaes'/> - <blocker name='vpclmulqdq'/> - <blocker name='avx512vnni'/> - <blocker name='avx512bitalg'/> - <blocker name='avx512-vpopcntdq'/> - <blocker name='spec-ctrl'/> - <blocker name='pku'/> - </cpu> <cpu type='kvm' name='Haswell-v4' typename='Haswell-v4-x86_64-cpu' usable='no'> <blocker name='pcid'/> <blocker name='erms'/> @@ -1732,6 +1649,7 @@ <property name='avx512-bf16' type='boolean' value='false'/> <property name='vmx-cr8-load-exit' type='boolean' value='false'/> <property name='xsaveopt' type='boolean' value='true' migratable='yes'/> + <property name='arch-lbr' type='boolean' value='false'/> <property name='vmx-apicv-vid' type='boolean' value='false'/> <property name='vmx-exit-save-pat' type='boolean' value='false'/> <property name='xtpr' type='boolean' value='false'/> @@ -2806,131 +2724,6 @@ <blocker name='wbnoinvd'/> <blocker name='xsavec'/> </cpu> - <cpu type='tcg' name='Icelake-Client-v3' typename='Icelake-Client-v3-x86_64-cpu' usable='no' deprecated='yes'> - <blocker name='fma'/> - <blocker name='pcid'/> - <blocker name='x2apic'/> - <blocker name='tsc-deadline'/> - <blocker name='avx'/> - <blocker name='f16c'/> - <blocker name='avx2'/> - <blocker name='invpcid'/> - <blocker name='rdseed'/> - <blocker name='avx512vbmi'/> - <blocker name='avx512vbmi2'/> - <blocker name='gfni'/> - <blocker name='vaes'/> - <blocker name='vpclmulqdq'/> - <blocker name='avx512vnni'/> - <blocker name='avx512bitalg'/> - <blocker name='avx512-vpopcntdq'/> - <blocker name='spec-ctrl'/> - <blocker name='ssbd'/> - <blocker name='3dnowprefetch'/> - <blocker name='wbnoinvd'/> - <blocker name='xsavec'/> - <blocker name='xsaves'/> - </cpu> - <cpu type='tcg' name='Icelake-Client-v2' typename='Icelake-Client-v2-x86_64-cpu' usable='no' deprecated='yes'> - <blocker name='fma'/> - <blocker name='pcid'/> - <blocker name='x2apic'/> - <blocker name='tsc-deadline'/> - <blocker name='avx'/> - <blocker name='f16c'/> - <blocker name='avx2'/> - <blocker name='invpcid'/> - <blocker name='rdseed'/> - <blocker name='avx512vbmi'/> - <blocker name='avx512vbmi2'/> - <blocker name='gfni'/> - <blocker name='vaes'/> - <blocker name='vpclmulqdq'/> - <blocker name='avx512vnni'/> - <blocker name='avx512bitalg'/> - <blocker name='avx512-vpopcntdq'/> - <blocker name='spec-ctrl'/> - <blocker name='ssbd'/> - <blocker name='3dnowprefetch'/> - <blocker name='wbnoinvd'/> - <blocker name='xsavec'/> - </cpu> - <cpu type='tcg' name='Icelake-Client-v1' typename='Icelake-Client-v1-x86_64-cpu' usable='no' deprecated='yes'> - <blocker name='fma'/> - <blocker name='pcid'/> - <blocker name='x2apic'/> - <blocker name='tsc-deadline'/> - <blocker name='avx'/> - <blocker name='f16c'/> - <blocker name='hle'/> - <blocker name='avx2'/> - <blocker name='invpcid'/> - <blocker name='rtm'/> - <blocker name='rdseed'/> - <blocker name='avx512vbmi'/> - <blocker name='avx512vbmi2'/> - <blocker name='gfni'/> - <blocker name='vaes'/> - <blocker name='vpclmulqdq'/> - <blocker name='avx512vnni'/> - <blocker name='avx512bitalg'/> - <blocker name='avx512-vpopcntdq'/> - <blocker name='spec-ctrl'/> - <blocker name='ssbd'/> - <blocker name='3dnowprefetch'/> - <blocker name='wbnoinvd'/> - <blocker name='xsavec'/> - </cpu> - <cpu type='tcg' name='Icelake-Client-noTSX' typename='Icelake-Client-noTSX-x86_64-cpu' usable='no' deprecated='yes'> - <blocker name='fma'/> - <blocker name='pcid'/> - <blocker name='x2apic'/> - <blocker name='tsc-deadline'/> - <blocker name='avx'/> - <blocker name='f16c'/> - <blocker name='avx2'/> - <blocker name='invpcid'/> - <blocker name='rdseed'/> - <blocker name='avx512vbmi'/> - <blocker name='avx512vbmi2'/> - <blocker name='gfni'/> - <blocker name='vaes'/> - <blocker name='vpclmulqdq'/> - <blocker name='avx512vnni'/> - <blocker name='avx512bitalg'/> - <blocker name='avx512-vpopcntdq'/> - <blocker name='spec-ctrl'/> - <blocker name='ssbd'/> - <blocker name='3dnowprefetch'/> - <blocker name='wbnoinvd'/> - <blocker name='xsavec'/> - </cpu> - <cpu type='tcg' name='Icelake-Client' typename='Icelake-Client-x86_64-cpu' usable='no' deprecated='yes'> - <blocker name='fma'/> - <blocker name='pcid'/> - <blocker name='x2apic'/> - <blocker name='tsc-deadline'/> - <blocker name='avx'/> - <blocker name='f16c'/> - <blocker name='hle'/> - <blocker name='avx2'/> - <blocker name='invpcid'/> - <blocker name='rtm'/> - <blocker name='rdseed'/> - <blocker name='avx512vbmi'/> - <blocker name='avx512vbmi2'/> - <blocker name='gfni'/> - <blocker name='vaes'/> - <blocker name='vpclmulqdq'/> - <blocker name='avx512vnni'/> - <blocker name='avx512bitalg'/> - <blocker name='avx512-vpopcntdq'/> - <blocker name='spec-ctrl'/> - <blocker name='ssbd'/> - <blocker name='3dnowprefetch'/> - <blocker name='wbnoinvd'/> - <blocker name='xsavec'/> - </cpu> <cpu type='tcg' name='Haswell-v4' typename='Haswell-v4-x86_64-cpu' usable='no'> <blocker name='fma'/> <blocker name='pcid'/> diff --git a/tests/qemuxml2argvdata/cpu-host-model.x86_64-latest.args b/tests/qemuxml2argvdata/cpu-host-model.x86_64-latest.args index fef92b02ba..853f0d9505 100644 --- a/tests/qemuxml2argvdata/cpu-host-model.x86_64-latest.args +++ b/tests/qemuxml2argvdata/cpu-host-model.x86_64-latest.args @@ -12,7 +12,7 @@ XDG_CONFIG_HOME=/tmp/lib/domain--1-QEMUGuest1/.config \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/tmp/lib/domain--1-QEMUGuest1/master-key.aes"}' \ -machine q35,usb=off,dump-guest-core=off,memory-backend=pc.ram \ -accel kvm \ --cpu EPYC-Rome,x2apic=on,tsc-deadline=on,hypervisor=on,tsc-adjust=on,stibp=on,arch-capabilities=on,ssbd=on,xsaves=on,cmp-legacy=on,amd-ssbd=on,virt-ssbd=on,tsc-scale=on,svme-addr-chk=on,rdctl-no=on,skip-l1dfl-vmentry=on,mds-no=on,pschange-mc-no=on \ +-cpu EPYC-Rome,x2apic=on,tsc-deadline=on,hypervisor=on,tsc-adjust=on,stibp=on,arch-capabilities=on,ssbd=on,xsaves=on,cmp-legacy=on,amd-ssbd=on,virt-ssbd=on,tsc-scale=on,vmcb-clean=on,svme-addr-chk=on,rdctl-no=on,skip-l1dfl-vmentry=on,mds-no=on,pschange-mc-no=on \ -m 214 \ -object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":224395264}' \ -overcommit mem-lock=off \ -- 2.36.1

2 1

[libvirt PATCH v2 00/81] Add support for post-copy recovery
by Jiri Denemark 06 Jun '22

06 Jun '22

This series implements a new VIR_MIGRATE_POSTCOPY_RESUME flag (virsh migrate --resume) for recovering from a failed post-copy migration. You can also fetch the series from my gitlab fork (the last RFC patch is missing there): git fetch https://gitlab.com/jirkade/libvirt.git post-copy-recovery Version 2: - rebased and changed Since tags to 8.5.0 - even patches marked as "no change" can be a bit different as required by rebasing to the current master or changes in other patches - replaced a few patches with the "qemu: Drop QEMU_CAPS_MIGRATION_EVENT" series: - [03/80] qemu: Return state from qemuMonitorGetMigrationCapabilities - [04/80] qemu: Enable migration events only when disabled - [20/80] qemu: Use switch in qemuDomainGetJobInfoMigrationStats - see individual patches for additional details - most of the patches were acked in v1, the following patches did not earn a Reviewed-by tag, were changed and lost the tag, or were added since the previous version of this series: - [03] Introduce VIR_DOMAIN_RUNNING_POSTCOPY_FAILED - [04] qemu: Keep domain running on dst on failed post-copy migration - [15] qemu: Restore async job start timestamp on reconnect - [19] qemu: Use switch in qemuProcessHandleMigrationStatus - [20] qemu: Handle 'postcopy-paused' migration state - [21] qemu: Add support for postcopy-recover QEMU migration state - [33] qemu: Introduce qemuMigrationDstFinishActive - [34] qemu: Handle migration job in qemuMigrationDstFinish - [45] qemu: Make qemuMigrationCheckPhase failure fatal - [48] qemu: Use QEMU_MIGRATION_PHASE_POSTCOPY_FAILED - [52] qemu: Implement VIR_MIGRATE_POSTCOPY_RESUME for Begin phase - [60] qemu: Use autoptr for mig in qemuMigrationDstPrepareFresh - [76] qemu: Implement VIR_DOMAIN_ABORT_JOB_POSTCOPY flag - [79] Introduce VIR_JOB_MIGRATION_SAFE job type - [80] qemu: Fix VSERPORT_CHANGE event in post-copy migration - [81] RFC: qemu: Keep vCPUs paused while migration is in postcopy-paused Jiri Denemark (81): qemu: Add debug messages to job recovery code qemumonitorjsontest: Test more migration capabilities Introduce VIR_DOMAIN_RUNNING_POSTCOPY_FAILED qemu: Keep domain running on dst on failed post-copy migration qemu: Explicitly emit events on post-copy failure qemu: Make qemuDomainCleanupAdd return void conf: Introduce virDomainObjIsFailedPostcopy helper conf: Introduce virDomainObjIsPostcopy helper qemu: Introduce qemuProcessCleanupMigrationJob qemu: Rename qemuDomainObjRestoreJob as qemuDomainObjPreserveJob qemu: Add qemuDomainObjRestoreAsyncJob qemu: Keep migration job active after failed post-copy qemu: Abort failed post-copy when we haven't called Finish yet qemu: Restore failed migration job on reconnect qemu: Restore async job start timestamp on reconnect qemu: Drop forward declarations in migration code qemu: Don't wait for migration job when migration is running qemu: Fetch paused migration stats qemu: Use switch in qemuProcessHandleMigrationStatus qemu: Handle 'postcopy-paused' migration state qemu: Add support for postcopy-recover QEMU migration state qemu: Create domain object at the end of qemuMigrationDstFinish qemu: Move success-only code out of endjob in qemuMigrationDstFinish qemu: Separate success and failure path in qemuMigrationDstFinish qemu: Rename "endjob" label in qemuMigrationDstFinish qemu: Generate migration cookie in Finish phase earlier qemu: Make final part of migration Finish phase reusable qemu: Drop obsolete comment in qemuMigrationDstFinish qemu: Preserve error in qemuMigrationDstFinish qemu: Introduce qemuMigrationDstFinishFresh qemu: Introduce qemuMigrationDstFinishOffline qemu: Separate cookie parsing for qemuMigrationDstFinishOffline qemu: Introduce qemuMigrationDstFinishActive qemu: Handle migration job in qemuMigrationDstFinish qemu: Make final part of migration Confirm phase reusable qemu: Make sure migrationPort is released even in callbacks qemu: Pass qemuDomainJobObj to qemuMigrationDstComplete qemu: Finish completed unattended migration qemu: Ignore missing memory statistics in query-migrate qemu: Improve post-copy migration handling on reconnect qemu: Check flags incompatible with offline migration earlier qemu: Introduce qemuMigrationSrcBeginXML helper qemu: Add new migration phases for post-copy recovery qemu: Separate protocol checks from qemuMigrationJobSetPhase qemu: Make qemuMigrationCheckPhase failure fatal qemu: Refactor qemuDomainObjSetJobPhase qemu: Do not set job owner in qemuMigrationJobSetPhase qemu: Use QEMU_MIGRATION_PHASE_POSTCOPY_FAILED Introduce VIR_MIGRATE_POSTCOPY_RESUME flag virsh: Add --postcopy-resume option for migrate command qemu: Don't set VIR_MIGRATE_PAUSED for post-copy resume qemu: Implement VIR_MIGRATE_POSTCOPY_RESUME for Begin phase qemu: Refactor qemuMigrationSrcPerformPhase qemu: Separate starting migration from qemuMigrationSrcRun qemu: Add support for 'resume' parameter of migrate QMP command qemu: Implement VIR_MIGRATE_POSTCOPY_RESUME for Perform phase qemu: Implement VIR_MIGRATE_POSTCOPY_RESUME for Confirm phase qemu: Introduce qemuMigrationDstPrepareFresh qemu: Refactor qemuMigrationDstPrepareFresh qemu: Use autoptr for mig in qemuMigrationDstPrepareFresh qemu: Add support for migrate-recover QMP command qemu: Rename qemuMigrationSrcCleanup qemu: Refactor qemuMigrationAnyConnectionClosed qemu: Handle incoming migration in qemuMigrationAnyConnectionClosed qemu: Start a migration phase in qemuMigrationAnyConnectionClosed qemu: Implement VIR_MIGRATE_POSTCOPY_RESUME for Prepare phase qemu: Implement VIR_MIGRATE_POSTCOPY_RESUME for Finish phase qemu: Create completed jobData in qemuMigrationSrcComplete qemu: Register qemuProcessCleanupMigrationJob after Begin phase qemu: Call qemuDomainCleanupAdd from qemuMigrationJobContinue qemu: Implement VIR_MIGRATE_POSTCOPY_RESUME for peer-to-peer migration qemu: Enable support for VIR_MIGRATE_POSTCOPY_RESUME Add virDomainAbortJobFlags public API qemu: Implement virDomainAbortJobFlags Add VIR_DOMAIN_ABORT_JOB_POSTCOPY flag for virDomainAbortJobFlags qemu: Implement VIR_DOMAIN_ABORT_JOB_POSTCOPY flag virsh: Add --postcopy option for domjobabort command NEWS: Add support for post-copy recovery Introduce VIR_JOB_MIGRATION_SAFE job type qemu: Fix VSERPORT_CHANGE event in post-copy migration RFC: qemu: Keep vCPUs paused while migration is in postcopy-paused NEWS.rst | 5 + docs/manpages/virsh.rst | 17 +- examples/c/misc/event-test.c | 3 + include/libvirt/libvirt-domain.h | 26 + src/conf/domain_conf.c | 33 + src/conf/domain_conf.h | 8 + src/driver-hypervisor.h | 5 + src/hypervisor/domain_job.c | 2 + src/hypervisor/domain_job.h | 5 + src/libvirt-domain.c | 83 +- src/libvirt_private.syms | 2 + src/libvirt_public.syms | 5 + src/qemu/qemu_domain.c | 10 +- src/qemu/qemu_domain.h | 6 +- src/qemu/qemu_domainjob.c | 106 +- src/qemu/qemu_domainjob.h | 16 +- src/qemu/qemu_driver.c | 104 +- src/qemu/qemu_migration.c | 2420 ++++++++++++----- src/qemu/qemu_migration.h | 43 +- src/qemu/qemu_monitor.c | 22 + src/qemu/qemu_monitor.h | 10 + src/qemu/qemu_monitor_json.c | 127 +- src/qemu/qemu_monitor_json.h | 7 + src/qemu/qemu_process.c | 405 ++- src/qemu/qemu_process.h | 3 + src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 14 +- src/remote_protocol-structs | 5 + tests/qemumonitorjsontest.c | 32 +- .../migration-in-params-in.xml | 2 +- .../migration-out-nbd-bitmaps-in.xml | 2 +- .../migration-out-nbd-out.xml | 2 +- .../migration-out-nbd-tls-out.xml | 2 +- .../migration-out-params-in.xml | 2 +- tools/virsh-domain-event.c | 3 +- tools/virsh-domain-monitor.c | 1 + tools/virsh-domain.c | 24 +- 37 files changed, 2628 insertions(+), 935 deletions(-) -- 2.35.1

5 113

[PATCH] util: json: Add modifier for adding non-negative long values to JSON objects
by Peter Krempa 06 Jun '22

06 Jun '22

Similarly to the 'k' modifier for integers introduce 'K' for long integers. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/util/virjson.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/util/virjson.c b/src/util/virjson.c index 6e13e97e15..ae970c7653 100644 --- a/src/util/virjson.c +++ b/src/util/virjson.c @@ -121,6 +121,7 @@ virJSONValueGetType(const virJSONValue *value) * * I: signed long integer value * J: signed long integer value, error if negative + * K: signed long integer value, omitted if negative * Z: signed long integer value, omitted if zero * Y: signed long integer value, omitted if zero, error if negative * @@ -228,6 +229,7 @@ virJSONValueObjectAddVArgs(virJSONValue **objptr, case 'Z': case 'Y': + case 'K': case 'J': case 'I': { long long val = va_arg(args, long long); @@ -242,6 +244,9 @@ virJSONValueObjectAddVArgs(virJSONValue **objptr, if (!val && (type == 'Z' || type == 'Y')) continue; + if (val < 0 && type == 'K') + continue; + rc = virJSONValueObjectAppendNumberLong(obj, key, val); } break; -- 2.35.3

3 3

[PATCH] qemu: Fix crash in qemuBuildDeviceCommandlineHandleOverrides
by Peter Krempa 06 Jun '22

06 Jun '22

'STREQ' is used to compare the override alias with the device alias. While the parser ensures that the override alias is non-NULL, the device alias may be NULL and STREQ doesn't handle that. Fixes: 38ab5c9ead5 Resolves: https://gitlab.com/libvirt/libvirt/-/issues/321 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_command.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 52e4ef03cd..b1be77743c 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -240,6 +240,10 @@ qemuBuildDeviceCommandlineHandleOverrides(virJSONValue *props, const char *alias = virJSONValueObjectGetString(props, "id"); size_t i; + /* If the device doesn't have an alias we can't override it's props */ + if (!alias) + return; + for (i = 0; i < nsdef->ndeviceOverride; i++) { qemuDomainXmlNsDeviceOverride *dev = nsdef->deviceOverride + i; size_t j; -- 2.36.1

3 2

[libvirt][PATCH RESEND v12 0/6] Support query and use SGX
by Haibin Huang 06 Jun '22

06 Jun '22

This patch series provides support for enabling Intel's Software Guard Extensions (SGX) feature in guest VM. Giving the SGX support in QEMU had been merged. Intel SGX is a set of instructions that increases the security of application code and data, giving them more protection from disclosure or modification. Developers can partition sensitive information into enclaves, which are areas of execution in memory with more security protection. The typical flow looks below at very high level: 1. Calls virConnectGetDomainCapabilities API to domain capabilities that includes the following SGX information. <feature> ... <sgx supported='yes'> <epc_size unit='KiB'>N</epc_size> </sgx> ... </feature> 2. User requests to start a guest calling virCreateXML() with SGX requirement. It does not support NUMA yet, since latest QEMU 6.2 release does not support NUMA. It should contain <devices> ... <memory model='sgx-epc'> <target> <size unit='KiB'>N</size> </target> </memory> ... </devices> Please note that SGX NUMA support will be implemented in future patches. Haibin Huang (4): Define SGX capabilities structs Get SGX capabilities form QMP Convert QMP capabilities to domain capabilities conf: expose SGX feature in domain capabilities Lin Yang (2): conf: Introduce SGX EPC element into device memory xml qemu: Add command-line to generate SGX EPC memory backend docs/formatdomain.rst | 9 +- docs/formatdomaincaps.rst | 26 ++++ src/conf/domain_capabilities.c | 33 ++++ src/conf/domain_capabilities.h | 13 ++ src/conf/domain_conf.c | 6 + src/conf/domain_conf.h | 1 + src/conf/domain_validate.c | 16 ++ src/conf/schemas/domaincaps.rng | 22 ++- src/conf/schemas/domaincommon.rng | 1 + src/libvirt_private.syms | 1 + src/qemu/qemu_alias.c | 6 +- src/qemu/qemu_capabilities.c | 145 ++++++++++++++++++ src/qemu/qemu_capabilities.h | 4 + src/qemu/qemu_capspriv.h | 4 + src/qemu/qemu_command.c | 54 ++++++- src/qemu/qemu_domain.c | 38 +++-- src/qemu/qemu_domain_address.c | 6 + src/qemu/qemu_driver.c | 1 + src/qemu/qemu_monitor.c | 10 ++ src/qemu/qemu_monitor.h | 3 + src/qemu/qemu_monitor_json.c | 104 ++++++++++++- src/qemu/qemu_monitor_json.h | 9 ++ src/qemu/qemu_process.c | 2 + src/qemu/qemu_validate.c | 8 + src/security/security_apparmor.c | 1 + src/security/security_dac.c | 2 + src/security/security_selinux.c | 2 + tests/domaincapsdata/bhyve_basic.x86_64.xml | 1 + tests/domaincapsdata/bhyve_fbuf.x86_64.xml | 1 + tests/domaincapsdata/bhyve_uefi.x86_64.xml | 1 + tests/domaincapsdata/empty.xml | 1 + tests/domaincapsdata/libxl-xenfv.xml | 1 + tests/domaincapsdata/libxl-xenpv.xml | 1 + .../domaincapsdata/qemu_2.11.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.11.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.11.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.11.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.12.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.12.0-tcg.x86_64.xml | 1 + .../qemu_2.12.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.12.0.x86_64.xml | 1 + .../domaincapsdata/qemu_3.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_3.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_3.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_3.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_3.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_3.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_3.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_3.1.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_3.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_4.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.0.0-tcg.x86_64.xml | 1 + .../qemu_4.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_4.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 1 + .../qemu_4.2.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.0.0-tcg.x86_64.xml | 1 + .../qemu_5.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_5.1.0.sparc.xml | 1 + tests/domaincapsdata/qemu_5.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.2.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.2.0-tcg.x86_64.xml | 1 + .../qemu_5.2.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_5.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 1 + .../qemu_6.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_6.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_6.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_6.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_6.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_6.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_6.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_6.2.0-q35.x86_64.xml | 4 + .../domaincapsdata/qemu_6.2.0-tcg.x86_64.xml | 4 + .../qemu_6.2.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_6.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_6.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_6.2.0.x86_64.xml | 4 + .../domaincapsdata/qemu_7.0.0-q35.x86_64.xml | 4 + .../domaincapsdata/qemu_7.0.0-tcg.x86_64.xml | 4 + .../qemu_7.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_7.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_7.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_7.0.0.x86_64.xml | 4 + .../domaincapsdata/qemu_7.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_7.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_7.1.0.x86_64.xml | 1 + .../caps_6.2.0.x86_64.replies | 22 ++- .../caps_6.2.0.x86_64.xml | 5 + .../caps_7.0.0.x86_64.replies | 22 ++- .../caps_7.0.0.x86_64.xml | 5 + .../caps_7.1.0.x86_64.replies | 21 ++- .../sgx-epc.x86_64-6.2.0.args | 37 +++++ tests/qemuxml2argvdata/sgx-epc.xml | 36 +++++ tests/qemuxml2argvtest.c | 2 + .../sgx-epc.x86_64-6.2.0.xml | 52 +++++++ tests/qemuxml2xmltest.c | 2 + 121 files changed, 793 insertions(+), 40 deletions(-) create mode 100644 tests/qemuxml2argvdata/sgx-epc.x86_64-6.2.0.args create mode 100644 tests/qemuxml2argvdata/sgx-epc.xml create mode 100644 tests/qemuxml2xmloutdata/sgx-epc.x86_64-6.2.0.xml -- 2.17.1

4 23

[PULL 00/11] hw/nvme updates
by Klaus Jensen 03 Jun '22

03 Jun '22

From: Klaus Jensen <k.jensen(a)samsung.com> Hi Peter, The following changes since commit 70e975203f366f2f30daaeb714bb852562b7b72f: Merge tag 'pull-request-2022-06-03' of https://gitlab.com/thuth/qemu into staging (2022-06-03 06:43:38 -0700) are available in the Git repository at: git://git.infradead.org/qemu-nvme.git tags/nvme-next-pull-request for you to fetch changes up to d7fe639cabf778903f6cab23ff58c905c71375ec: hw/nvme: add new command abort case (2022-06-03 21:48:24 +0200) ---------------------------------------------------------------- hw/nvme updates ---------------------------------------------------------------- Dmitry Tikhov (4): hw/nvme: fix narrowing conversion hw/nvme: add missing return statement hw/nvme: fix copy cmd for pi enabled namespaces hw/nvme: add new command abort case Klaus Jensen (7): hw/nvme: fix smart aen hw/nvme: enforce common serial per subsystem hw/nvme: do not auto-generate eui64 hw/nvme: do not auto-generate uuid hw/nvme: do not report null uuid hw/nvme: bump firmware revision hw/nvme: deprecate the use-intel-id compatibility parameter docs/about/deprecated.rst | 15 +++++++++++++++ hw/core/machine.c | 1 + hw/nvme/ctrl.c | 26 ++++++++++++++------------ hw/nvme/dif.c | 5 +++++ hw/nvme/ns.c | 9 +++++---- hw/nvme/nvme.h | 1 + hw/nvme/subsys.c | 7 +++++++ 7 files changed, 48 insertions(+), 16 deletions(-) -- 2.36.1

1 11

[PATCH] qemu: fd: Fix monitor usage of qemuFDPassDirectGetPath
by Peter Krempa 03 Jun '22

03 Jun '22

We need to use the 'name' variable and just overwrite it with the FD number when FDs are passed on the monitor. Otherwise we will read NULL path if the FD is accessed before being passed on the monitor. The idea of this helper is to simplify the monitor code so it would be counterproductive to have other behaviour. Fixes the following symptom: $ virsh attach-interface cd network default --model virtio error: Failed to attach interface error: internal error: unable to execute QEMU command 'netdev_add': File descriptor named '(null)' has not been found Fixes: bca9047906fd73fd30f275dd45b64998fbbcf6de Resolves: https://gitlab.com/libvirt/libvirt/-/issues/318 Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2092856 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_fd.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_fd.c b/src/qemu/qemu_fd.c index 6311161657..51a8133fde 100644 --- a/src/qemu/qemu_fd.c +++ b/src/qemu/qemu_fd.c @@ -235,7 +235,6 @@ qemuFDPassGetPath(qemuFDPass *fdpass) struct _qemuFDPassDirect { int fd; - char *path; char *name; bool passed; /* passed to qemu via monitor */ @@ -251,7 +250,6 @@ qemuFDPassDirectFree(qemuFDPassDirect *fdpass) VIR_FORCE_CLOSE(fdpass->fd); g_free(fdpass->name); - g_free(fdpass->path); g_free(fdpass); } @@ -295,7 +293,8 @@ qemuFDPassDirectTransferCommand(qemuFDPassDirect *fdpass, return; virCommandPassFD(cmd, fdpass->fd, VIR_COMMAND_PASS_FD_CLOSE_PARENT); - fdpass->path = g_strdup_printf("%d", fdpass->fd); + g_free(fdpass->name); + fdpass->name = g_strdup_printf("%d", fdpass->fd); fdpass->fd = -1; } @@ -318,7 +317,6 @@ qemuFDPassDirectTransferMonitor(qemuFDPassDirect *fdpass, if (qemuMonitorSendFileHandle(mon, fdpass->name, fdpass->fd) < 0) return -1; - fdpass->path = g_strdup(fdpass->name); VIR_FORCE_CLOSE(fdpass->fd); fdpass->passed = true; @@ -358,5 +356,5 @@ qemuFDPassDirectGetPath(qemuFDPassDirect *fdpass) if (!fdpass) return NULL; - return fdpass->path; + return fdpass->name; } -- 2.35.3

2 1

[libvirt PATCH] ci: gitlab: Expire artifacts after 1 day
by Erik Skultety 02 Jun '22

02 Jun '22

With GitLab cutting down on shared resource usage it's very likely that following our measure to decrease the number of CI minutes we'll also need to decrease our usage of storage. Start by decreasing artifact expiration time to 1 day for jobs that are currently exceeding it (by a lot -> 30 days). At the same time, define expiration on the integration jobs' artifacts where there currently isn't one defined. Although 1 day doesn't seem to be enough of a time period, given the cadency of libvirt pipeline executions it should suffice giving everyone/jobs enough time to download artifacts if needed. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- .gitlab-ci.yml | 4 ++-- ci/integration-template.yml | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 6a8b89729f..1b39047862 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -74,7 +74,7 @@ website: expose_as: 'Website' name: 'website' when: on_success - expire_in: 30 days + expire_in: 1 day paths: - website @@ -115,7 +115,7 @@ potfile: expose_as: 'Potfile' name: 'potfile' when: on_success - expire_in: 30 days + expire_in: 1 day paths: - libvirt.pot diff --git a/ci/integration-template.yml b/ci/integration-template.yml index e2ccebd1f6..bd634a971b 100644 --- a/ci/integration-template.yml +++ b/ci/integration-template.yml @@ -80,6 +80,7 @@ SCRATCH_DIR: "/tmp/scratch" artifacts: name: logs + expire_in: 1 day paths: - logs when: on_failure -- 2.36.1

2 3

[PATCH] qemu: Restore label to temp file in qemuDomainScreenshot()
by Michal Privoznik 02 Jun '22

02 Jun '22

Obtaining a screenshot via virDomainScreenshot() works like this: 1) we create a temp file, label it, then 2) tell QEMU to store the screenshot into it, and 3) finally, open the file for transfer via virStream Since the file is just temporary and even explicitly unlinked at the end, no seclabel restoration is done. This makes perfect sense for security models which attach a label to file itself (DAC, SELinux) because the label is gone with the file. However, for models where a list of files and allowed actions is kept on a side (AppArmor) this approach means we just append files into the profile and never remove them. In turn, the file grows and policy update takes longer with each entry. Restore the seclabel for AppArmor's sake. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_driver.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index fb63e6550f..0c6645ed89 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3423,8 +3423,13 @@ qemuDomainScreenshot(virDomainPtr dom, endjob: VIR_FORCE_CLOSE(tmp_fd); - if (unlink_tmp) + if (unlink_tmp) { + /* This may look pointless, since we're removing the file anyways, but + * it's crucial for AppArmor. Otherwise these temp files would + * accumulate in the domain's profile. */ + qemuSecurityDomainRestorePathLabel(driver, vm, tmp); unlink(tmp); + } qemuDomainObjEndJob(vm); -- 2.35.1

2 1

[PATCH REBASE 00/17] Use virXMLPropEnum() more (part I)
by Michal Privoznik 01 Jun '22

01 Jun '22

This is rebased version of: https://listman.redhat.com/archives/libvir-list/2022-April/229941.html Michal Prívozník (17): Drop needless typecast to virStorageType enum virStorageSourceGetActualType: Change type of retval virDomainBackupDefParse: Switch to virXMLPropEnumDefault() virDomainDeviceAddressParseXML: Switch to virXMLPropEnumDefault() virDomainStorageNetworkParseHost: Switch to virXMLPropEnumDefault() virDomainHostdevSubsysSCSIDefParseXML: Switch to virXMLPropEnumDefault() virDomainHostdevSubsysSCSIVHostDefParseXML: Switch to virXMLPropEnumDefault() virDomainDiskSourceNVMeParse: Switch to virXMLPropEnumDefault() virDomainDiskDefMirrorParse: Switch to virXMLPropEnumDefault() virDomainDiskSourcePoolDefParse: Switch to virXMLPropEnumDefault() virDomainDiskDefParseSourceXML: Switch to virXMLPropEnumDefault() virDomainChrDefParseXML: Switch to virXMLPropEnumDefault() virDomainTPMDefParseXML: Switch to virXMLPropEnumDefault() virDomainPanicDefParseXML: Switch to virXMLPropEnumDefault() virDomainInputDefParseXML: Switch to virXMLPropEnumDefault() virDomainHubDefParseXML: Switch to virXMLPropEnumDefault() virDomainTimerDefParseXML: Switch to virXMLPropEnumDefault() src/ch/ch_monitor.c | 2 +- src/conf/backup_conf.c | 16 +- src/conf/backup_conf.h | 2 +- src/conf/device_conf.c | 12 +- src/conf/device_conf.h | 4 +- src/conf/domain_audit.c | 2 +- src/conf/domain_conf.c | 494 ++++++------------ src/conf/domain_conf.h | 54 +- src/conf/domain_validate.c | 6 +- src/conf/storage_source_conf.c | 2 +- src/conf/storage_source_conf.h | 8 +- src/conf/virchrdev.c | 29 + src/libxl/libxl_conf.c | 32 +- src/libxl/libxl_domain.c | 2 +- src/libxl/xen_common.c | 29 +- src/libxl/xen_xl.c | 7 +- src/libxl/xen_xm.c | 3 + src/locking/domain_lock.c | 2 +- src/lxc/lxc_cgroup.c | 2 +- src/lxc/lxc_controller.c | 2 +- src/qemu/qemu_backup.c | 2 +- src/qemu/qemu_block.c | 14 +- src/qemu/qemu_cgroup.c | 12 + src/qemu/qemu_command.c | 49 +- src/qemu/qemu_domain.c | 44 +- src/qemu/qemu_domain_address.c | 4 +- src/qemu/qemu_driver.c | 4 +- src/qemu/qemu_hotplug.c | 4 +- src/qemu/qemu_migration.c | 6 +- src/qemu/qemu_monitor.c | 54 +- src/qemu/qemu_monitor_json.c | 4 +- src/qemu/qemu_process.c | 10 +- src/qemu/qemu_snapshot.c | 16 +- src/qemu/qemu_validate.c | 19 +- src/security/security_apparmor.c | 6 +- src/security/security_dac.c | 8 +- src/security/security_selinux.c | 28 +- .../storage_file_backend_gluster.c | 2 +- src/storage_file/storage_source.c | 4 +- .../storage_source_backingstore.c | 16 +- src/vmx/vmx.c | 26 + tests/qemuxml2argvtest.c | 2 +- tests/testutilsqemu.c | 2 +- 43 files changed, 557 insertions(+), 489 deletions(-) -- 2.35.1

3 39

[libvirt PATCH] docs: contact: recommend the TLS port for IRC
by Ján Tomko 01 Jun '22

01 Jun '22

Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- docs/contact.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/contact.rst b/docs/contact.rst index 19e1b66a52..f8f7e806b3 100644 --- a/docs/contact.rst +++ b/docs/contact.rst @@ -80,7 +80,7 @@ Some of the libvirt developers may be found on IRC on the `OFTC IRC <https://oftc.net>`__ network. Use the settings: - server: irc.oftc.net -- port: 6667 (the usual IRC port) +- port: 6697 (the usual IRC TLS port) - channel: #virt NB There is no guarantee that someone will be watching or able to reply -- 2.35.1

2 1

[libvirt PATCH] Fix typos
by Tim Wiederhake 01 Jun '22

01 Jun '22

Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com> --- src/qemu/qemu_fd.c | 2 +- src/util/virfile.c | 2 +- tests/meson.build | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_fd.c b/src/qemu/qemu_fd.c index bc6a37663c..6311161657 100644 --- a/src/qemu/qemu_fd.c +++ b/src/qemu/qemu_fd.c @@ -262,7 +262,7 @@ qemuFDPassDirectFree(qemuFDPassDirect *fdpass) * @fd: The FD, cleared when passed. * * The qemuFDPassDirect helper returned by this helper is used to hold a FD - * passed to qemu either direcly via FD number when used on commandline or the + * passed to qemu either directly via FD number when used on commandline or the * 'getfd' QMP command. */ qemuFDPassDirect * diff --git a/src/util/virfile.c b/src/util/virfile.c index e4522b5f67..99da058db3 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -4595,7 +4595,7 @@ struct runIOParams { * * Execute the copy based on the passed parameters. * - * Returns: size transfered, or < 0 on error. + * Returns: size transferred, or < 0 on error. */ static off_t diff --git a/tests/meson.build b/tests/meson.build index 1871f5e611..bc9d8ccc4c 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -47,7 +47,7 @@ tests_env = [ # # (process:50880): GLib-WARNING **: 02:54:15.272: poll(2) failed due to: Bad file descriptor. # -# Our code is inherantly racy, calling g_source_destroy which +# Our code is inherently racy, calling g_source_destroy which # removes the FD from the event thread poll asynchronously # but we close the FD immediately after g_source_destroy returns. # -- 2.31.1

2 1

[PATCH 00/15] docs: Convert some pages to rST and clean up (part 6)
by Peter Krempa 01 Jun '22

01 Jun '22

After this series only 2 non-generated HTML files remain: - index.html.in - 404.html.in It is possible to convert these but the utility of doing so may not be great for now. Additionally this series cleans up some long-broken links and removes unneeded raw HTML passthrough to declare anchors. Pavel Hrdina (2): docs: storage: rename headers to remove duplicate names docs: Convert 'storage' page to rst Peter Krempa (13): docs: formatsecret: Correct link to storage volume XML definition Correct links to TLS certificate setup page docs: Convert 'remote' page to rst docs: remote: Remove 'Limitations' paragraph docs: Convert 'uri' page to rst docs: uri: Remove old 'NULL URI' section docs: uri: Consolidate paragraphs on Xen URIs docs: uri: Move the 'test' hypervisor under a 'local hypervisors heading docs: uri: Rewrite section about transport protocols and extra parameters docs: governance: Remove unused HTML anchors docs: contact: Remove HTML anchors and adjust documents using them docs: bugs: Remove raw HTML anchor 'quality' docs: formatdomain: Remove old unreferenced HTML anchors .gitlab/issue_templates/bug.md | 2 +- docs/bugs.rst | 5 - docs/contact.rst | 11 +- docs/contribute.rst | 10 +- docs/drvesx.rst | 5 +- docs/formatdomain.rst | 112 ----- docs/formatsecret.rst | 8 +- docs/governance.rst | 5 - docs/kbase/tlscerts.rst | 4 +- docs/meson.build | 6 +- docs/page.xsl | 2 +- docs/remote.html.in | 297 ------------ docs/remote.rst | 209 +++++++++ docs/securityprocess.rst | 4 +- docs/storage.html.in | 833 --------------------------------- docs/storage.rst | 790 +++++++++++++++++++++++++++++++ docs/uri.html.in | 507 -------------------- docs/uri.rst | 405 ++++++++++++++++ tools/virt-pki-validate.in | 10 +- 19 files changed, 1431 insertions(+), 1794 deletions(-) delete mode 100644 docs/remote.html.in create mode 100644 docs/remote.rst delete mode 100644 docs/storage.html.in create mode 100644 docs/storage.rst delete mode 100644 docs/uri.html.in create mode 100644 docs/uri.rst -- 2.35.1

3 20

Release of libvirt-8.4.0
by Jiri Denemark 01 Jun '22

01 Jun '22

The 8.4.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://libvirt.org/sources/ https://libvirt.org/sources/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is greatly appreciated. * New features * qemu: D-Bus display Libvirt is now able to setup a D-Bus display export, either with a private bus or in p2p mode. This display is available in QEMU 7.0.0. * qemu: ppc64 Power10 processor support Support for the recently released IBM Power10 processor was added. * qemu: Introduce ``absolute`` clock offset The ``absolute`` clock offset type allows to set the guest clock to an arbitrary epoch timestamp at each start. This is useful if some VM needs to be kept set to an arbitrary time for e.g. testing or working around broken software. * qemu: add qemu-vdagent channel This paravirtualized qemu vdagent channel can enable copy and paste between a guest and a VNC client. It is available in QEMU 6.1.0. * api: Add new APIs ``virDomainSaveParams`` and ``virDomainRestoreParams`` * ``virDomainSaveParams``: An alternative domain saving API, extends ``virDomainSaveFlags`` by adding parameters. * ``virDomainRestoreParams``: An alternative domain restoring API, extends ``virDomainRestoreFlags`` by adding parameters. * Bug fixes * Improve heuristics for computing baseline CPU models Both ``virConnectBaselineHypervisorCPU`` and ``virConnectBaselineCPU`` were in some cases computing the result using a CPU model which was newer than some of the input models. For example, ``Cascadelake-Server`` was used as a baseline for ``Skylake-Server-IBRS`` and ``Cascadelake-Server``. The CPU model selection heuristics was improved to choose a more appropriate model. Enjoy. Jirka

1 0

[PATCH RESEND 0/3] network: Generate TFTP config regardless of DHCP
by Michal Privoznik 01 Jun '22

01 Jun '22

This is rebased version of: https://listman.redhat.com/archives/libvir-list/2021-December/226045.html Michal Prívozník (3): network: Initialize variables in networkDnsmasqConfContents() network: Separate DHCP config generator into a function network: Generate TFTP config regardless of DHCP src/network/bridge_driver.c | 259 ++++++++++-------- .../networkxml2confdata/netboot-network.conf | 4 +- tests/networkxml2confdata/netboot-tftp.conf | 13 + tests/networkxml2confdata/netboot-tftp.xml | 9 + tests/networkxml2conftest.c | 1 + tests/networkxml2xmlin/netboot-tftp.xml | 1 + tests/networkxml2xmlout/netboot-tftp.xml | 1 + tests/networkxml2xmltest.c | 1 + 8 files changed, 170 insertions(+), 119 deletions(-) create mode 100644 tests/networkxml2confdata/netboot-tftp.conf create mode 100644 tests/networkxml2confdata/netboot-tftp.xml create mode 120000 tests/networkxml2xmlin/netboot-tftp.xml create mode 120000 tests/networkxml2xmlout/netboot-tftp.xml -- 2.35.1

2 4

[PATCH 00/67] docs: Fix and clean up anchor links
by Peter Krempa 01 Jun '22

01 Jun '22

First 50 patches remove the use of raw HTML passthrough in formatdomain.rst, which is the only outstanding place which still does. Most of the work was done by a ad-hoc bash script, but manual tweaks were needed. Since this series also contains a test script which validates linking I'm not going to publish the conversion script. The rest of the series then cleans up pre-existing broken links and adds the aforementioned checker script. One more change is to prevent the use of external references in RST to refer to the same file. All usage was converted to local references and a syntax check was added. One slight drawback of the checker script is that it works on generated HTML files and thus the error message contains the output file name and not the source RST document. Output after the fixes can be browsed at: https://gitlab.com/pipo.sk/libvirt/-/jobs/2528184702/artifacts/browse/websi… Peter Krempa (67): docs: formatdomain: Remove 'elements' anchor docs: formatdomain: Remove 'elementsMetadata' anchor docs: formatdomain: Remove 'elementsOS' anchor docs: formatdomain: Remove 'elementsOSBIOS' anchor docs: formatdomain: Remove 'elementsOSContainer' anchor docs: formatdomain: Remove 'elementsSysinfo' anchor docs: formatdomain: Remove 'elementsCPUAllocation' anchor docs: formatdomain: Remove 'elementsIOThreadsAllocation' anchor docs: formatdomain: Remove 'elementsCPUTuning' anchor docs: formatdomain: Remove 'elementsMemoryAllocation' anchor docs: formatdomain: Remove 'elementsMemoryBacking' anchor docs: formatdomain: Remove 'elementsMemoryTuning' anchor docs: formatdomain: Remove 'elementsNUMATuning' anchor docs: formatdomain: Remove 'elementsBlockTuning' anchor docs: formatdomain: Remove 'elementsCPU' anchor docs: formatdomain: Remove 'hmat' anchor docs: formatdomain: Remove 'elementsEvents' anchor docs: formatdomain: Remove 'elementsFeatures' anchor docs: formatdomain: Remove 'elementsDevices' anchor docs: formatdomain: Remove 'elementsDisks' anchor docs: formatdomain: Remove 'elementsAddress' anchor docs: formatdomain: Remove 'elementsVirtio' anchor docs: formatdomain: Remove 'elementsVirtioTransitional' anchor docs: formatdomain: Remove 'elementsControllers' anchor docs: formatdomain: Remove 'elementsHostDev' anchor docs: formatdomain: Remove 'elementsNICS' anchor docs: formatdomain: Remove 'elementsNICSDirect' anchor docs: formatdomain: Remove 'elementsNICSTargetOverride' anchor docs: formatdomain: Remove 'elementQoS' anchor docs: formatdomain: Remove 'elementVlanTag' anchor docs: formatdomain: Remove 'elementPort' anchor docs: formatdomain: Remove 'mtu' anchor docs: formatdomain: Remove 'coalesce' anchor docs: formatdomain: Remove 'elementVhostuser' anchor docs: formatdomain: Remove 'elementsGraphics' anchor docs: formatdomain: Remove 'elementsVideo' anchor docs: formatdomain: Remove 'elementsConsole' anchor docs: formatdomain: Remove 'elementCharSerial' anchor docs: formatdomain: Remove 'elementCharSerialAndConsole' anchor docs: formatdomain: Remove 'elementsCharHostInterface' anchor docs: formatdomain: Remove 'elementsCharHost' anchor docs: formatdomain: Remove 'elementsAudio' anchor docs: formatdomain: Remove 'elementsTpm' anchor docs: formatdomain: Remove 'elementsMemory' anchor docs: formatdomain: Remove 'elementsIommu' anchor docs: formatdomain: Remove 'vsock' anchor docs: formatdomain: Remove 'seclabel' anchor docs: formatdomain: Remove 'keywrap' anchor docs: formatdomain: Remove 'launchSecurity' anchor docs: formatdomain: Remove the 'anchor' role docs: formatdomain: Use local reference directly docs: uri: Fix link to libvirtd configuration section syntax-check: Add check prohibiting remote reference to local file docs: page.xsl: Fix link to 'mailing-lists' section docs: domainstatecapture: Fix broken links docs: rpc: Fix broken headings docs: formatcaps: Fix anchors of links into formatdomain.rst scripts: hvsupport: Remove link into the 'html' directory docs: Fix link to 'tlscerts' article docs: Remove extra leading slash in 'api' and 'formatdomaincaps' pages docs: Fix links in kbase/internals docs: kbase/kvm-realtime: Fix few links docs: kbase/tlscerts: Fix links docs: remote: Fix anchor names in links to uri.html uri: Fix link to qemu KVM example config docs: formatstorageencryption: Use correct anchor into formatsecret page docs: Add HTML reference checker build-aux/syntax-check.mk | 7 + docs/api.rst | 2 +- docs/docs.rst | 2 +- docs/drvlxc.rst | 2 +- docs/formatbackup.rst | 6 +- docs/formatcaps.rst | 10 +- docs/formatcheckpoint.rst | 2 +- docs/formatdomain.rst | 360 ++++++++++++----------------- docs/formatdomaincaps.rst | 20 +- docs/formatnetwork.rst | 8 +- docs/formatnetworkport.rst | 4 +- docs/formatnode.rst | 2 +- docs/formatsecret.rst | 12 +- docs/formatsnapshot.rst | 8 +- docs/formatstorageencryption.rst | 2 +- docs/kbase/domainstatecapture.rst | 12 +- docs/kbase/internals/eventloop.rst | 2 +- docs/kbase/internals/migration.rst | 2 +- docs/kbase/internals/rpc.rst | 16 +- docs/kbase/kvm-realtime.rst | 10 +- docs/kbase/launch_security_sev.rst | 2 +- docs/kbase/locking-sanlock.rst | 2 +- docs/kbase/memorydevices.rst | 2 +- docs/kbase/s390_protected_virt.rst | 2 +- docs/kbase/tlscerts.rst | 8 +- docs/manpages/virsh.rst | 8 +- docs/meson.build | 11 + docs/page.xsl | 2 +- docs/remote.rst | 4 +- docs/storage.rst | 6 +- docs/uri.rst | 4 +- scripts/check-html-references.py | 153 ++++++++++++ scripts/hvsupport.py | 2 +- scripts/meson.build | 1 + 34 files changed, 402 insertions(+), 294 deletions(-) create mode 100755 scripts/check-html-references.py -- 2.35.3

2 81

[PATCH] gitlab: issue_template: Remove labelling commands
by Peter Krempa 01 Jun '22

01 Jun '22

The commands only work for users who are members of the project and thus can set flags themselves. For non-members they are ignored, so there's isn't much value in having it here. Additionally in my recent upstream issue triage I've changed some of the labels so they were not accurate anyways. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- .gitlab/issue_templates/bug.md | 5 ----- .gitlab/issue_templates/feature.md | 5 ----- 2 files changed, 10 deletions(-) diff --git a/.gitlab/issue_templates/bug.md b/.gitlab/issue_templates/bug.md index 8a54cc2da4..f220671a06 100644 --- a/.gitlab/issue_templates/bug.md +++ b/.gitlab/issue_templates/bug.md @@ -17,8 +17,3 @@ ## Additional information   - - - -<!-- The line below ensures that proper tags are added to the issue. -- > -/label ~bug diff --git a/.gitlab/issue_templates/feature.md b/.gitlab/issue_templates/feature.md index 50f5486701..a143aa7f45 100644 --- a/.gitlab/issue_templates/feature.md +++ b/.gitlab/issue_templates/feature.md @@ -23,8 +23,3 @@ Thank you for your interest in helping us to make libvirt better! ## Additional information - - - -<!-- The line below ensures that proper tags are added to the issue. -- > -/label ~enhancement -- 2.35.3

2 1

[PATCH] lib: Be consistent about vm->pid
by Michal Privoznik 31 May '22

31 May '22

The virDomainObj struct has @pid member where the domain's hypervisor PID is stored (e.g. QEMU/bhyve/libvirt_lxc/... PID). However, we are not consistent when it comes to shutoff state. Initially, because virDomainObjNew() uses g_new0() the @pid is initialized to 0. But when domain is shut off, some functions set it to -1 (virBhyveProcessStop, virCHProcessStop, qemuProcessStop, ..). In other places, the @pid is tested to be 0, on some other places it's tested for being negative and in the rest for being positive. To solve this inconsistency we can stick with either value, -1 or 0. I've chosen the latter as it's safer IMO. For instance if by mistake we'd kill(vm->pid, SIGTERM) we would kill ourselves instead of init's process group. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/bhyve/bhyve_process.c | 8 ++++---- src/ch/ch_domain.c | 2 +- src/ch/ch_process.c | 2 +- src/conf/domain_conf.h | 2 +- src/hypervisor/domain_cgroup.c | 2 +- src/lxc/lxc_process.c | 6 +++--- src/openvz/openvz_conf.c | 2 +- src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_process.c | 4 ++-- tests/qemusecuritytest.c | 1 - 10 files changed, 15 insertions(+), 16 deletions(-) diff --git a/src/bhyve/bhyve_process.c b/src/bhyve/bhyve_process.c index 18002b559b..d46786d393 100644 --- a/src/bhyve/bhyve_process.c +++ b/src/bhyve/bhyve_process.c @@ -293,7 +293,7 @@ virBhyveProcessStop(struct _bhyveConn *driver, return 0; } - if (vm->pid <= 0) { + if (vm->pid == 0) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Invalid PID %d for VM"), (int)vm->pid); @@ -329,7 +329,7 @@ virBhyveProcessStop(struct _bhyveConn *driver, bhyveProcessAutoDestroy); virDomainObjSetState(vm, VIR_DOMAIN_SHUTOFF, reason); - vm->pid = -1; + vm->pid = 0; vm->def->id = -1; bhyveProcessStopHook(vm, VIR_HOOK_BHYVE_OP_RELEASE); @@ -344,7 +344,7 @@ virBhyveProcessStop(struct _bhyveConn *driver, int virBhyveProcessShutdown(virDomainObj *vm) { - if (vm->pid <= 0) { + if (vm->pid == 0) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Invalid PID %d for VM"), (int)vm->pid); @@ -433,7 +433,7 @@ virBhyveProcessReconnect(virDomainObj *vm, if (!virDomainObjIsActive(vm)) return 0; - if (!vm->pid) + if (vm->pid == 0) return 0; virObjectLock(vm); diff --git a/src/ch/ch_domain.c b/src/ch/ch_domain.c index bb489a74e3..5ab526ba1b 100644 --- a/src/ch/ch_domain.c +++ b/src/ch/ch_domain.c @@ -405,7 +405,7 @@ virCHDomainGetMachineName(virDomainObj *vm) virCHDriver *driver = priv->driver; char *ret = NULL; - if (vm->pid > 0) { + if (vm->pid != 0) { ret = virSystemdGetMachineNameByPID(vm->pid); if (!ret) virResetLastError(); diff --git a/src/ch/ch_process.c b/src/ch/ch_process.c index 977082d585..4247902bcf 100644 --- a/src/ch/ch_process.c +++ b/src/ch/ch_process.c @@ -574,7 +574,7 @@ virCHProcessStop(virCHDriver *driver G_GNUC_UNUSED, vm->def->name); } - vm->pid = -1; + vm->pid = 0; vm->def->id = -1; g_clear_pointer(&priv->machineName, g_free); diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 6906db4af5..e7e0f24443 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -3059,7 +3059,7 @@ struct _virDomainObj { virObjectLockable parent; virCond cond; - pid_t pid; + pid_t pid; /* 0 for no PID, avoid negative values like -1 */ virDomainStateReason state; unsigned int autostart : 1; diff --git a/src/hypervisor/domain_cgroup.c b/src/hypervisor/domain_cgroup.c index 8072465615..7265325406 100644 --- a/src/hypervisor/domain_cgroup.c +++ b/src/hypervisor/domain_cgroup.c @@ -517,7 +517,7 @@ virDomainCgroupSetupCgroup(const char *prefix, bool privileged, char *machineName) { - if (!vm->pid) { + if (vm->pid == 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Cannot setup cgroups until process is started")); return -1; diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c index 9722d8e1de..d162812a74 100644 --- a/src/lxc/lxc_process.c +++ b/src/lxc/lxc_process.c @@ -217,7 +217,7 @@ static void virLXCProcessCleanup(virLXCDriver *driver, lxcProcessRemoveDomainStatus(cfg, vm); virDomainObjSetState(vm, VIR_DOMAIN_SHUTOFF, reason); - vm->pid = -1; + vm->pid = 0; vm->def->id = -1; if (!!g_atomic_int_dec_and_test(&driver->nactive) && driver->inhibitCallback) @@ -892,7 +892,7 @@ int virLXCProcessStop(virLXCDriver *driver, _("Some processes refused to die")); return -1; } - } else if (vm->pid > 0) { + } else if (vm->pid != 0) { /* If cgroup doesn't exist, just try cleaning up the * libvirt_lxc process */ if (virProcessKillPainfully(vm->pid, true) < 0) { @@ -1033,7 +1033,7 @@ virLXCProcessReadLogOutputData(virDomainObj *vm, bool isdead = false; char *eol; - if (vm->pid <= 0 || + if (vm->pid == 0 || (kill(vm->pid, 0) == -1 && errno == ESRCH)) isdead = true; diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index 191c79e1e2..79ab786355 100644 --- a/src/openvz/openvz_conf.c +++ b/src/openvz/openvz_conf.c @@ -528,7 +528,7 @@ int openvzLoadDomains(struct openvz_driver *driver) if (STREQ(status, "stopped")) { virDomainObjSetState(dom, VIR_DOMAIN_SHUTOFF, VIR_DOMAIN_SHUTOFF_UNKNOWN); - dom->pid = -1; + dom->pid = 0; } else { virDomainObjSetState(dom, VIR_DOMAIN_RUNNING, VIR_DOMAIN_RUNNING_UNKNOWN); diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 31e60c7359..8ebf152d95 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -10741,7 +10741,7 @@ qemuDomainGetMachineName(virDomainObj *vm) virQEMUDriver *driver = priv->driver; char *ret = NULL; - if (vm->pid > 0) { + if (vm->pid != 0) { ret = virSystemdGetMachineNameByPID(vm->pid); if (!ret) virResetLastError(); diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 07acb1c427..cbcc480089 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -8239,7 +8239,7 @@ void qemuProcessStop(virQEMUDriver *driver, g_clear_pointer(&vm->deprecations, g_free); vm->ndeprecations = 0; vm->taint = 0; - vm->pid = -1; + vm->pid = 0; virDomainObjSetState(vm, VIR_DOMAIN_SHUTOFF, reason); for (i = 0; i < vm->def->niothreadids; i++) vm->def->iothreadids[i]->thread_id = 0; @@ -8969,7 +8969,7 @@ qemuProcessReconnectHelper(virDomainObj *obj, g_autofree char *name = NULL; /* If the VM was inactive, we don't need to reconnect */ - if (!obj->pid) + if (obj->pid == 0) return 0; data = g_new0(struct qemuProcessReconnectData, 1); diff --git a/tests/qemusecuritytest.c b/tests/qemusecuritytest.c index 924c625a4c..4e2343b7d7 100644 --- a/tests/qemusecuritytest.c +++ b/tests/qemusecuritytest.c @@ -54,7 +54,6 @@ prepareObjects(virQEMUDriver *driver, if (!(vm = virDomainObjNew(driver->xmlopt))) return -1; - vm->pid = -1; priv = vm->privateData; priv->chardevStdioLogd = false; priv->rememberOwner = true; -- 2.35.1

2 1

[PATCH v2 0/5] network: firewalld: fix routed network
by Eric Garver 31 May '22

31 May '22

This series fixes routed networks when a newer firewalld (>= 1.0.0) is present [1]. Firewalld 1.0.0 included a change that disallows implicit forwarding between zones [2]. libvirt was relying on this behavior to allow routed networks to function. Firewalld policies are added. Policies have been supported since firewalld 0.9.0. If the running firewall does not support policies, then it will fallback to the current zone only behavior. v2: - keep existing libvirt zone as is - remove "<forward />" in libvirt-routed zone because this feature requires firewalld >= 0.9.0. Has no impact since the added policies allow forwarding libvirt-routed <--> ANY zone (including itself). - add probe for policies: virFirewallDGetPolicies(), virFirewallDPolicyExists() [1]: https://bugzilla.redhat.com/show_bug.cgi?id=2055706 [2]: https://github.com/firewalld/firewalld/issues/177 Eric Garver (5): util: add virFirewallDGetPolicies() util: add virFirewallDPolicyExists() network: firewalld: add zone for routed networks network: firewalld: add policies for routed networks network: firewalld: add support for routed networks src/libvirt_private.syms | 2 + src/network/bridge_driver_linux.c | 11 +++- src/network/libvirt-routed-in.policy | 11 ++++ src/network/libvirt-routed-out.policy | 12 +++++ src/network/libvirt-routed.zone | 10 ++++ src/network/libvirt-to-host.policy | 20 ++++++++ src/network/meson.build | 20 ++++++++ src/util/virfirewalld.c | 72 +++++++++++++++++++++++++++ src/util/virfirewalld.h | 2 + 9 files changed, 159 insertions(+), 1 deletion(-) create mode 100644 src/network/libvirt-routed-in.policy create mode 100644 src/network/libvirt-routed-out.policy create mode 100644 src/network/libvirt-routed.zone create mode 100644 src/network/libvirt-to-host.policy -- 2.35.3

1 5

[libvirt PATCH 0/4] ci: reduce number of jobs in the pipeline
by Daniel P. Berrangé 31 May '22

31 May '22

Come June 1st (aka very very soon) GitLab will reduce the CI minutes quota available from 2000 to 400 for public projects. The wallclock minutes for CI are the quota divided by a cost factor currently 0.008. IOW, after June 1st our allowance reduces from 250,000 wallclock minutes to 50,000. While I had intended that we join the OSS program, I'm unhappy with the financial liability the T&Cs require us to agree to for tha Usage stats show we're currently consuming 70-80,000 minutes a month, so we need to cut our usage by at least 30%. The main libvirt project is responsible for the vast majority of usage, so is the biggest quick win, but we need to economise across all our repos. With this series, we increase the number of jobs in the pipeline from 82 to 100, but we mark a great many of them as manual jobs, so they never run unless a user explicitly triggers them. So we have only 54 jobs executing instead of the original 82. The remaining 46 jobs are optional. This is a decent win in usage, but we probably need to cut a little more later to give us breathing space Daniel P. Berrangé (4): ci: refresh with lcitool manifest ci: disable native builds on certain distros ci: move Ubuntu GCC santizers build to 20.04 ci: eliminate many cross arch CI builds ci/gitlab/build-templates.yml | 17 ++- ci/gitlab/builds.yml | 246 ++++++++++++++++++++++++++++-- ci/gitlab/container-templates.yml | 3 + ci/gitlab/containers.yml | 50 +++--- ci/manifest.yml | 59 ++++--- 5 files changed, 329 insertions(+), 46 deletions(-) -- 2.36.1

2 6

[PATCH v2 0/2] 2 release notes for v8.4.0
by Han Han 31 May '22

31 May '22

v1: https://listman.redhat.com/archives/libvir-list/2022-May/231901.html diff from v1: rebase to latest and resolve conflicts Han Han (2): news: Add qemu-vdagent news: Add APIs virDomainSaveParams virDomainRestoreParams NEWS.rst | 12 ++++++++++++ 1 file changed, 12 insertions(+) -- 2.36.1

2 3

[PATCH RFC 00/10] qemu: Enable SCHED_CORE for domains and helper processes
by Michal Privoznik 31 May '22

31 May '22

The Linux kernel offers a way to mitigate side channel attacks on Hyper Threads (e.g. MDS and L1TF). Long story short, userspace can define groups of processes (aka trusted groups) and only processes within one group can run on sibling Hyper Threads. The group membership is automatically preserved on fork() and exec(). Now, there is one scenario which I don't cover in my series and I'd like to hear proposal: if there are two guests with odd number of vCPUs they can no longer run on sibling Hyper Threads because my patches create separate group for each QEMU. This is a performance penalty. Ideally, we would have a knob inside domain XML that would place two or more domains into the same trusted group. But since there's pre-existing example (of sharing a piece of information between two domains) I've failed to come up with something usable. Also, it's worth noting, that on kernel level, group membership is expressed by so called 'cookie' which is effectively an unique UL number, but there's no API that would "set this number on given process", so we may have to go with some abstraction layer. Michal Prívozník (10): qemu_tpm: Make APIs work over a single virDomainTPMDef qemu_dbus: Separate PID read code into qemuDBusGetPID qemu_vhost_user_gpu: Export qemuVhostUserGPUGetPid() qemu_tpm: Expose qemuTPMEmulatorGetPid() qemu_virtiofs: Separate PID read code into qemuVirtioFSGetPid virprocess: Core Scheduling support virCommand: Introduce APIs for core scheduling qemu_conf: Introduce a knob to turn off SCHED_CORE qemu: Enable SCHED_CORE for domains and helper processes qemu: Place helper processes into the same trusted group src/libvirt_private.syms | 6 + src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf.in | 5 + src/qemu/qemu_conf.c | 24 ++++ src/qemu/qemu_conf.h | 2 + src/qemu/qemu_dbus.c | 42 ++++--- src/qemu/qemu_dbus.h | 4 + src/qemu/qemu_extdevice.c | 171 ++++++++++++++++++++++++++--- src/qemu/qemu_extdevice.h | 3 + src/qemu/qemu_process.c | 9 ++ src/qemu/qemu_security.c | 4 + src/qemu/qemu_tpm.c | 91 +++++---------- src/qemu/qemu_tpm.h | 18 ++- src/qemu/qemu_vhost_user_gpu.c | 2 +- src/qemu/qemu_vhost_user_gpu.h | 8 ++ src/qemu/qemu_virtiofs.c | 41 ++++--- src/qemu/qemu_virtiofs.h | 5 + src/qemu/test_libvirtd_qemu.aug.in | 1 + src/util/vircommand.c | 74 +++++++++++++ src/util/vircommand.h | 5 + src/util/virprocess.c | 124 +++++++++++++++++++++ src/util/virprocess.h | 8 ++ 22 files changed, 538 insertions(+), 110 deletions(-) -- 2.35.1

4 32

[PATCH] qemu_capspriv: Drop needless declarations
by Michal Privoznik 31 May '22

31 May '22

There are two functions declared in qemu_capspriv.h: 1) virQEMUCapsInitHostCPUModel() which is not used anywhere but qemu_capabilities.c, 2) virQEMUCapsSetSEVCapabilities() which is my personal favorite but despite that it's never implemented nor called. Drop them. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_capspriv.h | 9 --------- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index ce3e7d275a..d0c8217825 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -3725,7 +3725,7 @@ virQEMUCapsNewHostCPUModel(void) } -void +static void virQEMUCapsInitHostCPUModel(virQEMUCaps *qemuCaps, virArch hostArch, virDomainVirtType type) diff --git a/src/qemu/qemu_capspriv.h b/src/qemu/qemu_capspriv.h index 26bf2d3571..fe24d01342 100644 --- a/src/qemu/qemu_capspriv.h +++ b/src/qemu/qemu_capspriv.h @@ -56,11 +56,6 @@ void virQEMUCapsSetArch(virQEMUCaps *qemuCaps, virArch arch); -void -virQEMUCapsInitHostCPUModel(virQEMUCaps *qemuCaps, - virArch hostArch, - virDomainVirtType type); - void virQEMUCapsUpdateHostCPUModel(virQEMUCaps *qemuCaps, virArch hostArch, @@ -97,10 +92,6 @@ virQEMUCapsSetGICCapabilities(virQEMUCaps *qemuCaps, virGICCapability *capabilities, size_t ncapabilities); -void -virQEMUCapsSetSEVCapabilities(virQEMUCaps *qemuCaps, - virSEVCapability *capabilities); - int virQEMUCapsProbeCPUDefinitionsTest(virQEMUCaps *qemuCaps, qemuMonitor *mon); -- 2.35.1

2 1

[PATCH] hw/nvme: deprecate the use-intel-id compatibility parameter
by Klaus Jensen 30 May '22

30 May '22

From: Klaus Jensen <k.jensen(a)samsung.com> Since version 5.2 commit 6eb7a071292a ("hw/block/nvme: change controller pci id"), the emulated NVMe controller has defaulted to a non-Intel PCI identifier. Deprecate the compatibility parameter so we can get rid of it once and for all. Signed-off-by: Klaus Jensen <k.jensen(a)samsung.com> --- docs/about/deprecated.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 896e5a97abbd..450f945ac25f 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -356,6 +356,14 @@ contains native support for this feature and thus use of the option ROM approach is obsolete. The native SeaBIOS support can be activated by using ``-machine graphics=off``. +``-device nvme,use-intel-id=on|off`` (since 7.1) +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ + +The ``nvme`` device originally used a PCI Vendor/Device Identifier combination +from Intel that was not properly allocated. Since version 5.2, the controller +has used a properly allocated identifier. Deprecate the ``use-intel-id`` +machine compatibility parameter. + Block device options '''''''''''''''''''' -- 2.35.1

2 2

[PATCH 0/2] virDomainInputDefValidate: Validate model
by Michal Privoznik 30 May '22

30 May '22

*** BLURB HERE *** Michal Prívozník (2): virDomainInputDefValidate: Reformat virDomainInputDefValidate: Validate model src/conf/domain_validate.c | 84 +++++++++++++++++++++++--------------- 1 file changed, 50 insertions(+), 34 deletions(-) -- 2.35.1

2 3

[PATCH] glibcompat: Provide proper override for 'g_hash_table_steal_extended'
by Peter Krempa 30 May '22

30 May '22

We've emulated the function in virHashSteal, with a note pointing to use the proper version. Move the code to glibcomapt.c and make it such that builds using newer glib already use the new function. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/util/glibcompat.c | 20 ++++++++++++++++++++ src/util/glibcompat.h | 8 ++++++++ src/util/virhash.c | 11 +++-------- 3 files changed, 31 insertions(+), 8 deletions(-) diff --git a/src/util/glibcompat.c b/src/util/glibcompat.c index eb6dcc0111..fdc32af5e2 100644 --- a/src/util/glibcompat.c +++ b/src/util/glibcompat.c @@ -64,6 +64,7 @@ #pragma GCC diagnostic ignored "-Wdeprecated-declarations" #undef g_canonicalize_filename +#undef g_hash_table_steal_extended #undef g_fsync #undef g_strdup_printf #undef g_strdup_vprintf @@ -173,6 +174,25 @@ vir_g_canonicalize_filename(const gchar *filename, } +gboolean +vir_g_hash_table_steal_extended(GHashTable *hash_table, + gconstpointer lookup_key, + gpointer *stolen_key, + gpointer *stolen_value) +{ +#if GLIB_CHECK_VERSION(2, 58, 0) + return g_hash_table_steal_extended(hash_table, lookup_key, stolen_key, stolen_value); +#else /* ! GLIB_CHECK_VERSION(2, 58, 0) */ + if (!(g_hash_table_lookup_extended(hash_table, lookup_key, stolen_key, stolen_value))) + return FALSE; + + g_hash_table_steal(hash_table, lookup_key); + + return TRUE; +#endif /* ! GLIB_CHECK_VERSION(2, 58, 0) */ +} + + /* Drop when min glib >= 2.63.0 */ gint vir_g_fsync(gint fd) diff --git a/src/util/glibcompat.h b/src/util/glibcompat.h index 697687b967..1f3a6f728f 100644 --- a/src/util/glibcompat.h +++ b/src/util/glibcompat.h @@ -70,6 +70,14 @@ gchar * vir_g_canonicalize_filename(const gchar *filename, const gchar *relative_to); + +gboolean +vir_g_hash_table_steal_extended(GHashTable *hash_table, + gconstpointer lookup_key, + gpointer *stolen_key, + gpointer *stolen_value); +#define g_hash_table_steal_extended vir_g_hash_table_steal_extended + gint vir_g_fsync(gint fd); char *vir_g_strdup_printf(const char *msg, ...) G_GNUC_PRINTF(1, 2); diff --git a/src/util/virhash.c b/src/util/virhash.c index a89b2d662e..c72c248186 100644 --- a/src/util/virhash.c +++ b/src/util/virhash.c @@ -242,24 +242,19 @@ virHashHasEntry(GHashTable *table, * Find the userdata specified by @name * and remove it from the hash without freeing it. * - * Deprecated: consider using g_hash_table_steal_extended once we upgrade to - * glib 2.58 + * Deprecated: consider using g_hash_table_steal_extended instead * * Returns a pointer to the userdata */ void *virHashSteal(GHashTable *table, const char *name) { - g_autofree void *orig_name = NULL; + g_autofree void *orig_name = NULL; /* the original key needs to be freed */ void *val = NULL; if (!table || !name) return NULL; - /* we can replace this by g_hash_table_steal_extended with glib 2.58 */ - if (!(g_hash_table_lookup_extended(table, name, &orig_name, &val))) - return NULL; - - g_hash_table_steal(table, name); + g_hash_table_steal_extended(table, name, &orig_name, &val); return val; } -- 2.35.3

2 1

[libvirt PATCH] virt-host-validate: Improve failure message when no HW virt is found
by Martin Kletzander 30 May '22

30 May '22

Make sure that more users understand that without HW virtualization you cannot have KVM working. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2086677 Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- tools/virt-host-validate-qemu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/virt-host-validate-qemu.c b/tools/virt-host-validate-qemu.c index 46ff1d249488..fcf9876ac916 100644 --- a/tools/virt-host-validate-qemu.c +++ b/tools/virt-host-validate-qemu.c @@ -71,7 +71,8 @@ int virHostValidateQEMU(void) virHostMsgPass(); } else { virHostMsgFail(VIR_HOST_VALIDATE_FAIL, - _("Only emulated CPUs are available, performance will be significantly limited")); + _("Host not compatible with KVM, HW virtualization CPU features not found. " + "Only emulated CPUs are available, performance will be significantly limited")); ret = -1; } } -- 2.35.1

2 1

Entering freeze for libvirt-8.4.0
by Jiri Denemark 30 May '22

30 May '22

I have just tagged v8.4.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Thanks, Jirka

1 1

[PATCH] qemuProcessStop: Don't try to remove QoS on already removed TAP
by Michal Privoznik 30 May '22

30 May '22

When cleaning up after stopped domain, one of the things we do is attempt to clear QoS settings on OVS type interfaces. Well, this is needless because they were removed just a couple of lines above. As a result, the attempt fails and a warning is printed into logs, polluting them needlessly. Closes: https://gitlab.com/libvirt/libvirt/-/issues/313 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_process.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 07acb1c427..c6d965d720 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -8166,12 +8166,6 @@ void qemuProcessStop(virQEMUDriver *driver, else VIR_WARN("Unable to release network device '%s'", NULLSTR(net->ifname)); } - - if (virDomainNetDefIsOvsport(net) && - virNetDevOpenvswitchInterfaceClearQos(net->ifname, vm->def->uuid) < 0) { - VIR_WARN("cannot clear bandwidth setting for ovs device : %s", - net->ifname); - } } retry: -- 2.35.1

2 1

[PATCH] docs: patches: Add a note about reviews and contacting developers
by Peter Krempa 30 May '22

30 May '22

Add a note outling best practices around review and responding to it. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- docs/submitting-patches.rst | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/docs/submitting-patches.rst b/docs/submitting-patches.rst index 7cb5c2e172..d6bc9b623c 100644 --- a/docs/submitting-patches.rst +++ b/docs/submitting-patches.rst @@ -89,3 +89,18 @@ Moreover, such patch needs to be prefixed correctly with ``--subject-prefix=PATCHv2`` appended to ``git send-email`` (substitute ``v2`` with the correct version if needed though). + +Reviews +------- + +Please note that reviewing may take a lot of effort so be patient. Try to react +to questions from reviewers. There's no need to acknowledge individual points +before addressing them in next version. Make sure to address all of reviewers +requests, or start a discussion if you don't agree with reviewers points. + +Feel free to respond to any flaw in any patch on the list, do not feel obliged +to review the rest of the series in such case. + +If your patches don't get attention after some time (~week) feel free to +remind us on list that your patches still need review. **Do not** contact +individual maintainers directly to review your patches. -- 2.35.3

2 1

[PATCH 0/2] 2 release notes for v8.4.0
by Han Han 30 May '22

30 May '22

Han Han (2): news: Add qemu-vdagent news: Add APIs virDomainSaveParams virDomainRestoreParams NEWS.rst | 12 ++++++++++++ 1 file changed, 12 insertions(+) -- 2.36.1

1 2

[libvirt PATCH] tools: add virt-qmp-proxy for proxying QMP clients to libvirt QEMU guests
by Daniel P. Berrangé 27 May '22

27 May '22

Libvirt provides QMP passthrough APIs for the QEMU driver and these are exposed in virsh. It is not especially pleasant, however, using the raw QMP JSON syntax. QEMU has a tool 'qmp-shell' which can speak QMP and exposes a human friendly interactive shell. It is not possible to use this with libvirt managed guest, however, since only one client can attach to he QMP socket at any point in time. The virt-qmp-proxy tool aims to solve this problem. It opens a UNIX socket and listens for incoming client connections, speaking QMP on the connected socket. It will forward any QMP commands received onto the running libvirt QEMU guest, and forward any replies back to the QMP client. $ virsh start demo $ virt-qmp-proxy demo demo.qmp & $ qmp-shell demo.qmp Welcome to the QMP low-level shell! Connected to QEMU 6.2.0 (QEMU) query-kvm { "return": { "enabled": true, "present": true } } Note this tool of course has the same risks as the raw libvirt QMP passthrough. It is safe to run query commands to fetch information but commands which change the QEMU state risk disrupting libvirt's management of QEMU, potentially resulting in data loss/corruption in the worst case. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- CC'ing QEMU since this is likely of interest to maintainers and users who work with QEMU and libvirt Note this impl is fairly crude in that it assumes it is receiving the QMP commands linewise one at a time. None the less it is good enough to work with qmp-shell already, so I figured it was worth exposing to the world. It also lacks support for forwarding events back to the QMP client. docs/manpages/meson.build | 1 + docs/manpages/virt-qmp-proxy.rst | 123 ++++++++++++++++++++++++++++ tools/meson.build | 5 ++ tools/virt-qmp-proxy | 133 +++++++++++++++++++++++++++++++ 4 files changed, 262 insertions(+) create mode 100644 docs/manpages/virt-qmp-proxy.rst create mode 100755 tools/virt-qmp-proxy diff --git a/docs/manpages/meson.build b/docs/manpages/meson.build index ba673cf472..4162a9969a 100644 --- a/docs/manpages/meson.build +++ b/docs/manpages/meson.build @@ -18,6 +18,7 @@ docs_man_files = [ { 'name': 'virt-pki-query-dn', 'section': '1', 'install': true }, { 'name': 'virt-pki-validate', 'section': '1', 'install': true }, { 'name': 'virt-qemu-run', 'section': '1', 'install': conf.has('WITH_QEMU') }, + { 'name': 'virt-qmp-proxy', 'section': '1', 'install': conf.has('WITH_QEMU') }, { 'name': 'virt-xml-validate', 'section': '1', 'install': true }, { 'name': 'libvirt-guests', 'section': '8', 'install': conf.has('WITH_LIBVIRTD') }, diff --git a/docs/manpages/virt-qmp-proxy.rst b/docs/manpages/virt-qmp-proxy.rst new file mode 100644 index 0000000000..94679406ab --- /dev/null +++ b/docs/manpages/virt-qmp-proxy.rst @@ -0,0 +1,123 @@ +============== +virt-qmp-proxy +============== + +-------------------------------------------------- +Expose a QMP proxy server for a libvirt QEMU guest +-------------------------------------------------- + +:Manual section: 1 +:Manual group: Virtualization Support + +.. contents:: + + +SYNOPSIS +======== + +``virt-qmp-proxy`` [*OPTION*]... *DOMAIN* *QMP-SOCKET-PATH* + + +DESCRIPTION +=========== + +This tool provides a way to expose a QMP proxy server that communicates +with a QEMU guest managed by libvirt. This enables standard QMP client +tools to interact with libvirt managed guests. + +**NOTE: use of this tool will result in the running QEMU guest being +marked as tainted.** It is strongly recommended that this tool *only be +used to send commands which query information* about the running guest. +If this tool is used to make changes to the state of the guest, this +may have negative interactions with the QEMU driver, resulting in an +inability to manage the guest operation thereafter, and in the worst +case **potentially lead to data loss or corruption**. + +The ``virt-qmp-proxy`` program will listen on a UNIX socket for incoming +client connections, and run the QMP protocol over the connection. Any +commands received will be sent to the running libvirt guest, and replies +sent back. + +The ``virt-qemu-proxy`` program may be interrupted (eg Ctrl-C) when it +is no longer required. The libvirt QEMU guest will continue running. + + +OPTIONS +======= + +*DOMAIN* + +The ID or UUID or Name of the libvirt QEMU guest. + +*QMP-SOCKET-PATH* + +The filesystem path at which to run the QMP server, listening for +incoming connections. + +``-c`` *CONNECTION-URI* +``--connect``\ =\ *CONNECTION-URI* + +The URI for the connection to the libvirt QEMU driver. If omitted, +a URI will be auto-detected. + +``-v``, ``--verbose`` + +Run in verbose mode, printing all QMP commands and replies that +are handled. + +``-h``, ``--help`` + +Display the command line help. + + +EXIT STATUS +=========== + +Upon successful shutdown, an exit status of 0 will be set. Upon +failure a non-zero status will be set. + + +AUTHOR +====== + +Daniel P. Berrangé + + +BUGS +==== + +Please report all bugs you discover. This should be done via either: + +#. the mailing list + + `https://libvirt.org/contact.html <https://libvirt.org/contact.html>`_ + +#. the bug tracker + + `https://libvirt.org/bugs.html <https://libvirt.org/bugs.html>`_ + +Alternatively, you may report bugs to your software distributor / vendor. + +NOTE: at this time there is no support for forwarding QMP events back +to the clients + +COPYRIGHT +========= + +Copyright (C) 2022 by Red Hat, Inc. + + +LICENSE +======= + +``virt-qemu-proxy`` is distributed under the terms of the GNU LGPL v2+. +This is free software; see the source for copying conditions. There +is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR +PURPOSE + + +SEE ALSO +======== + +virsh(1), `https://libvirt.org/ <https://libvirt.org/>`_, +`QMP reference <https://www.qemu.org/docs/master/interop/qemu-qmp-ref.html>`_ diff --git a/tools/meson.build b/tools/meson.build index bb28a904dc..4e959ecf0b 100644 --- a/tools/meson.build +++ b/tools/meson.build @@ -320,6 +320,11 @@ if conf.has('WITH_LIBVIRTD') endif endif +if conf.has('WITH_QEMU') + install_data('virt-qmp-proxy', + install_dir: bindir) +endif + if bash_completion_dep.found() subdir('bash-completion') endif diff --git a/tools/virt-qmp-proxy b/tools/virt-qmp-proxy new file mode 100755 index 0000000000..57f9759fab --- /dev/null +++ b/tools/virt-qmp-proxy @@ -0,0 +1,133 @@ +#!/usr/bin/env python3 + +import argparse +import libvirt +import libvirt_qemu +import os +import re +import socket +import sys +import json + + +def get_domain(uri, domstr): + conn = libvirt.open(uri) + + dom = None + if re.match(r'^\d+$', domstr): + dom = conn.lookupByID(int(domstr)) + elif re.match(r'^[+a-f0-9]+$', domstr): + dom = conn.lookupByUUIDString(domstr) + else: + dom = conn.lookupByName(domstr) + + if not dom.isActive(): + raise Exception( + "Domain must be running to validate measurement") + + return conn, dom + + +def qmp_server(conn, dom, client, verbose): + ver = conn.getVersion() + major = int(ver / 1000000) % 1000 + minor = int(ver / 1000) % 1000 + micro = ver % 1000 + + greetingobj = { + "QMP": { + "version": { + "qemu": { + "major": major, + "minor": minor, + "micro": micro, + }, + "package": f"qemu-{major}.{minor}.{micro}", + }, + "capabilities": [ + "oob" + ], + } + } + greeting = json.dumps(greetingobj) + "\r\n" + if verbose: + print(greeting, end='') + client.send(greeting.encode("utf-8")) + + while True: + # XXX shouldn't blindly assume this one read + # will fully capture one-and-only-one cmd + cmd = client.recv(1024).decode('utf8') + if verbose: + print(cmd) + + if cmd == "": + break + + if "qmp_capabilities" in cmd: + capabilitiesobj = { + "return": {}, + } + capabilities = json.dumps(capabilitiesobj) + "\r\n" + if verbose: + print(capabilities, end='') + client.send(capabilities.encode("utf-8")) + continue + + id = None + if "id" in cmd: + id = cmd[id] + + res = libvirt_qemu.qemuMonitorCommand(dom, cmd, 0) + + resobj = json.loads(res) + del resobj["id"] + if id is not None: + resobj["id"] = id + res = json.dumps(resobj) + "\r\n" + if verbose: + print(res, end='') + + client.send(res.encode('utf8')) + + +def parse_commandline(): + parser = argparse.ArgumentParser(description="Libvirt QMP proxy") + parser.add_argument("--connect", "-c", + help="Libvirt QEMU driver connection URI") + parser.add_argument("--verbose", "-v", action='store_true', + help="Display QMP traffic") + parser.add_argument("domain", metavar="DOMAIN", + help="Libvirt guest domain ID/UUID/Name") + parser.add_argument("sockpath", metavar="QMP-SOCK-PATH", + help="UNIX socket path for QMP server") + + return parser.parse_args() + + +def main(): + args = parse_commandline() + + conn, dom = get_domain(args.connect, args.domain) + + if conn.getType() != "QEMU": + raise Exception("QMP proxy requires a QEMU driver connection not %s" % + conn.getType()) + + sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM) + if os.path.exists(args.sockpath): + os.unlink(args.sockpath) + sock.bind(args.sockpath) + sock.listen(1) + + while True: + client, peeraddr = sock.accept() + qmp_server(conn, dom, client, args.verbose) + + +try: + main() + sys.exit(0) +except Exception as e: + print("%s: %s" % (sys.argv[0], str(e))) + sys.exit(1) -- 2.36.1

4 8

Upstream issue triage
by Peter Krempa 27 May '22

27 May '22

Hi, over the last week I've (re)triaged all of the upstream open issues. Now there are still some issues which per the classification are unconfirmed. That means I'm not sure whether the bug or feature request makes sense. I'd highly appreciate for assistance in looking at those. Please refer to the links on the new page I'm adding in the patch as the gitlab links are quite verbose. https://pipo.sk.gitlab.io/-/libvirt/-/jobs/2515052302/artifacts/website/iss… or once it gets merged at https://libvirt.org/issue-handling.html#issues-needing-attention Peter Krempa (1): docs: Add article about handling upstream issues docs/docs.rst | 3 + docs/issue-handling.rst | 164 ++++++++++++++++++++++++++++++++++++++++ docs/meson.build | 1 + 3 files changed, 168 insertions(+) create mode 100644 docs/issue-handling.rst -- 2.35.3

1 1

[PATCH] ci: Refresh generated files
by Martin Kletzander 27 May '22

27 May '22

Notable changes: * 'lcitool manifest' now generates absolute include paths Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- Pushed under the 'build-breaker' and 'just-ci-update' rules (just in case the latter also exists). ci/gitlab.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ci/gitlab.yml b/ci/gitlab.yml index 379a41111cab..cab4e6074c21 100644 --- a/ci/gitlab.yml +++ b/ci/gitlab.yml @@ -5,8 +5,8 @@ # https://gitlab.com/libvirt/libvirt-ci include: - - local: 'ci/gitlab/container-templates.yml' - - local: 'ci/gitlab/build-templates.yml' - - local: 'ci/gitlab/sanity-checks.yml' - - local: 'ci/gitlab/containers.yml' - - local: 'ci/gitlab/builds.yml' + - local: '/ci/gitlab/container-templates.yml' + - local: '/ci/gitlab/build-templates.yml' + - local: '/ci/gitlab/sanity-checks.yml' + - local: '/ci/gitlab/containers.yml' + - local: '/ci/gitlab/builds.yml' -- 2.35.1

2 3

[PATCH] NEWS: Mention 'absolute' clock offset
by Peter Krempa 27 May '22

27 May '22

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index b0d4297d53..e50010f9b2 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -26,6 +26,13 @@ v8.4.0 (unreleased) Support for the recently released IBM Power10 processor was added. + * qemu: Introduce ``absolute`` clock offset + + The ``absolute`` clock offset type allows to set the guest clock to an + arbitrary epoch timestamp at each start. This is useful if some VM needs + to be kept set to an arbitrary time for e.g. testing or working around + broken software. + * **Improvements** * **Bug fixes** -- 2.35.3

2 1

[libvirt PATCH] gitlab: mark job dependencies as optional
by Daniel P. Berrangé 27 May '22

27 May '22

The container jobs are all optional in upstream now, only running if dockerfile changes were made. Thus any build jobs which reference the container jobs need to mark their dependency as optional too. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- .gitlab-ci.yml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 0fbdd82aae..013f821881 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -62,7 +62,8 @@ website: stage: builds image: $CI_REGISTRY_IMAGE/ci-almalinux-8:latest needs: - - x86_64-almalinux-8-container + - job: x86_64-almalinux-8-container + optional: true before_script: - *script_variables script: @@ -82,7 +83,8 @@ codestyle: stage: sanity_checks image: $CI_REGISTRY_IMAGE/ci-opensuse-leap-153:latest needs: - - x86_64-opensuse-leap-153-container + - job: x86_64-opensuse-leap-153-container + optional: true before_script: - *script_variables script: @@ -98,7 +100,8 @@ potfile: stage: builds image: $CI_REGISTRY_IMAGE/ci-almalinux-8:latest needs: - - x86_64-almalinux-8-container + - job: x86_64-almalinux-8-container + optional: true rules: - if: "$CI_COMMIT_BRANCH == 'master'" before_script: -- 2.36.1

2 1

[PATCH] nss: Compare hostname case insensitive
by Michal Privoznik 27 May '22

27 May '22

There are some tools that convert hostname to lowercase before resolving it (e.g. ssh). In a way it makes sense because DNS is case insensitive and in case of ssh the lowercase version is then used to find matching record in its config file. However, our NSS module performs case sensitive comparison, which makes it useless with ssh. Just consider a machine named FooBar. Therefore, switch to case insensitive string comparison. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1777873 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- build-aux/syntax-check.mk | 2 +- tests/nsstest.c | 1 + tools/nss/libvirt_nss_leases.c | 2 +- tools/nss/libvirt_nss_macs.c | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 73f8a21c1b..f9f60c934c 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -1337,7 +1337,7 @@ sc_prohibit_enum_impl_with_vir_prefix_in_virsh: ## Exceptions ## ## ---------- ## -exclude_file_name_regexp--sc_avoid_strcase = ^tools/vsh\.h$$ +exclude_file_name_regexp--sc_avoid_strcase = ^tools/(vsh\.h|nss/libvirt_nss_(leases|macs)\.c)$$ exclude_file_name_regexp--sc_avoid_write = ^src/libvirt-stream\.c$$ diff --git a/tests/nsstest.c b/tests/nsstest.c index 2c2e57769b..a03f230452 100644 --- a/tests/nsstest.c +++ b/tests/nsstest.c @@ -173,6 +173,7 @@ mymain(void) # if !defined(LIBVIRT_NSS_GUEST) DO_TEST("fedora", AF_INET, "192.168.122.197", "192.168.122.198", "192.168.122.199", "192.168.122.3"); DO_TEST("gentoo", AF_INET, "192.168.122.254"); + DO_TEST("Gentoo", AF_INET, "192.168.122.254"); DO_TEST("gentoo", AF_INET6, "2001:1234:dead:beef::2"); DO_TEST("gentoo", AF_UNSPEC, "192.168.122.254"); DO_TEST("non-existent", AF_UNSPEC, NULL); diff --git a/tools/nss/libvirt_nss_leases.c b/tools/nss/libvirt_nss_leases.c index 536fcf8608..770dae8625 100644 --- a/tools/nss/libvirt_nss_leases.c +++ b/tools/nss/libvirt_nss_leases.c @@ -272,7 +272,7 @@ findLeasesParserEndMap(void *ctx) } } else { DEBUG("Check name '%s' vs '%s'", parser->name, NULLSTR(parser->entry.hostname)); - if (parser->entry.hostname && !strcmp(parser->name, parser->entry.hostname)) + if (parser->entry.hostname && !strcasecmp(parser->name, parser->entry.hostname)) found = true; } DEBUG("Found %d", found); diff --git a/tools/nss/libvirt_nss_macs.c b/tools/nss/libvirt_nss_macs.c index d4b165eef6..f45d149793 100644 --- a/tools/nss/libvirt_nss_macs.c +++ b/tools/nss/libvirt_nss_macs.c @@ -142,7 +142,7 @@ findMACsParserEndMap(void *ctx) if (parser->state != FIND_MACS_STATE_ENTRY) return 0; - if (!strcmp(parser->entry.name, parser->name)) { + if (!strcasecmp(parser->entry.name, parser->name)) { char **macs = realloc(*parser->macs, sizeof(char *) * ((*parser->nmacs) + parser->entry.nmacs)); if (!macs) -- 2.35.1

3 2

[libvirt PATCH 0/4] ci: Drop Fedora 34, add Fedora 36
by Andrea Bolognani 26 May '22

26 May '22

Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/548549670 Matching libvirt-perl MR, needed because the integration tests download artifacts from there: https://gitlab.com/libvirt/libvirt-perl/-/merge_requests/63 Andrea Bolognani (4): ci: Drop Fedora 34 ci: Refresh generated files ci: Add Fedora 36 ci: Move nonstandard jobs from Fedora 35 to Fedora 36 ...ile => fedora-36-cross-mingw32.Dockerfile} | 2 +- ...ile => fedora-36-cross-mingw64.Dockerfile} | 2 +- ...ora-34.Dockerfile => fedora-36.Dockerfile} | 3 +- ci/gitlab.yml | 767 +----------------- ci/gitlab/build-templates.yml | 45 + ci/gitlab/builds.yml | 402 +++++++++ ci/gitlab/container-templates.yml | 52 ++ ci/gitlab/containers.yml | 325 ++++++++ ci/gitlab/sanity-checks.yml | 18 + ci/integration.yml | 22 +- ci/manifest.yml | 10 +- 11 files changed, 864 insertions(+), 784 deletions(-) rename ci/containers/{fedora-35-cross-mingw32.Dockerfile => fedora-36-cross-mingw32.Dockerfile} (98%) rename ci/containers/{fedora-35-cross-mingw64.Dockerfile => fedora-36-cross-mingw64.Dockerfile} (98%) rename ci/containers/{fedora-34.Dockerfile => fedora-36.Dockerfile} (97%) create mode 100644 ci/gitlab/build-templates.yml create mode 100644 ci/gitlab/builds.yml create mode 100644 ci/gitlab/container-templates.yml create mode 100644 ci/gitlab/containers.yml create mode 100644 ci/gitlab/sanity-checks.yml -- 2.35.3

3 10

[libvirt PATCH 0/3] Fix null string specifiers detected by GCC
by Scott Davis 26 May '22

26 May '22

Each of the following tripped the -Wformat-overflow warning in GCC 11. The fixes all seemed pretty obvious based on the context. Apologies for any formatting or other mistakes, this is my first time submitting libvirt patches and using git publish. Scott Davis (3): qemu: fix null string specifier argument in qemuDomainBlockJobAbort remote: fix null string specifier argument in remoteProbeSessionDriverFromBinary vircgroupv1: fix null string specifier argument in virCgroupV1ValidatePlacement src/qemu/qemu_driver.c | 8 ++++---- src/remote/remote_sockets.c | 2 +- src/util/vircgroupv1.c | 5 ++--- 3 files changed, 7 insertions(+), 8 deletions(-) -- 2.25.1

3 6

Logging code, async signal safety, and syslog CEE
by Mike Pontillo 26 May '22

26 May '22

I was recently looking at an old (rejected) patch to add syslog CEE support[1], and a related ticket asking to rewrite the syslog logger to be async signal safe[2]. I'm hoping someone can help me understand the potential issues here, because I would like to work on adding syslog CCE support, and it seems like I should proceed with caution. According to issue #5, the syslog() function is unsafe due to the underlying use of sprintf(). However, in the logging code itself, g_strdup_vprintf() is called prior to the callouts to the defined log outputs. Is this call considered safe? What about other calls to GLib that occur within the output routines, such as the call to g_mkstemp_full()? Is there a test case I can execute to gain confidence that any new logging code I add will be async signal safe? Are there existing, known calls to the logger that can occur within a signal handler (or other circumstance that requires async signal safety)? The approach I was thinking of could build upon what was done for journald support, in that it could make use of the "meta" struct to define additional keys for the JSON message. I think the only complexity is the need to build up a new string. I don't think there is any need to support a "hierarchy"; building up a flat JSON dictionary should be all that is needed. So, if it is undesirable to call out to a JSON library (this was considered problematic in the original patch), the strings to be logged could be escaped and concatenated into a dictionary, and then sent up in the same way as existing syslog messages. NB: I also noticed that the journald structured logging fields tend to be all uppercase. I feel like it might also be good to convert the keys to lowercase, for consistency with the other CEE logs I have seen. Would a contribution like this be welcome in libvirt? I would appreciate any thoughts. Thanks, Mike [1]: https://listman.redhat.com/archives/libvir-list/2012-September/064560.html [2]: https://gitlab.com/libvirt/libvirt/-/issues/5

1 0

[PATCH 0/2] Avoid memcpy with NULL argument
by Peter Krempa 25 May '22

25 May '22

Behaviour is undefined per C standard. Peter Krempa (2): virNetMessageEncodePayloadRaw: Tolerate empty 'data' virNetMessageEncodePayloadEmpty: Replace by virNetMessageEncodePayloadRaw(msg, NULL, 0) src/rpc/virkeepalive.c | 2 +- src/rpc/virnetmessage.c | 76 ++++++++++++++--------------------- src/rpc/virnetmessage.h | 2 - src/rpc/virnetserverprogram.c | 9 +---- 4 files changed, 34 insertions(+), 55 deletions(-) -- 2.35.3

3 4

[PATCH 0/3] ppc64: POWER10 support
by Daniel Henrique Barboza 24 May '22

24 May '22

Changes from v2: - rebased with current master - patch 2: - added qemuxml2xmltest - all tests are now using DO_TEST_CAPS_ARCH_LATEST() - new patch 3: added NEWS.rst update - v2 link: https://listman.redhat.com/archives/libvir-list/2022-May/230746.html Daniel Henrique Barboza (3): cpu_map: add POWER10 cpu model cpu_ppc64: add support for host-model on POWER10 NEWS.rst: document Power10 support NEWS.rst | 4 ++ src/cpu/cpu_ppc64.c | 8 ++-- src/cpu_map/index.xml | 1 + src/cpu_map/meson.build | 1 + src/cpu_map/ppc64_POWER10.xml | 6 +++ tests/domaincapsdata/qemu_5.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_6.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_7.0.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 4 +- .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 4 +- .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 4 +- .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml | 4 +- ...eries-cpu-compat-power10.ppc64-latest.args | 34 +++++++++++++++ ...series-cpu-compat-power10.ppc64-latest.err | 1 + .../pseries-cpu-compat-power10.xml | 21 ++++++++++ tests/qemuxml2argvtest.c | 4 ++ ...series-cpu-compat-power10.ppc64-latest.xml | 41 +++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + tests/testutilshostcpus.h | 11 +++++ tests/testutilsqemu.c | 6 ++- tests/testutilsqemu.h | 2 + 22 files changed, 148 insertions(+), 13 deletions(-) create mode 100644 src/cpu_map/ppc64_POWER10.xml create mode 100644 tests/qemuxml2argvdata/pseries-cpu-compat-power10.ppc64-latest.args create mode 100644 tests/qemuxml2argvdata/pseries-cpu-compat-power10.ppc64-latest.err create mode 100644 tests/qemuxml2argvdata/pseries-cpu-compat-power10.xml create mode 100644 tests/qemuxml2xmloutdata/pseries-cpu-compat-power10.ppc64-latest.xml -- 2.32.0

2 6

[libvirt PATCH 0/6] Fix and refactor QMP event processing
by Jiri Denemark 24 May '22

24 May '22

Jiri Denemark (6): qemu: Avoid unlocked access to vm object in monitor callbacks qemu: Pass arguments to qemuProcessEventSubmit directly qemu: Make vm parameter of qemuProcessEventSubmit mandatory qemu: Drop driver parameter from qemuProcessEventSubmit qemu: Do not use opaque pointer in QEMU monitor callbacks qemu: Do not pass unused opaque pointer to monitor callbacks src/qemu/qemu_monitor.c | 16 +- src/qemu/qemu_monitor.h | 108 ++++------ src/qemu/qemu_monitor_priv.h | 1 - src/qemu/qemu_process.c | 384 +++++++++++++---------------------- src/qemu/qemu_processpriv.h | 3 +- tests/qemuhotplugtest.c | 3 +- tests/qemumonitortestutils.c | 15 +- tests/qemumonitortestutils.h | 5 +- 8 files changed, 191 insertions(+), 344 deletions(-) -- 2.35.1

2 7

[libvirt PATCH 0/2] syntax-check: Add versioning information and update
by Andrea Bolognani 24 May '22

24 May '22

Andrea Bolognani (2): syntax-check: Add versioning information syntax-check: Pull updates from gnulib build-aux/syntax-check.mk | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) -- 2.35.3

3 6

[PATCH] build-aux: remove syntax checks for ATTRIBUTE_* and ARRAY_CARDINALITY
by Daniel P. Berrangé 24 May '22

24 May '22

These checks made sense when we were in process of converting code. Since the definition of the macros has been entirely removed now, the compiler will already thrown an error. There aren't likely to be any in-flight patches that would hit this anyone either. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- build-aux/syntax-check.mk | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 09e7a014a3..e4c142dfd0 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -338,18 +338,6 @@ sc_avoid_g_gnuc_unused_in_header: halt='use G_GNUC_UNUSED in .c rather than .h files' \ $(_sc_search_regexp) -sc_prohibit_attribute_macros: - @prohibit='ATTRIBUTE_(UNUSED|NORETURN|SENTINEL|RETURN_CHECK|NOINLINE|FMT_PRINTF|FALLTHROUGH)' \ - in_vc_files='\.[ch]$$' \ - halt='use GLib macros: G_GNUC_<ATTRIBUTE_SUFFIX> for most' \ - $(_sc_search_regexp) - -sc_prohibit_non_glib_macros: - @prohibit='ARRAY_CARDINALITY' \ - in_vc_files='\.[ch]$$' \ - halt='use GLib macros: G_N_ELEMENTS' \ - $(_sc_search_regexp) - sc_prohibit_int_index: @prohibit='\<(int|unsigned)\s*\*?index\>(\s|,|;)' \ halt='use different name than 'index' for declaration' \ -- 2.36.1

2 1

[libvirt PATCH] qemu: Lock vm object in qemuProcessHandleMemoryFailure
by Jiri Denemark 24 May '22

24 May '22

This event handler was accessing a vm object without locking it first. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_process.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 033d3d5bc6..6f70d5d065 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -1773,6 +1773,8 @@ qemuProcessHandleMemoryFailure(qemuMonitor *mon G_GNUC_UNUSED, virDomainMemoryFailureActionType action; unsigned int flags = 0; + virObjectLock(vm); + switch (mfp->recipient) { case QEMU_MONITOR_MEMORY_FAILURE_RECIPIENT_HYPERVISOR: recipient = VIR_DOMAIN_EVENT_MEMORY_FAILURE_RECIPIENT_HYPERVISOR; @@ -1809,6 +1811,9 @@ qemuProcessHandleMemoryFailure(qemuMonitor *mon G_GNUC_UNUSED, flags |= VIR_DOMAIN_MEMORY_FAILURE_RECURSIVE; event = virDomainEventMemoryFailureNewFromObj(vm, recipient, action, flags); + + virObjectUnlock(vm); + virObjectEventStateQueue(driver->domainEventState, event); } -- 2.35.1

1 1

[PATCH v2] virprocess: Drop workaround for setns() wrt old glibc
by Michal Privoznik 24 May '22

24 May '22

We have our own implementation of setns() which was introduced in v1.2.9-rc1~190 and extended afterwards. The reason was that back in 2014 we were dealing with glibc that in some of its older versions did not provide the function. Mostly for non-intel arches. Nevertheless, glibc now offers the function for all architectures we care about (aarch64 being the freshest architecture where the function was introduced, in glibc-2.17). Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- v2 of: https://listman.redhat.com/archives/libvir-list/2022-May/231773.html diff to v1: - drop setns() detection in meson - make virProcessSetNamespaces() impl depend on __linux__ meson.build | 1 - src/util/virprocess.c | 55 +++++++++---------------------------------- 2 files changed, 11 insertions(+), 45 deletions(-) diff --git a/meson.build b/meson.build index a1c802b00d..c4585bd92c 100644 --- a/meson.build +++ b/meson.build @@ -557,7 +557,6 @@ functions = [ 'prlimit', 'sched_setscheduler', 'setgroups', - 'setns', 'setrlimit', 'symlink', 'sysctlbyname', diff --git a/src/util/virprocess.c b/src/util/virprocess.c index 36d7df050a..5ed0b5d0db 100644 --- a/src/util/virprocess.c +++ b/src/util/virprocess.c @@ -27,7 +27,6 @@ #ifndef WIN32 # include <sys/wait.h> #endif -#include <unistd.h> #if WITH_SYS_MOUNT_H # include <sys/mount.h> #endif @@ -70,49 +69,6 @@ VIR_LOG_INIT("util.process"); -#ifdef __linux__ -/* - * Workaround older glibc. While kernel may support the setns - * syscall, the glibc wrapper might not exist. If that's the - * case, use our own. - */ -# ifndef __NR_setns -# if defined(__x86_64__) -# define __NR_setns 308 -# elif defined(__i386__) -# define __NR_setns 346 -# elif defined(__arm__) -# define __NR_setns 375 -# elif defined(__aarch64__) -# define __NR_setns 375 -# elif defined(__powerpc__) -# define __NR_setns 350 -# elif defined(__s390__) -# define __NR_setns 339 -# endif -# endif - -# ifndef WITH_SETNS -# if defined(__NR_setns) -# include <sys/syscall.h> - -static inline int setns(int fd, int nstype) -{ - return syscall(__NR_setns, fd, nstype); -} -# else /* !__NR_setns */ -# error Please determine the syscall number for setns on your architecture -# endif -# endif -#else /* !__linux__ */ -static inline int setns(int fd G_GNUC_UNUSED, int nstype G_GNUC_UNUSED) -{ - virReportSystemError(ENOSYS, "%s", - _("Namespaces are not supported on this platform.")); - return -1; -} -#endif - VIR_ENUM_IMPL(virProcessSchedPolicy, VIR_PROC_POLICY_LAST, "none", @@ -714,6 +670,7 @@ int virProcessGetNamespaces(pid_t pid, } +#ifdef __linux__ int virProcessSetNamespaces(size_t nfdlist, int *fdlist) { @@ -742,6 +699,16 @@ int virProcessSetNamespaces(size_t nfdlist, } return 0; } +#else +int virProcessSetNamespaces(size_t nfdlist G_GNUC_UNUSED, + int *fdlist G_GNUC_UNUSED) +{ + virReportSystemError(ENOSYS, "%s", + _("Namespaces are not supported on this platform.")); + return -1; +} +#endif + #if WITH_PRLIMIT static int -- 2.35.1

2 1

[PATCH] virprocess: Drop workaround for setns() wrt old glibc
by Michal Privoznik 24 May '22

24 May '22

We have our own implementation of setns() which was introduced in v1.2.9-rc1~190 and extended afterwards. The reason was that back in 2014 we were dealing with glibc that in some of its older versions did not provide the function. Mostly for non-intel arches. Nevertheless, glibc now offers the function for all architectures we care about (aarch64 being the freshest architecture where the function was introduced, in glibc-2.17). Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/util/virprocess.c | 55 +++++++++---------------------------------- 1 file changed, 11 insertions(+), 44 deletions(-) diff --git a/src/util/virprocess.c b/src/util/virprocess.c index 36d7df050a..f0a79396e7 100644 --- a/src/util/virprocess.c +++ b/src/util/virprocess.c @@ -27,7 +27,6 @@ #ifndef WIN32 # include <sys/wait.h> #endif -#include <unistd.h> #if WITH_SYS_MOUNT_H # include <sys/mount.h> #endif @@ -70,49 +69,6 @@ VIR_LOG_INIT("util.process"); -#ifdef __linux__ -/* - * Workaround older glibc. While kernel may support the setns - * syscall, the glibc wrapper might not exist. If that's the - * case, use our own. - */ -# ifndef __NR_setns -# if defined(__x86_64__) -# define __NR_setns 308 -# elif defined(__i386__) -# define __NR_setns 346 -# elif defined(__arm__) -# define __NR_setns 375 -# elif defined(__aarch64__) -# define __NR_setns 375 -# elif defined(__powerpc__) -# define __NR_setns 350 -# elif defined(__s390__) -# define __NR_setns 339 -# endif -# endif - -# ifndef WITH_SETNS -# if defined(__NR_setns) -# include <sys/syscall.h> - -static inline int setns(int fd, int nstype) -{ - return syscall(__NR_setns, fd, nstype); -} -# else /* !__NR_setns */ -# error Please determine the syscall number for setns on your architecture -# endif -# endif -#else /* !__linux__ */ -static inline int setns(int fd G_GNUC_UNUSED, int nstype G_GNUC_UNUSED) -{ - virReportSystemError(ENOSYS, "%s", - _("Namespaces are not supported on this platform.")); - return -1; -} -#endif - VIR_ENUM_IMPL(virProcessSchedPolicy, VIR_PROC_POLICY_LAST, "none", @@ -714,6 +670,7 @@ int virProcessGetNamespaces(pid_t pid, } +#if WITH_SETNS int virProcessSetNamespaces(size_t nfdlist, int *fdlist) { @@ -742,6 +699,16 @@ int virProcessSetNamespaces(size_t nfdlist, } return 0; } +#else +int virProcessSetNamespaces(size_t nfdlist G_GNUC_UNUSED, + int *fdlist G_GNUC_UNUSED) +{ + virReportSystemError(ENOSYS, "%s", + _("Namespaces are not supported on this platform.")); + return -1; +} +#endif + #if WITH_PRLIMIT static int -- 2.35.1

2 1

[libvirt RFC 0/5] introduce virFileDirect API for block-friendly read/write
by Claudio Fontana 24 May '22

24 May '22

As a spin-off from the previous multifd series, this series offers a basic API for virfile.c to deal with reading and writing files opened with O_DIRECT. It applies this new API in the virFileDiskCopy code currently used for iohelper, and reworks the saveimage code and on-disk lengths to be O_DIRECT friendly. This series is also available at: https://gitlab.com/hw-claudio/libvirt.git "directio" Gitlab successful pipeline is at: https://gitlab.com/hw-claudio/libvirt/-/pipelines/546635704 Thank you for your feedback, Claudio Claudio Fontana (5): virfile: introduce virFileDirect APIs virfile: use virFileDirect API in runIOCopy qemu: saveimage: rework image read/write to be O_DIRECT friendly qemu: saveimage: assume future formats will also support compression virfile: virFileDiskCopy: prepare for O_DIRECT files without wrapper src/libvirt_private.syms | 8 + src/qemu/qemu_saveimage.c | 269 ++++++++++++++++++++------------ src/qemu/qemu_saveimage.h | 20 ++- src/util/virfile.c | 316 +++++++++++++++++++++++++++++++++----- src/util/virfile.h | 11 ++ 5 files changed, 476 insertions(+), 148 deletions(-) -- 2.26.2

1 5

[libvirt PATCH 00/11] syntax-check: Minimize http_sites
by Andrea Bolognani 24 May '22

24 May '22

Reduce the number of exceptions we keep around by various means. Andrea Bolognani (11): syntax-check: Drop unused http_sites docs: apps: Drop Tivoli Provisioning Manager docs: apps: Drop Cracow Cloud One docs: apps: Drop Snooze util: Drop references to netlink.pdf docs: Use more generic URL for netcat docs: Update URL for libxml2 docs: Update URL for MinGW docs: Update various URLs docs: Use HTTPS where possible src: Use archive.org for dead URLs build-aux/syntax-check.mk | 18 +----------------- ci/README.rst | 6 +++--- docs/apps.rst | 22 +++------------------- docs/drvhyperv.rst | 2 +- docs/drvlxc.rst | 2 +- docs/remote.rst | 2 +- docs/uri.rst | 2 +- docs/windows.rst | 4 ++-- src/conf/nwfilter_conf.c | 4 ++-- src/conf/schemas/basictypes.rng | 2 +- src/util/virnetdevmacvlan.c | 5 +---- src/util/virnetlink.c | 4 +--- tests/openvzutilstest.conf | 2 +- 13 files changed, 19 insertions(+), 56 deletions(-) -- 2.35.3

2 12

[PATCH v2 0/2] ppc64: POWER10 support
by Daniel Henrique Barboza 24 May '22

24 May '22

Changes in v2: - dropped former patch 01 since qemu ppc64 caps are up to date for 7.0.0 - v1 link: https://listman.redhat.com/archives/libvir-list/2022-May/230686.html Daniel Henrique Barboza (2): cpu_map: add POWER10 cpu model cpu_ppc64: add support for host-model on POWER10 src/cpu/cpu_ppc64.c | 8 ++--- src/cpu_map/index.xml | 1 + src/cpu_map/meson.build | 1 + src/cpu_map/ppc64_POWER10.xml | 6 ++++ tests/domaincapsdata/qemu_5.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_6.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_7.0.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 4 +-- .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 4 +-- .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 4 +-- .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml | 4 +-- .../pseries-cpu-compat-power10.args | 32 +++++++++++++++++++ .../pseries-cpu-compat-power10.err | 1 + .../pseries-cpu-compat-power10.xml | 21 ++++++++++++ tests/qemuxml2argvtest.c | 11 +++++++ tests/testutilshostcpus.h | 11 +++++++ tests/testutilsqemu.c | 4 ++- tests/testutilsqemu.h | 1 + 19 files changed, 104 insertions(+), 13 deletions(-) create mode 100644 src/cpu_map/ppc64_POWER10.xml create mode 100644 tests/qemuxml2argvdata/pseries-cpu-compat-power10.args create mode 100644 tests/qemuxml2argvdata/pseries-cpu-compat-power10.err create mode 100644 tests/qemuxml2argvdata/pseries-cpu-compat-power10.xml -- 2.32.0

2 9

[libvirt PATCH 00/13] syntax-check: Cleanups and improvements
by Andrea Bolognani 24 May '22

24 May '22

$ meson test --suite blurb Andrea Bolognani (13): syntax-check: Drop sc_bindtextdomain check syntax-check: Remove sc_gettext_init exception syntax-check: Remove sc_copyright_usage exception syntax-check: Improve sc_prohibit_config_h_in_headers check syntax-check: Use VC_LIST_EXCEPT in sc_prohibit_backup_files syntax-check: Simplify VC_LIST_ALWAYS_EXCLUDE_REGEX syntax-check: Drop unused machinery syntax-check: Drop ME variable syntax-check: Detect awk the same as all other programs syntax-check: Reorganize file syntax-check: Add all target syntax-check: Drop sc_ prefix when adding checks to meson syntax-check: Enforce sc_prohibit_backslash_alignment everywhere build-aux/Makefile.in | 1 + build-aux/meson.build | 7 +- build-aux/syntax-check.mk | 773 ++++++++++++++++++-------------------- ci/Makefile | 2 +- 4 files changed, 365 insertions(+), 418 deletions(-) -- 2.35.3

2 14

[PATCH] qemu_hotplug: Deny changing @rss and @rss_hash_report attributes of virtio vNICs
by Michal Privoznik 24 May '22

24 May '22

We have virDomainUpdateDeviceFlags() API that allows changing of some attributes of a device whilst domain is still running (e.g. setting different QoS, link state change on vNICs). But only very limited set of attributes can be changed and we have to check whether user isn't trying to sneak in a change that's not allowed. Well, in case of a virtio vNIC we forgot to check for @rss and @rss_hash_report attributes of <driver/>. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2082540 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_hotplug.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 24df66cc9f..f795568299 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -3662,7 +3662,9 @@ qemuDomainChangeNet(virQEMUDriver *driver, olddev->driver.virtio.guest.tso4 != newdev->driver.virtio.guest.tso4 || olddev->driver.virtio.guest.tso6 != newdev->driver.virtio.guest.tso6 || olddev->driver.virtio.guest.ecn != newdev->driver.virtio.guest.ecn || - olddev->driver.virtio.guest.ufo != newdev->driver.virtio.guest.ufo)) { + olddev->driver.virtio.guest.ufo != newdev->driver.virtio.guest.ufo || + olddev->driver.virtio.rss != newdev->driver.virtio.rss || + olddev->driver.virtio.rss_hash_report != newdev->driver.virtio.rss_hash_report)) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", _("cannot modify virtio network device driver attributes")); goto cleanup; -- 2.35.1

3 2

[PATCH] nodedev: prevent internal error on dev_busid parse
by Boris Fiuczynski 24 May '22

24 May '22

As "none" is a legal value represented in the sysfs attribute dev_busid this patch prevents libvirt from incorrectly reporting an internal error. Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com> Suggested-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/node_device/node_device_udev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c index 656130e98a..44ec22cf75 100644 --- a/src/node_device/node_device_udev.c +++ b/src/node_device/node_device_udev.c @@ -1140,7 +1140,7 @@ udevProcessCSS(struct udev_device *device, /* process optional channel devices information */ udevGetStringSysfsAttr(device, "dev_busid", &dev_busid); - if (dev_busid != NULL) + if (dev_busid != NULL && STRNEQ(dev_busid, "none")) def->caps->data.ccw_dev.channel_dev_addr = virCCWDeviceAddressFromString(dev_busid); if (virNodeDeviceGetCSSDynamicCaps(def->sysfs_path, &def->caps->data.ccw_dev) < 0) -- 2.36.1

2 1

[PATCH] qemuxml2xmltests.c: convert pseries tests to DO_TEST_CAPS_ARCH_LATEST
by Daniel Henrique Barboza 24 May '22

24 May '22

qemuxml2xmltests that have "pseries" in the name now use the DO_TEST_CAPS_LATEST_ARCH() macro. Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com> --- ...ies.xml => panic-pseries.ppc64-latest.xml} | 5 +- .../pseries-console-native.ppc64-latest.xml | 1 + .../pseries-console-native.xml | 1 - ...> pseries-console-virtio.ppc64-latest.xml} | 3 + ...series-cpu-compat-power9.ppc64-latest.xml} | 2 +- ...ml => pseries-cpu-compat.ppc64-latest.xml} | 2 +- ...xml => pseries-cpu-exact.ppc64-latest.xml} | 2 +- ....xml => pseries-features.ppc64-latest.xml} | 3 + ...ml => pseries-hostdevs-1.ppc64-latest.xml} | 3 + ...ml => pseries-hostdevs-2.ppc64-latest.xml} | 3 + ...ml => pseries-hostdevs-3.ppc64-latest.xml} | 3 + ... => pseries-many-buses-1.ppc64-latest.xml} | 3 + ... => pseries-many-buses-2.ppc64-latest.xml} | 3 + ... => pseries-many-devices.ppc64-latest.xml} | 3 + ...ram.xml => pseries-nvram.ppc64-latest.xml} | 5 +- ...=> pseries-panic-missing.ppc64-latest.xml} | 5 +- ...pseries-panic-no-address.ppc64-latest.xml} | 5 +- ...ries-phb-default-missing.ppc64-latest.xml} | 11 +- ...=> pseries-phb-numa-node.ppc64-latest.xml} | 3 +- ...ml => pseries-phb-simple.ppc64-latest.xml} | 11 +- ...ies-serial+console-native.ppc64-latest.xml | 1 + .../pseries-serial+console-native.xml | 1 - .../pseries-serial-compat.ppc64-latest.xml | 1 + .../pseries-serial-compat.xml | 1 - ...=> pseries-serial-native.ppc64-latest.xml} | 3 + ...ml => pseries-serial-pci.ppc64-latest.xml} | 3 + ...ml => pseries-serial-usb.ppc64-latest.xml} | 3 + tests/qemuxml2xmltest.c | 107 +++++------------- 28 files changed, 99 insertions(+), 98 deletions(-) rename tests/qemuxml2xmloutdata/{panic-pseries.xml => panic-pseries.ppc64-latest.xml} (88%) create mode 120000 tests/qemuxml2xmloutdata/pseries-console-native.ppc64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/pseries-console-native.xml rename tests/qemuxml2xmloutdata/{pseries-console-virtio.xml => pseries-console-virtio.ppc64-latest.xml} (91%) rename tests/qemuxml2xmloutdata/{pseries-cpu-compat-power9.xml => pseries-cpu-compat-power9.ppc64-latest.xml} (95%) rename tests/qemuxml2xmloutdata/{pseries-cpu-compat.xml => pseries-cpu-compat.ppc64-latest.xml} (95%) rename tests/qemuxml2xmloutdata/{pseries-cpu-exact.xml => pseries-cpu-exact.ppc64-latest.xml} (95%) rename tests/qemuxml2xmloutdata/{pseries-features.xml => pseries-features.ppc64-latest.xml} (91%) rename tests/qemuxml2xmloutdata/{pseries-hostdevs-1.xml => pseries-hostdevs-1.ppc64-latest.xml} (95%) rename tests/qemuxml2xmloutdata/{pseries-hostdevs-2.xml => pseries-hostdevs-2.ppc64-latest.xml} (94%) rename tests/qemuxml2xmloutdata/{pseries-hostdevs-3.xml => pseries-hostdevs-3.ppc64-latest.xml} (94%) rename tests/qemuxml2xmloutdata/{pseries-many-buses-1.xml => pseries-many-buses-1.ppc64-latest.xml} (91%) rename tests/qemuxml2xmloutdata/{pseries-many-buses-2.xml => pseries-many-buses-2.ppc64-latest.xml} (91%) rename tests/qemuxml2xmloutdata/{pseries-many-devices.xml => pseries-many-devices.ppc64-latest.xml} (98%) rename tests/qemuxml2xmloutdata/{pseries-nvram.xml => pseries-nvram.ppc64-latest.xml} (85%) rename tests/qemuxml2xmloutdata/{pseries-panic-missing.xml => pseries-panic-missing.ppc64-latest.xml} (88%) rename tests/qemuxml2xmloutdata/{pseries-panic-no-address.xml => pseries-panic-no-address.ppc64-latest.xml} (88%) rename tests/qemuxml2xmloutdata/{pseries-phb-simple.xml => pseries-phb-default-missing.ppc64-latest.xml} (91%) rename tests/qemuxml2xmloutdata/{pseries-phb-numa-node.xml => pseries-phb-numa-node.ppc64-latest.xml} (94%) rename tests/qemuxml2xmloutdata/{pseries-phb-default-missing.xml => pseries-phb-simple.ppc64-latest.xml} (91%) create mode 120000 tests/qemuxml2xmloutdata/pseries-serial+console-native.ppc64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/pseries-serial+console-native.xml create mode 120000 tests/qemuxml2xmloutdata/pseries-serial-compat.ppc64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/pseries-serial-compat.xml rename tests/qemuxml2xmloutdata/{pseries-serial-native.xml => pseries-serial-native.ppc64-latest.xml} (91%) rename tests/qemuxml2xmloutdata/{pseries-serial-pci.xml => pseries-serial-pci.ppc64-latest.xml} (90%) rename tests/qemuxml2xmloutdata/{pseries-serial-usb.xml => pseries-serial-usb.ppc64-latest.xml} (91%) diff --git a/tests/qemuxml2xmloutdata/panic-pseries.xml b/tests/qemuxml2xmloutdata/panic-pseries.ppc64-latest.xml similarity index 88% rename from tests/qemuxml2xmloutdata/panic-pseries.xml rename to tests/qemuxml2xmloutdata/panic-pseries.ppc64-latest.xml index cebb977d5a..f22634994c 100644 --- a/tests/qemuxml2xmloutdata/panic-pseries.xml +++ b/tests/qemuxml2xmloutdata/panic-pseries.ppc64-latest.xml @@ -8,13 +8,16 @@ <type arch='ppc64' machine='pseries'>hvm</type> <boot dev='hd'/> </os> + <cpu mode='custom' match='exact' check='none'> + <model fallback='forbid'>POWER9</model> + </cpu> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>destroy</on_crash> <devices> <emulator>/usr/bin/qemu-system-ppc64</emulator> - <controller type='usb' index='0'> + <controller type='usb' index='0' model='pci-ohci'> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0'/> </controller> <controller type='pci' index='0' model='pci-root'> diff --git a/tests/qemuxml2xmloutdata/pseries-console-native.ppc64-latest.xml b/tests/qemuxml2xmloutdata/pseries-console-native.ppc64-latest.xml new file mode 120000 index 0000000000..78d6d489ee --- /dev/null +++ b/tests/qemuxml2xmloutdata/pseries-console-native.ppc64-latest.xml @@ -0,0 +1 @@ +pseries-serial-native.ppc64-latest.xml \ No newline at end of file diff --git a/tests/qemuxml2xmloutdata/pseries-console-native.xml b/tests/qemuxml2xmloutdata/pseries-console-native.xml deleted file mode 120000 index 0d45a892c8..0000000000 --- a/tests/qemuxml2xmloutdata/pseries-console-native.xml +++ /dev/null @@ -1 +0,0 @@ -pseries-serial-native.xml \ No newline at end of file diff --git a/tests/qemuxml2xmloutdata/pseries-console-virtio.xml b/tests/qemuxml2xmloutdata/pseries-console-virtio.ppc64-latest.xml similarity index 91% rename from tests/qemuxml2xmloutdata/pseries-console-virtio.xml rename to tests/qemuxml2xmloutdata/pseries-console-virtio.ppc64-latest.xml index 0a44ea36bc..02e3d0136e 100644 --- a/tests/qemuxml2xmloutdata/pseries-console-virtio.xml +++ b/tests/qemuxml2xmloutdata/pseries-console-virtio.ppc64-latest.xml @@ -8,6 +8,9 @@ <type arch='ppc64' machine='pseries'>hvm</type> <boot dev='hd'/> </os> + <cpu mode='custom' match='exact' check='none'> + <model fallback='forbid'>POWER9</model> + </cpu> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> diff --git a/tests/qemuxml2xmloutdata/pseries-cpu-compat-power9.xml b/tests/qemuxml2xmloutdata/pseries-cpu-compat-power9.ppc64-latest.xml similarity index 95% rename from tests/qemuxml2xmloutdata/pseries-cpu-compat-power9.xml rename to tests/qemuxml2xmloutdata/pseries-cpu-compat-power9.ppc64-latest.xml index 93d692be0c..20843f8989 100644 --- a/tests/qemuxml2xmloutdata/pseries-cpu-compat-power9.xml +++ b/tests/qemuxml2xmloutdata/pseries-cpu-compat-power9.ppc64-latest.xml @@ -17,7 +17,7 @@ <on_crash>destroy</on_crash> <devices> <emulator>/usr/bin/qemu-system-ppc64</emulator> - <controller type='usb' index='0'> + <controller type='usb' index='0' model='pci-ohci'> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0'/> </controller> <controller type='pci' index='0' model='pci-root'> diff --git a/tests/qemuxml2xmloutdata/pseries-cpu-compat.xml b/tests/qemuxml2xmloutdata/pseries-cpu-compat.ppc64-latest.xml similarity index 95% rename from tests/qemuxml2xmloutdata/pseries-cpu-compat.xml rename to tests/qemuxml2xmloutdata/pseries-cpu-compat.ppc64-latest.xml index 4b880df610..066708990c 100644 --- a/tests/qemuxml2xmloutdata/pseries-cpu-compat.xml +++ b/tests/qemuxml2xmloutdata/pseries-cpu-compat.ppc64-latest.xml @@ -17,7 +17,7 @@ <on_crash>destroy</on_crash> <devices> <emulator>/usr/bin/qemu-system-ppc64</emulator> - <controller type='usb' index='0'> + <controller type='usb' index='0' model='pci-ohci'> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0'/> </controller> <controller type='pci' index='0' model='pci-root'> diff --git a/tests/qemuxml2xmloutdata/pseries-cpu-exact.xml b/tests/qemuxml2xmloutdata/pseries-cpu-exact.ppc64-latest.xml similarity index 95% rename from tests/qemuxml2xmloutdata/pseries-cpu-exact.xml rename to tests/qemuxml2xmloutdata/pseries-cpu-exact.ppc64-latest.xml index a8e88d012f..307d434051 100644 --- a/tests/qemuxml2xmloutdata/pseries-cpu-exact.xml +++ b/tests/qemuxml2xmloutdata/pseries-cpu-exact.ppc64-latest.xml @@ -18,7 +18,7 @@ <on_crash>destroy</on_crash> <devices> <emulator>/usr/bin/qemu-system-ppc64</emulator> - <controller type='usb' index='0'> + <controller type='usb' index='0' model='pci-ohci'> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0'/> </controller> <controller type='pci' index='0' model='pci-root'> diff --git a/tests/qemuxml2xmloutdata/pseries-features.xml b/tests/qemuxml2xmloutdata/pseries-features.ppc64-latest.xml similarity index 91% rename from tests/qemuxml2xmloutdata/pseries-features.xml rename to tests/qemuxml2xmloutdata/pseries-features.ppc64-latest.xml index 94a8f6a66f..c211da4fb7 100644 --- a/tests/qemuxml2xmloutdata/pseries-features.xml +++ b/tests/qemuxml2xmloutdata/pseries-features.ppc64-latest.xml @@ -19,6 +19,9 @@ <sbbc value='broken'/> <ibs value='fixed-ccd'/> </features> + <cpu mode='custom' match='exact' check='none'> + <model fallback='forbid'>POWER9</model> + </cpu> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> diff --git a/tests/qemuxml2xmloutdata/pseries-hostdevs-1.xml b/tests/qemuxml2xmloutdata/pseries-hostdevs-1.ppc64-latest.xml similarity index 95% rename from tests/qemuxml2xmloutdata/pseries-hostdevs-1.xml rename to tests/qemuxml2xmloutdata/pseries-hostdevs-1.ppc64-latest.xml index cff29a97c2..db369a1fc7 100644 --- a/tests/qemuxml2xmloutdata/pseries-hostdevs-1.xml +++ b/tests/qemuxml2xmloutdata/pseries-hostdevs-1.ppc64-latest.xml @@ -8,6 +8,9 @@ <type arch='ppc64' machine='pseries'>hvm</type> <boot dev='hd'/> </os> + <cpu mode='custom' match='exact' check='none'> + <model fallback='forbid'>POWER9</model> + </cpu> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> diff --git a/tests/qemuxml2xmloutdata/pseries-hostdevs-2.xml b/tests/qemuxml2xmloutdata/pseries-hostdevs-2.ppc64-latest.xml similarity index 94% rename from tests/qemuxml2xmloutdata/pseries-hostdevs-2.xml rename to tests/qemuxml2xmloutdata/pseries-hostdevs-2.ppc64-latest.xml index 598513d784..09b657698d 100644 --- a/tests/qemuxml2xmloutdata/pseries-hostdevs-2.xml +++ b/tests/qemuxml2xmloutdata/pseries-hostdevs-2.ppc64-latest.xml @@ -8,6 +8,9 @@ <type arch='ppc64' machine='pseries'>hvm</type> <boot dev='hd'/> </os> + <cpu mode='custom' match='exact' check='none'> + <model fallback='forbid'>POWER9</model> + </cpu> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> diff --git a/tests/qemuxml2xmloutdata/pseries-hostdevs-3.xml b/tests/qemuxml2xmloutdata/pseries-hostdevs-3.ppc64-latest.xml similarity index 94% rename from tests/qemuxml2xmloutdata/pseries-hostdevs-3.xml rename to tests/qemuxml2xmloutdata/pseries-hostdevs-3.ppc64-latest.xml index a1f00ddc7f..58ffb09c3b 100644 --- a/tests/qemuxml2xmloutdata/pseries-hostdevs-3.xml +++ b/tests/qemuxml2xmloutdata/pseries-hostdevs-3.ppc64-latest.xml @@ -8,6 +8,9 @@ <type arch='ppc64' machine='pseries'>hvm</type> <boot dev='hd'/> </os> + <cpu mode='custom' match='exact' check='none'> + <model fallback='forbid'>POWER9</model> + </cpu> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> diff --git a/tests/qemuxml2xmloutdata/pseries-many-buses-1.xml b/tests/qemuxml2xmloutdata/pseries-many-buses-1.ppc64-latest.xml similarity index 91% rename from tests/qemuxml2xmloutdata/pseries-many-buses-1.xml rename to tests/qemuxml2xmloutdata/pseries-many-buses-1.ppc64-latest.xml index 45521c907a..dbc5d0a94c 100644 --- a/tests/qemuxml2xmloutdata/pseries-many-buses-1.xml +++ b/tests/qemuxml2xmloutdata/pseries-many-buses-1.ppc64-latest.xml @@ -8,6 +8,9 @@ <type arch='ppc64' machine='pseries'>hvm</type> <boot dev='hd'/> </os> + <cpu mode='custom' match='exact' check='none'> + <model fallback='forbid'>POWER9</model> + </cpu> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> diff --git a/tests/qemuxml2xmloutdata/pseries-many-buses-2.xml b/tests/qemuxml2xmloutdata/pseries-many-buses-2.ppc64-latest.xml similarity index 91% rename from tests/qemuxml2xmloutdata/pseries-many-buses-2.xml rename to tests/qemuxml2xmloutdata/pseries-many-buses-2.ppc64-latest.xml index 0b1f670b3f..f9c5a78edd 100644 --- a/tests/qemuxml2xmloutdata/pseries-many-buses-2.xml +++ b/tests/qemuxml2xmloutdata/pseries-many-buses-2.ppc64-latest.xml @@ -8,6 +8,9 @@ <type arch='ppc64' machine='pseries'>hvm</type> <boot dev='hd'/> </os> + <cpu mode='custom' match='exact' check='none'> + <model fallback='forbid'>POWER9</model> + </cpu> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> diff --git a/tests/qemuxml2xmloutdata/pseries-many-devices.xml b/tests/qemuxml2xmloutdata/pseries-many-devices.ppc64-latest.xml similarity index 98% rename from tests/qemuxml2xmloutdata/pseries-many-devices.xml rename to tests/qemuxml2xmloutdata/pseries-many-devices.ppc64-latest.xml index 3c23523c60..5abf023b48 100644 --- a/tests/qemuxml2xmloutdata/pseries-many-devices.xml +++ b/tests/qemuxml2xmloutdata/pseries-many-devices.ppc64-latest.xml @@ -8,6 +8,9 @@ <type arch='ppc64' machine='pseries'>hvm</type> <boot dev='hd'/> </os> + <cpu mode='custom' match='exact' check='none'> + <model fallback='forbid'>POWER9</model> + </cpu> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> diff --git a/tests/qemuxml2xmloutdata/pseries-nvram.xml b/tests/qemuxml2xmloutdata/pseries-nvram.ppc64-latest.xml similarity index 85% rename from tests/qemuxml2xmloutdata/pseries-nvram.xml rename to tests/qemuxml2xmloutdata/pseries-nvram.ppc64-latest.xml index 278222ddea..c7a36df4e2 100644 --- a/tests/qemuxml2xmloutdata/pseries-nvram.xml +++ b/tests/qemuxml2xmloutdata/pseries-nvram.ppc64-latest.xml @@ -8,13 +8,16 @@ <type arch='ppc64' machine='pseries'>hvm</type> <boot dev='hd'/> </os> + <cpu mode='custom' match='exact' check='none'> + <model fallback='forbid'>POWER9</model> + </cpu> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>destroy</on_crash> <devices> <emulator>/usr/bin/qemu-system-ppc64</emulator> - <controller type='usb' index='0'> + <controller type='usb' index='0' model='pci-ohci'> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0'/> </controller> <controller type='pci' index='0' model='pci-root'> diff --git a/tests/qemuxml2xmloutdata/pseries-panic-missing.xml b/tests/qemuxml2xmloutdata/pseries-panic-missing.ppc64-latest.xml similarity index 88% rename from tests/qemuxml2xmloutdata/pseries-panic-missing.xml rename to tests/qemuxml2xmloutdata/pseries-panic-missing.ppc64-latest.xml index cebb977d5a..f22634994c 100644 --- a/tests/qemuxml2xmloutdata/pseries-panic-missing.xml +++ b/tests/qemuxml2xmloutdata/pseries-panic-missing.ppc64-latest.xml @@ -8,13 +8,16 @@ <type arch='ppc64' machine='pseries'>hvm</type> <boot dev='hd'/> </os> + <cpu mode='custom' match='exact' check='none'> + <model fallback='forbid'>POWER9</model> + </cpu> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>destroy</on_crash> <devices> <emulator>/usr/bin/qemu-system-ppc64</emulator> - <controller type='usb' index='0'> + <controller type='usb' index='0' model='pci-ohci'> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0'/> </controller> <controller type='pci' index='0' model='pci-root'> diff --git a/tests/qemuxml2xmloutdata/pseries-panic-no-address.xml b/tests/qemuxml2xmloutdata/pseries-panic-no-address.ppc64-latest.xml similarity index 88% rename from tests/qemuxml2xmloutdata/pseries-panic-no-address.xml rename to tests/qemuxml2xmloutdata/pseries-panic-no-address.ppc64-latest.xml index cebb977d5a..f22634994c 100644 --- a/tests/qemuxml2xmloutdata/pseries-panic-no-address.xml +++ b/tests/qemuxml2xmloutdata/pseries-panic-no-address.ppc64-latest.xml @@ -8,13 +8,16 @@ <type arch='ppc64' machine='pseries'>hvm</type> <boot dev='hd'/> </os> + <cpu mode='custom' match='exact' check='none'> + <model fallback='forbid'>POWER9</model> + </cpu> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>destroy</on_crash> <devices> <emulator>/usr/bin/qemu-system-ppc64</emulator> - <controller type='usb' index='0'> + <controller type='usb' index='0' model='pci-ohci'> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0'/> </controller> <controller type='pci' index='0' model='pci-root'> diff --git a/tests/qemuxml2xmloutdata/pseries-phb-simple.xml b/tests/qemuxml2xmloutdata/pseries-phb-default-missing.ppc64-latest.xml similarity index 91% rename from tests/qemuxml2xmloutdata/pseries-phb-simple.xml rename to tests/qemuxml2xmloutdata/pseries-phb-default-missing.ppc64-latest.xml index 9fa36ca3df..db513febad 100644 --- a/tests/qemuxml2xmloutdata/pseries-phb-simple.xml +++ b/tests/qemuxml2xmloutdata/pseries-phb-default-missing.ppc64-latest.xml @@ -8,16 +8,15 @@ <type arch='ppc64' machine='pseries'>hvm</type> <boot dev='hd'/> </os> + <cpu mode='custom' match='exact' check='none'> + <model fallback='forbid'>POWER9</model> + </cpu> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>destroy</on_crash> <devices> <emulator>/usr/bin/qemu-system-ppc64</emulator> - <controller type='pci' index='0' model='pci-root'> - <model name='spapr-pci-host-bridge'/> - <target index='0'/> - </controller> <controller type='pci' index='1' model='pci-root'> <model name='spapr-pci-host-bridge'/> <target index='1'/> @@ -27,6 +26,10 @@ <target index='2'/> </controller> <controller type='usb' index='0' model='none'/> + <controller type='pci' index='0' model='pci-root'> + <model name='spapr-pci-host-bridge'/> + <target index='0'/> + </controller> <audio id='1' type='none'/> <memballoon model='none'/> <panic model='pseries'/> diff --git a/tests/qemuxml2xmloutdata/pseries-phb-numa-node.xml b/tests/qemuxml2xmloutdata/pseries-phb-numa-node.ppc64-latest.xml similarity index 94% rename from tests/qemuxml2xmloutdata/pseries-phb-numa-node.xml rename to tests/qemuxml2xmloutdata/pseries-phb-numa-node.ppc64-latest.xml index 56d8ee9f86..59015846fb 100644 --- a/tests/qemuxml2xmloutdata/pseries-phb-numa-node.xml +++ b/tests/qemuxml2xmloutdata/pseries-phb-numa-node.ppc64-latest.xml @@ -12,7 +12,8 @@ <type arch='ppc64' machine='pseries'>hvm</type> <boot dev='hd'/> </os> - <cpu> + <cpu mode='custom' match='exact' check='none'> + <model fallback='forbid'>POWER9</model> <topology sockets='2' dies='1' cores='1' threads='4'/> <numa> <cell id='0' cpus='0-3' memory='1048576' unit='KiB'/> diff --git a/tests/qemuxml2xmloutdata/pseries-phb-default-missing.xml b/tests/qemuxml2xmloutdata/pseries-phb-simple.ppc64-latest.xml similarity index 91% rename from tests/qemuxml2xmloutdata/pseries-phb-default-missing.xml rename to tests/qemuxml2xmloutdata/pseries-phb-simple.ppc64-latest.xml index 9966c89167..80231e3dd7 100644 --- a/tests/qemuxml2xmloutdata/pseries-phb-default-missing.xml +++ b/tests/qemuxml2xmloutdata/pseries-phb-simple.ppc64-latest.xml @@ -8,12 +8,19 @@ <type arch='ppc64' machine='pseries'>hvm</type> <boot dev='hd'/> </os> + <cpu mode='custom' match='exact' check='none'> + <model fallback='forbid'>POWER9</model> + </cpu> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>destroy</on_crash> <devices> <emulator>/usr/bin/qemu-system-ppc64</emulator> + <controller type='pci' index='0' model='pci-root'> + <model name='spapr-pci-host-bridge'/> + <target index='0'/> + </controller> <controller type='pci' index='1' model='pci-root'> <model name='spapr-pci-host-bridge'/> <target index='1'/> @@ -23,10 +30,6 @@ <target index='2'/> </controller> <controller type='usb' index='0' model='none'/> - <controller type='pci' index='0' model='pci-root'> - <model name='spapr-pci-host-bridge'/> - <target index='0'/> - </controller> <audio id='1' type='none'/> <memballoon model='none'/> <panic model='pseries'/> diff --git a/tests/qemuxml2xmloutdata/pseries-serial+console-native.ppc64-latest.xml b/tests/qemuxml2xmloutdata/pseries-serial+console-native.ppc64-latest.xml new file mode 120000 index 0000000000..78d6d489ee --- /dev/null +++ b/tests/qemuxml2xmloutdata/pseries-serial+console-native.ppc64-latest.xml @@ -0,0 +1 @@ +pseries-serial-native.ppc64-latest.xml \ No newline at end of file diff --git a/tests/qemuxml2xmloutdata/pseries-serial+console-native.xml b/tests/qemuxml2xmloutdata/pseries-serial+console-native.xml deleted file mode 120000 index 0d45a892c8..0000000000 --- a/tests/qemuxml2xmloutdata/pseries-serial+console-native.xml +++ /dev/null @@ -1 +0,0 @@ -pseries-serial-native.xml \ No newline at end of file diff --git a/tests/qemuxml2xmloutdata/pseries-serial-compat.ppc64-latest.xml b/tests/qemuxml2xmloutdata/pseries-serial-compat.ppc64-latest.xml new file mode 120000 index 0000000000..78d6d489ee --- /dev/null +++ b/tests/qemuxml2xmloutdata/pseries-serial-compat.ppc64-latest.xml @@ -0,0 +1 @@ +pseries-serial-native.ppc64-latest.xml \ No newline at end of file diff --git a/tests/qemuxml2xmloutdata/pseries-serial-compat.xml b/tests/qemuxml2xmloutdata/pseries-serial-compat.xml deleted file mode 120000 index 0d45a892c8..0000000000 --- a/tests/qemuxml2xmloutdata/pseries-serial-compat.xml +++ /dev/null @@ -1 +0,0 @@ -pseries-serial-native.xml \ No newline at end of file diff --git a/tests/qemuxml2xmloutdata/pseries-serial-native.xml b/tests/qemuxml2xmloutdata/pseries-serial-native.ppc64-latest.xml similarity index 91% rename from tests/qemuxml2xmloutdata/pseries-serial-native.xml rename to tests/qemuxml2xmloutdata/pseries-serial-native.ppc64-latest.xml index 299ae61081..ebe7b5738b 100644 --- a/tests/qemuxml2xmloutdata/pseries-serial-native.xml +++ b/tests/qemuxml2xmloutdata/pseries-serial-native.ppc64-latest.xml @@ -8,6 +8,9 @@ <type arch='ppc64' machine='pseries'>hvm</type> <boot dev='hd'/> </os> + <cpu mode='custom' match='exact' check='none'> + <model fallback='forbid'>POWER9</model> + </cpu> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> diff --git a/tests/qemuxml2xmloutdata/pseries-serial-pci.xml b/tests/qemuxml2xmloutdata/pseries-serial-pci.ppc64-latest.xml similarity index 90% rename from tests/qemuxml2xmloutdata/pseries-serial-pci.xml rename to tests/qemuxml2xmloutdata/pseries-serial-pci.ppc64-latest.xml index e7517008ca..803bc55010 100644 --- a/tests/qemuxml2xmloutdata/pseries-serial-pci.xml +++ b/tests/qemuxml2xmloutdata/pseries-serial-pci.ppc64-latest.xml @@ -8,6 +8,9 @@ <type arch='ppc64' machine='pseries'>hvm</type> <boot dev='hd'/> </os> + <cpu mode='custom' match='exact' check='none'> + <model fallback='forbid'>POWER9</model> + </cpu> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> diff --git a/tests/qemuxml2xmloutdata/pseries-serial-usb.xml b/tests/qemuxml2xmloutdata/pseries-serial-usb.ppc64-latest.xml similarity index 91% rename from tests/qemuxml2xmloutdata/pseries-serial-usb.xml rename to tests/qemuxml2xmloutdata/pseries-serial-usb.ppc64-latest.xml index 4d5989ef4f..3a69273d39 100644 --- a/tests/qemuxml2xmloutdata/pseries-serial-usb.xml +++ b/tests/qemuxml2xmloutdata/pseries-serial-usb.ppc64-latest.xml @@ -8,6 +8,9 @@ <type arch='ppc64' machine='pseries'>hvm</type> <boot dev='hd'/> </os> + <cpu mode='custom' match='exact' check='none'> + <model fallback='forbid'>POWER9</model> + </cpu> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index bef8c4e010..9ac43d3294 100644 --- a/tests/qemuxml2xmltest.c +++ b/tests/qemuxml2xmltest.c @@ -691,77 +691,30 @@ mymain(void) QEMU_CAPS_OBJECT_RNG_EGD); DO_TEST_CAPS_LATEST("virtio-rng-builtin"); - DO_TEST("pseries-nvram", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, - QEMU_CAPS_DEVICE_NVRAM); - DO_TEST("pseries-panic-missing", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE); - DO_TEST("pseries-panic-no-address", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE); - - DO_TEST("pseries-phb-simple", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE); - DO_TEST("pseries-phb-default-missing", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE); - DO_TEST("pseries-phb-numa-node", - QEMU_CAPS_NUMA, - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, - QEMU_CAPS_SPAPR_PCI_HOST_BRIDGE_NUMA_NODE, - QEMU_CAPS_OBJECT_MEMORY_FILE); - - DO_TEST("pseries-many-devices", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, - QEMU_CAPS_VIRTIO_SCSI); - DO_TEST("pseries-many-buses-1", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, - QEMU_CAPS_VIRTIO_SCSI); - DO_TEST("pseries-many-buses-2", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, - QEMU_CAPS_VIRTIO_SCSI); - DO_TEST("pseries-hostdevs-1", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, - QEMU_CAPS_VIRTIO_SCSI, - QEMU_CAPS_DEVICE_VFIO_PCI); - DO_TEST("pseries-hostdevs-2", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, - QEMU_CAPS_VIRTIO_SCSI, - QEMU_CAPS_DEVICE_VFIO_PCI); - DO_TEST("pseries-hostdevs-3", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, - QEMU_CAPS_VIRTIO_SCSI, - QEMU_CAPS_DEVICE_VFIO_PCI); - - DO_TEST("pseries-features", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, - QEMU_CAPS_MACHINE_PSERIES_CAP_HPT_MAX_PAGE_SIZE, - QEMU_CAPS_MACHINE_PSERIES_CAP_HTM, - QEMU_CAPS_MACHINE_PSERIES_CAP_NESTED_HV, - QEMU_CAPS_MACHINE_PSERIES_CAP_CCF_ASSIST, - QEMU_CAPS_MACHINE_PSERIES_CAP_CFPC, - QEMU_CAPS_MACHINE_PSERIES_CAP_SBBC, - QEMU_CAPS_MACHINE_PSERIES_CAP_IBS); - - DO_TEST("pseries-serial-native", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, - QEMU_CAPS_DEVICE_SPAPR_VTY); - DO_TEST("pseries-serial+console-native", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, - QEMU_CAPS_DEVICE_SPAPR_VTY); - DO_TEST("pseries-serial-compat", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, - QEMU_CAPS_DEVICE_SPAPR_VTY); - DO_TEST("pseries-serial-pci", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, - QEMU_CAPS_DEVICE_PCI_SERIAL); - DO_TEST("pseries-serial-usb", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, - QEMU_CAPS_DEVICE_QEMU_XHCI, - QEMU_CAPS_DEVICE_USB_SERIAL); - DO_TEST("pseries-console-native", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, - QEMU_CAPS_DEVICE_SPAPR_VTY); - DO_TEST("pseries-console-virtio", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE); + DO_TEST_CAPS_ARCH_LATEST("pseries-nvram", "ppc64"); + DO_TEST_CAPS_ARCH_LATEST("pseries-panic-missing", "ppc64"); + DO_TEST_CAPS_ARCH_LATEST("pseries-panic-no-address", "ppc64"); + + DO_TEST_CAPS_ARCH_LATEST("pseries-phb-simple", "ppc64"); + DO_TEST_CAPS_ARCH_LATEST("pseries-phb-default-missing", "ppc64"); + DO_TEST_CAPS_ARCH_LATEST("pseries-phb-numa-node", "ppc64"); + + DO_TEST_CAPS_ARCH_LATEST("pseries-many-devices", "ppc64"); + DO_TEST_CAPS_ARCH_LATEST("pseries-many-buses-1", "ppc64"); + DO_TEST_CAPS_ARCH_LATEST("pseries-many-buses-2", "ppc64"); + DO_TEST_CAPS_ARCH_LATEST("pseries-hostdevs-1", "ppc64"); + DO_TEST_CAPS_ARCH_LATEST("pseries-hostdevs-2", "ppc64"); + DO_TEST_CAPS_ARCH_LATEST("pseries-hostdevs-3", "ppc64"); + + DO_TEST_CAPS_ARCH_LATEST("pseries-features", "ppc64"); + + DO_TEST_CAPS_ARCH_LATEST("pseries-serial-native", "ppc64"); + DO_TEST_CAPS_ARCH_LATEST("pseries-serial+console-native", "ppc64"); + DO_TEST_CAPS_ARCH_LATEST("pseries-serial-compat", "ppc64"); + DO_TEST_CAPS_ARCH_LATEST("pseries-serial-pci", "ppc64"); + DO_TEST_CAPS_ARCH_LATEST("pseries-serial-usb", "ppc64"); + DO_TEST_CAPS_ARCH_LATEST("pseries-console-native", "ppc64"); + DO_TEST_CAPS_ARCH_LATEST("pseries-console-virtio", "ppc64"); DO_TEST_NOCAPS("mach-virt-serial-native"); DO_TEST_NOCAPS("mach-virt-serial+console-native"); @@ -1087,10 +1040,9 @@ mymain(void) QEMU_CAPS_Q35_PCI_HOLE64_SIZE); DO_TEST("panic", QEMU_CAPS_DEVICE_PANIC); - DO_TEST("panic-pseries", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE); DO_TEST("panic-double", QEMU_CAPS_DEVICE_PANIC); DO_TEST("panic-no-address", QEMU_CAPS_DEVICE_PANIC); + DO_TEST_CAPS_ARCH_LATEST("panic-pseries", "ppc64"); DO_TEST_NOCAPS("disk-backing-chains"); DO_TEST_NOCAPS("disk-backing-chains-index"); @@ -1333,12 +1285,9 @@ mymain(void) QEMU_CAPS_DEVICE_CIRRUS_VGA); DO_TEST("smartcard-controller", QEMU_CAPS_CCID_EMULATED); - DO_TEST("pseries-cpu-compat-power9", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE); - DO_TEST("pseries-cpu-compat", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE); - DO_TEST("pseries-cpu-exact", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE); + DO_TEST_CAPS_ARCH_LATEST("pseries-cpu-compat-power9", "ppc64"); + DO_TEST_CAPS_ARCH_LATEST("pseries-cpu-compat", "ppc64"); + DO_TEST_CAPS_ARCH_LATEST("pseries-cpu-exact", "ppc64"); DO_TEST("user-aliases", QEMU_CAPS_DEVICE_CIRRUS_VGA, -- 2.32.0

2 2

[PATCH 0/3] qemuxml2argvtest: add ARG_CAPS_HOST_CPU_MODEL
by Daniel Henrique Barboza 24 May '22

24 May '22

Hi, This series attempts to fix a problem I found when converting the "pseries-cpu-compat-power9" to use DO_TEST_CAPS_ARCH_LATEST* macros. More information about the problem per se can be found in patch 02. Patch 03 is where I was able to convert the said test. Patch 01 is a trivial fix I found out when reading code. Daniel Henrique Barboza (3): qemu_capspriv.h: fix identation testutilsqemu: introduce ARG_CAPS_HOST_CPU_MODEL qemuxml2argvtest.c: use CAPS_ARCH_LATEST() with pseries-cpu-compat-power9 src/qemu/qemu_capspriv.h | 4 +- ...eries-cpu-compat-power9.ppc64-latest.args} | 12 +++--- ...series-cpu-compat-power9.ppc64-latest.err} | 0 tests/qemuxml2argvtest.c | 41 ++++++++++++------- tests/testutilsqemu.c | 4 ++ tests/testutilsqemu.h | 18 ++++---- 6 files changed, 49 insertions(+), 30 deletions(-) rename tests/qemuxml2argvdata/{pseries-cpu-compat-power9.args => pseries-cpu-compat-power9.ppc64-latest.args} (60%) rename tests/qemuxml2argvdata/{pseries-cpu-compat-power9.err => pseries-cpu-compat-power9.ppc64-latest.err} (100%) -- 2.32.0

2 7

[PATCH 00/17] nodedev: add optional device address of channel device to css device
by Boris Fiuczynski 23 May '22

23 May '22

While this series started with the intend to add the optional device address of a subchannel device to the nodedev css device the outcome now also includes a small fix in the error reporting of css cap XML parsing as well as a refactoring of generic ccw code into virccw in utils. Boris Fiuczynski (17): nodedev: fix reported error msg in css cap XML parsing util: refactor virDomainDeviceCCWAddress into virccw.h util: refactor virDomainCCWAddressAsString into virccw util: make reuse of ccw device address format constant util: refactor ccw address constants into virccw util: refactor virDomainCCWAddressIncrement into virccw util: refactor virDomainDeviceCCWAddressIsValid into virccw util: refactor virDomainDeviceCCWAddressEqual into virccw conf: adjust method name virDomainDeviceCCWAddressParseXML util: add ccw device address parsing into virccw util: add virCCWDeviceAddressFromString to virccw nodedev: refactor css format from ccw format method nodedev: refactor ccw device address parsing from XML nodedev: refactor css XML parsing from ccw XML parsing schemas: refactor out nodedev ccw address schema nodedev: add optional device address of channel device to css device nodedev: add tests for optional device address to css device po/POTFILES.in | 1 + src/conf/device_conf.c | 28 +-- src/conf/device_conf.h | 23 +-- src/conf/domain_addr.c | 28 +-- src/conf/domain_addr.h | 5 +- src/conf/domain_conf.c | 19 +- src/conf/domain_conf.h | 6 +- src/conf/node_device_conf.c | 171 +++++++++++++----- src/conf/node_device_conf.h | 2 + src/conf/schemas/nodedev.rng | 27 +-- src/libvirt_private.syms | 14 +- src/node_device/node_device_driver.c | 4 +- src/node_device/node_device_udev.c | 16 +- src/qemu/qemu_agent.c | 4 +- src/qemu/qemu_agent.h | 2 +- src/qemu/qemu_command.c | 2 +- src/util/meson.build | 1 + src/util/virccw.c | 103 +++++++++++ src/util/virccw.h | 52 ++++++ .../css_0_0_10000-invalid.xml | 10 + ...s_0_0_fffe_mdev_types_channel_dev_addr.xml | 22 +++ .../css_0_0_ffff_channel_dev_addr-invalid.xml | 15 ++ .../css_0_0_ffff_channel_dev_addr.xml | 15 ++ ...s_0_0_fffe_mdev_types_channel_dev_addr.xml | 1 + .../css_0_0_ffff_channel_dev_addr.xml | 1 + tests/nodedevxml2xmltest.c | 2 + 26 files changed, 418 insertions(+), 156 deletions(-) create mode 100644 src/util/virccw.c create mode 100644 src/util/virccw.h create mode 100644 tests/nodedevschemadata/css_0_0_10000-invalid.xml create mode 100644 tests/nodedevschemadata/css_0_0_fffe_mdev_types_channel_dev_addr.xml create mode 100644 tests/nodedevschemadata/css_0_0_ffff_channel_dev_addr-invalid.xml create mode 100644 tests/nodedevschemadata/css_0_0_ffff_channel_dev_addr.xml create mode 120000 tests/nodedevxml2xmlout/css_0_0_fffe_mdev_types_channel_dev_addr.xml create mode 120000 tests/nodedevxml2xmlout/css_0_0_ffff_channel_dev_addr.xml -- 2.33.1

2 21

[libvirt PATCH] qemu: Do not return NULL when qemuMigrationSrcBegin succeeds
by Jiri Denemark 23 May '22

23 May '22

My recent commit v8.3.0-201-gc500955e95 tried to fix a regression which would cause the function to return success even if virCloseCallbacksSet failed. But due to a strange code flow in the function introduced an opposite regression. The function would return NULL on success when called without VIR_MIGRATE_CHANGE_PROTECTION flag. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_migration.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 38596fa4de..6cc68a567a 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -2534,23 +2534,23 @@ qemuMigrationSrcBegin(virConnectPtr conn, if (virCloseCallbacksSet(driver->closeCallbacks, vm, conn, qemuMigrationSrcCleanup) < 0) goto endjob; - qemuMigrationJobContinue(vm); - } else { - goto endjob; } ret = g_steal_pointer(&xml); + endjob: + if (flags & VIR_MIGRATE_CHANGE_PROTECTION) { + if (ret) + qemuMigrationJobContinue(vm); + else + qemuMigrationJobFinish(vm); + } else { + qemuDomainObjEndJob(vm); + } + cleanup: virDomainObjEndAPI(&vm); return ret; - - endjob: - if (flags & VIR_MIGRATE_CHANGE_PROTECTION) - qemuMigrationJobFinish(vm); - else - qemuDomainObjEndJob(vm); - goto cleanup; } -- 2.35.1

2 1

[PATCH 0/2] Fix missing 'manual' mode for default snapshot disk definition and clean up docs
by Peter Krempa 23 May '22

23 May '22

Peter Krempa (2): docs: domain: Remove extraneous quotes schemas: Allow 'manual' snapshot mode in domain definition docs/formatdomain.rst | 20 ++++++++++---------- src/conf/schemas/domaincommon.rng | 1 + 2 files changed, 11 insertions(+), 10 deletions(-) -- 2.35.3

2 3

[libvirt PATCH v2 0/7] po: Various fixes and cleanups
by Andrea Bolognani 23 May '22

23 May '22

Changes from [v1] * instead of checking that the potfile doesn't contain unwanted comments at syntax-check time, prevent them from being added by passing all xgettext options explicitly ourselves. [v1] https://listman.redhat.com/archives/libvir-list/2022-May/231526.html Andrea Bolognani (7): po: Drop unwanted comments from potfile po: Stop using 'glib' preset for i18n.gettext() po: Drop prefixes from POTFILES.in po: Don't generate POTFILES syntax-check: Don't exclude src/false.c from sc_po_check po: Sort LINGUAS syntax-check: Introduce sc_linguas_sorting build-aux/syntax-check.mk | 21 ++- po/LINGUAS | 8 +- po/POTFILES | 384 ++++++++++++++++++++++++++++++++++++++ po/POTFILES.in | 384 -------------------------------------- po/libvirt.pot | 216 --------------------- po/meson.build | 17 +- 6 files changed, 406 insertions(+), 624 deletions(-) create mode 100644 po/POTFILES delete mode 100644 po/POTFILES.in -- 2.35.3

2 8

[PATCH v2] remote_daemon: Don't run virStateCleanup() if virStateReload() is still running
by Michal Privoznik 23 May '22

23 May '22

When a SIGHUP is received a thread is spawned that runs virStateReload(). However, if SIGINT is received while the former thread is still running then we may get into problematic situation: the cleanup code in main() sees drivers initialized and thus calls virStateCleanup(). So now we have two threads, one running virStateReload() the other virStateCleanup(). In this situation it's very likely that a race condition occurs and either of threads causes SIGSEGV. To fix this, unmark drivers as initialized in the virStateReload() thread for the time the function runs. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2075837 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- v2 of: https://listman.redhat.com/archives/libvir-list/2022-April/230415.html diff to v1: - reworked how int is set (instead of inc/dec I'm using set(0)/set(1)) so that reload can be attempted again and again if previous attempt failed. src/remote/remote_daemon.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/src/remote/remote_daemon.c b/src/remote/remote_daemon.c index 26469e0d9f..b8ecc51758 100644 --- a/src/remote/remote_daemon.c +++ b/src/remote/remote_daemon.c @@ -77,7 +77,7 @@ virNetSASLContext *saslCtxt = NULL; virNetServerProgram *remoteProgram = NULL; virNetServerProgram *qemuProgram = NULL; -volatile bool driversInitialized = false; +volatile gint driversInitialized = 0; static void daemonErrorHandler(void *opaque G_GNUC_UNUSED, virErrorPtr err G_GNUC_UNUSED) @@ -453,8 +453,13 @@ static void daemonReloadHandlerThread(void *opaque G_GNUC_UNUSED) VIR_INFO("Reloading configuration on SIGHUP"); virHookCall(VIR_HOOK_DRIVER_DAEMON, "-", VIR_HOOK_DAEMON_OP_RELOAD, SIGHUP, "SIGHUP", NULL, NULL); - if (virStateReload() < 0) + + if (virStateReload() < 0) { VIR_WARN("Error while reloading drivers"); + } + + /* Drivers are initialized again. */ + g_atomic_int_set(&driversInitialized, 1); } static void daemonReloadHandler(virNetDaemon *dmn G_GNUC_UNUSED, @@ -463,7 +468,7 @@ static void daemonReloadHandler(virNetDaemon *dmn G_GNUC_UNUSED, { virThread thr; - if (!driversInitialized) { + if (!g_atomic_int_compare_and_exchange(&driversInitialized, 1, 0)) { VIR_WARN("Drivers are not initialized, reload ignored"); return; } @@ -474,6 +479,10 @@ static void daemonReloadHandler(virNetDaemon *dmn G_GNUC_UNUSED, * Not much we can do on error here except log it. */ VIR_ERROR(_("Failed to create thread to handle daemon restart")); + + /* Drivers were initialized at the beginning, otherwise we wouldn't + * even get here. */ + g_atomic_int_set(&driversInitialized, 1); } } @@ -607,7 +616,7 @@ static void daemonRunStateInit(void *opaque) goto cleanup; } - driversInitialized = true; + g_atomic_int_set(&driversInitialized, 1); virNetDaemonSetShutdownCallbacks(dmn, virStateShutdownPrepare, @@ -1212,10 +1221,9 @@ int main(int argc, char **argv) { cleanup: virNetlinkEventServiceStopAll(); - if (driversInitialized) { + if (g_atomic_int_compare_and_exchange(&driversInitialized, 1, 0)) { /* NB: Possible issue with timing window between driversInitialized * setting if virNetlinkEventServerStart fails */ - driversInitialized = false; virStateCleanup(); } -- 2.35.1

2 1

[libvirt PATCH] qemu: Fix error propagation in qemuMigrationBegin
by Jiri Denemark 23 May '22

23 May '22

Commit v8.3.0-152-g49ef0f95c6 removed explicit VIR_FREE from qemuMigrationBegin, effectively reverting v1.2.14-57-g77ddd0bba2 The xml variable was used to hold the return value and thus had to be unset when an error happened after xml was already non-NULL. Such code may be quite confusing though and we usually avoid it by not storing anything to a return variable until everything succeeded. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_migration.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 438f2bc999..38596fa4de 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -2487,6 +2487,7 @@ qemuMigrationSrcBegin(virConnectPtr conn, virQEMUDriver *driver = conn->privateData; g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(driver); g_autofree char *xml = NULL; + char *ret = NULL; virDomainAsyncJob asyncJob; if (cfg->migrateTLSForce && @@ -2538,9 +2539,11 @@ qemuMigrationSrcBegin(virConnectPtr conn, goto endjob; } + ret = g_steal_pointer(&xml); + cleanup: virDomainObjEndAPI(&vm); - return g_steal_pointer(&xml); + return ret; endjob: if (flags & VIR_MIGRATE_CHANGE_PROTECTION) -- 2.35.1

2 1

[libvirt PATCH] apparmor: Enable locking AAVMF firmware
by Andrea Bolognani 23 May '22

23 May '22

We already allow this for OVMF. Closes: https://gitlab.com/libvirt/libvirt/-/issues/312 Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- src/security/apparmor/libvirt-qemu | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/security/apparmor/libvirt-qemu b/src/security/apparmor/libvirt-qemu index c29168da27..02ee273e7e 100644 --- a/src/security/apparmor/libvirt-qemu +++ b/src/security/apparmor/libvirt-qemu @@ -78,7 +78,7 @@ /var/lib/dbus/machine-id r, # access to firmware's etc - /usr/share/AAVMF/** r, + /usr/share/AAVMF/** rk, /usr/share/bochs/** r, /usr/share/edk2-ovmf/** rk, /usr/share/kvm/** r, -- 2.35.3

2 1

[PATCH] Allow VM to read sysfs PCI config, revision files
by Max Goodhart 20 May '22

20 May '22

From: Max Goodhart <gitlab(a)chromakode.com> This fixes a blank screen when viewing a VM with virtio graphics and gl-accelerated Spice display on Ubuntu 22.04 / libvirt 8.0.0 / qemu 6.2. Without these AppArmor permissions, the libvirt error log contains repetitions of: qemu_spice_gl_scanout_texture: failed to get fd for texture This appears to be similar to this GNOME Boxes issue: https://gitlab.gnome.org/GNOME/gnome-boxes/-/issues/586 Signed-off-by: Max Goodhart <c(a)chromakode.com> --- src/security/virt-aa-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 1f1cce8b3d..b314d2a059 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -1316,7 +1316,7 @@ get_files(vahControl * ctl) virBufferAddLit(&buf, " \"/dev/nvidiactl\" rw,\n"); virBufferAddLit(&buf, " # Probe DRI device attributes\n"); virBufferAddLit(&buf, " \"/dev/dri/\" r,\n"); - virBufferAddLit(&buf, " \"/sys/devices/**/{uevent,vendor,device,subsystem_vendor,subsystem_device}\" r,\n"); + virBufferAddLit(&buf, " \"/sys/devices/**/{uevent,vendor,device,subsystem_vendor,subsystem_device,config,revision}\" r,\n"); virBufferAddLit(&buf, " # dri libs will trigger that, but t is not requited and DAC would deny it anyway\n"); virBufferAddLit(&buf, " deny \"/var/lib/libvirt/.cache/\" w,\n"); } -- 2.34.1

3 5

[libvirt PATCH 00/80] Add support for post-copy recovery
by Jiri Denemark 19 May '22

19 May '22

This series implements a new VIR_MIGRATE_POSTCOPY_RESUME flag (virsh migrate --resume) for recovering from a failed post-copy migration. You can also fetch the series from my gitlab fork: git fetch https://gitlab.com/jirkade/libvirt.git post-copy-recovery Jiri Denemark (80): qemu: Add debug messages to job recovery code qemumonitorjsontest: Test more migration capabilities qemu: Return state from qemuMonitorGetMigrationCapabilities qemu: Enable migration events only when disabled Introduce VIR_DOMAIN_RUNNING_POSTCOPY_FAILED qemu: Keep domain running on dst on failed post-copy migration qemu: Explicitly emit events on post-copy failure qemu: Make qemuDomainCleanupAdd return void conf: Introduce virDomainObjIsFailedPostcopy helper conf: Introduce virDomainObjIsPostcopy helper qemu: Introduce qemuProcessCleanupMigrationJob qemu: Rename qemuDomainObjRestoreJob as qemuDomainObjPreserveJob qemu: Add qemuDomainObjRestoreAsyncJob qemu: Keep migration job active after failed post-copy qemu: Abort failed post-copy when we haven't called Finish yet qemu: Restore failed migration job on reconnect qemu: Restore async job start timestamp on reconnect qemu: Drop forward declarations in migration code qemu: Don't wait for migration job when migration is running qemu: Use switch in qemuDomainGetJobInfoMigrationStats qemu: Fetch paused migration stats qemu: Handle 'postcopy-paused' migration state qemu: Add support for postcopy-recover QEMU migration state qemu: Create domain object at the end of qemuMigrationDstFinish qemu: Move success-only code out of endjob in qemuMigrationDstFinish qemu: Separate success and failure path in qemuMigrationDstFinish qemu: Rename "endjob" label in qemuMigrationDstFinish qemu: Generate migration cookie in Finish phase earlier qemu: Make final part of migration Finish phase reusable qemu: Drop obsolete comment in qemuMigrationDstFinish qemu: Preserve error in qemuMigrationDstFinish qemu: Introduce qemuMigrationDstFinishFresh qemu: Introduce qemuMigrationDstFinishOffline qemu: Separate cookie parsing for qemuMigrationDstFinishOffline qemu: Introduce qemuMigrationDstFinishActive qemu: Handle migration job in qemuMigrationDstFinish qemu: Make final part of migration Confirm phase reusable qemu: Make sure migrationPort is released even in callbacks qemu: Pass qemuDomainJobObj to qemuMigrationDstComplete qemu: Finish completed unattended migration qemu: Ignore missing memory statistics in query-migrate qemu: Improve post-copy migration handling on reconnect qemu: Check flags incompatible with offline migration earlier qemu: Introduce qemuMigrationSrcBeginXML helper qemu: Add new migration phases for post-copy recovery qemu: Separate protocol checks from qemuMigrationJobSetPhase qemu: Make qemuMigrationCheckPhase failure fatal qemu: Refactor qemuDomainObjSetJobPhase qemu: Do not set job owner in qemuMigrationJobSetPhase qemu: Use QEMU_MIGRATION_PHASE_POSTCOPY_FAILED Introduce VIR_MIGRATE_POSTCOPY_RESUME flag virsh: Add --postcopy-resume option for migrate command qemu: Don't set VIR_MIGRATE_PAUSED for post-copy resume qemu: Implement VIR_MIGRATE_POSTCOPY_RESUME for Begin phase qmeu: Refactor qemuMigrationSrcPerformPhase qemu: Separate starting migration from qemuMigrationSrcRun qemu: Add support for 'resume' parameter of migrate QMP command qemu: Implement VIR_MIGRATE_POSTCOPY_RESUME for Perform phase qemu: Implement VIR_MIGRATE_POSTCOPY_RESUME for Confirm phase qemu: Introduce qemuMigrationDstPrepareFresh qemu: Refactor qemuMigrationDstPrepareFresh qemu: Simplify cleanup in qemuMigrationDstPrepareFresh qemu: Add support for migrate-recover QMP command qemu: Rename qemuMigrationSrcCleanup qemu: Refactor qemuMigrationAnyConnectionClosed qemu: Handle incoming migration in qemuMigrationAnyConnectionClosed qemu: Start a migration phase in qemuMigrationAnyConnectionClosed qemu: Implement VIR_MIGRATE_POSTCOPY_RESUME for Prepare phase qemu: Implement VIR_MIGRATE_POSTCOPY_RESUME for Finish phase qemu: Create completed jobData in qemuMigrationSrcComplete qemu: Register qemuProcessCleanupMigrationJob after Begin phase qemu: Call qemuDomainCleanupAdd from qemuMigrationJobContinue qemu: Implement VIR_MIGRATE_POSTCOPY_RESUME for peer-to-peer migration qemu: Enable support for VIR_MIGRATE_POSTCOPY_RESUME Add virDomainAbortJobFlags public API qemu: Implement virDomainAbortJobFlags Add VIR_DOMAIN_ABORT_JOB_POSTCOPY flag for virDomainAbortJobFlags qemu: Implement VIR_DOMAIN_ABORT_JOB_POSTCOPY flag virsh: Add --postcopy option for domjobabort command NEWS: Add support for post-copy recovery NEWS.rst | 5 + docs/manpages/virsh.rst | 17 +- examples/c/misc/event-test.c | 3 + include/libvirt/libvirt-domain.h | 26 + src/conf/domain_conf.c | 33 + src/conf/domain_conf.h | 8 + src/driver-hypervisor.h | 5 + src/hypervisor/domain_job.c | 1 + src/hypervisor/domain_job.h | 1 + src/libvirt-domain.c | 72 +- src/libvirt_private.syms | 2 + src/libvirt_public.syms | 1 + src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_domain.c | 9 +- src/qemu/qemu_domain.h | 5 +- src/qemu/qemu_domainjob.c | 103 +- src/qemu/qemu_domainjob.h | 16 +- src/qemu/qemu_driver.c | 83 +- src/qemu/qemu_migration.c | 2383 +++++++++++------ src/qemu/qemu_migration.h | 37 +- src/qemu/qemu_migration_params.c | 19 +- src/qemu/qemu_monitor.c | 27 +- src/qemu/qemu_monitor.h | 13 +- src/qemu/qemu_monitor_json.c | 151 +- src/qemu/qemu_monitor_json.h | 10 +- src/qemu/qemu_process.c | 355 ++- src/qemu/qemu_process.h | 3 + src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 14 +- src/remote_protocol-structs | 5 + tests/qemumonitorjsontest.c | 42 +- .../migration-in-params-in.xml | 2 +- .../migration-out-nbd-bitmaps-in.xml | 2 +- .../migration-out-nbd-out.xml | 2 +- .../migration-out-nbd-tls-out.xml | 2 +- .../migration-out-params-in.xml | 2 +- tools/virsh-domain-event.c | 3 +- tools/virsh-domain-monitor.c | 1 + tools/virsh-domain.c | 24 +- 39 files changed, 2556 insertions(+), 934 deletions(-) -- 2.35.1

5 195

[PATCH] remote_daemon: Don't run virStateCleanup() if virStateReload() is still running
by Michal Privoznik 19 May '22

19 May '22

When a SIGHUP is received a thread is spawned that runs virStateReload(). However, if SIGINT is received while the former thread is still running then we may get into problematic situation: the cleanup code in main() sees drivers initialized and thus calls virStateCleanup(). So now we have two threads, one running virStateReload() the other virStateCleanup(). In this situation it's very likely that a race condition occurs and either of threads causes SIGSEGV. To fix this, unmark drivers as initialized in the virStateReload() thread for the time the function runs. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2075837 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/remote/remote_daemon.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/remote/remote_daemon.c b/src/remote/remote_daemon.c index 26469e0d9f..37d27f93f4 100644 --- a/src/remote/remote_daemon.c +++ b/src/remote/remote_daemon.c @@ -77,7 +77,7 @@ virNetSASLContext *saslCtxt = NULL; virNetServerProgram *remoteProgram = NULL; virNetServerProgram *qemuProgram = NULL; -volatile bool driversInitialized = false; +volatile gint driversInitialized = 0; static void daemonErrorHandler(void *opaque G_GNUC_UNUSED, virErrorPtr err G_GNUC_UNUSED) @@ -453,8 +453,13 @@ static void daemonReloadHandlerThread(void *opaque G_GNUC_UNUSED) VIR_INFO("Reloading configuration on SIGHUP"); virHookCall(VIR_HOOK_DRIVER_DAEMON, "-", VIR_HOOK_DAEMON_OP_RELOAD, SIGHUP, "SIGHUP", NULL, NULL); - if (virStateReload() < 0) + + g_atomic_int_set(&driversInitialized, 0); + if (virStateReload() < 0) { VIR_WARN("Error while reloading drivers"); + } else { + g_atomic_int_inc(&driversInitialized); + } } static void daemonReloadHandler(virNetDaemon *dmn G_GNUC_UNUSED, @@ -463,7 +468,7 @@ static void daemonReloadHandler(virNetDaemon *dmn G_GNUC_UNUSED, { virThread thr; - if (!driversInitialized) { + if (g_atomic_int_get(&driversInitialized) == 0) { VIR_WARN("Drivers are not initialized, reload ignored"); return; } @@ -607,7 +612,7 @@ static void daemonRunStateInit(void *opaque) goto cleanup; } - driversInitialized = true; + g_atomic_int_inc(&driversInitialized); virNetDaemonSetShutdownCallbacks(dmn, virStateShutdownPrepare, @@ -1212,10 +1217,10 @@ int main(int argc, char **argv) { cleanup: virNetlinkEventServiceStopAll(); - if (driversInitialized) { + if (g_atomic_int_get(&driversInitialized) != 0) { /* NB: Possible issue with timing window between driversInitialized * setting if virNetlinkEventServerStart fails */ - driversInitialized = false; + g_atomic_int_set(&driversInitialized, 0); virStateCleanup(); } -- 2.35.1

3 4

[libvirt PATCH 0/5] Description Here
by Ján Tomko 19 May '22

19 May '22

Ján Tomko (5): Do not check if unsigned vars are less than zero src: QemuMonitorCommandWithFiles: report error when fd passing is unsupported apparmor: report error when removing profile failed vbox: SnapshotConfAllChildren: reduce scope of tempSize storagefile: set size field of ploop to 8 src/esx/esx_stream.c | 2 +- src/libvirt-qemu.c | 4 ++-- src/security/virt-aa-helper.c | 2 +- src/storage_file/storage_file_probe.c | 2 +- src/vbox/vbox_snapshot_conf.c | 3 +-- 5 files changed, 6 insertions(+), 7 deletions(-) -- 2.34.1

3 7

[PATCH] apparmor: Add support for dbus chardev
by Martin Kletzander 19 May '22

19 May '22

Commit 7648e40da50e added support for dbus chardev but forgot to handle it in AppArmor code. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- Pushed under the build-breaker rule. src/security/security_apparmor.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/security/security_apparmor.c b/src/security/security_apparmor.c index 55c019394050..008384dee8c2 100644 --- a/src/security/security_apparmor.c +++ b/src/security/security_apparmor.c @@ -1022,6 +1022,7 @@ AppArmorSetChardevLabel(virSecurityManager *mgr, case VIR_DOMAIN_CHR_TYPE_SPICEVMC: case VIR_DOMAIN_CHR_TYPE_NMDM: case VIR_DOMAIN_CHR_TYPE_QEMU_VDAGENT: + case VIR_DOMAIN_CHR_TYPE_DBUS: case VIR_DOMAIN_CHR_TYPE_LAST: ret = 0; break; @@ -1085,6 +1086,7 @@ AppArmorSetNetdevLabel(virSecurityManager *mgr, case VIR_DOMAIN_CHR_TYPE_SPICEVMC: case VIR_DOMAIN_CHR_TYPE_NMDM: case VIR_DOMAIN_CHR_TYPE_QEMU_VDAGENT: + case VIR_DOMAIN_CHR_TYPE_DBUS: case VIR_DOMAIN_CHR_TYPE_LAST: ret = 0; break; -- 2.35.1

1 0

[PATCH v2 0/3] ui: Remove deprecated sdl parameters and switch to QAPI parser
by Thomas Huth 19 May '22

19 May '22

The "-display sdl" option still uses a hand-crafted parser for its parameters since some of them used underscores which is forbidden in QAPI. Now that they've been deprecated and the deprecation period is over, we can remove the problematic parameters and switch to use the QAPI parser instead. While we're at it, also remove the deprecated "-sdl" and "-curses" options. v2: - Rebase to current master branch to resolve conflicts in docs/about/*.rst - Use an enum for the grab-mod parameter instead of a unconstrained string Thomas Huth (3): ui: Remove deprecated parameters of the "-display sdl" option ui: Switch "-display sdl" to use the QAPI parser ui: Remove deprecated options "-sdl" and "-curses" docs/about/deprecated.rst | 26 ------- docs/about/removed-features.rst | 27 +++++++ qapi/ui.json | 27 ++++++- include/sysemu/sysemu.h | 2 - softmmu/globals.c | 2 - softmmu/vl.c | 128 +------------------------------- ui/sdl2.c | 10 +++ qemu-options.hx | 56 +------------- 8 files changed, 68 insertions(+), 210 deletions(-) -- 2.27.0

5 18

[libvirt PATCH v4 00/11] Add QEMU "-display dbus" support
by marcandre.lureau＠redhat.com 19 May '22

19 May '22

From: Marc-André Lureau <marcandre.lureau(a)redhat.com> Hi, This series implements supports for the QEMU "-display dbus" support, available since 7.0. By default, libvirt will start a private VM bus (sharing and reusing the existing "vmstate" VM bus & code). The feature set should cover the needs to replace Spice as local client of choice, including 3daccel/dmabuf, audio, clipboard sharing, usb redirection, and arbitrary chardev/channels (for serial etc). The test Gtk4 client is also in progress, currently in development at https://gitlab.com/marcandre.lureau/qemu-display/. virt-viewer & boxes will need a port to Gtk4 to make use of the shared widget. thanks v4: - rebased, dropped some patches, updated versions in docs, code adjustments etc - dropped clipboard option, as standalone qemu-vdagent support landed v3: after QEMU 7.0 dev cycle opening and merge - rebased - add 7.0 x86-64 capabilities (instead of tweaking 6.2) - fix version annotations Marc-André Lureau (11): qemu: add -display dbus capability check conf: add <graphics type='dbus'> qemu: start the D-Bus daemon for the display qemu: add -display dbus support virsh: report the D-Bus bus URI for domdisplay conf: add <audio type='dbus'> support qemu: add audio type 'dbus' conf: add <serial type='dbus'> qemu: add -chardev dbus support qemu: add usbredir type 'dbus' docs: document <graphics> type dbus NEWS.rst | 5 + docs/formatdomain.rst | 43 +++++- src/bhyve/bhyve_command.c | 1 + src/conf/domain_conf.c | 129 +++++++++++++++++- src/conf/domain_conf.h | 14 ++ src/conf/domain_validate.c | 41 ++++-- src/conf/schemas/basictypes.rng | 7 + src/conf/schemas/domaincommon.rng | 63 +++++++++ src/libxl/libxl_conf.c | 1 + src/libxl/libxl_domain.c | 1 + src/libxl/libxl_driver.c | 1 + src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 65 ++++++++- src/qemu/qemu_domain.c | 1 + src/qemu/qemu_driver.c | 10 +- src/qemu/qemu_extdevice.c | 13 ++ src/qemu/qemu_hotplug.c | 1 + src/qemu/qemu_monitor_json.c | 10 ++ src/qemu/qemu_process.c | 41 +++++- src/qemu/qemu_validate.c | 33 +++++ src/security/security_dac.c | 2 + src/vmx/vmx.c | 1 + .../domaincapsdata/qemu_7.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_7.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_7.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_7.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_7.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_7.1.0.x86_64.xml | 1 + .../caps_7.0.0.x86_64.xml | 1 + .../caps_7.1.0.x86_64.xml | 1 + .../graphics-dbus-address.args | 30 ++++ .../graphics-dbus-address.xml | 35 +++++ .../qemuxml2argvdata/graphics-dbus-audio.args | 33 +++++ .../qemuxml2argvdata/graphics-dbus-audio.xml | 45 ++++++ .../graphics-dbus-chardev.args | 32 +++++ .../graphics-dbus-chardev.xml | 43 ++++++ tests/qemuxml2argvdata/graphics-dbus-p2p.args | 30 ++++ tests/qemuxml2argvdata/graphics-dbus-p2p.xml | 33 +++++ .../graphics-dbus-usbredir.args | 34 +++++ .../graphics-dbus-usbredir.xml | 30 ++++ tests/qemuxml2argvdata/graphics-dbus.args | 30 ++++ tests/qemuxml2argvdata/graphics-dbus.xml | 33 +++++ tests/qemuxml2argvtest.c | 17 +++ .../graphics-dbus-address.xml | 1 + .../graphics-dbus-audio.xml | 1 + .../graphics-dbus-chardev.xml | 1 + .../qemuxml2xmloutdata/graphics-dbus-p2p.xml | 1 + tests/qemuxml2xmloutdata/graphics-dbus.xml | 1 + tests/qemuxml2xmltest.c | 17 +++ tests/testutilsqemu.c | 1 + tools/virsh-domain.c | 24 +++- 52 files changed, 948 insertions(+), 20 deletions(-) create mode 100644 tests/qemuxml2argvdata/graphics-dbus-address.args create mode 100644 tests/qemuxml2argvdata/graphics-dbus-address.xml create mode 100644 tests/qemuxml2argvdata/graphics-dbus-audio.args create mode 100644 tests/qemuxml2argvdata/graphics-dbus-audio.xml create mode 100644 tests/qemuxml2argvdata/graphics-dbus-chardev.args create mode 100644 tests/qemuxml2argvdata/graphics-dbus-chardev.xml create mode 100644 tests/qemuxml2argvdata/graphics-dbus-p2p.args create mode 100644 tests/qemuxml2argvdata/graphics-dbus-p2p.xml create mode 100644 tests/qemuxml2argvdata/graphics-dbus-usbredir.args create mode 100644 tests/qemuxml2argvdata/graphics-dbus-usbredir.xml create mode 100644 tests/qemuxml2argvdata/graphics-dbus.args create mode 100644 tests/qemuxml2argvdata/graphics-dbus.xml create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus-address.xml create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus-audio.xml create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus-chardev.xml create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus-p2p.xml create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus.xml -- 2.36.1

2 12

Plans for the next release
by Jiri Denemark 19 May '22

19 May '22

We are getting close to the next release of libvirt. To aim for the release on June 01 I suggest entering the freeze on Wednesday May 25 in the evening and tagging RC2 on Monday May 30. I hope this works for everyone. Jirka

1 0

[PATCH 0/5] Some docs updates
by Han Han 19 May '22

19 May '22

Han Han (5): docs: apps: Add desktop app gnome-boxes docs: formatdomain: Add the introduced versions of net rss attrs news: Add news for rss and rss_hash_report attributes docs: drivers: Mention KVM/HVF in the link of qemu driver docs: drvqemu: Fix the syntax typo of Hypervisor.framework link NEWS.rst | 5 +++++ docs/apps.rst | 3 +++ docs/drivers.rst | 2 +- docs/drvqemu.rst | 2 +- docs/formatdomain.rst | 3 ++- 5 files changed, 12 insertions(+), 3 deletions(-) -- 2.35.1

2 7

[PATCH] remoteOpenConn: Pass correct variable to virConnectSetIdentity()
by Michal Privoznik 19 May '22

19 May '22

The remoteOpenConn() function was refactored recently. As a part of that new variable @newconn was introduced which holds virConnect object as it's being gradually constructed throughout the function. At the very end, when everything succeeded the variable is stolen into passed @conn. However, there was one line missed in the refactor which still access the @conn instead of @newconn leading to a NULL dereference. Fixes: f7c422993e4c7ca3e58b1d0d69f4772851af399f Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/remote/remote_daemon_dispatch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon_dispatch.c index c1f85925a3..0fde4233a5 100644 --- a/src/remote/remote_daemon_dispatch.c +++ b/src/remote/remote_daemon_dispatch.c @@ -1829,7 +1829,7 @@ remoteOpenConn(const char *uri, VIR_DEBUG("Opened driver %p", newconn); if (preserveIdentity) { - if (virConnectSetIdentity(*conn, identparams->par, identparams->npar, 0) < 0) + if (virConnectSetIdentity(newconn, identparams->par, identparams->npar, 0) < 0) return -1; VIR_DEBUG("Forwarded current identity to secondary driver"); -- 2.35.1

2 1

[PATCH 00/16] New update from 6.9 to 7.8
by Han Han 19 May '22

19 May '22

Han Han (16): news: make SEV attrs 'cbitpos' & 'reducedPhysBits' optional news: support device stats collection for SR-IOV VF hostdev news: cpu_map: Add EPYC-Rome cpu model news: cpu: Support for XML validation in cpu comparison news: logging: allow max_len=0 to disable log rollover news: qemu: Set noqueue qdisc for TAP devices news: qemu: Introduce virtio free page reporting feature news: qemu: virtiofs can be used without NUMA nodes news: qemu: Add 'fmode' and 'dmode' options for 9pfs news: Introduce "migrate_tls_force" to qemu.conf news: qemu: support kvm-poll-control performance hint news: cpu_map: Add Snowridge cpu model news: qemu: Add support for NFS disk protocol news: Support vhostuser in virsh attach-interface since v7.7.0 news: Add queue_size option to virtio disk news: Validation flags for creating net, nwfilter-binding, net port NEWS.rst | 89 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 89 insertions(+) -- 2.36.0

2 18

[libvirt PATCH v3 0/6] Add support for 'blob' to virtio video device
by Jonathon Jongsma 18 May '22

18 May '22

Add support to libvirt for the 'blob' option for virtio video devices in qemu. Also do a little preparatory refactoring of the video device xml parsing code. I sent this series out a couple months ago but didn't get any review. Sending out again after rebasing to current master branch. changes in v3: - rebased to latest master Changes in v2: - Added some basic documentation - add a qemu capability - Make sure that the /dev/udmabuf device is accessible to qemu (cgroups, etc) Jonathon Jongsma (6): conf: Refactor video model parsing conf: switch to virXMLProp* functions conf: use enum variable for video type conf: add support for 'blob' in virtio video device qemu: Add capability for virtio-gpu.blob qemu: Implement 'blob' support for virtio gpu docs/formatdomain.rst | 6 + src/conf/domain_conf.c | 133 +++++++++--------- src/conf/domain_conf.h | 3 +- src/conf/domain_validate.c | 13 +- src/conf/schemas/domaincommon.rng | 5 + src/libxl/libxl_conf.c | 10 ++ src/libxl/libxl_domain.c | 11 ++ src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_cgroup.c | 22 ++- src/qemu/qemu_command.c | 3 + src/qemu/qemu_domain.h | 1 + src/qemu/qemu_monitor_json.c | 16 ++- src/qemu/qemu_namespace.c | 22 +++ src/qemu/qemu_process.c | 7 + src/qemu/qemu_validate.c | 9 ++ .../caps_6.1.0.x86_64.xml | 1 + .../caps_6.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 1 + .../caps_6.2.0.x86_64.xml | 1 + .../caps_7.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml | 1 + .../caps_7.0.0.x86_64.xml | 1 + .../caps_7.1.0.x86_64.xml | 1 + .../video-virtio-blob-absent.args | 34 +++++ .../video-virtio-blob-absent.xml | 33 +++++ .../video-virtio-blob-off.args | 34 +++++ .../video-virtio-blob-off.xml | 33 +++++ .../video-virtio-blob-on.args | 34 +++++ .../qemuxml2argvdata/video-virtio-blob-on.xml | 33 +++++ .../video-virtio-vga-blob-on.args | 34 +++++ .../video-virtio-vga-blob-on.xml | 33 +++++ tests/qemuxml2argvtest.c | 12 ++ .../video-virtio-blob-absent.xml | 41 ++++++ .../video-virtio-blob-off.xml | 41 ++++++ .../video-virtio-blob-on.xml | 41 ++++++ .../video-virtio-vga-blob-on.xml | 41 ++++++ tests/qemuxml2xmltest.c | 12 ++ 38 files changed, 647 insertions(+), 81 deletions(-) create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-absent.args create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-absent.xml create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-off.args create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-off.xml create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-on.args create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-on.xml create mode 100644 tests/qemuxml2argvdata/video-virtio-vga-blob-on.args create mode 100644 tests/qemuxml2argvdata/video-virtio-vga-blob-on.xml create mode 100644 tests/qemuxml2xmloutdata/video-virtio-blob-absent.xml create mode 100644 tests/qemuxml2xmloutdata/video-virtio-blob-off.xml create mode 100644 tests/qemuxml2xmloutdata/video-virtio-blob-on.xml create mode 100644 tests/qemuxml2xmloutdata/video-virtio-vga-blob-on.xml -- 2.35.1

3 12

CFP Reminder: KVM Forum 2022
by Peter Maydell 18 May '22

18 May '22

================================================================ KVM Forum 2022 September 12-14, 2022 Dublin, Ireland & Virtual All submissions must be received before *** Friday June 3rd, 2022 at 23:59 PDT *** ================================================================ KVM Forum is an annual event that presents a rare opportunity for developers and users to discuss the state of Linux virtualization technology and plan for the challenges ahead. This highly technical conference unites the developers who drive KVM development and the users who depend on KVM as part of their offerings, or to power their data centers and clouds. Sessions include updates on the state of the KVM virtualization stack, planning for the future, and many opportunities for attendees to collaborate. Over the years since its inclusion in the mainline kernel, KVM has become a critical part of the FOSS cloud infrastructure. Come join us in continuing to improve the KVM ecosystem. This year's event is in Dublin, Ireland, but it is a combined physical+virtual conference: both speaking and attending can be virtual if you prefer. For more details, registration, travel and health and safety information, visit: https://events.linuxfoundation.org/kvm-forum/ For more information, some suggested topics, and to submit proposals, please see: https://events.linuxfoundation.org/kvm-forum/program/cfp/ We encourage you to submit and reach out to us should you have any questions. The program committee may be contacted as a group via email: kvm-forum-2022-pc(a)redhat.com. Apologies from the Program Committee for not posting an announcement of the CFP to these lists sooner.

1 0

[PATCH 0/4] virIdentity: Don't leak params in virGetConnectGeneric and refactor
by Peter Krempa 18 May '22

18 May '22

Fix a memleak and make the code a bit neater. Peter Krempa (4): util: typedparam: Introduce virTypedParamListFromParams virGetConnectGeneric: Fix memleak of 'identparams' when connecting between split daemons virIdentityGetParameters: Return 'virTypedParamList' doRemoteOpen: Refactor control flow src/driver.c | 8 +++---- src/libvirt_private.syms | 1 + src/remote/remote_daemon_dispatch.c | 36 ++++++++++++----------------- src/util/viridentity.c | 15 ++++-------- src/util/viridentity.h | 5 ++-- src/util/virtypedparam.c | 13 +++++++++++ src/util/virtypedparam.h | 4 ++++ 7 files changed, 44 insertions(+), 38 deletions(-) -- 2.35.3

2 5

[libvirt PATCH] util: Do not report useless error in virPortAllocatorRelease
by Jiri Denemark 18 May '22

18 May '22

If the port allocator bitmap does not have enough bits to keep the state of the port we're going to release, the port is not reserved and thus is trivially released without doing anything. No need to report an error in such case. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/util/virportallocator.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/util/virportallocator.c b/src/util/virportallocator.c index 44edd8f99a..97ab362749 100644 --- a/src/util/virportallocator.c +++ b/src/util/virportallocator.c @@ -254,12 +254,7 @@ virPortAllocatorRelease(unsigned short port) return 0; VIR_WITH_OBJECT_LOCK_GUARD(pa) { - if (virBitmapClearBit(pa->bitmap, port) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Failed to release port %d"), - port); - return -1; - } + ignore_value(virBitmapClearBit(pa->bitmap, port)); } return 0; -- 2.35.1

2 1

[libvirt RFCv8 00/27] multifd save restore prototype
by Claudio Fontana 18 May '22

18 May '22

This is v8 of the multifd save prototype, which fixes a few bugs, adds a few more code splits, and records the number of channels as well as the compression algorithm, so the restore command is more user-friendly. It is now possible to just say: virsh save mydomain /mnt/saves/mysave --parallel virsh restore /mnt/saves/mysave --parallel and things work with the default of 2 channels, no compression. It is also possible to say of course: virsh save mydomain /mnt/saves/mysave --parallel --parallel-connections 16 --parallel-compression zstd virsh restore /mnt/saves/mysave --parallel and things also work fine, due to channels and compression being stored in the main save file. --- changes from v7: * [ base params API and iohelper refactoring upstreamed ] * extended the QEMU save image format more, to record the nr of multifd channels on save. Made the data header struct packed. * removed --parallel-connections from the restore command, as now it is useless due to QEMU save image format extension. * separate out patches to expose migration_params APIs to saveimage, including qemuMigrationParamsSetString, SetCap, SetInt. * fixed bugs in the ImageOpen patch (missing saveFd init), removed some whitespace, and fixed some convoluted code paths for return value -3. Claudio Fontana (27): multifd-helper: new helper for parallel save/restore tools: prepare doSave to use parameters tools: prepare cmdRestore to use parameters libvirt: add new VIR_DOMAIN_SAVE_PARALLEL flag and parameter qemu: add stub support for VIR_DOMAIN_SAVE_PARALLEL in save qemu: add stub support for VIR_DOMAIN_SAVE_PARALLEL in restore qemu: saveimage: introduce virQEMUSaveFd qemu: saveimage: convert qemuSaveImageCreate to use virQEMUSaveFd qemu: saveimage: convert qemuSaveImageOpen to use virQEMUSaveFd qemu: saveimage: add virQEMUSaveFd APIs for multifd qemu: saveimage: wire up saveimage code with the multifd helper qemu: capabilities: add multifd to the probed migration capabilities qemu: saveimage: add multifd related fields to save format qemu: migration_params: add APIs to set Int and Cap qemu: migration: implement qemuMigrationSrcToFilesMultiFd qemu: add parameter to qemuMigrationDstRun to skip waiting qemu: implement qemuSaveImageLoadMultiFd tools: add parallel parameter to virsh save command tools: add parallel parameter to virsh restore command qemu: add migration parameter multifd-compression libvirt: add new VIR_SAVE_PARAM_PARALLEL_COMPRESSION qemu: saveimage: add parallel compression argument to ImageCreate qemu: saveimage: add stub support for multifd compression parameter qemu: migration: expose qemuMigrationParamsSetString qemu: saveimage: implement multifd-compression in parallel save qemu: saveimage: restore compressed parallel images tools: add parallel-compression parameter to virsh save command docs/manpages/virsh.rst | 39 +- include/libvirt/libvirt-domain.h | 29 + po/POTFILES.in | 1 + src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 6 + src/qemu/qemu_capabilities.h | 4 + src/qemu/qemu_driver.c | 140 +++-- src/qemu/qemu_migration.c | 160 +++-- src/qemu/qemu_migration.h | 16 +- src/qemu/qemu_migration_params.c | 71 ++- src/qemu/qemu_migration_params.h | 15 + src/qemu/qemu_process.c | 3 +- src/qemu/qemu_process.h | 5 +- src/qemu/qemu_saveimage.c | 557 ++++++++++++++---- src/qemu/qemu_saveimage.h | 57 +- src/qemu/qemu_snapshot.c | 6 +- src/util/meson.build | 16 + src/util/multifd-helper.c | 249 ++++++++ src/util/virthread.c | 5 + src/util/virthread.h | 1 + .../caps_4.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 + .../caps_4.0.0.riscv32.xml | 1 + .../caps_4.0.0.riscv64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 1 + .../caps_4.0.0.x86_64.xml | 1 + .../caps_4.1.0.x86_64.xml | 1 + .../caps_4.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 + .../caps_4.2.0.x86_64.xml | 1 + .../caps_5.0.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 2 + .../caps_5.0.0.riscv64.xml | 2 + .../caps_5.0.0.x86_64.xml | 2 + .../qemucapabilitiesdata/caps_5.1.0.sparc.xml | 2 + .../caps_5.1.0.x86_64.xml | 2 + .../caps_5.2.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 2 + .../caps_5.2.0.riscv64.xml | 2 + .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 2 + .../caps_5.2.0.x86_64.xml | 2 + .../caps_6.0.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 2 + .../caps_6.0.0.x86_64.xml | 2 + .../caps_6.1.0.x86_64.xml | 2 + .../caps_6.2.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 2 + .../caps_6.2.0.x86_64.xml | 2 + .../caps_7.0.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml | 2 + .../caps_7.0.0.x86_64.xml | 2 + tools/virsh-domain.c | 101 +++- 53 files changed, 1254 insertions(+), 281 deletions(-) create mode 100644 src/util/multifd-helper.c -- 2.35.3

6 50

[libvirt][PATCH v12 0/6] Support query and use SGX
by Lin Yang 18 May '22

18 May '22

This patch series provides support for enabling Intel's Software Guard Extensions (SGX) feature in guest VM. Giving the SGX support in QEMU had been merged. Intel SGX is a set of instructions that increases the security of application code and data, giving them more protection from disclosure or modification. Developers can partition sensitive information into enclaves, which are areas of execution in memory with more security protection. The typical flow looks below at very high level: 1. Calls virConnectGetDomainCapabilities API to domain capabilities that includes the following SGX information. <feature> ... <sgx supported='yes'> <epc_size unit='KiB'>N</epc_size> </sgx> ... </feature> 2. User requests to start a guest calling virCreateXML() with SGX requirement. It does not support NUMA yet, since latest QEMU 6.2 release does not support NUMA. It should contain <devices> ... <memory model='sgx-epc'> <target> <size unit='KiB'>N</size> </target> </memory> ... </devices> Please note that SGX NUMA support will be implemented in future patches. Haibin Huang (4): Get SGX capabilities form QMP Convert QMP capabilities to domain capabilities Adding of the QEMU CAPS flag for unit test conf: expose SGX feature in domain capabilities Lin Yang (2): conf: Introduce SGX EPC element into device memory xml qemu: Add command-line to generate SGX EPC memory backend docs/formatdomain.rst | 9 +- docs/formatdomaincaps.rst | 26 ++++ src/conf/domain_capabilities.c | 29 ++++ src/conf/domain_capabilities.h | 13 ++ src/conf/domain_conf.c | 6 + src/conf/domain_conf.h | 1 + src/conf/domain_validate.c | 16 ++ src/conf/schemas/domaincaps.rng | 22 ++- src/conf/schemas/domaincommon.rng | 1 + src/libvirt_private.syms | 1 + src/qemu/qemu_alias.c | 6 +- src/qemu/qemu_capabilities.c | 141 ++++++++++++++++++ src/qemu/qemu_capabilities.h | 4 + src/qemu/qemu_capspriv.h | 4 + src/qemu/qemu_command.c | 54 ++++++- src/qemu/qemu_domain.c | 38 +++-- src/qemu/qemu_domain_address.c | 6 + src/qemu/qemu_driver.c | 1 + src/qemu/qemu_monitor.c | 10 ++ src/qemu/qemu_monitor.h | 3 + src/qemu/qemu_monitor_json.c | 104 ++++++++++++- src/qemu/qemu_monitor_json.h | 9 ++ src/qemu/qemu_process.c | 2 + src/qemu/qemu_validate.c | 8 + src/security/security_apparmor.c | 1 + src/security/security_dac.c | 2 + src/security/security_selinux.c | 2 + tests/domaincapsdata/bhyve_basic.x86_64.xml | 1 + tests/domaincapsdata/bhyve_fbuf.x86_64.xml | 1 + tests/domaincapsdata/bhyve_uefi.x86_64.xml | 1 + tests/domaincapsdata/empty.xml | 1 + tests/domaincapsdata/libxl-xenfv.xml | 1 + tests/domaincapsdata/libxl-xenpv.xml | 1 + .../domaincapsdata/qemu_2.11.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.11.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.11.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.11.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.12.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.12.0-tcg.x86_64.xml | 1 + .../qemu_2.12.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.12.0.x86_64.xml | 1 + .../domaincapsdata/qemu_3.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_3.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_3.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_3.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_3.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_3.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_3.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_3.1.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_3.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_4.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.0.0-tcg.x86_64.xml | 1 + .../qemu_4.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_4.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 1 + .../qemu_4.2.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.0.0-tcg.x86_64.xml | 1 + .../qemu_5.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_5.1.0.sparc.xml | 1 + tests/domaincapsdata/qemu_5.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.2.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.2.0-tcg.x86_64.xml | 1 + .../qemu_5.2.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_5.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 1 + .../qemu_6.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_6.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_6.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_6.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_6.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_6.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_6.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_6.2.0-q35.x86_64.xml | 4 + .../domaincapsdata/qemu_6.2.0-tcg.x86_64.xml | 4 + .../qemu_6.2.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_6.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_6.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_6.2.0.x86_64.xml | 4 + .../domaincapsdata/qemu_7.0.0-q35.x86_64.xml | 4 + .../domaincapsdata/qemu_7.0.0-tcg.x86_64.xml | 4 + .../qemu_7.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_7.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_7.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_7.0.0.x86_64.xml | 4 + .../domaincapsdata/qemu_7.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_7.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_7.1.0.x86_64.xml | 1 + .../caps_6.2.0.x86_64.replies | 22 ++- .../caps_6.2.0.x86_64.xml | 5 + .../caps_7.0.0.x86_64.replies | 22 ++- .../caps_7.0.0.x86_64.xml | 5 + .../caps_7.1.0.x86_64.replies | 21 ++- .../sgx-epc.x86_64-6.2.0.args | 37 +++++ tests/qemuxml2argvdata/sgx-epc.xml | 36 +++++ tests/qemuxml2argvtest.c | 2 + .../sgx-epc.x86_64-6.2.0.xml | 52 +++++++ tests/qemuxml2xmltest.c | 2 + 121 files changed, 785 insertions(+), 40 deletions(-) create mode 100644 tests/qemuxml2argvdata/sgx-epc.x86_64-6.2.0.args create mode 100644 tests/qemuxml2argvdata/sgx-epc.xml create mode 100644 tests/qemuxml2xmloutdata/sgx-epc.x86_64-6.2.0.xml -- 2.25.1

1 6

[PATCH 00/10] virclosecallbacks: Cleanups (part 1)
by Peter Krempa 17 May '22

17 May '22

This series simplifies some aspects of close callbacks in preparation of further refactors. Peter Krempa (10): virclosecallbacks.h: Reformat header to contemporary style virObjectLockGuard: Require that returned value is used qemuMigrationSrcBegin: Automatically free 'xml' variable on error bhyve: Store 'driver' in VM private data lxc: Store 'driver' in VM private data qemuMigrationSrcCleanup: Use 'driver' from VM private data qemuProcessAutoDestroy: Use 'driver' from VM private data lxcProcessAutoDestroy: Use 'driver' from VM private data bhyveProcessAutoDestroy: Use 'driver' from VM private data virclosecallbacks: Don't pass opqaue pointer to callback invocation src/bhyve/bhyve_domain.c | 8 ++++++-- src/bhyve/bhyve_domain.h | 2 ++ src/bhyve/bhyve_driver.c | 2 +- src/bhyve/bhyve_process.c | 6 +++--- src/hypervisor/virclosecallbacks.c | 5 ++--- src/hypervisor/virclosecallbacks.h | 29 +++++++++++++++++------------ src/lxc/lxc_domain.c | 4 +++- src/lxc/lxc_domain.h | 1 + src/lxc/lxc_driver.c | 2 +- src/lxc/lxc_process.c | 8 +++----- src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_migration.c | 13 +++++-------- src/qemu/qemu_process.c | 5 ++--- src/util/virobject.h | 2 +- 14 files changed, 48 insertions(+), 41 deletions(-) -- 2.35.3

2 11

[PATCH 0/9] qemu: fd: Address differences between FD passing types
by Peter Krempa 17 May '22

17 May '22

Originally the intention was to have one set of helpers but it turned out to be too much hassle and too obscure semantics. This series adds a new helper qemuFDPassDirect and simplifies the internals greatly by using a distinct set of APIs. Peter Krempa (9): qemu: fd: Add a distinct set of APIs for 'direct' fd passing mode qemu: Convert passing of 'vhostfd' to 'qemuFDPassDirect' qemu: Convert passing of 'tapfds' to 'qemuFDPassDirect' qemu: Convert passing of 'slirpfd' to 'qemuFDPassDirect' qemu: Use 'qemuFDPassDirect' for 'unix' chardevs qemuFDPassValidate: Don't validate file descriptors qemu: fd: Remove support for 'direct' fd passing from 'qemuFDPass' qemuFDPassTransferCommand: Remove return value qemu: fd: Fix documentation for FD set related functions src/qemu/qemu_command.c | 55 +++----- src/qemu/qemu_domain.c | 7 +- src/qemu/qemu_domain.h | 7 +- src/qemu/qemu_fd.c | 265 ++++++++++++++++++++--------------- src/qemu/qemu_fd.h | 24 +++- src/qemu/qemu_hotplug.c | 15 +- src/qemu/qemu_interface.c | 8 +- src/qemu/qemu_monitor_json.c | 4 +- src/qemu/qemu_process.c | 5 +- src/qemu/qemu_slirp.c | 4 +- tests/qemuxml2argvmock.c | 10 +- tests/testutilsqemu.c | 26 ++-- 12 files changed, 232 insertions(+), 198 deletions(-) -- 2.35.3

2 11

[PATCH 0/3] qemu: Promote internals descriptions to kbase articles
by Peter Krempa 17 May '22

17 May '22

Inside of the qemu driver source tree we had 3 text files describing internals. We can promote them to kbase articles to make them more accessible. You can browse the converted files at: https://pipo.sk.gitlab.io/-/libvirt/-/jobs/2462903538/artifacts/website/kba… https://pipo.sk.gitlab.io/-/libvirt/-/jobs/2462903538/artifacts/website/kba… https://pipo.sk.gitlab.io/-/libvirt/-/jobs/2462903538/artifacts/website/kba… Peter Krempa (3): qemu: THREADS.txt: rSTize and move to knowledge-base qemu: MIGRATION.txt: Move to kbase and rSTisze qemu: EVENTHANDLERS.txt: Move to kbase and rSTisze docs/kbase/index.rst | 9 ++ docs/kbase/internals/meson.build | 3 + .../kbase/internals/qemu-event-handlers.rst | 44 +++--- .../kbase/internals/qemu-migration.rst | 67 +++++---- .../kbase/internals/qemu-threads.rst | 136 +++++++++--------- 5 files changed, 137 insertions(+), 122 deletions(-) rename src/qemu/EVENTHANDLERS.txt => docs/kbase/internals/qemu-event-handlers.rst (64%) rename src/qemu/MIGRATION.txt => docs/kbase/internals/qemu-migration.rst (59%) rename src/qemu/THREADS.txt => docs/kbase/internals/qemu-threads.rst (70%) -- 2.35.3

2 4

[PATCH 0/3] ui: Remove deprecated sdl parameters and switch to QAPI parser
by Thomas Huth 17 May '22

17 May '22

The "-display sdl" option still uses a hand-crafted parser for its parameters since some of them used underscores which is forbidden in QAPI. Now that they've been deprecated and the deprecation period is over, we can remove the problematic parameters and switch to use the QAPI parser instead. While we're at it, also remove the deprecated "-sdl" and "-curses" options. Thomas Huth (3): ui: Remove deprecated parameters of the "-display sdl" option ui: Switch "-display sdl" to use the QAPI parser ui: Remove deprecated options "-sdl" and "-curses" docs/about/deprecated.rst | 26 ------- docs/about/removed-features.rst | 27 +++++++ qapi/ui.json | 17 ++++- include/sysemu/sysemu.h | 2 - softmmu/globals.c | 2 - softmmu/vl.c | 128 +------------------------------- ui/sdl2.c | 13 ++++ qemu-options.hx | 56 +------------- 8 files changed, 61 insertions(+), 210 deletions(-) -- 2.27.0

4 12