- Devel - libvirt List Archives

[libvirt] [PATCH] doc: clone+build instructions
by Jim Meyering 09 Jul '09

09 Jul '09

I realized it'd be nice to include instructions on how to build from a just-cloned repository, so copied most of this new file, README-hacking, from coreutils: >From 7ffc5ce3ebb0769c0edc9f6fa9dc25e315ffdcf3 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Wed, 8 Jul 2009 21:37:59 +0200 Subject: [PATCH] doc: clone+build instructions * README-hacking: New file. * bootstrap: Remove obsolete comments. --- README-hacking | 74 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ bootstrap | 8 +----- 2 files changed, 75 insertions(+), 7 deletions(-) create mode 100644 README-hacking diff --git a/README-hacking b/README-hacking new file mode 100644 index 0000000..3463da2 --- /dev/null +++ b/README-hacking @@ -0,0 +1,74 @@ +-*- outline -*- + +These notes intend to help people working on the checked-out sources. +These requirements do not apply when building from a distribution tarball. +See also HACKING for more detailed libvirt contribution guidelines. + +* Requirements + +We've opted to keep only the highest-level sources in the GIT repository. +This eases our maintenance burden, (fewer merges etc.), but imposes more +requirements on anyone wishing to build from the just-checked-out sources. +Note the requirements to build the released archive are much less and +are just the requirements of the standard ./configure && make procedure. +Specific development tools and versions will be checked for and listed by +the bootstrap script. See README-prereq for specific notes on obtaining +these prerequisite tools. + +Valgrind <http://valgrind.org/> is also highly recommended, if +Valgrind supports your architecture. See also README-valgrind. + +While building from a just-cloned source tree may require installing a +few prerequisites, later, a plain `git pull && make' should be sufficient. + +* First GIT checkout + +You can get a copy of the source repository like this: + + $ git clone git://libvirt.org/libvirt + $ cd libvirt + +The next step is to get and check other files needed to build, +which are extracted from other source packages: + + $ ./bootstrap + +Then run this to create e.g., Makefiles and ./configure, +and to invoke ./configure: + + $ ./autogen.sh + +And there you are! Just + + $ make + $ make check + +At this point, there should be no difference between your local copy, +and the GIT master copy: + + $ git diff + +should output no difference. + +Enjoy! + +----- + +Copyright (C) 2002-2009 Free Software Foundation, Inc. + +This program is free software: you can redistribute it and/or modify +it under the terms of the GNU General Public License as published by +the Free Software Foundation, either version 3 of the License, or +(at your option) any later version. + +This program is distributed in the hope that it will be useful, +but WITHOUT ANY WARRANTY; without even the implied warranty of +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +GNU General Public License for more details. + +You should have received a copy of the GNU General Public License +along with this program. If not, see <http://www.gnu.org/licenses/>. + +Local Variables: +indent-tabs-mode: nil +End: diff --git a/bootstrap b/bootstrap index 0754d02..8b81e0e 100755 --- a/bootstrap +++ b/bootstrap @@ -1,11 +1,5 @@ #!/bin/sh -# Run this after autogen.sh, to pull in all of the gnulib-related bits. -# It's important to run *after* autogen.sh, since it updates some of -# the same files autogen.sh does, yet those from gnulib are newer, -# and match the tests. So if a gnulib bug has been fixed since the -# snapshot taken for whatever gettext release you're using, yet you -# run "make check" against the wrong version, the corresponding unit -# test in gl-tests/ may well fail. +# Run this before autogen.sh, to pull in all of the gnulib-related bits. usage() { echo >&2 "\ -- 1.6.3.3.524.g8586b

2 6

[libvirt] the role of libvirtd
by Hugh O. Brock 08 Jul '09

08 Jul '09

Hello all. I spent quite a while yesterday in a meeting with a client interested in using libvirt for a large project. They are quite happy in general with the direction things are going. However they have objections to a couple of libvirt design points that have come up in multiple cases in the past, including in developing the other project I'm involved in, oVirt. Specifically, they would really prefer that libvirtd be a one-stop shop for everything they need to do on a virtualization host, including things we have traditionally held out-of-scope for libvirt. A partial list of those things would include: * In-depth multipath config management * Hardware lifecycle management (power-off, reboot, etc.) * HA configuration ... and pretty much anything else you might want to do on a piece of hardware that is hosting virtual machines. My initial reaction of course was to tell them "Well you should just use a separate agent for that sort of thing." But of course this means making a separate connection to the node depending on what operation you want to perform, which is cumbersome. So I guess what I'm asking is, why *not* expand the scope of libvirtd to be a one-stop shop for managing a node? Is there a really good reason it shouldn't have the remaining capabilities libvirt users want? Is that reason good enough to balance the headache our users have to deal with in coming up with a separate package to handle the tasks libvirtd does not? Slings, arrows, or thunderous applause welcome... Take care, --Hugh

4 5

[libvirt] [PATCH] use gnulib via a submodule
by Jim Meyering 08 Jul '09

08 Jul '09

Please NOTE: do not apply the changes below. They are incomplete because I've removed all the boring, repetitive parts. If you want to apply something, use this: http://meyering.net/code/tmp/libvirt-submodule.patch.bz2 For an overall summary of the process of hooking up gnulib as a submodule, see the long commit log for 5/7, below: Subject: [PATCH 5/7] make .gnulib a submodule I'm not sure all of 1/7 is welcome, but at least the silent-rules part seems in line with what people here like, considering that mylibtool does something similar. With this, you might be comfortable removing mylibtool. Jim >From 41e0b6942648065dcf00e9aee3f961297464a336 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Mon, 6 Jul 2009 19:06:00 +0200 Subject: [PATCH 1/7] configure.in: use automake-1.11 --- configure.in | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/configure.in b/configure.in index 29c8867..1170958 100644 --- a/configure.in +++ b/configure.in @@ -5,7 +5,8 @@ AC_CONFIG_SRCDIR([src/libvirt.c]) AC_CONFIG_AUX_DIR([build-aux]) AM_CONFIG_HEADER([config.h]) dnl Make automake keep quiet about wildcards & other GNUmake-isms -AM_INIT_AUTOMAKE([-Wno-portability]) +AM_INIT_AUTOMAKE([1.11 color-tests parallel-tests -Wno-portability]) +AM_SILENT_RULES([yes]) # make --enable-silent-rules the default. AC_CANONICAL_HOST LIBVIRT_MAJOR_VERSION=`echo $VERSION | awk -F. '{print $1}'` -- 1.6.3.3.524.g8586b >From d73c9fc35bdcac3c1f8b24cad226fc879325d3c2 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Mon, 6 Jul 2009 18:23:44 +0200 Subject: [PATCH 2/7] * Makefile.cfg: Rename to... * cfg.mk: ...this. New file. --- Makefile.cfg => cfg.mk | 0 1 files changed, 0 insertions(+), 0 deletions(-) rename Makefile.cfg => cfg.mk (100%) diff --git a/Makefile.cfg b/cfg.mk similarity index 100% rename from Makefile.cfg rename to cfg.mk -- 1.6.3.3.524.g8586b >From 1cacbc7f4c883f763606e0bed36bd8d149add0d9 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Mon, 6 Jul 2009 18:28:10 +0200 Subject: [PATCH 3/7] Prepare to use maint.mk from gnulib Since Makefile.maint will soon come from gnulib's maint.mk, sync Makefile.maint to have the same contents (modulo minor things). In syncing it, we have to remove some libvirt-specific rules. Since we want to keep them (of course), put those in cfg.mk. * Makefile.maint: Merge from gnulib's maint.mk. * cfg.mk (sc_avoid_write): New rule. From Makefile.cfg. (sc_prohibit_strcmp_and_strncmp): Likewise, and rename. (sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise. (sc_prohibit_nonreentrant): Likewise. (sc_prohibit_ctype_h): Likewise. (sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise. (sc_prohibit_virBufferAdd_with_string_literal): Likewise. (sc_prohibit_gethostby): Likewise. (sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the rule, inserting "_libvirt", since this rule is a specialization of the one in gnulib. * GNUmakefile: Include cfg.mk, not Makefile.cfg * .x-sc_prohibit_strcmp_and_strncmp: New file. * Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp . --- .x-sc_prohibit_strcmp_and_strncmp | 1 + GNUmakefile | 4 +- Makefile.am | 1 + Makefile.maint | 734 +++++++++++++++++-------------------- cfg.mk | 163 ++++++++ 5 files changed, 505 insertions(+), 398 deletions(-) create mode 100644 .x-sc_prohibit_strcmp_and_strncmp diff --git a/.x-sc_prohibit_strcmp_and_strncmp b/.x-sc_prohibit_strcmp_and_strncmp new file mode 100644 index 0000000..b7c456e --- /dev/null +++ b/.x-sc_prohibit_strcmp_and_strncmp @@ -0,0 +1 @@ +^gnulib/ diff --git a/GNUmakefile b/GNUmakefile index 157f432..e6d4178 100644 --- a/GNUmakefile +++ b/GNUmakefile @@ -40,7 +40,7 @@ export TAR_OPTIONS = --owner=0 --group=0 --numeric-owner include Makefile -include $(srcdir)/Makefile.cfg +include $(srcdir)/cfg.mk include $(srcdir)/Makefile.maint else diff --git a/Makefile.am b/Makefile.am index 681034a..dd98ff2 100644 --- a/Makefile.am +++ b/Makefile.am @@ -16,6 +16,7 @@ EXTRA_DIST = \ .x-sc_avoid_if_before_free \ .x-sc_require_config_h_first \ .x-sc_prohibit_strcmp \ + .x-sc_prohibit_strcmp_and_strncmp \ .x-sc_require_config_h \ .x-sc_prohibit_nonreentrant \ Makefile.nonreentrant \ ... -- 1.6.3.3.524.g8586b >From a4b10833246264377c9c0c99a0178c3e9b6af0f7 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Mon, 6 Jul 2009 19:17:06 +0200 Subject: [PATCH 4/7] skip some of gnulib's new rules * cfg.mk (local-checks-to-skip): Add these: sc_error_message_uppercase, sc_program_name, sc_require_test_exit_idiom, sc_makefile_check. --- cfg.mk | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/cfg.mk b/cfg.mk index 3c9feb6..35bedd1 100644 --- a/cfg.mk +++ b/cfg.mk @@ -52,6 +52,10 @@ local-checks-to-skip = \ sc_system_h_headers \ sc_tight_scope \ sc_two_space_separator_in_usage \ + sc_error_message_uppercase \ + sc_program_name \ + sc_require_test_exit_idiom \ + sc_makefile_check \ sc_useless_cpp_parens useless_free_options = \ -- 1.6.3.3.524.g8586b >From 856172836da7f639323702aff67489e9a74d47d5 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Tue, 7 Jul 2009 11:22:52 +0200 Subject: [PATCH 5/7] make .gnulib a submodule This makes it so we record (via a git submodule) a snapshot of whatever version of gnulib we're using, and none of gnulib sources are in the libvirt repository. The result is that we have as much reproducibility as when we version-controlled imported copies of the gnulib sources, but without the hassle of the manual process we used when syncing with upstream. Note that when you clone libvirt, you get only the libvirt repository, but when you first run ./bootstrap, it clones gnulib (at the SHA1 recorded via the submodule), creating the .gnulib/ hierarchy. Then, the bootstrap script runs gnulib-tool to populate gnulib/ with the files that make up the selected modules. Put the following in your ~/.gitconfig file. [alias] syncsub = submodule foreach git pull origin master The update procedure is simple: git syncsub ...build & test... git commit -m 'gnulib: sync submodule to latest' .gnulib * .gitmodules: New file. * .gnulib: Initialize. * bootstrap: Set up to use the new submodule. Stop using --no-vc-files. Don't remove .gitignore files. Don't use or create .cvsignore. Diagnose an invalid --gnulib-srcdir=DIR argument. * build-aux/vc-list-files: Delete file, now pulled from gnulib. * build-aux/useless-if-before-free: Likewise. * po/POTFILES.in: Remove gnulib/lib/gai_strerror.c, since it no longer contains translatable strings. * gnulib/*: Remove gnulib/ hierarchy. --- .gitignore | 1 + .gitmodules | 3 + .gnulib | 1 + bootstrap | 45 +- build-aux/useless-if-before-free | 180 -- build-aux/vc-list-files | 107 - gnulib/lib/.cvsignore | 26 - gnulib/lib/.gitignore | 26 - gnulib/lib/Makefile.am | 1241 -------- gnulib/lib/alloca.c | 489 ---- gnulib/lib/alloca.in.h | 56 - gnulib/lib/arpa/.cvsignore | 1 - gnulib/lib/arpa/.gitignore | 1 - gnulib/lib/arpa_inet.in.h | 90 - ... diff --git a/.gitignore b/.gitignore index ca73a98..964580c 100644 --- a/.gitignore +++ b/.gitignore @@ -34,3 +34,4 @@ stamp-h stamp-h.in stamp-h1 update.log +tests/*.log diff --git a/.gitmodules b/.gitmodules new file mode 100644 index 0000000..7acb1ea --- /dev/null +++ b/.gitmodules @@ -0,0 +1,3 @@ +[submodule "gnulib"] + path = .gnulib + url = git://git.sv.gnu.org/gnulib.git diff --git a/.gnulib b/.gnulib new file mode 160000 index 0000000..1203e8d --- /dev/null +++ b/.gnulib @@ -0,0 +1 @@ +Subproject commit 1203e8d1f62dec3d2436dffadd5c20793cf84366 diff --git a/bootstrap b/bootstrap index baf52e7..7ce28da 100755 --- a/bootstrap +++ b/bootstrap @@ -40,25 +40,31 @@ do esac done -cleanup_gnulib() { - st=$? - rm -fr .gnulib - exit $st -} +# Get gnulib files. case ${GNULIB_SRCDIR--} in -) - if [ ! -d .gnulib ]; then + echo "$0: getting gnulib files..." + git submodule init || exit $? + git submodule update || exit $? + GNULIB_SRCDIR=.gnulib + ;; +*) + # Redirect the gnulib submodule to the directory on the command line + # if possible. + if test -d "$GNULIB_SRCDIR"/.git && \ + git config --file .gitmodules submodule.gnulib.url >/dev/null; then + git submodule init + GNULIB_SRCDIR=`cd $GNULIB_SRCDIR && pwd` + git config --replace-all submodule.gnulib.url $GNULIB_SRCDIR echo "$0: getting gnulib files..." - - trap cleanup_gnulib 1 2 13 15 - - git clone --depth 1 git://git.sv.gnu.org/gnulib .gnulib || - cleanup_gnulib - - trap - 1 2 13 15 + git submodule update || exit $? + GNULIB_SRCDIR=.gnulib + else + echo >&2 "$0: invalid gnulib srcdir: $GNULIB_SRCDIR" + exit 1 fi - GNULIB_SRCDIR=.gnulib + ;; esac gnulib_tool=$GNULIB_SRCDIR/gnulib-tool @@ -103,20 +109,9 @@ vc-list-files # put *.[ch] files in new gnulib/lib/ dir. $gnulib_tool \ - --no-vc-files \ --lgpl=2 \ --with-tests \ --m4-base=gnulib/m4 \ --source-base=gnulib/lib \ --tests-base=gnulib/tests \ --import $modules - -rm -f \ - .gitignore \ - gnulib/lib/.gitignore \ - gnulib/m4/.gitignore \ - gnulib/tests/.gitignore - -(cd gnulib/lib && - (cat .cvsignore; \ - ls -1 *.in.h|sed 's/\.in\.h/.h/') | sort -u > .t; mv .t .cvsignore) diff --git a/po/POTFILES.in b/po/POTFILES.in index 973f580..357cd70 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -1,4 +1,3 @@ -gnulib/lib/gai_strerror.c qemud/qemud.c qemud/remote.c src/bridge.c ... -- 1.6.3.3.524.g8586b >From ab811737a6914133bf12a46d4c5b5a2a2bdd9ee9 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Tue, 7 Jul 2009 12:05:18 +0200 Subject: [PATCH 6/7] remove all .cvsignore files --- .cvsignore | 34 ------------------------- build-aux/.cvsignore | 10 ------- build-aux/.gitignore | 2 + docs/.cvsignore | 4 --- docs/devhelp/.cvsignore | 3 -- docs/examples/.cvsignore | 7 ----- docs/examples/python/.cvsignore | 2 - docs/schemas/.cvsignore | 2 - examples/domain-events/events-c/.cvsignore | 6 ---- examples/hellolibvirt/.cvsignore | 5 ---- include/.cvsignore | 2 - include/libvirt/.cvsignore | 2 - m4/.cvsignore | 37 ---------------------------- po/.cvsignore | 15 ----------- proxy/.cvsignore | 5 ---- python/.cvsignore | 15 ----------- python/tests/.cvsignore | 2 - qemud/.cvsignore | 12 --------- src/.cvsignore | 20 --------------- tests/.cvsignore | 28 --------------------- tests/confdata/.cvsignore | 2 - tests/sexpr2xmldata/.cvsignore | 2 - tests/xencapsdata/.cvsignore | 2 - tests/xmconfigdata/.cvsignore | 2 - tests/xml2sexprdata/.cvsignore | 2 - tools/.cvsignore | 4 --- 26 files changed, 2 insertions(+), 225 deletions(-) ... -- 1.6.3.3.524.g8586b >From b718b0763f8fbfc35af586fa6d132d39259d0e11 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Tue, 7 Jul 2009 18:08:45 +0200 Subject: [PATCH 7/7] use gnumakefile and maintainer-makefile modules from gnulib * bootstrap (modules): Add gnumakefile and maintainer-makefile. * GNUmakefile: Remove file, now provided by gnulib. * Makefile.maint: Remove. Replaced by maint.mk from gnulib. .gitignore: Add GNUmakefile and maint.mk. * cfg.mk (prev_version_file): Disable this feature. Setting this to /dev/null avoids an otherwise harmless diagnostic. --- .gitignore | 2 + GNUmakefile | 60 ----- Makefile.maint | 770 -------------------------------------------------------- bootstrap | 2 + cfg.mk | 3 + 5 files changed, 7 insertions(+), 830 deletions(-) delete mode 100644 GNUmakefile delete mode 100644 Makefile.maint ... diff --git a/bootstrap b/bootstrap index 7ce28da..b0de3df 100755 --- a/bootstrap +++ b/bootstrap @@ -78,8 +78,10 @@ getaddrinfo gethostname getpass gettext +gnumakefile inet_pton ioctl +maintainer-makefile mkstemp mktempd perror diff --git a/cfg.mk b/cfg.mk index 35bedd1..736f7c0 100644 --- a/cfg.mk +++ b/cfg.mk @@ -227,3 +227,6 @@ sc_libvirt_unmarked_diagnostics: | grep '[ ]"' && \ { echo '$(ME): found unmarked diagnostic(s)' 1>&2; \ exit 1; } || : + +# We don't use this feature of maint.mk. +prev_version_file = /dev/null -- 1.6.3.3.524.g8586b

3 13

[libvirt] turn off dnsmasq
by Mike Power 08 Jul '09

08 Jul '09

I have a series of kvm vms I am running via libvirt. I have bind9 and dhcp3-server installed and I am happy with their configuration. The problem I have is that dhcp3-server and dnsmasq are currently fighting over who hands out the ip address. My vms work when they get their ip from dhcp3-server, and they fail when dnsmasq hands out the ip address. Unfortunately I can not get dnsmasq to stop handing out ip addresses. This is the configuration of my default network: <network> <name>default</name> <bridge name="virbr%d" /> <forward/> <ip address="192.168.122.1" netmask="255.255.255.0"> </ip> </network> Notice in the ip tag the optional dhcp tag is missing. Thus dnsmasq I thought, was supposed to leave well enough alone. It doesn't. I can turn off dhcp3-server and start up a host. What I see in the syslog is: Jul 7 08:52:21 vmhost dnsmasq[3420]: DHCPREQUEST(virbr0) 192.168.122.244 52:54:00:8f:7c:a4 Jul 7 08:52:21 vmhost dnsmasq[3420]: DHCPACK(virbr0) 192.168.122.244 52:54:00:8f:7c:a4 host1000 Then when I run ifconfig on the host1000 vm, it has an ip address that it obviously got from dnsmasq. I just need dnsmasq to stop handing out IPs, how do I do that? Mike Power

2 1

[libvirt] [PATCH 3/4] fix another failing "make distcheck" (qemuhelptest)
by Jim Meyering 08 Jul '09

08 Jul '09

This fixes another "make distcheck" (or non-srcdir) build failure: >From f9523d014a590fb881c14397f8c3869f328d023c Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Wed, 8 Jul 2009 08:35:24 +0200 Subject: [PATCH 3/4] fix another failing "make distcheck" (qemuhelptest) It failed in a non-srcdir build because those 5 sample output files were not included in the distribution tarball. Include them. * tests/Makefile.am (qemuhelpdata, EXTRA_DIST): Include these: kvm-74, kvm-86, qemu-0.10.5, qemu-0.9.1, qemu-kvm-0.10.5. --- tests/Makefile.am | 10 +++++++++- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 3d98d69..f8bde34 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -36,6 +36,13 @@ LDADDS = \ $(LIBSOCKET) \ $(COVERAGE_LDFLAGS) +qemuhelpdata = \ + kvm-74 \ + kvm-86 \ + qemu-0.10.5 \ + qemu-0.9.1 \ + qemu-kvm-0.10.5 + EXTRA_DIST = \ oomtrace.pl \ test-lib.sh \ @@ -51,7 +58,8 @@ EXTRA_DIST = \ storagevolschematest \ storagevolschemadata \ nodedevschematest \ - nodedevschemadata + nodedevschemadata \ + $(patsubst %,qemuhelpdata/%,$(qemuhelpdata)) noinst_PROGRAMS = virshtest conftest \ nodeinfotest statstest qparamtest -- 1.6.3.3.524.g8586b

3 4

[libvirt] [PATCH 4/4] generate ChangeLog from git logs into distribution tarball
by Jim Meyering 08 Jul '09

08 Jul '09

This is what I started out working on, before I noticed the "make distcheck" failures. >From 9fd0624b8cee33b8c725464d289cc5ce33ffc1c3 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Wed, 8 Jul 2009 08:54:25 +0200 Subject: [PATCH 4/4] generate ChangeLog from git logs into distribution tarball No longer maintain a version-controlled ChangeLog file, but do continue to include a ChangeLog file in distribution tarball. * Makefile.am (gen-ChangeLog): New rule. (dist-hook): Depend on it. (EXTRA_DIST): Add ChangeLog-old. * bootstrap (modules): Add gitlog-to-changelog. * ChangeLog: Remove file. Renamed to... * ChangeLog-old: ...this. New file. * autogen.sh: Touch ChangeLog, to ensure it exists. For automake. --- ChangeLog => ChangeLog-old | 2 +- Makefile.am | 15 +++++++++++++++ autogen.sh | 3 +++ bootstrap | 1 + build-aux/.gitignore | 1 + 5 files changed, 21 insertions(+), 1 deletions(-) rename ChangeLog => ChangeLog-old (99%) diff --git a/ChangeLog b/ChangeLog-old similarity index 99% rename from ChangeLog rename to ChangeLog-old index b266de6..c3b41e2 100644 --- a/ChangeLog +++ b/ChangeLog-old @@ -1207,7 +1207,7 @@ Fri Apr 24 13:17:47 BST 2009 Daniel P. Berrange <berrange(a)redhat.com> Fix network config in XM driver * src/xm_internal.c: Fix setting of bridge & script parameters in VIF config - * src/xend_internal.h, src/xend_internal.c: Export the + * src/xend_internal.h, src/xend_internal.c: Export the default bridge script name to XM driver * tests/xmconfigdata/*: Update to take account of script= setting in VIF config diff --git a/Makefile.am b/Makefile.am index c251f96..f9efff5 100644 --- a/Makefile.am +++ b/Makefile.am @@ -9,6 +9,7 @@ SUBDIRS = gnulib/lib include src qemud tools proxy docs gnulib/tests \ ACLOCAL_AMFLAGS = -I m4 -I gnulib/m4 EXTRA_DIST = \ + ChangeLog-old \ libvirt.spec libvirt.spec.in \ mingw32-libvirt.spec.in \ libvirt.pc libvirt.pc.in \ @@ -49,3 +50,17 @@ clean-cov: # disable this check distuninstallcheck: + +dist-hook: gen-ChangeLog + +# Generate the ChangeLog file (with all entries since the switch to git) +# and insert it into the directory we're about to use to create a tarball. +gen_start_date = 2009-07-04 +.PHONY: gen-ChangeLog +gen-ChangeLog: + if test -d .git; then \ + $(top_srcdir)/build-aux/gitlog-to-changelog \ + --since=$(gen_start_date) > $(distdir)/cl-t; \ + rm -f $(distdir)/ChangeLog; \ + mv $(distdir)/cl-t $(distdir)/ChangeLog; \ + fi diff --git a/autogen.sh b/autogen.sh index 788729f..c026112 100755 --- a/autogen.sh +++ b/autogen.sh @@ -54,6 +54,9 @@ if test -z "$*"; then echo "to pass any to it, please specify them on the $0 command line." fi +# Automake requires that ChangeLog exist. +touch ChangeLog + autopoint --force #rm -rf m4 libtoolize --copy --force diff --git a/bootstrap b/bootstrap index b0de3df..0754d02 100755 --- a/bootstrap +++ b/bootstrap @@ -78,6 +78,7 @@ getaddrinfo gethostname getpass gettext +gitlog-to-changelog gnumakefile inet_pton ioctl diff --git a/build-aux/.gitignore b/build-aux/.gitignore index af6c366..62188c1 100644 --- a/build-aux/.gitignore +++ b/build-aux/.gitignore @@ -10,3 +10,4 @@ mkinstalldirs mktempd /useless-if-before-free /vc-list-files +/gitlog-to-changelog -- 1.6.3.3.524.g8586b

3 3

[libvirt] netcf error message...
by Shahar Klein 08 Jul '09

08 Jul '09

folowing the instructions in netcf I'm trying to run some basic interface configuration via libvirt patched with the netcf patches I get error messages - but the interface(eth1) seem to be managed correctly - do I have an aug(what is that?) problem? virsh # iface-define /root/libvirt_working/eth1.xml error: Failed to define interface from /root/libvirt_working/eth1.xml error: internal error could not get interface XML description (netcf: unspecified error - aug_save failed) virsh # iface-list Name State MAC Address -------------------------------------------- eth0 active 00:18:fe:28:7d:82 lo active 00:00:00:00:00:00 virsh # iface-start eth1 Interface eth1 started virsh # iface-list Name State MAC Address -------------------------------------------- eth0 active 00:18:fe:28:7d:82 eth1 active 00:18:fe:28:7d:83 lo active 00:00:00:00:00:00

1 0

[libvirt] kernel summit topic - 'containers end-game'
by Serge E. Hallyn 08 Jul '09

08 Jul '09

A topic on ksummit agenda is 'containers end-game and how do we get there'. So for starters, looking just at application (and system) containers, what do the libvirt and liblxc projects want to see in kernel support that is currently missing? Are there specific things that should be done soon to make containers more useful and usable? More generally, the topic raises the question... what 'end-games' are there? A few I can think of off-hand include: 1. resource control 2. lightweight virtual servers 3. (or 2.5) unprivileged containers/jail-on-steroids (lightweight virtual servers in which you might, just maybe, almost, be able to give away a root account, at least as much as you could do so with a kvm/qemu/xen partition) 4. checkpoint, restart, and migration For each end-game, what kernel pieces do we think are missing? For instance, people seem agreed that resource control needs io control :) Containers imo need a user namespace. I think there are quite a few network namespace exploiters who require sysfs directory tagging (or some equivalent) to allow us to migrate physical devices into network namespaces. And checkpoint/restart needs... checkpoint/restart. thanks, -serge

5 14

[libvirt] PATCH: Fix LXC container capabilities
by Daniel P. Berrange 08 Jul '09

08 Jul '09

My previous change to LXC container capabilties setup has a fairly stupid bug in it. The container init process starts off with no capabilities whatsoever :-( This was caused by a bogus capng_lock() call which meant that all capabilities were cleared when the init process was exec'd. The capng_lock call sets NOROOT & NROOT_LOCKED flags in the process secure bits. This is not neccessary for the init process - we have reduced the bounding set which is sufficient for our security goals. With the capng_lock() call removed, the init process gets its permitted and effective sets filled to match the bounding set which is the desired scenario. Daniel diff --git a/src/lxc_container.c b/src/lxc_container.c index 950dd50..b3978df 100644 --- a/src/lxc_container.c +++ b/src/lxc_container.c @@ -675,16 +675,9 @@ static int lxcContainerDropCapabilities(void) _("failed to apply capabilities: %d"), ret); return -1; } - - /* Need to prevent them regaining any caps on exec */ - if ((ret = capng_lock()) < 0) { - lxcError(NULL, NULL, VIR_ERR_INTERNAL_ERROR, - _("failed to lock capabilities: %d"), ret); - return -1; - } - #else - VIR_WARN0(_("libcap-ng support not compiled in, unable to clear capabilities")); + /* Don't warn, since this ends up going to the guest console and annoying admins + VIR_WARN0(_("libcap-ng support not compiled in, unable to clear capabilities")); */ #endif return 0; } -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1

[libvirt] Cannot get network to work with LXC
by James Yu 08 Jul '09

08 Jul '09

Hi all, I tried to use the first xml config in http://libvirt.org/drvlxc.html to setup my first light weight container. However, I was unable to get the container's network to work. When I tried to give the interface an IP, I got the following error message: sh-4.0# /sbin/ifconfig veth1 192.168.0.1/24 SIOCSIFADDR: Permission denied SIOCSIFNETMASK: Permission denied SIOCGIFADDR: Cannot assign requested address SIOCSIFBROADCAST: Permission denied SIOCSIFFLAGS: Permission denied sh-4.0# Any advise ? This is a UTF-8 formatted mail ----------------------------------------------- James C.-C.Yu

3 2

[libvirt] PATCH: Video device config
by Tom Hughes 08 Jul '09

08 Jul '09

I recently posted a patch on the RedHat bugzilla (bug #467038) to add a model attribute to the graphics element so that the different graphics cards supported by QEMU could be selected. Apparently that approach has been rejected in the past however, and the preferred approach is to add a separate video element. I've taken the patch that Daniel Berrange posted here a few months ago that added the necessary XML handling for the new element and extended it by filling in the QEMU driver code to make it use the model details as well as fixing the default video model for XEN domains as per the list of outstanding issues given with the original patch. The updated patch is attached, and based on the list of outstanding tasks given before what remains to be done is: - Add RNG XML schemas & website docs - Make Xen drivers use this info for setting stdvga=1|0 config arg - Make VirtualBox use this info in whatever way it needs Tom -- Tom Hughes (tom(a)compton.nu) http://www.compton.nu/

3 3

[libvirt] [PATCH 2/4] fix failing "make distcheck"
by Jim Meyering 08 Jul '09

08 Jul '09

Make distcheck would fail without this: >From e2f91000a33168d2aaac89f94f1b11c633c579f0 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Wed, 8 Jul 2009 08:15:54 +0200 Subject: [PATCH 2/4] fix failing "make distcheck" * docs/Makefile.am (xml): Distribute testpool.xml and testvol.xml, which are referenced from testnode.xml. --- docs/Makefile.am | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index 43d04c3..4bdb827 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -55,7 +55,9 @@ xml = \ testdomfv0.xml \ testnetdef.xml \ testnetpriv.xml \ - testnode.xml + testnode.xml \ + testpool.xml \ + testvol.xml fig = \ libvirt-net-logical.fig \ -- 1.6.3.3.524.g8586b

3 2

[libvirt] [PATCH 1/4] Don't use mylibtool, (subsumed by automake's silent rules)
by Jim Meyering 08 Jul '09

08 Jul '09

Its use was causing a non-srcdir build to fail. * Makefile.am (EXTRA_DIST): Remove mylibtool. * configure.in: Don't use mylibtool. --- An alternative (if you don't want to use automake's silent-rules option) would be to keep mylibtool, but to use $(abs_top_srcdir) rather than $(top_srcdir) in that script. Makefile.am | 3 +-- configure.in | 4 ---- 2 files changed, 1 insertions(+), 6 deletions(-) diff --git a/Makefile.am b/Makefile.am index dd98ff2..c251f96 100644 --- a/Makefile.am +++ b/Makefile.am @@ -20,8 +20,7 @@ EXTRA_DIST = \ .x-sc_require_config_h \ .x-sc_prohibit_nonreentrant \ Makefile.nonreentrant \ - autogen.sh \ - mylibtool + autogen.sh man_MANS = virsh.1 diff --git a/configure.in b/configure.in index 1170958..a6f6754 100644 --- a/configure.in +++ b/configure.in @@ -59,10 +59,6 @@ dnl Support building Win32 DLLs (must appear *before* AM_PROG_LIBTOOL) AC_LIBTOOL_WIN32_DLL AM_PROG_LIBTOOL -dnl Override normal libtool in favour of our quiet version -LIBTOOL='$(SHELL) $(top_srcdir)/mylibtool' -AC_SUBST([LIBTOOL]) - AM_PROG_CC_C_O VERSION_SCRIPT_FLAGS=-Wl,--version-script= -- 1.6.3.3.524.g8586b

2 4

[libvirt] PATCH 2/2: Support <video> element in QEMU driver
by Daniel P. Berrange 08 Jul '09

08 Jul '09

This patch extends the QEMU driver to support the <video> element for configuring the type of video adapter exposed to the guest. It implements the XML -> ARGV and ARGV -> XML conversions, so both import & export work. Some of the existing tests are updated to use the <video> element to get test coverage. The QEMU help parsing test is changed to use symbolic constants instead of black magic hex constants. This supports both old -std-vga and new -vga style QEMU args. Daniel From: Daniel P. Berrange <berrange(a)redhat.com> Date: Mon, 6 Jul 2009 14:59:19 +0100 Subject: [PATCH 2/3] Support <video> element for QEMU guests * src/qemu_conf.c, src/qemu_conf.h: Use -vga or -std-vga when starting guests if video card is present * tests/qemuhelptest.c: Change to use constants instead of hardcoded hex numbers, and add VGA support * tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl-fullscreen.xml, tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.args, tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml, tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.args, tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.xml, tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-tls.xml, tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml, tests/qemuxml2argvdata/qemuxml2argv-input-xen.xml: Add <video> element for testing graphics adapter * tests/qemuxml2argvtest.c: Add QEMUD_CMD_FLAG_VGA flag * tests/qemuxml2xmltest.c: Add missing graphics-vnc-sasl/tls tests --- src/qemu_conf.c | 89 ++++++++++++++++++++ src/qemu_conf.h | 1 + tests/qemuhelptest.c | 66 +++++++++++++- .../qemuxml2argv-graphics-sdl-fullscreen.xml | 3 + .../qemuxml2argv-graphics-sdl.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml | 3 + .../qemuxml2argv-graphics-vnc-sasl.args | 2 +- .../qemuxml2argv-graphics-vnc-sasl.xml | 3 + .../qemuxml2argv-graphics-vnc-tls.xml | 3 + .../qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml | 3 + tests/qemuxml2argvdata/qemuxml2argv-input-xen.xml | 3 + tests/qemuxml2argvtest.c | 2 +- tests/qemuxml2xmltest.c | 2 + 13 files changed, 174 insertions(+), 8 deletions(-) diff --git a/src/qemu_conf.c b/src/qemu_conf.c index 9ca60b9..6337045 100644 --- a/src/qemu_conf.c +++ b/src/qemu_conf.c @@ -78,6 +78,15 @@ VIR_ENUM_IMPL(qemuDiskCacheV2, VIR_DOMAIN_DISK_CACHE_LAST, "writethrough", "writeback"); +VIR_ENUM_DECL(qemuVideo) + +VIR_ENUM_IMPL(qemuVideo, VIR_DOMAIN_VIDEO_TYPE_LAST, + "std", + "cirrus", + "vmware", + NULL, /* no arg needed for xen */ + NULL /* don't support vbox */); + int qemudLoadDriverConfig(struct qemud_driver *driver, const char *filename) { @@ -455,6 +464,8 @@ static unsigned int qemudComputeCmdFlags(const char *help, if (strstr(help, "format=")) flags |= QEMUD_CMD_FLAG_DRIVE_FORMAT; } + if (strstr(help, "-vga") && !strstr(help, "-std-vga")) + flags |= QEMUD_CMD_FLAG_VGA; if (strstr(help, "boot=on")) flags |= QEMUD_CMD_FLAG_DRIVE_BOOT; if (version >= 9000) @@ -1533,6 +1544,53 @@ int qemudBuildCommandLine(virConnectPtr conn, ADD_ARG_LIT("-full-screen"); } + if (def->nvideos) { + if (def->nvideos > 1) { + qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, + "%s", _("only one video card is currentely supported")); + goto error; + } + + if (qemuCmdFlags & QEMUD_CMD_FLAG_VGA) { + if (def->videos[0]->type == VIR_DOMAIN_VIDEO_TYPE_XEN) { + /* nothing - vga has no effect on Xen pvfb */ + } else { + const char *vgastr = qemuVideoTypeToString(def->videos[0]->type); + if (!vgastr) { + qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, + _("video type %s is not supported with QEMU"), + virDomainVideoTypeToString(def->videos[0]->type)); + goto error; + } + + ADD_ARG_LIT("-vga"); + ADD_ARG_LIT(vgastr); + } + } else { + + switch (def->videos[0]->type) { + case VIR_DOMAIN_VIDEO_TYPE_VGA: + ADD_ARG_LIT("-std-vga"); + break; + + case VIR_DOMAIN_VIDEO_TYPE_VMVGA: + ADD_ARG_LIT("-vmwarevga"); + break; + + case VIR_DOMAIN_VIDEO_TYPE_XEN: + case VIR_DOMAIN_VIDEO_TYPE_CIRRUS: + /* No special args - this is the default */ + break; + + default: + qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, + _("video type %s is not supported with QEMU"), + virDomainVideoTypeToString(def->videos[0]->type)); + goto error; + } + } + } + /* Add sound hardware */ if (def->nsounds) { int size = 100; @@ -2428,6 +2486,7 @@ virDomainDefPtr qemuParseCommandLine(virConnectPtr conn, char *path; int nnics = 0; const char **nics = NULL; + int video = VIR_DOMAIN_VIDEO_TYPE_CIRRUS; if (!progargv[0]) { qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, @@ -2805,6 +2864,18 @@ virDomainDefPtr qemuParseCommandLine(virConnectPtr conn, def->os.bootloader = strdup(val); if (!def->os.bootloader) goto no_memory; + } else if (STREQ(arg, "-vmwarevga")) { + video = VIR_DOMAIN_VIDEO_TYPE_VMVGA; + } else if (STREQ(arg, "-std-vga")) { + video = VIR_DOMAIN_VIDEO_TYPE_VGA; + } else if (STREQ(arg, "-vga")) { + WANT_VALUE(); + video = qemuVideoTypeFromString(val); + if (video < 0) { + qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, + _("unknown video adapter type '%s'"), val); + goto error; + } } else if (STREQ(arg, "-domid")) { WANT_VALUE(); /* ignore, generted on the fly */ @@ -2859,6 +2930,24 @@ virDomainDefPtr qemuParseCommandLine(virConnectPtr conn, def->graphics[def->ngraphics++] = sdl; } + if (def->ngraphics) { + virDomainVideoDefPtr vid; + if (VIR_ALLOC(vid) < 0) + goto no_memory; + if (def->virtType == VIR_DOMAIN_VIRT_XEN) + vid->type = VIR_DOMAIN_VIDEO_TYPE_XEN; + else + vid->type = video; + vid->vram = virDomainVideoDefaultRAM(def, vid->type); + vid->heads = 1; + + if (VIR_REALLOC_N(def->videos, def->nvideos+1) < 0) { + virDomainVideoDefFree(vid); + goto no_memory; + } + def->videos[def->nvideos++] = vid; + } + VIR_FREE(nics); if (!def->name) { diff --git a/src/qemu_conf.h b/src/qemu_conf.h index c0ed46d..9065821 100644 --- a/src/qemu_conf.h +++ b/src/qemu_conf.h @@ -57,6 +57,7 @@ enum qemud_cmd_flags { QEMUD_CMD_FLAG_DRIVE_CACHE_V2 = (1 << 12), /* Is the cache= flag wanting new v2 values */ QEMUD_CMD_FLAG_KVM = (1 << 13), /* Whether KVM is compiled in */ QEMUD_CMD_FLAG_DRIVE_FORMAT = (1 << 14), /* Is -drive format= avail */ + QEMUD_CMD_FLAG_VGA = (1 << 15), /* Is -vga avail */ }; /* Main driver state */ diff --git a/tests/qemuhelptest.c b/tests/qemuhelptest.c index bf8a293..73eae54 100644 --- a/tests/qemuhelptest.c +++ b/tests/qemuhelptest.c @@ -89,11 +89,67 @@ mymain(int argc, char **argv) ret = -1; \ } while (0) - DO_TEST("qemu-0.9.1", 0x002f, 9001, 0, 0); - DO_TEST("kvm-74", 0x633e, 9001, 1, 74); - DO_TEST("qemu-0.10.5", 0x5c6f, 10005, 0, 0); - DO_TEST("qemu-kvm-0.10.5", 0x7d7e, 10005, 1, 0); - DO_TEST("kvm-86", 0x7d7e, 10050, 1, 0); + DO_TEST("qemu-0.9.1", + QEMUD_CMD_FLAG_KQEMU | + QEMUD_CMD_FLAG_VNC_COLON | + QEMUD_CMD_FLAG_NO_REBOOT | + QEMUD_CMD_FLAG_DRIVE | + QEMUD_CMD_FLAG_NAME, + 9001, 0, 0); + DO_TEST("kvm-74", + QEMUD_CMD_FLAG_VNC_COLON | + QEMUD_CMD_FLAG_NO_REBOOT | + QEMUD_CMD_FLAG_DRIVE | + QEMUD_CMD_FLAG_DRIVE_BOOT | + QEMUD_CMD_FLAG_NAME | + QEMUD_CMD_FLAG_VNET_HDR | + QEMUD_CMD_FLAG_MIGRATE_KVM_STDIO | + QEMUD_CMD_FLAG_KVM | + QEMUD_CMD_FLAG_DRIVE_FORMAT, + 9001, 1, 74); + DO_TEST("qemu-0.10.5", + QEMUD_CMD_FLAG_KQEMU | + QEMUD_CMD_FLAG_VNC_COLON | + QEMUD_CMD_FLAG_NO_REBOOT | + QEMUD_CMD_FLAG_DRIVE | + QEMUD_CMD_FLAG_NAME | + QEMUD_CMD_FLAG_UUID | + QEMUD_CMD_FLAG_MIGRATE_QEMU_TCP | + QEMUD_CMD_FLAG_MIGRATE_QEMU_EXEC | + QEMUD_CMD_FLAG_DRIVE_CACHE_V2 | + QEMUD_CMD_FLAG_DRIVE_FORMAT | + QEMUD_CMD_FLAG_VGA, + 10005, 0, 0); + DO_TEST("qemu-kvm-0.10.5", + QEMUD_CMD_FLAG_VNC_COLON | + QEMUD_CMD_FLAG_NO_REBOOT | + QEMUD_CMD_FLAG_DRIVE | + QEMUD_CMD_FLAG_DRIVE_BOOT | + QEMUD_CMD_FLAG_NAME | + QEMUD_CMD_FLAG_UUID | + QEMUD_CMD_FLAG_VNET_HDR | + QEMUD_CMD_FLAG_MIGRATE_QEMU_TCP | + QEMUD_CMD_FLAG_MIGRATE_QEMU_EXEC | + QEMUD_CMD_FLAG_DRIVE_CACHE_V2 | + QEMUD_CMD_FLAG_KVM | + QEMUD_CMD_FLAG_DRIVE_FORMAT | + QEMUD_CMD_FLAG_VGA, + 10005, 1, 0); + DO_TEST("kvm-86", + QEMUD_CMD_FLAG_VNC_COLON | + QEMUD_CMD_FLAG_NO_REBOOT | + QEMUD_CMD_FLAG_DRIVE | + QEMUD_CMD_FLAG_DRIVE_BOOT | + QEMUD_CMD_FLAG_NAME | + QEMUD_CMD_FLAG_UUID | + QEMUD_CMD_FLAG_VNET_HDR | + QEMUD_CMD_FLAG_MIGRATE_QEMU_TCP | + QEMUD_CMD_FLAG_MIGRATE_QEMU_EXEC | + QEMUD_CMD_FLAG_DRIVE_CACHE_V2 | + QEMUD_CMD_FLAG_KVM | + QEMUD_CMD_FLAG_DRIVE_FORMAT | + QEMUD_CMD_FLAG_VGA, + 10050, 1, 0); return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl-fullscreen.xml b/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl-fullscreen.xml index fe1fe1a..f3fc588 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl-fullscreen.xml +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl-fullscreen.xml @@ -20,5 +20,8 @@ </disk> <input type='mouse' bus='ps2'/> <graphics type='sdl' display=':0.1' xauth='/root/.Xauthority' fullscreen='yes'/> + <video> + <model type='cirrus' vram='9216' heads='1'/> + </video> </devices> </domain> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.args b/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.args index 3b2b049..f908252 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.args @@ -1 +1 @@ -LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test XAUTHORITY=/root/.Xauthority DISPLAY=:0.1 /usr/bin/qemu -S -M pc -m 214 -smp 1 -monitor pty -no-acpi -boot c -hda /dev/HostVG/QEMUGuest1 -net none -serial none -parallel none -usb +LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test XAUTHORITY=/root/.Xauthority DISPLAY=:0.1 /usr/bin/qemu -S -M pc -m 214 -smp 1 -monitor pty -no-acpi -boot c -hda /dev/HostVG/QEMUGuest1 -net none -serial none -parallel none -usb -std-vga diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml b/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml index 1e04f12..431c3c9 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml @@ -20,5 +20,8 @@ </disk> <input type='mouse' bus='ps2'/> <graphics type='sdl' display=':0.1' xauth='/root/.Xauthority'/> + <video> + <model type='vga' vram='9216' heads='1'/> + </video> </devices> </domain> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.args b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.args index a41a57c..bd63540 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.args @@ -1 +1 @@ -LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test SASL_CONF_DIR=/root/.sasl2 /usr/bin/qemu -S -M pc -m 214 -smp 1 -monitor pty -no-acpi -boot c -hda /dev/HostVG/QEMUGuest1 -net none -serial none -parallel none -usb -vnc 127.0.0.1:3,sasl +LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test SASL_CONF_DIR=/root/.sasl2 /usr/bin/qemu -S -M pc -m 214 -smp 1 -monitor pty -no-acpi -boot c -hda /dev/HostVG/QEMUGuest1 -net none -serial none -parallel none -usb -vnc 127.0.0.1:3,sasl -vga cirrus diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.xml b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.xml index cbaa1da..b6f99d3 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.xml +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.xml @@ -20,5 +20,8 @@ </disk> <input type='mouse' bus='ps2'/> <graphics type='vnc' port='5903' autoport='no' listen='127.0.0.1'/> + <video> + <model type='cirrus' vram='9216' heads='1'/> + </video> </devices> </domain> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-tls.xml b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-tls.xml index cbaa1da..b6f99d3 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-tls.xml +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-tls.xml @@ -20,5 +20,8 @@ </disk> <input type='mouse' bus='ps2'/> <graphics type='vnc' port='5903' autoport='no' listen='127.0.0.1'/> + <video> + <model type='cirrus' vram='9216' heads='1'/> + </video> </devices> </domain> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml index cbaa1da..b6f99d3 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml @@ -20,5 +20,8 @@ </disk> <input type='mouse' bus='ps2'/> <graphics type='vnc' port='5903' autoport='no' listen='127.0.0.1'/> + <video> + <model type='cirrus' vram='9216' heads='1'/> + </video> </devices> </domain> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-input-xen.xml b/tests/qemuxml2argvdata/qemuxml2argv-input-xen.xml index 1e80317..fea7f8e 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-input-xen.xml +++ b/tests/qemuxml2argvdata/qemuxml2argv-input-xen.xml @@ -20,5 +20,8 @@ </disk> <input type='mouse' bus='xen'/> <graphics type='vnc' port='5903' autoport='no' listen='127.0.0.1'/> + <video> + <model type='xen' vram='4096' heads='1'/> + </video> </devices> </domain> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 28609eb..2a93018 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -216,7 +216,7 @@ mymain(int argc, char **argv) driver.vncSASL = 1; driver.vncSASLdir = strdup("/root/.sasl2"); - DO_TEST("graphics-vnc-sasl", 0); + DO_TEST("graphics-vnc-sasl", QEMUD_CMD_FLAG_VGA); driver.vncTLS = 1; driver.vncTLSx509verify = 1; driver.vncTLSx509certdir = strdup("/etc/pki/tls/qemu"); diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index ab9943d..7db7611 100644 --- a/tests/qemuxml2xmltest.c +++ b/tests/qemuxml2xmltest.c @@ -102,6 +102,8 @@ mymain(int argc, char **argv) DO_TEST("disk-drive-cache-v1-wb"); DO_TEST("disk-drive-cache-v1-none"); DO_TEST("graphics-vnc"); + DO_TEST("graphics-vnc-sasl"); + DO_TEST("graphics-vnc-tls"); DO_TEST("graphics-sdl"); DO_TEST("graphics-sdl-fullscreen"); DO_TEST("input-usbmouse"); -- 1.6.2.5 -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 2

[libvirt] [PATCH] provide the object name on lookup error
by Daniel Veillard 08 Jul '09

08 Jul '09

There were a number of places where the object name was not not reported, based on the use I don't think the string could be NULL in any of those. I also fixed a few POOL error which were really VOLume ones. Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

4 5

[libvirt] daily builds of pristine upstream sources for qemu, qemu-kvm, and libvirt
by Dustin Kirkland 07 Jul '09

07 Jul '09

Howdy, developers of qemu, qemu-kvm, and libvirt. I periodically see bug reports on these lists from users of Ubuntu packages of these projects. Since these users are often running some version of the project older than the current development branch, it's more interesting to know if the user can reproduce the bug on the latest development sources. I have constructed some automation that builds Debian/Ubuntu binaries for amd64, i386, and lpia platforms directly from your master git repositories every day at 11:00 UTC, and publishes them in a special, opt-in repository. These daily builds also drop any specific patches we may be carrying, in order to minimize the delta between the binaries built and your upstream sources. * https://launchpad.net/~ubuntu-virt/+archive/virt-daily-upstream In the event that an Ubuntu user reports a problem, and there's an interest in trying to reproduce the problem against the tip of the development branch, we can point them at this resource for testing purposes. Additionally, this tool also has the ability to expose build breakages. For example (let's not debug this in this thread), at the moment, qemu's build is broken, somewhere near: .... LINK cris-softmmu/qemu-system-cris ../libqemu_common.a(esdaudio.o): In function `qesd_run_in': /build/buildd/qemu-0.10.50.20090707062004/audio/esdaudio.c:400: undefined reference to `audio_pt_lock' .... Launchpad publishes the full build logs available for each architecture at the link above. For the above example, the specific build log is: * http://launchpadlibrarian.net/28761559/buildlog_ubuntu-karmic-amd64.qemu_0.… If anyone has suggestions as to the utility of this resource, I would appreciate constructive feedback. Cheers, -- :-Dustin

1 0

[libvirt] [PATCH] allow to set path to xen userspace tools
by Guido Günther 07 Jul '09

07 Jul '09

Hi, attached patch makes the path to the xen userspace tools configurable. Debian keeps this under /usr/lib/xen-default/ instead of /usr/lib/xen/. We don't have the amd64 libs in /usr/lib64/xen either so we can use: ./configure --with-xen-tools=/usr/lib/xen-defaults --with-xen-tools64=/usr/lib/xen-defaults instead of patching src/xen_internals.c directly. Skipping above options gives the current behaviour. I checked that "make check" still passes. O.k. to apply? Cheers, -- Guido

3 3

[libvirt] [PATCH] Power Hypervisor Support for libvirt - minimum set of features
by Eduardo Otubo 07 Jul '09

07 Jul '09

Hello all, This is the initial patch for the driver for IBM Power Hypervisors. The minimum set of features are now implemented: list, list --all and dumpxml. Here is the Changeset since last PATCH I sent: * The URI has changed to: phyp://user@[hmc|ivm]/managed_system. If the system is a HMC+VIOS based, only an HMC authentication will be required. Commands will be sent to VIOS trough HMC command line. And if the system is an IVM based, then just provide the username and password for IVM. * Since the Power Hypervisor has no information about UUID's, I built a little database (uuid_db) to store and associate LPAR ID's with UUID randomly generated by the API. * The command dumpxml is implemented, but there are some informations missing. Fetching informations like fstab, os type, uptime, IP addr and so on, will only be available in a future versions of the HMC system. * The TODO list is now set to implement life cycle functions. Thanks in advance, []'s -- Eduardo Otubo Software Engineer Linux Technology Center IBM Systems & Technology Group Mobile: +55 19 8135 0885 otubo(a)linux.vnet.ibm.com

2 7

[libvirt] PATCH: 0/3: Run QEMU guests within a CGroup
by Daniel P. Berrange 07 Jul '09

07 Jul '09

Recent Linux kernels have a new concept of 'CGroups' which is a way to group tasks on the system and apply policy to them as a whole. We already use this in the LXC container driver, to control total memory usage of things runing within a container. This patch series is a proof of concept to make use of CGroups in the QEMU driver. The idea is that we have a 3 level cgroup hierarchy - Top level; contains the libvirtd daemon itself - 2nd level: one per libvirt driver, but dos not contain any processes. - 3rd level: one per guest VM. Contains the QEMU process The host admin can do control on the top level and 2nd level to set an overall system policy. libvirt will then provide APIs / capabilities to control individual VMs policy. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

4 10

[libvirt] [PATCH 1/2] Added new filesystem glusterfs
by Harshavardhana 07 Jul '09

07 Jul '09

Added new enum for glusterfs, another netfs based filesystem. --- src/storage_conf.c | 2 +- src/storage_conf.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/storage_conf.c b/src/storage_conf.c index 5f724dc..16ed906 100644 --- a/src/storage_conf.c +++ b/src/storage_conf.c @@ -68,7 +68,7 @@ VIR_ENUM_IMPL(virStoragePoolFormatFileSystem, VIR_ENUM_IMPL(virStoragePoolFormatFileSystemNet, VIR_STORAGE_POOL_NETFS_LAST, - "auto", "nfs") + "auto", "nfs", "glusterfs") VIR_ENUM_IMPL(virStoragePoolFormatDisk, VIR_STORAGE_POOL_DISK_LAST, diff --git a/src/storage_conf.h b/src/storage_conf.h index 8a4fed2..27dc4a7 100644 --- a/src/storage_conf.h +++ b/src/storage_conf.h @@ -151,7 +151,6 @@ struct _virStoragePoolSourceHost { int protocol; }; - /* * Available extents on the underlying storage */ @@ -366,6 +365,7 @@ VIR_ENUM_DECL(virStoragePoolFormatFileSystem) enum virStoragePoolFormatFileSystemNet { VIR_STORAGE_POOL_NETFS_AUTO = 0, VIR_STORAGE_POOL_NETFS_NFS, + VIR_STORAGE_POOL_NETFS_GLUSTERFS, VIR_STORAGE_POOL_NETFS_LAST, }; VIR_ENUM_DECL(virStoragePoolFormatFileSystemNet) -- 1.6.0.6

2 1

[libvirt] Can't boot guest after adding an IDE storage
by M. Mohan Kumar 07 Jul '09

07 Jul '09

Hi, We installed Fedora 11 guest in an emulated SCSI disk using virt-install. After the installation the guest was shutdown and additional IDE virtual storage was added to the guest. When we try to boot the guest from virt-manager, it tries to boot from the newly added IDE storage (instead of installed SCSI storage) and fails to boot. It seems that how the disk devices are sorted is the problem. There is a bug opened to track this issue: https://bugzilla.redhat.com/show_bug.cgi?id=507271 As dicussed in the bugzilla, ideally there should be a 'bootable' flag for each storage device. Also virt-manager could another option to specify which disk to boot from. Regards, M. Mohan Kumar

3 2

[libvirt] [PATCH] don't raise a missing network as an internal error
by Daniel Veillard 07 Jul '09

07 Jul '09

https://bugzilla.redhat.com/show_bug.cgi?id=509189 When defining a domain referencing a missing network the erro should not be raised as an internal error. Patch by Paolo Bonzini looks fine to me, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

2 2

[libvirt] Switch from CVS to GIT is done
by Daniel Veillard 07 Jul '09

07 Jul '09

Thanks to Jim Meyering we now have a new git repository, I deprecated the CVS repository, it's read only, you should still be able to keep it around to make patches for a few weeks if needed. The new repo is at: http://libvirt.org/git/?p=libvirt.git;a=summary Unfortunately Jim had to clean up the conversion from CVS that was used previously at git://git.et.redhat.com/libvirt.git so the two are not compatible and the best is to clone a new tree using git clone git://libvirt.org/libvirt.git and then copying over your set of patches with "git format-patch" in the old dir and "git am" to paste them into the new cloned-dir (Jim can certainly provide more details if needed). Let us know if you see something weird in the new tree or on the web site, I have updated the download informations at http://libvirt.org/downloads.html A few things may change but I guess the switch is done at this point, Many thanks to Jim for maintaining the old tree and the migration ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

6 16

[libvirt] [PATCH 1/2] Added new filesystem glusterfs
by Harshavardhana 07 Jul '09

07 Jul '09

Added new enum for glusterfs, a new netfs based filesystem --- src/storage_conf.c | 2 +- src/storage_conf.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/storage_conf.c b/src/storage_conf.c index 5f724dc..16ed906 100644 --- a/src/storage_conf.c +++ b/src/storage_conf.c @@ -68,7 +68,7 @@ VIR_ENUM_IMPL(virStoragePoolFormatFileSystem, VIR_ENUM_IMPL(virStoragePoolFormatFileSystemNet, VIR_STORAGE_POOL_NETFS_LAST, - "auto", "nfs") + "auto", "nfs", "glusterfs") VIR_ENUM_IMPL(virStoragePoolFormatDisk, VIR_STORAGE_POOL_DISK_LAST, diff --git a/src/storage_conf.h b/src/storage_conf.h index 8a4fed2..27dc4a7 100644 --- a/src/storage_conf.h +++ b/src/storage_conf.h @@ -151,7 +151,6 @@ struct _virStoragePoolSourceHost { int protocol; }; - /* * Available extents on the underlying storage */ @@ -366,6 +365,7 @@ VIR_ENUM_DECL(virStoragePoolFormatFileSystem) enum virStoragePoolFormatFileSystemNet { VIR_STORAGE_POOL_NETFS_AUTO = 0, VIR_STORAGE_POOL_NETFS_NFS, + VIR_STORAGE_POOL_NETFS_GLUSTERFS, VIR_STORAGE_POOL_NETFS_LAST, }; VIR_ENUM_DECL(virStoragePoolFormatFileSystemNet) -- 1.6.0.6

1 0

[libvirt] make distcheck failure
by Guido Günther 07 Jul '09

07 Jul '09

Hi, in current git make distcheck currently fails on me with: make[5]: Entering directory `/var/scratch/debian/libvirt/cvs/libvirt/libvirt-0.6.5/_build/gnulib/lib' /bin/sh ../../../mylibtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../../gnulib/lib -I../.. -I../../intl -g -O2 -MT c-ctype.lo -MD -MP -MF .deps/c-ctype.Tpo -c -o c-ctype.lo ../../../gnulib/lib/c-ctype.c (CC) -o c-ctype.lo ../../../gnulib/lib/c-ctype.c ../../../mylibtool: line 58: /var/scratch/debian/libvirt/cvs/libvirt/libvirt-0.6.5/_build/gnulib/lib/../../../libtool: No such file or directory ../../../mylibtool: line 58: exec: /var/scratch/debian/libvirt/cvs/libvirt/libvirt-0.6.5/_build/gnulib/lib/../../../libtool: cannot execute: No such file or directory make[5]: *** [c-ctype.lo] Error 126 Any ideas? Cheers, -- Guido

2 1

[libvirt] Save and restore with KVM!
by Erkan Unal 06 Jul '09

06 Jul '09

Hi, First of all, I want to ask: is there a libvirt user mailing list? I generally see people exchanging ideas on development of libvirt in this mailing list. So feel free to direct me to the right place if this is not the main mailing list for these kind of questions. I am having problems with save and restore commands in virsh when I try to save and restore KVM virtual machines. After I initiate restore operation, instead of starting where I left during the save operation, it is restarting the VM. Therefore, I need to ask what should I check for these operations to execute correctly? What kind of vm disk types: qcow or vmdk? Which versions of qemu, kvm and libvirt combinations? currently I have libvirt 0.6.5, qemu 0.9.1, kvm-82 on fedora core 8 with kernel version of 2.6.26.8. Thanks, Erkan Unal

2 1

[libvirt] [PATCH] createLinux requires full-access connection
by Dan Kenigsberg 06 Jul '09

06 Jul '09

--- docs/examples/python/domstart.py | 2 +- python/tests/create.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/examples/python/domstart.py b/docs/examples/python/domstart.py index 64434c4..52fb79e 100755 --- a/docs/examples/python/domstart.py +++ b/docs/examples/python/domstart.py @@ -32,7 +32,7 @@ if len(sys.argv) != 2: (name, xmldesc) = read_domain(sys.argv[1]) -conn = libvirt.openReadOnly(None) +conn = libvirt.open(None) if conn == None: print 'Failed to open connection to the hypervisor' sys.exit(1) diff --git a/python/tests/create.py b/python/tests/create.py index 0da89a9..d2c434e 100755 --- a/python/tests/create.py +++ b/python/tests/create.py @@ -52,7 +52,7 @@ else: initrdU = "<initrd>" + initrdU + "</initrd>" -conn = libvirt.openReadOnly(None) +conn = libvirt.open(None) if conn == None: print 'Failed to open connection to the hypervisor' sys.exit(1) -- 1.6.2.5

3 2

[libvirt] [PATCH] Do a correct format mapping of partitions 2
by Henrik Persson 06 Jul '09

06 Jul '09

I make a new try from a different mail client now. /Henrik

4 5

Re: [libvirt] Patch to include arm variants in virsh capabilities
by C.J. Adams-Collier 05 Jul '09

05 Jul '09

> On Wed, Jul 01, 2009 at 11:02:16AM -0700, C.J. Adams-Collier wrote: > > Hey folks, > > > > I got an android and wanted to set up an armel debian vm to test out > > some code. I had to launch it directly with qemu-system-arm, though, > > since virsh didn't have an arm option to select. > > > > This is a patch against the debian version of the source after applying > > debian-specific changes. If you'd like a patch against mainline, I'd be > > willing to do that. > > > > http://karma.colliertech.org/~cjac/tmp/add-arm.patch > > Well, this list is really about upstream patches not distro specific > ones, I just verified that it applies cleanly against CVS. > and I could not access said patch [1]. That is weird. I hope it was just a fluke! Attached. > Send a patch against the > latest version or CVS/git as an mail attachemnt and we will try to add > it. Alrighty. I see that the mips machines are separated into 'mips' and 'mipsel'. I don't know anything about the endian-ness of the various machines (aside from versatilepb, which is little), so I just left them all in the generic qemu_arch_info.arch="arm" table entry. > Daniel Cheers, C.J. > [1] the server seems down I got an HTTP request timeout. hurm... I'm getting hits at least hourly from a site revproxied by the same host ( http://wp.colliertech.org/cj/ ) - perhaps it was a coincidental outage (*shakes fist at comcast*)? > -- > Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ > daniel <at> veillard.com | Rpmfind RPM search engine http://rpmfind.net/ > http://veillard.com/ | virtualization library http://libvirt.org/

3 5

[libvirt] Release of libvirt-0.6.5
by Daniel Veillard 03 Jul '09

03 Jul '09

As scheduled, the new version is available on the server: ftp://libvirt.org/libvirt/ This is mostly a bug fix release, though it includes some serious improvements for storage/NPIV and on the OpenNebula driver: * New features - create storage columes on disk backend (Henrik Persson) - drop of capabilities based on libcap-ng when possible (Daniel Berrange) * Portability - fix build on non-Linux targets (Daniel Berrange) * Documentation - typo and english fixes (Runa Bhattacharjee and Garry Dolley) - Docs on extending APIs (Dave Allan) - cleanup of debug and logging documentation (Amy Griffis) - add HACKING doc to the website (Daniel Berrange) - documentation for OpenNebula driver (Abel Miguez Rodriguez) * Bug fixes - forbid autostart on transcient networks - xen device removal crash (Daniel Berrange) - re-detection of transient VMs after libvirtd restart(Daniel Berrange) - bug in virFindFileInPath (Daniel Berrange) - handle new availheap sysctl in Xen (Daniel Berrange) - allow USB hostdev product 0 (Cole Robinson) - cleanup when creating a storage pool fails (Henrik Persson) - domain id fix on redefinition in test driver (Cole Robinson) - fix raw storage allocation (Cole Robinson) - memory reporting for inactive qemu drivers (Cole Robinson) - segfault if storage pool has no type attribute (Cole Robinson) - OpenNebula compilation issues (Javier Fontan) - dominfo command without security driver (Daniel Berrange) - domain state problems after migration or destroy (Federico Simoncelli) - leak in node device parsing (Dave Allan) - storage pool definitions reading at startup (Cole Robinson) - bogus WWN in NPIV support (David Allan) - avoid a segfault with recent Xen (Sascha) - cope with libnuma failures on weird topologies (Dan Berrange) - crash in QEMU driver with bad capabilities data (Dan Berrange) - trying to re-create a pool should not destroy it (Dave Allan) - endless loop in node device XML dump (Cole Robinson) - Re-label shared and readonly images (Dan Berrange) * Improvements - create and destroy NPIV support (David Allan) - networking in UML driver (Daniel Berrange) - HAL driver restart thread safety (Daniel Berrange) - capabilities and nodeinfo APIs for LXC (Daniel Berrange) - iNUMA API for VBox (Daniel Berrange) - dynamically search and use kvm-img qemu-img or qcow-create (Doug Goldstein) - fix qemu and kvm version parsing (Mark McLoughlin) - serial number for HAL storage (Dave Allan) - improve error reporting for virConnectOpen URIs (Daniel Berrange) - include OS driver name in device XML (Daniel Berrange) - fix qemu command flags fetching (Cole Robinson) - check that qemu support -drive format= (Cole Robinson) - improve emulator detection (Cole Robinson) - changes to config parser to accomodate VMX syntax (Matthias Bolte) - update network schemas and driver for missing elements (Satoru SATOH) - avoid changing file context if not needed (Tim Waugh) - skip labelling if no src path (Cole Robinson) - add arm emulation if qemu-system-arm is present (C.J. Adams-Collier) * Cleanups - daemon check logging env variables (Daniel Berrange) - User Mode Linux start and stop cleanups (Daniel Berrange) - share the NUMA api implementations (Daniel Berrange) - storage module dependancies (Dave Allan) - refactor storage XML parsing (Cole Robinson) - big cleanup of logging code (Amy Griffis) - superfluous % on format (Matthias Bolte) - cleanups and updates on OpenNebula driver (Daniel Berrange and Abel Miguez Rodriguez) thanks everybody for report, patches, documentation, etc ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] gitignore & cscope
by Dave Allan 03 Jul '09

03 Jul '09

Could we add cscope's files to .gitignore? Dave diff --git a/.gitignore b/.gitignore index 1b36694..ca73a98 100644 --- a/.gitignore +++ b/.gitignore @@ -19,6 +19,8 @@ config.status config.sub configure coverage +cscope.files +cscope.out libtool libvirt-*.tar.gz libvirt.pc

4 3

[libvirt] [PATCH 1/2] Re-label shared and readonly images
by Mark McLoughlin 03 Jul '09

03 Jul '09

From: Daniel P. Berrange <berrange(a)redhat.com> This patch was posted ages ago here: https://bugzilla.redhat.com/493692 But was never posted upstream AFAICT. Signed-off-by: Mark McLoughlin <markmc(a)redhat.com> --- src/security_selinux.c | 27 +++++++++++++++++---------- 1 files changed, 17 insertions(+), 10 deletions(-) diff --git a/src/security_selinux.c b/src/security_selinux.c index 4fb7c86..87073d2 100644 --- a/src/security_selinux.c +++ b/src/security_selinux.c @@ -24,11 +24,12 @@ #include "virterror_internal.h" #include "util.h" #include "memory.h" - +#include "logging.h" #define VIR_FROM_THIS VIR_FROM_SECURITY static char default_domain_context[1024]; +static char default_content_context[1024]; static char default_image_context[1024]; #define SECURITY_SELINUX_VOID_DOI "0" #define SECURITY_SELINUX_NAME "selinux" @@ -148,8 +149,13 @@ SELinuxInitialize(virConnectPtr conn) close(fd); ptr = strchrnul(default_image_context, '\n'); - *ptr = '\0'; - + if (*ptr == '\n') { + *ptr = '\0'; + strcpy(default_content_context, ptr+1); + ptr = strchrnul(default_content_context, '\n'); + if (*ptr == '\n') + *ptr = '\0'; + } return 0; } @@ -313,6 +319,8 @@ SELinuxSetFilecon(virConnectPtr conn, const char *path, char *tcon) { char ebuf[1024]; + VIR_INFO("Setting SELinux context on '%s' to '%s'", path, tcon); + if(setfilecon(path, tcon) < 0) { virSecurityReportError(conn, VIR_ERR_ERROR, _("%s: unable to set security context " @@ -337,9 +345,6 @@ SELinuxRestoreSecurityImageLabel(virConnectPtr conn, char *newpath = NULL; const char *path = disk->src; - if (disk->readonly || disk->shared) - return 0; - if ((err = virFileResolveLink(path, &newpath)) < 0) { virReportSystemError(conn, err, _("cannot resolve symlink %s"), path); @@ -366,8 +371,13 @@ SELinuxSetSecurityImageLabel(virConnectPtr conn, { const virSecurityLabelDefPtr secdef = &vm->def->seclabel; - if (secdef->imagelabel) + if (disk->shared) { + return SELinuxSetFilecon(conn, disk->src, default_image_context); + } else if (disk->readonly) { + return SELinuxSetFilecon(conn, disk->src, default_content_context); + } else if (secdef->imagelabel) { return SELinuxSetFilecon(conn, disk->src, secdef->imagelabel); + } return 0; } @@ -441,9 +451,6 @@ SELinuxSetSecurityLabel(virConnectPtr conn, if (secdef->imagelabel) { for (i = 0 ; i < vm->def->ndisks ; i++) { - if (vm->def->disks[i]->readonly || - vm->def->disks[i]->shared) continue; - if (SELinuxSetSecurityImageLabel(conn, vm, vm->def->disks[i]) < 0) return -1; } -- 1.6.2.5

2 5

[libvirt] vTPM support in libvirt
by Andreas Sommer 02 Jul '09

02 Jul '09

I'm wondering if there will be vTPM support in libvirt in the near future?! Xen does support it already with the configuration "vtpm = ['instance=1,backend=0']", for example. So it would be great if the libvirt XML format supported it, too... For example like this: <devices> <vtpm instance="1" backend="xxx" /> </devices> Both attributes are optional. The backend attribute is a VM ID (on Xen, only zero for dom0 is supported) and could be implemented as a UUID?! What do you think? Are there any efforts to introducing that? Cheers Andreas

6 13

[libvirt] [Patch] Fix network driver not to forget to save <domain/> in network XML file
by Satoru SATOH 02 Jul '09

02 Jul '09

It seems that libvirt network driver can understand /network/domain element but it does not save this configuration into the network definition XML file correctly (looks completely forgetting about it). Here is a fix for this problem. (see also: rhbz#505720) --- src/network_conf.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/network_conf.c b/src/network_conf.c index 1e0cbb8..1b50b84 100644 --- a/src/network_conf.c +++ b/src/network_conf.c @@ -592,6 +592,9 @@ char *virNetworkDefFormat(virConnectPtr conn, def->stp ? "on" : "off", def->delay); + if (def->domain) + virBufferVSprintf(&buf, " <domain name='%s'/>\n", def->domain); + if (def->ipAddress || def->netmask) { virBufferAddLit(&buf, " <ip"); -- 1.6.3.2

3 2

[libvirt] [Patch] Network schema fixes and updates
by Satoru SATOH 02 Jul '09

02 Jul '09

This is a patch to make network schema (network.rng) to support some neat features (/netowrk/domain, //dhcp/host/*). --- docs/schemas/network.rng | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng index 34c0163..a4281a5 100644 --- a/docs/schemas/network.rng +++ b/docs/schemas/network.rng @@ -1,6 +1,7 @@  <element name="network" xmlns="http://relaxng.org/ns/structure/1.0" datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes"> + <interleave>  <element name="name"><text/></element> @@ -43,6 +44,11 @@ </element> </optional> <optional> + <element name="domain"> + <attribute name="name"><text/></attribute> + </element> + </optional> + <optional>  <!-- FIXME: address, netmask and the start and end of the ranges @@ -63,7 +69,15 @@ <attribute name="end"><text/></attribute> </element> </zeroOrMore> + <zeroOrMore> + <element name="host"> + <attribute name="mac"><text/></attribute> + <attribute name="name"><text/></attribute> + <attribute name="ip"><text/></attribute> + </element> + </zeroOrMore> </element> </element> </optional> + </interleave> </element> -- 1.6.3.2

3 2

[libvirt] [PATCH 0/1] Fix pool create when pool already exists
by David Allan 02 Jul '09

02 Jul '09

When storagePoolCreate is called to define a pool that already exists, it mistakenly destroys the existing pool. This patch fixes the problem. Dave

5 8

[libvirt] Patch to include arm variants in virsh capabilities
by C.J. Adams-Collier 02 Jul '09

02 Jul '09

Hey folks, I got an android and wanted to set up an armel debian vm to test out some code. I had to launch it directly with qemu-system-arm, though, since virsh didn't have an arm option to select. This is a patch against the debian version of the source after applying debian-specific changes. If you'd like a patch against mainline, I'd be willing to do that. http://karma.colliertech.org/~cjac/tmp/add-arm.patch Cheers, C.J.

2 1

[libvirt] [PATCH] Fix node dumpxml infinite loop
by Cole Robinson 01 Jul '09

01 Jul '09

With current git, doing: 'virsh nodedev-dumpxml computer' locks up the daemon. The list iteration in update_caps was only happening conditionally: if that condition wasn't met, we loop forever. - Cole

3 2

[libvirt] PATCH: Opennebula Documentation updates
by "Abel Míguez Rodríguez" 01 Jul '09

01 Jul '09

Hi, here are some changes to apply at the ONE Documentation, Thanks Abel Miguez Rodriguez ---- Distributed System Architecture Group (http://dsa-research.org) GridWay, http://www.gridway.org OpenNEbula, http://www.opennebula.org

2 1

[libvirt] fix for crash in NPIV code
by Dave Allan 01 Jul '09

01 Jul '09

DV found a place in the NPIV code that was freeing the wrong thing in the error case causing a segfault. The patch to fix it follows. Dave diff --git a/src/node_device.c b/src/node_device.c index cd9f0ef..c5b839b 100644 --- a/src/node_device.c +++ b/src/node_device.c @@ -489,8 +489,8 @@ get_wwns(virConnectPtr conn, if (*wwnn == NULL || *wwpn == NULL) { /* Free the other one, if allocated... */ - VIR_FREE(wwnn); - VIR_FREE(wwpn); + VIR_FREE(*wwnn); + VIR_FREE(*wwpn); ret = -1; virReportOOMError(conn); }

2 1

[libvirt] PATCH : Opennebula documentation
by "Abel Míguez Rodríguez" 01 Jul '09

01 Jul '09

Hi, Attached is the OpenNebula driver documentation and a patch. The main Documentation file is "drvone.html.in" along with it a patch that includes: the API supported by the driver, an entry at "Documentation>Drivers" and a link to the documentation at "drivers.hmtl.in" Thanks --- sitemap.html.in.bak 2009-07-01 12:43:53.000000000 +0200 +++ sitemap.html.in 2009-06-30 18:19:44.000000000 +0200 @@ -148,6 +148,10 @@ <a href="drvvbox.html">VirtualBox</a> Driver for VirtualBox </li> + <li> + <a href="drvone.html">OpenNebula</a> + Driver for OpenNebula + </li> </ul> </li> <li> --- drivers.html.in.bak 2009-07-01 14:54:57.000000000 +0200 +++ drivers.html.in 2009-07-01 14:55:33.000000000 +0200 @@ -23,6 +23,7 @@ <li><a href="drvtest.html">Test</a></li> <li><a href="drvopenvz.html">OpenVZ</a></li> <li><a href="drvvbox.html">VirtualBox</a></li> + <li><a href="drvone.html">OpenNebula</a></li> </ul> </body> </html> --- hvsupport.html.in.bak 2009-07-01 12:41:36.000000000 +0200 +++ hvsupport.html.in 2009-07-01 13:02:38.000000000 +0200 @@ -22,6 +22,7 @@ updated on 2008-06-05. <th><a href="drvkvm.html">KVM</a></th> <th><a href="remote.html">Remote</a></th> <th><a href="drvvbox.html">VirtualBox</a></th> + <th><a href="drvone.html">ONE</a></th> </tr> <tr> <td> virConnectClose </td> @@ -31,6 +32,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectGetCapabilities </td> @@ -40,6 +42,7 @@ updated on 2008-06-05. <td> ≥ 0.2.1 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectGetHostname </td> @@ -49,6 +52,7 @@ updated on 2008-06-05. <td> ≥ 0.3.3 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virConnectGetMaxVcpus </td> @@ -58,6 +62,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virConnectGetType </td> @@ -67,6 +72,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectGetURI </td> @@ -76,6 +82,7 @@ updated on 2008-06-05. <td> ≥ 0.3.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectGetVersion </td> @@ -85,6 +92,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectListDefinedDomains </td> @@ -94,6 +102,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectListDomains </td> @@ -103,6 +112,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectNumOfDefinedDomains </td> @@ -112,6 +122,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectNumOfDomains </td> @@ -121,6 +132,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectOpen </td> @@ -130,6 +142,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectOpenAuth </td> @@ -139,6 +152,7 @@ updated on 2008-06-05. <td> </td> <td> </td> <td> </td> + <td> </td> </tr> <tr> <td> virConnectOpenReadOnly </td> @@ -148,6 +162,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainAttachDevice </td> @@ -157,6 +172,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainBlockPeek </td> @@ -166,6 +182,7 @@ updated on 2008-06-05. <td> 0.4.3 </td> <td> x </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainBlockStats </td> @@ -175,6 +192,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.2 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainCoreDump </td> @@ -184,6 +202,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainCreate </td> @@ -193,6 +212,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainCreateLinux </td> @@ -202,6 +222,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainDefineXML </td> @@ -211,6 +232,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainDestroy </td> @@ -220,6 +242,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainDetachDevice </td> @@ -229,6 +252,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainFree </td> @@ -238,6 +262,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetAutostart </td> @@ -247,11 +272,12 @@ updated on 2008-06-05. <td> ≥ 0.2.1 </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainGetConnect </td> <td> 0.3.0 </td> - <td colspan="5"> not a HV function </td> + <td colspan="6"> not a HV function </td> </tr> <tr> <td> virDomainGetID </td> @@ -261,6 +287,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetInfo </td> @@ -270,6 +297,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetMaxMemory </td> @@ -279,6 +307,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainGetMaxVcpus </td> @@ -288,6 +317,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainGetName </td> @@ -297,6 +327,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetOSType </td> @@ -306,6 +337,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetSchedulerParameters </td> @@ -315,6 +347,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainGetSchedulerType </td> @@ -324,6 +357,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainGetUUID </td> @@ -333,6 +367,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetUUIDString </td> @@ -342,6 +377,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetVcpus </td> @@ -351,6 +387,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainInterfaceStats </td> @@ -360,6 +397,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.2 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainGetXMLDesc </td> @@ -369,6 +407,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainLookupByID </td> @@ -378,6 +417,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainLookupByName </td> @@ -387,6 +427,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainLookupByUUID </td> @@ -396,6 +437,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainLookupByUUIDString </td> @@ -405,6 +447,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainMigrate </td> @@ -414,6 +457,7 @@ updated on 2008-06-05. <td> x </td> <td> 0.3.2 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainPinVcpu </td> @@ -423,6 +467,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainReboot </td> @@ -432,6 +477,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainRestore </td> @@ -441,6 +487,8 @@ updated on 2008-06-05. <td> ≥ 0.3.2 </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> + </tr> <tr> <td> virDomainResume </td> @@ -450,6 +498,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainSave </td> @@ -459,6 +508,7 @@ updated on 2008-06-05. <td> ≥ 0.3.2 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainSetAutostart </td> @@ -468,6 +518,7 @@ updated on 2008-06-05. <td> ≥ 0.2.1 </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainSetMaxMemory </td> @@ -476,6 +527,7 @@ updated on 2008-06-05. <td> x </td> <td> x </td> <td> ≥ 0.3.0 </td> + <td> x </td> </tr> <tr> <td> virDomainSetMemory </td> @@ -485,6 +537,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainSetSchedulerParameters </td> @@ -494,6 +547,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainSetVcpus </td> @@ -503,6 +557,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainShutdown </td> @@ -512,6 +567,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainSuspend </td> @@ -521,6 +577,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainUndefine </td> @@ -530,17 +587,18 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virGetVersion </td> <td> All </td> <td> All </td> - <td colspan="4"> Returns -1 if HV unsupported. </td> + <td colspan="5"> Returns -1 if HV unsupported. </td> </tr> <tr> <td> virInitialize </td> <td> 0.1.0 </td> - <td colspan="5"> not a HV function </td> + <td colspan="6"> not a HV function </td> </tr> <tr> <td> virDomainMemoryPeek </td> @@ -550,6 +608,7 @@ updated on 2008-06-05. <td> 0.4.3 </td> <td> x </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virNodeGetInfo </td> @@ -559,6 +618,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virNodeGetFreeMemory </td> @@ -568,6 +628,7 @@ updated on 2008-06-05. <td> x </td> <td> x </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virNodeGetCellsFreeMemory </td> @@ -577,6 +638,7 @@ updated on 2008-06-05. <td> x </td> <td> x </td> <td> x </td> + <td> x </td> </tr> </table> <h3>Network functions</h3> Abel Miguez Rodriguez ---- Distributed System Architecture Group (http://dsa-research.org) GridWay, http://www.gridway.org OpenNEbula, http://www.opennebula.org

3 2

[libvirt] libvirt 0.6.4: Confusing error message during virDomainRestore() if network not started
by Charles Duffy 01 Jul '09

01 Jul '09

Howdy, 'yall -- I found myself scratching my head for a few minutes trying to start a VM image via virDomainRestore(). Looking through the header definition in the XML, it read as follows: <interface type="network"> <mac address="00:15:3d:49:ec:0e"/> <source network="fvte-MIXED-DEFAULT"/> <target dev="vnet3"/> <model type="e1000"/> </interface> ...and on trying to do a virDomainRestore(), it exited with the following: Traceback (most recent call last): File "/usr/bin/fvte", line 8, in <module> load_entry_point('fvte==1.0', 'console_scripts', 'fvte')() File "/local/home-aux/cduffy/public_git/fvte/src/m1/fvte/cli.py", line 1838, in main cli.cmdloop() File "/opt/python25/lib/python2.5/cmd.py", line 142, in cmdloop stop = self.onecmd(line) File "/local/home-aux/cduffy/public_git/fvte/src/m1/fvte/cli.py", line 1791, in onecmd cmd.Cmd.onecmd(self, c) File "/opt/python25/lib/python2.5/cmd.py", line 219, in onecmd return func(arg) File "/local/home-aux/cduffy/public_git/fvte/src/m1/fvte/cli.py", line 1538, in do_mode self._vmm.vh_set_runmode(name, desired) File "/local/home-aux/cduffy/public_git/fvte/src/m1/fvte/vmmanip.py", line 324, in vh_set_runmode succp = (0 == virt['connect'].restore(ramfile)) File "/opt/python25/lib/python2.5/site-packages/libvirt.py", line 1224, in restore if ret == -1: raise libvirtError ('virDomainRestore() failed', conn=self) libvirt.libvirtError: internal error Failed to add tap interface 'vnet%d' to bridge 'fvtebr0' : No such device The actual issue was that the fvte-MIXED-DEFAULT network was not running, and an appropriate "virsh net-start" allowed the domain to restore correctly; detecting this condition and providing a clearer error message would probably be a Good Thing.

1 0

[libvirt] Patch to include arm variants in virsh capabilities
by C.J. Adams-Collier 01 Jul '09

01 Jul '09

Hey folks, I got an android and wanted to set up an armel debian vm to test out some code. I had to launch it directly with qemu-system-arm, though, since virsh didn't have an arm option to select. This is a patch against the debian version of the source after applying debian-specific changes. If you'd like a patch against mainline, I'd be willing to do that. http://karma.colliertech.org/~cjac/tmp/add-arm.patch Cheers, C.J.

1 0

[libvirt] While connecting through xen+ssh, virConnectClose doesn't close the connection
by Alexandru Nedelcu 01 Jul '09

01 Jul '09

Hi, I'm trying to create a Perl script with Sys::Virt (perl bindings). I'm also using Virsh for testing / experimenting, so this is in no way related to my Perl script (I mentioned it because there might be a sollution that I could use / implement). When connecting to libvirtd using a xen+ssh// connection, it connects, libvirt commands are executing, but on virsh "quit" (or when my script terminates), the connection is blocked. It bothers me because my script doesn't terminate. While running with LIBVIRT_DEBUG=1 I get the following messages: 14:30:51.086: debug : virDomainFree:1893 : domain=0x8791ff8 14:30:51.086: debug : virUnrefDomain:367 : unref domain 0x8791ff8 malcolm 1 14:30:51.086: debug : virReleaseDomain:325 : release domain 0x8791ff8 malcolm 14:30:51.087: debug : virReleaseDomain:337 : unref connection 0x87308a0 3 14:30:51.087: debug : virDomainFree:1893 : domain=0x8791f28 14:30:51.087: debug : virUnrefDomain:367 : unref domain 0x8791f28 Domain-0 1 14:30:51.087: debug : virReleaseDomain:325 : release domain 0x8791f28 Domain-0 14:30:51.087: debug : virReleaseDomain:337 : unref connection 0x87308a0 2 14:30:51.087: debug : virConnectClose:1203 : conn=0x87308a0 14:30:51.087: debug : call:6947 : Doing call 2 (nil) 14:30:51.087: debug : call:7017 : We have the buck 2 0x8796f68 0x8796f68 14:30:51.090: debug : processCallRecvLen:6605 : Got length, now need 28 total (24 more) 14:30:51.090: debug : processCalls:6873 : Giving up the buck 2 0x8796f68 (nil) 14:30:51.090: debug : call:7048 : All done with our call 2 (nil) 0x8796f68 Is this normal? Thanks,

1 0

[libvirt] PATCH : Opennebula, adding xen i686 domain capability and updating some error messages
by "Abel Míguez Rodríguez" 01 Jul '09

01 Jul '09

Hi, this patch uses "OPERATION_INVALID" error instead "OPERATION_FAILED" error where should be used, also adds a missing capability, defining Xen i686 domains. Thanks for the patches, --- one_driver.c.bak 2009-06-30 15:02:28.000000000 +0200 +++ one_driver.c 2009-06-30 15:02:29.000000000 +0200 @@ -505,7 +505,7 @@ static int oneDomainShutdown(virDomainPt ret= 0; goto return_point; } - oneError(dom->conn, dom, VIR_ERR_OPERATION_FAILED, + oneError(dom->conn, dom, VIR_ERR_OPERATION_INVALID, _("Wrong state to perform action")); goto return_point; } @@ -541,7 +541,7 @@ static int oneDomainDestroy(virDomainPtr if(c_oneCancel(vm->pid)) { /* VM not running, delete the instance at ONE DB */ if(c_oneFinalize(vm->pid)){ - oneError(dom->conn, dom, VIR_ERR_OPERATION_FAILED, + oneError(dom->conn, dom, VIR_ERR_OPERATION_INVALID, _("Wrong state to perform action")); goto return_point; } @@ -576,11 +576,11 @@ static int oneDomainSuspend(virDomainPtr ret=0; goto return_point; } - oneError(dom->conn, dom, VIR_ERR_OPERATION_FAILED, + oneError(dom->conn, dom, VIR_ERR_OPERATION_INVALID, _("Wrong state to perform action")); goto return_point; } - oneError(dom->conn,dom,VIR_ERR_OPERATION_FAILED, + oneError(dom->conn,dom,VIR_ERR_OPERATION_INVALID, _("domain is not running")); } else { oneError(dom->conn, dom, VIR_ERR_INVALID_DOMAIN, @@ -609,11 +609,11 @@ static int oneDomainResume(virDomainPtr ret=0; goto return_point; } - oneError(dom->conn, dom, VIR_ERR_OPERATION_FAILED, + oneError(dom->conn, dom, VIR_ERR_OPERATION_INVALID, _("Wrong state to perform action")); goto return_point; } - oneError(dom->conn,dom,VIR_ERR_OPERATION_FAILED, + oneError(dom->conn,dom,VIR_ERR_OPERATION_INVALID, _("domain is not paused ")); } else { oneError(dom->conn, dom, VIR_ERR_INVALID_DOMAIN, --- one_conf.c.bak 2009-06-30 15:01:06.000000000 +0200 +++ one_conf.c 2009-06-30 15:00:58.000000000 +0200 @@ -94,6 +94,27 @@ virCapsPtr oneCapsInit(void) { goto no_memory; } + if ((guest = virCapabilitiesAddGuest(caps, + "xen", + "i686", + 32, + NULL, + NULL, + 0, + NULL)) == NULL) + { + goto no_memory; + } + if (virCapabilitiesAddGuestDomain(guest, + "one", + NULL, + NULL, + 0, + NULL) == NULL) + { + goto no_memory; + } + return caps; Abel Miguez Rodriguez ---- Distributed System Architecture Group (http://dsa-research.org) GridWay, http://www.gridway.org OpenNEbula, http://www.opennebula.org

3 4

[libvirt] [PATCH] logging: remove unused level 0
by Amy Griffis 01 Jul '09

01 Jul '09

Some more logging cleanup. Remove all references to log level 0, and replace with VIR_LOG_DEBUG where appropriate. Also change any hard numbers to the corresponding VirLogPriority and add VIR_LOG_DEFAULT for the starting log level. Signed-off-by: Amy Griffis <amy.griffis(a)hp.com --- docs/logging.html.in | 6 ++---- qemud/libvirtd.conf | 5 ++--- qemud/qemud.c | 11 ++++++----- src/logging.c | 10 +++++----- src/logging.h | 2 ++ 5 files changed, 17 insertions(+), 17 deletions(-) diff --git a/docs/logging.html.in b/docs/logging.html.in index 11ea68c..fcd100f 100644 --- a/docs/logging.html.in +++ b/docs/logging.html.in @@ -49,7 +49,6 @@ <ul> <li>log_level: accepts the following values: <ul> - <li>0: no logging at all</li> <li>4: only errors</li> <li>3: warnings and errors</li> <li>2: informations, warnings and errors</li> @@ -84,20 +83,19 @@ </ul> In all cases the x prefix is the minimal level, acting as a filter: <ul> - <li>0: everything</li> <li>1: DEBUG</li> <li>2: INFO</li> <li>3: WARNING</li> <li>4: ERROR</li> </ul> Multiple output can be defined , they just need to be separated by - spaces, e.g.: <code>"3:syslog:libvirtd 0:file:/tmp/libvirt.log"</code> + spaces, e.g.: <code>"3:syslog:libvirtd 1:file:/tmp/libvirt.log"</code> will log all warnings and errors to syslog under the libvirtd ident but also log everything debugging and informations included in the file <code>/tmp/libvirt.log</code> For example setting up the following: <pre>export LIBVIRT_DEBUG=1 -export LIBVIRT_LOG_OUTPUTS="0:file:virsh.log"</pre> +export LIBVIRT_LOG_OUTPUTS="1:file:virsh.log"</pre> and then running virsh will accumulate the logs in the <code>virsh.log</code> file in a way similar to: <pre>14:29:04.771: debug : virInitialize:278 : register drivers diff --git a/qemud/libvirtd.conf b/qemud/libvirtd.conf index 1fd5918..49de466 100644 --- a/qemud/libvirtd.conf +++ b/qemud/libvirtd.conf @@ -269,7 +269,7 @@ # Logging controls # -# Logging level: 0 none, 4 errors, 3 warnings, 2 informations, 1 debug +# Logging level: 4 errors, 3 warnings, 2 informations, 1 debug # basically 1 will log everything possible #log_level = 3 @@ -303,13 +303,12 @@ # x:file:file_path # output to a file, with the given filepath # In all case the x prefix is the minimal level, acting as a filter -# 0: everything # 1: DEBUG # 2: INFO # 3: WARNING # 4: ERROR # -# Multiple output can be defined , they just need to be separated by spaces. +# Multiple output can be defined, they just need to be separated by spaces. # e.g.: # log_outputs="3:syslog:libvirtd" # to log all warnings and errors to syslog under the libvirtd ident diff --git a/qemud/qemud.c b/qemud/qemud.c index b5e3665..da20aa9 100644 --- a/qemud/qemud.c +++ b/qemud/qemud.c @@ -128,7 +128,7 @@ static int sigwrite = -1; /* Signal handler pipe */ static int ipsock = 0; /* -l Listen for TCP/IP */ /* Defaults for logging */ -static int log_level = 3; +static int log_level = VIR_LOG_DEFAULT; static char *log_filters = NULL; static char *log_outputs = NULL; @@ -2499,15 +2499,16 @@ qemudSetLogging(virConfPtr conf, const char *filename) { log_outputs = strdup(debugEnv); } if (!log_outputs) { + char *tmp = NULL; if (godaemon) { - char *tmp = NULL; if (virAsprintf (&tmp, "%d:syslog:libvirtd", log_level) < 0) goto free_and_fail; - virLogParseOutputs (tmp); - VIR_FREE (tmp); } else { - virLogParseOutputs("0:stderr:libvirtd"); + if (virAsprintf(&tmp, "%d:stderr", log_level) < 0) + goto free_and_fail; } + virLogParseOutputs(tmp); + VIR_FREE(tmp); } else { virLogParseOutputs(log_outputs); } diff --git a/src/logging.c b/src/logging.c index fd1d5d4..d13ae0f 100644 --- a/src/logging.c +++ b/src/logging.c @@ -119,7 +119,7 @@ static int virLogNbOutputs = 0; /* * Default priorities */ -static virLogPriority virLogDefaultPriority = VIR_LOG_WARN; +static virLogPriority virLogDefaultPriority = VIR_LOG_DEFAULT; static int virLogResetFilters(void); static int virLogResetOutputs(void); @@ -174,7 +174,7 @@ int virLogStartup(void) { virLogLen = 0; virLogStart = 0; virLogEnd = 0; - virLogDefaultPriority = VIR_LOG_WARN; + virLogDefaultPriority = VIR_LOG_DEFAULT; virLogUnlock(); return(0); } @@ -196,7 +196,7 @@ int virLogReset(void) { virLogLen = 0; virLogStart = 0; virLogEnd = 0; - virLogDefaultPriority = VIR_LOG_WARN; + virLogDefaultPriority = VIR_LOG_DEFAULT; virLogUnlock(); return(0); } @@ -689,7 +689,7 @@ int virLogParseOutputs(const char *outputs) { virSkipSpaces(&cur); while (*cur != 0) { prio= virParseNumber(&cur); - if ((prio < 0) || (prio > 4)) + if ((prio < VIR_LOG_DEBUG) || (prio > VIR_LOG_ERROR)) return(-1); if (*cur != ':') return(-1); @@ -770,7 +770,7 @@ int virLogParseFilters(const char *filters) { virSkipSpaces(&cur); while (*cur != 0) { prio= virParseNumber(&cur); - if ((prio < 0) || (prio > 4)) + if ((prio < VIR_LOG_DEBUG) || (prio > VIR_LOG_ERROR)) return(-1); if (*cur != ':') return(-1); diff --git a/src/logging.h b/src/logging.h index d99bb31..0b9ae79 100644 --- a/src/logging.h +++ b/src/logging.h @@ -77,6 +77,8 @@ typedef enum { VIR_LOG_ERROR, } virLogPriority; +#define VIR_LOG_DEFAULT VIR_LOG_WARN + /** * virLogOutputFunc: * @category: the category for the message

3 3

[libvirt] Upcoming 0.6.5 release and switching the main SCM engine (to git)
by Daniel Veillard 01 Jul '09

01 Jul '09

A couple of things I wanted to raise. - First we have a release 0.6.5 at the end of the week, so we are in bug fix mode, it would be good if people could make a round of testing of the latest CVS/git version or the snapshot at ftp://libvirt.org/libvirt/libvirt-cvs-snapshot.tar.gz The snapshot generation was proken in the previous months but I fixed it today. - Another point is that we use CVS as the SCM, that's historical, that's what I was used to when I created the project but clearly most people now use the git mirror (or mercurial) to generate their patches. I tried to assert how much git was prevalent, at least for patches embedded within the mail content a large majority are git generated: paphio:~/Mail -> tail -100000 libvir | grep "^diff" | wc -l 268 paphio:~/Mail -> tail -100000 libvir | grep "^diff" | grep -- '-git' | wc -l 182 that doesn't account mails which are attached and base64 encoded but I think it's reasonnable to conclude most of people sending patches generated them out of a git tree. CVS certainly show its age, too ! So my plan would be to switch out of CVS and make git the primary SCM, Jim Meyering is already maintaining the current git tree, so the plan would be to create a new main git tree on libvirt.org based on the existing git://git.et.redhat.com/libvirt.git tree, maybe fixing a couple of things in the process, and desactivate the CVS server after a couple of week grace period. I think once the decision is taken it's better to do it earlier than late, and I'm thinking that this could be done earlier next week if Jim schedule allows and there is no objection. That would allow to manage the set of patches for the following release only under git and not need an SCM transition in the course of preparing 0.6.6 (or 0.7.0). - Speaking of the following release, I'm shooting for a slightly smaller development cycle, in order to be able to push the next version in time for Fedora 12 Beta, this means a new release at the end of July, so only a bit more than a couple of weeks for pushing the changes, I really hope we will be able to include a first version of the ESX driver and Power Hyprvisor, if it's the case I think it will be worth bumping the release name to 0.7.0 . Feedback and opinions welcome, I hope git is not too uncontroversial :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

2 1

[libvirt] feature or bug?
by Gene Czarcinski 30 Jun '09

30 Jun '09

Yet another question. I am using the virt-manager GUI. When I begin to define a new guest and attempt to "browse" to specify where the iso image file is, the GUI dialog brings me up in my home directory. But, almost everything associated with libvirt is done as the root user. By default, why isn't the initial directory "/var/lib/libvirt/images"? Gene

2 1

[libvirt] your patence is appreciated
by Gene Czarcinski 30 Jun '09

30 Jun '09

I really hate being a bit of a PITA with all of my question/comments, but I am just trying to use Fedora virtualization in a manner where I can reasonably manage the configuration. I suspect I am not the first ex-VMware user and I will not be the last such user who is trying to use Fedora virtualization in place of VMware. I am very familiar with how guests are "managed" with VMware. I want Fedora (and Linux) virtualization to be a good product. Your patience is appreciated! Gene

2 1

[libvirt] need some help/asdive
by Gene Czarcinski 30 Jun '09

30 Jun '09

Background: I am a newbie to Linux Virtualization. However, I have been using Linux for a long time. After a short time with Slackware, I started with Red Hat Linux 2 and went on to 2.1, 3.0.3, 4, 4.2, 5, 5.2, ..., 8, 9. And then on to Fedora Core 1, 2, ... until I installed Fedora 11 about a month ago. I have also run VMware starting when it first appeared. Initially I used VMware to run Windows. These days I use it to run up to from 25 to 30 guests (between 1 and 5 at the same time) [yes, I have lots of system memory]. Besides a couple of Windows guests, I have some guests supporting both 32 bit (i386) and 64 bit (x86_64) architectures of older releases as well as alternatives such as CentOS -- I use these to build RPMs. Then there are the guests supporting other operating systems such as Solaris and *BSD. Finally, I have a set of test guest that I use for testing stuff which could destroy the operating system or which require a lot of re-booting. All of this in 25 to 30 guests. With Fedora 11, I started by trying VMware-server. Server 1.0.9 (which I used on Fedora 9) looks like much more work to get running ... more or less "a bridge too far". So, I tried server 2.0.2 ... but the client interface changed from a separate GUI application to a browser based interface: 1) this impacts my usage of the firefox browser; 2) it is a buggy implementation; and 3) it is a crappy interface which I do not like. So, I (finally) noticed that Linux in general and Fedora specifically has packages supporting running guests virtually ... so, lets change my "problem sets" and give this a try ... especially when I noticed that it could use the hardware support in my new AMD Phenom II 940 processor. Before getting into my specific questions/problem, let me describe how my systems are set up. First of all, I have a basic rule: "don't screw with a working system." Therefore, on each of my systems I have at least two root partitions defined -- one for the current (working) system and one for the next (new) system [these days it is actually a /boot partition with root being on a striped logical volume]. I also have a small (think minimal install) partition with Fedora to serve as a boot selector (using chainloader), as something to to define striped logical volumes, and to be there for "emergency" maintenance. Guys, this works for me and always doing fresh installs saves on other headaches. Implicit in the above is that I put all of my data and my /home into separate partitions or logical volumes. One of these are my VMware guest systems. Now VMware puts all of the files (configuration, disk image, etc.) associated a guest under a separate directory. Fedora virtualization does not do this and separation is something I need so that I can easily move to a new version of the operating system such as when Fedora 12 becomes available in November. Questions/problems: My first question: it appears to me that a guest is defined by two things -- a configuration file in /etc/libvirt/qemu and one or more disk images in /var/lib/libvirt/images ... is this it or are there other files I need to consider? My second question concerns the location of the disk images: what is the "best practical way" to move these out of the root partition? I have come up with these different approaches which could/may work: 1. change the "path" value in /etc/libvirt/storage/default.xml to point to a directory in a different partition. 2. Use a /etc/fstab entry to "bind mount" a directory in a separate partition onto /var/lib/libvirt/images 3. Just use an /etc/fstab entry to mount a partition on /var/lib/libvirt/images or, perhaps, on /var/lib/libvirt. [This could be done during system installation] OK, any comments on these?? I can live with changing some configuration files, I can live with copying guest configuration files between systems, I CANNOT live with the disk image files being put into the root partition. Before jumping "whole hog" into using Fedora Virtualization in place of VMware, I need to be able to live with the result. Figure 30 guest virtuals with 10GB of virtual disk each, that is 300GB. I have that space but not for every root partition on my system! Comment: It sure would be nice if Fedora Virtualization put all files related to a guest under a single directory the way VMware does. Comment: It sure would be nice if there was some system-wide configuration parameter that defined where virtualization files went. Right now, as a newbie, I am using the virt-manage GUI interface. I am studying the command-line programs to see what they offer me. So far, I like what I see in Fedora Virtualization but I need to address how things will be practically managed sooner rather than later. Any help appreciated. Gene

2 4

[libvirt] PATCH: Remove unused Open Nebula code, fix potential missing NULL terminator
by Daniel P. Berrange 30 Jun '09

30 Jun '09

This patch removes a bunch of unused Open Nebula code which has a number of flaws. It also fixes handling of a strncpy() call to ensure there is a NULL terminator in the copied string. And finally it makes a couple of strings be 'const' since they're never changed Daniel Index: src/opennebula/one_client.c =================================================================== RCS file: /data/cvs/libvirt/src/opennebula/one_client.c,v retrieving revision 1.1 diff -u -p -r1.1 one_client.c --- src/opennebula/one_client.c 24 Jun 2009 17:32:56 -0000 1.1 +++ src/opennebula/one_client.c 30 Jun 2009 11:05:12 -0000 @@ -33,16 +33,9 @@ void c_oneStart() xmlrpc_client_init2(&one_client.env, XMLRPC_CLIENT_NO_FLAGS, "OpenNebula API Client", "1.2", NULL, 0); - one_client.error=0; - -#ifdef ONED_PORT - one_client.url=(char *)malloc(64); - snprintf(one_client.url, 63, "http://localhost:%d/RPC2", ONED_PORT); -#else - one_client.url=(char *)"http://localhost:2633/RPC2"; -#endif - - one_client.session=(char *)"one-session"; + one_client.error = 0; + one_client.url = "http://localhost:2633/RPC2"; + one_client.session = "one-session"; }; @@ -94,35 +87,6 @@ int c_oneMigrate(int vmid, int hid, int return c_oneReturnCode(resultP); } -int c_oneAllocate(char* template_file) -{ - int file; - int size; - int bytes_read; - char *file_text; - int return_code; - - file=open(template_file, O_RDONLY); - size=lseek(file, 0, SEEK_END); - lseek(file, 0, SEEK_SET); - - file_text=(char *)malloc(size+1); - bytes_read=read(file, file_text, size); - close(file); - - if(bytes_read==size) { - file_text[size]=0; - - return_code=c_oneAllocateTemplate(file_text); - free(file_text); - - return return_code; - } else { - free(file_text); - return -1; - } -} - int c_oneAllocateTemplate(char* vm_template) { xmlrpc_value *resultP; @@ -222,6 +186,7 @@ int c_oneVmInfo(int vmid, char* ret_info if( return_code ) { strncpy(ret_info, return_string, length-1); + ret_info[length-1] = '\0'; xmlrpc_DECREF(resultP); free(return_string); @@ -241,9 +206,6 @@ void c_oneFree() { xmlrpc_env_clean(&one_client.env); xmlrpc_client_cleanup(); -#ifdef ONE_PORT - free(one_client.url); -#endif } Index: src/opennebula/one_client.h =================================================================== RCS file: /data/cvs/libvirt/src/opennebula/one_client.h,v retrieving revision 1.1 diff -u -p -r1.1 one_client.h --- src/opennebula/one_client.h 24 Jun 2009 17:32:56 -0000 1.1 +++ src/opennebula/one_client.h 30 Jun 2009 11:05:12 -0000 @@ -24,8 +24,8 @@ struct _oneClient { xmlrpc_env env; - char *url; - char *session; + const char *url; + const char *session; char *error; }; @@ -38,8 +38,6 @@ int c_oneDeploy(int vmid, int hid); int c_oneMigrate(int vmid, int hid, int flag); -int c_oneAllocate(char* template_file); - int c_oneAllocateTemplate(char* vm_template); int c_oneAction(int vmid,char* action); -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1

[libvirt] problem: deleting a guest
by Gene Czarcinski 30 Jun '09

30 Jun '09

I defined a new guest using the virt-manager GUI ... everything fine so far. I then decided that my definition was not correct (or I could be done with that guest) and could not find a way to delete the guest. OK, quit virt-manager, delete the configuration and disk-image files for the guest, restart libvirtd, and then start virt-manager again. The guest definition (according to virt-manager) was still there. I finnaly got rid of the definition by re-booting the system. THIS IS NOT SATISFACTORY! IMHO, I should be able to: 1. Define a new guest. 2. Delete the definition of a new guest but not the related configuration and disk-image files. 3. Delete the guest definition and the related configuration and disk image files but NOT and CD/DVD image files external to /var/lib/libvirt/images. 4. Import new guests which were created as clones, copied from another host, or convert created from something like VMware. Not it is certainly possible (or even likely) that I h\just do not understand how to do things yet. Or, this could be a bug. Or, this could be a lack of capabilities. Help appreciated in pointing me in the right direction. I will bugzilla where appropriate. Gene

3 3

[libvirt] How does libvirt 0.6.3 load kvm driver
by Jason Wong 30 Jun '09

30 Jun '09

Dear all, I found that libvirt 0.6.3 seems does not load KVM driver while libvirt 0.3.3 does. Situation description: I am using CentOS 5.3, and the kernel I used is 2.6.30. I downloaded the kernel from kernel.org andcompile it. KVM was compiled as a module. libvirt: libvirt 0.6.3, released by Eucalyptus(a cloud computing infrastructure software which supports KVM as well) (1) libvirt 0.6.3 does not load KVM driver After booting the machine with kernel 2.6.30 and probe KVM related module. I started libvirtd 0.6.3 and set LD_LIBRARY_PATH to "$LIBVIRT_063_HOME/lib:$LIBVIRT_063_HOME/usr/lib:$LD_LIBRARY_PATH". I found that I am not able to connect to libvirtd using "virsh --connect qemu:///system"(the virsh used is virsh 0.6.3 that shipped with libvirt 0.6.3), here is the debug message: ======================================= debug message ========================================= 17:41:11.219: debug : virInitialize:290 : register drivers 17:41:11.219: debug : virRegisterDriver:667 : registering Test as driver 0 17:41:11.219: debug : virRegisterNetworkDriver:567 : registering Test as network driver 0 17:41:11.219: debug : virRegisterStorageDriver:598 : registering Test as storage driver 0 17:41:11.219: debug : virRegisterDeviceMonitor:629 : registering Test as device driver 0 17:41:11.219: debug : virRegisterDriver:667 : registering Xen as driver 1 17:41:11.219: debug : vboxRegister:68 : VBoxCGlueInit failed: 0.0.0, errorval=-1 17:41:11.219: debug : virRegisterDriver:667 : registering VBOX as driver 2 17:41:11.219: debug : virConnectOpen:1050 : name=qemu:///system 17:41:11.219: debug : do_open:920 : name "qemu:///system" to URI components: scheme qemu opaque (null) authority (null) server (null) user (null) port 0 path /system 17:41:11.219: debug : do_open:930 : trying driver 0 (Test) ... 17:41:11.219: debug : do_open:936 : driver 0 Test returned DECLINED 17:41:11.219: debug : do_open:930 : trying driver 1 (Xen) ... 17:41:11.219: debug : do_open:936 : driver 1 Xen returned DECLINED 17:41:11.219: debug : do_open:930 : trying driver 2 (VBOX) ... 17:41:11.219: debug : do_open:936 : driver 2 VBOX returned DECLINED libvir: error : could not connect to qemu:///system 17:41:11.219: debug : virUnrefConnect:210 : unref connection 0x60dd00 1 17:41:11.219: debug : virReleaseConnect:171 : release connection 0x60dd00 libvirt error: could not connect to qemu:///system (code=5) error: failed to connect to hypervisor ================================end of debug message ========================================= It seems that libvirt 0.6.3 does not load QEMU driver. (2) libvirt 0.3.3 does load KVM driver However, when I run the command "lsmod | grep kvm". I found KVM module was present: ================================= result of lsmod ============================================== [root@node2 ~]# lsmod | grep kvm kvm_intel 46664 0 kvm 166224 1 kvm_intel [root@node2 ~]# ================================= end of result of lsmod ========================================= I stopped libvirtd 0.6.3 and then started libvirtd 0.3.3(the one shipped with CentOS 5.3). The virtual machine manager works well and I can use "virsh --connect qemu:///system"(the virsh used is virsh 0.3.3 that shipped with CentOS 5.3) to connect to libvirtd. I dig into libvirt source code. I found that in libvirt 0.3.3: There is qemudRegister() in libvirt.c. I think this function call is responsible for loading qemu(kvm) driver. And in libvirt 0.6.3: I cannot found qemudRegister() or virDriverLoadModule("qemu") in the source code. My question is: Does libvirt 0.6.3 support KVM? If yes, how does it load KVM driver? I want to find out why libvirt 0.3.3 works well while libvirt 0.6.3 does not work in my computer. Thanks. -- Jason Wong System engineer Cluster Technology Limited Email: hcwong(a)clustertech.com Direct Line: (852) 2655-6129 Tel: (852) 2655-6100 Fax: (852) 2994-2101 Website: www.clustertech.com ------------------------------ ************************************************************************** The information and attachment contained in this e-mail originating from Cluster Technology Limited is confidential and intended solely for the specified addressees. If you have received this email in error, please do not read, copy, distribute, disclose or use any information of this email in any way and please immediately notify the sender and delete this email. Thank you for your cooperation. **************************************************************************

2 4

[libvirt] hooking a physical nic to a bridge with net-create
by Shahar Klein 29 Jun '09

29 Jun '09

Hi I trying to set up a network configuration using libvirt The setup is: 1. a VM using virtio using a tap device connected to a bridge device 2. on the host side eth0 added to the same bridge device(without ip) using libvirt application (say virsh) I want to launch this set up: virsh net-create for the second part virsh create for the first part(tap, virtio, vm etc) I can set the first part(vm, tap, virtio) using the domain xml but I'm also interested in XMLing the second part and net-create it. I tried but only suceeded in creating the bridge Is it possible? am I missing somthing? Thanks in advance

4 7

[libvirt] HACKING file on website
by Daniel P. Berrange 29 Jun '09

29 Jun '09

FYI, I just committed a patch to add the contents of the 'HACKING' file to the website, under the section 'Documentation -> Internals -> Contributor Guidelines No content changes from HACKING, just html-ized existing content. Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

1 0

[libvirt] identi.ca micro-blogging group for libvirt & related apps
by Daniel P. Berrange 29 Jun '09

29 Jun '09

Micro-blogging is very popular these days and I know a number of people working on / with libvirt are using twitter/identi.ca So I decided it was worth creating a libvirt group on identi.ca for targetting notices relating to libvirt and any apps built using libvirt. You can find it here http://identi.ca/group/libvirt Any posting you make containing the magic word '!libvirt' will appear in the group page. Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

1 0

[libvirt] [PATCH] Fixing issues in re-detection of transient VMs
by Federico Simoncelli 29 Jun '09

29 Jun '09

Re-detection of transient VMs had two issues described in bugs 507304 and 507537: https://bugzilla.redhat.com/show_bug.cgi?id=507304 Summary: After a migration the domain status is saved as "paused" and it is not updated to "running". A following libvirtd restart will detect the vm as "paused" (instead of "running"). https://bugzilla.redhat.com/show_bug.cgi?id=507537 Summary: Destroying a transient re-detected domain leaves the domain defined (instead of completely remove it). Patches in attachment (and available in the bug report). -- Federico Simoncelli.

2 2

[libvirt] [PATCH] don't break on libnuma failures
by Daniel Veillard 28 Jun '09

28 Jun '09

Another patch hanging in bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=506590 sometimes libnuma can't handle some topologies, but those failures should not completely break libvirt, patch by Dan Berrange. Look sane to me, fixes the main problem for the reporter, so I applied and commited it, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

2 1

[libvirt] unchecked malloc+syscall uses
by Jim Meyering 28 Jun '09

28 Jun '09

I was looking through recent changes and spotted two potential NULL-dereferences in this change set: http://git.et.redhat.com/?p=libvirt.git;a=commitdiff;h=70c01b4c1adea75e9 In src/opennebula/one_client.c: + one_client.url=(char *)malloc(64); + snprintf(one_client.url, 63, "http://localhost:%d/RPC2", ONED_PORT); +#else + one_client.url=(char *)"http://localhost:2633/RPC2"; +#endif -- + file_text=(char *)malloc(size+1); + bytes_read=read(file, file_text, size); + close(file); + + if(bytes_read==size) { Perhaps of more immediate concern, these syscalls are not checked for failure: + file=open(template_file, O_RDONLY); + size=lseek(file, 0, SEEK_END); + lseek(file, 0, SEEK_SET); and same for the "read" syscall above. Note, this is just the result of a few minutes cursory review.

2 1

[libvirt] More then one pci device possible with libvirt and pci passthrough?
by Mirko Raasch 28 Jun '09

28 Jun '09

Hi, i want to use more then one pci card in my debian guest. But when i start the guest, the log says: libvirtd: 15:44:55.459: warning : pciTrySecondaryBusReset:483 : Other devices on bus with 0000:05:01.0, not doing bus reset With "/usr/bin/qemu-system-x86_64 -m 512 -name test -hda /media/vm/test.img -boot c -vnc :2 -k de -pcidevice host=05:01.0 -pcidevice host=05:02.0 -pcidevice host=05:03.0" there seems to be no problems. How can i start my guest with three pci devices passed through and libvirt? My hostdev section in the xml looks like this: <hostdev mode='subsystem' type='pci' managed='yes'> <source> <address domain='0x0000' bus='0x05' slot='0x01' function='0x0'/> </source> </hostdev> <hostdev mode='subsystem' type='pci' managed='yes'> <source> <address domain='0x0000' bus='0x05' slot='0x02' function='0x0'/> </source> </hostdev> <hostdev mode='subsystem' type='pci' managed='yes'> <source> <address domain='0x0000' bus='0x05' slot='0x03' function='0x0'/> </source> </hostdev> Greetings Mirko

1 0

[libvirt] Can't scale XP on remote
by sean darcy 27 Jun '09

27 Jun '09

Just starting out with an XP guest on Fedora 11 kvm. I'm using virt-manager to connect from a laptop. Server: kernel-2.6.29.4-167.fc11.x86_64 qemu-*-0.10.50-6.kvm86.fc11.x86_64 libvirt-0.6.4-2.fc11.x86_64 On the laptop: virt-manager-0.7.0-5.fc11.i586 libvirt-0.6.2-11.fc11.i586 The console comes, and XP runs fine. But, screen is scaled too large vertically for my laptop screen which is 1280x800. Only with fullscreen can I see the bottom menu bar. I would have assumed I could change the size of the screen (even if not the aspect ratio), but I can't. Am I doing something wrong, or is this just The Way Things Are? sean

3 6

[libvirt] [PATCH] avoid dumpXML segfault with recent Xen (3.4.0)
by Daniel Veillard 26 Jun '09

26 Jun '09

This is basically the patch by Sascha at https://bugzilla.redhat.com/show_bug.cgi?id=503254 with a couple of cleanups. I think it's low risk, and avoid a crash so I commited it. Basically ths SXPR syntax changed from (type vnc) to (vnc 1) for VNC vfb devices, and assuming something similar for sdl. The code checks first for type then backoff for vnc/sdl so I think this is backward compatible. Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

2 1

[libvirt] [PATCH 3/5] disk geometry
by Henrik Persson 26 Jun '09

26 Jun '09

Reads the disk geometry to be able to align disk partitions on cylinder boundries. Msdos partition tables really like this stuff.

4 3

[libvirt] [PATCH 0/5] Create storage volumes with disk backend
by Henrik Persson 26 Jun '09

26 Jun '09

Hi, These patches make it possible to create storage volumes when having a disk as backend. As sent in earlier mail, it does not handle LVM and RAID partition currently. /Henrik

2 1

[libvirt] [PATCH] Don't disable all logging with --disable-debug
by Amy Griffis 26 Jun '09

26 Jun '09

This patch changes the automake conditional for debugging to disable only the debug output, not the entire logging module. Since the logging symbols are always visible now, I moved them to libvirt_private.syms and got rid of libvirt_debug.syms. I noticed that debugFlag wasn't being used anymore, so I removed that too. There was some code in __virExec where if you called with NULLs for childout and childerr, it would conditionally set the fds to either -1 or the /dev/null fd depending on ENABLE_DEBUG. I'm not sure why the difference, but it seemed safe to remove the entire conditional section since either setting is effectively treated the same way in the following code. Signed-off-by: Amy Griffis <amy.griffis(a)hp.com> diff --git a/src/Makefile.am b/src/Makefile.am index f65e7ad..23a1843 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -498,10 +498,6 @@ EXTRA_DIST += \ # symbols aren't present at all. # -if ENABLE_DEBUG -USED_SYM_FILES += libvirt_debug.syms -endif - if WITH_DRIVER_MODULES USED_SYM_FILES += libvirt_driver_modules.syms endif @@ -517,7 +513,6 @@ endif EXTRA_DIST += \ libvirt_public.syms \ libvirt_private.syms \ - libvirt_debug.syms \ libvirt_driver_modules.syms \ libvirt_bridge.syms \ libvirt_linux.syms diff --git a/src/libvirt.c b/src/libvirt.c index bf49018..bcb707e 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -256,9 +256,7 @@ winsock_init (void) int virInitialize(void) { -#ifdef ENABLE_DEBUG char *debugEnv; -#endif if (initialized) return(0); @@ -269,7 +267,6 @@ virInitialize(void) virRandomInitialize(time(NULL) ^ getpid())) return -1; -#ifdef ENABLE_DEBUG debugEnv = getenv("LIBVIRT_DEBUG"); if (debugEnv && *debugEnv && *debugEnv != '0') { if (STREQ(debugEnv, "2") || STREQ(debugEnv, "info")) @@ -287,7 +284,6 @@ virInitialize(void) debugEnv = getenv("LIBVIRT_LOG_OUTPUTS"); if (debugEnv) virLogParseOutputs(debugEnv); -#endif DEBUG0("register drivers"); @@ -1055,13 +1051,11 @@ do_open (const char *name, /* Secondary driver for storage. Optional */ for (i = 0; i < virStorageDriverTabCount; i++) { res = virStorageDriverTab[i]->open (ret, auth, flags); -#ifdef ENABLE_DEBUG DEBUG("storage driver %d %s returned %s", i, virStorageDriverTab[i]->name, res == VIR_DRV_OPEN_SUCCESS ? "SUCCESS" : (res == VIR_DRV_OPEN_DECLINED ? "DECLINED" : (res == VIR_DRV_OPEN_ERROR ? "ERROR" : "unknown status"))); -#endif if (res == VIR_DRV_OPEN_ERROR) { if (0 && STREQ(virStorageDriverTab[i]->name, "remote")) { virLibConnWarning (NULL, VIR_WAR_NO_STORAGE, diff --git a/src/libvirt_debug.syms b/src/libvirt_debug.syms deleted file mode 100644 index 1742a0b..0000000 --- a/src/libvirt_debug.syms +++ /dev/null @@ -1,19 +0,0 @@ -# -# These symbols are dependent upon --enable-debug. -# - - -# libvirt_internal.h -debugFlag; - - -# logging.h -virLogMessage; -virLogSetDefaultPriority; -virLogDefineFilter; -virLogDefineOutput; -virLogParseFilters; -virLogParseOutputs; -virLogStartup; -virLogShutdown; -virLogReset; diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 309d7f9..3958d9b 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -192,6 +192,18 @@ virRegisterStorageDriver; virRegisterDeviceMonitor; +# logging.h +virLogMessage; +virLogSetDefaultPriority; +virLogDefineFilter; +virLogDefineOutput; +virLogParseFilters; +virLogParseOutputs; +virLogStartup; +virLogShutdown; +virLogReset; + + # memory.h virAlloc; virAllocN; diff --git a/src/logging.c b/src/logging.c index 83e07cc..fd1d5d4 100644 --- a/src/logging.c +++ b/src/logging.c @@ -39,9 +39,6 @@ #include "util.h" #include "threads.h" -#ifdef ENABLE_DEBUG -int debugFlag = 0; - /* * Macro used to format the message as a string in virLogMessage * and borrowed from libxml2 (also used in virRaiseError) @@ -793,5 +790,4 @@ int virLogParseFilters(const char *filters) { } return(ret); } -#endif /* ENABLE_DEBUG */ diff --git a/src/logging.h b/src/logging.h index 7ea8935..d99bb31 100644 --- a/src/logging.h +++ b/src/logging.h @@ -32,22 +32,17 @@ #ifdef ENABLE_DEBUG #define VIR_DEBUG_INT(category, f, l, fmt,...) \ virLogMessage(category, VIR_LOG_DEBUG, f, l, 0, fmt, __VA_ARGS__) +#else +#define VIR_DEBUG_INT(category, f, l, fmt,...) \ + do { } while (0) +#endif /* !ENABLE_DEBUG */ + #define VIR_INFO_INT(category, f, l, fmt,...) \ virLogMessage(category, VIR_LOG_INFO, f, l, 0, fmt, __VA_ARGS__) #define VIR_WARN_INT(category, f, l, fmt,...) \ virLogMessage(category, VIR_LOG_WARN, f, l, 0, fmt, __VA_ARGS__) #define VIR_ERROR_INT(category, f, l, fmt,...) \ virLogMessage(category, VIR_LOG_ERROR, f, l, 0, fmt, __VA_ARGS__) -#else -#define VIR_DEBUG_INT(category, f, l, fmt,...) \ - do { } while (0) -#define VIR_INFO_INT(category, f, l, fmt,...) \ - do { } while (0) -#define VIR_WARN_INT(category, f, l, fmt,...) \ - do { } while (0) -#define VIR_ERROR_INT(category, f, l, fmt,...) \ - do { } while (0) -#endif /* !ENABLE_DEBUG */ #define VIR_DEBUG(fmt,...) \ VIR_DEBUG_INT("file." __FILE__, __func__, __LINE__, fmt, __VA_ARGS__) @@ -108,8 +103,6 @@ typedef int (*virLogOutputFunc) (const char *category, int priority, */ typedef void (*virLogCloseFunc) (void *data); -#ifdef ENABLE_DEBUG - extern int virLogSetDefaultPriority(int priority); extern int virLogDefineFilter(const char *match, int priority, int flags); extern int virLogDefineOutput(virLogOutputFunc f, virLogCloseFunc c, @@ -128,18 +121,4 @@ extern void virLogMessage(const char *category, int priority, const char *funcname, long long linenr, int flags, const char *fmt, ...) ATTRIBUTE_FORMAT(printf, 6, 7); -#else /* ENABLE_DEBUG */ - -#define virLogSetDefaultPriority(p) -#define virLogDefineFilter(m, p, f) -#define virLogDefineOutput(func, c, d, p, f) -#define virLogStartup() -#define virLogReset() -#define virLogShutdown() -#define virLogParseFilters(f) -#define virLogParseOutputs(o) -#define virLogMessage(c, p, func, l, f, fmt, __VA_ARGS__) - -#endif /* ENABLE_DEBUG */ - #endif diff --git a/src/util.c b/src/util.c index 8b746f5..408e17a 100644 --- a/src/util.c +++ b/src/util.c @@ -349,10 +349,6 @@ __virExec(virConnectPtr conn, } else { childout = *outfd; } -#ifndef ENABLE_DEBUG - } else { - childout = null; -#endif } if (errfd != NULL) { @@ -380,10 +376,6 @@ __virExec(virConnectPtr conn, } else { childerr = *errfd; } -#ifndef ENABLE_DEBUG - } else { - childerr = null; -#endif } if ((pid = fork()) < 0) {

3 2

[libvirt] [PATCH 0/1] Fix bogus WWNs
by David Allan 26 Jun '09

26 Jun '09

When HBA kernel modules are loaded while libvirt is running, libvirt will often read bogus WWNs from sysfs as at least some modules trigger the HAL event notifying libvirt of adapters' existence before the sysfs info is correct. The following patch causes libvirt to reread the WWNs whenever dumpxml is called so the capability information about the WWNs will be up to date. I pulled the logic to read the WWNs into two separate functions, and the patch is slightly more invasive as a result. The resulting code is smaller and cleaner for it, though, so I think this is the right way to go. (The diff is also very ugly; it should make sense once applied.) Dave

3 3

[libvirt] virStorageVolCreateXMLFrom
by Kenneth Nagin 26 Jun '09

26 Jun '09

I'd like to get a better understanding of the virStorageVolCreateXMLFrom api Its name and signature imply that it is a cloning operation that copies a volume from one location to another. Is this correct? Assuming that the answer is yes I have few other questions: Does it support remote copy of non-shared storage, e.g. from a http server? Is there any thought about adding digest validation check, e.g. with a md5 digest? Is copy-on-write cloning supported in this command? Kenneth Nagin

3 3

[libvirt] [PATCH 5/5] create storage volumes, take 2
by Henrik Persson 26 Jun '09

26 Jun '09

Here is a updated patch that defines a enum for mapping parition code to parted's fs-type. /Henrik

1 0

[libvirt] [PATCH] For comment/critique only - netcf backend for virInterface*.
by Laine Stump 26 Jun '09

26 Jun '09

This is the backend for the interface driver (virInterface*()) that uses netcf. There are a few issues with it: 1) It doesn't yet implement the backend for virConnectListDefinedInterfaces() and virConnectNumOfDefinedInterfaces() (although it does use my patched netcf API to list only active interfaces for virConnectListInterfaces()). (That patch isn't committed to netcf yet, btw; it's functional, but a bit rough and hackish) 2) interfaceLookupByMACString() still uses the old arg convention for ncf_lookup_by_mac_string(), which returned a single interface. That function has been changed to potentially return multiple interfaces. To fully support that, we would need to change the libvirt API. What should we do here? 3) The XML in interfaceDefineXML() isn't validated, although the spot to do it is clearly marked. 4) There's no comment in the place where we could, in the future, transform the XML returned to interfaceGetXMLDesc() by netcf. Currently the two use the same RNG. Since it would be a null transform, and that will only change under our control, that isn't an *immediate* problem, but shouldn't be forgotten. Parts that I'm unsure of: 1) changes to the Makefile, particularly surrounding "DRIVER_MODULES". 2) Is it registered in the proper places? 3) Could it (should it?) be added to other hypervisor drivers? (Currently I only put it in qemud.c) --- qemud/Makefile.am | 4 + qemud/qemud.c | 6 + src/Makefile.am | 16 ++- src/interface_driver.c | 381 ++++++++++++++++++++++++++++++++++++++++++++++++ src/interface_driver.h | 34 +++++ 5 files changed, 440 insertions(+), 1 deletions(-) create mode 100644 src/interface_driver.c create mode 100644 src/interface_driver.h diff --git a/qemud/Makefile.am b/qemud/Makefile.am index 403846a..9f982ba 100644 --- a/qemud/Makefile.am +++ b/qemud/Makefile.am @@ -134,6 +134,10 @@ if WITH_NETWORK libvirtd_LDADD += ../src/libvirt_driver_network.la endif +if WITH_NETCF + libvirtd_LDADD += ../src/libvirt_driver_interface.la +endif + if WITH_NODE_DEVICES libvirtd_LDADD += ../src/libvirt_driver_nodedev.la endif diff --git a/qemud/qemud.c b/qemud/qemud.c index b5e3665..9326ce9 100644 --- a/qemud/qemud.c +++ b/qemud/qemud.c @@ -81,6 +81,9 @@ #ifdef WITH_NETWORK #include "network_driver.h" #endif +#ifdef WITH_NETCF +#include "interface_driver.h" +#endif #ifdef WITH_STORAGE_DIR #include "storage_driver.h" #endif @@ -822,6 +825,9 @@ static struct qemud_server *qemudInitialize(int sigread) { #ifdef WITH_NETWORK networkRegister(); #endif +#ifdef WITH_NETCF + interfaceRegister(); +#endif #ifdef WITH_STORAGE_DIR storageRegister(); #endif diff --git a/src/Makefile.am b/src/Makefile.am index f65e7ad..f5bf1b8 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -154,6 +154,9 @@ ONE_DRIVER_SOURCES = \ NETWORK_DRIVER_SOURCES = \ network_driver.h network_driver.c +INTERFACE_DRIVER_SOURCES = \ + interface_driver.h interface_driver.c + # Storage backend specific impls STORAGE_DRIVER_SOURCES = \ storage_driver.h storage_driver.c \ @@ -381,8 +384,18 @@ libvirt_driver_network_la_SOURCES = $(NETWORK_DRIVER_SOURCES) endif if WITH_NETCF -libvirt_driver_interface_la_CFLAGS = $(NETCF_CFLAGS) libvirt_driver_interface_la_LDFLAGS = $(NETCF_LIBS) +libvirt_driver_interface_la_CFLAGS = $(NETCF_CFLAGS) +if WITH_DRIVER_MODULES +mod_LTLIBRARIES += libvirt_driver_interface.la +else +noinst_LTLIBRARIES += libvirt_driver_interface.la +libvirt_la_LIBADD += libvirt_driver_interface.la +endif +if WITH_DRIVER_MODULES +libvirt_driver_interface_la_LDFLAGS += -module -avoid-version +endif +libvirt_driver_interface_la_SOURCES = $(INTERFACE_DRIVER_SOURCES) endif # Needed to keep automake quiet about conditionals @@ -467,6 +480,7 @@ EXTRA_DIST += \ $(OPENVZ_DRIVER_SOURCES) \ $(VBOX_DRIVER_SOURCES) \ $(NETWORK_DRIVER_SOURCES) \ + $(INTERFACE_DRIVER_SOURCES) \ $(STORAGE_DRIVER_SOURCES) \ $(STORAGE_DRIVER_FS_SOURCES) \ $(STORAGE_DRIVER_LVM_SOURCES) \ diff --git a/src/interface_driver.c b/src/interface_driver.c new file mode 100644 index 0000000..b6cf510 --- /dev/null +++ b/src/interface_driver.c @@ -0,0 +1,381 @@ +/* + * interface_driver.c: backend driver methods to handle physical + * interface configuration using the netcf library. + * + * Copyright (C) 2006-2009 Red Hat, Inc. + * Copyright (C) 2006 Daniel P. Berrange + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * + * Author: Daniel P. Berrange <berrange(a)redhat.com> + */ + +#include <config.h> + +#include <sys/types.h> +#include <sys/poll.h> +#include <dirent.h> +#include <limits.h> +#include <string.h> +#include <stdio.h> +#include <strings.h> +#include <stdarg.h> +#include <stdlib.h> +#include <unistd.h> +#include <errno.h> +#include <sys/utsname.h> +#include <sys/stat.h> +#include <fcntl.h> +#include <signal.h> +#include <paths.h> +#include <pwd.h> +#include <stdio.h> +#include <sys/wait.h> +#include <sys/ioctl.h> +#include <netcf.h> + +#include "virterror_internal.h" +#include "datatypes.h" +#include "interface_driver.h" +#include "driver.h" +#include "event.h" +#include "buf.h" +#include "util.h" +#include "memory.h" +#include "logging.h" + +#define VIR_FROM_THIS VIR_FROM_INTERFACE + +#define interfaceReportError(conn, dom, net, code, fmt...) \ + virReportErrorHelper(conn, VIR_FROM_THIS, code, __FILE__, \ + __FUNCTION__, __LINE__, fmt) + +/* Main driver state */ +struct interface_driver +{ + virMutex lock; + struct netcf *netcf; +}; + + +static void interfaceDriverLock(struct interface_driver *driver) +{ + virMutexLock(&driver->lock); +} + +static void interfaceDriverUnlock(struct interface_driver *driver) +{ + virMutexUnlock(&driver->lock); +} + + +static struct interface_driver *driverState = NULL; + +static virDrvOpenStatus interfaceOpenInterface(virConnectPtr conn, + virConnectAuthPtr auth ATTRIBUTE_UNUSED, + int flags ATTRIBUTE_UNUSED) +{ + if (VIR_ALLOC(driverState) < 0) + { + virReportOOMError(conn); + goto alloc_error; + } + + /* initialize non-0 stuff in driverState */ + if (virMutexInit(&driverState->lock) < 0) + { + /* what error to report? */ + goto mutex_error; + } + + /* open netcf */ + if (ncf_init(&driverState->netcf, NULL) != 0) + { + /* what error to report? */ + goto netcf_error; + } + + conn->interfacePrivateData = driverState; + return 0; + +netcf_error: + if (driverState->netcf) + { + ncf_close(driverState->netcf); + } + virMutexDestroy (&driverState->lock); +mutex_error: + VIR_FREE(driverState); +alloc_error: + return -1; +} + +static int interfaceCloseInterface(virConnectPtr conn) +{ + + if (conn->interfacePrivateData != NULL) + { + struct interface_driver *driver + = (struct interface_driver *)conn->interfacePrivateData; + + /* close netcf instance */ + ncf_close(driver->netcf); + /* destroy lock */ + virMutexDestroy(&driver->lock); + /* free driverState */ + VIR_FREE(driver); + } + conn->interfacePrivateData = NULL; + return 0; +} + +static int interfaceNumInterfaces(virConnectPtr conn) +{ + int count; + struct interface_driver *driver = conn->interfacePrivateData; + + interfaceDriverLock(driver); + count = ncf_num_of_interfaces(driver->netcf, NETCF_FLAG_ACTIVE); + interfaceDriverUnlock(driver); + return count; +} + +static int interfaceListInterfaces(virConnectPtr conn, char **const names, int nnames) +{ + struct interface_driver *driver = conn->interfacePrivateData; + int count; + + interfaceDriverLock(driver); + + count = ncf_list_interfaces(driver->netcf, nnames, names, NETCF_FLAG_ACTIVE); + /* netcf cleans up in the case of errors */ + interfaceDriverUnlock(driver); + + return count; + +} + +static virInterfacePtr interfaceLookupByName(virConnectPtr conn, + const char *name) +{ + struct interface_driver *driver = conn->interfacePrivateData; + struct netcf_if *iface; + virInterfacePtr ret = NULL; + + interfaceDriverLock(driver); + iface = ncf_lookup_by_name(driver->netcf, name); + + if (!iface) { + interfaceReportError(conn, NULL, NULL, VIR_ERR_NO_INTERFACE, + "%s", _("no interface with matching name")); + goto cleanup; + } + + ret = virGetInterface(conn, ncf_if_name(iface), ncf_if_mac_string(iface)); + +cleanup: + ncf_if_free(iface); + interfaceDriverUnlock(driver); + return ret; +} + +static virInterfacePtr interfaceLookupByMACString(virConnectPtr conn, + const char *macstr) +{ + struct interface_driver *driver = conn->interfacePrivateData; + struct netcf_if *iface; + virInterfacePtr ret = NULL; + + interfaceDriverLock(driver); + iface = ncf_lookup_by_mac_string(driver->netcf, macstr); + + if (!iface) { + interfaceReportError(conn, NULL, NULL, VIR_ERR_NO_INTERFACE, + "%s", _("no interface with matching MAC address")); + goto cleanup; + } + + ret = virGetInterface(conn, ncf_if_name(iface), ncf_if_mac_string(iface)); + +cleanup: + ncf_if_free(iface); + interfaceDriverUnlock(driver); + return ret; +} + +static char *interfaceGetXMLDesc(virInterfacePtr ifinfo, + unsigned int flags ATTRIBUTE_UNUSED) +{ + struct interface_driver *driver = ifinfo->conn->interfacePrivateData; + struct netcf_if *iface = NULL; + char *ret = NULL; + + interfaceDriverLock(driver); + iface = ncf_lookup_by_name(driver->netcf, ifinfo->name); + + if (!iface) { + /* May want to check by name here, but probably pointless */ + interfaceReportError(ifinfo->conn, NULL, ifinfo, VIR_ERR_INVALID_INTERFACE, + "%s", _("no interface with matching MAC Address")); + goto cleanup; + } + + ret = ncf_if_xml_desc(iface); + if (!ret) { + interfaceReportError(ifinfo->conn, NULL, ifinfo, VIR_ERR_INVALID_INTERFACE, + "%s", _("could not get interface XML description")); + goto cleanup; + } + +cleanup: + ncf_if_free(iface); + interfaceDriverUnlock(driver); + return ret; +} + +static virInterfacePtr interfaceDefineXML(virConnectPtr conn, + const char *xml, + unsigned int flags ATTRIBUTE_UNUSED) +{ + struct interface_driver *driver = conn->interfacePrivateData; + struct netcf_if *iface = NULL; + virInterfacePtr ret = NULL; + + interfaceDriverLock(driver); + + /* + * This is where we will want to validate the XML, and possibly + * transform it before sending it on. + */ + + iface = ncf_define(driver->netcf, xml); + if (!iface) { + interfaceReportError(conn, NULL, NULL, VIR_ERR_INVALID_INTERFACE, + "%s", _("failed to define new interface from XML")); + goto cleanup; + } + + ret = virGetInterface(conn, ncf_if_name(iface), ncf_if_mac_string(iface)); + +cleanup: + ncf_if_free(iface); + interfaceDriverUnlock(driver); + return ret; +} + +static int interfaceUndefine(virInterfacePtr ifinfo) { + struct interface_driver *driver = ifinfo->conn->interfacePrivateData; + struct netcf_if *iface = NULL; + int ret = -1; + + interfaceDriverLock(driver); + + iface = ncf_lookup_by_name(driver->netcf, ifinfo->name); + if (!iface) { + interfaceReportError(ifinfo->conn, NULL, ifinfo, VIR_ERR_INVALID_INTERFACE, + "%s", _("no interface with matching MAC address")); + goto cleanup; + } + + ret = ncf_if_undefine(iface); + if (ret < 0) { + interfaceReportError(ifinfo->conn, NULL, ifinfo, VIR_ERR_INVALID_INTERFACE, + "%s", _("failed to undefine interface")); + goto cleanup; + } + +cleanup: + ncf_if_free(iface); + interfaceDriverUnlock(driver); + return ret; +} + +static int interfaceCreate(virInterfacePtr ifinfo, + unsigned int flags ATTRIBUTE_UNUSED) +{ + struct interface_driver *driver = ifinfo->conn->interfacePrivateData; + struct netcf_if *iface = NULL; + int ret = -1; + + interfaceDriverLock(driver); + + iface = ncf_lookup_by_name(driver->netcf, ifinfo->name); + if (!iface) { + interfaceReportError(ifinfo->conn, NULL, ifincof, VIR_ERR_INVALID_INTERFACE, + "%s", _("no interface with matching MAC address")); + goto cleanup; + } + + ret = ncf_if_up(iface); + if (ret < 0) { + interfaceReportError(ifinfo->conn, NULL, ifinfo, VIR_ERR_INVALID_INTERFACE, + "%s", _("failed to create (start) interface")); + goto cleanup; + } + +cleanup: + ncf_if_free(iface); + interfaceDriverUnlock(driver); + return ret; +} + +static int interfaceDestroy(virInterfacePtr ifinfo, + unsigned int flags ATTRIBUTE_UNUSED) +{ + struct interface_driver *driver = ifinfo->conn->interfacePrivateData; + struct netcf_if *iface = NULL; + int ret = -1; + + interfaceDriverLock(driver); + + iface = ncf_lookup_by_name(driver->netcf, ifinfo->name); + if (!iface) { + interfaceReportError(ifinfo->conn, NULL, ifinfo, VIR_ERR_INVALID_INTERFACE, + "%s", _("no interface with matching MAC address")); + goto cleanup; + } + + ret = ncf_if_down(iface); + if (ret < 0) { + interfaceReportError(ifinfo->conn, NULL, ifinfo, VIR_ERR_INVALID_INTERFACE, + "%s", _("failed to destroy (stop) interface")); + goto cleanup; + } + +cleanup: + ncf_if_free(iface); + interfaceDriverUnlock(driver); + return ret; +} + +static virInterfaceDriver interfaceDriver = { + "Interface", + interfaceOpenInterface, /* open */ + interfaceCloseInterface, /* close */ + interfaceNumInterfaces, /* numOfInterfaces */ + interfaceListInterfaces, /* listInterfaces */ + interfaceLookupByName, /* interfaceLookupByName */ + interfaceLookupByMACString, /* interfaceLookupByMACSTring */ + interfaceGetXMLDesc, /* interfaceGetXMLDesc */ + interfaceDefineXML, /* interfaceDefineXML */ + interfaceUndefine, /* interfaceUndefine */ + interfaceCreate, /* interfaceCreate */ + interfaceDestroy, /* interfaceDestroy */ +}; + +int interfaceRegister(void) { + virRegisterInterfaceDriver(&interfaceDriver); + return 0; +} diff --git a/src/interface_driver.h b/src/interface_driver.h new file mode 100644 index 0000000..be00e0b --- /dev/null +++ b/src/interface_driver.h @@ -0,0 +1,34 @@ +/* + * interface_driver.h: core driver methods for managing physical host interfaces + * + * Copyright (C) 2006, 2007 Red Hat, Inc. + * Copyright (C) 2006 Daniel P. Berrange + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * + * Author: Daniel P. Berrange <berrange(a)redhat.com> + */ + + +#ifndef __VIR_INTERFACE__DRIVER_H +#define __VIR_INTERFACE__DRIVER_H + +#include <config.h> + +#include "internal.h" + +int interfaceRegister(void); + +#endif /* __VIR_INTERFACE__DRIVER_H */ -- 1.6.0.6

2 1

[libvirt] VMware ESX driver status update
by Matthias Bolte 26 Jun '09

26 Jun '09

Hi, I'm still working on the VMX config to domain XML mapping for dump/create XML, but it's not complete yet. I got distracted by other urgent, Uni related work that had to be done first. So I won't be able to complete the dump/create XML implementation until tomorrow (freeze for the 0.6.5 release) that was requested in order to get the driver merged into the official repository. But well, with the short release cycle of libvirt not much is lost :) Some details on the VMX config to domain XML mapping: I claimed before that I would need to read most information needed for dump XML from the VMX config file. That's not true. Possibly all information can be retrieved via VI API, but the information is scattered in various places in the VI API object model. I'm currently heading for reading this information from the VMX config file, because all needed information is concentrated in this file. Also, if one changes properties of a virtual machine via VI API and this properties is reflected in the VMX config, the ESX host updates the VMX config, so the information is kept in sync between the object model and the config file. I guess, that the VMX config files contains enough information to fill all or at least most fields of a virDomainDef. So the first goal is to fill a virDomainDef for dump XML. The next goal would be a basic create XML. I claimed before that I would need to write an VMX config file to the ESX host in order to create a new virtual machine, but as I dig trough the VI API in more detail, it seems that this claim maybe false. I'll just have to test this, but haven't had time to do it yet. One problem here is the essential guestOS field of the VMX config, see http://sanbarrow.com/vmx/vmx-guestos.html . For a first try I would set it to 'other' by default, because there is currently no field available in the domain XML to map this information to. But to allow the user to set this filed, I would want to extend to domain XML definition in order to reuse existing code. So how would I do this? Currently I'm just using the virDomainDef struct and the related parse and format functions. One option would be to add a guest field to the virDomainOSDef struct and extend the parse and format functions to handle it. The parse and format functions take flags already, so a flag could be added to indicate if the guest field should be handled or not (just like the VMX extension for the virConfParser). Regards, Matthias

4 5

[libvirt] [PATCH 0/3] Control Linux capabilities in libvirt
by Daniel P. Berrange 26 Jun '09

26 Jun '09

The libvirtd system instance runs privileged (as root), and likewise so do VMs run from it. This is undesirable for obvious security reasons, even if you do have SELinux available. Linux has a concept of capabilities which are actually what gives 'root' its power. If you take away all capabilities from a process running root, you significantly limit its power. eg if you take away CAP_DAC_OVERRIDE, root can now only read files explicitly owned by root, not any other users. There are about 30-something capabilities at this time - see 'man 7 capabilities' for a full list and examples of what each allows you todo Historically it has needed alot of code to manage/modify capabilities, but there is a new library for managing Linux capabilities recently released, which makes their use significantly easier. This is known as libcap-ng http://people.redhat.com/sgrubb/libcap-ng/ I anticipate a several step process 1. Drop all capabilities from spawned processes which don't need it 2. Reduce capabilities from the libvirtd daemon 3. Run VM processes as non-root, unprivileged users 4. Run the libvirtd daemon as as a non-root, semi-privileged user This series of patches lays the very *basic* groundwork for controlling Linux capabilities, doing options 1 and 2. Option '3' is what I'd really like to get working, but it is more invasive, because it will need changes to the QEMU driver so it will chown disks to the 'kvm' user before spawning kvm (likewise for PCI devs, USB devs, etc). Step 1 is a mild security benefit, adding step 3 is a significant step forward. Step 2 doesn't have much tangible benefit, since our functionality requires that we need CAP_DAC_OVERRIDE, CAP_SYS_ADMIN and CAP_NET_ADMIN. Once you give a process those, its pretty much game over for security benefits of removing other capabilities. The 4th option *could* help security, but only if there are some changes to the way distros deploy apps. In particular they'd need to make sure binaries are installed with correct file capabilities, before we could use it, otherwise we wouldnt' be able to get child processes we spawn to keep capabilities they need. In addition, with step 4, we'd be asking admins to trade off functionality against security. eg, we could only drop CAP_DAC_OVERRIDE, if you turned off certain features. It is certainly desirable for users who want to tightly lock down their system, but not for a general purpose install. Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

4 13

[libvirt] [PATCH 5/5] create storage volumes
by Henrik Persson 25 Jun '09

25 Jun '09

This patch does the last magic to be able to create storage volumes when using a disk as backend

3 3

[libvirt] [PATCH] Fix reading storage pool defs on driver startup
by Cole Robinson 25 Jun '09

25 Jun '09

The recent storage refactoring I committed broke reading pool definitions from disk on driver startup: the result was that none of your pools would be defined. Frankly not sure how I managed to miss the brokenness, sorry about that! Also refactor the startup code to match the existing network and domain conventions. Thanks, Cole

2 1

[libvirt] Fix the no debug build
by Amy Griffis 25 Jun '09

25 Jun '09

The --enable-debug=no build breaks building the UML driver because of __VA_ARGS__ in the virLogMessage macro. I fixed this by converting umlLog() calls to use the standard logging macros instead. The only problem I see with doing this is what Daniel had mentioned a while back. Disabling debug actually turns off the entire logging module instead of just the debug output. I can work on fixing that part in another patch. Signed-off-by: Amy Griffis <amy.griffis(a)hp.com> diff --git a/src/uml_driver.c b/src/uml_driver.c index 7949d4f..7aeb7bf 100644 --- a/src/uml_driver.c +++ b/src/uml_driver.c @@ -66,9 +66,6 @@ static int umlShutdown(void); -#define umlLog(level, msg, ...) \ - virLogMessage(__FILE__, level, __func__, __LINE__, 0, msg, __VA_ARGS__) - static void umlDriverLock(struct uml_driver *driver) { virMutexLock(&driver->lock); @@ -95,8 +92,7 @@ static int umlSetCloseExec(int fd) { goto error; return 0; error: - umlLog(VIR_LOG_ERROR, - "%s", _("Failed to set close-on-exec file descriptor flag\n")); + VIR_ERROR0(_("Failed to set close-on-exec file descriptor flag")); return -1; } @@ -136,7 +132,7 @@ umlAutostartConfigs(struct uml_driver *driver) { !virDomainIsActive(driver->domains.objs[i]) && umlStartVMDaemon(conn, driver, driver->domains.objs[i]) < 0) { virErrorPtr err = virGetLastError(); - umlLog(VIR_LOG_ERROR, _("Failed to autostart VM '%s': %s\n"), + VIR_ERROR(_("Failed to autostart VM '%s': %s"), driver->domains.objs[i]->def->name, err->message); } } @@ -368,13 +364,13 @@ umlStartup(int privileged) { if ((uml_driver->inotifyFD = inotify_init()) < 0) { - umlLog(VIR_LOG_ERROR, "%s", _("cannot initialize inotify")); + VIR_ERROR0(_("cannot initialize inotify")); goto error; } if (virFileMakePath(uml_driver->monitorDir) < 0) { char ebuf[1024]; - umlLog(VIR_LOG_ERROR, _("Failed to create monitor directory %s: %s"), + VIR_ERROR(_("Failed to create monitor directory %s: %s"), uml_driver->monitorDir, virStrerror(errno, ebuf, sizeof ebuf)); goto error; } @@ -407,8 +403,7 @@ umlStartup(int privileged) { return 0; out_of_memory: - umlLog (VIR_LOG_ERROR, - "%s", _("umlStartup: out of memory\n")); + VIR_ERROR0(_("umlStartup: out of memory")); error: VIR_FREE(userdir); @@ -825,25 +820,25 @@ static int umlStartVMDaemon(virConnectPtr conn, tmp = progenv; while (*tmp) { if (safewrite(logfd, *tmp, strlen(*tmp)) < 0) - umlLog(VIR_LOG_WARN, _("Unable to write envv to logfile: %s\n"), + VIR_WARN(_("Unable to write envv to logfile: %s"), virStrerror(errno, ebuf, sizeof ebuf)); if (safewrite(logfd, " ", 1) < 0) - umlLog(VIR_LOG_WARN, _("Unable to write envv to logfile: %s\n"), + VIR_WARN(_("Unable to write envv to logfile: %s"), virStrerror(errno, ebuf, sizeof ebuf)); tmp++; } tmp = argv; while (*tmp) { if (safewrite(logfd, *tmp, strlen(*tmp)) < 0) - umlLog(VIR_LOG_WARN, _("Unable to write argv to logfile: %s\n"), + VIR_WARN(_("Unable to write argv to logfile: %s"), virStrerror(errno, ebuf, sizeof ebuf)); if (safewrite(logfd, " ", 1) < 0) - umlLog(VIR_LOG_WARN, _("Unable to write argv to logfile: %s\n"), + VIR_WARN(_("Unable to write argv to logfile: %s"), virStrerror(errno, ebuf, sizeof ebuf)); tmp++; } if (safewrite(logfd, "\n", 1) < 0) - umlLog(VIR_LOG_WARN, _("Unable to write argv to logfile: %s\n"), + VIR_WARN(_("Unable to write argv to logfile: %s"), virStrerror(errno, ebuf, sizeof ebuf)); vm->monitor = -1; @@ -888,8 +883,7 @@ static void umlShutdownVMDaemon(virConnectPtr conn ATTRIBUTE_UNUSED, vm->monitor = -1; if ((ret = waitpid(vm->pid, NULL, 0)) != vm->pid) { - umlLog(VIR_LOG_WARN, - _("Got unexpected pid %d != %d\n"), + VIR_WARN(_("Got unexpected pid %d != %d"), ret, vm->pid); }

3 2

[libvirt] Memory leak in node_device_conf.c
by Dave Allan 25 Jun '09

25 Jun '09

I found what I assume is a memory leak in the node device code while working on a separate problem; patch attached. Dave diff --git a/src/node_device_conf.c b/src/node_device_conf.c index 1fbf9dc..56a9bb5 100644 --- a/src/node_device_conf.c +++ b/src/node_device_conf.c @@ -1203,6 +1203,8 @@ void virNodeDevCapsDefFree(virNodeDevCapsDefPtr caps) VIR_FREE(data->net.address); break; case VIR_NODE_DEV_CAP_SCSI_HOST: + VIR_FREE(data->scsi_host.wwnn); + VIR_FREE(data->scsi_host.wwpn); break; case VIR_NODE_DEV_CAP_SCSI: VIR_FREE(data->scsi.type);

3 2

[libvirt] Re: [netcf-devel] Multiple interfaces with identical mac-addresses
by Laine Stump 25 Jun '09

25 Jun '09

(expanding Cc to include libvir-list, because this is more of a libvirt issue) On 06/24/2009 01:52 PM, David Lutterkort wrote: > On Wed, 2009-06-24 at 18:22 +0100, Daniel P. Berrange wrote: > >> On Wed, Jun 24, 2009 at 10:20:00AM -0700, David Lutterkort wrote: >> >>> On Tue, 2009-06-23 at 21:47 +0100, Daniel P. Berrange wrote: >>> >>>> Why would we ever have duplicate MAC addresses? >>>> >>> VLANs: >>> >>> # vconfig add eth0 42 >>> # cat /sys/class/net/eth0.42/address >>> 00:15:58:81:5b:0e >>> # cat /sys/class/net/eth0/address >>> 00:15:58:81:5b:0e >>> >> Ok, so for the libvirt API we should define that the lookup-by-mac API >> will not return VLAN devices, since we cant provide a 1-1 lookup there >> > > Why would you do that ? When the user asks for interfaces with a MAC, > you don't know if they are looking for a VLAN or base device. If they > want the VLAN, how would they look that up ? > I think we need to do one of two things: 1) Modify the existing virInterfaceLookupByMACString() api to return a list of virInterfaces. Although the public API has been in one release, there has been no functionality behind the API, so there's nobody using it as it is, and nobody is going to expect to use it as it is either. Because of that, "backward compatibility" isn't as much of an issue, and maybe we could let this modification to the API slide. 2) If we want to be really anal, we could modify virInterfaceLookupByMACString() to return an error if there are multiple interfaces with that particular MAC address, then provide a new function (name suggestion?) that would return a list of interfaces.

2 1

[libvirt] [PATCH] fix virsh dominfo returns error when virNodeGetSecurityModel() is not supported.
by Tatsuro Enokura 25 Jun '09

25 Jun '09

Hi all I try virsh dominfo in upstream libvirt on xen machine, the commands returns -1 as follows: [root@vmi20 ~]# virsh dominfo rhel53rc2_pv_sdb3 Id: 1 Name: rhel53rc2_pv_sdb3 UUID: 05ba9be8-f4e9-e208-11c7-fc936655cd8e OS Type: linux State: idle CPU(s): 2 CPU time: 8.8s Max memory: 1048576 kB Used memory: 716800 kB Autostart: disable error: this function is not supported by the hypervisor: virNodeGetSecurityModel [root@vmi20 ~]# echo $? 1 The explanation of virNodeGetSecurityModel() and virNodeGetSecurityModel() in libvirt.c is return -2 when hypervisor drivers don't support these operations. But these functions return -1 in this case, and so cmdDominfo() in virsh.c returns FALSE. I make a patch. - virNodeGetSecurityModel() and virNodeGetSecurityModel() return -2 when drivers don't supprted these operations. - In CmdDominfo(), it is no operation when virNodeGetSecurityModel() and virNodeGetSecurityModel() return -2. Signed-off-by: Tatsuro Enokura <fj2026af(a)aa.jp.fujitsu.com> Thanks Tatsuro Enokura

3 8

[libvirt] [PATCH] OpenNebula driver changes
by Javier Fontan 25 Jun '09

25 Jun '09

Hello, The first patch makes OpenNebula driver compilable in recent codebase. The second one adds direct calls to xmlrpc library so it does not depend on OpenNebula libraries and can be licensed as LGPL. I have compiled libvirt with the modifications without errors but with the current version I checked out from git repository I am having problems: --8<------ (LD) -o libvirtd libvirtd-event.o libvirtd-qemud.o libvirtd-remote.o libvirtd-remote_protocol.o ../src/.libs/libvirt_driver_storage.a(storage_backend.o): In function `virStorageBackendWaitForDevices': /home/jfontan/git/libvirt.git/src/storage_backend.c:262: undefined reference to `virNodeDeviceWaitForDevices' ------>8-- Patches are made from 0a29f59e3b8e2c1fb797d2fa93831f21a3e1711e Bye -- Javier Fontan, Grid & Virtualization Technology Engineer/Researcher DSA Research Group: http://dsa-research.org Globus GridWay Metascheduler: http://www.GridWay.org OpenNebula Virtual Infrastructure Engine: http://www.OpenNebula.org

4 5

[libvirt] [PATCH 2/5] Add partition type
by Henrik Persson 25 Jun '09

25 Jun '09

This patch add the partition type (primary, extended, logical) in internal libvirt data structure. This is important when deciding what kind of partition should be created.

2 1

[libvirt] [PATCH 1/5] Add type of free area
by Henrik Persson 25 Jun '09

25 Jun '09

This patch adds the type of the free area, since this is important when creating logical partitions.

2 1

[libvirt] [PATCH 4/5] free extent fix
by Henrik Persson 25 Jun '09

25 Jun '09

Parted reports that the first block of the disk is free, even if it is occupied by the partition table.

2 1

[libvirt] libvirt support for qemu downscript
by Shahar Klein 24 Jun '09

24 Jun '09

Hi I'm using virsh to launch a VM. the if-up script works perfectly but I couldn't find any reference to using down script I 'gueesed ' and put something like that: <interface type='ethernet'> . . <script path='ifup'/> <downscript path='ifdwon'/> . . </interface> but the down script is not called on shutdown am I missing something? thanks Shahar

1 0

[libvirt] virsh hangs
by Garry Dolley 24 Jun '09

24 Jun '09

My system: Ubuntu Jaunty 9.04 libvirt 0.6.4 kvm 0.8.4 qemu 0.10.0 I'm not sure what triggered this, I was working with several VMs, and then found that virsh decided to hang: garry@kvr02:~$ virsh list Connecting to uri: qemu:///system <hang> I have to ^C out of it. If I 'force-stop' and then 'start' libvirt-bin: garry@kvr02:~$ sudo /etc/init.d/libvirt-bin force-stop * Forcefully stopping libvirt management daemon libvirtd ...done. garry@kvr02:~$ sudo /etc/init.d/libvirt-bin start * Starting libvirt management daemon libvirtd ...done. I can then get something: garry@kvr02:~$ virsh list Connecting to uri: qemu:///system Id Name State ---------------------------------- 1 vm1 running 4 s3-lax running 14 freebsd-test running 19 freebsd-2 running <hang> But it hangs after that 4th one. I must ^C it again. If I do 'virsh list' again, it'll then show nothing (hangs like it does above). Any suggestions? Thanks -- Garry Dolley ARP Networks, Inc. | http://www.arpnetworks.com | (818) 206-0181 Data center, VPS, and IP Transit solutions Member Los Angeles County REACT, Unit 336 | WQGK336 Blog http://scie.nti.st

3 6

Re: [libvirt] virsh hangs
by Garry Dolley 23 Jun '09

23 Jun '09

On Tue, Jun 23, 2009 at 04:08:25PM -0300, Itamar Reis Peixoto wrote: > why you don't try Fedora 11 > > it's have newer versions of libvirt and KVM > > and if you have problem's you can report a bug or talk with developers using IRC Why don't I use Fedora? Let's not go there... ;) -- Garry Dolley ARP Networks, Inc. | http://www.arpnetworks.com | (818) 206-0181 Data center, VPS, and IP Transit solutions Member Los Angeles County REACT, Unit 336 | WQGK336 Blog http://scie.nti.st

1 0

[libvirt] [RFC][PATCH] lxc: drop CAP_SYS_BOOT capability to prevent rebooting from inside containers
by Ryota Ozaki 23 Jun '09

23 Jun '09

Hi, Current lxc driver unexpectedly allows users inside containers to reboot host physical machine. This patch prevents this by dropping CAP_SYS_BOOT capability in the bounding set of the init processes in every containers. Note that the patch intends to make it easy to add further capabilities to drop if needed, although I'm not sure which capabilities should be dropped. (We might need to drop CAP_SETFCAP as well to be strict...) Thanks, ozaki-r Signed-off-by: Ryota Ozaki <ozaki.ryota(a)gmail.com> >From 0e7a7622bc6411bbe76c05c63c6e6e61d379d97b Mon Sep 17 00:00:00 2001 From: Ryota Ozaki <ozaki.ryota(a)gmail.com> Date: Fri, 8 May 2009 04:29:24 +0900 Subject: [PATCH] lxc: drop CAP_SYS_BOOT capability to prevent rebooting from inside containers Current lxc driver unexpectedly allows users inside containers to reboot host physical machine. This patch prevents this by dropping CAP_SYS_BOOT capability in the bounding set of the init processes in every containers. --- src/lxc_container.c | 30 ++++++++++++++++++++++++++++++ 1 files changed, 30 insertions(+), 0 deletions(-) diff --git a/src/lxc_container.c b/src/lxc_container.c index 3946b84..37ab216 100644 --- a/src/lxc_container.c +++ b/src/lxc_container.c @@ -32,6 +32,8 @@ #include <sys/ioctl.h> #include <sys/mount.h> #include <sys/wait.h> +#include <sys/prctl.h> +#include <sys/capability.h> #include <unistd.h> #include <mntent.h> @@ -639,6 +641,30 @@ static int lxcContainerSetupMounts(virDomainDefPtr vmDef, return lxcContainerSetupExtraMounts(vmDef); } + +static int lxcContainerDropCapabilities( virDomainDefPtr vmDef ) +{ + int i; + const struct { + int id; + const char *name; + } caps[] = { +#define ID_STRING(name) name, #name + { ID_STRING(CAP_SYS_BOOT) }, + }; + + for (i = 0 ; i < ARRAY_CARDINALITY(caps) ; i++) { + if (prctl(PR_CAPBSET_DROP, caps[i].id, 0, 0, 0)) { + lxcError(NULL, NULL, VIR_ERR_INTERNAL_ERROR, + "%s", _("failed to drop %s"), caps[i].name); + return -1; + } + } + + return 0; +} + + /** * lxcChild: * @argv: Pointer to container arguments @@ -705,6 +731,10 @@ static int lxcContainerChild( void *data ) if (lxcContainerEnableInterfaces(argv->nveths, argv->veths) < 0) return -1; + /* drop a set of root capabilities */ + if (lxcContainerDropCapabilities(vmDef) < 0) + return -1; + /* this function will only return if an error occured */ return lxcContainerExecInit(vmDef); } -- 1.6.0.6

6 15

[libvirt] [PATCH] Avoid unecessary SELinux setfilecon
by Daniel Veillard 23 Jun '09

23 Jun '09

As pointed by Tim Waugh in https://bugzilla.redhat.com/show_bug.cgi?id=507555 there are times where setting an SELinux file context is not possible, so if the context is already set appropriately the operation should be skipped Patch from Tim looks fine by me though I'm not versed in SELinux Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

2 1

[libvirt] [PATCH] Do a correct format mapping of partitions
by Henrik Persson E 23 Jun '09

23 Jun '09

This patch reads the partition type and sets the correct target format of the storage volume when based on physical disk. --- libvirt-0.6.4.org/src/parthelper.c 2008-09-02 11:24:21.000000000 +0200 +++ libvirt-0.6.4/src/parthelper.c 2009-06-22 16:29:49.108681000 +0200 @@ -67,6 +67,7 @@ while (part) { const char *type; const char *content; + int partType = 0; if (part->type & PED_PARTITION_LOGICAL) { type = "logical"; if (part->type & PED_PARTITION_FREESPACE) @@ -92,26 +93,35 @@ content = "data"; } + /* Get partition type */ + if(ped_partition_is_active(part)) { + if(ped_partition_is_flag_available(part, PED_PARTITION_TYPE)) { + partType = ped_partition_get_flag(part,PED_PARTITION_TYPE); + } + } + /* We do +1 on geom.end, because we want end of the last sector * in bytes, not the last sector number */ if (part->num != -1) { - printf("%s%d%c%s%c%s%c%llu%c%llu%c%llu%c", + printf("%s%d%c%s%c%s%c%llu%c%llu%c%llu%c%d%c", part->geom.dev->path, part->num, '\0', type, '\0', content, '\0', part->geom.start * 512llu, '\0', (part->geom.end + 1 ) * 512llu, '\0', - part->geom.length * 512llu, '\0'); + part->geom.length * 512llu, '\0', + partType, '\0'); } else { - printf("%s%c%s%c%s%c%llu%c%llu%c%llu%c", + printf("%s%c%s%c%s%c%llu%c%llu%c%llu%c%d%c", "-", '\0', type, '\0', content, '\0', part->geom.start * 512llu, '\0', (part->geom.end + 1 ) * 512llu, '\0', - part->geom.length * 512llu, '\0'); + part->geom.length * 512llu, '\0', + partType, '\0'); } part = ped_disk_next_partition(disk, part); } --- libvirt-0.6.4.org/src/storage_backend_disk.c 2009-04-02 11:50:10.000000000 +0200 +++ libvirt-0.6.4/src/storage_backend_disk.c 2009-06-22 18:25:14.095095000 +0200 @@ -36,6 +36,35 @@ #define PARTHELPER BINDIR "/libvirt_parthelper" +/* Map partition types to internal enum */ +static int +virStorageBackendDiskMapPartitionType(const char* partType) +{ + switch(atoi(partType)) { + case 0x05: + case 0x0f: + return VIR_STORAGE_VOL_DISK_EXTENDED; + case 0x06: + case 0x0e: + return VIR_STORAGE_VOL_DISK_FAT16; + case 0x0b: + case 0x0c: + return VIR_STORAGE_VOL_DISK_FAT32; + case 0x82: + return VIR_STORAGE_VOL_DISK_LINUX_SWAP; + case 0x83: + return VIR_STORAGE_VOL_DISK_LINUX; + case 0x8e: + return VIR_STORAGE_VOL_DISK_LINUX_LVM; + case 0xfd: + return VIR_STORAGE_VOL_DISK_LINUX_RAID; + default: + return VIR_STORAGE_VOL_DISK_NONE; + + } +} + + static int virStorageBackendDiskMakeDataVol(virConnectPtr conn, virStoragePoolObjPtr pool, @@ -128,6 +157,9 @@ if (virStorageBackendUpdateVolInfo(conn, vol, 1) < 0) return -1; + /* virStorageBackendUpdateVolInfo sets format incorrect for partitions */ + vol->target.format = virStorageBackendDiskMapPartitionType(groups[6]); + vol->type = VIR_STORAGE_VOL_BLOCK; /* The above gets allocation wrong for @@ -250,7 +282,7 @@ return virStorageBackendRunProgNul(conn, pool, prog, - 6, + 7, virStorageBackendDiskMakeVol, vol); }

2 1

[libvirt] virsh -no-kvm problem on debian install
by ChaosMedia > WebDev 23 Jun '09

23 Jun '09

Hi, i've installed lastest kvm-86 and libvirt-0.6.4 tarballs on my debian stable and have a problem using virsh No matter what i do in the guest domain config or with /usr/bin/ symlinks, libvirt keeps using the -no-kvm option when starting guests when my cpu has kvm-amd support, modules are loaded and /dev/kvm exists, and starting the guests thru command line works fine, and faster. debian seems to install the following binary /usr/bin/qemu-system-x86_64, i had to add "/usr/bin/qemu" to get virsh to work, otherwise it will say it can't connect to qemu:///system here's some command output : #virsh -c qemu:///system capabilities <capabilities> <host> <cpu> <arch>x86_64</arch> </cpu> <migration_features> <live/> <uri_transports> <uri_transport>tcp</uri_transport> </uri_transports> </migration_features> </host> <guest> <os_type>hvm</os_type> <arch name='i686'> <wordsize>32</wordsize> <emulator>/usr/bin/qemu</emulator> <machine>pc</machine> <machine>isapc</machine> <domain type='qemu'> </domain> </arch> <features> <pae/> <nonpae/> <acpi default='on' toggle='yes'/> <apic default='on' toggle='no'/> </features> </guest> <guest> <os_type>hvm</os_type> <arch name='x86_64'> <wordsize>64</wordsize> <emulator>/usr/bin/qemu-system-x86_64</emulator> <machine>pc</machine> <machine>isapc</machine> <domain type='qemu'> </domain> </arch> <features> <acpi default='on' toggle='yes'/> <apic default='on' toggle='no'/> </features> </guest> </capabilities> and tried adding "/usr/bin/qemu-kvm" symlink <capabilities> <host> <cpu> <arch>x86_64</arch> </cpu> <migration_features> <live/> <uri_transports> <uri_transport>tcp</uri_transport> </uri_transports> </migration_features> </host> <guest> <os_type>hvm</os_type> <arch name='i686'> <wordsize>32</wordsize> <emulator>/usr/bin/qemu</emulator> <machine>pc</machine> <machine>isapc</machine> <domain type='qemu'> </domain> <domain type='kvm'> <emulator>/usr/bin/qemu-kvm</emulator> </domain> </arch> <features> <pae/> <nonpae/> <acpi default='on' toggle='yes'/> <apic default='on' toggle='no'/> </features> </guest> <guest> <os_type>hvm</os_type> <arch name='x86_64'> <wordsize>64</wordsize> <emulator>/usr/bin/qemu-system-x86_64</emulator> <machine>pc</machine> <machine>isapc</machine> <domain type='qemu'> </domain> <domain type='kvm'> <emulator>/usr/bin/qemu-kvm</emulator> </domain> </arch> <features> <acpi default='on' toggle='yes'/> <apic default='on' toggle='no'/> </features> </guest> </capabilities> So far i had no luck getting virsh to use kvm, it always adds the -no-kvm option, i'm not sure how to specify the domain type in the guest config, using the <emulator>/usr/bin/qemu-kvm</emulator> won't help. i've found that thread discussing the binaries and options but don't know if that patch was already added or if i have to patch my tarball.. http://www.redhat.com/archives/libvir-list/2009-March/msg00281.html please let me know if there's some way to let libvirt know that kvm exists on a debian install, using /usr/bin/qemu-system-x86_64 thx, Marc

2 2

[libvirt] [RFC] Reporting host interface status/statistics via netcf/libvirt, and listing active vs. inactive interfaces
by Laine Stump 22 Jun '09

22 Jun '09

I've already been working on incorporating physical host interface configuration into libvirt by way of using libnetcf on the backend. It's becoming apparent that, in addition to modifying and reporting the current configuration of interfaces, libvirt users also want to query current status of each interface (up/down, possibly other flags, packet/byte/error counts, current IP address, etc). There are two possible ways of doing this: 1) maintain libnetcf's focus on just interface configuration, and add code directly into libvirt to grab this information via appropriate ioctls or 2) add the functionality to libnetcf, and have libvirt call the new libnetcf API. (2) seems to make the most sense, because likely other libnetcf consumers will want this capability too. I'm thinking of a single API, something like: int netcf_if_status(netcf_if *, netcf_if_stats *); (or maybe int netcf_if_info(netcf_if *, netcf_if_info *)) I haven't really put much thought into the details of what should be in netcf_if_stats yet (beyond what I listed above), but wanted to get this idea out there so people can start sounding off (if I'm going down the wrong road, I'd rather be put on the right path before I get too far along!) This function could be exposed in the libvirt API as something like: int virInterfaceStatus|Info(virInterffacePtr iface, virInterfaceStats|Info *info); Any comments/ideas on this? (One possible complication I can see is interfaces with multiple associated IPs. On some platforms, each interface can have only a single IPv4 and a single IPv6 address (more IPs == more interfaces), but on others there can be multiples.) A (kind of) separate issue: In libvirt we want to be able to list active (up) and inactive (down) interfaces separately. For consistency, libvirt's way of exposing that will be to mimic what is done with virConnectListNetworks() (active) vs. virConnectListDefinedNetworks() (inactive). But netcf could do it with an extra argument to ncf_list_interfaces(). If the latter, should the default behavior be to list all interfaces, with flags set to eliminate up or down interfaces? 0 (list all) NETCF_NOLIST_UP NETCF_NOLIST_DOWN Or should the values be something like this: 0 (list all) NETCF_LIST_UP_ONLY NETCF_LIST_DOWN_ONLY (UP_ONLY + DOWN_ONLY would be equivalent to 0. As long as nobody came up with a good reason for "0". So should we do one of those, or should we mimic libirt's virNetwork API in libnetcf too?

5 55

[libvirt] [PATCH] Refactor storage XML parsing to be consistent with domain/network conf.
by Cole Robinson 22 Jun '09

22 Jun '09

The storage driver arranges its parsing routines in a way that make them difficult to use in the test driver for non-default file parsing. This refactoring moves things to be consistent with the way domain_conf and network_conf do things. Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- src/libvirt_private.syms | 8 ++- src/storage_conf.c | 163 ++++++++++++++++++++++++++++++++-------------- src/storage_conf.h | 26 ++++++-- src/storage_driver.c | 8 +- src/test.c | 25 ++----- 5 files changed, 150 insertions(+), 80 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index f63fa05..309d7f9 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -267,7 +267,9 @@ virSecurityDriverGetModel; # storage_conf.h virStoragePoolDefFormat; virStoragePoolDefFree; -virStoragePoolDefParse; +virStoragePoolDefParseString; +virStoragePoolDefParseFile; +virStoragePoolDefParseNode; virStoragePoolLoadAllConfigs; virStoragePoolObjAssignDef; virStoragePoolObjClearVols; @@ -284,7 +286,9 @@ virStorageVolDefFindByName; virStorageVolDefFindByPath; virStorageVolDefFormat; virStorageVolDefFree; -virStorageVolDefParse; +virStorageVolDefParseFile; +virStorageVolDefParseString; +virStorageVolDefParseNode; virStoragePoolFormatDiskTypeToString; virStoragePoolFormatFileSystemTypeToString; virStoragePoolFormatFileSystemNetTypeToString; diff --git a/src/storage_conf.c b/src/storage_conf.c index 5f724dc..7d495ec 100644 --- a/src/storage_conf.c +++ b/src/storage_conf.c @@ -452,14 +452,12 @@ error: return ret; } - static virStoragePoolDefPtr -virStoragePoolDefParseDoc(virConnectPtr conn, - xmlXPathContextPtr ctxt, - xmlNodePtr root) { +virStoragePoolDefParseXML(virConnectPtr conn, + xmlXPathContextPtr ctxt) { virStoragePoolOptionsPtr options; virStoragePoolDefPtr ret; - xmlChar *type = NULL; + char *type = NULL; char *uuid = NULL; char *authType = NULL; @@ -468,13 +466,7 @@ virStoragePoolDefParseDoc(virConnectPtr conn, return NULL; } - if (STRNEQ((const char *)root->name, "pool")) { - virStorageReportError(conn, VIR_ERR_XML_ERROR, - "%s", _("unknown root element for storage pool")); - goto cleanup; - } - - type = xmlGetProp(root, BAD_CAST "type"); + type = virXPathString(conn, "string(./@type)", ctxt); if ((ret->type = virStoragePoolTypeFromString((const char *)type)) < 0) { virStorageReportError(conn, VIR_ERR_INTERNAL_ERROR, _("unknown storage pool type %s"), (const char*)type); @@ -656,6 +648,32 @@ catchXMLError (void *ctx, const char *msg ATTRIBUTE_UNUSED, ...) } virStoragePoolDefPtr +virStoragePoolDefParseNode(virConnectPtr conn, + xmlDocPtr xml, + xmlNodePtr root) { + xmlXPathContextPtr ctxt = NULL; + virStoragePoolDefPtr def = NULL; + + if (STRNEQ((const char *)root->name, "pool")) { + virStorageReportError(conn, VIR_ERR_XML_ERROR, + "%s", _("unknown root element for storage pool")); + goto cleanup; + } + + ctxt = xmlXPathNewContext(xml); + if (ctxt == NULL) { + virReportOOMError(conn); + goto cleanup; + } + + ctxt->node = root; + def = virStoragePoolDefParseXML(conn, ctxt); +cleanup: + xmlXPathFreeContext(ctxt); + return def; +} + +static virStoragePoolDefPtr virStoragePoolDefParse(virConnectPtr conn, const char *xmlStr, const char *filename) { @@ -663,7 +681,6 @@ virStoragePoolDefParse(virConnectPtr conn, xmlParserCtxtPtr pctxt; xmlDocPtr xml = NULL; xmlNodePtr node = NULL; - xmlXPathContextPtr ctxt = NULL; /* Set up a parser context so we can catch the details of XML errors. */ pctxt = xmlNewParserCtxt (); @@ -673,10 +690,17 @@ virStoragePoolDefParse(virConnectPtr conn, pctxt->_private = conn; if (conn) virResetError (&conn->err); - xml = xmlCtxtReadDoc (pctxt, BAD_CAST xmlStr, - filename ? filename : "storage.xml", NULL, - XML_PARSE_NOENT | XML_PARSE_NONET | - XML_PARSE_NOWARNING); + if (filename) { + xml = xmlCtxtReadFile (pctxt, filename, NULL, + XML_PARSE_NOENT | XML_PARSE_NONET | + XML_PARSE_NOWARNING); + } else { + xml = xmlCtxtReadDoc (pctxt, BAD_CAST xmlStr, + "storage.xml", NULL, + XML_PARSE_NOENT | XML_PARSE_NONET | + XML_PARSE_NOWARNING); + } + if (!xml) { if (conn && conn->err.code == VIR_ERR_NONE) virStorageReportError(conn, VIR_ERR_XML_ERROR, @@ -684,12 +708,6 @@ virStoragePoolDefParse(virConnectPtr conn, goto cleanup; } - ctxt = xmlXPathNewContext(xml); - if (ctxt == NULL) { - virReportOOMError(conn); - goto cleanup; - } - node = xmlDocGetRootElement(xml); if (node == NULL) { virStorageReportError(conn, VIR_ERR_XML_ERROR, @@ -697,21 +715,33 @@ virStoragePoolDefParse(virConnectPtr conn, goto cleanup; } - ret = virStoragePoolDefParseDoc(conn, ctxt, node); + ret = virStoragePoolDefParseNode(conn, xml, node); xmlFreeParserCtxt (pctxt); - xmlXPathFreeContext(ctxt); xmlFreeDoc(xml); return ret; cleanup: xmlFreeParserCtxt (pctxt); - xmlXPathFreeContext(ctxt); xmlFreeDoc(xml); return NULL; } +virStoragePoolDefPtr +virStoragePoolDefParseString(virConnectPtr conn, + const char *xmlStr) +{ + return virStoragePoolDefParse(conn, xmlStr, NULL); +} + +virStoragePoolDefPtr +virStoragePoolDefParseFile(virConnectPtr conn, + const char *filename) +{ + return virStoragePoolDefParse(conn, NULL, filename); +} + static int virStoragePoolSourceFormat(virConnectPtr conn, virBufferPtr buf, @@ -916,10 +946,9 @@ virStorageSize(virConnectPtr conn, } static virStorageVolDefPtr -virStorageVolDefParseDoc(virConnectPtr conn, +virStorageVolDefParseXML(virConnectPtr conn, virStoragePoolDefPtr pool, - xmlXPathContextPtr ctxt, - xmlNodePtr root) { + xmlXPathContextPtr ctxt) { virStorageVolDefPtr ret; virStorageVolOptionsPtr options; char *allocation = NULL; @@ -935,12 +964,6 @@ virStorageVolDefParseDoc(virConnectPtr conn, return NULL; } - if (STRNEQ((const char *)root->name, "volume")) { - virStorageReportError(conn, VIR_ERR_XML_ERROR, - "%s", _("unknown root element")); - goto cleanup; - } - ret->name = virXPathString(conn, "string(/volume/name)", ctxt); if (ret->name == NULL) { virStorageReportError(conn, VIR_ERR_XML_ERROR, @@ -1028,8 +1051,34 @@ virStorageVolDefParseDoc(virConnectPtr conn, return NULL; } - virStorageVolDefPtr +virStorageVolDefParseNode(virConnectPtr conn, + virStoragePoolDefPtr pool, + xmlDocPtr xml, + xmlNodePtr root) { + xmlXPathContextPtr ctxt = NULL; + virStorageVolDefPtr def = NULL; + + if (STRNEQ((const char *)root->name, "volume")) { + virStorageReportError(conn, VIR_ERR_XML_ERROR, + "%s", _("unknown root element for storage vol")); + goto cleanup; + } + + ctxt = xmlXPathNewContext(xml); + if (ctxt == NULL) { + virReportOOMError(conn); + goto cleanup; + } + + ctxt->node = root; + def = virStorageVolDefParseXML(conn, pool, ctxt); +cleanup: + xmlXPathFreeContext(ctxt); + return def; +} + +static virStorageVolDefPtr virStorageVolDefParse(virConnectPtr conn, virStoragePoolDefPtr pool, const char *xmlStr, @@ -1038,7 +1087,6 @@ virStorageVolDefParse(virConnectPtr conn, xmlParserCtxtPtr pctxt; xmlDocPtr xml = NULL; xmlNodePtr node = NULL; - xmlXPathContextPtr ctxt = NULL; /* Set up a parser context so we can catch the details of XML errors. */ pctxt = xmlNewParserCtxt (); @@ -1048,10 +1096,18 @@ virStorageVolDefParse(virConnectPtr conn, pctxt->_private = conn; if (conn) virResetError (&conn->err); - xml = xmlCtxtReadDoc (pctxt, BAD_CAST xmlStr, - filename ? filename : "storage.xml", NULL, - XML_PARSE_NOENT | XML_PARSE_NONET | - XML_PARSE_NOWARNING); + + if (filename) { + xml = xmlCtxtReadFile (pctxt, filename, NULL, + XML_PARSE_NOENT | XML_PARSE_NONET | + XML_PARSE_NOWARNING); + } else { + xml = xmlCtxtReadDoc (pctxt, BAD_CAST xmlStr, + "storage.xml", NULL, + XML_PARSE_NOENT | XML_PARSE_NONET | + XML_PARSE_NOWARNING); + } + if (!xml) { if (conn && conn->err.code == VIR_ERR_NONE) virStorageReportError(conn, VIR_ERR_XML_ERROR, @@ -1059,12 +1115,6 @@ virStorageVolDefParse(virConnectPtr conn, goto cleanup; } - ctxt = xmlXPathNewContext(xml); - if (ctxt == NULL) { - virReportOOMError(conn); - goto cleanup; - } - node = xmlDocGetRootElement(xml); if (node == NULL) { virStorageReportError(conn, VIR_ERR_XML_ERROR, @@ -1072,21 +1122,34 @@ virStorageVolDefParse(virConnectPtr conn, goto cleanup; } - ret = virStorageVolDefParseDoc(conn, pool, ctxt, node); + ret = virStorageVolDefParseNode(conn, pool, xml, node); xmlFreeParserCtxt (pctxt); - xmlXPathFreeContext(ctxt); xmlFreeDoc(xml); return ret; cleanup: xmlFreeParserCtxt (pctxt); - xmlXPathFreeContext(ctxt); xmlFreeDoc(xml); return NULL; } +virStorageVolDefPtr +virStorageVolDefParseString(virConnectPtr conn, + virStoragePoolDefPtr pool, + const char *xmlStr) +{ + return virStorageVolDefParse(conn, pool, xmlStr, NULL); +} + +virStorageVolDefPtr +virStorageVolDefParseFile(virConnectPtr conn, + virStoragePoolDefPtr pool, + const char *filename) +{ + return virStorageVolDefParse(conn, pool, NULL, filename); +} static int virStorageVolTargetDefFormat(virConnectPtr conn, diff --git a/src/storage_conf.h b/src/storage_conf.h index 8a4fed2..a2a164e 100644 --- a/src/storage_conf.h +++ b/src/storage_conf.h @@ -28,6 +28,8 @@ #include "util.h" #include "threads.h" +#include <libxml/tree.h> + /* Shared structs */ @@ -306,16 +308,26 @@ virStorageVolDefPtr virStorageVolDefFindByName(virStoragePoolObjPtr pool, void virStoragePoolObjClearVols(virStoragePoolObjPtr pool); -virStoragePoolDefPtr virStoragePoolDefParse(virConnectPtr conn, - const char *xml, - const char *filename); +virStoragePoolDefPtr virStoragePoolDefParseString(virConnectPtr conn, + const char *xml); +virStoragePoolDefPtr virStoragePoolDefParseFile(virConnectPtr conn, + const char *filename); +virStoragePoolDefPtr virStoragePoolDefParseNode(virConnectPtr conn, + xmlDocPtr xml, + xmlNodePtr root); char *virStoragePoolDefFormat(virConnectPtr conn, virStoragePoolDefPtr def); -virStorageVolDefPtr virStorageVolDefParse(virConnectPtr conn, - virStoragePoolDefPtr pool, - const char *xml, - const char *filename); +virStorageVolDefPtr virStorageVolDefParseString(virConnectPtr conn, + virStoragePoolDefPtr pool, + const char *xml); +virStorageVolDefPtr virStorageVolDefParseFile(virConnectPtr conn, + virStoragePoolDefPtr pool, + const char *filename); +virStorageVolDefPtr virStorageVolDefParseNode(virConnectPtr conn, + virStoragePoolDefPtr pool, + xmlDocPtr xml, + xmlNodePtr root); char *virStorageVolDefFormat(virConnectPtr conn, virStoragePoolDefPtr pool, virStorageVolDefPtr def); diff --git a/src/storage_driver.c b/src/storage_driver.c index 5a248a3..5fe22c6 100644 --- a/src/storage_driver.c +++ b/src/storage_driver.c @@ -466,7 +466,7 @@ storagePoolCreate(virConnectPtr conn, virStorageBackendPtr backend; storageDriverLock(driver); - if (!(def = virStoragePoolDefParse(conn, xml, NULL))) + if (!(def = virStoragePoolDefParseString(conn, xml))) goto cleanup; pool = virStoragePoolObjFindByUUID(&driver->pools, def->uuid); @@ -518,7 +518,7 @@ storagePoolDefine(virConnectPtr conn, virStorageBackendPtr backend; storageDriverLock(driver); - if (!(def = virStoragePoolDefParse(conn, xml, NULL))) + if (!(def = virStoragePoolDefParseString(conn, xml))) goto cleanup; if ((backend = virStorageBackendForType(def->type)) == NULL) @@ -1220,7 +1220,7 @@ storageVolumeCreateXML(virStoragePoolPtr obj, if ((backend = virStorageBackendForType(pool->def->type)) == NULL) goto cleanup; - voldef = virStorageVolDefParse(obj->conn, pool->def, xmldesc, NULL); + voldef = virStorageVolDefParseString(obj->conn, pool->def, xmldesc); if (voldef == NULL) goto cleanup; @@ -1362,7 +1362,7 @@ storageVolumeCreateXMLFrom(virStoragePoolPtr obj, goto cleanup; } - newvol = virStorageVolDefParse(obj->conn, pool->def, xmldesc, NULL); + newvol = virStorageVolDefParseString(obj->conn, pool->def, xmldesc); if (newvol == NULL) goto cleanup; diff --git a/src/test.c b/src/test.c index 2a672a3..6874d63 100644 --- a/src/test.c +++ b/src/test.c @@ -286,7 +286,7 @@ static int testOpenDefault(virConnectPtr conn) { netobj->persistent = 1; virNetworkObjUnlock(netobj); - if (!(pooldef = virStoragePoolDefParse(conn, defaultPoolXML, NULL))) + if (!(pooldef = virStoragePoolDefParseString(conn, defaultPoolXML))) goto error; if (!(poolobj = virStoragePoolObjAssignDef(conn, &privconn->pools, @@ -564,22 +564,13 @@ static int testOpenFromFile(virConnectPtr conn, goto error; } - def = virStoragePoolDefParse(conn, NULL, absFile); + def = virStoragePoolDefParseFile(conn, absFile); VIR_FREE(absFile); if (!def) goto error; } else { - xmlBufferPtr buf; - xmlSaveCtxtPtr sctxt; - - buf = xmlBufferCreate(); - sctxt = xmlSaveToBuffer(buf, NULL, 0); - xmlSaveTree(sctxt, pools[i]); - xmlSaveClose(sctxt); - if ((def = virStoragePoolDefParse(conn, - (const char *) buf->content, - NULL)) == NULL) { - xmlBufferFree(buf); + if ((def = virStoragePoolDefParseNode(conn, xml, + pools[i])) == NULL) { goto error; } } @@ -2514,7 +2505,7 @@ testStoragePoolCreate(virConnectPtr conn, virStoragePoolPtr ret = NULL; testDriverLock(privconn); - if (!(def = virStoragePoolDefParse(conn, xml, NULL))) + if (!(def = virStoragePoolDefParseString(conn, xml))) goto cleanup; pool = virStoragePoolObjFindByUUID(&privconn->pools, def->uuid); @@ -2557,7 +2548,7 @@ testStoragePoolDefine(virConnectPtr conn, virStoragePoolPtr ret = NULL; testDriverLock(privconn); - if (!(def = virStoragePoolDefParse(conn, xml, NULL))) + if (!(def = virStoragePoolDefParseString(conn, xml))) goto cleanup; def->capacity = defaultPoolCap; @@ -3082,7 +3073,7 @@ testStorageVolumeCreateXML(virStoragePoolPtr pool, goto cleanup; } - privvol = virStorageVolDefParse(pool->conn, privpool->def, xmldesc, NULL); + privvol = virStorageVolDefParseString(pool->conn, privpool->def, xmldesc); if (privvol == NULL) goto cleanup; @@ -3163,7 +3154,7 @@ testStorageVolumeCreateXMLFrom(virStoragePoolPtr pool, goto cleanup; } - privvol = virStorageVolDefParse(pool->conn, privpool->def, xmldesc, NULL); + privvol = virStorageVolDefParseString(pool->conn, privpool->def, xmldesc); if (privvol == NULL) goto cleanup; -- 1.6.3.2

2 3

[libvirt] [PATCH] Fix raw storage volume creation for allocation < capacity.
by Cole Robinson 22 Jun '09

22 Jun '09

CreateXMLFrom changes accidentally caused all raw volume creation to be fully allocated (as though allocation == capacity). Fix this. Also force CreateXMLFrom to maintain the previous behavior: sparseness should still be maintained since we search for holes when copying, and the clone behavior hasn't been tested with anything but the broken behavior. Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- src/storage_backend_fs.c | 2 +- src/storage_driver.c | 5 +++++ 2 files changed, 6 insertions(+), 1 deletions(-) diff --git a/src/storage_backend_fs.c b/src/storage_backend_fs.c index 0e93e54..c3d66b5 100644 --- a/src/storage_backend_fs.c +++ b/src/storage_backend_fs.c @@ -1047,7 +1047,7 @@ static int createRaw(virConnectPtr conn, goto cleanup; } - remain = vol->capacity; + remain = vol->allocation; if (inputfd != -1) { int amtread = -1; diff --git a/src/storage_driver.c b/src/storage_driver.c index 71e64a4..57a93c1 100644 --- a/src/storage_driver.c +++ b/src/storage_driver.c @@ -1377,6 +1377,11 @@ storageVolumeCreateXMLFrom(virStoragePoolPtr obj, if (newvol->capacity < origvol->capacity) newvol->capacity = origvol->capacity; + /* Make sure allocation is at least as large as the destination cap, + * to make absolutely sure we copy all possible contents */ + if (newvol->allocation < origvol->capacity; + newvol->allocation = origvol->capacity; + if (!backend->buildVolFrom) { virStorageReportError(obj->conn, VIR_ERR_NO_SUPPORT, "%s", _("storage pool does not support volume creation from an existing volume")); -- 1.6.0.6

3 4

[libvirt] Storage volume issues when creating an LVM or RAID partition
by Henrik Persson E 22 Jun '09

22 Jun '09

Hi everyone, I have currently some patches coming up for storage pools and volumes based on physical disks. However I have an issue that I would like to hear your opinion about. When it comes to storage pools and volumes based on physical disks, the name given does not really have any real meaning, the underlying disk/partition will at the end decide the name of the pool/volume (as soon as a refresh on the pool is made, the user defined names will be gone). This is quite confusion but at the end it still works. But there are cases where it does not work. To be able to create a partition type such as LVM or raid, parted (which is used as the disk management backend) does not support setting this partition type when creating the partition but instead by setting a flag on the partition after it has been created. As it is not possible to decide at which position in the partition table the new partition should be created, parted will just choose the next available number. To be able to set this flag on the partition, we need to know which partition we just created, and suddenly the name of the volume is important, but only if it has followed the rules that parted applied when finding the next available slot. If the name of the volume is incorrect we will end up with a volume created with incorrect type since we can't do 2 operation towards parted in a transaction manner (e.g. Volume name is sdb2 but the newly created partition is sdb1). I see two possible solutions on this problem: 1. We add volume name constraints in this case that makes sure that when a volume is created by a user (by checking the pool and scan all ready existing volumes in that pool), it has to create a name that is correct according to parted's rules. In that case we can use the volume name to find the partition just created and we can set the flag on the partition in a safe way 2. we extend the libvirt_parthelper and uses the libparted instead to create a partition, which then can be made in a more transaction like manner. However, in this case we have to more or less add all the support that parted has for creating a partition which is quite extensive. I put my vote on solution 1 but I like to know your opinion and also if any one knows that the initial plans were. /Henrik

1 0

[libvirt] Extend virConfParser to allow parsing VMware VMX config files
by Matthias Bolte 22 Jun '09

22 Jun '09

Hi, As part of the VMware ESX driver I need to parse VMware VMX config files. This files have basically the same syntax as Xen config files, but the key part of the key=value format is allowed to contain ':' and '.'. The attached patch adds a flag to the virConfParser to enabled a VMX mode for the parser to allow ':' and '.' in the key, as suggested by Daniel P. Berrange on IRC. Regards Matthias

3 5

[libvirt] [PATCH] Cleanup when Storage Pool Create fails.
by Henrik Persson E 22 Jun '09

22 Jun '09

When libvirt fails to create a storage pool (e.g. a disk pool does not have a partition table), the failed storage pool is not cleaned up correctly and is not possible to re-create the pool again. This attached patch addresses this problem. /Henrik

3 2

[libvirt] netbsd5.0
by Fabien Georget 22 Jun '09

22 Jun '09

Hi I want to run netbsd 5.0 with kvm in virt-manager. It works with default option but any network devices is recognized by the netbsd kernel. To enable network with qemu-kvm, we had to disable the acpi and add other options like -tdf, -localtime ... This is an an example who works : http://ghantoos.org/2009/05/12/my-first-shot-of-netbsd/ (An explanation I found is that the new scheduler in netbsd 5.0 cause some problems with virtualization based on VT) Currently, I have not found the way to do it with libvirt (and I don't think it is possible with virt-manager). It be very helpeful if these features can be add to libvirt. Thanks Fabien Georget

2 2

[libvirt] problems with remote authentication with policykit
by Jim Paris 22 Jun '09

22 Jun '09

Hi, I have libvirt 0.6.4 running kvm instances on a headless server. I'm using virt-manager 0.7.0 to manage them. In the past, I would SSH in and run virt-manager as root. Since running GTK apps as root is no good, I've switched to policykit authentication. By default, the libvirt policy only allows management if the user is in the active host session, which isn't the case with my SSH logins. Therefore I've added an override in /etc/PolicyKit/PolicyKit.conf: <match action="org.libvirt.unix.manage"> <return result="auth_admin_keep_session"/> </match> Now things generally work fine when SSHed in: - as root, virsh gives ro and rw access with no password - as jim, virsh gives ro access with no password, but requests a password for rw - as jim, virsh asks for a password for rw access But when accessing remotely, I get no useful error, and a hang: $ virsh -c qemu+ssh://jim@server/system libvir: Remote error : authentication failed <process hangs here> $ virsh --readonly -c qemu+ssh://jim@server/system libvir: Remote error : authentication failed <process hangs here> Furthermore, on the server, this leaves "nc" processes running, and eventually there are enough that libvirtd stops accepting new connections. I was also getting strange errors including: polkit-grant-helper: given auth type (8 -> yes) is bogus but now I can't reproduce that for the life of me, I have no idea what changed. Is policykit authentication supposed to work over qemu+ssh? I was hoping it would at least not break the --readonly case. -jim

3 11

[libvirt] netbsd5.0
by Fabien Georget 21 Jun '09

21 Jun '09

Hi I want to run netbsd 5.0 with kvm in virt-manager. It works with default option but any network devices is recognized by the netbsd kernel. To enable network with qemu-kvm, we had to disable the acpi and add other options like -tdf, -localtime ... This is an an example who works : http://ghantoos.org/2009/05/12/my-first-shot-of-netbsd/ (An explanation I found is that the new scheduler in netbsd 5.0 cause some problems with virtualization based on VT) Currently, I have not found the way to do it with libvirt (and I don't think it is possible with virt-manager). It be very helpeful if these features can be add to libvirt. Thanks Fabien Georget

1 0

[libvirt] [PATCH] Activate virtual networks initialized in custom test driver.
by Cole Robinson 19 Jun '09

19 Jun '09

If specifying a custom test driver, virtual networks were not 'activated' on driver init. This differs from the behavior of domains and storage pools, so fix it. Also improve a couple error messages in that area. Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- src/test.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/test.c b/src/test.c index 1661144..6f07462 100644 --- a/src/test.c +++ b/src/test.c @@ -462,7 +462,8 @@ static int testOpenFromFile(virConnectPtr conn, if (!(xml = xmlReadFd(fd, file, NULL, XML_PARSE_NOENT | XML_PARSE_NONET | XML_PARSE_NOERROR | XML_PARSE_NOWARNING))) { - testError(NULL, VIR_ERR_INTERNAL_ERROR, "%s", _("host")); + testError(NULL, VIR_ERR_INTERNAL_ERROR, + _("Invalid XML in file '%s'"), file); goto error; } close(fd); @@ -470,7 +471,8 @@ static int testOpenFromFile(virConnectPtr conn, root = xmlDocGetRootElement(xml); if ((root == NULL) || (!xmlStrEqual(root->name, BAD_CAST "node"))) { - testError(NULL, VIR_ERR_XML_ERROR, "%s", _("node")); + testError(NULL, VIR_ERR_XML_ERROR, "%s", + _("Root element is not 'node'")); goto error; } @@ -622,6 +624,7 @@ static int testOpenFromFile(virConnectPtr conn, goto error; } net->persistent = 1; + net->active = 1; virNetworkObjUnlock(net); } VIR_FREE(networks); -- 1.6.3.2

2 1

[libvirt] [PATCH] Fix storage handling for custom test driver.
by Cole Robinson 19 Jun '09

19 Jun '09

If using a custom test driver, storage pool file parsing was broken, and storage volume parsing was never implemented. Fix these issues, and add some examples in docs/ Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- docs/testnode.xml | 3 ++ docs/testpool.xml | 15 +++++++++ docs/testvol.xml | 6 +++ src/test.c | 88 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 112 insertions(+), 0 deletions(-) create mode 100644 docs/testpool.xml create mode 100644 docs/testvol.xml diff --git a/docs/testnode.xml b/docs/testnode.xml index be7121d..1ad7a10 100644 --- a/docs/testnode.xml +++ b/docs/testnode.xml @@ -11,6 +11,9 @@ <domain file="testdomfc4.xml"/> <network file="testnetpriv.xml"/> <network file="testnetdef.xml"/> + <pool file="testpool.xml"> + <volume file="testvol.xml"/> + </pool> <cpu> <mhz>6000</mhz> diff --git a/docs/testpool.xml b/docs/testpool.xml new file mode 100644 index 0000000..c1a8dff --- /dev/null +++ b/docs/testpool.xml @@ -0,0 +1,15 @@ +<pool type='dir'> + <name>default-pool</name> + <uuid>35bb2ad9-388a-cdfe-461a-b8907f6e53fe</uuid> + <capacity>107374182400</capacity> + <allocation>0</allocation> + <available>107374182400</available> + <target> + <path>/default-pool</path> + <permissions> + <mode>0700</mode> + <owner>10736</owner> + <group>10736</group> + </permissions> + </target> +</pool> diff --git a/docs/testvol.xml b/docs/testvol.xml new file mode 100644 index 0000000..00198f8 --- /dev/null +++ b/docs/testvol.xml @@ -0,0 +1,6 @@ +<volume> + <name>default-vol</name> + <capacity>1000000</capacity> + <allocation>50000</allocation> + <target/> +</volume> diff --git a/src/test.c b/src/test.c index 6874d63..1661144 100644 --- a/src/test.c +++ b/src/test.c @@ -341,6 +341,87 @@ static char *testBuildFilename(const char *relativeTo, } } +static int testOpenVolumesForPool(virConnectPtr conn, + xmlDocPtr xml, + xmlXPathContextPtr ctxt, + const char *file, + virStoragePoolObjPtr pool, + int poolidx) { + char *vol_xpath; + int i, ret, func_ret = -1; + xmlNodePtr *vols = NULL; + virStorageVolDefPtr def; + + /* Find storage volumes */ + if (virAsprintf(&vol_xpath, "/node/pool[%d]/volume", poolidx) < 0) { + virReportOOMError(NULL); + goto error; + } + + ret = virXPathNodeSet(conn, vol_xpath, ctxt, &vols); + VIR_FREE(vol_xpath); + if (ret < 0) { + testError(NULL, VIR_ERR_XML_ERROR, + _("node vol list for pool '%s'"), pool->def->name); + goto error; + } + + for (i = 0 ; i < ret ; i++) { + char *relFile = virXMLPropString(vols[i], "file"); + if (relFile != NULL) { + char *absFile = testBuildFilename(file, relFile); + VIR_FREE(relFile); + if (!absFile) { + testError(NULL, VIR_ERR_INTERNAL_ERROR, "%s", + _("resolving volume filename")); + goto error; + } + + def = virStorageVolDefParseFile(conn, pool->def, absFile); + VIR_FREE(absFile); + if (!def) + goto error; + } else { + if ((def = virStorageVolDefParseNode(conn, pool->def, xml, + vols[i])) == NULL) { + goto error; + } + } + + if (VIR_REALLOC_N(pool->volumes.objs, + pool->volumes.count+1) < 0) { + virReportOOMError(conn); + goto error; + } + + if (virAsprintf(&def->target.path, "%s/%s", + pool->def->target.path, + def->name) == -1) { + virReportOOMError(conn); + goto error; + } + + def->key = strdup(def->target.path); + if (def->key == NULL) { + virReportOOMError(conn); + goto error; + } + + pool->def->allocation += def->allocation; + pool->def->available = (pool->def->capacity - + pool->def->allocation); + + pool->volumes.objs[pool->volumes.count++] = def; + def = NULL; + } + + func_ret = 0; +error: + virStorageVolDefFree(def); + VIR_FREE(vols); + return func_ret; +} + static int testOpenFromFile(virConnectPtr conn, const char *file) { int fd = -1, i, ret; @@ -586,6 +667,13 @@ static int testOpenFromFile(virConnectPtr conn, goto error; } pool->active = 1; + + /* Find storage volumes */ + if (testOpenVolumesForPool(conn, xml, ctxt, file, pool, i+1) < 0) { + virStoragePoolObjUnlock(pool); + goto error; + } + virStoragePoolObjUnlock(pool); } VIR_FREE(pools); -- 1.6.3.2

2 1

[libvirt] [PATCH] Fix segfault if storage pool has no type attribute (possibly others)
by Cole Robinson 19 Jun '09

19 Jun '09

virEnumFromString doesn't check for a NULL string, and will segfault if passed one. Lots of calling code protects against this, but at least /pool/@type parsing does not. Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- src/util.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/util.c b/src/util.c index d8ab37f..8b746f5 100644 --- a/src/util.c +++ b/src/util.c @@ -1622,6 +1622,9 @@ int virEnumFromString(const char *const*types, const char *type) { unsigned int i; + if (!type) + return -1; + for (i = 0 ; i < ntypes ; i++) if (STREQ(types[i], type)) return i; -- 1.6.3.2

3 2