- Devel - libvirt List Archives

[libvirt] [PATCH] add cd and pwd commands to virsh
by Paolo Bonzini 17 Jul '09

17 Jul '09

This patch adds cd and pwd commands to virsh. These can be useful together with commands that refer to files in the local file systems, especially save and restore. I explicitly decided not to provide any other command, e.g. mkdir, to avoid going down a slippery slope (now you want mkdir, tomorrow ls and rm and so on...). If anything, it would be possible to add a generic shell command---but cd cannot be implemented that way, so pwd shall remain the sole "exception". I did not implement "cd -". Ok? 2009-07-02 Paolo Bonzini <pbonzini(a)redhat.com> * bootstrap: Add getcwd module. * docs/virsh.pod: Document cd and pwd commands. * src/virsh.c (info_cd, opts_cd, cmdCd, info_pwd, cmdPwd): New. (commands): Add cd and pwd commands. * virsh.1: Regenerate. Signed-off-by: Paolo Bonzini <pbonzini(a)redhat.com> --- bootstrap | 1 + docs/virsh.pod | 12 ++++++++ src/virsh.c | 77 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ virsh.1 | 12 ++++++++- 4 files changed, 101 insertions(+), 1 deletions(-) diff --git a/bootstrap b/bootstrap index baf52e7..b14d8cc 100755 --- a/bootstrap +++ b/bootstrap @@ -69,6 +69,7 @@ c-ctype close connect getaddrinfo +getcwd gethostname getpass gettext diff --git a/docs/virsh.pod b/docs/virsh.pod index 6434d78..9530ba6 100644 --- a/docs/virsh.pod +++ b/docs/virsh.pod @@ -82,6 +82,18 @@ Running hypervisor: Xen 3.0.0 =back +=item B<cd> I<directory> optional + +Will change current directory to I<directory>. The default directory +for the B<cd> command is the home directory or, if there is no I<HOME> +variable in the environment, the root directory. + +This command is only available in interactive mode. + +=item B<pwd> + +Will print the current directory. + =item B<connect> I<URI> optional I<--readonly> (Re)-Connect to the hypervisor. This is a build-in command after shell diff --git a/src/virsh.c b/src/virsh.c index 5623499..856e5a0 100644 --- a/src/virsh.c +++ b/src/virsh.c @@ -6047,6 +6047,81 @@ editReadBackFile (vshControl *ctl, const char *filename) } /* + * "cd" command + */ +static const vshCmdInfo info_cd[] = { + {"help", gettext_noop("change the current directory")}, + {"desc", gettext_noop("Change the current directory.")}, + {NULL, NULL} +}; + +static const vshCmdOptDef opts_cd[] = { + {"dir", VSH_OT_DATA, 0, gettext_noop("directory to switch to (default: home or else root)")}, + {NULL, 0, 0, NULL} +}; + +static int +cmdCd(vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED) +{ + const char *dir; + int found; + + if (!ctl->imode) { + vshError(ctl, FALSE, _("cd: command valid only in interactive mode")); + return -1; + } + + dir = vshCommandOptString(cmd, "dir", &found); + if (!found) + dir = getenv ("HOME"); + if (!dir) + dir = "/"; + + if (chdir (dir) == -1) { + vshError(ctl, FALSE, _("cd: %s: %s"), strerror (errno), dir); + return -1; + } + + return 0; +} + +/* + * "pwd" command + */ +static const vshCmdInfo info_pwd[] = { + {"help", gettext_noop("print the current directory")}, + {"desc", gettext_noop("Print the current directory.")}, + {NULL, NULL} +}; + +static int +cmdPwd(vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED) +{ + char *cwd; + size_t path_max; + int err = TRUE; + + path_max = (size_t) PATH_MAX + 2; + cwd = vshMalloc (ctl, path_max); + while (cwd) { + err = getcwd (cwd, path_max) == NULL; + if (!err || errno != ERANGE) + break; + + path_max *= 2; + cwd = vshRealloc (ctl, cwd, path_max); + } + + if (err) + vshError(ctl, FALSE, _("pwd: cannot get current directory: %s"), strerror (errno)); + else + vshPrint (ctl, _("%s\n"), cwd); + + free (cwd); + return !err; +} + +/* * "edit" command */ static const vshCmdInfo info_edit[] = { @@ -6209,6 +6284,7 @@ static const vshCmdDef commands[] = { {"attach-interface", cmdAttachInterface, opts_attach_interface, info_attach_interface}, {"autostart", cmdAutostart, opts_autostart, info_autostart}, {"capabilities", cmdCapabilities, NULL, info_capabilities}, + {"cd", cmdCd, opts_cd, info_cd}, {"connect", cmdConnect, opts_connect, info_connect}, {"console", cmdConsole, opts_console, info_console}, {"create", cmdCreate, opts_create, info_create}, @@ -6277,6 +6353,7 @@ static const vshCmdDef commands[] = { {"pool-undefine", cmdPoolUndefine, opts_pool_undefine, info_pool_undefine}, {"pool-uuid", cmdPoolUuid, opts_pool_uuid, info_pool_uuid}, + {"pwd", cmdPwd, NULL, info_pwd}, {"quit", cmdQuit, NULL, info_quit}, {"reboot", cmdReboot, opts_reboot, info_reboot}, {"restore", cmdRestore, opts_restore, info_restore}, diff --git a/virsh.1 b/virsh.1 index 45ea614..ca03cc1 100644 --- a/virsh.1 +++ b/virsh.1 @@ -132,7 +132,7 @@ .\" ======================================================================== .\" .IX Title "VIRSH 1" -.TH VIRSH 1 "2009-04-16" "libvirt-0.6.2" "Virtualization Support" +.TH VIRSH 1 "2009-07-02" "libvirt-0.6.4" "Virtualization Support" .\" For nroff, turn off justification. Always turn off hyphenation; it makes .\" way too many mistakes in technical documents. .if n .ad l @@ -214,6 +214,16 @@ Running hypervisor: Xen 3.0.0 .RE .RS 4 .RE +.IP "\fBcd\fR \fIdirectory\fR optional" 4 +.IX Item "cd directory optional" +Will change current directory to \fIdirectory\fR. The default directory +for the \fBcd\fR command is the home directory or, if there is no \fI\s-1HOME\s0\fR +variable in the environment, the root directory. +.Sp +This command is only available in interactive mode. +.IP "\fBpwd\fR" 4 +.IX Item "pwd" +Will print the current directory. .IP "\fBconnect\fR \fI\s-1URI\s0\fR optional \fI\-\-readonly\fR" 4 .IX Item "connect URI optional --readonly" (Re)\-Connect to the hypervisor. This is a build-in command after shell -- 1.6.2.5

3 7

[libvirt] consistency: push "update" hook vs. "make syntax-check"
by Jim Meyering 17 Jul '09

17 Jul '09

Currently the server side hook that runs "git diff --check" to prevent pushing a change that adds trailing blanks is more strict than our "make syntax-check" hook, since the former rejects any change that adds blank lines at the end of a file, while "make syntax-check" doesn't complain about that. The two should be consistent. One way is to make "make syntax-check" more strict. If we were to do that, we'd have to choose between cleaning existing files and exempting them from the new test. Cleaning is easy and doesn't impact tests at all, so I prefer it. Here's what would be involved: - remove 121 trailing newlines from 109 files by running this command: git ls-files -z | xargs -0 perl -pi -0777 -e 's/\n\n+$/\n/' Add a rule to cfg.mk so that "make syntax-check" warns about any new violations. It might run something like this: git ls-files -z \ | xargs -0 perl -ln -0777 -e '/\n(\n+)$/ and print "$ARGV: ".length $1' That command prints the name of each offending file with its trailing blank line count. While it takes well under a second on my system, (admittedly, with a hot cache), it's not well optimized, reading each file into memory and processing it. If it matters, we can come up with a more efficient (yet still portable) way to compare the last two bytes of each file to "\n\n". I went ahead and wrote a nearly-minimal script to do that. Rather than reading/processing all 27MB of sources, this reads just the last 2 bytes of each of the 1048 files, comparing those bytes to "\n\n" and printing the name when there's a match: git ls-files -z \ | xargs -0 perl -le ' foreach my $f (@ARGV) { open F,"<",$f or (warn "failed to open $f: $!\n"), next; my $p = sysseek(F, -2, 2); # seek failure probably means file has < 2 bytes; ignore my $two; defined $p and $p = sysread F,$two,2; close F; # ignore read failure $p && $two eq "\n\n" and (print $f),$fail=1; } END {exit defined $fail ? 1 : 0}' However, counting minor page faults, there's little difference (2193 before, 1976 after), but maximum memory consumption is probably way down. I didn't measure that. With a hot cache, the latter takes .02elapsed, and the former takes .09 seconds. I'm leaning towards the simplicity of the former, in spite of its cost. I'll bet someone can come up with a simple *and* efficient script (probably using sed) to list files with one or more trailing blank line.

3 9

[libvirt] [PATCH 0/4] Prepare remote driver client for data streams
by Daniel P. Berrange 17 Jul '09

17 Jul '09

This patch series does a small amount of refactoring to the remote driver client to aid in supporting data streams Daniel P. Berrange (4): Refactor incoming message handling to prepare for data stream support Refactor message sending to allow code reuse for data streams Simplify remote driver error reporting Rename a bunch of internal methods to clarify their meaning src/remote_internal.c | 366 ++++++++++++++++++++++++------------------------- 1 files changed, 181 insertions(+), 185 deletions(-) -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 8

[libvirt] PATCH: Allow QEMU VMs to be run unprivileged
by Daniel P. Berrange 17 Jul '09

17 Jul '09

This patch makes it such that the privileges libvirtd daemon can run unprivileged QEMU guests. The default remains unchanged with QEMU running as root:root, but the package maintainer can request an alternative default user at build time, and the sysadmin can also override this at install time with /etc/libvirt/qemu.conf. As well as making QEMU setuid/gid to the non-root user, this patch takes care of chown'ing all resources it needs to access. This currently includes - /dev/bus/usb/$BUS/$DEVICE for any assigned USB devices - /sys/bus/pci/$ADDR/{config,resource*,rom} for PCI devs - All disk paths Upon shutdown it will restore ownership to root for all of thesem, except shared/readonly disk images NB one minor problem is that USB devices attached based on vendor/product ID aren't handled. Need to figure out a way to deal with this.... Daniel commit 5283a949f4f5cc75e471ddd624362261280378d9 Author: Daniel P. Berrange <berrange(a)redhat.com> Date: Wed Jul 15 22:25:01 2009 +0100 Run QEMU guests as an unprivileged user * configure.in: Add --with-qemu-user and --with-qemu-group args * libvirt.spec.in: use 'qemu' for user/group for Fedora >= 12 * qemud/libvirtd_qemu.arg, qemud/test_libvirtd_qemu.aug, src/qemu.conf: Add 'user' and 'group' args for configuration * src/Makefile.am: Create %localstatedir/cache/libvirt/qemu * src/qemu_conf.c, src/qemu_conf.h: Load user/group from config * src/qemu_driver.c: Change user ID/group ID when launching QEMU guests. Change user/group ownership on disks/usb/pci devs. Put memory dumps in %localstatedir/cache/libvirt/qemu * src/util.c, src/util.h: Add convenient APIs for converting username/groupname to user ID / group ID diff --git a/configure.in b/configure.in index 552089a..634e812 100644 --- a/configure.in +++ b/configure.in @@ -1437,6 +1437,19 @@ AM_CONDITIONAL([WITH_NODE_DEVICES], [test "$with_nodedev" = "yes"]) AM_CONDITIONAL([WITH_LINUX], [test `uname -s` = "Linux"]) + +AC_ARG_WITH([qemu-user], + [ --with-qemu-user username to run QEMU system instance as], + [QEMU_USER=${withval}], + [QEMU_USER=root]) +AC_ARG_WITH([qemu-group], + [ --with-qemu-group groupname to run QEMU system instance as], + [QEMU_GROUP=${withval}], + [QEMU_GROUP=root]) +AC_DEFINE_UNQUOTED([QEMU_USER], ["$QEMU_USER"], [QEMU user account]) +AC_DEFINE_UNQUOTED([QEMU_GROUP], ["$QEMU_GROUP"], [QEMU group account]) + + # Only COPYING.LIB is under version control, yet COPYING # is included as part of the distribution tarball. # Copy one to the other, but only if this is a srcdir-build. @@ -1578,3 +1591,7 @@ AC_MSG_NOTICE([ Debug: $enable_debug]) AC_MSG_NOTICE([ Warnings: $enable_compile_warnings]) AC_MSG_NOTICE([ Readline: $lv_use_readline]) AC_MSG_NOTICE([]) +AC_MSG_NOTICE([Privileges]) +AC_MSG_NOTICE([]) +AC_MSG_NOTICE([ QEMU: $QEMU_USER:$QEMU_GROUP]) +AC_MSG_NOTICE([]) \ No newline at end of file diff --git a/libvirt.spec.in b/libvirt.spec.in index 6321eaa..1bde6c5 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -46,6 +46,14 @@ %define with_capng 0%{!?_without_capng:1} %endif +%if 0%{?fedora} >= 12 +%define qemu_user qemu +%define qemu_group qemu +%else +%define qemu_user root +%define qemu_group root +%endif + # # If building on RHEL switch on the specific support # @@ -309,6 +317,8 @@ of recent versions of Linux (and other OSes). %{?_without_storage_iscsi} \ %{?_without_storage_disk} \ %{?_without_numactl} \ + --with-qemu-user=%{qemu_user} \ + --with-qemu-group=%{qemu_group} \ --with-init-script=redhat \ --with-qemud-pid-file=%{_localstatedir}/run/libvirt_qemud.pid \ --with-remote-file=%{_localstatedir}/run/libvirtd.pid @@ -446,8 +456,9 @@ fi %dir %attr(0700, root, root) %{_localstatedir}/cache/libvirt/ %if %{with_qemu} -%dir %{_localstatedir}/run/libvirt/qemu/ -%dir %attr(0700, root, root) %{_localstatedir}/lib/libvirt/qemu/ +%dir %attr(0700, %{qemu_user}, %{qemu_group}) %{_localstatedir}/run/libvirt/qemu/ +%dir %attr(0700, %{qemu_user}, %{qemu_group}) %{_localstatedir}/lib/libvirt/qemu/ +%dir %attr(0700, %{qemu_user}, %{qemu_group}) %{_localstatedir}/cache/libvirt/qemu/ %endif %if %{with_lxc} %dir %{_localstatedir}/run/libvirt/lxc/ diff --git a/qemud/libvirtd_qemu.aug b/qemud/libvirtd_qemu.aug index 02699d6..abd6b62 100644 --- a/qemud/libvirtd_qemu.aug +++ b/qemud/libvirtd_qemu.aug @@ -29,6 +29,8 @@ module Libvirtd_qemu = | str_entry "vnc_password" | bool_entry "vnc_sasl" | str_entry "vnc_sasl_dir" + | str_entry "user" + | str_entry "group" (* Each enty in the config is one of the following three ... *) let entry = vnc_entry diff --git a/qemud/test_libvirtd_qemu.aug b/qemud/test_libvirtd_qemu.aug index 6f38e47..f62da01 100644 --- a/qemud/test_libvirtd_qemu.aug +++ b/qemud/test_libvirtd_qemu.aug @@ -79,6 +79,10 @@ vnc_sasl = 1 # point to the directory, and create a qemu.conf in that location # vnc_sasl_dir = \"/some/directory/sasl2\" + +user = \"root\" + +group = \"root\" " test Libvirtd_qemu.lns get conf = @@ -161,3 +165,7 @@ vnc_sasl_dir = \"/some/directory/sasl2\" { "#comment" = "point to the directory, and create a qemu.conf in that location" } { "#comment" = "" } { "vnc_sasl_dir" = "/some/directory/sasl2" } +{ "#comment" = "" } +{ "user"= "root" } +{ "#comment" = "" } +{ "group" = "root" } \ No newline at end of file diff --git a/src/Makefile.am b/src/Makefile.am index 889ede4..9b662ae 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -684,6 +684,7 @@ install-exec-local: if WITH_QEMU $(MKDIR_P) "$(DESTDIR)$(localstatedir)/lib/libvirt/qemu" $(MKDIR_P) "$(DESTDIR)$(localstatedir)/run/libvirt/qemu" + $(MKDIR_P) "$(DESTDIR)$(localstatedir)/cache/libvirt/qemu" endif if WITH_LXC $(MKDIR_P) "$(DESTDIR)$(localstatedir)/lib/libvirt/lxc" diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 0534d53..59c78d5 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -378,6 +378,8 @@ virRun; virSkipSpaces; virKillProcess; virGetUserDirectory; +virGetUserID; +virGetGroupID; # uuid.h diff --git a/src/qemu.conf b/src/qemu.conf index c2a53c5..3009725 100644 --- a/src/qemu.conf +++ b/src/qemu.conf @@ -88,3 +88,10 @@ # to 'none' instead # # security_driver = "selinux" + + +# The user ID for QEMU processes run by the system instance +#user = "root" + +# The group ID for QEMU processes run by the system instance +#group = "root" diff --git a/src/qemu_conf.c b/src/qemu_conf.c index 414b71b..0718f39 100644 --- a/src/qemu_conf.c +++ b/src/qemu_conf.c @@ -92,6 +92,8 @@ int qemudLoadDriverConfig(struct qemud_driver *driver, const char *filename) { virConfPtr conf; virConfValuePtr p; + char *user; + char *group; /* Setup 2 critical defaults */ if (!(driver->vncListen = strdup("127.0.0.1"))) { @@ -186,6 +188,36 @@ int qemudLoadDriverConfig(struct qemud_driver *driver, } } + p = virConfGetValue (conf, "user"); + CHECK_TYPE ("user", VIR_CONF_STRING); + if (!(user = strdup(p && p->str ? p->str : QEMU_USER))) { + virReportOOMError(NULL); + virConfFree(conf); + return -1; + } + if (virGetUserID(NULL, user, &driver->user) < 0) { + VIR_FREE(user); + virConfFree(conf); + return -1; + } + VIR_FREE(user); + + p = virConfGetValue (conf, "group"); + CHECK_TYPE ("group", VIR_CONF_STRING); + if (!(group = strdup(p && p->str ? p->str : QEMU_GROUP))) { + virReportOOMError(NULL); + virConfFree(conf); + return -1; + } + + + if (virGetGroupID(NULL, group, &driver->group) < 0) { + VIR_FREE(group); + virConfFree(conf); + return -1; + } + VIR_FREE(group); + virConfFree (conf); return 0; } diff --git a/src/qemu_conf.h b/src/qemu_conf.h index 175173d..fbf2ab9 100644 --- a/src/qemu_conf.h +++ b/src/qemu_conf.h @@ -66,6 +66,9 @@ struct qemud_driver { int privileged; + uid_t user; + gid_t group; + unsigned int qemuVersion; int nextvmid; diff --git a/src/qemu_driver.c b/src/qemu_driver.c index 342ba01..f2d021c 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -71,12 +71,11 @@ #define VIR_FROM_THIS VIR_FROM_QEMU /* For storing short-lived temporary files. */ -#define TEMPDIR LOCAL_STATE_DIR "/cache/libvirt" +#define TEMPDIR LOCAL_STATE_DIR "/cache/libvirt/qemu" #define QEMU_CMD_PROMPT "\n(qemu) " #define QEMU_PASSWD_PROMPT "Password: " - static int qemudShutdown(void); static void qemuDriverLock(struct qemud_driver *driver) @@ -1367,6 +1366,205 @@ static int qemudDomainSetSecurityLabel(virConnectPtr conn, struct qemud_driver * return 0; } + +#ifdef __linux__ +static int qemuDomainSetHostdevUSBOwnership(virConnectPtr conn, + virDomainHostdevDefPtr def, + uid_t uid, gid_t gid) +{ + char *usbpath = NULL; + + /* XXX what todo for USB devs assigned based on product/vendor ? Doom :-( */ + if (!def->source.subsys.u.usb.bus || + !def->source.subsys.u.usb.device) + return 0; + + if (virAsprintf(&usbpath, "/dev/bus/usb/%03d/%03d", + def->source.subsys.u.usb.bus, + def->source.subsys.u.usb.device) < 0) { + virReportOOMError(conn); + return -1; + } + + VIR_DEBUG("Setting ownership on %s to %d:%d", usbpath, uid, gid); + if (chown(usbpath, uid, gid) < 0) { + virReportSystemError(conn, errno, _("cannot set ownership on %s"), usbpath); + VIR_FREE(usbpath); + return -1; + } + VIR_FREE(usbpath); + + return 0; +} + +static int qemuDomainSetHostdevPCIOwnership(virConnectPtr conn, + virDomainHostdevDefPtr def, + uid_t uid, gid_t gid) +{ + char *pcidir = NULL; + char *file = NULL; + DIR *dir = NULL; + int ret = -1; + struct dirent *ent; + + if (virAsprintf(&pcidir, "/sys/bus/pci/devices/%04x:%02x:%02x.%x", + def->source.subsys.u.pci.domain, + def->source.subsys.u.pci.bus, + def->source.subsys.u.pci.slot, + def->source.subsys.u.pci.function) < 0) { + virReportOOMError(conn); + goto cleanup; + } + + if (!(dir = opendir(pcidir))) { + virReportSystemError(conn, errno, + _("cannot open %s"), pcidir); + goto cleanup; + } + + while ((ent = readdir(dir)) != NULL) { + /* QEMU device assignment requires: + * $PCIDIR/config, $PCIDIR/resource, $PCIDIR/resourceNNN, $PCIDIR/rom + */ + if (STREQ(ent->d_name, "config") || + STRPREFIX(ent->d_name, "resource") || + STREQ(ent->d_name, "rom")) { + if (virAsprintf(&file, "%s/%s", pcidir, ent->d_name) < 0) { + virReportOOMError(conn); + goto cleanup; + } + VIR_DEBUG("Setting ownership on %s to %d:%d", file, uid, gid); + if (chown(file, uid, gid) < 0) { + virReportSystemError(conn, errno, _("cannot set ownership on %s"), file); + goto cleanup; + } + VIR_FREE(file); + } + } + + ret = 0; + +cleanup: + if (dir) + closedir(dir); + VIR_FREE(file); + VIR_FREE(pcidir); + return ret; +} +#endif + + +static int qemuDomainSetHostdevOwnership(virConnectPtr conn, + virDomainHostdevDefPtr def, + uid_t uid, gid_t gid) +{ + if (def->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) + return 0; + +#ifdef __linux__ + switch (def->source.subsys.type) { + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB: + return qemuDomainSetHostdevUSBOwnership(conn, def, uid, gid); + + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI: + return qemuDomainSetHostdevPCIOwnership(conn, def, uid, gid); + + } + return 0; +#else + qemudReportError(conn, NULL, NULL, "%s", + _("unable to set host device ownership on this platform")); + return -1; +#endif + +} + +static int qemuDomainSetDiskOwnership(virConnectPtr conn, + virDomainDiskDefPtr def, + uid_t uid, gid_t gid) +{ + + if (!def->src) + return 0; + + VIR_DEBUG("Setting ownership on %s to %d:%d", def->src, uid, gid); + if (chown(def->src, uid, gid) < 0) { + virReportSystemError(conn, errno, _("cannot set ownership on %s"), + def->src); + return -1; + } + return 0; +} + +static int qemuDomainSetDeviceOwnership(virConnectPtr conn, + struct qemud_driver *driver, + virDomainDeviceDefPtr def, + int restore) +{ + uid_t uid; + gid_t gid; + + if (!driver->privileged) + return 0; + + /* short circuit case of root:root */ + if (!driver->user && !driver->group) + return 0; + + uid = restore ? 0 : driver->user; + gid = restore ? 0 : driver->group; + + switch (def->type) { + case VIR_DOMAIN_DEVICE_DISK: + if (restore && + (def->data.disk->readonly || def->data.disk->shared)) + return 0; + + return qemuDomainSetDiskOwnership(conn, def->data.disk, uid, gid); + + case VIR_DOMAIN_DEVICE_HOSTDEV: + return qemuDomainSetHostdevOwnership(conn, def->data.hostdev, uid, gid); + } + + return 0; +} + +static int qemuDomainSetAllDeviceOwnership(virConnectPtr conn, + struct qemud_driver *driver, + virDomainDefPtr def, + int restore) +{ + int i; + uid_t uid; + gid_t gid; + + if (!driver->privileged) + return 0; + + /* short circuit case of root:root */ + if (!driver->user && !driver->group) + return 0; + + uid = restore ? 0 : driver->user; + gid = restore ? 0 : driver->group; + + for (i = 0 ; i < def->ndisks ; i++) { + if (restore && + (def->disks[i]->readonly || def->disks[i]->shared)) + continue; + + if (qemuDomainSetDiskOwnership(conn, def->disks[i], uid, gid) < 0) + return -1; + } + + for (i = 0 ; i < def->nhostdevs ; i++) { + if (qemuDomainSetHostdevOwnership(conn, def->hostdevs[i], uid, gid) < 0) + return -1; + } + + return 0; +} + static virDomainPtr qemudDomainLookupByName(virConnectPtr conn, const char *name); @@ -1377,14 +1575,39 @@ struct gemudHookData { }; static int qemudSecurityHook(void *data) { - struct gemudHookData *h = (struct gemudHookData *) data; + struct gemudHookData *h = (struct gemudHookData *) data; + + if (qemudDomainSetSecurityLabel(h->conn, h->driver, h->vm) < 0) { + qemudReportError(h->conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, + _("Failed to set security label")); + return -1; + } + + if (h->driver->privileged) { + DEBUG("Dropping privileges of VM to %d:%d", h->driver->user, h->driver->group); + + if (qemuDomainSetAllDeviceOwnership(h->conn, h->driver, h->vm->def, 0) < 0) + return -1; - if (qemudDomainSetSecurityLabel(h->conn, h->driver, h->vm) < 0) { - qemudReportError(h->conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, - _("Failed to set security label")); + if (h->driver->group) { + if (setregid(h->driver->group, h->driver->group) < 0) { + virReportSystemError(NULL, errno, + _("cannot change to '%d' group"), + h->driver->group); return -1; + } } - return 0; + if (h->driver->user) { + if (setreuid(h->driver->user, h->driver->user) < 0) { + virReportSystemError(NULL, errno, + _("cannot change to '%d' user"), + h->driver->user); + return -1; + } + } + } + + return 0; } static int @@ -1662,6 +1885,10 @@ static void qemudShutdownVMDaemon(virConnectPtr conn ATTRIBUTE_UNUSED, VIR_FREE(vm->def->seclabel.imagelabel); } + if (qemuDomainSetAllDeviceOwnership(conn, driver, vm->def, 1) < 0) + VIR_WARN("Failed to restore all device ownership for %s", + vm->def->name); + if (qemudRemoveDomainStatus(conn, driver, vm) < 0) { VIR_WARN(_("Failed to remove domain status for %s"), vm->def->name); @@ -4227,12 +4454,20 @@ static int qemudDomainAttachDevice(virDomainPtr dom, case VIR_DOMAIN_DISK_DEVICE_FLOPPY: if (driver->securityDriver) driver->securityDriver->domainSetSecurityImageLabel(dom->conn, vm, dev->data.disk); + + if (qemuDomainSetDeviceOwnership(dom->conn, driver, dev, 0) < 0) + goto cleanup; + ret = qemudDomainChangeEjectableMedia(dom->conn, vm, dev); break; case VIR_DOMAIN_DISK_DEVICE_DISK: if (driver->securityDriver) driver->securityDriver->domainSetSecurityImageLabel(dom->conn, vm, dev->data.disk); + + if (qemuDomainSetDeviceOwnership(dom->conn, driver, dev, 0) < 0) + goto cleanup; + if (dev->data.disk->bus == VIR_DOMAIN_DISK_BUS_USB) { ret = qemudDomainAttachUsbMassstorageDevice(dom->conn, vm, dev); } else if (dev->data.disk->bus == VIR_DOMAIN_DISK_BUS_SCSI || @@ -4255,6 +4490,9 @@ static int qemudDomainAttachDevice(virDomainPtr dom, } else if (dev->type == VIR_DOMAIN_DEVICE_HOSTDEV && dev->data.hostdev->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS && dev->data.hostdev->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB) { + if (qemuDomainSetDeviceOwnership(dom->conn, driver, dev, 0) < 0) + goto cleanup; + ret = qemudDomainAttachHostDevice(dom->conn, vm, dev); } else { qemudReportError(dom->conn, dom, NULL, VIR_ERR_NO_SUPPORT, @@ -4267,8 +4505,11 @@ static int qemudDomainAttachDevice(virDomainPtr dom, ret = -1; cleanup: - if (ret < 0) + if (ret < 0) { + if (qemuDomainSetDeviceOwnership(dom->conn, driver, dev, 1) < 0) + VIR_WARN0("Fail to restore disk device ownership"); virDomainDeviceDefFree(dev); + } if (vm) virDomainObjUnlock(vm); qemuDriverUnlock(driver); @@ -4396,6 +4637,8 @@ static int qemudDomainDetachDevice(virDomainPtr dom, ret = qemudDomainDetachPciDiskDevice(dom->conn, vm, dev); if (driver->securityDriver) driver->securityDriver->domainRestoreSecurityImageLabel(dom->conn, dev->data.disk); + if (qemuDomainSetDeviceOwnership(dom->conn, driver, dev, 1) < 0) + VIR_WARN0("Fail to restore disk device ownership"); } else qemudReportError(dom->conn, dom, NULL, VIR_ERR_NO_SUPPORT, diff --git a/src/util.c b/src/util.c index 178ff0c..2420f8b 100644 --- a/src/util.c +++ b/src/util.c @@ -55,6 +55,7 @@ #include <netdb.h> #ifdef HAVE_GETPWUID_R #include <pwd.h> +#include <grp.h> #endif #if HAVE_CAPNG #include <cap-ng.h> @@ -1862,4 +1863,78 @@ char *virGetUserDirectory(virConnectPtr conn, return ret; } + + +int virGetUserID(virConnectPtr conn, + const char *name, + uid_t *uid) +{ + char *strbuf; + struct passwd pwbuf; + struct passwd *pw = NULL; + size_t strbuflen = sysconf(_SC_GETPW_R_SIZE_MAX); + + if (VIR_ALLOC_N(strbuf, strbuflen) < 0) { + virReportOOMError(conn); + return -1; + } + + /* + * From the manpage (terrifying but true): + * + * ERRORS + * 0 or ENOENT or ESRCH or EBADF or EPERM or ... + * The given name or uid was not found. + */ + if (getpwnam_r(name, &pwbuf, strbuf, strbuflen, &pw) != 0 || pw == NULL) { + virReportSystemError(conn, errno, + _("Failed to find user record for name '%s'"), + name); + VIR_FREE(strbuf); + return -1; + } + + *uid = pw->pw_uid; + + VIR_FREE(strbuf); + + return 0; +} + + +int virGetGroupID(virConnectPtr conn, + const char *name, + gid_t *gid) +{ + char *strbuf; + struct group grbuf; + struct group *gr = NULL; + size_t strbuflen = sysconf(_SC_GETGR_R_SIZE_MAX); + + if (VIR_ALLOC_N(strbuf, strbuflen) < 0) { + virReportOOMError(conn); + return -1; + } + + /* + * From the manpage (terrifying but true): + * + * ERRORS + * 0 or ENOENT or ESRCH or EBADF or EPERM or ... + * The given name or uid was not found. + */ + if (getgrnam_r(name, &grbuf, strbuf, strbuflen, &gr) != 0 || gr == NULL) { + virReportSystemError(conn, errno, + _("Failed to find group record for name '%s'"), + name); + VIR_FREE(strbuf); + return -1; + } + + *gid = gr->gr_gid; + + VIR_FREE(strbuf); + + return 0; +} #endif diff --git a/src/util.h b/src/util.h index 6dd005f..1a7286c 100644 --- a/src/util.h +++ b/src/util.h @@ -217,6 +217,12 @@ int virKillProcess(pid_t pid, int sig); #ifdef HAVE_GETPWUID_R char *virGetUserDirectory(virConnectPtr conn, uid_t uid); +int virGetUserID(virConnectPtr conn, + const char *name, + uid_t *uid); +int virGetGroupID(virConnectPtr conn, + const char *name, + gid_t *gid); #endif int virRandomInitialize(unsigned int seed); -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 2

[libvirt] [PATCH 0/9] Refactor remote protocol ready for data streams
by Daniel P. Berrange 17 Jul '09

17 Jul '09

The current libvirtd remote protocol dispatch code is written in such a way that assumes the only incoming messages from clients are method calls. This makes it very hard to support data streams. This patch series does an incrmental refactoring of alot of code to allow data streams to be easily wired in. Daniel P. Berrange (9): Split generic RPC message dispatch code out from remote protocol API handlers Decode incoming request header before invoking dispatch code Separate code for encoding outgoing remote message headers Change code generator to give async event messages their own postfix Move queuing of RPC replies into dispatch code Change the way client event loop watches are managed Split out code for handling incoming method call messages Define an API for registering incoming message dispatch filters Rename 'direction' to 'type' in remote_message_header qemud/Makefile.am | 3 +- qemud/dispatch.c | 533 ++++++++++++++++++++++++++++++++++++ qemud/dispatch.h | 63 +++++ qemud/qemud.c | 136 ++++++---- qemud/qemud.h | 35 ++- qemud/remote.c | 442 ++++-------------------------- qemud/remote.h | 72 +++++ qemud/remote_dispatch_prototypes.h | 7 - qemud/remote_dispatch_ret.h | 1 - qemud/remote_dispatch_table.h | 6 +- qemud/remote_generate_stubs.pl | 23 ++- qemud/remote_protocol.c | 6 +- qemud/remote_protocol.h | 18 +- qemud/remote_protocol.x | 66 ++++-- src/remote_internal.c | 18 +- 15 files changed, 926 insertions(+), 503 deletions(-) create mode 100644 qemud/dispatch.c create mode 100644 qemud/dispatch.h create mode 100644 qemud/remote.h -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 20

[libvirt] PATCH: Fix free of uninitialized data on PCI device failure
by Daniel P. Berrange 16 Jul '09

16 Jul '09

The pci.c file was freeing a variable that was not initialized in its failure path. This causes a crash if the user specifies a PCI device for a guest which does not exist commit 87f584fdd688865b4ea7f54d1b631f546535d8c2 Author: Daniel P. Berrange <berrange(a)redhat.com> Date: Thu Jul 16 13:23:32 2009 +0100 Fix free of unitialized data upon PCI open fail diff --git a/src/pci.c b/src/pci.c index 3ffa0aa..4030a14 100644 --- a/src/pci.c +++ b/src/pci.c @@ -834,10 +834,8 @@ pciReadDeviceID(pciDevice *dev, const char *id_name) dev->name, id_name); /* ID string is '0xNNNN\n' ... i.e. 7 bytes */ - if (virFileReadAll(path, 7, &id_str) < 7) { - VIR_FREE(id_str); + if (virFileReadAll(path, 7, &id_str) < 0) return NULL; - } /* Check for 0x suffix */ if (id_str[0] != '0' || id_str[1] != 'x') { -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1

[libvirt] Can not get domain's cpu time
by Zhang Qian 16 Jul '09

16 Jul '09

Hi, I have a domain running in my KVM box, and try to get its vcpu info by calling virDomainGetVcpus(), but it seems the cpu time returned to me is always 0. And I also found virsh can not get the CPU time too: $ virsh vcpuinfo aaa VCPU: 0 CPU: 0 State: running CPU Affinity: yy I tried the same virsh command in my Xen box for a running domain, the output is: $ virsh vcpuinfo test1 VCPU: 0 CPU: 1 State: running CPU time: 322.1s <----- I need this CPU Affinity: yy As you see, for KVM domain, there is no "CPU time". But it's very strange that virt-manager can show the right CPU usage for my running domain, I do not know where virt-manger gets it. Can anyone tell me which libvirt API should I call to get the CPU time? Thanks! Regards, Qian

3 3

[libvirt] PATCH: Handle changed monitor syntax for PCI hotplug/unplug
by Daniel P. Berrange 16 Jul '09

16 Jul '09

Annoyingly when PCI hotplug support was merged from KVM into QEMU the monitor syntax changed :-( This patch tries to deal with this by detecting the error message, and then re-trying with the alternative syntax. It also ensures the monitor error mesages is include with any libvirt error raised, so that we can more easily detect problems in the future FYI, I have a test case for this now in the TCK http://libvirt.org/git/?p=libvirt-tck.git;a=commit;h=0ea2a3f3c426b325f80981… Regards, Daniel >From fca1582a7406d9eef7ff1a5e108986df76aeb6a1 Mon Sep 17 00:00:00 2001 From: Daniel P. Berrange <berrange(a)redhat.com> Date: Mon, 6 Jul 2009 15:58:55 +0100 Subject: [PATCH 2/3] Fix PCI device hotplug/unplug with newer QEMU * src/qemu_driver.c: If hotplug/unplug fails, try with alternative monitor command syntax --- src/qemu_driver.c | 56 +++++++++++++++++++++++++++++++++++++++------------- 1 files changed, 42 insertions(+), 14 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index fdbbb56..25d446d 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -3915,6 +3915,7 @@ static int qemudDomainAttachPciDiskDevice(virConnectPtr conn, char *cmd, *reply, *s; char *safe_path; const char* type = virDomainDiskBusTypeToString(dev->data.disk->bus); + int tryAltSyntax = 0; for (i = 0 ; i < vm->def->ndisks ; i++) { if (STREQ(vm->def->disks[i]->dst, dev->data.disk->dst)) { @@ -3929,14 +3930,15 @@ static int qemudDomainAttachPciDiskDevice(virConnectPtr conn, return -1; } +try_command: safe_path = qemudEscapeMonitorArg(dev->data.disk->src); if (!safe_path) { virReportOOMError(conn); return -1; } - ret = virAsprintf(&cmd, "pci_add 0 storage file=%s,if=%s", - safe_path, type); + ret = virAsprintf(&cmd, "pci_add %s storage file=%s,if=%s", + (tryAltSyntax ? "pci_addr=auto" : "0"), safe_path, type); VIR_FREE(safe_path); if (ret == -1) { virReportOOMError(conn); @@ -3952,17 +3954,27 @@ static int qemudDomainAttachPciDiskDevice(virConnectPtr conn, DEBUG ("%s: pci_add reply: %s", vm->def->name, reply); /* If the command succeeds qemu prints: - * OK bus 0... */ -#define PCI_ATTACH_OK_MSG "OK bus 0, slot " - if ((s=strstr(reply, PCI_ATTACH_OK_MSG))) { - char* dummy = s; - s += strlen(PCI_ATTACH_OK_MSG); + * OK bus 0, slot XXX... + * or + * OK domain 0, bus 0, slot XXX + */ + if ((s = strstr(reply, "OK ")) && + (s = strstr(s, "slot "))) { + char *dummy = s; + s += strlen("slot "); if (virStrToLong_i ((const char*)s, &dummy, 10, &dev->data.disk->slotnum) == -1) VIR_WARN("%s", _("Unable to parse slot number\n")); + /* XXX not neccessarily always going to end up in domain 0 / bus 0 :-( */ + /* XXX this slotnum is not persistant across restarts :-( */ + } else if (!tryAltSyntax && strstr(reply, "Invalid pci address")) { + VIR_FREE(reply); + VIR_FREE(cmd); + tryAltSyntax = 1; + goto try_command; } else { qemudReportError (conn, dom, NULL, VIR_ERR_OPERATION_FAILED, - _("adding %s disk failed"), type); + _("adding %s disk failed: %s"), type, reply); VIR_FREE(reply); VIR_FREE(cmd); return -1; @@ -4179,6 +4191,7 @@ static int qemudDomainDetachPciDiskDevice(virConnectPtr conn, char *cmd = NULL; char *reply = NULL; virDomainDiskDefPtr detach = NULL; + int tryAltSyntax = 0; for (i = 0 ; i < vm->def->ndisks ; i++) { if (STREQ(vm->def->disks[i]->dst, dev->data.disk->dst)) { @@ -4200,9 +4213,17 @@ static int qemudDomainDetachPciDiskDevice(virConnectPtr conn, goto cleanup; } - if (virAsprintf(&cmd, "pci_del 0 %d", detach->slotnum) < 0) { - virReportOOMError(conn); - goto cleanup; +try_command: + if (tryAltSyntax) { + if (virAsprintf(&cmd, "pci_del pci_addr=0:0:%d", detach->slotnum) < 0) { + virReportOOMError(conn); + goto cleanup; + } + } else { + if (virAsprintf(&cmd, "pci_del 0 %d", detach->slotnum) < 0) { + virReportOOMError(conn); + goto cleanup; + } } if (qemudMonitorCommand(vm, cmd, &reply) < 0) { @@ -4212,12 +4233,19 @@ static int qemudDomainDetachPciDiskDevice(virConnectPtr conn, } DEBUG ("%s: pci_del reply: %s",vm->def->name, reply); + + if (!tryAltSyntax && + strstr(reply, "extraneous characters")) { + tryAltSyntax = 1; + goto try_command; + } /* If the command fails due to a wrong slot qemu prints: invalid slot, * nothing is printed on success */ - if (strstr(reply, "invalid slot")) { + if (strstr(reply, "invalid slot") || + strstr(reply, "Invalid pci address")) { qemudReportError (conn, NULL, NULL, VIR_ERR_OPERATION_FAILED, - _("failed to detach disk %s: invalid slot %d"), - detach->dst, detach->slotnum); + _("failed to detach disk %s: invalid slot %d: %s"), + detach->dst, detach->slotnum, reply); goto cleanup; } -- 1.6.2.5 -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 3

[libvirt] [PATCH] Fix the configure flags in spec file
by Daniel Veillard 16 Jul '09

16 Jul '09

Our libvirt spec file was still using old configuration options which had been deprecated. Fix that to use the new option, good thing the spec value matches the default ! Thanks for Chris Lalancette for raising this ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

2 1

[libvirt] Problem with libvirt and pci passthrough
by Mirko Raasch 16 Jul '09

16 Jul '09

Hi, i?m still having problem with libvirt and pci passthrough, if i use more then one pci card in the guest. If i start qemu 0.10.5 manualy, i can use all of the pci devices in the guest, here is the log: http://nopaste.info/610fa81fb5.html If i use libvirt to start the guest and passthrough three pci device, none of the device is usable in the guest: http://nopaste.info/ccfbfcf9a0.html Is there any limitation in libvirt? Greetings Mirko

1 0

[libvirt] PATCH: Relabel disk images *before* hotplugging
by Daniel P. Berrange 16 Jul '09

16 Jul '09

For some bizarre reason the original code we added for sVirt disk labelling with hotplug did not relabel the disks until after telling QEMU to hotplug. Clearly this is going to fail 99% of the time. It also forgot todo labelling when invoking a CDROM media change src/qemu_driver.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) Daniel diff --git a/src/qemu_driver.c b/src/qemu_driver.c index 25d446d..59c163c 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -4136,10 +4136,14 @@ static int qemudDomainAttachDevice(virDomainPtr dom, switch (dev->data.disk->device) { case VIR_DOMAIN_DISK_DEVICE_CDROM: case VIR_DOMAIN_DISK_DEVICE_FLOPPY: + if (driver->securityDriver) + driver->securityDriver->domainSetSecurityImageLabel(dom->conn, vm, dev->data.disk); ret = qemudDomainChangeEjectableMedia(dom->conn, vm, dev); break; case VIR_DOMAIN_DISK_DEVICE_DISK: + if (driver->securityDriver) + driver->securityDriver->domainSetSecurityImageLabel(dom->conn, vm, dev->data.disk); if (dev->data.disk->bus == VIR_DOMAIN_DISK_BUS_USB) { ret = qemudDomainAttachUsbMassstorageDevice(dom->conn, vm, dev); } else if (dev->data.disk->bus == VIR_DOMAIN_DISK_BUS_SCSI || @@ -4151,8 +4155,6 @@ static int qemudDomainAttachDevice(virDomainPtr dom, virDomainDiskBusTypeToString(dev->data.disk->bus)); goto cleanup; } - if (driver->securityDriver) - driver->securityDriver->domainSetSecurityImageLabel(dom->conn, vm, dev->data.disk); break; default: -- 1.6.2.5 -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1

[libvirt] PATCH Fix QEMU monitor prompt confusion
by Daniel P. Berrange 16 Jul '09

16 Jul '09

When you first connect to the QEMU monitor after a VM starts, it will print out QEMU 0.10.5 monitor - type 'help' for more information We already have code to detect & discard this. Unfortunately it seems that with QEMU >= 0.10.0 it will also print out this prompt when you disconnect and reconnect to the QEMU monitor. Except it doesn't print this out every time. It only appears to happen 50% of the time when libvirtd restarts and reconnects. When it does happen though it totally breaks all future monitor commands libvirt tries to run. This patch takes a fairly simple approach to solving it. Before running any QEMU monitor command, read and discard all pending data. 99% of the time there will be none, but if there is, this saves us from disaster. Daniel diff --git a/src/qemu_driver.c b/src/qemu_driver.c index 95ea882..fdbbb56 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -1656,6 +1656,28 @@ cleanup: qemuDriverUnlock(driver); } + +/* Throw away any data available on the monitor + * This is done before executing a command, in order + * to allow re-synchronization if something went badly + * wrong in the past. it also deals with problem of + * QEMU *sometimes* re-printing its initial greeting + * when we reconnect to the monitor after restarts. + */ +static void +qemuMonitorDiscardPendingData(virDomainObjPtr vm) { + char buf[1024]; + int ret = 0; + + /* Monitor is non-blocking, so just loop till we + * get -1 or 0. Don't bother with detecting + * errors, since we'll deal with that better later */ + do { + ret = read(vm->monitor, buf, sizeof (buf)-1); + } while (ret > 0); +} + + static int qemudMonitorCommandExtra(const virDomainObjPtr vm, const char *cmd, @@ -1667,6 +1689,8 @@ qemudMonitorCommandExtra(const virDomainObjPtr vm, size_t cmdlen = strlen(cmd); size_t extralen = extra ? strlen(extra) : 0; + qemuMonitorDiscardPendingData(vm); + if (safewrite(vm->monitor, cmd, cmdlen) != cmdlen) return -1; if (safewrite(vm->monitor, "\r", 1) != 1) -- 1.6.2.5 -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1

[libvirt] PATCH: Set stdout/err to /dev/null for spawned children
by Daniel P. Berrange 16 Jul '09

16 Jul '09

If passing a 'NULL' to virExec() for the stdout/err file descriptor it is intended that the child process get connected to /dev/null. This behaviour was previously broken when built with DEBUG enabled, and with Amy's recent logging change, it is now permanently broken. The problem this causes, is that the child process ends up still connected to the parent app's stderr/out. This causes things like Perl's test harness to hang waiting for end of file that will never come while libvirtd is running. THis patch puts virExec back to its original documented behaviour Daniel src/util.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/util.c b/src/util.c index f82cddc..178ff0c 100644 --- a/src/util.c +++ b/src/util.c @@ -376,6 +376,8 @@ __virExec(virConnectPtr conn, } else { childout = *outfd; } + } else { + childout = null; } if (errfd != NULL) { @@ -403,6 +405,8 @@ __virExec(virConnectPtr conn, } else { childerr = *errfd; } + } else { + childerr = null; } if ((pid = fork()) < 0) { -- 1.6.2.5 -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1

[libvirt] PATCH: Allow libvirtd autostart to be disabled
by Daniel P. Berrange 16 Jul '09

16 Jul '09

When connecting to a non-root libvirt driver, the remote libvirt will attempt to perform autostart of the libvirtd daemon. This is not always desirable, particularly in test scripts where you don't want the daemon autostarted every time it crashes - you want a clear failure Daniel src/remote_internal.c | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/remote_internal.c b/src/remote_internal.c index 6df0282..77b4810 100644 --- a/src/remote_internal.c +++ b/src/remote_internal.c @@ -972,6 +972,7 @@ remoteOpen (virConnectPtr conn, { struct private_data *priv; int ret, rflags = 0; + const char *autostart = getenv("LIBVIRT_AUTOSTART"); if (inside_daemon) return VIR_DRV_OPEN_DECLINED; @@ -998,7 +999,9 @@ remoteOpen (virConnectPtr conn, getuid() > 0) { DEBUG0("Auto-spawn user daemon instance"); rflags |= VIR_DRV_OPEN_REMOTE_USER; - rflags |= VIR_DRV_OPEN_REMOTE_AUTOSTART; + if (!autostart || + STRNEQ(autostart, "0")) + rflags |= VIR_DRV_OPEN_REMOTE_AUTOSTART; } /* @@ -1013,7 +1016,9 @@ remoteOpen (virConnectPtr conn, if (getuid() > 0) { DEBUG0("Auto-spawn user daemon instance"); rflags |= VIR_DRV_OPEN_REMOTE_USER; - rflags |= VIR_DRV_OPEN_REMOTE_AUTOSTART; + if (!autostart || + STRNEQ(autostart, "0")) + rflags |= VIR_DRV_OPEN_REMOTE_AUTOSTART; } #endif } -- 1.6.2.5 -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1

[libvirt] [PATCH] 1/3 add support for netcf XML import and export
by Daniel Veillard 16 Jul '09

16 Jul '09

Basically this implement the routines to read an netcf XML definition and build the associated internal data structures. It does the checking of the input XML up to making sure all the needed informations are availble in the right place, but does not check for extra data. It should support the full format as defined by interface.rng as of netcf version 0.1.0, both for input and output. This is rather repetitive and boring code, so I tried to factorize things following patterms similar to the one used in the grammar, the code reflects to a large extent the definition blocks there. The main data structure is virInterfaceDef, it defines the most common and shared attributes of all interfaces, the protocol definition allowed in the schemas is only ipv4 at the moment but with the expected extension to allow ipv6 in parallel I made a separate structure (currently embedded in the main one). There is a enum discriminating the specific structures needed for vlan, bride and bonding, and for the two last ones, a dynamically allocated array of bare interfaces (which can be of vlan or ethernet type, merged into a single structure). This passes valgrind, but since I'm not testing agaisnt misformed XML input I afraid of potential leaks on exit paths, otherwise this should be fine. Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

3 5

[libvirt] [PATCH] 3/3 Add netcf XML validation and input and output tests
by Daniel Veillard 16 Jul '09

16 Jul '09

Basic stuff similar to other tests, first we verify the input tests all conform to the provided schemas, then for each test we parse and reserialize verifying the output is identical. Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

2 2

[libvirt] Fix svirt handling of shared/readonly disks
by Daniel P. Berrange 15 Jul '09

15 Jul '09

The patch committed here commit 547147084d03ebf30d09d242a5a721a4df664ffe Author: Mark McLoughlin <markmc(a)redhat.com> Date: Fri Jul 3 10:26:37 2009 +0000 was not actually the latest version currently used in Fedora. It causes shared disks to be re-labelled upon VM shutdown, breaking any other guests still runing with this disk. The only safe option is to skip relabel for all readonly & shared disks Daniel diff --git a/src/security_selinux.c b/src/security_selinux.c index 80c1c85..0db9f49 100644 --- a/src/security_selinux.c +++ b/src/security_selinux.c @@ -354,6 +354,17 @@ SELinuxRestoreSecurityImageLabel(virConnectPtr conn, char *newpath = NULL; const char *path = disk->src; + /* Don't restore labels on readoly/shared disks, because + * other VMs may still be accessing these + * Alternatively we could iterate over all running + * domains and try to figure out if it is in use, but + * this would not work for clustered filesystems, since + * we can't see running VMs using the file on other nodes + * Safest bet is thus to skip the restore step. + */ + if (disk->readonly || disk->shared) + return 0; + if ((err = virFileResolveLink(path, &newpath)) < 0) { virReportSystemError(conn, err, _("cannot resolve symlink %s"), path); -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

1 0

[libvirt] [PATCH] 2/3 Add netcf XML schemas and test data
by Daniel Veillard 15 Jul '09

15 Jul '09

Directly imported from netcf-0.1.0 git with the exception that example have been changed to use single quote instead of double quote, otherwise unchanged. Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

2 1

[libvirt] [PATCH] build: submodule machinery now works also when no tag is reachable
by Jim Meyering 15 Jul '09

15 Jul '09

Mike Burns wrote: > I hit an issue with libvirt autobuild. I am running on an F11 machine and the build stage of libvirt--devel is failing. ... > I talked to danpb and he pointed out that there is a difference between .git-module-status and git submodule status: > > <danpb1> $ cat .git-module-status > <danpb1> -b653eda3ac4864de205419d9f41eec267cb89eeb .gnulib > <danpb1> git submodule status > <danpb1> b653eda3ac4864de205419d9f41eec267cb89eeb .gnulib (v0.0-2286-gb653eda) Hi Mike, Thanks for the report, and thanks to Dan for looking into it. Here's a patch: >From 3d3f1b105e4808d1c02f2132317bf815cf587604 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Wed, 15 Jul 2009 09:54:26 +0200 Subject: [PATCH] build: submodule machinery now works also when no tag is reachable The code in cfg.mk to detect when the git submodule was out of date worked most of the time, but not when checked out in a certain way. * cfg.mk: Extract submodule hash from command output and file, and compare only that, since the format of the full line may vary. Reported by Mike Burns, with some diagnosis by Daniel P Berrange. --- cfg.mk | 14 +++++++++++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/cfg.mk b/cfg.mk index 3b3d57f..a5514c4 100644 --- a/cfg.mk +++ b/cfg.mk @@ -233,9 +233,17 @@ prev_version_file = /dev/null ifeq (0,$(MAKELEVEL)) _curr_status = .git-module-status - _update_required := \ - $(shell t=$$(git submodule status); \ - test "$$t" = "$$(cat $(_curr_status) 2>/dev/null)"; echo $$?) + # The sed filter accommodates those who check out on a commit from which + # no tag is reachable. In that case, git submodule status prints a "-" + # in column 1 and does not print a "git describe"-style string after the + # submodule name. Contrast these: + # -b653eda3ac4864de205419d9f41eec267cb89eeb .gnulib + # b653eda3ac4864de205419d9f41eec267cb89eeb .gnulib (v0.0-2286-gb653eda) + _submodule_hash = sed 's/.//;s/ .*//' + _update_required := $(shell \ + actual=$$(git submodule status | $(_submodule_hash)); \ + stamp="$$($(_submodule_hash) $(_curr_status) 2>/dev/null)"; \ + test "$$stamp" = "$$actual"; echo $$?) ifeq (1,$(_update_required)) $(error gnulib update required; run ./autogen.sh first) endif -- 1.6.4.rc0.127.g81400

2 2

[libvirt] [PATCH] Update links to bugzilla
by Garry Dolley 15 Jul '09

15 Jul '09

* docs/bugs.html[.in]: Red Hat Enterprise Linux 5 specific tickets are under the 'Red Hat Enterprise Linux 5' product category. --- I forgot to update the RHEL 5 links in my previous patch, so here's another. docs/bugs.html | 2 +- docs/bugs.html.in | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/bugs.html b/docs/bugs.html index 55bcc2c..76653bb 100644 --- a/docs/bugs.html +++ b/docs/bugs.html @@ -93,7 +93,7 @@ If you are using official binaries from Red Hat Enterprise Linux distribution, tickets against the <code>Red Hat Enterprise Linux 5</code> product and the <code>libvirt</code> component. - <ul><li><a href="">View Red Hat Enterprise Linux libvirt tickets</a></li><li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Red%20Hat%20Enter…">New Red Hat Enterprise Linux libvirt ticket</a></li></ul></li><li> + <ul><li><a href="http://bugzilla.redhat.com/buglist.cgi?component=libvirt&product=Red%20…">View Red Hat Enterprise Linux libvirt tickets</a></li><li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Red%20Hat%20Enter…">New Red Hat Enterprise Linux libvirt ticket</a></li></ul></li><li> If you are using official binaries from another Linux distribution first follow their own bug reporting guidelines. </li></ul> diff --git a/docs/bugs.html.in b/docs/bugs.html.in index df26c15..62e3864 100644 --- a/docs/bugs.html.in +++ b/docs/bugs.html.in @@ -43,7 +43,7 @@ tickets against the <code>Red Hat Enterprise Linux 5</code> product and the <code>libvirt</code> component. <ul> - <li><a href="">View Red Hat Enterprise Linux libvirt tickets</a></li> + <li><a href="http://bugzilla.redhat.com/buglist.cgi?component=libvirt&product=Red%20…">View Red Hat Enterprise Linux libvirt tickets</a></li> <li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Red%20Hat%20Enter…">New Red Hat Enterprise Linux libvirt ticket</a></li> </ul> </li> -- 1.6.3.1

2 1

[libvirt] PATCH: Fix libvirtd autostart for test driver
by Daniel P. Berrange 15 Jul '09

15 Jul '09

Ensure test:/// URIs get routed to the non-privileged libvirtd * src/remote_internal.c: Ensure that all test:/// URIs are dealt with by the auto-started, per-user unprivileged libvirtd instances diff --git a/src/remote_internal.c b/src/remote_internal.c index 91e111e..e661daa 100644 --- a/src/remote_internal.c +++ b/src/remote_internal.c @@ -994,7 +994,8 @@ remoteOpen (virConnectPtr conn, conn->uri->scheme && ((strchr(conn->uri->scheme, '+') == 0)|| (strstr(conn->uri->scheme, "+unix") != NULL)) && - STREQ(conn->uri->path, "/session") && + (STREQ(conn->uri->path, "/session") || + STRPREFIX(conn->uri->scheme, "test+")) && getuid() > 0) { DEBUG0("Auto-spawn user daemon instance"); rflags |= VIR_DRV_OPEN_REMOTE_USER; -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1

[libvirt] PATCH: Fix bug in error reporting for security driver
by Daniel P. Berrange 15 Jul '09

15 Jul '09

There are a couple more bugs in the security driver error reporting code - The remote daemon driver was formatting a generic string error, instead of sending back the actual libvirt error - The public interface was not raising a full error, nor copying the error from the connection to the global error object Daniel diff -rup libvirt-0.6.3/qemud/remote.c libvirt-0.6.3.new/qemud/remote.c --- libvirt-0.6.3/qemud/remote.c 2009-04-24 09:12:05.000000000 -0400 +++ libvirt-0.6.3.new/qemud/remote.c 2009-07-13 06:30:02.000000000 -0400 @@ -1366,7 +1366,7 @@ remoteDispatchDomainGetSecurityLabel(str memset(&seclabel, 0, sizeof seclabel); if (virDomainGetSecurityLabel(dom, &seclabel) == -1) { virDomainFree(dom); - remoteDispatchFormatError(rerr, "%s", _("unable to get security label")); + remoteDispatchConnError(rerr, conn); return -1; } @@ -1395,7 +1395,7 @@ remoteDispatchNodeGetSecurityModel(struc memset(&secmodel, 0, sizeof secmodel); if (virNodeGetSecurityModel(conn, &secmodel) == -1) { - remoteDispatchFormatError(rerr, "%s", _("unable to get security model")); + remoteDispatchConnError(rerr, conn); return -1; } diff -rup libvirt-0.6.3/src/libvirt.c libvirt-0.6.3.new/src/libvirt.c --- libvirt-0.6.3/src/libvirt.c 2009-07-13 06:31:29.000000000 -0400 +++ libvirt-0.6.3.new/src/libvirt.c 2009-07-13 06:27:42.000000000 -0400 @@ -4212,15 +4212,24 @@ virDomainGetSecurityLabel(virDomainPtr d if (seclabel == NULL) { virLibDomainError(domain, VIR_ERR_INVALID_ARG, __FUNCTION__); - return -1; + goto error; } conn = domain->conn; - if (conn->driver->domainGetSecurityLabel) - return conn->driver->domainGetSecurityLabel(domain, seclabel); + if (conn->driver->domainGetSecurityLabel) { + int ret; + ret = conn->driver->domainGetSecurityLabel(domain, seclabel); + if (ret < 0) + goto error; + return ret; + } + + virLibConnError (conn, VIR_ERR_NO_SUPPORT, __FUNCTION__); - virLibConnWarning(conn, VIR_ERR_NO_SUPPORT, __FUNCTION__); +error: + /* Copy to connection error object for back compatability */ + virSetConnError(domain->conn); return -1; } @@ -4245,13 +4254,22 @@ virNodeGetSecurityModel(virConnectPtr co if (secmodel == NULL) { virLibConnError(conn, VIR_ERR_INVALID_ARG, __FUNCTION__); - return -1; + goto error; + } + + if (conn->driver->nodeGetSecurityModel) { + int ret; + ret = conn->driver->nodeGetSecurityModel(conn, secmodel); + if (ret < 0) + goto error; + return ret; } - if (conn->driver->nodeGetSecurityModel) - return conn->driver->nodeGetSecurityModel(conn, secmodel); + virLibConnError (conn, VIR_ERR_NO_SUPPORT, __FUNCTION__); - virLibConnWarning(conn, VIR_ERR_NO_SUPPORT, __FUNCTION__); +error: + /* Copy to connection error object for back compatability */ + virSetConnError(conn); return -1; } -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1

[libvirt] virsh migrate with libvirt-0.5.1: failed to start listening VM
by Jakub Hrozek 15 Jul '09

15 Jul '09

Hello, I was trying to migrate a KVM/QEMU VM running on a Fedora 10 host to another F10 host. Both machines have identical architectures (x86_64) and are running identical versions of libvirt and KVM (libvirt-0.5.1-2.fc10.x86_64, kvm-74-10.fc10.x86_64). However, the migration fails: # virsh migrate jhrozek-f11-minimal qemu+ssh://someothersystem.example.com/system libvir: QEMU error : operation failed: failed to start listening VM On the target host, the logfile /var/log/libvirt/qemu/jhrozek-f11-minimal.log says: qemu: could not open disk image /var/lib/libvirt/images/jhrozek-f11-minimal.img Which seems rather odd, isn't libvirt supposed to copy the image file? Is this supposed to work? Is there any way to debug the problem? I skimmed through RH Bugzilla and googled a bit but haven't found much clue. Help is appreciated, Jakub

4 3

[libvirt] Fedora Virtualization ... some comments and a request for help
by Gene Czarcinski 15 Jul '09

15 Jul '09

First some background ... For the last two to three weeks, I have been working with Fedora (Linux) virtualization ... specifically qemu/kvm. I have been a long time user of VMware and and am hoping to migrate to Fedora Virtualization ("to change my problem set"). I have successfully installed and run CentOS 5.3, Fedora 9, and Fedora 11 in both i386 and x86_64 flavors. I have also installed and run Win2k PRO. All of this worked just fine. Mostly I used virt-manager and only resorted to command-line software when there was no alternative. While I initially had some problems with the way sVirt was doing things, I installed the preview set of packages (libvirt 0.6.5, etc) and it is mostly "good enough" [I did find one "bug" which has been bugzillaed]. Now my problem! I am not sure if I am trying to do something which currently cannot be done, if I have found one or more bugs, or if I just need some help to point me in the right direction. I am trying to "migrate" some VMware guests over to qemu-kvm. I have tried Win2k guests, F9 guests, and F11 guests. Because I sense that the HW version of the disk images may be a problem, I made sure that all of the disk images were version 3 or 4. Using vmware-vdiskmanager, I converted any "split disks" into a single file. I tried using the vmdk files from wmare. I tried converting the files (using qemu-img) to both qcow2 and raw format. I tried using partimage-ng to save (on vmware) and then restore (on qemu-kvm) the disk images. Nothing works! For Win2k, the guest system starts booting and then I get a host system kernel oops. I also tried Win2k with qemu only (no kvm) ... the system started booting and then rebooted ... endlessly. For Fedora guests with LVM, grub brings in the kernel but then immediately fails because it cannot find the logical volumes. For Fedora guests with just /boot, swap, and / partitions, they fail after grub loads the kernel because (IIRC) "setuproot" fails ... it cannot find the root partition. I examined all of the virtual disk images that failed with guestfish and they all looked OK. I also attached some of these virtual disks and booted up under the rescue mode of the distribution DVD and the disks looked OK there too. BUT nothing worked! Then I ran some tests with guests created under qemu-kvm. I created a small guest by installing F11 on a SCSI drive (after doing a dance to swap things around). This scsi install installed and ran fine. I then took the disk image file and attached it to another guest as an IDE drive! This booted up and ran fine. Finally, I used partimage-ng to save the disk image originally created as SCSI and restored it to a different ide attached disk image ... this also booted up and ran fine. There is documentation out there (some, not a lot) which says that I should be able to "migrate" guests from VMware to qemu-kvm. For example: http://www.linux-kvm.org/page/How_To_Migrate_From_Vmware_To_KVM [I tried the above procedure, it did not work either] What am I doing wrong??? Any hints (let alone outright explanations) will be appreciated. BTW, there are statements that only vmdk version 3 and 4 formats ware supported. If that is true, why are there error messages issued when a vmdk file is processed which is not version 3 or 4? Gene

3 4

[libvirt] [PATCH] fix generation of .git-submodule-status
by Paolo Bonzini 15 Jul '09

15 Jul '09

When the .gnulib submodule is not initialized, "git submodule status" will prepend a dash in front of the submodule's SHA1. Currently, autogen.sh will then write the dashed SHA1 to its control file .git-submodule-status. This patch fixes the problem; the solution is to... * autogen.sh: Reinvoke git submodule status after bootstrap has initialized the submodule. --- autogen.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/autogen.sh b/autogen.sh index 415f3ec..c824a06 100755 --- a/autogen.sh +++ b/autogen.sh @@ -62,7 +62,7 @@ if test "$t" = "$(cat $curr_status 2>/dev/null)"; then : # good, it's up to date else echo running bootstrap... - ./bootstrap && echo "$t" > $curr_status + ./bootstrap && git submodule status > $curr_status fi # Automake requires that ChangeLog exist. -- 1.6.2.5

1 0

[libvirt] Can not shutdown and reboot KVM virtual machine
by Zhang Qian 14 Jul '09

14 Jul '09

Hi, I found I can not shutdown and reboot VMs in my KVM box. It seems I can shutdown a VM which has guest OS installed, but can not shutdown the VM which has no guest OS installed. Reboot can not work with this error message: this function is not supported by the hypervisor: virDomainReboot Any ideas? Thanks! I am using libvirt-0.6.4 and KVM-86. Regards, Qian

2 1

[libvirt] Moving Drivers to their respective directories under src/
by Pritesh Kothari 13 Jul '09

13 Jul '09

Hi All, Now since we have moved the repo from CVS => git can we consider moving each driver to its respective directory under src/. The src/ directory is too crowded with more then 150+ base files and more when you compile things. Also is there any way to output the compiled files to a separate out directory instead of keeping everything under src/. That would be advantages in two ways mainly one by reducing the entries in .gitignore (will be just out directory) and secondly will reduce the clutter by keeping src and output separate. Regards, Pritesh

2 1

[libvirt] [PATCH] Link to libvirt tickets on the Red Hat Bugzilla Server
by Garry Dolley 13 Jul '09

13 Jul '09

General tickets are under the 'Virtualization Tools' product category and Fedora specific tickets are under the 'Fedora' product category. The component is 'libvirt' in both cases. Signed-off-by: Garry Dolley <gdolley(a)ucla.edu> --- docs/bugs.html | 4 ++-- docs/bugs.html.in | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/bugs.html b/docs/bugs.html index b321505..55bcc2c 100644 --- a/docs/bugs.html +++ b/docs/bugs.html @@ -83,13 +83,13 @@ the <code>Virtualization Tools</code> product and the <code>libvirt</code> component. - <ul><li><a href="">View libvirt tickets</a></li><li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Virtualization%20…">New libvirt ticket</a></li></ul> + <ul><li><a href="http://bugzilla.redhat.com/buglist.cgi?component=libvirt&product=Virtua…">View libvirt tickets</a></li><li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Virtualization%20…">New libvirt ticket</a></li></ul> <h2>Linux Distribution specific bug reports</h2> <ul><li> If you are using official binaries from a Fedora distribution, enter tickets against the <code>Fedora</code> product and the <code>libvirt</code> component. - <ul><li><a href="">View Fedora libvirt tickets</a></li><li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Fedora&compon…">New Fedora libvirt ticket</a></li></ul></li><li> + <ul><li><a href="http://bugzilla.redhat.com/buglist.cgi?component=libvirt&product=Fedora">View Fedora libvirt tickets</a></li><li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Fedora&compon…">New Fedora libvirt ticket</a></li></ul></li><li> If you are using official binaries from Red Hat Enterprise Linux distribution, tickets against the <code>Red Hat Enterprise Linux 5</code> product and the <code>libvirt</code> component. diff --git a/docs/bugs.html.in b/docs/bugs.html.in index 0eb723a..df26c15 100644 --- a/docs/bugs.html.in +++ b/docs/bugs.html.in @@ -23,7 +23,7 @@ <ul> - <li><a href="">View libvirt tickets</a></li> + <li><a href="http://bugzilla.redhat.com/buglist.cgi?component=libvirt&product=Virtua…">View libvirt tickets</a></li> <li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Virtualization%20…">New libvirt ticket</a></li> </ul> @@ -34,7 +34,7 @@ tickets against the <code>Fedora</code> product and the <code>libvirt</code> component. <ul> - <li><a href="">View Fedora libvirt tickets</a></li> + <li><a href="http://bugzilla.redhat.com/buglist.cgi?component=libvirt&product=Fedora">View Fedora libvirt tickets</a></li> <li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Fedora&compon…">New Fedora libvirt ticket</a></li> </ul> </li> -- 1.6.3.1

2 1

[libvirt] PATCH 1/2: Support <video> element in domain config
by Daniel P. Berrange 13 Jul '09

13 Jul '09

This patch implements the basic domain config support for a <video> element as per http://www.redhat.com/archives/libvir-list/2009-May/msg00424.html Since last time this - Centralized the logic for default video model & default RAM - Added a type=vbox for their custom graphics card Daniel From: Daniel P. Berrange <berrange(a)redhat.com> Date: Mon, 6 Jul 2009 14:54:44 +0100 Subject: [PATCH 1/3] Support <video> tag for defining VGA card properties * docs/schemas/domain.rng: Define <video> element schema * src/domain_conf.c, src/domain_conf.h, src/libvirt_private.syms: Add parsing and formatting for <video> element --- docs/schemas/domain.rng | 34 +++++++ src/domain_conf.c | 225 ++++++++++++++++++++++++++++++++++++++++++++++ src/domain_conf.h | 29 ++++++ src/libvirt_private.syms | 5 + 4 files changed, 293 insertions(+), 0 deletions(-) diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng index 11cf04a..f857301 100644 --- a/docs/schemas/domain.rng +++ b/docs/schemas/domain.rng @@ -786,6 +786,39 @@ </element> </define>  + <define name="video"> + <element name="video"> + <optional> + <element name="model"> + <attribute name="type"> + <choice> + <value>vga</value> + <value>cirrus</value> + <value>vmvga</value> + <value>xen</value> + <value>vbox</value> + </choice> + </attribute> + <optional> + <attribute name="vram"> + <ref name="unsignedInt"/> + </attribute> + </optional> + <optional> + <attribute name="heads"> + <ref name="unsignedInt"/> + </attribute> + </optional> + </element> + </optional> + </element> + </define> +  @@ -1032,6 +1065,7 @@ <ref name="sound"/> <ref name="hostdev"/> <ref name="graphic"/> + <ref name="video"/> <ref name="console"/> <ref name="parallel"/> <ref name="serial"/> diff --git a/src/domain_conf.c b/src/domain_conf.c index ffa2aef..cc8c3ef 100644 --- a/src/domain_conf.c +++ b/src/domain_conf.c @@ -82,6 +82,7 @@ VIR_ENUM_IMPL(virDomainDevice, VIR_DOMAIN_DEVICE_LAST, "interface", "input", "sound", + "video", "hostdev") VIR_ENUM_IMPL(virDomainDisk, VIR_DOMAIN_DISK_TYPE_LAST, @@ -142,6 +143,13 @@ VIR_ENUM_IMPL(virDomainSoundModel, VIR_DOMAIN_SOUND_MODEL_LAST, "pcspk", "ac97") +VIR_ENUM_IMPL(virDomainVideo, VIR_DOMAIN_VIDEO_TYPE_LAST, + "vga", + "cirrus", + "vmvga", + "xen", + "vbox") + VIR_ENUM_IMPL(virDomainInput, VIR_DOMAIN_INPUT_TYPE_LAST, "mouse", "tablet") @@ -374,6 +382,14 @@ void virDomainSoundDefFree(virDomainSoundDefPtr def) VIR_FREE(def); } +void virDomainVideoDefFree(virDomainVideoDefPtr def) +{ + if (!def) + return; + + VIR_FREE(def); +} + void virDomainHostdevDefFree(virDomainHostdevDefPtr def) { if (!def) @@ -401,6 +417,9 @@ void virDomainDeviceDefFree(virDomainDeviceDefPtr def) case VIR_DOMAIN_DEVICE_SOUND: virDomainSoundDefFree(def->data.sound); break; + case VIR_DOMAIN_DEVICE_VIDEO: + virDomainVideoDefFree(def->data.video); + break; case VIR_DOMAIN_DEVICE_HOSTDEV: virDomainHostdevDefFree(def->data.hostdev); break; @@ -458,6 +477,10 @@ void virDomainDefFree(virDomainDefPtr def) virDomainSoundDefFree(def->sounds[i]); VIR_FREE(def->sounds); + for (i = 0 ; i < def->nvideos ; i++) + virDomainVideoDefFree(def->videos[i]); + VIR_FREE(def->videos); + for (i = 0 ; i < def->nhostdevs ; i++) virDomainHostdevDefFree(def->hostdevs[i]); VIR_FREE(def->hostdevs); @@ -1653,6 +1676,133 @@ error: goto cleanup; } + +int +virDomainVideoDefaultRAM(virDomainDefPtr def, + int type) +{ + switch (type) { + /* Wierd, QEMU defaults to 9 MB ??! */ + case VIR_DOMAIN_VIDEO_TYPE_VGA: + case VIR_DOMAIN_VIDEO_TYPE_CIRRUS: + case VIR_DOMAIN_VIDEO_TYPE_VMVGA: + if (def->virtType == VIR_DOMAIN_VIRT_VBOX) + return 8 * 1024; + else + return 9 * 1024; + break; + + case VIR_DOMAIN_VIDEO_TYPE_XEN: + /* Original Xen PVFB hardcoded to 4 MB */ + return 4 * 1024; + + default: + return 0; + } +} + + +int +virDomainVideoDefaultType(virDomainDefPtr def) +{ + switch (def->virtType) { + case VIR_DOMAIN_VIRT_TEST: + case VIR_DOMAIN_VIRT_QEMU: + case VIR_DOMAIN_VIRT_KQEMU: + case VIR_DOMAIN_VIRT_KVM: + case VIR_DOMAIN_VIRT_XEN: + if (def->os.type && + (STREQ(def->os.type, "xen") || + STREQ(def->os.type, "linux"))) + return VIR_DOMAIN_VIDEO_TYPE_XEN; + else + return VIR_DOMAIN_VIDEO_TYPE_CIRRUS; + + case VIR_DOMAIN_VIRT_VBOX: + return VIR_DOMAIN_VIDEO_TYPE_VBOX; + + default: + return -1; + } +} + +static virDomainVideoDefPtr +virDomainVideoDefParseXML(virConnectPtr conn, + const xmlNodePtr node, + virDomainDefPtr dom, + int flags ATTRIBUTE_UNUSED) { + virDomainVideoDefPtr def; + xmlNodePtr cur; + char *type = NULL; + char *heads = NULL; + char *vram = NULL; + + if (VIR_ALLOC(def) < 0) { + virReportOOMError(conn); + return NULL; + } + + cur = node->children; + while (cur != NULL) { + if (cur->type == XML_ELEMENT_NODE) { + if ((type == NULL) && (vram == NULL) && (heads == NULL) && + xmlStrEqual(cur->name, BAD_CAST "model")) { + type = virXMLPropString(cur, "type"); + vram = virXMLPropString(cur, "vram"); + heads = virXMLPropString(cur, "heads"); + } + } + cur = cur->next; + } + + if (type) { + if ((def->type = virDomainVideoTypeFromString(type)) < 0) { + virDomainReportError(conn, VIR_ERR_INTERNAL_ERROR, + _("unknown video model '%s'"), type); + goto error; + } + } else { + if ((def->type = virDomainVideoDefaultType(dom)) < 0) { + virDomainReportError(conn, VIR_ERR_INTERNAL_ERROR, "%s", + _("missing video model and cannot determine default")); + goto error; + } + } + + if (vram) { + if (virStrToLong_ui(vram, NULL, 10, &def->vram) < 0) { + virDomainReportError(conn, VIR_ERR_INTERNAL_ERROR, + _("cannot parse video ram '%s'"), vram); + goto error; + } + } else { + def->vram = virDomainVideoDefaultRAM(dom, def->type); + } + + if (heads) { + if (virStrToLong_ui(heads, NULL, 10, &def->heads) < 0) { + virDomainReportError(conn, VIR_ERR_INTERNAL_ERROR, + _("cannot parse video heads '%s'"), heads); + goto error; + } + } else { + def->heads = 1; + } + + VIR_FREE(type); + VIR_FREE(vram); + VIR_FREE(heads); + + return def; + +error: + virDomainVideoDefFree(def); + VIR_FREE(type); + VIR_FREE(vram); + VIR_FREE(heads); + return NULL; +} + static int virDomainHostdevSubsysUsbDefParseXML(virConnectPtr conn, const xmlNodePtr node, @@ -2091,6 +2241,10 @@ virDomainDeviceDefPtr virDomainDeviceDefParse(virConnectPtr conn, dev->type = VIR_DOMAIN_DEVICE_SOUND; if (!(dev->data.sound = virDomainSoundDefParseXML(conn, node, flags))) goto error; + } else if (xmlStrEqual(node->name, BAD_CAST "video")) { + dev->type = VIR_DOMAIN_DEVICE_VIDEO; + if (!(dev->data.video = virDomainVideoDefParseXML(conn, node, def, flags))) + goto error; } else if (xmlStrEqual(node->name, BAD_CAST "hostdev")) { dev->type = VIR_DOMAIN_DEVICE_HOSTDEV; if (!(dev->data.hostdev = virDomainHostdevDefParseXML(conn, node, flags))) @@ -2649,6 +2803,47 @@ static virDomainDefPtr virDomainDefParseXML(virConnectPtr conn, } VIR_FREE(nodes); + /* analysis of the video devices */ + if ((n = virXPathNodeSet(conn, "./devices/video", ctxt, &nodes)) < 0) { + virDomainReportError(conn, VIR_ERR_INTERNAL_ERROR, + "%s", _("cannot extract video devices")); + goto error; + } + if (n && VIR_ALLOC_N(def->videos, n) < 0) + goto no_memory; + for (i = 0 ; i < n ; i++) { + virDomainVideoDefPtr video = virDomainVideoDefParseXML(conn, + nodes[i], + def, + flags); + if (!video) + goto error; + def->videos[def->nvideos++] = video; + } + VIR_FREE(nodes); + + /* For backwards compatability, if no <video> tag is set but there + * is a <graphics> tag, then we add a single video tag */ + if (def->ngraphics && !def->nvideos) { + virDomainVideoDefPtr video; + if (VIR_ALLOC(video) < 0) + goto no_memory; + video->type = virDomainVideoDefaultType(def); + if (video->type < 0) { + virDomainReportError(conn, VIR_ERR_INTERNAL_ERROR, "%s", + _("cannot determine default video type")); + VIR_FREE(video); + goto error; + } + video->vram = virDomainVideoDefaultRAM(def, video->type); + video->heads = 1; + if (VIR_ALLOC_N(def->videos, 1) < 0) { + virDomainVideoDefFree(video); + goto no_memory; + } + def->videos[def->nvideos++] = video; + } + /* analysis of the host devices */ if ((n = virXPathNodeSet(conn, "./devices/hostdev", ctxt, &nodes)) < 0) { virDomainReportError(conn, VIR_ERR_INTERNAL_ERROR, @@ -3486,6 +3681,32 @@ virDomainSoundDefFormat(virConnectPtr conn, } static int +virDomainVideoDefFormat(virConnectPtr conn, + virBufferPtr buf, + virDomainVideoDefPtr def) +{ + const char *model = virDomainVideoTypeToString(def->type); + + if (!model) { + virDomainReportError(conn, VIR_ERR_INTERNAL_ERROR, + _("unexpected video model %d"), def->type); + return -1; + } + + virBufferAddLit(buf, " <video>\n"); + virBufferVSprintf(buf, " <model type='%s'", + model); + if (def->vram) + virBufferVSprintf(buf, " vram='%u'", def->vram); + if (def->heads) + virBufferVSprintf(buf, " heads='%u'", def->heads); + virBufferAddLit(buf, "/>\n"); + virBufferAddLit(buf, " </video>\n"); + + return 0; +} + +static int virDomainInputDefFormat(virConnectPtr conn, virBufferPtr buf, virDomainInputDefPtr def) @@ -3860,6 +4081,10 @@ char *virDomainDefFormat(virConnectPtr conn, if (virDomainSoundDefFormat(conn, &buf, def->sounds[n]) < 0) goto cleanup; + for (n = 0 ; n < def->nvideos ; n++) + if (virDomainVideoDefFormat(conn, &buf, def->videos[n]) < 0) + goto cleanup; + for (n = 0 ; n < def->nhostdevs ; n++) if (virDomainHostdevDefFormat(conn, &buf, def->hostdevs[n]) < 0) goto cleanup; diff --git a/src/domain_conf.h b/src/domain_conf.h index 51310c1..51dd6d3 100644 --- a/src/domain_conf.h +++ b/src/domain_conf.h @@ -265,6 +265,26 @@ struct _virDomainSoundDef { int model; }; + +enum virDomainVideoType { + VIR_DOMAIN_VIDEO_TYPE_VGA, + VIR_DOMAIN_VIDEO_TYPE_CIRRUS, + VIR_DOMAIN_VIDEO_TYPE_VMVGA, + VIR_DOMAIN_VIDEO_TYPE_XEN, + VIR_DOMAIN_VIDEO_TYPE_VBOX, + + VIR_DOMAIN_VIDEO_TYPE_LAST +}; + + +typedef struct _virDomainVideoDef virDomainVideoDef; +typedef virDomainVideoDef *virDomainVideoDefPtr; +struct _virDomainVideoDef { + int type; + unsigned int vram; + unsigned int heads; +}; + /* 3 possible graphics console modes */ enum virDomainGraphicsType { VIR_DOMAIN_GRAPHICS_TYPE_SDL, @@ -361,6 +381,7 @@ enum virDomainDeviceType { VIR_DOMAIN_DEVICE_NET, VIR_DOMAIN_DEVICE_INPUT, VIR_DOMAIN_DEVICE_SOUND, + VIR_DOMAIN_DEVICE_VIDEO, VIR_DOMAIN_DEVICE_HOSTDEV, VIR_DOMAIN_DEVICE_LAST, @@ -376,6 +397,7 @@ struct _virDomainDeviceDef { virDomainNetDefPtr net; virDomainInputDefPtr input; virDomainSoundDefPtr sound; + virDomainVideoDefPtr video; virDomainHostdevDefPtr hostdev; } data; }; @@ -492,6 +514,9 @@ struct _virDomainDef { int nsounds; virDomainSoundDefPtr *sounds; + int nvideos; + virDomainVideoDefPtr *videos; + int nhostdevs; virDomainHostdevDefPtr *hostdevs; @@ -557,6 +582,7 @@ void virDomainFSDefFree(virDomainFSDefPtr def); void virDomainNetDefFree(virDomainNetDefPtr def); void virDomainChrDefFree(virDomainChrDefPtr def); void virDomainSoundDefFree(virDomainSoundDefPtr def); +void virDomainVideoDefFree(virDomainVideoDefPtr def); void virDomainHostdevDefFree(virDomainHostdevDefPtr def); void virDomainDeviceDefFree(virDomainDeviceDefPtr def); void virDomainDefFree(virDomainDefPtr vm); @@ -666,6 +692,8 @@ int virDiskNameToBusDeviceIndex(virDomainDiskDefPtr disk, int *devIdx); virDomainFSDefPtr virDomainGetRootFilesystem(virDomainDefPtr def); +int virDomainVideoDefaultType(virDomainDefPtr def); +int virDomainVideoDefaultRAM(virDomainDefPtr def, int type); void virDomainObjLock(virDomainObjPtr obj); void virDomainObjUnlock(virDomainObjPtr obj); @@ -683,6 +711,7 @@ VIR_ENUM_DECL(virDomainFS) VIR_ENUM_DECL(virDomainNet) VIR_ENUM_DECL(virDomainChr) VIR_ENUM_DECL(virDomainSoundModel) +VIR_ENUM_DECL(virDomainVideo) VIR_ENUM_DECL(virDomainHostdevMode) VIR_ENUM_DECL(virDomainHostdevSubsys) VIR_ENUM_DECL(virDomainInput) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index bd7910b..d43620f 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -100,6 +100,11 @@ virDomainSaveStatus; virDomainSoundDefFree; virDomainSoundModelTypeFromString; virDomainSoundModelTypeToString; +virDomainVideoDefFree; +virDomainVideoTypeToString; +virDomainVideoTypeFromString; +virDomainVideoDefaultRAM; +virDomainVideoDefaultType; virDomainVirtTypeToString; virDomainFSDefFree; virDomainObjLock; -- 1.6.2.5 -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

3 3

[libvirt] [PATCH] Link to libvirt tickets on the Red Hat Bugzilla Server
by Garry Dolley 13 Jul '09

13 Jul '09

General tickets are under the 'Virtualization Tools' product category and Fedora specific tickets are under the 'Fedora' product category. The component is 'libvirt' in both cases. Signed-off-by: Garry Dolley <gdolley(a)ucla.edu> --- docs/bugs.html | 4 ++-- docs/bugs.html.in | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/bugs.html b/docs/bugs.html index b321505..55bcc2c 100644 --- a/docs/bugs.html +++ b/docs/bugs.html @@ -83,13 +83,13 @@ the <code>Virtualization Tools</code> product and the <code>libvirt</code> component. - <ul><li><a href="">View libvirt tickets</a></li><li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Virtualization%20…">New libvirt ticket</a></li></ul> + <ul><li><a href="http://bugzilla.redhat.com/buglist.cgi?component=libvirt&product=Virtua…">View libvirt tickets</a></li><li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Virtualization%20…">New libvirt ticket</a></li></ul> <h2>Linux Distribution specific bug reports</h2> <ul><li> If you are using official binaries from a Fedora distribution, enter tickets against the <code>Fedora</code> product and the <code>libvirt</code> component. - <ul><li><a href="">View Fedora libvirt tickets</a></li><li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Fedora&compon…">New Fedora libvirt ticket</a></li></ul></li><li> + <ul><li><a href="http://bugzilla.redhat.com/buglist.cgi?component=libvirt&product=Fedora">View Fedora libvirt tickets</a></li><li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Fedora&compon…">New Fedora libvirt ticket</a></li></ul></li><li> If you are using official binaries from Red Hat Enterprise Linux distribution, tickets against the <code>Red Hat Enterprise Linux 5</code> product and the <code>libvirt</code> component. diff --git a/docs/bugs.html.in b/docs/bugs.html.in index 0eb723a..df26c15 100644 --- a/docs/bugs.html.in +++ b/docs/bugs.html.in @@ -23,7 +23,7 @@ <ul> - <li><a href="">View libvirt tickets</a></li> + <li><a href="http://bugzilla.redhat.com/buglist.cgi?component=libvirt&product=Virtua…">View libvirt tickets</a></li> <li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Virtualization%20…">New libvirt ticket</a></li> </ul> @@ -34,7 +34,7 @@ tickets against the <code>Fedora</code> product and the <code>libvirt</code> component. <ul> - <li><a href="">View Fedora libvirt tickets</a></li> + <li><a href="http://bugzilla.redhat.com/buglist.cgi?component=libvirt&product=Fedora">View Fedora libvirt tickets</a></li> <li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Fedora&compon…">New Fedora libvirt ticket</a></li> </ul> </li> -- 1.6.3.1 !DSPAM:4a5792d46141992511921!

2 1

[libvirt] [PATCH] Fix docs and code disagreements for character devices.
by Cole Robinson 12 Jul '09

12 Jul '09

The 'pipe' character type wasn't documented. TCP uses a <protocol> element, not <wire> We weren't doing strict validation for protocol and source mode values. Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- docs/formatdomain.html | 18 +++++++++++++++++- docs/formatdomain.html.in | 17 ++++++++++++++++- src/domain_conf.c | 23 ++++++++++++++++++----- 3 files changed, 51 insertions(+), 7 deletions(-) diff --git a/docs/formatdomain.html b/docs/formatdomain.html index bb6da11..0b21c6b 100644 --- a/docs/formatdomain.html +++ b/docs/formatdomain.html @@ -181,6 +181,8 @@ </li><li> <a href="#elementsCharHost">Host device proxy</a> </li><li> + <a href="#elementsCharPipe">Named pipe</a> + </li><li> <a href="#elementsCharTCP">TCP client/server</a> </li><li> <a href="#elementsCharUDP">UDP network console</a> @@ -879,6 +881,20 @@ qemu-kvm -net nic,model=? /dev/null </serial> ...</pre> <h5> + <a name="elementsCharPipe" id="elementsCharPipe">Named pipe</a> + </h5> + + The character device writes output to a named pipe. See pipe(7) for + more info. + + <pre> + ... + <serial type="pipe"> + <source path="/tmp/mypipe"/> + <target port="1"/> + </serial> + ...</pre> + <h5> <a name="elementsCharTCP" id="elementsCharTCP">TCP client/server</a> </h5> @@ -889,7 +905,7 @@ qemu-kvm -net nic,model=? /dev/null ... <serial type="tcp"> <source mode="connect" host="0.0.0.0" service="2445"/> - <wiremode type="telnet"/> + <protocol type="telnet"/> <target port="1"/> </serial> ...</pre> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 48d689d..191b03e 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -839,6 +839,21 @@ qemu-kvm -net nic,model=? /dev/null </serial> ...</pre> + <h5><a name="elementsCharPipe">Named pipe</a></h5> + + + The character device writes output to a named pipe. See pipe(7) for + more info. + + + <pre> + ... + <serial type="pipe"> + <source path="/tmp/mypipe"/> + <target port="1"/> + </serial> + ...</pre> + <h5><a name="elementsCharTCP">TCP client/server</a></h5> @@ -850,7 +865,7 @@ qemu-kvm -net nic,model=? /dev/null ... <serial type="tcp"> <source mode="connect" host="0.0.0.0" service="2445"/> - <wiremode type="telnet"/> + <protocol type="telnet"/> <target port="1"/> </serial> ...</pre> diff --git a/src/domain_conf.c b/src/domain_conf.c index cc8c3ef..a04a131 100644 --- a/src/domain_conf.c +++ b/src/domain_conf.c @@ -1169,6 +1169,7 @@ error: * <serial type="tcp"> * <source mode="bind" host="0.0.0.0" service="2445"/> * <target port="1"/> + * <protocol type='raw'/> * </serial> * * <serial type="udp"> @@ -1257,11 +1258,16 @@ virDomainChrDefParseXML(virConnectPtr conn, connectHost = virXMLPropString(cur, "host"); if (connectService == NULL) connectService = virXMLPropString(cur, "service"); - } else { + } else if (STREQ((const char *)mode, "bind")) { if (bindHost == NULL) bindHost = virXMLPropString(cur, "host"); if (bindService == NULL) bindService = virXMLPropString(cur, "service"); + } else { + virDomainReportError(conn, VIR_ERR_INTERNAL_ERROR, + _("Unknown source mode '%s'"), + mode); + goto error; } if (def->type == VIR_DOMAIN_CHR_TYPE_UDP) @@ -1340,11 +1346,18 @@ virDomainChrDefParseXML(virConnectPtr conn, bindService = NULL; def->data.tcp.listen = 1; } - if (protocol != NULL && - STREQ(protocol, "telnet")) - def->data.tcp.protocol = VIR_DOMAIN_CHR_TCP_PROTOCOL_TELNET; - else + + if (protocol == NULL || + STREQ(protocol, "raw")) def->data.tcp.protocol = VIR_DOMAIN_CHR_TCP_PROTOCOL_RAW; + else if (STREQ(protocol, "telnet")) + def->data.tcp.protocol = VIR_DOMAIN_CHR_TCP_PROTOCOL_TELNET; + else { + virDomainReportError(conn, VIR_ERR_INTERNAL_ERROR, + _("Unknown protocol '%s'"), protocol); + goto error; + } + break; case VIR_DOMAIN_CHR_TYPE_UDP: -- 1.6.0.6

3 3

[libvirt] [PATCH] qemu: Check driver is initialized up front, to avoid segfault.
by Cole Robinson 12 Jul '09

12 Jul '09

If the qemu_driver was not initialized (possibly due to an error on driver startup), we can segfault if attempting to connect to the URI. Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- src/qemu_driver.c | 14 ++++++-------- 1 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index 95ea882..a9b4850 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -1779,6 +1779,12 @@ static virDrvOpenStatus qemudOpen(virConnectPtr conn, if (conn->uri->server != NULL) return VIR_DRV_OPEN_DECLINED; + if (qemu_driver == NULL) { + qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, "%s", + _("qemu state driver is not active")); + return VIR_DRV_OPEN_ERROR; + } + if (qemu_driver->privileged) { if (STRNEQ (conn->uri->path, "/system") && STRNEQ (conn->uri->path, "/session")) { @@ -1795,14 +1801,6 @@ static virDrvOpenStatus qemudOpen(virConnectPtr conn, return VIR_DRV_OPEN_ERROR; } } - - /* URI was good, but driver isn't active */ - if (qemu_driver == NULL) { - qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, "%s", - _("qemu state driver is not active")); - return VIR_DRV_OPEN_ERROR; - } - } conn->privateData = qemu_driver; -- 1.6.0.6

3 3

[libvirt] [PATCH] Link to libvirt tickets on the Red Hat Bugzilla Server
by gdolley＠arpnetworks.com 11 Jul '09

11 Jul '09

From: Garry Dolley <gdolley(a)ucla.edu> General tickets are under the 'Virtualization Tools' product category and Fedora specific tickets are under the 'Fedora' product category. The component is 'libvirt' in both cases. Signed-off-by: Garry Dolley <gdolley(a)ucla.edu> --- docs/bugs.html | 4 ++-- docs/bugs.html.in | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/bugs.html b/docs/bugs.html index b321505..55bcc2c 100644 --- a/docs/bugs.html +++ b/docs/bugs.html @@ -83,13 +83,13 @@ the <code>Virtualization Tools</code> product and the <code>libvirt</code> component. - <ul><li><a href="">View libvirt tickets</a></li><li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Virtualization%20…">New libvirt ticket</a></li></ul> + <ul><li><a href="http://bugzilla.redhat.com/buglist.cgi?component=libvirt&product=Virtua…">View libvirt tickets</a></li><li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Virtualization%20…">New libvirt ticket</a></li></ul> <h2>Linux Distribution specific bug reports</h2> <ul><li> If you are using official binaries from a Fedora distribution, enter tickets against the <code>Fedora</code> product and the <code>libvirt</code> component. - <ul><li><a href="">View Fedora libvirt tickets</a></li><li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Fedora&compon…">New Fedora libvirt ticket</a></li></ul></li><li> + <ul><li><a href="http://bugzilla.redhat.com/buglist.cgi?component=libvirt&product=Fedora">View Fedora libvirt tickets</a></li><li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Fedora&compon…">New Fedora libvirt ticket</a></li></ul></li><li> If you are using official binaries from Red Hat Enterprise Linux distribution, tickets against the <code>Red Hat Enterprise Linux 5</code> product and the <code>libvirt</code> component. diff --git a/docs/bugs.html.in b/docs/bugs.html.in index 0eb723a..df26c15 100644 --- a/docs/bugs.html.in +++ b/docs/bugs.html.in @@ -23,7 +23,7 @@ <ul> - <li><a href="">View libvirt tickets</a></li> + <li><a href="http://bugzilla.redhat.com/buglist.cgi?component=libvirt&product=Virtua…">View libvirt tickets</a></li> <li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Virtualization%20…">New libvirt ticket</a></li> </ul> @@ -34,7 +34,7 @@ tickets against the <code>Fedora</code> product and the <code>libvirt</code> component. <ul> - <li><a href="">View Fedora libvirt tickets</a></li> + <li><a href="http://bugzilla.redhat.com/buglist.cgi?component=libvirt&product=Fedora">View Fedora libvirt tickets</a></li> <li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Fedora&compon…">New Fedora libvirt ticket</a></li> </ul> </li> -- 1.6.3.1

1 0

[libvirt] Is virConnectListDefinedDomains broken?
by Hongming Xiao 11 Jul '09

11 Jul '09

Hi, list, Recently, I upgraded my system to Xen 3.3.1 (from Xen 3.0.3). After this, I found that virConnectListDefinedDomains no longer works. The problem can be reproduced by executing "virsh list -all" - those defined but inactive domains are not be returned. Has libvirt API been tested against Xen 3.3.1? Can this problem be fixed by upgrading libvirt to version 0.6.5? What is the best approach to address this issue? Thanks in advance, Eddy OS: CentOS 5.3 Xen: kernel-xen.x86_64 2.6.18-128.1.14.el5 installed kmod-drbd83-xen.x86_64 8.3.0-3 installed xen.x86_64 3.3.1-0 installed xen-libs.x86_64 3.3.1-0 installed libvirt: libvirt.x86_64 0.4.4-3 installed libvirt-python.x86_64 0.4.4-3 installed python-virtinst.noarch 0.300.2-12.el5 installed virt-viewer.x86_64 0.0.2-2.el5 installed

2 1

[libvirt] sound does not work for me
by Gene Czarcinski 11 Jul '09

11 Jul '09

I must must be doing something wrong because all the messages, etc. I have found says that sound works for guests. I let the guest's virtual sound device default to ES1370. I have tried f11 32 bit, f11 64 bit, and win2k and sound just does not work for any of them. I tried this with F11 64 bit host (libvirt 0.6.2) and a different F11 64 bit host with preview packages installed (libvirt 0.6.5) ... sound works on each of the host system but does not work for an guests. With a F11 64 bit guest, the sound preference applet shows the output device os "null". Also, doing "lspci" shows NO sound device. OK, what is going on? Gene

2 2

[libvirt] fix two "make syntax-check" failures
by Jim Meyering 11 Jul '09

11 Jul '09

Mark McLoughlin pointed out this failure: ChangeLog-old: if (foo) free (foo) ChangeLog-old: if (foo != NULL) free (foo) maint.mk: found useless "if" before "free" above make: *** [sc_avoid_if_before_free] Error 1 Here's the other: --- po/POTFILES.in +++ po/POTFILES.in @@ -1,3 +1,4 @@ +cfg.mk qemud/qemud.c qemud/remote.c src/bridge.c maint.mk: you have changed the set of files with translatable diagnostics; apply the above patch I had fixed the latter in gnulib (now that main.mk comes from there), but had forgotten to tell libvirt to use the latest version of gnulib, in order to get that fix. To do that, I ran "git syncsub" (where syncsub is an alias: syncsub = submodule foreach git pull origin master) then git commit -a. Here are the two patches I'm about to push: >From bcf2aed1a91e66fee823e9063050c14bfc4ca29d Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Thu, 9 Jul 2009 20:00:37 +0200 Subject: [PATCH 1/2] avoid a "make syntax-check" failure * .x-sc_avoid_if_before_free: Ignore *all* ChangeLog files, now, including ChangeLog-old. --- .x-sc_avoid_if_before_free | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/.x-sc_avoid_if_before_free b/.x-sc_avoid_if_before_free index 5093ef6..7e6ce62 100644 --- a/.x-sc_avoid_if_before_free +++ b/.x-sc_avoid_if_before_free @@ -1,5 +1 @@ -^gnulib/lib/getaddrinfo\.c$ -^gnulib/lib/printf-parse\.c$ -^gnulib/lib/vasnprintf\.c$ -^build-aux/useless-if-before-free$ -^ChangeLog$ +^ChangeLog -- 1.6.3.3.524.g8586b >From 72978b978991f106dc0e36b10a942d9040a1df00 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Thu, 9 Jul 2009 20:02:31 +0200 Subject: [PATCH 2/2] build: update from gnulib, for latest maint.mk * gnulib: Update submodule to latest. This fixes the make syntax-check failure whereby sc_po_check would complain about cfg.mk. --- .gnulib | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/.gnulib b/.gnulib index 1203e8d..b653eda 160000 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit 1203e8d1f62dec3d2436dffadd5c20793cf84366 +Subproject commit b653eda3ac4864de205419d9f41eec267cb89eeb -- 1.6.3.3.524.g8586b

4 10

[libvirt] libvirt repositories mirrored on gitorious
by Daniel P. Berrange 10 Jul '09

10 Jul '09

FYI, I have created a libvirt project on gitorious which has a mirror of the master branch of the libvirt.git repository. This mirror is *readonly* and updated automatically every 15 minutes. The purpose of this mirror is to allow people to easily publish their personal libvirt working repos to the world. The master upstream repository for libvirt does not change, it will remain on http://libvirt.org/git The main project under which libvirt repos will be hosted is at this URL: http://gitorious.org/libvirt You'll see the master libvirt.git repository there, and if you look at the right hand side, you'll see myself & Mark have both got clones for our staging repos, and topic branches within those clones for various patchsets we're working on If you want to publish your own patches simply signup for gitorious, go to the libvirt repository http://gitorious.org/libvirt/libvirt and select the 'Clone this repository on gitorious' link. A short while later you'll have your own personal clone where you can publish work you are doing on libvirt. Use of this is by no means compulsory, and doesn't change how you should submit patches to libvirt. They should still all be emailed to this list for review. Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

1 0

[libvirt] [PATCH] Use virDomainChrTypeFromString() instead of open coding
by Mark McLoughlin 10 Jul '09

10 Jul '09

* src/domain_conf.c: replace open coded chr type parsing with virDomainChrTypeFromString(), retaining the existing semantics where unknown types are silently mapped to the "null" type and "pty" is used if none is specified --- src/domain_conf.c | 29 ++++------------------------- 1 files changed, 4 insertions(+), 25 deletions(-) diff --git a/src/domain_conf.c b/src/domain_conf.c index 0407207..4056a86 100644 --- a/src/domain_conf.c +++ b/src/domain_conf.c @@ -1204,32 +1204,11 @@ virDomainChrDefParseXML(virConnectPtr conn, return NULL; } - def->type = VIR_DOMAIN_CHR_TYPE_PTY; type = virXMLPropString(node, "type"); - if (type != NULL) { - if (STREQ(type, "null")) - def->type = VIR_DOMAIN_CHR_TYPE_NULL; - else if (STREQ(type, "vc")) - def->type = VIR_DOMAIN_CHR_TYPE_VC; - else if (STREQ(type, "pty")) - def->type = VIR_DOMAIN_CHR_TYPE_PTY; - else if (STREQ(type, "dev")) - def->type = VIR_DOMAIN_CHR_TYPE_DEV; - else if (STREQ(type, "file")) - def->type = VIR_DOMAIN_CHR_TYPE_FILE; - else if (STREQ(type, "pipe")) - def->type = VIR_DOMAIN_CHR_TYPE_PIPE; - else if (STREQ(type, "stdio")) - def->type = VIR_DOMAIN_CHR_TYPE_STDIO; - else if (STREQ(type, "udp")) - def->type = VIR_DOMAIN_CHR_TYPE_UDP; - else if (STREQ(type, "tcp")) - def->type = VIR_DOMAIN_CHR_TYPE_TCP; - else if (STREQ(type, "unix")) - def->type = VIR_DOMAIN_CHR_TYPE_UNIX; - else - def->type = VIR_DOMAIN_CHR_TYPE_NULL; - } + if (type == NULL) + def->type = VIR_DOMAIN_CHR_TYPE_PTY; + else if ((def->type = virDomainChrTypeFromString(type)) < 0) + def->type = VIR_DOMAIN_CHR_TYPE_NULL; cur = node->children; while (cur != NULL) { -- 1.6.2.5

2 1

[libvirt] [PATCH] Link to libvirt tickets on the Red Hat Bugzilla Server
by Garry Dolley 10 Jul '09

10 Jul '09

General tickets are under the 'Virtualization Tools' product category and Fedora specific tickets are under the 'Fedora' product category. The component is 'libvirt' in both cases. Signed-off-by: Garry Dolley <gdolley(a)ucla.edu> --- docs/bugs.html | 4 ++-- docs/bugs.html.in | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/bugs.html b/docs/bugs.html index b321505..55bcc2c 100644 --- a/docs/bugs.html +++ b/docs/bugs.html @@ -83,13 +83,13 @@ the <code>Virtualization Tools</code> product and the <code>libvirt</code> component. - <ul><li><a href="">View libvirt tickets</a></li><li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Virtualization%20…">New libvirt ticket</a></li></ul> + <ul><li><a href="http://bugzilla.redhat.com/buglist.cgi?component=libvirt&product=Virtua…">View libvirt tickets</a></li><li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Virtualization%20…">New libvirt ticket</a></li></ul> <h2>Linux Distribution specific bug reports</h2> <ul><li> If you are using official binaries from a Fedora distribution, enter tickets against the <code>Fedora</code> product and the <code>libvirt</code> component. - <ul><li><a href="">View Fedora libvirt tickets</a></li><li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Fedora&compon…">New Fedora libvirt ticket</a></li></ul></li><li> + <ul><li><a href="http://bugzilla.redhat.com/buglist.cgi?component=libvirt&product=Fedora">View Fedora libvirt tickets</a></li><li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Fedora&compon…">New Fedora libvirt ticket</a></li></ul></li><li> If you are using official binaries from Red Hat Enterprise Linux distribution, tickets against the <code>Red Hat Enterprise Linux 5</code> product and the <code>libvirt</code> component. diff --git a/docs/bugs.html.in b/docs/bugs.html.in index 0eb723a..df26c15 100644 --- a/docs/bugs.html.in +++ b/docs/bugs.html.in @@ -23,7 +23,7 @@ <ul> - <li><a href="">View libvirt tickets</a></li> + <li><a href="http://bugzilla.redhat.com/buglist.cgi?component=libvirt&product=Virtua…">View libvirt tickets</a></li> <li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Virtualization%20…">New libvirt ticket</a></li> </ul> @@ -34,7 +34,7 @@ tickets against the <code>Fedora</code> product and the <code>libvirt</code> component. <ul> - <li><a href="">View Fedora libvirt tickets</a></li> + <li><a href="http://bugzilla.redhat.com/buglist.cgi?component=libvirt&product=Fedora">View Fedora libvirt tickets</a></li> <li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Fedora&compon…">New Fedora libvirt ticket</a></li> </ul> </li> -- 1.6.3.1

1 0

[libvirt] [PATCH 0/4] Use a unix socket for the qemu monitor
by Mark McLoughlin 10 Jul '09

10 Jul '09

Hi, In order to support qemu NIC hotplug, we're planning on sending tap file descriptors across the monitor to qemu. If that sounds like magic, it is! One of the most mystical and magical unix features around. See SCM_RIGHTS in unix(7). The upshot is that we need to switch to using a unix socket for the qemu monitor. This patch series does just that, while handling the tricky scenario where you start a vm with an old version of libvirtd, update to a newer version and restart libvirtd. See also: https://fedoraproject.org/wiki/Features/KVM_NIC_Hotplug Cheers, Mark.

2 8

[libvirt] More then one pci device possible with libvirt and pci passthrough?
by Mirko Raasch 10 Jul '09

10 Jul '09

Hi, i want to use more then one pci card in my debian guest. But when i start the guest, the log says: libvirtd: 15:44:55.459: warning : pciTrySecondaryBusReset:483 : Other devices on bus with 0000:05:01.0, not doing bus reset With "/usr/bin/qemu-system-x86_64 -m 512 -name test -hda /media/vm/test.img -boot c -vnc :2 -k de -pcidevice host=05:01.0 -pcidevice host=05:02.0 -pcidevice host=05:03.0" there seems to be no problems. How can i start my guest with three pci devices passed through and libvirt? My hostdev section in the xml looks like this: <hostdev mode='subsystem' type='pci' managed='yes'> <source> <address domain='0x0000' bus='0x05' slot='0x01' function='0x0'/> </source> </hostdev> <hostdev mode='subsystem' type='pci' managed='yes'> <source> <address domain='0x0000' bus='0x05' slot='0x02' function='0x0'/> </source> </hostdev> <hostdev mode='subsystem' type='pci' managed='yes'> <source> <address domain='0x0000' bus='0x05' slot='0x03' function='0x0'/> </source> </hostdev> Greetings Mirko

3 5

[libvirt] F11 and KVM Migrations
by Scott Baker 10 Jul '09

10 Jul '09

I have two host machines on the same subnet, and I have /var/lib/libvirt/images shared between the two via NFS. I'm trying to do a "migration" from one host to another and I'm getting an error. virsh # migrate --live Narwhal qemu+ssh://10.1.1.1/system error: operation failed: failed to start listening VM That's from the host running the VM to the new host. I'm assuming you have to do a "push" migrate, not a "pull"? Where can I look next to figure out why it didn't work? -- Scott Baker - Canby Telcom System Administrator - RHCE - 503.266.8253

3 5

[libvirt] more options for virt-manager
by Gene Czarcinski 10 Jul '09

10 Jul '09

I noticed that the command line qemu and qemu-kvm offer a number of options such as using vmware display and addition sound card emulation as compared to that when using virt-manager. Are there any plans to add these as options to virt-manager? As a more general question, is there some document which describes the plans, roadmaps, etc. for Fedora Virtualization (or should I say Linux Virtualization since it does apply to other distributions as well)? I pick up tid-bits in various messages and bug reports such as libvirt supporting vmware and "pool storage" providing some improvements but I do not have an overall picture as to what is planned. While developers may do some things sooner rather than later because they are easy to do, we users may have some preferences as to what features/capabilities are more important to us than others. Gene

2 2

[libvirt] libvirt and physical hardware devices
by Arjun Roy 10 Jul '09

10 Jul '09

Greetings. I am interested in finding out what kinds of physical hardware data can be pulled out of libvirt at present. In particular, I'm interested in sourcing: 1. All the processor information that would be revealed from /proc/cpuinfo -cpu # -core # -# cores total -model -family -cpuid_lvl -speed -cache -vendor -flags 2. The following network device paramters: -interface name -mac address -current ip address -current netmask -current broadcast -current link bandwidth This post (https://www.redhat.com/archives/libvir-list/2009-June/msg00236.html) seemed promising at least wrt. network stuff, and I was wondering if it ever went anywhere. So my overall questions: 1. Is this data (specifically, all of it) tracked and exposed by libvirt at present? 2. If not, are there any plans to do so? I know it is possible to find out this data using /proc/cpuinfo and the various socket ioctls, but would like to avoid relying on those if possible. Thanks, -Arjun Roy

4 4

[libvirt] preview comments
by Gene Czarcinski 10 Jul '09

10 Jul '09

I am currently running the set of "preview" packages: ------------------- libvirt.x86_64 0.6.5-1.fc11 @rawvirt libvirt-python.x86_64 0.6.5-1.fc11 @rawvirt qemu.x86_64 2:0.10.50-8.kvm87.fc11 @rawvirt qemu-common.x86_64 2:0.10.50-8.kvm87.fc11 @rawvirt qemu-img.x86_64 2:0.10.50-8.kvm87.fc11 @rawvirt qemu-kvm.x86_64 2:0.10.50-8.kvm87.fc11 @rawvirt qemu-system-arm.x86_64 2:0.10.50-8.kvm87.fc11 @rawvirt qemu-system-cris.x86_64 2:0.10.50-8.kvm87.fc11 @rawvirt qemu-system-m68k.x86_64 2:0.10.50-8.kvm87.fc11 @rawvirt qemu-system-mips.x86_64 2:0.10.50-8.kvm87.fc11 @rawvirt qemu-system-ppc.x86_64 2:0.10.50-8.kvm87.fc11 @rawvirt qemu-system-sh4.x86_64 2:0.10.50-8.kvm87.fc11 @rawvirt qemu-system-sparc.x86_64 2:0.10.50-8.kvm87.fc11 @rawvirt qemu-system-x86.x86_64 2:0.10.50-8.kvm87.fc11 @rawvirt qemu-user.x86_64 2:0.10.50-8.kvm87.fc11 @rawvirt -------------------------------------------- So far I have been very pleased! Not only does it work but it scratches my itch on how file contexts are handled ... when a guest begins to run, the context is set and when it stops, the context is restored. I notice this is not only being done for not only for ISO image files but for logical volumes also. Very good! However (you knew this was coming), I have found an undesirable characteristic (commonly called a bug) which I will be reporting to bugzilla. The problem occurs if two or more guests are sharing a file such as an ISO image file (which should be perfectly reasonable to share). The "virt_content_t" context is set when the first guest starts running and the additional guests will use that. However, when one of these guests stops running, the context is reset which will block the file from the other guests. I suspect a simply implementation was used which uses restorecon to reset the file's context when a guest stops. Unfortunately, I believe that the "fix" is going to be a lot more difficult and complex to implement. However, if it does take some time to fix, I still prefer the new way where file contexts are restored even if there is a known problem which, for right now means that for running multiple guests using the same file it is "don't do that". Gene

1 0

[libvirt] bootstrap/autogen.sh warnings/errors
by Daniel P. Berrange 09 Jul '09

09 Jul '09

Since the gnulib change, running autogen.sh prints out tonnes of warnings and results in errors during configure. This trace from RHEL-5 completes eventually, but throws errors. On Fedora 11 it won't complete configure at all, failing most header tests with errors about 'long long long', yes that's 3 longs. RHEL5: Putting files in AC_CONFIG_AUX_DIR, `build-aux'. aclocal:configure.in:12: warning: macro `AM_SILENT_RULES' not found in library aclocal:gnulib/m4/gnulib-comp.m4:189: warning: macro `AM_XGETTEXT_OPTION' not found in library configure.in:53: warning: AC_TYPE_LONG_LONG_INT is m4_require'd but is not m4_defun'd configure.in:53: AC_TYPE_LONG_LONG_INT is required by... gnulib/m4/stdint.m4:301: gl_STDINT_H is expanded from... gnulib/m4/gnulib-comp.m4:287: gl_INIT is expanded from... configure.in:53: the top level configure.in:53: warning: AC_TYPE_UNSIGNED_LONG_LONG_INT is m4_require'd but is not m4_defun'd configure.in:53: AC_TYPE_UNSIGNED_LONG_LONG_INT is required by... gnulib/m4/vasnprintf.m4:38: gl_PREREQ_PRINTF_ARGS is expanded from... gnulib/m4/vasnprintf.m4:30: gl_REPLACE_VASNPRINTF is expanded from... gnulib/m4/vasnprintf.m4:13: gl_FUNC_VASNPRINTF is expanded from... gnulib/m4/vasnprintf.m4:52: gl_PREREQ_PRINTF_PARSE is expanded from... gnulib/m4/intmax_t.m4:61: gt_AC_TYPE_INTMAX_T is expanded from... configure.in:53: gt_AC_TYPE_INTMAX_T is required by... gnulib/m4/vasnprintf.m4:65: _gl_DEFUN_ONCE([gl_PREREQ_VASNPRINTF]) is expanded from... configure.in:53: _gl_DEFUN_ONCE([gl_PREREQ_VASNPRINTF]) is required by... gnulib/m4/vasnprintf.m4:65: gl_PREREQ_VASNPRINTF is expanded from... configure.in:53: warning: AC_TYPE_LONG_LONG_INT is m4_require'd but is not m4_defun'd configure.in:53: AC_TYPE_LONG_LONG_INT is required by... gnulib/m4/stdint.m4:301: gl_STDINT_H is expanded from... gnulib/m4/gnulib-comp.m4:287: gl_INIT is expanded from... configure.in:53: the top level configure.in:53: warning: AC_TYPE_UNSIGNED_LONG_LONG_INT is m4_require'd but is not m4_defun'd configure.in:53: AC_TYPE_UNSIGNED_LONG_LONG_INT is required by... gnulib/m4/vasnprintf.m4:38: gl_PREREQ_PRINTF_ARGS is expanded from... gnulib/m4/vasnprintf.m4:30: gl_REPLACE_VASNPRINTF is expanded from... gnulib/m4/vasnprintf.m4:13: gl_FUNC_VASNPRINTF is expanded from... gnulib/m4/vasnprintf.m4:52: gl_PREREQ_PRINTF_PARSE is expanded from... gnulib/m4/intmax_t.m4:61: gt_AC_TYPE_INTMAX_T is expanded from... configure.in:53: gt_AC_TYPE_INTMAX_T is required by... gnulib/m4/vasnprintf.m4:65: _gl_DEFUN_ONCE([gl_PREREQ_VASNPRINTF]) is expanded from... configure.in:53: _gl_DEFUN_ONCE([gl_PREREQ_VASNPRINTF]) is required by... gnulib/m4/vasnprintf.m4:65: gl_PREREQ_VASNPRINTF is expanded from... configure.in:53: warning: AC_TYPE_LONG_LONG_INT is m4_require'd but is not m4_defun'd configure.in:53: AC_TYPE_LONG_LONG_INT is required by... gnulib/m4/stdint.m4:301: gl_STDINT_H is expanded from... gnulib/m4/gnulib-comp.m4:287: gl_INIT is expanded from... configure.in:53: the top level configure.in:53: warning: AC_TYPE_UNSIGNED_LONG_LONG_INT is m4_require'd but is not m4_defun'd configure.in:53: AC_TYPE_UNSIGNED_LONG_LONG_INT is required by... gnulib/m4/vasnprintf.m4:38: gl_PREREQ_PRINTF_ARGS is expanded from... gnulib/m4/vasnprintf.m4:30: gl_REPLACE_VASNPRINTF is expanded from... gnulib/m4/vasnprintf.m4:13: gl_FUNC_VASNPRINTF is expanded from... gnulib/m4/vasnprintf.m4:52: gl_PREREQ_PRINTF_PARSE is expanded from... gnulib/m4/intmax_t.m4:61: gt_AC_TYPE_INTMAX_T is expanded from... configure.in:53: gt_AC_TYPE_INTMAX_T is required by... gnulib/m4/vasnprintf.m4:65: _gl_DEFUN_ONCE([gl_PREREQ_VASNPRINTF]) is expanded from... configure.in:53: _gl_DEFUN_ONCE([gl_PREREQ_VASNPRINTF]) is required by... gnulib/m4/vasnprintf.m4:65: gl_PREREQ_VASNPRINTF is expanded from... configure.in: installing `build-aux/install-sh' configure.in: installing `build-aux/missing' docs/examples/Makefile.am: installing `build-aux/depcomp' examples/domain-events/events-c/Makefile.am: installing `build-aux/compile' src/Makefile.am:390: variable `libvirt_driver_interface_la_LDFLAGS' is defined but no program or src/Makefile.am:390: library has `libvirt_driver_interface_la' as canonic name (possible typo) Makefile.am: installing `./INSTALL' configure.in:53: warning: AC_TYPE_LONG_LONG_INT is m4_require'd but is not m4_defun'd configure.in:53: AC_TYPE_LONG_LONG_INT is required by... gnulib/m4/stdint.m4:301: gl_STDINT_H is expanded from... gnulib/m4/gnulib-comp.m4:287: gl_INIT is expanded from... configure.in:53: the top level configure.in:53: warning: AC_TYPE_UNSIGNED_LONG_LONG_INT is m4_require'd but is not m4_defun'd configure.in:53: AC_TYPE_UNSIGNED_LONG_LONG_INT is required by... gnulib/m4/vasnprintf.m4:38: gl_PREREQ_PRINTF_ARGS is expanded from... gnulib/m4/vasnprintf.m4:30: gl_REPLACE_VASNPRINTF is expanded from... gnulib/m4/vasnprintf.m4:13: gl_FUNC_VASNPRINTF is expanded from... gnulib/m4/vasnprintf.m4:52: gl_PREREQ_PRINTF_PARSE is expanded from... gnulib/m4/intmax_t.m4:61: gt_AC_TYPE_INTMAX_T is expanded from... configure.in:53: gt_AC_TYPE_INTMAX_T is required by... gnulib/m4/vasnprintf.m4:65: _gl_DEFUN_ONCE([gl_PREREQ_VASNPRINTF]) is expanded from... configure.in:53: _gl_DEFUN_ONCE([gl_PREREQ_VASNPRINTF]) is required by... gnulib/m4/vasnprintf.m4:65: gl_PREREQ_VASNPRINTF is expanded from... configure:11495: error: possibly undefined macro: AC_TYPE_LONG_LONG_INT If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. configure:11496: error: possibly undefined macro: AC_TYPE_UNSIGNED_LONG_LONG_INT checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for gawk... gawk checking whether make sets $(MAKE)... yes checking build system type... x86_64-redhat-linux-gnu checking host system type... x86_64-redhat-linux-gnu checking for gcc... gcc checking for C compiler default output file name... a.out checking whether the C compiler works... yes checking whether we are cross compiling... no checking for suffix of executables... checking for suffix of object files... o checking whether we are using the GNU C compiler... yes checking whether gcc accepts -g... yes checking for gcc option to accept ANSI C... none needed checking for style of include used by make... GNU checking dependency style of gcc... gcc3 checking for a BSD-compatible install... /usr/bin/install -c checking how to run the C preprocessor... gcc -E checking for ranlib... ranlib checking for egrep... grep -E checking for ANSI C header files... yes checking for sys/types.h... yes checking for sys/stat.h... yes checking for stdlib.h... yes checking for string.h... yes checking for memory.h... yes checking for strings.h... yes checking for inttypes.h... yes checking for stdint.h... yes checking for unistd.h... yes checking minix/config.h usability... no checking minix/config.h presence... no checking for minix/config.h... no checking whether it is safe to define __EXTENSIONS__... yes checking for _LARGEFILE_SOURCE value needed for large files... no checking for fseeko... yes checking for working alloca.h... yes checking for alloca... yes checking arpa/inet.h usability... yes checking arpa/inet.h presence... yes checking for arpa/inet.h... yes checking sys/socket.h usability... yes checking sys/socket.h presence... yes checking for sys/socket.h... yes checking errno.h usability... yes checking errno.h presence... yes checking for errno.h... yes checking float.h usability... yes checking float.h presence... yes checking for float.h... yes checking netdb.h usability... yes checking netdb.h presence... yes checking for netdb.h... yes checking netinet/in.h usability... yes checking netinet/in.h presence... yes checking for netinet/in.h... yes checking stdio_ext.h usability... yes checking stdio_ext.h presence... yes checking for stdio_ext.h... yes checking termios.h usability... yes checking termios.h presence... yes checking for termios.h... yes checking sys/time.h usability... yes checking sys/time.h presence... yes checking for sys/time.h... yes checking sys/mman.h usability... yes checking sys/mman.h presence... yes checking for sys/mman.h... yes checking sys/ioctl.h usability... yes checking sys/ioctl.h presence... yes checking for sys/ioctl.h... yes checking sys/filio.h usability... no checking sys/filio.h presence... no checking for sys/filio.h... no checking sys/select.h usability... yes checking sys/select.h presence... yes checking for sys/select.h... yes checking for stdint.h... (cached) yes checking wchar.h usability... yes checking wchar.h presence... yes checking for wchar.h... yes checking stdio.h usability... yes checking stdio.h presence... yes checking for stdio.h... yes checking for stdlib.h... (cached) yes checking for string.h... (cached) yes checking for sys/stat.h... (cached) yes checking time.h usability... yes checking time.h presence... yes checking for time.h... yes checking for unistd.h... (cached) yes checking sys/wait.h usability... yes checking sys/wait.h presence... yes checking for sys/wait.h... yes checking whether the preprocessor supports include_next... yes checking for inline... inline checking whether <sys/socket.h> is self-contained... yes checking for shutdown... yes checking whether <sys/socket.h> defines the SHUT_* macros... yes checking for struct sockaddr_storage... yes checking for sa_family_t... yes checking for complete errno.h... yes checking whether stdin defaults to large file offsets... yes checking for library containing gethostbyname... none required checking for gethostbyname... yes checking for library containing getservbyname... none required checking for getservbyname... yes checking for C/C++ restrict keyword... __restrict checking for IPv4 sockets... yes checking for IPv6 sockets... yes checking whether getdelim is declared... yes checking whether getline is declared... yes checking whether getpass is declared... yes checking for __fsetlocking... yes checking for tcgetattr... yes checking for tcsetattr... yes checking for gettimeofday... yes checking for lstat... yes checking for mprotect... yes checking for vasnprintf... no checking whether fflush_unlocked is declared... yes checking whether flockfile is declared... yes checking whether fputs_unlocked is declared... yes checking whether funlockfile is declared... yes checking whether putc_unlocked is declared... yes checking for struct timeval... yes checking whether malloc, realloc, calloc are POSIX compliant... yes checking for mmap... yes checking for MAP_ANONYMOUS... yes checking for memchr... yes checking whether memchr works... yes checking for special C compiler options needed for large files... no checking for _FILE_OFFSET_BITS value needed for large files... no checking for _LARGE_FILES value needed for large files... no checking for external symbol _system_configuration... no checking whether <sys/select.h> is self-contained... yes checking whether snprintf is declared... yes checking for stdbool.h that conforms to C99... yes checking for _Bool... yes ./configure: line 11495: AC_TYPE_LONG_LONG_INT: command not found ./configure: line 11496: AC_TYPE_UNSIGNED_LONG_LONG_INT: command not found checking whether strdup is declared... yes checking for working strerror function... yes checking whether strndup is declared... yes checking whether strnlen is declared... yes checking whether stat file-mode macros are broken... no checking for struct timespec in <time.h>... yes ./configure: line 12443: AC_TYPE_LONG_LONG_INT: command not found checking for wchar_t... yes checking for wint_t... yes ./configure: line 12570: AC_TYPE_LONG_LONG_INT: command not found checking for size_t... yes checking for inttypes.h... yes checking for stdint.h... yes ./configure: line 12763: AC_TYPE_LONG_LONG_INT: command not found checking for intmax_t... yes ./configure: line 12847: AC_TYPE_LONG_LONG_INT: command not found checking for snprintf... yes checking for strnlen... yes checking for wcslen... yes checking for wcsnlen... yes checking for mbrtowc... yes checking for wcrtomb... yes checking whether _snprintf is declared... no checking whether ungetc works on arbitrary bytes... yes checking for alloca as a compiler built-in... yes checking for fseeko... yes configure: checking how to do getaddrinfo, freeaddrinfo and getnameinfo checking for library containing getaddrinfo... none required checking for getaddrinfo... yes checking for gai_strerror (possibly via ws2tcpip.h)... yes checking for struct sockaddr.sa_len... no checking whether getaddrinfo is declared... yes checking whether freeaddrinfo is declared... yes checking whether gai_strerror is declared... yes checking whether getnameinfo is declared... yes checking for struct addrinfo... yes checking for getdelim... yes checking for gethostname... yes checking for getline... yes checking for working getline function... yes checking for getpagesize... yes checking for getpass... yes checking for gettimeofday with POSIX signature... yes checking whether gettimeofday clobbers localtime buffer... no checking for library containing gethostbyname... (cached) none required checking for gethostbyname... (cached) yes checking for library containing inet_ntop... none required checking whether inet_ntop is declared... yes checking for inet_pton... yes checking whether inet_pton is declared... yes checking whether lseek detects pipes... yes checking whether lstat dereferences a symlink specified with a trailing slash... yes checking for working mkstemp... yes checking whether <netinet/in.h> is self-contained... yes checking for sys/pstat.h... no checking for sys/sysmp.h... no checking for sys/sysinfo.h... yes checking for machine/hal_sysinfo.h... no checking for sys/table.h... no checking for sys/param.h... yes checking for sys/sysctl.h... yes checking for sys/systemcfg.h... no checking for pstat_getstatic... no checking for pstat_getdynamic... no checking for sysmp... no checking for getsysinfo... no checking for sysctl... yes checking for table... no checking poll.h usability... yes checking poll.h presence... yes checking for poll.h... yes checking for poll... yes checking for a shell that conforms to POSIX... /bin/sh checking for random_r... yes checking whether select supports a 0 argument... yes checking for library containing getservbyname... (cached) none required checking for getservbyname... (cached) yes checking for stdint.h... (cached) yes checking for SIZE_MAX... yes checking for snprintf... (cached) yes checking whether snprintf respects a size of 1... yes checking for socklen_t... yes ./configure: line 21828: test: =: unary operator expected ./configure: line 21835: test: =: unary operator expected checking whether stdint.h conforms to C99... yes checking for random.h... no checking for struct random_data... yes checking for stpcpy... yes F11 libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, `build-aux'. libtoolize: copying file `build-aux/ltmain.sh' libtoolize: putting macros in `gnulib/m4'. libtoolize: copying file `gnulib/m4/libtool.m4' libtoolize: copying file `gnulib/m4/ltoptions.m4' libtoolize: copying file `gnulib/m4/ltsugar.m4' libtoolize: copying file `gnulib/m4/ltversion.m4' libtoolize: copying file `gnulib/m4/lt~obsolete.m4' libtoolize: Consider adding `AC_CONFIG_MACRO_DIR([m4])' to configure.in and libtoolize: rerunning libtoolize, to keep the correct libtool macros in-tree. gnulib/m4/gnulib-comp.m4:189: warning: macro `AM_XGETTEXT_OPTION' not found in library configure.in:53: warning: gl_AC_HEADER_INTTYPES_H is m4_require'd but not m4_defun'd gnulib/m4/intmax_t.m4:35: gt_AC_TYPE_INTMAX_T is expanded from... gnulib/m4/vasnprintf.m4:41: gl_PREREQ_PRINTF_PARSE is expanded from... gnulib/m4/vasnprintf.m4:15: gl_REPLACE_VASNPRINTF is expanded from... gnulib/m4/vasnprintf.m4:7: gl_FUNC_VASNPRINTF is expanded from... gnulib/m4/gnulib-comp.m4:34: gl_INIT is expanded from... configure.in:53: the top level configure.in:53: warning: gl_AC_HEADER_STDINT_H is m4_require'd but not m4_defun'd configure.in:53: warning: gl_AC_HEADER_INTTYPES_H is m4_require'd but not m4_defun'd gnulib/m4/intmax_t.m4:35: gt_AC_TYPE_INTMAX_T is expanded from... gnulib/m4/vasnprintf.m4:41: gl_PREREQ_PRINTF_PARSE is expanded from... gnulib/m4/vasnprintf.m4:15: gl_REPLACE_VASNPRINTF is expanded from... gnulib/m4/vasnprintf.m4:7: gl_FUNC_VASNPRINTF is expanded from... gnulib/m4/gnulib-comp.m4:34: gl_INIT is expanded from... configure.in:53: the top level configure.in:53: warning: gl_AC_HEADER_STDINT_H is m4_require'd but not m4_defun'd configure.in:53: warning: gl_AC_HEADER_INTTYPES_H is m4_require'd but not m4_defun'd gnulib/m4/intmax_t.m4:35: gt_AC_TYPE_INTMAX_T is expanded from... gnulib/m4/vasnprintf.m4:41: gl_PREREQ_PRINTF_PARSE is expanded from... gnulib/m4/vasnprintf.m4:15: gl_REPLACE_VASNPRINTF is expanded from... gnulib/m4/vasnprintf.m4:7: gl_FUNC_VASNPRINTF is expanded from... gnulib/m4/gnulib-comp.m4:34: gl_INIT is expanded from... configure.in:53: the top level configure.in:53: warning: gl_AC_HEADER_STDINT_H is m4_require'd but not m4_defun'd configure.in:66: installing `build-aux/compile' configure.in:14: installing `build-aux/config.guess' configure.in:14: installing `build-aux/config.sub' configure.in:8: installing `build-aux/install-sh' configure.in:8: installing `build-aux/missing' docs/examples/Makefile.am: installing `build-aux/depcomp' src/Makefile.am:390: variable `libvirt_driver_interface_la_LDFLAGS' is defined but no program or src/Makefile.am:390: library has `libvirt_driver_interface_la' as canonical name (possible typo) Makefile.am: installing `./INSTALL' configure.in:53: warning: gl_AC_HEADER_INTTYPES_H is m4_require'd but not m4_defun'd gnulib/m4/intmax_t.m4:35: gt_AC_TYPE_INTMAX_T is expanded from... gnulib/m4/vasnprintf.m4:41: gl_PREREQ_PRINTF_PARSE is expanded from... gnulib/m4/vasnprintf.m4:15: gl_REPLACE_VASNPRINTF is expanded from... gnulib/m4/vasnprintf.m4:7: gl_FUNC_VASNPRINTF is expanded from... gnulib/m4/gnulib-comp.m4:34: gl_INIT is expanded from... configure.in:53: the top level configure.in:53: warning: gl_AC_HEADER_STDINT_H is m4_require'd but not m4_defun'd configure:14195: error: possibly undefined macro: gl_AC_HEADER_INTTYPES_H If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. configure:14196: error: possibly undefined macro: gl_AC_HEADER_STDINT_H checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for a thread-safe mkdir -p... /bin/mkdir -p checking for gawk... gawk checking whether make sets $(MAKE)... yes checking build system type... i686-pc-linux-gnu checking host system type... i686-pc-linux-gnu checking for gcc... gcc checking for C compiler default output file name... a.out checking whether the C compiler works... yes checking whether we are cross compiling... no checking for suffix of executables... checking for suffix of object files... o checking whether we are using the GNU C compiler... yes checking whether gcc accepts -g... yes checking for gcc option to accept ISO C89... none needed checking for style of include used by make... GNU checking dependency style of gcc... gcc3 checking for a BSD-compatible install... /usr/bin/install -c checking how to run the C preprocessor... gcc -E checking for ranlib... ranlib checking for grep that handles long lines and -e... /bin/grep checking for egrep... /bin/grep -E checking for ANSI C header files... yes checking for sys/types.h... yes checking for sys/stat.h... yes checking for stdlib.h... yes checking for string.h... yes checking for memory.h... yes checking for strings.h... yes checking for inttypes.h... yes checking for stdint.h... yes checking for unistd.h... yes checking minix/config.h usability... no checking minix/config.h presence... no checking for minix/config.h... no checking whether it is safe to define __EXTENSIONS__... yes checking for _LARGEFILE_SOURCE value needed for large files... no checking for working alloca.h... yes checking for alloca... yes checking arpa/inet.h usability... yes checking arpa/inet.h presence... yes checking for arpa/inet.h... yes checking sys/socket.h usability... yes checking sys/socket.h presence... yes checking for sys/socket.h... yes checking errno.h usability... yes checking errno.h presence... yes checking for errno.h... yes checking float.h usability... yes checking float.h presence... yes checking for float.h... yes checking netdb.h usability... yes checking netdb.h presence... yes checking for netdb.h... yes checking netinet/in.h usability... yes checking netinet/in.h presence... yes checking for netinet/in.h... yes checking stdio_ext.h usability... yes checking stdio_ext.h presence... yes checking for stdio_ext.h... yes checking termios.h usability... yes checking termios.h presence... yes checking for termios.h... yes checking sys/time.h usability... yes checking sys/time.h presence... yes checking for sys/time.h... yes checking sys/mman.h usability... yes checking sys/mman.h presence... yes checking for sys/mman.h... yes checking sys/ioctl.h usability... yes checking sys/ioctl.h presence... yes checking for sys/ioctl.h... yes checking sys/filio.h usability... no checking sys/filio.h presence... no checking for sys/filio.h... no checking sys/select.h usability... yes checking sys/select.h presence... yes checking for sys/select.h... yes checking for stdint.h... (cached) yes checking wchar.h usability... yes checking wchar.h presence... yes checking for wchar.h... yes checking stdio.h usability... yes checking stdio.h presence... yes checking for stdio.h... yes checking for stdlib.h... (cached) yes checking for string.h... (cached) yes checking for sys/stat.h... (cached) yes checking time.h usability... yes checking time.h presence... yes checking for time.h... yes checking for unistd.h... (cached) yes checking sys/wait.h usability... yes checking sys/wait.h presence... yes checking for sys/wait.h... yes checking whether the preprocessor supports include_next... yes checking for inline... inline checking whether <sys/socket.h> is self-contained... yes checking for shutdown... yes checking whether <sys/socket.h> defines the SHUT_* macros... yes checking for struct sockaddr_storage... yes checking for sa_family_t... yes checking for complete errno.h... yes checking whether stdin defaults to large file offsets... yes checking for library containing gethostbyname... none required checking for gethostbyname... yes checking for library containing getservbyname... none required checking for getservbyname... yes checking for C/C++ restrict keyword... __restrict checking for IPv4 sockets... yes checking for IPv6 sockets... yes checking whether getdelim is declared... yes checking whether getline is declared... yes checking whether getpass is declared... yes checking for __fsetlocking... yes checking for tcgetattr... yes checking for tcsetattr... yes checking for gettimeofday... yes checking for lstat... yes checking for mprotect... yes checking for vasnprintf... no checking whether fflush_unlocked is declared... yes checking whether flockfile is declared... yes checking whether fputs_unlocked is declared... yes checking whether funlockfile is declared... yes checking whether putc_unlocked is declared... yes checking for struct timeval... yes checking whether malloc, realloc, calloc are POSIX compliant... yes checking for mmap... yes checking for MAP_ANONYMOUS... yes checking for memchr... yes checking whether memchr works... yes checking for special C compiler options needed for large files... no checking for _FILE_OFFSET_BITS value needed for large files... 64 checking for external symbol _system_configuration... no checking whether <sys/select.h> is self-contained... yes checking whether snprintf is declared... yes checking for stdbool.h that conforms to C99... yes checking for _Bool... yes checking for long long int... yes checking for unsigned long long int... yes checking whether strdup is declared... yes checking for working strerror function... yes checking whether strndup is declared... yes checking whether strnlen is declared... yes checking whether stat file-mode macros are broken... no checking for struct timespec in <time.h>... yes checking for wchar_t... yes checking for wint_t... yes checking for size_t... yes ./configure: line 14195: gl_AC_HEADER_INTTYPES_H: command not found ./configure: line 14196: gl_AC_HEADER_STDINT_H: command not found checking for intmax_t... no checking for snprintf... yes checking for strnlen... yes checking for wcslen... yes checking for wcsnlen... yes checking for mbrtowc... yes checking for wcrtomb... yes checking whether _snprintf is declared... no checking whether ungetc works on arbitrary bytes... yes checking for alloca as a compiler built-in... yes checking for a thread-safe mkdir -p... /bin/mkdir -p checking for fseeko... yes configure: checking how to do getaddrinfo, freeaddrinfo and getnameinfo checking for library containing getaddrinfo... none required checking for getaddrinfo... no checking for getaddrinfo in ws2tcpip.h and -lws2_32... no checking for gai_strerror (possibly via ws2tcpip.h)... no checking for struct sockaddr.sa_len... no checking whether getaddrinfo is declared... no checking whether freeaddrinfo is declared... no checking whether gai_strerror is declared... no checking whether getnameinfo is declared... no checking for struct addrinfo... no checking for getdelim... yes checking for gethostname... yes checking for getline... yes checking for working getline function... yes checking for getpagesize... yes checking for getpass... yes checking for gettimeofday with POSIX signature... yes checking whether gettimeofday clobbers localtime buffer... no checking for library containing gethostbyname... (cached) none required checking for gethostbyname... (cached) yes checking for library containing inet_ntop... none required checking whether inet_ntop is declared... no checking for inet_pton... yes checking whether inet_pton is declared... no checking whether lseek detects pipes... yes checking whether lstat dereferences a symlink specified with a trailing slash... no checking for working mkstemp... no checking whether <netinet/in.h> is self-contained... no checking for netinet/in.h... (cached) yes checking for a thread-safe mkdir -p... /bin/mkdir -p checking for sys/pstat.h... no checking for sys/sysmp.h... no checking for sys/sysinfo.h... no checking for machine/hal_sysinfo.h... no checking for sys/table.h... no checking for sys/param.h... no checking for sys/sysctl.h... no checking for sys/systemcfg.h... no checking for pstat_getstatic... no checking for pstat_getdynamic... no checking for sysmp... no checking for getsysinfo... no checking for sysctl... yes checking for table... no checking poll.h usability... no checking poll.h presence... yes configure: WARNING: poll.h: present but cannot be compiled configure: WARNING: poll.h: check for missing prerequisite headers? configure: WARNING: poll.h: see the Autoconf documentation configure: WARNING: poll.h: section "Present But Cannot Be Compiled" configure: WARNING: poll.h: proceeding with the preprocessor's result configure: WARNING: poll.h: in the future, the compiler will take precedence checking for poll.h... yes checking for poll... yes checking for a shell that conforms to POSIX... /bin/sh checking for random_r... yes checking whether select supports a 0 argument... yes checking for library containing getservbyname... (cached) none required checking for getservbyname... (cached) yes checking for stdint.h... (cached) yes checking for SIZE_MAX... yes checking for snprintf... (cached) yes checking whether snprintf respects a size of 1... yes checking for socklen_t... yes checking whether stdint.h conforms to C99... no checking sys/inttypes.h usability... no checking sys/inttypes.h presence... no checking for sys/inttypes.h... no checking sys/bitypes.h usability... no checking sys/bitypes.h presence... yes configure: WARNING: sys/bitypes.h: present but cannot be compiled configure: WARNING: sys/bitypes.h: check for missing prerequisite headers? configure: WARNING: sys/bitypes.h: see the Autoconf documentation configure: WARNING: sys/bitypes.h: section "Present But Cannot Be Compiled" configure: WARNING: sys/bitypes.h: proceeding with the preprocessor's result configure: WARNING: sys/bitypes.h: in the future, the compiler will take precedence checking for sys/bitypes.h... yes checking for bit size of ptrdiff_t... 32 checking for bit size of size_t... 32 checking for bit size of sig_atomic_t... 32 checking for bit size of wchar_t... 32 checking for bit size of wint_t... 32 checking whether sig_atomic_t is signed... yes checking whether wchar_t is signed... yes checking whether wint_t is signed... no checking for ptrdiff_t integer literal suffix... checking for size_t integer literal suffix... u checking for sig_atomic_t integer literal suffix... checking for wchar_t integer literal suffix... l checking for wint_t integer literal suffix... u checking for random.h... no checking for struct random_data... yes checking for stpcpy... yes checking for strdup... yes checking for working strndup... yes checking for working strnlen... no checking for strsep... yes checking whether <sys/ioctl.h> declares ioctl... yes checking for a thread-safe mkdir -p... /bin/mkdir -p checking whether <sys/select.h> is self-contained... (cached) yes checking for a thread-safe mkdir -p... /bin/mkdir -p checking whether <sys/socket.h> is self-contained... (cached) yes checking for shutdown... (cached) yes checking whether <sys/socket.h> defines the SHUT_* macros... (cached) yes checking for struct sockaddr_storage... (cached) yes checking for sa_family_t... (cached) yes checking for a thread-safe mkdir -p... /bin/mkdir -p checking for nlink_t... yes checking for a thread-safe mkdir -p... /bin/mkdir -p checking for a thread-safe mkdir -p... /bin/mkdir -p checking whether localtime_r is compatible with its POSIX signature... yes checking for ptrdiff_t... no checking for vasprintf... yes checking whether <wchar.h> is standalone... yes checking for stdint.h... (cached) yes checking for library containing setsockopt... none needed checking for wchar_t... (cached) yes checking for wint_t... (cached) yes checking for shutdown... (cached) yes checking for gcc... (cached) gcc checking whether we are using the GNU C compiler... (cached) yes checking whether gcc accepts -g... (cached) yes checking for gcc option to accept ISO C89... (cached) none needed checking dependency style of gcc... (cached) gcc3 checking for an ANSI C-conforming const... yes checking for function prototypes... yes checking for string.h... (cached) yes checking for a sed that does not truncate output... /bin/sed checking for fgrep... /bin/grep -F checking for ld used by gcc... /usr/bin/ld checking if the linker (/usr/bin/ld) is GNU ld... yes checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B checking the name lister (/usr/bin/nm -B) interface... BSD nm checking whether ln -s works... yes checking the maximum length of command line arguments... 1966080 checking whether the shell understands some XSI constructs... yes checking whether the shell understands "+="... yes checking for /usr/bin/ld option to reload object files... -r checking for objdump... objdump checking how to recognize dependent libraries... pass_all checking for ar... ar checking for strip... strip checking for ranlib... (cached) ranlib checking command to parse /usr/bin/nm -B output from gcc object... ok checking for dlfcn.h... no checking for objdir... .libs checking if gcc supports -fno-rtti -fno-exceptions... no checking for gcc option to produce PIC... -fPIC -DPIC checking if gcc PIC flag -fPIC -DPIC works... yes checking if gcc static flag -static works... no checking if gcc supports -c -o file.o... yes checking if gcc supports -c -o file.o... (cached) yes checking whether the gcc linker (/usr/bin/ld) supports shared libraries... yes checking whether -lc should be explicitly linked in... no checking dynamic linker characteristics... GNU/Linux ld.so checking how to hardcode library paths into programs... immediate checking whether stripping libraries is possible... yes checking if libtool supports shared libraries... yes checking whether to build shared libraries... yes checking whether to build static libraries... yes checking whether gcc and cc understand -c and -o together... yes checking whether compiler accepts -Wall... yes checking whether compiler accepts -Wformat... yes checking whether compiler accepts -Wformat-security... yes checking whether compiler accepts -Wmissing-prototypes... yes checking whether compiler accepts -Wnested-externs... yes checking whether compiler accepts -Wpointer-arith... yes checking whether compiler accepts -Wextra... yes checking whether compiler accepts -Wshadow... yes checking whether compiler accepts -Wcast-align... yes checking whether compiler accepts -Wwrite-strings... yes checking whether compiler accepts -Waggregate-return... yes checking whether compiler accepts -Wstrict-prototypes... yes checking whether compiler accepts -Winline... yes checking whether compiler accepts -Wredundant-decls... yes checking whether compiler accepts -Wno-sign-compare... yes checking whether compiler accepts -Wp,-D_FORTIFY_SOURCE=2... yes checking whether compiler accepts -fexceptions... yes checking whether compiler accepts -fasynchronous-unwind-tables... yes checking whether compiler accepts -Werror... yes checking what language compliance flags to pass to the C compiler... checking whether compiler accepts -Wno-redundant-decls... yes checking for special C compiler options needed for large files... (cached) no checking for _FILE_OFFSET_BITS value needed for large files... (cached) 64 checking for cfmakeraw... yes checking for regexec... yes checking for uname... yes checking for sched_getaffinity... yes checking for getuid... yes checking for getgid... yes checking for posix_fallocate... yes checking for mmap... (cached) yes checking for readlink... yes checking for strerror_r... yes checking for strtok_r... yes checking for getmntent_r... yes checking for getgrnam_r... yes checking for getpwuid_r... yes checking pwd.h usability... no checking pwd.h presence... yes configure: WARNING: pwd.h: present but cannot be compiled configure: WARNING: pwd.h: check for missing prerequisite headers? configure: WARNING: pwd.h: see the Autoconf documentation configure: WARNING: pwd.h: section "Present But Cannot Be Compiled" configure: WARNING: pwd.h: proceeding with the preprocessor's result configure: WARNING: pwd.h: in the future, the compiler will take precedence checking for pwd.h... yes checking paths.h usability... no checking paths.h presence... yes configure: WARNING: paths.h: present but cannot be compiled configure: WARNING: paths.h: check for missing prerequisite headers? configure: WARNING: paths.h: see the Autoconf documentation configure: WARNING: paths.h: section "Present But Cannot Be Compiled" configure: WARNING: paths.h: proceeding with the preprocessor's result configure: WARNING: paths.h: in the future, the compiler will take precedence checking for paths.h... yes checking regex.h usability... no checking regex.h presence... yes configure: WARNING: regex.h: present but cannot be compiled configure: WARNING: regex.h: check for missing prerequisite headers? configure: WARNING: regex.h: see the Autoconf documentation configure: WARNING: regex.h: section "Present But Cannot Be Compiled" configure: WARNING: regex.h: proceeding with the preprocessor's result configure: WARNING: regex.h: in the future, the compiler will take precedence checking for regex.h... yes checking sys/syslimits.h usability... no checking sys/syslimits.h presence... no checking for sys/syslimits.h... no checking sys/utsname.h usability... no checking sys/utsname.h presence... yes configure: WARNING: sys/utsname.h: present but cannot be compiled configure: WARNING: sys/utsname.h: check for missing prerequisite headers? configure: WARNING: sys/utsname.h: see the Autoconf documentation configure: WARNING: sys/utsname.h: section "Present But Cannot Be Compiled" configure: WARNING: sys/utsname.h: proceeding with the preprocessor's result configure: WARNING: sys/utsname.h: in the future, the compiler will take precedence checking for sys/utsname.h... yes checking for sys/wait.h... (cached) yes checking winsock2.h usability... no checking winsock2.h presence... no checking for winsock2.h... no checking sched.h usability... no checking sched.h presence... yes configure: WARNING: sched.h: present but cannot be compiled configure: WARNING: sched.h: check for missing prerequisite headers? configure: WARNING: sched.h: see the Autoconf documentation configure: WARNING: sched.h: section "Present But Cannot Be Compiled" configure: WARNING: sched.h: proceeding with the preprocessor's result configure: WARNING: sched.h: in the future, the compiler will take precedence checking for sched.h... yes checking for termios.h... (cached) yes checking sys/poll.h usability... no checking sys/poll.h presence... yes configure: WARNING: sys/poll.h: present but cannot be compiled configure: WARNING: sys/poll.h: check for missing prerequisite headers? configure: WARNING: sys/poll.h: see the Autoconf documentation configure: WARNING: sys/poll.h: section "Present But Cannot Be Compiled" configure: WARNING: sys/poll.h: proceeding with the preprocessor's result configure: WARNING: sys/poll.h: in the future, the compiler will take precedence checking for sys/poll.h... yes checking syslog.h usability... no checking syslog.h presence... yes configure: WARNING: syslog.h: present but cannot be compiled configure: WARNING: syslog.h: check for missing prerequisite headers? configure: WARNING: syslog.h: see the Autoconf documentation configure: WARNING: syslog.h: section "Present But Cannot Be Compiled" configure: WARNING: syslog.h: proceeding with the preprocessor's result configure: WARNING: syslog.h: in the future, the compiler will take precedence checking for syslog.h... yes checking for xdrmem_create in -lportablexdr... no checking for library containing xdrmem_create... none required checking for gettext in -lintl... no checking for rpcgen... /usr/bin/rpcgen checking pthread.h usability... no checking pthread.h presence... yes configure: WARNING: pthread.h: present but cannot be compiled configure: WARNING: pthread.h: check for missing prerequisite headers? configure: WARNING: pthread.h: see the Autoconf documentation configure: WARNING: pthread.h: section "Present But Cannot Be Compiled" configure: WARNING: pthread.h: proceeding with the preprocessor's result configure: WARNING: pthread.h: in the future, the compiler will take precedence checking for pthread.h... yes checking for pthread_join in -lpthread... yes checking for rm... /bin/rm checking for mv... /bin/mv checking for tar... /bin/tar checking for xmllint... /usr/bin/xmllint checking for xmlcatalog... /usr/bin/xmlcatalog checking for xsltproc... /usr/bin/xsltproc checking for augparse... /usr/bin/augparse checking for a thread-safe mkdir -p... /bin/mkdir -p checking for dnsmasq... /usr/sbin/dnsmasq checking for brctl... /usr/sbin/brctl checking for udevadm... /sbin/udevadm checking for udevsettle... /sbin/udevsettle checking for modprobe... /sbin/modprobe checking where to write libvirtd PID file... /var/run/libvirtd.pid checking for init script flavor... redhat checking for lokkit... /usr/sbin/lokkit checking for iptables... /sbin/iptables checking for xs_read in -lxenstore... yes checking for xen/xen.h... no configure: error: Cannot find standard Xen headers. Is xen-devel installed? Config.log says configure:40254: checking for xen/xen.h configure:40277: gcc -c -g -O2 conftest.c >&5 In file included from conftest.c:192: /usr/include/stdint.h:139: error: 'long long long' is too long for GCC /usr/include/stdint.h:139: error: 'long long long' is too long for GCC Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

1 1

[libvirt] [PATCH] doc: clone+build instructions
by Jim Meyering 09 Jul '09

09 Jul '09

I realized it'd be nice to include instructions on how to build from a just-cloned repository, so copied most of this new file, README-hacking, from coreutils: >From 7ffc5ce3ebb0769c0edc9f6fa9dc25e315ffdcf3 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Wed, 8 Jul 2009 21:37:59 +0200 Subject: [PATCH] doc: clone+build instructions * README-hacking: New file. * bootstrap: Remove obsolete comments. --- README-hacking | 74 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ bootstrap | 8 +----- 2 files changed, 75 insertions(+), 7 deletions(-) create mode 100644 README-hacking diff --git a/README-hacking b/README-hacking new file mode 100644 index 0000000..3463da2 --- /dev/null +++ b/README-hacking @@ -0,0 +1,74 @@ +-*- outline -*- + +These notes intend to help people working on the checked-out sources. +These requirements do not apply when building from a distribution tarball. +See also HACKING for more detailed libvirt contribution guidelines. + +* Requirements + +We've opted to keep only the highest-level sources in the GIT repository. +This eases our maintenance burden, (fewer merges etc.), but imposes more +requirements on anyone wishing to build from the just-checked-out sources. +Note the requirements to build the released archive are much less and +are just the requirements of the standard ./configure && make procedure. +Specific development tools and versions will be checked for and listed by +the bootstrap script. See README-prereq for specific notes on obtaining +these prerequisite tools. + +Valgrind <http://valgrind.org/> is also highly recommended, if +Valgrind supports your architecture. See also README-valgrind. + +While building from a just-cloned source tree may require installing a +few prerequisites, later, a plain `git pull && make' should be sufficient. + +* First GIT checkout + +You can get a copy of the source repository like this: + + $ git clone git://libvirt.org/libvirt + $ cd libvirt + +The next step is to get and check other files needed to build, +which are extracted from other source packages: + + $ ./bootstrap + +Then run this to create e.g., Makefiles and ./configure, +and to invoke ./configure: + + $ ./autogen.sh + +And there you are! Just + + $ make + $ make check + +At this point, there should be no difference between your local copy, +and the GIT master copy: + + $ git diff + +should output no difference. + +Enjoy! + +----- + +Copyright (C) 2002-2009 Free Software Foundation, Inc. + +This program is free software: you can redistribute it and/or modify +it under the terms of the GNU General Public License as published by +the Free Software Foundation, either version 3 of the License, or +(at your option) any later version. + +This program is distributed in the hope that it will be useful, +but WITHOUT ANY WARRANTY; without even the implied warranty of +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +GNU General Public License for more details. + +You should have received a copy of the GNU General Public License +along with this program. If not, see <http://www.gnu.org/licenses/>. + +Local Variables: +indent-tabs-mode: nil +End: diff --git a/bootstrap b/bootstrap index 0754d02..8b81e0e 100755 --- a/bootstrap +++ b/bootstrap @@ -1,11 +1,5 @@ #!/bin/sh -# Run this after autogen.sh, to pull in all of the gnulib-related bits. -# It's important to run *after* autogen.sh, since it updates some of -# the same files autogen.sh does, yet those from gnulib are newer, -# and match the tests. So if a gnulib bug has been fixed since the -# snapshot taken for whatever gettext release you're using, yet you -# run "make check" against the wrong version, the corresponding unit -# test in gl-tests/ may well fail. +# Run this before autogen.sh, to pull in all of the gnulib-related bits. usage() { echo >&2 "\ -- 1.6.3.3.524.g8586b

2 6

[libvirt] the role of libvirtd
by Hugh O. Brock 09 Jul '09

09 Jul '09

Hello all. I spent quite a while yesterday in a meeting with a client interested in using libvirt for a large project. They are quite happy in general with the direction things are going. However they have objections to a couple of libvirt design points that have come up in multiple cases in the past, including in developing the other project I'm involved in, oVirt. Specifically, they would really prefer that libvirtd be a one-stop shop for everything they need to do on a virtualization host, including things we have traditionally held out-of-scope for libvirt. A partial list of those things would include: * In-depth multipath config management * Hardware lifecycle management (power-off, reboot, etc.) * HA configuration ... and pretty much anything else you might want to do on a piece of hardware that is hosting virtual machines. My initial reaction of course was to tell them "Well you should just use a separate agent for that sort of thing." But of course this means making a separate connection to the node depending on what operation you want to perform, which is cumbersome. So I guess what I'm asking is, why *not* expand the scope of libvirtd to be a one-stop shop for managing a node? Is there a really good reason it shouldn't have the remaining capabilities libvirt users want? Is that reason good enough to balance the headache our users have to deal with in coming up with a separate package to handle the tasks libvirtd does not? Slings, arrows, or thunderous applause welcome... Take care, --Hugh

4 5

[libvirt] [PATCH] use gnulib via a submodule
by Jim Meyering 09 Jul '09

09 Jul '09

Please NOTE: do not apply the changes below. They are incomplete because I've removed all the boring, repetitive parts. If you want to apply something, use this: http://meyering.net/code/tmp/libvirt-submodule.patch.bz2 For an overall summary of the process of hooking up gnulib as a submodule, see the long commit log for 5/7, below: Subject: [PATCH 5/7] make .gnulib a submodule I'm not sure all of 1/7 is welcome, but at least the silent-rules part seems in line with what people here like, considering that mylibtool does something similar. With this, you might be comfortable removing mylibtool. Jim >From 41e0b6942648065dcf00e9aee3f961297464a336 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Mon, 6 Jul 2009 19:06:00 +0200 Subject: [PATCH 1/7] configure.in: use automake-1.11 --- configure.in | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/configure.in b/configure.in index 29c8867..1170958 100644 --- a/configure.in +++ b/configure.in @@ -5,7 +5,8 @@ AC_CONFIG_SRCDIR([src/libvirt.c]) AC_CONFIG_AUX_DIR([build-aux]) AM_CONFIG_HEADER([config.h]) dnl Make automake keep quiet about wildcards & other GNUmake-isms -AM_INIT_AUTOMAKE([-Wno-portability]) +AM_INIT_AUTOMAKE([1.11 color-tests parallel-tests -Wno-portability]) +AM_SILENT_RULES([yes]) # make --enable-silent-rules the default. AC_CANONICAL_HOST LIBVIRT_MAJOR_VERSION=`echo $VERSION | awk -F. '{print $1}'` -- 1.6.3.3.524.g8586b >From d73c9fc35bdcac3c1f8b24cad226fc879325d3c2 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Mon, 6 Jul 2009 18:23:44 +0200 Subject: [PATCH 2/7] * Makefile.cfg: Rename to... * cfg.mk: ...this. New file. --- Makefile.cfg => cfg.mk | 0 1 files changed, 0 insertions(+), 0 deletions(-) rename Makefile.cfg => cfg.mk (100%) diff --git a/Makefile.cfg b/cfg.mk similarity index 100% rename from Makefile.cfg rename to cfg.mk -- 1.6.3.3.524.g8586b >From 1cacbc7f4c883f763606e0bed36bd8d149add0d9 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Mon, 6 Jul 2009 18:28:10 +0200 Subject: [PATCH 3/7] Prepare to use maint.mk from gnulib Since Makefile.maint will soon come from gnulib's maint.mk, sync Makefile.maint to have the same contents (modulo minor things). In syncing it, we have to remove some libvirt-specific rules. Since we want to keep them (of course), put those in cfg.mk. * Makefile.maint: Merge from gnulib's maint.mk. * cfg.mk (sc_avoid_write): New rule. From Makefile.cfg. (sc_prohibit_strcmp_and_strncmp): Likewise, and rename. (sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise. (sc_prohibit_nonreentrant): Likewise. (sc_prohibit_ctype_h): Likewise. (sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise. (sc_prohibit_virBufferAdd_with_string_literal): Likewise. (sc_prohibit_gethostby): Likewise. (sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the rule, inserting "_libvirt", since this rule is a specialization of the one in gnulib. * GNUmakefile: Include cfg.mk, not Makefile.cfg * .x-sc_prohibit_strcmp_and_strncmp: New file. * Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp . --- .x-sc_prohibit_strcmp_and_strncmp | 1 + GNUmakefile | 4 +- Makefile.am | 1 + Makefile.maint | 734 +++++++++++++++++-------------------- cfg.mk | 163 ++++++++ 5 files changed, 505 insertions(+), 398 deletions(-) create mode 100644 .x-sc_prohibit_strcmp_and_strncmp diff --git a/.x-sc_prohibit_strcmp_and_strncmp b/.x-sc_prohibit_strcmp_and_strncmp new file mode 100644 index 0000000..b7c456e --- /dev/null +++ b/.x-sc_prohibit_strcmp_and_strncmp @@ -0,0 +1 @@ +^gnulib/ diff --git a/GNUmakefile b/GNUmakefile index 157f432..e6d4178 100644 --- a/GNUmakefile +++ b/GNUmakefile @@ -40,7 +40,7 @@ export TAR_OPTIONS = --owner=0 --group=0 --numeric-owner include Makefile -include $(srcdir)/Makefile.cfg +include $(srcdir)/cfg.mk include $(srcdir)/Makefile.maint else diff --git a/Makefile.am b/Makefile.am index 681034a..dd98ff2 100644 --- a/Makefile.am +++ b/Makefile.am @@ -16,6 +16,7 @@ EXTRA_DIST = \ .x-sc_avoid_if_before_free \ .x-sc_require_config_h_first \ .x-sc_prohibit_strcmp \ + .x-sc_prohibit_strcmp_and_strncmp \ .x-sc_require_config_h \ .x-sc_prohibit_nonreentrant \ Makefile.nonreentrant \ ... -- 1.6.3.3.524.g8586b >From a4b10833246264377c9c0c99a0178c3e9b6af0f7 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Mon, 6 Jul 2009 19:17:06 +0200 Subject: [PATCH 4/7] skip some of gnulib's new rules * cfg.mk (local-checks-to-skip): Add these: sc_error_message_uppercase, sc_program_name, sc_require_test_exit_idiom, sc_makefile_check. --- cfg.mk | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/cfg.mk b/cfg.mk index 3c9feb6..35bedd1 100644 --- a/cfg.mk +++ b/cfg.mk @@ -52,6 +52,10 @@ local-checks-to-skip = \ sc_system_h_headers \ sc_tight_scope \ sc_two_space_separator_in_usage \ + sc_error_message_uppercase \ + sc_program_name \ + sc_require_test_exit_idiom \ + sc_makefile_check \ sc_useless_cpp_parens useless_free_options = \ -- 1.6.3.3.524.g8586b >From 856172836da7f639323702aff67489e9a74d47d5 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Tue, 7 Jul 2009 11:22:52 +0200 Subject: [PATCH 5/7] make .gnulib a submodule This makes it so we record (via a git submodule) a snapshot of whatever version of gnulib we're using, and none of gnulib sources are in the libvirt repository. The result is that we have as much reproducibility as when we version-controlled imported copies of the gnulib sources, but without the hassle of the manual process we used when syncing with upstream. Note that when you clone libvirt, you get only the libvirt repository, but when you first run ./bootstrap, it clones gnulib (at the SHA1 recorded via the submodule), creating the .gnulib/ hierarchy. Then, the bootstrap script runs gnulib-tool to populate gnulib/ with the files that make up the selected modules. Put the following in your ~/.gitconfig file. [alias] syncsub = submodule foreach git pull origin master The update procedure is simple: git syncsub ...build & test... git commit -m 'gnulib: sync submodule to latest' .gnulib * .gitmodules: New file. * .gnulib: Initialize. * bootstrap: Set up to use the new submodule. Stop using --no-vc-files. Don't remove .gitignore files. Don't use or create .cvsignore. Diagnose an invalid --gnulib-srcdir=DIR argument. * build-aux/vc-list-files: Delete file, now pulled from gnulib. * build-aux/useless-if-before-free: Likewise. * po/POTFILES.in: Remove gnulib/lib/gai_strerror.c, since it no longer contains translatable strings. * gnulib/*: Remove gnulib/ hierarchy. --- .gitignore | 1 + .gitmodules | 3 + .gnulib | 1 + bootstrap | 45 +- build-aux/useless-if-before-free | 180 -- build-aux/vc-list-files | 107 - gnulib/lib/.cvsignore | 26 - gnulib/lib/.gitignore | 26 - gnulib/lib/Makefile.am | 1241 -------- gnulib/lib/alloca.c | 489 ---- gnulib/lib/alloca.in.h | 56 - gnulib/lib/arpa/.cvsignore | 1 - gnulib/lib/arpa/.gitignore | 1 - gnulib/lib/arpa_inet.in.h | 90 - ... diff --git a/.gitignore b/.gitignore index ca73a98..964580c 100644 --- a/.gitignore +++ b/.gitignore @@ -34,3 +34,4 @@ stamp-h stamp-h.in stamp-h1 update.log +tests/*.log diff --git a/.gitmodules b/.gitmodules new file mode 100644 index 0000000..7acb1ea --- /dev/null +++ b/.gitmodules @@ -0,0 +1,3 @@ +[submodule "gnulib"] + path = .gnulib + url = git://git.sv.gnu.org/gnulib.git diff --git a/.gnulib b/.gnulib new file mode 160000 index 0000000..1203e8d --- /dev/null +++ b/.gnulib @@ -0,0 +1 @@ +Subproject commit 1203e8d1f62dec3d2436dffadd5c20793cf84366 diff --git a/bootstrap b/bootstrap index baf52e7..7ce28da 100755 --- a/bootstrap +++ b/bootstrap @@ -40,25 +40,31 @@ do esac done -cleanup_gnulib() { - st=$? - rm -fr .gnulib - exit $st -} +# Get gnulib files. case ${GNULIB_SRCDIR--} in -) - if [ ! -d .gnulib ]; then + echo "$0: getting gnulib files..." + git submodule init || exit $? + git submodule update || exit $? + GNULIB_SRCDIR=.gnulib + ;; +*) + # Redirect the gnulib submodule to the directory on the command line + # if possible. + if test -d "$GNULIB_SRCDIR"/.git && \ + git config --file .gitmodules submodule.gnulib.url >/dev/null; then + git submodule init + GNULIB_SRCDIR=`cd $GNULIB_SRCDIR && pwd` + git config --replace-all submodule.gnulib.url $GNULIB_SRCDIR echo "$0: getting gnulib files..." - - trap cleanup_gnulib 1 2 13 15 - - git clone --depth 1 git://git.sv.gnu.org/gnulib .gnulib || - cleanup_gnulib - - trap - 1 2 13 15 + git submodule update || exit $? + GNULIB_SRCDIR=.gnulib + else + echo >&2 "$0: invalid gnulib srcdir: $GNULIB_SRCDIR" + exit 1 fi - GNULIB_SRCDIR=.gnulib + ;; esac gnulib_tool=$GNULIB_SRCDIR/gnulib-tool @@ -103,20 +109,9 @@ vc-list-files # put *.[ch] files in new gnulib/lib/ dir. $gnulib_tool \ - --no-vc-files \ --lgpl=2 \ --with-tests \ --m4-base=gnulib/m4 \ --source-base=gnulib/lib \ --tests-base=gnulib/tests \ --import $modules - -rm -f \ - .gitignore \ - gnulib/lib/.gitignore \ - gnulib/m4/.gitignore \ - gnulib/tests/.gitignore - -(cd gnulib/lib && - (cat .cvsignore; \ - ls -1 *.in.h|sed 's/\.in\.h/.h/') | sort -u > .t; mv .t .cvsignore) diff --git a/po/POTFILES.in b/po/POTFILES.in index 973f580..357cd70 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -1,4 +1,3 @@ -gnulib/lib/gai_strerror.c qemud/qemud.c qemud/remote.c src/bridge.c ... -- 1.6.3.3.524.g8586b >From ab811737a6914133bf12a46d4c5b5a2a2bdd9ee9 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Tue, 7 Jul 2009 12:05:18 +0200 Subject: [PATCH 6/7] remove all .cvsignore files --- .cvsignore | 34 ------------------------- build-aux/.cvsignore | 10 ------- build-aux/.gitignore | 2 + docs/.cvsignore | 4 --- docs/devhelp/.cvsignore | 3 -- docs/examples/.cvsignore | 7 ----- docs/examples/python/.cvsignore | 2 - docs/schemas/.cvsignore | 2 - examples/domain-events/events-c/.cvsignore | 6 ---- examples/hellolibvirt/.cvsignore | 5 ---- include/.cvsignore | 2 - include/libvirt/.cvsignore | 2 - m4/.cvsignore | 37 ---------------------------- po/.cvsignore | 15 ----------- proxy/.cvsignore | 5 ---- python/.cvsignore | 15 ----------- python/tests/.cvsignore | 2 - qemud/.cvsignore | 12 --------- src/.cvsignore | 20 --------------- tests/.cvsignore | 28 --------------------- tests/confdata/.cvsignore | 2 - tests/sexpr2xmldata/.cvsignore | 2 - tests/xencapsdata/.cvsignore | 2 - tests/xmconfigdata/.cvsignore | 2 - tests/xml2sexprdata/.cvsignore | 2 - tools/.cvsignore | 4 --- 26 files changed, 2 insertions(+), 225 deletions(-) ... -- 1.6.3.3.524.g8586b >From b718b0763f8fbfc35af586fa6d132d39259d0e11 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Tue, 7 Jul 2009 18:08:45 +0200 Subject: [PATCH 7/7] use gnumakefile and maintainer-makefile modules from gnulib * bootstrap (modules): Add gnumakefile and maintainer-makefile. * GNUmakefile: Remove file, now provided by gnulib. * Makefile.maint: Remove. Replaced by maint.mk from gnulib. .gitignore: Add GNUmakefile and maint.mk. * cfg.mk (prev_version_file): Disable this feature. Setting this to /dev/null avoids an otherwise harmless diagnostic. --- .gitignore | 2 + GNUmakefile | 60 ----- Makefile.maint | 770 -------------------------------------------------------- bootstrap | 2 + cfg.mk | 3 + 5 files changed, 7 insertions(+), 830 deletions(-) delete mode 100644 GNUmakefile delete mode 100644 Makefile.maint ... diff --git a/bootstrap b/bootstrap index 7ce28da..b0de3df 100755 --- a/bootstrap +++ b/bootstrap @@ -78,8 +78,10 @@ getaddrinfo gethostname getpass gettext +gnumakefile inet_pton ioctl +maintainer-makefile mkstemp mktempd perror diff --git a/cfg.mk b/cfg.mk index 35bedd1..736f7c0 100644 --- a/cfg.mk +++ b/cfg.mk @@ -227,3 +227,6 @@ sc_libvirt_unmarked_diagnostics: | grep '[ ]"' && \ { echo '$(ME): found unmarked diagnostic(s)' 1>&2; \ exit 1; } || : + +# We don't use this feature of maint.mk. +prev_version_file = /dev/null -- 1.6.3.3.524.g8586b

3 13

[libvirt] turn off dnsmasq
by Mike Power 09 Jul '09

09 Jul '09

I have a series of kvm vms I am running via libvirt. I have bind9 and dhcp3-server installed and I am happy with their configuration. The problem I have is that dhcp3-server and dnsmasq are currently fighting over who hands out the ip address. My vms work when they get their ip from dhcp3-server, and they fail when dnsmasq hands out the ip address. Unfortunately I can not get dnsmasq to stop handing out ip addresses. This is the configuration of my default network: <network> <name>default</name> <bridge name="virbr%d" /> <forward/> <ip address="192.168.122.1" netmask="255.255.255.0"> </ip> </network> Notice in the ip tag the optional dhcp tag is missing. Thus dnsmasq I thought, was supposed to leave well enough alone. It doesn't. I can turn off dhcp3-server and start up a host. What I see in the syslog is: Jul 7 08:52:21 vmhost dnsmasq[3420]: DHCPREQUEST(virbr0) 192.168.122.244 52:54:00:8f:7c:a4 Jul 7 08:52:21 vmhost dnsmasq[3420]: DHCPACK(virbr0) 192.168.122.244 52:54:00:8f:7c:a4 host1000 Then when I run ifconfig on the host1000 vm, it has an ip address that it obviously got from dnsmasq. I just need dnsmasq to stop handing out IPs, how do I do that? Mike Power

2 1

[libvirt] [PATCH 3/4] fix another failing "make distcheck" (qemuhelptest)
by Jim Meyering 09 Jul '09

09 Jul '09

This fixes another "make distcheck" (or non-srcdir) build failure: >From f9523d014a590fb881c14397f8c3869f328d023c Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Wed, 8 Jul 2009 08:35:24 +0200 Subject: [PATCH 3/4] fix another failing "make distcheck" (qemuhelptest) It failed in a non-srcdir build because those 5 sample output files were not included in the distribution tarball. Include them. * tests/Makefile.am (qemuhelpdata, EXTRA_DIST): Include these: kvm-74, kvm-86, qemu-0.10.5, qemu-0.9.1, qemu-kvm-0.10.5. --- tests/Makefile.am | 10 +++++++++- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 3d98d69..f8bde34 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -36,6 +36,13 @@ LDADDS = \ $(LIBSOCKET) \ $(COVERAGE_LDFLAGS) +qemuhelpdata = \ + kvm-74 \ + kvm-86 \ + qemu-0.10.5 \ + qemu-0.9.1 \ + qemu-kvm-0.10.5 + EXTRA_DIST = \ oomtrace.pl \ test-lib.sh \ @@ -51,7 +58,8 @@ EXTRA_DIST = \ storagevolschematest \ storagevolschemadata \ nodedevschematest \ - nodedevschemadata + nodedevschemadata \ + $(patsubst %,qemuhelpdata/%,$(qemuhelpdata)) noinst_PROGRAMS = virshtest conftest \ nodeinfotest statstest qparamtest -- 1.6.3.3.524.g8586b

3 4

[libvirt] [PATCH 4/4] generate ChangeLog from git logs into distribution tarball
by Jim Meyering 08 Jul '09

08 Jul '09

This is what I started out working on, before I noticed the "make distcheck" failures. >From 9fd0624b8cee33b8c725464d289cc5ce33ffc1c3 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Wed, 8 Jul 2009 08:54:25 +0200 Subject: [PATCH 4/4] generate ChangeLog from git logs into distribution tarball No longer maintain a version-controlled ChangeLog file, but do continue to include a ChangeLog file in distribution tarball. * Makefile.am (gen-ChangeLog): New rule. (dist-hook): Depend on it. (EXTRA_DIST): Add ChangeLog-old. * bootstrap (modules): Add gitlog-to-changelog. * ChangeLog: Remove file. Renamed to... * ChangeLog-old: ...this. New file. * autogen.sh: Touch ChangeLog, to ensure it exists. For automake. --- ChangeLog => ChangeLog-old | 2 +- Makefile.am | 15 +++++++++++++++ autogen.sh | 3 +++ bootstrap | 1 + build-aux/.gitignore | 1 + 5 files changed, 21 insertions(+), 1 deletions(-) rename ChangeLog => ChangeLog-old (99%) diff --git a/ChangeLog b/ChangeLog-old similarity index 99% rename from ChangeLog rename to ChangeLog-old index b266de6..c3b41e2 100644 --- a/ChangeLog +++ b/ChangeLog-old @@ -1207,7 +1207,7 @@ Fri Apr 24 13:17:47 BST 2009 Daniel P. Berrange <berrange(a)redhat.com> Fix network config in XM driver * src/xm_internal.c: Fix setting of bridge & script parameters in VIF config - * src/xend_internal.h, src/xend_internal.c: Export the + * src/xend_internal.h, src/xend_internal.c: Export the default bridge script name to XM driver * tests/xmconfigdata/*: Update to take account of script= setting in VIF config diff --git a/Makefile.am b/Makefile.am index c251f96..f9efff5 100644 --- a/Makefile.am +++ b/Makefile.am @@ -9,6 +9,7 @@ SUBDIRS = gnulib/lib include src qemud tools proxy docs gnulib/tests \ ACLOCAL_AMFLAGS = -I m4 -I gnulib/m4 EXTRA_DIST = \ + ChangeLog-old \ libvirt.spec libvirt.spec.in \ mingw32-libvirt.spec.in \ libvirt.pc libvirt.pc.in \ @@ -49,3 +50,17 @@ clean-cov: # disable this check distuninstallcheck: + +dist-hook: gen-ChangeLog + +# Generate the ChangeLog file (with all entries since the switch to git) +# and insert it into the directory we're about to use to create a tarball. +gen_start_date = 2009-07-04 +.PHONY: gen-ChangeLog +gen-ChangeLog: + if test -d .git; then \ + $(top_srcdir)/build-aux/gitlog-to-changelog \ + --since=$(gen_start_date) > $(distdir)/cl-t; \ + rm -f $(distdir)/ChangeLog; \ + mv $(distdir)/cl-t $(distdir)/ChangeLog; \ + fi diff --git a/autogen.sh b/autogen.sh index 788729f..c026112 100755 --- a/autogen.sh +++ b/autogen.sh @@ -54,6 +54,9 @@ if test -z "$*"; then echo "to pass any to it, please specify them on the $0 command line." fi +# Automake requires that ChangeLog exist. +touch ChangeLog + autopoint --force #rm -rf m4 libtoolize --copy --force diff --git a/bootstrap b/bootstrap index b0de3df..0754d02 100755 --- a/bootstrap +++ b/bootstrap @@ -78,6 +78,7 @@ getaddrinfo gethostname getpass gettext +gitlog-to-changelog gnumakefile inet_pton ioctl diff --git a/build-aux/.gitignore b/build-aux/.gitignore index af6c366..62188c1 100644 --- a/build-aux/.gitignore +++ b/build-aux/.gitignore @@ -10,3 +10,4 @@ mkinstalldirs mktempd /useless-if-before-free /vc-list-files +/gitlog-to-changelog -- 1.6.3.3.524.g8586b

3 3

[libvirt] netcf error message...
by Shahar Klein 08 Jul '09

08 Jul '09

folowing the instructions in netcf I'm trying to run some basic interface configuration via libvirt patched with the netcf patches I get error messages - but the interface(eth1) seem to be managed correctly - do I have an aug(what is that?) problem? virsh # iface-define /root/libvirt_working/eth1.xml error: Failed to define interface from /root/libvirt_working/eth1.xml error: internal error could not get interface XML description (netcf: unspecified error - aug_save failed) virsh # iface-list Name State MAC Address -------------------------------------------- eth0 active 00:18:fe:28:7d:82 lo active 00:00:00:00:00:00 virsh # iface-start eth1 Interface eth1 started virsh # iface-list Name State MAC Address -------------------------------------------- eth0 active 00:18:fe:28:7d:82 eth1 active 00:18:fe:28:7d:83 lo active 00:00:00:00:00:00

1 0

[libvirt] kernel summit topic - 'containers end-game'
by Serge E. Hallyn 08 Jul '09

08 Jul '09

A topic on ksummit agenda is 'containers end-game and how do we get there'. So for starters, looking just at application (and system) containers, what do the libvirt and liblxc projects want to see in kernel support that is currently missing? Are there specific things that should be done soon to make containers more useful and usable? More generally, the topic raises the question... what 'end-games' are there? A few I can think of off-hand include: 1. resource control 2. lightweight virtual servers 3. (or 2.5) unprivileged containers/jail-on-steroids (lightweight virtual servers in which you might, just maybe, almost, be able to give away a root account, at least as much as you could do so with a kvm/qemu/xen partition) 4. checkpoint, restart, and migration For each end-game, what kernel pieces do we think are missing? For instance, people seem agreed that resource control needs io control :) Containers imo need a user namespace. I think there are quite a few network namespace exploiters who require sysfs directory tagging (or some equivalent) to allow us to migrate physical devices into network namespaces. And checkpoint/restart needs... checkpoint/restart. thanks, -serge

5 14

[libvirt] PATCH: Fix LXC container capabilities
by Daniel P. Berrange 08 Jul '09

08 Jul '09

My previous change to LXC container capabilties setup has a fairly stupid bug in it. The container init process starts off with no capabilities whatsoever :-( This was caused by a bogus capng_lock() call which meant that all capabilities were cleared when the init process was exec'd. The capng_lock call sets NOROOT & NROOT_LOCKED flags in the process secure bits. This is not neccessary for the init process - we have reduced the bounding set which is sufficient for our security goals. With the capng_lock() call removed, the init process gets its permitted and effective sets filled to match the bounding set which is the desired scenario. Daniel diff --git a/src/lxc_container.c b/src/lxc_container.c index 950dd50..b3978df 100644 --- a/src/lxc_container.c +++ b/src/lxc_container.c @@ -675,16 +675,9 @@ static int lxcContainerDropCapabilities(void) _("failed to apply capabilities: %d"), ret); return -1; } - - /* Need to prevent them regaining any caps on exec */ - if ((ret = capng_lock()) < 0) { - lxcError(NULL, NULL, VIR_ERR_INTERNAL_ERROR, - _("failed to lock capabilities: %d"), ret); - return -1; - } - #else - VIR_WARN0(_("libcap-ng support not compiled in, unable to clear capabilities")); + /* Don't warn, since this ends up going to the guest console and annoying admins + VIR_WARN0(_("libcap-ng support not compiled in, unable to clear capabilities")); */ #endif return 0; } -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1

[libvirt] Cannot get network to work with LXC
by James Yu 08 Jul '09

08 Jul '09

Hi all, I tried to use the first xml config in http://libvirt.org/drvlxc.html to setup my first light weight container. However, I was unable to get the container's network to work. When I tried to give the interface an IP, I got the following error message: sh-4.0# /sbin/ifconfig veth1 192.168.0.1/24 SIOCSIFADDR: Permission denied SIOCSIFNETMASK: Permission denied SIOCGIFADDR: Cannot assign requested address SIOCSIFBROADCAST: Permission denied SIOCSIFFLAGS: Permission denied sh-4.0# Any advise ? This is a UTF-8 formatted mail ----------------------------------------------- James C.-C.Yu

3 2

[libvirt] PATCH: Video device config
by Tom Hughes 08 Jul '09

08 Jul '09

I recently posted a patch on the RedHat bugzilla (bug #467038) to add a model attribute to the graphics element so that the different graphics cards supported by QEMU could be selected. Apparently that approach has been rejected in the past however, and the preferred approach is to add a separate video element. I've taken the patch that Daniel Berrange posted here a few months ago that added the necessary XML handling for the new element and extended it by filling in the QEMU driver code to make it use the model details as well as fixing the default video model for XEN domains as per the list of outstanding issues given with the original patch. The updated patch is attached, and based on the list of outstanding tasks given before what remains to be done is: - Add RNG XML schemas & website docs - Make Xen drivers use this info for setting stdvga=1|0 config arg - Make VirtualBox use this info in whatever way it needs Tom -- Tom Hughes (tom(a)compton.nu) http://www.compton.nu/

3 3

[libvirt] [PATCH 2/4] fix failing "make distcheck"
by Jim Meyering 08 Jul '09

08 Jul '09

Make distcheck would fail without this: >From e2f91000a33168d2aaac89f94f1b11c633c579f0 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Wed, 8 Jul 2009 08:15:54 +0200 Subject: [PATCH 2/4] fix failing "make distcheck" * docs/Makefile.am (xml): Distribute testpool.xml and testvol.xml, which are referenced from testnode.xml. --- docs/Makefile.am | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index 43d04c3..4bdb827 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -55,7 +55,9 @@ xml = \ testdomfv0.xml \ testnetdef.xml \ testnetpriv.xml \ - testnode.xml + testnode.xml \ + testpool.xml \ + testvol.xml fig = \ libvirt-net-logical.fig \ -- 1.6.3.3.524.g8586b

3 2

[libvirt] [PATCH 1/4] Don't use mylibtool, (subsumed by automake's silent rules)
by Jim Meyering 08 Jul '09

08 Jul '09

Its use was causing a non-srcdir build to fail. * Makefile.am (EXTRA_DIST): Remove mylibtool. * configure.in: Don't use mylibtool. --- An alternative (if you don't want to use automake's silent-rules option) would be to keep mylibtool, but to use $(abs_top_srcdir) rather than $(top_srcdir) in that script. Makefile.am | 3 +-- configure.in | 4 ---- 2 files changed, 1 insertions(+), 6 deletions(-) diff --git a/Makefile.am b/Makefile.am index dd98ff2..c251f96 100644 --- a/Makefile.am +++ b/Makefile.am @@ -20,8 +20,7 @@ EXTRA_DIST = \ .x-sc_require_config_h \ .x-sc_prohibit_nonreentrant \ Makefile.nonreentrant \ - autogen.sh \ - mylibtool + autogen.sh man_MANS = virsh.1 diff --git a/configure.in b/configure.in index 1170958..a6f6754 100644 --- a/configure.in +++ b/configure.in @@ -59,10 +59,6 @@ dnl Support building Win32 DLLs (must appear *before* AM_PROG_LIBTOOL) AC_LIBTOOL_WIN32_DLL AM_PROG_LIBTOOL -dnl Override normal libtool in favour of our quiet version -LIBTOOL='$(SHELL) $(top_srcdir)/mylibtool' -AC_SUBST([LIBTOOL]) - AM_PROG_CC_C_O VERSION_SCRIPT_FLAGS=-Wl,--version-script= -- 1.6.3.3.524.g8586b

2 4

[libvirt] PATCH 2/2: Support <video> element in QEMU driver
by Daniel P. Berrange 08 Jul '09

08 Jul '09

This patch extends the QEMU driver to support the <video> element for configuring the type of video adapter exposed to the guest. It implements the XML -> ARGV and ARGV -> XML conversions, so both import & export work. Some of the existing tests are updated to use the <video> element to get test coverage. The QEMU help parsing test is changed to use symbolic constants instead of black magic hex constants. This supports both old -std-vga and new -vga style QEMU args. Daniel From: Daniel P. Berrange <berrange(a)redhat.com> Date: Mon, 6 Jul 2009 14:59:19 +0100 Subject: [PATCH 2/3] Support <video> element for QEMU guests * src/qemu_conf.c, src/qemu_conf.h: Use -vga or -std-vga when starting guests if video card is present * tests/qemuhelptest.c: Change to use constants instead of hardcoded hex numbers, and add VGA support * tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl-fullscreen.xml, tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.args, tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml, tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.args, tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.xml, tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-tls.xml, tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml, tests/qemuxml2argvdata/qemuxml2argv-input-xen.xml: Add <video> element for testing graphics adapter * tests/qemuxml2argvtest.c: Add QEMUD_CMD_FLAG_VGA flag * tests/qemuxml2xmltest.c: Add missing graphics-vnc-sasl/tls tests --- src/qemu_conf.c | 89 ++++++++++++++++++++ src/qemu_conf.h | 1 + tests/qemuhelptest.c | 66 +++++++++++++- .../qemuxml2argv-graphics-sdl-fullscreen.xml | 3 + .../qemuxml2argv-graphics-sdl.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml | 3 + .../qemuxml2argv-graphics-vnc-sasl.args | 2 +- .../qemuxml2argv-graphics-vnc-sasl.xml | 3 + .../qemuxml2argv-graphics-vnc-tls.xml | 3 + .../qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml | 3 + tests/qemuxml2argvdata/qemuxml2argv-input-xen.xml | 3 + tests/qemuxml2argvtest.c | 2 +- tests/qemuxml2xmltest.c | 2 + 13 files changed, 174 insertions(+), 8 deletions(-) diff --git a/src/qemu_conf.c b/src/qemu_conf.c index 9ca60b9..6337045 100644 --- a/src/qemu_conf.c +++ b/src/qemu_conf.c @@ -78,6 +78,15 @@ VIR_ENUM_IMPL(qemuDiskCacheV2, VIR_DOMAIN_DISK_CACHE_LAST, "writethrough", "writeback"); +VIR_ENUM_DECL(qemuVideo) + +VIR_ENUM_IMPL(qemuVideo, VIR_DOMAIN_VIDEO_TYPE_LAST, + "std", + "cirrus", + "vmware", + NULL, /* no arg needed for xen */ + NULL /* don't support vbox */); + int qemudLoadDriverConfig(struct qemud_driver *driver, const char *filename) { @@ -455,6 +464,8 @@ static unsigned int qemudComputeCmdFlags(const char *help, if (strstr(help, "format=")) flags |= QEMUD_CMD_FLAG_DRIVE_FORMAT; } + if (strstr(help, "-vga") && !strstr(help, "-std-vga")) + flags |= QEMUD_CMD_FLAG_VGA; if (strstr(help, "boot=on")) flags |= QEMUD_CMD_FLAG_DRIVE_BOOT; if (version >= 9000) @@ -1533,6 +1544,53 @@ int qemudBuildCommandLine(virConnectPtr conn, ADD_ARG_LIT("-full-screen"); } + if (def->nvideos) { + if (def->nvideos > 1) { + qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, + "%s", _("only one video card is currentely supported")); + goto error; + } + + if (qemuCmdFlags & QEMUD_CMD_FLAG_VGA) { + if (def->videos[0]->type == VIR_DOMAIN_VIDEO_TYPE_XEN) { + /* nothing - vga has no effect on Xen pvfb */ + } else { + const char *vgastr = qemuVideoTypeToString(def->videos[0]->type); + if (!vgastr) { + qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, + _("video type %s is not supported with QEMU"), + virDomainVideoTypeToString(def->videos[0]->type)); + goto error; + } + + ADD_ARG_LIT("-vga"); + ADD_ARG_LIT(vgastr); + } + } else { + + switch (def->videos[0]->type) { + case VIR_DOMAIN_VIDEO_TYPE_VGA: + ADD_ARG_LIT("-std-vga"); + break; + + case VIR_DOMAIN_VIDEO_TYPE_VMVGA: + ADD_ARG_LIT("-vmwarevga"); + break; + + case VIR_DOMAIN_VIDEO_TYPE_XEN: + case VIR_DOMAIN_VIDEO_TYPE_CIRRUS: + /* No special args - this is the default */ + break; + + default: + qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, + _("video type %s is not supported with QEMU"), + virDomainVideoTypeToString(def->videos[0]->type)); + goto error; + } + } + } + /* Add sound hardware */ if (def->nsounds) { int size = 100; @@ -2428,6 +2486,7 @@ virDomainDefPtr qemuParseCommandLine(virConnectPtr conn, char *path; int nnics = 0; const char **nics = NULL; + int video = VIR_DOMAIN_VIDEO_TYPE_CIRRUS; if (!progargv[0]) { qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, @@ -2805,6 +2864,18 @@ virDomainDefPtr qemuParseCommandLine(virConnectPtr conn, def->os.bootloader = strdup(val); if (!def->os.bootloader) goto no_memory; + } else if (STREQ(arg, "-vmwarevga")) { + video = VIR_DOMAIN_VIDEO_TYPE_VMVGA; + } else if (STREQ(arg, "-std-vga")) { + video = VIR_DOMAIN_VIDEO_TYPE_VGA; + } else if (STREQ(arg, "-vga")) { + WANT_VALUE(); + video = qemuVideoTypeFromString(val); + if (video < 0) { + qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, + _("unknown video adapter type '%s'"), val); + goto error; + } } else if (STREQ(arg, "-domid")) { WANT_VALUE(); /* ignore, generted on the fly */ @@ -2859,6 +2930,24 @@ virDomainDefPtr qemuParseCommandLine(virConnectPtr conn, def->graphics[def->ngraphics++] = sdl; } + if (def->ngraphics) { + virDomainVideoDefPtr vid; + if (VIR_ALLOC(vid) < 0) + goto no_memory; + if (def->virtType == VIR_DOMAIN_VIRT_XEN) + vid->type = VIR_DOMAIN_VIDEO_TYPE_XEN; + else + vid->type = video; + vid->vram = virDomainVideoDefaultRAM(def, vid->type); + vid->heads = 1; + + if (VIR_REALLOC_N(def->videos, def->nvideos+1) < 0) { + virDomainVideoDefFree(vid); + goto no_memory; + } + def->videos[def->nvideos++] = vid; + } + VIR_FREE(nics); if (!def->name) { diff --git a/src/qemu_conf.h b/src/qemu_conf.h index c0ed46d..9065821 100644 --- a/src/qemu_conf.h +++ b/src/qemu_conf.h @@ -57,6 +57,7 @@ enum qemud_cmd_flags { QEMUD_CMD_FLAG_DRIVE_CACHE_V2 = (1 << 12), /* Is the cache= flag wanting new v2 values */ QEMUD_CMD_FLAG_KVM = (1 << 13), /* Whether KVM is compiled in */ QEMUD_CMD_FLAG_DRIVE_FORMAT = (1 << 14), /* Is -drive format= avail */ + QEMUD_CMD_FLAG_VGA = (1 << 15), /* Is -vga avail */ }; /* Main driver state */ diff --git a/tests/qemuhelptest.c b/tests/qemuhelptest.c index bf8a293..73eae54 100644 --- a/tests/qemuhelptest.c +++ b/tests/qemuhelptest.c @@ -89,11 +89,67 @@ mymain(int argc, char **argv) ret = -1; \ } while (0) - DO_TEST("qemu-0.9.1", 0x002f, 9001, 0, 0); - DO_TEST("kvm-74", 0x633e, 9001, 1, 74); - DO_TEST("qemu-0.10.5", 0x5c6f, 10005, 0, 0); - DO_TEST("qemu-kvm-0.10.5", 0x7d7e, 10005, 1, 0); - DO_TEST("kvm-86", 0x7d7e, 10050, 1, 0); + DO_TEST("qemu-0.9.1", + QEMUD_CMD_FLAG_KQEMU | + QEMUD_CMD_FLAG_VNC_COLON | + QEMUD_CMD_FLAG_NO_REBOOT | + QEMUD_CMD_FLAG_DRIVE | + QEMUD_CMD_FLAG_NAME, + 9001, 0, 0); + DO_TEST("kvm-74", + QEMUD_CMD_FLAG_VNC_COLON | + QEMUD_CMD_FLAG_NO_REBOOT | + QEMUD_CMD_FLAG_DRIVE | + QEMUD_CMD_FLAG_DRIVE_BOOT | + QEMUD_CMD_FLAG_NAME | + QEMUD_CMD_FLAG_VNET_HDR | + QEMUD_CMD_FLAG_MIGRATE_KVM_STDIO | + QEMUD_CMD_FLAG_KVM | + QEMUD_CMD_FLAG_DRIVE_FORMAT, + 9001, 1, 74); + DO_TEST("qemu-0.10.5", + QEMUD_CMD_FLAG_KQEMU | + QEMUD_CMD_FLAG_VNC_COLON | + QEMUD_CMD_FLAG_NO_REBOOT | + QEMUD_CMD_FLAG_DRIVE | + QEMUD_CMD_FLAG_NAME | + QEMUD_CMD_FLAG_UUID | + QEMUD_CMD_FLAG_MIGRATE_QEMU_TCP | + QEMUD_CMD_FLAG_MIGRATE_QEMU_EXEC | + QEMUD_CMD_FLAG_DRIVE_CACHE_V2 | + QEMUD_CMD_FLAG_DRIVE_FORMAT | + QEMUD_CMD_FLAG_VGA, + 10005, 0, 0); + DO_TEST("qemu-kvm-0.10.5", + QEMUD_CMD_FLAG_VNC_COLON | + QEMUD_CMD_FLAG_NO_REBOOT | + QEMUD_CMD_FLAG_DRIVE | + QEMUD_CMD_FLAG_DRIVE_BOOT | + QEMUD_CMD_FLAG_NAME | + QEMUD_CMD_FLAG_UUID | + QEMUD_CMD_FLAG_VNET_HDR | + QEMUD_CMD_FLAG_MIGRATE_QEMU_TCP | + QEMUD_CMD_FLAG_MIGRATE_QEMU_EXEC | + QEMUD_CMD_FLAG_DRIVE_CACHE_V2 | + QEMUD_CMD_FLAG_KVM | + QEMUD_CMD_FLAG_DRIVE_FORMAT | + QEMUD_CMD_FLAG_VGA, + 10005, 1, 0); + DO_TEST("kvm-86", + QEMUD_CMD_FLAG_VNC_COLON | + QEMUD_CMD_FLAG_NO_REBOOT | + QEMUD_CMD_FLAG_DRIVE | + QEMUD_CMD_FLAG_DRIVE_BOOT | + QEMUD_CMD_FLAG_NAME | + QEMUD_CMD_FLAG_UUID | + QEMUD_CMD_FLAG_VNET_HDR | + QEMUD_CMD_FLAG_MIGRATE_QEMU_TCP | + QEMUD_CMD_FLAG_MIGRATE_QEMU_EXEC | + QEMUD_CMD_FLAG_DRIVE_CACHE_V2 | + QEMUD_CMD_FLAG_KVM | + QEMUD_CMD_FLAG_DRIVE_FORMAT | + QEMUD_CMD_FLAG_VGA, + 10050, 1, 0); return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl-fullscreen.xml b/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl-fullscreen.xml index fe1fe1a..f3fc588 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl-fullscreen.xml +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl-fullscreen.xml @@ -20,5 +20,8 @@ </disk> <input type='mouse' bus='ps2'/> <graphics type='sdl' display=':0.1' xauth='/root/.Xauthority' fullscreen='yes'/> + <video> + <model type='cirrus' vram='9216' heads='1'/> + </video> </devices> </domain> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.args b/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.args index 3b2b049..f908252 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.args @@ -1 +1 @@ -LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test XAUTHORITY=/root/.Xauthority DISPLAY=:0.1 /usr/bin/qemu -S -M pc -m 214 -smp 1 -monitor pty -no-acpi -boot c -hda /dev/HostVG/QEMUGuest1 -net none -serial none -parallel none -usb +LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test XAUTHORITY=/root/.Xauthority DISPLAY=:0.1 /usr/bin/qemu -S -M pc -m 214 -smp 1 -monitor pty -no-acpi -boot c -hda /dev/HostVG/QEMUGuest1 -net none -serial none -parallel none -usb -std-vga diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml b/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml index 1e04f12..431c3c9 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml @@ -20,5 +20,8 @@ </disk> <input type='mouse' bus='ps2'/> <graphics type='sdl' display=':0.1' xauth='/root/.Xauthority'/> + <video> + <model type='vga' vram='9216' heads='1'/> + </video> </devices> </domain> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.args b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.args index a41a57c..bd63540 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.args @@ -1 +1 @@ -LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test SASL_CONF_DIR=/root/.sasl2 /usr/bin/qemu -S -M pc -m 214 -smp 1 -monitor pty -no-acpi -boot c -hda /dev/HostVG/QEMUGuest1 -net none -serial none -parallel none -usb -vnc 127.0.0.1:3,sasl +LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test SASL_CONF_DIR=/root/.sasl2 /usr/bin/qemu -S -M pc -m 214 -smp 1 -monitor pty -no-acpi -boot c -hda /dev/HostVG/QEMUGuest1 -net none -serial none -parallel none -usb -vnc 127.0.0.1:3,sasl -vga cirrus diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.xml b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.xml index cbaa1da..b6f99d3 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.xml +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.xml @@ -20,5 +20,8 @@ </disk> <input type='mouse' bus='ps2'/> <graphics type='vnc' port='5903' autoport='no' listen='127.0.0.1'/> + <video> + <model type='cirrus' vram='9216' heads='1'/> + </video> </devices> </domain> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-tls.xml b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-tls.xml index cbaa1da..b6f99d3 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-tls.xml +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-tls.xml @@ -20,5 +20,8 @@ </disk> <input type='mouse' bus='ps2'/> <graphics type='vnc' port='5903' autoport='no' listen='127.0.0.1'/> + <video> + <model type='cirrus' vram='9216' heads='1'/> + </video> </devices> </domain> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml index cbaa1da..b6f99d3 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml @@ -20,5 +20,8 @@ </disk> <input type='mouse' bus='ps2'/> <graphics type='vnc' port='5903' autoport='no' listen='127.0.0.1'/> + <video> + <model type='cirrus' vram='9216' heads='1'/> + </video> </devices> </domain> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-input-xen.xml b/tests/qemuxml2argvdata/qemuxml2argv-input-xen.xml index 1e80317..fea7f8e 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-input-xen.xml +++ b/tests/qemuxml2argvdata/qemuxml2argv-input-xen.xml @@ -20,5 +20,8 @@ </disk> <input type='mouse' bus='xen'/> <graphics type='vnc' port='5903' autoport='no' listen='127.0.0.1'/> + <video> + <model type='xen' vram='4096' heads='1'/> + </video> </devices> </domain> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 28609eb..2a93018 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -216,7 +216,7 @@ mymain(int argc, char **argv) driver.vncSASL = 1; driver.vncSASLdir = strdup("/root/.sasl2"); - DO_TEST("graphics-vnc-sasl", 0); + DO_TEST("graphics-vnc-sasl", QEMUD_CMD_FLAG_VGA); driver.vncTLS = 1; driver.vncTLSx509verify = 1; driver.vncTLSx509certdir = strdup("/etc/pki/tls/qemu"); diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index ab9943d..7db7611 100644 --- a/tests/qemuxml2xmltest.c +++ b/tests/qemuxml2xmltest.c @@ -102,6 +102,8 @@ mymain(int argc, char **argv) DO_TEST("disk-drive-cache-v1-wb"); DO_TEST("disk-drive-cache-v1-none"); DO_TEST("graphics-vnc"); + DO_TEST("graphics-vnc-sasl"); + DO_TEST("graphics-vnc-tls"); DO_TEST("graphics-sdl"); DO_TEST("graphics-sdl-fullscreen"); DO_TEST("input-usbmouse"); -- 1.6.2.5 -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 2

[libvirt] [PATCH] provide the object name on lookup error
by Daniel Veillard 08 Jul '09

08 Jul '09

There were a number of places where the object name was not not reported, based on the use I don't think the string could be NULL in any of those. I also fixed a few POOL error which were really VOLume ones. Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

4 5

[libvirt] daily builds of pristine upstream sources for qemu, qemu-kvm, and libvirt
by Dustin Kirkland 08 Jul '09

08 Jul '09

Howdy, developers of qemu, qemu-kvm, and libvirt. I periodically see bug reports on these lists from users of Ubuntu packages of these projects. Since these users are often running some version of the project older than the current development branch, it's more interesting to know if the user can reproduce the bug on the latest development sources. I have constructed some automation that builds Debian/Ubuntu binaries for amd64, i386, and lpia platforms directly from your master git repositories every day at 11:00 UTC, and publishes them in a special, opt-in repository. These daily builds also drop any specific patches we may be carrying, in order to minimize the delta between the binaries built and your upstream sources. * https://launchpad.net/~ubuntu-virt/+archive/virt-daily-upstream In the event that an Ubuntu user reports a problem, and there's an interest in trying to reproduce the problem against the tip of the development branch, we can point them at this resource for testing purposes. Additionally, this tool also has the ability to expose build breakages. For example (let's not debug this in this thread), at the moment, qemu's build is broken, somewhere near: .... LINK cris-softmmu/qemu-system-cris ../libqemu_common.a(esdaudio.o): In function `qesd_run_in': /build/buildd/qemu-0.10.50.20090707062004/audio/esdaudio.c:400: undefined reference to `audio_pt_lock' .... Launchpad publishes the full build logs available for each architecture at the link above. For the above example, the specific build log is: * http://launchpadlibrarian.net/28761559/buildlog_ubuntu-karmic-amd64.qemu_0.… If anyone has suggestions as to the utility of this resource, I would appreciate constructive feedback. Cheers, -- :-Dustin

1 0

[libvirt] [PATCH] allow to set path to xen userspace tools
by Guido Günther 08 Jul '09

08 Jul '09

Hi, attached patch makes the path to the xen userspace tools configurable. Debian keeps this under /usr/lib/xen-default/ instead of /usr/lib/xen/. We don't have the amd64 libs in /usr/lib64/xen either so we can use: ./configure --with-xen-tools=/usr/lib/xen-defaults --with-xen-tools64=/usr/lib/xen-defaults instead of patching src/xen_internals.c directly. Skipping above options gives the current behaviour. I checked that "make check" still passes. O.k. to apply? Cheers, -- Guido

3 3

[libvirt] [PATCH] Power Hypervisor Support for libvirt - minimum set of features
by Eduardo Otubo 08 Jul '09

08 Jul '09

Hello all, This is the initial patch for the driver for IBM Power Hypervisors. The minimum set of features are now implemented: list, list --all and dumpxml. Here is the Changeset since last PATCH I sent: * The URI has changed to: phyp://user@[hmc|ivm]/managed_system. If the system is a HMC+VIOS based, only an HMC authentication will be required. Commands will be sent to VIOS trough HMC command line. And if the system is an IVM based, then just provide the username and password for IVM. * Since the Power Hypervisor has no information about UUID's, I built a little database (uuid_db) to store and associate LPAR ID's with UUID randomly generated by the API. * The command dumpxml is implemented, but there are some informations missing. Fetching informations like fstab, os type, uptime, IP addr and so on, will only be available in a future versions of the HMC system. * The TODO list is now set to implement life cycle functions. Thanks in advance, []'s -- Eduardo Otubo Software Engineer Linux Technology Center IBM Systems & Technology Group Mobile: +55 19 8135 0885 otubo(a)linux.vnet.ibm.com

2 7

[libvirt] PATCH: 0/3: Run QEMU guests within a CGroup
by Daniel P. Berrange 08 Jul '09

08 Jul '09

Recent Linux kernels have a new concept of 'CGroups' which is a way to group tasks on the system and apply policy to them as a whole. We already use this in the LXC container driver, to control total memory usage of things runing within a container. This patch series is a proof of concept to make use of CGroups in the QEMU driver. The idea is that we have a 3 level cgroup hierarchy - Top level; contains the libvirtd daemon itself - 2nd level: one per libvirt driver, but dos not contain any processes. - 3rd level: one per guest VM. Contains the QEMU process The host admin can do control on the top level and 2nd level to set an overall system policy. libvirt will then provide APIs / capabilities to control individual VMs policy. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

4 10

[libvirt] [PATCH 1/2] Added new filesystem glusterfs
by Harshavardhana 08 Jul '09

08 Jul '09

Added new enum for glusterfs, another netfs based filesystem. --- src/storage_conf.c | 2 +- src/storage_conf.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/storage_conf.c b/src/storage_conf.c index 5f724dc..16ed906 100644 --- a/src/storage_conf.c +++ b/src/storage_conf.c @@ -68,7 +68,7 @@ VIR_ENUM_IMPL(virStoragePoolFormatFileSystem, VIR_ENUM_IMPL(virStoragePoolFormatFileSystemNet, VIR_STORAGE_POOL_NETFS_LAST, - "auto", "nfs") + "auto", "nfs", "glusterfs") VIR_ENUM_IMPL(virStoragePoolFormatDisk, VIR_STORAGE_POOL_DISK_LAST, diff --git a/src/storage_conf.h b/src/storage_conf.h index 8a4fed2..27dc4a7 100644 --- a/src/storage_conf.h +++ b/src/storage_conf.h @@ -151,7 +151,6 @@ struct _virStoragePoolSourceHost { int protocol; }; - /* * Available extents on the underlying storage */ @@ -366,6 +365,7 @@ VIR_ENUM_DECL(virStoragePoolFormatFileSystem) enum virStoragePoolFormatFileSystemNet { VIR_STORAGE_POOL_NETFS_AUTO = 0, VIR_STORAGE_POOL_NETFS_NFS, + VIR_STORAGE_POOL_NETFS_GLUSTERFS, VIR_STORAGE_POOL_NETFS_LAST, }; VIR_ENUM_DECL(virStoragePoolFormatFileSystemNet) -- 1.6.0.6

2 1

[libvirt] Can't boot guest after adding an IDE storage
by M. Mohan Kumar 08 Jul '09

08 Jul '09

Hi, We installed Fedora 11 guest in an emulated SCSI disk using virt-install. After the installation the guest was shutdown and additional IDE virtual storage was added to the guest. When we try to boot the guest from virt-manager, it tries to boot from the newly added IDE storage (instead of installed SCSI storage) and fails to boot. It seems that how the disk devices are sorted is the problem. There is a bug opened to track this issue: https://bugzilla.redhat.com/show_bug.cgi?id=507271 As dicussed in the bugzilla, ideally there should be a 'bootable' flag for each storage device. Also virt-manager could another option to specify which disk to boot from. Regards, M. Mohan Kumar

3 2

[libvirt] [PATCH] don't raise a missing network as an internal error
by Daniel Veillard 08 Jul '09

08 Jul '09

https://bugzilla.redhat.com/show_bug.cgi?id=509189 When defining a domain referencing a missing network the erro should not be raised as an internal error. Patch by Paolo Bonzini looks fine to me, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

2 2

[libvirt] Switch from CVS to GIT is done
by Daniel Veillard 07 Jul '09

07 Jul '09

Thanks to Jim Meyering we now have a new git repository, I deprecated the CVS repository, it's read only, you should still be able to keep it around to make patches for a few weeks if needed. The new repo is at: http://libvirt.org/git/?p=libvirt.git;a=summary Unfortunately Jim had to clean up the conversion from CVS that was used previously at git://git.et.redhat.com/libvirt.git so the two are not compatible and the best is to clone a new tree using git clone git://libvirt.org/libvirt.git and then copying over your set of patches with "git format-patch" in the old dir and "git am" to paste them into the new cloned-dir (Jim can certainly provide more details if needed). Let us know if you see something weird in the new tree or on the web site, I have updated the download informations at http://libvirt.org/downloads.html A few things may change but I guess the switch is done at this point, Many thanks to Jim for maintaining the old tree and the migration ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

6 16

[libvirt] [PATCH 1/2] Added new filesystem glusterfs
by Harshavardhana 07 Jul '09

07 Jul '09

Added new enum for glusterfs, a new netfs based filesystem --- src/storage_conf.c | 2 +- src/storage_conf.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/storage_conf.c b/src/storage_conf.c index 5f724dc..16ed906 100644 --- a/src/storage_conf.c +++ b/src/storage_conf.c @@ -68,7 +68,7 @@ VIR_ENUM_IMPL(virStoragePoolFormatFileSystem, VIR_ENUM_IMPL(virStoragePoolFormatFileSystemNet, VIR_STORAGE_POOL_NETFS_LAST, - "auto", "nfs") + "auto", "nfs", "glusterfs") VIR_ENUM_IMPL(virStoragePoolFormatDisk, VIR_STORAGE_POOL_DISK_LAST, diff --git a/src/storage_conf.h b/src/storage_conf.h index 8a4fed2..27dc4a7 100644 --- a/src/storage_conf.h +++ b/src/storage_conf.h @@ -151,7 +151,6 @@ struct _virStoragePoolSourceHost { int protocol; }; - /* * Available extents on the underlying storage */ @@ -366,6 +365,7 @@ VIR_ENUM_DECL(virStoragePoolFormatFileSystem) enum virStoragePoolFormatFileSystemNet { VIR_STORAGE_POOL_NETFS_AUTO = 0, VIR_STORAGE_POOL_NETFS_NFS, + VIR_STORAGE_POOL_NETFS_GLUSTERFS, VIR_STORAGE_POOL_NETFS_LAST, }; VIR_ENUM_DECL(virStoragePoolFormatFileSystemNet) -- 1.6.0.6

1 0

[libvirt] make distcheck failure
by Guido Günther 07 Jul '09

07 Jul '09

Hi, in current git make distcheck currently fails on me with: make[5]: Entering directory `/var/scratch/debian/libvirt/cvs/libvirt/libvirt-0.6.5/_build/gnulib/lib' /bin/sh ../../../mylibtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../../gnulib/lib -I../.. -I../../intl -g -O2 -MT c-ctype.lo -MD -MP -MF .deps/c-ctype.Tpo -c -o c-ctype.lo ../../../gnulib/lib/c-ctype.c (CC) -o c-ctype.lo ../../../gnulib/lib/c-ctype.c ../../../mylibtool: line 58: /var/scratch/debian/libvirt/cvs/libvirt/libvirt-0.6.5/_build/gnulib/lib/../../../libtool: No such file or directory ../../../mylibtool: line 58: exec: /var/scratch/debian/libvirt/cvs/libvirt/libvirt-0.6.5/_build/gnulib/lib/../../../libtool: cannot execute: No such file or directory make[5]: *** [c-ctype.lo] Error 126 Any ideas? Cheers, -- Guido

2 1

[libvirt] Save and restore with KVM!
by Erkan Unal 07 Jul '09

07 Jul '09

Hi, First of all, I want to ask: is there a libvirt user mailing list? I generally see people exchanging ideas on development of libvirt in this mailing list. So feel free to direct me to the right place if this is not the main mailing list for these kind of questions. I am having problems with save and restore commands in virsh when I try to save and restore KVM virtual machines. After I initiate restore operation, instead of starting where I left during the save operation, it is restarting the VM. Therefore, I need to ask what should I check for these operations to execute correctly? What kind of vm disk types: qcow or vmdk? Which versions of qemu, kvm and libvirt combinations? currently I have libvirt 0.6.5, qemu 0.9.1, kvm-82 on fedora core 8 with kernel version of 2.6.26.8. Thanks, Erkan Unal

2 1

[libvirt] [PATCH] createLinux requires full-access connection
by Dan Kenigsberg 07 Jul '09

07 Jul '09

--- docs/examples/python/domstart.py | 2 +- python/tests/create.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/examples/python/domstart.py b/docs/examples/python/domstart.py index 64434c4..52fb79e 100755 --- a/docs/examples/python/domstart.py +++ b/docs/examples/python/domstart.py @@ -32,7 +32,7 @@ if len(sys.argv) != 2: (name, xmldesc) = read_domain(sys.argv[1]) -conn = libvirt.openReadOnly(None) +conn = libvirt.open(None) if conn == None: print 'Failed to open connection to the hypervisor' sys.exit(1) diff --git a/python/tests/create.py b/python/tests/create.py index 0da89a9..d2c434e 100755 --- a/python/tests/create.py +++ b/python/tests/create.py @@ -52,7 +52,7 @@ else: initrdU = "<initrd>" + initrdU + "</initrd>" -conn = libvirt.openReadOnly(None) +conn = libvirt.open(None) if conn == None: print 'Failed to open connection to the hypervisor' sys.exit(1) -- 1.6.2.5

3 2

[libvirt] [PATCH] Do a correct format mapping of partitions 2
by Henrik Persson 07 Jul '09

07 Jul '09

I make a new try from a different mail client now. /Henrik

4 5

Re: [libvirt] Patch to include arm variants in virsh capabilities
by C.J. Adams-Collier 05 Jul '09

05 Jul '09

> On Wed, Jul 01, 2009 at 11:02:16AM -0700, C.J. Adams-Collier wrote: > > Hey folks, > > > > I got an android and wanted to set up an armel debian vm to test out > > some code. I had to launch it directly with qemu-system-arm, though, > > since virsh didn't have an arm option to select. > > > > This is a patch against the debian version of the source after applying > > debian-specific changes. If you'd like a patch against mainline, I'd be > > willing to do that. > > > > http://karma.colliertech.org/~cjac/tmp/add-arm.patch > > Well, this list is really about upstream patches not distro specific > ones, I just verified that it applies cleanly against CVS. > and I could not access said patch [1]. That is weird. I hope it was just a fluke! Attached. > Send a patch against the > latest version or CVS/git as an mail attachemnt and we will try to add > it. Alrighty. I see that the mips machines are separated into 'mips' and 'mipsel'. I don't know anything about the endian-ness of the various machines (aside from versatilepb, which is little), so I just left them all in the generic qemu_arch_info.arch="arm" table entry. > Daniel Cheers, C.J. > [1] the server seems down I got an HTTP request timeout. hurm... I'm getting hits at least hourly from a site revproxied by the same host ( http://wp.colliertech.org/cj/ ) - perhaps it was a coincidental outage (*shakes fist at comcast*)? > -- > Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ > daniel <at> veillard.com | Rpmfind RPM search engine http://rpmfind.net/ > http://veillard.com/ | virtualization library http://libvirt.org/

3 5

[libvirt] Release of libvirt-0.6.5
by Daniel Veillard 04 Jul '09

04 Jul '09

As scheduled, the new version is available on the server: ftp://libvirt.org/libvirt/ This is mostly a bug fix release, though it includes some serious improvements for storage/NPIV and on the OpenNebula driver: * New features - create storage columes on disk backend (Henrik Persson) - drop of capabilities based on libcap-ng when possible (Daniel Berrange) * Portability - fix build on non-Linux targets (Daniel Berrange) * Documentation - typo and english fixes (Runa Bhattacharjee and Garry Dolley) - Docs on extending APIs (Dave Allan) - cleanup of debug and logging documentation (Amy Griffis) - add HACKING doc to the website (Daniel Berrange) - documentation for OpenNebula driver (Abel Miguez Rodriguez) * Bug fixes - forbid autostart on transcient networks - xen device removal crash (Daniel Berrange) - re-detection of transient VMs after libvirtd restart(Daniel Berrange) - bug in virFindFileInPath (Daniel Berrange) - handle new availheap sysctl in Xen (Daniel Berrange) - allow USB hostdev product 0 (Cole Robinson) - cleanup when creating a storage pool fails (Henrik Persson) - domain id fix on redefinition in test driver (Cole Robinson) - fix raw storage allocation (Cole Robinson) - memory reporting for inactive qemu drivers (Cole Robinson) - segfault if storage pool has no type attribute (Cole Robinson) - OpenNebula compilation issues (Javier Fontan) - dominfo command without security driver (Daniel Berrange) - domain state problems after migration or destroy (Federico Simoncelli) - leak in node device parsing (Dave Allan) - storage pool definitions reading at startup (Cole Robinson) - bogus WWN in NPIV support (David Allan) - avoid a segfault with recent Xen (Sascha) - cope with libnuma failures on weird topologies (Dan Berrange) - crash in QEMU driver with bad capabilities data (Dan Berrange) - trying to re-create a pool should not destroy it (Dave Allan) - endless loop in node device XML dump (Cole Robinson) - Re-label shared and readonly images (Dan Berrange) * Improvements - create and destroy NPIV support (David Allan) - networking in UML driver (Daniel Berrange) - HAL driver restart thread safety (Daniel Berrange) - capabilities and nodeinfo APIs for LXC (Daniel Berrange) - iNUMA API for VBox (Daniel Berrange) - dynamically search and use kvm-img qemu-img or qcow-create (Doug Goldstein) - fix qemu and kvm version parsing (Mark McLoughlin) - serial number for HAL storage (Dave Allan) - improve error reporting for virConnectOpen URIs (Daniel Berrange) - include OS driver name in device XML (Daniel Berrange) - fix qemu command flags fetching (Cole Robinson) - check that qemu support -drive format= (Cole Robinson) - improve emulator detection (Cole Robinson) - changes to config parser to accomodate VMX syntax (Matthias Bolte) - update network schemas and driver for missing elements (Satoru SATOH) - avoid changing file context if not needed (Tim Waugh) - skip labelling if no src path (Cole Robinson) - add arm emulation if qemu-system-arm is present (C.J. Adams-Collier) * Cleanups - daemon check logging env variables (Daniel Berrange) - User Mode Linux start and stop cleanups (Daniel Berrange) - share the NUMA api implementations (Daniel Berrange) - storage module dependancies (Dave Allan) - refactor storage XML parsing (Cole Robinson) - big cleanup of logging code (Amy Griffis) - superfluous % on format (Matthias Bolte) - cleanups and updates on OpenNebula driver (Daniel Berrange and Abel Miguez Rodriguez) thanks everybody for report, patches, documentation, etc ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] gitignore & cscope
by Dave Allan 03 Jul '09

03 Jul '09

Could we add cscope's files to .gitignore? Dave diff --git a/.gitignore b/.gitignore index 1b36694..ca73a98 100644 --- a/.gitignore +++ b/.gitignore @@ -19,6 +19,8 @@ config.status config.sub configure coverage +cscope.files +cscope.out libtool libvirt-*.tar.gz libvirt.pc

4 3

[libvirt] [PATCH 1/2] Re-label shared and readonly images
by Mark McLoughlin 03 Jul '09

03 Jul '09

From: Daniel P. Berrange <berrange(a)redhat.com> This patch was posted ages ago here: https://bugzilla.redhat.com/493692 But was never posted upstream AFAICT. Signed-off-by: Mark McLoughlin <markmc(a)redhat.com> --- src/security_selinux.c | 27 +++++++++++++++++---------- 1 files changed, 17 insertions(+), 10 deletions(-) diff --git a/src/security_selinux.c b/src/security_selinux.c index 4fb7c86..87073d2 100644 --- a/src/security_selinux.c +++ b/src/security_selinux.c @@ -24,11 +24,12 @@ #include "virterror_internal.h" #include "util.h" #include "memory.h" - +#include "logging.h" #define VIR_FROM_THIS VIR_FROM_SECURITY static char default_domain_context[1024]; +static char default_content_context[1024]; static char default_image_context[1024]; #define SECURITY_SELINUX_VOID_DOI "0" #define SECURITY_SELINUX_NAME "selinux" @@ -148,8 +149,13 @@ SELinuxInitialize(virConnectPtr conn) close(fd); ptr = strchrnul(default_image_context, '\n'); - *ptr = '\0'; - + if (*ptr == '\n') { + *ptr = '\0'; + strcpy(default_content_context, ptr+1); + ptr = strchrnul(default_content_context, '\n'); + if (*ptr == '\n') + *ptr = '\0'; + } return 0; } @@ -313,6 +319,8 @@ SELinuxSetFilecon(virConnectPtr conn, const char *path, char *tcon) { char ebuf[1024]; + VIR_INFO("Setting SELinux context on '%s' to '%s'", path, tcon); + if(setfilecon(path, tcon) < 0) { virSecurityReportError(conn, VIR_ERR_ERROR, _("%s: unable to set security context " @@ -337,9 +345,6 @@ SELinuxRestoreSecurityImageLabel(virConnectPtr conn, char *newpath = NULL; const char *path = disk->src; - if (disk->readonly || disk->shared) - return 0; - if ((err = virFileResolveLink(path, &newpath)) < 0) { virReportSystemError(conn, err, _("cannot resolve symlink %s"), path); @@ -366,8 +371,13 @@ SELinuxSetSecurityImageLabel(virConnectPtr conn, { const virSecurityLabelDefPtr secdef = &vm->def->seclabel; - if (secdef->imagelabel) + if (disk->shared) { + return SELinuxSetFilecon(conn, disk->src, default_image_context); + } else if (disk->readonly) { + return SELinuxSetFilecon(conn, disk->src, default_content_context); + } else if (secdef->imagelabel) { return SELinuxSetFilecon(conn, disk->src, secdef->imagelabel); + } return 0; } @@ -441,9 +451,6 @@ SELinuxSetSecurityLabel(virConnectPtr conn, if (secdef->imagelabel) { for (i = 0 ; i < vm->def->ndisks ; i++) { - if (vm->def->disks[i]->readonly || - vm->def->disks[i]->shared) continue; - if (SELinuxSetSecurityImageLabel(conn, vm, vm->def->disks[i]) < 0) return -1; } -- 1.6.2.5

2 5

[libvirt] vTPM support in libvirt
by Andreas Sommer 03 Jul '09

03 Jul '09

I'm wondering if there will be vTPM support in libvirt in the near future?! Xen does support it already with the configuration "vtpm = ['instance=1,backend=0']", for example. So it would be great if the libvirt XML format supported it, too... For example like this: <devices> <vtpm instance="1" backend="xxx" /> </devices> Both attributes are optional. The backend attribute is a VM ID (on Xen, only zero for dom0 is supported) and could be implemented as a UUID?! What do you think? Are there any efforts to introducing that? Cheers Andreas

6 13

[libvirt] [Patch] Fix network driver not to forget to save <domain/> in network XML file
by Satoru SATOH 03 Jul '09

03 Jul '09

It seems that libvirt network driver can understand /network/domain element but it does not save this configuration into the network definition XML file correctly (looks completely forgetting about it). Here is a fix for this problem. (see also: rhbz#505720) --- src/network_conf.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/network_conf.c b/src/network_conf.c index 1e0cbb8..1b50b84 100644 --- a/src/network_conf.c +++ b/src/network_conf.c @@ -592,6 +592,9 @@ char *virNetworkDefFormat(virConnectPtr conn, def->stp ? "on" : "off", def->delay); + if (def->domain) + virBufferVSprintf(&buf, " <domain name='%s'/>\n", def->domain); + if (def->ipAddress || def->netmask) { virBufferAddLit(&buf, " <ip"); -- 1.6.3.2

3 2

[libvirt] [Patch] Network schema fixes and updates
by Satoru SATOH 03 Jul '09

03 Jul '09

This is a patch to make network schema (network.rng) to support some neat features (/netowrk/domain, //dhcp/host/*). --- docs/schemas/network.rng | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng index 34c0163..a4281a5 100644 --- a/docs/schemas/network.rng +++ b/docs/schemas/network.rng @@ -1,6 +1,7 @@  <element name="network" xmlns="http://relaxng.org/ns/structure/1.0" datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes"> + <interleave>  <element name="name"><text/></element> @@ -43,6 +44,11 @@ </element> </optional> <optional> + <element name="domain"> + <attribute name="name"><text/></attribute> + </element> + </optional> + <optional>  <!-- FIXME: address, netmask and the start and end of the ranges @@ -63,7 +69,15 @@ <attribute name="end"><text/></attribute> </element> </zeroOrMore> + <zeroOrMore> + <element name="host"> + <attribute name="mac"><text/></attribute> + <attribute name="name"><text/></attribute> + <attribute name="ip"><text/></attribute> + </element> + </zeroOrMore> </element> </element> </optional> + </interleave> </element> -- 1.6.3.2

3 2

[libvirt] [PATCH 0/1] Fix pool create when pool already exists
by David Allan 02 Jul '09

02 Jul '09

When storagePoolCreate is called to define a pool that already exists, it mistakenly destroys the existing pool. This patch fixes the problem. Dave

5 8

[libvirt] Patch to include arm variants in virsh capabilities
by C.J. Adams-Collier 02 Jul '09

02 Jul '09

Hey folks, I got an android and wanted to set up an armel debian vm to test out some code. I had to launch it directly with qemu-system-arm, though, since virsh didn't have an arm option to select. This is a patch against the debian version of the source after applying debian-specific changes. If you'd like a patch against mainline, I'd be willing to do that. http://karma.colliertech.org/~cjac/tmp/add-arm.patch Cheers, C.J.

2 1

[libvirt] [PATCH] Fix node dumpxml infinite loop
by Cole Robinson 02 Jul '09

02 Jul '09

With current git, doing: 'virsh nodedev-dumpxml computer' locks up the daemon. The list iteration in update_caps was only happening conditionally: if that condition wasn't met, we loop forever. - Cole

3 2

[libvirt] PATCH: Opennebula Documentation updates
by "Abel Míguez Rodríguez" 02 Jul '09

02 Jul '09

Hi, here are some changes to apply at the ONE Documentation, Thanks Abel Miguez Rodriguez ---- Distributed System Architecture Group (http://dsa-research.org) GridWay, http://www.gridway.org OpenNEbula, http://www.opennebula.org

2 1

[libvirt] fix for crash in NPIV code
by Dave Allan 02 Jul '09

02 Jul '09

DV found a place in the NPIV code that was freeing the wrong thing in the error case causing a segfault. The patch to fix it follows. Dave diff --git a/src/node_device.c b/src/node_device.c index cd9f0ef..c5b839b 100644 --- a/src/node_device.c +++ b/src/node_device.c @@ -489,8 +489,8 @@ get_wwns(virConnectPtr conn, if (*wwnn == NULL || *wwpn == NULL) { /* Free the other one, if allocated... */ - VIR_FREE(wwnn); - VIR_FREE(wwpn); + VIR_FREE(*wwnn); + VIR_FREE(*wwpn); ret = -1; virReportOOMError(conn); }

2 1

[libvirt] PATCH : Opennebula documentation
by "Abel Míguez Rodríguez" 02 Jul '09

02 Jul '09

Hi, Attached is the OpenNebula driver documentation and a patch. The main Documentation file is "drvone.html.in" along with it a patch that includes: the API supported by the driver, an entry at "Documentation>Drivers" and a link to the documentation at "drivers.hmtl.in" Thanks --- sitemap.html.in.bak 2009-07-01 12:43:53.000000000 +0200 +++ sitemap.html.in 2009-06-30 18:19:44.000000000 +0200 @@ -148,6 +148,10 @@ <a href="drvvbox.html">VirtualBox</a> Driver for VirtualBox </li> + <li> + <a href="drvone.html">OpenNebula</a> + Driver for OpenNebula + </li> </ul> </li> <li> --- drivers.html.in.bak 2009-07-01 14:54:57.000000000 +0200 +++ drivers.html.in 2009-07-01 14:55:33.000000000 +0200 @@ -23,6 +23,7 @@ <li><a href="drvtest.html">Test</a></li> <li><a href="drvopenvz.html">OpenVZ</a></li> <li><a href="drvvbox.html">VirtualBox</a></li> + <li><a href="drvone.html">OpenNebula</a></li> </ul> </body> </html> --- hvsupport.html.in.bak 2009-07-01 12:41:36.000000000 +0200 +++ hvsupport.html.in 2009-07-01 13:02:38.000000000 +0200 @@ -22,6 +22,7 @@ updated on 2008-06-05. <th><a href="drvkvm.html">KVM</a></th> <th><a href="remote.html">Remote</a></th> <th><a href="drvvbox.html">VirtualBox</a></th> + <th><a href="drvone.html">ONE</a></th> </tr> <tr> <td> virConnectClose </td> @@ -31,6 +32,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectGetCapabilities </td> @@ -40,6 +42,7 @@ updated on 2008-06-05. <td> ≥ 0.2.1 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectGetHostname </td> @@ -49,6 +52,7 @@ updated on 2008-06-05. <td> ≥ 0.3.3 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virConnectGetMaxVcpus </td> @@ -58,6 +62,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virConnectGetType </td> @@ -67,6 +72,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectGetURI </td> @@ -76,6 +82,7 @@ updated on 2008-06-05. <td> ≥ 0.3.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectGetVersion </td> @@ -85,6 +92,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectListDefinedDomains </td> @@ -94,6 +102,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectListDomains </td> @@ -103,6 +112,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectNumOfDefinedDomains </td> @@ -112,6 +122,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectNumOfDomains </td> @@ -121,6 +132,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectOpen </td> @@ -130,6 +142,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectOpenAuth </td> @@ -139,6 +152,7 @@ updated on 2008-06-05. <td> </td> <td> </td> <td> </td> + <td> </td> </tr> <tr> <td> virConnectOpenReadOnly </td> @@ -148,6 +162,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainAttachDevice </td> @@ -157,6 +172,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainBlockPeek </td> @@ -166,6 +182,7 @@ updated on 2008-06-05. <td> 0.4.3 </td> <td> x </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainBlockStats </td> @@ -175,6 +192,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.2 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainCoreDump </td> @@ -184,6 +202,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainCreate </td> @@ -193,6 +212,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainCreateLinux </td> @@ -202,6 +222,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainDefineXML </td> @@ -211,6 +232,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainDestroy </td> @@ -220,6 +242,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainDetachDevice </td> @@ -229,6 +252,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainFree </td> @@ -238,6 +262,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetAutostart </td> @@ -247,11 +272,12 @@ updated on 2008-06-05. <td> ≥ 0.2.1 </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainGetConnect </td> <td> 0.3.0 </td> - <td colspan="5"> not a HV function </td> + <td colspan="6"> not a HV function </td> </tr> <tr> <td> virDomainGetID </td> @@ -261,6 +287,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetInfo </td> @@ -270,6 +297,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetMaxMemory </td> @@ -279,6 +307,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainGetMaxVcpus </td> @@ -288,6 +317,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainGetName </td> @@ -297,6 +327,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetOSType </td> @@ -306,6 +337,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetSchedulerParameters </td> @@ -315,6 +347,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainGetSchedulerType </td> @@ -324,6 +357,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainGetUUID </td> @@ -333,6 +367,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetUUIDString </td> @@ -342,6 +377,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetVcpus </td> @@ -351,6 +387,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainInterfaceStats </td> @@ -360,6 +397,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.2 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainGetXMLDesc </td> @@ -369,6 +407,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainLookupByID </td> @@ -378,6 +417,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainLookupByName </td> @@ -387,6 +427,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainLookupByUUID </td> @@ -396,6 +437,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainLookupByUUIDString </td> @@ -405,6 +447,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainMigrate </td> @@ -414,6 +457,7 @@ updated on 2008-06-05. <td> x </td> <td> 0.3.2 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainPinVcpu </td> @@ -423,6 +467,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainReboot </td> @@ -432,6 +477,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainRestore </td> @@ -441,6 +487,8 @@ updated on 2008-06-05. <td> ≥ 0.3.2 </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> + </tr> <tr> <td> virDomainResume </td> @@ -450,6 +498,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainSave </td> @@ -459,6 +508,7 @@ updated on 2008-06-05. <td> ≥ 0.3.2 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainSetAutostart </td> @@ -468,6 +518,7 @@ updated on 2008-06-05. <td> ≥ 0.2.1 </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainSetMaxMemory </td> @@ -476,6 +527,7 @@ updated on 2008-06-05. <td> x </td> <td> x </td> <td> ≥ 0.3.0 </td> + <td> x </td> </tr> <tr> <td> virDomainSetMemory </td> @@ -485,6 +537,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainSetSchedulerParameters </td> @@ -494,6 +547,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainSetVcpus </td> @@ -503,6 +557,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainShutdown </td> @@ -512,6 +567,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainSuspend </td> @@ -521,6 +577,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainUndefine </td> @@ -530,17 +587,18 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virGetVersion </td> <td> All </td> <td> All </td> - <td colspan="4"> Returns -1 if HV unsupported. </td> + <td colspan="5"> Returns -1 if HV unsupported. </td> </tr> <tr> <td> virInitialize </td> <td> 0.1.0 </td> - <td colspan="5"> not a HV function </td> + <td colspan="6"> not a HV function </td> </tr> <tr> <td> virDomainMemoryPeek </td> @@ -550,6 +608,7 @@ updated on 2008-06-05. <td> 0.4.3 </td> <td> x </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virNodeGetInfo </td> @@ -559,6 +618,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virNodeGetFreeMemory </td> @@ -568,6 +628,7 @@ updated on 2008-06-05. <td> x </td> <td> x </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virNodeGetCellsFreeMemory </td> @@ -577,6 +638,7 @@ updated on 2008-06-05. <td> x </td> <td> x </td> <td> x </td> + <td> x </td> </tr> </table> <h3>Network functions</h3> Abel Miguez Rodriguez ---- Distributed System Architecture Group (http://dsa-research.org) GridWay, http://www.gridway.org OpenNEbula, http://www.opennebula.org

3 2

[libvirt] libvirt 0.6.4: Confusing error message during virDomainRestore() if network not started
by Charles Duffy 02 Jul '09

02 Jul '09

Howdy, 'yall -- I found myself scratching my head for a few minutes trying to start a VM image via virDomainRestore(). Looking through the header definition in the XML, it read as follows: <interface type="network"> <mac address="00:15:3d:49:ec:0e"/> <source network="fvte-MIXED-DEFAULT"/> <target dev="vnet3"/> <model type="e1000"/> </interface> ...and on trying to do a virDomainRestore(), it exited with the following: Traceback (most recent call last): File "/usr/bin/fvte", line 8, in <module> load_entry_point('fvte==1.0', 'console_scripts', 'fvte')() File "/local/home-aux/cduffy/public_git/fvte/src/m1/fvte/cli.py", line 1838, in main cli.cmdloop() File "/opt/python25/lib/python2.5/cmd.py", line 142, in cmdloop stop = self.onecmd(line) File "/local/home-aux/cduffy/public_git/fvte/src/m1/fvte/cli.py", line 1791, in onecmd cmd.Cmd.onecmd(self, c) File "/opt/python25/lib/python2.5/cmd.py", line 219, in onecmd return func(arg) File "/local/home-aux/cduffy/public_git/fvte/src/m1/fvte/cli.py", line 1538, in do_mode self._vmm.vh_set_runmode(name, desired) File "/local/home-aux/cduffy/public_git/fvte/src/m1/fvte/vmmanip.py", line 324, in vh_set_runmode succp = (0 == virt['connect'].restore(ramfile)) File "/opt/python25/lib/python2.5/site-packages/libvirt.py", line 1224, in restore if ret == -1: raise libvirtError ('virDomainRestore() failed', conn=self) libvirt.libvirtError: internal error Failed to add tap interface 'vnet%d' to bridge 'fvtebr0' : No such device The actual issue was that the fvte-MIXED-DEFAULT network was not running, and an appropriate "virsh net-start" allowed the domain to restore correctly; detecting this condition and providing a clearer error message would probably be a Good Thing.

1 0

[libvirt] Patch to include arm variants in virsh capabilities
by C.J. Adams-Collier 02 Jul '09

02 Jul '09

Hey folks, I got an android and wanted to set up an armel debian vm to test out some code. I had to launch it directly with qemu-system-arm, though, since virsh didn't have an arm option to select. This is a patch against the debian version of the source after applying debian-specific changes. If you'd like a patch against mainline, I'd be willing to do that. http://karma.colliertech.org/~cjac/tmp/add-arm.patch Cheers, C.J.

1 0

[libvirt] While connecting through xen+ssh, virConnectClose doesn't close the connection
by Alexandru Nedelcu 01 Jul '09

01 Jul '09

Hi, I'm trying to create a Perl script with Sys::Virt (perl bindings). I'm also using Virsh for testing / experimenting, so this is in no way related to my Perl script (I mentioned it because there might be a sollution that I could use / implement). When connecting to libvirtd using a xen+ssh// connection, it connects, libvirt commands are executing, but on virsh "quit" (or when my script terminates), the connection is blocked. It bothers me because my script doesn't terminate. While running with LIBVIRT_DEBUG=1 I get the following messages: 14:30:51.086: debug : virDomainFree:1893 : domain=0x8791ff8 14:30:51.086: debug : virUnrefDomain:367 : unref domain 0x8791ff8 malcolm 1 14:30:51.086: debug : virReleaseDomain:325 : release domain 0x8791ff8 malcolm 14:30:51.087: debug : virReleaseDomain:337 : unref connection 0x87308a0 3 14:30:51.087: debug : virDomainFree:1893 : domain=0x8791f28 14:30:51.087: debug : virUnrefDomain:367 : unref domain 0x8791f28 Domain-0 1 14:30:51.087: debug : virReleaseDomain:325 : release domain 0x8791f28 Domain-0 14:30:51.087: debug : virReleaseDomain:337 : unref connection 0x87308a0 2 14:30:51.087: debug : virConnectClose:1203 : conn=0x87308a0 14:30:51.087: debug : call:6947 : Doing call 2 (nil) 14:30:51.087: debug : call:7017 : We have the buck 2 0x8796f68 0x8796f68 14:30:51.090: debug : processCallRecvLen:6605 : Got length, now need 28 total (24 more) 14:30:51.090: debug : processCalls:6873 : Giving up the buck 2 0x8796f68 (nil) 14:30:51.090: debug : call:7048 : All done with our call 2 (nil) 0x8796f68 Is this normal? Thanks,

1 0

[libvirt] PATCH : Opennebula, adding xen i686 domain capability and updating some error messages
by "Abel Míguez Rodríguez" 01 Jul '09

01 Jul '09

Hi, this patch uses "OPERATION_INVALID" error instead "OPERATION_FAILED" error where should be used, also adds a missing capability, defining Xen i686 domains. Thanks for the patches, --- one_driver.c.bak 2009-06-30 15:02:28.000000000 +0200 +++ one_driver.c 2009-06-30 15:02:29.000000000 +0200 @@ -505,7 +505,7 @@ static int oneDomainShutdown(virDomainPt ret= 0; goto return_point; } - oneError(dom->conn, dom, VIR_ERR_OPERATION_FAILED, + oneError(dom->conn, dom, VIR_ERR_OPERATION_INVALID, _("Wrong state to perform action")); goto return_point; } @@ -541,7 +541,7 @@ static int oneDomainDestroy(virDomainPtr if(c_oneCancel(vm->pid)) { /* VM not running, delete the instance at ONE DB */ if(c_oneFinalize(vm->pid)){ - oneError(dom->conn, dom, VIR_ERR_OPERATION_FAILED, + oneError(dom->conn, dom, VIR_ERR_OPERATION_INVALID, _("Wrong state to perform action")); goto return_point; } @@ -576,11 +576,11 @@ static int oneDomainSuspend(virDomainPtr ret=0; goto return_point; } - oneError(dom->conn, dom, VIR_ERR_OPERATION_FAILED, + oneError(dom->conn, dom, VIR_ERR_OPERATION_INVALID, _("Wrong state to perform action")); goto return_point; } - oneError(dom->conn,dom,VIR_ERR_OPERATION_FAILED, + oneError(dom->conn,dom,VIR_ERR_OPERATION_INVALID, _("domain is not running")); } else { oneError(dom->conn, dom, VIR_ERR_INVALID_DOMAIN, @@ -609,11 +609,11 @@ static int oneDomainResume(virDomainPtr ret=0; goto return_point; } - oneError(dom->conn, dom, VIR_ERR_OPERATION_FAILED, + oneError(dom->conn, dom, VIR_ERR_OPERATION_INVALID, _("Wrong state to perform action")); goto return_point; } - oneError(dom->conn,dom,VIR_ERR_OPERATION_FAILED, + oneError(dom->conn,dom,VIR_ERR_OPERATION_INVALID, _("domain is not paused ")); } else { oneError(dom->conn, dom, VIR_ERR_INVALID_DOMAIN, --- one_conf.c.bak 2009-06-30 15:01:06.000000000 +0200 +++ one_conf.c 2009-06-30 15:00:58.000000000 +0200 @@ -94,6 +94,27 @@ virCapsPtr oneCapsInit(void) { goto no_memory; } + if ((guest = virCapabilitiesAddGuest(caps, + "xen", + "i686", + 32, + NULL, + NULL, + 0, + NULL)) == NULL) + { + goto no_memory; + } + if (virCapabilitiesAddGuestDomain(guest, + "one", + NULL, + NULL, + 0, + NULL) == NULL) + { + goto no_memory; + } + return caps; Abel Miguez Rodriguez ---- Distributed System Architecture Group (http://dsa-research.org) GridWay, http://www.gridway.org OpenNEbula, http://www.opennebula.org

3 4

[libvirt] [PATCH] logging: remove unused level 0
by Amy Griffis 01 Jul '09

01 Jul '09

Some more logging cleanup. Remove all references to log level 0, and replace with VIR_LOG_DEBUG where appropriate. Also change any hard numbers to the corresponding VirLogPriority and add VIR_LOG_DEFAULT for the starting log level. Signed-off-by: Amy Griffis <amy.griffis(a)hp.com --- docs/logging.html.in | 6 ++---- qemud/libvirtd.conf | 5 ++--- qemud/qemud.c | 11 ++++++----- src/logging.c | 10 +++++----- src/logging.h | 2 ++ 5 files changed, 17 insertions(+), 17 deletions(-) diff --git a/docs/logging.html.in b/docs/logging.html.in index 11ea68c..fcd100f 100644 --- a/docs/logging.html.in +++ b/docs/logging.html.in @@ -49,7 +49,6 @@ <ul> <li>log_level: accepts the following values: <ul> - <li>0: no logging at all</li> <li>4: only errors</li> <li>3: warnings and errors</li> <li>2: informations, warnings and errors</li> @@ -84,20 +83,19 @@ </ul> In all cases the x prefix is the minimal level, acting as a filter: <ul> - <li>0: everything</li> <li>1: DEBUG</li> <li>2: INFO</li> <li>3: WARNING</li> <li>4: ERROR</li> </ul> Multiple output can be defined , they just need to be separated by - spaces, e.g.: <code>"3:syslog:libvirtd 0:file:/tmp/libvirt.log"</code> + spaces, e.g.: <code>"3:syslog:libvirtd 1:file:/tmp/libvirt.log"</code> will log all warnings and errors to syslog under the libvirtd ident but also log everything debugging and informations included in the file <code>/tmp/libvirt.log</code> For example setting up the following: <pre>export LIBVIRT_DEBUG=1 -export LIBVIRT_LOG_OUTPUTS="0:file:virsh.log"</pre> +export LIBVIRT_LOG_OUTPUTS="1:file:virsh.log"</pre> and then running virsh will accumulate the logs in the <code>virsh.log</code> file in a way similar to: <pre>14:29:04.771: debug : virInitialize:278 : register drivers diff --git a/qemud/libvirtd.conf b/qemud/libvirtd.conf index 1fd5918..49de466 100644 --- a/qemud/libvirtd.conf +++ b/qemud/libvirtd.conf @@ -269,7 +269,7 @@ # Logging controls # -# Logging level: 0 none, 4 errors, 3 warnings, 2 informations, 1 debug +# Logging level: 4 errors, 3 warnings, 2 informations, 1 debug # basically 1 will log everything possible #log_level = 3 @@ -303,13 +303,12 @@ # x:file:file_path # output to a file, with the given filepath # In all case the x prefix is the minimal level, acting as a filter -# 0: everything # 1: DEBUG # 2: INFO # 3: WARNING # 4: ERROR # -# Multiple output can be defined , they just need to be separated by spaces. +# Multiple output can be defined, they just need to be separated by spaces. # e.g.: # log_outputs="3:syslog:libvirtd" # to log all warnings and errors to syslog under the libvirtd ident diff --git a/qemud/qemud.c b/qemud/qemud.c index b5e3665..da20aa9 100644 --- a/qemud/qemud.c +++ b/qemud/qemud.c @@ -128,7 +128,7 @@ static int sigwrite = -1; /* Signal handler pipe */ static int ipsock = 0; /* -l Listen for TCP/IP */ /* Defaults for logging */ -static int log_level = 3; +static int log_level = VIR_LOG_DEFAULT; static char *log_filters = NULL; static char *log_outputs = NULL; @@ -2499,15 +2499,16 @@ qemudSetLogging(virConfPtr conf, const char *filename) { log_outputs = strdup(debugEnv); } if (!log_outputs) { + char *tmp = NULL; if (godaemon) { - char *tmp = NULL; if (virAsprintf (&tmp, "%d:syslog:libvirtd", log_level) < 0) goto free_and_fail; - virLogParseOutputs (tmp); - VIR_FREE (tmp); } else { - virLogParseOutputs("0:stderr:libvirtd"); + if (virAsprintf(&tmp, "%d:stderr", log_level) < 0) + goto free_and_fail; } + virLogParseOutputs(tmp); + VIR_FREE(tmp); } else { virLogParseOutputs(log_outputs); } diff --git a/src/logging.c b/src/logging.c index fd1d5d4..d13ae0f 100644 --- a/src/logging.c +++ b/src/logging.c @@ -119,7 +119,7 @@ static int virLogNbOutputs = 0; /* * Default priorities */ -static virLogPriority virLogDefaultPriority = VIR_LOG_WARN; +static virLogPriority virLogDefaultPriority = VIR_LOG_DEFAULT; static int virLogResetFilters(void); static int virLogResetOutputs(void); @@ -174,7 +174,7 @@ int virLogStartup(void) { virLogLen = 0; virLogStart = 0; virLogEnd = 0; - virLogDefaultPriority = VIR_LOG_WARN; + virLogDefaultPriority = VIR_LOG_DEFAULT; virLogUnlock(); return(0); } @@ -196,7 +196,7 @@ int virLogReset(void) { virLogLen = 0; virLogStart = 0; virLogEnd = 0; - virLogDefaultPriority = VIR_LOG_WARN; + virLogDefaultPriority = VIR_LOG_DEFAULT; virLogUnlock(); return(0); } @@ -689,7 +689,7 @@ int virLogParseOutputs(const char *outputs) { virSkipSpaces(&cur); while (*cur != 0) { prio= virParseNumber(&cur); - if ((prio < 0) || (prio > 4)) + if ((prio < VIR_LOG_DEBUG) || (prio > VIR_LOG_ERROR)) return(-1); if (*cur != ':') return(-1); @@ -770,7 +770,7 @@ int virLogParseFilters(const char *filters) { virSkipSpaces(&cur); while (*cur != 0) { prio= virParseNumber(&cur); - if ((prio < 0) || (prio > 4)) + if ((prio < VIR_LOG_DEBUG) || (prio > VIR_LOG_ERROR)) return(-1); if (*cur != ':') return(-1); diff --git a/src/logging.h b/src/logging.h index d99bb31..0b9ae79 100644 --- a/src/logging.h +++ b/src/logging.h @@ -77,6 +77,8 @@ typedef enum { VIR_LOG_ERROR, } virLogPriority; +#define VIR_LOG_DEFAULT VIR_LOG_WARN + /** * virLogOutputFunc: * @category: the category for the message

3 3

[libvirt] Upcoming 0.6.5 release and switching the main SCM engine (to git)
by Daniel Veillard 01 Jul '09

01 Jul '09

A couple of things I wanted to raise. - First we have a release 0.6.5 at the end of the week, so we are in bug fix mode, it would be good if people could make a round of testing of the latest CVS/git version or the snapshot at ftp://libvirt.org/libvirt/libvirt-cvs-snapshot.tar.gz The snapshot generation was proken in the previous months but I fixed it today. - Another point is that we use CVS as the SCM, that's historical, that's what I was used to when I created the project but clearly most people now use the git mirror (or mercurial) to generate their patches. I tried to assert how much git was prevalent, at least for patches embedded within the mail content a large majority are git generated: paphio:~/Mail -> tail -100000 libvir | grep "^diff" | wc -l 268 paphio:~/Mail -> tail -100000 libvir | grep "^diff" | grep -- '-git' | wc -l 182 that doesn't account mails which are attached and base64 encoded but I think it's reasonnable to conclude most of people sending patches generated them out of a git tree. CVS certainly show its age, too ! So my plan would be to switch out of CVS and make git the primary SCM, Jim Meyering is already maintaining the current git tree, so the plan would be to create a new main git tree on libvirt.org based on the existing git://git.et.redhat.com/libvirt.git tree, maybe fixing a couple of things in the process, and desactivate the CVS server after a couple of week grace period. I think once the decision is taken it's better to do it earlier than late, and I'm thinking that this could be done earlier next week if Jim schedule allows and there is no objection. That would allow to manage the set of patches for the following release only under git and not need an SCM transition in the course of preparing 0.6.6 (or 0.7.0). - Speaking of the following release, I'm shooting for a slightly smaller development cycle, in order to be able to push the next version in time for Fedora 12 Beta, this means a new release at the end of July, so only a bit more than a couple of weeks for pushing the changes, I really hope we will be able to include a first version of the ESX driver and Power Hyprvisor, if it's the case I think it will be worth bumping the release name to 0.7.0 . Feedback and opinions welcome, I hope git is not too uncontroversial :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

2 1

[libvirt] feature or bug?
by Gene Czarcinski 01 Jul '09

01 Jul '09

Yet another question. I am using the virt-manager GUI. When I begin to define a new guest and attempt to "browse" to specify where the iso image file is, the GUI dialog brings me up in my home directory. But, almost everything associated with libvirt is done as the root user. By default, why isn't the initial directory "/var/lib/libvirt/images"? Gene

2 1

[libvirt] your patence is appreciated
by Gene Czarcinski 01 Jul '09

01 Jul '09

I really hate being a bit of a PITA with all of my question/comments, but I am just trying to use Fedora virtualization in a manner where I can reasonably manage the configuration. I suspect I am not the first ex-VMware user and I will not be the last such user who is trying to use Fedora virtualization in place of VMware. I am very familiar with how guests are "managed" with VMware. I want Fedora (and Linux) virtualization to be a good product. Your patience is appreciated! Gene

2 1

[libvirt] need some help/asdive
by Gene Czarcinski 30 Jun '09

30 Jun '09

Background: I am a newbie to Linux Virtualization. However, I have been using Linux for a long time. After a short time with Slackware, I started with Red Hat Linux 2 and went on to 2.1, 3.0.3, 4, 4.2, 5, 5.2, ..., 8, 9. And then on to Fedora Core 1, 2, ... until I installed Fedora 11 about a month ago. I have also run VMware starting when it first appeared. Initially I used VMware to run Windows. These days I use it to run up to from 25 to 30 guests (between 1 and 5 at the same time) [yes, I have lots of system memory]. Besides a couple of Windows guests, I have some guests supporting both 32 bit (i386) and 64 bit (x86_64) architectures of older releases as well as alternatives such as CentOS -- I use these to build RPMs. Then there are the guests supporting other operating systems such as Solaris and *BSD. Finally, I have a set of test guest that I use for testing stuff which could destroy the operating system or which require a lot of re-booting. All of this in 25 to 30 guests. With Fedora 11, I started by trying VMware-server. Server 1.0.9 (which I used on Fedora 9) looks like much more work to get running ... more or less "a bridge too far". So, I tried server 2.0.2 ... but the client interface changed from a separate GUI application to a browser based interface: 1) this impacts my usage of the firefox browser; 2) it is a buggy implementation; and 3) it is a crappy interface which I do not like. So, I (finally) noticed that Linux in general and Fedora specifically has packages supporting running guests virtually ... so, lets change my "problem sets" and give this a try ... especially when I noticed that it could use the hardware support in my new AMD Phenom II 940 processor. Before getting into my specific questions/problem, let me describe how my systems are set up. First of all, I have a basic rule: "don't screw with a working system." Therefore, on each of my systems I have at least two root partitions defined -- one for the current (working) system and one for the next (new) system [these days it is actually a /boot partition with root being on a striped logical volume]. I also have a small (think minimal install) partition with Fedora to serve as a boot selector (using chainloader), as something to to define striped logical volumes, and to be there for "emergency" maintenance. Guys, this works for me and always doing fresh installs saves on other headaches. Implicit in the above is that I put all of my data and my /home into separate partitions or logical volumes. One of these are my VMware guest systems. Now VMware puts all of the files (configuration, disk image, etc.) associated a guest under a separate directory. Fedora virtualization does not do this and separation is something I need so that I can easily move to a new version of the operating system such as when Fedora 12 becomes available in November. Questions/problems: My first question: it appears to me that a guest is defined by two things -- a configuration file in /etc/libvirt/qemu and one or more disk images in /var/lib/libvirt/images ... is this it or are there other files I need to consider? My second question concerns the location of the disk images: what is the "best practical way" to move these out of the root partition? I have come up with these different approaches which could/may work: 1. change the "path" value in /etc/libvirt/storage/default.xml to point to a directory in a different partition. 2. Use a /etc/fstab entry to "bind mount" a directory in a separate partition onto /var/lib/libvirt/images 3. Just use an /etc/fstab entry to mount a partition on /var/lib/libvirt/images or, perhaps, on /var/lib/libvirt. [This could be done during system installation] OK, any comments on these?? I can live with changing some configuration files, I can live with copying guest configuration files between systems, I CANNOT live with the disk image files being put into the root partition. Before jumping "whole hog" into using Fedora Virtualization in place of VMware, I need to be able to live with the result. Figure 30 guest virtuals with 10GB of virtual disk each, that is 300GB. I have that space but not for every root partition on my system! Comment: It sure would be nice if Fedora Virtualization put all files related to a guest under a single directory the way VMware does. Comment: It sure would be nice if there was some system-wide configuration parameter that defined where virtualization files went. Right now, as a newbie, I am using the virt-manage GUI interface. I am studying the command-line programs to see what they offer me. So far, I like what I see in Fedora Virtualization but I need to address how things will be practically managed sooner rather than later. Any help appreciated. Gene

2 4

[libvirt] PATCH: Remove unused Open Nebula code, fix potential missing NULL terminator
by Daniel P. Berrange 30 Jun '09

30 Jun '09

This patch removes a bunch of unused Open Nebula code which has a number of flaws. It also fixes handling of a strncpy() call to ensure there is a NULL terminator in the copied string. And finally it makes a couple of strings be 'const' since they're never changed Daniel Index: src/opennebula/one_client.c =================================================================== RCS file: /data/cvs/libvirt/src/opennebula/one_client.c,v retrieving revision 1.1 diff -u -p -r1.1 one_client.c --- src/opennebula/one_client.c 24 Jun 2009 17:32:56 -0000 1.1 +++ src/opennebula/one_client.c 30 Jun 2009 11:05:12 -0000 @@ -33,16 +33,9 @@ void c_oneStart() xmlrpc_client_init2(&one_client.env, XMLRPC_CLIENT_NO_FLAGS, "OpenNebula API Client", "1.2", NULL, 0); - one_client.error=0; - -#ifdef ONED_PORT - one_client.url=(char *)malloc(64); - snprintf(one_client.url, 63, "http://localhost:%d/RPC2", ONED_PORT); -#else - one_client.url=(char *)"http://localhost:2633/RPC2"; -#endif - - one_client.session=(char *)"one-session"; + one_client.error = 0; + one_client.url = "http://localhost:2633/RPC2"; + one_client.session = "one-session"; }; @@ -94,35 +87,6 @@ int c_oneMigrate(int vmid, int hid, int return c_oneReturnCode(resultP); } -int c_oneAllocate(char* template_file) -{ - int file; - int size; - int bytes_read; - char *file_text; - int return_code; - - file=open(template_file, O_RDONLY); - size=lseek(file, 0, SEEK_END); - lseek(file, 0, SEEK_SET); - - file_text=(char *)malloc(size+1); - bytes_read=read(file, file_text, size); - close(file); - - if(bytes_read==size) { - file_text[size]=0; - - return_code=c_oneAllocateTemplate(file_text); - free(file_text); - - return return_code; - } else { - free(file_text); - return -1; - } -} - int c_oneAllocateTemplate(char* vm_template) { xmlrpc_value *resultP; @@ -222,6 +186,7 @@ int c_oneVmInfo(int vmid, char* ret_info if( return_code ) { strncpy(ret_info, return_string, length-1); + ret_info[length-1] = '\0'; xmlrpc_DECREF(resultP); free(return_string); @@ -241,9 +206,6 @@ void c_oneFree() { xmlrpc_env_clean(&one_client.env); xmlrpc_client_cleanup(); -#ifdef ONE_PORT - free(one_client.url); -#endif } Index: src/opennebula/one_client.h =================================================================== RCS file: /data/cvs/libvirt/src/opennebula/one_client.h,v retrieving revision 1.1 diff -u -p -r1.1 one_client.h --- src/opennebula/one_client.h 24 Jun 2009 17:32:56 -0000 1.1 +++ src/opennebula/one_client.h 30 Jun 2009 11:05:12 -0000 @@ -24,8 +24,8 @@ struct _oneClient { xmlrpc_env env; - char *url; - char *session; + const char *url; + const char *session; char *error; }; @@ -38,8 +38,6 @@ int c_oneDeploy(int vmid, int hid); int c_oneMigrate(int vmid, int hid, int flag); -int c_oneAllocate(char* template_file); - int c_oneAllocateTemplate(char* vm_template); int c_oneAction(int vmid,char* action); -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1

[libvirt] problem: deleting a guest
by Gene Czarcinski 30 Jun '09

30 Jun '09

I defined a new guest using the virt-manager GUI ... everything fine so far. I then decided that my definition was not correct (or I could be done with that guest) and could not find a way to delete the guest. OK, quit virt-manager, delete the configuration and disk-image files for the guest, restart libvirtd, and then start virt-manager again. The guest definition (according to virt-manager) was still there. I finnaly got rid of the definition by re-booting the system. THIS IS NOT SATISFACTORY! IMHO, I should be able to: 1. Define a new guest. 2. Delete the definition of a new guest but not the related configuration and disk-image files. 3. Delete the guest definition and the related configuration and disk image files but NOT and CD/DVD image files external to /var/lib/libvirt/images. 4. Import new guests which were created as clones, copied from another host, or convert created from something like VMware. Not it is certainly possible (or even likely) that I h\just do not understand how to do things yet. Or, this could be a bug. Or, this could be a lack of capabilities. Help appreciated in pointing me in the right direction. I will bugzilla where appropriate. Gene

3 3

[libvirt] How does libvirt 0.6.3 load kvm driver
by Jason Wong 30 Jun '09

30 Jun '09

Dear all, I found that libvirt 0.6.3 seems does not load KVM driver while libvirt 0.3.3 does. Situation description: I am using CentOS 5.3, and the kernel I used is 2.6.30. I downloaded the kernel from kernel.org andcompile it. KVM was compiled as a module. libvirt: libvirt 0.6.3, released by Eucalyptus(a cloud computing infrastructure software which supports KVM as well) (1) libvirt 0.6.3 does not load KVM driver After booting the machine with kernel 2.6.30 and probe KVM related module. I started libvirtd 0.6.3 and set LD_LIBRARY_PATH to "$LIBVIRT_063_HOME/lib:$LIBVIRT_063_HOME/usr/lib:$LD_LIBRARY_PATH". I found that I am not able to connect to libvirtd using "virsh --connect qemu:///system"(the virsh used is virsh 0.6.3 that shipped with libvirt 0.6.3), here is the debug message: ======================================= debug message ========================================= 17:41:11.219: debug : virInitialize:290 : register drivers 17:41:11.219: debug : virRegisterDriver:667 : registering Test as driver 0 17:41:11.219: debug : virRegisterNetworkDriver:567 : registering Test as network driver 0 17:41:11.219: debug : virRegisterStorageDriver:598 : registering Test as storage driver 0 17:41:11.219: debug : virRegisterDeviceMonitor:629 : registering Test as device driver 0 17:41:11.219: debug : virRegisterDriver:667 : registering Xen as driver 1 17:41:11.219: debug : vboxRegister:68 : VBoxCGlueInit failed: 0.0.0, errorval=-1 17:41:11.219: debug : virRegisterDriver:667 : registering VBOX as driver 2 17:41:11.219: debug : virConnectOpen:1050 : name=qemu:///system 17:41:11.219: debug : do_open:920 : name "qemu:///system" to URI components: scheme qemu opaque (null) authority (null) server (null) user (null) port 0 path /system 17:41:11.219: debug : do_open:930 : trying driver 0 (Test) ... 17:41:11.219: debug : do_open:936 : driver 0 Test returned DECLINED 17:41:11.219: debug : do_open:930 : trying driver 1 (Xen) ... 17:41:11.219: debug : do_open:936 : driver 1 Xen returned DECLINED 17:41:11.219: debug : do_open:930 : trying driver 2 (VBOX) ... 17:41:11.219: debug : do_open:936 : driver 2 VBOX returned DECLINED libvir: error : could not connect to qemu:///system 17:41:11.219: debug : virUnrefConnect:210 : unref connection 0x60dd00 1 17:41:11.219: debug : virReleaseConnect:171 : release connection 0x60dd00 libvirt error: could not connect to qemu:///system (code=5) error: failed to connect to hypervisor ================================end of debug message ========================================= It seems that libvirt 0.6.3 does not load QEMU driver. (2) libvirt 0.3.3 does load KVM driver However, when I run the command "lsmod | grep kvm". I found KVM module was present: ================================= result of lsmod ============================================== [root@node2 ~]# lsmod | grep kvm kvm_intel 46664 0 kvm 166224 1 kvm_intel [root@node2 ~]# ================================= end of result of lsmod ========================================= I stopped libvirtd 0.6.3 and then started libvirtd 0.3.3(the one shipped with CentOS 5.3). The virtual machine manager works well and I can use "virsh --connect qemu:///system"(the virsh used is virsh 0.3.3 that shipped with CentOS 5.3) to connect to libvirtd. I dig into libvirt source code. I found that in libvirt 0.3.3: There is qemudRegister() in libvirt.c. I think this function call is responsible for loading qemu(kvm) driver. And in libvirt 0.6.3: I cannot found qemudRegister() or virDriverLoadModule("qemu") in the source code. My question is: Does libvirt 0.6.3 support KVM? If yes, how does it load KVM driver? I want to find out why libvirt 0.3.3 works well while libvirt 0.6.3 does not work in my computer. Thanks. -- Jason Wong System engineer Cluster Technology Limited Email: hcwong(a)clustertech.com Direct Line: (852) 2655-6129 Tel: (852) 2655-6100 Fax: (852) 2994-2101 Website: www.clustertech.com ------------------------------ ************************************************************************** The information and attachment contained in this e-mail originating from Cluster Technology Limited is confidential and intended solely for the specified addressees. If you have received this email in error, please do not read, copy, distribute, disclose or use any information of this email in any way and please immediately notify the sender and delete this email. Thank you for your cooperation. **************************************************************************

2 4

[libvirt] hooking a physical nic to a bridge with net-create
by Shahar Klein 30 Jun '09

30 Jun '09

Hi I trying to set up a network configuration using libvirt The setup is: 1. a VM using virtio using a tap device connected to a bridge device 2. on the host side eth0 added to the same bridge device(without ip) using libvirt application (say virsh) I want to launch this set up: virsh net-create for the second part virsh create for the first part(tap, virtio, vm etc) I can set the first part(vm, tap, virtio) using the domain xml but I'm also interested in XMLing the second part and net-create it. I tried but only suceeded in creating the bridge Is it possible? am I missing somthing? Thanks in advance

4 7