- Devel - libvirt List Archives

[libvirt PATCH] qemu: adjust memlock for multiple vfio/vdpa devices
by Jonathon Jongsma 22 Aug '22

22 Aug '22

When multiple VFIO or VDPA devices are assigned to a guest, the guest can fail to start because the guest fails to map enough memory. For example, the case mentioned in https://bugzilla.redhat.com/show_bug.cgi?id=1994893 results in this failure: 2021-08-05T09:51:47.692578Z qemu-kvm: failed to write, fd=24, errno=14 (Bad address) 2021-08-05T09:51:47.692590Z qemu-kvm: vhost vdpa map fail! 2021-08-05T09:51:47.692594Z qemu-kvm: vhost-vdpa: DMA mapping failed, unable to continue The current memlock limit calculation does not work for scenarios where there are multiple such devices assigned to a guest. The root causes are a little bit different between VFIO and VDPA devices. For VFIO devices, the issue only occurs when a vIOMMU is present. In this scenario, each vfio device is assigned a separate AddressSpace fully mapping guest RAM. When there is no vIOMMU, the devices are all within the same AddressSpace so no additional memory limit is needed. For VDPA devices, each device requires the full memory to be mapped regardless of whether there is a vIOMMU or not. In order to enable these scenarios, we need to multiply memlock limit by the number of VDPA devices plus the number of VFIO devices for guests with a vIOMMU. This has the potential for pushing the memlock limit above the host physical memory and negating any protection that these locked memory limits are providing, but there is no other short-term solution. In the future, there should be have a revised userspace iommu interface (iommufd) that the VFIO and VDPA backends can make use of. This will be able to share locked memory limits between both vfio and vdpa use cases and address spaces and then we can disable these short term hacks. But this is still in development upstream. Signed-off-by: Jonathon Jongsma <jjongsma(a)redhat.com> --- src/qemu/qemu_domain.c | 56 ++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 54 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 45f00e162d..a1e91ef48f 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -9233,6 +9233,40 @@ getPPC64MemLockLimitBytes(virDomainDef *def, } +static int +qemuDomainGetNumVFIODevices(const virDomainDef *def) +{ + int i; + int n = 0; + + for (i = 0; i < def->nhostdevs; i++) { + if (virHostdevIsVFIODevice(def->hostdevs[i]) || + virHostdevIsMdevDevice(def->hostdevs[i])) + n++; + } + for (i = 0; i < def->ndisks; i++) { + if (virStorageSourceChainHasNVMe(def->disks[i]->src)) + n++; + } + return n; +} + + +static int +qemuDomainGetNumVDPANetDevices(const virDomainDef *def) +{ + int i; + int n = 0; + + for (i = 0; i < def->nnets; i++) { + if (virDomainNetGetActualType(def->nets[i]) == VIR_DOMAIN_NET_TYPE_VDPA) + n++; + } + + return n; +} + + /** * qemuDomainGetMemLockLimitBytes: * @def: domain definition @@ -9252,6 +9286,8 @@ qemuDomainGetMemLockLimitBytes(virDomainDef *def, bool forceVFIO) { unsigned long long memKB = 0; + int nvfio; + int nvdpa; /* prefer the hard limit */ if (virMemoryLimitIsSet(def->mem.hard_limit)) { @@ -9270,6 +9306,8 @@ qemuDomainGetMemLockLimitBytes(virDomainDef *def, if (ARCH_IS_PPC64(def->os.arch) && def->virtType == VIR_DOMAIN_VIRT_KVM) return getPPC64MemLockLimitBytes(def, forceVFIO); + nvfio = qemuDomainGetNumVFIODevices(def); + nvdpa = qemuDomainGetNumVDPANetDevices(def); /* For device passthrough using VFIO the guest memory and MMIO memory * regions need to be locked persistent in order to allow DMA. * @@ -9288,8 +9326,22 @@ qemuDomainGetMemLockLimitBytes(virDomainDef *def, * * Note that this may not be valid for all platforms. */ - if (forceVFIO || qemuDomainNeedsVFIO(def) || virDomainDefHasVDPANet(def)) - memKB = virDomainDefGetMemoryTotal(def) + 1024 * 1024; + if (forceVFIO || nvfio || nvdpa) { + /* At present, the full memory needs to be locked for each VFIO / VDPA + * device. For VFIO devices, this only applies when there is a vIOMMU + * present. Yes, this may result in a memory limit that is greater than + * the host physical memory, which is not ideal. The long-term solution + * is a new userspace iommu interface (iommufd) which should eliminate + * this duplicate memory accounting. But for now this is the only way + * to enable configurations with e.g. multiple vdpa devices. + */ + int factor = nvdpa; + + if (def->iommu) + factor += nvfio; + + memKB = MAX(factor, 1) * virDomainDefGetMemoryTotal(def) + 1024 * 1024; + } return memKB << 10; } -- 2.37.1

2 1

[libvirt PATCH] libxl: Fix build with recent Xen that introduces new disk backend type
by Oleksandr Tyshchenko 22 Aug '22

22 Aug '22

From: Oleksandr Tyshchenko <oleksandr_tyshchenko(a)epam.com> Xen toolstack has gained basic Virtio support recently which becides adding various virtio related stuff introduces new disk backend type LIBXL_DISK_BACKEND_STANDALONE [1]. Unfortunately, this caused a regression in libvirt build with Xen support enabled, reported by the osstest today [2]: CC libxl/libvirt_driver_libxl_impl_la-xen_xl.lo ../../src/libxl/xen_xl.c: In function 'xenParseXLDisk': ../../src/libxl/xen_xl.c:779:17: error: enumeration value 'LIBXL_DISK_BACKEND_STANDALONE' not handled in switch [-Werror=switch-enum] switch (libxldisk->backend) { ^~~~~~ cc1: all warnings being treated as errors The interesting fact is that switch already has a default branch (which ought to cover such new addition), but the error is triggered as -Wswitch-enum gives a warning about an omitted enumeration code even if there is a default label. Also there is a similar issue in libxlUpdateDiskDef() which I have reproduced after fixing the first one, but it that case the corresponding switch doesn't have a default branch. Fix both issues by inserting required enumeration item to make the compiler happy and adding ifdef guard to be able to build against old Xen libraries as well (without LIBXL_HAVE_DEVICE_DISK_SPECIFICATION). Also add a default branch to switch in libxlUpdateDiskDef(). Please note, that current patch doesn't implement the proper handling of LIBXL_DISK_BACKEND_STANDALONE and friends, it is just intended to fix the regression immediately to unblock the osstest. Also it worth mentioning that current patch won't solve the possible additions in the future. [1] https://lore.kernel.org/xen-devel/20220716163745.28712-1-olekstysh@gmail.co… [2] https://lore.kernel.org/xen-devel/E1oHEQO-0008GA-Uo@osstest.test-lab.xenpro… Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko(a)epam.com> --- Cc: Julien Grall <julien(a)xen.org> Cc: Anthony PERARD <anthony.perard(a)citrix.com> Cc: Michal Privoznik <mprivozn(a)redhat.com> Please note, the patch is tested on: https://xenbits.xen.org/gitweb/?p=libvirt.git;a=shortlog;h=refs/heads/xen-t… but should work on the master as well (as the same code is present here). --- src/libxl/libxl_conf.c | 4 ++++ src/libxl/xen_xl.c | 3 +++ 2 files changed, 7 insertions(+) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index aa3d7925ec..526f0b2b08 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -1240,6 +1240,10 @@ libxlUpdateDiskDef(virDomainDiskDef *l_disk, libxl_device_disk *x_disk) driver = "phy"; break; case LIBXL_DISK_BACKEND_UNKNOWN: +#ifdef LIBXL_HAVE_DEVICE_DISK_SPECIFICATION + case LIBXL_DISK_BACKEND_STANDALONE: +#endif + default: break; } if (driver) diff --git a/src/libxl/xen_xl.c b/src/libxl/xen_xl.c index 4de4e3140f..6919325623 100644 --- a/src/libxl/xen_xl.c +++ b/src/libxl/xen_xl.c @@ -715,6 +715,9 @@ xenParseXLDisk(virConf *conf, virDomainDef *def) virDomainDiskSetDriver(disk, "phy"); virDomainDiskSetType(disk, VIR_STORAGE_TYPE_BLOCK); break; +#ifdef LIBXL_HAVE_DEVICE_DISK_SPECIFICATION + case LIBXL_DISK_BACKEND_STANDALONE: +#endif default: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("disk backend not supported: %s"), -- 2.25.1

7 12

[libvirt PATCH 00/16] various network driver cleanups
by Laine Stump 22 Aug '22

22 Aug '22

These all bubbled to the top of a series that adds support for an nftables backend to the network driver, but are valid patches by themselves, so I'm sending them separately to make the other series look shorter. Laine Stump (16): conf: replace explicit virNetworkDefFree() with g_autoptr(virNetworkDef) esx: replace explicit virNetworkDefFree() with g_autoptr(virNetworkDef) network: replace explicit virNetworkDefFree() with g_autoptr(virNetworkDef) qemu: replace explicit virNetworkDefFree() with g_autoptr(virNetworkDef) test driver: replace explicit virNetworkDefFree() with g_autoptr(virNetworkDef) vbox: replace explicit virNetworkDefFree() with g_autoptr(virNetworkDef) tests: replace explicit virNetworkDefFree() with g_autoptr(virNetworkDef) conf: remove superfluous cleanup: labels and ret return variables qemu: remove superfluous cleanup: labels and ret return variables tests: remove superfluous cleanup: labels and ret return variables network: move driver state struct into bridge_driver_conf.h network: create separate config object for virNetworkDriverState util: replace g_snprintf with g_autofreed g_strdup_printf in viriptables.c util: remove unused function virFirewallApplyRuleFirewallD() util: make virFirewallRuleToString() global util: don't use virFirewallRuleToString() to log the rule being applied po/POTFILES | 1 + src/conf/domain_conf.c | 26 +-- src/conf/virnetworkobj.c | 72 ++++----- src/esx/esx_network_driver.c | 6 +- src/libvirt_private.syms | 1 + src/network/bridge_driver.c | 233 ++++++++++++--------------- src/network/bridge_driver_conf.c | 165 +++++++++++++++++++ src/network/bridge_driver_conf.h | 82 ++++++++++ src/network/bridge_driver_platform.h | 43 +---- src/network/meson.build | 1 + src/qemu/qemu_process.c | 24 ++- src/test/test_driver.c | 6 +- src/util/virfirewall.c | 28 ++-- src/util/virfirewall.h | 3 + src/util/viriptables.c | 15 +- src/vbox/vbox_network.c | 6 +- tests/networkxml2firewalltest.c | 15 +- tests/networkxml2xmltest.c | 3 +- tests/networkxml2xmlupdatetest.c | 8 +- 19 files changed, 443 insertions(+), 295 deletions(-) create mode 100644 src/network/bridge_driver_conf.c create mode 100644 src/network/bridge_driver_conf.h -- 2.37.1

2 17

[libvirt PATCH 0/6] qemu: retire three more capabilities
by Ján Tomko 22 Aug '22

22 Aug '22

Ján Tomko (6): qemu: always assume QEMU_CAPS_DUMP_GUEST_MEMORY qemu: retire QEMU_CAPS_DUMP_GUEST_MEMORY qemu: always assume QEMU_CAPS_*_HOLE64_SIZE qemu: Retire QEMU_CAPS_I440FX_PCI_HOLE64_SIZE qemu: retire QEMU_CAPS_Q35_PCI_HOLE64_SIZE qemu: do not probe for -pcihost properties src/qemu/qemu_capabilities.c | 21 +- src/qemu/qemu_capabilities.h | 6 +- src/qemu/qemu_driver.c | 6 - src/qemu/qemu_validate.c | 14 - .../caps_4.2.0.aarch64.replies | 140 ++++---- .../caps_4.2.0.aarch64.xml | 1 - .../caps_4.2.0.ppc64.replies | 128 +++----- .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 - .../caps_4.2.0.s390x.replies | 114 +++---- .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 - .../caps_4.2.0.x86_64.replies | 264 ++++----------- .../caps_4.2.0.x86_64.xml | 3 - .../caps_5.0.0.aarch64.replies | 144 ++++----- .../caps_5.0.0.aarch64.xml | 1 - .../caps_5.0.0.ppc64.replies | 140 ++++---- .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 - .../caps_5.0.0.riscv64.replies | 128 +++----- .../caps_5.0.0.riscv64.xml | 1 - .../caps_5.0.0.x86_64.replies | 277 ++++------------ .../caps_5.0.0.x86_64.xml | 3 - .../caps_5.1.0.sparc.replies | 86 ++--- .../qemucapabilitiesdata/caps_5.1.0.sparc.xml | 1 - .../caps_5.1.0.x86_64.replies | 291 ++++------------- .../caps_5.1.0.x86_64.xml | 3 - .../caps_5.2.0.aarch64.replies | 148 ++++----- .../caps_5.2.0.aarch64.xml | 1 - .../caps_5.2.0.ppc64.replies | 140 ++++---- .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 1 - .../caps_5.2.0.riscv64.replies | 128 +++----- .../caps_5.2.0.riscv64.xml | 1 - .../caps_5.2.0.s390x.replies | 118 +++---- .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 1 - .../caps_5.2.0.x86_64.replies | 291 ++++------------- .../caps_5.2.0.x86_64.xml | 3 - .../caps_6.0.0.aarch64.replies | 148 ++++----- .../caps_6.0.0.aarch64.xml | 1 - .../caps_6.0.0.s390x.replies | 118 +++---- .../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 1 - .../caps_6.0.0.x86_64.replies | 291 ++++------------- .../caps_6.0.0.x86_64.xml | 3 - .../caps_6.1.0.x86_64.replies | 301 ++++-------------- .../caps_6.1.0.x86_64.xml | 3 - .../caps_6.2.0.aarch64.replies | 148 ++++----- .../caps_6.2.0.aarch64.xml | 1 - .../caps_6.2.0.ppc64.replies | 140 ++++---- .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 1 - .../caps_6.2.0.x86_64.replies | 301 ++++-------------- .../caps_6.2.0.x86_64.xml | 3 - .../caps_7.0.0.aarch64.replies | 152 ++++----- .../caps_7.0.0.aarch64.xml | 1 - .../caps_7.0.0.ppc64.replies | 140 ++++---- .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml | 1 - .../caps_7.0.0.x86_64.replies | 301 ++++-------------- .../caps_7.0.0.x86_64.xml | 3 - .../caps_7.1.0.x86_64.replies | 301 ++++-------------- .../caps_7.1.0.x86_64.xml | 3 - tests/qemuxml2argvdata/pcihole64-none.err | 1 - tests/qemuxml2argvdata/pcihole64-none.xml | 25 -- tests/qemuxml2argvtest.c | 6 +- tests/qemuxml2xmloutdata/pcihole64-none.xml | 30 -- tests/qemuxml2xmltest.c | 8 +- 61 files changed, 1457 insertions(+), 3582 deletions(-) delete mode 100644 tests/qemuxml2argvdata/pcihole64-none.err delete mode 100644 tests/qemuxml2argvdata/pcihole64-none.xml delete mode 100644 tests/qemuxml2xmloutdata/pcihole64-none.xml -- 2.37.1

2 8

[libvirt PATCH v4 0/6] Add support for 'blob' to virtio video device
by Jonathon Jongsma 18 Aug '22

18 Aug '22

Add support to libvirt for the 'blob' option for virtio video devices in qemu. Also do a little preparatory refactoring of the video device xml parsing code. I sent this series out a couple times but didn't get much review. Sending out again after fixing a few minor test- and doc-related things discussed in the last version and rebasing to current master branch. changes in v4: - rebased to latest master - updated tests changes in v3: - rebased to latest master Changes in v2: - Added some basic documentation - add a qemu capability - Make sure that the /dev/udmabuf device is accessible to qemu (cgroups, etc) Jonathon Jongsma (6): conf: Refactor video model parsing conf: switch to virXMLProp* functions conf: use enum variable for video type conf: add support for 'blob' in virtio video device qemu: Add capability for virtio-gpu.blob qemu: Implement 'blob' support for virtio gpu docs/formatdomain.rst | 7 + src/conf/domain_conf.c | 133 +++++++++--------- src/conf/domain_conf.h | 3 +- src/conf/domain_validate.c | 13 +- src/conf/schemas/domaincommon.rng | 5 + src/libxl/libxl_conf.c | 10 ++ src/libxl/libxl_domain.c | 11 ++ src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_cgroup.c | 22 ++- src/qemu/qemu_command.c | 3 + src/qemu/qemu_domain.h | 1 + src/qemu/qemu_monitor_json.c | 16 ++- src/qemu/qemu_namespace.c | 22 +++ src/qemu/qemu_process.c | 7 + src/qemu/qemu_validate.c | 9 ++ .../caps_6.1.0.x86_64.xml | 1 + .../caps_6.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 1 + .../caps_6.2.0.x86_64.xml | 1 + .../caps_7.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml | 1 + .../caps_7.0.0.x86_64.xml | 1 + .../caps_7.1.0.x86_64.xml | 1 + ...ideo-virtio-blob-absent.x86_64-latest.args | 39 +++++ .../video-virtio-blob-absent.xml | 36 +++++ .../video-virtio-blob-off.x86_64-latest.args | 39 +++++ .../video-virtio-blob-off.xml | 36 +++++ .../video-virtio-blob-on.x86_64-latest.args | 39 +++++ .../qemuxml2argvdata/video-virtio-blob-on.xml | 36 +++++ tests/qemuxml2argvtest.c | 3 + ...video-virtio-blob-absent.x86_64-latest.xml | 48 +++++++ .../video-virtio-blob-off.x86_64-latest.xml | 48 +++++++ .../video-virtio-blob-on.x86_64-latest.xml | 48 +++++++ tests/qemuxml2xmltest.c | 3 + 35 files changed, 567 insertions(+), 81 deletions(-) create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-absent.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-absent.xml create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-off.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-off.xml create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-on.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-on.xml create mode 100644 tests/qemuxml2xmloutdata/video-virtio-blob-absent.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/video-virtio-blob-off.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/video-virtio-blob-on.x86_64-latest.xml -- 2.37.1

1 6

[libvirt PATCH] tests: Drop irrelevant CPU config from graphics-spice-timeout
by Jiri Denemark 18 Aug '22

18 Aug '22

Resolves: https://gitlab.com/libvirt/libvirt/-/issues/243 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- .../graphics-spice-timeout.x86_64-latest.args | 4 ++-- .../graphics-spice-timeout.xml | 18 ------------------ .../graphics-spice-timeout.x86_64-latest.xml | 17 +---------------- 3 files changed, 3 insertions(+), 36 deletions(-) diff --git a/tests/qemuxml2argvdata/graphics-spice-timeout.x86_64-latest.args b/tests/qemuxml2argvdata/graphics-spice-timeout.x86_64-latest.args index 17b49e3169..13c4c08e6f 100644 --- a/tests/qemuxml2argvdata/graphics-spice-timeout.x86_64-latest.args +++ b/tests/qemuxml2argvdata/graphics-spice-timeout.x86_64-latest.args @@ -12,11 +12,11 @@ XDG_CONFIG_HOME=/tmp/lib/domain--1-f14/.config \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/tmp/lib/domain--1-f14/master-key.aes"}' \ -machine pc,usb=off,dump-guest-core=off,memory-backend=pc.ram \ -accel kvm \ --cpu core2duo,ds=on,acpi=on,ss=on,ht=on,tm=on,pbe=on,ds-cpl=on,vmx=on,est=on,tm2=on,cx16=on,xtpr=on,lahf-lm=on \ +-cpu qemu64 \ -m 1024 \ -object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":1073741824}' \ -overcommit mem-lock=off \ --smp 2,sockets=1,dies=1,cores=2,threads=1 \ +-smp 2,sockets=2,cores=1,threads=1 \ -uuid 553effab-b5e1-2d80-dfe3-da4344826c43 \ -no-user-config \ -nodefaults \ diff --git a/tests/qemuxml2argvdata/graphics-spice-timeout.xml b/tests/qemuxml2argvdata/graphics-spice-timeout.xml index 57b48656b2..d1620b7df4 100644 --- a/tests/qemuxml2argvdata/graphics-spice-timeout.xml +++ b/tests/qemuxml2argvdata/graphics-spice-timeout.xml @@ -15,24 +15,6 @@ <apic/> <pae/> </features> - <cpu match='exact' check='none'> - <model>core2duo</model> - <vendor>Intel</vendor> - <topology sockets='1' dies='1' cores='2' threads='1'/> - <feature policy='require' name='ds'/> - <feature policy='require' name='acpi'/> - <feature policy='require' name='ss'/> - <feature policy='require' name='ht'/> - <feature policy='require' name='tm'/> - <feature policy='require' name='pbe'/> - <feature policy='require' name='ds_cpl'/> - <feature policy='require' name='vmx'/> - <feature policy='require' name='est'/> - <feature policy='require' name='tm2'/> - <feature policy='require' name='cx16'/> - <feature policy='require' name='xtpr'/> - <feature policy='require' name='lahf_lm'/> - </cpu> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> diff --git a/tests/qemuxml2xmloutdata/graphics-spice-timeout.x86_64-latest.xml b/tests/qemuxml2xmloutdata/graphics-spice-timeout.x86_64-latest.xml index 6f8a20950c..6f1c0a6c93 100644 --- a/tests/qemuxml2xmloutdata/graphics-spice-timeout.x86_64-latest.xml +++ b/tests/qemuxml2xmloutdata/graphics-spice-timeout.x86_64-latest.xml @@ -16,22 +16,7 @@ <pae/> </features> <cpu mode='custom' match='exact' check='none'> - <model fallback='allow'>core2duo</model> - <vendor>Intel</vendor> - <topology sockets='1' dies='1' cores='2' threads='1'/> - <feature policy='require' name='ds'/> - <feature policy='require' name='acpi'/> - <feature policy='require' name='ss'/> - <feature policy='require' name='ht'/> - <feature policy='require' name='tm'/> - <feature policy='require' name='pbe'/> - <feature policy='require' name='ds_cpl'/> - <feature policy='require' name='vmx'/> - <feature policy='require' name='est'/> - <feature policy='require' name='tm2'/> - <feature policy='require' name='cx16'/> - <feature policy='require' name='xtpr'/> - <feature policy='require' name='lahf_lm'/> + <model fallback='forbid'>qemu64</model> </cpu> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> -- 2.35.1

2 1

[PATCH] vmx: Fix leak in virVMXParseEthernet
by Martin Kletzander 18 Aug '22

18 Aug '22

Commit 580538c5dd7f forgot to free switchId. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- src/vmx/vmx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 9ad463658aa8..191f0b5e83ff 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -2920,6 +2920,7 @@ virVMXParseEthernet(virConf *conf, int controller, virDomainNetDef **def) VIR_FREE(address); VIR_FREE(virtualDev); VIR_FREE(vnet); + VIR_FREE(switchId); return result; } -- 2.37.2

2 1

[PATCH] news: Mention esx support for new interface types
by Martin Kletzander 18 Aug '22

18 Aug '22

Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- NEWS.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 548828c60d72..468b41c1fd9a 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -24,6 +24,11 @@ v8.7.0 (unreleased) * **Improvements** + * esx: Domain XMLs can now be dumped for VMs with two new interface types + + One is when the interface is not connected anywhere `type='dummy'` and one + when it is connected to VMWare Distributed Switch `type='vds'`. + * **Bug fixes** -- 2.37.2

2 1

slow live migration ram
by Ignazio Cassano 18 Aug '22

18 Aug '22

Hello, I am using openstack rdo with kvm libvirt. Live migration is very slow when the vm is using ram intensively. If I migrate a vm that has been running on a host for a few days, it takes several minutes to migrate the memory. After the first migration, I immediately try another one on the same vm, it takes very little. I think it's due to the fragmentation of the pages: is there any remedy? Thanks Ignazio

1 0

[PATCH v4 0/3] qemu: add an API for "query-stats" QMP command
by Amneesh Singh 18 Aug '22

18 Aug '22

QEMU is gaining introspectable statistics which can be queried via the "query-stats" QMP command. This patchset aims to add an API for the same. The returned JSON for "query-stats" is an array of objects containing their own respective array of statistics. Patch 1 adds the API for "query-stats" and a function to deserialize the returned objects into respective hashtables. Patch 2 adds the "query-stats" to QEMU capabilities. Patch 3 uses the API to query the halt poll success time and the halt poll failure time. v3 -> v4 ======== Some changes based on past reviews by Mr. Martin and me [1/3]: - - clean up qemuMonitorQueryStatsProviderNew. - make relevant checks/changes to support the change above. - do NOT return the GPtrArray, instead just return the json object. (this helps retain the non-stat info returned which will be useful in the future patches). - add a function which deserializes value associated with the "stats" key in the JSON object (one of the objects returned in the JSON array above) into a GHashTable. [2/3]: - add a flag to for the capability in tests. [3/3]: - use a helper function to make things cleaner. v2 -> v3 ======== Sorry for the late patchset, I was under the impression I had sent it on Monday but apparently, I did not. [1/3]: - use a single enum for all the statistics. - use QEMU_MONITOR_QUERY_STATS_NAME_LAST as the sentinel value for the provider constructor. - relevant changes to enum values. [2/3]: - fix comment spacing [3/3] - better checks v1 -> v2 ======== I have been tinkering with the v1 patchset and have rewrote the v2 patches a couple of times. I believe the current patchset is still not perfect and would appreciate some reviews. I have another patch or two written but they do not make any significant changes to the current patchset. [1/3]: - use virBitmap instead of an array of strings for statistics. - add enums for the stat names and add qemuMonitorQueryStatsNameTypeToString to switch between the "ToString" functions based on the target type. - change qemuMonitorQueryStatsProviderNew to a variadic function that takes stat enum values with the sentinel value being -1. [2/3]: - No changes [3/3]: - Add relevant monitor related checks to check if the domain is active. - Acquire and release qemuMonitorObj lock before and after calling qemuMonitorQueryStats respectively. - Add the check for privileged access. Relevant QEMU patches can be found here: https://lore.kernel.org/all/20220530150714.756954-1-pbonzini@redhat.com/ This patchset is part of the 2022 GSOC contributor project. Amneesh Singh (3): qemu_monitor: add qemuMonitorQueryStats qemu_capabilities: add "query-stats" QMP command to the QEMU capabilities qemu_driver: use qemuMonitorQueryStats to extract halt poll time src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_driver.c | 81 +++++++++++- src/qemu/qemu_monitor.c | 117 ++++++++++++++++++ src/qemu/qemu_monitor.h | 48 +++++++ src/qemu/qemu_monitor_json.c | 91 ++++++++++++++ src/qemu/qemu_monitor_json.h | 6 + .../caps_7.1.0.x86_64.xml | 1 + 8 files changed, 345 insertions(+), 6 deletions(-) -- 2.37.1

2 6

[libvirt PATCH 0/2] tests: Fix qemuxml2argvtest failure on macOS 12
by Andrea Bolognani 18 Aug '22

18 Aug '22

As reported in https://listman.redhat.com/archives/libvir-list/2022-May/230762.html I'm still unclear on why this worked with all versions of macOS until 12, but the fix feels reasonable enough and I can't really justify digging much further. Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/615807379 macOS 12 job: https://gitlab.com/abologna/libvirt/-/jobs/2895958597 Andrea Bolognani (2): util: Preserve macOS dyld environment by default tests: Reset macOS dyld environment src/util/vircommand.c | 2 ++ tests/qemuxml2argvtest.c | 2 ++ 2 files changed, 4 insertions(+) -- 2.37.2

2 3

[PATCH] RFC: char: deprecate usage of bidirectional pipe
by marcandre.lureau＠redhat.com 16 Aug '22

16 Aug '22

From: Marc-André Lureau <marcandre.lureau(a)redhat.com> As Ed Swierk explained back in 2006: https://lists.nongnu.org/archive/html/qemu-devel/2006-12/msg00160.html "When qemu writes into the pipe, it immediately reads back what it just wrote and treats it as a monitor command, endlessly breathing its own exhaust." This is similarly confusing when using the chardev with a serial device, as reported in https://bugzilla.redhat.com/show_bug.cgi?id=2106975. It seems we have kept the support for bidirectional pipes for historical reasons and odd systems, however it's not documented in qemu -chardev options. I suggest to stop supporting it, for portability reasons. Signed-off-by: Marc-André Lureau <marcandre.lureau(a)redhat.com> --- docs/about/deprecated.rst | 6 ++++++ chardev/char-pipe.c | 4 ++++ 2 files changed, 10 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 7ee26626d5cf..dd5ca30d527b 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -45,6 +45,12 @@ transmit audio through the VNC protocol. ``tty`` and ``parport`` are aliases that will be removed. Instead, the actual backend names ``serial`` and ``parallel`` should be used. +``-chardev pipe`` support for bidirectional pipes (since 7.1) +'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' + +For portability reasons, the support for bidirectional ``pipe`` will +be removed. Instead, use ``file.in`` & ``file.out`` unidirectional pipes. + Short-form boolean options (since 6.0) '''''''''''''''''''''''''''''''''''''' diff --git a/chardev/char-pipe.c b/chardev/char-pipe.c index 66d3b8509183..7db963035e7d 100644 --- a/chardev/char-pipe.c +++ b/chardev/char-pipe.c @@ -27,6 +27,7 @@ #include "qemu/main-loop.h" #include "qemu/module.h" #include "qemu/option.h" +#include "qemu/error-report.h" #include "chardev/char.h" #ifdef _WIN32 @@ -142,6 +143,9 @@ static void qemu_chr_open_pipe(Chardev *chr, if (fd_out >= 0) { close(fd_out); } + warn_report("Support for bidirectional pipe is deprecated,"); + warn_report("please use portable one-way pipes instead (%s.in & %s.out).", + filename, filename); TFR(fd_in = fd_out = qemu_open_old(filename, O_RDWR | O_BINARY)); if (fd_in < 0) { error_setg_file_open(errp, errno, filename); -- 2.37.0.rc0

4 4

[PATCH] qemu_tpm: Don't crash if qemuTPMPcrBankBitmapToStr(NULL)
by Michal Privoznik 15 Aug '22

15 Aug '22

Historically, the tpm->data.emulator.activePcrBanks member was an unsigned int but since it was used as a bitmap it was converted to virBitmap type instead. Now, the virBitmap is allocated inside of virDomainTPMDefParseXML() but only if <activePcrBanks/> was found with at last one child element. Otherwise it stays NULL. Fast forward to starting a domain with TPM 2.0 and no <activePcrBanks/> configured. Eventually, qemuTPMEmulatorBuildCommand() is called, which subsequently calls qemuTPMEmulatorReconfigure() and finally qemuTPMPcrBankBitmapToStr() passing the NULL value. Before rewrite to virBitmap this function would return NULL for empty activePcrBanks but now, well, now it crashes. Fixes: 52c7c31c8038aa31d502f59a40e4fb4ba9f61113 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_tpm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_tpm.c b/src/qemu/qemu_tpm.c index c08b0851da..584c787b70 100644 --- a/src/qemu/qemu_tpm.c +++ b/src/qemu/qemu_tpm.c @@ -449,6 +449,9 @@ qemuTPMPcrBankBitmapToStr(virBitmap *activePcrBanks) g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; ssize_t bank = -1; + if (!activePcrBanks) + return NULL; + while ((bank = virBitmapNextSetBit(activePcrBanks, bank)) > -1) virBufferAsprintf(&buf, "%s,", virDomainTPMPcrBankTypeToString(bank)); -- 2.35.1

2 1

[PATCH 00/11] Dirty page rate limit support
by huangy81＠chinatelecom.cn 13 Aug '22

13 Aug '22

From: Hyman Huang(黄勇) <huangy81(a)chinatelecom.cn> Qemu introduced dirty page rate limit feature in 7.1.0, see the details in the following link: https://lore.kernel.org/qemu-devel/cover.1656177590.git.huangy81@chinatelec… So may be it's the right time to enabling this feature in libvirt meanwhile so that upper user can play with it. Expecting the upper app can use this feature to do a vcpu Qos or whatever else. This patch add 2 new apis to implement dirty page rate limit: 1. virDomainSetVcpuDirtyLimit, which set vcpu dirty page rate limit. virsh command 'vcpudirtylimit' also implemented correspondingly. 2. virDomainCancelVcpuDirtyLimit, which cancel vcpu dirty page rate limit. 'cancel' option was introduced to 'vcpudirtylimit' to cancel the limit correspondingly. In addition, function 'qemuMonitorQueryVcpuDirtyLimit' was implemented to query dirty page rate limit, virsh command 'vcpuinfo' was extended so that user can query dirty page rate limit info via 'vcpuinfo'. This series make main modifications as the following: - introduce QEMU_CAPS_VCPU_DIRTY_LIMIT capability so that libvirt can probe before using dirty page rate limit feature. - implement virsh command 'vcpudirtylimit' to set/cancel dirty page rate limit. - extend vcpuinfo api so that it can display dirtylimit info. - document dirty page rate limit feature. Please review, thanks! Best regards! *** BLURB HERE *** Hyman Huang(黄勇) (11): qemu_capabilities: Introduce QEMU_CAPS_VCPU_DIRTY_LIMIT capability libvirt: Add virDomainSetVcpuDirtyLimit API qemu_driver: Implement qemuDomainSetVcpuDirtyLimit virsh: Introduce vcpudirtylimit api qemu_monitor: Implement qemuMonitorQueryVcpuDirtyLimit qemu_driver: Extend qemuDomainGetVcpus for dirtylimit virsh: Extend vcpuinfo api to display dirtylimit info libvirt: Add virDomainCancelVcpuDirtyLimit API qemu_driver: Implement qemuDomainCancelVcpuDirtyLimit virsh: Add cancel option to vcpudirtylimit api NEWS: Document dirty page rate limit APIs NEWS.rst | 13 ++ include/libvirt/libvirt-domain.h | 22 ++++ src/driver-hypervisor.h | 13 ++ src/libvirt-domain.c | 95 +++++++++++++++ src/libvirt_public.syms | 6 + src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_driver.c | 146 +++++++++++++++++++++++ src/qemu/qemu_monitor.c | 35 ++++++ src/qemu/qemu_monitor.h | 26 ++++ src/qemu/qemu_monitor_json.c | 137 +++++++++++++++++++++ src/qemu/qemu_monitor_json.h | 13 ++ src/remote/remote_daemon_dispatch.c | 2 + src/remote/remote_driver.c | 4 + src/remote/remote_protocol.x | 30 ++++- src/remote_protocol-structs | 13 ++ tests/qemucapabilitiesdata/caps_7.1.0.x86_64.xml | 1 + tools/virsh-domain.c | 112 +++++++++++++++++ 18 files changed, 673 insertions(+), 2 deletions(-) -- 1.8.3.1

1 11

[PATCH for-7.1?] Fix some typos in documentation (most of them found by codespell)
by Stefan Weil 12 Aug '22

12 Aug '22

Signed-off-by: Stefan Weil <sw(a)weilnetz.de> --- docs/about/deprecated.rst | 2 +- docs/specs/acpi_erst.rst | 4 ++-- docs/system/devices/canokey.rst | 8 ++++---- docs/system/devices/cxl.rst | 12 ++++++------ 4 files changed, 13 insertions(+), 13 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 7ee26626d5..91b03115ee 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -297,7 +297,7 @@ by using ``-machine graphics=off``. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ In QEMU versions 6.1, 6.2 and 7.0, the ``nvme-ns`` generates an EUI-64 -identifer that is not globally unique. If an EUI-64 identifer is required, the +identifier that is not globally unique. If an EUI-64 identifier is required, the user must set it explicitly using the ``nvme-ns`` device parameter ``eui64``. ``-device nvme,use-intel-id=on|off`` (since 7.1) diff --git a/docs/specs/acpi_erst.rst b/docs/specs/acpi_erst.rst index a8a9d22d25..2339b60ad7 100644 --- a/docs/specs/acpi_erst.rst +++ b/docs/specs/acpi_erst.rst @@ -108,7 +108,7 @@ Slot 0 contains a backend storage header that identifies the contents as ERST and also facilitates efficient access to the records. Depending upon the size of the backend storage, additional slots will be designated to be a part of the slot 0 header. For example, at 8KiB, -the slot 0 header can accomodate 1021 records. Thus a storage size +the slot 0 header can accommodate 1021 records. Thus a storage size of 8MiB (8KiB * 1024) requires an additional slot for use by the header. In this scenario, slot 0 and slot 1 form the backend storage header, and records can be stored starting at slot 2. @@ -196,5 +196,5 @@ References [2] "Unified Extensible Firmware Interface Specification", version 2.1, October 2008. -[3] "Windows Hardware Error Architecture", specfically +[3] "Windows Hardware Error Architecture", specifically "Error Record Persistence Mechanism". diff --git a/docs/system/devices/canokey.rst b/docs/system/devices/canokey.rst index c2c58ae3e7..cfa6186e48 100644 --- a/docs/system/devices/canokey.rst +++ b/docs/system/devices/canokey.rst @@ -28,9 +28,9 @@ With the same software configuration as a hardware key, the guest OS can use all the functionalities of a secure key as if there was actually an hardware key plugged in. -CanoKey QEMU provides much convenience for debuging: +CanoKey QEMU provides much convenience for debugging: -* libcanokey-qemu supports debuging output thus developers can +* libcanokey-qemu supports debugging output thus developers can inspect what happens inside a secure key * CanoKey QEMU supports trace event thus event * QEMU USB stack supports pcap thus USB packet between the guest @@ -102,8 +102,8 @@ and find CanoKey QEMU there: You may setup the key as guided in [6]_. The console for the key is at [7]_. -Debuging -======== +Debugging +========= CanoKey QEMU consists of two parts, ``libcanokey-qemu.so`` and ``canokey.c``, the latter of which resides in QEMU. The former provides core functionality diff --git a/docs/system/devices/cxl.rst b/docs/system/devices/cxl.rst index 36031325cc..f25783a4ec 100644 --- a/docs/system/devices/cxl.rst +++ b/docs/system/devices/cxl.rst @@ -83,7 +83,7 @@ CXL Fixed Memory Windows (CFMW) A CFMW consists of a particular range of Host Physical Address space which is routed to particular CXL Host Bridges. At time of generic software initialization it will have a particularly interleaving -configuration and associated Quality of Serice Throtling Group (QTG). +configuration and associated Quality of Service Throttling Group (QTG). This information is available to system software, when making decisions about how to configure interleave across available CXL memory devices. It is provide as CFMW Structures (CFMWS) in @@ -98,7 +98,7 @@ specification defined register interface called CXL Host Bridge Component Registers (CHBCR). The location of this CHBCR MMIO space is described to system software via a CXL Host Bridge Structure (CHBS) in the CEDT ACPI table. The actual interfaces -are identical to those used for other parts of the CXL heirarchy +are identical to those used for other parts of the CXL hierarchy as CXL Component Registers in PCI BARs. Interfaces provided include: @@ -143,7 +143,7 @@ CXL Memory Devices - Type 3 ~~~~~~~~~~~~~~~~~~~~~~~~~~~ CXL type 3 devices use a PCI class code and are intended to be supported by a generic operating system driver. They have HDM decoders -though in these EP devices, the decoder is reponsible not for +though in these EP devices, the decoder is responsible not for routing but for translation of the incoming host physical address (HPA) into a Device Physical Address (DPA). @@ -209,7 +209,7 @@ Notes: ranges of the system physical address map. Each CFMW has particular interleave setup across the CXL Host Bridges (HB) CFMW0 provides uninterleaved access to HB0, CFW2 provides - uninterleaved acess to HB1. CFW1 provides interleaved memory access + uninterleaved access to HB1. CFW1 provides interleaved memory access across HB0 and HB1. (2) **Two CXL Host Bridges**. Each of these has 2 CXL Root Ports and @@ -282,7 +282,7 @@ Example topology involving a switch:: --------------------------------------------------- | Switch 0 USP as PCI 0d:00.0 | | USP has HDM decoder which direct traffic to | - | appropiate downstream port | + | appropriate downstream port | | Switch BUS appears as 0e | |x__________________________________________________| | | | | @@ -366,7 +366,7 @@ An example of 4 devices below a switch suitable for 1, 2 or 4 way interleave:: Kernel Configuration Options ---------------------------- -In Linux 5.18 the followings options are necessary to make use of +In Linux 5.18 the following options are necessary to make use of OS management of CXL memory devices as described here. * CONFIG_CXL_BUS -- 2.30.2

3 3

[PATCH 0/3] schema: Some fixes and maxphyaddr support in hostcpu
by Jim Fehlig 12 Aug '22

12 Aug '22

Inspired by Tim's patch to fix my earlier omission https://listman.redhat.com/archives/libvir-list/2022-August/233624.html Jim Fehlig (3): schema: Remove optional nesting in hostcpu rng schema: Don't enforce ordering of hostcpu capabilities elements schema: Add maxphysaddr element to hostcpu src/conf/schemas/cputypes.rng | 47 +++++++++++++----------- tests/capabilityschemadata/caps-test.xml | 2 + 2 files changed, 28 insertions(+), 21 deletions(-) -- 2.37.1

2 4

[libvirt PATCH] schema: Add maxphysaddr element to hostcpu
by Tim Wiederhake 12 Aug '22

12 Aug '22

The output of "virsh capabilities" was not conformant to the capability.rng schema. Add the missing element to the schema. Fixes: c647bf29afb9890c792172ecf7db2c9c27babbb6 Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com> --- src/conf/schemas/cputypes.rng | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/conf/schemas/cputypes.rng b/src/conf/schemas/cputypes.rng index 4ae386c3c0..d02f2f88cf 100644 --- a/src/conf/schemas/cputypes.rng +++ b/src/conf/schemas/cputypes.rng @@ -387,6 +387,9 @@ <optional> <ref name="cpuTopology"/> </optional> + <optional> + <ref name="cpuMaxPhysAddr"/> + </optional> <zeroOrMore> <element name="feature"> <attribute name="name"> -- 2.36.1

3 4

[PATCH] NEWS: Mention support for specifying vCPU address size
by Jim Fehlig 11 Aug '22

11 Aug '22

Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- NEWS.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index efd63bc9c3..548828c60d 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,11 @@ v8.7.0 (unreleased) * **New features** + * qemu: Add support for specifying vCPU physical address size in bits + + Users can now specify the number of vCPU physical address bits with + the `<maxphysaddr>` subelment of the `<cpu>` element. + * **Improvements** * **Bug fixes** -- 2.37.1

2 1

[libvirt PATCH 0/3] qemu: retire QEMU_CAPS_VIRTIO_TX_ALG
by Ján Tomko 11 Aug '22

11 Aug '22

*** BRULB HERE *** Ján Tomko (3): tests: qemuxml2xmltest: remove interface from disk test qemu: always assume QEMU_CAPS_VIRTIO_TX_ALG qemu: retire QEMU_CAPS_VIRTIO_TX_ALG src/qemu/qemu_capabilities.c | 3 +- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c | 36 +++++++++---------- src/qemu/qemu_validate.c | 8 ----- .../caps_4.2.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 - .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 - .../caps_4.2.0.x86_64.xml | 1 - .../caps_5.0.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 - .../caps_5.0.0.riscv64.xml | 1 - .../caps_5.0.0.x86_64.xml | 1 - .../caps_5.1.0.x86_64.xml | 1 - .../caps_5.2.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 1 - .../caps_5.2.0.riscv64.xml | 1 - .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 1 - .../caps_5.2.0.x86_64.xml | 1 - .../caps_6.0.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 1 - .../caps_6.0.0.x86_64.xml | 1 - .../caps_6.1.0.x86_64.xml | 1 - .../caps_6.2.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 1 - .../caps_6.2.0.x86_64.xml | 1 - .../caps_7.0.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml | 1 - .../caps_7.0.0.x86_64.xml | 1 - .../caps_7.1.0.x86_64.xml | 1 - .../disk-copy_on_read.x86_64-latest.args | 4 +-- tests/qemuxml2argvdata/disk-copy_on_read.xml | 5 --- tests/qemuxml2argvtest.c | 3 +- .../qemuxml2xmloutdata/disk-copy_on_read.xml | 8 +---- tests/qemuxml2xmltest.c | 4 +-- 34 files changed, 24 insertions(+), 74 deletions(-) -- 2.37.1

2 4

[libvirt PATCH 0/3] tests: Fix qemucapabilitiestest on macOS
by Andrea Bolognani 11 Aug '22

11 Aug '22

We need to mock the function that probes for HVF support. Andrea Bolognani (3): tests: Use domaincapsmock in qemucapabilitiestest qemu: Make virQEMUCapsProbeHVF() non-static tests: Mock virQEMUCapsProbeHVF() src/qemu/qemu_capabilities.c | 4 ++-- src/qemu/qemu_capabilities.h | 2 ++ tests/domaincapsmock.c | 6 ++++++ tests/qemucapabilitiestest.c | 3 ++- 4 files changed, 12 insertions(+), 3 deletions(-) -- 2.37.1

3 7

[PATCH v2] qemuDomainObjWait: Report error when VM is being destroyed
by Peter Krempa 11 Aug '22

11 Aug '22

Since we started handing the monitor EOF event inside a job any code which uses virDomainObjWait would no longer properly abort in case when the VM crashed during the wait. This is because virDomainObjWait uses virDomainObjIsActive which checks 'vm->def->id' to see if the VM is still active. Unfortunately the domain id is cleared in qemuProcessStop which is run only inside the job. To fix this we can use the 'beingDestroyed' flag stored in the VM private data which is set to true around the time when the condition is signalled. Reported-by: Pavel Hrdina <phrdina(a)redhat.com> Fixes: 8c9ff9960b29d4703a99efdd1cadcf6f48799cc0 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- v2: Fix condition in qemuMigrationSrcWaitForCompletion, where we check whether the VM is active to use same logic src/qemu/qemu_domain.c | 12 +++++++++++- src/qemu/qemu_migration.c | 2 +- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 2caed7315b..43b5ad5d6e 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -11780,5 +11780,15 @@ qemuDomainRemoveLogs(virQEMUDriver *driver, int qemuDomainObjWait(virDomainObj *vm) { - return virDomainObjWait(vm); + qemuDomainObjPrivate *priv = vm->privateData; + + if (virDomainObjWait(vm) < 0) + return -1; + + if (priv->beingDestroyed) { + virReportError(VIR_ERR_OPERATION_FAILED, "%s", _("domain is not running")); + return -1; + } + + return 0; } diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 0b48852b9d..8a8e9ab207 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -2078,7 +2078,7 @@ qemuMigrationSrcWaitForCompletion(virDomainObj *vm, return rv; if (qemuDomainObjWait(vm) < 0) { - if (virDomainObjIsActive(vm)) + if (virDomainObjIsActive(vm) && !priv->beingDestroyed) jobData->status = VIR_DOMAIN_JOB_STATUS_FAILED; return -2; } -- 2.37.1

2 1

[PATCH] qemuMigrationSrcWaitForSpice: Remove return value
by Peter Krempa 11 Aug '22

11 Aug '22

The only caller doesn't check the return value and actually doesn't have one either. Remove the return value and adjust return statements. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_migration.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 0b48852b9d..e28f738ebf 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -1773,21 +1773,20 @@ qemuMigrationDstPostcopyFailed(virDomainObj *vm) } -static int +static void qemuMigrationSrcWaitForSpice(virDomainObj *vm) { qemuDomainObjPrivate *priv = vm->privateData; qemuDomainJobPrivate *jobPriv = priv->job.privateData; if (!jobPriv->spiceMigration) - return 0; + return; VIR_DEBUG("Waiting for SPICE to finish migration"); while (!jobPriv->spiceMigrated && !priv->job.abortJob) { if (qemuDomainObjWait(vm) < 0) - return -1; + return; } - return 0; } -- 2.37.1

3 2

[libvirt PATCH v2 0/2] ci: Fix paths shown in the website
by Andrea Bolognani 11 Aug '22

11 Aug '22

Compare https://abologna.gitlab.io/-/libvirt/-/jobs/2840280594/artifacts/website/ma… with https://libvirt.org/manpages/virtqemud.html#files Changes from [v1]: * don't use pathlib; * don't check whether DESTDIR is absolute. [v1] https://listman.redhat.com/archives/libvir-list/2022-July/232929.html Andrea Bolognani (2): scripts: Add $DESTDIR support to meson-install-web.py ci: Fix paths shown in the website .gitlab-ci.yml | 6 +++--- scripts/meson-install-web.py | 8 ++++++-- 2 files changed, 9 insertions(+), 5 deletions(-) -- 2.37.1

2 3

[libvirt PATCH 0/3] ci: Fix paths shown in the website
by Andrea Bolognani 10 Aug '22

10 Aug '22

Compare https://abologna.gitlab.io/-/libvirt/-/jobs/2741293181/artifacts/website/ma… with https://libvirt.org/manpages/virtqemud.html#files Andrea Bolognani (3): scripts: Port meson-install-web.py to pathlib scripts: Add $DESTDIR support to meson-install-web.py ci: Fix paths shown in the website .gitlab-ci.yml | 6 +++--- scripts/meson-install-web.py | 22 ++++++++++++++++++++-- 2 files changed, 23 insertions(+), 5 deletions(-) -- 2.35.3

2 6

[PATCH 0/3] qemu: Fix waiting for domain condition when qemu crashes
by Peter Krempa 10 Aug '22

10 Aug '22

See 3/4. Peter Krempa (4): qemuProcessBeginStopJob: Add debug log when waking up all threads waiting on domain condition qemu: Replace virDomainObjWait with qemuDomainObjWait qemuDomainObjWait: Report error when VM is being destroyed DO_NOT_APPLY_UPSTREAM: reproducer src/qemu/qemu_block.c | 2 +- src/qemu/qemu_domain.c | 17 +++++++++++++++++ src/qemu/qemu_domain.h | 3 +++ src/qemu/qemu_driver.c | 5 +++-- src/qemu/qemu_migration.c | 12 ++++++------ src/qemu/qemu_process.c | 1 + 6 files changed, 31 insertions(+), 9 deletions(-) -- 2.37.1

2 5

Test failures on macOS 12
by Andrea Bolognani 10 Aug '22

10 Aug '22

I'm trying to enable CI coverage for macOS 12, but I'm running into a couple of issues that I'm not sure how to handle. Note that the test suite currently passes on macOS 11[1], so these failures have to be a consequence to changes made to macOS that we haven't yet learned how to cope with. The first one is in vircryptotest: Encrypt aes265cbc ... Expected ciphertext doesn't match I've added some debug statements and it looks like the generated data is different every time, which seems like a pretty good indication that virrandommock is not being picked up correctly. This is not the only test program that uses that specific mock though, so I'm not sure what makes it fail when all the others are succeeding. The other issue is in qemuxml2argvtest: error : virCommandWait:2752 : internal error: Child process (/usr/libexec/qemu/vhost-user/test-vhost-user-gpu --print-capabilities) unexpected fatal signal 6: dyld[8896]: symbol not found in flat namespace '_virQEMUCapsGet' error : qemuVhostUserFillDomainGPU:394 : operation failed: Unable to find a satisfying vhost-user-gpu So the various virFileWrapperAddPrefix() calls that cause the contents of tests/qemuvhostuserdata/ to override the host's own vhostuser configuration are still effective, but for some reason the trivial test-vhost-user-gpu shell script can't be run successfully because an internal libvirt symbol can't be found somehow? Confusing. Roman, does any of this ring a bell? Any chance you could investigate? macOS 12 has been out for a while now so I'd be very keen to have it added to CI. Thanks in advance! [1] https://gitlab.com/libvirt/libvirt/-/jobs/2421455154 -- Andrea Bolognani / Red Hat / Virtualization

3 10

[PATCH 0/5] jobs: qemu & hypervisor: move hypervisor-based variables and functions
by Kristina Hanicova 10 Aug '22

10 Aug '22

*** BLURB HERE *** Kristina Hanicova (5): qemu: beginJob: move saveStatus into private job callbacks hypervisor: domain_job: add maxQueuedJobs qemu: remove unused driver and all its propagations qemu: refactor functions with removed driver if possible hypervisor: domain_job: add JobData private callbacks into virDomainJobObj src/ch/ch_domain.c | 2 +- src/hypervisor/domain_job.c | 4 +- src/hypervisor/domain_job.h | 8 +- src/libxl/libxl_domain.c | 2 +- src/lxc/lxc_domain.c | 2 +- src/qemu/qemu_backup.c | 21 +- src/qemu/qemu_backup.h | 3 +- src/qemu/qemu_block.c | 26 +- src/qemu/qemu_block.h | 6 +- src/qemu/qemu_blockjob.c | 25 +- src/qemu/qemu_blockjob.h | 3 +- src/qemu/qemu_checkpoint.c | 15 +- src/qemu/qemu_domain.c | 51 ++- src/qemu/qemu_domain.h | 21 +- src/qemu/qemu_domainjob.c | 45 +-- src/qemu/qemu_domainjob.h | 15 +- src/qemu/qemu_driver.c | 581 +++++++++++++------------------ src/qemu/qemu_hotplug.c | 217 +++++------- src/qemu/qemu_hotplug.h | 39 +-- src/qemu/qemu_migration.c | 235 ++++++------- src/qemu/qemu_migration.h | 15 +- src/qemu/qemu_migration_cookie.c | 5 +- src/qemu/qemu_migration_params.c | 38 +- src/qemu/qemu_migration_params.h | 15 +- src/qemu/qemu_process.c | 201 +++++------ src/qemu/qemu_process.h | 12 +- src/qemu/qemu_snapshot.c | 24 +- tests/qemuhotplugtest.c | 6 +- 28 files changed, 699 insertions(+), 938 deletions(-) -- 2.37.1

2 7

[PATCH] qemu: Fix indentation
by Andrea Bolognani 10 Aug '22

10 Aug '22

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. src/qemu/qemu_capabilities.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index f8e70470f6..79ef8b88ef 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -3284,7 +3284,7 @@ virQEMUCapsProbeHVF(virQEMUCaps *qemuCaps) static int virQEMUCapsProbeHVF(virQEMUCaps *qemuCaps G_GNUC_UNUSED) { - return 0; + return 0; } #endif -- 2.37.1

1 0

[PATCH v2 0/9] qemu: Enable SCHED_CORE for domains and helper processes
by Michal Privoznik 10 Aug '22

10 Aug '22

v2 of: https://listman.redhat.com/archives/libvir-list/2022-May/230902.html While technically, the original series was "just" and RFC, it got proper review and thus I'm marking this as v2. What's still missing? ===================== * Per Dario's suggestion, we should take vcpu pinning (and possibly emulator pinning as well) into account, so that the guest doesn't have to do SCHED_CORE inside it. * per-VM knob to enable/disable SCHED_CORE. But as discussed under my RFC patches, it's probably not needed, at least for now. It can always be added later, should somebody need it. Diff to v1: =========== * Turned qemu.conf knob into an enum rather than boolean, so that users can chose whether helper processes are placed into the emulator group too * Cleaned up virCommand* code; per Dan's suggestion use one variable to differentiate runAlone/runAmong states, instead of two. Michal Prívozník (9): qemu_dbus: Separate PID read code into qemuDBusGetPID qemu_vhost_user_gpu: Export qemuVhostUserGPUGetPid() qemu_tpm: Expose qemuTPMEmulatorGetPid() qemu_virtiofs: Separate PID read code into qemuVirtioFSGetPid virprocess: Core Scheduling support virCommand: Introduce APIs for core scheduling qemu_conf: Introduce a knob to set SCHED_CORE qemu: Enable SCHED_CORE for domains and helper processes qemu: Place helper processes into the same trusted group src/libvirt_private.syms | 6 ++ src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf.in | 14 ++++ src/qemu/qemu_conf.c | 42 ++++++++++ src/qemu/qemu_conf.h | 11 +++ src/qemu/qemu_dbus.c | 42 +++++++--- src/qemu/qemu_dbus.h | 4 + src/qemu/qemu_extdevice.c | 120 ++++++++++++++++++++++++++++ src/qemu/qemu_extdevice.h | 3 + src/qemu/qemu_process.c | 9 +++ src/qemu/qemu_security.c | 4 + src/qemu/qemu_tpm.c | 2 +- src/qemu/qemu_tpm.h | 7 ++ src/qemu/qemu_vhost_user_gpu.c | 2 +- src/qemu/qemu_vhost_user_gpu.h | 8 ++ src/qemu/qemu_virtiofs.c | 41 +++++++--- src/qemu/qemu_virtiofs.h | 5 ++ src/qemu/test_libvirtd_qemu.aug.in | 1 + src/util/vircommand.c | 63 +++++++++++++++ src/util/vircommand.h | 5 ++ src/util/virprocess.c | 124 +++++++++++++++++++++++++++++ src/util/virprocess.h | 8 ++ 22 files changed, 494 insertions(+), 28 deletions(-) -- 2.35.1

4 17

[PATCH 0/3] qemu: add support for the SCHED_DEADLINE scheduling policy
by Sasha Algisi 10 Aug '22

10 Aug '22

Hello everyone, This patchset aims at adding support for the SCHED_DEADLINE Linux scheduling policy for vcpus, io-threads and emulator processes. In fact, libvirt currently supports SCHED_OTHER, SCHED_BATCH, SCHED_IDLE, SCHE_FIFO and SCHED_RR, but not SCHED_DEADLINE. SCHED_DEADLINE is a policy implementing an algorithm originating from the real-time scheduling community, but it can be useful outside of the real-time computing field as well. It allows one to set a specific amount of CPU time that a task should receive with a given periodicity, and withing a certain deadline. E.g., task t should be scheduled at least for 50 ms every 100 ms. To achieve this, it needs 3 parameters: runtime, deadline and period (although period can just be equal to deadline, which is what happens automatically if one sets period=0). It must always hold that: runtime <= deadline <= period (and this is enforced by the kernel, but checks are included in the patches, so that meaningful and easy to interpret error messages can be printed to the user). More info on SCHED_DEADLINE are available here: https://docs.kernel.org/scheduler/sched-deadline.html The interface will look like this, e.g., for setting SCHED_DEADLINE as a policy for 3 (0-2) vcpus, with runtime = 10000000, deadline = 15000000 and period = 20000000: <cputune> ... <vcpusched vcpus="0-2" scheduler="deadline" runtime="10000000" deadline="15000000" period="20000000"/> ... </cputune> This a link to a branch containing the patches: https://gitlab.com/Algisi-00/libvirt/-/tree/sched-deadline And this is the link to results of running the CI on such branch: https://gitlab.com/Algisi-00/libvirt/-/pipelines/601795712 Note that the jobs that are failing are also failing in the exact same way without these patches applied. Feedback is welcome and very much appreciated. Thanks and regards. Sasha Algisi (3): virprocess: define sched_attr and sched_setattr virprocess: add the SCHED_DEADLINE scheduling policy domain_conf: add SCHED_DEADLINE support in the XML configuration NEWS.rst | 5 ++ docs/formatdomain.rst | 16 +++- src/ch/ch_process.c | 3 +- src/conf/domain_conf.c | 52 +++++++++++-- src/conf/domain_conf.h | 3 + src/conf/schemas/domaincommon.rng | 16 ++++ src/qemu/qemu_process.c | 8 +- src/util/virprocess.c | 123 +++++++++++++++++++++++++++++- src/util/virprocess.h | 6 +- 9 files changed, 216 insertions(+), 16 deletions(-) -- 2.37.1 -- ------------------------ Indirizzo istituzionale di posta elettronica degli studenti e dei laureati dell'Università di TorinoOfficial University of Turin email address for students and graduates

2 7

[PATCH 0/5] bridge_driver: Enable virMacMap iff dnsmasq is started
by Michal Privoznik 09 Aug '22

09 Aug '22

See 5/5 for explanation. Michal Prívozník (5): bridge_driver: Set @dnsmasqStarted only after successful dnsmasq spawn bridge_driver: Use g_autoptr() for virMacMap virNetworkObjSetMacMap: take double pointer of @macmap bridge_driver: Introduce a helper for virNetworkObjSetMacMap() bridge_driver: Enable virMacMap iff dnsmasq is started src/conf/virnetworkobj.c | 4 +-- src/conf/virnetworkobj.h | 2 +- src/network/bridge_driver.c | 54 ++++++++++++++++++++----------------- 3 files changed, 32 insertions(+), 28 deletions(-) -- 2.35.1

2 6

[libvirt PATCH] rpm: merge mingw sub-packages into native spec
by Daniel P. Berrangé 09 Aug '22

09 Aug '22

One specfile containing both native and mingw builds is the new best practice for Fedora. This reduces the maint burden and ensures the mingw packages don't fall behind. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- .gitlab-ci.yml | 2 +- libvirt.spec.in | 287 ++++++++++++++++++++++++++++++++++++ meson.build | 17 +-- mingw-libvirt.spec.in | 327 ------------------------------------------ 4 files changed, 293 insertions(+), 340 deletions(-) delete mode 100644 mingw-libvirt.spec.in diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 6a8b89729f..39c5f8fb6d 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -33,7 +33,7 @@ include: - meson dist -C build --no-tests - if test -x /usr/bin/rpmbuild && test "$RPM" != "skip"; then - rpmbuild --clean --nodeps --define "_topdir $PWD/rpmbuild/" -ta build/meson-dist/libvirt-*.tar.xz; + rpmbuild --clean --nodeps --define "_without_mingw 1" --define "_topdir $PWD/rpmbuild/" -ta build/meson-dist/libvirt-*.tar.xz; mv rpmbuild/RPMS/x86_64/ libvirt-rpms/; else meson compile -C build; diff --git a/libvirt.spec.in b/libvirt.spec.in index a238edf2aa..fe386bfef2 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -197,6 +197,10 @@ %define qemu_moddir %{_libdir}/qemu %define qemu_datadir %{_datadir}/qemu +%define with_mingw 0 +%if 0%{?fedora} + %define with_mingw 0%{!?_without_mingw:1} +%endif # RHEL releases provide stable tool chains and so it is safe to turn # compiler warning into errors without being worried about frequent @@ -393,6 +397,36 @@ BuildRequires: libtirpc-devel BuildRequires: firewalld-filesystem %endif +%if %{with_mingw} +BuildRequires: mingw32-filesystem +BuildRequires: mingw32-gcc +BuildRequires: mingw32-binutils +BuildRequires: mingw32-glib2 >= 2.48 +BuildRequires: mingw32-libgpg-error +BuildRequires: mingw32-libgcrypt +BuildRequires: mingw32-gnutls +BuildRequires: mingw32-gettext +BuildRequires: mingw32-libxml2 +BuildRequires: mingw32-portablexdr +BuildRequires: mingw32-dlfcn +BuildRequires: mingw32-libssh2 +BuildRequires: mingw32-curl + +BuildRequires: mingw64-filesystem +BuildRequires: mingw64-gcc +BuildRequires: mingw64-binutils +BuildRequires: mingw64-glib2 >= 2.48 +BuildRequires: mingw64-libgpg-error +BuildRequires: mingw64-libgcrypt +BuildRequires: mingw64-gnutls +BuildRequires: mingw64-gettext +BuildRequires: mingw64-libxml2 +BuildRequires: mingw64-portablexdr +BuildRequires: mingw64-dlfcn +BuildRequires: mingw64-libssh2 +BuildRequires: mingw64-curl +%endif + %description Libvirt is a C toolkit to interact with the virtualization capabilities of recent versions of Linux (and other OSes). The main package includes @@ -948,6 +982,25 @@ Requires: libvirt-daemon-driver-network = %{version}-%{release} %description nss Libvirt plugin for NSS for translating domain names into IP addresses. +%if %{with_mingw} +%package -n mingw32-libvirt +Summary: %{summary} +Obsoletes: mingw32-libvirt-static < 7.0.0 +BuildArch: noarch + +%description -n mingw32-libvirt +MinGW Windows libvirt virtualization library. + +%package -n mingw64-libvirt +Summary: %{summary} +Obsoletes: mingw64-libvirt-static < 7.0.0 +BuildArch: noarch + +%description -n mingw64-libvirt +MinGW Windows libvirt virtualization library. + +%{?mingw_debug_package} +%endif %prep @@ -1191,6 +1244,84 @@ export SOURCE_DATE_EPOCH=$(stat --printf='%Y' %{_specdir}/%{name}.spec) %meson_build +%if %{with_mingw} +%mingw_meson \ + --auto-features=enabled \ + -Ddriver_remote=enabled \ + -Ddriver_test=enabled \ + -Ddriver_esx=enabled \ + -Dcurl=enabled \ + -Ddocs=enabled \ + -Dapparmor=disabled \ + -Dapparmor_profiles=disabled \ + -Dattr=disabled \ + -Daudit=disabled \ + -Dbash_completion=disabled \ + -Dblkid=disabled \ + -Dcapng=disabled \ + -Ddriver_bhyve=disabled \ + -Ddriver_hyperv=disabled \ + -Ddriver_interface=disabled \ + -Ddriver_libvirtd=disabled \ + -Ddriver_libxl=disabled \ + -Ddriver_lxc=disabled \ + -Ddriver_network=disabled \ + -Ddriver_openvz=disabled \ + -Ddriver_qemu=disabled \ + -Ddriver_secrets=disabled \ + -Ddriver_vbox=disabled \ + -Ddriver_vmware=disabled \ + -Ddriver_vz=disabled \ + -Ddtrace=disabled \ + -Dexpensive_tests=enabled \ + -Dfirewalld=disabled \ + -Dfirewalld_zone=disabled \ + -Dfuse=disabled \ + -Dglusterfs=disabled \ + -Dhost_validate=disabled \ + -Dlibiscsi=disabled \ + -Dlibnl=disabled \ + -Dlibpcap=disabled \ + -Dlibssh2=disabled \ + -Dlibssh=disabled \ + -Dlogin_shell=disabled \ + -Dnetcf=disabled \ + -Dnls=disabled \ + -Dnss=disabled \ + -Dnumactl=disabled \ + -Dnumad=disabled \ + -Dopenwsman=disabled \ + -Dpciaccess=disabled \ + -Dpm_utils=disabled \ + -Dpolkit=disabled \ + -Dreadline=disabled \ + -Drpath=disabled \ + -Dsanlock=disabled \ + -Dsasl=disabled \ + -Dsecdriver_apparmor=disabled \ + -Dsecdriver_selinux=disabled \ + -Dselinux=disabled \ + -Dstorage_dir=disabled \ + -Dstorage_disk=disabled \ + -Dstorage_fs=disabled \ + -Dstorage_gluster=disabled \ + -Dstorage_iscsi_direct=disabled \ + -Dstorage_iscsi=disabled \ + -Dstorage_lvm=disabled \ + -Dstorage_mpath=disabled \ + -Dstorage_rbd=disabled \ + -Dstorage_scsi=disabled \ + -Dstorage_sheepdog=disabled \ + -Dstorage_vstorage=disabled \ + -Dstorage_zfs=disabled \ + -Dsysctl_config=disabled \ + -Dtests=disabled \ + -Dudev=disabled \ + -Dwireshark_dissector=disabled \ + -Dyajl=disabled +%mingw_ninja +%endif + %install rm -fr %{buildroot} @@ -1259,6 +1390,26 @@ mv $RPM_BUILD_ROOT%{_datadir}/systemtap/tapset/libvirt_qemu_probes.stp \ %endif %endif +%if %{with_mingw} +%mingw_ninja_install + +rm -rf $RPM_BUILD_ROOT%{mingw32_sysconfdir}/libvirt/nwfilter +rm -rf $RPM_BUILD_ROOT%{mingw64_sysconfdir}/libvirt/nwfilter +rm -rf $RPM_BUILD_ROOT%{mingw32_datadir}/doc/* +rm -rf $RPM_BUILD_ROOT%{mingw64_datadir}/doc/* +rm -rf $RPM_BUILD_ROOT%{mingw32_datadir}/gtk-doc/* +rm -rf $RPM_BUILD_ROOT%{mingw64_datadir}/gtk-doc/* + +rm -rf $RPM_BUILD_ROOT%{mingw32_libexecdir}/libvirt_iohelper.exe +rm -rf $RPM_BUILD_ROOT%{mingw64_libexecdir}/libvirt_iohelper.exe +rm -rf $RPM_BUILD_ROOT%{mingw32_libexecdir}/libvirt-guests.sh +rm -rf $RPM_BUILD_ROOT%{mingw64_libexecdir}/libvirt-guests.sh + +%mingw_debug_install_post + +%endif + + %check # Building on slow archs, like emulated s390x in Fedora copr, requires # raising the test timeout @@ -2119,5 +2270,141 @@ exit 0 %{_datadir}/libvirt/api/libvirt-qemu-api.xml %{_datadir}/libvirt/api/libvirt-lxc-api.xml +%if %{with_mingw} +%files -n mingw32-libvirt +%dir %{mingw32_sysconfdir}/libvirt/ +%config(noreplace) %{mingw32_sysconfdir}/libvirt/libvirt.conf +%config(noreplace) %{mingw32_sysconfdir}/libvirt/libvirt-admin.conf + +%{mingw32_bindir}/libvirt-0.dll +%{mingw32_bindir}/virsh.exe +%{mingw32_bindir}/virt-admin.exe +%{mingw32_bindir}/virt-xml-validate +%{mingw32_bindir}/virt-pki-query-dn.exe +%{mingw32_bindir}/virt-pki-validate +%{mingw32_bindir}/libvirt-lxc-0.dll +%{mingw32_bindir}/libvirt-qemu-0.dll +%{mingw32_bindir}/libvirt-admin-0.dll + +%{mingw32_libdir}/libvirt.dll.a +%{mingw32_libdir}/pkgconfig/libvirt.pc +%{mingw32_libdir}/pkgconfig/libvirt-qemu.pc +%{mingw32_libdir}/pkgconfig/libvirt-lxc.pc +%{mingw32_libdir}/pkgconfig/libvirt-admin.pc +%{mingw32_libdir}/libvirt-lxc.dll.a +%{mingw32_libdir}/libvirt-qemu.dll.a +%{mingw32_libdir}/libvirt-admin.dll.a + +%dir %{mingw32_datadir}/libvirt/ +%dir %{mingw32_datadir}/libvirt/schemas/ +%{mingw32_datadir}/libvirt/schemas/*.rng + +%dir %{mingw32_datadir}/libvirt/api/ +%{mingw32_datadir}/libvirt/api/libvirt-api.xml +%{mingw32_datadir}/libvirt/api/libvirt-lxc-api.xml +%{mingw32_datadir}/libvirt/api/libvirt-qemu-api.xml +%{mingw32_datadir}/libvirt/api/libvirt-admin-api.xml + +%{mingw32_datadir}/libvirt/cpu_map/*.xml + +%{mingw32_datadir}/libvirt/test-screenshot.png + +%{mingw32_datadir}/locale/*/LC_MESSAGES/libvirt.mo + +%dir %{mingw32_includedir}/libvirt +%{mingw32_includedir}/libvirt/libvirt.h +%{mingw32_includedir}/libvirt/libvirt-common.h +%{mingw32_includedir}/libvirt/libvirt-domain.h +%{mingw32_includedir}/libvirt/libvirt-domain-checkpoint.h +%{mingw32_includedir}/libvirt/libvirt-domain-snapshot.h +%{mingw32_includedir}/libvirt/libvirt-event.h +%{mingw32_includedir}/libvirt/libvirt-host.h +%{mingw32_includedir}/libvirt/libvirt-interface.h +%{mingw32_includedir}/libvirt/libvirt-network.h +%{mingw32_includedir}/libvirt/libvirt-nodedev.h +%{mingw32_includedir}/libvirt/libvirt-nwfilter.h +%{mingw32_includedir}/libvirt/libvirt-secret.h +%{mingw32_includedir}/libvirt/libvirt-storage.h +%{mingw32_includedir}/libvirt/libvirt-stream.h +%{mingw32_includedir}/libvirt/virterror.h +%{mingw32_includedir}/libvirt/libvirt-lxc.h +%{mingw32_includedir}/libvirt/libvirt-qemu.h +%{mingw32_includedir}/libvirt/libvirt-admin.h + +%{mingw32_mandir}/man1/virsh.1* +%{mingw32_mandir}/man1/virt-admin.1* +%{mingw32_mandir}/man1/virt-xml-validate.1* +%{mingw32_mandir}/man1/virt-pki-query-dn.1* +%{mingw32_mandir}/man1/virt-pki-validate.1* +%{mingw32_mandir}/man7/virkey*.7* + + +%files -n mingw64-libvirt +%dir %{mingw64_sysconfdir}/libvirt/ +%config(noreplace) %{mingw64_sysconfdir}/libvirt/libvirt.conf +%config(noreplace) %{mingw64_sysconfdir}/libvirt/libvirt-admin.conf + +%{mingw64_bindir}/libvirt-0.dll +%{mingw64_bindir}/virsh.exe +%{mingw64_bindir}/virt-admin.exe +%{mingw64_bindir}/virt-xml-validate +%{mingw64_bindir}/virt-pki-query-dn.exe +%{mingw64_bindir}/virt-pki-validate +%{mingw64_bindir}/libvirt-lxc-0.dll +%{mingw64_bindir}/libvirt-qemu-0.dll +%{mingw64_bindir}/libvirt-admin-0.dll + +%{mingw64_libdir}/libvirt.dll.a +%{mingw64_libdir}/pkgconfig/libvirt.pc +%{mingw64_libdir}/pkgconfig/libvirt-qemu.pc +%{mingw64_libdir}/pkgconfig/libvirt-lxc.pc +%{mingw64_libdir}/pkgconfig/libvirt-admin.pc +%{mingw64_libdir}/libvirt-lxc.dll.a +%{mingw64_libdir}/libvirt-qemu.dll.a +%{mingw64_libdir}/libvirt-admin.dll.a + +%dir %{mingw64_datadir}/libvirt/ +%dir %{mingw64_datadir}/libvirt/schemas/ +%{mingw64_datadir}/libvirt/schemas/*.rng + +%dir %{mingw64_datadir}/libvirt/api/ +%{mingw64_datadir}/libvirt/api/libvirt-api.xml +%{mingw64_datadir}/libvirt/api/libvirt-lxc-api.xml +%{mingw64_datadir}/libvirt/api/libvirt-qemu-api.xml +%{mingw64_datadir}/libvirt/api/libvirt-admin-api.xml + +%{mingw64_datadir}/libvirt/cpu_map/*.xml + +%{mingw64_datadir}/libvirt/test-screenshot.png + +%{mingw64_datadir}/locale/*/LC_MESSAGES/libvirt.mo + +%dir %{mingw64_includedir}/libvirt +%{mingw64_includedir}/libvirt/libvirt.h +%{mingw64_includedir}/libvirt/libvirt-common.h +%{mingw64_includedir}/libvirt/libvirt-domain.h +%{mingw64_includedir}/libvirt/libvirt-domain-checkpoint.h +%{mingw64_includedir}/libvirt/libvirt-domain-snapshot.h +%{mingw64_includedir}/libvirt/libvirt-event.h +%{mingw64_includedir}/libvirt/libvirt-host.h +%{mingw64_includedir}/libvirt/libvirt-interface.h +%{mingw64_includedir}/libvirt/libvirt-network.h +%{mingw64_includedir}/libvirt/libvirt-nodedev.h +%{mingw64_includedir}/libvirt/libvirt-nwfilter.h +%{mingw64_includedir}/libvirt/libvirt-secret.h +%{mingw64_includedir}/libvirt/libvirt-storage.h +%{mingw64_includedir}/libvirt/libvirt-stream.h +%{mingw64_includedir}/libvirt/virterror.h +%{mingw64_includedir}/libvirt/libvirt-lxc.h +%{mingw64_includedir}/libvirt/libvirt-qemu.h +%{mingw64_includedir}/libvirt/libvirt-admin.h + +%{mingw64_mandir}/man1/virsh.1* +%{mingw64_mandir}/man1/virt-admin.1* +%{mingw64_mandir}/man1/virt-xml-validate.1* +%{mingw64_mandir}/man1/virt-pki-query-dn.1* +%{mingw64_mandir}/man1/virt-pki-validate.1* +%{mingw64_mandir}/man7/virkey*.7* +%endif %changelog diff --git a/meson.build b/meson.build index 2d1ae4091a..0b3187ad88 100644 --- a/meson.build +++ b/meson.build @@ -2161,22 +2161,15 @@ endforeach # generate dist files if git - spec_files = [ - 'libvirt.spec.in', - 'mingw-libvirt.spec.in', - ] - spec_conf = configuration_data({ 'VERSION': meson.project_version(), }) - foreach file : spec_files - configure_file( - input: file, - output: '@BASENAME@', - configuration: spec_conf, - ) - endforeach + configure_file( + input: 'libvirt.spec.in', + output: '@BASENAME@', + configuration: spec_conf, + ) authors = run_command(python3_prog, meson_gen_authors_prog.path(), env: runutf8, check: true) diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in deleted file mode 100644 index dbcb6d4b8f..0000000000 --- a/mingw-libvirt.spec.in +++ /dev/null @@ -1,327 +0,0 @@ -%{?mingw_package_header} - -# This spec file assumes you are building on a Fedora version -# that's still supported by the vendor. It may work on other distros -# or versions, but no effort will be made to ensure that going forward. -%define min_fedora 33 - -Name: mingw-libvirt -Version: @VERSION@ -Release: 1%{?dist} -Summary: MinGW Windows libvirt virtualization library - -License: LGPLv2+ -URL: https://libvirt.org/ - -%if %(echo %{version} | grep -q "\.0$"; echo $?) == 1 - %define mainturl stable_updates/ -%endif -Source: https://libvirt.org/sources/%{?mainturl}libvirt-%{version}.tar.xz - -BuildRequires: mingw32-filesystem >= 95 -BuildRequires: mingw64-filesystem >= 95 -BuildRequires: mingw32-gcc -BuildRequires: mingw64-gcc -BuildRequires: mingw32-binutils -BuildRequires: mingw64-binutils -BuildRequires: mingw32-glib2 >= 2.48 -BuildRequires: mingw64-glib2 >= 2.48 -BuildRequires: mingw32-libgpg-error -BuildRequires: mingw64-libgpg-error -BuildRequires: mingw32-libgcrypt -BuildRequires: mingw64-libgcrypt -BuildRequires: mingw32-gnutls -BuildRequires: mingw64-gnutls -BuildRequires: mingw32-gettext -BuildRequires: mingw64-gettext -BuildRequires: mingw32-libxml2 -BuildRequires: mingw64-libxml2 -BuildRequires: mingw32-portablexdr -BuildRequires: mingw64-portablexdr -BuildRequires: mingw32-dlfcn -BuildRequires: mingw64-dlfcn - -BuildRequires: pkgconfig -# Need native version for msgfmt -BuildRequires: gettext -BuildRequires: libxslt -BuildRequires: python3 -BuildRequires: perl-interpreter -BuildRequires: perl(Getopt::Long) -BuildRequires: meson -BuildRequires: ninja-build -BuildRequires: python3-docutils - -BuildRequires: mingw32-libssh2 -BuildRequires: mingw64-libssh2 -BuildRequires: mingw32-curl -BuildRequires: mingw64-curl -BuildRequires: cpp -%if 0%{?fedora} || 0%{?rhel} > 7 -BuildRequires: rpcgen -%endif - -BuildArch: noarch - -%description -MinGW Windows libvirt virtualization library. - -# Mingw32 -%package -n mingw32-libvirt -Summary: %{summary} -Obsoletes: mingw32-libvirt-static < 7.0.0 - -%description -n mingw32-libvirt -MinGW Windows libvirt virtualization library. - -# Mingw64 -%package -n mingw64-libvirt -Summary: %{summary} -Obsoletes: mingw64-libvirt-static < 7.0.0 - -%description -n mingw64-libvirt -MinGW Windows libvirt virtualization library. - -%{?mingw_debug_package} - - -%prep -%setup -q -n libvirt-%{version} - -%build -%if 0%{?fedora} >= %{min_fedora} - %define supported_platform 1 -%else - %define supported_platform 0 -%endif - -%if ! %{supported_platform} -echo "This RPM requires Fedora >= %{min_fedora}" -exit 1 -%endif - -%mingw_meson \ - --auto-features=enabled \ - -Ddriver_remote=enabled \ - -Ddriver_test=enabled \ - -Ddriver_esx=enabled \ - -Dcurl=enabled \ - -Ddocs=enabled \ - -Dapparmor=disabled \ - -Dapparmor_profiles=disabled \ - -Dattr=disabled \ - -Daudit=disabled \ - -Dbash_completion=disabled \ - -Dblkid=disabled \ - -Dcapng=disabled \ - -Ddriver_bhyve=disabled \ - -Ddriver_hyperv=disabled \ - -Ddriver_interface=disabled \ - -Ddriver_libvirtd=disabled \ - -Ddriver_libxl=disabled \ - -Ddriver_lxc=disabled \ - -Ddriver_network=disabled \ - -Ddriver_openvz=disabled \ - -Ddriver_qemu=disabled \ - -Ddriver_secrets=disabled \ - -Ddriver_vbox=disabled \ - -Ddriver_vmware=disabled \ - -Ddriver_vz=disabled \ - -Ddtrace=disabled \ - -Dexpensive_tests=enabled \ - -Dfirewalld=disabled \ - -Dfirewalld_zone=disabled \ - -Dfuse=disabled \ - -Dglusterfs=disabled \ - -Dhost_validate=disabled \ - -Dlibiscsi=disabled \ - -Dlibnl=disabled \ - -Dlibpcap=disabled \ - -Dlibssh2=disabled \ - -Dlibssh=disabled \ - -Dlogin_shell=disabled \ - -Dnetcf=disabled \ - -Dnls=disabled \ - -Dnss=disabled \ - -Dnumactl=disabled \ - -Dnumad=disabled \ - -Dopenwsman=disabled \ - -Dpciaccess=disabled \ - -Dpm_utils=disabled \ - -Dpolkit=disabled \ - -Dreadline=disabled \ - -Drpath=disabled \ - -Dsanlock=disabled \ - -Dsasl=disabled \ - -Dsecdriver_apparmor=disabled \ - -Dsecdriver_selinux=disabled \ - -Dselinux=disabled \ - -Dstorage_dir=disabled \ - -Dstorage_disk=disabled \ - -Dstorage_fs=disabled \ - -Dstorage_gluster=disabled \ - -Dstorage_iscsi_direct=disabled \ - -Dstorage_iscsi=disabled \ - -Dstorage_lvm=disabled \ - -Dstorage_mpath=disabled \ - -Dstorage_rbd=disabled \ - -Dstorage_scsi=disabled \ - -Dstorage_sheepdog=disabled \ - -Dstorage_vstorage=disabled \ - -Dstorage_zfs=disabled \ - -Dsysctl_config=disabled \ - -Dtests=disabled \ - -Dudev=disabled \ - -Dwireshark_dissector=disabled \ - -Dyajl=disabled -%mingw_ninja - -%install -%mingw_ninja_install - -rm -rf $RPM_BUILD_ROOT%{mingw32_sysconfdir}/libvirt/nwfilter -rm -rf $RPM_BUILD_ROOT%{mingw64_sysconfdir}/libvirt/nwfilter -rm -rf $RPM_BUILD_ROOT%{mingw32_datadir}/doc/* -rm -rf $RPM_BUILD_ROOT%{mingw64_datadir}/doc/* -rm -rf $RPM_BUILD_ROOT%{mingw32_datadir}/gtk-doc/* -rm -rf $RPM_BUILD_ROOT%{mingw64_datadir}/gtk-doc/* - -rm -rf $RPM_BUILD_ROOT%{mingw32_libexecdir}/libvirt_iohelper.exe -rm -rf $RPM_BUILD_ROOT%{mingw64_libexecdir}/libvirt_iohelper.exe -rm -rf $RPM_BUILD_ROOT%{mingw32_libexecdir}/libvirt-guests.sh -rm -rf $RPM_BUILD_ROOT%{mingw64_libexecdir}/libvirt-guests.sh - - -# Mingw32 -%files -n mingw32-libvirt -%dir %{mingw32_sysconfdir}/libvirt/ -%config(noreplace) %{mingw32_sysconfdir}/libvirt/libvirt.conf -%config(noreplace) %{mingw32_sysconfdir}/libvirt/libvirt-admin.conf - -%{mingw32_bindir}/libvirt-0.dll -%{mingw32_bindir}/virsh.exe -%{mingw32_bindir}/virt-admin.exe -%{mingw32_bindir}/virt-xml-validate -%{mingw32_bindir}/virt-pki-validate -%{mingw32_bindir}/libvirt-lxc-0.dll -%{mingw32_bindir}/libvirt-qemu-0.dll -%{mingw32_bindir}/libvirt-admin-0.dll - -%{mingw32_libdir}/libvirt.dll.a -%{mingw32_libdir}/pkgconfig/libvirt.pc -%{mingw32_libdir}/pkgconfig/libvirt-qemu.pc -%{mingw32_libdir}/pkgconfig/libvirt-lxc.pc -%{mingw32_libdir}/pkgconfig/libvirt-admin.pc -%{mingw32_libdir}/libvirt-lxc.dll.a -%{mingw32_libdir}/libvirt-qemu.dll.a -%{mingw32_libdir}/libvirt-admin.dll.a - -%dir %{mingw32_datadir}/libvirt/ -%dir %{mingw32_datadir}/libvirt/schemas/ -%{mingw32_datadir}/libvirt/schemas/*.rng - -%dir %{mingw32_datadir}/libvirt/api/ -%{mingw32_datadir}/libvirt/api/libvirt-api.xml -%{mingw32_datadir}/libvirt/api/libvirt-lxc-api.xml -%{mingw32_datadir}/libvirt/api/libvirt-qemu-api.xml -%{mingw32_datadir}/libvirt/api/libvirt-admin-api.xml - -%{mingw32_datadir}/libvirt/cpu_map/*.xml - -%{mingw32_datadir}/libvirt/test-screenshot.png - -%{mingw32_datadir}/locale/*/LC_MESSAGES/libvirt.mo - -%dir %{mingw32_includedir}/libvirt -%{mingw32_includedir}/libvirt/libvirt.h -%{mingw32_includedir}/libvirt/libvirt-common.h -%{mingw32_includedir}/libvirt/libvirt-domain.h -%{mingw32_includedir}/libvirt/libvirt-domain-checkpoint.h -%{mingw32_includedir}/libvirt/libvirt-domain-snapshot.h -%{mingw32_includedir}/libvirt/libvirt-event.h -%{mingw32_includedir}/libvirt/libvirt-host.h -%{mingw32_includedir}/libvirt/libvirt-interface.h -%{mingw32_includedir}/libvirt/libvirt-network.h -%{mingw32_includedir}/libvirt/libvirt-nodedev.h -%{mingw32_includedir}/libvirt/libvirt-nwfilter.h -%{mingw32_includedir}/libvirt/libvirt-secret.h -%{mingw32_includedir}/libvirt/libvirt-storage.h -%{mingw32_includedir}/libvirt/libvirt-stream.h -%{mingw32_includedir}/libvirt/virterror.h -%{mingw32_includedir}/libvirt/libvirt-lxc.h -%{mingw32_includedir}/libvirt/libvirt-qemu.h -%{mingw32_includedir}/libvirt/libvirt-admin.h - -%{mingw32_mandir}/man1/virsh.1* -%{mingw32_mandir}/man1/virt-admin.1* -%{mingw32_mandir}/man1/virt-xml-validate.1* -%{mingw32_mandir}/man1/virt-pki-validate.1* -%{mingw32_mandir}/man7/virkey*.7* - -# Mingw64 -%files -n mingw64-libvirt -%dir %{mingw64_sysconfdir}/libvirt/ -%config(noreplace) %{mingw64_sysconfdir}/libvirt/libvirt.conf -%config(noreplace) %{mingw64_sysconfdir}/libvirt/libvirt-admin.conf - -%{mingw64_bindir}/libvirt-0.dll -%{mingw64_bindir}/virsh.exe -%{mingw64_bindir}/virt-admin.exe -%{mingw64_bindir}/virt-xml-validate -%{mingw64_bindir}/virt-pki-validate -%{mingw64_bindir}/libvirt-lxc-0.dll -%{mingw64_bindir}/libvirt-qemu-0.dll -%{mingw64_bindir}/libvirt-admin-0.dll - -%{mingw64_libdir}/libvirt.dll.a -%{mingw64_libdir}/pkgconfig/libvirt.pc -%{mingw64_libdir}/pkgconfig/libvirt-qemu.pc -%{mingw64_libdir}/pkgconfig/libvirt-lxc.pc -%{mingw64_libdir}/pkgconfig/libvirt-admin.pc -%{mingw64_libdir}/libvirt-lxc.dll.a -%{mingw64_libdir}/libvirt-qemu.dll.a -%{mingw64_libdir}/libvirt-admin.dll.a - -%dir %{mingw64_datadir}/libvirt/ -%dir %{mingw64_datadir}/libvirt/schemas/ -%{mingw64_datadir}/libvirt/schemas/*.rng - -%dir %{mingw64_datadir}/libvirt/api/ -%{mingw64_datadir}/libvirt/api/libvirt-api.xml -%{mingw64_datadir}/libvirt/api/libvirt-lxc-api.xml -%{mingw64_datadir}/libvirt/api/libvirt-qemu-api.xml -%{mingw64_datadir}/libvirt/api/libvirt-admin-api.xml - -%{mingw64_datadir}/libvirt/cpu_map/*.xml - -%{mingw64_datadir}/libvirt/test-screenshot.png - -%{mingw64_datadir}/locale/*/LC_MESSAGES/libvirt.mo - -%dir %{mingw64_includedir}/libvirt -%{mingw64_includedir}/libvirt/libvirt.h -%{mingw64_includedir}/libvirt/libvirt-common.h -%{mingw64_includedir}/libvirt/libvirt-domain.h -%{mingw64_includedir}/libvirt/libvirt-domain-checkpoint.h -%{mingw64_includedir}/libvirt/libvirt-domain-snapshot.h -%{mingw64_includedir}/libvirt/libvirt-event.h -%{mingw64_includedir}/libvirt/libvirt-host.h -%{mingw64_includedir}/libvirt/libvirt-interface.h -%{mingw64_includedir}/libvirt/libvirt-network.h -%{mingw64_includedir}/libvirt/libvirt-nodedev.h -%{mingw64_includedir}/libvirt/libvirt-nwfilter.h -%{mingw64_includedir}/libvirt/libvirt-secret.h -%{mingw64_includedir}/libvirt/libvirt-storage.h -%{mingw64_includedir}/libvirt/libvirt-stream.h -%{mingw64_includedir}/libvirt/virterror.h -%{mingw64_includedir}/libvirt/libvirt-lxc.h -%{mingw64_includedir}/libvirt/libvirt-qemu.h -%{mingw64_includedir}/libvirt/libvirt-admin.h - -%{mingw64_mandir}/man1/virsh.1* -%{mingw64_mandir}/man1/virt-admin.1* -%{mingw64_mandir}/man1/virt-xml-validate.1* -%{mingw64_mandir}/man1/virt-pki-validate.1* -%{mingw64_mandir}/man7/virkey*.7* - -%changelog -- 2.37.1

2 6

[PATCH for 8.7.0 00/80] Remove pre-blockdev disk setup code
by Peter Krempa 09 Aug '22

09 Aug '22

Starting with libvirt-8.7.0 we'll support qemu-4.2 as minimum and thus we'll only use -blockdev now. Remove the old cruft. This series applies on top of the patches bumping minimum qemu version to qemu-4.2 I've posted earlier. The whole branch can be fetched at: git fetch https://gitlab.com/pipo.sk/libvirt.git blockdev-remove-2 Peter Krempa (80): qemu: Allways assume QEMU_CAPS_CHANGE_BACKING_FILE qemu: capabilities: Retire QEMU_CAPS_CHANGE_BACKING_FILE qemu: Always assume support for QEMU_CAPS_ACTIVE_COMMIT qemu: capabilities: Retire QEMU_CAPS_ACTIVE_COMMIT qemu: Always assume support for QEMU_CAPS_GLUSTER_DEBUG_LEVEL qemu: capabilities: Retire QEMU_CAPS_GLUSTER_DEBUG_LEVEL qemu: Always assume support for QEMU_CAPS_DRIVE_DISCARD and QEMU_CAPS_DRIVE_DETECT_ZEROES qemu: capabilities: Retire QEMU_CAPS_DRIVE_DISCARD and QEMU_CAPS_DRIVE_DETECT_ZEROES qemuxml2argvtest: Use DO_TEST_CAPS_LATEST for all 'user-aliases' tests qemuxml2xmltest: Modernize all test cases using QEMU_CAPS_QCOW2_LUKS qemu: Always assume support for QEMU_CAPS_QCOW2_LUKS qemu: capabilities: Retire QEMU_CAPS_QCOW2_LUKS qemu: capabilities: Unconditionally set QEMU_CAPS_BLOCKDEV/QEMU_CAPS_BLOCKDEV_HOSTDEV_SCSI tests: Force QEMU_CAPS_BLOCKDEV(_HOSTDEV_SCSI) in fake caps tests qemu: Refactor access to 'qomName' field of the qemu disk private data qemu: command: Always assume support for QEMU_CAPS_SCSI_DISK_DEVICE_ID qemu: capabilities: Retire capabilities used for -blockdev detection qemu: Remove code conditional on QEMU_CAPS_BLOCKDEV_HOSTDEV_SCSI qemu: capabilities: Retire QEMU_CAPS_BLOCKDEV_HOSTDEV_SCSI qemu: block: Remove legacy spellings for InetSocketAddress qemu: migration: Remove pre-blockdev code paths qemuMigrationSrcNBDStorageCopyBlockdev: Remove some arguments qemu: migration: Assume support for QEMU_CAPS_BLOCKDEV_DEL qemu: capabilities: Retire QEMU_CAPS_BLOCKDEV_DEL qemu: snapshot: Remove pre-blockdev code paths qemu: Remove unused code for pre-blockdev disk snapshot monitor interaction qemu: block: Remove pre-blockdev code paths qemu: migration_cookie: Remove pre-blockdev code paths qemu: validate: Remove impossible validation checks qemu: process: Remove pre-blockdev code paths qemu: blockjob: Remove legacy block job completion code qemu: Remove legacy block job event processing handler qemu: monitor: Remove infrastructure for BLOCK_JOB_* events qemuDomainSetBlockThreshold: Remove pre-blockdev node name detection qemu: block: Remove 'qemuBlockNodeNamesDetect' and related infrastructure qemu: blockjob: Remove pre-blockdev blockjob setup qemu: alias: Remove check for QEMU_CAPS_BLOCKDEV qemuDomainGetStatsBlock: Remove pre-blockdev code paths qemu: block: Remove unused qemuBlockGetNodeData qemu: monitor: Remove unused qemuMonitorQueryNamedBlockNodes and clean up qemu: driver: Remove pre-blockdev code paths from qemuDomainBlockCopyCommon qemu: monitor: Remove unused qemuMonitorDriveMirror qemu: driver: Remove pre-blockdev code paths from qemuDomainBlockCommit qemu: monitor: Remove unused arguments of qemuMonitorBlockCommit qemu: driver: Remove pre-blockdev code paths from qemuDomainBlockPullCommon qemu: monitor: Remove unused arguments of qemuMonitorBlockStream qemu: monitor: Remove unused qemuMonitorDiskNameLookup qemu: driver: Remove pre-blockdev code paths from qemuDomainBlockPivot qemu: monitor: Remove unused qemuMonitorDrivePivot qemu: command: Remove pre-blockdev floppy setup qemu: Remove pre-blockdev PFLASH setup qemuDomainBlockResize: Always refuse resize of empty/readonly disks qemuDomainBlocksStatsGather: Remove pre-blockdev code paths qemu: monitor: Remove unused qemuMonitorBlockStatsUpdateCapacity qemu: driver: Remove remaining QEMU_CAPS_BLOCKDEV capability checks qemu: hotplug: Remove pre-blockdev code path from qemuDomainChangeEjectableMedia qemu: monitor: Remove unused qemuMonitor(Eject|Change)Media qemuhotplugtest: Switch to -blockdev mode qemuDomainRemoveDiskDevice: Remove special casing for disks on 'sd' bus qemu: hotplug: Remove pre-blockdev code paths qemu: block: Remove unused qemuBlockStorageSourceChainDetachPrepareLegacy qemu: Remove 'driveAlias' argument of qemuBlockStorageSourceDetachPrepare qemu: block: Remove support for legacy disk hotplug/unplug qemu: monitor: Remove unused qemuMonitorAddDrive/qemuMonitorDriveDel qemu: command: Delegate qemuBuildDriveStr to SD cards only qemu: command: Generate -drive for SD cards via JSON props qemu: command: Remove unused qemuGetDriveSourceString qemu: domain: Assume QEMU_CAPS_BLOCKDEV for the domain private code qemuDomainSecretStorageSourcePrepare: Remove cabapbility check when preparing cookies qemuDomainDiskBlockJobIsSupported: Assume QEMU_CAPS_BLOCKDEV is supported qemuDomainDiskGetBackendAlias: Assume QEMU_CAPS_BLOCKDEV is supported qemuDomainValidateStorageSource: Remove QEMU_CAPS_BLOCKDEV validation qemuDomainValidateStorageSource: Remove 'maskBlockdev' argument qemuDomainDetermineDiskChain: Assume QEMU_CAPS_BLOCKDEV qemu: Retire QEMU_CAPS_BLOCKDEV qemu: Setup disk throttling for SD cards via monitor qemu: capabilities: Retire QEMU_CAPS_QUERY_NAMED_BLOCK_NODES qemu: Assume support and retire QEMU_CAPS_BLOCK_WRITE_THRESHOLD qemu: Assume and retire QEMU_CAPS_BLOCKDEV_BACKUP qemuDomainDetermineDiskChain: Remove 'report_broken' argument src/qemu/qemu_alias.c | 10 +- src/qemu/qemu_alias.h | 5 +- src/qemu/qemu_backup.c | 10 +- src/qemu/qemu_block.c | 461 +----------- src/qemu/qemu_block.h | 27 +- src/qemu/qemu_blockjob.c | 170 +---- src/qemu/qemu_capabilities.c | 67 +- src/qemu/qemu_capabilities.h | 30 +- src/qemu/qemu_checkpoint.c | 2 +- src/qemu/qemu_command.c | 655 ++--------------- src/qemu/qemu_command.h | 4 - src/qemu/qemu_domain.c | 195 ++--- src/qemu/qemu_domain.h | 14 +- src/qemu/qemu_driver.c | 564 ++++----------- src/qemu/qemu_hotplug.c | 118 +-- src/qemu/qemu_migration.c | 147 +--- src/qemu/qemu_migration_cookie.c | 19 +- src/qemu/qemu_monitor.c | 184 +---- src/qemu/qemu_monitor.h | 62 -- src/qemu/qemu_monitor_json.c | 447 +----------- src/qemu/qemu_monitor_json.h | 53 -- src/qemu/qemu_monitor_text.c | 82 --- src/qemu/qemu_monitor_text.h | 6 - src/qemu/qemu_process.c | 209 +----- src/qemu/qemu_snapshot.c | 125 +--- src/qemu/qemu_validate.c | 34 +- tests/domaincapsdata/qemu_4.2.0.ppc64.xml | 2 +- tests/qemublocktest.c | 4 +- .../caps_4.2.0.aarch64.xml | 15 - .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 11 - .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 15 - .../caps_4.2.0.x86_64.xml | 15 - .../caps_5.0.0.aarch64.xml | 15 - .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 15 - .../caps_5.0.0.riscv64.xml | 15 - .../caps_5.0.0.x86_64.xml | 15 - .../qemucapabilitiesdata/caps_5.1.0.sparc.xml | 15 - .../caps_5.1.0.x86_64.xml | 15 - .../caps_5.2.0.aarch64.xml | 15 - .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 15 - .../caps_5.2.0.riscv64.xml | 15 - .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 15 - .../caps_5.2.0.x86_64.xml | 15 - .../caps_6.0.0.aarch64.xml | 15 - .../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 15 - .../caps_6.0.0.x86_64.xml | 15 - .../caps_6.1.0.x86_64.xml | 15 - .../caps_6.2.0.aarch64.xml | 15 - .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 15 - .../caps_6.2.0.x86_64.xml | 15 - .../caps_7.0.0.aarch64.xml | 15 - .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml | 15 - .../caps_7.0.0.x86_64.xml | 15 - .../caps_7.1.0.x86_64.xml | 15 - tests/qemuhotplugtest.c | 76 +- .../qemuhotplug-base-ccw-live+ccw-virtio.xml | 2 +- ...with-2-ccw-virtio+ccw-virtio-1-reverse.xml | 4 +- ...otplug-base-ccw-live-with-2-ccw-virtio.xml | 2 +- ...-with-ccw-virtio+ccw-virtio-2-explicit.xml | 2 +- ...-ccw-live-with-ccw-virtio+ccw-virtio-2.xml | 2 +- .../qemuhotplug-base-live+cdrom-scsi.xml | 2 +- .../qemuhotplug-base-live+cdrom-usb.xml | 2 +- ...uhotplug-base-live+disk-scsi-multipath.xml | 2 +- ...+disk-scsi-wwn+disk-scsi-duplicate-wwn.xml | 2 +- .../qemuhotplug-base-live+disk-scsi.xml | 2 +- .../qemuhotplug-base-live+disk-usb.xml | 2 +- .../qemuhotplug-base-live+disk-virtio.xml | 2 +- ...thout-scsi-controller-live+disk-scsi-2.xml | 2 +- ...monitorjson-nodename-basic-blockstats.json | 166 ----- ...onitorjson-nodename-basic-named-nodes.json | 268 ------- .../qemumonitorjson-nodename-basic.result | 16 - ...itorjson-nodename-blockjob-blockstats.json | 301 -------- ...torjson-nodename-blockjob-named-nodes.json | 682 ------------------ .../qemumonitorjson-nodename-blockjob.result | 26 - ...monitorjson-nodename-empty-blockstats.json | 2 - ...onitorjson-nodename-empty-named-nodes.json | 2 - .../qemumonitorjson-nodename-empty.result | 0 ...nitorjson-nodename-gluster-blockstats.json | 111 --- ...itorjson-nodename-gluster-named-nodes.json | 135 ---- .../qemumonitorjson-nodename-gluster.result | 11 - ...monitorjson-nodename-iscsi-blockstats.json | 113 --- ...onitorjson-nodename-iscsi-named-nodes.json | 114 --- .../qemumonitorjson-nodename-iscsi.result | 13 - ...umonitorjson-nodename-luks-blockstats.json | 58 -- ...monitorjson-nodename-luks-named-nodes.json | 109 --- .../qemumonitorjson-nodename-luks.result | 6 - ...mumonitorjson-nodename-old-blockstats.json | 160 ---- ...umonitorjson-nodename-old-named-nodes.json | 2 - .../qemumonitorjson-nodename-old.result | 0 ...itorjson-nodename-relative-blockstats.json | 329 --------- ...torjson-nodename-relative-named-nodes.json | 554 -------------- .../qemumonitorjson-nodename-relative.result | 33 - ...json-nodename-same-backing-blockstats.json | 221 ------ ...son-nodename-same-backing-named-nodes.json | 316 -------- ...mumonitorjson-nodename-same-backing.result | 23 - tests/qemumonitorjsontest.c | 105 +-- .../blockjob-mirror-in.xml | 1 + .../migration-in-params-in.xml | 1 + .../migration-out-nbd-out.xml | 1 + .../migration-out-nbd-tls-out.xml | 1 + .../migration-out-params-in.xml | 1 + tests/qemustatusxml2xmldata/upgrade-out.xml | 1 + .../qemustatusxml2xmldata/vcpus-multi-in.xml | 1 + .../aarch64-aavmf-virtio-mmio.args | 5 +- .../aarch64-cpu-passthrough.args | 5 +- .../aarch64-kvm-32-on-64.args | 5 +- .../aarch64-virt-2.6-virtio-pci-default.args | 5 +- .../qemuxml2argvdata/aarch64-virt-virtio.args | 5 +- .../aarch64-virtio-pci-default.args | 5 +- .../aarch64-virtio-pci-manual-addresses.args | 5 +- .../arm-vexpressa9-virtio.args | 5 +- tests/qemuxml2argvdata/arm-virt-virtio.args | 5 +- tests/qemuxml2argvdata/audio-default-sdl.args | 5 +- .../qemuxml2argvdata/audio-default-spice.args | 5 +- tests/qemuxml2argvdata/audio-default-vnc.args | 5 +- tests/qemuxml2argvdata/autoindex.args | 5 +- .../qemuxml2argvdata/balloon-device-auto.args | 5 +- .../balloon-device-deflate-off.args | 5 +- .../balloon-device-deflate.args | 5 +- .../balloon-device-period.args | 5 +- tests/qemuxml2argvdata/balloon-device.args | 5 +- tests/qemuxml2argvdata/blkiotune-device.args | 5 +- tests/qemuxml2argvdata/blkiotune.args | 5 +- tests/qemuxml2argvdata/boot-cdrom.args | 5 +- tests/qemuxml2argvdata/boot-complex.args | 35 +- tests/qemuxml2argvdata/boot-floppy-q35.args | 6 +- tests/qemuxml2argvdata/boot-floppy.args | 10 +- .../boot-menu-disable-drive.args | 5 +- tests/qemuxml2argvdata/boot-menu-disable.args | 5 +- .../boot-menu-enable-with-timeout.args | 5 +- tests/qemuxml2argvdata/boot-menu-enable.args | 5 +- tests/qemuxml2argvdata/boot-multi.args | 5 +- tests/qemuxml2argvdata/boot-network.args | 5 +- tests/qemuxml2argvdata/boot-order.args | 20 +- tests/qemuxml2argvdata/channel-guestfwd.args | 5 +- tests/qemuxml2argvdata/channel-spicevmc.args | 5 +- .../qemuxml2argvdata/channel-virtio-auto.args | 5 +- .../channel-virtio-autoadd.args | 5 +- .../channel-virtio-autoassign.args | 5 +- .../channel-virtio-default.args | 5 +- .../channel-virtio-state.args | 5 +- .../qemuxml2argvdata/channel-virtio-unix.args | 5 +- tests/qemuxml2argvdata/channel-virtio.args | 5 +- tests/qemuxml2argvdata/clock-catchup.args | 5 +- tests/qemuxml2argvdata/clock-france.args | 5 +- tests/qemuxml2argvdata/clock-hpet-off.args | 5 +- .../clock-localtime-basis-localtime.args | 5 +- tests/qemuxml2argvdata/clock-localtime.args | 5 +- tests/qemuxml2argvdata/clock-realtime.args | 5 +- tests/qemuxml2argvdata/clock-utc.args | 5 +- tests/qemuxml2argvdata/clock-variable.args | 5 +- .../qemuxml2argvdata/console-compat-auto.args | 5 +- .../console-compat-chardev.args | 5 +- tests/qemuxml2argvdata/console-compat.args | 5 +- .../qemuxml2argvdata/console-virtio-ccw.args | 5 +- .../qemuxml2argvdata/console-virtio-many.args | 5 +- tests/qemuxml2argvdata/console-virtio.args | 5 +- tests/qemuxml2argvdata/controller-order.args | 10 +- .../cpu-host-passthrough-features.args | 5 +- .../qemuxml2argvdata/cputune-zero-shares.args | 5 +- tests/qemuxml2argvdata/cputune.args | 5 +- tests/qemuxml2argvdata/disk-nvme.xml | 5 +- .../qemuxml2argvdata/encrypted-disk-usage.xml | 5 +- .../firmware-manual-efi-acpi-aarch64.args | 8 +- .../firmware-manual-efi-acpi-q35.args | 8 +- .../firmware-manual-efi-noacpi-aarch64.args | 8 +- .../firmware-manual-efi-secure.args | 8 +- .../qemuxml2argvdata/firmware-manual-efi.args | 8 +- .../qemuxml2argvdata/graphics-dbus-audio.args | 5 +- .../graphics-egl-headless.args | 5 +- .../graphics-sdl-fullscreen.args | 5 +- tests/qemuxml2argvdata/graphics-sdl.args | 5 +- .../hostdev-scsi-vhost-scsi-ccw.args | 5 +- .../hostdev-scsi-vhost-scsi-pci.args | 5 +- .../hostdev-vfio-multidomain.args | 5 +- tests/qemuxml2argvdata/hostdev-vfio.args | 5 +- .../qemuxml2argvdata/hugepages-memaccess.args | 5 +- .../hugepages-memaccess2.args | 5 +- tests/qemuxml2argvdata/hugepages-shared.args | 5 +- .../hvf-aarch64-virt-headless.args | 13 +- .../hvf-x86_64-q35-headless.args | 5 +- .../qemuxml2argvdata/input-usbmouse-addr.args | 5 +- tests/qemuxml2argvdata/input-usbmouse.args | 5 +- tests/qemuxml2argvdata/input-usbtablet.args | 5 +- tests/qemuxml2argvdata/input-virtio-ccw.args | 5 +- .../iothreads-disk-virtio-ccw.args | 10 +- tests/qemuxml2argvdata/iothreads-disk.args | 15 +- .../iothreads-ids-partial.args | 5 +- tests/qemuxml2argvdata/iothreads-ids.args | 5 +- tests/qemuxml2argvdata/iothreads.args | 5 +- tests/qemuxml2argvdata/kvm-pit-delay.args | 5 +- tests/qemuxml2argvdata/kvm-pit-discard.args | 5 +- .../machine-aeskeywrap-off-cap.args | 5 +- .../machine-aeskeywrap-off-caps.args | 5 +- .../machine-aeskeywrap-on-cap.args | 5 +- .../machine-aeskeywrap-on-caps.args | 5 +- tests/qemuxml2argvdata/machine-aliases1.args | 5 +- tests/qemuxml2argvdata/machine-aliases2.args | 5 +- tests/qemuxml2argvdata/machine-core-off.args | 5 +- tests/qemuxml2argvdata/machine-core-on.args | 5 +- .../machine-deakeywrap-off-cap.args | 5 +- .../machine-deakeywrap-off-caps.args | 5 +- .../machine-deakeywrap-on-cap.args | 5 +- .../machine-deakeywrap-on-caps.args | 5 +- .../machine-keywrap-none-caps.args | 5 +- .../machine-keywrap-none.args | 5 +- ...ine-loadparm-multiple-disks-nets-s390.args | 10 +- .../machine-loadparm-s390.args | 5 +- .../qemuxml2argvdata/machine-vmport-opt.args | 5 +- tests/qemuxml2argvdata/master-key.args | 5 +- .../memory-hotplug-dimm-addr.args | 5 +- .../qemuxml2argvdata/memory-hotplug-dimm.args | 5 +- tests/qemuxml2argvdata/memory-hotplug.args | 5 +- tests/qemuxml2argvdata/memtune-unlimited.args | 5 +- tests/qemuxml2argvdata/memtune.args | 5 +- tests/qemuxml2argvdata/migrate.args | 5 +- tests/qemuxml2argvdata/minimal.args | 5 +- tests/qemuxml2argvdata/misc-acpi.args | 5 +- tests/qemuxml2argvdata/misc-disable-s3.args | 5 +- .../misc-disable-suspends.args | 5 +- tests/qemuxml2argvdata/misc-enable-s4.args | 5 +- tests/qemuxml2argvdata/misc-uuid.args | 5 +- tests/qemuxml2argvdata/monitor-json.args | 5 +- .../multifunction-pci-device.args | 5 +- tests/qemuxml2argvdata/net-client.args | 5 +- tests/qemuxml2argvdata/net-eth-hostip.args | 5 +- tests/qemuxml2argvdata/net-eth-ifname.args | 5 +- tests/qemuxml2argvdata/net-eth-names.args | 5 +- .../net-eth-unmanaged-tap.args | 5 +- tests/qemuxml2argvdata/net-eth.args | 5 +- .../net-hostdev-bootorder.args | 5 +- .../net-hostdev-multidomain.args | 5 +- .../net-hostdev-vfio-multidomain.args | 5 +- tests/qemuxml2argvdata/net-hostdev-vfio.args | 5 +- tests/qemuxml2argvdata/net-hostdev.args | 5 +- tests/qemuxml2argvdata/net-mcast.args | 5 +- tests/qemuxml2argvdata/net-server.args | 5 +- tests/qemuxml2argvdata/net-udp.args | 5 +- tests/qemuxml2argvdata/net-user-addr.args | 5 +- tests/qemuxml2argvdata/net-user.args | 5 +- .../net-vhostuser-multiq.args | 5 +- tests/qemuxml2argvdata/net-virtio-device.args | 5 +- .../net-virtio-disable-offloads.args | 5 +- tests/qemuxml2argvdata/net-virtio-netdev.args | 5 +- .../net-virtio-rxtxqueuesize.args | 5 +- .../net-virtio-teaming-hostdev.args | 5 +- .../qemuxml2argvdata/net-virtio-teaming.args | 5 +- tests/qemuxml2argvdata/net-virtio.args | 5 +- tests/qemuxml2argvdata/nosharepages.args | 5 +- .../numad-auto-memory-vcpu-cpuset.args | 5 +- ...o-memory-vcpu-no-cpuset-and-placement.args | 5 +- .../numad-auto-vcpu-static-numatune.args | 5 +- .../numad-static-memory-auto-vcpu.args | 5 +- tests/qemuxml2argvdata/numad.args | 5 +- .../numatune-auto-nodeset-invalid.args | 5 +- tests/qemuxml2argvdata/numatune-memory.args | 5 +- .../parallel-parport-chardev.args | 5 +- .../parallel-tcp-chardev.args | 5 +- tests/qemuxml2argvdata/pci-autoadd-addr.args | 5 +- tests/qemuxml2argvdata/pci-autoadd-idx.args | 5 +- tests/qemuxml2argvdata/pci-autofill-addr.args | 5 +- .../pci-bridge-many-disks.args | 525 ++++++++------ tests/qemuxml2argvdata/pci-bridge.args | 5 +- tests/qemuxml2argvdata/pci-many.args | 145 ++-- tests/qemuxml2argvdata/pci-rom.args | 5 +- .../pci-serial-dev-chardev.args | 5 +- tests/qemuxml2argvdata/pcie-expander-bus.args | 5 +- tests/qemuxml2argvdata/pcie-root-port.args | 5 +- .../pcie-switch-downstream-port.args | 5 +- .../pcie-switch-upstream-port.args | 5 +- tests/qemuxml2argvdata/pcihole64-q35.args | 5 +- .../pseries-vio-user-assigned.args | 5 +- tests/qemuxml2argvdata/pseries-vio.args | 5 +- tests/qemuxml2argvdata/q35-pcie-autoadd.args | 5 +- tests/qemuxml2argvdata/q35-pcie.args | 5 +- tests/qemuxml2argvdata/q35-usb2-multi.args | 5 +- tests/qemuxml2argvdata/q35-usb2-reorder.args | 5 +- tests/qemuxml2argvdata/q35-usb2.args | 5 +- .../q35-virt-manager-basic.args | 5 +- tests/qemuxml2argvdata/q35-virtio-pci.args | 5 +- tests/qemuxml2argvdata/q35.args | 5 +- tests/qemuxml2argvdata/qemu-ns-alt.args | 5 +- .../qemu-ns-commandline-ns0.args | 5 +- .../qemu-ns-commandline-ns1.args | 5 +- .../qemuxml2argvdata/qemu-ns-commandline.args | 5 +- .../qemu-ns-domain-commandline-ns0.args | 5 +- .../qemu-ns-domain-commandline.args | 5 +- .../qemuxml2argvdata/qemu-ns-domain-ns0.args | 5 +- tests/qemuxml2argvdata/qemu-ns-no-env.args | 5 +- tests/qemuxml2argvdata/restore-v2-fd.args | 5 +- tests/qemuxml2argvdata/restore-v2.args | 5 +- tests/qemuxml2argvdata/riscv64-virt-pci.args | 5 +- tests/qemuxml2argvdata/riscv64-virt.args | 5 +- tests/qemuxml2argvdata/seclabel-dac-none.args | 5 +- .../seclabel-dynamic-baselabel.args | 5 +- .../seclabel-dynamic-labelskip.args | 5 +- .../seclabel-dynamic-override.args | 10 +- .../seclabel-dynamic-relabel.args | 5 +- tests/qemuxml2argvdata/seclabel-dynamic.args | 5 +- tests/qemuxml2argvdata/seclabel-none.args | 5 +- .../seclabel-static-labelskip.args | 5 +- .../seclabel-static-relabel.args | 5 +- tests/qemuxml2argvdata/seclabel-static.args | 5 +- .../serial-dev-chardev-iobase.args | 5 +- .../qemuxml2argvdata/serial-dev-chardev.args | 5 +- .../qemuxml2argvdata/serial-file-chardev.args | 5 +- tests/qemuxml2argvdata/serial-file-log.args | 5 +- .../qemuxml2argvdata/serial-many-chardev.args | 5 +- .../qemuxml2argvdata/serial-pty-chardev.args | 5 +- tests/qemuxml2argvdata/serial-spiceport.args | 5 +- .../qemuxml2argvdata/serial-tcp-chardev.args | 5 +- .../serial-tcp-telnet-chardev.args | 5 +- .../serial-tcp-tlsx509-chardev-notls.args | 5 +- .../serial-tcp-tlsx509-chardev-verify.args | 5 +- .../serial-tcp-tlsx509-chardev.args | 5 +- .../serial-tcp-tlsx509-secret-chardev.args | 5 +- .../qemuxml2argvdata/serial-udp-chardev.args | 5 +- tests/qemuxml2argvdata/serial-vc-chardev.args | 5 +- tests/qemuxml2argvdata/smbios-type-fwcfg.args | 5 +- tests/qemuxml2argvdata/smbios.args | 5 +- tests/qemuxml2argvdata/smp-dies.args | 5 +- tests/qemuxml2argvdata/smp.args | 5 +- tests/qemuxml2argvdata/sound-device.args | 5 +- tests/qemuxml2argvdata/sound.args | 5 +- tests/qemuxml2argvdata/sparc-minimal.args | 10 +- tests/qemuxml2argvdata/user-aliases-usb.args | 41 -- .../user-aliases-usb.x86_64-latest.args | 44 ++ tests/qemuxml2argvdata/user-aliases.args | 68 -- .../user-aliases.x86_64-latest.args | 74 ++ tests/qemuxml2argvdata/user-aliases.xml | 5 +- tests/qemuxml2argvdata/user-aliases2.args | 1 - .../user-aliases2.x86_64-latest.args | 39 + .../video-device-pciaddr-default.args | 5 +- tests/qemuxml2argvdata/video-none-device.args | 5 +- .../video-qxl-device-vgamem.args | 5 +- tests/qemuxml2argvdata/video-qxl-device.args | 5 +- tests/qemuxml2argvdata/video-qxl-heads.args | 5 +- tests/qemuxml2argvdata/video-qxl-noheads.args | 5 +- .../video-qxl-resolution.args | 5 +- .../video-qxl-sec-device-vgamem.args | 5 +- .../video-qxl-sec-device.args | 5 +- .../video-vga-device-vgamem.args | 5 +- tests/qemuxml2argvdata/video-vga-device.args | 5 +- .../qemuxml2argvdata/video-vga-qxl-heads.args | 5 +- .../video-virtio-gpu-ccw.args | 5 +- .../video-virtio-gpu-device.args | 5 +- .../video-virtio-gpu-sdl-gl.args | 5 +- .../video-virtio-gpu-spice-gl.args | 5 +- .../video-virtio-gpu-virgl.args | 5 +- tests/qemuxml2argvdata/video-virtio-vga.args | 5 +- tests/qemuxml2argvdata/virtio-rng-ccw.args | 5 +- tests/qemuxml2argvdata/vmcoreinfo.args | 5 +- tests/qemuxml2argvtest.c | 14 +- ...k-nvme.xml => disk-nvme.x86_64-latest.xml} | 0 ...=> encrypted-disk-usage.x86_64-latest.xml} | 0 ...k.xml => encrypted-disk.x86_64-latest.xml} | 5 +- ...ses.xml => user-aliases.x86_64-latest.xml} | 0 tests/qemuxml2xmltest.c | 15 +- 358 files changed, 1924 insertions(+), 8440 deletions(-) delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-basic-blockstats.json delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-basic-named-nodes.json delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-basic.result delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-blockjob-blockstats.json delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-blockjob-named-nodes.json delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-blockjob.result delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-empty-blockstats.json delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-empty-named-nodes.json delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-empty.result delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-gluster-blockstats.json delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-gluster-named-nodes.json delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-gluster.result delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-iscsi-blockstats.json delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-iscsi-named-nodes.json delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-iscsi.result delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-luks-blockstats.json delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-luks-named-nodes.json delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-luks.result delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-old-blockstats.json delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-old-named-nodes.json delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-old.result delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-relative-blockstats.json delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-relative-named-nodes.json delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-relative.result delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-same-backing-blockstats.json delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-same-backing-named-nodes.json delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-same-backing.result delete mode 100644 tests/qemuxml2argvdata/user-aliases-usb.args create mode 100644 tests/qemuxml2argvdata/user-aliases-usb.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/user-aliases.args create mode 100644 tests/qemuxml2argvdata/user-aliases.x86_64-latest.args delete mode 120000 tests/qemuxml2argvdata/user-aliases2.args create mode 100644 tests/qemuxml2argvdata/user-aliases2.x86_64-latest.args rename tests/qemuxml2xmloutdata/{disk-nvme.xml => disk-nvme.x86_64-latest.xml} (100%) rename tests/qemuxml2xmloutdata/{encrypted-disk-usage.xml => encrypted-disk-usage.x86_64-latest.xml} (100%) rename tests/qemuxml2xmloutdata/{encrypted-disk.xml => encrypted-disk.x86_64-latest.xml} (89%) rename tests/qemuxml2xmloutdata/{user-aliases.xml => user-aliases.x86_64-latest.xml} (100%) -- 2.36.1

4 169

[PATCH] remote: Make remote_daemon depend on qemu_protocol.h
by He Zhe 09 Aug '22

09 Aug '22

We sometimes meet the following parallel compililation issue, since remote_daemon depends on remote_protocol.h qemu_protocol.h and lxc_protocol.h, which are usually generated due to remote_driver . | FAILED: src/virtnetworkd.p/remote_remote_daemon_dispatch.c.o | x86_64-wrs-linux-gcc ... | In file included from ../libvirt-8.1.0/src/remote/remote_daemon_dispatch.c:26: | ../libvirt-8.1.0/src/remote/remote_daemon.h:30:10: fatal error: qemu_protocol.h: No such file or directory | 30 | #include "qemu_protocol.h" | | ^~~~~~~~~~~~~~~~~ | compilation terminated. This patch adds the headers as dependencies of remote_daemon to make sure they are always in place in advance. Signed-off-by: He Zhe <zhe.he(a)windriver.com> --- src/remote/meson.build | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/src/remote/meson.build b/src/remote/meson.build index eb4f7a0068..04525fb4a6 100644 --- a/src/remote/meson.build +++ b/src/remote/meson.build @@ -5,6 +5,15 @@ remote_driver_sources = [ remote_driver_generated = [] +remote_daemon_sources = files( + 'remote_daemon.c', + 'remote_daemon_config.c', + 'remote_daemon_dispatch.c', + 'remote_daemon_stream.c', +) + +remote_daemon_generated = [] + foreach name : [ 'remote', 'qemu', 'lxc' ] client_bodies_h = '@0@_client_bodies.h'.format(name) protocol_c = '@0@_protocol.c'.format(name) @@ -21,7 +30,7 @@ foreach name : [ 'remote', 'qemu', 'lxc' ] capture: true, ) - remote_driver_generated += custom_target( + protocol_h_generated = custom_target( protocol_h, input: protocol_x, output: protocol_h, @@ -30,6 +39,9 @@ foreach name : [ 'remote', 'qemu', 'lxc' ] ], ) + remote_driver_generated += protocol_h_generated + remote_daemon_generated += protocol_h_generated + remote_driver_generated += custom_target( protocol_c, input: protocol_x, @@ -42,15 +54,6 @@ foreach name : [ 'remote', 'qemu', 'lxc' ] rpc_probe_files += files(protocol_x) endforeach -remote_daemon_sources = files( - 'remote_daemon.c', - 'remote_daemon_config.c', - 'remote_daemon_dispatch.c', - 'remote_daemon_stream.c', -) - -remote_daemon_generated = [] - virt_ssh_helper_sources = files( 'remote_sockets.c', 'remote_ssh_helper.c', -- 2.17.1

2 2

[libvirt PATCH] conf: Simplify IOMMU device validation
by Andrea Bolognani 08 Aug '22

08 Aug '22

Instead of duplicating the list of attributes that are not allowed for some of the IOMMU models, use two separate switch statements: one for the attributes and one for the address. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- src/conf/domain_validate.c | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 88205c64e0..1c78a3d31c 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -2633,6 +2633,7 @@ virDomainIOMMUDefValidate(const virDomainIOMMUDef *iommu) { switch (iommu->model) { case VIR_DOMAIN_IOMMU_MODEL_SMMUV3: + case VIR_DOMAIN_IOMMU_MODEL_VIRTIO: if (iommu->intremap != VIR_TRISTATE_SWITCH_ABSENT || iommu->caching_mode != VIR_TRISTATE_SWITCH_ABSENT || iommu->eim != VIR_TRISTATE_SWITCH_ABSENT || @@ -2643,8 +2644,15 @@ virDomainIOMMUDefValidate(const virDomainIOMMUDef *iommu) virDomainIOMMUModelTypeToString(iommu->model)); return -1; } - G_GNUC_FALLTHROUGH; + break; + case VIR_DOMAIN_IOMMU_MODEL_INTEL: + case VIR_DOMAIN_IOMMU_MODEL_LAST: + break; + } + + switch (iommu->model) { + case VIR_DOMAIN_IOMMU_MODEL_SMMUV3: case VIR_DOMAIN_IOMMU_MODEL_INTEL: if (iommu->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE) { virReportError(VIR_ERR_XML_ERROR, @@ -2655,18 +2663,6 @@ virDomainIOMMUDefValidate(const virDomainIOMMUDef *iommu) break; case VIR_DOMAIN_IOMMU_MODEL_VIRTIO: - if (iommu->intremap != VIR_TRISTATE_SWITCH_ABSENT || - iommu->caching_mode != VIR_TRISTATE_SWITCH_ABSENT || - iommu->eim != VIR_TRISTATE_SWITCH_ABSENT || - iommu->iotlb != VIR_TRISTATE_SWITCH_ABSENT || - iommu->aw_bits != 0) { - virReportError(VIR_ERR_XML_ERROR, - _("iommu model '%s' doesn't support additional attributes"), - virDomainIOMMUModelTypeToString(iommu->model)); - return -1; - } - break; - case VIR_DOMAIN_IOMMU_MODEL_LAST: break; } -- 2.37.1

3 2

[PATCH v2 0/7] qemu: remove support for query-cpus
by Paolo Bonzini 08 Aug '22

08 Aug '22

The query-cpus-fast command was introduced in 2.12, therefore query-cpus is never used on supported versions of QEMU. Remove the logic to parse its output, as well as the parameters to choose between the two commands. Since most tests were still mocking the query-cpus command, the expected results of QEMU monitor commands have to be converted as well. Thanks, Paolo v1->v2: do not query capability, regenerate test output [Peter] hopefully patch 3/7 is not mangled [Pavel] Paolo Bonzini (7): tests: remove duplicate cpuinfo test tests: drop "-fast" from query-cpus-fast tests tests: convert ppc64 tests to query-cpus-fast tests: convert x86_64 tests to query-cpus-fast tests: remove query-cpus tests qemu: remove support for query-cpus qemu: deprecate query-cpus-fast capability src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_domain.c | 22 +- src/qemu/qemu_monitor.c | 29 +- src/qemu/qemu_monitor.h | 6 +- src/qemu/qemu_monitor_json.c | 44 +-- src/qemu/qemu_monitor_json.h | 3 +- .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1 - .../caps_3.1.0.x86_64.xml | 1 - .../caps_4.0.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 - .../caps_4.0.0.riscv32.xml | 1 - .../caps_4.0.0.riscv64.xml | 1 - .../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 1 - .../caps_4.0.0.x86_64.xml | 1 - .../caps_4.1.0.x86_64.xml | 1 - .../caps_4.2.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 - .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 - .../caps_4.2.0.x86_64.xml | 1 - .../caps_5.0.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 - .../caps_5.0.0.riscv64.xml | 1 - .../caps_5.0.0.x86_64.xml | 1 - .../qemucapabilitiesdata/caps_5.1.0.sparc.xml | 1 - .../caps_5.1.0.x86_64.xml | 1 - .../caps_5.2.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 1 - .../caps_5.2.0.riscv64.xml | 1 - .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 1 - .../caps_5.2.0.x86_64.xml | 1 - .../caps_6.0.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 1 - .../caps_6.0.0.x86_64.xml | 1 - .../caps_6.1.0.x86_64.xml | 1 - .../caps_6.2.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 1 - .../caps_6.2.0.x86_64.xml | 1 - .../caps_7.0.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml | 1 - .../caps_7.0.0.x86_64.xml | 1 - .../caps_7.1.0.x86_64.xml | 1 - tests/qemuhotplugtest.c | 2 - ...umonitorjson-cpuinfo-ppc64-basic-cpus.json | 64 ++--- ...itorjson-cpuinfo-ppc64-hotplug-1-cpus.json | 176 ++++++------ ...itorjson-cpuinfo-ppc64-hotplug-2-cpus.json | 264 ++++++++++-------- ...itorjson-cpuinfo-ppc64-hotplug-4-cpus.json | 264 ++++++++++-------- ...mumonitorjson-cpuinfo-ppc64-hotplug-4.data | 8 - ...torjson-cpuinfo-ppc64-no-threads-cpus.json | 88 +++--- ...=> qemumonitorjson-cpuinfo-s390-cpus.json} | 0 ...qemumonitorjson-cpuinfo-s390-hotplug.json} | 0 ...data => qemumonitorjson-cpuinfo-s390.data} | 0 ...json-cpuinfo-x86-basic-pluggable-cpus.json | 65 +++-- ...nitorjson-cpuinfo-x86-basic-pluggable.data | 5 - ...qemumonitorjson-cpuinfo-x86-full-cpus.json | 154 +++++----- ...onitorjson-cpuinfo-x86-full-fast-cpus.json | 126 --------- ...torjson-cpuinfo-x86-full-fast-hotplug.json | 115 -------- ...qemumonitorjson-cpuinfo-x86-full-fast.data | 109 -------- ...onitorjson-cpuinfo-x86-node-full-cpus.json | 16 +- ...qemumonitorjson-cpuinfo-x86-node-full.data | 2 - tests/qemumonitorjsontest.c | 102 +------ 61 files changed, 626 insertions(+), 1076 deletions(-) rename tests/qemumonitorjsondata/{qemumonitorjson-cpuinfo-s390-fast-cpus.json => qemumonitorjson-cpuinfo-s390-cpus.json} (100%) rename tests/qemumonitorjsondata/{qemumonitorjson-cpuinfo-s390-fast-hotplug.json => qemumonitorjson-cpuinfo-s390-hotplug.json} (100%) rename tests/qemumonitorjsondata/{qemumonitorjson-cpuinfo-s390-fast.data => qemumonitorjson-cpuinfo-s390.data} (100%) delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-x86-full-fast-cpus.json delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-x86-full-fast-hotplug.json delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-x86-full-fast.data -- 2.37.1

3 9

[PATCH 0/7] qemu: remove support for query-cpus
by Paolo Bonzini 08 Aug '22

08 Aug '22

The query-cpus-fast command was introduced in 2.12, therefore query-cpus is never used on supported versions of QEMU. Remove the logic to parse its output, as well as the parameters to choose between the two commands. Since most tests were still mocking the query-cpus command, the expected results of QEMU monitor commands have to be converted as well. Thanks, Paolo Paolo Bonzini (7): tests: remove duplicate cpuinfo test tests: drop "-fast" from query-cpus-fast tests tests: convert ppc64 tests to query-cpus-fast tests: convert x86_64 tests to query-cpus-fast tests: remove query-cpus tests qemu: remove support for query-cpus qemu: deprecate query-cpus-fast capability src/qemu/qemu_capabilities.c | 4 +- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_domain.c | 22 +- src/qemu/qemu_monitor.c | 29 +- src/qemu/qemu_monitor.h | 6 +- src/qemu/qemu_monitor_json.c | 44 +-- src/qemu/qemu_monitor_json.h | 3 +- tests/qemuhotplugtest.c | 2 - ...umonitorjson-cpuinfo-ppc64-basic-cpus.json | 64 ++--- ...itorjson-cpuinfo-ppc64-hotplug-1-cpus.json | 176 ++++++------ ...itorjson-cpuinfo-ppc64-hotplug-2-cpus.json | 264 ++++++++++-------- ...itorjson-cpuinfo-ppc64-hotplug-4-cpus.json | 264 ++++++++++-------- ...mumonitorjson-cpuinfo-ppc64-hotplug-4.data | 8 - ...torjson-cpuinfo-ppc64-no-threads-cpus.json | 88 +++--- ...=> qemumonitorjson-cpuinfo-s390-cpus.json} | 0 ...qemumonitorjson-cpuinfo-s390-hotplug.json} | 0 ...data => qemumonitorjson-cpuinfo-s390.data} | 0 ...json-cpuinfo-x86-basic-pluggable-cpus.json | 65 +++-- ...nitorjson-cpuinfo-x86-basic-pluggable.data | 5 - ...qemumonitorjson-cpuinfo-x86-full-cpus.json | 154 +++++----- ...onitorjson-cpuinfo-x86-full-fast-cpus.json | 126 --------- ...torjson-cpuinfo-x86-full-fast-hotplug.json | 115 -------- ...qemumonitorjson-cpuinfo-x86-full-fast.data | 109 -------- ...onitorjson-cpuinfo-x86-node-full-cpus.json | 16 +- ...qemumonitorjson-cpuinfo-x86-node-full.data | 2 - tests/qemumonitorjsontest.c | 102 +------ 26 files changed, 628 insertions(+), 1042 deletions(-) rename tests/qemumonitorjsondata/{qemumonitorjson-cpuinfo-s390-fast-cpus.json => qemumonitorjson-cpuinfo-s390-cpus.json} (100%) rename tests/qemumonitorjsondata/{qemumonitorjson-cpuinfo-s390-fast-hotplug.json => qemumonitorjson-cpuinfo-s390-hotplug.json} (100%) rename tests/qemumonitorjsondata/{qemumonitorjson-cpuinfo-s390-fast.data => qemumonitorjson-cpuinfo-s390.data} (100%) delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-x86-full-fast-cpus.json delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-x86-full-fast-hotplug.json delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-x86-full-fast.data -- 2.37.1

3 10

[PATCH] conf: Check IOMMU for unsupported attributes
by Michal Privoznik 08 Aug '22

08 Aug '22

Currently, it's possible to pass various attributes to an IOMMU's <driver/> element hoping that we enable them in underlying hypervisor. However, depending on the IOMMU model, some of these attributes can't be enabled and are simply ignored. This is suboptimal and we should reject such configuration in the validate phase. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2101633 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/conf/domain_validate.c | 26 +++++++++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index d4d72037d5..88205c64e0 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -2632,8 +2632,20 @@ static int virDomainIOMMUDefValidate(const virDomainIOMMUDef *iommu) { switch (iommu->model) { - case VIR_DOMAIN_IOMMU_MODEL_INTEL: case VIR_DOMAIN_IOMMU_MODEL_SMMUV3: + if (iommu->intremap != VIR_TRISTATE_SWITCH_ABSENT || + iommu->caching_mode != VIR_TRISTATE_SWITCH_ABSENT || + iommu->eim != VIR_TRISTATE_SWITCH_ABSENT || + iommu->iotlb != VIR_TRISTATE_SWITCH_ABSENT || + iommu->aw_bits != 0) { + virReportError(VIR_ERR_XML_ERROR, + _("iommu model '%s' doesn't support additional attributes"), + virDomainIOMMUModelTypeToString(iommu->model)); + return -1; + } + G_GNUC_FALLTHROUGH; + + case VIR_DOMAIN_IOMMU_MODEL_INTEL: if (iommu->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE) { virReportError(VIR_ERR_XML_ERROR, _("iommu model '%s' can't have address"), @@ -2643,6 +2655,18 @@ virDomainIOMMUDefValidate(const virDomainIOMMUDef *iommu) break; case VIR_DOMAIN_IOMMU_MODEL_VIRTIO: + if (iommu->intremap != VIR_TRISTATE_SWITCH_ABSENT || + iommu->caching_mode != VIR_TRISTATE_SWITCH_ABSENT || + iommu->eim != VIR_TRISTATE_SWITCH_ABSENT || + iommu->iotlb != VIR_TRISTATE_SWITCH_ABSENT || + iommu->aw_bits != 0) { + virReportError(VIR_ERR_XML_ERROR, + _("iommu model '%s' doesn't support additional attributes"), + virDomainIOMMUModelTypeToString(iommu->model)); + return -1; + } + break; + case VIR_DOMAIN_IOMMU_MODEL_LAST: break; } -- 2.35.1

2 1

[PATCH] util: basic support for vendor-specific vfio drivers
by Laine Stump 08 Aug '22

08 Aug '22

Before a PCI device can be assigned to a guest with VFIO, that device must be bound to the vfio-pci driver rather than to the device's normal driver. The vfio-pci driver provides APIs that permit QEMU to perform all the necessary operations to make the device accessible to the guest. There has been kernel work recently to support vendor/device-specific VFIO drivers that provide the basic vfio-pci driver functionality while adding support for device-specific operations (for example these device-specific drivers are planned to support live migration of certain devices). All that will be needed to make this functionality available will be to bind the new vendor-specific driver to the device (rather than the generic vfio-pci driver, which will continue to work just without the extra functionality). But until now libvirt has required that all PCI devices being assigned to a guest with VFIO specifically have the "vfio-pci" driver bound to the device. So even if the user manually binds a shiny new vendor-specific driver to the device (and puts "managed='no'" in the config to prevent libvirt from changing that), libvirt will just fail during startup of the guest (or during hotplug) because the driver bound to the device isn't named exactly "vfio-pci". Fortunately these new vendor/device-specific drivers can be easily identified as being "vfio-pci + extra stuff" - all that's needed is to look at the output of the "modinfo $driver_name" command to see if "vfio_pci" is in the alias list for the driver. That's what this patch does. When libvirt checks the driver bound to a device (either to decide if it needs to bind to a different driver or perform some other operation, or if the current driver is acceptable as-is), if the driver isn't specifically "vfio-pci", then it will look at the output of modinfo for the driver that *is* bound to the device; if modinfo shows vfio_pci as an alias for that device, then we'll behave as if the driver was exactly "vfio-pci". The effect of this patch is that users will now be able to pre-setup a device to be bound to a vendor-specific driver, then put "managed='no'" in the config and libvirt will allow that driver. What this patch does *not* do is handle automatically determining the proper/best vendor-specific driver and binding to it in the case of "managed='yes'". This will be implemented later when there is a widely available driver / device combo we can use for testing. This initial simple patch is just something simple that will permit initial testing of the new drivers' functionality. (I personally had to add an extra patch playing with driver names to my build just to test that everything was working as expected; that's okay for a patch as simple as this, but wouldn't be acceptable testing for anything more complex.) Signed-off-by: Laine Stump <laine(a)redhat.com> --- meson.build | 1 + src/hypervisor/virhostdev.c | 26 ++++------- src/util/virpci.c | 90 ++++++++++++++++++++++++++++++++++--- src/util/virpci.h | 3 ++ 4 files changed, 97 insertions(+), 23 deletions(-) diff --git a/meson.build b/meson.build index de59b1be9c..9d96eb3ee3 100644 --- a/meson.build +++ b/meson.build @@ -822,6 +822,7 @@ optional_programs = [ 'iscsiadm', 'mdevctl', 'mm-ctl', + 'modinfo', 'modprobe', 'ovs-vsctl', 'pdwtags', diff --git a/src/hypervisor/virhostdev.c b/src/hypervisor/virhostdev.c index c0ce867596..15b35fa75e 100644 --- a/src/hypervisor/virhostdev.c +++ b/src/hypervisor/virhostdev.c @@ -747,9 +747,8 @@ virHostdevPreparePCIDevicesImpl(virHostdevManager *mgr, mgr->inactivePCIHostdevs) < 0) goto reattachdevs; } else { - g_autofree char *driverPath = NULL; - g_autofree char *driverName = NULL; - int stub; + g_autofree char *drvName = NULL; + virPCIStubDriver drvType; /* Unmanaged devices should already have been marked as * inactive: if that's the case, we can simply move on */ @@ -769,18 +768,14 @@ virHostdevPreparePCIDevicesImpl(virHostdevManager *mgr, * information about active / inactive device across * daemon restarts has been implemented */ - if (virPCIDeviceGetDriverPathAndName(pci, - &driverPath, &driverName) < 0) + if (virPCIDeviceGetDriverNameAndType(pci, &drvName, &drvType) < 0) goto reattachdevs; - stub = virPCIStubDriverTypeFromString(driverName); - - if (stub > VIR_PCI_STUB_DRIVER_NONE && - stub < VIR_PCI_STUB_DRIVER_LAST) { + if (drvType > VIR_PCI_STUB_DRIVER_NONE) { /* The device is bound to a known stub driver: store this * information and add a copy to the inactive list */ - virPCIDeviceSetStubDriver(pci, stub); + virPCIDeviceSetStubDriver(pci, drvType); VIR_DEBUG("Adding PCI device %s to inactive list", virPCIDeviceGetName(pci)); @@ -2292,18 +2287,13 @@ virHostdevPrepareOneNVMeDevice(virHostdevManager *hostdev_mgr, /* Let's check if all PCI devices are NVMe disks. */ for (i = 0; i < virPCIDeviceListCount(pciDevices); i++) { virPCIDevice *pci = virPCIDeviceListGet(pciDevices, i); - g_autofree char *drvPath = NULL; g_autofree char *drvName = NULL; - int stub = VIR_PCI_STUB_DRIVER_NONE; + virPCIStubDriver drvType; - if (virPCIDeviceGetDriverPathAndName(pci, &drvPath, &drvName) < 0) + if (virPCIDeviceGetDriverNameAndType(pci, &drvName, &drvType) < 0) goto cleanup; - if (drvName) - stub = virPCIStubDriverTypeFromString(drvName); - - if (stub == VIR_PCI_STUB_DRIVER_VFIO || - STREQ_NULLABLE(drvName, "nvme")) + if (drvType == VIR_PCI_STUB_DRIVER_VFIO || STREQ_NULLABLE(drvName, "nvme")) continue; VIR_WARN("Suspicious NVMe disk assignment. PCI device " diff --git a/src/util/virpci.c b/src/util/virpci.c index 7800966963..8b714d3ddc 100644 --- a/src/util/virpci.c +++ b/src/util/virpci.c @@ -37,6 +37,7 @@ #include "virstring.h" #include "viralloc.h" #include "virpcivpd.h" +#include "vircommand.h" VIR_LOG_INIT("util.pci"); @@ -277,6 +278,84 @@ virPCIDeviceGetDriverPathAndName(virPCIDevice *dev, char **path, char **name) } +/** + * virPCIDeviceGetDriverNameAndType: + * @dev: virPCIDevice object to examine + * @drvName: returns name of driver bound to this device (if any) + * @drvType: returns type of driver if it is a known stub driver type + * + * Find the name of the driver bound to @dev (if any) and the type of + * the driver if it is a known/recognized "stub" driver (based on the + * name). If the name doesn't match one of the virPCIStubDrivers + * exactly, check the output of "modinfo vfio-pci" to see if + * "vfio_pci" is included in the driver's list of aliases; if so, then + * this driver has all the functionality of the basic vfio_pci driver, + * so it should be considered of the type VIR_PCI_STUB_DRIVER_VFIO. + * + * Return 0 on success, -1 on failure. If -1 is returned, then an error + * message has been logged. + */ +int +virPCIDeviceGetDriverNameAndType(virPCIDevice *dev, + char **drvName, + virPCIStubDriver *drvType) +{ + g_autofree char *drvPath = NULL; + g_autoptr(virCommand) cmd = NULL; + g_autofree char *output = NULL; + g_autoptr(GRegex) regex = NULL; + g_autoptr(GError) err = NULL; + g_autoptr(GMatchInfo) info = NULL; + int exit; + int tmpType; + + if (virPCIDeviceGetDriverPathAndName(dev, &drvPath, drvName) < 0) + return -1; + + if (!*drvName) { + *drvType = VIR_PCI_STUB_DRIVER_NONE; + return 0; + } + + tmpType = virPCIStubDriverTypeFromString(*drvName); + + if (tmpType > VIR_PCI_STUB_DRIVER_NONE) { + *drvType = tmpType; + return 0; /* exact match of a known driver name (or no name) */ + } + + /* Check the output of "modinfo $drvName" to see if it has + * "vfio_pci" as an alias. If it does, then this driver should + * also be considered as a vfio-pci driver, because it implements + * all the functionality of the basic vfio-pci (plus additional + * device-specific stuff). + */ + + cmd = virCommandNewArgList(MODINFO, *drvName, NULL); + virCommandSetOutputBuffer(cmd, &output); + if (virCommandRun(cmd, &exit) < 0) + return -1; + + regex = g_regex_new("^alias: +vfio_pci:", G_REGEX_MULTILINE, 0, &err); + if (!regex) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Failed to compile regex %s"), err->message); + return -1; + } + + g_regex_match(regex, output, 0, &info); + if (g_match_info_matches(info)) { + VIR_DEBUG("Driver %s is a vfio_pci driver", *drvName); + *drvType = VIR_PCI_STUB_DRIVER_VFIO; + } else { + VIR_DEBUG("Driver %s is NOT a vfio_pci driver", *drvName); + *drvType = VIR_PCI_STUB_DRIVER_NONE; + } + + return 0; +} + + static int virPCIDeviceConfigOpenInternal(virPCIDevice *dev, bool readonly, bool fatal) { @@ -1004,8 +1083,8 @@ virPCIDeviceReset(virPCIDevice *dev, virPCIDeviceList *activeDevs, virPCIDeviceList *inactiveDevs) { - g_autofree char *drvPath = NULL; g_autofree char *drvName = NULL; + virPCIStubDriver drvType; int ret = -1; int fd = -1; int hdrType = -1; @@ -1032,15 +1111,16 @@ virPCIDeviceReset(virPCIDevice *dev, * reset it whenever appropriate, so doing it ourselves would just * be redundant. */ - if (virPCIDeviceGetDriverPathAndName(dev, &drvPath, &drvName) < 0) + if (virPCIDeviceGetDriverNameAndType(dev, &drvName, &drvType) < 0) goto cleanup; - if (virPCIStubDriverTypeFromString(drvName) == VIR_PCI_STUB_DRIVER_VFIO) { - VIR_DEBUG("Device %s is bound to vfio-pci - skip reset", - dev->name); + if (drvType == VIR_PCI_STUB_DRIVER_VFIO) { + + VIR_DEBUG("Device %s is bound to %s - skip reset", dev->name, drvName); ret = 0; goto cleanup; } + VIR_DEBUG("Resetting device %s", dev->name); if ((fd = virPCIDeviceConfigOpenWrite(dev)) < 0) diff --git a/src/util/virpci.h b/src/util/virpci.h index 4d9193f24e..0532b90f90 100644 --- a/src/util/virpci.h +++ b/src/util/virpci.h @@ -280,6 +280,9 @@ int virPCIDeviceRebind(virPCIDevice *dev); int virPCIDeviceGetDriverPathAndName(virPCIDevice *dev, char **path, char **name); +int virPCIDeviceGetDriverNameAndType(virPCIDevice *dev, + char **drvName, + virPCIStubDriver *drvType); int virPCIDeviceIsPCIExpress(virPCIDevice *dev); int virPCIDeviceHasPCIExpressLink(virPCIDevice *dev); -- 2.35.3

5 23

[PATCH] news: qemu: Add support for zero-copy migration
by Fangge Jin 08 Aug '22

08 Aug '22

Signed-off-by: Fangge Jin <fjin(a)redhat.com> --- NEWS.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 79aad652e8..0eb3299e3b 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -42,6 +42,11 @@ v8.5.0 (2022-07-01) A new ``VIR_MIGRATE_POSTCOPY_RESUME`` flag (``virsh migrate --postcopy-resume``) was introduced for recovering from a failed post-copy migration. + * qemu: Add support for zero-copy migration + + With QEMU 7.1.0, libvirt can enable zerocopy for parallel migration. This is + implmented by adding a new ``VIR_MIGRATE_ZEROCOPY`` flag(``virsh migrate --zerocopy``). + * Introduce thread_pool_min and thread_pool_max attributes to IOThread New attributes ``thread_pool_min`` and ``thread_pool_max`` were introduced -- 2.31.1

2 1

[PATCH 00/11] qemu & hypervisor: move helper job functions
by Kristina Hanicova 08 Aug '22

08 Aug '22

This series moves helper functions from qemu so that they can be used by other hypervisors or BeginJob / EndJob functions which will be generalized and moved in one of the following series as well. Kristina Hanicova (11): qemu & hypervisor: move qemuDomainObjResetAgentJob() into hypervisor qemu & hypervisor: move qemuDomainObjResetAsyncJob() into hypervisor qemu: propagate virDomainJobObj into qemuDomainObjPreserveJob() qemu & hypervisor: move qemuDomainObjPreserveJob() into hypervisor qemu & hypervisor: move qemuDomainObjClearJob() into hypervisor libxl: use virDomainObjClearJob() instead of libxlDomainObjFreeJob() LXC: use virDomainObjClearJob() instead of virLXCDomainObjFreeJob() CH: use virDomainObjClearJob() instead of virCHDomainObjFreeJob() qemu & hypervisor: move qemuDomainTrackJob() into hypervisor qemu: move virDomainNestedJobAllowed into hypervisor qemu: move virDomainObjCanSetJob() into hypervisor src/ch/ch_domain.c | 10 +-- src/hypervisor/domain_job.c | 99 +++++++++++++++++++++++++++ src/hypervisor/domain_job.h | 18 +++++ src/libvirt_private.syms | 7 ++ src/libxl/libxl_domain.c | 9 +-- src/lxc/lxc_domain.c | 7 +- src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_domainjob.c | 129 ++++-------------------------------- src/qemu/qemu_domainjob.h | 7 -- src/qemu/qemu_process.c | 2 +- 10 files changed, 142 insertions(+), 148 deletions(-) -- 2.37.1

2 12

[PULL 0/6] Misc next patches
by Daniel P. Berrangé 05 Aug '22

05 Aug '22

The following changes since commit 09ed077d7fae5f825e18ff9a2004dcdd1b165edb: Merge tag 'trivial-branch-for-7.1-pull-request' of https://gitlab.com/laurent_vivier/qemu into staging (2022-08-04 17:21:13 -0700) are available in the Git repository at: https://gitlab.com/berrange/qemu tags/misc-next-pull-request for you to fetch changes up to e3fdb13e8851be570db41a50589ce82d11d61c12: util/qemu-sockets: Replace the call to close a socket with closesocket() (2022-08-05 16:18:15 +0100) ---------------------------------------------------------------- Merge misc patches * Display deprecation warnings in -cpu help * Fix zerocopy IPv6 handling * Clarify platform support policy on minor release/backports * Fix closesocket call in error path ---------------------------------------------------------------- Andrea Bolognani (1): docs: build-platforms: Clarify stance on minor releases and backports Bin Meng (1): util/qemu-sockets: Replace the call to close a socket with closesocket() Daniel P. Berrangé (3): target/i386: display deprecation status in '-cpu help' target/s390x: display deprecation status in '-cpu help' target/arm: display deprecation status in '-cpu help' Leonardo Bras (1): QIOChannelSocket: Add support for MSG_ZEROCOPY + IPV6 docs/about/build-platforms.rst | 5 ++++- io/channel-socket.c | 4 ++-- target/arm/helper.c | 7 ++++++- target/i386/cpu.c | 5 +++++ target/s390x/cpu_models.c | 23 ++++++++++++++++++----- util/qemu-sockets.c | 4 ++-- 6 files changed, 37 insertions(+), 11 deletions(-) -- 2.37.1

1 6

[PATCH] rpm: add virt-pki-query-dn to mingw spec
by Daniel P. Berrangé 05 Aug '22

05 Aug '22

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- mingw-libvirt.spec.in | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in index dbcb6d4b8f..5a04ff7223 100644 --- a/mingw-libvirt.spec.in +++ b/mingw-libvirt.spec.in @@ -202,6 +202,7 @@ rm -rf $RPM_BUILD_ROOT%{mingw64_libexecdir}/libvirt-guests.sh %{mingw32_bindir}/virsh.exe %{mingw32_bindir}/virt-admin.exe %{mingw32_bindir}/virt-xml-validate +%{mingw32_bindir}/virt-pki-query-dn.exe %{mingw32_bindir}/virt-pki-validate %{mingw32_bindir}/libvirt-lxc-0.dll %{mingw32_bindir}/libvirt-qemu-0.dll @@ -255,6 +256,7 @@ rm -rf $RPM_BUILD_ROOT%{mingw64_libexecdir}/libvirt-guests.sh %{mingw32_mandir}/man1/virsh.1* %{mingw32_mandir}/man1/virt-admin.1* %{mingw32_mandir}/man1/virt-xml-validate.1* +%{mingw32_mandir}/man1/virt-pki-query-dn.1* %{mingw32_mandir}/man1/virt-pki-validate.1* %{mingw32_mandir}/man7/virkey*.7* @@ -268,6 +270,7 @@ rm -rf $RPM_BUILD_ROOT%{mingw64_libexecdir}/libvirt-guests.sh %{mingw64_bindir}/virsh.exe %{mingw64_bindir}/virt-admin.exe %{mingw64_bindir}/virt-xml-validate +%{mingw64_bindir}/virt-pki-query-dn.exe %{mingw64_bindir}/virt-pki-validate %{mingw64_bindir}/libvirt-lxc-0.dll %{mingw64_bindir}/libvirt-qemu-0.dll @@ -321,6 +324,7 @@ rm -rf $RPM_BUILD_ROOT%{mingw64_libexecdir}/libvirt-guests.sh %{mingw64_mandir}/man1/virsh.1* %{mingw64_mandir}/man1/virt-admin.1* %{mingw64_mandir}/man1/virt-xml-validate.1* +%{mingw64_mandir}/man1/virt-pki-query-dn.1* %{mingw64_mandir}/man1/virt-pki-validate.1* %{mingw64_mandir}/man7/virkey*.7* -- 2.37.1

2 1

[PATCH for 8.7.0 00/20] Bump minimum supported qemu version to qemu-4.2 (part 1)
by Peter Krempa 05 Aug '22

05 Aug '22

In August Debian 10 officially reaches EOL, thus we can bump minimum qemu version to 4.2 which is being limited by Ubuntu and RHEL/Centos 8. QEMU-4.2 allows us to remove a big bunch of old code though. Few examples which this series (and the next iterations of it) will deal with: - old auidiodev config via ENV variables - old-style VIRTIO tranitional setup (possibly) - most of legacy block device setup (upcoming series) This series is lacking the removal of Debian 10 from our CI infra though, I'll post that separately once I get to it. The patches can also be fetched at: git fetch https://gitlab.com/pipo.sk/libvirt.git debian-10-remove-part1 as some of the pure-removal patches here will be truncated to prevent spamming the list. Peter Krempa (20): qemuxml2(argv|xml)test: Remove 'qemu-4.1' variant of 'x86-kvm-32-on-64' tests: qemuxml2argv: Remove pre-blockdev versions of disk-related tests qemuxml2argvtest: Drop 'qemu-4.1' variants of all audio tests qemuxml2argvtest: Remove 'qemu-3.1' versions of virtio-(non-)transitional tests qemuxml2argvtest: Remove pre-qemu-4.2 versions of 'cpu-host-model' test qemuxml2argvtest: Remove 'qemu-4.0' version of aarch64-features-sve case qemuxml2argvtest: Remove 'qemu-4.0' versions of 'cpu-host-model-cmt' and 'cpu-tsc-frequency' tests: qemucapabilities: Remove qemu-3.1 test data tests: domaincaps: Remove test data for qemu-3.1 qemucapabilitiestest: Remove test data for qemu-4.0 domaincapstest: Remove test data for qemu-4.0 qemucapabilitiestest: Remove test data for qemu-4.1 domaincapstest: Remove test data for qemu-4.1 qemu: Formally deprecate support for qemu < 4.2 qemu: command: Always assume QEMU_CAPS_AUDIODEV qemu: command: Drop the code for configuring audio devices via environment variables qemu: command: Drop qemuBuildAudioCommandLine thin wrapper qemu: validate: Remove unreachable checks for QEMU_CAPS_AUDIODEV qemuxml2(argv|xml)test: Remove use of QEMU_CAPS_AUDIODEV in fake-caps tests qemu: capabilities: Retire QEMU_CAPS_AUDIODEV docs/drvqemu.rst | 2 +- src/qemu/qemu_capabilities.c | 7 +- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c | 221 +- src/qemu/qemu_validate.c | 86 - .../domaincapsdata/qemu_3.1.0-q35.x86_64.xml | 211 - .../domaincapsdata/qemu_3.1.0-tcg.x86_64.xml | 230 - tests/domaincapsdata/qemu_3.1.0.ppc64.xml | 138 - tests/domaincapsdata/qemu_3.1.0.x86_64.xml | 211 - .../domaincapsdata/qemu_4.0.0-q35.x86_64.xml | 211 - .../domaincapsdata/qemu_4.0.0-tcg.x86_64.xml | 230 - .../qemu_4.0.0-virt.aarch64.xml | 179 - tests/domaincapsdata/qemu_4.0.0.aarch64.xml | 173 - tests/domaincapsdata/qemu_4.0.0.ppc64.xml | 139 - tests/domaincapsdata/qemu_4.0.0.s390x.xml | 236 - tests/domaincapsdata/qemu_4.0.0.x86_64.xml | 211 - .../domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 217 - .../domaincapsdata/qemu_4.1.0-tcg.x86_64.xml | 233 - tests/domaincapsdata/qemu_4.1.0.x86_64.xml | 217 - .../caps_3.1.0.ppc64.replies | 23732 --------------- .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1072 - .../caps_3.1.0.x86_64.replies | 24428 --------------- .../caps_3.1.0.x86_64.xml | 1387 - .../caps_4.0.0.aarch64.replies | 20893 ------------- .../caps_4.0.0.aarch64.xml | 363 - .../caps_4.0.0.ppc64.replies | 24461 --------------- .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1091 - .../caps_4.0.0.riscv32.replies | 18154 ----------- .../caps_4.0.0.riscv32.xml | 157 - .../caps_4.0.0.riscv64.replies | 18154 ----------- .../caps_4.0.0.riscv64.xml | 157 - .../caps_4.0.0.s390x.replies | 21721 ------------- .../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 2891 -- .../caps_4.0.0.x86_64.replies | 25001 --------------- .../caps_4.0.0.x86_64.xml | 1398 - .../caps_4.1.0.x86_64.replies | 25198 ---------------- .../caps_4.1.0.x86_64.xml | 1971 -- .../caps_4.2.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 - .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 - .../caps_4.2.0.x86_64.xml | 1 - .../caps_5.0.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 - .../caps_5.0.0.riscv64.xml | 1 - .../caps_5.0.0.x86_64.xml | 1 - .../qemucapabilitiesdata/caps_5.1.0.sparc.xml | 1 - .../caps_5.1.0.x86_64.xml | 1 - .../caps_5.2.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 1 - .../caps_5.2.0.riscv64.xml | 1 - .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 1 - .../caps_5.2.0.x86_64.xml | 1 - .../caps_6.0.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 1 - .../caps_6.0.0.x86_64.xml | 1 - .../caps_6.1.0.x86_64.xml | 1 - .../caps_6.2.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 1 - .../caps_6.2.0.x86_64.xml | 1 - .../caps_7.0.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml | 1 - .../caps_7.0.0.x86_64.xml | 1 - .../caps_7.1.0.x86_64.xml | 1 - .../aarch64-aavmf-virtio-mmio.args | 2 +- .../aarch64-cpu-passthrough.args | 2 +- .../aarch64-features-sve.aarch64-4.0.0.err | 1 - tests/qemuxml2argvdata/aarch64-gic-host.args | 2 +- .../aarch64-gic-none-tcg.args | 2 +- tests/qemuxml2argvdata/aarch64-gic-v2.args | 2 +- tests/qemuxml2argvdata/aarch64-gic-v3.args | 2 +- .../aarch64-kvm-32-on-64.args | 2 +- .../qemuxml2argvdata/aarch64-pci-serial.args | 2 +- .../aarch64-traditional-pci.args | 2 +- .../aarch64-usb-controller-nec-xhci.args | 2 +- .../aarch64-usb-controller-qemu-xhci.args | 2 +- .../aarch64-video-default.args | 4 +- .../aarch64-video-virtio-gpu-pci.args | 2 +- .../aarch64-virt-2.6-virtio-pci-default.args | 2 +- .../aarch64-virt-default-nic.args | 2 +- .../qemuxml2argvdata/aarch64-virt-virtio.args | 2 +- .../aarch64-virtio-pci-default.args | 2 +- .../aarch64-virtio-pci-manual-addresses.args | 2 +- tests/qemuxml2argvdata/acpi-table.args | 2 +- .../arm-vexpressa9-basic.args | 2 +- .../arm-vexpressa9-nodevs.args | 2 +- .../arm-vexpressa9-virtio.args | 2 +- tests/qemuxml2argvdata/arm-virt-virtio.args | 2 +- .../audio-alsa-best.x86_64-4.1.0.args | 46 - .../audio-alsa-full.x86_64-4.1.0.err | 1 - .../audio-alsa-minimal.x86_64-4.1.0.args | 33 - .../audio-coreaudio-best.x86_64-4.1.0.args | 46 - .../audio-coreaudio-full.x86_64-4.1.0.err | 1 - .../audio-coreaudio-minimal.x86_64-4.1.0.args | 33 - ...audio-default-nographics.x86_64-4.1.0.args | 33 - tests/qemuxml2argvdata/audio-default-sdl.args | 2 +- .../qemuxml2argvdata/audio-default-spice.args | 2 +- tests/qemuxml2argvdata/audio-default-vnc.args | 4 +- .../audio-file-best.x86_64-4.1.0.args | 45 - .../audio-file-full.x86_64-4.1.0.err | 1 - .../audio-file-minimal.x86_64-4.1.0.args | 33 - .../audio-jack-full.x86_64-4.1.0.err | 1 - .../audio-jack-minimal.x86_64-4.1.0.err | 1 - .../audio-many-backends.x86_64-4.1.0.err | 1 - .../audio-none-best.x86_64-4.1.0.args | 44 - .../audio-none-full.x86_64-4.1.0.err | 1 - .../audio-none-minimal.x86_64-4.1.0.args | 33 - .../audio-oss-best.x86_64-4.1.0.args | 49 - .../audio-oss-full.x86_64-4.1.0.err | 1 - .../audio-oss-minimal.x86_64-4.1.0.args | 33 - .../audio-pulseaudio-best.x86_64-4.1.0.args | 48 - .../audio-pulseaudio-full.x86_64-4.1.0.err | 1 - ...audio-pulseaudio-minimal.x86_64-4.1.0.args | 33 - .../audio-sdl-best.x86_64-4.1.0.args | 46 - .../audio-sdl-full.x86_64-4.1.0.err | 1 - .../audio-sdl-minimal.x86_64-4.1.0.args | 33 - .../audio-spice-best.x86_64-4.1.0.args | 45 - .../audio-spice-full.x86_64-4.1.0.err | 1 - .../audio-spice-minimal.x86_64-4.1.0.args | 34 - tests/qemuxml2argvdata/autoindex.args | 2 +- .../qemuxml2argvdata/balloon-ccw-deflate.args | 2 +- .../qemuxml2argvdata/balloon-device-auto.args | 2 +- .../balloon-device-deflate-off.args | 2 +- .../balloon-device-deflate.args | 2 +- .../balloon-device-period.args | 2 +- tests/qemuxml2argvdata/balloon-device.args | 2 +- .../balloon-mmio-deflate.args | 2 +- .../blkdeviotune-group-num.x86_64-4.1.0.args | 37 - .../blkdeviotune-max-length.x86_64-4.1.0.args | 37 - .../blkdeviotune-max.x86_64-4.1.0.args | 37 - tests/qemuxml2argvdata/blkiotune-device.args | 2 +- tests/qemuxml2argvdata/blkiotune.args | 2 +- tests/qemuxml2argvdata/boot-cdrom.args | 2 +- tests/qemuxml2argvdata/boot-complex.args | 2 +- tests/qemuxml2argvdata/boot-floppy-q35.args | 2 +- tests/qemuxml2argvdata/boot-floppy.args | 2 +- .../boot-menu-disable-drive.args | 2 +- tests/qemuxml2argvdata/boot-menu-disable.args | 2 +- .../boot-menu-enable-with-timeout.args | 2 +- tests/qemuxml2argvdata/boot-menu-enable.args | 2 +- tests/qemuxml2argvdata/boot-multi.args | 2 +- tests/qemuxml2argvdata/boot-network.args | 2 +- tests/qemuxml2argvdata/boot-order.args | 2 +- tests/qemuxml2argvdata/channel-guestfwd.args | 2 +- tests/qemuxml2argvdata/channel-spicevmc.args | 2 +- .../qemuxml2argvdata/channel-virtio-auto.args | 2 +- .../channel-virtio-autoadd.args | 2 +- .../channel-virtio-autoassign.args | 2 +- .../channel-virtio-default.args | 2 +- .../channel-virtio-state.args | 2 +- .../qemuxml2argvdata/channel-virtio-unix.args | 2 +- tests/qemuxml2argvdata/channel-virtio.args | 2 +- tests/qemuxml2argvdata/chardev-reconnect.args | 2 +- tests/qemuxml2argvdata/clock-catchup.args | 2 +- tests/qemuxml2argvdata/clock-france.args | 2 +- tests/qemuxml2argvdata/clock-hpet-off.args | 2 +- .../clock-localtime-basis-localtime.args | 2 +- tests/qemuxml2argvdata/clock-localtime.args | 2 +- tests/qemuxml2argvdata/clock-realtime.args | 2 +- .../clock-timer-hyperv-rtc.args | 2 +- tests/qemuxml2argvdata/clock-utc.args | 2 +- tests/qemuxml2argvdata/clock-variable.args | 2 +- .../qemuxml2argvdata/console-compat-auto.args | 2 +- .../console-compat-chardev.args | 2 +- tests/qemuxml2argvdata/console-compat.args | 2 +- .../qemuxml2argvdata/console-virtio-ccw.args | 2 +- .../qemuxml2argvdata/console-virtio-many.args | 2 +- tests/qemuxml2argvdata/console-virtio.args | 2 +- tests/qemuxml2argvdata/controller-order.args | 4 +- tests/qemuxml2argvdata/cpu-Haswell-noTSX.args | 2 +- tests/qemuxml2argvdata/cpu-Haswell.args | 2 +- tests/qemuxml2argvdata/cpu-Haswell2.args | 2 +- tests/qemuxml2argvdata/cpu-Haswell3.args | 2 +- tests/qemuxml2argvdata/cpu-cache-disable.args | 2 +- .../qemuxml2argvdata/cpu-cache-disable2.args | 2 +- .../qemuxml2argvdata/cpu-cache-disable3.args | 2 +- .../cpu-cache-emulate-l3.args | 2 +- .../cpu-cache-passthrough.args | 2 +- .../cpu-cache-passthrough2.args | 2 +- .../cpu-check-default-none.args | 2 +- .../cpu-check-default-none2.args | 2 +- .../cpu-check-default-partial.args | 2 +- .../cpu-check-default-partial2.args | 2 +- tests/qemuxml2argvdata/cpu-check-none.args | 2 +- tests/qemuxml2argvdata/cpu-exact1.args | 2 +- .../cpu-exact2-nofallback.args | 2 +- tests/qemuxml2argvdata/cpu-exact2.args | 2 +- tests/qemuxml2argvdata/cpu-fallback.args | 2 +- tests/qemuxml2argvdata/cpu-host-kvmclock.args | 2 +- .../qemuxml2argvdata/cpu-host-model-cmt.args | 2 +- .../cpu-host-model-cmt.x86_64-4.0.0.args | 33 - .../cpu-host-model-fallback.args | 2 +- .../cpu-host-model-vendor.args | 2 +- tests/qemuxml2argvdata/cpu-host-model.args | 2 +- .../cpu-host-model.x86_64-3.1.0.args | 36 - .../cpu-host-model.x86_64-4.0.0.args | 36 - .../cpu-host-model.x86_64-4.1.0.args | 36 - .../cpu-host-passthrough-features.args | 2 +- .../cpu-host-passthrough.args | 2 +- .../qemuxml2argvdata/cpu-hotplug-startup.args | 2 +- tests/qemuxml2argvdata/cpu-kvmclock.args | 2 +- tests/qemuxml2argvdata/cpu-minimum1.args | 2 +- tests/qemuxml2argvdata/cpu-minimum2.args | 2 +- .../cpu-no-removed-features.args | 2 +- tests/qemuxml2argvdata/cpu-numa-disjoint.args | 2 +- .../qemuxml2argvdata/cpu-numa-memshared.args | 2 +- .../cpu-numa-no-memory-element.args | 2 +- tests/qemuxml2argvdata/cpu-numa1.args | 2 +- tests/qemuxml2argvdata/cpu-numa2.args | 2 +- tests/qemuxml2argvdata/cpu-s390-features.args | 2 +- tests/qemuxml2argvdata/cpu-s390-zEC12.args | 2 +- tests/qemuxml2argvdata/cpu-strict1.args | 2 +- tests/qemuxml2argvdata/cpu-topology1.args | 2 +- tests/qemuxml2argvdata/cpu-topology2.args | 2 +- tests/qemuxml2argvdata/cpu-topology3.args | 2 +- tests/qemuxml2argvdata/cpu-tsc-frequency.args | 2 +- .../cpu-tsc-frequency.x86_64-4.0.0.args | 33 - tests/qemuxml2argvdata/cputune-numatune.args | 2 +- .../qemuxml2argvdata/cputune-zero-shares.args | 2 +- tests/qemuxml2argvdata/cputune.args | 2 +- .../default-kvm-host-arch.args | 2 +- .../default-qemu-host-arch.args | 2 +- .../disk-aio.x86_64-4.1.0.args | 36 - .../disk-arm-virtio-sd.aarch64-4.0.0.args | 38 - ...isk-backing-chains-index.x86_64-4.1.0.args | 45 - ...k-backing-chains-noindex.x86_64-4.1.0.args | 1 - .../disk-cache.x86_64-3.1.0.args | 42 - .../disk-cache.x86_64-4.1.0.args | 42 - .../disk-cdrom-network.x86_64-4.1.0.args | 39 - .../disk-cdrom-tray.x86_64-4.1.0.args | 38 - .../disk-cdrom.x86_64-4.1.0.args | 39 - .../disk-copy_on_read.x86_64-4.1.0.args | 39 - .../disk-detect-zeroes.x86_64-4.1.0.args | 37 - .../disk-discard.x86_64-4.1.0.args | 36 - .../disk-error-policy-s390x.s390x-4.0.0.args | 35 - .../disk-error-policy.x86_64-4.1.0.args | 37 - .../disk-floppy-q35.x86_64-4.1.0.args | 36 - .../disk-floppy.x86_64-4.1.0.args | 37 - .../disk-fmt-qcow.x86_64-4.1.0.args | 35 - .../disk-network-gluster.x86_64-4.1.0.args | 37 - .../disk-network-iscsi.x86_64-4.1.0.args | 49 - .../disk-network-nbd.x86_64-4.1.0.args | 41 - ...disk-network-rbd-no-colon.x86_64-4.1.0.err | 1 - .../disk-network-rbd.x86_64-4.1.0.args | 44 - .../disk-network-sheepdog.x86_64-4.1.0.args | 35 - ...disk-network-source-auth.x86_64-4.1.0.args | 40 - ...disk-network-tlsx509-nbd.x86_64-4.1.0.args | 35 - ...isk-network-tlsx509-vxhs.x86_64-4.1.0.args | 41 - .../disk-readonly-disk.x86_64-4.1.0.args | 36 - .../disk-shared.x86_64-3.1.0.args | 41 - .../disk-shared.x86_64-4.1.0.args | 41 - .../disk-source-pool-mode.x86_64-4.1.0.args | 40 - .../disk-source-pool.x86_64-4.1.0.args | 42 - .../disk-transient.x86_64-4.1.0.err | 1 - ...virtio-scsi-reservations.x86_64-4.1.0.args | 39 - .../encrypted-disk-usage.x86_64-4.1.0.args | 35 - .../encrypted-disk.x86_64-4.1.0.args | 35 - .../fd-memory-no-numa-topology.args | 2 +- .../fd-memory-numa-topology.args | 2 +- .../fd-memory-numa-topology2.args | 2 +- .../fd-memory-numa-topology3.args | 2 +- .../firmware-manual-bios.args | 2 +- .../firmware-manual-efi-acpi-aarch64.args | 2 +- .../firmware-manual-efi-acpi-q35.args | 2 +- .../firmware-manual-efi-noacpi-aarch64.args | 2 +- ...l-efi-nvram-network-iscsi.x86_64-4.1.0.err | 1 - .../firmware-manual-efi-secure.args | 2 +- .../qemuxml2argvdata/firmware-manual-efi.args | 2 +- .../firmware-manual-noefi-acpi-q35.args | 2 +- .../firmware-manual-noefi-noacpi-aarch64.args | 2 +- .../firmware-manual-noefi-noacpi-q35.args | 2 +- .../floppy-drive-fat.x86_64-4.1.0.args | 35 - .../hostdev-mdev-precreated.args | 2 +- .../hostdev-pci-address-unassigned.args | 2 +- .../hostdev-pci-multifunction.args | 2 +- .../hostdev-scsi-lsi.x86_64-4.1.0.args | 49 - .../hostdev-scsi-vhost-scsi-ccw.args | 2 +- .../hostdev-scsi-vhost-scsi-pci.args | 2 +- .../hostdev-scsi-vhost-scsi-pcie.args | 2 +- ...hostdev-scsi-virtio-scsi.x86_64-4.1.0.args | 51 - .../hostdev-subsys-mdev-vfio-ccw.args | 2 +- .../hostdev-vfio-multidomain.args | 2 +- .../hostdev-vfio-zpci-autogenerate-fids.args | 2 +- .../hostdev-vfio-zpci-autogenerate-uids.args | 2 +- .../hostdev-vfio-zpci-autogenerate.args | 2 +- .../hostdev-vfio-zpci-boundaries.args | 2 +- .../hostdev-vfio-zpci-ccw-memballoon.args | 2 +- .../hostdev-vfio-zpci-multidomain-many.args | 2 +- tests/qemuxml2argvdata/hostdev-vfio-zpci.args | 2 +- tests/qemuxml2argvdata/hostdev-vfio.args | 2 +- tests/qemuxml2argvdata/hotplug-base.args | 2 +- .../hugepages-default-2M.args | 2 +- .../hugepages-default-system-size.args | 2 +- tests/qemuxml2argvdata/hugepages-default.args | 2 +- .../qemuxml2argvdata/hugepages-memaccess.args | 2 +- .../hugepages-memaccess2.args | 2 +- tests/qemuxml2argvdata/hugepages-nodeset.args | 2 +- .../hugepages-numa-default-2M.args | 2 +- .../hugepages-numa-default-dimm.args | 2 +- .../hugepages-numa-default.args | 2 +- .../hugepages-numa-nodeset-part.args | 2 +- .../hugepages-numa-nodeset.args | 2 +- tests/qemuxml2argvdata/hugepages-shared.args | 2 +- .../hvf-aarch64-virt-headless.args | 2 +- .../hvf-x86_64-q35-headless.args | 2 +- .../qemuxml2argvdata/input-usbmouse-addr.args | 2 +- tests/qemuxml2argvdata/input-usbmouse.args | 2 +- tests/qemuxml2argvdata/input-usbtablet.args | 2 +- tests/qemuxml2argvdata/input-virtio-ccw.args | 2 +- .../iothreads-disk-virtio-ccw.args | 2 +- tests/qemuxml2argvdata/iothreads-disk.args | 2 +- .../iothreads-ids-partial.args | 2 +- tests/qemuxml2argvdata/iothreads-ids.args | 2 +- tests/qemuxml2argvdata/iothreads.args | 2 +- tests/qemuxml2argvdata/kvm-features-off.args | 2 +- tests/qemuxml2argvdata/kvm-features.args | 2 +- tests/qemuxml2argvdata/kvm-pit-delay.args | 2 +- tests/qemuxml2argvdata/kvm-pit-discard.args | 2 +- tests/qemuxml2argvdata/kvmclock.args | 2 +- .../luks-disks-source.x86_64-4.1.0.args | 48 - .../luks-disks.x86_64-4.1.0.args | 39 - .../mach-virt-console-virtio.args | 2 +- .../mach-virt-serial-native.args | 2 +- .../mach-virt-serial-pci.args | 2 +- .../mach-virt-serial-usb.args | 2 +- .../machine-aeskeywrap-off-cap.args | 2 +- .../machine-aeskeywrap-off-caps.args | 2 +- .../machine-aeskeywrap-on-cap.args | 2 +- .../machine-aeskeywrap-on-caps.args | 2 +- tests/qemuxml2argvdata/machine-aliases1.args | 2 +- tests/qemuxml2argvdata/machine-aliases2.args | 2 +- tests/qemuxml2argvdata/machine-core-off.args | 2 +- tests/qemuxml2argvdata/machine-core-on.args | 2 +- .../machine-deakeywrap-off-cap.args | 2 +- .../machine-deakeywrap-off-caps.args | 2 +- .../machine-deakeywrap-on-cap.args | 2 +- .../machine-deakeywrap-on-caps.args | 2 +- .../machine-keywrap-none-caps.args | 2 +- .../machine-keywrap-none.args | 2 +- ...ine-loadparm-multiple-disks-nets-s390.args | 2 +- .../machine-loadparm-net-s390.args | 2 +- .../machine-loadparm-s390.args | 2 +- .../qemuxml2argvdata/machine-vmport-opt.args | 2 +- tests/qemuxml2argvdata/master-key.args | 2 +- .../memory-hotplug-dimm-addr.args | 2 +- .../qemuxml2argvdata/memory-hotplug-dimm.args | 2 +- ...emory-hotplug-nvdimm-ppc64-abi-update.args | 2 +- .../memory-hotplug-nvdimm-ppc64.args | 2 +- ...emory-hotplug-ppc64-nonuma-abi-update.args | 2 +- .../memory-hotplug-ppc64-nonuma.args | 2 +- tests/qemuxml2argvdata/memory-hotplug.args | 2 +- tests/qemuxml2argvdata/memtune-unlimited.args | 2 +- tests/qemuxml2argvdata/memtune.args | 2 +- .../migrate-numa-unaligned.args | 2 +- tests/qemuxml2argvdata/migrate.args | 2 +- tests/qemuxml2argvdata/minimal.args | 2 +- tests/qemuxml2argvdata/misc-acpi.args | 2 +- tests/qemuxml2argvdata/misc-disable-s3.args | 2 +- .../misc-disable-suspends.args | 2 +- tests/qemuxml2argvdata/misc-enable-s4.args | 2 +- tests/qemuxml2argvdata/misc-uuid.args | 2 +- tests/qemuxml2argvdata/monitor-json.args | 2 +- .../multifunction-pci-device.args | 2 +- tests/qemuxml2argvdata/net-client.args | 2 +- tests/qemuxml2argvdata/net-eth-hostip.args | 2 +- tests/qemuxml2argvdata/net-eth-ifname.args | 2 +- tests/qemuxml2argvdata/net-eth-names.args | 2 +- .../net-eth-unmanaged-tap.args | 2 +- tests/qemuxml2argvdata/net-eth.args | 2 +- .../net-hostdev-bootorder.args | 2 +- .../net-hostdev-multidomain.args | 2 +- .../net-hostdev-vfio-multidomain.args | 2 +- tests/qemuxml2argvdata/net-hostdev-vfio.args | 2 +- tests/qemuxml2argvdata/net-hostdev.args | 2 +- tests/qemuxml2argvdata/net-many-models.args | 2 +- tests/qemuxml2argvdata/net-mcast.args | 2 +- tests/qemuxml2argvdata/net-server.args | 2 +- tests/qemuxml2argvdata/net-udp.args | 2 +- tests/qemuxml2argvdata/net-user-addr.args | 2 +- tests/qemuxml2argvdata/net-user.args | 2 +- .../net-vhostuser-multiq.args | 2 +- tests/qemuxml2argvdata/net-vhostuser.args | 2 +- tests/qemuxml2argvdata/net-virtio-ccw.args | 2 +- tests/qemuxml2argvdata/net-virtio-device.args | 2 +- .../net-virtio-disable-offloads.args | 2 +- tests/qemuxml2argvdata/net-virtio-netdev.args | 2 +- .../net-virtio-rxtxqueuesize.args | 2 +- .../net-virtio-teaming-hostdev.args | 2 +- .../qemuxml2argvdata/net-virtio-teaming.args | 2 +- tests/qemuxml2argvdata/net-virtio.args | 2 +- tests/qemuxml2argvdata/nosharepages.args | 2 +- .../numad-auto-memory-vcpu-cpuset.args | 2 +- ...o-memory-vcpu-no-cpuset-and-placement.args | 2 +- .../numad-auto-vcpu-static-numatune.args | 2 +- .../numad-static-memory-auto-vcpu.args | 2 +- tests/qemuxml2argvdata/numad.args | 2 +- .../numatune-auto-nodeset-invalid.args | 2 +- .../numatune-auto-prefer.args | 2 +- .../qemuxml2argvdata/numatune-distances.args | 2 +- .../numatune-memnode-no-memory.args | 2 +- tests/qemuxml2argvdata/numatune-memnode.args | 2 +- tests/qemuxml2argvdata/numatune-memory.args | 2 +- tests/qemuxml2argvdata/numatune-no-vcpu.args | 2 +- .../qemuxml2argvdata/pages-dimm-discard.args | 2 +- .../pages-discard-hugepages.args | 2 +- tests/qemuxml2argvdata/pages-discard.args | 2 +- .../parallel-parport-chardev.args | 2 +- .../parallel-tcp-chardev.args | 2 +- tests/qemuxml2argvdata/pci-autoadd-addr.args | 2 +- tests/qemuxml2argvdata/pci-autoadd-idx.args | 2 +- tests/qemuxml2argvdata/pci-autofill-addr.args | 2 +- .../pci-bridge-many-disks.args | 2 +- tests/qemuxml2argvdata/pci-bridge.args | 4 +- tests/qemuxml2argvdata/pci-expander-bus.args | 2 +- tests/qemuxml2argvdata/pci-many.args | 2 +- tests/qemuxml2argvdata/pci-rom-disabled.args | 2 +- tests/qemuxml2argvdata/pci-rom.args | 2 +- .../pci-serial-dev-chardev.args | 2 +- tests/qemuxml2argvdata/pcie-expander-bus.args | 2 +- .../pcie-root-port-model-generic.args | 2 +- .../pcie-root-port-model-ioh3420.args | 2 +- tests/qemuxml2argvdata/pcie-root-port.args | 2 +- tests/qemuxml2argvdata/pcie-root.args | 2 +- .../pcie-switch-downstream-port.args | 2 +- .../pcie-switch-upstream-port.args | 2 +- tests/qemuxml2argvdata/pcihole64-q35.args | 2 +- tests/qemuxml2argvdata/pcihole64.args | 2 +- tests/qemuxml2argvdata/pmu-feature-off.args | 2 +- tests/qemuxml2argvdata/pmu-feature.args | 2 +- tests/qemuxml2argvdata/ppc-dtb.args | 2 +- .../ppc64-usb-controller-legacy.args | 2 +- .../ppc64-usb-controller-qemu-xhci.args | 2 +- .../ppc64-usb-controller.args | 2 +- tests/qemuxml2argvdata/ppce500-serial.args | 2 +- tests/qemuxml2argvdata/pseries-basic.args | 2 +- .../pseries-console-virtio.args | 2 +- .../qemuxml2argvdata/pseries-cpu-compat.args | 2 +- tests/qemuxml2argvdata/pseries-cpu-exact.args | 2 +- tests/qemuxml2argvdata/pseries-cpu-le.args | 2 +- tests/qemuxml2argvdata/pseries-features.args | 2 +- .../qemuxml2argvdata/pseries-hostdevs-1.args | 2 +- .../qemuxml2argvdata/pseries-hostdevs-2.args | 2 +- .../qemuxml2argvdata/pseries-hostdevs-3.args | 2 +- .../pseries-many-buses-1.args | 2 +- .../pseries-many-buses-2.args | 2 +- .../pseries-many-devices.args | 2 +- tests/qemuxml2argvdata/pseries-nvram.args | 2 +- .../pseries-panic-missing.args | 2 +- .../pseries-panic-no-address.args | 2 +- .../pseries-phb-default-missing.args | 2 +- .../pseries-phb-numa-node.args | 2 +- .../qemuxml2argvdata/pseries-phb-simple.args | 2 +- .../pseries-serial-native.args | 2 +- .../qemuxml2argvdata/pseries-serial-pci.args | 2 +- .../qemuxml2argvdata/pseries-serial-usb.args | 2 +- .../qemuxml2argvdata/pseries-usb-default.args | 2 +- tests/qemuxml2argvdata/pseries-usb-kbd.args | 2 +- tests/qemuxml2argvdata/pseries-usb-multi.args | 2 +- .../pseries-vio-user-assigned.args | 2 +- tests/qemuxml2argvdata/pseries-vio.args | 2 +- .../q35-default-devices-only.args | 2 +- tests/qemuxml2argvdata/q35-multifunction.args | 2 +- .../q35-pci-force-address.args | 4 +- tests/qemuxml2argvdata/q35-pcie-autoadd.args | 2 +- tests/qemuxml2argvdata/q35-pcie.args | 2 +- .../q35-pm-disable-fallback.args | 2 +- tests/qemuxml2argvdata/q35-pm-disable.args | 2 +- tests/qemuxml2argvdata/q35-usb2-multi.args | 2 +- tests/qemuxml2argvdata/q35-usb2-reorder.args | 2 +- tests/qemuxml2argvdata/q35-usb2.args | 2 +- .../q35-virt-manager-basic.args | 4 +- tests/qemuxml2argvdata/q35-virtio-pci.args | 2 +- tests/qemuxml2argvdata/q35.args | 2 +- tests/qemuxml2argvdata/qemu-ns-alt.args | 2 +- .../qemu-ns-commandline-ns0.args | 2 +- .../qemu-ns-commandline-ns1.args | 2 +- .../qemuxml2argvdata/qemu-ns-commandline.args | 2 +- .../qemu-ns-domain-commandline-ns0.args | 2 +- .../qemu-ns-domain-commandline.args | 2 +- .../qemuxml2argvdata/qemu-ns-domain-ns0.args | 2 +- tests/qemuxml2argvdata/qemu-ns-no-env.args | 2 +- .../reboot-timeout-disabled.args | 2 +- .../reboot-timeout-enabled.args | 2 +- tests/qemuxml2argvdata/restore-v2-fd.args | 2 +- tests/qemuxml2argvdata/restore-v2.args | 2 +- tests/qemuxml2argvdata/riscv64-virt-pci.args | 2 +- tests/qemuxml2argvdata/riscv64-virt.args | 2 +- .../qemuxml2argvdata/s390-panic-missing.args | 2 +- .../s390-panic-no-address.args | 2 +- tests/qemuxml2argvdata/s390-serial-2.args | 2 +- .../qemuxml2argvdata/s390-serial-console.args | 2 +- tests/qemuxml2argvdata/s390-serial.args | 2 +- tests/qemuxml2argvdata/seclabel-dac-none.args | 2 +- .../seclabel-dynamic-baselabel.args | 2 +- .../seclabel-dynamic-labelskip.args | 2 +- .../seclabel-dynamic-override.args | 2 +- .../seclabel-dynamic-relabel.args | 2 +- tests/qemuxml2argvdata/seclabel-dynamic.args | 2 +- tests/qemuxml2argvdata/seclabel-none.args | 2 +- .../seclabel-static-labelskip.args | 2 +- .../seclabel-static-relabel.args | 2 +- tests/qemuxml2argvdata/seclabel-static.args | 2 +- .../serial-dev-chardev-iobase.args | 2 +- .../qemuxml2argvdata/serial-dev-chardev.args | 2 +- .../qemuxml2argvdata/serial-file-chardev.args | 2 +- tests/qemuxml2argvdata/serial-file-log.args | 2 +- .../qemuxml2argvdata/serial-many-chardev.args | 2 +- .../qemuxml2argvdata/serial-pty-chardev.args | 2 +- tests/qemuxml2argvdata/serial-spiceport.args | 2 +- .../qemuxml2argvdata/serial-tcp-chardev.args | 2 +- .../serial-tcp-telnet-chardev.args | 2 +- .../serial-tcp-tlsx509-chardev-notls.args | 2 +- .../serial-tcp-tlsx509-chardev-verify.args | 2 +- .../serial-tcp-tlsx509-chardev.args | 2 +- .../serial-tcp-tlsx509-secret-chardev.args | 2 +- .../qemuxml2argvdata/serial-udp-chardev.args | 2 +- .../qemuxml2argvdata/serial-unix-chardev.args | 2 +- tests/qemuxml2argvdata/serial-vc-chardev.args | 2 +- .../shmem-plain-doorbell.args | 2 +- tests/qemuxml2argvdata/shmem.args | 2 +- .../smartcard-controller.args | 2 +- .../smartcard-host-certificates-database.args | 2 +- .../smartcard-host-certificates.args | 2 +- tests/qemuxml2argvdata/smartcard-host.args | 2 +- .../smartcard-passthrough-spicevmc.args | 2 +- .../smartcard-passthrough-tcp.args | 2 +- tests/qemuxml2argvdata/smbios-type-fwcfg.args | 2 +- tests/qemuxml2argvdata/smbios.args | 2 +- tests/qemuxml2argvdata/smp-dies.args | 2 +- tests/qemuxml2argvdata/smp.args | 2 +- tests/qemuxml2argvdata/sound-device.args | 26 +- tests/qemuxml2argvdata/sound.args | 8 +- tests/qemuxml2argvdata/sparc-minimal.args | 2 +- .../usb-controller-default-q35.args | 2 +- .../usb-controller-explicit-q35.args | 2 +- .../usb-controller-qemu-xhci.args | 2 +- .../qemuxml2argvdata/usb-controller-xhci.args | 2 +- tests/qemuxml2argvdata/usb-controller.args | 2 +- .../usb-hub-autoadd-deluxe.args | 2 +- tests/qemuxml2argvdata/usb-hub-autoadd.args | 2 +- tests/qemuxml2argvdata/usb-hub.args | 2 +- .../qemuxml2argvdata/usb-ich9-autoassign.args | 2 +- .../qemuxml2argvdata/usb-ich9-companion.args | 2 +- .../qemuxml2argvdata/usb-ich9-ehci-addr.args | 2 +- .../qemuxml2argvdata/usb-long-port-path.args | 2 +- tests/qemuxml2argvdata/usb-none.args | 2 +- .../usb-piix3-controller.args | 2 +- .../qemuxml2argvdata/usb-port-autoassign.args | 2 +- tests/qemuxml2argvdata/usb-port-missing.args | 2 +- tests/qemuxml2argvdata/usb-ports.args | 2 +- tests/qemuxml2argvdata/usb-redir-boot.args | 2 +- .../usb-redir-filter-version.args | 2 +- tests/qemuxml2argvdata/usb-redir-filter.args | 2 +- tests/qemuxml2argvdata/usb-redir.args | 2 +- .../qemuxml2argvdata/usb-xhci-autoassign.args | 2 +- tests/qemuxml2argvdata/usb1-usb2.args | 2 +- tests/qemuxml2argvdata/user-aliases-usb.args | 2 +- tests/qemuxml2argvdata/user-aliases.args | 6 +- .../vcpu-placement-static.args | 2 +- .../video-device-pciaddr-default.args | 4 +- tests/qemuxml2argvdata/video-none-device.args | 4 +- .../video-qxl-device-vgamem.args | 2 +- tests/qemuxml2argvdata/video-qxl-device.args | 2 +- tests/qemuxml2argvdata/video-qxl-heads.args | 2 +- tests/qemuxml2argvdata/video-qxl-noheads.args | 2 +- .../video-qxl-resolution.args | 2 +- .../video-qxl-sec-device-vgamem.args | 2 +- .../video-qxl-sec-device.args | 2 +- .../video-vga-device-vgamem.args | 2 +- tests/qemuxml2argvdata/video-vga-device.args | 2 +- .../qemuxml2argvdata/video-vga-qxl-heads.args | 2 +- .../video-virtio-gpu-ccw.args | 4 +- .../video-virtio-gpu-device.args | 2 +- .../video-virtio-gpu-secondary.args | 2 +- .../video-virtio-gpu-spice-gl.args | 2 +- .../video-virtio-gpu-virgl.args | 2 +- tests/qemuxml2argvdata/video-virtio-vga.args | 2 +- .../virtio-input-passthrough.args | 2 +- tests/qemuxml2argvdata/virtio-input.args | 2 +- .../virtio-non-transitional.x86_64-3.1.0.args | 53 - tests/qemuxml2argvdata/virtio-rng-ccw.args | 2 +- .../qemuxml2argvdata/virtio-rng-default.args | 2 +- tests/qemuxml2argvdata/virtio-rng-egd.args | 2 +- .../qemuxml2argvdata/virtio-rng-multiple.args | 2 +- tests/qemuxml2argvdata/virtio-rng-random.args | 2 +- .../virtio-transitional.x86_64-3.1.0.args | 46 - tests/qemuxml2argvdata/vmcoreinfo.args | 2 +- .../x86-kvm-32-on-64.x86_64-4.1.0.args | 31 - tests/qemuxml2argvtest.c | 93 +- .../x86-kvm-32-on-64.x86_64-4.1.0.xml | 24 - tests/qemuxml2xmltest.c | 21 +- 590 files changed, 495 insertions(+), 218552 deletions(-) delete mode 100644 tests/domaincapsdata/qemu_3.1.0-q35.x86_64.xml delete mode 100644 tests/domaincapsdata/qemu_3.1.0-tcg.x86_64.xml delete mode 100644 tests/domaincapsdata/qemu_3.1.0.ppc64.xml delete mode 100644 tests/domaincapsdata/qemu_3.1.0.x86_64.xml delete mode 100644 tests/domaincapsdata/qemu_4.0.0-q35.x86_64.xml delete mode 100644 tests/domaincapsdata/qemu_4.0.0-tcg.x86_64.xml delete mode 100644 tests/domaincapsdata/qemu_4.0.0-virt.aarch64.xml delete mode 100644 tests/domaincapsdata/qemu_4.0.0.aarch64.xml delete mode 100644 tests/domaincapsdata/qemu_4.0.0.ppc64.xml delete mode 100644 tests/domaincapsdata/qemu_4.0.0.s390x.xml delete mode 100644 tests/domaincapsdata/qemu_4.0.0.x86_64.xml delete mode 100644 tests/domaincapsdata/qemu_4.1.0-q35.x86_64.xml delete mode 100644 tests/domaincapsdata/qemu_4.1.0-tcg.x86_64.xml delete mode 100644 tests/domaincapsdata/qemu_4.1.0.x86_64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_3.1.0.ppc64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_3.1.0.x86_64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_4.0.0.aarch64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_4.0.0.aarch64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_4.0.0.ppc64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_4.0.0.ppc64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_4.0.0.riscv32.replies delete mode 100644 tests/qemucapabilitiesdata/caps_4.0.0.riscv32.xml delete mode 100644 tests/qemucapabilitiesdata/caps_4.0.0.riscv64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_4.0.0.riscv64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_4.0.0.s390x.replies delete mode 100644 tests/qemucapabilitiesdata/caps_4.0.0.s390x.xml delete mode 100644 tests/qemucapabilitiesdata/caps_4.0.0.x86_64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_4.1.0.x86_64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_4.1.0.x86_64.xml delete mode 100644 tests/qemuxml2argvdata/aarch64-features-sve.aarch64-4.0.0.err delete mode 100644 tests/qemuxml2argvdata/audio-alsa-best.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/audio-alsa-full.x86_64-4.1.0.err delete mode 100644 tests/qemuxml2argvdata/audio-alsa-minimal.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/audio-coreaudio-best.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/audio-coreaudio-full.x86_64-4.1.0.err delete mode 100644 tests/qemuxml2argvdata/audio-coreaudio-minimal.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/audio-default-nographics.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/audio-file-best.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/audio-file-full.x86_64-4.1.0.err delete mode 100644 tests/qemuxml2argvdata/audio-file-minimal.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/audio-jack-full.x86_64-4.1.0.err delete mode 100644 tests/qemuxml2argvdata/audio-jack-minimal.x86_64-4.1.0.err delete mode 100644 tests/qemuxml2argvdata/audio-many-backends.x86_64-4.1.0.err delete mode 100644 tests/qemuxml2argvdata/audio-none-best.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/audio-none-full.x86_64-4.1.0.err delete mode 100644 tests/qemuxml2argvdata/audio-none-minimal.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/audio-oss-best.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/audio-oss-full.x86_64-4.1.0.err delete mode 100644 tests/qemuxml2argvdata/audio-oss-minimal.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/audio-pulseaudio-best.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/audio-pulseaudio-full.x86_64-4.1.0.err delete mode 100644 tests/qemuxml2argvdata/audio-pulseaudio-minimal.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/audio-sdl-best.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/audio-sdl-full.x86_64-4.1.0.err delete mode 100644 tests/qemuxml2argvdata/audio-sdl-minimal.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/audio-spice-best.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/audio-spice-full.x86_64-4.1.0.err delete mode 100644 tests/qemuxml2argvdata/audio-spice-minimal.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/blkdeviotune-group-num.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/blkdeviotune-max-length.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/blkdeviotune-max.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/cpu-host-model-cmt.x86_64-4.0.0.args delete mode 100644 tests/qemuxml2argvdata/cpu-host-model.x86_64-3.1.0.args delete mode 100644 tests/qemuxml2argvdata/cpu-host-model.x86_64-4.0.0.args delete mode 100644 tests/qemuxml2argvdata/cpu-host-model.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/cpu-tsc-frequency.x86_64-4.0.0.args delete mode 100644 tests/qemuxml2argvdata/disk-aio.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/disk-arm-virtio-sd.aarch64-4.0.0.args delete mode 100644 tests/qemuxml2argvdata/disk-backing-chains-index.x86_64-4.1.0.args delete mode 120000 tests/qemuxml2argvdata/disk-backing-chains-noindex.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/disk-cache.x86_64-3.1.0.args delete mode 100644 tests/qemuxml2argvdata/disk-cache.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/disk-cdrom-network.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/disk-cdrom-tray.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/disk-cdrom.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/disk-copy_on_read.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/disk-detect-zeroes.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/disk-discard.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/disk-error-policy-s390x.s390x-4.0.0.args delete mode 100644 tests/qemuxml2argvdata/disk-error-policy.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/disk-floppy-q35.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/disk-floppy.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/disk-fmt-qcow.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/disk-network-gluster.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/disk-network-iscsi.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/disk-network-nbd.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/disk-network-rbd-no-colon.x86_64-4.1.0.err delete mode 100644 tests/qemuxml2argvdata/disk-network-rbd.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/disk-network-sheepdog.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/disk-network-source-auth.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/disk-network-tlsx509-nbd.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/disk-network-tlsx509-vxhs.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/disk-readonly-disk.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/disk-shared.x86_64-3.1.0.args delete mode 100644 tests/qemuxml2argvdata/disk-shared.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/disk-source-pool-mode.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/disk-source-pool.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/disk-transient.x86_64-4.1.0.err delete mode 100644 tests/qemuxml2argvdata/disk-virtio-scsi-reservations.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/encrypted-disk-usage.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/encrypted-disk.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/firmware-manual-efi-nvram-network-iscsi.x86_64-4.1.0.err delete mode 100644 tests/qemuxml2argvdata/floppy-drive-fat.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-lsi.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-virtio-scsi.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/luks-disks-source.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/luks-disks.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2argvdata/virtio-non-transitional.x86_64-3.1.0.args delete mode 100644 tests/qemuxml2argvdata/virtio-transitional.x86_64-3.1.0.args delete mode 100644 tests/qemuxml2argvdata/x86-kvm-32-on-64.x86_64-4.1.0.args delete mode 100644 tests/qemuxml2xmloutdata/x86-kvm-32-on-64.x86_64-4.1.0.xml -- 2.36.1

4 29

[PATCH 0/3] ci: Drop Alpine-314 and Debian-10
by Peter Krempa 05 Aug '22

05 Aug '22

Alpine-314 was dropped by lcitool recently. Debian-10 will reach EOL in August, so patches 2-3/3 should be pushed only after the upcoming release. Pipeline: https://gitlab.com/pipo.sk/libvirt/-/pipelines/594315458 Peter Krempa (3): ci: Move builds from alpine-314 to alpine-315 ci: Move active Debian-10 jobs to Debian-11 ci: Drop Debian 10 ci/containers/alpine-314.Dockerfile | 81 ----------- .../debian-10-cross-aarch64.Dockerfile | 125 ----------------- .../debian-10-cross-armv6l.Dockerfile | 124 ----------------- .../debian-10-cross-armv7l.Dockerfile | 125 ----------------- ci/containers/debian-10-cross-i686.Dockerfile | 124 ----------------- ci/containers/debian-10-cross-mips.Dockerfile | 124 ----------------- .../debian-10-cross-mips64el.Dockerfile | 124 ----------------- .../debian-10-cross-mipsel.Dockerfile | 124 ----------------- .../debian-10-cross-ppc64le.Dockerfile | 124 ----------------- .../debian-10-cross-s390x.Dockerfile | 124 ----------------- ci/containers/debian-10.Dockerfile | 105 -------------- ci/gitlab.yml | 2 +- ci/gitlab/builds.yml | 130 ------------------ ci/gitlab/containers.yml | 87 ------------ ci/manifest.yml | 44 ------ 15 files changed, 1 insertion(+), 1566 deletions(-) delete mode 100644 ci/containers/alpine-314.Dockerfile delete mode 100644 ci/containers/debian-10-cross-aarch64.Dockerfile delete mode 100644 ci/containers/debian-10-cross-armv6l.Dockerfile delete mode 100644 ci/containers/debian-10-cross-armv7l.Dockerfile delete mode 100644 ci/containers/debian-10-cross-i686.Dockerfile delete mode 100644 ci/containers/debian-10-cross-mips.Dockerfile delete mode 100644 ci/containers/debian-10-cross-mips64el.Dockerfile delete mode 100644 ci/containers/debian-10-cross-mipsel.Dockerfile delete mode 100644 ci/containers/debian-10-cross-ppc64le.Dockerfile delete mode 100644 ci/containers/debian-10-cross-s390x.Dockerfile delete mode 100644 ci/containers/debian-10.Dockerfile -- 2.36.1

4 11

[PATCH] qemu_process: Destroy domain's namespace after killing QEMU
by Michal Privoznik 04 Aug '22

04 Aug '22

After QEMU is killed in qemuProcessStop() its mount namespace doesn't exist anymore, because it was the only process running there. Thus we should clear our internal flag that the domain has namespace enabled so that seclabel restore code does not try to enter it. We do the same in qemuProcessHandleMonitorEOF() but when it is us, who decides to kill QEMU rather than QEMU quitting we haven't seen EOF by the time qemuProcessStop() is called. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_process.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index d29da63242..fbf460595b 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -8265,6 +8265,9 @@ void qemuProcessStop(virQEMUDriver *driver, VIR_QEMU_PROCESS_KILL_FORCE| VIR_QEMU_PROCESS_KILL_NOCHECK)); + /* Its namespace is also gone then. */ + qemuDomainDestroyNamespace(driver, vm); + qemuDomainCleanupRun(driver, vm); qemuExtDevicesStop(driver, vm); -- 2.35.1

2 1

[libvirt PATCH v2 0/2] kbase: Improve secureboot page
by Andrea Bolognani 04 Aug '22

04 Aug '22

Changes from [v1]: * document configuration where Secure Boot support is completely absent, not just inactive; * explain in more detail how the various firmware features interact with one another. [v1] https://listman.redhat.com/archives/libvir-list/2022-August/233449.html Andrea Bolognani (2): kbase: Always explicitly enable secure-boot firmware feature kbase: Document how to disable Secure Boot entirely docs/kbase/secureboot.rst | 34 +++++++++++++++++++++++++++++++--- 1 file changed, 31 insertions(+), 3 deletions(-) -- 2.37.1

2 4

[PATCH] virhostcpu: Fix non-Linux virHostCPUGetPhysAddrSize() stub
by Michal Privoznik 04 Aug '22

04 Aug '22

The non-Linux version of virHostCPUGetPhysAddrSize() is lacking G_GNUC_UNUSED attribute to its @size argument which triggers an error on all non-Linux builds. And while at it, make the function actually signal error (ENOSYS) since it does not set the argument. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed as build breaker fix. src/util/virhostcpu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/util/virhostcpu.c b/src/util/virhostcpu.c index 3a02e224e8..54d0166b85 100644 --- a/src/util/virhostcpu.c +++ b/src/util/virhostcpu.c @@ -1672,9 +1672,10 @@ virHostCPUGetSignature(char **signature) } int -virHostCPUGetPhysAddrSize(unsigned int *size) +virHostCPUGetPhysAddrSize(unsigned int *size G_GNUC_UNUSED) { - return 0; + errno = ENOSYS; + return -1; } #endif /* __linux__ */ -- 2.35.1

1 0

[libvirt PATCH] kbase: Always explicitly enable secure-boot firmware feature
by Andrea Bolognani 04 Aug '22

04 Aug '22

It should be enough to enable or disable the enrolled-keys feature to control whether Secure Boot is enforced, but there's a slight complication: many distro packages for edk2 include, in addition to general purpose firmware images, builds that are targeting the Confidential Computing use case. For those, the firmware descriptor will not advertise the enrolled-keys feature, which will technically make them suitable for satisfying a configuration such as <os firmware='efi'> <firmware> <feature state='off' name='enrolled-keys'/> </firmware> </os> In practice, users will expect the general purpose build to be used in this case. Explicitly asking for the secure-boot feature to be enabled achieves that result at the cost of some slight additional verbosity. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- docs/kbase/secureboot.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/kbase/secureboot.rst b/docs/kbase/secureboot.rst index 8f151c1f2a..5fa59ad5e2 100644 --- a/docs/kbase/secureboot.rst +++ b/docs/kbase/secureboot.rst @@ -14,6 +14,7 @@ ask for Secure Boot to be enabled with <os firmware='efi'> <firmware> + <feature enabled='yes' name='secure-boot'/> <feature enabled='yes' name='enrolled-keys'/> </firmware> </os> @@ -24,6 +25,7 @@ and for it to be disabled with <os firmware='efi'> <firmware> + <feature enabled='yes' name='secure-boot'/> <feature enabled='no' name='enrolled-keys'/> </firmware> </os> @@ -44,6 +46,7 @@ snippet: <os firmware='efi'> <loader secure='yes'/> <firmware> + <feature enabled='yes' name='secure-boot'/> <feature enabled='yes' name='enrolled-keys'/> </firmware> </os> -- 2.37.1

2 4

[libvirt-dbus] README: Fix the broken link of libvirt-dbus
by Han Han 04 Aug '22

04 Aug '22

Signed-off-by: Han Han <hhan(a)redhat.com> --- README.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.rst b/README.rst index eacbbf2..ee20e85 100644 --- a/README.rst +++ b/README.rst @@ -13,7 +13,7 @@ API better suited for dbus-based applications. libvirt-dbus is Free Software and licenced under LGPLv2+. -* https://libvirt.org/libvirt-dbus.html +* https://libvirt.org/dbus.html The latest official releases can be found at: -- 2.37.1

2 3

[PATCH V2 0/4] Handle physical address bits
by Jim Fehlig 03 Aug '22

03 Aug '22

Hi All, This is a V2 of Dario's old patches adding support for specifying the virtual CPU address size in bits https://listman.redhat.com/archives/libvir-list/2020-October/210901.html I've rebased those patches to latest master and tweaked them a bit. E.g. I removed the qemucaps code since phys-bits and host-phys-bits have been around before the minimum qemu version supported by libvirt. I also added patches to expose the number of host address bits and ensure ABI stability as requested in the old review comments. Dario Faggioli (2): conf: Add support for specifying CPU max physical address size qemu: Add support for max physical address size Jim Fehlig (2): capabilities: Report number of host CPU physical address bits cpu conf: Check ABI stability of CPU maxphysaddr config docs/formatdomain.rst | 23 +++++++ src/conf/cpu_conf.c | 63 +++++++++++++++++++ src/conf/cpu_conf.h | 17 +++++ src/conf/schemas/cputypes.rng | 19 ++++++ src/cpu/cpu_x86.c | 8 +++ src/libvirt_private.syms | 2 + src/qemu/qemu_command.c | 21 +++++++ src/qemu/qemu_domain.c | 46 ++++++++++++++ src/qemu/qemu_validate.c | 12 ++++ src/util/virhostcpu.c | 55 ++++++++++++++++ src/util/virhostcpu.h | 3 + .../cpu-phys-bits-emulate.xml | 20 ++++++ .../cpu-phys-bits-passthrough.xml | 20 ++++++ tests/genericxml2xmltest.c | 3 + .../cpu-phys-bits-emulate.args | 32 ++++++++++ .../cpu-phys-bits-emulate.xml | 20 ++++++ .../cpu-phys-bits-emulate2.args | 32 ++++++++++ .../cpu-phys-bits-emulate2.xml | 20 ++++++ .../cpu-phys-bits-emulate3.err | 1 + .../cpu-phys-bits-emulate3.xml | 20 ++++++ .../cpu-phys-bits-passthrough.args | 32 ++++++++++ .../cpu-phys-bits-passthrough.xml | 20 ++++++ .../cpu-phys-bits-passthrough2.err | 1 + .../cpu-phys-bits-passthrough2.xml | 20 ++++++ .../cpu-phys-bits-passthrough3.err | 1 + .../cpu-phys-bits-passthrough3.xml | 20 ++++++ tests/qemuxml2argvtest.c | 7 +++ 27 files changed, 538 insertions(+) create mode 100644 tests/genericxml2xmlindata/cpu-phys-bits-emulate.xml create mode 100644 tests/genericxml2xmlindata/cpu-phys-bits-passthrough.xml create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate.args create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate.xml create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate2.args create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate2.xml create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate3.err create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate3.xml create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-passthrough.args create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-passthrough.xml create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-passthrough2.err create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-passthrough2.xml create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-passthrough3.err create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-passthrough3.xml -- 2.36.1

2 10

Live migration support for Cloud-Hypervisor VMs
by Praveen K Paladugu 03 Aug '22

03 Aug '22

Folks, We are implementing Live Migration support in "ch" driver of Libvirt. I'd like to confirm if the approach we have chosen would be accepted upstream once implemented. Our immediate goal is to implement "Hypervisor Native" + "Managed Direct" mode of migration. "Hypervisor Native" here referring to VMM(ch) being responsible for data flow. This in contrast to TUNNELED migration where data is sent over libvirt rpc. "Managed Direct" referring to virsh client responsible for control flow between source and dest hosts. The libvirtd daemons on source and destination do not have to communicate with each other. These modes are described further at https://libvirt.org/migration.html#network-data-transports. At the moment, Cloud-Hypervisor supports receiving migration data only on Unix Domain Sockets. Also, Cloud-Hypervisor does not encrypt the VM data while sending. We are considering forking "socat" processes as documented at https://github.com/cloud-hypervisor/cloud-hypervisor/blob/main/docs/live_mi…. The socat processes will be forked in "Prepare" and "Perform" phases on Destination and Source hosts respectively. I couldn't find any existing implementation in libvirt to connect Domain Sockets on different hosts. Please let me know, if you'd recommend a different approach from forking socat processes to connect Domain Sockets on source and dest hosts to allow Live VM Migration. FYI, I had an early discussion on this topic at https://gitlab.com/libvirt/libvirt/-/issues/352 and Peter suggested I follow here for broader discussion. Also Peter, rightly, suggested we look at enabling encryption of VM data in cloud-hypervisor. This is something we will follow up with after enabling Live Migration in Libvirt. -- Regards, Praveen K Paladugu

2 2

[PATCH] qemu: Move CPU validation out of PostParse
by Michal Privoznik 03 Aug '22

03 Aug '22

The qemuDomainDefCPUPostParse() does a bit more than filling in missing info. It also validates CPU cache configuration. Move that code into qemuValidateDomainDefCpu() where the code fits better. And since I need to fix indentation of existing code in qemuValidateDomainDefCpu(), I'm taking this opportunity and move error messages onto single line. Interestingly, this uncovers a bug we have in sc_prohibit_diagnostic_without_format syntax-check rule, because previously a virReportError() with a message spawned over three lines was not caught but not it is. But trying to understand that regex is a job for another time. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_domain.c | 56 ----------------- src/qemu/qemu_validate.c | 129 +++++++++++++++++++++++++++------------ 2 files changed, 89 insertions(+), 96 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index a53c25f36e..61a7297599 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -4373,62 +4373,6 @@ qemuDomainDefCPUPostParse(virDomainDef *def, if (!def->cpu) return 0; - if (def->cpu->cache) { - virCPUCacheDef *cache = def->cpu->cache; - - if (!ARCH_IS_X86(def->os.arch)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("CPU cache specification is not supported " - "for '%s' architecture"), - virArchToString(def->os.arch)); - return -1; - } - - switch (cache->mode) { - case VIR_CPU_CACHE_MODE_EMULATE: - if (cache->level != 3) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("CPU cache mode '%s' can only be used with " - "level='3'"), - virCPUCacheModeTypeToString(cache->mode)); - return -1; - } - break; - - case VIR_CPU_CACHE_MODE_PASSTHROUGH: - if (def->cpu->mode != VIR_CPU_MODE_HOST_PASSTHROUGH && - def->cpu->mode != VIR_CPU_MODE_MAXIMUM) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("CPU cache mode '%s' can only be used with " - "'%s' / '%s' CPUs"), - virCPUCacheModeTypeToString(cache->mode), - virCPUModeTypeToString(VIR_CPU_MODE_HOST_PASSTHROUGH), - virCPUModeTypeToString(VIR_CPU_MODE_MAXIMUM)); - return -1; - } - - if (cache->level != -1) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("unsupported CPU cache level for mode '%s'"), - virCPUCacheModeTypeToString(cache->mode)); - return -1; - } - break; - - case VIR_CPU_CACHE_MODE_DISABLE: - if (cache->level != -1) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("unsupported CPU cache level for mode '%s'"), - virCPUCacheModeTypeToString(cache->mode)); - return -1; - } - break; - - case VIR_CPU_CACHE_MODE_LAST: - break; - } - } - for (i = 0; i < def->cpu->nfeatures; i++) { virCPUFeatureDef *feature = &def->cpu->features[i]; diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 48bd40db9f..7fa899e411 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -332,52 +332,101 @@ qemuValidateDomainDefCpu(virQEMUDriver *driver, if (!cpu) return 0; - if (!cpu->model && cpu->mode == VIR_CPU_MODE_CUSTOM) - return 0; - - switch ((virCPUMode) cpu->mode) { - case VIR_CPU_MODE_HOST_PASSTHROUGH: - if (def->os.arch == VIR_ARCH_ARMV7L && - driver->hostarch == VIR_ARCH_AARCH64) { - if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_CPU_AARCH64_OFF)) { + if (def->cpu->cache) { + virCPUCacheDef *cache = def->cpu->cache; + + if (!ARCH_IS_X86(def->os.arch)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("CPU cache specification is not supported for '%s' architecture"), + virArchToString(def->os.arch)); + return -1; + } + + switch (cache->mode) { + case VIR_CPU_CACHE_MODE_EMULATE: + if (cache->level != 3) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("QEMU binary does not support CPU " - "host-passthrough for armv7l on " - "aarch64 host")); + _("CPU cache mode '%s' can only be used with level='3'"), + virCPUCacheModeTypeToString(cache->mode)); return -1; } - } + break; - if (cpu->migratable && - cpu->migratable != VIR_TRISTATE_SWITCH_OFF && - !virQEMUCapsGet(qemuCaps, QEMU_CAPS_CPU_MIGRATABLE)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Migratable attribute for host-passthrough " - "CPU is not supported by this QEMU binary")); - return -1; - } - break; - - case VIR_CPU_MODE_HOST_MODEL: - /* qemu_command.c will error out if cpu->mode is HOST_MODEL for - * every arch but PPC64. However, we can't move this validation - * here because non-PPC64 archs will translate HOST_MODEL to - * something else during domain start, changing cpu->mode to - * CUSTOM. - */ - break; - - case VIR_CPU_MODE_MAXIMUM: - if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_CPU_MAX)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("maximum CPU is not supported by QEMU binary")); - return -1; + case VIR_CPU_CACHE_MODE_PASSTHROUGH: + if (def->cpu->mode != VIR_CPU_MODE_HOST_PASSTHROUGH && + def->cpu->mode != VIR_CPU_MODE_MAXIMUM) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("CPU cache mode '%s' can only be used with '%s' / '%s' CPUs"), + virCPUCacheModeTypeToString(cache->mode), + virCPUModeTypeToString(VIR_CPU_MODE_HOST_PASSTHROUGH), + virCPUModeTypeToString(VIR_CPU_MODE_MAXIMUM)); + return -1; + } + + if (cache->level != -1) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("unsupported CPU cache level for mode '%s'"), + virCPUCacheModeTypeToString(cache->mode)); + return -1; + } + break; + + case VIR_CPU_CACHE_MODE_DISABLE: + if (cache->level != -1) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("unsupported CPU cache level for mode '%s'"), + virCPUCacheModeTypeToString(cache->mode)); + return -1; + } + break; + + case VIR_CPU_CACHE_MODE_LAST: + break; } - break; + } + + if (cpu->model || cpu->mode != VIR_CPU_MODE_CUSTOM) { + switch ((virCPUMode) cpu->mode) { + case VIR_CPU_MODE_HOST_PASSTHROUGH: + if (def->os.arch == VIR_ARCH_ARMV7L && + driver->hostarch == VIR_ARCH_AARCH64) { + if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_CPU_AARCH64_OFF)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("QEMU binary does not support CPU host-passthrough for armv7l on aarch64 host")); + return -1; + } + } - case VIR_CPU_MODE_CUSTOM: - case VIR_CPU_MODE_LAST: - break; + if (cpu->migratable && + cpu->migratable != VIR_TRISTATE_SWITCH_OFF && + !virQEMUCapsGet(qemuCaps, QEMU_CAPS_CPU_MIGRATABLE)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Migratable attribute for host-passthrough CPU is not supported by this QEMU binary")); + return -1; + } + break; + + case VIR_CPU_MODE_HOST_MODEL: + /* qemu_command.c will error out if cpu->mode is HOST_MODEL for + * every arch but PPC64. However, we can't move this validation + * here because non-PPC64 archs will translate HOST_MODEL to + * something else during domain start, changing cpu->mode to + * CUSTOM. + */ + break; + + case VIR_CPU_MODE_MAXIMUM: + if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_CPU_MAX)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("maximum CPU is not supported by QEMU binary")); + return -1; + } + break; + + case VIR_CPU_MODE_CUSTOM: + case VIR_CPU_MODE_LAST: + break; + } } return 0; -- 2.35.1

2 1

[libvirt PATCH] qemu: Reset stored memlock limit when stopping QEMU
by Jiri Denemark 03 Aug '22

03 Aug '22

When resetting private data after stopping QEMU process we should also reset the original memory locking limit (both normal and pre-migration) as they are not relevant anymore. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_domain.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index a53c25f36e..12c58a25b9 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -1705,6 +1705,9 @@ qemuDomainObjPrivateDataClear(qemuDomainObjPrivate *priv) g_slist_free_full(g_steal_pointer(&priv->dbusVMStateIds), g_free); priv->dbusVMState = false; + + priv->originalMemlock = 0; + priv->preMigrationMemlock = 0; } -- 2.35.1

2 1

[libvirt PATCH] qemu: Do not try to set memlock on inactive domain
by Jiri Denemark 03 Aug '22

03 Aug '22

When we call qemuDomainSetMaxMemLock to reset memory locking limit back to its original value the domain can already be stopped (for example after the domain shuts down during migration) in which case it does not make sense to set any limit. Doing so can even be harmful as we may end up setting the limit for the daemon itself as the PID is 0. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_domain.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 12c58a25b9..ad6c614d89 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -9461,6 +9461,10 @@ qemuDomainSetMaxMemLock(virDomainObj *vm, { unsigned long long current = 0; + /* nothing to do if the domain is not running */ + if (vm->pid <= 0) + return 0; + if (virProcessGetMaxMemLock(vm->pid, &current) < 0) return -1; -- 2.35.1

2 1

[PATCH 0/4] testutilsqemu: Fake TPM versions
by Michal Privoznik 03 Aug '22

03 Aug '22

Technically, this is a v2 of: https://listman.redhat.com/archives/libvir-list/2022-July/233306.html but not really. Because I've discarded the 3/3 from original series and implemented Andrea's idea. Michal Prívozník (4): src: Export virDomainTPMVersion enum conversion helpers testutilsqemu: Fake TPM versions qemu_validate: Validate TPM version qemuxml2argvtest: Add negative cases for TPM version src/libvirt_private.syms | 2 ++ src/qemu/qemu_validate.c | 15 ++++++++++++--- tests/domaincapsdata/qemu_3.1.0-q35.x86_64.xml | 3 +++ tests/domaincapsdata/qemu_3.1.0-tcg.x86_64.xml | 3 +++ tests/domaincapsdata/qemu_3.1.0.x86_64.xml | 3 +++ tests/domaincapsdata/qemu_4.0.0-q35.x86_64.xml | 3 +++ tests/domaincapsdata/qemu_4.0.0-tcg.x86_64.xml | 3 +++ tests/domaincapsdata/qemu_4.0.0.x86_64.xml | 3 +++ tests/domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 3 +++ tests/domaincapsdata/qemu_4.1.0-tcg.x86_64.xml | 3 +++ tests/domaincapsdata/qemu_4.1.0.x86_64.xml | 3 +++ tests/domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 3 +++ tests/domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 3 +++ tests/domaincapsdata/qemu_4.2.0.ppc64.xml | 3 +++ tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 3 +++ tests/domaincapsdata/qemu_5.0.0-q35.x86_64.xml | 3 +++ tests/domaincapsdata/qemu_5.0.0-tcg.x86_64.xml | 3 +++ .../domaincapsdata/qemu_5.0.0-virt.aarch64.xml | 3 +++ tests/domaincapsdata/qemu_5.0.0.aarch64.xml | 3 +++ tests/domaincapsdata/qemu_5.0.0.ppc64.xml | 3 +++ tests/domaincapsdata/qemu_5.0.0.x86_64.xml | 3 +++ tests/domaincapsdata/qemu_5.1.0-q35.x86_64.xml | 3 +++ tests/domaincapsdata/qemu_5.1.0-tcg.x86_64.xml | 3 +++ tests/domaincapsdata/qemu_5.1.0.x86_64.xml | 3 +++ tests/domaincapsdata/qemu_5.2.0-q35.x86_64.xml | 3 +++ tests/domaincapsdata/qemu_5.2.0-tcg.x86_64.xml | 3 +++ .../domaincapsdata/qemu_5.2.0-virt.aarch64.xml | 3 +++ tests/domaincapsdata/qemu_5.2.0.aarch64.xml | 3 +++ tests/domaincapsdata/qemu_5.2.0.ppc64.xml | 3 +++ tests/domaincapsdata/qemu_5.2.0.x86_64.xml | 3 +++ tests/domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 4 ++++ tests/domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 4 ++++ .../domaincapsdata/qemu_6.0.0-virt.aarch64.xml | 4 ++++ tests/domaincapsdata/qemu_6.0.0.aarch64.xml | 4 ++++ tests/domaincapsdata/qemu_6.0.0.x86_64.xml | 4 ++++ tests/domaincapsdata/qemu_6.1.0-q35.x86_64.xml | 4 ++++ tests/domaincapsdata/qemu_6.1.0-tcg.x86_64.xml | 4 ++++ tests/domaincapsdata/qemu_6.1.0.x86_64.xml | 4 ++++ tests/domaincapsdata/qemu_6.2.0-q35.x86_64.xml | 4 ++++ tests/domaincapsdata/qemu_6.2.0-tcg.x86_64.xml | 4 ++++ .../domaincapsdata/qemu_6.2.0-virt.aarch64.xml | 4 ++++ tests/domaincapsdata/qemu_6.2.0.aarch64.xml | 4 ++++ tests/domaincapsdata/qemu_6.2.0.ppc64.xml | 4 ++++ tests/domaincapsdata/qemu_6.2.0.x86_64.xml | 4 ++++ tests/domaincapsdata/qemu_7.0.0-q35.x86_64.xml | 3 +++ tests/domaincapsdata/qemu_7.0.0-tcg.x86_64.xml | 3 +++ .../domaincapsdata/qemu_7.0.0-virt.aarch64.xml | 3 +++ tests/domaincapsdata/qemu_7.0.0.aarch64.xml | 3 +++ tests/domaincapsdata/qemu_7.0.0.ppc64.xml | 3 +++ tests/domaincapsdata/qemu_7.0.0.x86_64.xml | 3 +++ tests/domaincapsdata/qemu_7.1.0-q35.x86_64.xml | 3 +++ tests/domaincapsdata/qemu_7.1.0-tcg.x86_64.xml | 3 +++ tests/domaincapsdata/qemu_7.1.0.x86_64.xml | 3 +++ tests/domaincapstest.c | 17 ++++++++++++++++- .../tpm-emulator-tpm2.x86_64-latest.err | 1 + .../tpm-emulator.x86_64-latest.err | 1 + tests/qemuxml2argvtest.c | 6 ++++++ tests/testutilsqemu.c | 13 +++++++++++-- tests/testutilsqemu.h | 3 +++ 59 files changed, 219 insertions(+), 6 deletions(-) create mode 100644 tests/qemuxml2argvdata/tpm-emulator-tpm2.x86_64-latest.err create mode 100644 tests/qemuxml2argvdata/tpm-emulator.x86_64-latest.err -- 2.35.1

2 5

[PATCH 0/6] qemu: Remove monitor socket waiting code
by Peter Krempa 02 Aug '22

02 Aug '22

We either pre-open a socket and pass the file descriptor to qemu or are guaranteed that the socket is open by other means. The qemu monitor code can be simplified a lot. Peter Krempa (6): qemu: process: Remove 'retry' argument from qemuConnectMonitor qemu: monitor: Remove 'timeout' argument from qemuMonitorOpen qemuMonitorTestNew: Call qemuMonitorOpen with 'retry' false qemuProcessQMPConnectMonitor: Connect to probing monitor with 'retry' set to false qemuMonitorOpenUnix: Remove 'retry' argument qemuMonitorOpenUnix: Don't overwrite 'ret' needlessly src/qemu/qemu_monitor.c | 59 +++++------------------------------- src/qemu/qemu_monitor.h | 4 +-- src/qemu/qemu_process.c | 24 +++------------ tests/qemumonitortestutils.c | 2 -- 4 files changed, 13 insertions(+), 76 deletions(-) -- 2.36.1

2 7

[PATCH] qemu_capabilities: replace code with function call
by Kristina Hanicova 02 Aug '22

02 Aug '22

Since functions virQEMUCapsFillDomainFeatureSEVCaps() and virQEMUCapsSEVInfoCopy() essentially do the same thing it does not make sense to have the code duplicated. This patch replaces the relevant code in the first function with the function call to the second one. Signed-off-by: Kristina Hanicova <khanicov(a)redhat.com> --- Notes: Pointed out by Michal src/qemu/qemu_capabilities.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index b002fb98ed..53223417ae 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -6495,18 +6495,7 @@ virQEMUCapsFillDomainFeatureSEVCaps(virQEMUCaps *qemuCaps, if (!cap) return; - domCaps->sev = g_new0(virSEVCapability, 1); - - domCaps->sev->pdh = g_strdup(cap->pdh); - domCaps->sev->cert_chain = g_strdup(cap->cert_chain); - if (cap->cpu0_id != NULL) { - domCaps->sev->cpu0_id = g_strdup(cap->cpu0_id); - } - - domCaps->sev->cbitpos = cap->cbitpos; - domCaps->sev->reduced_phys_bits = cap->reduced_phys_bits; - domCaps->sev->max_guests = cap->max_guests; - domCaps->sev->max_es_guests = cap->max_es_guests; + virQEMUCapsSEVInfoCopy(&domCaps->sev, cap); } -- 2.37.1

2 1

[PATCH 0/2] Fix build with glibc 2.36
by Cole Robinson 02 Aug '22

02 Aug '22

With glibc 2.36, sys/mount.h and linux/mount.h conflict: https://sourceware.org/glibc/wiki/Release/2.36#Usage_of_.3Clinux.2Fmount.h.… Easiest way to run this through CI? Submit MR to libvirt gitlab? Cole Robinson (2): lxc: containter: fix build with glibc 2.36 virfile: Fix build with glibc 2.36 src/lxc/lxc_container.c | 3 --- src/util/virfile.c | 4 +++- 2 files changed, 3 insertions(+), 4 deletions(-) -- 2.36.1

2 6

[libvirt PATCH 0/2] fix console device access in ch driver
by Praveen K Paladugu 02 Aug '22

02 Aug '22

Patch1: Drops the check to only have a console/serial device configured for ch VMs. This is no longer needed. Patch2: Addresses https://gitlab.com/libvirt/libvirt/-/issues/344. Libvirt adds compat console devices for "hvm" VMs. The added console/serial device type is initialized to VIR_DOMAIN_CHR_TYPE_NULL, when in fact the device added is a pty device. This patch modifies the default console device type to "pty". I looked at NOT adding Compat Console devices for ch VMs. But this looked like a better fix. Praveen K Paladugu (2): ch: drop the check to have a single console/serial conf: set the default chr device type to pty src/ch/ch_domain.c | 9 +-------- src/conf/domain_conf.c | 1 + 2 files changed, 2 insertions(+), 8 deletions(-) -- 2.27.0

2 5

[PATCH 0/3] testutilsqemu: Fake TPM versions
by Michal Privoznik 02 Aug '22

02 Aug '22

I thought I've sent these before the freeze but as I tried to ping them, I realize I didn't. I'm not sure how critical these are to get into the release (after all we see no test failing), but they make at least VIR_TEST_DEBUG output of domcapabilities cleaner. Michal Prívozník (3): virtpm: Use corresponding type for argument for virTPM*CapsGet() testutilsqemu: Mock virTPMSwtpmSetupCapsGet() testutilsqemu: Fake TPM versions src/util/virtpm.c | 4 ++-- src/util/virtpm.h | 6 +++--- .../domaincapsdata/qemu_3.1.0-q35.x86_64.xml | 4 ++++ .../domaincapsdata/qemu_3.1.0-tcg.x86_64.xml | 4 ++++ tests/domaincapsdata/qemu_3.1.0.x86_64.xml | 4 ++++ .../domaincapsdata/qemu_4.0.0-q35.x86_64.xml | 4 ++++ .../domaincapsdata/qemu_4.0.0-tcg.x86_64.xml | 4 ++++ tests/domaincapsdata/qemu_4.0.0.x86_64.xml | 4 ++++ .../domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 4 ++++ .../domaincapsdata/qemu_4.1.0-tcg.x86_64.xml | 4 ++++ tests/domaincapsdata/qemu_4.1.0.x86_64.xml | 4 ++++ .../domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 4 ++++ .../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 4 ++++ tests/domaincapsdata/qemu_4.2.0.ppc64.xml | 4 ++++ tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 4 ++++ .../domaincapsdata/qemu_5.0.0-q35.x86_64.xml | 4 ++++ .../domaincapsdata/qemu_5.0.0-tcg.x86_64.xml | 4 ++++ .../qemu_5.0.0-virt.aarch64.xml | 4 ++++ tests/domaincapsdata/qemu_5.0.0.aarch64.xml | 4 ++++ tests/domaincapsdata/qemu_5.0.0.ppc64.xml | 4 ++++ tests/domaincapsdata/qemu_5.0.0.x86_64.xml | 4 ++++ .../domaincapsdata/qemu_5.1.0-q35.x86_64.xml | 4 ++++ .../domaincapsdata/qemu_5.1.0-tcg.x86_64.xml | 4 ++++ tests/domaincapsdata/qemu_5.1.0.x86_64.xml | 4 ++++ .../domaincapsdata/qemu_5.2.0-q35.x86_64.xml | 4 ++++ .../domaincapsdata/qemu_5.2.0-tcg.x86_64.xml | 4 ++++ .../qemu_5.2.0-virt.aarch64.xml | 4 ++++ tests/domaincapsdata/qemu_5.2.0.aarch64.xml | 4 ++++ tests/domaincapsdata/qemu_5.2.0.ppc64.xml | 4 ++++ tests/domaincapsdata/qemu_5.2.0.x86_64.xml | 4 ++++ .../domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 4 ++++ .../domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 4 ++++ .../qemu_6.0.0-virt.aarch64.xml | 4 ++++ tests/domaincapsdata/qemu_6.0.0.aarch64.xml | 4 ++++ tests/domaincapsdata/qemu_6.0.0.x86_64.xml | 4 ++++ .../domaincapsdata/qemu_6.1.0-q35.x86_64.xml | 4 ++++ .../domaincapsdata/qemu_6.1.0-tcg.x86_64.xml | 4 ++++ tests/domaincapsdata/qemu_6.1.0.x86_64.xml | 4 ++++ .../domaincapsdata/qemu_6.2.0-q35.x86_64.xml | 4 ++++ .../domaincapsdata/qemu_6.2.0-tcg.x86_64.xml | 4 ++++ .../qemu_6.2.0-virt.aarch64.xml | 4 ++++ tests/domaincapsdata/qemu_6.2.0.aarch64.xml | 4 ++++ tests/domaincapsdata/qemu_6.2.0.ppc64.xml | 4 ++++ tests/domaincapsdata/qemu_6.2.0.x86_64.xml | 4 ++++ .../domaincapsdata/qemu_7.0.0-q35.x86_64.xml | 4 ++++ .../domaincapsdata/qemu_7.0.0-tcg.x86_64.xml | 4 ++++ .../qemu_7.0.0-virt.aarch64.xml | 4 ++++ tests/domaincapsdata/qemu_7.0.0.aarch64.xml | 4 ++++ tests/domaincapsdata/qemu_7.0.0.ppc64.xml | 4 ++++ tests/domaincapsdata/qemu_7.0.0.x86_64.xml | 4 ++++ .../domaincapsdata/qemu_7.1.0-q35.x86_64.xml | 4 ++++ .../domaincapsdata/qemu_7.1.0-tcg.x86_64.xml | 4 ++++ tests/domaincapsdata/qemu_7.1.0.x86_64.xml | 4 ++++ tests/testutilsqemu.c | 19 +++++++++++++++++++ 54 files changed, 228 insertions(+), 5 deletions(-) -- 2.35.1

3 8

[PATCH] tpm: Refactor open-coded bitmap 'activePcrBanks' to virBitmap
by Peter Krempa 01 Aug '22

01 Aug '22

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- Applies on top of Michal's series to fix 'activePcrBank' handling. src/conf/domain_conf.c | 17 +++++++++-------- src/conf/domain_conf.h | 2 +- src/qemu/qemu_tpm.c | 21 +++++++++------------ 3 files changed, 19 insertions(+), 21 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index ddd6fe1c90..fccb29bc63 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -3255,6 +3255,7 @@ void virDomainTPMDefFree(virDomainTPMDef *def) virObjectUnref(def->data.emulator.source); g_free(def->data.emulator.storagepath); g_free(def->data.emulator.logfile); + virBitmapFree(def->data.emulator.activePcrBanks); break; case VIR_DOMAIN_TPM_TYPE_LAST: break; @@ -10442,6 +10443,8 @@ virDomainTPMDefParseXML(virDomainXMLOption *xmlopt, if ((nnodes = virXPathNodeSet("./backend/active_pcr_banks/*", ctxt, &nodes)) < 0) break; + if (nnodes > 0) + def->data.emulator.activePcrBanks = virBitmapNew(0); for (i = 0; i < nnodes; i++) { if ((bank = virDomainTPMPcrBankTypeFromString((const char *)nodes[i]->name)) < 0) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, @@ -10449,7 +10452,7 @@ virDomainTPMDefParseXML(virDomainXMLOption *xmlopt, nodes[i]->name); goto error; } - def->data.emulator.activePcrBanks |= (1 << bank); + virBitmapSetBitExpand(def->data.emulator.activePcrBanks, bank); } break; case VIR_DOMAIN_TPM_TYPE_LAST: @@ -20671,7 +20674,8 @@ virDomainTPMDefCheckABIStability(virDomainTPMDef *src, return false; } - if (src->data.emulator.activePcrBanks != dst->data.emulator.activePcrBanks) { + if (!virBitmapEqual(src->data.emulator.activePcrBanks, + dst->data.emulator.activePcrBanks)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("Target active PCR banks doesn't match source")); return false; @@ -24235,13 +24239,10 @@ virDomainTPMDefFormat(virBuffer *buf, } if (def->data.emulator.activePcrBanks) { g_auto(virBuffer) activePcrBanksBuf = VIR_BUFFER_INIT_CHILD(&backendChildBuf); - size_t i; + ssize_t bank = -1; - for (i = VIR_DOMAIN_TPM_PCR_BANK_SHA1; i < VIR_DOMAIN_TPM_PCR_BANK_LAST; i++) { - if ((def->data.emulator.activePcrBanks & (1 << i))) - virBufferAsprintf(&activePcrBanksBuf, "<%s/>\n", - virDomainTPMPcrBankTypeToString(i)); - } + while ((bank = virBitmapNextSetBit(def->data.emulator.activePcrBanks, bank)) > -1) + virBufferAsprintf(&activePcrBanksBuf, "<%s/>\n", virDomainTPMPcrBankTypeToString(bank)); virXMLFormatElement(&backendChildBuf, "active_pcr_banks", NULL, &activePcrBanksBuf); } diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 200a75d705..724265b6b5 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -1451,7 +1451,7 @@ struct _virDomainTPMDef { unsigned char secretuuid[VIR_UUID_BUFLEN]; bool hassecretuuid; bool persistent_state; - unsigned int activePcrBanks; + virBitmap *activePcrBanks; } emulator; } data; }; diff --git a/src/qemu/qemu_tpm.c b/src/qemu/qemu_tpm.c index f28dd2e1e9..c08b0851da 100644 --- a/src/qemu/qemu_tpm.c +++ b/src/qemu/qemu_tpm.c @@ -444,19 +444,16 @@ qemuTPMEmulatorRunSetup(const char *storagepath, static char * -qemuTPMPcrBankBitmapToStr(unsigned int pcrBanks) +qemuTPMPcrBankBitmapToStr(virBitmap *activePcrBanks) { g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; - const char *comma = ""; - size_t i; - - for (i = VIR_DOMAIN_TPM_PCR_BANK_SHA1; i < VIR_DOMAIN_TPM_PCR_BANK_LAST; i++) { - if (pcrBanks & (1 << i)) { - virBufferAsprintf(&buf, "%s%s", - comma, virDomainTPMPcrBankTypeToString(i)); - comma = ","; - } - } + ssize_t bank = -1; + + while ((bank = virBitmapNextSetBit(activePcrBanks, bank)) > -1) + virBufferAsprintf(&buf, "%s,", virDomainTPMPcrBankTypeToString(bank)); + + virBufferTrim(&buf, ","); + return virBufferContentAndReset(&buf); } @@ -481,7 +478,7 @@ static int qemuTPMEmulatorReconfigure(const char *storagepath, uid_t swtpm_user, gid_t swtpm_group, - unsigned int activePcrBanks, + virBitmap *activePcrBanks, const char *logfile, const virDomainTPMVersion tpmversion, const unsigned char *secretuuid) -- 2.36.1

2 1

[PATCH 0/8] conf: Don't lose <active_pcr_banks/> when no TPM version is provided
by Michal Privoznik 01 Aug '22

01 Aug '22

*** BLURB HERE *** Michal Prívozník (8): conf: Report an error when default TPM model is provided conf: Report error when default TPM version is provided conf: Drop needless setting of VIR_DOMAIN_TPM_VERSION_DEFAULT conf: Move _virDomainTPMDef::version into _virDomainTPMDef::data::emulator conf: Use virXMLPropEnum more when parsing TPM qemu_domain: Move TPM post parse code into qemuDomainTPMDefPostParse() qemu: Move TPMs validation out of PostParse conf: Don't lose <active_pcr_banks/> when no TPM version is provided src/conf/domain_conf.c | 81 +++++++++++++------------------- src/conf/domain_conf.h | 10 ++-- src/conf/domain_validate.c | 28 ++++++++++- src/qemu/qemu_command.c | 2 +- src/qemu/qemu_domain.c | 63 ++++++------------------- src/qemu/qemu_tpm.c | 10 ++-- src/qemu/qemu_validate.c | 87 ++++++++++++++++++++++++----------- src/security/virt-aa-helper.c | 2 +- 8 files changed, 147 insertions(+), 136 deletions(-) -- 2.35.1

3 23

Can RHEL7 VM run remote libvirt commands to Fedora36 host?
by Carol Bouchard 01 Aug '22

01 Aug '22

I have a test environment that use to work but no longer does. My laptop is Fedora36 (libvirt version 8.1.0.2) while the VMs it spawns are RHEL7 (max libvirt version is 4.5.0). The source of my problem seems to be that RHEL7 libvirt needs rw socket /var/run/libvirt/libvirt-sock which no longer exists in fedora36. The following is successful from RHEL7 VM to laptop: virsh -d0 --connect 'qemu+ssh://192.168.120.1/system?*socket*=/var/run/libvirt/libvirt-sock-ro' domstate beaker-test-vm1.beaker If I change the action from domstate to start, it fails on error: Failed to start domain beaker-test-vm1.beaker error: operation forbidden: read only access prevents virDomainCreate which made me realize ro stands for read-only; however, there is no libvirt-sock. I tried some of the other socket files without success. Is there a work-around? Carol

2 3

[PATCH] spec: Remove duplicate check of libvirtd status
by Jim Fehlig 01 Aug '22

01 Aug '22

The %posttrans scriptlet checks if libvirtd is active within a condition that is only executed if libvirtd is active. Remove the duplicate check. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- This patch contains an improvement Martin suggested while reviewing another patch to the posttrans scriptlet https://listman.redhat.com/archives/libvir-list/2022-July/232947.html The problem of not restarting socket units if libvird is inactive persists, but it is not clear if socket units need restarted on package update. libvirt.spec.in | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 9d788b790f..a238edf2aa 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1365,18 +1365,12 @@ then # own the sockets again when it comes back up. Thus we must # do this particular ordering, so that we get libvirtd # running with socket activation in use - /bin/systemctl is-active libvirtd.service 1>/dev/null 2>&1 - if test $? = 0 - then - /bin/systemctl stop libvirtd.service >/dev/null 2>&1 || : - - /bin/systemctl try-restart \ - libvirtd.socket \ - libvirtd-ro.socket \ - libvirtd-admin.socket >/dev/null 2>&1 || : - - /bin/systemctl start libvirtd.service >/dev/null 2>&1 || : - fi + /bin/systemctl stop libvirtd.service >/dev/null 2>&1 || : + /bin/systemctl try-restart \ + libvirtd.socket \ + libvirtd-ro.socket \ + libvirtd-admin.socket >/dev/null 2>&1 || : + /bin/systemctl start libvirtd.service >/dev/null 2>&1 || : fi fi -- 2.36.1

2 2

Release of libvirt-8.6.0
by Jiri Denemark 01 Aug '22

01 Aug '22

The 8.6.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://libvirt.org/sources/ https://libvirt.org/sources/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is greatly appreciated. * Improvements * conf: Improved firmware autoselection The firmware autoselection feature now behaves more intuitively, reports better error messages on failure and comes with high-level documentation. Enjoy. Jirka

1 0

[libvirt] Semantic change in v4.3 slows down image creation and snapshots (on ZFS)
by Christian Ehrhardt 31 Jul '22

31 Jul '22

Hi, when discussing bug [1] triggered by [2] Daniel and I have found that the change [3] which is in since v4.3 was a semantic change to the behavior of libvirt. virt-manager used and still does issue a volume XML like: <volume> <name>disk.qcow2</name> <capacity>16106127360</capacity> <allocation>16106127360</allocation> <target> <format type="qcow2"/> <features> <lazy_refcounts/> </features> </target> </volume> Up until the commit above that was using preallocation=metadata, but now uses preallocation=falloc. In many cases (read: Fileystems) that won't be very user-visible, but if you are running on ZFS (or anything else that can't fallocate well) this is made worse by [4] slowing down these operations a lot. After the POV for virt-manager seems to have settled on the bug [1] referenced the remaining question is if libvirt should revert/modify the change [3] - and that we agreed required a wider discussion to be had here, hence this mail. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1759454 [2]: https://bugs.launchpad.net/virt-manager/+bug/1847105 [3]: https://libvirt.org/git/?p=libvirt.git;a=commit;h=c9ec7088c7a3f4cd26bb471f1… [4]: https://github.com/zfsonlinux/zfs/issues/326 -- Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd

4 3

Feature proposal: support setting block I/O throttling for vhostuser disk
by jlwang 29 Jul '22

29 Jul '22

Hi, blkdeviotune command don't support setting I/O throttlig for vhostuser disk. We propose to commit patch to support the feature. Are there any issues that would prevent this feature from being accepted? Thanks, Wang Jinlei

1 0

[libvirt PATCH 0/2] qemu: support stateless UEFI firmware
by Daniel P. Berrangé 29 Jul '22

29 Jul '22

This is to enable SEV builds of UEFI which provide only a single CODE.fd file, with not VARS.fd. Daniel P. Berrangé (2): conf: support stateless UEFI firmware qemu: support use of stateless EFI firmware docs/formatdomain.rst | 9 +++- src/conf/domain_conf.c | 9 ++++ src/conf/domain_conf.h | 1 + src/conf/domain_validate.c | 26 ++++++++++ src/conf/schemas/domaincommon.rng | 5 ++ src/qemu/qemu_domain.c | 3 +- src/qemu/qemu_firmware.c | 48 +++++++++++-------- ...-auto-bios-not-stateless.x86_64-latest.err | 1 + .../firmware-auto-bios-not-stateless.xml | 18 +++++++ ...are-auto-bios-stateless.x86_64-latest.args | 32 +++++++++++++ .../firmware-auto-bios-stateless.xml | 18 +++++++ ...ware-auto-efi-stateless.x86_64-latest.args | 33 +++++++++++++ .../firmware-auto-efi-stateless.xml | 18 +++++++ .../firmware-manual-bios-not-stateless.err | 1 + .../firmware-manual-bios-not-stateless.xml | 15 ++++++ .../firmware-manual-bios-stateless.args | 30 ++++++++++++ .../firmware-manual-bios-stateless.xml | 15 ++++++ ...nual-efi-nvram-stateless.x86_64-latest.err | 1 + .../firmware-manual-efi-nvram-stateless.xml | 21 ++++++++ ...nvram-template-stateless.x86_64-latest.err | 1 + ...re-manual-efi-nvram-template-stateless.xml | 19 ++++++++ ...re-manual-efi-stateless.x86_64-latest.args | 33 +++++++++++++ .../firmware-manual-efi-stateless.xml | 18 +++++++ tests/qemuxml2argvtest.c | 10 ++++ ...ware-auto-bios-stateless.x86_64-latest.xml | 34 +++++++++++++ .../firmware-manual-bios-stateless.xml | 25 ++++++++++ .../firmware-manual-bios.xml | 25 ++++++++++ tests/qemuxml2xmltest.c | 3 ++ 28 files changed, 451 insertions(+), 21 deletions(-) create mode 100644 tests/qemuxml2argvdata/firmware-auto-bios-not-stateless.x86_64-latest.err create mode 100644 tests/qemuxml2argvdata/firmware-auto-bios-not-stateless.xml create mode 100644 tests/qemuxml2argvdata/firmware-auto-bios-stateless.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/firmware-auto-bios-stateless.xml create mode 100644 tests/qemuxml2argvdata/firmware-auto-efi-stateless.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/firmware-auto-efi-stateless.xml create mode 100644 tests/qemuxml2argvdata/firmware-manual-bios-not-stateless.err create mode 100644 tests/qemuxml2argvdata/firmware-manual-bios-not-stateless.xml create mode 100644 tests/qemuxml2argvdata/firmware-manual-bios-stateless.args create mode 100644 tests/qemuxml2argvdata/firmware-manual-bios-stateless.xml create mode 100644 tests/qemuxml2argvdata/firmware-manual-efi-nvram-stateless.x86_64-latest.err create mode 100644 tests/qemuxml2argvdata/firmware-manual-efi-nvram-stateless.xml create mode 100644 tests/qemuxml2argvdata/firmware-manual-efi-nvram-template-stateless.x86_64-latest.err create mode 100644 tests/qemuxml2argvdata/firmware-manual-efi-nvram-template-stateless.xml create mode 100644 tests/qemuxml2argvdata/firmware-manual-efi-stateless.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/firmware-manual-efi-stateless.xml create mode 100644 tests/qemuxml2xmloutdata/firmware-auto-bios-stateless.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/firmware-manual-bios-stateless.xml create mode 100644 tests/qemuxml2xmloutdata/firmware-manual-bios.xml -- 2.36.1

3 9

Entering freeze for libvirt-8.6.0
by Jiri Denemark 29 Jul '22

29 Jul '22

I have just tagged v8.6.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Thanks, Jirka

1 1

[libvirt PATCH for 8.6.0] qemu_migration_params: Avoid deadlock in qemuMigrationParamsReset
by Jiri Denemark 29 Jul '22

29 Jul '22

In my recent comnmit v8.5.0-188-gc47f1abb81 I accidentally moved qemuMigrationParamsResetTLS after qemuDomainObjEnterMonitorAsync not noticing qemuMigrationParamsResetTLS will try to enter the monitor again. The second call will time out and return with a domain object locked. But we're still in monitor section and the object should be unlocked which means qemuDomainObjExitMonitor will deadlock trying to lock it again. Fixes: c47f1abb81194461377a0c608a7ecd87f9ce9146 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_migration_params.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_params.c index be7966a18a..9da2fd6d98 100644 --- a/src/qemu/qemu_migration_params.c +++ b/src/qemu/qemu_migration_params.c @@ -1291,6 +1291,7 @@ qemuMigrationParamsReset(virQEMUDriver *driver, { virErrorPtr err; g_autoptr(virBitmap) clearCaps = NULL; + int rc; virErrorPreserveLast(&err); @@ -1305,11 +1306,16 @@ qemuMigrationParamsReset(virQEMUDriver *driver, clearCaps = virBitmapNew(0); - if (qemuMigrationParamsApplyCaps(vm, clearCaps) == 0 && - qemuMigrationParamsApplyValues(vm, origParams, false) == 0) - qemuMigrationParamsResetTLS(driver, vm, asyncJob, origParams, apiFlags); + rc = 0; + if (qemuMigrationParamsApplyCaps(vm, clearCaps) < 0 || + qemuMigrationParamsApplyValues(vm, origParams, false) < 0) + rc = -1; qemuDomainObjExitMonitor(vm); + if (rc < 0) + goto cleanup; + + qemuMigrationParamsResetTLS(driver, vm, asyncJob, origParams, apiFlags); cleanup: virErrorRestore(&err); -- 2.35.1

2 1

[PATCH] virjson: Change virJSONValueObjectHasKey() signature
by Michal Privoznik 28 Jul '22

28 Jul '22

Currently, virJSONValueObjectHasKey() can return one of three values: -1 if passed object type is not VIR_JSON_TYPE_OBJECT, 0 if the key is not present, and finally 1 if the key is present. But, neither of callers is interested in the -1 case. In fact, some callers call this function treating -1 and 1 cases the same. Therefore, make the function return just true/false and fix few callers that explicitly checked for == 1 case. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_agent.c | 8 ++++---- src/qemu/qemu_monitor_json.c | 10 +++++----- src/util/virjson.c | 8 ++++---- src/util/virjson.h | 2 +- 4 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index d81f01ba77..0d77a2f90d 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -231,12 +231,12 @@ qemuAgentIOProcessLine(qemuAgent *agent, return -1; } - if (virJSONValueObjectHasKey(obj, "QMP") == 1) { + if (virJSONValueObjectHasKey(obj, "QMP")) { return 0; - } else if (virJSONValueObjectHasKey(obj, "event") == 1) { + } else if (virJSONValueObjectHasKey(obj, "event")) { return qemuAgentIOProcessEvent(agent, obj); - } else if (virJSONValueObjectHasKey(obj, "error") == 1 || - virJSONValueObjectHasKey(obj, "return") == 1) { + } else if (virJSONValueObjectHasKey(obj, "error") || + virJSONValueObjectHasKey(obj, "return")) { if (msg) { if (msg->sync) { unsigned long long id; diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 941596563a..2469165728 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -203,14 +203,14 @@ qemuMonitorJSONIOProcessLine(qemuMonitor *mon, return -1; } - if (virJSONValueObjectHasKey(obj, "QMP") == 1) { + if (virJSONValueObjectHasKey(obj, "QMP")) { return 0; - } else if (virJSONValueObjectHasKey(obj, "event") == 1) { + } else if (virJSONValueObjectHasKey(obj, "event")) { PROBE(QEMU_MONITOR_RECV_EVENT, "mon=%p event=%s", mon, line); return qemuMonitorJSONIOProcessEvent(mon, obj); - } else if (virJSONValueObjectHasKey(obj, "error") == 1 || - virJSONValueObjectHasKey(obj, "return") == 1) { + } else if (virJSONValueObjectHasKey(obj, "error") || + virJSONValueObjectHasKey(obj, "return")) { PROBE(QEMU_MONITOR_RECV_REPLY, "mon=%p reply=%s", mon, line); if (msg) { @@ -270,7 +270,7 @@ qemuMonitorJSONCommandWithFd(qemuMonitor *mon, memset(&msg, 0, sizeof(msg)); - if (virJSONValueObjectHasKey(cmd, "execute") == 1) { + if (virJSONValueObjectHasKey(cmd, "execute")) { g_autofree char *id = qemuMonitorNextCommandID(mon); if (virJSONValueObjectAppendString(cmd, "id", id) < 0) { diff --git a/src/util/virjson.c b/src/util/virjson.c index 53f8cdff95..ef59b5deb4 100644 --- a/src/util/virjson.c +++ b/src/util/virjson.c @@ -798,21 +798,21 @@ virJSONValueArrayConcat(virJSONValue *a, } -int +bool virJSONValueObjectHasKey(virJSONValue *object, const char *key) { size_t i; if (object->type != VIR_JSON_TYPE_OBJECT) - return -1; + return false; for (i = 0; i < object->data.object.npairs; i++) { if (STREQ(object->data.object.pairs[i].key, key)) - return 1; + return true; } - return 0; + return false; } diff --git a/src/util/virjson.h b/src/util/virjson.h index aced48a538..ce181dcb82 100644 --- a/src/util/virjson.h +++ b/src/util/virjson.h @@ -88,7 +88,7 @@ int virJSONValueArrayConcat(virJSONValue *a, virJSONValue *c); -int +bool virJSONValueObjectHasKey(virJSONValue *object, const char *key); virJSONValue * -- 2.35.1

2 1

[libvirt PATCH] qemu: Restore original memory locking limit on reconnect
by Jiri Denemark 28 Jul '22

28 Jul '22

Commit v8.4.0-287-gd4d3bb8130 tried to make sure the original pre-migration memory locking limit is restored at the end of migration, but it missed the case when libvirt daemon is restarted during migration which needs to be aborted on reconnect. And if this was not enough, I forgot to actually save the status XML after setting the field in priv (in the commit mentioned above and also in v8.4.0-291-gd375993ab3). https://bugzilla.redhat.com/show_bug.cgi?id=2107424 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_migration.c | 13 +++++++++---- src/qemu/qemu_process.c | 2 ++ 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 8e9428a5bb..e1f5e49683 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -4672,10 +4672,12 @@ qemuMigrationSrcStart(virDomainObj *vm, switch (spec->destType) { case MIGRATION_DEST_HOST: if (STREQ(spec->dest.host.protocol, "rdma") && - virMemoryLimitIsSet(vm->def->mem.hard_limit) && - qemuDomainSetMaxMemLock(vm, vm->def->mem.hard_limit << 10, - &priv->preMigrationMemlock) < 0) { - return -1; + virMemoryLimitIsSet(vm->def->mem.hard_limit)) { + if (qemuDomainSetMaxMemLock(vm, vm->def->mem.hard_limit << 10, + &priv->preMigrationMemlock) < 0) + return -1; + /* Store the original memory locking limit */ + qemuDomainSaveStatus(vm); } return qemuMonitorMigrateToHost(priv->mon, migrateFlags, spec->dest.host.protocol, @@ -4868,6 +4870,9 @@ qemuMigrationSrcRun(virQEMUDriver *driver, if (qemuDomainSetMaxMemLock(vm, limit << 10, &priv->preMigrationMemlock) < 0) goto error; + + /* Store the original memory locking limit */ + qemuDomainSaveStatus(vm); } if (storageMigration) { diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index d42333195a..137dcf5cf4 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -3678,6 +3678,7 @@ qemuProcessRecoverMigration(virQEMUDriver *driver, { virDomainJobStatus migStatus = VIR_DOMAIN_JOB_STATUS_NONE; qemuDomainJobPrivate *jobPriv = job->privateData; + qemuDomainObjPrivate *priv = vm->privateData; virDomainState state; int reason; int rc; @@ -3727,6 +3728,7 @@ qemuProcessRecoverMigration(virQEMUDriver *driver, qemuMigrationParamsReset(driver, vm, VIR_ASYNC_JOB_NONE, jobPriv->migParams, job->apiFlags); + qemuDomainSetMaxMemLock(vm, 0, &priv->preMigrationMemlock); return 0; } -- 2.35.1

2 1

[PATCH] qemu: don't call qemuMigrationSrcIsAllowedHostdev() from qemuMigrationDstPrepareFresh()
by Laine Stump 28 Jul '22

28 Jul '22

This call to qemuMigrationSrcIsAllowedHostdev() (which does a hardcoded fail of the migration if there is any PCI or mdev hostdev device in the domain) while doing the destination side of migration prep was found once the call to that same function was removed from the source side migration prep (commit 25883cd5). According to jdenemar, for the V2 migration protocol, prep of the destination is the first step, so this *was* the proper place to do the check, but for V3 migration this is in a way redundant (since we will have already done the check on the source side (updated by 25883cd5 to query QEMU rather than do a hardcoded fail)). Of course it's possible that the source could support migration of a particular VFIO device, but the destination doesn't. But the current check on the destination side is worthless even in that case, since it is just *always* failing rather than querying QEMU; and QEMU can't be queried at the point where the destination check is happening, since it isn't yet running. Anyway QEMU should complain when it's started if it's going to fail, so removing this check should just move the failure to happen a bit later. So the best solution to this problem is to simply remove the hardcoded check/fail from qemuMigrationDstPrepareFresh() and rely on QEMU to fail if it needs to. Fixes: 25883cd5f0b188f2417f294b7d219a77b219f7c2 Signed-off-by: Laine Stump <laine(a)redhat.com> --- src/qemu/qemu_migration.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 20dc91f1ce..85b6b12f92 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -3379,9 +3379,6 @@ qemuMigrationDstPrepareFresh(virQEMUDriver *driver, QEMU_MIGRATION_COOKIE_CAPS; } - if (!qemuMigrationSrcIsAllowedHostdev(*def)) - goto cleanup; - /* Let migration hook filter domain XML */ if (virHookPresent(VIR_HOOK_DRIVER_QEMU)) { g_autofree char *xml = NULL; -- 2.35.3

2 1

[libvirt PATCH for 8.6.0] qemu: Properly release job in qemuDomainSaveInternal
by Jiri Denemark 27 Jul '22

27 Jul '22

The function would fail to release the job in case qemuMigrationSrcIsAllowed failed. Fixes v8.5.0-157-g69e0e33873 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 9013e6fb8d..019ec4a035 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2656,7 +2656,7 @@ qemuDomainSaveInternal(virQEMUDriver *driver, goto cleanup; if (!qemuMigrationSrcIsAllowed(driver, vm, false, VIR_ASYNC_JOB_SAVE, 0)) - goto cleanup; + goto endjob; if (!virDomainObjIsActive(vm)) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", -- 2.35.1

2 1

[PATCH v2 0/2] docs: Document reviewing and issue handling
by Peter Krempa 26 Jul '22

26 Jul '22

Following changes to the respective v1 versions of these patches: Peter Krempa (2): docs: patches: Add a note about reviews and contacting developers - followed Erik's suggestion to add bulletpoint instead of a blob of text docs: Add article about handling upstream issues (previously not reviewed) - fixed spelling and re-formulated some sentences docs/docs.rst | 3 + docs/issue-handling.rst | 174 ++++++++++++++++++++++++++++++++++++ docs/meson.build | 1 + docs/submitting-patches.rst | 22 +++++ 4 files changed, 200 insertions(+) create mode 100644 docs/issue-handling.rst -- 2.36.1

2 4

[PATCH 0/3] qemu: add an API for "query-stats" QMP command
by Amneesh Singh 26 Jul '22

26 Jul '22

QEMU is gaining introspectable statistics which can be queried via the "query-stats" QMP command. This patchset aims to add an API for the same. The returned JSON for "query-stats" is an array of objects containing their own respective array of statistics. Patch 1 adds the API which returns the deserialized JSON in the form of a GPtrArray of GHashTables. Patch 2 adds the "query-stats" to QEMU capabilities. Patch 3 uses the API to query the halt poll success time and the halt poll failure time. v2 -> v3 ======== Sorry for the late patchset, I was under the impression I had sent it on Monday but apparently, I did not. [1/3]: - use a single enum for all the statistics. - use QEMU_MONITOR_QUERY_STATS_NAME_LAST as the sentinel value for the provider constructor. - relevant changes to enum values. [2/3]: - fix comment spacing [3/3] - better checks v1 -> v2 ======== I have been tinkering with the v1 patchset and have rewrote the v2 patches a couple of times. I believe the current patchset is still not perfect and would appreciate some reviews. I have another patch or two written but they do not make any significant changes to the current patchset. [1/3]: - use virBitmap instead of an array of strings for statistics. - add enums for the stat names and add qemuMonitorQueryStatsNameTypeToString to switch between the "ToString" functions based on the target type. - change qemuMonitorQueryStatsProviderNew to a variadic function that takes stat enum values with the sentinel value being -1. [2/3]: - No changes [3/3]: - Add relevant monitor related checks to check if the domain is active. - Acquire and release qemuMonitorObj lock before and after calling qemuMonitorQueryStats respectively. - Add the check for privileged access. Relevant QEMU patches can be found here: https://lore.kernel.org/all/20220530150714.756954-1-pbonzini@redhat.com/ This patchset is part of the 2022 GSOC contributor project. Amneesh Singh (3): qemu_monitor: add qemuMonitorQueryStats qemu_capabilities: add "query-stats" QMP command to the QEMU capabilities qemu_driver: use qemuMonitorQueryStats to extract halt poll time src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_driver.c | 69 ++++++++++++++++--- src/qemu/qemu_monitor.c | 70 +++++++++++++++++++ src/qemu/qemu_monitor.h | 45 ++++++++++++ src/qemu/qemu_monitor_json.c | 130 +++++++++++++++++++++++++++++++++++ src/qemu/qemu_monitor_json.h | 6 ++ 7 files changed, 315 insertions(+), 8 deletions(-) -- 2.36.1

4 13

[libvirt][PATCH v13 0/6] Support query and use SGX
by Lin Yang 26 Jul '22

26 Jul '22

This patch series provides support for enabling Intel's Software Guard Extensions (SGX) feature in guest VM. Giving the SGX support in QEMU had been merged. Intel SGX is a set of instructions that increases the security of application code and data, giving them more protection from disclosure or modification. Developers can partition sensitive information into enclaves, which are areas of execution in memory with more security protection. The typical flow looks below at very high level: 1. Calls virConnectGetDomainCapabilities API to domain capabilities that includes the following SGX information. <feature> ... <sgx supported='yes'> <flc>no</flc> <sgx1>yes</sgx1> <sgx2>no</sgx2> <section_size>2</section_size> <sections> <section node='0' size='1'/> <section node='1' size='1'/> </sections> </sgx> ... </feature> 2. User requests to start a guest calling virCreateXML() with SGX requirement. It supports both non-NUMA SGX interface in QEMU 6.2.0 and NUMA SGX interface in QEMU 7.0.0 and later version. Without NUMA info: <devices> ... <memory model='sgx-epc'> <target> <size unit='KiB'>N</size> </target> </memory> ... </devices> With NUMA info: <devices> ... <memory model='sgx-epc'> <source> <nodemask>0-1</nodemask> </source> <target> <size unit='KiB'>16384</size> <node>0</node> </target> </memory> ... </devices> Please note that it assumes EPC target node in guest VM (.node attribute) is not required in SGX related parameter in QEMU command if QEMU didn't provide any SGX NUMA info, like QEMU 6.2.0 version. Haibin Huang (4): Define SGX capabilities structs Get SGX capabilities form QMP Convert QMP capabilities to domain capabilities conf: expose SGX feature in domain capabilities Lin Yang (2): conf: Introduce SGX EPC element into device memory xml qemu: Add command-line to generate SGX EPC memory backend docs/formatdomain.rst | 27 +- docs/formatdomaincaps.rst | 40 +++ src/conf/domain_capabilities.c | 58 ++++ src/conf/domain_capabilities.h | 24 ++ src/conf/domain_conf.c | 27 ++ src/conf/domain_conf.h | 1 + src/conf/domain_validate.c | 9 + src/conf/schemas/domaincaps.rng | 42 +++ src/conf/schemas/domaincommon.rng | 1 + src/libvirt_private.syms | 1 + src/qemu/qemu_alias.c | 6 +- src/qemu/qemu_capabilities.c | 258 ++++++++++++++++++ src/qemu/qemu_capabilities.h | 4 + src/qemu/qemu_command.c | 87 +++++- src/qemu/qemu_domain.c | 48 +++- src/qemu/qemu_domain_address.c | 6 + src/qemu/qemu_driver.c | 1 + src/qemu/qemu_monitor.c | 10 + src/qemu/qemu_monitor.h | 3 + src/qemu/qemu_monitor_json.c | 154 ++++++++++- src/qemu/qemu_monitor_json.h | 4 + src/qemu/qemu_process.c | 2 + src/qemu/qemu_validate.c | 8 + src/security/security_apparmor.c | 1 + src/security/security_dac.c | 2 + src/security/security_selinux.c | 2 + tests/domaincapsdata/bhyve_basic.x86_64.xml | 1 + tests/domaincapsdata/bhyve_fbuf.x86_64.xml | 1 + tests/domaincapsdata/bhyve_uefi.x86_64.xml | 1 + tests/domaincapsdata/empty.xml | 1 + tests/domaincapsdata/libxl-xenfv.xml | 1 + tests/domaincapsdata/libxl-xenpv.xml | 1 + .../domaincapsdata/qemu_2.11.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.11.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.11.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.11.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.12.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.12.0-tcg.x86_64.xml | 1 + .../qemu_2.12.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.12.0.x86_64.xml | 1 + .../domaincapsdata/qemu_3.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_3.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_3.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_3.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_3.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_3.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_3.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_3.1.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_3.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_4.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.0.0-tcg.x86_64.xml | 1 + .../qemu_4.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_4.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 1 + .../qemu_4.2.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.0.0-tcg.x86_64.xml | 1 + .../qemu_5.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_5.1.0.sparc.xml | 1 + tests/domaincapsdata/qemu_5.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.2.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.2.0-tcg.x86_64.xml | 1 + .../qemu_5.2.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_5.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 1 + .../qemu_6.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_6.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_6.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_6.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_6.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_6.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_6.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_6.2.0-q35.x86_64.xml | 6 + .../domaincapsdata/qemu_6.2.0-tcg.x86_64.xml | 6 + .../qemu_6.2.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_6.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_6.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_6.2.0.x86_64.xml | 6 + .../domaincapsdata/qemu_7.0.0-q35.x86_64.xml | 10 + .../domaincapsdata/qemu_7.0.0-tcg.x86_64.xml | 10 + .../qemu_7.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_7.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_7.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_7.0.0.x86_64.xml | 10 + .../domaincapsdata/qemu_7.1.0-q35.x86_64.xml | 10 + .../domaincapsdata/qemu_7.1.0-tcg.x86_64.xml | 10 + tests/domaincapsdata/qemu_7.1.0.x86_64.xml | 10 + .../caps_6.2.0.x86_64.replies | 30 +- .../caps_6.2.0.x86_64.xml | 7 + .../caps_7.0.0.x86_64.replies | 34 ++- .../caps_7.0.0.x86_64.xml | 11 + .../caps_7.1.0.x86_64.replies | 34 ++- .../caps_7.1.0.x86_64.xml | 11 + .../sgx-epc-numa.x86_64-latest.args | 40 +++ tests/qemuxml2argvdata/sgx-epc-numa.xml | 50 ++++ .../sgx-epc.x86_64-6.2.0.args | 37 +++ tests/qemuxml2argvdata/sgx-epc.xml | 36 +++ tests/qemuxml2argvtest.c | 3 + .../sgx-epc-numa.x86_64-latest.xml | 64 +++++ .../sgx-epc.x86_64-6.2.0.xml | 52 ++++ tests/qemuxml2xmltest.c | 3 + 124 files changed, 1349 insertions(+), 42 deletions(-) create mode 100644 tests/qemuxml2argvdata/sgx-epc-numa.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/sgx-epc-numa.xml create mode 100644 tests/qemuxml2argvdata/sgx-epc.x86_64-6.2.0.args create mode 100644 tests/qemuxml2argvdata/sgx-epc.xml create mode 100644 tests/qemuxml2xmloutdata/sgx-epc-numa.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/sgx-epc.x86_64-6.2.0.xml -- 2.25.1

5 31

[PATCH v2] coding-style: Allow some use of ternary operators
by Michal Privoznik 25 Jul '22

25 Jul '22

While we all understand that excessive use of ternary operator may worsen code readability (e.g. nested, multi-line expression), there are few cases where using it actually improves code readability. For instance, when a function takes a long list of arguments out of which one depends on a boolean expression, or when formatting "yes"/"no" or "on"/"off" values based on a boolean variable (although one can argue that the latter is a subset of the former). Just consider alternatives to: virBufferAsprintf(buf, "<elem>%s</elem>\n", boolVar ? "yes" : "no"); In fact, this pattern occurs plenty in our code. Exempt it from our "no ternary operators" rule. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> Reviewed-by: Claudio Fontana <cfontana(a)suse.de> --- v2 of: https://listman.redhat.com/archives/libvir-list/2022-July/233150.html diff to v1: - Changed wording, as suggested by Daniel. docs/coding-style.rst | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/docs/coding-style.rst b/docs/coding-style.rst index bf0a80fbc5..81bd4474f1 100644 --- a/docs/coding-style.rst +++ b/docs/coding-style.rst @@ -470,7 +470,9 @@ Pointer comparisons may be shortened. All long forms are okay. if (!foo) # or: if (foo == NULL) New code should avoid the ternary operator as much as possible. -Specifically it must never span more than one line or nest: +Its usage in basic cases is warranted (e.g. when deciding between +two constant strings), however, it must never span more than one +line or nest. :: @@ -481,6 +483,9 @@ Specifically it must never span more than one line or nest: char *foo = bar ? bar->baz ? bar->baz->foo : "nobaz" : "nobar"; + GOOD: + virBufferAsprintf(buf, "<element>%s</element>\n", boolVar ? "yes" : "no"); + Preprocessor ------------ -- 2.35.1

2 1

[libvirt PATCH 0/3] qemu: Properly reset migration parameters on reconnect
by Jiri Denemark 25 Jul '22

25 Jul '22

https://bugzilla.redhat.com/show_bug.cgi?id=2107892 Jiri Denemark (3): qemu_migration: Store original migration params in status XML qemu_migration_params: Refactor qemuMigrationParamsApply qemu_migration_params: Refactor qemuMigrationParamsReset src/qemu/qemu_migration.c | 6 +++ src/qemu/qemu_migration_params.c | 69 +++++++++++++++++++++++--------- 2 files changed, 55 insertions(+), 20 deletions(-) -- 2.35.1

2 4

[PATCH 0/5] qemu: Migration code (ternary operator) cleanups
by Peter Krempa 25 Jul '22

25 Jul '22

I've noticed few things that could be improved during review of Jirka's post copy migration changes but didn't want to interfer with the series at that point. Peter Krempa (5): qemuMigrationDstFinishFresh: Avoid multi-line ternary operator in function call qemuMigrationDstPersist: Avoid multi-line ternary operator in function call qemu: migration: Overwrite 'dname' only when NULL qemuMigrationSrcIOFunc: Avoid unnecessary string construction qemu: monitor: Split up enum strings definitions src/qemu/qemu_migration.c | 37 +++++++++++++++++++++++-------------- src/qemu/qemu_monitor.c | 35 ++++++++++++++++++++++++++--------- 2 files changed, 49 insertions(+), 23 deletions(-) -- 2.36.1

2 9

[PATCH] coding-style: Allow some use of ternary operators
by Michal Privoznik 25 Jul '22

25 Jul '22

While we all understand that excessive use of ternary operator may worsen code readability (e.g. nested, multi-line expression), there are few cases where using it actually improves code readability. For instance, when a function takes a long list of arguments out of which one depends on a boolean expression, or when formatting "yes"/"no" or "on"/"off" values based on a boolean variable (although one can argue that the latter is a subset of the former). Just consider alternatives to: virBufferAsprintf(buf, "<elem>%s</elem>\n", boolVar ? "yes" : "no"); In fact, this pattern occurs plenty in our code. Exempt if from our "no ternary operators" rule. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- docs/coding-style.rst | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/docs/coding-style.rst b/docs/coding-style.rst index bf0a80fbc5..038f18bda2 100644 --- a/docs/coding-style.rst +++ b/docs/coding-style.rst @@ -470,7 +470,9 @@ Pointer comparisons may be shortened. All long forms are okay. if (!foo) # or: if (foo == NULL) New code should avoid the ternary operator as much as possible. -Specifically it must never span more than one line or nest: +Specifically it must never span more than one line or nest. However, +its usage in very basic cases is warranted (e.g. when deciding +between two constant strings): :: @@ -481,6 +483,9 @@ Specifically it must never span more than one line or nest: char *foo = bar ? bar->baz ? bar->baz->foo : "nobaz" : "nobar"; + GOOD: + virBufferAsprintf(buf, "<element>%s</element>\n", boolVar ? "yes" : "no"); + Preprocessor ------------ -- 2.35.1

3 2

[PATCH] rpc: Pass OPENSSL_CONF through to ssh invocations
by Richard W.M. Jones 25 Jul '22

25 Jul '22

It's no longer possible for libvirt to connect over the ssh transport from RHEL 9 to RHEL 5. This is because SHA1 signatures have been effectively banned in RHEL 9 at the openssl level. They are required to check the RHEL 5 host key. Note this is a separate issue from openssh requiring additional configuration in order to connect to older servers. Connecting from a RHEL 9 client to RHEL 5 server: $ cat ~/.ssh/config Host 192.168.0.91 KexAlgorithms +diffie-hellman-group14-sha1 MACs +hmac-sha1 HostKeyAlgorithms +ssh-rsa PubkeyAcceptedKeyTypes +ssh-rsa PubkeyAcceptedAlgorithms +ssh-rsa $ virsh -c 'qemu+ssh://root@192.168.0.91/system' list error: failed to connect to the hypervisor error: Cannot recv data: ssh_dispatch_run_fatal: Connection to 192.168.0.91 port 22: error in libcrypto: Connection reset by peer "error in libcrypto: Connection reset by peer" is the characteristic error of openssl having been modified to disable SHA1 by default. (You will not see this on non-RHEL-derived distros.) You could enable the legacy crypto policy which downgrades security on the entire host, but a more fine-grained way to do this is to create an alternate openssl configuration file that enables the "forbidden" signatures. However this requires passing the OPENSSL_CONF environment variable through to ssh to specify the alternate configuration. Libvirt filters out this environment variable, but this commit allows it through. With this commit: $ cat /var/tmp/openssl.cnf .include /etc/ssl/openssl.cnf [openssl_init] alg_section = evp_properties [evp_properties] rh-allow-sha1-signatures = yes $ OPENSSL_CONF=/var/tmp/openssl.cnf ./run virsh -c 'qemu+ssh://root@192.168.0.91/system' list root(a)192.168.0.91's password: Id Name State -------------------- Essentially my argument here is that OPENSSL_CONF is sufficiently similar in nature to KRB5CCNAME, SSH* and XAUTHORITY that we should permit it to be passed through. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2062360 Signed-off-by: Richard W.M. Jones <rjones(a)redhat.com> --- src/rpc/virnetsocket.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c index 32f506d2d4..8280bda007 100644 --- a/src/rpc/virnetsocket.c +++ b/src/rpc/virnetsocket.c @@ -855,6 +855,7 @@ int virNetSocketNewConnectSSH(const char *nodename, virCommandAddEnvPass(cmd, "KRB5CCNAME"); virCommandAddEnvPass(cmd, "SSH_AUTH_SOCK"); virCommandAddEnvPass(cmd, "SSH_ASKPASS"); + virCommandAddEnvPass(cmd, "OPENSSL_CONF"); virCommandAddEnvPass(cmd, "DISPLAY"); virCommandAddEnvPass(cmd, "XAUTHORITY"); virCommandClearCaps(cmd); -- 2.31.1

3 2

[libvirt][PATCH v11 0/4] Support query and use SGX
by Lin Yang 25 Jul '22

25 Jul '22

This patch series provides support for enabling Intel's Software Guard Extensions (SGX) feature in guest VM. Giving the SGX support in QEMU had been merged. Intel SGX is a set of instructions that increases the security of application code and data, giving them more protection from disclosure or modification. Developers can partition sensitive information into enclaves, which are areas of execution in memory with more security protection. It depends on QEMU fixing[1], which will move cpu QOM object from /machine/unattached/device[nn] to /machine/cpu[nn]. It requires libvirt to change the default cpu QOM object location once QEMU patch gets accepted, but it is out of this SGX patch scope. The typical flow looks below at very high level: 1. Calls virConnectGetDomainCapabilities API to domain capabilities that includes the following SGX information. <feature> ... <sgx supported='yes'> <epc_size unit='KiB'>N</epc_size> </sgx> ... </feature> 2. User requests to start a guest calling virCreateXML() with SGX requirement. It does not support NUMA yet, since latest QEMU 6.2 release does not support NUMA. It should contain <devices> ... <memory model='sgx-epc'> <target> <size unit='KiB'>N</size> </target> </memory> ... </devices> Please note that SGX NUMA support will be implemented in future patches. [1] https://lists.nongnu.org/archive/html/qemu-devel/2022-01/msg03534.html Haibin Huang (2): qemu: provide support to query the SGX capability conf: expose SGX feature in domain capabilities Lin Yang (2): conf: Introduce SGX EPC element into device memory xml qemu: Add command-line to generate SGX EPC memory backend docs/formatdomain.rst | 9 +- docs/formatdomaincaps.rst | 26 ++++ src/conf/domain_capabilities.c | 29 ++++ src/conf/domain_capabilities.h | 13 ++ src/conf/domain_conf.c | 6 + src/conf/domain_conf.h | 1 + src/conf/domain_validate.c | 16 ++ src/conf/schemas/domaincaps.rng | 22 ++- src/conf/schemas/domaincommon.rng | 1 + src/libvirt_private.syms | 1 + src/qemu/qemu_alias.c | 6 +- src/qemu/qemu_capabilities.c | 143 ++++++++++++++++++ src/qemu/qemu_capabilities.h | 6 + src/qemu/qemu_capspriv.h | 4 + src/qemu/qemu_command.c | 54 ++++++- src/qemu/qemu_domain.c | 38 +++-- src/qemu/qemu_domain_address.c | 6 + src/qemu/qemu_driver.c | 1 + src/qemu/qemu_monitor.c | 10 ++ src/qemu/qemu_monitor.h | 3 + src/qemu/qemu_monitor_json.c | 104 ++++++++++++- src/qemu/qemu_monitor_json.h | 9 ++ src/qemu/qemu_process.c | 2 + src/qemu/qemu_validate.c | 8 + src/security/security_apparmor.c | 1 + src/security/security_dac.c | 2 + src/security/security_selinux.c | 2 + tests/domaincapsdata/bhyve_basic.x86_64.xml | 1 + tests/domaincapsdata/bhyve_fbuf.x86_64.xml | 1 + tests/domaincapsdata/bhyve_uefi.x86_64.xml | 1 + tests/domaincapsdata/empty.xml | 1 + tests/domaincapsdata/libxl-xenfv.xml | 1 + tests/domaincapsdata/libxl-xenpv.xml | 1 + .../domaincapsdata/qemu_2.11.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.11.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.11.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.11.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.12.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.12.0-tcg.x86_64.xml | 1 + .../qemu_2.12.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.12.0.x86_64.xml | 1 + .../domaincapsdata/qemu_3.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_3.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_3.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_3.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_3.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_3.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_3.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_3.1.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_3.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_4.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.0.0-tcg.x86_64.xml | 1 + .../qemu_4.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_4.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 1 + .../qemu_4.2.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.0.0-tcg.x86_64.xml | 1 + .../qemu_5.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_5.1.0.sparc.xml | 1 + tests/domaincapsdata/qemu_5.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.2.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.2.0-tcg.x86_64.xml | 1 + .../qemu_5.2.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_5.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 1 + .../qemu_6.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_6.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_6.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_6.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_6.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_6.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_6.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_6.2.0-q35.x86_64.xml | 4 + .../domaincapsdata/qemu_6.2.0-tcg.x86_64.xml | 4 + .../qemu_6.2.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_6.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_6.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_6.2.0.x86_64.xml | 4 + .../domaincapsdata/qemu_7.0.0-q35.x86_64.xml | 4 + .../domaincapsdata/qemu_7.0.0-tcg.x86_64.xml | 4 + .../qemu_7.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_7.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_7.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_7.0.0.x86_64.xml | 4 + .../caps_6.2.0.x86_64.replies | 22 ++- .../caps_6.2.0.x86_64.xml | 5 + .../caps_7.0.0.x86_64.replies | 22 ++- .../caps_7.0.0.x86_64.xml | 5 + .../sgx-epc.x86_64-6.2.0.args | 37 +++++ tests/qemuxml2argvdata/sgx-epc.xml | 36 +++++ tests/qemuxml2argvtest.c | 2 + .../sgx-epc.x86_64-latest.xml | 52 +++++++ tests/qemuxml2xmltest.c | 2 + 117 files changed, 769 insertions(+), 36 deletions(-) create mode 100644 tests/qemuxml2argvdata/sgx-epc.x86_64-6.2.0.args create mode 100644 tests/qemuxml2argvdata/sgx-epc.xml create mode 100644 tests/qemuxml2xmloutdata/sgx-epc.x86_64-latest.xml -- 2.25.1

7 17

[PATCH] cmdQemuMonitorCommandQMPWrap: Reset ignored errors from JSON parsing
by Peter Krempa 25 Jul '22

25 Jul '22

'cmdQemuMonitorCommandQMPWrap' is checking whether the user provided string is not valid JSON to avoid wrapping it. In cases where it's not JSON we ignore the error and add the wrapper. If the caller then reports a different non-libvirt error the error from the JSON parsing would be printed as well. Reset errors we ignore: # virsh qemu-monitor-command cd --pass-fds a asdf error: Unable to parse FD number 'a' error: internal error: cannot parse json asdf: lexical error: invalid char in json text. asdf (right here) ------^ In the above case 'asdf' is not valid JSON, but the code did wrap it into '{"execute":"asdf"}', the only problem is the argument for --pass-fds. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- tools/virsh-domain.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 9b1b14cdc2..743660e794 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -9769,6 +9769,8 @@ cmdQemuMonitorCommandQMPWrap(vshControl *ctl, if (virJSONValueIsObject(fullcmdjson)) return g_steal_pointer(&fullcmd); + vshResetLibvirtError(); + /* we try to wrap the command and possible arguments into a JSON object, if * we as fall back we pass through what we've got from the user */ @@ -9787,6 +9789,8 @@ cmdQemuMonitorCommandQMPWrap(vshControl *ctl, * JSON object wrapper and try using that */ g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; + vshResetLibvirtError(); + virBufferAddLit(&buf, "{"); /* opt points to the _ARGV option bit containing the command so we'll * iterate through the arguments now */ -- 2.35.1

2 2

[PATCH v2] virsh: Require --xpath for *dumpxml
by Michal Privoznik 25 Jul '22

25 Jul '22

Historically, the dumpxml command reject any unknown arguments, for instance: virsh dumpxml fedora xxx However, after v8.5.0-rc1~31 the second argument ('xxx') is treated as an XPath, but it's not that clearly visible. Therefore, require the --xpath switch, like this: virsh dumpxml fedora --xpath xxx Yes, this breaks already released virsh, but I think we can argue that the pool of users of this particular function is very small. We also document the argument being mandatory: dumpxml [--inactive] [--security-info] [--update-cpu] [--migratable] [--xpath EXPRESSION] [--wrap] domain The sooner we do this change, the better. The same applies for other *dumpxml functions (net-dumpxml, pool-dumpxml, vol-dumpxl to name a few). Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2103524 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- v2 of: https://listman.redhat.com/archives/libvir-list/2022-July/232733.html diff to v1: - Extended commit message to point out that we document --xpath as required, - Fixed the rest of the *dumpxml commands tools/virsh-backup.c | 1 + tools/virsh-checkpoint.c | 1 + tools/virsh-domain.c | 3 +++ tools/virsh-interface.c | 1 + tools/virsh-network.c | 2 ++ tools/virsh-nodedev.c | 1 + tools/virsh-nwfilter.c | 2 ++ tools/virsh-pool.c | 1 + tools/virsh-secret.c | 1 + tools/virsh-snapshot.c | 1 + tools/virsh-volume.c | 1 + 11 files changed, 15 insertions(+) diff --git a/tools/virsh-backup.c b/tools/virsh-backup.c index db122abc09..1bb2c63113 100644 --- a/tools/virsh-backup.c +++ b/tools/virsh-backup.c @@ -117,6 +117,7 @@ static const vshCmdOptDef opts_backup_dumpxml[] = { VIRSH_COMMON_OPT_DOMAIN_FULL(VIR_CONNECT_LIST_DOMAINS_ACTIVE), {.name = "xpath", .type = VSH_OT_STRING, + .flags = VSH_OFLAG_REQ_OPT, .completer = virshCompleteEmpty, .help = N_("xpath expression to filter the XML document") }, diff --git a/tools/virsh-checkpoint.c b/tools/virsh-checkpoint.c index a7ef39849d..9605c893af 100644 --- a/tools/virsh-checkpoint.c +++ b/tools/virsh-checkpoint.c @@ -854,6 +854,7 @@ static const vshCmdOptDef opts_checkpoint_dumpxml[] = { }, {.name = "xpath", .type = VSH_OT_STRING, + .flags = VSH_OFLAG_REQ_OPT, .completer = virshCompleteEmpty, .help = N_("xpath expression to filter the XML document") }, diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 43034f2f81..8c6245ca2a 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -4529,6 +4529,7 @@ static const vshCmdOptDef opts_save_image_dumpxml[] = { }, {.name = "xpath", .type = VSH_OT_STRING, + .flags = VSH_OFLAG_REQ_OPT, .completer = virshCompleteEmpty, .help = N_("xpath expression to filter the XML document") }, @@ -4961,6 +4962,7 @@ static const vshCmdOptDef opts_managed_save_dumpxml[] = { }, {.name = "xpath", .type = VSH_OT_STRING, + .flags = VSH_OFLAG_REQ_OPT, .completer = virshCompleteEmpty, .help = N_("xpath expression to filter the XML document") }, @@ -10461,6 +10463,7 @@ static const vshCmdOptDef opts_dumpxml[] = { }, {.name = "xpath", .type = VSH_OT_STRING, + .flags = VSH_OFLAG_REQ_OPT, .completer = virshCompleteEmpty, .help = N_("xpath expression to filter the XML document") }, diff --git a/tools/virsh-interface.c b/tools/virsh-interface.c index b29ffc9bef..39ea53ec9d 100644 --- a/tools/virsh-interface.c +++ b/tools/virsh-interface.c @@ -472,6 +472,7 @@ static const vshCmdOptDef opts_interface_dumpxml[] = { }, {.name = "xpath", .type = VSH_OT_STRING, + .flags = VSH_OFLAG_REQ_OPT, .completer = virshCompleteEmpty, .help = N_("xpath expression to filter the XML document") }, diff --git a/tools/virsh-network.c b/tools/virsh-network.c index 99ced6ccc6..004719dad6 100644 --- a/tools/virsh-network.c +++ b/tools/virsh-network.c @@ -351,6 +351,7 @@ static const vshCmdOptDef opts_network_dumpxml[] = { }, {.name = "xpath", .type = VSH_OT_STRING, + .flags = VSH_OFLAG_REQ_OPT, .completer = virshCompleteEmpty, .help = N_("xpath expression to filter the XML document") }, @@ -1556,6 +1557,7 @@ static const vshCmdOptDef opts_network_port_dumpxml[] = { VIRSH_COMMON_OPT_NETWORK_PORT(0), {.name = "xpath", .type = VSH_OT_STRING, + .flags = VSH_OFLAG_REQ_OPT, .completer = virshCompleteEmpty, .help = N_("xpath expression to filter the XML document") }, diff --git a/tools/virsh-nodedev.c b/tools/virsh-nodedev.c index 37e361c701..2adcad9c10 100644 --- a/tools/virsh-nodedev.c +++ b/tools/virsh-nodedev.c @@ -567,6 +567,7 @@ static const vshCmdOptDef opts_node_device_dumpxml[] = { }, {.name = "xpath", .type = VSH_OT_STRING, + .flags = VSH_OFLAG_REQ_OPT, .completer = virshCompleteEmpty, .help = N_("xpath expression to filter the XML document") }, diff --git a/tools/virsh-nwfilter.c b/tools/virsh-nwfilter.c index ff7f6f4026..d4112c8620 100644 --- a/tools/virsh-nwfilter.c +++ b/tools/virsh-nwfilter.c @@ -188,6 +188,7 @@ static const vshCmdOptDef opts_nwfilter_dumpxml[] = { }, {.name = "xpath", .type = VSH_OT_STRING, + .flags = VSH_OFLAG_REQ_OPT, .completer = virshCompleteEmpty, .help = N_("xpath expression to filter the XML document") }, @@ -610,6 +611,7 @@ static const vshCmdOptDef opts_nwfilter_binding_dumpxml[] = { }, {.name = "xpath", .type = VSH_OT_STRING, + .flags = VSH_OFLAG_REQ_OPT, .completer = virshCompleteEmpty, .help = N_("xpath expression to filter the XML document") }, diff --git a/tools/virsh-pool.c b/tools/virsh-pool.c index 820a61f889..8a98c6ae40 100644 --- a/tools/virsh-pool.c +++ b/tools/virsh-pool.c @@ -777,6 +777,7 @@ static const vshCmdOptDef opts_pool_dumpxml[] = { }, {.name = "xpath", .type = VSH_OT_STRING, + .flags = VSH_OFLAG_REQ_OPT, .completer = virshCompleteEmpty, .help = N_("xpath expression to filter the XML document") }, diff --git a/tools/virsh-secret.c b/tools/virsh-secret.c index 79fa3faf5a..17d2bbd88d 100644 --- a/tools/virsh-secret.c +++ b/tools/virsh-secret.c @@ -140,6 +140,7 @@ static const vshCmdOptDef opts_secret_dumpxml[] = { }, {.name = "xpath", .type = VSH_OT_STRING, + .flags = VSH_OFLAG_REQ_OPT, .completer = virshCompleteEmpty, .help = N_("xpath expression to filter the XML document") }, diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c index 83fdfb9616..8fa64ba903 100644 --- a/tools/virsh-snapshot.c +++ b/tools/virsh-snapshot.c @@ -1609,6 +1609,7 @@ static const vshCmdOptDef opts_snapshot_dumpxml[] = { }, {.name = "xpath", .type = VSH_OT_STRING, + .flags = VSH_OFLAG_REQ_OPT, .completer = virshCompleteEmpty, .help = N_("xpath expression to filter the XML document") }, diff --git a/tools/virsh-volume.c b/tools/virsh-volume.c index bf72d8135f..300a0aa8e5 100644 --- a/tools/virsh-volume.c +++ b/tools/virsh-volume.c @@ -1161,6 +1161,7 @@ static const vshCmdOptDef opts_vol_dumpxml[] = { VIRSH_COMMON_OPT_POOL_OPTIONAL, {.name = "xpath", .type = VSH_OT_STRING, + .flags = VSH_OFLAG_REQ_OPT, .completer = virshCompleteEmpty, .help = N_("xpath expression to filter the XML document") }, -- 2.35.1

3 2

Re: Qemu guest-reset option on device_add
by Michal Prívozník 24 Jul '22

24 Jul '22

On 7/6/22 17:55, Simon Fairweather wrote: > Hi Michal, If you are able to implement the feature that would be great. > > Regards > Simon. Hey, I've posted patches here: https://listman.redhat.com/archives/libvir-list/2022-July/232756.html I'm not sure whether you want to build libvirt from git only to test them, or wait until release, but in general, the <source/> element gained new 'guestReset' attribute and you could use it like this: <hostdev mode='subsystem' type='usb' managed='yes'> <source guestReset='no'> <vendor>0x05ac</vendor> <product>0x12a8</product> </source> </hostdev> Michal

2 1

[PATCH 0/4] jobs: use virDomainObjResetJob()
by Kristina Hanicova 22 Jul '22

22 Jul '22

*** BLURB HERE *** Kristina Hanicova (4): qemu & hypervisor: move qemuDomainObjResetJob() into hypervisor libxl: use virDomainObjResetJob() LXC: use virDomainObjResetJob() CH: use virDomainObjResetJob() src/ch/ch_domain.c | 13 ++----------- src/hypervisor/domain_job.c | 9 +++++++++ src/hypervisor/domain_job.h | 2 ++ src/libvirt_private.syms | 1 + src/libxl/libxl_domain.c | 13 ++----------- src/lxc/lxc_domain.c | 13 ++----------- src/qemu/qemu_domainjob.c | 20 +++++--------------- 7 files changed, 23 insertions(+), 48 deletions(-) -- 2.35.3

2 5

[libvirt PATCH 0/3] qemu: Allow IOMMU devices to have aliases
by Andrea Bolognani 22 Jul '22

22 Jul '22

Andrea Bolognani (3): schema: Allow IOMMU devices to have aliases qemu: Assign default alias to IOMMU devices qemu: Add IOMMU device alias to command line src/conf/schemas/domaincommon.rng | 3 +++ src/qemu/qemu_alias.c | 10 ++++++++++ src/qemu/qemu_command.c | 2 ++ .../intel-iommu-aw-bits.x86_64-latest.args | 2 +- .../intel-iommu-caching-mode.x86_64-latest.args | 2 +- .../intel-iommu-device-iotlb.x86_64-latest.args | 2 +- .../intel-iommu-eim.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/intel-iommu.x86_64-latest.args | 2 +- .../virtio-iommu-aarch64.aarch64-latest.args | 2 +- .../virtio-iommu-x86_64.x86_64-latest.args | 2 +- 10 files changed, 22 insertions(+), 7 deletions(-) -- 2.35.3

2 4

[PATCH] tests: qemucapabilities: Update test data for the qemu-7.1 cycle on x86_64
by Peter Krempa 22 Jul '22

22 Jul '22

Update to v7.0.0-2780-g5288bee45f Notable changes: - set-vcpu-dirty-limit/cancel-vcpu-dirty-limit/query-vcpu-dirty-limit command added - snapshot-save/snapshot-load command added - dirty-sync-missed-zero-copy migration statistic added - postcopy-preempt migration feature added - the 'copy-before-write' block driver gained: - 'cbw-timeout' property - 'on-cbw-error' property with values: - 'break-guest-write' - 'break-snapshot' Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- .../caps_7.1.0.x86_64.replies | 2870 +++++++++-------- .../caps_7.1.0.x86_64.xml | 2 +- 2 files changed, 1506 insertions(+), 1366 deletions(-) diff --git a/tests/qemucapabilitiesdata/caps_7.1.0.x86_64.replies b/tests/qemucapabilitiesdata/caps_7.1.0.x86_64.replies index 025d2db895..d893d67ea8 100644 --- a/tests/qemucapabilitiesdata/caps_7.1.0.x86_64.replies +++ b/tests/qemucapabilitiesdata/caps_7.1.0.x86_64.replies @@ -21,7 +21,7 @@ "minor": 0, "major": 7 }, - "package": "v7.0.0-2187-g2a8835cb45" + "package": "v7.0.0-2780-g5288bee45f" }, "id": "libvirt-2" } @@ -1032,56 +1032,74 @@ "arg-type": "0" }, { - "name": "snapshot-save", + "name": "set-vcpu-dirty-limit", "ret-type": "0", "meta-type": "command", "arg-type": "160" }, { - "name": "snapshot-load", + "name": "cancel-vcpu-dirty-limit", "ret-type": "0", "meta-type": "command", "arg-type": "161" }, + { + "name": "query-vcpu-dirty-limit", + "ret-type": "[162]", + "meta-type": "command", + "arg-type": "0" + }, + { + "name": "snapshot-save", + "ret-type": "0", + "meta-type": "command", + "arg-type": "163" + }, + { + "name": "snapshot-load", + "ret-type": "0", + "meta-type": "command", + "arg-type": "164" + }, { "name": "snapshot-delete", "ret-type": "0", "meta-type": "command", - "arg-type": "162" + "arg-type": "165" }, { "name": "transaction", "ret-type": "0", "meta-type": "command", - "arg-type": "163" + "arg-type": "166" }, { "name": "trace-event-get-state", - "ret-type": "[165]", + "ret-type": "[168]", "meta-type": "command", - "arg-type": "164" + "arg-type": "167" }, { "name": "trace-event-set-state", "ret-type": "0", "meta-type": "command", - "arg-type": "166" + "arg-type": "169" }, { "name": "qmp_capabilities", "ret-type": "0", "meta-type": "command", - "arg-type": "167" + "arg-type": "170" }, { "name": "query-version", - "ret-type": "168", + "ret-type": "171", "meta-type": "command", "arg-type": "0" }, { "name": "query-commands", - "ret-type": "[169]", + "ret-type": "[172]", "meta-type": "command", "arg-type": "0" }, @@ -1093,63 +1111,63 @@ }, { "name": "query-qmp-schema", - "ret-type": "[170]", + "ret-type": "[173]", "meta-type": "command", "arg-type": "0" }, { "name": "qom-list", - "ret-type": "[172]", + "ret-type": "[175]", "meta-type": "command", - "arg-type": "171" + "arg-type": "174" }, { "name": "qom-get", "ret-type": "any", "meta-type": "command", - "arg-type": "173" + "arg-type": "176" }, { "name": "qom-set", "ret-type": "0", "meta-type": "command", - "arg-type": "174" + "arg-type": "177" }, { "name": "qom-list-types", - "ret-type": "[176]", + "ret-type": "[179]", "meta-type": "command", - "arg-type": "175" + "arg-type": "178" }, { "name": "qom-list-properties", - "ret-type": "[172]", + "ret-type": "[175]", "meta-type": "command", - "arg-type": "177" + "arg-type": "180" }, { "name": "object-add", "ret-type": "0", "meta-type": "command", - "arg-type": "178" + "arg-type": "181" }, { "name": "object-del", "ret-type": "0", "meta-type": "command", - "arg-type": "179" + "arg-type": "182" }, { "name": "device-list-properties", - "ret-type": "[172]", + "ret-type": "[175]", "meta-type": "command", - "arg-type": "180" + "arg-type": "183" }, { "name": "device_add", "ret-type": "0", "meta-type": "command", - "arg-type": "181", + "arg-type": "184", "features": [ "json-cli", "json-cli-hotplug" @@ -1159,51 +1177,51 @@ "name": "device_del", "ret-type": "0", "meta-type": "command", - "arg-type": "182" + "arg-type": "185" }, { "name": "DEVICE_DELETED", "meta-type": "event", - "arg-type": "183" + "arg-type": "186" }, { "name": "DEVICE_UNPLUG_GUEST_ERROR", "meta-type": "event", - "arg-type": "184" + "arg-type": "187" }, { "name": "query-cpus-fast", - "ret-type": "[185]", + "ret-type": "[188]", "meta-type": "command", "arg-type": "0" }, { "name": "query-machines", - "ret-type": "[186]", + "ret-type": "[189]", "meta-type": "command", "arg-type": "0" }, { "name": "query-current-machine", - "ret-type": "187", + "ret-type": "190", "meta-type": "command", "arg-type": "0" }, { "name": "query-target", - "ret-type": "188", + "ret-type": "191", "meta-type": "command", "arg-type": "0" }, { "name": "query-uuid", - "ret-type": "189", + "ret-type": "192", "meta-type": "command", "arg-type": "0" }, { "name": "query-vm-generation-id", - "ret-type": "190", + "ret-type": "193", "meta-type": "command", "arg-type": "0" }, @@ -1233,7 +1251,7 @@ }, { "name": "query-kvm", - "ret-type": "191", + "ret-type": "194", "meta-type": "command", "arg-type": "0" }, @@ -1241,23 +1259,23 @@ "name": "memsave", "ret-type": "0", "meta-type": "command", - "arg-type": "192" + "arg-type": "195" }, { "name": "pmemsave", "ret-type": "0", "meta-type": "command", - "arg-type": "193" + "arg-type": "196" }, { "name": "query-memdev", - "ret-type": "[194]", + "ret-type": "[197]", "meta-type": "command", "arg-type": "0" }, { "name": "query-hotpluggable-cpus", - "ret-type": "[195]", + "ret-type": "[198]", "meta-type": "command", "arg-type": "0" }, @@ -1265,53 +1283,53 @@ "name": "set-numa-node", "ret-type": "0", "meta-type": "command", - "arg-type": "196" + "arg-type": "199" }, { "name": "balloon", "ret-type": "0", "meta-type": "command", - "arg-type": "197" + "arg-type": "200" }, { "name": "query-balloon", - "ret-type": "198", + "ret-type": "201", "meta-type": "command", "arg-type": "0" }, { "name": "BALLOON_CHANGE", "meta-type": "event", - "arg-type": "199" + "arg-type": "202" }, { "name": "query-memory-size-summary", - "ret-type": "200", + "ret-type": "203", "meta-type": "command", "arg-type": "0" }, { "name": "query-memory-devices", - "ret-type": "[201]", + "ret-type": "[204]", "meta-type": "command", "arg-type": "0" }, { "name": "MEMORY_DEVICE_SIZE_CHANGE", "meta-type": "event", - "arg-type": "202" + "arg-type": "205" }, { "name": "MEM_UNPLUG_ERROR", "meta-type": "event", - "arg-type": "203", + "arg-type": "206", "features": [ "deprecated" ] }, { "name": "x-query-irq", - "ret-type": "204", + "ret-type": "207", "meta-type": "command", "arg-type": "0", "features": [ @@ -1320,7 +1338,7 @@ }, { "name": "x-query-jit", - "ret-type": "204", + "ret-type": "207", "meta-type": "command", "arg-type": "0", "features": [ @@ -1329,7 +1347,7 @@ }, { "name": "x-query-numa", - "ret-type": "204", + "ret-type": "207", "meta-type": "command", "arg-type": "0", "features": [ @@ -1338,7 +1356,7 @@ }, { "name": "x-query-opcount", - "ret-type": "204", + "ret-type": "207", "meta-type": "command", "arg-type": "0", "features": [ @@ -1347,7 +1365,7 @@ }, { "name": "x-query-profile", - "ret-type": "204", + "ret-type": "207", "meta-type": "command", "arg-type": "0", "features": [ @@ -1356,7 +1374,7 @@ }, { "name": "x-query-ramblock", - "ret-type": "204", + "ret-type": "207", "meta-type": "command", "arg-type": "0", "features": [ @@ -1365,7 +1383,7 @@ }, { "name": "x-query-rdma", - "ret-type": "204", + "ret-type": "207", "meta-type": "command", "arg-type": "0", "features": [ @@ -1374,7 +1392,7 @@ }, { "name": "x-query-roms", - "ret-type": "204", + "ret-type": "207", "meta-type": "command", "arg-type": "0", "features": [ @@ -1383,7 +1401,7 @@ }, { "name": "x-query-usb", - "ret-type": "204", + "ret-type": "207", "meta-type": "command", "arg-type": "0", "features": [ @@ -1392,19 +1410,19 @@ }, { "name": "query-cpu-model-expansion", - "ret-type": "210", + "ret-type": "213", "meta-type": "command", - "arg-type": "209" + "arg-type": "212" }, { "name": "query-cpu-definitions", - "ret-type": "[211]", + "ret-type": "[214]", "meta-type": "command", "arg-type": "0" }, { "name": "query-replay", - "ret-type": "212", + "ret-type": "215", "meta-type": "command", "arg-type": "0" }, @@ -1412,7 +1430,7 @@ "name": "replay-break", "ret-type": "0", "meta-type": "command", - "arg-type": "213" + "arg-type": "216" }, { "name": "replay-delete-break", @@ -1424,18 +1442,18 @@ "name": "replay-seek", "ret-type": "0", "meta-type": "command", - "arg-type": "214" + "arg-type": "217" }, { "name": "yank", "ret-type": "0", "allow-oob": true, "meta-type": "command", - "arg-type": "215" + "arg-type": "218" }, { "name": "query-yank", - "ret-type": "[216]", + "ret-type": "[219]", "allow-oob": true, "meta-type": "command", "arg-type": "0" @@ -1444,17 +1462,17 @@ "name": "add_client", "ret-type": "0", "meta-type": "command", - "arg-type": "217" + "arg-type": "220" }, { "name": "query-name", - "ret-type": "218", + "ret-type": "221", "meta-type": "command", "arg-type": "0" }, { "name": "query-iothreads", - "ret-type": "[219]", + "ret-type": "[222]", "meta-type": "command", "arg-type": "0" }, @@ -1483,7 +1501,7 @@ "name": "human-monitor-command", "ret-type": "str", "meta-type": "command", - "arg-type": "220", + "arg-type": "223", "features": [ "savevm-monitor-nodes" ] @@ -1492,47 +1510,47 @@ "name": "getfd", "ret-type": "0", "meta-type": "command", - "arg-type": "221" + "arg-type": "224" }, { "name": "closefd", "ret-type": "0", "meta-type": "command", - "arg-type": "222" + "arg-type": "225" }, { "name": "add-fd", - "ret-type": "224", + "ret-type": "227", "meta-type": "command", - "arg-type": "223" + "arg-type": "226" }, { "name": "remove-fd", "ret-type": "0", "meta-type": "command", - "arg-type": "225" + "arg-type": "228" }, { "name": "query-fdsets", - "ret-type": "[226]", + "ret-type": "[229]", "meta-type": "command", "arg-type": "0" }, { "name": "query-command-line-options", - "ret-type": "[228]", + "ret-type": "[231]", "meta-type": "command", - "arg-type": "227" + "arg-type": "230" }, { "name": "RTC_CHANGE", "meta-type": "event", - "arg-type": "229" + "arg-type": "232" }, { "name": "VFU_CLIENT_HANGUP", "meta-type": "event", - "arg-type": "230" + "arg-type": "233" }, { "name": "rtc-reset-reinjection", @@ -1542,19 +1560,19 @@ }, { "name": "query-sev", - "ret-type": "231", + "ret-type": "234", "meta-type": "command", "arg-type": "0" }, { "name": "query-sev-launch-measure", - "ret-type": "232", + "ret-type": "235", "meta-type": "command", "arg-type": "0" }, { "name": "query-sev-capabilities", - "ret-type": "233", + "ret-type": "236", "meta-type": "command", "arg-type": "0" }, @@ -1562,54 +1580,54 @@ "name": "sev-inject-launch-secret", "ret-type": "0", "meta-type": "command", - "arg-type": "234" + "arg-type": "237" }, { "name": "query-sev-attestation-report", - "ret-type": "236", + "ret-type": "239", "meta-type": "command", - "arg-type": "235" + "arg-type": "238" }, { "name": "query-sgx", - "ret-type": "239", + "ret-type": "242", "meta-type": "command", "arg-type": "0" }, { "name": "query-sgx-capabilities", - "ret-type": "239", + "ret-type": "242", "meta-type": "command", "arg-type": "0" }, { "name": "query-acpi-ospm-status", - "ret-type": "[240]", + "ret-type": "[243]", "meta-type": "command", "arg-type": "0" }, { "name": "ACPI_DEVICE_OST", "meta-type": "event", - "arg-type": "241" + "arg-type": "244" }, { "name": "query-pci", - "ret-type": "[242]", + "ret-type": "[245]", "meta-type": "command", "arg-type": "0" }, { "name": "query-stats", - "ret-type": "[244]", + "ret-type": "[247]", "meta-type": "command", - "arg-type": "243" + "arg-type": "246" }, { "name": "query-stats-schemas", - "ret-type": "[246]", + "ret-type": "[249]", "meta-type": "command", - "arg-type": "245" + "arg-type": "248" }, { "name": "0", @@ -1630,7 +1648,7 @@ }, { "name": "status", - "type": "247" + "type": "250" } ], "meta-type": "object" @@ -1644,7 +1662,7 @@ }, { "name": "reason", - "type": "248" + "type": "251" } ], "meta-type": "object" @@ -1658,7 +1676,7 @@ }, { "name": "reason", - "type": "248" + "type": "251" } ], "meta-type": "object" @@ -1668,7 +1686,7 @@ "members": [ { "name": "action", - "type": "249" + "type": "252" } ], "meta-type": "object" @@ -1678,7 +1696,7 @@ "members": [ { "name": "action", - "type": "249" + "type": "252" } ], "meta-type": "object" @@ -1689,22 +1707,22 @@ { "name": "reboot", "default": null, - "type": "250" + "type": "253" }, { "name": "shutdown", "default": null, - "type": "251" + "type": "254" }, { "name": "panic", "default": null, - "type": "252" + "type": "255" }, { "name": "watchdog", "default": null, - "type": "249" + "type": "252" } ], "meta-type": "object" @@ -1714,12 +1732,12 @@ "members": [ { "name": "action", - "type": "253" + "type": "256" }, { "name": "info", "default": null, - "type": "254" + "type": "257" } ], "meta-type": "object" @@ -1729,12 +1747,12 @@ "members": [ { "name": "action", - "type": "253" + "type": "256" }, { "name": "info", "default": null, - "type": "254" + "type": "257" } ], "meta-type": "object" @@ -1744,15 +1762,15 @@ "members": [ { "name": "recipient", - "type": "255" + "type": "258" }, { "name": "action", - "type": "256" + "type": "259" }, { "name": "flags", - "type": "257" + "type": "260" } ], "meta-type": "object" @@ -1900,7 +1918,7 @@ { "name": "read-only-mode", "default": null, - "type": "258" + "type": "261" } ], "meta-type": "object" @@ -2122,7 +2140,7 @@ { "name": "io-status", "default": null, - "type": "259" + "type": "262" } ], "meta-type": "object" @@ -2163,12 +2181,12 @@ }, { "name": "stats", - "type": "260" + "type": "263" }, { "name": "driver-specific", "default": null, - "type": "261" + "type": "264" }, { "name": "parent", @@ -2221,7 +2239,7 @@ }, { "name": "io-status", - "type": "259" + "type": "262" }, { "name": "ready", @@ -2229,7 +2247,7 @@ }, { "name": "status", - "type": "262" + "type": "265" }, { "name": "auto-finalize", @@ -2297,7 +2315,7 @@ { "name": "mode", "default": null, - "type": "263" + "type": "266" } ], "meta-type": "object" @@ -2385,7 +2403,7 @@ { "name": "on-error", "default": null, - "type": "264" + "type": "267" }, { "name": "filter-node-name", @@ -2419,7 +2437,7 @@ }, { "name": "sync", - "type": "265" + "type": "268" }, { "name": "speed", @@ -2434,7 +2452,7 @@ { "name": "bitmap-mode", "default": null, - "type": "266" + "type": "269" }, { "name": "compress", @@ -2444,12 +2462,12 @@ { "name": "on-source-error", "default": null, - "type": "264" + "type": "267" }, { "name": "on-target-error", "default": null, - "type": "264" + "type": "267" }, { "name": "auto-finalize", @@ -2469,7 +2487,7 @@ { "name": "x-perf", "default": null, - "type": "267", + "type": "270", "features": [ "unstable" ] @@ -2486,7 +2504,7 @@ { "name": "mode", "default": null, - "type": "263" + "type": "266" } ], "meta-type": "object" @@ -2505,7 +2523,7 @@ }, { "name": "sync", - "type": "265" + "type": "268" }, { "name": "speed", @@ -2520,7 +2538,7 @@ { "name": "bitmap-mode", "default": null, - "type": "266" + "type": "269" }, { "name": "compress", @@ -2530,12 +2548,12 @@ { "name": "on-source-error", "default": null, - "type": "264" + "type": "267" }, { "name": "on-target-error", "default": null, - "type": "264" + "type": "267" }, { "name": "auto-finalize", @@ -2555,7 +2573,7 @@ { "name": "x-perf", "default": null, - "type": "267", + "type": "270", "features": [ "unstable" ] @@ -2618,7 +2636,7 @@ }, { "name": "detect_zeroes", - "type": "268" + "type": "271" }, { "name": "bps", @@ -2646,7 +2664,7 @@ }, { "name": "image", - "type": "269" + "type": "272" }, { "name": "bps_max", @@ -2720,7 +2738,7 @@ }, { "name": "cache", - "type": "270" + "type": "273" }, { "name": "write_threshold", @@ -2729,7 +2747,7 @@ { "name": "dirty-bitmaps", "default": null, - "type": "[271]" + "type": "[274]" } ], "meta-type": "object" @@ -2739,11 +2757,11 @@ "members": [ { "name": "nodes", - "type": "[272]" + "type": "[275]" }, { "name": "edges", - "type": "[273]" + "type": "[276]" } ], "meta-type": "object" @@ -2781,12 +2799,12 @@ }, { "name": "sync", - "type": "265" + "type": "268" }, { "name": "mode", "default": null, - "type": "263" + "type": "266" }, { "name": "speed", @@ -2806,12 +2824,12 @@ { "name": "on-source-error", "default": null, - "type": "264" + "type": "267" }, { "name": "on-target-error", "default": null, - "type": "264" + "type": "267" }, { "name": "unmap", @@ -2821,7 +2839,7 @@ { "name": "copy-mode", "default": null, - "type": "274" + "type": "277" }, { "name": "auto-finalize", @@ -2892,7 +2910,7 @@ }, { "name": "bitmaps", - "type": "[275]" + "type": "[278]" } ], "meta-type": "object" @@ -2930,7 +2948,7 @@ }, { "name": "sync", - "type": "265" + "type": "268" }, { "name": "speed", @@ -2950,12 +2968,12 @@ { "name": "on-source-error", "default": null, - "type": "264" + "type": "267" }, { "name": "on-target-error", "default": null, - "type": "264" + "type": "267" }, { "name": "filter-node-name", @@ -2965,7 +2983,7 @@ { "name": "copy-mode", "default": null, - "type": "274" + "type": "277" }, { "name": "auto-finalize", @@ -3020,7 +3038,7 @@ { "name": "on-error", "default": null, - "type": "264" + "type": "267" }, { "name": "filter-node-name", @@ -3125,177 +3143,177 @@ "variants": [ { "case": "blkdebug", - "type": "279" + "type": "282" }, { "case": "blklogwrites", - "type": "280" + "type": "283" }, { "case": "blkverify", - "type": "281" + "type": "284" }, { "case": "blkreplay", - "type": "282" + "type": "285" }, { "case": "bochs", - "type": "283" + "type": "286" }, { "case": "cloop", - "type": "283" + "type": "286" }, { "case": "compress", - "type": "283" + "type": "286" }, { "case": "copy-before-write", - "type": "284" + "type": "287" }, { "case": "copy-on-read", - "type": "285" + "type": "288" }, { "case": "dmg", - "type": "283" + "type": "286" }, { "case": "file", - "type": "286" + "type": "289" }, { "case": "ftp", - "type": "287" + "type": "290" }, { "case": "ftps", - "type": "288" + "type": "291" }, { "case": "gluster", - "type": "289" + "type": "292" }, { "case": "host_cdrom", - "type": "286" + "type": "289" }, { "case": "host_device", - "type": "286" + "type": "289" }, { "case": "http", - "type": "290" + "type": "293" }, { "case": "https", - "type": "291" + "type": "294" }, { "case": "iscsi", - "type": "292" + "type": "295" }, { "case": "luks", - "type": "293" + "type": "296" }, { "case": "nbd", - "type": "294" + "type": "297" }, { "case": "nfs", - "type": "295" + "type": "298" }, { "case": "null-aio", - "type": "296" + "type": "299" }, { "case": "null-co", - "type": "296" + "type": "299" }, { "case": "nvme", - "type": "297" + "type": "300" }, { "case": "parallels", - "type": "283" + "type": "286" }, { "case": "preallocate", - "type": "298" + "type": "301" }, { "case": "qcow2", - "type": "299" + "type": "302" }, { "case": "qcow", - "type": "300" + "type": "303" }, { "case": "qed", - "type": "301" + "type": "304" }, { "case": "quorum", - "type": "302" + "type": "305" }, { "case": "raw", - "type": "303" + "type": "306" }, { "case": "rbd", - "type": "304" + "type": "307" }, { "case": "replication", - "type": "305" + "type": "308" }, { "case": "snapshot-access", - "type": "283" + "type": "286" }, { "case": "ssh", - "type": "306" + "type": "309" }, { "case": "throttle", - "type": "307" + "type": "310" }, { "case": "vdi", - "type": "283" + "type": "286" }, { "case": "vhdx", - "type": "283" + "type": "286" }, { "case": "vmdk", - "type": "301" + "type": "304" }, { "case": "vpc", - "type": "283" + "type": "286" }, { "case": "vvfat", - "type": "308" + "type": "311" } ], "members": [ { "name": "driver", - "type": "276" + "type": "279" }, { "name": "node-name", @@ -3305,12 +3323,12 @@ { "name": "discard", "default": null, - "type": "277" + "type": "280" }, { "name": "cache", "default": null, - "type": "278" + "type": "281" }, { "name": "read-only", @@ -3330,7 +3348,7 @@ { "name": "detect-zeroes", "default": null, - "type": "268" + "type": "271" } ], "meta-type": "object" @@ -3364,7 +3382,7 @@ }, { "name": "options", - "type": "309" + "type": "312" } ], "meta-type": "object" @@ -3382,7 +3400,7 @@ }, { "name": "options", - "type": "310" + "type": "313" }, { "name": "force", @@ -3439,11 +3457,11 @@ }, { "name": "operation", - "type": "311" + "type": "314" }, { "name": "action", - "type": "312" + "type": "315" }, { "name": "nospace", @@ -3462,7 +3480,7 @@ "members": [ { "name": "type", - "type": "313" + "type": "316" }, { "name": "device", @@ -3493,7 +3511,7 @@ "members": [ { "name": "type", - "type": "313" + "type": "316" }, { "name": "device", @@ -3523,11 +3541,11 @@ }, { "name": "operation", - "type": "311" + "type": "314" }, { "name": "action", - "type": "312" + "type": "315" } ], "meta-type": "object" @@ -3537,7 +3555,7 @@ "members": [ { "name": "type", - "type": "313" + "type": "316" }, { "name": "device", @@ -3563,7 +3581,7 @@ "members": [ { "name": "type", - "type": "313" + "type": "316" }, { "name": "id", @@ -3633,7 +3651,7 @@ }, { "name": "iothread", - "type": "314" + "type": "317" }, { "name": "force", @@ -3666,7 +3684,7 @@ "members": [ { "name": "type", - "type": "315" + "type": "318" }, { "name": "error", @@ -3770,7 +3788,7 @@ }, { "name": "status", - "type": "262" + "type": "265" } ], "meta-type": "object" @@ -3849,11 +3867,11 @@ }, { "name": "type", - "type": "313" + "type": "316" }, { "name": "status", - "type": "262" + "type": "265" }, { "name": "current-progress", @@ -3876,7 +3894,7 @@ "members": [ { "name": "addr", - "type": "316" + "type": "319" }, { "name": "tls-creds", @@ -3936,7 +3954,7 @@ { "name": "mode", "default": null, - "type": "317" + "type": "320" } ], "meta-type": "object" @@ -3947,25 +3965,25 @@ "variants": [ { "case": "nbd", - "type": "319" + "type": "322" }, { "case": "vhost-user-blk", - "type": "320" + "type": "323" }, { "case": "fuse", - "type": "321" + "type": "324" }, { "case": "vduse-blk", - "type": "322" + "type": "325" } ], "members": [ { "name": "type", - "type": "318" + "type": "321" }, { "name": "id", @@ -4008,7 +4026,7 @@ { "name": "mode", "default": null, - "type": "317" + "type": "320" } ], "meta-type": "object" @@ -4037,7 +4055,7 @@ }, { "name": "type", - "type": "318" + "type": "321" }, { "name": "node-name", @@ -4102,7 +4120,7 @@ { "name": "format", "default": null, - "type": "323" + "type": "326" } ], "meta-type": "object" @@ -4121,7 +4139,7 @@ { "name": "format", "default": null, - "type": "323" + "type": "326" } ], "meta-type": "object" @@ -4140,7 +4158,7 @@ }, { "name": "backend", - "type": "324" + "type": "327" } ], "meta-type": "object" @@ -4165,7 +4183,7 @@ }, { "name": "backend", - "type": "324" + "type": "327" } ], "meta-type": "object" @@ -4233,7 +4251,7 @@ { "name": "format", "default": null, - "type": "325" + "type": "328" } ], "meta-type": "object" @@ -4243,7 +4261,7 @@ "members": [ { "name": "status", - "type": "326" + "type": "329" }, { "name": "completed", @@ -4276,7 +4294,7 @@ "members": [ { "name": "formats", - "type": "[325]" + "type": "[328]" } ], "meta-type": "object" @@ -4301,47 +4319,47 @@ "variants": [ { "case": "nic", - "type": "328" + "type": "331" }, { "case": "user", - "type": "329" + "type": "332" }, { "case": "tap", - "type": "330" + "type": "333" }, { "case": "l2tpv3", - "type": "331" + "type": "334" }, { "case": "socket", - "type": "332" + "type": "335" }, { "case": "vde", - "type": "333" + "type": "336" }, { "case": "bridge", - "type": "334" + "type": "337" }, { "case": "hubport", - "type": "335" + "type": "338" }, { "case": "netmap", - "type": "336" + "type": "339" }, { "case": "vhost-user", - "type": "337" + "type": "340" }, { "case": "vhost-vdpa", - "type": "338" + "type": "341" }, { "case": "none", @@ -4355,7 +4373,7 @@ }, { "name": "type", - "type": "327" + "type": "330" } ], "meta-type": "object" @@ -4399,15 +4417,15 @@ }, { "name": "multicast", - "type": "342" + "type": "345" }, { "name": "unicast", - "type": "342" + "type": "345" }, { "name": "vlan", - "type": "342" + "type": "345" }, { "name": "broadcast-allowed", @@ -4583,11 +4601,11 @@ }, { "name": "duplex", - "type": "343" + "type": "346" }, { "name": "autoneg", - "type": "344" + "type": "347" } ], "meta-type": "object" @@ -4625,15 +4643,15 @@ }, { "name": "key", - "type": "345" + "type": "348" }, { "name": "mask", - "type": "346" + "type": "349" }, { "name": "action", - "type": "347" + "type": "350" } ], "meta-type": "object" @@ -4791,7 +4809,7 @@ }, { "name": "options", - "type": "348" + "type": "351" } ], "meta-type": "object" @@ -4802,7 +4820,7 @@ "variants": [ { "case": "vnc", - "type": "351" + "type": "354" }, { "case": "spice", @@ -4812,7 +4830,7 @@ "members": [ { "name": "protocol", - "type": "349" + "type": "352" }, { "name": "password", @@ -4821,7 +4839,7 @@ { "name": "connected", "default": null, - "type": "350" + "type": "353" } ], "meta-type": "object" @@ -4832,7 +4850,7 @@ "variants": [ { "case": "vnc", - "type": "352" + "type": "355" }, { "case": "spice", @@ -4842,7 +4860,7 @@ "members": [ { "name": "protocol", - "type": "349" + "type": "352" }, { "name": "time", @@ -4871,7 +4889,7 @@ { "name": "format", "default": null, - "type": "353" + "type": "356" } ], "meta-type": "object" @@ -4914,12 +4932,12 @@ }, { "name": "mouse-mode", - "type": "354" + "type": "357" }, { "name": "channels", "default": null, - "type": "[355]" + "type": "[358]" } ], "meta-type": "object" @@ -4929,11 +4947,11 @@ "members": [ { "name": "server", - "type": "356" + "type": "359" }, { "name": "client", - "type": "356" + "type": "359" } ], "meta-type": "object" @@ -4943,11 +4961,11 @@ "members": [ { "name": "server", - "type": "357" + "type": "360" }, { "name": "client", - "type": "355" + "type": "358" } ], "meta-type": "object" @@ -4957,11 +4975,11 @@ "members": [ { "name": "server", - "type": "356" + "type": "359" }, { "name": "client", - "type": "356" + "type": "359" } ], "meta-type": "object" @@ -4981,7 +4999,7 @@ { "name": "family", "default": null, - "type": "358" + "type": "361" }, { "name": "service", @@ -4996,7 +5014,7 @@ { "name": "clients", "default": null, - "type": "[359]" + "type": "[362]" } ], "meta-type": "object" @@ -5015,20 +5033,20 @@ }, { "name": "server", - "type": "[360]" + "type": "[363]" }, { "name": "clients", - "type": "[359]" + "type": "[362]" }, { "name": "auth", - "type": "361" + "type": "364" }, { "name": "vencrypt", "default": null, - "type": "362" + "type": "365" }, { "name": "display", @@ -5053,11 +5071,11 @@ "members": [ { "name": "server", - "type": "363" + "type": "366" }, { "name": "client", - "type": "364" + "type": "367" } ], "meta-type": "object" @@ -5067,11 +5085,11 @@ "members": [ { "name": "server", - "type": "363" + "type": "366" }, { "name": "client", - "type": "359" + "type": "362" } ], "meta-type": "object" @@ -5081,11 +5099,11 @@ "members": [ { "name": "server", - "type": "363" + "type": "366" }, { "name": "client", - "type": "359" + "type": "362" } ], "meta-type": "object" @@ -5122,7 +5140,7 @@ "members": [ { "name": "keys", - "type": "[365]" + "type": "[368]" }, { "name": "hold-time", @@ -5147,7 +5165,7 @@ }, { "name": "events", - "type": "[366]" + "type": "[369]" } ], "meta-type": "object" @@ -5158,19 +5176,19 @@ "variants": [ { "case": "curses", - "type": "371" + "type": "374" }, { "case": "egl-headless", - "type": "372" + "type": "375" }, { "case": "dbus", - "type": "373" + "type": "376" }, { "case": "sdl", - "type": "374" + "type": "377" }, { "case": "default", @@ -5188,7 +5206,7 @@ "members": [ { "name": "type", - "type": "367" + "type": "370" }, { "name": "full-screen", @@ -5208,7 +5226,7 @@ { "name": "gl", "default": null, - "type": "368" + "type": "371" } ], "meta-type": "object" @@ -5219,13 +5237,13 @@ "variants": [ { "case": "vnc", - "type": "376" + "type": "379" } ], "members": [ { "name": "type", - "type": "375" + "type": "378" } ], "meta-type": "object" @@ -5236,13 +5254,13 @@ "variants": [ { "case": "vnc", - "type": "378" + "type": "381" } ], "members": [ { "name": "type", - "type": "377" + "type": "380" } ], "meta-type": "object" @@ -5253,27 +5271,27 @@ { "name": "status", "default": null, - "type": "379" + "type": "382" }, { "name": "ram", "default": null, - "type": "380" + "type": "383" }, { "name": "disk", "default": null, - "type": "380" + "type": "383" }, { "name": "vfio", "default": null, - "type": "381" + "type": "384" }, { "name": "xbzrle-cache", "default": null, - "type": "382" + "type": "385" }, { "name": "total-time", @@ -5323,12 +5341,12 @@ { "name": "compression", "default": null, - "type": "383" + "type": "386" }, { "name": "socket-address", "default": null, - "type": "[384]" + "type": "[387]" } ], "meta-type": "object" @@ -5353,7 +5371,7 @@ "members": [ { "name": "capability", - "type": "385" + "type": "388" }, { "name": "state", @@ -5428,17 +5446,17 @@ { "name": "tls-creds", "default": null, - "type": "314" + "type": "317" }, { "name": "tls-hostname", "default": null, - "type": "314" + "type": "317" }, { "name": "tls-authz", "default": null, - "type": "314" + "type": "317" }, { "name": "max-bandwidth", @@ -5486,7 +5504,7 @@ { "name": "multifd-compression", "default": null, - "type": "386" + "type": "389" }, { "name": "multifd-zlib-level", @@ -5501,7 +5519,7 @@ { "name": "block-bitmap-mapping", "default": null, - "type": "[387]" + "type": "[390]" } ], "meta-type": "object" @@ -5630,7 +5648,7 @@ { "name": "multifd-compression", "default": null, - "type": "386" + "type": "389" }, { "name": "multifd-zlib-level", @@ -5645,7 +5663,7 @@ { "name": "block-bitmap-mapping", "default": null, - "type": "[387]" + "type": "[390]" } ], "meta-type": "object" @@ -5684,7 +5702,7 @@ "members": [ { "name": "status", - "type": "379" + "type": "382" } ], "meta-type": "object" @@ -5704,11 +5722,11 @@ "members": [ { "name": "mode", - "type": "388" + "type": "391" }, { "name": "reason", - "type": "389" + "type": "392" } ], "meta-type": "object" @@ -5718,7 +5736,7 @@ "members": [ { "name": "state", - "type": "379" + "type": "382" } ], "meta-type": "object" @@ -5837,15 +5855,15 @@ "members": [ { "name": "mode", - "type": "388" + "type": "391" }, { "name": "last-mode", - "type": "388" + "type": "391" }, { "name": "reason", - "type": "389" + "type": "392" } ], "meta-type": "object" @@ -5885,7 +5903,7 @@ { "name": "mode", "default": null, - "type": "390" + "type": "393" } ], "meta-type": "object" @@ -5900,7 +5918,7 @@ }, { "name": "status", - "type": "391" + "type": "394" }, { "name": "start-time", @@ -5916,18 +5934,67 @@ }, { "name": "mode", - "type": "390" + "type": "393" }, { "name": "vcpu-dirty-rate", "default": null, - "type": "[392]" + "type": "[395]" } ], "meta-type": "object" }, { "name": "160", + "members": [ + { + "name": "cpu-index", + "default": null, + "type": "int" + }, + { + "name": "dirty-rate", + "type": "int" + } + ], + "meta-type": "object" + }, + { + "name": "161", + "members": [ + { + "name": "cpu-index", + "default": null, + "type": "int" + } + ], + "meta-type": "object" + }, + { + "name": "[162]", + "element-type": "162", + "meta-type": "array" + }, + { + "name": "162", + "members": [ + { + "name": "cpu-index", + "type": "int" + }, + { + "name": "limit-rate", + "type": "int" + }, + { + "name": "current-rate", + "type": "int" + } + ], + "meta-type": "object" + }, + { + "name": "163", "members": [ { "name": "job-id", @@ -5949,7 +6016,7 @@ "meta-type": "object" }, { - "name": "161", + "name": "164", "members": [ { "name": "job-id", @@ -5971,7 +6038,7 @@ "meta-type": "object" }, { - "name": "162", + "name": "165", "members": [ { "name": "job-id", @@ -5989,22 +6056,22 @@ "meta-type": "object" }, { - "name": "163", + "name": "166", "members": [ { "name": "actions", - "type": "[393]" + "type": "[396]" }, { "name": "properties", "default": null, - "type": "394" + "type": "397" } ], "meta-type": "object" }, { - "name": "164", + "name": "167", "members": [ { "name": "name", @@ -6019,12 +6086,12 @@ "meta-type": "object" }, { - "name": "[165]", - "element-type": "165", + "name": "[168]", + "element-type": "168", "meta-type": "array" }, { - "name": "165", + "name": "168", "members": [ { "name": "name", @@ -6032,7 +6099,7 @@ }, { "name": "state", - "type": "395" + "type": "398" }, { "name": "vcpu", @@ -6042,7 +6109,7 @@ "meta-type": "object" }, { - "name": "166", + "name": "169", "members": [ { "name": "name", @@ -6066,22 +6133,22 @@ "meta-type": "object" }, { - "name": "167", + "name": "170", "members": [ { "name": "enable", "default": null, - "type": "[396]" + "type": "[399]" } ], "meta-type": "object" }, { - "name": "168", + "name": "171", "members": [ { "name": "qemu", - "type": "397" + "type": "400" }, { "name": "package", @@ -6091,12 +6158,12 @@ "meta-type": "object" }, { - "name": "[169]", - "element-type": "169", + "name": "[172]", + "element-type": "172", "meta-type": "array" }, { - "name": "169", + "name": "172", "members": [ { "name": "name", @@ -6106,41 +6173,41 @@ "meta-type": "object" }, { - "name": "[170]", - "element-type": "170", + "name": "[173]", + "element-type": "173", "meta-type": "array" }, { - "name": "170", + "name": "173", "tag": "meta-type", "variants": [ { "case": "builtin", - "type": "399" + "type": "402" }, { "case": "enum", - "type": "400" + "type": "403" }, { "case": "array", - "type": "401" + "type": "404" }, { "case": "object", - "type": "402" + "type": "405" }, { "case": "alternate", - "type": "403" + "type": "406" }, { "case": "command", - "type": "404" + "type": "407" }, { "case": "event", - "type": "405" + "type": "408" } ], "members": [ @@ -6150,7 +6217,7 @@ }, { "name": "meta-type", - "type": "398" + "type": "401" }, { "name": "features", @@ -6161,7 +6228,7 @@ "meta-type": "object" }, { - "name": "171", + "name": "174", "members": [ { "name": "path", @@ -6171,12 +6238,12 @@ "meta-type": "object" }, { - "name": "[172]", - "element-type": "172", + "name": "[175]", + "element-type": "175", "meta-type": "array" }, { - "name": "172", + "name": "175", "members": [ { "name": "name", @@ -6200,7 +6267,7 @@ "meta-type": "object" }, { - "name": "173", + "name": "176", "members": [ { "name": "path", @@ -6219,7 +6286,7 @@ "meta-type": "builtin" }, { - "name": "174", + "name": "177", "members": [ { "name": "path", @@ -6237,7 +6304,7 @@ "meta-type": "object" }, { - "name": "175", + "name": "178", "members": [ { "name": "implements", @@ -6253,12 +6320,12 @@ "meta-type": "object" }, { - "name": "[176]", - "element-type": "176", + "name": "[179]", + "element-type": "179", "meta-type": "array" }, { - "name": "176", + "name": "179", "members": [ { "name": "name", @@ -6278,7 +6345,7 @@ "meta-type": "object" }, { - "name": "177", + "name": "180", "members": [ { "name": "typename", @@ -6288,164 +6355,164 @@ "meta-type": "object" }, { - "name": "178", + "name": "181", "tag": "qom-type", "variants": [ { "case": "authz-list", - "type": "407" + "type": "410" }, { "case": "authz-listfile", - "type": "408" + "type": "411" }, { "case": "authz-pam", - "type": "409" + "type": "412" }, { "case": "authz-simple", - "type": "410" + "type": "413" }, { "case": "can-host-socketcan", - "type": "411" + "type": "414" }, { "case": "colo-compare", - "type": "412" + "type": "415" }, { "case": "cryptodev-backend", - "type": "413" + "type": "416" }, { "case": "cryptodev-backend-builtin", - "type": "413" + "type": "416" }, { "case": "cryptodev-vhost-user", - "type": "414" + "type": "417" }, { "case": "dbus-vmstate", - "type": "415" + "type": "418" }, { "case": "filter-buffer", - "type": "416" + "type": "419" }, { "case": "filter-dump", - "type": "417" + "type": "420" }, { "case": "filter-mirror", - "type": "418" + "type": "421" }, { "case": "filter-redirector", - "type": "419" + "type": "422" }, { "case": "filter-replay", - "type": "420" + "type": "423" }, { "case": "filter-rewriter", - "type": "421" + "type": "424" }, { "case": "input-barrier", - "type": "422" + "type": "425" }, { "case": "input-linux", - "type": "423" + "type": "426" }, { "case": "iothread", - "type": "424" + "type": "427" }, { "case": "main-loop", - "type": "425" + "type": "428" }, { "case": "memory-backend-epc", - "type": "426" + "type": "429" }, { "case": "memory-backend-file", - "type": "427" + "type": "430" }, { "case": "memory-backend-memfd", - "type": "428" + "type": "431" }, { "case": "memory-backend-ram", - "type": "429" + "type": "432" }, { "case": "pr-manager-helper", - "type": "430" + "type": "433" }, { "case": "qtest", - "type": "431" + "type": "434" }, { "case": "rng-builtin", - "type": "432" + "type": "435" }, { "case": "rng-egd", - "type": "433" + "type": "436" }, { "case": "rng-random", - "type": "434" + "type": "437" }, { "case": "secret", - "type": "435" + "type": "438" }, { "case": "secret_keyring", - "type": "436" + "type": "439" }, { "case": "sev-guest", - "type": "437" + "type": "440" }, { "case": "throttle-group", - "type": "438" + "type": "441" }, { "case": "tls-creds-anon", - "type": "439" + "type": "442" }, { "case": "tls-creds-psk", - "type": "440" + "type": "443" }, { "case": "tls-creds-x509", - "type": "441" + "type": "444" }, { "case": "tls-cipher-suites", - "type": "442" + "type": "445" }, { "case": "x-remote-object", - "type": "443" + "type": "446" }, { "case": "x-vfio-user-server", - "type": "444" + "type": "447" }, { "case": "can-bus", @@ -6463,7 +6530,7 @@ "members": [ { "name": "qom-type", - "type": "406" + "type": "409" }, { "name": "id", @@ -6473,7 +6540,7 @@ "meta-type": "object" }, { - "name": "179", + "name": "182", "members": [ { "name": "id", @@ -6483,7 +6550,7 @@ "meta-type": "object" }, { - "name": "180", + "name": "183", "members": [ { "name": "typename", @@ -6493,7 +6560,7 @@ "meta-type": "object" }, { - "name": "181", + "name": "184", "members": [ { "name": "driver", @@ -6513,7 +6580,7 @@ "meta-type": "object" }, { - "name": "182", + "name": "185", "members": [ { "name": "id", @@ -6523,7 +6590,7 @@ "meta-type": "object" }, { - "name": "183", + "name": "186", "members": [ { "name": "device", @@ -6538,7 +6605,7 @@ "meta-type": "object" }, { - "name": "184", + "name": "187", "members": [ { "name": "device", @@ -6553,17 +6620,17 @@ "meta-type": "object" }, { - "name": "[185]", - "element-type": "185", + "name": "[188]", + "element-type": "188", "meta-type": "array" }, { - "name": "185", + "name": "188", "tag": "target", "variants": [ { "case": "s390x", - "type": "447" + "type": "450" }, { "case": "aarch64", @@ -6702,22 +6769,22 @@ { "name": "props", "default": null, - "type": "445" + "type": "448" }, { "name": "target", - "type": "446" + "type": "449" } ], "meta-type": "object" }, { - "name": "[186]", - "element-type": "186", + "name": "[189]", + "element-type": "189", "meta-type": "array" }, { - "name": "186", + "name": "189", "members": [ { "name": "name", @@ -6763,7 +6830,7 @@ "meta-type": "object" }, { - "name": "187", + "name": "190", "members": [ { "name": "wakeup-suspend-support", @@ -6773,17 +6840,17 @@ "meta-type": "object" }, { - "name": "188", + "name": "191", "members": [ { "name": "arch", - "type": "446" + "type": "449" } ], "meta-type": "object" }, { - "name": "189", + "name": "192", "members": [ { "name": "UUID", @@ -6793,7 +6860,7 @@ "meta-type": "object" }, { - "name": "190", + "name": "193", "members": [ { "name": "guid", @@ -6803,7 +6870,7 @@ "meta-type": "object" }, { - "name": "191", + "name": "194", "members": [ { "name": "enabled", @@ -6817,7 +6884,7 @@ "meta-type": "object" }, { - "name": "192", + "name": "195", "members": [ { "name": "val", @@ -6840,7 +6907,7 @@ "meta-type": "object" }, { - "name": "193", + "name": "196", "members": [ { "name": "val", @@ -6858,12 +6925,12 @@ "meta-type": "object" }, { - "name": "[194]", - "element-type": "194", + "name": "[197]", + "element-type": "197", "meta-type": "array" }, { - "name": "194", + "name": "197", "members": [ { "name": "id", @@ -6901,18 +6968,18 @@ }, { "name": "policy", - "type": "448" + "type": "451" } ], "meta-type": "object" }, { - "name": "[195]", - "element-type": "195", + "name": "[198]", + "element-type": "198", "meta-type": "array" }, { - "name": "195", + "name": "198", "members": [ { "name": "type", @@ -6924,7 +6991,7 @@ }, { "name": "props", - "type": "445" + "type": "448" }, { "name": "qom-path", @@ -6935,40 +7002,40 @@ "meta-type": "object" }, { - "name": "196", + "name": "199", "tag": "type", "variants": [ { "case": "node", - "type": "450" + "type": "453" }, { "case": "dist", - "type": "451" + "type": "454" }, { "case": "cpu", - "type": "452" + "type": "455" }, { "case": "hmat-lb", - "type": "453" + "type": "456" }, { "case": "hmat-cache", - "type": "454" + "type": "457" } ], "members": [ { "name": "type", - "type": "449" + "type": "452" } ], "meta-type": "object" }, { - "name": "197", + "name": "200", "members": [ { "name": "value", @@ -6978,7 +7045,7 @@ "meta-type": "object" }, { - "name": "198", + "name": "201", "members": [ { "name": "actual", @@ -6988,7 +7055,7 @@ "meta-type": "object" }, { - "name": "199", + "name": "202", "members": [ { "name": "actual", @@ -6998,7 +7065,7 @@ "meta-type": "object" }, { - "name": "200", + "name": "203", "members": [ { "name": "base-memory", @@ -7013,45 +7080,45 @@ "meta-type": "object" }, { - "name": "[201]", - "element-type": "201", + "name": "[204]", + "element-type": "204", "meta-type": "array" }, { - "name": "201", + "name": "204", "tag": "type", "variants": [ { "case": "dimm", - "type": "456" + "type": "459" }, { "case": "nvdimm", - "type": "456" + "type": "459" }, { "case": "virtio-pmem", - "type": "457" + "type": "460" }, { "case": "virtio-mem", - "type": "458" + "type": "461" }, { "case": "sgx-epc", - "type": "459" + "type": "462" } ], "members": [ { "name": "type", - "type": "455" + "type": "458" } ], "meta-type": "object" }, { - "name": "202", + "name": "205", "members": [ { "name": "id", @@ -7070,7 +7137,7 @@ "meta-type": "object" }, { - "name": "203", + "name": "206", "members": [ { "name": "device", @@ -7084,7 +7151,7 @@ "meta-type": "object" }, { - "name": "204", + "name": "207", "members": [ { "name": "human-readable-text", @@ -7094,36 +7161,36 @@ "meta-type": "object" }, { - "name": "209", + "name": "212", "members": [ { "name": "type", - "type": "462" + "type": "465" }, { "name": "model", - "type": "460" + "type": "463" } ], "meta-type": "object" }, { - "name": "210", + "name": "213", "members": [ { "name": "model", - "type": "460" + "type": "463" } ], "meta-type": "object" }, { - "name": "[211]", - "element-type": "211", + "name": "[214]", + "element-type": "214", "meta-type": "array" }, { - "name": "211", + "name": "214", "members": [ { "name": "name", @@ -7160,11 +7227,11 @@ "meta-type": "object" }, { - "name": "212", + "name": "215", "members": [ { "name": "mode", - "type": "463" + "type": "466" }, { "name": "filename", @@ -7179,7 +7246,7 @@ "meta-type": "object" }, { - "name": "213", + "name": "216", "members": [ { "name": "icount", @@ -7189,7 +7256,7 @@ "meta-type": "object" }, { - "name": "214", + "name": "217", "members": [ { "name": "icount", @@ -7199,31 +7266,31 @@ "meta-type": "object" }, { - "name": "215", + "name": "218", "members": [ { "name": "instances", - "type": "[216]" + "type": "[219]" } ], "meta-type": "object" }, { - "name": "[216]", - "element-type": "216", + "name": "[219]", + "element-type": "219", "meta-type": "array" }, { - "name": "216", + "name": "219", "tag": "type", "variants": [ { "case": "block-node", - "type": "465" + "type": "468" }, { "case": "chardev", - "type": "466" + "type": "469" }, { "case": "migration", @@ -7233,13 +7300,13 @@ "members": [ { "name": "type", - "type": "464" + "type": "467" } ], "meta-type": "object" }, { - "name": "217", + "name": "220", "members": [ { "name": "protocol", @@ -7263,7 +7330,7 @@ "meta-type": "object" }, { - "name": "218", + "name": "221", "members": [ { "name": "name", @@ -7274,12 +7341,12 @@ "meta-type": "object" }, { - "name": "[219]", - "element-type": "219", + "name": "[222]", + "element-type": "222", "meta-type": "array" }, { - "name": "219", + "name": "222", "members": [ { "name": "id", @@ -7309,7 +7376,7 @@ "meta-type": "object" }, { - "name": "220", + "name": "223", "members": [ { "name": "command-line", @@ -7324,7 +7391,7 @@ "meta-type": "object" }, { - "name": "221", + "name": "224", "members": [ { "name": "fdname", @@ -7334,7 +7401,7 @@ "meta-type": "object" }, { - "name": "222", + "name": "225", "members": [ { "name": "fdname", @@ -7344,7 +7411,7 @@ "meta-type": "object" }, { - "name": "223", + "name": "226", "members": [ { "name": "fdset-id", @@ -7360,7 +7427,7 @@ "meta-type": "object" }, { - "name": "224", + "name": "227", "members": [ { "name": "fdset-id", @@ -7374,7 +7441,7 @@ "meta-type": "object" }, { - "name": "225", + "name": "228", "members": [ { "name": "fdset-id", @@ -7389,12 +7456,12 @@ "meta-type": "object" }, { - "name": "[226]", - "element-type": "226", + "name": "[229]", + "element-type": "229", "meta-type": "array" }, { - "name": "226", + "name": "229", "members": [ { "name": "fdset-id", @@ -7402,13 +7469,13 @@ }, { "name": "fds", - "type": "[467]" + "type": "[470]" } ], "meta-type": "object" }, { - "name": "227", + "name": "230", "members": [ { "name": "option", @@ -7419,12 +7486,12 @@ "meta-type": "object" }, { - "name": "[228]", - "element-type": "228", + "name": "[231]", + "element-type": "231", "meta-type": "array" }, { - "name": "228", + "name": "231", "members": [ { "name": "option", @@ -7432,13 +7499,13 @@ }, { "name": "parameters", - "type": "[468]" + "type": "[471]" } ], "meta-type": "object" }, { - "name": "229", + "name": "232", "members": [ { "name": "offset", @@ -7452,7 +7519,7 @@ "meta-type": "object" }, { - "name": "230", + "name": "233", "members": [ { "name": "vfu-id", @@ -7474,7 +7541,7 @@ "meta-type": "object" }, { - "name": "231", + "name": "234", "members": [ { "name": "enabled", @@ -7498,7 +7565,7 @@ }, { "name": "state", - "type": "469" + "type": "472" }, { "name": "handle", @@ -7508,7 +7575,7 @@ "meta-type": "object" }, { - "name": "232", + "name": "235", "members": [ { "name": "data", @@ -7518,7 +7585,7 @@ "meta-type": "object" }, { - "name": "233", + "name": "236", "members": [ { "name": "pdh", @@ -7544,7 +7611,7 @@ "meta-type": "object" }, { - "name": "234", + "name": "237", "members": [ { "name": "packet-header", @@ -7563,7 +7630,7 @@ "meta-type": "object" }, { - "name": "235", + "name": "238", "members": [ { "name": "mnonce", @@ -7573,7 +7640,7 @@ "meta-type": "object" }, { - "name": "236", + "name": "239", "members": [ { "name": "data", @@ -7583,7 +7650,7 @@ "meta-type": "object" }, { - "name": "239", + "name": "242", "members": [ { "name": "sgx", @@ -7610,18 +7677,18 @@ }, { "name": "sections", - "type": "[470]" + "type": "[473]" } ], "meta-type": "object" }, { - "name": "[240]", - "element-type": "240", + "name": "[243]", + "element-type": "243", "meta-type": "array" }, { - "name": "240", + "name": "243", "members": [ { "name": "device", @@ -7634,7 +7701,7 @@ }, { "name": "slot-type", - "type": "471" + "type": "474" }, { "name": "source", @@ -7648,22 +7715,22 @@ "meta-type": "object" }, { - "name": "241", + "name": "244", "members": [ { "name": "info", - "type": "240" + "type": "243" } ], "meta-type": "object" }, { - "name": "[242]", - "element-type": "242", + "name": "[245]", + "element-type": "245", "meta-type": "array" }, { - "name": "242", + "name": "245", "members": [ { "name": "bus", @@ -7671,18 +7738,18 @@ }, { "name": "devices", - "type": "[472]" + "type": "[475]" } ], "meta-type": "object" }, { - "name": "243", + "name": "246", "tag": "target", "variants": [ { "case": "vcpu", - "type": "475" + "type": "478" }, { "case": "vm", @@ -7692,27 +7759,27 @@ "members": [ { "name": "target", - "type": "473" + "type": "476" }, { "name": "providers", "default": null, - "type": "[474]" + "type": "[477]" } ], "meta-type": "object" }, { - "name": "[244]", - "element-type": "244", + "name": "[247]", + "element-type": "247", "meta-type": "array" }, { - "name": "244", + "name": "247", "members": [ { "name": "provider", - "type": "476" + "type": "479" }, { "name": "qom-path", @@ -7721,41 +7788,41 @@ }, { "name": "stats", - "type": "[477]" + "type": "[480]" } ], "meta-type": "object" }, { - "name": "245", + "name": "248", "members": [ { "name": "provider", "default": null, - "type": "476" + "type": "479" } ], "meta-type": "object" }, { - "name": "[246]", - "element-type": "246", + "name": "[249]", + "element-type": "249", "meta-type": "array" }, { - "name": "246", + "name": "249", "members": [ { "name": "provider", - "type": "476" + "type": "479" }, { "name": "target", - "type": "473" + "type": "476" }, { "name": "stats", - "type": "[478]" + "type": "[481]" } ], "meta-type": "object" @@ -7766,7 +7833,7 @@ "meta-type": "builtin" }, { - "name": "247", + "name": "250", "members": [ { "name": "debug" @@ -7838,7 +7905,7 @@ ] }, { - "name": "248", + "name": "251", "members": [ { "name": "none" @@ -7886,7 +7953,7 @@ ] }, { - "name": "249", + "name": "252", "members": [ { "name": "reset" @@ -7922,7 +7989,7 @@ ] }, { - "name": "250", + "name": "253", "members": [ { "name": "reset" @@ -7938,7 +8005,7 @@ ] }, { - "name": "251", + "name": "254", "members": [ { "name": "poweroff" @@ -7954,7 +8021,7 @@ ] }, { - "name": "252", + "name": "255", "members": [ { "name": "pause" @@ -7974,7 +8041,7 @@ ] }, { - "name": "253", + "name": "256", "members": [ { "name": "pause" @@ -7994,28 +8061,28 @@ ] }, { - "name": "254", + "name": "257", "tag": "type", "variants": [ { "case": "hyper-v", - "type": "480" + "type": "483" }, { "case": "s390", - "type": "481" + "type": "484" } ], "members": [ { "name": "type", - "type": "479" + "type": "482" } ], "meta-type": "object" }, { - "name": "255", + "name": "258", "members": [ { "name": "hypervisor" @@ -8031,7 +8098,7 @@ ] }, { - "name": "256", + "name": "259", "members": [ { "name": "ignore" @@ -8055,7 +8122,7 @@ ] }, { - "name": "257", + "name": "260", "members": [ { "name": "action-required", @@ -8069,7 +8136,7 @@ "meta-type": "object" }, { - "name": "258", + "name": "261", "members": [ { "name": "retain" @@ -8099,7 +8166,7 @@ "meta-type": "array" }, { - "name": "259", + "name": "262", "members": [ { "name": "ok" @@ -8119,7 +8186,7 @@ ] }, { - "name": "260", + "name": "263", "members": [ { "name": "rd_bytes", @@ -8228,41 +8295,41 @@ }, { "name": "timed_stats", - "type": "[482]" + "type": "[485]" }, { "name": "rd_latency_histogram", "default": null, - "type": "483" + "type": "486" }, { "name": "wr_latency_histogram", "default": null, - "type": "483" + "type": "486" }, { "name": "flush_latency_histogram", "default": null, - "type": "483" + "type": "486" } ], "meta-type": "object" }, { - "name": "261", + "name": "264", "tag": "driver", "variants": [ { "case": "file", - "type": "484" + "type": "487" }, { "case": "host_device", - "type": "484" + "type": "487" }, { "case": "nvme", - "type": "485" + "type": "488" }, { "case": "blkdebug", @@ -8424,13 +8491,13 @@ "members": [ { "name": "driver", - "type": "276" + "type": "279" } ], "meta-type": "object" }, { - "name": "262", + "name": "265", "members": [ { "name": "undefined" @@ -8482,7 +8549,7 @@ ] }, { - "name": "263", + "name": "266", "members": [ { "name": "existing" @@ -8498,7 +8565,7 @@ ] }, { - "name": "264", + "name": "267", "members": [ { "name": "report" @@ -8526,7 +8593,7 @@ ] }, { - "name": "265", + "name": "268", "members": [ { "name": "top" @@ -8554,7 +8621,7 @@ ] }, { - "name": "266", + "name": "269", "members": [ { "name": "on-success" @@ -8574,7 +8641,7 @@ ] }, { - "name": "267", + "name": "270", "members": [ { "name": "use-copy-range", @@ -8595,7 +8662,7 @@ "meta-type": "object" }, { - "name": "268", + "name": "271", "members": [ { "name": "off" @@ -8615,7 +8682,7 @@ ] }, { - "name": "269", + "name": "272", "members": [ { "name": "filename", @@ -8677,18 +8744,18 @@ { "name": "backing-image", "default": null, - "type": "269" + "type": "272" }, { "name": "format-specific", "default": null, - "type": "486" + "type": "489" } ], "meta-type": "object" }, { - "name": "270", + "name": "273", "members": [ { "name": "writeback", @@ -8706,12 +8773,12 @@ "meta-type": "object" }, { - "name": "[271]", - "element-type": "271", + "name": "[274]", + "element-type": "274", "meta-type": "array" }, { - "name": "271", + "name": "274", "members": [ { "name": "name", @@ -8747,12 +8814,12 @@ "meta-type": "object" }, { - "name": "[272]", - "element-type": "272", + "name": "[275]", + "element-type": "275", "meta-type": "array" }, { - "name": "272", + "name": "275", "members": [ { "name": "id", @@ -8760,7 +8827,7 @@ }, { "name": "type", - "type": "487" + "type": "490" }, { "name": "name", @@ -8770,12 +8837,12 @@ "meta-type": "object" }, { - "name": "[273]", - "element-type": "273", + "name": "[276]", + "element-type": "276", "meta-type": "array" }, { - "name": "273", + "name": "276", "members": [ { "name": "parent", @@ -8791,17 +8858,17 @@ }, { "name": "perm", - "type": "[488]" + "type": "[491]" }, { "name": "shared-perm", - "type": "[488]" + "type": "[491]" } ], "meta-type": "object" }, { - "name": "274", + "name": "277", "members": [ { "name": "background" @@ -8817,12 +8884,12 @@ ] }, { - "name": "[275]", - "element-type": "275", + "name": "[278]", + "element-type": "278", "meta-type": "array" }, { - "name": "275", + "name": "278", "members": [ { "type": "str" @@ -8834,7 +8901,7 @@ "meta-type": "alternate" }, { - "name": "276", + "name": "279", "members": [ { "name": "blkdebug" @@ -9010,7 +9077,7 @@ ] }, { - "name": "277", + "name": "280", "members": [ { "name": "ignore" @@ -9026,7 +9093,7 @@ ] }, { - "name": "278", + "name": "281", "members": [ { "name": "direct", @@ -9042,11 +9109,11 @@ "meta-type": "object" }, { - "name": "279", + "name": "282", "members": [ { "name": "image", - "type": "489" + "type": "492" }, { "name": "config", @@ -9086,36 +9153,36 @@ { "name": "inject-error", "default": null, - "type": "[490]" + "type": "[493]" }, { "name": "set-state", "default": null, - "type": "[491]" + "type": "[494]" }, { "name": "take-child-perms", "default": null, - "type": "[488]" + "type": "[491]" }, { "name": "unshare-child-perms", "default": null, - "type": "[488]" + "type": "[491]" } ], "meta-type": "object" }, { - "name": "280", + "name": "283", "members": [ { "name": "file", - "type": "489" + "type": "492" }, { "name": "log", - "type": "489" + "type": "492" }, { "name": "log-sector-size", @@ -9136,64 +9203,74 @@ "meta-type": "object" }, { - "name": "281", + "name": "284", "members": [ { "name": "test", - "type": "489" + "type": "492" }, { "name": "raw", - "type": "489" + "type": "492" } ], "meta-type": "object" }, { - "name": "282", + "name": "285", "members": [ { "name": "image", - "type": "489" + "type": "492" } ], "meta-type": "object" }, { - "name": "283", + "name": "286", "members": [ { "name": "file", - "type": "489" + "type": "492" } ], "meta-type": "object" }, { - "name": "284", + "name": "287", "members": [ { "name": "file", - "type": "489" + "type": "492" }, { "name": "target", - "type": "489" + "type": "492" }, { "name": "bitmap", "default": null, "type": "37" + }, + { + "name": "on-cbw-error", + "default": null, + "type": "495" + }, + { + "name": "cbw-timeout", + "default": null, + "type": "int" } ], "meta-type": "object" }, { - "name": "285", + "name": "288", "members": [ { "name": "file", - "type": "489" + "type": "492" }, { "name": "bottom", @@ -9204,7 +9281,7 @@ "meta-type": "object" }, { - "name": "286", + "name": "289", "members": [ { "name": "filename", @@ -9218,12 +9295,12 @@ { "name": "locking", "default": null, - "type": "492" + "type": "496" }, { "name": "aio", "default": null, - "type": "493" + "type": "497" }, { "name": "aio-max-batch", @@ -9250,7 +9327,7 @@ ] }, { - "name": "287", + "name": "290", "members": [ { "name": "url", @@ -9290,7 +9367,7 @@ "meta-type": "object" }, { - "name": "288", + "name": "291", "members": [ { "name": "url", @@ -9335,7 +9412,7 @@ "meta-type": "object" }, { - "name": "289", + "name": "292", "members": [ { "name": "volume", @@ -9347,7 +9424,7 @@ }, { "name": "server", - "type": "[384]" + "type": "[387]" }, { "name": "debug", @@ -9363,7 +9440,7 @@ "meta-type": "object" }, { - "name": "290", + "name": "293", "members": [ { "name": "url", @@ -9413,7 +9490,7 @@ "meta-type": "object" }, { - "name": "291", + "name": "294", "members": [ { "name": "url", @@ -9468,11 +9545,11 @@ "meta-type": "object" }, { - "name": "292", + "name": "295", "members": [ { "name": "transport", - "type": "494" + "type": "498" }, { "name": "portal", @@ -9505,7 +9582,7 @@ { "name": "header-digest", "default": null, - "type": "495" + "type": "499" }, { "name": "timeout", @@ -9516,11 +9593,11 @@ "meta-type": "object" }, { - "name": "293", + "name": "296", "members": [ { "name": "file", - "type": "489" + "type": "492" }, { "name": "key-secret", @@ -9531,11 +9608,11 @@ "meta-type": "object" }, { - "name": "294", + "name": "297", "members": [ { "name": "server", - "type": "384" + "type": "387" }, { "name": "export", @@ -9574,11 +9651,11 @@ "meta-type": "object" }, { - "name": "295", + "name": "298", "members": [ { "name": "server", - "type": "496" + "type": "500" }, { "name": "path", @@ -9618,7 +9695,7 @@ "meta-type": "object" }, { - "name": "296", + "name": "299", "members": [ { "name": "size", @@ -9639,7 +9716,7 @@ "meta-type": "object" }, { - "name": "297", + "name": "300", "members": [ { "name": "device", @@ -9653,11 +9730,11 @@ "meta-type": "object" }, { - "name": "298", + "name": "301", "members": [ { "name": "file", - "type": "489" + "type": "492" }, { "name": "prealloc-align", @@ -9673,16 +9750,16 @@ "meta-type": "object" }, { - "name": "299", + "name": "302", "members": [ { "name": "file", - "type": "489" + "type": "492" }, { "name": "backing", "default": null, - "type": "497" + "type": "501" }, { "name": "lazy-refcounts", @@ -9707,7 +9784,7 @@ { "name": "overlap-check", "default": null, - "type": "498" + "type": "502" }, { "name": "cache-size", @@ -9737,53 +9814,53 @@ { "name": "encrypt", "default": null, - "type": "499" + "type": "503" }, { "name": "data-file", "default": null, - "type": "489" + "type": "492" } ], "meta-type": "object" }, { - "name": "300", + "name": "303", "members": [ { "name": "file", - "type": "489" + "type": "492" }, { "name": "backing", "default": null, - "type": "497" + "type": "501" }, { "name": "encrypt", "default": null, - "type": "500" + "type": "504" } ], "meta-type": "object" }, { - "name": "301", + "name": "304", "members": [ { "name": "file", - "type": "489" + "type": "492" }, { "name": "backing", "default": null, - "type": "497" + "type": "501" } ], "meta-type": "object" }, { - "name": "302", + "name": "305", "members": [ { "name": "blkverify", @@ -9792,7 +9869,7 @@ }, { "name": "children", - "type": "[489]" + "type": "[492]" }, { "name": "vote-threshold", @@ -9806,17 +9883,17 @@ { "name": "read-pattern", "default": null, - "type": "501" + "type": "505" } ], "meta-type": "object" }, { - "name": "303", + "name": "306", "members": [ { "name": "file", - "type": "489" + "type": "492" }, { "name": "offset", @@ -9832,7 +9909,7 @@ "meta-type": "object" }, { - "name": "304", + "name": "307", "members": [ { "name": "pool", @@ -9860,7 +9937,7 @@ { "name": "encrypt", "default": null, - "type": "502" + "type": "506" }, { "name": "user", @@ -9870,7 +9947,7 @@ { "name": "auth-client-required", "default": null, - "type": "[503]" + "type": "[507]" }, { "name": "key-secret", @@ -9880,21 +9957,21 @@ { "name": "server", "default": null, - "type": "[504]" + "type": "[508]" } ], "meta-type": "object" }, { - "name": "305", + "name": "308", "members": [ { "name": "file", - "type": "489" + "type": "492" }, { "name": "mode", - "type": "505" + "type": "509" }, { "name": "top-id", @@ -9905,11 +9982,11 @@ "meta-type": "object" }, { - "name": "306", + "name": "309", "members": [ { "name": "server", - "type": "506" + "type": "510" }, { "name": "path", @@ -9923,13 +10000,13 @@ { "name": "host-key-check", "default": null, - "type": "507" + "type": "511" } ], "meta-type": "object" }, { - "name": "307", + "name": "310", "members": [ { "name": "throttle-group", @@ -9937,13 +10014,13 @@ }, { "name": "file", - "type": "489" + "type": "492" } ], "meta-type": "object" }, { - "name": "308", + "name": "311", "members": [ { "name": "dir", @@ -9978,64 +10055,64 @@ "meta-type": "array" }, { - "name": "309", + "name": "312", "tag": "driver", "variants": [ { "case": "file", - "type": "508" + "type": "512" }, { "case": "gluster", - "type": "509" + "type": "513" }, { "case": "luks", - "type": "510" + "type": "514" }, { "case": "nfs", - "type": "511" + "type": "515" }, { "case": "parallels", - "type": "512" + "type": "516" }, { "case": "qcow", - "type": "513" + "type": "517" }, { "case": "qcow2", - "type": "514" + "type": "518" }, { "case": "qed", - "type": "515" + "type": "519" }, { "case": "rbd", - "type": "516" + "type": "520" }, { "case": "ssh", - "type": "517" + "type": "521" }, { "case": "vdi", - "type": "518" + "type": "522" }, { "case": "vhdx", - "type": "519" + "type": "523" }, { "case": "vmdk", - "type": "520" + "type": "524" }, { "case": "vpc", - "type": "521" + "type": "525" }, { "case": "blkdebug", @@ -10153,22 +10230,22 @@ "members": [ { "name": "driver", - "type": "276" + "type": "279" } ], "meta-type": "object" }, { - "name": "310", + "name": "313", "tag": "driver", "variants": [ { "case": "luks", - "type": "522" + "type": "526" }, { "case": "qcow2", - "type": "523" + "type": "527" }, { "case": "blkdebug", @@ -10334,13 +10411,13 @@ "members": [ { "name": "driver", - "type": "276" + "type": "279" } ], "meta-type": "object" }, { - "name": "311", + "name": "314", "members": [ { "name": "read" @@ -10356,7 +10433,7 @@ ] }, { - "name": "312", + "name": "315", "members": [ { "name": "ignore" @@ -10376,7 +10453,7 @@ ] }, { - "name": "313", + "name": "316", "members": [ { "name": "commit" @@ -10420,7 +10497,7 @@ ] }, { - "name": "314", + "name": "317", "members": [ { "type": "str" @@ -10432,7 +10509,7 @@ "meta-type": "alternate" }, { - "name": "315", + "name": "318", "members": [ { "name": "read" @@ -10452,36 +10529,36 @@ ] }, { - "name": "316", + "name": "319", "tag": "type", "variants": [ { "case": "inet", - "type": "525" + "type": "529" }, { "case": "unix", - "type": "526" + "type": "530" }, { "case": "vsock", - "type": "527" + "type": "531" }, { "case": "fd", - "type": "528" + "type": "532" } ], "members": [ { "name": "type", - "type": "524" + "type": "528" } ], "meta-type": "object" }, { - "name": "317", + "name": "320", "members": [ { "name": "safe" @@ -10497,7 +10574,7 @@ ] }, { - "name": "318", + "name": "321", "members": [ { "name": "nbd" @@ -10521,7 +10598,7 @@ ] }, { - "name": "319", + "name": "322", "members": [ { "name": "name", @@ -10536,7 +10613,7 @@ { "name": "bitmaps", "default": null, - "type": "[275]" + "type": "[278]" }, { "name": "allocation-depth", @@ -10547,11 +10624,11 @@ "meta-type": "object" }, { - "name": "320", + "name": "323", "members": [ { "name": "addr", - "type": "384" + "type": "387" }, { "name": "logical-block-size", @@ -10567,7 +10644,7 @@ "meta-type": "object" }, { - "name": "321", + "name": "324", "members": [ { "name": "mountpoint", @@ -10581,13 +10658,13 @@ { "name": "allow-other", "default": null, - "type": "529" + "type": "533" } ], "meta-type": "object" }, { - "name": "322", + "name": "325", "members": [ { "name": "name", @@ -10617,7 +10694,7 @@ "meta-type": "object" }, { - "name": "323", + "name": "326", "members": [ { "name": "utf8" @@ -10633,108 +10710,108 @@ ] }, { - "name": "324", + "name": "327", "tag": "type", "variants": [ { "case": "file", - "type": "531" + "type": "535" }, { "case": "serial", - "type": "532" + "type": "536" }, { "case": "parallel", - "type": "532" + "type": "536" }, { "case": "pipe", - "type": "532" + "type": "536" }, { "case": "socket", - "type": "533" + "type": "537" }, { "case": "udp", - "type": "534" + "type": "538" }, { "case": "pty", - "type": "535" + "type": "539" }, { "case": "null", - "type": "535" + "type": "539" }, { "case": "mux", - "type": "536" + "type": "540" }, { "case": "msmouse", - "type": "535" + "type": "539" }, { "case": "wctablet", - "type": "535" + "type": "539" }, { "case": "braille", - "type": "535" + "type": "539" }, { "case": "testdev", - "type": "535" + "type": "539" }, { "case": "stdio", - "type": "537" + "type": "541" }, { "case": "console", - "type": "535" + "type": "539" }, { "case": "spicevmc", - "type": "538" + "type": "542" }, { "case": "spiceport", - "type": "539" + "type": "543" }, { "case": "qemu-vdagent", - "type": "540" + "type": "544" }, { "case": "dbus", - "type": "541" + "type": "545" }, { "case": "vc", - "type": "542" + "type": "546" }, { "case": "ringbuf", - "type": "543" + "type": "547" }, { "case": "memory", - "type": "543" + "type": "547" } ], "members": [ { "name": "type", - "type": "530" + "type": "534" } ], "meta-type": "object" }, { - "name": "325", + "name": "328", "members": [ { "name": "elf" @@ -10762,7 +10839,7 @@ ] }, { - "name": "326", + "name": "329", "members": [ { "name": "none" @@ -10786,12 +10863,12 @@ ] }, { - "name": "[325]", - "element-type": "325", + "name": "[328]", + "element-type": "328", "meta-type": "array" }, { - "name": "327", + "name": "330", "members": [ { "name": "none" @@ -10847,7 +10924,7 @@ ] }, { - "name": "328", + "name": "331", "members": [ { "name": "netdev", @@ -10878,7 +10955,7 @@ "meta-type": "object" }, { - "name": "329", + "name": "332", "members": [ { "name": "hostname", @@ -10938,7 +11015,7 @@ { "name": "dnssearch", "default": null, - "type": "[544]" + "type": "[548]" }, { "name": "domainname", @@ -10978,12 +11055,12 @@ { "name": "hostfwd", "default": null, - "type": "[544]" + "type": "[548]" }, { "name": "guestfwd", "default": null, - "type": "[544]" + "type": "[548]" }, { "name": "tftp-server-name", @@ -10994,7 +11071,7 @@ "meta-type": "object" }, { - "name": "330", + "name": "333", "members": [ { "name": "ifname", @@ -11075,7 +11152,7 @@ "meta-type": "object" }, { - "name": "331", + "name": "334", "members": [ { "name": "src", @@ -11148,7 +11225,7 @@ "meta-type": "object" }, { - "name": "332", + "name": "335", "members": [ { "name": "fd", @@ -11184,7 +11261,7 @@ "meta-type": "object" }, { - "name": "333", + "name": "336", "members": [ { "name": "sock", @@ -11210,7 +11287,7 @@ "meta-type": "object" }, { - "name": "334", + "name": "337", "members": [ { "name": "br", @@ -11226,7 +11303,7 @@ "meta-type": "object" }, { - "name": "335", + "name": "338", "members": [ { "name": "hubid", @@ -11241,7 +11318,7 @@ "meta-type": "object" }, { - "name": "336", + "name": "339", "members": [ { "name": "ifname", @@ -11256,7 +11333,7 @@ "meta-type": "object" }, { - "name": "337", + "name": "340", "members": [ { "name": "chardev", @@ -11276,7 +11353,7 @@ "meta-type": "object" }, { - "name": "338", + "name": "341", "members": [ { "name": "vhostdev", @@ -11287,12 +11364,20 @@ "name": "queues", "default": null, "type": "int" + }, + { + "name": "x-svq", + "default": null, + "type": "bool", + "features": [ + "unstable" + ] } ], "meta-type": "object" }, { - "name": "342", + "name": "345", "members": [ { "name": "normal" @@ -11317,7 +11402,7 @@ "meta-type": "array" }, { - "name": "343", + "name": "346", "members": [ { "name": "half" @@ -11333,7 +11418,7 @@ ] }, { - "name": "344", + "name": "347", "members": [ { "name": "off" @@ -11349,7 +11434,7 @@ ] }, { - "name": "345", + "name": "348", "members": [ { "name": "priority", @@ -11408,7 +11493,7 @@ "meta-type": "object" }, { - "name": "346", + "name": "349", "members": [ { "name": "in-pport", @@ -11449,7 +11534,7 @@ "meta-type": "object" }, { - "name": "347", + "name": "350", "members": [ { "name": "goto-tbl", @@ -11485,16 +11570,16 @@ "meta-type": "object" }, { - "name": "348", + "name": "351", "tag": "type", "variants": [ { "case": "passthrough", - "type": "545" + "type": "549" }, { "case": "emulator", - "type": "546" + "type": "550" } ], "members": [ @@ -11506,7 +11591,7 @@ "meta-type": "object" }, { - "name": "349", + "name": "352", "members": [ { "name": "vnc" @@ -11522,7 +11607,7 @@ ] }, { - "name": "350", + "name": "353", "members": [ { "name": "keep" @@ -11542,7 +11627,7 @@ ] }, { - "name": "351", + "name": "354", "members": [ { "name": "display", @@ -11553,7 +11638,7 @@ "meta-type": "object" }, { - "name": "352", + "name": "355", "members": [ { "name": "display", @@ -11564,7 +11649,7 @@ "meta-type": "object" }, { - "name": "353", + "name": "356", "members": [ { "name": "ppm" @@ -11580,7 +11665,7 @@ ] }, { - "name": "354", + "name": "357", "members": [ { "name": "client" @@ -11600,12 +11685,12 @@ ] }, { - "name": "[355]", - "element-type": "355", + "name": "[358]", + "element-type": "358", "meta-type": "array" }, { - "name": "355", + "name": "358", "members": [ { "name": "host", @@ -11617,7 +11702,7 @@ }, { "name": "family", - "type": "358" + "type": "361" }, { "name": "connection-id", @@ -11639,7 +11724,7 @@ "meta-type": "object" }, { - "name": "356", + "name": "359", "members": [ { "name": "host", @@ -11651,13 +11736,13 @@ }, { "name": "family", - "type": "358" + "type": "361" } ], "meta-type": "object" }, { - "name": "357", + "name": "360", "members": [ { "name": "host", @@ -11669,7 +11754,7 @@ }, { "name": "family", - "type": "358" + "type": "361" }, { "name": "auth", @@ -11680,7 +11765,7 @@ "meta-type": "object" }, { - "name": "358", + "name": "361", "members": [ { "name": "ipv4" @@ -11708,12 +11793,12 @@ ] }, { - "name": "[359]", - "element-type": "359", + "name": "[362]", + "element-type": "362", "meta-type": "array" }, { - "name": "359", + "name": "362", "members": [ { "name": "host", @@ -11725,7 +11810,7 @@ }, { "name": "family", - "type": "358" + "type": "361" }, { "name": "websocket", @@ -11745,12 +11830,12 @@ "meta-type": "object" }, { - "name": "[360]", - "element-type": "360", + "name": "[363]", + "element-type": "363", "meta-type": "array" }, { - "name": "360", + "name": "363", "members": [ { "name": "host", @@ -11762,7 +11847,7 @@ }, { "name": "family", - "type": "358" + "type": "361" }, { "name": "websocket", @@ -11770,18 +11855,18 @@ }, { "name": "auth", - "type": "361" + "type": "364" }, { "name": "vencrypt", "default": null, - "type": "362" + "type": "365" } ], "meta-type": "object" }, { - "name": "361", + "name": "364", "members": [ { "name": "none" @@ -11825,7 +11910,7 @@ ] }, { - "name": "362", + "name": "365", "members": [ { "name": "plain" @@ -11869,7 +11954,7 @@ ] }, { - "name": "363", + "name": "366", "members": [ { "name": "host", @@ -11881,7 +11966,7 @@ }, { "name": "family", - "type": "358" + "type": "361" }, { "name": "websocket", @@ -11896,7 +11981,7 @@ "meta-type": "object" }, { - "name": "364", + "name": "367", "members": [ { "name": "host", @@ -11908,7 +11993,7 @@ }, { "name": "family", - "type": "358" + "type": "361" }, { "name": "websocket", @@ -11918,67 +12003,67 @@ "meta-type": "object" }, { - "name": "[365]", - "element-type": "365", + "name": "[368]", + "element-type": "368", "meta-type": "array" }, { - "name": "365", + "name": "368", "tag": "type", "variants": [ { "case": "number", - "type": "548" + "type": "552" }, { "case": "qcode", - "type": "549" + "type": "553" } ], "members": [ { "name": "type", - "type": "547" + "type": "551" } ], "meta-type": "object" }, { - "name": "[366]", - "element-type": "366", + "name": "[369]", + "element-type": "369", "meta-type": "array" }, { - "name": "366", + "name": "369", "tag": "type", "variants": [ { "case": "key", - "type": "551" + "type": "555" }, { "case": "btn", - "type": "552" + "type": "556" }, { "case": "rel", - "type": "553" + "type": "557" }, { "case": "abs", - "type": "553" + "type": "557" } ], "members": [ { "name": "type", - "type": "550" + "type": "554" } ], "meta-type": "object" }, { - "name": "367", + "name": "370", "members": [ { "name": "default" @@ -12014,7 +12099,7 @@ ] }, { - "name": "368", + "name": "371", "members": [ { "name": "off" @@ -12038,7 +12123,7 @@ ] }, { - "name": "369", + "name": "372", "members": [ { "name": "grab-on-hover", @@ -12049,12 +12134,17 @@ "name": "zoom-to-fit", "default": null, "type": "bool" + }, + { + "name": "show-tabs", + "default": null, + "type": "bool" } ], "meta-type": "object" }, { - "name": "370", + "name": "373", "members": [ { "name": "left-command-key", @@ -12075,7 +12165,7 @@ "meta-type": "object" }, { - "name": "371", + "name": "374", "members": [ { "name": "charset", @@ -12086,7 +12176,7 @@ "meta-type": "object" }, { - "name": "372", + "name": "375", "members": [ { "name": "rendernode", @@ -12097,7 +12187,7 @@ "meta-type": "object" }, { - "name": "373", + "name": "376", "members": [ { "name": "rendernode", @@ -12123,18 +12213,18 @@ "meta-type": "object" }, { - "name": "374", + "name": "377", "members": [ { "name": "grab-mod", "default": null, - "type": "554" + "type": "558" } ], "meta-type": "object" }, { - "name": "375", + "name": "378", "members": [ { "name": "vnc" @@ -12146,7 +12236,7 @@ ] }, { - "name": "376", + "name": "379", "members": [ { "name": "tls-certs", @@ -12157,7 +12247,7 @@ "meta-type": "object" }, { - "name": "377", + "name": "380", "members": [ { "name": "vnc" @@ -12169,18 +12259,18 @@ ] }, { - "name": "378", + "name": "381", "members": [ { "name": "addresses", "default": null, - "type": "[384]" + "type": "[387]" } ], "meta-type": "object" }, { - "name": "379", + "name": "382", "members": [ { "name": "none" @@ -12244,7 +12334,7 @@ ] }, { - "name": "380", + "name": "383", "members": [ { "name": "transferred", @@ -12313,12 +12403,16 @@ { "name": "postcopy-bytes", "type": "int" + }, + { + "name": "dirty-sync-missed-zero-copy", + "type": "int" } ], "meta-type": "object" }, { - "name": "381", + "name": "384", "members": [ { "name": "transferred", @@ -12328,7 +12422,7 @@ "meta-type": "object" }, { - "name": "382", + "name": "385", "members": [ { "name": "cache-size", @@ -12362,7 +12456,7 @@ "meta-type": "object" }, { - "name": "383", + "name": "386", "members": [ { "name": "pages", @@ -12388,41 +12482,41 @@ "meta-type": "object" }, { - "name": "[384]", - "element-type": "384", + "name": "[387]", + "element-type": "387", "meta-type": "array" }, { - "name": "384", + "name": "387", "tag": "type", "variants": [ { "case": "inet", - "type": "506" + "type": "510" }, { "case": "unix", - "type": "555" + "type": "559" }, { "case": "vsock", - "type": "556" + "type": "560" }, { "case": "fd", - "type": "544" + "type": "548" } ], "members": [ { "name": "type", - "type": "524" + "type": "528" } ], "meta-type": "object" }, { - "name": "385", + "name": "388", "members": [ { "name": "xbzrle" @@ -12489,6 +12583,9 @@ }, { "name": "zero-copy-send" + }, + { + "name": "postcopy-preempt" } ], "meta-type": "enum", @@ -12512,11 +12609,12 @@ "x-ignore-shared", "validate-uuid", "background-snapshot", - "zero-copy-send" + "zero-copy-send", + "postcopy-preempt" ] }, { - "name": "386", + "name": "389", "members": [ { "name": "none" @@ -12536,12 +12634,12 @@ ] }, { - "name": "[387]", - "element-type": "387", + "name": "[390]", + "element-type": "390", "meta-type": "array" }, { - "name": "387", + "name": "390", "members": [ { "name": "node-name", @@ -12553,13 +12651,13 @@ }, { "name": "bitmaps", - "type": "[557]" + "type": "[561]" } ], "meta-type": "object" }, { - "name": "388", + "name": "391", "members": [ { "name": "none" @@ -12579,7 +12677,7 @@ ] }, { - "name": "389", + "name": "392", "members": [ { "name": "none" @@ -12603,7 +12701,7 @@ ] }, { - "name": "390", + "name": "393", "members": [ { "name": "page-sampling" @@ -12623,7 +12721,7 @@ ] }, { - "name": "391", + "name": "394", "members": [ { "name": "unstarted" @@ -12643,12 +12741,12 @@ ] }, { - "name": "[392]", - "element-type": "392", + "name": "[395]", + "element-type": "395", "meta-type": "array" }, { - "name": "392", + "name": "395", "members": [ { "name": "id", @@ -12662,84 +12760,84 @@ "meta-type": "object" }, { - "name": "[393]", - "element-type": "393", + "name": "[396]", + "element-type": "396", "meta-type": "array" }, { - "name": "393", + "name": "396", "tag": "type", "variants": [ { "case": "abort", - "type": "559" + "type": "563" }, { "case": "block-dirty-bitmap-add", - "type": "560" + "type": "564" }, { "case": "block-dirty-bitmap-remove", - "type": "561" + "type": "565" }, { "case": "block-dirty-bitmap-clear", - "type": "561" + "type": "565" }, { "case": "block-dirty-bitmap-enable", - "type": "561" + "type": "565" }, { "case": "block-dirty-bitmap-disable", - "type": "561" + "type": "565" }, { "case": "block-dirty-bitmap-merge", - "type": "562" + "type": "566" }, { "case": "blockdev-backup", - "type": "563" + "type": "567" }, { "case": "blockdev-snapshot", - "type": "564" + "type": "568" }, { "case": "blockdev-snapshot-internal-sync", - "type": "565" + "type": "569" }, { "case": "blockdev-snapshot-sync", - "type": "566" + "type": "570" }, { "case": "drive-backup", - "type": "567" + "type": "571" } ], "members": [ { "name": "type", - "type": "558" + "type": "562" } ], "meta-type": "object" }, { - "name": "394", + "name": "397", "members": [ { "name": "completion-mode", "default": null, - "type": "568" + "type": "572" } ], "meta-type": "object" }, { - "name": "395", + "name": "398", "members": [ { "name": "unavailable" @@ -12759,12 +12857,12 @@ ] }, { - "name": "[396]", - "element-type": "396", + "name": "[399]", + "element-type": "399", "meta-type": "array" }, { - "name": "396", + "name": "399", "members": [ { "name": "oob" @@ -12776,7 +12874,7 @@ ] }, { - "name": "397", + "name": "400", "members": [ { "name": "major", @@ -12794,7 +12892,7 @@ "meta-type": "object" }, { - "name": "398", + "name": "401", "members": [ { "name": "builtin" @@ -12830,21 +12928,21 @@ ] }, { - "name": "399", + "name": "402", "members": [ { "name": "json-type", - "type": "569" + "type": "573" } ], "meta-type": "object" }, { - "name": "400", + "name": "403", "members": [ { "name": "members", - "type": "[570]" + "type": "[574]" }, { "name": "values", @@ -12857,7 +12955,7 @@ "meta-type": "object" }, { - "name": "401", + "name": "404", "members": [ { "name": "element-type", @@ -12867,11 +12965,11 @@ "meta-type": "object" }, { - "name": "402", + "name": "405", "members": [ { "name": "members", - "type": "[571]" + "type": "[575]" }, { "name": "tag", @@ -12881,23 +12979,23 @@ { "name": "variants", "default": null, - "type": "[572]" + "type": "[576]" } ], "meta-type": "object" }, { - "name": "403", + "name": "406", "members": [ { "name": "members", - "type": "[573]" + "type": "[577]" } ], "meta-type": "object" }, { - "name": "404", + "name": "407", "members": [ { "name": "arg-type", @@ -12916,7 +13014,7 @@ "meta-type": "object" }, { - "name": "405", + "name": "408", "members": [ { "name": "arg-type", @@ -12926,7 +13024,7 @@ "meta-type": "object" }, { - "name": "406", + "name": "409", "members": [ { "name": "authz-list" @@ -13108,23 +13206,23 @@ ] }, { - "name": "407", + "name": "410", "members": [ { "name": "policy", "default": null, - "type": "574" + "type": "578" }, { "name": "rules", "default": null, - "type": "[575]" + "type": "[579]" } ], "meta-type": "object" }, { - "name": "408", + "name": "411", "members": [ { "name": "filename", @@ -13139,7 +13237,7 @@ "meta-type": "object" }, { - "name": "409", + "name": "412", "members": [ { "name": "service", @@ -13149,7 +13247,7 @@ "meta-type": "object" }, { - "name": "410", + "name": "413", "members": [ { "name": "identity", @@ -13159,7 +13257,7 @@ "meta-type": "object" }, { - "name": "411", + "name": "414", "members": [ { "name": "if", @@ -13173,7 +13271,7 @@ "meta-type": "object" }, { - "name": "412", + "name": "415", "members": [ { "name": "primary_in", @@ -13220,7 +13318,7 @@ "meta-type": "object" }, { - "name": "413", + "name": "416", "members": [ { "name": "queues", @@ -13231,7 +13329,7 @@ "meta-type": "object" }, { - "name": "414", + "name": "417", "members": [ { "name": "queues", @@ -13246,7 +13344,7 @@ "meta-type": "object" }, { - "name": "415", + "name": "418", "members": [ { "name": "addr", @@ -13261,7 +13359,7 @@ "meta-type": "object" }, { - "name": "416", + "name": "419", "members": [ { "name": "netdev", @@ -13270,7 +13368,7 @@ { "name": "queue", "default": null, - "type": "576" + "type": "580" }, { "name": "status", @@ -13285,7 +13383,7 @@ { "name": "insert", "default": null, - "type": "577" + "type": "581" }, { "name": "interval", @@ -13295,7 +13393,7 @@ "meta-type": "object" }, { - "name": "417", + "name": "420", "members": [ { "name": "netdev", @@ -13304,7 +13402,7 @@ { "name": "queue", "default": null, - "type": "576" + "type": "580" }, { "name": "status", @@ -13319,7 +13417,7 @@ { "name": "insert", "default": null, - "type": "577" + "type": "581" }, { "name": "file", @@ -13334,7 +13432,7 @@ "meta-type": "object" }, { - "name": "418", + "name": "421", "members": [ { "name": "netdev", @@ -13343,7 +13441,7 @@ { "name": "queue", "default": null, - "type": "576" + "type": "580" }, { "name": "status", @@ -13358,7 +13456,7 @@ { "name": "insert", "default": null, - "type": "577" + "type": "581" }, { "name": "outdev", @@ -13373,7 +13471,7 @@ "meta-type": "object" }, { - "name": "419", + "name": "422", "members": [ { "name": "netdev", @@ -13382,7 +13480,7 @@ { "name": "queue", "default": null, - "type": "576" + "type": "580" }, { "name": "status", @@ -13397,7 +13495,7 @@ { "name": "insert", "default": null, - "type": "577" + "type": "581" }, { "name": "indev", @@ -13418,7 +13516,7 @@ "meta-type": "object" }, { - "name": "420", + "name": "423", "members": [ { "name": "netdev", @@ -13427,7 +13525,7 @@ { "name": "queue", "default": null, - "type": "576" + "type": "580" }, { "name": "status", @@ -13442,13 +13540,13 @@ { "name": "insert", "default": null, - "type": "577" + "type": "581" } ], "meta-type": "object" }, { - "name": "421", + "name": "424", "members": [ { "name": "netdev", @@ -13457,7 +13555,7 @@ { "name": "queue", "default": null, - "type": "576" + "type": "580" }, { "name": "status", @@ -13472,7 +13570,7 @@ { "name": "insert", "default": null, - "type": "577" + "type": "581" }, { "name": "vnet_hdr_support", @@ -13483,7 +13581,7 @@ "meta-type": "object" }, { - "name": "422", + "name": "425", "members": [ { "name": "name", @@ -13523,7 +13621,7 @@ "meta-type": "object" }, { - "name": "423", + "name": "426", "members": [ { "name": "evdev", @@ -13542,13 +13640,13 @@ { "name": "grab-toggle", "default": null, - "type": "578" + "type": "582" } ], "meta-type": "object" }, { - "name": "424", + "name": "427", "members": [ { "name": "aio-max-batch", @@ -13584,7 +13682,7 @@ "meta-type": "object" }, { - "name": "425", + "name": "428", "members": [ { "name": "aio-max-batch", @@ -13605,7 +13703,7 @@ "meta-type": "object" }, { - "name": "426", + "name": "429", "members": [ { "name": "dump", @@ -13625,7 +13723,7 @@ { "name": "policy", "default": null, - "type": "448" + "type": "451" }, { "name": "prealloc", @@ -13660,7 +13758,7 @@ "meta-type": "object" }, { - "name": "427", + "name": "430", "members": [ { "name": "dump", @@ -13680,7 +13778,7 @@ { "name": "policy", "default": null, - "type": "448" + "type": "451" }, { "name": "prealloc", @@ -13739,7 +13837,7 @@ "meta-type": "object" }, { - "name": "428", + "name": "431", "members": [ { "name": "dump", @@ -13759,7 +13857,7 @@ { "name": "policy", "default": null, - "type": "448" + "type": "451" }, { "name": "prealloc", @@ -13809,7 +13907,7 @@ "meta-type": "object" }, { - "name": "429", + "name": "432", "members": [ { "name": "dump", @@ -13829,7 +13927,7 @@ { "name": "policy", "default": null, - "type": "448" + "type": "451" }, { "name": "prealloc", @@ -13864,7 +13962,7 @@ "meta-type": "object" }, { - "name": "430", + "name": "433", "members": [ { "name": "path", @@ -13874,7 +13972,7 @@ "meta-type": "object" }, { - "name": "431", + "name": "434", "members": [ { "name": "chardev", @@ -13889,7 +13987,7 @@ "meta-type": "object" }, { - "name": "432", + "name": "435", "members": [ { "name": "opened", @@ -13903,7 +14001,7 @@ "meta-type": "object" }, { - "name": "433", + "name": "436", "members": [ { "name": "opened", @@ -13921,7 +14019,7 @@ "meta-type": "object" }, { - "name": "434", + "name": "437", "members": [ { "name": "opened", @@ -13940,7 +14038,7 @@ "meta-type": "object" }, { - "name": "435", + "name": "438", "members": [ { "name": "loaded", @@ -13953,7 +14051,7 @@ { "name": "format", "default": null, - "type": "579" + "type": "583" }, { "name": "keyid", @@ -13979,7 +14077,7 @@ "meta-type": "object" }, { - "name": "436", + "name": "439", "members": [ { "name": "loaded", @@ -13992,7 +14090,7 @@ { "name": "format", "default": null, - "type": "579" + "type": "583" }, { "name": "keyid", @@ -14012,7 +14110,7 @@ "meta-type": "object" }, { - "name": "437", + "name": "440", "members": [ { "name": "sev-device", @@ -14057,12 +14155,12 @@ "meta-type": "object" }, { - "name": "438", + "name": "441", "members": [ { "name": "limits", "default": null, - "type": "580" + "type": "584" }, { "name": "x-iops-total", @@ -14220,7 +14318,7 @@ "meta-type": "object" }, { - "name": "439", + "name": "442", "members": [ { "name": "verify-peer", @@ -14235,7 +14333,7 @@ { "name": "endpoint", "default": null, - "type": "581" + "type": "585" }, { "name": "priority", @@ -14254,7 +14352,7 @@ "meta-type": "object" }, { - "name": "440", + "name": "443", "members": [ { "name": "verify-peer", @@ -14269,7 +14367,7 @@ { "name": "endpoint", "default": null, - "type": "581" + "type": "585" }, { "name": "priority", @@ -14293,7 +14391,7 @@ "meta-type": "object" }, { - "name": "441", + "name": "444", "members": [ { "name": "verify-peer", @@ -14308,7 +14406,7 @@ { "name": "endpoint", "default": null, - "type": "581" + "type": "585" }, { "name": "priority", @@ -14337,7 +14435,7 @@ "meta-type": "object" }, { - "name": "442", + "name": "445", "members": [ { "name": "verify-peer", @@ -14352,7 +14450,7 @@ { "name": "endpoint", "default": null, - "type": "581" + "type": "585" }, { "name": "priority", @@ -14363,7 +14461,7 @@ "meta-type": "object" }, { - "name": "443", + "name": "446", "members": [ { "name": "fd", @@ -14377,11 +14475,11 @@ "meta-type": "object" }, { - "name": "444", + "name": "447", "members": [ { "name": "socket", - "type": "384" + "type": "387" }, { "name": "device", @@ -14391,7 +14489,7 @@ "meta-type": "object" }, { - "name": "445", + "name": "448", "members": [ { "name": "node-id", @@ -14427,7 +14525,7 @@ "meta-type": "object" }, { - "name": "446", + "name": "449", "members": [ { "name": "aarch64" @@ -14559,17 +14657,17 @@ ] }, { - "name": "447", + "name": "450", "members": [ { "name": "cpu-state", - "type": "582" + "type": "586" } ], "meta-type": "object" }, { - "name": "448", + "name": "451", "members": [ { "name": "default" @@ -14593,7 +14691,7 @@ ] }, { - "name": "449", + "name": "452", "members": [ { "name": "node" @@ -14621,7 +14719,7 @@ ] }, { - "name": "450", + "name": "453", "members": [ { "name": "nodeid", @@ -14652,7 +14750,7 @@ "meta-type": "object" }, { - "name": "451", + "name": "454", "members": [ { "name": "src", @@ -14670,7 +14768,7 @@ "meta-type": "object" }, { - "name": "452", + "name": "455", "members": [ { "name": "node-id", @@ -14706,7 +14804,7 @@ "meta-type": "object" }, { - "name": "453", + "name": "456", "members": [ { "name": "initiator", @@ -14718,11 +14816,11 @@ }, { "name": "hierarchy", - "type": "583" + "type": "587" }, { "name": "data-type", - "type": "584" + "type": "588" }, { "name": "latency", @@ -14738,7 +14836,7 @@ "meta-type": "object" }, { - "name": "454", + "name": "457", "members": [ { "name": "node-id", @@ -14754,11 +14852,11 @@ }, { "name": "associativity", - "type": "585" + "type": "589" }, { "name": "policy", - "type": "586" + "type": "590" }, { "name": "line", @@ -14768,7 +14866,7 @@ "meta-type": "object" }, { - "name": "455", + "name": "458", "members": [ { "name": "dimm" @@ -14796,47 +14894,47 @@ ] }, { - "name": "456", + "name": "459", "members": [ { "name": "data", - "type": "587" + "type": "591" } ], "meta-type": "object" }, { - "name": "457", + "name": "460", "members": [ { "name": "data", - "type": "588" + "type": "592" } ], "meta-type": "object" }, { - "name": "458", + "name": "461", "members": [ { "name": "data", - "type": "589" + "type": "593" } ], "meta-type": "object" }, { - "name": "459", + "name": "462", "members": [ { "name": "data", - "type": "590" + "type": "594" } ], "meta-type": "object" }, { - "name": "460", + "name": "463", "members": [ { "name": "name", @@ -14851,7 +14949,7 @@ "meta-type": "object" }, { - "name": "461", + "name": "464", "members": [ { "name": "incompatible" @@ -14875,7 +14973,7 @@ ] }, { - "name": "462", + "name": "465", "members": [ { "name": "static" @@ -14891,7 +14989,7 @@ ] }, { - "name": "463", + "name": "466", "members": [ { "name": "none" @@ -14911,7 +15009,7 @@ ] }, { - "name": "464", + "name": "467", "members": [ { "name": "block-node" @@ -14931,7 +15029,7 @@ ] }, { - "name": "465", + "name": "468", "members": [ { "name": "node-name", @@ -14941,7 +15039,7 @@ "meta-type": "object" }, { - "name": "466", + "name": "469", "members": [ { "name": "id", @@ -14951,12 +15049,12 @@ "meta-type": "object" }, { - "name": "[467]", - "element-type": "467", + "name": "[470]", + "element-type": "470", "meta-type": "array" }, { - "name": "467", + "name": "470", "members": [ { "name": "fd", @@ -14971,12 +15069,12 @@ "meta-type": "object" }, { - "name": "[468]", - "element-type": "468", + "name": "[471]", + "element-type": "471", "meta-type": "array" }, { - "name": "468", + "name": "471", "members": [ { "name": "name", @@ -14984,7 +15082,7 @@ }, { "name": "type", - "type": "591" + "type": "595" }, { "name": "help", @@ -15000,7 +15098,7 @@ "meta-type": "object" }, { - "name": "469", + "name": "472", "members": [ { "name": "uninit" @@ -15032,12 +15130,12 @@ ] }, { - "name": "[470]", - "element-type": "470", + "name": "[473]", + "element-type": "473", "meta-type": "array" }, { - "name": "470", + "name": "473", "members": [ { "name": "node", @@ -15051,7 +15149,7 @@ "meta-type": "object" }, { - "name": "471", + "name": "474", "members": [ { "name": "DIMM" @@ -15067,12 +15165,12 @@ ] }, { - "name": "[472]", - "element-type": "472", + "name": "[475]", + "element-type": "475", "meta-type": "array" }, { - "name": "472", + "name": "475", "members": [ { "name": "bus", @@ -15088,11 +15186,11 @@ }, { "name": "class_info", - "type": "592" + "type": "596" }, { "name": "id", - "type": "593" + "type": "597" }, { "name": "irq", @@ -15110,17 +15208,17 @@ { "name": "pci_bridge", "default": null, - "type": "594" + "type": "598" }, { "name": "regions", - "type": "[595]" + "type": "[599]" } ], "meta-type": "object" }, { - "name": "473", + "name": "476", "members": [ { "name": "vm" @@ -15136,16 +15234,16 @@ ] }, { - "name": "[474]", - "element-type": "474", + "name": "[477]", + "element-type": "477", "meta-type": "array" }, { - "name": "474", + "name": "477", "members": [ { "name": "provider", - "type": "476" + "type": "479" }, { "name": "names", @@ -15156,7 +15254,7 @@ "meta-type": "object" }, { - "name": "475", + "name": "478", "members": [ { "name": "vcpus", @@ -15167,7 +15265,7 @@ "meta-type": "object" }, { - "name": "476", + "name": "479", "members": [ { "name": "kvm" @@ -15179,12 +15277,12 @@ ] }, { - "name": "[477]", - "element-type": "477", + "name": "[480]", + "element-type": "480", "meta-type": "array" }, { - "name": "477", + "name": "480", "members": [ { "name": "name", @@ -15192,18 +15290,18 @@ }, { "name": "value", - "type": "596" + "type": "600" } ], "meta-type": "object" }, { - "name": "[478]", - "element-type": "478", + "name": "[481]", + "element-type": "481", "meta-type": "array" }, { - "name": "478", + "name": "481", "members": [ { "name": "name", @@ -15211,12 +15309,12 @@ }, { "name": "type", - "type": "597" + "type": "601" }, { "name": "unit", "default": null, - "type": "598" + "type": "602" }, { "name": "base", @@ -15236,7 +15334,7 @@ "meta-type": "object" }, { - "name": "479", + "name": "482", "members": [ { "name": "hyper-v" @@ -15252,7 +15350,7 @@ ] }, { - "name": "480", + "name": "483", "members": [ { "name": "arg1", @@ -15278,7 +15376,7 @@ "meta-type": "object" }, { - "name": "481", + "name": "484", "members": [ { "name": "core", @@ -15294,18 +15392,18 @@ }, { "name": "reason", - "type": "599" + "type": "603" } ], "meta-type": "object" }, { - "name": "[482]", - "element-type": "482", + "name": "[485]", + "element-type": "485", "meta-type": "array" }, { - "name": "482", + "name": "485", "members": [ { "name": "interval_length", @@ -15359,7 +15457,7 @@ "meta-type": "object" }, { - "name": "483", + "name": "486", "members": [ { "name": "boundaries", @@ -15373,7 +15471,7 @@ "meta-type": "object" }, { - "name": "484", + "name": "487", "members": [ { "name": "discard-nb-ok", @@ -15391,7 +15489,7 @@ "meta-type": "object" }, { - "name": "485", + "name": "488", "members": [ { "name": "completion-errors", @@ -15414,36 +15512,36 @@ "meta-type": "array" }, { - "name": "486", + "name": "489", "tag": "type", "variants": [ { "case": "qcow2", - "type": "601" + "type": "605" }, { "case": "vmdk", - "type": "602" + "type": "606" }, { "case": "luks", - "type": "603" + "type": "607" }, { "case": "rbd", - "type": "604" + "type": "608" } ], "members": [ { "name": "type", - "type": "600" + "type": "604" } ], "meta-type": "object" }, { - "name": "487", + "name": "490", "members": [ { "name": "block-backend" @@ -15463,12 +15561,12 @@ ] }, { - "name": "[488]", - "element-type": "488", + "name": "[491]", + "element-type": "491", "meta-type": "array" }, { - "name": "488", + "name": "491", "members": [ { "name": "consistent-read" @@ -15492,7 +15590,7 @@ ] }, { - "name": "489", + "name": "492", "members": [ { "type": "49" @@ -15504,16 +15602,16 @@ "meta-type": "alternate" }, { - "name": "[490]", - "element-type": "490", + "name": "[493]", + "element-type": "493", "meta-type": "array" }, { - "name": "490", + "name": "493", "members": [ { "name": "event", - "type": "605" + "type": "609" }, { "name": "state", @@ -15523,7 +15621,7 @@ { "name": "iotype", "default": null, - "type": "606" + "type": "610" }, { "name": "errno", @@ -15549,16 +15647,16 @@ "meta-type": "object" }, { - "name": "[491]", - "element-type": "491", + "name": "[494]", + "element-type": "494", "meta-type": "array" }, { - "name": "491", + "name": "494", "members": [ { "name": "event", - "type": "605" + "type": "609" }, { "name": "state", @@ -15573,7 +15671,23 @@ "meta-type": "object" }, { - "name": "492", + "name": "495", + "members": [ + { + "name": "break-guest-write" + }, + { + "name": "break-snapshot" + } + ], + "meta-type": "enum", + "values": [ + "break-guest-write", + "break-snapshot" + ] + }, + { + "name": "496", "members": [ { "name": "auto" @@ -15593,7 +15707,7 @@ ] }, { - "name": "493", + "name": "497", "members": [ { "name": "threads" @@ -15613,7 +15727,7 @@ ] }, { - "name": "494", + "name": "498", "members": [ { "name": "tcp" @@ -15629,7 +15743,7 @@ ] }, { - "name": "495", + "name": "499", "members": [ { "name": "crc32c" @@ -15653,11 +15767,11 @@ ] }, { - "name": "496", + "name": "500", "members": [ { "name": "type", - "type": "607" + "type": "611" }, { "name": "host", @@ -15667,7 +15781,7 @@ "meta-type": "object" }, { - "name": "497", + "name": "501", "members": [ { "type": "49" @@ -15682,62 +15796,62 @@ "meta-type": "alternate" }, { - "name": "498", + "name": "502", "members": [ { - "type": "608" + "type": "612" }, { - "type": "609" + "type": "613" } ], "meta-type": "alternate" }, { - "name": "499", + "name": "503", "tag": "format", "variants": [ { "case": "aes", - "type": "611" + "type": "615" }, { "case": "luks", - "type": "612" + "type": "616" } ], "members": [ { "name": "format", - "type": "610" + "type": "614" } ], "meta-type": "object" }, { - "name": "500", + "name": "504", "tag": "format", "variants": [ { "case": "aes", - "type": "611" + "type": "615" } ], "members": [ { "name": "format", - "type": "613" + "type": "617" } ], "meta-type": "object" }, { - "name": "[489]", - "element-type": "489", + "name": "[492]", + "element-type": "492", "meta-type": "array" }, { - "name": "501", + "name": "505", "members": [ { "name": "quorum" @@ -15753,33 +15867,33 @@ ] }, { - "name": "502", + "name": "506", "tag": "format", "variants": [ { "case": "luks", - "type": "615" + "type": "619" }, { "case": "luks2", - "type": "616" + "type": "620" } ], "members": [ { "name": "format", - "type": "614" + "type": "618" } ], "meta-type": "object" }, { - "name": "[503]", - "element-type": "503", + "name": "[507]", + "element-type": "507", "meta-type": "array" }, { - "name": "503", + "name": "507", "members": [ { "name": "cephx" @@ -15795,12 +15909,12 @@ ] }, { - "name": "[504]", - "element-type": "504", + "name": "[508]", + "element-type": "508", "meta-type": "array" }, { - "name": "504", + "name": "508", "members": [ { "name": "host", @@ -15814,7 +15928,7 @@ "meta-type": "object" }, { - "name": "505", + "name": "509", "members": [ { "name": "primary" @@ -15830,7 +15944,7 @@ ] }, { - "name": "506", + "name": "510", "members": [ { "name": "host", @@ -15874,12 +15988,12 @@ "meta-type": "object" }, { - "name": "507", + "name": "511", "tag": "mode", "variants": [ { "case": "hash", - "type": "618" + "type": "622" }, { "case": "none", @@ -15893,13 +16007,13 @@ "members": [ { "name": "mode", - "type": "617" + "type": "621" } ], "meta-type": "object" }, { - "name": "508", + "name": "512", "members": [ { "name": "filename", @@ -15912,7 +16026,7 @@ { "name": "preallocation", "default": null, - "type": "619" + "type": "623" }, { "name": "nocow", @@ -15928,11 +16042,11 @@ "meta-type": "object" }, { - "name": "509", + "name": "513", "members": [ { "name": "location", - "type": "289" + "type": "292" }, { "name": "size", @@ -15941,13 +16055,13 @@ { "name": "preallocation", "default": null, - "type": "619" + "type": "623" } ], "meta-type": "object" }, { - "name": "510", + "name": "514", "members": [ { "name": "key-secret", @@ -15957,27 +16071,27 @@ { "name": "cipher-alg", "default": null, - "type": "620" + "type": "624" }, { "name": "cipher-mode", "default": null, - "type": "621" + "type": "625" }, { "name": "ivgen-alg", "default": null, - "type": "622" + "type": "626" }, { "name": "ivgen-hash-alg", "default": null, - "type": "623" + "type": "627" }, { "name": "hash-alg", "default": null, - "type": "623" + "type": "627" }, { "name": "iter-time", @@ -15986,7 +16100,7 @@ }, { "name": "file", - "type": "489" + "type": "492" }, { "name": "size", @@ -15995,17 +16109,17 @@ { "name": "preallocation", "default": null, - "type": "619" + "type": "623" } ], "meta-type": "object" }, { - "name": "511", + "name": "515", "members": [ { "name": "location", - "type": "295" + "type": "298" }, { "name": "size", @@ -16015,11 +16129,11 @@ "meta-type": "object" }, { - "name": "512", + "name": "516", "members": [ { "name": "file", - "type": "489" + "type": "492" }, { "name": "size", @@ -16034,11 +16148,11 @@ "meta-type": "object" }, { - "name": "513", + "name": "517", "members": [ { "name": "file", - "type": "489" + "type": "492" }, { "name": "size", @@ -16052,22 +16166,22 @@ { "name": "encrypt", "default": null, - "type": "624" + "type": "628" } ], "meta-type": "object" }, { - "name": "514", + "name": "518", "members": [ { "name": "file", - "type": "489" + "type": "492" }, { "name": "data-file", "default": null, - "type": "489" + "type": "492" }, { "name": "data-file-raw", @@ -16086,7 +16200,7 @@ { "name": "version", "default": null, - "type": "625" + "type": "629" }, { "name": "backing-file", @@ -16096,12 +16210,12 @@ { "name": "backing-fmt", "default": null, - "type": "276" + "type": "279" }, { "name": "encrypt", "default": null, - "type": "624" + "type": "628" }, { "name": "cluster-size", @@ -16111,7 +16225,7 @@ { "name": "preallocation", "default": null, - "type": "619" + "type": "623" }, { "name": "lazy-refcounts", @@ -16126,17 +16240,17 @@ { "name": "compression-type", "default": null, - "type": "626" + "type": "630" } ], "meta-type": "object" }, { - "name": "515", + "name": "519", "members": [ { "name": "file", - "type": "489" + "type": "492" }, { "name": "size", @@ -16150,7 +16264,7 @@ { "name": "backing-fmt", "default": null, - "type": "276" + "type": "279" }, { "name": "cluster-size", @@ -16166,11 +16280,11 @@ "meta-type": "object" }, { - "name": "516", + "name": "520", "members": [ { "name": "location", - "type": "304" + "type": "307" }, { "name": "size", @@ -16184,17 +16298,17 @@ { "name": "encrypt", "default": null, - "type": "627" + "type": "631" } ], "meta-type": "object" }, { - "name": "517", + "name": "521", "members": [ { "name": "location", - "type": "306" + "type": "309" }, { "name": "size", @@ -16204,11 +16318,11 @@ "meta-type": "object" }, { - "name": "518", + "name": "522", "members": [ { "name": "file", - "type": "489" + "type": "492" }, { "name": "size", @@ -16217,17 +16331,17 @@ { "name": "preallocation", "default": null, - "type": "619" + "type": "623" } ], "meta-type": "object" }, { - "name": "519", + "name": "523", "members": [ { "name": "file", - "type": "489" + "type": "492" }, { "name": "size", @@ -16246,7 +16360,7 @@ { "name": "subformat", "default": null, - "type": "628" + "type": "632" }, { "name": "block-state-zero", @@ -16257,11 +16371,11 @@ "meta-type": "object" }, { - "name": "520", + "name": "524", "members": [ { "name": "file", - "type": "489" + "type": "492" }, { "name": "size", @@ -16270,12 +16384,12 @@ { "name": "extents", "default": null, - "type": "[489]" + "type": "[492]" }, { "name": "subformat", "default": null, - "type": "629" + "type": "633" }, { "name": "backing-file", @@ -16285,7 +16399,7 @@ { "name": "adapter-type", "default": null, - "type": "630" + "type": "634" }, { "name": "hwversion", @@ -16306,11 +16420,11 @@ "meta-type": "object" }, { - "name": "521", + "name": "525", "members": [ { "name": "file", - "type": "489" + "type": "492" }, { "name": "size", @@ -16319,7 +16433,7 @@ { "name": "subformat", "default": null, - "type": "631" + "type": "635" }, { "name": "force-size", @@ -16330,11 +16444,11 @@ "meta-type": "object" }, { - "name": "522", + "name": "526", "members": [ { "name": "state", - "type": "632" + "type": "636" }, { "name": "new-secret", @@ -16365,12 +16479,12 @@ "meta-type": "object" }, { - "name": "523", + "name": "527", "members": [ { "name": "encrypt", "default": null, - "type": "633" + "type": "637" } ], "meta-type": "object" @@ -16381,7 +16495,7 @@ "meta-type": "builtin" }, { - "name": "524", + "name": "528", "members": [ { "name": "inet" @@ -16405,47 +16519,47 @@ ] }, { - "name": "525", + "name": "529", "members": [ { "name": "data", - "type": "506" + "type": "510" } ], "meta-type": "object" }, { - "name": "526", + "name": "530", "members": [ { "name": "data", - "type": "555" + "type": "559" } ], "meta-type": "object" }, { - "name": "527", + "name": "531", "members": [ { "name": "data", - "type": "556" + "type": "560" } ], "meta-type": "object" }, { - "name": "528", + "name": "532", "members": [ { "name": "data", - "type": "544" + "type": "548" } ], "meta-type": "object" }, { - "name": "529", + "name": "533", "members": [ { "name": "off" @@ -16465,7 +16579,7 @@ ] }, { - "name": "530", + "name": "534", "members": [ { "name": "file" @@ -16561,142 +16675,142 @@ ] }, { - "name": "531", + "name": "535", "members": [ { "name": "data", - "type": "634" + "type": "638" } ], "meta-type": "object" }, { - "name": "532", + "name": "536", "members": [ { "name": "data", - "type": "635" + "type": "639" } ], "meta-type": "object" }, { - "name": "533", + "name": "537", "members": [ { "name": "data", - "type": "636" + "type": "640" } ], "meta-type": "object" }, { - "name": "534", + "name": "538", "members": [ { "name": "data", - "type": "637" + "type": "641" } ], "meta-type": "object" }, { - "name": "535", + "name": "539", "members": [ { "name": "data", - "type": "638" + "type": "642" } ], "meta-type": "object" }, { - "name": "536", + "name": "540", "members": [ { "name": "data", - "type": "639" + "type": "643" } ], "meta-type": "object" }, { - "name": "537", + "name": "541", "members": [ { "name": "data", - "type": "640" + "type": "644" } ], "meta-type": "object" }, { - "name": "538", + "name": "542", "members": [ { "name": "data", - "type": "641" + "type": "645" } ], "meta-type": "object" }, { - "name": "539", + "name": "543", "members": [ { "name": "data", - "type": "642" + "type": "646" } ], "meta-type": "object" }, { - "name": "540", + "name": "544", "members": [ { "name": "data", - "type": "643" + "type": "647" } ], "meta-type": "object" }, { - "name": "541", + "name": "545", "members": [ { "name": "data", - "type": "644" + "type": "648" } ], "meta-type": "object" }, { - "name": "542", + "name": "546", "members": [ { "name": "data", - "type": "645" + "type": "649" } ], "meta-type": "object" }, { - "name": "543", + "name": "547", "members": [ { "name": "data", - "type": "646" + "type": "650" } ], "meta-type": "object" }, { - "name": "[544]", - "element-type": "544", + "name": "[548]", + "element-type": "548", "meta-type": "array" }, { - "name": "544", + "name": "548", "members": [ { "name": "str", @@ -16706,27 +16820,27 @@ "meta-type": "object" }, { - "name": "545", + "name": "549", "members": [ { "name": "data", - "type": "647" + "type": "651" } ], "meta-type": "object" }, { - "name": "546", + "name": "550", "members": [ { "name": "data", - "type": "648" + "type": "652" } ], "meta-type": "object" }, { - "name": "547", + "name": "551", "members": [ { "name": "number" @@ -16742,7 +16856,7 @@ ] }, { - "name": "548", + "name": "552", "members": [ { "name": "data", @@ -16752,17 +16866,17 @@ "meta-type": "object" }, { - "name": "549", + "name": "553", "members": [ { "name": "data", - "type": "649" + "type": "653" } ], "meta-type": "object" }, { - "name": "550", + "name": "554", "members": [ { "name": "key" @@ -16786,37 +16900,37 @@ ] }, { - "name": "551", + "name": "555", "members": [ { "name": "data", - "type": "650" + "type": "654" } ], "meta-type": "object" }, { - "name": "552", + "name": "556", "members": [ { "name": "data", - "type": "651" + "type": "655" } ], "meta-type": "object" }, { - "name": "553", + "name": "557", "members": [ { "name": "data", - "type": "652" + "type": "656" } ], "meta-type": "object" }, { - "name": "554", + "name": "558", "members": [ { "name": "lctrl-lalt" @@ -16841,7 +16955,7 @@ "meta-type": "builtin" }, { - "name": "555", + "name": "559", "members": [ { "name": "path", @@ -16861,7 +16975,7 @@ "meta-type": "object" }, { - "name": "556", + "name": "560", "members": [ { "name": "cid", @@ -16875,12 +16989,12 @@ "meta-type": "object" }, { - "name": "[557]", - "element-type": "557", + "name": "[561]", + "element-type": "561", "meta-type": "array" }, { - "name": "557", + "name": "561", "members": [ { "name": "name", @@ -16893,13 +17007,13 @@ { "name": "transform", "default": null, - "type": "653" + "type": "657" } ], "meta-type": "object" }, { - "name": "558", + "name": "562", "members": [ { "name": "abort" @@ -16958,17 +17072,17 @@ ] }, { - "name": "559", + "name": "563", "members": [ { "name": "data", - "type": "654" + "type": "658" } ], "meta-type": "object" }, { - "name": "560", + "name": "564", "members": [ { "name": "data", @@ -16978,7 +17092,7 @@ "meta-type": "object" }, { - "name": "561", + "name": "565", "members": [ { "name": "data", @@ -16988,7 +17102,7 @@ "meta-type": "object" }, { - "name": "562", + "name": "566", "members": [ { "name": "data", @@ -16998,7 +17112,7 @@ "meta-type": "object" }, { - "name": "563", + "name": "567", "members": [ { "name": "data", @@ -17008,7 +17122,7 @@ "meta-type": "object" }, { - "name": "564", + "name": "568", "members": [ { "name": "data", @@ -17018,7 +17132,7 @@ "meta-type": "object" }, { - "name": "565", + "name": "569", "members": [ { "name": "data", @@ -17028,7 +17142,7 @@ "meta-type": "object" }, { - "name": "566", + "name": "570", "members": [ { "name": "data", @@ -17038,7 +17152,7 @@ "meta-type": "object" }, { - "name": "567", + "name": "571", "members": [ { "name": "data", @@ -17048,7 +17162,7 @@ "meta-type": "object" }, { - "name": "568", + "name": "572", "members": [ { "name": "individual" @@ -17064,7 +17178,7 @@ ] }, { - "name": "569", + "name": "573", "members": [ { "name": "string" @@ -17104,12 +17218,12 @@ ] }, { - "name": "[570]", - "element-type": "570", + "name": "[574]", + "element-type": "574", "meta-type": "array" }, { - "name": "570", + "name": "574", "members": [ { "name": "name", @@ -17124,12 +17238,12 @@ "meta-type": "object" }, { - "name": "[571]", - "element-type": "571", + "name": "[575]", + "element-type": "575", "meta-type": "array" }, { - "name": "571", + "name": "575", "members": [ { "name": "name", @@ -17153,12 +17267,12 @@ "meta-type": "object" }, { - "name": "[572]", - "element-type": "572", + "name": "[576]", + "element-type": "576", "meta-type": "array" }, { - "name": "572", + "name": "576", "members": [ { "name": "case", @@ -17172,12 +17286,12 @@ "meta-type": "object" }, { - "name": "[573]", - "element-type": "573", + "name": "[577]", + "element-type": "577", "meta-type": "array" }, { - "name": "573", + "name": "577", "members": [ { "name": "type", @@ -17187,7 +17301,7 @@ "meta-type": "object" }, { - "name": "574", + "name": "578", "members": [ { "name": "deny" @@ -17203,12 +17317,12 @@ ] }, { - "name": "[575]", - "element-type": "575", + "name": "[579]", + "element-type": "579", "meta-type": "array" }, { - "name": "575", + "name": "579", "members": [ { "name": "match", @@ -17216,18 +17330,18 @@ }, { "name": "policy", - "type": "574" + "type": "578" }, { "name": "format", "default": null, - "type": "655" + "type": "659" } ], "meta-type": "object" }, { - "name": "576", + "name": "580", "members": [ { "name": "all" @@ -17247,7 +17361,7 @@ ] }, { - "name": "577", + "name": "581", "members": [ { "name": "before" @@ -17263,7 +17377,7 @@ ] }, { - "name": "578", + "name": "582", "members": [ { "name": "ctrl-ctrl" @@ -17295,7 +17409,7 @@ ] }, { - "name": "579", + "name": "583", "members": [ { "name": "raw" @@ -17311,7 +17425,7 @@ ] }, { - "name": "580", + "name": "584", "members": [ { "name": "iops-total", @@ -17412,7 +17526,7 @@ "meta-type": "object" }, { - "name": "581", + "name": "585", "members": [ { "name": "client" @@ -17428,7 +17542,7 @@ ] }, { - "name": "582", + "name": "586", "members": [ { "name": "uninitialized" @@ -17456,7 +17570,7 @@ ] }, { - "name": "583", + "name": "587", "members": [ { "name": "memory" @@ -17480,7 +17594,7 @@ ] }, { - "name": "584", + "name": "588", "members": [ { "name": "access-latency" @@ -17512,7 +17626,7 @@ ] }, { - "name": "585", + "name": "589", "members": [ { "name": "none" @@ -17532,7 +17646,7 @@ ] }, { - "name": "586", + "name": "590", "members": [ { "name": "none" @@ -17552,7 +17666,7 @@ ] }, { - "name": "587", + "name": "591", "members": [ { "name": "id", @@ -17591,7 +17705,7 @@ "meta-type": "object" }, { - "name": "588", + "name": "592", "members": [ { "name": "id", @@ -17614,7 +17728,7 @@ "meta-type": "object" }, { - "name": "589", + "name": "593", "members": [ { "name": "id", @@ -17653,7 +17767,7 @@ "meta-type": "object" }, { - "name": "590", + "name": "594", "members": [ { "name": "id", @@ -17680,7 +17794,7 @@ "meta-type": "object" }, { - "name": "591", + "name": "595", "members": [ { "name": "string" @@ -17704,7 +17818,7 @@ ] }, { - "name": "592", + "name": "596", "members": [ { "name": "desc", @@ -17719,7 +17833,7 @@ "meta-type": "object" }, { - "name": "593", + "name": "597", "members": [ { "name": "device", @@ -17743,27 +17857,27 @@ "meta-type": "object" }, { - "name": "594", + "name": "598", "members": [ { "name": "bus", - "type": "656" + "type": "660" }, { "name": "devices", "default": null, - "type": "[472]" + "type": "[475]" } ], "meta-type": "object" }, { - "name": "[595]", - "element-type": "595", + "name": "[599]", + "element-type": "599", "meta-type": "array" }, { - "name": "595", + "name": "599", "members": [ { "name": "bar", @@ -17795,11 +17909,14 @@ "meta-type": "object" }, { - "name": "596", + "name": "600", "members": [ { "type": "int" }, + { + "type": "bool" + }, { "type": "[int]" } @@ -17807,7 +17924,7 @@ "meta-type": "alternate" }, { - "name": "597", + "name": "601", "members": [ { "name": "cumulative" @@ -17835,7 +17952,7 @@ ] }, { - "name": "598", + "name": "602", "members": [ { "name": "bytes" @@ -17845,17 +17962,21 @@ }, { "name": "cycles" + }, + { + "name": "boolean" } ], "meta-type": "enum", "values": [ "bytes", "seconds", - "cycles" + "cycles", + "boolean" ] }, { - "name": "599", + "name": "603", "members": [ { "name": "unknown" @@ -17883,7 +18004,7 @@ ] }, { - "name": "600", + "name": "604", "members": [ { "name": "qcow2" @@ -17907,47 +18028,47 @@ ] }, { - "name": "601", + "name": "605", "members": [ { "name": "data", - "type": "657" + "type": "661" } ], "meta-type": "object" }, { - "name": "602", + "name": "606", "members": [ { "name": "data", - "type": "658" + "type": "662" } ], "meta-type": "object" }, { - "name": "603", + "name": "607", "members": [ { "name": "data", - "type": "659" + "type": "663" } ], "meta-type": "object" }, { - "name": "604", + "name": "608", "members": [ { "name": "data", - "type": "660" + "type": "664" } ], "meta-type": "object" }, { - "name": "605", + "name": "609", "members": [ { "name": "l1_update" @@ -18147,7 +18268,7 @@ ] }, { - "name": "606", + "name": "610", "members": [ { "name": "read" @@ -18179,7 +18300,7 @@ ] }, { - "name": "607", + "name": "611", "members": [ { "name": "inet" @@ -18191,12 +18312,12 @@ ] }, { - "name": "608", + "name": "612", "members": [ { "name": "template", "default": null, - "type": "609" + "type": "613" }, { "name": "main-header", @@ -18247,7 +18368,7 @@ "meta-type": "object" }, { - "name": "609", + "name": "613", "members": [ { "name": "none" @@ -18271,7 +18392,7 @@ ] }, { - "name": "610", + "name": "614", "members": [ { "name": "aes" @@ -18287,7 +18408,7 @@ ] }, { - "name": "611", + "name": "615", "members": [ { "name": "key-secret", @@ -18298,7 +18419,7 @@ "meta-type": "object" }, { - "name": "612", + "name": "616", "members": [ { "name": "key-secret", @@ -18309,7 +18430,7 @@ "meta-type": "object" }, { - "name": "613", + "name": "617", "members": [ { "name": "aes" @@ -18321,7 +18442,7 @@ ] }, { - "name": "614", + "name": "618", "members": [ { "name": "luks" @@ -18337,7 +18458,7 @@ ] }, { - "name": "615", + "name": "619", "members": [ { "name": "key-secret", @@ -18347,7 +18468,7 @@ "meta-type": "object" }, { - "name": "616", + "name": "620", "members": [ { "name": "key-secret", @@ -18357,7 +18478,7 @@ "meta-type": "object" }, { - "name": "617", + "name": "621", "members": [ { "name": "none" @@ -18377,11 +18498,11 @@ ] }, { - "name": "618", + "name": "622", "members": [ { "name": "type", - "type": "661" + "type": "665" }, { "name": "hash", @@ -18391,7 +18512,7 @@ "meta-type": "object" }, { - "name": "619", + "name": "623", "members": [ { "name": "off" @@ -18415,7 +18536,7 @@ ] }, { - "name": "620", + "name": "624", "members": [ { "name": "aes-128" @@ -18471,7 +18592,7 @@ ] }, { - "name": "621", + "name": "625", "members": [ { "name": "ecb" @@ -18495,7 +18616,7 @@ ] }, { - "name": "622", + "name": "626", "members": [ { "name": "plain" @@ -18515,7 +18636,7 @@ ] }, { - "name": "623", + "name": "627", "members": [ { "name": "md5" @@ -18551,28 +18672,28 @@ ] }, { - "name": "624", + "name": "628", "tag": "format", "variants": [ { "case": "qcow", - "type": "611" + "type": "615" }, { "case": "luks", - "type": "663" + "type": "667" } ], "members": [ { "name": "format", - "type": "662" + "type": "666" } ], "meta-type": "object" }, { - "name": "625", + "name": "629", "members": [ { "name": "v2" @@ -18588,7 +18709,7 @@ ] }, { - "name": "626", + "name": "630", "members": [ { "name": "zlib" @@ -18604,28 +18725,28 @@ ] }, { - "name": "627", + "name": "631", "tag": "format", "variants": [ { "case": "luks", - "type": "664" + "type": "668" }, { "case": "luks2", - "type": "665" + "type": "669" } ], "members": [ { "name": "format", - "type": "614" + "type": "618" } ], "meta-type": "object" }, { - "name": "628", + "name": "632", "members": [ { "name": "dynamic" @@ -18641,7 +18762,7 @@ ] }, { - "name": "629", + "name": "633", "members": [ { "name": "monolithicSparse" @@ -18669,7 +18790,7 @@ ] }, { - "name": "630", + "name": "634", "members": [ { "name": "ide" @@ -18693,7 +18814,7 @@ ] }, { - "name": "631", + "name": "635", "members": [ { "name": "dynamic" @@ -18709,7 +18830,7 @@ ] }, { - "name": "632", + "name": "636", "members": [ { "name": "active" @@ -18725,12 +18846,12 @@ ] }, { - "name": "633", + "name": "637", "tag": "format", "variants": [ { "case": "luks", - "type": "666" + "type": "670" }, { "case": "qcow", @@ -18740,13 +18861,13 @@ "members": [ { "name": "format", - "type": "662" + "type": "666" } ], "meta-type": "object" }, { - "name": "634", + "name": "638", "members": [ { "name": "logfile", @@ -18776,7 +18897,7 @@ "meta-type": "object" }, { - "name": "635", + "name": "639", "members": [ { "name": "logfile", @@ -18796,7 +18917,7 @@ "meta-type": "object" }, { - "name": "636", + "name": "640", "members": [ { "name": "logfile", @@ -18810,7 +18931,7 @@ }, { "name": "addr", - "type": "316" + "type": "319" }, { "name": "tls-creds", @@ -18861,7 +18982,7 @@ "meta-type": "object" }, { - "name": "637", + "name": "641", "members": [ { "name": "logfile", @@ -18875,18 +18996,18 @@ }, { "name": "remote", - "type": "316" + "type": "319" }, { "name": "local", "default": null, - "type": "316" + "type": "319" } ], "meta-type": "object" }, { - "name": "638", + "name": "642", "members": [ { "name": "logfile", @@ -18902,7 +19023,7 @@ "meta-type": "object" }, { - "name": "639", + "name": "643", "members": [ { "name": "logfile", @@ -18922,7 +19043,7 @@ "meta-type": "object" }, { - "name": "640", + "name": "644", "members": [ { "name": "logfile", @@ -18943,7 +19064,7 @@ "meta-type": "object" }, { - "name": "641", + "name": "645", "members": [ { "name": "logfile", @@ -18963,7 +19084,7 @@ "meta-type": "object" }, { - "name": "642", + "name": "646", "members": [ { "name": "logfile", @@ -18983,7 +19104,7 @@ "meta-type": "object" }, { - "name": "643", + "name": "647", "members": [ { "name": "logfile", @@ -19009,7 +19130,7 @@ "meta-type": "object" }, { - "name": "644", + "name": "648", "members": [ { "name": "logfile", @@ -19029,7 +19150,7 @@ "meta-type": "object" }, { - "name": "645", + "name": "649", "members": [ { "name": "logfile", @@ -19065,7 +19186,7 @@ "meta-type": "object" }, { - "name": "646", + "name": "650", "members": [ { "name": "logfile", @@ -19086,7 +19207,7 @@ "meta-type": "object" }, { - "name": "647", + "name": "651", "members": [ { "name": "path", @@ -19102,7 +19223,7 @@ "meta-type": "object" }, { - "name": "648", + "name": "652", "members": [ { "name": "chardev", @@ -19112,7 +19233,7 @@ "meta-type": "object" }, { - "name": "649", + "name": "653", "members": [ { "name": "unmapped" @@ -19720,11 +19841,11 @@ ] }, { - "name": "650", + "name": "654", "members": [ { "name": "key", - "type": "365" + "type": "368" }, { "name": "down", @@ -19734,11 +19855,11 @@ "meta-type": "object" }, { - "name": "651", + "name": "655", "members": [ { "name": "button", - "type": "667" + "type": "671" }, { "name": "down", @@ -19748,11 +19869,11 @@ "meta-type": "object" }, { - "name": "652", + "name": "656", "members": [ { "name": "axis", - "type": "668" + "type": "672" }, { "name": "value", @@ -19762,7 +19883,7 @@ "meta-type": "object" }, { - "name": "653", + "name": "657", "members": [ { "name": "persistent", @@ -19773,13 +19894,13 @@ "meta-type": "object" }, { - "name": "654", + "name": "658", "members": [ ], "meta-type": "object" }, { - "name": "655", + "name": "659", "members": [ { "name": "exact" @@ -19795,7 +19916,7 @@ ] }, { - "name": "656", + "name": "660", "members": [ { "name": "number", @@ -19811,21 +19932,21 @@ }, { "name": "io_range", - "type": "669" + "type": "673" }, { "name": "memory_range", - "type": "669" + "type": "673" }, { "name": "prefetchable_range", - "type": "669" + "type": "673" } ], "meta-type": "object" }, { - "name": "657", + "name": "661", "members": [ { "name": "compat", @@ -19863,22 +19984,22 @@ { "name": "encrypt", "default": null, - "type": "670" + "type": "674" }, { "name": "bitmaps", "default": null, - "type": "[671]" + "type": "[675]" }, { "name": "compression-type", - "type": "626" + "type": "630" } ], "meta-type": "object" }, { - "name": "658", + "name": "662", "members": [ { "name": "create-type", @@ -19894,34 +20015,34 @@ }, { "name": "extents", - "type": "[269]" + "type": "[272]" } ], "meta-type": "object" }, { - "name": "659", + "name": "663", "members": [ { "name": "cipher-alg", - "type": "620" + "type": "624" }, { "name": "cipher-mode", - "type": "621" + "type": "625" }, { "name": "ivgen-alg", - "type": "622" + "type": "626" }, { "name": "ivgen-hash-alg", "default": null, - "type": "623" + "type": "627" }, { "name": "hash-alg", - "type": "623" + "type": "627" }, { "name": "payload-offset", @@ -19937,24 +20058,24 @@ }, { "name": "slots", - "type": "[672]" + "type": "[676]" } ], "meta-type": "object" }, { - "name": "660", + "name": "664", "members": [ { "name": "encryption-format", "default": null, - "type": "614" + "type": "618" } ], "meta-type": "object" }, { - "name": "661", + "name": "665", "members": [ { "name": "md5" @@ -19974,7 +20095,7 @@ ] }, { - "name": "662", + "name": "666", "members": [ { "name": "qcow" @@ -19990,7 +20111,7 @@ ] }, { - "name": "663", + "name": "667", "members": [ { "name": "key-secret", @@ -20000,27 +20121,27 @@ { "name": "cipher-alg", "default": null, - "type": "620" + "type": "624" }, { "name": "cipher-mode", "default": null, - "type": "621" + "type": "625" }, { "name": "ivgen-alg", "default": null, - "type": "622" + "type": "626" }, { "name": "ivgen-hash-alg", "default": null, - "type": "623" + "type": "627" }, { "name": "hash-alg", "default": null, - "type": "623" + "type": "627" }, { "name": "iter-time", @@ -20031,7 +20152,7 @@ "meta-type": "object" }, { - "name": "664", + "name": "668", "members": [ { "name": "key-secret", @@ -20040,13 +20161,13 @@ { "name": "cipher-alg", "default": null, - "type": "620" + "type": "624" } ], "meta-type": "object" }, { - "name": "665", + "name": "669", "members": [ { "name": "key-secret", @@ -20055,17 +20176,17 @@ { "name": "cipher-alg", "default": null, - "type": "620" + "type": "624" } ], "meta-type": "object" }, { - "name": "666", + "name": "670", "members": [ { "name": "state", - "type": "632" + "type": "636" }, { "name": "new-secret", @@ -20096,7 +20217,7 @@ "meta-type": "object" }, { - "name": "667", + "name": "671", "members": [ { "name": "left" @@ -20140,7 +20261,7 @@ ] }, { - "name": "668", + "name": "672", "members": [ { "name": "x" @@ -20156,7 +20277,7 @@ ] }, { - "name": "669", + "name": "673", "members": [ { "name": "base", @@ -20170,12 +20291,12 @@ "meta-type": "object" }, { - "name": "670", + "name": "674", "tag": "format", "variants": [ { "case": "luks", - "type": "659" + "type": "663" }, { "case": "aes", @@ -20185,18 +20306,18 @@ "members": [ { "name": "format", - "type": "610" + "type": "614" } ], "meta-type": "object" }, { - "name": "[671]", - "element-type": "671", + "name": "[675]", + "element-type": "675", "meta-type": "array" }, { - "name": "671", + "name": "675", "members": [ { "name": "name", @@ -20208,23 +20329,23 @@ }, { "name": "flags", - "type": "[673]" + "type": "[677]" } ], "meta-type": "object" }, { - "name": "[269]", - "element-type": "269", + "name": "[272]", + "element-type": "272", "meta-type": "array" }, { - "name": "[672]", - "element-type": "672", + "name": "[676]", + "element-type": "676", "meta-type": "array" }, { - "name": "672", + "name": "676", "members": [ { "name": "active", @@ -20248,12 +20369,12 @@ "meta-type": "object" }, { - "name": "[673]", - "element-type": "673", + "name": "[677]", + "element-type": "677", "meta-type": "array" }, { - "name": "673", + "name": "677", "members": [ { "name": "in-use" @@ -20528,6 +20649,15 @@ { "name": "snapshot-save" }, + { + "name": "query-vcpu-dirty-limit" + }, + { + "name": "cancel-vcpu-dirty-limit" + }, + { + "name": "set-vcpu-dirty-limit" + }, { "name": "query-dirty-rate" }, @@ -24817,6 +24947,12 @@ "name": "max_io_size", "type": "uint64" }, + { + "default-value": false, + "name": "quirk_mode_page_vendor_specific_apple", + "description": "on/off", + "type": "bool" + }, { "default-value": 0, "name": "opt_io_size", @@ -33848,6 +33984,10 @@ { "state": false, "capability": "zero-copy-send" + }, + { + "state": false, + "capability": "postcopy-preempt" } ], "id": "libvirt-49" diff --git a/tests/qemucapabilitiesdata/caps_7.1.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_7.1.0.x86_64.xml index 2b2f1aef52..2e30fc5f2e 100644 --- a/tests/qemucapabilitiesdata/caps_7.1.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_7.1.0.x86_64.xml @@ -246,7 +246,7 @@ <version>7000050</version> <kvmVersion>0</kvmVersion> <microcodeVersion>43100244</microcodeVersion> - <package>v7.0.0-2187-g2a8835cb45</package> + <package>v7.0.0-2780-g5288bee45f</package> <arch>x86_64</arch> <hostCPU type='kvm' model='base' migratability='yes'> <property name='vmx-entry-load-rtit-ctl' type='boolean' value='false'/> -- 2.36.1

2 1

[PATCH 0/2] qemu_hotplug: Fix two issues with chardev hotplug
by Michal Privoznik 22 Jul '22

22 Jul '22

And while at it, make the code 5 lines shorter. Michal Prívozník (2): qemu_hotplug: Close FDs in QEMU on failed chardev hotplug qemu_hotplug: Create chardev files before attempting to relabel them src/qemu/qemu_hotplug.c | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) -- 2.35.1

2 4

[PATCH] qemu_migration: Acquire correct job in qemuMigrationSrcIsAllowed
by Martin Kletzander 22 Jul '22

22 Jul '22

Commit 62627524607f added the acquiring of a job, but it is not always VIR_ASYNC_JOB_MIGRATION_OUT, so the code fails when doing save or anything else. Correct the async job by passing it from the caller as another parameter. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- This will hopefully fix the integration tests that failed this morning: https://gitlab.com/libvirt/libvirt/-/pipelines/594066714 src/qemu/qemu_driver.c | 8 ++++---- src/qemu/qemu_migration.c | 7 ++++--- src/qemu/qemu_migration.h | 1 + src/qemu/qemu_snapshot.c | 4 ++-- 4 files changed, 11 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 75c7a8a6b225..9013e6fb8d9a 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2651,13 +2651,13 @@ qemuDomainSaveInternal(virQEMUDriver *driver, virQEMUSaveData *data = NULL; g_autoptr(qemuDomainSaveCookie) cookie = NULL; - if (!qemuMigrationSrcIsAllowed(driver, vm, false, 0)) - goto cleanup; - if (qemuDomainObjBeginAsyncJob(driver, vm, VIR_ASYNC_JOB_SAVE, VIR_DOMAIN_JOB_OPERATION_SAVE, flags) < 0) goto cleanup; + if (!qemuMigrationSrcIsAllowed(driver, vm, false, VIR_ASYNC_JOB_SAVE, 0)) + goto cleanup; + if (!virDomainObjIsActive(vm)) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("guest unexpectedly quit")); @@ -3177,7 +3177,7 @@ doCoreDump(virQEMUDriver *driver, goto cleanup; } - if (!qemuMigrationSrcIsAllowed(driver, vm, false, 0)) + if (!qemuMigrationSrcIsAllowed(driver, vm, false, VIR_ASYNC_JOB_DUMP, 0)) goto cleanup; if (qemuMigrationSrcToFile(driver, vm, fd, compressor, diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 84befe7d39e7..20dc91f1cedd 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -1452,6 +1452,7 @@ bool qemuMigrationSrcIsAllowed(virQEMUDriver *driver, virDomainObj *vm, bool remote, + int asyncJob, unsigned int flags) { qemuDomainObjPrivate *priv = vm->privateData; @@ -1483,7 +1484,7 @@ qemuMigrationSrcIsAllowed(virQEMUDriver *driver, g_auto(GStrv) blockers = NULL; if (qemuDomainGetMigrationBlockers(driver, vm, - VIR_ASYNC_JOB_MIGRATION_OUT, + asyncJob, &blockers) < 0) { return false; } @@ -2637,7 +2638,7 @@ qemuMigrationSrcBeginPhase(virQEMUDriver *driver, qemuMigrationJobStartPhase(vm, QEMU_MIGRATION_PHASE_BEGIN3) < 0) return NULL; - if (!qemuMigrationSrcIsAllowed(driver, vm, true, flags)) + if (!qemuMigrationSrcIsAllowed(driver, vm, true, priv->job.asyncJob, flags)) return NULL; if (!(flags & (VIR_MIGRATE_UNSAFE | VIR_MIGRATE_OFFLINE)) && @@ -6039,7 +6040,7 @@ qemuMigrationSrcPerformJob(virQEMUDriver *driver, if (!(flags & VIR_MIGRATE_OFFLINE) && virDomainObjCheckActive(vm) < 0) goto endjob; - if (!qemuMigrationSrcIsAllowed(driver, vm, true, flags)) + if (!qemuMigrationSrcIsAllowed(driver, vm, true, VIR_ASYNC_JOB_MIGRATION_OUT, flags)) goto endjob; if (!(flags & (VIR_MIGRATE_UNSAFE | VIR_MIGRATE_OFFLINE)) && diff --git a/src/qemu/qemu_migration.h b/src/qemu/qemu_migration.h index 65c29d574405..a39f65165988 100644 --- a/src/qemu/qemu_migration.h +++ b/src/qemu/qemu_migration.h @@ -229,6 +229,7 @@ bool qemuMigrationSrcIsAllowed(virQEMUDriver *driver, virDomainObj *vm, bool remote, + int asyncJob, unsigned int flags); int diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index 833f880252af..0733d44faac4 100644 --- a/src/qemu/qemu_snapshot.c +++ b/src/qemu/qemu_snapshot.c @@ -291,7 +291,7 @@ qemuSnapshotCreateActiveInternal(virQEMUDriver *driver, virDomainSnapshotDef *snapdef = virDomainSnapshotObjGetDef(snap); int ret = -1; - if (!qemuMigrationSrcIsAllowed(driver, vm, false, 0)) + if (!qemuMigrationSrcIsAllowed(driver, vm, false, VIR_ASYNC_JOB_SNAPSHOT, 0)) goto cleanup; if (virDomainObjGetState(vm, NULL) == VIR_DOMAIN_RUNNING) { @@ -1422,7 +1422,7 @@ qemuSnapshotCreateActiveExternal(virQEMUDriver *driver, /* do the memory snapshot if necessary */ if (memory) { /* check if migration is possible */ - if (!qemuMigrationSrcIsAllowed(driver, vm, false, 0)) + if (!qemuMigrationSrcIsAllowed(driver, vm, false, VIR_ASYNC_JOB_SNAPSHOT, 0)) goto cleanup; qemuDomainJobSetStatsType(priv->job.current, -- 2.35.1

2 1

[PATCH 0/4] jobs: make & use generalized virDomainObjInitJob()
by Kristina Hanicova 21 Jul '22

21 Jul '22

This series uses qemuDomainObjInitJob() as virDomainObjInitJob() in all drivers that use virDomainObjJob structure. Kristina Hanicova (4): qemu & hypervisor: move qemuDomainObjInitJob() into hypervisor libxl: use virDomainObjInitJob() LXC: use virDomainObjInitJob() CH: use virDomainObjInitJob() src/ch/ch_domain.c | 13 +------------ src/hypervisor/domain_job.c | 25 +++++++++++++++++++++++++ src/hypervisor/domain_job.h | 4 ++++ src/libvirt_private.syms | 1 + src/libxl/libxl_domain.c | 17 +++-------------- src/lxc/lxc_domain.c | 13 +------------ src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_domainjob.c | 26 -------------------------- src/qemu/qemu_domainjob.h | 4 ---- 9 files changed, 36 insertions(+), 69 deletions(-) -- 2.35.3

2 5

[PATCH v2 0/8] domain_conf & domain_capabilities: small refactoring
by Kristina Hanicova 21 Jul '22

21 Jul '22

diff to v1: * dropped 1 wrong commit (thanks Daniel) * improved setting of the variable (suggested by Peter, Michal, Martin) * extended the switch to include all cases instead of simple if to be future proof (suggested by Peter) v1: https://listman.redhat.com/archives/libvir-list/2022-July/232991.html Kristina Hanicova (8): domain_capabilities: use early return in virDomainCapsFeatureSEVFormat() domain_capabilities: reformat virDomainCapsFeatureSEVFormat() domain_capabilities: reformat virDomainCapsCPUCustomFormat() domain_conf: remove breaks after return in virDomainChrSourceDefIsEqual() domain_conf: extend switch with if in virDomainChrDefFree() domain_conf: use early return in virDomainObjAssignDef() domain_conf: rewrite conditions in virDomainObjWaitUntil() domain_conf: rewrite variable setting src/conf/domain_capabilities.c | 37 ++++++++--------- src/conf/domain_conf.c | 76 +++++++++++++++++----------------- 2 files changed, 55 insertions(+), 58 deletions(-) -- 2.35.3

2 17

[libvirt PATCH] qemu_migration: Use EnterMonitorAsync in qemuDomainGetMigrationBlockers
by Jiri Denemark 21 Jul '22

21 Jul '22

The code is run with an async job and thus needs to make sure a nested job is acquired before entering the monitor. While touching the code in qemuMigrationSrcIsAllowed I also fixed the grammar which was accidentally broken by v8.5.0-140-g2103807e33. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_migration.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 5d1e5f987b..d83db3a824 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -1418,12 +1418,15 @@ qemuMigrationSrcIsAllowedHostdev(const virDomainDef *def) static int qemuDomainGetMigrationBlockers(virQEMUDriver *driver, virDomainObj *vm, + int asyncJob, char ***blockers) { qemuDomainObjPrivate *priv = vm->privateData; int rc; - qemuDomainObjEnterMonitor(driver, vm); + if (qemuDomainObjEnterMonitorAsync(driver, vm, asyncJob) < 0) + return -1; + rc = qemuMonitorGetMigrationBlockers(priv->mon, blockers); qemuDomainObjExitMonitor(vm); @@ -1458,10 +1461,12 @@ qemuMigrationSrcIsAllowed(virQEMUDriver *driver, bool blockedReasonsCap = virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_MIGRATION_BLOCKED_REASONS); - /* Ask qemu if it have a migration blocker */ + /* Ask qemu if it has a migration blocker */ if (blockedReasonsCap) { g_auto(GStrv) blockers = NULL; - if (qemuDomainGetMigrationBlockers(driver, vm, &blockers) < 0) + if (qemuDomainGetMigrationBlockers(driver, vm, + VIR_ASYNC_JOB_MIGRATION_OUT, + &blockers) < 0) return false; if (blockers && blockers[0]) { -- 2.35.1

2 1

[PATCH v2 0/2] domain_conf: rewriting else after return
by Kristina Hanicova 21 Jul '22

21 Jul '22

diff to v1: * split one commit into two * rewrite the functions in the second one to use the switch (suggested by Daniel, thanks) v1: https://listman.redhat.com/archives/libvir-list/2022-July/232989.html Kristina Hanicova (2): domain_conf: remove else after return / goto domain_conf: rewrite if else functions to switch src/conf/domain_conf.c | 77 +++++++++++++++++++++++++++--------------- 1 file changed, 49 insertions(+), 28 deletions(-) -- 2.35.3

2 4

[PATCH 0/2] qemu_cgroup: Two almost trivial cleanups
by Michal Privoznik 21 Jul '22

21 Jul '22

I'm trying to fix SGX patches I reviewed earlier [1] and these would simplify my attempts. 1: https://listman.redhat.com/archives/libvir-list/2022-July/232679.html Michal Prívozník (2): qemu_cgroup: Avoid ternary operator when setting @deviceACL qemu_cgroup: Introduce qemuCgroupAllowDevicesPaths() src/qemu/qemu_cgroup.c | 54 +++++++++++++++++++++++++++++------------- 1 file changed, 37 insertions(+), 17 deletions(-) -- 2.35.1

3 5

[PATCH 0/2] A couple of migration blocker query patches
by Laine Stump 21 Jul '22

21 Jul '22

Five minutes after pushing eperezma's patches that query QEMU for migration blockers, I realized that the query would be called during "offline migration" (when there is no QEMU process running). So the 1st patch moves the query down so it will only be called during live migration. The 2nd patch takes advantage of this new query to skip the hardcoded check the makes any vfio assigned device a migration blocker. Once QEMU and the kernel get migration of (some) vfio devices sorted out, libvirt will allow migration of domains with those devices. Laine Stump (2): qemu: don't try to query QEMU about migration blockers during offline migration qemu: skip hardcoded hostdev migration check if QEMU can do it for us src/qemu/qemu_migration.c | 45 ++++++++++++++++++++++----------------- 1 file changed, 26 insertions(+), 19 deletions(-) -- 2.35.3

2 3

[PATCH 0/9] domain_conf & domain_capabilities: small refactoring
by Kristina Hanicova 21 Jul '22

21 Jul '22

*** BLURB HERE *** Kristina Hanicova (9): domain_capabilities: use early return in virDomainCapsFeatureSEVFormat() domain_capabilities: reformat virDomainCapsFeatureSEVFormat() domain_capabilities: reformat virDomainCapsCPUCustomFormat() domain_conf: remove breaks after return in virDomainChrSourceDefIsEqual() domain_conf: replace switch with if in virDomainChrDefFree() domain_conf: rewrite virDomainSoundCodecDefFree() domain_conf: use early return in virDomainObjAssignDef() domain_conf: rewrite conditions in virDomainObjWaitUntil() domain_conf: rewrite variable setting to ternary operator src/conf/domain_capabilities.c | 37 ++++++++------- src/conf/domain_conf.c | 82 +++++++++++++++------------------- 2 files changed, 53 insertions(+), 66 deletions(-) -- 2.35.3

5 16

[libvirt PATCH v4 0/4] Ask qemu about migration blockers
by Eugenio Pérez 21 Jul '22

21 Jul '22

There are some hardcoded migration blockers in libvirt, like having a net vhost-vdpa device. While it's true that they cannot be migrated at the moment, there are plans to be able to migrate them soon. They'll put a migration blockers in the cases where you cannot migrate them. Ask qemu about then before rejecting the migration. In case the question is not possible, assume they're not migratable. v4: * Do not override qemuDomainGetMigrationBlockers error calling again virReportError. * Replace ", " with "; " in blockers separators. v3: * Return ok in qemuMonitorJSONGetMigrationBlockers is there are no blockers. * Fix indentation * Report all blockers instead of only the first. * Squash some patches * Move note to function doc. * s/QEMU_MIGRATION_BLOCKED_REASONS/QEMU_CAPS_MIGRATION_BLOCKED_REASONS/ v2: * Ask qemu if it has some pending blockers before try the migration Eugenio Pérez (3): qemu_monitor: add support for get qemu migration blockers qemu_migration: get migration blockers before hardcoded checks qemu_migration: Do not forbid vDPA devices if can query blockers Jonathon Jongsma (1): qemu: introduce capability QEMU_CAPS_MIGRATION_BLOCKED_REASONS src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_migration.c | 34 +++++++++++++- src/qemu/qemu_monitor.c | 11 +++++ src/qemu/qemu_monitor.h | 4 ++ src/qemu/qemu_monitor_json.c | 44 +++++++++++++++++++ src/qemu/qemu_monitor_json.h | 3 ++ .../caps_6.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 1 + .../caps_6.0.0.x86_64.xml | 1 + .../caps_6.1.0.x86_64.xml | 1 + .../caps_6.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 1 + .../caps_6.2.0.x86_64.xml | 1 + .../caps_7.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml | 1 + .../caps_7.0.0.x86_64.xml | 1 + .../caps_7.1.0.x86_64.xml | 1 + 18 files changed, 109 insertions(+), 1 deletion(-) -- 2.31.1

3 9