- Devel - libvirt List Archives

[libvirt] [PATCH] Increase the number of available VNC ports.
by Chris Lalancette 06 Apr '10

06 Apr '10

When starting up qemu VNC autoport guests, we were only looking through ports 5900 to 6000, meaning we were limited to 100 total clients. Increase that limit to 65535 (the last available port), so we can have up to 59635 VNC autoport guests. Signed-off-by: Chris Lalancette <clalance(a)redhat.com> --- src/qemu/qemu_driver.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index bc94ce6..ce43fd3 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2598,7 +2598,7 @@ qemuInitPCIAddresses(struct qemud_driver *driver, static int qemudNextFreeVNCPort(struct qemud_driver *driver ATTRIBUTE_UNUSED) { int i; - for (i = 5900 ; i < 6000 ; i++) { + for (i = 5900 ; i < 65535 ; i++) { int fd; int reuse = 1; struct sockaddr_in addr; -- 1.6.6.1

3 3

[libvirt] [PATCH] nwfilter: RHEL 5 gcc fixes
by Stefan Berger 06 Apr '10

06 Apr '10

This patch fixes some compilation issues for the RHEL5 build. I am also removing the IPV6 constant where it appears in the wrong place. Seems like a new bad thing to rely on the compiler to tell about potentially uninitialized vars... Signed-off-by; Stefan Berger <stefanb(a)us.ibm.com> --- src/conf/nwfilter_conf.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) Index: libvirt-acl/src/conf/nwfilter_conf.c =================================================================== --- libvirt-acl.orig/src/conf/nwfilter_conf.c +++ libvirt-acl/src/conf/nwfilter_conf.c @@ -392,7 +392,9 @@ struct _virXMLAttr2Struct static const struct int_map macProtoMap[] = { INTMAP_ENTRY(ETHERTYPE_ARP , "arp"), INTMAP_ENTRY(ETHERTYPE_IP , "ipv4"), +#ifdef ETHERTYPE_IPV6 INTMAP_ENTRY(ETHERTYPE_IPV6, "ipv6"), +#endif INTMAP_ENTRY_LAST }; @@ -547,7 +549,6 @@ static const struct int_map ipProtoMap[] #ifdef IPPROTO_SCTP INTMAP_ENTRY(IPPROTO_SCTP, "sctp"), #endif - INTMAP_ENTRY(IPPROTO_IPV6, "ipv6"), INTMAP_ENTRY(IPPROTO_ICMPV6, "icmpv6"), INTMAP_ENTRY_LAST }; @@ -1124,7 +1125,7 @@ virNWFilterRuleDetailsParse(xmlNodePtr n nwItemDesc *item; int int_val; unsigned int uint_val; - void *data_ptr, *storage_ptr; + void *data_ptr = NULL, *storage_ptr; valueValidator validator; char *match = virXMLPropString(node, "match"); nwIPAddress ipaddr; @@ -1550,7 +1551,7 @@ virNWFilterRuleParse(xmlNodePtr node) char *direction; char *prio; int found; - int found_i; + int found_i = 0; unsigned int priority; xmlNodePtr cur;

2 2

[libvirt] [PATCH] Fix compiler warning about unused conn parameter
by Matthias Bolte 06 Apr '10

06 Apr '10

This only affects builds without NUMA support. --- I just pushed this patch. src/nodeinfo.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/nodeinfo.c b/src/nodeinfo.c index 402a6b7..4d7fac1 100644 --- a/src/nodeinfo.c +++ b/src/nodeinfo.c @@ -450,7 +450,7 @@ int nodeCapsInitNUMA(virCapsPtr caps ATTRIBUTE_UNUSED) { return 0; } -int nodeGetCellsFreeMemory(virConnectPtr conn, +int nodeGetCellsFreeMemory(virConnectPtr conn ATTRIBUTE_UNUSED, unsigned long long *freeMems ATTRIBUTE_UNUSED, int startCell ATTRIBUTE_UNUSED, int maxCells ATTRIBUTE_UNUSED) @@ -460,7 +460,7 @@ int nodeGetCellsFreeMemory(virConnectPtr conn, return -1; } -unsigned long long nodeGetFreeMemory(virConnectPtr conn) +unsigned long long nodeGetFreeMemory(virConnectPtr conn ATTRIBUTE_UNUSED) { nodeReportError(VIR_ERR_NO_SUPPORT, "%s", _("NUMA memory information not available on this platform")); -- 1.6.3.3

1 0

[libvirt] Sys::Virt Perl bindings - calling newSVpv with unsafe length
by Richard W.M. Jones 06 Apr '10

06 Apr '10

Dan, After tracking down a very obscure bug in hivex & libguestfs Perl bindings, I started looking for places where we call newSVpv with a variable length argument that could be zero. In such cases, one should call newSVpvn instead, otherwise Perl will try to use strlen() to calculate the length of the data buffer when length is passed in as zero [I'm sure you are aware of this already]. There seems to be one such case in the Sys::Virt bindings: http://cpansearch.perl.org/src/DANBERR/Sys-Virt-0.2.3/Virt.xs CODE: if ((bytes = virSecretGetValue(sec, &len, flags)) == NULL) { _croak_error(virConnGetLastError(virSecretGetConnect(sec))); } RETVAL = newSVpv((char*)bytes, len); Maybe 'len' can never be zero here, but I think it's safer to turn this into a call to newSVpvn anyway. Also, if you look at the source to newSVpv: http://github.com/mirrors/perl/blob/blead/sv.c#L7752 You'll see there is an extra test, not present with newSVpvn. So it's better to always call newSVpvn wherever there is a constant-sized buffer, eg in code like this: if ((virDomainGetUUID(dom, rawuuid)) < 0) { _croak_error(virConnGetLastError(virDomainGetConnect(dom))); } RETVAL = newSVpv((char*)rawuuid, sizeof(rawuuid)); Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones New in Fedora 11: Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 70 libraries supprt'd http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw

2 1

[libvirt] [PATCH] [0/4] Managed save APIs version 2
by Daniel Veillard 06 Apr '10

06 Apr '10

Change w.r.t. version 1 is the saving path under /var/lib and not /var/run, the restore bug fix spotted by Laine and the various typo and improvement from Eric. As posted earlier, I have implemented the small set of managed save APIs, where libvirt stores the domain state itself and can then recover that state when the domain is started up. I think the code is complete, but not really tested (I still need to debug a failure which seems unrelated), with the exception of the virsh commands which probably need to be extended for convenience. Also I implemented it only for the qemu driver, I would not be surprized if an ESX backend could be implemented since there is no file path in this API. A command "virsh saveall" would be convenient, to be added later. More documentation is needed too. Thanks to Chris Lalancette who wrote a large part of this code ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

5 22

[libvirt] [PATCH] Fix compiler warning about non-literal format string
by Matthias Bolte 06 Apr '10

06 Apr '10

--- I just pushed this patch. src/security/security_apparmor.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/security/security_apparmor.c b/src/security/security_apparmor.c index db04d5c..8e1c794 100644 --- a/src/security/security_apparmor.c +++ b/src/security/security_apparmor.c @@ -483,7 +483,7 @@ AppArmorSetSecurityProcessLabel(virSecurityDriverPtr drv, virDomainObjPtr vm) } if (aa_change_profile(profile_name) < 0) { - virSecurityReportError(VIR_ERR_INTERNAL_ERROR, + virSecurityReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("error calling aa_change_profile()")); goto clean; } -- 1.6.3.3

1 0

[libvirt] Build fails on RHEL-5
by Chris Lalancette 06 Apr '10

06 Apr '10

Hey Stefan, When trying to build libvirt head on RHEL-5, I'm getting this error: gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../gnulib/lib -I../gnulib/lib -I../include -I../src/util -I../include -I/usr/include/libxml2 -DLIBDIR=\"/usr/local/lib\" -DBINDIR=\"/usr/local/libexec\" -DSBINDIR=\"/usr/local/sbin\" -DSYSCONF_DIR=\"/usr/local/etc\" -DLOCALEBASEDIR=\"/usr/local/share/locale\" -DPKGDATADIR=\"/usr/local/share/libvirt\" -DLOCAL_STATE_DIR=\"/usr/local/var\" -DGETTEXT_PACKAGE=\"libvirt\" -Wall -Wformat -Wformat-security -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wextra -Wshadow -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes -Winline -Wredundant-decls -Wno-sign-compare -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fasynchronous-unwind-tables -fdiagnostics-show-option -Werror -DIN_LIBVIRT -g -O2 -MT libvirt_conf_la-nwfilter_conf.lo -MD -MP -MF .deps/libvirt_conf_la-nwfilter_conf.Tpo -c conf/nwfilter_conf.c -fPIC -DPIC -o .libs/libvirt_conf_la-nwfilter_conf.o conf/nwfilter_conf.c:395: error: 'ETHERTYPE_IPV6' undeclared here (not in a function) make[3]: *** [libvirt_conf_la-nwfilter_conf.lo] Error 1 It seems that ETHERTYPE_IPV6 is not declared in /usr/include/net/ethernet.h in RHEL-5. We can probably get around this by adding (untested): #ifndef ETHERTYPE_IPV6 #define ETHERTYPE_IPV6 0x86dd #endif At the top of nwfilter_conf.c -- Chris Lalancette

2 2

[libvirt] [PATCH] Only parse 'CPU XML' in virCPUDefParseXML()
by Jim Fehlig 06 Apr '10

06 Apr '10

I received a report of user crashing libvirtd with virsh capabilities > capabilities.xml virsh cpu-compare capabilities.xml Breakpoint 1, x86ModelFind (map=0x6fb6f0, name=0x0) at cpu/cpu_x86.c:501 501 model = map->models; (gdb) bt #0 x86ModelFind (map=0x6fb6f0, name=0x0) at cpu/cpu_x86.c:501 #1 0x00007ffff70d0832 in x86ModelFromCPU (cpu=0x712070, map=0x6fb6f0, policy=1) at cpu/cpu_x86.c:541 #2 0x00007ffff70d12e9 in x86Compute (host=0x6ea610, cpu=0x712070, guest=0x0) at cpu/cpu_x86.c:822 #3 0x00007ffff70d1750 in x86Compare (host=0x6ea610, cpu=0x712070) at cpu/cpu_x86.c:927 #4 0x00007ffff70cf0c9 in cpuCompare (conn=0x6f69a0, host=0x6ea610, cpu=0x712070) at cpu/cpu.c:118 #5 0x00007ffff70ceff4 in cpuCompareXML (conn=0x6f69a0, host=0x6ea610, xml=0x6fa3e0 "<capabilities>\n\n <host>\n <cpu>\n <arch>x86_64</arch>\n <features>\n <pae/>\n </features>\n </cpu>\n <migration_features>\n <live/>\n <uri_transports>\n <uri_tra"...) at cpu/cpu.c:90 .. (gdb) n 503 if (STREQ(model->name, name)) (gdb) Program received signal SIGSEGV, Segmentation fault. 0x00007ffff4ff4960 in strcmp () from /lib64/libc.so.6 name, passed to x86ModelFind(), is NULL because virCPUDefParseXML() failed to parse anything meaningful from the "malformed" CPU XML. I waffled for quite a while on how to fix this and in the end decided to ensure the CPU XML passed to virCPUDefParseXML() does in fact contain an element named 'cpu'. AFAICT, all consumers of virCPUDefParseXML() pass an xmlNodePtr rooted at 'cpu' element. NB: I will be offline until Monday so if this patch is satisfactory please include it for 0.7.8/0.8.0 release :-). Otherwise I'll respin with suggested changes next week. Thanks! Jim

2 3

[libvirt] .so version number question
by Eric Blake 06 Apr '10

06 Apr '10

On IRC, Chris raised the question on what version number we should be using for libvirt.so. The libtool manual has an entire chapter on the matter: http://www.gnu.org/software/libtool/manual/libtool.html#Release-numbers In particular, it states that if you are using the -version-info flag to libtool (which our src/Makefile.am currently does), then you are promising to abide by the libtool versioning rules, where the .so version is treated as current:revision:age (and not major.minor.micro). In fact, libtool goes so far as to state that "Never try to set the interface numbers so that they correspond to the release number of your package. This is an abuse that only fosters misunderstanding of the purpose of library versions. Instead, use the -release flag (see Release numbers), but be warned that every release of your package will not be binary compatible with any other release." Should we be using -release instead of -version-info? Or should we continue using -version-info, but follow the advice of divorcing the .so version number from the release number? For example, according to the libtool rules, if the two version numbers are independent, then going from libtool 0.7.7 to 0.8.0 (that is, a minor version number bump in terms of packaging numbering), should go from libvirt.so.0:7:7 (we are at API version 0, with seven revisions of the code implementing that API, and are compatible back to -7:0:0, which is nonsense, so it effectively works out that we are compatible back to 0:0:0) to libvirt.so.1:0:1 (we added API, this is the first implementation of that new API, and we are compatible back to 0.x.x). Going by the libtool rules means that the c.r.a field will increment 'c' rather frequently (basically, every time we add an API!), but as long as 'a' increments just as frequently, then we are not making any backwards incompatible changes. But if you don't like that, the we should be going by the -release flag to libtool, where the .so numbering matches the libvirt release numbering. On the other hand, libtool states that using the -release flag means that anyone that uses libtool to link against libvirt.so is treated as being an incompatible change (basically, even though we are striving hard to maintain backwards compatibility, libtool can't exploit that). Again from the manual, "Note that this option causes a modification of the library name, so do not use it unless you want to break binary compatibility with any past library releases. In general, you should only use -release for package-internal libraries or for ones whose interfaces change very frequently." Libvirt's interface changes frequently, but libvirt.so is not a package-internal library so I don't think that -release is the way to go. Should I try to prepare a patch to start making better use of the -version-info libtool flag according to the libtool rules? And if so, is everyone okay with just punting on this issue until after 0.8.0 is out the door? -- Eric Blake eblake(a)redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org

1 0

[libvirt] clarified syntax-check error message
by Dave Allan 06 Apr '10

06 Apr '10

I pushed the attached trivial patch after noticing that I had a tab in one of my RNG schemas and that the error message was not quite right in that case. Dave

1 0

[libvirt] [PATCH Java] Add finalize to automatically free libvirt objects
by Matthias Bolte 05 Apr '10

05 Apr '10

The Connect and Network classes already had finalize, add it to all other classes that wrap libvirt objects to unify the behavior. --- src/main/java/org/libvirt/Device.java | 5 +++++ src/main/java/org/libvirt/Domain.java | 5 +++++ src/main/java/org/libvirt/Interface.java | 5 +++++ src/main/java/org/libvirt/Network.java | 1 + src/main/java/org/libvirt/StoragePool.java | 5 +++++ src/main/java/org/libvirt/StorageVol.java | 5 +++++ 6 files changed, 26 insertions(+), 0 deletions(-) diff --git a/src/main/java/org/libvirt/Device.java b/src/main/java/org/libvirt/Device.java index b4f9a0c..5329be5 100644 --- a/src/main/java/org/libvirt/Device.java +++ b/src/main/java/org/libvirt/Device.java @@ -132,6 +132,11 @@ public class Device { return desc; } + @Override + public void finalize() throws LibvirtException { + free(); + } + /** * Frees this device object. The running instance is kept alive. The data * structure is freed and should not be used thereafter. diff --git a/src/main/java/org/libvirt/Domain.java b/src/main/java/org/libvirt/Domain.java index e7b24ef..a80800c 100644 --- a/src/main/java/org/libvirt/Domain.java +++ b/src/main/java/org/libvirt/Domain.java @@ -162,6 +162,11 @@ public class Domain { processError(); } + @Override + public void finalize() throws LibvirtException { + free(); + } + /** * Frees this domain object. The running instance is kept alive. The data * structure is freed and should not be used thereafter. diff --git a/src/main/java/org/libvirt/Interface.java b/src/main/java/org/libvirt/Interface.java index 44bcad5..8b97925 100644 --- a/src/main/java/org/libvirt/Interface.java +++ b/src/main/java/org/libvirt/Interface.java @@ -112,6 +112,11 @@ public class Interface { return returnValue; } + @Override + public void finalize() throws LibvirtException { + free(); + } + /** * Frees this interface object. The running instance is kept alive. The data * structure is freed and should not be used thereafter. diff --git a/src/main/java/org/libvirt/Network.java b/src/main/java/org/libvirt/Network.java index 3c6f313..63b1f12 100644 --- a/src/main/java/org/libvirt/Network.java +++ b/src/main/java/org/libvirt/Network.java @@ -64,6 +64,7 @@ public class Network { processError(); } + @Override public void finalize() throws LibvirtException { free(); } diff --git a/src/main/java/org/libvirt/StoragePool.java b/src/main/java/org/libvirt/StoragePool.java index 7de7d50..54468bd 100644 --- a/src/main/java/org/libvirt/StoragePool.java +++ b/src/main/java/org/libvirt/StoragePool.java @@ -115,6 +115,11 @@ public class StoragePool { processError(); } + @Override + public void finalize() throws LibvirtException { + free(); + } + /** * Free a storage pool object, releasing all memory associated with it. Does * not change the state of the pool on the host. diff --git a/src/main/java/org/libvirt/StorageVol.java b/src/main/java/org/libvirt/StorageVol.java index 5ae5f5c..c5a3717 100644 --- a/src/main/java/org/libvirt/StorageVol.java +++ b/src/main/java/org/libvirt/StorageVol.java @@ -75,6 +75,11 @@ public class StorageVol { processError(); } + @Override + public void finalize() throws LibvirtException { + free(); + } + /** * Release the storage volume handle. The underlying storage volume contains * to exist -- 1.6.3.3

3 4

[libvirt] [PATCH] nwfilter: remove virConnectPtr conn from functions where it is not necessary
by Stefan Berger 05 Apr '10

05 Apr '10

This patch removes the virConnectPtr parameter from all functions where it's not necessary starting out with removing it as a parameter to the error reporting function. Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com> --- src/conf/nwfilter_conf.c | 154 ++---- src/conf/nwfilter_conf.h | 24 src/conf/nwfilter_params.c | 7 src/conf/nwfilter_params.h | 3 src/nwfilter/nwfilter_driver.c | 24 src/nwfilter/nwfilter_ebiptables_driver.c | 760 ++++++++++++------------------ src/nwfilter/nwfilter_gentech_driver.c | 51 -- src/nwfilter/nwfilter_gentech_driver.h | 6 tests/nwfilterxml2xmltest.c | 2 9 files changed, 423 insertions(+), 608 deletions(-) Index: libvirt-acl/src/conf/nwfilter_conf.h =================================================================== --- libvirt-acl.orig/src/conf/nwfilter_conf.h +++ libvirt-acl/src/conf/nwfilter_conf.h @@ -518,13 +518,11 @@ virNWFilterPoolObjPtr const char *name); -int virNWFilterPoolObjSaveDef(virConnectPtr conn, - virNWFilterDriverStatePtr driver, +int virNWFilterPoolObjSaveDef(virNWFilterDriverStatePtr driver, virNWFilterPoolObjPtr pool, virNWFilterDefPtr def); -int virNWFilterPoolObjDeleteDef(virConnectPtr conn, - virNWFilterPoolObjPtr pool); +int virNWFilterPoolObjDeleteDef(virNWFilterPoolObjPtr pool); virNWFilterPoolObjPtr virNWFilterPoolObjAssignDef(virConnectPtr conn, virNWFilterPoolObjListPtr pools, @@ -533,28 +531,23 @@ virNWFilterPoolObjPtr virNWFilterPoolObj int virNWFilterTestUnassignDef(virConnectPtr conn, virNWFilterPoolObjPtr pool); -virNWFilterDefPtr virNWFilterDefParseNode(virConnectPtr conn, - xmlDocPtr xml, +virNWFilterDefPtr virNWFilterDefParseNode(xmlDocPtr xml, xmlNodePtr root); -char *virNWFilterDefFormat(virConnectPtr conn, - virNWFilterDefPtr def); +char *virNWFilterDefFormat(virNWFilterDefPtr def); -int virNWFilterSaveXML(virConnectPtr conn, - const char *configDir, +int virNWFilterSaveXML(const char *configDir, virNWFilterDefPtr def, const char *xml); -int virNWFilterSaveConfig(virConnectPtr conn, - const char *configDir, +int virNWFilterSaveConfig(const char *configDir, virNWFilterDefPtr def); int virNWFilterPoolLoadAllConfigs(virConnectPtr conn, virNWFilterPoolObjListPtr pools, const char *configDir); -char *virNWFilterConfigFile(virConnectPtr conn, - const char *dir, +char *virNWFilterConfigFile(const char *dir, const char *name); virNWFilterDefPtr virNWFilterDefParseString(virConnectPtr conn, @@ -568,8 +561,7 @@ void virNWFilterPoolObjUnlock(virNWFilte int virNWFilterConfLayerInit(virHashIterator domUpdateCB); void virNWFilterConfLayerShutdown(void); -# define virNWFilterReportError(conn, code, fmt...) \ - (void)conn; \ +# define virNWFilterReportError(code, fmt...) \ virReportErrorHelper(NULL, VIR_FROM_NWFILTER, code, __FILE__, \ __FUNCTION__, __LINE__, fmt) Index: libvirt-acl/src/conf/nwfilter_conf.c =================================================================== --- libvirt-acl.orig/src/conf/nwfilter_conf.c +++ libvirt-acl/src/conf/nwfilter_conf.c @@ -310,8 +310,7 @@ virNWFilterPoolObjListFree(virNWFilterPo static int -virNWFilterRuleDefAddVar(virConnectPtr conn ATTRIBUTE_UNUSED, - virNWFilterRuleDefPtr nwf, +virNWFilterRuleDefAddVar(virNWFilterRuleDefPtr nwf, nwItemDesc *item, const char *var) { @@ -1112,8 +1111,7 @@ virNWIPv6AddressParser(const char *input static int -virNWFilterRuleDetailsParse(virConnectPtr conn ATTRIBUTE_UNUSED, - xmlNodePtr node, +virNWFilterRuleDetailsParse(xmlNodePtr node, virNWFilterRuleDefPtr nwf, const virXMLAttr2Struct *att) { @@ -1152,8 +1150,7 @@ virNWFilterRuleDetailsParse(virConnectPt flags_set |= NWFILTER_ENTRY_ITEM_FLAG_HAS_VAR; storage_ptr = NULL; - if (virNWFilterRuleDefAddVar(conn, - nwf, + if (virNWFilterRuleDefAddVar(nwf, item, &prop[1])) rc = -1; @@ -1325,7 +1322,7 @@ virNWFilterRuleDetailsParse(virConnectPt } if (!found || rc) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, _("%s has illegal value %s"), att[idx].name, prop); rc = -1; @@ -1348,8 +1345,7 @@ virNWFilterRuleDetailsParse(virConnectPt static virNWFilterIncludeDefPtr -virNWFilterIncludeParse(virConnectPtr conn, - xmlNodePtr cur) +virNWFilterIncludeParse(xmlNodePtr cur) { virNWFilterIncludeDefPtr ret; @@ -1360,7 +1356,7 @@ virNWFilterIncludeParse(virConnectPtr co ret->filterref = virXMLPropString(cur, "filter"); if (!ret->filterref) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("rule node requires action attribute")); goto err_exit; @@ -1548,8 +1544,7 @@ virNWFilterRuleDefFixup(virNWFilterRuleD static virNWFilterRuleDefPtr -virNWFilterRuleParse(virConnectPtr conn, - xmlNodePtr node) +virNWFilterRuleParse(xmlNodePtr node) { char *action; char *direction; @@ -1571,28 +1566,28 @@ virNWFilterRuleParse(virConnectPtr conn, prio = virXMLPropString(node, "priority"); if (!action) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("rule node requires action attribute")); goto err_exit; } if ((ret->action = virNWFilterRuleActionTypeFromString(action)) < 0) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("unknown rule action attribute value")); goto err_exit; } if (!direction) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("rule node requires direction attribute")); goto err_exit; } if ((ret->tt = virNWFilterRuleDirectionTypeFromString(direction)) < 0) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("unknown rule direction attribute value")); goto err_exit; @@ -1624,8 +1619,7 @@ virNWFilterRuleParse(virConnectPtr conn, found = 1; ret->prtclType = virAttr[i].prtclType; - if (virNWFilterRuleDetailsParse(conn, - cur, + if (virNWFilterRuleDetailsParse(cur, ret, virAttr[i].att) < 0) { /* we ignore malformed rules @@ -1663,8 +1657,7 @@ err_exit: static virNWFilterDefPtr -virNWFilterDefParseXML(virConnectPtr conn, - xmlXPathContextPtr ctxt) { +virNWFilterDefParseXML(xmlXPathContextPtr ctxt) { virNWFilterDefPtr ret; xmlNodePtr curr = ctxt->node; char *uuid = NULL; @@ -1678,7 +1671,7 @@ virNWFilterDefParseXML(virConnectPtr con ret->name = virXPathString("string(./@name)", ctxt); if (!ret->name) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("filter has no name")); goto cleanup; } @@ -1688,7 +1681,7 @@ virNWFilterDefParseXML(virConnectPtr con if (chain) { if ((ret->chainsuffix = virNWFilterChainSuffixTypeFromString(chain)) < 0) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, _("unknown chain suffix '%s'"), chain); goto cleanup; } @@ -1697,13 +1690,13 @@ virNWFilterDefParseXML(virConnectPtr con uuid = virXPathString("string(./uuid)", ctxt); if (uuid == NULL) { if (virUUIDGenerate(ret->uuid) < 0) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("unable to generate uuid")); goto cleanup; } } else { if (virUUIDParse(uuid, ret->uuid) < 0) { - virNWFilterReportError(conn, VIR_ERR_XML_ERROR, + virNWFilterReportError(VIR_ERR_XML_ERROR, "%s", _("malformed uuid element")); goto cleanup; } @@ -1721,9 +1714,9 @@ virNWFilterDefParseXML(virConnectPtr con /* ignore malformed rule and include elements */ if (xmlStrEqual(curr->name, BAD_CAST "rule")) - entry->rule = virNWFilterRuleParse(conn, curr); + entry->rule = virNWFilterRuleParse(curr); else if (xmlStrEqual(curr->name, BAD_CAST "filterref")) - entry->include = virNWFilterIncludeParse(conn, curr); + entry->include = virNWFilterIncludeParse(curr); if (entry->rule || entry->include) { if (VIR_REALLOC_N(ret->filterEntries, ret->nentries+1) < 0) { @@ -1762,7 +1755,7 @@ catchXMLError (void *ctx, const char *ms conn->err.code == VIR_ERR_NONE && ctxt->lastError.level == XML_ERR_FATAL && ctxt->lastError.message != NULL) { - virNWFilterReportError(conn, VIR_ERR_XML_DETAIL, + virNWFilterReportError(VIR_ERR_XML_DETAIL, _("at line %d: %s"), ctxt->lastError.line, ctxt->lastError.message); @@ -1772,14 +1765,13 @@ catchXMLError (void *ctx, const char *ms virNWFilterDefPtr -virNWFilterDefParseNode(virConnectPtr conn, - xmlDocPtr xml, +virNWFilterDefParseNode(xmlDocPtr xml, xmlNodePtr root) { xmlXPathContextPtr ctxt = NULL; virNWFilterDefPtr def = NULL; if (STRNEQ((const char *)root->name, "filter")) { - virNWFilterReportError(conn, VIR_ERR_XML_ERROR, + virNWFilterReportError(VIR_ERR_XML_ERROR, "%s", _("unknown root element for nw filter pool")); goto cleanup; @@ -1792,7 +1784,7 @@ virNWFilterDefParseNode(virConnectPtr co } ctxt->node = root; - def = virNWFilterDefParseXML(conn, ctxt); + def = virNWFilterDefParseXML(ctxt); cleanup: xmlXPathFreeContext(ctxt); @@ -1802,8 +1794,8 @@ cleanup: static virNWFilterDefPtr virNWFilterDefParse(virConnectPtr conn, - const char *xmlStr, - const char *filename) { + const char *xmlStr, + const char *filename) { virNWFilterDefPtr ret = NULL; xmlParserCtxtPtr pctxt; xmlDocPtr xml = NULL; @@ -1830,19 +1822,19 @@ virNWFilterDefParse(virConnectPtr conn, if (!xml) { if (conn && conn->err.code == VIR_ERR_NONE) - virNWFilterReportError(conn, VIR_ERR_XML_ERROR, + virNWFilterReportError(VIR_ERR_XML_ERROR, "%s",_("failed to parse xml document")); goto cleanup; } node = xmlDocGetRootElement(xml); if (node == NULL) { - virNWFilterReportError(conn, VIR_ERR_XML_ERROR, + virNWFilterReportError(VIR_ERR_XML_ERROR, "%s", _("missing root element")); goto cleanup; } - ret = virNWFilterDefParseNode(conn, xml, node); + ret = virNWFilterDefParseNode(xml, node); xmlFreeParserCtxt (pctxt); xmlFreeDoc(xml); @@ -1858,7 +1850,7 @@ virNWFilterDefParse(virConnectPtr conn, virNWFilterDefPtr virNWFilterDefParseString(virConnectPtr conn, - const char *xmlStr) + const char *xmlStr) { return virNWFilterDefParse(conn, xmlStr, NULL); } @@ -1874,7 +1866,7 @@ virNWFilterDefParseFile(virConnectPtr co virNWFilterPoolObjPtr virNWFilterPoolObjFindByUUID(virNWFilterPoolObjListPtr pools, - const unsigned char *uuid) + const unsigned char *uuid) { unsigned int i; @@ -1891,7 +1883,7 @@ virNWFilterPoolObjFindByUUID(virNWFilter virNWFilterPoolObjPtr virNWFilterPoolObjFindByName(virNWFilterPoolObjListPtr pools, - const char *name) + const char *name) { unsigned int i; @@ -1906,8 +1898,7 @@ virNWFilterPoolObjFindByName(virNWFilter } -int virNWFilterSaveXML(virConnectPtr conn, - const char *configDir, +int virNWFilterSaveXML(const char *configDir, virNWFilterDefPtr def, const char *xml) { @@ -1916,7 +1907,7 @@ int virNWFilterSaveXML(virConnectPtr con size_t towrite; int err; - if ((configFile = virNWFilterConfigFile(conn, configDir, def->name)) == NULL) + if ((configFile = virNWFilterConfigFile(configDir, def->name)) == NULL) goto cleanup; if ((err = virFileMakePath(configDir))) { @@ -1962,17 +1953,16 @@ int virNWFilterSaveXML(virConnectPtr con } -int virNWFilterSaveConfig(virConnectPtr conn, - const char *configDir, +int virNWFilterSaveConfig(const char *configDir, virNWFilterDefPtr def) { int ret = -1; char *xml; - if (!(xml = virNWFilterDefFormat(conn, def))) + if (!(xml = virNWFilterDefFormat(def))) goto cleanup; - if (virNWFilterSaveXML(conn, configDir, def, xml)) + if (virNWFilterSaveXML(configDir, def, xml)) goto cleanup; ret = 0; @@ -2119,13 +2109,13 @@ virNWFilterTestUnassignDef(virConnectPtr virNWFilterPoolObjPtr virNWFilterPoolObjAssignDef(virConnectPtr conn, - virNWFilterPoolObjListPtr pools, - virNWFilterDefPtr def) + virNWFilterPoolObjListPtr pools, + virNWFilterDefPtr def) { virNWFilterPoolObjPtr pool; if (virNWFilterDefLoopDetect(conn, pools, def)) { - virNWFilterReportError(conn, VIR_ERR_INVALID_NWFILTER, + virNWFilterReportError(VIR_ERR_INVALID_NWFILTER, "%s", _("filter would introduce a loop")); return NULL; } @@ -2154,7 +2144,7 @@ virNWFilterPoolObjAssignDef(virConnectPt } if (virMutexInitRecursive(&pool->lock) < 0) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("cannot initialize mutex")); VIR_FREE(pool); return NULL; @@ -2178,9 +2168,9 @@ virNWFilterPoolObjAssignDef(virConnectPt static virNWFilterPoolObjPtr virNWFilterPoolObjLoad(virConnectPtr conn, - virNWFilterPoolObjListPtr pools, - const char *file, - const char *path) + virNWFilterPoolObjListPtr pools, + const char *file, + const char *path) { virNWFilterDefPtr def; virNWFilterPoolObjPtr pool; @@ -2190,7 +2180,7 @@ virNWFilterPoolObjLoad(virConnectPtr con } if (!virFileMatchesNameSuffix(file, def->name, ".xml")) { - virNWFilterReportError(conn, VIR_ERR_INVALID_NWFILTER, + virNWFilterReportError(VIR_ERR_INVALID_NWFILTER, _("network filter pool config filename '%s' does not match pool name '%s'"), path, def->name); virNWFilterDefFree(def); @@ -2215,8 +2205,8 @@ virNWFilterPoolObjLoad(virConnectPtr con int virNWFilterPoolLoadAllConfigs(virConnectPtr conn, - virNWFilterPoolObjListPtr pools, - const char *configDir) + virNWFilterPoolObjListPtr pools, + const char *configDir) { DIR *dir; struct dirent *entry; @@ -2242,7 +2232,7 @@ virNWFilterPoolLoadAllConfigs(virConnect if (virFileBuildPath(configDir, entry->d_name, NULL, path, PATH_MAX) < 0) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, _("config filename '%s/%s' is too long"), configDir, entry->d_name); continue; @@ -2260,10 +2250,9 @@ virNWFilterPoolLoadAllConfigs(virConnect int -virNWFilterPoolObjSaveDef(virConnectPtr conn, - virNWFilterDriverStatePtr driver, - virNWFilterPoolObjPtr pool, - virNWFilterDefPtr def) +virNWFilterPoolObjSaveDef(virNWFilterDriverStatePtr driver, + virNWFilterPoolObjPtr pool, + virNWFilterDefPtr def) { char *xml; int fd = -1, ret = -1; @@ -2282,7 +2271,7 @@ virNWFilterPoolObjSaveDef(virConnectPtr if (virFileBuildPath(driver->configDir, def->name, ".xml", path, sizeof(path)) < 0) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("cannot construct config file path")); return -1; } @@ -2292,8 +2281,8 @@ virNWFilterPoolObjSaveDef(virConnectPtr } } - if (!(xml = virNWFilterDefFormat(conn, def))) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + if (!(xml = virNWFilterDefFormat(def))) { + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("failed to generate XML")); return -1; } @@ -2335,19 +2324,18 @@ virNWFilterPoolObjSaveDef(virConnectPtr int -virNWFilterPoolObjDeleteDef(virConnectPtr conn, - virNWFilterPoolObjPtr pool) +virNWFilterPoolObjDeleteDef(virNWFilterPoolObjPtr pool) { if (!pool->configFile) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, - _("no config file for %s"), pool->def->name); + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, + _("no config file for %s"), pool->def->name); return -1; } if (unlink(pool->configFile) < 0) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, - _("cannot remove config for %s"), - pool->def->name); + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, + _("cannot remove config for %s"), + pool->def->name); return -1; } @@ -2369,8 +2357,7 @@ virNWIPAddressFormat(virBufferPtr buf, n static void -virNWFilterRuleDefDetailsFormat(virConnectPtr conn, - virBufferPtr buf, +virNWFilterRuleDefDetailsFormat(virBufferPtr buf, const char *type, const virXMLAttr2Struct *att, virNWFilterRuleDefPtr def) @@ -2420,7 +2407,7 @@ virNWFilterRuleDefDetailsFormat(virConne att[i].name); if (att[i].formatter) { if (!att[i].formatter(buf, def)) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, _("formatter for %s %s reported error"), type, att[i].name); @@ -2484,8 +2471,7 @@ err_exit: static char * -virNWFilterRuleDefFormat(virConnectPtr conn, - virNWFilterRuleDefPtr def) +virNWFilterRuleDefFormat(virNWFilterRuleDefPtr def) { int i; virBuffer buf = VIR_BUFFER_INITIALIZER; @@ -2500,8 +2486,7 @@ virNWFilterRuleDefFormat(virConnectPtr c i = 0; while (virAttr[i].id) { if (virAttr[i].prtclType == def->prtclType) { - virNWFilterRuleDefDetailsFormat(conn, - &buf2, + virNWFilterRuleDefDetailsFormat(&buf2, virAttr[i].id, virAttr[i].att, def); @@ -2563,18 +2548,16 @@ virNWFilterIncludeDefFormat(virNWFilterI static char * -virNWFilterEntryFormat(virConnectPtr conn, - virNWFilterEntryPtr entry) +virNWFilterEntryFormat(virNWFilterEntryPtr entry) { if (entry->rule) - return virNWFilterRuleDefFormat(conn, entry->rule); + return virNWFilterRuleDefFormat(entry->rule); return virNWFilterIncludeDefFormat(entry->include); } char * -virNWFilterDefFormat(virConnectPtr conn, - virNWFilterDefPtr def) +virNWFilterDefFormat(virNWFilterDefPtr def) { virBuffer buf = VIR_BUFFER_INITIALIZER; char uuid[VIR_UUID_STRING_BUFLEN]; @@ -2590,7 +2573,7 @@ virNWFilterDefFormat(virConnectPtr conn, virBufferVSprintf(&buf," <uuid>%s</uuid>\n", uuid); for (i = 0; i < def->nentries; i++) { - xml = virNWFilterEntryFormat(conn, def->filterEntries[i]); + xml = virNWFilterEntryFormat(def->filterEntries[i]); if (!xml) goto err_exit; virBufferVSprintf(&buf, "%s", xml); @@ -2613,8 +2596,7 @@ virNWFilterDefFormat(virConnectPtr conn, } -char *virNWFilterConfigFile(virConnectPtr conn ATTRIBUTE_UNUSED, - const char *dir, +char *virNWFilterConfigFile(const char *dir, const char *name) { char *ret = NULL; Index: libvirt-acl/src/nwfilter/nwfilter_driver.c =================================================================== --- libvirt-acl.orig/src/nwfilter/nwfilter_driver.c +++ libvirt-acl/src/nwfilter/nwfilter_driver.c @@ -194,8 +194,8 @@ nwfilterLookupByUUID(virConnectPtr conn, nwfilterDriverUnlock(driver); if (!pool) { - virNWFilterReportError(conn, VIR_ERR_NO_NWFILTER, - "%s", _("no pool with matching uuid")); + virNWFilterReportError(VIR_ERR_NO_NWFILTER, + "%s", _("no pool with matching uuid")); goto cleanup; } @@ -220,8 +220,8 @@ nwfilterLookupByName(virConnectPtr conn, nwfilterDriverUnlock(driver); if (!pool) { - virNWFilterReportError(conn, VIR_ERR_NO_NWFILTER, - _("no pool with matching name '%s'"), name); + virNWFilterReportError(VIR_ERR_NO_NWFILTER, + _("no pool with matching name '%s'"), name); goto cleanup; } @@ -306,7 +306,7 @@ nwfilterDefine(virConnectPtr conn, if (!(pool = virNWFilterPoolObjAssignDef(conn, &driver->pools, def))) goto cleanup; - if (virNWFilterPoolObjSaveDef(conn, driver, pool, def) < 0) { + if (virNWFilterPoolObjSaveDef(driver, pool, def) < 0) { virNWFilterPoolObjRemove(&driver->pools, pool); def = NULL; goto cleanup; @@ -333,19 +333,19 @@ nwfilterUndefine(virNWFilterPtr obj) { nwfilterDriverLock(driver); pool = virNWFilterPoolObjFindByUUID(&driver->pools, obj->uuid); if (!pool) { - virNWFilterReportError(obj->conn, VIR_ERR_INVALID_NWFILTER, - "%s", _("no nwfilter pool with matching uuid")); + virNWFilterReportError(VIR_ERR_INVALID_NWFILTER, + "%s", _("no nwfilter pool with matching uuid")); goto cleanup; } if (virNWFilterTestUnassignDef(obj->conn, pool)) { - virNWFilterReportError(obj->conn, VIR_ERR_INVALID_NWFILTER, + virNWFilterReportError(VIR_ERR_INVALID_NWFILTER, "%s", _("nwfilter is in use")); goto cleanup; } - if (virNWFilterPoolObjDeleteDef(obj->conn, pool) < 0) + if (virNWFilterPoolObjDeleteDef(pool) < 0) goto cleanup; VIR_FREE(pool->configFile); @@ -374,12 +374,12 @@ nwfilterDumpXML(virNWFilterPtr obj, nwfilterDriverUnlock(driver); if (!pool) { - virNWFilterReportError(obj->conn, VIR_ERR_INVALID_NWFILTER, - "%s", _("no nwfilter pool with matching uuid")); + virNWFilterReportError(VIR_ERR_INVALID_NWFILTER, + "%s", _("no nwfilter pool with matching uuid")); goto cleanup; } - ret = virNWFilterDefFormat(obj->conn, pool->def); + ret = virNWFilterDefFormat(pool->def); cleanup: if (pool) Index: libvirt-acl/src/nwfilter/nwfilter_ebiptables_driver.c =================================================================== --- libvirt-acl.orig/src/nwfilter/nwfilter_ebiptables_driver.c +++ libvirt-acl/src/nwfilter/nwfilter_ebiptables_driver.c @@ -106,8 +106,7 @@ static const char *supported_protocols[] static int -printVar(virConnectPtr conn, - virNWFilterHashTablePtr vars, +printVar(virNWFilterHashTablePtr vars, char *buf, int bufsize, nwItemDescPtr item, int *done) @@ -117,14 +116,14 @@ printVar(virConnectPtr conn, if ((item->flags & NWFILTER_ENTRY_ITEM_FLAG_HAS_VAR)) { char *val = (char *)virHashLookup(vars->hashTable, item->var); if (!val) { - virNWFilterReportError(conn, VIR_ERR_INVALID_NWFILTER, + virNWFilterReportError(VIR_ERR_INVALID_NWFILTER, _("cannot find value for '%s'"), item->var); return 1; } if (!virStrcpy(buf, val, bufsize)) { - virNWFilterReportError(conn, VIR_ERR_INVALID_NWFILTER, + virNWFilterReportError(VIR_ERR_INVALID_NWFILTER, _("Buffer to small to print MAC address " "'%s' into"), item->var); @@ -138,8 +137,7 @@ printVar(virConnectPtr conn, static int -_printDataType(virConnectPtr conn, - virNWFilterHashTablePtr vars, +_printDataType(virNWFilterHashTablePtr vars, char *buf, int bufsize, nwItemDescPtr item, bool asHex) @@ -147,7 +145,7 @@ _printDataType(virConnectPtr conn, int done; char *data; - if (printVar(conn, vars, buf, bufsize, item, &done)) + if (printVar(vars, buf, bufsize, item, &done)) return 1; if (done) @@ -157,13 +155,13 @@ _printDataType(virConnectPtr conn, case DATATYPE_IPADDR: data = virSocketFormatAddr(&item->u.ipaddr.addr); if (!data) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, "%s", + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("internal IPv4 address representation " "is bad")); return 1; } if (snprintf(buf, bufsize, "%s", data) >= bufsize) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, "%s", + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("buffer too small for IP address")); VIR_FREE(data); return 1; @@ -174,14 +172,14 @@ _printDataType(virConnectPtr conn, case DATATYPE_IPV6ADDR: data = virSocketFormatAddr(&item->u.ipaddr.addr); if (!data) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, "%s", + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("internal IPv6 address representation " "is bad")); return 1; } if (snprintf(buf, bufsize, "%s", data) >= bufsize) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, "%s", + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("buffer too small for IPv6 address")); VIR_FREE(data); return 1; @@ -192,7 +190,7 @@ _printDataType(virConnectPtr conn, case DATATYPE_MACADDR: case DATATYPE_MACMASK: if (bufsize < VIR_MAC_STRING_BUFLEN) { - virNWFilterReportError(conn, VIR_ERR_INVALID_NWFILTER, "%s", + virNWFilterReportError(VIR_ERR_INVALID_NWFILTER, "%s", _("Buffer too small for MAC address")); return 1; } @@ -204,7 +202,7 @@ _printDataType(virConnectPtr conn, case DATATYPE_IPMASK: if (snprintf(buf, bufsize, "%d", item->u.u8) >= bufsize) { - virNWFilterReportError(conn, VIR_ERR_INVALID_NWFILTER, + virNWFilterReportError(VIR_ERR_INVALID_NWFILTER, _("Buffer too small for uint8 type")); return 1; } @@ -213,7 +211,7 @@ _printDataType(virConnectPtr conn, case DATATYPE_UINT16: if (snprintf(buf, bufsize, asHex ? "0x%x" : "%d", item->u.u16) >= bufsize) { - virNWFilterReportError(conn, VIR_ERR_INVALID_NWFILTER, "%s", + virNWFilterReportError(VIR_ERR_INVALID_NWFILTER, "%s", _("Buffer too small for uint16 type")); return 1; } @@ -222,14 +220,14 @@ _printDataType(virConnectPtr conn, case DATATYPE_UINT8: if (snprintf(buf, bufsize, asHex ? "0x%x" : "%d", item->u.u8) >= bufsize) { - virNWFilterReportError(conn, VIR_ERR_INVALID_NWFILTER, "%s", + virNWFilterReportError(VIR_ERR_INVALID_NWFILTER, "%s", _("Buffer too small for uint8 type")); return 1; } break; default: - virNWFilterReportError(conn, VIR_ERR_INVALID_NWFILTER, + virNWFilterReportError(VIR_ERR_INVALID_NWFILTER, _("Unhandled datatype %x"), item->datatype); return 1; break; @@ -240,22 +238,20 @@ _printDataType(virConnectPtr conn, static int -printDataType(virConnectPtr conn, - virNWFilterHashTablePtr vars, +printDataType(virNWFilterHashTablePtr vars, char *buf, int bufsize, nwItemDescPtr item) { - return _printDataType(conn, vars, buf, bufsize, item, 0); + return _printDataType(vars, buf, bufsize, item, 0); } static int -printDataTypeAsHex(virConnectPtr conn, - virNWFilterHashTablePtr vars, +printDataTypeAsHex(virNWFilterHashTablePtr vars, char *buf, int bufsize, nwItemDescPtr item) { - return _printDataType(conn, vars, buf, bufsize, item, 1); + return _printDataType(vars, buf, bufsize, item, 1); } @@ -271,8 +267,7 @@ ebiptablesRuleInstFree(ebiptablesRuleIns static int -ebiptablesAddRuleInst(virConnectPtr conn, - virNWFilterRuleInstPtr res, +ebiptablesAddRuleInst(virNWFilterRuleInstPtr res, char *commandTemplate, enum virNWFilterChainSuffixType neededChain, char chainprefix, @@ -292,21 +287,19 @@ ebiptablesAddRuleInst(virConnectPtr conn inst->priority = priority; inst->ruleType = ruleType; - return virNWFilterRuleInstAddData(conn, res, inst); + return virNWFilterRuleInstAddData(res, inst); } static int -ebtablesHandleEthHdr(virConnectPtr conn, - virBufferPtr buf, +ebtablesHandleEthHdr(virBufferPtr buf, virNWFilterHashTablePtr vars, ethHdrDataDefPtr ethHdr) { char macaddr[VIR_MAC_STRING_BUFLEN]; if (HAS_ENTRY_ITEM(&ethHdr->dataSrcMACAddr)) { - if (printDataType(conn, - vars, + if (printDataType(vars, macaddr, sizeof(macaddr), &ethHdr->dataSrcMACAddr)) goto err_exit; @@ -317,8 +310,7 @@ ebtablesHandleEthHdr(virConnectPtr conn, macaddr); if (HAS_ENTRY_ITEM(&ethHdr->dataSrcMACMask)) { - if (printDataType(conn, - vars, + if (printDataType(vars, macaddr, sizeof(macaddr), &ethHdr->dataSrcMACMask)) goto err_exit; @@ -330,8 +322,7 @@ ebtablesHandleEthHdr(virConnectPtr conn, } if (HAS_ENTRY_ITEM(&ethHdr->dataDstMACAddr)) { - if (printDataType(conn, - vars, + if (printDataType(vars, macaddr, sizeof(macaddr), &ethHdr->dataDstMACAddr)) goto err_exit; @@ -342,8 +333,7 @@ ebtablesHandleEthHdr(virConnectPtr conn, macaddr); if (HAS_ENTRY_ITEM(&ethHdr->dataDstMACMask)) { - if (printDataType(conn, - vars, + if (printDataType(vars, macaddr, sizeof(macaddr), &ethHdr->dataDstMACMask)) goto err_exit; @@ -365,8 +355,7 @@ ebtablesHandleEthHdr(virConnectPtr conn, /************************ iptables support ************************/ -static int iptablesLinkIPTablesBaseChain(virConnectPtr conn ATTRIBUTE_UNUSED, - const char *iptables_cmd, +static int iptablesLinkIPTablesBaseChain(const char *iptables_cmd, virBufferPtr buf, const char *udchain, const char *syschain, @@ -407,8 +396,7 @@ static int iptablesLinkIPTablesBaseChain } -static int iptablesCreateBaseChains(virConnectPtr conn, - const char *iptables_cmd, +static int iptablesCreateBaseChains(const char *iptables_cmd, virBufferPtr buf) { virBufferVSprintf(buf,"%s -N " VIRT_IN_CHAIN CMD_SEPARATOR @@ -419,13 +407,13 @@ static int iptablesCreateBaseChains(virC iptables_cmd, iptables_cmd, iptables_cmd); - iptablesLinkIPTablesBaseChain(conn, iptables_cmd, buf, + iptablesLinkIPTablesBaseChain(iptables_cmd, buf, VIRT_IN_CHAIN , "FORWARD", 1, 1); - iptablesLinkIPTablesBaseChain(conn, iptables_cmd, buf, + iptablesLinkIPTablesBaseChain(iptables_cmd, buf, VIRT_OUT_CHAIN , "FORWARD", 2, 1); - iptablesLinkIPTablesBaseChain(conn, iptables_cmd, buf, + iptablesLinkIPTablesBaseChain(iptables_cmd, buf, VIRT_IN_POST_CHAIN, "FORWARD", 3, 1); - iptablesLinkIPTablesBaseChain(conn, iptables_cmd, buf, + iptablesLinkIPTablesBaseChain(iptables_cmd, buf, HOST_IN_CHAIN , "INPUT" , 1, 1); return 0; @@ -433,8 +421,7 @@ static int iptablesCreateBaseChains(virC static int -iptablesCreateTmpRootChain(virConnectPtr conn ATTRIBUTE_UNUSED, - const char *iptables_cmd, +iptablesCreateTmpRootChain(const char *iptables_cmd, virBufferPtr buf, char prefix, int incoming, const char *ifname, @@ -462,21 +449,19 @@ iptablesCreateTmpRootChain(virConnectPtr static int -iptablesCreateTmpRootChains(virConnectPtr conn, - const char *iptables_cmd, +iptablesCreateTmpRootChains(const char *iptables_cmd, virBufferPtr buf, const char *ifname) { - iptablesCreateTmpRootChain(conn, iptables_cmd, buf, 'F', 0, ifname, 1); - iptablesCreateTmpRootChain(conn, iptables_cmd, buf, 'F', 1, ifname, 1); - iptablesCreateTmpRootChain(conn, iptables_cmd, buf, 'H', 1, ifname, 1); + iptablesCreateTmpRootChain(iptables_cmd, buf, 'F', 0, ifname, 1); + iptablesCreateTmpRootChain(iptables_cmd, buf, 'F', 1, ifname, 1); + iptablesCreateTmpRootChain(iptables_cmd, buf, 'H', 1, ifname, 1); return 0; } static int -_iptablesRemoveRootChain(virConnectPtr conn ATTRIBUTE_UNUSED, - const char *iptables_cmd, +_iptablesRemoveRootChain(const char *iptables_cmd, virBufferPtr buf, char prefix, int incoming, const char *ifname, @@ -507,60 +492,55 @@ _iptablesRemoveRootChain(virConnectPtr c static int -iptablesRemoveRootChain(virConnectPtr conn ATTRIBUTE_UNUSED, - const char *iptables_cmd, +iptablesRemoveRootChain(const char *iptables_cmd, virBufferPtr buf, char prefix, int incoming, const char *ifname) { - return _iptablesRemoveRootChain(conn, iptables_cmd, + return _iptablesRemoveRootChain(iptables_cmd, buf, prefix, incoming, ifname, 0); } static int -iptablesRemoveTmpRootChain(virConnectPtr conn ATTRIBUTE_UNUSED, - const char *iptables_cmd, +iptablesRemoveTmpRootChain(const char *iptables_cmd, virBufferPtr buf, char prefix, int incoming, const char *ifname) { - return _iptablesRemoveRootChain(conn, iptables_cmd, buf, prefix, + return _iptablesRemoveRootChain(iptables_cmd, buf, prefix, incoming, ifname, 1); } static int -iptablesRemoveTmpRootChains(virConnectPtr conn, - const char *iptables_cmd, +iptablesRemoveTmpRootChains(const char *iptables_cmd, virBufferPtr buf, const char *ifname) { - iptablesRemoveTmpRootChain(conn, iptables_cmd, buf, 'F', 0, ifname); - iptablesRemoveTmpRootChain(conn, iptables_cmd, buf, 'F', 1, ifname); - iptablesRemoveTmpRootChain(conn, iptables_cmd, buf, 'H', 1, ifname); + iptablesRemoveTmpRootChain(iptables_cmd, buf, 'F', 0, ifname); + iptablesRemoveTmpRootChain(iptables_cmd, buf, 'F', 1, ifname); + iptablesRemoveTmpRootChain(iptables_cmd, buf, 'H', 1, ifname); return 0; } static int -iptablesRemoveRootChains(virConnectPtr conn, - const char *iptables_cmd, +iptablesRemoveRootChains(const char *iptables_cmd, virBufferPtr buf, const char *ifname) { - iptablesRemoveRootChain(conn, iptables_cmd, buf, 'F', 0, ifname); - iptablesRemoveRootChain(conn, iptables_cmd, buf, 'F', 1, ifname); - iptablesRemoveRootChain(conn, iptables_cmd, buf, 'H', 1, ifname); + iptablesRemoveRootChain(iptables_cmd, buf, 'F', 0, ifname); + iptablesRemoveRootChain(iptables_cmd, buf, 'F', 1, ifname); + iptablesRemoveRootChain(iptables_cmd, buf, 'H', 1, ifname); return 0; } static int -iptablesLinkTmpRootChain(virConnectPtr conn ATTRIBUTE_UNUSED, - const char *iptables_cmd, +iptablesLinkTmpRootChain(const char *iptables_cmd, virBufferPtr buf, const char *basechain, char prefix, @@ -594,22 +574,20 @@ iptablesLinkTmpRootChain(virConnectPtr c static int -iptablesLinkTmpRootChains(virConnectPtr conn, - const char *cmd, +iptablesLinkTmpRootChains(const char *cmd, virBufferPtr buf, const char *ifname) { - iptablesLinkTmpRootChain(conn, cmd, buf, VIRT_OUT_CHAIN, 'F', 0, ifname, 1); - iptablesLinkTmpRootChain(conn, cmd, buf, VIRT_IN_CHAIN , 'F', 1, ifname, 1); - iptablesLinkTmpRootChain(conn, cmd, buf, HOST_IN_CHAIN , 'H', 1, ifname, 1); + iptablesLinkTmpRootChain(cmd, buf, VIRT_OUT_CHAIN, 'F', 0, ifname, 1); + iptablesLinkTmpRootChain(cmd, buf, VIRT_IN_CHAIN , 'F', 1, ifname, 1); + iptablesLinkTmpRootChain(cmd, buf, HOST_IN_CHAIN , 'H', 1, ifname, 1); return 0; } static int -iptablesSetupVirtInPost(virConnectPtr conn ATTRIBUTE_UNUSED, - const char *iptables_cmd, +iptablesSetupVirtInPost(const char *iptables_cmd, virBufferPtr buf, const char *ifname) { @@ -634,8 +612,7 @@ iptablesSetupVirtInPost(virConnectPtr co static int -iptablesClearVirtInPost(virConnectPtr conn ATTRIBUTE_UNUSED, - const char *iptables_cmd, +iptablesClearVirtInPost(const char *iptables_cmd, virBufferPtr buf, const char *ifname) { @@ -649,13 +626,12 @@ iptablesClearVirtInPost(virConnectPtr co } static int -_iptablesUnlinkRootChain(virConnectPtr conn ATTRIBUTE_UNUSED, - const char *iptables_cmd, - virBufferPtr buf, - const char *basechain, - char prefix, - int incoming, const char *ifname, - int isTempChain) +_iptablesUnlinkRootChain(const char *iptables_cmd, + virBufferPtr buf, + const char *basechain, + char prefix, + int incoming, const char *ifname, + int isTempChain) { char chain[MAX_CHAINNAME_LENGTH]; char chainPrefix[2] = { @@ -684,61 +660,56 @@ _iptablesUnlinkRootChain(virConnectPtr c static int -iptablesUnlinkRootChain(virConnectPtr conn ATTRIBUTE_UNUSED, - const char *iptables_cmd, +iptablesUnlinkRootChain(const char *iptables_cmd, virBufferPtr buf, const char *basechain, char prefix, int incoming, const char *ifname) { - return _iptablesUnlinkRootChain(conn, iptables_cmd, buf, + return _iptablesUnlinkRootChain(iptables_cmd, buf, basechain, prefix, incoming, ifname, 0); } static int -iptablesUnlinkTmpRootChain(virConnectPtr conn ATTRIBUTE_UNUSED, - const char *iptables_cmd, +iptablesUnlinkTmpRootChain(const char *iptables_cmd, virBufferPtr buf, const char *basechain, char prefix, int incoming, const char *ifname) { - return _iptablesUnlinkRootChain(conn, iptables_cmd, buf, + return _iptablesUnlinkRootChain(iptables_cmd, buf, basechain, prefix, incoming, ifname, 1); } static int -iptablesUnlinkRootChains(virConnectPtr conn, - const char *cmd, +iptablesUnlinkRootChains(const char *cmd, virBufferPtr buf, const char *ifname) { - iptablesUnlinkRootChain(conn, cmd, buf, VIRT_OUT_CHAIN, 'F', 0, ifname); - iptablesUnlinkRootChain(conn, cmd, buf, VIRT_IN_CHAIN , 'F', 1, ifname); - iptablesUnlinkRootChain(conn, cmd, buf, HOST_IN_CHAIN , 'H', 1, ifname); + iptablesUnlinkRootChain(cmd, buf, VIRT_OUT_CHAIN, 'F', 0, ifname); + iptablesUnlinkRootChain(cmd, buf, VIRT_IN_CHAIN , 'F', 1, ifname); + iptablesUnlinkRootChain(cmd, buf, HOST_IN_CHAIN , 'H', 1, ifname); return 0; } static int -iptablesUnlinkTmpRootChains(virConnectPtr conn, - const char *cmd, +iptablesUnlinkTmpRootChains(const char *cmd, virBufferPtr buf, const char *ifname) { - iptablesUnlinkTmpRootChain(conn, cmd, buf, VIRT_OUT_CHAIN, 'F', 0, ifname); - iptablesUnlinkTmpRootChain(conn, cmd, buf, VIRT_IN_CHAIN , 'F', 1, ifname); - iptablesUnlinkTmpRootChain(conn, cmd, buf, HOST_IN_CHAIN , 'H', 1, ifname); + iptablesUnlinkTmpRootChain(cmd, buf, VIRT_OUT_CHAIN, 'F', 0, ifname); + iptablesUnlinkTmpRootChain(cmd, buf, VIRT_IN_CHAIN , 'F', 1, ifname); + iptablesUnlinkTmpRootChain(cmd, buf, HOST_IN_CHAIN , 'H', 1, ifname); return 0; } static int -iptablesRenameTmpRootChain(virConnectPtr conn ATTRIBUTE_UNUSED, - const char *iptables_cmd, +iptablesRenameTmpRootChain(const char *iptables_cmd, virBufferPtr buf, char prefix, int incoming, @@ -769,21 +740,19 @@ iptablesRenameTmpRootChain(virConnectPtr static int -iptablesRenameTmpRootChains(virConnectPtr conn, - const char *iptables_cmd, +iptablesRenameTmpRootChains(const char *iptables_cmd, virBufferPtr buf, const char *ifname) { - iptablesRenameTmpRootChain(conn, iptables_cmd, buf, 'F', 0, ifname); - iptablesRenameTmpRootChain(conn, iptables_cmd, buf, 'F', 1, ifname); - iptablesRenameTmpRootChain(conn, iptables_cmd, buf, 'H', 1, ifname); + iptablesRenameTmpRootChain(iptables_cmd, buf, 'F', 0, ifname); + iptablesRenameTmpRootChain(iptables_cmd, buf, 'F', 1, ifname); + iptablesRenameTmpRootChain(iptables_cmd, buf, 'H', 1, ifname); return 0; } static void -iptablesInstCommand(virConnectPtr conn ATTRIBUTE_UNUSED, - virBufferPtr buf, +iptablesInstCommand(virBufferPtr buf, const char *templ, char cmd, int pos, int stopOnError) { @@ -797,8 +766,7 @@ iptablesInstCommand(virConnectPtr conn A static int -iptablesHandleSrcMacAddr(virConnectPtr conn ATTRIBUTE_UNUSED, - virBufferPtr buf, +iptablesHandleSrcMacAddr(virBufferPtr buf, virNWFilterHashTablePtr vars, nwItemDescPtr srcMacAddr, int directionIn ATTRIBUTE_UNUSED) @@ -806,8 +774,7 @@ iptablesHandleSrcMacAddr(virConnectPtr c char macaddr[VIR_MAC_STRING_BUFLEN]; if (HAS_ENTRY_ITEM(srcMacAddr)) { - if (printDataType(conn, - vars, + if (printDataType(vars, macaddr, sizeof(macaddr), srcMacAddr)) goto err_exit; @@ -828,8 +795,7 @@ err_exit: static int -iptablesHandleIpHdr(virConnectPtr conn ATTRIBUTE_UNUSED, - virBufferPtr buf, +iptablesHandleIpHdr(virBufferPtr buf, virNWFilterHashTablePtr vars, ipHdrDataDefPtr ipHdr, int directionIn) @@ -849,8 +815,7 @@ iptablesHandleIpHdr(virConnectPtr conn A if (HAS_ENTRY_ITEM(&ipHdr->dataSrcIPAddr)) { - if (printDataType(conn, - vars, + if (printDataType(vars, ipaddr, sizeof(ipaddr), &ipHdr->dataSrcIPAddr)) goto err_exit; @@ -863,8 +828,7 @@ iptablesHandleIpHdr(virConnectPtr conn A if (HAS_ENTRY_ITEM(&ipHdr->dataSrcIPMask)) { - if (printDataType(conn, - vars, + if (printDataType(vars, number, sizeof(number), &ipHdr->dataSrcIPMask)) goto err_exit; @@ -875,8 +839,7 @@ iptablesHandleIpHdr(virConnectPtr conn A } } else if (HAS_ENTRY_ITEM(&ipHdr->dataSrcIPFrom)) { - if (printDataType(conn, - vars, + if (printDataType(vars, ipaddr, sizeof(ipaddr), &ipHdr->dataSrcIPFrom)) goto err_exit; @@ -889,8 +852,7 @@ iptablesHandleIpHdr(virConnectPtr conn A if (HAS_ENTRY_ITEM(&ipHdr->dataSrcIPTo)) { - if (printDataType(conn, - vars, + if (printDataType(vars, ipaddr, sizeof(ipaddr), &ipHdr->dataSrcIPTo)) goto err_exit; @@ -903,8 +865,7 @@ iptablesHandleIpHdr(virConnectPtr conn A if (HAS_ENTRY_ITEM(&ipHdr->dataDstIPAddr)) { - if (printDataType(conn, - vars, + if (printDataType(vars, ipaddr, sizeof(ipaddr), &ipHdr->dataDstIPAddr)) goto err_exit; @@ -917,8 +878,7 @@ iptablesHandleIpHdr(virConnectPtr conn A if (HAS_ENTRY_ITEM(&ipHdr->dataDstIPMask)) { - if (printDataType(conn, - vars, + if (printDataType(vars, number, sizeof(number), &ipHdr->dataDstIPMask)) goto err_exit; @@ -930,8 +890,7 @@ iptablesHandleIpHdr(virConnectPtr conn A } } else if (HAS_ENTRY_ITEM(&ipHdr->dataDstIPFrom)) { - if (printDataType(conn, - vars, + if (printDataType(vars, ipaddr, sizeof(ipaddr), &ipHdr->dataDstIPFrom)) goto err_exit; @@ -944,8 +903,7 @@ iptablesHandleIpHdr(virConnectPtr conn A if (HAS_ENTRY_ITEM(&ipHdr->dataDstIPTo)) { - if (printDataType(conn, - vars, + if (printDataType(vars, ipaddr, sizeof(ipaddr), &ipHdr->dataDstIPTo)) goto err_exit; @@ -958,8 +916,7 @@ iptablesHandleIpHdr(virConnectPtr conn A if (HAS_ENTRY_ITEM(&ipHdr->dataDSCP)) { - if (printDataType(conn, - vars, + if (printDataType(vars, number, sizeof(number), &ipHdr->dataDSCP)) goto err_exit; @@ -980,8 +937,7 @@ err_exit: static int -iptablesHandlePortData(virConnectPtr conn ATTRIBUTE_UNUSED, - virBufferPtr buf, +iptablesHandlePortData(virBufferPtr buf, virNWFilterHashTablePtr vars, portDataDefPtr portData, int directionIn) @@ -995,8 +951,7 @@ iptablesHandlePortData(virConnectPtr con } if (HAS_ENTRY_ITEM(&portData->dataSrcPortStart)) { - if (printDataType(conn, - vars, + if (printDataType(vars, portstr, sizeof(portstr), &portData->dataSrcPortStart)) goto err_exit; @@ -1008,8 +963,7 @@ iptablesHandlePortData(virConnectPtr con portstr); if (HAS_ENTRY_ITEM(&portData->dataSrcPortEnd)) { - if (printDataType(conn, - vars, + if (printDataType(vars, portstr, sizeof(portstr), &portData->dataSrcPortEnd)) goto err_exit; @@ -1021,8 +975,7 @@ iptablesHandlePortData(virConnectPtr con } if (HAS_ENTRY_ITEM(&portData->dataDstPortStart)) { - if (printDataType(conn, - vars, + if (printDataType(vars, portstr, sizeof(portstr), &portData->dataDstPortStart)) goto err_exit; @@ -1034,8 +987,7 @@ iptablesHandlePortData(virConnectPtr con portstr); if (HAS_ENTRY_ITEM(&portData->dataDstPortEnd)) { - if (printDataType(conn, - vars, + if (printDataType(vars, portstr, sizeof(portstr), &portData->dataDstPortEnd)) goto err_exit; @@ -1054,7 +1006,6 @@ err_exit: /* * _iptablesCreateRuleInstance: - * @conn : Pointer to a virConnect object * @chainPrefix : The prefix to put in front of the name of the chain * @nwfilter : The filter * @rule: The rule of the filter to convert @@ -1069,8 +1020,7 @@ err_exit: * virConnect object. */ static int -_iptablesCreateRuleInstance(virConnectPtr conn, - int directionIn, +_iptablesCreateRuleInstance(int directionIn, const char *chainPrefix, virNWFilterDefPtr nwfilter, virNWFilterRuleDefPtr rule, @@ -1099,30 +1049,26 @@ _iptablesCreateRuleInstance(virConnectPt virBufferAddLit(&buf, " -p tcp"); - if (iptablesHandleSrcMacAddr(conn, - &buf, + if (iptablesHandleSrcMacAddr(&buf, vars, &rule->p.tcpHdrFilter.dataSrcMACAddr, directionIn)) goto err_exit; - if (iptablesHandleIpHdr(conn, - &buf, + if (iptablesHandleIpHdr(&buf, vars, &rule->p.tcpHdrFilter.ipHdr, directionIn)) goto err_exit; - if (iptablesHandlePortData(conn, - &buf, + if (iptablesHandlePortData(&buf, vars, &rule->p.tcpHdrFilter.portData, directionIn)) goto err_exit; if (HAS_ENTRY_ITEM(&rule->p.tcpHdrFilter.dataTCPOption)) { - if (printDataType(conn, - vars, + if (printDataType(vars, number, sizeof(number), &rule->p.tcpHdrFilter.dataTCPOption)) goto err_exit; @@ -1144,22 +1090,19 @@ _iptablesCreateRuleInstance(virConnectPt virBufferAddLit(&buf, " -p udp"); - if (iptablesHandleSrcMacAddr(conn, - &buf, + if (iptablesHandleSrcMacAddr(&buf, vars, &rule->p.udpHdrFilter.dataSrcMACAddr, directionIn)) goto err_exit; - if (iptablesHandleIpHdr(conn, - &buf, + if (iptablesHandleIpHdr(&buf, vars, &rule->p.udpHdrFilter.ipHdr, directionIn)) goto err_exit; - if (iptablesHandlePortData(conn, - &buf, + if (iptablesHandlePortData(&buf, vars, &rule->p.udpHdrFilter.portData, directionIn)) @@ -1175,15 +1118,13 @@ _iptablesCreateRuleInstance(virConnectPt virBufferAddLit(&buf, " -p udplite"); - if (iptablesHandleSrcMacAddr(conn, - &buf, + if (iptablesHandleSrcMacAddr(&buf, vars, &rule->p.udpliteHdrFilter.dataSrcMACAddr, directionIn)) goto err_exit; - if (iptablesHandleIpHdr(conn, - &buf, + if (iptablesHandleIpHdr(&buf, vars, &rule->p.udpliteHdrFilter.ipHdr, directionIn)) @@ -1200,15 +1141,13 @@ _iptablesCreateRuleInstance(virConnectPt virBufferAddLit(&buf, " -p esp"); - if (iptablesHandleSrcMacAddr(conn, - &buf, + if (iptablesHandleSrcMacAddr(&buf, vars, &rule->p.espHdrFilter.dataSrcMACAddr, directionIn)) goto err_exit; - if (iptablesHandleIpHdr(conn, - &buf, + if (iptablesHandleIpHdr(&buf, vars, &rule->p.espHdrFilter.ipHdr, directionIn)) @@ -1225,15 +1164,13 @@ _iptablesCreateRuleInstance(virConnectPt virBufferAddLit(&buf, " -p ah"); - if (iptablesHandleSrcMacAddr(conn, - &buf, + if (iptablesHandleSrcMacAddr(&buf, vars, &rule->p.ahHdrFilter.dataSrcMACAddr, directionIn)) goto err_exit; - if (iptablesHandleIpHdr(conn, - &buf, + if (iptablesHandleIpHdr(&buf, vars, &rule->p.ahHdrFilter.ipHdr, directionIn)) @@ -1250,22 +1187,19 @@ _iptablesCreateRuleInstance(virConnectPt virBufferAddLit(&buf, " -p sctp"); - if (iptablesHandleSrcMacAddr(conn, - &buf, + if (iptablesHandleSrcMacAddr(&buf, vars, &rule->p.sctpHdrFilter.dataSrcMACAddr, directionIn)) goto err_exit; - if (iptablesHandleIpHdr(conn, - &buf, + if (iptablesHandleIpHdr(&buf, vars, &rule->p.sctpHdrFilter.ipHdr, directionIn)) goto err_exit; - if (iptablesHandlePortData(conn, - &buf, + if (iptablesHandlePortData(&buf, vars, &rule->p.sctpHdrFilter.portData, directionIn)) @@ -1284,15 +1218,13 @@ _iptablesCreateRuleInstance(virConnectPt else virBufferAddLit(&buf, " -p icmpv6"); - if (iptablesHandleSrcMacAddr(conn, - &buf, + if (iptablesHandleSrcMacAddr(&buf, vars, &rule->p.icmpHdrFilter.dataSrcMACAddr, directionIn)) goto err_exit; - if (iptablesHandleIpHdr(conn, - &buf, + if (iptablesHandleIpHdr(&buf, vars, &rule->p.icmpHdrFilter.ipHdr, directionIn)) @@ -1305,8 +1237,7 @@ _iptablesCreateRuleInstance(virConnectPt else parm = "--icmpv6-type"; - if (printDataType(conn, - vars, + if (printDataType(vars, number, sizeof(number), &rule->p.icmpHdrFilter.dataICMPType)) goto err_exit; @@ -1318,8 +1249,7 @@ _iptablesCreateRuleInstance(virConnectPt number); if (HAS_ENTRY_ITEM(&rule->p.icmpHdrFilter.dataICMPCode)) { - if (printDataType(conn, - vars, + if (printDataType(vars, number, sizeof(number), &rule->p.icmpHdrFilter.dataICMPCode)) goto err_exit; @@ -1339,15 +1269,13 @@ _iptablesCreateRuleInstance(virConnectPt virBufferAddLit(&buf, " -p igmp"); - if (iptablesHandleSrcMacAddr(conn, - &buf, + if (iptablesHandleSrcMacAddr(&buf, vars, &rule->p.igmpHdrFilter.dataSrcMACAddr, directionIn)) goto err_exit; - if (iptablesHandleIpHdr(conn, - &buf, + if (iptablesHandleIpHdr(&buf, vars, &rule->p.igmpHdrFilter.ipHdr, directionIn)) @@ -1364,15 +1292,13 @@ _iptablesCreateRuleInstance(virConnectPt virBufferAddLit(&buf, " -p all"); - if (iptablesHandleSrcMacAddr(conn, - &buf, + if (iptablesHandleSrcMacAddr(&buf, vars, &rule->p.allHdrFilter.dataSrcMACAddr, directionIn)) goto err_exit; - if (iptablesHandleIpHdr(conn, - &buf, + if (iptablesHandleIpHdr(&buf, vars, &rule->p.allHdrFilter.ipHdr, directionIn)) @@ -1403,8 +1329,7 @@ _iptablesCreateRuleInstance(virConnectPt return -1; } - return ebiptablesAddRuleInst(conn, - res, + return ebiptablesAddRuleInst(res, virBufferContentAndReset(&buf), nwfilter->chainsuffix, '\0', @@ -1421,8 +1346,7 @@ err_exit: static int -iptablesCreateRuleInstance(virConnectPtr conn, - virNWFilterDefPtr nwfilter, +iptablesCreateRuleInstance(virNWFilterDefPtr nwfilter, virNWFilterRuleDefPtr rule, const char *ifname, virNWFilterHashTablePtr vars, @@ -1443,8 +1367,7 @@ iptablesCreateRuleInstance(virConnectPtr chainPrefix[0] = 'F'; chainPrefix[1] = CHAINPREFIX_HOST_IN_TEMP; - rc = _iptablesCreateRuleInstance(conn, - directionIn, + rc = _iptablesCreateRuleInstance(directionIn, chainPrefix, nwfilter, rule, @@ -1459,8 +1382,7 @@ iptablesCreateRuleInstance(virConnectPtr return rc; chainPrefix[1] = CHAINPREFIX_HOST_OUT_TEMP; - rc = _iptablesCreateRuleInstance(conn, - !directionIn, + rc = _iptablesCreateRuleInstance(!directionIn, chainPrefix, nwfilter, rule, @@ -1476,8 +1398,7 @@ iptablesCreateRuleInstance(virConnectPtr chainPrefix[0] = 'H'; chainPrefix[1] = CHAINPREFIX_HOST_IN_TEMP; - rc = _iptablesCreateRuleInstance(conn, - directionIn, + rc = _iptablesCreateRuleInstance(directionIn, chainPrefix, nwfilter, rule, @@ -1498,7 +1419,6 @@ iptablesCreateRuleInstance(virConnectPtr /* * ebtablesCreateRuleInstance: - * @conn : Pointer to a virConnect object * @chainPrefix : The prefix to put in front of the name of the chain * @nwfilter : The filter * @rule: The rule of the filter to convert @@ -1513,8 +1433,7 @@ iptablesCreateRuleInstance(virConnectPtr * virConnect object. */ static int -ebtablesCreateRuleInstance(virConnectPtr conn, - char chainPrefix, +ebtablesCreateRuleInstance(char chainPrefix, virNWFilterDefPtr nwfilter, virNWFilterRuleDefPtr rule, const char *ifname, @@ -1543,15 +1462,13 @@ ebtablesCreateRuleInstance(virConnectPtr EBTABLES_DEFAULT_TABLE, chain); - if (ebtablesHandleEthHdr(conn, - &buf, + if (ebtablesHandleEthHdr(&buf, vars, &rule->p.ethHdrFilter.ethHdr)) goto err_exit; if (HAS_ENTRY_ITEM(&rule->p.ethHdrFilter.dataProtocolID)) { - if (printDataTypeAsHex(conn, - vars, + if (printDataTypeAsHex(vars, number, sizeof(number), &rule->p.ethHdrFilter.dataProtocolID)) goto err_exit; @@ -1568,8 +1485,7 @@ ebtablesCreateRuleInstance(virConnectPtr CMD_DEF_PRE EBTABLES_CMD " -t %s -%%c %s %%s", EBTABLES_DEFAULT_TABLE, chain); - if (ebtablesHandleEthHdr(conn, - &buf, + if (ebtablesHandleEthHdr(&buf, vars, &rule->p.arpHdrFilter.ethHdr)) goto err_exit; @@ -1577,10 +1493,9 @@ ebtablesCreateRuleInstance(virConnectPtr virBufferAddLit(&buf, " -p arp"); if (HAS_ENTRY_ITEM(&rule->p.arpHdrFilter.dataHWType)) { - if (printDataType(conn, - vars, - number, sizeof(number), - &rule->p.arpHdrFilter.dataHWType)) + if (printDataType(vars, + number, sizeof(number), + &rule->p.arpHdrFilter.dataHWType)) goto err_exit; virBufferVSprintf(&buf, " --arp-htype %s %s", @@ -1589,8 +1504,7 @@ ebtablesCreateRuleInstance(virConnectPtr } if (HAS_ENTRY_ITEM(&rule->p.arpHdrFilter.dataOpcode)) { - if (printDataType(conn, - vars, + if (printDataType(vars, number, sizeof(number), &rule->p.arpHdrFilter.dataOpcode)) goto err_exit; @@ -1601,8 +1515,7 @@ ebtablesCreateRuleInstance(virConnectPtr } if (HAS_ENTRY_ITEM(&rule->p.arpHdrFilter.dataProtocolType)) { - if (printDataTypeAsHex(conn, - vars, + if (printDataTypeAsHex(vars, number, sizeof(number), &rule->p.arpHdrFilter.dataProtocolType)) goto err_exit; @@ -1613,8 +1526,7 @@ ebtablesCreateRuleInstance(virConnectPtr } if (HAS_ENTRY_ITEM(&rule->p.arpHdrFilter.dataARPSrcIPAddr)) { - if (printDataType(conn, - vars, + if (printDataType(vars, ipaddr, sizeof(ipaddr), &rule->p.arpHdrFilter.dataARPSrcIPAddr)) goto err_exit; @@ -1626,8 +1538,7 @@ ebtablesCreateRuleInstance(virConnectPtr } if (HAS_ENTRY_ITEM(&rule->p.arpHdrFilter.dataARPDstIPAddr)) { - if (printDataType(conn, - vars, + if (printDataType(vars, ipaddr, sizeof(ipaddr), &rule->p.arpHdrFilter.dataARPDstIPAddr)) goto err_exit; @@ -1639,8 +1550,7 @@ ebtablesCreateRuleInstance(virConnectPtr } if (HAS_ENTRY_ITEM(&rule->p.arpHdrFilter.dataARPSrcMACAddr)) { - if (printDataType(conn, - vars, + if (printDataType(vars, macaddr, sizeof(macaddr), &rule->p.arpHdrFilter.dataARPSrcMACAddr)) goto err_exit; @@ -1652,8 +1562,7 @@ ebtablesCreateRuleInstance(virConnectPtr } if (HAS_ENTRY_ITEM(&rule->p.arpHdrFilter.dataARPDstMACAddr)) { - if (printDataType(conn, - vars, + if (printDataType(vars, macaddr, sizeof(macaddr), &rule->p.arpHdrFilter.dataARPDstMACAddr)) goto err_exit; @@ -1670,8 +1579,7 @@ ebtablesCreateRuleInstance(virConnectPtr CMD_DEF_PRE EBTABLES_CMD " -t %s -%%c %s %%s", EBTABLES_DEFAULT_TABLE, chain); - if (ebtablesHandleEthHdr(conn, - &buf, + if (ebtablesHandleEthHdr(&buf, vars, &rule->p.ipHdrFilter.ethHdr)) goto err_exit; @@ -1680,8 +1588,7 @@ ebtablesCreateRuleInstance(virConnectPtr " -p ipv4"); if (HAS_ENTRY_ITEM(&rule->p.ipHdrFilter.ipHdr.dataSrcIPAddr)) { - if (printDataType(conn, - vars, + if (printDataType(vars, ipaddr, sizeof(ipaddr), &rule->p.ipHdrFilter.ipHdr.dataSrcIPAddr)) goto err_exit; @@ -1692,8 +1599,7 @@ ebtablesCreateRuleInstance(virConnectPtr ipaddr); if (HAS_ENTRY_ITEM(&rule->p.ipHdrFilter.ipHdr.dataSrcIPMask)) { - if (printDataType(conn, - vars, + if (printDataType(vars, number, sizeof(number), &rule->p.ipHdrFilter.ipHdr.dataSrcIPMask)) goto err_exit; @@ -1705,8 +1611,7 @@ ebtablesCreateRuleInstance(virConnectPtr if (HAS_ENTRY_ITEM(&rule->p.ipHdrFilter.ipHdr.dataDstIPAddr)) { - if (printDataType(conn, - vars, + if (printDataType(vars, ipaddr, sizeof(ipaddr), &rule->p.ipHdrFilter.ipHdr.dataDstIPAddr)) goto err_exit; @@ -1717,8 +1622,7 @@ ebtablesCreateRuleInstance(virConnectPtr ipaddr); if (HAS_ENTRY_ITEM(&rule->p.ipHdrFilter.ipHdr.dataDstIPMask)) { - if (printDataType(conn, - vars, + if (printDataType(vars, number, sizeof(number), &rule->p.ipHdrFilter.ipHdr.dataDstIPMask)) goto err_exit; @@ -1729,8 +1633,7 @@ ebtablesCreateRuleInstance(virConnectPtr } if (HAS_ENTRY_ITEM(&rule->p.ipHdrFilter.ipHdr.dataProtocolID)) { - if (printDataType(conn, - vars, + if (printDataType(vars, number, sizeof(number), &rule->p.ipHdrFilter.ipHdr.dataProtocolID)) goto err_exit; @@ -1743,8 +1646,7 @@ ebtablesCreateRuleInstance(virConnectPtr if (HAS_ENTRY_ITEM(&rule->p.ipHdrFilter.portData.dataSrcPortStart)) { - if (printDataType(conn, - vars, + if (printDataType(vars, number, sizeof(number), &rule->p.ipHdrFilter.portData.dataSrcPortStart)) goto err_exit; @@ -1755,8 +1657,7 @@ ebtablesCreateRuleInstance(virConnectPtr number); if (HAS_ENTRY_ITEM(&rule->p.ipHdrFilter.portData.dataSrcPortEnd)) { - if (printDataType(conn, - vars, + if (printDataType(vars, number, sizeof(number), &rule->p.ipHdrFilter.portData.dataSrcPortEnd)) goto err_exit; @@ -1769,8 +1670,7 @@ ebtablesCreateRuleInstance(virConnectPtr if (HAS_ENTRY_ITEM(&rule->p.ipHdrFilter.portData.dataDstPortStart)) { - if (printDataType(conn, - vars, + if (printDataType(vars, number, sizeof(number), &rule->p.ipHdrFilter.portData.dataDstPortStart)) goto err_exit; @@ -1781,8 +1681,7 @@ ebtablesCreateRuleInstance(virConnectPtr number); if (HAS_ENTRY_ITEM(&rule->p.ipHdrFilter.portData.dataDstPortEnd)) { - if (printDataType(conn, - vars, + if (printDataType(vars, number, sizeof(number), &rule->p.ipHdrFilter.portData.dataDstPortEnd)) goto err_exit; @@ -1794,8 +1693,7 @@ ebtablesCreateRuleInstance(virConnectPtr } if (HAS_ENTRY_ITEM(&rule->p.ipHdrFilter.ipHdr.dataDSCP)) { - if (printDataType(conn, - vars, + if (printDataType(vars, number, sizeof(number), &rule->p.ipHdrFilter.ipHdr.dataDSCP)) goto err_exit; @@ -1812,8 +1710,7 @@ ebtablesCreateRuleInstance(virConnectPtr CMD_DEF_PRE EBTABLES_CMD " -t %s -%%c %s %%s", EBTABLES_DEFAULT_TABLE, chain); - if (ebtablesHandleEthHdr(conn, - &buf, + if (ebtablesHandleEthHdr(&buf, vars, &rule->p.ipv6HdrFilter.ethHdr)) goto err_exit; @@ -1822,8 +1719,7 @@ ebtablesCreateRuleInstance(virConnectPtr " -p ipv6"); if (HAS_ENTRY_ITEM(&rule->p.ipv6HdrFilter.ipHdr.dataSrcIPAddr)) { - if (printDataType(conn, - vars, + if (printDataType(vars, ipv6addr, sizeof(ipv6addr), &rule->p.ipv6HdrFilter.ipHdr.dataSrcIPAddr)) goto err_exit; @@ -1834,8 +1730,7 @@ ebtablesCreateRuleInstance(virConnectPtr ipv6addr); if (HAS_ENTRY_ITEM(&rule->p.ipv6HdrFilter.ipHdr.dataSrcIPMask)) { - if (printDataType(conn, - vars, + if (printDataType(vars, number, sizeof(number), &rule->p.ipv6HdrFilter.ipHdr.dataSrcIPMask)) goto err_exit; @@ -1847,8 +1742,7 @@ ebtablesCreateRuleInstance(virConnectPtr if (HAS_ENTRY_ITEM(&rule->p.ipv6HdrFilter.ipHdr.dataDstIPAddr)) { - if (printDataType(conn, - vars, + if (printDataType(vars, ipv6addr, sizeof(ipv6addr), &rule->p.ipv6HdrFilter.ipHdr.dataDstIPAddr)) goto err_exit; @@ -1859,8 +1753,7 @@ ebtablesCreateRuleInstance(virConnectPtr ipv6addr); if (HAS_ENTRY_ITEM(&rule->p.ipv6HdrFilter.ipHdr.dataDstIPMask)) { - if (printDataType(conn, - vars, + if (printDataType(vars, number, sizeof(number), &rule->p.ipv6HdrFilter.ipHdr.dataDstIPMask)) goto err_exit; @@ -1871,8 +1764,7 @@ ebtablesCreateRuleInstance(virConnectPtr } if (HAS_ENTRY_ITEM(&rule->p.ipv6HdrFilter.ipHdr.dataProtocolID)) { - if (printDataType(conn, - vars, + if (printDataType(vars, number, sizeof(number), &rule->p.ipv6HdrFilter.ipHdr.dataProtocolID)) goto err_exit; @@ -1885,8 +1777,7 @@ ebtablesCreateRuleInstance(virConnectPtr if (HAS_ENTRY_ITEM(&rule->p.ipv6HdrFilter.portData.dataSrcPortStart)) { - if (printDataType(conn, - vars, + if (printDataType(vars, number, sizeof(number), &rule->p.ipv6HdrFilter.portData.dataSrcPortStart)) goto err_exit; @@ -1897,8 +1788,7 @@ ebtablesCreateRuleInstance(virConnectPtr number); if (HAS_ENTRY_ITEM(&rule->p.ipv6HdrFilter.portData.dataSrcPortEnd)) { - if (printDataType(conn, - vars, + if (printDataType(vars, number, sizeof(number), &rule->p.ipv6HdrFilter.portData.dataSrcPortEnd)) goto err_exit; @@ -1911,8 +1801,7 @@ ebtablesCreateRuleInstance(virConnectPtr if (HAS_ENTRY_ITEM(&rule->p.ipv6HdrFilter.portData.dataDstPortStart)) { - if (printDataType(conn, - vars, + if (printDataType(vars, number, sizeof(number), &rule->p.ipv6HdrFilter.portData.dataDstPortStart)) goto err_exit; @@ -1923,10 +1812,9 @@ ebtablesCreateRuleInstance(virConnectPtr number); if (HAS_ENTRY_ITEM(&rule->p.ipv6HdrFilter.portData.dataDstPortEnd)) { - if (printDataType(conn, - vars, - number, sizeof(number), - &rule->p.ipv6HdrFilter.portData.dataDstPortEnd)) + if (printDataType(vars, + number, sizeof(number), + &rule->p.ipv6HdrFilter.portData.dataDstPortEnd)) goto err_exit; virBufferVSprintf(&buf, @@ -1957,8 +1845,7 @@ ebtablesCreateRuleInstance(virConnectPtr return -1; } - return ebiptablesAddRuleInst(conn, - res, + return ebiptablesAddRuleInst(res, virBufferContentAndReset(&buf), nwfilter->chainsuffix, chainPrefix, @@ -1988,7 +1875,7 @@ err_exit: * virConnect object. */ static int -ebiptablesCreateRuleInstance(virConnectPtr conn, +ebiptablesCreateRuleInstance(virConnectPtr conn ATTRIBUTE_UNUSED, enum virDomainNetType nettype, virNWFilterDefPtr nwfilter, virNWFilterRuleDefPtr rule, @@ -2008,8 +1895,7 @@ ebiptablesCreateRuleInstance(virConnectP if (rule->tt == VIR_NWFILTER_RULE_DIRECTION_OUT || rule->tt == VIR_NWFILTER_RULE_DIRECTION_INOUT) { - rc = ebtablesCreateRuleInstance(conn, - CHAINPREFIX_HOST_IN_TEMP, + rc = ebtablesCreateRuleInstance(CHAINPREFIX_HOST_IN_TEMP, nwfilter, rule, ifname, @@ -2021,8 +1907,7 @@ ebiptablesCreateRuleInstance(virConnectP if (rule->tt == VIR_NWFILTER_RULE_DIRECTION_IN || rule->tt == VIR_NWFILTER_RULE_DIRECTION_INOUT) { - rc = ebtablesCreateRuleInstance(conn, - CHAINPREFIX_HOST_OUT_TEMP, + rc = ebtablesCreateRuleInstance(CHAINPREFIX_HOST_OUT_TEMP, nwfilter, rule, ifname, @@ -2041,15 +1926,14 @@ ebiptablesCreateRuleInstance(virConnectP case VIR_NWFILTER_RULE_PROTOCOL_IGMP: case VIR_NWFILTER_RULE_PROTOCOL_ALL: if (nettype == VIR_DOMAIN_NET_TYPE_DIRECT) { - virNWFilterReportError(conn, VIR_ERR_INVALID_NWFILTER, + virNWFilterReportError(VIR_ERR_INVALID_NWFILTER, _("'%s' protocol not support for net type '%s'"), virNWFilterRuleProtocolTypeToString(rule->prtclType), virDomainNetTypeToString(nettype)); return 1; } isIPv6 = 0; - rc = iptablesCreateRuleInstance(conn, - nwfilter, + rc = iptablesCreateRuleInstance(nwfilter, rule, ifname, vars, @@ -2066,15 +1950,14 @@ ebiptablesCreateRuleInstance(virConnectP case VIR_NWFILTER_RULE_PROTOCOL_ICMPV6: case VIR_NWFILTER_RULE_PROTOCOL_ALLoIPV6: if (nettype == VIR_DOMAIN_NET_TYPE_DIRECT) { - virNWFilterReportError(conn, VIR_ERR_INVALID_NWFILTER, + virNWFilterReportError(VIR_ERR_INVALID_NWFILTER, _("'%s' protocol not support for net type '%s'"), virNWFilterRuleProtocolTypeToString(rule->prtclType), virDomainNetTypeToString(nettype)); return 1; } isIPv6 = 1; - rc = iptablesCreateRuleInstance(conn, - nwfilter, + rc = iptablesCreateRuleInstance(nwfilter, rule, ifname, vars, @@ -2083,7 +1966,7 @@ ebiptablesCreateRuleInstance(virConnectP break; case VIR_NWFILTER_RULE_PROTOCOL_LAST: - virNWFilterReportError(conn, VIR_ERR_INVALID_NWFILTER, + virNWFilterReportError(VIR_ERR_INVALID_NWFILTER, "%s", _("illegal protocol type")); rc = 1; break; @@ -2115,7 +1998,6 @@ ebiptablesDisplayRuleInstance(virConnect /** * ebiptablesWriteToTempFile: - * @conn: pointer to virConnect object * @string : the string to write into the file * * Returns the tempory filename where the string was written into, @@ -2128,8 +2010,7 @@ ebiptablesDisplayRuleInstance(virConnect * set so that the file can be run as an executable script. */ static char * -ebiptablesWriteToTempFile(virConnectPtr conn, - const char *string) { +ebiptablesWriteToTempFile(const char *string) { char filename[] = "/tmp/virtdXXXXXX"; int len; char *filnam; @@ -2139,14 +2020,14 @@ ebiptablesWriteToTempFile(virConnectPtr int fd = mkstemp(filename); if (fd < 0) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("cannot create temporary file")); return NULL; } if (fchmod(fd, S_IXUSR| S_IRUSR | S_IWUSR) < 0) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("cannot change permissions on temp. file")); goto err_exit; @@ -2155,7 +2036,7 @@ ebiptablesWriteToTempFile(virConnectPtr len = strlen(header); written = safewrite(fd, header, len); if (written != len) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("cannot write string to file")); goto err_exit; @@ -2164,7 +2045,7 @@ ebiptablesWriteToTempFile(virConnectPtr len = strlen(string); written = safewrite(fd, string, len); if (written != len) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("cannot write string to file")); goto err_exit; @@ -2188,7 +2069,6 @@ err_exit: /** * ebiptablesExecCLI: - * @conn : pointer to virConnect object * @buf : pointer to virBuffer containing the string with the commands to * execute. * @status: Pointer to an integer for returning the status of the @@ -2202,8 +2082,7 @@ err_exit: * script and return the status of the execution. */ static int -ebiptablesExecCLI(virConnectPtr conn, - virBufferPtr buf, +ebiptablesExecCLI(virBufferPtr buf, int *status) { char *cmds; @@ -2226,7 +2105,7 @@ ebiptablesExecCLI(virConnectPtr conn, if (!cmds) return 0; - filename = ebiptablesWriteToTempFile(conn, cmds); + filename = ebiptablesWriteToTempFile(cmds); VIR_FREE(cmds); if (!filename) @@ -2248,8 +2127,7 @@ ebiptablesExecCLI(virConnectPtr conn, static int -ebtablesCreateTmpRootChain(virConnectPtr conn ATTRIBUTE_UNUSED, - virBufferPtr buf, +ebtablesCreateTmpRootChain(virBufferPtr buf, int incoming, const char *ifname, int stopOnError) { @@ -2271,8 +2149,7 @@ ebtablesCreateTmpRootChain(virConnectPtr static int -ebtablesLinkTmpRootChain(virConnectPtr conn ATTRIBUTE_UNUSED, - virBufferPtr buf, +ebtablesLinkTmpRootChain(virBufferPtr buf, int incoming, const char *ifname, int stopOnError) { @@ -2299,8 +2176,7 @@ ebtablesLinkTmpRootChain(virConnectPtr c static int -_ebtablesRemoveRootChain(virConnectPtr conn ATTRIBUTE_UNUSED, - virBufferPtr buf, +_ebtablesRemoveRootChain(virBufferPtr buf, int incoming, const char *ifname, int isTempChain) { @@ -2326,26 +2202,23 @@ _ebtablesRemoveRootChain(virConnectPtr c static int -ebtablesRemoveRootChain(virConnectPtr conn, - virBufferPtr buf, +ebtablesRemoveRootChain(virBufferPtr buf, int incoming, const char *ifname) { - return _ebtablesRemoveRootChain(conn, buf, incoming, ifname, 0); + return _ebtablesRemoveRootChain(buf, incoming, ifname, 0); } static int -ebtablesRemoveTmpRootChain(virConnectPtr conn, - virBufferPtr buf, +ebtablesRemoveTmpRootChain(virBufferPtr buf, int incoming, const char *ifname) { - return _ebtablesRemoveRootChain(conn, buf, incoming, ifname, 1); + return _ebtablesRemoveRootChain(buf, incoming, ifname, 1); } static int -_ebtablesUnlinkRootChain(virConnectPtr conn ATTRIBUTE_UNUSED, - virBufferPtr buf, +_ebtablesUnlinkRootChain(virBufferPtr buf, int incoming, const char *ifname, int isTempChain) { @@ -2375,26 +2248,23 @@ _ebtablesUnlinkRootChain(virConnectPtr c static int -ebtablesUnlinkRootChain(virConnectPtr conn, - virBufferPtr buf, +ebtablesUnlinkRootChain(virBufferPtr buf, int incoming, const char *ifname) { - return _ebtablesUnlinkRootChain(conn, buf, incoming, ifname, 0); + return _ebtablesUnlinkRootChain(buf, incoming, ifname, 0); } static int -ebtablesUnlinkTmpRootChain(virConnectPtr conn, - virBufferPtr buf, +ebtablesUnlinkTmpRootChain(virBufferPtr buf, int incoming, const char *ifname) { - return _ebtablesUnlinkRootChain(conn, buf, incoming, ifname, 1); + return _ebtablesUnlinkRootChain(buf, incoming, ifname, 1); } static int -ebtablesCreateTmpSubChain(virConnectPtr conn ATTRIBUTE_UNUSED, - virBufferPtr buf, +ebtablesCreateTmpSubChain(virBufferPtr buf, int incoming, const char *ifname, const char *protocol, @@ -2430,8 +2300,7 @@ ebtablesCreateTmpSubChain(virConnectPtr static int -_ebtablesRemoveSubChain(virConnectPtr conn ATTRIBUTE_UNUSED, - virBufferPtr buf, +_ebtablesRemoveSubChain(virBufferPtr buf, int incoming, const char *ifname, const char *protocol, @@ -2467,26 +2336,24 @@ _ebtablesRemoveSubChain(virConnectPtr co static int -ebtablesRemoveSubChain(virConnectPtr conn, - virBufferPtr buf, +ebtablesRemoveSubChain(virBufferPtr buf, int incoming, const char *ifname, const char *protocol) { - return _ebtablesRemoveSubChain(conn, buf, + return _ebtablesRemoveSubChain(buf, incoming, ifname, protocol, 0); } static int -ebtablesRemoveSubChains(virConnectPtr conn, - virBufferPtr buf, - const char *ifname) +ebtablesRemoveSubChains(virBufferPtr buf, + const char *ifname) { int i; for (i = 0; supported_protocols[i]; i++) { - ebtablesRemoveSubChain(conn, buf, 1, ifname, supported_protocols[i]); - ebtablesRemoveSubChain(conn, buf, 0, ifname, supported_protocols[i]); + ebtablesRemoveSubChain(buf, 1, ifname, supported_protocols[i]); + ebtablesRemoveSubChain(buf, 0, ifname, supported_protocols[i]); } return 0; @@ -2494,27 +2361,25 @@ ebtablesRemoveSubChains(virConnectPtr co static int -ebtablesRemoveTmpSubChain(virConnectPtr conn, - virBufferPtr buf, +ebtablesRemoveTmpSubChain(virBufferPtr buf, int incoming, const char *ifname, const char *protocol) { - return _ebtablesRemoveSubChain(conn, buf, + return _ebtablesRemoveSubChain(buf, incoming, ifname, protocol, 1); } static int -ebtablesRemoveTmpSubChains(virConnectPtr conn, - virBufferPtr buf, +ebtablesRemoveTmpSubChains(virBufferPtr buf, const char *ifname) { int i; for (i = 0; supported_protocols[i]; i++) { - ebtablesRemoveTmpSubChain(conn, buf, 1, ifname, + ebtablesRemoveTmpSubChain(buf, 1, ifname, supported_protocols[i]); - ebtablesRemoveTmpSubChain(conn, buf, 0, ifname, + ebtablesRemoveTmpSubChain(buf, 0, ifname, supported_protocols[i]); } @@ -2523,8 +2388,7 @@ ebtablesRemoveTmpSubChains(virConnectPtr static int -ebtablesRenameTmpSubChain(virConnectPtr conn ATTRIBUTE_UNUSED, - virBufferPtr buf, +ebtablesRenameTmpSubChain(virBufferPtr buf, int incoming, const char *ifname, const char *protocol) @@ -2553,15 +2417,14 @@ ebtablesRenameTmpSubChain(virConnectPtr static int -ebtablesRenameTmpSubChains(virConnectPtr conn, - virBufferPtr buf, +ebtablesRenameTmpSubChains(virBufferPtr buf, const char *ifname) { int i; for (i = 0; supported_protocols[i]; i++) { - ebtablesRenameTmpSubChain (conn, buf, 1, ifname, + ebtablesRenameTmpSubChain (buf, 1, ifname, supported_protocols[i]); - ebtablesRenameTmpSubChain (conn, buf, 0, ifname, + ebtablesRenameTmpSubChain (buf, 0, ifname, supported_protocols[i]); } @@ -2570,18 +2433,16 @@ ebtablesRenameTmpSubChains(virConnectPtr static int -ebtablesRenameTmpRootChain(virConnectPtr conn, - virBufferPtr buf, +ebtablesRenameTmpRootChain(virBufferPtr buf, int incoming, const char *ifname) { - return ebtablesRenameTmpSubChain(conn, buf, incoming, ifname, NULL); + return ebtablesRenameTmpSubChain(buf, incoming, ifname, NULL); } static void -ebiptablesInstCommand(virConnectPtr conn ATTRIBUTE_UNUSED, - virBufferPtr buf, +ebiptablesInstCommand(virBufferPtr buf, const char *templ, char cmd, int pos, int stopOnError) { @@ -2604,7 +2465,7 @@ ebiptablesRuleOrderSort(const void *a, c static int -ebiptablesApplyNewRules(virConnectPtr conn, +ebiptablesApplyNewRules(virConnectPtr conn ATTRIBUTE_UNUSED, const char *ifname, int nruleInstances, void **_inst) @@ -2630,41 +2491,41 @@ ebiptablesApplyNewRules(virConnectPtr co } } - ebtablesUnlinkTmpRootChain(conn, &buf, 1, ifname); - ebtablesUnlinkTmpRootChain(conn, &buf, 0, ifname); - ebtablesRemoveTmpSubChains(conn, &buf, ifname); - ebtablesRemoveTmpRootChain(conn, &buf, 1, ifname); - ebtablesRemoveTmpRootChain(conn, &buf, 0, ifname); - ebiptablesExecCLI(conn, &buf, &cli_status); + ebtablesUnlinkTmpRootChain(&buf, 1, ifname); + ebtablesUnlinkTmpRootChain(&buf, 0, ifname); + ebtablesRemoveTmpSubChains(&buf, ifname); + ebtablesRemoveTmpRootChain(&buf, 1, ifname); + ebtablesRemoveTmpRootChain(&buf, 0, ifname); + ebiptablesExecCLI(&buf, &cli_status); if (chains_in != 0) - ebtablesCreateTmpRootChain(conn, &buf, 1, ifname, 1); + ebtablesCreateTmpRootChain(&buf, 1, ifname, 1); if (chains_out != 0) - ebtablesCreateTmpRootChain(conn, &buf, 0, ifname, 1); + ebtablesCreateTmpRootChain(&buf, 0, ifname, 1); if (chains_in & (1 << VIR_NWFILTER_CHAINSUFFIX_IPv4)) - ebtablesCreateTmpSubChain(conn, &buf, 1, ifname, "ipv4", 1); + ebtablesCreateTmpSubChain(&buf, 1, ifname, "ipv4", 1); if (chains_out & (1 << VIR_NWFILTER_CHAINSUFFIX_IPv4)) - ebtablesCreateTmpSubChain(conn, &buf, 0, ifname, "ipv4", 1); + ebtablesCreateTmpSubChain(&buf, 0, ifname, "ipv4", 1); if (chains_in & (1 << VIR_NWFILTER_CHAINSUFFIX_IPv6)) - ebtablesCreateTmpSubChain(conn, &buf, 1, ifname, "ipv6", 1); + ebtablesCreateTmpSubChain(&buf, 1, ifname, "ipv6", 1); if (chains_out & (1 << VIR_NWFILTER_CHAINSUFFIX_IPv6)) - ebtablesCreateTmpSubChain(conn, &buf, 0, ifname, "ipv6", 1); + ebtablesCreateTmpSubChain(&buf, 0, ifname, "ipv6", 1); // keep arp as last if (chains_in & (1 << VIR_NWFILTER_CHAINSUFFIX_ARP)) - ebtablesCreateTmpSubChain(conn, &buf, 1, ifname, "arp", 1); + ebtablesCreateTmpSubChain(&buf, 1, ifname, "arp", 1); if (chains_out & (1 << VIR_NWFILTER_CHAINSUFFIX_ARP)) - ebtablesCreateTmpSubChain(conn, &buf, 0, ifname, "arp", 1); + ebtablesCreateTmpSubChain(&buf, 0, ifname, "arp", 1); - if (ebiptablesExecCLI(conn, &buf, &cli_status) || cli_status != 0) + if (ebiptablesExecCLI(&buf, &cli_status) || cli_status != 0) goto tear_down_tmpebchains; for (i = 0; i < nruleInstances; i++) switch (inst[i]->ruleType) { case RT_EBTABLES: - ebiptablesInstCommand(conn, &buf, + ebiptablesInstCommand(&buf, inst[i]->commandTemplate, 'A', -1, 1); break; @@ -2676,68 +2537,68 @@ ebiptablesApplyNewRules(virConnectPtr co break; } - if (ebiptablesExecCLI(conn, &buf, &cli_status) || cli_status != 0) + if (ebiptablesExecCLI(&buf, &cli_status) || cli_status != 0) goto tear_down_tmpebchains; // FIXME: establishment of iptables user define table tree goes here if (haveIptables) { - iptablesUnlinkTmpRootChains(conn, IPTABLES_CMD, &buf, ifname); - iptablesRemoveTmpRootChains(conn, IPTABLES_CMD, &buf, ifname); + iptablesUnlinkTmpRootChains(IPTABLES_CMD, &buf, ifname); + iptablesRemoveTmpRootChains(IPTABLES_CMD, &buf, ifname); - iptablesCreateBaseChains(conn, IPTABLES_CMD, &buf); + iptablesCreateBaseChains(IPTABLES_CMD, &buf); - if (ebiptablesExecCLI(conn, &buf, &cli_status) || cli_status != 0) + if (ebiptablesExecCLI(&buf, &cli_status) || cli_status != 0) goto tear_down_tmpebchains; - iptablesCreateTmpRootChains(conn, IPTABLES_CMD, &buf, ifname); + iptablesCreateTmpRootChains(IPTABLES_CMD, &buf, ifname); - if (ebiptablesExecCLI(conn, &buf, &cli_status) || cli_status != 0) + if (ebiptablesExecCLI(&buf, &cli_status) || cli_status != 0) goto tear_down_tmpiptchains; - iptablesLinkTmpRootChains(conn, IPTABLES_CMD, &buf, ifname); - iptablesSetupVirtInPost(conn, IPTABLES_CMD, &buf, ifname); - if (ebiptablesExecCLI(conn, &buf, &cli_status) || cli_status != 0) + iptablesLinkTmpRootChains(IPTABLES_CMD, &buf, ifname); + iptablesSetupVirtInPost(IPTABLES_CMD, &buf, ifname); + if (ebiptablesExecCLI(&buf, &cli_status) || cli_status != 0) goto tear_down_tmpiptchains; for (i = 0; i < nruleInstances; i++) { if (inst[i]->ruleType == RT_IPTABLES) - iptablesInstCommand(conn, &buf, + iptablesInstCommand(&buf, inst[i]->commandTemplate, 'A', -1, 1); } - if (ebiptablesExecCLI(conn, &buf, &cli_status) || cli_status != 0) + if (ebiptablesExecCLI(&buf, &cli_status) || cli_status != 0) goto tear_down_tmpiptchains; } if (haveIp6tables) { - iptablesUnlinkTmpRootChains(conn, IP6TABLES_CMD, &buf, ifname); - iptablesRemoveTmpRootChains(conn, IP6TABLES_CMD, &buf, ifname); + iptablesUnlinkTmpRootChains(IP6TABLES_CMD, &buf, ifname); + iptablesRemoveTmpRootChains(IP6TABLES_CMD, &buf, ifname); - iptablesCreateBaseChains(conn, IP6TABLES_CMD, &buf); + iptablesCreateBaseChains(IP6TABLES_CMD, &buf); - if (ebiptablesExecCLI(conn, &buf, &cli_status) || cli_status != 0) + if (ebiptablesExecCLI(&buf, &cli_status) || cli_status != 0) goto tear_down_tmpiptchains; - iptablesCreateTmpRootChains(conn, IP6TABLES_CMD, &buf, ifname); + iptablesCreateTmpRootChains(IP6TABLES_CMD, &buf, ifname); - if (ebiptablesExecCLI(conn, &buf, &cli_status) || cli_status != 0) + if (ebiptablesExecCLI(&buf, &cli_status) || cli_status != 0) goto tear_down_tmpip6tchains; - iptablesLinkTmpRootChains(conn, IP6TABLES_CMD, &buf, ifname); - iptablesSetupVirtInPost(conn, IP6TABLES_CMD, &buf, ifname); - if (ebiptablesExecCLI(conn, &buf, &cli_status) || cli_status != 0) + iptablesLinkTmpRootChains(IP6TABLES_CMD, &buf, ifname); + iptablesSetupVirtInPost(IP6TABLES_CMD, &buf, ifname); + if (ebiptablesExecCLI(&buf, &cli_status) || cli_status != 0) goto tear_down_tmpip6tchains; for (i = 0; i < nruleInstances; i++) { if (inst[i]->ruleType == RT_IP6TABLES) - iptablesInstCommand(conn, &buf, + iptablesInstCommand(&buf, inst[i]->commandTemplate, 'A', -1, 1); } - if (ebiptablesExecCLI(conn, &buf, &cli_status) || cli_status != 0) + if (ebiptablesExecCLI(&buf, &cli_status) || cli_status != 0) goto tear_down_tmpip6tchains; } @@ -2745,39 +2606,39 @@ ebiptablesApplyNewRules(virConnectPtr co // END IPTABLES stuff if (chains_in != 0) - ebtablesLinkTmpRootChain(conn, &buf, 1, ifname, 1); + ebtablesLinkTmpRootChain(&buf, 1, ifname, 1); if (chains_out != 0) - ebtablesLinkTmpRootChain(conn, &buf, 0, ifname, 1); + ebtablesLinkTmpRootChain(&buf, 0, ifname, 1); - if (ebiptablesExecCLI(conn, &buf, &cli_status) || cli_status != 0) + if (ebiptablesExecCLI(&buf, &cli_status) || cli_status != 0) goto tear_down_ebsubchains_and_unlink; return 0; tear_down_ebsubchains_and_unlink: - ebtablesUnlinkTmpRootChain(conn, &buf, 1, ifname); - ebtablesUnlinkTmpRootChain(conn, &buf, 0, ifname); + ebtablesUnlinkTmpRootChain(&buf, 1, ifname); + ebtablesUnlinkTmpRootChain(&buf, 0, ifname); tear_down_tmpip6tchains: if (haveIp6tables) { - iptablesUnlinkTmpRootChains(conn, IP6TABLES_CMD, &buf, ifname); - iptablesRemoveTmpRootChains(conn, IP6TABLES_CMD, &buf, ifname); + iptablesUnlinkTmpRootChains(IP6TABLES_CMD, &buf, ifname); + iptablesRemoveTmpRootChains(IP6TABLES_CMD, &buf, ifname); } tear_down_tmpiptchains: if (haveIptables) { - iptablesUnlinkTmpRootChains(conn, IPTABLES_CMD, &buf, ifname); - iptablesRemoveTmpRootChains(conn, IPTABLES_CMD, &buf, ifname); + iptablesUnlinkTmpRootChains(IPTABLES_CMD, &buf, ifname); + iptablesRemoveTmpRootChains(IPTABLES_CMD, &buf, ifname); } tear_down_tmpebchains: - ebtablesRemoveTmpSubChains(conn, &buf, ifname); - ebtablesRemoveTmpRootChain(conn, &buf, 1, ifname); - ebtablesRemoveTmpRootChain(conn, &buf, 0, ifname); + ebtablesRemoveTmpSubChains(&buf, ifname); + ebtablesRemoveTmpRootChain(&buf, 1, ifname); + ebtablesRemoveTmpRootChain(&buf, 0, ifname); - ebiptablesExecCLI(conn, &buf, &cli_status); + ebiptablesExecCLI(&buf, &cli_status); - virNWFilterReportError(conn, VIR_ERR_BUILD_FIREWALL, + virNWFilterReportError(VIR_ERR_BUILD_FIREWALL, "%s", _("Some rules could not be created.")); @@ -2786,64 +2647,64 @@ tear_down_tmpebchains: static int -ebiptablesTearNewRules(virConnectPtr conn, +ebiptablesTearNewRules(virConnectPtr conn ATTRIBUTE_UNUSED, const char *ifname) { int cli_status; virBuffer buf = VIR_BUFFER_INITIALIZER; - iptablesUnlinkTmpRootChains(conn, IPTABLES_CMD, &buf, ifname); - iptablesRemoveTmpRootChains(conn, IPTABLES_CMD, &buf, ifname); + iptablesUnlinkTmpRootChains(IPTABLES_CMD, &buf, ifname); + iptablesRemoveTmpRootChains(IPTABLES_CMD, &buf, ifname); - iptablesUnlinkTmpRootChains(conn, IP6TABLES_CMD, &buf, ifname); - iptablesRemoveTmpRootChains(conn, IP6TABLES_CMD, &buf, ifname); + iptablesUnlinkTmpRootChains(IP6TABLES_CMD, &buf, ifname); + iptablesRemoveTmpRootChains(IP6TABLES_CMD, &buf, ifname); - ebtablesUnlinkTmpRootChain(conn, &buf, 1, ifname); - ebtablesUnlinkTmpRootChain(conn, &buf, 0, ifname); + ebtablesUnlinkTmpRootChain(&buf, 1, ifname); + ebtablesUnlinkTmpRootChain(&buf, 0, ifname); - ebtablesRemoveTmpSubChains(conn, &buf, ifname); - ebtablesRemoveTmpRootChain(conn, &buf, 1, ifname); - ebtablesRemoveTmpRootChain(conn, &buf, 0, ifname); + ebtablesRemoveTmpSubChains(&buf, ifname); + ebtablesRemoveTmpRootChain(&buf, 1, ifname); + ebtablesRemoveTmpRootChain(&buf, 0, ifname); - ebiptablesExecCLI(conn, &buf, &cli_status); + ebiptablesExecCLI(&buf, &cli_status); return 0; } static int -ebiptablesTearOldRules(virConnectPtr conn, +ebiptablesTearOldRules(virConnectPtr conn ATTRIBUTE_UNUSED, const char *ifname) { int cli_status; virBuffer buf = VIR_BUFFER_INITIALIZER; // switch to new iptables user defined chains - iptablesUnlinkRootChains(conn, IPTABLES_CMD, &buf, ifname); - iptablesRemoveRootChains(conn, IPTABLES_CMD, &buf, ifname); + iptablesUnlinkRootChains(IPTABLES_CMD, &buf, ifname); + iptablesRemoveRootChains(IPTABLES_CMD, &buf, ifname); - iptablesRenameTmpRootChains(conn, IPTABLES_CMD, &buf, ifname); - ebiptablesExecCLI(conn, &buf, &cli_status); + iptablesRenameTmpRootChains(IPTABLES_CMD, &buf, ifname); + ebiptablesExecCLI(&buf, &cli_status); - iptablesUnlinkRootChains(conn, IP6TABLES_CMD, &buf, ifname); - iptablesRemoveRootChains(conn, IP6TABLES_CMD, &buf, ifname); + iptablesUnlinkRootChains(IP6TABLES_CMD, &buf, ifname); + iptablesRemoveRootChains(IP6TABLES_CMD, &buf, ifname); - iptablesRenameTmpRootChains(conn, IP6TABLES_CMD, &buf, ifname); - ebiptablesExecCLI(conn, &buf, &cli_status); + iptablesRenameTmpRootChains(IP6TABLES_CMD, &buf, ifname); + ebiptablesExecCLI(&buf, &cli_status); - ebtablesUnlinkRootChain(conn, &buf, 1, ifname); - ebtablesUnlinkRootChain(conn, &buf, 0, ifname); + ebtablesUnlinkRootChain(&buf, 1, ifname); + ebtablesUnlinkRootChain(&buf, 0, ifname); - ebtablesRemoveSubChains(conn, &buf, ifname); + ebtablesRemoveSubChains(&buf, ifname); - ebtablesRemoveRootChain(conn, &buf, 1, ifname); - ebtablesRemoveRootChain(conn, &buf, 0, ifname); + ebtablesRemoveRootChain(&buf, 1, ifname); + ebtablesRemoveRootChain(&buf, 0, ifname); - ebtablesRenameTmpSubChains(conn, &buf, ifname); - ebtablesRenameTmpRootChain(conn, &buf, 1, ifname); - ebtablesRenameTmpRootChain(conn, &buf, 0, ifname); + ebtablesRenameTmpSubChains(&buf, ifname); + ebtablesRenameTmpRootChain(&buf, 1, ifname); + ebtablesRenameTmpRootChain(&buf, 0, ifname); - ebiptablesExecCLI(conn, &buf, &cli_status); + ebiptablesExecCLI(&buf, &cli_status); return 0; } @@ -2862,7 +2723,7 @@ ebiptablesTearOldRules(virConnectPtr con * commands failed. */ static int -ebiptablesRemoveRules(virConnectPtr conn, +ebiptablesRemoveRules(virConnectPtr conn ATTRIBUTE_UNUSED, const char *ifname ATTRIBUTE_UNUSED, int nruleInstances, void **_inst) @@ -2874,16 +2735,16 @@ ebiptablesRemoveRules(virConnectPtr conn ebiptablesRuleInstPtr *inst = (ebiptablesRuleInstPtr *)_inst; for (i = 0; i < nruleInstances; i++) - ebiptablesInstCommand(conn, &buf, + ebiptablesInstCommand(&buf, inst[i]->commandTemplate, 'D', -1, 0); - if (ebiptablesExecCLI(conn, &buf, &cli_status)) + if (ebiptablesExecCLI(&buf, &cli_status)) goto err_exit; if (cli_status) { - virNWFilterReportError(conn, VIR_ERR_BUILD_FIREWALL, + virNWFilterReportError(VIR_ERR_BUILD_FIREWALL, "%s", _("error while executing CLI commands")); rc = 1; @@ -2908,25 +2769,24 @@ ebiptablesAllTeardown(const char *ifname { virBuffer buf = VIR_BUFFER_INITIALIZER; int cli_status; - virConnectPtr conn = NULL; - iptablesUnlinkRootChains(conn, IPTABLES_CMD, &buf, ifname); - iptablesClearVirtInPost (conn, IPTABLES_CMD, &buf, ifname); - iptablesRemoveRootChains(conn, IPTABLES_CMD, &buf, ifname); + iptablesUnlinkRootChains(IPTABLES_CMD, &buf, ifname); + iptablesClearVirtInPost (IPTABLES_CMD, &buf, ifname); + iptablesRemoveRootChains(IPTABLES_CMD, &buf, ifname); - iptablesUnlinkRootChains(conn, IP6TABLES_CMD, &buf, ifname); - iptablesClearVirtInPost (conn, IP6TABLES_CMD, &buf, ifname); - iptablesRemoveRootChains(conn, IP6TABLES_CMD, &buf, ifname); + iptablesUnlinkRootChains(IP6TABLES_CMD, &buf, ifname); + iptablesClearVirtInPost (IP6TABLES_CMD, &buf, ifname); + iptablesRemoveRootChains(IP6TABLES_CMD, &buf, ifname); - ebtablesUnlinkRootChain(conn, &buf, 1, ifname); - ebtablesUnlinkRootChain(conn, &buf, 0, ifname); + ebtablesUnlinkRootChain(&buf, 1, ifname); + ebtablesUnlinkRootChain(&buf, 0, ifname); - ebtablesRemoveRootChain(conn, &buf, 1, ifname); - ebtablesRemoveRootChain(conn, &buf, 0, ifname); + ebtablesRemoveRootChain(&buf, 1, ifname); + ebtablesRemoveRootChain(&buf, 0, ifname); - ebtablesRemoveSubChains(conn, &buf, ifname); + ebtablesRemoveSubChains(&buf, ifname); - ebiptablesExecCLI(conn, &buf, &cli_status); + ebiptablesExecCLI(&buf, &cli_status); return 0; } Index: libvirt-acl/src/conf/nwfilter_params.c =================================================================== --- libvirt-acl.orig/src/conf/nwfilter_params.c +++ libvirt-acl/src/conf/nwfilter_params.c @@ -153,7 +153,6 @@ virNWFilterHashTableRemoveEntry(virNWFil struct addToTableStruct { virNWFilterHashTablePtr target; int errOccurred; - virConnectPtr conn; }; @@ -174,7 +173,7 @@ addToTable(void *payload, const char *na } if (virNWFilterHashTablePut(atts->target, name, val, 1) != 0) { - virNWFilterReportError(atts->conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, _("Could not put variable '%s' into hashmap"), name); atts->errOccurred = 1; @@ -184,14 +183,12 @@ addToTable(void *payload, const char *na int -virNWFilterHashTablePutAll(virConnectPtr conn, - virNWFilterHashTablePtr src, +virNWFilterHashTablePutAll(virNWFilterHashTablePtr src, virNWFilterHashTablePtr dest) { struct addToTableStruct atts = { .target = dest, .errOccurred = 0, - .conn = conn, }; virHashForEach(src->hashTable, addToTable, &atts); Index: libvirt-acl/tests/nwfilterxml2xmltest.c =================================================================== --- libvirt-acl.orig/tests/nwfilterxml2xmltest.c +++ libvirt-acl/tests/nwfilterxml2xmltest.c @@ -39,7 +39,7 @@ static int testCompareXMLToXMLFiles(cons if (!(dev = virNWFilterDefParseString(NULL, inXmlData))) goto fail; - if (!(actual = virNWFilterDefFormat(NULL, dev))) + if (!(actual = virNWFilterDefFormat(dev))) goto fail; if (STRNEQ(outXmlData, actual)) { Index: libvirt-acl/src/conf/nwfilter_params.h =================================================================== --- libvirt-acl.orig/src/conf/nwfilter_params.h +++ libvirt-acl/src/conf/nwfilter_params.h @@ -46,8 +46,7 @@ int virNWFilterHashTablePut(virNWFilterH int freeName); int virNWFilterHashTableRemoveEntry(virNWFilterHashTablePtr table, const char *name); -int virNWFilterHashTablePutAll(virConnectPtr conn, - virNWFilterHashTablePtr src, +int virNWFilterHashTablePutAll(virNWFilterHashTablePtr src, virNWFilterHashTablePtr dest); # define VALID_VARNAME \ Index: libvirt-acl/src/nwfilter/nwfilter_gentech_driver.c =================================================================== --- libvirt-acl.orig/src/nwfilter/nwfilter_gentech_driver.c +++ libvirt-acl/src/nwfilter/nwfilter_gentech_driver.c @@ -62,7 +62,6 @@ virNWFilterTechDriverForName(const char /** * virNWFilterRuleInstAddData: - * @conn : pointer to virConnect object * @res : pointer to virNWFilterRuleInst object collecting the instantiation * data of a single firewall rule. * @data : the opaque data that the driver wants to add @@ -77,8 +76,7 @@ virNWFilterTechDriverForName(const char * message attached to the virConnect object. */ int -virNWFilterRuleInstAddData(virConnectPtr conn ATTRIBUTE_UNUSED, - virNWFilterRuleInstPtr res, +virNWFilterRuleInstAddData(virNWFilterRuleInstPtr res, void *data) { if (VIR_REALLOC_N(res->data, res->ndata+1) < 0) { @@ -107,7 +105,6 @@ virNWFilterRuleInstFree(virNWFilterRuleI /** * virNWFilterVarHashmapAddStdValues: - * @conn: Poijter to virConnect object * @tables: pointer to hash tabel to add values to * @macaddr: The string of the MAC address to add to the hash table, * may be NULL @@ -118,15 +115,14 @@ virNWFilterRuleInstFree(virNWFilterRuleI * Adds a couple of standard keys (MAC, IP) to the hash table. */ static int -virNWFilterVarHashmapAddStdValues(virConnectPtr conn, - virNWFilterHashTablePtr table, +virNWFilterVarHashmapAddStdValues(virNWFilterHashTablePtr table, char *macaddr) { if (macaddr) { if (virHashAddEntry(table->hashTable, NWFILTER_STD_VAR_MAC, macaddr) < 0) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Could not add variable 'MAC' to hashmap")); return 1; } @@ -138,7 +134,6 @@ virNWFilterVarHashmapAddStdValues(virCon /** * virNWFilterCreateVarHashmap: - * @conn: pointer to virConnect object * @macaddr: pointer to string containing formatted MAC address of interface * * Create a hashmap used for evaluating the firewall rules. Initializes @@ -148,15 +143,14 @@ virNWFilterVarHashmapAddStdValues(virCon * is attached to the virConnect object. */ virNWFilterHashTablePtr -virNWFilterCreateVarHashmap(virConnectPtr conn, - char *macaddr) { +virNWFilterCreateVarHashmap(char *macaddr) { virNWFilterHashTablePtr table = virNWFilterHashTableCreate(0); if (!table) { virReportOOMError(); return NULL; } - if (virNWFilterVarHashmapAddStdValues(conn, table, macaddr)) { + if (virNWFilterVarHashmapAddStdValues(table, macaddr)) { virNWFilterHashTableFree(table); return NULL; } @@ -216,7 +210,6 @@ virNWFilterRuleInstantiate(virConnectPtr /** * virNWFilterCreateVarsFrom: - * @conn: pointer to virConnect object * @vars1: pointer to hash table * @vars2: pointer to hash table * @@ -227,8 +220,7 @@ virNWFilterRuleInstantiate(virConnectPtr * contents of var2 will overwrite those of var1. */ static virNWFilterHashTablePtr -virNWFilterCreateVarsFrom(virConnectPtr conn, - virNWFilterHashTablePtr vars1, +virNWFilterCreateVarsFrom(virNWFilterHashTablePtr vars1, virNWFilterHashTablePtr vars2) { virNWFilterHashTablePtr res = virNWFilterHashTableCreate(0); @@ -237,10 +229,10 @@ virNWFilterCreateVarsFrom(virConnectPtr return NULL; } - if (virNWFilterHashTablePutAll(conn, vars1, res)) + if (virNWFilterHashTablePutAll(vars1, res)) goto err_exit; - if (virNWFilterHashTablePutAll(conn, vars2, res)) + if (virNWFilterHashTablePutAll(vars2, res)) goto err_exit; return res; @@ -324,7 +316,7 @@ _virNWFilterInstantiateRec(virConnectPtr if (obj) { if (obj->wantRemoved) { - virNWFilterReportError(conn, VIR_ERR_NO_NWFILTER, + virNWFilterReportError(VIR_ERR_NO_NWFILTER, _("Filter '%s' is in use."), inc->filterref); rc = 1; @@ -334,8 +326,7 @@ _virNWFilterInstantiateRec(virConnectPtr // create a temporary hashmap for depth-first tree traversal virNWFilterHashTablePtr tmpvars = - virNWFilterCreateVarsFrom(conn, - inc->params, + virNWFilterCreateVarsFrom(inc->params, vars); if (!tmpvars) { virReportOOMError(); @@ -373,7 +364,7 @@ _virNWFilterInstantiateRec(virConnectPtr if (rc) break; } else { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, _("referenced filter '%s' is missing"), inc->filterref); rc = 1; @@ -516,7 +507,7 @@ _virNWFilterInstantiateFilter(virConnect techdriver = virNWFilterTechDriverForName(drvname); if (!techdriver) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, _("Could not get access to ACL tech " "driver '%s'"), drvname); @@ -527,14 +518,14 @@ _virNWFilterInstantiateFilter(virConnect obj = virNWFilterPoolObjFindByName(&driver->pools, net->filter); if (!obj) { - virNWFilterReportError(conn, VIR_ERR_NO_NWFILTER, + virNWFilterReportError(VIR_ERR_NO_NWFILTER, _("Could not find filter '%s'"), net->filter); return 1; } if (obj->wantRemoved) { - virNWFilterReportError(conn, VIR_ERR_NO_NWFILTER, + virNWFilterReportError(VIR_ERR_NO_NWFILTER, _("Filter '%s' is in use."), net->filter); rc = 1; @@ -549,8 +540,7 @@ _virNWFilterInstantiateFilter(virConnect goto err_exit; } - vars1 = virNWFilterCreateVarHashmap(conn, - str_macaddr); + vars1 = virNWFilterCreateVarHashmap(str_macaddr); if (!vars1) { rc = 1; goto err_exit; @@ -558,8 +548,7 @@ _virNWFilterInstantiateFilter(virConnect str_macaddr = NULL; - vars = virNWFilterCreateVarsFrom(conn, - vars1, + vars = virNWFilterCreateVarsFrom(vars1, net->filterparams); if (!vars) { rc = 1; @@ -630,7 +619,7 @@ int virNWFilterRollbackUpdateFilter(virC virNWFilterTechDriverPtr techdriver; techdriver = virNWFilterTechDriverForName(drvname); if (!techdriver) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, _("Could not get access to ACL tech " "driver '%s'"), drvname); @@ -649,7 +638,7 @@ virNWFilterTearOldFilter(virConnectPtr c virNWFilterTechDriverPtr techdriver; techdriver = virNWFilterTechDriverForName(drvname); if (!techdriver) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, _("Could not get access to ACL tech " "driver '%s'"), drvname); @@ -668,12 +657,10 @@ virNWFilterTeardownFilter(const virDomai techdriver = virNWFilterTechDriverForName(drvname); if (!techdriver) { -#if 0 - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, _("Could not get access to ACL tech " "driver '%s'"), drvname); -#endif return 1; } Index: libvirt-acl/src/nwfilter/nwfilter_gentech_driver.h =================================================================== --- libvirt-acl.orig/src/nwfilter/nwfilter_gentech_driver.h +++ libvirt-acl/src/nwfilter/nwfilter_gentech_driver.h @@ -25,8 +25,7 @@ virNWFilterTechDriverPtr virNWFilterTechDriverForName(const char *name); -int virNWFilterRuleInstAddData(virConnectPtr conn, - virNWFilterRuleInstPtr res, +int virNWFilterRuleInstAddData(virNWFilterRuleInstPtr res, void *data); @@ -48,8 +47,7 @@ int virNWFilterTearOldFilter(virConnectP int virNWFilterTeardownFilter(const virDomainNetDefPtr net); -virNWFilterHashTablePtr virNWFilterCreateVarHashmap(virConnectPtr conn, - char *macaddr); +virNWFilterHashTablePtr virNWFilterCreateVarHashmap(char *macaddr); void virNWFilterDomainFWUpdateCB(void *payload, const char *name ATTRIBUTE_UNUSED,

2 1

[libvirt] [PATCH] Eliminate compiler warning about non-const format string
by Laine Stump 05 Apr '10

05 Apr '10

--- src/nwfilter/nwfilter_ebiptables_driver.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/nwfilter/nwfilter_ebiptables_driver.c b/src/nwfilter/nwfilter_ebiptables_driver.c index 6d66543..cffe027 100644 --- a/src/nwfilter/nwfilter_ebiptables_driver.c +++ b/src/nwfilter/nwfilter_ebiptables_driver.c @@ -204,7 +204,7 @@ _printDataType(virConnectPtr conn, case DATATYPE_IPMASK: if (snprintf(buf, bufsize, "%d", item->u.u8) >= bufsize) { - virNWFilterReportError(conn, VIR_ERR_INVALID_NWFILTER, + virNWFilterReportError(conn, VIR_ERR_INVALID_NWFILTER, "%s", _("Buffer too small for uint8 type")); return 1; } -- 1.6.6.1

2 2

[libvirt] [PATCH] xenapi: Add managedsave entries to the driver struct
by Matthias Bolte 05 Apr '10

05 Apr '10

Commit 15c647a91e8c5bcfcb02ac4e755160c5c99a2a1e added the new managedsave entries to all driver structs except the XenAPI one. --- I just pushed this patch. src/xenapi/xenapi_driver.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/xenapi/xenapi_driver.c b/src/xenapi/xenapi_driver.c index dcfdc1e..240aa16 100644 --- a/src/xenapi/xenapi_driver.c +++ b/src/xenapi/xenapi_driver.c @@ -1783,6 +1783,9 @@ static virDriver xenapiDriver = { NULL, /* domainMigrateSetMaxDowntime */ NULL, /* domainEventRegisterAny */ NULL, /* domainEventDeregisterAny */ + NULL, /* domainManagedSave */ + NULL, /* domainHasManagedSaveImage */ + NULL, /* domainManagedSaveRemove */ }; /** -- 1.6.3.3

2 1

[libvirt] [PATCH] nwfilter: Fix random index in virNWFilterRuleDefDetailsFormat
by Matthias Bolte 05 Apr '10

05 Apr '10

An uninitialized int value was used to index an array. This can result in a segfault in nwfilterxml2xmltest. --- src/conf/nwfilter_conf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c index 08934fb..7c71ece 100644 --- a/src/conf/nwfilter_conf.c +++ b/src/conf/nwfilter_conf.c @@ -2375,7 +2375,7 @@ virNWFilterRuleDefDetailsFormat(virConnectPtr conn, const virXMLAttr2Struct *att, virNWFilterRuleDefPtr def) { - int i, j; + int i = 0, j; bool typeShown = 0; bool neverShown = 1; enum match { -- 1.6.3.3

2 2

[libvirt] [PATCH] xenapi: Fix uninitialized variable warning
by Matthias Bolte 05 Apr '10

05 Apr '10

--- src/xenapi/xenapi_utils.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/xenapi/xenapi_utils.c b/src/xenapi/xenapi_utils.c index 581bd90..4eb17fa 100644 --- a/src/xenapi/xenapi_utils.c +++ b/src/xenapi/xenapi_utils.c @@ -405,7 +405,7 @@ createVifNetwork (virConnectPtr conn, xen_vm vm, char *device, vm_opt->u.handle = xvm; xen_network_set *net_set = NULL; xen_network_record *net_rec = NULL; - int cnt; + int cnt = 0; if (xen_network_get_all(session, &net_set)) { for(cnt = 0; cnt < net_set->size; cnt++) { if (xen_network_get_record(session, &net_rec, net_set->contents[cnt])) { -- 1.6.3.3

2 2

[libvirt] [PATCH] nwfilter: Get rid of regular expressions for testing of var names and values
by Stefan Berger 04 Apr '10

04 Apr '10

Get rid of the regular expressions when evaluating variable names and values. Rather use the strspn() function. Along with this cleanup the initialization function for the code that used the regular expression can also be removed. Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com> --- src/conf/nwfilter_conf.c | 5 ---- src/conf/nwfilter_conf.h | 3 -- src/conf/nwfilter_params.c | 50 +++++++++++++++------------------------------ src/conf/nwfilter_params.h | 6 +++++ 4 files changed, 24 insertions(+), 40 deletions(-) Index: libvirt-acl/src/conf/nwfilter_conf.h =================================================================== --- libvirt-acl.orig/src/conf/nwfilter_conf.h +++ libvirt-acl/src/conf/nwfilter_conf.h @@ -568,9 +568,6 @@ void virNWFilterPoolObjUnlock(virNWFilte int virNWFilterConfLayerInit(virHashIterator domUpdateCB); void virNWFilterConfLayerShutdown(void); -int virNWFilterParamConfLayerInit(void); -void virNWFilterParamConfLayerShutdown(void); - # define virNWFilterReportError(conn, code, fmt...) \ (void)conn; \ virReportErrorHelper(NULL, VIR_FROM_NWFILTER, code, __FILE__, \ Index: libvirt-acl/src/conf/nwfilter_params.c =================================================================== --- libvirt-acl.orig/src/conf/nwfilter_params.c +++ libvirt-acl/src/conf/nwfilter_params.c @@ -22,8 +22,6 @@ #include <config.h> -#include <regex.h> - #include "internal.h" #include "memory.h" @@ -35,13 +33,6 @@ #define VIR_FROM_THIS VIR_FROM_NWFILTER -/* - * regular expressions for parameter names and values - */ -static regex_t regex_nam; -static regex_t regex_val; - - static void hashDealloc(void *payload, const char *name ATTRIBUTE_UNUSED) { @@ -215,6 +206,21 @@ err_exit: #ifndef PROXY + +static bool +isValidVarName(const char *var) +{ + return var[strspn(var, VALID_VARNAME)] == 0; +} + + +static bool +isValidVarValue(const char *value) +{ + return value[strspn(value, VALID_VARVALUE)] == 0; +} + + virNWFilterHashTablePtr virNWFilterParseParamAttributes(xmlNodePtr cur) { @@ -234,9 +240,9 @@ virNWFilterParseParamAttributes(xmlNodeP nam = virXMLPropString(cur, "name"); val = virXMLPropString(cur, "value"); if (nam != NULL && val != NULL) { - if (regexec(&regex_nam, nam, 0, NULL, 0) != 0) + if (!isValidVarName(nam)) goto skip_entry; - if (regexec(&regex_val, val, 0, NULL, 0) != 0) + if (!isValidVarValue(nam)) goto skip_entry; if (virNWFilterHashTablePut(table, nam, val, 1)) { VIR_FREE(nam); @@ -296,25 +302,3 @@ virNWFilterFormatParamAttributes(virNWFi return virBufferContentAndReset(&buf); } - - -int virNWFilterParamConfLayerInit(void) { - - if (regcomp(&regex_nam, "^[a-zA-Z0-9_]+$" , - REG_NOSUB|REG_EXTENDED) != 0) - return 1; - - if (regcomp(&regex_val, "^[a-zA-Z0-9_.:]+$", - REG_NOSUB|REG_EXTENDED) != 0) { - regfree(&regex_nam); - return 1; - } - - return 0; -} - - -void virNWFilterParamConfLayerShutdown(void) { - regfree(&regex_nam); - regfree(&regex_val); -} Index: libvirt-acl/src/conf/nwfilter_params.h =================================================================== --- libvirt-acl.orig/src/conf/nwfilter_params.h +++ libvirt-acl/src/conf/nwfilter_params.h @@ -50,4 +50,10 @@ int virNWFilterHashTablePutAll(virConnec virNWFilterHashTablePtr src, virNWFilterHashTablePtr dest); +#define VALID_VARNAME \ + "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789_" + +#define VALID_VARVALUE \ + "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789_.:" + #endif /* NWFILTER_PARAMS_H */ Index: libvirt-acl/src/conf/nwfilter_conf.c =================================================================== --- libvirt-acl.orig/src/conf/nwfilter_conf.c +++ libvirt-acl/src/conf/nwfilter_conf.c @@ -2634,16 +2634,13 @@ int virNWFilterConfLayerInit(virHashIter if (virMutexInit(&updateMutex)) return 1; - if (virNWFilterParamConfLayerInit()) - return 1; - return 0; } void virNWFilterConfLayerShutdown(void) { - virNWFilterParamConfLayerShutdown(); + virMutexDestroy(&updateMutex); }

2 1

[libvirt] [RFC PATCH 0/8]: Domain Snapshot API
by Chris Lalancette 03 Apr '10

03 Apr '10

Hello, Here is the first set of RFC patches for the snapshot API. Note that this definitely isn't finished; in particular, we are going to be changing the semantic for virDomainCreateFromSnapshot, and there are still a couple of known outstanding bugs. Nevertheless, that will probably be pretty minor in terms of code, so we'd like to get review on the rest of these patches for now. I've broken the series down along lines that I believe will compile independently, though I haven't yet done a git-bisect to confirm. Unfortunately it leaves patch 3/8 as a monster patch implementing the skeleton and remote driver. The good news is that it is mostly mechanical. Suggestions for how to better split it up are welcome. Thanks go to Jirka for lots of code contribution to this series, and all of the others who took part in the discussion of this API. Comments are welcome. Chris Lalancette

3 25

[libvirt] [PATCH] build: improve check for out-of-date .gnulib submodule
by Eric Blake 03 Apr '10

03 Apr '10

git reset --hard 96e5a2d4d5b13bf2cc887562dc11d146b78d5950 ./autogen.sh make -s git pull make -s <-- expecting auto-bootstrap here, doesn't happen Use git diff to expose whether the submodule has untracked changes, which are typical on an incremental pull if .gnulib was updated but the user did not manually run 'git submodule update'. After this patch is applied, I encountered a new problem when following the reproducing pattern. Basically, the change to .gnulib between libvirt's commit 96e5a2d4 and this patch introduced a change to sys_ioctl.in.h, but gnulib (intentionally) does not make the replacement headers depend on Makefile changes. Therefore, I ended up with the generated replacement header being broken: gnulib/lib/sys/ioctl.h complained about a use of @. But that seems like something that should be fixed upstream in gnulib's bootstrap script (that is, when doing a gnulib update, all files created from .in.h file should probably be deleted). Without the benefit of that proposed gnulib fix, I worked around the problem by manually removing the stale gnulib/lib/sys/ioctl.h. * autogen.sh (t): Also run bootstrap if the gnulib submodule needs to be updated. * cfg.mk (_autogen): Likewise. Reported by Matthias Bolte. --- That took a lot longer to fix than I originally expected. But I think this patch fixes the libvirt side of things, so that make will properly rerun autogen when the .gnulib submodule changes. Thanks again to Matthias for boiling it down to a reproducible step. And now I'm off to figure out whether gnulib's bootstrap script could do a better job of deleting any generated headers that might be rendered invalid by an update in gnulib modules. autogen.sh | 2 +- cfg.mk | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/autogen.sh b/autogen.sh index a618d86..2f5b42d 100755 --- a/autogen.sh +++ b/autogen.sh @@ -75,7 +75,7 @@ bootstrap_hash() # Ensure that whenever we pull in a gnulib update or otherwise change to a # different version (i.e., when switching branches), we also rerun ./bootstrap. curr_status=.git-module-status -t=$(bootstrap_hash) +t=$(bootstrap_hash; git diff .gnulib) if test "$t" = "$(cat $curr_status 2>/dev/null)"; then : # good, it's up to date, all we need is autoreconf autoreconf -if diff --git a/cfg.mk b/cfg.mk index b6b2530..74fe5ed 100644 --- a/cfg.mk +++ b/cfg.mk @@ -294,7 +294,8 @@ ifeq (0,$(MAKELEVEL)) _submodule_hash = sed 's/^[ +-]//;s/ .*//' _update_required := $(shell \ actual=$$(git submodule status | $(_submodule_hash); \ - git hash-object bootstrap.conf); \ + git hash-object bootstrap.conf; \ + git diff .gnulib); \ stamp="$$($(_submodule_hash) $(_curr_status) 2>/dev/null)"; \ test "$$stamp" = "$$actual"; echo $$?) ifeq (1,$(_update_required)) @@ -303,9 +304,12 @@ Makefile: _autogen endif endif +# It is necessary to call autogen any time gnulib changes. Autogen +# reruns configure, then we regenerate all Makefiles at once. .PHONY: _autogen _autogen: $(srcdir)/autogen.sh + ./config.status # Exempt @...@ uses of these symbols. _makefile_at_at_check_exceptions = ' && !/(SCHEMA|SYSCONF)DIR/' -- 1.6.6.1

2 2

[libvirt] [PATCH] [0/4] Managed save APIs
by Daniel Veillard 03 Apr '10

03 Apr '10

As posted earlier, I have implemented the small set of managed save APIs, where libvirt stores the domain state itself and can then recover that state when the domain is started up. I think the code is complete, but not really tested (I still need to debug a failure which seems unrelated), with the exception of the virsh commands which probably need to be extended for convenience. Also I implemented it only for the qemu driver, I would not be surprized if an ESX backend could be implemented since there is no file path in this API. More documentation is needed too. Thanks Chris Lalancette who wrote a large part of this code ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

3 8

[libvirt] [PATCH 0/3] Add dnsmasq module
by Satoru SATOH 03 Apr '10

03 Apr '10

The following series of patches is a prototype implementation of dnsmasq module. It implements an idea originally suggested by Daniel-san and can address the problem that too many --dhcp-host args hitting ARG_MAX limit I reported last year [1]. [1] https://www.redhat.com/archives/libvir-list/2009-October/msg00216.html Thanks, Satoru SATOH

1 3

[libvirt] [PATCH] Optimization of the check for valid interface name
by Stefan Berger 03 Apr '10

03 Apr '10

The attached patch optimizes the validation of the name of an interface. Signed-off-by: Stefan Berger Index: libvirt-acl/src/conf/domain_conf.c =================================================================== --- libvirt-acl.orig/src/conf/domain_conf.c +++ libvirt-acl/src/conf/domain_conf.c @@ -1795,7 +1795,7 @@ cleanup: static bool isValidIfname(const char *ifname) { - return (strspn(ifname, VALID_IFNAME_CHARS) == strlen(ifname)); + return ifname[strspn(ifname, VALID_IFNAME_CHARS)] == 0; }

3 2

[libvirt] [PATCH] Use virStrToLong_ui rather than virStrToLong_i where possible
by Stefan Berger 03 Apr '10

03 Apr '10

Use the virStrToLong_ui() function rather than the virStrToLong_i() where possible. Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com> --- src/conf/nwfilter_conf.c | 33 +++++++++++++++++---------------- 1 file changed, 17 insertions(+), 16 deletions(-) Index: libvirt-acl/src/conf/nwfilter_conf.c =================================================================== --- libvirt-acl.orig/src/conf/nwfilter_conf.c +++ libvirt-acl/src/conf/nwfilter_conf.c @@ -1126,6 +1126,7 @@ virNWFilterRuleDetailsParse(virConnectPt enum virNWFilterEntryItemFlags *flags ,match_flag = 0, flags_set = 0; nwItemDesc *item; int int_val; + unsigned int uint_val; void *data_ptr, *storage_ptr; valueValidator validator; char *match = virXMLPropString(node, "match"); @@ -1175,12 +1176,12 @@ virNWFilterRuleDetailsParse(virConnectPt case DATATYPE_UINT8: storage_ptr = &item->u.u8; - if (virStrToLong_i(prop, NULL, 10, &int_val) >= 0) { - if (int_val >= 0 && int_val <= 0xff) { + if (virStrToLong_ui(prop, NULL, 10, &uint_val) >= 0) { + if (uint_val <= 0xff) { if (!validator) - *(uint8_t *)storage_ptr = int_val; + *(uint8_t *)storage_ptr = uint_val; found = 1; - data_ptr = &int_val; + data_ptr = &uint_val; } else rc = -1; } else @@ -1189,12 +1190,12 @@ virNWFilterRuleDetailsParse(virConnectPt case DATATYPE_UINT16: storage_ptr = &item->u.u16; - if (virStrToLong_i(prop, NULL, 10, &int_val) >= 0) { - if (int_val >= 0 && int_val <= 0xffff) { + if (virStrToLong_ui(prop, NULL, 10, &uint_val) >= 0) { + if (uint_val <= 0xffff) { if (!validator) - *(uint16_t *)storage_ptr = int_val; + *(uint16_t *)storage_ptr = uint_val; found = 1; - data_ptr = &int_val; + data_ptr = &uint_val; } else rc = -1; } else @@ -1212,13 +1213,13 @@ virNWFilterRuleDetailsParse(virConnectPt case DATATYPE_IPMASK: storage_ptr = &item->u.u8; - if (virStrToLong_i(prop, NULL, 10, &int_val) == 0) { - if (int_val >= 0 && int_val <= 32) { + if (virStrToLong_ui(prop, NULL, 10, &uint_val) == 0) { + if (uint_val <= 32) { if (!validator) *(uint8_t *)storage_ptr = - (uint8_t)int_val; + (uint8_t)uint_val; found = 1; - data_ptr = &int_val; + data_ptr = &uint_val; } else rc = -1; } else { @@ -1266,13 +1267,13 @@ virNWFilterRuleDetailsParse(virConnectPt case DATATYPE_IPV6MASK: storage_ptr = &item->u.u8; - if (virStrToLong_i(prop, NULL, 10, &int_val) == 0) { - if (int_val >= 0 && int_val <= 128) { + if (virStrToLong_ui(prop, NULL, 10, &uint_val) == 0) { + if (uint_val <= 128) { if (!validator) *(uint8_t *)storage_ptr = - (uint8_t)int_val; + (uint8_t)uint_val; found = 1; - data_ptr = &int_val; + data_ptr = &uint_val; } else rc = -1; } else {

2 1

[libvirt] [PATCH v1 0/2] Fixes to network filter rules instantiator + XML parser and XML parser test cases
by Stefan Berger 03 Apr '10

03 Apr '10

The following two patches fix some problems when instantiating the network filtering rules provided by the test cases in the 2nd patch on a running virtual machine using 'nwfilter-define'. There's one known problem realted to 'dscp' values not being capped at '63'. This will be fixed later. Regards, Stefan

2 5

[libvirt] [PATCH] build: import latest gnulib
by Eric Blake 03 Apr '10

03 Apr '10

* .gnulib: Update to latest. * cfg.mk (sc_prohibit_test_minus_ao): Delete, it was moved into gnulib's maint.mk. --- Here's the full list of gnulib changes: * .gnulib 4f01268...e01b458 (44): > maint.mk: check for [ as well as test > gnumakefile: don't squelch _version output > sys_time: avoid compiler warnings > maint.mk: split a long line > maint.mk: s/_header_without_use/_sc_header_without_use/ > maint: improve module indicators > fdopendir: work around FreeBSD bug > Emit #pragma system_header after the inclusion guard, not before. > Fix indentation. > save-cwd: don't leak a file descriptor when the caller execs > Remove vestiges of fts-lgpl module. > Fix definition of tests witness macro. > Fix definition of tests witness macro. > Fix ioctl's protoype on glibc systems. > Normalize copyright line formatting. > exclude: fix the case of globs vs. EXCLUDE_INCLUDE > maint.mk: prohibit use of test's -o and -a operators > Remove unused GNULIB_XYZ macro definitions. > Mark privileged tests modules. > Split C++ tests into separate tests modules. > gnulib-tool: Allow 'foo-tests' module even if there is no module 'foo'. > gnulib-tool: Add support for special categories of tests. > ansi-c++-opt: Allow turning off the C++ build by default. > unistd: Avoid #define replacements in C++ mode. > Fix link errors on mingw. > lib-ignore: Determine different options for different compilers. > Remove unused GNULIB_XYZ macro definitions. > Add a remark about certain modules. > Resolve conflict between the two kinds of module indicators. > autoupdate > Distinguish two kinds of module indicators. > New module description field 'Comment'. > Addendum to 2010-02-07 commit. > Use GNULIB_POSIXCHECK instead of GNULIB_PORTCHECK. > Avoid side effects from tests-related modules on the compilation of lib. > Factorize common .m4 code. > Fix a compilation error on Cygwin with g++ >= 4.3. > Rename gl_GETLOGIN. > Rename gl_GETLOGIN_R. > Rename gl_INET_NTOP. > Rename gl_INET_PTON. > Rename gl_MBSLEN. > Rename gl_FORKPTY and gl_OPENPTY. > top/maint.mk (sc_texinfo_acronym): Don't infloop if there is no *.texi files. .gnulib | 2 +- cfg.mk | 8 -------- 2 files changed, 1 insertions(+), 9 deletions(-) diff --git a/.gnulib b/.gnulib index 4f01268..e01b458 160000 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit 4f01268d0c584c20704e42527f4fa125e7525aae +Subproject commit e01b458f40440e64ce6f59beb0b446219bb6302d diff --git a/cfg.mk b/cfg.mk index 2e7b68a..07360b0 100644 --- a/cfg.mk +++ b/cfg.mk @@ -272,14 +272,6 @@ sc_preprocessor_indentation: echo '$(ME): skipping test $@: cppi not installed' 1>&2; \ fi -_m1 = use "test C1 && test C2", not "test C1 -''a C2" -_m2 = use "test C1 || test C2", not "test C1 -''o C2" -# Using test's -a and -o operators is not portable. -sc_prohibit_test_minus_ao: - @re='(\<test| \[+) .+ -[ao] ' \ - msg='$(_m1); $(_m2)' \ - $(_prohibit_regexp) - sc_copyright_format: @$(VC_LIST_EXCEPT) | xargs grep -ni 'copyright .*Red 'Hat \ | grep -v Inc \ -- 1.6.6.1

2 3

[libvirt] Pushed qemuDomainRestore fix
by Chris Lalancette 03 Apr '10

03 Apr '10

FYI, I just pushed this fix (with blessing from DV): commit d62f4c36c2c28b96952143247a1360e8c18f64c7 Author: Chris Lalancette <clalance(a)redhat.com> Date: Tue Mar 23 09:11:29 2010 -0400 Don't use virFileReadLimFD in qemuDomainRestore. virFileReadLimFD is a poor fit for reading the header of the restore file. The problem is that virFileReadLimFD returns an error when there is more data after the amount you ask to read, but that is *expected* in this case. This patch is essentially a revert of 1a4d5c9543641c444dccd682f6256ee3faf22a80, but I don't think that commit does what it says anyway. It purports to prevent an unwarranted OOM error, but since virFileReadLimFD will allocate memory up to the maximum anyway, the upper limit on the total amount of memory allocated is the same for either the old version or the new version. Since the old saferead actually works and virFileReadLimFD does not, revert to using saferead. Signed-off-by: Chris Lalancette <clalance(a)redhat.com> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 4291bc7..70d2781 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -5547,7 +5547,12 @@ static int qemudDomainRestore(virConnectPtr conn, goto cleanup; } - if (virFileReadLimFD(fd, header.xml_len, &xml) != header.xml_len) { + if (VIR_ALLOC_N(xml, header.xml_len) < 0) { + virReportOOMError(); + goto cleanup; + } + + if (saferead(fd, xml, header.xml_len) != header.xml_len) { qemuReportError(VIR_ERR_OPERATION_FAILED, "%s", _("failed to read XML")); goto cleanup; -- Chris Lalancette

2 1

[libvirt] [PATCH] VBox: Fix use of uninitialized value
by Jiri Denemark 03 Apr '10

03 Apr '10

--- src/vbox/vbox_tmpl.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index 14fdcda..59ad1b8 100644 --- a/src/vbox/vbox_tmpl.c +++ b/src/vbox/vbox_tmpl.c @@ -1570,7 +1570,7 @@ static int vboxDomainDestroy(virDomainPtr dom) { #if VBOX_API_VERSION == 2002 console->vtbl->PowerDown(console); #else - IProgress *progress; + IProgress *progress = NULL; console->vtbl->PowerDown(console, &progress); if (progress) { progress->vtbl->WaitForCompletion(progress, -1); -- 1.7.0.4

2 2

[libvirt] [PATCH] Changes to clock timer XML to match final design.
by Laine Stump 02 Apr '10

02 Apr '10

The clock timer XML is being updated in the following ways (based on further off-list discussion that was missed during the initial implementation): 1) 'wallclock' is changed to 'track', and the possible values are 'boot' (corresponds to old 'host'), 'guest', and 'wall'. 2) 'mode' has an additional value 'smpsafe' 3) when tickpolicy='catchup', there can be an optional sub-element of timer called 'catchup': <catchup threshold=123 slew=120 limit=10000/> Those three values are all longs, always optional, and if they are present, they are positive. Internally, 0 indicates "unspecified". * docs/schemas/domain.rng: updated RNG definition to account for changes * src/conf/domain_conf.h: change the C struct and enums to match changes. * src/conf/domain_conf.c: timer parse and format functions changed to handle the new selections and new element. * src/libvirt_private.syms: *TimerWallclock* changes to *TimerTrack* * src/qemu/qemu_conf.c: again, account for Wallclock --> Track change. --- docs/schemas/domain.rng | 24 +++++++++++- src/conf/domain_conf.c | 89 +++++++++++++++++++++++++++++++++++---------- src/conf/domain_conf.h | 26 ++++++++++---- src/libvirt_private.syms | 4 +- src/qemu/qemu_conf.c | 17 +++++++-- 5 files changed, 126 insertions(+), 34 deletions(-) diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng index d804301..228665c 100644 --- a/docs/schemas/domain.rng +++ b/docs/schemas/domain.rng @@ -344,10 +344,11 @@ </choice> </attribute> <optional> - <attribute name="wallclock"> + <attribute name="track"> <choice> - <value>host</value> + <value>boot</value> <value>guest</value> + <value>wall</value> </choice> </attribute> </optional> @@ -362,6 +363,9 @@ </attribute> </optional> <optional> + <ref name="catchup"/> + </optional> + <optional> <attribute name="frequency"> <ref name="unsignedInt"/> </attribute> @@ -373,6 +377,7 @@ <value>native</value> <value>emulate</value> <value>paravirt</value> + <value>smpsafe</value> </choice> </attribute> </optional> @@ -387,6 +392,21 @@ <empty/> </element> </define> + <define name="catchup"> + <element name="catchup"> + <optional> + <attribute name="threshold"> + <ref name="unsignedInt"/> + </attribute> + <attribute name="slew"> + <ref name="unsignedInt"/> + </attribute> + <attribute name="limit"> + <ref name="unsignedInt"/> + </attribute> + </optional> + </element> + </define> <!-- A bootloader may be used to extract the OS information instead of defining the OS parameter in the instance. It points just to the diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 66aa53e..b8acab9 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -252,9 +252,10 @@ VIR_ENUM_IMPL(virDomainTimerName, VIR_DOMAIN_TIMER_NAME_LAST, "hpet", "tsc"); -VIR_ENUM_IMPL(virDomainTimerWallclock, VIR_DOMAIN_TIMER_WALLCLOCK_LAST, - "host", - "guest"); +VIR_ENUM_IMPL(virDomainTimerTrack, VIR_DOMAIN_TIMER_TRACK_LAST, + "boot", + "guest", + "wall"); VIR_ENUM_IMPL(virDomainTimerTickpolicy, VIR_DOMAIN_TIMER_TICKPOLICY_LAST, "delay", @@ -266,7 +267,8 @@ VIR_ENUM_IMPL(virDomainTimerMode, VIR_DOMAIN_TIMER_MODE_LAST, "auto", "native", "emulate", - "paravirt"); + "paravirt", + "smpsafe"); #define virDomainReportError(code, ...) \ virReportErrorHelper(NULL, VIR_FROM_DOMAIN, code, __FILE__, \ @@ -2555,7 +2557,7 @@ virDomainTimerDefParseXML(const xmlNodePtr node, char *name = NULL; char *present = NULL; char *tickpolicy = NULL; - char *wallclock = NULL; + char *track = NULL; char *mode = NULL; virDomainTimerDefPtr def; @@ -2603,12 +2605,12 @@ virDomainTimerDefParseXML(const xmlNodePtr node, } } - def->wallclock = -1; - wallclock = virXMLPropString(node, "wallclock"); - if (wallclock != NULL) { - if ((def->wallclock = virDomainTimerWallclockTypeFromString(wallclock)) < 0) { + def->track = -1; + track = virXMLPropString(node, "track"); + if (track != NULL) { + if ((def->track = virDomainTimerTrackTypeFromString(track)) < 0) { virDomainReportError(VIR_ERR_INTERNAL_ERROR, - _("unknown timer wallclock '%s'"), wallclock); + _("unknown timer track '%s'"), track); goto error; } } @@ -2616,7 +2618,7 @@ virDomainTimerDefParseXML(const xmlNodePtr node, int ret = virXPathULong("string(./frequency)", ctxt, &def->frequency); if (ret == -1) { def->frequency = 0; - } else if (ret <= 0) { + } else if (ret < 0) { virDomainReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("invalid timer frequency")); goto error; @@ -2632,11 +2634,42 @@ virDomainTimerDefParseXML(const xmlNodePtr node, } } + xmlNodePtr catchup = virXPathNode("./catchup", ctxt); + if (catchup != NULL) { + ret = virXPathULong("string(./catchup/@threshold)", ctxt, + &def->catchup.threshold); + if (ret == -1) { + def->catchup.threshold = 0; + } else if (ret < 0) { + virDomainReportError(VIR_ERR_INTERNAL_ERROR, + "%s", _("invalid catchup threshold")); + goto error; + } + + ret = virXPathULong("string(./catchup/@slew)", ctxt, &def->catchup.slew); + if (ret == -1) { + def->catchup.slew = 0; + } else if (ret < 0) { + virDomainReportError(VIR_ERR_INTERNAL_ERROR, + "%s", _("invalid catchup slew")); + goto error; + } + + ret = virXPathULong("string(./catchup/@limit)", ctxt, &def->catchup.limit); + if (ret == -1) { + def->catchup.limit = 0; + } else if (ret < 0) { + virDomainReportError(VIR_ERR_INTERNAL_ERROR, + "%s", _("invalid catchup limit")); + goto error; + } + } + cleanup: VIR_FREE(name); VIR_FREE(present); VIR_FREE(tickpolicy); - VIR_FREE(wallclock); + VIR_FREE(track); VIR_FREE(mode); ctxt->node = oldnode; @@ -5456,16 +5489,16 @@ virDomainTimerDefFormat(virBufferPtr buf, if ((def->name == VIR_DOMAIN_TIMER_NAME_PLATFORM) || (def->name == VIR_DOMAIN_TIMER_NAME_RTC)) { - if (def->wallclock != -1) { - const char *wallclock - = virDomainTimerWallclockTypeToString(def->wallclock); - if (!wallclock) { + if (def->track != -1) { + const char *track + = virDomainTimerTrackTypeToString(def->track); + if (!track) { virDomainReportError(VIR_ERR_INTERNAL_ERROR, - _("unexpected timer wallclock %d"), - def->wallclock); + _("unexpected timer track %d"), + def->track); return -1; } - virBufferVSprintf(buf, " wallclock='%s'", wallclock); + virBufferVSprintf(buf, " track='%s'", track); } } @@ -5487,7 +5520,23 @@ virDomainTimerDefFormat(virBufferPtr buf, } } - virBufferAddLit(buf, "/>\n"); + if ((def->catchup.threshold == 0) + && (def->catchup.slew == 0) + && (def->catchup.limit == 0)) { + virBufferAddLit(buf, "/>\n"); + } else { + virBufferAddLit(buf, ">\n <catchup "); + if (def->catchup.threshold > 0) { + virBufferVSprintf(buf, " threshold='%lu'", def->catchup.threshold); + } + if (def->catchup.slew > 0) { + virBufferVSprintf(buf, " slew='%lu'", def->catchup.slew); + } + if (def->catchup.limit > 0) { + virBufferVSprintf(buf, " limit='%lu'", def->catchup.limit); + } + virBufferAddLit(buf, "/>\n </timer>\n"); + } return 0; } diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index ed1a4ad..435d546 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -656,11 +656,12 @@ enum virDomainTimerNameType { VIR_DOMAIN_TIMER_NAME_LAST, }; -enum virDomainTimerWallclockType { - VIR_DOMAIN_TIMER_WALLCLOCK_HOST = 0, - VIR_DOMAIN_TIMER_WALLCLOCK_GUEST, +enum virDomainTimerTrackType { + VIR_DOMAIN_TIMER_TRACK_BOOT = 0, + VIR_DOMAIN_TIMER_TRACK_GUEST, + VIR_DOMAIN_TIMER_TRACK_WALL, - VIR_DOMAIN_TIMER_WALLCLOCK_LAST, + VIR_DOMAIN_TIMER_TRACK_LAST, }; enum virDomainTimerTickpolicyType { @@ -677,10 +678,19 @@ enum virDomainTimerModeType { VIR_DOMAIN_TIMER_MODE_NATIVE, VIR_DOMAIN_TIMER_MODE_EMULATE, VIR_DOMAIN_TIMER_MODE_PARAVIRT, + VIR_DOMAIN_TIMER_MODE_SMPSAFE, VIR_DOMAIN_TIMER_MODE_LAST, }; +typedef struct _virDomainTimerCatchupDef virDomainTimerCatchupDef; +typedef virDomainTimerCatchupDef *virDomainTimerCatchupDefPtr; +struct _virDomainTimerCatchupDef { + unsigned long threshold; + unsigned long slew; + unsigned long limit; +}; + typedef struct _virDomainTimerDef virDomainTimerDef; typedef virDomainTimerDef *virDomainTimerDefPtr; struct _virDomainTimerDef { @@ -688,8 +698,10 @@ struct _virDomainTimerDef { int present; /* unspecified = -1, no = 0, yes = 1 */ int tickpolicy; /* none|catchup|merge|discard */ - /* wallclock is only valid for name='platform|rtc' */ - int wallclock; /* host|guest */ + virDomainTimerCatchupDef catchup; + + /* track is only valid for name='platform|rtc' */ + int track; /* host|guest */ /* frequency & mode are only valid for name='tsc' */ unsigned long frequency; /* in Hz, unspecified = 0 */ @@ -1029,7 +1041,7 @@ VIR_ENUM_DECL(virDomainClockOffset) VIR_ENUM_DECL(virDomainNetdevMacvtap) VIR_ENUM_DECL(virDomainTimerName) -VIR_ENUM_DECL(virDomainTimerWallclock) +VIR_ENUM_DECL(virDomainTimerTrack) VIR_ENUM_DECL(virDomainTimerTickpolicy) VIR_ENUM_DECL(virDomainTimerMode) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index cc943f8..08a6b97 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -199,8 +199,8 @@ virDomainClockOffsetTypeFromString; virDomainDiskErrorPolicyTypeToString; virDomainTimerNameTypeToString; virDomainTimerNameTypeFromString; -virDomainTimerWallclockTypeToString; -virDomainTimerWallclockTypeFromString; +virDomainTimerTrackTypeToString; +virDomainTimerTrackTypeFromString; virDomainTimerTickpolicyTypeToString; virDomainTimerTickpolicyTypeFromString; virDomainTimerModeTypeToString; diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 8f6f7ec..4f279be 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -3183,11 +3183,22 @@ qemuBuildClockArgStr(virDomainClockDefPtr def) int i; for (i = 0; i < def->ntimers; i++) { if (def->timers[i]->name == VIR_DOMAIN_TIMER_NAME_RTC) { - if (def->timers[i]->wallclock == VIR_DOMAIN_TIMER_WALLCLOCK_HOST) { - virBufferAddLit(&buf, ",clock=host"); - } else if (def->timers[i]->wallclock == VIR_DOMAIN_TIMER_WALLCLOCK_GUEST) { + switch (def->timers[i]->track) { + case -1: /* unspecified - use hypervisor default */ + break; + case VIR_DOMAIN_TIMER_TRACK_BOOT: + qemuReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("unsupported rtc timer track '%s'"), + virDomainTimerTrackTypeToString(def->timers[i]->track)); + goto error; + case VIR_DOMAIN_TIMER_TRACK_GUEST: virBufferAddLit(&buf, ",clock=vm"); + break; + case VIR_DOMAIN_TIMER_TRACK_WALL: + virBufferAddLit(&buf, ",clock=host"); + break; } + switch (def->timers[i]->tickpolicy) { case -1: case VIR_DOMAIN_TIMER_TICKPOLICY_DELAY: -- 1.6.6.1

2 2

[libvirt] [PATCH] Eliminate compile warnings in nwfilter error log calls
by Laine Stump 02 Apr '10

02 Apr '10

--- src/nwfilter/nwfilter_ebiptables_driver.c | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/nwfilter/nwfilter_ebiptables_driver.c b/src/nwfilter/nwfilter_ebiptables_driver.c index 68bada6..172394d 100644 --- a/src/nwfilter/nwfilter_ebiptables_driver.c +++ b/src/nwfilter/nwfilter_ebiptables_driver.c @@ -156,13 +156,13 @@ printDataType(virConnectPtr conn, case DATATYPE_IPADDR: data = virSocketFormatAddr(&item->u.ipaddr.addr); if (!data) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, "%s", _("internal IPv4 address representation " "is bad")); return 1; } if (snprintf(buf, bufsize, "%s", data) >= bufsize) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, "%s", _("buffer too small for IP address")); VIR_FREE(data); return 1; @@ -173,14 +173,14 @@ printDataType(virConnectPtr conn, case DATATYPE_IPV6ADDR: data = virSocketFormatAddr(&item->u.ipaddr.addr); if (!data) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, "%s", _("internal IPv6 address representation " "is bad")); return 1; } if (snprintf(buf, bufsize, "%s", data) >= bufsize) { - virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, "%s", _("buffer too small for IPv6 address")); VIR_FREE(data); return 1; @@ -191,7 +191,7 @@ printDataType(virConnectPtr conn, case DATATYPE_MACADDR: case DATATYPE_MACMASK: if (bufsize < VIR_MAC_STRING_BUFLEN) { - virNWFilterReportError(conn, VIR_ERR_INVALID_NWFILTER, + virNWFilterReportError(conn, VIR_ERR_INVALID_NWFILTER, "%s", _("Buffer too small for MAC address")); return 1; } @@ -202,7 +202,7 @@ printDataType(virConnectPtr conn, case DATATYPE_UINT16: if (snprintf(buf, bufsize, "%d", item->u.u16) >= bufsize) { - virNWFilterReportError(conn, VIR_ERR_INVALID_NWFILTER, + virNWFilterReportError(conn, VIR_ERR_INVALID_NWFILTER, "%s", _("Buffer too small for uint16 type")); return 1; } @@ -213,7 +213,7 @@ printDataType(virConnectPtr conn, case DATATYPE_UINT8: if (snprintf(buf, bufsize, "%d", item->u.u8) >= bufsize) { - virNWFilterReportError(conn, VIR_ERR_INVALID_NWFILTER, + virNWFilterReportError(conn, VIR_ERR_INVALID_NWFILTER, "%s", _("Buffer too small for uint8 type")); return 1; } -- 1.6.6.1

2 2

[libvirt] [PATCH] Allow domain disk images on root-squash NFS to coexist with security driver.
by Laine Stump 02 Apr '10

02 Apr '10

(suggested by Daniel Berrange, tested by Dan Kenigsberg) virStorageFileGetMetadata will fail for disk images that are stored on a root-squash NFS share that isn't world-readable. SELinuxSetSecurityImageLabel is called during the startup of every domain (as long as security_driver != "none"), and it will propogate the error from virStorageFileGetMetadata, causing the domain startup to fail. This is, however, a common scenario when qemu is run as a non-root user and the disk image is stored on NFS. Ignoring this failure (which doesn't matter in this case, since the next thing done by SELinuxSetSecurityImageLabel - setting the file context - will also fail (and that function already ignores failures due to root-squash NFS) will allow us to continue bringing up the domain. The result is that we don't need to disable the entire security driver just because a domain's disk image is stored on root-squashed NFS. --- src/security/security_selinux.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 6680e2d..3e20475 100644 --- a/src/security/security_selinux.c +++ b/src/security/security_selinux.c @@ -430,7 +430,7 @@ SELinuxSetSecurityImageLabel(virDomainObjPtr vm, path = NULL; if (ret < 0) - return -1; + break; if (meta.backingStore != NULL && SELinuxSetFilecon(meta.backingStore, -- 1.6.6.1

2 2

[libvirt] [RFC]: Snapshot API v4
by Chris Lalancette 02 Apr '10

02 Apr '10

Hello, Here is the 4th (and hopefully final) draft for the snapshot API that we've been discussing. There is one minor change and one major change in this draft. The minor change is that we've added a virDomainSnapshotHasCurrent and virDomainSnapshotCurrent methods to get at the current snapshot. The major change is that I've removed all but one of the possible virDomainSnapshotDelete() flags. After reviewing ESX, virtualbox, and qemu, it seems that the deletion of any snapshots that have children will *automatically* merge the changes from that snapshot into the children to keep the children viable. Therefore, the MERGE and MERGE_FORCE flags are nonsensical. Since this is the virDomainSnapshotDelete call, we don't really need a flag to say "delete", so I've removed the DISCARD flag. What that leaves us with is a single flag to the delete API that says to delete this snapshot, and all children of this snapshot. This could be useful to clean out a tree of snapshots instead of doing it one-by-one. If there are no further major objections to this API, we'll be posting patches later today or tomorrow that implement this API for both qemu and virtualbox. Note that I've not included my full notes from last time. If anyone is still interested in those, I can either repost them or send them privately. /* NOTE: struct _virDomainSnapshot is a private structure, ala * struct _virDomain. */ typedef struct _virDomainSnapshot virDomainSnapshot; /* Take a snapshot of the current VM state. */ virDomainSnapshotPtr virDomainSnapshotCreateXML(virDomainPtr domain, const char *xmlDesc, unsigned int flags); /* Dump the XML of a snapshot */ /* NOTE: see below for proposed XML */ char *virDomainSnapshotGetXMLDesc(virDomainSnapshotPtr snapshot, unsigned int flags); /* Return the number of snapshots for this domain */ int virDomainSnapshotNum(virDomainPtr domain, unsigned int flags); /* Get the names of all snapshots for this domain */ int virDomainListSnapshotNames(virDomainPtr domain, char **names, int nameslen, unsigned int flags); /* Get a handle to a named snapshot */ virDomainSnapshotPtr virDomainSnapshotLookupByName(virDomainPtr domain, const char *name, unsigned int flags); /* Find out if domain "domain" has a current snapshot */ int virDomainSnapshotHasCurrent(virDomainPtr domain, unsigned int flags); /* Get a handle to the current in-use snapshot for the domain. */ int virDomainSnapshotCurrent(virDomainPtr domain, unsigned int flags); /* Start the guest from the snapshot "snapshot". Note that * the guest may either be running or not. * * In the case the VM is running, then the snapshot *must* have * been taken while the VM was running (i.e. the snapshot <state> * tag must be "RUNNING"). This will revert the disk and memory to * "snapshot". * * In the case the VM is not running, then the snapshot may * have been taken while the VM was not running or not. In * either case it will revert just the disk to "snapshot". */ int virDomainCreateFromSnapshot(virDomainSnapshotPtr snapshot, unsigned int flags); /* Delete a snapshot. * * TREE: discard this snapshot and any children snapshots * * Note that this operation can happen when the domain is running or shut * down, though this is hypervisor specific */ */ typedef enum { VIR_DOMAIN_SNAPSHOT_DELETE_TREE, } virDomainSnapshotDelete; int virDomainSnapshotDelete(virDomainSnapshotPtr snapshot, unsigned int flags); int virDomainSnapshotFree(virDomainSnapshotPtr snapshot); NOTE: During snapshot creation, *none* of the fields are required. That is, you can call virDomainSnapshotCreateXML() with an XML of "<domainsnapshot/>". In this case, the individual driver will make up a <name> for you, the <creationdate> will be set to the current time+date, <description> will be empty, <state> will be the current state of the VM, and <parent> will be set to the current snapshot (if any). If you do want to specify some fields during virDomainSnapshotCreateXML(), note that the only ones that are settable are <name> and <description>; the rest are ignored, and filled in by the driver when the snapshot is actually created. NOTE: <state> refers to the state of the VM when the snapshot was taken. NOTE: <creationdate> is in the format %Y-%m-%d_%T as defined by strptime. Also note that the granularity of <creationdate> is in seconds. <domainsnapshot> <name>XYZ</name> <creationdate>...</creationdate> <description>...</description> <state>RUNNING</state> <domain> <uuid>XXXXX-XXXX-XXXX-XXXX-XXXXXXXXX</uuid> </domain> <parent> <name>ABC</name> </parent> </domainsnapshot> The virsh commands will be: virsh snapshot-create <dom> [<xmlfile>] virsh snapshot-list <dom> virsh snapshot-dumpxml <dom> <name> virsh start-from-snapshot <dom> <snapshotname> virsh snapshot-delete <dom> <snapshotname> [--children] -- Chris Lalancette

2 2

[libvirt] [PATCH] nwfilter: Some fixes to XML parser
by Stefan Berger 02 Apr '10

02 Apr '10

While writing a couple of test cases for the nwfilter's XML parser I found some cases where the output ended up not looking as expected. So the following changes are in the patch below: - if the protocol ID in the MAC header is an integer, just write it into the datastructure without trying to find a corresponding string for it and if none is found failing - when writing the protocol ID as string, simply write it as integer if no corresponding string can be found - same changes for arpOpcode parsing and printing - same changes for protocol ID in an IP packet - DSCP value needs to be written into the data structure - IP protocol version number is redundant at this level, so remove it - parse the protocol ID found inside an IP packet not only as string but also as uint8 - arrange the display of the src and destination masks to be shown after the src and destination ip address respectively in the XML - the existing libvirt IP address parser accepts for example '25' as an IP address. I want this to be parsed as a CIDR type netmask. So try to parse it as an integer first (CIDR netmask) and if that doesn't work as a dotted IP address style netmask. - instantiation of rules with MAC masks didn't work because they weren't printed into a buffer, yet. Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com> --- src/conf/nwfilter_conf.c | 128 ++++++++++++++---------------- src/nwfilter/nwfilter_ebiptables_driver.c | 1 2 files changed, 61 insertions(+), 68 deletions(-) Index: libvirt-acl/src/conf/nwfilter_conf.c =================================================================== --- libvirt-acl.orig/src/conf/nwfilter_conf.c +++ libvirt-acl/src/conf/nwfilter_conf.c @@ -403,15 +403,12 @@ checkMacProtocolID(enum attrDatatype dat virNWFilterRuleDefPtr nwf ATTRIBUTE_UNUSED) { int32_t res = -1; - const char *str; if (datatype == DATATYPE_STRING) { if (intMapGetByString(macProtoMap, (char *)value, 1, &res) == 0) res = -1; } else if (datatype == DATATYPE_UINT16) { - if (intMapGetByInt(macProtoMap, - (int32_t)*(uint16_t *)value, &str) == 0) - res = -1; + res = (uint32_t)*(uint16_t *)value; } if (res != -1) { @@ -433,9 +430,10 @@ macProtocolIDFormatter(virBufferPtr buf, nwf->p.ethHdrFilter.dataProtocolID.u.u16, &str)) { virBufferVSprintf(buf, "%s", str); - return 1; + } else { + virBufferVSprintf(buf, "%d", nwf->p.ethHdrFilter.dataProtocolID.u.u16); } - return 0; + return 1; } @@ -500,15 +498,12 @@ arpOpcodeValidator(enum attrDatatype dat virNWFilterRuleDefPtr nwf) { int32_t res = -1; - const char *str; if (datatype == DATATYPE_STRING) { if (intMapGetByString(arpOpcodeMap, (char *)value, 1, &res) == 0) res = -1; } else if (datatype == DATATYPE_UINT16) { - if (intMapGetByInt(arpOpcodeMap, - (uint32_t)*(uint16_t *)value, &str) == 0) - res = -1; + res = (uint32_t)*(uint16_t *)value; } if (res != -1) { @@ -530,9 +525,10 @@ arpOpcodeFormatter(virBufferPtr buf, nwf->p.arpHdrFilter.dataOpcode.u.u16, &str)) { virBufferVSprintf(buf, "%s", str); - return 1; + } else { + virBufferVSprintf(buf, "%d", nwf->p.arpHdrFilter.dataOpcode.u.u16); } - return 0; + return 1; } @@ -560,16 +556,12 @@ static bool checkIPProtocolID(enum attrD virNWFilterRuleDefPtr nwf) { int32_t res = -1; - const char *str; if (datatype == DATATYPE_STRING) { if (intMapGetByString(ipProtoMap, (char *)value, 1, &res) == 0) res = -1; } else if (datatype == DATATYPE_UINT8) { - // may just accept what user provides and not test... - if (intMapGetByInt(ipProtoMap, - (uint32_t)*(uint16_t *)value, &str) == 0) - res = -1; + res = (uint32_t)*(uint16_t *)value; } if (res != -1) { @@ -591,19 +583,24 @@ formatIPProtocolID(virBufferPtr buf, nwf->p.ipHdrFilter.ipHdr.dataProtocolID.u.u8, &str)) { virBufferVSprintf(buf, "%s", str); - return 1; + } else { + virBufferVSprintf(buf, "%d", + nwf->p.ipHdrFilter.ipHdr.dataProtocolID.u.u8); } - return 0; + return 1; } static bool dscpValidator(enum attrDatatype datatype ATTRIBUTE_UNUSED, void *val, - virNWFilterRuleDefPtr nwf ATTRIBUTE_UNUSED) + virNWFilterRuleDefPtr nwf) { uint8_t dscp = *(uint16_t *)val; if (dscp > 63) return 0; + + nwf->p.ipHdrFilter.ipHdr.dataDSCP.u.u8 = dscp; + return 1; } @@ -685,11 +682,6 @@ static const virXMLAttr2Struct arpAttrib static const virXMLAttr2Struct ipAttributes[] = { COMMON_MAC_PROPS(ipHdrFilter), { - .name = "version", - .datatype = DATATYPE_UINT8, - .dataIdx = offsetof(virNWFilterRuleDef, p.ipHdrFilter.ipHdr.dataIPVersion), - }, - { .name = SRCIPADDR, .datatype = DATATYPE_IPADDR, .dataIdx = offsetof(virNWFilterRuleDef, p.ipHdrFilter.ipHdr.dataSrcIPAddr), @@ -711,7 +703,7 @@ static const virXMLAttr2Struct ipAttribu }, { .name = "protocol", - .datatype = DATATYPE_STRING, + .datatype = DATATYPE_STRING | DATATYPE_UINT8, .dataIdx = offsetof(virNWFilterRuleDef, p.ipHdrFilter.ipHdr.dataProtocolID), .validator= checkIPProtocolID, .formatter= formatIPProtocolID, @@ -756,16 +748,16 @@ static const virXMLAttr2Struct ipv6Attri .dataIdx = offsetof(virNWFilterRuleDef, p.ipv6HdrFilter.ipHdr.dataSrcIPAddr), }, { - .name = DSTIPADDR, - .datatype = DATATYPE_IPV6ADDR, - .dataIdx = offsetof(virNWFilterRuleDef, p.ipv6HdrFilter.ipHdr.dataDstIPAddr), - }, - { .name = SRCIPMASK, .datatype = DATATYPE_IPV6MASK, .dataIdx = offsetof(virNWFilterRuleDef, p.ipv6HdrFilter.ipHdr.dataSrcIPMask), }, { + .name = DSTIPADDR, + .datatype = DATATYPE_IPV6ADDR, + .dataIdx = offsetof(virNWFilterRuleDef, p.ipv6HdrFilter.ipHdr.dataDstIPAddr), + }, + { .name = DSTIPMASK, .datatype = DATATYPE_IPV6MASK, .dataIdx = offsetof(virNWFilterRuleDef, p.ipv6HdrFilter.ipHdr.dataDstIPMask), @@ -818,16 +810,16 @@ static const virXMLAttr2Struct ipv6Attri .dataIdx = offsetof(virNWFilterRuleDef, p.STRUCT.ipHdr.dataSrcIPAddr),\ },\ {\ - .name = DSTIPADDR,\ - .datatype = ADDRTYPE,\ - .dataIdx = offsetof(virNWFilterRuleDef, p.STRUCT.ipHdr.dataDstIPAddr),\ - },\ - {\ .name = SRCIPMASK,\ .datatype = MASKTYPE,\ .dataIdx = offsetof(virNWFilterRuleDef, p.STRUCT.ipHdr.dataSrcIPMask),\ },\ {\ + .name = DSTIPADDR,\ + .datatype = ADDRTYPE,\ + .dataIdx = offsetof(virNWFilterRuleDef, p.STRUCT.ipHdr.dataDstIPAddr),\ + },\ + {\ .name = DSTIPMASK,\ .datatype = MASKTYPE,\ .dataIdx = offsetof(virNWFilterRuleDef, p.STRUCT.ipHdr.dataDstIPMask),\ @@ -1276,26 +1268,26 @@ virNWFilterRuleDetailsParse(virConnectPt case DATATYPE_IPMASK: storage_ptr = &item->u.u8; - if (!virNWIPv4AddressParser(prop, &ipaddr)) { - if (sscanf(prop, "%d", &int_val) == 1) { - if (int_val >= 0 && int_val <= 32) { - if (!validator) - *(uint8_t *)storage_ptr = - (uint8_t)int_val; - found = 1; - data_ptr = &int_val; - } else - rc = -1; + if (virStrToLong_i(prop, NULL, 10, &int_val) == 0) { + if (int_val >= 0 && int_val <= 32) { + if (!validator) + *(uint8_t *)storage_ptr = + (uint8_t)int_val; + found = 1; + data_ptr = &int_val; } else rc = -1; } else { - int_val = virSocketGetNumNetmaskBits( + if (virNWIPv4AddressParser(prop, &ipaddr)) { + int_val = virSocketGetNumNetmaskBits( &ipaddr.addr); - if (int_val >= 0) - *(uint8_t *)storage_ptr = int_val; - else + if (int_val >= 0) + *(uint8_t *)storage_ptr = int_val; + else + rc = -1; + found = 1; + } else rc = -1; - found = 1; } break; @@ -1330,26 +1322,26 @@ virNWFilterRuleDetailsParse(virConnectPt case DATATYPE_IPV6MASK: storage_ptr = &item->u.u8; - if (!virNWIPv6AddressParser(prop, &ipaddr)) { - if (sscanf(prop, "%d", &int_val) == 1) { - if (int_val >= 0 && int_val <= 128) { - if (!validator) - *(uint8_t *)storage_ptr = - (uint8_t)int_val; - found = 1; - data_ptr = &int_val; - } else - rc = -1; + if (virStrToLong_i(prop, NULL, 10, &int_val) == 0) { + if (int_val >= 0 && int_val <= 128) { + if (!validator) + *(uint8_t *)storage_ptr = + (uint8_t)int_val; + found = 1; + data_ptr = &int_val; } else rc = -1; } else { - int_val = virSocketGetNumNetmaskBits( - &ipaddr.addr); - if (int_val >= 0) - *(uint8_t *)storage_ptr = int_val; - else - rc = -1; - found = 1; + if (virNWIPv6AddressParser(prop, &ipaddr)) { + int_val = virSocketGetNumNetmaskBits( + &ipaddr.addr); + if (int_val >= 0) + *(uint8_t *)storage_ptr = int_val; + else + rc = -1; + found = 1; + } else + rc = -1; } break; Index: libvirt-acl/src/nwfilter/nwfilter_ebiptables_driver.c =================================================================== --- libvirt-acl.orig/src/nwfilter/nwfilter_ebiptables_driver.c +++ libvirt-acl/src/nwfilter/nwfilter_ebiptables_driver.c @@ -189,6 +189,7 @@ printDataType(virConnectPtr conn, break; case DATATYPE_MACADDR: + case DATATYPE_MACMASK: if (bufsize < VIR_MAC_STRING_BUFLEN) { virNWFilterReportError(conn, VIR_ERR_INVALID_NWFILTER, _("Buffer too small for MAC address"));

3 3

[libvirt] Node devices XML format
by Dev.Atom 02 Apr '10

02 Apr '10

Hi, I need help about Node devices XML format description, there's no infos at libvirt.org, is there another info source where I can have description of this XML file ? Thanks, Best regards, Arnaud Champion

2 1

[libvirt] [PATCHv2 00/10] Begin to replace scanf and atoi
by Matthias Bolte 01 Apr '10

01 Apr '10

This set of patches is a first step towards removing the scanf and atoi usage in libvirt. I began with the simple cases and post this now to get some feedback before I start to convert the more difficult cases. Changes in v2: - don't test tmp for NULL - note in commit message if parsing is stricter now - don't leak in PRUnicharToInt (vbox) - strip a trailing \n in openvzGetVPSUUID, as it was done before - don't use strspn to skip whitespaces, virStrToLong* does this already - fix virStrToLong* return value tests to check for < 0 instead of < 3 or != 1 - add STRSKIP to skip a given prefix of a string Thanks to Eric Blake and Jim Meyering. Matthias

2 22

[libvirt] [PATCH] ESX test case needs '/' in interface name
by Stefan Berger 01 Apr '10

01 Apr '10

To fix an ESX test case, valid interface names need '/' as valid letter. Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com> Index: libvirt-acl/src/conf/domain_conf.h =================================================================== --- libvirt-acl.orig/src/conf/domain_conf.h +++ libvirt-acl/src/conf/domain_conf.h @@ -298,7 +298,7 @@ struct _virDomainNetDef { }; # define VALID_IFNAME_CHARS \ - "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_" + "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_/" enum virDomainChrTargetType { VIR_DOMAIN_CHR_TARGET_TYPE_NULL = 0,

2 2

[libvirt] [PATCH] Fix linker errors in proxy
by Matthias Bolte 01 Apr '10

01 Apr '10

domain_conf.c:494: undefined reference to 'virNWFilterHashTableFree' domain_conf.c:5107: undefined reference to 'virNWFilterFormatParamAttributes' Add missing source to the proxy and disable XML parsing code in nwfilter_params.c for a proxy build. --- proxy/Makefile.am | 2 ++ src/conf/nwfilter_params.c | 2 ++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/proxy/Makefile.am b/proxy/Makefile.am index aef11ca..9ea91d8 100644 --- a/proxy/Makefile.am +++ b/proxy/Makefile.am @@ -15,6 +15,7 @@ libexec_PROGRAMS = libvirt_proxy libvirt_proxy_SOURCES = libvirt_proxy.c \ @top_srcdir@/src/util/buf.c \ + @top_srcdir@/src/util/hash.c \ @top_srcdir@/src/util/logging.c \ @top_srcdir@/src/util/memory.c \ @top_srcdir@/src/util/network.c \ @@ -26,6 +27,7 @@ libvirt_proxy_SOURCES = libvirt_proxy.c \ @top_srcdir@/src/conf/storage_encryption_conf.c \ @top_srcdir@/src/conf/domain_conf.c \ @top_srcdir@/src/conf/cpu_conf.c \ + @top_srcdir@/src/conf/nwfilter_params.c \ @top_srcdir@/src/xen/xend_internal.c \ @top_srcdir@/src/xen/xen_hypervisor.c \ @top_srcdir@/src/xen/sexpr.c \ diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c index 38a51c9..286c5ef 100644 --- a/src/conf/nwfilter_params.c +++ b/src/conf/nwfilter_params.c @@ -214,6 +214,7 @@ err_exit: } +#ifndef PROXY virNWFilterHashTablePtr virNWFilterParseParamAttributes(xmlNodePtr cur) { @@ -254,6 +255,7 @@ skip_entry: } return table; } +#endif struct formatterParam { -- 1.6.3.3

2 2

[libvirt] [PATCH] Fix ./configure: line 27875: [: missing `]'
by Matthias Bolte 01 Apr '10

01 Apr '10

Commit 7998714d60b997357bfea15d6f2d0f729fc8fb29 replaced '-a' with '&& test' but this single '-a' needs to stay. --- configure.ac | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 3c3d7b3..fc87e19 100644 --- a/configure.ac +++ b/configure.ac @@ -240,7 +240,7 @@ AC_ARG_WITH([libvirtd], dnl dnl specific tests to setup DV devel environments with debug etc ... dnl -if [[ "${LOGNAME}" = "veillard" && test "`pwd`" = "/u/veillard/libvirt" ]] ; then +if [[ "${LOGNAME}" = "veillard" -a "`pwd`" = "/u/veillard/libvirt" ]] ; then STATIC_BINARIES="-static" else STATIC_BINARIES= -- 1.6.3.3

2 4

[libvirt] [PATCH] nwfilter: Support for learning a VM's IP address
by Stefan Berger 01 Apr '10

01 Apr '10

Subject: Support for learning a VM's IP address This patch implements support for learning a VM's IP address. It uses the pcap library to listen on the VM's backend network interface (tap) or the physical ethernet device (macvtap) and tries to capture packets with source or destination MAC address of the VM and learn from DHCP Offers, ARP traffic, or first-sent IPv4 packet what the IP address of the VM's interface is. This then allows to instantiate the network traffic filtering rules without the user having to provide the IP parameter somewhere in the filter description or in the interface description as a parameter. This only supports to detect the parameter IP, which is for the assumed single IPv4 address of a VM. There is not support for interfaces that may have multiple IP addresses (IP aliasing) or IPv6 that may then require more than one valid IP address to be detected. A VM can have multiple independent interfaces that each uses a different IP address and in that case it will be attempted to detect each one of the address independently. So, when for example an interface description in the domain XML has looked like this up to now: <interface type='bridge'> <source bridge='mybridge'/> <model type='virtio'/> <filterref filter='clean-traffic'> <parameter name='IP' value='10.2.3.4'/> </filterref> </interface> you may omit the IP parameter: <interface type='bridge'> <source bridge='mybridge'/> <model type='virtio'/> <filterref filter='clean-traffic'/> </interface> Internally I am walking the 'tree' of a VM's referenced network filters and determine with the given variables which variables are missing. Now, the above IP parameter may be missing and this causes a libvirt-internal thread to be started that uses the pcap library's API to listen to the backend interface (in case of macvtap to the physical interface) in an attempt to determine the missing IP parameter. If the backend interface disappears the thread terminates assuming the VM was brought down. In case of a macvtap device a timeout is being used to wait for packets from the given VM (filtering by VM's interface MAC address). If the VM's macvtap device disappeared the thread also terminates. In all other cases it tries to determine the IP address of the VM and will then apply the rules late on the given interface, which would have happened immediately if the IP parameter had been explicitly given. In case an error happens while the firewall rules are applied, the VM's backend interface is 'down'ed preventing it to communicate. Reasons for failure for applying the network firewall rules may that an ebtables/iptables command failes or OOM errors. Essentially the same failure reasons may occur as when the firewall rules are applied immediately on VM start, except that due to the late application of the filtering rules the VM now is already running and cannot be hindered anymore from starting. Bringing down the whole VM would probably be considered too drastic. While a VM's IP address is attempted to be determined only limited updates to network filters are allowed. In particular it is prevented that filters are modified in such a way that they would introduce new variables. A caveat: The algorithm does not know which one is the appropriate IP address of a VM. If the VM spoofs an IP address in its first ARP traffic or IPv4 packets its filtering rules will be instantiated for this IP address, thus 'locking' it to the found IP address. So, it's still 'safer' to explicitly provide the IP address of a VM's interface in the filter description if it is known beforehand. Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com> --- configure.ac | 39 ++ src/Makefile.am | 13 src/conf/nwfilter_conf.c | 7 src/conf/nwfilter_conf.h | 3 src/libvirt_private.syms | 12 src/nwfilter/nwfilter_driver.c | 11 src/nwfilter/nwfilter_ebiptables_driver.c | 100 +++++ src/nwfilter/nwfilter_ebiptables_driver.h | 7 src/nwfilter/nwfilter_gentech_driver.c | 408 +++++++++++++++++++-- src/nwfilter/nwfilter_gentech_driver.h | 14 src/nwfilter/nwfilter_learnipaddr.c | 579 ++++++++++++++++++++++++++++++ src/nwfilter/nwfilter_learnipaddr.h | 61 +++ 12 files changed, 1216 insertions(+), 38 deletions(-) Index: libvirt-acl/src/nwfilter/nwfilter_learnipaddr.h =================================================================== --- /dev/null +++ libvirt-acl/src/nwfilter/nwfilter_learnipaddr.h @@ -0,0 +1,61 @@ +/* + * nwfilter_learnipaddr.h: support for learning IP address used by a VM + * on an interface + * + * Copyright (C) 2010 IBM Corp. + * Copyright (C) 2010 Stefan Berger + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * + * Author: Stefan Berger <stefanb(a)us.ibm.com> + */ + +#ifndef __NWFILTER_LEARNIPADDR_H +#define __NWFILTER_LEARNIPADDR_H + +typedef struct _virNWFilterIPAddrLearnReq virNWFilterIPAddrLearnReq; +typedef virNWFilterIPAddrLearnReq *virNWFilterIPAddrLearnReqPtr; +struct _virNWFilterIPAddrLearnReq { + char ifname[IF_NAMESIZE]; + char linkdev[IF_NAMESIZE]; + enum virDomainNetType nettype; + unsigned char macaddr[VIR_MAC_BUFLEN]; + char *filtername; + virNWFilterHashTablePtr filterparams; + virNWFilterDriverStatePtr driver; + + int status; + pthread_t thread; +}; + +int virNWFilterLearnIPAddress(virConnectPtr conn, + const char *ifname, + const char *linkdev, + enum virDomainNetType nettype, + const unsigned char *macaddr, + const char *filtername, + virNWFilterHashTablePtr filterparams, + virNWFilterDriverStatePtr driver); + +virNWFilterIPAddrLearnReqPtr virNWFilterLookupLearnReq(const char *ifname); + + +void virNWFilterDelIpAddrForIfname(const char *ifname); +const char *virNWFilterGetIpAddrForIfname(const char *ifname); + +int virNWFilterLearnInit(void); +void virNWFilterLearnShutdown(void); + +#endif /* __NWFILTER_LEARNIPADDR_H */ Index: libvirt-acl/src/nwfilter/nwfilter_learnipaddr.c =================================================================== --- /dev/null +++ libvirt-acl/src/nwfilter/nwfilter_learnipaddr.c @@ -0,0 +1,579 @@ +/* + * nwfilter_learnipaddr.c: support for learning IP address used by a VM + * on an interface + * + * Copyright (C) 2010 IBM Corp. + * Copyright (C) 2010 Stefan Berger + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * + * Author: Stefan Berger <stefanb(a)us.ibm.com> + */ + +#include <config.h> + +#ifdef HAVE_LIBPCAP +#include <pcap.h> +#endif + +#include <fcntl.h> +#include <sys/ioctl.h> + +#include <arpa/inet.h> +#include <net/ethernet.h> +#include <netinet/ip.h> +#include <netinet/udp.h> +#include <net/if_arp.h> +#include <linux/if.h> + +#include "internal.h" + +#include "buf.h" +#include "memory.h" +#include "logging.h" +#include "datatypes.h" +#include "virterror_internal.h" +#include "threads.h" +#include "conf/nwfilter_params.h" +#include "conf/domain_conf.h" +#include "nwfilter_gentech_driver.h" +#include "nwfilter_ebiptables_driver.h" +#include "nwfilter_learnipaddr.h" + +#define VIR_FROM_THIS VIR_FROM_NWFILTER + + +/* structure of an ARP request/reply message */ +struct f_arphdr { + struct arphdr arphdr; + uint8_t ar_sha[ETH_ALEN]; + uint32_t ar_sip; + uint8_t ar_tha[ETH_ALEN]; + uint32_t ar_tip; +} __attribute__((packed)); + + +/* structure representing DHCP message */ +struct dhcp { + uint8_t op; + uint8_t htype; + uint8_t hlen; + uint8_t hops; + uint32_t xid; + uint16_t secs; + uint16_t flags; + uint32_t ciaddr; + uint32_t yiaddr; + uint32_t siaddr; + uint32_t giaddr; + uint32_t chaddr; + /* omitted */ +} __attribute__((packed)); + + +struct ether_vlan_header +{ + uint8_t dhost[ETH_ALEN]; + uint8_t shost[ETH_ALEN]; + uint16_t vlan_type; + uint16_t vlan_flags; + uint16_t ether_type; +} __attribute__((packed)); + + +static virMutex pendingLearnReqLock; +static virHashTablePtr pendingLearnReq; + +static virMutex ipAddressMapLock; +static virNWFilterHashTablePtr ipAddressMap; + + +static void +virNWFilterIPAddrLearnReqFree(virNWFilterIPAddrLearnReqPtr req) { + if (!req) + return; + + VIR_FREE(req->filtername); + virNWFilterHashTableFree(req->filterparams); + + VIR_FREE(req); +} + + +#if HAVE_LIBPCAP + +static int +virNWFilterRegisterLearnReq(virNWFilterIPAddrLearnReqPtr req) { + int res = -1; + virMutexLock(&pendingLearnReqLock); + + if (!virHashLookup(pendingLearnReq, req->ifname)) + res = virHashAddEntry(pendingLearnReq, req->ifname, req); + + virMutexUnlock(&pendingLearnReqLock); + + return res; +} + +#endif + + +virNWFilterIPAddrLearnReqPtr +virNWFilterLookupLearnReq(const char *ifname) { + void *res; + + virMutexLock(&pendingLearnReqLock); + + res = virHashLookup(pendingLearnReq, ifname); + + virMutexUnlock(&pendingLearnReqLock); + + return res; +} + + +static void +freeLearnReqEntry(void *payload, const char *name ATTRIBUTE_UNUSED) { + virNWFilterIPAddrLearnReqFree(payload); +} + + +#ifdef HAVE_LIBPCAP + +static virNWFilterIPAddrLearnReqPtr +virNWFilterDeregisterLearnReq(const char *ifname) { + virNWFilterIPAddrLearnReqPtr res; + + virMutexLock(&pendingLearnReqLock); + + res = virHashLookup(pendingLearnReq, ifname); + + if (res) + virHashRemoveEntry(pendingLearnReq, ifname, NULL); + + virMutexUnlock(&pendingLearnReqLock); + + return res; +} + + + +static int +virNWFilterAddIpAddrForIfname(const char *ifname, char *addr) { + int ret; + + virMutexLock(&ipAddressMapLock); + + ret = virNWFilterHashTablePut(ipAddressMap, ifname, addr, 1); + + virMutexUnlock(&ipAddressMapLock); + + return ret; +} +#endif + + +void +virNWFilterDelIpAddrForIfname(const char *ifname) { + + virMutexLock(&ipAddressMapLock); + + if (virHashLookup(ipAddressMap->hashTable, ifname)) + virNWFilterHashTableRemoveEntry(ipAddressMap, ifname); + + virMutexUnlock(&ipAddressMapLock); +} + + +const char * +virNWFilterGetIpAddrForIfname(const char *ifname) { + const char *res; + + virMutexLock(&ipAddressMapLock); + + res = virHashLookup(ipAddressMap->hashTable, ifname); + + virMutexUnlock(&ipAddressMapLock); + + return res; +} + + +#ifdef HAVE_LIBPCAP + +/** + * learnIPAddressThread + * arg: pointer to virNWFilterIPAddrLearnReq structure + * + * Learn the IP address being used on an interface. Use ARP Request and + * Reply messages, DHCP offers and the first IP packet being sent from + * the VM to detect the IP address it is using. Detects only one IP address + * per interface (IP aliasing not supported) + */ +static void * +learnIPAddressThread(void *arg) +{ + char errbuf[PCAP_ERRBUF_SIZE] = {0}; + pcap_t *handle; + struct bpf_program fp; + struct pcap_pkthdr header; + const u_char *packet; + struct ether_header *ether_hdr; + struct ether_vlan_header *vlan_hdr; + virNWFilterIPAddrLearnReqPtr req = arg; + uint32_t vmaddr = 0; + unsigned int ethHdrSize; + char *listen_if = (strlen(req->linkdev) != 0) ? req->linkdev + : req->ifname; + int to_ms = (strlen(req->linkdev) != 0) ? 1000 + : 0; + char macaddr[VIR_MAC_STRING_BUFLEN]; + virBuffer buf = VIR_BUFFER_INITIALIZER; + char *filter= NULL; + uint16_t etherType; + + req->status = 0; + + handle = pcap_open_live(listen_if, BUFSIZ, 0, to_ms, errbuf); + + if (handle == NULL) { + VIR_DEBUG("Couldn't open device %s: %s\n", listen_if, errbuf); + req->status = ENODEV; + goto done; + } + + virFormatMacAddr(req->macaddr, macaddr); + virBufferVSprintf(&buf, "ether host %s", macaddr); + if (virBufferError(&buf)) { + req->status = ENOMEM; + goto done; + } + + filter = virBufferContentAndReset(&buf); + + if (pcap_compile(handle, &fp, filter, 1, 0) != 0 || + pcap_setfilter(handle, &fp) != 0) { + VIR_DEBUG("Couldn't compile or set filter '%s'.\n", filter); + req->status = EINVAL; + goto done; + } + + while (req->status == 0 && vmaddr == 0) { + packet = pcap_next(handle, &header); + + if (!packet) { + if (to_ms == 0) { + /* assuming IF disappeared */ + req->status = ENODEV; + break; + } + /* listening on linkdev, check whether VM's dev is still there */ + if (checkIf(req->ifname, req->macaddr)) { + req->status = ENODEV; + break; + } + continue; + } + + if (header.len >= sizeof(struct ether_header)) { + ether_hdr = (struct ether_header*)packet; + + switch (ntohs(ether_hdr->ether_type)) { + + case ETHERTYPE_IP: + ethHdrSize = sizeof(struct ether_header); + etherType = ntohs(ether_hdr->ether_type); + break; + + case ETHERTYPE_VLAN: + ethHdrSize = sizeof(struct ether_vlan_header); + vlan_hdr = (struct ether_vlan_header *)packet; + if (ntohs(vlan_hdr->ether_type) != ETHERTYPE_IP || + header.len < ethHdrSize) + continue; + etherType = ntohs(vlan_hdr->ether_type); + break; + + default: + continue; + } + + if (memcmp(ether_hdr->ether_shost, + req->macaddr, + VIR_MAC_BUFLEN) == 0) { + // packets from the VM + + if ((header.len >= ethHdrSize + + sizeof(struct iphdr))) { + struct iphdr *iphdr = (struct iphdr*)(packet + + ethHdrSize); + vmaddr = iphdr->saddr; + // skip eth. bcast and mcast addresses, + // and zero address in DHCP Requests + if ((ntohl(vmaddr) & 0xc0000000) || vmaddr == 0) { + vmaddr = 0; + continue; + } + + } else if (etherType == ETHERTYPE_ARP && + (header.len >= ethHdrSize + + sizeof(struct f_arphdr))) { + struct f_arphdr *arphdr = (struct f_arphdr*)(packet + + ethHdrSize); + switch (ntohs(arphdr->arphdr.ar_op)) { + case ARPOP_REPLY: + vmaddr = arphdr->ar_sip; + break; + case ARPOP_REQUEST: + vmaddr = arphdr->ar_tip; + break; + } + } + } else if (memcmp(ether_hdr->ether_dhost, + req->macaddr, + VIR_MAC_BUFLEN) == 0) { + // packets to the VM + if (etherType == ETHERTYPE_IP && + (header.len >= ethHdrSize + + sizeof(struct iphdr))) { + struct iphdr *iphdr = (struct iphdr*)(packet + + ethHdrSize); + if ((iphdr->protocol == IPPROTO_UDP) && + (header.len >= ethHdrSize + + iphdr->ihl * 4 + + sizeof(struct udphdr))) { + struct udphdr *udphdr= (struct udphdr *) + ((char *)iphdr + iphdr->ihl * 4); + if (ntohs(udphdr->source) == 67 && + ntohs(udphdr->dest) == 68 && + header.len >= ethHdrSize + + iphdr->ihl * 4 + + sizeof(struct udphdr) + + sizeof(struct dhcp)) { + struct dhcp *dhcp = (struct dhcp *) + ((char *)udphdr + sizeof(udphdr)); + if (dhcp->op == 2 /* DHCP OFFER */) { + vmaddr = dhcp->yiaddr; + } + } + } + } + } + } + } + + done: + VIR_FREE(filter); + + if (handle) + pcap_close(handle); + + ebtablesRemoveBasicRules(NULL, req->ifname); + + if (req->status == 0) { + int ret; + char inetaddr[INET_ADDRSTRLEN]; + inet_ntop(AF_INET, &vmaddr, inetaddr, sizeof(inetaddr)); + + virNWFilterAddIpAddrForIfname(req->ifname, strdup(inetaddr)); + + ret = virNWFilterInstantiateFilterLate(NULL, + req->ifname, + req->linkdev, + req->nettype, + req->macaddr, + req->filtername, + req->filterparams, + req->driver); + VIR_DEBUG("Result from applying firewall rules on " + "%s with IP addr %s : %d\n", req->ifname, inetaddr, ret); + } + + memset(&req->thread, 0x0, sizeof(req->thread)); + + VIR_DEBUG("pcap thread terminating for interface %s\n",req->ifname); + + virNWFilterDeregisterLearnReq(req->ifname); + + virNWFilterIPAddrLearnReqFree(req); + + return 0; +} + + +/** + * virNWFilterLearnIPAddress + * @conn: pointer to virConnect object + * @ifname: the name of the interface + * @linkdev : the name of the link device; currently only used in case of a + * macvtap device + * @nettype : the type of interface + * @macaddr : the MAC address of the interface + * @filtername : the name of the top-level filter to apply to the interface + * once its IP address has been detected + * @driver : the network filter driver + * + * Instruct to learn the IP address being used on a given interface (ifname). + * Unless there already is a thread attempting to learn the IP address + * being used on the interface, a thread is started that will listen on + * the traffic being sent on the interface (or link device) with the + * MAC address that is provided. Will then launch the application of the + * firewall rules on the interface. + */ +int +virNWFilterLearnIPAddress(virConnectPtr conn, + const char *ifname, + const char *linkdev, + enum virDomainNetType nettype, + const unsigned char *macaddr, + const char *filtername, + virNWFilterHashTablePtr filterparams, + virNWFilterDriverStatePtr driver) { + int rc; + virNWFilterIPAddrLearnReqPtr req = NULL; + virNWFilterHashTablePtr ht = NULL; + + if (VIR_ALLOC(req) < 0) { + virReportOOMError(); + goto err_exit; + } + + ht = virNWFilterHashTableCreate(0); + if (ht == NULL) { + virReportOOMError(); + goto err_exit; + } + + if (virNWFilterHashTablePutAll(conn, filterparams, ht)) + goto err_exit; + + req->filtername = strdup(filtername); + if (req->filtername == NULL) { + virReportOOMError(); + goto err_exit; + } + + if (virStrcpyStatic(req->ifname, ifname) == NULL) { + virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + _("Destination buffer for ifname ('%s') " + "not large enough"), ifname); + goto err_exit; + } + + if (linkdev) { + if (virStrcpyStatic(req->linkdev, linkdev) == NULL) { + virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + _("Destination buffer for linkdev ('%s') " + "not large enough"), linkdev); + goto err_exit; + } + } + req->nettype = nettype; + memcpy(req->macaddr, macaddr, sizeof(req->macaddr)); + req->driver = driver; + req->filterparams = ht; + ht = NULL; + + rc = virNWFilterRegisterLearnReq(req); + + if (rc) + goto err_exit; + + if (ebtablesApplyBasicRules(conn, + ifname, + macaddr)) { + goto err_exit; + } + + if (pthread_create(&req->thread, + NULL, + learnIPAddressThread, + req) != 0) + goto err_exit; + + return 0; + +err_exit: + ebtablesRemoveBasicRules(conn, ifname); + virNWFilterIPAddrLearnReqFree(req); + virNWFilterHashTableFree(ht); + return 1; +} + +#else + +int +virNWFilterLearnIPAddress(virConnectPtr conn ATTRIBUTE_UNUSED, + const char *ifname ATTRIBUTE_UNUSED, + const char *linkdev ATTRIBUTE_UNUSED, + enum virDomainNetType nettype ATTRIBUTE_UNUSED, + const unsigned char *macaddr ATTRIBUTE_UNUSED, + const char *filtername ATTRIBUTE_UNUSED, + virNWFilterHashTablePtr filterparams ATTRIBUTE_UNUSED, + virNWFilterDriverStatePtr driver ATTRIBUTE_UNUSED) { + virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + _("IP parameter must be given since libvirt " + "was not compiled with IP address learning " + "support")); + return 1; +} +#endif /* HAVE_LIBPCAP */ + + +/** + * virNWFilterLearnInit + * Initialization of this layer + */ +int +virNWFilterLearnInit(void) { + pendingLearnReq = virHashCreate(0); + if (!pendingLearnReq) { + virReportOOMError(); + return 1; + } + + if (virMutexInit(&pendingLearnReqLock)) { + virNWFilterLearnShutdown(); + return 1; + } + + ipAddressMap = virNWFilterHashTableCreate(0); + if (!ipAddressMap) { + virReportOOMError(); + virNWFilterLearnShutdown(); + return 1; + } + + if (virMutexInit(&ipAddressMapLock)) { + virNWFilterLearnShutdown(); + return 1; + } + + return 0; +} + + +/** + * virNWFilterLearnShutdown + * Shutdown of this layer + */ +void +virNWFilterLearnShutdown(void) { + virHashFree(pendingLearnReq, freeLearnReqEntry); + pendingLearnReq = NULL; + + virNWFilterHashTableFree(ipAddressMap); + ipAddressMap = NULL; +} Index: libvirt-acl/src/Makefile.am =================================================================== --- libvirt-acl.orig/src/Makefile.am +++ libvirt-acl/src/Makefile.am @@ -289,7 +289,8 @@ STORAGE_HELPER_DISK_SOURCES = \ NWFILTER_DRIVER_SOURCES = \ nwfilter/nwfilter_driver.h nwfilter/nwfilter_driver.c \ nwfilter/nwfilter_gentech_driver.c \ - nwfilter/nwfilter_ebiptables_driver.c + nwfilter/nwfilter_ebiptables_driver.c \ + nwfilter/nwfilter_learnipaddr.c # Security framework and drivers for various models SECURITY_DRIVER_SOURCES = \ @@ -740,10 +741,11 @@ else libvirt_la_LIBADD += libvirt_driver_nwfilter.la noinst_LTLIBRARIES += libvirt_driver_nwfilter.la endif -libvirt_driver_nwfilter_la_CFLAGS = \ +libvirt_driver_nwfilter_la_CFLAGS = $(LIBPCAP_CFLAGS) \ -I@top_srcdir@/src/conf +libvirt_driver_nwfilter_la_LDFLAGS = $(LIBPCAP_LIBS) if WITH_DRIVER_MODULES -libvirt_driver_nwfilter_la_LDFLAGS = -module -avoid-version ../gnulib/lib/libgnu.la +libvirt_driver_nwfilter_la_LDFLAGS += -module -avoid-version ../gnulib/lib/libgnu.la endif libvirt_driver_nwfilter_la_SOURCES = $(NWFILTER_DRIVER_SOURCES) endif @@ -887,6 +889,7 @@ libvirt_la_LDFLAGS = $(VERSION_SCRIPT_FL -version-info $(LIBVIRT_VERSION_INFO) \ $(COVERAGE_CFLAGS:-f%=-Wc,-f%) \ $(LIBXML_LIBS) \ + $(LIBPCAP_LIBS) \ $(DRIVER_MODULE_LIBS) \ $(CYGWIN_EXTRA_LDFLAGS) $(MINGW_EXTRA_LDFLAGS) libvirt_la_CFLAGS = $(COVERAGE_CFLAGS) -DIN_LIBVIRT @@ -935,8 +938,8 @@ libvirt_lxc_SOURCES = \ $(NODE_INFO_SOURCES) \ $(ENCRYPTION_CONF_SOURCES) \ $(DOMAIN_CONF_SOURCES) \ - $(NWFILTER_PARAM_CONF_SOURCES) \ - $(CPU_CONF_SOURCES) + $(CPU_CONF_SOURCES) \ + $(NWFILTER_PARAM_CONF_SOURCES) libvirt_lxc_LDFLAGS = $(WARN_CFLAGS) $(COVERAGE_LDCFLAGS) $(CAPNG_LIBS) $(YAJL_LIBS) libvirt_lxc_LDADD = $(LIBXML_LIBS) $(NUMACTL_LIBS) ../gnulib/lib/libgnu.la libvirt_lxc_CFLAGS = \ Index: libvirt-acl/src/nwfilter/nwfilter_gentech_driver.c =================================================================== --- libvirt-acl.orig/src/nwfilter/nwfilter_gentech_driver.c +++ libvirt-acl/src/nwfilter/nwfilter_gentech_driver.c @@ -24,6 +24,9 @@ #include <config.h> #include <stdint.h> +#include <sys/socket.h> +#include <sys/ioctl.h> +#include <linux/if.h> #include "internal.h" @@ -34,12 +37,16 @@ #include "virterror_internal.h" #include "nwfilter_gentech_driver.h" #include "nwfilter_ebiptables_driver.h" +#include "nwfilter_learnipaddr.h" #define VIR_FROM_THIS VIR_FROM_NWFILTER #define NWFILTER_STD_VAR_MAC "MAC" +#define NWFILTER_STD_VAR_IP "IP" + +static int _virNWFilterTeardownFilter(const char *ifname); static virNWFilterTechDriverPtr filter_tech_drivers[] = { @@ -111,6 +118,8 @@ virNWFilterRuleInstFree(virNWFilterRuleI * @tables: pointer to hash tabel to add values to * @macaddr: The string of the MAC address to add to the hash table, * may be NULL + * @ipaddr: The string of the IP address to add to the hash table; + * may be NULL * * Returns 0 in case of success, 1 in case an error happened with * error having been reported. @@ -120,7 +129,8 @@ virNWFilterRuleInstFree(virNWFilterRuleI static int virNWFilterVarHashmapAddStdValues(virConnectPtr conn, virNWFilterHashTablePtr table, - char *macaddr) + char *macaddr, + char *ipaddr) { if (macaddr) { if (virHashAddEntry(table->hashTable, @@ -132,6 +142,16 @@ virNWFilterVarHashmapAddStdValues(virCon } } + if (ipaddr) { + if (virHashAddEntry(table->hashTable, + NWFILTER_STD_VAR_IP, + ipaddr) < 0) { + virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + "%s", _("Could not add variable 'IP' to hashmap")); + return 1; + } + } + return 0; } @@ -140,23 +160,26 @@ virNWFilterVarHashmapAddStdValues(virCon * virNWFilterCreateVarHashmap: * @conn: pointer to virConnect object * @macaddr: pointer to string containing formatted MAC address of interface + * @ipaddr: pointer to string containing formatted IP address used by + * VM on this interface; may be NULL * * Create a hashmap used for evaluating the firewall rules. Initializes - * it with the standard variable 'MAC'. + * it with the standard variable 'MAC' and 'IP' if provided. * * Returns pointer to hashmap, NULL if an error occcurred and error message * is attached to the virConnect object. */ virNWFilterHashTablePtr virNWFilterCreateVarHashmap(virConnectPtr conn, - char *macaddr) { + char *macaddr, + char *ipaddr) { virNWFilterHashTablePtr table = virNWFilterHashTableCreate(0); if (!table) { virReportOOMError(); return NULL; } - if (virNWFilterVarHashmapAddStdValues(conn, table, macaddr)) { + if (virNWFilterVarHashmapAddStdValues(conn, table, macaddr, ipaddr)) { virNWFilterHashTableFree(table); return NULL; } @@ -284,9 +307,9 @@ _virNWFilterInstantiateRec(virConnectPtr virNWFilterHashTablePtr vars, int *nEntries, virNWFilterRuleInstPtr **insts, - enum instCase useNewFilter, int *foundNewFilter) + enum instCase useNewFilter, int *foundNewFilter, + virNWFilterDriverStatePtr driver) { - virNWFilterDriverStatePtr driver = conn->nwfilterPrivateData; virNWFilterPoolObjPtr obj; int rc = 0; int i; @@ -365,7 +388,96 @@ _virNWFilterInstantiateRec(virConnectPtr tmpvars, nEntries, insts, useNewFilter, - foundNewFilter); + foundNewFilter, + driver); + + virNWFilterHashTableFree(tmpvars); + + virNWFilterPoolObjUnlock(obj); + if (rc) + break; + } else { + virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + _("referenced filter '%s' is missing"), + inc->filterref); + rc = 1; + break; + } + } + } + return rc; +} + + +static int +virNWFilterDetermineMissingVarsRec(virConnectPtr conn, + virNWFilterDefPtr filter, + virNWFilterHashTablePtr vars, + virNWFilterHashTablePtr missing_vars, + int useNewFilter, + virNWFilterDriverStatePtr driver) +{ + virNWFilterPoolObjPtr obj; + int rc = 0; + int i, j; + virNWFilterDefPtr next_filter; + + for (i = 0; i < filter->nentries; i++) { + virNWFilterRuleDefPtr rule = filter->filterEntries[i]->rule; + virNWFilterIncludeDefPtr inc = filter->filterEntries[i]->include; + if (rule) { + // check all variables of this rule + for (j = 0; j < rule->nvars; j++) { + if (!virHashLookup(vars->hashTable, rule->vars[j])) { + virNWFilterHashTablePut(missing_vars, rule->vars[j], + strdup("1"), 1); + } + } + } else if (inc) { + VIR_DEBUG("Following filter %s\n", inc->filterref); + obj = virNWFilterPoolObjFindByName(&driver->pools, + inc->filterref); + if (obj) { + + if (obj->wantRemoved) { + virNWFilterReportError(conn, VIR_ERR_NO_NWFILTER, + _("Filter '%s' is in use."), + inc->filterref); + rc = 1; + virNWFilterPoolObjUnlock(obj); + break; + } + + // create a temporary hashmap for depth-first tree traversal + virNWFilterHashTablePtr tmpvars = + virNWFilterCreateVarsFrom(conn, + inc->params, + vars); + if (!tmpvars) { + virReportOOMError(); + rc = 1; + virNWFilterPoolObjUnlock(obj); + break; + } + + next_filter = obj->def; + + switch (useNewFilter) { + case INSTANTIATE_FOLLOW_NEWFILTER: + if (obj->newDef) { + next_filter = obj->newDef; + } + break; + case INSTANTIATE_ALWAYS: + break; + } + + rc = virNWFilterDetermineMissingVarsRec(conn, + next_filter, + tmpvars, + missing_vars, + useNewFilter, + driver); virNWFilterHashTableFree(tmpvars); @@ -438,9 +550,12 @@ virNWFilterInstantiate(virConnectPtr con enum virDomainNetType nettype, virNWFilterDefPtr filter, const char *ifname, + const char *linkdev, virNWFilterHashTablePtr vars, enum instCase useNewFilter, int *foundNewFilter, - bool teardownOld) + bool teardownOld, + const unsigned char *macaddr, + virNWFilterDriverStatePtr driver) { int rc; int j, nptrs; @@ -449,6 +564,44 @@ virNWFilterInstantiate(virConnectPtr con void **ptrs = NULL; int instantiate = 1; + virNWFilterLockFilterUpdates(); + + virNWFilterHashTablePtr missing_vars = virNWFilterHashTableCreate(0); + if (!missing_vars) { + virReportOOMError(); + rc = 1; + goto err_exit; + } + + rc = virNWFilterDetermineMissingVarsRec(conn, + filter, + vars, + missing_vars, + useNewFilter, + driver); + if (rc) + goto err_exit; + + if (virHashSize(missing_vars->hashTable) == 1) { + if (virHashLookup(missing_vars->hashTable, + NWFILTER_STD_VAR_IP) != NULL) { + if (virNWFilterLookupLearnReq(ifname) == NULL) { + rc = virNWFilterLearnIPAddress(conn, + ifname, + linkdev, + nettype, macaddr, + filter->name, + vars, driver); + } + goto err_exit; + } + rc = 1; + goto err_exit; + } else if (virHashSize(missing_vars->hashTable) > 1) { + rc = 1; + goto err_exit; + } + rc = _virNWFilterInstantiateRec(conn, techdriver, nettype, @@ -456,7 +609,8 @@ virNWFilterInstantiate(virConnectPtr con ifname, vars, &nEntries, &insts, - useNewFilter, foundNewFilter); + useNewFilter, foundNewFilter, + driver); if (rc) goto err_exit; @@ -487,24 +641,33 @@ virNWFilterInstantiate(virConnectPtr con err_exit: + virNWFilterUnlockFilterUpdates(); + for (j = 0; j < nEntries; j++) virNWFilterRuleInstFree(insts[j]); VIR_FREE(insts); + virNWFilterHashTableFree(missing_vars); + return rc; } static int -_virNWFilterInstantiateFilter(virConnectPtr conn, - const virDomainNetDefPtr net, - bool teardownOld, - enum instCase useNewFilter) +__virNWFilterInstantiateFilter(virConnectPtr conn, + bool teardownOld, + const char *ifname, + const char *linkdev, + enum virDomainNetType nettype, + const unsigned char *macaddr, + const char *filtername, + virNWFilterHashTablePtr filterparams, + enum instCase useNewFilter, + virNWFilterDriverStatePtr driver) { int rc; const char *drvname = EBIPTABLES_DRIVER_ID; - virNWFilterDriverStatePtr driver = conn->nwfilterPrivateData; virNWFilterTechDriverPtr techdriver; virNWFilterPoolObjPtr obj; virNWFilterHashTablePtr vars, vars1; @@ -512,6 +675,8 @@ _virNWFilterInstantiateFilter(virConnect char vmmacaddr[VIR_MAC_STRING_BUFLEN] = {0}; int foundNewFilter = 0; char *str_macaddr = NULL; + const char *ipaddr; + char *str_ipaddr = NULL; techdriver = virNWFilterTechDriverForName(drvname); @@ -523,25 +688,25 @@ _virNWFilterInstantiateFilter(virConnect return 1; } - VIR_DEBUG("filter name: %s\n", net->filter); + VIR_DEBUG("filter name: %s\n", filtername); - obj = virNWFilterPoolObjFindByName(&driver->pools, net->filter); + obj = virNWFilterPoolObjFindByName(&driver->pools, filtername); if (!obj) { virNWFilterReportError(conn, VIR_ERR_NO_NWFILTER, _("Could not find filter '%s'"), - net->filter); + filtername); return 1; } if (obj->wantRemoved) { virNWFilterReportError(conn, VIR_ERR_NO_NWFILTER, _("Filter '%s' is in use."), - net->filter); + filtername); rc = 1; goto err_exit; } - virFormatMacAddr(net->mac, vmmacaddr); + virFormatMacAddr(macaddr, vmmacaddr); str_macaddr = strdup(vmmacaddr); if (!str_macaddr) { virReportOOMError(); @@ -549,18 +714,29 @@ _virNWFilterInstantiateFilter(virConnect goto err_exit; } + ipaddr = virNWFilterGetIpAddrForIfname(ifname); + if (ipaddr) { + str_ipaddr = strdup(ipaddr); + if (!str_ipaddr) { + virReportOOMError(); + rc = 1; + goto err_exit; + } + } + vars1 = virNWFilterCreateVarHashmap(conn, - str_macaddr); + str_macaddr, str_ipaddr); if (!vars1) { rc = 1; goto err_exit; } str_macaddr = NULL; + str_ipaddr = NULL; vars = virNWFilterCreateVarsFrom(conn, vars1, - net->filterparams); + filterparams); if (!vars) { rc = 1; goto err_exit_vars1; @@ -582,12 +758,15 @@ _virNWFilterInstantiateFilter(virConnect rc = virNWFilterInstantiate(conn, techdriver, - net->type, + nettype, filter, - net->ifname, + ifname, + linkdev, vars, useNewFilter, &foundNewFilter, - teardownOld); + teardownOld, + macaddr, + driver); virNWFilterHashTableFree(vars); @@ -595,15 +774,180 @@ err_exit_vars1: virNWFilterHashTableFree(vars1); err_exit: - virNWFilterPoolObjUnlock(obj); + VIR_FREE(str_ipaddr); VIR_FREE(str_macaddr); return rc; } +static int +_virNWFilterInstantiateFilter(virConnectPtr conn, + const virDomainNetDefPtr net, + bool teardownOld, + enum instCase useNewFilter) +{ + const char *linkdev = (net->type == VIR_DOMAIN_NET_TYPE_DIRECT) + ? net->data.direct.linkdev + : NULL; + return __virNWFilterInstantiateFilter(conn, + teardownOld, + net->ifname, + linkdev, + net->type, + net->mac, + net->filter, + net->filterparams, + useNewFilter, + conn->nwfilterPrivateData); +} + + +// FIXME: move chgIfFlags, ifUp, checkIf into common file & share w/ macvtap.c + +/* + * chgIfFlags: Change flags on an interface + * @ifname : name of the interface + * @flagclear : the flags to clear + * @flagset : the flags to set + * + * The new flags of the interface will be calculated as + * flagmask = (~0 ^ flagclear) + * newflags = (curflags & flagmask) | flagset; + * + * Returns 0 on success, errno on failure. + */ +static int chgIfFlags(const char *ifname, short flagclear, short flagset) { + struct ifreq ifr; + int rc = 0; + int flags; + short flagmask = (~0 ^ flagclear); + int fd = socket(PF_PACKET, SOCK_DGRAM, 0); + + if (fd < 0) + return errno; + + if (virStrncpy(ifr.ifr_name, + ifname, strlen(ifname), sizeof(ifr.ifr_name)) == NULL) { + rc = ENODEV; + goto err_exit; + } + + if (ioctl(fd, SIOCGIFFLAGS, &ifr) < 0) { + rc = errno; + goto err_exit; + } + + flags = (ifr.ifr_flags & flagmask) | flagset; + + if (ifr.ifr_flags != flags) { + ifr.ifr_flags = flags; + + if (ioctl(fd, SIOCSIFFLAGS, &ifr) < 0) + rc = errno; + } + +err_exit: + close(fd); + return rc; +} + +/* + * ifUp + * @name: name of the interface + * @up: 1 for up, 0 for down + * + * Function to control if an interface is activated (up, 1) or not (down, 0) + * + * Returns 0 in case of success or an errno code in case of failure. + */ +static int +ifUp(const char *name, int up) +{ + return chgIfFlags(name, + (up) ? 0 : IFF_UP, + (up) ? IFF_UP : 0); +} + + +/** + * checkIf + * + * @ifname: Name of the interface + * @macaddr: expected MAC address of the interface + * + * FIXME: the interface's index is another good parameter to check + * + * Determine whether a given interface is still available. If so, + * it must have the given MAC address. + * + * Returns an error code ENODEV in case the interface does not exist + * anymore or its MAC address is different, 0 otherwise. + */ +int +checkIf(const char *ifname, const unsigned char *macaddr) +{ + struct ifreq ifr; + int fd = socket(PF_PACKET, SOCK_DGRAM, 0); + int rc = 0; + + if (fd < 0) + return errno; + + if (virStrncpy(ifr.ifr_name, + ifname, strlen(ifname), sizeof(ifr.ifr_name)) == NULL) { + rc = ENODEV; + goto err_exit; + } + + if (ioctl(fd, SIOCGIFHWADDR, &ifr) < 0) { + rc = errno; + goto err_exit; + } + + if (memcmp(&ifr.ifr_hwaddr.sa_data, macaddr, 6) != 0) + rc = ENODEV; + + err_exit: + close(fd); + return rc; +} + + +int +virNWFilterInstantiateFilterLate(virConnectPtr conn, + const char *ifname, + const char *linkdev, + enum virDomainNetType nettype, + const unsigned char *macaddr, + const char *filtername, + virNWFilterHashTablePtr filterparams, + virNWFilterDriverStatePtr driver) +{ + int rc; + rc = __virNWFilterInstantiateFilter(conn, + 1, + ifname, + linkdev, + nettype, + macaddr, + filtername, + filterparams, + INSTANTIATE_ALWAYS, + driver); + if (rc) { + //something went wrong... 'DOWN' the interface + if (ifUp(ifname ,0)) { + // assuming interface disappeared... + _virNWFilterTeardownFilter(ifname); + } + } + return rc; +} + + int virNWFilterInstantiateFilter(virConnectPtr conn, const virDomainNetDefPtr net) @@ -660,8 +1004,8 @@ virNWFilterTearOldFilter(virConnectPtr c } -int -virNWFilterTeardownFilter(const virDomainNetDefPtr net) +static int +_virNWFilterTeardownFilter(const char *ifname) { const char *drvname = EBIPTABLES_DRIVER_ID; virNWFilterTechDriverPtr techdriver; @@ -676,13 +1020,21 @@ virNWFilterTeardownFilter(const virDomai #endif return 1; } + techdriver->allTeardown(ifname); - techdriver->allTeardown(net->ifname); + virNWFilterDelIpAddrForIfname(ifname); return 0; } +int +virNWFilterTeardownFilter(const virDomainNetDefPtr net) +{ + return _virNWFilterTeardownFilter(net->ifname); +} + + void virNWFilterDomainFWUpdateCB(void *payload, const char *name ATTRIBUTE_UNUSED, Index: libvirt-acl/src/nwfilter/nwfilter_driver.c =================================================================== --- libvirt-acl.orig/src/nwfilter/nwfilter_driver.c +++ libvirt-acl/src/nwfilter/nwfilter_driver.c @@ -37,6 +37,8 @@ #include "nwfilter_gentech_driver.h" +#include "nwfilter_learnipaddr.h" + #define VIR_FROM_THIS VIR_FROM_NWFILTER #define nwfilterLog(msg...) fprintf(stderr, msg) @@ -65,9 +67,12 @@ static int nwfilterDriverStartup(int privileged) { char *base = NULL; - if (virNWFilterConfLayerInit(virNWFilterDomainFWUpdateCB) < 0) + if (virNWFilterLearnInit() < 0) return -1; + if (virNWFilterConfLayerInit(virNWFilterDomainFWUpdateCB) < 0) + goto conf_init_err; + if (VIR_ALLOC(driverState) < 0) goto alloc_err_exit; @@ -120,6 +125,9 @@ error: alloc_err_exit: virNWFilterConfLayerShutdown(); +conf_init_err: + virNWFilterLearnShutdown(); + return -1; } @@ -413,5 +421,6 @@ static virStateDriver stateDriver = { int nwfilterRegister(void) { virRegisterNWFilterDriver(&nwfilterDriver); virRegisterStateDriver(&stateDriver); + virNWFilterLearnInit(); return 0; } Index: libvirt-acl/src/nwfilter/nwfilter_gentech_driver.h =================================================================== --- libvirt-acl.orig/src/nwfilter/nwfilter_gentech_driver.h +++ libvirt-acl/src/nwfilter/nwfilter_gentech_driver.h @@ -46,13 +46,25 @@ int virNWFilterRollbackUpdateFilter(virC int virNWFilterTearOldFilter(virConnectPtr conn, const virDomainNetDefPtr net); +int virNWFilterInstantiateFilterLate(virConnectPtr conn, + const char *ifname, + const char *linkdev, + enum virDomainNetType nettype, + const unsigned char *macaddr, + const char *filtername, + virNWFilterHashTablePtr filterparams, + virNWFilterDriverStatePtr driver); + int virNWFilterTeardownFilter(const virDomainNetDefPtr net); virNWFilterHashTablePtr virNWFilterCreateVarHashmap(virConnectPtr conn, - char *macaddr); + char *macaddr, + char *ipaddr); void virNWFilterDomainFWUpdateCB(void *payload, const char *name ATTRIBUTE_UNUSED, void *data); +int checkIf(const char *ifname, const unsigned char *macaddr); + #endif Index: libvirt-acl/src/libvirt_private.syms =================================================================== --- libvirt-acl.orig/src/libvirt_private.syms +++ libvirt-acl/src/libvirt_private.syms @@ -488,6 +488,8 @@ virNWFilterRegisterCallbackDriver; virNWFilterTestUnassignDef; virNWFilterConfLayerInit; virNWFilterConfLayerShutdown; +virNWFilterLockFilterUpdates; +virNWFilterUnlockFilterUpdates; #nwfilter_params.h @@ -503,6 +505,16 @@ virNWFilterInstantiateFilter; virNWFilterTeardownFilter; +#nwfilter_learnipaddr.h +ipAddressMap; +ipAddressMapLock; +pendingLearnReq; +pendingLearnReqLock; +virNWFilterGetIpAddrForIfname; +virNWFilterDelIpAddrForIfname; +virNWFilterLookupLearnReq; + + # pci.h pciGetDevice; pciFreeDevice; Index: libvirt-acl/src/conf/nwfilter_conf.c =================================================================== --- libvirt-acl.orig/src/conf/nwfilter_conf.c +++ libvirt-acl/src/conf/nwfilter_conf.c @@ -111,17 +111,18 @@ struct int_map { */ static virMutex updateMutex; -static void +void virNWFilterLockFilterUpdates(void) { virMutexLock(&updateMutex); } -static void +void virNWFilterUnlockFilterUpdates(void) { virMutexUnlock(&updateMutex); } + /* * attribute names for the rules XML */ @@ -2731,7 +2732,7 @@ int virNWFilterConfLayerInit(virHashIter { virNWFilterDomainFWUpdateCB = domUpdateCB; - if (virMutexInit(&updateMutex)) + if (virMutexInitRecursive(&updateMutex)) return 1; if (virNWFilterParamConfLayerInit()) Index: libvirt-acl/src/conf/nwfilter_conf.h =================================================================== --- libvirt-acl.orig/src/conf/nwfilter_conf.h +++ libvirt-acl/src/conf/nwfilter_conf.h @@ -565,6 +565,9 @@ virNWFilterDefPtr virNWFilterDefParseFil void virNWFilterPoolObjLock(virNWFilterPoolObjPtr obj); void virNWFilterPoolObjUnlock(virNWFilterPoolObjPtr obj); +void virNWFilterLockFilterUpdates(void); +void virNWFilterUnlockFilterUpdates(void); + int virNWFilterConfLayerInit(virHashIterator domUpdateCB); void virNWFilterConfLayerShutdown(void); Index: libvirt-acl/src/nwfilter/nwfilter_ebiptables_driver.c =================================================================== --- libvirt-acl.orig/src/nwfilter/nwfilter_ebiptables_driver.c +++ libvirt-acl/src/nwfilter/nwfilter_ebiptables_driver.c @@ -2533,6 +2533,106 @@ ebiptablesInstCommand(virConnectPtr conn } +int +ebtablesApplyBasicRules(virConnectPtr conn, + const char *ifname, + const unsigned char *macaddr) +{ + virBuffer buf = VIR_BUFFER_INITIALIZER; + int cli_status; + char chain[MAX_CHAINNAME_LENGTH]; + char chainPrefix = CHAINPREFIX_HOST_IN_TEMP; + char macaddr_str[VIR_MAC_STRING_BUFLEN]; + + virFormatMacAddr(macaddr, macaddr_str); + + ebtablesUnlinkTmpRootChain(conn, &buf, 1, ifname); + ebtablesUnlinkTmpRootChain(conn, &buf, 0, ifname); + ebtablesRemoveTmpSubChains(conn, &buf, ifname); + ebtablesRemoveTmpRootChain(conn, &buf, 1, ifname); + ebtablesRemoveTmpRootChain(conn, &buf, 0, ifname); + ebiptablesExecCLI(conn, &buf, &cli_status); + + ebtablesCreateTmpRootChain(conn, &buf, 1, ifname, 1); + + PRINT_ROOT_CHAIN(chain, chainPrefix, ifname); + virBufferVSprintf(&buf, + CMD_DEF(EBTABLES_CMD + " -t %s -A %s -s ! %s -j DROP") CMD_SEPARATOR + CMD_EXEC + "%s", + + EBTABLES_DEFAULT_TABLE, + chain, + macaddr_str, + CMD_STOPONERR(1)); + + virBufferVSprintf(&buf, + CMD_DEF(EBTABLES_CMD + " -t %s -A %s -p IPv4 -j ACCEPT") CMD_SEPARATOR + CMD_EXEC + "%s", + + EBTABLES_DEFAULT_TABLE, + chain, + CMD_STOPONERR(1)); + + virBufferVSprintf(&buf, + CMD_DEF(EBTABLES_CMD + " -t %s -A %s -p ARP -j ACCEPT") CMD_SEPARATOR + CMD_EXEC + "%s", + + EBTABLES_DEFAULT_TABLE, + chain, + CMD_STOPONERR(1)); + + virBufferVSprintf(&buf, + CMD_DEF(EBTABLES_CMD + " -t %s -A %s -j DROP") CMD_SEPARATOR + CMD_EXEC + "%s", + + EBTABLES_DEFAULT_TABLE, + chain, + CMD_STOPONERR(1)); + + ebtablesLinkTmpRootChain(conn, &buf, 1, ifname, 1); + + if (ebiptablesExecCLI(conn, &buf, &cli_status) || cli_status != 0) + goto tear_down_tmpebchains; + + return 0; + +tear_down_tmpebchains: + ebtablesRemoveBasicRules(conn, ifname); + + virNWFilterReportError(conn, VIR_ERR_BUILD_FIREWALL, + "%s", + _("Some rules could not be created.")); + + return 1; +} + + +int +ebtablesRemoveBasicRules(virConnectPtr conn, + const char *ifname) +{ + virBuffer buf = VIR_BUFFER_INITIALIZER; + int cli_status; + + ebtablesUnlinkTmpRootChain(conn, &buf, 1, ifname); + ebtablesUnlinkTmpRootChain(conn, &buf, 0, ifname); + ebtablesRemoveTmpSubChains(conn, &buf, ifname); + ebtablesRemoveTmpRootChain(conn, &buf, 1, ifname); + ebtablesRemoveTmpRootChain(conn, &buf, 0, ifname); + + ebiptablesExecCLI(conn, &buf, &cli_status); + return 0; +} + + static int ebiptablesRuleOrderSort(const void *a, const void *b) { Index: libvirt-acl/src/nwfilter/nwfilter_ebiptables_driver.h =================================================================== --- libvirt-acl.orig/src/nwfilter/nwfilter_ebiptables_driver.h +++ libvirt-acl/src/nwfilter/nwfilter_ebiptables_driver.h @@ -45,4 +45,11 @@ extern virNWFilterTechDriver ebiptables_ # define EBIPTABLES_DRIVER_ID "ebiptables" + +int ebtablesApplyBasicRules(virConnectPtr conn, + const char *ifname, + const unsigned char *macaddr); +int ebtablesRemoveBasicRules(virConnectPtr conn, + const char *ifname); + #endif Index: libvirt-acl/configure.ac =================================================================== --- libvirt-acl.orig/configure.ac +++ libvirt-acl/configure.ac @@ -41,6 +41,7 @@ XMLRPC_REQUIRED=1.14.0 HAL_REQUIRED=0.5.0 DEVMAPPER_REQUIRED=1.0.0 LIBCURL_REQUIRED="7.18.0" +LIBPCAP_REQUIRED="1.0.0" dnl Checks for C compiler. AC_PROG_CC @@ -1045,6 +1046,39 @@ AC_SUBST([NUMACTL_CFLAGS]) AC_SUBST([NUMACTL_LIBS]) +dnl pcap lib +LIBPCAP_CONFIG="pcap-config" +LIBPCAP_CFLAGS="" +LIBPCAP_LIBS="" +LIBPCAP_FOUND="no" + +AC_ARG_WITH([libpcap], AC_HELP_STRING([--with-libpcap=@<:@PFX@:>@], [libpcap location])) +if test "$with_qemu" = "yes"; then + if test "x$with_libpcap" != "xno" ; then + if test "x$with_libpcap" != "x" ; then + LIBPCAP_CONFIG=$with_libpcap/bin/$LIBPCAP_CONFIG + fi + AC_MSG_CHECKING(libpcap $LIBPCAP_CONFIG >= $LIBPCAP_REQUIRED ) + if ! $LIBPCAP_CONFIG --libs > /dev/null 2>&1 ; then + AC_MSG_RESULT(no) + else + LIBPCAP_LIBS="`$LIBPCAP_CONFIG --libs`" + LIBPCAP_CFLAGS="`$LIBPCAP_CONFIG --cflags`" + LIBPCAP_FOUND="yes" + AC_MSG_RESULT(yes) + fi + fi +fi + +if test "x$LIBPCAP_FOUND" = "xyes"; then + AC_DEFINE_UNQUOTED([HAVE_LIBPCAP], 1, [whether libpcap can be used]) +fi + +AC_SUBST([LIBPCAP_CFLAGS]) +AC_SUBST([LIBPCAP_LIBS]) + + + dnl dnl Checks for the UML driver dnl @@ -2129,6 +2163,11 @@ AC_MSG_NOTICE([ xmlrpc: $XMLRPC_CFLAGS else AC_MSG_NOTICE([ xmlrpc: no]) fi +if test "$with_qemu" = "yes" ; then +AC_MSG_NOTICE([ pcap: $LIBPCAP_CFLAGS $LIBPCAP_LIBS]) +else +AC_MSG_NOTICE([ pcap: no]) +fi AC_MSG_NOTICE([]) AC_MSG_NOTICE([Test suite]) AC_MSG_NOTICE([])

3 4

[libvirt] [RFC]: Snapshot API v3
by Chris Lalancette 01 Apr '10

01 Apr '10

Hello, After our discussions about the snapshot API last week, I went ahead and implemented quite a bit of the API. I also went back to the ESX, Virtualbox, and QEMU API's to try and make sure our API's matched up. What's below is my revised API based on that survey. Following my revised API are notes that I took regarding how the libvirt API matches up to the various API's, and some questions about semantics that I had while doing the survey. More comments and questions are welcome. /* NOTE: struct _virDomainSnapshot is a private structure, ala * struct _virDomain. */ typedef struct _virDomainSnapshot virDomainSnapshot; /* Take a snapshot of the current VM state. Throws an error if * the VM is not currently running */ virDomainSnapshotPtr virDomainSnapshotCreateXML(virDomainPtr domain, const char *xmlDesc, unsigned int flags); /* Dump the XML of a snapshot */ /* NOTE: see below for proposed XML */ char *virDomainSnapshotGetXMLDesc(virDomainSnapshotPtr snapshot, unsigned int flags); /* Return the number of snapshots for this domain */ int virDomainSnapshotNum(virDomainPtr domain, unsigned int flags); /* Get the names of all snapshots for this domain */ int virDomainListSnapshotNames(virDomainPtr domain, char **names, int nameslen, unsigned int flags); /* Get a handle to a named snapshot */ virDomainSnapshotPtr virDomainSnapshotLookupByName(virDomainPtr domain, const char *name, unsigned int flags); /* Get a handle to the current in-use snapshot for the domain */ virDomainSnapshotPtr virDomainSnapshotCurrent(virDomainPtr domain, unsigned int flags); /* Start the guest from the snapshot "snapshot" */ int virDomainCreateFromSnapshot(virDomainSnapshotPtr snapshot, unsigned int flags); /* Rename the snapshot */ /* Do we really need this? In theory we could use * virsh snapshot-edit <domain> <name> and then detect * name changes, but that will require a UUID, which may * or may not be overkill */ int virDomainSnapshotRename(virDomainSnapshotPtr snapshot, char *newname, unsigned int flags); /* Delete a snapshot - with no flags, the snapshot is not used anymore, * but also not removed. With a MERGE flag, it merges the snapshot into * the parent snapshot (or the base image, if there is no parent snapshot). * Note that if other snapshots would be discarded because of this * MERGE action, this operation will fail. If that is really what is intended, * use MERGE_FORCE. * * With a DISCARD flag, it deletes the snapshot. Note that if children snapshots * would be discarded because of this delete action, this operation will * fail. If this is really what is intended, use DISCARD_FORCE. * * MERGE, MERGE_FORCE, DISCARD, and DISCARD_FORCE are mutually-exclusive. * * Note that this operation can happen when the domain is running or shut * down, though this is hypervisor specific */ typedef enum { VIR_DOMAIN_SNAPSHOT_DELETE_MERGE, VIR_DOMAIN_SNAPSHOT_DELETE_MERGE_FORCE, VIR_DOMAIN_SNAPSHOT_DELETE_DISCARD, VIR_DOMAIN_SNAPSHOT_DELETE_DISCARD_FORCE, } virDomainSnapshotDelete; int virDomainSnapshotDelete(virDomainSnapshotPtr snapshot, unsigned int flags); int virDomainSnapshotFree(virDomainSnapshotPtr snapshot); NOTE: During snapshot creation, *none* of the fields are required. That is, you can call virDomainSnapshotCreateXML() with an XML of "<domainsnapshot/>". In this case, the individual driver will make up a <name> and <uuid> for you, the <creationdate> will be set to the current time+date, <description> will be empty, <state> will be the current state of the VM, and <parent> will be set to the current snapshot (if any). If you do want to specify some fields during virDomainSnapshotCreateXML(), note that the only ones that are settable are <name>, <uuid>, and <description>; the rest are ignored, and filled in by the driver when the snapshot is actually created. NOTE: <state> refers to the state of the VM when the snapshot was taken. <domainsnapshot> <name>XYZ</name> <creationdate>...</creationdate> <description>...</description> <state>RUNNING</state> <domain> <uuid>XXXXX-XXXX-XXXX-XXXX-XXXXXXXXX</uuid> </domain> <parent> <name>ABC</name> </parent> </domainsnapshot> The virsh commands will be: virsh snapshot-create <dom> <xmlfile> virsh snapshot-list <dom> virsh snapshot-dumpxml <dom> <name> virsh start-with-snapshot <dom> <snapshotname> virsh snapshot-delete <dom> <snapshotname> [--merge|--mergeforce|--delete|--deleteforce] virsh snapshot-delete-all <dom> Possible issues: 1) I don't see a way to support "managed" save/restore and snapshotting with this API. I think we'll have to have a separate API for managed save/restore. 2) What is the semantic for deleting snapshots from a running domain? Virtualbox seems to not allow you to manipulate snapshots while the domain is running. Qemu does allow this, but it's currently unclear what the exact semantics are. VMware seems to allow manipulation of snapshots while the domain is running. 3) Do we need a snapshot UUID? Virtualbox allows you to have multiple snapshots with the same name, differentiated by UUID. Confusingly, they also have a "FindByName" method that returns the first depth-first search snapshot that matches a given name. For qemu, if you specify the same name twice it overwrites the previous one with the new one. I don't know what ESX does here. Mapping of our interface to various hypervisors: +-------------------------------+-----------------+-------------------+------------------------------+ | Libvirt | Qemu | Virtualbox | ESX | +-------------------------------+-----------------+-------------------+------------------------------+ | virDomainSnapshotCreateXML | monitor command | takeSnapshot | CreateSnapshot_task | | | "savevm"; if | Snapshots can | takes a name, description, | | | snapshot name | be taken on | memory (true/false) and | | | is already in | powered off, | quiesce (true/false). | | | use, replaces | saved, running, | What does "memory" mean? | | | the previous | or paused VMs. | Should we model "quiesce" | | | snapshot. Also | The snapshot is | Trees of snapshots are | | | qemu-img | always taken | supported. What happens | | | snapshot -c can | against the | on a duplicate name? What | | | be used to | current snapshot. | state(s) can a VM be in | | | create a | What happens on | when calling this? Does | | | disk-only | a duplicate | a VM get paused when this | | | snapshot. What | name? Trees of | is called? | | | happens if the | snapshots are | | | | VM is running | not currently | | | | when you do | supported. | | | | this? Trees of | Taking a snapshot | | | | snapshots seem | of a running VM | | | | to be supported | pauses the VM | | | | VM gets paused | before taking the | | | | while this is | snapshot. | | | | happening. What | | | | | states can the | | | | | VM be in? | | | +-------------------------------+-----------------+-------------------+------------------------------+ | virDomainSnapshotGetXMLDesc | Libvirt qemu | GetId | VirtualMachine object-> | | | snapshot | GetDescription | snapshot-> rootSnapshotList | | | metadata | GetTimeStamp | [i].createTime | | | | GetParent | .description | | | | GetCurrentSnapshot| .name | | | | | .id | | | | | .state | | | | | .quiesced | | | | | .vm | +-------------------------------+-----------------+-------------------+------------------------------+ | virDomainSnapshotNum | Libvirt qemu | GetSnapshotCount | VirtualMachine object-> | | | snapshot | | snapshot-> rootSnapshotList | | | metadata | | | +-------------------------------+-----------------+-------------------+------------------------------+ | virDomainListSnapshotNames | Libvirt qemu | GetSnapshotCount | VirtualMachine object-> | | | snapshot | GetChildren | snapshot-> rootSnapshotList | | | metadata, or | | | | | listvm monitor | | | | | command or | | | | | qemu-img | | | | | snapshot -l | | | | | <file>. If the | | | | | VM has multiple | | | | | disks and the | | | | | disks have | | | | | different | | | | | snapshots, what | | | | | do you do? | | | +-------------------------------+-----------------+-------------------+------------------------------+ | virDomainSnapshotLookupByName | " | findSnapshot | VirtualMachine object-> | | | | Takes a name and | snapshot-> rootSnapshotList | | | | returns a | | | | | snapshot object. | | | | | In case of | | | | | multiple snapshots| | | | | with the same | | | | | name, it returns | | | | | the first object | | | | | from a depth | | | | | first search. | | +-------------------------------+-----------------+-------------------+------------------------------+ | virDomainCreateFromSnapshot | qemu-img | restoreSnapshot | RevertToSnapshot_Task | | | snapshot -a | Takes a snapshot | Changes execution state | | | <snapname> | object, and | of VM to state of this | | | <file>. What | resets the VM's | snapshot. Takes a | | | happens if the | state to that of | snapshot object, an | | | VM has multiple | the snapshot. | optional host, and | | | files with | If this is a | suppressPowerOn, which | | | different | snapshot taken | forces the VM to the off | | | snapshots? | against a running | state regardless of the | | | | machine, then the | state when the snapshot | | | | memory is | was taken. Implies that | | | | restored as well. | without this flag, VM | | | | Does *not* start | starts in whatever | | | | the VM. The VM | <state> was when snapshot | | | | must be off for | was taken. | | | | this operation to | | | | | succeed. | | +-------------------------------+-----------------+-------------------+------------------------------+ | virDomainSnapshotDelete | monitor command | deleteSnapshot | RemoveSnapshot_Task | | | "delvm". What | deletes the | removes this snapshot and | | | happens if the | specified | deletes any associated | | | snapshot is in | snapshot. Takes | storage. Operates on a | | | use? What | an ID. The VM | VirtualMachineSnapshot | | | states can the | must be off. | object. What states can | | | VM be in? Also | Differences to | the VM be in? What | | | qemu-img | children | happens if this snapshot | | | snapshot -d | snapshots will be | is in-use? What happens | | | <name> <file> | merged with the | to parents and children? | | | command can be | children to keep | | | | used. What | children valid. | | | | happens if the | Parent for this | | | | disk is in-use? | snapshot will | | | | What happens to | become parent of | | | | parents and | any children | | | | children? | snapshots. | | | | How do we | | | | | handle merges? | | | +-------------------------------+-----------------+-------------------+------------------------------+ | virDomainSnapshotCurrent | Libvirt qemu | currentSnapshot | VirtualMachine object-> | | | snapshot | | snapshot-> currentSnapshot | | | metadata | | | +-------------------------------+-----------------+-------------------+------------------------------+ | virDomainSnapshotRename | Libvirt qemu | ISnapshot->name | RenameSnapshot | | | snapshot | | | | | metadata | | | +-------------------------------+-----------------+-------------------+------------------------------+ | virDomainSnapshotDelete with | Libvirt qemu | deleteSnapshot | RemoveAllSnapshots_Task | | DISCARD_FORCE flag against | snapshot | with manual depth | | | root snapshot | metadata | deletion of | | | | | children | | +-------------------------------+-----------------+-------------------+------------------------------+ | | | | RevertToCurrentSnapshot_Task | +-------------------------------+-----------------+-------------------+------------------------------+ Attribute mapping: +----------------+----------+-------------+----------------------------+ | Libvirt | Qemu | Virtualbox | ESX | +----------------+----------+-------------+----------------------------+ | <name> | TAG | name | name | +----------------+----------+-------------+----------------------------+ | <creationdate> | DATE | timeStamp | createTime | +----------------+----------+-------------+----------------------------+ | <description> | Libvirt | description | description | | | qemu | | | | | metadata | | | +----------------+----------+-------------+----------------------------+ | <state> | Libvirt | online | state (this is the *power* | | | qemu | | state of the VM when this | | | metadata | | snapshot was taken) | +----------------+----------+-------------+----------------------------+ | <domain><uuid> | Libvirt | machine | vm | | | qemu | | | | | metadata | | | +----------------+----------+-------------+----------------------------+ | <parent><name> | Libvirt | parent | N/A | | | qemu | | | | | metadata | | | +----------------+----------+-------------+----------------------------+ | N/A | N/A | id (uuid) | id | +----------------+----------+-------------+----------------------------+ | N/A | N/A | children | childSnapshotList | +----------------+----------+-------------+----------------------------+ | N/A | N/A | N/A | memory | +----------------+----------+-------------+----------------------------+ | N/A | N/A | N/A | quiesced | +----------------+----------+-------------+----------------------------+ | N/A | N/A | N/A | backupManifest | +----------------+----------+-------------+----------------------------+ | N/A | N/A | N/A | replaySupported | +----------------+----------+-------------+----------------------------+ -- Chris Lalancette

6 13

[libvirt] [RFC] Managed save APIs
by Daniel Veillard 01 Apr '10

01 Apr '10

The current API provides the following Save abd Restore functions: int virDomainSave (virDomainPtr domain, const char *to); int virDomainRestore (virConnectPtr conn, const char *from); where the user provide the path to the file used to hold the domain saved state. However it can be really useful to have a managed version where libvirt itself stores the data. It can then automatically reuse it once the domain is to be restarted. This also avoid the problem of keeping stale saved data once a domain has been restarted independantly. One of our use case was to save the running domains state on shutdown, and unfortunately virDomainSave()/virDomainRestore() can't be used for that because if one of the domain is labelled as autorestart, as soon as the daemon would restart it would recreate the guest but without knowledge of the backup state. So we propose the 3 following new APIs to deal with managed saves: int virDomainManagedSave(virDomainPtr dom, unsigned int flags); int virDomainHasManagedSaveImage(virDomainPtr dom, unsigned int flags); int virDomainManagedSaveRemove(virDomainPtr dom, unsigned int flags); virDomainManagedSave() is to be run on a running domain. Once the call complete, as in virDomainSave() the domain is stopped upon completion, but there is no restore counterpart as any order to start the domain from the API would load the state from the managed file, similary if the domain is autostarted when libvirtd starts. Once a domain has restarted his managed save image is destroyed, basically managed save image can only exist for a stopped domain, for a running domain that would be by definition outdated data. Suggested new entry points in libvirt.c are below, thanks in advance for any feedback (and thanks to Chris Lalancette who started this work): diff --git a/src/libvirt.c b/src/libvirt.c index cc5b4c5..293ea17 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -12135,3 +12135,143 @@ error: virDispatchError(conn); return -1; } + +/** + * virDomainManagedSave: + * @dom: pointer to the domain + * @flags: optional flags currently unused + * + * This method will suspend a domain and save its memory contents to + * a file on disk. After the call, if successful, the domain is not + * listed as running anymore. + * The difference from virDomainSave() is that libvirt is keeping track of + * the saved state itself, and will reuse it once the domain is being + * restarted (automatically or via an explicit libvirt call). + * As a result any running domain is sure to not have a managed saved image. + * + * Returns 0 in case of success or -1 in case of failure + */ +int virDomainManagedSave(virDomainPtr dom, unsigned int flags) +{ + virConnectPtr conn; + + VIR_DEBUG("dom=%p, flags=%u", dom, flags); + + virResetLastError(); + + if (!VIR_IS_CONNECTED_DOMAIN(dom)) { + virLibDomainError(NULL, VIR_ERR_INVALID_DOMAIN, __FUNCTION__); + virDispatchError(NULL); + return -1; + } + + conn = dom->conn; + if (conn->flags & VIR_CONNECT_RO) { + virLibDomainError(dom, VIR_ERR_OPERATION_DENIED, __FUNCTION__); + goto error; + } + + if (conn->driver->domainManagedSave) { + int ret; + + ret = conn->driver->domainManagedSave(dom, flags); + if (ret < 0) + goto error; + return ret; + } + + virLibConnError(conn, VIR_ERR_NO_SUPPORT, __FUNCTION__); + +error: + virDispatchError(conn); + return -1; +} + +/** + * virDomainHasManagedSaveImage: + * @dom: pointer to the domain + * @flags: optional flags currently unused + * + * Check if a domain has a managed save image as created by + * virDomainManagedSave(). Note that any running domain should not have + * such an image, as it should have been removed on restart. + * + * Returns 0 if no image is present, 1 if an image is present, and + * -1 in case of error + */ +int virDomainHasManagedSaveImage(virDomainPtr dom, unsigned int flags) +{ + virConnectPtr conn; + + VIR_DEBUG("dom=%p, flags=%u", dom, flags); + + virResetLastError(); + + if (!VIR_IS_CONNECTED_DOMAIN(dom)) { + virLibDomainError(NULL, VIR_ERR_INVALID_DOMAIN, __FUNCTION__); + virDispatchError(NULL); + return -1; + } + + conn = dom->conn; + + if (conn->driver->domainHasManagedSaveImage) { + int ret; + + ret = conn->driver->domainHasManagedSaveImage(dom, flags); + if (ret < 0) + goto error; + return ret; + } + + virLibConnError(conn, VIR_ERR_NO_SUPPORT, __FUNCTION__); + +error: + virDispatchError(conn); + return -1; +} + +/** + * virDomainManagedSaveRemove: + * @dom: pointer to the domain + * @flags: optional flags currently unused + * + * Remove any managed save image as for this domain. + * + * Returns 0 in case of success, and -1 in case of error + */ +int virDomainManagedSaveRemove(virDomainPtr dom, unsigned int flags) +{ + virConnectPtr conn; + + VIR_DEBUG("dom=%p, flags=%u", dom, flags); + + virResetLastError(); + + if (!VIR_IS_CONNECTED_DOMAIN(dom)) { + virLibDomainError(NULL, VIR_ERR_INVALID_DOMAIN, __FUNCTION__); + virDispatchError(NULL); + return -1; + } + + conn = dom->conn; + if (conn->flags & VIR_CONNECT_RO) { + virLibDomainError(dom, VIR_ERR_OPERATION_DENIED, __FUNCTION__); + goto error; + } + + if (conn->driver->domainManagedSaveRemove) { + int ret; + + ret = conn->driver->domainManagedSaveRemove(dom, flags); + if (ret < 0) + goto error; + return ret; + } + + virLibConnError(conn, VIR_ERR_NO_SUPPORT, __FUNCTION__); + +error: + virDispatchError(conn); + return -1; +} Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] [PATCH 00/10] Begin to replace scanf and atoi
by Matthias Bolte 01 Apr '10

01 Apr '10

This set of patches is a first step towards removing the scanf and atoi usage in libvirt. I began with the simple cases and post this now to get some feedback before I start to convert the more difficult ones. 01/10 Replace sscanf in legacy device address parsing 02/10 Replace sscanf in nwfilter rule parsing 03/10 Refactor major.minor.micro version parsing into a function 04/10 cgroup: Replace sscanf with virStrToLong_ll 05/10 vbox: Replace atoi with virStrToLong_i 06/10 xen: Use virParseMacAddr instead of sscanf 07/10 openvz: Use strtok_r instead of sscanf for VPS UUID parsing 08/10 xenapi: Use virStrToLong_i instead of sscanf for CPU map parsing 09/10 xen: Use virStrToLong_i instead of sscanf for XenD port parsing 10/10 Replace sscanf in PCI device address parsing src/conf/domain_conf.c | 38 +++++++++++++++++++--------- src/conf/nwfilter_conf.c | 10 +++--- src/esx/esx_driver.c | 31 ++++------------------ src/libvirt_private.syms | 1 + src/lxc/lxc_driver.c | 10 +------ src/openvz/openvz_conf.c | 27 ++++++++++++------- src/uml/uml_conf.h | 2 +- src/uml/uml_driver.c | 17 ++++++------ src/util/cgroup.c | 3 +- src/util/pci.c | 59 ++++++++++++++++++++++++++++++++++--------- src/util/util.c | 37 +++++++++++++++++++++++++++ src/util/util.h | 1 + src/vbox/vbox_tmpl.c | 18 +++++-------- src/xen/xend_internal.c | 20 ++------------ src/xen/xm_internal.c | 19 +++---------- src/xenapi/xenapi_driver.c | 21 +++++++-------- src/xenapi/xenapi_utils.c | 3 +- 17 files changed, 179 insertions(+), 138 deletions(-) Matthias

5 31

[libvirt] [PATCH] website: Add archive link for libvirt-users list
by Matthias Bolte 01 Apr '10

01 Apr '10

--- docs/contact.html.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/contact.html.in b/docs/contact.html.in index 09f8e35..c9dceda 100644 --- a/docs/contact.html.in +++ b/docs/contact.html.in @@ -21,7 +21,7 @@ </ul> </dd> - <dt><a href="">libvirt-users(a)redhat.com</a></dt> + <dt><a href="https://www.redhat.com/archives/libvirt-users/">libvirt-users(a)redhat.com</a></dt> <dd>This list a place for discussions involving libvirt users. Topics for discussion include <ul> <li>Usage of libvirt / virsh</li> -- 1.6.3.3

2 2

[libvirt] [PATCH] Fix apibuild.py warning about virNWFilterLookupByUUIDString
by Matthias Bolte 01 Apr '10

01 Apr '10

The function name was written with capital I in the Filter part. --- src/libvirt.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 138dd31..5247fe7 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -11333,7 +11333,7 @@ error: } /** - * virNWFIlterLookupByUUIDString: + * virNWFilterLookupByUUIDString: * @conn: pointer to the hypervisor connection * @uuidstr: the string UUID for the nwfilter * -- 1.6.3.3

2 2

[libvirt] Patch for Vepa support in brctl
by Kumar L Srikanth-B22348 01 Apr '10

01 Apr '10

Hi Daniel, Can you please provide a valid patch for 'brctl' utility, to support 'vepa' mode. Regards, Srikanth.

3 2

[libvirt] [PATCH] Blank out invalid interface names with escaped letters etc.
by Stefan Berger 01 Apr '10

01 Apr '10

Hunt interface names through a regular expression matcher to check whether they only contain valid characters. Valid characters in this code are currently a-z,A-Z,0-9, and '_'. Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com> --- src/conf/domain_conf.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) Index: libvirt-acl/src/conf/domain_conf.c =================================================================== --- libvirt-acl.orig/src/conf/domain_conf.c +++ libvirt-acl/src/conf/domain_conf.c @@ -28,6 +28,7 @@ #include <unistd.h> #include <fcntl.h> #include <dirent.h> +#include <regex.h> #include "virterror_internal.h" #include "datatypes.h" @@ -1776,6 +1777,23 @@ cleanup: } +static bool +isValidIfname(const char *ifname) { + int rc = 1; + regex_t regex_ifname; + + if (regcomp(&regex_ifname, "^[a-zA-Z0-9_]+$", + REG_NOSUB|REG_EXTENDED) != 0) + return 0; + + if (regexec(&regex_ifname, ifname, 0, NULL, 0) != 0) + rc = 0; + + regfree(&regex_ifname); + return rc; +} + + /* Parse the XML definition for a network interface * @param node XML nodeset to parse for net definition @@ -1859,8 +1877,10 @@ virDomainNetDefParseXML(virCapsPtr caps, xmlStrEqual(cur->name, BAD_CAST "target")) { ifname = virXMLPropString(cur, "dev"); if ((ifname != NULL) && - (STRPREFIX((const char*)ifname, "vnet"))) { + ((STRPREFIX((const char*)ifname, "vnet")) || + (!isValidIfname(ifname)))) { /* An auto-generated target name, blank it out */ + /* blank out invalid interface names */ VIR_FREE(ifname); } } else if ((script == NULL) &&

3 2

[libvirt] [PATCH] maint: remove redundant tests after virStrToLong
by Eric Blake 01 Apr '10

01 Apr '10

virStrToLong* guarantees (via strtol) that the end pointer will be set to the point at which parsing stopped (even on failure, this point is the start of the input string). * src/esx/esx_driver.c (esxGetVersion): Remove pointless conditional. * src/qemu/qemu_conf.c (qemuParseCommandLinePCI) (qemuParseCommandLineUSB, qemuParseCommandLineSmp): Likewise. * src/qemu/qemu_monitor_text.c (qemuMonitorTextGetMigrationStatus): Likewise. --- src/esx/esx_driver.c | 6 ++---- src/qemu/qemu_conf.c | 14 ++++++-------- src/qemu/qemu_monitor_text.c | 6 +++--- 3 files changed, 11 insertions(+), 15 deletions(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index bbe8a51..f07493e 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -690,13 +690,11 @@ esxGetVersion(virConnectPtr conn, unsigned long *version) temp = (char *)priv->host->service->about->version; /* Expecting 'major.minor.release' format */ - if (virStrToLong_ui(temp, &temp, 10, &major) < 0 || temp == NULL || - *temp != '.') { + if (virStrToLong_ui(temp, &temp, 10, &major) < 0 || *temp != '.') { goto failure; } - if (virStrToLong_ui(temp + 1, &temp, 10, &minor) < 0 || temp == NULL || - *temp != '.') { + if (virStrToLong_ui(temp + 1, &temp, 10, &minor) < 0 || *temp != '.') { goto failure; } diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 8f6f7ec..5d0b211 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -5217,14 +5217,14 @@ qemuParseCommandLinePCI(const char *val) } start = val + strlen("host="); - if (virStrToLong_i(start, &end, 16, &bus) < 0 || !end || *end != ':') { + if (virStrToLong_i(start, &end, 16, &bus) < 0 || *end != ':') { qemuReportError(VIR_ERR_INTERNAL_ERROR, _("cannot extract PCI device bus '%s'"), val); VIR_FREE(def); goto cleanup; } start = end + 1; - if (virStrToLong_i(start, &end, 16, &slot) < 0 || !end || *end != '.') { + if (virStrToLong_i(start, &end, 16, &slot) < 0 || *end != '.') { qemuReportError(VIR_ERR_INTERNAL_ERROR, _("cannot extract PCI device slot '%s'"), val); VIR_FREE(def); @@ -5275,7 +5275,7 @@ qemuParseCommandLineUSB(const char *val) start = val + strlen("host:"); if (strchr(start, ':')) { - if (virStrToLong_i(start, &end, 16, &first) < 0 || !end || *end != ':') { + if (virStrToLong_i(start, &end, 16, &first) < 0 || *end != ':') { qemuReportError(VIR_ERR_INTERNAL_ERROR, _("cannot extract USB device vendor '%s'"), val); VIR_FREE(def); @@ -5289,7 +5289,7 @@ qemuParseCommandLineUSB(const char *val) goto cleanup; } } else { - if (virStrToLong_i(start, &end, 10, &first) < 0 || !end || *end != '.') { + if (virStrToLong_i(start, &end, 10, &first) < 0 || *end != '.') { qemuReportError(VIR_ERR_INTERNAL_ERROR, _("cannot extract USB device bus '%s'"), val); VIR_FREE(def); @@ -5573,13 +5573,11 @@ qemuParseCommandLineSmp(virDomainDefPtr dom, for (i = 0; i < nkws; i++) { if (vals[i] == NULL) { if (i > 0 || - virStrToLong_i(kws[i], &end, 10, &n) < 0 || - !end || *end != '\0') + virStrToLong_i(kws[i], &end, 10, &n) < 0 || *end != '\0') goto syntax; dom->vcpus = n; } else { - if (virStrToLong_i(vals[i], &end, 10, &n) < 0 || - !end || *end != '\0') + if (virStrToLong_i(vals[i], &end, 10, &n) < 0 || *end != '\0') goto syntax; if (STREQ(kws[i], "sockets")) sockets = n; diff --git a/src/qemu/qemu_monitor_text.c b/src/qemu/qemu_monitor_text.c index 1596e59..a199de7 100644 --- a/src/qemu/qemu_monitor_text.c +++ b/src/qemu/qemu_monitor_text.c @@ -1075,7 +1075,7 @@ int qemuMonitorTextGetMigrationStatus(qemuMonitorPtr mon, goto done; tmp += strlen(MIGRATION_TRANSFER_PREFIX); - if (virStrToLong_ull(tmp, &end, 10, transferred) < 0 || !end) { + if (virStrToLong_ull(tmp, &end, 10, transferred) < 0) { qemuReportError(VIR_ERR_INTERNAL_ERROR, _("cannot parse migration data transferred statistic %s"), tmp); goto cleanup; @@ -1087,7 +1087,7 @@ int qemuMonitorTextGetMigrationStatus(qemuMonitorPtr mon, goto done; tmp += strlen(MIGRATION_REMAINING_PREFIX); - if (virStrToLong_ull(tmp, &end, 10, remaining) < 0 || !end) { + if (virStrToLong_ull(tmp, &end, 10, remaining) < 0) { qemuReportError(VIR_ERR_INTERNAL_ERROR, _("cannot parse migration data remaining statistic %s"), tmp); goto cleanup; @@ -1098,7 +1098,7 @@ int qemuMonitorTextGetMigrationStatus(qemuMonitorPtr mon, goto done; tmp += strlen(MIGRATION_TOTAL_PREFIX); - if (virStrToLong_ull(tmp, &end, 10, total) < 0 || !end) { + if (virStrToLong_ull(tmp, &end, 10, total) < 0) { qemuReportError(VIR_ERR_INTERNAL_ERROR, _("cannot parse migration data total statistic %s"), tmp); goto cleanup; -- 1.6.6.1

2 2

[libvirt] possible bug in virConnectGetLibVersion()
by Paolo Smiraglia 01 Apr '10

01 Apr '10

I need to get libvirt version. Using function virConnecGetLibVersion(), I've return message like errore: unknown error My system settings are: Kernel: 2.6.33 Hypervisor: QEMU 0.12.3 Libvirt: 0.7.6 (cloned from git) The code that fails is in src/libvirt.c:1656 ========================================================= if (conn->driver->libvirtVersion) { ret = conn->driver->libvirtVersion(conn, libVer); if (ret < 0) goto error; return ret; } *libVer = LIBVIR_VERSION_NUMBER; ret = 0; error: virDispatchError(conn); return ret; } ========================================================= I noticed that conn->driver->libvirtVersion is NULL for all the hypervisors except the remote one (src/remote/remote_driver.c), hence it always dispatch an unknown error. I checked the current libvirt code (always cloned from git), and the bug is also present. Is this a bug, or this is a well known behavior? If this is a bug, a possible solution could be to add the code line return ret; before "error:" label. This is my debugged code ========================================================= if (conn->driver->libvirtVersion) { ret = conn->driver->libvirtVersion(conn, libVer); if (ret < 0) goto error; return ret; } *libVer = LIBVIR_VERSION_NUMBER; ret = 0; return ret; /* POSSIBLE BUG SOLUTION */ error: virDispatchError(conn); return ret; } ========================================================= Have a good day! -- PAOLO SMIRAGLIA Via Avigliana 13/5 10138 Torino (TO) Tel: 0039 333 52 73 593 E-Mail: paolo.smiraglia(a)gmail.com - - - - - MSN: mastronano(a)hotmail.com Jabber: mastronano(a)jabber.linux.it Skype: paolo.smiraglia

3 3

[libvirt] [PATCH] virsh: add 'exit' as an alias for 'quit'
by Eric Blake 01 Apr '10

01 Apr '10

Call me lazy: some shells use exit (e.g. sh), others use quit (e.g. ftp), but I never remember which. So it's faster to write a patch to make virsh take both than it is to take a 50-50 guess, and get it wrong in half of my attempts. * tools/virsh.c (commands): Add 'exit'. * tools/virsh.pod: Document it. --- So, how many 'exit's in virsh will it take for me to have saved more time than I spent writing up this commit message and email? :) tools/virsh.c | 1 + tools/virsh.pod | 2 +- 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index ddcc052..5c56fa6 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -8254,6 +8254,7 @@ static const vshCmdDef commands[] = { {"pwd", cmdPwd, NULL, info_pwd}, #endif {"quit", cmdQuit, NULL, info_quit}, + {"exit", cmdQuit, NULL, info_quit}, {"reboot", cmdReboot, opts_reboot, info_reboot}, {"restore", cmdRestore, opts_restore, info_restore}, {"resume", cmdResume, opts_resume, info_resume}, diff --git a/tools/virsh.pod b/tools/virsh.pod index 9434f31..fc4a70c 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -65,7 +65,7 @@ The following commands are generic i.e. not specific to a domain. This prints a small synopsis about all commands available for B<virsh> B<help> I<command> will print out a detailed help message on that command. -=item B<quit> +=item B<quit>, B<exit> quit this interactive terminal -- 1.6.6.1

2 2

[libvirt] [PATCH] maint: fix cpp indentation syntax-check failure
by Jim Meyering 01 Apr '10

01 Apr '10

FYI, >From 3cda0eb487d9cafa89cd7595ed0d43ee2a93b8fc Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Wed, 31 Mar 2010 16:32:38 +0200 Subject: [PATCH] maint: fix cpp indentation syntax-check failure * src/esx/esx_vi_types.h: Filter through cppi. --- src/esx/esx_vi_types.h | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/esx/esx_vi_types.h b/src/esx/esx_vi_types.h index a61cdc1..d3c7115 100644 --- a/src/esx/esx_vi_types.h +++ b/src/esx/esx_vi_types.h @@ -1,4 +1,3 @@ - /* * esx_vi_types.h: client for the VMware VI API 2.5 to manage ESX hosts * @@ -50,7 +49,7 @@ typedef struct _esxVI_DateTime esxVI_DateTime; typedef struct _esxVI_Fault esxVI_Fault; typedef struct _esxVI_ManagedObjectReference esxVI_ManagedObjectReference; -#include "esx_vi_types.generated.typedef" +# include "esx_vi_types.generated.typedef" @@ -70,7 +69,7 @@ enum _esxVI_Type { esxVI_Type_Fault, esxVI_Type_ManagedObjectReference, -#include "esx_vi_types.generated.typeenum" +# include "esx_vi_types.generated.typeenum" esxVI_Type_Other, }; @@ -294,6 +293,6 @@ int esxVI_ManagedObjectReference_Deserialize -#include "esx_vi_types.generated.h" +# include "esx_vi_types.generated.h" #endif /* __ESX_VI_TYPES_H__ */ -- 1.7.0.3.513.gc8ed0

1 0

[libvirt] [PATCH] esx: Generate most SOAP mapping and improve inheritance handling
by Matthias Bolte 01 Apr '10

01 Apr '10

The Python script generates the mappings based on the type descriptions in the esx_vi_generator.input file. This also improves the inheritance handling and allows to get rid of the ugly, inflexible, and error prone _base/_super approach. Now every struct that represents a SOAP type contains a _type member, that allows to recreate C++-like dynamic dispatch for "method" calls in C. --- src/Makefile.am | 23 +- src/esx/.gitignore | 1 + src/esx/esx_driver.c | 10 +- src/esx/esx_vi.c | 51 +- src/esx/esx_vi.h | 7 +- src/esx/esx_vi_generator.input | 426 ++++++++ src/esx/esx_vi_generator.py | 1025 ++++++++++++++++++ src/esx/esx_vi_methods.c | 44 +- src/esx/esx_vi_types.c | 2258 +++++----------------------------------- src/esx/esx_vi_types.h | 1090 +------------------- 10 files changed, 1868 insertions(+), 3067 deletions(-) create mode 100644 src/esx/.gitignore create mode 100644 src/esx/esx_vi_generator.input create mode 100755 src/esx/esx_vi_generator.py diff --git a/src/Makefile.am b/src/Makefile.am index c661a5c..54792b4 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -26,6 +26,8 @@ INCLUDES = \ EXTRA_DIST = $(conf_DATA) +BUILT_SOURCES = + if WITH_NETWORK UUID=$(shell uuidgen 2>/dev/null) endif @@ -250,6 +252,20 @@ ESX_DRIVER_SOURCES = \ esx/esx_vi_types.c esx/esx_vi_types.h \ esx/esx_vmx.c esx/esx_vmx.h +ESX_DRIVER_GENERATED = \ + esx/esx_vi_types.generated.c \ + esx/esx_vi_types.generated.h \ + esx/esx_vi_types.generated.typedef \ + esx/esx_vi_types.generated.typeenum \ + esx/esx_vi_types.generated.typetostring \ + esx/esx_vi_types.generated.typefromstring + +ESX_DRIVER_EXTRA_DIST = \ + esx/README \ + esx/esx_vi_generator.input \ + esx/esx_vi_generator.py \ + $(ESX_DRIVER_GENERATED) + NETWORK_DRIVER_SOURCES = \ network/bridge_driver.h network/bridge_driver.c @@ -594,7 +610,10 @@ libvirt_driver_one_la_SOURCES = $(ONE_DRIVER_SOURCES) endif +BUILT_SOURCES += $(ESX_DRIVER_GENERATED) +$(ESX_DRIVER_GENERATED): $(srcdir)/esx/esx_vi_generator.input $(srcdir)/esx/esx_vi_generator.py + -srcdir=$(srcdir) $(srcdir)/esx/esx_vi_generator.py if WITH_ESX if WITH_DRIVER_MODULES @@ -610,6 +629,7 @@ if WITH_DRIVER_MODULES libvirt_driver_esx_la_LDFLAGS += -module -avoid-version endif libvirt_driver_esx_la_SOURCES = $(ESX_DRIVER_SOURCES) +libvirt_driver_esx_la_DEPENDENCIES = $(ESX_DRIVER_GENERATED) endif if WITH_NETWORK @@ -784,6 +804,7 @@ EXTRA_DIST += \ $(VBOX_DRIVER_SOURCES) \ $(XENAPI_DRIVER_SOURCES) \ $(ESX_DRIVER_SOURCES) \ + $(ESX_DRIVER_EXTRA_DIST) \ $(NETWORK_DRIVER_SOURCES) \ $(INTERFACE_DRIVER_SOURCES) \ $(STORAGE_DRIVER_SOURCES) \ @@ -867,7 +888,7 @@ EXTRA_DIST += \ libvirt_macvtap.syms \ libvirt_daemon.syms -BUILT_SOURCES = libvirt.syms +BUILT_SOURCES += libvirt.syms libvirt.syms: libvirt_public.syms $(USED_SYM_FILES) rm -f $@-tmp $@ diff --git a/src/esx/.gitignore b/src/esx/.gitignore new file mode 100644 index 0000000..29e1d48 --- /dev/null +++ b/src/esx/.gitignore @@ -0,0 +1 @@ +*.generated.* diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index bbe8a51..663c560 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -1924,8 +1924,14 @@ esxDomainGetInfo(virDomainPtr domain, virDomainInfoPtr info) perfEntityMetric = perfEntityMetric->_next) { VIR_DEBUG0("perfEntityMetric ..."); - for (perfMetricIntSeries = perfEntityMetric->value; - perfMetricIntSeries != NULL; + perfMetricIntSeries = + esxVI_PerfMetricIntSeries_DynamicCast(perfEntityMetric->value); + + if (perfMetricIntSeries == NULL) { + VIR_ERROR0("QueryPerf returned object with unexpected type"); + } + + for (; perfMetricIntSeries != NULL; perfMetricIntSeries = perfMetricIntSeries->_next) { VIR_DEBUG0("perfMetricIntSeries ..."); diff --git a/src/esx/esx_vi.c b/src/esx/esx_vi.c index 326add7..c1fd4b4 100644 --- a/src/esx/esx_vi.c +++ b/src/esx/esx_vi.c @@ -3,7 +3,7 @@ * esx_vi.c: client for the VMware VI API 2.5 to manage ESX hosts * * Copyright (C) 2010 Red Hat, Inc. - * Copyright (C) 2009 Matthias Bolte <matthias.bolte(a)googlemail.com> + * Copyright (C) 2009-2010 Matthias Bolte <matthias.bolte(a)googlemail.com> * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -480,12 +480,12 @@ esxVI_Context_Connect(esxVI_Context *ctx, const char *url, dynamicProperty = dynamicProperty->_next) { if (STREQ(dynamicProperty->name, "vmFolder")) { if (esxVI_ManagedObjectReference_CastFromAnyType - (dynamicProperty->val, &ctx->vmFolder, "Folder")) { + (dynamicProperty->val, &ctx->vmFolder)) { goto failure; } } else if (STREQ(dynamicProperty->name, "hostFolder")) { if (esxVI_ManagedObjectReference_CastFromAnyType - (dynamicProperty->val, &ctx->hostFolder, "Folder")) { + (dynamicProperty->val, &ctx->hostFolder)) { goto failure; } } else { @@ -725,6 +725,21 @@ esxVI_Context_Execute(esxVI_Context *ctx, const char *methodName, "Call to '%s' returned an empty result, " "expecting a non-empty result", methodName); goto failure; + } else if ((*response)->node->next != NULL) { + ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, + "Call to '%s' returned a list, expecting " + "exactly one item", methodName); + goto failure; + } + + break; + + case esxVI_Occurrence_RequiredList: + if ((*response)->node == NULL) { + ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, + "Call to '%s' returned an empty result, " + "expecting a non-empty result", methodName); + goto failure; } break; @@ -740,7 +755,7 @@ esxVI_Context_Execute(esxVI_Context *ctx, const char *methodName, break; - case esxVI_Occurrence_List: + case esxVI_Occurrence_OptionalList: /* Any amount of items is valid */ break; @@ -821,10 +836,11 @@ esxVI_Enumeration_CastFromAnyType(const esxVI_Enumeration *enumeration, *value = 0; /* undefined */ - if (STRNEQ(anyType->other, enumeration->type)) { + if (anyType->type != enumeration->type) { ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, - "Expecting type '%s' but found '%s'", enumeration->type, - anyType->other); + "Expecting type '%s' but found '%s'", + esxVI_Type_ToString(enumeration->type), + esxVI_Type_ToString(anyType->type)); return -1; } @@ -837,7 +853,7 @@ esxVI_Enumeration_CastFromAnyType(const esxVI_Enumeration *enumeration, ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, "Unknown value '%s' for %s", anyType->value, - enumeration->type); + esxVI_Type_ToString(enumeration->type)); return -1; } @@ -870,7 +886,8 @@ esxVI_Enumeration_Serialize(const esxVI_Enumeration *enumeration, return -1; } - ESV_VI__XML_TAG__OPEN(output, element, enumeration->type); + ESV_VI__XML_TAG__OPEN(output, element, + esxVI_Type_ToString(enumeration->type)); virBufferAdd(output, name, -1); @@ -906,7 +923,7 @@ esxVI_Enumeration_Deserialize(const esxVI_Enumeration *enumeration, } ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, "Unknown value '%s' for %s", - name, enumeration->type); + name, esxVI_Type_ToString(enumeration->type)); cleanup: VIR_FREE(name); @@ -1009,7 +1026,7 @@ esxVI_List_CastFromAnyType(esxVI_AnyType *anyType, esxVI_List **list, return -1; } - for (childNode = anyType->_node->children; childNode != NULL; + for (childNode = anyType->node->children; childNode != NULL; childNode = childNode->next) { if (childNode->type != XML_ELEMENT_NODE) { ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, @@ -1151,7 +1168,7 @@ esxVI_BuildFullTraversalSpecItem(esxVI_SelectionSpec **fullTraversalSpecList, } if (esxVI_TraversalSpec_Alloc(&traversalSpec) < 0 || - esxVI_String_DeepCopyValue(&traversalSpec->_base->name, name) < 0 || + esxVI_String_DeepCopyValue(&traversalSpec->name, name) < 0 || esxVI_String_DeepCopyValue(&traversalSpec->type, type) < 0 || esxVI_String_DeepCopyValue(&traversalSpec->path, path) < 0) { goto failure; @@ -1177,7 +1194,8 @@ esxVI_BuildFullTraversalSpecItem(esxVI_SelectionSpec **fullTraversalSpecList, } if (esxVI_SelectionSpec_AppendToList(fullTraversalSpecList, - traversalSpec->_base) < 0) { + esxVI_SelectionSpec_DynamicCast + (traversalSpec)) < 0) { goto failure; } @@ -1721,8 +1739,7 @@ esxVI_LookupResourcePoolByHostSystem dynamicProperty = dynamicProperty->_next) { if (STREQ(dynamicProperty->name, "parent")) { if (esxVI_ManagedObjectReference_CastFromAnyType - (dynamicProperty->val, &managedObjectReference, - "ComputeResource") < 0) { + (dynamicProperty->val, &managedObjectReference) < 0) { goto failure; } @@ -1756,7 +1773,7 @@ esxVI_LookupResourcePoolByHostSystem dynamicProperty = dynamicProperty->_next) { if (STREQ(dynamicProperty->name, "resourcePool")) { if (esxVI_ManagedObjectReference_CastFromAnyType - (dynamicProperty->val, resourcePool, "ResourcePool") < 0) { + (dynamicProperty->val, resourcePool) < 0) { goto failure; } @@ -2231,7 +2248,7 @@ esxVI_LookupPendingTaskInfoListByVirtualMachine dynamicProperty = dynamicProperty->_next) { if (STREQ(dynamicProperty->name, "recentTask")) { if (esxVI_ManagedObjectReference_CastListFromAnyType - (dynamicProperty->val, &recentTaskList, "Task") < 0) { + (dynamicProperty->val, &recentTaskList) < 0) { goto failure; } diff --git a/src/esx/esx_vi.h b/src/esx/esx_vi.h index 1349a1b..555dad5 100644 --- a/src/esx/esx_vi.h +++ b/src/esx/esx_vi.h @@ -2,7 +2,7 @@ /* * esx_vi.h: client for the VMware VI API 2.5 to manage ESX hosts * - * Copyright (C) 2009 Matthias Bolte <matthias.bolte(a)googlemail.com> + * Copyright (C) 2009-2010 Matthias Bolte <matthias.bolte(a)googlemail.com> * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -61,8 +61,9 @@ enum _esxVI_ProductVersion { enum _esxVI_Occurrence { esxVI_Occurrence_Undefined = 0, esxVI_Occurrence_RequiredItem, + esxVI_Occurrence_RequiredList, esxVI_Occurrence_OptionalItem, - esxVI_Occurrence_List, + esxVI_Occurrence_OptionalList, esxVI_Occurrence_None }; @@ -132,7 +133,7 @@ struct _esxVI_EnumerationValue { }; struct _esxVI_Enumeration { - const char *type; + esxVI_Type type; esxVI_EnumerationValue values[10]; }; diff --git a/src/esx/esx_vi_generator.input b/src/esx/esx_vi_generator.input new file mode 100644 index 0000000..06dddbf --- /dev/null +++ b/src/esx/esx_vi_generator.input @@ -0,0 +1,426 @@ +# +# Definitions of vSphere API 2.5 enumeration and objects types used as input +# for the esx_vi_generator.py script. +# +# This format is line-based, so end-of-line is important. +# +# +# Enumeration definition: +# +# enum <name> +# <value> +# ... +# end +# +# +# Object definition: +# +# object <name> [extends <name>] +# <type> <name> <occurrence> +# ... +# end +# +# Possible values for the <occurrence> field are: +# +# - r for a required item +# - rl for a required list +# - o for an optional item +# - ol for an optional list +# - i for an ignored item or list +# +# Object member sequence has to match the WSDL sequence +# + + +# # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # +# Enumerations +# + +enum ManagedEntityStatus + gray + green + yellow + red +end + + +enum ObjectUpdateKind + modify + enter + leave +end + + +enum PerfStatsType + absolute + delta + rate +end + + +enum PerfSummaryType + average + maximum + minimum + latest + summation + none +end + + +enum PropertyChangeOp + add + remove + assign + indirectRemove +end + + +enum SharesLevel + low + normal + high + custom +end + + +enum TaskInfoState + queued + running + success + error +end + + +enum VirtualMachineMovePriority + lowPriority + highPriority + defaultPriority +end + + +enum VirtualMachinePowerState + poweredOff + poweredOn + suspended +end + + +# # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # +# Objects +# + +object AboutInfo + String name r + String fullName r + String vendor r + String version r + String build r + String localeVersion o + String localeBuild o + String osType r + String productLineId r + String apiType r + String apiVersion r +end + + +object ChoiceOption extends OptionType + ElementDescription choiceInfo rl + Int defaultIndex o +end + + +object Description + String label r + String summary r +end + + +object DynamicProperty + String name r + AnyType val r +end + + +object ElementDescription extends Description + String key r +end + + +object Event + Int key r + Int chainId r + DateTime createdTime r + String userName r + DatacenterEventArgument datacenter i + ComputeResourceEventArgument computeResource i + HostEventArgument host i + VmEventArgument vm i + String fullFormattedMessage o +end + + +object HostCpuIdInfo + Int level r + String vendor o + String eax o + String ebx o + String ecx o + String edx o +end + + +object ObjectContent + ManagedObjectReference obj r + DynamicProperty propSet ol + MissingProperty missingSet i +end + + +object ObjectSpec + ManagedObjectReference obj r + Boolean skip o + SelectionSpec selectSet ol +end + + +object ObjectUpdate + ObjectUpdateKind kind r + ManagedObjectReference obj r + PropertyChange changeSet ol + MissingProperty missingSet i +end + + +object OptionType + Boolean valueIsReadonly o +end + + +object PerfCounterInfo + Int key r + ElementDescription nameInfo r + ElementDescription groupInfo r + ElementDescription unitInfo r + PerfSummaryType rollupType r + PerfStatsType statsType r + Int level o + Int associatedCounterId ol +end + + +object PerfEntityMetric extends PerfEntityMetricBase + PerfSampleInfo sampleInfo ol + PerfMetricSeries value ol +end + + +object PerfEntityMetricBase + ManagedObjectReference entity r +end + + +object PerfMetricId + Int counterId r + String instance r +end + + +object PerfMetricIntSeries extends PerfMetricSeries + Long value ol +end + + +object PerfMetricSeries + PerfMetricId id r +end + + +object PerfQuerySpec + ManagedObjectReference entity r + DateTime startTime o + DateTime endTime o + Int maxSample o + PerfMetricId metricId ol + Int intervalId o + String format o +end + + +object PerfSampleInfo + DateTime timestamp r + Int interval r +end + + +object PropertyChange + String name r + PropertyChangeOp op r + AnyType val o +end + + +object PropertyFilterSpec + PropertySpec propSet rl + ObjectSpec objectSet rl +end + + +object PropertyFilterUpdate + ManagedObjectReference filter r + ObjectUpdate objectSet ol + MissingObject missingSet i +end + + +object PropertySpec + String type r + Boolean all o + String pathSet ol +end + + +object ResourceAllocationInfo + Long reservation o + Boolean expandableReservation o + Long limit o + SharesInfo shares o + Long overheadLimit o +end + + +object ResourcePoolResourceUsage + Long reservationUsed r + Long reservationUsedForVm r + Long unreservedForPool r + Long unreservedForVm r + Long overallUsage r + Long maxUsage r +end + + +object SelectionSpec + String name o +end + + +object ServiceContent + ManagedObjectReference rootFolder r + ManagedObjectReference propertyCollector r + ManagedObjectReference viewManager o + AboutInfo about r + ManagedObjectReference setting o + ManagedObjectReference userDirectory o + ManagedObjectReference sessionManager o + ManagedObjectReference authorizationManager o + ManagedObjectReference perfManager o + ManagedObjectReference scheduledTaskManager o + ManagedObjectReference alarmManager o + ManagedObjectReference eventManager o + ManagedObjectReference taskManager o + ManagedObjectReference extensionManager o + ManagedObjectReference customizationSpecManager o + ManagedObjectReference customFieldsManager o + ManagedObjectReference accountManager o + ManagedObjectReference diagnosticManager o + ManagedObjectReference licenseManager o + ManagedObjectReference searchIndex o + ManagedObjectReference fileManager o + ManagedObjectReference virtualDiskManager o + ManagedObjectReference virtualizationManager o +end + + +object SharesInfo + Int shares r + SharesLevel level r +end + + +object TaskInfo + String key r + ManagedObjectReference task r + String name o + String descriptionId r + ManagedObjectReference entity o + String entityName o + ManagedObjectReference locked ol + TaskInfoState state r + Boolean cancelled r + Boolean cancelable r + LocalizedMethodFault error i + AnyType result o + Int progress o + TaskReason reason i + DateTime queueTime r + DateTime startTime o + DateTime completeTime o + Int eventChainId r +end + + +object TraversalSpec extends SelectionSpec + String type r + String path r + Boolean skip o + SelectionSpec selectSet ol +end + + +object UpdateSet + String version r + PropertyFilterUpdate filterSet ol +end + + +object UserSession + String key r + String userName r + String fullName r + DateTime loginTime r + DateTime lastActiveTime r + String locale r + String messageLocale r +end + + +object VirtualMachineConfigSpec + String changeVersion o + String name o + String version o + String uuid o + Long npivNodeWorldWideName ol + Long npivPortWorldWideName ol + String npivWorldWideNameType o + String npivWorldWideNameOp o + String locationId o + String guestId o + String alternateGuestName o + String annotation o + VirtualMachineFileInfo files i + ToolsConfigInfo tools i + VirtualMachineFlagInfo flags i + VirtualMachineConsolePreferences consolePreferences i + VirtualMachineDefaultPowerOpInfo powerOpInfo i + Int numCPUs o + Long memoryMB o + VirtualDeviceConfigSpec deviceChange i + ResourceAllocationInfo cpuAllocation o + ResourceAllocationInfo memoryAllocation o + VirtualMachineAffinityInfo cpuAffinity i + VirtualMachineAffinityInfo memoryAffinity i + VirtualMachineNetworkShaperInfo networkShaper i + VirtualMachineCpuIdInfoSpec cpuFeatureMask i + OptionValue extraConfig i + String swapPlacement o + VirtualMachineBootOptions bootOptions i +end + + +object VirtualMachineQuestionInfo + String id r + String text r + ChoiceOption choice r + VirtualMachineMessage message i +end diff --git a/src/esx/esx_vi_generator.py b/src/esx/esx_vi_generator.py new file mode 100755 index 0000000..5ca6138 --- /dev/null +++ b/src/esx/esx_vi_generator.py @@ -0,0 +1,1025 @@ +#!/usr/bin/python + +# +# esx_vi_generator.py: generates most of the SOAP type mapping code +# +# Copyright (C) 2010 Matthias Bolte <matthias.bolte(a)googlemail.com> +# +# This library is free software; you can redistribute it and/or +# modify it under the terms of the GNU Lesser General Public +# License as published by the Free Software Foundation; either +# version 2.1 of the License, or (at your option) any later version. +# +# This library is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +# Lesser General Public License for more details. +# +# You should have received a copy of the GNU Lesser General Public +# License along with this library; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA +# + +import sys +import os +import os.path + + + + + + +class Property: + OCCURRENCE__REQUIRED_ITEM = "r" + OCCURRENCE__REQUIRED_LIST = "rl" + OCCURRENCE__OPTIONAL_ITEM = "o" + OCCURRENCE__OPTIONAL_LIST = "ol" + OCCURRENCE__IGNORED = "i" + + valid_occurrences = [OCCURRENCE__REQUIRED_ITEM, + OCCURRENCE__REQUIRED_LIST, + OCCURRENCE__OPTIONAL_ITEM, + OCCURRENCE__OPTIONAL_LIST, + OCCURRENCE__IGNORED] + + def __init__(self, type, name, occurrence): + self.type = type + self.name = name + self.occurrence = occurrence + + def is_enum(self): + global predefined_enums + global enums_by_name + + return self.type in predefined_enums or self.type in enums_by_name + + def generate_struct_member(self): + if self.occurrence == Property.OCCURRENCE__IGNORED: + return " /* FIXME: %s is currently ignored */\n" % self.name + else: + string = " %s%s; " % (self.get_type_string(), self.name) + + while len(string) < 59: + string += " " + + return string + "/* %s */\n" % self.get_occurrence_string() + + def generate_free_code(self): + if self.type == "String" and \ + self.occurrence not in [Property.OCCURRENCE__REQUIRED_LIST, + Property.OCCURRENCE__OPTIONAL_LIST, + Property.OCCURRENCE__IGNORED]: + return " VIR_FREE(item->%s);\n" % self.name + elif self.is_enum(): + return "" + else: + if self.occurrence == Property.OCCURRENCE__IGNORED: + return " /* FIXME: %s is currently ignored */\n" % self.name + else: + return " esxVI_%s_Free(&item->%s);\n" % (self.type, self.name) + + def generate_validate_code(self): + if self.occurrence in [Property.OCCURRENCE__REQUIRED_ITEM, + Property.OCCURRENCE__REQUIRED_LIST]: + return " ESX_VI__TEMPLATE__PROPERTY__REQUIRE(%s)\n" % self.name + elif self.occurrence == Property.OCCURRENCE__IGNORED: + return " /* FIXME: %s is currently ignored */\n" % self.name + else: + return "" + + def generate_deep_copy_code(self): + if self.occurrence == Property.OCCURRENCE__IGNORED: + return " /* FIXME: %s is currently ignored */\n" % self.name + elif self.occurrence in [Property.OCCURRENCE__REQUIRED_LIST, + Property.OCCURRENCE__OPTIONAL_LIST]: + return " ESX_VI__TEMPLATE__PROPERTY__DEEP_COPY_LIST(%s, %s)\n" % (self.type, self.name) + elif self.type == "String": + return " ESX_VI__TEMPLATE__PROPERTY__DEEP_COPY_VALUE(String, %s)\n" % self.name + else: + return " ESX_VI__TEMPLATE__PROPERTY__DEEP_COPY(%s, %s)\n" % (self.type, self.name) + + def generate_serialize_code(self): + if self.occurrence == Property.OCCURRENCE__IGNORED: + return " /* FIXME: %s is currently ignored */\n" % self.name + elif self.occurrence in [Property.OCCURRENCE__REQUIRED_LIST, + Property.OCCURRENCE__OPTIONAL_LIST]: + return " ESX_VI__TEMPLATE__PROPERTY__SERIALIZE_LIST(%s, %s)\n" % (self.type, self.name) + elif self.type == "String": + return " ESX_VI__TEMPLATE__PROPERTY__SERIALIZE_VALUE(String, %s)\n" % self.name + else: + return " ESX_VI__TEMPLATE__PROPERTY__SERIALIZE(%s, %s)\n" % (self.type, self.name) + + def generate_deserialize_code(self): + if self.occurrence == Property.OCCURRENCE__IGNORED: + return " ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_IGNORE(%s) /* FIXME */\n" % self.name + elif self.occurrence in [Property.OCCURRENCE__REQUIRED_LIST, + Property.OCCURRENCE__OPTIONAL_LIST]: + return " ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_LIST(%s, %s)\n" % (self.type, self.name) + elif self.type == "String": + return " ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, %s)\n" % self.name + else: + return " ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(%s, %s)\n" % (self.type, self.name) + + def get_type_string(self): + if self.type == "String" and \ + self.occurrence not in [Property.OCCURRENCE__REQUIRED_LIST, + Property.OCCURRENCE__OPTIONAL_LIST]: + return "char *" + elif self.is_enum(): + return "esxVI_%s " % self.type + else: + return "esxVI_%s *" % self.type + + def get_occurrence_string(self): + if self.occurrence == Property.OCCURRENCE__REQUIRED_ITEM: + return "required" + elif self.occurrence == Property.OCCURRENCE__REQUIRED_LIST: + return "required, list" + elif self.occurrence == Property.OCCURRENCE__OPTIONAL_ITEM: + return "optional" + elif self.occurrence == Property.OCCURRENCE__OPTIONAL_LIST: + return "optional, list" + + raise ValueError("unknown cardinality value '%s'" % self.cardinality) + + + + + + + + +class Object: + FEATURE__DYNAMIC_CAST = (1 << 1) + FEATURE__LIST = (1 << 2) + FEATURE__DEEP_COPY = (1 << 3) + FEATURE__ANY_TYPE = (1 << 4) + FEATURE__SERIALIZE = (1 << 5) + FEATURE__DESERIALIZE = (1 << 6) + + def __init__(self, name, extends, properties, features = 0, extended_by = None): + self.name = name + self.extends = extends + self.features = features | Object.FEATURE__SERIALIZE | Object.FEATURE__DESERIALIZE + self.properties = properties + self.extended_by = extended_by + + self.properties_by_name = {} + + for property in self.properties: + self.properties_by_name[property.name] = property + + def generate_struct_members(self, add_banner = False, struct_gap = False): + global objects_by_name + members = "" + + if self.extends is None: + struct_gap = True + string = " esxVI_Type _type; " + + while len(string) < 59: + string += " " + + members += string + "/* required */\n" + + if struct_gap and self.extends is None: + members += "\n" + + if self.extends is not None: + members += objects_by_name[self.extends].generate_struct_members(add_banner = True, struct_gap = False) + "\n" + + if self.extends is not None or add_banner: + members += " /* %s */\n" % self.name + + for property in self.properties: + members += property.generate_struct_member() + + if len(self.properties) < 1: + members += " /* no properties */\n" + + return members + + def generate_free_code(self, add_banner = False): + global objects_by_name + source = "" + + if self.extends is not None: + source += objects_by_name[self.extends].generate_free_code(add_banner = True) + "\n" + + if self.extends is not None or add_banner: + source += " /* %s */\n" % self.name + + if len(self.properties) < 1: + source += " /* no properties */\n" + else: + string = "" + + for property in self.properties: + string += property.generate_free_code() + + if len(string) < 1: + source += " /* no properties to be freed */\n" + else: + source += string + + return source + + def generate_validate_code(self, add_banner = False): + global objects_by_name + source = "" + + if self.extends is not None: + source += objects_by_name[self.extends].generate_validate_code(add_banner = True) + "\n" + + if self.extends is not None or add_banner: + source += " /* %s */\n" % self.name + + if len(self.properties) < 1: + source += " /* no properties */\n" + else: + string = "" + + for property in self.properties: + string += property.generate_validate_code() + + if len(string) < 1: + source += " /* no required properties */\n" + else: + source += string + + return source + + def generate_dynamic_cast_code(self): + global objects_by_name + source = "" + + if self.extended_by is not None: + source += " /* %s */\n" % self.name + + for extended_by in self.extended_by: + source += " ESX_VI__TEMPLATE__DYNAMIC_CAST__ACCEPT(%s)\n" % extended_by + + for extended_by in self.extended_by: + source += objects_by_name[extended_by].generate_dynamic_cast_code() + + return source + + def generate_deep_copy_code(self, add_banner = False): + global objects_by_name + source = "" + + if self.extends is not None: + source += objects_by_name[self.extends].generate_deep_copy_code(add_banner = True) + "\n" + + if self.extends is not None or add_banner: + source += " /* %s */\n" % self.name + + if len(self.properties) < 1: + source += " /* no properties */\n" + else: + string = "" + + for property in self.properties: + string += property.generate_deep_copy_code() + + if len(string) < 1: + source += " /* no properties to be deep copied */\n" + else: + source += string + + return source + + def generate_serialize_code(self, add_banner = False): + global objects_by_name + source = "" + + if self.extends is not None: + source += objects_by_name[self.extends].generate_serialize_code(add_banner = True) + "\n" + + if self.extends is not None or add_banner: + source += " /* %s */\n" % self.name + + if len(self.properties) < 1: + source += " /* no properties */\n" + else: + for property in self.properties: + source += property.generate_serialize_code() + + return source + + def generate_deserialize_code(self, add_banner = False): + global objects_by_name + source = "" + + if self.extends is not None: + source += objects_by_name[self.extends].generate_deserialize_code(add_banner = True) + "\n" + + if self.extends is not None or add_banner: + source += " /* %s */\n" % self.name + + if len(self.properties) < 1: + source += " /* no properties */\n" + else: + for property in self.properties: + source += property.generate_deserialize_code() + + return source + + def generate_typedef(self): + return "typedef struct _esxVI_%s esxVI_%s;\n" % (self.name, self.name) + + def generate_typeenum(self): + return " esxVI_Type_%s,\n" % self.name + + def generate_typetostring(self): + string = " case esxVI_Type_%s:\n" % self.name + string += " return \"%s\";\n\n" % self.name + + return string + + def generate_typefromstring(self): + string = " else if (STREQ(type, \"%s\")) {\n" % self.name + string += " return esxVI_Type_%s;\n" % self.name + string += " }\n" + + return string + + def generate_header(self): + header = "/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *\n" + header += " * VI Type: %s\n" % self.name + + if self.extends is not None: + header += " * extends %s\n" % self.extends + + first = True + + if self.extended_by is not None: + for extended_by in self.extended_by: + if first: + header += " * extended by %s\n" % extended_by + first = False + else: + header += " * %s\n" % extended_by + + header += " */\n\n" + + # struct + header += "struct _esxVI_%s {\n" % self.name + + if self.features & Object.FEATURE__LIST: + string = " esxVI_%s *_next; " % self.name + else: + string = " esxVI_%s *_unused; " % self.name + + while len(string) < 59: + string += " " + + header += string + "/* optional */\n" + + header += self.generate_struct_members(struct_gap = True) + + header += "};\n\n" + + # functions + header += "int esxVI_%s_Alloc(esxVI_%s **item);\n" % (self.name, self.name) + header += "void esxVI_%s_Free(esxVI_%s **item);\n" % (self.name, self.name) + header += "int esxVI_%s_Validate(esxVI_%s *item);\n" % (self.name, self.name) + + if self.features & Object.FEATURE__DYNAMIC_CAST: + if self.extended_by is not None or self.extends is not None: + header += "esxVI_%s *esxVI_%s_DynamicCast(void *item);\n" % (self.name, self.name) + else: + report_error("cannot add dynamic cast support for an untyped object") + + if self.features & Object.FEATURE__LIST: + header += "int esxVI_%s_AppendToList(esxVI_%s **list, esxVI_%s *item);\n" % (self.name, self.name, self.name) + + if self.features & Object.FEATURE__DEEP_COPY: + header += "int esxVI_%s_DeepCopy(esxVI_%s **dst, esxVI_%s *src);\n" % (self.name, self.name, self.name) + + if self.features & Object.FEATURE__LIST: + header += "int esxVI_%s_DeepCopyList(esxVI_%s **dstList, esxVI_%s *srcList);\n" % (self.name, self.name, self.name) + + if self.features & Object.FEATURE__ANY_TYPE: + header += "int esxVI_%s_CastFromAnyType(esxVI_AnyType *anyType, esxVI_%s **item);\n" % (self.name, self.name) + + if self.features & Object.FEATURE__LIST: + header += "int esxVI_%s_CastListFromAnyType(esxVI_AnyType *anyType, esxVI_%s **list);\n" % (self.name, self.name) + + if self.features & Object.FEATURE__SERIALIZE: + header += "int esxVI_%s_Serialize(esxVI_%s *item, const char *element, virBufferPtr output);\n" % (self.name, self.name) + + if self.features & Object.FEATURE__LIST: + header += "int esxVI_%s_SerializeList(esxVI_%s *list, const char *element, virBufferPtr output);\n" % (self.name, self.name) + + if self.features & Object.FEATURE__DESERIALIZE: + header += "int esxVI_%s_Deserialize(xmlNodePtr node, esxVI_%s **item);\n" % (self.name, self.name) + + if self.features & Object.FEATURE__LIST: + header += "int esxVI_%s_DeserializeList(xmlNodePtr node, esxVI_%s **list);\n" % (self.name, self.name) + + header += "\n\n\n" + + return header + + def generate_source(self): + source = "/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *\n" + source += " * VI Type: %s\n" % self.name + + if self.extends is not None: + source += " * extends %s\n" % self.extends + + first = True + + if self.extended_by is not None: + for extended_by in self.extended_by: + if first: + source += " * extended by %s\n" % extended_by + first = False + else: + source += " * %s\n" % extended_by + + source += " */\n\n" + + # functions + source += "/* esxVI_%s_Alloc */\n" % self.name + source += "ESX_VI__TEMPLATE__ALLOC(%s)\n\n" % self.name + + # free + if self.extended_by is None: + source += "/* esxVI_%s_Free */\n" % self.name + source += "ESX_VI__TEMPLATE__FREE(%s,\n" % self.name + source += "{\n" + + if self.features & Object.FEATURE__LIST: + source += " esxVI_%s_Free(&item->_next);\n\n" % self.name + + source += self.generate_free_code() + + source += "})\n\n" + else: + source += "/* esxVI_%s_Free */\n" % self.name + source += "ESX_VI__TEMPLATE__DYNAMIC_FREE(%s,\n" % self.name + source += "{\n" + + for extended_by in self.extended_by: + source += " ESX_VI__TEMPLATE__DISPATCH__FREE(%s)\n" % extended_by + + source += "},\n" + source += "{\n" + + if self.features & Object.FEATURE__LIST: + source += " esxVI_%s_Free(&item->_next);\n\n" % self.name + + source += self.generate_free_code() + + source += "})\n\n" + + # validate + source += "/* esxVI_%s_Validate */\n" % self.name + source += "ESX_VI__TEMPLATE__VALIDATE(%s,\n" % self.name + source += "{\n" + + source += self.generate_validate_code() + + source += "})\n\n" + + # dynamic cast + if self.features & Object.FEATURE__DYNAMIC_CAST: + if self.extended_by is not None or self.extends is not None: + source += "/* esxVI_%s_DynamicCast */\n" % self.name + source += "ESX_VI__TEMPLATE__DYNAMIC_CAST(%s,\n" % self.name + source += "{\n" + + source += self.generate_dynamic_cast_code() + + source += "})\n\n" + else: + report_error("cannot add dynamic cast support for an untyped object") + + # append to list + if self.features & Object.FEATURE__LIST: + source += "/* esxVI_%s_AppendToList */\n" % self.name + source += "ESX_VI__TEMPLATE__LIST__APPEND(%s)\n\n" % self.name + + # deep copy + if self.extended_by is None: + if self.features & Object.FEATURE__DEEP_COPY: + source += "/* esxVI_%s_DeepCopy */\n" % self.name + source += "ESX_VI__TEMPLATE__DEEP_COPY(%s,\n" % self.name + source += "{\n" + + source += self.generate_deep_copy_code() + + source += "})\n\n" + + if self.features & Object.FEATURE__LIST: + source += "/* esxVI_%s_DeepCopyList */\n" % self.name + source += "ESX_VI__TEMPLATE__LIST__DEEP_COPY(%s)\n\n" % self.name + else: + if self.features & Object.FEATURE__DEEP_COPY: + source += "/* esxVI_%s_DeepCopy */\n" % self.name + source += "ESX_VI__TEMPLATE__DYNAMIC_DEEP_COPY(%s)\n" % self.name + source += "{\n" + + for extended_by in self.extended_by: + source += " ESX_VI__TEMPLATE__DISPATCH__DEEP_COPY(%s)\n" % extended_by + + source += "},\n" + source += "{\n" + + source += self.generate_deep_copy_code() + + source += "})\n\n" + + if self.features & Object.FEATURE__LIST: + source += "/* esxVI_%s_DeepCopyList */\n" % self.name + source += "ESX_VI__TEMPLATE__LIST__DEEP_COPY(%s)\n\n" % self.name + + # cast from any type + if self.features & Object.FEATURE__ANY_TYPE: + source += "/* esxVI_%s_CastFromAnyType */\n" % self.name + source += "ESX_VI__TEMPLATE__CAST_FROM_ANY_TYPE(%s)\n" % self.name + + if self.features & Object.FEATURE__LIST: + source += "/* esxVI_%s_CastListFromAnyType */\n" % self.name + source += "ESX_VI__TEMPLATE__LIST__CAST_FROM_ANY_TYPE(%s)\n\n" % self.name + + # serialize + if self.extended_by is None: + if self.features & Object.FEATURE__SERIALIZE: + source += "/* esxVI_%s_Serialize */\n" % self.name + source += "ESX_VI__TEMPLATE__SERIALIZE(%s,\n" % self.name + source += "{\n" + + source += self.generate_serialize_code() + + source += "})\n\n" + + if self.features & Object.FEATURE__LIST: + source += "/* esxVI_%s_SerializeList */\n" % self.name + source += "ESX_VI__TEMPLATE__LIST__SERIALIZE(%s)\n\n" % self.name + else: + if self.features & Object.FEATURE__SERIALIZE: + source += "/* esxVI_%s_Serialize */\n" % self.name + source += "ESX_VI__TEMPLATE__DYNAMIC_SERIALIZE(%s,\n" % self.name + source += "{\n" + + for extended_by in self.extended_by: + source += " ESX_VI__TEMPLATE__DISPATCH__SERIALIZE(%s)\n" % extended_by + + source += "},\n" + source += "{\n" + + source += self.generate_serialize_code() + + source += "})\n\n" + + if self.features & Object.FEATURE__LIST: + source += "/* esxVI_%s_SerializeList */\n" % self.name + source += "ESX_VI__TEMPLATE__LIST__SERIALIZE(%s)\n\n" % self.name + + # deserilaize + if self.features & Object.FEATURE__DESERIALIZE: + source += "/* esxVI_%s_Deserialize */\n" % self.name + source += "ESX_VI__TEMPLATE__DESERIALIZE(%s,\n" % self.name + source += "{\n" + + source += self.generate_deserialize_code() + + source += "})\n\n" + + if self.features & Object.FEATURE__LIST: + source += "/* esxVI_%s_DeserializeList */\n" % self.name + source += "ESX_VI__TEMPLATE__LIST__DESERIALIZE(%s)\n\n" % self.name + + source += "\n\n" + + return source + + + + + + + + +class Enum: + FEATURE__ANY_TYPE = (1 << 1) + FEATURE__SERIALIZE = (1 << 2) + FEATURE__DESERIALIZE = (1 << 3) + + + def __init__(self, name, values, features = 0): + self.name = name + self.values = values + self.features = features | Enum.FEATURE__SERIALIZE | Enum.FEATURE__DESERIALIZE + + def generate_typedef(self): + return "typedef enum _esxVI_%s esxVI_%s;\n" % (self.name, self.name) + + def generate_typeenum(self): + return " esxVI_Type_%s,\n" % self.name + + def generate_typetostring(self): + string = " case esxVI_Type_%s:\n" % self.name + string += " return \"%s\";\n\n" % self.name + + return string + + def generate_typefromstring(self): + string = " else if (STREQ(type, \"%s\")) {\n" % self.name + string += " return esxVI_Type_%s;\n" % self.name + string += " }\n" + + return string + + def generate_header(self): + header = "/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *\n" + header += " * VI Enum: %s\n" % self.name + header += " */\n\n" + + # enum + header += "enum _esxVI_%s {\n" % self.name + header += " esxVI_%s_Undefined = 0,\n" % self.name + + for value in self.values: + header += " esxVI_%s_%s,\n" % (self.name, capitalize_first(value)) + + header += "};\n\n" + + # functions + if self.features & Enum.FEATURE__ANY_TYPE: + header += "int esxVI_%s_CastFromAnyType(esxVI_AnyType *anyType, esxVI_%s *item);\n" % (self.name, self.name) + + if self.features & Enum.FEATURE__SERIALIZE: + header += "int esxVI_%s_Serialize(esxVI_%s item, const char *element, virBufferPtr output);\n" % (self.name, self.name) + + if self.features & Enum.FEATURE__DESERIALIZE: + header += "int esxVI_%s_Deserialize(xmlNodePtr node, esxVI_%s *item);\n" % (self.name, self.name) + + header += "\n\n\n" + + return header + + def generate_source(self): + source = "/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *\n" + source += " * VI Enum: %s\n" % self.name + source += " */\n\n" + + source += "static const esxVI_Enumeration _esxVI_%s_Enumeration = {\n" % self.name + source += " esxVI_Type_%s, {\n" % self.name + + for value in self.values: + source += " { \"%s\", esxVI_%s_%s },\n" % (value, self.name, capitalize_first(value)) + + source += " { NULL, -1 },\n" + source += " },\n" + source += "};\n\n" + + # functions + if self.features & Enum.FEATURE__ANY_TYPE: + source += "/* esxVI_%s_CastFromAnyType */\n" % self.name + source += "ESX_VI__TEMPLATE__ENUMERATION__CAST_FROM_ANY_TYPE(%s)\n\n" % self.name + + if self.features & Enum.FEATURE__SERIALIZE: + source += "/* esxVI_%s_Serialize */\n" % self.name + source += "ESX_VI__TEMPLATE__ENUMERATION__SERIALIZE(%s)\n\n" % self.name + + if self.features & Enum.FEATURE__DESERIALIZE: + source += "/* esxVI_%s_Deserialize */\n" % self.name + source += "ESX_VI__TEMPLATE__ENUMERATION__DESERIALIZE(%s)\n\n" % self.name + + source += "\n\n" + + return source + + + + + +def report_error(message): + print "error: " + message + sys.exit(1) + + + +def usage(): + print "%s <input-filename> <output-directory>" % sys.argv[0] + sys.exit(0) + + + +def capitalize_first(string): + return string[:1].upper() + string[1:] + + + +def parse_object(block): + # expected format: object <name> [extends <name>] + header_items = block[0][1].split() + + if len(header_items) < 2: + report_error("line %d: invalid block header" % (number)) + + assert header_items[0] == "object" + + name = header_items[1] + extends = None + + if len(header_items) > 2: + if header_items[2] != "extends": + report_error("line %d: invalid block header" % (number)) + else: + extends = header_items[3] + + properties = [] + + for line in block[1:]: + # expected format: <type> <name> <occurrence> + items = line[1].split() + + if len(items) != 3: + report_error("line %d: invalid property" % line[0]) + + if items[2] not in Property.valid_occurrences: + report_error("line %d: invalid occurrence" % line[0]) + + properties.append(Property(type = items[0], name = items[1], + occurrence = items[2])) + + return Object(name = name, extends = extends, properties = properties) + + + +def parse_enum(block): + # expected format: enum <name> + header_items = block[0][1].split() + + if len(header_items) < 2: + report_error("line %d: invalid block header" % (number)) + + assert header_items[0] == "enum" + + name = header_items[1] + + values = [] + + for line in block[1:]: + # expected format: <value> + values.append(line[1]) + + return Enum(name = name, values = values) + + + +def inherit_features(obj): + if obj.extended_by is not None: + for extended_by in obj.extended_by: + objects_by_name[extended_by].features |= obj.features + + if obj.extends is not None: + objects_by_name[obj.extends].features |= obj.features + + if obj.extended_by is not None: + for extended_by in obj.extended_by: + inherit_features(objects_by_name[extended_by]) + + + +def is_known_type(type): + return type in predefined_objects or \ + type in predefined_enums or \ + type in objects_by_name or \ + type in enums_by_name + + + +def open_and_print(filename): + if filename.startswith("./"): + print " GEN " + filename[2:] + else: + print " GEN " + filename + + return open(filename, "wb") + + + + + + + + + + +predefined_enums = ["Boolean"] + +predefined_objects = ["AnyType", + "Int", + "Long", + "String", + "DateTime", + "ManagedObjectReference"] + + +additional_enum_features = { "ManagedEntityStatus" : Enum.FEATURE__ANY_TYPE, + "TaskInfoState" : Enum.FEATURE__ANY_TYPE, + "VirtualMachinePowerState" : Enum.FEATURE__ANY_TYPE } + + +additional_object_features = { "Event" : Object.FEATURE__LIST, + "HostCpuIdInfo" : Object.FEATURE__ANY_TYPE | Object.FEATURE__LIST, + "ManagedObjectReference" : Object.FEATURE__ANY_TYPE, + "ObjectContent" : Object.FEATURE__DEEP_COPY | Object.FEATURE__LIST, + "PerfCounterInfo" : Object.FEATURE__LIST, + "PerfEntityMetric" : Object.FEATURE__LIST, + "PerfQuerySpec" : Object.FEATURE__LIST, + "PerfMetricIntSeries" : Object.FEATURE__DYNAMIC_CAST, + "PropertyFilterSpec" : Object.FEATURE__LIST, + "ResourcePoolResourceUsage" : Object.FEATURE__ANY_TYPE, + "SelectionSpec" : Object.FEATURE__DYNAMIC_CAST, + "SharesInfo" : Object.FEATURE__ANY_TYPE, + "TaskInfo" : Object.FEATURE__ANY_TYPE | Object.FEATURE__LIST, + "UserSession" : Object.FEATURE__ANY_TYPE, + "VirtualMachineQuestionInfo" : Object.FEATURE__ANY_TYPE } + + +removed_object_features = { "DynamicProperty" : Object.FEATURE__SERIALIZE, + "ObjectContent" : Object.FEATURE__SERIALIZE, + "ObjectUpdate" : Object.FEATURE__SERIALIZE, + "PropertyChange" : Object.FEATURE__SERIALIZE, + "PropertyFilterUpdate" : Object.FEATURE__SERIALIZE, + "TaskInfo" : Object.FEATURE__SERIALIZE, + "UpdateSet" : Object.FEATURE__SERIALIZE, + "VirtualMachineConfigInfo" : Object.FEATURE__SERIALIZE } + + + + +if "srcdir" in os.environ: + input_filename = os.path.join(os.environ["srcdir"], "esx/esx_vi_generator.input") + output_dirname = os.path.join(os.environ["srcdir"], "esx") +else: + input_filename = os.path.join(os.getcwd(), "esx_vi_generator.input") + output_dirname = os.getcwd() + + + +typedef = open_and_print(os.path.join(output_dirname, "esx_vi_types.generated.typedef")) +typeenum = open_and_print(os.path.join(output_dirname, "esx_vi_types.generated.typeenum")) +typetostring = open_and_print(os.path.join(output_dirname, "esx_vi_types.generated.typetostring")) +typefromstring = open_and_print(os.path.join(output_dirname, "esx_vi_types.generated.typefromstring")) +header = open_and_print(os.path.join(output_dirname, "esx_vi_types.generated.h")) +source = open_and_print(os.path.join(output_dirname, "esx_vi_types.generated.c")) + + + +number = 0 +objects_by_name = {} +enums_by_name = {} +block = None + + + +for line in file(input_filename, "rb").readlines(): + number += 1 + + if "#" in line: + line = line[:line.index("#")] + + line = line.lstrip().rstrip() + + if len(line) < 1: + continue + + if line.startswith("object") or line.startswith("enum"): + if block is not None: + report_error("line %d: nested block found" % (number)) + else: + block = [] + + if block is not None: + if line == "end": + if block[0][1].startswith("object"): + obj = parse_object(block) + objects_by_name[obj.name] = obj + else: + enum = parse_enum(block) + enums_by_name[enum.name] = enum + + block = None + else: + block.append((number, line)) + + + +for enum in enums_by_name.values(): + # apply additional features + if enum.name in additional_enum_features: + enum.features |= additional_enum_features[enum.name] + + + +for obj in objects_by_name.values(): + for property in obj.properties: + if property.occurrence != Property.OCCURRENCE__IGNORED and \ + not is_known_type(property.type): + report_error("object '%s' contains unknown property type '%s'" % (obj.name, property.type)) + + if obj.extends is not None: + if not is_known_type(obj.extends): + report_error("object '%s' extends unknown object '%s'" % (obj.name, obj.extends)) + + # detect list usage + for property in obj.properties: + if (property.occurrence == Property.OCCURRENCE__REQUIRED_LIST or \ + property.occurrence == Property.OCCURRENCE__OPTIONAL_LIST) and \ + property.type not in predefined_objects: + objects_by_name[property.type].features |= Object.FEATURE__LIST + + # apply/remove additional features + if obj.name in additional_object_features: + obj.features |= additional_object_features[obj.name] + + if obj.name in removed_object_features: + obj.features &= ~removed_object_features[obj.name] + + # spread deep copy onto properties + if obj.features & Object.FEATURE__DEEP_COPY: + for property in obj.properties: + if property.occurrence != Property.OCCURRENCE__IGNORED and \ + property.type not in predefined_objects: + objects_by_name[property.type].features |= Object.FEATURE__DEEP_COPY + + # detect extended_by relation + if obj.extends is not None: + extended_obj = objects_by_name[obj.extends] + + if extended_obj.extended_by is None: + extended_obj.extended_by = [obj.name] + else: + extended_obj.extended_by.append(obj.name) + + + + + +for obj in objects_by_name.values(): + inherit_features(obj) + + + + + +typedef.write("/* Generated by esx_vi_generator.py */\n\n\n\n") +typeenum.write("/* Generated by esx_vi_generator.py */\n\n") +typetostring.write("/* Generated by esx_vi_generator.py */\n\n") +typefromstring.write("/* Generated by esx_vi_generator.py */\n\n") +header.write("/* Generated by esx_vi_generator.py */\n\n\n\n") +source.write("/* Generated by esx_vi_generator.py */\n\n\n\n") + + +typedef.write("/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *\n" + + " * VI Enums\n" + + " */\n\n") + + + +names = enums_by_name.keys() +names.sort() + + +for name in names: + typedef.write(enums_by_name[name].generate_typedef()) + typeenum.write(enums_by_name[name].generate_typeenum()) + typetostring.write(enums_by_name[name].generate_typetostring()) + typefromstring.write(enums_by_name[name].generate_typefromstring()) + header.write(enums_by_name[name].generate_header()) + source.write(enums_by_name[name].generate_source()) + + + +typedef.write("\n\n\n" + + "/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *\n" + + " * VI Types\n" + + " */\n\n") + +typeenum.write("\n") + +typetostring.write("\n") + +typefromstring.write("\n") + + + +names = objects_by_name.keys() +names.sort() + + +for name in names: + typedef.write(objects_by_name[name].generate_typedef()) + typeenum.write(objects_by_name[name].generate_typeenum()) + typetostring.write(objects_by_name[name].generate_typetostring()) + typefromstring.write(objects_by_name[name].generate_typefromstring()) + header.write(objects_by_name[name].generate_header()) + source.write(objects_by_name[name].generate_source()) diff --git a/src/esx/esx_vi_methods.c b/src/esx/esx_vi_methods.c index 07cd82a..f1234ae 100644 --- a/src/esx/esx_vi_methods.c +++ b/src/esx/esx_vi_methods.c @@ -304,7 +304,7 @@ ESX_VI__METHOD(RetrieveProperties, (esxVI_Context *ctx, esxVI_PropertyFilterSpec *specSet, /* list */ esxVI_ObjectContent **objectContentList), - List, + OptionalList, { ESX_VI__METHOD__CHECK_SERVICE() ESX_VI__METHOD__PARAMETER__CHECK_OUTPUT(objectContentList) @@ -344,8 +344,7 @@ ESX_VI__METHOD(PowerOnVM_Task, virtualMachine) }, { - if (esxVI_ManagedObjectReference_Deserialize(response->node, task, - "Task") < 0) { + if (esxVI_ManagedObjectReference_Deserialize(response->node, task) < 0) { goto failure; } }) @@ -369,8 +368,7 @@ ESX_VI__METHOD(PowerOffVM_Task, virtualMachine) }, { - if (esxVI_ManagedObjectReference_Deserialize(response->node, task, - "Task") < 0) { + if (esxVI_ManagedObjectReference_Deserialize(response->node, task) < 0) { goto failure; } }) @@ -394,8 +392,7 @@ ESX_VI__METHOD(SuspendVM_Task, virtualMachine) }, { - if (esxVI_ManagedObjectReference_Deserialize(response->node, task, - "Task") < 0) { + if (esxVI_ManagedObjectReference_Deserialize(response->node, task) < 0) { goto failure; } }) @@ -428,8 +425,7 @@ ESX_VI__METHOD(MigrateVM_Task, ESX_VI__METHOD__PARAMETER__SERIALIZE(VirtualMachinePowerState, state) }, { - if (esxVI_ManagedObjectReference_Deserialize(response->node, task, - "Task") < 0) { + if (esxVI_ManagedObjectReference_Deserialize(response->node, task) < 0) { goto failure; } }) @@ -456,8 +452,7 @@ ESX_VI__METHOD(ReconfigVM_Task, ESX_VI__METHOD__PARAMETER__SERIALIZE(VirtualMachineConfigSpec, spec) }, { - if (esxVI_ManagedObjectReference_Deserialize(response->node, task, - "Task") < 0) { + if (esxVI_ManagedObjectReference_Deserialize(response->node, task) < 0) { goto failure; } }) @@ -490,8 +485,7 @@ ESX_VI__METHOD(RegisterVM_Task, ESX_VI__METHOD__PARAMETER__SERIALIZE(ManagedObjectReference, host) }, { - if (esxVI_ManagedObjectReference_Deserialize(response->node, task, - "Task") < 0) { + if (esxVI_ManagedObjectReference_Deserialize(response->node, task) < 0) { goto failure; } }) @@ -583,8 +577,8 @@ ESX_VI__METHOD(CreateFilter, ESX_VI__METHOD__PARAMETER__SERIALIZE(Boolean, partialUpdates) }, { - if (esxVI_ManagedObjectReference_Deserialize(response->node, propertyFilter, - "PropertyFilter") < 0) { + if (esxVI_ManagedObjectReference_Deserialize(response->node, + propertyFilter) < 0) { goto failure; } }) @@ -684,7 +678,7 @@ ESX_VI__METHOD(ValidateMigration, esxVI_ManagedObjectReference *pool, esxVI_ManagedObjectReference *host, esxVI_Event **eventList), - List, + OptionalList, { ESX_VI__METHOD__PARAMETER__CHECK_OUTPUT(eventList) }, @@ -736,10 +730,8 @@ ESX_VI__METHOD(FindByIp, ESX_VI__METHOD__PARAMETER__SERIALIZE(Boolean, vmSearch) }, { - if (esxVI_ManagedObjectReference_Deserialize - (response->node, managedObjectReference, - vmSearch == esxVI_Boolean_True ? "VirtualMachine" - : "HostSystem") < 0) { + if (esxVI_ManagedObjectReference_Deserialize(response->node, + managedObjectReference) < 0) { goto failure; } }) @@ -771,10 +763,8 @@ ESX_VI__METHOD(FindByUuid, ESX_VI__METHOD__PARAMETER__SERIALIZE(Boolean, vmSearch) }, { - if (esxVI_ManagedObjectReference_Deserialize - (response->node, managedObjectReference, - vmSearch == esxVI_Boolean_True ? "VirtualMachine" - : "HostSystem") < 0) { + if (esxVI_ManagedObjectReference_Deserialize(response->node, + managedObjectReference) < 0) { goto failure; } }) @@ -789,7 +779,7 @@ ESX_VI__METHOD(QueryAvailablePerfMetric, esxVI_DateTime *endTime, esxVI_Int *intervalId, esxVI_PerfMetricId **perfMetricIdList), - List, + OptionalList, { ESX_VI__METHOD__CHECK_SERVICE() ESX_VI__METHOD__PARAMETER__CHECK_OUTPUT(perfMetricIdList) @@ -820,7 +810,7 @@ ESX_VI__METHOD(QueryPerfCounter, (esxVI_Context *ctx, esxVI_Int *counterId, /* list */ esxVI_PerfCounterInfo **perfCounterInfoList), - List, + OptionalList, { ESX_VI__METHOD__CHECK_SERVICE() ESX_VI__METHOD__PARAMETER__CHECK_OUTPUT(perfCounterInfoList) @@ -848,7 +838,7 @@ ESX_VI__METHOD(QueryPerf, (esxVI_Context *ctx, esxVI_PerfQuerySpec *querySpec, /* list */ esxVI_PerfEntityMetric **perfEntityMetricList), - List, + OptionalList, { ESX_VI__METHOD__CHECK_SERVICE() ESX_VI__METHOD__PARAMETER__CHECK_OUTPUT(perfEntityMetricList) diff --git a/src/esx/esx_vi_types.c b/src/esx/esx_vi_types.c index 87a13cb..6f257b2 100644 --- a/src/esx/esx_vi_types.c +++ b/src/esx/esx_vi_types.c @@ -64,11 +64,17 @@ -#define ESX_VI__TEMPLATE__ALLOC(_type) \ +#define ESX_VI__TEMPLATE__ALLOC(__type) \ int \ - esxVI_##_type##_Alloc(esxVI_##_type **ptrptr) \ + esxVI_##__type##_Alloc(esxVI_##__type **ptrptr) \ { \ - return esxVI_Alloc((void **)ptrptr, sizeof(esxVI_##_type)); \ + if (esxVI_Alloc((void **)ptrptr, sizeof (esxVI_##__type)) < 0) { \ + return -1; \ + } \ + \ + (*ptrptr)->_type = esxVI_Type_##__type; \ + \ + return 0; \ } @@ -92,11 +98,18 @@ -#define ESX_VI__TEMPLATE__VALIDATE(_type, _require) \ +#define ESX_VI__TEMPLATE__VALIDATE(__type, _require) \ int \ - esxVI_##_type##_Validate(esxVI_##_type *item) \ + esxVI_##__type##_Validate(esxVI_##__type *item) \ { \ - const char *type_name = #_type; \ + const char *type_name = esxVI_Type_ToString(esxVI_Type_##__type); \ + \ + if (item->_type <= esxVI_Type_Undefined || \ + item->_type >= esxVI_Type_Other) { \ + ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, \ + "%s object has invalid dynamic type", type_name); \ + return -1; \ + } \ \ _require \ \ @@ -105,11 +118,31 @@ -#define ESX_VI__TEMPLATE__VALIDATE_NOOP(_type) \ +#define ESX_VI__TEMPLATE__DEEP_COPY(_type, _deep_copy) \ int \ - esxVI_##_type##_Validate(esxVI_##_type *item ATTRIBUTE_UNUSED) \ + esxVI_##_type##_DeepCopy(esxVI_##_type **dest, esxVI_##_type *src) \ { \ + if (dest == NULL || *dest != NULL) { \ + ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, "Invalid argument"); \ + return -1; \ + } \ + \ + if (src == NULL) { \ + return 0; \ + } \ + \ + if (esxVI_##_type##_Alloc(dest) < 0) { \ + goto failure; \ + } \ + \ + _deep_copy \ + \ return 0; \ + \ + failure: \ + esxVI_##_type##_Free(dest); \ + \ + return -1; \ } @@ -184,19 +217,20 @@ return -1; \ } \ \ - if (STRNEQ(anyType->other, #_type)) { \ + if (anyType->type != esxVI_Type_##_type) { \ ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, \ "Expecting type '%s' but found '%s'", \ - #_type, anyType->other); \ + esxVI_Type_ToString(esxVI_Type_##_type), \ + anyType->other); \ return -1; \ } \ \ - return esxVI_##_type##_Deserialize(anyType->_node, ptrptr); \ + return esxVI_##_type##_Deserialize(anyType->node, ptrptr); \ } -#define ESX_VI__TEMPLATE__SERIALIZE_EXTRA(_type, _type_string, _serialize) \ +#define ESX_VI__TEMPLATE__SERIALIZE_EXTRA(_type, _extra, _serialize) \ int \ esxVI_##_type##_Serialize(esxVI_##_type *item, \ const char *element, virBufferPtr output) \ @@ -210,11 +244,14 @@ return 0; \ } \ \ + _extra \ + \ if (esxVI_##_type##_Validate(item) < 0) { \ return -1; \ } \ \ - ESV_VI__XML_TAG__OPEN(output, element, _type_string); \ + ESV_VI__XML_TAG__OPEN(output, element, \ + esxVI_Type_ToString(esxVI_Type_##_type)); \ \ _serialize \ \ @@ -226,7 +263,7 @@ #define ESX_VI__TEMPLATE__SERIALIZE(_type, _serialize) \ - ESX_VI__TEMPLATE__SERIALIZE_EXTRA(_type, #_type, _serialize) + ESX_VI__TEMPLATE__SERIALIZE_EXTRA(_type, /* nothing */, _serialize) @@ -328,6 +365,31 @@ +/* + * Macros for property handling to be used as part of other macros + */ + +#define ESX_VI__TEMPLATE__PROPERTY__DEEP_COPY(_type, _name) \ + if (esxVI_##_type##_DeepCopy(&(*dest)->_name, src->_name) < 0) { \ + goto failure; \ + } + + + +#define ESX_VI__TEMPLATE__PROPERTY__DEEP_COPY_LIST(_type, _name) \ + if (esxVI_##_type##_DeepCopyList(&(*dest)->_name, src->_name) < 0) { \ + goto failure; \ + } + + + +#define ESX_VI__TEMPLATE__PROPERTY__DEEP_COPY_VALUE(_type, _name) \ + if (esxVI_##_type##_DeepCopyValue(&(*dest)->_name, src->_name) < 0) { \ + goto failure; \ + } + + + #define ESX_VI__TEMPLATE__PROPERTY__SERIALIZE(_type, _name) \ if (esxVI_##_type##_Serialize(item->_name, #_name, output) < 0) { \ return -1; \ @@ -360,23 +422,17 @@ -#define ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(_type, _name) \ +#define ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_IGNORE(_name) \ if (xmlStrEqual(childNode->name, BAD_CAST #_name)) { \ - if (esxVI_##_type##_DeserializeValue(childNode, \ - &(*ptrptr)->_name) < 0) { \ - goto failure; \ - } \ - \ continue; \ } -#define ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(_type, _expected, \ - _name) \ +#define ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(_type, _name) \ if (xmlStrEqual(childNode->name, BAD_CAST #_name)) { \ - if (esxVI_##_type##_Deserialize(childNode, &(*ptrptr)->_name, \ - _expected) < 0) { \ + if (esxVI_##_type##_DeserializeValue(childNode, \ + &(*ptrptr)->_name) < 0) { \ goto failure; \ } \ \ @@ -385,13 +441,6 @@ -#define ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_NOOP(_name) \ - if (xmlStrEqual(childNode->name, BAD_CAST #_name)) { \ - continue; \ - } - - - #define ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_LIST(_type, _name) \ if (xmlStrEqual(childNode->name, BAD_CAST #_name)) { \ esxVI_##_type *_name##Item = NULL; \ @@ -427,6 +476,10 @@ +/* + * Macros to implement enumerations + */ + #define ESX_VI__TEMPLATE__ENUMERATION__CAST_FROM_ANY_TYPE(_type) \ int \ esxVI_##_type##_CastFromAnyType(esxVI_AnyType *anyType, \ @@ -459,20 +512,102 @@ +/* + * Macros to implement dynamic dispatched functions + */ + +#define ESX_VI__TEMPLATE__DISPATCH(__type, _dispatch, _error_return) \ + switch (item->_type) { \ + _dispatch \ + \ + case esxVI_Type_##__type: \ + break; \ + \ + default: \ + ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, \ + "Call to %s for unexpected type '%s'", __FUNCTION__, \ + esxVI_Type_ToString(item->_type)); \ + return _error_return; \ + } + + + +#define ESX_VI__TEMPLATE__DISPATCH__FREE(_type) \ + case esxVI_Type_##_type: \ + esxVI_##_type##_Free((esxVI_##_type **)ptrptr); \ + return; + + + +#define ESX_VI__TEMPLATE__DISPATCH__DEEP_COPY(_type) \ + case esxVI_Type_##_type: \ + return esxVI_##_type##_DeepCopy((esxVI_##_type **)dst, \ + (esxVI_##_type *)src); + + + +#define ESX_VI__TEMPLATE__DISPATCH__SERIALIZE(_type) \ + case esxVI_Type_##_type: \ + return esxVI_##_type##_Serialize((esxVI_##_type *)item, element, \ + output); + + + +#define ESX_VI__TEMPLATE__DYNAMIC_FREE(__type, _dispatch, _body) \ + ESX_VI__TEMPLATE__FREE(__type, \ + ESX_VI__TEMPLATE__DISPATCH(__type, _dispatch, /* nothing */) \ + _body) + + + +#define ESX_VI__TEMPLATE__DYNAMIC_CAST(__type, _accept) \ + esxVI_##__type * \ + esxVI_##__type##_DynamicCast(void *item) \ + { \ + if (item == NULL) { \ + ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, "Invalid argument"); \ + return NULL; \ + } \ + \ + _accept \ + \ + return NULL; \ + } + + + +#define ESX_VI__TEMPLATE__DYNAMIC_CAST__ACCEPT(__type) \ + if (((esxVI_Object *)item)->_type == esxVI_Type_##__type) { \ + return item; \ + } + + + +#define ESX_VI__TEMPLATE__DYNAMIC_SERIALIZE(__type, _dispatch, _serialize) \ + ESX_VI__TEMPLATE__SERIALIZE_EXTRA(__type, \ + ESX_VI__TEMPLATE__DISPATCH(__type, _dispatch, -1), \ + _serialize) + + + /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * XSI: Type */ const char * -esxVI_Type_Name(esxVI_Type type) +esxVI_Type_ToString(esxVI_Type type) { switch (type) { + default: case esxVI_Type_Undefined: - return "undefined"; + return "<undefined>"; case esxVI_Type_Boolean: return "xsd:boolean"; + case esxVI_Type_AnyType: + return "xsd:anyType"; + case esxVI_Type_String: return "xsd:string"; @@ -485,14 +620,53 @@ esxVI_Type_Name(esxVI_Type type) case esxVI_Type_Long: return "xsd:long"; - case esxVI_Type_Other: - return "other"; + case esxVI_Type_DateTime: + return "xsd:dateTime"; - default: - return "unknown"; + case esxVI_Type_Fault: + return "Fault"; + + case esxVI_Type_ManagedObjectReference: + return "ManagedObjectReference"; + +#include "esx_vi_types.generated.typetostring" + + case esxVI_Type_Other: + return "<other>"; } } +esxVI_Type +esxVI_Type_FromString(const char *type) +{ + if (type == NULL || STREQ(type, "<undefined>")) { + return esxVI_Type_Undefined; + } else if (STREQ(type, "xsd:boolean")) { + return esxVI_Type_Boolean; + } else if (STREQ(type, "xsd:anyType")) { + return esxVI_Type_AnyType; + } else if (STREQ(type, "xsd:string")) { + return esxVI_Type_String; + } else if (STREQ(type, "xsd:short")) { + return esxVI_Type_Short; + } else if (STREQ(type, "xsd:int")) { + return esxVI_Type_Int; + } else if (STREQ(type, "xsd:long")) { + return esxVI_Type_Long; + } else if (STREQ(type, "xsd:dateTime")) { + return esxVI_Type_DateTime; + } else if (STREQ(type, "Fault")) { + return esxVI_Type_Fault; + } else if (STREQ(type, "ManagedObjectReference")) { + return esxVI_Type_ManagedObjectReference; + } + +#include "esx_vi_types.generated.typefromstring" + + else { + return esxVI_Type_Other; + } +} /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * @@ -500,7 +674,7 @@ esxVI_Type_Name(esxVI_Type type) */ static const esxVI_Enumeration _esxVI_Boolean_Enumeration = { - "xsd:boolean", { + esxVI_Type_Boolean, { { "true", esxVI_Boolean_True }, { "false", esxVI_Boolean_False }, { NULL, -1 }, @@ -525,7 +699,7 @@ ESX_VI__TEMPLATE__ALLOC(AnyType); /* esxVI_AnyType_Free */ ESX_VI__TEMPLATE__FREE(AnyType, { - xmlFreeNode(item->_node); + xmlFreeNode(item->node); VIR_FREE(item->other); VIR_FREE(item->value); }); @@ -536,9 +710,9 @@ esxVI_AnyType_ExpectType(esxVI_AnyType *anyType, esxVI_Type type) if (anyType->type != type) { ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, "Expecting type '%s' but found '%s'", - esxVI_Type_Name(type), + esxVI_Type_ToString(type), anyType->type != esxVI_Type_Other - ? esxVI_Type_Name(anyType->type) + ? esxVI_Type_ToString(anyType->type) : anyType->other); return -1; } @@ -562,9 +736,10 @@ esxVI_AnyType_DeepCopy(esxVI_AnyType **dest, esxVI_AnyType *src) goto failure; } - (*dest)->_node = xmlCopyNode(src->_node, 1); + (*dest)->_type = src->_type; + (*dest)->node = xmlCopyNode(src->node, 1); - if ((*dest)->_node == NULL) { + if ((*dest)->node == NULL) { ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, "Could not copy an XML node"); goto failure; } @@ -612,7 +787,7 @@ esxVI_AnyType_DeepCopy(esxVI_AnyType **dest, esxVI_AnyType *src) int esxVI_AnyType_Deserialize(xmlNodePtr node, esxVI_AnyType **anyType) { - long long number; + long long int number; if (anyType == NULL || *anyType != NULL) { ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, "Invalid argument"); @@ -623,9 +798,9 @@ esxVI_AnyType_Deserialize(xmlNodePtr node, esxVI_AnyType **anyType) return -1; } - (*anyType)->_node = xmlCopyNode(node, 1); + (*anyType)->node = xmlCopyNode(node, 1); - if ((*anyType)->_node == NULL) { + if ((*anyType)->node == NULL) { ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, "Could not copy an XML node"); goto failure; } @@ -641,6 +816,15 @@ esxVI_AnyType_Deserialize(xmlNodePtr node, esxVI_AnyType **anyType) goto failure; } + (*anyType)->type = esxVI_Type_FromString((*anyType)->other); + + if ((*anyType)->type == esxVI_Type_Undefined) { + ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, + "Unknown value '%s' for AnyType 'type' property", + (*anyType)->other); + goto failure; + } + (*anyType)->value = (char *)xmlNodeListGetString(node->doc, node->children, 1); @@ -669,13 +853,11 @@ esxVI_AnyType_Deserialize(xmlNodePtr node, esxVI_AnyType **anyType) goto failure; \ } \ \ - (*anyType)->type = esxVI_Type_##_type; \ (*anyType)->_name = number; \ } while (0) - if (STREQ((*anyType)->other, "xsd:boolean")) { - (*anyType)->type = esxVI_Type_Boolean; - + switch ((*anyType)->type) { + case esxVI_Type_Boolean: if (STREQ((*anyType)->value, "true")) { (*anyType)->boolean = esxVI_Boolean_True; } else if (STREQ((*anyType)->value, "false")) { @@ -686,15 +868,27 @@ esxVI_AnyType_Deserialize(xmlNodePtr node, esxVI_AnyType **anyType) (*anyType)->value); goto failure; } - } else if (STREQ((*anyType)->other, "xsd:string")) { - (*anyType)->type = esxVI_Type_String; + + break; + + case esxVI_Type_String: (*anyType)->string = (*anyType)->value; - } else if (STREQ((*anyType)->other, "xsd:short")) { + break; + + case esxVI_Type_Short: _DESERIALIZE_NUMBER(Short, "xsd:short", int16, INT16_MIN, INT16_MAX); - } else if (STREQ((*anyType)->other, "xsd:int")) { + break; + + case esxVI_Type_Int: _DESERIALIZE_NUMBER(Int, "xsd:int", int32, INT32_MIN, INT32_MAX); - } else if (STREQ((*anyType)->other, "xsd:long")) { + break; + + case esxVI_Type_Long: _DESERIALIZE_NUMBER(Long, "xsd:long", int64, INT64_MIN, INT64_MAX); + break; + + default: + break; } #undef _DESERIALIZE_NUMBER @@ -724,6 +918,12 @@ ESX_VI__TEMPLATE__FREE(String, VIR_FREE(item->value); }); +/* esxVI_String_Validate */ +ESX_VI__TEMPLATE__VALIDATE(String, +{ + ESX_VI__TEMPLATE__PROPERTY__REQUIRE(value) +}) + /* esxVI_String_AppendToList */ ESX_VI__TEMPLATE__LIST__APPEND(String); @@ -782,30 +982,11 @@ esxVI_String_AppendValueListToList(esxVI_String **stringList, return -1; } -int -esxVI_String_DeepCopy(esxVI_String **dest, esxVI_String *src) +/* esxVI_String_DeepCopy */ +ESX_VI__TEMPLATE__DEEP_COPY(String, { - if (dest == NULL || *dest != NULL) { - ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, "Invalid argument"); - return -1; - } - - if (src == NULL) { - return 0; - } - - if (esxVI_String_Alloc(dest) < 0 || - esxVI_String_DeepCopyValue(&(*dest)->value, src->value)) { - goto failure; - } - - return 0; - - failure: - esxVI_String_Free(dest); - - return -1; -} + ESX_VI__TEMPLATE__PROPERTY__DEEP_COPY_VALUE(String, value) +}) /* esxVI_String_DeepCopyList */ ESX_VI__TEMPLATE__LIST__DEEP_COPY(String); @@ -865,37 +1046,11 @@ esxVI_String_SerializeValue(const char *value, const char *element, return 0; } -int -esxVI_String_Deserialize(xmlNodePtr node, esxVI_String **string) +/* esxVI_String_Deserialize */ +ESX_VI__TEMPLATE__DESERIALIZE(String, { - if (string == NULL || *string != NULL) { - ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, "Invalid argument"); - return -1; - } - - if (esxVI_String_Alloc(string) < 0) { - return -1; - } - - (*string)->value = - (char *)xmlNodeListGetString(node->doc, node->children, 1); - - if ((*string)->value == NULL) { - (*string)->value = strdup(""); - - if ((*string)->value == NULL) { - virReportOOMError(); - goto failure; - } - } - - return 0; - - failure: - esxVI_String_Free(string); - - return -1; -} + ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, value) +}) /* esxVI_String_DeserializeList */ ESX_VI__TEMPLATE__LIST__DESERIALIZE(String); @@ -938,39 +1093,21 @@ ESX_VI__TEMPLATE__FREE(Int, }); /* esxVI_Int_Validate */ -ESX_VI__TEMPLATE__VALIDATE_NOOP(Int); +ESX_VI__TEMPLATE__VALIDATE(Int, +{ +}) /* esxVI_Int_AppendToList */ ESX_VI__TEMPLATE__LIST__APPEND(Int); -int -esxVI_Int_DeepCopy(esxVI_Int **dest, esxVI_Int *src) +/* esxVI_Int_DeepCopy */ +ESX_VI__TEMPLATE__DEEP_COPY(Int, { - if (dest == NULL || *dest != NULL) { - ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, "Invalid argument"); - return -1; - } - - if (src == NULL) { - return 0; - } - - if (esxVI_Int_Alloc(dest) < 0) { - goto failure; - } - (*dest)->value = src->value; - - return 0; - - failure: - esxVI_Int_Free(dest); - - return -1; -} +}) /* esxVI_Int_Serialize */ -ESX_VI__TEMPLATE__SERIALIZE_EXTRA(Int, "xsd:int", +ESX_VI__TEMPLATE__SERIALIZE(Int, { virBufferVSprintf(output, "%d", (int)item->value); }); @@ -997,13 +1134,15 @@ ESX_VI__TEMPLATE__FREE(Long, }); /* esxVI_Long_Validate */ -ESX_VI__TEMPLATE__VALIDATE_NOOP(Long); +ESX_VI__TEMPLATE__VALIDATE(Long, +{ +}) /* esxVI_Long_AppendToList */ ESX_VI__TEMPLATE__LIST__APPEND(Long); /* esxVI_Long_Serialize */ -ESX_VI__TEMPLATE__SERIALIZE_EXTRA(Long, "xsd:long", +ESX_VI__TEMPLATE__SERIALIZE(Long, { virBufferVSprintf(output, "%lld", (long long int)item->value); }); @@ -1036,7 +1175,7 @@ ESX_VI__TEMPLATE__VALIDATE(DateTime, }); /* esxVI_DateTime_Serialize */ -ESX_VI__TEMPLATE__SERIALIZE_EXTRA(DateTime, "xsd:dateTime", +ESX_VI__TEMPLATE__SERIALIZE(DateTime, { virBufferAdd(output, item->value, -1); }); @@ -1074,184 +1213,6 @@ esxVI_DateTime_Deserialize(xmlNodePtr node, esxVI_DateTime **dateTime) /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Enum: ManagedEntityStatus - */ - -static const esxVI_Enumeration _esxVI_ManagedEntityStatus_Enumeration = { - "ManagedEntityStatus", { - { "gray", esxVI_ManagedEntityStatus_Gray }, - { "green", esxVI_ManagedEntityStatus_Green }, - { "yellow", esxVI_ManagedEntityStatus_Yellow }, - { "red", esxVI_ManagedEntityStatus_Red }, - { NULL, -1 }, - }, -}; - -/* esxVI_ManagedEntityStatus_CastFromAnyType */ -ESX_VI__TEMPLATE__ENUMERATION__CAST_FROM_ANY_TYPE(ManagedEntityStatus); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Enum: ObjectUpdateKind - */ - -static const esxVI_Enumeration _esxVI_ObjectUpdateKind_Enumeration = { - "ObjectUpdateKind", { - { "enter", esxVI_ObjectUpdateKind_Enter }, - { "leave", esxVI_ObjectUpdateKind_Leave }, - { "modify", esxVI_ObjectUpdateKind_Modify }, - { NULL, -1 }, - }, -}; - -/* esxVI_ObjectUpdateKind_Deserialize */ -ESX_VI__TEMPLATE__ENUMERATION__DESERIALIZE(ObjectUpdateKind); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Enum: PerfSummaryType - */ - -static const esxVI_Enumeration _esxVI_PerfSummaryType_Enumeration = { - "PerfSummaryType", { - { "average", esxVI_PerfSummaryType_Average }, - { "latest", esxVI_PerfSummaryType_Latest }, - { "maximum", esxVI_PerfSummaryType_Maximum }, - { "minimum", esxVI_PerfSummaryType_Minimum }, - { "none", esxVI_PerfSummaryType_None }, - { "summation", esxVI_PerfSummaryType_Summation }, - { NULL, -1 }, - }, -}; - -/* esxVI_PerfSummaryType_Deserialize */ -ESX_VI__TEMPLATE__ENUMERATION__DESERIALIZE(PerfSummaryType); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Enum: PerfStatsType - */ - -static const esxVI_Enumeration _esxVI_PerfStatsType_Enumeration = { - "PerfStatsType", { - { "absolute", esxVI_PerfStatsType_Absolute }, - { "delta", esxVI_PerfStatsType_Delta }, - { "rate", esxVI_PerfStatsType_Rate }, - { NULL, -1 }, - }, -}; - -/* esxVI_PerfStatsType_Deserialize */ -ESX_VI__TEMPLATE__ENUMERATION__DESERIALIZE(PerfStatsType); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Enum: PropertyChangeOp - */ - -static const esxVI_Enumeration _esxVI_PropertyChangeOp_Enumeration = { - "PropertyChangeOp", { - { "add", esxVI_PropertyChangeOp_Add }, - { "remove", esxVI_PropertyChangeOp_Remove }, - { "assign", esxVI_PropertyChangeOp_Assign }, - { "indirectRemove", esxVI_PropertyChangeOp_IndirectRemove }, - { NULL, -1 }, - }, -}; - -/* esxVI_PropertyChangeOp_Deserialize */ -ESX_VI__TEMPLATE__ENUMERATION__DESERIALIZE(PropertyChangeOp); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Enum: SharesLevel - */ - -static const esxVI_Enumeration _esxVI_SharesLevel_Enumeration = { - "SharesLevel", { - { "custom", esxVI_SharesLevel_Custom }, - { "high", esxVI_SharesLevel_High }, - { "low", esxVI_SharesLevel_Low }, - { "normal", esxVI_SharesLevel_Normal }, - { NULL, -1 }, - }, -}; - -/* esxVI_SharesLevel_Serialize */ -ESX_VI__TEMPLATE__ENUMERATION__SERIALIZE(SharesLevel); - -/* esxVI_SharesLevel_Deserialize */ -ESX_VI__TEMPLATE__ENUMERATION__DESERIALIZE(SharesLevel); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Enum: TaskInfoState - */ - -static const esxVI_Enumeration _esxVI_TaskInfoState_Enumeration = { - "TaskInfoState", { - { "error", esxVI_TaskInfoState_Error }, - { "queued", esxVI_TaskInfoState_Queued }, - { "running", esxVI_TaskInfoState_Running }, - { "success", esxVI_TaskInfoState_Success }, - { NULL, -1 }, - }, -}; - -/* esxVI_TaskInfoState_CastFromAnyType */ -ESX_VI__TEMPLATE__ENUMERATION__CAST_FROM_ANY_TYPE(TaskInfoState); - -/* esxVI_TaskInfoState_Deserialize */ -ESX_VI__TEMPLATE__ENUMERATION__DESERIALIZE(TaskInfoState); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Enum: VirtualMachineMovePriority - */ - -static const esxVI_Enumeration _esxVI_VirtualMachineMovePriority_Enumeration = { - "VirtualMachineMovePriority", { - { "lowPriority", esxVI_VirtualMachineMovePriority_LowPriority }, - { "highPriority", esxVI_VirtualMachineMovePriority_HighPriority }, - { "defaultPriority", esxVI_VirtualMachineMovePriority_DefaultPriority }, - { NULL, -1 }, - }, -}; - -/* esxVI_VirtualMachineMovePriority_Serialize */ -ESX_VI__TEMPLATE__ENUMERATION__SERIALIZE(VirtualMachineMovePriority); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Enum: VirtualMachinePowerState - */ - -static const esxVI_Enumeration _esxVI_VirtualMachinePowerState_Enumeration = { - "VirtualMachinePowerState", { - { "poweredOff", esxVI_VirtualMachinePowerState_PoweredOff }, - { "poweredOn", esxVI_VirtualMachinePowerState_PoweredOn }, - { "suspended", esxVI_VirtualMachinePowerState_Suspended }, - { NULL, -1 }, - }, -}; - -/* esxVI_VirtualMachinePowerState_CastFromAnyType */ -ESX_VI__TEMPLATE__ENUMERATION__CAST_FROM_ANY_TYPE(VirtualMachinePowerState); - -/* esxVI_VirtualMachinePowerState_Serialize */ -ESX_VI__TEMPLATE__ENUMERATION__SERIALIZE(VirtualMachinePowerState); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * VI Type: Fault */ @@ -1277,7 +1238,7 @@ ESX_VI__TEMPLATE__DESERIALIZE(Fault, { ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, faultcode); ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, faultstring); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_NOOP(detail); /* FIXME */ + ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_IGNORE(detail); /* FIXME */ }); @@ -1298,128 +1259,21 @@ ESX_VI__TEMPLATE__FREE(ManagedObjectReference, VIR_FREE(item->value); }); -int -esxVI_ManagedObjectReference_DeepCopy(esxVI_ManagedObjectReference **dest, - esxVI_ManagedObjectReference *src) +/* esxVI_ManagedObjectReference_DeepCopy */ +ESX_VI__TEMPLATE__DEEP_COPY(ManagedObjectReference, { - if (dest == NULL || *dest != NULL) { - ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, "Invalid argument"); - return -1; - } - - if (src == NULL) { - return 0; - } - - if (esxVI_ManagedObjectReference_Alloc(dest) < 0 || - esxVI_String_DeepCopyValue(&(*dest)->type, src->type) < 0 || - esxVI_String_DeepCopyValue(&(*dest)->value, src->value) < 0) { - goto failure; - } - - return 0; - - failure: - esxVI_ManagedObjectReference_Free(dest); - - return -1; -} + ESX_VI__TEMPLATE__PROPERTY__DEEP_COPY_VALUE(String, type) + ESX_VI__TEMPLATE__PROPERTY__DEEP_COPY_VALUE(String, value) +}) /* esxVI_ManagedObjectReference_AppendToList */ ESX_VI__TEMPLATE__LIST__APPEND(ManagedObjectReference); -int -esxVI_ManagedObjectReference_CastFromAnyType - (esxVI_AnyType *anyType, - esxVI_ManagedObjectReference **managedObjectReference, - const char *expectedType) -{ - if (anyType == NULL || managedObjectReference == NULL || - *managedObjectReference != NULL) { - ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, "Invalid argument"); - return -1; - } - - if (STRNEQ(anyType->other, "ManagedObjectReference")) { - ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, - "Expecting type 'ManagedObjectReference' but found '%s'", - anyType->other); - return -1; - } - - return esxVI_ManagedObjectReference_Deserialize(anyType->_node, - managedObjectReference, - expectedType); -} - -int -esxVI_ManagedObjectReference_CastListFromAnyType - (esxVI_AnyType *anyType, - esxVI_ManagedObjectReference **managedObjectReferenceList, - const char *expectedType) -{ - int result = 0; - xmlNodePtr childNode = NULL; - esxVI_AnyType *childAnyType = NULL; - esxVI_ManagedObjectReference *managedObjectReference = NULL; - - if (managedObjectReferenceList == NULL || - *managedObjectReferenceList != NULL) { - ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, "Invalid argument"); - goto failure; - } - - if (anyType == NULL) { - return 0; - } - - if (STRNEQ(anyType->other, "ArrayOfManagedObjectReference")) { - ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, - "Expecting type to be 'ArrayOfManagedObjectReference' " - "but found '%s'", anyType->other); - goto failure; - } - - for (childNode = anyType->_node->children; childNode != NULL; - childNode = childNode->next) { - if (childNode->type != XML_ELEMENT_NODE) { - ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, - "Wrong XML element type %d", childNode->type); - goto failure; - } - - esxVI_AnyType_Free(&childAnyType); - - if (esxVI_AnyType_Deserialize(childNode, &childAnyType) < 0) { - goto failure; - } - - managedObjectReference = NULL; - - if (esxVI_ManagedObjectReference_CastFromAnyType - (childAnyType, &managedObjectReference, expectedType) < 0) { - goto failure; - } - - if (esxVI_ManagedObjectReference_AppendToList - (managedObjectReferenceList, managedObjectReference) < 0) { - goto failure; - } - } - +/* esxVI_ManagedObjectReference_CastFromAnyType */ +ESX_VI__TEMPLATE__CAST_FROM_ANY_TYPE(ManagedObjectReference) - cleanup: - esxVI_AnyType_Free(&childAnyType); - - return result; - - failure: - esxVI_ManagedObjectReference_Free(managedObjectReferenceList); - - result = -1; - - goto cleanup; -} +/* esxVI_ManagedObjectReference_CastListFromAnyType */ +ESX_VI__TEMPLATE__LIST__CAST_FROM_ANY_TYPE(ManagedObjectReference) int esxVI_ManagedObjectReference_Serialize @@ -1454,8 +1308,7 @@ ESX_VI__TEMPLATE__LIST__SERIALIZE(ManagedObjectReference); int esxVI_ManagedObjectReference_Deserialize - (xmlNodePtr node, esxVI_ManagedObjectReference **managedObjectReference, - const char *expectedType) + (xmlNodePtr node, esxVI_ManagedObjectReference **managedObjectReference) { if (managedObjectReference == NULL || *managedObjectReference != NULL) { ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, "Invalid argument"); @@ -1475,14 +1328,6 @@ esxVI_ManagedObjectReference_Deserialize goto failure; } - if (expectedType != NULL && - STRNEQ(expectedType, (*managedObjectReference)->type)) { - ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, - "Expected type '%s' but found '%s'", expectedType, - (*managedObjectReference)->type); - goto failure; - } - if (esxVI_String_DeserializeValue(node, &(*managedObjectReference)->value) < 0) { goto failure; @@ -1496,1533 +1341,4 @@ esxVI_ManagedObjectReference_Deserialize return -1; } - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: DynamicProperty - */ - -/* esxVI_DynamicProperty_Alloc */ -ESX_VI__TEMPLATE__ALLOC(DynamicProperty); - -/* esxVI_DynamicProperty_Free */ -ESX_VI__TEMPLATE__FREE(DynamicProperty, -{ - esxVI_DynamicProperty_Free(&item->_next); - - VIR_FREE(item->name); - esxVI_AnyType_Free(&item->val); -}); - -/* esxVI_DynamicProperty_Validate */ -ESX_VI__TEMPLATE__VALIDATE(DynamicProperty, -{ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(name); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(val); -}); - -int -esxVI_DynamicProperty_DeepCopy(esxVI_DynamicProperty **dest, - esxVI_DynamicProperty *src) -{ - if (dest == NULL || *dest != NULL) { - ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, "Invalid argument"); - return -1; - } - - if (src == NULL) { - return 0; - } - - if (esxVI_DynamicProperty_Alloc(dest) < 0 || - esxVI_String_DeepCopyValue(&(*dest)->name, src->name) < 0 || - esxVI_AnyType_DeepCopy(&(*dest)->val, src->val) < 0) { - goto failure; - } - - return 0; - - failure: - esxVI_DynamicProperty_Free(dest); - - return -1; -} - -/* esxVI_DynamicProperty_DeepCopyList */ -ESX_VI__TEMPLATE__LIST__DEEP_COPY(DynamicProperty); - -/* esxVI_DynamicProperty_AppendToList */ -ESX_VI__TEMPLATE__LIST__APPEND(DynamicProperty); - -/* esxVI_DynamicProperty_Deserialize */ -ESX_VI__TEMPLATE__DESERIALIZE(DynamicProperty, -{ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, name); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(AnyType, val); -}); - -/* esxVI_DynamicProperty_DeserializeList */ -ESX_VI__TEMPLATE__LIST__DESERIALIZE(DynamicProperty); - - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: HostCpuIdInfo - */ - -/* esxVI_HostCpuIdInfo_Alloc */ -ESX_VI__TEMPLATE__ALLOC(HostCpuIdInfo); - -/* esxVI_HostCpuIdInfo_Free */ -ESX_VI__TEMPLATE__FREE(HostCpuIdInfo, -{ - esxVI_HostCpuIdInfo_Free(&item->_next); - - esxVI_Int_Free(&item->level); - VIR_FREE(item->vendor); - VIR_FREE(item->eax); - VIR_FREE(item->ebx); - VIR_FREE(item->ecx); - VIR_FREE(item->edx); -}); - -/* esxVI_HostCpuIdInfo_Validate */ -ESX_VI__TEMPLATE__VALIDATE(HostCpuIdInfo, -{ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(level); -}); - -/* esxVI_HostCpuIdInfo_CastFromAnyType */ -ESX_VI__TEMPLATE__CAST_FROM_ANY_TYPE(HostCpuIdInfo); - -/* esxVI_HostCpuIdInfo_CastListFromAnyType */ -ESX_VI__TEMPLATE__LIST__CAST_FROM_ANY_TYPE(HostCpuIdInfo); - -/* esxVI_HostCpuIdInfo_Deserialize */ -ESX_VI__TEMPLATE__DESERIALIZE(HostCpuIdInfo, -{ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(Int, level); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, vendor); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, eax); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, ebx); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, ecx); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, edx); -}); - -/* esxVI_HostCpuIdInfo_DeserializeList */ -ESX_VI__TEMPLATE__LIST__DESERIALIZE(HostCpuIdInfo); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: SelectionSpec - */ - -/* esxVI_SelectionSpec_Alloc */ -ESX_VI__TEMPLATE__ALLOC(SelectionSpec); - -void -esxVI_SelectionSpec_Free(esxVI_SelectionSpec **selectionSpec) -{ - esxVI_SelectionSpec *local = NULL; - - if (selectionSpec == NULL || *selectionSpec == NULL) { - return; - } - - esxVI_SelectionSpec_Free(&(*selectionSpec)->_next); - - if ((*selectionSpec)->_super != NULL) { - /* - * Explicitly set this pointer to NULL here, otherwise this is will - * result in a dangling pointer. The actual memory of this object is - * freed by a call from the esxVI_TraversalSpec_Free function to the - * esxVI_SelectionSpec_Free function with the base pointer. - * - * Use a local copy of the pointer and set the reference to NULL, - * otherwise Valgrind complains about invalid writes. - */ - local = *selectionSpec; - *selectionSpec = NULL; - - esxVI_TraversalSpec_Free(&local->_super); - } else { - VIR_FREE((*selectionSpec)->name); - - VIR_FREE(*selectionSpec); - } -} - -/* esxVI_SelectionSpec_Validate */ -ESX_VI__TEMPLATE__VALIDATE(SelectionSpec, -{ - if (item->_super != NULL) { - return esxVI_TraversalSpec_Validate(item->_super); - } - - /* All properties are optional */ - (void)type_name; -}); - -/* esxVI_SelectionSpec_AppendToList */ -ESX_VI__TEMPLATE__LIST__APPEND(SelectionSpec); - -int -esxVI_SelectionSpec_Serialize(esxVI_SelectionSpec *selectionSpec, - const char *element, virBufferPtr output) -{ - if (element == NULL || output == NULL) { - ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, "Invalid argument"); - return -1; - } - - if (selectionSpec == NULL) { - return 0; - } - - if (selectionSpec->_super != NULL) { - return esxVI_TraversalSpec_Serialize(selectionSpec->_super, element, - output); - } - - if (esxVI_SelectionSpec_Validate(selectionSpec) < 0) { - return -1; - } - - ESV_VI__XML_TAG__OPEN(output, element, "SelectionSpec"); - - if (esxVI_String_SerializeValue(selectionSpec->name, "name", output) < 0) { - return -1; - } - - ESV_VI__XML_TAG__CLOSE(output, element); - - return 0; -} - -/* esxVI_SelectionSpec_SerializeList */ -ESX_VI__TEMPLATE__LIST__SERIALIZE(SelectionSpec); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: TraversalSpec extends SelectionSpec - */ - -int -esxVI_TraversalSpec_Alloc(esxVI_TraversalSpec **traversalSpec) -{ - if (esxVI_Alloc((void **)traversalSpec, sizeof(esxVI_TraversalSpec)) < 0) { - return -1; - } - - if (esxVI_SelectionSpec_Alloc(&(*traversalSpec)->_base) < 0) { - esxVI_TraversalSpec_Free(traversalSpec); - return -1; - } - - (*traversalSpec)->_base->_super = *traversalSpec; - - return 0; -} - -void -esxVI_TraversalSpec_Free(esxVI_TraversalSpec **traversalSpec) -{ - esxVI_TraversalSpec *local = NULL; - - if (traversalSpec == NULL || *traversalSpec == NULL) { - return; - } - - /* - * Need to store the traversalSpec pointer in a local variable here, - * because it is possible that the traversalSpec pointer and the _super - * pointer represent the same location in memory, e.g. if - * esxVI_SelectionSpec_Free calls esxVI_TraversalSpec_Free with the _super - * pointer as argument. Setting the _super pointer to NULL sets the - * traversalSpec pointer also to NULL, because we're working on a reference - * to this pointer here. - * - * Also use a local copy of the pointer and set the reference to NULL, - * otherwise Valgrind complains about invalid writes. - */ - local = *traversalSpec; - *traversalSpec = NULL; - - /* - * Setting the _super pointer to NULL here is important, otherwise - * esxVI_SelectionSpec_Free would call esxVI_TraversalSpec_Free again, - * resulting in both functions calling each other trying to free the - * _base/_super object until a stackoverflow occurs. - */ - local->_base->_super = NULL; - - esxVI_SelectionSpec_Free(&local->_base); - VIR_FREE(local->type); - VIR_FREE(local->path); - esxVI_SelectionSpec_Free(&local->selectSet); - - VIR_FREE(local); -} - -/* esxVI_TraversalSpec_Validate */ -ESX_VI__TEMPLATE__VALIDATE(TraversalSpec, -{ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(type); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(path); -}); - -/* esxVI_TraversalSpec_Serialize */ -ESX_VI__TEMPLATE__SERIALIZE(TraversalSpec, -{ - if (esxVI_String_SerializeValue(item->_base->name, "name", output) < 0) { - return -1; - } - - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE_VALUE(String, type); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE_VALUE(String, path); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE(Boolean, skip); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE_LIST(SelectionSpec, selectSet); -}); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: ObjectSpec - */ - -/* esxVI_ObjectSpec_Alloc */ -ESX_VI__TEMPLATE__ALLOC(ObjectSpec); - -/* esxVI_ObjectSpec_Free */ -ESX_VI__TEMPLATE__FREE(ObjectSpec, -{ - esxVI_ObjectSpec_Free(&item->_next); - - esxVI_ManagedObjectReference_Free(&item->obj); - esxVI_SelectionSpec_Free(&item->selectSet); -}); - -/* esxVI_ObjectSpec_Validate */ -ESX_VI__TEMPLATE__VALIDATE(ObjectSpec, -{ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(obj); -}); - -/* esxVI_ObjectSpec_AppendToList */ -ESX_VI__TEMPLATE__LIST__APPEND(ObjectSpec); - -/* esxVI_ObjectSpec_Serialize */ -ESX_VI__TEMPLATE__SERIALIZE(ObjectSpec, -{ - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE(ManagedObjectReference, obj); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE(Boolean, skip); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE_LIST(SelectionSpec, selectSet); -}); - -/* esxVI_ObjectSpec_SerializeList */ -ESX_VI__TEMPLATE__LIST__SERIALIZE(ObjectSpec); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: PropertyChange - */ - -/* esxVI_PropertyChange_Alloc */ -ESX_VI__TEMPLATE__ALLOC(PropertyChange); - -/* esxVI_PropertyChange_Free */ -ESX_VI__TEMPLATE__FREE(PropertyChange, -{ - esxVI_PropertyChange_Free(&item->_next); - - VIR_FREE(item->name); - esxVI_AnyType_Free(&item->val); -}); - -/* esxVI_PropertyChange_Validate */ -ESX_VI__TEMPLATE__VALIDATE(PropertyChange, -{ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(name); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(op); -}); - -/* esxVI_PropertyChange_AppendToList */ -ESX_VI__TEMPLATE__LIST__APPEND(PropertyChange); - -/* esxVI_PropertyChange_Deserialize */ -ESX_VI__TEMPLATE__DESERIALIZE(PropertyChange, -{ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, name); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(PropertyChangeOp, op); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(AnyType, val); -}); - -/* esxVI_PropertyChange_DeserializeList */ -ESX_VI__TEMPLATE__LIST__DESERIALIZE(PropertyChange); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: PropertySpec - */ - -/* esxVI_PropertySpec_Alloc */ -ESX_VI__TEMPLATE__ALLOC(PropertySpec); - -/* esxVI_PropertySpec_Free */ -ESX_VI__TEMPLATE__FREE(PropertySpec, -{ - esxVI_PropertySpec_Free(&item->_next); - - VIR_FREE(item->type); - esxVI_String_Free(&item->pathSet); -}); - -/* esxVI_PropertySpec_Validate */ -ESX_VI__TEMPLATE__VALIDATE(PropertySpec, -{ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(type); -}); - -/* esxVI_PropertySpec_AppendToList */ -ESX_VI__TEMPLATE__LIST__APPEND(PropertySpec); - -/* esxVI_PropertySpec_Serialize */ -ESX_VI__TEMPLATE__SERIALIZE(PropertySpec, -{ - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE_VALUE(String, type); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE(Boolean, all); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE_LIST(String, pathSet); -}); - -/* esxVI_PropertySpec_SerializeList */ -ESX_VI__TEMPLATE__LIST__SERIALIZE(PropertySpec); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: PropertyFilterSpec - */ - -/* esxVI_PropertyFilterSpec_Alloc */ -ESX_VI__TEMPLATE__ALLOC(PropertyFilterSpec); - -/* esxVI_PropertyFilterSpec_Free */ -ESX_VI__TEMPLATE__FREE(PropertyFilterSpec, -{ - esxVI_PropertyFilterSpec_Free(&item->_next); - - esxVI_PropertySpec_Free(&item->propSet); - esxVI_ObjectSpec_Free(&item->objectSet); -}); - -/* esxVI_PropertyFilterSpec_Validate */ -ESX_VI__TEMPLATE__VALIDATE(PropertyFilterSpec, -{ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(propSet); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(objectSet); -}); - -/* esxVI_PropertyFilterSpec_AppendToList */ -ESX_VI__TEMPLATE__LIST__APPEND(PropertyFilterSpec); - -/* esxVI_PropertyFilterSpec_Serialize */ -ESX_VI__TEMPLATE__SERIALIZE(PropertyFilterSpec, -{ - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE_LIST(PropertySpec, propSet); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE_LIST(ObjectSpec, objectSet); -}); - -/* esxVI_PropertyFilterSpec_SerializeList */ -ESX_VI__TEMPLATE__LIST__SERIALIZE(PropertyFilterSpec); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: ObjectContent - */ - -/* esxVI_ObjectContent_Alloc */ -ESX_VI__TEMPLATE__ALLOC(ObjectContent); - -/* esxVI_ObjectContent_Free */ -ESX_VI__TEMPLATE__FREE(ObjectContent, -{ - esxVI_ObjectContent_Free(&item->_next); - - esxVI_ManagedObjectReference_Free(&item->obj); - esxVI_DynamicProperty_Free(&item->propSet); - /*esxVI_MissingProperty_Free(&item->missingSet);*//* FIXME */ -}); - -/* esxVI_ObjectContent_Validate */ -ESX_VI__TEMPLATE__VALIDATE(ObjectContent, -{ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(obj); -}); - -/* esxVI_ObjectContent_AppendToList */ -ESX_VI__TEMPLATE__LIST__APPEND(ObjectContent); - -int -esxVI_ObjectContent_DeepCopy(esxVI_ObjectContent **dest, - esxVI_ObjectContent *src) -{ - if (dest == NULL || *dest != NULL) { - ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, "Invalid argument"); - return -1; - } - - if (src == NULL) { - return 0; - } - - if (esxVI_ObjectContent_Alloc(dest) < 0 || - esxVI_ManagedObjectReference_DeepCopy(&(*dest)->obj, src->obj) < 0 || - esxVI_DynamicProperty_DeepCopyList(&(*dest)->propSet, - src->propSet) < 0) { - goto failure; - } - -#if 0 /* FIXME */ - if (esxVI_MissingProperty_DeepCopyList(&(*dest)->missingSet, - src->missingSet) < 0) { - goto failure; - } -#endif - - return 0; - - failure: - esxVI_ObjectContent_Free(dest); - - return -1; -} - -/* esxVI_ObjectContent_Deserialize */ -ESX_VI__TEMPLATE__DESERIALIZE(ObjectContent, -{ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - NULL, obj); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_LIST(DynamicProperty, propSet); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_NOOP(missingSet); /* FIXME */ -}); - -/* esxVI_ObjectContent_DeserializeList */ -ESX_VI__TEMPLATE__LIST__DESERIALIZE(ObjectContent); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: ObjectUpdate - */ - -/* esxVI_ObjectUpdate_Alloc */ -ESX_VI__TEMPLATE__ALLOC(ObjectUpdate); - -/* esxVI_ObjectUpdate_Free */ -ESX_VI__TEMPLATE__FREE(ObjectUpdate, -{ - esxVI_ObjectUpdate_Free(&item->_next); - - esxVI_ManagedObjectReference_Free(&item->obj); - esxVI_PropertyChange_Free(&item->changeSet); - /*esxVI_MissingProperty_Free(&item->missingSet);*//* FIXME */ -}); - -/* esxVI_ObjectUpdate_Validate */ -ESX_VI__TEMPLATE__VALIDATE(ObjectUpdate, -{ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(kind); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(obj); -}); - -/* esxVI_ObjectUpdate_AppendToList */ -ESX_VI__TEMPLATE__LIST__APPEND(ObjectUpdate); - -/* esxVI_ObjectUpdate_Deserialize */ -ESX_VI__TEMPLATE__DESERIALIZE(ObjectUpdate, -{ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(ObjectUpdateKind, kind); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - NULL, obj); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_LIST(PropertyChange, changeSet); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_NOOP(missingSet); /* FIXME */ -}); - -/* esxVI_ObjectUpdate_DeserializeList */ -ESX_VI__TEMPLATE__LIST__DESERIALIZE(ObjectUpdate); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: PropertyFilterUpdate - */ - -/* esxVI_PropertyFilterUpdate_Alloc */ -ESX_VI__TEMPLATE__ALLOC(PropertyFilterUpdate); - -/* esxVI_PropertyFilterUpdate_Free */ -ESX_VI__TEMPLATE__FREE(PropertyFilterUpdate, -{ - esxVI_PropertyFilterUpdate_Free(&item->_next); - - esxVI_ManagedObjectReference_Free(&item->filter); - esxVI_ObjectUpdate_Free(&item->objectSet); - /*esxVI_MissingProperty_Free(&item->missingSet);*//* FIXME */ -}); - -/* esxVI_PropertyFilterUpdate_Validate */ -ESX_VI__TEMPLATE__VALIDATE(PropertyFilterUpdate, -{ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(filter); -}); - -/* esxVI_PropertyFilterUpdate_AppendToList */ -ESX_VI__TEMPLATE__LIST__APPEND(PropertyFilterUpdate); - -/* esxVI_PropertyFilterUpdate_Deserialize */ -ESX_VI__TEMPLATE__DESERIALIZE(PropertyFilterUpdate, -{ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - NULL, filter); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_LIST(ObjectUpdate, objectSet); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_NOOP(missingSet); /* FIXME */ -}); - -/* esxVI_PropertyFilterUpdate_DeserializeList */ -ESX_VI__TEMPLATE__LIST__DESERIALIZE(PropertyFilterUpdate); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: AboutInfo - */ - -/* esxVI_AboutInfo_Alloc */ -ESX_VI__TEMPLATE__ALLOC(AboutInfo); - -/* esxVI_AboutInfo_Free */ -ESX_VI__TEMPLATE__FREE(AboutInfo, -{ - VIR_FREE(item->name); - VIR_FREE(item->fullName); - VIR_FREE(item->vendor); - VIR_FREE(item->version); - VIR_FREE(item->build); - VIR_FREE(item->localeVersion); - VIR_FREE(item->localeBuild); - VIR_FREE(item->osType); - VIR_FREE(item->productLineId); - VIR_FREE(item->apiType); - VIR_FREE(item->apiVersion); -}); - -/* esxVI_AboutInfo_Validate */ -ESX_VI__TEMPLATE__VALIDATE(AboutInfo, -{ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(name); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(fullName); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(vendor); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(version); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(build); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(localeVersion); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(localeBuild); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(osType); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(productLineId); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(apiType); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(apiVersion); -}); - -/* esxVI_AboutInfo_Deserialize */ -ESX_VI__TEMPLATE__DESERIALIZE(AboutInfo, -{ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, name); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, fullName); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, vendor); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, version); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, build); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, localeVersion); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, localeBuild); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, osType); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, productLineId); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, apiType); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, apiVersion); -}); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: ServiceContent - */ - -/* esxVI_ServiceContent_Alloc */ -ESX_VI__TEMPLATE__ALLOC(ServiceContent); - -/* esxVI_ServiceContent_Free */ -ESX_VI__TEMPLATE__FREE(ServiceContent, -{ - esxVI_ManagedObjectReference_Free(&item->rootFolder); - esxVI_ManagedObjectReference_Free(&item->propertyCollector); - esxVI_ManagedObjectReference_Free(&item->viewManager); - esxVI_AboutInfo_Free(&item->about); - esxVI_ManagedObjectReference_Free(&item->setting); - esxVI_ManagedObjectReference_Free(&item->userDirectory); - esxVI_ManagedObjectReference_Free(&item->sessionManager); - esxVI_ManagedObjectReference_Free(&item->authorizationManager); - esxVI_ManagedObjectReference_Free(&item->perfManager); - esxVI_ManagedObjectReference_Free(&item->scheduledTaskManager); - esxVI_ManagedObjectReference_Free(&item->alarmManager); - esxVI_ManagedObjectReference_Free(&item->eventManager); - esxVI_ManagedObjectReference_Free(&item->taskManager); - esxVI_ManagedObjectReference_Free(&item->extensionManager); - esxVI_ManagedObjectReference_Free(&item->customizationSpecManager); - esxVI_ManagedObjectReference_Free(&item->customFieldsManager); - esxVI_ManagedObjectReference_Free(&item->accountManager); - esxVI_ManagedObjectReference_Free(&item->diagnosticManager); - esxVI_ManagedObjectReference_Free(&item->licenseManager); - esxVI_ManagedObjectReference_Free(&item->searchIndex); - esxVI_ManagedObjectReference_Free(&item->fileManager); - esxVI_ManagedObjectReference_Free(&item->virtualDiskManager); - esxVI_ManagedObjectReference_Free(&item->virtualizationManager); -}); - -/* esxVI_ServiceContent_Validate */ -ESX_VI__TEMPLATE__VALIDATE(ServiceContent, -{ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(rootFolder); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(propertyCollector); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(about); -}); - -/* esxVI_ServiceContent_Deserialize */ -ESX_VI__TEMPLATE__DESERIALIZE(ServiceContent, -{ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - "Folder", rootFolder); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - "PropertyCollector", - propertyCollector); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - "ViewManager", - viewManager); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(AboutInfo, about); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - "OptionManager", setting); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - "UserDirectory", - userDirectory); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - "SessionManager", - sessionManager); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - "AuthorizationManager", - authorizationManager); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - "PerformanceManager", - perfManager); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - "ScheduledTaskManager", - scheduledTaskManager); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - "AlarmManager", - alarmManager); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - "EventManager", - eventManager); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - "TaskManager", - taskManager); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - "ExtensionManager", - extensionManager); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - "CustomizationSpecManager", - customizationSpecManager); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - "CustomFieldsManager", - customFieldsManager); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - "HostLocalAccountManager", - accountManager); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - "DiagnosticManager", - diagnosticManager); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - "LicenseManager", - licenseManager); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - "SearchIndex", - searchIndex); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - "FileManager", - fileManager); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - "VirtualDiskManager", - virtualDiskManager); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - "VirtualizationManager", - virtualizationManager); -}); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: UpdateSet - */ - -/* esxVI_UpdateSet_Alloc */ -ESX_VI__TEMPLATE__ALLOC(UpdateSet); - -/* esxVI_UpdateSet_Free */ -ESX_VI__TEMPLATE__FREE(UpdateSet, -{ - VIR_FREE(item->version); - esxVI_PropertyFilterUpdate_Free(&item->filterSet); -}); - -/* esxVI_UpdateSet_Validate */ -ESX_VI__TEMPLATE__VALIDATE(UpdateSet, -{ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(version); -}); - -/* esxVI_UpdateSet_Deserialize */ -ESX_VI__TEMPLATE__DESERIALIZE(UpdateSet, -{ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, version); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_LIST(PropertyFilterUpdate, - filterSet); -}); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: SharesInfo - */ - -/* esxVI_SharesInfo_Alloc */ -ESX_VI__TEMPLATE__ALLOC(SharesInfo); - -/* esxVI_SharesInfo_Free */ -ESX_VI__TEMPLATE__FREE(SharesInfo, -{ - esxVI_Int_Free(&item->shares); -}); - -/* esxVI_SharesInfo_Validate */ -ESX_VI__TEMPLATE__VALIDATE(SharesInfo, -{ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(shares); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(level); -}); - -/* esxVI_SharesInfo_CastFromAnyType */ -ESX_VI__TEMPLATE__CAST_FROM_ANY_TYPE(SharesInfo); - -/* esxVI_SharesInfo_Deserialize */ -ESX_VI__TEMPLATE__DESERIALIZE(SharesInfo, -{ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(Int, shares); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(SharesLevel, level); -}); - -/* esxVI_SharesInfo_Serialize */ -ESX_VI__TEMPLATE__SERIALIZE(SharesInfo, -{ - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE(Int, shares); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE(SharesLevel, level); -}); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: ResourceAllocationInfo - */ - -/* esxVI_ResourceAllocationInfo_Alloc */ -ESX_VI__TEMPLATE__ALLOC(ResourceAllocationInfo); - -/* esxVI_ResourceAllocationInfo_Free */ -ESX_VI__TEMPLATE__FREE(ResourceAllocationInfo, -{ - esxVI_Long_Free(&item->reservation); - esxVI_Long_Free(&item->limit); - esxVI_SharesInfo_Free(&item->shares); - esxVI_Long_Free(&item->overheadLimit); -}); - -/* esxVI_ResourceAllocationInfo_Validate */ -ESX_VI__TEMPLATE__VALIDATE_NOOP(ResourceAllocationInfo); - -/* esxVI_ResourceAllocationInfo_Serialize */ -ESX_VI__TEMPLATE__SERIALIZE(ResourceAllocationInfo, -{ - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE(Long, reservation); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE(Boolean, expandableReservation); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE(Long, limit); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE(SharesInfo, shares); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE(Long, overheadLimit); -}); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: ResourcePoolResourceUsage - */ - -/* esxVI_ResourcePoolResourceUsage_Alloc */ -ESX_VI__TEMPLATE__ALLOC(ResourcePoolResourceUsage); - -/* esxVI_ResourcePoolResourceUsage_Free */ -ESX_VI__TEMPLATE__FREE(ResourcePoolResourceUsage, -{ - esxVI_Long_Free(&item->reservationUsed); - esxVI_Long_Free(&item->reservationUsedForVm); - esxVI_Long_Free(&item->unreservedForPool); - esxVI_Long_Free(&item->unreservedForVm); - esxVI_Long_Free(&item->overallUsage); - esxVI_Long_Free(&item->maxUsage); -}); - -/* esxVI_ResourcePoolResourceUsage_Validate */ -ESX_VI__TEMPLATE__VALIDATE(ResourcePoolResourceUsage, -{ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(reservationUsed); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(reservationUsedForVm); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(unreservedForPool); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(unreservedForVm); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(overallUsage); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(maxUsage); -}); - -/* esxVI_ResourcePoolResourceUsage_CastFromAnyType */ -ESX_VI__TEMPLATE__CAST_FROM_ANY_TYPE(ResourcePoolResourceUsage); - -/* esxVI_ResourcePoolResourceUsage_Deserialize */ -ESX_VI__TEMPLATE__DESERIALIZE(ResourcePoolResourceUsage, -{ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(Long, reservationUsed); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(Long, reservationUsedForVm); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(Long, unreservedForPool); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(Long, unreservedForVm); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(Long, overallUsage); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(Long, maxUsage); -}); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: VirtualMachineConfigSpec - */ - -/* esxVI_VirtualMachineConfigSpec_Alloc */ -ESX_VI__TEMPLATE__ALLOC(VirtualMachineConfigSpec); - -/* esxVI_VirtualMachineConfigSpec_Free */ -ESX_VI__TEMPLATE__FREE(VirtualMachineConfigSpec, -{ - VIR_FREE(item->changeVersion); - VIR_FREE(item->name); - VIR_FREE(item->version); - VIR_FREE(item->uuid); - esxVI_Long_Free(&item->npivNodeWorldWideName); - esxVI_Long_Free(&item->npivPortWorldWideName); - VIR_FREE(item->npivWorldWideNameType); - VIR_FREE(item->npivWorldWideNameOp); - VIR_FREE(item->locationId); - VIR_FREE(item->guestId); - VIR_FREE(item->alternateGuestName); - VIR_FREE(item->annotation); - /* FIXME: implement missing */ - esxVI_Int_Free(&item->numCPUs); - esxVI_Long_Free(&item->memoryMB); - /* FIXME: implement missing */ - esxVI_ResourceAllocationInfo_Free(&item->cpuAllocation); - esxVI_ResourceAllocationInfo_Free(&item->memoryAllocation); - /* FIXME: implement missing */ - VIR_FREE(item->swapPlacement); - /* FIXME: implement missing */ -}); - -/* esxVI_VirtualMachineConfigSpec_Validate */ -ESX_VI__TEMPLATE__VALIDATE_NOOP(VirtualMachineConfigSpec); - -/* esxVI_VirtualMachineConfigSpec_Serialize */ -ESX_VI__TEMPLATE__SERIALIZE(VirtualMachineConfigSpec, -{ - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE_VALUE(String, changeVersion); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE_VALUE(String, name); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE_VALUE(String, version); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE_VALUE(String, uuid); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE_LIST(Long, npivNodeWorldWideName); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE_LIST(Long, npivPortWorldWideName); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE_VALUE(String, npivWorldWideNameType); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE_VALUE(String, npivWorldWideNameOp); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE_VALUE(String, locationId); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE_VALUE(String, guestId); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE_VALUE(String, alternateGuestName); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE_VALUE(String, annotation); - /* FIXME: implement missing */ - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE(Int, numCPUs); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE(Long, memoryMB); - /* FIXME: implement missing */ - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE(ResourceAllocationInfo, - cpuAllocation); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE(ResourceAllocationInfo, - memoryAllocation); - /* FIXME: implement missing */ - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE_VALUE(String, swapPlacement); - /* FIXME: implement missing */ -}); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: Event - */ - -/* esxVI_Event_Alloc */ -ESX_VI__TEMPLATE__ALLOC(Event); - -/* esxVI_Event_Free */ -ESX_VI__TEMPLATE__FREE(Event, -{ - esxVI_Event_Free(&item->_next); - - /* FIXME: implement the rest */ - esxVI_Int_Free(&item->key); - esxVI_Int_Free(&item->chainId); - esxVI_DateTime_Free(&item->createdTime); - VIR_FREE(item->userName); - VIR_FREE(item->fullFormattedMessage); -}); - -/* esxVI_Event_Validate */ -ESX_VI__TEMPLATE__VALIDATE(Event, -{ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(key); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(chainId); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(createdTime); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(userName); -}); - -/* esxVI_Event_Deserialize */ -ESX_VI__TEMPLATE__DESERIALIZE(Event, -{ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(Int, key); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(Int, chainId); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(DateTime, createdTime); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, userName); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_NOOP(datacenter); /* FIXME */ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_NOOP(computeResource); /* FIXME */ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_NOOP(host); /* FIXME */ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_NOOP(vm); /* FIXME */ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, fullFormattedMessage); -}); - -/* esxVI_Event_DeserializeList */ -ESX_VI__TEMPLATE__LIST__DESERIALIZE(Event); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: UserSession - */ - -/* esxVI_UserSession_Alloc */ -ESX_VI__TEMPLATE__ALLOC(UserSession); - -/* esxVI_UserSession_Free */ -ESX_VI__TEMPLATE__FREE(UserSession, -{ - VIR_FREE(item->key); - VIR_FREE(item->userName); - VIR_FREE(item->fullName); - esxVI_DateTime_Free(&item->loginTime); - esxVI_DateTime_Free(&item->lastActiveTime); - VIR_FREE(item->locale); - VIR_FREE(item->messageLocale); -}); - -/* esxVI_UserSession_Validate */ -ESX_VI__TEMPLATE__VALIDATE(UserSession, -{ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(key); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(userName); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(fullName); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(loginTime); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(lastActiveTime); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(locale); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(messageLocale); -}); - -/* esxVI_UserSession_CastFromAnyType */ -ESX_VI__TEMPLATE__CAST_FROM_ANY_TYPE(UserSession); - -/* esxVI_UserSession_Deserialize */ -ESX_VI__TEMPLATE__DESERIALIZE(UserSession, -{ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, key); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, userName); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, fullName); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(DateTime, loginTime); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(DateTime, lastActiveTime); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, locale); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, messageLocale); -}); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: VirtualMachineQuestionInfo - */ - -/* esxVI_VirtualMachineQuestionInfo_Alloc */ -ESX_VI__TEMPLATE__ALLOC(VirtualMachineQuestionInfo); - -/* esxVI_VirtualMachineQuestionInfo_Free */ -ESX_VI__TEMPLATE__FREE(VirtualMachineQuestionInfo, -{ - VIR_FREE(item->id); - VIR_FREE(item->text); - esxVI_ChoiceOption_Free(&item->choice); - /*esxVI_VirtualMachineMessage_Free(&item->message);*//* FIXME */ -}); - -/* esxVI_VirtualMachineQuestionInfo_Validate */ -ESX_VI__TEMPLATE__VALIDATE(VirtualMachineQuestionInfo, -{ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(id); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(text); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(choice); -}); - -/* esxVI_VirtualMachineQuestionInfo_CastFromAnyType */ -ESX_VI__TEMPLATE__CAST_FROM_ANY_TYPE(VirtualMachineQuestionInfo); - -/* esxVI_VirtualMachineQuestionInfo_Deserialize */ -ESX_VI__TEMPLATE__DESERIALIZE(VirtualMachineQuestionInfo, -{ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, id); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, text); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(ChoiceOption, choice); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_NOOP(message); /* FIXME */ -}); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: ElementDescription extends Description - * - * In contrast to SelectionSpec and TraversalSpec just merge - * Description into ElementDescription for simplicity, because - * only ElementDescription is used. - */ - -/* esxVI_ElementDescription_Alloc */ -ESX_VI__TEMPLATE__ALLOC(ElementDescription); - -/* esxVI_ElementDescription_Free */ -ESX_VI__TEMPLATE__FREE(ElementDescription, -{ - esxVI_ElementDescription_Free(&item->_next); - - VIR_FREE(item->label); - VIR_FREE(item->summary); - VIR_FREE(item->key); -}); - -/* esxVI_ElementDescription_Validate */ -ESX_VI__TEMPLATE__VALIDATE(ElementDescription, -{ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(label); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(summary); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(key); -}); - -/* esxVI_ElementDescription_AppendToList */ -ESX_VI__TEMPLATE__LIST__APPEND(ElementDescription); - -/* esxVI_ElementDescription_Deserialize */ -ESX_VI__TEMPLATE__DESERIALIZE(ElementDescription, -{ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, label); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, summary); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, key); -}); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: ChoiceOption extends OptionType - * - * In contrast to SelectionSpec and TraversalSpec just merge - * OptionType into ChoiceOption for simplicity, because - * only ChoiceOption is used. - */ - -/* esxVI_ChoiceOption_Alloc */ -ESX_VI__TEMPLATE__ALLOC(ChoiceOption); - -/* esxVI_ChoiceOption_Free */ -ESX_VI__TEMPLATE__FREE(ChoiceOption, -{ - esxVI_ElementDescription_Free(&item->choiceInfo); - esxVI_Int_Free(&item->defaultIndex); -}); - -/* esxVI_ChoiceOption_Validate */ -ESX_VI__TEMPLATE__VALIDATE(ChoiceOption, -{ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(choiceInfo); -}); - -/* esxVI_ChoiceOption_Deserialize */ -ESX_VI__TEMPLATE__DESERIALIZE(ChoiceOption, -{ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(Boolean, valueIsReadonly); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_LIST(ElementDescription, choiceInfo); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(Int, defaultIndex); -}); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: PerfMetricId - */ - -/* esxVI_PerfMetricId_Alloc */ -ESX_VI__TEMPLATE__ALLOC(PerfMetricId); - -/* esxVI_PerfMetricId_Free */ -ESX_VI__TEMPLATE__FREE(PerfMetricId, -{ - esxVI_PerfMetricId_Free(&item->_next); - - esxVI_Int_Free(&item->counterId); - VIR_FREE(item->instance); -}); - -/* esxVI_PerfMetricId_Validate */ -ESX_VI__TEMPLATE__VALIDATE(PerfMetricId, -{ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(counterId); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(instance); -}); - -/* esxVI_PerfMetricId_Serialize */ -ESX_VI__TEMPLATE__SERIALIZE(PerfMetricId, -{ - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE(Int, counterId); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE_VALUE(String, instance); -}); - -/* esxVI_PerfMetricId_SerializeList */ -ESX_VI__TEMPLATE__LIST__SERIALIZE(PerfMetricId); - -/* esxVI_PerfMetricId_Deserialize */ -ESX_VI__TEMPLATE__DESERIALIZE(PerfMetricId, -{ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(Int, counterId); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, instance); -}); - -/* esxVI_PerfMetricId_DeserializeList */ -ESX_VI__TEMPLATE__LIST__DESERIALIZE(PerfMetricId); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: PerfCounterInfo - */ - -/* esxVI_PerfCounterInfo_Alloc */ -ESX_VI__TEMPLATE__ALLOC(PerfCounterInfo); - -/* esxVI_PerfCounterInfo_Free */ -ESX_VI__TEMPLATE__FREE(PerfCounterInfo, -{ - esxVI_PerfCounterInfo_Free(&item->_next); - - esxVI_Int_Free(&item->key); - esxVI_ElementDescription_Free(&item->nameInfo); - esxVI_ElementDescription_Free(&item->groupInfo); - esxVI_ElementDescription_Free(&item->unitInfo); - esxVI_Int_Free(&item->level); - esxVI_Int_Free(&item->associatedCounterId); -}); - -/* esxVI_PerfCounterInfo_Validate */ -ESX_VI__TEMPLATE__VALIDATE(PerfCounterInfo, -{ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(key); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(nameInfo); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(groupInfo); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(unitInfo); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(rollupType); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(statsType); -}); - -/* esxVI_PerfCounterInfo_Deserialize */ -ESX_VI__TEMPLATE__DESERIALIZE(PerfCounterInfo, -{ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(Int, key); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(ElementDescription, nameInfo); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(ElementDescription, groupInfo); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(ElementDescription, unitInfo); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(PerfSummaryType, rollupType); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(PerfStatsType, statsType); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(Int, level); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_LIST(Int, associatedCounterId); -}); - -/* esxVI_PerfCounterInfo_DeserializeList */ -ESX_VI__TEMPLATE__LIST__DESERIALIZE(PerfCounterInfo); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: PerfQuerySpec - */ - -/* esxVI_PerfQuerySpec_Alloc */ -ESX_VI__TEMPLATE__ALLOC(PerfQuerySpec); - -/* esxVI_PerfQuerySpec_Free */ -ESX_VI__TEMPLATE__FREE(PerfQuerySpec, -{ - esxVI_PerfQuerySpec_Free(&item->_next); - - esxVI_ManagedObjectReference_Free(&item->entity); - esxVI_DateTime_Free(&item->startTime); - esxVI_DateTime_Free(&item->endTime); - esxVI_Int_Free(&item->maxSample); - esxVI_PerfMetricId_Free(&item->metricId); - esxVI_Int_Free(&item->intervalId); - VIR_FREE(item->format); -}); - -/* esxVI_PerfQuerySpec_Validate */ -ESX_VI__TEMPLATE__VALIDATE(PerfQuerySpec, -{ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(entity); -}); - -/* esxVI_PerfQuerySpec_Serialize */ -ESX_VI__TEMPLATE__SERIALIZE(PerfQuerySpec, -{ - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE(ManagedObjectReference, entity); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE(DateTime, startTime); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE(DateTime, endTime); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE(Int, maxSample); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE_LIST(PerfMetricId, metricId); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE(Int, intervalId); - ESX_VI__TEMPLATE__PROPERTY__SERIALIZE_VALUE(String, format); -}); - -/* esxVI_PerfQuerySpec_SerializeList */ -ESX_VI__TEMPLATE__LIST__SERIALIZE(PerfQuerySpec); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: PerfSampleInfo - */ - -/* esxVI_PerfSampleInfo_Alloc */ -ESX_VI__TEMPLATE__ALLOC(PerfSampleInfo); - -/* esxVI_PerfSampleInfo_Free */ -ESX_VI__TEMPLATE__FREE(PerfSampleInfo, -{ - esxVI_PerfSampleInfo_Free(&item->_next); - - esxVI_DateTime_Free(&item->timestamp); - esxVI_Int_Free(&item->interval); -}); - -/* esxVI_PerfSampleInfo_Validate */ -ESX_VI__TEMPLATE__VALIDATE(PerfSampleInfo, -{ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(timestamp); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(interval); -}); - -/* esxVI_PerfSampleInfo_AppendToList */ -ESX_VI__TEMPLATE__LIST__APPEND(PerfSampleInfo); - -/* esxVI_PerfSampleInfo_Deserialize */ -ESX_VI__TEMPLATE__DESERIALIZE(PerfSampleInfo, -{ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(DateTime, timestamp); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(Int, interval); -}); - -/* esxVI_PerfSampleInfo_DeserializeList */ -ESX_VI__TEMPLATE__LIST__DESERIALIZE(PerfSampleInfo); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: PerfMetricIntSeries extends PerfMetricSeries - * - * In contrast to SelectionSpec and TraversalSpec just merge - * PerfMetricSeries into PerfMetricIntSeries for simplicity, because - * only PerfMetricIntSeries is used and the other type inheriting - * PerfMetricSeries (PerfMetricSeriesCSV) is not used. - */ - -/* esxVI_PerfMetricIntSeries_Alloc */ -ESX_VI__TEMPLATE__ALLOC(PerfMetricIntSeries); - -/* esxVI_PerfMetricIntSeries_Free */ -ESX_VI__TEMPLATE__FREE(PerfMetricIntSeries, -{ - esxVI_PerfMetricIntSeries_Free(&item->_next); - - esxVI_PerfMetricId_Free(&item->id); - esxVI_Long_Free(&item->value); -}); - -/* esxVI_PerfMetricIntSeries_Validate */ -ESX_VI__TEMPLATE__VALIDATE(PerfMetricIntSeries, -{ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(id); -}); - -/* esxVI_PerfMetricIntSeries_AppendToList */ -ESX_VI__TEMPLATE__LIST__APPEND(PerfMetricIntSeries); - -/* esxVI_PerfMetricIntSeries_Deserialize */ -ESX_VI__TEMPLATE__DESERIALIZE(PerfMetricIntSeries, -{ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(PerfMetricId, id); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_LIST(Long, value); -}); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: PerfEntityMetric extends PerfEntityMetricBase - * - * In contrast to SelectionSpec and TraversalSpec just merge - * PerfEntityMetricBase into PerfEntityMetric for simplicity, because - * only PerfEntityMetric is used and the other type inheriting - * PerfEntityMetric (PerfEntityMetricCSV) is not used. - * - * Also use PerfMetricIntSeries instead of the correct base type - * PerfMetricSeries for the value property, because only - * PerfMetricIntSeries is used. - */ - -/* esxVI_PerfEntityMetric_Alloc */ -ESX_VI__TEMPLATE__ALLOC(PerfEntityMetric); - -/* esxVI_PerfEntityMetric_Free */ -ESX_VI__TEMPLATE__FREE(PerfEntityMetric, -{ - esxVI_PerfEntityMetric_Free(&item->_next); - - esxVI_ManagedObjectReference_Free(&item->entity); - esxVI_PerfSampleInfo_Free(&item->sampleInfo); - esxVI_PerfMetricIntSeries_Free(&item->value); -}); - -/* esxVI_PerfEntityMetric_Validate */ -ESX_VI__TEMPLATE__VALIDATE(PerfEntityMetric, -{ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(entity); -}); - -/* esxVI_PerfEntityMetric_Deserialize */ -ESX_VI__TEMPLATE__DESERIALIZE(PerfEntityMetric, -{ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - NULL, entity); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_LIST(PerfSampleInfo, sampleInfo); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_LIST(PerfMetricIntSeries, value); -}); - -/* esxVI_PerfEntityMetric_DeserializeList */ -ESX_VI__TEMPLATE__LIST__DESERIALIZE(PerfEntityMetric); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: TaskInfo - */ - -/* esxVI_TaskInfo_Alloc */ -ESX_VI__TEMPLATE__ALLOC(TaskInfo); - -/* esxVI_TaskInfo_Free */ -ESX_VI__TEMPLATE__FREE(TaskInfo, -{ - esxVI_TaskInfo_Free(&item->_next); - - VIR_FREE(item->key); - esxVI_ManagedObjectReference_Free(&item->task); - VIR_FREE(item->name); - VIR_FREE(item->descriptionId); - esxVI_ManagedObjectReference_Free(&item->entity); - VIR_FREE(item->entityName); - /*esxVI_ManagedObjectReference_Free(&item->locked);*//* FIXME */ - /*esxVI_MethodFault_Free(&item->error);*//* FIXME */ - esxVI_AnyType_Free(&item->result); - esxVI_Int_Free(&item->progress); - /*esxVI_TaskReason_Free(&item->reason);*//* FIXME */ - esxVI_DateTime_Free(&item->queueTime); - esxVI_DateTime_Free(&item->startTime); - esxVI_DateTime_Free(&item->completeTime); - esxVI_Int_Free(&item->eventChainId); -}); - -/* esxVI_TaskInfo_Validate */ -ESX_VI__TEMPLATE__VALIDATE(TaskInfo, -{ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(key); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(task); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(descriptionId); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(state); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(cancelled); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(cancelable); - /*ESX_VI__TEMPLATE__PROPERTY__REQUIRE(reason);*//* FIXME */ - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(queueTime); - ESX_VI__TEMPLATE__PROPERTY__REQUIRE(eventChainId); -}); - -/* esxVI_TaskInfo_CastFromAnyType */ -ESX_VI__TEMPLATE__CAST_FROM_ANY_TYPE(TaskInfo); - -/* esxVI_TaskInfo_AppendToList */ -ESX_VI__TEMPLATE__LIST__APPEND(TaskInfo); - -/* esxVI_TaskInfo_Deserialize */ -ESX_VI__TEMPLATE__DESERIALIZE(TaskInfo, -{ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, key); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - "Task", task); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, name); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, descriptionId); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_EXPECTED(ManagedObjectReference, - NULL, entity); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, entityName); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_NOOP(locked); /* FIXME */ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(TaskInfoState, state); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(Boolean, cancelled); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(Boolean, cancelable); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_NOOP(error); /* FIXME */ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(AnyType, result); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(Int, progress); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_NOOP(reason); /* FIXME */ - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(DateTime, queueTime); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(DateTime, startTime); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(DateTime, completeTime); - ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE(Int, eventChainId); -}); +#include "esx_vi_types.generated.c" diff --git a/src/esx/esx_vi_types.h b/src/esx/esx_vi_types.h index e5451e9..a61cdc1 100644 --- a/src/esx/esx_vi_types.h +++ b/src/esx/esx_vi_types.h @@ -25,13 +25,8 @@ # include "buf.h" - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * XSI - */ - typedef enum _esxVI_Type esxVI_Type; +typedef struct _esxVI_Object esxVI_Object; @@ -49,75 +44,50 @@ typedef struct _esxVI_DateTime esxVI_DateTime; /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Enums - */ - -typedef enum _esxVI_ManagedEntityStatus esxVI_ManagedEntityStatus; -typedef enum _esxVI_ObjectUpdateKind esxVI_ObjectUpdateKind; -typedef enum _esxVI_PerfSummaryType esxVI_PerfSummaryType; -typedef enum _esxVI_PerfStatsType esxVI_PerfStatsType; -typedef enum _esxVI_PropertyChangeOp esxVI_PropertyChangeOp; -typedef enum _esxVI_SharesLevel esxVI_SharesLevel; -typedef enum _esxVI_TaskInfoState esxVI_TaskInfoState; -typedef enum _esxVI_VirtualMachineMovePriority esxVI_VirtualMachineMovePriority; -typedef enum _esxVI_VirtualMachinePowerState esxVI_VirtualMachinePowerState; - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * VI Types */ typedef struct _esxVI_Fault esxVI_Fault; typedef struct _esxVI_ManagedObjectReference esxVI_ManagedObjectReference; -typedef struct _esxVI_DynamicProperty esxVI_DynamicProperty; -typedef struct _esxVI_HostCpuIdInfo esxVI_HostCpuIdInfo; -typedef struct _esxVI_SelectionSpec esxVI_SelectionSpec; -typedef struct _esxVI_TraversalSpec esxVI_TraversalSpec; -typedef struct _esxVI_ObjectSpec esxVI_ObjectSpec; -typedef struct _esxVI_PropertyChange esxVI_PropertyChange; -typedef struct _esxVI_PropertySpec esxVI_PropertySpec; -typedef struct _esxVI_PropertyFilterSpec esxVI_PropertyFilterSpec; -typedef struct _esxVI_ObjectContent esxVI_ObjectContent; -typedef struct _esxVI_ObjectUpdate esxVI_ObjectUpdate; -typedef struct _esxVI_PropertyFilterUpdate esxVI_PropertyFilterUpdate; -typedef struct _esxVI_AboutInfo esxVI_AboutInfo; -typedef struct _esxVI_ServiceContent esxVI_ServiceContent; -typedef struct _esxVI_UpdateSet esxVI_UpdateSet; -typedef struct _esxVI_SharesInfo esxVI_SharesInfo; -typedef struct _esxVI_ResourceAllocationInfo esxVI_ResourceAllocationInfo; -typedef struct _esxVI_ResourcePoolResourceUsage esxVI_ResourcePoolResourceUsage; -typedef struct _esxVI_VirtualMachineConfigSpec esxVI_VirtualMachineConfigSpec; -typedef struct _esxVI_Event esxVI_Event; -typedef struct _esxVI_UserSession esxVI_UserSession; -typedef struct _esxVI_VirtualMachineQuestionInfo esxVI_VirtualMachineQuestionInfo; -typedef struct _esxVI_ElementDescription esxVI_ElementDescription; -typedef struct _esxVI_ChoiceOption esxVI_ChoiceOption; -typedef struct _esxVI_PerfMetricId esxVI_PerfMetricId; -typedef struct _esxVI_PerfCounterInfo esxVI_PerfCounterInfo; -typedef struct _esxVI_PerfQuerySpec esxVI_PerfQuerySpec; -typedef struct _esxVI_PerfSampleInfo esxVI_PerfSampleInfo; -typedef struct _esxVI_PerfMetricIntSeries esxVI_PerfMetricIntSeries; -typedef struct _esxVI_PerfEntityMetric esxVI_PerfEntityMetric; -typedef struct _esxVI_TaskInfo esxVI_TaskInfo; + +#include "esx_vi_types.generated.typedef" /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * XSI: Type + * Type */ enum _esxVI_Type { esxVI_Type_Undefined = 0, esxVI_Type_Boolean, + esxVI_Type_AnyType, esxVI_Type_String, esxVI_Type_Short, esxVI_Type_Int, esxVI_Type_Long, + esxVI_Type_DateTime, + esxVI_Type_Fault, + esxVI_Type_ManagedObjectReference, + +#include "esx_vi_types.generated.typeenum" + esxVI_Type_Other, }; -const char *esxVI_Type_Name(esxVI_Type type); +const char *esxVI_Type_ToString(esxVI_Type type); +esxVI_Type esxVI_Type_FromString(const char *type); + + + +/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * + * Object extends List + */ + +struct _esxVI_Object { + esxVI_Object *_next; /* optional */ + esxVI_Type _type; /* required */ +}; @@ -142,8 +112,10 @@ int esxVI_Boolean_Deserialize(xmlNodePtr node, esxVI_Boolean *boolean_); */ struct _esxVI_AnyType { - xmlNodePtr _node; /* required */ + esxVI_AnyType *_unused; /* optional */ + esxVI_Type _type; /* = esxVI_Type_AnyType */ /* required */ + xmlNodePtr node; /* required */ esxVI_Type type; /* required */ char *other; /* required */ char *value; /* required */ @@ -170,12 +142,14 @@ int esxVI_AnyType_Deserialize(xmlNodePtr node, esxVI_AnyType **anyType); struct _esxVI_String { esxVI_String *_next; /* optional */ + esxVI_Type _type; /* required */ char *value; /* required */ }; int esxVI_String_Alloc(esxVI_String **string); void esxVI_String_Free(esxVI_String **stringList); +int esxVI_String_Validate(esxVI_String *string); int esxVI_String_AppendToList(esxVI_String **stringList, esxVI_String *string); int esxVI_String_AppendValueToList(esxVI_String **stringList, const char *value); @@ -202,6 +176,7 @@ int esxVI_String_DeserializeValue(xmlNodePtr node, char **value); struct _esxVI_Int { esxVI_Int *_next; /* optional */ + esxVI_Type _type; /* required */ int32_t value; /* required */ }; @@ -225,6 +200,7 @@ int esxVI_Int_Deserialize(xmlNodePtr node, esxVI_Int **number); struct _esxVI_Long { esxVI_Long *_next; /* optional */ + esxVI_Type _type; /* required */ int64_t value; /* required */ }; @@ -246,6 +222,9 @@ int esxVI_Long_Deserialize(xmlNodePtr node, esxVI_Long **number); */ struct _esxVI_DateTime { + esxVI_DateTime *_unused; /* optional */ + esxVI_Type _type; /* required */ + char *value; /* required */ }; @@ -259,170 +238,13 @@ int esxVI_DateTime_Deserialize(xmlNodePtr node, esxVI_DateTime **dateTime); /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Enum: ManagedEntityStatus - */ - -enum _esxVI_ManagedEntityStatus { - esxVI_ManagedEntityStatus_Undefined = 0, - esxVI_ManagedEntityStatus_Gray, - esxVI_ManagedEntityStatus_Green, - esxVI_ManagedEntityStatus_Yellow, - esxVI_ManagedEntityStatus_Red, -}; - -int esxVI_ManagedEntityStatus_CastFromAnyType - (esxVI_AnyType *anyType, esxVI_ManagedEntityStatus *managedEntityStatus); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Enum: ObjectUpdateKind - */ - -enum _esxVI_ObjectUpdateKind { - esxVI_ObjectUpdateKind_Undefined = 0, - esxVI_ObjectUpdateKind_Enter, - esxVI_ObjectUpdateKind_Leave, - esxVI_ObjectUpdateKind_Modify, -}; - -int esxVI_ObjectUpdateKind_Deserialize - (xmlNodePtr node, esxVI_ObjectUpdateKind *objectUpdateKind); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Enum: PerfSummaryType - */ - -enum _esxVI_PerfSummaryType { - esxVI_PerfSummaryType_Undefined = 0, - esxVI_PerfSummaryType_Average, - esxVI_PerfSummaryType_Latest, - esxVI_PerfSummaryType_Maximum, - esxVI_PerfSummaryType_Minimum, - esxVI_PerfSummaryType_None, - esxVI_PerfSummaryType_Summation, -}; - -int esxVI_PerfSummaryType_Deserialize(xmlNodePtr node, - esxVI_PerfSummaryType *perfSummaryType); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Enum: PerfStatsType - */ - -enum _esxVI_PerfStatsType { - esxVI_PerfStatsType_Undefined = 0, - esxVI_PerfStatsType_Absolute, - esxVI_PerfStatsType_Delta, - esxVI_PerfStatsType_Rate, -}; - -int esxVI_PerfStatsType_Deserialize(xmlNodePtr node, - esxVI_PerfStatsType *perfStatsType); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Enum: PropertyChangeOp - */ - -enum _esxVI_PropertyChangeOp { - esxVI_PropertyChangeOp_Undefined = 0, - esxVI_PropertyChangeOp_Add, - esxVI_PropertyChangeOp_Remove, - esxVI_PropertyChangeOp_Assign, - esxVI_PropertyChangeOp_IndirectRemove, -}; - -int esxVI_PropertyChangeOp_Deserialize - (xmlNodePtr node, esxVI_PropertyChangeOp *propertyChangeOp); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Enum: SharesLevel - */ - -enum _esxVI_SharesLevel { - esxVI_SharesLevel_Undefined = 0, - esxVI_SharesLevel_Custom, - esxVI_SharesLevel_High, - esxVI_SharesLevel_Low, - esxVI_SharesLevel_Normal, -}; - -int esxVI_SharesLevel_Serialize(esxVI_SharesLevel sharesLevel, - const char *element, virBufferPtr output); -int esxVI_SharesLevel_Deserialize(xmlNodePtr node, - esxVI_SharesLevel *sharesLevel); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Enum: TaskInfoState - */ - -enum _esxVI_TaskInfoState { - esxVI_TaskInfoState_Undefined = 0, - esxVI_TaskInfoState_Error, - esxVI_TaskInfoState_Queued, - esxVI_TaskInfoState_Running, - esxVI_TaskInfoState_Success, -}; - -int esxVI_TaskInfoState_CastFromAnyType(esxVI_AnyType *anyType, - esxVI_TaskInfoState *taskInfoState); -int esxVI_TaskInfoState_Deserialize(xmlNodePtr node, - esxVI_TaskInfoState *taskInfoState); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Enum: VirtualMachineMovePriority - */ - -enum _esxVI_VirtualMachineMovePriority { - esxVI_VirtualMachineMovePriority_Undefined = 0, - esxVI_VirtualMachineMovePriority_LowPriority, - esxVI_VirtualMachineMovePriority_HighPriority, - esxVI_VirtualMachineMovePriority_DefaultPriority, -}; - -int esxVI_VirtualMachineMovePriority_Serialize - (esxVI_VirtualMachineMovePriority virtualMachineMovePriority, - const char *element, virBufferPtr output); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Enum: VirtualMachinePowerState - */ - -enum _esxVI_VirtualMachinePowerState { - esxVI_VirtualMachinePowerState_Undefined = 0, - esxVI_VirtualMachinePowerState_PoweredOff, - esxVI_VirtualMachinePowerState_PoweredOn, - esxVI_VirtualMachinePowerState_Suspended, -}; - -int esxVI_VirtualMachinePowerState_CastFromAnyType - (esxVI_AnyType *anyType, - esxVI_VirtualMachinePowerState *virtualMachinePowerState); -int esxVI_VirtualMachinePowerState_Serialize - (esxVI_VirtualMachinePowerState virtualMachinePowerState, - const char *element, virBufferPtr output); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * VI Type: Fault */ struct _esxVI_Fault { + esxVI_Fault *_unused; /* optional */ + esxVI_Type _type; /* required */ + char *faultcode; /* required */ char *faultstring; /* required */ }; @@ -440,6 +262,7 @@ int esxVI_Fault_Deserialize(xmlNodePtr node, esxVI_Fault **fault); struct _esxVI_ManagedObjectReference { esxVI_ManagedObjectReference *_next; /* optional */ + esxVI_Type _type; /* required */ char *type; /* required */ char *value; /* required */ @@ -454,14 +277,12 @@ int esxVI_ManagedObjectReference_DeepCopy(esxVI_ManagedObjectReference **dest, int esxVI_ManagedObjectReference_AppendToList (esxVI_ManagedObjectReference **managedObjectReferenceList, esxVI_ManagedObjectReference *managedObjectReference); -int esxVI_ManagedObjectReference_CastFromAnyType(esxVI_AnyType *anyType, - esxVI_ManagedObjectReference - **managedObjectReference, - const char *expectedType); +int esxVI_ManagedObjectReference_CastFromAnyType + (esxVI_AnyType *anyType, + esxVI_ManagedObjectReference **managedObjectReference); int esxVI_ManagedObjectReference_CastListFromAnyType (esxVI_AnyType *anyType, - esxVI_ManagedObjectReference **managedObjectReferenceList, - const char *expectedType); + esxVI_ManagedObjectReference **managedObjectReferenceList); int esxVI_ManagedObjectReference_Serialize (esxVI_ManagedObjectReference *managedObjectReference, const char *element, virBufferPtr output); @@ -469,833 +290,10 @@ int esxVI_ManagedObjectReference_SerializeList (esxVI_ManagedObjectReference *managedObjectReference, const char *element, virBufferPtr output); int esxVI_ManagedObjectReference_Deserialize - (xmlNodePtr node, esxVI_ManagedObjectReference **managedObjectReference, - const char *expectedType); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: DynamicProperty - */ - -struct _esxVI_DynamicProperty { - esxVI_DynamicProperty *_next; /* optional */ - - char *name; /* required */ - esxVI_AnyType *val; /* required */ -}; - -int esxVI_DynamicProperty_Alloc(esxVI_DynamicProperty **dynamicProperty); -void esxVI_DynamicProperty_Free - (esxVI_DynamicProperty **dynamicPropertyList); -int esxVI_DynamicProperty_Validate(esxVI_DynamicProperty *dynamicProperty); -int esxVI_DynamicProperty_DeepCopy(esxVI_DynamicProperty **dest, - esxVI_DynamicProperty *src); -int esxVI_DynamicProperty_DeepCopyList(esxVI_DynamicProperty **destList, - esxVI_DynamicProperty *srcList); -int esxVI_DynamicProperty_AppendToList - (esxVI_DynamicProperty **dynamicPropertyList, - esxVI_DynamicProperty *dynamicProperty); -int esxVI_DynamicProperty_Deserialize(xmlNodePtr node, - esxVI_DynamicProperty **dynamicProperty); -int esxVI_DynamicProperty_DeserializeList - (xmlNodePtr node, esxVI_DynamicProperty **dynamicPropertyList); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: HostCpuIdInfo - */ - -struct _esxVI_HostCpuIdInfo { - esxVI_HostCpuIdInfo *_next; /* optional */ - - esxVI_Int *level; /* required */ - char *vendor; /* optional */ - char *eax; /* optional */ - char *ebx; /* optional */ - char *ecx; /* optional */ - char *edx; /* optional */ -}; - -int esxVI_HostCpuIdInfo_Alloc(esxVI_HostCpuIdInfo **hostCpuIdInfo); -void esxVI_HostCpuIdInfo_Free(esxVI_HostCpuIdInfo **hostCpuIdInfoList); -int esxVI_HostCpuIdInfo_Validate(esxVI_HostCpuIdInfo *hostCpuIdInfo); -int esxVI_HostCpuIdInfo_CastFromAnyType(esxVI_AnyType *anyType, - esxVI_HostCpuIdInfo **hostCpuIdInfo); -int esxVI_HostCpuIdInfo_CastListFromAnyType - (esxVI_AnyType *anyType, esxVI_HostCpuIdInfo **hostCpuIdInfoList); -int esxVI_HostCpuIdInfo_Deserialize(xmlNodePtr node, - esxVI_HostCpuIdInfo **hostCpuIdInfo); -int esxVI_HostCpuIdInfo_DeserializeList - (xmlNodePtr node, esxVI_HostCpuIdInfo **hostCpuIdInfoList); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: SelectionSpec - */ - -struct _esxVI_SelectionSpec { - esxVI_SelectionSpec *_next; /* optional */ - esxVI_TraversalSpec *_super; /* optional */ - - char *name; /* optional */ -}; - -int esxVI_SelectionSpec_Alloc(esxVI_SelectionSpec **selectionSpec); -void esxVI_SelectionSpec_Free(esxVI_SelectionSpec **selectionSpecList); -int esxVI_SelectionSpec_Validate(esxVI_SelectionSpec *selectionSpec); -int esxVI_SelectionSpec_AppendToList(esxVI_SelectionSpec **selectionSpecList, - esxVI_SelectionSpec *selectionSpec); -int esxVI_SelectionSpec_Serialize(esxVI_SelectionSpec *selectionSpec, - const char *element, virBufferPtr output); -int esxVI_SelectionSpec_SerializeList(esxVI_SelectionSpec *selectionSpecList, - const char *element, virBufferPtr output); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: TraversalSpec extends SelectionSpec - */ - -struct _esxVI_TraversalSpec { - esxVI_SelectionSpec *_base; /* required */ - - char *type; /* required */ - char *path; /* required */ - esxVI_Boolean skip; /* optional */ - esxVI_SelectionSpec *selectSet; /* optional, list */ -}; - -int esxVI_TraversalSpec_Alloc(esxVI_TraversalSpec **traversalSpec); -void esxVI_TraversalSpec_Free(esxVI_TraversalSpec **traversalSpec); -int esxVI_TraversalSpec_Validate(esxVI_TraversalSpec *traversalSpec); -int esxVI_TraversalSpec_Serialize(esxVI_TraversalSpec *traversalSpec, - const char *element, virBufferPtr output); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: ObjectSpec - */ - -struct _esxVI_ObjectSpec { - esxVI_ObjectSpec *_next; /* optional */ - - esxVI_ManagedObjectReference *obj; /* required */ - esxVI_Boolean skip; /* optional */ - esxVI_SelectionSpec *selectSet; /* optional, list */ -}; - -int esxVI_ObjectSpec_Alloc(esxVI_ObjectSpec **objectSpec); -void esxVI_ObjectSpec_Free(esxVI_ObjectSpec **objectSpecList); -int esxVI_ObjectSpec_Validate(esxVI_ObjectSpec *objectSpec); -int esxVI_ObjectSpec_AppendToList(esxVI_ObjectSpec **objectSpecList, - esxVI_ObjectSpec *objectSpec); -int esxVI_ObjectSpec_Serialize(esxVI_ObjectSpec *objectSpec, - const char *element, virBufferPtr output); -int esxVI_ObjectSpec_SerializeList(esxVI_ObjectSpec *objectSpecList, - const char *element, virBufferPtr output); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: PropertyChange - */ - -struct _esxVI_PropertyChange { - esxVI_PropertyChange *_next; /* optional */ - - char *name; /* required */ - esxVI_PropertyChangeOp op; /* required */ - esxVI_AnyType *val; /* optional */ -}; - -int esxVI_PropertyChange_Alloc(esxVI_PropertyChange **propertyChange); -void esxVI_PropertyChange_Free(esxVI_PropertyChange **propertyChangeList); -int esxVI_PropertyChange_Validate(esxVI_PropertyChange *propertyChange); -int esxVI_PropertyChange_AppendToList - (esxVI_PropertyChange **propertyChangeList, - esxVI_PropertyChange *propertyChange); -int esxVI_PropertyChange_Deserialize(xmlNodePtr node, - esxVI_PropertyChange **propertyChange); -int esxVI_PropertyChange_DeserializeList - (xmlNodePtr node, esxVI_PropertyChange **propertyChangeList); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: PropertySpec - */ - -struct _esxVI_PropertySpec { - esxVI_PropertySpec *_next; /* optional */ - - char *type; /* required */ - esxVI_Boolean all; /* optional */ - esxVI_String *pathSet; /* optional, list */ -}; - -int esxVI_PropertySpec_Alloc(esxVI_PropertySpec **propertySpec); -void esxVI_PropertySpec_Free(esxVI_PropertySpec **propertySpecList); -int esxVI_PropertySpec_Validate(esxVI_PropertySpec *propertySpec); -int esxVI_PropertySpec_AppendToList(esxVI_PropertySpec **propertySpecList, - esxVI_PropertySpec *propertySpec); -int esxVI_PropertySpec_Serialize(esxVI_PropertySpec *propertySpec, - const char *element, virBufferPtr output); -int esxVI_PropertySpec_SerializeList(esxVI_PropertySpec *propertySpecList, - const char *element, virBufferPtr output); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: PropertyFilterSpec - */ - -struct _esxVI_PropertyFilterSpec { - esxVI_PropertyFilterSpec *_next; /* optional */ - - esxVI_PropertySpec *propSet; /* required, list */ - esxVI_ObjectSpec *objectSet; /* required, list */ -}; - -int esxVI_PropertyFilterSpec_Alloc - (esxVI_PropertyFilterSpec **propertyFilterSpec); -void esxVI_PropertyFilterSpec_Free - (esxVI_PropertyFilterSpec **propertyFilterSpecList); -int esxVI_PropertyFilterSpec_Validate - (esxVI_PropertyFilterSpec *propertyFilterSpec); -int esxVI_PropertyFilterSpec_AppendToList - (esxVI_PropertyFilterSpec **propertyFilterSpecList, - esxVI_PropertyFilterSpec *propertyFilterSpec); -int esxVI_PropertyFilterSpec_Serialize - (esxVI_PropertyFilterSpec *propertyFilterSpec, const char *element, - virBufferPtr output); -int esxVI_PropertyFilterSpec_SerializeList - (esxVI_PropertyFilterSpec *propertyFilterSpecList, const char *element, - virBufferPtr output); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: ObjectContent - */ - -struct _esxVI_ObjectContent { - esxVI_ObjectContent *_next; /* optional */ - - esxVI_ManagedObjectReference *obj; /* required */ - esxVI_DynamicProperty *propSet; /* optional, list */ - /*esxVI_MissingProperty *missingSet; *//* optional, list *//* FIXME */ -}; - -int esxVI_ObjectContent_Alloc(esxVI_ObjectContent **objectContent); -void esxVI_ObjectContent_Free(esxVI_ObjectContent **objectContentList); -int esxVI_ObjectContent_Validate(esxVI_ObjectContent *objectContent); -int esxVI_ObjectContent_AppendToList(esxVI_ObjectContent **objectContentList, - esxVI_ObjectContent *objectContent); -int esxVI_ObjectContent_DeepCopy(esxVI_ObjectContent **dest, - esxVI_ObjectContent *src); -int esxVI_ObjectContent_Deserialize(xmlNodePtr node, - esxVI_ObjectContent **objectContent); -int esxVI_ObjectContent_DeserializeList - (xmlNodePtr node, esxVI_ObjectContent **objectContentList); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: ObjectUpdate - */ - -struct _esxVI_ObjectUpdate { - esxVI_ObjectUpdate *_next; /* optional */ - - esxVI_ObjectUpdateKind kind; /* required */ - esxVI_ManagedObjectReference *obj; /* required */ - esxVI_PropertyChange *changeSet; /* optional, list */ - /*esxVI_MissingProperty *missingSet; *//* optional, list *//* FIXME */ -}; - -int esxVI_ObjectUpdate_Alloc(esxVI_ObjectUpdate **objectUpdate); -void esxVI_ObjectUpdate_Free(esxVI_ObjectUpdate **objectUpdateList); -int esxVI_ObjectUpdate_Validate(esxVI_ObjectUpdate *objectUpdate); -int esxVI_ObjectUpdate_AppendToList(esxVI_ObjectUpdate **objectUpdateList, - esxVI_ObjectUpdate *objectUpdate); -int esxVI_ObjectUpdate_Deserialize(xmlNodePtr node, - esxVI_ObjectUpdate **objectUpdate); -int esxVI_ObjectUpdate_DeserializeList(xmlNodePtr node, - esxVI_ObjectUpdate **objectUpdateList); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: PropertyFilterUpdate - */ - -struct _esxVI_PropertyFilterUpdate { - esxVI_PropertyFilterUpdate *_next; /* optional */ - - esxVI_ManagedObjectReference *filter; /* required */ - esxVI_ObjectUpdate *objectSet; /* optional, list */ - /*esxVI_MissingProperty *missingSet; *//* optional, list *//* FIXME */ -}; - -int esxVI_PropertyFilterUpdate_Alloc - (esxVI_PropertyFilterUpdate **propertyFilterUpdate); -void esxVI_PropertyFilterUpdate_Free - (esxVI_PropertyFilterUpdate **propertyFilterUpdateList); -int esxVI_PropertyFilterUpdate_Validate - (esxVI_PropertyFilterUpdate *propertyFilterUpdate); -int esxVI_PropertyFilterUpdate_AppendToList - (esxVI_PropertyFilterUpdate **propertyFilterUpdateList, - esxVI_PropertyFilterUpdate *propertyFilterUpdate); -int esxVI_PropertyFilterUpdate_Deserialize - (xmlNodePtr node, esxVI_PropertyFilterUpdate **propertyFilterUpdate); -int esxVI_PropertyFilterUpdate_DeserializeList - (xmlNodePtr node, esxVI_PropertyFilterUpdate **propertyFilterUpdateList); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: AboutInfo - */ - -struct _esxVI_AboutInfo { - char *name; /* required */ - char *fullName; /* required */ - char *vendor; /* required */ - char *version; /* required */ - char *build; /* required */ - char *localeVersion; /* optional */ - char *localeBuild; /* optional */ - char *osType; /* required */ - char *productLineId; /* required */ - char *apiType; /* required */ - char *apiVersion; /* required */ -}; - -int esxVI_AboutInfo_Alloc(esxVI_AboutInfo **aboutInfo); -void esxVI_AboutInfo_Free(esxVI_AboutInfo **aboutInfo); -int esxVI_AboutInfo_Validate(esxVI_AboutInfo *aboutInfo); -int esxVI_AboutInfo_Deserialize(xmlNodePtr node, esxVI_AboutInfo **aboutInfo); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: ServiceContent - */ - -struct _esxVI_ServiceContent { - esxVI_ManagedObjectReference *rootFolder; /* required */ - esxVI_ManagedObjectReference *propertyCollector; /* required */ - esxVI_ManagedObjectReference *viewManager; /* optional */ - esxVI_AboutInfo *about; /* required */ - esxVI_ManagedObjectReference *setting; /* optional */ - esxVI_ManagedObjectReference *userDirectory; /* optional */ - esxVI_ManagedObjectReference *sessionManager; /* optional */ - esxVI_ManagedObjectReference *authorizationManager; /* optional */ - esxVI_ManagedObjectReference *perfManager; /* optional */ - esxVI_ManagedObjectReference *scheduledTaskManager; /* optional */ - esxVI_ManagedObjectReference *alarmManager; /* optional */ - esxVI_ManagedObjectReference *eventManager; /* optional */ - esxVI_ManagedObjectReference *taskManager; /* optional */ - esxVI_ManagedObjectReference *extensionManager; /* optional */ - esxVI_ManagedObjectReference *customizationSpecManager; /* optional */ - esxVI_ManagedObjectReference *customFieldsManager; /* optional */ - esxVI_ManagedObjectReference *accountManager; /* optional */ - esxVI_ManagedObjectReference *diagnosticManager; /* optional */ - esxVI_ManagedObjectReference *licenseManager; /* optional */ - esxVI_ManagedObjectReference *searchIndex; /* optional */ - esxVI_ManagedObjectReference *fileManager; /* optional */ - esxVI_ManagedObjectReference *virtualDiskManager; /* optional */ - esxVI_ManagedObjectReference *virtualizationManager; /* optional */ -}; - -int esxVI_ServiceContent_Alloc(esxVI_ServiceContent **serviceContent); -void esxVI_ServiceContent_Free(esxVI_ServiceContent **serviceContent); -int esxVI_ServiceContent_Validate(esxVI_ServiceContent *serviceContent); -int esxVI_ServiceContent_Deserialize(xmlNodePtr node, - esxVI_ServiceContent **serviceContent); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: UpdateSet - */ - -struct _esxVI_UpdateSet { - char *version; /* required */ - esxVI_PropertyFilterUpdate *filterSet; /* optional, list */ -}; - -int esxVI_UpdateSet_Alloc(esxVI_UpdateSet **updateSet); -void esxVI_UpdateSet_Free(esxVI_UpdateSet **updateSet); -int esxVI_UpdateSet_Validate(esxVI_UpdateSet *updateSet); -int esxVI_UpdateSet_Deserialize(xmlNodePtr node, esxVI_UpdateSet **updateSet); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: SharesInfo - */ - -struct _esxVI_SharesInfo { - esxVI_Int *shares; /* required */ - esxVI_SharesLevel level; /* required */ -}; - -int esxVI_SharesInfo_Alloc(esxVI_SharesInfo **sharesInfo); -void esxVI_SharesInfo_Free(esxVI_SharesInfo **sharesInfo); -int esxVI_SharesInfo_Validate(esxVI_SharesInfo *sharesInfo); -int esxVI_SharesInfo_CastFromAnyType(esxVI_AnyType *anyType, - esxVI_SharesInfo **sharesInfo); -int esxVI_SharesInfo_Deserialize(xmlNodePtr node, - esxVI_SharesInfo **sharesInfo); -int esxVI_SharesInfo_Serialize(esxVI_SharesInfo *sharesInfo, - const char *element, virBufferPtr output); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: ResourceAllocationInfo - */ - -struct _esxVI_ResourceAllocationInfo { - esxVI_Long *reservation; /* optional */ - esxVI_Boolean expandableReservation; /* optional */ - esxVI_Long *limit; /* optional */ - esxVI_SharesInfo *shares; /* optional */ - esxVI_Long *overheadLimit; /* optional */ -}; - -int esxVI_ResourceAllocationInfo_Alloc - (esxVI_ResourceAllocationInfo **resourceAllocationInfo); -void esxVI_ResourceAllocationInfo_Free - (esxVI_ResourceAllocationInfo **resourceAllocationInfo); -int esxVI_ResourceAllocationInfo_Validate - (esxVI_ResourceAllocationInfo *resourceAllocationInfo); -int esxVI_ResourceAllocationInfo_Serialize - (esxVI_ResourceAllocationInfo *resourceAllocationInfo, - const char *element, virBufferPtr output); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: ResourcePoolResourceUsage - */ - -struct _esxVI_ResourcePoolResourceUsage { - esxVI_Long *reservationUsed; /* required */ - esxVI_Long *reservationUsedForVm; /* required */ - esxVI_Long *unreservedForPool; /* required */ - esxVI_Long *unreservedForVm; /* required */ - esxVI_Long *overallUsage; /* required */ - esxVI_Long *maxUsage; /* required */ -}; - -int esxVI_ResourcePoolResourceUsage_Alloc - (esxVI_ResourcePoolResourceUsage **resourcePoolResourceUsage); -void esxVI_ResourcePoolResourceUsage_Free - (esxVI_ResourcePoolResourceUsage **resourcePoolResourceUsage); -int esxVI_ResourcePoolResourceUsage_Validate - (esxVI_ResourcePoolResourceUsage *resourcePoolResourceUsage); -int esxVI_ResourcePoolResourceUsage_CastFromAnyType - (esxVI_AnyType *anyType, - esxVI_ResourcePoolResourceUsage **resourcePoolResourceUsage); -int esxVI_ResourcePoolResourceUsage_Deserialize - (xmlNodePtr node, - esxVI_ResourcePoolResourceUsage **resourcePoolResourceUsage); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: VirtualMachineConfigSpec - */ - -/* FIXME: implement the rest */ -struct _esxVI_VirtualMachineConfigSpec { - char *changeVersion; /* optional */ - char *name; /* optional */ - char *version; /* optional */ - char *uuid; /* optional */ - esxVI_Long *npivNodeWorldWideName; /* optional, list */ - esxVI_Long *npivPortWorldWideName; /* optional, list */ - char *npivWorldWideNameType; /* optional */ - char *npivWorldWideNameOp; /* optional */ - char *locationId; /* optional */ - char *guestId; /* optional */ - char *alternateGuestName; /* optional */ - char *annotation; /* optional */ - //esxVI_VirtualMachineFileInfo *files; /* optional */ - //esxVI_ToolsConfigInfo *tools; /* optional */ - //esxVI_VirtualMachineFlagInfo *flags; /* optional */ - //esxVI_VirtualMachineConsolePreferences *consolePreferences; /* optional */ - //esxVI_VirtualMachineDefaultPowerOpInfo *powerOpInfo; /* optional */ - esxVI_Int *numCPUs; /* optional */ - esxVI_Long *memoryMB; /* optional */ - //esxVI_VirtualDeviceConfigSpec *deviceChange; /* optional, list */ - esxVI_ResourceAllocationInfo *cpuAllocation; /* optional */ - esxVI_ResourceAllocationInfo *memoryAllocation; /* optional */ - //esxVI_VirtualMachineAffinityInfo *cpuAffinity; /* optional */ - //esxVI_VirtualMachineAffinityInfo *memoryAffinity; /* optional */ - //esxVI_VirtualMachineNetworkShaperInfo *networkShaper; /* optional */ - //esxVI_VirtualMachineCpuIdInfoSpec *cpuFeatureMask; /* optional, list */ - //esxVI_OptionValue *extraConfig; /* optional, list */ - char *swapPlacement; /* optional */ - //esxVI_VirtualMachineBootOptions *bootOptions; /* optional */ -}; - -int esxVI_VirtualMachineConfigSpec_Alloc - (esxVI_VirtualMachineConfigSpec **virtualMachineConfigSpec); -void esxVI_VirtualMachineConfigSpec_Free - (esxVI_VirtualMachineConfigSpec **virtualMachineConfigSpec); -int esxVI_VirtualMachineConfigSpec_Validate - (esxVI_VirtualMachineConfigSpec *virtualMachineConfigSpec); -int esxVI_VirtualMachineConfigSpec_Serialize - (esxVI_VirtualMachineConfigSpec *virtualMachineConfigSpec, - const char *element, virBufferPtr output); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: Event - */ - -/* FIXME: implement the rest */ -struct _esxVI_Event { - esxVI_Event *_next; /* optional */ - - esxVI_Int *key; /* required */ - esxVI_Int *chainId; /* required */ - esxVI_DateTime *createdTime; /* required */ - char *userName; /* required */ - //??? datacenter; /* optional */ - //??? computeResource; /* optional */ - //??? host; /* optional */ - //??? vm; /* optional */ - char *fullFormattedMessage; /* optional */ -}; - -int esxVI_Event_Alloc(esxVI_Event **event); -void esxVI_Event_Free(esxVI_Event **eventList); -int esxVI_Event_Validate(esxVI_Event *event); -int esxVI_Event_Deserialize(xmlNodePtr node, esxVI_Event **event); -int esxVI_Event_DeserializeList(xmlNodePtr node, esxVI_Event **eventList); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: UserSession - */ - -struct _esxVI_UserSession { - char *key; /* required */ - char *userName; /* required */ - char *fullName; /* required */ - esxVI_DateTime *loginTime; /* required */ - esxVI_DateTime *lastActiveTime; /* required */ - char *locale; /* required */ - char *messageLocale; /* required */ -}; - -int esxVI_UserSession_Alloc(esxVI_UserSession **userSession); -void esxVI_UserSession_Free(esxVI_UserSession **userSession); -int esxVI_UserSession_Validate(esxVI_UserSession *userSession); -int esxVI_UserSession_CastFromAnyType(esxVI_AnyType *anyType, - esxVI_UserSession **userSession); -int esxVI_UserSession_Deserialize(xmlNodePtr node, - esxVI_UserSession **userSession); - + (xmlNodePtr node, esxVI_ManagedObjectReference **managedObjectReference); -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: VirtualMachineQuestionInfo - */ - -/* FIXME: implement the rest */ -struct _esxVI_VirtualMachineQuestionInfo { - char *id; /* required */ - char *text; /* required */ - esxVI_ChoiceOption *choice; /* required */ - /*esxVI_VirtualMachineMessage *message;*/ /* optional, list */ -}; - -int esxVI_VirtualMachineQuestionInfo_Alloc - (esxVI_VirtualMachineQuestionInfo **virtualMachineQuestionInfo); -void esxVI_VirtualMachineQuestionInfo_Free - (esxVI_VirtualMachineQuestionInfo **virtualMachineQuestionInfo); -int esxVI_VirtualMachineQuestionInfo_Validate - (esxVI_VirtualMachineQuestionInfo *virtualMachineQuestionInfo); -int esxVI_VirtualMachineQuestionInfo_CastFromAnyType - (esxVI_AnyType *anyType, - esxVI_VirtualMachineQuestionInfo **virtualMachineQuestionInfo); -int esxVI_VirtualMachineQuestionInfo_Deserialize - (xmlNodePtr node, - esxVI_VirtualMachineQuestionInfo **virtualMachineQuestionInfo); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: ElementDescription extends Description - * - * In contrast to SelectionSpec and TraversalSpec just merge - * Description into ElementDescription for simplicity, because - * only ElementDescription is used. - */ - -struct _esxVI_ElementDescription { - esxVI_ElementDescription *_next; /* optional */ - - /* Description */ - char *label; /* required */ - char *summary; /* required */ - - /* ElementDescription */ - char *key; /* required */ -}; - -int esxVI_ElementDescription_Alloc - (esxVI_ElementDescription **elementDescription); -void esxVI_ElementDescription_Free - (esxVI_ElementDescription **elementDescription); -int esxVI_ElementDescription_Validate - (esxVI_ElementDescription *elementDescription); -int esxVI_ElementDescription_AppendToList - (esxVI_ElementDescription **elementDescriptionList, - esxVI_ElementDescription *elementDescription); -int esxVI_ElementDescription_Deserialize - (xmlNodePtr node, esxVI_ElementDescription **elementDescription); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: ChoiceOption extends OptionType - * - * In contrast to SelectionSpec and TraversalSpec just merge - * OptionType into ChoiceOption for simplicity, because - * only ChoiceOption is used. - */ - -struct _esxVI_ChoiceOption { - /* OptionType */ - esxVI_Boolean valueIsReadonly; /* optional */ - - /* ChoiceOption */ - esxVI_ElementDescription *choiceInfo; /* required, list */ - esxVI_Int *defaultIndex; /* optional */ -}; - -int esxVI_ChoiceOption_Alloc(esxVI_ChoiceOption **choiceOption); -void esxVI_ChoiceOption_Free(esxVI_ChoiceOption **choiceOption); -int esxVI_ChoiceOption_Validate(esxVI_ChoiceOption *choiceOption); -int esxVI_ChoiceOption_Deserialize(xmlNodePtr node, - esxVI_ChoiceOption **choiceOption); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: PerfMetricId - */ - -struct _esxVI_PerfMetricId { - esxVI_PerfMetricId *_next; /* optional */ - - esxVI_Int *counterId; /* required */ - char *instance; /* required */ -}; - -int esxVI_PerfMetricId_Alloc(esxVI_PerfMetricId **perfMetricId); -void esxVI_PerfMetricId_Free(esxVI_PerfMetricId **perfMetricId); -int esxVI_PerfMetricId_Validate(esxVI_PerfMetricId *perfMetricId); -int esxVI_PerfMetricId_Serialize(esxVI_PerfMetricId *perfMetricId, - const char *element, virBufferPtr output); -int esxVI_PerfMetricId_SerializeList(esxVI_PerfMetricId *perfMetricIdList, - const char *element, virBufferPtr output); -int esxVI_PerfMetricId_Deserialize(xmlNodePtr node, - esxVI_PerfMetricId **perfMetricId); -int esxVI_PerfMetricId_DeserializeList(xmlNodePtr node, - esxVI_PerfMetricId **perfMetricIdList); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: PerfCounterInfo - */ - -struct _esxVI_PerfCounterInfo { - esxVI_PerfCounterInfo *_next; /* optional */ - - esxVI_Int *key; /* required */ - esxVI_ElementDescription *nameInfo; /* required */ - esxVI_ElementDescription *groupInfo; /* required */ - esxVI_ElementDescription *unitInfo; /* required */ - esxVI_PerfSummaryType rollupType; /* required */ - esxVI_PerfStatsType statsType; /* required */ - esxVI_Int *level; /* optional */ - esxVI_Int *associatedCounterId; /* optional, list */ -}; - -int esxVI_PerfCounterInfo_Alloc(esxVI_PerfCounterInfo **perfCounterInfo); -void esxVI_PerfCounterInfo_Free(esxVI_PerfCounterInfo **perfCounterInfo); -int esxVI_PerfCounterInfo_Validate(esxVI_PerfCounterInfo *perfCounterInfo); -int esxVI_PerfCounterInfo_Deserialize(xmlNodePtr node, - esxVI_PerfCounterInfo **perfCounterInfo); -int esxVI_PerfCounterInfo_DeserializeList - (xmlNodePtr node, esxVI_PerfCounterInfo **perfCounterInfoList); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: PerfQuerySpec - */ - -struct _esxVI_PerfQuerySpec { - esxVI_PerfQuerySpec *_next; /* optional */ - - esxVI_ManagedObjectReference *entity; /* required */ - esxVI_DateTime *startTime; /* optional */ - esxVI_DateTime *endTime; /* optional */ - esxVI_Int *maxSample; /* optional */ - esxVI_PerfMetricId *metricId; /* optional, list */ - esxVI_Int *intervalId; /* optional */ - char *format; /* optional */ // FIXME: see PerfFormat -}; - -int esxVI_PerfQuerySpec_Alloc(esxVI_PerfQuerySpec **perfQuerySpec); -void esxVI_PerfQuerySpec_Free(esxVI_PerfQuerySpec **perfQuerySpec); -int esxVI_PerfQuerySpec_Validate(esxVI_PerfQuerySpec *perfQuerySpec); -int esxVI_PerfQuerySpec_Serialize(esxVI_PerfQuerySpec *perfQuerySpec, - const char *element, virBufferPtr output); -int esxVI_PerfQuerySpec_SerializeList(esxVI_PerfQuerySpec *perfQuerySpecList, - const char *element, virBufferPtr output); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: PerfSampleInfo - */ - -struct _esxVI_PerfSampleInfo { - esxVI_PerfSampleInfo *_next; /* optional */ - - esxVI_DateTime *timestamp; /* required */ - esxVI_Int *interval; /* required */ -}; - -int esxVI_PerfSampleInfo_Alloc(esxVI_PerfSampleInfo **perfSampleInfo); -void esxVI_PerfSampleInfo_Free(esxVI_PerfSampleInfo **perfSampleInfo); -int esxVI_PerfSampleInfo_Validate(esxVI_PerfSampleInfo *perfSampleInfo); -int esxVI_PerfSampleInfo_AppendToList(esxVI_PerfSampleInfo **perfSampleInfoList, - esxVI_PerfSampleInfo *perfSampleInfo); -int esxVI_PerfSampleInfo_Deserialize(xmlNodePtr node, - esxVI_PerfSampleInfo **perfSampleInfo); -int esxVI_PerfSampleInfo_DeserializeList - (xmlNodePtr node, esxVI_PerfSampleInfo **perfSampleInfoList); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: PerfMetricIntSeries extends PerfMetricSeries - * - * In contrast to SelectionSpec and TraversalSpec just merge - * PerfMetricSeries into PerfMetricIntSeries for simplicity, because - * only PerfMetricIntSeries is used and the other type inheriting - * PerfMetricSeries (PerfMetricSeriesCSV) is not used. - */ - -struct _esxVI_PerfMetricIntSeries { - esxVI_PerfMetricIntSeries *_next; /* optional */ - - /* PerfMetricSeries */ - esxVI_PerfMetricId *id; /* required */ - - /* PerfMetricIntSeries */ - esxVI_Long *value; /* optional, list */ -}; - -int esxVI_PerfMetricIntSeries_Alloc - (esxVI_PerfMetricIntSeries **perfMetricIntSeries); -void esxVI_PerfMetricIntSeries_Free - (esxVI_PerfMetricIntSeries **perfMetricIntSeries); -int esxVI_PerfMetricIntSeries_Validate - (esxVI_PerfMetricIntSeries *perfMetricIntSeries); -int esxVI_PerfMetricIntSeries_AppendToList - (esxVI_PerfMetricIntSeries **perfMetricIntSeriesList, - esxVI_PerfMetricIntSeries *perfMetricIntSeries); -int esxVI_PerfMetricIntSeries_Deserialize - (xmlNodePtr node, esxVI_PerfMetricIntSeries **perfMetricIntSeries); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: PerfEntityMetric extends PerfEntityMetricBase - * - * In contrast to SelectionSpec and TraversalSpec just merge - * PerfEntityMetricBase into PerfEntityMetric for simplicity, because - * only PerfEntityMetric is used and the other type inheriting - * PerfEntityMetric (PerfEntityMetricCSV) is not used. - * - * Also use PerfMetricIntSeries instead of the correct base type - * PerfMetricSeries for the value property, because only - * PerfMetricIntSeries is used. - */ - -struct _esxVI_PerfEntityMetric { - esxVI_PerfEntityMetric *_next; /* optional */ - - /* PerfEntityMetricBase */ - esxVI_ManagedObjectReference *entity; /* required */ - - /* PerfEntityMetric */ - esxVI_PerfSampleInfo *sampleInfo; /* optional, list */ - esxVI_PerfMetricIntSeries *value; /* optional, list */ -}; - -int esxVI_PerfEntityMetric_Alloc(esxVI_PerfEntityMetric **perfEntityMetric); -void esxVI_PerfEntityMetric_Free(esxVI_PerfEntityMetric **perfEntityMetric); -int esxVI_PerfEntityMetric_Validate(esxVI_PerfEntityMetric *perfEntityMetric); -int esxVI_PerfEntityMetric_Deserialize - (xmlNodePtr node, esxVI_PerfEntityMetric **perfEntityMetric); -int esxVI_PerfEntityMetric_DeserializeList - (xmlNodePtr node, esxVI_PerfEntityMetric **perfEntityMetricList); - - - -/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * - * VI Type: TaskInfo - */ - -struct _esxVI_TaskInfo { - esxVI_TaskInfo *_next; /* optional */ - - char *key; /* required */ - esxVI_ManagedObjectReference *task; /* required */ - char *name; /* optional */ - char *descriptionId; /* required */ - esxVI_ManagedObjectReference *entity; /* optional */ - char *entityName; /* optional */ - /*esxVI_ManagedObjectReference *locked;*/ /* optional, list *//* FIXME */ - esxVI_TaskInfoState state; /* required */ - esxVI_Boolean cancelled; /* required */ - esxVI_Boolean cancelable; /* required */ - /*esxVI_MethodFault *error;*/ /* optional *//* FIXME */ - esxVI_AnyType *result; /* optional */ - esxVI_Int *progress; /* optional */ - /*esxVI_TaskReason *reason;*/ /* required *//* FIXME */ - esxVI_DateTime *queueTime; /* required */ - esxVI_DateTime *startTime; /* optional */ - esxVI_DateTime *completeTime; /* optional */ - esxVI_Int *eventChainId; /* required */ -}; -int esxVI_TaskInfo_Alloc(esxVI_TaskInfo **taskInfo); -void esxVI_TaskInfo_Free(esxVI_TaskInfo **taskInfoList); -int esxVI_TaskInfo_Validate(esxVI_TaskInfo *taskInfo); -int esxVI_TaskInfo_CastFromAnyType(esxVI_AnyType *anyType, - esxVI_TaskInfo **taskInfo); -int esxVI_TaskInfo_AppendToList(esxVI_TaskInfo **taskInfoList, - esxVI_TaskInfo *taskInfo); -int esxVI_TaskInfo_Deserialize(xmlNodePtr node, esxVI_TaskInfo **taskInfo); +#include "esx_vi_types.generated.h" #endif /* __ESX_VI_TYPES_H__ */ -- 1.6.3.3

2 2

Re: [libvirt] [PATCH] Add virt-aa-helper and secaatest to .gitignore
by Matthias Bolte 01 Apr '10

01 Apr '10

2010/3/31 Daniel Veillard <veillard(a)redhat.com>: > On Wed, Mar 31, 2010 at 01:38:48PM +0200, Matthias Bolte wrote: >> --- >> src/.gitignore | 1 + >> tests/.gitignore | 1 + >> 2 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/src/.gitignore b/src/.gitignore >> index 26b8689..e407dcb 100644 >> --- a/src/.gitignore >> +++ b/src/.gitignore >> @@ -15,3 +15,4 @@ libvirt_lxc >> libvirt.syms >> *.i >> *.s >> +virt-aa-helper >> diff --git a/tests/.gitignore b/tests/.gitignore >> index 399baee..387a924 100644 >> --- a/tests/.gitignore >> +++ b/tests/.gitignore >> @@ -33,3 +33,4 @@ object-locking-files.txt >> esxutilstest >> vmx2xmltest >> xml2vmxtest >> +secaatest > > ACK, > > Daniel > Thanks, pushed. Matthias

1 0

[libvirt] [PATCH] esx: Remove redundant semicolons
by Matthias Bolte 01 Apr '10

01 Apr '10

--- src/esx/esx_vi_types.c | 66 ++++++++++++++++++++++++------------------------ 1 files changed, 33 insertions(+), 33 deletions(-) diff --git a/src/esx/esx_vi_types.c b/src/esx/esx_vi_types.c index 6f257b2..3a30712 100644 --- a/src/esx/esx_vi_types.c +++ b/src/esx/esx_vi_types.c @@ -682,10 +682,10 @@ static const esxVI_Enumeration _esxVI_Boolean_Enumeration = { }; /* esxVI_Boolean_Serialize */ -ESX_VI__TEMPLATE__ENUMERATION__SERIALIZE(Boolean); +ESX_VI__TEMPLATE__ENUMERATION__SERIALIZE(Boolean) /* esxVI_Boolean_Deserialize */ -ESX_VI__TEMPLATE__ENUMERATION__DESERIALIZE(Boolean); +ESX_VI__TEMPLATE__ENUMERATION__DESERIALIZE(Boolean) @@ -694,7 +694,7 @@ ESX_VI__TEMPLATE__ENUMERATION__DESERIALIZE(Boolean); */ /* esxVI_AnyType_Alloc */ -ESX_VI__TEMPLATE__ALLOC(AnyType); +ESX_VI__TEMPLATE__ALLOC(AnyType) /* esxVI_AnyType_Free */ ESX_VI__TEMPLATE__FREE(AnyType, @@ -702,7 +702,7 @@ ESX_VI__TEMPLATE__FREE(AnyType, xmlFreeNode(item->node); VIR_FREE(item->other); VIR_FREE(item->value); -}); +}) int esxVI_AnyType_ExpectType(esxVI_AnyType *anyType, esxVI_Type type) @@ -908,7 +908,7 @@ esxVI_AnyType_Deserialize(xmlNodePtr node, esxVI_AnyType **anyType) */ /* esxVI_String_Alloc */ -ESX_VI__TEMPLATE__ALLOC(String); +ESX_VI__TEMPLATE__ALLOC(String) /* esxVI_String_Free */ ESX_VI__TEMPLATE__FREE(String, @@ -916,7 +916,7 @@ ESX_VI__TEMPLATE__FREE(String, esxVI_String_Free(&item->_next); VIR_FREE(item->value); -}); +}) /* esxVI_String_Validate */ ESX_VI__TEMPLATE__VALIDATE(String, @@ -925,7 +925,7 @@ ESX_VI__TEMPLATE__VALIDATE(String, }) /* esxVI_String_AppendToList */ -ESX_VI__TEMPLATE__LIST__APPEND(String); +ESX_VI__TEMPLATE__LIST__APPEND(String) int esxVI_String_AppendValueToList(esxVI_String **stringList, const char *value) @@ -989,7 +989,7 @@ ESX_VI__TEMPLATE__DEEP_COPY(String, }) /* esxVI_String_DeepCopyList */ -ESX_VI__TEMPLATE__LIST__DEEP_COPY(String); +ESX_VI__TEMPLATE__LIST__DEEP_COPY(String) int esxVI_String_DeepCopyValue(char **dest, const char *src) @@ -1022,7 +1022,7 @@ esxVI_String_Serialize(esxVI_String *string, const char *element, } /* esxVI_String_SerializeList */ -ESX_VI__TEMPLATE__LIST__SERIALIZE(String); +ESX_VI__TEMPLATE__LIST__SERIALIZE(String) int esxVI_String_SerializeValue(const char *value, const char *element, @@ -1053,7 +1053,7 @@ ESX_VI__TEMPLATE__DESERIALIZE(String, }) /* esxVI_String_DeserializeList */ -ESX_VI__TEMPLATE__LIST__DESERIALIZE(String); +ESX_VI__TEMPLATE__LIST__DESERIALIZE(String) int esxVI_String_DeserializeValue(xmlNodePtr node, char **value) @@ -1084,13 +1084,13 @@ esxVI_String_DeserializeValue(xmlNodePtr node, char **value) */ /* esxVI_Int_Alloc */ -ESX_VI__TEMPLATE__ALLOC(Int); +ESX_VI__TEMPLATE__ALLOC(Int) /* esxVI_Int_Free */ ESX_VI__TEMPLATE__FREE(Int, { esxVI_Int_Free(&item->_next); -}); +}) /* esxVI_Int_Validate */ ESX_VI__TEMPLATE__VALIDATE(Int, @@ -1098,7 +1098,7 @@ ESX_VI__TEMPLATE__VALIDATE(Int, }) /* esxVI_Int_AppendToList */ -ESX_VI__TEMPLATE__LIST__APPEND(Int); +ESX_VI__TEMPLATE__LIST__APPEND(Int) /* esxVI_Int_DeepCopy */ ESX_VI__TEMPLATE__DEEP_COPY(Int, @@ -1110,13 +1110,13 @@ ESX_VI__TEMPLATE__DEEP_COPY(Int, ESX_VI__TEMPLATE__SERIALIZE(Int, { virBufferVSprintf(output, "%d", (int)item->value); -}); +}) /* esxVI_Int_SerializeList */ -ESX_VI__TEMPLATE__LIST__SERIALIZE(Int); +ESX_VI__TEMPLATE__LIST__SERIALIZE(Int) /* esxVI_Int_Deserialize */ -ESX_VI__TEMPLATE__DESERIALIZE_NUMBER(Int, "xsd:int", INT32_MIN, INT32_MAX); +ESX_VI__TEMPLATE__DESERIALIZE_NUMBER(Int, "xsd:int", INT32_MIN, INT32_MAX) @@ -1125,13 +1125,13 @@ ESX_VI__TEMPLATE__DESERIALIZE_NUMBER(Int, "xsd:int", INT32_MIN, INT32_MAX); */ /* esxVI_Long_Alloc */ -ESX_VI__TEMPLATE__ALLOC(Long); +ESX_VI__TEMPLATE__ALLOC(Long) /* esxVI_Long_Free */ ESX_VI__TEMPLATE__FREE(Long, { esxVI_Long_Free(&item->_next); -}); +}) /* esxVI_Long_Validate */ ESX_VI__TEMPLATE__VALIDATE(Long, @@ -1139,19 +1139,19 @@ ESX_VI__TEMPLATE__VALIDATE(Long, }) /* esxVI_Long_AppendToList */ -ESX_VI__TEMPLATE__LIST__APPEND(Long); +ESX_VI__TEMPLATE__LIST__APPEND(Long) /* esxVI_Long_Serialize */ ESX_VI__TEMPLATE__SERIALIZE(Long, { virBufferVSprintf(output, "%lld", (long long int)item->value); -}); +}) /* esxVI_Long_SerializeList */ -ESX_VI__TEMPLATE__LIST__SERIALIZE(Long); +ESX_VI__TEMPLATE__LIST__SERIALIZE(Long) /* esxVI_Long_Deserialize */ -ESX_VI__TEMPLATE__DESERIALIZE_NUMBER(Long, "xsd:long", INT64_MIN, INT64_MAX); +ESX_VI__TEMPLATE__DESERIALIZE_NUMBER(Long, "xsd:long", INT64_MIN, INT64_MAX) @@ -1160,25 +1160,25 @@ ESX_VI__TEMPLATE__DESERIALIZE_NUMBER(Long, "xsd:long", INT64_MIN, INT64_MAX); */ /* esxVI_DateTime_Alloc */ -ESX_VI__TEMPLATE__ALLOC(DateTime); +ESX_VI__TEMPLATE__ALLOC(DateTime) /* esxVI_DateTime_Free */ ESX_VI__TEMPLATE__FREE(DateTime, { VIR_FREE(item->value); -}); +}) /* esxVI_DateTime_Validate */ ESX_VI__TEMPLATE__VALIDATE(DateTime, { ESX_VI__TEMPLATE__PROPERTY__REQUIRE(value); -}); +}) /* esxVI_DateTime_Serialize */ ESX_VI__TEMPLATE__SERIALIZE(DateTime, { virBufferAdd(output, item->value, -1); -}); +}) int esxVI_DateTime_Deserialize(xmlNodePtr node, esxVI_DateTime **dateTime) @@ -1224,14 +1224,14 @@ ESX_VI__TEMPLATE__FREE(Fault, { VIR_FREE(item->faultcode); VIR_FREE(item->faultstring); -}); +}) /* esxVI_Fault_Validate */ ESX_VI__TEMPLATE__VALIDATE(Fault, { ESX_VI__TEMPLATE__PROPERTY__REQUIRE(faultcode); ESX_VI__TEMPLATE__PROPERTY__REQUIRE(faultstring); -}); +}) /* esxVI_Fault_Deserialize */ ESX_VI__TEMPLATE__DESERIALIZE(Fault, @@ -1239,7 +1239,7 @@ ESX_VI__TEMPLATE__DESERIALIZE(Fault, ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, faultcode); ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_VALUE(String, faultstring); ESX_VI__TEMPLATE__PROPERTY__DESERIALIZE_IGNORE(detail); /* FIXME */ -}); +}) @@ -1248,7 +1248,7 @@ ESX_VI__TEMPLATE__DESERIALIZE(Fault, */ /* esxVI_ManagedObjectReference_Alloc */ -ESX_VI__TEMPLATE__ALLOC(ManagedObjectReference); +ESX_VI__TEMPLATE__ALLOC(ManagedObjectReference) /* esxVI_ManagedObjectReference_Free */ ESX_VI__TEMPLATE__FREE(ManagedObjectReference, @@ -1257,7 +1257,7 @@ ESX_VI__TEMPLATE__FREE(ManagedObjectReference, VIR_FREE(item->type); VIR_FREE(item->value); -}); +}) /* esxVI_ManagedObjectReference_DeepCopy */ ESX_VI__TEMPLATE__DEEP_COPY(ManagedObjectReference, @@ -1267,7 +1267,7 @@ ESX_VI__TEMPLATE__DEEP_COPY(ManagedObjectReference, }) /* esxVI_ManagedObjectReference_AppendToList */ -ESX_VI__TEMPLATE__LIST__APPEND(ManagedObjectReference); +ESX_VI__TEMPLATE__LIST__APPEND(ManagedObjectReference) /* esxVI_ManagedObjectReference_CastFromAnyType */ ESX_VI__TEMPLATE__CAST_FROM_ANY_TYPE(ManagedObjectReference) @@ -1304,7 +1304,7 @@ esxVI_ManagedObjectReference_Serialize } /* esxVI_ManagedObjectReference_SerializeList */ -ESX_VI__TEMPLATE__LIST__SERIALIZE(ManagedObjectReference); +ESX_VI__TEMPLATE__LIST__SERIALIZE(ManagedObjectReference) int esxVI_ManagedObjectReference_Deserialize -- 1.6.3.3

2 2

[libvirt] [PATCH] maint: mark xenapiSessionErrorHandler messages for translation
by Jim Meyering 31 Mar '10

31 Mar '10

This makes sure that all xenapiSessionErrorHandler diagnostics are marked for translation. >From c79adc5fb5efb7aa2fbeee20d41d1c765e90b022 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Wed, 31 Mar 2010 12:24:25 +0200 Subject: [PATCH] maint: mark xenapiSessionErrorHandler messages for translation * cfg.mk (msg_gen_function): Add xenapiSessionErrorHandler. * po/POTFILES.in: Add src/xenapi/xenapi_driver.c * src/xenapi/xenapi_driver.c: Mark strings for translation. * src/xenapi/xenapi_utils.c (xenapiUtil_ParseQuery): --- cfg.mk | 1 + po/POTFILES.in | 1 + src/xenapi/xenapi_driver.c | 138 +++++++++++++++++++++++++++----------------- src/xenapi/xenapi_utils.c | 2 +- 4 files changed, 89 insertions(+), 53 deletions(-) diff --git a/cfg.mk b/cfg.mk index 9b8ee00..45da56a 100644 --- a/cfg.mk +++ b/cfg.mk @@ -215,6 +215,7 @@ msg_gen_function += virXenInotifyError msg_gen_function += virXenStoreError msg_gen_function += virXendError msg_gen_function += vshCloseLogFile +msg_gen_function += xenapiSessionErrorHandler msg_gen_function += xenUnifiedError msg_gen_function += xenXMError diff --git a/po/POTFILES.in b/po/POTFILES.in index 645c344..417bfa1 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -85,6 +85,7 @@ src/xen/xen_hypervisor.c src/xen/xen_inotify.c src/xen/xm_internal.c src/xen/xs_internal.c +src/xenapi/xenapi_driver.c src/xenapi/xenapi_utils.c tools/console.c tools/virsh.c diff --git a/src/xenapi/xenapi_driver.c b/src/xenapi/xenapi_driver.c index 6e1183d..d48bb4d 100644 --- a/src/xenapi/xenapi_driver.c +++ b/src/xenapi/xenapi_driver.c @@ -95,13 +95,13 @@ xenapiOpen (virConnectPtr conn, virConnectAuthPtr auth, int flags ATTRIBUTE_UNUS if (conn->uri->server == NULL) { xenapiSessionErrorHandler(conn, VIR_ERR_AUTH_FAILED, - "Server name not in URI"); + _("Server name not in URI")); goto error; } if (auth == NULL) { xenapiSessionErrorHandler(conn, VIR_ERR_AUTH_FAILED, - "Authentication Credentials not found"); + _("Authentication Credentials not found")); goto error; } @@ -117,7 +117,7 @@ xenapiOpen (virConnectPtr conn, virConnectAuthPtr auth, int flags ATTRIBUTE_UNUS if (username == NULL) { xenapiSessionErrorHandler(conn, VIR_ERR_AUTH_FAILED, - "Username request failed"); + _("Username request failed")); goto error; } } @@ -126,7 +126,7 @@ xenapiOpen (virConnectPtr conn, virConnectAuthPtr auth, int flags ATTRIBUTE_UNUS if (password == NULL) { xenapiSessionErrorHandler(conn, VIR_ERR_AUTH_FAILED, - "Password request failed"); + _("Password request failed")); goto error; } @@ -145,7 +145,7 @@ xenapiOpen (virConnectPtr conn, virConnectAuthPtr auth, int flags ATTRIBUTE_UNUS if (!(privP->caps = getCapsObject())) { xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, - "Capabilities not found"); + _("Capabilities not found")); goto error; } @@ -166,7 +166,7 @@ xenapiOpen (virConnectPtr conn, virConnectAuthPtr auth, int flags ATTRIBUTE_UNUS return VIR_DRV_OPEN_SUCCESS; } - xenapiSessionErrorHandler(conn, VIR_ERR_AUTH_FAILED, ""); + xenapiSessionErrorHandler(conn, VIR_ERR_AUTH_FAILED, NULL); error: VIR_FREE(username); @@ -279,7 +279,8 @@ xenapiGetVersion (virConnectPtr conn, unsigned long *hvVer) } if (version) { if (sscanf(version, "%ld.%ld.%ld", &major, &minor, &release) != 3) { - xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Couldn't get version info"); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, + _("Couldn't get version info")); xen_string_string_map_free(result); VIR_FREE(version); return -1; @@ -356,7 +357,8 @@ xenapiNodeGetInfo (virConnectPtr conn, virNodeInfoPtr info) info->memory = (unsigned long)(memory / 1024); xen_host_metrics_set_free(xen_met_set); } else { - xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Unable to get host metric Information"); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, + _("Unable to get host metric Information")); return -1; } if (xen_host_cpu_get_all(session, &host_cpu_set)) { @@ -377,7 +379,8 @@ xenapiNodeGetInfo (virConnectPtr conn, virNodeInfoPtr info) VIR_FREE(modelname); return 0; } - xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Unable to get Host CPU set"); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, + _("Unable to get Host CPU set")); return -1; } @@ -397,7 +400,8 @@ xenapiGetCapabilities (virConnectPtr conn) return xml; } cleanup: - xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Capabilities not available"); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, + _("Capabilities not available")); return NULL; } @@ -426,7 +430,8 @@ xenapiListDomains (virConnectPtr conn, int *ids, int maxids) for (i = 0; (i < (result->size)) && (i < maxids); i++) { xen_vm_get_domid(session, &t0, result->contents[i]); if (t0 > (int64_t)INT_MAX || t0 < (int64_t)INT_MIN) { - xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "DomainID can't fit in 32 bits"); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, + _("DomainID can't fit in 32 bits")); xen_vm_set_free(result); return -1; } @@ -497,7 +502,8 @@ xenapiDomainCreateXML (virConnectPtr conn, domP = virGetDomain(conn, record->name_label, raw_uuid); if (!domP) { xen_vm_record_free(record); - xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Domain Pointer is invalid"); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, + _("Domain Pointer is invalid")); return domP; } domP->id = record->domid; @@ -549,7 +555,8 @@ xenapiDomainLookupByID (virConnectPtr conn, int id) xen_vm_get_domid(session, &domid, result->contents[i]); domP->id = domid; } else { - xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Domain Pointer not valid"); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, + _("Domain Pointer not valid")); domP = NULL; } xen_uuid_free(uuid); @@ -590,7 +597,8 @@ xenapiDomainLookupByUUID (virConnectPtr conn, if (record != NULL) { domP = virGetDomain(conn, record->name_label, uuid); if (!domP) { - xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Domain Pointer not valid"); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, + _("Domain Pointer not valid")); domP = NULL; } else { domP->id = record->domid; @@ -624,7 +632,8 @@ xenapiDomainLookupByName (virConnectPtr conn, xen_session *session = ((struct _xenapiPrivate *)(conn->privateData))->session; if (xen_vm_get_by_name_label(session, &vms, (char *)name) && vms->size > 0) { if (vms->size != 1) { - xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Domain name is not unique"); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, + _("Domain name is not unique")); xen_vm_set_free(vms); return NULL; } @@ -644,13 +653,14 @@ xenapiDomainLookupByName (virConnectPtr conn, xen_uuid_free(uuid); xen_vm_set_free(vms); if (!session->ok) - xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Couldn't get the Domain Pointer"); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, + _("Couldn't get the Domain Pointer")); return NULL; } } } if (vms) xen_vm_set_free(vms); - xenapiSessionErrorHandler(conn, VIR_ERR_NO_DOMAIN, ""); + xenapiSessionErrorHandler(conn, VIR_ERR_NO_DOMAIN, NULL); return NULL; } @@ -669,7 +679,8 @@ xenapiDomainSuspend (virDomainPtr dom) xen_session *session = ((struct _xenapiPrivate *)(dom->conn->privateData))->session; if (xen_vm_get_by_name_label(session, &vms, dom->name) && vms->size > 0) { if (vms->size != 1) { - xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, "Domain name is not unique"); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, + _("Domain name is not unique")); xen_vm_set_free(vms); return -1; } else { @@ -684,7 +695,7 @@ xenapiDomainSuspend (virDomainPtr dom) } } if (vms) xen_vm_set_free(vms); - xenapiSessionErrorHandler(dom->conn, VIR_ERR_NO_DOMAIN, ""); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_NO_DOMAIN, NULL); return -1; } @@ -703,7 +714,8 @@ xenapiDomainResume (virDomainPtr dom) xen_session *session = ((struct _xenapiPrivate *)(dom->conn->privateData))->session; if (xen_vm_get_by_name_label(session, &vms, dom->name) && vms->size > 0) { if (vms->size != 1) { - xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, "Domain name is not unique"); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, + _("Domain name is not unique")); xen_vm_set_free(vms); return -1; } else { @@ -718,7 +730,7 @@ xenapiDomainResume (virDomainPtr dom) } } if (vms) xen_vm_set_free(vms); - xenapiSessionErrorHandler(dom->conn, VIR_ERR_NO_DOMAIN, ""); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_NO_DOMAIN, NULL); return -1; } @@ -737,7 +749,8 @@ xenapiDomainShutdown (virDomainPtr dom) xen_session *session = ((struct _xenapiPrivate *)(dom->conn->privateData))->session; if (xen_vm_get_by_name_label(session, &vms, dom->name) && vms->size > 0) { if (vms->size != 1) { - xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, "Domain name is not unique"); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, + _("Domain name is not unique")); xen_vm_set_free(vms); return -1; } else { @@ -752,7 +765,7 @@ xenapiDomainShutdown (virDomainPtr dom) } } if (vms) xen_vm_set_free(vms); - xenapiSessionErrorHandler(dom->conn, VIR_ERR_NO_DOMAIN, ""); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_NO_DOMAIN, NULL); return -1; } @@ -771,7 +784,8 @@ xenapiDomainReboot (virDomainPtr dom, unsigned int flags ATTRIBUTE_UNUSED) xen_session *session = ((struct _xenapiPrivate *)(dom->conn->privateData))->session; if (xen_vm_get_by_name_label(session, &vms, dom->name) && vms->size > 0) { if (vms->size != 1) { - xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, "Domain name is not unique"); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, + _("Domain name is not unique")); xen_vm_set_free(vms); return -1; } @@ -785,7 +799,7 @@ xenapiDomainReboot (virDomainPtr dom, unsigned int flags ATTRIBUTE_UNUSED) return 0; } if (vms) xen_vm_set_free(vms); - xenapiSessionErrorHandler(dom->conn, VIR_ERR_NO_DOMAIN, ""); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_NO_DOMAIN, NULL); return -1; } @@ -804,7 +818,8 @@ xenapiDomainDestroy (virDomainPtr dom) xen_session *session = ((struct _xenapiPrivate *)(dom->conn->privateData))->session; if (xen_vm_get_by_name_label(session, &vms, dom->name) && vms->size > 0) { if (vms->size != 1) { - xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, "Domain name is not unique"); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, + _("Domain name is not unique")); xen_vm_set_free(vms); return -1; } @@ -818,7 +833,7 @@ xenapiDomainDestroy (virDomainPtr dom) return 0; } if (vms) xen_vm_set_free(vms); - xenapiSessionErrorHandler(dom->conn, VIR_ERR_NO_DOMAIN, ""); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_NO_DOMAIN, NULL); return -1; } @@ -839,7 +854,8 @@ xenapiDomainGetOSType (virDomainPtr dom) if (xen_vm_get_by_name_label(session, &vms, dom->name) && vms->size > 0) { if (vms->size != 1) { - xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, "Domain name is not unique"); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, + _("Domain name is not unique")); xen_vm_set_free(vms); return NULL; } @@ -852,7 +868,7 @@ xenapiDomainGetOSType (virDomainPtr dom) virReportOOMError(); VIR_FREE(boot_policy); } else - xenapiSessionErrorHandler(dom->conn, VIR_ERR_NO_DOMAIN, ""); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_NO_DOMAIN, NULL); cleanup: if (vms) xen_vm_set_free(vms); @@ -873,7 +889,8 @@ xenapiDomainGetMaxMemory (virDomainPtr dom) xen_session *session = ((struct _xenapiPrivate *)(dom->conn->privateData))->session; if (xen_vm_get_by_name_label(session, &vms, dom->name) && vms->size > 0) { if (vms->size != 1) { - xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, "Domain name is not unique"); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, + _("Domain name is not unique")); xen_vm_set_free(vms); return 0; } @@ -903,7 +920,8 @@ xenapiDomainSetMaxMemory (virDomainPtr dom, unsigned long memory) xen_session *session = ((struct _xenapiPrivate *)(dom->conn->privateData))->session; if (xen_vm_get_by_name_label(session, &vms, dom->name) && vms->size > 0) { if (vms->size != 1) { - xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, "Domain name is not unique"); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, + _("Domain name is not unique")); xen_vm_set_free(vms); return -1; } @@ -939,7 +957,8 @@ xenapiDomainGetInfo (virDomainPtr dom, virDomainInfoPtr info) info->cpuTime = 0; /* CPU time is not advertised */ if (xen_vm_get_by_name_label(session, &vms, dom->name) && vms->size > 0) { if (vms->size != 1) { - xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, "Domain name is not unique"); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, + _("Domain name is not unique")); xen_vm_set_free(vms); return -1; } @@ -982,7 +1001,8 @@ xenapiDomainSetVcpus (virDomainPtr dom, unsigned int nvcpus) xen_session *session = ((struct _xenapiPrivate *)(dom->conn->privateData))->session; if (xen_vm_get_by_name_label(session, &vms, dom->name) && vms->size > 0) { if (vms->size != 1) { - xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, "Domain name is not unique"); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, + _("Domain name is not unique")); xen_vm_set_free(vms); return -1; } @@ -1013,7 +1033,8 @@ xenapiDomainPinVcpu (virDomainPtr dom, unsigned int vcpu ATTRIBUTE_UNUSED, xen_session *session = ((struct _xenapiPrivate *)(dom->conn->privateData))->session; if (xen_vm_get_by_name_label(session, &vms, dom->name) && vms->size > 0) { if (vms->size != 1) { - xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, "Domain name is not unique"); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, + _("Domain name is not unique")); xen_vm_set_free(vms); return -1; } @@ -1063,13 +1084,15 @@ xenapiDomainGetVcpus (virDomainPtr dom, if (xenapiDomainGetInfo(dom, &domInfo) == 0) { nvcpus = domInfo.nrVirtCpu; } else { - xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, "Couldn't fetch Domain Information"); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, + _("Couldn't fetch Domain Information")); return -1; } if (xenapiNodeGetInfo(dom->conn, &nodeInfo) == 0) cpus = nodeInfo.cpus; else { - xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, "Couldn't fetch Node Information"); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, + _("Couldn't fetch Node Information")); return -1; } if (nvcpus > maxinfo) @@ -1079,7 +1102,8 @@ xenapiDomainGetVcpus (virDomainPtr dom, if (!xen_vm_get_by_name_label(session, &vms, dom->name)) return -1; if (vms->size != 1) { - xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, "Domain name is not unique"); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, + _("Domain name is not unique")); xen_vm_set_free(vms); return -1; } @@ -1130,7 +1154,8 @@ xenapiDomainGetMaxVcpus (virDomainPtr dom) xen_session *session = ((struct _xenapiPrivate *)(dom->conn->privateData))->session; if (xen_vm_get_by_name_label(session, &vms, dom->name) && vms->size > 0) { if (vms->size != 1) { - xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, "Domain name is not unique"); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, + _("Domain name is not unique")); xen_vm_set_free(vms); return -1; } @@ -1166,7 +1191,8 @@ xenapiDomainDumpXML (virDomainPtr dom, int flags ATTRIBUTE_UNUSED) if (!xen_vm_get_by_name_label(session, &vms, dom->name)) return NULL; if (vms->size != 1) { - xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, "Domain name is not unique"); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, + _("Domain name is not unique")); xen_vm_set_free(vms); return NULL; } @@ -1322,7 +1348,7 @@ xenapiDomainDumpXML (virDomainPtr dom, int flags ATTRIBUTE_UNUSED) if (vif_rec != NULL) { if (virParseMacAddr((const char *)vif_rec->mac,defPtr->nets[i]->mac) < 0) xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, - "Unable to parse given mac address"); + _("Unable to parse given mac address")); xen_vif_record_free(vif_rec); } } @@ -1373,7 +1399,8 @@ xenapiListDefinedDomains (virConnectPtr conn, char **const names, } xen_vm_record_free(record); } else { - xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Couldn't get VM record"); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, + _("Couldn't get VM record")); xen_vm_set_free(result); while (--j >= 0) VIR_FREE(names[j]); return -1; @@ -1434,7 +1461,8 @@ xenapiDomainCreate (virDomainPtr dom) xen_session *session = ((struct _xenapiPrivate *)(dom->conn->privateData))->session; if (xen_vm_get_by_name_label(session, &vms, dom->name) && vms->size > 0) { if (vms->size != 1) { - xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, "Domain name is not unique"); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, + _("Domain name is not unique")); xen_vm_set_free(vms); return -1; } @@ -1476,7 +1504,8 @@ xenapiDomainDefineXML (virConnectPtr conn, const char *xml) if (!session->ok) xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); else - xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Couldn't get VM information from XML"); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, + _("Couldn't get VM information from XML")); virDomainDefFree(defPtr); return NULL; } @@ -1508,7 +1537,8 @@ xenapiDomainUndefine (virDomainPtr dom) xen_session *session = ((struct _xenapiPrivate *)(dom->conn->privateData))->session; if (xen_vm_get_by_name_label(session, &vms, dom->name) && vms->size > 0) { if (vms->size != 1) { - xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, "Domain name is not unique"); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, + _("Domain name is not unique")); xen_vm_set_free(vms); return -1; } @@ -1522,7 +1552,7 @@ xenapiDomainUndefine (virDomainPtr dom) return 0; } if (vms) xen_vm_set_free(vms); - xenapiSessionErrorHandler(dom->conn, VIR_ERR_NO_DOMAIN, ""); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_NO_DOMAIN, NULL); return -1; } @@ -1543,7 +1573,8 @@ xenapiDomainGetAutostart (virDomainPtr dom, int *autostart) xen_session *session = ((struct _xenapiPrivate *)(dom->conn->privateData))->session; if (xen_vm_get_by_name_label(session, &vms, dom->name) && vms->size > 0) { if (vms->size != 1) { - xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, "Domain name is not unique"); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, + _("Domain name is not unique")); xen_vm_set_free(vms); return -1; } @@ -1569,7 +1600,7 @@ xenapiDomainGetAutostart (virDomainPtr dom, int *autostart) return 0; } if (vms) xen_vm_set_free(vms); - xenapiSessionErrorHandler(dom->conn, VIR_ERR_NO_DOMAIN, ""); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_NO_DOMAIN, NULL); return -1; } @@ -1588,7 +1619,8 @@ xenapiDomainSetAutostart (virDomainPtr dom, int autostart) xen_session *session = ((struct _xenapiPrivate *)(dom->conn->privateData))->session; if (xen_vm_get_by_name_label(session, &vms, dom->name) && vms->size > 0) { if (vms->size != 1) { - xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, "Domain name is not unique"); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR, + _("Domain name is not unique")); xen_vm_set_free(vms); return -1; } @@ -1607,7 +1639,7 @@ xenapiDomainSetAutostart (virDomainPtr dom, int autostart) return 0; } if (vms) xen_vm_set_free(vms); - xenapiSessionErrorHandler(dom->conn, VIR_ERR_NO_DOMAIN, ""); + xenapiSessionErrorHandler(dom->conn, VIR_ERR_NO_DOMAIN, NULL); return -1; } @@ -1636,12 +1668,14 @@ xenapiNodeGetFreeMemory (virConnectPtr conn) xen_host_metrics_get_all(session, &xen_met_set); if (xen_met_set != NULL) { if (!xen_host_metrics_get_memory_free(session, (int64_t *)&freeMem, xen_met_set->contents[0])) { - xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Couldn't get host metrics - memory information"); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, + _("Couldn't get host metrics - memory information")); freeMem = 0; } xen_host_metrics_set_free(xen_met_set); } else { - xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Couldn't get host metrics"); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, + _("Couldn't get host metrics")); } return freeMem; } @@ -1657,7 +1691,7 @@ xenapiNodeGetCellsFreeMemory (virConnectPtr conn, unsigned long long *freeMems, int startCell, int maxCells) { if (maxCells > 1 && startCell > 0) { - xenapiSessionErrorHandler(conn, VIR_ERR_NO_SUPPORT, ""); + xenapiSessionErrorHandler(conn, VIR_ERR_NO_SUPPORT, NULL); return -1; } else { freeMems[0] = xenapiNodeGetFreeMemory(conn); diff --git a/src/xenapi/xenapi_utils.c b/src/xenapi/xenapi_utils.c index 697ad39..60e3c8d 100644 --- a/src/xenapi/xenapi_utils.c +++ b/src/xenapi/xenapi_utils.c @@ -119,7 +119,7 @@ xenapiUtil_ParseQuery(virConnectPtr conn, xmlURIPtr uri, int *noVerify) if (virStrToLong_i(queryParam->value, NULL, 10, noVerify) < 0 || (*noVerify != 0 && *noVerify != 1)) { xenapiSessionErrorHandler(conn, VIR_ERR_INVALID_ARG, - "Query parameter 'no_verify' has unexpected value (should be 0 or 1)"); + _("Query parameter 'no_verify' has unexpected value (should be 0 or 1)")); goto failure; } } -- 1.7.0.3.513.gc8ed0

2 1

[libvirt] [PATCH v2] Blank out invalid interface names with escaped letters etc.
by Stefan Berger 31 Mar '10

31 Mar '10

Check that interface names only contain valid characters. Blank them out otherwise. Valid characters in this code are currently a-z,A-Z,0-9, '-' and '_'. Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com> --- src/conf/domain_conf.c | 9 ++++++++- src/conf/domain_conf.h | 3 +++ 2 files changed, 11 insertions(+), 1 deletion(-) Index: libvirt-acl/src/conf/domain_conf.c =================================================================== --- libvirt-acl.orig/src/conf/domain_conf.c +++ libvirt-acl/src/conf/domain_conf.c @@ -1776,6 +1776,11 @@ cleanup: } +static bool +isValidIfname(const char *ifname) { + return strspn(ifname, VALID_IFNAME_CHARS) == strlen(ifname); +} + /* Parse the XML definition for a network interface * @param node XML nodeset to parse for net definition @@ -1859,8 +1864,10 @@ virDomainNetDefParseXML(virCapsPtr caps, xmlStrEqual(cur->name, BAD_CAST "target")) { ifname = virXMLPropString(cur, "dev"); if ((ifname != NULL) && - (STRPREFIX((const char*)ifname, "vnet"))) { + ((STRPREFIX((const char*)ifname, "vnet")) || + (!isValidIfname(ifname)))) { /* An auto-generated target name, blank it out */ + /* blank out invalid interface names */ VIR_FREE(ifname); } } else if ((script == NULL) && Index: libvirt-acl/src/conf/domain_conf.h =================================================================== --- libvirt-acl.orig/src/conf/domain_conf.h +++ libvirt-acl/src/conf/domain_conf.h @@ -297,6 +297,9 @@ struct _virDomainNetDef { virNWFilterHashTablePtr filterparams; }; +#define VALID_IFNAME_CHARS \ + "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_" + enum virDomainChrTargetType { VIR_DOMAIN_CHR_TARGET_TYPE_NULL = 0, VIR_DOMAIN_CHR_TARGET_TYPE_MONITOR,

1 0

[libvirt] [PATCH] Keep track of guest paused state after disk IO / watchdog events
by Daniel P. Berrange 31 Mar '10

31 Mar '10

When a watchdog/IO error occurs, one of the possible actions that QEMU might take is to pause the guest. In this scenario libvirt needs to update its internal state for the VM, and emit a lifecycle event: VIR_DOMAIN_EVENT_SUSPENDED with a detail being one of: VIR_DOMAIN_EVENT_SUSPENDED_IOERROR VIR_DOMAIN_EVENT_SUSPENDED_WATCHDOG To future proof against possible QEMU support for multiple monitor consoles, this patch also hooks into the 'STOPPED' event in QEMU and emits a generic VIR_DOMAIN_EVENT_SUSPENDED_PAUSED event * include/libvirt/libvirt.h.in: Add VIR_DOMAIN_EVENT_SUSPENDED_IOERROR * src/qemu/qemu_driver.c: Update VM state to paused when IO error or watchdog events occurrs * src/qemu/qemu_monitor_json.c: Fix typo in disk IO event name --- include/libvirt/libvirt.h.in | 2 + src/qemu/qemu_driver.c | 83 ++++++++++++++++++++++++++++++++++++++---- src/qemu/qemu_monitor_json.c | 2 +- 3 files changed, 78 insertions(+), 9 deletions(-) diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index 6d8552f..7cb483e 100644 --- a/include/libvirt/libvirt.h.in +++ b/include/libvirt/libvirt.h.in @@ -1384,6 +1384,8 @@ typedef enum { typedef enum { VIR_DOMAIN_EVENT_SUSPENDED_PAUSED = 0, /* Normal suspend due to admin pause */ VIR_DOMAIN_EVENT_SUSPENDED_MIGRATED = 1, /* Suspended for offline migration */ + VIR_DOMAIN_EVENT_SUSPENDED_IOERROR = 2, /* Suspended due to a disk I/O error */ + VIR_DOMAIN_EVENT_SUSPENDED_WATCHDOG = 3, /* Suspended due to a watchdog firing */ } virDomainEventSuspendedDetailType; /** diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 9ee5da7..4291bc7 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -909,6 +909,38 @@ qemuHandleDomainReset(qemuMonitorPtr mon ATTRIBUTE_UNUSED, static int +qemuHandleDomainStop(qemuMonitorPtr mon ATTRIBUTE_UNUSED, + virDomainObjPtr vm) +{ + struct qemud_driver *driver = qemu_driver; + virDomainEventPtr event = NULL; + + virDomainObjLock(vm); + if (vm->state == VIR_DOMAIN_RUNNING) { + VIR_DEBUG("Transitioned guest %s to paused state due to unknown event", vm->def->name); + + vm->state = VIR_DOMAIN_PAUSED; + event = virDomainEventNewFromObj(vm, + VIR_DOMAIN_EVENT_SUSPENDED, + VIR_DOMAIN_EVENT_SUSPENDED_PAUSED); + + if (virDomainSaveStatus(driver->caps, driver->stateDir, vm) < 0) + VIR_WARN("Unable to save status on vm %s after IO error", vm->def->name); + } + virDomainObjUnlock(vm); + + if (event) { + qemuDriverLock(driver); + if (event) + qemuDomainEventQueue(driver, event); + qemuDriverUnlock(driver); + } + + return 0; +} + + +static int qemuHandleDomainRTCChange(qemuMonitorPtr mon ATTRIBUTE_UNUSED, virDomainObjPtr vm, long long offset) @@ -943,15 +975,32 @@ qemuHandleDomainWatchdog(qemuMonitorPtr mon ATTRIBUTE_UNUSED, int action) { struct qemud_driver *driver = qemu_driver; - virDomainEventPtr event; + virDomainEventPtr watchdogEvent = NULL; + virDomainEventPtr lifecycleEvent = NULL; virDomainObjLock(vm); - event = virDomainEventWatchdogNewFromObj(vm, action); + watchdogEvent = virDomainEventWatchdogNewFromObj(vm, action); + + if (action == VIR_DOMAIN_EVENT_WATCHDOG_PAUSE && + vm->state == VIR_DOMAIN_RUNNING) { + VIR_DEBUG("Transitioned guest %s to paused state due to watchdog", vm->def->name); + + vm->state = VIR_DOMAIN_PAUSED; + lifecycleEvent = virDomainEventNewFromObj(vm, + VIR_DOMAIN_EVENT_SUSPENDED, + VIR_DOMAIN_EVENT_SUSPENDED_WATCHDOG); + + if (virDomainSaveStatus(driver->caps, driver->stateDir, vm) < 0) + VIR_WARN("Unable to save status on vm %s after IO error", vm->def->name); + } virDomainObjUnlock(vm); - if (event) { + if (watchdogEvent || lifecycleEvent) { qemuDriverLock(driver); - qemuDomainEventQueue(driver, event); + if (watchdogEvent) + qemuDomainEventQueue(driver, watchdogEvent); + if (lifecycleEvent) + qemuDomainEventQueue(driver, lifecycleEvent); qemuDriverUnlock(driver); } @@ -966,7 +1015,8 @@ qemuHandleDomainIOError(qemuMonitorPtr mon ATTRIBUTE_UNUSED, int action) { struct qemud_driver *driver = qemu_driver; - virDomainEventPtr event; + virDomainEventPtr ioErrorEvent = NULL; + virDomainEventPtr lifecycleEvent = NULL; const char *srcPath; const char *devAlias; virDomainDiskDefPtr disk; @@ -982,12 +1032,28 @@ qemuHandleDomainIOError(qemuMonitorPtr mon ATTRIBUTE_UNUSED, devAlias = ""; } - event = virDomainEventIOErrorNewFromObj(vm, srcPath, devAlias, action); + ioErrorEvent = virDomainEventIOErrorNewFromObj(vm, srcPath, devAlias, action); + + if (action == VIR_DOMAIN_EVENT_IO_ERROR_PAUSE && + vm->state == VIR_DOMAIN_RUNNING) { + VIR_DEBUG("Transitioned guest %s to paused state due to IO error", vm->def->name); + + vm->state = VIR_DOMAIN_PAUSED; + lifecycleEvent = virDomainEventNewFromObj(vm, + VIR_DOMAIN_EVENT_SUSPENDED, + VIR_DOMAIN_EVENT_SUSPENDED_IOERROR); + + if (virDomainSaveStatus(driver->caps, driver->stateDir, vm) < 0) + VIR_WARN("Unable to save status on vm %s after IO error", vm->def->name); + } virDomainObjUnlock(vm); - if (event) { + if (ioErrorEvent || lifecycleEvent) { qemuDriverLock(driver); - qemuDomainEventQueue(driver, event); + if (ioErrorEvent) + qemuDomainEventQueue(driver, ioErrorEvent); + if (lifecycleEvent) + qemuDomainEventQueue(driver, lifecycleEvent); qemuDriverUnlock(driver); } @@ -1090,6 +1156,7 @@ no_memory: static qemuMonitorCallbacks monitorCallbacks = { .eofNotify = qemuHandleMonitorEOF, .diskSecretLookup = findVolumeQcowPassphrase, + .domainStop = qemuHandleDomainStop, .domainReset = qemuHandleDomainReset, .domainRTCChange = qemuHandleDomainRTCChange, .domainWatchdog = qemuHandleDomainWatchdog, diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 3901d46..eac3aca 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -66,7 +66,7 @@ struct { { "STOP", qemuMonitorJSONHandleStop, }, { "RTC_CHANGE", qemuMonitorJSONHandleRTCChange, }, { "WATCHDOG", qemuMonitorJSONHandleWatchdog, }, - { "DISK_IO_ERROR", qemuMonitorJSONHandleIOError, }, + { "BLOCK_IO_ERROR", qemuMonitorJSONHandleIOError, }, { "VNC_CONNECTED", qemuMonitorJSONHandleVNCConnect, }, { "VNC_INITIALIZED", qemuMonitorJSONHandleVNCInitialize, }, { "VNC_DISCONNECTED", qemuMonitorJSONHandleVNCDisconnect, }, -- 1.6.2.5

2 2

[libvirt] [PATCH] Keep build quiet for generated file
by Daniel P. Berrange 31 Mar '10

31 Mar '10

Adds $(AM_V_GEN) to many more manual makefile.am rules that were generating files --- daemon/Makefile.am | 28 ++++++++++++++-------------- src/Makefile.am | 18 +++++++++--------- tools/Makefile.am | 40 ++++++++++++++++++++-------------------- 3 files changed, 43 insertions(+), 43 deletions(-) diff --git a/daemon/Makefile.am b/daemon/Makefile.am index e117b97..a82e9a9 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -172,16 +172,16 @@ remote.c: remote_dispatch_prototypes.h \ REMOTE_PROTOCOL = $(top_srcdir)/src/remote/remote_protocol.x remote_dispatch_prototypes.h: $(srcdir)/remote_generate_stubs.pl $(REMOTE_PROTOCOL) - perl -w $(srcdir)/remote_generate_stubs.pl -p $(REMOTE_PROTOCOL) > $@ + $(AM_V_GEN)perl -w $(srcdir)/remote_generate_stubs.pl -p $(REMOTE_PROTOCOL) > $@ remote_dispatch_table.h: $(srcdir)/remote_generate_stubs.pl $(REMOTE_PROTOCOL) - perl -w $(srcdir)/remote_generate_stubs.pl -t $(REMOTE_PROTOCOL) > $@ + $(AM_V_GEN)perl -w $(srcdir)/remote_generate_stubs.pl -t $(REMOTE_PROTOCOL) > $@ remote_dispatch_args.h: $(srcdir)/remote_generate_stubs.pl $(REMOTE_PROTOCOL) - perl -w $(srcdir)/remote_generate_stubs.pl -a $(REMOTE_PROTOCOL) > $@ + $(AM_V_GEN)perl -w $(srcdir)/remote_generate_stubs.pl -a $(REMOTE_PROTOCOL) > $@ remote_dispatch_ret.h: $(srcdir)/remote_generate_stubs.pl $(REMOTE_PROTOCOL) - perl -w $(srcdir)/remote_generate_stubs.pl -r $(REMOTE_PROTOCOL) > $@ + $(AM_V_GEN)perl -w $(srcdir)/remote_generate_stubs.pl -r $(REMOTE_PROTOCOL) > $@ LOGROTATE_CONFS = libvirtd.qemu.logrotate libvirtd.lxc.logrotate \ libvirtd.uml.logrotate @@ -195,16 +195,16 @@ libvirtd.qemu.logrotate: libvirtd.qemu.logrotate.in mv $@-t $@ libvirtd.lxc.logrotate: libvirtd.lxc.logrotate.in - sed \ + $(AM_V_GEN)sed \ -e 's![@]localstatedir[@]!$(localstatedir)!g' \ - < $< > $@-t - mv $@-t $@ + < $< > $@-t && \ + mv $@-t $@ libvirtd.uml.logrotate: libvirtd.uml.logrotate.in - sed \ + $(AM_V_GEN)sed \ -e 's![@]localstatedir[@]!$(localstatedir)!g' \ - < $< > $@-t - mv $@-t $@ + < $< > $@-t && \ + mv $@-t $@ install-logrotate: $(LOGROTATE_CONFS) mkdir -p $(DESTDIR)$(localstatedir)/log/libvirt/qemu/ @@ -231,13 +231,13 @@ uninstall-init: BUILT_SOURCES += libvirtd.init libvirtd.init: libvirtd.init.in - sed \ + $(AM_V_GEN)sed \ -e s!\@localstatedir\@!@localstatedir@!g \ -e s!\@sbindir\@!@sbindir@!g \ -e s!\@sysconfdir\@!@sysconfdir@!g \ - < $< > $@-t - chmod a+x $@-t - mv $@-t $@ + < $< > $@-t && \ + chmod a+x $@-t && \ + mv $@-t $@ check-local: test -x '$(AUGPARSE)' \ diff --git a/src/Makefile.am b/src/Makefile.am index c661a5c..cc0a7d6 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -870,17 +870,17 @@ EXTRA_DIST += \ BUILT_SOURCES = libvirt.syms libvirt.syms: libvirt_public.syms $(USED_SYM_FILES) - rm -f $@-tmp $@ - printf '# WARNING: generated from the following:\n# $^\n\n' >$@-tmp - cat $(srcdir)/libvirt_public.syms >>$@-tmp - printf '\n\n# Private symbols\n\n' >>$@-tmp - printf 'LIBVIRT_PRIVATE_$(VERSION) {\n\n' >>$@-tmp - printf 'global:\n\n' >>$@-tmp + $(AM_V_GEN)rm -f $@-tmp $@ ; \ + printf '# WARNING: generated from the following:\n# $^\n\n' >$@-tmp && \ + cat $(srcdir)/libvirt_public.syms >>$@-tmp && \ + printf '\n\n# Private symbols\n\n' >>$@-tmp && \ + printf 'LIBVIRT_PRIVATE_$(VERSION) {\n\n' >>$@-tmp && \ + printf 'global:\n\n' >>$@-tmp && \ for file in $(USED_SYM_FILES); do \ cat $(srcdir)/$$file >>$@-tmp; \ - done - printf '\n\nlocal:\n*;\n\n};' >>$@-tmp - chmod a-w $@-tmp + done && \ + printf '\n\nlocal:\n*;\n\n};' >>$@-tmp && \ + chmod a-w $@-tmp && \ mv $@-tmp libvirt.syms # Empty source list - it merely links a bunch of convenience libs together diff --git a/tools/Makefile.am b/tools/Makefile.am index 46107f6..33a3216 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -17,18 +17,18 @@ man1_MANS = virt-xml-validate.1 virt-pki-validate.1 virsh.1 virt-xml-validate: virt-xml-validate.in Makefile - sed -e 's,@SCHEMADIR@,$(pkgdatadir)/schemas,' < $< > $@ || (rm $@ && exit 1) - chmod +x $@ + $(AM_V_GEN)sed -e 's,@SCHEMADIR@,$(pkgdatadir)/schemas,' < $< > $@ \ + || (rm $@ && exit 1) && chmod +x $@ virt-xml-validate.1: virt-xml-validate - $(POD2MAN) $< $@ + $(AM_V_GEN)$(POD2MAN) $< $@ virt-pki-validate: virt-pki-validate.in Makefile - sed -e 's,@SYSCONFDIR@,$(sysconfdir),' < $< > $@ || (rm $@ && exit 1) - chmod +x $@ + $(AM_V_GEN)sed -e 's,@SYSCONFDIR@,$(sysconfdir),' < $< > $@ \ + || (rm $@ && exit 1) && chmod +x $@ virt-pki-validate.1: virt-pki-validate - $(POD2MAN) $< $@ + $(AM_V_GEN)$(POD2MAN) $< $@ virsh_SOURCES = \ console.c console.h \ @@ -55,24 +55,24 @@ virsh_CFLAGS = \ BUILT_SOURCES = virsh-net-edit.c virsh-pool-edit.c virsh-net-edit.c: virsh.c Makefile.am - rm -f $@-tmp - echo '/* Automatically generated from: $^ */' > $@-tmp - echo 'static int' >> $@-tmp + $(AM_V_GEN)rm -f $@-tmp && \ + echo '/* Automatically generated from: $^ */' > $@-tmp && \ + echo 'static int' >> $@-tmp && \ awk '/^cmdEdit/, /^}/' $< \ | sed -e 's/domain/network/g' \ -e 's/Domain/Network/g' \ -e 's/cmdEdit/cmdNetworkEdit/g' \ -e 's/dom/network/g' \ -e 's/int flags.*/int flags = 0;/g' \ - >> $@-tmp - chmod a-w $@-tmp - rm -f $@ + >> $@-tmp && \ + chmod a-w $@-tmp && \ + rm -f $@ && \ mv $@-tmp $@ virsh-pool-edit.c: virsh.c Makefile.am - rm -f $@-tmp - echo '/* Automatically generated from: $^ */' > $@-tmp - echo 'static int' >> $@-tmp + $(AM_V_GEN)rm -f $@-tmp && \ + echo '/* Automatically generated from: $^ */' > $@-tmp && \ + echo 'static int' >> $@-tmp && \ awk '/^cmdEdit/, /^}/' $< \ | sed -e 's/domain/pool/g' \ -e 's/vshCommandOptDomain/vshCommandOptPool/g' \ @@ -83,9 +83,9 @@ virsh-pool-edit.c: virsh.c Makefile.am -e 's/$virStoragePoolDefineXML.*$);/\1, 0);/' \ -e 's/dom/pool/g' \ -e 's/int flags.*/int flags = 0;/g' \ - >> $@-tmp - chmod a-w $@-tmp - rm -f $@ + >> $@-tmp && \ + chmod a-w $@-tmp && \ + rm -f $@ && \ mv $@-tmp $@ @@ -110,13 +110,13 @@ virsh_LDADD += virsh_win_icon.$(OBJEXT) # information is needed in this area. virsh_win_icon.$(OBJEXT): virsh_win_icon.rc - $(WINDRES) \ + $(AM_V_GEN)$(WINDRES) \ --input-format rc --input $< \ --output-format coff --output $@ endif virsh.1: virsh.pod - $(POD2MAN) $< $@ + $(AM_V_GEN)$(POD2MAN) $< $@ CLEANFILES = $(bin_SCRIPTS) $(man1_MANS) -- 1.6.2.5

2 1

[libvirt] failed to connect to the hypervisor
by Ameya Pandit 31 Mar '10

31 Mar '10

Hi, I have KVM qemu installed on Fedora 12 host server. My VMs are marked to autostart. When I reboot my host server the virtual machines starts but halts on its bios display screen. If I login mannually destroy the VMs and start again, it just works without any errors. Can someone please help me with this issue ? error logs I found are this : Starting libvirtd daemon: [ OK ] error: unable to connect to '/var/run/libvirt/libvirt-sock': No such file or directory error: failed to connect to the hypervisor some more info : virsh capabilities <capabilities> <host> <cpu> <arch>i686</arch> </cpu> <migration_features> <live/> <uri_transports> <uri_transport>tcp</uri_transport> </uri_transports> </migration_features> </host> <guest> <os_type>hvm</os_type> <arch name='i686'> <wordsize>32</wordsize> <emulator>/usr/bin/qemu</emulator> <machine>pc-0.11</machine> <machine canonical='pc-0.11'>pc</machine> <machine>pc-0.10</machine> <machine>isapc</machine> <domain type='qemu'> </domain> <domain type='kvm'> <emulator>/usr/bin/qemu-kvm</emulator> <machine>pc-0.11</machine> <machine canonical='pc-0.11'>pc</machine> <machine>pc-0.10</machine> <machine>isapc</machine> </domain> </arch> <features> <pae/> <nonpae/> <acpi default='on' toggle='yes'/> <apic default='on' toggle='no'/> </features> </guest> <guest> <os_type>hvm</os_type> <arch name='x86_64'> <wordsize>64</wordsize> <emulator>/usr/bin/qemu-system-x86_64</emulator> <machine>pc-0.11</machine> <machine canonical='pc-0.11'>pc</machine> <machine>pc-0.10</machine> <machine>isapc</machine> <domain type='qemu'> </domain> </arch> <features> <acpi default='on' toggle='yes'/> <apic default='on' toggle='no'/> </features> </guest> </capabilities> Kindly let me know if any more information required inorder to fix this issue. -- Regards, Ameya Pandit Buzz: 90040 27390 | www.ameyapandit.com

1 0

[libvirt] [PATCH] Add virt-aa-helper and secaatest to .gitignore
by Matthias Bolte 31 Mar '10

31 Mar '10

--- src/.gitignore | 1 + tests/.gitignore | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/.gitignore b/src/.gitignore index 26b8689..e407dcb 100644 --- a/src/.gitignore +++ b/src/.gitignore @@ -15,3 +15,4 @@ libvirt_lxc libvirt.syms *.i *.s +virt-aa-helper diff --git a/tests/.gitignore b/tests/.gitignore index 399baee..387a924 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -33,3 +33,4 @@ object-locking-files.txt esxutilstest vmx2xmltest xml2vmxtest +secaatest -- 1.6.3.3

1 0

[libvirt] Vserver support in Libvirt
by Chaitra Gorantla 31 Mar '10

31 Mar '10

Hi all, I am using libvirt for managing KVM. I would also like to manage Vserver using libvirt. Is there any patch available for vserver ? When will libvirt release official patch for vserver? Thanks, Chaitra Regards, Chaitra GN "I don't think anything is unrealistic if you believe you can do it" ________________________________ This Email may contain confidential or privileged information for the intended recipient (s) If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system. ______________________________________________________________________

2 1

[libvirt] Vserver patch for Libvirt
by Chaitra Gorantla 31 Mar '10

31 Mar '10

Hi all, I am using libvirt for managing KVM. I would also like to manage Vserver also using libvirt. Is there any patch available for vserver ? When will libvirt relase official patch for vserver? Thanks, Chaitra ________________________________ This Email may contain confidential or privileged information for the intended recipient (s) If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system. ______________________________________________________________________

2 2

[libvirt] [PATCH] nwfilter: fix some make dist/built/rpm issues
by Daniel Veillard 31 Mar '10

31 Mar '10

Here is a couple of patches related to make dist, then build from resulting tarball and rpm building. The first one adds a few missing header files in the associated file variables, it's needed otherwise the missing headers would break compilation from a distribution tarball The second one handles the xml filter files, first they need to be added to EXTRA_DIST from their Makefile.am otherwise they are missing from the tarball, and second that set of file in /etc/ need to be listed in the rpm spec file, associated with the main libvirt rpm (i.e. where the daemon resides as it's useless with just the client). I think those are fairly uncontroversial and are needed to not break the distribution, but I will probably commit those tomorrow, in case someone points out something stupid :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

1 1

[libvirt] [PATCH] nwfilter: Make entries in a int-2-string map more readable
by Stefan Berger 31 Mar '10

31 Mar '10

A cosmetic change that makes the entries in the int-2-string maps look more readable. Add some missing entries. Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com> --- src/conf/nwfilter_conf.c | 97 +++++++++++++---------------------------------- 1 file changed, 28 insertions(+), 69 deletions(-) Index: libvirt-acl/src/conf/nwfilter_conf.c =================================================================== --- libvirt-acl.orig/src/conf/nwfilter_conf.c +++ libvirt-acl/src/conf/nwfilter_conf.c @@ -105,6 +105,9 @@ struct int_map { const char *val; }; +#define INTMAP_ENTRY(ATT, VAL) { .attr = ATT, .val = VAL } +#define INTMAP_ENTRY_LAST { .val = NULL } + /* * only one filter update allowed @@ -388,18 +391,10 @@ struct _virXMLAttr2Struct static const struct int_map macProtoMap[] = { - { - .attr = ETHERTYPE_ARP, - .val = "arp", - }, { - .attr = ETHERTYPE_IP, - .val = "ipv4", - }, { - .attr = ETHERTYPE_IPV6, - .val = "ipv6", - }, { - .val = NULL, - } + INTMAP_ENTRY(ETHERTYPE_ARP , "arp"), + INTMAP_ENTRY(ETHERTYPE_IP , "ipv4"), + INTMAP_ENTRY(ETHERTYPE_IPV6, "ipv6"), + INTMAP_ENTRY_LAST }; @@ -486,36 +481,16 @@ checkMACMask(enum attrDatatype datatype * supported arp opcode -- see 'ebtables -h arp' for the naming */ static const struct int_map arpOpcodeMap[] = { - { - .attr = 1, - .val = "Request", - } , { - .attr = 2, - .val = "Reply", - } , { - .attr = 3, - .val = "Request_Reverse", - } , { - .attr = 4, - .val = "Reply_Reverse", - } , { - .attr = 5, - .val = "DRARP_Request", - } , { - .attr = 6, - .val = "DRARP_Reply", - } , { - .attr = 7, - .val = "DRARP_Error", - } , { - .attr = 8, - .val = "InARP_Request", - } , { - .attr = 9, - .val = "ARP_NAK", - } , { - .val = NULL, - } + INTMAP_ENTRY(1, "Request"), + INTMAP_ENTRY(2, "Reply"), + INTMAP_ENTRY(3, "Request_Reverse"), + INTMAP_ENTRY(4, "Reply_Reverse"), + INTMAP_ENTRY(5, "DRARP_Request"), + INTMAP_ENTRY(6, "DRARP_Reply"), + INTMAP_ENTRY(7, "DRARP_Error"), + INTMAP_ENTRY(8, "InARP_Request"), + INTMAP_ENTRY(9, "ARP_NAK"), + INTMAP_ENTRY_LAST }; @@ -562,37 +537,21 @@ arpOpcodeFormatter(virBufferPtr buf, static const struct int_map ipProtoMap[] = { - { - .attr = IPPROTO_TCP, - .val = "tcp", - } , { - .attr = IPPROTO_UDP, - .val = "udp", + INTMAP_ENTRY(IPPROTO_TCP, "tcp"), + INTMAP_ENTRY(IPPROTO_UDP, "udp"), #ifdef IPPROTO_UDPLITE - } , { - .attr = IPPROTO_UDPLITE, - .val = "udplite", + INTMAP_ENTRY(IPPROTO_UDPLITE, "udplite"), #endif - } , { - .attr = IPPROTO_ESP, - .val = "esp", - } , { - .attr = IPPROTO_AH, - .val = "ah", - } , { - .attr = IPPROTO_ICMP, - .val = "icmp", - } , { - .attr = IPPROTO_IGMP, - .val = "igmp", + INTMAP_ENTRY(IPPROTO_ESP, "esp"), + INTMAP_ENTRY(IPPROTO_AH, "ah"), + INTMAP_ENTRY(IPPROTO_ICMP, "icmp"), + INTMAP_ENTRY(IPPROTO_IGMP, "igmp"), #ifdef IPPROTO_SCTP - } , { - .attr = IPPROTO_SCTP, - .val = "sctp", + INTMAP_ENTRY(IPPROTO_SCTP, "sctp"), #endif - } , { - .val = NULL, - } + INTMAP_ENTRY(IPPROTO_IPV6, "ipv6"), + INTMAP_ENTRY(IPPROTO_ICMPV6, "icmpv6"), + INTMAP_ENTRY_LAST };

4 6

[libvirt] CfP with Extended Deadline 5th Workshop on Virtualization in High-Performance Cloud Computing (VHPC'10)
by Michael Alexander 31 Mar '10

31 Mar '10

Apologies if you received multiple copies of this message. ================================================================= CALL FOR PAPERS 5th Workshop on Virtualization in High-Performance Cloud Computing VHPC'10 as part of Euro-Par 2010, Island of Ischia-Naples, Italy ================================================================= Date: August 31, 2010 Euro-Par 2009: http://www.europar2010.org/ Workshop URL: http://vhpc.org SUBMISSION DEADLINE: Abstracts: April 4, 2010 (extended) Full Paper: June 19, 2010 (extended) Scope: Virtualization has become a common abstraction layer in modern data centers, enabling resource owners to manage complex infrastructure independently of their applications. Conjointly virtualization is becoming a driving technology for a manifold of industry grade IT services. Piloted by the Amazon Elastic Computing Cloud services, the cloud concept includes the notion of a separation between resource owners and users, adding services such as hosted application frameworks and queuing. Utilizing the same infrastructure, clouds carry significant potential for use in high-performance scientific computing. The ability of clouds to provide for requests and releases of vast computing resource dynamically and close to the marginal cost of providing the services is unprecedented in the history of scientific and commercial computing. Distributed computing concepts that leverage federated resource access are popular within the grid community, but have not seen previously desired deployed levels so far. Also, many of the scientific datacenters have not adopted virtualization or cloud concepts yet. This workshop aims to bring together industrial providers with the scientific community in order to foster discussion, collaboration and mutual exchange of knowledge and experience. The workshop will be one day in length, composed of 20 min paper presentations, each followed by 10 min discussion sections. Presentations may be accompanied by interactive demonstrations. It concludes with a 30 min panel discussion by presenters. TOPICS Topics include, but are not limited to, the following subjects: - Virtualization in cloud, cluster and grid HPC environments - VM cloud, cluster load distribution algorithms - Cloud, cluster and grid filesystems - QoS and and service level guarantees - Cloud programming models, APIs and databases - Software as a service (SaaS) - Cloud provisioning - Virtualized I/O - VMMs and storage virtualization - MPI, PVM on virtual machines - High-performance network virtualization - High-speed interconnects - Hypervisor extensions - Tools for cluster and grid computing - Xen/other VMM cloud/cluster/grid tools - Raw device access from VMs - Cloud reliability, fault-tolerance, and security - Cloud load balancing - VMs - power efficiency - Network architectures for VM-based environments - VMMs/Hypervisors - Hardware support for virtualization - Fault tolerant VM environments - Workload characterizations for VM-based environments - Bottleneck management - Metering - VM-based cloud performance modeling - Cloud security, access control and data integrity - Performance management and tuning hosts and guest VMs - VMM performance tuning on various load types - Research and education use cases - Cloud use cases - Management of VM environments and clouds - Deployment of VM-based environments PAPER SUBMISSION Papers submitted to the workshop will be reviewed by at least two members of the program committee and external reviewers. Submissions should include abstract, key words, the e-mail address of the corresponding author, and must not exceed 10 pages, including tables and figures at a main font size no smaller than 11 point. Submission of a paper should be regarded as a commitment that, should the paper be accepted, at least one of the authors will register and attend the conference to present the work. Accepted papers will be published in the Springer LNCS series - the format must be according to the Springer LNCS Style. Initial submissions are in PDF, accepted papers will be requested to provided source files. Format Guidelines: http://www.springer.de/comp/lncs/authors.html Submission Link: http://edas.info/newPaper.php?c=8553 IMPORTANT DATES April 4 - Abstract submission due (extended) May 19 - Full paper submission (extended) July 14 - Acceptance notification August 3 - Camera-ready version due August 31 - September 3 - conference CHAIR Michael Alexander (chair), scaledinfra technologies GmbH, Austria Gianluigi Zanetti (co-chair), CRS4, Italy PROGRAM COMMITTEE Padmashree Apparao, Intel Corp., USA Volker Buege, University of Karlsruhe, Germany Roberto Canonico, University of Napoli Federico II, Italy Tommaso Cucinotta, Scuola Superiore Sant'Anna, Italy Werner Fischer, Thomas Krenn AG, Germany William Gardner, University of Guelph, Canada Wolfgang Gentzsch, DEISA. Max Planck Gesellschaft, Germany Derek Groen, UVA, The Netherlands Marcus Hardt, Forschungszentrum Karlsruhe, Germany Sverre Jarp, CERN, Switzerland Shantenu Jha, Louisiana State University, USA Xuxian Jiang, NC State, USA Kenji Kaneda, Google, Japan Yves Kemp, DESY Hamburg, Germany Ignacio Llorente, Universidad Complutense de Madrid, Spain Naoya Maruyama, Tokyo Institute of Technology, Japan Jean-Marc Menaud, Ecole des Mines de Nantes, France Anastassios Nano, National Technical University of Athens, Greece Oliver Oberst, Karlsruhe Institute of Technology, Germany Jose Renato Santos, HP Labs, USA Borja Sotomayor, University of Chicago, USA Yoshio Turner, HP Labs, USA Kurt Tuschku, University of Vienna, Austria Lizhe Wang, Indiana University, USA Chao-Tung Yang, Tunghai University, Taiwan DURATION: Workshop Duration is one day. GENERAL INFORMATION The workshop will be held as part of Euro-Par 2010, Island of Ischia-Naples, Italy. Euro-Par 2010: http://www.europar2010.org/

1 0

[libvirt] ESX snapshot deletion
by Chris Lalancette 31 Mar '10

31 Mar '10

Hey Mattias, I'm currently working on the semantics of virDomainSnapshotDelete(), which has been renamed from the earlier virDomainSnapshotDeactivate(). In qemu/kvm, it seems like it is possible to delete a snapshot at any time, even while that snapshot is running (though I'm not yet sure exactly what happens in that case). Talking to Jirka, it seems like the virtualbox GUI doesn't allow you to do any operations at all on snapshots while a domain is running, although we don't know yet if this is a restriction in the API as well. My questions for you are about how ESX handles this situation: 1) Can you manipulate a domain's snapshots while that domain is running? 2) If so, can you delete the snapshot that is currently running? If so, what happens? -- Chris Lalancette

2 2

[libvirt] [PATCH 1/2] build: update gnulib
by Eric Blake 31 Mar '10

31 Mar '10

Picks up fixes for gethostname compilation problems on mingw. * .gnulib: Update to latest. * build-aux/.gitignore: Regenerate. * cfg.mk (local-checks-to-skip): Avoid new test not relevent to libvirt. --- This replaces https://www.redhat.com/archives/libvir-list/2010-March/msg00915.html, and should fix the issues Matthias was seeing with compiling gnulib on mingw. .gnulib | 2 +- build-aux/.gitignore | 1 + cfg.mk | 1 + 3 files changed, 3 insertions(+), 1 deletions(-) diff --git a/.gnulib b/.gnulib index 10d66ae..4f01268 160000 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit 10d66aedfdd610f731c8c54152b9dfca3efbee12 +Subproject commit 4f01268d0c584c20704e42527f4fa125e7525aae diff --git a/build-aux/.gitignore b/build-aux/.gitignore index 29b1e03..8717628 100644 --- a/build-aux/.gitignore +++ b/build-aux/.gitignore @@ -6,6 +6,7 @@ /useless-if-before-free /vc-list-files arg-nonnull.h +c++defs.h config.rpath gitlog-to-changelog mkinstalldirs diff --git a/cfg.mk b/cfg.mk index 27cfca4..0c41ae5 100644 --- a/cfg.mk +++ b/cfg.mk @@ -51,6 +51,7 @@ local-checks-to-skip = \ sc_space_tab \ sc_sun_os_names \ sc_system_h_headers \ + sc_texinfo_acronym \ sc_tight_scope \ sc_two_space_separator_in_usage \ sc_error_message_uppercase \ -- 1.6.6.1

2 6

[libvirt] [PATCH] maint: show which compiler warning triggered
by Eric Blake 31 Mar '10

31 Mar '10

* acinclude.m4 (LIBVIRT_COMPILE_WARNINGS): Add -fdiagnostics-show-option. --- Here's an example of how things change, when using './configure --enable-compiler-warnings=error' and introducing something gcc would warn about: CC libvirt_driver_nwfilter_la-nwfilter_ebiptables_driver.lo cc1: warnings being treated as errors nwfilter/nwfilter_ebiptables_driver.c: In function '_iptablesCreateRuleInstance': nwfilter/nwfilter_ebiptables_driver.c:1059: error: unused variable 'oops' [-Wunused-variable] acinclude.m4 | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index f00933f..7fa2d67 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -13,13 +13,17 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[ dnl ****************************** AC_ARG_ENABLE(compile-warnings, - AC_HELP_STRING([--enable-compile-warnings=@<:@no/minimum/yes/maximum/error@:>@], - [Turn on compiler warnings]),, + [AC_HELP_STRING([--enable-compile-warnings=@<:@no/minimum/yes/maximum/error@:>@], + [Turn on compiler warnings])],, [enable_compile_warnings="m4_default([$1],[maximum])"]) warnCFLAGS= - common_flags="-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fasynchronous-unwind-tables" + common_flags= + common_flags="$common_flags -Wp,-D_FORTIFY_SOURCE=2" + common_flags="$common_flags -fexceptions" + common_flags="$common_flags -fasynchronous-unwind-tables" + common_flags="$common_flags -fdiagnostics-show-option" case "$enable_compile_warnings" in no) -- 1.6.6.1

2 1

[libvirt] [PATCH] Add dummy nwfilter driver to test driver
by Stefan Berger 31 Mar '10

31 Mar '10

This patch adds a dummy nwfilter driver to the test driver so that the int-overflow test passes without modifications. Signed-off-by: Stefan Berger <Stefanb(a)us.ibm.com> Index: libvirt/src/test/test_driver.c =================================================================== --- libvirt.orig/src/test/test_driver.c +++ libvirt/src/test/test_driver.c @@ -5205,6 +5205,22 @@ static int testSecretClose(virConnectPtr return 0; } + +static virDrvOpenStatus testNWFilterOpen(virConnectPtr conn, + virConnectAuthPtr auth ATTRIBUTE_UNUSED, + int flags ATTRIBUTE_UNUSED) { + if (STRNEQ(conn->driver->name, "Test")) + return VIR_DRV_OPEN_DECLINED; + + conn->secretPrivateData = conn->privateData; + return VIR_DRV_OPEN_SUCCESS; +} + +static int testNWFilterClose(virConnectPtr conn) { + conn->nwfilterPrivateData = NULL; + return 0; +} + static virDriver testDriver = { VIR_DRV_TEST, "Test", @@ -5398,6 +5414,12 @@ static virSecretDriver testSecretDriver }; +static virNWFilterDriver testNWFilterDriver = { + .name = "Test", + .open = testNWFilterOpen, + .close = testNWFilterClose, +}; + /** * testRegister: * @@ -5418,6 +5440,8 @@ testRegister(void) return -1; if (virRegisterSecretDriver(&testSecretDriver) < 0) return -1; + if (virRegisterNWFilterDriver(&testNWFilterDriver) < 0) + return -1; return 0; }

4 4

[libvirt] [PATCH] Use libvirt's existing ipv6/ipv4 parser/printer rather than self-written ones
by Stefan Berger 31 Mar '10

31 Mar '10

This patch changes the network filtering code to use libvirt's existing IPv4 and IPv6 address parsers/printers rather than my self-written ones. I am introducing a new function in network.c that counts the number of bits in a netmask and ensures that the given address is indeed a netmask, return -1 on error or values of 0-32 for IPv4 addresses and 0-128 for IPv6 addresses. I then based the function checking for valid netmask on invoking this function. Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com> --- src/conf/nwfilter_conf.c | 181 ++---------------------------- src/conf/nwfilter_conf.h | 8 - src/nwfilter/nwfilter_ebiptables_driver.c | 46 ++++--- src/util/network.c | 173 +++++++++++++++------------- src/util/network.h | 3 5 files changed, 142 insertions(+), 269 deletions(-) Index: libvirt-acl/src/conf/nwfilter_conf.h =================================================================== --- libvirt-acl.orig/src/conf/nwfilter_conf.h +++ libvirt-acl/src/conf/nwfilter_conf.h @@ -33,6 +33,8 @@ # include "util.h" # include "hash.h" # include "xml.h" +# include "network.h" + /** * Chain suffix size is: @@ -85,11 +87,7 @@ struct _nwMACAddress { typedef struct _nwIPAddress nwIPAddress; typedef nwIPAddress *nwIPAddressPtr; struct _nwIPAddress { - int isIPv6; - union { - unsigned char ipv4Addr[4]; - unsigned char ipv6Addr[16]; - } addr; + virSocketAddr addr; }; Index: libvirt-acl/src/util/network.c =================================================================== --- libvirt-acl.orig/src/util/network.c +++ libvirt-acl/src/util/network.c @@ -219,88 +219,10 @@ virSocketGetPort(virSocketAddrPtr addr) * Returns 0 in case of success and -1 in case of error */ int virSocketAddrIsNetmask(virSocketAddrPtr netmask) { - int i; - - if (netmask == NULL) - return(-1); - - if (netmask->stor.ss_family == AF_INET) { - virIPv4Addr tm; - unsigned char tmp; - int ok = 0; - - if (getIPv4Addr(netmask, &tm) < 0) - return(-1); - - for (i = 0;i < 4;i++) { - if (tm[i] != 0) - break; - } - - if (i >= 4) - return(0); - - tmp = 0xFF; - do { - if (tm[i] == tmp) { - ok = 1; - break; - } - tmp <<= 1; - } while (tmp != 0); - if (ok == 0) - return(-1); - i++; - - if (i >= 4) - return(0); - - for (;i < 4;i++) { - if (tm[i] != 0xFF) - return(-1); - } - } else if (netmask->stor.ss_family == AF_INET6) { - virIPv6Addr tm; - unsigned short tmp; - int ok = 0; - - /* - * Hum, on IPv6 people use prefixes instead of netmask - */ - if (getIPv6Addr(netmask, &tm) < 0) - return(-1); - - for (i = 0;i < 8;i++) { - if (tm[i] != 0) - break; - } - - if (i >= 8) - return(0); - - tmp = 0xFFFF; - do { - if (tm[i] == tmp) { - ok = 1; - break; - } - tmp <<= 1; - } while (tmp != 0); - if (ok == 0) - return(-1); - i++; - - if (i >= 8) - return(0); - - for (;i < 8;i++) { - if (tm[i] != 0xFFFF) - return(-1); - } - } else { - return(-1); - } - return(0); + int n = virSocketGetNumNetmaskBits(netmask); + if (n < 0) + return -1; + return 0; } /** @@ -415,3 +337,90 @@ int virSocketGetRange(virSocketAddrPtr s } return(ret); } + + +/** + * virGetNumNetmaskBits + * @netmask: the presumed netmask + * + * Get the number of netmask bits in a netmask. + * + * Returns the number of bits in the netmask or -1 if an error occurred + * or the netmask is invalid. + */ +int virSocketGetNumNetmaskBits(const virSocketAddrPtr netmask) +{ + int i, j; + int c = 0; + + if (netmask->stor.ss_family == AF_INET) { + virIPv4Addr tm; + uint8_t bit; + + if (getIPv4Addr(netmask, &tm) < 0) + return -1; + + for (i = 0; i < 4; i++) + if (tm[i] == 0xff) + c += 8; + else + break; + + if (c == 8 * 4) + return c; + + j = i << 3; + while (j < (8 * 4)) { + bit = 1 << (7 - (j & 7)); + if ((tm[j >> 3] & bit)) { + c++; + } else + break; + j++; + } + + while (j < (8 * 4)) { + bit = 1 << (7 - (j & 7)); + if ((tm[j >> 3] & bit)) + return -1; + j++; + } + + return c; + } else if (netmask->stor.ss_family == AF_INET6) { + virIPv6Addr tm; + uint16_t bit; + + if (getIPv6Addr(netmask, &tm) < 0) + return -1; + + for (i = 0; i < 8; i++) + if (tm[i] == 0xffff) + c += 16; + else + break; + + if (c == 16 * 8) + return c; + + j = i << 4; + while (j < (16 * 8)) { + bit = 1 << (15 - (j & 0xf)); + if ((tm[j >> 4] & bit)) { + c++; + } else + break; + j++; + } + + while (j < (16 * 8)) { + bit = 1 << (15 - (j & 0xf)); + if ((tm[j >> 4]) & bit) + return -1; + j++; + } + + return c; + } + return -1; +} Index: libvirt-acl/src/util/network.h =================================================================== --- libvirt-acl.orig/src/util/network.h +++ libvirt-acl/src/util/network.h @@ -48,4 +48,7 @@ int virSocketAddrIsNetmask(virSocketAddr int virSocketCheckNetmask (virSocketAddrPtr addr1, virSocketAddrPtr addr2, virSocketAddrPtr netmask); + +int virSocketGetNumNetmaskBits(const virSocketAddrPtr netmask); + #endif /* __VIR_NETWORK_H__ */ Index: libvirt-acl/src/conf/nwfilter_conf.c =================================================================== --- libvirt-acl.orig/src/conf/nwfilter_conf.c +++ libvirt-acl/src/conf/nwfilter_conf.c @@ -473,22 +473,6 @@ checkValidMask(unsigned char *data, int } -/* check for a valid IPv4 mask */ -static bool -checkIPv4Mask(enum attrDatatype datatype ATTRIBUTE_UNUSED, void *maskptr, - virNWFilterRuleDefPtr nwf ATTRIBUTE_UNUSED) -{ - return checkValidMask(maskptr, 4); -} - -static bool -checkIPv6Mask(enum attrDatatype datatype ATTRIBUTE_UNUSED, void *maskptr, - virNWFilterRuleDefPtr nwf ATTRIBUTE_UNUSED) -{ - return checkValidMask(maskptr, 16); -} - - static bool checkMACMask(enum attrDatatype datatype ATTRIBUTE_UNUSED, void *macMask, @@ -498,16 +482,6 @@ checkMACMask(enum attrDatatype datatype } -static int getMaskNumBits(const unsigned char *mask, int len) { - int i = 0; - while (i < (len << 3)) { - if (!(mask[i>>3] & (0x80 >> (i & 3)))) - break; - i++; - } - return i; -} - /* * supported arp opcode -- see 'ebtables -h arp' for the naming */ @@ -1227,21 +1201,8 @@ static bool virNWIPv4AddressParser(const char *input, nwIPAddressPtr output) { - int i; - char *endptr; - const char *n = input; - long int d; - - for (i = 0; i < 4; i++) { - d = strtol(n, &endptr, 10); - if (d < 0 || d > 255 || - (endptr - n > 3 ) || - (i <= 2 && *endptr != '.' ) || - (i == 3 && *endptr != '\0')) - return 0; - output->addr.ipv4Addr[i] = (unsigned char)d; - n = endptr + 1; - } + if (virSocketParseIpv4Addr(input, &output->addr) == -1) + return 0; return 1; } @@ -1250,81 +1211,8 @@ static bool virNWIPv6AddressParser(const char *input, nwIPAddressPtr output) { - int i, j, pos; - uint16_t n; - int shiftpos = -1; - char prevchar; - char base; - - memset(output, 0x0, sizeof(*output)); - - output->isIPv6 = 1; - - pos = 0; - i = 0; - - while (i < 8) { - j = 0; - n = 0; - while (1) { - prevchar = input[pos++]; - if (prevchar == ':' || prevchar == 0) { - if (j > 0) { - output->addr.ipv6Addr[i * 2 + 0] = n >> 8; - output->addr.ipv6Addr[i * 2 + 1] = n; - i++; - } - break; - } - - if (j >= 4) - return 0; - - if (prevchar >= '0' && prevchar <= '9') - base = '0'; - else if (prevchar >= 'a' && prevchar <= 'f') - base = 'a' - 10; - else if (prevchar >= 'A' && prevchar <= 'F') - base = 'A' - 10; - else - return 0; - n <<= 4; - n |= (prevchar - base); - j++; - } - - if (prevchar == 0) - break; - - if (input[pos] == ':') { - pos ++; - // sequence of zeros - if (prevchar != ':') - return 0; - - if (shiftpos != -1) - return 0; - - shiftpos = i; - } - } - - if (shiftpos != -1) { - if (i >= 7) - return 0; - i--; - j = 0; - while (i >= shiftpos) { - output->addr.ipv6Addr[15 - (j*2) - 1] = - output->addr.ipv6Addr[i * 2 + 0]; - output->addr.ipv6Addr[15 - (j*2) - 0] = - output->addr.ipv6Addr[i * 2 + 1]; - output->addr.ipv6Addr[i * 2 + 0] = 0; - output->addr.ipv6Addr[i * 2 + 1] = 0; - i--; - j++; - } - } + if (virSocketParseIpv6Addr(input, &output->addr) == -1) + return 0; return 1; } @@ -1442,11 +1330,10 @@ virNWFilterRuleDetailsParse(virConnectPt } else rc = -1; } else { - if (checkIPv4Mask(datatype, - ipaddr.addr.ipv4Addr, nwf)) - *(uint8_t *)storage_ptr = - getMaskNumBits(ipaddr.addr.ipv4Addr, - sizeof(ipaddr.addr.ipv4Addr)); + int_val = virSocketGetNumNetmaskBits( + &ipaddr.addr); + if (int_val >= 0) + *(uint8_t *)storage_ptr = int_val; else rc = -1; found = 1; @@ -1497,11 +1384,10 @@ virNWFilterRuleDetailsParse(virConnectPt } else rc = -1; } else { - if (checkIPv6Mask(datatype, - ipaddr.addr.ipv6Addr, nwf)) - *(uint8_t *)storage_ptr = - getMaskNumBits(ipaddr.addr.ipv6Addr, - sizeof(ipaddr.addr.ipv6Addr)); + int_val = virSocketGetNumNetmaskBits( + &ipaddr.addr); + if (int_val >= 0) + *(uint8_t *)storage_ptr = int_val; else rc = -1; found = 1; @@ -2571,43 +2457,12 @@ virNWFilterPoolObjDeleteDef(virConnectPt static void virNWIPAddressFormat(virBufferPtr buf, nwIPAddressPtr ipaddr) { - if (!ipaddr->isIPv6) { - virBufferVSprintf(buf, "%d.%d.%d.%d", - ipaddr->addr.ipv4Addr[0], - ipaddr->addr.ipv4Addr[1], - ipaddr->addr.ipv4Addr[2], - ipaddr->addr.ipv4Addr[3]); - } else { - int i; - int dcshown = 0, in_dc = 0; - unsigned short n; - while (i < 8) { - n = (ipaddr->addr.ipv6Addr[i * 2 + 0] << 8) | - ipaddr->addr.ipv6Addr[i * 2 + 1]; - if (n == 0) { - if (!dcshown) { - in_dc = 1; - if (i == 0) - virBufferAddLit(buf, ":"); - dcshown = 1; - } - if (in_dc) { - i++; - continue; - } - } - if (in_dc) { - dcshown = 1; - virBufferAddLit(buf, ":"); - in_dc = 0; - } - i++; - virBufferVSprintf(buf, "%x", n); - if (i < 8) - virBufferAddLit(buf, ":"); - } - if (in_dc) - virBufferAddLit(buf, ":"); + virSocketAddrPtr addr = &ipaddr->addr; + char *output = virSocketFormatAddr(addr); + + if (output) { + virBufferVSprintf(buf, "%s", output); + VIR_FREE(output); } } Index: libvirt-acl/src/nwfilter/nwfilter_ebiptables_driver.c =================================================================== --- libvirt-acl.orig/src/nwfilter/nwfilter_ebiptables_driver.c +++ libvirt-acl/src/nwfilter/nwfilter_ebiptables_driver.c @@ -144,7 +144,7 @@ printDataType(virConnectPtr conn, nwItemDescPtr item) { int done; - int i, pos, s; + char *data; if (printVar(conn, vars, buf, bufsize, item, &done)) return 1; @@ -154,30 +154,38 @@ printDataType(virConnectPtr conn, switch (item->datatype) { case DATATYPE_IPADDR: - if (snprintf(buf, bufsize, "%d.%d.%d.%d", - item->u.ipaddr.addr.ipv4Addr[0], - item->u.ipaddr.addr.ipv4Addr[1], - item->u.ipaddr.addr.ipv4Addr[2], - item->u.ipaddr.addr.ipv4Addr[3]) >= bufsize) { - virNWFilterReportError(conn, VIR_ERR_INVALID_NWFILTER, - _("Buffer too small for IP address")); + data = virSocketFormatAddr(&item->u.ipaddr.addr); + if (!data) { + virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + _("internal IPv4 address representation " + "is bad")); + return 1; + } + if (snprintf(buf, bufsize, "%s", data) >= bufsize) { + virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + _("buffer too small for IP address")); + VIR_FREE(data); return 1; } + VIR_FREE(data); break; case DATATYPE_IPV6ADDR: - pos = 0; - for (i = 0; i < 16; i++) { - s = snprintf(&buf[pos], bufsize - pos, "%x%s", - (unsigned int)item->u.ipaddr.addr.ipv6Addr[i], - ((i & 1) && (i < 15)) ? ":" : "" ); - if (s >= bufsize - pos) { - virNWFilterReportError(conn, VIR_ERR_INVALID_NWFILTER, - _("Buffer too small for IPv6 address")); - return 1; - } - pos += s; + data = virSocketFormatAddr(&item->u.ipaddr.addr); + if (!data) { + virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + _("internal IPv6 address representation " + "is bad")); + return 1; + } + + if (snprintf(buf, bufsize, "%s", data) >= bufsize) { + virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + _("buffer too small for IPv6 address")); + VIR_FREE(data); + return 1; } + VIR_FREE(data); break; case DATATYPE_MACADDR:

2 1

[libvirt] [PATCH] Remove driver dependency from nwfilter_conf.c
by Stefan Berger 31 Mar '10

31 Mar '10

This patch removes the driver dependency from nwfilter_conf.c and moves a callback function calling into the driver into nwfilter_gentech_driver.c and passes a pointer to that callback function upon initialization of nwfilter_conf.c. Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com> Index: libvirt-acl/src/conf/nwfilter_conf.c =================================================================== --- libvirt-acl.orig/src/conf/nwfilter_conf.c +++ libvirt-acl/src/conf/nwfilter_conf.c @@ -39,7 +39,6 @@ #include "nwfilter_params.h" #include "nwfilter_conf.h" #include "domain_conf.h" -#include "nwfilter/nwfilter_gentech_driver.h" #define VIR_FROM_THIS VIR_FROM_NWFILTER @@ -2064,56 +2063,7 @@ virNWFilterRegisterCallbackDriver(virNWF } -enum UpdateStep { - STEP_APPLY_NEW, - STEP_TEAR_NEW, - STEP_TEAR_OLD, -}; - -struct cbStruct { - virConnectPtr conn; - enum UpdateStep step; - int err; -}; - -static void -virNWFilterDomainFWUpdateCB(void *payload, - const char *name ATTRIBUTE_UNUSED, - void *data) -{ - virDomainObjPtr obj = payload; - virDomainDefPtr vm = obj->def; - struct cbStruct *cb = data; - int i; - - virDomainObjLock(obj); - - if (virDomainObjIsActive(obj)) { - for (i = 0; i < vm->nnets; i++) { - virDomainNetDefPtr net = vm->nets[i]; - if ((net->filter) && (net->ifname)) { - switch (cb->step) { - case STEP_APPLY_NEW: - cb->err = virNWFilterUpdateInstantiateFilter(cb->conn, - net); - break; - - case STEP_TEAR_NEW: - cb->err = virNWFilterRollbackUpdateFilter(cb->conn, net); - break; - - case STEP_TEAR_OLD: - cb->err = virNWFilterTearOldFilter(cb->conn, net); - break; - } - if (cb->err) - break; - } - } - } - - virDomainObjUnlock(obj); -} +static virHashIterator virNWFilterDomainFWUpdateCB; static int @@ -2121,7 +2071,7 @@ virNWFilterTriggerVMFilterRebuild(virCon { int i; int err; - struct cbStruct cb = { + struct domUpdateCBStruct cb = { .conn = conn, .err = 0, .step = STEP_APPLY_NEW, @@ -2717,8 +2667,10 @@ char *virNWFilterConfigFile(virConnectPt } -int virNWFilterConfLayerInit(void) +int virNWFilterConfLayerInit(virHashIterator domUpdateCB) { + virNWFilterDomainFWUpdateCB = domUpdateCB; + if (virMutexInit(&updateMutex)) return 1; Index: libvirt-acl/src/conf/nwfilter_conf.h =================================================================== --- libvirt-acl.orig/src/conf/nwfilter_conf.h +++ libvirt-acl/src/conf/nwfilter_conf.h @@ -402,6 +402,19 @@ struct _virNWFilterRuleInst { }; +enum UpdateStep { + STEP_APPLY_NEW, + STEP_TEAR_NEW, + STEP_TEAR_OLD, +}; + +struct domUpdateCBStruct { + virConnectPtr conn; + enum UpdateStep step; + int err; +}; + + enum virDomainNetType; typedef int (*virNWFilterRuleCreateInstance)(virConnectPtr conn, @@ -516,7 +529,7 @@ virNWFilterDefPtr virNWFilterDefParseFil void virNWFilterPoolObjLock(virNWFilterPoolObjPtr obj); void virNWFilterPoolObjUnlock(virNWFilterPoolObjPtr obj); -int virNWFilterConfLayerInit(void); +int virNWFilterConfLayerInit(virHashIterator domUpdateCB); void virNWFilterConfLayerShutdown(void); int virNWFilterParamConfLayerInit(void); Index: libvirt-acl/src/nwfilter/nwfilter_driver.c =================================================================== --- libvirt-acl.orig/src/nwfilter/nwfilter_driver.c +++ libvirt-acl/src/nwfilter/nwfilter_driver.c @@ -34,6 +34,7 @@ #include "memory.h" #include "domain_conf.h" #include "nwfilter_driver.h" +#include "nwfilter_gentech_driver.h" #define VIR_FROM_THIS VIR_FROM_NWFILTER @@ -64,7 +65,7 @@ static int nwfilterDriverStartup(int privileged) { char *base = NULL; - if (virNWFilterConfLayerInit() < 0) + if (virNWFilterConfLayerInit(virNWFilterDomainFWUpdateCB) < 0) return -1; if (VIR_ALLOC(driverState) < 0) Index: libvirt-acl/src/nwfilter/nwfilter_gentech_driver.c =================================================================== --- libvirt-acl.orig/src/nwfilter/nwfilter_gentech_driver.c +++ libvirt-acl/src/nwfilter/nwfilter_gentech_driver.c @@ -681,3 +681,43 @@ virNWFilterTeardownFilter(const virDomai return 0; } + + +void +virNWFilterDomainFWUpdateCB(void *payload, + const char *name ATTRIBUTE_UNUSED, + void *data) +{ + virDomainObjPtr obj = payload; + virDomainDefPtr vm = obj->def; + struct domUpdateCBStruct *cb = data; + int i; + + virDomainObjLock(obj); + + if (virDomainObjIsActive(obj)) { + for (i = 0; i < vm->nnets; i++) { + virDomainNetDefPtr net = vm->nets[i]; + if ((net->filter) && (net->ifname)) { + switch (cb->step) { + case STEP_APPLY_NEW: + cb->err = virNWFilterUpdateInstantiateFilter(cb->conn, + net); + break; + + case STEP_TEAR_NEW: + cb->err = virNWFilterRollbackUpdateFilter(cb->conn, net); + break; + + case STEP_TEAR_OLD: + cb->err = virNWFilterTearOldFilter(cb->conn, net); + break; + } + if (cb->err) + break; + } + } + } + + virDomainObjUnlock(obj); +} Index: libvirt-acl/src/nwfilter/nwfilter_gentech_driver.h =================================================================== --- libvirt-acl.orig/src/nwfilter/nwfilter_gentech_driver.h +++ libvirt-acl/src/nwfilter/nwfilter_gentech_driver.h @@ -51,4 +51,8 @@ int virNWFilterTeardownFilter(const virD virNWFilterHashTablePtr virNWFilterCreateVarHashmap(virConnectPtr conn, char *macaddr); +void virNWFilterDomainFWUpdateCB(void *payload, + const char *name ATTRIBUTE_UNUSED, + void *data); + #endif

2 1

[libvirt] [PATCH] [0/6] implement synchronous hook scripts
by Daniel Veillard 30 Mar '10

30 Mar '10

As discussed previously this implement hook scripts which may be called from libvirtd at specific times. The script are supposed to be small, execute fast as it's synchronous, their exit value is 0 otherwise it's considered a failure (which may be ignored but in general will stops the ongoing operation). Scripts are stored under /etc/libvirt/hook/ (or rather $SYSCONF_DIR/libvirt/hook/) if missing no script invocation will ever be done. There is one script per 'driver' there is currently hooks for the daemon, qemu and lxc, so right now only /etc/libvirt/hook/daemon /etc/libvirt/hook/qemu /etc/libvirt/hook/lxc are potentially used. The implemented set of operations is rather simple currently daemon start, reload, and exit, and for domain operations, domain startup and exit. This can be extended to more drivers in the future of more fine-grained modularity for the scripts. The current API to the script israther simple it get passed arguments about the object name, the operation name, suboperation, and an extra string. Right now for the daemon the script would get the fallowing calls: /etc/libvirt/hooks/daemon - start - start /etc/libvirt/hooks/daemon - reload begin SIGHUP /etc/libvirt/hooks/daemon - shutdown - shutdown and for qemu (or lxc): /etc/libvirt/hooks/qemu RHEL-5.4-64 start begin - /etc/libvirt/hooks/qemu RHEL-5.4-64 stopped end - with the XML configuration of the domain passed on the script stdin if needed. In case of script failure at domain startup, this is raised as an normal error, e.g.: [root@paphio tmp]# virsh start RHEL-5.4-64 error: Failed to start domain RHEL-5.4-64 error: Hook script execution failed: Hook script /etc/libvirt/hooks/qemu qemu failed with error code 256:forbidden startup [root@paphio tmp]# Some hooks could certainly be added at different place in domain lifetime operations, for example we plan to add some for migration, but one thing to remember is that those synchronous scripts can have a serious impact on execution, so to some extend it's better to use the asynchronous async event mechanism when possible. Among the things left to improve and check, there is the behaviour when the daemon is started by the user for example for qemu:///user and double check some of the script interaction with security, SELinux in particular. But the basics are there, and I would hope to have this in the next release, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

4 23

[libvirt] virsh setmaxmem
by Chris Lalancette 30 Mar '10

30 Mar '10

All, My recent patch to remove qemudDomainSetMaxMem() revealed some surprising (to me) behavior of "virsh setmaxmem". In particular, if you run setmaxmem, and the hypervisor doesn't support it, this fact will be reported to you. However, if the amount you were setting for maxmem happens to be lower than "currentMemory", setmaxmem will silently balloon down the domain for you. This is a surprising result exactly because virsh reports error, but did something anyway. What I would expect is that if a hypervisor doesn't support virDomainSetMaxMem(), nothing at all is done. If we agree that this is behavior that needs to be fixed, I would suggest that we move the code to do the auto-ballooning into each of the individual drivers that *do* support virDomainSetMaxMem(). Currently that includes the test driver, the LXC driver, and the Xen driver. This way, we maintain the current behavior for the hypervisors that support this call, and make sure not to do anything at all for the hypervisors that do not. Opinions? -- Chris Lalancette

3 4

[libvirt] [PATCH 0/4] Add timer element to domain clock elements
by Laine Stump 30 Mar '10

30 Mar '10

This patchset implements the XML described in http://www.redhat.com/archives/libvir-list/2010-March/msg00304.html (with one small change - the tickpolicy 'none' was changed to 'delay' after a later discussion). It also implements the qemu backend for those timer types that qemu supports. One thing to point out to 'early adopters': qemu's driftfix option is currently broken, so if you try to specify a tickpolicy=catchup in an rtc timer, the domain will give an error on startup. A patch for that has been posted by Zach Amsden to qemu-devel: http://lists.gnu.org/archive/html/qemu-devel/2010-03/msg02036.html Backends for other hypervisors have not been implemented. That is left as an exercise for later ;-)

2 5

[libvirt] [PATCH 0/2] virsh: honor VISUAL
by Eric Blake 30 Mar '10

30 Mar '10

On IRC yesterday, the comment came up that 'virsh edit' is over-protective, because it prevented me from editing in-terminal using my favorite editor, even after I worked around the fact that sudo sanitizes EDITOR. Besides, historically, VISUAL is used in situations where opening a new window is okay, while EDITOR is used when editing should reuse the current terminal; so we should honor that convention.

3 7

[libvirt] [PATCH] esx: Allow 'lsisas1068' as SCSI controller type
by Matthias Bolte 30 Mar '10

30 Mar '10

Extend tests to cover all SCSI controller types and document the new type. --- docs/drvesx.html.in | 4 +++ src/esx/esx_vmx.c | 14 +++++++----- tests/vmx2xmldata/vmx2xml-scsi-buslogic.vmx | 7 ------ tests/vmx2xmldata/vmx2xml-scsi-buslogic.xml | 20 ------------------ tests/vmx2xmldata/vmx2xml-scsi-driver.vmx | 17 +++++++++++++++ tests/vmx2xmldata/vmx2xml-scsi-driver.xml | 30 +++++++++++++++++++++++++++ tests/vmx2xmltest.c | 2 +- tests/xml2vmxdata/xml2vmx-scsi-buslogic.vmx | 12 ---------- tests/xml2vmxdata/xml2vmx-scsi-buslogic.xml | 15 ------------- tests/xml2vmxdata/xml2vmx-scsi-driver.vmx | 22 +++++++++++++++++++ tests/xml2vmxdata/xml2vmx-scsi-driver.xml | 25 ++++++++++++++++++++++ tests/xml2vmxtest.c | 2 +- 12 files changed, 108 insertions(+), 62 deletions(-) delete mode 100644 tests/vmx2xmldata/vmx2xml-scsi-buslogic.vmx delete mode 100644 tests/vmx2xmldata/vmx2xml-scsi-buslogic.xml create mode 100644 tests/vmx2xmldata/vmx2xml-scsi-driver.vmx create mode 100644 tests/vmx2xmldata/vmx2xml-scsi-driver.xml delete mode 100644 tests/xml2vmxdata/xml2vmx-scsi-buslogic.vmx delete mode 100644 tests/xml2vmxdata/xml2vmx-scsi-buslogic.xml create mode 100644 tests/xml2vmxdata/xml2vmx-scsi-driver.vmx create mode 100644 tests/xml2vmxdata/xml2vmx-scsi-driver.xml diff --git a/docs/drvesx.html.in b/docs/drvesx.html.in index 44a144f..9b413ab 100644 --- a/docs/drvesx.html.in +++ b/docs/drvesx.html.in @@ -275,6 +275,10 @@ ethernet0.checkMACAddress = "false" <dd> LSI Logic SCSI controller for recent guests. </dd> + <dt><code>lsisas1068</code></dt> + <dd> + LSI Logic SAS 1068 controller. + </dd> </dl> Here a domain XML snippet: diff --git a/src/esx/esx_vmx.c b/src/esx/esx_vmx.c index ba4c608..6c1d56e 100644 --- a/src/esx/esx_vmx.c +++ b/src/esx/esx_vmx.c @@ -557,10 +557,11 @@ esxVMX_GatherSCSIControllers(virDomainDefPtr def, char *virtualDev[4], if (disk->driverName != NULL && STRCASENEQ(disk->driverName, "buslogic") && - STRCASENEQ(disk->driverName, "lsilogic")) { + STRCASENEQ(disk->driverName, "lsilogic") && + STRCASENEQ(disk->driverName, "lsisas1068")) { ESX_ERROR(VIR_ERR_INTERNAL_ERROR, "Expecting domain XML entry 'devices/disk/target' to be " - "'buslogic' or 'lsilogic' but found '%s'", + "'buslogic' or 'lsilogic' or 'lsisas1068' but found '%s'", disk->driverName); return -1; } @@ -1269,10 +1270,11 @@ esxVMX_ParseSCSIController(virConfPtr conf, int controller, int *present, if (*virtualDev != NULL && STRCASENEQ(*virtualDev, "buslogic") && - STRCASENEQ(*virtualDev, "lsilogic")) { + STRCASENEQ(*virtualDev, "lsilogic") && + STRCASENEQ(*virtualDev, "lsisas1068")) { ESX_ERROR(VIR_ERR_INTERNAL_ERROR, - "Expecting VMX entry '%s' to be 'buslogic' or 'lsilogic' " - "but found '%s'", virtualDev_name, *virtualDev); + "Expecting VMX entry '%s' to be 'buslogic' or 'lsilogic' or " + "'lsisas1068' but found '%s'", virtualDev_name, *virtualDev); goto failure; } @@ -1312,7 +1314,7 @@ esxVMX_ParseDisk(esxVI_Context *ctx, virConfPtr conf, int device, int bus, * bus = VIR_DOMAIN_DISK_BUS_SCSI * controller = [0..3] * id = [0..6,8..15] - * virtualDev = {'buslogic', 'lsilogic'} + * virtualDev = {'buslogic', 'lsilogic', 'lsisas1068'} * * device = {VIR_DOMAIN_DISK_DEVICE_DISK, VIR_DOMAIN_DISK_DEVICE_CDROM} * bus = VIR_DOMAIN_DISK_BUS_IDE diff --git a/tests/vmx2xmldata/vmx2xml-scsi-buslogic.vmx b/tests/vmx2xmldata/vmx2xml-scsi-buslogic.vmx deleted file mode 100644 index 1725051..0000000 --- a/tests/vmx2xmldata/vmx2xml-scsi-buslogic.vmx +++ /dev/null @@ -1,7 +0,0 @@ -config.version = "8" -virtualHW.version = "4" -scsi0.present = "true" -scsi0.virtualDev = "buslogic" -scsi0:0.present = "true" -scsi0:0.deviceType = "scsi-hardDisk" -scsi0:0.fileName = "harddisk.vmdk" diff --git a/tests/vmx2xmldata/vmx2xml-scsi-buslogic.xml b/tests/vmx2xmldata/vmx2xml-scsi-buslogic.xml deleted file mode 100644 index 2ffb866..0000000 --- a/tests/vmx2xmldata/vmx2xml-scsi-buslogic.xml +++ /dev/null @@ -1,20 +0,0 @@ -<domain type='vmware'> - <uuid>00000000-0000-0000-0000-000000000000</uuid> - <memory>32768</memory> - <currentMemory>32768</currentMemory> - <vcpu>1</vcpu> - <os> - <type arch='i686'>hvm</type> - </os> - <clock offset='utc'/> - <on_poweroff>destroy</on_poweroff> - <on_reboot>restart</on_reboot> - <on_crash>destroy</on_crash> - <devices> - <disk type='file' device='disk'> - <driver name='buslogic'/> - <source file='[datastore] directory/harddisk.vmdk'/> - <target dev='sda' bus='scsi'/> - </disk> - </devices> -</domain> diff --git a/tests/vmx2xmldata/vmx2xml-scsi-driver.vmx b/tests/vmx2xmldata/vmx2xml-scsi-driver.vmx new file mode 100644 index 0000000..cb055f6 --- /dev/null +++ b/tests/vmx2xmldata/vmx2xml-scsi-driver.vmx @@ -0,0 +1,17 @@ +config.version = "8" +virtualHW.version = "4" +scsi0.present = "true" +scsi0.virtualDev = "buslogic" +scsi1.present = "true" +scsi1.virtualDev = "lsilogic" +scsi2.present = "true" +scsi2.virtualDev = "lsisas1068" +scsi0:0.present = "true" +scsi0:0.deviceType = "scsi-hardDisk" +scsi0:0.fileName = "harddisk1.vmdk" +scsi1:0.present = "true" +scsi1:0.deviceType = "scsi-hardDisk" +scsi1:0.fileName = "harddisk2.vmdk" +scsi2:0.present = "true" +scsi2:0.deviceType = "scsi-hardDisk" +scsi2:0.fileName = "harddisk3.vmdk" diff --git a/tests/vmx2xmldata/vmx2xml-scsi-driver.xml b/tests/vmx2xmldata/vmx2xml-scsi-driver.xml new file mode 100644 index 0000000..1fa9ac4 --- /dev/null +++ b/tests/vmx2xmldata/vmx2xml-scsi-driver.xml @@ -0,0 +1,30 @@ +<domain type='vmware'> + <uuid>00000000-0000-0000-0000-000000000000</uuid> + <memory>32768</memory> + <currentMemory>32768</currentMemory> + <vcpu>1</vcpu> + <os> + <type arch='i686'>hvm</type> + </os> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <disk type='file' device='disk'> + <driver name='buslogic'/> + <source file='[datastore] directory/harddisk1.vmdk'/> + <target dev='sda' bus='scsi'/> + </disk> + <disk type='file' device='disk'> + <driver name='lsilogic'/> + <source file='[datastore] directory/harddisk2.vmdk'/> + <target dev='sdp' bus='scsi'/> + </disk> + <disk type='file' device='disk'> + <driver name='lsisas1068'/> + <source file='[datastore] directory/harddisk3.vmdk'/> + <target dev='sdae' bus='scsi'/> + </disk> + </devices> +</domain> diff --git a/tests/vmx2xmltest.c b/tests/vmx2xmltest.c index b4eb5d5..e75def4 100644 --- a/tests/vmx2xmltest.c +++ b/tests/vmx2xmltest.c @@ -122,7 +122,7 @@ mymain(int argc, char **argv) DO_TEST("graphics-vnc", "graphics-vnc", esxVI_APIVersion_25); - DO_TEST("scsi-buslogic", "scsi-buslogic", esxVI_APIVersion_25); + DO_TEST("scsi-driver", "scsi-driver", esxVI_APIVersion_25); DO_TEST("scsi-writethrough", "scsi-writethrough", esxVI_APIVersion_25); DO_TEST("harddisk-scsi-file", "harddisk-scsi-file", esxVI_APIVersion_25); diff --git a/tests/xml2vmxdata/xml2vmx-scsi-buslogic.vmx b/tests/xml2vmxdata/xml2vmx-scsi-buslogic.vmx deleted file mode 100644 index 2f98da3..0000000 --- a/tests/xml2vmxdata/xml2vmx-scsi-buslogic.vmx +++ /dev/null @@ -1,12 +0,0 @@ -config.version = "8" -virtualHW.version = "4" -guestOS = "other" -uuid.bios = "56 4d 9b ef ac d9 b4 e0-c8 f0 ae a8 b9 10 35 15" -displayName = "scsi-buslogic" -memsize = "4" -numvcpus = "1" -scsi0.present = "true" -scsi0.virtualDev = "buslogic" -scsi0:0.present = "true" -scsi0:0.deviceType = "scsi-hardDisk" -scsi0:0.fileName = "/vmfs/volumes/datastore/directory/harddisk.vmdk" diff --git a/tests/xml2vmxdata/xml2vmx-scsi-buslogic.xml b/tests/xml2vmxdata/xml2vmx-scsi-buslogic.xml deleted file mode 100644 index 5d52c54..0000000 --- a/tests/xml2vmxdata/xml2vmx-scsi-buslogic.xml +++ /dev/null @@ -1,15 +0,0 @@ -<domain type='vmware'> - <name>scsi-buslogic</name> - <uuid>564d9bef-acd9-b4e0-c8f0-aea8b9103515</uuid> - <memory>4096</memory> - <os> - <type>hvm</type> - </os> - <devices> - <disk type='file' device='disk'> - <driver name='buslogic'/> - <source file='[datastore] directory/harddisk.vmdk'/> - <target dev='sda' bus='scsi'/> - </disk> - </devices> -</domain> diff --git a/tests/xml2vmxdata/xml2vmx-scsi-driver.vmx b/tests/xml2vmxdata/xml2vmx-scsi-driver.vmx new file mode 100644 index 0000000..7cceca0 --- /dev/null +++ b/tests/xml2vmxdata/xml2vmx-scsi-driver.vmx @@ -0,0 +1,22 @@ +config.version = "8" +virtualHW.version = "4" +guestOS = "other" +uuid.bios = "56 4d 9b ef ac d9 b4 e0-c8 f0 ae a8 b9 10 35 15" +displayName = "scsi-buslogic" +memsize = "4" +numvcpus = "1" +scsi0.present = "true" +scsi0.virtualDev = "buslogic" +scsi1.present = "true" +scsi1.virtualDev = "lsilogic" +scsi2.present = "true" +scsi2.virtualDev = "lsisas1068" +scsi0:0.present = "true" +scsi0:0.deviceType = "scsi-hardDisk" +scsi0:0.fileName = "/vmfs/volumes/datastore/directory/harddisk1.vmdk" +scsi1:0.present = "true" +scsi1:0.deviceType = "scsi-hardDisk" +scsi1:0.fileName = "/vmfs/volumes/datastore/directory/harddisk2.vmdk" +scsi2:0.present = "true" +scsi2:0.deviceType = "scsi-hardDisk" +scsi2:0.fileName = "/vmfs/volumes/datastore/directory/harddisk3.vmdk" diff --git a/tests/xml2vmxdata/xml2vmx-scsi-driver.xml b/tests/xml2vmxdata/xml2vmx-scsi-driver.xml new file mode 100644 index 0000000..797a26e --- /dev/null +++ b/tests/xml2vmxdata/xml2vmx-scsi-driver.xml @@ -0,0 +1,25 @@ +<domain type='vmware'> + <name>scsi-buslogic</name> + <uuid>564d9bef-acd9-b4e0-c8f0-aea8b9103515</uuid> + <memory>4096</memory> + <os> + <type>hvm</type> + </os> + <devices> + <disk type='file' device='disk'> + <driver name='buslogic'/> + <source file='[datastore] directory/harddisk1.vmdk'/> + <target dev='sda' bus='scsi'/> + </disk> + <disk type='file' device='disk'> + <driver name='lsilogic'/> + <source file='[datastore] directory/harddisk2.vmdk'/> + <target dev='sdp' bus='scsi'/> + </disk> + <disk type='file' device='disk'> + <driver name='lsisas1068'/> + <source file='[datastore] directory/harddisk3.vmdk'/> + <target dev='sdae' bus='scsi'/> + </disk> + </devices> +</domain> diff --git a/tests/xml2vmxtest.c b/tests/xml2vmxtest.c index b8b9d6f..f9c4730 100644 --- a/tests/xml2vmxtest.c +++ b/tests/xml2vmxtest.c @@ -175,7 +175,7 @@ mymain(int argc, char **argv) DO_TEST("graphics-vnc", "graphics-vnc", esxVI_APIVersion_25); - DO_TEST("scsi-buslogic", "scsi-buslogic", esxVI_APIVersion_25); + DO_TEST("scsi-driver", "scsi-driver", esxVI_APIVersion_25); DO_TEST("scsi-writethrough", "scsi-writethrough", esxVI_APIVersion_25); DO_TEST("harddisk-scsi-file", "harddisk-scsi-file", esxVI_APIVersion_25); -- 1.6.3.3

2 5

[libvirt] 0.7.8 schedule
by Daniel Veillard 30 Mar '10

30 Mar '10

So clearly we are a bit late we didn't freezed this week-end, hopefully we can push the last bits for the release tomorrow. I would be tempted to actually name the release 0.8.0 if we get the snapshot API in (which I expect), then start freeze on Wed, and make the official release early next week. There is still a few things to clean up left and right, some patches for bug fixes need ACKs, so I still expect some work before being able to declare the new release ready ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] [PATCH] nwfilter_ebiptables_driver.c: avoid NULL dereference
by Jim Meyering 30 Mar '10

30 Mar '10

Another one caught by clang: Note the first test to see if "inst" may be NULL. Then, in the following loop, "inst" is unconditionally dereferenced via "inst[i]". There are other unprotected used of "inst[i]" below, too. Rather than trying to protect all uses, one by one, I chose to return "success" when given an empty list of rules. In addition, not only does it appear to be possible to call this function with a NULL "inst" pointer, but it may even be undefined. At least one caller is virNWFilterInstantiate, where "inst" maps to the caller's "ptrs" variable. There, ptrs is initialized (or not, in some cases) by virNWFilterRuleInstancesToArray. Fortunately, at least this one caller (virNWFilterRuleInstancesToArray) does initialize "ptrs" to NULL, so in actuality, it cannot currently be used undefined. But the fact that a function like virNWFilterRuleInstancesToArray can return "successfully" without defining that output parameter is a little risky. >From f2d1a49095ed6f7caa3d5ee67409ac561c55ba77 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Mon, 29 Mar 2010 18:27:26 +0200 Subject: [PATCH] nwfilter_ebiptables_driver.c: avoid NULL dereference * src/nwfilter/nwfilter_ebiptables_driver.c (ebiptablesApplyNewRules): Don't dereference a NULL or uninitialized pointer when given an empty list of rules --- src/nwfilter/nwfilter_ebiptables_driver.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/nwfilter/nwfilter_ebiptables_driver.c b/src/nwfilter/nwfilter_ebiptables_driver.c index 7871926..3932b44 100644 --- a/src/nwfilter/nwfilter_ebiptables_driver.c +++ b/src/nwfilter/nwfilter_ebiptables_driver.c @@ -2378,31 +2378,32 @@ ebiptablesRuleOrderSort(const void *a, const void *b) static int ebiptablesApplyNewRules(virConnectPtr conn, const char *ifname, int nruleInstances, void **_inst) { int i; int cli_status; ebiptablesRuleInstPtr *inst = (ebiptablesRuleInstPtr *)_inst; int chains_in = 0, chains_out = 0; virBuffer buf = VIR_BUFFER_INITIALIZER; int haveIptables = 0; - if (inst) - qsort(inst, nruleInstances, sizeof(inst[0]), - ebiptablesRuleOrderSort); + if (nruleInstances == 0 || inst == NULL) + return 0; + + qsort(inst, nruleInstances, sizeof(inst[0]), ebiptablesRuleOrderSort); for (i = 0; i < nruleInstances; i++) { if (inst[i]->ruleType == RT_EBTABLES) { if (inst[i]->chainprefix == CHAINPREFIX_HOST_IN_TEMP) chains_in |= (1 << inst[i]->neededProtocolChain); else chains_out |= (1 << inst[i]->neededProtocolChain); } } ebtablesUnlinkTmpRootChain(conn, &buf, 1, ifname); ebtablesUnlinkTmpRootChain(conn, &buf, 0, ifname); ebtablesRemoveTmpSubChains(conn, &buf, ifname); ebtablesRemoveTmpRootChain(conn, &buf, 1, ifname); -- 1.7.0.3.448.g82eeb

4 7

[libvirt] [PATCH] Make int-overflow test case pass
by Stefan Berger 30 Mar '10

30 Mar '10

This fix makes the int-overflow test case pass. Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com> Index: libvirt/tests/int-overflow =================================================================== --- libvirt.orig/tests/int-overflow +++ libvirt/tests/int-overflow @@ -14,6 +14,7 @@ fi . "$srcdir/test-lib.sh" echo "error: failed to get domain '4294967298'" > exp || fail=1 +echo "error: Failed to start the nwfilter driver: Is the daemon running ?" >> exp || fail=1 echo domname 4294967298 | $abs_top_builddir/tools/virsh --quiet \ --connect test://$abs_top_srcdir/examples/xml/test/testnode.xml \ > /dev/null 2> err || fail=1

3 4

[libvirt] [PATCH v4 00/15] Network filtering (ACL) extensions for libvirt
by Stefan Berger 30 Mar '10

30 Mar '10

Hi! This is a repost of this set of patches with some of the suggested fixes applied and ipv6 support on the ebtables layer added. Between V3 and V4 of this patch series the following changes were made: - occurrences of typo 'scp' were changed to 'sctp' - the root ebtables chain for each interface now has the previx of 'libvirt-' - additional calls into tear-down functions in case something goes wrong while starting the qemu/kvm VM in 2nd level error paths - additional functions in the driver interface to split up the application of firewall rules into - creation of new firewall rules 'tree' - switch-over to new firewall rules 'tree', tear down of old one and renaming of new firewall 'tree' - tear down of new firewall rules 'tree' in case an error happend during update of several VMs. - additional patch with example filters The following set of patches add network filtering (ACL) extensions to libvirt and enable network traffic filtering for VMs using ebtables and, depending on the networking technology being used (tap, but not macvtap), also iptables. Usage of either is optional and controlled through filters that a VM is referencing. The ebtables-level filtering is based on the XML derived from the CIM network slide 10 (filtering) from the DMTF website (http://www.dmtf.org/standards/cim/cim_schema_v2230/CIM_Network.pdf) The XML we derived from this was discussed on the list before. On the ebtables level we currently handle filtering of IPv4 and ARP traffic. The iptables-level filtering is based on similar XML where XML nodes described the particular protocol to filter for. Its extensions enable the filtering of traffic using iptables for tcp, udp, icmp, igmp, sctp and 'all' types of traffic. This list of protocols maps to the features supported by iptables and only excludes protocols like 'esp', 'ah' and 'udplite'. Currently only bridging mode is supported and based on availability of the physdev match. The filtering framework adds new libvirt virsh commands for managing the filters. The 5 new commands are: - virsh nwfilter-list - virsh nwfilter-dumpxml <name of filter> - virsh nwfilter-define <name of file containing filter desc.> - virsh nwfilter-undefine <name of filter> - virsh nwfilter-edit <name of filter> Above commands are similar to commands for already existing pools and as such much of the code directly related to the above commands could be borrowed from other drivers. The network filters can either contain rules using the above mentioned XML or contain references to other filters in order to build more complex filters that form some sort of filter tree or can contain both. An example for a filter referencing other filters would be this one here: <filter name='demofilter4' chain='root'> <uuid>66f62d1d-34c1-1421-824f-c62d5ee5e8b6</uuid> <filterref filter='no-mac-spoofing'/> <filterref filter='no-mac-broadcast'/> <filterref filter='no-arp-spoofing'/> <filterref filter='allow-dhcp'> <parameter name='DHCPSERVER' value='10.0.0.1'/> </filterref> <filterref filter='no-other-l2-traffic'/> <filterref filter='recv-only-vm-ipaddress'/> <filterref filter='recv-only-vm-macaddress'/> <filterref filter='l3-test'/> <filterref filter='ipv6test'/> </filter> A filter containing actual rules would look like this: <filter name='no-mac-broadcast' chain='ipv4'> <uuid>ffe2ccd6-edec-7360-1852-6b5ccb553234</uuid> <rule action='drop' direction='out' priority='500'> <mac dstmacaddr='ff:ff:ff:ff:ff:ff'/> </rule> </filter> The filter XML now also holds a priority attribute in the rule. This provides control over the ordering of the applied ebtables/iptables rules beyond their appearance in the XML. The domain XML has been extended to reference a top level filter from within each <interface> XML node. A valid reference to such a top level filter looks like this: <interface type='bridge'> <source bridge='static'/> <filterref filter='demofilter4'> <parameter name='IP' value='9.59.241.151'/> </filterref> </interface> In this XML a parameter IP is passed for instantiation of the referenced filters, that may require the availability of this parameter. In the above case the IP parameter's value describes the value of the IP address of the VM and allows to enable those filters to be instantiated that require this 'IP' variable. If a filter requires a parameter that is not provided, the VM will not start or the interface will not attach to a running VM. Any names of parameters can be provided for instantiation of filters and their names and values only need to pass a regular expression test. In a subsequent patch we will be adding capability to allow users to omit the IP parameter (only) and enable libvirt to learn the IP address of the VM and have it instantiate the filter once it knows it. While virtual machines are running, it is possible to update their filters. For that all running VMs' filter 'trees' are traversed to detect whether the updated filter is referenced by the VM. If so, its ebtables/iptable rules are applied. If one of the VMs' update fails allupdates are rolled back and the filter XML update is rejected. One comment about the instantiation of the rules: Since the XML allows to create nearly any possible combination of parameters to ebtables or iptables commands, I haven't used the ebtables or iptables wrappers. Instead, I am writing ebtables/iptables command into a buffer, add command line options to each one of them as described in the rule's XML, write the buffer into a file and run it as a script. For those commands that are not allowed to fail I am using the following format to run them: cmd="ebtables <some options>" r=`${cmd}` if [ $? -ne 0 ]; then echo "Failure in command ${cmd}." exit 1 fi cmd="..." [...] If one of the command fails in such a batch, the libvirt code is going pick up the error code '1', tear down anything previously established and report an error back. The actual error message shown above is currently not reported back, but can be later on with some changes to the commands running external programs that need to read the script's stdout. One comment to patch 14: It currently #include's a .c file into a .c file only for the reason so I don't have to change too much code once I change code in the underlying patch. So this has to be changed. The patch series works without patch 13, but then only supports ebtables. The patches apply to the current tip. They pass 'make syntax-check' and have been frequently run in valgrind for memory leak checks. Looking forward to your feedback on the patches. Thanks and regards, Stefan and Gerhard

3 21

[libvirt] [PATCH] nwfilter_conf.c: don't test an uninitialized local variable
by Jim Meyering 30 Mar '10

30 Mar '10

I've just run the code through clang, and it spotted a few new problems. Here's one: >From 4c848787c8268e37db9a1d0754b8fcd8e5774f73 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Mon, 29 Mar 2010 17:34:32 +0200 Subject: [PATCH] nwfilter_conf.c: don't test an uninitialized local variable * src/conf/nwfilter_conf.c (virNWIPAddressFormat): Do not use "i" uninitialized. --- src/conf/nwfilter_conf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c index e82aae6..f673e69 100644 --- a/src/conf/nwfilter_conf.c +++ b/src/conf/nwfilter_conf.c @@ -2423,7 +2423,7 @@ virNWIPAddressFormat(virBufferPtr buf, nwIPAddressPtr ipaddr) ipaddr->addr.ipv4Addr[2], ipaddr->addr.ipv4Addr[3]); } else { - int i; + unsigned int i = 0; int dcshown = 0, in_dc = 0; unsigned short n; while (i < 8) { -- 1.7.0.3.448.g82eeb

3 2

[libvirt] [PATCH] Fix 'make check' runs due to usage of conn parameter in error reporting
by Stefan Berger 30 Mar '10

30 Mar '10

This patch fixes the 'make check' runs for me which, under certain circumstances and login configurations, did invoke popups requesting authentication. I removed the parameter conn from being passed into the error reporting function. Signed-off-by; Stefan Berger <stefanb(a)us.ibm.com> --- src/conf/nwfilter_conf.c | 15 ++++++--------- src/conf/nwfilter_conf.h | 3 ++- 2 files changed, 8 insertions(+), 10 deletions(-) Index: libvirt/src/conf/nwfilter_conf.c =================================================================== --- libvirt.orig/src/conf/nwfilter_conf.c +++ libvirt/src/conf/nwfilter_conf.c @@ -44,9 +44,6 @@ #define VIR_FROM_THIS VIR_FROM_NWFILTER -#define virNWFilterError(conn, code, fmt...) \ - virReportErrorHelper(conn, VIR_FROM_NWFILTER, code, __FILE__,\ - __FUNCTION__, __LINE__, fmt) VIR_ENUM_IMPL(virNWFilterRuleAction, VIR_NWFILTER_RULE_ACTION_LAST, "drop", @@ -2248,9 +2245,9 @@ virNWFilterPoolObjLoad(virConnectPtr con } if (!virFileMatchesNameSuffix(file, def->name, ".xml")) { - virNWFilterError(conn, VIR_ERR_INVALID_NWFILTER, - "NWFilter pool config filename '%s' does not match pool name '%s'", - path, def->name); + virNWFilterReportError(conn, VIR_ERR_INVALID_NWFILTER, + _("network filter pool config filename '%s' does not match pool name '%s'"), + path, def->name); virNWFilterDefFree(def); return NULL; } @@ -2300,9 +2297,9 @@ virNWFilterPoolLoadAllConfigs(virConnect if (virFileBuildPath(configDir, entry->d_name, NULL, path, PATH_MAX) < 0) { - virNWFilterError(conn, VIR_ERR_INTERNAL_ERROR, - "Config filename '%s/%s' is too long", - configDir, entry->d_name); + virNWFilterReportError(conn, VIR_ERR_INTERNAL_ERROR, + _("config filename '%s/%s' is too long"), + configDir, entry->d_name); continue; } Index: libvirt/src/conf/nwfilter_conf.h =================================================================== --- libvirt.orig/src/conf/nwfilter_conf.h +++ libvirt/src/conf/nwfilter_conf.h @@ -523,7 +523,8 @@ int virNWFilterParamConfLayerInit(void); void virNWFilterParamConfLayerShutdown(void); # define virNWFilterReportError(conn, code, fmt...) \ - virReportErrorHelper(conn, VIR_FROM_NWFILTER, code, __FILE__, \ + (void)conn; \ + virReportErrorHelper(NULL, VIR_FROM_NWFILTER, code, __FILE__, \ __FUNCTION__, __LINE__, fmt)

1 0

[libvirt] issues about Migrating with virsh and libvirt functions
by wei ma 29 Mar '10

29 Mar '10

Hi everyone i've been trying to migrate a domain from hostA to hostB.But everytime i did it with "virsh --live migrate <Domain> xen+ssh://root@Destination", it failed and told me something like "Error Domain not found:xenUnifiedDomainLookupByName". The same thing happened when i tried to do the same thing with libvirt API like virDomainMigrate & virDomainMigrateToURI. i am confused about this. So can anybody can tell me why?Thanks a lot. BTW,the OS is CentOS 5.4 with libvirt 0.7.7 and Xen 3.4.0.

2 1

[libvirt] [PATCH] filter new files through cppi, so syntax-check passes once again
by Jim Meyering 27 Mar '10

27 Mar '10

FYI, just pushed (no semantic change): >From d0e79bd5fa280a568d5b919fabd5f2f4dacf8f89 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Fri, 26 Mar 2010 19:29:54 +0100 Subject: [PATCH] filter new files through cppi, so syntax-check passes once again * src/conf/nwfilter_conf.h: Indent cpp directives. * src/conf/nwfilter_params.h: Likewise. * src/datatypes.h: Likewise. * src/nwfilter/nwfilter_driver.h: Likewise. * src/nwfilter/nwfilter_ebiptables_driver.h: Likewise. * src/nwfilter/nwfilter_gentech_driver.h: Likewise. --- src/conf/nwfilter_conf.h | 24 ++++++++++++------------ src/conf/nwfilter_params.h | 4 ++-- src/datatypes.h | 6 +++--- src/nwfilter/nwfilter_driver.h | 6 +++--- src/nwfilter/nwfilter_ebiptables_driver.h | 6 +++--- src/nwfilter/nwfilter_gentech_driver.h | 2 +- 6 files changed, 24 insertions(+), 24 deletions(-) diff --git a/src/conf/nwfilter_conf.h b/src/conf/nwfilter_conf.h index 5ba2f41..9b6ca40 100644 --- a/src/conf/nwfilter_conf.h +++ b/src/conf/nwfilter_conf.h @@ -24,15 +24,15 @@ * Author: Stefan Berger <stefanb(a)us.ibm.com> */ #ifndef NWFILTER_CONF_H -#define NWFILTER_CONF_H +# define NWFILTER_CONF_H -#include <stdint.h> -#include <stddef.h> +# include <stdint.h> +# include <stddef.h> -#include "internal.h" -#include "util.h" -#include "hash.h" -#include "xml.h" +# include "internal.h" +# include "util.h" +# include "hash.h" +# include "xml.h" /** * Chain suffix size is: @@ -43,7 +43,7 @@ * terminating '0' = * 32-3-15-1-1 = 12 */ -#define MAX_CHAIN_SUFFIX_SIZE 12 +# define MAX_CHAIN_SUFFIX_SIZE 12 enum virNWFilterEntryItemFlags { @@ -53,10 +53,10 @@ enum virNWFilterEntryItemFlags { }; -#define HAS_ENTRY_ITEM(data) \ +# define HAS_ENTRY_ITEM(data) \ (((data)->flags) & NWFILTER_ENTRY_ITEM_FLAG_EXISTS) -#define ENTRY_GET_NEG_SIGN(data) \ +# define ENTRY_GET_NEG_SIGN(data) \ ((((data)->flags) & NWFILTER_ENTRY_ITEM_FLAG_IS_NEG) ? "!" : "") // datatypes appearing in rule attributes @@ -288,7 +288,7 @@ enum virNWFilterEbtablesTableType { }; -#define MAX_RULE_PRIORITY 1000 +# define MAX_RULE_PRIORITY 1000 typedef struct _virNWFilterRuleDef virNWFilterRuleDef; @@ -522,7 +522,7 @@ void virNWFilterConfLayerShutdown(void); int virNWFilterParamConfLayerInit(void); void virNWFilterParamConfLayerShutdown(void); -#define virNWFilterReportError(conn, code, fmt...) \ +# define virNWFilterReportError(conn, code, fmt...) \ virReportErrorHelper(conn, VIR_FROM_NWFILTER, code, __FILE__, \ __FUNCTION__, __LINE__, fmt) diff --git a/src/conf/nwfilter_params.h b/src/conf/nwfilter_params.h index 7a9b1ee..5b4afba 100644 --- a/src/conf/nwfilter_params.h +++ b/src/conf/nwfilter_params.h @@ -20,9 +20,9 @@ * Author: Stefan Berger <stefanb(a)us.ibm.com> */ #ifndef NWFILTER_PARAMS_H -#define NWFILTER_PARAMS_H +# define NWFILTER_PARAMS_H -#include "hash.h" +# include "hash.h" typedef struct _virNWFilterHashTable virNWFilterHashTable; typedef virNWFilterHashTable *virNWFilterHashTablePtr; diff --git a/src/datatypes.h b/src/datatypes.h index c221119..4663c9c 100644 --- a/src/datatypes.h +++ b/src/datatypes.h @@ -126,9 +126,9 @@ * magic value used to protect the API when pointers to network filter * pool structures are passed down by the users. */ -#define VIR_NWFILTER_MAGIC 0xDEAD7777 -#define VIR_IS_NWFILTER(obj) ((obj) && (obj)->magic==VIR_NWFILTER_MAGIC) -#define VIR_IS_CONNECTED_NWFILTER(obj) (VIR_IS_NWFILTER(obj) && VIR_IS_CONNECT((obj)->conn)) +# define VIR_NWFILTER_MAGIC 0xDEAD7777 +# define VIR_IS_NWFILTER(obj) ((obj) && (obj)->magic==VIR_NWFILTER_MAGIC) +# define VIR_IS_CONNECTED_NWFILTER(obj) (VIR_IS_NWFILTER(obj) && VIR_IS_CONNECT((obj)->conn)) /** diff --git a/src/nwfilter/nwfilter_driver.h b/src/nwfilter/nwfilter_driver.h index b7d8668..3f60560 100644 --- a/src/nwfilter/nwfilter_driver.h +++ b/src/nwfilter/nwfilter_driver.h @@ -26,10 +26,10 @@ */ #ifndef __VIR_NWFILTER_DRIVER_H__ -#define __VIR_NWFILTER_DRIVER_H__ +# define __VIR_NWFILTER_DRIVER_H__ -#include "nwfilter_params.h" -#include "nwfilter_conf.h" +# include "nwfilter_params.h" +# include "nwfilter_conf.h" int nwfilterRegister(void); diff --git a/src/nwfilter/nwfilter_ebiptables_driver.h b/src/nwfilter/nwfilter_ebiptables_driver.h index a036b99..ff22844 100644 --- a/src/nwfilter/nwfilter_ebiptables_driver.h +++ b/src/nwfilter/nwfilter_ebiptables_driver.h @@ -21,9 +21,9 @@ * Author: Stefan Berger <stefanb(a)us.ibm.com> */ #ifndef VIR_NWFILTER_EBTABLES_DRIVER_H__ -#define VIR_NWFILTER_EBTABLES_DRIVER_H__ +# define VIR_NWFILTER_EBTABLES_DRIVER_H__ -#define MAX_CHAINNAME_LENGTH 32 /* see linux/netfilter_bridge/ebtables.h */ +# define MAX_CHAINNAME_LENGTH 32 /* see linux/netfilter_bridge/ebtables.h */ enum RuleType { RT_EBTABLES, @@ -43,6 +43,6 @@ struct _ebiptablesRuleInst { extern virNWFilterTechDriver ebiptables_driver; -#define EBIPTABLES_DRIVER_ID "ebiptables" +# define EBIPTABLES_DRIVER_ID "ebiptables" #endif diff --git a/src/nwfilter/nwfilter_gentech_driver.h b/src/nwfilter/nwfilter_gentech_driver.h index a77d95a..6b7da71 100644 --- a/src/nwfilter/nwfilter_gentech_driver.h +++ b/src/nwfilter/nwfilter_gentech_driver.h @@ -21,7 +21,7 @@ * Author: Stefan Berger <stefanb(a)us.ibm.com> */ #ifndef __NWFILTER_GENTECH_DRIVER_H -#define __NWFILTER_GENTECH_DRIVER_H +# define __NWFILTER_GENTECH_DRIVER_H virNWFilterTechDriverPtr virNWFilterTechDriverForName(const char *name); -- 1.7.0.3.448.g82eeb

2 2

[libvirt] [PATCH 0/3] Check CPU features during migration
by Jiri Denemark 27 Mar '10

27 Mar '10

Jiri Denemark (3): cpuUpdate() for updating guest CPU according to host CPU Helper function for making a deep-copy of virCPUDefPtr Introduce UPDATE_CPU flag for virDomainGetXMLDesc include/libvirt/libvirt.h.in | 5 +- src/conf/cpu_conf.c | 37 ++++++++++ src/conf/cpu_conf.h | 3 + src/cpu/cpu.c | 22 ++++++ src/cpu/cpu.h | 9 +++ src/cpu/cpu_generic.c | 1 + src/cpu/cpu_x86.c | 161 +++++++++++++++++++++++++++++++++++++----- src/libvirt.c | 3 +- src/libvirt_private.syms | 2 + src/qemu/qemu_driver.c | 54 ++++++++++++-- tools/virsh.c | 4 + 11 files changed, 273 insertions(+), 28 deletions(-)

3 11

[libvirt] [PATCH] Don't replace persistent domain config with migrated config
by Jiri Denemark 27 Mar '10

27 Mar '10

When a domain is defined on host1, migrated to host2 and then migrated back to host1, its current configuration would overwrite the libvirtd's in-memory copy of persistent configuration of that domain. This is not desired as we want to preserve the persistent configuration untouched. This patch introduces new 'live' parameter to virDomainAssignDef. Passing 'true' for 'live' means the configuration passed to virDomainAssignDef describes a configuration of live instance of the domain. This applies for saved domains which are being restored or for incoming domains during migration. All callers have been changed to pass the appropriate value. --- src/conf/domain_conf.c | 19 +++++++++++++------ src/conf/domain_conf.h | 5 ++++- src/lxc/lxc_driver.c | 4 ++-- src/opennebula/one_driver.c | 4 ++-- src/openvz/openvz_driver.c | 4 ++-- src/qemu/qemu_driver.c | 10 +++++----- src/test/test_driver.c | 10 +++++----- src/uml/uml_driver.c | 4 ++-- 8 files changed, 35 insertions(+), 25 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 22e1679..4cc27ff 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -749,18 +749,25 @@ static virDomainObjPtr virDomainObjNew(virCapsPtr caps) virDomainObjPtr virDomainAssignDef(virCapsPtr caps, virDomainObjListPtr doms, - const virDomainDefPtr def) + const virDomainDefPtr def, + bool live) { virDomainObjPtr domain; char uuidstr[VIR_UUID_STRING_BUFLEN]; if ((domain = virDomainFindByUUID(doms, def->uuid))) { if (!virDomainObjIsActive(domain)) { - virDomainDefFree(domain->def); - domain->def = def; + if (live) { + /* save current configuration to be restored on domain shutdown */ + if (!domain->newDef) + domain->newDef = domain->def; + domain->def = def; + } else { + virDomainDefFree(domain->def); + domain->def = def; + } } else { - if (domain->newDef) - virDomainDefFree(domain->newDef); + virDomainDefFree(domain->newDef); domain->newDef = def; } @@ -5780,7 +5787,7 @@ virDomainObjPtr virDomainLoadConfig(virCapsPtr caps, newVM = 0; } - if (!(dom = virDomainAssignDef(caps, doms, def))) + if (!(dom = virDomainAssignDef(caps, doms, def, false))) goto error; dom->autostart = autostart; diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 44fff0c..9e6cb69 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -810,9 +810,12 @@ void virDomainObjRef(virDomainObjPtr vm); /* Returns 1 if the object was freed, 0 if more refs exist */ int virDomainObjUnref(virDomainObjPtr vm); +/* live == true means def describes an active domain (being migrated or + * restored) as opposed to a new persistent configuration of the domain */ virDomainObjPtr virDomainAssignDef(virCapsPtr caps, virDomainObjListPtr doms, - const virDomainDefPtr def); + const virDomainDefPtr def, + bool live); void virDomainRemoveInactive(virDomainObjListPtr doms, virDomainObjPtr dom); diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index ba13065..9786cc0 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -381,7 +381,7 @@ static virDomainPtr lxcDomainDefine(virConnectPtr conn, const char *xml) } if (!(vm = virDomainAssignDef(driver->caps, - &driver->domains, def))) + &driver->domains, def, false))) goto cleanup; def = NULL; vm->persistent = 1; @@ -1368,7 +1368,7 @@ lxcDomainCreateAndStart(virConnectPtr conn, if (!(vm = virDomainAssignDef(driver->caps, - &driver->domains, def))) + &driver->domains, def, false))) goto cleanup; def = NULL; diff --git a/src/opennebula/one_driver.c b/src/opennebula/one_driver.c index e1d1efc..f7fbd46 100644 --- a/src/opennebula/one_driver.c +++ b/src/opennebula/one_driver.c @@ -251,7 +251,7 @@ static virDomainPtr oneDomainDefine(virConnectPtr conn, const char *xml) goto return_point; if (!(vm = virDomainAssignDef(driver->caps, - &driver->domains, def))) { + &driver->domains, def, false))) { virDomainDefFree(def); goto return_point; } @@ -456,7 +456,7 @@ oneDomainCreateAndStart(virConnectPtr conn, } if (!(vm = virDomainAssignDef(driver->caps, - &driver->domains, def))) { + &driver->domains, def, false))) { virDomainDefFree(def); goto return_point; } diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index 50aadfc..e0a0768 100644 --- a/src/openvz/openvz_driver.c +++ b/src/openvz/openvz_driver.c @@ -825,7 +825,7 @@ openvzDomainDefineXML(virConnectPtr conn, const char *xml) goto cleanup; } if (!(vm = virDomainAssignDef(driver->caps, - &driver->domains, vmdef))) + &driver->domains, vmdef, false))) goto cleanup; vmdef = NULL; vm->persistent = 1; @@ -905,7 +905,7 @@ openvzDomainCreateXML(virConnectPtr conn, const char *xml, goto cleanup; } if (!(vm = virDomainAssignDef(driver->caps, - &driver->domains, vmdef))) + &driver->domains, vmdef, false))) goto cleanup; vmdef = NULL; /* All OpenVZ domains seem to be persistent - this is a bit of a violation diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 257f914..2c81d68 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3563,7 +3563,7 @@ static virDomainPtr qemudDomainCreate(virConnectPtr conn, const char *xml, if (!(vm = virDomainAssignDef(driver->caps, &driver->domains, - def))) + def, false))) goto cleanup; def = NULL; @@ -5220,7 +5220,7 @@ static int qemudDomainRestore(virConnectPtr conn, if (!(vm = virDomainAssignDef(driver->caps, &driver->domains, - def))) { + def, true))) { qemuReportError(VIR_ERR_OPERATION_FAILED, "%s", _("failed to assign new VM")); goto cleanup; @@ -5761,7 +5761,7 @@ static virDomainPtr qemudDomainDefine(virConnectPtr conn, const char *xml) { if (!(vm = virDomainAssignDef(driver->caps, &driver->domains, - def))) { + def, false))) { goto cleanup; } def = NULL; @@ -8391,7 +8391,7 @@ qemudDomainMigratePrepareTunnel(virConnectPtr dconn, if (!(vm = virDomainAssignDef(driver->caps, &driver->domains, - def))) { + def, true))) { qemuReportError(VIR_ERR_OPERATION_FAILED, "%s", _("failed to assign new VM")); goto cleanup; @@ -8622,7 +8622,7 @@ qemudDomainMigratePrepare2 (virConnectPtr dconn, if (!(vm = virDomainAssignDef(driver->caps, &driver->domains, - def))) { + def, true))) { qemuReportError(VIR_ERR_OPERATION_FAILED, "%s", _("failed to assign new VM")); goto cleanup; diff --git a/src/test/test_driver.c b/src/test/test_driver.c index f54ebae..9a880f1 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -554,7 +554,7 @@ static int testOpenDefault(virConnectPtr conn) { if (testDomainGenerateIfnames(conn, domdef) < 0) goto error; if (!(domobj = virDomainAssignDef(privconn->caps, - &privconn->domains, domdef))) + &privconn->domains, domdef, false))) goto error; domdef = NULL; @@ -910,7 +910,7 @@ static int testOpenFromFile(virConnectPtr conn, if (testDomainGenerateIfnames(conn, def) < 0 || !(dom = virDomainAssignDef(privconn->caps, - &privconn->domains, def))) { + &privconn->domains, def, false))) { virDomainDefFree(def); goto error; } @@ -1308,7 +1308,7 @@ testDomainCreateXML(virConnectPtr conn, const char *xml, if (testDomainGenerateIfnames(conn, def) < 0) goto cleanup; if (!(dom = virDomainAssignDef(privconn->caps, - &privconn->domains, def))) + &privconn->domains, def, false))) goto cleanup; def = NULL; @@ -1853,7 +1853,7 @@ static int testDomainRestore(virConnectPtr conn, if (testDomainGenerateIfnames(conn, def) < 0) goto cleanup; if (!(dom = virDomainAssignDef(privconn->caps, - &privconn->domains, def))) + &privconn->domains, def, true))) goto cleanup; def = NULL; @@ -2302,7 +2302,7 @@ static virDomainPtr testDomainDefineXML(virConnectPtr conn, if (testDomainGenerateIfnames(conn, def) < 0) goto cleanup; if (!(dom = virDomainAssignDef(privconn->caps, - &privconn->domains, def))) + &privconn->domains, def, false))) goto cleanup; def = NULL; dom->persistent = 1; diff --git a/src/uml/uml_driver.c b/src/uml/uml_driver.c index bf06787..0c12469 100644 --- a/src/uml/uml_driver.c +++ b/src/uml/uml_driver.c @@ -1283,7 +1283,7 @@ static virDomainPtr umlDomainCreate(virConnectPtr conn, const char *xml, if (!(vm = virDomainAssignDef(driver->caps, &driver->domains, - def))) + def, false))) goto cleanup; def = NULL; @@ -1619,7 +1619,7 @@ static virDomainPtr umlDomainDefine(virConnectPtr conn, const char *xml) { if (!(vm = virDomainAssignDef(driver->caps, &driver->domains, - def))) + def, false))) goto cleanup; def = NULL; vm->persistent = 1; -- 1.7.0.3

3 5

[libvirt] [PATCH 0/1] Disk error policy
by David Allan 27 Mar '10

27 Mar '10

Here's a revised patch for disk error policy XML incorporating the feedback from Dan and Daniel. Dave David Allan (1): Add disk error policy to domain XML docs/schemas/domain.rng | 12 +++++++- src/conf/domain_conf.c | 18 +++++++++++ src/conf/domain_conf.h | 10 ++++++ src/libvirt_private.syms | 2 +- src/qemu/qemu_conf.c | 17 +++++++++- tests/qemuargv2xmltest.c | 3 ++ .../qemuxml2argv-disk-drive-error-policy-stop.args | 1 + .../qemuxml2argv-disk-drive-error-policy-stop.xml | 32 ++++++++++++++++++++ tests/qemuxml2argvtest.c | 3 ++ 9 files changed, 94 insertions(+), 4 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-error-policy-stop.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-error-policy-stop.xml

3 3

[libvirt] [PATCH] fix build break
by Dave Allan 27 Mar '10

27 Mar '10

I pushed this trivial patch to fix a build break earlier today. Dave

2 1

[libvirt] [PATCH] [RFC] Use enum of virDomainNetType
by Stefan Berger 27 Mar '10

27 Mar '10

To find out where the net type 'direct' needs to be handled I introduced the 'enum virDomainNetType' in the virDomainNetDef structure and let the compiler tell me where the case statement is missing. Then I added the unhandled device statement to the UML driver. Signed-off-by; Stefan Berger <stefanb(a)us.ibm.com> Index: libvirt-plain/src/conf/domain_conf.h =================================================================== --- libvirt-plain.orig/src/conf/domain_conf.h +++ libvirt-plain/src/conf/domain_conf.h @@ -251,7 +251,7 @@ enum virDomainNetdevMacvtapType { typedef struct _virDomainNetDef virDomainNetDef; typedef virDomainNetDef *virDomainNetDefPtr; struct _virDomainNetDef { - int type; + enum virDomainNetType type; unsigned char mac[VIR_MAC_BUFLEN]; char *model; union { Index: libvirt-plain/src/lxc/lxc_driver.c =================================================================== --- libvirt-plain.orig/src/lxc/lxc_driver.c +++ libvirt-plain/src/lxc/lxc_driver.c @@ -800,6 +800,16 @@ static int lxcSetupInterfaces(virConnect case VIR_DOMAIN_NET_TYPE_BRIDGE: bridge = def->nets[i]->data.bridge.brname; break; + + case VIR_DOMAIN_NET_TYPE_USER: + case VIR_DOMAIN_NET_TYPE_ETHERNET: + case VIR_DOMAIN_NET_TYPE_SERVER: + case VIR_DOMAIN_NET_TYPE_CLIENT: + case VIR_DOMAIN_NET_TYPE_MCAST: + case VIR_DOMAIN_NET_TYPE_INTERNAL: + case VIR_DOMAIN_NET_TYPE_DIRECT: + case VIR_DOMAIN_NET_TYPE_LAST: + break; } DEBUG("bridge: %s", bridge); Index: libvirt-plain/src/qemu/qemu_conf.c =================================================================== --- libvirt-plain.orig/src/qemu/qemu_conf.c +++ libvirt-plain/src/qemu/qemu_conf.c @@ -2686,6 +2686,14 @@ qemuBuildHostNetStr(virDomainNetDefPtr n net->data.socket.address, net->data.socket.port); break; + case VIR_DOMAIN_NET_TYPE_USER: + case VIR_DOMAIN_NET_TYPE_ETHERNET: + case VIR_DOMAIN_NET_TYPE_NETWORK: + case VIR_DOMAIN_NET_TYPE_BRIDGE: + case VIR_DOMAIN_NET_TYPE_INTERNAL: + case VIR_DOMAIN_NET_TYPE_DIRECT: + case VIR_DOMAIN_NET_TYPE_LAST: + break; } type_sep = ','; break; Index: libvirt-plain/src/uml/uml_conf.c =================================================================== --- libvirt-plain.orig/src/uml/uml_conf.c +++ libvirt-plain/src/uml/uml_conf.c @@ -244,6 +244,14 @@ umlBuildCommandLineNet(virConnectPtr con umlReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, "%s", _("internal networking type not supported")); goto error; + + case VIR_DOMAIN_NET_TYPE_DIRECT: + umlReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, "%s", + _("direct networking type not supported")); + goto error; + + case VIR_DOMAIN_NET_TYPE_LAST: + break; } virBufferVSprintf(&buf, ",%02x:%02x:%02x:%02x:%02x:%02x", Index: libvirt-plain/src/conf/domain_conf.c =================================================================== --- libvirt-plain.orig/src/conf/domain_conf.c +++ libvirt-plain/src/conf/domain_conf.c @@ -450,6 +450,10 @@ void virDomainNetDefFree(virDomainNetDef case VIR_DOMAIN_NET_TYPE_DIRECT: VIR_FREE(def->data.direct.linkdev); break; + + case VIR_DOMAIN_NET_TYPE_USER: + case VIR_DOMAIN_NET_TYPE_LAST: + break; } VIR_FREE(def->ifname); @@ -1740,7 +1744,7 @@ virDomainNetDefParseXML(virCapsPtr caps, type = virXMLPropString(node, "type"); if (type != NULL) { - if ((def->type = virDomainNetTypeFromString(type)) < 0) { + if ((int)(def->type = virDomainNetTypeFromString(type)) < 0) { virDomainReportError(VIR_ERR_INTERNAL_ERROR, _("unknown interface type '%s'"), type); goto error; @@ -1949,6 +1953,10 @@ virDomainNetDefParseXML(virCapsPtr caps, dev = NULL; break; + + case VIR_DOMAIN_NET_TYPE_USER: + case VIR_DOMAIN_NET_TYPE_LAST: + break; } if (ifname != NULL) { @@ -4861,6 +4869,10 @@ virDomainNetDefFormat(virBufferPtr buf, virDomainNetdevMacvtapTypeToString(def->data.direct.mode)); virBufferAddLit(buf, "/>\n"); break; + + case VIR_DOMAIN_NET_TYPE_USER: + case VIR_DOMAIN_NET_TYPE_LAST: + break; } if (def->ifname)

2 1

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt
by Anthony Liguori 27 Mar '10

27 Mar '10

On 03/23/2010 10:57 AM, Paul Brook wrote: >>> I think there is a serious divergence of approach there, instanciating >>> API stating 'we are gonna deprecate them sooner or later' tell the >>> application developper 'my time is more important than yours' and not >>> really something I like to carry to the API users. >>> The main goal of libvirt remains to provide APIs needed to unify the >>> development of the virtualization layers. Having APIs which makes >>> sense only for one or 2 virtualization engines is not a problem in >>> itself, it just raises questions about the actual semantic of that API. >>> If that semantic is sound, then I see no reason to not add it, really >>> and we actually often do. >>> >> Yeah, but the problem we're facing is, I want there to be an API added >> to the management layer as part of the feature commit in qemu. If there >> has to be a discussion and decisions about how to model the API, it's >> not going to be successful. >> > I thought the monitor protocol *was* our API. If not, why not? > It is. But our API is missing key components like guest enumeration. So the fundamental topic here is, do we introduce these missing components to allow people to build directly to our interface or do we make use of the functionality that libvirt already provides if they can plumb our API directly to users. Regards, Anthony Liguori > Paul >

10 65

[libvirt] [PATCH] Mention direct device support since 0.7.7 in web doc
by Stefan Berger 27 Mar '10

27 Mar '10

In the web documentation mention that the direct device support is there since libvirt 0.7.7. A Linux kernel 2.6.34 is required for macvtap to be available as standard device. Index: libvirt-plain/docs/formatdomain.html.in =================================================================== --- libvirt-plain.orig/docs/formatdomain.html.in +++ libvirt-plain/docs/formatdomain.html.in @@ -741,8 +741,11 @@ Provides direct attachment of the virtual machine's NIC to the given - physial interface of the host. This setup requires the Linux macvtap - driver to be available. One of the modes 'vepa' + physial interface of the host. + Since 0.7.7 (QEMU and KVM only) + This setup requires the Linux macvtap + driver to be available. (Since Linux 2.6.34.) + One of the modes 'vepa' ( <a href="http://www.ieee802.org/1/files/public/docs2009/new-evb-congdon-vepa-modular…"> 'Virtual Ethernet Port Aggregator'</a>), 'bridge' or 'private' can be chosen for the operation mode of the macvtap device, 'vepa'

2 1

[libvirt] [PATCH] Fix QEMU cpu affinity at startup to include all threads
by Daniel P. Berrange 27 Mar '10

27 Mar '10

The QEMU cpu affinity is used in NUMA scenarios to ensure that guest memory is allocated from a specific node. Normally memory is allocate on demand in vCPU threads, but when using hugepages the initial thread leader allocates memory upfront. libvirt was not setting affinity of the thread leader, or I/O threads. This patch changes the code to set the process affinity in between the fork()/exec() of QEMU. This ensures that every single QEMU thread gets the affinity * src/qemu/qemu_driver.c: Set affinity on entire QEMU process at startup --- src/qemu/qemu_driver.c | 29 ++++++++++++++++------------- 1 files changed, 16 insertions(+), 13 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 257f914..2598deb 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1701,6 +1701,9 @@ qemuDetectVcpuPIDs(struct qemud_driver *driver, return 0; } +/* + * To be run between fork/exec of QEMU only + */ static int qemudInitCpuAffinity(virDomainObjPtr vm) { @@ -1708,7 +1711,8 @@ qemudInitCpuAffinity(virDomainObjPtr vm) virNodeInfo nodeinfo; unsigned char *cpumap; int cpumaplen; - qemuDomainObjPrivatePtr priv = vm->privateData; + + DEBUG0("Setting CPU affinity"); if (nodeGetInfo(NULL, &nodeinfo) < 0) return -1; @@ -1740,14 +1744,14 @@ qemudInitCpuAffinity(virDomainObjPtr vm) VIR_USE_CPU(cpumap, i); } - /* The XML config only gives a per-VM affinity, so we apply - * the same mapping to all vCPUs */ - for (i = 0 ; i < priv->nvcpupids ; i++) { - if (virProcessInfoSetAffinity(priv->vcpupids[i], - cpumap, cpumaplen, maxcpu) < 0) { - VIR_FREE(cpumap); - return -1; - } + /* We are assuming we are running between fork/exec of QEMU, so + * that getpid() gives the QEMU process ID and we know that + * no threads are running. + */ + if (virProcessInfoSetAffinity(getpid(), + cpumap, cpumaplen, maxcpu) < 0) { + VIR_FREE(cpumap); + return -1; } VIR_FREE(cpumap); @@ -2653,6 +2657,9 @@ struct qemudHookData { static int qemudSecurityHook(void *data) { struct qemudHookData *h = data; + if (qemudInitCpuAffinity(h->vm) < 0) + return -1; + if (qemuAddToCgroup(h->driver, h->vm->def) < 0) return -1; @@ -2943,10 +2950,6 @@ static int qemudStartVMDaemon(virConnectPtr conn, if (qemuDetectVcpuPIDs(driver, vm) < 0) goto abort; - DEBUG0("Setting CPU affinity"); - if (qemudInitCpuAffinity(vm) < 0) - goto abort; - DEBUG0("Setting any required VM passwords"); if (qemuInitPasswords(conn, driver, vm, qemuCmdFlags) < 0) goto abort; -- 1.6.2.5

2 1

[libvirt] [PATCH][Network] Make dhcp service enabled only if //ip/dhcp exists in network xml
by Satoru SATOH 26 Mar '10

26 Mar '10

Libvirtd enabls DHCP service on virtual networks even if the element '//ip/dhcp' does not exist in the network xml. The following patch fixes this problem. Signed-off-by: Satoru SATOH <satoru.satoh(a)gmail.com> --- src/conf/network_conf.c | 2 ++ src/conf/network_conf.h | 2 ++ src/network/bridge_driver.c | 5 +---- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 1f3a44c..e41775a 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -466,6 +466,8 @@ virNetworkDefParseXML(xmlXPathContextPtr ctxt) if ((ip = virXPathNode("./ip[1]", ctxt)) && virNetworkIPParseXML(def, ip) < 0) goto error; + + def->dhcp = (virXPathNode("./ip/dhcp", ctxt) != NULL ? 1 : 0); } diff --git a/src/conf/network_conf.h b/src/conf/network_conf.h index 127a23a..847ddd3 100644 --- a/src/conf/network_conf.h +++ b/src/conf/network_conf.h @@ -74,6 +74,8 @@ struct _virNetworkDef { char *netmask; char *network; + unsigned int dhcp; + unsigned int nranges; /* Zero or more dhcp ranges */ virNetworkDHCPRangeDefPtr ranges; diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 83ab00e..6dcf7b4 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -943,12 +943,9 @@ static int networkStartNetworkDaemon(struct network_driver *driver, goto err_delbr2; } - if ((network->def->ipAddress || - network->def->nranges) && - dhcpStartDhcpDaemon(network) < 0) + if (network->def->dhcp && dhcpStartDhcpDaemon(network) < 0) goto err_delbr2; - /* Persist the live configuration now we have bridge info */ if (virNetworkSaveConfig(NETWORK_STATE_DIR, network->def) < 0) { goto err_kill; -- 1.6.2.5

2 2

[libvirt] [PATCH 1/1] XenAPI remote storage support on libvirt
by Sharadha Prabhakar (3P) 26 Mar '10

26 Mar '10

This patch contains the APIs for support XenAPI remote storage support on libvirt. This patch allows you to list storage pools, storage volumes, get information about storage pools and volumes and create storage pools of type NETFS with format type nfs,cifs-iso,nfs-iso using virsh. You can also create VMs with storage pools attached and destroy storage pools. While creating a VM with storage. The disk tag's source element should be of the form '/storage pool uuid/storage volume uuid'. --- ./libvirt_org/src/xenapi/xenapi_storage_driver.c 1970-01-01 01:00:00.000000000 +0100 +++ ./libvirt/src/xenapi/xenapi_storage_driver.c 2010-03-24 15:27:43.000000000 +0000 @@ -0,0 +1,1499 @@ +/* + * xenapi_storage_driver.c: Xen API storage driver APIs + * Copyright (C) 2009, 2010 Citrix Ltd. + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * + * Author: Sharadha Prabhakar <sharadha.prabhakar(a)citrix.com> + */ + +#include <config.h> +#include <stdint.h> +#include <unistd.h> +#include <string.h> +#include <stdlib.h> +#include <errno.h> +#include <sys/types.h> +#include <libxml/uri.h> +#include <xen_internal.h> +#include <libxml/parser.h> +#include <curl/curl.h> +#include <xen/api/xen_common.h> +#include <xen/api/xen_vm.h> +#include <xen/api/xen_vm.h> +#include <xen/api/xen_all.h> +#include <xen/api/xen_vm_metrics.h> +#include <xen/api/xen_api_failure.h> +#include <xen/dom0_ops.h> + +#include "libvirt_internal.h" +#include "libvirt/libvirt.h" +#include "virterror_internal.h" +#include "storage_conf.h" +#include "datatypes.h" +#include "xenapi_driver.h" +#include "util.h" +#include "uuid.h" +#include "authhelper.h" +#include "memory.h" +#include "driver.h" +#include "util/logging.h" +#include "buf.h" +#include "xenapi_utils.h" +#include "xenapi_storage_driver.h" + +/* +*XenapiStorageOpen +* +*Authenticates and creates a session with the server +*Returns VIR_DRV_OPEN_SUCCESS on success, else VIR_DRV_OPEN_ERROR +*/ +static virDrvOpenStatus +xenapiStorageOpen (virConnectPtr conn, virConnectAuthPtr auth, int flags ATTRIBUTE_UNUSED) +{ + char *username = NULL; + char *password = NULL; + struct _xenapiStoragePrivate *privP = NULL; + + if (conn->uri == NULL || conn->uri->scheme == NULL || + STRCASENEQ(conn->uri->scheme, "XenAPI")) { + return VIR_DRV_OPEN_DECLINED; + } + + if (conn->uri->server == NULL) { + xenapiSessionErrorHandler(conn, VIR_ERR_AUTH_FAILED, + "Server name not in URI"); + goto error; + } + + if (auth == NULL) { + xenapiSessionErrorHandler(conn, VIR_ERR_AUTH_FAILED, + "Authentication Credentials not found"); + goto error; + } + + if (conn->uri->user != NULL) { + username = strdup(conn->uri->user); + + if (username == NULL) { + virReportOOMError(); + goto error; + } + } else { + username = virRequestUsername(auth, NULL, conn->uri->server); + + if (username == NULL) { + xenapiSessionErrorHandler(conn, VIR_ERR_AUTH_FAILED, + "Username request failed"); + goto error; + } + } + + password = virRequestPassword(auth, username, conn->uri->server); + + if (password == NULL) { + xenapiSessionErrorHandler(conn, VIR_ERR_AUTH_FAILED, + "Password request failed"); + goto error; + } + + if (VIR_ALLOC(privP) < 0) { + virReportOOMError(); + goto error; + } + + if (virAsprintf(&privP->url, "https://%s", conn->uri->server) < 0) { + virReportOOMError(); + goto error; + } + + if (xenapiUtil_ParseQuery(conn, conn->uri, &privP->noVerify) < 0) + goto error; + + xmlInitParser(); + xmlKeepBlanksDefault(0); + xen_init(); + curl_global_init(CURL_GLOBAL_ALL); + + privP->session = xen_session_login_with_password(call_func, privP, username, + password, xen_api_latest_version); + + if (privP->session != NULL && privP->session->ok) { + conn->storagePrivateData = privP; + VIR_FREE(username); + VIR_FREE(password); + return VIR_DRV_OPEN_SUCCESS; + } + + xenapiSessionErrorHandler(conn, VIR_ERR_AUTH_FAILED, ""); + + error: + VIR_FREE(username); + VIR_FREE(password); + + if (privP != NULL) { + if (privP->session != NULL) + xenSessionFree(privP->session); + + VIR_FREE(privP->url); + VIR_FREE(privP); + } + + return VIR_DRV_OPEN_ERROR; +} + + +/* +*XenapiStorageClose +* +*Closes the session with the server +*Returns 0 on success +*/ +static int +xenapiStorageClose (virConnectPtr conn) +{ + struct _xenapiStoragePrivate *priv = (struct _xenapiStoragePrivate *)conn->storagePrivateData; + xen_session_logout(priv->session); + VIR_FREE(priv->url); + VIR_FREE(priv); + return 0; + +} + +/* +*XenapiNumOfStoragePools +* +*Provides the number of active storage pools +*Returns number of pools found on success, or -1 on error +*/ +static int +xenapiNumOfStoragePools (virConnectPtr conn) +{ + xen_sr_set *sr_set=NULL; + xen_pbd_set *pbd_set=NULL; + xen_sr_record *record=NULL; + bool currently_attached; + int cnt=-1,i; + xen_session * session = ((struct _xenapiStoragePrivate *)(conn->storagePrivateData))->session; + if (xen_sr_get_all(session, &sr_set) && sr_set->size>0) { + for (i=0; i<sr_set->size; i++) { + if (xen_sr_get_record(session, &record, sr_set->contents[i])) { + if (xen_sr_get_pbds(session, &pbd_set, sr_set->contents[i]) && pbd_set->size>0) { + xen_pbd_get_currently_attached(session, &currently_attached, pbd_set->contents[0]); + if (currently_attached == 1) cnt++; + xen_pbd_set_free(pbd_set); + } else { + if (pbd_set) { + xen_pbd_set_free(pbd_set); + xen_sr_record_free(record); + xen_sr_set_free(sr_set); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Physical Block Devices not found"); + return -1; + } + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + xen_sr_record_free(record); + xen_sr_set_free(sr_set); + return -1; + } + xen_sr_record_free(record); + } else { + xen_sr_set_free(sr_set); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + return -1; + } + } + xen_sr_set_free(sr_set); + } else { + if (sr_set) { + xen_sr_set_free(sr_set); + xenapiSessionErrorHandler(conn, VIR_ERR_NO_STORAGE_POOL, ""); + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + } + } + return cnt; +} + +/* +*XenapiListStoragePools +* +*Provides the list of names of active storage pools upto maxnames +*returns number of names in the list on success ,or -1 or error +*/ +static int +xenapiListStoragePools (virConnectPtr conn, char **const names, + int maxnames) +{ + xen_sr_set *sr_set=NULL; + xen_pbd_set *pbd_set=NULL; + xen_sr_record *record=NULL; + char *usenames=NULL; + bool currently_attached; + int count=0,i; + xen_session * session = ((struct _xenapiStoragePrivate *)(conn->storagePrivateData))->session; + if (xen_sr_get_all(session, &sr_set) && sr_set->size>0) { + for (i=0; (i<sr_set->size) && (count<maxnames); i++) { + if (xen_sr_get_record(session, &record, sr_set->contents[i])) { + if (xen_sr_get_pbds(session, &pbd_set, sr_set->contents[i]) && pbd_set->size>0) { + xen_pbd_get_currently_attached(session, &currently_attached, pbd_set->contents[0]); + if (currently_attached == 1) { + if(!(usenames = strdup(record->name_label))) { + virReportOOMError(); + goto cleanup; + } + names[count++] = usenames; + } + xen_pbd_set_free(pbd_set); + } else { + if (pbd_set) { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Physical Block Devices not found"); + goto cleanup; + } + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + xen_sr_record_free(record); + xen_sr_set_free(sr_set); + return -1; + } + xen_sr_record_free(record); + } else { + xen_sr_set_free(sr_set); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + return -1; + } + } + xen_sr_set_free(sr_set); + return count; + } else { + if (sr_set) { + xen_sr_set_free(sr_set); + xenapiSessionErrorHandler(conn, VIR_ERR_NO_STORAGE_POOL, ""); + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + } + } + return -1; + cleanup: + xen_pbd_set_free(pbd_set); + xen_sr_record_free(record); + xen_sr_set_free(sr_set); + while (--count>=0) VIR_FREE(names[count]); + return -1; +} + + +/* +*XenapiListDefinedStoragePools +* +*Provides the list of names of inactive storage pools upto maxnames +* +*/ +static int +xenapiListDefinedStoragePools (virConnectPtr conn, char **const names, + int maxnames) +{ + xen_sr_set *sr_set=NULL; + xen_pbd_set *pbd_set=NULL; + xen_sr_record *record=NULL; + char *usenames=NULL; + bool currently_attached; + int count=0,i; + xen_session * session = ((struct _xenapiStoragePrivate *)(conn->storagePrivateData))->session; + if (xen_sr_get_all(session, &sr_set) && sr_set->size>0) { + for (i=0; (i<sr_set->size) && (count<maxnames); i++) { + if (xen_sr_get_record(session, &record, sr_set->contents[i])) { + if (xen_sr_get_pbds(session, &pbd_set, sr_set->contents[i]) && pbd_set->size>0) { + xen_pbd_get_currently_attached(session, &currently_attached, pbd_set->contents[0]); + if (currently_attached == 0) { + if(!(usenames = strdup(record->name_label))) { + virReportOOMError(); + goto cleanup; + } + names[count++] = usenames; + } + xen_pbd_set_free(pbd_set); + } else { + if (pbd_set) { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Physical Block Devices not found"); + goto cleanup; + } + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + xen_sr_record_free(record); + xen_sr_set_free(sr_set); + return -1; + } + xen_sr_record_free(record); + } else { + xen_sr_set_free(sr_set); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + return -1; + } + } + xen_sr_set_free(sr_set); + return count; + } else { + if (sr_set) { + xen_sr_set_free(sr_set); + xenapiSessionErrorHandler(conn, VIR_ERR_NO_STORAGE_POOL, ""); + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + } + } + return -1; + + cleanup: + xen_pbd_set_free(pbd_set); + xen_sr_record_free(record); + xen_sr_set_free(sr_set); + while (--count>=0) free(names[count]); + return -1; +} + + +/* +*XenapiNumOfDefinedStoragePools +* +*Provides the number of inactive storage pools +* +*/ +static int +xenapiNumOfDefinedStoragePools (virConnectPtr conn) +{ + xen_sr_set *sr_set=NULL; + xen_pbd_set *pbd_set=NULL; + xen_sr_record *record=NULL; + int cnt=-1,i; + xen_session * session = ((struct _xenapiStoragePrivate *)(conn->storagePrivateData))->session; + if (xen_sr_get_all(session, &sr_set) && sr_set->size>0) { + for (i=0; i<sr_set->size; i++) { + if (xen_sr_get_record(session, &record, sr_set->contents[i])) { + if (xen_sr_get_pbds(session, &pbd_set, sr_set->contents[i]) && pbd_set->size>0) { + bool currently_attached; + xen_pbd_get_currently_attached(session, &currently_attached, pbd_set->contents[0]); + if (currently_attached == 0) cnt++; + xen_pbd_set_free(pbd_set); + } else { + if (pbd_set) { + xen_pbd_set_free(pbd_set); + xen_sr_record_free(record); + xen_sr_set_free(sr_set); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Physical Block Devices not found"); + return -1; + } + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + xen_sr_record_free(record); + xen_sr_set_free(sr_set); + return -1; + } + xen_sr_record_free(record); + } else { + xen_sr_set_free(sr_set); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + return -1; + } + } + xen_sr_set_free(sr_set); + } else { + if (sr_set) { + xen_sr_set_free(sr_set); + xenapiSessionErrorHandler(conn, VIR_ERR_NO_STORAGE_POOL, ""); + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + } + } + return cnt; +} + +/* +*XenapiStoragePoolCreateXML +* +*Creates a Storage Pool from the given XML +* Only storage pool type NETFS is supported for now +*/ +static virStoragePoolPtr +xenapiStoragePoolCreateXML (virConnectPtr conn, const char *xmlDesc, + unsigned int flags ATTRIBUTE_UNUSED) +{ + virStoragePoolDefPtr pdef = NULL; + char *pooltype=NULL; + xen_sr sr=NULL; + xen_host host=NULL; + virBuffer path = VIR_BUFFER_INITIALIZER; + xen_string_string_map *device_config=NULL,*smconfig=NULL; + virStoragePoolPtr poolPtr = NULL; + unsigned char raw_uuid[VIR_UUID_BUFLEN]; + xen_sr_record *sr_record = NULL; + xen_session *session = ((struct _xenapiPrivate *)(conn->privateData))->session; + if(!(pdef = virStoragePoolDefParseString(xmlDesc))) { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Couldn't parse XML"); + virBufferFreeAndReset(&path); + return NULL; + } + if (pdef->type != VIR_STORAGE_POOL_NETFS) { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Only Pool type NETFS is currently supported"); + goto cleanup; + } else { + if (pdef->source.format == VIR_STORAGE_POOL_NETFS_NFS_ISO) { + pooltype = (char *)"iso"; + if (!pdef->source.host.name) { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Host name required for creating NFS ISO SR"); + goto cleanup; + } + if (!pdef->source.dir) { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Directory required for creating NFS ISO SR"); + goto cleanup; + } + device_config = xen_string_string_map_alloc(1); + if (!(device_config->contents[0].key = strdup("location"))) { + goto cleanup_device_config; + } + virBufferVSprintf(&path,"%s:%s",pdef->source.host.name, pdef->source.dir); + device_config->contents[0].val = virBufferContentAndReset(&path); + smconfig = xen_string_string_map_alloc(0); + } + else if (pdef->source.format == VIR_STORAGE_POOL_NETFS_CIFS_ISO) { + pooltype = (char *)"iso"; + if (!pdef->source.host.name) { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Host name required for creating CIFS ISO SR"); + goto cleanup; + } + if (!pdef->source.dir) { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Directory required for creating CIFS ISO SR"); + goto cleanup; + } + device_config = xen_string_string_map_alloc(1); + if (!(device_config->contents[0].key = strdup("location"))) + goto cleanup_device_config; + + if (pdef->source.host.name[0] != '/') { + virBufferVSprintf(&path,"//%s%s",pdef->source.host.name, pdef->source.dir); + } + else { + virBufferVSprintf(&path,"%s%s",pdef->source.host.name, pdef->source.dir); + } + device_config->contents[0].val = virBufferContentAndReset(&path); + smconfig = xen_string_string_map_alloc(1); + if (!(smconfig->contents[0].key = strdup("iso_type"))) { + xen_string_string_map_free(smconfig); + xen_string_string_map_free(device_config); + virStoragePoolDefFree(pdef); + return NULL; + } + if (!(smconfig->contents[0].val = strdup("cifs"))) { + xen_string_string_map_free(smconfig); + xen_string_string_map_free(device_config); + virStoragePoolDefFree(pdef); + return NULL; + } + } + else if (pdef->source.format == VIR_STORAGE_POOL_NETFS_NFS) { + pooltype = (char *)"nfs"; + if (!pdef->source.host.name) { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Server name required for creating NFS SR"); + goto cleanup; + } + if (!pdef->source.dir) { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Directory required for creating NFS SR"); + goto cleanup; + } + device_config = xen_string_string_map_alloc(2); + if (!(device_config->contents[0].key = strdup("server"))) + goto cleanup_device_config; + if (!(device_config->contents[0].val = strdup(pdef->source.host.name))) + goto cleanup_device_config; + if (!(device_config->contents[1].key = strdup("serverpath"))) + goto cleanup_device_config; + if (!(device_config->contents[1].val = strdup(pdef->source.dir))) + goto cleanup_device_config; + smconfig = xen_string_string_map_alloc(0); + virBufferFreeAndReset(&path); + } + else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Format type of NETFS not supported by the hypervisor"); + goto cleanup; + } + } + if (!xen_session_get_this_host(session, &host, session)) { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + virStoragePoolDefFree(pdef); + return NULL; + } + if (!xen_sr_create(session, &sr, host, device_config, 0, pdef->name, (char *)"", + pooltype, (char *) "iso", true, smconfig)) { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + virStoragePoolDefFree(pdef); + xen_host_free(host); + return NULL; + } + if (!xen_sr_get_record(session, &sr_record, sr)){ + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + virStoragePoolDefFree(pdef); + xen_host_free(host); + xen_sr_free(sr); + return NULL; + } + virUUIDParse(sr_record->uuid,raw_uuid); + poolPtr = virGetStoragePool(conn,(const char *)sr_record->name_label,raw_uuid); + if (!poolPtr) xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Couldn't get a valid storage pool pointer"); + virStoragePoolDefFree(pdef); + xen_sr_record_free(sr_record); + xen_host_free(host); + return poolPtr; + + cleanup_device_config: + xen_string_string_map_free(device_config); + + cleanup: + virStoragePoolDefFree(pdef); + virBufferFreeAndReset(&path); + return NULL; +} + +static int +xenapiStoragePoolBuild (virStoragePoolPtr pool ATTRIBUTE_UNUSED, + unsigned int flags ATTRIBUTE_UNUSED) +{ + return 0; /* return SUCCESS for now */ +} + + +static int +xenapiStoragePoolCreate (virStoragePoolPtr pool ATTRIBUTE_UNUSED, + unsigned int flags ATTRIBUTE_UNUSED) +{ + return 0; +} + + +/* +*XenapiStoragePoolSetAutostart +* +*Autostart option is always ON by default and is not allowed to be OFF +* +*/ +static int +xenapiStoragePoolSetAutostart (virStoragePoolPtr pool, int autostart) +{ + virConnectPtr conn = pool->conn; + if (autostart == 1) { + VIR_DEBUG0("XenAPI storage pools autostart option is always ON by default"); + return 0; + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Hypervisor doesn't allow autostart to be OFF"); + return -1; + } +} + + +/* +*XenapiStoragePoolGetAutostart +* +*Returns the storage pool autostart option. Which is always ON +* +*/ +static int +xenapiStoragePoolGetAutostart (virStoragePoolPtr pool ATTRIBUTE_UNUSED, + int * autostart) +{ + *autostart=1; /* XenAPI storage pools always have autostart set to ON */ + return 0; +} + + +/* +*XenapiStoragePoolLookupByName +* +* storage pool based on its unique name +* +*/ +static virStoragePoolPtr +xenapiStoragePoolLookupByName (virConnectPtr conn, + const char * name) +{ + virStoragePoolPtr poolPtr=NULL; + xen_sr_record *record=NULL; + xen_sr_set *sr_set=NULL; + xen_sr sr=NULL; + unsigned char raw_uuid[VIR_UUID_BUFLEN]; + xen_session *session = ((struct _xenapiStoragePrivate *)(conn->storagePrivateData))->session; + if (xen_sr_get_by_name_label(session, &sr_set, (char *)name) && sr_set->size>0) { + if (sr_set->size!=1) { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Storage Pool name is not unique"); + xen_sr_set_free(sr_set); + return NULL; + } + sr = sr_set->contents[0]; + if (!xen_sr_get_record(session, &record, sr)) { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + xen_sr_set_free(sr_set); + return NULL; + } + virUUIDParse(record->uuid,raw_uuid); + if (!(poolPtr = virGetStoragePool(conn,name,raw_uuid))) + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Storage Pool pointer not available"); + xen_sr_record_free(record); + xen_sr_set_free(sr_set); + } else { + if (sr_set) { + xen_sr_set_free(sr_set); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Storage Pool not found"); + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + } + } + return poolPtr; +} + + +/* +*XenapiStoragePoolGetXMLDesc +* +*Returns the configuration of a storage pool as XML +* +*/ +static char * +xenapiStoragePoolGetXMLDesc (virStoragePoolPtr pool, + unsigned int flags ATTRIBUTE_UNUSED) +{ + xen_sr_record *record=NULL; + xen_sr sr=NULL; + xen_pbd_set *pbd_set=NULL; + xen_pbd pbd=NULL; + char *pathDetails = NULL, *host=NULL, *path=NULL,*xml=NULL; + virConnectPtr conn = pool->conn; + virStoragePoolDefPtr pdef=NULL; + xen_string_string_map *smconfig=NULL; + bool cifs; + xen_string_string_map *deviceConfig=NULL; + char uuidStr[VIR_UUID_STRING_BUFLEN]; + int i; + xen_session *session = ((struct _xenapiStoragePrivate *)(conn->storagePrivateData))->session; + virUUIDFormat(pool->uuid,uuidStr); + if (xen_sr_get_by_uuid(session, &sr, uuidStr)) { + if (!xen_sr_get_record(session, &record, sr)) { + xen_sr_free(sr); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Couldn't get SR information"); + return NULL; + } + if (VIR_ALLOC(pdef)<0) { + virReportOOMError(); + xen_sr_record_free(record); + return NULL; + } + if (STREQ(record->type,"nfs") || STREQ(record->type,"iso")) + pdef->type = VIR_STORAGE_POOL_NETFS; + else if(STREQ(record->type,"iscsi")) + pdef->type = VIR_STORAGE_POOL_ISCSI; + else if(STREQ(record->type,"file")) + pdef->type = VIR_STORAGE_POOL_DIR; + else if(STREQ(record->type,"lvm")) + pdef->type = VIR_STORAGE_POOL_LOGICAL; + else if(STREQ(record->type,"ext")) { + pdef->type = VIR_STORAGE_POOL_FS; + pdef->source.format = VIR_STORAGE_POOL_FS_EXT3; + } + else if(STREQ(record->type,"hba")) + pdef->type = VIR_STORAGE_POOL_SCSI; + + if (!(pdef->name = strdup(record->name_label))) { + virReportOOMError(); + xen_sr_record_free(record); + virStoragePoolDefFree(pdef); + return NULL; + } + virUUIDParse(record->uuid,pdef->uuid); + pdef->allocation = (record->virtual_allocation)/1024; + pdef->capacity = (record->physical_size)/1024; + pdef->available = (record->physical_size - record->physical_utilisation)/1024; + + if (STREQ(record->type,"iso")) { + if (xen_sr_get_sm_config(session, &smconfig, sr)){ + cifs = false; + for (i=0;i<smconfig->size;i++){ + if (STREQ(smconfig->contents[i].key,"iso_type") + && STREQ(smconfig->contents[i].val, "cifs")) + cifs = true; + break; + } + xen_string_string_map_free(smconfig); + xen_sr_get_pbds (session, &pbd_set, sr); + pbd = pbd_set->contents[0]; + xen_pbd_get_device_config(session, &deviceConfig, pbd); + if (deviceConfig) { + for (i=0;i<deviceConfig->size;i++) { + if(STREQ(deviceConfig->contents[i].key,"location")) { + if (!(pathDetails = strdup(deviceConfig->contents[i].val))) { + virReportOOMError(); + xen_sr_record_free(record); + virStoragePoolDefFree(pdef); + xen_string_string_map_free(deviceConfig); + xen_pbd_set_free(pbd_set); + return NULL; + } + break; + } + } + xen_string_string_map_free(deviceConfig); + xen_pbd_set_free(pbd_set); + } + if (pathDetails) { + if (VIR_ALLOC_N(host,strlen(pathDetails)) <0) { + virReportOOMError(); + xen_sr_record_free(record); + virStoragePoolDefFree(pdef); + VIR_FREE(pathDetails); + return NULL; + } + if (VIR_ALLOC_N(path,strlen(pathDetails)) <0) { + virReportOOMError(); + xen_sr_record_free(record); + virStoragePoolDefFree(pdef); + VIR_FREE(host); + VIR_FREE(pathDetails); + return NULL; + } + host[0]='\0';path[0]='\0'; + if (cifs) { + pdef->source.format = VIR_STORAGE_POOL_NETFS_CIFS_ISO; + sscanf(pathDetails,"//%[^/]%s",host,path); + } else { + pdef->source.format = VIR_STORAGE_POOL_NETFS_NFS_ISO; + sscanf(pathDetails,"%[^:]:%s",host,path); + } + if (STRNEQ(host,"\0")) { + if (!(pdef->source.host.name = strdup(host))) { + virReportOOMError(); + xen_sr_record_free(record); + virStoragePoolDefFree(pdef); + VIR_FREE(host); + VIR_FREE(path); + VIR_FREE(pathDetails); + return NULL; + } + } + if (STRNEQ(path,"\0")) { + if (!(pdef->source.dir = strdup(path))) { + virReportOOMError(); + xen_sr_record_free(record); + virStoragePoolDefFree(pdef); + VIR_FREE(host); + VIR_FREE(path); + VIR_FREE(pathDetails); + return NULL; + } + } + VIR_FREE(host); + VIR_FREE(path); + VIR_FREE(pathDetails); + } + } + } + if (!(pdef->target.path = strdup("/"))) { + virReportOOMError(); + xen_sr_record_free(record); + virStoragePoolDefFree(pdef); + return NULL; + } + xen_sr_record_free(record); + xml = virStoragePoolDefFormat(pdef); + virStoragePoolDefFree(pdef); + if (!xml) + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Couldn't convert to XML format"); + return xml; + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + return NULL; + } +} + + +/* +*XenapiStoragePoolNumOfVolumes +* +*Fetch the number of storage volumes within a pool +* +*/ +static int +xenapiStoragePoolNumOfVolumes (virStoragePoolPtr pool ATTRIBUTE_UNUSED) +{ + xen_sr_set *sr_set=NULL; + xen_sr sr=NULL; + xen_vdi_set *vdi_set=NULL; + virConnectPtr conn = pool->conn; + xen_session *session = ((struct _xenapiStoragePrivate *)(conn->storagePrivateData))->session; + int count=0; + if (xen_sr_get_by_name_label(session, &sr_set, pool->name) && sr_set->size!=0) { + if (sr_set->size!=1) { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Storage Pool Name is not unique"); + xen_sr_set_free(sr_set); + return -1; + } + sr = sr_set->contents[0]; + if (xen_sr_get_vdis(session, &vdi_set, sr) && vdi_set->size!=0) { + count = vdi_set->size; + xen_sr_set_free(sr_set); + xen_vdi_set_free(vdi_set); + return count; + } else { + if (vdi_set) { + xen_vdi_set_free(vdi_set); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Volume not found"); + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + } + return -1; + } + } else { + if (sr_set) { + xen_sr_set_free(sr_set); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Storage Pool not found"); + return -1; + } + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + return -1; + } +} + + +/* +*XenapiStoragePoolListVolumes +* +*Fetch list of storage volume names, limiting to at most maxnames. +* +*/ +static int +xenapiStoragePoolListVolumes (virStoragePoolPtr pool, char ** const names, + int maxnames) +{ + xen_sr_set *sr_set=NULL; + xen_sr sr=NULL; + xen_vdi_set *vdi_set=NULL; + xen_vdi vdi=NULL; + int count,i; + char *usenames = NULL; + virConnectPtr conn=pool->conn; + xen_session *session = ((struct _xenapiStoragePrivate *)(conn->storagePrivateData))->session; + if (xen_sr_get_by_name_label(session, &sr_set, pool->name) && sr_set->size>0) { + if (sr_set->size!=1) { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Storage Pool name is not unique"); + xen_sr_set_free(sr_set); + return -1; + } + sr = sr_set->contents[0]; + if (xen_sr_get_vdis(session, &vdi_set, sr) && vdi_set->size>0) { + for (i=0,count=0; (i<vdi_set->size) && (count<maxnames); i++) { + vdi = vdi_set->contents[i]; + if (xen_vdi_get_name_label(session, &usenames, vdi)) { + names[count++] = usenames; + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + xen_vdi_set_free(vdi_set); + xen_sr_set_free(sr_set); + while(--count) VIR_FREE(names[count]); + return -1; + } + } + xen_vdi_set_free(vdi_set); + } else { + if (vdi_set) { + xen_vdi_set_free(vdi_set); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Volume not found"); + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + } + return -1; + } + xen_sr_set_free(sr_set); + return count; + } else { + if (sr_set) { + xen_sr_set_free(sr_set); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Storage Pool not found"); + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + } + } + return -1; +} + +/* +*XenapiStoragePoolIsActive +* +*Determine if the storage pool is currently running +* +*/ +static int +xenapiStoragePoolIsActive(virStoragePoolPtr pool) +{ + xen_sr sr=NULL; + xen_pbd_set *pbd_set=NULL; + virConnectPtr conn=pool->conn; + char uuid[VIR_UUID_STRING_BUFLEN]; + xen_session *session = ((struct _xenapiStoragePrivate *)(conn->storagePrivateData))->session; + virUUIDFormat(pool->uuid,uuid); + + if (xen_sr_get_by_uuid(session, &sr, uuid)) { + if (xen_sr_get_pbds(session, &pbd_set, sr) && pbd_set->size>0) { + bool currently_attached; + xen_pbd_get_currently_attached(session, &currently_attached, pbd_set->contents[0]); + xen_pbd_set_free(pbd_set); + xen_sr_free(sr); + if (currently_attached == 1) + return 1; /* running */ + else + return 0; /* not running */ + } else { + if (pbd_set) { + xen_pbd_set_free(pbd_set); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Physical Block Device not found"); + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + } + xen_sr_free(sr); + return -1; + } + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + } + return -1; +} + +/* +*XenapiStoragePoolLookupByUUID +* +*Lookup the storage pool by UUID +* +*/ +static virStoragePoolPtr +xenapiStoragePoolLookupByUUID (virConnectPtr conn, + const unsigned char * uuid) +{ + xen_sr sr = NULL; + xen_sr_record *record = NULL; + char uuidStr[VIR_UUID_STRING_BUFLEN]; + virStoragePoolPtr pool = NULL; + xen_session *session = ((struct _xenapiStoragePrivate *)(conn->storagePrivateData))->session; + virUUIDFormat(uuid,uuidStr); + if (xen_sr_get_by_uuid(session, &sr, uuidStr) && sr) { + if (xen_sr_get_record(session, &record, sr)) { + pool = virGetStoragePool(conn, record->name_label, uuid); + if (!pool) { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Couldn't get storage pool pointer"); + xen_sr_record_free(record); + return pool; + } + xen_sr_record_free(record); + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + xen_sr_free(sr); + } + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_NO_STORAGE_POOL, NULL); + } + return pool; +} + + +/* +*XenapiStoragePoolGetInfo +* +*Get information regarding the given storage pool +* +*/ +static int +xenapiStoragePoolGetInfo (virStoragePoolPtr pool, + virStoragePoolInfoPtr info) +{ + xen_sr_record *record=NULL; + xen_sr sr=NULL; + virConnectPtr conn = pool->conn; + int state = -1; + char uuid[VIR_UUID_STRING_BUFLEN]; + xen_session *session = ((struct _xenapiStoragePrivate *)(conn->storagePrivateData))->session; + virUUIDFormat(pool->uuid,uuid); + if (xen_sr_get_by_uuid(session, &sr, uuid) && sr) { + if (xen_sr_get_record(session, &record, sr)) { + info->capacity = record->physical_size; + info->allocation = record->virtual_allocation; + info->available = record->physical_size - record->physical_utilisation; + state = xenapiStoragePoolIsActive(pool); + if(state == 1) info->state = VIR_STORAGE_POOL_RUNNING; + else if(state == 0) info->state = VIR_STORAGE_POOL_INACTIVE; + xen_sr_record_free(record); + return 0; + } else { + xen_sr_free(sr); + xenapiSessionErrorHandler(conn, VIR_ERR_NO_STORAGE_POOL, NULL); + return -1; + } + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + return -1; + } +} + +/* +*XenapiStoragePoolLookupByVolume +* +*Lookup storage pool from the volume given +* +*/ +static virStoragePoolPtr +xenapiStoragePoolLookupByVolume (virStorageVolPtr vol) +{ + xen_sr_record *record=NULL; + xen_sr_set *sr_set=NULL; + xen_sr sr=NULL; + virStoragePoolPtr poolPtr=NULL; + virConnectPtr conn = vol->conn; + unsigned char raw_uuid[VIR_UUID_BUFLEN]; + xen_session *session = ((struct _xenapiStoragePrivate *)(conn->storagePrivateData))->session; + + if (xen_sr_get_by_name_label(session, &sr_set, vol->pool) && sr_set->size>0) { + if (sr_set->size!=1) { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Storage Pool name is not unique"); + xen_sr_set_free(sr_set); + return NULL; + } + sr = sr_set->contents[0]; + xen_sr_get_record(session, &record, sr); + if (record!=NULL) { + virUUIDParse(record->uuid,raw_uuid); + poolPtr = virGetStoragePool(conn,(const char *)record->name_label, raw_uuid); + if (poolPtr != NULL) { + xen_sr_record_free(record); + xen_sr_set_free(sr_set); + return poolPtr; + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Storage Pool pointer unavailable"); + } + xen_sr_record_free(record); + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + } + xen_sr_set_free(sr_set); + } else { + if (sr_set) { + xen_sr_set_free(sr_set); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Storage Pool not found"); + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + } + } + return NULL; +} + +/* +*XenapiStorageVolLookupByName +* +*Lookup Storage volume by unique name +* +*/ +static virStorageVolPtr +xenapiStorageVolLookupByName (virStoragePoolPtr pool, + const char *name) +{ + xen_vdi_set *vdi_set=NULL; + xen_vdi vdi=NULL; + virStorageVolPtr volPtr=NULL; + virConnectPtr conn = pool->conn; + char *uuid=NULL; + xen_session *session = ((struct _xenapiStoragePrivate *)(conn->storagePrivateData))->session; + + if (xen_vdi_get_by_name_label(session, &vdi_set, (char *)name) && vdi_set->size>0) { + if (vdi_set->size!=1) { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Storage Volume name is not unique"); + xen_vdi_set_free(vdi_set); + return NULL; + } + vdi = vdi_set->contents[0]; + if (xen_vdi_get_uuid(session, &uuid, vdi)) { + volPtr = virGetStorageVol(conn, pool->name, name, uuid); + if (!volPtr) xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Storage Volume pointer not available"); + VIR_FREE(uuid); + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Couldn't find the Unique key of the Storage Volume specified"); + } + xen_vdi_set_free(vdi_set); + } else { + if (vdi_set) { + xen_vdi_set_free(vdi_set); + xenapiSessionErrorHandler(conn, VIR_ERR_NO_STORAGE_VOL, "Storage Volume not found"); + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + } + } + return volPtr; +} + +/* +*XenapiStorageVolGetInfo +* +*Get information about the given storage volume +* +*/ +static int +xenapiStorageVolGetInfo (virStorageVolPtr vol, + virStorageVolInfoPtr info) +{ + virConnectPtr conn = vol->conn; + xen_vdi vdi=NULL; + xen_vdi_record *record=NULL; + xen_sr sr=NULL; + xen_sr_record *sr_record=NULL; + xen_session *session = ((struct _xenapiStoragePrivate *)(conn->storagePrivateData))->session; + int ret=-1; + //char uuid[VIR_UUID_STRING_BUFLEN]; + //virUUIDFormat((unsigned char *)vol->key,uuid); + + if (xen_vdi_get_by_uuid(session, &vdi, vol->key)) { + if (xen_vdi_get_record(session, &record, vdi)) { + info->capacity = record->virtual_size; + info->allocation = record->physical_utilisation; + if (xen_vdi_get_sr(session, &sr, vdi)) { + if (xen_sr_get_record(session, &sr_record, sr)) { + info->type = getStorageVolumeType(sr_record->type); + xen_sr_record_free(sr_record); + ret=0; + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + } + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + } + xen_vdi_record_free(record); + } else { + xen_vdi_free(vdi); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + } + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + } + return ret; +} + +static int +xenapiStoragePoolIsPersistent (virStoragePoolPtr pool ATTRIBUTE_UNUSED) +{ + return 1; /* Storage Pool is always persistent */ +} + + +/* +*XenapiStorageVolGetXMLDesc +* +*Get Storage Volume configuration as XML +* +*/ +static char * +xenapiStorageVolGetXMLDesc (virStorageVolPtr vol, unsigned int flags ATTRIBUTE_UNUSED) +{ + virBuffer buf = VIR_BUFFER_INITIALIZER; + virConnectPtr conn = vol->conn; + xen_vdi vdi=NULL; + xen_sr sr=NULL; + xen_vdi_record *record=NULL; + char *sr_uuid =NULL, *srname=NULL, *xml=NULL, *poolXml=NULL; + unsigned char raw_uuid[VIR_UUID_BUFLEN]; + virStorageVolDefPtr vdef=NULL; + virStoragePoolDefPtr pdef=NULL; + virStoragePoolPtr pool=NULL; + + xen_session *session = ((struct _xenapiStoragePrivate *)(conn->storagePrivateData))->session; + if (xen_vdi_get_by_uuid(session, &vdi, vol->key)) { + if (!xen_vdi_get_record(session, &record, vdi)) { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Couldn't get Volume information"); + xen_vdi_free(vdi); + virBufferFreeAndReset(&buf); + return NULL; + } + if (VIR_ALLOC(vdef)<0) { + virReportOOMError(); + virBufferFreeAndReset(&buf); + xen_vdi_record_free(record); + return NULL; + } + if (!(vdef->name = strdup(record->name_label))) { + virReportOOMError(); + virBufferFreeAndReset(&buf); + xen_vdi_record_free(record); + virStorageVolDefFree(vdef); + return NULL; + } + if (!(vdef->key = strdup(record->uuid))) { + virReportOOMError(); + virBufferFreeAndReset(&buf); + xen_vdi_record_free(record); + virStorageVolDefFree(vdef); + return NULL; + } + vdef->allocation = record->virtual_size; + vdef->capacity = record->physical_utilisation; + + if (xen_vdi_get_sr(session, &sr, vdi) && xen_sr_get_uuid(session, &sr_uuid, sr)) { + virBufferVSprintf(&buf, "/%s/%s", sr_uuid, record->uuid); + vdef->target.path = virBufferContentAndReset(&buf); + } + xen_sr_get_name_label(session, &srname, sr); + if (sr) xen_sr_free(sr); + xen_vdi_record_free(record); + + virUUIDParse(sr_uuid, raw_uuid); + if(!(pool = virGetStoragePool(conn, srname, raw_uuid))) { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Could get storage pool pointer"); + VIR_FREE(srname); + VIR_FREE(sr_uuid); + virStorageVolDefFree(vdef); + return NULL; + } + VIR_FREE(srname); + VIR_FREE(sr_uuid); + if (!(poolXml = xenapiStoragePoolGetXMLDesc(pool, 0))) { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Couldn't get Storage Pool XML"); + virStorageVolDefFree(vdef); + return NULL; + } + if(!(pdef = virStoragePoolDefParseString(poolXml))) { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Couldn't parse Storage Pool XML"); + VIR_FREE(poolXml); + virStorageVolDefFree(vdef); + return NULL; + } + VIR_FREE(poolXml); + if(!(xml = virStorageVolDefFormat(pdef, vdef))) { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Couldn't convert Storage Volume info to XML"); + virStorageVolDefFree(vdef); + virStoragePoolDefFree(pdef); + return NULL; + } + virStorageVolDefFree(vdef); + virStoragePoolDefFree(pdef); + return xml; + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + return NULL; + } +} + +/* +*XenapiStorageVolLookupByPath +* +*Lookup Storage Volume for the given path +* +*/ +static virStorageVolPtr +xenapiStorageVolLookupByPath (virConnectPtr conn, + ATTRIBUTE_UNUSED const char * path) +{ + xen_sr sr=NULL; + xen_vdi vdi=NULL; + virStorageVolPtr volPtr=NULL; + char *srname=NULL,*vname=NULL; + char sruuid[VIR_UUID_STRING_BUFLEN]="\0", vuuid[VIR_UUID_STRING_BUFLEN]="\0"; + xen_session *session = ((struct _xenapiStoragePrivate *)(conn->storagePrivateData))->session; + + sscanf(path,"/%[^/]/%[^/]",sruuid,vuuid); + if (STREQ(sruuid,"\0") || STREQ(vuuid,"\0")) { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Invalid path"); + return NULL; + } + if (xen_sr_get_by_uuid(session, &sr, sruuid) && xen_sr_get_name_label(session, &srname, sr)) { + if (xen_vdi_get_by_uuid(session, &vdi, vuuid) && xen_vdi_get_name_label(session, &vname, vdi)) { + if (!(volPtr = virGetStorageVol(conn, srname, vname, vuuid))) + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Storage Volume pointer not available"); + VIR_FREE(vname); + xen_vdi_free(vdi); + } else { + if (vdi) xen_vdi_free(vdi); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + } + VIR_FREE(srname); + xen_sr_free(sr); + } else { + if (sr) xen_sr_free(sr); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + } + return volPtr; +} + +/* +*XenapiStorageVolGetPath +* +*Get path for the specified storage volume +* +*/ +static char * +xenapiStorageVolGetPath (virStorageVolPtr vol) +{ + xen_vdi vdi=NULL; + virConnectPtr conn = vol->conn; + virBuffer path = VIR_BUFFER_INITIALIZER; + xen_sr sr=NULL; + char *sruuid=NULL; + xen_session *session = ((struct _xenapiStoragePrivate *)(conn->storagePrivateData))->session; + + if (xen_vdi_get_by_uuid(session, &vdi, vol->key)) { + if (xen_vdi_get_sr(session, &sr, vdi) && xen_sr_get_uuid(session, &sruuid, sr)) { + virBufferVSprintf(&path,"/%s/%s",sruuid,vol->key); + VIR_FREE(sruuid); + xen_sr_free(sr); + } else { + if (sr) xen_sr_free(sr); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + } + xen_vdi_free(vdi); + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + } + return virBufferContentAndReset(&path); +} + +static int +xenapiStoragePoolRefresh ( ATTRIBUTE_UNUSED virStoragePoolPtr pool, + ATTRIBUTE_UNUSED unsigned int flags) +{ + return 0; +} + +/* +*XenapiStorageVolLookupByKey +* +*Lookup storage volume for the given key +* +*/ +static virStorageVolPtr +xenapiStorageVolLookupByKey (virConnectPtr conn, const char * key) +{ + xen_vdi vdi=NULL; + xen_sr sr=NULL; + xen_vdi_record *vrecord=NULL; + xen_sr_record *srecord=NULL; + virStorageVolPtr volPtr=NULL; + xen_session *session = ((struct _xenapiStoragePrivate *)(conn->storagePrivateData))->session; + if (xen_vdi_get_by_uuid(session, &vdi, (char *)key) && xen_vdi_get_record(session, &vrecord, vdi)) { + if (xen_vdi_get_sr(session, &sr, vdi) && xen_sr_get_record(session, &srecord, sr)) { + volPtr = virGetStorageVol(conn, srecord->name_label, vrecord->name_label, key); + if (!volPtr) + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Storage Volume Pointer not available"); + xen_sr_record_free(srecord); + } else { + if (sr) xen_sr_free(sr); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + } + xen_vdi_record_free(vrecord); + } else { + if (vdi) xen_vdi_free(vdi); + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + } + return volPtr; +} + + +/* +*XenapiStoragePoolDestroy +* +*unplug PBDs connected to the specified storage pool +* +*/ +static int +xenapiStoragePoolDestroy (virStoragePoolPtr pool) +{ + xen_sr sr=NULL; + xen_pbd pbd=NULL; + char uuidStr[VIR_UUID_STRING_BUFLEN]; + struct xen_pbd_set *pbd_set=NULL; + int i,ret=-1; + virConnectPtr conn = pool->conn; + xen_session *session = ((struct _xenapiStoragePrivate *)(conn->storagePrivateData))->session; + virUUIDFormat(pool->uuid,uuidStr); + if (xen_sr_get_by_uuid(session, &sr, uuidStr)) { + if (xen_sr_get_pbds(session, &pbd_set, sr) && pbd_set->size>0) { + for (i=0;i<pbd_set->size;i++) { + pbd = pbd_set->contents[0]; + if (xen_pbd_unplug(session, pbd)) + ret=0; + else + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + } + xen_pbd_set_free(pbd_set); + } else { + if (pbd_set) { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "There are no PBDs in the specified pool to unplug"); + xen_pbd_set_free(pbd_set); + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + } + } + xen_sr_free(sr); + } else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + } + return ret; +} + +static virStorageDriver xenapiStorageDriver = { + "XenAPI Storage", + xenapiStorageOpen, + xenapiStorageClose, + xenapiNumOfStoragePools, + xenapiListStoragePools, + xenapiNumOfDefinedStoragePools, + xenapiListDefinedStoragePools, + NULL, + xenapiStoragePoolLookupByName, + xenapiStoragePoolLookupByUUID, + xenapiStoragePoolLookupByVolume, + xenapiStoragePoolCreateXML, + NULL, + xenapiStoragePoolBuild, + NULL, + xenapiStoragePoolCreate, + xenapiStoragePoolDestroy, + NULL, + xenapiStoragePoolRefresh, + xenapiStoragePoolGetInfo, + xenapiStoragePoolGetXMLDesc, + xenapiStoragePoolGetAutostart, + xenapiStoragePoolSetAutostart, + xenapiStoragePoolNumOfVolumes, + xenapiStoragePoolListVolumes, + xenapiStorageVolLookupByName, + xenapiStorageVolLookupByKey, + xenapiStorageVolLookupByPath, + NULL, + NULL, + NULL, + xenapiStorageVolGetInfo, + xenapiStorageVolGetXMLDesc, + xenapiStorageVolGetPath, + xenapiStoragePoolIsActive, + xenapiStoragePoolIsPersistent +}; + + +/* +*XenapiStorageRegister +* +*Register the storage driver APIs +* +*/ +int +xenapiStorageRegister (void) +{ + return virRegisterStorageDriver(&xenapiStorageDriver); +} + + + + --- ./libvirt_org/src/xenapi/xenapi_storage_driver.h 1970-01-01 01:00:00.000000000 +0100 +++ ./libvirt/src/xenapi/xenapi_storage_driver.h 2010-03-11 12:46:00.000000000 +0000 @@ -0,0 +1,42 @@ +/* + * xenapi_storage_driver.h: Xen API Storage Driver header file + * Copyright (C) 2009, 2010 Citrix Ltd. + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * + * Author: Sharadha Prabhakar <sharadha.prabhakar(a)citrix.com> + */ + + +#ifndef __VIR_XENAPI_STORAGE_H__ +#define __VIR_XENAPI_STORAGE_H__ + +#include <xen/api/xen_common.h> +#include <libxml/tree.h> + + + +/* XenAPI storage driver's private data structure */ +struct _xenapiStoragePrivate { + xen_session *session; + char *url; + int noVerify; + virCapsPtr caps; +}; + + + + +#endif /* __VIR_XENAPI_STORAGE_H__ */ --- ./src/xenapi/xenapi_utils.h_orig 2010-03-24 15:38:59.000000000 +0000 +++ ./src/xenapi/xenapi_utils.h 2010-03-23 10:44:38.000000000 +0000 @@ -56,8 +56,12 @@ #include "buf.h" #define NETWORK_DEVID_SIZE (12) +#define STORAGE_DEVID_SIZE (12) typedef uint64_t cpumap_t; +//newly added +int +createVbdStorage (virConnectPtr conn, xen_vm vm, int device, char *path, int devtype); void xenSessionFree(xen_session *session); --- ./src/xenapi/xenapi_utils.c_orig 2010-03-24 15:32:28.000000000 +0000 +++ ./src/xenapi/xenapi_utils.c 2010-03-24 15:09:41.000000000 +0000 @@ -53,6 +53,7 @@ #include "xenapi_utils.h" #include "util/logging.h" #include "qparams.h" +#include "xenapi_storage_driver.h" void xenSessionFree(xen_session *session) @@ -390,17 +391,96 @@ const char *buf, const char *filename, const char *func, size_t lineno) { struct _xenapiPrivate *priv = conn->privateData; - - if (buf == NULL && priv != NULL && priv->session != NULL) { - char *ret = returnErrorFromSession(priv->session); - virReportErrorHelper(conn, VIR_FROM_XENAPI, errNum, filename, func, lineno, _("%s"), ret); - xen_session_clear_error(priv->session); - VIR_FREE(ret); + struct _xenapiStoragePrivate *privS = conn->storagePrivateData; + char *ret = NULL; + if (buf == NULL) { + if (priv != NULL && priv->session != NULL) { + if (!priv->session->ok) { + ret = returnErrorFromSession(priv->session); + virReportErrorHelper(conn, VIR_FROM_XENAPI, errNum, filename, func, lineno, _("%s"), ret); + xen_session_clear_error(priv->session); + VIR_FREE(ret); + } + } + if (privS != NULL && privS->session !=NULL) { + if (!privS->session->ok) { + ret = returnErrorFromSession(privS->session); + virReportErrorHelper(conn, VIR_FROM_XENAPI, errNum, filename, func, lineno, _("%s"), ret); + xen_session_clear_error(privS->session); + VIR_FREE(ret); + } + } } else { virReportErrorHelper(conn, VIR_FROM_XENAPI, errNum, filename, func, lineno, _("%s"), buf); } } +/* create VBDs for VM */ +int +createVbdStorage (virConnectPtr conn, xen_vm vm, int device, char *path, int devtype) +{ + xen_vm xvm=NULL; + xen_vdi vdi=NULL; + xen_vbd vbd=NULL; + char *vmuuid=NULL; + char userdevice[STORAGE_DEVID_SIZE]="\0"; + xen_vbd_record *record=NULL; + xen_session *session = ((struct _xenapiPrivate *)(conn->privateData))->session; + char sruuid[VIR_UUID_STRING_BUFLEN]="\0", voluuid[VIR_UUID_STRING_BUFLEN]="\0"; + if (sscanf(path,"/%[^/]/%[^/]",sruuid,voluuid)!=2) + return -1; + fprintf(stderr,"\nsruuid: %s\nvoluuid: %s",sruuid,voluuid); + if (!xen_vm_get_uuid(session, &vmuuid, vm)) + return -1; + if (!xen_vm_get_by_uuid(session, &xvm, vmuuid)){ + VIR_FREE(vmuuid); + return -1; + } + VIR_FREE(vmuuid); + if (!xen_vdi_get_by_uuid(session, &vdi, voluuid)) { + xen_vm_free(xvm); + return -1; + } + sprintf(userdevice,"%d",device); + xen_vm_record_opt *vm_opt = xen_vm_record_opt_alloc(); + vm_opt->is_record = 0; + vm_opt->u.handle = xvm; + + xen_vdi_record_opt *vdi_opt = xen_vdi_record_opt_alloc(); + vdi_opt->is_record = 0; + vdi_opt->u.handle = vdi; + + record = xen_vbd_record_alloc(); + record->vm = vm_opt; + record->vdi = vdi_opt; + if (!(record->userdevice = strdup(userdevice))) { + xen_vbd_record_free(record); + return -1; + } + record->other_config = xen_string_string_map_alloc(0); + record->runtime_properties = xen_string_string_map_alloc(0); + record->qos_algorithm_params = xen_string_string_map_alloc(0); + if (devtype == VIR_DOMAIN_DISK_DEVICE_DISK) + record->type = XEN_VBD_TYPE_DISK; + else if (devtype == VIR_DOMAIN_DISK_DEVICE_CDROM) + record->type = XEN_VBD_TYPE_CD; + else { + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, "Only CDROM and HardDisk supported"); + xen_vbd_record_free(record); + return -1; + } + if (!xen_vbd_create(session, &vbd, record)){ + xenapiSessionErrorHandler(conn, VIR_ERR_INTERNAL_ERROR, NULL); + xen_vbd_record_free(record); + return -1; + } + xen_vbd_record_free(record); + + return 0; +} + + + /* creates network intereface for VM */ int createVifNetwork (virConnectPtr conn, xen_vm vm, char *device, @@ -557,6 +637,7 @@ int device_number=0; char *bridge=NULL,*mac=NULL; int i; + //support for network interfaces for (i=0;i<def->nnets;i++) { if (def->nets[i]->type == VIR_DOMAIN_NET_TYPE_BRIDGE) { if (def->nets[i]->data.bridge.brname) @@ -580,6 +661,13 @@ if (bridge) VIR_FREE(bridge); } } + //support for disks here + for (i=0;i<def->ndisks;i++) { + if (createVbdStorage(conn, *vm, i, def->disks[i]->src, def->disks[i]->device)!= 0) { + xen_vm_record_free(*record); + return -1; + } + } return 0; error_cleanup: --- ../libvirt_org/src/conf/storage_conf.c 2010-02-17 17:38:05.000000000 +0000 +++ ./src/conf/storage_conf.c 2010-03-22 15:08:36.000000000 +0000 @@ -61,7 +61,7 @@ VIR_ENUM_IMPL(virStoragePoolFormatFileSystemNet, VIR_STORAGE_POOL_NETFS_LAST, - "auto", "nfs", "glusterfs") + "auto", "nfs", "nfs-iso", "cifs-iso", "glusterfs") VIR_ENUM_IMPL(virStoragePoolFormatDisk, VIR_STORAGE_POOL_DISK_LAST, --- ../libvirt_org/src/conf/storage_conf.h 2010-02-17 17:38:06.000000000 +0000 +++ ./src/conf/storage_conf.h 2010-03-22 14:01:02.000000000 +0000 @@ -404,6 +404,8 @@ enum virStoragePoolFormatFileSystemNet { VIR_STORAGE_POOL_NETFS_AUTO = 0, VIR_STORAGE_POOL_NETFS_NFS, + VIR_STORAGE_POOL_NETFS_NFS_ISO, + VIR_STORAGE_POOL_NETFS_CIFS_ISO, VIR_STORAGE_POOL_NETFS_GLUSTERFS, VIR_STORAGE_POOL_NETFS_LAST, }; --- ./src/Makefile.am_04mar 2010-03-05 10:55:04.000000000 +0000 +++ ./src/Makefile.am 2010-03-23 18:11:50.000000000 +0000 @@ -210,7 +211,9 @@ XENAPI_DRIVER_SOURCES = \ xenapi/xenapi_driver.c xenapi/xenapi_driver.h \ xenapi_driver_private.h \ - xenapi/xenapi_utils.c xenapi/xenapi_utils.h + xenapi/xenapi_utils.c xenapi/xenapi_utils.h \ + xenapi/xenapi_storage_driver.c \ + xenapi/xenapi_storage_driver.h UML_DRIVER_SOURCES = \ uml/uml_conf.c uml/uml_conf.h \ --- ../libvirt_org/src/libvirt.c 2010-02-17 17:38:08.000000000 +0000 +++ ./src/libvirt.c 2010-03-11 12:14:33.000000000 +0000 @@ -377,6 +381,10 @@ #ifdef WITH_ESX if (esxRegister() == -1) return -1; #endif #ifdef WITH_XENAPI if (xenapiRegister () == -1) return -1; + if (xenapiStorageRegister () == -1) return -1; #endif #ifdef WITH_REMOTE if (remoteRegister () == -1) return -1; #endif --- ./src/xenapi/xenapi_driver.h_orig 2010-03-23 19:00:14.000000000 +0000 +++ ./src/xenapi/xenapi_driver.h 2010-03-11 11:11:01.000000000 +0000 @@ -25,5 +25,6 @@ extern int xenapiRegister (void); +extern int xenapiStorageRegister (void); #endif /* __VIR_XENAPI_PRIV_H__ */

1 1

[libvirt] using disk devices with mixed bus types (ide and virtio)
by Ingo Tuchscherer 26 Mar '10

26 Mar '10

Hello, While using multiple disk devices with different bus types (ide and virtio) I noticed that the order of disks is handled in a special way. The disk device which was defined as the first item will not be the first entry in the system xml file. e.g. if I define a virtio device (which is supposed to be the boot device) this would be added after all the ide devices. So it's not possible to boot from a virtio device even if I have defined other ide devices since qemu flags the first device as boot device. Is there a special reason why the disks are sorted by type (first all ide and then virtio) because that's prevents from booting virtio devices. Thanks. Mit freundlichen Grüßen / Kind regards Ingo Tuchscherer

1 0

[libvirt] [PATCH] tests: test-lib.sh portability and clean-up
by Jim Meyering 26 Mar '10

26 Mar '10

No big deal, but I saw recent additions of "test ... -a ..." (not portable) so fixed the rest, too. Now, searching for violations shows none: git grep '\<test .* -a ' Whether it's possible to rely on test -a in test scripts is debatable: perhaps you've ensured that the SHELL you use when running tests is POSIX compliant or better (I do that in coreutils), but at least in configure.ac, we should toe the line wrt portability (because *it* has less choice), so those are in a separate commit. Since this is a global change, it deserves a syntax-check rule. That's the 3/3 patch, below. 1/3 fixes test-lib.sh 2/3 fixes configure.ac >From ca7db6cb8000cc283fcee7899140d2fc892b0296 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Wed, 24 Mar 2010 09:05:27 +0100 Subject: [PATCH 1/3] tests: shell script portability and clean-up * tests/test-lib.sh: "echo -n" is not portable. Use printf instead. Remove unnecessary uses of "eval-in-subshell" (subshell is sufficient). Remove uses of tests' -a operator; it is not portable. Instead, use "test cond && test cond2". * tests/schematestutils.sh: Replace use of test's -a. --- tests/schematestutils.sh | 2 +- tests/test-lib.sh | 20 ++++++++++---------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/tests/schematestutils.sh b/tests/schematestutils.sh index 301b9eb..f172857 100644 --- a/tests/schematestutils.sh +++ b/tests/schematestutils.sh @@ -21,7 +21,7 @@ do ret=$? test_result $n $(basename $(dirname $xml))"/"$(basename $xml) $ret - if test "$verbose" = "1" -a $ret != 0 ; then + if test "$verbose" = "1" && test $ret != 0 ; then echo -e "$cmd\n$result" fi if test "$ret" != 0 ; then diff --git a/tests/test-lib.sh b/tests/test-lib.sh index 57fd438..28b830e 100644 --- a/tests/test-lib.sh +++ b/tests/test-lib.sh @@ -19,7 +19,7 @@ test_intro() name=$1 if test "$verbose" = "0" ; then echo "TEST: $name" - echo -n " " + printf " " fi } @@ -29,15 +29,15 @@ test_result() name=$2 status=$3 if test "$verbose" = "0" ; then - mod=`eval "expr $ $counter - 1 $ % 40"` - if test "$counter" != 1 -a "$mod" = 0 ; then - printf " %-3d\n" `eval "expr $counter - 1"` - echo -n " " + mod=`expr $ $counter + 40 - 1 $ % 40` + if test "$counter" != 1 && test "$mod" = 0 ; then + printf " %-3d\n" `expr $counter - 1` + printf " " fi if test "$status" = "0" ; then - echo -n "." + printf "." else - echo -n "!" + printf "!" fi else if test "$status" = "0" ; then @@ -54,11 +54,11 @@ test_final() status=$2 if test "$verbose" = "0" ; then - mod=`eval "expr $ $counter + 1 $ % 40"` - if test "$mod" != "0" -a "$mod" != "1" ; then + mod=`expr $ $counter + 1 $ % 40` + if test "$mod" != "0" && test "$mod" != "1" ; then for i in `seq $mod 40` do - echo -n " " + printf " " done fi if test "$status" = "0" ; then -- 1.7.0.3.435.g097f4 >From 7998714d60b997357bfea15d6f2d0f729fc8fb29 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Wed, 24 Mar 2010 09:10:13 +0100 Subject: [PATCH 2/3] build: don't use "test cond1 -a cond2" in configure: it's not portable * configure.ac: Use "test cond1 && test cond2" instead. --- configure.ac | 26 +++++++++++++------------- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/configure.ac b/configure.ac index bcf1d5a..2e6d2e4 100644 --- a/configure.ac +++ b/configure.ac @@ -197,10 +197,10 @@ dnl if --prefix is /usr, don't use /usr/var for localstatedir dnl or /usr/etc for sysconfdir dnl as this makes a lot of things break in testing situations -if test "$prefix" = "/usr" -a "$localstatedir" = '${prefix}/var' ; then +if test "$prefix" = "/usr" && test "$localstatedir" = '${prefix}/var' ; then localstatedir='/var' fi -if test "$prefix" = "/usr" -a "$sysconfdir" = '${prefix}/etc' ; then +if test "$prefix" = "/usr" && test "$sysconfdir" = '${prefix}/etc' ; then sysconfdir='/etc' fi @@ -240,7 +240,7 @@ AC_ARG_WITH([libvirtd], dnl dnl specific tests to setup DV devel environments with debug etc ... dnl -if [[ "${LOGNAME}" = "veillard" -a "`pwd`" = "/u/veillard/libvirt" ]] ; then +if [[ "${LOGNAME}" = "veillard" && test "`pwd`" = "/u/veillard/libvirt" ]] ; then STATIC_BINARIES="-static" else STATIC_BINARIES= @@ -351,7 +351,7 @@ LIBXENSERVER_LIBS="" LIBXENSERVER_CFLAGS="" dnl search for the XenServer library if test "$with_xenapi" != "no" ; then - if test "$with_xenapi" != "yes" -a "$with_xenapi" != "check" ; then + if test "$with_xenapi" != "yes" && test "$with_xenapi" != "check" ; then LIBXENSERVER_CFLAGS="-I$with_xenapi/include" LIBXENSERVER_LIBS="-L$with_xenapi" fi @@ -390,7 +390,7 @@ XEN_LIBS="" XEN_CFLAGS="" dnl search for the Xen store library if test "$with_xen" != "no" ; then - if test "$with_xen" != "yes" -a "$with_xen" != "check" ; then + if test "$with_xen" != "yes" && test "$with_xen" != "check" ; then XEN_CFLAGS="-I$with_xen/include" XEN_LIBS="-L$with_xen/lib64 -L$with_xen/lib" fi @@ -571,7 +571,7 @@ AC_ARG_WITH([libxml], AC_HELP_STRING([--with-libxml=@<:@PFX@:>@], [libxml2 locat if test "x$with_libxml" = "xno" ; then AC_MSG_CHECKING(for libxml2 libraries >= $LIBXML_REQUIRED) AC_MSG_ERROR([libxml2 >= $LIBXML_REQUIRED is required for libvirt]) -elif test "x$with_libxml" = "x" -a "x$PKG_CONFIG" != "x" ; then +elif test "x$with_libxml" = "x" && test "x$PKG_CONFIG" != "x" ; then PKG_CHECK_MODULES(LIBXML, libxml-2.0 >= $LIBXML_REQUIRED, [LIBXML_FOUND=yes], [LIBXML_FOUND=no]) fi if test "$LIBXML_FOUND" = "no" ; then @@ -661,7 +661,7 @@ AC_ARG_WITH([sasl], SASL_CFLAGS= SASL_LIBS= if test "x$with_sasl" != "xno"; then - if test "x$with_sasl" != "xyes" -a "x$with_sasl" != "xcheck"; then + if test "x$with_sasl" != "xyes" && test "x$with_sasl" != "xcheck"; then SASL_CFLAGS="-I$with_sasl" SASL_LIBS="-L$with_sasl" fi @@ -716,7 +716,7 @@ AC_ARG_WITH([yajl], YAJL_CFLAGS= YAJL_LIBS= if test "x$with_yajl" != "xno"; then - if test "x$with_yajl" != "xyes" -a "x$with_yajl" != "xcheck"; then + if test "x$with_yajl" != "xyes" && test "x$with_yajl" != "xcheck"; then YAJL_CFLAGS="-I$with_yajl/include" YAJL_LIBS="-L$with_yajl/lib" fi @@ -1004,7 +1004,7 @@ AC_ARG_WITH([numactl], NUMACTL_CFLAGS= NUMACTL_LIBS= -if test "$with_qemu" = "yes" -a "$with_numactl" != "no"; then +if test "$with_qemu" = "yes" && test "$with_numactl" != "no"; then old_cflags="$CFLAGS" old_libs="$LIBS" if test "$with_numactl" = "check"; then @@ -1062,7 +1062,7 @@ dnl dnl libssh checks dnl -if test "$with_libssh2" != "yes" -a "$with_libssh2" != "no"; then +if test "$with_libssh2" != "yes" && test "$with_libssh2" != "no"; then libssh2_path="$with_libssh2" elif test "$with_libssh2" = "yes"; then libssh2_path="/usr/local/lib/" @@ -1143,7 +1143,7 @@ dnl introduced in 0.4.0 release which need as minimum dnl CAPNG_CFLAGS= CAPNG_LIBS= -if test "$with_qemu" = "yes" -a "$with_capng" != "no"; then +if test "$with_qemu" = "yes" && test "$with_capng" != "no"; then old_cflags="$CFLAGS" old_libs="$LIBS" if test "$with_capng" = "check"; then @@ -1453,7 +1453,7 @@ if test "$with_storage_disk" = "yes" -o "$with_storage_disk" = "check"; then PARTED_FOUND=yes fi - if test "$with_storage_disk" != "no" -a "x$PKG_CONFIG" != "x" ; then + if test "$with_storage_disk" != "no" && test "x$PKG_CONFIG" != "x" ; then PKG_CHECK_MODULES(LIBPARTED, libparted >= $PARTED_REQUIRED, [], [PARTED_FOUND=no]) fi if test "$PARTED_FOUND" = "no"; then @@ -1635,7 +1635,7 @@ else fi AC_MSG_RESULT($RUNNING_XEND) -AM_CONDITIONAL([ENABLE_XEN_TESTS], [test "$RUNNING_XEN" != "no" -a "$RUNNING_XEND" != "no"]) +AM_CONDITIONAL([ENABLE_XEN_TESTS], [test "$RUNNING_XEN" != "no" && test "$RUNNING_XEND" != "no"]) AC_ARG_ENABLE([test-coverage], AC_HELP_STRING([--enable-test-coverage], [turn on code coverage instrumentation @<:@default=no@:>@]), -- 1.7.0.3.435.g097f4 >From 95c8ddd2eca90e3024a6f74af84517c1e0115a60 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Wed, 24 Mar 2010 09:32:43 +0100 Subject: [PATCH 3/3] maint: add syntax-check rule to prohibit use of test's -a operator * cfg.mk (sc_prohibit_test_minus_a): New rule. --- cfg.mk | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/cfg.mk b/cfg.mk index 2d0d278..4302338 100644 --- a/cfg.mk +++ b/cfg.mk @@ -269,6 +269,12 @@ sc_preprocessor_indentation: echo '$(ME): skipping test $@: cppi not installed' 1>&2; \ fi +# Using test's -a operator is not portable. +sc_prohibit_test_minus_a: + @re='\<test .+ -[a] ' \ + msg='use "test C1 && test C2, not "test C1 -''a C2"' \ + $(_prohibit_regexp) + sc_copyright_format: @$(VC_LIST_EXCEPT) | xargs grep -ni 'copyright .*Red 'Hat \ | grep -v Inc \ -- 1.7.0.3.435.g097f4

2 7

[libvirt] Supporting hypervisor specific APIs in libvirt
by Anthony Liguori 26 Mar '10

26 Mar '10

Hi, I've mentioned this to a few folks already but I wanted to start a proper thread. We're struggling in qemu with usability and one area that concerns me is the disparity in features that are supported by qemu vs what's implemented in libvirt. This isn't necessarily libvirt's problem if it's mission is to provide a common hypervisor API that covers the most commonly used features. However, for qemu, we need an API that covers all of our features that people can develop against. The ultimate question we need to figure out is, should we encourage our users to always use libvirt or should we build our own API for people (and libvirt) to consume. I don't think it's necessarily a big technical challenge for libvirt to support qemu more completely. I think it amounts to introducing a series of virQemuXXXX APIs that implement qemu specific functions. Over time, qemu specific APIs can be deprecated in favour of more generic virDomain APIs. What's the feeling about this from the libvirt side of things? Is there interest in support hypervisor specific interfaces should we be looking to provide our own management interface for libvirt to consume? Regards, Anthony Liguori

12 34

[libvirt] [PATCH] esx: Make the conf parser compare names case insensitive in VMX mode
by Matthias Bolte 26 Mar '10

26 Mar '10

The keys of entries in a VMX file are case insensitive. Both scsi0:1.fileName and scsi0:1.filename are valid. Therefore, make the conf parser compare names case insensitive in VMX mode to accept every capitalization variation. Also add test cases for this. --- src/util/conf.c | 5 ++- tests/vmx2xmldata/vmx2xml-case-insensitive-1.vmx | 51 ++++++++++++++++++++++ tests/vmx2xmldata/vmx2xml-case-insensitive-1.xml | 25 +++++++++++ tests/vmx2xmldata/vmx2xml-case-insensitive-2.vmx | 51 ++++++++++++++++++++++ tests/vmx2xmldata/vmx2xml-case-insensitive-2.xml | 25 +++++++++++ tests/vmx2xmltest.c | 9 ++++ 6 files changed, 165 insertions(+), 1 deletions(-) create mode 100644 tests/vmx2xmldata/vmx2xml-case-insensitive-1.vmx create mode 100644 tests/vmx2xmldata/vmx2xml-case-insensitive-1.xml create mode 100644 tests/vmx2xmldata/vmx2xml-case-insensitive-2.vmx create mode 100644 tests/vmx2xmldata/vmx2xml-case-insensitive-2.xml diff --git a/src/util/conf.c b/src/util/conf.c index 24588c2..ae0459e 100644 --- a/src/util/conf.c +++ b/src/util/conf.c @@ -831,7 +831,10 @@ virConfGetValue(virConfPtr conf, const char *setting) cur = conf->entries; while (cur != NULL) { - if ((cur->name != NULL) && (STREQ(cur->name, setting))) + if ((cur->name != NULL) && + ((conf->flags & VIR_CONF_FLAG_VMX_FORMAT && + STRCASEEQ(cur->name, setting)) || + STREQ(cur->name, setting))) return(cur->value); cur = cur->next; } diff --git a/tests/vmx2xmldata/vmx2xml-case-insensitive-1.vmx b/tests/vmx2xmldata/vmx2xml-case-insensitive-1.vmx new file mode 100644 index 0000000..3626c5e --- /dev/null +++ b/tests/vmx2xmldata/vmx2xml-case-insensitive-1.vmx @@ -0,0 +1,51 @@ +CONFIG.VERSION = "8" +VIRTUALHW.VERSION = "4" +FLOPPY0.PRESENT = "FALSE" +NVRAM = "FEDORA11.NVRAM" +DEPLOYMENTPLATFORM = "WINDOWS" +VIRTUALHW.PRODUCTCOMPATIBILITY = "HOSTED" +TOOLS.UPGRADE.POLICY = "USEGLOBAL" +POWERTYPE.POWEROFF = "DEFAULT" +POWERTYPE.POWERON = "DEFAULT" +POWERTYPE.SUSPEND = "DEFAULT" +POWERTYPE.RESET = "DEFAULT" + +DISPLAYNAME = "FEDORA11" +EXTENDEDCONFIGFILE = "FEDORA11.VMXF" + +SCSI0.PRESENT = "TRUE" +SCSI0.SHAREDBUS = "NONE" +SCSI0.VIRTUALDEV = "LSILOGIC" +MEMSIZE = "1024" +SCSI0:0.PRESENT = "TRUE" +SCSI0:0.FILENAME = "FEDORA11.vmdk" +SCSI0:0.DEVICETYPE = "SCSI-HARDDISK" +IDE0:0.PRESENT = "TRUE" +IDE0:0.CLIENTDEVICE = "TRUE" +IDE0:0.DEVICETYPE = "CDROM-RAW" +IDE0:0.STARTCONNECTED = "FALSE" +ETHERNET0.PRESENT = "TRUE" +ETHERNET0.NETWORKNAME = "VM NETWORK" +ETHERNET0.ADDRESSTYPE = "VPX" +ETHERNET0.GENERATEDADDRESS = "00:50:56:91:48:C7" +CHIPSET.ONLINESTANDBY = "FALSE" +GUESTOSALTNAME = "RED HAT ENTERPRISE LINUX 5 (32-BIT)" +GUESTOS = "RHEL5" +UUID.BIOS = "50 11 5E 16 9B DC 49 D7-F1 71 53 C4 D7 F9 17 10" +SNAPSHOT.ACTION = "KEEP" +SCHED.CPU.MIN = "0" +SCHED.CPU.UNITS = "MHZ" +SCHED.CPU.SHARES = "NORMAL" +SCHED.MEM.MINSIZE = "0" +SCHED.MEM.SHARES = "NORMAL" +TOOLSCRIPTS.AFTERPOWERON = "TRUE" +TOOLSCRIPTS.AFTERRESUME = "TRUE" +TOOLSCRIPTS.BEFORESUSPEND = "TRUE" +TOOLSCRIPTS.BEFOREPOWEROFF = "TRUE" + +SCSI0:0.REDO = "" +TOOLS.SYNCTIME = "FALSE" +UUID.LOCATION = "56 4D B5 06 A2 BD FB EB-AE 86 F7 D8 49 27 D0 C4" +SCHED.CPU.MAX = "UNLIMITED" +SCHED.SWAP.DERIVEDNAME = "/VMFS/VOLUMES/498076B2-02796C1A-EF5B-000AE484A6A3/FEDORA11/FEDORA11-7DE040D8.VSWP" +TOOLS.REMINDINSTALL = "TRUE" diff --git a/tests/vmx2xmldata/vmx2xml-case-insensitive-1.xml b/tests/vmx2xmldata/vmx2xml-case-insensitive-1.xml new file mode 100644 index 0000000..0be570f --- /dev/null +++ b/tests/vmx2xmldata/vmx2xml-case-insensitive-1.xml @@ -0,0 +1,25 @@ +<domain type='vmware'> + <name>FEDORA11</name> + <uuid>50115e16-9bdc-49d7-f171-53c4d7f91710</uuid> + <memory>1048576</memory> + <currentMemory>1048576</currentMemory> + <vcpu>1</vcpu> + <os> + <type arch='i686'>hvm</type> + </os> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <disk type='file' device='disk'> + <driver name='LSILOGIC'/> + <source file='[datastore] directory/FEDORA11.vmdk'/> + <target dev='sda' bus='scsi'/> + </disk> + <interface type='bridge'> + <mac address='00:50:56:91:48:c7'/> + <source bridge='VM NETWORK'/> + </interface> + </devices> +</domain> diff --git a/tests/vmx2xmldata/vmx2xml-case-insensitive-2.vmx b/tests/vmx2xmldata/vmx2xml-case-insensitive-2.vmx new file mode 100644 index 0000000..a485d03 --- /dev/null +++ b/tests/vmx2xmldata/vmx2xml-case-insensitive-2.vmx @@ -0,0 +1,51 @@ +config.version = "8" +virtualhw.version = "4" +floppy0.present = "false" +nvram = "fedora11.nvram" +deploymentplatform = "windows" +virtualhw.productcompatibility = "hosted" +tools.upgrade.policy = "useglobal" +powertype.poweroff = "default" +powertype.poweron = "default" +powertype.suspend = "default" +powertype.reset = "default" + +displayname = "fedora11" +extendedconfigfile = "fedora11.vmxf" + +scsi0.present = "true" +scsi0.sharedbus = "none" +scsi0.virtualdev = "lsilogic" +memsize = "1024" +scsi0:0.present = "true" +scsi0:0.filename = "fedora11.vmdk" +scsi0:0.devicetype = "scsi-harddisk" +ide0:0.present = "true" +ide0:0.clientdevice = "true" +ide0:0.devicetype = "cdrom-raw" +ide0:0.startconnected = "false" +ethernet0.present = "true" +ethernet0.networkname = "vm network" +ethernet0.addresstype = "vpx" +ethernet0.generatedaddress = "00:50:56:91:48:c7" +chipset.onlinestandby = "false" +guestosaltname = "red hat enterprise linux 5 (32-bit)" +guestos = "rhel5" +uuid.bios = "50 11 5e 16 9b dc 49 d7-f1 71 53 c4 d7 f9 17 10" +snapshot.action = "keep" +sched.cpu.min = "0" +sched.cpu.units = "mhz" +sched.cpu.shares = "normal" +sched.mem.minsize = "0" +sched.mem.shares = "normal" +toolscripts.afterpoweron = "true" +toolscripts.afterresume = "true" +toolscripts.beforesuspend = "true" +toolscripts.beforepoweroff = "true" + +scsi0:0.redo = "" +tools.synctime = "false" +uuid.location = "56 4d b5 06 a2 bd fb eb-ae 86 f7 d8 49 27 d0 c4" +sched.cpu.max = "unlimited" +sched.swap.derivedname = "/vmfs/volumes/498076b2-02796c1a-ef5b-000ae484a6a3/fedora11/fedora11-7de040d8.vswp" +tools.remindinstall = "true" diff --git a/tests/vmx2xmldata/vmx2xml-case-insensitive-2.xml b/tests/vmx2xmldata/vmx2xml-case-insensitive-2.xml new file mode 100644 index 0000000..766172f --- /dev/null +++ b/tests/vmx2xmldata/vmx2xml-case-insensitive-2.xml @@ -0,0 +1,25 @@ +<domain type='vmware'> + <name>fedora11</name> + <uuid>50115e16-9bdc-49d7-f171-53c4d7f91710</uuid> + <memory>1048576</memory> + <currentMemory>1048576</currentMemory> + <vcpu>1</vcpu> + <os> + <type arch='i686'>hvm</type> + </os> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <disk type='file' device='disk'> + <driver name='lsilogic'/> + <source file='[datastore] directory/fedora11.vmdk'/> + <target dev='sda' bus='scsi'/> + </disk> + <interface type='bridge'> + <mac address='00:50:56:91:48:c7'/> + <source bridge='vm network'/> + </interface> + </devices> +</domain> diff --git a/tests/vmx2xmltest.c b/tests/vmx2xmltest.c index b4eb5d5..4c93059 100644 --- a/tests/vmx2xmltest.c +++ b/tests/vmx2xmltest.c @@ -26,6 +26,7 @@ testCompareFiles(const char *vmx, const char *xml, esxVI_APIVersion apiVersion) char *vmxPtr = &(vmxData[0]); char *xmlPtr = &(xmlData[0]); virDomainDefPtr def = NULL; + virErrorPtr err = NULL; if (virtTestLoadFile(vmx, &vmxPtr, MAX_FILE) < 0) { goto failure; @@ -39,12 +40,16 @@ testCompareFiles(const char *vmx, const char *xml, esxVI_APIVersion apiVersion) apiVersion); if (def == NULL) { + err = virGetLastError(); + fprintf(stderr, "ERROR: %s\n", err != NULL ? err->message : "<unknown>"); goto failure; } formatted = virDomainDefFormat(def, VIR_DOMAIN_XML_SECURE); if (formatted == NULL) { + err = virGetLastError(); + fprintf(stderr, "ERROR: %s\n", err != NULL ? err->message : "<unknown>"); goto failure; } @@ -117,6 +122,10 @@ mymain(int argc, char **argv) } \ } while (0) + + DO_TEST("case-insensitive-1", "case-insensitive-1", esxVI_APIVersion_25); + DO_TEST("case-insensitive-2", "case-insensitive-2", esxVI_APIVersion_25); + DO_TEST("minimal", "minimal", esxVI_APIVersion_25); DO_TEST("minimal-64bit", "minimal-64bit", esxVI_APIVersion_25); -- 1.6.3.3

3 3

[libvirt] [PATCH v3 00/14] Network filtering (ACL) extensions for libvirt
by stefanb＠us.ibm.com 26 Mar '10

26 Mar '10

Hi! This is a repost of this set of patches with some of the suggested fixes applied and ipv6 support on the ebtables layer added. The following set of patches add network filtering (ACL) extensions to libvirt and enable network traffic filtering for VMs using ebtables and, depending on the networking technology being used (tap, but not macvtap), also iptables. Usage of either is optional and controlled through filters that a VM is referencing. The ebtables-level filtering is based on the XML derived from the CIM network slide 10 (filtering) from the DMTF website (http://www.dmtf.org/standards/cim/cim_schema_v2230/CIM_Network.pdf) The XML we derived from this was discussed on the list before. On the ebtables level we currently handle filtering of IPv4 and ARP traffic. The iptables-level filtering is based on similar XML where XML nodes described the particular protocol to filter for. Its extensions enable the filtering of traffic using iptables for tcp, udp, icmp, igmp, sctp and 'all' types of traffic. This list of protocols maps to the features supported by iptables and only excludes protocols like 'esp', 'ah' and 'udplite'. Currently only bridging mode is supported and based on availability of the physdev match. The filtering framework adds new libvirt virsh commands for managing the filters. The 5 new commands are: - virsh nwfilter-list - virsh nwfilter-dumpxml <name of filter> - virsh nwfilter-define <name of file containing filter desc.> - virsh nwfilter-undefine <name of filter> - virsh nwfilter-edit <name of filter> Above commands are similar to commands for already existing pools and as such much of the code directly related to the above commands could be borrowed from other drivers. The network filters can either contain rules using the above mentioned XML or contain references to other filters in order to build more complex filters that form some sort of filter tree or can contain both. An example for a filter referencing other filters would be this one here: <filter name='demofilter4' chain='root'> <uuid>66f62d1d-34c1-1421-824f-c62d5ee5e8b6</uuid> <filterref filter='no-mac-spoofing'/> <filterref filter='no-mac-broadcast'/> <filterref filter='no-arp-spoofing'/> <filterref filter='allow-dhcp'> <parameter name='DHCPSERVER' value='10.0.0.1'/> </filterref> <filterref filter='no-other-l2-traffic'/> <filterref filter='recv-only-vm-ipaddress'/> <filterref filter='recv-only-vm-macaddress'/> <filterref filter='l3-test'/> <filterref filter='ipv6test'/> </filter> A filter containing actual rules would look like this: <filter name='no-mac-broadcast' chain='ipv4'> <uuid>ffe2ccd6-edec-7360-1852-6b5ccb553234</uuid> <rule action='drop' direction='out' priority='500'> <mac dstmacaddr='ff:ff:ff:ff:ff:ff'/> </rule> </filter> The filter XML now also holds a priority attribute in the rule. This provides control over the ordering of the applied ebtables/iptables rules beyond their appearance in the XML. The domain XML has been extended to reference a top level filter from within each <interface> XML node. A valid reference to such a top level filter looks like this: <interface type='bridge'> <source bridge='static'/> <filterref filter='demofilter4'> <parameter name='IP' value='9.59.241.151'/> </filterref> </interface> In this XML a parameter IP is passed for instantiation of the referenced filters, that may require the availability of this parameter. In the above case the IP parameter's value describes the value of the IP address of the VM and allows to enable those filters to be instantiated that require this 'IP' variable. If a filter requires a parameter that is not provided, the VM will not start or the interface will not attach to a running VM. Any names of parameters can be provided for instantiation of filters and their names and values only need to pass a regular expression test. In a subsequent patch we will be adding capability to allow users to omit the IP parameter (only) and enable libvirt to learn the IP address of the VM and have it instantiate the filter once it knows it. While virtual machines are running, it is possible to update their filters. For that all running VMs' filter 'trees' are traversed to detect whether the updated filter is referenced by the VM. If so, its ebtables/iptable rules are applied. If one of the VMs' update fails allupdates are rolled back and the filter XML update is rejected. One comment about the instantiation of the rules: Since the XML allows to create nearly any possible combination of parameters to ebtables or iptables commands, I haven't used the ebtables or iptables wrappers. Instead, I am writing ebtables/iptables command into a buffer, add command line options to each one of them as described in the rule's XML, write the buffer into a file and run it as a script. For those commands that are not allowed to fail I am using the following format to run them: cmd="ebtables <some options>" r=`${cmd}` if [ $? -ne 0 ]; then echo "Failure in command ${cmd}." exit 1 fi cmd="..." [...] If one of the command fails in such a batch, the libvirt code is going pick up the error code '1', tear down anything previously established and report an error back. The actual error message shown above is currently not reported back, but can be later on with some changes to the commands running external programs that need to read the script's stdout. One comment to patch 14: It currently #include's a .c file into a .c file only for the reason so I don't have to change too much code once I change code in the underlying patch. So this has to be changed. The patch series works without patch 13, but then only supports ebtables. The patches apply to the current tip. They pass 'make syntax-check' and have been frequently run in valgrind for memory leak checks. Looking forward to your feedback on the patches. Thanks and regards, Stefan and Gerhard

5 42

[libvirt] [PATCH][QEMU driver] Catch cdrom change error
by Ryan Harper 26 Mar '10

26 Mar '10

Currently when we attempt to change the cdrom in a qemu VM the monitor doesn't generate an error if the target filename doesn't exist. I've submitted a patch[1] for this. This patch is the libvirt qemu-driver side which catches the error message from the monitor and reportes the error to libvirt. This means that virsh attach-disk cdrom commands won't appear to succeed when qemu change command actually failed. I've tested this patch on an older libvirt (rebuild libvirt-0.7.0 on my ubuntu host) but haven't rebuilt against git head since I can't quite compile that on my host. 1. http://lists.gnu.org/archive/html/qemu-devel/2010-03/msg01935.html Signed-off-by: Ryan Harper <ryanh(a)us.ibm.com> diff --git a/src/qemu/qemu_monitor_text.c b/src/qemu/qemu_monitor_text.c index 1596e59..f868907 100644 --- a/src/qemu/qemu_monitor_text.c +++ b/src/qemu/qemu_monitor_text.c @@ -905,7 +905,14 @@ int qemuMonitorTextChangeMedia(qemuMonitorPtr mon, qemuReportError(VIR_ERR_OPERATION_FAILED, _("could not eject media on %s: %s"), devname, reply); goto cleanup; - } + } + + /* Could not open message indicates bad filename */ + if (strstr(reply, "\nCould not open ")) { + qemuReportError(VIR_ERR_OPERATION_FAILED, + _("could not change media on %s: %s"), devname, reply); + goto cleanup; + } ret = 0; -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ryanh(a)us.ibm.com

1 0

[libvirt] [PATCH 00/13] Add support for all QEMU event notifications
by Daniel P. Berrange 26 Mar '10

26 Mar '10

This series adds support for (nearly) all QEMU event notifications that are currently supported by the new JSON mode monitor. - Guest reboot - RTC adjustment - Watchdog firing - Block IO errors - Graphics client connect/disconnect It required two new public APIs, and a bunch of extra function callback typedefs which will be shown in each following commit message. This scheme is extensible to support any further events against domains. It does not support events on other types of object (storage, node devices, etc), but those can follow exactly the same API design scheme should we need them in the future. We don't want to unify them at the public API level, since internally they need to dispatch to separate drivers anyway. I'm generally happy with the public API for the events, with the exception of the graphics event which is horribly complex due to the large amount of data. I'm not sure if there's a way to make that event nicer.... The full diffstat for all patches daemon/dispatch.h | 10 daemon/libvirtd.c | 20 daemon/libvirtd.h | 2 daemon/remote.c | 348 ++++++++++++++-- daemon/remote_dispatch_args.h | 2 daemon/remote_dispatch_prototypes.h | 16 daemon/remote_dispatch_table.h | 37 + examples/domain-events/events-c/event-test.c | 168 ++++++- include/libvirt/libvirt.h.in | 106 ++++ src/conf/domain_event.c | 580 ++++++++++++++++++++++++--- src/conf/domain_event.h | 82 +++ src/driver.c | 4 src/driver.h | 18 src/esx/esx_driver.c | 2 src/libvirt.c | 133 +++++- src/libvirt_private.syms | 16 src/libvirt_public.syms | 6 src/lxc/lxc_driver.c | 60 ++ src/opennebula/one_driver.c | 2 src/openvz/openvz_driver.c | 2 src/phyp/phyp_driver.c | 2 src/qemu/qemu_driver.c | 290 +++++++++++++ src/qemu/qemu_monitor.c | 77 +++ src/qemu/qemu_monitor.h | 39 + src/qemu/qemu_monitor_json.c | 144 ++++++ src/remote/remote_driver.c | 459 +++++++++++++++++---- src/remote/remote_protocol.c | 111 +++++ src/remote/remote_protocol.h | 185 ++++++-- src/remote/remote_protocol.x | 65 ++- src/test/test_driver.c | 58 ++ src/uml/uml_driver.c | 2 src/vbox/vbox_tmpl.c | 155 +++++-- src/xen/xen_driver.c | 71 ++- src/xenapi/xenapi_driver.c | 2 34 files changed, 2947 insertions(+), 327 deletions(-) Daniel

3 36

[libvirt] [PATCH 0/1] Disk error policy
by David Allan 26 Mar '10

26 Mar '10

The following patch adds support for setting the disk error policy to the domain XML and using it when setting up the qemu command line. It specifies the werror=somepolicy,rerror=somepolicy flags to tell qemu what to do in the case of an io error. This patch is my first foray into the setup of the qemu command line, so please review with heightened care. Dave David Allan (1): Add disk error policy to domain XML docs/schemas/domain.rng | 12 +++++++++++- src/conf/domain_conf.c | 15 +++++++++++++++ src/conf/domain_conf.h | 10 ++++++++++ src/libvirt_private.syms | 2 +- src/qemu/qemu_conf.c | 12 +++++++++--- tests/qemuhelptest.c | 1 + tests/qemuxml2argvtest.c | 3 +++ 7 files changed, 50 insertions(+), 5 deletions(-)

4 4