- Devel - libvirt List Archives

[libvirt] [PATCH] Fix virPipeReadUntilEOF on more than 1024 bytes of data
by Daniel Veillard 03 Nov '10

03 Nov '10

This is a bug I found while testing the smbios support, it uses virPipeReadUntilEOF to read the stdout of the exec'ed dmidecode process and this failed to capture the full output. It read only 1024 bytes. The problem is that this is based on a poll loop, and in the loop we read at most 1024 bytes per filedescriptor, but we also note in the loop if poll indicates that the process won't output more than that on that fd by setting finished[i] = 1. The simplest way is that if we read a full buffer make sure finished[i] is still 0 because we will need another pass in the loop. Daniel diff --git a/src/util/util.c b/src/util/util.c index f7c7d32..a059675 100644 --- a/src/util/util.c +++ b/src/util/util.c @@ -984,6 +984,9 @@ virPipeReadUntilEOF(int outfd, int errfd, got = read(fds[i].fd, data, sizeof(data)); + if (got == sizeof(data)) + finished[i] = 0; + if (got == 0) { finished[i] = 1; continue; -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

2 2

[libvirt] Changing the default for qcow2 creation
by Matthew Booth 03 Nov '10

03 Nov '10

I've recently been investigating a severe performance issue I noticed when writing to a qcow2-backed image. When virt-v2v is doing a format conversion from raw to qcow2, it does the following: 1. Create a new qcow2 image 2. Launch a libguestfs appliance (kvm) using the new image 3. Write the source raw data to the appliance's block device I noticed that the same process writing to a raw image rather than a qcow2 image was adequately fast, and decided to do some testing. I've attached my simple test program.[1] It does the following: 1. Start an appliance with test.img as a disk. 2. Format test.img with ext2. 3. Create a file /test 4. Write 256M of data to /test in 2M chunks Only step 4 is timed. I ran the program against test.img prepared in 4 different ways: 1. A sparse raw file: 15.3 seconds truncate --size 300M test.img 2. A preallocated raw file: 14.8 seconds fallocate -l 300M test.img 3. A sparse qcow2 file: 223.0 seconds qemu-img create -f qcow2 test.img 300M 4. A metadata preallocated qcow2 file: 14.5 seconds qemu-img create -f qcow2 -o preallocated=metadata test.img 300M With the exception of (3), I ran the test 3 times and took the middle time rounded to 1DP. I saw about 5-10% variation. I only ran the test against (3) once. The precise ordering of 1, 2 and 4 is surprising, but given the variation probably not that interesting: they're all about the same. The interesting thing is that the overhead of qcow2 metadata creation during the test seems to account for a 15x performance penalty. I had a cursory look at metadata preallocation, which I hadn't been aware of before today. Creating a qcow2 image of any size with no preallocation results in a 136k file. If you preallocate the metadata, a sparse file is created large enough to accomodate the entire image, with >136k actually used. In the above 300M case this is 204k. On a slightly more practical 20G image, 3.3M is preallocated. It's also worth noting that the image takes considerably longer to create. On my laptop, creation without preallocation is 'instantaneous' at any size. With preallocation, a 20G image takes 6 seconds to create, and a 100G image takes 26 seconds. libvirt's qemu driver doesn't currently preallocate qcow2 metadata when creating a new image. Given the tiny disk space overhead of the metadata (0.02%) and the small processing overhead of pre-creation relative to subsequent creation on-the-fly, I suggest that the libvirt qemu driver is updated to pre-allocate metadata by default. Thoughts? Matt [1] Note that I'm running this against libguestfs from git, which uses virtio-serial rather than usermode networking for appliance<->host communication. This change alone improved the performance of this test by about 10x. If your numbers don't match mine, that's probably why. I don't know off the top of my head if this change has made it into F14 yet. It's definitely not in F13. -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490

5 6

[libvirt] New PHP bindings
by Arnar Mar Sig 03 Nov '10

03 Nov '10

Hi There are few PHP libvirt bindings out there, but all I found are procedural based and incomplete. To address this I created another binding that is OO based and in large part generated from libvirt-api.xml. The extension already supports most of the API, split into 6 classes: virConnect, virDomain, virInterface, virNetwork, virStoragePool, and virStorageVol. Snapshot of the current code can be found at: http://libvirt-debian.vm.antab.is/files/php-libvirt.tar.bz2 Or using svn from: http://svn.antab.is/php-libvirt/trunk Build instructions are in the README file. Documents can be found at http://libvirt-debian.vm.antab.is/ NOTE: Most of the docs are copied from libvirt. It has mostly been tested with libvirt test backend and PHP unit tests (phpt) are used to test, covering about 40% of basic usage. It is by no means complete and missing some functionality like classmaps (So virConnect::domainLookupBy* can return user defined class extended from virDomain) and probably leaks memory. I would appreciate any input and comments. Thanks Arnar Mar Sig

3 7

[libvirt] [PATCH 00/10] Allow access to text console with virStream APIs (v2)
by Daniel P. Berrange 02 Nov '10

02 Nov '10

2 29

[libvirt] [PATCH] xen: work with ia64 MAX_VIRT_CPUS of 64
by Eric Blake 02 Nov '10

02 Nov '10

* src/xen/xen_hypervisor.c (MAX_VIRT_CPUS): Move... * src/xen/xen_driver.h (MAX_VIRT_CPUS): ...so all xen code can see same value. * src/xen/xend_internal.c (sexpr_to_xend_domain_info) (xenDaemonDomainGetVcpusFlags, xenDaemonParseSxpr) (xenDaemonFormatSxpr): Work if MAX_VIRT_CPUS is 64 on a platform where long is 64-bits. * src/xen/xm_internal.c (xenXMDomainConfigParse) (xenXMDomainConfigFormat): Likewise. --- On at least the xen/stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/jeremy/xen.git we have the case where MAX_VIRT_CPUS is 32 for x86 but 64 for ia64. That branch does not have XEN_LEGACY_MAX_VCPUS. But according to our comments, other branches had only XEN_LEGACY_MAX_VCPUS, which means that xm_internal.c would fail to compile without this patch, when targetting xen headers that lack MAX_VIRT_CPUS. src/xen/xen_driver.h | 8 ++++++++ src/xen/xen_hypervisor.c | 8 -------- src/xen/xend_internal.c | 17 +++++++++-------- src/xen/xm_internal.c | 9 +++++---- 4 files changed, 22 insertions(+), 20 deletions(-) diff --git a/src/xen/xen_driver.h b/src/xen/xen_driver.h index 53f97d4..16d22f1 100644 --- a/src/xen/xen_driver.h +++ b/src/xen/xen_driver.h @@ -29,6 +29,14 @@ # include <winsock2.h> # endif +/* xen-unstable changeset 19788 removed MAX_VIRT_CPUS from public + * headers. Its semantic was retained with XEN_LEGACY_MAX_VCPUS. + * Ensure MAX_VIRT_CPUS is defined accordingly. + */ +# if !defined(MAX_VIRT_CPUS) && defined(XEN_LEGACY_MAX_VCPUS) +# define MAX_VIRT_CPUS XEN_LEGACY_MAX_VCPUS +# endif + extern int xenRegister (void); # define XEN_UNIFIED_HYPERVISOR_OFFSET 0 diff --git a/src/xen/xen_hypervisor.c b/src/xen/xen_hypervisor.c index 3797865..ec726fe 100644 --- a/src/xen/xen_hypervisor.c +++ b/src/xen/xen_hypervisor.c @@ -109,14 +109,6 @@ typedef privcmd_hypercall_t hypercall_t; # define SYS_IFACE_MIN_VERS_NUMA 4 #endif -/* xen-unstable changeset 19788 removed MAX_VIRT_CPUS from public - * headers. Its semanitc was retained with XEN_LEGACY_MAX_VCPUS. - * Ensure MAX_VIRT_CPUS is defined accordingly. - */ -#if !defined(MAX_VIRT_CPUS) && defined(XEN_LEGACY_MAX_VCPUS) -# define MAX_VIRT_CPUS XEN_LEGACY_MAX_VCPUS -#endif - static int xen_ioctl_hypercall_cmd = 0; static int initialized = 0; static int in_init = 0; diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c index 974e96b..614c036 100644 --- a/src/xen/xend_internal.c +++ b/src/xen/xend_internal.c @@ -2192,7 +2192,7 @@ xenDaemonParseSxpr(virConnectPtr conn, } def->maxvcpus = sexpr_int(root, "domain/vcpus"); - def->vcpus = count_one_bits(sexpr_int(root, "domain/vcpu_avail")); + def->vcpus = count_one_bits_l(sexpr_u64(root, "domain/vcpu_avail")); if (!def->vcpus || def->maxvcpus < def->vcpus) def->vcpus = def->maxvcpus; @@ -2468,7 +2468,7 @@ sexpr_to_xend_domain_info(virDomainPtr domain, const struct sexpr *root, } info->cpuTime = sexpr_float(root, "domain/cpu_time") * 1000000000; vcpus = sexpr_int(root, "domain/vcpus"); - info->nrVirtCpu = count_one_bits(sexpr_int(root, "domain/vcpu_avail")); + info->nrVirtCpu = count_one_bits_l(sexpr_u64(root, "domain/vcpu_avail")); if (!info->nrVirtCpu || vcpus < info->nrVirtCpu) info->nrVirtCpu = vcpus; @@ -3706,7 +3706,7 @@ xenDaemonDomainGetVcpusFlags(virDomainPtr domain, unsigned int flags) ret = sexpr_int(root, "domain/vcpus"); if (!(flags & VIR_DOMAIN_VCPU_MAXIMUM)) { - int vcpus = count_one_bits(sexpr_int(root, "domain/vcpu_avail")); + int vcpus = count_one_bits_l(sexpr_u64(root, "domain/vcpu_avail")); if (vcpus) ret = MIN(vcpus, ret); } @@ -5770,10 +5770,11 @@ xenDaemonFormatSxpr(virConnectPtr conn, virBufferVSprintf(&buf, "(memory %lu)(maxmem %lu)", def->mem.cur_balloon/1024, def->mem.max_balloon/1024); virBufferVSprintf(&buf, "(vcpus %u)", def->maxvcpus); - /* Computing the vcpu_avail bitmask works because MAX_VIRT_CPUS is 32. */ - verify(MAX_VIRT_CPUS <= sizeof(1U) * CHAR_BIT); + /* Computing the vcpu_avail bitmask works because MAX_VIRT_CPUS is + either 32, or 64 on a platform where long is big enough. */ + verify(MAX_VIRT_CPUS <= sizeof(1UL) * CHAR_BIT); if (def->vcpus < def->maxvcpus) - virBufferVSprintf(&buf, "(vcpu_avail %u)", (1U << def->vcpus) - 1); + virBufferVSprintf(&buf, "(vcpu_avail %lu)", (1UL << def->vcpus) - 1); if (def->cpumask) { char *ranges = virDomainCpuSetFormat(def->cpumask, def->cpumasklen); @@ -5870,8 +5871,8 @@ xenDaemonFormatSxpr(virConnectPtr conn, virBufferVSprintf(&buf, "(vcpus %u)", def->maxvcpus); if (def->vcpus < def->maxvcpus) - virBufferVSprintf(&buf, "(vcpu_avail %u)", - (1U << def->vcpus) - 1); + virBufferVSprintf(&buf, "(vcpu_avail %lu)", + (1UL << def->vcpus) - 1); for (i = 0 ; i < def->os.nBootDevs ; i++) { switch (def->os.bootDevs[i]) { diff --git a/src/xen/xm_internal.c b/src/xen/xm_internal.c index f80e252..6c5df0f 100644 --- a/src/xen/xm_internal.c +++ b/src/xen/xm_internal.c @@ -776,7 +776,7 @@ xenXMDomainConfigParse(virConnectPtr conn, virConfPtr conf) { def->maxvcpus = count; if (xenXMConfigGetULong(conf, "vcpu_avail", &count, -1) < 0) goto cleanup; - def->vcpus = MIN(count_one_bits(count), def->maxvcpus); + def->vcpus = MIN(count_one_bits_l(count), def->maxvcpus); if (xenXMConfigGetString(conf, "cpus", &str, NULL) < 0) goto cleanup; @@ -2336,10 +2336,11 @@ virConfPtr xenXMDomainConfigFormat(virConnectPtr conn, if (xenXMConfigSetInt(conf, "vcpus", def->maxvcpus) < 0) goto no_memory; - /* Computing the vcpu_avail bitmask works because MAX_VIRT_CPUS is 32. */ - verify(MAX_VIRT_CPUS <= sizeof(1U) * CHAR_BIT); + /* Computing the vcpu_avail bitmask works because MAX_VIRT_CPUS is + either 32, or 64 on a platform where long is big enough. */ + verify(MAX_VIRT_CPUS <= sizeof(1UL) * CHAR_BIT); if (def->vcpus < def->maxvcpus && - xenXMConfigSetInt(conf, "vcpu_avail", (1U << def->vcpus) - 1) < 0) + xenXMConfigSetInt(conf, "vcpu_avail", (1UL << def->vcpus) - 1) < 0) goto no_memory; if ((def->cpumask != NULL) && -- 1.7.2.3

5 12

[libvirt] could no query memory balloon allocation
by Marc Haber 02 Nov '10

02 Nov '10

Hi, I am playing around with libvirt and KVM on a Debian sid system (with a self-built kernel 2.6.36, 64bit kernel and 32bit userland). I have pulled libvirt 0.8.4 from experimental. When I try staring a VM using virtu-manager, I get the error message "Error starting domain: operation failed: could not query memory balloon allocation". This is probably some weird timing issue - when I have an strace attached to the libvirtd, everything is fine. In the #kvm IRC channel, people have told me that there may be an issue between some kernel versions and some libvirt versions, but neither the list archives nor the git changelog of 0.8.5 indicate such an issue (and #virt on oftc is quiet as usual). Can anybody explain what is going on on my system and what I could do to work around the issue? Greetings Marc -- ----------------------------------------------------------------------------- Marc Haber | "I don't trust Computers. They | Mailadresse im Header Mannheim, Germany | lose things." Winona Ryder | Fon: *49 621 72739834 Nordisch by Nature | How to make an American Quilt | Fax: *49 3221 2323190

1 0

[libvirt] [PATCH] Fix build with polkit 0
by Jim Fehlig 02 Nov '10

02 Nov '10

Commit e8066d53 broke the build with polkit0: remote.c: In function 'remoteDispatchAuthPolkit': remote.c:4177: error: 'rv' undeclared (first use in this function) Add missing identifier. --- daemon/remote.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/daemon/remote.c b/daemon/remote.c index 886d53d..3cf3886 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -4152,6 +4152,7 @@ remoteDispatchAuthPolkit (struct qemud_server *server, DBusError err; const char *action; char ident[100]; + int rv; memset(ident, 0, sizeof ident); -- 1.6.0.2

2 2

[libvirt] how to attach PCI/USB device
by Zdenek Styblik 02 Nov '10

02 Nov '10

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello list and its users, as subject suggests, I'm trying to attach PCI/USB devices to Guest(VM). A-and, it doesn't work. But I swear I had it before(somewhat in the beginnings). I'm using virt-managers to add/attach devices. I've failed to attach PCI device, but it "does not" matter right now. I can attach USB devices, but they are not in VM. I've tried to attach USB HUB as well and what not - nothing. So, could somebody please tell me, how to debug it? Could it be somehow connected with qemu-kvm running 'root-less'? libvirt-0.8.4 and 0.8.5. Thank you all and nice whatever-timezone-you-are-in, Zdenek - -- Zdenek Styblik Net/Linux admin OS TurnovFree.net email: stybla(a)turnovfree.net jabber: stybla(a)jabber.turnovfree.net -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkzPCuQACgkQ8MreUbSH7imBMACcCW+DQ4lwNmcPiM9kXNjbHIWD o68An3RwjHN98zlQumJsCGbnG5Xie0WB =4ZBd -----END PGP SIGNATURE-----

3 6

[libvirt] libvirtd: how to react on qemu watchdog events
by Hu Tao 02 Nov '10

02 Nov '10

Hi, I'm currently seeking a way to monitor qemu watchdog events and do somthing based on these events. Although there is a good example at libvirt-source/examples/domain-events/events-c/event-test.c to start with, and I did achieve my goal by little modification of the example, but it ran as a libvirt client. How can I make libvirtd monitor the events and react on them? Thanks a lot!

2 1

[libvirt] [PATCH] Fix several warnings about a non-literal format string
by Jiri Denemark 02 Nov '10

02 Nov '10

They only popped up during --disable-nls build. Without this configure option, gcc wasn't able to detect them. --- I already pushed this since it's both trivial and build-breaking. src/esx/esx_vmx.c | 2 +- src/util/iptables.c | 2 +- src/util/network.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/esx/esx_vmx.c b/src/esx/esx_vmx.c index 0a26614..36818df 100644 --- a/src/esx/esx_vmx.c +++ b/src/esx/esx_vmx.c @@ -2611,7 +2611,7 @@ esxVMX_FormatConfig(esxVMX_Context *ctx, virCapsPtr caps, virDomainDefPtr def, /* def:maxvcpus -> vmx:numvcpus */ if (def->vcpus != def->maxvcpus) { - ESX_ERROR(VIR_ERR_CONFIG_UNSUPPORTED, + ESX_ERROR(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("No support for domain XML entry 'vcpu' attribute " "'current'")); goto cleanup; diff --git a/src/util/iptables.c b/src/util/iptables.c index fc656b9..fe78d1c 100644 --- a/src/util/iptables.c +++ b/src/util/iptables.c @@ -334,7 +334,7 @@ static char *iptablesFormatNetwork(virSocketAddr *netaddr, if (!VIR_SOCKET_IS_FAMILY(netaddr, AF_INET) || !VIR_SOCKET_IS_FAMILY(netmask, AF_INET)) { - iptablesError(VIR_ERR_CONFIG_UNSUPPORTED, + iptablesError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("Only IPv4 addresses can be used with iptables")); return NULL; } diff --git a/src/util/network.c b/src/util/network.c index 81ac228..1abe78b 100644 --- a/src/util/network.c +++ b/src/util/network.c @@ -80,7 +80,7 @@ virSocketParseAddr(const char *val, virSocketAddrPtr addr, int family) { int err; if (val == NULL) { - virSocketError(VIR_ERR_INVALID_ARG, _("Missing address")); + virSocketError(VIR_ERR_INVALID_ARG, "%s", _("Missing address")); return -1; } @@ -173,7 +173,7 @@ virSocketFormatAddrFull(virSocketAddrPtr addr, int err; if (addr == NULL) { - virSocketError(VIR_ERR_INVALID_ARG, _("Missing address")); + virSocketError(VIR_ERR_INVALID_ARG, "%s", _("Missing address")); return NULL; } -- 1.7.3.2

1 0

Re: [libvirt] SPAM-LOW: Re: Re: Node.GetInfo error
by arnaud.champion＠devatom.fr 02 Nov '10

02 Nov '10

?:S I'm far away from a git expert :S Maybe anyone on the list can help us ? Arnaud From: 黄亮 Sent: Monday, November 01, 2010 2:42 PM To: arnaud.champion(a)devatom.fr Subject: Re: Re: Re: SPAM-LOW: Re: Re: Node.GetInfo error Hi Arnaud, I tried GitExtension, but while applying patch, it returns "Patch format detection failed. " Should I change some settings or is there something not right in the patch file? Regards 2010-11-01 -------------------------------------------------------------------------------- Lancer -------------------------------------------------------------------------------- 发件人： arnaud.champion(a)devatom.fr 发送时间： 2010-11-01 16:55:51 收件人：黄亮抄送： libvir-list(a)redhat.com 主题： Re: Re: SPAM-LOW: Re: Re: Node.GetInfo error Ok, if you are under windows (like me), use GitExtension (http://sourceforge.net/projects/gitextensions/) It works, not perfect, but it works. Arnaud From: 黄亮 Sent: Monday, November 01, 2010 9:52 AM To: arnaud.champion(a)devatom.fr Subject: Re: Re: SPAM-LOW: Re: Re: Node.GetInfo error Hi Arnaud, The NodeInfoStructure you sent to me yesterday works, thank you. I saw your patch file, should I manually apply it to the source code or is there some tools I can use to automatically apply the changes? Regards 2010-11-01 -------------------------------------------------------------------------------- Lancer -------------------------------------------------------------------------------- 发件人： arnaud.champion(a)devatom.fr 发送时间： 2010-11-01 16:37:17 收件人：黄亮抄送： libvir-list 主题： Re: SPAM-LOW: Re: Re: Node.GetInfo error Hi, I think the solution is in the last patches I have send (which are not yet in the git). Have you tried the NodeInfoStructure I have sended yesterday ? Arnaud From: 黄亮 Sent: Monday, November 01, 2010 3:01 AM To: arnaud.champion(a)devatom.fr Cc: libvir-list Subject: SPAM-LOW: Re: Re: Node.GetInfo error HI, I tried Errors.Error err = Errors.GetLastError(); MessageBox.Show(err.Message); But IDE shows compilation errors that there is no "Error" defination in "Errors", and "Errors.GetLastError()" returns int. I made a guess that maybe it was like this: Error err = Errors.SaveLastError(); MessageBox.Show("Get Info error: " + err.Message); It can be compiled but "err.Message" has nothing in it. Did I make a wrong assumption? Regards 2010-11-01 -------------------------------------------------------------------------------- Lancer -------------------------------------------------------------------------------- 发件人： arnaud.champion(a)devatom.fr 发送时间： 2010-10-31 16:48:15 收件人：黄亮抄送： libvir-list(a)redhat.com 主题： Re: Node.GetInfo error Ok, at first GetLastError return an Error object. So you should anything like : Errors.Error err = Errors.GetLastError(); MessageBox.Show(err.Message); For the NodeInfo structure, I think the problem is the same that was for DomainInfo, I'll check marshaling. Then respond you with the correct infos. Arnaud PS : can you also put libvirt-list(a)redhat.com in copy of your mails, to keep everyone in the loop ? From: 黄亮 Sent: Sunday, October 31, 2010 8:20 AM To: arnaud.champion Subject: Node.GetInfo error Hi, Sorry for disturbing again. But I get error while using Node.GetInfo. Code: NodeInfo aNodeInfo = new NodeInfo(); if (Node.GetInfo(con, aNodeInfo) < 0) { //MessageBox.Show("Node Info Error"); MessageBox.Show(Errors.GetLastError().ToString()); return 0f; } I'm sure con != IntPtr.Zero. I tried to use Errors.GetLastError(), it returns int. But I don't know what to do with it. So, any suggestions ? Thanks Regards 2010-10-31 -------------------------------------------------------------------------------- Lancer __________ Information from ESET Smart Security, version of virus signature database 5577 (20101030) __________ The message was checked by ESET Smart Security. http://www.eset.com __________ Information from ESET Smart Security, version of virus signature database 5580 (20101031) __________ The message was checked by ESET Smart Security. http://www.eset.com

5 7

[libvirt] [PATCH] [TCK] network: create networks and check for exected results
by Stefan Berger 02 Nov '10

02 Nov '10

Derived from the nwfilter test program, this one works with libvirt's networks. It creates networks from provided xml files and checks for expected configuration in iptables, running processes and virsh output using provided data files with commands to execute and the expected results for after creating the network and after tearing it down (*.post.dat). 3 tests are currently not passing due to a bug in libvirt... Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com> --- Build.PL | 2 scripts/networks/100-apply-verify-host.t | 10 scripts/networks/networkApplyTest.sh | 343 +++++++++++++ scripts/networks/networkxml2hostout/tck-testnet-1.dat | 11 scripts/networks/networkxml2hostout/tck-testnet-1.post.dat | 4 scripts/networks/networkxml2hostout/tck-testnet-2.dat | 8 scripts/networks/networkxml2hostout/tck-testnet-2.post.dat | 4 scripts/networks/networkxml2xmlin/tck-testnet-1.xml | 12 scripts/networks/networkxml2xmlin/tck-testnet-2.xml | 12 9 files changed, 405 insertions(+), 1 deletion(-) Index: libvirt-tck/scripts/networks/networkApplyTest.sh =================================================================== --- /dev/null +++ libvirt-tck/scripts/networks/networkApplyTest.sh @@ -0,0 +1,343 @@ +#!/bin/bash + +VIRSH=virsh + +uri= +if [ "x${LIBVIRT_TCK_CONFIG}x" != "xx" ]; then + uri_exp=`cat ${LIBVIRT_TCK_CONFIG} | grep "^uri\s*=" | sed -e 's/uri\s*=\s*//' | tail -n 1` + if [ "x${uri_exp}x" != "xx" ]; then + eval "uri=${uri_exp}" + fi + if [ "x${uri}x" == "xx" ]; then + uri="qemu:///system" + fi +else + uri="qemu:///system" +fi +LIBVIRT_URI=${uri} + + +FLAG_WAIT="$((1<<0))" +FLAG_VERBOSE="$((1<<2))" +FLAG_LIBVIRT_TEST="$((1<<3))" +FLAG_TAP_TEST="$((1<<4))" +FLAG_FORCE_CLEAN="$((1<<5))" + +failctr=0 +passctr=0 +attachfailctr=0 +attachctr=0 + +TAP_FAIL_LIST="" +TAP_FAIL_CTR=0 +TAP_TOT_CTR=0 + +function usage() { + local cmd="$0" +cat <<EOF +Usage: ${cmd} [--help|-h|-?] [--noattach] [--wait] [--verbose] + [--libvirt-test] [--tap-test] + +Options: + --help,-h,-? : Display this help screen. + --wait : Wait for the user to press the enter key once an error + was detected + --verbose : Verbose output + --libvirt-test : Use the libvirt test output format + --tap-test : TAP format output + --force : Allow the automatic cleaning of VMs and networks + previously created by the TCK test suite + +This test creates libvirt 'networks' and checks for expected results +(iptables, running processes (dnsmasq)) using provided xml and data +file respectively. +EOF +} + + +function tap_fail() { + echo "not ok $1 - ${2:0:66}" + TAP_FAIL_LIST+="$1 " + ((TAP_FAIL_CTR++)) + ((TAP_TOT_CTR++)) +} + +function tap_pass() { + echo "ok $1 - ${2:0:70}" + ((TAP_TOT_CTR++)) +} + +function tap_final() { + local okay + + [ -n "${TAP_FAIL_LIST}" ] && echo "FAILED tests ${TAP_FAIL_LIST}" + + okay=`echo "($TAP_TOT_CTR-$TAP_FAIL_CTR)*100/$TAP_TOT_CTR" | bc -l` + echo "Failed ${TAP_FAIL_CTR}/${TAP_TOT_CTR} tests, ${okay:0:5}% okay" +} + +# A wrapper for mktemp in case it does not exist +# Echos the name of a temporary file. +function mktmpfile() { + local tmp + type -P mktemp > /dev/null + if [ $? -eq 0 ]; then + tmp=$(mktemp -t nwfvmtest.XXXXXX) + echo ${tmp} + else + while :; do + tmp="/tmp/nwfvmtest.${RANDOM}" + if [ ! -f ${tmp} ]; then + touch ${tmp} + chmod 666 ${tmp} + echo ${tmp} + break + fi + done + fi + return 0 +} + + +function checkExpectedOutput() { + local xmlfile="$1" + local datafile="$2" + local flags="$3" + local skipregex="$4" + local cmd line tmpfile tmpfile2 skip + + tmpfile=`mktmpfile` + tmpfile2=`mktmpfile` + + exec 4<${datafile} + + read <&4 + line="${REPLY}" + + while [ "x${line}x" != "xx" ]; do + cmd=`echo ${line##\#}` + + skip=0 + if [ "x${skipregex}x" != "xx" ]; then + skip=`echo ${cmd} | grep -c -E ${skipregex}` + fi + + eval ${cmd} 2>&1 | tee ${tmpfile} 1>/dev/null + + rm ${tmpfile2} 2>/dev/null + touch ${tmpfile2} + + while [ 1 ]; do + read <&4 + line="${REPLY}" + + if [ "${line:0:1}" == "#" ] || [ "x${line}x" == "xx" ]; then + + if [ ${skip} -ne 0 ]; then + break + fi + + diff ${tmpfile} ${tmpfile2} >/dev/null + + if [ $? -ne 0 ]; then + if [ $((flags & FLAG_VERBOSE)) -ne 0 ]; then + echo "FAIL ${xmlfile} : ${cmd}" + diff ${tmpfile} ${tmpfile2} + fi + ((failctr++)) + if [ $((flags & FLAG_WAIT)) -ne 0 ]; then + echo "tmp files: $tmpfile, $tmpfile2" + echo "Press enter" + read + fi + [ $((flags & FLAG_LIBVIRT_TEST)) -ne 0 ] && \ + test_result $((passctr+failctr)) "" 1 + [ $((flags & FLAG_TAP_TEST)) -ne 0 ] && \ + tap_fail $((passctr+failctr)) "${xmlfile} : ${cmd}" + else + ((passctr++)) + [ $((flags & FLAG_VERBOSE)) -ne 0 ] && \ + echo "PASS ${xmlfile} : ${cmd}" + [ $((flags & FLAG_LIBVIRT_TEST)) -ne 0 ] && \ + test_result $((passctr+failctr)) "" 0 + [ $((flags & FLAG_TAP_TEST)) -ne 0 ] && \ + tap_pass $((passctr+failctr)) "${xmlfile} : ${cmd}" + fi + + break + + fi + echo "${line}" >> ${tmpfile2} + done + done + + exec 4>&- + + rm -rf "${tmpfile}" "${tmpfile2}" 2>/dev/null +} + + +function doTest() { + local xmlfile="$1" + local datafile="$2" + local postdatafile="$3" + local flags="$4" + local netname + + if [ ! -r "${xmlfile}" ]; then + echo "FAIL : Cannot access filter XML file ${xmlfile}." + return 1 + fi + + netname=`cat "${xmlfile}" | sed -n 's/.*<name>$[[:print:]]*$<.*/\1/p'` + + ${VIRSH} net-create "${xmlfile}" > /dev/null + + checkExpectedOutput "${xmlfile}" "${datafile}" "${flags}" "" + + ${VIRSH} net-destroy "${netname}" > /dev/null + + if [ -r ${postdatafile} ]; then + checkExpectedOutput "${xmlfile}" "${postdatafile}" "${flags}" "" + fi + + return 0 +} + + +function runTests() { + local xmldir="$1" + local hostoutdir="$2" + local flags="$3" + local datafiles f c + local tap_total=0 ctr=0 + + pushd ${PWD} > /dev/null + cd ${hostoutdir} + datafiles=`ls *.dat` + popd > /dev/null + + if [ $((flags & FLAG_TAP_TEST)) -ne 0 ]; then + # Need to count the number of total tests + for fil in ${datafiles}; do + c=$(grep -c "^#" ${hostoutdir}/${fil}) + ((tap_total+=c)) + ((ctr++)) + done + echo "1..${tap_total}" + fi + + for fil in `echo "${datafiles}" | grep -v "\.post\.dat$"`; do + f=${fil%%.dat} + doTest "${xmldir}/${f}.xml" "${hostoutdir}/${fil}" \ + "${hostoutdir}/${f}.post.dat" "${flags}" + done + + if [ $((flags & FLAG_LIBVIRT_TEST)) -ne 0 ]; then + test_final $((passctr+failctr)) $failctr + elif [ $((flags & FLAG_TAP_TEST)) -ne 0 ]; then + tap_final + else + echo "" + echo "Summary: ${failctr} failures, ${passctr} passes," + if [ ${attachctr} -ne 0 ]; then + echo " ${attachfailctr} interface attachment failures with ${attachctr} attempts" + fi + fi +} + + +function main() { + local prgname="$0" + local vm1 vm2 + local xmldir="networkxml2xmlin" + local hostoutdir="networkxml2hostout" + local res rc + local flags + + while [ $# -ne 0 ]; do + case "$1" in + --help|-h|-\?) usage ${prgname}; exit 0;; + --wait) ((flags |= FLAG_WAIT ));; + --verbose) ((flags |= FLAG_VERBOSE ));; + --libvirt-test) ((flags |= FLAG_LIBVIRT_TEST ));; + --tap-test) ((flags |= FLAG_TAP_TEST ));; + --force) ((flags |= FLAG_FORCE_CLEAN ));; + *) usage ${prgname}; exit 1;; + esac + shift 1 + done + + if [ `uname` != "Linux" ]; then + if [ $((flags & FLAG_TAP_TEST)) -ne 0 ]; then + echo "1..0 # Skipped: Only valid on Linux hosts" + else + echo "This script will only run on Linux." + fi + exit 1; + fi + + if [ $((flags & FLAG_TAP_TEST)) -ne 0 ]; then + if [ "${LIBVIRT_URI}" != "qemu:///system" ]; then + echo "1..0 # Skipped: Only valid for Qemu system driver" + exit 0 + fi + + for name in `virsh list | awk '{print $2}'` + do + case ${name} in + tck*) + if [ "x${LIBVIRT_TCK_AUTOCLEAN}" == "x1" -o \ + $((flags & FLAG_FORCE_CLEAN)) -ne 0 ]; then + res=$(virsh destroy ${name} 2>&1) + res=$(virsh undefine ${name} 2>&1) + if [ $? -ne 0 ]; then + echo "Bail out! Could not undefine VM ${name}: ${res}" + exit 0 + fi + else + echo "Bail out! TCK VMs from previous tests still exist, use --force to clean" + exit 1 + fi + esac + done + + for name in `virsh net-list | sed -n '3,$p'` + do + case ${name} in + tck*) + if [ "x${LIBVIRT_TCK_AUTOCLEAN}" == "x1" -o \ + $((flags & FLAG_FORCE_CLEAN)) -ne 0 ]; then + res=$(virsh net-destroy ${name} 2>&1) + rc=$? + res=$(virsh net-undefine ${name} 2>&1) + if [ $rc -ne 0 -a $? -ne 0 ]; then + echo "Bail out! Could not destroy/undefine network ${name}: ${res}" + exit 1 + fi + else + echo "Bail out! Network ${name} already exists, use --force to clean" + exit 1 + fi + esac + done + fi + + if [ $((flags & FLAG_LIBVIRT_TEST)) -ne 0 ]; then + pushd ${PWD} > /dev/null + . test-lib.sh + if [ $? -ne 0 ]; then + exit 1 + fi + test_intro $this_test + popd > /dev/null + fi + + res=$(${VIRSH} capabilities 2>&1) + + runTests "${xmldir}" "${hostoutdir}" "${flags}" + + return 0 +} + +main "$@" Index: libvirt-tck/scripts/networks/networkxml2hostout/tck-testnet-1.dat =================================================================== --- /dev/null +++ libvirt-tck/scripts/networks/networkxml2hostout/tck-testnet-1.dat @@ -0,0 +1,11 @@ +#iptables -t nat -L -n | grep 10.1.2 +MASQUERADE tcp -- 10.1.2.0/24 !10.1.2.0/24 masq ports: 1024-65535 +MASQUERADE udp -- 10.1.2.0/24 !10.1.2.0/24 masq ports: 1024-65535 +MASQUERADE all -- 10.1.2.0/24 !10.1.2.0/24 +#iptables -n -L FORWARD | grep 10.1.2 +ACCEPT all -- anywhere 10.1.2.0/24 state RELATED,ESTABLISHED +ACCEPT all -- 10.1.2.0/24 anywhere +#ps aux | grep dnsmasq | grep 10.1.2 | sed -n 's/.*\$dnsmasq[[:print:]*]\$/\\1/p' +dnsmasq --strict-order --bind-interfaces --pid-file=/var/run/libvirt/network/tck-testnet.pid --conf-file= --listen-address 10.1.2.1 --except-interface lo --dhcp-range 10.1.2.2,10.1.2.254 --dhcp-lease-max=253 --dhcp-no-override +#virsh net-list | grep tck-testnet +tck-testnet active no Index: libvirt-tck/scripts/networks/networkxml2xmlin/tck-testnet-1.xml =================================================================== --- /dev/null +++ libvirt-tck/scripts/networks/networkxml2xmlin/tck-testnet-1.xml @@ -0,0 +1,12 @@ +<network> + <name>tck-testnet</name> + <uuid>aadc8920-502a-4774-ac2b-cd382a204d06</uuid> + <forward mode='nat'/> + <bridge name='testbr' stp='on' delay='0' /> + <ip address='10.1.2.1' netmask='255.255.255.0'> + <dhcp> + <range start='10.1.2.2' end='10.1.2.254' /> + </dhcp> + </ip> +</network> + Index: libvirt-tck/scripts/networks/networkxml2hostout/tck-testnet-2.dat =================================================================== --- /dev/null +++ libvirt-tck/scripts/networks/networkxml2hostout/tck-testnet-2.dat @@ -0,0 +1,8 @@ +#iptables -L FORWARD | grep 10.1.2 +ACCEPT all -- anywhere 10.1.2.0/24 +ACCEPT all -- 10.1.2.0/24 anywhere +#iptables -t nat -L | grep 10.1.2 +#ps aux | grep dnsmasq | grep 10.1.2 | sed -n 's/.*\$dnsmasq[[:print:]*]\$/\\1/p' +dnsmasq --strict-order --bind-interfaces --pid-file=/var/run/libvirt/network/tck-testnet.pid --conf-file= --listen-address 10.1.2.1 --except-interface lo --dhcp-range 10.1.2.2,10.1.2.254 --dhcp-lease-max=253 --dhcp-no-override +#virsh net-list | grep tck-testnet +tck-testnet active no Index: libvirt-tck/scripts/networks/networkxml2xmlin/tck-testnet-2.xml =================================================================== --- /dev/null +++ libvirt-tck/scripts/networks/networkxml2xmlin/tck-testnet-2.xml @@ -0,0 +1,12 @@ +<network> + <name>tck-testnet</name> + <uuid>aadc8920-502a-4774-ac2b-cd382a204d06</uuid> + <forward mode='route'/> + <bridge name='testbr' stp='on' delay='0' /> + <ip address='10.1.2.1' netmask='255.255.255.0'> + <dhcp> + <range start='10.1.2.2' end='10.1.2.254' /> + </dhcp> + </ip> +</network> + Index: libvirt-tck/scripts/networks/100-apply-verify-host.t =================================================================== --- /dev/null +++ libvirt-tck/scripts/networks/100-apply-verify-host.t @@ -0,0 +1,10 @@ +#!/bin/bash + +pwd=$(dirname $0) + +pushd ${PWD} > /dev/null + +cd ${pwd} +bash ./networkApplyTest.sh --tap-test + +popd > /dev/null Index: libvirt-tck/scripts/networks/networkxml2hostout/tck-testnet-1.post.dat =================================================================== --- /dev/null +++ libvirt-tck/scripts/networks/networkxml2hostout/tck-testnet-1.post.dat @@ -0,0 +1,4 @@ +#iptables -t nat -L -n | grep 10.1.2 +#iptables -n -L FORWARD | grep 10.1.2 +#ps aux | grep dnsmasq | grep 10.1.2 | sed -n 's/.*\$dnsmasq[[:print:]*]\$/\\1/p' +#virsh net-list | grep tck-testnet Index: libvirt-tck/scripts/networks/networkxml2hostout/tck-testnet-2.post.dat =================================================================== --- /dev/null +++ libvirt-tck/scripts/networks/networkxml2hostout/tck-testnet-2.post.dat @@ -0,0 +1,4 @@ +#iptables -t nat -L -n | grep 10.1.2 +#iptables -n -L FORWARD | grep 10.1.2 +#ps aux | grep dnsmasq | grep 10.1.2 | sed -n 's/.*\$dnsmasq[[:print:]*]\$/\\1/p' +#virsh net-list | grep tck-testnet Index: libvirt-tck/Build.PL =================================================================== --- libvirt-tck.orig/Build.PL +++ libvirt-tck/Build.PL @@ -29,7 +29,7 @@ sub process_pkgdata_files { my $name = $File::Find::name; if (-d) { $tck_dirs{$name} = []; - } elsif (-f && (/\.t$/ || /\.sh$/ || /\.fwall$/ || /\.xml$/)) { + } elsif (-f && /\.(t|sh|fwall|xml|dat)$/) { push @{$tck_dirs{$dir}}, $name; } };

3 8

[libvirt] [PATCH 0/4] Fix handling of errors with disk labelling on NFS
by Daniel P. Berrange 01 Nov '10

01 Nov '10

The previous commit 06f81c63ebc19cb0e51f9b397991f6d6ae56d090 masked a flaw with handling of errors for NFS disk labels. If you had multiple devices that required labelling, and an disk on root squashing NFS, then when the failure occurred for the NFS file, all further devices would be skipped. The caller would then ignore the error and try to launch the guest anyway, unless there was a stdin_path on NFS. Since NFS error handling was not dealt with in the correct place, this in turn meant that disk hotplug failed with root squashing NFS. All in all a bit of a mess. This tries to clean up the code handling errors closer to the point of occurrance libvirt_private.syms | 1 + qemu/qemu_driver.c | 3 +-- qemu/qemu_monitor_text.c | 28 +++++++++++++++++++--------- security/security_selinux.c | 11 +++++++---- util/storage_file.c | 32 +++++++++++++++++++++++++------- util/storage_file.h | 9 +++++++++ 6 files changed, 62 insertions(+), 22 deletions(-) Daniel

2 8

[libvirt] [PATCH] docs: fix typo
by Eric Blake 01 Nov '10

01 Nov '10

* docs/drvqemu.html.in (qemu): Fix typo. --- Noticed this while browsing the web; pushing it as obvious. docs/drvqemu.html.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/drvqemu.html.in b/docs/drvqemu.html.in index ab54133..7230cae 100644 --- a/docs/drvqemu.html.in +++ b/docs/drvqemu.html.in @@ -70,7 +70,7 @@ qemu+ssh://root@example.com/system (remote access, SSH tunnelled) application. Thus the QEMU instances spawned from this driver will share the same privileges as the client application. The intended use case for this driver is desktop virtualization, with virtual - machines storing their disk imags in the user's home directory and + machines storing their disk images in the user's home directory and being managed from the local desktop login session. </p> -- 1.7.2.3

1 0

[libvirt] [C# bindings][PATCH] Add/Clean comments and virConnecSetErrorFunc Sample
by arnaud.champion＠devatom.fr 01 Nov '10

01 Nov '10

?Hi, here is a new patch, it add/correct some comments. It also make virDomainInfo marshaling working. It also add a new sample virConnectSetErrorFunc to show usage of virConnectSetErrorFunc, virError struct, virDomainInfo struct. Regards, Arnaud

2 4

[libvirt] [PATCH 1/2] qemu: add the USB devices to the cgroup whitelist
by Diego Elio Pettenò 01 Nov '10

01 Nov '10

Make sure that the QEmu process within the cgroup can access the device file for the USB device that has to be connected to the virtual domain. --- src/qemu/qemu_driver.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 55 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index a7cce6a..0612e69 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3434,6 +3434,25 @@ static int qemuSetupChardevCgroup(virDomainDefPtr def, } +static int qemuSetupHostUsbDeviceCgroup(usbDevice *dev ATTRIBUTE_UNUSED, + const char *path, + void *opaque) +{ + virCgroupPtr cgroup = opaque; + int rc; + + VIR_DEBUG("Process path '%s' for USB device", path); + rc = virCgroupAllowDevicePath(cgroup, path); + if (rc != 0) { + virReportSystemError(-rc, + _("Unable to allow device %s"), + path); + return -1; + } + + return 0; +} + static int qemuSetupCgroup(struct qemud_driver *driver, virDomainObjPtr vm) { @@ -3507,6 +3526,23 @@ static int qemuSetupCgroup(struct qemud_driver *driver, qemuSetupChardevCgroup, cgroup) < 0) goto cleanup; + + for (i = 0; i < vm->def->nhostdevs; i++) { + virDomainHostdevDefPtr hostdev = vm->def->hostdevs[i]; + usbDevice *usb; + + if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) + continue; + if (hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB) + continue; + + if ((usb = usbGetDevice(hostdev->source.subsys.u.usb.bus, + hostdev->source.subsys.u.usb.device)) == NULL) + goto cleanup; + + if (usbDeviceFileIterate(usb, qemuSetupHostUsbDeviceCgroup, cgroup) < 0 ) + goto cleanup; + } } if ((rc = qemuCgroupControllerActive(driver, VIR_CGROUP_CONTROLLER_MEMORY))) { @@ -8511,6 +8547,25 @@ static int qemudDomainAttachHostUsbDevice(struct qemud_driver *driver, goto error; } + if (qemuCgroupControllerActive(driver, VIR_CGROUP_CONTROLLER_DEVICES)) { + virCgroupPtr cgroup = NULL; + usbDevice *usb; + + if (virCgroupForDomain(driver->cgroup, vm->def->name, &cgroup, 0) !=0 ) { + qemuReportError(VIR_ERR_INTERNAL_ERROR, + _("Unable to find cgroup for %s\n"), + vm->def->name); + goto error; + } + + if ((usb = usbGetDevice(hostdev->source.subsys.u.usb.bus, + hostdev->source.subsys.u.usb.device)) == NULL) + goto error; + + if (usbDeviceFileIterate(usb, qemuSetupHostUsbDeviceCgroup, cgroup) < 0 ) + goto error; + } + qemuDomainObjEnterMonitorWithDriver(driver, vm); if (qemuCmdFlags & QEMUD_CMD_FLAG_DEVICE) ret = qemuMonitorAddDevice(priv->mon, devstr); -- 1.7.3.2

3 4

[libvirt] [PATCH] qemu: add the USB devices to the cgroup whitelist
by Diego Elio Pettenò 01 Nov '10

01 Nov '10

Add a new interface to hostusb.h to add an USB device abstraction to a cgroup whitelist; then use it both when attaching a new USB device and when adding it to the commandline so that the device can be accessed by the QEmu-specific cgroup. --- src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 36 ++++++++++++++++++++++++++++++++++++ src/util/hostusb.c | 6 ++++++ src/util/hostusb.h | 4 +++- 4 files changed, 46 insertions(+), 1 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index cf06256..0c6f308 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -707,6 +707,7 @@ virMutexUnlock; # usb.h +usbAllowDeviceCgroup; usbDeviceFileIterate; usbDeviceGetBus; usbDeviceGetDevno; diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 1eea3a9..acf319e 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3505,6 +3505,23 @@ static int qemuSetupCgroup(struct qemud_driver *driver, qemuSetupChardevCgroup, cgroup) < 0) goto cleanup; + + for (i = 0; i < vm->def->nhostdevs; i++) { + virDomainHostdevDefPtr hostdev = vm->def->hostdevs[i]; + usbDevice *usb; + + if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) + continue; + if (hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB) + continue; + + if ((usb = usbFindDevice(hostdev->source.subsys.u.usb.vendor, + hostdev->source.subsys.u.usb.product)) == NULL) + goto cleanup; + + if (usbAllowDeviceCgroup(usb, cgroup) < 0) + goto cleanup; + } } if ((rc = qemuCgroupControllerActive(driver, VIR_CGROUP_CONTROLLER_MEMORY))) { @@ -8454,6 +8471,25 @@ static int qemudDomainAttachHostUsbDevice(struct qemud_driver *driver, goto error; } + if (qemuCgroupControllerActive(driver, VIR_CGROUP_CONTROLLER_DEVICES)) { + virCgroupPtr cgroup = NULL; + usbDevice *usb; + + if (virCgroupForDomain(driver->cgroup, vm->def->name, &cgroup, 0) !=0 ) { + qemuReportError(VIR_ERR_INTERNAL_ERROR, + _("Unable to find cgroup for %s\n"), + vm->def->name); + goto error; + } + + if ((usb = usbFindDevice(hostdev->source.subsys.u.usb.vendor, + hostdev->source.subsys.u.usb.product)) == NULL) + goto error; + + if (usbAllowDeviceCgroup(usb, cgroup) < 0) + goto error; + } + qemuDomainObjEnterMonitorWithDriver(driver, vm); if (qemuCmdFlags & QEMUD_CMD_FLAG_DEVICE) ret = qemuMonitorAddDevice(priv->mon, devstr); diff --git a/src/util/hostusb.c b/src/util/hostusb.c index 2d6e414..2cbe1fb 100644 --- a/src/util/hostusb.c +++ b/src/util/hostusb.c @@ -225,3 +225,9 @@ int usbDeviceFileIterate(usbDevice *dev, { return (actor)(dev, dev->path, opaque); } + +int usbAllowDeviceCgroup(usbDevice *dev, + virCgroupPtr group) +{ + return virCgroupAllowDevicePath(group, dev->path); +} diff --git a/src/util/hostusb.h b/src/util/hostusb.h index f4a13ca..12269ad 100644 --- a/src/util/hostusb.h +++ b/src/util/hostusb.h @@ -23,6 +23,7 @@ # define __VIR_USB_H__ # include "internal.h" +# include "cgroup.h" typedef struct _usbDevice usbDevice; @@ -48,6 +49,7 @@ typedef int (*usbDeviceFileActor)(usbDevice *dev, int usbDeviceFileIterate(usbDevice *dev, usbDeviceFileActor actor, void *opaque); - +int usbAllowDeviceCgroup(usbDevice *dev, + virCgroupPtr group); #endif /* __VIR_USB_H__ */ -- 1.7.3.2

2 3

Re: [libvirt] SPAM-LOW: Re: Re: Node.GetInfo error
by arnaud.champion＠devatom.fr 01 Nov '10

01 Nov '10

?Ok, if you are under windows (like me), use GitExtension (http://sourceforge.net/projects/gitextensions/) It works, not perfect, but it works. Arnaud From: 黄亮 Sent: Monday, November 01, 2010 9:52 AM To: arnaud.champion(a)devatom.fr Subject: Re: Re: SPAM-LOW: Re: Re: Node.GetInfo error Hi Arnaud, The NodeInfoStructure you sent to me yesterday works, thank you. I saw your patch file, should I manually apply it to the source code or is there some tools I can use to automatically apply the changes? Regards 2010-11-01 -------------------------------------------------------------------------------- Lancer -------------------------------------------------------------------------------- 发件人： arnaud.champion(a)devatom.fr 发送时间： 2010-11-01 16:37:17 收件人：黄亮抄送： libvir-list 主题： Re: SPAM-LOW: Re: Re: Node.GetInfo error Hi, I think the solution is in the last patches I have send (which are not yet in the git). Have you tried the NodeInfoStructure I have sended yesterday ? Arnaud From: 黄亮 Sent: Monday, November 01, 2010 3:01 AM To: arnaud.champion(a)devatom.fr Cc: libvir-list Subject: SPAM-LOW: Re: Re: Node.GetInfo error HI, I tried Errors.Error err = Errors.GetLastError(); MessageBox.Show(err.Message); But IDE shows compilation errors that there is no "Error" defination in "Errors", and "Errors.GetLastError()" returns int. I made a guess that maybe it was like this: Error err = Errors.SaveLastError(); MessageBox.Show("Get Info error: " + err.Message); It can be compiled but "err.Message" has nothing in it. Did I make a wrong assumption? Regards 2010-11-01 -------------------------------------------------------------------------------- Lancer -------------------------------------------------------------------------------- 发件人： arnaud.champion(a)devatom.fr 发送时间： 2010-10-31 16:48:15 收件人：黄亮抄送： libvir-list(a)redhat.com 主题： Re: Node.GetInfo error Ok, at first GetLastError return an Error object. So you should anything like : Errors.Error err = Errors.GetLastError(); MessageBox.Show(err.Message); For the NodeInfo structure, I think the problem is the same that was for DomainInfo, I'll check marshaling. Then respond you with the correct infos. Arnaud PS : can you also put libvirt-list(a)redhat.com in copy of your mails, to keep everyone in the loop ? From: 黄亮 Sent: Sunday, October 31, 2010 8:20 AM To: arnaud.champion Subject: Node.GetInfo error Hi, Sorry for disturbing again. But I get error while using Node.GetInfo. Code: NodeInfo aNodeInfo = new NodeInfo(); if (Node.GetInfo(con, aNodeInfo) < 0) { //MessageBox.Show("Node Info Error"); MessageBox.Show(Errors.GetLastError().ToString()); return 0f; } I'm sure con != IntPtr.Zero. I tried to use Errors.GetLastError(), it returns int. But I don't know what to do with it. So, any suggestions ? Thanks Regards 2010-10-31 -------------------------------------------------------------------------------- Lancer __________ Information from ESET Smart Security, version of virus signature database 5577 (20101030) __________ The message was checked by ESET Smart Security. http://www.eset.com

1 0

Re: [libvirt] Node.GetInfo error
by arnaud.champion＠devatom.fr 01 Nov '10

01 Nov '10

?Ok, at first GetLastError return an Error object. So you should anything like : Errors.Error err = Errors.GetLastError(); MessageBox.Show(err.Message); For the NodeInfo structure, I think the problem is the same that was for DomainInfo, I'll check marshaling. Then respond you with the correct infos. Arnaud PS : can you also put libvirt-list(a)redhat.com in copy of your mails, to keep everyone in the loop ? From: 黄亮 Sent: Sunday, October 31, 2010 8:20 AM To: arnaud.champion Subject: Node.GetInfo error Hi, Sorry for disturbing again. But I get error while using Node.GetInfo. Code: NodeInfo aNodeInfo = new NodeInfo(); if (Node.GetInfo(con, aNodeInfo) < 0) { //MessageBox.Show("Node Info Error"); MessageBox.Show(Errors.GetLastError().ToString()); return 0f; } I'm sure con != IntPtr.Zero. I tried to use Errors.GetLastError(), it returns int. But I don't know what to do with it. So, any suggestions ? Thanks Regards 2010-10-31 -------------------------------------------------------------------------------- Lancer

2 4

[libvirt] ESXi 4.1 Driver
by Sherif Nagy 31 Oct '10

31 Oct '10

Dear All, Any idea what release of Libvirt has or will have the support for ESXi 4.1 driver? Thank You, Regards, Sherif

1 1

Re: [libvirt] SPAM-LOW: Domain.GetInfo error
by arnaud.champion＠devatom.fr 31 Oct '10

31 Oct '10

?Hi, In fact, when you compile libvirt with mingwin/msys, the binaries are compiled in 32 bits, even it runs on a 64 bits system. Accordingly, C# bindings must be targeted as x86 (32 bits) when compiling them. This isn't a problem for a 64 bits application which use bindings, .Net make the trick to make it works. I haven't made any test with xen (I haven't xen) but if your sample works, it means libvirt is compiled with xen support. Happy halloween to you also. Arnaud From: 黄亮 Sent: Sunday, October 31, 2010 6:52 AM To: arnaud.champion(a)devatom.fr Subject: Re: Re: SPAM-LOW: Domain.GetInfo error Hi, Thanks for your reply. It works with the patch you provide in last letter. But I don't understand "x86 target" you mentioned, does it mean if I want to make the code run, the server which runs xend & libvirtd must be a x86 arch, not a x64 arch? As to the question "are you sure also that libvirt dll is compiled with xen support ?" I just follow the instructions on http://github.com/photron/msys_setup, without the ESX support, I think it should support Xen, though it isn't write in explicit. Anyway, at least it's working. Thanks for your reply. Regards and Best wishes, and Happy Halloween XD 2010-10-31 -------------------------------------------------------------------------------- Lancer -------------------------------------------------------------------------------- 发件人： arnaud.champion(a)devatom.fr 发送时间： 2010-10-31 01:21:52 收件人：黄亮抄送： libvir-list(a)redhat.com 主题： Re: SPAM-LOW: Domain.GetInfo error Hi, So, at first, are you sure that conn != IntPtr.Zero and pDomain != IntPtr.Zero. if both pointer are ok, can you please check the DomainInfo marshal, I have just sended patch today around this structure, and I think the patch is not yet pushed to the git. The DomainInfo structure must be marshaled in this way : /// <summary> /// Structure to handle domain informations /// </summary> [StructLayout(LayoutKind.Sequential)] public class DomainInfo { /// <summary> /// The running state, one of virDomainState. /// </summary> private byte state; /// <summary> /// The maximum memory in KBytes allowed. /// </summary> [MarshalAs(UnmanagedType.SysUInt)] public UIntPtr maxMem; /// <summary> /// The memory in KBytes used by the domain. /// </summary> [MarshalAs(UnmanagedType.SysUInt)] public UIntPtr memory; /// <summary> /// The number of virtual CPUs for the domain. /// </summary> public ushort nrVirtCpu; /// <summary> /// The CPU time used in nanoseconds. /// </summary> [MarshalAs(UnmanagedType.SysUInt)] public UIntPtr cpuTime; /// <summary> /// The running state, one of virDomainState. /// </summary> public DomainState State { get { return (DomainState)state; } } } Also, another important thing change : the libvirt bindings project must have an x86 target to make this marshaling working. This is also in the patch. Another thing, you can also use Errors.GetLastErro() method to identify the problem, it return an error class which can inform you about the problem. Best regards, Arnaud PS : are you sure also that libvirt dll is compiled with xen support ? From: 黄亮 Sent: Saturday, October 30, 2010 7:07 PM To: arnaud.champion Subject: SPAM-LOW: Domain.GetInfo error Dear Arnaud Here is my test code. Function Domain.GetInfo return -1 and I don't know where is the mistake. Would you do me a favor to point out the problem? Thank you! Code: IntPtr conn = Connect.Open("xen+tcp://192.168.0.1?no_verify=1"); String DomainName = e.Node.Text; IntPtr pDomain = Domain.LookupByName(conn, DomainName); DomainInfo aInfo = new DomainInfo(); if (Domain.GetInfo(pDomain, aInfo) == -1) { MessageBox.Show("Get Info error"); return; } 2010-10-31 -------------------------------------------------------------------------------- 黄亮 __________ Information from ESET Smart Security, version of virus signature database 5576 (20101029) __________ The message was checked by ESET Smart Security. http://www.eset.com

1 0

Re: [libvirt] SPAM-LOW: Domain.GetInfo error
by arnaud.champion＠devatom.fr 30 Oct '10

30 Oct '10

?Hi, So, at first, are you sure that conn != IntPtr.Zero and pDomain != IntPtr.Zero. if both pointer are ok, can you please check the DomainInfo marshal, I have just sended patch today around this structure, and I think the patch is not yet pushed to the git. The DomainInfo structure must be marshaled in this way : /// <summary> /// Structure to handle domain informations /// </summary> [StructLayout(LayoutKind.Sequential)] public class DomainInfo { /// <summary> /// The running state, one of virDomainState. /// </summary> private byte state; /// <summary> /// The maximum memory in KBytes allowed. /// </summary> [MarshalAs(UnmanagedType.SysUInt)] public UIntPtr maxMem; /// <summary> /// The memory in KBytes used by the domain. /// </summary> [MarshalAs(UnmanagedType.SysUInt)] public UIntPtr memory; /// <summary> /// The number of virtual CPUs for the domain. /// </summary> public ushort nrVirtCpu; /// <summary> /// The CPU time used in nanoseconds. /// </summary> [MarshalAs(UnmanagedType.SysUInt)] public UIntPtr cpuTime; /// <summary> /// The running state, one of virDomainState. /// </summary> public DomainState State { get { return (DomainState)state; } } } Also, another important thing change : the libvirt bindings project must have an x86 target to make this marshaling working. This is also in the patch. Another thing, you can also use Errors.GetLastErro() method to identify the problem, it return an error class which can inform you about the problem. Best regards, Arnaud PS : are you sure also that libvirt dll is compiled with xen support ? From: 黄亮 Sent: Saturday, October 30, 2010 7:07 PM To: arnaud.champion Subject: SPAM-LOW: Domain.GetInfo error Dear Arnaud Here is my test code. Function Domain.GetInfo return -1 and I don't know where is the mistake. Would you do me a favor to point out the problem? Thank you! Code: IntPtr conn = Connect.Open("xen+tcp://192.168.0.1?no_verify=1"); String DomainName = e.Node.Text; IntPtr pDomain = Domain.LookupByName(conn, DomainName); DomainInfo aInfo = new DomainInfo(); if (Domain.GetInfo(pDomain, aInfo) == -1) { MessageBox.Show("Get Info error"); return; } 2010-10-31 -------------------------------------------------------------------------------- 黄亮

1 0

[libvirt] Hyper-V driver ?
by arnaud.champion＠devatom.fr 30 Oct '10

30 Oct '10

?Hi, I was just thinking about Hyper-V, has anyone ever tried to create a driver for Hyper-V via WinRM (http://msdn.microsoft.com/en-us/library/aa384426(VS.85).aspx) I don't know if it is possible, and I have certainly not the skills to make one, but I think it can be a possibility no ? Regards, Arnaud

4 5

[libvirt] virDomainInfo marshalling prolem
by arnaud.champion＠devatom.fr 30 Oct '10

30 Oct '10

?Hi, I am working on the marshaling of the virDomainInfo structure. I have marshalled it in this way : /// <summary> /// Structure to handle domain informations /// </summary> [StructLayout(LayoutKind.Sequential)] public class DomainInfo { /// <summary> /// The running state, one of virDomainState. /// </summary> private Byte state; /// <summary> /// The maximum memory in KBytes allowed. /// </summary> public int maxMem; /// <summary> /// The memory in KBytes used by the domain. /// </summary> public int memory; /// <summary> /// The number of virtual CPUs for the domain. /// </summary> public short nrVirtCpu; /// <summary> /// The CPU time used in nanoseconds. /// </summary> public long cpuTime; /// <summary> /// The running state, one of virDomainState. /// </summary> public DomainState State { get { return (DomainState)state; } } } It work fine in 32 bits, but not in 64 bits, it seems that packing in 64 bits is different so infos are not in order. Am I right ? Regards, Arnaud

4 10

[libvirt] [PATCH C#] Always close connections and free domains
by Matthias Bolte 30 Oct '10

30 Oct '10

Also free the unmanaged authDataPtr in the virConnectOpenAuth examples. --- examples/MonoDevelop/virConnectOpen/MainWindow.cs | 10 ++++++++++ .../MonoDevelop/virConnectOpenAuth/MainWindow.cs | 20 +++++++++++++------- examples/VisualStudio/virConnectOpen/Form1.cs | 10 ++++++++++ examples/VisualStudio/virConnectOpenAuth/Form1.cs | 16 +++++++++++----- 4 files changed, 44 insertions(+), 12 deletions(-) diff --git a/examples/MonoDevelop/virConnectOpen/MainWindow.cs b/examples/MonoDevelop/virConnectOpen/MainWindow.cs index 849f99f..0abae49 100644 --- a/examples/MonoDevelop/virConnectOpen/MainWindow.cs +++ b/examples/MonoDevelop/virConnectOpen/MainWindow.cs @@ -25,19 +25,29 @@ public partial class MainWindow : Gtk.Window protected virtual void OnButton1Clicked (object sender, System.EventArgs e) { + StoragePoolListStore.Clear (); + IntPtr conn = Connect.Open(entry1.Text); if (conn != IntPtr.Zero) { int numOfStoragePools = Connect.NumOfStoragePools(conn); if (numOfStoragePools == -1) + { ShowError("Unable to get the number of storage pools"); + goto cleanup; + } string[] storagePoolsNames = new string[numOfStoragePools]; int listStoragePools = Connect.ListStoragePools(conn, ref storagePoolsNames, numOfStoragePools); if (listStoragePools == -1) + { ShowError("Unable to list storage pools"); + goto cleanup; + } foreach (string storagePoolName in storagePoolsNames) AddStoragePoolInTreeView(storagePoolName); + cleanup: + Connect.Close(conn); } else { diff --git a/examples/MonoDevelop/virConnectOpenAuth/MainWindow.cs b/examples/MonoDevelop/virConnectOpenAuth/MainWindow.cs index 996a417..d02acd4 100644 --- a/examples/MonoDevelop/virConnectOpenAuth/MainWindow.cs +++ b/examples/MonoDevelop/virConnectOpenAuth/MainWindow.cs @@ -43,8 +43,12 @@ public partial class MainWindow : Gtk.Window Application.Quit (); a.RetVal = true; } + protected virtual void OnButton1Clicked (object sender, System.EventArgs e) { + // Remove all items + domainListStore.Clear (); + // Fill a structure to pass username and password to callbacks AuthData authData = new AuthData { password = entry3.Text, user_name = entry2.Text }; IntPtr authDataPtr = Marshal.AllocHGlobal(Marshal.SizeOf(authData)); @@ -64,7 +68,8 @@ public partial class MainWindow : Gtk.Window // Request the connection IntPtr conn = Connect.OpenAuth(entry1.Text, ref auth, 0); - + Marshal.FreeHGlobal(authDataPtr); + if (conn != IntPtr.Zero) { // Get the number of defined (not running) domains @@ -73,7 +78,7 @@ public partial class MainWindow : Gtk.Window if (Connect.ListDefinedDomains(conn, ref definedDomainNames, numOfDefinedDomains) == -1) { ShowError("Unable to list defined domains"); - return; + goto cleanup; } // Add the domain names to the listbox @@ -88,7 +93,7 @@ public partial class MainWindow : Gtk.Window if (Connect.ListDomains(conn, runningDomainIDs, numOfRunningDomain) == -1) { ShowError("Unable to list running domains"); - return; + goto cleanup; } // Add the domain names to the listbox @@ -98,16 +103,19 @@ public partial class MainWindow : Gtk.Window if (domainPtr == IntPtr.Zero) { ShowError("Unable to lookup domains by id"); - return; + goto cleanup; } string domainName = Domain.GetName(domainPtr); + Domain.Free(domainPtr); if (string.IsNullOrEmpty(domainName)) { ShowError("Unable to get domain name"); - return; + goto cleanup; } AddDomainInTreeView(domainName); } + + cleanup: Connect.Close(conn); } else @@ -156,7 +164,5 @@ public partial class MainWindow : Gtk.Window } return 0; } - - } diff --git a/examples/VisualStudio/virConnectOpen/Form1.cs b/examples/VisualStudio/virConnectOpen/Form1.cs index 870b83d..240aaaa 100644 --- a/examples/VisualStudio/virConnectOpen/Form1.cs +++ b/examples/VisualStudio/virConnectOpen/Form1.cs @@ -27,18 +27,28 @@ namespace virConnectOpen private void btnConnect_Click(object sender, EventArgs e) { + lbStoragePool.Items.Clear(); + IntPtr conn = Connect.Open(tbURI.Text); if (conn != IntPtr.Zero) { int numOfStoragePools = Connect.NumOfStoragePools(conn); if (numOfStoragePools == -1) + { ShowError("Unable to get the number of storage pools"); + goto cleanup; + } string[] storagePoolsNames = new string[numOfStoragePools]; int listStoragePools = Connect.ListStoragePools(conn, ref storagePoolsNames, numOfStoragePools); if (listStoragePools == -1) + { ShowError("Unable to list storage pools"); + goto cleanup; + } foreach (string storagePoolName in storagePoolsNames) lbStoragePool.Items.Add(storagePoolName); + cleanup: + Connect.Close(conn); } else { diff --git a/examples/VisualStudio/virConnectOpenAuth/Form1.cs b/examples/VisualStudio/virConnectOpenAuth/Form1.cs index 7901c27..87634a0 100644 --- a/examples/VisualStudio/virConnectOpenAuth/Form1.cs +++ b/examples/VisualStudio/virConnectOpenAuth/Form1.cs @@ -44,6 +44,8 @@ namespace virConnectOpenAuth private void btnConnect_Click(object sender, EventArgs e) { + lbDomains.Items.Clear(); + // Fill a structure to pass username and password to callbacks AuthData authData = new AuthData { password = tbPassword.Text, user_name = tbUsername.Text }; IntPtr authDataPtr = Marshal.AllocHGlobal(Marshal.SizeOf(authData)); @@ -62,6 +64,7 @@ namespace virConnectOpenAuth // Request the connection IntPtr conn = Connect.OpenAuth(tbURI.Text, ref auth, 0); + Marshal.FreeHGlobal(authDataPtr); if (conn != IntPtr.Zero) { @@ -70,9 +73,9 @@ namespace virConnectOpenAuth string[] definedDomainNames = new string[numOfDefinedDomains]; if (Connect.ListDefinedDomains(conn, ref definedDomainNames, numOfDefinedDomains) == -1) { - MessageBox.Show("Unable to list defined domains", "List defined domains failed", MessageBoxButtons.OK, + MessageBox.Show("Unable to list defined domains", "List defined domains failed", MessageBoxButtons.OK, MessageBoxIcon.Error); - return; + goto cleanup; } // Add the domain names to the listbox @@ -86,7 +89,7 @@ namespace virConnectOpenAuth { MessageBox.Show("Unable to list running domains", "List running domains failed", MessageBoxButtons.OK, MessageBoxIcon.Error); - return; + goto cleanup; } // Add the domain names to the listbox @@ -97,17 +100,20 @@ namespace virConnectOpenAuth { MessageBox.Show("Unable to lookup domains by id", "Lookup domain failed", MessageBoxButtons.OK, MessageBoxIcon.Error); - return; + goto cleanup; } string domainName = Domain.GetName(domainPtr); + Domain.Free(domainPtr); if (string.IsNullOrEmpty(domainName)) { MessageBox.Show("Unable to get domain name", "Get domain name failed", MessageBoxButtons.OK, MessageBoxIcon.Error); - return; + goto cleanup; } lbDomains.Items.Add(domainName); } + + cleanup: Connect.Close(conn); } else -- 1.7.0.4

4 4

[libvirt] Lxc support
by Jean-Philippe Menil 30 Oct '10

30 Oct '10

Hi, i'm trying to test the lxc support in libvirt, but but libvirt failed to start container with error "lxcContainerAvailable:897 : clone call returned Operation not permitted, container support is not enabled" Althought i've compiled libvirt with th lxc support: configure: Configuration summary configure: ===================== configure: configure: Drivers configure: configure: Xen: no configure: Proxy: no configure: QEMU: yes configure: UML: yes configure: OpenVZ: no configure: VBox: no configure: XenAPI: no configure: LXC: yes configure: PHYP: no configure: ONE: no configure: ESX: no configure: Test: yes configure: Remote: yes configure: Network: yes configure: Libvirtd: yes configure: netcf: no configure: macvtap: yes configure: virtport: no Here is my xml: <domain type='lxc'> <name>lxc1</name> <memory>500000</memory> <os> <type>exe</type> <init>/bin/sh</init> </os> <vcpu>1</vcpu> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>destroy</on_crash> <devices> <emulator>/usr/lib/libvirt/libvirt_lxc</emulator> <filesystem type='mount'> <source dir='/var/lib/lxc/lxc1/rootfs'/> <target dir='/'/> </filesystem> <interface type='bridge'> <source bridge='U13'/> <target dev='veth0'/> </interface> <console type='pty' > <target port='5'/> </console> </devices> </domain> And here are the errors: 10:41:09.968: debug : virCgroupNew:542 : New group / 10:41:09.968: debug : virCgroupDetect:232 : Detected mount/mapping 0:cpu at /var/local/cgroup in 10:41:09.968: debug : virCgroupDetect:232 : Detected mount/mapping 1:cpuacct at /var/local/cgroup in 10:41:09.968: debug : virCgroupDetect:232 : Detected mount/mapping 2:cpuset at /var/local/cgroup in 10:41:09.968: debug : virCgroupDetect:232 : Detected mount/mapping 3:memory at /var/local/cgroup in 10:41:09.968: debug : virCgroupDetect:232 : Detected mount/mapping 4:devices at /var/local/cgroup in 10:41:09.968: debug : virCgroupDetect:232 : Detected mount/mapping 5:freezer at /var/local/cgroup in 10:41:09.968: debug : virCgroupNew:542 : New group /libvirt 10:41:09.968: debug : virCgroupDetect:232 : Detected mount/mapping 0:cpu at /var/local/cgroup in 10:41:09.968: debug : virCgroupDetect:232 : Detected mount/mapping 1:cpuacct at /var/local/cgroup in 10:41:09.968: debug : virCgroupDetect:232 : Detected mount/mapping 2:cpuset at /var/local/cgroup in 10:41:09.968: debug : virCgroupDetect:232 : Detected mount/mapping 3:memory at /var/local/cgroup in 10:41:09.968: debug : virCgroupDetect:232 : Detected mount/mapping 4:devices at /var/local/cgroup in 10:41:09.968: debug : virCgroupDetect:232 : Detected mount/mapping 5:freezer at /var/local/cgroup in 10:41:09.968: debug : virCgroupMakeGroup:484 : Make group /libvirt 10:41:09.968: debug : virCgroupMakeGroup:496 : Make controller /var/local/cgroup/libvirt/ 10:41:09.968: debug : virCgroupMakeGroup:496 : Make controller /var/local/cgroup/libvirt/ 10:41:09.968: debug : virCgroupMakeGroup:496 : Make controller /var/local/cgroup/libvirt/ 10:41:09.968: debug : virCgroupMakeGroup:496 : Make controller /var/local/cgroup/libvirt/ 10:41:09.968: debug : virCgroupMakeGroup:496 : Make controller /var/local/cgroup/libvirt/ 10:41:09.968: debug : virCgroupMakeGroup:496 : Make controller /var/local/cgroup/libvirt/ 10:41:09.968: debug : virCgroupNew:542 : New group /libvirt/lxc 10:41:09.968: debug : virCgroupDetect:232 : Detected mount/mapping 0:cpu at /var/local/cgroup in 10:41:09.968: debug : virCgroupDetect:232 : Detected mount/mapping 1:cpuacct at /var/local/cgroup in 10:41:09.968: debug : virCgroupDetect:232 : Detected mount/mapping 2:cpuset at /var/local/cgroup in 10:41:09.968: debug : virCgroupDetect:232 : Detected mount/mapping 3:memory at /var/local/cgroup in 10:41:09.968: debug : virCgroupDetect:232 : Detected mount/mapping 4:devices at /var/local/cgroup in 10:41:09.968: debug : virCgroupDetect:232 : Detected mount/mapping 5:freezer at /var/local/cgroup in 10:41:09.968: debug : virCgroupMakeGroup:484 : Make group /libvirt/lxc 10:41:09.968: debug : virCgroupMakeGroup:496 : Make controller /var/local/cgroup/libvirt/lxc/ 10:41:09.968: debug : lxcControllerRun:595 : Setting up private /dev/pts 10:41:10.012: debug : lxcControllerRun:621 : Mouting 'devpts' on /var/lib/lxc/lxc1/rootfs/dev/pts 10:41:10.012: debug : lxcControllerRun:636 : Opening tty on private /var/lib/lxc/lxc1/rootfs/dev/pts/ptmx 10:41:10.044: debug : lxcContainerAvailable:897 : clone call returned Operation not permitted, container support is not enabled 10:41:10.044: debug : lxcContainerStart:848 : Enable network namespaces 10:41:10.076: debug : lxcContainerStart:854 : clone() completed, new container PID is -1 10:41:10.076: error : lxcContainerStart:858 : Failed to run clone container: Operation not permitted 10:41:10.076: debug : vethDelete:159 : veth: veth1 10:41:10.076: debug : virRunWithHook:818 : ip link del veth1 Can someone tell me what i'm doing wrong? Many thanks. Regards.

5 8

[libvirt] [PATCH] build: cleanup declaration of xen tests.
by Diego Elio Pettenò 29 Oct '10

29 Oct '10

Only build statstest and reconnect if they should be used, so add them behind the ENABLE_XEN_TESTS conditional. --- tests/Makefile.am | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 9720b6e..20b6805 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -73,11 +73,14 @@ EXTRA_DIST = \ qemuhelpdata check_PROGRAMS = virshtest conftest sockettest \ - nodeinfotest statstest qparamtest virbuftest + nodeinfotest qparamtest virbuftest if WITH_XEN check_PROGRAMS += xml2sexprtest sexpr2xmltest \ - reconnect xmconfigtest xencapstest + xmconfigtest xencapstest +if ENABLE_XEN_TESTS +check_PROGRAMS += statstest reconnect +endif endif if WITH_QEMU check_PROGRAMS += qemuxml2argvtest qemuxml2xmltest qemuargv2xmltest qemuhelptest @@ -149,7 +152,6 @@ EXTRA_DIST += $(test_scripts) TESTS = virshtest \ nodeinfotest \ - statstest \ qparamtest \ virbuftest \ sockettest \ @@ -161,7 +163,7 @@ TESTS += xml2sexprtest \ xmconfigtest \ xencapstest if ENABLE_XEN_TESTS -TESTS += reconnect +TESTS += reconnect statstest endif endif -- 1.7.3.2

2 1

[libvirt] [PATCH 1/2] support compression at virsh dump
by KAMEZAWA Hiroyuki 29 Oct '10

29 Oct '10

>From 4f74c4a69785432258ad5ea5e695d1b94aaa5b30 Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki <kamezawa.hiroyu(a)jp.fujitsu.com> Date: Thu, 28 Oct 2010 16:31:46 +0900 Subject: [PATCH 1/2] add compression support for "virsh dump" Add dump_image_format[] to qemu.conf and support compressed dump at virsh dump. coredump compression is important for saving disk space in an environment where multiple guests run. In general, "disk space for dump" is specially allocated and will be a dead space in the system. It's used only at emergency. So, it's better to have both of save_image_format and dump_image_format. "save" is done in scheduled manner with enough calculated disk space for it. This code reuses some of save_image_format[] and supports the same format. Changelog: - modified libvirtd_qemu.aug - modified test_libvirtd_qemu.aug - fixed error handling of qemudSaveCompressionTypeFromString() --- src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf | 4 +++ src/qemu/qemu_conf.c | 11 ++++++++++ src/qemu/qemu_conf.h | 1 + src/qemu/qemu_driver.c | 41 ++++++++++++++++++++++++++++++++------ src/qemu/test_libvirtd_qemu.aug | 2 + 6 files changed, 53 insertions(+), 7 deletions(-) diff --git a/src/qemu/libvirtd_qemu.aug b/src/qemu/libvirtd_qemu.aug index b9ace3e..66994fd 100644 --- a/src/qemu/libvirtd_qemu.aug +++ b/src/qemu/libvirtd_qemu.aug @@ -36,6 +36,7 @@ module Libvirtd_qemu = | str_array_entry "cgroup_controllers" | str_array_entry "cgroup_device_acl" | str_entry "save_image_format" + | str_entry "dump_image_format" | str_entry "hugetlbfs_mount" | bool_entry "relaxed_acs_check" | bool_entry "vnc_allow_host_audio" diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf index 53b76e7..e2c581e 100644 --- a/src/qemu/qemu.conf +++ b/src/qemu/qemu.conf @@ -145,7 +145,11 @@ # saving a domain in order to save disk space; the list above is in descending # order by performance and ascending order by compression ratio. # +# save_image_format is used when you use 'virsh save' at scheduled saving. +# dump_image_format is used when you use 'virsh dump' at emergency crashdump. +# # save_image_format = "raw" +# dump_image_format = "raw" # If provided by the host and a hugetlbfs mount point is configured, diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 5bd3d4c..b5c17b5 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -325,6 +325,17 @@ int qemudLoadDriverConfig(struct qemud_driver *driver, } } + p = virConfGetValue (conf, "dump_image_format"); + CHECK_TYPE ("dump_image_format", VIR_CONF_STRING); + if (p && p->str) { + VIR_FREE(driver->dumpImageFormat); + if (!(driver->dumpImageFormat = strdup(p->str))) { + virReportOOMError(); + virConfFree(conf); + return -1; + } + } + p = virConfGetValue (conf, "hugetlbfs_mount"); CHECK_TYPE ("hugetlbfs_mount", VIR_CONF_STRING); if (p && p->str) { diff --git a/src/qemu/qemu_conf.h b/src/qemu/qemu_conf.h index 530dcdb..bbe6887 100644 --- a/src/qemu/qemu_conf.h +++ b/src/qemu/qemu_conf.h @@ -164,6 +164,7 @@ struct qemud_driver { virSecurityDriverPtr securitySecondaryDriver; char *saveImageFormat; + char *dumpImageFormat; pciDeviceList *activePciHostdevs; diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index b119ca1..51ad50b 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -5907,11 +5907,22 @@ static int qemudDomainCoreDump(virDomainPtr dom, int resume = 0, paused = 0; int ret = -1, fd = -1; virDomainEventPtr event = NULL; - const char *args[] = { - "cat", - NULL, - }; + int compress; qemuDomainObjPrivatePtr priv; + /* + * We reuse "save" flag for "dump" here. Then, we can support the same + * format in "save" and "dump". + */ + compress = QEMUD_SAVE_FORMAT_RAW; + if (driver->dumpImageFormat) { + compress = qemudSaveCompressionTypeFromString(driver->dumpImageFormat); + if (compress < 0) { + qemuReportError(VIR_ERR_OPERATION_FAILED, "%s", + _("Invalid dump image format specified in " + "configuration file")); + return -1; + } + } qemuDriverLock(driver); vm = virDomainFindByUUID(&driver->domains, dom->uuid); @@ -5978,9 +5989,25 @@ static int qemudDomainCoreDump(virDomainPtr dom, } qemuDomainObjEnterMonitorWithDriver(driver, vm); - ret = qemuMonitorMigrateToFile(priv->mon, - QEMU_MONITOR_MIGRATE_BACKGROUND, - args, path, 0); + if (compress == QEMUD_SAVE_FORMAT_RAW) { + const char *args[] = { + "cat", + NULL, + }; + ret = qemuMonitorMigrateToFile(priv->mon, + QEMU_MONITOR_MIGRATE_BACKGROUND, + args, path, 0); + } else { + const char *prog = qemudSaveCompressionTypeToString(compress); + const char *args[] = { + prog, + "-c", + NULL, + }; + ret = qemuMonitorMigrateToFile(priv->mon, + QEMU_MONITOR_MIGRATE_BACKGROUND, + args, path, 0); + } qemuDomainObjExitMonitorWithDriver(driver, vm); if (ret < 0) goto endjob; diff --git a/src/qemu/test_libvirtd_qemu.aug b/src/qemu/test_libvirtd_qemu.aug index 6788346..efbf642 100644 --- a/src/qemu/test_libvirtd_qemu.aug +++ b/src/qemu/test_libvirtd_qemu.aug @@ -94,6 +94,8 @@ cgroup_device_acl = [ \"/dev/null\", \"/dev/full\", \"/dev/zero\" ] save_image_format = \"gzip\" +dump_image_format = \"gzip\" + hugetlbfs_mount = \"/dev/hugepages\" set_process_name = 1 -- 1.7.2.3

3 5

[libvirt] [PATCH] qemu_driver: add virCgroupMounted
by Lai Jiangshan 29 Oct '10

29 Oct '10

When wen mount any cgroup without "-o devices", we will fail to start vms: # virsh start vm1 error: Failed to start domain vm1 error: Unable to deny all devices for vm1: No such file or directory When wen mount any cgroup without "-o cpu", we will fail to get schedinfo: # virsh schedinfo vm1 Scheduler : posix error: unable to get cpu shares tunable: No such file or directory We should only use the cgroup controllers which are mounted on host. So I add virCgroupMounted() for qemuCgroupControllerActive() Signed-off-by: Lai Jiangshan <laijs(a)cn.fujitsu.com> --- diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 3b127d6..5885ad8 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -61,6 +61,7 @@ virConfWriteMem; # cgroup.h virCgroupForDomain; virCgroupForDriver; +virCgroupMounted; virCgroupRemove; virCgroupFree; virCgroupAddTask; diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 16f34f7..f09d029 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -724,6 +724,8 @@ static int qemuCgroupControllerActive(struct qemud_driver *driver, { if (driver->cgroup == NULL) return 0; + if (!virCgroupMounted(driver->cgroup, controller)) + return 0; if (driver->cgroupControllers & (1 << controller)) return 1; return 0; diff --git a/src/util/cgroup.c b/src/util/cgroup.c index 7e887dc..8fac389 100644 --- a/src/util/cgroup.c +++ b/src/util/cgroup.c @@ -71,6 +71,17 @@ void virCgroupFree(virCgroupPtr *group) VIR_FREE(*group); } +/** + * virCgroupMounted: query whether a cgroup subsystem is mounted or not + * + * @cgroup: The group structure to be queried + * @controller: cgroup subsystem id + */ +bool virCgroupMounted(virCgroupPtr cgroup, int controller) +{ + return !!cgroup->controllers[controller].mountPoint; +} + #if defined HAVE_MNTENT_H && defined HAVE_GETMNTENT_R /* * Process /proc/mounts figuring out what controllers are diff --git a/src/util/cgroup.h b/src/util/cgroup.h index b8f2d08..9e1c61f 100644 --- a/src/util/cgroup.h +++ b/src/util/cgroup.h @@ -83,5 +83,6 @@ int virCgroupGetFreezerState(virCgroupPtr group, char **state); int virCgroupRemove(virCgroupPtr group); void virCgroupFree(virCgroupPtr *group); +bool virCgroupMounted(virCgroupPtr cgroup, int controller); #endif /* CGROUP_H */

3 2

[libvirt] [PATCH] vbox: Don't warn when the linker search path doesn't contain VBoxXPCOMC.so
by Matthias Bolte 29 Oct '10

29 Oct '10

This is actually a workaround, to unbreak make check on systems without VirtualBox. --- src/vbox/vbox_XPCOMCGlue.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/src/vbox/vbox_XPCOMCGlue.c b/src/vbox/vbox_XPCOMCGlue.c index 7648e54..15a9622 100644 --- a/src/vbox/vbox_XPCOMCGlue.c +++ b/src/vbox/vbox_XPCOMCGlue.c @@ -124,7 +124,14 @@ static int tryLoadOne(const char *dir, bool setAppHome, bool ignoreMissing) g_hVBoxXPCOMC = dlopen(name, RTLD_NOW | RTLD_LOCAL); if (g_hVBoxXPCOMC == NULL) { - VIR_WARN("Could not dlopen '%s': %s", name, dlerror()); + /* + * FIXME: Don't warn in this case as it currently breaks make check + * on systems without VirtualBox. + */ + if (dir != NULL) { + VIR_WARN("Could not dlopen '%s': %s", name, dlerror()); + } + goto cleanup; } -- 1.7.0.4

2 1

[libvirt] [PATCH C#] Don't add a column per item in the Mono virConnectOpenAuth example
by Matthias Bolte 29 Oct '10

29 Oct '10

--- .../MonoDevelop/virConnectOpenAuth/MainWindow.cs | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/examples/MonoDevelop/virConnectOpenAuth/MainWindow.cs b/examples/MonoDevelop/virConnectOpenAuth/MainWindow.cs index d02acd4..4a3411d 100644 --- a/examples/MonoDevelop/virConnectOpenAuth/MainWindow.cs +++ b/examples/MonoDevelop/virConnectOpenAuth/MainWindow.cs @@ -36,6 +36,10 @@ public partial class MainWindow : Gtk.Window treeview1.AppendColumn(tvcDomains); treeview1.Model = domainListStore; + + CellRendererText crtDomainCell = new CellRendererText(); + tvcDomains.PackStart(crtDomainCell, true); + tvcDomains.AddAttribute(crtDomainCell, "text", 0); } protected void OnDeleteEvent (object sender, DeleteEventArgs a) @@ -137,9 +141,6 @@ public partial class MainWindow : Gtk.Window private void AddDomainInTreeView(string domainName) { domainListStore.AppendValues(domainName); - CellRendererText crtDomainCell = new CellRendererText(); - tvcDomains.PackStart(crtDomainCell, true); - tvcDomains.AddAttribute(crtDomainCell, "text", 0); } private static int AuthCallback(ref ConnectCredential[] creds, IntPtr cbdata) -- 1.7.0.4

3 4

[libvirt] [PATCH] vbox: Stop hardcoding a single path for VBoxXPCOMC.so
by Matthias Bolte 29 Oct '10

29 Oct '10

This partly reverts df90ca7661b0a789bd790ccf8258a4527c13eb8d. Don't disable the VirtualBox driver when configure can't find VBoxXPCOMC.so, rely on detection at runtime again instead. Keep --with-vbox=/path/to/virtualbox intact, added to for: https://bugzilla.redhat.com/show_bug.cgi?id=609185 Detection order for VBoxXPCOMC.so: 1. VBOX_APP_HOME environment variable 2. configure provided location 3. hardcoded list of known locations 4. dynamic linker search path Also cleanup the glue code and improve error reporting. --- Patch is based on Daniel's suggestion in: https://www.redhat.com/archives/libvir-list/2010-October/msg00852.html configure.ac | 53 +--------- po/POTFILES.in | 1 + src/vbox/vbox_XPCOMCGlue.c | 232 +++++++++++++++++++++++--------------------- src/vbox/vbox_XPCOMCGlue.h | 14 --- 4 files changed, 130 insertions(+), 170 deletions(-) diff --git a/configure.ac b/configure.ac index e41f2b5..40d6b69 100644 --- a/configure.ac +++ b/configure.ac @@ -225,8 +225,8 @@ AC_ARG_WITH([xenapi], AC_HELP_STRING([--with-xenapi], [add XenAPI support @<:@default=check@:>@]),[],[with_xenapi=check]) AC_ARG_WITH([vbox], AC_HELP_STRING([--with-vbox=@<:@PFX@:>@], - [VirtualBox XPCOMC location @<:@default=check@:>@]),[], - [with_vbox=check]) + [VirtualBox XPCOMC location @<:@default=yes@:>@]),[], + [with_vbox=yes]) AC_ARG_WITH([lxc], AC_HELP_STRING([--with-lxc], [add Linux Container support @<:@default=check@:>@]),[],[with_lxc=check]) AC_ARG_WITH([one], @@ -332,51 +332,10 @@ dnl vbox_xpcomc_dir= -if test "x$with_vbox" = "xyes" || test "x$with_vbox" = "xcheck"; then - AC_MSG_CHECKING([for VirtualBox XPCOMC location]) - - for vbox in \ - /usr/lib/virtualbox/VBoxXPCOMC.so \ - /usr/lib64/virtualbox/VBoxXPCOMC.so \ - /usr/lib/VirtualBox/VBoxXPCOMC.so \ - /opt/virtualbox/VBoxXPCOMC.so \ - /opt/VirtualBox/VBoxXPCOMC.so \ - /opt/virtualbox/i386/VBoxXPCOMC.so \ - /opt/VirtualBox/i386/VBoxXPCOMC.so \ - /opt/virtualbox/amd64/VBoxXPCOMC.so \ - /opt/VirtualBox/amd64/VBoxXPCOMC.so \ - /usr/local/lib/virtualbox/VBoxXPCOMC.so \ - /usr/local/lib/VirtualBox/VBoxXPCOMC.so \ - /Applications/VirtualBox.app/Contents/MacOS/VBoxXPCOMC.dylib \ - ; do - if test -f "$vbox"; then - vbox_xpcomc_dir=`AS_DIRNAME(["$vbox"])` - break - fi - done - - if test -n "$vbox_xpcomc_dir"; then - AC_MSG_RESULT([$vbox_xpcomc_dir]) - with_vbox=yes - else - if test "x$with_vbox" = "xcheck"; then - AC_MSG_RESULT([not found, disabling VirtualBox driver]) - with_vbox=no - else - AC_MSG_RESULT([not found]) - AC_MSG_ERROR([VirtualBox XPCOMC is required for the VirtualBox driver]) - fi - fi -else - if test "x$with_vbox" != "xno"; then - if test -f ${with_vbox}/VBoxXPCOMC.so || \ - test -f ${with_vbox}/VBoxXPCOMC.dylib; then - vbox_xpcomc_dir=$with_vbox - with_vbox=yes - else - AC_MSG_ERROR([$with_vbox does not contain VirtualBox XPCOMC]) - fi - fi +if test "x$with_vbox" != "xyes" && test "x$with_vbox" != "xno"; then + # intentionally don't do any further checks here on the provided path + vbox_xpcomc_dir=$with_vbox + with_vbox=yes fi AC_DEFINE_UNQUOTED([VBOX_XPCOMC_DIR], ["$vbox_xpcomc_dir"], diff --git a/po/POTFILES.in b/po/POTFILES.in index 541335e..dafef47 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -93,6 +93,7 @@ src/util/util.c src/util/virtaudit.c src/util/virterror.c src/util/xml.c +src/vbox/vbox_XPCOMCGlue.c src/vbox/vbox_driver.c src/vbox/vbox_tmpl.c src/xen/proxy_internal.c diff --git a/src/vbox/vbox_XPCOMCGlue.c b/src/vbox/vbox_XPCOMCGlue.c index e8b0bd1..7648e54 100644 --- a/src/vbox/vbox_XPCOMCGlue.c +++ b/src/vbox/vbox_XPCOMCGlue.c @@ -32,13 +32,18 @@ #include <config.h> -#include <stdio.h> -#include <string.h> #include <stdlib.h> -#include <stdarg.h> #include <dlfcn.h> +#include <stdbool.h> #include "vbox_XPCOMCGlue.h" +#include "internal.h" +#include "memory.h" +#include "util.h" +#include "logging.h" +#include "virterror_internal.h" + +#define VIR_FROM_THIS VIR_FROM_VBOX /******************************************************************************* @@ -60,8 +65,6 @@ *******************************************************************************/ /** The dlopen handle for VBoxXPCOMC. */ void *g_hVBoxXPCOMC = NULL; -/** The last load error. */ -char g_szVBoxErrMsg[256]; /** Pointer to the VBoxXPCOMC function table. */ PCVBOXXPCOM g_pVBoxFuncs = NULL; /** Pointer to VBoxGetXPCOMCFunctions for the loaded VBoxXPCOMC so/dylib/dll. */ @@ -69,104 +72,97 @@ PFNVBOXGETXPCOMCFUNCTIONS g_pfnGetFunctions = NULL; /** - * Wrapper for setting g_szVBoxErrMsg. Can be an empty stub. - * - * @param fAlways When 0 the g_szVBoxErrMsg is only set if empty. - * @param pszFormat The format string. - * @param ... The arguments. - */ -static void setErrMsg(int fAlways, const char *pszFormat, ...) -{ -#ifndef LIBVIRT_VERSION - if ( fAlways - || !g_szVBoxErrMsg[0]) - { - va_list va; - va_start(va, pszFormat); - vsnprintf(g_szVBoxErrMsg, sizeof(g_szVBoxErrMsg), pszFormat, va); - va_end(va); - } -#else /* libvirt */ - (void)fAlways; - (void)pszFormat; -#endif /* libvirt */ -} - - -/** * Try load VBoxXPCOMC.so/dylib/dll from the specified location and resolve all * the symbols we need. * - * @returns 0 on success, -1 on failure. - * @param pszHome The director where to try load VBoxXPCOMC from. Can - * be NULL. - * @param fSetAppHome Whether to set the VBOX_APP_HOME env.var. or not - * (boolean). + * @returns 0 on success, -1 on failure and 1 if VBoxXPCOMC was not found. + * @param dir The directory where to try load VBoxXPCOMC from. Can + * be NULL. + * @param setAppHome Whether to set the VBOX_APP_HOME env.var. or not. + * @param ignoreMissing Whether to ignore missing library or not. */ -static int tryLoadOne(const char *pszHome, int fSetAppHome) +static int tryLoadOne(const char *dir, bool setAppHome, bool ignoreMissing) { - size_t cchHome = pszHome ? strlen(pszHome) : 0; - size_t cbBufNeeded; - char szName[4096]; - int rc = -1; + int result = -1; + char *name = NULL; + PFNVBOXGETXPCOMCFUNCTIONS pfnGetFunctions; + + if (dir != NULL) { + if (virAsprintf(&name, "%s/%s", dir, DYNLIB_NAME) < 0) { + virReportOOMError(); + return -1; + } - /* - * Construct the full name. - */ - cbBufNeeded = cchHome + sizeof("/" DYNLIB_NAME); - if (cbBufNeeded > sizeof(szName)) - { - setErrMsg(1, "path buffer too small: %u bytes needed", - (unsigned)cbBufNeeded); - return -1; - } - if (cchHome) - { - memcpy(szName, pszHome, cchHome); - szName[cchHome] = '/'; - cchHome++; + if (!virFileExists(name)) { + if (!ignoreMissing) { + VIR_ERROR(_("Libaray '%s' doesn't exist"), name); + } + + return -1; + } + } else { + name = strdup(DYNLIB_NAME); + + if (name == NULL) { + virReportOOMError(); + return -1; + } } - memcpy(&szName[cchHome], DYNLIB_NAME, sizeof(DYNLIB_NAME)); /* * Try load it by that name, setting the VBOX_APP_HOME first (for now). * Then resolve and call the function table getter. */ - if (fSetAppHome) - { - if (pszHome) - setenv("VBOX_APP_HOME", pszHome, 1 /* always override */); - else + if (setAppHome) { + if (dir != NULL) { + setenv("VBOX_APP_HOME", dir, 1 /* always override */); + } else { unsetenv("VBOX_APP_HOME"); + } } - g_hVBoxXPCOMC = dlopen(szName, RTLD_NOW | RTLD_LOCAL); - if (g_hVBoxXPCOMC) - { - PFNVBOXGETXPCOMCFUNCTIONS pfnGetFunctions; - pfnGetFunctions = (PFNVBOXGETXPCOMCFUNCTIONS) - dlsym(g_hVBoxXPCOMC, VBOX_GET_XPCOMC_FUNCTIONS_SYMBOL_NAME); - if (pfnGetFunctions) - { - g_pVBoxFuncs = pfnGetFunctions(VBOX_XPCOMC_VERSION); - if (g_pVBoxFuncs) - { - g_pfnGetFunctions = pfnGetFunctions; - return 0; - } - /* bail out */ - setErrMsg(1, "%.80s: pfnGetFunctions(%#x) failed", - szName, VBOX_XPCOMC_VERSION); - } - else - setErrMsg(1, "dlsym(%.80s/%.32s): %.128s", - szName, VBOX_GET_XPCOMC_FUNCTIONS_SYMBOL_NAME, dlerror()); + g_hVBoxXPCOMC = dlopen(name, RTLD_NOW | RTLD_LOCAL); + + if (g_hVBoxXPCOMC == NULL) { + VIR_WARN("Could not dlopen '%s': %s", name, dlerror()); + goto cleanup; + } + + pfnGetFunctions = (PFNVBOXGETXPCOMCFUNCTIONS) + dlsym(g_hVBoxXPCOMC, VBOX_GET_XPCOMC_FUNCTIONS_SYMBOL_NAME); + + if (pfnGetFunctions == NULL) { + VIR_ERROR(_("Could not dlsym %s from '%s': %s"), + VBOX_GET_XPCOMC_FUNCTIONS_SYMBOL_NAME, name, dlerror()); + goto cleanup; + } + + g_pVBoxFuncs = pfnGetFunctions(VBOX_XPCOMC_VERSION); + + if (g_pVBoxFuncs == NULL) { + VIR_ERROR(_("Calling %s from '%s' failed"), + VBOX_GET_XPCOMC_FUNCTIONS_SYMBOL_NAME, name); + goto cleanup; + } + + g_pfnGetFunctions = pfnGetFunctions; + result = 0; + + if (dir != NULL) { + VIR_DEBUG("Found %s in '%s'", DYNLIB_NAME, dir); + } else { + VIR_DEBUG("Found %s in dynamic linker search path", DYNLIB_NAME); + } + +cleanup: + if (g_hVBoxXPCOMC != NULL && result < 0) { dlclose(g_hVBoxXPCOMC); g_hVBoxXPCOMC = NULL; } - else - setErrMsg(0, "dlopen(%.80s): %.160s", szName, dlerror()); - return rc; + + VIR_FREE(name); + + return result; } @@ -175,34 +171,53 @@ static int tryLoadOne(const char *pszHome, int fSetAppHome) * function pointers. * * @returns 0 on success, -1 on failure. - * - * @remark This should be considered moved into a separate glue library since - * its its going to be pretty much the same for any user of VBoxXPCOMC - * and it will just cause trouble to have duplicate versions of this - * source code all around the place. */ int VBoxCGlueInit(void) { - /* - * If the user specifies the location, try only that. - */ - const char *pszHome = getenv("VBOX_APP_HOME"); - if (pszHome) - return tryLoadOne(pszHome, 0); + int i; + static const char *knownDirs[] = { + "/usr/lib/virtualbox", + "/usr/lib/virtualbox-ose", + "/usr/lib64/virtualbox", + "/usr/lib64/virtualbox-ose", + "/usr/lib/VirtualBox", + "/opt/virtualbox", + "/opt/VirtualBox", + "/opt/virtualbox/i386", + "/opt/VirtualBox/i386", + "/opt/virtualbox/amd64", + "/opt/VirtualBox/amd64", + "/usr/local/lib/virtualbox", + "/usr/local/lib/VirtualBox", + "/Applications/VirtualBox.app/Contents/MacOS" + }; + const char *home = getenv("VBOX_APP_HOME"); + + /* If the user specifies the location, try only that. */ + if (home != NULL) { + if (tryLoadOne(home, false, false) < 0) { + return -1; + } + } - /* - * Try the configured location. - */ - g_szVBoxErrMsg[0] = '\0'; + /* Try the additionally configured location. */ + if (VBOX_XPCOMC_DIR[0] != '\0') { + if (tryLoadOne(VBOX_XPCOMC_DIR, true, true) >= 0) { + return 0; + } + } - if (tryLoadOne(VBOX_XPCOMC_DIR, 1) == 0) - return 0; + /* Try the known locations. */ + for (i = 0; i < ARRAY_CARDINALITY(knownDirs); ++i) { + if (tryLoadOne(knownDirs[i], true, true) >= 0) { + return 0; + } + } - /* - * Finally try the dynamic linker search path. - */ - if (tryLoadOne(NULL, 1) == 0) + /* Finally try the dynamic linker search path. */ + if (tryLoadOne(NULL, false, true) >= 0) { return 0; + } /* No luck, return failure. */ return -1; @@ -214,14 +229,13 @@ int VBoxCGlueInit(void) */ void VBoxCGlueTerm(void) { - if (g_hVBoxXPCOMC) - { + if (g_hVBoxXPCOMC != NULL) { #if 0 /* VBoxRT.so doesn't like being reloaded. See @bugref{3725}. */ dlclose(g_hVBoxXPCOMC); #endif g_hVBoxXPCOMC = NULL; } + g_pVBoxFuncs = NULL; g_pfnGetFunctions = NULL; - memset(g_szVBoxErrMsg, 0, sizeof(g_szVBoxErrMsg)); } diff --git a/src/vbox/vbox_XPCOMCGlue.h b/src/vbox/vbox_XPCOMCGlue.h index c04eefa..6c44030 100644 --- a/src/vbox/vbox_XPCOMCGlue.h +++ b/src/vbox/vbox_XPCOMCGlue.h @@ -32,26 +32,12 @@ /* This has to be the oldest version we support. */ # include "vbox_CAPI_v2_2.h" -# ifdef __cplusplus -extern "C" { -# endif - -/** The dlopen handle for VBoxXPCOMC. */ -extern void *g_hVBoxXPCOMC; -/** The last load error. */ -extern char g_szVBoxErrMsg[256]; /** Pointer to the VBoxXPCOMC function table. */ extern PCVBOXXPCOM g_pVBoxFuncs; /** Pointer to VBoxGetXPCOMCFunctions for the loaded VBoxXPCOMC so/dylib/dll. */ extern PFNVBOXGETXPCOMCFUNCTIONS g_pfnGetFunctions; - int VBoxCGlueInit(void); void VBoxCGlueTerm(void); - -# ifdef __cplusplus -} -# endif - #endif -- 1.7.0.4

3 3

[libvirt] [PATCH] Fix typo
by Hu Tao 29 Oct '10

29 Oct '10

--- include/libvirt/libvirt.h.in | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index b45f7ec..3379210 100644 --- a/include/libvirt/libvirt.h.in +++ b/include/libvirt/libvirt.h.in @@ -2044,7 +2044,7 @@ typedef enum { /** - * virConnectDomainEventWatchdogCallback: + * virConnectDomainEventIOErrorCallback: * @conn: connection object * @dom: domain on which the event occurred * @srcPath: The host file on which the IO error occurred @@ -2064,7 +2064,7 @@ typedef void (*virConnectDomainEventIOErrorCallback)(virConnectPtr conn, void *opaque); /** - * virConnectDomainEventWatchdogCallback: + * virConnectDomainEventIOErrorReasonCallback: * @conn: connection object * @dom: domain on which the event occurred * @srcPath: The host file on which the IO error occurred -- 1.7.3

3 2

[libvirt] Fwd: Re: Lxc support
by Jean-Philippe Menil 29 Oct '10

29 Oct '10

-------- Message original -------- Sujet: Re: [libvirt] Lxc support Date : Fri, 29 Oct 2010 13:13:16 +0200 De : Jean-Philippe Menil <jean-philippe.menil(a)univ-nantes.fr> Répondre à : jean-philippe.menil(a)univ-nantes.fr Organisation : IRTS - DSI - Université de Nantes Pour : Daniel P. Berrange <berrange(a)redhat.com> Le 29/10/2010 12:39, Daniel P. Berrange a écrit : > On Fri, Oct 29, 2010 at 12:27:59PM +0200, Jean-Philippe Menil wrote: >> Le 29/10/2010 12:00, Osier a écrit : >>> On 10/29/2010 04:42 PM, Jean-Philippe Menil wrote: >>>> Hi, >>>> >>>> i'm trying to test the lxc support in libvirt, but but libvirt failed to >>>> start container with error "lxcContainerAvailable:897 : clone call >>>> returned Operation not permitted, container support is not enabled" >>>> >>> >>> What's the kernel version you use? Just as the error message says, the >>> system call 'clone' failed, It's probly caused by lacking of kernel >>> support. >>> >>> At least you should make sure 'clone' support these flags: >>> >>> CLONE_NEWPID, CLONE_NEWNS, CLONE_NEWUTS, CLONE_NEWIPC, SIGCHLD > >> thanks for your response. >> The kernel is a 2.6.36 wit hthe following: >> root@redbreast:/tmp# cat /boot/config-2.6.36-dsiun-1a | grep -i pid >> CONFIG_PROC_PID_CPUSET=y >> CONFIG_PID_NS=y >> # CONFIG_SPI_SPIDEV is not set >> CONFIG_HID_PID=y > > You need to check for _NS= here, and want to see the following > > $ grep _NS= /boot/config-2.6.34.6-54.fc13.x86_64 > CONFIG_CGROUP_NS=y > CONFIG_UTS_NS=y > CONFIG_IPC_NS=y > CONFIG_USER_NS=y > CONFIG_PID_NS=y > CONFIG_NET_NS=y > > Daniel Sorry, forgot to cc the list Ok, So my kernel lokks fine: root@redbreast:/tmp# cat /boot/config-2.6.36-dsiun-1a | grep _NS CONFIG_CGROUP_NS=y CONFIG_UTS_NS=y CONFIG_IPC_NS=y CONFIG_USER_NS=y CONFIG_PID_NS=y CONFIG_NET_NS=y Libvirt was compiled with following: --with-qemu --with-qemu-user=libvirt-qemu --with-qemu-group=kvm --without-xen --without-openvz --without-avahi --without-sasl --without-polkit --without-udev --without-hal --with-storage-fs --with-storage-lvm --without-storage-iscsi --with-storage-disk --with-init-scripts=none --without-numactl --without-selinux --without-esx --without-libssh2 --without-capng --with-macvtap --enable-debug --with-lxc

1 0

[libvirt] [PATCH] qemu: Fix one memory leak in qemu driver.c
by Osier Yang 29 Oct '10

29 Oct '10

* src/qemu/qemu_driver.c (qemuDomainManagedSavePath) --- src/qemu/qemu_driver.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 89b4d11..976fb72 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -5843,6 +5843,7 @@ qemuDomainManagedSavePath(struct qemud_driver *driver, virDomainObjPtr vm) { char *ret; if (virAsprintf(&ret, "%s/%s.save", driver->saveDir, vm->def->name) < 0) { + VIR_FREE(ret); virReportOOMError(); return(NULL); } -- 1.7.2.3

2 1

[libvirt] Fixing the output of "virsh help"
by Justin Clift 29 Oct '10

29 Oct '10

Hi all, The output of virsh --help has become pretty unwieldy for people, so I'd like to adjust it to display things in a fashion that's easier to locate things in. Below is my first mock up of what the new output should look like, with it broken into functional categories. Does this seem like the best approach? Open to completely different ideas, different layout approaches, etc. :) Notes: + In a final (working) solution, each of the commands would be alphabetically sorted in its category. Only roughly manually sorted them below, to show the general effect. + Some of the lines below looked like they might wrap in email, so I manually cut them off with "...". Not thinking of doing that in a coded up version. We'd just let them wrap. ;) + Pretty sure we'd need to adjust the test suite components that leverage from virsh --help, but I don't think it can be avoided. ********************************************************************** virsh # help Commands: CPU Management ************** cpu-baseline compute baseline CPU cpu-compare compare host CPU with a CPU described by an ... maxvcpus connection vcpu maximum setvcpus change number of virtual CPUs vcpucount domain vcpu counts vcpuinfo detailed domain vcpu information vcpupin control domain vcpu affinity Device Management ***************** attach-device attach device from an XML file attach-disk attach disk device detach-device detach device from an XML file detach-disk detach disk device update-device update device from an XML file Domain Management ***************** autostart autostart a domain create create a domain from an XML file destroy destroy a domain define define (but don't start) a domain from an XML... domid convert a domain name or UUID to domain id domuuid convert a domain name or id to domain UUID dominfo domain information domjobinfo domain job information domjobabort abort active domain job domname convert a domain id or UUID to domain name domstate domain state domblkstat get device block stats for a domain domifstat get network interface stats for a domain dommemstat get memory statistics for a domain domblkinfo domain block device size information domxml-from-native Convert native config to domain XML domxml-to-native Convert domain XML to native config dump dump the core of a domain to a file for anal... dumpxml domain information in XML edit edit XML configuration for a domain list list domains managedsave managed save of a domain state managedsave-remove Remove managed save of a domain memtune Get/Set memory paramters migrate migrate domain to another host migrate-setmaxdowntime set maximum tolerable downtime reboot reboot a domain restore restore a domain from a saved state in a file resume resume a domain save save a domain state to a file setmem change memory allocation setmaxmem change maximum memory limit shutdown gracefully shutdown a domain start start a (previously defined) inactive domain suspend suspend a domain undefine undefine an inactive domain Management of Secrets ********************* secret-define define or modify a secret from an XML file secret-dumpxml secret attributes in XML secret-set-value set a secret value secret-get-value Output a secret value secret-undefine undefine a secret secret-list list secrets Networking ********** net-autostart autostart a network net-create create a network from an XML file net-define define (but don't start) a network from... net-destroy destroy a network net-dumpxml network information in XML net-edit edit XML configuration for a network net-list list networks net-name convert a network UUID to network name net-start start a (previously defined) inactive network net-undefine undefine an inactive network net-uuid convert a network name to network UUID Network Interfaces ****************** attach-interface attach network interface detach-interface detach network interface iface-list list physical host interfaces iface-name convert an interface MAC address to inte... iface-mac convert an interface name to interface M... iface-dumpxml interface information in XML iface-define define (but don't start) a physical host... iface-undefine undefine a physical host interface (remo... iface-edit edit XML configuration for a physical ho... iface-start start a physical host interface (enable ... iface-destroy destroy a physical host interface (disab... Nodes ***** nodeinfo node information nodedev-list enumerate devices on this host nodedev-dumpxml node device details in XML nodedev-dettach dettach node device from its device driver nodedev-reattach reattach node device to its device driver nodedev-reset reset node device nodedev-create create a device defined by an XML file o... nodedev-destroy destroy a device on the node NWfilter ******** nwfilter-define define or update a network filter from a... nwfilter-undefine undefine a network filter nwfilter-dumpxml network filter information in XML nwfilter-list list network filters nwfilter-edit edit XML configuration for a network filter Snapshots ********* snapshot-create Create a snapshot snapshot-current Get the current snapshot snapshot-delete Delete a domain snapshot snapshot-dumpxml Dump XML for a domain snapshot snapshot-list List snapshots for a domain snapshot-revert Revert a domain to a snapshot Storage Pools ************* find-storage-pool-sources discover potential storage poo... find-storage-pool-sources-as find potential storage pool... pool-autostart autostart a pool pool-build build a pool pool-create create a pool from an XML file pool-create-as create a pool from a set of args pool-define define (but don't start) a pool from an ... pool-define-as define a pool from a set of args pool-destroy destroy a pool pool-delete delete a pool pool-dumpxml pool information in XML pool-edit edit XML configuration for a storage pool pool-info storage pool information pool-list list pools pool-name convert a pool UUID to pool name pool-refresh refresh a pool pool-start start a (previously defined) inactive pool pool-undefine undefine an inactive pool pool-uuid convert a pool name to pool UUID Storage Volumes *************** vol-create create a vol from an XML file vol-create-from create a vol, using another volume as input vol-create-as create a volume from a set of args vol-clone clone a volume. vol-delete delete a vol vol-wipe wipe a vol vol-dumpxml vol information in XML vol-info storage vol information vol-list list vols vol-pool returns the storage pool for a given ... vol-path returns the volume path for a given ... vol-name returns the volume name for a given ... vol-key returns the volume key for a given ... Virsh itself ************** cd change the current directory connect (re)connect to hypervisor console connect to the guest console echo echo arguments exit quit this interactive terminal help print help pwd print the current directory quit quit this interactive terminal uri print the hypervisor canonical URI version show version vncdisplay vnc display Not sure (need suggestions) :> ****************************** capabilities capabilities freecell NUMA free memory hostname print the hypervisor hostname schedinfo show/set scheduler parameters ttyconsole tty console virsh # **********************************************************************

3 4

[libvirt] "qemudDispatchSignalEvent" warning... but QEMU support not compiled in
by Justin Clift 29 Oct '10

29 Oct '10

Hi all, Just noticed this warning message when shutting down foreground libvirtd on OSX (via ^C): 17:24:04.247: warning : qemudDispatchSignalEvent:402 : Shutting down on signal 2 Didn't think anything of it, till realising that libvirtd was compiled without QEMU support. It doesn't seem to be hurting anything, but mentioning it in case someone knows what it's about and whether we should care. :) Regards and best wishes, Justin Clift

2 2

[libvirt] C# bindings raising an error
by arnaud.champion＠devatom.fr 29 Oct '10

29 Oct '10

?Hi, I start to work on a new sample code for C# bindings. The goal is to show how to use errors callbacks... Do you a way to raise an error for sample ? (I know it's an antagonist request ) Regards, Arnaud

3 6

Re: [libvirt] SPAM-LOW: Re: Re: System.DllNotFoundException
by arnaud.champion＠devatom.fr 29 Oct '10

29 Oct '10

?You're welcome, glad to help you. Arnaud From: 黄亮 Sent: Friday, October 29, 2010 10:07 AM To: arnaud.champion(a)devatom.fr Subject: SPAM-LOW: Re: Re: System.DllNotFoundException Hi, depends.exe really helps! it turns out that there are 7 dlls I'm missing. Thanks to the dll-files.com, I can download all of them. And put all of them in the same dir with my test exe, it works. Thank you arnaud, you really help a lot. Best wishes 2010-10-29 -------------------------------------------------------------------------------- Lancer -------------------------------------------------------------------------------- 发件人： arnaud.champion(a)devatom.fr 发送时间： 2010-10-29 15:38:47 收件人：黄亮抄送： libvir-list(a)redhat.com 主题： Re: System.DllNotFoundException Hi, what do you mean when you say "I use the .cs file you release to create a dll project" ? C# bindings are provided with a visual studio 2010 solution, I think it's better to use it if you can. If you can't (because you have vs2005 or vs2008), please re-create a solution with all C# bindings codes. Be sure you have the dll in your Debug directory : libcurl-4.dll libgcrypt-11.dll libgnutls-26.dll libgpg-error-0.dll libportablexdr-0.dll libtasn1-3.dll libvirt-0.dll libxml2-2.dll Also, be carefull about one thing : these dll must be in the directory of the executable. I mean if you create a project "testBinding" which produce "testBindings.exe", then these dlls must be in the same directory of "testBindings.exe". You can also use "depends.exe" (http://www.dependencywalker.com/) which is a tool used to check dll dependency. You open your libvirt-0.dll with it and see if there is no missing dll (maybe a dll miss you, and I don't see it because my system ever own it, I don't know). Arnaud From: 黄亮 Sent: Friday, October 29, 2010 3:51 AM To: arnaud.champion(a)devatom.fr Subject: System.DllNotFoundException Hello Arnaud I've compiled libvirt using photron scripts and got the libvirt-0.dll I use the .cs file you released to create a dll project, and get CSharpDll.dll Then I create a new project to invoke CSharpDll.dll, I got a System.DllNotFoundException while "Libvirt.Connect.Open" is trying to work. The exception shows libvirt-0.dll cannot be found. I tried to put libvirt-0.dll everywhere. In the same dir with .sln, with .cs file, in Debug dir, even in Windows/System32 dir. But I got no luck. It's still stuck. So I need your help to get me out of the mess. Would you please tell me where I may go wrong? Many Thanks 2010-10-29 -------------------------------------------------------------------------------- Lancer __________ Information from ESET Smart Security, version of virus signature database 5573 (20101028) __________ The message was checked by ESET Smart Security. http://www.eset.com

1 0

Re: [libvirt] System.DllNotFoundException
by arnaud.champion＠devatom.fr 29 Oct '10

29 Oct '10

?Hi, what do you mean when you say "I use the .cs file you release to create a dll project" ? C# bindings are provided with a visual studio 2010 solution, I think it's better to use it if you can. If you can't (because you have vs2005 or vs2008), please re-create a solution with all C# bindings codes. Be sure you have the dll in your Debug directory : libcurl-4.dll libgcrypt-11.dll libgnutls-26.dll libgpg-error-0.dll libportablexdr-0.dll libtasn1-3.dll libvirt-0.dll libxml2-2.dll Also, be carefull about one thing : these dll must be in the directory of the executable. I mean if you create a project "testBinding" which produce "testBindings.exe", then these dlls must be in the same directory of "testBindings.exe". You can also use "depends.exe" (http://www.dependencywalker.com/) which is a tool used to check dll dependency. You open your libvirt-0.dll with it and see if there is no missing dll (maybe a dll miss you, and I don't see it because my system ever own it, I don't know). Arnaud From: 黄亮 Sent: Friday, October 29, 2010 3:51 AM To: arnaud.champion(a)devatom.fr Subject: System.DllNotFoundException Hello Arnaud I've compiled libvirt using photron scripts and got the libvirt-0.dll I use the .cs file you released to create a dll project, and get CSharpDll.dll Then I create a new project to invoke CSharpDll.dll, I got a System.DllNotFoundException while "Libvirt.Connect.Open" is trying to work. The exception shows libvirt-0.dll cannot be found. I tried to put libvirt-0.dll everywhere. In the same dir with .sln, with .cs file, in Debug dir, even in Windows/System32 dir. But I got no luck. It's still stuck. So I need your help to get me out of the mess. Would you please tell me where I may go wrong? Many Thanks 2010-10-29 -------------------------------------------------------------------------------- Lancer

1 0

[libvirt] [PATCH C#] Fix two memory leaks in the ConnectCredential.Result setter
by Matthias Bolte 29 Oct '10

29 Oct '10

StringToHGlobalAnsi returns a pointer to unmanaged memory that must be freed using FreeHGlobal. When the setter is called twice the strdup'ed unmanaged string from the first call leaks. Free it before assigning it again. --- NativeFunctions.cs | 6 +++++- Types.cs | 13 +++++++++++-- projects/MonoDevelop/LibvirtBindings.dll.config | 2 ++ 3 files changed, 18 insertions(+), 3 deletions(-) diff --git a/NativeFunctions.cs b/NativeFunctions.cs index 25d7532..71136b8 100644 --- a/NativeFunctions.cs +++ b/NativeFunctions.cs @@ -16,8 +16,12 @@ namespace Libvirt { public class NativeFunctions { - // TODO : this is atemporary workaround for virConnectOpenAuth callback, this should be removed + // TODO : this is a temporary workaround for virConnectOpenAuth callback, this should be removed [DllImport("msvcrt.dll", EntryPoint = "_strdup", CallingConvention = CallingConvention.Cdecl)] public static extern IntPtr StrDup(IntPtr strSource); + + // TODO : this is a temporary workaround for virConnectOpenAuth callback, this should be removed + [DllImport("msvcrt.dll", EntryPoint = "free", CallingConvention = CallingConvention.Cdecl)] + public static extern void Free(IntPtr ptr); } } diff --git a/Types.cs b/Types.cs index 0d471fb..37a1f47 100644 --- a/Types.cs +++ b/Types.cs @@ -1,4 +1,4 @@ -/* +/* * Copyright (C) * Arnaud Champion <arnaud.champion(a)devatom.fr> * Jaromír Červenka <cervajz(a)cervajz.com> @@ -406,6 +406,10 @@ namespace Libvirt [StructLayout(LayoutKind.Sequential)] public class ConnectCredential { + public ConnectCredential () + { + result = IntPtr.Zero; + } ///<summary> /// One of virConnectCredentialType constants ///</summary> @@ -473,8 +477,13 @@ namespace Libvirt } set { - result = NativeFunctions.StrDup(Marshal.StringToHGlobalAnsi(value)); + IntPtr tmp = Marshal.StringToHGlobalAnsi(value); + + NativeFunctions.Free(result); + result = NativeFunctions.StrDup(tmp); resultlen = (uint)value.Length; + + Marshal.FreeHGlobal(tmp); } } } diff --git a/projects/MonoDevelop/LibvirtBindings.dll.config b/projects/MonoDevelop/LibvirtBindings.dll.config index d0ded4c..2dfa2e4 100644 --- a/projects/MonoDevelop/LibvirtBindings.dll.config +++ b/projects/MonoDevelop/LibvirtBindings.dll.config @@ -6,6 +6,8 @@ </dllmap> <dllmap dll="msvcrt.dll"> <dllentry os="windows" dll="msvcrt.dll" name="_strdup" target="_strdup" /> + <dllentry os="windows" dll="msvcrt.dll" name="free" target="free" /> <dllentry os="linux" dll="libc.so.6" name="_strdup" target="strdup" /> + <dllentry os="linux" dll="libc.so.6" name="free" target="free" /> </dllmap> </configuration> -- 1.7.0.4

3 3

[libvirt] [PATCH] show compiled in options in virsh --version
by Daniel Veillard 29 Oct '10

29 Oct '10

To ease debugging this trivial patch allows to find what was compiled in in the local version of libvirt, this doesn't work for remote access but that's probably sufficient. With the patch I get on my machine: paphio:~/libvirt/tools -> ./virsh --version Virsh command line tool of libvirt 0.8.4 See web site at http://libvirt.org/ Compiled with support for: Hypervisors: Xen QEmu/KVM UML OpenVZ LXC ESX PHYP Test Networking: Remote Daemon Network Bridging Netcf Nwfilter Storage: Dir Disk Filesystem SCSI Multipath iSCSI LVM Miscellaneous: SELinux Secrets Debug Readline paphio:~/libvirt/tools -> instead of just "0.8.4" Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

7 12

[libvirt] [PATCH 0/2] speed up qemu domain save by increasing dd blocksize
by Laine Stump 29 Oct '10

29 Oct '10

These two patches are posted together because applying the 2nd exposes the bug fixed by the first. Here are the results of tests I made with various block sizes before deciding the 1MB really was the best balance (all tests were done on a paused 512MB domain, saving to local disk on a Lenovo T61 laptop) BS M:SS save image size ----- ---- --------------- 2048K - 0:56 476135451 1024K - 0:56 475090953 512k - 1:02 474564173 256k - 1:10 474303797 128k - 1:25 474176859 512 - 3:47 474085423 - the original I didn't bother testing sizes between 512 and 128k, as there was still significant improvement from 128k to 256k.

5 27

[libvirt] [PATCH] fix warnign on virtaudit.c
by KAMEZAWA Hiroyuki 28 Oct '10

28 Oct '10

I met this on the latest git tree. == >From fdd982b0cf3b772f61825736e6fc98bf948c4792 Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki <kamezawa.hiroyu(a)jp.fujitsu.com> Date: Thu, 28 Oct 2010 16:18:07 +0900 Subject: [PATCH] libvirt-audit-printf-warning-fix fix warning CC libvirt_util_la-virtaudit.lo cc1: warnings being treated as errors util/virtaudit.c: In function 'virAuditEncode': util/virtaudit.c:146: error: implicit declaration of function 'virAsprintf' [-Wimplicit-function-declaration] util/virtaudit.c:146: error: nested extern declaration of 'virAsprintf' [-Wnested-externs] --- src/util/virtaudit.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/util/virtaudit.c b/src/util/virtaudit.c index d568660..6af7af0 100644 --- a/src/util/virtaudit.c +++ b/src/util/virtaudit.c @@ -30,6 +30,7 @@ #include "virterror_internal.h" #include "logging.h" #include "virtaudit.h" +#include "util.h" /* Provide the macros in case the header file is old. FIXME: should be removed. */ -- 1.7.2.3

2 1

[libvirt] libvirt-csharp coverage update
by arnaud.champion＠devatom.fr 28 Oct '10

28 Oct '10

?Hi Justin, I have sended some patches today. When they will be pushed the coverage will the one in the xls file. I have also changed the linux testing environment, now I test mono bindings with Ubuntu 10.10 x64 and mono compiled in 64 bits, because we have seen some troubles with marshaling in this configuration. So, here are the all the test environements : - Windows 7 (64 bits) / .Net 4 - Windows 7 (64 bits) / Mono (compiled in 32 bits) 2.6.7 - Ubuntu 10.10 amd64 / Mono (compiled in 64 bits) 2.6.7 I will notify you about any changes about testing envs. Best regards, Arnaud

5 10

[libvirt] [PATCH] eliminate possibility of a double-closed file descriptor
by Stefan Berger 28 Oct '10

28 Oct '10

The 2nd and 3rd hunk show the only double-closed file descriptor code part that I found while trying to clean up close(). The first hunk seems a harmless cleanup in that same file. Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com> Index: Stefan/src/storage/storage_backend_logical.c =================================================================== --- Stefan.orig/src/storage/storage_backend_logical.c +++ Stefan/src/storage/storage_backend_logical.c @@ -37,6 +37,7 @@ #include "util.h" #include "memory.h" #include "logging.h" +#include "files.h" #define VIR_FROM_THIS VIR_FROM_STORAGE @@ -408,10 +409,10 @@ virStorageBackendLogicalBuildPool(virCon virReportSystemError(errno, _("cannot clear device header of '%s'"), pool->def->source.devices[i].path); - close(fd); + VIR_FORCE_CLOSE(fd); goto cleanup; } - if (close(fd) < 0) { + if (VIR_CLOSE(fd) < 0) { virReportSystemError(errno, _("cannot close device '%s'"), pool->def->source.devices[i].path); @@ -622,7 +623,7 @@ virStorageBackendLogicalCreateVol(virCon goto cleanup; } - if (close(fd) < 0) { + if (VIR_CLOSE(fd) < 0) { virReportSystemError(errno, _("cannot close file '%s'"), vol->target.path); @@ -641,8 +642,7 @@ virStorageBackendLogicalCreateVol(virCon return 0; cleanup: - if (fd != -1) - close(fd); + VIR_FORCE_CLOSE(fd); virStorageBackendLogicalDeleteVol(conn, pool, vol, 0); return -1; }

2 2

[libvirt] [PATCH] qemu: check for vm after starting a job
by Eric Blake 28 Oct '10

28 Oct '10

https://bugzilla.redhat.com/show_bug.cgi?id=638285 - when migrating a guest, it was very easy to provoke a race where an application could query block information on a VM that had just been migrated away. Any time qemu code obtains a job lock, it must also check that the VM was not taken down in the time where it was waiting for the lock. * src/qemu/qemu_driver.c (qemudDomainSetMemory) (qemudDomainGetInfo, qemuDomainGetBlockInfo): Check that vm still exists after obtaining job lock, before starting monitor action. --- src/qemu/qemu_driver.c | 25 ++++++++++++++++++++++--- 1 files changed, 22 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index ae1d833..af5126d 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -463,7 +463,8 @@ static int ATTRIBUTE_RETURN_CHECK qemuDomainObjEndJob(virDomainObjPtr obj) * obj must be locked before calling, qemud_driver must be unlocked * * To be called immediately before any QEMU monitor API call - * Must have alrady called qemuDomainObjBeginJob(). + * Must have already called qemuDomainObjBeginJob(), and checked + * that the VM is still active. * * To be followed with qemuDomainObjExitMonitor() once complete */ @@ -504,7 +505,7 @@ static void qemuDomainObjExitMonitor(virDomainObjPtr obj) * obj must be locked before calling, qemud_driver must be locked * * To be called immediately before any QEMU monitor API call - * Must have alrady called qemuDomainObjBeginJob(). + * Must have already called qemuDomainObjBeginJob(). * * To be followed with qemuDomainObjExitMonitorWithDriver() once complete */ @@ -522,7 +523,7 @@ static void qemuDomainObjEnterMonitorWithDriver(struct qemud_driver *driver, vir /* obj must NOT be locked before calling, qemud_driver must be unlocked, * and will be locked after returning * - * Should be paired with an earlier qemuDomainObjEnterMonitor() call + * Should be paired with an earlier qemuDomainObjEnterMonitorWithDriver() call */ static void qemuDomainObjExitMonitorWithDriver(struct qemud_driver *driver, virDomainObjPtr obj) { @@ -4948,6 +4949,12 @@ static int qemudDomainSetMemory(virDomainPtr dom, unsigned long newmem) { if (qemuDomainObjBeginJob(vm) < 0) goto cleanup; + if (!virDomainObjIsActive(vm)) { + qemuReportError(VIR_ERR_OPERATION_INVALID, + "%s", _("domain is not running")); + goto endjob; + } + priv = vm->privateData; qemuDomainObjEnterMonitor(vm); r = qemuMonitorSetBalloon(priv->mon, newmem); @@ -5014,11 +5021,17 @@ static int qemudDomainGetInfo(virDomainPtr dom, } else if (!priv->jobActive) { if (qemuDomainObjBeginJob(vm) < 0) goto cleanup; + if (!virDomainObjIsActive(vm)) { + qemuReportError(VIR_ERR_OPERATION_INVALID, + "%s", _("domain is not running")); + goto endjob; + } qemuDomainObjEnterMonitor(vm); err = qemuMonitorGetBalloonInfo(priv->mon, &balloon); qemuDomainObjExitMonitor(vm); if (err < 0) { + endjob: if (qemuDomainObjEndJob(vm) == 0) vm = NULL; goto cleanup; @@ -10343,6 +10356,11 @@ static int qemuDomainGetBlockInfo(virDomainPtr dom, qemuDomainObjPrivatePtr priv = vm->privateData; if (qemuDomainObjBeginJob(vm) < 0) goto cleanup; + if (!virDomainObjIsActive(vm)) { + qemuReportError(VIR_ERR_OPERATION_INVALID, + "%s", _("domain is not running")); + goto endjob; + } qemuDomainObjEnterMonitor(vm); ret = qemuMonitorGetBlockExtent(priv->mon, @@ -10350,6 +10368,7 @@ static int qemuDomainGetBlockInfo(virDomainPtr dom, &info->allocation); qemuDomainObjExitMonitor(vm); + endjob: if (qemuDomainObjEndJob(vm) == 0) vm = NULL; } else { -- 1.7.2.3

3 6

[libvirt] iptables complains about a bad rule
by Matthias Bolte 28 Oct '10

28 Oct '10

With libvirt from git on Ubuntu 10.04 I get this 3 errors (actually 2 warnings an 1 error) when starting libvirtd: 23:15:45.221: error : virRunWithHook:855 : internal error '/sbin/iptables --table mangle --delete POSTROUTING --out-interface virbr0 --protocol udp --destination-port 68 --jump CHECKSUM --checksum-fill' exited with non-zero status 2 and signal 0: iptables v1.4.4: unknown option `--checksum-fill' Try `iptables -h' or 'iptables --help' for more information. 23:15:45.238: error : virRunWithHook:855 : internal error '/sbin/iptables --table filter --delete INPUT --in-interface virbr0 --protocol udp --destination-port 69 --jump ACCEPT' exited with non-zero status 1 and signal 0: iptables: Bad rule (does a matching rule exist in that chain?). 23:15:45.275: error : virRunWithHook:855 : internal error '/sbin/iptables --table mangle --insert POSTROUTING --out-interface virbr0 --protocol udp --destination-port 68 --jump CHECKSUM --checksum-fill' exited with non-zero status 2 and signal 0: iptables v1.4.4: unknown option `--checksum-fill' Try `iptables -h' or 'iptables --help' for more information. The first and the last one just indicate that my iptables here is too old to know about --checksum-fill, but what about the second one? Matthias

2 4

[libvirt] cgroups and USB passthrough devices don't work together
by Diego Elio Pettenò 28 Oct '10

28 Oct '10

Hi all, beside the problem with USB devices I sent the patch for earlier, there is another problem that I'm not sure how to fix: the QEmu cgroup is _not_ allowed to access the device when adding it to the virtual machine. Basically it'd need a call to virCgroupAllowDevicePath() when adding the device… -- Diego Elio Pettenò — “Flameeyes” http://blog.flameeyes.eu/ If you found a .asc file in this mail and know not what it is, it's a GnuPG digital signature: http://www.gnupg.org/

2 1

[libvirt] [PATCH] qemu: Unref domain on error of opening qemu monitor
by Hu Tao 28 Oct '10

28 Oct '10

The domain refed will be left unrefed when there is error when opening qemu monitor, so unref it. --- src/qemu/qemu_driver.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 25695df..4bcfb27 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1385,7 +1385,7 @@ qemuConnectMonitor(struct qemud_driver *driver, virDomainObjPtr vm) (driver->securityDriver,vm) < 0) { VIR_ERROR(_("Failed to set security context for monitor for %s"), vm->def->name); - goto error; + return ret; } /* Hold an extra reference because we can't allow 'vm' to be @@ -1420,8 +1420,10 @@ qemuConnectMonitor(struct qemud_driver *driver, virDomainObjPtr vm) qemuDomainObjExitMonitorWithDriver(driver, vm); error: - if (ret < 0) + if (ret < 0) { qemuMonitorClose(priv->mon); + virDomainObjUnref(vm); + } return ret; } -- 1.7.3

3 4

Re: [libvirt] SPAM-LOW: Re: Re: Guide for libvirt C# bindings
by arnaud.champion＠devatom.fr 28 Oct '10

28 Oct '10

?In fact, I think it's better to let the choice to the libvirt team. I think they should have a good reason to not expose windows binary. Regards Arnaud From: 黄亮 Sent: Thursday, October 28, 2010 10:28 AM To: arnaud.champion(a)devatom.fr Subject: Re: Re: Re: SPAM-LOW: Re: Re: Guide for libvirt C# bindings yes. Compiling them can be really tough. And thanks for your job that we may invoke api of libvirt in Windows. Maybe you can upload the dll somewhere if libvirt.org won't host, just a suggestion. Regards. 2010-10-28 -------------------------------------------------------------------------------- Lancer -------------------------------------------------------------------------------- 发件人： arnaud.champion(a)devatom.fr 发送时间： 2010-10-28 16:10:54 收件人：黄亮抄送： libvir-list(a)redhat.com 主题： Re: Re: SPAM-LOW: Re: Re: Guide for libvirt C# bindings Yes all the dlls will be produced by this script. In fact, thanks for the script to it's author, it's the harder part (especially for windows users as I am, we are not used to compile in the linux wa ) I hope in the future that the libvirt windows dll will be directly hosted on libvirt.org, but I don't know. Regards, Arnaud From: 黄亮 Sent: Thursday, October 28, 2010 10:05 AM To: arnaud.champion(a)devatom.fr Subject: Re: Re: SPAM-LOW: Re: Re: Guide for libvirt C# bindings Really appreciated! Just to confirm that, all the dlls you mentioned is produced after I use photron scripts, right? That's great. And really thank you for what you've done. Regards and best wishes 2010-10-28 -------------------------------------------------------------------------------- 黄亮 -------------------------------------------------------------------------------- 发件人： arnaud.champion(a)devatom.fr 发送时间： 2010-10-28 15:45:15 收件人：黄亮抄送： libvir-list(a)redhat.com 主题： Re: SPAM-LOW: Re: Re: Guide for libvirt C# bindings Okay, libvirt-0.dll is the libvirt project compilation under windows. To produced it, there is two ways, the hard way and the smooth way the hard way is to install msys, mingwin and so one to have all needed tools, then download needed sources compile them. It's hard, and long. the smooth way is to use photron (Matthias) scripts to produce it. You can find scripts here : http://github.com/photron/msys_setup You download the scripts and foolow the readme.txt which is inside. Once you have compiled libvirt, you need to put these dll in an accessible way for your application (usually, I put it under the .exe produced by .Net) : - libcurl-4.dll (if compiled with esx support) - libgcrypt-11.dll - libgnutls-26.dll - libgpg-error-0.dll - libportablexdr-0.dll - libtasn1-3.dll - libvirt-0.dll - libxml2-2.dll Regards, Arnaud From: 黄亮 Sent: Thursday, October 28, 2010 9:29 AM To: arnaud.champion(a)devatom.fr Subject: SPAM-LOW: Re: Re: Guide for libvirt C# bindings Thank you for your reply. I've downloaded the source code by git. It seems the project needs a dll called libvirt-0.dll. It would be appreciated that you can tell me where to get the dll or how to produce it. Then I can try your examples and write my own. Regards 2010-10-28 -------------------------------------------------------------------------------- Lancer -------------------------------------------------------------------------------- 发件人： arnaud.champion(a)devatom.fr 发送时间： 2010-10-28 15:12:43 收件人：黄亮抄送： libvir-list(a)redhat.com 主题： Re: Guide for libvirt C# bindings Hi, the C# bindings provides 3 sample code to show how to use them. All functions are not in the examples, but examples show how to connect and get domain events (callbacks...) I use these bindings for another project : DAVIM ( www.devatom.fr sorry it's in french only ) and they work well. Anyway, I can help you if you have questions. Arnaud From: 黄亮 Sent: Thursday, October 28, 2010 4:30 AM To: arnaud.champion Subject: Guide for libvirt C# bindings Dear Arnaud Champion I learned you are making C# bindings for libvirt on libvirt.org. I'm interested in it and want to have a try on Windows. Do you have any guide books or introductions for using your C# bindings? I'm using .Net Framework 3.5 and VS 2005. Look forward to your reply. Regards 2010-10-28 -------------------------------------------------------------------------------- Lancer __________ Information from ESET Smart Security, version of virus signature database 5569 (20101027) __________ The message was checked by ESET Smart Security. http://www.eset.com __________ Information from ESET Smart Security, version of virus signature database 5569 (20101027) __________ The message was checked by ESET Smart Security. http://www.eset.com

2 1

Re: [libvirt] SPAM-LOW: Re: Re: Guide for libvirt C# bindings
by arnaud.champion＠devatom.fr 28 Oct '10

28 Oct '10

?Okay, libvirt-0.dll is the libvirt project compilation under windows. To produced it, there is two ways, the hard way and the smooth way the hard way is to install msys, mingwin and so one to have all needed tools, then download needed sources compile them. It's hard, and long. the smooth way is to use photron (Matthias) scripts to produce it. You can find scripts here : http://github.com/photron/msys_setup You download the scripts and foolow the readme.txt which is inside. Once you have compiled libvirt, you need to put these dll in an accessible way for your application (usually, I put it under the .exe produced by .Net) : - libcurl-4.dll (if compiled with esx support) - libgcrypt-11.dll - libgnutls-26.dll - libgpg-error-0.dll - libportablexdr-0.dll - libtasn1-3.dll - libvirt-0.dll - libxml2-2.dll Regards, Arnaud From: 黄亮 Sent: Thursday, October 28, 2010 9:29 AM To: arnaud.champion(a)devatom.fr Subject: SPAM-LOW: Re: Re: Guide for libvirt C# bindings Thank you for your reply. I've downloaded the source code by git. It seems the project needs a dll called libvirt-0.dll. It would be appreciated that you can tell me where to get the dll or how to produce it. Then I can try your examples and write my own. Regards 2010-10-28 -------------------------------------------------------------------------------- Lancer -------------------------------------------------------------------------------- 发件人： arnaud.champion(a)devatom.fr 发送时间： 2010-10-28 15:12:43 收件人：黄亮抄送： libvir-list(a)redhat.com 主题： Re: Guide for libvirt C# bindings Hi, the C# bindings provides 3 sample code to show how to use them. All functions are not in the examples, but examples show how to connect and get domain events (callbacks...) I use these bindings for another project : DAVIM ( www.devatom.fr sorry it's in french only ) and they work well. Anyway, I can help you if you have questions. Arnaud From: 黄亮 Sent: Thursday, October 28, 2010 4:30 AM To: arnaud.champion Subject: Guide for libvirt C# bindings Dear Arnaud Champion I learned you are making C# bindings for libvirt on libvirt.org. I'm interested in it and want to have a try on Windows. Do you have any guide books or introductions for using your C# bindings? I'm using .Net Framework 3.5 and VS 2005. Look forward to your reply. Regards 2010-10-28 -------------------------------------------------------------------------------- Lancer __________ Information from ESET Smart Security, version of virus signature database 5569 (20101027) __________ The message was checked by ESET Smart Security. http://www.eset.com

2 2

[libvirt] [PATCH] docs: updated the C# bindings page with arnauds latest changes
by Justin Clift 28 Oct '10

28 Oct '10

--- Going to push this directly, as Arnaud has already confirmed (on list) the generated output is correct. docs/csharp.html.in | 129 +++++++++++++++++++++++++++++++++------------------ 1 files changed, 83 insertions(+), 46 deletions(-) diff --git a/docs/csharp.html.in b/docs/csharp.html.in index a32fbd2..dc67d7c 100644 --- a/docs/csharp.html.in +++ b/docs/csharp.html.in @@ -24,6 +24,8 @@ <p> These bindings depend upon the libvirt libraries being installed. + </p> + <p> In the .NET case, this is <b>libvirt-0.dll</b>, produced from compiling libvirt for windows. </p> @@ -67,18 +69,51 @@ git clone git://libvirt.org/libvirt-csharp.git <h2><a name="usage">Usage</a></h2> <p> - The class library exposes the <b>LibvirtBindings</b> namespace. - This namespace exposes all of the needed types (enum, struct), - and 2 main classes, <b>libVirt</b> and <b>libvirtError</b>. + The libvirt C# bindings class library exposes the <b>Libvirt</b> + namespace. This namespace exposes all of the needed types (enum, + struct), plus many classes exposing the libvirt API methods. + </p> + <p> + These classes are grouped into functional areas, with each class + exposing libvirt methods related to that area. </p> <p> - The <b>libVirt</b> class exposes all of the interfaces of the - libvirt library for handling virtualized domains. + For example, the libvirt methods related to connections, such as + <b>virConnectOpenAuth</b> and <b>virConnectNumOfDomains</b>, are in + the <b>Connect</b> class. + <br /> + They are accessed as <b>Connect.OpenAuth</b>, and + <b>Connect.NumOfDomains</b> respectively. </p> <p> - The <b>libvirtError</b> class exposes all of the interfaces of - the libvirt library for handling errors raised while using the library. + In the same manner, the other class name mappings are: + </p> + <table class="top_table"> + <tr><th>Name of libvirt function</th><th>C# class name</th></tr> + <tr><td>virDomain...</td><td>Domain</td></tr> + <tr><td>virEvent...</td><td>Event</td></tr> + <tr><td>virInterface...</td><td>Interface</td></tr> + <tr><td>virNetwork...</td><td>Network</td></tr> + <tr><td>virNode...</td><td>Node</td></tr> + <tr><td>virSecret...</td><td>Secret</td></tr> + <tr><td>virStoragePool...</td><td>StoragePool</td></tr> + <tr><td>virStorageVolume...</td><td>StorageVolume</td></tr> + <tr><td>virStream...</td><td>Stream</td></tr> + </table> + <p> + There are some additions as well: </p> + <ul> + <li> + There is a class named <b>Library</b>, exposing the + <b>virGetVersion</b> and <b>virInitialize</b> methods + </li> + <li> + There is a class named <b>Errors</b>, exposing the error + related methods. For example, <b>virSetErrorFunc</b> and + <b>virConnResetLastError</b>. + </li> + </ul> <p> </p> @@ -92,14 +127,16 @@ git clone git://libvirt.org/libvirt-csharp.git <p> </p> - <h2><a name="notes">Notes on testing</a></h2> + <h2><a name="notes">Test Configuration</a></h2> <p> - Windows testing is performed on Windows 7, with .NET 4, Visual Studio 2010, and MonoDevelop 2.4. - </p> - <p> - Linux testing is performed on Fedora 13 i686, with MonoDevelop 2.2. + Testing is performed using the following configurations: </p> + <ul> + <li>Windows 7 (64 bits) / .Net 4</li> + <li>Windows 7 (64 bits) / Mono 2.6.7 (compiled in 32 bits)</li> + <li>Ubuntu 10.10 amd64 / Mono 2.6.7 (compiled in 64 bits)</li> + </ul> <p> </p> @@ -109,7 +146,7 @@ git clone git://libvirt.org/libvirt-csharp.git Coverage of the libvirt types is: </p> <table class="top_table"> - <tr><th>Type</th><th>Name</th><th>Binding?</th><th>Tested?</th><th>Sample Code?</th><th>Works?</th><th>Tested .Net/Windows Works?</th><th>Tested Mono/Windows Works?</th><th>Tested Mono/Linux Works?</th></tr> + <tr><th>Type</th><th>Name</th><th>Binding?</th><th>Tested?</th><th>Sample Code?</th><th>Works?</th><th>Tested .Net/Windows Works?</th><th>Tested Mono (32-bit)/Windows Works?</th><th>Tested Mono (64-bit)/Linux Works?</th></tr> <tr><td>enum</td><td>virCPUCompareResult</td><td>No</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>struct</td><td>virConnect</td><td>Yes, an IntPtr as the struct is not public</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> <tr><td>struct</td><td>virConnectAuth</td><td>Yes</td><td>Yes</td><td>virConnectOpenAuth</td><td>Yes</td><td>Yes</td><td>Yes</td><td>Yes</td></tr> @@ -122,7 +159,7 @@ git clone git://libvirt.org/libvirt-csharp.git <tr><td>enum</td><td>virDomainCoreDumpFlags</td><td>No</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>enum</td><td>virDomainCreateFlags</td><td>No</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>enum</td><td>virDomainDeviceModifyFlags</td><td>No</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> - <tr><td>enum</td><td>virDomainEventDefinedDetailType</td><td>Yes</td><td> </td><td>Yes</td><td>Yes</td><td> </td><td> </td><td> </td></tr> + <tr><td>enum</td><td>virDomainEventDefinedDetailType</td><td>Yes</td><td>Yes</td><td>virEventRegisterImpl</td><td>Yes</td><td>Yes</td><td>Yes</td><td>Yes</td></tr> <tr><td>struct</td><td>virDomainEventGraphicsAddress</td><td>No</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>enum</td><td>virDomainEventGraphicsAddressType</td><td>No</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>enum</td><td>virDomainEventGraphicsPhase</td><td>No</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> @@ -130,12 +167,12 @@ git clone git://libvirt.org/libvirt-csharp.git <tr><td>struct</td><td>virDomainEventGraphicsSubjectIdentity</td><td>No</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>enum</td><td>virDomainEventID</td><td>No</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>enum</td><td>virDomainEventIOErrorAction</td><td>No</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> - <tr><td>enum</td><td>virDomainEventResumedDetailType</td><td>Yes</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> - <tr><td>enum</td><td>virDomainEventStartedDetailType</td><td>Yes</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> - <tr><td>enum</td><td>virDomainEventStoppedDetailType</td><td>Yes</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> - <tr><td>enum</td><td>virDomainEventSuspendedDetailType</td><td>Yes</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> - <tr><td>enum</td><td>virDomainEventType</td><td>Yes</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> - <tr><td>enum</td><td>virDomainEventUndefinedDetailType</td><td>Yes</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> + <tr><td>enum</td><td>virDomainEventResumedDetailType</td><td>Yes</td><td>Yes</td><td>virEventRegisterImpl</td><td>Yes</td><td>Yes</td><td>Yes</td><td>Yes</td></tr> + <tr><td>enum</td><td>virDomainEventStartedDetailType</td><td>Yes</td><td>Yes</td><td>virEventRegisterImpl</td><td>Yes</td><td>Yes</td><td>Yes</td><td>Yes</td></tr> + <tr><td>enum</td><td>virDomainEventStoppedDetailType</td><td>Yes</td><td>Yes</td><td>virEventRegisterImpl</td><td>Yes</td><td>Yes</td><td>Yes</td><td>Yes</td></tr> + <tr><td>enum</td><td>virDomainEventSuspendedDetailType</td><td>Yes</td><td>Yes</td><td>virEventRegisterImpl</td><td>Yes</td><td>Yes</td><td>Yes</td><td>Yes</td></tr> + <tr><td>enum</td><td>virDomainEventType</td><td>Yes</td><td>Yes</td><td>virEventRegisterImpl</td><td>Yes</td><td>Yes</td><td>Yes</td><td>Yes</td></tr> + <tr><td>enum</td><td>virDomainEventUndefinedDetailType</td><td>Yes</td><td>Yes</td><td>virEventRegisterImpl</td><td>Yes</td><td>Yes</td><td>Yes</td><td>Yes</td></tr> <tr><td>enum</td><td>virDomainEventWatchdogAction</td><td>No</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>struct</td><td>virDomainInfo</td><td>Yes</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> <tr><td>struct</td><td>virDomainInterfaceStatsStruct</td><td>Yes</td><td>No</td><td> </td><td>Maybe</td><td> </td><td> </td><td> </td></tr> @@ -149,7 +186,7 @@ git clone git://libvirt.org/libvirt-csharp.git <tr><td>enum</td><td>virDomainSnapshotDeleteFlags</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>enum</td><td>virDomainState</td><td>Yes</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> <tr><td>enum</td><td>virDomainXMLFlags</td><td>Yes</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> - <tr><td>enum</td><td>virEventHandleType</td><td>Yes</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> + <tr><td>enum</td><td>virEventHandleType</td><td>Yes</td><td>Yes</td><td>virEventRegisterImpl</td><td>Yes</td><td>Yes</td><td>Yes</td><td>Yes</td></tr> <tr><td>struct</td><td>virInterface</td><td>Yes, an IntPtr as the struct is not public</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>enum</td><td>virInterfaceXMLFlags</td><td>No</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>struct</td><td>virNWFilter</td><td>No</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> @@ -162,10 +199,10 @@ git clone git://libvirt.org/libvirt-csharp.git <tr><td>enum</td><td>virSecretUsageType</td><td>No</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>struct</td><td>virSecurityLabel</td><td>No</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>struct</td><td>virSecurityModel</td><td>No</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> - <tr><td>struct</td><td>virStoragePool</td><td>Yes, an IntPtr as the struct is not public</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>enum</td><td>virStoragePoolBuildFlags</td><td>Yes</td><td>No</td><td> </td><td>Maybe</td><td> </td><td> </td><td> </td></tr> <tr><td>enum</td><td>virStoragePoolDeleteFlags</td><td>Yes</td><td>No</td><td> </td><td>Maybe</td><td> </td><td> </td><td> </td></tr> <tr><td>struct</td><td>virStoragePoolInfo</td><td>Yes</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> + <tr><td>struct</td><td>virStoragePool</td><td>Yes, an IntPtr as the struct is not public</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>enum</td><td>virStoragePoolState</td><td>Yes</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> <tr><td>struct</td><td>virStorageVol</td><td>Yes, an IntPtr as the struct is not public</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>enum</td><td>virStorageVolDeleteFlags</td><td>No</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> @@ -186,10 +223,10 @@ git clone git://libvirt.org/libvirt-csharp.git Coverage of the libvirt functions is: </p> <table class="top_table"> - <tr><th>Name</th><th>Binding?</th><th>Type?</th><th>Tested?</th><th>Sample Code?</th><th>Working?</th><th>Tested .Net/Windows Works?</th><th>Tested Mono/Windows Works?</th><th>Tested Mono/Linux Works?</th></tr> - <tr><td>virConnectAuthCallbackPtr</td><td>Yes</td><td>delegate</td><td>Yes</td><td>virConnectOpenAuth</td><td>Yes</td><td>Yes</td><td>Yes</td><td> </td></tr> + <tr><th>Name</th><th>Binding?</th><th>Type?</th><th>Tested?</th><th>Sample Code?</th><th>Working?</th><th>Tested .Net/Windows Works?</th><th>Tested Mono (32-bit)/Windows Works?</th><th>Tested Mono (64-bit)/Linux Works?</th></tr> + <tr><td>virConnectAuthCallback</td><td>Yes</td><td>delegate</td><td>Yes</td><td>virConnectOpenAuth</td><td>Yes</td><td>Yes</td><td>Yes</td><td>Yes</td></tr> <tr><td>virConnectBaselineCPU</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> - <tr><td>virConnectClose</td><td>Yes</td><td>function</td><td>Yes</td><td>virConnectOpenAuth</td><td> </td><td>Yes</td><td>Yes</td><td>Yes</td></tr> + <tr><td>virConnectClose</td><td>Yes</td><td>function</td><td>Yes</td><td>virConnectOpenAuth</td><td>Yes</td><td>Yes</td><td>Yes</td><td>Yes</td></tr> <tr><td>virConnectCompareCPU</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virConnectDomainEventCallback</td><td>Yes</td><td>delegate</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> <tr><td>virConnectDomainEventDeregister</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> @@ -199,7 +236,7 @@ git clone git://libvirt.org/libvirt-csharp.git <tr><td>virConnectDomainEventIOErrorCallback</td><td>No</td><td>delegate</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virConnectDomainEventIOErrorReasonCallback</td><td>No</td><td>delegate</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virConnectDomainEventRTCChangeCallback</td><td>No</td><td>delegate</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> - <tr><td>virConnectDomainEventRegister</td><td>Yes</td><td>function</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> + <tr><td>virConnectDomainEventRegister</td><td>Yes</td><td>function</td><td>Yes</td><td>virEventRegisterImpl</td><td>Yes</td><td>Yes</td><td>Yes</td><td>Yes</td></tr> <tr><td>virConnectDomainEventRegisterAny</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virConnectDomainEventWatchdogCallback</td><td>No</td><td>delegate</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virConnectDomainXMLFromNative</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> @@ -219,11 +256,11 @@ git clone git://libvirt.org/libvirt-csharp.git <tr><td>virConnectListDefinedNetworks</td><td>Yes</td><td>function</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> <tr><td>virConnectListDefinedStoragePools</td><td>Yes</td><td>function</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> <tr><td>virConnectListDomains</td><td>Yes</td><td>function</td><td>Yes</td><td>virConnectOpenAuth</td><td>Yes</td><td>Yes</td><td>Yes</td><td>Yes</td></tr> - <tr><td>virConnectListInterfaces</td><td>Yes</td><td>function</td><td>Yes</td><td> </td><td>Yes, if the host handles the method</td><td> </td><td> </td><td> </td></tr> + <tr><td>virConnectListInterfaces</td><td>Yes</td><td>function</td><td>Yes</td><td> </td><td>Yes, if the host handle the method</td><td> </td><td> </td><td> </td></tr> <tr><td>virConnectListNWFilters </td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virConnectListNetworks</td><td>Yes</td><td>function</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> <tr><td>virConnectListSecrets</td><td>Yes</td><td>function</td><td>No</td><td> </td><td>Maybe</td><td> </td><td> </td><td> </td></tr> - <tr><td>virConnectListStoragePools</td><td>Yes</td><td>function</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> + <tr><td>virConnectListStoragePools</td><td>Yes</td><td>function</td><td>Yes</td><td>virConnectOpen</td><td>Yes</td><td>Yes</td><td>Yes</td><td>Yes</td></tr> <tr><td>virConnectNumOfDefinedDomains</td><td>Yes</td><td>function</td><td>Yes</td><td>virConnectOpenAuth</td><td>Yes</td><td>Yes</td><td>Yes</td><td>Yes</td></tr> <tr><td>virConnectNumOfDefinedInterfaces</td><td>Yes</td><td>function</td><td>No</td><td> </td><td>Maybe</td><td> </td><td> </td><td> </td></tr> <tr><td>virConnectNumOfDefinedNetworks</td><td>Yes</td><td>function</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> @@ -233,8 +270,8 @@ git clone git://libvirt.org/libvirt-csharp.git <tr><td>virConnectNumOfNWFilters</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virConnectNumOfNetworks </td><td>Yes</td><td>function</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> <tr><td>virConnectNumOfSecrets</td><td>Yes</td><td>function</td><td>No</td><td> </td><td>Maybe</td><td> </td><td> </td><td> </td></tr> - <tr><td>virConnectNumOfStoragePools</td><td>Yes</td><td>function</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> - <tr><td>virConnectOpen</td><td>Yes</td><td>function</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> + <tr><td>virConnectNumOfStoragePools</td><td>Yes</td><td>function</td><td>Yes</td><td>virConnectOpen</td><td>Yes</td><td>Yes</td><td>Yes</td><td>Yes</td></tr> + <tr><td>virConnectOpen</td><td>Yes</td><td>function</td><td>Yes</td><td>virConnectOpen, virEventRegisterImpl</td><td>Yes</td><td>Yes</td><td>Yes</td><td>Yes</td></tr> <tr><td>virConnectOpenAuth</td><td>Yes</td><td>function</td><td>Yes</td><td>virConnectOpenAuth</td><td>Yes</td><td>Yes</td><td>Yes</td><td>Yes</td></tr> <tr><td>virConnectOpenReadOnly</td><td>Yes</td><td>function</td><td>No</td><td> </td><td>Maybe</td><td> </td><td> </td><td> </td></tr> <tr><td>virConnectRef</td><td>Yes</td><td>function</td><td>No</td><td> </td><td>Maybe</td><td> </td><td> </td><td> </td></tr> @@ -272,29 +309,29 @@ git clone git://libvirt.org/libvirt-csharp.git <tr><td>virDomainGetXMLDesc</td><td>Yes</td><td>function</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> <tr><td>virDomainHasCurrentSnapshot</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virDomainHasManagedSaveImage</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> - <tr><td>virDomainInterfaceStats</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> + <tr><td>virDomainInterfaceStats </td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virDomainIsActive</td><td>Yes</td><td>function</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> <tr><td>virDomainIsPersistent</td><td>Yes</td><td>function</td><td>No</td><td> </td><td>Maybe</td><td> </td><td> </td><td> </td></tr> <tr><td>virDomainLookupByID</td><td>Yes</td><td>function</td><td>Yes</td><td>virConnectOpenAuth</td><td>Yes</td><td>Yes</td><td>Yes</td><td>Yes</td></tr> <tr><td>virDomainLookupByName</td><td>Yes</td><td>function</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> <tr><td>virDomainLookupByUUID</td><td>Yes</td><td>function</td><td>No</td><td> </td><td>Maybe</td><td> </td><td> </td><td> </td></tr> <tr><td>virDomainLookupByUUIDString</td><td>Yes</td><td>function</td><td>No</td><td> </td><td>Maybe</td><td> </td><td> </td><td> </td></tr> - <tr><td>virDomainManagedSave</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> + <tr><td>virDomainManagedSave </td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virDomainManagedSaveRemove</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virDomainMemoryPeek</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virDomainMemoryStats</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virDomainMigrate</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virDomainMigrateSetMaxDowntime</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> - <tr><td>virDomainMigrateToURI</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> + <tr><td>virDomainMigrateToURI </td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virDomainPinVcpu</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virDomainReboot</td><td>Yes</td><td>function</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> - <tr><td>virDomainRef</td><td>Yes</td><td>function</td><td>No</td><td> </td><td>Maybe</td><td> </td><td> </td><td> </td></tr> + <tr><td>virDomainRef </td><td>Yes</td><td>function</td><td>No</td><td> </td><td>Maybe</td><td> </td><td> </td><td> </td></tr> <tr><td>virDomainRestore</td><td>Yes </td><td>function</td><td>No</td><td> </td><td>Maybe</td><td> </td><td> </td><td> </td></tr> - <tr><td>virDomainResume</td><td>Yes</td><td>function</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> + <tr><td>virDomainResume </td><td>Yes</td><td>function</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> <tr><td>virDomainRevertToSnapshot</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virDomainSave</td><td>Yes</td><td>function</td><td>No</td><td> </td><td>Maybe</td><td> </td><td> </td><td> </td></tr> <tr><td>virDomainSetAutostart</td><td>Yes</td><td>function</td><td>No</td><td> </td><td>Maybe</td><td> </td><td> </td><td> </td></tr> - <tr><td>virDomainSetMaxMemory</td><td>Yes</td><td>function</td><td>No</td><td> </td><td>Maybe</td><td> </td><td> </td><td> </td></tr> + <tr><td>virDomainSetMaxMemory </td><td>Yes</td><td>function</td><td>No</td><td> </td><td>Maybe</td><td> </td><td> </td><td> </td></tr> <tr><td>virDomainSetMemory</td><td>Yes</td><td>function</td><td>No</td><td> </td><td>Maybe</td><td> </td><td> </td><td> </td></tr> <tr><td>virDomainSetSchedulerParameters</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virDomainSetVcpus</td><td>Yes</td><td>function</td><td>No</td><td> </td><td>Maybe</td><td> </td><td> </td><td> </td></tr> @@ -312,14 +349,14 @@ git clone git://libvirt.org/libvirt-csharp.git <tr><td>virDomainUpdateDeviceFlags</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virEventAddHandleFunc</td><td>Yes</td><td>delegate</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> <tr><td>virEventAddTimeoutFunc</td><td>Yes</td><td>delegate</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> - <tr><td>virEventHandleCallback</td><td>Yes</td><td>delegate</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> - <tr><td>virEventRegisterImpl</td><td>Yes</td><td>function</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> + <tr><td>virEventHandleCallback</td><td>Yes</td><td>delegate</td><td>Yes</td><td>virEventRegisterImpl</td><td>Yes</td><td>Yes</td><td>Yes</td><td>Yes</td></tr> + <tr><td>virEventRegisterImpl</td><td>Yes</td><td>function</td><td>Yes</td><td>virEventRegisterImpl</td><td>Yes</td><td>Yes</td><td>Yes</td><td>Yes</td></tr> <tr><td>virEventRemoveHandleFunc</td><td>Yes</td><td>delegate</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> <tr><td>virEventRemoveTimeoutFunc</td><td>Yes</td><td>delegate</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> - <tr><td>virEventTimeoutCallback</td><td>Yes</td><td>delegate</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> + <tr><td>virEventTimeoutCallback</td><td>Yes</td><td>delegate</td><td>Yes</td><td>virEventRegisterImpl</td><td>Yes</td><td>Yes</td><td>Yes</td><td>Yes</td></tr> <tr><td>virEventUpdateHandleFunc</td><td>Yes</td><td>delegate</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> <tr><td>virEventUpdateTimeoutFunc</td><td>Yes</td><td>delegate</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> - <tr><td>virFreeCallback</td><td>Yes</td><td>function</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> + <tr><td>virFreeCallback</td><td>Yes</td><td>function</td><td>Yes</td><td>virEventRegisterImpl</td><td>Yes</td><td>Yes</td><td>Yes</td><td>Yes</td></tr> <tr><td>virGetVersion</td><td>Yes</td><td>function</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> <tr><td>virInitialize</td><td>Yes</td><td>function</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> <tr><td>virInterfaceCreate</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> @@ -333,7 +370,7 @@ git clone git://libvirt.org/libvirt-csharp.git <tr><td>virInterfaceIsActive</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virInterfaceLookupByMACString</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virInterfaceLookupByName</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> - <tr><td>virInterfaceRef</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> + <tr><td>virInterfaceRef </td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virInterfaceUndefine</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virNWFilterDefineXML</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virNWFilterFree</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> @@ -344,7 +381,7 @@ git clone git://libvirt.org/libvirt-csharp.git <tr><td>virNWFilterLookupByName </td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virNWFilterLookupByUUID</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virNWFilterLookupByUUIDString</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> - <tr><td>virNWFilterRef</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> + <tr><td>virNWFilterRef </td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virNWFilterUndefine</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virNetworkCreate</td><td>Yes</td><td>function</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> <tr><td>virNetworkCreateXML</td><td>Yes</td><td>function</td><td>No</td><td> </td><td>Maybe</td><td> </td><td> </td><td> </td></tr> @@ -386,10 +423,10 @@ git clone git://libvirt.org/libvirt-csharp.git <tr><td>virNodeListDevices</td><td>Yes</td><td>function</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> <tr><td>virNodeNumOfDevices</td><td>Yes</td><td>function</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> <tr><td>virSecretDefineXML</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> - <tr><td>virSecretFree</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> + <tr><td>virSecretFree </td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virSecretGetConnect</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virSecretGetUUID</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> - <tr><td>virSecretGetUUIDString</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> + <tr><td>virSecretGetUUIDString </td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virSecretGetUsageID</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virSecretGetUsageType</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virSecretGetValue</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> @@ -441,13 +478,13 @@ git clone git://libvirt.org/libvirt-csharp.git <tr><td>virStorageVolLookupByPath</td><td>Yes</td><td>function</td><td>Yes</td><td> </td><td>Yes</td><td> </td><td> </td><td> </td></tr> <tr><td>virStorageVolRef</td><td>Yes</td><td>function</td><td>No</td><td> </td><td>No</td><td> </td><td> </td><td> </td></tr> <tr><td>virStorageVolWipe</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> - <tr><td>virStreamAbort</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> + <tr><td>virStreamAbort </td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virStreamEventAddCallback</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virStreamEventCallback</td><td>No</td><td>delegate</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virStreamEventRemoveCallback</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virStreamEventUpdateCallback</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virStreamFinish </td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> - <tr><td>virStreamFree</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> + <tr><td>virStreamFree </td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virStreamNew</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virStreamRecv</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> <tr><td>virStreamRecvAll</td><td>No</td><td>function</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr> -- 1.7.2.3

1 1

Re: [libvirt] SPAM-LOW: Re: Re: Guide for libvirt C# bindings
by arnaud.champion＠devatom.fr 28 Oct '10

28 Oct '10

?Yes all the dlls will be produced by this script. In fact, thanks for the script to it's author, it's the harder part (especially for windows users as I am, we are not used to compile in the linux wa ) I hope in the future that the libvirt windows dll will be directly hosted on libvirt.org, but I don't know. Regards, Arnaud From: 黄亮 Sent: Thursday, October 28, 2010 10:05 AM To: arnaud.champion(a)devatom.fr Subject: Re: Re: SPAM-LOW: Re: Re: Guide for libvirt C# bindings Really appreciated! Just to confirm that, all the dlls you mentioned is produced after I use photron scripts, right? That's great. And really thank you for what you've done. Regards and best wishes 2010-10-28 -------------------------------------------------------------------------------- 黄亮 -------------------------------------------------------------------------------- 发件人： arnaud.champion(a)devatom.fr 发送时间： 2010-10-28 15:45:15 收件人：黄亮抄送： libvir-list(a)redhat.com 主题： Re: SPAM-LOW: Re: Re: Guide for libvirt C# bindings Okay, libvirt-0.dll is the libvirt project compilation under windows. To produced it, there is two ways, the hard way and the smooth way the hard way is to install msys, mingwin and so one to have all needed tools, then download needed sources compile them. It's hard, and long. the smooth way is to use photron (Matthias) scripts to produce it. You can find scripts here : http://github.com/photron/msys_setup You download the scripts and foolow the readme.txt which is inside. Once you have compiled libvirt, you need to put these dll in an accessible way for your application (usually, I put it under the .exe produced by .Net) : - libcurl-4.dll (if compiled with esx support) - libgcrypt-11.dll - libgnutls-26.dll - libgpg-error-0.dll - libportablexdr-0.dll - libtasn1-3.dll - libvirt-0.dll - libxml2-2.dll Regards, Arnaud From: 黄亮 Sent: Thursday, October 28, 2010 9:29 AM To: arnaud.champion(a)devatom.fr Subject: SPAM-LOW: Re: Re: Guide for libvirt C# bindings Thank you for your reply. I've downloaded the source code by git. It seems the project needs a dll called libvirt-0.dll. It would be appreciated that you can tell me where to get the dll or how to produce it. Then I can try your examples and write my own. Regards 2010-10-28 -------------------------------------------------------------------------------- Lancer -------------------------------------------------------------------------------- 发件人： arnaud.champion(a)devatom.fr 发送时间： 2010-10-28 15:12:43 收件人：黄亮抄送： libvir-list(a)redhat.com 主题： Re: Guide for libvirt C# bindings Hi, the C# bindings provides 3 sample code to show how to use them. All functions are not in the examples, but examples show how to connect and get domain events (callbacks...) I use these bindings for another project : DAVIM ( www.devatom.fr sorry it's in french only ) and they work well. Anyway, I can help you if you have questions. Arnaud From: 黄亮 Sent: Thursday, October 28, 2010 4:30 AM To: arnaud.champion Subject: Guide for libvirt C# bindings Dear Arnaud Champion I learned you are making C# bindings for libvirt on libvirt.org. I'm interested in it and want to have a try on Windows. Do you have any guide books or introductions for using your C# bindings? I'm using .Net Framework 3.5 and VS 2005. Look forward to your reply. Regards 2010-10-28 -------------------------------------------------------------------------------- Lancer __________ Information from ESET Smart Security, version of virus signature database 5569 (20101027) __________ The message was checked by ESET Smart Security. http://www.eset.com

1 0

[libvirt] C# bindins web page changes
by arnaud.champion＠devatom.fr 28 Oct '10

28 Oct '10

?Hi Justin, since renaming of the C# bindings is done, the usage described has also to be changed. I'll try to explain you : the project no more expose the namespace "libvirtBindings", in place the new namespace is "Libvirt". The Libvirt namespace expose all types needed (struct, enum...) Now there is more classes to expose API methods : - virConnect... methods (virConnectOpen, virConnectNumOfDomains,etc) are in the "Connect" class. For example, "virConnectOpenAuth" is "Connect.OpenAuth" method in bindings, "virConnectNumOfDomains" is "Connect.NumOfDomains" In the same manner : virDomain... methods are in the "Domain" class virEvent... in the "Event" class virInterface... in the "Interface" class virNetwork... in the "Network" class virNode... in the "Node" class virSecret... in the "Secret" class (even if nothing is binded in it :S but it will be) virStoragePool... in the "StoragePool" class virStorageVolume... in the "StorageVolume" class virStream... in the "Stream" class There is some exceptions in fact : - there is a class "Library" which expose "virGetVersion" and "virInitialize" methods - the class "Errors" which expose error related methods (for example "virSetErrorFunc" or "virConnResetLastError") Best regards, Arnaud

2 3

Re: [libvirt] Guide for libvirt C# bindings
by arnaud.champion＠devatom.fr 28 Oct '10

28 Oct '10

?Hi, the C# bindings provides 3 sample code to show how to use them. All functions are not in the examples, but examples show how to connect and get domain events (callbacks...) I use these bindings for another project : DAVIM ( www.devatom.fr sorry it's in french only ) and they work well. Anyway, I can help you if you have questions. Arnaud From: 黄亮 Sent: Thursday, October 28, 2010 4:30 AM To: arnaud.champion Subject: Guide for libvirt C# bindings Dear Arnaud Champion I learned you are making C# bindings for libvirt on libvirt.org. I'm interested in it and want to have a try on Windows. Do you have any guide books or introductions for using your C# bindings? I'm using .Net Framework 3.5 and VS 2005. Look forward to your reply. Regards 2010-10-28 -------------------------------------------------------------------------------- Lancer

1 0

Re: [libvirt] dommemstat won't work
by 黄亮 28 Oct '10

28 Oct '10

Oh... So, is there any documents that I can see which driver supports "dommemstat"? Thank you 2010-10-28 Lancer

3 2

[libvirt] [PATCH] docs: update ruby bindings maintainer to chris lalancette
by Justin Clift 28 Oct '10

28 Oct '10

--- docs/bindings.html.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/bindings.html.in b/docs/bindings.html.in index b190a38..41114f0 100644 --- a/docs/bindings.html.in +++ b/docs/bindings.html.in @@ -60,7 +60,7 @@ </p> </li> <li> - <strong>Ruby</strong>: David Lutterkort develops + <strong>Ruby</strong>: Chris Lalancette develops <a href="http://libvirt.org/ruby/">Ruby bindings</a>. </li> </ul> -- 1.7.2.3

1 1

[libvirt] [PATCH] docs: revamp api_extension example, using vcpu patch series
by Eric Blake 28 Oct '10

28 Oct '10

Complete patch is compressed and attached, because it is so large. But the bulk of it consisted mainly of running 'git format-patch -15 b0137887' to pick up the top of my vcpu series, then replacing the contents of docs/api_extension/ with the new patches. The meat of the patch is the overview html file, copied here if you don't want to unzip the attachment: 2010-10-20 Eric Blake <eblake(a)redhat.com> docs: revamp api_extension example, using vcpu patch series * docs/api_extension/*: Replace example files. * docs/api_extension.html.in: Rewrite to match new example files. diff --git c/docs/api_extension.html.in w/docs/api_extension.html.in index de6eedc..1396e91 100644 --- c/docs/api_extension.html.in +++ w/docs/api_extension.html.in @@ -10,8 +10,12 @@ <p> This document walks you through the process of implementing a new - API in libvirt. It uses as an example the addition of the node device - create and destroy APIs. + API in libvirt. It uses as an example the addition of + separating maximum from current vcpu usage of a domain. + Remember that new API includes any new public functions, but it + also includes addition of flags or extension of XML used through + existing functions. The example in this document adds both + types of API, and not all extensions require quite as many patches. </p> <p> @@ -23,7 +27,12 @@ added to libvirt. Someone may already be working on the feature you want. Also, recognize that everything you write is likely to undergo significant rework as you discuss it with the other developers, so - don't wait too long before getting feedback. + don't wait too long before getting feedback. In the vcpu example + below, list feedback was first requested + <a href="https://www.redhat.com/archives/libvir-list/2010-September/msg00423.html">here</a>, + and resulted in several rounds of improvements before coding + began, and this example is slightly rearranged from the actual + order of the commits. </p> <p> @@ -46,11 +55,22 @@ <li>define the public API</li> <li>define the internal driver API</li> <li>implement the public API</li> - <li>define the wire protocol format</li> - <li>implement the RPC client</li> - <li>implement the server side dispatcher</li> - <li>implement the driver methods</li> + <li>implement the remote protocol: + <ol> + <li>define the wire protocol format</li> + <li>implement the RPC client</li> + <li>implement the server side dispatcher</li> + </ol> + </li> + <li>use new API where appropriate in drivers</li> <li>add virsh support</li> + <li>add common handling for new API</li> + <li>for each driver that can support the new API: + <ol> + <li>add prerequisite support</li> + <li>fully implement new API</li> + </ol> + </li> </ol> <p> @@ -66,11 +86,10 @@ functionality--get the whole thing working and make sure you're happy with it. Then use git or some other version control system that lets you rewrite your commit history and break patches into pieces so you - don't drop a big blob of code on the mailing list at one go. For - example, I didn't follow my own advice when I originally submitted the - example code to the libvirt list but rather submitted it in several - large chunks. I've used git's ability to rewrite my commit history to - break the code apart into the example patches shown. + don't drop a big blob of code on the mailing list at one go. + The example code used in this document was rebased several + times between the original list posting and the final committed + version. </p> <p> @@ -86,9 +105,23 @@ <h2><a name='publicapi'>Defining the public API</a></h2> - <p>The first task is to define the public API and add it to:</p> + <p>The first task is to define the public API. If the addition + involves XML, this includes enhancing the RelaxNG schema and + documenting the new elements or attributes:</p> - <p><code>include/libvirt/libvirt.h.in</code></p> + <p><code> + docs/schemas/domain.rng<br/> + docs/formatdomain.html.in + </code></p> + + <p>If the addition involves a new function, this involves adding + a declaration in the public header, and arranging to export the + symbol:</p> + + <p><code> + include/libvirt/libvirt.h.in + src/libvirt_public.syms + </code></p> <p> This task is in many ways the most important to get right, since once @@ -99,12 +132,9 @@ rework it as you go through the process of implementing it. </p> - <p>Once you have defined the API, you have to add the symbol names to:</p> - - <p><code>src/libvirt_public.syms</code></p> - - <p class="example">See <a href="api_extension/0001-Step-1-of-8-Define-the-public-API.patch">0001-Step-1-of-8-Define-the-public-API.patch</a> for example code.</p> - + <p class="example">See <a href="api_extension/0001-Step-1-of-15-add-to-xml.patch">0001-Step-1-of-15-add-to-xml.patch</a> + and <a href="api_extension/0002-Step-2-of-15-add-new-public-API.patch">0002-Step-2-of-15-add-new-public-API.patch</a> + for example code.</p> <h2><a name='internalapi'>Defining the internal API</a></h2> @@ -118,7 +148,7 @@ <p> Of course, it's possible that the new API will involve the creation of - an entire new driver type, in which case the changes will include the + an entirely new driver type, in which case the changes will include the creation of a new struct type to represent the new driver type. </p> @@ -129,10 +159,11 @@ <p> To define the internal API, first typedef the driver function prototype and then add a new field for it to the relevant driver - struct. + struct. Then, update all existing instances of the driver to + provide a <code>NULL</code> stub for the new function. </p> - <p class="example">See <a href="api_extension/0002-Step-2-of-8-Define-the-internal-driver-API.patch">0002-Step-2-of-8-Define-the-internal-driver-API.patch</a></p> + <p class="example">See <a href="api_extension/0003-Step-3-of-15-define-internal-driver-API.patch">0003-Step-3-of-15-define-internal-driver-API.patch</a></p> <h2><a name='implpublic'>Implementing the public API</a></h2> @@ -166,16 +197,23 @@ <p><code>src/libvirt.c</code></p> - <p class="example">See <a href="api_extension/0003-Step-3-of-8-Implement-the-public-API.patch">0003-Step-3-of-8-Implement-the-public-API.patch</a></p> + <p class="example">See <a href="api_extension/0004-Step-4-of-15-implement-the-public-APIs.patch">0004-Step-4-of-15-implement-the-public-APIs.patch</a></p> + + <h2><a name='remoteproto'>Implementing the remote protocol</a></h2> + + <p> + Implementing the remote protocol is essentially a + straightforward exercise which is probably most easily + understood by referring to the existing code and the example + patch. It involves several related changes, followed by + regenerating derived files.</p> + <p class="example">See <a href="api_extension/0005-Step-5-of-15-implement-the-remote-protocol.patch">0005-Step-5-of-15-implement-the-remote-protocol.patch</a></p> - <h2><a name='wireproto'>Defining the wire protocol format</a></h2> + <h3><a name='wireproto'>Defining the wire protocol format</a></h3> <p> - Defining the wire protocol is essentially a straightforward exercise - which is probably most easily understood by referring to the existing - remote protocol wire format definitions and the example patch. It - involves making two additions to: + Defining the wire protocol involves making additions to: </p> <p><code>src/remote/remote_protocol.x</code></p> @@ -185,7 +223,7 @@ to the API. One struct describes the parameters to be passed to the remote function, and a second struct describes the value returned by the remote function. The one exception to this rule is that functions - that return only integer status do not require a struct for returned + that return only 0 or -1 for status do not require a struct for returned data. </p> @@ -194,23 +232,19 @@ added to the API. </p> - <p class="example">See <a href="api_extension/0004-Step-4-of-8-Define-the-wire-protocol-format.patch">0004-Step-4-of-8-Define-the-wire-protocol-format.patch</a></p> - <p> Once these changes are in place, it's necessary to run 'make rpcgen' in the src directory to create the .c and .h files required by the remote protocol code. This must be done on a Linux host using the GLibC rpcgen program. Other rpcgen versions may generate code which - results in bogus compile time warnings + results in bogus compile time warnings. </p> - - <h2><a name='rpcclient'>Implement the RPC client</a></h2> + <h3><a name='rpcclient'>Implement the RPC client</a></h3> <p> - Implementing the RPC client is also relatively mechanical, so refer to - the exising code and example patch for guidance. The RPC client uses - the rpcgen generated .h files. The remote method calls go in: + Implementing the uses the rpcgen generated .h files. The remote + method calls go in: </p> <p><code>src/remote/remote_internal.c</code></p> @@ -227,17 +261,10 @@ <li>unlocks the remote driver.</li> </ol> - <p> - Once you have created the remote method calls, you have to add fields - for them to the driver structs for the appropriate remote driver. - </p> - - <p class="example">See <a href="api_extension/0005-Step-5-of-8-Implement-the-RPC-client.patch">0005-Step-5-of-8-Implement-the-RPC-client.patch</a></p> - - <h2><a name="serverdispatch">Implement the server side dispatcher</a></h2> + <h3><a name="serverdispatch">Implement the server side dispatcher</a></h3> <p> - Implementing the server side of the remote function calls is simply a + Implementing the server side of the remote function call is simply a matter of deserializing the parameters passed in from the remote caller and passing them to the corresponding internal API function. The server side dispatchers are implemented in: @@ -247,8 +274,65 @@ <p>Again, this step uses the .h files generated by make rpcgen.</p> - <p class="example">See <a href="api_extension/0006-Step-6-of-8-Implement-the-server-side-dispatcher.patch">0006-Step-6-of-8-Implement-the-server-side-dispatcher.patch</a></p> + <p> + After all three pieces of the remote protocol are complete, and + the generated files have been updated, it will be necessary to + update the file:</p> + + <p><code>src/remote_protocol-structs</code></p> + + <p> + This file should only have new lines added; modifications to + existing lines probably imply a backwards-incompatible API change. + </p> + + <p class="example">See <a href="api_extension/0005-Step-5-of-15-implement-the-remote-protocol.patch">0005-Step-5-of-15-implement-the-remote-protocol.patch</a></p> + + <h2><a name="internaluseapi">Use the new API internally</a></h2> + + <p> + Many times, a new API is merely an extension of existing + concepts that accomplished a subset of the same actions. When + this is the case, it makes sense to share a common + implementation by making the older API become a trivial wrapper + around the new API, rather than duplicating the common code. + This step should not introduce any semantic differences for the + old API. This step is optional if the new API has no relation + to existing API. + </p> + + <p class="example">See <a href="api_extension/0006-Step-6-of-15-make-old-API-trivially-wrap-to-new-API.patch">0006-Step-6-of-15-make-old-API-trivially-wrap-to-new-API.patch</a></p> + + <h2><a name="virshuseapi">Expose the new API in virsh</a></h2> + + <p> + All new API should be manageable from the virsh command line + shell. This proves that the API is sufficient for the purpose, + and makes it possible to identify if the proposed API needs slight + changes for easier usage. However, remember that virsh is used + to connect to hosts running older versions of libvirtd, so the + new commands should have fallbacks to the older API when + possible; implementing the virsh hooks at this point makes it + very easy to test these fallbacks. Also remember to document + virsh additions. + </p> + + <p> + A virsh command is composed of a few pieces of code. You need to + define an array of vshCmdInfo structs for each new command that + contain the help text and the command description text. You also need + an array of vshCmdOptDef structs to describe the command options. + Once you have those pieces of data in place you can write the function + implementing the virsh command. Finally, you need to add the new + command to the commands[] array. The following files need changes: + </p> + <p><code> + tools/virsh.c<br/> + tools/virsh.pod + </code></p> + + <p class="example">See <a href="api_extension/0007-Step-7-of-15-add-virsh-support.patch">0007-Step-7-of-15-add-virsh-support.patch</a></p> <h2><a name="driverimpl">Implement the driver methods</a></h2> @@ -261,42 +345,72 @@ adding. </p> + <h3><a name="commonimpl">Implement common handling</a></h3> + <p> - In the example code, the extension is only an additional two function - calls in the node device API, so most of the new code is additions to - existing files. The only new files are there for multi-platform - implementation convenience, as some of the new code is Linux specific. + If the new API is applicable to more than one driver, it may + make sense to provide some utility routines, or to factor some + of the work into the dispatcher, to avoid reimplementing the + same code in every driver. In the example code, this involved + adding a member to the virDomainDefPtr struct for mapping + between the XML API addition and the in-memory representation of + a domain, along with updating all clients to use the new member. + Up to this point, there have been no changes to existing + semantics, and the new APIs will fail unless they are used in + the same way as the older API wrappers. </p> + <p class="example">See <a href="api_extension/0008-Step-8-of-15-support-new-xml.patch">0008-Step-8-of-15-support-new-xml.patch</a></p> + + <h3><a name="drivercode">Implement driver handling</a></h3> + <p> - The example code is probably uninteresting unless you're concerned - with libvirt storage, but I've included it here to show how new files - are added to the build environment. + The remaining patches should only touch one driver at a time. + It is possible to implement all changes for a driver in one + patch, but for review purposes, it may still make sense to break + things into simpler steps. Here is where the new APIs finally + start working. </p> - <p class="example">See <a href="api_extension/0007-Step-7-of-8-Implement-the-driver-methods.patch">0007-Step-7-of-8-Implement-the-driver-methods.patch</a></p> + <p> + In the example patches, three separate drivers are supported: + test, qemu, and xen. It is always a good idea to patch the test + driver in addition to the target driver, to prove that the API + can be used for more than one driver. The example updates the + test driver in one patch: + </p> - <h2><a name="virsh">Implement virsh commands</a></h2> + <p class="example">See <a href="api_extension/0009-Step-9-of-15-support-all-flags-in-test-driver.patch">0009-Step-9-of-15-support-all-flags-in-test-driver.patch</a></p> <p> - Once you have the new functionality in place, the easiest way to test - it and also to provide it to end users is to implement support for it - in virsh. + The qemu changes were easier to split into two phases, one for + updating the mapping between the new XML and the hypervisor + command line arguments, and one for supporting all possible + flags of the new API: </p> + <p class="example">See <a href="api_extension/0010-Step-10-of-15-improve-vcpu-support-in-qemu-command-line.patch">0010-Step-10-of-15-improve-vcpu-support-in-qemu-command-line.patch</a> + and <a href="api_extension/0011-Step-11-of-15-complete-vcpu-support-in-qemu-driver.patch">0011-Step-11-of-15-complete-vcpu-support-in-qemu-driver.patch</a></p> + <p> - A virsh command is composed of a few pieces of code. You need to - define an array of vshCmdInfo structs for each new command that - contain the help text and the command description text. You also need - an array of vshCmdOptDef structs to describe the command options. - Once you have those pieces of data in place you can write the function - implementing the virsh command. Finally, you need to add the new - command to the commands[] array. + Finally, the example breaks the xen driver changes across four + patches, mapping the XML changes to the hypervisor command + lines, implementing the getter API independently of the setter + API, and cleanup of up code rendered dead by the new API: </p> - <p class="example">See <a href="api_extension/0008-Step-8-of-8-Add-virsh-support.patch">0008-Step-8-of-8-Add-virsh-support.patch</a></p> + <p class="example">See <a href="api_extension/0012-Step-12-of-15-improve-vcpu-support-in-xen-command-line.patch">0012-Step-12-of-15-improve-vcpu-support-in-xen-command-line.patch</a>, + <a href="api_extension/0013-Step-13-of-15-improve-support-for-getting-xen-vcpu-counts.patch">0013-Step-13-of-15-improve-support-for-getting-xen-vcpu-counts.patch</a>, + <a href="api_extension/0014-Step-14-of-15-improve-support-for-setting-xen-vcpu-counts.patch">0014-Step-14-of-15-improve-support-for-setting-xen-vcpu-counts.patch</a>, + and <a href="api_extension/0015-Step-15-of-15-remove-dead-xen-code.patch">0015-Step-15-of-15-remove-dead-xen-code.patch</a></p> + + <p> + The exact details of the example code are probably uninteresting + unless you're concerned with virtual cpu management. + </p> <p>Once you have working functionality, run make check and make - syntax-check before generating patches.</p> + syntax-check on each patch of the series before submitting + patches.</p> </body> </html> -- Eric Blake eblake(a)redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org

5 12

[libvirt] [PATCH] docs: reworded and reordered the bindings page, plus minor tweaks
by Justin Clift 28 Oct '10

28 Oct '10

Reordered the bindings into alphabetical order, added a link to the php-libvirt source on Github, plus gave the direct package names needed for Python usage on RHEL/Fedora, and Ubuntu. --- At some point the "Windows" statement on this page should be reworded or made a bit neater too. Not just yet though. :) docs/bindings.html.in | 62 +++++++++++++++++++++++++++++++++--------------- 1 files changed, 42 insertions(+), 20 deletions(-) diff --git a/docs/bindings.html.in b/docs/bindings.html.in index 0bc997e..7a90ad6 100644 --- a/docs/bindings.html.in +++ b/docs/bindings.html.in @@ -4,42 +4,64 @@ <h1 >Bindings for other languages</h1> <p> - Libvirt comes with bindings to support other languages than - pure <strong>C</strong>. First the headers embeds the necessary - declarations to allow direct access from <strong>C++</strong> - code, but also we have bindings for higher level kind of languages: + Libvirt supports C and C++ directly, and has bindings available + for other languages: </p> <ul> <li> - <strong>Python</strong>: Libvirt comes with direct support for - the Python language (just make sure you installed the libvirt-python - package if not compiling from sources). See below for more - information about using libvirt with python + <strong>C#</strong>: Arnaud Champion develops + <a href="csharp.html">C# bindings</a>. </li> <li> - <strong>Perl</strong>: Daniel Berrange provides - <a href="http://search.cpan.org/dist/Sys-Virt/">bindings for Perl</a>. + <strong>Java</strong>: Daniel Veillard develops + <a href="java.html">Java bindings</a>. </li> <li> - <strong>OCaml</strong>: Richard Jones supplies - <a href="http://libvirt.org/ocaml/">bindings for OCaml</a>. + <strong>OCaml</strong>: Richard Jones develops + <a href="http://libvirt.org/ocaml/">OCaml bindings</a>. </li> <li> - <strong>Ruby</strong>: David Lutterkort provides - <a href="http://libvirt.org/ruby/">bindings for Ruby</a>. + <strong>Perl</strong>: Daniel Berrange develops + <a href="http://search.cpan.org/dist/Sys-Virt/">Perl bindings</a>. </li> <li> - <strong>Java</strong>: Daniel Veillard maintains - <a href="java.html">Java bindings</a>. + <p> + <strong>PHP</strong>: Radek Hladik develops + <a href="http://phplibvirt.cybersales.cz/">PHP bindings</a>. + </p> + <p> + The php-libvirt bindings also have their source online + <a href="http://github.com/Kedarius/php-libvirt">here in Github</a>. + </p> + <p> + This allows you to easily see the code, make comments on it, + create your own forks, and contribute the changes back. + </p> </li> <li> - <strong>C#</strong>: Arnaud Champion maintains - <a href="csharp.html">C# bindings</a>. + <p> + <strong>Python</strong>: Libvirt comes with direct support for + the Python language. + </p> + <p> + If your libvirt is installed as packages, rather than compiled + by you from source code, ensure you have the appropriate + package installed. + </p> + <p> + This is named <b>libvirt-python</b> on RHEL/Fedora, + <a href="http://packages.ubuntu.com/search?keywords=python-libvirt"><b>python-libvirt</b></a> + on Ubuntu, and may be named differently on others. + </p> + <p> + For usage information, see the + <a href="python.html">Python API bindings</a> page. + </p> </li> <li> - <strong>PHP</strong>: Radek Hladik is developing - <a href="http://phplibvirt.cybersales.cz/">PHP bindings</a>. + <strong>Ruby</strong>: David Lutterkort develops + <a href="http://libvirt.org/ruby/">Ruby bindings</a>. </li> </ul> -- 1.7.2.3

2 2

[libvirt] [PATCH] mingw: Add body for virFork and remove double virDriverLoadModule export
by Matthias Bolte 27 Oct '10

27 Oct '10

Commit 9bd3cce0d2d54e6ab893bb8137218b83d9294714 added virFork and virDriverLoadModule to libvirt_private.syms, but virFork didn't have a body on Win32 and virDriverLoadModule was already correctly exported conditional via libvirt_driver_modules.syms. --- src/libvirt_private.syms | 4 ---- src/util/util.c | 9 +++++++++ 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 1a71e79..670e9f2 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -314,10 +314,6 @@ virDomainConfNWFilterTeardown; virDomainConfVMNWFilterTeardown; -# driver.h -virDriverLoadModule; - - # ebtables.h ebtablesAddForwardAllowIn; ebtablesAddForwardPolicyReject; diff --git a/src/util/util.c b/src/util/util.c index 586baee..fd4d6d4 100644 --- a/src/util/util.c +++ b/src/util/util.c @@ -927,6 +927,15 @@ virExecDaemonize(const char *const*argv ATTRIBUTE_UNUSED, return -1; } +int +virFork(pid_t *pid) +{ + *pid = -1; + errno = ENOTSUP; + + return -1; +} + # endif /* WIN32 */ int -- 1.7.0.4

2 2

[libvirt] [libvirt-csharp][PATCH] add new sample "virEventRegisterImpl"
by arnaud.champion＠devatom.fr 27 Oct '10

27 Oct '10

?Hi, this patch add a new sample code for Visual Studio and Mono. The sample show how to use domain callbacks via virEventRegisterImpl (he old way, deprecated method for domain events). Regards, Arnaud

2 1

[libvirt] [libvirt-csharp][PATCH] Make examples works on mono compiled in 64 bits, simply the ConnectOpenAuth process, and finalise renaming
by arnaud.champion＠devatom.fr 27 Oct '10

27 Oct '10

?Hi, I have finally find the problem with examples on mono compiled in 64 bits. The problem was the "ToInt32" method of an IntPtr which failed on mono 64 bits (have to use ToInt64 instead). This path solve this problem. Also, I have put marshaling complexity of the ConnectOpenAuth callback in bindings, this make the callback of ConnectOpenAuth more simple to achieve the authentification. In the example, the callback is treated like this : private static int AuthCallback(ref ConnectCredential[] creds, IntPtr cbdata) { AuthData authData = (AuthData)Marshal.PtrToStructure(cbdata, typeof(AuthData)); foreach (ConnectCredential cred in creds) { switch (cred.type) { case ConnectCredentialType.VIR_CRED_AUTHNAME: // Fill the user name cred.Result = authData.user_name; break; case ConnectCredentialType.VIR_CRED_PASSPHRASE: // Fill the password cred.Result = authData.password; break; default: return -1; } } return 0; } The bindings user has no marshaling to do, and believe me, it's simpler. Finally, this patch finalize renaming. Best regards, Arnaud Champion

2 3

[libvirt] Xen: Stream-API or XML-RPC or XenAPI for managedSave, snapshots
by Philipp Hahn 27 Oct '10

27 Oct '10

Hello, for our project I need libvirts "managed save" functionality for Xen-3.4. In my implementation I tried to use Xens 'suspend' and 'resume', which would nicely match, but these two functions are not available throu the legacy streaming API (xend-http-server, xend-unix-server), which libvirt seems to still use. They are available throu the XML-RPC interface and the XenAPI interface, which libvirt doesn't seem to use. Are there any plans to convert libvirt to use one of the newer interfaces? My other option would be to either implement another subdriver for xenUnified*, which would implement domainManagedSave(), domainHasManagedSaveImage() and domainManagedSaveRemove() using XML-RPC (or XenAPI), or to implement suspend() and resume() in Xend. I also will need to look at snapshots next: Has someone already investigated adding snapshot support to Xen(-3.4)? Sincerely Philipp Hahn -- Philipp Hahn Open Source Software Engineer hahn(a)univention.de Univention GmbH Linux for Your Business fon: +49 421 22 232- 0 Mary-Somerville-Str.1 28359 Bremen fax: +49 421 22 232-99 http://www.univention.de Besuchen Sie uns auf unseren nächsten Veranstaltungen: 26. - 28.10.: IT & Business 2010 in Stuttgart 27. - 28.10.: MODERNER STAAT 2010 in Berlin http://www.univention.de/univention/termine/veranstaltungstermin/

2 2

[libvirt] dommemstat won't work
by 黄亮 27 Oct '10

27 Oct '10

Hi all. I try "virsh dommemstat <domain>" and it returns as follows :Failed to get memory statistics for domain vm_unfw :this function is not supported by the connection driver: virDomainMemoryStats So what may be the problem? I'm using CentOS release 5.5. Updated it's libvirt from 0.6.3 to 0.8.4 through "./configure; make; make install" procedure, and ran "autobuild.sh" in the directory of libvirt-0.8.4. Using "virsh version", it tells xen api version is 3.0.1, and xm version is 3.3.0 Thanks! 2010-10-27 黄亮

2 1

[libvirt] [PATCH 0/7]: Rewrite all the auditing hooks
by Daniel P. Berrange 27 Oct '10

27 Oct '10

This patch series reverts two previous commits which added auditing hooks to the daemon/remote.c dispatcher code. This is then replaced with hooks added directly to the QEMU driver code. This has the downside that auditing only works for the QEMU driver, but it is unavoidable because the dispatcher code has insufficient information to properly generate audit records. It also handles escaping of strings which contain user supplied arbitrary formatted data. It finishes up by adding auditing of disk/net resources.

2 15

[libvirt] [PATCH] Tell automake to use tar-pax instead of tar-v7 for make dist
by Matthias Bolte 27 Oct '10

27 Oct '10

Commit 66a04090673a5e21700d11bdea0084f1ee870c24 updated the API extention example patch series and added files that results in filenames longer than 99 chars during make dist. This is a problem because automake uses tar with the old v7 format during make dist. The v7 format is limited to 99 chars per filename. Use the newer and unlimited POSIX format instead. --- configure.ac | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index d942d3c..838dac7 100644 --- a/configure.ac +++ b/configure.ac @@ -6,7 +6,7 @@ AC_CONFIG_AUX_DIR([build-aux]) AC_CONFIG_HEADERS([config.h]) AC_CONFIG_MACRO_DIR([m4]) dnl Make automake keep quiet about wildcards & other GNUmake-isms -AM_INIT_AUTOMAKE([-Wno-portability]) +AM_INIT_AUTOMAKE([1.9 -Wno-portability tar-pax]) # Use the silent-rules feature when possible. m4_ifndef([AM_SILENT_RULES], [m4_define([AM_SILENT_RULES],[])]) -- 1.7.0.4

4 4

[libvirt] [PATCH] Fix xen API documentation.
by Philipp Hahn 27 Oct '10

27 Oct '10

Add missing 'on'. Change 'dom' to 'domain' as used in xenDaemonDomainBlockPeek() Signed-off-by: Philipp Hahn <hahn(a)univention.de> --- src/xen/xend_internal.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

2 1

[libvirt] Gtk# help
by arnaud.champion＠devatom.fr 27 Oct '10

27 Oct '10

?Hi, As you maybe have seen in my csharp sample code, I'm not an expert with Gtk# under mono, it's really different from windows form. Can anyone help me with Gtk# to make the bindings samples better ? Arnaud

1 0

[libvirt] Libvirt.org "Docs" page (top level)
by Justin Clift 27 Oct '10

27 Oct '10

Hi us, The top level libvir.org Docs page is blank: http://libvirt.org/docs.html Looks like it's only purpose is to show the menu on the left hand side, where people can click documentation headings. The completely empty page content though, kind of looks "wrong", so I'm thinking we should fit it with something. Initial thought is to have an autogenerated list of all the docs pages, expanded out. Pretty much a table of contents kind of thing. But open to suggestions too if someone has better ideas? :) Regards and best wishes, Justin Clift

3 3

Re: [libvirt] How to start a defined domain
by 黄亮 27 Oct '10

27 Oct '10

yes, and it works now, both "virsh start vm01" and my program. A lot of thanks to you. But there is still something disturbing. I'm using putty on windows xp connecting to another computer running CentOS which has xen and libvirt on it. After I type "virsh start vm01" or run my program, the terminal freezes, I can't input anything to terminal. And then the network connection to server is closed. Have you been into this? 2010-10-27 黄亮发件人： Osier 发送时间： 2010-10-27 11:25:54 收件人：黄亮抄送：主题： Re: [libvirt] How to start a defined domain ----- "黄亮" <lancerhuang(a)163.com> wrote: > > > nope. > > "vm01" can be seen after I started it using "xm create vm01". > But, if I shut it down using "xm shutdown vm01", it can't be seen > using "virsh list --all" > > I assume that, "vm01" only have a xm config file stored in /etc/xen/, > and libvirt or virsh need a XML style config file. So I can't start > vm01 using "virsh start vm01" nor can I see it using "virsh list > --all". > > Is it like this? Do correct me if I'm wrong :-) so it becomes clear now, I guess you didn't 'define' the guest from libvirt side, that means'vm01' is not a persistent domain, so after you shutdown the vm01 using xm, yes, libvirt can't see it anymore. actually even if after you use "virsh destroy" or "virsh shutdown", libvirt can't see it either.. :-) the way to define a domain to be persistent,(assume the domain is running) # virsh dumpxml vm01 > vm01.xml # virsh define vm01.xml then think you can start it via: # virsh start vm01 - Osier > > 2010-10-27 > > 黄亮 > > 发件人： Osier > 发送时间： 2010-10-27 10:56:54 > 收件人：黄亮 > 抄送： > 主题： Re: [libvirt] How to start a defined domain > > > > ----- "黄亮" <lancerhuang(a)163.com> wrote: > > > > > Oh, yeah, you're right, it's "make uninstall" :-) > > > > after uninstall 0.8.4 and reinstall 0.6.3, it still won't work. > > > > but one thing I should mention is that while using "virsh start > vm01", > > it reports the same error, saying can't find domain "vm01" with > > "xenUnifiedDomainLookupByName ". > > So I think maybe there is something I'm missing in define a domain. > > > > Would you give me some hints so I can see where I go wrong? Really > > appreciated > > > > ah, well, so let us check lower, can you see the guest "vm01" by > "virsh list --all"? > > - Osier > > > > 2010-10-27 > > > > 黄亮 > > > > 发件人： Osier > > 发送时间： 2010-10-26 22:29:40 > > 收件人：黄亮 > > 抄送： libvir-list > > 主题： Re: [libvirt] How to start a defined domain > > > > > > > > ----- "黄亮" <lancerhuang(a)163.com> wrote: > > > > > > > > Well, after "make clean", I run the compiled start.c, still won't > > > work. > > > > "make clean" won't uninstall the installed stuffs, use "make > > uninstall" > > instead, or you just made a typo? :-) > > > > after that, suggest re-installing 0.6.3 if you are not sure if it's > > injured. > > > > - Osier > > > > > And I forget to metion, an error msg is shown: > > > > > > libvir: Xen error : Domain not found: xenUnifiedDomainLookupByName > > > > > > is that means I missed something? > > > > > > > > > 2010-10-26 > > > > > > 黄亮 > > > > > > 发件人： Osier > > > 发送时间： 2010-10-26 18:05:46 > > > 收件人：黄亮 > > > 抄送： > > > 主题： Re: [libvirt] How to start a defined domain > > > > > > > > > > > > ----- "黄亮" <lancerhuang(a)163.com> wrote: > > > > > > > > > > > Accroding to your case, it seems I have no need to upgrade > libvirt > > > to > > > > 0.8.4 > > > > Will that work if I erase 0.8.4 using "make clean" and draw back > > to > > > > 0.6.3 ? > > > > > > yep, think so, if you don't need the new features, and 0.6.3 is > > enough > > > for your project requirement.. :-) > > > > > > - Osier > > > > > > > > > > > > > > > > 2010-10-26 > > > > > > > > 黄亮 > > > > > > > > 发件人： Osier > > > > 发送时间： 2010-10-26 17:10:40 > > > > 收件人：黄亮 > > > > 抄送： > > > > 主题： Re: [libvirt] How to start a defined domain > > > > > > > > > > > > > > > > ----- "黄亮" <lancerhuang(a)163.com> wrote: > > > > > > > > > > > > > > Thanks for your reply, Osier. > > > > > > > > > > > > > > > The distro I'm using is CentOS release 5.5 (Final) > > > > > > > > > > I'm not quite sure about the version of libvirt. At first, it > > > seems > > > > to > > > > > be 0.6.3, because /usr/lib64/libvirt.so.0 points to > > > > > /usr/lib64/libvirt.so.0.6.3 > > > > > Then I downloaded the src of libvirt_0.8.4 from offical > website, > > > and > > > > > configure, make, make install. > > > > > But now it show errors when I type "virsh". The error message > > lies > > > > > below: > > > > > > > > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.8.2' > not > > > > found > > > > > (required by virsh) > > > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.1' > not > > > > found > > > > > (required by virsh) > > > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.5' > not > > > > found > > > > > (required by virsh) > > > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.8.1' > not > > > > found > > > > > (required by virsh) > > > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.0' > not > > > > found > > > > > (required by virsh) > > > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.2' > not > > > > found > > > > > (required by virsh) > > > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.3' > not > > > > found > > > > > (required by virsh) > > > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.8.0' > not > > > > found > > > > > (required by virsh) > > > > > virsh: /usr/local/lib/libvirt.so.0: version > > > `LIBVIRT_PRIVATE_0.8.4' > > > > > not found (required by virsh) > > > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.7' > not > > > > found > > > > > (required by virsh) > > > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.6.4' > not > > > > found > > > > > (required by virsh) > > > > > > > > probly you should try to erase the 0.6.3, then compile and > install > > > > libvirt > > > > like: > > > > > > > > # ./configure --prefix=/usr --libdir=/usr/lib64 > > > > # make > > > > # make install > > > > > > > > your test program has no problem on my box. the libvirt on my > box > > > also > > > > is > > > > 0.6.3. > > > > > > > > Regards > > > > > > > > - Osier > > > > > > > > > > As for xen, it is 3.3.2. The full "xm info" message is listed > > > below: > > > > > host : testbed01 > > > > > release : 2.6.18-194.11.4.el5xen > > > > > version : #1 SMP Tue Sep 21 05:40:24 EDT 2010 > > > > > machine : x86_64 > > > > > nr_cpus : 8 > > > > > nr_nodes : 1 > > > > > cores_per_socket : 4 > > > > > threads_per_core : 2 > > > > > cpu_mhz : 2793 > > > > > hw_caps : > > > > > > > > > > > > > > > bfebfbff:28100800:00000000:00000140:0098e3fd:00000000:00000001:00000000 > > > > > virt_caps : hvm > > > > > total_memory : 4055 > > > > > free_memory : 533 > > > > > node_to_cpu : node0:0-7 > > > > > node_to_memory : node0:533 > > > > > xen_major : 3 > > > > > xen_minor : 3 > > > > > xen_extra : .2 > > > > > xen_caps : xen-3.0-x86_64 xen-3.0-x86_32p hvm-3.0-x86_32 > > > > > hvm-3.0-x86_32p hvm-3.0-x86_64 > > > > > xen_scheduler : credit > > > > > xen_pagesize : 4096 > > > > > platform_params : virt_start=0xffff800000000000 > > > > > xen_changeset : unavailable > > > > > cc_compiler : gcc version 4.1.2 20080704 (Red Hat 4.1.2-44) > > > > > cc_compile_by : root > > > > > cc_compile_domain : gitco.tld > > > > > cc_compile_date : Tue Aug 18 21:07:28 CEST 2009 > > > > > xend_config_format : 4 > > > > > > > > > > I've write a simple c program to test the api, and it is > listed > > > > below: > > > > > > > > > > 1 // This program aims to test the api which can start the VM > > > > > 2 > > > > > 3 #include "stdio.h" > > > > > 4 #include "stdlib.h" > > > > > 5 #include "libvirt/libvirt.h" > > > > > 6 > > > > > 7 int main(int argc ,char* argv[]) > > > > > 8 { > > > > > 9 virConnectPtr conn; > > > > > 10 conn = virConnectOpen( "xen+tcp://localhost?no_Verify=1" ); > > > > > 11 if( conn == NULL ) > > > > > 12 { > > > > > 13 printf( "Failed to Connect\n" ); > > > > > 14 return 1; > > > > > 15 } > > > > > 16 const char* host = "vm01"; > > > > > 17 virDomainPtr dom; > > > > > 18 dom = virDomainLookupByName( conn, host ); > > > > > 19 if( dom == NULL ) > > > > > 20 { > > > > > 21 printf( "can't find dom\n" ); > > > > > 22 return 1; > > > > > 23 } > > > > > 24 // else > > > > > 25 // { > > > > > 26 // virDomainFree( dom ); > > > > > 27 // virConnectClose( conn ); > > > > > 28 // printf("done\n"); > > > > > 29 // return 0; > > > > > 30 // } > > > > > 31 if( virDomainCreate( dom ) == -1 ) > > > > > 32 { > > > > > 33 printf( "failed to Start\n" ); > > > > > 34 virDomainFree( dom ); > > > > > 35 virConnectClose( conn ); > > > > > 36 return 1; > > > > > 37 } > > > > > 38 else > > > > > 39 { > > > > > 40 printf( "Started\n" ); > > > > > 41 virDomainFree( dom ); > > > > > 42 virConnectClose( conn ); > > > > > 43 return 0; > > > > > 44 } > > > > > 45 } > > > > > > > > > > 2010-10-26 > > > > > > > > > > Lancer > > > > > > > > > > 发件人： Osier > > > > > 发送时间： 2010-10-26 11:35:31 > > > > > 收件人：黄亮 > > > > > 抄送： libvir-list > > > > > 主题： Re: [libvirt] How to start a defined domain > > > > > > > > > > > > > > > > > > > > ----- "黄亮" <lancerhuang(a)163.com> wrote: > > > > > > > > > > > I've create a domain called "vm01" using Virt-Manager, the > GUI > > > > tool. > > > > > > Now I wanna use libvirt api to control the life cycle of > vm01. > > > > > > It went on well with shutdown and reboot, but how to start > it > > > > became > > > > > a > > > > > > problem. > > > > > > > > > > > > I was intended to get the virDomainPtr by using > > > > > virDomainLookupByName > > > > > > api, and then start it using virDomainCreate api. > > > > > > But it turns out that virDomainLookupByName api cannot > return > > a > > > > > > virDomainPtr for a defined but not running domain. > > > > > > > > > > > > > > > > no, it can :-) > > > > > > > > > > If it really doesn't work for you, could you write a simple > > > program > > > > to > > > > > reproduce it? and try to explain what's the version of libvirt > > you > > > > > use, > > > > > on which distro, etc, any helpful info is welcomed. :-) > > > > > > > > > > Thanks > > > > > > > > > > - Osier > > > > > > > > > > > That's my situation, what do you suggest I do now? > > > > > > Thanks in advance. > > > > > > > > > > > > 2010-10-26 > > > > > > > > > > > > Lancer > > > > > > -- > > > > > > libvir-list mailing list > > > > > > libvir-list(a)redhat.com > > > > > > https://www.redhat.com/mailman/listinfo/libvir-list > > > > > > > > > > __________ Information from ESET Smart Security, version of > > virus > > > > > signature database 5562 (20101025) __________ > > > > > > > > > > The message was checked by ESET Smart Security. > > > > > > > > > > http://www.eset.com > > > > > > > > __________ Information from ESET Smart Security, version of > virus > > > > signature database 5562 (20101025) __________ > > > > > > > > The message was checked by ESET Smart Security. > > > > > > > > http://www.eset.com > > > > > > __________ Information from ESET Smart Security, version of virus > > > signature database 5563 (20101026) __________ > > > > > > The message was checked by ESET Smart Security. > > > > > > http://www.eset.com > > > > __________ Information from ESET Smart Security, version of virus > > signature database 5565 (20101026) __________ > > > > The message was checked by ESET Smart Security. > > > > http://www.eset.com > > __________ Information from ESET Smart Security, version of virus > signature database 5566 (20101027) __________ > > The message was checked by ESET Smart Security. > > http://www.eset.com __________ Information from ESET Smart Security, version of virus signature database 5566 (20101027) __________ The message was checked by ESET Smart Security. http://www.eset.com

1 0

Re: [libvirt] --checksum-fill error on Ubuntu 10.04
by Osier 27 Oct '10

27 Oct '10

caused by network filter driver depends on the newer iptables, there is no "--checksum-fill" option indeed in older iptables. The following commit log is from iptables git. commit 9d1b11102b53103c00b7fddf4658a4d2bdee1338 Author: Michael S. Tsirkin <mst(a)redhat.com> Date: Thu Jul 15 17:23:24 2010 +0200 extensions: libxt_CHECKSUM extension This adds a `CHECKSUM' target, which can be used in the iptables mangle table. You can use this target to compute and fill in the checksum in a packet that lacks a checksum. This is particularly useful, if you need to work around old applications such as dhcp clients, that do not work well with checksum offloads, but don't want to disable checksum offload in your device. The problem happens in the field with virtualized applications. For reference, see Red Hat bz 605555, as well as http://www.spinics.net/lists/kvm/msg37660.html Typical expected use (helps old dhclient binary running in a VM): iptables -A POSTROUTING -t mangle -p udp --dport bootpc \ -j CHECKSUM --checksum-fill Includes fixes by Jan Engelhardt <jengelh(a)medozas.de> Signed-off-by: Michael S. Tsirkin <mst(a)redhat.com> Signed-off-by: Patrick McHardy <kaber(a)trash.net> Even on my FC13, it's without "CHECKSUM" support, the build date is 'Thu 08 Apr 2010 06:30:45 PM CST', :-) Could we treat the error message as warnings? or make it only works for newer iptables? - Osier ----- "Justin Clift" <jclift(a)redhat.com> wrote: > Hi us, > > Just noticed an error message when manually starting libvirtd (built > from git) on Ubuntu 10.04, while checking something else: > > iptables v1.4.4: unknown option `--checksum-fill' > > It shows up in the initial default network setup: > > 10:40:19.807: error : virRunWithHook:855 : internal error > '/sbin/iptables --table mangle --insert POSTROUTING --out-interface > virbr0 --protocol udp --destination-port 68 --jump CHECKSUM > --checksum-fill' exited with non-zero status 2 and signal 0: iptables > v1.4.4: unknown option `--checksum-fill' > Try `iptables -h' or 'iptables --help' for more information. > > Just a FYI, in case someone wants to look into it. > > Regards and best wishes, > > Justin Clift > > -- > libvir-list mailing list > libvir-list(a)redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list

3 2

[libvirt] [PATCH] docs: added a table of contents to the first 11 docs files
by Justin Clift 27 Oct '10

27 Oct '10

There are a 58 docs files, so adding an autogeneratec Table Of Contents to them all will take some time. This is the first piece of the work done. --- docs/api.html.in | 17 +++-------------- docs/apps.html.in | 29 ++++++++++++++++++----------- docs/architecture.html.in | 42 +++++++++++++++++++----------------------- docs/archnetwork.html.in | 9 ++++++--- docs/auth.html.in | 41 ++++++++++++++--------------------------- docs/bugs.html.in | 12 ++++++++---- docs/contact.html.in | 6 ++++-- docs/deployment.html.in | 10 ++++++---- docs/devguide.html.in | 6 ++++-- docs/downloads.html.in | 18 ++++++++++-------- docs/drivers.html.in | 28 ++++++++++++++++++++++------ 11 files changed, 114 insertions(+), 104 deletions(-) diff --git a/docs/api.html.in b/docs/api.html.in index ad43fa3..e8bbeed 100644 --- a/docs/api.html.in +++ b/docs/api.html.in @@ -5,20 +5,9 @@ <p> This page describes the main principles and architecture choices behind the definition of the libvirt API: - <ul> - <li> - <a href="#Objects">Objects exposed</a> - </li> - <li> - <a href="#Functions">Functions and naming conventions</a> - </li> - <li> - <a href="#Driver">The drivers</a> - </li> - <li> - <a href="#Remote">Daemon and remote access</a> - </li> - </ul> + + <ul id="toc"></ul> + <h2><a name="Objects">Objects exposed</a></h2> <p> As defined in the <a href="goals.html">goals section</a>, libvirt API need to expose all the resources needed to manage the virtualization diff --git a/docs/apps.html.in b/docs/apps.html.in index 215c9b2..792c145 100644 --- a/docs/apps.html.in +++ b/docs/apps.html.in @@ -4,19 +4,26 @@ <p> This page provides an illustration of the wide variety of - applications using the libvirt management API. If you know - of interesting applications not listed on this page, send - a message to the <a href="contact.html">mailing list</a> - to request that it be added here. If your application uses - libvirt as its API, the following graphic is available for - your website to advertise support for libvirt: + applications using the libvirt management API. + </p> + + <ul id="toc"></ul> + + <h2><a name="add">Add an application</a></h2> + + <p> + To add an application not listed on this page, send a message + to the <a href="contact.html">mailing list</a>, requesting it + be added here. If your application uses libvirt as its API, + the following graphic is available for your website to advertise + support for libvirt: </p> <p class="image"> <img src="madeWith.png" alt="Made with libvirt"/> </p> - <h2>Command line tools</h2> + <h2><a name="command">Command line tools</a></h2> <dl> <dt>virsh</dt> @@ -60,7 +67,7 @@ </dd> </dl> - <h2>Desktop applications</h2> + <h2><a name="desktop">Desktop applications</a></h2> <dl> <dt><a href="http://virt-manager.org/">virt-manager</a></dt> @@ -79,7 +86,7 @@ </dd> </dl> - <h2>Web applications</h2> + <h2><a name="web">Web applications</a></h2> <dl> <dt><a href="http://ovirt.org/">oVirt</a></dt> @@ -99,7 +106,7 @@ </dd> </dl> - <h2>LiveCD / Appliances</h2> + <h2><a name="livecd">LiveCD / Appliances</a></h2> <dl> <dt><a href="http://et.redhat.com/~rjones/virt-p2v/">virt-p2v</a></dt> @@ -111,7 +118,7 @@ </dd> </dl> - <h2>Monitoring plugins</h2> + <h2><a name="monitoring">Monitoring plugins</a></h2> <dl> <dt><a href="http://honk.sigxcpu.org/projects/libvirt/#munin">for munin</a></dt> <dd> diff --git a/docs/architecture.html.in b/docs/architecture.html.in index a3e91a5..12d7e04 100644 --- a/docs/architecture.html.in +++ b/docs/architecture.html.in @@ -1,23 +1,19 @@ +<?xml version="1.0"?> <html> <body> <h1 >libvirt architecture</h1> - <p>Currently libvirt supports 2 kind of virtualization, and its -internal structure is based on a driver model which simplifies adding new -engines:</p> - <ul> - <li> - <a href="#Xen">Xen hypervisor</a> - </li> - <li> - <a href="#QEmu">QEmu and KVM based virtualization</a> - </li> - <li> - <a href="#drivers">the driver architecture</a> - </li> - </ul> - <h3> - <a name="Xen">Libvirt Xen support</a> - </h3> + + <p> + Currently libvirt supports 2 kind of virtualization, and its + internal structure is based on a driver model which simplifies + adding new + engines: + </p> + + <ul id="toc"></ul> + + <h2><a name="Xen">Xen support</a></h2> + <p>When running in a Xen environment, programs using libvirt have to execute in "Domain 0", which is the primary Linux OS loaded on the machine. That OS kernel provides most if not all of the actual drivers used by the set of @@ -48,9 +44,9 @@ privilege access).</p> connect to initialize the library. It will then fork a libvirt_proxy program running as root and providing read_only access to the API, this is then only useful for reporting and monitoring.</p> - <h3> - <a name="QEmu">Libvirt QEmu and KVM support</a> - </h3> + + <h2><a name="QEmu">QEmu and KVM support</a></h2> + <p>The model for QEmu and KVM is completely similar, basically KVM is based on QEmu for the process controlling a new domain, only small details differs between the two. In both case the libvirt API is provided by a controlling @@ -62,9 +58,9 @@ emulations models of QEmu, the selection is done when creating the new domain, by specifying the architecture and machine type targeted.</p> <p>The code controlling the QEmu process is available in the <code>qemud/</code> directory.</p> - <h3> - <a name="drivers">the driver based architecture</a> - </h3> + + <h2><a name="drivers">Driver based architecture</a></h2> + <p>As the previous section explains, libvirt can communicate using different channels with the current hypervisor, and should also be able to use different kind of hypervisor. To simplify the internal design, code, ease diff --git a/docs/archnetwork.html.in b/docs/archnetwork.html.in index 22e8697..57b8f3d 100644 --- a/docs/archnetwork.html.in +++ b/docs/archnetwork.html.in @@ -1,8 +1,11 @@ +<?xml version="1.0"?> <html> <body> <h1>Network management architecture</h1> - <h2>Architecture illustration</h2> + <ul id="toc"></ul> + + <h2><a name="architecture">Architecture illustration</a></h2> <p> The diagrams below illustrate some of the network configurations @@ -34,13 +37,13 @@ </li> </ul> - <h3>Logical diagram</h3> + <h3><a name="logical">Logical diagram</a></h3> <p class="image"> <img src="libvirt-net-logical.png" alt="Logical network architecture"/> </p> - <h3>Physical diagram</h3> + <h3><a name="physical">Physical diagram</a></h3> <p class="image"> <img src="libvirt-net-physical.png" alt="Physical network architecture"/> diff --git a/docs/auth.html.in b/docs/auth.html.in index 13731eb..2163959 100644 --- a/docs/auth.html.in +++ b/docs/auth.html.in @@ -1,30 +1,17 @@ +<?xml version="1.0"?> <html> <body> <h1 >Access control</h1> <p> -When connecting to libvirt, some connections may require client -authentication before allowing use of the APIs. The set of possible -authentication mechanisms is administrator controlled, independent -of applications using libvirt. -</p> - <ul> - <li> - <a href="#ACL_server_config">Server configuration</a> - </li> - <li> - <a href="#ACL_server_unix_perms">UNIX socket permissions/group</a> - </li> - <li> - <a href="#ACL_server_polkit">UNIX socket PolicyKit auth</a> - </li> - <li> - <a href="#ACL_server_username">Username/password auth</a> - </li> - <li> - <a href="#ACL_server_kerberos">Kerberos auth</a> - </li> - </ul> - <h3><a name="ACL_server_config">Server configuration</a></h3> + When connecting to libvirt, some connections may require client + authentication before allowing use of the APIs. The set of possible + authentication mechanisms is administrator controlled, independent + of applications using libvirt. + </p> + + <ul id="toc"></ul> + + <h2><a name="ACL_server_config">Server configuration</a></h2> <p> The libvirt daemon allows the administrator to choose the authentication mechanisms used for client connections on each network socket independently. @@ -35,7 +22,7 @@ currently a choice of <code>none</code>, <code>polkit</code>, and <code>sasl</co The SASL scheme can be further configured to choose between a large number of different mechanisms. </p> - <h3><a name="ACL_server_unix_perms">UNIX socket permissions/group</a></h3> + <h2><a name="ACL_server_unix_perms">UNIX socket permissions/group</a></h2> <p> If libvirt does not contain support for PolicyKit, then access control for the UNIX domain socket is done using traditional file user/group ownership @@ -52,7 +39,7 @@ parameter. For example, setting the former to mode <code>0770</code> and the latter <code>wheel</code> would let any user in the wheel group connect to the libvirt daemon. </p> - <h3><a name="ACL_server_polkit">UNIX socket PolicyKit auth</a></h3> + <h2><a name="ACL_server_polkit">UNIX socket PolicyKit auth</a></h2> <p> If libvirt contains support for PolicyKit, then access control options are more advanced. The <code>unix_sock_auth</code> parameter will default to @@ -86,7 +73,7 @@ ResultActive=yes</pre> Further examples of PolicyKit setup can be found on the <a href="http://wiki.libvirt.org/page/SSHPolicyKitSetup">wiki page</a>. </p> - <h3><a name="ACL_server_username">Username/password auth</a></h3> + <h2><a name="ACL_server_username">Username/password auth</a></h2> <p> The plain TCP socket of the libvirt daemon defaults to using SASL for authentication. The SASL mechanism configured by default is DIGEST-MD5, which provides a basic @@ -123,7 +110,7 @@ again: <pre> # saslpasswd2 -a libvirt -d fred </pre> - <h3><a name="ACL_server_kerberos">Kerberos auth</a></h3> + <h2><a name="ACL_server_kerberos">Kerberos auth</a></h2> <p> The plain TCP socket of the libvirt daemon defaults to using SASL for authentication. The SASL mechanism configured by default is DIGEST-MD5, which provides a basic diff --git a/docs/bugs.html.in b/docs/bugs.html.in index fa557a8..201705b 100644 --- a/docs/bugs.html.in +++ b/docs/bugs.html.in @@ -4,14 +4,18 @@ <h1>Bug reporting</h1> + <ul id="toc"></ul> + + <h2><a name="bugzilla">Bug Tracking</a></h2> + <p> The <a href="http://bugzilla.redhat.com">Red Hat Bugzilla Server</a> - should be used to report bugs and request features against libvirt. + should be used to report bugs and request features in libvirt. Before submitting a ticket, check the existing tickets to see if the bug/feature is already tracked. </p> - <h2>General libvirt bug reports</h2> + <h2><a name="general">General libvirt bug reports</a></h2> <p> If you are using official libvirt binaries from a Linux distribution @@ -27,7 +31,7 @@ <li><a href="http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Virtualization%20…">New libvirt ticket</a></li> </ul> - <h2>Linux Distribution specific bug reports</h2> + <h2><a name="distribution">Linux Distribution specific bug reports</a></h2> <ul> <li> If you are using official binaries from a <strong>Fedora distribution</strong>, enter @@ -54,7 +58,7 @@ </ul> - <h2>How to file high quality bug reports</h2> + <h2><a name="quality">How to file high quality bug reports</a></h2> <p> To increase the likelihood of your bug report being addressed it is diff --git a/docs/contact.html.in b/docs/contact.html.in index c9dceda..1a9f79a 100644 --- a/docs/contact.html.in +++ b/docs/contact.html.in @@ -3,7 +3,9 @@ <body> <h1>Contacting the development team</h1> - <h2>Mailing lists</h2> + <ul id="toc"></ul> + + <h2><a name="email">Mailing lists</a></h2> <p> There are two mailing-lists: @@ -45,7 +47,7 @@ clone. </p> - <h2>IRC discussion</h2> + <h2><a name="irc">IRC discussion</a></h2> <p> Some of the libvirt developers may be found on IRC on the <a href="http://oftc.net">OFTC IRC</a> diff --git a/docs/deployment.html.in b/docs/deployment.html.in index 94c480f..8ef383b 100644 --- a/docs/deployment.html.in +++ b/docs/deployment.html.in @@ -2,16 +2,18 @@ <body> <h1>Deployment</h1> - <h2>Pre-packaged releases</h2> + <ul id="toc"></ul> + + <h2><a name="packages">Pre-packaged releases</a></h2> <p> - The libvirt API is now available in all major Linux distributions + The libvirt API is now available in all major Linux distributions, so the simplest deployment approach is to use your distributions' package management software to install the <code>libvirt</code> module. </p> - <h2>Self-built releases</h2> + <h2><a name="tarball">Self-built releases</a></h2> <p> libvirt uses GNU autotools for its build system, so deployment @@ -25,7 +27,7 @@ # make install </pre> - <h2>Built from GIT</h2> + <h2><a name="git">Built from GIT</a></h2> <p> When building from GIT it is necessary to generate the autotools diff --git a/docs/devguide.html.in b/docs/devguide.html.in index 6c51c36..ba499db 100644 --- a/docs/devguide.html.in +++ b/docs/devguide.html.in @@ -3,6 +3,8 @@ <body> <h1>libvirt Application Development Guide</h1> + <ul id="toc"></ul> + <p> The guide is both a learning tool for developing with libvirt and an API reference document. It is a work in progress, composed by a @@ -16,7 +18,7 @@ contribution to the content here will do it. :) </p> - <h2>Browsable online</h2> + <h2><a name="online">Browsable online</a></h2> <ul> <li><a href="http://libvirt.org/guide/html/"> @@ -33,7 +35,7 @@ Source RPM format</a></li> </ul> - <h2>GIT source repository</h2> + <h2><a name="git">GIT source repository</a></h2> <p> The source is in a git repository: diff --git a/docs/downloads.html.in b/docs/downloads.html.in index 4b37d07..709bee8 100644 --- a/docs/downloads.html.in +++ b/docs/downloads.html.in @@ -3,7 +3,9 @@ <body> <h1>Downloads</h1> - <h2>Official Releases</h2> + <ul id="toc"></ul> + + <h2><a name="releases">Official Releases</a></h2> <p> The latest versions of the libvirt C library can be downloaded from: @@ -14,7 +16,7 @@ <li><a href="http://libvirt.org/sources/">libvirt.org HTTP server</a></li> </ul> - <h2>Hourly development snapshots</h2> + <h2><a name="hourly">Hourly development snapshots</a></h2> <p> Once an hour, an automated snapshot is made from the git server @@ -27,7 +29,7 @@ <li><a href="http://libvirt.org/sources/libvirt-git-snapshot.tar.gz">libvirt.org HTTP server</a></li> </ul> - <h2>GIT source repository</h2> + <h2><a name="git">GIT source repository</a></h2> <p> Libvirt code source is now maintained in a <a href="http://git-scm.com/">git</a> @@ -61,7 +63,7 @@ contribution to the content here will do it. :) </p> - <h2>Downloadable PDF</h2> + <h2><a name="appdevpdf">Application Development Guide PDF</a></h2> <p> PDF download is available here: @@ -71,7 +73,7 @@ <li><a href="http://libvirt.org/guide/pdf/Application_Development_Guide.pdf">libvirt App Dev Guide</a> (PDF)</li> </ul> - <h2>GIT source repository</h2> + <h2><a name="appdevgit">Application Development Guide source GIT repository</a></h2> <p> The source is also in a git repository: @@ -89,9 +91,9 @@ <br /> - <h1>libvirt Installation</h1> + <h1><a name="installation">libvirt Installation</a></h1> - <h2><a name="Compilatio">Compilation</a></h2> + <h2><a name="Compilatio">Compiling a release tarball</a></h2> <p> libvirt uses the standard configure/make/install steps: @@ -116,7 +118,7 @@ update your list of installed shared libs. </p> - <h2>Building from a source code checkout</h2> + <h2><a name="build">Building from a GIT checkout</a></h2> <p> The libvirt build process uses GNU autotools, so after obtaining a diff --git a/docs/drivers.html.in b/docs/drivers.html.in index 7e31434..b97200c 100644 --- a/docs/drivers.html.in +++ b/docs/drivers.html.in @@ -2,6 +2,8 @@ <body> <h1>Internal drivers</h1> + <ul id="toc"></ul> + <p> The libvirt public API delegates its implementation to one or more internal drivers, depending on the <a href="uri.html">connection URI</a> @@ -10,21 +12,35 @@ network and storage driver active. </p> - <h2>Hypervisor drivers</h2> + <h2><a name="hypervisor">Hypervisor drivers</a></h2> <p> The hypervisor drivers currently supported by libvirt are: </p> <ul> - <li><strong><a href="drvxen.html">Xen</a></strong></li> - <li><strong><a href="drvqemu.html">QEMU</a></strong></li> - <li><strong><a href="drvlxc.html">LXC</a></strong></li> - <li><strong><a href="drvtest.html">Test</a></strong></li> + <li><strong><a href="drvlxc.html">LXC</a></strong> - Linux Containers</li> + <li><strong><a href="drvone.html">OpenNebula</a></strong></li> <li><strong><a href="drvopenvz.html">OpenVZ</a></strong></li> + <li><strong><a href="drvqemu.html">QEMU</a></strong></li> + <li><strong><a href="drvtest.html">Test</a></strong> - Used for testing</li> + <li><strong><a href="drvuml.html">UML</a></strong> - User Mode Linux</li> <li><strong><a href="drvvbox.html">VirtualBox</a></strong></li> - <li><strong><a href="drvone.html">OpenNebula</a></strong></li> <li><strong><a href="drvesx.html">VMware ESX</a></strong></li> + <li><strong><a href="drvxen.html">Xen</a></strong></li> + </ul> + + <h2><a name="stroage">Storage drivers</a></h2> + + <ul> + <li><strong><a href="storage.html#StorageBackendDir">Directory backend</a></strong></li> + <li><strong><a href="storage.html#StorageBackendFS">Local filesystem backend</a></strong></li> + <li><strong><a href="storage.html#StorageBackendNetFS">Network filesystem backend</a></strong></li> + <li><strong><a href="storage.html#StorageBackendLogical">Logical Volume Manager (LVM) backend</a></strong></li> + <li><strong><a href="storage.html#StorageBackendDisk">Disk backend</a></strong></li> + <li><strong><a href="storage.html#StorageBackendISCSI">iSCSI backend</a></strong></li> + <li><strong><a href="storage.html#StorageBackendSCSI">SCSI backend</a></strong></li> + <li><strong><a href="storage.html#StorageBackendMultipath">Multipath backend</a></strong></li> </ul> </body> </html> -- 1.7.2.3

3 3

Re: [libvirt] How to start a defined domain
by 黄亮 27 Oct '10

27 Oct '10

nope. "vm01" can be seen after I started it using "xm create vm01". But, if I shut it down using "xm shutdown vm01", it can't be seen using "virsh list --all" I assume that, "vm01" only have a xm config file stored in /etc/xen/, and libvirt or virsh need a XML style config file. So I can't start vm01 using "virsh start vm01" nor can I see it using "virsh list --all". Is it like this? Do correct me if I'm wrong :-) 2010-10-27 黄亮发件人： Osier 发送时间： 2010-10-27 10:56:54 收件人：黄亮抄送：主题： Re: [libvirt] How to start a defined domain ----- "黄亮" <lancerhuang(a)163.com> wrote: > > Oh, yeah, you're right, it's "make uninstall" :-) > > after uninstall 0.8.4 and reinstall 0.6.3, it still won't work. > > but one thing I should mention is that while using "virsh start vm01", > it reports the same error, saying can't find domain "vm01" with > "xenUnifiedDomainLookupByName ". > So I think maybe there is something I'm missing in define a domain. > > Would you give me some hints so I can see where I go wrong? Really > appreciated > ah, well, so let us check lower, can you see the guest "vm01" by "virsh list --all"? - Osier > > 2010-10-27 > > 黄亮 > > 发件人： Osier > 发送时间： 2010-10-26 22:29:40 > 收件人：黄亮 > 抄送： libvir-list > 主题： Re: [libvirt] How to start a defined domain > > > > ----- "黄亮" <lancerhuang(a)163.com> wrote: > > > > > Well, after "make clean", I run the compiled start.c, still won't > > work. > > "make clean" won't uninstall the installed stuffs, use "make > uninstall" > instead, or you just made a typo? :-) > > after that, suggest re-installing 0.6.3 if you are not sure if it's > injured. > > - Osier > > > And I forget to metion, an error msg is shown: > > > > libvir: Xen error : Domain not found: xenUnifiedDomainLookupByName > > > > is that means I missed something? > > > > > > 2010-10-26 > > > > 黄亮 > > > > 发件人： Osier > > 发送时间： 2010-10-26 18:05:46 > > 收件人：黄亮 > > 抄送： > > 主题： Re: [libvirt] How to start a defined domain > > > > > > > > ----- "黄亮" <lancerhuang(a)163.com> wrote: > > > > > > > > Accroding to your case, it seems I have no need to upgrade libvirt > > to > > > 0.8.4 > > > Will that work if I erase 0.8.4 using "make clean" and draw back > to > > > 0.6.3 ? > > > > yep, think so, if you don't need the new features, and 0.6.3 is > enough > > for your project requirement.. :-) > > > > - Osier > > > > > > > > > > > > 2010-10-26 > > > > > > 黄亮 > > > > > > 发件人： Osier > > > 发送时间： 2010-10-26 17:10:40 > > > 收件人：黄亮 > > > 抄送： > > > 主题： Re: [libvirt] How to start a defined domain > > > > > > > > > > > > ----- "黄亮" <lancerhuang(a)163.com> wrote: > > > > > > > > > > > Thanks for your reply, Osier. > > > > > > > > > > > > The distro I'm using is CentOS release 5.5 (Final) > > > > > > > > I'm not quite sure about the version of libvirt. At first, it > > seems > > > to > > > > be 0.6.3, because /usr/lib64/libvirt.so.0 points to > > > > /usr/lib64/libvirt.so.0.6.3 > > > > Then I downloaded the src of libvirt_0.8.4 from offical website, > > and > > > > configure, make, make install. > > > > But now it show errors when I type "virsh". The error message > lies > > > > below: > > > > > > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.8.2' not > > > found > > > > (required by virsh) > > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.1' not > > > found > > > > (required by virsh) > > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.5' not > > > found > > > > (required by virsh) > > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.8.1' not > > > found > > > > (required by virsh) > > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.0' not > > > found > > > > (required by virsh) > > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.2' not > > > found > > > > (required by virsh) > > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.3' not > > > found > > > > (required by virsh) > > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.8.0' not > > > found > > > > (required by virsh) > > > > virsh: /usr/local/lib/libvirt.so.0: version > > `LIBVIRT_PRIVATE_0.8.4' > > > > not found (required by virsh) > > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.7' not > > > found > > > > (required by virsh) > > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.6.4' not > > > found > > > > (required by virsh) > > > > > > probly you should try to erase the 0.6.3, then compile and install > > > libvirt > > > like: > > > > > > # ./configure --prefix=/usr --libdir=/usr/lib64 > > > # make > > > # make install > > > > > > your test program has no problem on my box. the libvirt on my box > > also > > > is > > > 0.6.3. > > > > > > Regards > > > > > > - Osier > > > > > > > > As for xen, it is 3.3.2. The full "xm info" message is listed > > below: > > > > host : testbed01 > > > > release : 2.6.18-194.11.4.el5xen > > > > version : #1 SMP Tue Sep 21 05:40:24 EDT 2010 > > > > machine : x86_64 > > > > nr_cpus : 8 > > > > nr_nodes : 1 > > > > cores_per_socket : 4 > > > > threads_per_core : 2 > > > > cpu_mhz : 2793 > > > > hw_caps : > > > > > > > > > > bfebfbff:28100800:00000000:00000140:0098e3fd:00000000:00000001:00000000 > > > > virt_caps : hvm > > > > total_memory : 4055 > > > > free_memory : 533 > > > > node_to_cpu : node0:0-7 > > > > node_to_memory : node0:533 > > > > xen_major : 3 > > > > xen_minor : 3 > > > > xen_extra : .2 > > > > xen_caps : xen-3.0-x86_64 xen-3.0-x86_32p hvm-3.0-x86_32 > > > > hvm-3.0-x86_32p hvm-3.0-x86_64 > > > > xen_scheduler : credit > > > > xen_pagesize : 4096 > > > > platform_params : virt_start=0xffff800000000000 > > > > xen_changeset : unavailable > > > > cc_compiler : gcc version 4.1.2 20080704 (Red Hat 4.1.2-44) > > > > cc_compile_by : root > > > > cc_compile_domain : gitco.tld > > > > cc_compile_date : Tue Aug 18 21:07:28 CEST 2009 > > > > xend_config_format : 4 > > > > > > > > I've write a simple c program to test the api, and it is listed > > > below: > > > > > > > > 1 // This program aims to test the api which can start the VM > > > > 2 > > > > 3 #include "stdio.h" > > > > 4 #include "stdlib.h" > > > > 5 #include "libvirt/libvirt.h" > > > > 6 > > > > 7 int main(int argc ,char* argv[]) > > > > 8 { > > > > 9 virConnectPtr conn; > > > > 10 conn = virConnectOpen( "xen+tcp://localhost?no_Verify=1" ); > > > > 11 if( conn == NULL ) > > > > 12 { > > > > 13 printf( "Failed to Connect\n" ); > > > > 14 return 1; > > > > 15 } > > > > 16 const char* host = "vm01"; > > > > 17 virDomainPtr dom; > > > > 18 dom = virDomainLookupByName( conn, host ); > > > > 19 if( dom == NULL ) > > > > 20 { > > > > 21 printf( "can't find dom\n" ); > > > > 22 return 1; > > > > 23 } > > > > 24 // else > > > > 25 // { > > > > 26 // virDomainFree( dom ); > > > > 27 // virConnectClose( conn ); > > > > 28 // printf("done\n"); > > > > 29 // return 0; > > > > 30 // } > > > > 31 if( virDomainCreate( dom ) == -1 ) > > > > 32 { > > > > 33 printf( "failed to Start\n" ); > > > > 34 virDomainFree( dom ); > > > > 35 virConnectClose( conn ); > > > > 36 return 1; > > > > 37 } > > > > 38 else > > > > 39 { > > > > 40 printf( "Started\n" ); > > > > 41 virDomainFree( dom ); > > > > 42 virConnectClose( conn ); > > > > 43 return 0; > > > > 44 } > > > > 45 } > > > > > > > > 2010-10-26 > > > > > > > > Lancer > > > > > > > > 发件人： Osier > > > > 发送时间： 2010-10-26 11:35:31 > > > > 收件人：黄亮 > > > > 抄送： libvir-list > > > > 主题： Re: [libvirt] How to start a defined domain > > > > > > > > > > > > > > > > ----- "黄亮" <lancerhuang(a)163.com> wrote: > > > > > > > > > I've create a domain called "vm01" using Virt-Manager, the GUI > > > tool. > > > > > Now I wanna use libvirt api to control the life cycle of vm01. > > > > > It went on well with shutdown and reboot, but how to start it > > > became > > > > a > > > > > problem. > > > > > > > > > > I was intended to get the virDomainPtr by using > > > > virDomainLookupByName > > > > > api, and then start it using virDomainCreate api. > > > > > But it turns out that virDomainLookupByName api cannot return > a > > > > > virDomainPtr for a defined but not running domain. > > > > > > > > > > > > > no, it can :-) > > > > > > > > If it really doesn't work for you, could you write a simple > > program > > > to > > > > reproduce it? and try to explain what's the version of libvirt > you > > > > use, > > > > on which distro, etc, any helpful info is welcomed. :-) > > > > > > > > Thanks > > > > > > > > - Osier > > > > > > > > > That's my situation, what do you suggest I do now? > > > > > Thanks in advance. > > > > > > > > > > 2010-10-26 > > > > > > > > > > Lancer > > > > > -- > > > > > libvir-list mailing list > > > > > libvir-list(a)redhat.com > > > > > https://www.redhat.com/mailman/listinfo/libvir-list > > > > > > > > __________ Information from ESET Smart Security, version of > virus > > > > signature database 5562 (20101025) __________ > > > > > > > > The message was checked by ESET Smart Security. > > > > > > > > http://www.eset.com > > > > > > __________ Information from ESET Smart Security, version of virus > > > signature database 5562 (20101025) __________ > > > > > > The message was checked by ESET Smart Security. > > > > > > http://www.eset.com > > > > __________ Information from ESET Smart Security, version of virus > > signature database 5563 (20101026) __________ > > > > The message was checked by ESET Smart Security. > > > > http://www.eset.com > > __________ Information from ESET Smart Security, version of virus > signature database 5565 (20101026) __________ > > The message was checked by ESET Smart Security. > > http://www.eset.com __________ Information from ESET Smart Security, version of virus signature database 5566 (20101027) __________ The message was checked by ESET Smart Security. http://www.eset.com

1 0

[libvirt] [PATCH] docs: reformated the bindings page html markup to match other pages
by Justin Clift 27 Oct '10

27 Oct '10

--- Looks the same when processed, but the previous messy HTML got on my nerves while I was looking at other stuff. docs/bindings.html.in | 74 +++++++++++++++++++++++++++++++++--------------- 1 files changed, 51 insertions(+), 23 deletions(-) diff --git a/docs/bindings.html.in b/docs/bindings.html.in index bdcd231..0bc997e 100644 --- a/docs/bindings.html.in +++ b/docs/bindings.html.in @@ -1,31 +1,59 @@ +<?xml version="1.0"?> <html> <body> <h1 >Bindings for other languages</h1> - <p>Libvirt comes with bindings to support other languages than -pure <strong>C</strong>. First the headers embeds the necessary declarations to -allow direct access from <strong>C++</strong> code, but also we have bindings for -higher level kind of languages:</p> + + <p> + Libvirt comes with bindings to support other languages than + pure <strong>C</strong>. First the headers embeds the necessary + declarations to allow direct access from <strong>C++</strong> + code, but also we have bindings for higher level kind of languages: + </p> + <ul> - <li><strong>Python</strong>: Libvirt comes with direct support for the Python language - (just make sure you installed the libvirt-python package if not - compiling from sources). See below for more information about - using libvirt with python</li> - <li><strong>Perl</strong>: Daniel Berrange provides <a href="http://search.cpan.org/dist/Sys-Virt/">bindings for - Perl</a>.</li> - <li><strong>OCaml</strong>: Richard Jones supplies <a href="http://libvirt.org/ocaml/">bindings for OCaml</a>.</li> - <li><strong>Ruby</strong>: David Lutterkort provides <a href="http://libvirt.org/ruby/">bindings for Ruby</a>.</li> - <li><strong>Java</strong>: Daniel Veillard maintains <a href="java.html">Java bindings</a>.</li> - <li><strong>C#</strong>: Arnaud Champion maintains <a href="csharp.html">C# bindings</a>.</li> - <li><strong>PHP</strong>: Radek Hladik is developing <a href="http://phplibvirt.cybersales.cz/">PHP bindings</a>.</li> + <li> + <strong>Python</strong>: Libvirt comes with direct support for + the Python language (just make sure you installed the libvirt-python + package if not compiling from sources). See below for more + information about using libvirt with python + </li> + <li> + <strong>Perl</strong>: Daniel Berrange provides + <a href="http://search.cpan.org/dist/Sys-Virt/">bindings for Perl</a>. + </li> + <li> + <strong>OCaml</strong>: Richard Jones supplies + <a href="http://libvirt.org/ocaml/">bindings for OCaml</a>. + </li> + <li> + <strong>Ruby</strong>: David Lutterkort provides + <a href="http://libvirt.org/ruby/">bindings for Ruby</a>. + </li> + <li> + <strong>Java</strong>: Daniel Veillard maintains + <a href="java.html">Java bindings</a>. + </li> + <li> + <strong>C#</strong>: Arnaud Champion maintains + <a href="csharp.html">C# bindings</a>. + </li> + <li> + <strong>PHP</strong>: Radek Hladik is developing + <a href="http://phplibvirt.cybersales.cz/">PHP bindings</a>. + </li> </ul> - <p>For information on using libvirt on <strong>Windows</strong> - <a href="windows.html">please see the Windows - support page</a>. + + <p> + For information on using libvirt on <strong>Windows</strong> + <a href="windows.html">please see the Windows support page</a>. + </p> + + <p> + Support, requests or help for libvirt bindings are welcome on the + <a href="https://www.redhat.com/mailman/listinfo/libvir-list/">mailing list</a>, + as usual try to provide enough background information and make sure + you use recent version, see the <a href="bugs.html">help page</a>. </p> - <p>Support, requests or help for libvirt bindings are welcome on -the <a href="https://www.redhat.com/mailman/listinfo/libvir-list/">mailing -list</a>, as usual try to provide enough background information -and make sure you use recent version, see the <a href="bugs.html">help -page</a>.</p> + </body> </html> -- 1.7.2.3

2 3

Re: [libvirt] How to start a defined domain
by 黄亮 27 Oct '10

27 Oct '10

Oh, yeah, you're right, it's "make uninstall" :-) after uninstall 0.8.4 and reinstall 0.6.3, it still won't work. but one thing I should mention is that while using "virsh start vm01", it reports the same error, saying can't find domain "vm01" with "xenUnifiedDomainLookupByName ". So I think maybe there is something I'm missing in define a domain. Would you give me some hints so I can see where I go wrong? Really appreciated 2010-10-27 黄亮发件人： Osier 发送时间： 2010-10-26 22:29:40 收件人：黄亮抄送： libvir-list 主题： Re: [libvirt] How to start a defined domain ----- "黄亮" <lancerhuang(a)163.com> wrote: > > Well, after "make clean", I run the compiled start.c, still won't > work. "make clean" won't uninstall the installed stuffs, use "make uninstall" instead, or you just made a typo? :-) after that, suggest re-installing 0.6.3 if you are not sure if it's injured. - Osier > And I forget to metion, an error msg is shown: > > libvir: Xen error : Domain not found: xenUnifiedDomainLookupByName > > is that means I missed something? > > > 2010-10-26 > > 黄亮 > > 发件人： Osier > 发送时间： 2010-10-26 18:05:46 > 收件人：黄亮 > 抄送： > 主题： Re: [libvirt] How to start a defined domain > > > > ----- "黄亮" <lancerhuang(a)163.com> wrote: > > > > > Accroding to your case, it seems I have no need to upgrade libvirt > to > > 0.8.4 > > Will that work if I erase 0.8.4 using "make clean" and draw back to > > 0.6.3 ? > > yep, think so, if you don't need the new features, and 0.6.3 is enough > for your project requirement.. :-) > > - Osier > > > > > > > > 2010-10-26 > > > > 黄亮 > > > > 发件人： Osier > > 发送时间： 2010-10-26 17:10:40 > > 收件人：黄亮 > > 抄送： > > 主题： Re: [libvirt] How to start a defined domain > > > > > > > > ----- "黄亮" <lancerhuang(a)163.com> wrote: > > > > > > > > Thanks for your reply, Osier. > > > > > > > > > The distro I'm using is CentOS release 5.5 (Final) > > > > > > I'm not quite sure about the version of libvirt. At first, it > seems > > to > > > be 0.6.3, because /usr/lib64/libvirt.so.0 points to > > > /usr/lib64/libvirt.so.0.6.3 > > > Then I downloaded the src of libvirt_0.8.4 from offical website, > and > > > configure, make, make install. > > > But now it show errors when I type "virsh". The error message lies > > > below: > > > > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.8.2' not > > found > > > (required by virsh) > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.1' not > > found > > > (required by virsh) > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.5' not > > found > > > (required by virsh) > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.8.1' not > > found > > > (required by virsh) > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.0' not > > found > > > (required by virsh) > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.2' not > > found > > > (required by virsh) > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.3' not > > found > > > (required by virsh) > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.8.0' not > > found > > > (required by virsh) > > > virsh: /usr/local/lib/libvirt.so.0: version > `LIBVIRT_PRIVATE_0.8.4' > > > not found (required by virsh) > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.7' not > > found > > > (required by virsh) > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.6.4' not > > found > > > (required by virsh) > > > > probly you should try to erase the 0.6.3, then compile and install > > libvirt > > like: > > > > # ./configure --prefix=/usr --libdir=/usr/lib64 > > # make > > # make install > > > > your test program has no problem on my box. the libvirt on my box > also > > is > > 0.6.3. > > > > Regards > > > > - Osier > > > > > > As for xen, it is 3.3.2. The full "xm info" message is listed > below: > > > host : testbed01 > > > release : 2.6.18-194.11.4.el5xen > > > version : #1 SMP Tue Sep 21 05:40:24 EDT 2010 > > > machine : x86_64 > > > nr_cpus : 8 > > > nr_nodes : 1 > > > cores_per_socket : 4 > > > threads_per_core : 2 > > > cpu_mhz : 2793 > > > hw_caps : > > > > > > bfebfbff:28100800:00000000:00000140:0098e3fd:00000000:00000001:00000000 > > > virt_caps : hvm > > > total_memory : 4055 > > > free_memory : 533 > > > node_to_cpu : node0:0-7 > > > node_to_memory : node0:533 > > > xen_major : 3 > > > xen_minor : 3 > > > xen_extra : .2 > > > xen_caps : xen-3.0-x86_64 xen-3.0-x86_32p hvm-3.0-x86_32 > > > hvm-3.0-x86_32p hvm-3.0-x86_64 > > > xen_scheduler : credit > > > xen_pagesize : 4096 > > > platform_params : virt_start=0xffff800000000000 > > > xen_changeset : unavailable > > > cc_compiler : gcc version 4.1.2 20080704 (Red Hat 4.1.2-44) > > > cc_compile_by : root > > > cc_compile_domain : gitco.tld > > > cc_compile_date : Tue Aug 18 21:07:28 CEST 2009 > > > xend_config_format : 4 > > > > > > I've write a simple c program to test the api, and it is listed > > below: > > > > > > 1 // This program aims to test the api which can start the VM > > > 2 > > > 3 #include "stdio.h" > > > 4 #include "stdlib.h" > > > 5 #include "libvirt/libvirt.h" > > > 6 > > > 7 int main(int argc ,char* argv[]) > > > 8 { > > > 9 virConnectPtr conn; > > > 10 conn = virConnectOpen( "xen+tcp://localhost?no_Verify=1" ); > > > 11 if( conn == NULL ) > > > 12 { > > > 13 printf( "Failed to Connect\n" ); > > > 14 return 1; > > > 15 } > > > 16 const char* host = "vm01"; > > > 17 virDomainPtr dom; > > > 18 dom = virDomainLookupByName( conn, host ); > > > 19 if( dom == NULL ) > > > 20 { > > > 21 printf( "can't find dom\n" ); > > > 22 return 1; > > > 23 } > > > 24 // else > > > 25 // { > > > 26 // virDomainFree( dom ); > > > 27 // virConnectClose( conn ); > > > 28 // printf("done\n"); > > > 29 // return 0; > > > 30 // } > > > 31 if( virDomainCreate( dom ) == -1 ) > > > 32 { > > > 33 printf( "failed to Start\n" ); > > > 34 virDomainFree( dom ); > > > 35 virConnectClose( conn ); > > > 36 return 1; > > > 37 } > > > 38 else > > > 39 { > > > 40 printf( "Started\n" ); > > > 41 virDomainFree( dom ); > > > 42 virConnectClose( conn ); > > > 43 return 0; > > > 44 } > > > 45 } > > > > > > 2010-10-26 > > > > > > Lancer > > > > > > 发件人： Osier > > > 发送时间： 2010-10-26 11:35:31 > > > 收件人：黄亮 > > > 抄送： libvir-list > > > 主题： Re: [libvirt] How to start a defined domain > > > > > > > > > > > > ----- "黄亮" <lancerhuang(a)163.com> wrote: > > > > > > > I've create a domain called "vm01" using Virt-Manager, the GUI > > tool. > > > > Now I wanna use libvirt api to control the life cycle of vm01. > > > > It went on well with shutdown and reboot, but how to start it > > became > > > a > > > > problem. > > > > > > > > I was intended to get the virDomainPtr by using > > > virDomainLookupByName > > > > api, and then start it using virDomainCreate api. > > > > But it turns out that virDomainLookupByName api cannot return a > > > > virDomainPtr for a defined but not running domain. > > > > > > > > > > no, it can :-) > > > > > > If it really doesn't work for you, could you write a simple > program > > to > > > reproduce it? and try to explain what's the version of libvirt you > > > use, > > > on which distro, etc, any helpful info is welcomed. :-) > > > > > > Thanks > > > > > > - Osier > > > > > > > That's my situation, what do you suggest I do now? > > > > Thanks in advance. > > > > > > > > 2010-10-26 > > > > > > > > Lancer > > > > -- > > > > libvir-list mailing list > > > > libvir-list(a)redhat.com > > > > https://www.redhat.com/mailman/listinfo/libvir-list > > > > > > __________ Information from ESET Smart Security, version of virus > > > signature database 5562 (20101025) __________ > > > > > > The message was checked by ESET Smart Security. > > > > > > http://www.eset.com > > > > __________ Information from ESET Smart Security, version of virus > > signature database 5562 (20101025) __________ > > > > The message was checked by ESET Smart Security. > > > > http://www.eset.com > > __________ Information from ESET Smart Security, version of virus > signature database 5563 (20101026) __________ > > The message was checked by ESET Smart Security. > > http://www.eset.com __________ Information from ESET Smart Security, version of virus signature database 5565 (20101026) __________ The message was checked by ESET Smart Security. http://www.eset.com

1 0

[libvirt] [PATCH] virsh: use - not _ in memtune option names
by Eric Blake 26 Oct '10

26 Oct '10

* tools/virsh.c (opts_memtune): All other options in virsh use - for separating words. --- tools/virsh.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index cafd304..b616eef 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -2890,13 +2890,13 @@ static const vshCmdInfo info_memtune[] = { static const vshCmdOptDef opts_memtune[] = { {"domain", VSH_OT_DATA, VSH_OFLAG_REQ, N_("domain name, id or uuid")}, - {VIR_DOMAIN_MEMORY_HARD_LIMIT, VSH_OT_INT, VSH_OFLAG_NONE, + {"hard-limit", VSH_OT_INT, VSH_OFLAG_NONE, N_("Max memory in kilobytes")}, - {VIR_DOMAIN_MEMORY_SOFT_LIMIT, VSH_OT_INT, VSH_OFLAG_NONE, + {"soft-limit", VSH_OT_INT, VSH_OFLAG_NONE, N_("Memory during contention in kilobytes")}, - {VIR_DOMAIN_MEMORY_SWAP_HARD_LIMIT, VSH_OT_INT, VSH_OFLAG_NONE, + {"swap-hard-limit", VSH_OT_INT, VSH_OFLAG_NONE, N_("Max swap in kilobytes")}, - {VIR_DOMAIN_MEMORY_MIN_GUARANTEE, VSH_OT_INT, VSH_OFLAG_NONE, + {"min-guarantee", VSH_OT_INT, VSH_OFLAG_NONE, N_("Min guaranteed memory in kilobytes")}, {NULL, 0, 0, NULL} }; -- 1.7.2.3

2 5

[libvirt] [PATCH] build: silence configure warning if ksh is missing
by Eric Blake 26 Oct '10

26 Oct '10

* configure.ac (lv_cv_wrapper_shell): Fix logic error if candidate shell is not available. Reported by Matthias Bolte. --- On IRC, Matthias reported a noisy configure run: eblake: checking for shell that supports <> redirection... ./configure: line 31581: ksh: command not found Worse, if a shell is missing, it doesn't change the contents of conftest.a, so that missing shell would be selected in the loop. This patch fixes both the noise and the wrong selection. configure.ac | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 86a864b..7e7f295 100644 --- a/configure.ac +++ b/configure.ac @@ -616,7 +616,7 @@ if test "$with_qemu" = yes; then test $lv_cv_wrapper_shell = none && AC_MSG_ERROR([could not find decent shell]) echo a > conftest.a - $lv_cv_wrapper_shell -c ': 1<>conftest.a' + ($lv_cv_wrapper_shell -c ': 1<>conftest.a') 2>/dev/null && case `cat conftest.a`.$lv_cv_wrapper_shell in a./*) break;; dnl /bin/sh is good enough a.*) dnl bash, ksh, and zsh all understand 'command', use that -- 1.7.2.3

2 4

[libvirt] [PATCH] maint: fix syntax-check failure of previous patch
by Eric Blake 26 Oct '10

26 Oct '10

* cfg.mk (sc_prohibit_trailing_blank_lines): Delete; this is adequately covered by maint.mk's sc_prohibit_empty_lines_at_EOF. * .x-sc_prohibit_empty_lines_at_EOF: New file, to exempt raw patches. * Makefile.am (EXTRA_DIST): Include new exemption. --- I'm pushing this under the build-breaker rule, since my previous patch made 'make syntax-check' fail for not one, but two identical syntax checks. .x-sc_prohibit_empty_lines_at_EOF | 1 + Makefile.am | 1 + cfg.mk | 9 --------- 3 files changed, 2 insertions(+), 9 deletions(-) create mode 100644 .x-sc_prohibit_empty_lines_at_EOF diff --git a/.x-sc_prohibit_empty_lines_at_EOF b/.x-sc_prohibit_empty_lines_at_EOF new file mode 100644 index 0000000..f481a09 --- /dev/null +++ b/.x-sc_prohibit_empty_lines_at_EOF @@ -0,0 +1 @@ +^docs/api_extension/.* diff --git a/Makefile.am b/Makefile.am index b51bd2b..26c6488 100644 --- a/Makefile.am +++ b/Makefile.am @@ -25,6 +25,7 @@ EXTRA_DIST = \ .x-sc_avoid_write \ .x-sc_m4_quote_check \ .x-sc_prohibit_asprintf \ + .x-sc_prohibit_empty_lines_at_EOF \ .x-sc_prohibit_gethostby \ .x-sc_prohibit_gethostname \ .x-sc_prohibit_gettext_noop \ diff --git a/cfg.mk b/cfg.mk index d50ffb7..d238a5f 100644 --- a/cfg.mk +++ b/cfg.mk @@ -406,15 +406,6 @@ sc_prohibit_newline_at_end_of_diagnostic: && { echo '$(ME): newline at end of message(s)' 1>&2; \ exit 1; } || : -# Disallow trailing blank lines. -sc_prohibit_trailing_blank_lines: - @$(VC_LIST_EXCEPT) | xargs perl -ln -0777 -e \ - '/\n\n+$$/ and print $$ARGV' > $@-t - @found=0; test -s $@-t && { found=1; cat $@-t 1>&2; \ - echo '$(ME): found trailing blank line(s)' 1>&2; }; \ - rm -f $@-t; \ - test $$found = 0 - # Regex for grep -E that exempts generated files from style rules. preprocessor_exempt = ((qemu|remote)_(driver|protocol)\.h)$$ # Enforce recommended preprocessor indentation style. -- 1.7.2.3

1 0

[libvirt] [PATCH] qemu: Fix detection of drive readonly option
by Jiri Denemark 26 Oct '10

26 Oct '10

So far, readonly=on option is used when qemu supports -device. However, there are qemu versions which support readonly option with -drive although they don't have support for -device. --- src/qemu/qemu_conf.c | 12 ++- src/qemu/qemu_conf.h | 1 + tests/qemuhelpdata/kvm-83-rhel56 | 141 ++++++++++++++++++++ tests/qemuhelptest.c | 26 ++++ ...qemuxml2argv-disk-drive-readonly-no-device.args | 1 + .../qemuxml2argv-disk-drive-readonly-no-device.xml | 31 +++++ tests/qemuxml2argvtest.c | 5 +- 7 files changed, 214 insertions(+), 3 deletions(-) create mode 100644 tests/qemuhelpdata/kvm-83-rhel56 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-readonly-no-device.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-readonly-no-device.xml diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index e2c67a3..00e89a1 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -1187,6 +1187,8 @@ static unsigned long long qemudComputeCmdFlags(const char *help, flags |= QEMUD_CMD_FLAG_DRIVE_CACHE_V2; if (strstr(help, "format=")) flags |= QEMUD_CMD_FLAG_DRIVE_FORMAT; + if (strstr(help, "readonly=")) + flags |= QEMUD_CMD_FLAG_DRIVE_READONLY; } if (strstr(help, "-vga") && !strstr(help, "-std-vga")) flags |= QEMUD_CMD_FLAG_VGA; @@ -1202,8 +1204,14 @@ static unsigned long long qemudComputeCmdFlags(const char *help, flags |= QEMUD_CMD_FLAG_CHARDEV; if (strstr(help, "-balloon")) flags |= QEMUD_CMD_FLAG_BALLOON; - if (strstr(help, "-device")) + if (strstr(help, "-device")) { flags |= QEMUD_CMD_FLAG_DEVICE; + /* + * When -device was introduced, qemu already supported drive's + * readonly option but didn't advertise that. + */ + flags |= QEMUD_CMD_FLAG_DRIVE_READONLY; + } if (strstr(help, "-nodefconfig")) flags |= QEMUD_CMD_FLAG_NODEFCONFIG; /* The trailing ' ' is important to avoid a bogus match */ @@ -2688,7 +2696,7 @@ qemuBuildDriveStr(virDomainDiskDefPtr disk, disk->bus != VIR_DOMAIN_DISK_BUS_IDE) virBufferAddLit(&opt, ",boot=on"); if (disk->readonly && - qemuCmdFlags & QEMUD_CMD_FLAG_DEVICE) + qemuCmdFlags & QEMUD_CMD_FLAG_DRIVE_READONLY) virBufferAddLit(&opt, ",readonly=on"); if (disk->driverType && *disk->driverType != '\0' && disk->type != VIR_DOMAIN_DISK_TYPE_DIR && diff --git a/src/qemu/qemu_conf.h b/src/qemu/qemu_conf.h index 005031d..530dcdb 100644 --- a/src/qemu/qemu_conf.h +++ b/src/qemu/qemu_conf.h @@ -96,6 +96,7 @@ enum qemud_cmd_flags { QEMUD_CMD_FLAG_FSDEV = (1LL << 40), /* -fstype filesystem passthrough */ QEMUD_CMD_FLAG_NESTING = (1LL << 41), /* -enable-nesting (SVM/VMX) */ QEMUD_CMD_FLAG_NAME_PROCESS = (1LL << 42), /* Is -name process= available */ + QEMUD_CMD_FLAG_DRIVE_READONLY = (1LL << 43), /* -drive readonly=on|off */ }; /* Main driver state */ diff --git a/tests/qemuhelpdata/kvm-83-rhel56 b/tests/qemuhelpdata/kvm-83-rhel56 new file mode 100644 index 0000000..b2cefa9 --- /dev/null +++ b/tests/qemuhelpdata/kvm-83-rhel56 @@ -0,0 +1,141 @@ +QEMU PC emulator version 0.9.1 (kvm-83-maint-snapshot-20090205), Copyright (c) 2003-2008 Fabrice Bellard +usage: qemu [options] [disk_image] + +'disk_image' is a raw hard image image for IDE hard disk 0 + +Standard options: +-M machine select emulated machine (-M ? for list) +-cpu cpu select CPU (-cpu ? for list) +-fda/-fdb file use 'file' as floppy disk 0/1 image +-hda/-hdb file use 'file' as IDE hard disk 0/1 image +-hdc/-hdd file use 'file' as IDE hard disk 2/3 image +-cdrom file use 'file' as IDE cdrom image (cdrom is ide1 master) +-drive [file=file][,if=type][,bus=n][,unit=m][,media=d][,index=i] + [,cyls=c,heads=h,secs=s[,trans=t]][,snapshot=on|off] + [,cache=writethrough|writeback|none|unsafe][,format=f][,serial=s] + [,boot=on|off][,readonly=on|off] + use 'file' as a drive image +-mtdblock file use 'file' as on-board Flash memory image +-sd file use 'file' as SecureDigital card image +-pflash file use 'file' as a parallel flash image +-boot [a|c|d|n] boot on floppy (a), hard disk (c), CD-ROM (d), or network (n) +-snapshot write to temporary files instead of disk image files +-no-frame open SDL window without a frame and window decorations +-alt-grab use Ctrl-Alt-Shift to grab mouse (instead of Ctrl-Alt) +-no-quit disable SDL window close capability +-no-fd-bootchk disable boot signature checking for floppy disks +-m megs set virtual RAM size to megs MB [default=128] +-smp n set the number of CPUs to 'n' [default=1] +-nographic disable graphical output and redirect serial I/Os to console +-portrait rotate graphical output 90 deg left (only PXA LCD) +-k language use keyboard layout (for example "fr" for French) +-audio-help print list of audio drivers and their options +-soundhw c1,... enable audio support + and only specified sound cards (comma separated list) + use -soundhw ? to get the list of supported cards + use -soundhw all to enable all of them +-vga [std|cirrus] + select video card type +-localtime set the real time clock to local time [default=utc] +-full-screen start in full screen +-win2k-hack use it when installing Windows 2000 to avoid a disk full bug +-rtc-td-hack use it to fix time drift in Windows ACPI HAL +-usb enable the USB driver (will be the default soon) +-usbdevice name add the host or guest USB device 'name' +-name string set the name of the guest +-uuid %08x-%04x-%04x-%04x-%012x specify machine UUID +-notify event enable async-notifications for event +-qxl <num>[,ram=megs] + use 'num' qxl display devices, each with RAM size of 'megs' MB + [default=64] +-spice <args> use spice +-spice-help show spice usage + +Network options: +-net nic[,vlan=n][,macaddr=addr][,model=type][,name=str] + create a new Network Interface Card and connect it to VLAN 'n' +-net user[,vlan=n][,name=str][,hostname=host] + connect the user mode network stack to VLAN 'n' and send + hostname 'host' to DHCP clients +-net tap[,vlan=n][,name=str][,fd=h][,ifname=name][,script=file][,downscript=dfile] + connect the host TAP network interface to VLAN 'n' and use the + network scripts 'file' (default=/etc/qemu-ifup) + and 'dfile' (default=/etc/qemu-ifdown); + use '[down]script=no' to disable script execution; + use 'fd=h' to connect to an already opened TAP interface +-net socket[,vlan=n][,name=str][,fd=h][,listen=[host]:port][,connect=host:port] + connect the vlan 'n' to another VLAN using a socket connection +-net socket[,vlan=n][,name=str][,fd=h][,mcast=maddr:port] + connect the vlan 'n' to multicast maddr and port +-net none use it alone to have zero network devices; if no -net option + is provided, the default is '-net nic -net user' + +-tftp dir allow tftp access to files in dir [-net user] +-bootp file advertise file in BOOTP replies +-redir [tcp|udp]:host-port:[guest-host]:guest-port + redirect TCP or UDP connections from host to guest [-net user] + +Linux boot specific: +-kernel bzImage use 'bzImage' as kernel image +-append cmdline use 'cmdline' as kernel command line +-initrd file use 'file' as initial ram disk + +Debug/Expert options: +-monitor dev redirect the monitor to char device 'dev' +-vmchannel di:DI,dev redirect the hypercall device with device id DI, to char device 'dev' +-serial dev redirect the serial port to char device 'dev' +-parallel dev redirect the parallel port to char device 'dev' +-pidfile file Write PID to 'file' +-S freeze CPU at startup (use 'c' to start execution) +-s wait gdb connection to port +-p port set gdb connection port [default=1234] +-d item1,... output log to /tmp/qemu.log (use -d ? for a list of log items) +-hdachs c,h,s[,t] force hard disk 0 physical geometry and the optional BIOS + translation (t=none or lba) (usually qemu can guess them) +-L path set the directory for the BIOS, VGA BIOS and keymaps +-no-kvm disable KVM hardware virtualization +-no-kvm-irqchip disable KVM kernel mode PIC/IOAPIC/LAPIC +-no-kvm-pit disable KVM kernel mode PIT +-no-kvm-pit-reinjection disable KVM kernel mode PIT interrupt reinjection +-pcidevice host=bus:dev.func[,dma=none][,name=string] + expose a PCI device to the guest OS. + dma=none: don't perform any dma translations (default is to use an iommu) + 'string' is used in log output. +-no-acpi disable ACPI +-no-hpet disable HPET +-balloon none disable balloon device +-balloon virtio + enable virtio balloon device (default) +-acpitable [sig=str][,rev=n][,oem_id=str][,oem_table_id=str][,oem_rev=n][,asl_compiler_id=str][,asl_compiler_rev=n][,data=file1[:file2]...] + ACPI table description +-smbios file=binary + Load SMBIOS entry from binary file +-smbios type=0[,vendor=str][,version=str][,date=str][,release=%d.%d] + Specify SMBIOS type 0 fields +-smbios type=1[,manufacturer=str][,product=str][,version=str][,serial=str] + [,uuid=uuid][,sku=str][,family=str] + Specify SMBIOS type 1 fields +-no-reboot exit instead of rebooting +-no-shutdown stop before shutdown +-loadvm [tag|id] start right away with a saved state (loadvm in monitor) +-vnc display start a VNC server on display +-daemonize daemonize QEMU after initializing +-tdf inject timer interrupts that got lost +-kvm-shadow-memory megs set the amount of shadow pages to be allocated +-mem-path set the path to hugetlbfs/tmpfs mounted directory, also + enables allocation of guest memory with huge pages +-mem-prealloc toggles preallocation of -mem-path backed physical memory + at startup. Default is enabled. +-option-rom rom load a file, rom, into the option ROM space +-clock force the use of the given methods for timer alarm. + To see what timers are available use -clock ? +-startdate select initial date of the clock +-icount [N|auto] + Enable virtual instruction counter with 2^N clock ticks per instruction + +During emulation, the following keys are useful: +ctrl-alt-f toggle full screen +ctrl-alt-n switch to virtual console 'n' +ctrl-alt toggle mouse and keyboard grab + +When using -nographic, press 'ctrl-a h' to get some help. diff --git a/tests/qemuhelptest.c b/tests/qemuhelptest.c index d4453db..97531ff 100644 --- a/tests/qemuhelptest.c +++ b/tests/qemuhelptest.c @@ -130,6 +130,30 @@ mymain(int argc, char **argv) QEMUD_CMD_FLAG_MEM_PATH | QEMUD_CMD_FLAG_TDF, 9001, 1, 74); + DO_TEST("kvm-83-rhel56", + QEMUD_CMD_FLAG_VNC_COLON | + QEMUD_CMD_FLAG_NO_REBOOT | + QEMUD_CMD_FLAG_DRIVE | + QEMUD_CMD_FLAG_DRIVE_BOOT | + QEMUD_CMD_FLAG_NAME | + QEMUD_CMD_FLAG_UUID | + QEMUD_CMD_FLAG_VNET_HDR | + QEMUD_CMD_FLAG_MIGRATE_QEMU_TCP | + QEMUD_CMD_FLAG_MIGRATE_QEMU_EXEC | + QEMUD_CMD_FLAG_DRIVE_CACHE_V2 | + QEMUD_CMD_FLAG_KVM | + QEMUD_CMD_FLAG_DRIVE_FORMAT | + QEMUD_CMD_FLAG_DRIVE_SERIAL | + QEMUD_CMD_FLAG_VGA | + QEMUD_CMD_FLAG_PCIDEVICE | + QEMUD_CMD_FLAG_MEM_PATH | + QEMUD_CMD_FLAG_BALLOON | + QEMUD_CMD_FLAG_RTC_TD_HACK | + QEMUD_CMD_FLAG_NO_HPET | + QEMUD_CMD_FLAG_NO_KVM_PIT | + QEMUD_CMD_FLAG_TDF | + QEMUD_CMD_FLAG_DRIVE_READONLY, + 9001, 1, 83); DO_TEST("qemu-0.10.5", QEMUD_CMD_FLAG_KQEMU | QEMUD_CMD_FLAG_VNC_COLON | @@ -238,6 +262,7 @@ mymain(int argc, char **argv) QEMUD_CMD_FLAG_DRIVE_CACHE_V2 | QEMUD_CMD_FLAG_DRIVE_FORMAT | QEMUD_CMD_FLAG_DRIVE_SERIAL | + QEMUD_CMD_FLAG_DRIVE_READONLY | QEMUD_CMD_FLAG_VGA | QEMUD_CMD_FLAG_0_10 | QEMUD_CMD_FLAG_ENABLE_KVM | @@ -267,6 +292,7 @@ mymain(int argc, char **argv) QEMUD_CMD_FLAG_KVM | QEMUD_CMD_FLAG_DRIVE_FORMAT | QEMUD_CMD_FLAG_DRIVE_SERIAL | + QEMUD_CMD_FLAG_DRIVE_READONLY | QEMUD_CMD_FLAG_VGA | QEMUD_CMD_FLAG_0_10 | QEMUD_CMD_FLAG_PCIDEVICE | diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-readonly-no-device.args b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-readonly-no-device.args new file mode 100644 index 0000000..fb99a7c --- /dev/null +++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-readonly-no-device.args @@ -0,0 +1 @@ +LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test /usr/bin/qemu -S -M pc -m 214 -smp 1 -nographic -monitor unix:/tmp/test-monitor,server,nowait -no-acpi -boot c -drive file=/dev/HostVG/QEMUGuest1,if=ide,bus=0,unit=0 -drive file=/dev/sr0,if=ide,media=cdrom,bus=1,unit=0,readonly=on -net none -serial none -parallel none -usb diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-readonly-no-device.xml b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-readonly-no-device.xml new file mode 100644 index 0000000..1f193c9 --- /dev/null +++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-readonly-no-device.xml @@ -0,0 +1,31 @@ +<domain type='qemu'> + <name>QEMUGuest1</name> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> + <memory>219200</memory> + <currentMemory>219200</currentMemory> + <vcpu>1</vcpu> + <os> + <type arch='i686' machine='pc'>hvm</type> + <boot dev='hd'/> + </os> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <emulator>/usr/bin/qemu</emulator> + <disk type='block' device='disk'> + <source dev='/dev/HostVG/QEMUGuest1'/> + <target dev='hda' bus='ide'/> + <address type='drive' controller='0' bus='0' unit='0'/> + </disk> + <disk type='block' device='cdrom'> + <source dev='/dev/sr0'/> + <target dev='hdc' bus='ide'/> + <readonly/> + <address type='drive' controller='0' bus='1' unit='0'/> + </disk> + <controller type='ide' index='0'/> + <memballoon model='virtio'/> + </devices> +</domain> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 4eb3cc6..f719f12 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -276,7 +276,10 @@ mymain(int argc, char **argv) DO_TEST("disk-drive-fat", QEMUD_CMD_FLAG_DRIVE | QEMUD_CMD_FLAG_DRIVE_BOOT | QEMUD_CMD_FLAG_DRIVE_FORMAT, false); DO_TEST("disk-drive-readonly-disk", QEMUD_CMD_FLAG_DRIVE | - QEMUD_CMD_FLAG_DEVICE | QEMUD_CMD_FLAG_NODEFCONFIG, false); + QEMUD_CMD_FLAG_DRIVE_READONLY | QEMUD_CMD_FLAG_DEVICE | + QEMUD_CMD_FLAG_NODEFCONFIG, false); + DO_TEST("disk-drive-readonly-no-device", QEMUD_CMD_FLAG_DRIVE | + QEMUD_CMD_FLAG_DRIVE_READONLY | QEMUD_CMD_FLAG_NODEFCONFIG, false); DO_TEST("disk-drive-fmt-qcow", QEMUD_CMD_FLAG_DRIVE | QEMUD_CMD_FLAG_DRIVE_BOOT | QEMUD_CMD_FLAG_DRIVE_FORMAT, false); DO_TEST("disk-drive-shared", QEMUD_CMD_FLAG_DRIVE | -- 1.7.3.2

4 6

[libvirt] [PATCH] Don't use %.3d format for bus/addr of USB devices.
by Diego Elio Pettenò 26 Oct '10

26 Oct '10

When using 0-prefixed numbers, QEmu will interpret them as octal numbers (as C convention says); this means that if you attach a device that has addr > 10 (decimal) you're going to attach a different device. --- src/qemu/qemu_conf.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 00e89a1..5bd3d4c 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -3266,7 +3266,7 @@ qemuBuildUSBHostdevDevStr(virDomainHostdevDefPtr dev) return NULL; } - if (virAsprintf(&ret, "usb-host,hostbus=%.3d,hostaddr=%.3d,id=%s", + if (virAsprintf(&ret, "usb-host,hostbus=%d,hostaddr=%d,id=%s", dev->source.subsys.u.usb.bus, dev->source.subsys.u.usb.device, dev->info.alias) < 0) @@ -3288,7 +3288,7 @@ qemuBuildUSBHostdevUsbDevStr(virDomainHostdevDefPtr dev) return NULL; } - if (virAsprintf(&ret, "host:%.3d.%.3d", + if (virAsprintf(&ret, "host:%d.%d", dev->source.subsys.u.usb.bus, dev->source.subsys.u.usb.device) < 0) virReportOOMError(); -- 1.7.3.2

2 1

[libvirt] [PATCH] virsh: consolidate memtune docs
by Eric Blake 26 Oct '10

26 Oct '10

* tools/virsh.pod (memtune): Drop second copy, fill to 80 columns, enhance wording. --- Seeing memtune twice in the man page is a bit confusing. This patch doesn't touch the pending issue of whether --min_guarantee makes sense, or should be deleted before it becomes a pre-mature API addition. Also, should memtune be changed to use VSH_OT_INT rather than VSH_OT_STRING? The current 'virsh help memtune' output looks weird: OPTIONS [--domain] <string> domain name, id or uuid --hard_limit <string> Max memory in kilobytes --soft_limit <string> Memory during contention in kilobytes --swap_hard_limit <string> Max swap in kilobytes --min_guarantee <string> Min guaranteed memory in kilobytes tools/virsh.pod | 15 ++++++++------- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 943a563..bc68146 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -513,13 +513,14 @@ Change the maximum memory allocation limit in the guest domain. This should not change the current memory use. The memory limit is specified in kilobytes. -=item B<memtune> I<domain-id> - -Displays the domain memory parameters. - -=item B<memtune> I<domain-id> optional I<--hard-limit> B<kilobytes> optional I<--soft-limit> B<kilobytes> optional I<--swap-hard-limit> B<kilobytes> -I<--min-guarantee> B<kilobytes> - -Allows you to set the domain memory parameters. LXC and QEMU/KVM supports these parameters. +=item B<memtune> I<domain-id> optional I<--hard-limit> B<kilobytes> +optional I<--soft-limit> B<kilobytes> optional I<--swap-hard-limit> +B<kilobytes> -I<--min-guarantee> B<kilobytes> + +Allows you to display or set the domain memory parameters. Without +flags, the current settings are displayed; with a flag, the +appropriate limit is adjusted if supported by the hypervisor. LXC and +QEMU/KVM supports I<--hard-limit>, I<--soft-limit>, and I<--swap-hard-limit>. =item B<setvcpus> I<domain-id> I<count> -- 1.7.2.3

3 7

[libvirt] [PATCH v4 00/13] Implement memory control api
by Nikunj A. Dadhania 26 Oct '10

26 Oct '10

Changelog from v3: * Add unsigned int flags to the public api and make corresponding changes further down till the drivers(qemu, lxc and remote) * Move exporting of the api's to patch two * Added memtune test in tests/qemuxml2xmltest.c * Fix: src/conf/domain_conf.c - print memtune element only if tunable is present * Fix: src/qemu/qemu_driver.c - call cgroup apis only if nonzero * Fix: src/lxc/lxc_controller.c - call cgroup apis only if nonzero Changelog from v2: * Implement virDomainGetMemoryParameters api * Add virDomainGetMemoryParameters to memtune command in virsh * Provide domainGetMemoryParameters implementation for remote, QEmu and LXC drivers * Auto-generate code using rpcgen and remote_generate_stubs.pl * Squash all the changes related to remote driver and remote protocol into one single patch. * Patch re-ordering Changelog from v1: * Patch re-ordering for compilation * Folded python bindings changes to patch 01 * Added defines for string constants for memory tunables * Typo fix: min_guarantee * Moved initialization of function pointers in driver.h patch This patch series implement public api for controlling various memory tunables exported by the OS. This is based on the following RFC[1]. * Implement virDomainSetMemoryParameters api * Provide implementation for remote, QEmu and LXC drivers * Enable memory controller support fro QEmu * virsh command for runtime changes to the memory parameters * Domain configuration parsing for memory control parameters * Cgroup memory controller code for memory hard_limit/soft_limit, swap hard_limit To Do * Python bindings is just a place holder, need to implement 1. https://www.redhat.com/archives/libvir-list/2010-August/msg00607.html 2. https://www.redhat.com/archives/libvir-list/2010-August/msg00699.html --- Nikunj A. Dadhania (13): Adding structure and defines for virDomainSet/GetMemoryParameters Adding virDomainSetMemoryParameters and virDomainGetMemoryParameters API Adds xml entries for memory tunables XML parsing for memory tunables Implement cgroup memory controller tunables Implement driver interface domainSetMemoryParamters for QEmu Implement driver interface domainGetMemoryParamters for QEmu Adding memtunables to qemuSetupCgroup Adding memtunables to libvirt-lxc command Implement driver interface domainSetMemoryParamters for LXC Implement driver interface domainGetMemoryParamters for LXC Adding memtune command to virsh tool Remote protocol changes and implements virDomainSet/GetMemoryParameters daemon/remote.c | 162 +++++++++++++ daemon/remote_dispatch_args.h | 2 daemon/remote_dispatch_prototypes.h | 16 + daemon/remote_dispatch_ret.h | 1 daemon/remote_dispatch_table.h | 10 + docs/schemas/domain.rng | 31 +++ include/libvirt/libvirt.h.in | 63 +++++ python/generator.py | 2 python/libvirt-override-api.xml | 12 + python/libvirt-override.c | 14 + src/conf/domain_conf.c | 54 ++++ src/conf/domain_conf.h | 12 + src/driver.h | 14 + src/esx/esx_driver.c | 2 src/esx/esx_vmx.c | 30 +- src/libvirt.c | 104 +++++++++ src/libvirt_private.syms | 6 src/libvirt_public.syms | 6 src/lxc/lxc_controller.c | 32 +++ src/lxc/lxc_driver.c | 215 +++++++++++++++++- src/openvz/openvz_driver.c | 10 - src/phyp/phyp_driver.c | 2 src/qemu/qemu.conf | 4 src/qemu/qemu_conf.c | 11 - src/qemu/qemu_driver.c | 265 +++++++++++++++++++++- src/remote/remote_driver.c | 151 +++++++++++++ src/remote/remote_protocol.c | 88 +++++++ src/remote/remote_protocol.h | 58 +++++ src/remote/remote_protocol.x | 44 ++++ src/test/test_driver.c | 14 + src/uml/uml_conf.c | 2 src/uml/uml_driver.c | 16 + src/util/cgroup.c | 106 +++++++++ src/util/cgroup.h | 7 + src/xen/xen_driver.c | 2 tests/qemuxml2argvdata/qemuxml2argv-memtune.args | 1 tests/qemuxml2argvdata/qemuxml2argv-memtune.xml | 30 ++ tests/qemuxml2xmltest.c | 1 tools/virsh.c | 130 +++++++++++ 39 files changed, 1662 insertions(+), 68 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memtune.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memtune.xml

6 47

[libvirt] [PATCH] docs: make the location of the xml catalog file a configure option
by Justin Clift 26 Oct '10

26 Oct '10

The default location for the XML catalog file, /etc/xml/catalog, used when validating the generated html docs, isn't correct for MacOS X. This commit adds an option to the configure script, allowing the default to be overridden: --with-xml-catalog-file=/path/to/xml/catalog/file --- Tested on MacOS X 10.6 (using overridden locatin), and Fedora 13 (using the default location). Works fine on both. configure.ac | 17 ++++++++++++----- docs/Makefile.am | 10 ++++++---- 2 files changed, 18 insertions(+), 9 deletions(-) diff --git a/configure.ac b/configure.ac index e41f2b5..153fa1f 100644 --- a/configure.ac +++ b/configure.ac @@ -171,6 +171,12 @@ AC_ARG_WITH([html-subdir], [AC_HELP_STRING([--with-html-subdir=path], [HTML_DIR="$HTML_DIR/\$(PACKAGE)-\$(VERSION)/html"]) AC_SUBST([HTML_DIR]) +dnl Specific XML catalog file for validation of generated html +AC_ARG_WITH([xml-catalog-file], [AC_HELP_STRING([--with-xml-catalog-file=path], + [path to XML catalog file for validating generated html, default /etc/xml/catalog])], + [XML_CATALOG_FILE=$withval], [XML_CATALOG_FILE='/etc/xml/catalog']) +AC_SUBST([XML_CATALOG_FILE]) + dnl if --prefix is /usr, don't use /usr/var for localstatedir dnl or /usr/etc for sysconfdir dnl as this makes a lot of things break in testing situations @@ -2416,11 +2422,12 @@ AC_MSG_NOTICE([ Alloc OOM: $enable_oom]) AC_MSG_NOTICE([]) AC_MSG_NOTICE([Miscellaneous]) AC_MSG_NOTICE([]) -AC_MSG_NOTICE([ Debug: $enable_debug]) -AC_MSG_NOTICE([ Warnings: $enable_compile_warnings]) -AC_MSG_NOTICE([ Readline: $lv_use_readline]) -AC_MSG_NOTICE([ Python: $with_python]) -AC_MSG_NOTICE([ DTrace: $with_dtrace]) +AC_MSG_NOTICE([ Debug: $enable_debug]) +AC_MSG_NOTICE([ Warnings: $enable_compile_warnings]) +AC_MSG_NOTICE([ Readline: $lv_use_readline]) +AC_MSG_NOTICE([ Python: $with_python]) +AC_MSG_NOTICE([ DTrace: $with_dtrace]) +AC_MSG_NOTICE([ XML Catalog: $XML_CATALOG_FILE]) AC_MSG_NOTICE([]) AC_MSG_NOTICE([Privileges]) AC_MSG_NOTICE([]) diff --git a/docs/Makefile.am b/docs/Makefile.am index ae13c46..27804a2 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -118,10 +118,11 @@ todo: %.html: %.html.tmp @if test -x $(XMLLINT) && test -x $(XMLCATALOG) ; then \ - if $(XMLCATALOG) /etc/xml/catalog \ + if $(XMLCATALOG) $(XML_CATALOG_FILE) \ "-//W3C//DTD XHTML 1.0 Strict//EN" > /dev/null ; then \ echo "Validating $@" ; \ - $(XMLLINT) --nonet --format --valid $< > $@ \ + SGML_CATALOG_FILES=$(XML_CATALOG_FILE) \ + $(XMLLINT) --catalogs --nonet --format --valid $< > $@ \ || { rm $@ && exit 1; }; \ else echo "missing XHTML1 DTD" ; fi ; fi @@ -131,10 +132,11 @@ html/index.html: libvirt-api.xml newapi.xsl page.xsl sitemap.html.in echo "Rebuilding the HTML pages from the XML API" ; \ $(XSLTPROC) --nonet $(srcdir)/newapi.xsl libvirt-api.xml ; fi -@if test -x $(XMLLINT) && test -x $(XMLCATALOG) ; then \ - if $(XMLCATALOG) /etc/xml/catalog "-//W3C//DTD XHTML 1.0 Strict//EN" \ + if $(XMLCATALOG) $(XML_CATALOG_FILE) "-//W3C//DTD XHTML 1.0 Strict//EN" \ > /dev/null ; then \ echo "Validating the resulting XHTML pages" ; \ - $(XMLLINT) --nonet --valid --noout html/*.html ; \ + SGML_CATALOG_FILES=$(XML_CATALOG_FILE) \ + $(XMLLINT) --catalogs --nonet --valid --noout html/*.html ; \ else echo "missing XHTML1 DTD" ; fi ; fi $(addprefix $(srcdir)/,$(devhelphtml)): $(srcdir)/libvirt-api.xml $(devhelpxsl) -- 1.7.3

3 4

[libvirt] [PATCH] docs: install the generated html files when make install is run
by Justin Clift 26 Oct '10

26 Oct '10

Previously, only the API docs were installed, rather than the complete documentation set. This commit ensures the complete documentation set is installed. --- docs/Makefile.am | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index 27804a2..f1ec2a6 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -26,6 +26,11 @@ devhelphtml = \ devhelp/libvirt-libvirt.html \ devhelp/libvirt-virterror.html +css = \ + generic.css \ + libvirt.css \ + main.css + devhelppng = \ devhelp/home.png \ devhelp/left.png \ @@ -169,6 +174,10 @@ rebuild: api all install-data-local: $(mkinstalldirs) $(DESTDIR)$(HTML_DIR) + for f in $(css) $(dot_html); do \ + $(INSTALL) -m 0644 $(srcdir)/$$f $(DESTDIR)$(HTML_DIR); done + for f in $(gif) $(png); do \ + $(INSTALL) -m 0644 $(srcdir)/$$f $(DESTDIR)$(HTML_DIR); done -$(INSTALL) -m 0644 $(srcdir)/Libxml2-Logo-90x34.gif $(DESTDIR)$(HTML_DIR) $(mkinstalldirs) $(DESTDIR)$(HTML_DIR)/html for h in $(apihtml); do \ -- 1.7.2.3

3 6

Re: [libvirt] How to start a defined domain
by Osier 26 Oct '10

26 Oct '10

----- "黄亮" <lancerhuang(a)163.com> wrote: > > Well, after "make clean", I run the compiled start.c, still won't > work. "make clean" won't uninstall the installed stuffs, use "make uninstall" instead, or you just made a typo? :-) after that, suggest re-installing 0.6.3 if you are not sure if it's injured. - Osier > And I forget to metion, an error msg is shown: > > libvir: Xen error : Domain not found: xenUnifiedDomainLookupByName > > is that means I missed something? > > > 2010-10-26 > > 黄亮 > > 发件人： Osier > 发送时间： 2010-10-26 18:05:46 > 收件人：黄亮 > 抄送： > 主题： Re: [libvirt] How to start a defined domain > > > > ----- "黄亮" <lancerhuang(a)163.com> wrote: > > > > > Accroding to your case, it seems I have no need to upgrade libvirt > to > > 0.8.4 > > Will that work if I erase 0.8.4 using "make clean" and draw back to > > 0.6.3 ? > > yep, think so, if you don't need the new features, and 0.6.3 is enough > for your project requirement.. :-) > > - Osier > > > > > > > > 2010-10-26 > > > > 黄亮 > > > > 发件人： Osier > > 发送时间： 2010-10-26 17:10:40 > > 收件人：黄亮 > > 抄送： > > 主题： Re: [libvirt] How to start a defined domain > > > > > > > > ----- "黄亮" <lancerhuang(a)163.com> wrote: > > > > > > > > Thanks for your reply, Osier. > > > > > > > > > The distro I'm using is CentOS release 5.5 (Final) > > > > > > I'm not quite sure about the version of libvirt. At first, it > seems > > to > > > be 0.6.3, because /usr/lib64/libvirt.so.0 points to > > > /usr/lib64/libvirt.so.0.6.3 > > > Then I downloaded the src of libvirt_0.8.4 from offical website, > and > > > configure, make, make install. > > > But now it show errors when I type "virsh". The error message lies > > > below: > > > > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.8.2' not > > found > > > (required by virsh) > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.1' not > > found > > > (required by virsh) > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.5' not > > found > > > (required by virsh) > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.8.1' not > > found > > > (required by virsh) > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.0' not > > found > > > (required by virsh) > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.2' not > > found > > > (required by virsh) > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.3' not > > found > > > (required by virsh) > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.8.0' not > > found > > > (required by virsh) > > > virsh: /usr/local/lib/libvirt.so.0: version > `LIBVIRT_PRIVATE_0.8.4' > > > not found (required by virsh) > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.7' not > > found > > > (required by virsh) > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.6.4' not > > found > > > (required by virsh) > > > > probly you should try to erase the 0.6.3, then compile and install > > libvirt > > like: > > > > # ./configure --prefix=/usr --libdir=/usr/lib64 > > # make > > # make install > > > > your test program has no problem on my box. the libvirt on my box > also > > is > > 0.6.3. > > > > Regards > > > > - Osier > > > > > > As for xen, it is 3.3.2. The full "xm info" message is listed > below: > > > host : testbed01 > > > release : 2.6.18-194.11.4.el5xen > > > version : #1 SMP Tue Sep 21 05:40:24 EDT 2010 > > > machine : x86_64 > > > nr_cpus : 8 > > > nr_nodes : 1 > > > cores_per_socket : 4 > > > threads_per_core : 2 > > > cpu_mhz : 2793 > > > hw_caps : > > > > > > bfebfbff:28100800:00000000:00000140:0098e3fd:00000000:00000001:00000000 > > > virt_caps : hvm > > > total_memory : 4055 > > > free_memory : 533 > > > node_to_cpu : node0:0-7 > > > node_to_memory : node0:533 > > > xen_major : 3 > > > xen_minor : 3 > > > xen_extra : .2 > > > xen_caps : xen-3.0-x86_64 xen-3.0-x86_32p hvm-3.0-x86_32 > > > hvm-3.0-x86_32p hvm-3.0-x86_64 > > > xen_scheduler : credit > > > xen_pagesize : 4096 > > > platform_params : virt_start=0xffff800000000000 > > > xen_changeset : unavailable > > > cc_compiler : gcc version 4.1.2 20080704 (Red Hat 4.1.2-44) > > > cc_compile_by : root > > > cc_compile_domain : gitco.tld > > > cc_compile_date : Tue Aug 18 21:07:28 CEST 2009 > > > xend_config_format : 4 > > > > > > I've write a simple c program to test the api, and it is listed > > below: > > > > > > 1 // This program aims to test the api which can start the VM > > > 2 > > > 3 #include "stdio.h" > > > 4 #include "stdlib.h" > > > 5 #include "libvirt/libvirt.h" > > > 6 > > > 7 int main(int argc ,char* argv[]) > > > 8 { > > > 9 virConnectPtr conn; > > > 10 conn = virConnectOpen( "xen+tcp://localhost?no_Verify=1" ); > > > 11 if( conn == NULL ) > > > 12 { > > > 13 printf( "Failed to Connect\n" ); > > > 14 return 1; > > > 15 } > > > 16 const char* host = "vm01"; > > > 17 virDomainPtr dom; > > > 18 dom = virDomainLookupByName( conn, host ); > > > 19 if( dom == NULL ) > > > 20 { > > > 21 printf( "can't find dom\n" ); > > > 22 return 1; > > > 23 } > > > 24 // else > > > 25 // { > > > 26 // virDomainFree( dom ); > > > 27 // virConnectClose( conn ); > > > 28 // printf("done\n"); > > > 29 // return 0; > > > 30 // } > > > 31 if( virDomainCreate( dom ) == -1 ) > > > 32 { > > > 33 printf( "failed to Start\n" ); > > > 34 virDomainFree( dom ); > > > 35 virConnectClose( conn ); > > > 36 return 1; > > > 37 } > > > 38 else > > > 39 { > > > 40 printf( "Started\n" ); > > > 41 virDomainFree( dom ); > > > 42 virConnectClose( conn ); > > > 43 return 0; > > > 44 } > > > 45 } > > > > > > 2010-10-26 > > > > > > Lancer > > > > > > 发件人： Osier > > > 发送时间： 2010-10-26 11:35:31 > > > 收件人：黄亮 > > > 抄送： libvir-list > > > 主题： Re: [libvirt] How to start a defined domain > > > > > > > > > > > > ----- "黄亮" <lancerhuang(a)163.com> wrote: > > > > > > > I've create a domain called "vm01" using Virt-Manager, the GUI > > tool. > > > > Now I wanna use libvirt api to control the life cycle of vm01. > > > > It went on well with shutdown and reboot, but how to start it > > became > > > a > > > > problem. > > > > > > > > I was intended to get the virDomainPtr by using > > > virDomainLookupByName > > > > api, and then start it using virDomainCreate api. > > > > But it turns out that virDomainLookupByName api cannot return a > > > > virDomainPtr for a defined but not running domain. > > > > > > > > > > no, it can :-) > > > > > > If it really doesn't work for you, could you write a simple > program > > to > > > reproduce it? and try to explain what's the version of libvirt you > > > use, > > > on which distro, etc, any helpful info is welcomed. :-) > > > > > > Thanks > > > > > > - Osier > > > > > > > That's my situation, what do you suggest I do now? > > > > Thanks in advance. > > > > > > > > 2010-10-26 > > > > > > > > Lancer > > > > -- > > > > libvir-list mailing list > > > > libvir-list(a)redhat.com > > > > https://www.redhat.com/mailman/listinfo/libvir-list > > > > > > __________ Information from ESET Smart Security, version of virus > > > signature database 5562 (20101025) __________ > > > > > > The message was checked by ESET Smart Security. > > > > > > http://www.eset.com > > > > __________ Information from ESET Smart Security, version of virus > > signature database 5562 (20101025) __________ > > > > The message was checked by ESET Smart Security. > > > > http://www.eset.com > > __________ Information from ESET Smart Security, version of virus > signature database 5563 (20101026) __________ > > The message was checked by ESET Smart Security. > > http://www.eset.com

1 0

[libvirt] [PATCH] Fix build for SystemTap 1.0
by Matthias Bolte 26 Oct '10

26 Oct '10

With SystemTap 1.0 a part of the generated macros in probes.h expands to: volatile __typeof__(((name))) arg2 = (name); GCC reports an 'invalid initialize' error when name has type char[]. Therfore, add casts to char* to avoid this. --- daemon/libvirtd.c | 4 ++-- daemon/remote.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index 8e88d05..d3f003e 100644 --- a/daemon/libvirtd.c +++ b/daemon/libvirtd.c @@ -1230,11 +1230,11 @@ remoteCheckCertificate(struct qemud_client *client) } } - PROBE(CLIENT_TLS_ALLOW, "fd=%d, name=%s", client->fd, name); + PROBE(CLIENT_TLS_ALLOW, "fd=%d, name=%s", client->fd, (char *)name); return 0; authdeny: - PROBE(CLIENT_TLS_DENY, "fd=%d, name=%s", client->fd, name); + PROBE(CLIENT_TLS_DENY, "fd=%d, name=%s", client->fd, (char *)name); return -1; authfail: diff --git a/daemon/remote.c b/daemon/remote.c index 3b72f98..50ccb3b 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -4223,7 +4223,7 @@ remoteDispatchAuthPolkit (struct qemud_server *server, goto authdeny; } PROBE(CLIENT_AUTH_ALLOW, "fd=%d, auth=%d, username=%s", - client->fd, REMOTE_AUTH_POLKIT, ident); + client->fd, REMOTE_AUTH_POLKIT, (char *)ident); VIR_INFO(_("Policy allowed action %s from pid %d, uid %d"), action, callerPid, callerUid); ret->complete = 1; @@ -4238,7 +4238,7 @@ authfail: authdeny: PROBE(CLIENT_AUTH_DENY, "fd=%d, auth=%d, username=%s", - client->fd, REMOTE_AUTH_POLKIT, ident); + client->fd, REMOTE_AUTH_POLKIT, (char *)ident); goto error; error: -- 1.7.0.4

3 3

[libvirt] [PATCH] xen: Fix domain dump
by Jiri Denemark 26 Oct '10

26 Oct '10

Remove redundant 'live' parameter which caused an error from xend: "xend.err 'Too many values for live'" --- src/xen/xend_internal.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c index b90c331..bce911e 100644 --- a/src/xen/xend_internal.c +++ b/src/xen/xend_internal.c @@ -3026,7 +3026,7 @@ xenDaemonDomainCoreDump(virDomainPtr domain, const char *filename, } return xend_op(domain->conn, domain->name, - "op", "dump", "file", filename, "live", "0", + "op", "dump", "file", filename, "live", (flags & VIR_DUMP_LIVE ? "1" : "0"), "crash", (flags & VIR_DUMP_CRASH ? "1" : "0"), NULL); -- 1.7.3.2

2 2

[libvirt] [PATCH] Avoid squashing errors during network startup cleanup path
by Daniel P. Berrange 26 Oct '10

26 Oct '10

When failing to start a virtual network, we have to cleanup, tearing down any iptables rules. If the iptables rules were not present yet though, this raises an error, which squashes the original error we were handling. * src/network/bridge_driver.c: When failing to start a virtual network, don't squash the original error in cleanup --- src/network/bridge_driver.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 8721747..0777d85 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -1171,6 +1171,7 @@ static int networkStartNetworkDaemon(struct network_driver *driver, virNetworkObjPtr network) { int err; + virErrorPtr save_err; if (virNetworkObjIsActive(network)) { networkReportError(VIR_ERR_INTERNAL_ERROR, @@ -1255,7 +1256,12 @@ static int networkStartNetworkDaemon(struct network_driver *driver, } err_delbr2: + save_err = virSaveLastError(); networkRemoveIptablesRules(driver, network); + if (save_err) { + virSetError(save_err); + virFreeError(save_err); + } err_delbr1: if ((err = brSetInterfaceUp(driver->brctl, network->def->bridge, 0))) { -- 1.7.2.3

2 1

Re: [libvirt] How to start a defined domain
by 黄亮 26 Oct '10

26 Oct '10

Well, after "make clean", I run the compiled start.c, still won't work. And I forget to metion, an error msg is shown: libvir: Xen error : Domain not found: xenUnifiedDomainLookupByName is that means I missed something? 2010-10-26 黄亮发件人： Osier 发送时间： 2010-10-26 18:05:46 收件人：黄亮抄送：主题： Re: [libvirt] How to start a defined domain ----- "黄亮" <lancerhuang(a)163.com> wrote: > > Accroding to your case, it seems I have no need to upgrade libvirt to > 0.8.4 > Will that work if I erase 0.8.4 using "make clean" and draw back to > 0.6.3 ? yep, think so, if you don't need the new features, and 0.6.3 is enough for your project requirement.. :-) - Osier > > > > 2010-10-26 > > 黄亮 > > 发件人： Osier > 发送时间： 2010-10-26 17:10:40 > 收件人：黄亮 > 抄送： > 主题： Re: [libvirt] How to start a defined domain > > > > ----- "黄亮" <lancerhuang(a)163.com> wrote: > > > > > Thanks for your reply, Osier. > > > > > > The distro I'm using is CentOS release 5.5 (Final) > > > > I'm not quite sure about the version of libvirt. At first, it seems > to > > be 0.6.3, because /usr/lib64/libvirt.so.0 points to > > /usr/lib64/libvirt.so.0.6.3 > > Then I downloaded the src of libvirt_0.8.4 from offical website, and > > configure, make, make install. > > But now it show errors when I type "virsh". The error message lies > > below: > > > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.8.2' not > found > > (required by virsh) > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.1' not > found > > (required by virsh) > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.5' not > found > > (required by virsh) > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.8.1' not > found > > (required by virsh) > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.0' not > found > > (required by virsh) > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.2' not > found > > (required by virsh) > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.3' not > found > > (required by virsh) > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.8.0' not > found > > (required by virsh) > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_PRIVATE_0.8.4' > > not found (required by virsh) > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.7.7' not > found > > (required by virsh) > > virsh: /usr/local/lib/libvirt.so.0: version `LIBVIRT_0.6.4' not > found > > (required by virsh) > > probly you should try to erase the 0.6.3, then compile and install > libvirt > like: > > # ./configure --prefix=/usr --libdir=/usr/lib64 > # make > # make install > > your test program has no problem on my box. the libvirt on my box also > is > 0.6.3. > > Regards > > - Osier > > > > As for xen, it is 3.3.2. The full "xm info" message is listed below: > > host : testbed01 > > release : 2.6.18-194.11.4.el5xen > > version : #1 SMP Tue Sep 21 05:40:24 EDT 2010 > > machine : x86_64 > > nr_cpus : 8 > > nr_nodes : 1 > > cores_per_socket : 4 > > threads_per_core : 2 > > cpu_mhz : 2793 > > hw_caps : > > > bfebfbff:28100800:00000000:00000140:0098e3fd:00000000:00000001:00000000 > > virt_caps : hvm > > total_memory : 4055 > > free_memory : 533 > > node_to_cpu : node0:0-7 > > node_to_memory : node0:533 > > xen_major : 3 > > xen_minor : 3 > > xen_extra : .2 > > xen_caps : xen-3.0-x86_64 xen-3.0-x86_32p hvm-3.0-x86_32 > > hvm-3.0-x86_32p hvm-3.0-x86_64 > > xen_scheduler : credit > > xen_pagesize : 4096 > > platform_params : virt_start=0xffff800000000000 > > xen_changeset : unavailable > > cc_compiler : gcc version 4.1.2 20080704 (Red Hat 4.1.2-44) > > cc_compile_by : root > > cc_compile_domain : gitco.tld > > cc_compile_date : Tue Aug 18 21:07:28 CEST 2009 > > xend_config_format : 4 > > > > I've write a simple c program to test the api, and it is listed > below: > > > > 1 // This program aims to test the api which can start the VM > > 2 > > 3 #include "stdio.h" > > 4 #include "stdlib.h" > > 5 #include "libvirt/libvirt.h" > > 6 > > 7 int main(int argc ,char* argv[]) > > 8 { > > 9 virConnectPtr conn; > > 10 conn = virConnectOpen( "xen+tcp://localhost?no_Verify=1" ); > > 11 if( conn == NULL ) > > 12 { > > 13 printf( "Failed to Connect\n" ); > > 14 return 1; > > 15 } > > 16 const char* host = "vm01"; > > 17 virDomainPtr dom; > > 18 dom = virDomainLookupByName( conn, host ); > > 19 if( dom == NULL ) > > 20 { > > 21 printf( "can't find dom\n" ); > > 22 return 1; > > 23 } > > 24 // else > > 25 // { > > 26 // virDomainFree( dom ); > > 27 // virConnectClose( conn ); > > 28 // printf("done\n"); > > 29 // return 0; > > 30 // } > > 31 if( virDomainCreate( dom ) == -1 ) > > 32 { > > 33 printf( "failed to Start\n" ); > > 34 virDomainFree( dom ); > > 35 virConnectClose( conn ); > > 36 return 1; > > 37 } > > 38 else > > 39 { > > 40 printf( "Started\n" ); > > 41 virDomainFree( dom ); > > 42 virConnectClose( conn ); > > 43 return 0; > > 44 } > > 45 } > > > > 2010-10-26 > > > > Lancer > > > > 发件人： Osier > > 发送时间： 2010-10-26 11:35:31 > > 收件人：黄亮 > > 抄送： libvir-list > > 主题： Re: [libvirt] How to start a defined domain > > > > > > > > ----- "黄亮" <lancerhuang(a)163.com> wrote: > > > > > I've create a domain called "vm01" using Virt-Manager, the GUI > tool. > > > Now I wanna use libvirt api to control the life cycle of vm01. > > > It went on well with shutdown and reboot, but how to start it > became > > a > > > problem. > > > > > > I was intended to get the virDomainPtr by using > > virDomainLookupByName > > > api, and then start it using virDomainCreate api. > > > But it turns out that virDomainLookupByName api cannot return a > > > virDomainPtr for a defined but not running domain. > > > > > > > no, it can :-) > > > > If it really doesn't work for you, could you write a simple program > to > > reproduce it? and try to explain what's the version of libvirt you > > use, > > on which distro, etc, any helpful info is welcomed. :-) > > > > Thanks > > > > - Osier > > > > > That's my situation, what do you suggest I do now? > > > Thanks in advance. > > > > > > 2010-10-26 > > > > > > Lancer > > > -- > > > libvir-list mailing list > > > libvir-list(a)redhat.com > > > https://www.redhat.com/mailman/listinfo/libvir-list > > > > __________ Information from ESET Smart Security, version of virus > > signature database 5562 (20101025) __________ > > > > The message was checked by ESET Smart Security. > > > > http://www.eset.com > > __________ Information from ESET Smart Security, version of virus > signature database 5562 (20101025) __________ > > The message was checked by ESET Smart Security. > > http://www.eset.com __________ Information from ESET Smart Security, version of virus signature database 5563 (20101026) __________ The message was checked by ESET Smart Security. http://www.eset.com

1 0

[libvirt] RFC: Libvirt extensions for QEMU tracing
by Prerna Saxena 26 Oct '10

26 Oct '10

Hi, Tracing infrastructure is now a part of upstream QEMU, which allows options to choose different trace backends to handle trace-events of interest. The choice of 'simple' trace backend allows users to dynamically enable/disable trace events for a running qemu instance as well as to set options for logging traces to a desired file via the qemu monitor. While the QMP interfaces are still under discussion (http://www.mail-archive.com/qemu-devel@nongnu.org/msg44535.html) I propose the following extensions for virsh to make use of human-monitor tracing commands: 1. virsh trace-events DOMAIN-ID [set TRACE-EVENT ON ] ---------------------------------------------------- - Implements QEMU monitor command 'trace event' to change state of a particular trace-event. - Eg, virsh trace-events DOMAIN-ID set ABC on : changes state of trace-event 'ABC' to enabled. - When specified without arguments, it implements QEMU monitor command to show all currently available trace events and their state for a specific instance. - Eg, virsh trace-events DOMAIN-ID : lists all trace-events with their state for that instance. 2. virsh trace-file DOMAIN_ID [set FILENAME | --enable | --disable] ------------------------------------------------------------------- - Implements the qemu monitor command : trace-file - Without any arguments, it lists the currently active trace output file with its state. - The 'set' subcommand changes the output file to FILENAME. - The --enable and --disable switches respectively enable and disable writing of trace data to output file. The catch is, these are only available for 'simple' trace backend for qemu, so one would need to be careful of handling failures when these commands are passed to qemu instances compiled with a different trace backend. It would have been much easier if there existed a generic virsh command to pass commands to the QEMU monitor. I saw some patches for qemu-monitor-command option for virsh,(http://www.mail-archive.com/libvir-list@redhat.com/msg26237.html) but looks like it is not upstream right now. In order to support QEMU tracing, would this be a better bet than implementing virsh extensions listed above ? If yes, any chance we might have it in for the next release ? Awaiting feedback, -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

3 2

[libvirt] List of available libvirt drivers installed?
by Shi Jin 26 Oct '10

26 Oct '10

I am wondering if there is a way to show a list of available libvirt hypervisor drvers installed in an existing libvirt installation. I know based on the version of libvirt, I can find out supported drivers from this matrix: http://libvirt.org/hvsupport.html However, the particular installation may not turn on all available drivers for this particular build. Is there a way to find out? Particularly, I want to find out if the default libvirt coming with RHEL-5/6 supports VMware ESX, and the same for Ubuntu-10.4/10.10. Thanks in advance. Shi -- Shi Jin, PhD

2 1

[libvirt] [PATCH v2 1/2] visrh dump compression support
by KAMEZAWA Hiroyuki 26 Oct '10

26 Oct '10

2 8

[libvirt] [PATCH 1/2] virsh: Add option 'model' for attach-interface
by Osier Yang 26 Oct '10

26 Oct '10

Allows to specify the NIC model type when attaching an interface, it's an optional option. --- tools/virsh.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 3e37b06..2da9489 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -8292,6 +8292,7 @@ static const vshCmdOptDef opts_attach_interface[] = { {"target", VSH_OT_DATA, 0, N_("target network name")}, {"mac", VSH_OT_DATA, 0, N_("MAC address")}, {"script", VSH_OT_DATA, 0, N_("script used to bridge network interface")}, + {"model", VSH_OT_DATA, 0, N_("model type")}, {"persistent", VSH_OT_BOOL, 0, N_("persist interface attachment")}, {NULL, 0, 0, NULL} }; @@ -8300,7 +8301,7 @@ static int cmdAttachInterface(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom = NULL; - char *mac, *target, *script, *type, *source; + char *mac, *target, *script, *type, *source, *model; int typ, ret = FALSE; unsigned int flags; virBuffer buf = VIR_BUFFER_INITIALIZER; @@ -8319,6 +8320,7 @@ cmdAttachInterface(vshControl *ctl, const vshCmd *cmd) target = vshCommandOptString(cmd, "target", NULL); mac = vshCommandOptString(cmd, "mac", NULL); script = vshCommandOptString(cmd, "script", NULL); + model = vshCommandOptString(cmd, "model", NULL); /* check interface type */ if (STREQ(type, "network")) { @@ -8345,6 +8347,8 @@ cmdAttachInterface(vshControl *ctl, const vshCmd *cmd) virBufferVSprintf(&buf, " <mac address='%s'/>\n", mac); if (script != NULL) virBufferVSprintf(&buf, " <script path='%s'/>\n", script); + if (model != NULL) + virBufferVSprintf(&buf, " <model type='%s'/>\n", model); virBufferAddLit(&buf, "</interface>\n"); -- 1.7.1

3 2

[libvirt] [PATCH] Fix documentation for virEventAddTimeout()
by Philipp Hahn 26 Oct '10

26 Oct '10

Fix copy&paste error from virEventAddHandle(). Signed-off-by: Philipp Hahn <hahn(a)univention.de> --- src/util/event.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

2 1

[libvirt] --checksum-fill error on Ubuntu 10.04
by Justin Clift 26 Oct '10

26 Oct '10

Hi us, Just noticed an error message when manually starting libvirtd (built from git) on Ubuntu 10.04, while checking something else: iptables v1.4.4: unknown option `--checksum-fill' It shows up in the initial default network setup: 10:40:19.807: error : virRunWithHook:855 : internal error '/sbin/iptables --table mangle --insert POSTROUTING --out-interface virbr0 --protocol udp --destination-port 68 --jump CHECKSUM --checksum-fill' exited with non-zero status 2 and signal 0: iptables v1.4.4: unknown option `--checksum-fill' Try `iptables -h' or 'iptables --help' for more information. Just a FYI, in case someone wants to look into it. Regards and best wishes, Justin Clift

2 1

Re: [libvirt] How to start a defined domain
by Osier 26 Oct '10

26 Oct '10

----- "黄亮" <lancerhuang(a)163.com> wrote: > I've create a domain called "vm01" using Virt-Manager, the GUI tool. > Now I wanna use libvirt api to control the life cycle of vm01. > It went on well with shutdown and reboot, but how to start it became a > problem. > > I was intended to get the virDomainPtr by using virDomainLookupByName > api, and then start it using virDomainCreate api. > But it turns out that virDomainLookupByName api cannot return a > virDomainPtr for a defined but not running domain. > no, it can :-) If it really doesn't work for you, could you write a simple program to reproduce it? and try to explain what's the version of libvirt you use, on which distro, etc, any helpful info is welcomed. :-) Thanks - Osier > That's my situation, what do you suggest I do now? > Thanks in advance. > > 2010-10-26 > > Lancer > -- > libvir-list mailing list > libvir-list(a)redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list

1 0

[libvirt] How to start a defined domain
by 黄亮 26 Oct '10

26 Oct '10

I've create a domain called "vm01" using Virt-Manager, the GUI tool. Now I wanna use libvirt api to control the life cycle of vm01. It went on well with shutdown and reboot, but how to start it became a problem. I was intended to get the virDomainPtr by using virDomainLookupByName api, and then start it using virDomainCreate api. But it turns out that virDomainLookupByName api cannot return a virDomainPtr for a defined but not running domain. That's my situation, what do you suggest I do now? Thanks in advance. 2010-10-26 Lancer

1 0

[libvirt] Initial working Mac OS X libvirt client build
by Justin Clift 25 Oct '10

25 Oct '10

Hi all, This is for anyone using the Homebrew package management system on Mac OS X. :) A first working (but still experimental) libvirt formula is online: http://github.com/justinclift/libvirt It includes the libvirt text mode client (virsh), and the libvirt development libraries. If you have time to test it and report success/failure/(etc), please do. Be aware, for the moment, it pulls down a tarred up snapshot of libvirt git, with a few trivial patches applied to make compiling work: What works: + Remote connections using TLS (qemu+tls://) <-- encrypted + Remote connections using TCP (qemu+tls://) <-- not encrypted! What doesn't work: + Remote connections using SSH (qemu+ssh://), if the server has PolicyKit enabled. (possible bug, will look into it) In theory, this means connecting to Ubuntu server should work, as that uses groups to control access rather than PolicyKit. Haven't tried it though, so if you do, please let me know how it goes. ;) Testing and feedback is encouraged. The aim here is to have the libvirt client (virsh) plus development libraries work properly on OS X. Please note, I'm new to OS X, github, and Homebrew, so if you notice things that should be done better/differently/etc, please let me know. :) Regards and best wishes, Justin Clift

7 33

[libvirt] [PATCH 2/2] virsh: update attach-interface docs
by Osier Yang 25 Oct '10

25 Oct '10

* tools/virsh.pod (attach-interface): add docs for new option 'model' and missed option 'persistent'. --- tools/virsh.pod | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 61875af..d904800 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -647,7 +647,7 @@ although this use only replaces the media within the existing virtual cdrom or floppy device; consider using B<update-device> for this usage instead. I<mode> can specify the two specific mode I<readonly> or I<shareable>. -=item B<attach-interface> I<domain-id> I<type> I<source> optional I<--target target> I<--mac mac> I<--script script> +=item B<attach-interface> I<domain-id> I<type> I<source> optional I<--target target> I<--mac mac> I<--script script> I<--model model> I<--persistent> Attach a new network interface to the domain. I<type> can be either I<network> to indicate a physical network device or I<bridge> to indicate a bridge to a device. @@ -656,6 +656,8 @@ I<target> allows to indicate the target device in the guest. I<mac> allows to specify the MAC address of the network interface. I<script> allows to specify a path to a script handling a bridge instead of the default one. +I<model> allows to specify the model type. +I<persistent> indicates the changes will affect the next boot of the domain. =item B<detach-device> I<domain-id> I<FILE> -- 1.7.1

2 1