- Devel - libvirt List Archives

[libvirt] [PATCH] XML: Escape double-hyphens in XML comment
by Philipp Hahn 21 Feb '14

21 Feb '14

To quote <http://www.w3.org/TR/REC-xml/#sec-comments>: > For compatibility, the string "--" (double-hyphen) must not occur within comments. For example this breaks creating snapshots: $ virsh snapshot-create-as $VM "comment--bug" $ xmllint --noout /var/lib/libvirt/qemu/snapshot/$VM/comment--bug.xml /var/lib/libvirt/qemu/snapshot/$VM/comment--bug.xml:4: parser error : Comment not terminated <domain...<devices>...<disk...<source dev="/dev/sda"/>... It might break on the "/" as this is the only prohibited character for QEMU domains, as the name is directly used as a file name. To fix such broken files (by hand), remove the broken comment by doing something like this after making sure libvirtd is stopped: sed -i -ne '/^<domainsnapshot>$/,$p' /var/lib/libvirt/qemu/snapshot/*/*.xml sed -i -ne '/^<domain /,$p' /etc/libvirt/qemu/*.xml sed -i -ne '/^<pool /,$p' /etc/libvirt/storage/*.xml @Debian: The bug is also in libvirt-0.9.12. Signed-off-by: Philipp Hahn <hahn(a)univention.de> --- src/util/virxml.c | 34 ++++++++++++++++++++++++++++++---- 1 file changed, 30 insertions(+), 4 deletions(-) diff --git a/src/util/virxml.c b/src/util/virxml.c index dd530a6..ad45e68 100644 --- a/src/util/virxml.c +++ b/src/util/virxml.c @@ -798,6 +798,34 @@ const char *virXMLPickShellSafeComment(const char *str1, const char *str2) return NULL; } +/* + * Break sequence of hyphens by inserting (arbitrarily chosen) backslashes. + * <http://www.w3.org/TR/REC-xml/#sec-comments>: + * > For compatibility, the string "--" (double-hyphen) must not occur within + * > comments. + */ +static int virXMLEmitEscapedComment(int fd, + const char *str) +{ + size_t len; + + if (!strstr(str, "--")) { + len = strlen(str); + if (safewrite(fd, str, len) != len) + return -1; + return 0; + } + + for (;*str;str++) { + if (safewrite(fd, str, 1) != 1) + return -1; + if (str[0] == '-' && str[1] == '-') + if (safewrite(fd, "\\", 1) != 1) + return -1; + } + return 0; +} + static int virXMLEmitWarning(int fd, const char *name, const char *cmd) @@ -822,16 +850,14 @@ static int virXMLEmitWarning(int fd, if (safewrite(fd, prologue, len) != len) return -1; - len = strlen(cmd); - if (safewrite(fd, cmd, len) != len) + if (virXMLEmitEscapedComment(fd, cmd) < 0) return -1; if (name) { if (safewrite(fd, " ", 1) != 1) return -1; - len = strlen(name); - if (safewrite(fd, name, len) != len) + if (virXMLEmitEscapedComment(fd, name) < 0) return -1; } -- 1.8.5.3

3 3

[libvirt] ANNOUNCE: libvirt-glib release 0.1.8
by Daniel P. Berrange 21 Feb '14

21 Feb '14

I am pleased to announce that a new release of the libvirt-glib package, version 0.1.8, is now available from ftp://libvirt.org/libvirt/glib/ The packages are GPG signed with Key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R) Changes in this release: - Add getter/setter for UUID in domain config - Remove dead code / unused variables - Add missing symbol exports - Add support for setting nwfilters in domain config - Switch to standard gobject introspection autotools macros - Fix typo preventing removal of clock config - Add getter/setters for disk driver type - Add unit tests based on glib tap harness - Add test for validating symbol file exports - Add getters for domain graphics config params - Add more getters for domain timer config - Add support for hpet timer type - Fix event loop impl on win32 - Fix parent class/object of pit timer class - Fix misc API doc bugs - Add more getters for domain clock config - Fix removal of domain CPU feature flags - Fix removal of capabilities CPU topology - Misc fixes to glib event loop integration libvirt-glib comprises three distinct libraries: - libvirt-glib - Integrate with the GLib event loop and error handling - libvirt-gconfig - Representation of libvirt XML documents as GObjects - libvirt-gobject - Mapping of libvirt APIs into the GObject type system NB: While libvirt aims to be API/ABI stable forever, with libvirt-glib we are not yet guaranteeing that libvirt-glib libraries are API/ABI permanently stable. As of the 0.0.8 release, we have tentatively frozen the API/ABI with the intent of being longterm stable hereafter, but there is still a small chance we might find flaws requiring an API/ABI change. The likelihood of this is low, however, and we will strive to avoid it. Follow up comments about libvirt-glib should be directed to the regular libvir-list(a)redhat.com development list. Thanks to all the people involved in contributing to this release. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

1 0

[libvirt] [PATCH 0/5] Get AppArmor to work for LXC containers
by Cédric Bosdonnat 21 Feb '14

21 Feb '14

This patch series, implements the AppArmor support for LXC containers. examples/apparmor/libvirt-lxc only allows the minimum, users will be able to add more in the generated profile. Cédric Bosdonnat (5): LXC driver: generate apparmor profiles for guests Make sure apparmor is started before libvirtd Set default lxc security_driver to none apparmor: add debug traces when changing profile. add support for apparmor in lxc-enter-namespace daemon/libvirtd.service.in | 1 + examples/apparmor/Makefile.am | 2 ++ examples/apparmor/TEMPLATE | 2 +- examples/apparmor/libvirt-lxc | 17 ++++++++++ src/libvirt-lxc.c | 13 ++++++++ src/lxc/lxc.conf | 2 ++ src/security/security_apparmor.c | 15 ++++++--- src/security/virt-aa-helper.c | 69 +++++++++++++++++++++++++++++----------- 8 files changed, 97 insertions(+), 24 deletions(-) create mode 100644 examples/apparmor/libvirt-lxc -- 1.8.5.2

3 7

[libvirt] [PATCH v2 glib] gobject-stream: fix issue found by coverity
by Pavel Hrdina 21 Feb '14

21 Feb '14

The coverity server found issue in gvir_stream_close function that we ignore return values of g_input_stream_close and g_output_stream_close, but we also ignore the error message and we assume that it's closed without error. Now we will check return values and also propagate the error message to the upper layers. We should try to close both streams even if closing the first one will fails. We can propagate only one error message. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- libvirt-gobject/libvirt-gobject-stream.c | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/libvirt-gobject/libvirt-gobject-stream.c b/libvirt-gobject/libvirt-gobject-stream.c index 1572022..46dbd9a 100644 --- a/libvirt-gobject/libvirt-gobject-stream.c +++ b/libvirt-gobject/libvirt-gobject-stream.c @@ -102,17 +102,31 @@ static GOutputStream* gvir_stream_get_output_stream(GIOStream *io_stream) static gboolean gvir_stream_close(GIOStream *io_stream, GCancellable *cancellable, - G_GNUC_UNUSED GError **error) + GError **error) { GVirStream *self = GVIR_STREAM(io_stream); + GError *local_error = NULL; + gboolean i_ret = TRUE, o_ret = TRUE; + + g_return_val_if_fail(error == NULL || *error == NULL, FALSE); if (self->priv->input_stream) - g_input_stream_close(self->priv->input_stream, cancellable, NULL); + i_ret = g_input_stream_close(self->priv->input_stream, cancellable, &local_error); + + if (local_error) + g_propagate_error(error, local_error); if (self->priv->output_stream) - g_output_stream_close(self->priv->output_stream, cancellable, NULL); + o_ret = g_output_stream_close(self->priv->output_stream, cancellable, &local_error); + + if (local_error) { + if (i_ret) + g_propagate_error(error, local_error); + else + g_error_free(local_error); + } - return TRUE; /* FIXME: really close the stream? */ + return (i_ret && o_ret); } -- 1.8.3.1

2 2

[libvirt] [PATCH v12 00/11] Write separate module for hostdev passthrough
by Chunyan Liu 21 Feb '14

21 Feb '14

These patches implements a separate module for hostdev passthrough so that it could be shared by different drivers and can maintain a global state of a host device. patch 1/11: pci/usb/scsi used_by should include driver and domain info to check conflict among different drivers. patch 2/11~5/11: extract qemu specific code outside, to prepare for hostdev common library patch 6/11: move hostdev functions from qemu_hostdev.c to common library and maintain insistent device state. patch 7/11: add a unit test for hostdev common library. patch 8/11: switch qemu driver to use the common library instead of its own hostdev passthrough APIs. patch 9/11: switch lxc driver to use the common library instead of its own hostdev passthrough APIs. patch 10/11: add a hostdev pci backend type for xen usage. patch 11/11: add pci passthrough to libxl driver. --- Changes to v11: * rebase to latest shareable scsi hostdev changes * split v11 1/6 (add hostdev common library): add some small patches to extract qemu specific codes outside first before adding hostdev common library patch, for easier review. Chunyan Liu (11): change used_by: specify both driver and domain qemu_hostdev: move cfg->relaxedACS as a flag qemu_hostdev: move COLD_BOOT as a flag qemu_hostdev: parse BACKEND_DEFAULT outside qemu_hostdev: add/remove share device outside add hostdev passthrough common library add unit test for hostdev common library change qemu driver to use hostdev common library change lxc driver to use hostdev common library add hostdev pci backend type for xen add pci passthrough for libxl driver .gitignore | 1 + docs/schemas/domaincommon.rng | 1 + po/POTFILES.in | 3 +- src/Makefile.am | 3 +- src/conf/domain_conf.c | 3 +- src/conf/domain_conf.h | 1 + src/libvirt_private.syms | 21 + src/libxl/libxl_conf.c | 63 + src/libxl/libxl_conf.h | 4 + src/libxl/libxl_domain.c | 9 + src/libxl/libxl_driver.c | 448 +++++- src/lxc/lxc_conf.h | 4 - src/lxc/lxc_driver.c | 47 +- src/lxc/lxc_hostdev.c | 413 ----- src/lxc/lxc_hostdev.h | 43 - src/lxc/lxc_process.c | 24 +- src/qemu/qemu_command.c | 4 +- src/qemu/qemu_conf.h | 11 +- src/qemu/qemu_domain.c | 22 + src/qemu/qemu_driver.c | 83 +- src/qemu/qemu_hostdev.c | 89 +- src/qemu/qemu_hostdev.h | 5 +- src/qemu/qemu_hotplug.c | 144 +- src/qemu/qemu_process.c | 61 +- src/util/virhostdev.c | 1787 ++++++++++++++++++++ src/util/virhostdev.h | 134 ++ src/util/virpci.c | 30 +- src/util/virpci.h | 9 +- src/util/virscsi.c | 30 +- src/util/virscsi.h | 7 +- src/util/virusb.c | 29 +- src/util/virusb.h | 8 +- tests/Makefile.am | 5 + .../qemuxml2argv-hostdev-pci-address.xml | 1 + .../qemuxml2argvdata/qemuxml2argv-net-hostdev.xml | 1 + tests/qemuxml2argvdata/qemuxml2argv-pci-rom.xml | 2 + tests/virhostdevtest.c | 473 ++++++ tests/virscsitest.c | 6 +- 38 files changed, 3292 insertions(+), 737 deletions(-) delete mode 100644 src/lxc/lxc_hostdev.c delete mode 100644 src/lxc/lxc_hostdev.h create mode 100644 src/util/virhostdev.c create mode 100644 src/util/virhostdev.h create mode 100644 tests/virhostdevtest.c

4 24

[libvirt] [PATCH] Ignore additional fields in iscsiadm output
by Ján Tomko 21 Feb '14

21 Feb '14

There has been a new field introduced in iscsiadm --mode session output [1], but our regex only expects four fields. This breaks startup of iscsi pools: error: Failed to start pool iscsi error: internal error: cannot find session Fix this by ignoring anything after the fourth field. https://bugzilla.redhat.com/show_bug.cgi?id=1067173 [1] https://github.com/mikechristie/open-iscsi/commit/181af9a --- src/storage/storage_backend_iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/storage/storage_backend_iscsi.c b/src/storage/storage_backend_iscsi.c index 556c2cc..1149e43 100644 --- a/src/storage/storage_backend_iscsi.c +++ b/src/storage/storage_backend_iscsi.c @@ -102,7 +102,7 @@ virStorageBackendISCSISession(virStoragePoolObjPtr pool, * Pull out 2nd and 4th fields */ const char *regexes[] = { - "^tcp:\\s+\\[(\\S+)\\]\\s+\\S+\\s+(\\S+)\\s*$" + "^tcp:\\s+\\[(\\S+)\\]\\s+\\S+\\s+(\\S+).*$" }; int vars[] = { 2, -- 1.8.3.2

2 2

[libvirt] [PATCH] Add a stub for virCgroupGetDomainTotalCpuStats
by Ján Tomko 21 Feb '14

21 Feb '14

Commit 6515889 broke the build on FreeBSD: In function `qemuDomainGetCPUStats': /../../src/qemu/qemu_driver.c:16102: undefined reference to `virCgroupGetDomainTotalCpuStats' --- Pushed as a build-breaker. src/util/vircgroup.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 268a4ae..2dba10c 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -4261,6 +4261,17 @@ virCgroupGetCpuacctStat(virCgroupPtr group ATTRIBUTE_UNUSED, int +virCgroupGetDomainTotalCpuStats(virCgroupPtr group ATTRIBUTE_UNUSED, + virTypedParameterPtr params ATTRIBUTE_UNUSED, + int nparams ATTRIBUTE_UNUSED) +{ + virReportSystemError(ENOSYS, "%s", + _("Control groups not supported on this platform")); + return -1; +} + + +int virCgroupSetFreezerState(virCgroupPtr group ATTRIBUTE_UNUSED, const char *state ATTRIBUTE_UNUSED) { -- 1.8.3.2

1 0

[libvirt] [PATCHv4 00/10] Add BlkIO and CPU/mem stat API implementations for lxc
by Thorsten Behrens 21 Feb '14

21 Feb '14

This patch set adds block io, memory and domain cpu statistics API slot implementations to the LXC driver, in order to get linux container monitoring and accounting a bit closer to qemu standards. The last patch is a tad quirky (happy to hear suggestions on alternative ways), in that it widens the permissible value set at the .domainBlockStats slot: for lxc guests, it is relatively likely to have zero disk devices, since host filesystems can be used via passthrough bind mounts. Therefore, passing the zero-length string as device path, is interpreted as 'return summary stats for the entire domains's block io'. v4 addresses the last remaining review comments. Thorsten Behrens (10): Add util virCgroupGetBlkioIo*Serviced methods. Implement domainMemoryStats API slot for LXC driver. Make qemuGetDomainTotalCPUStats a virCgroup function. Implement domainGetCPUStats for lxc driver. Implement lxcDomainBlockStats* for lxc driver Widening API change - accept empty path for virDomainBlockStats Add unit test for virCgroupGetBlkioIo*Serviced Add unit test for virCgroupGetMemoryUsage. Fix misspelled cpuacct.usage_percpu in cgroup mock. Add unit test for virCgroupGetPercpuStats. src/libvirt.c | 8 +- src/libvirt_private.syms | 4 + src/lxc/lxc_driver.c | 300 +++++++++++++++++++++++++++++++++ src/qemu/qemu_driver.c | 54 +----- src/util/vircgroup.c | 382 +++++++++++++++++++++++++++++++++++++++++++ src/util/vircgroup.h | 24 +++ tests/testutilslxc.h | 3 + tests/vircgroupmock.c | 100 ++++++++++- tests/vircgrouptest.c | 230 ++++++++++++++++++++++++++ tools/virsh-domain-monitor.c | 11 +- tools/virsh.pod | 5 +- 11 files changed, 1059 insertions(+), 62 deletions(-) -- 1.8.4.5

4 21

[libvirt] [libvirt-python PATCH] generator: Skip exporting only sentinels
by Martin Kletzander 21 Feb '14

21 Feb '14

When enum type has '_LAST' in its name, but is not the last type in that enum, it's skipped even though it shouldn't be. Currently, this is the case for only VIR_NETWORK_UPDATE_COMMAND_ADD_LAST inside an enum virNetworkUpdateCommand. Also, since _LAST types can have other enums instead of values, that needs to be filtered out using a try-except when converting the value. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- generator.py | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/generator.py b/generator.py index 42f3913..0e9600f 100755 --- a/generator.py +++ b/generator.py @@ -227,10 +227,9 @@ def enum(type, name, value): value = 1 elif value == 'VIR_DOMAIN_AFFECT_CONFIG': value = 2 - if name[-5:] != '_LAST': - if onlyOverrides and name not in enums[type]: - return - enums[type][name] = value + if onlyOverrides and name not in enums[type]: + return + enums[type][name] = value def lxc_enum(type, name, value): if type not in lxc_enums: @@ -1765,13 +1764,23 @@ def buildWrappers(module): # # Generate enum constants # + def enumsSortKey(data): + value = data[1] + try: + value = int(value) + except ValueError: + value = float('inf') + return value + enumvals = list(enums.items()) if enumvals is not None: enumvals.sort(key=lambda x: x[0]) for type,enum in enumvals: classes.write("# %s\n" % type) items = list(enum.items()) - items.sort(key=lambda i: int(i[1])) + items.sort(key=enumsSortKey) + if items[-1][0].endswith('_LAST'): + del items[-1] for name,value in items: classes.write("%s = %s\n" % (name,value)) classes.write("\n") -- 1.9.0

2 2

[libvirt] [PATCH] virsh: fix memory leak in virsh when starting a guest with invalid fd
by Jincheng Miao 21 Feb '14

21 Feb '14

When start a guest with --pass-fd, if the argument of --pass-fd is invalid, virsh will exit, but doesn't free the variable 'dom'. The valgrind said: ... ==24569== 63 (56 direct, 7 indirect) bytes in 1 blocks are definitely lost in loss record 130 of 234 ==24569== at 0x4C2A1D4: calloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==24569== by 0x4E879A4: virAllocVar (viralloc.c:544) ==24569== by 0x4EBD625: virObjectNew (virobject.c:190) ==24569== by 0x4F3A18A: virGetDomain (datatypes.c:226) ==24569== by 0x4F9311F: remoteDomainLookupByName (remote_driver.c:6636) ==24569== by 0x4F44F20: virDomainLookupByName (libvirt.c:2277) ==24569== by 0x12F616: vshCommandOptDomainBy (virsh-domain.c:105) ==24569== by 0x131C79: cmdStart (virsh-domain.c:3330) ==24569== by 0x12C4AB: vshCommandRun (virsh.c:1752) ==24569== by 0x127001: main (virsh.c:3218) https://bugzilla.redhat.com/show_bug.cgi?id=1067338 Signed-off-by: Jincheng Miao <jmiao(a)redhat.com> --- tools/virsh-domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index c3db94c..57653a2 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -3428,11 +3428,11 @@ cmdStart(vshControl *ctl, const vshCmd *cmd) if (virDomainGetID(dom) != (unsigned int)-1) { vshError(ctl, "%s", _("Domain is already active")); virDomainFree(dom); - return false; + goto cleanup; } if (cmdStartGetFDs(ctl, cmd, &nfds, &fds) < 0) - return false; + goto cleanup; if (vshCommandOptBool(cmd, "paused")) flags |= VIR_DOMAIN_START_PAUSED; -- 1.8.5.3

2 2

[libvirt] [PATCH] maint: update to latest gnulib
by Eric Blake 21 Feb '14

21 Feb '14

Among other things, gnulib now allows overriding of sed during 'make syntax-check'. * .gnulib: Update to latest, for maint.mk improvements. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Pushing under the maintainer rule, before we freeze. I still need to revive Roman's work on using $(SED) and/or portable sed constructs in our cfg.mk, but that can occur after freeze if necessary, while the hard part of the gnulib submodule should be done before freeze. * .gnulib d5fec6c...3f51bf4 (9): > maintainer-makefiles: use $(SED) for syntax check > update from texinfo > savedir: add sorting arg to savedir, streamsavedir; remove fdsavedir > autoupdate > update from texinfo > update from texinfo > file-type: add support for doors and other less-common file types > update from texinfo > autoupdate .gnulib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gnulib b/.gnulib index d5fec6c..3f51bf4 160000 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit d5fec6c22f03c6a73d62260c9ce091c10c0a9cbd +Subproject commit 3f51bf41c8be8b310f57caff371377414701d5cc -- 1.8.5.3

1 0

Re: [libvirt] [libvirt-users] event-test.py cannot detects domain shutdown
by Cole Robinson 21 Feb '14

21 Feb '14

On 02/18/2014 05:12 AM, Kim Larry wrote: > 2014년 2월 11일 오후 10:00에 Eric Blake <eblake(a)redhat.com> 작성: > >> On 02/11/2014 12:20 AM, Kim Larry wrote: >> >>>>> libvirtd version is 1.1.4 and using Xen for hypervisor. >>>> I'm not as familiar with the xen hypervisor as with qemu; it may just be >>>> the case that no one has coded the xen driver to send a shutdown event. >>>> At any rate, I can confirm that with the qemu driver, shutdown events >>>> are delivered. >> >>> It is a bit weird that all except shutdown event are coded... >>> If it is true, do I have to just wait? >> >> https://rwmj.wordpress.com/2010/11/08/want-help-dont-email-me-directly/ >> >> Or you could look into the source code and provide a patch; but >> discussing this on the list is a better way to get a reaction from >> someone familiar with the xen code. >> >> -- >> Eric Blake eblake redhat com +1-919-301-3266 >> Libvirt virtualization library http://libvirt.org > > > Ah, I forgot to add libvirt-users in Cc... sorry. > > The thing I found today is that if libvirt uses xend driver, shutdown events > are delivered, but if libvirt uses libxl drvier, doesn't show up anything. It > seems there are bugs on shutdown event, so I did dig into the libvirt source > briefly, but I couldn't find where libxl driver calls event callback. > > Any help will be greatly appreciated. Especially someone who is familiar with > xen code. > Jim, does this sound familiar? - Cole

2 4

[libvirt] [PATCH] libxl: always use libxlVmCleanupJob in shutdown thread
by Jim Fehlig 20 Feb '14

20 Feb '14

Commit e4a0e900 missed calling libxlVmCleanupJob in the shutdown handler when processing a reboot event. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- src/libxl/libxl_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index f7ca91c..9f87e71 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -393,7 +393,7 @@ libxlDomainShutdownThread(void *opaque) break; case LIBXL_SHUTDOWN_REASON_REBOOT: libxl_domain_destroy(ctx, vm->def->id, NULL); - libxlVmCleanup(driver, vm, VIR_DOMAIN_SHUTOFF_SHUTDOWN); + libxlVmCleanupJob(driver, vm, VIR_DOMAIN_SHUTOFF_SHUTDOWN); libxlVmStart(driver, vm, 0, -1); break; default: -- 1.8.1.4

2 2

[libvirt] [PATCH] qemu: adjust maxmem/maxvcpu computation
by Eric Blake 20 Feb '14

20 Feb '14

https://bugzilla.redhat.com/show_bug.cgi?id=1038363 If a domain has a different maximum for persistent and live maxmem or max vcpus, then it is possible to hit cases where libvirt refuses to adjust the current values or gets halfway through the adjustment before failing. Better is to determine up front if the change is possible for all requested flags. * src/qemu/qemu_driver.c (qemuDomainSetMemoryFlags): Compute correct maximum if both live and config are being set. (qemuDomainSetVcpusFlags): Likewise. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- src/qemu/qemu_driver.c | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index a0b3ce3..288b98b 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2242,8 +2242,16 @@ static int qemuDomainSetMemoryFlags(virDomainPtr dom, unsigned long newmem, } else { /* resize the current memory */ + unsigned long oldmax = 0; - if (newmem > vm->def->mem.max_balloon) { + if (flags & VIR_DOMAIN_AFFECT_LIVE) + oldmax = vm->def->mem.max_balloon; + if (flags & VIR_DOMAIN_AFFECT_CONFIG) { + if (!oldmax || oldmax > persistentDef->mem.max_balloon) + oldmax = persistentDef->mem.max_balloon; + } + + if (newmem > oldmax) { virReportError(VIR_ERR_INVALID_ARG, "%s", _("cannot set memory higher than max memory")); goto endjob; @@ -4121,6 +4129,7 @@ qemuDomainSetVcpusFlags(virDomainPtr dom, unsigned int nvcpus, virDomainDefPtr persistentDef; int ret = -1; bool maximum; + unsigned int maxvcpus = 0; virQEMUDriverConfigPtr cfg = NULL; virCapsPtr caps = NULL; qemuAgentCPUInfoPtr cpuinfo = NULL; @@ -4168,11 +4177,17 @@ qemuDomainSetVcpusFlags(virDomainPtr dom, unsigned int nvcpus, goto endjob; } - if (!maximum && nvcpus > vm->def->maxvcpus) { + if (flags & VIR_DOMAIN_AFFECT_LIVE) + maxvcpus = vm->def->maxvcpus; + if (flags & VIR_DOMAIN_AFFECT_CONFIG) { + if (!maxvcpus || maxvcpus > persistentDef->maxvcpus) + maxvcpus = persistentDef->maxvcpus; + } + if (!maximum && nvcpus > maxvcpus) { virReportError(VIR_ERR_INVALID_ARG, _("requested vcpus is greater than max allowable" " vcpus for the domain: %d > %d"), - nvcpus, vm->def->maxvcpus); + nvcpus, maxvcpus); goto endjob; } -- 1.8.5.3

2 3

[libvirt] [PATCH 0/4] add 'virsh event' and friends
by Eric Blake 20 Feb '14

20 Feb '14

Inspired by my work on qemu monitor events; Dan correctly argued that if we're going to expose those through virsh, we also need to expose regular events. Patch 5/4 still coming, which adds handlers for the remaining 15 domain event types. Eric Blake (4): virsh: common code for parsing --seconds virsh: common code for waiting for an event virsh: add event command, for lifecycle events virsh: add net-event command tools/virsh-domain.c | 410 +++++++++++++++++++++++++++++++++++++++++++------- tools/virsh-network.c | 171 ++++++++++++++++++++- tools/virsh.c | 186 ++++++++++++++++++++++- tools/virsh.h | 17 ++- tools/virsh.pod | 30 ++++ 5 files changed, 752 insertions(+), 62 deletions(-) -- 1.8.5.3

2 12

[libvirt] [PATCH] Rename virDomainGetRootFilesystem to virDomainGetFilesystemForTarget
by Daniel P. Berrange 20 Feb '14

20 Feb '14

The virDomainGetRootFilesystem method can be generalized to allow any filesystem path to be obtained. While doing this, start a new test case for purpose of testing various helper methods in the domain_conf.{c,h} files, such as this one. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- .gitignore | 1 + src/conf/domain_conf.c | 5 +- src/conf/domain_conf.h | 3 +- src/libvirt_private.syms | 2 +- src/lxc/lxc_container.c | 2 +- src/lxc/lxc_process.c | 2 +- tests/Makefile.am | 6 ++ tests/domainconfdata/getfilesystem.xml | 28 ++++++++ tests/domainconftest.c | 120 +++++++++++++++++++++++++++++++++ tests/testutils.c | 57 ++++++++++++++++ tests/testutils.h | 5 ++ 11 files changed, 225 insertions(+), 6 deletions(-) create mode 100644 tests/domainconfdata/getfilesystem.xml create mode 100644 tests/domainconftest.c diff --git a/.gitignore b/.gitignore index d5a6cf5..cbb3e8a 100644 --- a/.gitignore +++ b/.gitignore @@ -147,6 +147,7 @@ /tests/commandtest /tests/conftest /tests/cputest +/tests/domainconftest /tests/domainsnapshotxml2xmltest /tests/esxutilstest /tests/eventtest diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0079234..dd36026 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -17827,12 +17827,13 @@ virDiskNameToBusDeviceIndex(virDomainDiskDefPtr disk, } virDomainFSDefPtr -virDomainGetRootFilesystem(virDomainDefPtr def) +virDomainGetFilesystemForTarget(virDomainDefPtr def, + const char *path) { size_t i; for (i = 0; i < def->nfss; i++) { - if (STREQ(def->fss[i]->dst, "/")) + if (STREQ(def->fss[i]->dst, path)) return def->fss[i]; } diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 647d115..ea7f1a1 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2541,7 +2541,8 @@ int virDiskNameToBusDeviceIndex(virDomainDiskDefPtr disk, int *busIdx, int *devIdx); -virDomainFSDefPtr virDomainGetRootFilesystem(virDomainDefPtr def); +virDomainFSDefPtr virDomainGetFilesystemForTarget(virDomainDefPtr def, + const char *path); int virDomainFSIndexByName(virDomainDefPtr def, const char *name); int virDomainVideoDefaultType(const virDomainDef *def); int virDomainVideoDefaultRAM(const virDomainDef *def, int type); diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 2dbb8f8..a870e9c 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -225,7 +225,7 @@ virDomainFSTypeFromString; virDomainFSTypeToString; virDomainFSWrpolicyTypeFromString; virDomainFSWrpolicyTypeToString; -virDomainGetRootFilesystem; +virDomainGetFilesystemForTarget; virDomainGraphicsAuthConnectedTypeFromString; virDomainGraphicsAuthConnectedTypeToString; virDomainGraphicsDefFree; diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index c6bdc8c..c32b085 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -1823,7 +1823,7 @@ static int lxcContainerChild(void *data) if (lxcContainerSetID(vmDef) < 0) goto cleanup; - root = virDomainGetRootFilesystem(vmDef); + root = virDomainGetFilesystemForTarget(vmDef, "/"); if (argv->nttyPaths) { const char *tty = argv->ttyPaths[0]; diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c index cc9c1a2..f0190a0 100644 --- a/src/lxc/lxc_process.c +++ b/src/lxc/lxc_process.c @@ -934,7 +934,7 @@ virLXCProcessReadLogOutput(virDomainObjPtr vm, static int virLXCProcessEnsureRootFS(virDomainObjPtr vm) { - virDomainFSDefPtr root = virDomainGetRootFilesystem(vm->def); + virDomainFSDefPtr root = virDomainGetFilesystemForTarget(vm->def, "/"); if (root) return 0; diff --git a/tests/Makefile.am b/tests/Makefile.am index 568b7a0..90fb3a0 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -65,6 +65,7 @@ EXTRA_DIST = \ commanddata \ confdata \ cputestdata \ + domainconfdata \ domainschemadata \ domainschematest \ domainsnapshotschematest \ @@ -141,6 +142,7 @@ test_programs = virshtest sockettest \ virportallocatortest \ sysinfotest \ virstoragetest \ + domainconftest \ $(NULL) if WITH_REMOTE @@ -893,6 +895,10 @@ sysinfotest_SOURCES = \ sysinfotest.c testutils.h testutils.c sysinfotest_LDADD = $(LDADDS) +domainconftest_SOURCES = \ + domainconftest.c testutils.h testutils.c +domainconftest_LDADD = $(LDADDS) + fdstreamtest_SOURCES = \ fdstreamtest.c testutils.h testutils.c fdstreamtest_LDADD = $(LDADDS) diff --git a/tests/domainconfdata/getfilesystem.xml b/tests/domainconfdata/getfilesystem.xml new file mode 100644 index 0000000..2ee78b4 --- /dev/null +++ b/tests/domainconfdata/getfilesystem.xml @@ -0,0 +1,28 @@ +<domain type='test'> + <name>demo</name> + <uuid>8369f1ac-7e46-e869-4ca5-759d51478066</uuid> + <memory unit='KiB'>500000</memory> + <currentMemory unit='KiB'>500000</currentMemory> + <vcpu placement='static'>1</vcpu> + <os> + <type arch='x86_64'>hvm</type> + <init>/bin/sh</init> + </os> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <filesystem type='mount' accessmode='passthrough'> + <source dir='/'/> + <target dir='/'/> + </filesystem> + <filesystem type='mount' accessmode='passthrough'> + <source dir='/'/> + <target dir='/dev'/> + </filesystem> + <console type='pty'> + <target type='lxc' port='0'/> + </console> + </devices> +</domain> diff --git a/tests/domainconftest.c b/tests/domainconftest.c new file mode 100644 index 0000000..d38ef5c --- /dev/null +++ b/tests/domainconftest.c @@ -0,0 +1,120 @@ +/* + * Copyright (C) 2013 Red Hat, Inc. + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + * Author: Daniel P. Berrange <berrange(a)redhat.com> + */ + +#include <config.h> + +#include "testutils.h" +#include "virerror.h" +#include "viralloc.h" +#include "virlog.h" + +#include "domain_conf.h" + +#define VIR_FROM_THIS VIR_FROM_NONE + +static virCapsPtr caps; +static virDomainXMLOptionPtr xmlopt; + +struct testGetFilesystemData { + const char *filename; + const char *path; + bool expectEntry; +}; + +static int testGetFilesystem(const void *opaque) +{ + int ret = -1; + char *xmlData = NULL; + virDomainDefPtr def = NULL; + char *filename = NULL; + const struct testGetFilesystemData *data = opaque; + virDomainFSDefPtr fsdef; + + if (virAsprintf(&filename, "%s/domainconfdata/%s.xml", + abs_srcdir, data->filename) < 0) + goto cleanup; + + if (virtTestLoadFile(filename, &xmlData) < 0) + goto cleanup; + + if (!(def = virDomainDefParseString(xmlData, caps, xmlopt, + 1 << VIR_DOMAIN_VIRT_TEST, 0))) + goto cleanup; + + fsdef = virDomainGetFilesystemForTarget(def, + data->path); + if (!fsdef) { + if (data->expectEntry) { + fprintf(stderr, "Expected FS for path '%s' in '%s'\n", + data->path, filename); + goto cleanup; + } + } else { + if (!data->expectEntry) { + fprintf(stderr, "Unexpected FS for path '%s' in '%s'\n", + data->path, filename); + goto cleanup; + } + } + + ret = 0; + +cleanup: + virDomainDefFree(def); + VIR_FREE(xmlData); + VIR_FREE(filename); + return ret; +} + +static int +mymain(void) +{ + int ret = 0; + + if ((caps = virTestGenericCapsInit()) == NULL) + goto cleanup; + + if (!(xmlopt = virTestGenericDomainXMLConfInit())) + goto cleanup; + +#define DO_TEST_GET_FS(fspath, expect) \ + do { \ + struct testGetFilesystemData data = { \ + .filename = "getfilesystem", \ + .path = fspath, \ + .expectEntry = expect, \ + }; \ + if (virtTestRun("Get FS " fspath, testGetFilesystem, &data) < 0) \ + ret = -1; \ + } while (0) + + DO_TEST_GET_FS("/", true); + DO_TEST_GET_FS("/dev", true); + DO_TEST_GET_FS("/dev/pts", false); + DO_TEST_GET_FS("/doesnotexist", false); + + virObjectUnref(caps); + virObjectUnref(xmlopt); + + cleanup: + return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; +} + +VIRT_TEST_MAIN(mymain) diff --git a/tests/testutils.c b/tests/testutils.c index 32fe374..ac2a654 100644 --- a/tests/testutils.c +++ b/tests/testutils.c @@ -645,3 +645,60 @@ int virtTestClearLineRegex(const char *pattern, return 0; } + + +virCapsPtr virTestGenericCapsInit(void) +{ + virCapsPtr caps; + virCapsGuestPtr guest; + + if ((caps = virCapabilitiesNew(VIR_ARCH_X86_64, + 0, 0)) == NULL) + return NULL; + + if ((guest = virCapabilitiesAddGuest(caps, "hvm", VIR_ARCH_I686, + "/usr/bin/acme-virt", NULL, + 0, NULL)) == NULL) + goto error; + + if (!virCapabilitiesAddGuestDomain(guest, "test", NULL, NULL, 0, NULL)) + goto error; + + + if ((guest = virCapabilitiesAddGuest(caps, "hvm", VIR_ARCH_X86_64, + "/usr/bin/acme-virt", NULL, + 0, NULL)) == NULL) + goto error; + + if (!virCapabilitiesAddGuestDomain(guest, "test", NULL, NULL, 0, NULL)) + goto error; + + + if (virTestGetDebug()) { + char *caps_str; + + caps_str = virCapabilitiesFormatXML(caps); + if (!caps_str) + goto error; + + fprintf(stderr, "Generic driver capabilities:\n%s", caps_str); + + VIR_FREE(caps_str); + } + + return caps; + +error: + virObjectUnref(caps); + return NULL; +} + +static virDomainDefParserConfig virTestGenericDomainDefParserConfig; +static virDomainXMLPrivateDataCallbacks virTestGenericPrivateDataCallbacks; + +virDomainXMLOptionPtr virTestGenericDomainXMLConfInit(void) +{ + return virDomainXMLOptionNew(&virTestGenericDomainDefParserConfig, + &virTestGenericPrivateDataCallbacks, + NULL); +} diff --git a/tests/testutils.h b/tests/testutils.h index 674d3df..8d2048b 100644 --- a/tests/testutils.h +++ b/tests/testutils.h @@ -27,6 +27,8 @@ # include "viralloc.h" # include "virfile.h" # include "virstring.h" +# include "capabilities.h" +# include "domain_conf.h" # define EXIT_AM_SKIP 77 /* tell Automake we're skipping a test */ # define EXIT_AM_HARDFAIL 99 /* tell Automake that the framework is broken */ @@ -102,4 +104,7 @@ int virtTestMain(int argc, return virtTestMain(argc, argv, func); \ } +virCapsPtr virTestGenericCapsInit(void); +virDomainXMLOptionPtr virTestGenericDomainXMLConfInit(void); + #endif /* __VIT_TEST_UTILS_H__ */ -- 1.8.4.2

2 2

[libvirt] help debugging event timing
by Eric Blake 20 Feb '14

20 Feb '14

In my recent work on events, I'm running into something where I'm stumped on timing behavior. I'm using virEventRegisterDefaultImpl()/virEventRunDefaultImpl() as my event loop, and trying to test that an event is firing correctly. With the test:///default (or any other local URI), if I register an event callback function, the callback gets invoked almost right after the event happens. This is the same behavior under test in our testsuite (in objecteventtest.c). But with qemu:///system (or any other remote URI), when I register an event callback function, my callback does not get invoked until I make some other RPC call on the connection. At first, I thought the events were not being wired up at all, and that I was just blocking forever because I missed something, but while stepping through gdb on the client side, I noticed that calling virConnectDomainEventDeregisterAny() in my shutdown code then indeed proceeded to go through the entire backlog of events that had been generated, but at that point I was no longer registered so my callback was not called. So I ended up using virEventAddTimeout() to set up a periodic interrupt (at 10 seconds, slow enough to see the delays), where in the handler I called virConnectGetLibVersion() as a way to force RPC traffic and at least get events as a result of my timer. If it matters, I was initially using keepalive_interval=-1 in /etc/libvirt/libvirtd.conf in order to avoid killing my debug sessions; but even when I switched to keepalive_interval=3, I'm still seeing the same delayed behavior (if the keepalive were to make a difference, I would have expected seeing the event at 3 seconds instead of my timer at 10 seconds). I thought that the RPC protocol was supposed to allow asynchronous events, and with minimal downtime. gdb in libvirtd says that remoteDispatchObjectEventSend() is called in a timely manner, but that merely queues things up, and I got lost trying to follow where virNetSocketUpdateIOCallback() turned into something that wakes up the actual write() to the socket. On the other side, I don't see a call to virDomainEventDispatchDefaultFunc() which then calls my callback until the next RPC call/response, but again, I got lost on trying to trace whether a read() of the socket was getting data in a timely manner but just not firing anything in my event loop, or whether things were getting stuck client side after the read but with nothing waking up my event loop. Any advice on how to better debug where things are getting stuck, to determine whether the holdup is in the server not sending or in the client not being responsive to the send? Is it something where systemtap might give me a better picture? Or better yet, a patch to fix the problem would be nice. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org

2 2

[libvirt] [PATCH] Fix multiple bugs in LXC domainMemoryStats driver
by Daniel P. Berrange 20 Feb '14

20 Feb '14

The virCgroupXXX APIs' return value must be checked for being less than 0, not equal to 0. An VIR_ERR_OPERATION_INVALID error must also be raised when the VM is not running to prevent a crash on NULL priv->cgroup field. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- src/lxc/lxc_driver.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index 50910df..10e0fbb 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -5410,13 +5410,16 @@ lxcDomainMemoryStats(virDomainPtr dom, if (virDomainMemoryStatsEnsureACL(dom->conn, vm->def) < 0) goto cleanup; - if (!virCgroupGetMemSwapUsage(priv->cgroup, &swap_usage)) + if (!virDomainObjIsActive(vm)) { + virReportError(VIR_ERR_OPERATION_INVALID, "%s", + _("domain is not active")); goto cleanup; + } - if (!virCgroupGetMemoryUsage(priv->cgroup, &mem_usage)) + if (virCgroupGetMemSwapUsage(priv->cgroup, &swap_usage) < 0) goto cleanup; - if (!virDomainObjIsActive(vm)) + if (virCgroupGetMemoryUsage(priv->cgroup, &mem_usage) < 0) goto cleanup; ret = 0; -- 1.8.5.3

2 1

[libvirt] [PATCH glib] gobject-stream: fix issue found by coverity
by Pavel Hrdina 20 Feb '14

20 Feb '14

The coverity server found issue in gvir_stream_close function that we ignore return values of g_input_stream_close and g_outpu_stream_close, but we also ignore the error message and we assume that it's closed without error. Now we will check return values and also propagate the error message to the upper layers. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- libvirt-gobject/libvirt-gobject-stream.c | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/libvirt-gobject/libvirt-gobject-stream.c b/libvirt-gobject/libvirt-gobject-stream.c index 1572022..66a12ab 100644 --- a/libvirt-gobject/libvirt-gobject-stream.c +++ b/libvirt-gobject/libvirt-gobject-stream.c @@ -102,17 +102,33 @@ static GOutputStream* gvir_stream_get_output_stream(GIOStream *io_stream) static gboolean gvir_stream_close(GIOStream *io_stream, GCancellable *cancellable, - G_GNUC_UNUSED GError **error) + GError **error) { GVirStream *self = GVIR_STREAM(io_stream); + GError *local_error = NULL; + gboolean i_ret = TRUE, o_ret = TRUE; if (self->priv->input_stream) - g_input_stream_close(self->priv->input_stream, cancellable, NULL); + i_ret = g_input_stream_close(self->priv->input_stream, cancellable, &local_error); + + if (local_error) { + if (!*error) + g_propagate_error(error, local_error); + else + g_error_free(local_error); + } if (self->priv->output_stream) - g_output_stream_close(self->priv->output_stream, cancellable, NULL); + o_ret = g_output_stream_close(self->priv->output_stream, cancellable, &local_error); + + if (local_error) { + if (!*error) + g_propagate_error(error, local_error); + else + g_error_free(local_error); + } - return TRUE; /* FIXME: really close the stream? */ + return (i_ret && o_ret); } -- 1.8.3.1

2 3

[libvirt] 1.2.0 segfault on Centos 6
by Franky Van Liedekerke 20 Feb '14

20 Feb '14

Hi, using libvirt 1.2.0 on a up-to-date Centos6.5 machine leads to occasional segmentation faults (see below). Sometimes it runs for 5 minutes, sometimes for an hour, but after that the result is always the same: segfault after some weird qom-list, that apparently the qemu version on centos doesn't know. Has 1.2.1 a known fix for this? Franky (debug log of last crash is below the dotted line) ------------------------------------------------- 2014-02-04 15:50:27.351+0000: 9082: error : qemuMonitorJSONCheckError:354 : internal error: unable to execute QEMU command 'qom-list': The command qom-list has not been found Caught Segmentation violation dumping internal log buffer: ====== start of log ===== +0000: 9084: debug : virObjectRef:293 : OBJECT_REF: obj=0x7fac58000ac0 2014-02-04 15:50:27.347+0000: 9084: debug : virObjectRef:293 : OBJECT_REF: obj=0x7fac58000ac0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventRunDefaultImpl:271 : running default event implementation 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollCleanupTimeouts:517 : Cleanup 5 2014-02-04 15:50:27.347+0000: 9084: debug : remoteDispatchDomainLookupByNameHelper:4965 : server=0x7fac7ce77ae0 client=0x7fac7ce86610 msg=0x7fac7ce827f0 rerr=0x7fac6c5b3bc0 args=0x7fac40002730 ret=0x7fac40002790 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollCleanupHandles:565 : Cleanup 15 2014-02-04 15:50:27.347+0000: 9084: debug : virDomainLookupByName:2269 : conn=0x7fac340018a0, name=bqafm0001ap.frm.meshcore.net 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=0 w=1, f=5 e=1 d=0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=1 w=2, f=7 e=1 d=0 2014-02-04 15:50:27.347+0000: 9084: debug : virObjectRef:293 : OBJECT_REF: obj=0x7fac7ce760b0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=2 w=3, f=12 e=1 d=0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=3 w=4, f=13 e=1 d=0 2014-02-04 15:50:27.347+0000: 9084: debug : virAccessManagerCheckDomain:231 : manager=0x7fac7ce760b0(name=stack) driver=QEMU domain=0x7fac5c2386c0 perm=0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=4 w=5, f=14 e=1 d=0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=5 w=6, f=15 e=1 d=0 2014-02-04 15:50:27.347+0000: 9084: debug : virAccessManagerCheckDomain:231 : manager=0x7fac7ce776f0(name=none) driver=QEMU domain=0x7fac5c2386c0 perm=0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=6 w=7, f=16 e=1 d=0 2014-02-04 15:50:27.347+0000: 9084: debug : virObjectUnref:256 : OBJECT_UNREF: obj=0x7fac7ce760b0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=7 w=8, f=17 e=1 d=0 2014-02-04 15:50:27.347+0000: 9084: debug : virObjectNew:199 : OBJECT_NEW: obj=0x7fac40002750 classname=virDomain 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=8 w=9, f=19 e=1 d=0 2014-02-04 15:50:27.347+0000: 9084: debug : virObjectRef:293 : OBJECT_REF: obj=0x7fac340018a0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=9 w=10, f=23 e=25 d=0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=10 w=11, f=25 e=25 d=0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=11 w=12, f=24 e=25 d=0 2014-02-04 15:50:27.347+0000: 9084: debug : virDomainFree:2433 : dom=0x7fac40002750, (VM: name=bqafm0001ap.frm.meshcore.net, uuid=3b009e73-e095-29fa-8970-f5c2b647d5a0) 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=12 w=13, f=26 e=25 d=0 2014-02-04 15:50:27.347+0000: 9084: debug : virObjectUnref:256 : OBJECT_UNREF: obj=0x7fac40002750 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=13 w=14, f=27 e=1 d=0 2014-02-04 15:50:27.347+0000: 9084: debug : virObjectUnref:258 : OBJECT_DISPOSE: obj=0x7fac40002750 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=14 w=58, f=28 e=1 d=0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollCalculateTimeout:332 : Calculate expiry of 5 timers 2014-02-04 15:50:27.347+0000: 9084: debug : virDomainDispose:264 : release domain 0x7fac40002750 bqafm0001ap.frm.meshcore.net 3b009e73-e095-29fa-8970-f5c2b647d5a0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollCalculateTimeout:340 : Got a timeout scheduled for 1391529031312 2014-02-04 15:50:27.347+0000: 9084: debug : virObjectUnref:256 : OBJECT_UNREF: obj=0x7fac340018a0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollCalculateTimeout:340 : Got a timeout scheduled for 1391529032347 2014-02-04 15:50:27.347+0000: 9084: debug : virObjectUnref:256 : OBJECT_UNREF: obj=0x7fac58000ac0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollCalculateTimeout:353 : Schedule timeout then=1391529031312 now=1391529027347 2014-02-04 15:50:27.347+0000: 9084: debug : virNetMessageEncodePayload:374 : Encode length as 80 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollCalculateTimeout:362 : Timeout at 1391529031312 due in 3965 ms 2014-02-04 15:50:27.347+0000: 9084: debug : virObjectUnref:256 : OBJECT_UNREF: obj=0x7fac58000ac0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollRunOnce:630 : EVENT_POLL_RUN: nhandles=15 timeout=3965 2014-02-04 15:50:27.347+0000: 9084: debug : virNetServerClientSendMessageLocked:1451 : msg=0x7fac7ce827f0 proc=23 len=80 offset=0 2014-02-04 15:50:27.347+0000: 9084: debug : virNetServerClientSendMessageLocked:1459 : RPC_SERVER_CLIENT_MSG_TX_QUEUE: client=0x7fac7ce86610 len=80 prog=536903814 vers=1 proc=23 type=1 status=0 serial=4 2014-02-04 15:50:27.347+0000: 9084: debug : virNetServerClientCalculateHandleMode:153 : tls=(nil) hs=-1, rx=0x7fac7ce86c80 tx=0x7fac7ce827f0 2014-02-04 15:50:27.347+0000: 9084: debug : virNetServerClientCalculateHandleMode:188 : mode=3 2014-02-04 15:50:27.347+0000: 9084: debug : virEventPollUpdateHandle:147 : EVENT_POLL_UPDATE_HANDLE: watch=58 events=3 2014-02-04 15:50:27.347+0000: 9084: debug : virEventPollInterruptLocked:717 : Interrupting 2014-02-04 15:50:27.347+0000: 9084: debug : virObjectUnref:256 : OBJECT_UNREF: obj=0x7fac7ce80030 2014-02-04 15:50:27.347+0000: 9084: debug : virObjectUnref:256 : OBJECT_UNREF: obj=0x7fac7ce86610 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollRunOnce:641 : Poll got 1 event(s) 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollDispatchTimeouts:426 : Dispatch 5 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollDispatchHandles:471 : Dispatch 15 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollDispatchHandles:485 : i=0 w=1 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollDispatchHandles:499 : EVENT_POLL_DISPATCH_HANDLE: watch=1 events=1 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollDispatchHandles:485 : i=1 w=2 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollDispatchHandles:485 : i=2 w=3 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollDispatchHandles:485 : i=3 w=4 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollDispatchHandles:485 : i=4 w=5 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollDispatchHandles:485 : i=5 w=6 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollDispatchHandles:485 : i=6 w=7 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollDispatchHandles:485 : i=7 w=8 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollDispatchHandles:485 : i=8 w=9 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollDispatchHandles:485 : i=9 w=10 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollDispatchHandles:485 : i=10 w=11 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollDispatchHandles:485 : i=11 w=12 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollDispatchHandles:485 : i=12 w=13 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollDispatchHandles:485 : i=13 w=14 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollDispatchHandles:485 : i=14 w=58 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollCleanupTimeouts:517 : Cleanup 5 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollCleanupHandles:565 : Cleanup 15 2014-02-04 15:50:27.347+0000: 9081: debug : virEventRunDefaultImpl:271 : running default event implementation 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollCleanupTimeouts:517 : Cleanup 5 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollCleanupHandles:565 : Cleanup 15 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=0 w=1, f=5 e=1 d=0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=1 w=2, f=7 e=1 d=0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=2 w=3, f=12 e=1 d=0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=3 w=4, f=13 e=1 d=0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=4 w=5, f=14 e=1 d=0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=5 w=6, f=15 e=1 d=0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=6 w=7, f=16 e=1 d=0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=7 w=8, f=17 e=1 d=0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=8 w=9, f=19 e=1 d=0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=9 w=10, f=23 e=25 d=0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=10 w=11, f=25 e=25 d=0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=11 w=12, f=24 e=25 d=0 2014-02-04 15:50:27.347+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=12 w=13, f=26 e=25 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=13 w=14, f=27 e=1 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=14 w=58, f=28 e=5 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCalculateTimeout:332 : Calculate expiry of 5 timers 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCalculateTimeout:340 : Got a timeout scheduled for 1391529031312 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCalculateTimeout:340 : Got a timeout scheduled for 1391529032347 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCalculateTimeout:353 : Schedule timeout then=1391529031312 now=1391529027348 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCalculateTimeout:362 : Timeout at 1391529031312 due in 3964 ms 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollRunOnce:630 : EVENT_POLL_RUN: nhandles=15 timeout=3964 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollRunOnce:641 : Poll got 1 event(s) 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchTimeouts:426 : Dispatch 5 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:471 : Dispatch 15 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=0 w=1 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=1 w=2 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=2 w=3 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=3 w=4 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=4 w=5 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=5 w=6 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=6 w=7 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=7 w=8 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=8 w=9 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=9 w=10 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=10 w=11 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=11 w=12 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=12 w=13 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=13 w=14 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=14 w=58 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:499 : EVENT_POLL_DISPATCH_HANDLE: watch=58 events=2 2014-02-04 15:50:27.348+0000: 9081: debug : virNetMessageFree:72 : msg=0x7fac7ce827f0 nfds=0 cb=(nil) 2014-02-04 15:50:27.348+0000: 9081: debug : virNetServerClientCalculateHandleMode:153 : tls=(nil) hs=-1, rx=0x7fac7ce86c80 tx=(nil) 2014-02-04 15:50:27.348+0000: 9081: debug : virNetServerClientCalculateHandleMode:188 : mode=1 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollUpdateHandle:147 : EVENT_POLL_UPDATE_HANDLE: watch=58 events=1 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollInterruptLocked:713 : Skip interrupt, 1 140378773645312 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCleanupTimeouts:517 : Cleanup 5 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCleanupHandles:565 : Cleanup 15 2014-02-04 15:50:27.348+0000: 9081: debug : virEventRunDefaultImpl:271 : running default event implementation 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCleanupTimeouts:517 : Cleanup 5 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCleanupHandles:565 : Cleanup 15 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=0 w=1, f=5 e=1 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=1 w=2, f=7 e=1 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=2 w=3, f=12 e=1 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=3 w=4, f=13 e=1 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=4 w=5, f=14 e=1 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=5 w=6, f=15 e=1 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=6 w=7, f=16 e=1 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=7 w=8, f=17 e=1 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=8 w=9, f=19 e=1 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=9 w=10, f=23 e=25 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=10 w=11, f=25 e=25 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=11 w=12, f=24 e=25 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=12 w=13, f=26 e=25 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=13 w=14, f=27 e=1 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=14 w=58, f=28 e=1 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCalculateTimeout:332 : Calculate expiry of 5 timers 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCalculateTimeout:340 : Got a timeout scheduled for 1391529031312 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCalculateTimeout:340 : Got a timeout scheduled for 1391529032347 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCalculateTimeout:353 : Schedule timeout then=1391529031312 now=1391529027348 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCalculateTimeout:362 : Timeout at 1391529031312 due in 3964 ms 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollRunOnce:630 : EVENT_POLL_RUN: nhandles=15 timeout=3964 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollRunOnce:641 : Poll got 1 event(s) 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchTimeouts:426 : Dispatch 5 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:471 : Dispatch 15 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=0 w=1 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=1 w=2 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=2 w=3 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=3 w=4 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=4 w=5 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=5 w=6 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=6 w=7 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=7 w=8 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=8 w=9 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=9 w=10 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=10 w=11 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=11 w=12 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=12 w=13 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=13 w=14 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=14 w=58 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:499 : EVENT_POLL_DISPATCH_HANDLE: watch=58 events=1 2014-02-04 15:50:27.348+0000: 9081: debug : virNetMessageDecodeLength:149 : Got length, now need 80 total (76 more) 2014-02-04 15:50:27.348+0000: 9081: debug : virNetServerClientCalculateHandleMode:153 : tls=(nil) hs=-1, rx=0x7fac7ce86c80 tx=(nil) 2014-02-04 15:50:27.348+0000: 9081: debug : virNetServerClientCalculateHandleMode:188 : mode=1 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollUpdateHandle:147 : EVENT_POLL_UPDATE_HANDLE: watch=58 events=1 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollInterruptLocked:713 : Skip interrupt, 1 140378773645312 2014-02-04 15:50:27.348+0000: 9081: debug : virNetServerClientDispatchRead:1202 : RPC_SERVER_CLIENT_MSG_RX: client=0x7fac7ce86610 len=80 prog=536903814 vers=1 proc=150 type=0 status=0 serial=5 2014-02-04 15:50:27.348+0000: 9081: debug : virKeepAliveCheckMessage:374 : ka=0x7fac7ce86d60, client=0x7fac7ce86610, msg=0x7fac7ce86c80 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollUpdateTimeout:260 : EVENT_POLL_UPDATE_TIMEOUT: timer=59 frequency=5000 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollUpdateTimeout:278 : Set timer freq=5000 expires=1391529032348 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollInterruptLocked:713 : Skip interrupt, 1 140378773645312 2014-02-04 15:50:27.348+0000: 9081: debug : virObjectRef:293 : OBJECT_REF: obj=0x7fac7ce86610 2014-02-04 15:50:27.348+0000: 9081: debug : virNetServerDispatchNewMessage:213 : server=0x7fac7ce77ae0 client=0x7fac7ce86610 message=0x7fac7ce86c80 2014-02-04 15:50:27.348+0000: 9081: debug : virObjectRef:293 : OBJECT_REF: obj=0x7fac7ce80030 2014-02-04 15:50:27.348+0000: 9081: debug : virNetMessageNew:44 : msg=0x7fac7ce86e60 tracked=1 2014-02-04 15:50:27.348+0000: 9081: debug : virNetServerClientCalculateHandleMode:153 : tls=(nil) hs=-1, rx=0x7fac7ce86e60 tx=(nil) 2014-02-04 15:50:27.348+0000: 9083: debug : virNetServerHandleJob:184 : server=0x7fac7ce77ae0 client=0x7fac7ce86610 message=0x7fac7ce86c80 prog=0x7fac7ce80030 2014-02-04 15:50:27.348+0000: 9081: debug : virNetServerClientCalculateHandleMode:188 : mode=1 2014-02-04 15:50:27.348+0000: 9083: debug : virNetServerProgramDispatch:285 : prog=536903814 ver=1 type=0 status=0 serial=5 proc=150 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollUpdateHandle:147 : EVENT_POLL_UPDATE_HANDLE: watch=58 events=1 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollInterruptLocked:713 : Skip interrupt, 1 140378773645312 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCleanupTimeouts:517 : Cleanup 5 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCleanupHandles:565 : Cleanup 15 2014-02-04 15:50:27.348+0000: 9083: debug : virObjectRef:293 : OBJECT_REF: obj=0x7fac58000ac0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventRunDefaultImpl:271 : running default event implementation 2014-02-04 15:50:27.348+0000: 9083: debug : virObjectRef:293 : OBJECT_REF: obj=0x7fac58000ac0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCleanupTimeouts:517 : Cleanup 5 2014-02-04 15:50:27.348+0000: 9083: debug : remoteDispatchDomainIsActiveHelper:4723 : server=0x7fac7ce77ae0 client=0x7fac7ce86610 msg=0x7fac7ce86c80 rerr=0x7fac6cfb4bc0 args=0x7fac50000970 ret=0x7fac50000910 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCleanupHandles:565 : Cleanup 15 2014-02-04 15:50:27.348+0000: 9083: debug : virObjectNew:199 : OBJECT_NEW: obj=0x7fac50000930 classname=virDomain 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=0 w=1, f=5 e=1 d=0 2014-02-04 15:50:27.348+0000: 9083: debug : virObjectRef:293 : OBJECT_REF: obj=0x7fac340018a0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=1 w=2, f=7 e=1 d=0 2014-02-04 15:50:27.348+0000: 9083: debug : virDomainIsActive:17649 : dom=0x7fac50000930 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=2 w=3, f=12 e=1 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=3 w=4, f=13 e=1 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=4 w=5, f=14 e=1 d=0 2014-02-04 15:50:27.348+0000: 9083: debug : virObjectRef:293 : OBJECT_REF: obj=0x7fac7ce760b0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=5 w=6, f=15 e=1 d=0 2014-02-04 15:50:27.348+0000: 9083: debug : virAccessManagerCheckDomain:231 : manager=0x7fac7ce760b0(name=stack) driver=QEMU domain=0x7fac5c2386c0 perm=1 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=6 w=7, f=16 e=1 d=0 2014-02-04 15:50:27.348+0000: 9083: debug : virAccessManagerCheckDomain:231 : manager=0x7fac7ce776f0(name=none) driver=QEMU domain=0x7fac5c2386c0 perm=1 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=7 w=8, f=17 e=1 d=0 2014-02-04 15:50:27.348+0000: 9083: debug : virObjectUnref:256 : OBJECT_UNREF: obj=0x7fac7ce760b0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=8 w=9, f=19 e=1 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=9 w=10, f=23 e=25 d=0 2014-02-04 15:50:27.348+0000: 9083: debug : virDomainFree:2433 : dom=0x7fac50000930, (VM: name=bqafm0001ap.frm.meshcore.net, uuid=3b009e73-e095-29fa-8970-f5c2b647d5a0) 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=10 w=11, f=25 e=25 d=0 2014-02-04 15:50:27.348+0000: 9083: debug : virObjectUnref:256 : OBJECT_UNREF: obj=0x7fac50000930 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=11 w=12, f=24 e=25 d=0 2014-02-04 15:50:27.348+0000: 9083: debug : virObjectUnref:258 : OBJECT_DISPOSE: obj=0x7fac50000930 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=12 w=13, f=26 e=25 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=13 w=14, f=27 e=1 d=0 2014-02-04 15:50:27.348+0000: 9083: debug : virDomainDispose:264 : release domain 0x7fac50000930 bqafm0001ap.frm.meshcore.net 3b009e73-e095-29fa-8970-f5c2b647d5a0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=14 w=58, f=28 e=1 d=0 2014-02-04 15:50:27.348+0000: 9083: debug : virObjectUnref:256 : OBJECT_UNREF: obj=0x7fac340018a0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCalculateTimeout:332 : Calculate expiry of 5 timers 2014-02-04 15:50:27.348+0000: 9083: debug : virObjectUnref:256 : OBJECT_UNREF: obj=0x7fac58000ac0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCalculateTimeout:340 : Got a timeout scheduled for 1391529031312 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCalculateTimeout:340 : Got a timeout scheduled for 1391529032348 2014-02-04 15:50:27.348+0000: 9083: debug : virNetMessageEncodePayload:374 : Encode length as 32 2014-02-04 15:50:27.348+0000: 9083: debug : virObjectUnref:256 : OBJECT_UNREF: obj=0x7fac58000ac0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCalculateTimeout:353 : Schedule timeout then=1391529031312 now=1391529027348 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCalculateTimeout:362 : Timeout at 1391529031312 due in 3964 ms 2014-02-04 15:50:27.348+0000: 9083: debug : virNetServerClientSendMessageLocked:1451 : msg=0x7fac7ce86c80 proc=150 len=32 offset=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollRunOnce:630 : EVENT_POLL_RUN: nhandles=15 timeout=3964 2014-02-04 15:50:27.348+0000: 9083: debug : virNetServerClientSendMessageLocked:1459 : RPC_SERVER_CLIENT_MSG_TX_QUEUE: client=0x7fac7ce86610 len=32 prog=536903814 vers=1 proc=150 type=1 status=0 serial=5 2014-02-04 15:50:27.348+0000: 9083: debug : virNetServerClientCalculateHandleMode:153 : tls=(nil) hs=-1, rx=0x7fac7ce86e60 tx=0x7fac7ce86c80 2014-02-04 15:50:27.348+0000: 9083: debug : virNetServerClientCalculateHandleMode:188 : mode=3 2014-02-04 15:50:27.348+0000: 9083: debug : virEventPollUpdateHandle:147 : EVENT_POLL_UPDATE_HANDLE: watch=58 events=3 2014-02-04 15:50:27.348+0000: 9083: debug : virEventPollInterruptLocked:717 : Interrupting 2014-02-04 15:50:27.348+0000: 9083: debug : virObjectUnref:256 : OBJECT_UNREF: obj=0x7fac7ce80030 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollRunOnce:641 : Poll got 1 event(s) 2014-02-04 15:50:27.348+0000: 9083: debug : virObjectUnref:256 : OBJECT_UNREF: obj=0x7fac7ce86610 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchTimeouts:426 : Dispatch 5 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:471 : Dispatch 15 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=0 w=1 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:499 : EVENT_POLL_DISPATCH_HANDLE: watch=1 events=1 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=1 w=2 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=2 w=3 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=3 w=4 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=4 w=5 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=5 w=6 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=6 w=7 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=7 w=8 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=8 w=9 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=9 w=10 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=10 w=11 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=11 w=12 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=12 w=13 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=13 w=14 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=14 w=58 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCleanupTimeouts:517 : Cleanup 5 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCleanupHandles:565 : Cleanup 15 2014-02-04 15:50:27.348+0000: 9081: debug : virEventRunDefaultImpl:271 : running default event implementation 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCleanupTimeouts:517 : Cleanup 5 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCleanupHandles:565 : Cleanup 15 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=0 w=1, f=5 e=1 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=1 w=2, f=7 e=1 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=2 w=3, f=12 e=1 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=3 w=4, f=13 e=1 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=4 w=5, f=14 e=1 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=5 w=6, f=15 e=1 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=6 w=7, f=16 e=1 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=7 w=8, f=17 e=1 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=8 w=9, f=19 e=1 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=9 w=10, f=23 e=25 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=10 w=11, f=25 e=25 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=11 w=12, f=24 e=25 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=12 w=13, f=26 e=25 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=13 w=14, f=27 e=1 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=14 w=58, f=28 e=5 d=0 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCalculateTimeout:332 : Calculate expiry of 5 timers 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCalculateTimeout:340 : Got a timeout scheduled for 1391529031312 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCalculateTimeout:340 : Got a timeout scheduled for 1391529032348 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCalculateTimeout:353 : Schedule timeout then=1391529031312 now=1391529027348 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollCalculateTimeout:362 : Timeout at 1391529031312 due in 3964 ms 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollRunOnce:630 : EVENT_POLL_RUN: nhandles=15 timeout=3964 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollRunOnce:641 : Poll got 1 event(s) 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchTimeouts:426 : Dispatch 5 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:471 : Dispatch 15 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=0 w=1 2014-02-04 15:50:27.348+0000: 9081: debug : virEventPollDispatchHandles:485 : i=1 w=2 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=2 w=3 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=3 w=4 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=4 w=5 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=5 w=6 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=6 w=7 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=7 w=8 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=8 w=9 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=9 w=10 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=10 w=11 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=11 w=12 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=12 w=13 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=13 w=14 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=14 w=58 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:499 : EVENT_POLL_DISPATCH_HANDLE: watch=58 events=2 2014-02-04 15:50:27.349+0000: 9081: debug : virNetMessageFree:72 : msg=0x7fac7ce86c80 nfds=0 cb=(nil) 2014-02-04 15:50:27.349+0000: 9081: debug : virNetServerClientCalculateHandleMode:153 : tls=(nil) hs=-1, rx=0x7fac7ce86e60 tx=(nil) 2014-02-04 15:50:27.349+0000: 9081: debug : virNetServerClientCalculateHandleMode:188 : mode=1 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollUpdateHandle:147 : EVENT_POLL_UPDATE_HANDLE: watch=58 events=1 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollInterruptLocked:713 : Skip interrupt, 1 140378773645312 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollCleanupTimeouts:517 : Cleanup 5 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollCleanupHandles:565 : Cleanup 15 2014-02-04 15:50:27.349+0000: 9081: debug : virEventRunDefaultImpl:271 : running default event implementation 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollCleanupTimeouts:517 : Cleanup 5 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollCleanupHandles:565 : Cleanup 15 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=0 w=1, f=5 e=1 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=1 w=2, f=7 e=1 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=2 w=3, f=12 e=1 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=3 w=4, f=13 e=1 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=4 w=5, f=14 e=1 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=5 w=6, f=15 e=1 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=6 w=7, f=16 e=1 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=7 w=8, f=17 e=1 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=8 w=9, f=19 e=1 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=9 w=10, f=23 e=25 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=10 w=11, f=25 e=25 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=11 w=12, f=24 e=25 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=12 w=13, f=26 e=25 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=13 w=14, f=27 e=1 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=14 w=58, f=28 e=1 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollCalculateTimeout:332 : Calculate expiry of 5 timers 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollCalculateTimeout:340 : Got a timeout scheduled for 1391529031312 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollCalculateTimeout:340 : Got a timeout scheduled for 1391529032348 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollCalculateTimeout:353 : Schedule timeout then=1391529031312 now=1391529027349 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollCalculateTimeout:362 : Timeout at 1391529031312 due in 3963 ms 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollRunOnce:630 : EVENT_POLL_RUN: nhandles=15 timeout=3963 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollRunOnce:641 : Poll got 1 event(s) 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchTimeouts:426 : Dispatch 5 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:471 : Dispatch 15 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=0 w=1 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=1 w=2 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=2 w=3 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=3 w=4 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=4 w=5 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=5 w=6 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=6 w=7 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=7 w=8 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=8 w=9 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=9 w=10 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=10 w=11 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=11 w=12 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=12 w=13 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=13 w=14 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=14 w=58 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:499 : EVENT_POLL_DISPATCH_HANDLE: watch=58 events=1 2014-02-04 15:50:27.349+0000: 9081: debug : virNetMessageDecodeLength:149 : Got length, now need 88 total (84 more) 2014-02-04 15:50:27.349+0000: 9081: debug : virNetServerClientCalculateHandleMode:153 : tls=(nil) hs=-1, rx=0x7fac7ce86e60 tx=(nil) 2014-02-04 15:50:27.349+0000: 9081: debug : virNetServerClientCalculateHandleMode:188 : mode=1 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollUpdateHandle:147 : EVENT_POLL_UPDATE_HANDLE: watch=58 events=1 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollInterruptLocked:713 : Skip interrupt, 1 140378773645312 2014-02-04 15:50:27.349+0000: 9081: debug : virNetServerClientDispatchRead:1202 : RPC_SERVER_CLIENT_MSG_RX: client=0x7fac7ce86610 len=88 prog=536903814 vers=1 proc=159 type=0 status=0 serial=6 2014-02-04 15:50:27.349+0000: 9081: debug : virKeepAliveCheckMessage:374 : ka=0x7fac7ce86d60, client=0x7fac7ce86610, msg=0x7fac7ce86e60 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollUpdateTimeout:260 : EVENT_POLL_UPDATE_TIMEOUT: timer=59 frequency=5000 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollUpdateTimeout:278 : Set timer freq=5000 expires=1391529032349 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollInterruptLocked:713 : Skip interrupt, 1 140378773645312 2014-02-04 15:50:27.349+0000: 9081: debug : virObjectRef:293 : OBJECT_REF: obj=0x7fac7ce86610 2014-02-04 15:50:27.349+0000: 9081: debug : virNetServerDispatchNewMessage:213 : server=0x7fac7ce77ae0 client=0x7fac7ce86610 message=0x7fac7ce86e60 2014-02-04 15:50:27.349+0000: 9081: debug : virObjectRef:293 : OBJECT_REF: obj=0x7fac7ce80030 2014-02-04 15:50:27.349+0000: 9081: debug : virNetMessageNew:44 : msg=0x7fac7ce78c60 tracked=1 2014-02-04 15:50:27.349+0000: 9081: debug : virNetServerClientCalculateHandleMode:153 : tls=(nil) hs=-1, rx=0x7fac7ce78c60 tx=(nil) 2014-02-04 15:50:27.349+0000: 9081: debug : virNetServerClientCalculateHandleMode:188 : mode=1 2014-02-04 15:50:27.349+0000: 9082: debug : virNetServerHandleJob:184 : server=0x7fac7ce77ae0 client=0x7fac7ce86610 message=0x7fac7ce86e60 prog=0x7fac7ce80030 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollUpdateHandle:147 : EVENT_POLL_UPDATE_HANDLE: watch=58 events=1 2014-02-04 15:50:27.349+0000: 9082: debug : virNetServerProgramDispatch:285 : prog=536903814 ver=1 type=0 status=0 serial=6 proc=159 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollInterruptLocked:713 : Skip interrupt, 1 140378773645312 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollCleanupTimeouts:517 : Cleanup 5 2014-02-04 15:50:27.349+0000: 9082: debug : virObjectRef:293 : OBJECT_REF: obj=0x7fac58000ac0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollCleanupHandles:565 : Cleanup 15 2014-02-04 15:50:27.349+0000: 9082: debug : virObjectRef:293 : OBJECT_REF: obj=0x7fac58000ac0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventRunDefaultImpl:271 : running default event implementation 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollCleanupTimeouts:517 : Cleanup 5 2014-02-04 15:50:27.349+0000: 9082: debug : remoteDispatchDomainMemoryStatsHelper:5195 : server=0x7fac7ce77ae0 client=0x7fac7ce86610 msg=0x7fac7ce86e60 rerr=0x7fac6d9b5bc0 args=0x7fac44000900 ret=0x7fac440009a0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollCleanupHandles:565 : Cleanup 15 2014-02-04 15:50:27.349+0000: 9082: debug : virObjectNew:199 : OBJECT_NEW: obj=0x7fac440008c0 classname=virDomain 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=0 w=1, f=5 e=1 d=0 2014-02-04 15:50:27.349+0000: 9082: debug : virObjectRef:293 : OBJECT_REF: obj=0x7fac340018a0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=1 w=2, f=7 e=1 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=2 w=3, f=12 e=1 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=3 w=4, f=13 e=1 d=0 2014-02-04 15:50:27.349+0000: 9082: debug : virDomainMemoryStats:8719 : dom=0x7fac440008c0, (VM: name=bqafm0001ap.frm.meshcore.net, uuid=3b009e73-e095-29fa-8970-f5c2b647d5a0), stats=0x7fac44000af0, nr_stats=8, flags=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=4 w=5, f=14 e=1 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=5 w=6, f=15 e=1 d=0 2014-02-04 15:50:27.349+0000: 9082: debug : virObjectRef:293 : OBJECT_REF: obj=0x7fac7ce760b0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=6 w=7, f=16 e=1 d=0 2014-02-04 15:50:27.349+0000: 9082: debug : virAccessManagerCheckDomain:231 : manager=0x7fac7ce760b0(name=stack) driver=QEMU domain=0x7fac5c2386c0 perm=1 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=7 w=8, f=17 e=1 d=0 2014-02-04 15:50:27.349+0000: 9082: debug : virAccessManagerCheckDomain:231 : manager=0x7fac7ce776f0(name=none) driver=QEMU domain=0x7fac5c2386c0 perm=1 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=8 w=9, f=19 e=1 d=0 2014-02-04 15:50:27.349+0000: 9082: debug : virObjectUnref:256 : OBJECT_UNREF: obj=0x7fac7ce760b0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=9 w=10, f=23 e=25 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=10 w=11, f=25 e=25 d=0 2014-02-04 15:50:27.349+0000: 9082: debug : virObjectRef:293 : OBJECT_REF: obj=0x7fac5c209c20 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=11 w=12, f=24 e=25 d=0 2014-02-04 15:50:27.349+0000: 9082: debug : qemuDomainObjBeginJobInternal:1024 : Starting job: query (async=none vm=0x7fac5c2141a0 name=bqafm0001ap.frm.meshcore.net) 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=12 w=13, f=26 e=25 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=13 w=14, f=27 e=1 d=0 2014-02-04 15:50:27.349+0000: 9082: debug : virObjectRef:293 : OBJECT_REF: obj=0x7fac5c2141a0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=14 w=58, f=28 e=1 d=0 2014-02-04 15:50:27.349+0000: 9082: debug : qemuDomainObjBeginJobInternal:1066 : Started job: query (async=none vm=0x7fac5c2141a0 name=bqafm0001ap.frm.meshcore.net) 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollCalculateTimeout:332 : Calculate expiry of 5 timers 2014-02-04 15:50:27.349+0000: 9082: debug : virObjectUnref:256 : OBJECT_UNREF: obj=0x7fac5c209c20 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollCalculateTimeout:340 : Got a timeout scheduled for 1391529031312 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollCalculateTimeout:340 : Got a timeout scheduled for 1391529032349 2014-02-04 15:50:27.349+0000: 9082: debug : qemuDomainObjEnterMonitorInternal:1252 : Entering monitor (mon=0x7fac54000c00 vm=0x7fac5c2141a0 name=bqafm0001ap.frm.meshcore.net) 2014-02-04 15:50:27.349+0000: 9082: debug : virObjectRef:293 : OBJECT_REF: obj=0x7fac54000c00 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollCalculateTimeout:353 : Schedule timeout then=1391529031312 now=1391529027349 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollCalculateTimeout:362 : Timeout at 1391529031312 due in 3963 ms 2014-02-04 15:50:27.349+0000: 9082: debug : qemuMonitorGetMemoryStats:1565 : mon=0x7fac54000c00 stats=0x7fac44000af0 nstats=8 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollRunOnce:630 : EVENT_POLL_RUN: nhandles=15 timeout=3963 2014-02-04 15:50:27.349+0000: 9082: debug : qemuMonitorFindBalloonObjectPath:1045 : Searching for Balloon Object Path starting at / 2014-02-04 15:50:27.349+0000: 9082: debug : virJSONValueToString:1106 : object=0x7fac44000a50 2014-02-04 15:50:27.349+0000: 9082: debug : virJSONValueToStringOne:1037 : object=0x7fac44000a50 type=0 gen=0x7fac44000d60 2014-02-04 15:50:27.349+0000: 9082: debug : virJSONValueToStringOne:1037 : object=0x7fac44000a70 type=2 gen=0x7fac44000d60 2014-02-04 15:50:27.349+0000: 9082: debug : virJSONValueToStringOne:1037 : object=0x7fac44000bf0 type=0 gen=0x7fac44000d60 2014-02-04 15:50:27.349+0000: 9082: debug : virJSONValueToStringOne:1037 : object=0x7fac44000c10 type=2 gen=0x7fac44000d60 2014-02-04 15:50:27.349+0000: 9082: debug : virJSONValueToStringOne:1037 : object=0x7fac44000ce0 type=2 gen=0x7fac44000d60 2014-02-04 15:50:27.349+0000: 9082: debug : virJSONValueToString:1139 : result={"execute":"qom-list","arguments":{"path":"/"},"id":"libvirt-6"} 2014-02-04 15:50:27.349+0000: 9082: debug : qemuMonitorJSONCommandWithFd:264 : Send command '{"execute":"qom-list","arguments":{"path":"/"},"id":"libvirt-6"}' for write with FD -1 2014-02-04 15:50:27.349+0000: 9082: debug : virEventPollUpdateHandle:147 : EVENT_POLL_UPDATE_HANDLE: watch=10 events=15 2014-02-04 15:50:27.349+0000: 9082: debug : virEventPollInterruptLocked:717 : Interrupting 2014-02-04 15:50:27.349+0000: 9082: debug : qemuMonitorSend:959 : QEMU_MONITOR_SEND_MSG: mon=0x7fac54000c00 msg={"execute":"qom-list","arguments":{"path":"/"},"id":"libvirt-6"} fd=-1 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollRunOnce:641 : Poll got 1 event(s) 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchTimeouts:426 : Dispatch 5 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:471 : Dispatch 15 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=0 w=1 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:499 : EVENT_POLL_DISPATCH_HANDLE: watch=1 events=1 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=1 w=2 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=2 w=3 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=3 w=4 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=4 w=5 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=5 w=6 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=6 w=7 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=7 w=8 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=8 w=9 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=9 w=10 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=10 w=11 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=11 w=12 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=12 w=13 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=13 w=14 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=14 w=58 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollCleanupTimeouts:517 : Cleanup 5 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollCleanupHandles:565 : Cleanup 15 2014-02-04 15:50:27.349+0000: 9081: debug : virEventRunDefaultImpl:271 : running default event implementation 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollCleanupTimeouts:517 : Cleanup 5 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollCleanupHandles:565 : Cleanup 15 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=0 w=1, f=5 e=1 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=1 w=2, f=7 e=1 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=2 w=3, f=12 e=1 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=3 w=4, f=13 e=1 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=4 w=5, f=14 e=1 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=5 w=6, f=15 e=1 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=6 w=7, f=16 e=1 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=7 w=8, f=17 e=1 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=8 w=9, f=19 e=1 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=9 w=10, f=23 e=29 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=10 w=11, f=25 e=25 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=11 w=12, f=24 e=25 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=12 w=13, f=26 e=25 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=13 w=14, f=27 e=1 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=14 w=58, f=28 e=1 d=0 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollCalculateTimeout:332 : Calculate expiry of 5 timers 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollCalculateTimeout:340 : Got a timeout scheduled for 1391529031312 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollCalculateTimeout:340 : Got a timeout scheduled for 1391529032349 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollCalculateTimeout:353 : Schedule timeout then=1391529031312 now=1391529027349 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollCalculateTimeout:362 : Timeout at 1391529031312 due in 3963 ms 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollRunOnce:630 : EVENT_POLL_RUN: nhandles=15 timeout=3963 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollRunOnce:641 : Poll got 1 event(s) 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchTimeouts:426 : Dispatch 5 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:471 : Dispatch 15 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=0 w=1 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=1 w=2 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=2 w=3 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=3 w=4 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=4 w=5 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=5 w=6 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=6 w=7 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=7 w=8 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=8 w=9 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=9 w=10 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:499 : EVENT_POLL_DISPATCH_HANDLE: watch=10 events=2 2014-02-04 15:50:27.349+0000: 9081: debug : virObjectRef:293 : OBJECT_REF: obj=0x7fac54000c00 2014-02-04 15:50:27.349+0000: 9081: debug : qemuMonitorIOWrite:504 : QEMU_MONITOR_IO_WRITE: mon=0x7fac54000c00 buf={"execute":"qom-list","arguments":{"path":"/"},"id":"libvirt-6"} len=66 ret=66 errno=22 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollUpdateHandle:147 : EVENT_POLL_UPDATE_HANDLE: watch=10 events=13 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollInterruptLocked:713 : Skip interrupt, 1 140378773645312 2014-02-04 15:50:27.349+0000: 9081: debug : virObjectUnref:256 : OBJECT_UNREF: obj=0x7fac54000c00 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=10 w=11 2014-02-04 15:50:27.349+0000: 9081: debug : virEventPollDispatchHandles:485 : i=11 w=12 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollDispatchHandles:485 : i=12 w=13 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollDispatchHandles:485 : i=13 w=14 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollDispatchHandles:485 : i=14 w=58 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollCleanupTimeouts:517 : Cleanup 5 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollCleanupHandles:565 : Cleanup 15 2014-02-04 15:50:27.350+0000: 9081: debug : virEventRunDefaultImpl:271 : running default event implementation 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollCleanupTimeouts:517 : Cleanup 5 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollCleanupHandles:565 : Cleanup 15 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=0 w=1, f=5 e=1 d=0 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=1 w=2, f=7 e=1 d=0 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=2 w=3, f=12 e=1 d=0 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=3 w=4, f=13 e=1 d=0 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=4 w=5, f=14 e=1 d=0 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=5 w=6, f=15 e=1 d=0 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=6 w=7, f=16 e=1 d=0 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=7 w=8, f=17 e=1 d=0 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=8 w=9, f=19 e=1 d=0 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=9 w=10, f=23 e=25 d=0 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=10 w=11, f=25 e=25 d=0 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=11 w=12, f=24 e=25 d=0 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=12 w=13, f=26 e=25 d=0 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=13 w=14, f=27 e=1 d=0 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=14 w=58, f=28 e=1 d=0 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollCalculateTimeout:332 : Calculate expiry of 5 timers 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollCalculateTimeout:340 : Got a timeout scheduled for 1391529031312 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollCalculateTimeout:340 : Got a timeout scheduled for 1391529032349 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollCalculateTimeout:353 : Schedule timeout then=1391529031312 now=1391529027350 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollCalculateTimeout:362 : Timeout at 1391529031312 due in 3962 ms 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollRunOnce:630 : EVENT_POLL_RUN: nhandles=15 timeout=3962 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollRunOnce:641 : Poll got 1 event(s) 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollDispatchTimeouts:426 : Dispatch 5 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollDispatchHandles:471 : Dispatch 15 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollDispatchHandles:485 : i=0 w=1 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollDispatchHandles:485 : i=1 w=2 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollDispatchHandles:485 : i=2 w=3 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollDispatchHandles:485 : i=3 w=4 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollDispatchHandles:485 : i=4 w=5 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollDispatchHandles:485 : i=5 w=6 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollDispatchHandles:485 : i=6 w=7 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollDispatchHandles:485 : i=7 w=8 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollDispatchHandles:485 : i=8 w=9 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollDispatchHandles:485 : i=9 w=10 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollDispatchHandles:499 : EVENT_POLL_DISPATCH_HANDLE: watch=10 events=1 2014-02-04 15:50:27.350+0000: 9081: debug : virObjectRef:293 : OBJECT_REF: obj=0x7fac54000c00 2014-02-04 15:50:27.350+0000: 9081: debug : qemuMonitorIOProcess:396 : QEMU_MONITOR_IO_PROCESS: mon=0x7fac54000c00 buf={"id": "libvirt-6", "error": {"class": "CommandNotFound", "desc": "The command qom-list has not been found", "data": {"name": "qom-list"}}} len=141 2014-02-04 15:50:27.350+0000: 9081: debug : qemuMonitorJSONIOProcessLine:157 : Line [{"id": "libvirt-6", "error": {"class": "CommandNotFound", "desc": "The command qom-list has not been found", "data": {"name": "qom-list"}}}] 2014-02-04 15:50:27.350+0000: 9081: debug : virJSONValueFromString:975 : string={"id": "libvirt-6", "error": {"class": "CommandNotFound", "desc": "The command qom-list has not been found", "data": {"name": "qom-list"}}} 2014-02-04 15:50:27.350+0000: 9081: debug : virJSONParserHandleStartMap:853 : parser=0x7fffd5667f70 2014-02-04 15:50:27.350+0000: 9081: debug : virJSONParserHandleMapKey:835 : parser=0x7fffd5667f70 key=0x7fac7ce78d42 2014-02-04 15:50:27.350+0000: 9081: debug : virJSONParserHandleString:815 : parser=0x7fffd5667f70 str=0x7fac7ce78d48 2014-02-04 15:50:27.350+0000: 9081: debug : virJSONParserHandleMapKey:835 : parser=0x7fffd5667f70 key=0x7fac7ce78d55 2014-02-04 15:50:27.350+0000: 9081: debug : virJSONParserHandleStartMap:853 : parser=0x7fffd5667f70 2014-02-04 15:50:27.350+0000: 9081: debug : virJSONParserHandleMapKey:835 : parser=0x7fffd5667f70 key=0x7fac7ce78d5f 2014-02-04 15:50:27.350+0000: 9081: debug : virJSONParserHandleString:815 : parser=0x7fffd5667f70 str=0x7fac7ce78d68 2014-02-04 15:50:27.350+0000: 9081: debug : virJSONParserHandleMapKey:835 : parser=0x7fffd5667f70 key=0x7fac7ce78d7b 2014-02-04 15:50:27.350+0000: 9081: debug : virJSONParserHandleString:815 : parser=0x7fffd5667f70 str=0x7fac7ce78d83 2014-02-04 15:50:27.350+0000: 9081: debug : virJSONParserHandleMapKey:835 : parser=0x7fffd5667f70 key=0x7fac7ce78dae 2014-02-04 15:50:27.350+0000: 9081: debug : virJSONParserHandleStartMap:853 : parser=0x7fffd5667f70 2014-02-04 15:50:27.350+0000: 9081: debug : virJSONParserHandleMapKey:835 : parser=0x7fffd5667f70 key=0x7fac7ce78db7 2014-02-04 15:50:27.350+0000: 9081: debug : virJSONParserHandleString:815 : parser=0x7fffd5667f70 str=0x7fac7ce78dbf 2014-02-04 15:50:27.350+0000: 9081: debug : virJSONParserHandleEndMap:881 : parser=0x7fffd5667f70 2014-02-04 15:50:27.350+0000: 9081: debug : virJSONParserHandleEndMap:881 : parser=0x7fffd5667f70 2014-02-04 15:50:27.350+0000: 9081: debug : virJSONParserHandleEndMap:881 : parser=0x7fffd5667f70 2014-02-04 15:50:27.350+0000: 9081: debug : virJSONValueFromString:1026 : result=0x7fac7ce6b9a0 2014-02-04 15:50:27.350+0000: 9081: debug : qemuMonitorJSONIOProcessLine:177 : QEMU_MONITOR_RECV_REPLY: mon=0x7fac54000c00 reply={"id": "libvirt-6", "error": {"class": "CommandNotFound", "desc": "The command qom-list has not been found", "data": {"name": "qom-list"}}} 2014-02-04 15:50:27.350+0000: 9081: debug : qemuMonitorJSONIOProcess:226 : Total used 141 bytes out of 141 available in buffer 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollUpdateHandle:147 : EVENT_POLL_UPDATE_HANDLE: watch=10 events=13 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollInterruptLocked:713 : Skip interrupt, 1 140378773645312 2014-02-04 15:50:27.350+0000: 9081: debug : virObjectUnref:256 : OBJECT_UNREF: obj=0x7fac54000c00 2014-02-04 15:50:27.350+0000: 9082: debug : virEventPollUpdateHandle:147 : EVENT_POLL_UPDATE_HANDLE: watch=10 events=13 2014-02-04 15:50:27.350+0000: 9081: debug : virEventPollDispatchHandles:485 : i=10 w=11 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollDispatchHandles:485 : i=11 w=12 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollDispatchHandles:485 : i=12 w=13 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollDispatchHandles:485 : i=13 w=14 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollDispatchHandles:485 : i=14 w=58 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollCleanupTimeouts:517 : Cleanup 5 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollCleanupHandles:565 : Cleanup 15 2014-02-04 15:50:27.351+0000: 9081: debug : virEventRunDefaultImpl:271 : running default event implementation 2014-02-04 15:50:27.351+0000: 9082: debug : virEventPollInterruptLocked:713 : Skip interrupt, 0 140378773645312 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollCleanupTimeouts:517 : Cleanup 5 2014-02-04 15:50:27.351+0000: 9082: debug : qemuMonitorJSONCommandWithFd:269 : Receive command reply ret=0 rxObject=0x7fac7ce6b9a0 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollCleanupHandles:565 : Cleanup 15 2014-02-04 15:50:27.351+0000: 9082: debug : virJSONValueToString:1106 : object=0x7fac44000a50 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=0 w=1, f=5 e=1 d=0 2014-02-04 15:50:27.351+0000: 9082: debug : virJSONValueToStringOne:1037 : object=0x7fac44000a50 type=0 gen=0x7fac44001000 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=1 w=2, f=7 e=1 d=0 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=2 w=3, f=12 e=1 d=0 2014-02-04 15:50:27.351+0000: 9082: debug : virJSONValueToStringOne:1037 : object=0x7fac44000a70 type=2 gen=0x7fac44001000 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=3 w=4, f=13 e=1 d=0 2014-02-04 15:50:27.351+0000: 9082: debug : virJSONValueToStringOne:1037 : object=0x7fac44000bf0 type=0 gen=0x7fac44001000 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=4 w=5, f=14 e=1 d=0 2014-02-04 15:50:27.351+0000: 9082: debug : virJSONValueToStringOne:1037 : object=0x7fac44000c10 type=2 gen=0x7fac44001000 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=5 w=6, f=15 e=1 d=0 2014-02-04 15:50:27.351+0000: 9082: debug : virJSONValueToStringOne:1037 : object=0x7fac44000ce0 type=2 gen=0x7fac44001000 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=6 w=7, f=16 e=1 d=0 2014-02-04 15:50:27.351+0000: 9082: debug : virJSONValueToString:1139 : result={"execute":"qom-list","arguments":{"path":"/"},"id":"libvirt-6"} 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=7 w=8, f=17 e=1 d=0 2014-02-04 15:50:27.351+0000: 9082: debug : virJSONValueToString:1106 : object=0x7fac7ce6b9a0 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=8 w=9, f=19 e=1 d=0 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=9 w=10, f=23 e=25 d=0 2014-02-04 15:50:27.351+0000: 9082: debug : virJSONValueToStringOne:1037 : object=0x7fac7ce6b9a0 type=0 gen=0x7fac44001000 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=10 w=11, f=25 e=25 d=0 2014-02-04 15:50:27.351+0000: 9082: debug : virJSONValueToStringOne:1037 : object=0x7fac7ce6b8a0 type=2 gen=0x7fac44001000 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=11 w=12, f=24 e=25 d=0 2014-02-04 15:50:27.351+0000: 9082: debug : virJSONValueToStringOne:1037 : object=0x7fac7ce67660 type=0 gen=0x7fac44001000 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=12 w=13, f=26 e=25 d=0 2014-02-04 15:50:27.351+0000: 9082: debug : virJSONValueToStringOne:1037 : object=0x7fac7ce83f30 type=2 gen=0x7fac44001000 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=13 w=14, f=27 e=1 d=0 2014-02-04 15:50:27.351+0000: 9082: debug : virJSONValueToStringOne:1037 : object=0x7fac7ce61930 type=2 gen=0x7fac44001000 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollMakePollFDs:394 : Prepare n=14 w=58, f=28 e=1 d=0 2014-02-04 15:50:27.351+0000: 9082: debug : virJSONValueToStringOne:1037 : object=0x7fac7ce6ce30 type=0 gen=0x7fac44001000 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollCalculateTimeout:332 : Calculate expiry of 5 timers 2014-02-04 15:50:27.351+0000: 9082: debug : virJSONValueToStringOne:1037 : object=0x7fac7ce80230 type=2 gen=0x7fac44001000 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollCalculateTimeout:340 : Got a timeout scheduled for 1391529031312 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollCalculateTimeout:340 : Got a timeout scheduled for 1391529032349 2014-02-04 15:50:27.351+0000: 9082: debug : virJSONValueToString:1139 : result={"id":"libvirt-6","error":{"class":"CommandNotFound","desc":"The command qom-list has not been found","data":{"name":"qom-list"}}} 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollCalculateTimeout:353 : Schedule timeout then=1391529031312 now=1391529027351 2014-02-04 15:50:27.351+0000: 9082: debug : qemuMonitorJSONCheckError:343 : unable to execute QEMU command {"execute":"qom-list","arguments":{"path":"/"},"id":"libvirt-6"}: {"id":"libvirt-6","error":{"class":"CommandNotFound","desc":"The command qom-list has not been found","data":{"name":"qom-list"}}} 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollCalculateTimeout:362 : Timeout at 1391529031312 due in 3961 ms 2014-02-04 15:50:27.351+0000: 9081: debug : virEventPollRunOnce:630 : EVENT_POLL_RUN: nhandles=15 timeout=3961 2014-02-04 15:50:27.351+0000: 9082: error : qemuMonitorJSONCheckError:354 : internal error: unable to execute QEMU command 'qom-list': The command qom-list has not been found ====== end of log ===== Segmentation fault (core dumped)

8 11

[libvirt] [PATCH v2] bandwidth: Adjust documentation
by John Ferlan 20 Feb '14

20 Feb '14

Recent autotest/virt-test testing on f20 discovered an anomaly in how the bandwidth options are documented and used. This was discovered due to a bug fix in the /sbin/tc utility found in iproute-3.11.0.1 (on f20) in which overflow was actually caught and returned as an error. The fix was first introduced in iproute-3.10 (search on iproute2 commit 'a303853e'). The autotest/virt-test test for virsh domiftune was attempting to send the largest unsigned integer value (4294967295) for maximum value testing. The libvirt xml implementation was designed to manage values in kilobytes thus when this value was passed to /sbin/tc, it (now) properly rejected the 4294967295kbps value. Investigation of the problem discovered that formatdomain.html.in and formatnetwork.html.in described the elements and property types slightly differently, although they use the same code - virNetDevBandwidthParseRate() (shared by portgroups, domains, and networks xml parsers). Rather than have the descriptions in two places, this patch will combine and reword the description under formatnetwork.html.in and have formatdomain.html.in link to that description. This documentation faux pas was continued into the virsh man page where the bandwidth description for both 'attach-interface' and 'domiftune' did not indicate the format of each value, thus leading to the test using largest unsigned integer value assuming "bps" rather than "kbps", which ultimately was wrong. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Changes since v1: -> Reflection and some private IRC validation results in changing to use "kilobyte" and not "kibibyte" -> Although the smallest unit is 1 kb/kbps, it's felt that things aren't headed in the going smaller direction, rather things are desired to be larger. So the inability to "test" the maximum of 4294967295 bps in favor of 4294967 kbps shouldn't really matter. docs/formatdomain.html.in | 35 +++----------------- docs/formatnetwork.html.in | 81 ++++++++++++++++++++++++++++++++++------------ tools/virsh.pod | 10 ++++-- 3 files changed, 73 insertions(+), 53 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 4660983..ea1a97b 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -3750,37 +3750,10 @@ qemu-kvm -net nic,model=? /dev/null <p> This part of interface XML provides setting quality of service. Incoming - and outgoing traffic can be shaped independently. The - <code>bandwidth</code> element can have at most one <code>inbound</code> - and at most one <code>outbound</code> child elements. Leaving any of these - children element out result in no QoS applied on that traffic direction. - So, when you want to shape only domain's incoming traffic, use - <code>inbound</code> only, and vice versa. Each of these elements have one - mandatory attribute <code>average</code> (or <code>floor</code> as - described below). <code>average</code> specifies average bit rate on - the interface being shaped. Then there are two optional attributes: - <code>peak</code>, which specifies maximum rate at which interface can send - data, and <code>burst</code>, amount of bytes that can be burst at - <code>peak</code> speed. Accepted values for attributes are integer - numbers. The units for <code>average</code> and <code>peak</code> attributes - are kilobytes per second, and for the <code>burst</code> just kilobytes. - Note the limitation of implementation: the <code>peak</code> attribute in - <code>outbound</code> element is ignored (as linux ingress filters don't - know it yet). <span class="since">Since 0.9.4</span> The <code>inbound</code> can - optionally have <code>floor</code> attribute. This is there for - guaranteeing minimal throughput for shaped interfaces. This, however, - requires that all traffic goes through one point where QoS decisions can - take place. That's why this attribute works only for virtual networks for - now (that is <code><interface type='network'/></code> with a - forward type of route, nat, or no forward at all). Moreover, the - virtual network the interface is connected to is required to have at least - inbound QoS set (<code>average</code> at least). Moreover, with - <code>floor</code> attribute users don't need to specify - <code>average</code>. However, <code>peak</code> and <code>burst</code> - attributes still require <code>average</code>. Currently, linux kernel - doesn't allow ingress qdiscs to have any classes therefore - <code>floor</code> can be applied only on <code>inbound</code> and not - <code>outbound</code>. <span class="since">Since 1.0.1</span> + and outgoing traffic can be shaped independently. + The <code>bandwidth</code> element and its child elements are described + in the <a href="formatnetwork.html#elementQoS">QoS</a> section of + the Network XML. </p> <h5><a name="elementVlanTag">Setting VLAN tag (on supported network types only)</a></h5> diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in index 1ca1bec..d4c390a 100644 --- a/docs/formatnetwork.html.in +++ b/docs/formatnetwork.html.in @@ -412,40 +412,81 @@ <p> The <code><bandwidth></code> element allows setting - quality of service for a particular network. - <span class="since">Since 0.9.4</span> The limits specified + quality of service for a particular network + (<span class="since">since 0.9.4</span>). For a <code>domain</code> + object, the limits specified are applied to the domain traffic. + For a <code>network</code> object, the limits specified are applied to the aggregate of all traffic to/from all guest interfaces attached to that network, <b>not</b> to each guest - interface individually. Setting <code>bandwidth</code> for a + interface individually. Setting <code>bandwidth</code> for a network is supported only for networks with a <code><forward></code> mode of <code>route</code>, <code>nat</code>, or no mode at all - (i.e. an "isolated" network). <code>bandwidth</code> setting + (i.e. an "isolated" network). Setting <code>bandwidth</code> is <b>not</b> supported for forward modes of <code>bridge</code>, <code>passthrough</code>, <code>private</code>, or <code>hostdev</code>, and attempts to do this will lead to - a failure to define the network (or to create a transient - network). + a failure to define the network (or to create a transient network). </p> <p> Incoming and outgoing traffic can be shaped independently. The - <code>bandwidth</code> element can have at most - one <code>inbound</code> and at most one <code>outbound</code> + <code>bandwidth</code> element can have at most one + <code>inbound</code> and at most one <code>outbound</code> child element. Leaving either of these children elements out results in no QoS applied for that traffic direction. So, - when you want to shape only a network's incoming traffic, use + when you want to shape only incoming traffic, use <code>inbound</code> only, and vice versa. Each of these - elements have one mandatory attribute - <code>average</code>, - which specifies the desired average bit rate for the interface - being shaped (in kibibytes/second). There are also two - optional attributes: <code>peak</code>, which specifies the - maximum rate at which the bridge can send data (again in - kibibytes/second), and <code>burst</code> - the amount of - bytes that can be transmitted in a single burst at - <code>peak</code> speed (in kibibytes). Accepted values for - attributes are integer numbers. The allotted bandwidth is - shared equally between domains connected to the network. + elements have one mandatory attribute - <code>average</code> (or + <code>floor</code> as described below). The attributes are as follows, + where accepted values for each attribute is an integer number. </p> + <dl> + <dt><code>average</code></dt> + <dd> + Specifies the desired average bit rate for the interface + being shaped (in kilobytes/second). + </dd> + <dt><code>peak</code></dt> + <dd> + Optional attribute which specifies the maximum rate at + which the bridge can send data (in kilobytes/second). + Note the limitation of implementation: this attribute in the + <code>outbound</code> element is ignored (as Linux ingress + filters don't know it yet). + </dd> + <dt><code>burst</code></dt> + <dd> + Optional attribute which specifies the amount of kilobytes that + can be transmitted in a single burst at <code>peak</code> speed. + </dd> + <dt><code>floor</code></dt> + <dd> + Optional attribute available only for the <code>inbound</code> + element. This attribute guarantees minimal throughput for + shaped interfaces. This, however, requires that all traffic + goes through one point where QoS decisions can take place, hence + why this attribute works only for virtual networks for now + (that is <code><interface type='network'/></code> with a + forward type of route, nat, or no forward at all). Moreover, the + virtual network the interface is connected to is required to have + at least inbound QoS set (<code>average</code> at least). If + using the <code>floor</code> attribute users don't need to specify + <code>average</code>. However, <code>peak</code> and + <code>burst</code> attributes still require <code>average</code>. + Currently, the Linux kernel doesn't allow ingress qdiscs to have + any classes therefore <code>floor</code> can be applied only + on <code>inbound</code> and not <code>outbound</code>. + </dd> + </dl> + + <p> + Attributes <code>average</code>, <code>peak</code>, and + <code>burst</code> are available + <span class="since">since 0.9.4</span>, while the + <code>floor</code> attribute is available + <span class="since">since 1.0.1</span>. + </p> + <p> A <code><portgroup></code> element can also include a <code><bandwidth></code> element. In that case, the @@ -561,7 +602,7 @@ network), and each portgroup has a name, as well as various subelements associated with it. The currently supported subelements are <code><bandwidth></code> - (documented <a href="formatdomain.html#elementQoS">here</a>) + (described <a href="formatnetwork.html#elementQoS">here</a>) and <code><virtualport></code> (documented <a href="formatdomain.html#elementsNICSDirect">here</a>). If a domain interface definition specifies a portgroup (by diff --git a/tools/virsh.pod b/tools/virsh.pod index f221475..30dcbb8 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -680,7 +680,10 @@ or the MAC address. If no I<--inbound> or I<--outbound> is specified, this command will query and show the bandwidth settings. Otherwise, it will set the inbound or outbound bandwidth. I<average,peak,burst> is the same as -in command I<attach-interface>. +in command I<attach-interface>. Values for I<average> and I<peak> are +expressed in kilobytes per second, while I<burst> is expressed in kilobytes +in a single burst at -I<peak> speed as described in the Network XML +documentation at L<http://libvirt.org/formatnetwork.html#elementQoS>. If I<--live> is specified, affect a running guest. If I<--config> is specified, affect the next boot of a persistent guest. @@ -2019,7 +2022,10 @@ of the network interface. I<script> allows to specify a path to a script handling a bridge instead of the default one. I<model> allows to specify the model type. I<inbound> and I<outbound> control the bandwidth of the interface. I<peak> and I<burst> are optional, so "average,peak", "average,,burst" and -"average" are also legal. +"average" are also legal. Values for I<average> and I<peak> are +expressed in kilobytes per second, while I<burst> is expressed in kilobytes +in a single burst at -I<peak> speed as described in the Network XML +documentation at L<http://libvirt.org/formatnetwork.html#elementQoS>. If I<--live> is specified, affect a running domain. If I<--config> is specified, affect the next startup of a persistent domain. -- 1.8.4.2

3 5

[libvirt] [PATCH] Fix build of portallocator on mingw
by Ján Tomko 20 Feb '14

20 Feb '14

IN6ADDR_ANY_INIT does not seem to be working as expected on MinGW: error: missing braces around initializer [-Werror=missing-braces] .sin6_addr = IN6ADDR_ANY_INIT, Use the in6addr_any variable instead. Reported by Daniel P. Berrange. --- Pushed as a build breaker. src/util/virportallocator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virportallocator.c b/src/util/virportallocator.c index 06174b0..22cdc37 100644 --- a/src/util/virportallocator.c +++ b/src/util/virportallocator.c @@ -106,7 +106,7 @@ static int virPortAllocatorBindToPort(bool *used, struct sockaddr_in6 addr6 = { .sin6_family = AF_INET6, .sin6_port = htons(port), - .sin6_addr = IN6ADDR_ANY_INIT, + .sin6_addr = in6addr_any }; struct sockaddr_in addr4 = { .sin_family = AF_INET, -- 1.8.3.2

2 2

[libvirt] [PATCH 0/2] Add two string helper methods
by Daniel P. Berrange 20 Feb '14

20 Feb '14

As mentioned in my review, I took the first two patches from this series and polished them up ready for merge https://www.redhat.com/archives/libvir-list/2014-January/msg01067.html Hopefully this should be good enough for the vbox snapshot work to use. Changes since that posting - Added unit tests - Changed virStringSearch API to return all matches in one go, rather than need repeated calls - Rewrote virStringReplace to use virBuffer APIs Daniel P. Berrange (1): Add virStringReplace method for substring replacement Manuel VIVES (1): Add virStringSearch method for regex matching po/POTFILES.in | 1 + src/libvirt_private.syms | 2 + src/util/virstring.c | 146 ++++++++++++++++++++++++++++++++++++++++++- src/util/virstring.h | 12 ++++ tests/virstringtest.c | 159 +++++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 319 insertions(+), 1 deletion(-) -- 1.8.5.3

2 4

[libvirt] [PATCH] lxc: Add destroy support for suspended domains
by Richard Weinberger 20 Feb '14

20 Feb '14

Destroying a suspended domain needs special action. We cannot simply terminate all process because they are frozen. Do deal with that we send them SIGKILL and thaw them. Upon wakeup the process sees the pending signal and dies immediately. Signed-off-by: Richard Weinberger <richard(a)nod.at> --- src/lxc/lxc_process.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c index ed729f6..b518dce 100644 --- a/src/lxc/lxc_process.c +++ b/src/lxc/lxc_process.c @@ -697,6 +697,30 @@ int virLXCProcessStop(virLXCDriverPtr driver, VIR_FREE(vm->def->seclabels[0]->imagelabel); } + /* If the LXC domain is suspended we send all processes a SIGKILL + * and thaw them. Upon wakeup the process sees the pending signal + * and dies immediately. It is guaranteed that priv->cgroup != NULL + * here because the domain has aleady been suspended using the + * freezer cgroup. + */ + if (reason == VIR_DOMAIN_SHUTOFF_DESTROYED && + virDomainObjGetState(vm, NULL) == VIR_DOMAIN_PAUSED) { + if (virCgroupKillRecursive(priv->cgroup, SIGKILL) <= 0) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Unable to kill all processes")); + return -1; + } + + if (virCgroupSetFreezerState(priv->cgroup, "THAWED") < 0) { + virReportError(VIR_ERR_OPERATION_FAILED, + _("Unable to thaw all processes")); + + return -1; + } + + goto cleanup; + } + if (priv->cgroup) { rc = virCgroupKillPainfully(priv->cgroup); if (rc < 0) @@ -716,6 +740,7 @@ int virLXCProcessStop(virLXCDriverPtr driver, } } +cleanup: virLXCProcessCleanup(driver, vm, reason); return 0; -- 1.8.4.5

2 1

[libvirt] [PATCH v10] bhyve: add a basic driver
by Roman Bogorodskiy 20 Feb '14

20 Feb '14

Changes from v9: - Fix AC_PATH_PROG macro usage for bhyve tools - Check for readdir() failures - Make sure we go only with disk type 'file' - Remove unneeded locking from bhyveConnectGetCapabilities() - Don't check for NULL before calling virObjectUnlock() - s/INFO/DEBUG/ for low level domain operations - Ignore logfd close errors in bhyve_process.c - Drop unneeded virReportError for virDomainDefParseString() - Indent and style fixes Changes from v8: - Implement domainUndefine and two more functions it depends on: domainIsActive and bhyveDomainIsPersistent Changes from v7: - Squashed in ACL support - Check for disk and bus type for bhyve and disk type for bhyveload - Handle case when URI == NULL in ConnectOpen - Call bhyveload only after we've built bhyve command to avoid unneeded load/reload for wrong domain configuration - Cleanup unload calls on errors - Minor style fixes Changes from v6: - Fix typo: s/LIBIVRT_DRIVER_RESULT_BHYVE/LIBVIRT_DRIVER_RESULT_BHYVE/ - Report domain state in 'dominfo' - Add a patch which implements ACL support Now both 'make check' and 'make syntax-check' pass. Changes from v5: - Obtain version using uname(3) - Cleanup driver global objects in StateCleanup instead of ConnectClose Changes from v4: - Set acpi and apic flags based on domain definition - Add more detailed description about -H and -P flags of bhyve to justify theirs usage Roman Bogorodskiy (1): bhyve: add a basic driver configure.ac | 7 + daemon/libvirtd.c | 9 + include/libvirt/virterror.h | 1 + m4/virt-driver-bhyve.m4 | 57 +++++ po/POTFILES.in | 3 + src/Makefile.am | 32 +++ src/bhyve/bhyve_command.c | 331 ++++++++++++++++++++++++ src/bhyve/bhyve_command.h | 41 +++ src/bhyve/bhyve_driver.c | 612 ++++++++++++++++++++++++++++++++++++++++++++ src/bhyve/bhyve_driver.h | 28 ++ src/bhyve/bhyve_process.c | 224 ++++++++++++++++ src/bhyve/bhyve_process.h | 36 +++ src/bhyve/bhyve_utils.h | 48 ++++ src/conf/domain_conf.c | 3 +- src/conf/domain_conf.h | 1 + src/driver.h | 1 + src/libvirt.c | 3 + src/util/virerror.c | 1 + 18 files changed, 1437 insertions(+), 1 deletion(-) create mode 100644 m4/virt-driver-bhyve.m4 create mode 100644 src/bhyve/bhyve_command.c create mode 100644 src/bhyve/bhyve_command.h create mode 100644 src/bhyve/bhyve_driver.c create mode 100644 src/bhyve/bhyve_driver.h create mode 100644 src/bhyve/bhyve_process.c create mode 100644 src/bhyve/bhyve_process.h create mode 100644 src/bhyve/bhyve_utils.h -- 1.8.4.3

2 3

[libvirt] [PATCHv3 00/10] Add BlkIO and CPU/mem stat API implementations for lxc
by Thorsten Behrens 19 Feb '14

19 Feb '14

This patch set adds block io, memory and domain cpu statistics API slot implementations to the LXC driver, in order to get linux container monitoring and accounting a bit closer to qemu standards. The last patch is a tad quirky (happy to hear suggestions on alternative ways), in that it widens the permissible value set at the .domainBlockStats slot: for lxc guests, it is relatively likely to have zero disk devices, since host filesystems can be used via passthrough bind mounts. Therefore, passing the zero-length string as device path, is interpreted as 'return summary stats for the entire domains's block io'. v3 addresses review comments, and adds unit tests for good measure. Thorsten Behrens (10): Add util virCgroupGetBlkioIo*Serviced methods. Implement domainMemoryStats API slot for LXC driver. Make qemuGetDomainTotalCPUStats a virCgroup function. Implement domainGetCPUStats for lxc driver. Implement lxcDomainBlockStats* for lxc driver Widening API change - accept empty path for virDomainBlockStats Add unit test for virCgroupGetBlkioIo*Serviced Add unit test for virCgroupGetMemoryUsage. Fix misspelled cpuacct.usage_percpu in cgroup mock. Add unit test for virCgroupGetPercpuStats. src/libvirt.c | 8 +- src/libvirt_private.syms | 4 + src/lxc/lxc_driver.c | 297 +++++++++++++++++++++++++++++++++ src/qemu/qemu_driver.c | 54 +----- src/util/vircgroup.c | 382 +++++++++++++++++++++++++++++++++++++++++++ src/util/vircgroup.h | 24 +++ tests/vircgroupmock.c | 109 +++++++++++- tests/vircgrouptest.c | 234 ++++++++++++++++++++++++++ tools/virsh-domain-monitor.c | 11 +- tools/virsh.pod | 5 +- 10 files changed, 1066 insertions(+), 62 deletions(-) -- 1.8.4

3 23

[libvirt] [PATCH V2 00/13] libxl: add job support
by Jim Fehlig 19 Feb '14

19 Feb '14

This patch series adds job support to the libxl driver, using a simplified version of the technique used in the qemu driver. One benefit of this series is no longer blocking get operations during long running modify operations. E.g. with these patches 'vish dominfo dom' will work while 'virsh save dom ...' is in progress. The first two patches are new to the series, following review of V1. Patch1 changes the cleanup logic to unconditionally set dom id to -1 on domain shutdown. Patch2 removes libxlVmReap, giving callers more control over domain destruction/cleanup. The remaining patches are updates to V1 based on Daniel's and Michal's comments. Jim Fehlig (13): libxl: always set vm id to -1 on shutdown libxl: remove libxlVmReap function libxl: Add job support to libxl driver libxl: use job functions in libxlVmStart libxl: use job functions in libxlDomainSetMemoryFlags libxl: use job functions in libxlDomain{Suspend,Resume} libxl: use job functions when cleaning up a domain libxl: use job functions in domain save operations libxl: use job functions in libxlDomainCoreDump libxl: use job functions in vcpu set and pin functions libxl: use job functions in device attach and detach functions libxl: use job functions in libxlDomainSetAutostart libxl: use job functions in libxlDomainSetSchedulerParametersFlags src/libxl/libxl_domain.c | 128 +++++++++++++++ src/libxl/libxl_domain.h | 38 +++++ src/libxl/libxl_driver.c | 405 +++++++++++++++++++++++++++++++---------------- 3 files changed, 432 insertions(+), 139 deletions(-) -- 1.8.1.4

2 29

[libvirt] [PATCH 0/2] Introduce max_anonymous_clients
by Michal Privoznik 19 Feb '14

19 Feb '14

https://bugzilla.redhat.com/show_bug.cgi?id=981729 So far we can limit how many clients are connected, how many are waiting in accept() line but we could not control the count of accepted but not authenticated yet. Michal Privoznik (2): virNetServer: Introduce unauth clients counter daemon: Introduce max_anonymous_clients daemon/libvirtd-config.c | 1 + daemon/libvirtd-config.h | 1 + daemon/libvirtd.aug | 1 + daemon/libvirtd.c | 1 + daemon/libvirtd.conf | 3 ++ daemon/remote.c | 21 ++++++++----- daemon/test_libvirtd.aug.in | 1 + src/locking/lock_daemon.c | 4 +-- src/lxc/lxc_controller.c | 2 +- src/rpc/virnetserver.c | 73 +++++++++++++++++++++++++++++++++++++++++---- src/rpc/virnetserver.h | 3 ++ 11 files changed, 95 insertions(+), 16 deletions(-) -- 1.8.5.1

4 11

[libvirt] [PATCHv6 0/5] Handling of undefine and redefine snapshots with VirtualBox 4.2
by Manuel VIVES 19 Feb '14

19 Feb '14

Hi, This is a serie of patches in order to support undefining and redefining snapshots with VirtualBox 4.2. The serie of patches is rather big, and adds among other things some utility functions unrelated to VirtualBox in patches 1 & 2. The code review could be done in several parts: e.g. patches 1 & 2 separately to validate the utility functions. The VirtualBox API provides only high level operations to manipulate snapshots, so it not possible to support flags like VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE and VIR_DOMAIN_SNAPSHOT_DELETE_METADATA_ONLY with only API calls. Following an IRC talk with Eric Blake, the decision was taken to emulate these behaviours by manipulating directly the .vbox XML files. The first two patches are some util methods for handling regexp and strings that will be used after. The third patch brings more details in the snapshot XML returned by libvirt. We will need those modifications in order to redefine the snapshots. The fourth patch brings the support of the VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE and VIR_DOMAIN_SNAPSHOT_CREATE_CURRENT flags in virDomainSnapshotCreateXML. The fifth and last patch brings the support of the VIR_DOMAIN_SNAPSHOT_DELETE_METADATA_ONLY flag in virDomainSnapshotDelete. The patches are only tested with Virtualbox 4.2 but the code is compliant with Virtualbox 4.3 API. Regards, Manuel VIVES v6: * Rebased because of a massive change in vbox_tmpl.c due to changes in the handling of different versions of VirtualBox v5: * The patches are modified according to a first review by Laine Stump: * renamed virSearchUuid to virSearchRegex and moved it from viruuid.{c,h} to virstring.{c,h}. * Various fixes. V4: * The code is compliant with Virtualbox 4.3 API * Some minor modifications in order to satisfy "make syntax-check" V3: * Use of STREQ_NULLABLE instead of STREQ in one case * Fix the method for finding uuids according to Ján Tomko review V2: * Fix a licence problem with the method for string replacement Manuel VIVES (5): virstring.h/c: Util method for finding regexp patterns in some strings virstring.h/c: Util method for making some find and replace in strings vbox_tmpl.c: Better XML description for snapshots vbox_tmpl.c: Patch for redefining snapshots vbox_tmpl.c: Add methods for undefining snapshots po/POTFILES.in | 1 + src/libvirt_private.syms | 2 + src/util/virstring.c | 163 +++- src/util/virstring.h | 4 + src/vbox/vbox_tmpl.c | 2346 ++++++++++++++++++++++++++++++++++++++++++---- 5 files changed, 2346 insertions(+), 170 deletions(-) -- 1.7.10.4

3 11

[libvirt] Reporting log/error messages through capabilities
by Richard W.M. Jones 19 Feb '14

19 Feb '14

When qemu is completely broken, libvirtd starts up OK but exists in a kind of broken state where no guests can possibly be run. I hit this problem ... again ... today: https://bugzilla.redhat.com/show_bug.cgi?id=1066630#c0 There is a libvirt bug here, which is that it's very hard to diagnose what is going on when qemu fails to work at all. The logging system in libvirt(d) is trememdously powerful, but ultimately confusing to use, and requires users to edit config files which makes it a non-starter for programs using libvirt through the API [1]. >From a libguestfs point of view, it's impossible for us to report back to the user that there is a problem two layers below in qemu. So my idea is that libvirt capabilities output should have an <info> section containing log messages/errors. <capabilities> ... <info> Could not run qemu-system-blah: "symbol lookup error: /usr/bin/qemu-system-s390x: undefined symbol: glfs_discard_async" </info> </capabilities> Libguestfs queries for libvirt capabilities anyway. If we don't get a satisfactory set of <guest/> elements, then we could list out the <info/> section. Easy for us. The problem is the <info/> element hardly fits into capabilities. If we didn't put it there, could it go some other place? Or a new API? Are there other unanticipated problems here? I think one is that libvirt doesn't appear to collect detailed log information by default, (unless the user edits log_level). That's assuming I understand the code correctly. Personally I think libvirt should always collect debug information, because you never know when it could be useful, but for the above, collecting errors & warnings unconditionally is sufficient. Rich. [1] By the way, this is a general complaint about libvirt. Please DON'T add any more stuff to the configuration file. Everything should be configurable through the API, or not at all. There are two other settings I can think of that libguestfs would like to adjust but cannot because they are only available in a configuration file. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/

4 11

[libvirt] [PATCH v2] qemu: Use virtio network device for aarch64/virt
by Oleg Strikov 19 Feb '14

19 Feb '14

This patch changes network device type used by default from rtl8139 to virtio when architecture type is aarch64 and machine type is virt. Qemu doesn't support any other machine types for aarch64 right now and we can't make any other aarch64-specific tuning in this function yet. Signed-off-by: Oleg Strikov <oleg.strikov(a)canonical.com> --- Changes since v1: * qemuxml2argvtest suite has been extended to validate correct setup for aarch64 guests when no NIC model is provided in the XML src/qemu/qemu_domain.c | 3 ++- .../qemuxml2argv-aarch64-virt-default-nic.args | 6 ++++++ .../qemuxml2argv-aarch64-virt-default-nic.xml | 22 ++++++++++++++++++++ tests/qemuxml2argvtest.c | 3 +++ 4 files changed, 33 insertions(+), 1 deletion(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-default-nic.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-default-nic.xml diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index a665061..9a040ee 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -797,7 +797,8 @@ qemuDomainDefaultNetModel(const virDomainDef *def) def->os.arch == VIR_ARCH_S390X) return "virtio"; - if (def->os.arch == VIR_ARCH_ARMV7L) { + if (def->os.arch == VIR_ARCH_ARMV7L || + def->os.arch == VIR_ARCH_AARCH64) { if (STREQ(def->os.machine, "versatilepb")) return "smc91c111"; diff --git a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-default-nic.args b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-default-nic.args new file mode 100644 index 0000000..d4d403b --- /dev/null +++ b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-default-nic.args @@ -0,0 +1,6 @@ +LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test QEMU_AUDIO_DRV=none \ +/usr/bin/qemu-system-aarch64 -S -M virt -m 1024 -smp 1 -nographic \ +-nodefconfig -nodefaults -monitor unix:/tmp/test-monitor,server,nowait \ +-boot c -kernel /aarch64.kernel -initrd /aarch64.initrd -append console=ttyAMA0 \ +-usb -device virtio-net-device,vlan=0,id=net0,mac=52:54:00:09:a4:37 \ +-net user,vlan=0,name=hostnet0 diff --git a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-default-nic.xml b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-default-nic.xml new file mode 100644 index 0000000..868de94 --- /dev/null +++ b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-default-nic.xml @@ -0,0 +1,22 @@ +<domain type="qemu"> + <name>aarch64-virt-default-nic</name> + <uuid>6ba410c5-1e5c-4d57-bee7-2228e7ffa32f</uuid> + <memory>1048576</memory> + <currentMemory>1048576</currentMemory> + <vcpu>1</vcpu> + <features> + <acpi/> + </features> + <os> + <type arch="aarch64" machine="virt">hvm</type> + <kernel>/aarch64.kernel</kernel> + <initrd>/aarch64.initrd</initrd> + <cmdline>console=ttyAMA0</cmdline> + </os> + <devices> + <emulator>/usr/bin/qemu-system-aarch64</emulator> + <interface type='user'> + <mac address='52:54:00:09:a4:37'/> + </interface> + </devices> +</domain> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 7a5b50d..43ac1d1 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1335,6 +1335,9 @@ mymain(void) QEMU_CAPS_DEVICE, QEMU_CAPS_NODEFCONFIG, QEMU_CAPS_DTB, QEMU_CAPS_DRIVE, QEMU_CAPS_DEVICE_VIRTIO_MMIO, QEMU_CAPS_DEVICE_VIRTIO_RNG, QEMU_CAPS_OBJECT_RNG_RANDOM); + DO_TEST("aarch64-virt-default-nic", + QEMU_CAPS_DEVICE, QEMU_CAPS_NODEFCONFIG, + QEMU_CAPS_DEVICE_VIRTIO_MMIO); DO_TEST("kvm-pit-device", QEMU_CAPS_KVM_PIT_TICK_POLICY); DO_TEST("kvm-pit-delay", QEMU_CAPS_NO_KVM_PIT); -- 1.7.9.5

2 1

[libvirt] [PATCH] networkRunHook: Run hook only if possible
by Michal Privoznik 19 Feb '14

19 Feb '14

Currently, networkRunHook() is called in networkAllocateActualDevice and friends. These functions, however, doesn't necessarily work on networks, For example, if domain's interface is defined in this fashion: <interface type='bridge'> <mac address='52:54:00:0b:3b:16'/> <source bridge='virbr1'/> <model type='rtl8139'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x09' function='0x0'/> </interface> The networkAllocateActualDevice jumps directly onto 'validate' label as the interface is not type of 'network'. Hence, @network is left initialized to NULL and networkRunHook(network, ...) is called. One of the things that the hook function does is dereference @network. Soupir. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/network/bridge_driver.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index ee264b9..a6c719d 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -150,6 +150,12 @@ networkRunHook(virNetworkObjPtr network, int ret = -1; if (virHookPresent(VIR_HOOK_DRIVER_NETWORK)) { + if (!network) { + VIR_DEBUG("Not running hook as @network is NULL"); + ret = 0; + goto cleanup; + } + virBufferAddLit(&buf, "<hookData>\n"); virBufferAdjustIndent(&buf, 2); if (virNetworkDefFormatBuf(&buf, network->def, 0) < 0) -- 1.9.0

2 1

[libvirt] Is it possible to set a timeout to the Connection class?
by Pasquale Dir 19 Feb '14

19 Feb '14

I am using the java api bindings. I'd like to set a connection timeout on the Connect class as sometimes it takes just too long. Is there any way/workaround?

4 5

Re: [libvirt] Is it possible to set a timeout to the Connection class?
by Claudio Bley 19 Feb '14

19 Feb '14

[please, don't top-post on technical lists and keep the conversation on list] At Wed, 19 Feb 2014 11:59:29 +0100, Pasquale Dir wrote: > > Thank you I didn't think about the Future, I'll try it and if it doesn't > work I'll just try to edit the tcp connection timeout file. > Can you answer me to the other question too, please? > > << what new apis are you talking about? I am doing migration by executing > the Domain.migrate function in a separate thread and obtaining progress by > DomainJobInfo class. Did you introduce some new api who automatically does > this? I can't find it here http://libvirt.org/sources/java/javadoc/ >> Eric was talking about the block-pull API functions, like virDomainBlockPull[1] which was added to libvirt in version 0.9.4. These functions have not been wrapped in libvirt-java, yet. (Patches welcome!) As Eric pointed out, there is curently no equivalent async _migration_ function in libvirt. Claudio [1]: http://libvirt.org/html/libvirt-libvirt.html#virDomainBlockPull

1 0

[libvirt] LSN-2013-0018: Unsafe usage of paths under /proc/$PID/root by the LXC driver
by Daniel P. Berrange 19 Feb '14

19 Feb '14

Libvirt Security Notice: LSN-2013-0018 ====================================== Summary: Unsafe usage of paths under /proc/$PID/root by the LXC driver Reported on: 20131217 Published on: 20131217 Fixed on: 20140219 Reported by: Reco <recoverym4n(a)gmail.com> Patched by: Reco <recoverym4n(a)gmail.com>, Eric Blake <eblake(a)redhat.com>, Daniel Berrange <berrange(a)redhat.com> See also: CVE-2013-6456, debian bug #732394 Description ----------- The LXC driver will open paths under /proc/$PID/root for some operations it performs on running guests. For the virDomainShutdown and virDomainReboot APIs it will use this to access the /dev/initctl path in the container. For the virDomainDeviceAttach / virDomainDeviceDettach APIs it will use this to create device nodes in the container's /dev filesystem. If any of the path components under control of the container are symlinks the container can cause the libvirtd daemon to access the incorrect files. Impact ------ A container can cause the administrator to shutdown or reboot the host OS if /dev/initctl in the container is made to be an absolute symlink back to itself or /run/initctl. A container can cause the host administrator to mknod in an arbitrary host directory when invoking the virDomainDeviceAttach API by replacing '/dev' with an absolute symlink. A container can cause the host administrator to delete host device when invoking the virDomainDeviceDettach API by replacing '/dev' with an absolute symlink. Workaround ---------- Do not use the virDomainShutdown or virDomainReboot APIs without also passing the VIR_DOMAIN_SHUTDOWN_SIGNAL or VIR_DOMAIN_REBOOT_SIGNAL flags respectively. These will cause the LXC driver to send a SIGTERM or SIGHUP signal respectively, to the init process instead of using /dev/initct.. Do not use the virDomainDeviceAttach or virDomainDeviceDetach APIs at all unless the guest OS is trusted. Affected product ---------------- Name: libvirt Repository: git://libvirt.org/git/libvirt.git http://libvirt.org/git/?p=libvirt.git Branch: master Broken in: v1.0.1 Broken in: v1.0.2 Broken in: v1.0.3 Broken in: v1.0.4 Broken in: v1.0.5 Broken in: v1.0.6 Broken in: v1.0.0 Broken in: v1.1.1 Broken in: v1.1.2 Broken in: v1.1.3 Broken in: v1.1.4 Broken in: v1.2.0 Broken in: v1.2.1 Broken by: cbb106f807b32f1f6af22d1e92fe0ff9ba6d73b3 Broken by: de858e3fa7ffcab5f80d07f8a74d94cbaf8716b9 Broken by: ed77abc58bc5a6837a5021f26e1a335dbfb477bf Broken by: a5efb3190913b6903775ca3756f79443d4ea8a5b Broken by: 4ad6a013304f6fe29b0866742c902054bfbcf23f Fixed by: aebbcdd33c8c18891f0bdbbf8924599a28152c9c Fixed by: 4dd3a7d5bc44980135a1b11810ba9aeab42a4a59 Fixed by: 7fba01c15c1f886b4235825692b4c13e88dd9f7b Fixed by: 1754c7f0ab1407dcf7c89636a35711dd9b1febe1 Fixed by: 1cadeafcaa422844a27ef622e2a7041d0235bcb3 Fixed by: 5fc590ad9f4071350a8df4d567ba88baacc8334d Branch: v1.0.1-maint Broken by: cbb106f807b32f1f6af22d1e92fe0ff9ba6d73b3 Branch: v1.0.2-maint Broken by: cbb106f807b32f1f6af22d1e92fe0ff9ba6d73b3 Broken by: de858e3fa7ffcab5f80d07f8a74d94cbaf8716b9 Broken by: ed77abc58bc5a6837a5021f26e1a335dbfb477bf Broken by: a5efb3190913b6903775ca3756f79443d4ea8a5b Broken by: 4ad6a013304f6fe29b0866742c902054bfbcf23f Branch: v1.0.3-maint Broken by: cbb106f807b32f1f6af22d1e92fe0ff9ba6d73b3 Broken by: de858e3fa7ffcab5f80d07f8a74d94cbaf8716b9 Broken by: ed77abc58bc5a6837a5021f26e1a335dbfb477bf Broken by: a5efb3190913b6903775ca3756f79443d4ea8a5b Broken by: 4ad6a013304f6fe29b0866742c902054bfbcf23f Branch: v1.0.4-maint Broken by: cbb106f807b32f1f6af22d1e92fe0ff9ba6d73b3 Broken by: de858e3fa7ffcab5f80d07f8a74d94cbaf8716b9 Broken by: ed77abc58bc5a6837a5021f26e1a335dbfb477bf Broken by: a5efb3190913b6903775ca3756f79443d4ea8a5b Broken by: 4ad6a013304f6fe29b0866742c902054bfbcf23f Branch: v1.0.5-maint Broken in: v1.0.5.1 Broken in: v1.0.5.2 Broken in: v1.0.5.3 Broken in: v1.0.5.4 Broken in: v1.0.5.5 Broken in: v1.0.5.6 Broken in: v1.0.5.7 Broken in: v1.0.5.8 Broken in: v1.0.5.9 Broken by: cbb106f807b32f1f6af22d1e92fe0ff9ba6d73b3 Broken by: de858e3fa7ffcab5f80d07f8a74d94cbaf8716b9 Broken by: ed77abc58bc5a6837a5021f26e1a335dbfb477bf Broken by: a5efb3190913b6903775ca3756f79443d4ea8a5b Broken by: 4ad6a013304f6fe29b0866742c902054bfbcf23f Fixed by: f84056cf6166332b1f15f3e6584a88f5d42273fe Fixed by: 0e9fee68b3bff24e4d3ab48de8129946202f3bc0 Fixed by: 9849cf6d89e5665667a0df449ddc3fd5582da242 Fixed by: 21821ed4d1faf5bf563a26e8ac7cd2eb0450d322 Fixed by: e57058cfe827b1971ca0dee224ff273c9cad7756 Fixed by: e1e7e05376faf1ed471cb5c1d1e0415458f2af7d Branch: v1.0.6-maint Broken by: cbb106f807b32f1f6af22d1e92fe0ff9ba6d73b3 Broken by: de858e3fa7ffcab5f80d07f8a74d94cbaf8716b9 Broken by: ed77abc58bc5a6837a5021f26e1a335dbfb477bf Broken by: a5efb3190913b6903775ca3756f79443d4ea8a5b Broken by: 4ad6a013304f6fe29b0866742c902054bfbcf23f Fixed by: e9941eee1a3c1cb0af7bc39076eb0e8c2c4eb603 Fixed by: 84cf9af8d9a803f2e12df0b8b0c2bd2de544cf93 Fixed by: f8706947b86e6de2961aacddb5eb2345d9c033b4 Fixed by: 081e0fabfd8c0f5c3f2c869ddcf11710c445a962 Fixed by: b2a853e1f6aea9683a30eafd2b069b8be0fcf898 Fixed by: bd9ec4506e29a9ce682961eee99d0326ed64145d Branch: v1.1.0-maint Broken by: cbb106f807b32f1f6af22d1e92fe0ff9ba6d73b3 Broken by: de858e3fa7ffcab5f80d07f8a74d94cbaf8716b9 Broken by: ed77abc58bc5a6837a5021f26e1a335dbfb477bf Broken by: a5efb3190913b6903775ca3756f79443d4ea8a5b Broken by: 4ad6a013304f6fe29b0866742c902054bfbcf23f Fixed by: 61c7e0b66e8b37d4ea64024c100d2ed467d5cb47 Fixed by: 43720035b7f4c175ef2594296d874bc1910840b3 Fixed by: 212414281f0001da78f2312d7f52dcf124317fc9 Fixed by: c17dd7ede2affd147ffdc5e8daef85939bda0dd0 Fixed by: ed46a680a02cf96b229a89f74ddbab69522c9ef5 Fixed by: 807db4a30ee903f973d496b3293d9e6aaa511174 Branch: v1.1.1-maint Broken by: cbb106f807b32f1f6af22d1e92fe0ff9ba6d73b3 Broken by: de858e3fa7ffcab5f80d07f8a74d94cbaf8716b9 Broken by: ed77abc58bc5a6837a5021f26e1a335dbfb477bf Broken by: a5efb3190913b6903775ca3756f79443d4ea8a5b Broken by: 4ad6a013304f6fe29b0866742c902054bfbcf23f Fixed by: 6ecb7bc3aed7f60edad5289c9b0cfcf99eee6611 Fixed by: 72a4c29ca72789b13de1ed9cb96df9fb2b0fdde4 Fixed by: 83f83508e128275bd1b74988162dc6b9f86e00ee Fixed by: 398c88edfaef50b9b59eb2d9a61b07c9c940a661 Fixed by: dd055960df60c536957664f0ae3c591feecf7b09 Fixed by: 14d69bd00e4455a1d174d14c5af73975cf9e904a Branch: v1.1.2-maint Broken by: cbb106f807b32f1f6af22d1e92fe0ff9ba6d73b3 Broken by: de858e3fa7ffcab5f80d07f8a74d94cbaf8716b9 Broken by: ed77abc58bc5a6837a5021f26e1a335dbfb477bf Broken by: a5efb3190913b6903775ca3756f79443d4ea8a5b Broken by: 4ad6a013304f6fe29b0866742c902054bfbcf23f Fixed by: f639b2d17ce935b650bb2aca7bdd8d727cab8b02 Fixed by: a06bdfcb446f182e490f70422a8431c3bcb2c801 Fixed by: 77ddbad2a9272239a09673c5d6993793308514e9 Fixed by: a6e9270ec79924fabd5a872984bb5d38eaf3df8a Fixed by: eae2a2ada81c5828991bb1b9438f7556a7e51ce8 Fixed by: 21368274a9aa91e8a5f0addb3a6bba8dad91e334 Branch: v1.1.3-maint Broken in: v1.1.3.1 Broken in: v1.1.3.2 Broken in: v1.1.3.3 Fixed in: v1.1.3.4 Broken by: cbb106f807b32f1f6af22d1e92fe0ff9ba6d73b3 Broken by: de858e3fa7ffcab5f80d07f8a74d94cbaf8716b9 Broken by: ed77abc58bc5a6837a5021f26e1a335dbfb477bf Broken by: a5efb3190913b6903775ca3756f79443d4ea8a5b Broken by: 4ad6a013304f6fe29b0866742c902054bfbcf23f Fixed by: a3a3cfcb7c400bcde198b5b929ff2d4f889dee78 Fixed by: cb016b9ef1a6d786657a98546db8412f86510367 Fixed by: 72e379ed93b4707e26bbc5e3457a85833f50eb1a Fixed by: fcf05c194cb1cca6b5c703073b97ed1408a2c546 Fixed by: d5c0b57fffbe651c425b4de6c11712030cce7e7e Fixed by: fef343339127b989746214b86901553da6d17863 Branch: v1.1.4-maint Broken by: cbb106f807b32f1f6af22d1e92fe0ff9ba6d73b3 Broken by: de858e3fa7ffcab5f80d07f8a74d94cbaf8716b9 Broken by: ed77abc58bc5a6837a5021f26e1a335dbfb477bf Broken by: a5efb3190913b6903775ca3756f79443d4ea8a5b Broken by: 4ad6a013304f6fe29b0866742c902054bfbcf23f Fixed by: 28681077373f1fa567b7f56117a22047f90925fe Fixed by: 0e931dfcda308fbb84eef42bc92e257e39af083d Fixed by: 3101022b4d4fee46916b87b1c21a3956a91d94b2 Fixed by: 1d1daaf58677cfa843b6891a98dc6cdb42116434 Fixed by: 80f57ec4224af65392db09fb8f47be7434e2fc86 Fixed by: ba4065b6f64fca7706070b8458fdf0bc06115b9b Branch: v1.2.0-maint Broken by: cbb106f807b32f1f6af22d1e92fe0ff9ba6d73b3 Broken by: de858e3fa7ffcab5f80d07f8a74d94cbaf8716b9 Broken by: ed77abc58bc5a6837a5021f26e1a335dbfb477bf Broken by: a5efb3190913b6903775ca3756f79443d4ea8a5b Broken by: 4ad6a013304f6fe29b0866742c902054bfbcf23f Fixed by: 3e97a53caa9adddd47da1c22dbed81ef2e02f735 Fixed by: 17188260657e095f5d210bc73ba1661875a8f885 Fixed by: 70665ec5f2cd910666bc703727dc6d7c15efe7bf Fixed by: 3f43a7727ac068de8aac6b9c030b38fb3cb1426d Fixed by: cd48d62aca488a116b47073be2607653a1d3305e Fixed by: 8fca7a4fa6b40d21723008d2092536349f20517d Branch: v1.2.1-maint Broken by: cbb106f807b32f1f6af22d1e92fe0ff9ba6d73b3 Broken by: de858e3fa7ffcab5f80d07f8a74d94cbaf8716b9 Broken by: ed77abc58bc5a6837a5021f26e1a335dbfb477bf Broken by: a5efb3190913b6903775ca3756f79443d4ea8a5b Broken by: 4ad6a013304f6fe29b0866742c902054bfbcf23f Fixed by: 8b546028f901dc414463678574ceabbacc37c4cb Fixed by: b0ed2d94ace3c57198ce7b4793f906abf5397e36 Fixed by: ee1269eecd3566729f3909db624f7ebd7bf1b84a Fixed by: b9997828231b3492252cb6d9a0ad4f3dc522791e Fixed by: 51a897a22e1c031edd46fd077487a2f8e649cb9f Fixed by: ad52184399aa414fa3d7e2756e4ea6a45ec0d3a3 -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

1 0

[libvirt] java api bindings for detecting domain events
by Avanti Ajay 19 Feb '14

19 Feb '14

Hi.. I am doing a project in which I need to detect KVM domain events and I am using java for my project. On the net I found many patches for the libvirt Java API bindings for event detection. Does the latest version 0.5 have these patches included ie can I use the method Domain.domainEventRegisterAny() directly. Also can u please tell me exactly how to use this method? Thank you Avanti

2 1

[libvirt] [bug-report] libvirtd 1.1.4-maint with lastest patches can't be connected
by Wangpan 19 Feb '14

19 Feb '14

Hi experts, Is there anybody could help me to fix this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1066801 my libvirt version is 1.1.4-manit without the newest patches after this one: 13 days ago Eric Blake event: move event filtering to daemon (regression fix) Description of problem: After I cherry-picked these patches of 1.1.4-maint branch(I want to fix the dead lock and a libvirtd crash bugs of libvirtd, https://bugzilla.redhat.com/show_bug.cgi?id=929412 https://bugzilla.redhat.com/show_bug.cgi?id=1058149) my libvirtd can be started, but the connection can't be established, and libvirtd failed to stop after 'service libvirt-bin stop', as well as 'ctrl+c' when I run 'libvirtd -v' on the foreground. Steps to Reproduce: 1. create many VMs(40 in my env) on the host 2. kill -9 `pid of libvirtd` 3. start libvirtd by using service libvirt-bin start 4. virsh list or virsh version Thanks a lot!

1 0

[libvirt] [PATCH v9 0/7] Support keyboard device
by Li Zhang 19 Feb '14

19 Feb '14

From: Li Zhang <zhlcindy(a)linux.vnet.ibm.com> This patchset is to add keyboard input device. For PPC64, it doesn't support a default keyboard device when the graphic is enabled. Libvirt supports QEMU command line as "-device VGA" which won't create any keyboard device for it. So it requires libvirt to add a default USB keyboard device for it. This patchset is to add keyboard input device and a default USB keyboard for PPC64. The related discussion in QEMU community: http://lists.nongnu.org/archive/html/qemu-devel/2013-11/msg01734.html Li Zhang (7): conf: Add one interface to add default input devices conf: Add a keyboard input device type conf: Remove the implicit PS2 devices for non-X86 platforms qemu_cap: Add USB keyboard capability qemu: format qemu command line for USB keyboard xen: format xen command line for USB keyboard Add a default USB keyboard and USB mouse for PPC64 v9 -> v8: * Move keyboard XML format to the first patch. (Jan Tomko) * Correct one logic error. (Jan Tomko) v8 -> v7: * Add USB keyboard output XML format when VIR_DOMAIN_XML_MIGRATABLE isn't set. (Daniel P. && Jan Tomko) * Fix test cases because of XML changes. v7 -> v6: * Corret indention errors in code. (Jan Tomko) * Correct make check error in xen driver. (Jan Tomko) * Split 5/6 to 2 parts, qemu and xen. (Jan Tomko) v6 -> v5: * Change kbd to keyboard, and correct -usbdevice parameter. * Remove implicit PS/2 keyboard output in XML in case older libvirtd can read it. (Jan Tomko) * Remove implicit keyboard for XEN to make it safer. v5 -> v4: * Add PS/2 KBD definition in XML file. (Daniel.P.Berrange) * Allow PS/2 KBD devices and set KBD default bus as PS2 for X86, USB for non-x86. (Daniel.P.Berrange) * Add an implicit PS/2 KBD as PS/2 mouse. (Danniel.P.Berrange) v4 -> v3: * Don't remove PS2 mouse device for other virtualization drivers (Jan Tomko). v3 -> v2: * Handle the KBD device type in xen and QEMU driver. (Daniel.P.Berrange) * Remove PS2 mouse device for non-X86 platforms. * Move virDomainDefMaybeAddInput to a new patch. (Jan Tomko) * Replace VIR_REALLOC_N with VIR_APPEND_ELEMENT. (Jan Tomoko) * Fix several typos. (Jan Tomoko) * Add a virReportError when QEMU_CAPS_DEVICE_USB_KBD can't be gotten. (Jan Tomoko) v2 -> v1: * change ifs to switch clause. * reconstruct the patches docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c | 116 ++++++++++++++------- src/conf/domain_conf.h | 5 + src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 3 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 41 ++++++-- src/qemu/qemu_domain.c | 23 +++- src/util/virarch.h | 2 + src/xenxs/xen_sxpr.c | 27 +++-- src/xenxs/xen_xm.c | 30 ++++-- tests/qemucapabilitiesdata/caps_1.2.2-1.caps | 1 + tests/qemucapabilitiesdata/caps_1.3.1-1.caps | 1 + tests/qemucapabilitiesdata/caps_1.4.2-1.caps | 1 + tests/qemucapabilitiesdata/caps_1.5.3-1.caps | 1 + tests/qemucapabilitiesdata/caps_1.6.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_1.6.50-1.caps | 1 + tests/qemuhelptest.c | 8 ++ ...qemuhotplug-console-compat-2+console-virtio.xml | 1 + .../qemuxml2argv-console-compat-2.xml | 1 + .../qemuxml2argv-graphics-listen-network.xml | 1 + .../qemuxml2argv-graphics-listen-network2.xml | 1 + .../qemuxml2argv-graphics-sdl-fullscreen.xml | 1 + .../qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml | 1 + .../qemuxml2argv-graphics-spice-compression.xml | 1 + .../qemuxml2argv-graphics-spice-qxl-vga.xml | 1 + .../qemuxml2argv-graphics-spice-timeout.xml | 2 + .../qemuxml2argv-graphics-spice.xml | 1 + .../qemuxml2argv-graphics-vnc-policy.xml | 1 + .../qemuxml2argv-graphics-vnc-sasl.xml | 1 + .../qemuxml2argv-graphics-vnc-socket.xml | 1 + .../qemuxml2argv-graphics-vnc-tls.xml | 1 + .../qemuxml2argv-graphics-vnc-websocket.xml | 1 + .../qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml | 1 + tests/qemuxml2argvdata/qemuxml2argv-input-xen.xml | 1 + .../qemuxml2argv-net-bandwidth.xml | 1 + tests/qemuxml2argvdata/qemuxml2argv-pci-bridge.xml | 1 + .../qemuxml2argvdata/qemuxml2argv-pseries-disk.xml | 3 +- .../qemuxml2argv-pseries-usb-kbd.args | 9 ++ .../qemuxml2argv-pseries-usb-kbd.xml | 19 ++++ .../qemuxml2argv-serial-spiceport.xml | 1 + tests/qemuxml2argvtest.c | 3 + .../qemuxml2xmlout-graphics-listen-network2.xml | 1 + .../qemuxml2xmlout-graphics-spice-timeout.xml | 1 + tests/vmx2xmldata/vmx2xml-graphics-vnc.xml | 1 + 45 files changed, 256 insertions(+), 66 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-usb-kbd.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-usb-kbd.xml -- 1.8.2.1

2 18

[libvirt] [Question] Is it ok to occupy large amount of cache when save?
by Wangyufei (James) 19 Feb '14

19 Feb '14

Hello, When I call virDomainManagedSave, libvirtd will fork a child process libvirt_iohelper to write save file, and the system cache will increase soon just like this: Swap: 0M total, 0M used, 0M free, 1668M cached Swap: 0M total, 0M used, 0M free, 1715M cached But I have cgroup to control the memory of libvirtd below 50 M, so in this case, libvirt_iohelper will be killed, and virDomainManagedSave failed. So my question is: 1. Is it ok for libvirtd to occupy large amount of cache when save? Can we flush cache in time? 2. In my situation, is it any good idea to help me out? Increase the memory limit value? Pass through the cache? Flush cache? Or any one better? Which one do you preffer? Best Regards, -WangYufei

2 1

[libvirt] ANNOUNCE: libvirt 1.1.3.4 maintenance release
by Cole Robinson 19 Feb '14

19 Feb '14

libvirt 1.1.3.4 maintenance release is now available. This is libvirt 1.1.3 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-1.1.3.4.tar.gz Changes in this version: * CVE-2013-6456: Avoid unsafe use of /proc/$PID/root in LXC hotunplug code * CVE-2013-6456: Avoid unsafe use of /proc/$PID/root in LXC chardev hostdev hotplug * CVE-2013-6456: Avoid unsafe use of /proc/$PID/root in LXC block hostdev hotplug * CVE-2013-6456: Avoid unsafe use of /proc/$PID/root in LXC USB hotplug * CVE-2013-6456: Avoid unsafe use of /proc/$PID/root in LXC disk hotplug * CVE-2013-6456: Avoid unsafe use of /proc/$PID/root in LXC shutdown/reboot code * Add helper for running code in separate namespaces * Add virFileMakeParentPath helper function * Move check for cgroup devices ACL upfront in LXC hotplug * Disks are always block devices, never character devices * Fix reset of cgroup when detaching USB device from LXC guests * Record hotplugged USB device in LXC live guest config * Fix path used for USB device attach with LXC * Don't block use of USB with containers * storage: avoid short reads while chasing backing chain * event: move event filtering to daemon (regression fix) * Push nwfilter update locking up to top level * Add a read/write lock implementation * tests: Add more tests for virConnectBaselineCPU * cpu: Try to use source CPU model in virConnectBaselineCPU * cpu: Fix VIR_CONNECT_BASELINE_CPU_EXPAND_FEATURES * tests: Better support for VIR_CONNECT_BASELINE_CPU_EXPAND_FEATURES * qemu: Change the default unix monitor timeout For info about past maintenance releases, see: http://wiki.libvirt.org/page/Maintenance_Releases Thanks, Cole

1 0

[libvirt] [PATCH] bridge_driver.h: Fix build --without-network
by Michal Privoznik 18 Feb '14

18 Feb '14

The networkNotifyActualDevice function is accepting two arguments, not one: qemu/qemu_process.c: In function 'qemuProcessNotifyNets': qemu/qemu_process.c:2776:47: error: macro "networkNotifyActualDevice" passed 2 arguments, but takes just 1 if (networkNotifyActualDevice(def, net) < 0) ^ Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/network/bridge_driver.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/network/bridge_driver.h b/src/network/bridge_driver.h index 0f80556..1c2a4a7 100644 --- a/src/network/bridge_driver.h +++ b/src/network/bridge_driver.h @@ -55,7 +55,7 @@ int networkDnsmasqConfContents(virNetworkObjPtr network, # else /* Define no-op replacements that don't drag in any link dependencies. */ # define networkAllocateActualDevice(dom, iface) 0 -# define networkNotifyActualDevice(iface) (iface=iface, 0) +# define networkNotifyActualDevice(dom, iface) (dom=dom, iface=iface, 0) # define networkReleaseActualDevice(dom, iface) (dom=dom, iface=iface, 0) # define networkGetNetworkAddress(netname, netaddr) (-2) # define networkDnsmasqConfContents(network, pidfile, configstr, \ -- 1.9.0

2 1

[libvirt] [PATCH] Fix conflicting types of virInitctlSetRunLevel
by Ján Tomko 18 Feb '14

18 Feb '14

aebbcdd didn't change the non-linux definition of the function, breaking the build on FreeBSD: ../../src/util/virinitctl.c:164: error: conflicting types for 'virInitctlSetRunLevel' ../../src/util/virinitctl.h:40: error: previous declaration of 'virInitctlSetRunLevel' was here --- Pushed as trivial. src/util/virinitctl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/virinitctl.c b/src/util/virinitctl.c index 579268f..012200c 100644 --- a/src/util/virinitctl.c +++ b/src/util/virinitctl.c @@ -159,8 +159,7 @@ cleanup: return ret; } #else -int virInitctlSetRunLevel(virInitctlRunLevel level ATTRIBUTE_UNUSED, - const char *vroot ATTRIBUTE_UNUSED) +int virInitctlSetRunLevel(virInitctlRunLevel level ATTRIBUTE_UNUSED) { virReportUnsupportedError(); return -1; -- 1.8.3.2

1 0

[libvirt] [PATCH v4 0/3] Network hooks
by Michal Privoznik 18 Feb '14

18 Feb '14

Tier four. Michal Privoznik (3): network_conf: Expose virNetworkDefFormatInternal network: Introduce network hooks network: Taint networks that are using hook script docs/hooks.html.in | 98 ++++++++++++++++++++++++++++++++------ src/conf/network_conf.c | 64 ++++++++++++++++++++++--- src/conf/network_conf.h | 20 ++++++++ src/libvirt_private.syms | 4 ++ src/lxc/lxc_driver.c | 4 +- src/lxc/lxc_process.c | 6 +-- src/network/bridge_driver.c | 111 ++++++++++++++++++++++++++++++++++++++++++-- src/network/bridge_driver.h | 19 ++++---- src/qemu/qemu_command.c | 2 +- src/qemu/qemu_hotplug.c | 14 +++--- src/qemu/qemu_process.c | 4 +- src/util/virhook.c | 13 +++++- src/util/virhook.h | 11 +++++ 13 files changed, 321 insertions(+), 49 deletions(-) -- 1.8.5.3

2 10

[libvirt] [PATCH v9] bhyve: add a basic driver
by Roman Bogorodskiy 18 Feb '14

18 Feb '14

Changes from v8: - Implement domainUndefine and two more functions it depends on: domainIsActive and domainIsPersistent Changes from v7: - Squashed in ACL support - Check for disk and bus type for bhyve and disk type for bhyveload - Handle case when URI == NULL in ConnectOpen - Call bhyveload only after we've built bhyve command to avoid unneeded load/reload for wrong domain configuration - Cleanup unload calls on errors - Minor style fixes Changes from v6: - Fix typo: s/LIBIVRT_DRIVER_RESULT_BHYVE/LIBVIRT_DRIVER_RESULT_BHYVE/ - Report domain state in 'dominfo' - Add a patch which implements ACL support Now both 'make check' and 'make syntax-check' pass. Changes from v5: - Obtain version using uname(3) - Cleanup driver global objects in StateCleanup instead of ConnectClose Changes from v4: - Set acpi and apic flags based on domain definition - Add more detailed description about -H and -P flags of bhyve to justify theirs usage Roman Bogorodskiy (1): bhyve: add a basic driver configure.ac | 7 + daemon/libvirtd.c | 9 + include/libvirt/virterror.h | 1 + m4/virt-driver-bhyve.m4 | 57 ++++ po/POTFILES.in | 3 + src/Makefile.am | 31 ++ src/bhyve/bhyve_command.c | 314 ++++++++++++++++++++ src/bhyve/bhyve_command.h | 41 +++ src/bhyve/bhyve_driver.c | 707 ++++++++++++++++++++++++++++++++++++++++++++ src/bhyve/bhyve_driver.h | 28 ++ src/bhyve/bhyve_process.c | 227 ++++++++++++++ src/bhyve/bhyve_process.h | 36 +++ src/bhyve/bhyve_utils.h | 49 +++ src/conf/domain_conf.c | 3 +- src/conf/domain_conf.h | 1 + src/driver.h | 1 + src/libvirt.c | 3 + src/util/virerror.c | 1 + 18 files changed, 1518 insertions(+), 1 deletion(-) create mode 100644 m4/virt-driver-bhyve.m4 create mode 100644 src/bhyve/bhyve_command.c create mode 100644 src/bhyve/bhyve_command.h create mode 100644 src/bhyve/bhyve_driver.c create mode 100644 src/bhyve/bhyve_driver.h create mode 100644 src/bhyve/bhyve_process.c create mode 100644 src/bhyve/bhyve_process.h create mode 100644 src/bhyve/bhyve_utils.h -- 1.8.4.3

3 6

[libvirt] [PATCH REPOST] Introduce new OOM testing support
by Daniel P. Berrange 18 Feb '14

18 Feb '14

The previous OOM testing support would re-run the entire "main" method each iteration, failing a different malloc each time. When a test suite has 'n' allocations, the number of repeats requires is (n * (n + 1) ) / 2. This gets very large, very quickly. This new OOM testing support instead integrates at the virtTestRun level, so each individual test case gets repeated, instead of the entire test suite. This means the values of 'n' are orders of magnitude smaller. The simple usage is $ VIR_TEST_OOM=1 ./qemuxml2argvtest ... 29) QEMU XML-2-ARGV clock-utc ... OK Test OOM for nalloc=36 .................................... OK 30) QEMU XML-2-ARGV clock-localtime ... OK Test OOM for nalloc=36 .................................... OK 31) QEMU XML-2-ARGV clock-france ... OK Test OOM for nalloc=38 ...................................... OK ... the second lines reports how many mallocs have to be failed, and thus how many repeats of the test will be run. If it crashes, then running under valgrind will often show the problem $ VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest When debugging problems it is also helpful to select an individual test case $ VIR_TEST_RANGE=30 VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest When things get really tricky, it is possible to request that just specific allocs are failed. eg to fail allocs 5 -> 12, use $ VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-12 ../run valgrind ./qemuxml2argvtest In the worse case, you might want to know the stack trace of the alloc which was failed then VIR_TEST_OOM_TRACE can be set. If it is set to 1 then it will only print if it thinks a mistake happened. This is often not reliable, so setting it to 2 will make it print the stack trace for every alloc that is failed. $ VIR_TEST_OOM_TRACE=2 VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-5 ../run valgrind ./qemuxml2argvtest 30) QEMU XML-2-ARGV clock-localtime ... OK Test OOM for nalloc=36 !virAllocN /home/berrange/src/virt/libvirt/src/util/viralloc.c:180 virHashCreateFull /home/berrange/src/virt/libvirt/src/util/virhash.c:144 virDomainDefParseXML /home/berrange/src/virt/libvirt/src/conf/domain_conf.c:11745 virDomainDefParseNode /home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12646 virDomainDefParse /home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12590 testCompareXMLToArgvFiles /home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:106 virtTestRun /home/berrange/src/virt/libvirt/tests/testutils.c:250 mymain /home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:418 (discriminator 2) virtTestMain /home/berrange/src/virt/libvirt/tests/testutils.c:750 ?? ??:0 _start ??:? FAILED Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- cfg.mk | 2 +- docs/internals/oomtesting.html.in | 213 ++++++++++++++++++++++++++++++++++++++ docs/sitemap.html.in | 4 + tests/qemuargv2xmltest.c | 14 +-- tests/qemuxml2argvtest.c | 12 ++- tests/qemuxmlnstest.c | 18 ++-- tests/testutils.c | 195 +++++++++++++++++++++++++++++++++- tests/testutils.h | 2 + 8 files changed, 438 insertions(+), 22 deletions(-) create mode 100644 docs/internals/oomtesting.html.in diff --git a/cfg.mk b/cfg.mk index 207dfeb..bbc966b 100644 --- a/cfg.mk +++ b/cfg.mk @@ -948,7 +948,7 @@ exclude_file_name_regexp--sc_libvirt_unmarked_diagnostics = \ exclude_file_name_regexp--sc_po_check = ^(docs/|src/rpc/gendispatch\.pl$$) exclude_file_name_regexp--sc_prohibit_VIR_ERR_NO_MEMORY = \ - ^(include/libvirt/virterror\.h|daemon/dispatch\.c|src/util/virerror\.c)$$ + ^(include/libvirt/virterror\.h|daemon/dispatch\.c|src/util/virerror\.c|docs/internals/oomtesting\.html\.in)$$ exclude_file_name_regexp--sc_prohibit_access_xok = ^src/util/virutil\.c$$ diff --git a/docs/internals/oomtesting.html.in b/docs/internals/oomtesting.html.in new file mode 100644 index 0000000..c5edacf --- /dev/null +++ b/docs/internals/oomtesting.html.in @@ -0,0 +1,213 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> +<html xmlns="http://www.w3.org/1999/xhtml"> + <body> + <h1>Out of memory testing</h1> + + <ul id="toc"></ul> + + + <p> + This page describes how to use the test suite todo out of memory + testing. + </p> + + <h2>Building with OOM testing</h2> + + <p> + Since OOM testing requires hooking into the malloc APIs, it is + not enabled by default. The flag <code>--enable-test-oom</code> + must be given to <code>configure</code>. When this is done the + libvirt allocation APIs will have some hooks enabled. + </p> + + <pre> +$ ./configure --enable-test-oom +</pre> + + + <h2><a name="basicoom">Basic OOM testing support</a></h2> + + <p> + The first step in validating OOM usage is to run a test suite + with full OOM testing enabled. This is done by setting the + <code>VIR_TEST_OOM=1</code> environment variable. The way this + works is that it runs the test once normally to "prime" any + static memory allocations. Then it runs it once more counting + the total number of memory allocations. Then it runs it in a + loop failing a different memory allocation each time. For every + memory allocation failure triggered, it expects the test case + to return an error. OOM testing is quite slow requiring each + test case to be executed O(n) times, where 'n' is the total + number of memory allocations. This results in a total number + of memory allocations of '(n * (n + 1) ) / 2' + </p> + + <pre> +$ VIR_TEST_OOM=1 ./qemuxml2argvtest + 1) QEMU XML-2-ARGV minimal ... OK + Test OOM for nalloc=42 .......................................... OK + 2) QEMU XML-2-ARGV minimal-s390 ... OK + Test OOM for nalloc=28 ............................ OK + 3) QEMU XML-2-ARGV machine-aliases1 ... OK + Test OOM for nalloc=38 ...................................... OK + 4) QEMU XML-2-ARGV machine-aliases2 ... OK + Test OOM for nalloc=38 ...................................... OK + 5) QEMU XML-2-ARGV machine-core-on ... OK + Test OOM for nalloc=37 ..................................... OK +...snip... +</pre> + + <p> + In this output, the first line shows the normal execution and + the test number, and the second line shows the total number + of memory allocations from that test case. + </p> + + <h3><a name="valgrind">Tracking failures with valgrind</a></h3> + + <p> + The test suite should obviously *not* crash during OOM testing. + If it does crash, then to assist in tracking down the problem + it is worth using valgrind and only running a single test case. + For example, supposing test case 5 crashed. Then re-run the + test with + </p> + + <pre> +$ VIR_TEST_OOM=1 VIR_TEST_RANGE=5 ../run valgrind ./qemuxml2argvtest +...snip... + 5) QEMU XML-2-ARGV machine-core-on ... OK + Test OOM for nalloc=37 ..................................... OK +...snip... + </pre> + + <p> + Valgrind should report the cause of the crash - for example a + double free or use of uninitialized memory or NULL pointer + access. + </p> + + <h3><a name="stacktraces">Tracking failures with stack traces</a></h3> + + <p> + With some really difficult bugs valgrind is not sufficient to + identify the cause. In this case, it is useful to identify the + precise allocation which was failed, to allow the code path + to the error to be traced. The <code>VIR_TEST_OOM</code> + env variable can be given a range of memory allocations to + test. So if a test case has 150 allocations, it can be told + to only test allocation numbers 7-10. The <code>VIR_TEST_OOM_TRACE</code> + variable can be used to print out stack traces. + </p> + + <pre> +$ VIR_TEST_OOM_TRACE=2 VIR_TEST_OOM=1:7-10 VIR_TEST_RANGE=5 \ + ../run valgrind ./qemuxml2argvtest + 5) QEMU XML-2-ARGV machine-core-on ... OK + Test OOM for nalloc=37 !virAllocN +/home/berrange/src/virt/libvirt/src/util/viralloc.c:180 +virDomainDefParseXML +/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:11786 (discriminator 1) +virDomainDefParseNode +/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12677 +virDomainDefParse +/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12621 +testCompareXMLToArgvFiles +/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:107 +virtTestRun +/home/berrange/src/virt/libvirt/tests/testutils.c:266 +mymain +/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:388 (discriminator 2) +virtTestMain +/home/berrange/src/virt/libvirt/tests/testutils.c:791 +__libc_start_main +??:? +_start +??:? +!virAlloc +/home/berrange/src/virt/libvirt/src/util/viralloc.c:133 +virDomainDiskDefParseXML +/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:4790 +virDomainDefParseXML +/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:11797 +virDomainDefParseNode +/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12677 +virDomainDefParse +/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12621 +testCompareXMLToArgvFiles +/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:107 +virtTestRun +/home/berrange/src/virt/libvirt/tests/testutils.c:266 +mymain +/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:388 (discriminator 2) +virtTestMain +/home/berrange/src/virt/libvirt/tests/testutils.c:791 +__libc_start_main +??:? +_start +??:? +!virAllocN +/home/berrange/src/virt/libvirt/src/util/viralloc.c:180 +virXPathNodeSet +/home/berrange/src/virt/libvirt/src/util/virxml.c:609 +virDomainDefParseXML +/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:11805 +virDomainDefParseNode +/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12677 +virDomainDefParse +/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12621 +testCompareXMLToArgvFiles +/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:107 +virtTestRun +/home/berrange/src/virt/libvirt/tests/testutils.c:266 +mymain +/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:388 (discriminator 2) +virtTestMain +/home/berrange/src/virt/libvirt/tests/testutils.c:791 +__libc_start_main +??:? +_start +??:? +!virAllocN +/home/berrange/src/virt/libvirt/src/util/viralloc.c:180 +virDomainDefParseXML +/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:11808 (discriminator 1) +virDomainDefParseNode +/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12677 +virDomainDefParse +/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12621 +testCompareXMLToArgvFiles +/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:107 +virtTestRun +/home/berrange/src/virt/libvirt/tests/testutils.c:266 +mymain +/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:388 (discriminator 2) +virtTestMain +/home/berrange/src/virt/libvirt/tests/testutils.c:791 +__libc_start_main +??:? +_start +??:? + </pre> + + <h3><a name="noncrash">Non-crash related problems</a></h3> + + <p> + Not all memory allocation bugs result in code crashing. Sometimes + the code will be silently ignoring the allocation failure, resulting + in incorrect data being produced. For example the XML parser may + mistakenly treat an allocation failure as indicating that an XML + attribute was not set in the input document. It is hard to identify + these problems from the test suite automatically. For this, the + test suites should be run with <code>VIR_TEST_DEBUG=1</code> set + and then stderr analysed for any unexpected data. For example, + the XML conversion may show an embedded "(null)" literal, or the + test suite might complain about missing elements / attributes + in the actual vs expected data. These are all signs of bugs in + OOM handling. In the future the OOM tests will be enhanced to + validate that an error VIR_ERR_NO_MEMORY is returned for each + allocation failed, rather than some other error. + </p> + </body> +</html> diff --git a/docs/sitemap.html.in b/docs/sitemap.html.in index 08c2fbd..7d0610b 100644 --- a/docs/sitemap.html.in +++ b/docs/sitemap.html.in @@ -342,6 +342,10 @@ <a href="internals/locking.html">Lock managers</a> <span>Use lock managers to protect disk content</span> </li> + <li> + <a href="internals/oomtesting.html">Out of memory testing</a> + <span>Simulating OOM conditions in the test suite</span> + </li> </ul> </li> <li> diff --git a/tests/qemuargv2xmltest.c b/tests/qemuargv2xmltest.c index 1b13fcc..e75c85d 100644 --- a/tests/qemuargv2xmltest.c +++ b/tests/qemuargv2xmltest.c @@ -42,7 +42,6 @@ static int testCompareXMLToArgvFiles(const char *xml, char *cmd = NULL; int ret = -1; virDomainDefPtr vmdef = NULL; - char *log; if (virtTestLoadFile(cmdfile, &cmd) < 0) goto fail; @@ -53,13 +52,16 @@ static int testCompareXMLToArgvFiles(const char *xml, cmd, NULL, NULL, NULL))) goto fail; - if ((log = virtTestLogContentAndReset()) == NULL) - goto fail; - if ((*log != '\0') != expect_warning) { + if (!virtTestOOMActive()) { + char *log; + if ((log = virtTestLogContentAndReset()) == NULL) + goto fail; + if ((*log != '\0') != expect_warning) { + VIR_FREE(log); + goto fail; + } VIR_FREE(log); - goto fail; } - VIR_FREE(log); if (!virDomainDefCheckABIStability(vmdef, vmdef)) { fprintf(stderr, "ABI stability check failed on %s", xml); diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 7a5b50d..26d63d3 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -284,7 +284,8 @@ static int testCompareXMLToArgvFiles(const char *xml, if (!(vmdef = virDomainDefParseFile(xml, driver.caps, driver.xmlopt, QEMU_EXPECTED_VIRT_TYPES, VIR_DOMAIN_XML_INACTIVE))) { - if (flags & FLAG_EXPECT_PARSE_ERROR) + if (!virtTestOOMActive() && + (flags & FLAG_EXPECT_PARSE_ERROR)) goto ok; goto out; } @@ -357,7 +358,8 @@ static int testCompareXMLToArgvFiles(const char *xml, migrateFrom, migrateFd, NULL, VIR_NETDEV_VPORT_PROFILE_OP_NO_OP, &testCallbacks))) { - if (flags & FLAG_EXPECT_FAILURE) { + if (!virtTestOOMActive() && + (flags & FLAG_EXPECT_FAILURE)) { ret = 0; if (virTestGetDebug() > 1) fprintf(stderr, "Got expected error: %s\n", @@ -371,7 +373,8 @@ static int testCompareXMLToArgvFiles(const char *xml, goto out; } - if (!!virGetLastError() != !!(flags & FLAG_EXPECT_ERROR)) { + if (!virtTestOOMActive() && + (!!virGetLastError() != !!(flags & FLAG_EXPECT_ERROR))) { if (virTestGetDebug() && (log = virtTestLogContentAndReset())) fprintf(stderr, "\n%s", log); goto out; @@ -392,7 +395,8 @@ static int testCompareXMLToArgvFiles(const char *xml, } ok: - if (flags & FLAG_EXPECT_ERROR) { + if (!virtTestOOMActive() && + (flags & FLAG_EXPECT_ERROR)) { /* need to suppress the errors */ virResetLastError(); } diff --git a/tests/qemuxmlnstest.c b/tests/qemuxmlnstest.c index 9426bf7..20a5ccd 100644 --- a/tests/qemuxmlnstest.c +++ b/tests/qemuxmlnstest.c @@ -122,15 +122,17 @@ static int testCompareXMLToArgvFiles(const char *xml, &testCallbacks))) goto fail; - if (!!virGetLastError() != expectError) { - if (virTestGetDebug() && (log = virtTestLogContentAndReset())) - fprintf(stderr, "\n%s", log); - goto fail; - } + if (!virtTestOOMActive()) { + if (!!virGetLastError() != expectError) { + if (virTestGetDebug() && (log = virtTestLogContentAndReset())) + fprintf(stderr, "\n%s", log); + goto fail; + } - if (expectError) { - /* need to suppress the errors */ - virResetLastError(); + if (expectError) { + /* need to suppress the errors */ + virResetLastError(); + } } if (!(actualargv = virCommandToString(cmd))) diff --git a/tests/testutils.c b/tests/testutils.c index 32fe374..52d07eb 100644 --- a/tests/testutils.c +++ b/tests/testutils.c @@ -47,6 +47,13 @@ #include "virprocess.h" #include "virstring.h" +#ifdef TEST_OOM +# ifdef TEST_OOM_TRACE +# include <dlfcn.h> +# include <execinfo.h> +# endif +#endif + #ifdef HAVE_PATHS_H # include <paths.h> #endif @@ -64,12 +71,37 @@ static unsigned int testDebug = -1; static unsigned int testVerbose = -1; static unsigned int testExpensive = -1; +#ifdef TEST_OOM +static unsigned int testOOM = 0; +static unsigned int testOOMStart = -1; +static unsigned int testOOMEnd = -1; +static unsigned int testOOMTrace = 0; +# ifdef TEST_OOM_TRACE +void *testAllocStack[30]; +int ntestAllocStack; +# endif +#endif +static bool testOOMActive = false; + static size_t testCounter = 0; static size_t testStart = 0; static size_t testEnd = 0; char *progname; +bool virtTestOOMActive(void) +{ + return testOOMActive; +} + +#ifdef TEST_OOM_TRACE +static void virTestAllocHook(int nalloc ATTRIBUTE_UNUSED, + void *opaque ATTRIBUTE_UNUSED) +{ + ntestAllocStack = backtrace(testAllocStack, ARRAY_CARDINALITY(testAllocStack)); +} +#endif + void virtTestResult(const char *name, int ret, const char *msg, ...) { va_list vargs; @@ -108,6 +140,35 @@ void virtTestResult(const char *name, int ret, const char *msg, ...) va_end(vargs); } +#ifdef TEST_OOM_TRACE +static void +virTestShowTrace(void) +{ + size_t j; + for (j = 2; j < ntestAllocStack; j++) { + Dl_info info; + char *cmd; + + dladdr(testAllocStack[j], &info); + if (info.dli_fname && + strstr(info.dli_fname, ".so")) { + if (virAsprintf(&cmd, "addr2line -f -e %s %p", + info.dli_fname, + ((void*)((unsigned long long)testAllocStack[j] + - (unsigned long long)info.dli_fbase))) < 0) + continue; + } else { + if (virAsprintf(&cmd, "addr2line -f -e %s %p", + (char*)(info.dli_fname ? info.dli_fname : "<unknown>"), + testAllocStack[j]) < 0) + continue; + } + ignore_value(system(cmd)); + VIR_FREE(cmd); + } +} +#endif + /* * Runs test * @@ -154,7 +215,7 @@ virtTestRun(const char *title, !((testCounter-1) % 40)) { fprintf(stderr, " %-3zu\n", (testCounter-1)); fprintf(stderr, " "); - } + } if (ret == 0) fprintf(stderr, "."); else if (ret == EXIT_AM_SKIP) @@ -163,6 +224,77 @@ virtTestRun(const char *title, fprintf(stderr, "!"); } +#ifdef TEST_OOM + if (testOOM && ret != EXIT_AM_SKIP) { + int nalloc; + int oomret; + int start, end; + size_t i; + virResetLastError(); + virAllocTestInit(); +# ifdef TEST_OOM_TRACE + virAllocTestHook(virTestAllocHook, NULL); +# endif + oomret = body(data); + nalloc = virAllocTestCount(); + fprintf(stderr, " Test OOM for nalloc=%d ", nalloc); + if (testOOMStart == -1 || + testOOMEnd == -1) { + start = 0; + end = nalloc; + } else { + start = testOOMStart; + end = testOOMEnd + 1; + } + testOOMActive = true; + for (i = start; i < end; i++) { + bool missingFail = false; +# ifdef TEST_OOM_TRACE + memset(testAllocStack, 0, ARRAY_CARDINALITY(testAllocStack)); + ntestAllocStack = 0; +# endif + virAllocTestOOM(i + 1, 1); + oomret = body(data); + + /* fprintf() disabled because XML parsing APIs don't allow + * distinguish between element / attribute not present + * in the XML (which is non-fatal), vs OOM / malformed + * which should be fatal. Thus error reporting for + * optionally present XML is mostly broken. + */ + if (oomret == 0) { + missingFail = true; +# if 0 + fprintf(stderr, " alloc %zu failed but no err status\n", i + 1); +# endif + } else { + virErrorPtr lerr = virGetLastError(); + if (!lerr) { +# if 0 + fprintf(stderr, " alloc %zu failed but no error report\n", i + 1); +# endif + missingFail = true; + } + } + if ((missingFail && testOOMTrace) || (testOOMTrace > 1)) { + fprintf(stderr, "%s", "!"); +# ifdef TEST_OOM_TRACE + virTestShowTrace(); +# endif + ret = -1; + } else { + fprintf(stderr, "%s", "."); + } + } + testOOMActive = false; + if (ret == 0) + fprintf(stderr, " OK\n"); + else + fprintf(stderr, " FAILED\n"); + virAllocTestInit(); + } +#endif /* TEST_OOM */ + return ret; } @@ -191,7 +323,6 @@ virtTestLoadFile(const char *file, char **buf) tmplen = buflen = st.st_size + 1; if (VIR_ALLOC_N(*buf, buflen) < 0) { - fprintf(stderr, "%s: larger than available memory (> %d)\n", file, buflen); VIR_FORCE_FCLOSE(fp); return -1; } @@ -467,7 +598,8 @@ virtTestLogOutput(virLogSource source ATTRIBUTE_UNUSED, { struct virtTestLogData *log = data; virCheckFlags(VIR_LOG_STACK_TRACE,); - virBufferAsprintf(&log->buf, "%s: %s", timestamp, str); + if (!testOOMActive) + virBufferAsprintf(&log->buf, "%s: %s", timestamp, str); } static void @@ -535,6 +667,9 @@ int virtTestMain(int argc, { int ret; char *testRange = NULL; +#ifdef TEST_OOM + char *oomstr; +#endif if (!virFileExists(abs_srcdir)) return EXIT_AM_HARDFAIL; @@ -590,6 +725,60 @@ int virtTestMain(int argc, } } +#ifdef TEST_OOM + if ((oomstr = getenv("VIR_TEST_OOM")) != NULL) { + char *next; + if (testDebug == -1) + testDebug = 1; + testOOM = 1; + if (oomstr[0] != '\0' && + oomstr[1] == ':') { + if (virStrToLong_ui(oomstr + 2, &next, 10, &testOOMStart) < 0) { + fprintf(stderr, "Cannot parse range %s\n", oomstr); + return EXIT_FAILURE; + } + if (*next == '\0') { + testOOMEnd = testOOMStart; + } else { + if (*next != '-') { + fprintf(stderr, "Cannot parse range %s\n", oomstr); + return EXIT_FAILURE; + } + if (virStrToLong_ui(next+1, NULL, 10, &testOOMEnd) < 0) { + fprintf(stderr, "Cannot parse range %s\n", oomstr); + return EXIT_FAILURE; + } + } + } else { + testOOMStart = -1; + testOOMEnd = -1; + } + } + +# ifdef TEST_OOM_TRACE + if ((oomstr = getenv("VIR_TEST_OOM_TRACE")) != NULL) { + if (virStrToLong_ui(oomstr, NULL, 10, &testOOMTrace) < 0) { + fprintf(stderr, "Cannot parse oom trace %s\n", oomstr); + return EXIT_FAILURE; + } + } +# else + if (getenv("VIR_TEST_OOM_TRACE")) { + fprintf(stderr, "%s", "OOM test tracing not enabled in this build\n"); + return EXIT_FAILURE; + } +# endif +#else /* TEST_OOM */ + if (getenv("VIR_TEST_OOM")) { + fprintf(stderr, "%s", "OOM testing not enabled in this build\n"); + return EXIT_FAILURE; + } + if (getenv("VIR_TEST_OOM_TRACE")) { + fprintf(stderr, "%s", "OOM test tracing not enabled in this build\n"); + return EXIT_FAILURE; + } +#endif /* TEST_OOM */ + ret = (func)(); virResetLastError(); diff --git a/tests/testutils.h b/tests/testutils.h index 674d3df..29eb9d9 100644 --- a/tests/testutils.h +++ b/tests/testutils.h @@ -44,6 +44,8 @@ extern char *progname; # error Fix Makefile.am # endif +bool virtTestOOMActive(void); + void virtTestResult(const char *name, int ret, const char *msg, ...) ATTRIBUTE_FMT_PRINTF(3,4); int virtTestRun(const char *title, -- 1.8.5.3

2 1

[libvirt] Schedule for upcoming release of 1.2.2
by Daniel Veillard 18 Feb '14

18 Feb '14

Since February ends up on the 28, I think it makes sense to enter the freeze for 1.2.2 next week-end if we want to have it by the end of the month, so please try to get features pushed this week, well if you want them in the next release, thanks, Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

4 5

[libvirt] [PATCH 0/8 v3] Avoid unsafe usage of /proc/$PID/root in LXC driver
by Daniel P. Berrange 18 Feb '14

18 Feb '14

An update of https://www.redhat.com/archives/libvir-list/2014-February/msg00401.html Eric had previously suggested that we could have our fork helper pass by a pre-opened file descriptor and then label that, so we can move the labelling code out of the subprocess. While I believe that is technically possible, it plays havoc with the security driver APIs. We'd basically have to create an entire new set of APIs that take an FD instead of path / object in virSecurityManager. I don't think that's a net win in terms of complexity added. Considering what we're running in the fork helper - We're Linux only so can rely on sane glibc malloc behaviour - We're already using security manager calls in the QEMU driver fork helper - We've protected the logging + error APIs in virFork So I think we'll get away with bending the POSIX rules on async safe functions in this instance. Changes in this version - Avoid use of virCgroupAllowDeviceByPath where we already have the major/minor number - Avoid overwriting errors set by virCgroupAllow* - Use return value check of < 0 instead of != 0 - Other misc typos Eric mentioned Daniel P. Berrange (7): Add virFileMakeParentPath helper function Add helper for running code in separate namespaces Avoid unsafe use of /proc/$PID/root in LXC disk hotplug Avoid unsafe use of /proc/$PID/root in LXC USB hotplug Avoid unsafe use of /proc/$PID/root in LXC block hostdev hotplug Avoid unsafe use of /proc/$PID/root in LXC chardev hostdev hotplug Avoid unsafe use of /proc/$PID/root in LXC hotunplug code Eric Blake (1): Avoid unsafe use of /proc/$PID/root in LXC shutdown/reboot code src/libvirt_private.syms | 2 + src/lxc/lxc_driver.c | 507 ++++++++++++++++++++++++----------------------- src/util/virfile.c | 27 +++ src/util/virfile.h | 1 + src/util/virinitctl.c | 26 +-- src/util/virinitctl.h | 5 +- src/util/virprocess.c | 107 ++++++++++ src/util/virprocess.h | 11 + 8 files changed, 418 insertions(+), 268 deletions(-) -- 1.8.5.3

2 16

[libvirt] libvirtd ssl configuration
by Гусев Павел 17 Feb '14

17 Feb '14

Hi! I found little semantics bug: [13:53:40] root@dedicated-04:~ # LC_ALL=C libvirtd -h libvirtd: invalid option -- 'h' Usage: libvirtd [options] Options: -v | --verbose Verbose messages. -d | --daemon Run as a daemon & write PID file. -l | --listen Listen for TCP/IP connections. -t | --timeout <secs> Exit after timeout period. -f | --config <file> Configuration file. | --version Display version information. -p | --pid-file <file> Change name of PID file. libvirt management daemon: Default paths: Configuration file (unless overridden by -f): /etc/libvirt/libvirtd.conf Sockets: /var/run/libvirt/libvirt-sock /var/run/libvirt/libvirt-sock-ro TLS: CA certificate: /etc/pki/CA/caert.pem Server certificate: /etc/pki/libvirt/servercert.pem Server private key: /etc/pki/libvirt/private/serverkey.pem PID file (unless overridden by -p): /var/run/libvirtd.pid I think that caert.pem should be cacert.pem =) Tnx. С уважением, Гусев Павел Руководитель отдела системного администрирования QSOFT | Ведущий web-интегратор офис 7(495) 771-7363 #110 | моб. 7(926) 850-1108 pgusev(a)qsoft.ru Москва, Авангардная улица, 3 | qsoft.ru San Francisco, 222 Columbus Ave | qsoftus.com

2 2

[libvirt] [PATCH 0/2] Taint domains altered by hook scripts
by Michal Privoznik 17 Feb '14

17 Feb '14

Currently, we only allow XML changing in qemu driver and nowhere else. Michal Privoznik (2): virDomainTaintFlags: Introduce VIR_DOMAIN_TAINT_HOOK qemu: Implement VIR_DOMAIN_TAINT_HOOK src/conf/domain_conf.c | 3 ++- src/conf/domain_conf.h | 1 + src/qemu/qemu_domain.c | 4 ++++ src/qemu/qemu_domain.h | 2 ++ src/qemu/qemu_migration.c | 10 ++++++++++ 5 files changed, 19 insertions(+), 1 deletion(-) -- 1.8.5.2

2 6

[libvirt] Exposing and calculating CPU APIC IDs (was Re: [Qemu-devel] [RFC 1/3] target-i386: moving registers of vmstate from cpu_exec_init() to x86_cpu_realizefn())
by Eduardo Habkost 17 Feb '14

17 Feb '14

On Wed, Jan 15, 2014 at 03:37:04PM +0100, Igor Mammedov wrote: > On Wed, 15 Jan 2014 20:24:01 +0800 > Chen Fan <chen.fan.fnst(a)cn.fujitsu.com> wrote: > > On Tue, 2014-01-14 at 11:40 +0100, Igor Mammedov wrote: > > > On Tue, 14 Jan 2014 17:27:20 +0800 > > > Chen Fan <chen.fan.fnst(a)cn.fujitsu.com> wrote: > > > > > > > the intend of this patch is to register cpu vmstates with apic id instead of cpu > > > > index, due to the property setting of apic_id is behind the cpu initialization. so > > > > we move the registers of cpu vmstate from cpu_exec_init() to x86_cpu_realizefn() to > > > > let the set apicid as the parameter. > > > > > > > > Signed-off-by: Chen Fan <chen.fan.fnst(a)cn.fujitsu.com> > > > > --- > > > > exec.c | 5 +++++ > > > > target-i386/cpu.c | 9 +++++++++ > > > > 2 files changed, 14 insertions(+) > > > > > > > > diff --git a/exec.c b/exec.c > > > > index 7e49e8e..9be5855 100644 > > > > --- a/exec.c > > > > +++ b/exec.c > > > > @@ -438,7 +438,9 @@ CPUState *qemu_get_cpu(int index) > > > > void cpu_exec_init(CPUArchState *env) > > > > { > > > > CPUState *cpu = ENV_GET_CPU(env); > > > > +#if !defined(TARGET_I386) > > > > CPUClass *cc = CPU_GET_CLASS(cpu); > > > > +#endif > > > > CPUState *some_cpu; > > > > int cpu_index; > > > > > > > > @@ -460,6 +462,8 @@ void cpu_exec_init(CPUArchState *env) > > > > #if defined(CONFIG_USER_ONLY) > > > > cpu_list_unlock(); > > > > #endif > > > > + > > > > +#if !defined(TARGET_I386) > > > > if (qdev_get_vmsd(DEVICE(cpu)) == NULL) { > > > > vmstate_register(NULL, cpu_index, &vmstate_cpu_common, cpu); > > > > } > > > > @@ -472,6 +476,7 @@ void cpu_exec_init(CPUArchState *env) > > > > if (cc->vmsd != NULL) { > > > > vmstate_register(NULL, cpu_index, cc->vmsd, cpu); > > > > } > > > > +#endif /* !TARGET_I386 */ > > > > } > > > > > > > > #if defined(TARGET_HAS_ICE) > > > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > > > > index 967529a..dada6f6 100644 > > > > --- a/target-i386/cpu.c > > > > +++ b/target-i386/cpu.c > > > > @@ -2552,6 +2552,7 @@ static void x86_cpu_apic_realize(X86CPU *cpu, Error **errp) > > > > static void x86_cpu_realizefn(DeviceState *dev, Error **errp) > > > > { > > > > CPUState *cs = CPU(dev); > > > > + CPUClass *cc = CPU_GET_CLASS(cs); > > > > X86CPU *cpu = X86_CPU(dev); > > > > X86CPUClass *xcc = X86_CPU_GET_CLASS(dev); > > > > CPUX86State *env = &cpu->env; > > > > @@ -2615,6 +2616,14 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp) > > > > cpu_reset(cs); > > > > > > > > xcc->parent_realize(dev, &local_err); > > > > + > > > > + if (qdev_get_vmsd(DEVICE(cs)) == NULL) { > > > > + vmstate_register(NULL, env->cpuid_apic_id, &vmstate_cpu_common, cs); > > > > + } > > > > + > > > > + if (cc->vmsd != NULL) { > > > > + vmstate_register(NULL, env->cpuid_apic_id, cc->vmsd, cs); > > > > + } > > > how about doing it in common CPUclass.realize() > > > you can use get_arch_id() for getting CPU id, it returns cpu_index by default > > > and apic_id for target-i386. > > > > Thanks for your kind suggestion, does this mean we can directly move > > vmstate_register to cpu_common_realizefn()? > yep, that is a gist of it. > > There is more to the issue with discontinuous CPUs, a lot of code still > use cpu_index and the way it's allocated is not compatible with discontinuous > CPUs, so this issue should be fixed as well. > > Also you propose to use a raw apic id with CLI/user interface. > I recall there were objections to it since APIC ID contains topology > information and it's not trivial for user to get it right. > The last idea that was discussed to fix it was not expose APIC ID to > user but rather introduce QOM hierarchy like: > /machine/node/N/socket/X/core/Y/thread/Z > and use it in user interface as a means to specify an arbitrary CPU > and let QEMU calculate APIC ID based on this path. > > But nobody took on implementing it yet. We're taking so long to get a decent interface implemented, that part of me is considering exposing the APIC ID directly like suggested before, and requiring libvirt to calculate topology-aware APIC IDs[1] to properly implement CPU hotplug (and possibly for other tasks). Another part of me is hoping that the libvirt developers ask us to please not do that, so I can use it as argument against exposing the APIC IDs directly the next time we discuss this. :) [1] See target-i386/topology.h for references -- Eduardo

4 10

[libvirt] [PATCH] Revert "storage: Introduce internal pool support"
by Peter Krempa 17 Feb '14

17 Feb '14

The internal pools were an idea in one of the first iterations of the gluster series that deemed unused. Somehow still this got pushed. Remove it as the internal flag isn't needed. This reverts commit 362da8209d760fc1acd3a1c8df5b04aa676492eb. --- src/conf/storage_conf.c | 3 --- src/conf/storage_conf.h | 1 - src/storage/storage_driver.c | 12 ++++-------- 3 files changed, 4 insertions(+), 12 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index eaa9325..e4232e9 100644 --- a/src/conf/storage_conf.c +++ b/src/conf/storage_conf.c @@ -2172,9 +2172,6 @@ static bool virStoragePoolMatch(virStoragePoolObjPtr poolobj, unsigned int flags) { - if (poolobj->internal) - return false; - /* filter by active state */ if (MATCH(VIR_CONNECT_LIST_STORAGE_POOLS_FILTERS_ACTIVE) && !((MATCH(VIR_CONNECT_LIST_STORAGE_POOLS_ACTIVE) && diff --git a/src/conf/storage_conf.h b/src/conf/storage_conf.h index cada861..251b968 100644 --- a/src/conf/storage_conf.h +++ b/src/conf/storage_conf.h @@ -332,7 +332,6 @@ struct _virStoragePoolObj { int active; int autostart; unsigned int asyncjobs; - bool internal; virStoragePoolDefPtr def; virStoragePoolDefPtr newDef; diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 64451c5..e0ebdb0 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -376,8 +376,7 @@ storageConnectNumOfStoragePools(virConnectPtr conn) { virStoragePoolObjPtr obj = driver->pools.objs[i]; virStoragePoolObjLock(obj); if (virConnectNumOfStoragePoolsCheckACL(conn, obj->def) && - virStoragePoolObjIsActive(obj) && - !obj->internal) + virStoragePoolObjIsActive(obj)) nactive++; virStoragePoolObjUnlock(obj); } @@ -402,8 +401,7 @@ storageConnectListStoragePools(virConnectPtr conn, virStoragePoolObjPtr obj = driver->pools.objs[i]; virStoragePoolObjLock(obj); if (virConnectListStoragePoolsCheckACL(conn, obj->def) && - virStoragePoolObjIsActive(obj) && - !obj->internal) { + virStoragePoolObjIsActive(obj)) { if (VIR_STRDUP(names[got], obj->def->name) < 0) { virStoragePoolObjUnlock(obj); goto cleanup; @@ -437,8 +435,7 @@ storageConnectNumOfDefinedStoragePools(virConnectPtr conn) { virStoragePoolObjPtr obj = driver->pools.objs[i]; virStoragePoolObjLock(obj); if (virConnectNumOfDefinedStoragePoolsCheckACL(conn, obj->def) && - !virStoragePoolObjIsActive(obj) && - !obj->internal) + !virStoragePoolObjIsActive(obj)) nactive++; virStoragePoolObjUnlock(obj); } @@ -463,8 +460,7 @@ storageConnectListDefinedStoragePools(virConnectPtr conn, virStoragePoolObjPtr obj = driver->pools.objs[i]; virStoragePoolObjLock(obj); if (virConnectListDefinedStoragePoolsCheckACL(conn, obj->def) && - !virStoragePoolObjIsActive(obj) && - !obj->internal) { + !virStoragePoolObjIsActive(obj)) { if (VIR_STRDUP(names[got], obj->def->name) < 0) { virStoragePoolObjUnlock(obj); goto cleanup; -- 1.8.5.3

2 2

[libvirt] [PATCH v8 0/7] Support keyboard device
by Li Zhang 17 Feb '14

17 Feb '14

From: Li Zhang <zhlcindy(a)linux.vnet.ibm.com> This patchset is to add keyboard input device. For PPC64, it doesn't support a default keyboard device when the graphic is enabled. Libvirt supports QEMU command line as "-device VGA" which won't create any keyboard device for it. So it requires libvirt to add a default USB keyboard device for it. This patchset is to add keyboard input device and a default USB keyboard for PPC64. The related discussion in QEMU community: http://lists.nongnu.org/archive/html/qemu-devel/2013-11/msg01734.html Li Zhang (7): conf: Add a keyboard input device type conf: Add one interface to add default input devices conf: Remove the implicit PS2 mouse for non-X86 platforms and add an implicit PS2 keyboard device for X86 platforms. qemu_cap: Add USB keyboard capability qemu: format qemu command line for USB keyboard xen: format xen command line for USB keyboard Add a default USB keyboard and USB mouse for PPC64 v8 -> v7: * Add USB keyboard output XML format when VIR_DOMAIN_XML_MIGRATABLE isn't set. (Daniel P. && Jan Tomko) * Fix test cases because of XML changes. v7 -> v6: * Corret indention errors in code. (Jan Tomko) * Correct make check error in xen driver. (Jan Tomko) * Split 5/6 to 2 parts, qemu and xen. (Jan Tomko) v6 -> v5: * Change kbd to keyboard, and correct -usbdevice parameter. * Remove implicit PS/2 keyboard output in XML in case older libvirtd can read it. (Jan Tomko) * Remove implicit keyboard for XEN to make it safer. v5 -> v4: * Add PS/2 KBD definition in XML file. (Daniel.P.Berrange) * Allow PS/2 KBD devices and set KBD default bus as PS2 for X86, USB for non-x86. (Daniel.P.Berrange) * Add an implicit PS/2 KBD as PS/2 mouse. (Danniel.P.Berrange) v4 -> v3: * Don't remove PS2 mouse device for other virtualization drivers (Jan Tomko). v3 -> v2: * Handle the KBD device type in xen and QEMU driver. (Daniel.P.Berrange) * Remove PS2 mouse device for non-X86 platforms. * Move virDomainDefMaybeAddInput to a new patch. (Jan Tomko) * Replace VIR_REALLOC_N with VIR_APPEND_ELEMENT. (Jan Tomoko) * Fix several typos. (Jan Tomoko) * Add a virReportError when QEMU_CAPS_DEVICE_USB_KBD can't be gotten. (Jan Tomoko) v2 -> v1: * change ifs to switch clause. * reconstruct the patches docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c | 116 ++++++++++++++------- src/conf/domain_conf.h | 5 + src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 3 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 41 ++++++-- src/qemu/qemu_domain.c | 23 +++- src/util/virarch.h | 2 + src/xenxs/xen_sxpr.c | 27 +++-- src/xenxs/xen_xm.c | 30 ++++-- tests/qemucapabilitiesdata/caps_1.2.2-1.caps | 1 + tests/qemucapabilitiesdata/caps_1.3.1-1.caps | 1 + tests/qemucapabilitiesdata/caps_1.4.2-1.caps | 1 + tests/qemucapabilitiesdata/caps_1.5.3-1.caps | 1 + tests/qemucapabilitiesdata/caps_1.6.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_1.6.50-1.caps | 1 + tests/qemuhelptest.c | 8 ++ ...qemuhotplug-console-compat-2+console-virtio.xml | 1 + .../qemuxml2argv-console-compat-2.xml | 1 + .../qemuxml2argv-graphics-listen-network.xml | 1 + .../qemuxml2argv-graphics-listen-network2.xml | 1 + .../qemuxml2argv-graphics-sdl-fullscreen.xml | 1 + .../qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml | 1 + .../qemuxml2argv-graphics-spice-compression.xml | 1 + .../qemuxml2argv-graphics-spice-qxl-vga.xml | 1 + .../qemuxml2argv-graphics-spice-timeout.xml | 2 + .../qemuxml2argv-graphics-spice.xml | 1 + .../qemuxml2argv-graphics-vnc-policy.xml | 1 + .../qemuxml2argv-graphics-vnc-sasl.xml | 1 + .../qemuxml2argv-graphics-vnc-socket.xml | 1 + .../qemuxml2argv-graphics-vnc-tls.xml | 1 + .../qemuxml2argv-graphics-vnc-websocket.xml | 1 + .../qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml | 1 + tests/qemuxml2argvdata/qemuxml2argv-input-xen.xml | 1 + .../qemuxml2argv-net-bandwidth.xml | 1 + tests/qemuxml2argvdata/qemuxml2argv-pci-bridge.xml | 1 + .../qemuxml2argvdata/qemuxml2argv-pseries-disk.xml | 3 +- .../qemuxml2argv-pseries-usb-kbd.args | 9 ++ .../qemuxml2argv-pseries-usb-kbd.xml | 19 ++++ .../qemuxml2argv-serial-spiceport.xml | 1 + tests/qemuxml2argvtest.c | 3 + .../qemuxml2xmlout-graphics-listen-network2.xml | 1 + .../qemuxml2xmlout-graphics-spice-timeout.xml | 1 + tests/vmx2xmldata/vmx2xml-graphics-vnc.xml | 1 + 45 files changed, 256 insertions(+), 66 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-usb-kbd.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-usb-kbd.xml -- 1.8.2.1

2 11

[libvirt] [PATCH 0/5] fix query-command-line-options
by Amos Kong 17 Feb '14

17 Feb '14

This patchset fixed some issues of query-command-line-options: * some new options haven't arguments can't be queried. (eg: -enable-fips) * some legcy options have arguments can't be queried. (eg: -vnc display) More discussion: http://marc.info/?l=qemu-devel&m=139081830416684&w=2 Amos Kong (5): qmp: rename query_option_descs() to get_param_infolist() introduce two marcos to dump the options info query-command-line-options: query all the options in qemu-options.hx introduce QEMU_OPTIONS_GENERATE_HELPMSG query-command-line-options: return help message for legacy options qapi-schema.json | 5 ++++- qemu-options-wrapper.h | 27 +++++++++++++++++++++++++++ util/qemu-config.c | 50 +++++++++++++++++++++++++++++++++++++++++--------- 3 files changed, 72 insertions(+), 10 deletions(-) -- 1.8.4.2

4 19

[libvirt] [PATCH v6 0/6] Support keyboard device
by Li Zhang 17 Feb '14

17 Feb '14

From: Li Zhang <zhlcindy(a)linux.vnet.ibm.com> This patchset is to add keyboard input device. For PPC64, it doesn't support a default keyboard device when the graphic is enabled. Libvirt supports QEMU command line as "-device VGA" which won't create any keyboard device for it. So it requires libvirt to add a default USB keyboard device for it. This patchset is to add keyboard input device and a default USB keyboard for PPC64. The related discussion in QEMU community: http://lists.nongnu.org/archive/html/qemu-devel/2013-11/msg01734.html Li Zhang (6): conf: Add a keyboard input device type conf: Add one interface to add default input devices conf: Remove the implicit PS2 mouse for non-X86 platforms and add an implicit PS2 keyboard device for X86 platforms. qemu_cap: Add USB keyboard capability qemu: parse qemu command line for USB keyboard Add a default USB keyboard and USB mouse for PPC64 v6 -> v5: * Change kbd to keyboard, and correct -usbdevice parameter. * Remove implicit PS/2 keyboard output in XML in case older libvirtd can read it. (Jan Tomko) * Remove implicit keyboard for XEN to make it safer. v5 -> v4: * Add PS/2 KBD definition in XML file. (Daniel.P.Berrange) * Allow PS/2 KBD devices and set KBD default bus as PS2 for X86, USB for non-x86. (Daniel.P.Berrange) * Add an implicit PS/2 KBD as PS/2 mouse. (Danniel.P.Berrange) v4 -> v3: * Don't remove PS2 mouse device for other virtualization drivers (Jan Tomko). v3 -> v2: * Handle the KBD device type in xen and QEMU driver. (Daniel.P.Berrange) * Remove PS2 mouse device for non-X86 platforms. * Move virDomainDefMaybeAddInput to a new patch. (Jan Tomko) * Replace VIR_REALLOC_N with VIR_APPEND_ELEMENT. (Jan Tomoko) * Fix several typos. (Jan Tomoko) * Add a virReportError when QEMU_CAPS_DEVICE_USB_KBD can't be gotten. (Jan Tomoko) v2 -> v1: * change ifs to switch clause. * reconstruct the patches docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c | 115 ++++++++++++++------- src/conf/domain_conf.h | 5 + src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 3 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 41 ++++++-- src/qemu/qemu_domain.c | 23 ++++- src/util/virarch.h | 2 + src/xenxs/xen_sxpr.c | 27 +++-- src/xenxs/xen_xm.c | 30 ++++-- tests/qemucapabilitiesdata/caps_1.2.2-1.caps | 1 + tests/qemucapabilitiesdata/caps_1.3.1-1.caps | 1 + tests/qemucapabilitiesdata/caps_1.4.2-1.caps | 1 + tests/qemucapabilitiesdata/caps_1.5.3-1.caps | 1 + tests/qemucapabilitiesdata/caps_1.6.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_1.6.50-1.caps | 1 + tests/qemuhelptest.c | 8 ++ .../qemuxml2argvdata/qemuxml2argv-pseries-disk.xml | 3 +- .../qemuxml2argv-pseries-usb-kbd.args | 9 ++ .../qemuxml2argv-pseries-usb-kbd.xml | 19 ++++ tests/qemuxml2argvtest.c | 3 + 22 files changed, 229 insertions(+), 68 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-usb-kbd.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-usb-kbd.xml -- 1.8.2.1

3 21

[libvirt] ANNOUNCE: virt-manager 1.0.0 released
by Cole Robinson 15 Feb '14

15 Feb '14

I'm happy to announce the release of virt-manager 1.0.0! Our version numbers were starting to get awkward, and this release was suitably featureful, so it felt like time to bump the major version. (And it's trendy these days, right?). virt-manager is a desktop application for managing KVM, Xen, and LXC virtualization via libvirt. The release can be downloaded from: http://virt-manager.org/download.html The direct download links are: http://virt-manager.org/download/sources/virt-manager/virt-manager-1.0.0.ta… This release includes: - virt-manager: Snapshot support - New tool virt-xml: Edit libvirt XML in one shot from the command line: http://www.redhat.com/archives/libvir-list/2014-January/msg01226.html - Improved defaults: qcow2, USB2, host CPU model, guest agent channel, ... - Introspect command line options like --disk=? or --network=help - The virt-image tool will be removed before the next release, speak up if you have a good reason not to remove it. - virt-manager: Support arm vexpress VM creation - virt-manager: Add guest memory usage graphs (Thorsten Behrens) - virt-manager: UI for editing <filesystem> devices (Cédric Bosdonnat) - Spice USB redirection support (Guannan Ren) - <tpm> UI and command line support (Stefan Berger) - <rng> UI and command line support (Giuseppe Scrivano) - <panic> UI and command line support (Chen Hanxiao) - <blkiotune> command line support (Chen Hanxiao) - virt-manager: support for glusterfs storage pools (Giuseppe Scrivano) - cli: New options --memory, --features, --clock, --metadata, --pm - Greatly improve app responsiveness when connecting to remote hosts - Lots of UI cleanup and improvements Thanks to everyone who has contributed to this release through testing, bug reporting, submitting patches, and otherwise sending in feedback! Thanks, Cole

1 0

[libvirt] [PATCH v1 0/4] Time setting and getting in qemu guests
by Michal Privoznik 14 Feb '14

14 Feb '14

This can be used all, but 'virsh domtime --sync $dom' is dependent on this qemu patch: http://lists.nongnu.org/archive/html/qemu-devel/2014-01/msg04293.html Anyway, once all the patches are merged, users can simply do: virsh resume $dom virsh domtime --sync $dom and their guest time won't be off after the resume. Michal Privoznik (4): Introduce virDomain{Get,Set}Time APIs remote: Implement remote{Get,Set}Time virsh: Expose virDomain{Get,Set}Time qemu: Implement virDomain{Get,Set}Time daemon/remote.c | 35 +++++++++++ include/libvirt/libvirt.h.in | 13 +++++ src/access/viraccessperm.c | 2 +- src/access/viraccessperm.h | 6 ++ src/driver.h | 13 +++++ src/libvirt.c | 91 +++++++++++++++++++++++++++++ src/libvirt_public.syms | 6 ++ src/qemu/qemu_agent.c | 81 ++++++++++++++++++++++++++ src/qemu/qemu_agent.h | 6 ++ src/qemu/qemu_driver.c | 135 +++++++++++++++++++++++++++++++++++++++++++ src/remote/remote_driver.c | 32 ++++++++++ src/remote/remote_protocol.x | 31 +++++++++- src/remote_protocol-structs | 16 +++++ tools/virsh-domain-monitor.c | 126 ++++++++++++++++++++++++++++++++++++++++ tools/virsh.pod | 16 +++++ 15 files changed, 607 insertions(+), 2 deletions(-) -- 1.8.5.3

5 18

[libvirt] [PATCH 0/2] Test secret XML parsing and formatting
by Ján Tomko 14 Feb '14

14 Feb '14

Ján Tomko (2): docs: remove <auth> from secret XML format Add tests for secret XML parsing docs/formatsecret.html.in | 2 - tests/Makefile.am | 12 ++- tests/secretschematest | 10 +++ tests/secretxml2xmlin/ephemeral-usage-volume.xml | 7 ++ tests/secretxml2xmlin/usage-ceph.xml | 7 ++ tests/secretxml2xmlin/usage-iscsi.xml | 7 ++ tests/secretxml2xmlin/usage-volume.xml | 7 ++ tests/secretxml2xmltest.c | 98 ++++++++++++++++++++++++ 8 files changed, 147 insertions(+), 3 deletions(-) create mode 100755 tests/secretschematest create mode 100644 tests/secretxml2xmlin/ephemeral-usage-volume.xml create mode 100644 tests/secretxml2xmlin/usage-ceph.xml create mode 100644 tests/secretxml2xmlin/usage-iscsi.xml create mode 100644 tests/secretxml2xmlin/usage-volume.xml create mode 100644 tests/secretxml2xmltest.c -- 1.8.3.2

2 4

[libvirt] [PATCH glib] Fix symfile checks in VPATH build
by Daniel P. Berrange 14 Feb '14

14 Feb '14

The check-symfile and check-symsorting rules were not taking $(srcdir) into account when accessing the symfile paths. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- build-aux/check-symsorting.pl | 3 +-- libvirt-gconfig/Makefile.am | 4 ++-- libvirt-glib/Makefile.am | 4 ++-- libvirt-gobject/Makefile.am | 4 ++-- 4 files changed, 7 insertions(+), 8 deletions(-) Pushed as a build-breaker fix. diff --git a/build-aux/check-symsorting.pl b/build-aux/check-symsorting.pl index 470247c..31b6059 100755 --- a/build-aux/check-symsorting.pl +++ b/build-aux/check-symsorting.pl @@ -19,10 +19,9 @@ use strict; use warnings; -die "syntax: $0 SRCDIR SYMFILE..." unless int(@ARGV) >= 2; +die "syntax: $0 SYMFILE..." unless int(@ARGV) >= 1; my $ret = 0; -my $srcdir = shift; my $incomment = 0; my $name; foreach my $symfile (@ARGV) { diff --git a/libvirt-gconfig/Makefile.am b/libvirt-gconfig/Makefile.am index e32d222..d328ca7 100644 --- a/libvirt-gconfig/Makefile.am +++ b/libvirt-gconfig/Makefile.am @@ -224,14 +224,14 @@ libvirt-gconfig-enum-types.c: $(GCONFIG_HEADER_FILES) libvirt-gconfig-enum-types # rule for libosvirt-gconfig.la. However, checking symbols relies on Linux ELF layout if WITH_LINUX check-symfile: libvirt-gconfig.sym libvirt-gconfig-1.0.la - $(AM_V_GEN)$(PERL) $(top_srcdir)/build-aux/check-symfile.pl libvirt-gconfig.sym \ + $(AM_V_GEN)$(PERL) $(top_srcdir)/build-aux/check-symfile.pl $(srcdir)/libvirt-gconfig.sym \ .libs/libvirt-gconfig-1.0.so else ! WITH_LINUX check-symfile: endif ! WITH_LINUX check-symsorting: $(AM_V_GEN)$(PERL) $(top_srcdir)/build-aux/check-symsorting.pl \ - $(srcdir) libvirt-gconfig.sym + $(srcdir)/libvirt-gconfig.sym check-local: check-symfile check-symsorting -include $(INTROSPECTION_MAKEFILE) diff --git a/libvirt-glib/Makefile.am b/libvirt-glib/Makefile.am index 15b9917..a48cfbb 100644 --- a/libvirt-glib/Makefile.am +++ b/libvirt-glib/Makefile.am @@ -41,14 +41,14 @@ libvirt_glib_1_0_la_LDFLAGS = \ # rule for libosvirt-glib.la. However, checking symbols relies on Linux ELF layout if WITH_LINUX check-symfile: libvirt-glib.sym libvirt-glib-1.0.la - $(AM_V_GEN)$(PERL) $(top_srcdir)/build-aux/check-symfile.pl libvirt-glib.sym \ + $(AM_V_GEN)$(PERL) $(top_srcdir)/build-aux/check-symfile.pl $(srcdir)/libvirt-glib.sym \ .libs/libvirt-glib-1.0.so else ! WITH_LINUX check-symfile: endif ! WITH_LINUX check-symsorting: $(AM_V_GEN)$(PERL) $(top_srcdir)/build-aux/check-symsorting.pl \ - $(srcdir) libvirt-glib.sym + $(srcdir)/libvirt-glib.sym check-local: check-symfile check-symsorting -include $(INTROSPECTION_MAKEFILE) diff --git a/libvirt-gobject/Makefile.am b/libvirt-gobject/Makefile.am index b6b2a5d..516c10f 100644 --- a/libvirt-gobject/Makefile.am +++ b/libvirt-gobject/Makefile.am @@ -124,14 +124,14 @@ CLEANFILES = $(BUILT_SOURCES) # rule for libosvirt-gobject.la. However, checking symbols relies on Linux ELF layout if WITH_LINUX check-symfile: libvirt-gobject.sym libvirt-gobject-1.0.la - $(AM_V_GEN)$(PERL) $(top_srcdir)/build-aux/check-symfile.pl libvirt-gobject.sym \ + $(AM_V_GEN)$(PERL) $(top_srcdir)/build-aux/check-symfile.pl $(srcdir)/libvirt-gobject.sym \ .libs/libvirt-gobject-1.0.so else ! WITH_LINUX check-symfile: endif ! WITH_LINUX check-symsorting: $(AM_V_GEN)$(PERL) $(top_srcdir)/build-aux/check-symsorting.pl \ - $(srcdir) libvirt-gobject.sym + $(srcdir)/libvirt-gobject.sym check-local: check-symfile check-symsorting -include $(INTROSPECTION_MAKEFILE) -- 1.8.5.3

1 0

[libvirt] [PATCH] Forgot to add lxcconf2xmldata to dist.
by Cédric Bosdonnat 14 Feb '14

14 Feb '14

--- tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index 0718a69..9bb61ca 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -72,6 +72,7 @@ EXTRA_DIST = \ domainsnapshotxml2xmlout \ fchostdata \ interfaceschemadata \ + lxcconf2xmldata \ lxcxml2xmldata \ lxcxml2xmloutdata \ networkschematest \ -- 1.8.5.2

2 1

[libvirt] [PATCH] lxc: Add virCgroupSetOwner()
by Daniel P. Berrange 14 Feb '14

14 Feb '14

From: Richard Weinberger <richard(a)nod.at> Add a new helper function to change the permissions of a control group. This function is needed for user namespaces, we need to chmod() the cgroup to the initial uid/gid such that systemd is allowed to use the cgroup. Only the systemd controller is made accessible to the container. Others must remain read-only since it is generally not safe to delegate resource controller write access to unprivileged processes. Signed-off-by: Richard Weinberger <richard(a)nod.at> --- src/libvirt_private.syms | 1 + src/lxc/lxc_cgroup.c | 9 ++++++++ src/util/vircgroup.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++++ src/util/vircgroup.h | 5 +++++ 4 files changed, 69 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 0b28bac..cfa9f75 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1056,6 +1056,7 @@ virCgroupSetMemory; virCgroupSetMemoryHardLimit; virCgroupSetMemorySoftLimit; virCgroupSetMemSwapHardLimit; +virCgroupSetOwner; virCgroupSupportsCpuBW; diff --git a/src/lxc/lxc_cgroup.c b/src/lxc/lxc_cgroup.c index cc0d5e8..0d0d9c0 100644 --- a/src/lxc/lxc_cgroup.c +++ b/src/lxc/lxc_cgroup.c @@ -484,6 +484,15 @@ virCgroupPtr virLXCCgroupCreate(virDomainDefPtr def) &cgroup) < 0) goto cleanup; + /* setup control group permissions for user namespace */ + if (def->idmap.uidmap) { + if (virCgroupSetOwner(cgroup, + def->idmap.uidmap[0].target, + def->idmap.gidmap[0].target, + (1 << VIR_CGROUP_CONTROLLER_SYSTEMD))) + goto cleanup; + } + cleanup: return cgroup; } diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index a6d60c5..2dc6986 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -3253,6 +3253,60 @@ cleanup: } +int virCgroupSetOwner(virCgroupPtr cgroup, + uid_t uid, + gid_t gid, + int controllers) +{ + size_t i; + + for (i = 0; i < VIR_CGROUP_CONTROLLER_LAST; i++) { + char *base, *entry; + DIR *dh; + struct dirent *de; + + if (!((1 << i) & controllers)) + continue; + + if (!cgroup->controllers[i].mountPoint) + continue; + + if (virAsprintf(&base, "%s%s", cgroup->controllers[i].mountPoint, + cgroup->controllers[i].placement) < 0) { + virReportOOMError(); + return -1; + } + + dh = opendir(base); + while ((de = readdir(dh)) != NULL) { + if (STREQ(de->d_name, ".") || + STREQ(de->d_name, "..")) + continue; + + if (virAsprintf(&entry, "%s/%s", base, de->d_name) < 0) { + VIR_FREE(base); + virReportOOMError(); + } + + if (chown(entry, uid, gid) < 0) + virReportSystemError(errno, _("cannot chown '%s' to (%u, %u)"), + entry, uid, gid); + + VIR_FREE(entry); + } + closedir(dh); + + if (chown(base, uid, gid) < 0) + virReportSystemError(errno, _("cannot chown '%s' to (%u, %u)"), + base, uid, gid); + + VIR_FREE(base); + } + + return 0; +} + + /** * virCgroupSupportsCpuBW(): * Check whether the host supports CFS bandwidth. diff --git a/src/util/vircgroup.h b/src/util/vircgroup.h index a70eb18..38d94f3 100644 --- a/src/util/vircgroup.h +++ b/src/util/vircgroup.h @@ -225,4 +225,9 @@ int virCgroupIsolateMount(virCgroupPtr group, bool virCgroupSupportsCpuBW(virCgroupPtr cgroup); +int virCgroupSetOwner(virCgroupPtr cgroup, + uid_t uid, + gid_t gid, + int controllers); + #endif /* __VIR_CGROUP_H__ */ -- 1.8.5.3

6 15

[libvirt] [PATCHv3 0/2] Support IPv6 in port allocator
by Ján Tomko 14 Feb '14

14 Feb '14

v1: Support IPv6 in port allocator https://www.redhat.com/archives/libvir-list/2013-October/msg00007.html v2: https://www.redhat.com/archives/libvir-list/2013-October/msg01313.html bind to v4 and v6 separately v3: fix the embarrasing bug of hardcoding AF_INET anyway added a test that mocks a v4-only system even on systems with IPv6 compiled in Ján Tomko (2): Split out bind() from virPortAllocatorAcquire Support IPv6 in port allocator src/util/virportallocator.c | 106 +++++++++++++++++++++++++++++++------------ tests/virportallocatortest.c | 68 +++++++++++++++++++++++++-- 2 files changed, 143 insertions(+), 31 deletions(-) -- 1.8.3.2

3 5

[libvirt] Destroying a suspended LXC domain
by Richard Weinberger 14 Feb '14

14 Feb '14

Hi! If we suspend a LXC domain libvirt freezes all tasks in the cgroup using the process freezer. Upon destroy libvirt tries to kill all tasks using SIGTERM and later SIGKILL, but as they are frozen the tasks are unkillable. This seems to confuse libvirt, all tasks remain but libvirt forgets the domain. Here a small example: ---cut--- lxc-host1:/etc # /opt/libvirt-dev/bin/virsh domstate my3rdcontainer paused lxc-host1:/etc # /opt/libvirt-dev/bin/virsh destroy my3rdcontainer error: Failed to destroy domain my3rdcontainer error: internal error: Some processes refused to die lxc-host1:/etc # ps fax ... 2118 ? Dsl 0:00 /opt/libvirt-dev/lib/libvirt_lxc --name my3rdcontainer --console 19 --security=none --handshake 22 --backgr 2128 ? Ds 0:00 \_ /sbin/init 2152 ? Ds 0:00 \_ /usr/lib/systemd/systemd-journald 2171 ? Ds 0:00 \_ /bin/dbus-daemon --system --address=systemd: --nofork --nopidfile --systemd-activation 2174 ? Ds 0:00 \_ /usr/lib/systemd/systemd-logind 2189 ? Dsl 0:00 \_ /usr/sbin/rsyslogd -n 2778 ? Ds 0:00 \_ /usr/sbin/cron -n 2782 pts/0 Ds+ 0:00 \_ /sbin/agetty --noclear -s console 115200 38400 9600 2786 ? Ds 0:00 \_ /usr/sbin/sshd -D ... ---cut--- I can think of three options to deal with that. a) Refuse to destroy a suspended LXC domain b) Implicitly resume it upon destroy c) Send a SIGKILL to each task and then thaw all tasks using the process freezer. If the task is woken up the it sees immediately the pending SIGKILL and dies. I'd vote for c) because I want to destroy a LXC domain without resuming it. I.e. I want to kill it to avoid any further IO from the already suspended domain. What do you think? I'd volunteer for a patch. :) Thanks, //richard

4 3

[libvirt] [PATCH] [RFC] lxc: Remove !priv->cgroup case
by Richard Weinberger 14 Feb '14

14 Feb '14

Currently we enforce that every container has a cgroup. So we can delete these two !priv->cgroup branches. Signed-off-by: Richard Weinberger <richard(a)nod.at> --- Hi! Maybe I miss something but I think we can delete these two !priv->cgroup branches. If virLXCCgroupCreate() returns NULL the LXC controller exists. Thanks, //richard --- src/lxc/lxc_process.c | 30 +++++++++--------------------- 1 file changed, 9 insertions(+), 21 deletions(-) diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c index ed729f6..f75d353 100644 --- a/src/lxc/lxc_process.c +++ b/src/lxc/lxc_process.c @@ -203,10 +203,8 @@ static void virLXCProcessCleanup(virLXCDriverPtr driver, virDomainConfVMNWFilterTeardown(vm); - if (priv->cgroup) { - virCgroupRemove(priv->cgroup); - virCgroupFree(&priv->cgroup); - } + virCgroupRemove(priv->cgroup); + virCgroupFree(&priv->cgroup); /* Get machined to terminate the machine as it may not have cleaned it * properly. See https://bugs.freedesktop.org/show_bug.cgi?id=68370 for @@ -697,23 +695,13 @@ int virLXCProcessStop(virLXCDriverPtr driver, VIR_FREE(vm->def->seclabels[0]->imagelabel); } - if (priv->cgroup) { - rc = virCgroupKillPainfully(priv->cgroup); - if (rc < 0) - return -1; - if (rc > 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Some processes refused to die")); - return -1; - } - } else { - /* If cgroup doesn't exist, just try cleaning up the - * libvirt_lxc process */ - if (virProcessKillPainfully(vm->pid, true) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Processes %d refused to die"), (int)vm->pid); - return -1; - } + rc = virCgroupKillPainfully(priv->cgroup); + if (rc < 0) + return -1; + if (rc > 0) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("Some processes refused to die")); + return -1; } virLXCProcessCleanup(driver, vm, reason); -- 1.8.4.5

2 2

[libvirt] [PATCH] lxc: Don't shadow global symbol "link"
by Peter Krempa 14 Feb '14

14 Feb '14

Yet another variable name frowned upon by older compilers. Introduced in commit b73c029d. --- src/lxc/lxc_native.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/lxc/lxc_native.c b/src/lxc/lxc_native.c index 2cf479d..663e29c 100644 --- a/src/lxc/lxc_native.c +++ b/src/lxc/lxc_native.c @@ -334,7 +334,7 @@ lxcFstabWalkCallback(const char* name, virConfValuePtr value, void * data) static virDomainNetDefPtr lxcCreateNetDef(const char *type, - const char *link, + const char *linkdev, const char *mac, const char *flag, const char *macvlanmode) @@ -357,18 +357,18 @@ lxcCreateNetDef(const char *type, net->mac = macAddr; if (STREQ(type, "veth")) { - if (!link) + if (!linkdev) goto error; net->type = VIR_DOMAIN_NET_TYPE_BRIDGE; - if (VIR_STRDUP(net->data.bridge.brname, link) < 0) + if (VIR_STRDUP(net->data.bridge.brname, linkdev) < 0) goto error; } else if (STREQ(type, "macvlan")) { net->type = VIR_DOMAIN_NET_TYPE_DIRECT; - if (!link || VIR_STRDUP(net->data.direct.linkdev, link) < 0) + if (!linkdev || VIR_STRDUP(net->data.direct.linkdev, linkdev) < 0) goto error; if (!macvlanmode || STREQ(macvlanmode, "private")) @@ -411,7 +411,7 @@ lxcCreateHostdevDef(int mode, int type, const char *data) static int lxcAddNetworkDefinition(virDomainDefPtr def, const char *type, - const char *link, + const char *linkdev, const char *mac, const char *flag, const char *macvlanmode, @@ -428,14 +428,14 @@ lxcAddNetworkDefinition(virDomainDefPtr def, isPhys = STREQ(type, "phys"); isVlan = STREQ(type, "vlan"); if (type != NULL && (isPhys || isVlan)) { - if (!link) { + if (!linkdev) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("Missing 'link' attribute for NIC")); goto error; } if (!(hostdev = lxcCreateHostdevDef(VIR_DOMAIN_HOSTDEV_MODE_CAPABILITIES, VIR_DOMAIN_HOSTDEV_CAPS_TYPE_NET, - link))) + linkdev))) goto error; /* This still requires the user to manually setup the vlan interface @@ -443,7 +443,7 @@ lxcAddNetworkDefinition(virDomainDefPtr def, if (isVlan && vlanid) { VIR_FREE(hostdev->source.caps.u.net.iface); if (virAsprintf(&hostdev->source.caps.u.net.iface, - "%s.%s", link, vlanid) < 0) + "%s.%s", linkdev, vlanid) < 0) goto error; } @@ -451,7 +451,7 @@ lxcAddNetworkDefinition(virDomainDefPtr def, goto error; def->hostdevs[def->nhostdevs - 1] = hostdev; } else { - if (!(net = lxcCreateNetDef(type, link, mac, flag, macvlanmode))) + if (!(net = lxcCreateNetDef(type, linkdev, mac, flag, macvlanmode))) goto error; if (VIR_EXPAND_N(def->nets, def->nnets, 1) < 0) -- 1.8.5.3

2 2

[libvirt] [PATCHv6 0/8] Gluster snapshot series
by Peter Krempa 14 Feb '14

14 Feb '14

This version was tweaked according to Dan's and Eric's feedback. Peter Krempa (8): conf: Move qemuDiskGetActualType to virDomainDiskGetActualType conf: Move qemuSnapshotDiskGetActualType to virDomainSnapshotDiskGetActualType storage: Add file storage APIs in the default storage driver storage: add file functions for local and block files storage: Add storage file backends for gluster qemu: Switch snapshot deletion to the new API functions qemu: snapshot: Use new APIs to detect presence of existing storage files qemu: snapshot: Add support for external active snapshots on gluster cfg.mk | 1 + docs/formatsnapshot.html.in | 5 +- src/conf/domain_conf.c | 10 ++ src/conf/domain_conf.h | 1 + src/conf/snapshot_conf.c | 7 ++ src/conf/snapshot_conf.h | 2 + src/libvirt_private.syms | 2 + src/qemu/qemu_command.c | 8 +- src/qemu/qemu_command.h | 9 ++ src/qemu/qemu_conf.c | 17 --- src/qemu/qemu_conf.h | 4 - src/qemu/qemu_driver.c | 198 ++++++++++++++++++++++++++-------- src/storage/storage_backend.c | 44 ++++++++ src/storage/storage_backend.h | 41 +++++++ src/storage/storage_backend_fs.c | 48 +++++++++ src/storage/storage_backend_fs.h | 2 + src/storage/storage_backend_gluster.c | 139 ++++++++++++++++++++++++ src/storage/storage_backend_gluster.h | 1 + src/storage/storage_driver.c | 145 +++++++++++++++++++++++++ src/storage/storage_driver.h | 32 +++++- tests/Makefile.am | 3 + 21 files changed, 644 insertions(+), 75 deletions(-) -- 1.8.5.3

3 19

[libvirt] [PATCH] storage: gluster: Don't leak private data when storage file init fails
by Peter Krempa 14 Feb '14

14 Feb '14

In a44b7b87bcc6681e2939f65a3552fc96f68bc7b6 I've introduced a function that initializes a storage file wrapper object on gluster based volumes. The initialization function leaks the private data pointer in case of failure. This patch fixes it. Reported by John Ferlan. --- Notes: Pushed under the trivial rule. src/storage/storage_backend_gluster.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/storage/storage_backend_gluster.c b/src/storage/storage_backend_gluster.c index a9c33c2..202a441 100644 --- a/src/storage/storage_backend_gluster.c +++ b/src/storage/storage_backend_gluster.c @@ -570,6 +570,7 @@ virStorageFileBackendGlusterInit(virStorageFilePtr file) error: VIR_FREE(priv->volname); glfs_fini(priv->vol); + VIR_FREE(priv); return -1; } -- 1.8.5.3

1 0

[libvirt] [PATCH 1/2] lxc: Add virCgroupSetOwner()
by Richard Weinberger 14 Feb '14

14 Feb '14

Add a new helper function to change the permissions of a control group. This function is needed for user namespaces, we need to chmod() the cgroup to the initial uid/gid such that systemd is allowed to use the cgroup. Signed-off-by: Richard Weinberger <richard(a)nod.at> --- src/libvirt_private.syms | 1 + src/lxc/lxc_cgroup.c | 7 +++++++ src/util/vircgroup.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ src/util/vircgroup.h | 2 ++ 4 files changed, 56 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 2c9536a..40e72f2 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1056,6 +1056,7 @@ virCgroupSetMemory; virCgroupSetMemoryHardLimit; virCgroupSetMemorySoftLimit; virCgroupSetMemSwapHardLimit; +virCgroupSetOwner; virCgroupSupportsCpuBW; diff --git a/src/lxc/lxc_cgroup.c b/src/lxc/lxc_cgroup.c index cc0d5e8..de93528 100644 --- a/src/lxc/lxc_cgroup.c +++ b/src/lxc/lxc_cgroup.c @@ -484,6 +484,13 @@ virCgroupPtr virLXCCgroupCreate(virDomainDefPtr def) &cgroup) < 0) goto cleanup; + /* setup control group permissions for user namespace */ + if (def->idmap.uidmap) { + if (virCgroupSetOwner(cgroup, def->idmap.uidmap[0].target, + def->idmap.gidmap[0].target)) + goto cleanup; + } + cleanup: return cgroup; } diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index a6d60c5..b2666e8 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -3252,6 +3252,52 @@ cleanup: return ret; } +int virCgroupSetOwner(virCgroupPtr cgroup, uid_t uid, gid_t gid) { + size_t i; + + for (i = 0; i < VIR_CGROUP_CONTROLLER_LAST; i++) { + char *base, *entry; + DIR *dh; + struct dirent *de; + + if (!cgroup->controllers[i].mountPoint) + continue; + + if (virAsprintf(&base, "%s%s", cgroup->controllers[i].mountPoint, + cgroup->controllers[i].placement) < 0) { + virReportOOMError(); + return -1; + } + + dh = opendir(base); + while ((de = readdir(dh)) != NULL) { + if (STREQ(de->d_name, ".") || + STREQ(de->d_name, "..")) + continue; + + if (virAsprintf(&entry, "%s/%s", base, de->d_name) < 0) { + VIR_FREE(base); + virReportOOMError(); + } + + if (chown(entry, uid, gid) < 0) + virReportSystemError(errno, _("cannot chown '%s' to (%u, %u)"), + entry, uid, gid); + + VIR_FREE(entry); + } + closedir(dh); + + if (chown(base, uid, gid) < 0) + virReportSystemError(errno, _("cannot chown '%s' to (%u, %u)"), + base, uid, gid); + + VIR_FREE(base); + } + + return 0; +} + /** * virCgroupSupportsCpuBW(): diff --git a/src/util/vircgroup.h b/src/util/vircgroup.h index a70eb18..6e00f28 100644 --- a/src/util/vircgroup.h +++ b/src/util/vircgroup.h @@ -225,4 +225,6 @@ int virCgroupIsolateMount(virCgroupPtr group, bool virCgroupSupportsCpuBW(virCgroupPtr cgroup); +int virCgroupSetOwner(virCgroupPtr cgroup, uid_t uid, gid_t gid); + #endif /* __VIR_CGROUP_H__ */ -- 1.8.4.5

2 6

[libvirt] [PATCH] storage: Fix build with older compilers afeter gluster snapshot series
by Peter Krempa 14 Feb '14

14 Feb '14

In commit e32268184b4fd1611ed5ffd3c758b8f6a34152e6 I accidentally added twice a typedef for virStorageFileBackend when I moved it between files across patch iterations. The double declaration breaks build on older compilers in RHEL5 and FreeBSD. Remove the spurious definition. --- Notes: Pushed under the build-breaker rule. src/storage/storage_backend.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/storage/storage_backend.h b/src/storage/storage_backend.h index 1c7ad1e..5314411 100644 --- a/src/storage/storage_backend.h +++ b/src/storage/storage_backend.h @@ -207,9 +207,6 @@ typedef int (*virStorageFileBackendStat)(virStorageFilePtr file, struct stat *st); -typedef struct _virStorageFileBackend virStorageFileBackend; -typedef virStorageFileBackend *virStorageFileBackendPtr; - virStorageFileBackendPtr virStorageFileBackendForType(int type, int protocol); struct _virStorageFileBackend { -- 1.8.5.3

1 0

[libvirt] [PATCH v7 0/7] Support keyboard device
by Li Zhang 14 Feb '14

14 Feb '14

From: Li Zhang <zhlcindy(a)linux.vnet.ibm.com> This patchset is to add keyboard input device. For PPC64, it doesn't support a default keyboard device when the graphic is enabled. Libvirt supports QEMU command line as "-device VGA" which won't create any keyboard device for it. So it requires libvirt to add a default USB keyboard device for it. This patchset is to add keyboard input device and a default USB keyboard for PPC64. The related discussion in QEMU community: http://lists.nongnu.org/archive/html/qemu-devel/2013-11/msg01734.html Li Zhang (7): conf: Add a keyboard input device type conf: Add one interface to add default input devices conf: Remove the implicit PS2 mouse for non-X86 and platforms and add an implicit PS2 keyboard device for X86 platforms. qemu_cap: Add USB keyboard capability qemu: format qemu command line for USB keyboard xen: format xen command line for USB keyboard Add a default USB keyboard and USB mouse for PPC64 v7 -> v6: * Corret indention errors in code. (Jan Tomko) * Correct make check error in xen driver. (Jan Tomko) * Split 5/6 to 2 parts, qemu and xen. (Jan Tomko) v6 -> v5: * Change kbd to keyboard, and correct -usbdevice parameter. * Remove implicit PS/2 keyboard output in XML in case older libvirtd can read it. (Jan Tomko) * Remove implicit keyboard for XEN to make it safer. v5 -> v4: * Add PS/2 KBD definition in XML file. (Daniel.P.Berrange) * Allow PS/2 KBD devices and set KBD default bus as PS2 for X86, USB for non-x86. (Daniel.P.Berrange) * Add an implicit PS/2 KBD as PS/2 mouse. (Danniel.P.Berrange) v4 -> v3: * Don't remove PS2 mouse device for other virtualization drivers (Jan Tomko). v3 -> v2: * Handle the KBD device type in xen and QEMU driver. (Daniel.P.Berrange) * Remove PS2 mouse device for non-X86 platforms. * Move virDomainDefMaybeAddInput to a new patch. (Jan Tomko) * Replace VIR_REALLOC_N with VIR_APPEND_ELEMENT. (Jan Tomoko) * Fix several typos. (Jan Tomoko) * Add a virReportError when QEMU_CAPS_DEVICE_USB_KBD can't be gotten. (Jan Tomoko) v2 -> v1: * change ifs to switch clause. * reconstruct the patches docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c | 112 ++++++++++++++------- src/conf/domain_conf.h | 5 + src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 3 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 41 ++++++-- src/qemu/qemu_domain.c | 23 ++++- src/util/virarch.h | 2 + src/xenxs/xen_sxpr.c | 27 +++-- src/xenxs/xen_xm.c | 30 ++++-- tests/qemucapabilitiesdata/caps_1.2.2-1.caps | 1 + tests/qemucapabilitiesdata/caps_1.3.1-1.caps | 1 + tests/qemucapabilitiesdata/caps_1.4.2-1.caps | 1 + tests/qemucapabilitiesdata/caps_1.5.3-1.caps | 1 + tests/qemucapabilitiesdata/caps_1.6.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_1.6.50-1.caps | 1 + tests/qemuhelptest.c | 8 ++ .../qemuxml2argvdata/qemuxml2argv-pseries-disk.xml | 3 +- .../qemuxml2argv-pseries-usb-kbd.args | 9 ++ .../qemuxml2argv-pseries-usb-kbd.xml | 19 ++++ tests/qemuxml2argvtest.c | 3 + 22 files changed, 227 insertions(+), 67 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-usb-kbd.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-usb-kbd.xml -- 1.8.2.1

1 7

[libvirt] [PATCH v3 00/21] LXC configuration conversion
by Cédric Bosdonnat 14 Feb '14

14 Feb '14

Here is an updated version of the patch set fixing comments from Daniel. It also adds 3 commits: * One adding conversion for the newly supported blkio throttle tune in lxc driver. * One actually using the state of the veth network device in lxc driver. * One adding the ability to give major:minor numbers instead of a path for blkio tune devices. The last one is a way to address Daniel's comment on the /dev/block/... paths. Cédric Bosdonnat (21): Improve virConf parse to handle LXC config format LXC driver: started implementing connectDomainXMLFromNative LXC from native: import rootfs LXC from native: migrate fstab and lxc.mount.entry LXC from native: implement no network conversion LXC from native: migrate veth network configuration LXC from native: convert phys network types to net hostdev devices LXC from native: convert lxc.tty to console devices LXC from native: convert macvlan network configuration LXC from native: convert lxc.id_map into <idmap> LXC from native: migrate memory tuning LXC from native: map lxc.cgroup.cpu.* LXC from native: map lxc.cgroup.cpuset.* LXC from native: add lxc.cgroup.blkio.* mapping LXC from native: map lxc.arch to /domain/os/type@arch LXC from native: map block filesystems LXC from native: map vlan network type LXC: added some doc on domxml-from-native with mention of limitations LXC from native: convert blkio throttle config lxc: honor link state=up for veth interfaces blkiotune: allow <node major='' minor=''/> in place of <path> .gitignore | 1 + docs/drvlxc.html.in | 34 +- docs/formatdomain.html.in | 10 +- po/POTFILES.in | 1 + src/Makefile.am | 1 + src/conf/domain_conf.c | 45 +- src/conf/domain_conf.h | 2 + src/libvirt_private.syms | 1 + src/lxc/lxc_cgroup.c | 5 + src/lxc/lxc_container.c | 2 +- src/lxc/lxc_container.h | 2 + src/lxc/lxc_driver.c | 41 + src/lxc/lxc_native.c | 952 +++++++++++++++++++++ src/lxc/lxc_native.h | 32 + src/lxc/lxc_process.c | 5 + src/qemu/qemu_cgroup.c | 5 + src/qemu/qemu_driver.c | 10 + src/util/vircgroup.c | 126 ++- src/util/vircgroup.h | 10 + src/util/virconf.c | 46 +- src/util/virconf.h | 10 + tests/Makefile.am | 7 +- tests/lxcconf2xmldata/lxcconf2xml-blkiotune.config | 11 + tests/lxcconf2xmldata/lxcconf2xml-blkiotune.xml | 39 + .../lxcconf2xmldata/lxcconf2xml-cpusettune.config | 6 + tests/lxcconf2xmldata/lxcconf2xml-cpusettune.xml | 27 + tests/lxcconf2xmldata/lxcconf2xml-cputune.config | 7 + tests/lxcconf2xmldata/lxcconf2xml-cputune.xml | 29 + tests/lxcconf2xmldata/lxcconf2xml-fstab.config | 37 + tests/lxcconf2xmldata/lxcconf2xml-idmap.config | 5 + tests/lxcconf2xmldata/lxcconf2xml-idmap.xml | 28 + .../lxcconf2xml-macvlannetwork.config | 13 + .../lxcconf2xmldata/lxcconf2xml-macvlannetwork.xml | 26 + tests/lxcconf2xmldata/lxcconf2xml-memtune.config | 10 + tests/lxcconf2xmldata/lxcconf2xml-memtune.xml | 29 + .../lxcconf2xmldata/lxcconf2xml-nonenetwork.config | 4 + tests/lxcconf2xmldata/lxcconf2xml-nonenetwork.xml | 21 + tests/lxcconf2xmldata/lxcconf2xml-nonetwork.config | 3 + tests/lxcconf2xmldata/lxcconf2xml-nonetwork.xml | 24 + .../lxcconf2xmldata/lxcconf2xml-physnetwork.config | 6 + tests/lxcconf2xmldata/lxcconf2xml-physnetwork.xml | 26 + tests/lxcconf2xmldata/lxcconf2xml-simple.config | 41 + tests/lxcconf2xmldata/lxcconf2xml-simple.xml | 41 + .../lxcconf2xmldata/lxcconf2xml-vlannetwork.config | 12 + tests/lxcconf2xmldata/lxcconf2xml-vlannetwork.xml | 26 + tests/lxcconf2xmltest.c | 131 +++ 46 files changed, 1865 insertions(+), 85 deletions(-) create mode 100644 src/lxc/lxc_native.c create mode 100644 src/lxc/lxc_native.h create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-blkiotune.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-blkiotune.xml create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-cpusettune.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-cpusettune.xml create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-cputune.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-cputune.xml create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-fstab.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-idmap.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-idmap.xml create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-macvlannetwork.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-macvlannetwork.xml create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-memtune.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-memtune.xml create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-nonenetwork.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-nonenetwork.xml create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-nonetwork.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-nonetwork.xml create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-physnetwork.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-physnetwork.xml create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-simple.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-simple.xml create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-vlannetwork.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-vlannetwork.xml create mode 100644 tests/lxcconf2xmltest.c -- 1.8.5.2

5 50

Re: [libvirt] [PATCH RFC 0/2] support compression with dumping guest memory
by Qiao Nuohan 13 Feb '14

13 Feb '14

On 01/29/2014 10:04 AM, qiaonuohan wrote: > --memory-only option is introduced without compression supported. Therefore, > this is a freature regression of virsh dump. This patchset is used to add > compression support in libvirt side and please refer the following address to > see the qemu side, the lastest version of qemu side v7(ready for comment now). > > http://lists.gnu.org/archive/html/qemu-devel/2014-01/msg03669.html > > qiaonuohan (2): > support compression when --memory-only option is specified > support configuring the format of dumping memory in qemu.conf > > include/libvirt/libvirt.h.in | 18 +++++++++---- > src/libvirt.c | 15 +++++++++++ > src/qemu/libvirtd_qemu.aug | 1 + > src/qemu/qemu.conf | 6 +++++ > src/qemu/qemu_conf.c | 2 ++ > src/qemu/qemu_conf.h | 1 + > src/qemu/qemu_driver.c | 52 +++++++++++++++++++++++++++++++++++--- > src/qemu/qemu_monitor.c | 6 ++--- > src/qemu/qemu_monitor.h | 3 ++- > src/qemu/qemu_monitor_json.c | 4 ++- > src/qemu/qemu_monitor_json.h | 3 ++- > src/qemu/test_libvirtd_qemu.aug.in | 1 + > tests/qemumonitorjsontest.c | 2 +- > tools/virsh-domain.c | 29 +++++++++++++++++++++ > 14 files changed, 127 insertions(+), 16 deletions(-) > Hello Do you have some comments on my patches? -- Regards Qiao Nuohan

2 1

[libvirt] Get Info for QEMU/KVM storage and volume
by Qiang Fu 13 Feb '14

13 Feb '14

Hi all, I am new to libvirt. Right now I am trying to use libvirt to get statistics information (size, free space and so on) on host storage and vm volume running on QEMU/KVM hypervisor. However when I looked at the API support matrix: http://libvirt.org/hvsupport.html#virStorageDriver It seems the storage pool APIs do not support QEMU/KVM even for the latest version of libvirt. Can anyone suggest any workaround solution? Or will there be any plan in the future for libvirt to support that? Thanks in advance, Bruce

1 0

[libvirt] [PATCHv5 0/7] Gluster snapshot series
by Peter Krempa 13 Feb '14

13 Feb '14

New version after the recent feedback and fixing a few bugs found while testing. Please see individual patches for changes. Peter Krempa (7): storage: Add APIs for internal handling of files via the storage driver storage: Implement file storage APIs in the default storage driver storage: add file functions for local and block files storage: Add storage file backends for gluster qemu: Switch snapshot deletion to the new API functions qemu: snapshot: Use new APIs to detect presence of existing storage files qemu: snapshot: Add support for external active snapshots on gluster docs/formatsnapshot.html.in | 5 +- docs/hvsupport.pl | 4 +- po/POTFILES.in | 1 + src/Makefile.am | 1 + src/check-aclrules.pl | 1 + src/check-drivername.pl | 1 + src/driver.h | 30 ++++- src/libvirt_private.c | 180 ++++++++++++++++++++++++++++++ src/libvirt_private.h | 61 ++++++++++ src/libvirt_private.syms | 9 ++ src/qemu/qemu_command.c | 2 +- src/qemu/qemu_command.h | 9 ++ src/qemu/qemu_driver.c | 204 ++++++++++++++++++++++++++-------- src/storage/storage_backend.c | 42 +++++++ src/storage/storage_backend.h | 43 +++++++ src/storage/storage_backend_fs.c | 48 ++++++++ src/storage/storage_backend_fs.h | 2 + src/storage/storage_backend_gluster.c | 143 ++++++++++++++++++++++++ src/storage/storage_backend_gluster.h | 1 + src/storage/storage_driver.c | 95 ++++++++++++++++ 20 files changed, 829 insertions(+), 53 deletions(-) create mode 100644 src/libvirt_private.c create mode 100644 src/libvirt_private.h -- 1.8.5.3

3 16

[libvirt] [PATCH] qemu driver: sync guest time via qemu-guest-agent when domain is resumed
by Marcelo Tosatti 13 Feb '14

13 Feb '14

Since QEMU commit "kvmclock: clock should count only if vm is running" (http://lists.gnu.org/archive/html/qemu-devel/2013-06/msg01225.html) guests have their realtime clock stopped during pause. To correct the situation, invoke guest agent to sync time from host time. Signed-off-by: Marcelo Tosatti <mtosatti(a)redhat.com> diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 8bcd98e..df01244 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -2695,6 +2695,40 @@ qemuProcessPrepareMonitorChr(virQEMUDriverConfigPtr cfg, } + +#include <sys/time.h> + +static void +qemuAgentSyncGuestTime(virDomainObjPtr vm) +{ + int ret; + struct timeval tv; + char *result; + qemuDomainObjPrivatePtr priv; + char buf[500]; + + priv = vm->privateData; + + ret = gettimeofday(&tv, NULL); + if (ret) { + virReportSystemError(errno, "%s", _("gettimeofday failure")); + return; + } + + memset(buf, 0, sizeof(buf)); + + sprintf(buf, "{ \"execute\": \"guest-set-time\"," + "\"arguments\":{\"time\":%lld}}\" ", + tv.tv_usec * 1000 + (tv.tv_sec * 1000000000LL)); + + qemuDomainObjEnterAgent(vm); + ret = qemuAgentArbitraryCommand(priv->agent, buf, &result, + VIR_DOMAIN_QEMU_AGENT_COMMAND_DEFAULT); + qemuDomainObjExitAgent(vm); + if (ret < 0) + VIR_FREE(result); +} + /* * Precondition: vm must be locked, and a job must be active. * This method will call {Enter,Exit}Monitor @@ -2727,6 +2761,7 @@ qemuProcessStartCPUs(virQEMUDriverPtr driver, virDomainObjPtr vm, if (ret == 0) { virDomainObjSetState(vm, VIR_DOMAIN_RUNNING, reason); + qemuAgentSyncGuestTime(vm); } else { if (virDomainLockProcessPause(driver->lockManager, vm, &priv->lockState) < 0) VIR_WARN("Unable to release lease on %s", vm->def->name);

4 16

[libvirt] [PATCH] spec: add missing dep of libvirt-daemon-config-nwfilter
by Eric Blake 13 Feb '14

13 Feb '14

Similar to cf76c4b, if modules are used, then nwfilter configuration requires the nwfilter driver module. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- libvirt.spec.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index 2d57c71..2b44c21 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -737,6 +737,9 @@ Summary: Network filter configuration files for the libvirtd daemon Group: Development/Libraries Requires: libvirt-daemon = %{version}-%{release} + %if %{with_driver_modules} +Requires: libvirt-daemon-driver-nwfilter = %{version}-%{release} + %endif %description daemon-config-nwfilter Network filter configuration files for cleaning guest traffic -- 1.8.5.3

2 2

[libvirt] [PATCH] spec: require libvirt-wireshark from libvirt metapackage
by Eric Blake 13 Feb '14

13 Feb '14

In general, the 'libvirt' metapackage should pull in all subpackages. Fix this for the wireshark subpackage created in commit f9ada9f. * libvirt.spec.in (Requires): Add dependency. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- libvirt.spec.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index d3e6048..2d57c71 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -428,6 +428,9 @@ Requires: libvirt-daemon-driver-storage = %{version}-%{release} Requires: libvirt-daemon-driver-network = %{version}-%{release} Requires: libvirt-daemon-driver-nodedev = %{version}-%{release} %endif + %if %{with_wireshark} +Requires: libvirt-wireshark = %{version}-%{release} + %endif %endif Requires: libvirt-client = %{version}-%{release} -- 1.8.5.3

4 7

[libvirt] [PATCH] rpm: create libvirt-wireshark sub-package
by Eric Blake 13 Feb '14

13 Feb '14

On Fedora 20, with wireshark-devel installed, 'make rpm' failed due to installed but unpackaged files related to wireshark. As F20 is already released without wireshark, I chose to add a new sub-package that is enabled only for F21 and later. Furthermore, all existing wireshark plugins belong to the wireshark package, so I got to invent behavior of how the first third-part wireshark module will behave. * libvirt.spec.in (with_wireshark): Add new conditional. * configure.ac (ws-plugindir): Improve wording. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- I was tempted to push this as a build-breaker fix for 'make rpm', but rpms are close enough to black magic that I decided a review is safer, after all. Tested with both F20 (not built) and F21 (new subpackage built just fine), using normal build of all subpackages and also a build with '%client_only 1' in ~/.rpmmacros to ensure that it indeed works in a client-only setup. configure.ac | 4 ++-- libvirt.spec.in | 34 ++++++++++++++++++++++++++++++++++ 2 files changed, 36 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 884e0e4..23e2201 100644 --- a/configure.ac +++ b/configure.ac @@ -2578,8 +2578,8 @@ AM_CONDITIONAL([WITH_WIRESHARK_DISSECTOR], [test "$with_wireshark_dissector" = " AC_ARG_WITH([ws-plugindir], [AS_HELP_STRING([--with-ws-plugindir], - [wireshark plugins directory that plugin will installed])], - [ ws_plugindir=$withval ]) + [wireshark plugins directory for use when installing wireshark plugin])], + [ws_plugindir=$withval]) if test "$with_wireshark_dissector" != "no" && test -z "$ws_plugindir"; then ws_version=`$WIRESHARK -v | head -1 | cut -f 2 -d' '` diff --git a/libvirt.spec.in b/libvirt.spec.in index 5229ece..e006f2b 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -129,6 +129,7 @@ %define with_numad 0%{!?_without_numad:0} %define with_firewalld 0%{!?_without_firewalld:0} %define with_libssh2 0%{!?_without_libssh2:0} +%define with_wireshark 0%{!?_without_wireshark:0} # Non-server/HV driver defaults which are always enabled %define with_sasl 0%{!?_without_sasl:1} @@ -269,6 +270,11 @@ %define with_libssh2 0%{!?_without_libssh2:1} %endif +# Enable wireshark plugins for all distros shipping libvirt 1.2.2 or newer +%if 0%{?fedora} >= 21 + %define with_wireshark 0%{!?_without_wireshark:1} +%endif + # Disable some drivers when building without libvirt daemon. # The logic is the same as in configure.ac %if ! %{with_libvirtd} @@ -631,6 +637,10 @@ BuildRequires: scrub BuildRequires: numad %endif +%if %{with_wireshark} +BuildRequires: wireshark-devel +%endif + Provides: bundled(gnulib) %description @@ -1115,6 +1125,17 @@ Requires: cyrus-sasl-md5 Shared libraries and client binaries needed to access to the virtualization capabilities of recent versions of Linux (and other OSes). +%if %{with_wireshark} +%package wireshark +Summary: Wireshark dissector plugin for libvirt RPC transactions +Group: Development/Libraries +Requires: wireshark +Requires: %{name}-client = %{version}-%{release} + +%description wireshark +Wireshark dissector plugin for better analysis of libvirt RPC traffic. +%endif + %if %{with_lxc} %package login-shell Summary: Login shell for connecting users to an LXC container @@ -1340,6 +1361,10 @@ driver %define _with_firewalld --with-firewalld %endif +%if ! %{with_wireshark} + %define _without_wireshark --without-wireshark-dissector +%endif + %define when %(date +"%%F-%%T") %define where %(hostname) %define who %{?packager}%{!?packager:Unknown} @@ -1412,6 +1437,7 @@ driver %{?_without_dtrace} \ %{?_without_driver_modules} \ %{?_with_firewalld} \ + %{?_without_wireshark} \ %{with_packager} \ %{with_packager_version} \ --with-qemu-user=%{qemu_user} \ @@ -1442,6 +1468,9 @@ rm -f $RPM_BUILD_ROOT%{_libdir}/libvirt/lock-driver/*.a rm -f $RPM_BUILD_ROOT%{_libdir}/libvirt/connection-driver/*.la rm -f $RPM_BUILD_ROOT%{_libdir}/libvirt/connection-driver/*.a %endif +%if %{with_wireshark} +rm -f $RPM_BUILD_ROOT%{_libdir}/wireshark/plugins/*/libvirt.la +%endif %if %{with_network} install -d -m 0755 $RPM_BUILD_ROOT%{_datadir}/lib/libvirt/dnsmasq/ @@ -2117,6 +2146,11 @@ exit 0 %config(noreplace) %{_sysconfdir}/sasl2/libvirt.conf %endif +%if %{with_wireshark} +%files wireshark +%{_libdir}/wireshark/plugins/*/libvirt.so +%endif + %if %{with_lxc} %files login-shell %attr(4750, root, virtlogin) %{_bindir}/virt-login-shell -- 1.8.5.3

3 7

[libvirt] [PATCH] lxc from native: removed now remaining useless line
by Cédric Bosdonnat 13 Feb '14

13 Feb '14

--- src/lxc/lxc_native.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/lxc/lxc_native.c b/src/lxc/lxc_native.c index ee07635..2cf479d 100644 --- a/src/lxc/lxc_native.c +++ b/src/lxc/lxc_native.c @@ -900,7 +900,6 @@ lxcParseConfigString(const char *config) } /* Loop over lxc.mount.entry to add filesystem devices for them */ - value = virConfGetValue(properties, "lxc.mount.entry"); if (virConfWalk(properties, lxcFstabWalkCallback, vmdef) < 0) goto error; -- 1.8.5.2

2 1

[libvirt] [PATCH] Fix stream related spelling mistakes
by Philipp Hahn 13 Feb '14

13 Feb '14

Consistent spelling of all-uppercase I/O. Signed-off-by: Philipp Hahn <hahn(a)univention.de> --- libvirt-override-virStream.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt-override-virStream.py b/libvirt-override-virStream.py index 53000da..e9dd09a 100644 --- a/libvirt-override-virStream.py +++ b/libvirt-override-virStream.py @@ -28,7 +28,7 @@ def recvAll(self, handler, opaque): """Receive the entire data stream, sending the data to the requested data sink. This is simply a convenient alternative - to virStreamRecv, for apps that do blocking-I/o. + to virStreamRecv, for apps that do blocking-I/O. A hypothetical handler function looks like: @@ -61,7 +61,7 @@ """ Send the entire data stream, reading the data from the requested data source. This is simply a convenient alternative - to virStreamSend, for apps that do blocking-I/o. + to virStreamSend, for apps that do blocking-I/O. A hypothetical handler function looks like: -- 1.8.5.3

2 1

[libvirt] [PATCH] Fix stream related spelling mistakes
by Philipp Hahn 13 Feb '14

13 Feb '14

Remove double "is". Consistent spelling of all-uppercase I/O. Signed-off-by: Philipp Hahn <hahn(a)univention.de> --- src/libvirt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 9cc5b1c..666ab1e 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -15890,7 +15890,7 @@ error: * * Send the entire data stream, reading the data from the * requested data source. This is simply a convenient alternative - * to virStreamSend, for apps that do blocking-I/o. + * to virStreamSend, for apps that do blocking-I/O. * * An example using this with a hypothetical file upload * API looks like @@ -15983,7 +15983,7 @@ cleanup: * * Receive the entire data stream, sending the data to the * requested data sink. This is simply a convenient alternative - * to virStreamRecv, for apps that do blocking-I/o. + * to virStreamRecv, for apps that do blocking-I/O. * * An example using this with a hypothetical file download * API looks like @@ -16192,7 +16192,7 @@ error: * virStreamFinish: * @stream: pointer to the stream object * - * Indicate that there is no further data is to be transmitted + * Indicate that there is no further data to be transmitted * on the stream. For output streams this should be called once * all data has been written. For input streams this should be * called once virStreamRecv returns end-of-file. -- 1.8.5.3

2 1

[libvirt] [Question] Is it a bug about cpu model Westmere?
by Wangyufei (James) 13 Feb '14

13 Feb '14

Hello, I find that the cpu model Westmere defined in recently qemu has the cupid CPUID_EXT_PCLMULQDQ, but the cpu model Westmere defined in libvirt doesn't have it, SandyBridge defined in libvirt has it. In my opinion, the same cpu model defined in qemu and libvirt should have the same cpuids, or there'll be some problem happened. First, am I right? Second, if I'm right, whose bug it is? Libvirt or qemu? Thanks for your attention. Best Regards, -WangYufei

2 1

[libvirt] [PATCH] bandwidth: Adjust documentation
by John Ferlan 12 Feb '14

12 Feb '14

Recent autotest/virt-test testing on f20 discovered an anomaly in how the bandwidth options are documented and used. This was discovered due to a bug fix in the /sbin/tc utility found in iproute-3.11.0.1 (on f20) in which overflow was actually caught and returned as an error. The fix was first introduced in iproute-3.10 (search on iproute2 commit 'a303853e'). The autotest/virt-test test for virsh domiftune was attempting to send the largest unsigned integer value (4294967295) for maximum value testing. The libvirt xml implementation was designed to manage values in kibibytes (eg, 1024 blocks of bytes), thus when this value was passed to /sbin/tc, it (now) properly rejected the 4294967295kbps value. Investigation of the problem discovered that formatdomain.html.in and formatnetwork.html.in described the elements and property types slightly differently, although they use the same code - virNetDevBandwidthParseRate() (shared by portgroups, domains, and networks xml parsers). Rather than have the descriptions in two places, this patch will combine and reword the description under formatnetwork.html.in and have formatdomain.html.in link to that description. This documentation faux pas was continued into the virsh man page where the bandwidth description for both 'attach-interface' and 'domiftune' did not indicate the scope of each value, thus leading to the test using largest unsigned integer value, which ultimately will be wrong. Additionally, modified the virnetdevbandwidth.h to use kibibytes instead of kbytes (to be more clear). Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- docs/formatdomain.html.in | 35 +++---------------- docs/formatnetwork.html.in | 81 ++++++++++++++++++++++++++++++++----------- src/util/virnetdevbandwidth.h | 8 ++--- tools/virsh.pod | 10 ++++-- 4 files changed, 77 insertions(+), 57 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 4660983..ea1a97b 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -3750,37 +3750,10 @@ qemu-kvm -net nic,model=? /dev/null <p> This part of interface XML provides setting quality of service. Incoming - and outgoing traffic can be shaped independently. The - <code>bandwidth</code> element can have at most one <code>inbound</code> - and at most one <code>outbound</code> child elements. Leaving any of these - children element out result in no QoS applied on that traffic direction. - So, when you want to shape only domain's incoming traffic, use - <code>inbound</code> only, and vice versa. Each of these elements have one - mandatory attribute <code>average</code> (or <code>floor</code> as - described below). <code>average</code> specifies average bit rate on - the interface being shaped. Then there are two optional attributes: - <code>peak</code>, which specifies maximum rate at which interface can send - data, and <code>burst</code>, amount of bytes that can be burst at - <code>peak</code> speed. Accepted values for attributes are integer - numbers. The units for <code>average</code> and <code>peak</code> attributes - are kilobytes per second, and for the <code>burst</code> just kilobytes. - Note the limitation of implementation: the <code>peak</code> attribute in - <code>outbound</code> element is ignored (as linux ingress filters don't - know it yet). <span class="since">Since 0.9.4</span> The <code>inbound</code> can - optionally have <code>floor</code> attribute. This is there for - guaranteeing minimal throughput for shaped interfaces. This, however, - requires that all traffic goes through one point where QoS decisions can - take place. That's why this attribute works only for virtual networks for - now (that is <code><interface type='network'/></code> with a - forward type of route, nat, or no forward at all). Moreover, the - virtual network the interface is connected to is required to have at least - inbound QoS set (<code>average</code> at least). Moreover, with - <code>floor</code> attribute users don't need to specify - <code>average</code>. However, <code>peak</code> and <code>burst</code> - attributes still require <code>average</code>. Currently, linux kernel - doesn't allow ingress qdiscs to have any classes therefore - <code>floor</code> can be applied only on <code>inbound</code> and not - <code>outbound</code>. <span class="since">Since 1.0.1</span> + and outgoing traffic can be shaped independently. + The <code>bandwidth</code> element and its child elements are described + in the <a href="formatnetwork.html#elementQoS">QoS</a> section of + the Network XML. </p> <h5><a name="elementVlanTag">Setting VLAN tag (on supported network types only)</a></h5> diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in index 1ca1bec..de71ebf 100644 --- a/docs/formatnetwork.html.in +++ b/docs/formatnetwork.html.in @@ -412,40 +412,81 @@ <p> The <code><bandwidth></code> element allows setting - quality of service for a particular network. - <span class="since">Since 0.9.4</span> The limits specified + quality of service for a particular network + (<span class="since">since 0.9.4</span>). For a <code>domain</code> + object, the limits specified are applied to the domain traffic. + For a <code>network</code> object, the limits specified are applied to the aggregate of all traffic to/from all guest interfaces attached to that network, <b>not</b> to each guest - interface individually. Setting <code>bandwidth</code> for a + interface individually. Setting <code>bandwidth</code> for a network is supported only for networks with a <code><forward></code> mode of <code>route</code>, <code>nat</code>, or no mode at all - (i.e. an "isolated" network). <code>bandwidth</code> setting + (i.e. an "isolated" network). Setting <code>bandwidth</code> is <b>not</b> supported for forward modes of <code>bridge</code>, <code>passthrough</code>, <code>private</code>, or <code>hostdev</code>, and attempts to do this will lead to - a failure to define the network (or to create a transient - network). + a failure to define the network (or to create a transient network). </p> <p> Incoming and outgoing traffic can be shaped independently. The - <code>bandwidth</code> element can have at most - one <code>inbound</code> and at most one <code>outbound</code> + <code>bandwidth</code> element can have at most one + <code>inbound</code> and at most one <code>outbound</code> child element. Leaving either of these children elements out results in no QoS applied for that traffic direction. So, - when you want to shape only a network's incoming traffic, use + when you want to shape only incoming traffic, use <code>inbound</code> only, and vice versa. Each of these - elements have one mandatory attribute - <code>average</code>, - which specifies the desired average bit rate for the interface - being shaped (in kibibytes/second). There are also two - optional attributes: <code>peak</code>, which specifies the - maximum rate at which the bridge can send data (again in - kibibytes/second), and <code>burst</code> - the amount of - bytes that can be transmitted in a single burst at - <code>peak</code> speed (in kibibytes). Accepted values for - attributes are integer numbers. The allotted bandwidth is - shared equally between domains connected to the network. + elements have one mandatory attribute - <code>average</code> (or + <code>floor</code> as described below). The attributes are as follows, + where accepted values for each attribute is an integer number. </p> + <dl> + <dt><code>average</code></dt> + <dd> + Specifies the desired average bit rate for the interface + being shaped (in kibibytes/second). + </dd> + <dt><code>peak</code></dt> + <dd> + Optional attribute which specifies the maximum rate at + which the bridge can send data (in kibibytes/second). + Note the limitation of implementation: this attribute in the + <code>outbound</code> element is ignored (as Linux ingress + filters don't know it yet). + </dd> + <dt><code>burst</code></dt> + <dd> + Optional attribute which specifies the amount of kibibytes that + can be transmitted in a single burst at <code>peak</code> speed. + </dd> + <dt><code>floor</code></dt> + <dd> + Optional attribute available only for the <code>inbound</code> + element. This attribute guarantees minimal throughput for + shaped interfaces. This, however, requires that all traffic + goes through one point where QoS decisions can take place, hence + why this attribute works only for virtual networks for now + (that is <code><interface type='network'/></code> with a + forward type of route, nat, or no forward at all). Moreover, the + virtual network the interface is connected to is required to have + at least inbound QoS set (<code>average</code> at least). If + using the <code>floor</code> attribute users don't need to specify + <code>average</code>. However, <code>peak</code> and + <code>burst</code> attributes still require <code>average</code>. + Currently, the Linux kernel doesn't allow ingress qdiscs to have + any classes therefore <code>floor</code> can be applied only + on <code>inbound</code> and not <code>outbound</code>. + </dd> + </dl> + + <p> + Note that a kibibyte is a block of 1024 bytes. Attributes + <code>average</code>, <code>peak</code>, and <code>burst</code> + are available <span class="since">since 0.9.4</span>, while + the <code>floor</code> attribute is only available + <span class="since">since 1.0.1</span>. + </p> + <p> A <code><portgroup></code> element can also include a <code><bandwidth></code> element. In that case, the @@ -561,7 +602,7 @@ network), and each portgroup has a name, as well as various subelements associated with it. The currently supported subelements are <code><bandwidth></code> - (documented <a href="formatdomain.html#elementQoS">here</a>) + (described <a href="formatnetwork.html#elementQoS">here</a>) and <code><virtualport></code> (documented <a href="formatdomain.html#elementsNICSDirect">here</a>). If a domain interface definition specifies a portgroup (by diff --git a/src/util/virnetdevbandwidth.h b/src/util/virnetdevbandwidth.h index 4606a07..2a22820 100644 --- a/src/util/virnetdevbandwidth.h +++ b/src/util/virnetdevbandwidth.h @@ -29,10 +29,10 @@ typedef struct _virNetDevBandwidthRate virNetDevBandwidthRate; typedef virNetDevBandwidthRate *virNetDevBandwidthRatePtr; struct _virNetDevBandwidthRate { - unsigned long long average; /* kbytes/s */ - unsigned long long peak; /* kbytes/s */ - unsigned long long floor; /* kbytes/s */ - unsigned long long burst; /* kbytes */ + unsigned long long average; /* kibibytes/s */ + unsigned long long peak; /* kibibytes/s */ + unsigned long long floor; /* kibibytes/s */ + unsigned long long burst; /* kibibytes */ }; typedef struct _virNetDevBandwidth virNetDevBandwidth; diff --git a/tools/virsh.pod b/tools/virsh.pod index f221475..2cf58a6 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -680,7 +680,11 @@ or the MAC address. If no I<--inbound> or I<--outbound> is specified, this command will query and show the bandwidth settings. Otherwise, it will set the inbound or outbound bandwidth. I<average,peak,burst> is the same as -in command I<attach-interface>. +in command I<attach-interface>. Values for I<average>, I<peak>, and +I<burst> are expressed in kibibytes (blocks of 1024 bytes) as described +in the Network XML documentation at +L<http://libvirt.org/formatnetwork.html#elementQoS>. + If I<--live> is specified, affect a running guest. If I<--config> is specified, affect the next boot of a persistent guest. @@ -2019,7 +2023,9 @@ of the network interface. I<script> allows to specify a path to a script handling a bridge instead of the default one. I<model> allows to specify the model type. I<inbound> and I<outbound> control the bandwidth of the interface. I<peak> and I<burst> are optional, so "average,peak", "average,,burst" and -"average" are also legal. +"average" are also legal. Values for I<average>, I<peak>, and I<burst> are +expressed in kibibytes (blocks of 1024 bytes) as described in the Network +XML documentation at L<http://libvirt.org/formatnetwork.html#elementQoS>. If I<--live> is specified, affect a running domain. If I<--config> is specified, affect the next startup of a persistent domain. -- 1.8.4.2

1 1

[libvirt] [PATCHv2] spec: add missing dep of libvirt-daemon-config-network
by Eric Blake 12 Feb '14

12 Feb '14

From: Thierry Parmentelat <thierry.parmentelat(a)inria.fr> When building modules, libvirt-daemon-config-network requires libvirt-daemon-driver-network to ensure the 'default' network is setup properly Signed-off-by: Eric Blake <eblake(a)redhat.com> --- v2: make dep dependent on whether subpackage is created libvirt.spec.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index 4d804e6..d3e6048 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -720,6 +720,9 @@ Summary: Default configuration files for the libvirtd daemon Group: Development/Libraries Requires: libvirt-daemon = %{version}-%{release} + %if %{with_driver_modules} +Requires: libvirt-daemon-driver-network = %{version}-%{release} + %endif %description daemon-config-network Default configuration files for setting up NAT based networking -- 1.8.5.3

2 2

[libvirt] libvirt default network
by Thierry Parmentelat 12 Feb '14

12 Feb '14

Hi This is in echo to a message originally sent on libvirt-users, but having not received any answer yet so we figured we would try this list instead So, we use libvirt on various flavours of fedora; with fedora18 we were using libvirt-1.0.4, that we rebuilt using a slightly modified version of mainstream specfile Under fedora20 we’ve first tried using the libvirt version that comes with vanilla fedora - 1.1.3 - but are seeing glitches that apparently are fixed in 1.2.1, so we’re giving this a shot The problem we have is, right after installation of our libvirt rpm, the ‘default’ network is not known to the system: [root@vnode07 ~]# virsh -c lxc:// net-dumpxml default error: failed to get network 'default' error: Network not found: no network with matching name ‘default' While the ‘source’ file for this default network did ship with the rpm [root@vnode07 ~]# rpm -qf /usr/share/libvirt/networks/default.xml libvirt-daemon-driver-network-1.2.1-0.x86_64 ------------ What we used to have with 1.0.4 and 1.1.3 at that same point (right after yum install) is [root@vnode05 ~]# virsh -c lxc:// net-dumpxml default <network connections='1510’> .. </network> — So, I’m confident we can tweak our specfile to get this to work by adding something like net-define / net-autostart / net-start somewhere near the post install script of the daemon package or something However we would appreciate some insight as to how this would happen in the first place; is this an intentional change on your end ? or did we screw that up somehow ? if so, I could not find out precisely how this network definition is supposed to take place when the package gets installed, any hint / insight on that would be much appreciated Thanks in advance

4 9

Re: [libvirt] [libvirt-users] Help? Running into problems with migrateToURI2() and virDomainDefCheckABIStability()
by Cole Robinson 12 Feb '14

12 Feb '14

On 02/12/2014 01:03 PM, Chris Friesen wrote: > On 02/11/2014 04:45 PM, Cole Robinson wrote: >> On 02/10/2014 06:46 PM, Chris Friesen wrote: >>> Hi, >>> >>> We've run into a problem with libvirt 1.1.2 and are looking for some comments >>> on whether this is a bug or design intent. >>> >>> We're trying to use migrateToURI() but we're using a few things (numatune, >>> vcpu mask, etc.) that may need adjustment during the migration. We found that >>> migrateToURI2() mostly works if we use XML created by copying the domain XML >>> from the running instance and modifying the appropriate sections. >>> >>> The problem that we're seeing is that the serial console checking in >>> libvirt/src/conf/domain_conf.c::virDomainDefCheckABIStability() is failing >>> even though we haven't touched the serial console XML: > >> I think we will have to see the XML your passing before and after edit to >> figure out what's going wrong. Also, showing all the arguments you are >> invoking the migration APIs with. > > > Okay, this is going to be a long message. :) > > We're calling it as: > > dom.migrateToURI2(duri, muri, xml_str, logical_sum, None, CONF.live_migration_bandwidth) > > Here are the supplied arguments: > duri = u'qemu+tcp://compute-0/system' > muri = u'tcp://compute-0' > flaglist = ['VIR_MIGRATE_UNDEFINE_SOURCE', 'VIR_MIGRATE_PEER2PEER', 'VIR_MIGRATE_LIVE'] > logical_sum = 19, (logical OR of flaglist) > CONF.live_migration_bandwidth = 0 > > Grabbing original XML prior to migration: > > dom_xml = etree.fromstring(dom.XMLDesc(0)) > xml_str = etree.tostring(dom_xml) > > xml_str (BEFORE) = > <domain type="qemu" id="2"> > <name>instance-00000006</name> > <uuid>2e13869b-edc0-40dc-92e3-1f2ffde60cce</uuid> > <dpdk> > <process type="secondary"/> > <file prefix="vs"/> > <cpu list="0"/> > <memory channels="4"/> > </dpdk> > <memory unit="KiB">262144</memory> > <currentMemory unit="KiB">262144</currentMemory> > <memoryBacking> > <hugepages/> > </memoryBacking> > <vcpu placement="static" cpuset="1-2">2</vcpu> > <cputune> > <vcpupin vcpu="0" cpuset="1"/> > <vcpupin vcpu="1" cpuset="2"/> > <emulatorpin cpuset="1-2"/> > </cputune> > <numatune> > <memory mode="preferred" nodeset="0"/> > </numatune> > <sysinfo type="smbios"> > <system> > <entry name="manufacturer">OpenStack Foundation</entry> > <entry name="product">OpenStack Nova</entry> > <entry name="version">2013.2.2</entry> > <entry name="serial">771a1b10-d2f7-4ebb-b21e-4040560732f5</entry> > <entry name="uuid">2e13869b-edc0-40dc-92e3-1f2ffde60cce</entry> > </system> > </sysinfo> > <os> > <type arch="x86_64" machine="pc-i440fx-1.4">hvm</type> > <boot dev="hd"/> > <smbios mode="sysinfo"/> > </os> > <features> > <acpi/> > <apic/> > </features> > <clock offset="utc"/> > <on_poweroff>destroy</on_poweroff> > <on_reboot>restart</on_reboot> > <on_crash>destroy</on_crash> > <devices> > <emulator>/usr/bin/qemu-system-x86_64</emulator> > <disk type="file" device="disk"> > <driver name="qemu" type="qcow2" cache="none"/> > <source file="/etc/nova/instances/2e13869b-edc0-40dc-92e3-1f2ffde60cce/disk"/> > <target dev="vda" bus="virtio"/> > <alias name="virtio-disk0"/> > <address type="pci" domain="0x0000" bus="0x00" slot="0x05" function="0x0"/> > </disk> > <controller type="usb" index="0"> > <alias name="usb0"/> > <address type="pci" domain="0x0000" bus="0x00" slot="0x01" function="0x2"/> > </controller> > <controller type="pci" index="0" model="pci-root"> > <alias name="pci.0"/> > </controller> > <interface type="vswitch"> > <mac address="fa:16:3e:fb:34:6b"/> > <source network="4db95d31-64f1-4f10-9138-5fe68c0d77ac"/> > <target dev="7bc76b0e-b12a-4153-8ce8-d3d145c51e6f"/> > <model type="e1000"/> > <alias name="net0"/> > <address type="pci" domain="0x0000" bus="0x00" slot="0x03" function="0x0"/> > </interface> > <interface type="vswitch"> > <mac address="fa:16:3e:d5:b9:50"/> > <source network="8512742c-af3e-4787-b2d8-b0b9ab160297"/> > <target dev="33ab1061-7fa4-4250-99a4-dd7eb4029aa1"/> > <model type="e1000"/> > <alias name="net1"/> > <address type="pci" domain="0x0000" bus="0x00" slot="0x04" function="0x0"/> > </interface> > <serial type="file"> > <source path="/etc/nova/instances/2e13869b-edc0-40dc-92e3-1f2ffde60cce/console.log"/> > <target port="0"/> > <alias name="serial0"/> > </serial> > <serial type="pty"> > <source path="/dev/pts/1"/> > <target port="1"/> > <alias name="serial1"/> > </serial> > <console type="file"> > <source path="/etc/nova/instances/2e13869b-edc0-40dc-92e3-1f2ffde60cce/console.log"/> > <target type="serial" port="0"/> > <alias name="serial0"/> > </console> > <input type="tablet" bus="usb"> > <alias name="input0"/> > </input> > <input type="mouse" bus="ps2"/> > <graphics type="vnc" port="5900" autoport="yes" listen="0.0.0.0" keymap="en-us"> > <listen type="address" address="0.0.0.0"/> > </graphics> > <video> > <model type="cirrus" vram="9216" heads="1"/> > <alias name="video0"/> > <address type="pci" domain="0x0000" bus="0x00" slot="0x02" function="0x0"/> > </video> > <memballoon model="virtio"> > <alias name="balloon0"/> > <address type="pci" domain="0x0000" bus="0x00" slot="0x06" function="0x0"/> > </memballoon> > </devices> > <seclabel type="none"/> > </domain> > > > > This is the modified XML, specifically updating vcpu, cputune, numatune. > In this case they actually have the same values as above but there are > whitespace differences: > > > xml_str (MODIFIED) = > <domain type="qemu" id="2"> > <name>instance-00000006</name> > <uuid>2e13869b-edc0-40dc-92e3-1f2ffde60cce</uuid> > <dpdk> > <process type="secondary"/> > <file prefix="vs"/> > <cpu list="0"/> > <memory channels="4"/> > </dpdk> > <memory unit="KiB">262144</memory> > <currentMemory unit="KiB">262144</currentMemory> > <memoryBacking> > <hugepages/> > </memoryBacking> > <vcpu placement="static" cpuset="1,2">2</vcpu> > <cputune> > <vcpupin vcpu="0" cpuset="1"/><vcpupin vcpu="1" cpuset="2"/><emulatorpin cpuset="1,2"/></cputune> > <numatune> > <memory mode="preferred" nodeset="0"/></numatune> > <sysinfo type="smbios"> > <system> > <entry name="manufacturer">OpenStack Foundation</entry> > <entry name="product">OpenStack Nova</entry> > <entry name="version">2013.2.2</entry> > <entry name="serial">771a1b10-d2f7-4ebb-b21e-4040560732f5</entry> > <entry name="uuid">2e13869b-edc0-40dc-92e3-1f2ffde60cce</entry> > </system> > </sysinfo> > <os> > <type arch="x86_64" machine="pc-i440fx-1.4">hvm</type> > <boot dev="hd"/> > <smbios mode="sysinfo"/> > </os> > <features> > <acpi/> > <apic/> > </features> > <clock offset="utc"/> > <on_poweroff>destroy</on_poweroff> > <on_reboot>restart</on_reboot> > <on_crash>destroy</on_crash> > <devices> > <emulator>/usr/bin/qemu-system-x86_64</emulator> > <disk type="file" device="disk"> > <driver name="qemu" type="qcow2" cache="none"/> > <source file="/etc/nova/instances/2e13869b-edc0-40dc-92e3-1f2ffde60cce/disk"/> > <target dev="vda" bus="virtio"/> > <alias name="virtio-disk0"/> > <address type="pci" domain="0x0000" bus="0x00" slot="0x05" function="0x0"/> > </disk> > <controller type="usb" index="0"> > <alias name="usb0"/> > <address type="pci" domain="0x0000" bus="0x00" slot="0x01" function="0x2"/> > </controller> > <controller type="pci" index="0" model="pci-root"> > <alias name="pci.0"/> > </controller> > <interface type="vswitch"> > <mac address="fa:16:3e:fb:34:6b"/> > <source network="4db95d31-64f1-4f10-9138-5fe68c0d77ac"/> > <target dev="7bc76b0e-b12a-4153-8ce8-d3d145c51e6f"/> > <model type="e1000"/> > <alias name="net0"/> > <address type="pci" domain="0x0000" bus="0x00" slot="0x03" function="0x0"/> > </interface> > <interface type="vswitch"> > <mac address="fa:16:3e:d5:b9:50"/> > <source network="8512742c-af3e-4787-b2d8-b0b9ab160297"/> > <target dev="33ab1061-7fa4-4250-99a4-dd7eb4029aa1"/> > <model type="e1000"/> > <alias name="net1"/> > <address type="pci" domain="0x0000" bus="0x00" slot="0x04" function="0x0"/> > </interface> > <serial type="file"> > <source path="/etc/nova/instances/2e13869b-edc0-40dc-92e3-1f2ffde60cce/console.log"/> > <target port="0"/> > <alias name="serial0"/> > </serial> > <serial type="pty"> > <source path="/dev/pts/1"/> > <target port="1"/> > <alias name="serial1"/> > </serial> > <console type="file"> > <source path="/etc/nova/instances/2e13869b-edc0-40dc-92e3-1f2ffde60cce/console.log"/> > <target type="serial" port="0"/> > <alias name="serial0"/> > </console> > <input type="tablet" bus="usb"> > <alias name="input0"/> > </input> > <input type="mouse" bus="ps2"/> > <graphics type="vnc" port="5900" autoport="yes" listen="0.0.0.0" keymap="en-us"> > <listen type="address" address="0.0.0.0"/> > </graphics> > <video> > <model type="cirrus" vram="9216" heads="1"/> > <alias name="video0"/> > <address type="pci" domain="0x0000" bus="0x00" slot="0x02" function="0x0"/> > </video> > <memballoon model="virtio"> > <alias name="balloon0"/> > <address type="pci" domain="0x0000" bus="0x00" slot="0x06" function="0x0"/> > </memballoon> > </devices> > <seclabel type="none"/> > </domain> > > > > Calling migrateToURI2 then gives the following error : > 2014-02-12 03:37:17.738 1251 ERROR nova.virt.libvirt.driver [-] [instance: 2e13869b-edc0-40dc-92e3-1f2ffde60cce] Live Migration failure: unsupported configuration: Target domain console count 1 does not match source 0 > > > If we remove the this section : > <serial type="pty"> > <source path="/dev/pts/1"/> > <target port="1"/> > <alias name="serial1"/> > </serial> > > Then we get the following error : > 2014-02-12 04:19:12.689 1278 ERROR nova.virt.libvirt.driver [-] [instance: 90335c32-a7ae-4c99-8e5a-cd177f6b3c22] Live Migration failure: unsupported configuration: Target domain serial port count 1 does not match source 2 > > If we remove just the following line: > <source path="/dev/pts/1"/> > > so the modified portion looks like this, > <serial type="file"> > <source path="/etc/nova/instances/00b99f94-436e-406b-8459-83e77758f154/console.log"/> > <target port="0"/> > <alias name="serial0"/> > </serial> > <serial type="pty"> > <target port="1"/> > <alias name="serial1"/> > </serial> > <console type="file"> > <source path="/etc/nova/instances/00b99f94-436e-406b-8459-83e77758f154/console.log"/> > <target type="serial" port="0"/> > <alias name="serial0"/> > </console> > <input type="tablet" bus="usb"> > > Then we get this error : > > 2014-02-12 04:29:06.402 5175 ERROR nova.virt.libvirt.driver [-] [instance: 00b99f94-436e-406b-8459-83e77758f154] Live Migration failure: unsupported configuration: Target domain console count 1 does not match source 0 > > If we modify it with empty <serial type='pty'> element like this: > > <serial type="file"> > <source path="/etc/nova/instances/b1103349-8c9f-4315-9144-03fc22f09be1/console.log"/> > <target port="0"/> > <alias name="serial0"/> > </serial> > <serial type="pty"> > </serial> > <console type="file"> > <source path="/etc/nova/instances/b1103349-8c9f-4315-9144-03fc22f09be1/console.log"/> > <target type="serial" port="0"/> > <alias name="serial0"/> > </console> > > Then we get this error: > > 2014-02-12 04:36:45.686 5358 ERROR nova.virt.libvirt.driver [-] [instance: b1103349-8c9f-4315-9144-03fc22f09be1] Live Migration failure: unsupported configuration: Target domain console count 1 does not match source 0 > > If we modify it with empty <serial type='pty'> element and also remove > <console type='file'> section completely like this : > > <serial type="file"> > <source path="/etc/nova/instances/8cccb4ad-2abc-4513-b8fd-bfb811301677/console.log"/> > <target port="0"/> > <alias name="serial0"/> > </serial> > <serial type="pty"> > </serial> > > Then this successfully migrates! > > However, it then fails on subsequent migration back to the original host. Prior to migrating > back the domain XML serial/console section looks like: > > <serial type="file"> > <source path="/etc/nova/instances/8cccb4ad-2abc-4513-b8fd-bfb811301677/console.log"/> > <target port="0"/> > <alias name="serial0"/> > </serial> > <serial type="pty"> > <source path="/dev/pts/1"/> > <target port="1"/> > <alias name="serial1"/> > </serial> > <console type="file"> > <source path="/etc/nova/instances/8cccb4ad-2abc-4513-b8fd-bfb811301677/console.log"/> > <target type="serial" port="0"/> > <alias name="serial0"/> > </console> > > After modifying empty <serial type='pty'> element and removing the <console type='file'> section > it looks like this : > > <serial type="file"> > <source path="/etc/nova/instances/8cccb4ad-2abc-4513-b8fd-bfb811301677/console.log"/> > <target port="0"/> > <alias name="serial0"/> > </serial> > <serial type="pty"> > </serial> > > But this give the following error when migrating back: > > 2014-02-12 06:00:19.831 7125 ERROR nova.virt.libvirt.driver [-] [instance: 8cccb4ad-2abc-4513-b8fd-bfb811301677] Live Migration failure: unsupported configuration: Target domain console count 0 does not match source 1 > Thanks for the detailed info. Can you put that into an upstream libvirt bug report? http://libvirt.org/bugs.html Does this sound familiar to any other libvirt devs? - Cole

1 0

[libvirt] [PATCHv2 0/6] server-side domain event filtering
by Eric Blake 12 Feb '14

12 Feb '14

v1 was here: https://www.redhat.com/archives/libvir-list/2014-January/msg00689.html Since then, I've rebased it on top of this patch which still needs review: https://www.redhat.com/archives/libvir-list/2014-January/msg01406.html as well as added patch 6 so that we don't have to repeat the exercise of adding a new RPC down the road. Eric Blake (6): event: dynamically manage server-side RPC domain events event: server RPC protocol tweaks for domain lifecycle events event: prepare client to track domain callbackID event: client RPC protocol tweaks for domain lifecycle events event: convert remaining domain events to new style event: pass reason for PM events daemon/libvirtd.h | 3 +- daemon/remote.c | 665 ++++++++++++++++++++++++++------- src/conf/domain_event.c | 184 ++++++++-- src/conf/domain_event.h | 28 +- src/conf/network_event.c | 6 +- src/conf/object_event.c | 35 +- src/conf/object_event_private.h | 6 +- src/libvirt_internal.h | 7 +- src/remote/remote_driver.c | 796 ++++++++++++++++++++++++++++++++-------- src/remote/remote_protocol.x | 195 +++++++++- src/remote_protocol-structs | 95 +++++ 11 files changed, 1679 insertions(+), 341 deletions(-) -- 1.8.5.3

2 15

[libvirt] [PATCH] Fixed build with clang.
by Cédric Bosdonnat 12 Feb '14

12 Feb '14

Two unused global variables, and DBUS_TYPE_INVALID used as a const char*. --- src/phyp/phyp_driver.c | 1 - src/storage/storage_backend_scsi.c | 24 ------------------------ src/util/virdbus.c | 2 +- 3 files changed, 1 insertion(+), 26 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index 20b5bd4..9adb6b0 100644 --- a/src/phyp/phyp_driver.c +++ b/src/phyp/phyp_driver.c @@ -66,7 +66,6 @@ * */ static unsigned const int HMC = 0; -static unsigned const int IVM = 127; static unsigned const int PHYP_IFACENAME_SIZE = 24; static unsigned const int PHYP_MAC_SIZE = 12; diff --git a/src/storage/storage_backend_scsi.c b/src/storage/storage_backend_scsi.c index b38e530..44f17c9 100644 --- a/src/storage/storage_backend_scsi.c +++ b/src/storage/storage_backend_scsi.c @@ -107,30 +107,6 @@ struct diskType { unsigned long long magic; }; -static struct diskType const disk_types[] = { - { VIR_STORAGE_POOL_DISK_LVM2, 0x218, 8, 0x31303020324D564CULL }, - { VIR_STORAGE_POOL_DISK_GPT, 0x200, 8, 0x5452415020494645ULL }, - { VIR_STORAGE_POOL_DISK_DVH, 0x0, 4, 0x41A9E50BULL }, - { VIR_STORAGE_POOL_DISK_MAC, 0x0, 2, 0x5245ULL }, - { VIR_STORAGE_POOL_DISK_BSD, 0x40, 4, 0x82564557ULL }, - { VIR_STORAGE_POOL_DISK_SUN, 0x1fc, 2, 0xBEDAULL }, - /* - * NOTE: pc98 is funky; the actual signature is 0x55AA (just like dos), so - * we can't use that. At the moment I'm relying on the "dummy" IPL - * bootloader data that comes from parted. Luckily, the chances of running - * into a pc98 machine running libvirt are approximately nil. - */ - /*{ 0x1fe, 2, 0xAA55UL },*/ - { VIR_STORAGE_POOL_DISK_PC98, 0x0, 8, 0x314C5049000000CBULL }, - /* - * NOTE: the order is important here; some other disk types (like GPT and - * and PC98) also have 0x55AA at this offset. For that reason, the DOS - * one must be the last one. - */ - { VIR_STORAGE_POOL_DISK_DOS, 0x1fe, 2, 0xAA55ULL }, - { -1, 0x0, 0, 0x0ULL }, -}; - static int virStorageBackendSCSIUpdateVolTargetInfo(virStorageVolTargetPtr target, unsigned long long *allocation, diff --git a/src/util/virdbus.c b/src/util/virdbus.c index a0cbbfe..a6232b7 100644 --- a/src/util/virdbus.c +++ b/src/util/virdbus.c @@ -1281,7 +1281,7 @@ int virDBusIsServiceEnabled(const char *name) "/org/freedesktop/DBus", "org.freedesktop.DBus", "ListActivatableNames", - DBUS_TYPE_INVALID) < 0) + NULL) < 0) return ret; if (!dbus_message_iter_init(reply, &iter) || -- 1.8.5.2

3 4

[libvirt] [PATCH] storage: handle NULL return from virGetStorageVol
by Michael Chapman 12 Feb '14

12 Feb '14

virGetStorageVol can return NULL on out-of-memory. If it does, cleanly abort the volume clone operation. Signed-off-by: Michael Chapman <mike(a)very.puzzling.org> --- src/storage/storage_driver.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index c83aa8a..2f7b2e5 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -1828,6 +1828,10 @@ storageVolCreateXMLFrom(virStoragePoolPtr obj, pool->volumes.objs[pool->volumes.count++] = newvol; volobj = virGetStorageVol(obj->conn, pool->def->name, newvol->name, newvol->key, NULL, NULL); + if (!volobj) { + pool->volumes.count--; + goto cleanup; + } /* Drop the pool lock during volume allocation */ pool->asyncjobs++; -- 1.8.3.1

2 1

[libvirt] [PATCH 0/2] Partially revert separation of volume creating and building
by Ján Tomko 12 Feb '14

12 Feb '14

The storage driver expects 'createVol' to fill out the volume key. For disk and logical backends, we generate the key only after the volume has been built. Revert the separation commits for these backends. Ján Tomko (2): Revert "storage: lvm: Separate creating of the volume from building" Revert "storage: disk: Separate creating of the volume from building" src/storage/storage_backend_disk.c | 44 ++++++++----------------- src/storage/storage_backend_logical.c | 60 ++++++++++++++--------------------- 2 files changed, 37 insertions(+), 67 deletions(-) -- 1.8.3.2

2 4

[libvirt] [PATCH] Fix leaks in vircapstest
by Ján Tomko 12 Feb '14

12 Feb '14

Coverity complains about cell_cpus being leaked on error and valgrind shows 'caps' is leaked on success. Introduced in eb64e87. --- tests/vircapstest.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/vircapstest.c b/tests/vircapstest.c index a40771d..4264e9e 100644 --- a/tests/vircapstest.c +++ b/tests/vircapstest.c @@ -40,7 +40,7 @@ static virCapsPtr buildNUMATopology(int seq) { virCapsPtr caps; - virCapsHostNUMACellCPUPtr cell_cpus; + virCapsHostNUMACellCPUPtr cell_cpus = NULL; int core_id, cell_id; int id; @@ -75,6 +75,8 @@ buildNUMATopology(int seq) return caps; error: + virCapabilitiesClearHostNUMACellCPUTopology(cell_cpus, MAX_CPUS_IN_CELL); + VIR_FREE(cell_cpus); virObjectUnref(caps); return NULL; @@ -87,7 +89,7 @@ test_virCapabilitiesGetCpusForNodemask(const void *data ATTRIBUTE_UNUSED) const char *nodestr = "3,4,5,6"; virBitmapPtr nodemask = NULL; virBitmapPtr cpumap = NULL; - virCapsPtr caps; + virCapsPtr caps = NULL; int mask_size = 8; int ret = -1; @@ -107,6 +109,7 @@ test_virCapabilitiesGetCpusForNodemask(const void *data ATTRIBUTE_UNUSED) ret = 0; error: + virObjectUnref(caps); virBitmapFree(nodemask); virBitmapFree(cpumap); return ret; -- 1.8.3.2

2 2

[libvirt] [PATCH] AppArmor: Fix the place where the template should be installed
by Cédric Bosdonnat 12 Feb '14

12 Feb '14

The security driver expects /etc/apparmor.d/libvirt/TEMPLATE but we installed it to /etc/apparmor.d/libvirtd/TEMPLATE. Move the template to the expected place since that code was here long before. --- examples/apparmor/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/apparmor/Makefile.am b/examples/apparmor/Makefile.am index 6e69440..2630fef 100644 --- a/examples/apparmor/Makefile.am +++ b/examples/apparmor/Makefile.am @@ -32,7 +32,7 @@ abstractions_DATA = \ libvirt-qemu \ $(NULL) -templatesdir = $(apparmordir)/libvirtd +templatesdir = $(apparmordir)/libvirt templates_DATA = \ TEMPLATE \ $(NULL) -- 1.8.5.2

2 1

[libvirt] [PATCH v2 0/2] Handle non-sequential NUMA node numbers
by Pradipta Kr. Banerjee 12 Feb '14

12 Feb '14

v2 *Add test case as suggested by Daniel *Minor change in comments Pradipta Kr. Banerjee (2): Handle non-sequential NUMA node numbers vircapstest: Introduce virCapabilitiesGetCpusForNodemask test src/conf/capabilities.c | 12 ++++- src/qemu/qemu_driver.c | 5 +- src/qemu/qemu_process.c | 2 +- tests/Makefile.am | 5 ++ tests/vircapstest.c | 129 ++++++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 148 insertions(+), 5 deletions(-) create mode 100644 tests/vircapstest.c -- 1.8.5.3

4 6

[libvirt] [PATCH 0/8] storage: separate storage volume creation from building
by Peter Krempa 12 Feb '14

12 Feb '14

This series splits the internal storage volume metadata creation from actual volume building and adds support for deletion of guster volumes. Peter Krempa (8): storage: fs: Fix comment for virStorageBackendFileSystemDelete storage: Support deletion of volumes on gluster pools storage: lvm: Avoid forward decl of virStorageBackendLogicalDeleteVol storage: lvm: Separate creating of the volume from building storage: disk: Separate creating of the volume from building storage: RBD: Separate creating of the volume from building storage: Sheepdog: Separate creating of the volume from building storage: Improve error message when a storage backend is missing src/storage/storage_backend.c | 3 +- src/storage/storage_backend_disk.c | 44 ++++++++---- src/storage/storage_backend_fs.c | 6 +- src/storage/storage_backend_gluster.c | 64 +++++++++++++++++ src/storage/storage_backend_logical.c | 127 ++++++++++++++++++--------------- src/storage/storage_backend_rbd.c | 41 +++++++++-- src/storage/storage_backend_sheepdog.c | 29 +++++++- 7 files changed, 226 insertions(+), 88 deletions(-) -- 1.8.5.2

4 23

[libvirt] [PATCH 00/11] libxl: add job support
by Jim Fehlig 12 Feb '14

12 Feb '14

This patch series adds job support to the libxl driver, using techiques from the qemu driver. One benefit is no longer blocking get operations during long running modify operations. E.g. with these patches 'vish dominfo dom' will work while 'virsh save dom ...' is in progress. The first patch adds the job support machinery, followed by several patches that make use of it. I initially had all but the first in a single "use-job-support" patch, but hope breaking it out eases review. Jim Fehlig (11): libxl: Add job support to libxl driver libxl: use job functions in libxlVmStart libxl: use job functions in libxlDomainSetMemoryFlags libxl: use job functions in libxlDomain{Suspend,Resume} libxl: use job functions in libxlDomainDestroyFlags libxl: use job functions in domain save operations libxl: use job functions in libxlDomainCoreDump libxl: use job functions in vcpu set and pin functions libxl: use job functions in device attach and detach functions libxl: use job functions in libxlDomainSetAutostart libxl: use job functions in libxlDomainSetSchedulerParametersFlags src/libxl/libxl_domain.c | 128 ++++++++++++++++++ src/libxl/libxl_domain.h | 37 +++++ src/libxl/libxl_driver.c | 346 +++++++++++++++++++++++++++++++---------------- 3 files changed, 395 insertions(+), 116 deletions(-) -- 1.8.1.4

3 37

[libvirt] [python PATCH] examples: demonstrate network events
by Eric Blake 12 Feb '14

12 Feb '14

Commit 6ea5be0 added network event callback support, so we might as well demonstrate that it works by updating our example. * examples/event-test.py: Add network event, fix typos. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- examples/event-test.py | 70 ++++++++++++++++++++++++++++++++++++-------------- 1 file changed, 51 insertions(+), 19 deletions(-) diff --git a/examples/event-test.py b/examples/event-test.py index 1402c04..101dbc0 100644 --- a/examples/event-test.py +++ b/examples/event-test.py @@ -2,6 +2,6 @@ # # # -################################################################################# -# Start off by implementing a general purpose event loop for anyones use -################################################################################# +############################################################################## +# Start off by implementing a general purpose event loop for anyone's use +############################################################################## import sys import getopt @@ -158,7 +158,7 @@ class virEventLoopPure: # This is the heart of the event loop, performing one single # iteration. It asks when the next timeout is due, and then - # calcuates the maximum amount of time it is able to sleep + # calculates the maximum amount of time it is able to sleep # for in poll() pending file handle events. # # It then goes into the poll() sleep. @@ -167,9 +167,9 @@ class virEventLoopPure: # events which need to be dispatched to registered callbacks # It may also be time to fire some periodic timers. # - # Due to the coarse granularity of schedular timeslices, if + # Due to the coarse granularity of scheduler timeslices, if # we ask for a sleep of 500ms in order to satisfy a timer, we - # may return up to 1 schedular timeslice early. So even though + # may return up to 1 scheduler timeslice early. So even though # our sleep timeout was reached, the registered timer may not # technically be at its expiry point. This leads to us going # back around the loop with a crazy 5ms sleep. So when checking @@ -227,7 +227,7 @@ class virEventLoopPure: self.runningPoll = False - # Actually the event loop forever + # Actually run the event loop forever def run_loop(self): self.quit = False while not self.quit: @@ -429,8 +429,8 @@ def virEventLoopNativeStart(): ########################################################################## # Everything that now follows is a simple demo of domain lifecycle events ########################################################################## -def eventToString(event): - eventStrings = ( "Defined", +def domEventToString(event): + domEventStrings = ( "Defined", "Undefined", "Started", "Suspended", @@ -438,11 +438,12 @@ def eventToString(event): "Stopped", "Shutdown", "PMSuspended", - "Crashed" ) - return eventStrings[event] + "Crashed", + ) + return domEventStrings[event] -def detailToString(event, detail): - eventStrings = ( +def domDetailToString(event, detail): + domEventStrings = ( ( "Added", "Updated" ), ( "Removed", ), ( "Booted", "Migrated", "Restored", "Snapshot", "Wakeup" ), @@ -451,19 +452,19 @@ def detailToString(event, detail): ( "Shutdown", "Destroyed", "Crashed", "Migrated", "Saved", "Failed", "Snapshot"), ( "Finished", ), ( "Memory", "Disk" ), - ( "Panicked", ) + ( "Panicked", ), ) - return eventStrings[event][detail] + return domEventStrings[event][detail] def myDomainEventCallback1 (conn, dom, event, detail, opaque): print("myDomainEventCallback1 EVENT: Domain %s(%s) %s %s" % (dom.name(), dom.ID(), - eventToString(event), - detailToString(event, detail))) + domEventToString(event), + domDetailToString(event, detail))) def myDomainEventCallback2 (conn, dom, event, detail, opaque): print("myDomainEventCallback2 EVENT: Domain %s(%s) %s %s" % (dom.name(), dom.ID(), - eventToString(event), - detailToString(event, detail))) + domEventToString(event), + domDetailToString(event, detail))) def myDomainEventRebootCallback(conn, dom, opaque): print("myDomainEventRebootCallback: Domain %s(%s)" % (dom.name(), dom.ID())) @@ -501,6 +502,35 @@ def myDomainEventDeviceRemovedCallback(conn, dom, dev, opaque): print("myDomainEventDeviceRemovedCallback: Domain %s(%s) device removed: %s" % ( dom.name(), dom.ID(), dev)) +########################################################################## +# Network events +########################################################################## +def netEventToString(event): + netEventStrings = ( "Defined", + "Undefined", + "Started", + "Stopped", + ) + return netEventStrings[event] + +def netDetailToString(event, detail): + netEventStrings = ( + ( "Added", ), + ( "Removed", ), + ( "Started", ), + ( "Stopped", ), + ) + return netEventStrings[event][detail] + +def myNetworkEventLifecycleCallback(conn, net, event, detail, opaque): + print("myNetworkEventLifecycleCallback: Network %s %s %s" % (net.name(), + netEventToString(event), + netDetailToString(event, detail))) + +########################################################################## +# Set up and run the program +########################################################################## + run = True def myConnectionCloseCallback(conn, reason, opaque): @@ -577,6 +607,8 @@ def main(): vc.domainEventRegisterAny(None, libvirt.VIR_DOMAIN_EVENT_ID_PMSUSPEND_DISK, myDomainEventPMSuspendDiskCallback, None) vc.domainEventRegisterAny(None, libvirt.VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED, myDomainEventDeviceRemovedCallback, None) + vc.networkEventRegisterAny(None, libvirt.VIR_NETWORK_EVENT_ID_LIFECYCLE, myNetworkEventLifecycleCallback, None) + vc.setKeepAlive(5, 3) # The rest of your app would go here normally, but for sake -- 1.8.5.3

2 2

[libvirt] Make systemd work with LXC user namespaces
by Richard Weinberger 11 Feb '14

11 Feb '14

These two patches fix the issue that control groups are unusable if user namespaces are enabled. We have to chown() the control group to the correct user. As the container mounts the control group and only the controller is allowed to chown() the mount point we need a new barrier to synchronize them after the container has setup the control groups. Thanks, //richard [PATCH 1/2] lxc: Add another barrier [PATCH 2/2] lxc: Add virCgroupSetOwner()

2 4

[libvirt] [PATCH] qemu: Implement a stub cpuArchDriver.baseline() handler for aarch64
by Oleg Strikov 11 Feb '14

11 Feb '14

Openstack Nova calls virConnectBaselineCPU() during initialization of the instance to get a full list of CPU features. This patch adds a stub to aarch64-specific code to handle this request (no actual work is done). That's enough to have this stub with limited functionality because qemu/kvm backend supports only 'host-passthrough' cpu mode on aarch64. Signed-off-by: Oleg Strikov <oleg.strikov(a)canonical.com> --- src/cpu/cpu_aarch64.c | 25 ++++++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/src/cpu/cpu_aarch64.c b/src/cpu/cpu_aarch64.c index f674bff..3c3e749 100644 --- a/src/cpu/cpu_aarch64.c +++ b/src/cpu/cpu_aarch64.c @@ -85,6 +85,29 @@ AArch64GuestData(virCPUDefPtr host ATTRIBUTE_UNUSED, return VIR_CPU_COMPARE_IDENTICAL; } +static virCPUDefPtr +AArch64Baseline(virCPUDefPtr *cpus, + unsigned int ncpus ATTRIBUTE_UNUSED, + const char **models ATTRIBUTE_UNUSED, + unsigned int nmodels ATTRIBUTE_UNUSED, + unsigned int flags) +{ + virCPUDefPtr cpu = NULL; + + virCheckFlags(VIR_CONNECT_BASELINE_CPU_EXPAND_FEATURES, NULL); + + if (VIR_ALLOC(cpu) < 0 || + VIR_STRDUP(cpu->model, cpus[0]->model) < 0) { + virCPUDefFree(cpu); + return NULL; + } + + cpu->type = VIR_CPU_TYPE_GUEST; + cpu->match = VIR_CPU_MATCH_EXACT; + + return cpu; +} + struct cpuArchDriver cpuDriverAARCH64 = { .name = "aarch64", .arch = archs, @@ -95,7 +118,7 @@ struct cpuArchDriver cpuDriverAARCH64 = { .free = AArch64DataFree, .nodeData = AArch64NodeData, .guestData = AArch64GuestData, - .baseline = NULL, + .baseline = AArch64Baseline, .update = AArch64Update, .hasFeature = NULL, }; -- 1.7.9.5

2 1

[libvirt] CPU models and feature probing (was Re: [Qemu-devel] [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties
by Eduardo Habkost 11 Feb '14

11 Feb '14

(CCing libvir-list again, as this is continuing a discussion about a subject that interests libvirt developers, from another thread.) On Thu, Feb 06, 2014 at 04:51:17PM +0100, Andreas Färber wrote: > Am 06.02.2014 16:19, schrieb Igor Mammedov: > > On Wed, 5 Feb 2014 17:52:16 +0100 > > Igor Mammedov <imammedo(a)redhat.com> wrote: > > > >> On Wed, 05 Feb 2014 17:14:27 +0100 > >> Andreas Färber <afaerber(a)suse.de> wrote: > >> > >>> Am 05.02.2014 15:40, schrieb Igor Mammedov: > >>>> On Sun, 15 Dec 2013 23:50:47 +0100 > >>>> Andreas Färber <afaerber(a)suse.de> wrote: > >>>> > >>>>> Am 27.11.2013 23:28, schrieb Igor Mammedov: > >>>>>> Igor Mammedov (16): > >>>>>> target-i386: cleanup 'foo' feature handling' > >>>>>> target-i386: cleanup 'foo=val' feature handling > >>>>> > >>>>> Thanks, I've queued these on qom-cpu-next: > >>>>> https://github.com/afaerber/qemu-cpu/commits/qom-cpu-next > >>>>> > >>>>>> target-i386: cpu: convert 'level' to static property > >>>>>> target-i386: cpu: convert 'xlevel' to static property > >>>>>> target-i386: cpu: convert 'family' to static property > >>>>>> target-i386: cpu: convert 'model' to static property > >>>>>> target-i386: cpu: convert 'stepping' to static property > >>>>>> target-i386: cpu: convert 'vendor' to static property > >>>>>> target-i386: cpu: convert 'model-id' to static property > >>>>>> target-i386: cpu: convert 'tsc-frequency' to static property > >>>>> > >>>>> But I still don't see the utility of this conversion after all the > >>>>> discussions we've had... :( > >>>> It seems there is movement to make DEVICE self describing for purpose > >>>> of QAPI schema introspection, where static properties would be used > >>>> (dynamic ones are not suitable for this purpose) > >>> > >>> Do you have a pointer to such a discussion? Sounds like I was not > >>> involved and Anthony probably not either... > >> Not at the moment, CCing people who might know more about the topic. > >> > >> But just thinking about creating QAPI schema for devices, it's not really > >> possible to generate one using dynamic properties (unless one resorts to > >> creating every supported device instance), while arrays of static properties > >> are there for every device and simplistically speaking just need conversion > >> to schema format. > > > > There is one more reason to use static properties for external user-settable > > properties when it comes to device, i.e. to get list of properties user could > > use command: > > #qemu -device x86_64-cpu,? > > x86_64-cpu.pmu=boolean > > x86_64-cpu.hv-spinlocks=int > > x86_64-cpu.hv-relaxed=boolean > > x86_64-cpu.hv-vapic=boolean > > x86_64-cpu.check=boolean > > x86_64-cpu.enforce=boolean > > > > which now yields only partial properties user is interested in, above > > mentioned conversion patches make previously not available properties > > visible to user via typical interface, perhaps eventually we could > > drop list_cpu() interface in favor of -device foo-cpu,? command. > > We already brought that up specifically for decision on a KVM call and > Anthony's clear statement was that the expected way for management tools > to discover properties was to instantiate the object and run qom-list on it. As far as I remember, this was decided as the recommended way to list the feature _default values_ (e.g. discover which features are going to be enabled on each CPU model). Is this really the recommended way to discover which properties can be set on device_add, too? We are not going to have any other instrospection mechanism that won't require objects to be created? > > It is a known issue, both for info qtree and -device, that they do not > list all properties. But I don't want to repeat this discussion over and > over again: Paolo's patches for static properties were rejected by > Anthony, therefore I could not queue them on qom-next back then and > therefore I had to code my properties for the X86CPU (which was not yet > a device back then) the new QOM way, and now you're trying to override > Anthony's decision in forcing me to accept patches that Anthony had > vetoed against! > > If you or libvirt need all properties for -device, then send a patch. No > one did for two years, so apparently no one cared. > > Static properties are considered a valid, convenient way to define > properties for a device but not the sole one for a device or object. > Using info qtree or -device as justification for implementation > decisions is backwards and wrong since those are considered legacy. So, let me ask again, explicitly: we are not going to ever have a QMP-based interface that will allow all available device_add options to be queried without instantiating an object first? This really surprises me. (That's not a question just for Andreas. I would like to hear from Paolo, Anthony, and others.) > > And specifically for libvirt Eduardo pushed into a release properties > that could be used to inspect CPUIDs. If that's not being used by > libvirt, as Eduardo seems to imply now, why did we put work in that in > the first place? It is not being used by libvirt because the current interface is unusable without running QEMU once for each CPU model. With the CPU model subclasses, we will be able to make it possible to create/destroy CPUs of different models in a single QEMU instance, and then libvirt will be able to use it. > > If there's no relation between a CPU model named, e.g., "Haswell" and > the one on an Intel Haswell chip any more, then we should give them > artificial names like "qemu64"; I strongly believe that Haswell > definition in code should match that of the specs/hardware and if TCG > can't emulate something that's one thing (subtractive: no AVX) and if > KVM wants to speed up things that's another (additive: kvmvapic, > in-kernel IRQ/PIT). What I am arguing against is watering the meaning of > our definitions from "this is this model" to "this is handy". In > particular, if we use the post_initialize hook like I suggested then > -global is still able to override it and Eduardo's properties should > correctly report them to libvirt. "Haswell" is named this way not only because it looks like Haswell, but also because it has useful features you are going to find only on Haswell, and you (probably) are not going to be able to run it on hosts older than Haswell. That's the main real-world application of CPU models: making sure the VMs can run on a specific subset of hosts. So, if you choose "Haswell", you are telling the management stack "I know this is going to run only on Haswell and newer CPUs". That's why x2apic is being proposed as an exception: it can be enabled on any host, because it doesn't depend on host-side support. That's why I propose we enable it on CPU models that don't have x2apic in the real world. (BTW, what is the relation between this subject and static properties? I was expecting this to be discussed in the other existing thread about x2apic) > > > Taking in account Paolo's cleanup of legacy properties in static properties, > > it might make them more suitable for moving concept to Object level. > > (As far as I remember, Anthony objected to it due to existence of legacy > > properties). > > That'll be for Anthony to answer, but static properties at Object level > would still not expose child<> and especially not link<> properties to > the user. > > Andreas > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- Eduardo

4 13

[libvirt] [PATCH] Rename 'index' in virCapabilitiesGetCpusForNode
by Ján Tomko 11 Feb '14

11 Feb '14

This shadows the index function on some systems (RHEL-6.4, FreeBSD 9): ../../src/conf/capabilities.c: In function 'virCapabilitiesGetCpusForNode': ../../src/conf/capabilities.c:1005: warning: declaration of'index' shadows a global declaration [-Wshadow] /usr/include/strings.h:57: warning: shadowed declaration is here [-Wshadow] --- src/conf/capabilities.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) Pushed as a build-breaker. diff --git a/src/conf/capabilities.c b/src/conf/capabilities.c index 78f65cb..c1c4ab8 100644 --- a/src/conf/capabilities.c +++ b/src/conf/capabilities.c @@ -1002,11 +1002,11 @@ virCapabilitiesGetCpusForNode(virCapsPtr caps, { virCapsHostNUMACellPtr cell = NULL; size_t cpu; - size_t index; + size_t i; /* The numa node numbers can be non-contiguous. Ex: 0,1,16,17. */ - for (index = 0; index < caps->host.nnumaCell; index++) { - if (caps->host.numaCell[index]->num == node) { - cell = caps->host.numaCell[index]; + for (i = 0; i < caps->host.nnumaCell; i++) { + if (caps->host.numaCell[i]->num == node) { + cell = caps->host.numaCell[i]; break; } } -- 1.8.3.2

3 2

[libvirt] [PATCH python] examples: event-test: Add network event support
by Cole Robinson 11 Feb '14

11 Feb '14

Just an example of network lifecycle events --- examples/event-test.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/examples/event-test.py b/examples/event-test.py index 1402c04..fb750c7 100644 --- a/examples/event-test.py +++ b/examples/event-test.py @@ -500,6 +500,14 @@ def myDomainEventPMSuspendDiskCallback(conn, dom, reason, opaque): def myDomainEventDeviceRemovedCallback(conn, dom, dev, opaque): print("myDomainEventDeviceRemovedCallback: Domain %s(%s) device removed: %s" % ( dom.name(), dom.ID(), dev)) +def myNetworkEventLifecycleCallback(conn, net, event, detail, opaque): + event_to_string = { + 0: "Defined", + 1: "Undefined", + 2: "Started", + 3: "Stopped", + } + print("myNetworkEventLifecycleCallback: Network %s: %s detail=%s" % (net.name(), event_to_string.get(event, "event=%s" % event), detail)) run = True @@ -577,6 +585,8 @@ def main(): vc.domainEventRegisterAny(None, libvirt.VIR_DOMAIN_EVENT_ID_PMSUSPEND_DISK, myDomainEventPMSuspendDiskCallback, None) vc.domainEventRegisterAny(None, libvirt.VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED, myDomainEventDeviceRemovedCallback, None) + vc.networkEventRegisterAny(None, libvirt.VIR_NETWORK_EVENT_ID_LIFECYCLE, myNetworkEventLifecycleCallback, None) + vc.setKeepAlive(5, 3) # The rest of your app would go here normally, but for sake -- 1.8.5.3

2 1