- Devel - libvirt List Archives

[PULL 16/36] hw/block: Deprecate the TC58128 block device
by Philippe Mathieu-Daudé 19 Jan '24

19 Jan '24

From: Samuel Tardieu <sam(a)rfc1149.net> The 16MiB flash device is only used by the deprecated shix machine. Its code it old and unmaintained, and has never been adapted to the QOM architecture. It still contains debug statements and uses global variables. It is time to deprecate it. Signed-off-by: Samuel Tardieu <sam(a)rfc1149.net> Reviewed-by: Cédric Le Goater <clg(a)redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd(a)linaro.org> Message-ID: <20240109083053.2581588-3-sam(a)rfc1149.net> Signed-off-by: Philippe Mathieu-Daudé <philmd(a)linaro.org> --- docs/about/deprecated.rst | 2 +- hw/block/tc58128.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index e6a12c9077..15e39f8bbb 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -273,7 +273,7 @@ The Nios II architecture is orphan. '''''''''''''''''''' The machine is no longer in existence and has been long unmaintained -in QEMU. +in QEMU. This also holds for the TC51828 16MiB flash that it uses. Backend options --------------- diff --git a/hw/block/tc58128.c b/hw/block/tc58128.c index d350126b27..6944cf58fa 100644 --- a/hw/block/tc58128.c +++ b/hw/block/tc58128.c @@ -202,6 +202,7 @@ static sh7750_io_device tc58128 = { int tc58128_init(struct SH7750State *s, const char *zone1, const char *zone2) { + warn_report_once("The TC58128 flash device is deprecated"); init_dev(&tc58128_devs[0], zone1); init_dev(&tc58128_devs[1], zone2); return sh7750_register_io_device(s, &tc58128); -- 2.41.0

1 0

[PULL 15/36] target/sh4: Deprecate the shix machine
by Philippe Mathieu-Daudé 19 Jan '24

19 Jan '24

From: Samuel Tardieu <sam(a)rfc1149.net> The shix machine has been designed and used at Télécom Paris from 2003 to 2010. It had been added to QEMU in 2005 and has not been maintained since. Since nobody is using the physical board anymore nor interested in maintaining the QEMU port, it is time to deprecate it. Signed-off-by: Samuel Tardieu <sam(a)rfc1149.net> Reviewed-by: Cédric Le Goater <clg(a)redhat.com> Reviewed-by: Yoshinori Sato <ysato(a)users.sourceforge.jp> Reviewed-by: Philippe Mathieu-Daudé <philmd(a)linaro.org> Message-ID: <20240109083053.2581588-2-sam(a)rfc1149.net> Signed-off-by: Philippe Mathieu-Daudé <philmd(a)linaro.org> --- docs/about/deprecated.rst | 5 +++++ hw/sh4/shix.c | 1 + 2 files changed, 6 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 2e15040246..e6a12c9077 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -269,6 +269,11 @@ Nios II ``10m50-ghrd`` and ``nios2-generic-nommu`` machines (since 8.2) The Nios II architecture is orphan. +``shix`` (since 9.0) +'''''''''''''''''''' + +The machine is no longer in existence and has been long unmaintained +in QEMU. Backend options --------------- diff --git a/hw/sh4/shix.c b/hw/sh4/shix.c index aa812512f0..eb3150b5bc 100644 --- a/hw/sh4/shix.c +++ b/hw/sh4/shix.c @@ -80,6 +80,7 @@ static void shix_machine_init(MachineClass *mc) mc->init = shix_init; mc->is_default = true; mc->default_cpu_type = TYPE_SH7750R_CPU; + mc->deprecation_reason = "old and unmaintained"; } DEFINE_MACHINE("shix", shix_machine_init) -- 2.41.0

1 0

[PATCH v2 0/2] ppc: Rename power5+ and power7+ for the new QOM naming rules
by Thomas Huth 18 Jan '24

18 Jan '24

We can get rid of the "power5+" / "power7+" hack in qom/object.c by using CPU aliases for those names instead (first patch). I think in the long run, we should get rid of the names with a "+" in it completely, so the second patch suggests to deprecate those, but I'd also be fine if we keep the aliases around, so in that case please ignore the second patch. v2: - Use "power5p" / "power7p" instead of "power5plus" / "power7plus" Thomas Huth (2): target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming rules docs/about: Deprecate the old "power5+" and "power7+" CPU names docs/about/deprecated.rst | 9 +++++++++ hw/ppc/spapr_cpu_core.c | 4 ++-- qom/object.c | 4 ---- target/ppc/cpu-models.c | 10 ++++++---- 4 files changed, 17 insertions(+), 10 deletions(-) -- 2.43.0

4 7

[PATCH 0/3] qapi/hmp/cli: Remove the deprecated 'singlestep'
by Philippe Mathieu-Daudé 17 Jan '24

17 Jan '24

Deprecated for 8.1, good to go for 9.0. Based-on: <20240112100059.965041-5-thuth(a)redhat.com> "Remove deprecated command line options" Philippe Mathieu-Daudé (3): qapi: Remove deprecated 'singlestep' member of StatusInfo hmp: Remove deprecated 'singlestep' command cli: Remove deprecated '-singlestep' command line option docs/about/deprecated.rst | 40 --------------------------------- docs/about/removed-features.rst | 24 ++++++++++++++++++++ docs/user/main.rst | 6 ----- qapi/run-state.json | 11 --------- bsd-user/main.c | 3 +-- linux-user/main.c | 2 -- system/runstate.c | 8 ------- system/vl.c | 18 +-------------- tests/qtest/test-hmp.c | 1 - hmp-commands.hx | 13 ----------- qemu-options.hx | 8 ------- tests/qemu-iotests/183.out | 4 ++-- tests/qemu-iotests/234.out | 8 +++---- tests/qemu-iotests/262.out | 4 ++-- tests/qemu-iotests/280.out | 2 +- 15 files changed, 35 insertions(+), 117 deletions(-) -- 2.41.0

4 6

[libvirt PATCH] news: document my changes for 10.0.0
by Ján Tomko 17 Jan '24

17 Jan '24

Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- NEWS.rst | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index e5df8224e9..4c799999fe 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -72,6 +72,12 @@ v10.0.0 (2024-01-15) change in a future release and can be customized with the nbdkit_config_default build option. + * qemu: add ID mapping support for virtiofsd + + New ``<idmap>`` element was added for virtiofsd-based ``<filesystem>`` + devices. It can be used to set up UID and GID mapping between host + and guest, making running virtiofsd unprivileged much more useful. + * **Improvements** * qemu: Improve migration XML use when persisting VM on destination @@ -94,6 +100,11 @@ v10.0.0 (2024-01-15) The test driver now supports basic hotplug and hotunplug of PCI devices. + * qemu: allow virtiofsd to run unprivileged + + Nowadays virtiofsd no longer requires to run with root privileges, so the + restriction to always run as root is now removed from libvirt too. + * **Bug fixes** * qemu: Various migration bug fixes and debuggability improvement -- 2.42.0

2 1

[PATCH 00/18] Grab bag of fixes and improvements
by Andrea Bolognani 17 Jan '24

17 Jan '24

This started out as a way to make the upcoming loongarch64 support slightly nicer to implement, but ended up including a bunch of tangentially related changes. Since trying to unentangle them would just result in a bunch of smaller series that still have dependencies on each other, I'm just sending everything at once. Andrea Bolognani (18): tests: Add devices to pseries-phb-simple tests: Add pseries-phb-user-alias qemu: Fix handling of user aliases for default PHB tests: Drop aarch64-virtio-pci-default tests: Add {aarch64,riscv64}-virt-headless-mmio tests: Drop various redundant tests tests: Simplify balloon-mmio-deflate tests: Request virtio-mmio for balloon-mmio-deflate qemu: Stop checking QEMU_CAPS_OBJECT_GPEX qemu: Retire QEMU_CAPS_OBJECT_GPEX qemu: Improve qemuDomainSupportsPCI() qemu: Move qemuDomainSupportsPCIMultibus() qemu: Improve qemuDomainSupportsPCIMultibus() tests: Add *-default-net qemu: Improve qemuDomainDefaultNetModel() tests: Add *-default-devices qemu: Don't add memballoon by default on RISC-V qemu: Default to no USB and no memballoon for new architectures src/qemu/qemu_alias.c | 2 +- src/qemu/qemu_capabilities.c | 31 +----- src/qemu/qemu_capabilities.h | 4 +- src/qemu/qemu_command.c | 25 ++++- src/qemu/qemu_domain.c | 94 ++++++++++++------- src/qemu/qemu_domain.h | 4 +- src/qemu/qemu_domain_address.c | 2 +- .../caps_4.2.0_aarch64.xml | 1 - .../caps_5.0.0_aarch64.xml | 1 - .../caps_5.0.0_riscv64.xml | 1 - .../caps_5.2.0_aarch64.xml | 1 - .../caps_5.2.0_riscv64.xml | 1 - .../caps_5.2.0_x86_64.xml | 1 - .../caps_6.0.0_aarch64.xml | 1 - .../caps_6.0.0_x86_64.xml | 1 - .../caps_6.1.0_x86_64.xml | 1 - .../caps_6.2.0_aarch64.xml | 1 - .../caps_6.2.0_x86_64.xml | 1 - .../caps_7.0.0_aarch64+hvf.xml | 1 - .../caps_7.0.0_aarch64.xml | 1 - .../caps_7.0.0_x86_64.xml | 1 - .../caps_7.1.0_x86_64.xml | 1 - .../caps_7.2.0_x86_64+hvf.xml | 1 - .../caps_7.2.0_x86_64.xml | 1 - .../caps_8.0.0_riscv64.xml | 1 - .../caps_8.0.0_x86_64.xml | 1 - .../caps_8.1.0_x86_64.xml | 1 - .../caps_8.2.0_aarch64.xml | 1 - .../caps_8.2.0_x86_64.xml | 1 - .../caps_9.0.0_x86_64.xml | 1 - ...ch64-aavmf-virtio-mmio.aarch64-latest.args | 46 --------- .../aarch64-aavmf-virtio-mmio.xml | 49 ---------- ...arch64-default-devices.aarch64-latest.args | 31 ++++++ .../aarch64-default-devices.xml | 12 +++ .../aarch64-default-net.aarch64-latest.args | 35 +++++++ .../qemuxml2argvdata/aarch64-default-net.xml | 17 ++++ ...h64-virt-headless-mmio.aarch64-latest.args | 48 ++++++++++ .../aarch64-virt-headless-mmio.xml | 48 ++++++++++ ...ch64-virtio-pci-default.aarch64-4.2.0.args | 54 ----------- ...h64-virtio-pci-default.aarch64-latest.args | 54 ----------- .../aarch64-virtio-pci-default.xml | 44 --------- .../arm-virt-virtio.aarch64-latest.args | 54 ----------- tests/qemuxml2argvdata/arm-virt-virtio.xml | 45 --------- .../balloon-mmio-deflate.aarch64-latest.args | 4 - .../qemuxml2argvdata/balloon-mmio-deflate.xml | 17 +--- ...> ppc64-default-devices.ppc64-latest.args} | 22 ++--- .../ppc64-default-devices.xml | 12 +++ ...gs => ppc64-default-net.ppc64-latest.args} | 22 ++--- ...s-phb-simple.xml => ppc64-default-net.xml} | 12 +-- .../pseries-phb-simple.ppc64-latest.args | 5 +- tests/qemuxml2argvdata/pseries-phb-simple.xml | 11 ++- ... pseries-phb-user-alias.ppc64-latest.args} | 7 +- .../pseries-phb-user-alias.xml | 30 ++++++ ...iscv64-default-devices.riscv64-latest.args | 30 ++++++ .../riscv64-default-devices.xml | 12 +++ .../riscv64-default-net.riscv64-latest.args | 34 +++++++ .../qemuxml2argvdata/riscv64-default-net.xml | 17 ++++ ...64-virt-headless-mmio.riscv64-latest.args} | 39 ++++---- .../riscv64-virt-headless-mmio.xml | 43 +++++++++ .../riscv64-virt-pci.riscv64-latest.args | 35 ------- tests/qemuxml2argvdata/riscv64-virt-pci.xml | 24 ----- .../riscv64-virt.riscv64-latest.args | 38 -------- tests/qemuxml2argvdata/riscv64-virt.xml | 19 ---- .../s390x-default-devices.s390x-latest.args | 32 +++++++ .../s390x-default-devices.xml | 12 +++ .../s390x-default-net.s390x-latest.args | 33 +++++++ tests/qemuxml2argvdata/s390x-default-net.xml | 17 ++++ .../x86_64-default-devices.x86_64-latest.args | 33 +++++++ .../x86_64-default-devices.xml | 12 +++ .../x86_64-default-net.x86_64-latest.args | 33 +++++++ tests/qemuxml2argvdata/x86_64-default-net.xml | 17 ++++ tests/qemuxml2argvtest.c | 47 ++++------ ...rch64-aavmf-virtio-mmio.aarch64-latest.xml | 56 ----------- ...aarch64-default-devices.aarch64-latest.xml | 26 +++++ .../aarch64-default-net.aarch64-latest.xml | 43 +++++++++ ...ch64-virt-headless-mmio.aarch64-latest.xml | 71 ++++++++++++++ ...ch64-virtio-pci-default.aarch64-latest.xml | 94 ------------------- ...=> ppc64-default-devices.ppc64-latest.xml} | 24 ++--- ...xml => ppc64-default-net.ppc64-latest.xml} | 23 ++--- .../pseries-phb-simple.ppc64-latest.xml | 14 ++- ...> pseries-phb-user-alias.ppc64-latest.xml} | 18 +++- ...riscv64-default-devices.riscv64-latest.xml | 20 ++++ .../riscv64-default-net.riscv64-latest.xml | 37 ++++++++ ...cv64-virt-headless-mmio.riscv64-latest.xml | 58 ++++++++++++ .../s390x-default-devices.s390x-latest.xml | 27 ++++++ .../s390x-default-net.s390x-latest.xml | 31 ++++++ .../x86_64-default-devices.x86_64-latest.xml | 31 ++++++ .../x86_64-default-net.x86_64-latest.xml | 32 +++++++ tests/qemuxml2xmltest.c | 21 ++++- 89 files changed, 1162 insertions(+), 855 deletions(-) delete mode 100644 tests/qemuxml2argvdata/aarch64-aavmf-virtio-mmio.aarch64-latest.args delete mode 100644 tests/qemuxml2argvdata/aarch64-aavmf-virtio-mmio.xml create mode 100644 tests/qemuxml2argvdata/aarch64-default-devices.aarch64-latest.args create mode 100644 tests/qemuxml2argvdata/aarch64-default-devices.xml create mode 100644 tests/qemuxml2argvdata/aarch64-default-net.aarch64-latest.args create mode 100644 tests/qemuxml2argvdata/aarch64-default-net.xml create mode 100644 tests/qemuxml2argvdata/aarch64-virt-headless-mmio.aarch64-latest.args create mode 100644 tests/qemuxml2argvdata/aarch64-virt-headless-mmio.xml delete mode 100644 tests/qemuxml2argvdata/aarch64-virtio-pci-default.aarch64-4.2.0.args delete mode 100644 tests/qemuxml2argvdata/aarch64-virtio-pci-default.aarch64-latest.args delete mode 100644 tests/qemuxml2argvdata/aarch64-virtio-pci-default.xml delete mode 100644 tests/qemuxml2argvdata/arm-virt-virtio.aarch64-latest.args delete mode 100644 tests/qemuxml2argvdata/arm-virt-virtio.xml copy tests/qemuxml2argvdata/{pseries-phb-simple.ppc64-latest.args => ppc64-default-devices.ppc64-latest.args} (56%) create mode 100644 tests/qemuxml2argvdata/ppc64-default-devices.xml copy tests/qemuxml2argvdata/{pseries-phb-simple.ppc64-latest.args => ppc64-default-net.ppc64-latest.args} (56%) copy tests/qemuxml2argvdata/{pseries-phb-simple.xml => ppc64-default-net.xml} (55%) copy tests/qemuxml2argvdata/{pseries-phb-simple.ppc64-latest.args => pseries-phb-user-alias.ppc64-latest.args} (75%) create mode 100644 tests/qemuxml2argvdata/pseries-phb-user-alias.xml create mode 100644 tests/qemuxml2argvdata/riscv64-default-devices.riscv64-latest.args create mode 100644 tests/qemuxml2argvdata/riscv64-default-devices.xml create mode 100644 tests/qemuxml2argvdata/riscv64-default-net.riscv64-latest.args create mode 100644 tests/qemuxml2argvdata/riscv64-default-net.xml rename tests/qemuxml2argvdata/{aarch64-virt-virtio-MMIO.aarch64.latest.args => riscv64-virt-headless-mmio.riscv64-latest.args} (50%) create mode 100644 tests/qemuxml2argvdata/riscv64-virt-headless-mmio.xml delete mode 100644 tests/qemuxml2argvdata/riscv64-virt-pci.riscv64-latest.args delete mode 100644 tests/qemuxml2argvdata/riscv64-virt-pci.xml delete mode 100644 tests/qemuxml2argvdata/riscv64-virt.riscv64-latest.args delete mode 100644 tests/qemuxml2argvdata/riscv64-virt.xml create mode 100644 tests/qemuxml2argvdata/s390x-default-devices.s390x-latest.args create mode 100644 tests/qemuxml2argvdata/s390x-default-devices.xml create mode 100644 tests/qemuxml2argvdata/s390x-default-net.s390x-latest.args create mode 100644 tests/qemuxml2argvdata/s390x-default-net.xml create mode 100644 tests/qemuxml2argvdata/x86_64-default-devices.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/x86_64-default-devices.xml create mode 100644 tests/qemuxml2argvdata/x86_64-default-net.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/x86_64-default-net.xml delete mode 100644 tests/qemuxml2xmloutdata/aarch64-aavmf-virtio-mmio.aarch64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/aarch64-default-devices.aarch64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/aarch64-default-net.aarch64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/aarch64-virt-headless-mmio.aarch64-latest.xml delete mode 100644 tests/qemuxml2xmloutdata/aarch64-virtio-pci-default.aarch64-latest.xml copy tests/qemuxml2xmloutdata/{pseries-phb-simple.ppc64-latest.xml => ppc64-default-devices.ppc64-latest.xml} (58%) copy tests/qemuxml2xmloutdata/{pseries-phb-simple.ppc64-latest.xml => ppc64-default-net.ppc64-latest.xml} (63%) copy tests/qemuxml2xmloutdata/{pseries-phb-simple.ppc64-latest.xml => pseries-phb-user-alias.ppc64-latest.xml} (69%) create mode 100644 tests/qemuxml2xmloutdata/riscv64-default-devices.riscv64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/riscv64-default-net.riscv64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/riscv64-virt-headless-mmio.riscv64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/s390x-default-devices.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/s390x-default-net.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/x86_64-default-devices.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/x86_64-default-net.x86_64-latest.xml -- 2.43.0

3 49

[PATCH 0/2] ppc: Rename power5+ and power7+ for the new QOM naming rules
by Thomas Huth 17 Jan '24

17 Jan '24

We can get rid of the "power5+" / "power7+" hack in qom/object.c by using CPU aliases for those names instead (first patch). I think in the long run, we should get rid of the names with a "+" in it completely, so the second patch suggests to deprecate those, but I'd also be fine if we keep the aliases around, so in that case please ignore the second patch. Thomas Huth (2): target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming rules docs/about: Deprecate the old "power5+" and "power7+" CPU names docs/about/deprecated.rst | 9 +++++++++ hw/ppc/spapr_cpu_core.c | 4 ++-- qom/object.c | 4 ---- target/ppc/cpu-models.c | 10 ++++++---- 4 files changed, 17 insertions(+), 10 deletions(-) -- 2.43.0

6 12

[PATCH 00/23] qemu XML testing improvements, part 2 - enforcement of xml->xml testing
by Peter Krempa 17 Jan '24

17 Jan '24

TL;DR: Patch 23/23 is optional, read below! This patch saga aims to improve and simplify testing of qemu XML configs. Part 1 ensured that all input XMLs are invoked from qemuxml2argvtest In part 2 I've focused on untangling xml->xml testing, explaining and cleaning up cases which don't make sense and finally strictly enforcing a xml->xml invocation for each xml->argv invocation. The last part is done by merging xml->xml testing into qemuxml2argvtest. As a final, but optional step qemuxml2argvtest is then renamed to qemuxmlconftest to avoid confsion. I can understand that muscle memory can be hard to change, and thus this step is optional and I have no problem in dropping that patch. This had negligible impact on the run-time of qemuxml2argvtest(qemuxmlconftest): Before: Benchmark 1: ./tests/qemuxml2argvtest Time (mean ± σ): 1.709 s ± 0.023 s [User: 1.461 s, System: 0.236 s] Range (min … max): 1.672 s … 1.744 s 10 runs Benchmark 1: ./tests/qemuxml2xmltest Time (mean ± σ): 671.2 ms ± 11.9 ms [User: 591.7 ms, System: 75.0 ms] Range (min … max): 656.3 ms … 684.9 ms 10 runs After: Benchmark 1: ./tests/qemuxmlconftest Time (mean ± σ): 1.748 s ± 0.024 s [User: 1.500 s, System: 0.236 s] Range (min … max): 1.721 s … 1.788 s 10 runs Part 3 will then deal with ensuring that libvirt-generated XML can be parsed back and formatted identically, including fixes to ensure that it is actually the case. Parsing the libvirt-generated XML, formatting it back and checking it for identity can expose problems in formatting of auto-filled values (I've caught one such case in review, but not with the test, but rather with seing that the code is broken). Peter Krempa (23): virschematest: Add possibility to have exceptions from the '-invalid' suffix qemuxml2xmltest: Add invocation for 'numatune-auto-nodeset-invalid' case qemuxmlargvdata: disk-network-nfs: Drop 'index' attribute from backing store qemuxml2xmltest: Use same parameters as in qemuxml2argvtest for 'riscv64-virt' testCompareDomXML2XMLFiles: Sanitize handling of 'parse_flags' tests: Rename 'qemustatusxml2xmltest' to 'qemuxmlactivetest' testutilsqemu: Create a typedef for struct testQemuInfo qemu*xml2*test: Invoke tests from a function qemuxmlactivetest: Prepare for proper active/inactive -> active/inactive testing qemuxmlactivetest: Add qemu active XML to active/inactive XML tests qemuxml2xmltest: Parse all input files as inactive qemuxml2*test: Remove FLAG_SKIP_CONFIG_ACTIVE flag qemuxml2xmltest: Remove pointless inactive->active testing qemuxml2argvtest: Remove unused separate parsing of arch qemuxml2argvtest: Use virDomainDefParseFile instead of virXMLParse+virDomainDefParseNode qemuxml2argvtest: Setup fake driver only once qemuxml2argvtest: Extract setup/parse step qemuxml2argvtest: Add parsing of the input XML as separate test qemuxml2argvtest: Test (inactive) def -> xml conversion tests: Remove qemuxml2xmltest qemuxml2argvtest: Populate all outstanding def->xml cases meson: tests: Allow 'timeout' override for all tests tests: Rename 'qemuxml2argvtest' to 'qemuxmlconftest' docs/advanced-tests.rst | 12 +- src/conf/domain_conf.c | 2 + src/util/virsecret.c | 2 +- tests/meson.build | 13 +- tests/qemucapabilitiesdata/README.rst | 4 +- tests/qemustatusxml2xmltest.c | 130 --- tests/qemuxml2argvdata/disk-network-nfs.xml | 2 +- .../qemuxml2argvdata/mach-virt-serial-usb.xml | 2 +- tests/qemuxml2argvdata/pseries-serial-usb.xml | 2 +- ...aarch64-cpu-passthrough.aarch64-latest.xml | 42 + .../aarch64-features-wrong.aarch64-latest.xml | 28 + .../aarch64-gic-default.aarch64-4.2.0.xml | 26 + .../aarch64-gic-none.aarch64-4.2.0.xml | 26 + .../aarch64-kvm-32-on-64.aarch64-latest.xml | 64 + ...arch64-virt-default-nic.aarch64-latest.xml | 44 + ...arch64-virt-virtio-MMIO.aarch64.latest.xml | 63 + .../aarch64-virt-virtio.aarch64-4.2.0.xml | 94 ++ .../aarch64-virt-virtio.aarch64-latest.xml | 94 ++ ...rch64-virtio-pci-default.aarch64-4.2.0.xml | 94 ++ .../arm-vexpressa9-basic.aarch64-latest.xml | 46 + .../arm-vexpressa9-nodevs.aarch64-latest.xml | 31 + .../arm-vexpressa9-virtio.aarch64-latest.xml | 61 + .../arm-virt-virtio.aarch64-latest.xml | 95 ++ .../audio-default-sdl.x86_64-4.2.0.xml | 44 + .../audio-default-spice.x86_64-4.2.0.xml | 46 + .../audio-default-vnc.x86_64-4.2.0.xml | 46 + .../audio-jack-minimal.x86_64-latest.xml | 39 + .../balloon-ccw-deflate.s390x-latest.xml | 27 + ...lloon-device-deflate-off.x86_64-latest.xml | 40 + .../balloon-device-deflate.x86_64-latest.xml | 40 + .../balloon-device.x86_64-latest.xml | 40 + .../balloon-mmio-deflate.aarch64-latest.xml | 34 + .../boot-complex.x86_64-latest.xml | 89 ++ .../boot-menu-disable-drive.x86_64-latest.xml | 42 + .../boot-menu-enable.x86_64-latest.xml | 42 + .../channel-spicevmc.x86_64-latest.xml | 55 + .../channel-unix-guestfwd.x86_64-latest.xml | 42 + ...hannel-unix-source-path.x86_64-latest.xml} | 0 .../channel-virtio-autoadd.x86_64-latest.xml | 70 ++ ...hannel-virtio-autoassign.x86_64-latest.xml | 70 ++ .../channel-virtio-default.x86_64-latest.xml | 61 + ...=> channel-virtio-state.x86_64-latest.xml} | 0 .../channel-virtio-unix.x86_64-latest.xml | 60 + .../chardev-reconnect.x86_64-latest.xml | 72 ++ .../clock-france.x86_64-latest.xml | 40 + .../clock-hpet-off.x86_64-7.2.0.xml | 44 + .../clock-hpet-off.x86_64-latest.xml | 44 + ...ocaltime-basis-localtime.x86_64-latest.xml | 40 + .../clock-variable.x86_64-latest.xml | 40 + .../console-compat-chardev.x86_64-latest.xml | 48 + .../console-sclp.s390x-latest.xml | 36 + .../console-virtio-ccw.s390x-latest.xml | 39 + .../console-virtio-unix.x86_64-latest.xml | 45 + .../controller-order.x86_64-latest.xml | 98 ++ .../cpu-Haswell-noTSX.x86_64-latest.xml | 31 + .../cpu-Haswell.x86_64-latest.xml | 31 + .../cpu-Haswell2.x86_64-latest.xml | 33 + .../cpu-Haswell3.x86_64-latest.xml | 33 + .../cpu-cache-disable.x86_64-latest.xml | 31 + .../cpu-cache-disable3.x86_64-latest.xml | 31 + .../cpu-cache-emulate-l3.x86_64-latest.xml | 31 + .../cpu-cache-passthrough.x86_64-latest.xml | 31 + .../cpu-exact1.x86_64-latest.xml | 38 + .../cpu-exact2-nofallback.x86_64-latest.xml | 45 + .../cpu-exact2.x86_64-latest.xml | 45 + .../cpu-fallback.x86_64-5.2.0.xml | 40 + .../cpu-fallback.x86_64-8.0.0.xml | 40 + .../cpu-host-model-cmt.x86_64-latest.xml | 29 + ...u-host-model-fallback-kvm.x86_64-4.2.0.xml | 29 + ...u-host-model-fallback-kvm.x86_64-5.0.0.xml | 29 + ...u-host-model-fallback-kvm.x86_64-5.1.0.xml | 29 + ...u-host-model-fallback-kvm.x86_64-5.2.0.xml | 29 + ...u-host-model-fallback-kvm.x86_64-6.0.0.xml | 29 + ...u-host-model-fallback-kvm.x86_64-6.1.0.xml | 29 + ...u-host-model-fallback-kvm.x86_64-6.2.0.xml | 29 + ...u-host-model-fallback-kvm.x86_64-7.0.0.xml | 29 + ...u-host-model-fallback-kvm.x86_64-7.1.0.xml | 29 + ...u-host-model-fallback-kvm.x86_64-7.2.0.xml | 29 + ...u-host-model-fallback-kvm.x86_64-8.0.0.xml | 29 + ...u-host-model-fallback-kvm.x86_64-8.1.0.xml | 29 + ...-host-model-fallback-kvm.x86_64-latest.xml | 29 + ...u-host-model-fallback-tcg.x86_64-4.2.0.xml | 29 + ...u-host-model-fallback-tcg.x86_64-5.0.0.xml | 29 + ...u-host-model-fallback-tcg.x86_64-5.1.0.xml | 29 + ...u-host-model-fallback-tcg.x86_64-5.2.0.xml | 29 + ...u-host-model-fallback-tcg.x86_64-6.0.0.xml | 29 + ...u-host-model-fallback-tcg.x86_64-6.1.0.xml | 29 + ...u-host-model-fallback-tcg.x86_64-6.2.0.xml | 29 + ...u-host-model-fallback-tcg.x86_64-7.0.0.xml | 29 + ...u-host-model-fallback-tcg.x86_64-7.1.0.xml | 29 + ...u-host-model-fallback-tcg.x86_64-7.2.0.xml | 29 + ...u-host-model-fallback-tcg.x86_64-8.0.0.xml | 29 + ...u-host-model-fallback-tcg.x86_64-8.1.0.xml | 29 + ...-host-model-fallback-tcg.x86_64-latest.xml | 29 + .../cpu-host-model-kvm.x86_64-4.2.0.xml | 48 + .../cpu-host-model-kvm.x86_64-5.0.0.xml | 48 + .../cpu-host-model-kvm.x86_64-5.1.0.xml | 48 + .../cpu-host-model-kvm.x86_64-5.2.0.xml | 48 + .../cpu-host-model-kvm.x86_64-6.0.0.xml | 48 + .../cpu-host-model-kvm.x86_64-6.1.0.xml | 48 + .../cpu-host-model-kvm.x86_64-6.2.0.xml | 48 + .../cpu-host-model-kvm.x86_64-7.0.0.xml | 48 + .../cpu-host-model-kvm.x86_64-7.1.0.xml | 48 + .../cpu-host-model-kvm.x86_64-7.2.0.xml | 48 + .../cpu-host-model-kvm.x86_64-8.0.0.xml | 48 + .../cpu-host-model-kvm.x86_64-8.1.0.xml | 48 + .../cpu-host-model-kvm.x86_64-latest.xml | 48 + ...host-model-nofallback-kvm.x86_64-4.2.0.xml | 29 + ...host-model-nofallback-kvm.x86_64-5.0.0.xml | 29 + ...host-model-nofallback-kvm.x86_64-5.1.0.xml | 29 + ...host-model-nofallback-kvm.x86_64-5.2.0.xml | 29 + ...host-model-nofallback-kvm.x86_64-6.0.0.xml | 29 + ...host-model-nofallback-kvm.x86_64-6.1.0.xml | 29 + ...host-model-nofallback-kvm.x86_64-6.2.0.xml | 29 + ...host-model-nofallback-kvm.x86_64-7.0.0.xml | 29 + ...host-model-nofallback-kvm.x86_64-7.1.0.xml | 29 + ...host-model-nofallback-kvm.x86_64-7.2.0.xml | 29 + ...host-model-nofallback-kvm.x86_64-8.0.0.xml | 29 + ...host-model-nofallback-kvm.x86_64-8.1.0.xml | 29 + ...ost-model-nofallback-kvm.x86_64-latest.xml | 29 + ...host-model-nofallback-tcg.x86_64-4.2.0.xml | 29 + ...host-model-nofallback-tcg.x86_64-5.0.0.xml | 29 + ...host-model-nofallback-tcg.x86_64-5.1.0.xml | 29 + ...host-model-nofallback-tcg.x86_64-5.2.0.xml | 29 + ...host-model-nofallback-tcg.x86_64-6.0.0.xml | 29 + ...host-model-nofallback-tcg.x86_64-6.1.0.xml | 29 + ...host-model-nofallback-tcg.x86_64-6.2.0.xml | 29 + ...host-model-nofallback-tcg.x86_64-7.0.0.xml | 29 + ...host-model-nofallback-tcg.x86_64-7.1.0.xml | 29 + ...host-model-nofallback-tcg.x86_64-7.2.0.xml | 29 + ...host-model-nofallback-tcg.x86_64-8.0.0.xml | 29 + ...host-model-nofallback-tcg.x86_64-8.1.0.xml | 29 + ...ost-model-nofallback-tcg.x86_64-latest.xml | 29 + .../cpu-host-model-tcg.x86_64-4.2.0.xml | 48 + .../cpu-host-model-tcg.x86_64-5.0.0.xml | 48 + .../cpu-host-model-tcg.x86_64-5.1.0.xml | 48 + .../cpu-host-model-tcg.x86_64-5.2.0.xml | 48 + .../cpu-host-model-tcg.x86_64-6.0.0.xml | 48 + .../cpu-host-model-tcg.x86_64-6.1.0.xml | 48 + .../cpu-host-model-tcg.x86_64-6.2.0.xml | 48 + .../cpu-host-model-tcg.x86_64-7.0.0.xml | 48 + .../cpu-host-model-tcg.x86_64-7.1.0.xml | 48 + .../cpu-host-model-tcg.x86_64-7.2.0.xml | 48 + .../cpu-host-model-tcg.x86_64-8.0.0.xml | 48 + .../cpu-host-model-tcg.x86_64-8.1.0.xml | 48 + .../cpu-host-model-tcg.x86_64-latest.xml | 48 + .../cpu-host-passthrough.x86_64-latest.xml | 29 + .../cpu-hotplug-startup.x86_64-latest.xml | 40 + .../cpu-minimum1.x86_64-latest.xml | 31 + .../cpu-minimum2.x86_64-latest.xml | 35 + .../cpu-no-removed-features.x86_64-latest.xml | 33 + .../cpu-nofallback.x86_64-5.2.0.xml | 40 + .../cpu-nofallback.x86_64-8.0.0.xml | 40 + .../cpu-phys-bits-emulate.x86_64-latest.xml | 31 + .../cpu-phys-bits-emulate2.x86_64-latest.xml | 31 + ...pu-phys-bits-passthrough.x86_64-latest.xml | 31 + ...pu-qemu-host-passthrough.x86_64-latest.xml | 29 + .../cpu-s390-features.s390x-latest.xml | 27 + .../cpu-s390-zEC12.s390x-latest.xml | 25 + .../cpu-strict1.x86_64-latest.xml | 58 + .../cpu-topology1.x86_64-latest.xml | 32 + .../cpu-topology2.x86_64-latest.xml | 32 + .../cpu-topology3.x86_64-latest.xml | 32 + .../cpu-topology4.x86_64-latest.xml | 32 + .../cpu-translation.x86_64-latest.xml | 44 + .../cpu-tsc-frequency.x86_64-latest.xml | 41 + ...l => disk-active-commit.x86_64-latest.xml} | 0 ...sk-backing-chains-index.x86_64-latest.xml} | 0 ...network-invalid-inactive.x86_64-latest.xml | 1 - ...m-empty-network-invalid.x86_64-latest.xml} | 0 ...isk-cdrom-network-nbdkit.x86_64-latest.xml | 72 ++ .../disk-cdrom-tray.x86_64-latest.xml | 56 + .../disk-device-removable.x86_64-latest.xml | 54 + .../disk-error-policy-s390x.s390x-latest.xml | 43 + .../disk-floppy-pseries.ppc64-latest.xml | 44 + .../disk-floppy-q35.x86_64-latest.xml | 56 + .../disk-floppy-tray.x86_64-latest.xml | 53 + .../disk-geometry.x86_64-latest.xml | 41 + .../disk-ide-split.x86_64-latest.xml | 47 + .../disk-ide-wwn.x86_64-latest.xml | 42 + .../disk-ioeventfd.x86_64-latest.xml | 58 + ....xml => disk-mirror-old.x86_64-latest.xml} | 0 ...test.xml => disk-mirror.x86_64-latest.xml} | 0 ...disk-network-http-nbdkit.x86_64-latest.xml | 72 ++ .../disk-network-nfs.x86_64-latest.xml | 2 +- ...isk-network-rbd-no-colon.x86_64-latest.xml | 50 + .../disk-network-sheepdog.x86_64-6.0.0.xml | 46 + ...rce-curl-nbdkit-backing.x86_64-latest.xml} | 31 +- ...twork-source-curl-nbdkit.x86_64-latest.xml | 96 ++ ...disk-network-source-curl.x86_64-latest.xml | 96 ++ .../disk-network-ssh-key.x86_64-latest.xml | 49 + .../disk-network-ssh-nbdkit.x86_64-latest.xml | 38 + ...isk-network-ssh-password.x86_64-latest.xml | 41 + .../disk-network-ssh.x86_64-latest.xml | 38 + .../disk-network-tlsx509-nbd.x86_64-5.2.0.xml | 37 + .../disk-no-boot.x86_64-latest.xml | 54 + .../disk-order.x86_64-latest.xml | 59 + .../disk-readonly-disk.x86_64-latest.xml | 47 + .../disk-scsi-disk-split.x86_64-latest.xml | 69 ++ .../disk-scsi-disk-wwn.x86_64-latest.xml | 53 + ...isk-scsi-lun-passthrough.x86_64-latest.xml | 49 + .../disk-shared.x86_64-latest.xml | 66 ++ .../disk-snapshot.x86_64-latest.xml | 53 + .../disk-vhostuser-numa.x86_64-4.2.0.xml | 48 + .../disk-vhostuser-numa.x86_64-latest.xml | 48 + .../disk-vhostvdpa.x86_64-latest.xml | 40 + .../disk-virtio-ccw-many.s390x-latest.xml | 51 + .../disk-virtio-ccw.s390x-latest.xml | 39 + ...-virtio-scsi-reservations.x86_64-5.2.0.xml | 53 + .../fips-enabled.x86_64-5.1.0.xml | 40 + .../fips-enabled.x86_64-latest.xml | 40 + .../fs9p-ccw.s390x-latest.xml | 50 + .../qemuxml2xmloutdata/fs9p.x86_64-latest.xml | 44 + ...atest.xml => genid-auto.x86_64-latest.xml} | 0 ..._64-latest.xml => genid.x86_64-latest.xml} | 0 .../graphics-dbus-usbredir.x86_64-latest.xml | 42 + .../graphics-egl-headless.x86_64-latest.xml | 42 + ...cs-spice-agent-file-xfer.x86_64-latest.xml | 48 + ...raphics-spice-agentmouse.x86_64-latest.xml | 50 + ...spice-gl-auto-rendernode.x86_64-latest.xml | 39 + .../graphics-spice-no-args.x86_64-latest.xml | 38 + .../graphics-spice-sasl.x86_64-latest.xml | 41 + ...graphics-spice-usb-redir.x86_64-latest.xml | 66 ++ .../graphics-vnc-none.x86_64-latest.xml | 39 + .../graphics-vnc-policy.x86_64-latest.xml | 45 + .../graphics-vnc-power.x86_64-latest.xml | 45 + ...remove-generated-socket.x86_64-latest.xml} | 0 ...s-vnc-socket-new-cmdline.x86_64-latest.xml | 36 + .../graphics-vnc-tls-secret.x86_64-5.2.0.xml | 39 + .../graphics-vnc-tls-secret.x86_64-latest.xml | 39 + ...splay-spice-egl-headless.x86_64-latest.xml | 46 + ...dev-display-spice-opengl.x86_64-latest.xml | 46 + ...display-vnc-egl-headless.x86_64-latest.xml | 46 + ...hostdev-mdev-display-vnc.x86_64-latest.xml | 45 + ...stdev-pci-address-device.x86_64-latest.xml | 46 + ...tdev-scsi-vhost-scsi-pcie.x86_64-4.2.0.xml | 45 + ...-usb-address-device-boot.x86_64-latest.xml | 45 + ...stdev-usb-address-device.x86_64-latest.xml | 45 + ...hostdev-vfio-multidomain.x86_64-latest.xml | 46 + .../hotplug-base.x86_64-latest.xml | 44 + .../hugepages-default-5M.x86_64-latest.xml | 41 + .../hugepages-numa-default.x86_64-latest.xml | 35 + .../hyperv-passthrough.x86_64-6.1.0.xml | 34 + .../input-usbmouse-addr.x86_64-latest.xml | 43 + .../iothreads-disk-virtio-ccw.s390x-4.2.0.xml | 41 + ...iothreads-virtio-scsi-pci.x86_64-5.2.0.xml | 49 + .../kvm-pit-delay.x86_64-latest.xml | 42 + .../kvm-pit-discard.x86_64-latest.xml | 42 + .../kvmclock+eoi-disabled.x86_64-latest.xml | 38 + .../launch-security-s390-pv.s390x-latest.xml | 32 + ...unch-security-sev-direct.x86_64-latest.xml | 48 + ...sev-missing-platform-info.x86_64-6.0.0.xml | 43 + .../launch-security-sev.x86_64-6.0.0.xml | 45 + .../luks-disks-source-qcow2.x86_64-5.2.0.xml | 107 ++ ...achine-aeskeywrap-off-cap.s390x-latest.xml | 34 + ...chine-aeskeywrap-off-caps.s390x-latest.xml | 34 + ...machine-aeskeywrap-on-cap.s390x-latest.xml | 34 + ...achine-aeskeywrap-on-caps.s390x-latest.xml | 34 + .../machine-aliases1.x86_64-latest.xml | 40 + .../machine-aliases2.x86_64-latest.xml | 40 + ...achine-deakeywrap-off-cap.s390x-latest.xml | 34 + ...chine-deakeywrap-off-caps.s390x-latest.xml | 34 + ...machine-deakeywrap-on-cap.s390x-latest.xml | 34 + ...achine-deakeywrap-on-caps.s390x-latest.xml | 34 + ...machine-keywrap-none-caps.s390x-latest.xml | 31 + .../machine-keywrap-none.s390x-latest.xml | 31 + ...machine-loadparm-net-s390.s390x-latest.xml | 32 + .../machine-loadparm-s390.s390x-latest.xml | 33 + .../machine-vmport-opt.x86_64-latest.xml | 43 + .../memory-align-fail.x86_64-latest.xml | 39 + ...mory-hotplug-nvdimm-align.x86_64-5.2.0.xml | 60 + ...mory-hotplug-nvdimm-label.x86_64-5.2.0.xml | 62 + ...emory-hotplug-nvdimm-pmem.x86_64-5.2.0.xml | 60 + ...y-hotplug-nvdimm-readonly.x86_64-5.2.0.xml | 60 + ...emory-hotplug-virtio-pmem.x86_64-5.2.0.xml | 55 + .../migrate-numa-unaligned.x86_64-latest.xml | 41 + .../misc-no-reboot.x86_64-5.2.0.xml | 38 + .../mlock-off.x86_64-latest.xml | 29 + .../mlock-on.x86_64-latest.xml | 32 + ...multifunction-pci-device.x86_64-latest.xml | 64 + .../name-escape.x86_64-latest.xml | 95 ++ .../net-client.x86_64-latest.xml | 46 + .../net-eth-names.x86_64-latest.xml | 52 + .../net-hostdev-fail.x86_64-latest.xml | 49 + .../net-hostdev-multidomain.x86_64-latest.xml | 54 + ...hostdev-vfio-multidomain.x86_64-latest.xml | 54 + .../net-mcast.x86_64-latest.xml | 46 + .../net-user-passt.x86_64-7.2.0.xml | 61 + .../net-vhostuser-fail.x86_64-latest.xml | 46 + .../net-vhostuser-multiq.x86_64-latest.xml | 73 ++ .../net-virtio-ccw.s390x-latest.xml | 37 + .../net-virtio-netdev.x86_64-latest.xml | 45 + ...uto-vcpu-static-numatune.x86_64-latest.xml | 44 + ...-static-memory-auto-vcpu.x86_64-latest.xml | 44 + .../numad.x86_64-latest.xml | 44 + ...une-auto-nodeset-invalid.x86_64-latest.xml | 44 + ...-unavailable-restrictive.x86_64-latest.xml | 30 + ...mnode-unavailable-strict.x86_64-latest.xml | 30 + .../numatune-memnode.x86_64-5.2.0.xml | 41 + ...-nodeset-exceed-hostnode.x86_64-latest.xml | 48 + .../numatune-system-memory.x86_64-latest.xml | 32 + ...parallel-parport-chardev.x86_64-latest.xml | 44 + .../parallel-tcp-chardev.x86_64-latest.xml | 45 + .../parallel-unix-chardev.x86_64-latest.xml | 42 + .../qemuxml2xmloutdata/ppc-dtb.ppc-latest.xml | 36 + ...-usb-controller-qemu-xhci.ppc64-latest.xml | 38 + .../ppce500-serial.ppc-latest.xml | 35 + .../pseries-basic.ppc64-latest.xml | 41 + .../pseries-cpu-le.ppc64-latest.xml | 41 + .../pseries-features.ppc64-4.2.0.xml | 40 + .../pseries-usb-default.ppc64-latest.xml | 41 + .../pseries-usb-kbd.ppc64-latest.xml | 42 + .../pseries-usb-multi.ppc64-latest.xml | 44 + ...pseries-vio-user-assigned.ppc64-latest.xml | 59 + .../pseries-vio.ppc64-latest.xml | 59 + .../q35-default-devices-only.x86_64-4.2.0.xml | 50 + .../q35-multifunction.x86_64-4.2.0.xml | 125 ++ .../q35-pcie-autoadd.x86_64-4.2.0.xml | 154 +++ .../q35-pcie.x86_64-4.2.0.xml | 158 +++ .../q35-virt-manager-basic.x86_64-4.2.0.xml | 128 ++ .../qemu-ns-alt.x86_64-latest.xml | 46 + .../qemu-ns-commandline-ns0.x86_64-latest.xml | 43 + .../qemu-ns-commandline-ns1.x86_64-latest.xml | 43 + .../qemu-ns-commandline.x86_64-latest.xml | 43 + ...s-domain-commandline-ns0.x86_64-latest.xml | 43 + ...mu-ns-domain-commandline.x86_64-latest.xml | 43 + .../qemu-ns-domain-ns0.x86_64-latest.xml | 43 + .../restore-v2-fd.x86_64-latest.xml | 40 + .../riscv64-virt.riscv64-latest.xml | 20 +- ...llow-bogus-usb-controller.s390x-latest.xml | 48 + ...s390-allow-bogus-usb-none.s390x-latest.xml | 44 + ...label-dynamic-baselabel.x86_64-latest.xml} | 0 ...label-dynamic-labelskip.x86_64-latest.xml} | 0 ...el-dynamic-none-relabel.x86_64-latest.xml} | 0 ...clabel-dynamic-override.x86_64-latest.xml} | 0 ...eclabel-dynamic-relabel.x86_64-latest.xml} | 0 .../seclabel-dynamic.x86_64-latest.xml | 41 + ...clabel-static-labelskip.x86_64-latest.xml} | 0 .../seclabel-static-relabel.x86_64-latest.xml | 43 + ...erial-dev-chardev-iobase.x86_64-latest.xml | 52 + .../serial-dev-chardev.x86_64-latest.xml | 50 + .../serial-file-chardev.x86_64-latest.xml | 50 + .../serial-file-log.x86_64-latest.xml | 50 + .../serial-many-chardev.x86_64-latest.xml | 54 + .../serial-pty-chardev.x86_64-latest.xml | 48 + .../serial-tcp-chardev.x86_64-latest.xml | 52 + ...erial-tcp-telnet-chardev.x86_64-latest.xml | 52 + ...p-tlsx509-chardev-verify.x86_64-latest.xml | 59 + ...p-tlsx509-secret-chardev.x86_64-latest.xml | 59 + .../serial-udp-chardev.x86_64-latest.xml | 58 + .../serial-unix-chardev.x86_64-latest.xml | 50 + .../serial-vc-chardev.x86_64-latest.xml | 48 + .../shmem-invalid-address.x86_64-latest.xml | 34 + .../shmem-invalid-size.x86_64-latest.xml | 34 + .../shmem-small-size.x86_64-latest.xml | 34 + ...artcard-passthrough-unix.x86_64-latest.xml | 36 + .../sound-device.x86_64-4.2.0.xml | 61 + .../sparc-minimal.sparc-latest.xml | 33 + .../usb-bus-missing.x86_64-latest.xml | 37 + ...-default-unavailable-q35.x86_64-latest.xml | 33 + ...ntroller-ich9-autoassign.x86_64-latest.xml | 48 + ...ontroller-ich9-companion.x86_64-latest.xml | 43 + ...ler-nec-xhci-unavailable.x86_64-latest.xml | 33 + ...ller-nex-xhci-autoassign.x86_64-latest.xml | 34 + ...usb-controller-qemu-xhci.x86_64-latest.xml | 29 + .../usb-hub-autoadd-deluxe.x86_64-latest.xml | 47 + .../usb-hub-autoadd.x86_64-latest.xml | 35 + .../usb-hub.x86_64-latest.xml | 34 + .../usb-long-port-path.x86_64-latest.xml | 43 + .../usb-port-autoassign.x86_64-latest.xml | 38 + .../usb-ports.x86_64-latest.xml | 46 + .../usb-redir-boot.x86_64-latest.xml | 58 + .../usb-redir-unix.x86_64-latest.xml | 49 + .../usb1-usb2.x86_64-latest.xml | 79 ++ .../user-aliases-usb.x86_64-latest.xml | 88 ++ .../user-aliases2.x86_64-latest.xml | 52 + ...vhost-user-gpu-secondary.x86_64-latest.xml | 57 + .../vhost-user-vga.x86_64-latest.xml | 52 + ...deo-bochs-display-device.x86_64-latest.xml | 44 + .../video-qxl-device-vgamem.x86_64-latest.xml | 44 + .../video-qxl-device-vram64.x86_64-latest.xml | 38 + .../video-qxl-device.x86_64-latest.xml | 44 + ...eo-qxl-sec-device-vgamem.x86_64-latest.xml | 48 + ...eo-qxl-sec-device-vram64.x86_64-latest.xml | 42 + .../video-qxl-sec-device.x86_64-latest.xml | 48 + ...deo-ramfb-display-device.x86_64-latest.xml | 43 + .../video-vga-device-vgamem.x86_64-latest.xml | 44 + .../video-vga-device.x86_64-latest.xml | 44 + .../video-vga-qxl-heads.x86_64-latest.xml | 52 + .../video-virtio-vga.x86_64-latest.xml | 44 + ...o-options-controller-ats.x86_64-latest.xml | 47 + ...options-controller-iommu.x86_64-latest.xml | 47 + ...ptions-controller-packed.x86_64-latest.xml | 47 + .../virtio-options-disk-ats.x86_64-latest.xml | 43 + ...irtio-options-disk-iommu.x86_64-latest.xml | 43 + ...rtio-options-disk-packed.x86_64-latest.xml | 43 + .../virtio-options-fs-ats.x86_64-latest.xml | 43 + .../virtio-options-fs-iommu.x86_64-latest.xml | 43 + ...virtio-options-fs-packed.x86_64-latest.xml | 43 + ...virtio-options-input-ats.x86_64-latest.xml | 39 + ...rtio-options-input-iommu.x86_64-latest.xml | 39 + ...tio-options-input-packed.x86_64-latest.xml | 39 + ...o-options-memballoon-ats.x86_64-latest.xml | 32 + ...lloon-freepage-reporting.x86_64-latest.xml | 31 + ...options-memballoon-iommu.x86_64-latest.xml | 32 + ...ptions-memballoon-packed.x86_64-latest.xml | 32 + .../virtio-options-net-ats.x86_64-latest.xml | 43 + ...virtio-options-net-iommu.x86_64-latest.xml | 43 + ...irtio-options-net-packed.x86_64-latest.xml | 43 + .../virtio-options-rng-ats.x86_64-latest.xml | 41 + ...virtio-options-rng-iommu.x86_64-latest.xml | 41 + ...irtio-options-rng-packed.x86_64-latest.xml | 41 + ...virtio-options-video-ats.x86_64-latest.xml | 45 + ...rtio-options-video-iommu.x86_64-latest.xml | 45 + ...tio-options-video-packed.x86_64-latest.xml | 45 + .../virtio-rng-builtin.x86_64-5.2.0.xml | 35 + .../virtio-rng-ccw.s390x-latest.xml | 43 + .../virtio-rng-default.x86_64-latest.xml | 35 + .../virtio-rng-egd-unix.x86_64-5.2.0.xml | 37 + .../virtio-rng-egd-unix.x86_64-latest.xml | 37 + .../virtio-rng-multiple.x86_64-latest.xml | 42 + .../watchdog-device.x86_64-latest.xml | 43 + .../watchdog-diag288.s390x-latest.xml | 34 + .../watchdog-dump.x86_64-latest.xml | 41 + .../watchdog-injectnmi.x86_64-latest.xml | 41 + tests/qemuxml2xmltest.c | 1040 ----------------- ...-unix-source-path-active.x86_64-latest.xml | 62 + ...ix-source-path-inactive.x86_64-latest.xml} | 0 ...nnel-virtio-state-active.x86_64-latest.xml | 0 ...el-virtio-state-inactive.x86_64-latest.xml | 55 + ...isk-active-commit-active.x86_64-latest.xml | 0 ...k-active-commit-inactive.x86_64-latest.xml | 45 + ...king-chains-index-active.x86_64-latest.xml | 164 +++ ...g-chains-index-inactive.x86_64-latest.xml} | 0 .../disk-mirror-active.x86_64-latest.xml | 0 .../disk-mirror-inactive.x86_64-latest.xml | 70 ++ .../disk-mirror-old-active.x86_64-latest.xml | 0 ...disk-mirror-old-inactive.x86_64-latest.xml | 63 + .../genid-active.x86_64-latest.xml | 0 .../genid-auto-active.x86_64-latest.xml | 0 .../genid-auto-inactive.x86_64-latest.xml | 36 + .../genid-inactive.x86_64-latest.xml | 36 + ...-generated-socket-active.x86_64-latest.xml | 45 + ...nerated-socket-inactive.x86_64-latest.xml} | 0 ...-static-labelskip-active.x86_64-latest.xml | 0 ...tatic-labelskip-inactive.x86_64-latest.xml | 45 + tests/qemuxmlactivetest.c | 260 +++++ .../{qemuxml2argvtest.c => qemuxmlconftest.c} | 309 +++-- tests/testutils.c | 9 +- tests/testutilsqemu.c | 17 +- tests/testutilsqemu.h | 26 +- tests/virschematest.c | 43 +- 452 files changed, 18725 insertions(+), 1358 deletions(-) delete mode 100644 tests/qemustatusxml2xmltest.c create mode 100644 tests/qemuxml2xmloutdata/aarch64-cpu-passthrough.aarch64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/aarch64-features-wrong.aarch64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/aarch64-gic-default.aarch64-4.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/aarch64-gic-none.aarch64-4.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/aarch64-kvm-32-on-64.aarch64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/aarch64-virt-default-nic.aarch64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/aarch64-virt-virtio-MMIO.aarch64.latest.xml create mode 100644 tests/qemuxml2xmloutdata/aarch64-virt-virtio.aarch64-4.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/aarch64-virt-virtio.aarch64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/aarch64-virtio-pci-default.aarch64-4.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/arm-vexpressa9-basic.aarch64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/arm-vexpressa9-nodevs.aarch64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/arm-vexpressa9-virtio.aarch64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/arm-virt-virtio.aarch64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/audio-default-sdl.x86_64-4.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/audio-default-spice.x86_64-4.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/audio-default-vnc.x86_64-4.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/audio-jack-minimal.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/balloon-ccw-deflate.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/balloon-device-deflate-off.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/balloon-device-deflate.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/balloon-device.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/balloon-mmio-deflate.aarch64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/boot-complex.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/boot-menu-disable-drive.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/boot-menu-enable.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/channel-spicevmc.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/channel-unix-guestfwd.x86_64-latest.xml rename tests/qemuxml2xmloutdata/{channel-unix-source-path-inactive.x86_64-latest.xml => channel-unix-source-path.x86_64-latest.xml} (100%) create mode 100644 tests/qemuxml2xmloutdata/channel-virtio-autoadd.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/channel-virtio-autoassign.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/channel-virtio-default.x86_64-latest.xml rename tests/qemuxml2xmloutdata/{channel-virtio-state-inactive.x86_64-latest.xml => channel-virtio-state.x86_64-latest.xml} (100%) create mode 100644 tests/qemuxml2xmloutdata/channel-virtio-unix.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/chardev-reconnect.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/clock-france.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/clock-hpet-off.x86_64-7.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/clock-hpet-off.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/clock-localtime-basis-localtime.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/clock-variable.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/console-compat-chardev.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/console-sclp.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/console-virtio-ccw.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/console-virtio-unix.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/controller-order.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-Haswell-noTSX.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-Haswell.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-Haswell2.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-Haswell3.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-cache-disable.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-cache-disable3.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-cache-emulate-l3.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-cache-passthrough.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-exact1.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-exact2-nofallback.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-exact2.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-fallback.x86_64-5.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-fallback.x86_64-8.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-cmt.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-fallback-kvm.x86_64-4.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-fallback-kvm.x86_64-5.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-fallback-kvm.x86_64-5.1.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-fallback-kvm.x86_64-5.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-fallback-kvm.x86_64-6.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-fallback-kvm.x86_64-6.1.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-fallback-kvm.x86_64-6.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-fallback-kvm.x86_64-7.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-fallback-kvm.x86_64-7.1.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-fallback-kvm.x86_64-7.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-fallback-kvm.x86_64-8.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-fallback-kvm.x86_64-8.1.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-fallback-kvm.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-fallback-tcg.x86_64-4.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-fallback-tcg.x86_64-5.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-fallback-tcg.x86_64-5.1.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-fallback-tcg.x86_64-5.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-fallback-tcg.x86_64-6.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-fallback-tcg.x86_64-6.1.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-fallback-tcg.x86_64-6.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-fallback-tcg.x86_64-7.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-fallback-tcg.x86_64-7.1.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-fallback-tcg.x86_64-7.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-fallback-tcg.x86_64-8.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-fallback-tcg.x86_64-8.1.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-fallback-tcg.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-kvm.x86_64-4.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-kvm.x86_64-5.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-kvm.x86_64-5.1.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-kvm.x86_64-5.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-kvm.x86_64-6.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-kvm.x86_64-6.1.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-kvm.x86_64-6.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-kvm.x86_64-7.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-kvm.x86_64-7.1.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-kvm.x86_64-7.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-kvm.x86_64-8.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-kvm.x86_64-8.1.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-kvm.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-nofallback-kvm.x86_64-4.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-nofallback-kvm.x86_64-5.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-nofallback-kvm.x86_64-5.1.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-nofallback-kvm.x86_64-5.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-nofallback-kvm.x86_64-6.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-nofallback-kvm.x86_64-6.1.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-nofallback-kvm.x86_64-6.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-nofallback-kvm.x86_64-7.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-nofallback-kvm.x86_64-7.1.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-nofallback-kvm.x86_64-7.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-nofallback-kvm.x86_64-8.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-nofallback-kvm.x86_64-8.1.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-nofallback-kvm.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-nofallback-tcg.x86_64-4.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-nofallback-tcg.x86_64-5.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-nofallback-tcg.x86_64-5.1.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-nofallback-tcg.x86_64-5.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-nofallback-tcg.x86_64-6.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-nofallback-tcg.x86_64-6.1.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-nofallback-tcg.x86_64-6.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-nofallback-tcg.x86_64-7.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-nofallback-tcg.x86_64-7.1.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-nofallback-tcg.x86_64-7.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-nofallback-tcg.x86_64-8.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-nofallback-tcg.x86_64-8.1.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-nofallback-tcg.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-tcg.x86_64-4.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-tcg.x86_64-5.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-tcg.x86_64-5.1.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-tcg.x86_64-5.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-tcg.x86_64-6.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-tcg.x86_64-6.1.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-tcg.x86_64-6.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-tcg.x86_64-7.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-tcg.x86_64-7.1.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-tcg.x86_64-7.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-tcg.x86_64-8.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-tcg.x86_64-8.1.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-model-tcg.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-host-passthrough.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-hotplug-startup.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-minimum1.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-minimum2.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-no-removed-features.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-nofallback.x86_64-5.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-nofallback.x86_64-8.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-phys-bits-emulate.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-phys-bits-emulate2.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-phys-bits-passthrough.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-qemu-host-passthrough.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-s390-features.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-s390-zEC12.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-strict1.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-topology1.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-topology2.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-topology3.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-topology4.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-translation.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-tsc-frequency.x86_64-latest.xml rename tests/qemuxml2xmloutdata/{disk-active-commit-inactive.x86_64-latest.xml => disk-active-commit.x86_64-latest.xml} (100%) rename tests/qemuxml2xmloutdata/{disk-backing-chains-index-inactive.x86_64-latest.xml => disk-backing-chains-index.x86_64-latest.xml} (100%) delete mode 120000 tests/qemuxml2xmloutdata/disk-cdrom-empty-network-invalid-inactive.x86_64-latest.xml rename tests/qemuxml2xmloutdata/{disk-cdrom-empty-network-invalid-active.x86_64-latest.xml => disk-cdrom-empty-network-invalid.x86_64-latest.xml} (100%) create mode 100644 tests/qemuxml2xmloutdata/disk-cdrom-network-nbdkit.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-cdrom-tray.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-device-removable.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-error-policy-s390x.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-floppy-pseries.ppc64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-floppy-q35.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-floppy-tray.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-geometry.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-ide-split.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-ide-wwn.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-ioeventfd.x86_64-latest.xml rename tests/qemuxml2xmloutdata/{disk-mirror-old-inactive.x86_64-latest.xml => disk-mirror-old.x86_64-latest.xml} (100%) rename tests/qemuxml2xmloutdata/{disk-mirror-inactive.x86_64-latest.xml => disk-mirror.x86_64-latest.xml} (100%) create mode 100644 tests/qemuxml2xmloutdata/disk-network-http-nbdkit.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-network-rbd-no-colon.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-network-sheepdog.x86_64-6.0.0.xml rename tests/qemuxml2xmloutdata/{disk-network-nfs-inactive.x86_64-latest.xml => disk-network-source-curl-nbdkit-backing.x86_64-latest.xml} (64%) create mode 100644 tests/qemuxml2xmloutdata/disk-network-source-curl-nbdkit.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-network-source-curl.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-network-ssh-key.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-network-ssh-nbdkit.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-network-ssh-password.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-network-ssh.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-network-tlsx509-nbd.x86_64-5.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/disk-no-boot.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-order.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-readonly-disk.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-scsi-disk-split.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-scsi-disk-wwn.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-scsi-lun-passthrough.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-shared.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-snapshot.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-vhostuser-numa.x86_64-4.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/disk-vhostuser-numa.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-vhostvdpa.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-virtio-ccw-many.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-virtio-ccw.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/disk-virtio-scsi-reservations.x86_64-5.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/fips-enabled.x86_64-5.1.0.xml create mode 100644 tests/qemuxml2xmloutdata/fips-enabled.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/fs9p-ccw.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/fs9p.x86_64-latest.xml rename tests/qemuxml2xmloutdata/{genid-auto-inactive.x86_64-latest.xml => genid-auto.x86_64-latest.xml} (100%) rename tests/qemuxml2xmloutdata/{genid-inactive.x86_64-latest.xml => genid.x86_64-latest.xml} (100%) create mode 100644 tests/qemuxml2xmloutdata/graphics-dbus-usbredir.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/graphics-egl-headless.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/graphics-spice-agent-file-xfer.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/graphics-spice-agentmouse.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/graphics-spice-gl-auto-rendernode.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/graphics-spice-no-args.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/graphics-spice-sasl.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/graphics-spice-usb-redir.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/graphics-vnc-none.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/graphics-vnc-policy.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/graphics-vnc-power.x86_64-latest.xml rename tests/qemuxml2xmloutdata/{graphics-vnc-remove-generated-socket-inactive.x86_64-latest.xml => graphics-vnc-remove-generated-socket.x86_64-latest.xml} (100%) create mode 100644 tests/qemuxml2xmloutdata/graphics-vnc-socket-new-cmdline.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/graphics-vnc-tls-secret.x86_64-5.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/graphics-vnc-tls-secret.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-mdev-display-spice-egl-headless.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-mdev-display-spice-opengl.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-mdev-display-vnc-egl-headless.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-mdev-display-vnc.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-pci-address-device.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-scsi-vhost-scsi-pcie.x86_64-4.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-usb-address-device-boot.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-usb-address-device.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-vfio-multidomain.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/hotplug-base.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/hugepages-default-5M.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/hugepages-numa-default.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/hyperv-passthrough.x86_64-6.1.0.xml create mode 100644 tests/qemuxml2xmloutdata/input-usbmouse-addr.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/iothreads-disk-virtio-ccw.s390x-4.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/iothreads-virtio-scsi-pci.x86_64-5.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/kvm-pit-delay.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/kvm-pit-discard.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/kvmclock+eoi-disabled.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/launch-security-s390-pv.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/launch-security-sev-direct.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/launch-security-sev-missing-platform-info.x86_64-6.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/launch-security-sev.x86_64-6.0.0.xml create mode 100644 tests/qemuxml2xmloutdata/luks-disks-source-qcow2.x86_64-5.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/machine-aeskeywrap-off-cap.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/machine-aeskeywrap-off-caps.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/machine-aeskeywrap-on-cap.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/machine-aeskeywrap-on-caps.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/machine-aliases1.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/machine-aliases2.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/machine-deakeywrap-off-cap.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/machine-deakeywrap-off-caps.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/machine-deakeywrap-on-cap.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/machine-deakeywrap-on-caps.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/machine-keywrap-none-caps.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/machine-keywrap-none.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/machine-loadparm-net-s390.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/machine-loadparm-s390.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/machine-vmport-opt.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/memory-align-fail.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/memory-hotplug-nvdimm-align.x86_64-5.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/memory-hotplug-nvdimm-label.x86_64-5.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/memory-hotplug-nvdimm-pmem.x86_64-5.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/memory-hotplug-nvdimm-readonly.x86_64-5.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/memory-hotplug-virtio-pmem.x86_64-5.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/migrate-numa-unaligned.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/misc-no-reboot.x86_64-5.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/mlock-off.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/mlock-on.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/multifunction-pci-device.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/name-escape.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/net-client.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/net-eth-names.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/net-hostdev-fail.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/net-hostdev-multidomain.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/net-hostdev-vfio-multidomain.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/net-mcast.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/net-user-passt.x86_64-7.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/net-vhostuser-fail.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/net-vhostuser-multiq.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/net-virtio-ccw.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/net-virtio-netdev.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/numad-auto-vcpu-static-numatune.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/numad-static-memory-auto-vcpu.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/numad.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/numatune-auto-nodeset-invalid.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/numatune-memnode-unavailable-restrictive.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/numatune-memnode-unavailable-strict.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/numatune-memnode.x86_64-5.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/numatune-static-nodeset-exceed-hostnode.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/numatune-system-memory.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/parallel-parport-chardev.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/parallel-tcp-chardev.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/parallel-unix-chardev.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/ppc-dtb.ppc-latest.xml create mode 100644 tests/qemuxml2xmloutdata/ppc64-usb-controller-qemu-xhci.ppc64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/ppce500-serial.ppc-latest.xml create mode 100644 tests/qemuxml2xmloutdata/pseries-basic.ppc64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/pseries-cpu-le.ppc64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/pseries-features.ppc64-4.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/pseries-usb-default.ppc64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/pseries-usb-kbd.ppc64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/pseries-usb-multi.ppc64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/pseries-vio-user-assigned.ppc64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/pseries-vio.ppc64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/q35-default-devices-only.x86_64-4.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/q35-multifunction.x86_64-4.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/q35-pcie-autoadd.x86_64-4.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/q35-pcie.x86_64-4.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/q35-virt-manager-basic.x86_64-4.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/qemu-ns-alt.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/qemu-ns-commandline-ns0.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/qemu-ns-commandline-ns1.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/qemu-ns-commandline.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/qemu-ns-domain-commandline-ns0.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/qemu-ns-domain-commandline.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/qemu-ns-domain-ns0.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/restore-v2-fd.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/s390-allow-bogus-usb-controller.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/s390-allow-bogus-usb-none.s390x-latest.xml rename tests/qemuxml2xmloutdata/{seclabel-dynamic-baselabel-inactive.x86_64-latest.xml => seclabel-dynamic-baselabel.x86_64-latest.xml} (100%) rename tests/qemuxml2xmloutdata/{seclabel-dynamic-labelskip-inactive.x86_64-latest.xml => seclabel-dynamic-labelskip.x86_64-latest.xml} (100%) rename tests/qemuxml2xmloutdata/{seclabel-dynamic-none-relabel-inactive.x86_64-latest.xml => seclabel-dynamic-none-relabel.x86_64-latest.xml} (100%) rename tests/qemuxml2xmloutdata/{seclabel-dynamic-override-inactive.x86_64-latest.xml => seclabel-dynamic-override.x86_64-latest.xml} (100%) rename tests/qemuxml2xmloutdata/{seclabel-dynamic-relabel-inactive.x86_64-latest.xml => seclabel-dynamic-relabel.x86_64-latest.xml} (100%) create mode 100644 tests/qemuxml2xmloutdata/seclabel-dynamic.x86_64-latest.xml rename tests/qemuxml2xmloutdata/{seclabel-static-labelskip-inactive.x86_64-latest.xml => seclabel-static-labelskip.x86_64-latest.xml} (100%) create mode 100644 tests/qemuxml2xmloutdata/seclabel-static-relabel.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/serial-dev-chardev-iobase.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/serial-dev-chardev.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/serial-file-chardev.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/serial-file-log.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/serial-many-chardev.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/serial-pty-chardev.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/serial-tcp-chardev.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/serial-tcp-telnet-chardev.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/serial-tcp-tlsx509-chardev-verify.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/serial-tcp-tlsx509-secret-chardev.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/serial-udp-chardev.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/serial-unix-chardev.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/serial-vc-chardev.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/shmem-invalid-address.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/shmem-invalid-size.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/shmem-small-size.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/smartcard-passthrough-unix.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/sound-device.x86_64-4.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/sparc-minimal.sparc-latest.xml create mode 100644 tests/qemuxml2xmloutdata/usb-bus-missing.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/usb-controller-default-unavailable-q35.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/usb-controller-ich9-autoassign.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/usb-controller-ich9-companion.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/usb-controller-nec-xhci-unavailable.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/usb-controller-nex-xhci-autoassign.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/usb-controller-qemu-xhci.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/usb-hub-autoadd-deluxe.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/usb-hub-autoadd.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/usb-hub.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/usb-long-port-path.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/usb-port-autoassign.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/usb-ports.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/usb-redir-boot.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/usb-redir-unix.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/usb1-usb2.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/user-aliases-usb.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/user-aliases2.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/vhost-user-gpu-secondary.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/vhost-user-vga.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/video-bochs-display-device.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/video-qxl-device-vgamem.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/video-qxl-device-vram64.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/video-qxl-device.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/video-qxl-sec-device-vgamem.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/video-qxl-sec-device-vram64.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/video-qxl-sec-device.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/video-ramfb-display-device.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/video-vga-device-vgamem.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/video-vga-device.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/video-vga-qxl-heads.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/video-virtio-vga.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-options-controller-ats.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-options-controller-iommu.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-options-controller-packed.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-options-disk-ats.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-options-disk-iommu.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-options-disk-packed.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-options-fs-ats.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-options-fs-iommu.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-options-fs-packed.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-options-input-ats.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-options-input-iommu.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-options-input-packed.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-options-memballoon-ats.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-options-memballoon-freepage-reporting.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-options-memballoon-iommu.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-options-memballoon-packed.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-options-net-ats.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-options-net-iommu.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-options-net-packed.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-options-rng-ats.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-options-rng-iommu.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-options-rng-packed.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-options-video-ats.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-options-video-iommu.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-options-video-packed.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-rng-builtin.x86_64-5.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-rng-ccw.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-rng-default.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-rng-egd-unix.x86_64-5.2.0.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-rng-egd-unix.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-rng-multiple.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/watchdog-device.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/watchdog-diag288.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/watchdog-dump.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/watchdog-injectnmi.x86_64-latest.xml delete mode 100644 tests/qemuxml2xmltest.c create mode 100644 tests/qemuxmlactive2xmldata/channel-unix-source-path-active.x86_64-latest.xml rename tests/{qemuxml2xmloutdata/channel-unix-source-path-active.x86_64-latest.xml => qemuxmlactive2xmldata/channel-unix-source-path-inactive.x86_64-latest.xml} (100%) rename tests/{qemuxml2xmloutdata => qemuxmlactive2xmldata}/channel-virtio-state-active.x86_64-latest.xml (100%) create mode 100644 tests/qemuxmlactive2xmldata/channel-virtio-state-inactive.x86_64-latest.xml rename tests/{qemuxml2xmloutdata => qemuxmlactive2xmldata}/disk-active-commit-active.x86_64-latest.xml (100%) create mode 100644 tests/qemuxmlactive2xmldata/disk-active-commit-inactive.x86_64-latest.xml create mode 100644 tests/qemuxmlactive2xmldata/disk-backing-chains-index-active.x86_64-latest.xml rename tests/{qemuxml2xmloutdata/disk-backing-chains-index-active.x86_64-latest.xml => qemuxmlactive2xmldata/disk-backing-chains-index-inactive.x86_64-latest.xml} (100%) rename tests/{qemuxml2xmloutdata => qemuxmlactive2xmldata}/disk-mirror-active.x86_64-latest.xml (100%) create mode 100644 tests/qemuxmlactive2xmldata/disk-mirror-inactive.x86_64-latest.xml rename tests/{qemuxml2xmloutdata => qemuxmlactive2xmldata}/disk-mirror-old-active.x86_64-latest.xml (100%) create mode 100644 tests/qemuxmlactive2xmldata/disk-mirror-old-inactive.x86_64-latest.xml rename tests/{qemuxml2xmloutdata => qemuxmlactive2xmldata}/genid-active.x86_64-latest.xml (100%) rename tests/{qemuxml2xmloutdata => qemuxmlactive2xmldata}/genid-auto-active.x86_64-latest.xml (100%) create mode 100644 tests/qemuxmlactive2xmldata/genid-auto-inactive.x86_64-latest.xml create mode 100644 tests/qemuxmlactive2xmldata/genid-inactive.x86_64-latest.xml create mode 100644 tests/qemuxmlactive2xmldata/graphics-vnc-remove-generated-socket-active.x86_64-latest.xml rename tests/{qemuxml2xmloutdata/graphics-vnc-remove-generated-socket-active.x86_64-latest.xml => qemuxmlactive2xmldata/graphics-vnc-remove-generated-socket-inactive.x86_64-latest.xml} (100%) rename tests/{qemuxml2xmloutdata => qemuxmlactive2xmldata}/seclabel-static-labelskip-active.x86_64-latest.xml (100%) create mode 100644 tests/qemuxmlactive2xmldata/seclabel-static-labelskip-inactive.x86_64-latest.xml create mode 100644 tests/qemuxmlactivetest.c rename tests/{qemuxml2argvtest.c => qemuxmlconftest.c} (95%) -- 2.43.0

2 25

build failure on ppc64le
by Jim Fehlig 17 Jan '24

17 Jan '24

Hi All, We recently started noticing build failures of libvirt for ppc64le on some distros in our build service. Seems it's possible for sources in remote to be built before remote_protocol.h is generated [ 178s] cc -Isrc/virtnodedevd.p -Isrc -I../src -Isrc/conf -I../src/conf -Isrc/remote -I../src/remote -Isrc/admin -I../src/admin -Isrc/access -I../src/access -Isrc/rpc -I../src/rpc -Isrc/util -I../src/util -Iinclude -I../include -I. -I.. -I/usr/include/p11-kit-1 -I/usr/include/libnl3 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/gio-unix-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/libxml2 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu99 -fasynchronous-unwind-tables -fexceptions -fipa-pure-const -fno-common -Waddress -Waggressive-loop-optimizations -Walloc-size-larger-than=9223372036854775807 -Walloca -Warray-bounds=2 -Wattributes -Wbool-compare -Wbool-operation -Wbuiltin-declaration-mismatch -Wbuiltin-macro-redefined -Wcast-align -Wchar-subscripts -Wclobbered -Wcomment -Wcomments -Wcoverage-mismatch -Wcpp -Wdangling-else -Wdate-time -Wdeclaration-after-statement -Wdeprecated-declarations -Wdesignated-init -Wdiscarded-array-qualifiers -Wdiscarded-qualifiers -Wdiv-by-zero -Wduplicated-cond -Wduplicate-decl-specifier -Wempty-body -Wendif-labels -Wexpansion-to-defined -Wformat-contains-nul -Wformat-extra-args -Wno-format-nonliteral -Wformat-overflow=2 -Wformat-security -Wno-format-truncation -Wformat-y2k -Wformat-zero-length -Wframe-address -Wframe-larger-than=2048 -Wfree-nonheap-object -Whsa -Wignored-attributes -Wignored-qualifiers -Wimplicit -Wimplicit-fallthrough=5 -Wimplicit-function-declaration -Wimplicit-int -Wincompatible-pointer-types -Winit-self -Winline -Wint-conversion -Wint-in-bool-context -Wint-to-pointer-cast -Winvalid-memory-model -Winvalid-pch -Wjump-misses-init -Wlogical-not-parentheses -Wlogical-op -Wmain -Wmaybe-uninitialized -Wmemset-elt-size -Wmemset-transposed-args -Wmisleading-indentation -Wmissing-braces -Wmissing-declarations -Wmissing-field-initializers -Wmissing-include-dirs -Wmissing-parameter-type -Wmissing-prototypes -Wmultichar -Wnarrowing -Wnested-externs -Wnonnull -Wnonnull-compare -Wnormalized=nfc -Wnull-dereference -Wodr -Wold-style-declaration -Wold-style-definition -Wopenmp-simd -Woverflow -Woverride-init -Wpacked-bitfield-compat -Wparentheses -Wpointer-arith -Wpointer-compare -Wpointer-sign -Wpointer-to-int-cast -Wpragmas -Wpsabi -Wrestrict -Wreturn-local-addr -Wreturn-type -Wscalar-storage-order -Wsequence-point -Wshadow -Wshift-count-negative -Wshift-count-overflow -Wshift-negative-value -Wshift-overflow=2 -Wno-sign-compare -Wsizeof-array-argument -Wsizeof-pointer-memaccess -Wstrict-aliasing -Wstrict-prototypes -Wstringop-overflow=2 -Wno-suggest-attribute=const -Wsuggest-attribute=format -Wsuggest-attribute=noreturn -Wno-suggest-attribute=pure -Wsuggest-final-methods -Wsuggest-final-types -Wswitch -Wswitch-bool -Wswitch-enum -Wswitch-unreachable -Wsync-nand -Wtautological-compare -Wtrampolines -Wtrigraphs -Wtype-limits -Wuninitialized -Wunknown-pragmas -Wunused -Wunused-but-set-parameter -Wunused-but-set-variable -Wunused-const-variable=2 -Wunused-function -Wunused-label -Wunused-local-typedefs -Wunused-parameter -Wunused-result -Wunused-value -Wunused-variable -Wvarargs -Wvariadic-macros -Wvector-operation-performance -Wvla -Wvolatile-register-var -Wwrite-strings -fstack-protector-strong -Wdouble-promotion -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -g -fPIE -pthread -DIN_LIBVIRT '-Dabs_top_builddir="/home/abuild/rpmbuild/BUILD/libvirt-9.10.0/ppc64le-suse-linux"' '-Dabs_top_srcdir="/home/abuild/rpmbuild/BUILD/libvirt-9.10.0"' '-DDAEMON_NAME="virtnodedevd"' '-DMODULE_NAME="nodedev"' -MD -MQ src/virtnodedevd.p/remote_remote_daemon_config.c.o -MF src/virtnodedevd.p/remote_remote_daemon_config.c.o.d -o src/virtnodedevd.p/remote_remote_daemon_config.c.o -c ../src/remote/remote_daemon_config.c [ 178s] ../src/remote/remote_daemon_config.c: In function ‘daemonConfigNew’: [ 178s] ../src/remote/remote_daemon_config.c:111:30: error: ‘REMOTE_AUTH_POLKIT’ undeclared (first use in this function); did you mean ‘WITH_POLKIT’? [ 178s] data->auth_unix_rw = REMOTE_AUTH_POLKIT; [ 178s] ^~~~~~~~~~~~~~~~~~ [ 178s] WITH_POLKIT [ 178s] ../src/remote/remote_daemon_config.c:111:30: note: each undeclared identifier is reported only once for each function it appears in [ 178s] ../src/remote/remote_daemon_config.c:115:30: error: ‘REMOTE_AUTH_NONE’ undeclared (first use in this function); did you mean ‘REMOTE_AUTH_POLKIT’? [ 178s] data->auth_unix_rw = REMOTE_AUTH_NONE; [ 178s] ^~~~~~~~~~~~~~~~ [ 178s] REMOTE_AUTH_POLKIT [ 178s] ../src/remote/remote_daemon_config.c: In function ‘daemonConfigLoadOptions’: [ 178s] ../src/remote/remote_daemon_config.c:252:31: error: ‘REMOTE_AUTH_POLKIT’ undeclared (first use in this function); did you mean ‘WITH_POLKIT’? [ 178s] if (data->auth_unix_rw == REMOTE_AUTH_POLKIT) { [ 178s] ^~~~~~~~~~~~~~~~~~ [ 178s] WITH_POLKIT [ 178s] [263/1422] /usr/bin/meson --internal exe --capture src/admin/admin_server_dispatch_stubs.h -- /home/abuild/rpmbuild/BUILD/libvirt-9.10.0/src/rpc/gendispatch.pl --mode=server admin ADMIN ../src/admin/admin_protocol.x [ 179s] [264/1422] /home/abuild/rpmbuild/BUILD/libvirt-9.10.0/scripts/meson-python.sh /usr/bin/python3 /home/abuild/rpmbuild/BUILD/libvirt-9.10.0/scripts/rpcgen/main.py --mode=header ../src/remote/remote_protocol.x src/remote/remote_protocol.h Full build log of one failure case can be found here https://build.opensuse.org/build/Virtualization/15.6/ppc64le/libvirt/_log The below patch fixes the issue in our testing, but I'm not sure if it's the best solution, versus e.g. a dependency along the lines of rpc_dep et. al. Thanks for comments/suggestions. Regards, Jim diff --git a/src/meson.build b/src/meson.build index 6538c43628..3f989de7f9 100644 --- a/src/meson.build +++ b/src/meson.build @@ -616,7 +616,7 @@ foreach daemon : virt_daemons bin = executable( daemon['name'], [ - daemon.get('sources', [ remote_daemon_sources, remote_daemon_generated ]), + daemon.get('sources', [ remote_daemon_sources, remote_daemon_generated, remote_driver_generated ]), dtrace_gen_objects, ], c_args: [

2 1

[PATCH] apparmor: Allow access to /sys/devices/system/node/*/cpumap for libnuma
by Sergio Durigan Junior 15 Jan '24

15 Jan '24

A QEMU change (10218ae6d006f76410804cc4dc690085b3d008b5) introduced some libnuma calls that require read access to /sys/devices/system/node/*/cpumap, which currently is forbidden by the standard apparmor profile. This commit allows read-only access to the file specified above. Closes #515 Signed-off-by: Sergio Durigan Junior <sergio.durigan(a)canonical.com> --- src/security/apparmor/libvirt-qemu.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/security/apparmor/libvirt-qemu.in b/src/security/apparmor/libvirt-qemu.in index 53f45c3a28..f40f471891 100644 --- a/src/security/apparmor/libvirt-qemu.in +++ b/src/security/apparmor/libvirt-qemu.in @@ -252,6 +252,9 @@ /sys/devices/system/node/node[0-9]*/meminfo r, /sys/module/vhost/parameters/max_mem_regions r, + # Access to libnuma + /sys/devices/system/node/*/cpumap r, + # silence refusals to open lttng files (see LP: #1432644) deny /dev/shm/lttng-ust-wait-* r, deny /run/shm/lttng-ust-wait-* r, -- 2.34.1

3 3

[PATCH v2 00/11] qemu: Add support for CPU clusters
by Andrea Bolognani 15 Jan '24

15 Jan '24

Changes from [v1] * minimize amount of newly-introduced test data; * add documentation for CPU topology information in the host capabilities XML; * address other review comments. [v1] https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/ZAZO… Andrea Bolognani (11): tests: Add hostcpudata for machine with CPU clusters conf: Report CPU clusters in capabilities XML conf: Allow specifying CPU clusters qemu: Introduce QEMU_CAPS_SMP_CLUSTERS qemu: Use CPU clusters for guests tests: Add test case for CPU clusters qemu: Make monitor aware of CPU clusters tests: Verify handling of CPU clusters in QMP data docs: Improve documentation for CPU topology docs: Document CPU clusters news: Mention support for CPU clusters NEWS.rst | 6 + docs/formatcaps.rst | 72 ++++++-- docs/formatdomain.rst | 24 ++- src/bhyve/bhyve_command.c | 5 + src/conf/capabilities.c | 5 +- src/conf/capabilities.h | 1 + src/conf/cpu_conf.c | 16 +- src/conf/cpu_conf.h | 1 + src/conf/domain_conf.c | 1 + src/conf/schemas/capability.rng | 3 + src/conf/schemas/cputypes.rng | 5 + src/cpu/cpu.c | 1 + src/libvirt_linux.syms | 1 + src/libxl/libxl_capabilities.c | 1 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 8 + src/qemu/qemu_domain.c | 3 +- src/qemu/qemu_monitor.c | 2 + src/qemu/qemu_monitor.h | 2 + src/qemu/qemu_monitor_json.c | 5 + src/util/virhostcpu.c | 22 +++ src/util/virhostcpu.h | 1 + src/vmx/vmx.c | 7 + tests/capabilityschemadata/caps-qemu-kvm.xml | 32 ++-- .../x86_64-host+guest,model486-result.xml | 2 +- .../x86_64-host+guest,models-result.xml | 2 +- .../cputestdata/x86_64-host+guest-result.xml | 2 +- tests/cputestdata/x86_64-host+guest.xml | 2 +- .../x86_64-host+host-model-nofallback.xml | 2 +- ...t-Haswell-noTSX+Haswell,haswell-result.xml | 2 +- ...ell-noTSX+Haswell-noTSX,haswell-result.xml | 2 +- ...ost-Haswell-noTSX+Haswell-noTSX-result.xml | 2 +- .../x86_64-host-worse+guest-result.xml | 2 +- .../qemucapabilitiesdata/caps_7.1.0_ppc64.xml | 1 + .../caps_7.1.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml | 1 + .../caps_7.2.0_x86_64+hvf.xml | 1 + .../caps_7.2.0_x86_64.xml | 1 + .../caps_8.0.0_riscv64.xml | 1 + .../caps_8.0.0_x86_64.xml | 1 + .../qemucapabilitiesdata/caps_8.1.0_s390x.xml | 1 + .../caps_8.1.0_x86_64.xml | 1 + .../caps_8.2.0_aarch64.xml | 1 + .../caps_8.2.0_x86_64.xml | 1 + .../caps_9.0.0_x86_64.xml | 1 + .../ppc64-modern-bulk-result-conf.xml | 2 +- .../ppc64-modern-bulk-result-live.xml | 2 +- .../ppc64-modern-individual-result-conf.xml | 2 +- .../ppc64-modern-individual-result-live.xml | 2 +- .../x86-modern-bulk-result-conf.xml | 2 +- .../x86-modern-bulk-result-live.xml | 2 +- .../x86-modern-individual-add-result-conf.xml | 2 +- .../x86-modern-individual-add-result-live.xml | 2 +- ...imeout+graphics-spice-timeout-password.xml | 2 +- .../qemuhotplug-graphics-spice-timeout.xml | 2 +- ...torjson-cpuinfo-aarch64-clusters-cpus.json | 88 +++++++++ ...json-cpuinfo-aarch64-clusters-hotplug.json | 171 ++++++++++++++++++ ...umonitorjson-cpuinfo-aarch64-clusters.data | 108 +++++++++++ tests/qemumonitorjsontest.c | 9 +- .../cpu-hotplug-startup.x86_64-latest.args | 2 +- .../cpu-numa-disjoint.x86_64-latest.args | 2 +- .../cpu-numa-disordered.x86_64-latest.args | 2 +- .../cpu-numa-memshared.x86_64-latest.args | 2 +- ...-numa-no-memory-element.x86_64-latest.args | 2 +- .../cpu-numa1.x86_64-latest.args | 2 +- .../cpu-numa2.x86_64-latest.args | 2 +- .../cpu-topology1.x86_64-latest.args | 2 +- .../cpu-topology2.x86_64-latest.args | 2 +- .../cpu-topology3.x86_64-latest.args | 2 +- .../cpu-topology4.x86_64-latest.args | 2 +- ...args => cpu-topology5.aarch64-latest.args} | 12 +- tests/qemuxml2argvdata/cpu-topology5.xml | 17 ++ ...memory-no-numa-topology.x86_64-latest.args | 2 +- .../fd-memory-no-numa-topology.xml | 2 +- ...fd-memory-numa-topology.x86_64-latest.args | 2 +- .../fd-memory-numa-topology.xml | 2 +- ...d-memory-numa-topology2.x86_64-latest.args | 2 +- .../fd-memory-numa-topology2.xml | 2 +- ...d-memory-numa-topology3.x86_64-latest.args | 2 +- .../fd-memory-numa-topology3.xml | 2 +- .../hugepages-nvdimm.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/hugepages-nvdimm.xml | 2 +- ...memory-default-hugepage.x86_64-latest.args | 2 +- .../memfd-memory-default-hugepage.xml | 2 +- .../memfd-memory-numa.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/memfd-memory-numa.xml | 2 +- ...emory-hotplug-dimm-addr.x86_64-latest.args | 2 +- .../memory-hotplug-dimm.x86_64-latest.args | 2 +- ...memory-hotplug-multiple.x86_64-latest.args | 2 +- ...y-hotplug-nvdimm-access.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-access.xml | 2 +- ...ry-hotplug-nvdimm-align.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-align.xml | 2 +- ...ry-hotplug-nvdimm-label.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-label.xml | 2 +- ...ory-hotplug-nvdimm-pmem.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-pmem.xml | 2 +- ...-nvdimm-ppc64-abi-update.ppc64-latest.args | 2 +- ...ory-hotplug-nvdimm-ppc64.ppc64-latest.args | 2 +- ...hotplug-nvdimm-readonly.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-readonly.xml | 2 +- .../memory-hotplug-nvdimm.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm.xml | 2 +- ...mory-hotplug-virtio-mem.x86_64-latest.args | 2 +- .../memory-hotplug-virtio-mem.xml | 2 +- ...ory-hotplug-virtio-pmem.x86_64-latest.args | 2 +- .../memory-hotplug-virtio-pmem.xml | 2 +- .../memory-hotplug.x86_64-latest.args | 2 +- ...auto-memory-vcpu-cpuset.x86_64-latest.args | 2 +- ...no-cpuset-and-placement.x86_64-latest.args | 2 +- ...d-auto-vcpu-no-numatune.x86_64-latest.args | 2 +- ...to-vcpu-static-numatune.x86_64-latest.args | 2 +- ...static-memory-auto-vcpu.x86_64-latest.args | 2 +- ...static-vcpu-no-numatune.x86_64-latest.args | 2 +- .../qemuxml2argvdata/numad.x86_64-latest.args | 2 +- ...ne-auto-nodeset-invalid.x86_64-latest.args | 2 +- .../pci-expander-bus.x86_64-latest.args | 2 +- .../pcie-expander-bus.x86_64-latest.args | 2 +- .../pseries-phb-numa-node.ppc64-latest.args | 2 +- tests/qemuxml2argvtest.c | 1 + .../cpu-numa-disjoint.x86_64-latest.xml | 2 +- .../cpu-numa-disordered.x86_64-latest.xml | 2 +- .../cpu-numa-memshared.x86_64-latest.xml | 2 +- ...u-numa-no-memory-element.x86_64-latest.xml | 2 +- .../cpu-numa1.x86_64-latest.xml | 2 +- .../cpu-numa2.x86_64-latest.xml | 2 +- .../cpu-topology5.aarch64-latest.xml | 29 +++ ...memory-hotplug-dimm-addr.x86_64-latest.xml | 2 +- .../memory-hotplug-dimm.x86_64-latest.xml | 2 +- .../memory-hotplug-multiple.x86_64-latest.xml | 2 +- ...g-nvdimm-ppc64-abi-update.ppc64-latest.xml | 2 +- ...mory-hotplug-nvdimm-ppc64.ppc64-latest.xml | 2 +- .../memory-hotplug.x86_64-latest.xml | 2 +- ...-auto-memory-vcpu-cpuset.x86_64-latest.xml | 2 +- ...-no-cpuset-and-placement.x86_64-latest.xml | 2 +- ...ad-auto-vcpu-no-numatune.x86_64-latest.xml | 2 +- ...-static-vcpu-no-numatune.x86_64-latest.xml | 2 +- .../pci-expander-bus.x86_64-latest.xml | 2 +- .../pcie-expander-bus.x86_64-latest.xml | 2 +- .../pseries-phb-numa-node.ppc64-latest.xml | 2 +- tests/qemuxml2xmltest.c | 2 + .../linux-basic-clusters/system/cpu | 1 + .../linux-basic-clusters/system/node | 1 + .../vircaps-aarch64-basic-clusters.xml | 39 ++++ .../vircaps2xmldata/vircaps-aarch64-basic.xml | 32 ++-- .../vircaps-x86_64-basic-dies.xml | 24 +-- .../vircaps2xmldata/vircaps-x86_64-basic.xml | 32 ++-- .../vircaps2xmldata/vircaps-x86_64-caches.xml | 16 +- tests/vircaps2xmldata/vircaps-x86_64-hmat.xml | 48 ++--- .../vircaps-x86_64-resctrl-cdp.xml | 24 +-- .../vircaps-x86_64-resctrl-cmt.xml | 24 +-- .../vircaps-x86_64-resctrl-fake-feature.xml | 24 +-- .../vircaps-x86_64-resctrl-skx-twocaches.xml | 2 +- .../vircaps-x86_64-resctrl-skx.xml | 2 +- .../vircaps-x86_64-resctrl.xml | 24 +-- tests/vircaps2xmltest.c | 1 + .../linux-aarch64-with-clusters.cpuinfo | 72 ++++++++ .../linux-aarch64-with-clusters.expected | 1 + .../cpu/cpu0/topology/cluster_cpus_list | 1 + .../cpu/cpu0/topology/cluster_id | 1 + .../cpu/cpu0/topology/core_cpus_list | 1 + .../cpu/cpu0/topology/core_id | 1 + .../cpu/cpu0/topology/core_siblings_list | 1 + .../cpu/cpu0/topology/package_cpus_list | 1 + .../cpu/cpu0/topology/physical_package_id | 1 + .../cpu/cpu0/topology/thread_siblings_list | 1 + .../cpu/cpu1/topology/cluster_cpus_list | 1 + .../cpu/cpu1/topology/cluster_id | 1 + .../cpu/cpu1/topology/core_cpus_list | 1 + .../cpu/cpu1/topology/core_id | 1 + .../cpu/cpu1/topology/core_siblings_list | 1 + .../cpu/cpu1/topology/package_cpus_list | 1 + .../cpu/cpu1/topology/physical_package_id | 1 + .../cpu/cpu1/topology/thread_siblings_list | 1 + .../cpu/cpu2/topology/cluster_cpus_list | 1 + .../cpu/cpu2/topology/cluster_id | 1 + .../cpu/cpu2/topology/core_cpus_list | 1 + .../cpu/cpu2/topology/core_id | 1 + .../cpu/cpu2/topology/core_siblings_list | 1 + .../cpu/cpu2/topology/package_cpus_list | 1 + .../cpu/cpu2/topology/physical_package_id | 1 + .../cpu/cpu2/topology/thread_siblings_list | 1 + .../cpu/cpu3/topology/cluster_cpus_list | 1 + .../cpu/cpu3/topology/cluster_id | 1 + .../cpu/cpu3/topology/core_cpus_list | 1 + .../cpu/cpu3/topology/core_id | 1 + .../cpu/cpu3/topology/core_siblings_list | 1 + .../cpu/cpu3/topology/package_cpus_list | 1 + .../cpu/cpu3/topology/physical_package_id | 1 + .../cpu/cpu3/topology/thread_siblings_list | 1 + .../cpu/cpu4/topology/cluster_cpus_list | 1 + .../cpu/cpu4/topology/cluster_id | 1 + .../cpu/cpu4/topology/core_cpus_list | 1 + .../cpu/cpu4/topology/core_id | 1 + .../cpu/cpu4/topology/core_siblings_list | 1 + .../cpu/cpu4/topology/package_cpus_list | 1 + .../cpu/cpu4/topology/physical_package_id | 1 + .../cpu/cpu4/topology/thread_siblings_list | 1 + .../cpu/cpu5/topology/cluster_cpus_list | 1 + .../cpu/cpu5/topology/cluster_id | 1 + .../cpu/cpu5/topology/core_cpus_list | 1 + .../cpu/cpu5/topology/core_id | 1 + .../cpu/cpu5/topology/core_siblings_list | 1 + .../cpu/cpu5/topology/package_cpus_list | 1 + .../cpu/cpu5/topology/physical_package_id | 1 + .../cpu/cpu5/topology/thread_siblings_list | 1 + .../cpu/cpu6/topology/cluster_cpus_list | 1 + .../cpu/cpu6/topology/cluster_id | 1 + .../cpu/cpu6/topology/core_cpus_list | 1 + .../cpu/cpu6/topology/core_id | 1 + .../cpu/cpu6/topology/core_siblings_list | 1 + .../cpu/cpu6/topology/package_cpus_list | 1 + .../cpu/cpu6/topology/physical_package_id | 1 + .../cpu/cpu6/topology/thread_siblings_list | 1 + .../cpu/cpu7/topology/cluster_cpus_list | 1 + .../cpu/cpu7/topology/cluster_id | 1 + .../cpu/cpu7/topology/core_cpus_list | 1 + .../cpu/cpu7/topology/core_id | 1 + .../cpu/cpu7/topology/core_siblings_list | 1 + .../cpu/cpu7/topology/package_cpus_list | 1 + .../cpu/cpu7/topology/physical_package_id | 1 + .../cpu/cpu7/topology/thread_siblings_list | 1 + .../linux-with-clusters/cpu/online | 1 + .../linux-with-clusters/cpu/present | 1 + .../linux-with-clusters/node/node0/cpu0 | 1 + .../linux-with-clusters/node/node0/cpu1 | 1 + .../linux-with-clusters/node/node0/cpu2 | 1 + .../linux-with-clusters/node/node0/cpu3 | 1 + .../linux-with-clusters/node/node0/cpulist | 1 + .../linux-with-clusters/node/node1/cpu4 | 1 + .../linux-with-clusters/node/node1/cpu5 | 1 + .../linux-with-clusters/node/node1/cpu6 | 1 + .../linux-with-clusters/node/node1/cpu7 | 1 + .../linux-with-clusters/node/node1/cpulist | 1 + .../linux-with-clusters/node/online | 1 + .../linux-with-clusters/node/possible | 1 + tests/virhostcputest.c | 1 + tests/vmx2xmldata/esx-in-the-wild-10.xml | 2 +- tests/vmx2xmldata/esx-in-the-wild-8.xml | 2 +- tests/vmx2xmldata/esx-in-the-wild-9.xml | 2 +- 241 files changed, 1044 insertions(+), 276 deletions(-) create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-aarch64-clusters-cpus.json create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-aarch64-clusters-hotplug.json create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-aarch64-clusters.data copy tests/qemuxml2argvdata/{cpu-topology2.x86_64-latest.args => cpu-topology5.aarch64-latest.args} (69%) create mode 100644 tests/qemuxml2argvdata/cpu-topology5.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-topology5.aarch64-latest.xml create mode 120000 tests/vircaps2xmldata/linux-basic-clusters/system/cpu create mode 120000 tests/vircaps2xmldata/linux-basic-clusters/system/node create mode 100644 tests/vircaps2xmldata/vircaps-aarch64-basic-clusters.xml create mode 100644 tests/virhostcpudata/linux-aarch64-with-clusters.cpuinfo create mode 100644 tests/virhostcpudata/linux-aarch64-with-clusters.expected create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu0/topology/cluster_cpus_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu0/topology/cluster_id create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu0/topology/core_cpus_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu0/topology/core_id create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu0/topology/core_siblings_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu0/topology/package_cpus_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu0/topology/physical_package_id create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu0/topology/thread_siblings_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu1/topology/cluster_cpus_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu1/topology/cluster_id create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu1/topology/core_cpus_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu1/topology/core_id create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu1/topology/core_siblings_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu1/topology/package_cpus_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu1/topology/physical_package_id create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu1/topology/thread_siblings_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu2/topology/cluster_cpus_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu2/topology/cluster_id create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu2/topology/core_cpus_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu2/topology/core_id create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu2/topology/core_siblings_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu2/topology/package_cpus_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu2/topology/physical_package_id create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu2/topology/thread_siblings_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu3/topology/cluster_cpus_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu3/topology/cluster_id create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu3/topology/core_cpus_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu3/topology/core_id create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu3/topology/core_siblings_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu3/topology/package_cpus_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu3/topology/physical_package_id create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu3/topology/thread_siblings_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu4/topology/cluster_cpus_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu4/topology/cluster_id create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu4/topology/core_cpus_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu4/topology/core_id create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu4/topology/core_siblings_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu4/topology/package_cpus_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu4/topology/physical_package_id create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu4/topology/thread_siblings_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu5/topology/cluster_cpus_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu5/topology/cluster_id create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu5/topology/core_cpus_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu5/topology/core_id create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu5/topology/core_siblings_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu5/topology/package_cpus_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu5/topology/physical_package_id create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu5/topology/thread_siblings_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu6/topology/cluster_cpus_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu6/topology/cluster_id create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu6/topology/core_cpus_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu6/topology/core_id create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu6/topology/core_siblings_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu6/topology/package_cpus_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu6/topology/physical_package_id create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu6/topology/thread_siblings_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu7/topology/cluster_cpus_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu7/topology/cluster_id create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu7/topology/core_cpus_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu7/topology/core_id create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu7/topology/core_siblings_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu7/topology/package_cpus_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu7/topology/physical_package_id create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu7/topology/thread_siblings_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/online create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/present create mode 120000 tests/virhostcpudata/linux-with-clusters/node/node0/cpu0 create mode 120000 tests/virhostcpudata/linux-with-clusters/node/node0/cpu1 create mode 120000 tests/virhostcpudata/linux-with-clusters/node/node0/cpu2 create mode 120000 tests/virhostcpudata/linux-with-clusters/node/node0/cpu3 create mode 100644 tests/virhostcpudata/linux-with-clusters/node/node0/cpulist create mode 120000 tests/virhostcpudata/linux-with-clusters/node/node1/cpu4 create mode 120000 tests/virhostcpudata/linux-with-clusters/node/node1/cpu5 create mode 120000 tests/virhostcpudata/linux-with-clusters/node/node1/cpu6 create mode 120000 tests/virhostcpudata/linux-with-clusters/node/node1/cpu7 create mode 100644 tests/virhostcpudata/linux-with-clusters/node/node1/cpulist create mode 100644 tests/virhostcpudata/linux-with-clusters/node/online create mode 100644 tests/virhostcpudata/linux-with-clusters/node/possible -- 2.43.0

2 19

[PATCH] news: document auto-selection of VFIO variant drivers
by Laine Stump 15 Jan '24

15 Jan '24

Signed-off-by: Laine Stump <laine(a)redhat.com> --- NEWS.rst | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index af3c4906df..fed50aae86 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -37,6 +37,15 @@ v10.0.0 (unreleased) ``virDomainBlockResize`` allows resizing a block-device backed ``raw`` disk of a VM without the need to specify the full size of the block device. + * qemu: automatic selection/binding of VFIO variant drivers + + When a device is assigned to a guest using VFIO with ``<hostdev + managed='yes'>``, libvirt will now search the running kernel's + modules.alias file for the most specific match to that device for + a VFIO driver, and bind that driver to the device rather than + vfio-pci. A specific driver can also be forced, using the + ``<driver model='plugh'/>`` attribute. + * **Improvements** * qemu: Improve migration XML use when persisting VM on destination -- 2.43.0

2 2

Release of libvirt-10.0.0
by Jiri Denemark 15 Jan '24

15 Jan '24

The 10.0.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is greatly appreciated. * New features * qemu: Enable ``postcopy-preempt`` migration capability Post-copy migrations are now started with ``postcopy-preempt`` capability enabled as long as it is supported by both sides of migration. This should enable faster migration of memory pages that the destination tries to read before they are migrated from the source. * qemu: Add support for mapping iothreads to virtqueues of ``virtio-blk`` devices QEMU added the possibility to map multiple ``iothreads`` to a single ``virtio-blk`` device and map them even to specific virtqueues. Libvirt adds a ``<iothreads>`` subelement of the ``<disk> <driver>`` element that users can use to configure the mapping. * qemu: Allow automatic resize of block-device-backed disk to full size of the device The new flag ``VIR_DOMAIN_BLOCK_RESIZE_CAPACITY`` for ``virDomainBlockResize`` allows resizing a block-device backed ``raw`` disk of a VM without the need to specify the full size of the block device. * qemu: automatic selection/binding of VFIO variant drivers When a device is assigned to a guest using VFIO with ``<hostdev managed='yes'>``, libvirt will now search the running kernel's modules.alias file for the most specific match to that device for a VFIO driver, and bind that driver to the device rather than vfio-pci. A specific driver can also be forced, using the ``<driver model='plugh'/>`` attribute. * qemu: add runtime configuration option for nbdkit Since the new nbdkit support requires a recent selinux policy that is not widely available yet, it is now possible to build libvirt with nbdkit support for remote disks but disabled at runtime. This behavior is controlled via the storage_use_nbdkit option of the qemu driver configuration file. The option will default to being disabled, but this may change in a future release and can be customized with the nbdkit_config_default build option. * Improvements * qemu: Improve migration XML use when persisting VM on destination When migrating a VM with a custom migration XML, use it as a base for persisting it on the destination as users could have changed non-ABI breaking facts which would prevent subsequent start if the old XML were used. * qemu: Simplify non-shared storage migration to ``raw`` block devices The phase of copying storage during migration without shared storage requires that both the source and destination image are identical in size. This may not be possible if the destination is backed by a block device and the source image size is not a multiple of the block device block size. Libvirt aleviates this by automatically adding a ``<slice>`` to match the size of the source image rather than failing the migration. * test driver: Support for hotplug/hotunplug of PCI devices The test driver now supports basic hotplug and hotunplug of PCI devices. * Bug fixes * qemu: Various migration bug fixes and debuggability improvement This release fixes multiple bugs in virsh and libvirt in handling of migration arguments and XMLs and modifies error reporting for better debugging. * conf: Restore setting default bus for input devices Because of a regression, starting from 9.3.0 libvirt did not autofill bus for input devices. With this release the regression was identified and fixed. * qemu: Relax check for memory device coldplug Because of a check that was too aggressive, a virtio-mem memory device could not be cold plugged. This is now fixed. * qemu: Be less aggressive when dropping channel source paths Another regression is resolved, (introduced in 9.7.0) when libvirt was too aggressive when dropping parsed paths for <channel/> sources * qemuDomainChangeNet: Reflect trustGuestRxFilters change On device-update, when a user requested change of trustGuestRxFilters for a domain's <interface/> libvirt did nothing. It did not throw an error nor did it reflect the change. Starting with this release, the change is reflected. Enjoy. Jirka

1 0

[PATCH] NEWS: mention nbdkit config option
by Jonathon Jongsma 15 Jan '24

15 Jan '24

Signed-off-by: Jonathon Jongsma <jjongsma(a)redhat.com> --- NEWS.rst | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index af3c4906df..8088097ad6 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -37,6 +37,16 @@ v10.0.0 (unreleased) ``virDomainBlockResize`` allows resizing a block-device backed ``raw`` disk of a VM without the need to specify the full size of the block device. + * qemu: add runtime configuration option for nbdkit + + Since the new nbdkit support requires a recent selinux policy that is not + widely available yet, it is now possible to build libvirt with nbdkit + support for remote disks but disabled at runtime. This behavior is + controlled via the storage_use_nbdkit option of the qemu driver + configuration file. The option will default to being disabled, but this may + change in a future release and can be customized with the + nbdkit_config_default build option. + * **Improvements** * qemu: Improve migration XML use when persisting VM on destination -- 2.43.0

2 1

[v3 0/4] Support for dirty-limit live migration
by Hyman Huang 15 Jan '24

15 Jan '24

v3: - adjust the parameter check location for suggested by Michal - mark the VIR_MIGRATE_DIRTY_LIMIT flag since 10.0.0 - rebase on master Thanks Michal for the comments. Please review, Yong. v1: The dirty-limit functionality for live migration was introduced since qemu>=8.1. In the live migration scenario, it implements the force convergence using the dirty-limit approach, which results in better reliable read performance. A straightforward dirty-limit capability for live migration is added by this patchset. Users might not care about other dirty-limit arguments like "x-vcpu-dirty-limit-period" or "vcpu-dirty-limit," thus do not expose them to Libvirt and Keep the default configurations and values in place. For more details about dirty-limit, please see the following reference: https://lore.kernel.org/qemu- devel/169024923116.19090.10825599068950039132-0(a)git.sr.ht/ Hyman Huang (4): Add VIR_MIGRATE_DIRTY_LIMIT flag qemu_migration: Implement VIR_MIGRATE_DIRTY_LIMIT flag virsh: Add support for VIR_MIGRATE_DIRTY_LIMIT flag NEWS: document support for dirty-limit live migration NEWS.rst | 8 ++++++++ docs/manpages/virsh.rst | 10 +++++++++- include/libvirt/libvirt-domain.h | 5 +++++ src/libvirt-domain.c | 8 ++++++++ src/qemu/qemu_migration.c | 8 ++++++++ src/qemu/qemu_migration.h | 1 + src/qemu/qemu_migration_params.c | 6 ++++++ src/qemu/qemu_migration_params.h | 1 + tools/virsh-domain.c | 6 ++++++ 9 files changed, 52 insertions(+), 1 deletion(-) -- 2.39.1

2 5

[PATCH] NEWS: Document my contributions for upcoming release
by Michal Privoznik 12 Jan '24

12 Jan '24

Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- NEWS.rst | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index af3c4906df..e8cc89a2ee 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -55,6 +55,10 @@ v10.0.0 (unreleased) Libvirt aleviates this by automatically adding a ``<slice>`` to match the size of the source image rather than failing the migration. + * test driver: Support for hotplug/hotunplug of PCI devices + + The test driver now supports basic hotplug and hotunplug of PCI devices. + * **Bug fixes** * qemu: Various migration bug fixes and debuggability improvement @@ -63,6 +67,29 @@ v10.0.0 (unreleased) migration arguments and XMLs and modifies error reporting for better debugging. + * conf: Restore setting default bus for input devices + + Because of a regression, starting from 9.3.0 libvirt did not autofill bus + for input devices. With this release the regression was identified and + fixed. + + * qemu: Relax check for memory device coldplug + + Because of too aggressive check, a virtio-mem memory device could not be + cold plugged. This now fixed. + + * qemu: Be less aggressive when dropping channel source paths + + Another regression is resolved, (introduced in 9.7.0) when libvirt was too + aggressive when dropping parsed paths for <channel/> sources + + * qemuDomainChangeNet: Reflect trustGuestRxFilters change + + On device-update, when user requests change of trustGuestRxFilters for a + domain's <interface/> libvirt did nothing. Neither it thrown an error nor + did it reflect the change. Starting with this release, the change is + reflected. + v9.10.0 (2023-12-01) ==================== -- 2.41.0

2 1

[PATCH 0/2] ci: Fix upstream QEMU integration job
by Andrea Bolognani 12 Jan '24

12 Jan '24

Or at least, hopefully it does! This is completely untested, as validating changes to the integration tests is difficult/annoying. The job's currently broken anyway, so it's not like these changes could possibly make things worse :) Andrea Bolognani (2): ci: Fix .integration_tests_upstream_qemu ci: Do more as part of .qemu-build-template ci/integration-template.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.43.0

2 3

[PATCH rfcv3 00/11] LIBVIRT: X86: TDX support
by Zhenzhong Duan 12 Jan '24

12 Jan '24

Hi, This series brings libvirt the x86 TDX support. * What's TDX? TDX stands for Trust Domain Extensions which isolates VMs from the virtual-machine manager (VMM)/hypervisor and any other software on the platform. To support TDX, multiple software components, not only KVM but also QEMU, guest Linux and virtual bios, need to be updated. For more details, please check link[1], there are TDX spec links and public repository link at github for each software component. This patchset is another software component to extend libvirt to support TDX, with which one can start a VM from high level rather than running qemu directly. * Misc As QEMU use a software emulated way to reset guest which isn't supported by TDX guest for security reason. We add a new way to emulate the reset for TDX guest, called "hard reboot". We achieve this by killing old qemu and start a new one. Complete code can be found at [1], matching qemu code can be found at [2]. There are some new properties for tdx-guest object, i.e. `mrconfigid`, `mrowner`, `mrownerconfig` and `debug` which aren't in matching qemu[2] yet. I keep them intentionally as they will be implemented in qemu as extention series of [2]. * Test start/stop/reboot with virsh stop/reboot trigger in guest stop with on_poweroff=destroy/restart reboot with on_reboot=destroy/restart * Patch organization - patch 1-3: Support query of TDX capabilities. - patch 4-6: Add TDX type to launchsecurity framework. - patch 7-11: Add hard reboot support to TDX guest [1] https://github.com/intel/libvirt-tdx/commits/tdx_for_upstream_rfcv3 [2] https://github.com/intel/qemu-tdx/tree/tdx-qemu-upstream-v3 Thanks Zhenzhong Changelog: rfcv3: - Change to generate qemu cmdline with -bios - drop firmware auto match as -bios is used - add a hard reboot method to reboot TDX guest rfcv2: - give up using qmp cmd and check TDX directly on host for TDX capabilities. - use launchsecurity framework to support TDX - use <os>.<loader> for general loader - add auto firmware match feature for TDX A example TDVF fimware description file 70-edk2-x86_64-tdx.json: { "description": "UEFI firmware for x86_64, supporting Intel TDX", "interface-types": [ "uefi" ], "mapping": { "device": "generic", "filename": "/usr/share/OVMF/OVMF_CODE-tdx.fd" }, "targets": [ { "architecture": "x86_64", "machines": [ "pc-q35-*" ] } ], "features": [ "intel-tdx", "verbose-dynamic" ], "tags": [ ] } rfcv2: https://www.mail-archive.com/libvir-list@redhat.com/msg219378.html Chenyi Qiang (3): qemu: add hard reboot in QEMU driver qemu: make hard reboot as the TDX default reboot mode virsh: add new option "timekeep" to keep virsh console alive Zhenzhong Duan (8): qemu: Check if INTEL Trust Domain Extention support is enabled qemu: Add TDX capability conf: expose TDX feature in domain capabilities conf: add tdx as launch security type qemu: Add command line and validation for TDX type qemu: force special parameters enabled for TDX guest qemu: Extend hard reboot in Qemu driver conf: Add support to keep same domid for hard reboot docs/formatdomaincaps.rst | 1 + include/libvirt/libvirt-domain.h | 2 + src/conf/domain_capabilities.c | 1 + src/conf/domain_capabilities.h | 1 + src/conf/domain_conf.c | 50 ++++++++++++++++ src/conf/domain_conf.h | 11 ++++ src/conf/schemas/domaincaps.rng | 9 +++ src/conf/schemas/domaincommon.rng | 34 +++++++++++ src/conf/virconftypes.h | 2 + src/qemu/qemu_capabilities.c | 38 +++++++++++- src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 29 +++++++++ src/qemu/qemu_domain.c | 18 ++++++ src/qemu/qemu_domain.h | 4 ++ src/qemu/qemu_driver.c | 85 ++++++++++++++++++++------ src/qemu/qemu_firmware.c | 1 + src/qemu/qemu_monitor.c | 19 +++++- src/qemu/qemu_monitor.h | 2 +- src/qemu/qemu_monitor_json.c | 6 +- src/qemu/qemu_namespace.c | 1 + src/qemu/qemu_process.c | 99 ++++++++++++++++++++++++++++++- src/qemu/qemu_validate.c | 18 ++++++ tools/virsh-console.c | 3 + tools/virsh-domain.c | 64 +++++++++++++++----- tools/virsh.h | 1 + 25 files changed, 463 insertions(+), 37 deletions(-) -- 2.34.1

5 40

Entering freeze for libvirt-10.0.0
by Jiri Denemark 12 Jan '24

12 Jan '24

I have just tagged v10.0.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Thanks, Jirka

1 1

[PATCH 0/3] ci: Fixes for integration jobs
by Andrea Bolognani 12 Jan '24

12 Jan '24

Andrea Bolognani (3): ci: Fix upstream-qemu job definitions ci: Move upstream-qemu job to Fedora 39 ci: Add notes for integration jobs ci/integration.yml | 58 +++++++++++++++++++++++++++++++--------------- 1 file changed, 39 insertions(+), 19 deletions(-) -- 2.43.0

3 15

[PATCH] NEWS: Mention migration fixes and iothread mapping
by Peter Krempa 12 Jan '24

12 Jan '24

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 9e538a8f57..af3c4906df 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -24,10 +24,45 @@ v10.0.0 (unreleased) This should enable faster migration of memory pages that the destination tries to read before they are migrated from the source. + * qemu: Add support for mapping iothreads to virtqueues of ``virtio-blk`` devices + + QEMU added the possibility to map multiple ``iothreads`` to a single + ``virtio-blk`` device and map them even to specific virtqueues. Libvirt + adds a ``<iothreads>`` subelement of the ``<disk> <driver>`` element that + users can use to configure the mapping. + + * qemu: Allow automatic resize of block-device-backed disk to full size of the device + + The new flag ``VIR_DOMAIN_BLOCK_RESIZE_CAPACITY`` for + ``virDomainBlockResize`` allows resizing a block-device backed ``raw`` disk + of a VM without the need to specify the full size of the block device. + * **Improvements** + * qemu: Improve migration XML use when persisting VM on destination + + When migrating a VM with a custom migration XML, use it as a base for + persisting it on the destination as users could have changed non-ABI + breaking facts which would prevent subsequent start if the old XML were used. + + * qemu: Simplify non-shared storage migration to ``raw`` block devices + + The phase of copying storage during migration without shared storage + requires that both the source and destination image are identical in size. + This may not be possible if the destination is backed by a block device + and the source image size is not a multiple of the block device block size. + + Libvirt aleviates this by automatically adding a ``<slice>`` to match the + size of the source image rather than failing the migration. + * **Bug fixes** + * qemu: Various migration bug fixes and debuggability improvement + + This release fixes multiple bugs in virsh and libvirt in handling of + migration arguments and XMLs and modifies error reporting for better + debugging. + v9.10.0 (2023-12-01) ==================== -- 2.43.0

2 1

[PATCH] conf: domain_conf: cleanup def in case of errors
by Shaleen Bathla 11 Jan '24

11 Jan '24

Just like in rest of the function virDomainFSDefParseXML, use goto error so that def will be cleaned up in error cases. Signed-off-by: Shaleen Bathla <shaleen.bathla(a)oracle.com> --- src/conf/domain_conf.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index be57a1981e7d..5d55d2acdace 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8866,23 +8866,23 @@ virDomainFSDefParseXML(virDomainXMLOption *xmlopt, goto error; if ((n = virXPathNodeSet("./idmap/uid", ctxt, &uid_nodes)) < 0) - return NULL; + goto error; if (n) { def->idmap.uidmap = virDomainIdmapDefParseXML(ctxt, uid_nodes, n); if (!def->idmap.uidmap) - return NULL; + goto error; def->idmap.nuidmap = n; } if ((n = virXPathNodeSet("./idmap/gid", ctxt, &gid_nodes)) < 0) - return NULL; + goto error; if (n) { def->idmap.gidmap = virDomainIdmapDefParseXML(ctxt, gid_nodes, n); if (!def->idmap.gidmap) - return NULL; + goto error; def->idmap.ngidmap = n; } -- 2.39.3

2 1

[PATCH 00/11] qemu: Add support for CPU clusters
by Andrea Bolognani 11 Jan '24

11 Jan '24

Edited for brevity. Full version: $ git fetch https://gitlab.com/abologna/libvirt.git cpu-clusters Depends on: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/IDFV… Andrea Bolognani (11): tests: Add hostcpudata for machine with CPU clusters conf: Report CPU clusters in capabilities XML conf: Allow specifying CPU clusters qemu: Introduce QEMU_CAPS_SMP_CLUSTERS qemu: Use CPU clusters for guests tests: Add test case for CPU clusters qemu: Make monitor aware of CPU clusters tests: Verify handling of CPU clusters in QMP data docs: Tweak documentation for CPU topology docs: Document CPU clusters news: Mention support for CPU clusters NEWS.rst | 6 + docs/formatcaps.rst | 2 +- docs/formatdomain.rst | 24 +- src/bhyve/bhyve_command.c | 5 + src/conf/capabilities.c | 5 +- src/conf/capabilities.h | 1 + src/conf/cpu_conf.c | 16 +- src/conf/cpu_conf.h | 1 + src/conf/domain_conf.c | 1 + src/conf/schemas/capability.rng | 3 + src/conf/schemas/cputypes.rng | 5 + src/cpu/cpu.c | 1 + src/libvirt_linux.syms | 1 + src/libxl/libxl_capabilities.c | 1 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 7 + src/qemu/qemu_domain.c | 3 +- src/qemu/qemu_monitor.c | 2 + src/qemu/qemu_monitor.h | 2 + src/qemu/qemu_monitor_json.c | 5 + src/util/virhostcpu.c | 22 + src/util/virhostcpu.h | 1 + src/vmx/vmx.c | 7 + tests/capabilityschemadata/caps-qemu-kvm.xml | 32 +- .../x86_64-host+guest,model486-result.xml | 2 +- .../x86_64-host+guest,models-result.xml | 2 +- .../cputestdata/x86_64-host+guest-result.xml | 2 +- tests/cputestdata/x86_64-host+guest.xml | 2 +- .../x86_64-host+host-model-nofallback.xml | 2 +- ...t-Haswell-noTSX+Haswell,haswell-result.xml | 2 +- ...ell-noTSX+Haswell-noTSX,haswell-result.xml | 2 +- ...ost-Haswell-noTSX+Haswell-noTSX-result.xml | 2 +- .../x86_64-host-worse+guest-result.xml | 2 +- .../qemucapabilitiesdata/caps_7.1.0_ppc64.xml | 1 + .../caps_7.1.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml | 1 + .../caps_7.2.0_x86_64+hvf.xml | 1 + .../caps_7.2.0_x86_64.xml | 1 + .../caps_8.0.0_riscv64.xml | 1 + .../caps_8.0.0_x86_64.xml | 1 + .../qemucapabilitiesdata/caps_8.1.0_s390x.xml | 1 + .../caps_8.1.0_x86_64.xml | 1 + .../caps_8.2.0_aarch64.xml | 1 + .../caps_8.2.0_x86_64.xml | 1 + .../caps_9.0.0_x86_64.xml | 1 + .../ppc64-modern-bulk-result-conf.xml | 2 +- .../ppc64-modern-bulk-result-live.xml | 2 +- .../ppc64-modern-individual-result-conf.xml | 2 +- .../ppc64-modern-individual-result-live.xml | 2 +- .../x86-modern-bulk-result-conf.xml | 2 +- .../x86-modern-bulk-result-live.xml | 2 +- .../x86-modern-individual-add-result-conf.xml | 2 +- .../x86-modern-individual-add-result-live.xml | 2 +- ...imeout+graphics-spice-timeout-password.xml | 2 +- .../qemuhotplug-graphics-spice-timeout.xml | 2 +- ...torjson-cpuinfo-aarch64-clusters-cpus.json | 88 + ...json-cpuinfo-aarch64-clusters-hotplug.json | 171 ++ ...umonitorjson-cpuinfo-aarch64-clusters.data | 108 + tests/qemumonitorjsontest.c | 9 +- .../cpu-hotplug-startup.x86_64-latest.args | 2 +- .../cpu-numa-disjoint.x86_64-latest.args | 2 +- .../cpu-numa-disordered.x86_64-latest.args | 2 +- .../cpu-numa-memshared.x86_64-latest.args | 2 +- ...-numa-no-memory-element.x86_64-latest.args | 2 +- .../cpu-numa1.x86_64-latest.args | 2 +- .../cpu-numa2.x86_64-latest.args | 2 +- .../cpu-topology1.x86_64-latest.args | 2 +- .../cpu-topology2.x86_64-latest.args | 2 +- .../cpu-topology3.x86_64-latest.args | 2 +- .../cpu-topology4.x86_64-latest.args | 2 +- ...args => cpu-topology5.aarch64-latest.args} | 12 +- tests/qemuxml2argvdata/cpu-topology5.xml | 17 + ...memory-no-numa-topology.x86_64-latest.args | 2 +- .../fd-memory-no-numa-topology.xml | 2 +- ...fd-memory-numa-topology.x86_64-latest.args | 2 +- .../fd-memory-numa-topology.xml | 2 +- ...d-memory-numa-topology2.x86_64-latest.args | 2 +- .../fd-memory-numa-topology2.xml | 2 +- ...d-memory-numa-topology3.x86_64-latest.args | 2 +- .../fd-memory-numa-topology3.xml | 2 +- .../hugepages-nvdimm.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/hugepages-nvdimm.xml | 2 +- ...memory-default-hugepage.x86_64-latest.args | 2 +- .../memfd-memory-default-hugepage.xml | 2 +- .../memfd-memory-numa.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/memfd-memory-numa.xml | 2 +- ...emory-hotplug-dimm-addr.x86_64-latest.args | 2 +- .../memory-hotplug-dimm.x86_64-latest.args | 2 +- ...memory-hotplug-multiple.x86_64-latest.args | 2 +- ...y-hotplug-nvdimm-access.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-access.xml | 2 +- ...ry-hotplug-nvdimm-align.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-align.xml | 2 +- ...ry-hotplug-nvdimm-label.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-label.xml | 2 +- ...ory-hotplug-nvdimm-pmem.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-pmem.xml | 2 +- ...-nvdimm-ppc64-abi-update.ppc64-latest.args | 2 +- ...ory-hotplug-nvdimm-ppc64.ppc64-latest.args | 2 +- ...hotplug-nvdimm-readonly.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-readonly.xml | 2 +- .../memory-hotplug-nvdimm.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm.xml | 2 +- ...mory-hotplug-virtio-mem.x86_64-latest.args | 2 +- .../memory-hotplug-virtio-mem.xml | 2 +- ...ory-hotplug-virtio-pmem.x86_64-latest.args | 2 +- .../memory-hotplug-virtio-pmem.xml | 2 +- .../memory-hotplug.x86_64-latest.args | 2 +- ...auto-memory-vcpu-cpuset.x86_64-latest.args | 2 +- ...no-cpuset-and-placement.x86_64-latest.args | 2 +- ...d-auto-vcpu-no-numatune.x86_64-latest.args | 2 +- ...to-vcpu-static-numatune.x86_64-latest.args | 2 +- ...static-memory-auto-vcpu.x86_64-latest.args | 2 +- ...static-vcpu-no-numatune.x86_64-latest.args | 2 +- .../qemuxml2argvdata/numad.x86_64-latest.args | 2 +- ...ne-auto-nodeset-invalid.x86_64-latest.args | 2 +- .../pci-expander-bus.x86_64-latest.args | 2 +- .../pcie-expander-bus.x86_64-latest.args | 2 +- .../pseries-phb-numa-node.ppc64-latest.args | 2 +- tests/qemuxml2argvtest.c | 1 + .../cpu-numa-disjoint.x86_64-latest.xml | 2 +- .../cpu-numa-disordered.x86_64-latest.xml | 2 +- .../cpu-numa-memshared.x86_64-latest.xml | 2 +- ...u-numa-no-memory-element.x86_64-latest.xml | 2 +- .../cpu-numa1.x86_64-latest.xml | 2 +- .../cpu-numa2.x86_64-latest.xml | 2 +- ...memory-hotplug-dimm-addr.x86_64-latest.xml | 2 +- .../memory-hotplug-dimm.x86_64-latest.xml | 2 +- .../memory-hotplug-multiple.x86_64-latest.xml | 2 +- ...g-nvdimm-ppc64-abi-update.ppc64-latest.xml | 2 +- ...mory-hotplug-nvdimm-ppc64.ppc64-latest.xml | 2 +- .../memory-hotplug.x86_64-latest.xml | 2 +- ...-auto-memory-vcpu-cpuset.x86_64-latest.xml | 2 +- ...-no-cpuset-and-placement.x86_64-latest.xml | 2 +- ...ad-auto-vcpu-no-numatune.x86_64-latest.xml | 2 +- ...-static-vcpu-no-numatune.x86_64-latest.xml | 2 +- .../pci-expander-bus.x86_64-latest.xml | 2 +- .../pcie-expander-bus.x86_64-latest.xml | 2 +- .../pseries-phb-numa-node.ppc64-latest.xml | 2 +- .../linux-basic-clusters/system/cpu | 1 + .../linux-basic-clusters/system/node | 1 + .../vircaps-aarch64-basic-clusters.xml | 255 +++ .../vircaps2xmldata/vircaps-aarch64-basic.xml | 32 +- .../vircaps-x86_64-basic-dies.xml | 24 +- .../vircaps2xmldata/vircaps-x86_64-basic.xml | 32 +- .../vircaps2xmldata/vircaps-x86_64-caches.xml | 16 +- tests/vircaps2xmldata/vircaps-x86_64-hmat.xml | 48 +- .../vircaps-x86_64-resctrl-cdp.xml | 24 +- .../vircaps-x86_64-resctrl-cmt.xml | 24 +- .../vircaps-x86_64-resctrl-fake-feature.xml | 24 +- .../vircaps-x86_64-resctrl-skx-twocaches.xml | 2 +- .../vircaps-x86_64-resctrl-skx.xml | 2 +- .../vircaps-x86_64-resctrl.xml | 24 +- tests/vircaps2xmltest.c | 1 + .../linux-aarch64-with-clusters.cpuinfo | 2016 +++++++++++++++++ .../linux-aarch64-with-clusters.expected | 1 + .../cpu/cpu0/topology/cluster_cpus | 1 + .../cpu/cpu0/topology/cluster_cpus_list | 1 + .../cpu/cpu0/topology/cluster_id | 1 + .../cpu/cpu0/topology/core_cpus | 1 + .../cpu/cpu0/topology/core_cpus_list | 1 + .../cpu/cpu0/topology/core_id | 1 + .../cpu/cpu0/topology/core_siblings | 1 + .../cpu/cpu0/topology/core_siblings_list | 1 + .../cpu/cpu0/topology/package_cpus | 1 + .../cpu/cpu0/topology/package_cpus_list | 1 + .../cpu/cpu0/topology/physical_package_id | 1 + .../cpu/cpu0/topology/thread_siblings | 1 + .../cpu/cpu0/topology/thread_siblings_list | 1 + [...] tests/virhostcputest.c | 1 + tests/vmx2xmldata/esx-in-the-wild-10.xml | 2 +- tests/vmx2xmldata/esx-in-the-wild-8.xml | 2 +- tests/vmx2xmldata/esx-in-the-wild-9.xml | 2 +- 3303 files changed, 6180 insertions(+), 262 deletions(-) create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-aarch64-clusters-cpus.json create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-aarch64-clusters-hotplug.json create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-aarch64-clusters.data copy tests/qemuxml2argvdata/{cpu-topology2.x86_64-latest.args => cpu-topology5.aarch64-latest.args} (69%) create mode 100644 tests/qemuxml2argvdata/cpu-topology5.xml create mode 120000 tests/vircaps2xmldata/linux-basic-clusters/system/cpu create mode 120000 tests/vircaps2xmldata/linux-basic-clusters/system/node create mode 100644 tests/vircaps2xmldata/vircaps-aarch64-basic-clusters.xml create mode 100644 tests/virhostcpudata/linux-aarch64-with-clusters.cpuinfo create mode 100644 tests/virhostcpudata/linux-aarch64-with-clusters.expected create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu0/topology/cluster_cpus create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu0/topology/cluster_cpus_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu0/topology/cluster_id create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu0/topology/core_cpus create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu0/topology/core_cpus_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu0/topology/core_id create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu0/topology/core_siblings create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu0/topology/core_siblings_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu0/topology/package_cpus create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu0/topology/package_cpus_list create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu0/topology/physical_package_id create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu0/topology/thread_siblings create mode 100644 tests/virhostcpudata/linux-with-clusters/cpu/cpu0/topology/thread_siblings_list [...] -- 2.43.0

2 28

[PATCH] virsh: Command completion, add comp-methods with zlib and zstd
by Yalei Li 11 Jan '24

11 Jan '24

Signed-off-by: Yalei Li <liyl43(a)chinatelecom.cn> --- tools/virsh-completer-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c index b54baf3577..2891d1399c 100644 --- a/tools/virsh-completer-domain.c +++ b/tools/virsh-completer-domain.c @@ -1012,7 +1012,7 @@ virshDomainMigrateCompMethodsCompleter(vshControl *ctl, const vshCmd *cmd, unsigned int flags) { - const char *methods[] = {"xbzrle", "mt", NULL}; + const char *methods[] = {"xbzrle", "mt", "zlib", "zstd", NULL}; const char *method = NULL; virCheckFlags(0, NULL); -- 2.27.0

2 1

[PATCH 0/4] Prepare webpage for hosting via gitlab pages
by Peter Krempa 10 Jan '24

10 Jan '24

As the progress on the gitlab feature we need to do this seems good: https://gitlab.com/gitlab-org/gitlab-pages/-/issues/601 this series prepares the libvirt project to do the hosting and will allow us to validate it before switching over once the feature is enabled. Patches 1/4 and 2/4 can be pushed right away: - Patch 1/4 prepares the job to publish the page (currently via the libvirt.gitlab.io/libvirt URL each project gets automatically - Patch 2/4 adds the '_redirects' file which is populated from adapted 'mod_rewrite' rules from the current server. This file serves for validation of the rules and will allow us to validate them before switching over The last 2 patches are for the subsequent steps: - 3/4 removes the 'legacy' webpage job, this can be pushed either when we switch over to gitlab pages or when the old server will fetch the archive from the new artifacts file - 4/4 will be needed right before swithching over to gitlab pages as the redirects will need to be adapted for custom domain hosting The new 'pages' artifact from a CI run of this series can be viewed at: https://gitlab.com/pipo.sk/libvirt/-/jobs/5900957150 The 'redirect' validation (from an older version of this series) can be viewed at: https://pipo.sk.gitlab.io/libvirt/_redirects (beware that this will cause a certificate failure, as gitlab pages doesn't work well if you have a dot in your username ...) Peter Krempa (4): gitlab-ci: Configure website build to be published via gitlab pages docs: Add redirects configuration for gitlab pages gitlab-ci: Drop the legacy web page job docs: gitlab redirects: Drop '/libvirt' prefix for hosting the web through gitlab pages .gitlab-ci.yml | 80 +++++++++++++++++++++++++++++++++--------- docs/.gitlab_redirects | 54 ++++++++++++++++++++++++++++ 2 files changed, 117 insertions(+), 17 deletions(-) create mode 100644 docs/.gitlab_redirects -- 2.43.0

2 6

[PATCH v2 0/4] Introduce dynamicMemslots attribute for virtio-mem
by Michal Privoznik 10 Jan '24

10 Jan '24

v2 of: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/MWYG… diff to v1: - Don't set .unplugged-inaccessible because it's not compatible with !x84_64 and even on x86_64 it's likely to get deprecated soon. Thanks David for pointing this out! Michal Prívozník (4): conf: Introduce dynamicMemslots attribute for virtio-mem qemu_capabilities: Add QEMU_CAPS_DEVICE_VIRTIO_MEM_PCI_DYNAMIC_MEMSLOTS capability qemu_validate: Check capability for virtio-mem dynamicMemslots qemu_command: Generate cmd line for virtio-mem dynamicMemslots docs/formatdomain.rst | 6 ++++++ src/conf/domain_conf.c | 18 +++++++++++++++++- src/conf/domain_conf.h | 1 + src/conf/schemas/domaincommon.rng | 5 +++++ src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 3 +++ src/qemu/qemu_validate.c | 7 +++++++ .../qemucapabilitiesdata/caps_8.2.0_x86_64.xml | 1 + ...emory-hotplug-virtio-mem.x86_64-latest.args | 2 +- .../memory-hotplug-virtio-mem.xml | 2 +- 11 files changed, 45 insertions(+), 3 deletions(-) -- 2.41.0

4 19

[PATCH v2 00/14] Unreacheble code cleanup
by Dmitry Frolov 10 Jan '24

10 Jan '24

A lot of unreacheble code was caused by int functions, which return nothing except zero. Unreacheble code was removed. Corresponding functions type was changed to void. Dmitry Frolov (14): cpu: turn virCPUx86DataAddItem() to void cpu: turn virCPUx86DataAdd() to void libxl: turn libxlCapsAddCPUID() to void libxl: turn virCapabilitiesAddHostFeature() to void libxl: turn libxl_get_physinfo() to void conf: turn virCapabilitiesSetNetPrefix() to void libxl: turn libxlMakeDomainOSCaps() to void libxl: turn libxlMakeDomainDeviceDiskCaps() to void libxl: turn libxlMakeDomainDeviceGraphicsCaps() to void libxl: turn libxlMakeDomainDeviceVideoCaps() to void conf: turn virDomainGraphicsListenAppendAddress() to void vbox: turn vboxDumpDisplay() to void libxl: turn xenParseXLNamespaceData() to void rpc: turn virNetClientAddProgram() to void src/admin/admin_remote.c | 3 +- src/conf/capabilities.c | 8 +-- src/conf/capabilities.h | 4 +- src/conf/domain_conf.c | 4 +- src/conf/domain_conf.h | 2 +- src/cpu/cpu_x86.c | 91 ++++++++++++--------------------- src/cpu/cpu_x86.h | 2 +- src/libxl/libxl_capabilities.c | 54 +++++++------------ src/libxl/libxl_conf.c | 20 ++------ src/libxl/libxl_driver.c | 6 +-- src/libxl/xen_common.c | 7 +-- src/libxl/xen_xl.c | 8 ++- src/locking/lock_driver_lockd.c | 3 +- src/logging/log_manager.c | 3 +- src/lxc/lxc_monitor.c | 4 +- src/remote/remote_driver.c | 7 ++- src/rpc/virnetclient.c | 3 +- src/rpc/virnetclient.h | 2 +- src/test/test_driver.c | 6 +-- src/vbox/vbox_common.c | 13 ++--- src/vmx/vmx.c | 3 +- tests/libxlmock.c | 5 +- 22 files changed, 86 insertions(+), 172 deletions(-) -- 2.34.1

4 55

Re: Re: Re: [libvirt PATCH V2 0/4] add loongarch support for libvirt
by Andrea Bolognani 10 Jan '24

10 Jan '24

On Tue, Jan 09, 2024 at 01:25:16AM -0800, Andrea Bolognani wrote: > On Tue, Jan 09, 2024 at 09:51:59AM +0800, lixianglai wrote: > > Hi Andrea: > > > > I'm so sorry to bother you. > > > > I modified the code according to your suggestion and sent the second version > > of patch to the community, > > > > but I did not find it in the mailing list, I am not sure whether I have > > successfully sent it to the community, > > > > so I would like to confirm that you can receive the email of the second > > version of patch I sent? > > > > Under normal circumstances, can I see the patch I sent in the link below? > > > > https://lists.libvirt.org/archives/list/devel@lists.libvirt.org > > Yeah, it's supposed to show up there as well as in the month view[1] > but I can't see it. I haven't received a copy in my inbox either. > > It looks like something went wrong. Normally my first guess would be > that the messages are held up in the moderation queue, but I've > confirmed with the list admin that was not the case here. > > I'd say maybe give it a bit more time just in case things are > temporarily stuck in between servers, then send the patches again. > Worst case scenario, we're going to get two copies, no big deal :) I think I might have spotted the problem. You probably sent the patches to the old mailing list address (libvir-list(a)redhat.com) instead of the new one (devel(a)lists.libvirt.org) You should have gotten a message back telling you about it (I just did, which is how I noticed) but I've found those notifications to be somewhat hit and miss in the past. Just send the patches to the new address and they should make it to the list. If you use git-publish, it should automatically pick the right address. -- Andrea Bolognani / Red Hat / Virtualization

2 1

[PATCH] qemu: Be less aggressive when dropping channel source paths
by Michal Privoznik 09 Jan '24

09 Jan '24

In v9.7.0-rc1~130 I've shortened the path that's generated for <channel/> source. With that, I had to adjust regex that matches all versions of paths we have ever generated so that we can drop them (see comment around qemuDomainChrDefDropDefaultPath()). But as it is usually the case with regexes - they are write only. And while I attempted to make one portion of the path optional ("/target/") I accidentally made regex accept more, which resulted in libvirt dropping the user provided path and generating our own instead. Fixes: d3759d3674ab9453e5fb5a27ab6c28b8ff8d5569 Resolves: https://issues.redhat.com/browse/RHEL-20807 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_domain.c | 2 +- ...hannel-unix-source-path.x86_64-latest.args | 8 ++++++++ .../channel-unix-source-path.xml | 16 +++++++++++++++ ...-unix-source-path-active.x86_64-latest.xml | 20 +++++++++++++++++++ ...nix-source-path-inactive.x86_64-latest.xml | 20 +++++++++++++++++++ 5 files changed, 65 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 003fe7c71b..3a00fb689e 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -5447,7 +5447,7 @@ qemuDomainChrMatchDefaultPath(const char *prefix, virBufferEscapeRegex(&buf, "^%s", prefix); if (infix) virBufferEscapeRegex(&buf, "%s", infix); - virBufferAddLit(&buf, "/(target/)?([^/]+\\.)|(domain-[^/]+/)|([0-9]+-[^/]+/)"); + virBufferAddLit(&buf, "/(target/)?(([^/]+\\.)|(domain-[^/]+/)|([0-9]+-[^/]+/))"); virBufferEscapeRegex(&buf, "%s$", target); regexp = virBufferContentAndReset(&buf); diff --git a/tests/qemuxml2argvdata/channel-unix-source-path.x86_64-latest.args b/tests/qemuxml2argvdata/channel-unix-source-path.x86_64-latest.args index 821a508a40..845236d286 100644 --- a/tests/qemuxml2argvdata/channel-unix-source-path.x86_64-latest.args +++ b/tests/qemuxml2argvdata/channel-unix-source-path.x86_64-latest.args @@ -40,6 +40,14 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.config \ -device '{"driver":"virtserialport","bus":"virtio-serial0.0","nr":5,"chardev":"charchannel4","id":"channel4","name":"org.qemu.guest_agent.4"}' \ -chardev socket,id=charchannel5,fd=1729,server=on,wait=off \ -device '{"driver":"virtserialport","bus":"virtio-serial0.0","nr":6,"chardev":"charchannel5","id":"channel5","name":"org.qemu.guest_agent.5"}' \ +-chardev socket,id=charchannel6,fd=1729,server=on,wait=off \ +-device '{"driver":"virtserialport","bus":"virtio-serial0.0","nr":7,"chardev":"charchannel6","id":"channel6","name":"org.qemu.guest_agent.6"}' \ +-chardev socket,id=charchannel7,fd=1729,server=on,wait=off \ +-device '{"driver":"virtserialport","bus":"virtio-serial0.0","nr":8,"chardev":"charchannel7","id":"channel7","name":"org.qemu.guest_agent.7"}' \ +-chardev socket,id=charchannel8,fd=1729,server=on,wait=off \ +-device '{"driver":"virtserialport","bus":"virtio-serial0.0","nr":9,"chardev":"charchannel8","id":"channel8","name":"org.qemu.guest_agent.8"}' \ +-chardev socket,id=charchannel9,fd=1729,server=on,wait=off \ +-device '{"driver":"virtserialport","bus":"virtio-serial0.0","nr":10,"chardev":"charchannel9","id":"channel9","name":"org.qemu.guest_agent.9"}' \ -audiodev '{"id":"audio1","driver":"none"}' \ -sandbox on,obsolete=deny,elevateprivileges=deny,spawn=deny,resourcecontrol=deny \ -msg timestamp=on diff --git a/tests/qemuxml2argvdata/channel-unix-source-path.xml b/tests/qemuxml2argvdata/channel-unix-source-path.xml index df548d88e7..265971eb94 100644 --- a/tests/qemuxml2argvdata/channel-unix-source-path.xml +++ b/tests/qemuxml2argvdata/channel-unix-source-path.xml @@ -32,6 +32,22 @@ <source mode='bind' path='/var/run/libvirt/qemu/channel/1-QEMUGuest1/org.qemu.guest_agent.5'/> <target type='virtio' name='org.qemu.guest_agent.5'/> </channel> + <channel type="unix"> + <source mode="bind" path="/1-QEMUGuest1/org.qemu.guest_agent.6"/> + <target type="virtio" name="org.qemu.guest_agent.6" state="connected"/> + </channel> + <channel type="unix"> + <source mode="bind" path="/tmp/1-QEMUGuest1/org.qemu.guest_agent.7"/> + <target type="virtio" name="org.qemu.guest_agent.7" state="connected"/> + </channel> + <channel type="unix"> + <source mode="bind" path="/tmp/libvirt/qemu/channel/1-QEMUGuest1/org.qemu.guest_agent.8"/> + <target type="virtio" name="org.qemu.guest_agent.8" state="connected"/> + </channel> + <channel type="unix"> + <source mode="bind" path="/tmp/org.qemu.guest_agent.9"/> + <target type="virtio" name="org.qemu.guest_agent.9" state="connected"/> + </channel> <memballoon model='none'/> </devices> </domain> diff --git a/tests/qemuxml2xmloutdata/channel-unix-source-path-active.x86_64-latest.xml b/tests/qemuxml2xmloutdata/channel-unix-source-path-active.x86_64-latest.xml index 022ad7025a..12a981438c 100644 --- a/tests/qemuxml2xmloutdata/channel-unix-source-path-active.x86_64-latest.xml +++ b/tests/qemuxml2xmloutdata/channel-unix-source-path-active.x86_64-latest.xml @@ -54,6 +54,26 @@ <target type='virtio' name='org.qemu.guest_agent.5'/> <address type='virtio-serial' controller='0' bus='0' port='6'/> </channel> + <channel type='unix'> + <source mode='bind' path='/1-QEMUGuest1/org.qemu.guest_agent.6'/> + <target type='virtio' name='org.qemu.guest_agent.6'/> + <address type='virtio-serial' controller='0' bus='0' port='7'/> + </channel> + <channel type='unix'> + <source mode='bind' path='/tmp/1-QEMUGuest1/org.qemu.guest_agent.7'/> + <target type='virtio' name='org.qemu.guest_agent.7'/> + <address type='virtio-serial' controller='0' bus='0' port='8'/> + </channel> + <channel type='unix'> + <source mode='bind' path='/tmp/libvirt/qemu/channel/1-QEMUGuest1/org.qemu.guest_agent.8'/> + <target type='virtio' name='org.qemu.guest_agent.8'/> + <address type='virtio-serial' controller='0' bus='0' port='9'/> + </channel> + <channel type='unix'> + <source mode='bind' path='/tmp/org.qemu.guest_agent.9'/> + <target type='virtio' name='org.qemu.guest_agent.9'/> + <address type='virtio-serial' controller='0' bus='0' port='10'/> + </channel> <input type='mouse' bus='ps2'/> <input type='keyboard' bus='ps2'/> <audio id='1' type='none'/> diff --git a/tests/qemuxml2xmloutdata/channel-unix-source-path-inactive.x86_64-latest.xml b/tests/qemuxml2xmloutdata/channel-unix-source-path-inactive.x86_64-latest.xml index 3b013e9f87..2315a572e4 100644 --- a/tests/qemuxml2xmloutdata/channel-unix-source-path-inactive.x86_64-latest.xml +++ b/tests/qemuxml2xmloutdata/channel-unix-source-path-inactive.x86_64-latest.xml @@ -49,6 +49,26 @@ <target type='virtio' name='org.qemu.guest_agent.5'/> <address type='virtio-serial' controller='0' bus='0' port='6'/> </channel> + <channel type='unix'> + <source mode='bind' path='/1-QEMUGuest1/org.qemu.guest_agent.6'/> + <target type='virtio' name='org.qemu.guest_agent.6'/> + <address type='virtio-serial' controller='0' bus='0' port='7'/> + </channel> + <channel type='unix'> + <source mode='bind' path='/tmp/1-QEMUGuest1/org.qemu.guest_agent.7'/> + <target type='virtio' name='org.qemu.guest_agent.7'/> + <address type='virtio-serial' controller='0' bus='0' port='8'/> + </channel> + <channel type='unix'> + <source mode='bind' path='/tmp/libvirt/qemu/channel/1-QEMUGuest1/org.qemu.guest_agent.8'/> + <target type='virtio' name='org.qemu.guest_agent.8'/> + <address type='virtio-serial' controller='0' bus='0' port='9'/> + </channel> + <channel type='unix'> + <source mode='bind' path='/tmp/org.qemu.guest_agent.9'/> + <target type='virtio' name='org.qemu.guest_agent.9'/> + <address type='virtio-serial' controller='0' bus='0' port='10'/> + </channel> <input type='mouse' bus='ps2'/> <input type='keyboard' bus='ps2'/> <audio id='1' type='none'/> -- 2.41.0

2 1

[PATCH 0/2] ci: Update to Fedora 39
by Michal Privoznik 09 Jan '24

09 Jan '24

Green pipeline: https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1106643445 Michal Prívozník (2): ci: integration: Switch upstream integration tests to Fedora 39 ci: Update Alpine and Fedora and regenerate ci/buildenv/{alpine-317.sh => alpine-319.sh} | 0 ci/buildenv/{fedora-37.sh => fedora-39.sh} | 0 ...e-317.Dockerfile => alpine-319.Dockerfile} | 2 +- ...ora-37.Dockerfile => fedora-39.Dockerfile} | 2 +- ci/gitlab/builds.yml | 64 +++++++-------- ci/gitlab/containers.yml | 18 ++--- ci/integration.yml | 80 +++++++++---------- ci/manifest.yml | 18 ++--- 8 files changed, 92 insertions(+), 92 deletions(-) rename ci/buildenv/{alpine-317.sh => alpine-319.sh} (100%) rename ci/buildenv/{fedora-37.sh => fedora-39.sh} (100%) rename ci/containers/{alpine-317.Dockerfile => alpine-319.Dockerfile} (98%) rename ci/containers/{fedora-37.Dockerfile => fedora-39.Dockerfile} (98%) -- 2.41.0

6 15

[PATCH v2 0/2] Deprecate the shix machine and the TC58128 flash device
by Samuel Tardieu 09 Jan '24

09 Jan '24

The shix machine was a research project started around 2003 at Télécom Paris. Preliminary support in QEMU was added in 2005 back when the QEMU architecture was less structured than it is now. Unfortunately, the support for the shix machine and its peripherals, such as the TC58128 16MiB flash device, has never been maintained as the research project used the real machine. This project stopped around 2010 and to the best of my knowledge and after consulting with the original author Alexis Polti, I propose to deprecate it in QEMU as well as the TC58128 flash device which does not implement the QOM model and still contains debug fprintf statements. Samuel Tardieu (2): target/sh4: Deprecate the shix machine hw/block: Deprecate the TC58128 block device docs/about/deprecated.rst | 5 +++++ hw/block/tc58128.c | 1 + hw/sh4/shix.c | 1 + 3 files changed, 7 insertions(+) -- 2.42.0

2 4

[PATCH] qemu: tighten semantics of 'size' when resizing block devices
by Daniel P. Berrangé 09 Jan '24

09 Jan '24

When VIR_DOMAIN_BLOCK_RESIZE_CAPACITY is set, the 'size' parameter is currently ignored. Since applications must none the less pass a value for this parameter, it is preferrable to declare some explicit semantics for it. This declare that the parameter must be 0, or the exact size of the underlying block device. The latter gives the management application the ability to sanity check that the block device size matches what they think it should be. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/libvirt-domain.c | 5 +++-- src/qemu/qemu_driver.c | 9 ++++++++- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 94e5672ed8..83abad251e 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -6389,8 +6389,9 @@ virDomainBlockPeek(virDomainPtr dom, * to the next alignment boundary. * * If @flag contains VIR_DOMAIN_BLOCK_RESIZE_CAPACITY (since 10.0.0) the - * hypervisor will resize the guest block device to fully fill the source, - * ignoring @size. This is possible only for image formats with no metadata + * hypervisor will resize the guest block device to fully fill the source. + * @size must be either set to zero, or to the exact size of the block + * device source. This is possible only for image formats with no metadata * ('raw') and for source devices with limited capacity such as block devices. * * The @disk parameter is either an unambiguous source name of the diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 49bc4a624d..8e529f97b5 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -9325,7 +9325,14 @@ qemuDomainBlockResize(virDomainPtr dom, goto endjob; } - size = disk->src->physical; + if (size == 0) { + size = disk->src->physical; + } else if (size != disk->src->physical) { + virReportError(VIR_ERR_INVALID_ARG, + _("block resize to full capacity %llu but validate size is %llu"), + size, disk->src->physical); + goto endjob; + } } /* qcow2 and qed must be sized on 512 byte blocks/sectors, -- 2.43.0

2 2

[PATCH 0/2] tests: Add capabilities for QEMU 8.2.0 on aarch64
by Andrea Bolognani 09 Jan '24

09 Jan '24

Edited for brevity. Full version: $ git fetch https://gitlab.com/abologna/libvirt.git qemu-caps Andrea Bolognani (2): tests: Don't use features with vexpress machine tests: Add capabilities for QEMU 8.2.0 on aarch64 .../qemu_8.2.0-virt.aarch64.xml | 227 + tests/domaincapsdata/qemu_8.2.0.aarch64.xml | 227 + .../caps_8.2.0_aarch64.replies | 36411 ++++++++++++++++ .../caps_8.2.0_aarch64.xml | 549 + ...ch64-aavmf-virtio-mmio.aarch64-latest.args | 5 +- ...arch64-cpu-passthrough.aarch64-latest.args | 3 +- ...fault-cpu-kvm-virt-4.2.aarch64-latest.args | 3 +- ...fault-cpu-tcg-virt-4.2.aarch64-latest.args | 3 +- .../aarch64-features-sve.aarch64-latest.args | 3 +- ...rch64-gic-default-both.aarch64-latest.args | 3 +- ...aarch64-gic-default-v2.aarch64-latest.args | 3 +- ...aarch64-gic-default-v3.aarch64-latest.args | 3 +- .../aarch64-gic-default.aarch64-latest.args | 3 +- .../aarch64-gic-host.aarch64-latest.args | 3 +- .../aarch64-gic-none-both.aarch64-latest.args | 3 +- .../aarch64-gic-none-tcg.aarch64-latest.args | 3 +- .../aarch64-gic-none-v2.aarch64-latest.args | 3 +- .../aarch64-gic-none-v3.aarch64-latest.args | 3 +- .../aarch64-gic-none.aarch64-latest.args | 3 +- .../aarch64-gic-v2.aarch64-latest.args | 3 +- .../aarch64-gic-v3.aarch64-latest.args | 3 +- .../aarch64-kvm-32-on-64.aarch64-latest.args | 4 +- .../aarch64-pci-serial.aarch64-latest.args | 3 +- .../aarch64-tpm.aarch64-latest.args | 3 +- ...arch64-traditional-pci.aarch64-latest.args | 3 +- ...aarch64-usb-controller.aarch64-latest.args | 3 +- .../aarch64-video-default.aarch64-latest.args | 3 +- ...4-video-virtio-gpu-pci.aarch64-latest.args | 5 +- ...rch64-virt-default-nic.aarch64-latest.args | 5 +- .../aarch64-virt-graphics.aarch64-latest.args | 4 +- .../aarch64-virt-headless.aarch64-latest.args | 4 +- ...rch64-virt-virtio-MMIO.aarch64.latest.args | 5 +- .../aarch64-virt-virtio.aarch64-latest.args | 5 +- ...h64-virtio-pci-default.aarch64-latest.args | 5 +- ...o-pci-manual-addresses.aarch64-latest.args | 7 +- .../arm-vexpressa9-basic.aarch64-latest.args | 2 +- .../qemuxml2argvdata/arm-vexpressa9-basic.xml | 5 - .../arm-vexpressa9-nodevs.xml | 5 - .../arm-vexpressa9-virtio.aarch64-latest.args | 2 +- .../arm-vexpressa9-virtio.xml | 5 - .../arm-virt-virtio.aarch64-latest.args | 4 +- .../balloon-mmio-deflate.aarch64-latest.args | 3 +- .../clock-timer-armvtimer.aarch64-latest.args | 3 +- ...ult-video-type-aarch64.aarch64-latest.args | 3 +- .../disk-arm-virtio-sd.aarch64-latest.args | 1 - ...mware-auto-efi-aarch64.aarch64-latest.args | 2 +- ...efi-abi-update-aarch64.aarch64-latest.args | 2 +- ...-loader-raw-abi-update.aarch64-latest.args | 2 +- ...-efi-format-loader-raw.aarch64-latest.args | 2 +- ...i-aarch64-legacy-paths.aarch64-latest.args | 2 +- ...anual-efi-acpi-aarch64.aarch64-latest.args | 2 +- ...ual-efi-noacpi-aarch64.aarch64-latest.args | 3 +- ...l-noefi-noacpi-aarch64.aarch64-latest.args | 3 +- .../iommu-smmuv3.aarch64-latest.args | 3 +- ...ch-virt-console-native.aarch64-latest.args | 3 +- ...ch-virt-console-virtio.aarch64-latest.args | 3 +- ...-serial+console-native.aarch64-latest.args | 3 +- ...ach-virt-serial-compat.aarch64-latest.args | 3 +- ...ach-virt-serial-native.aarch64-latest.args | 3 +- .../mach-virt-serial-pci.aarch64-latest.args | 3 +- .../mach-virt-serial-usb.aarch64-latest.args | 3 +- ...e-expander-bus-aarch64.aarch64-latest.args | 3 +- .../pvpanic-pci-aarch64.aarch64-latest.args | 2 +- ...pci-no-address-aarch64.aarch64-latest.args | 2 +- .../virtio-iommu-aarch64.aarch64-latest.args | 2 +- 65 files changed, 37483 insertions(+), 127 deletions(-) create mode 100644 tests/domaincapsdata/qemu_8.2.0-virt.aarch64.xml create mode 100644 tests/domaincapsdata/qemu_8.2.0.aarch64.xml create mode 100644 tests/qemucapabilitiesdata/caps_8.2.0_aarch64.replies create mode 100644 tests/qemucapabilitiesdata/caps_8.2.0_aarch64.xml -- 2.43.0

3 7

[PATCH 0/2] Deprecate the shix machine and the TC58128 flash device
by Samuel Tardieu 09 Jan '24

09 Jan '24

The shix machine was a research project started around 2003 at Télécom Paris. Preliminary support in QEMU was added in 2005 back when the QEMU architecture was less structured than it is now. Unfortunately, the support for the shix machine and its peripherals, such as the TC58128 16MiB flash device, has never been maintained as the research project used the real machine. This project stopped around 2010 and to the best of my knowledge and after consulting with the original author Alexis Polti, I propose to deprecate it in QEMU as well as the TC58128 flash device which does not implement the QOM model and still contains debug fprintf statements. Samuel Tardieu (2): target/sh4: Deprecate the shix machine hw/block: Deprecate the TC58128 block device docs/about/deprecated.rst | 5 +++++ hw/block/tc58128.c | 1 + hw/sh4/shix.c | 1 + 3 files changed, 7 insertions(+) -- 2.42.0

4 7

[libvirt PATCH 0/6] qemu: Enable postcopy-preempt migration capability
by Jiri Denemark 08 Jan '24

08 Jan '24

This is technically a v2 of my recent "Introduce VIR_MIGRATE_POSTCOPY_PREEMPT flag", but the two series share exactly two lines of code (those defining a new QEMU_MIGRATION_CAP_POSTCOPY_PREEMPT enum item) so I'm just sending it as a separate series. More details about this feature can be found in patch 5/6. Jiri Denemark (6): qemu: Document qemuMigrationParamsFlagMapItem fields qemu: Use C99 initializers for qemuMigrationParamsFlagMap qemu: Rename remoteCaps parameter in qemuMigrationParamsCheck qemu: Add support for optional migration capabilities qemu: Enable postcopy-preempt migration capability NEWS: Mention postcopy-preempt migration capability NEWS.rst | 8 ++ src/qemu/qemu_migration.c | 19 +++-- src/qemu/qemu_migration_params.c | 127 ++++++++++++++++++++++--------- src/qemu/qemu_migration_params.h | 4 +- 4 files changed, 115 insertions(+), 43 deletions(-) -- 2.43.0

2 12

[libvirt PATCH 0/3] Introduce VIR_MIGRATE_POSTCOPY_PREEMPT flag
by Jiri Denemark 08 Jan '24

08 Jan '24

See 1/3 for details. https://issues.redhat.com/browse/RHEL-7100 Jiri Denemark (3): Introduce VIR_MIGRATE_POSTCOPY_PREEMPT flag virsh migrate: Add --postcopy-preempt option qemu_migration: Implement VIR_MIGRATE_POSTCOPY_PREEMPT docs/manpages/virsh.rst | 9 ++++++--- include/libvirt/libvirt-domain.h | 8 ++++++++ src/qemu/qemu_migration.c | 21 ++++++++++++++++++--- src/qemu/qemu_migration.h | 1 + src/qemu/qemu_migration_params.c | 6 ++++++ src/qemu/qemu_migration_params.h | 1 + tools/virsh-domain.c | 6 ++++++ 7 files changed, 46 insertions(+), 6 deletions(-) -- 2.43.0

3 7

[PATCH v3 00/13] Support for VFIO variant drivers, Part 2
by Laine Stump 05 Jan '24

05 Jan '24

This is "V3 of Part 2". "V2 of Part 2": is here: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/EVHM… Part 1 (which simply made it possible to use virsh nodedev-detach to bind a device to a manually-specified variant driver, and at guest runtime allowed libvirt to ignore the fact that the driver found to the device was something other than exactly "vfio-pci") was here: https://listman.redhat.com/archives/libvir-list/2023-August/241338.html and pushed upstream as of commit v9.6.0-153-g24beaffec3 Part 2 adds two new pieces of functionality: 1) It is possible to manually specify a VFIO variant driver (or force the generic vfio-pci driver) for a device in the domain XML with, e.g.: <driver name='mlx5_vfio_pci'/> (for the former) or: <driver name='vfio-pci'/> (for the latter). 2) By default libvirt will now find the "best match" VFIO or VFIO variant driver by comparing the device's modalias file contents (in sysfs) with vfio drivers found in the running kernel's modules.alias file. This means that "virsh nodedev-detach" of a host device will bind it to its appropriate VFIO variant driver (if one is available), and also if a <hostdev> decice in a domain config has "managed='yes'", libvirt will bind it to a variant driver if possible (in order to force binding to the basic vfio-pci driver instead, you just need to add the <driver> element mentioned above). Differences from V2 to V3: * I attempted to simplify my explanation of the confusion with module name vs. driver name that I had in the commit log of patch 1. * I think I've addressed all of the minor issues pointed out by Peter in his reviews V2 (joining unnecessarily split lines, failing when a modalias file can't be found (rather than "kind of" ignoring it), and other minor fixes. * The main difference between V2 and V3 is that I've relented on the issue of re-using the existing <driver name='blah'/> attribute (due to potential backwrd compatibility problems we might encounter), and am instead adding a new attribute <driver model='blah'/>. This means that both the driver name and the new driver model attribute names don't make as much sense, but that's what fancy GUI frontends are for -hiding the borderline-confusing names! * One change suggested by Peter that I enthusiastically agree with, but haven't implemented in V3 is to cache the few relevant lines of modules.alias rather than rereading the entire file each time. I do agree with him, but have run out of steam (and time) to implement it now - I do promise a followup with this functionality "soon". Patches 2-9 and 11 were already ACKed by Peter in V2 (several of them conditionally based on some minor fixes that I have made). This leaves only patches 1, 10, 12, and 13 that require an ACK (V2 had 15 patches, but I removed two of them). Laine Stump (13): util: properly deal with VFIO module name vs. driver name schema: consolidate RNG for all hostdev <driver> elements conf: move/rename hostdev PCI driver type enum to device_conf.h conf: normalize hostdev <driver> parsing to simplify adding new attr conf: put hostdev PCI backend into a struct conf: use virDeviceHostdevPCIDriverInfo in network and networkport objects conf: split out hostdev <driver> parse/format to their own functions conf: use new common parser/formatter for hostdev driver in network XML conf: replace virHostdevIsVFIODevice with virHostdevIsPCIDevice xen: explicitly set hostdev driver.name at runtime, not in postparse tests: remove explicit <driver name='vfio'/> from hostdev test cases conf: support manually specifying VFIO variant driver in <hostdev> XML qemu: automatically bind to a vfio variant driver, if available docs/formatdomain.rst | 55 ++- docs/formatnetwork.rst | 22 +- docs/formatnetworkport.rst | 1 - docs/pci-addresses.rst | 1 - src/conf/device_conf.c | 59 +++ src/conf/device_conf.h | 27 ++ src/conf/domain_capabilities.c | 2 +- src/conf/domain_capabilities.h | 2 +- src/conf/domain_conf.c | 98 +---- src/conf/domain_conf.h | 18 +- src/conf/network_conf.c | 42 +- src/conf/network_conf.h | 17 +- src/conf/schemas/basictypes.rng | 20 + src/conf/schemas/domaincommon.rng | 173 ++++---- src/conf/schemas/network.rng | 10 +- src/conf/schemas/networkport.rng | 10 +- src/conf/virconftypes.h | 2 + src/conf/virnetworkportdef.c | 22 +- src/conf/virnetworkportdef.h | 4 +- src/hypervisor/virhostdev.c | 16 +- src/hypervisor/virhostdev.h | 2 - src/libvirt_private.syms | 8 +- src/libxl/libxl_capabilities.c | 3 +- src/libxl/libxl_domain.c | 73 +++- src/libxl/libxl_driver.c | 25 +- src/network/bridge_driver.c | 3 +- src/qemu/qemu_capabilities.c | 4 +- src/qemu/qemu_command.c | 16 +- src/qemu/qemu_domain.c | 28 +- src/qemu/qemu_hostdev.c | 2 +- src/qemu/qemu_hotplug.c | 2 +- src/qemu/qemu_validate.c | 6 +- src/security/security_apparmor.c | 2 +- src/security/security_dac.c | 4 +- src/security/security_selinux.c | 4 +- src/security/virt-aa-helper.c | 7 +- src/test/test_driver.c | 18 +- src/util/virpci.c | 410 ++++++++++++++++-- src/util/virpci.h | 2 + tests/domaincapstest.c | 4 +- tests/libxlxml2domconfigdata/moredevs-hvm.xml | 1 - tests/networkxml2xmlin/hostdev-pf-old.xml | 8 + tests/networkxml2xmlin/hostdev-pf.xml | 1 - tests/networkxml2xmlout/hostdev-pf-old.xml | 8 + tests/networkxml2xmlout/hostdev-pf.xml | 1 - tests/networkxml2xmltest.c | 6 + .../qemuhotplug-hostdev-pci.xml | 1 - .../qemumemlock-pc-hardlimit+hostdev.xml | 1 - ...emumemlock-pc-hardlimit+locked+hostdev.xml | 1 - .../qemumemlock-pc-hostdev-nvme.xml | 1 - .../qemumemlock-pc-hostdev.xml | 1 - .../qemumemlock-pc-locked+hostdev.xml | 1 - .../qemumemlock-pseries-hardlimit+hostdev.xml | 1 - ...mlock-pseries-hardlimit+locked+hostdev.xml | 1 - .../qemumemlock-pseries-hostdev.xml | 1 - .../qemumemlock-pseries-locked+hostdev.xml | 1 - tests/qemustatusxml2xmldata/modern-in.xml | 1 - .../hostdev-pci-address-unassigned.xml | 4 - .../hostdev-pci-multifunction.xml | 7 - .../hostdev-vfio-multidomain.xml | 1 - .../hostdev-vfio-zpci-autogenerate-fids.xml | 2 - .../hostdev-vfio-zpci-autogenerate-uids.xml | 2 - .../hostdev-vfio-zpci-autogenerate.xml | 1 - .../hostdev-vfio-zpci-boundaries.xml | 2 - .../hostdev-vfio-zpci-ccw-memballoon.xml | 1 - .../hostdev-vfio-zpci-duplicate.xml | 2 - ...ostdev-vfio-zpci-invalid-uid-valid-fid.xml | 1 - .../hostdev-vfio-zpci-multidomain-many.xml | 8 - .../hostdev-vfio-zpci-set-zero.xml | 1 - .../hostdev-vfio-zpci-uid-set-zero.xml | 1 - .../hostdev-vfio-zpci-wrong-arch.xml | 1 - tests/qemuxml2argvdata/hostdev-vfio-zpci.xml | 1 - .../hostdev-vfio.x86_64-latest.args | 5 +- tests/qemuxml2argvdata/hostdev-vfio.xml | 19 +- .../net-hostdev-vfio-multidomain.xml | 1 - tests/qemuxml2argvdata/net-hostdev-vfio.xml | 1 - tests/qemuxml2argvdata/pseries-hostdevs-1.xml | 3 - tests/qemuxml2argvdata/pseries-hostdevs-2.xml | 2 - tests/qemuxml2argvdata/pseries-hostdevs-3.xml | 2 - ...v-pci-address-unassigned.x86_64-latest.xml | 4 - ...ostdev-pci-multifunction.x86_64-latest.xml | 7 - ...dev-vfio-old-driver-name.x86_64-latest.xml | 46 ++ ...io-zpci-autogenerate-fids.s390x-latest.xml | 2 - ...io-zpci-autogenerate-uids.s390x-latest.xml | 2 - ...ev-vfio-zpci-autogenerate.s390x-latest.xml | 1 - ...tdev-vfio-zpci-boundaries.s390x-latest.xml | 2 - ...-vfio-zpci-ccw-memballoon.s390x-latest.xml | 1 - ...fio-zpci-multidomain-many.s390x-latest.xml | 8 - .../hostdev-vfio-zpci.s390x-latest.xml | 1 - .../hostdev-vfio.x86_64-latest.xml | 24 +- .../net-hostdev-vfio.x86_64-latest.xml | 1 - .../pseries-hostdevs-1.ppc64-latest.xml | 3 - .../pseries-hostdevs-2.ppc64-latest.xml | 2 - .../pseries-hostdevs-3.ppc64-latest.xml | 2 - tests/virhostdevtest.c | 2 +- .../plug-hostdev-pci-unmanaged.xml | 1 - .../plug-hostdev-pci.xml | 1 - tests/virpcimock.c | 9 + tests/xlconfigdata/test-fullvirt-pci.xml | 2 - tests/xmconfigdata/test-pci-dev-syntax.xml | 2 - tests/xmconfigdata/test-pci-devs.xml | 2 - tools/virsh-completer-nodedev.c | 4 +- 102 files changed, 927 insertions(+), 530 deletions(-) create mode 100644 tests/networkxml2xmlin/hostdev-pf-old.xml create mode 100644 tests/networkxml2xmlout/hostdev-pf-old.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-vfio-old-driver-name.x86_64-latest.xml -- 2.43.0

2 25

[PATCH 0/6] qemu: Update capabilities and add support for assigning multiple iothreads to a virtio-blk device
by Peter Krempa 05 Jan '24

05 Jan '24

See 4/6 for docs, 6/6 for examples Peter Krempa (6): qemucapabilitiesdata: Add data for the qemu-9.0 development cycle util: xml: Return GPtrArray from virXMLNodeGetSubelement qemu: capabilities: Introduce QEMU_CAPS_VIRTIO_BLK_IOTHREAD_MAPPING conf: Add possibility to configure multiple iothreads per disk qemu: Implement support for configuring iothread to virtqueue mapping for disks tests: Add xml->argv and xml->xml tests for the new iothread mapping feature docs/formatdomain.rst | 23 +- src/conf/domain_conf.c | 116 +- src/conf/domain_conf.h | 14 + src/conf/domain_validate.c | 8 + src/conf/network_conf.c | 33 +- src/conf/nwfilter_conf.c | 20 +- src/conf/schemas/domaincommon.rng | 47 +- src/hypervisor/domain_driver.c | 15 +- src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 45 + src/qemu/qemu_validate.c | 117 +- src/util/virxml.c | 21 +- src/util/virxml.h | 5 +- .../domaincapsdata/qemu_9.0.0-q35.x86_64.xml | 289 + .../domaincapsdata/qemu_9.0.0-tcg.x86_64.xml | 288 + tests/domaincapsdata/qemu_9.0.0.x86_64.xml | 289 + .../caps_9.0.0_x86_64.replies | 42923 ++++++++++++++++ .../caps_9.0.0_x86_64.xml | 3760 ++ .../iothreads-disk.x86_64-latest.args | 13 +- tests/qemuxml2argvdata/iothreads-disk.xml | 25 +- .../iothreads-disk.x86_64-latest.xml | 26 +- 22 files changed, 47986 insertions(+), 94 deletions(-) create mode 100644 tests/domaincapsdata/qemu_9.0.0-q35.x86_64.xml create mode 100644 tests/domaincapsdata/qemu_9.0.0-tcg.x86_64.xml create mode 100644 tests/domaincapsdata/qemu_9.0.0.x86_64.xml create mode 100644 tests/qemucapabilitiesdata/caps_9.0.0_x86_64.replies create mode 100644 tests/qemucapabilitiesdata/caps_9.0.0_x86_64.xml -- 2.43.0

2 8

[PATCH 0/2] tests: Ensure test files are newline-terminated
by Andrea Bolognani 05 Jan '24

05 Jan '24

Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1128046264 Andrea Bolognani (2): tests: Drop some unused qemunbdkit data files tests: Ensure test files are newline-terminated ...69d019_36ea_4111_8f0a_8c9a70e21366-create.json | 2 +- ...69d019_36ea_4111_8f0a_8c9a70e21366-define.json | 2 +- ...441d39_495e_4243_ad9f_beb3f14c23d9-create.json | 2 +- ...441d39_495e_4243_ad9f_beb3f14c23d9-define.json | 2 +- ...dc4916_1ca8_49ac_b176_871d16c13076-create.json | 2 +- ...dc4916_1ca8_49ac_b176_871d16c13076-define.json | 2 +- .../disk-cdrom-network.args.disk1.pipe.778 | 2 +- .../disk-cdrom-network.args.disk2.pipe.780 | 2 +- .../disk-network-http.args.disk2.pipe.778 | 2 +- .../disk-network-http.args.disk3.pipe.780 | 2 +- ...source-curl-nbdkit-backing.args.disk0.pipe.778 | 2 +- .../disk-network-source-curl.args.disk0.pipe.778 | 2 +- .../disk-network-source-curl.args.disk1.pipe.780 | 2 +- .../disk-network-source-curl.args.disk1.pipe.782 | 2 +- .../disk-network-source-curl.args.disk2.pipe.782 | 1 - .../disk-network-source-curl.args.disk2.pipe.784 | 2 +- .../disk-network-ssh-password.args.disk0.pipe.778 | 2 +- tests/qemunbdkitdata/disk-network-ssh.args.disk1 | 8 -------- .../disk-network-ssh.args.disk1.pipe.778 | 1 - tests/qemunbdkitdata/disk-network-ssh.args.disk2 | 9 --------- tests/testutils.c | 15 ++++++--------- .../linux-ppc64-deconf-cpus.signature | 2 +- .../linux-ppc64-subcores1.signature | 2 +- .../linux-ppc64-subcores2.signature | 2 +- .../linux-ppc64-subcores3.signature | 2 +- .../linux-s390x-with-frequency.signature | 2 +- 26 files changed, 27 insertions(+), 49 deletions(-) delete mode 100644 tests/qemunbdkitdata/disk-network-source-curl.args.disk2.pipe.782 delete mode 100644 tests/qemunbdkitdata/disk-network-ssh.args.disk1 delete mode 100644 tests/qemunbdkitdata/disk-network-ssh.args.disk1.pipe.778 delete mode 100644 tests/qemunbdkitdata/disk-network-ssh.args.disk2 -- 2.43.0

2 3

[PATCH v4] qemu: add runtime config option for nbdkit
by Jonathon Jongsma 05 Jan '24

05 Jan '24

Currently when we build with nbdkit support, libvirt will always try to use nbdkit to access remote disk sources when it is available. But without an up-to-date selinux policy allowing this, it will fail. because the required selinux policies are not yet widely available, we have disabled nbdkit support on rpm builds for all distributions before Fedora 40. Unfortunately, this makes it more difficult to test nbdkit support. After someone updates to the necessary selinux policies, they would also need to rebuild libvirt to enable nbdkit support. By introducing a configure option (nbdkit_config_default), we can build packages with nbdkit support but have it disabled by default. Signed-off-by: Jonathon Jongsma <jjongsma(a)redhat.com> Suggested-by: Andrea Bolognani <abologna(a)redhat.com> --- changes in v4 - squashed in Andrea's suggested changes - updated error message - Changed one instance of WITH_NDBKIT to WITH_NBDKIT :) - tested libvirt.spec.in | 18 ++++++++++++++---- meson.build | 10 ++++++++++ meson_options.txt | 3 ++- src/qemu/libvirtd_qemu.aug | 3 +++ src/qemu/meson.build | 2 ++ src/qemu/qemu.conf.in | 11 +++++++++++ src/qemu/qemu_conf.c | 24 ++++++++++++++++++++++++ src/qemu/qemu_conf.h | 2 ++ src/qemu/qemu_domain.c | 3 +++ src/qemu/test_libvirtd_qemu.aug.in | 1 + tests/qemuxml2argvtest.c | 15 +++++++++------ 11 files changed, 81 insertions(+), 11 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 1d0ec5073d..2f2d713732 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -96,6 +96,7 @@ %define with_sanlock 0 %define with_numad 0 %define with_nbdkit 0 +%define with_nbdkit_config_default 0 %define with_firewalld_zone 0 %define with_netcf 0 %define with_libssh2 0 @@ -174,15 +175,17 @@ %endif %endif -# We should only enable nbdkit support if the OS ships a SELinux policy that -# allows libvirt to launch it. Right now that's not the case anywhere, but -# things should be fine by the time Fedora 40 is released. +# We want to build with nbdkit support, but should only enable nbdkit by +# default if the OS ships a SELinux policy that allows libvirt to launch it. +# Right now that's not the case anywhere, but things should be fine by the time +# Fedora 40 is released. # # TODO: add RHEL 9 once a minor release that contains the necessary SELinux # bits exists (we only support the most recent minor release) %if %{with_qemu} + %define with_nbdkit 0%{!?_without_nbdkit:1} %if 0%{?fedora} >= 40 - %define with_nbdkit 0%{!?_without_nbdkit:1} + %define with_nbdkit_config_default 0%{!?_without_nbdkit_config_default:1} %endif %endif @@ -1207,6 +1210,12 @@ exit 1 %define arg_nbdkit -Dnbdkit=disabled %endif +%if %{with_nbdkit_config_default} + %define arg_nbdkit_config_default -Dnbdkit_config_default=enabled +%else + %define arg_nbdkit_config_default -Dnbdkit_config_default=disabled +%endif + %if %{with_fuse} %define arg_fuse -Dfuse=enabled %else @@ -1322,6 +1331,7 @@ export SOURCE_DATE_EPOCH=$(stat --printf='%Y' %{_specdir}/libvirt.spec) %{?arg_sanlock} \ -Dlibpcap=enabled \ %{?arg_nbdkit} \ + %{?arg_nbdkit_config_default} \ -Dlibnl=enabled \ -Daudit=enabled \ -Ddtrace=enabled \ diff --git a/meson.build b/meson.build index 4d96b32e58..1e5e1d7954 100644 --- a/meson.build +++ b/meson.build @@ -1009,6 +1009,16 @@ if not conf.has('WITH_NBDKIT') libnbd_dep = dependency('', required: false) endif +# default value for storage_use_nbdkit config option. +# For now 'auto' just maps to disabled, but in the future it may depend on +# which security drivers are enabled +use_nbdkit_default = get_option('nbdkit_config_default').enabled() + +if use_nbdkit_default and not conf.has('WITH_NBDKIT') + error('nbdkit_config_default requires nbdkit to be enabled') +endif +conf.set10('USE_NBDKIT_DEFAULT', use_nbdkit_default) + libnl_version = '3.0' if not get_option('libnl').disabled() and host_machine.system() == 'linux' libnl_dep = dependency('libnl-3.0', version: '>=' + libnl_version, required: get_option('libnl')) diff --git a/meson_options.txt b/meson_options.txt index a0928102bf..182e28b3d1 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -104,7 +104,8 @@ option('loader_nvram', type: 'string', value: '', description: 'Pass list of pai option('login_shell', type: 'feature', value: 'auto', description: 'build virt-login-shell') option('nss', type: 'feature', value: 'auto', description: 'enable Name Service Switch plugin for resolving guest IP addresses') option('numad', type: 'feature', value: 'auto', description: 'use numad to manage CPU placement dynamically') -option('nbdkit', type: 'feature', value: 'auto', description: 'use nbdkit to access network disks') +option('nbdkit', type: 'feature', value: 'auto', description: 'Build nbdkit storage backend') +option('nbdkit_config_default', type: 'feature', value: 'auto', description: 'Whether to use nbdkit storage backend for network disks by default (configurable)') option('pm_utils', type: 'feature', value: 'auto', description: 'use pm-utils for power management') option('sysctl_config', type: 'feature', value: 'auto', description: 'Whether to install sysctl configs') option('tls_priority', type: 'string', value: 'NORMAL', description: 'set the default TLS session priority string') diff --git a/src/qemu/libvirtd_qemu.aug b/src/qemu/libvirtd_qemu.aug index ed097ea3d9..43485b43fb 100644 --- a/src/qemu/libvirtd_qemu.aug +++ b/src/qemu/libvirtd_qemu.aug @@ -147,6 +147,8 @@ module Libvirtd_qemu = let capability_filters_entry = str_array_entry "capability_filters" + let storage_entry = bool_entry "storage_use_nbdkit" + (* Each entry in the config is one of the following ... *) let entry = default_tls_entry | vnc_entry @@ -170,6 +172,7 @@ module Libvirtd_qemu = | nbd_entry | swtpm_entry | capability_filters_entry + | storage_entry | obsolete_entry let comment = [ label "#comment" . del /#[ \t]*/ "# " . store /([^ \t\n][^\n]*)?/ . del /\n/ "\n" ] diff --git a/src/qemu/meson.build b/src/qemu/meson.build index 2279fef2ca..4c3e1dee78 100644 --- a/src/qemu/meson.build +++ b/src/qemu/meson.build @@ -137,6 +137,7 @@ if conf.has('WITH_QEMU') qemu_user_group_conf = configuration_data({ 'QEMU_USER': qemu_user, 'QEMU_GROUP': qemu_group, + 'USE_NBDKIT_DEFAULT': use_nbdkit_default.to_int(), }) qemu_conf = configure_file( input: 'qemu.conf.in', @@ -147,6 +148,7 @@ if conf.has('WITH_QEMU') qemu_user_group_hack_conf = configuration_data({ 'QEMU_USER': qemu_user, 'QEMU_GROUP': qemu_group, + 'USE_NBDKIT_DEFAULT': use_nbdkit_default.to_int(), # This hack is necessary because the output file is going to be # used as input for another configure_file() call later, which # will take care of substituting @CONFIG@ with useful data diff --git a/src/qemu/qemu.conf.in b/src/qemu/qemu.conf.in index 6897e0f760..34025a02ef 100644 --- a/src/qemu/qemu.conf.in +++ b/src/qemu/qemu.conf.in @@ -974,3 +974,14 @@ # "full" - both QEMU and its helper processes are placed into separate # scheduling group #sched_core = "none" + +# Using nbdkit to access remote disk sources +# +# If this is set then libvirt will use nbdkit to access remote disk sources +# when available. nbdkit will export an NBD share to QEMU rather than having +# QEMU attempt to access the remote server directly. +# +# Possible values are 0 or 1. Default value is @USE_NBDKIT_DEFAULT@. Please +# note that the default might change in future releases. +# +#storage_use_nbdkit = @USE_NBDKIT_DEFAULT@ diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 513b5ebb1e..53eec9c43a 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -285,6 +285,7 @@ virQEMUDriverConfig *virQEMUDriverConfigNew(bool privileged, return NULL; cfg->deprecationBehavior = g_strdup("none"); + cfg->storageUseNbdkit = USE_NBDKIT_DEFAULT; return g_steal_pointer(&cfg); } @@ -1065,6 +1066,26 @@ virQEMUDriverConfigLoadCapsFiltersEntry(virQEMUDriverConfig *cfg, } +static int +virQEMUDriverConfigLoadStorageEntry(virQEMUDriverConfig *cfg, + virConf *conf) +{ + if (virConfGetValueBool(conf, "storage_use_nbdkit", &cfg->storageUseNbdkit) < 0) + return -1; + +#if !WITH_NBDKIT + if (cfg->storageUseNbdkit) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + "%s", + _("configuration option 'storage_use_nbdkit' was specified, but nbdkit is not supported by this libvirt")); + return -1; + } +#endif /* WITH_NBDKIT */ + + return 0; +} + + int virQEMUDriverConfigLoadFile(virQEMUDriverConfig *cfg, const char *filename, bool privileged) @@ -1136,6 +1157,9 @@ int virQEMUDriverConfigLoadFile(virQEMUDriverConfig *cfg, if (virQEMUDriverConfigLoadCapsFiltersEntry(cfg, conf) < 0) return -1; + if (virQEMUDriverConfigLoadStorageEntry(cfg, conf) < 0) + return -1; + return 0; } diff --git a/src/qemu/qemu_conf.h b/src/qemu/qemu_conf.h index 1a3ba3a0fb..36049b4bfa 100644 --- a/src/qemu/qemu_conf.h +++ b/src/qemu/qemu_conf.h @@ -230,6 +230,8 @@ struct _virQEMUDriverConfig { char *deprecationBehavior; + bool storageUseNbdkit; + virQEMUSchedCore schedCore; }; diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 734d63f8a4..e16ba1c225 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -10296,6 +10296,9 @@ qemuDomainPrepareStorageSourceNbdkit(virStorageSource *src, { g_autoptr(qemuNbdkitCaps) nbdkit = NULL; + if (!cfg->storageUseNbdkit) + return false; + if (virStorageSourceGetActualType(src) != VIR_STORAGE_TYPE_NETWORK) return false; diff --git a/src/qemu/test_libvirtd_qemu.aug.in b/src/qemu/test_libvirtd_qemu.aug.in index c730df40b0..e4cfde6cc7 100644 --- a/src/qemu/test_libvirtd_qemu.aug.in +++ b/src/qemu/test_libvirtd_qemu.aug.in @@ -117,3 +117,4 @@ module Test_libvirtd_qemu = } { "deprecation_behavior" = "none" } { "sched_core" = "none" } +{ "storage_use_nbdkit" = "@USE_NBDKIT_DEFAULT@" } diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index b2ea2191dc..74d20b9132 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1125,7 +1125,6 @@ mymain(void) DO_TEST_CAPS_LATEST("disk-cdrom-empty-network-invalid"); DO_TEST_CAPS_LATEST("disk-cdrom-bus-other"); DO_TEST_CAPS_LATEST("disk-cdrom-network"); - DO_TEST_CAPS_LATEST_NBDKIT("disk-cdrom-network-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_CURL); DO_TEST_CAPS_LATEST("disk-cdrom-tray"); DO_TEST_CAPS_LATEST("disk-floppy"); DO_TEST_CAPS_LATEST("disk-floppy-q35"); @@ -1171,8 +1170,6 @@ mymain(void) DO_TEST_CAPS_VER("disk-network-sheepdog", "6.0.0"); DO_TEST_CAPS_LATEST("disk-network-source-auth"); DO_TEST_CAPS_LATEST("disk-network-source-curl"); - DO_TEST_CAPS_LATEST_NBDKIT("disk-network-source-curl-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_CURL); - DO_TEST_CAPS_LATEST_NBDKIT("disk-network-source-curl-nbdkit-backing", QEMU_NBDKIT_CAPS_PLUGIN_CURL); DO_TEST_CAPS_LATEST("disk-network-nfs"); driver.config->vxhsTLS = 1; driver.config->nbdTLSx509secretUUID = g_strdup("6fd3f62d-9fe7-4a4e-a869-7acd6376d8ea"); @@ -1183,13 +1180,10 @@ mymain(void) DO_TEST_CAPS_LATEST("disk-network-tlsx509-nbd-hostname"); DO_TEST_CAPS_VER("disk-network-tlsx509-vxhs", "5.0.0"); DO_TEST_CAPS_LATEST("disk-network-http"); - DO_TEST_CAPS_LATEST_NBDKIT("disk-network-http-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_CURL); VIR_FREE(driver.config->nbdTLSx509secretUUID); VIR_FREE(driver.config->vxhsTLSx509secretUUID); driver.config->vxhsTLS = 0; DO_TEST_CAPS_LATEST("disk-network-ssh"); - DO_TEST_CAPS_LATEST_NBDKIT("disk-network-ssh-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_SSH); - DO_TEST_CAPS_LATEST_NBDKIT("disk-network-ssh-password", QEMU_NBDKIT_CAPS_PLUGIN_SSH); DO_TEST_CAPS_LATEST("disk-no-boot"); DO_TEST_CAPS_LATEST("disk-nvme"); DO_TEST_CAPS_VER("disk-vhostuser-numa", "4.2.0"); @@ -1259,6 +1253,15 @@ mymain(void) DO_TEST_CAPS_LATEST("disk-geometry"); DO_TEST_CAPS_LATEST("disk-blockio"); + driver.config->storageUseNbdkit = 1; + DO_TEST_CAPS_LATEST_NBDKIT("disk-cdrom-network-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_CURL); + DO_TEST_CAPS_LATEST_NBDKIT("disk-network-source-curl-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_CURL); + DO_TEST_CAPS_LATEST_NBDKIT("disk-network-source-curl-nbdkit-backing", QEMU_NBDKIT_CAPS_PLUGIN_CURL); + DO_TEST_CAPS_LATEST_NBDKIT("disk-network-http-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_CURL); + DO_TEST_CAPS_LATEST_NBDKIT("disk-network-ssh-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_SSH); + DO_TEST_CAPS_LATEST_NBDKIT("disk-network-ssh-password", QEMU_NBDKIT_CAPS_PLUGIN_SSH); + driver.config->storageUseNbdkit = 0; + DO_TEST_CAPS_VER("disk-virtio-scsi-reservations", "5.2.0"); DO_TEST_CAPS_LATEST("disk-virtio-scsi-reservations"); -- 2.43.0

3 8

[PATCH] libvirt.spec: Fix nbdkit selection logic on mingw and old rhel
by Peter Krempa 05 Jan '24

05 Jan '24

rhel-8 lacks 'pidfd_open()' support and thus nbdkit can't be enabled there. mingw builds explicitly disable nbdkit support, but use '--auto-features=enabled' thus omitting setting of 'nbdkit_config_default' results in meson thinking we want to enable it: ../meson.build:1018:2: ERROR: Problem encountered: nbdkit_config_default requires nbdkit to be enabled Disable it explicitly. The meson logic might need to be fixed eventually when switching it on by default. Fixes: 9eabf14afbd429af1be195723fdeab5ccdd0b2cd Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- libvirt.spec.in | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 2f2d713732..8413e3c19a 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -179,13 +179,19 @@ # default if the OS ships a SELinux policy that allows libvirt to launch it. # Right now that's not the case anywhere, but things should be fine by the time # Fedora 40 is released. -# -# TODO: add RHEL 9 once a minor release that contains the necessary SELinux -# bits exists (we only support the most recent minor release) %if %{with_qemu} - %define with_nbdkit 0%{!?_without_nbdkit:1} - %if 0%{?fedora} >= 40 - %define with_nbdkit_config_default 0%{!?_without_nbdkit_config_default:1} + # rhel-8 lacks pidfd_open + %if 0%{?fedora} || 0%{?rhel} >= 9 + %define with_nbdkit 0%{!?_without_nbdkit:1} + + # setting 'with_nbdkit_config_default' must be done only when compiling + # in nbdkit support + # + # TODO: add RHEL 9 once a minor release that contains the necessary SELinux + # bits exists (we only support the most recent minor release) + %if 0%{?fedora} >= 40 + %define with_nbdkit_config_default 0%{!?_without_nbdkit_config_default:1} + %endif %endif %endif @@ -1397,6 +1403,7 @@ export SOURCE_DATE_EPOCH=$(stat --printf='%Y' %{_specdir}/libvirt.spec) -Dhost_validate=disabled \ -Dlibiscsi=disabled \ -Dnbdkit=disabled \ + -Dnbdkit_config_default=disabled \ -Dlibnl=disabled \ -Dlibpcap=disabled \ -Dlibssh2=disabled \ -- 2.43.0

2 1

[PATCH 0/7] Code cleanup 2
by Artem Chernyshev 05 Jan '24

05 Jan '24

Several functions was modified to become invariant. Change their type to void and remove unnecessary checks of their return values. Found by Linux Verification Center (linuxtesting.org) with SVACE. Artem Chernyshev (7): cpu: : virCPUx86DataAddItem() to void rpc: virnetserver: virNetServerAddService() to void lxc: virLXCControllerAddConsole() to void conf: virDomainNetUpdate() to void virprocess: virProcessGetNamespaces() to void node_device: udevTranslatePCIIds() to void node_device: udevGetStringSysfsAttr() to void src/conf/domain_conf.c | 3 +- src/conf/domain_conf.h | 2 +- src/cpu/cpu_x86.c | 179 +++++++++++------------------ src/cpu/cpu_x86.h | 4 +- src/libvirt-lxc.c | 5 +- src/libxl/libxl_capabilities.c | 13 +-- src/lxc/lxc_controller.c | 9 +- src/lxc/lxc_driver.c | 6 +- src/node_device/node_device_udev.c | 69 ++++------- src/qemu/qemu_capabilities.c | 3 +- src/qemu/qemu_driver.c | 3 +- src/qemu/qemu_monitor_json.c | 7 +- src/qemu/qemu_process.c | 3 +- src/rpc/virnetserver.c | 25 +--- src/rpc/virnetserver.h | 2 +- src/util/virprocess.c | 4 +- src/util/virprocess.h | 2 +- tests/virnetdaemontest.c | 6 +- 18 files changed, 118 insertions(+), 227 deletions(-) -- 2.43.0

2 13

[libvirt PATCH v2 00/15] Support for VFIO variant drivers, Part 2
by Laine Stump 05 Jan '24

05 Jan '24

(Thisis "V2 of Part 2". "V1 of Part 2" is here: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/5GF4… ) Part 1 (which simply made it possible to use virsh nodedev-detach to bind a device to a manually-specified variant driver, and at guest runtime allowed libvirt to ignore the fact that the driver found to the device was something other than exactly "vfio-pci") was here: https://listman.redhat.com/archives/libvir-list/2023-August/241338.html and pushed upstream as of commit v9.6.0-153-g24beaffec3 Part 2 adds two new pieces of functionality: 1) It is possible to manually specify a VFIO variant driver (or force the generic vfio-pci driver) for a device in the domain XML with, e.g.: <driver name='mlx5_vfio_pci'/> (for the former) or: <driver name='vfio-pci'/> (for the latter). 2) By default libvirt will now find the "best match" VFIO or VFIO variant driver by comparing the device's modalias file contents (in sysfs) with vfio drivers found in the running kernel's modules.alias file. This means that "virsh nodedev-detach" of a host device will bind it to its appropriate VFIO variant driver (if one is available), and also if a <hostdev> decice in a domain config has "managed='yes'", libvirt will bind it to a variant driver if possible (in order to force binding to the basic vfio-pci driver instead, you just need to add the <driver> element mentioned above). The first 12 patches are all just getting (1) going (a lot of it is refactoring code to use common code for the four places that use the hostdev <driver> element), and the final 3 patches implement (2). More details are spread along the way. Differences from V1: I squashed together a couple of the patches, and fixed some things that caused CI jobs to fail (I'd forgotten to push the branch to gitlab and trigger CI). Laine Stump (15): util: properly deal with module vs. driver when binding device to driver schema: consolidate RNG for all hostdev <driver> elements conf: move/rename hostdev PCI driver type enum to device_conf.h conf: normalize hostdev <driver> parsing to simplify adding new attr conf: put hostdev PCI backend into a struct conf: use virDeviceHostdevPCIDriverInfo in network and networkport objects conf: split out hostdev <driver> parse/format to their own functions conf: use new common parser/formatter for hostdev driver in network XML tests: remove explicit <driver name='vfio'/> from hostdev test cases xen: explicitly set hostdev driver.type at runtime, not in postparse conf: replace virHostdevIsVFIODevice with virHostdevIsPCIDevice conf: support manually specifying VFIO variant driver in <hostdev> XML util: new function virStringSkipToSpace() tests: mock virPCIDevice(BindTo|UnbindFrom)Stub with nop functions qemu: automatically bind to a vfio variant driver, if available docs/formatdomain.rst | 55 ++- src/conf/device_conf.c | 75 +++ src/conf/device_conf.h | 27 ++ src/conf/domain_capabilities.c | 2 +- src/conf/domain_capabilities.h | 2 +- src/conf/domain_conf.c | 98 +--- src/conf/domain_conf.h | 18 +- src/conf/network_conf.c | 43 +- src/conf/network_conf.h | 17 +- src/conf/schemas/basictypes.rng | 20 + src/conf/schemas/domaincommon.rng | 173 ++++--- src/conf/schemas/network.rng | 10 +- src/conf/schemas/networkport.rng | 10 +- src/conf/virconftypes.h | 2 + src/conf/virnetworkportdef.c | 22 +- src/conf/virnetworkportdef.h | 4 +- src/hypervisor/virhostdev.c | 16 +- src/hypervisor/virhostdev.h | 2 - src/libvirt_private.syms | 10 +- src/libxl/libxl_capabilities.c | 2 +- src/libxl/libxl_domain.c | 65 ++- src/libxl/libxl_driver.c | 25 +- src/network/bridge_driver.c | 2 +- src/qemu/qemu_capabilities.c | 4 +- src/qemu/qemu_command.c | 14 +- src/qemu/qemu_domain.c | 29 +- src/qemu/qemu_hostdev.c | 2 +- src/qemu/qemu_hotplug.c | 2 +- src/qemu/qemu_validate.c | 6 +- src/security/security_apparmor.c | 2 +- src/security/security_dac.c | 4 +- src/security/security_selinux.c | 4 +- src/security/virt-aa-helper.c | 8 +- src/util/virpci.c | 438 ++++++++++++++++-- src/util/virpci.h | 3 + src/util/virstring.c | 17 + src/util/virstring.h | 1 + tests/domaincapstest.c | 4 +- tests/libxlxml2domconfigdata/moredevs-hvm.xml | 1 - tests/networkxml2xmlin/hostdev-pf-old.xml | 8 + tests/networkxml2xmlin/hostdev-pf.xml | 2 +- tests/networkxml2xmlout/hostdev-pf-old.xml | 8 + tests/networkxml2xmlout/hostdev-pf.xml | 2 +- tests/networkxml2xmltest.c | 6 + tests/qemuhotplugmock.c | 15 + .../qemuhotplug-hostdev-pci.xml | 1 - .../qemuhotplug-base-live+hostdev-pci.xml | 2 +- ...uhotplug-pseries-base-live+hostdev-pci.xml | 2 +- tests/qemustatusxml2xmldata/modern-in.xml | 2 +- .../hostdev-pci-address-unassigned.xml | 4 - .../hostdev-pci-multifunction.xml | 7 - .../hostdev-vfio-multidomain.xml | 1 - .../hostdev-vfio-zpci-autogenerate-fids.xml | 2 - .../hostdev-vfio-zpci-autogenerate-uids.xml | 2 - .../hostdev-vfio-zpci-autogenerate.xml | 1 - .../hostdev-vfio-zpci-boundaries.xml | 2 - .../hostdev-vfio-zpci-ccw-memballoon.xml | 1 - .../hostdev-vfio-zpci-duplicate.xml | 2 - ...ostdev-vfio-zpci-invalid-uid-valid-fid.xml | 1 - .../hostdev-vfio-zpci-multidomain-many.xml | 8 - .../hostdev-vfio-zpci-set-zero.xml | 1 - .../hostdev-vfio-zpci-uid-set-zero.xml | 1 - .../hostdev-vfio-zpci-wrong-arch.xml | 1 - tests/qemuxml2argvdata/hostdev-vfio-zpci.xml | 1 - .../hostdev-vfio.x86_64-latest.args | 5 +- tests/qemuxml2argvdata/hostdev-vfio.xml | 19 +- .../net-hostdev-vfio-multidomain.xml | 1 - tests/qemuxml2argvdata/net-hostdev-vfio.xml | 1 - tests/qemuxml2argvdata/pseries-hostdevs-1.xml | 3 - tests/qemuxml2argvdata/pseries-hostdevs-2.xml | 2 - tests/qemuxml2argvdata/pseries-hostdevs-3.xml | 2 - ...v-pci-address-unassigned.x86_64-latest.xml | 4 - ...ostdev-pci-multifunction.x86_64-latest.xml | 7 - ...io-zpci-autogenerate-fids.s390x-latest.xml | 2 - ...io-zpci-autogenerate-uids.s390x-latest.xml | 2 - ...ev-vfio-zpci-autogenerate.s390x-latest.xml | 1 - ...tdev-vfio-zpci-boundaries.s390x-latest.xml | 2 - ...-vfio-zpci-ccw-memballoon.s390x-latest.xml | 1 - ...fio-zpci-multidomain-many.s390x-latest.xml | 8 - .../hostdev-vfio-zpci.s390x-latest.xml | 1 - .../hostdev-vfio.x86_64-latest.xml | 24 +- .../net-hostdev-vfio.x86_64-latest.xml | 1 - .../pseries-hostdevs-1.ppc64-latest.xml | 3 - .../pseries-hostdevs-2.ppc64-latest.xml | 2 - .../pseries-hostdevs-3.ppc64-latest.xml | 2 - tests/virhostdevtest.c | 2 +- .../plug-hostdev-pci-unmanaged.xml | 2 +- .../plug-hostdev-pci.xml | 2 +- tests/xlconfigdata/test-fullvirt-pci.xml | 2 - tests/xmconfigdata/test-pci-dev-syntax.xml | 2 - tests/xmconfigdata/test-pci-devs.xml | 2 - tools/virsh-completer-nodedev.c | 4 +- 92 files changed, 933 insertions(+), 498 deletions(-) create mode 100644 tests/networkxml2xmlin/hostdev-pf-old.xml create mode 100644 tests/networkxml2xmlout/hostdev-pf-old.xml -- 2.41.0

3 44

[libvirt PATCH 0/5] Initial network support in ch driver.
by Praveen K Paladugu 04 Jan '24

04 Jan '24

This series introduces network support for ch guests. ETHERNET network mode is the only mode supported. More modes will be add once this series is merged. For security reasons, cloud-hypervisor requries FDs for guests to be sent using SCM_RIGHTS. This patch series introduces 2 methods that support sending FDs to ch in Patch 3. Network support in ch driver is introduced by Patch 5. I previously sent "hypervisor: Move interface mgmt methods to hypervisor" patch by itself. I merged this patch also into Patch 2 in this series. Praveen K Paladugu (5): conf: Drop unused parameter hypervisor: Move domain interface mgmt methods util: Add util methods required by ch networking ch: Introduce version based cap for network support ch: Enable ETHERNET Network mode support po/POTFILES | 3 + src/ch/ch_capabilities.c | 9 + src/ch/ch_capabilities.h | 1 + src/ch/ch_conf.h | 4 + src/ch/ch_domain.c | 41 +++ src/ch/ch_domain.h | 3 + src/ch/ch_interface.c | 104 +++++++ src/ch/ch_interface.h | 35 +++ src/ch/ch_monitor.c | 205 +++++--------- src/ch/ch_monitor.h | 7 +- src/ch/ch_process.c | 160 ++++++++++- src/ch/meson.build | 2 + src/conf/domain_conf.c | 1 - src/conf/domain_conf.h | 3 +- src/hypervisor/domain_interface.c | 457 ++++++++++++++++++++++++++++++ src/hypervisor/domain_interface.h | 45 +++ src/hypervisor/meson.build | 1 + src/libvirt_private.syms | 11 + src/libxl/libxl_domain.c | 2 +- src/libxl/libxl_driver.c | 4 +- src/lxc/lxc_driver.c | 2 +- src/lxc/lxc_process.c | 4 +- src/qemu/qemu_command.c | 6 +- src/qemu/qemu_hotplug.c | 15 +- src/qemu/qemu_interface.c | 339 +--------------------- src/qemu/qemu_interface.h | 11 - src/qemu/qemu_process.c | 73 +---- src/util/virsocket.c | 109 +++++++ src/util/virsocket.h | 3 + 29 files changed, 1093 insertions(+), 567 deletions(-) create mode 100644 src/ch/ch_interface.c create mode 100644 src/ch/ch_interface.h create mode 100644 src/hypervisor/domain_interface.c create mode 100644 src/hypervisor/domain_interface.h -- 2.41.0

3 9

[PATCH 00/19] qemu XML testing improvements, part 1 - forgotten test files and network driver
by Peter Krempa 04 Jan '24

04 Jan '24

This patch saga aims to improve and simplify testing of qemu XML configs. Part 1 deals with input test files which are not used in qemuxml2argvtest, introduces a mock network driver and adds a checker that all input files are in fact used. Peter Krempa (19): qemuxml2argvtest: Reinstate 'console-compat-chardev' and 'pci-serial-dev-chardev' qemuxml2argvtest: Fix and use 'disk-network-ssh-key' case qemuxml2argvtest: Reinstate 'pseries-vio-address-clash' case qemuxml2argvdata: Move 'smbios-multiple-type2' case to genericxml2xmltest qemuxml2argvtest: Remove duplicated invocations of tests qemuxml2argvtest: Check for duplicate invocation of tests qemuxml2argvmock: Mock qemuInterfaceBridgeConnect qemuxml2argvtest: Add test cases covered only by qemuxml2xmltest - part 1 qemuxml2xmltest: Move 'graphics-listen-network2' case go genericxml2xmltest qemuxml2*test: Add specific test case for interface link state qemuxml*test: Improve 'vhost_queues' test case qemuxml2xmltest: Delete 'interface-driver' case qemu: process: Separate setup of network device objects qemuxml2argvmock: Mock virNetDevSetMTU qemuxml2xmltest: Introduce fake network driver qemuxml2argvtest: Enable 'graphics-listen-network' case virnetworkportxml2xmltest: Add simple versions of bridge/network tests qemuxml2argvtest: Add test cases covered only by qemuxml2xmltest - part 2 qemuxml2argvtest: Add checker that all input files are used src/qemu/qemu_interface.h | 2 +- src/qemu/qemu_process.c | 45 ++-- src/util/virnetdev.h | 2 +- .../graphics-listen-network2.xml | 0 .../smbios-multiple-type2.xml | 0 .../graphics-listen-network2.xml | 35 +++ tests/genericxml2xmltest.c | 3 + tests/qemustatusxml2xmltest.c | 2 +- ...nu-disable-with-timeout.x86_64-latest.args | 36 +++ ...hannel-unix-source-path.x86_64-latest.args | 45 ++++ .../chardev-label.x86_64-latest.args | 41 +++ .../console-compat2.x86_64-latest.args | 40 +++ .../cpu-empty.x86_64-latest.args | 33 +++ ...cpu-host-model-features.x86_64-latest.args | 33 +++ .../cpu-numa-disordered.x86_64-latest.args | 38 +++ .../disk-active-commit.x86_64-latest.args | 38 +++ .../disk-mirror-old.x86_64-latest.args | 45 ++++ .../disk-mirror.x86_64-latest.args | 48 ++++ .../disk-network-ssh-key.x86_64-latest.args | 38 +++ .../qemuxml2argvdata/disk-network-ssh-key.xml | 2 +- .../disk-network-vxhs.x86_64-5.0.0.args | 35 +++ .../downscript.x86_64-latest.args | 43 +++ ...graphics-listen-network.x86_64-latest.args | 37 +++ .../graphics-listen-network.xml | 2 +- .../hostdev-mdev-display.x86_64-latest.args | 34 +++ ...ev-scsi-autogen-address.x86_64-latest.args | 60 +++++ ...hostdev-scsi-large-unit.x86_64-latest.args | 39 +++ .../hostdev-scsi-shareable.x86_64-latest.args | 39 +++ tests/qemuxml2argvdata/interface-driver.xml | 54 ---- .../qemuxml2argvdata/lease.x86_64-latest.args | 39 +++ .../memorybacking-set.x86_64-latest.args | 33 +++ .../memorybacking-unset.x86_64-latest.args | 33 +++ .../metadata-duplicate.x86_64-latest.args | 36 +++ .../metadata.x86_64-latest.args | 36 +++ .../net-bandwidth.x86_64-latest.args | 47 ++++ tests/qemuxml2argvdata/net-bandwidth.xml | 2 +- .../net-bandwidth2.x86_64-latest.args | 44 +++ tests/qemuxml2argvdata/net-bandwidth2.xml | 2 +- .../net-coalesce.x86_64-latest.args | 48 ++++ tests/qemuxml2argvdata/net-coalesce.xml | 6 +- .../net-isolated-port.x86_64-latest.args | 43 +++ tests/qemuxml2argvdata/net-isolated-port.xml | 2 +- .../net-linkstate.x86_64-latest.args | 36 +++ tests/qemuxml2argvdata/net-linkstate.xml | 34 +++ .../net-midonet.x86_64-latest.args | 38 +++ .../net-mtu.x86_64-latest.args | 46 ++++ tests/qemuxml2argvdata/net-mtu.xml | 4 +- .../net-openvswitch.x86_64-latest.args | 38 +++ tests/qemuxml2argvdata/net-openvswitch.xml | 2 +- ...irtio-network-portgroup.x86_64-latest.args | 42 +++ .../net-virtio-network-portgroup.xml | 6 +- ...-virtio-teaming-network.x86_64-latest.args | 39 +++ .../net-virtio-teaming-network.xml | 4 +- .../net-virtio-vhost.x86_64-latest.args | 42 +++ ...{vhost_queues.xml => net-virtio-vhost.xml} | 25 +- ...d-auto-vcpu-no-numatune.x86_64-latest.args | 36 +++ ...static-vcpu-no-numatune.x86_64-latest.args | 36 +++ ...vcpus-topology-mismatch.x86_64-latest.args | 34 +++ .../panic-pseries.ppc64-latest.args | 34 +++ .../pcihole64-gib.x86_64-latest.args | 34 +++ ...pseries-vio-address-clash.ppc64-latest.err | 1 + .../s390-defaultconsole.s390x-latest.args | 33 +++ .../s390-panic.s390x-latest.args | 35 +++ ...eclabel-device-multiple.x86_64-latest.args | 36 +++ ...el-dynamic-none-relabel.x86_64-latest.args | 37 +++ .../seclabel-dynamic-none.x86_64-latest.args | 36 +++ ...serial-target-port-auto.x86_64-latest.args | 42 +++ .../tap-vhost-incorrect.x86_64-latest.args | 40 +++ .../qemuxml2argvdata/tap-vhost-incorrect.xml | 4 +- .../tap-vhost.x86_64-latest.args | 44 +++ tests/qemuxml2argvdata/tap-vhost.xml | 2 +- .../vhost-user-fs-sock.x86_64-latest.args | 34 +++ ...ideo-virtio-gpu-ccw-auto.s390x-latest.args | 36 +++ tests/qemuxml2argvmock.c | 25 ++ tests/qemuxml2argvtest.c | 255 +++++++++++++++++- .../graphics-listen-network.x86_64-latest.xml | 2 +- .../interface-driver.x86_64-latest.xml | 67 ----- .../net-bandwidth.x86_64-latest.xml | 2 +- .../net-bandwidth2.x86_64-latest.xml | 2 +- .../net-coalesce.x86_64-latest.xml | 6 +- .../net-isolated-port.x86_64-latest.xml | 2 +- ...st.xml => net-linkstate.x86_64-latest.xml} | 34 ++- .../net-openvswitch.x86_64-latest.xml | 2 +- ...virtio-network-portgroup.x86_64-latest.xml | 6 +- ...t-virtio-teaming-network.x86_64-latest.xml | 4 +- ...xml => net-virtio-vhost.x86_64-latest.xml} | 29 +- .../tap-vhost-incorrect.x86_64-latest.xml | 4 +- .../tap-vhost.x86_64-latest.xml | 2 +- tests/qemuxml2xmltest.c | 6 +- tests/testutils.c | 14 + tests/testutils.h | 2 + tests/testutilsqemu.h | 3 + .../plug-bridge-basic.xml | 11 + .../plug-network-basic.xml | 10 + tests/virnetworkportxml2xmltest.c | 2 + 95 files changed, 2407 insertions(+), 233 deletions(-) rename tests/{qemuxml2argvdata => genericxml2xmlindata}/graphics-listen-network2.xml (100%) rename tests/{qemuxml2argvdata => genericxml2xmlindata}/smbios-multiple-type2.xml (100%) create mode 100644 tests/genericxml2xmloutdata/graphics-listen-network2.xml create mode 100644 tests/qemuxml2argvdata/boot-menu-disable-with-timeout.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/channel-unix-source-path.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/chardev-label.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/console-compat2.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/cpu-empty.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-features.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/cpu-numa-disordered.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/disk-active-commit.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/disk-mirror-old.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/disk-mirror.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/disk-network-ssh-key.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/disk-network-vxhs.x86_64-5.0.0.args create mode 100644 tests/qemuxml2argvdata/downscript.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/graphics-listen-network.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/hostdev-scsi-autogen-address.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/hostdev-scsi-large-unit.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/hostdev-scsi-shareable.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/interface-driver.xml create mode 100644 tests/qemuxml2argvdata/lease.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/memorybacking-set.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/memorybacking-unset.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/metadata-duplicate.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/metadata.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/net-bandwidth.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/net-bandwidth2.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/net-coalesce.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/net-isolated-port.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/net-linkstate.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/net-linkstate.xml create mode 100644 tests/qemuxml2argvdata/net-midonet.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/net-mtu.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/net-openvswitch.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/net-virtio-network-portgroup.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/net-virtio-teaming-network.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/net-virtio-vhost.x86_64-latest.args rename tests/qemuxml2argvdata/{vhost_queues.xml => net-virtio-vhost.xml} (67%) create mode 100644 tests/qemuxml2argvdata/numad-auto-vcpu-no-numatune.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/numad-static-vcpu-no-numatune.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/numavcpus-topology-mismatch.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/panic-pseries.ppc64-latest.args create mode 100644 tests/qemuxml2argvdata/pcihole64-gib.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/pseries-vio-address-clash.ppc64-latest.err create mode 100644 tests/qemuxml2argvdata/s390-defaultconsole.s390x-latest.args create mode 100644 tests/qemuxml2argvdata/s390-panic.s390x-latest.args create mode 100644 tests/qemuxml2argvdata/seclabel-device-multiple.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/seclabel-dynamic-none-relabel.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/seclabel-dynamic-none.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/serial-target-port-auto.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/tap-vhost-incorrect.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/tap-vhost.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/vhost-user-fs-sock.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/video-virtio-gpu-ccw-auto.s390x-latest.args delete mode 100644 tests/qemuxml2xmloutdata/interface-driver.x86_64-latest.xml rename tests/qemuxml2xmloutdata/{graphics-listen-network2.x86_64-latest.xml => net-linkstate.x86_64-latest.xml} (63%) rename tests/qemuxml2xmloutdata/{vhost_queues.x86_64-latest.xml => net-virtio-vhost.x86_64-latest.xml} (78%) create mode 100644 tests/virnetworkportxml2xmldata/plug-bridge-basic.xml create mode 100644 tests/virnetworkportxml2xmldata/plug-network-basic.xml -- 2.43.0

2 28

[PATCH 0/4] Introduce dynamicMemslots attribute for virtio-mem
by Michal Privoznik 04 Jan '24

04 Jan '24

I couldn't decide whether the new attribute should be in <target/> or <memory/> element. I went with the former, but if anybody feels I should have went with the latter then I can change it. Michal Prívozník (4): conf: Introduce dynamicMemslots attribute for virtio-mem qemu_capabilities: Add QEMU_CAPS_DEVICE_VIRTIO_MEM_PCI_DYNAMIC_MEMSLOTS capability qemu_validate: Check capability for virtio-mem dynamicMemslots qemu_command: Generate cmd line for virtio-mem dynamicMemslots docs/formatdomain.rst | 6 ++++++ src/conf/domain_conf.c | 18 +++++++++++++++++- src/conf/domain_conf.h | 1 + src/conf/schemas/domaincommon.rng | 5 +++++ src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 12 ++++++++++++ src/qemu/qemu_validate.c | 7 +++++++ .../qemucapabilitiesdata/caps_8.2.0_x86_64.xml | 1 + ...emory-hotplug-virtio-mem.x86_64-latest.args | 2 +- .../memory-hotplug-virtio-mem.xml | 2 +- 11 files changed, 54 insertions(+), 3 deletions(-) -- 2.41.0

1 4

[libvirt PATCH v3] qemu: add runtime config option for nbdkit
by Jonathon Jongsma 04 Jan '24

04 Jan '24

Currently when we build with nbdkit support, libvirt will always try to use nbdkit to access remote disk sources when it is available. But without an up-to-date selinux policy allowing this, it will fail. because the required selinux policies are not yet widely available, we have disabled nbdkit support on rpm builds for all distributions before Fedora 40. Unfortunately, this makes it more difficult to test nbdkit support. After someone updates to the necessary selinux policies, they would also need to rebuild libvirt to enable nbdkit support. By introducing a configure option (nbdkit_config_default), we can build packages with nbdkit support but have it disabled by default. Signed-off-by: Jonathon Jongsma <jjongsma(a)redhat.com> Suggested-by: Andrea Bolognani <abologna(a)redhat.com> --- Sorry for the delay in getting out a new version. Thanksgiving break in the USA, etc. Changes in v3: - nbdkit_config_default changed from a meson 'boolean' to a meson 'feature' configure option - print error message for senseless configurations where nbdkit is disabled but nbdkit_config_default is enabled - added a comment to example config file about possibility of the default value changing in the future - don't include the storage_use_nbdkit in the config file if nbdkit support is not compiled in. I used the same strategy that is used in the remote driver where certain config options are disabled based on whether WITH_IP is defined or not. When WITH_NBDKIT is not defined, the value is not included in the config file and we don't attempt to parse it from the config file either. libvirt.spec.in | 18 +++++++-- meson.build | 10 +++++ meson_options.txt | 3 +- ...libvirtd_qemu.aug => libvirtd_qemu.aug.in} | 7 ++++ src/qemu/meson.build | 37 ++++++++++++++++++- src/qemu/qemu.conf.in | 13 +++++++ src/qemu/qemu_conf.c | 19 ++++++++++ src/qemu/qemu_conf.h | 2 + src/qemu/qemu_domain.c | 3 ++ tests/qemuxml2argvtest.c | 15 +++++--- 10 files changed, 114 insertions(+), 13 deletions(-) rename src/qemu/{libvirtd_qemu.aug => libvirtd_qemu.aug.in} (98%) diff --git a/libvirt.spec.in b/libvirt.spec.in index f3fdedfde4..7aa497a565 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -96,6 +96,7 @@ %define with_sanlock 0 %define with_numad 0 %define with_nbdkit 0 +%define with_nbdkit_config_default 0 %define with_firewalld_zone 0 %define with_netcf 0 %define with_libssh2 0 @@ -174,15 +175,17 @@ %endif %endif -# We should only enable nbdkit support if the OS ships a SELinux policy that -# allows libvirt to launch it. Right now that's not the case anywhere, but -# things should be fine by the time Fedora 40 is released. +# We want to build with nbdkit support, but should only enable nbdkit by +# default if the OS ships a SELinux policy that allows libvirt to launch it. +# Right now that's not the case anywhere, but things should be fine by the time +# Fedora 40 is released. # # TODO: add RHEL 9 once a minor release that contains the necessary SELinux # bits exists (we only support the most recent minor release) %if %{with_qemu} + %define with_nbdkit 0%{!?_without_nbdkit:1} %if 0%{?fedora} >= 40 - %define with_nbdkit 0%{!?_without_nbdkit:1} + %define with_nbdkit_config_default 0%{!?_without_nbdkit_config_default:1} %endif %endif @@ -1214,6 +1217,12 @@ exit 1 %define arg_nbdkit -Dnbdkit=disabled %endif +%if %{with_nbdkit_config_default} + %define arg_nbdkit_config_default -Dnbdkit_config_default=enabled +%else + %define arg_nbdkit_config_default -Dnbdkit_config_default=disabled +%endif + %if %{with_fuse} %define arg_fuse -Dfuse=enabled %else @@ -1329,6 +1338,7 @@ export SOURCE_DATE_EPOCH=$(stat --printf='%Y' %{_specdir}/libvirt.spec) %{?arg_sanlock} \ -Dlibpcap=enabled \ %{?arg_nbdkit} \ + %{?arg_nbdkit_config_default} \ -Dlibnl=enabled \ -Daudit=enabled \ -Ddtrace=enabled \ diff --git a/meson.build b/meson.build index 62481a008d..e63b807f21 100644 --- a/meson.build +++ b/meson.build @@ -1012,6 +1012,16 @@ if not conf.has('WITH_NBDKIT') libnbd_dep = dependency('', required: false) endif +# default value for storage_use_nbdkit config option. +# For now 'auto' just maps to disabled, but in the future it may depend on +# which security drivers are enabled +use_nbdkit_default = get_option('nbdkit_config_default').enabled() + +if use_nbdkit_default and not conf.has('WITH_NBDKIT') + error('nbdkit_config_default requires nbdkit to be enabled') +endif +conf.set10('USE_NBDKIT_DEFAULT', use_nbdkit_default) + libnl_version = '3.0' if not get_option('libnl').disabled() and host_machine.system() == 'linux' libnl_dep = dependency('libnl-3.0', version: '>=' + libnl_version, required: get_option('libnl')) diff --git a/meson_options.txt b/meson_options.txt index a0928102bf..05fd63dd41 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -104,7 +104,8 @@ option('loader_nvram', type: 'string', value: '', description: 'Pass list of pai option('login_shell', type: 'feature', value: 'auto', description: 'build virt-login-shell') option('nss', type: 'feature', value: 'auto', description: 'enable Name Service Switch plugin for resolving guest IP addresses') option('numad', type: 'feature', value: 'auto', description: 'use numad to manage CPU placement dynamically') -option('nbdkit', type: 'feature', value: 'auto', description: 'use nbdkit to access network disks') +option('nbdkit', type: 'feature', value: 'auto', description: 'Build nbdkit storage backend') +option('nbdkit_config_default', type: 'feature', value: 'disabled', description: 'Whether to use nbdkit storage backend for network disks by default (configurable)') option('pm_utils', type: 'feature', value: 'auto', description: 'use pm-utils for power management') option('sysctl_config', type: 'feature', value: 'auto', description: 'Whether to install sysctl configs') option('tls_priority', type: 'string', value: 'NORMAL', description: 'set the default TLS session priority string') diff --git a/src/qemu/libvirtd_qemu.aug b/src/qemu/libvirtd_qemu.aug.in similarity index 98% rename from src/qemu/libvirtd_qemu.aug rename to src/qemu/libvirtd_qemu.aug.in index ed097ea3d9..bcc0aa8938 100644 --- a/src/qemu/libvirtd_qemu.aug +++ b/src/qemu/libvirtd_qemu.aug.in @@ -147,6 +147,10 @@ module Libvirtd_qemu = let capability_filters_entry = str_array_entry "capability_filters" +@CUT_WITH_NBDKIT@ + let storage_entry = bool_entry "storage_use_nbdkit" + +@END@ (* Each entry in the config is one of the following ... *) let entry = default_tls_entry | vnc_entry @@ -170,6 +174,9 @@ module Libvirtd_qemu = | nbd_entry | swtpm_entry | capability_filters_entry +@CUT_WITH_NBDKIT@ + | storage_entry +@END@ | obsolete_entry let comment = [ label "#comment" . del /#[ \t]*/ "# " . store /([^ \t\n][^\n]*)?/ . del /\n/ "\n" ] diff --git a/src/qemu/meson.build b/src/qemu/meson.build index 2279fef2ca..43519e2834 100644 --- a/src/qemu/meson.build +++ b/src/qemu/meson.build @@ -137,9 +137,41 @@ if conf.has('WITH_QEMU') qemu_user_group_conf = configuration_data({ 'QEMU_USER': qemu_user, 'QEMU_GROUP': qemu_group, + 'USE_NBDKIT_DEFAULT': use_nbdkit_default.to_int(), }) + + # preprocess config files to remove items related to features that are not + # compiled in + preprocess_config_files = [ + { + 'inpath': 'qemu.conf.in', + 'outpath': 'qemu.conf.tmp', + 'outvar': 'qemu_conf_tmp', + }, + { + 'inpath': 'libvirtd_qemu.aug.in', + 'outpath': 'libvirtd_qemu.aug', + 'outvar': 'libvirtd_qemu_aug', + } + ] + foreach item : preprocess_config_files + if conf.has('WITH_NBDKIT') + preprocess_cmd = [ 'sed', '-e', '/[@]CUT_WITH_NBDKIT[@]/d', '-e', '/[@]END[@]/d', '@INPUT@' ] + else + preprocess_cmd = [ 'sed', '-e', '/[@]CUT_WITH_NBDKIT[@]/,/[@]END[@]/d', '@INPUT@' ] + endif + + tmp = configure_file( + input: item['inpath'], + output: item['outpath'], + command: preprocess_cmd, + capture: true, + ) + set_variable(item['outvar'], tmp) + endforeach + qemu_conf = configure_file( - input: 'qemu.conf.in', + input: qemu_conf_tmp, output: 'qemu.conf', configuration: qemu_user_group_conf, ) @@ -147,6 +179,7 @@ if conf.has('WITH_QEMU') qemu_user_group_hack_conf = configuration_data({ 'QEMU_USER': qemu_user, 'QEMU_GROUP': qemu_group, + 'USE_NBDKIT_DEFAULT': use_nbdkit_default.to_int(), # This hack is necessary because the output file is going to be # used as input for another configure_file() call later, which # will take care of substituting @CONFIG@ with useful data @@ -159,7 +192,7 @@ if conf.has('WITH_QEMU') ) virt_conf_files += qemu_conf - virt_aug_files += files('libvirtd_qemu.aug') + virt_aug_files += libvirtd_qemu_aug virt_test_aug_files += { 'name': 'test_libvirtd_qemu.aug', 'aug': test_libvirtd_qemu_aug_tmp, diff --git a/src/qemu/qemu.conf.in b/src/qemu/qemu.conf.in index 6897e0f760..76633c6a2f 100644 --- a/src/qemu/qemu.conf.in +++ b/src/qemu/qemu.conf.in @@ -974,3 +974,16 @@ # "full" - both QEMU and its helper processes are placed into separate # scheduling group #sched_core = "none" + +@CUT_WITH_NBDKIT@ +# Using nbdkit to access remote disk sources +# +# If this is set then libvirt will use nbdkit to access remote disk sources +# when available. nbdkit will export an NBD share to QEMU rather than having +# QEMU attempt to access the remote server directly. +# +# Possible values are 0 or 1. Default value is @USE_NBDKIT_DEFAULT@. Please +# note that the default might change in future releases. +# +# storage_use_nbdkit = @USE_NBDKIT_DEFAULT@ +@END@ diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 513b5ebb1e..e1a1bc3655 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -285,6 +285,7 @@ virQEMUDriverConfig *virQEMUDriverConfigNew(bool privileged, return NULL; cfg->deprecationBehavior = g_strdup("none"); + cfg->storageUseNbdkit = USE_NBDKIT_DEFAULT; return g_steal_pointer(&cfg); } @@ -1065,6 +1066,19 @@ virQEMUDriverConfigLoadCapsFiltersEntry(virQEMUDriverConfig *cfg, } +#if WITH_NBDKIT +static int +virQEMUDriverConfigLoadStorageEntry(virQEMUDriverConfig *cfg, + virConf *conf) +{ + if (virConfGetValueBool(conf, "storage_use_nbdkit", &cfg->storageUseNbdkit) < 0) + return -1; + + return 0; +} +#endif /* WITH_NBDKIT */ + + int virQEMUDriverConfigLoadFile(virQEMUDriverConfig *cfg, const char *filename, bool privileged) @@ -1136,6 +1150,11 @@ int virQEMUDriverConfigLoadFile(virQEMUDriverConfig *cfg, if (virQEMUDriverConfigLoadCapsFiltersEntry(cfg, conf) < 0) return -1; +#if WITH_NBDKIT + if (virQEMUDriverConfigLoadStorageEntry(cfg, conf) < 0) + return -1; +#endif /* WITH_NBDKIT */ + return 0; } diff --git a/src/qemu/qemu_conf.h b/src/qemu/qemu_conf.h index 1a3ba3a0fb..36049b4bfa 100644 --- a/src/qemu/qemu_conf.h +++ b/src/qemu/qemu_conf.h @@ -230,6 +230,8 @@ struct _virQEMUDriverConfig { char *deprecationBehavior; + bool storageUseNbdkit; + virQEMUSchedCore schedCore; }; diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 953808fcfe..0891ddabe9 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -10296,6 +10296,9 @@ qemuDomainPrepareStorageSourceNbdkit(virStorageSource *src, { g_autoptr(qemuNbdkitCaps) nbdkit = NULL; + if (!cfg->storageUseNbdkit) + return false; + if (virStorageSourceGetActualType(src) != VIR_STORAGE_TYPE_NETWORK) return false; diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index b2ea2191dc..74d20b9132 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1125,7 +1125,6 @@ mymain(void) DO_TEST_CAPS_LATEST("disk-cdrom-empty-network-invalid"); DO_TEST_CAPS_LATEST("disk-cdrom-bus-other"); DO_TEST_CAPS_LATEST("disk-cdrom-network"); - DO_TEST_CAPS_LATEST_NBDKIT("disk-cdrom-network-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_CURL); DO_TEST_CAPS_LATEST("disk-cdrom-tray"); DO_TEST_CAPS_LATEST("disk-floppy"); DO_TEST_CAPS_LATEST("disk-floppy-q35"); @@ -1171,8 +1170,6 @@ mymain(void) DO_TEST_CAPS_VER("disk-network-sheepdog", "6.0.0"); DO_TEST_CAPS_LATEST("disk-network-source-auth"); DO_TEST_CAPS_LATEST("disk-network-source-curl"); - DO_TEST_CAPS_LATEST_NBDKIT("disk-network-source-curl-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_CURL); - DO_TEST_CAPS_LATEST_NBDKIT("disk-network-source-curl-nbdkit-backing", QEMU_NBDKIT_CAPS_PLUGIN_CURL); DO_TEST_CAPS_LATEST("disk-network-nfs"); driver.config->vxhsTLS = 1; driver.config->nbdTLSx509secretUUID = g_strdup("6fd3f62d-9fe7-4a4e-a869-7acd6376d8ea"); @@ -1183,13 +1180,10 @@ mymain(void) DO_TEST_CAPS_LATEST("disk-network-tlsx509-nbd-hostname"); DO_TEST_CAPS_VER("disk-network-tlsx509-vxhs", "5.0.0"); DO_TEST_CAPS_LATEST("disk-network-http"); - DO_TEST_CAPS_LATEST_NBDKIT("disk-network-http-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_CURL); VIR_FREE(driver.config->nbdTLSx509secretUUID); VIR_FREE(driver.config->vxhsTLSx509secretUUID); driver.config->vxhsTLS = 0; DO_TEST_CAPS_LATEST("disk-network-ssh"); - DO_TEST_CAPS_LATEST_NBDKIT("disk-network-ssh-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_SSH); - DO_TEST_CAPS_LATEST_NBDKIT("disk-network-ssh-password", QEMU_NBDKIT_CAPS_PLUGIN_SSH); DO_TEST_CAPS_LATEST("disk-no-boot"); DO_TEST_CAPS_LATEST("disk-nvme"); DO_TEST_CAPS_VER("disk-vhostuser-numa", "4.2.0"); @@ -1259,6 +1253,15 @@ mymain(void) DO_TEST_CAPS_LATEST("disk-geometry"); DO_TEST_CAPS_LATEST("disk-blockio"); + driver.config->storageUseNbdkit = 1; + DO_TEST_CAPS_LATEST_NBDKIT("disk-cdrom-network-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_CURL); + DO_TEST_CAPS_LATEST_NBDKIT("disk-network-source-curl-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_CURL); + DO_TEST_CAPS_LATEST_NBDKIT("disk-network-source-curl-nbdkit-backing", QEMU_NBDKIT_CAPS_PLUGIN_CURL); + DO_TEST_CAPS_LATEST_NBDKIT("disk-network-http-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_CURL); + DO_TEST_CAPS_LATEST_NBDKIT("disk-network-ssh-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_SSH); + DO_TEST_CAPS_LATEST_NBDKIT("disk-network-ssh-password", QEMU_NBDKIT_CAPS_PLUGIN_SSH); + driver.config->storageUseNbdkit = 0; + DO_TEST_CAPS_VER("disk-virtio-scsi-reservations", "5.2.0"); DO_TEST_CAPS_LATEST("disk-virtio-scsi-reservations"); -- 2.41.0

2 3

[libvirt PATCH 0/5] add loongarch support for libvirt
by xianglai li 04 Jan '24

04 Jan '24

From: lixianglai <lixianglai(a)loongson.cn> Hello, Everyone: This patch series adds libvirt support for loongarch.Although the bios path and name has not been officially integrated into qemu and we think there are still many shortcomings, we try to push a version of patch to the community according to the opinions of the community, hoping to listen to everyone's opinions. Anyway we have a version of libvirt that supports loongarch. You can also get libvirt's patch from the link below: https://gitlab.com/lixianglai/libvirt branch: loongarch Since the patch associated with loongarch has not yet been submitted to the virt-manager community, we are providing a temporary patch with loongarch for the time being patch's virt-manager, the open source work of virt-manager adding loongarch will be followed up later or synchronized with the open source libvirt. You can get the virt-manager code with loongarch patch from the link below: https://github.com/loongson/virt-manager branch: loongarch loongarch's virtual machine bios is not yet available in qemu, so you can get it from the following link https://github.com/loongson/Firmware/tree/main/LoongArchVirtMachine (Note: You should clone the repository using git instead of downloading the file via wget or you'll get xml) We named the bios edk2-loongarch64-code.fd, edk2-loongarch64-vars.fd is used to store pflash images of non-volatile variables.After installing qemu-system-loongarch64, you need to manually copy these two files to the /user/share/qemu directory. Since there is no fedora operating system that supports the loongarch architecture, you can find an iso that supports loongarch at the link below for testing purposes: https://github.com/fedora-remix-loongarch/releases-info Well, if you have completed the above steps I think you can now install loongarch virtual machine, you can install it through the virt-manager graphical interface, or install it through vrit-install, here is an example of installing it using virt-install: virt-install \ --virt-type=qemu \ --name loongarch-test \ --memory 4096 \ --vcpus=4 \ --arch=loongarch64 \ --boot cdrom \ --disk device=cdrom,bus=scsi,path=/root/livecd-fedora-mate-4.loongarch64.iso \ --disk path=/var/lib/libvirt/images/debian12-loongarch64.qcow2,size=10,format=qcow2,bus=scsi \ --network network=default \ --osinfo archlinux \ --feature acpi=true \ --video=virtio \ --graphics=vnc,listen=0.0.0.0 lixianglai (5): Add loongarch cpu support Add loongarch cpu model and vendor info Config some capabilities for loongarch virt machine Implement the method of getting host info for loongarch Add bios path for loongarch po/POTFILES | 1 + src/conf/schemas/basictypes.rng | 1 + src/cpu/cpu.c | 2 + src/cpu/cpu.h | 2 + src/cpu/cpu_loongarch.c | 742 +++++++++++++++++++++++++++++ src/cpu/cpu_loongarch.h | 25 + src/cpu/cpu_loongarch_data.h | 37 ++ src/cpu/meson.build | 1 + src/cpu_map/index.xml | 5 + src/cpu_map/loongarch_la464.xml | 6 + src/cpu_map/loongarch_vendors.xml | 3 + src/cpu_map/meson.build | 2 + src/qemu/qemu.conf.in | 3 +- src/qemu/qemu_capabilities.c | 6 + src/qemu/qemu_conf.c | 3 +- src/qemu/qemu_domain.c | 32 ++ src/qemu/qemu_domain.h | 1 + src/qemu/qemu_domain_address.c | 55 +++ src/qemu/qemu_validate.c | 2 +- src/qemu/test_libvirtd_qemu.aug.in | 1 + src/util/virarch.c | 4 + src/util/virarch.h | 4 + src/util/virhostcpu.c | 4 +- src/util/virsysinfo.c | 5 +- 24 files changed, 940 insertions(+), 7 deletions(-) create mode 100644 src/cpu/cpu_loongarch.c create mode 100644 src/cpu/cpu_loongarch.h create mode 100644 src/cpu/cpu_loongarch_data.h create mode 100644 src/cpu_map/loongarch_la464.xml create mode 100644 src/cpu_map/loongarch_vendors.xml -- 2.27.0

3 23

[PATCH] Fix regression on default bus for keyboard/mouse from c4bc4d3b #577
by Jonathan Wright 03 Jan '24

03 Jan '24

Signed-off-by: Jonathan Wright <jonathan(a)almalinux.org> --- src/conf/domain_postparse.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/domain_postparse.c b/src/conf/domain_postparse.c index e79913b73f..ee27023f3e 100644 --- a/src/conf/domain_postparse.c +++ b/src/conf/domain_postparse.c @@ -657,6 +657,7 @@ virDomainInputDefPostParse(virDomainInputDef *input, if ((input->type == VIR_DOMAIN_INPUT_TYPE_MOUSE || input->type == VIR_DOMAIN_INPUT_TYPE_KBD) && (ARCH_IS_X86(def->os.arch) || def->os.arch == VIR_ARCH_NONE)) { + input->bus = VIR_DOMAIN_INPUT_BUS_PS2; } else if (ARCH_IS_S390(def->os.arch) || input->type == VIR_DOMAIN_INPUT_TYPE_PASSTHROUGH) { input->bus = VIR_DOMAIN_INPUT_BUS_VIRTIO; -- 2.43.0

2 2

[PATCH 00/10] qemu: Improve disk resizing on block devices and support resizing of disk with slice
by Peter Krempa 03 Jan '24

03 Jan '24

This series implements two features: - automatic size discovery when resizing a raw disk on a block device - resizing of raw disks when a 'storage slice' is in use Peter Krempa (10): qemu: block: Introduce helpers for properly testing for 'raw' and 'luks' images qemu: Use qemuBlockStorageSourceIsQEMULuks/qemuBlockStorageSourceIsRaw qemuDomainBlockResize: Agregate all checks at the beginning vsh: Introduce simple version of VSH_ALTERNATIVE_OPTIONS_EXPR virDomainBlockResize: Introduce VIR_DOMAIN_BLOCK_RESIZE_CAPACITY qemuDomainBlockResize: Implement VIR_DOMAIN_BLOCK_RESIZE_CAPACITY qemu: block: Make 'slice' layer effective for 'raw' storage source qemu: block: Format storage slice properties optionally virStorageSourceSliceFree: Export function qemuDomainBlockResize: Properly resize disks with storage slice docs/manpages/virsh.rst | 6 +- include/libvirt/libvirt-domain.h | 1 + src/conf/storage_source_conf.c | 2 +- src/conf/storage_source_conf.h | 2 + src/libvirt-domain.c | 5 + src/libvirt_private.syms | 1 + src/qemu/qemu_block.c | 193 +++++++++++++----- src/qemu/qemu_block.h | 9 + src/qemu/qemu_command.c | 2 +- src/qemu/qemu_driver.c | 99 ++++++++- .../disk-slices.x86_64-latest.args | 14 +- tools/virsh-domain.c | 10 +- tools/vsh.h | 4 + 13 files changed, 276 insertions(+), 72 deletions(-) -- 2.43.0

3 17

[PATCH v2] qemu_driver: Don't handle the EOF event if vm get restarted
by tugy＠chinatelecom.cn 03 Jan '24

03 Jan '24

From: Guoyi Tu <tugy(a)chinatelecom.cn> Currently, libvirt creates a thread pool with only on thread to handle all qemu monitor events for virtual machines, In the cases that if the thread gets stuck while handling a monitor EOF event, such as unable to kill the virtual machine process or release resources, the events of other virtual machine will be also blocked, which will lead to the abnormal behavior of other virtual machines. For instance, when another virtual machine completes a shutdown operation and the monitor EOF event has been queued but remains unprocessed, we immediately destroy and start the virtual machine again, at a later time when EOF event get processed, the processMonitorEOFEvent() will kill the virtual machine that just started. To address this issue, in the processMonitorEOFEvent(), we check whether the current virtual machine's id is equal to the the one at the time the event was generated. If they do not match, we immediately return. Signed-off-by: Guoyi Tu <tugy(a)chinatelecom.cn> Signed-off-by: dengpengcheng <dengpc12(a)chinatelecom.cn> --- src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_driver.c | 11 +++++++++-- src/qemu/qemu_process.c | 2 +- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 953808fcfe..435ee621df 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -11470,7 +11470,6 @@ qemuProcessEventFree(struct qemuProcessEvent *event) case QEMU_PROCESS_EVENT_NETDEV_STREAM_DISCONNECTED: case QEMU_PROCESS_EVENT_NIC_RX_FILTER_CHANGED: case QEMU_PROCESS_EVENT_SERIAL_CHANGED: - case QEMU_PROCESS_EVENT_MONITOR_EOF: case QEMU_PROCESS_EVENT_GUEST_CRASHLOADED: g_free(event->data); break; @@ -11484,6 +11483,7 @@ qemuProcessEventFree(struct qemuProcessEvent *event) case QEMU_PROCESS_EVENT_UNATTENDED_MIGRATION: case QEMU_PROCESS_EVENT_RESET: case QEMU_PROCESS_EVENT_NBDKIT_EXITED: + case QEMU_PROCESS_EVENT_MONITOR_EOF: case QEMU_PROCESS_EVENT_LAST: break; } diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 64afae6450..cfc5b79657 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3854,7 +3854,8 @@ processJobStatusChangeEvent(virDomainObj *vm, static void processMonitorEOFEvent(virQEMUDriver *driver, - virDomainObj *vm) + virDomainObj *vm, + int domid) { qemuDomainObjPrivate *priv = vm->privateData; int eventReason = VIR_DOMAIN_EVENT_STOPPED_SHUTDOWN; @@ -3863,6 +3864,12 @@ processMonitorEOFEvent(virQEMUDriver *driver, unsigned int stopFlags = 0; virObjectEvent *event = NULL; + if (vm->def->id != domid) { + VIR_ERROR("Domain %s was restarted, ignoring EOF", + vm->def->name); + return; + } + if (qemuProcessBeginStopJob(vm, VIR_JOB_DESTROY, true) < 0) return; @@ -4082,7 +4089,7 @@ static void qemuProcessEventHandler(void *data, void *opaque) processJobStatusChangeEvent(vm, processEvent->data); break; case QEMU_PROCESS_EVENT_MONITOR_EOF: - processMonitorEOFEvent(driver, vm); + processMonitorEOFEvent(driver, vm, GPOINTER_TO_INT(processEvent->data)); break; case QEMU_PROCESS_EVENT_PR_DISCONNECT: processPRDisconnectEvent(vm); diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index fc05b4b24f..696d526a5d 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -316,7 +316,7 @@ qemuProcessHandleMonitorEOF(qemuMonitor *mon, } qemuProcessEventSubmit(vm, QEMU_PROCESS_EVENT_MONITOR_EOF, - 0, 0, NULL); + 0, 0, GINT_TO_POINTER(vm->def->id)); /* We don't want this EOF handler to be called over and over while the * thread is waiting for a job. -- 2.17.1

3 2

[PATCH] Fix regression on default bus for keyboard/mouse from c4bc4d3b #577
by Jonathan Wright 03 Jan '24

03 Jan '24

Signed-off-by: Jonathan Wright <jonathan(a)almalinux.org> --- src/conf/domain_postparse.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/domain_postparse.c b/src/conf/domain_postparse.c index e79913b73f..ee27023f3e 100644 --- a/src/conf/domain_postparse.c +++ b/src/conf/domain_postparse.c @@ -657,6 +657,7 @@ virDomainInputDefPostParse(virDomainInputDef *input, if ((input->type == VIR_DOMAIN_INPUT_TYPE_MOUSE || input->type == VIR_DOMAIN_INPUT_TYPE_KBD) && (ARCH_IS_X86(def->os.arch) || def->os.arch == VIR_ARCH_NONE)) { + input->bus = VIR_DOMAIN_INPUT_BUS_PS2; } else if (ARCH_IS_S390(def->os.arch) || input->type == VIR_DOMAIN_INPUT_TYPE_PASSTHROUGH) { input->bus = VIR_DOMAIN_INPUT_BUS_VIRTIO; -- 2.43.0

1 0

[PATCH] conf: Restore setting default bus for input devices
by Michal Privoznik 03 Jan '24

03 Jan '24

Prior to v9.3.0-rc1~30 we used to set default bus for <input/> devices, during XML parsing. In the commit this code was moved to a post parse callback. But somehow the line that sets the bus in one specific case disappeared. Bring it back. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/577 Fixes: c4bc4d3b82fbe22e03c986ca896090f481df5c10 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/conf/domain_postparse.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/domain_postparse.c b/src/conf/domain_postparse.c index e79913b73f..ed9411f5e6 100644 --- a/src/conf/domain_postparse.c +++ b/src/conf/domain_postparse.c @@ -657,6 +657,7 @@ virDomainInputDefPostParse(virDomainInputDef *input, if ((input->type == VIR_DOMAIN_INPUT_TYPE_MOUSE || input->type == VIR_DOMAIN_INPUT_TYPE_KBD) && (ARCH_IS_X86(def->os.arch) || def->os.arch == VIR_ARCH_NONE)) { + input->bus = VIR_DOMAIN_INPUT_BUS_PS2; } else if (ARCH_IS_S390(def->os.arch) || input->type == VIR_DOMAIN_INPUT_TYPE_PASSTHROUGH) { input->bus = VIR_DOMAIN_INPUT_BUS_VIRTIO; -- 2.41.0

2 1

[PATCH] qemucapabilitiesdata: Final update of 'caps_8.2.0_x86_64'
by Peter Krempa 03 Jan '24

03 Jan '24

QEMU 8.2 was released, update the x86_64 data for a final time. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- .../qemucapabilitiesdata/caps_8.2.0_x86_64.replies | 13 +++++++------ tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml | 4 ++-- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.replies b/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.replies index b9d26f633c..56011f8317 100644 --- a/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.replies +++ b/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.replies @@ -17,11 +17,11 @@ { "return": { "qemu": { - "micro": 50, - "minor": 1, + "micro": 0, + "minor": 2, "major": 8 }, - "package": "v8.1.0-3111-gad6ef0a42e" + "package": "v8.2.0" }, "id": "libvirt-2" } @@ -30705,9 +30705,10 @@ "type": "bool" }, { - "default-value": 0, - "name": "len-reserved-regions", - "type": "uint32" + "default-value": [ + ], + "name": "reserved-regions", + "type": "list" }, { "default-value": 0, diff --git a/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml b/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml index ef3bd14597..ee52952702 100644 --- a/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml @@ -199,9 +199,9 @@ <flag name='qcow2-discard-no-unref'/> <flag name='run-with.async-teardown'/> <flag name='virtio-blk-vhost-vdpa'/> - <version>8001050</version> + <version>8002000</version> <microcodeVersion>43100246</microcodeVersion> - <package>v8.1.0-3111-gad6ef0a42e</package> + <package>v8.2.0</package> <arch>x86_64</arch> <hostCPU type='kvm' model='base' migratability='yes'> <property name='avx-ne-convert' type='boolean' value='false'/> -- 2.43.0

2 1

[PATCH] ci: Switch from FreeBSD 12.0 to FreeBSD 14.0
by Michal Privoznik 03 Jan '24

03 Jan '24

FreeBSD 12.0 is no longer supported since 14.0 is out. Change the CI manifest and refresh the rest. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- .../{freebsd-12.vars => freebsd-14.vars} | 0 ci/gitlab/builds.yml | 28 +++++++++---------- ci/manifest.yml | 4 +-- 3 files changed, 16 insertions(+), 16 deletions(-) rename ci/cirrus/{freebsd-12.vars => freebsd-14.vars} (100%) diff --git a/ci/cirrus/freebsd-12.vars b/ci/cirrus/freebsd-14.vars similarity index 100% rename from ci/cirrus/freebsd-12.vars rename to ci/cirrus/freebsd-14.vars diff --git a/ci/gitlab/builds.yml b/ci/gitlab/builds.yml index 5cc904ffb7..434e272e5a 100644 --- a/ci/gitlab/builds.yml +++ b/ci/gitlab/builds.yml @@ -1028,20 +1028,6 @@ mingw64-fedora-rawhide-local-env: # Native cirrus build jobs -x86_64-freebsd-12: - extends: .cirrus_build_job - needs: [] - allow_failure: false - variables: - CIRRUS_VM_IMAGE_NAME: freebsd-12-4 - CIRRUS_VM_IMAGE_SELECTOR: image_family - CIRRUS_VM_INSTANCE_TYPE: freebsd_instance - INSTALL_COMMAND: pkg install -y - NAME: freebsd-12 - UPDATE_COMMAND: pkg update - UPGRADE_COMMAND: pkg upgrade -y - - x86_64-freebsd-13: extends: .cirrus_build_job needs: [] @@ -1056,6 +1042,20 @@ x86_64-freebsd-13: UPGRADE_COMMAND: pkg upgrade -y +x86_64-freebsd-14: + extends: .cirrus_build_job + needs: [] + allow_failure: false + variables: + CIRRUS_VM_IMAGE_NAME: freebsd-14-0 + CIRRUS_VM_IMAGE_SELECTOR: image_family + CIRRUS_VM_INSTANCE_TYPE: freebsd_instance + INSTALL_COMMAND: pkg install -y + NAME: freebsd-14 + UPDATE_COMMAND: pkg update + UPGRADE_COMMAND: pkg upgrade -y + + aarch64-macos-13: extends: .cirrus_build_job needs: [] diff --git a/ci/manifest.yml b/ci/manifest.yml index 85f6b9d878..44353dd05b 100644 --- a/ci/manifest.yml +++ b/ci/manifest.yml @@ -192,10 +192,10 @@ targets: allow-failure: true builds: false - freebsd-12: x86_64 - freebsd-13: x86_64 + freebsd-14: x86_64 + opensuse-leap-15: jobs: - arch: x86_64 -- 2.41.0

2 1

Plans for 10.0.0 release (freeze on Tuesday 09 Jan)
by Jiri Denemark 03 Jan '24

03 Jan '24

We are getting close to 10.0.0 release of libvirt. To aim for the release on Monday 15 Jan I suggest entering the freeze on Tuesday 09 Jan and tagging RC2 on Friday 12 Jan. I hope this works for everyone. Jirka

1 0

[PATCH] storage_util: Fix the false condition in virStorageBackendDeviceIsEmpty
by Han Han 02 Jan '24

02 Jan '24

In virStorageBackendDeviceIsEmpty, the return value for virStorageBackendPARTEDValidLabel is -1 or 0. That makes the later condition 'ret == -2' make always false. Remove the always false condition. Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE. Fixes: https://gitlab.com/libvirt/libvirt/-/issues/576 Signed-off-by: Han Han <hhan(a)redhat.com> --- src/storage/storage_util.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index 7bf815d978..82bcfa5838 100644 --- a/src/storage/storage_util.c +++ b/src/storage/storage_util.c @@ -3352,15 +3352,9 @@ virStorageBackendDeviceIsEmpty(const char *devpath, writelabel)) == -2) ret = virStorageBackendPARTEDValidLabel(devpath, format, writelabel); - if (ret == -2 && !writelabel) + if (!writelabel) ret = 0; - if (ret == -2) { - virReportError(VIR_ERR_OPERATION_INVALID, - _("Unable to probe '%1$s' for existing data, forced overwrite is necessary"), - devpath); - } - return ret == 0; } -- 2.43.0

2 1

[PATCH v2] Improve error message in remoteGetUNIXSocket
by Martin Kletzander 02 Jan '24

02 Jan '24

By adding a link to an explanation in the kbase. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- v2: - Do not print first socket path - Add a kbase article explaining the details and solutions - Add a link to said article v1: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/WGEV… .../kbase/failed_connection_after_install.rst | 58 +++++++++++++++++++ docs/kbase/index.rst | 3 + docs/kbase/meson.build | 1 + src/remote/remote_sockets.c | 2 +- 4 files changed, 63 insertions(+), 1 deletion(-) create mode 100644 docs/kbase/failed_connection_after_install.rst diff --git a/docs/kbase/failed_connection_after_install.rst b/docs/kbase/failed_connection_after_install.rst new file mode 100644 index 000000000000..cea57c460e10 --- /dev/null +++ b/docs/kbase/failed_connection_after_install.rst @@ -0,0 +1,58 @@ +======================================== +Libvirt does not work after installation +======================================== + +.. contents:: + +TL;DR +===== + +Most probably you want to start a virtqemud socket: + +:: + + # systemctl start virtqemud.socket + +If you are unsure whether to do this, please read the rest of this document. + +Symptom +======= + +After installing libvirt or a virt tool that uses libvirt, commands do +not work when run as root: + +:: + + # virsh list + error: failed to connect to the hypervisor + error: Operation not supported: Cannot use direct socket mode if no URI is set. + For more information see https://libvirt.org/kbase/failed_connection_after_install.html + +Root cause +========== + +Distribution guidelines and/or configurations may discourage or prohibit +starting services as part of a package installation. And because libvirt cannot +know where you might want to connect it cannot start it on its own. + +Solution +======== + +After installing libvirt you may need to start a particular libvirt daemon on +the local machine, set a (default) URI to connect to or, alternatively, +rebooting the machine might work. + +If you are trying to connect to a remote libvirt daemon you need to specify a `connection URI <../uri.html>`__. + +If you are trying to control a local hypervisor, then the solution depends on various factors. You should know: + +- what hypervisor driver you want to connect to, whether it is ``virtqemud`` for QEMU, ``virtchd`` for Cloud Hypervisor, etc. and +- how to start a service or socket (in case of systemd) on you system. + +Example of the most common solution, trying to use QEMU/KVM on Linux with systemd as an init system, is: + +:: + + # systemctl start virtqemud.socket + +also provided on the top of the page. diff --git a/docs/kbase/index.rst b/docs/kbase/index.rst index 896ececdf258..e51b35cbfce5 100644 --- a/docs/kbase/index.rst +++ b/docs/kbase/index.rst @@ -64,6 +64,9 @@ Usage `Secure Boot <secureboot.html>`__ Enable and disable the Secure Boot feature +`Connection fail after installation <failed_connection_after_install.html>`__ + Explanation of a common issue users stumble upon after installation + Debugging --------- diff --git a/docs/kbase/meson.build b/docs/kbase/meson.build index 5b608293e27c..6d4ca90215a5 100644 --- a/docs/kbase/meson.build +++ b/docs/kbase/meson.build @@ -2,6 +2,7 @@ docs_kbase_files = [ 'backing_chains', 'debuglogs', 'domainstatecapture', + 'failed_connection_after_install', 'index', 'kvm-realtime', 'launch_security_sev', diff --git a/src/remote/remote_sockets.c b/src/remote/remote_sockets.c index 4ab3d72933e2..8d403b6f014a 100644 --- a/src/remote/remote_sockets.c +++ b/src/remote/remote_sockets.c @@ -398,7 +398,7 @@ remoteGetUNIXSocket(remoteDriverTransport transport, if (!direct_sock_name) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", - _("Cannot use direct socket mode if no URI is set")); + _("Cannot use direct socket mode if no URI is set. For more information see https://libvirt.org/kbase/failed_connection_after_install.html")); return NULL; } -- 2.43.0

2 1

[PATCH] qemu: Replace the deprecated short-formed option "unix"
by Han Han 21 Dec '23

21 Dec '23

Change to the boolean option "unix=on" Signed-off-by: Han Han <hhan(a)redhat.com> --- src/qemu/qemu_command.c | 2 +- .../graphics-spice-auto-socket-cfg.x86_64-latest.args | 2 +- .../graphics-spice-auto-socket.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/graphics-spice-socket.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/name-escape.x86_64-latest.args | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index b45a5e4f80..bc285c0b6f 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -8204,7 +8204,7 @@ qemuBuildGraphicsSPICECommandLine(virQEMUDriverConfig *cfg, switch (glisten->type) { case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET: - virBufferAddLit(&opt, "unix,addr="); + virBufferAddLit(&opt, "unix=on,addr="); virQEMUBuildBufferEscapeComma(&opt, glisten->socket); virBufferAddLit(&opt, ","); hasInsecure = true; diff --git a/tests/qemuxml2argvdata/graphics-spice-auto-socket-cfg.x86_64-latest.args b/tests/qemuxml2argvdata/graphics-spice-auto-socket-cfg.x86_64-latest.args index a50ca802ae..03fa8e868a 100644 --- a/tests/qemuxml2argvdata/graphics-spice-auto-socket-cfg.x86_64-latest.args +++ b/tests/qemuxml2argvdata/graphics-spice-auto-socket-cfg.x86_64-latest.args @@ -27,7 +27,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.config \ -boot strict=on \ -device '{"driver":"piix3-usb-uhci","id":"usb","bus":"pci.0","addr":"0x1.0x2"}' \ -audiodev '{"id":"audio1","driver":"spice"}' \ --spice unix,addr=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/spice.sock,seamless-migration=on \ +-spice unix=on,addr=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/spice.sock,seamless-migration=on \ -device '{"driver":"cirrus-vga","id":"video0","bus":"pci.0","addr":"0x2"}' \ -sandbox on,obsolete=deny,elevateprivileges=deny,spawn=deny,resourcecontrol=deny \ -msg timestamp=on diff --git a/tests/qemuxml2argvdata/graphics-spice-auto-socket.x86_64-latest.args b/tests/qemuxml2argvdata/graphics-spice-auto-socket.x86_64-latest.args index a50ca802ae..03fa8e868a 100644 --- a/tests/qemuxml2argvdata/graphics-spice-auto-socket.x86_64-latest.args +++ b/tests/qemuxml2argvdata/graphics-spice-auto-socket.x86_64-latest.args @@ -27,7 +27,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.config \ -boot strict=on \ -device '{"driver":"piix3-usb-uhci","id":"usb","bus":"pci.0","addr":"0x1.0x2"}' \ -audiodev '{"id":"audio1","driver":"spice"}' \ --spice unix,addr=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/spice.sock,seamless-migration=on \ +-spice unix=on,addr=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/spice.sock,seamless-migration=on \ -device '{"driver":"cirrus-vga","id":"video0","bus":"pci.0","addr":"0x2"}' \ -sandbox on,obsolete=deny,elevateprivileges=deny,spawn=deny,resourcecontrol=deny \ -msg timestamp=on diff --git a/tests/qemuxml2argvdata/graphics-spice-socket.x86_64-latest.args b/tests/qemuxml2argvdata/graphics-spice-socket.x86_64-latest.args index 634176a6c3..9c30cf6089 100644 --- a/tests/qemuxml2argvdata/graphics-spice-socket.x86_64-latest.args +++ b/tests/qemuxml2argvdata/graphics-spice-socket.x86_64-latest.args @@ -27,7 +27,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.config \ -boot strict=on \ -device '{"driver":"piix3-usb-uhci","id":"usb","bus":"pci.0","addr":"0x1.0x2"}' \ -audiodev '{"id":"audio1","driver":"spice"}' \ --spice unix,addr=/tmp/spice.sock,seamless-migration=on \ +-spice unix=on,addr=/tmp/spice.sock,seamless-migration=on \ -device '{"driver":"cirrus-vga","id":"video0","bus":"pci.0","addr":"0x2"}' \ -sandbox on,obsolete=deny,elevateprivileges=deny,spawn=deny,resourcecontrol=deny \ -msg timestamp=on diff --git a/tests/qemuxml2argvdata/name-escape.x86_64-latest.args b/tests/qemuxml2argvdata/name-escape.x86_64-latest.args index 096a774caa..9eec8f5a9f 100644 --- a/tests/qemuxml2argvdata/name-escape.x86_64-latest.args +++ b/tests/qemuxml2argvdata/name-escape.x86_64-latest.args @@ -41,7 +41,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-foo=1,bar=2/.config \ -netdev '{"type":"user","guestfwd":[{"str":"tcp:10.0.2.1:4600-chardev:charchannel0"}],"id":"channel0"}' \ -audiodev '{"id":"audio1","driver":"spice"}' \ -vnc vnc=unix:/var/lib/libvirt/qemu/domain--1-foo=1,,bar=2/vnc.sock,audiodev=audio1 \ --spice unix,addr=/var/lib/libvirt/qemu/domain--1-foo=1,,bar=2/spice.sock,gl=on,rendernode=/dev/dri/foo,,bar,seamless-migration=on \ +-spice unix=on,addr=/var/lib/libvirt/qemu/domain--1-foo=1,,bar=2/spice.sock,gl=on,rendernode=/dev/dri/foo,,bar,seamless-migration=on \ -device '{"driver":"cirrus-vga","id":"video0","bus":"pci.0","addr":"0x2"}' \ -blockdev '{"driver":"iscsi","portal":"example.foo.org:3260","target":"iqn.1992-01.com.example:my,storage","lun":1,"transport":"tcp","node-name":"libvirt-2-backend","read-only":false}' \ -device '{"driver":"scsi-generic","drive":"libvirt-2-backend","id":"hostdev0","bus":"scsi0.0","channel":0,"scsi-id":0,"lun":4}' \ -- 2.43.0

3 4

[PATCH 0/4] Support for dirty-limit live migration
by Hyman Huang 21 Dec '23

21 Dec '23

v2: - mark the VIR_MIGRATE_DIRTY_LIMIT flag since 9.10.0 v1: The dirty-limit functionality for live migration was introduced since qemu>=8.1. In the live migration scenario, it implements the force convergence using the dirty-limit approach, which results in better reliable read performance. A straightforward dirty-limit capability for live migration is added by this patchset. Users might not care about other dirty-limit arguments like "x-vcpu-dirty-limit-period" or "vcpu-dirty-limit," thus do not expose them to Libvirt and Keep the default configurations and values in place. For more details about dirty-limit, please see the following reference: https://lore.kernel.org/qemu- devel/169024923116.19090.10825599068950039132-0(a)git.sr.ht/ Hyman Huang (4): Add VIR_MIGRATE_DIRTY_LIMIT flag qemu_migration: Implement VIR_MIGRATE_DIRTY_LIMIT flag virsh: Add support for VIR_MIGRATE_DIRTY_LIMIT flag NEWS: document support for dirty-limit live migration NEWS.rst | 8 ++++++++ docs/manpages/virsh.rst | 10 +++++++++- include/libvirt/libvirt-domain.h | 5 +++++ src/libvirt-domain.c | 8 ++++++++ src/qemu/qemu_migration.c | 8 ++++++++ src/qemu/qemu_migration.h | 1 + src/qemu/qemu_migration_params.c | 6 ++++++ src/qemu/qemu_migration_params.h | 1 + tools/virsh-domain.c | 10 ++++++++++ 9 files changed, 56 insertions(+), 1 deletion(-) -- 2.39.1

2 9

[PATCH v2] conf: fix integer overflow in virDomainControllerDefParseXML
by Egor Makrushin 20 Dec '23

20 Dec '23

Multiplication results in integer overflow. Thus, replace it with ULLONG_MAX and change def->opts.pciopts.pcihole64size type to ULL. Update variable usage according to new type. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Egor Makrushin <emakrushin(a)astralinux.ru> --- v2: update variable type according to maintainer's proposal src/conf/domain_conf.c | 4 ++-- src/conf/domain_conf.h | 2 +- src/qemu/qemu_command.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 58a985fc5d..9f842937e6 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8523,7 +8523,7 @@ virDomainControllerDefParseXML(virDomainXMLOption *xmlopt, unsigned long long bytes; if ((rc = virParseScaledValue("./pcihole64", NULL, ctxt, &bytes, 1024, - 1024ULL * ULONG_MAX, false)) < 0) + ULLONG_MAX, false)) < 0) return NULL; if (rc == 1) @@ -23123,7 +23123,7 @@ virDomainControllerDefFormat(virBuffer *buf, if (def->type == VIR_DOMAIN_CONTROLLER_TYPE_PCI && def->opts.pciopts.pcihole64) { - virBufferAsprintf(&childBuf, "<pcihole64 unit='KiB'>%lu</" + virBufferAsprintf(&childBuf, "<pcihole64 unit='KiB'>%llu</" "pcihole64>\n", def->opts.pciopts.pcihole64size); } diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 0c5e2636e1..14901b37ba 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -707,7 +707,7 @@ struct _virDomainVirtioSerialOpts { struct _virDomainPCIControllerOpts { bool pcihole64; - unsigned long pcihole64size; + unsigned long long pcihole64size; /* the exact controller name is in the "model" subelement, e.g.: * <controller type='pci' model='pcie-root-port'> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 54fb8220e8..b45a5e4f80 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6211,7 +6211,7 @@ qemuBuildGlobalControllerCommandLine(virCommand *cmd, } virCommandAddArg(cmd, "-global"); - virCommandAddArgFormat(cmd, "%s.pci-hole64-size=%luK", hoststr, + virCommandAddArgFormat(cmd, "%s.pci-hole64-size=%lluK", hoststr, cont->opts.pciopts.pcihole64size); } } -- 2.30.2

2 1

[PATCH 0/2] qemuxml2argvtest: Don't exec '/usr/libexec/qemu/vhost-user/test-vhost-user-gpu'
by Peter Krempa 20 Dec '23

20 Dec '23

'qemuExtVhostUserGPUPrepareDomain' breaks our design assumptions about the 'PrepareDomain' step which should not touch anything on the host. This patchset for now fixes the symptom by mocking the function and poisons virFork and virCommandRun so that this doesn't happen in the future. Proper fix will require splitting the vhost-user GPU prepare step to prepare the host-specific portion separately. Peter Krempa (2): qemuxml2argvmock: Mock qemuExtVhostUserGPUPrepareDomain qemuxml2argvmock: Poison virCommandRun and virFork from test context src/qemu/qemu_vhost_user_gpu.c | 4 ++++ src/qemu/qemu_vhost_user_gpu.h | 2 +- src/util/vircommand.h | 4 ++-- tests/qemuxml2argvmock.c | 28 ++++++++++++++++++++++++++++ 4 files changed, 35 insertions(+), 3 deletions(-) -- 2.43.0

2 7

[PATCH] conf: Remove multiplication to avoid overflow
by Egor Makrushin 20 Dec '23

20 Dec '23

Multiplication results in integer overflow. Replace value of 6th agrument with ULLONG_MAX. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 04bd77a19f ("conf: Move and rename virDomainParseScaledValue()") Signed-off-by: Egor Makrushin <emakrushin(a)astralinux.ru> --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 58a985fc5d..871fd3a874 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8523,7 +8523,7 @@ virDomainControllerDefParseXML(virDomainXMLOption *xmlopt, unsigned long long bytes; if ((rc = virParseScaledValue("./pcihole64", NULL, ctxt, &bytes, 1024, - 1024ULL * ULONG_MAX, false)) < 0) + ULLONG_MAX, false)) < 0) return NULL; if (rc == 1) -- 2.30.2

3 3

[libvirt PATCH] remote: DeserializeDomainDiskErrors: remove dead code
by Ján Tomko 19 Dec '23

19 Dec '23

As of commit b2d079c113a which converted this function to use g_strdup, the error label is only reached when i = 0, rendering it useless. Remove it. Fixes: https://gitlab.com/libvirt/libvirt/-/issues/572 Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/remote/remote_driver.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 132d0194c6..392377deae 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -1641,12 +1641,11 @@ remoteDeserializeDomainDiskErrors(remote_domain_disk_error *ret_errors_val, int maxerrors) { size_t i = 0; - size_t j; if (ret_errors_len > limit || ret_errors_len > maxerrors) { virReportError(VIR_ERR_RPC, "%s", _("returned number of disk errors exceeds limit")); - goto error; + return -1; } for (i = 0; i < ret_errors_len; i++) { @@ -1655,12 +1654,6 @@ remoteDeserializeDomainDiskErrors(remote_domain_disk_error *ret_errors_val, } return 0; - - error: - for (j = 0; j < i; j++) - VIR_FREE(errors[j].disk); - - return -1; } static int -- 2.42.0

2 1

[PATCH] apparmor: Add capabilities for PCI passthrough to virtxend profile
by Jim Fehlig 19 Dec '23

19 Dec '23

When splitting out the apparmor modular daemon profiles from the libvirtd profile, the net_admin and sys_admin capabilities were dropped from the virtxend profile. It was not known at the time that these capabilities were needed for PCI passthrough. Without the capabilities, the following messages are emitted from the audit subsystem audit: type=1400 audit(1702939277.946:63): apparmor="DENIED" \ operation="capable" class="cap" profile="virtxend" pid=3611 \ comm="rpc-virtxend" capability=21 capname="sys_admin" audit: type=1400 audit(1702940304.818:63): apparmor="DENIED" \ operation="capable" class="cap" profile="virtxend" pid=3731 \ comm="rpc-virtxend" capability=12 capname="net_admin" It appears sys_admin is needed to simply read from the PCI dev's sysfs config file. The net_admin capability is needed when setting the MAC address of an SR-IOV virtual function. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- src/security/apparmor/usr.sbin.virtxend.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/security/apparmor/usr.sbin.virtxend.in b/src/security/apparmor/usr.sbin.virtxend.in index 78a11305f5..77fedce352 100644 --- a/src/security/apparmor/usr.sbin.virtxend.in +++ b/src/security/apparmor/usr.sbin.virtxend.in @@ -5,8 +5,10 @@ profile virtxend @sbindir@/virtxend flags=(attach_disconnected) { #include <abstractions/dbus> capability kill, + capability net_admin, capability setgid, capability setuid, + capability sys_admin, capability sys_pacct, capability ipc_lock, -- 2.43.0

2 1

Patches on libvirt patchew are outdated
by Han Han 19 Dec '23

19 Dec '23

Hi, The libvirt patchew https://patchew.org/Libvirt/ has no update for more than one month. Is it dropped? If not, please sync the patches to it~

3 6

[vf-token 0/8] Introduce vf-token when using userspace PF
by Vivek Kashyap 18 Dec '23

18 Dec '23

The VFIO PCI ABI has been extended to require userspace PF driver to set a VF token to a known value. The VF drivers are then required to provide this token to access the VF device. The vf-token is set by the PF driver before VF drivers can access the device. The kernel provides no means to retrieve the token in use; but there is no specification describing the distribution or level of confidentiality of the token. Qemu has been extended to require the vf-token when vf device is used. An important point to note is that the vf-token is required only when both the PF and VF are used in userspace. This patch series adds support to provide the vf-token (uuid format) in the domain XML and to generate the qemu commandline including the vf-token. To support vf-token the new element will be used as follows: <hostdev mode='subsystem' type='pci' managed='yes'> <driver name='vfio'/> <source> <address domain='0x0000' bus='0x0' slot='0x00' function='0x1'> <vf-token uuid='00112233-4455-6677-8899-aabbccddeeff'/> </address> </source> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0'/> </hostdev> The generated commandline will include the following: -device {"driver":"vfio-pci","host":"0000:00:0.1", "vf-token":"00112233-4455-6677-8899-aabbccddeeff", "id":"hostdev0","bus":"pci.0","addr":"0x1"} Changes since initial RFC: 1. Added documentation 2. Added test cases and ran successful test suite after each patch commit 3. fixed spaces, coding sytle, and uuid string format 4. Used S:vftoken in virJSONValueObjectAdd instead of a conditional Vivek Kashyap (8): Define the vf-token extension for PCI device Introduce the vf-token qemu capability This patch introduces the PCI address extension flag for vf-token This patch introduces new XML parser/formatter functions for parsing the vf-token Introduce a validation function for vf-token support in qemu and generate vf-token device attribute in qemu command line Provide information about the vf-token flag Add tests for the vf-token flag to the qemuxml2argv and qemuxml2xml test suites Update news about vf-token NEWS.rst | 8 +++ docs/formatdomain.rst | 3 ++ src/conf/device_conf.c | 49 ++++++++++++++++--- src/conf/domain_addr.h | 1 + src/conf/domain_conf.c | 8 +++ src/conf/schemas/basictypes.rng | 7 +++ src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 3 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 8 +++ src/qemu/qemu_domain_address.c | 3 ++ src/qemu/qemu_validate.c | 20 ++++++++ src/util/virpci.c | 7 +++ src/util/virpci.h | 10 ++++ .../qemucapabilitiesdata/caps_8.1.0_s390x.xml | 1 + .../caps_8.1.0_x86_64.xml | 1 + .../caps_8.2.0_x86_64.xml | 1 + .../hostdev-vfio-vf-token.x86_64-latest.args | 34 +++++++++++++ .../hostdev-vfio-vf-token.xml | 22 +++++++++ tests/qemuxml2argvtest.c | 1 + .../hostdev-vfio-vf-token.x86_64-latest.xml | 40 +++++++++++++++ tests/qemuxml2xmltest.c | 1 + 22 files changed, 223 insertions(+), 7 deletions(-) create mode 100644 tests/qemuxml2argvdata/hostdev-vfio-vf-token.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/hostdev-vfio-vf-token.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-vfio-vf-token.x86_64-latest.xml -- 2.33.8

1 8

[PATCH] rpc: fix race in waking up client event loop
by Daniel P. Berrangé 18 Dec '23

18 Dec '23

The first thread to issue a client RPC request will own the event loop execution, sitting in the virNetClientIOEventLoop function. It releases the client lock while running: virNetClientUnlock() g_main_loop_run() virNetClientLock() If a second thread arrives with an RPC request, it will queue it for the first thread to process. To inform the first thread that there's a new request it calls g_main_loop_quit() to break it out of the main loop. This works if the first thread is in g_main_loop_run() at that time. There is a small window of opportunity, however, where the first thread has released the client lock, but not yet got into g_main_loop_run(). If that happens, the wakeup from the second thread is lost. This patch deals with that by changing the way the wakeup is performed. Instead of directly calling g_main_loop_quit(), the second thread creates an idle source to run the quit function from within the first thread. This guarantees that the first thread will see the wakeup. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/rpc/virnetclient.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index 4ab8af68c5..68098b1c8d 100644 --- a/src/rpc/virnetclient.c +++ b/src/rpc/virnetclient.c @@ -1848,6 +1848,15 @@ static void virNetClientIOUpdateCallback(virNetClient *client, } +static gboolean virNetClientIOWakeup(gpointer opaque) +{ + GMainLoop *loop = opaque; + + g_main_loop_quit(loop); + + return G_SOURCE_REMOVE; +} + /* * This function sends a message to remote server and awaits a reply * @@ -1925,7 +1934,9 @@ static int virNetClientIO(virNetClient *client, /* Check to see if another thread is dispatching */ if (client->haveTheBuck) { /* Force other thread to wakeup from poll */ - g_main_loop_quit(client->eventLoop); + GSource *wakeup = g_idle_source_new(); + g_source_set_callback(wakeup, virNetClientIOWakeup, client->eventLoop, NULL); + g_source_attach(wakeup, client->eventCtx); /* If we are non-blocking, detach the thread and keep the call in the * queue. */ -- 2.43.0

4 3

[PATCH 1/3] rpc: mark GSourceFuncs functions in vireventglibwatch.c as static
by Fima Shevrin 18 Dec '23

18 Dec '23

From: "Denis V. Lunev" <den(a)openvz.org> They are not exported from the module and thus should be static. Signed-off-by: Denis V. Lunev <den(a)openvz.org> Signed-off-by: Fima Shevrin <efim.shevrin(a)virtuozzo.com> --- src/util/vireventglibwatch.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/vireventglibwatch.c b/src/util/vireventglibwatch.c index b7f3a8786a..b21e505731 100644 --- a/src/util/vireventglibwatch.c +++ b/src/util/vireventglibwatch.c @@ -71,7 +71,7 @@ virEventGLibFDSourceFinalize(GSource *source G_GNUC_UNUSED) } -GSourceFuncs virEventGLibFDSourceFuncs = { +static GSourceFuncs virEventGLibFDSourceFuncs = { .prepare = virEventGLibFDSourcePrepare, .check = virEventGLibFDSourceCheck, .dispatch = virEventGLibFDSourceDispatch, @@ -194,7 +194,7 @@ virEventGLibSocketSourceFinalize(GSource *source) } -GSourceFuncs virEventGLibSocketSourceFuncs = { +static GSourceFuncs virEventGLibSocketSourceFuncs = { .prepare = virEventGLibSocketSourcePrepare, .check = virEventGLibSocketSourceCheck, .dispatch = virEventGLibSocketSourceDispatch, -- 2.34.1

5 12

[PATCH (pushed)] qemuDomainBlockPeek: Fix format checking logic
by Peter Krempa 16 Dec '23

16 Dec '23

Recent refactor which changed the format check to use qemuBlockStorageSourceIsRaw accidentaly inverted the condition. Caught by the CI test suite. Fixes: b600b69f8291226095e0fdb2eb7503baa79063fc Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- Pushed as trivial CI fix. src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 9d8be15721..2d75357939 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -10173,7 +10173,7 @@ qemuDomainBlockPeek(virDomainPtr dom, goto cleanup; } - if (qemuBlockStorageSourceIsRaw(disk->src)) { + if (!qemuBlockStorageSourceIsRaw(disk->src)) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, _("peeking is only supported for disk with 'raw' format not '%1$s'"), virStorageFileFormatTypeToString(disk->src->format)); -- 2.43.0

1 0

Re: [PATCH 3/3] rpc: Rework rpc notifications in main and side thread
by Daniel P. Berrangé 15 Dec '23

15 Dec '23

On Fri, Dec 15, 2023 at 01:48:09PM +0000, Efim Shevrin wrote: > Hello, > > here are call traces with two threads generated by python script > // ============================== > [root@dandreev-vz-6-0-0-243-master libvirt]# gdb -p 288985 > (gdb) t a a bt > > Thread 2 (Thread 0x7f2112862640 (LWP 288986) "python3"): > #0 0x00007f2121d4296f in poll () at /lib64/libc.so.6 > #1 0x00007f211444650c in g_main_context_iterate.constprop () at /lib64/libglib-2.0.so.0 > #2 0x00007f21143f1483 in g_main_loop_run () at /lib64/libglib-2.0.so.0 > #3 0x00007f211406800b in virNetClientIOEventLoop () at /lib64/libvirt.so.0 > #4 0x00007f2114068a0a in virNetClientIO () at /lib64/libvirt.so.0 > #5 0x00007f21140692c1 in virNetClientSendInternal () at /lib64/libvirt.so.0 > #6 0x00007f211406936d in virNetClientSendWithReply () at /lib64/libvirt.so.0 > #7 0x00007f2114061a1d in virNetClientProgramCall () at /lib64/libvirt.so.0 > #8 0x00007f21140f79ac in callFull () at /lib64/libvirt.so.0 > #9 0x00007f21140f7a2f in call () at /lib64/libvirt.so.0 > #10 0x00007f21140d8435 in remoteDomainCreate () at /lib64/libvirt.so.0 > #11 0x00007f21141dd60c in virDomainCreate () at /lib64/libvirt.so.0 > #12 0x00007f21145c8114 in libvirt_virDomainCreate () at /usr/lib64/python3.9/site-packages/libvirtmod.cpython-39-x86_64-linux-gnu.so Ok, this thread is the primary one responsible for I/O. It is waiting, while not holding any mutex. > Thread 1 (Thread 0x7f21223cf740 (LWP 288985) "python3"): > #0 0x00007f2121c9c39a in __futex_abstimed_wait_common () at /lib64/libc.so.6 > #1 0x00007f2121c9eba0 in pthread_cond_wait@@GLIBC_2.3.2 () at /lib64/libc.so.6 > #2 0x00007f2113f4982a in virCondWait () at /lib64/libvirt.so.0 > #3 0x00007f2113f1fee3 in virObjectWait () at /lib64/libvirt.so.0 > #4 0x00007f211406882a in virNetClientIO () at /lib64/libvirt.so.0 > #5 0x00007f21140692c1 in virNetClientSendInternal () at /lib64/libvirt.so.0 > #6 0x00007f211406936d in virNetClientSendWithReply () at /lib64/libvirt.so.0 > #7 0x00007f2114061a1d in virNetClientProgramCall () at /lib64/libvirt.so.0 > #8 0x00007f21140f79ac in callFull () at /lib64/libvirt.so.0 > #9 0x00007f21140f7a2f in call () at /lib64/libvirt.so.0 > #10 0x00007f21140f24eb in remoteNodeDeviceNumOfCaps () at /lib64/libvirt.so.0 > #11 0x00007f2114207a00 in virNodeDeviceNumOfCaps () at /lib64/libvirt.so.0 This is a second API call that has arrived and has queued its outgoing message, and is waiting either for the other thread to pass ownership of the socket to it, or for the other thread to provide its reply (whichever comes first). This is all totally normal, and working as expected, so I still don't see what the actual problem is ? > // ========================================================================= > > just in case here is python script > > [root@dandreev-vz-6-0-0-243-master ~]# cat a.py > import libvirt > import time > from threading import Thread > > def startVM(connection, vm_name): > try: > # Find the virtual machine by name > print('starting VM') > connection.lookupByName(vm_name).create() > print('done starting VM') > except libvirt.libvirtError as e: > print(f'Libvirt Error: {e}') > > # Replace 'qemu+tcp://10.34.66.13/system' with your actual connection URI > connection_uri = 'qemu+tcp://localhost/system' > connection = libvirt.open(connection_uri) > if connection is None: > print(f'Failed to open connection to {connection_uri}') > exit(1) > > try: > # Replace 'your_vm_name' with the actual name of your virtual machine > # startVM(connection, 'instance-00000002') > thread = Thread(target=lambda: startVM(connection, 'instance-00000002')) > thread.start() > time.sleep(3) > devs = connection.listAllDevices() > for i in range(100000): > for dev in devs: > print('listing caps for dev %i %s' % (i, dev)) > try: > dev.listCaps() > except Exception as e: > print('ERROR: %s' % e) > print('DONE listing caps') > > connection.lookupByName('instance-00000002').destroy() > except: > connection.lookupByName('instance-00000002').destroy() > finally: > thread.join() > # Close the connection outside the function > connection.close() What behaviour are you expecting this demo program to show ? When I run it, the VM starts and the the dev caps listing is then run 3 seconds later (due to the sleep). Removing the sleep, I can see the caps list running in parallel with the 'create'. Basically I see nothing wrong. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|

2 1

Re: [PATCH 3/3] rpc: Rework rpc notifications in main and side thread
by Denis V. Lunev 15 Dec '23

15 Dec '23

On 12/15/23 14:48, Efim Shevrin wrote: > Hello, > > here are call traces with two threads generated by python script > // ============================== > [root@dandreev-vz-6-0-0-243-master libvirt]# gdb -p 288985 > (gdb) t a a bt > > Thread 2 (Thread 0x7f2112862640 (LWP 288986) "python3"): > #0 0x00007f2121d4296f in poll () at /lib64/libc.so.6 > #1 0x00007f211444650c in g_main_context_iterate.constprop () at > /lib64/libglib-2.0.so.0 > #2 0x00007f21143f1483 in g_main_loop_run () at /lib64/libglib-2.0.so.0 > #3 0x00007f211406800b in virNetClientIOEventLoop () at > /lib64/libvirt.so.0 > #4 0x00007f2114068a0a in virNetClientIO () at /lib64/libvirt.so.0 > #5 0x00007f21140692c1 in virNetClientSendInternal () at > /lib64/libvirt.so.0 > #6 0x00007f211406936d in virNetClientSendWithReply () at > /lib64/libvirt.so.0 > #7 0x00007f2114061a1d in virNetClientProgramCall () at > /lib64/libvirt.so.0 > #8 0x00007f21140f79ac in callFull () at /lib64/libvirt.so.0 > #9 0x00007f21140f7a2f in call () at /lib64/libvirt.so.0 > #10 0x00007f21140d8435 in remoteDomainCreate () at /lib64/libvirt.so.0 > #11 0x00007f21141dd60c in virDomainCreate () at /lib64/libvirt.so.0 > #12 0x00007f21145c8114 in libvirt_virDomainCreate () at > /usr/lib64/python3.9/site-packages/libvirtmod.cpython-39-x86_64-linux-gnu.so > #13 0x00007f21221268a8 in cfunction_call () at /lib64/libpython3.9.so.1.0 > #14 0x00007f2122118814 in _PyObject_MakeTpCall () at > /lib64/libpython3.9.so.1.0 > #15 0x00007f212211566e in _PyEval_EvalFrameDefault () at > /lib64/libpython3.9.so.1.0 > #16 0x00007f212211d013 in function_code_fastcall () at > /lib64/libpython3.9.so.1.0 > #17 0x00007f2122110650 in _PyEval_EvalFrameDefault () at > /lib64/libpython3.9.so.1.0 > #18 0x00007f212211d013 in function_code_fastcall () at > /lib64/libpython3.9.so.1.0 > #19 0x00007f21221103e8 in _PyEval_EvalFrameDefault () at > /lib64/libpython3.9.so.1.0 > #20 0x00007f212211d013 in function_code_fastcall () at > /lib64/libpython3.9.so.1.0 > #21 0x00007f21221133d2 in _PyEval_EvalFrameDefault () at > /lib64/libpython3.9.so.1.0 > #22 0x00007f212211d013 in function_code_fastcall () at > /lib64/libpython3.9.so.1.0 > #23 0x00007f2122110650 in _PyEval_EvalFrameDefault () at > /lib64/libpython3.9.so.1.0 > #24 0x00007f212211d013 in function_code_fastcall () at > /lib64/libpython3.9.so.1.0 > #25 0x00007f2122110650 in _PyEval_EvalFrameDefault () at > /lib64/libpython3.9.so.1.0 > #26 0x00007f212211d013 in function_code_fastcall () at > /lib64/libpython3.9.so.1.0 > #27 0x00007f2122125382 in method_vectorcall () at > /lib64/libpython3.9.so.1.0 > #28 0x00007f21221d8c4a in t_bootstrap () at /lib64/libpython3.9.so.1.0 > #29 0x00007f21221d8bf8 in pythread_wrapper () at > /lib64/libpython3.9.so.1.0 > #30 0x00007f2121c9f802 in start_thread () at /lib64/libc.so.6 > #31 0x00007f2121c3f450 in clone3 () at /lib64/libc.so.6 > > Thread 1 (Thread 0x7f21223cf740 (LWP 288985) "python3"): > #0 0x00007f2121c9c39a in __futex_abstimed_wait_common () at > /lib64/libc.so.6 > #1 0x00007f2121c9eba0 in pthread_cond_wait@@GLIBC_2.3.2 () at > /lib64/libc.so.6 > #2 0x00007f2113f4982a in virCondWait () at /lib64/libvirt.so.0 > #3 0x00007f2113f1fee3 in virObjectWait () at /lib64/libvirt.so.0 > #4 0x00007f211406882a in virNetClientIO () at /lib64/libvirt.so.0 > #5 0x00007f21140692c1 in virNetClientSendInternal () at > /lib64/libvirt.so.0 > #6 0x00007f211406936d in virNetClientSendWithReply () at > /lib64/libvirt.so.0 > #7 0x00007f2114061a1d in virNetClientProgramCall () at > /lib64/libvirt.so.0 > #8 0x00007f21140f79ac in callFull () at /lib64/libvirt.so.0 > #9 0x00007f21140f7a2f in call () at /lib64/libvirt.so.0 > #10 0x00007f21140f24eb in remoteNodeDeviceNumOfCaps () at > /lib64/libvirt.so.0 > #11 0x00007f2114207a00 in virNodeDeviceNumOfCaps () at /lib64/libvirt.so.0 > #12 0x00007f21145d8edf in libvirt_virNodeDeviceListCaps.lto_priv.0 () > at > /usr/lib64/python3.9/site-packages/libvirtmod.cpython-39-x86_64-linux-gnu.so > #13 0x00007f21221268a8 in cfunction_call () at /lib64/libpython3.9.so.1.0 > #14 0x00007f2122118814 in _PyObject_MakeTpCall () at > /lib64/libpython3.9.so.1.0 > #15 0x00007f212211566e in _PyEval_EvalFrameDefault () at > /lib64/libpython3.9.so.1.0 > #16 0x00007f212211d013 in function_code_fastcall () at > /lib64/libpython3.9.so.1.0 > #17 0x00007f2122110650 in _PyEval_EvalFrameDefault () at > /lib64/libpython3.9.so.1.0 > #18 0x00007f212210f06d in _PyEval_EvalCode () at > /lib64/libpython3.9.so.1.0 > #19 0x00007f212218c495 in _PyEval_EvalCodeWithName () at > /lib64/libpython3.9.so.1.0 > --Type <RET> for more, q to quit, c to continue without paging-- > #20 0x00007f212218c42d in PyEval_EvalCodeEx () at > /lib64/libpython3.9.so.1.0 > #21 0x00007f212218c3df in PyEval_EvalCode () at /lib64/libpython3.9.so.1.0 > #22 0x00007f21221b7524 in run_eval_code_obj () at > /lib64/libpython3.9.so.1.0 > #23 0x00007f21221b5da6 in run_mod () at /lib64/libpython3.9.so.1.0 > #24 0x00007f212208f0cb in pyrun_file.cold () at /lib64/libpython3.9.so.1.0 > #25 0x00007f21221bb253 in PyRun_SimpleFileExFlags () at > /lib64/libpython3.9.so.1.0 > #26 0x00007f21221b7ee8 in Py_RunMain () at /lib64/libpython3.9.so.1.0 > #27 0x00007f212217f02d in Py_BytesMain () at /lib64/libpython3.9.so.1.0 > #28 0x00007f2121c3feb0 in __libc_start_call_main () at /lib64/libc.so.6 > #29 0x00007f2121c3ff60 in __libc_start_main_impl () at /lib64/libc.so.6 > #30 0x000056013181a095 in _start () > > // > ========================================================================= > > just in case here is python script > > [root@dandreev-vz-6-0-0-243-master ~]# cat a.py > import libvirt > import time > from threading import Thread > > def startVM(connection, vm_name): > try: > # Find the virtual machine by name > print('starting VM') > connection.lookupByName(vm_name).create() > print('done starting VM') > except libvirt.libvirtError as e: > print(f'Libvirt Error: {e}') > > # Replace 'qemu+tcp://10.34.66.13/system' with your actual connection URI > connection_uri = 'qemu+tcp://localhost/system' > connection = libvirt.open(connection_uri) > if connection is None: > print(f'Failed to open connection to {connection_uri}') > exit(1) > > try: > # Replace 'your_vm_name' with the actual name of your virtual machine > # startVM(connection, 'instance-00000002') > thread = Thread(target=lambda: startVM(connection, 'instance-00000002')) > thread.start() > time.sleep(3) > devs = connection.listAllDevices() > for i in range(100000): > for dev in devs: > print('listing caps for dev %i %s' % (i, dev)) > try: > dev.listCaps() > except Exception as e: > print('ERROR: %s' % e) > print('DONE listing caps') > > connection.lookupByName('instance-00000002').destroy() > except: > connection.lookupByName('instance-00000002').destroy() > finally: > thread.join() > # Close the connection outside the function > connection.close() > > // ================================================================= > > We use virtual machine startup as a loaded operation, but migration or > something similar could be used. > > Fima Shevrin > ------------------------------------------------------------------------ > *From:* Daniel P. Berrangé <berrange(a)redhat.com> > *Sent:* Friday, December 15, 2023 19:09 > *To:* Efim Shevrin <efim.shevrin(a)virtuozzo.com> > *Cc:* devel(a)lists.libvirt.org <devel(a)lists.libvirt.org>; > den(a)openvz.org <den(a)openvz.org> > *Subject:* Re: [PATCH 3/3] rpc: Rework rpc notifications in main and > side thread > [You don't often get email from berrange(a)redhat.com. Learn why this is > important at https://aka.ms/LearnAboutSenderIdentification ] > > On Fri, Dec 15, 2023 at 02:32:19AM +0800, Fima Shevrin wrote: > > RPC client implementation uses the following paradigm. The critical > > section is organized via virObjectLock(client)/virObjectUnlock(client) > > braces. Though this is potentially problematic as > > main thread: side thread: > > virObjectUnlock(client); > > virObjectLock(client); > > g_main_loop_quit(client->eventLoop); > > virObjectUnlock(client); > > g_main_loop_run(client->eventLoop); > > > > This means in particular that is the main thread is executing very long > > request like VM migration, the wakeup from the side thread could be > > stuck until the main request will be fully completed. > > Can you explain this in more detail, with call traces illustration > for the two threads. You're not saying where the main thread is > doing work with the 'client' lock hold for a long time. Generally > the goal should be for the main thread to only hold the lock for > a short time. Also if the side thread is already holding a reference > on 'client', then potentially we should consider if it is possible > to terminate the event loop without acquiring the mutex, as GMainLoop > protects itself wrt concurrent usage already, provided all threads > hold a reference directly or indirectly. At our opinion the problem here is missed wakeup from the side thread to the main thread. In the original code, i.e. before switching to the main_loop, the problem was not occurred as wakeup event was kept inside the pipe and the poll has been immediately woken up. I have written the same code with pipes but that code is a bit cumbersome due to the Windows compatibility. Thus this application with Prepare seems cleaner. Den

2 2

[PATCH 0/4] virsh/virt-admin: Don't use virErrorRestore
by Peter Krempa 15 Dec '23

15 Dec '23

Client application shouldn't need to reset the error. Peter Krempa (4): virshReconnect: Preserve current URI if not explicitly set in ctl->connname virshCatchDisconnect: Don't probe connection URI vshAdmConnect: Preserve connection URI in ctl->connname if auto-detected vshAdmCatchDisconnect: Don't probe connection URI tools/virsh.c | 13 +++++-------- tools/virt-admin.c | 11 ++++------- 2 files changed, 9 insertions(+), 15 deletions(-) -- 2.43.0

2 4

[PATCH 4/4] vshAdmCatchDisconnect: Don't probe connection URI
by Peter Krempa 15 Dec '23

15 Dec '23

virsh already stores the connection URI in 'ctl->connname', use that instead. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- tools/virt-admin.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/tools/virt-admin.c b/tools/virt-admin.c index 02cf421cee..fa9304c772 100644 --- a/tools/virt-admin.c +++ b/tools/virt-admin.c @@ -72,15 +72,10 @@ vshAdmCatchDisconnect(virAdmConnectPtr conn G_GNUC_UNUSED, { vshControl *ctl = opaque; const char *str = "unknown reason"; - virErrorPtr error; - g_autofree char *uri = NULL; if (reason == VIR_CONNECT_CLOSE_REASON_CLIENT) return; - virErrorPreserveLast(&error); - uri = virAdmConnectGetURI(conn); - switch ((virConnectCloseReason) reason) { case VIR_CONNECT_CLOSE_REASON_ERROR: str = N_("Disconnected from %1$s due to I/O error"); @@ -96,8 +91,7 @@ vshAdmCatchDisconnect(virAdmConnectPtr conn G_GNUC_UNUSED, break; } - vshError(ctl, _(str), NULLSTR(uri)); - virErrorRestore(&error); + vshError(ctl, _(str), NULLSTR(ctl->connname)); } static int -- 2.43.0

1 0

[PATCH] CIM: Include <stdlib.h> in libxkutil for malloc functions
by Florian Weimer 15 Dec '23

15 Dec '23

This avoids implicit function declarations and build failures with future compilers. Not sure where to submit this. Our Fedora package references <http://libvirt.org/CIM/>, but it's 404, and I can't find a CIM component in the Gitlab organization. Thanks, Florian diff --git a/libxkutil/infostore.c b/libxkutil/infostore.c index d2b2f719dc1d3616..060a83b26e170df7 100644 --- a/libxkutil/infostore.c +++ b/libxkutil/infostore.c @@ -26,6 +26,7 @@ #include <sys/stat.h> #include <sys/file.h> #include <string.h> +#include <stdlib.h> #include <libvirt/libvirt.h> #include <libxml/parser.h> diff --git a/libxkutil/xml_parse_test.c b/libxkutil/xml_parse_test.c index 384593d056d07fb2..9af570efc75f7681 100644 --- a/libxkutil/xml_parse_test.c +++ b/libxkutil/xml_parse_test.c @@ -1,5 +1,6 @@ #include <stdio.h> #include <inttypes.h> +#include <stdlib.h> #include <getopt.h>

3 3

Public virErrorPreserveLast()/virErrorRestore()
by John Levon 15 Dec '23

15 Dec '23

These two functions are currently private to libvirt, hence not available to consumers. Would it be possible to make them public? Without them, there's no way to do any libvirt call without stomping on an existing error that you may want to preserve. I have multiple threads sharing a remote connection (to local libvirtd). I need to be able to handle connection drops (e.g. libvirtd restart). Long story short, the only approach I've found that actually works properly is that there's one main conn object, each thread has a virConnectRef() to it, and whenever a thread gets an error, we check in the error callback if !virConnectIsAlive(). If so, we close the thread's conn, and potentially also clean up the main conn. Then when the error gets returned from the relevant library call, we try to re-connect. However, virConnectIsAlive() stomps on the thread's error, meaning we lose the context on a real, non-connection-related error. So I need to be able to save and restore in the error handler. Given how much these are used inside libvirt code already, it feels likely it would be useful in other public cases too. Thoughts? thnaks john

4 13

[PATCH v2 0/3] Rework main and side threads interaction in rpc
by Fima Shevrin 15 Dec '23

15 Dec '23

From: "Fima Shevrin" <efim.shevrin(a)virtuozzo.com> RPC client implementation uses the following paradigm. The critical section is organized via virObjectLock(client)/virObjectUnlock(client) braces. Though this is potentially problematic as main thread: side thread: virObjectUnlock(client); virObjectLock(client); g_main_loop_quit(client->eventLoop); virObjectUnlock(client); g_main_loop_run(client->eventLoop); This means in particular that is the main thread is executing very long request like VM migration, the wakeup from the side thread could be stuck until the main request will be fully completed. Discrubed case is easily reproducible with the simple python scripts doing slow and fast requests in parallel from two different threads. Our idea is to release the lock at the prepare stage and avoid libvirt stuck during the interaction between main and side threads. Changes: Add cover letter and versions From 2d1a5f094101808216970dbf90383ffeadae7fe9 Mon Sep 17 00:00:00 2001 From: "Denis V. Lunev" <den(a)openvz.org> Date: Sat, 25 Nov 2023 14:11:56 +0300 Subject: [PATCH v2 1/3] rpc: mark GSourceFuncs functions in vireventglibwatch.c as static They are not exported from the module and thus should be static. Signed-off-by: Denis V. Lunev <den(a)openvz.org> Signed-off-by: Fima Shevrin <efim.shevrin(a)virtuozzo.com> --- src/util/vireventglibwatch.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/vireventglibwatch.c b/src/util/vireventglibwatch.c index b7f3a8786a..b21e505731 100644 --- a/src/util/vireventglibwatch.c +++ b/src/util/vireventglibwatch.c @@ -71,7 +71,7 @@ virEventGLibFDSourceFinalize(GSource *source G_GNUC_UNUSED) } -GSourceFuncs virEventGLibFDSourceFuncs = { +static GSourceFuncs virEventGLibFDSourceFuncs = { .prepare = virEventGLibFDSourcePrepare, .check = virEventGLibFDSourceCheck, .dispatch = virEventGLibFDSourceDispatch, @@ -194,7 +194,7 @@ virEventGLibSocketSourceFinalize(GSource *source) } -GSourceFuncs virEventGLibSocketSourceFuncs = { +static GSourceFuncs virEventGLibSocketSourceFuncs = { .prepare = virEventGLibSocketSourcePrepare, .check = virEventGLibSocketSourceCheck, .dispatch = virEventGLibSocketSourceDispatch, -- 2.34.1

1 2

[PATCH 0/2] qemu: Drop support for virtiofsd written in C and modernize cmd line
by Michal Privoznik 15 Dec '23

15 Dec '23

*** BLURB HERE *** Michal Prívozník (2): qemu: Drop support for C implementation of virtiofsd qemu_virtiofs: Don't use deprecated cmd line src/qemu/qemu_validate.c | 6 ++++ src/qemu/qemu_virtiofs.c | 33 +++++++------------ .../vhost-user-fs-fd-memory.xml | 1 - 3 files changed, 17 insertions(+), 23 deletions(-) -- 2.41.0

5 6

[libvirt PATCHv2 0/9] support running virtiofsd in session mode
by Ján Tomko 14 Dec '23

14 Dec '23

Now with automatic id mapping selection. Ján Tomko (9): conf: move idmap definition earlier conf: move idmap parsing earlier conf: add idmap element to filesystem qemu: format uid/gid map for virtiofs qemu: virtiofs: do not force UID 0 qemu: allow running virtiofsd in session mode util: add virGetSubUIDs qemu: virtiofs: auto-fill idmap for unprivileged use docs: virtiofs: add section about ID remapping docs/formatdomain.rst | 8 + docs/kbase/virtiofs.rst | 19 +++ src/conf/domain_conf.c | 152 ++++++++++++------ src/conf/domain_conf.h | 29 ++-- src/conf/schemas/domaincommon.rng | 3 + src/libvirt_private.syms | 2 + src/qemu/qemu_validate.c | 7 +- src/qemu/qemu_virtiofs.c | 95 ++++++++++- src/util/virutil.c | 70 ++++++++ src/util/virutil.h | 12 ++ .../vhost-user-fs-fd-memory.xml | 4 + tests/utiltest.c | 33 ++++ tests/virutiltestdata/subuid | 4 + 13 files changed, 362 insertions(+), 76 deletions(-) create mode 100644 tests/virutiltestdata/subuid -- 2.42.0

2 14

[PATCH] Unreacheble code cleanup
by Dmitry Frolov 13 Dec '23

13 Dec '23

Removed code is unreacheble, since the following functions always return 0: virCPUx86DataAdd() libxlCapsAddCPUID() virCapabilitiesAddHostFeature() libxl_get_physinfo() virCapabilitiesSetNetPrefix() libxlMakeDomainOSCaps() libxlMakeDomainDeviceDiskCaps() libxlMakeDomainDeviceGraphicsCaps() libxlMakeDomainDeviceVideoCaps() Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Dmitry Frolov <frolov(a)swemel.ru> --- src/libxl/libxl_capabilities.c | 34 ++++++++++++---------------------- 1 file changed, 12 insertions(+), 22 deletions(-) diff --git a/src/libxl/libxl_capabilities.c b/src/libxl/libxl_capabilities.c index 177e8b988e..68908874fb 100644 --- a/src/libxl/libxl_capabilities.c +++ b/src/libxl/libxl_capabilities.c @@ -64,12 +64,7 @@ libxlCapsAddCPUID(virCPUData *data, virCPUx86CPUID *cpuid, ssize_t ncaps) item.type = VIR_CPU_X86_DATA_CPUID; for (i = 0; i < ncaps; i++) { item.data.cpuid = cpuid[i]; - - if (virCPUx86DataAdd(data, &item) < 0) { - VIR_DEBUG("Failed to add CPUID(%x,%x)", - cpuid[i].eax_in, cpuid[i].ecx_in); - return -1; - } + virCPUx86DataAdd(data, &item) < 0); } return 0; @@ -119,8 +114,7 @@ libxlCapsNodeData(virCPUDef *cpu, libxl_hwcap hwcap) return NULL; ncaps = G_N_ELEMENTS(cpuid); - if (libxlCapsAddCPUID(cpudata, cpuid, ncaps) < 0) - return NULL; + libxlCapsAddCPUID(cpudata, cpuid, ncaps); return g_steal_pointer(&cpudata); } @@ -145,9 +139,10 @@ libxlCapsInitCPU(virCaps *caps, libxl_physinfo *phy_info) cpu = virCPUDefNew(); host_pae = phy_info->hw_cap[0] & LIBXL_X86_FEATURE_PAE_MASK; - if (host_pae && - virCapabilitiesAddHostFeature(caps, "pae") < 0) + if (host_pae) { + virCapabilitiesAddHostFeature(caps, "pae"); return -1; + } host_lm = (phy_info->hw_cap[2] & LIBXL_X86_FEATURE_LM_MASK); if (host_lm) @@ -179,17 +174,12 @@ libxlCapsInitHost(libxl_ctx *ctx, virCaps *caps) int ret = -1; libxl_physinfo_init(&phy_info); - if (libxl_get_physinfo(ctx, &phy_info) != 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Failed to get node physical info from libxenlight")); - goto cleanup; - } + libxl_get_physinfo(ctx, &phy_info); if (libxlCapsInitCPU(caps, &phy_info) < 0) goto cleanup; - if (virCapabilitiesSetNetPrefix(caps, LIBXL_GENERATED_PREFIX_XEN) < 0) - goto cleanup; + virCapabilitiesSetNetPrefix(caps, LIBXL_GENERATED_PREFIX_XEN); ret = 0; @@ -685,11 +675,11 @@ libxlMakeDomainCapabilities(virDomainCaps *domCaps, else domCaps->maxvcpus = PV_MAX_VCPUS; - if (libxlMakeDomainOSCaps(domCaps->machine, os, firmwares, nfirmwares) < 0 || - libxlMakeDomainDeviceDiskCaps(disk) < 0 || - libxlMakeDomainDeviceGraphicsCaps(graphics) < 0 || - libxlMakeDomainDeviceVideoCaps(video) < 0) - return -1; + libxlMakeDomainOSCaps(domCaps->machine, os, firmwares, nfirmwares); + libxlMakeDomainDeviceDiskCaps(disk); + libxlMakeDomainDeviceGraphicsCaps(graphics); + libxlMakeDomainDeviceVideoCaps(video); + if (STRNEQ(domCaps->machine, "xenpvh") && libxlMakeDomainDeviceHostdevCaps(hostdev) < 0) return -1; -- 2.34.1

2 1

[PATCH v2 0/4] Support for dirty-limit live migration
by Hyman Huang 09 Dec '23

09 Dec '23

v2: - mark the VIR_MIGRATE_DIRTY_LIMIT flag since 10.0.0 v1: The dirty-limit functionality for live migration was introduced since qemu>=8.1. In the live migration scenario, it implements the force convergence using the dirty-limit approach, which results in better reliable read performance. A straightforward dirty-limit capability for live migration is added by this patchset. Users might not care about other dirty-limit arguments like "x-vcpu-dirty-limit-period" or "vcpu-dirty-limit," thus do not expose them to Libvirt and Keep the default configurations and values in place. For more details about dirty-limit, please see the following reference: https://lore.kernel.org/qemu- devel/169024923116.19090.10825599068950039132-0(a)git.sr.ht/ Hyman Huang (4): Add VIR_MIGRATE_DIRTY_LIMIT flag qemu_migration: Implement VIR_MIGRATE_DIRTY_LIMIT flag virsh: Add support for VIR_MIGRATE_DIRTY_LIMIT flag NEWS: document support for dirty-limit live migration NEWS.rst | 8 ++++++++ docs/manpages/virsh.rst | 10 +++++++++- include/libvirt/libvirt-domain.h | 5 +++++ src/libvirt-domain.c | 8 ++++++++ src/qemu/qemu_migration.c | 8 ++++++++ src/qemu/qemu_migration.h | 1 + src/qemu/qemu_migration_params.c | 6 ++++++ src/qemu/qemu_migration_params.h | 1 + tools/virsh-domain.c | 10 ++++++++++ 9 files changed, 56 insertions(+), 1 deletion(-) -- 2.39.1

1 4

[PATCH v2 0/9] RFC: Add versioned CPUs to libvirt
by Jonathon Jongsma 08 Dec '23

08 Dec '23

For SEV-SNP support we will need to be able to specify versioned CPU models that are not yet available in libvirt. Rather than just adding a versioned CPU or two that would satisfy that immediate need, I decided to try to add versioned CPUs in a more standard way. This series generates CPU definitions for all cpu versions that are defined in upstream qemu (at least for recent Intel and AMD CPUs). libvirt already provides a select subset of these versions as configurable CPU models. But we only include the ones that have defined aliases in qemu, such as EPYC-IBPB. After this patchset, all verisioned cpu models supported by qemu will be available in libvirt. Note that I'm only adding versions that are not already available via their alias. For example, I am not adding an EPYC-v2 CPU model since it is already available as EPYC-IBPB. Changes in v2: - don't make any changes to existing CPU models - drop concept of aliases from libvirt and only provide new versioned models that aren't already available via their qemu alias. Jonathon Jongsma (9): cpu_map: update script to generate versioned CPUs cpu_map: Add versioned EPYC CPUs cpu_map: Add versioned Intel Skylake CPUs cpu_map: Add versioned Intel Cascadelake CPUs cpu_map: Add versioned Intel Icelake CPUs cpu_map: Add versioned Intel Cooperlake CPUs cpu_map: Add versioned Intel Snowridge CPUs cpu_map: Add versioned Intel SapphireRapids CPUs cpu_map: Add versioned Dhyana CPUs src/cpu_map/index.xml | 22 +++ src/cpu_map/meson.build | 22 +++ src/cpu_map/sync_qemu_models_i386.py | 44 ++++-- src/cpu_map/x86_Cascadelake-Server-v2.xml | 93 +++++++++++++ src/cpu_map/x86_Cascadelake-Server-v4.xml | 91 +++++++++++++ src/cpu_map/x86_Cascadelake-Server-v5.xml | 92 +++++++++++++ src/cpu_map/x86_Cooperlake-v2.xml | 98 ++++++++++++++ src/cpu_map/x86_Dhyana-v2.xml | 81 ++++++++++++ src/cpu_map/x86_EPYC-Milan-v2.xml | 108 +++++++++++++++ src/cpu_map/x86_EPYC-Rome-v2.xml | 93 +++++++++++++ src/cpu_map/x86_EPYC-Rome-v3.xml | 95 +++++++++++++ src/cpu_map/x86_EPYC-Rome-v4.xml | 94 +++++++++++++ src/cpu_map/x86_EPYC-v3.xml | 87 ++++++++++++ src/cpu_map/x86_EPYC-v4.xml | 88 ++++++++++++ src/cpu_map/x86_Icelake-Server-v3.xml | 103 +++++++++++++++ src/cpu_map/x86_Icelake-Server-v4.xml | 108 +++++++++++++++ src/cpu_map/x86_Icelake-Server-v5.xml | 109 +++++++++++++++ src/cpu_map/x86_Icelake-Server-v6.xml | 109 +++++++++++++++ src/cpu_map/x86_SapphireRapids-v2.xml | 125 ++++++++++++++++++ src/cpu_map/x86_Skylake-Client-v4.xml | 77 +++++++++++ src/cpu_map/x86_Skylake-Server-v4.xml | 83 ++++++++++++ src/cpu_map/x86_Skylake-Server-v5.xml | 85 ++++++++++++ src/cpu_map/x86_Snowridge-v2.xml | 78 +++++++++++ src/cpu_map/x86_Snowridge-v3.xml | 80 +++++++++++ src/cpu_map/x86_Snowridge-v4.xml | 78 +++++++++++ .../x86_64-cpuid-Atom-P5362-guest.xml | 3 +- .../x86_64-cpuid-Atom-P5362-json.xml | 3 +- .../x86_64-cpuid-Cooperlake-host.xml | 3 +- .../x86_64-cpuid-EPYC-7502-32-Core-host.xml | 5 +- .../x86_64-cpuid-EPYC-7601-32-Core-guest.xml | 9 +- ...6_64-cpuid-EPYC-7601-32-Core-ibpb-host.xml | 8 +- ..._64-cpuid-Hygon-C86-7185-32-core-guest.xml | 5 +- ...6_64-cpuid-Hygon-C86-7185-32-core-host.xml | 5 +- ...6_64-cpuid-Hygon-C86-7185-32-core-json.xml | 6 +- ...4-cpuid-Ryzen-7-1800X-Eight-Core-guest.xml | 9 +- .../x86_64-cpuid-Xeon-Platinum-8268-guest.xml | 9 +- .../x86_64-cpuid-Xeon-Platinum-8268-host.xml | 9 +- .../x86_64-cpuid-Xeon-Platinum-9242-guest.xml | 9 +- .../x86_64-cpuid-Xeon-Platinum-9242-host.xml | 9 +- .../x86_64-cpuid-Xeon-Platinum-9242-json.xml | 9 +- ..._64-cpuid-baseline-Cascadelake+Icelake.xml | 9 +- ...-cpuid-baseline-Cooperlake+Cascadelake.xml | 9 +- ...6_64-cpuid-baseline-Cooperlake+Icelake.xml | 9 +- .../domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 2 + .../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 2 + tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 2 + .../domaincapsdata/qemu_5.0.0-q35.x86_64.xml | 4 + .../domaincapsdata/qemu_5.0.0-tcg.x86_64.xml | 4 + tests/domaincapsdata/qemu_5.0.0.x86_64.xml | 4 + .../domaincapsdata/qemu_5.1.0-q35.x86_64.xml | 7 + .../domaincapsdata/qemu_5.1.0-tcg.x86_64.xml | 7 + tests/domaincapsdata/qemu_5.1.0.x86_64.xml | 7 + .../domaincapsdata/qemu_5.2.0-q35.x86_64.xml | 7 + .../domaincapsdata/qemu_5.2.0-tcg.x86_64.xml | 7 + tests/domaincapsdata/qemu_5.2.0.x86_64.xml | 7 + .../domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 8 ++ .../domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 8 ++ tests/domaincapsdata/qemu_6.0.0.x86_64.xml | 8 ++ .../domaincapsdata/qemu_6.1.0-q35.x86_64.xml | 15 +++ .../domaincapsdata/qemu_6.1.0-tcg.x86_64.xml | 15 +++ tests/domaincapsdata/qemu_6.1.0.x86_64.xml | 15 +++ .../domaincapsdata/qemu_6.2.0-q35.x86_64.xml | 16 +++ .../domaincapsdata/qemu_6.2.0-tcg.x86_64.xml | 16 +++ tests/domaincapsdata/qemu_6.2.0.x86_64.xml | 16 +++ .../domaincapsdata/qemu_7.0.0-q35.x86_64.xml | 17 +++ .../domaincapsdata/qemu_7.0.0-tcg.x86_64.xml | 17 +++ tests/domaincapsdata/qemu_7.0.0.x86_64.xml | 17 +++ .../domaincapsdata/qemu_7.1.0-q35.x86_64.xml | 17 +++ .../domaincapsdata/qemu_7.1.0-tcg.x86_64.xml | 17 +++ tests/domaincapsdata/qemu_7.1.0.x86_64.xml | 17 +++ .../domaincapsdata/qemu_7.2.0-q35.x86_64.xml | 17 +++ .../qemu_7.2.0-tcg.x86_64+hvf.xml | 17 +++ .../domaincapsdata/qemu_7.2.0-tcg.x86_64.xml | 17 +++ tests/domaincapsdata/qemu_7.2.0.x86_64.xml | 17 +++ .../domaincapsdata/qemu_8.0.0-q35.x86_64.xml | 17 +++ .../domaincapsdata/qemu_8.0.0-tcg.x86_64.xml | 17 +++ tests/domaincapsdata/qemu_8.0.0.x86_64.xml | 17 +++ .../domaincapsdata/qemu_8.1.0-q35.x86_64.xml | 27 +++- .../domaincapsdata/qemu_8.1.0-tcg.x86_64.xml | 22 +++ tests/domaincapsdata/qemu_8.1.0.x86_64.xml | 27 +++- .../domaincapsdata/qemu_8.2.0-q35.x86_64.xml | 27 +++- .../domaincapsdata/qemu_8.2.0-tcg.x86_64.xml | 22 +++ tests/domaincapsdata/qemu_8.2.0.x86_64.xml | 27 +++- ...-host-model-fallback-kvm.x86_64-8.1.0.args | 2 +- ...host-model-fallback-kvm.x86_64-latest.args | 2 +- .../cpu-host-model-kvm.x86_64-8.1.0.args | 2 +- .../cpu-host-model-kvm.x86_64-latest.args | 2 +- ...ost-model-nofallback-kvm.x86_64-8.1.0.args | 2 +- ...st-model-nofallback-kvm.x86_64-latest.args | 2 +- 89 files changed, 2710 insertions(+), 123 deletions(-) create mode 100644 src/cpu_map/x86_Cascadelake-Server-v2.xml create mode 100644 src/cpu_map/x86_Cascadelake-Server-v4.xml create mode 100644 src/cpu_map/x86_Cascadelake-Server-v5.xml create mode 100644 src/cpu_map/x86_Cooperlake-v2.xml create mode 100644 src/cpu_map/x86_Dhyana-v2.xml create mode 100644 src/cpu_map/x86_EPYC-Milan-v2.xml create mode 100644 src/cpu_map/x86_EPYC-Rome-v2.xml create mode 100644 src/cpu_map/x86_EPYC-Rome-v3.xml create mode 100644 src/cpu_map/x86_EPYC-Rome-v4.xml create mode 100644 src/cpu_map/x86_EPYC-v3.xml create mode 100644 src/cpu_map/x86_EPYC-v4.xml create mode 100644 src/cpu_map/x86_Icelake-Server-v3.xml create mode 100644 src/cpu_map/x86_Icelake-Server-v4.xml create mode 100644 src/cpu_map/x86_Icelake-Server-v5.xml create mode 100644 src/cpu_map/x86_Icelake-Server-v6.xml create mode 100644 src/cpu_map/x86_SapphireRapids-v2.xml create mode 100644 src/cpu_map/x86_Skylake-Client-v4.xml create mode 100644 src/cpu_map/x86_Skylake-Server-v4.xml create mode 100644 src/cpu_map/x86_Skylake-Server-v5.xml create mode 100644 src/cpu_map/x86_Snowridge-v2.xml create mode 100644 src/cpu_map/x86_Snowridge-v3.xml create mode 100644 src/cpu_map/x86_Snowridge-v4.xml -- 2.41.0

2 11

[PATCH] remote: Fix cached hypervisor type
by Jim Fehlig 08 Dec '23

08 Dec '23

Commit 501825011c switched the remote driver to using g_auto, but missed one case of needing to steal a pointer holding the hypervisor type. Without it, memory is freed and the output of 'virsh version' has random output Compiled against library: libvirt 10.0.0 Using library: libvirt 10.0.0 Using API: ��%�U 10.0.0 Running hypervisor: ��U 8.1.3 Ths change also fixes random SIGABRT from perl processes running libvirt-tck tests. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- src/remote/remote_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index c4831db6cd..132d0194c6 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -1408,7 +1408,7 @@ remoteConnectGetType(virConnectPtr conn) return NULL; /* Stash. */ - return priv->type = ret.type; + return priv->type = g_steal_pointer(&ret.type); } static int remoteConnectIsSecure(virConnectPtr conn) -- 2.43.0

2 1

[PATCH 0/8] migration fixes for non-shared storage migration
by Peter Krempa 07 Dec '23

07 Dec '23

Peter Krempa (8): qemuMigrationDstPrecreateStorage: Improve error messages qemuMigrationDstPrecreateStorage: Refactor cleanup qemuMigrationDstPrecreateStorage: Fix and clarify logic qemu: migration: Improve handling of VIR_MIGRATE_PARAM_DEST_XML with VIR_MIGRATE_PERSIST_DEST qemuDomainStorageOpenStat: Remove unused 'driver' argument and untangle callers qemu: migration: Rename qemuMigrationDstPrecreateStorage to qemuMigrationDstPrepareStorage qemu: Move and export qemuDomainStorageUpdatePhysical and dependencies qemu: migration: Automatically fix non-shared-storage migration to bigger block devices src/qemu/qemu_domain.c | 114 +++++++++++++++++++++++++++++ src/qemu/qemu_domain.h | 16 ++++ src/qemu/qemu_driver.c | 149 ++++---------------------------------- src/qemu/qemu_migration.c | 146 +++++++++++++++++++++++++++---------- 4 files changed, 249 insertions(+), 176 deletions(-) -- 2.43.0

2 9

[PATCH 0/3] nodedev: Storage device size fixes
by Peter Krempa 07 Dec '23

07 Dec '23

Peter Krempa (3): virNodeDeviceCapStorageDefFormat: Don't check argument for virBufferEscapeString virNodeDeviceCapStorageDefFormat: Extract formatting of block size data virNodeDeviceCapStorageDefFormatBlocksize: Report sector size and count together src/conf/node_device_conf.c | 65 +++++++++++++++---------------------- 1 file changed, 27 insertions(+), 38 deletions(-) -- 2.43.0

2 4

[PATCH v1] qemu_driver: Don't handle the EOF event if monitor changed
by tugy＠chinatelecom.cn 07 Dec '23

07 Dec '23

From: Guoyi Tu <tugy(a)chinatelecom.cn> Currently, libvirt creates a thread pool with only on thread to handle all qemu monitor events for virtual machines, In the cases that if the thread gets stuck while handling a monitor EOF event, such as unable to kill the virtual machine process or release resources, the events of other virtual machine will be also blocked, which will lead to the abnormal behavior of other virtual machines. For instance, when another virtual machine completes a shutdown operation and the monitor EOF event has been queued but remains unprocessed, we immediately destroy and start the virtual machine again, at a later time when EOF event get processed, the processMonitorEOFEvent() will kill the virtual machine that just started. To address this issue, in the processMonitorEOFEvent(), we check whether the current virtual machine's monitor object matches the one at the time the event was generated. If they do not match, we immediately return. Signed-off-by: Guoyi Tu <tugy(a)chinatelecom.cn> Signed-off-by: dengpengcheng <dengpc12(a)chinatelecom.cn> --- src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_driver.c | 11 +++++++++-- src/qemu/qemu_process.c | 2 +- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 953808fcfe..435ee621df 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -11470,7 +11470,6 @@ qemuProcessEventFree(struct qemuProcessEvent *event) case QEMU_PROCESS_EVENT_NETDEV_STREAM_DISCONNECTED: case QEMU_PROCESS_EVENT_NIC_RX_FILTER_CHANGED: case QEMU_PROCESS_EVENT_SERIAL_CHANGED: - case QEMU_PROCESS_EVENT_MONITOR_EOF: case QEMU_PROCESS_EVENT_GUEST_CRASHLOADED: g_free(event->data); break; @@ -11484,6 +11483,7 @@ qemuProcessEventFree(struct qemuProcessEvent *event) case QEMU_PROCESS_EVENT_UNATTENDED_MIGRATION: case QEMU_PROCESS_EVENT_RESET: case QEMU_PROCESS_EVENT_NBDKIT_EXITED: + case QEMU_PROCESS_EVENT_MONITOR_EOF: case QEMU_PROCESS_EVENT_LAST: break; } diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index d00d2a27c6..57acafb48b 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3854,7 +3854,8 @@ processJobStatusChangeEvent(virDomainObj *vm, static void processMonitorEOFEvent(virQEMUDriver *driver, - virDomainObj *vm) + virDomainObj *vm, + qemuMonitor *mon) { qemuDomainObjPrivate *priv = vm->privateData; int eventReason = VIR_DOMAIN_EVENT_STOPPED_SHUTDOWN; @@ -3863,6 +3864,12 @@ processMonitorEOFEvent(virQEMUDriver *driver, unsigned int stopFlags = 0; virObjectEvent *event = NULL; + if (priv->mon != mon) { + VIR_DEBUG("Domain %p '%s' has been shutdown, ignoring EOF", + vm, vm->def->name); + return; + } + if (qemuProcessBeginStopJob(vm, VIR_JOB_DESTROY, true) < 0) return; @@ -4082,7 +4089,7 @@ static void qemuProcessEventHandler(void *data, void *opaque) processJobStatusChangeEvent(vm, processEvent->data); break; case QEMU_PROCESS_EVENT_MONITOR_EOF: - processMonitorEOFEvent(driver, vm); + processMonitorEOFEvent(driver, vm, processEvent->data); break; case QEMU_PROCESS_EVENT_PR_DISCONNECT: processPRDisconnectEvent(vm); diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index f32e82bbd1..ff54e947fe 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -316,7 +316,7 @@ qemuProcessHandleMonitorEOF(qemuMonitor *mon, } qemuProcessEventSubmit(vm, QEMU_PROCESS_EVENT_MONITOR_EOF, - 0, 0, NULL); + 0, 0, priv->mon); /* We don't want this EOF handler to be called over and over while the * thread is waiting for a job. -- 2.17.1

3 3

[PATCH] network: fix check in virNetworkLoadConfig
by Anastasia Belova 07 Dec '23

07 Dec '23

virFileLinkPointsTo return non-zero value on fail. This value may be positive or negative, so check should be != 0. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: bddbda99df ("network: Introduce virnetworkobj") Signed-off-by: Anastasia Belova <abelova(a)astralinux.ru> --- src/conf/virnetworkobj.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/virnetworkobj.c b/src/conf/virnetworkobj.c index 20ee8eb58a..47658986e8 100644 --- a/src/conf/virnetworkobj.c +++ b/src/conf/virnetworkobj.c @@ -945,7 +945,7 @@ virNetworkLoadConfig(virNetworkObjList *nets, if ((autostartLink = virNetworkConfigFile(autostartDir, name)) == NULL) return NULL; - if ((autostart = virFileLinkPointsTo(autostartLink, configFile)) < 0) + if ((autostart = virFileLinkPointsTo(autostartLink, configFile)) != 0) return NULL; if (!(def = virNetworkDefParse(NULL, configFile, xmlopt, false))) -- 2.30.2

3 3

[PATCH] security_util: fix log in virSecurityMoveRememberedLabel
by Anastasia Belova 07 Dec '23

07 Dec '23

Fix incorrect log message for timestamp value. Probably this line was copied from the check for attr. Found by Linux Verification Center (linuxtesting.org) Fixes: 7cfb7aab57 ("security_util: Remove stale XATTRs") Signed-off-by: Anastasia Belova <abelova(a)astralinux.ru> --- src/security/security_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/security/security_util.c b/src/security/security_util.c index a4e6687561..b96b4ccb1f 100644 --- a/src/security/security_util.c +++ b/src/security/security_util.c @@ -502,7 +502,7 @@ virSecurityMoveRememberedLabel(const char *name, } else if (errno != ENODATA) { virReportSystemError(errno, _("Unable to get XATTR %1$s on %2$s"), - attr_name, src); + timestamp_name, src); return -1; } } -- 2.30.2

2 1

[libvirt PATCH] test: remove redundant cpuTestGuestCPUID test
by Jonathon Jongsma 06 Dec '23

06 Dec '23

DO_TEST_CPUID(arch, host, json) is a multipart test. It consists of the following tests: - cpuTestHostCPUID() - cpuTestGuestCPUID(with JSON_* flag) - cpuTestCPUIDSignature() - DO_TEST_JSON(): - if json==JSON_MODELS: - cpuTestGuestCPUID(without JSON_* flag) - cpuTestJSONCPUID() - cputestJSONSignature() Notice that for tests with json==JSON_MODELS, cpuTestGuestCPUID() is actually called twice but with different arguments. The first one passes JSON_MODELS to the test function, while the second one passes 0. The main difference in behavior when calling cpuTestGuestCPUID() with or without the flag is that in the first case, it parses the captured qemu output from $ARCH-cpuid-$CPU.json. It extracts the cpu model list from that JSON, and uses that to filter out possible cpu models to match. In other words, it tries to match the cpu to a model that was supported by the qemu version that was used to generate this JSON file. When it finds a match, it generates a cpu definition and compares the xml form of that definition with the file $ARCH-cpuid-$CPU-guest.xml. When called without the JSON_MODELS flag, it simply attempts to match it against the full libvirt cpu map and doesn't attempt to filter out any matches based on the JSON qemu cpu model list. After it finds a match, it generates an xml definition for the cpu and compares it to the same file listed above. So if these two invocations disagree on the cpu match (e.g. because libvirt has added a cpu model to its cpu map that matches better than one that was supported by the version of qemu that generated the JSON file) the test will fail. This duplicate call to cpuTestGuestCPUID() was originally added in commit 49c945a6f5c885394507f88086cc2f9461df7c27. The original justification for that commit was to fix test failures when the Qemu driver was disabled. But since DO_TEST_JSON() is #defined empty when qemu is disabled, this particular invocation would not even be executed in this scenario, so it doesn't seem relevant. Signed-off-by: Jonathon Jongsma <jjongsma(a)redhat.com> --- tests/cputest.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tests/cputest.c b/tests/cputest.c index b3253e3116..93cd0e12a7 100644 --- a/tests/cputest.c +++ b/tests/cputest.c @@ -993,10 +993,6 @@ mymain(void) #if WITH_QEMU # define DO_TEST_JSON(arch, host, json) \ do { \ - if (json == JSON_MODELS) { \ - DO_TEST(arch, cpuTestGuestCPUID, host, host, \ - NULL, NULL, 0, NULL, 0, 0); \ - } \ if (json != JSON_NONE) { \ DO_TEST(arch, cpuTestJSONCPUID, host, host, \ NULL, NULL, 0, NULL, json, 0); \ -- 2.41.0

2 1

[libvirt PATCH v2] rpc: don't try to spawn non-existant daemon
by Daniel P. Berrangé 06 Dec '23

06 Dec '23

If libvirt is built in client only mode, the libvirtd/virtqemud/etc daemons won't exist. If the client is told to connect to a local hypervisor, it'll see the socket doesn't exist, try to spawn the daemon and then re-try connecting to the socket for a few seconds. Ultimately this will fail because the daemon doesn't exist and the user gets an error message error: Failed to connect socket to '/run/user/1000/libvirt/virtqemud-sock': No such file or directory technically this is accurate, but it doesn't help identify the root cause. With this change it will now report error: binary 'virtqemud' does not exist in $PATH: No such file or directory and will skip all the socket connect retries Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Last time it was suggested that virCommandGetBinaryPath could be extended to always check whether the binary exists. I started doing that and realized it was a bad idea as this method runs in a context which might not have permission to access to the binary we are about to run, as we've not changed user/group ID yet. So I'm re-posting this targetted fix, with format string fixup. src/rpc/virnetsocket.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c index b58f7a6b8f..0215c99c73 100644 --- a/src/rpc/virnetsocket.c +++ b/src/rpc/virnetsocket.c @@ -123,9 +123,19 @@ VIR_ONCE_GLOBAL_INIT(virNetSocket); #ifndef WIN32 static int virNetSocketForkDaemon(const char *binary) { - g_autoptr(virCommand) cmd = virCommandNewArgList(binary, - "--timeout=120", - NULL); + g_autofree char *binarypath = virFindFileInPath(binary); + g_autoptr(virCommand) cmd = NULL; + + if (!binarypath) { + virReportSystemError(ENOENT, + _("binary '%1$s' does not exist in $PATH"), + binary); + return -1; + } + + cmd = virCommandNewArgList(binarypath, + "--timeout=120", + NULL); virCommandAddEnvPassCommon(cmd); virCommandAddEnvPass(cmd, "XDG_CACHE_HOME"); -- 2.41.0

2 1

[PATCH] virsh: migrate: Fix logic bug in interlock of --copy-storage-synchronous-writes flag
by Peter Krempa 06 Dec '23

06 Dec '23

As the error message states we want to check that one of '--copy-storage-all' or '--copy-storage-inc' is used, but the condition mentioned VIR_MIGRATE_NON_SHARED_DISK twice. Fixes: 1c2bd205edd Resolves: https://issues.redhat.com/browse/RHEL-17596 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- tools/virsh-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 66f933dead..f7784b46e9 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -11194,7 +11194,7 @@ doMigrate(void *opaque) } if (flags & VIR_MIGRATE_NON_SHARED_SYNCHRONOUS_WRITES && - !(flags & (VIR_MIGRATE_NON_SHARED_DISK | VIR_MIGRATE_NON_SHARED_DISK))) { + !(flags & (VIR_MIGRATE_NON_SHARED_DISK | VIR_MIGRATE_NON_SHARED_INC))) { vshError(ctl, "'--copy-storage-synchronous-writes' requires one of '--copy-storage-all', '--copy-storage-inc'"); goto out; } -- 2.43.0

2 1

[PATCH 0/2] qemuDomainChangeNet: Reflect trustGuestRxFilters change
by Michal Privoznik 06 Dec '23

06 Dec '23

*** BLURB HERE *** Michal Prívozník (2): qemuMonitorJSONQueryRxFilter: Allow @filter to be NULL qemuDomainChangeNet: Reflect trustGuestRxFilters change src/qemu/qemu_hotplug.c | 51 ++++++++++++++++++++++++++++++++++++ src/qemu/qemu_monitor.c | 12 +++++++++ src/qemu/qemu_monitor_json.c | 3 ++- 3 files changed, 65 insertions(+), 1 deletion(-) -- 2.41.0

2 3

[RFC PATCH 0/5] qemu: Stop using 'raw' driver when not needed
by Peter Krempa 05 Dec '23

05 Dec '23

This patchset is RFC as it requires qemu patches to preserve format inside the 'backing file format' field, or we could break qcow2 images for older libvirt. The main rationale is documented in 5/5. Peter Krempa (5): [DO NOT PUSH] update qemu capabilities for 'backing-mask-protocol' qemu: capabilities: Introduce QEMU_CAPS_BLOCKJOB_BACKING_MASK_PROTOCOL qemu: monitor: Use 'backing-mask-protocol' for blockjobs when available qemu: block: Always add extra 'raw' layer for storage slice qemuBlockStorageSourceNeedsFormatLayer: Stop formatting 'raw' driver when not needed src/qemu/qemu_block.c | 66 +-- src/qemu/qemu_block.h | 3 +- src/qemu/qemu_capabilities.c | 5 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_monitor.c | 1 + src/qemu/qemu_monitor_json.c | 10 + src/qemu/qemu_monitor_priv.h | 2 + .../caps_8.2.0_x86_64.replies | 21 +- .../caps_8.2.0_x86_64.xml | 5 +- tests/qemuhotplugtest.c | 15 - .../async-teardown.x86_64-latest.args | 5 +- .../audio-alsa-best.x86_64-latest.args | 5 +- .../audio-alsa-full.x86_64-latest.args | 5 +- .../audio-alsa-minimal.x86_64-latest.args | 5 +- .../audio-coreaudio-best.x86_64-latest.args | 5 +- .../audio-coreaudio-full.x86_64-latest.args | 5 +- ...audio-coreaudio-minimal.x86_64-latest.args | 5 +- ...udio-default-nographics.x86_64-latest.args | 5 +- .../audio-default-sdl.x86_64-latest.args | 5 +- .../audio-default-spice.x86_64-latest.args | 5 +- .../audio-default-vnc.x86_64-latest.args | 5 +- .../audio-file-best.x86_64-latest.args | 5 +- .../audio-file-full.x86_64-latest.args | 5 +- .../audio-file-minimal.x86_64-latest.args | 5 +- .../audio-jack-full.x86_64-latest.args | 5 +- .../audio-jack-minimal.x86_64-latest.args | 5 +- .../audio-many-backends.x86_64-latest.args | 5 +- .../audio-none-best.x86_64-latest.args | 5 +- .../audio-none-full.x86_64-latest.args | 5 +- .../audio-none-minimal.x86_64-latest.args | 5 +- .../audio-oss-best.x86_64-latest.args | 5 +- .../audio-oss-full.x86_64-latest.args | 5 +- .../audio-oss-minimal.x86_64-latest.args | 5 +- .../audio-pipewire-best.x86_64-latest.args | 5 +- .../audio-pipewire-full.x86_64-latest.args | 5 +- .../audio-pipewire-minimal.x86_64-latest.args | 5 +- .../audio-pulseaudio-best.x86_64-latest.args | 5 +- .../audio-pulseaudio-full.x86_64-latest.args | 5 +- ...udio-pulseaudio-minimal.x86_64-latest.args | 5 +- .../audio-sdl-best.x86_64-latest.args | 5 +- .../audio-sdl-full.x86_64-latest.args | 5 +- .../audio-sdl-minimal.x86_64-latest.args | 5 +- .../audio-spice-best.x86_64-latest.args | 5 +- .../audio-spice-full.x86_64-latest.args | 5 +- .../audio-spice-minimal.x86_64-latest.args | 5 +- .../autoindex.x86_64-latest.args | 5 +- .../balloon-device-auto.x86_64-latest.args | 5 +- ...loon-device-deflate-off.x86_64-latest.args | 5 +- .../balloon-device-deflate.x86_64-latest.args | 5 +- .../balloon-device-period.x86_64-latest.args | 5 +- .../balloon-device.x86_64-latest.args | 5 +- .../blkiotune-device.x86_64-latest.args | 5 +- .../blkiotune.x86_64-latest.args | 5 +- .../boot-cdrom.x86_64-latest.args | 5 +- .../boot-complex.x86_64-latest.args | 35 +- .../boot-floppy-q35.x86_64-latest.args | 5 +- .../boot-floppy.x86_64-latest.args | 10 +- ...boot-menu-disable-drive.x86_64-latest.args | 5 +- .../boot-menu-disable.x86_64-latest.args | 5 +- ...enu-enable-with-timeout.x86_64-latest.args | 5 +- .../boot-menu-enable.x86_64-latest.args | 5 +- .../boot-multi.x86_64-latest.args | 5 +- .../boot-network.x86_64-latest.args | 5 +- .../boot-order.x86_64-latest.args | 20 +- .../channel-guestfwd.x86_64-latest.args | 5 +- ...l-qemu-vdagent-features.x86_64-latest.args | 5 +- .../channel-qemu-vdagent.x86_64-latest.args | 5 +- .../channel-spicevmc.x86_64-latest.args | 5 +- .../channel-virtio-auto.x86_64-latest.args | 5 +- .../channel-virtio-autoadd.x86_64-latest.args | 5 +- ...annel-virtio-autoassign.x86_64-latest.args | 5 +- .../channel-virtio-default.x86_64-latest.args | 5 +- .../channel-virtio-state.x86_64-latest.args | 5 +- .../channel-virtio-unix.x86_64-latest.args | 5 +- .../channel-virtio.x86_64-latest.args | 5 +- .../clock-absolute.x86_64-latest.args | 5 +- .../clock-catchup.x86_64-latest.args | 5 +- .../clock-france.x86_64-latest.args | 5 +- .../clock-hpet-off.x86_64-latest.args | 5 +- ...caltime-basis-localtime.x86_64-latest.args | 5 +- .../clock-localtime.x86_64-latest.args | 5 +- .../clock-realtime.x86_64-latest.args | 5 +- .../clock-utc.x86_64-latest.args | 5 +- .../clock-variable.x86_64-latest.args | 5 +- .../console-compat-auto.x86_64-latest.args | 5 +- .../console-compat.x86_64-latest.args | 5 +- .../console-virtio-many.x86_64-latest.args | 5 +- .../console-virtio.x86_64-latest.args | 5 +- .../controller-order.x86_64-latest.args | 10 +- .../controller-virtio-scsi.x86_64-latest.args | 25 +- ...st-passthrough-features.x86_64-latest.args | 5 +- .../cputune-cpuset-big-id.x86_64-latest.args | 5 +- .../cputune-zero-shares.x86_64-latest.args | 5 +- .../cputune.x86_64-latest.args | 5 +- .../devices-acpi-index.x86_64-latest.args | 10 +- .../disk-aio.x86_64-latest.args | 5 +- ...-backing-chains-noindex.x86_64-latest.args | 10 +- .../disk-blockio.x86_64-latest.args | 10 +- .../disk-boot-cdrom.x86_64-latest.args | 10 +- .../disk-boot-disk.x86_64-latest.args | 10 +- .../disk-cdrom-bus-other.x86_64-latest.args | 5 +- ...sk-cdrom-network-nbdkit.x86_64-latest.args | 15 +- .../disk-cdrom-network.x86_64-latest.args | 15 +- .../disk-cdrom-tray.x86_64-latest.args | 10 +- .../disk-cdrom.x86_64-latest.args | 10 +- .../disk-copy_on_read.x86_64-latest.args | 5 +- .../disk-detect-zeroes.x86_64-latest.args | 5 +- .../disk-device-removable.x86_64-latest.args | 15 +- .../disk-discard.x86_64-latest.args | 5 +- .../disk-floppy-q35.x86_64-latest.args | 5 +- .../disk-floppy-tray.x86_64-latest.args | 15 +- .../disk-floppy.x86_64-latest.args | 15 +- .../disk-fmt-qcow.x86_64-latest.args | 5 +- .../disk-geometry.x86_64-latest.args | 5 +- .../disk-ide-split.x86_64-latest.args | 10 +- .../disk-ide-wwn.x86_64-latest.args | 5 +- .../disk-ioeventfd.x86_64-latest.args | 5 +- .../disk-network-gluster.x86_64-latest.args | 10 +- ...isk-network-http-nbdkit.x86_64-latest.args | 20 +- .../disk-network-http.x86_64-latest.args | 20 +- .../disk-network-iscsi.x86_64-latest.args | 35 +- .../disk-network-nbd.x86_64-latest.args | 30 +- .../disk-network-nfs.x86_64-latest.args | 5 +- ...rbd-encryption-luks-any.x86_64-latest.args | 7 +- ...sk-network-rbd-no-colon.x86_64-latest.args | 10 +- .../disk-network-rbd.x86_64-latest.args | 30 +- ...isk-network-source-auth.x86_64-latest.args | 15 +- ...work-source-curl-nbdkit.x86_64-latest.args | 20 +- ...isk-network-source-curl.x86_64-latest.args | 20 +- ...disk-network-ssh-nbdkit.x86_64-latest.args | 5 +- ...sk-network-ssh-password.x86_64-latest.args | 5 +- .../disk-network-ssh.x86_64-latest.args | 5 +- ...rk-tlsx509-nbd-hostname.x86_64-latest.args | 5 +- ...isk-network-tlsx509-nbd.x86_64-latest.args | 5 +- .../disk-no-boot.x86_64-latest.args | 15 +- .../disk-nvme.x86_64-latest.args | 15 +- .../disk-order.x86_64-latest.args | 20 +- .../disk-readonly-disk.x86_64-latest.args | 10 +- .../disk-rotation.x86_64-latest.args | 15 +- .../disk-sata-device.x86_64-latest.args | 5 +- .../disk-scsi-device-auto.x86_64-latest.args | 10 +- .../disk-scsi-disk-split.x86_64-latest.args | 20 +- .../disk-scsi-disk-vpd.x86_64-latest.args | 10 +- .../disk-scsi-disk-wwn.x86_64-latest.args | 10 +- ...sk-scsi-lun-passthrough.x86_64-latest.args | 10 +- .../disk-scsi.x86_64-latest.args | 30 +- .../disk-serial.x86_64-latest.args | 10 +- .../disk-shared.x86_64-latest.args | 20 +- .../disk-slices.x86_64-latest.args | 8 +- .../disk-snapshot.x86_64-latest.args | 5 +- .../disk-source-pool-mode.x86_64-latest.args | 20 +- .../disk-source-pool.x86_64-latest.args | 10 +- .../disk-usb-device.x86_64-latest.args | 10 +- .../disk-vhostvdpa.x86_64-latest.args | 5 +- .../disk-virtio-queues.x86_64-latest.args | 15 +- ...irtio-scsi-reservations.x86_64-latest.args | 10 +- .../disk-virtio.x86_64-latest.args | 20 +- .../event_idx.x86_64-latest.args | 5 +- .../fips-enabled.x86_64-latest.args | 5 +- ...-auto-efi-enrolled-keys.x86_64-latest.args | 5 +- ...uto-efi-loader-insecure.x86_64-latest.args | 5 +- ...re-auto-efi-loader-path.x86_64-latest.args | 5 +- ...-auto-efi-loader-secure.x86_64-latest.args | 5 +- ...to-efi-no-enrolled-keys.x86_64-latest.args | 5 +- ...are-auto-efi-no-secboot.x86_64-latest.args | 5 +- ...are-auto-efi-nvram-file.x86_64-latest.args | 5 +- ...efi-nvram-network-iscsi.x86_64-latest.args | 5 +- ...o-efi-nvram-network-nbd.x86_64-latest.args | 5 +- ...are-auto-efi-nvram-path.x86_64-latest.args | 5 +- ...auto-efi-nvram-template.x86_64-latest.args | 5 +- ...rmware-auto-efi-secboot.x86_64-latest.args | 5 +- ...rmware-auto-efi-smm-off.x86_64-latest.args | 5 +- .../firmware-auto-efi.x86_64-latest.args | 5 +- ...are-manual-efi-acpi-q35.x86_64-latest.args | 5 +- ...are-manual-efi-features.x86_64-latest.args | 5 +- ...loader-path-nonstandard.x86_64-latest.args | 5 +- ...anual-efi-loader-secure.x86_64-latest.args | 5 +- ...olled-keys-legacy-paths.x86_64-latest.args | 5 +- ...al-efi-no-enrolled-keys.x86_64-latest.args | 5 +- ...no-secboot-legacy-paths.x86_64-latest.args | 5 +- ...e-manual-efi-no-secboot.x86_64-latest.args | 5 +- ...e-manual-efi-nvram-file.x86_64-latest.args | 5 +- ...efi-nvram-network-iscsi.x86_64-latest.args | 5 +- ...l-efi-nvram-network-nbd.x86_64-latest.args | 5 +- ...am-template-nonstandard.x86_64-latest.args | 5 +- ...nual-efi-nvram-template.x86_64-latest.args | 5 +- ...fi-secboot-legacy-paths.x86_64-latest.args | 5 +- ...ware-manual-efi-secboot.x86_64-latest.args | 5 +- .../firmware-manual-efi.x86_64-latest.args | 5 +- .../graphics-dbus-audio.x86_64-latest.args | 5 +- ...egl-headless-rendernode.x86_64-latest.args | 5 +- .../graphics-egl-headless.x86_64-latest.args | 5 +- ...graphics-sdl-fullscreen.x86_64-latest.args | 5 +- .../graphics-sdl.x86_64-latest.args | 5 +- ...ics-vnc-auto-socket-cfg.x86_64-latest.args | 5 +- ...aphics-vnc-egl-headless.x86_64-latest.args | 5 +- ...hics-vnc-no-listen-attr.x86_64-latest.args | 5 +- .../graphics-vnc-policy.x86_64-latest.args | 5 +- .../graphics-vnc-power.x86_64-latest.args | 5 +- ...remove-generated-socket.x86_64-latest.args | 5 +- .../graphics-vnc-sasl.x86_64-latest.args | 5 +- .../graphics-vnc.x86_64-latest.args | 5 +- ...tdev-pci-address-device.x86_64-latest.args | 5 +- .../hostdev-pci-address.x86_64-latest.args | 5 +- .../hostdev-scsi-lsi.x86_64-latest.args | 5 +- ...dev-scsi-vhost-scsi-pci.x86_64-latest.args | 5 +- ...ostdev-scsi-virtio-scsi.x86_64-latest.args | 5 +- ...usb-address-device-boot.x86_64-latest.args | 5 +- ...tdev-usb-address-device.x86_64-latest.args | 5 +- .../hostdev-usb-address.x86_64-latest.args | 5 +- ...ostdev-vfio-multidomain.x86_64-latest.args | 5 +- .../hostdev-vfio.x86_64-latest.args | 5 +- .../hugepages-memaccess.x86_64-latest.args | 5 +- .../hugepages-memaccess2.x86_64-latest.args | 5 +- .../hugepages-shared.x86_64-latest.args | 5 +- .../input-usbmouse-addr.x86_64-latest.args | 5 +- .../input-usbmouse.x86_64-latest.args | 5 +- .../input-usbtablet.x86_64-latest.args | 5 +- .../iothreads-disk.x86_64-latest.args | 10 +- ...threads-virtio-scsi-pci.x86_64-latest.args | 10 +- .../kvm-pit-delay.x86_64-latest.args | 5 +- .../kvm-pit-discard.x86_64-latest.args | 5 +- ...nch-security-sev-direct.x86_64-latest.args | 5 +- .../machine-aliases1.x86_64-latest.args | 5 +- .../machine-aliases2.x86_64-latest.args | 5 +- .../machine-core-off.x86_64-latest.args | 5 +- .../machine-core-on.x86_64-latest.args | 5 +- .../machine-vmport-opt.x86_64-latest.args | 5 +- ...emory-hotplug-dimm-addr.x86_64-latest.args | 5 +- .../memory-hotplug-dimm.x86_64-latest.args | 5 +- ...memory-hotplug-multiple.x86_64-latest.args | 5 +- ...y-hotplug-nvdimm-access.x86_64-latest.args | 5 +- ...ry-hotplug-nvdimm-align.x86_64-latest.args | 5 +- ...ry-hotplug-nvdimm-label.x86_64-latest.args | 5 +- ...ory-hotplug-nvdimm-pmem.x86_64-latest.args | 5 +- ...hotplug-nvdimm-readonly.x86_64-latest.args | 5 +- .../memory-hotplug-nvdimm.x86_64-latest.args | 5 +- ...mory-hotplug-virtio-mem.x86_64-latest.args | 5 +- ...ory-hotplug-virtio-pmem.x86_64-latest.args | 5 +- .../memory-hotplug.x86_64-latest.args | 5 +- .../memtune-unlimited.x86_64-latest.args | 5 +- .../memtune.x86_64-latest.args | 5 +- .../migrate.x86_64-latest.args | 5 +- .../minimal.x86_64-latest.args | 5 +- .../misc-acpi.x86_64-latest.args | 5 +- .../misc-disable-s3.x86_64-latest.args | 5 +- .../misc-disable-suspends.x86_64-latest.args | 5 +- .../misc-enable-s4.x86_64-latest.args | 5 +- .../misc-no-reboot.x86_64-latest.args | 5 +- .../misc-uuid.x86_64-latest.args | 5 +- ...ultifunction-pci-device.x86_64-latest.args | 5 +- .../net-client.x86_64-latest.args | 5 +- .../net-eth-hostip.x86_64-latest.args | 5 +- .../net-eth-ifname.x86_64-latest.args | 5 +- .../net-eth-names.x86_64-latest.args | 5 +- .../net-eth-unmanaged-tap.x86_64-latest.args | 5 +- .../net-eth.x86_64-latest.args | 5 +- .../net-hostdev-bootorder.x86_64-latest.args | 5 +- ...net-hostdev-multidomain.x86_64-latest.args | 5 +- ...ostdev-vfio-multidomain.x86_64-latest.args | 5 +- .../net-hostdev-vfio.x86_64-latest.args | 5 +- .../net-hostdev.x86_64-latest.args | 5 +- .../net-mcast.x86_64-latest.args | 5 +- .../net-server.x86_64-latest.args | 5 +- .../net-udp.x86_64-latest.args | 5 +- .../net-user-addr.x86_64-latest.args | 5 +- .../net-user-passt.x86_64-latest.args | 5 +- .../net-user.x86_64-latest.args | 5 +- .../net-vhostuser-multiq.x86_64-latest.args | 5 +- .../net-virtio-device.x86_64-latest.args | 5 +- ...virtio-disable-offloads.x86_64-latest.args | 5 +- .../net-virtio-netdev.x86_64-latest.args | 5 +- .../net-virtio-rss.x86_64-latest.args | 5 +- ...et-virtio-rxtxqueuesize.x86_64-latest.args | 5 +- ...-virtio-teaming-hostdev.x86_64-latest.args | 5 +- .../net-virtio-teaming.x86_64-latest.args | 5 +- .../net-virtio.x86_64-latest.args | 5 +- .../nosharepages.x86_64-latest.args | 5 +- ...auto-memory-vcpu-cpuset.x86_64-latest.args | 5 +- ...no-cpuset-and-placement.x86_64-latest.args | 5 +- ...to-vcpu-static-numatune.x86_64-latest.args | 5 +- ...static-memory-auto-vcpu.x86_64-latest.args | 5 +- .../qemuxml2argvdata/numad.x86_64-latest.args | 5 +- ...ne-auto-nodeset-invalid.x86_64-latest.args | 5 +- .../panic-no-address.x86_64-latest.args | 5 +- .../qemuxml2argvdata/panic.x86_64-latest.args | 5 +- ...arallel-parport-chardev.x86_64-latest.args | 5 +- .../parallel-tcp-chardev.x86_64-latest.args | 5 +- .../pci-autoadd-addr.x86_64-latest.args | 5 +- .../pci-autoadd-idx.x86_64-latest.args | 5 +- .../pci-autofill-addr.x86_64-latest.args | 5 +- .../pci-bridge-many-disks.x86_64-latest.args | 525 +++++++----------- .../pci-bridge.x86_64-latest.args | 5 +- .../pci-many.x86_64-latest.args | 145 ++--- .../pci-rom.x86_64-latest.args | 5 +- .../pcie-expander-bus.x86_64-latest.args | 5 +- .../pcie-root-port.x86_64-latest.args | 5 +- ...-switch-downstream-port.x86_64-latest.args | 5 +- ...ie-switch-upstream-port.x86_64-latest.args | 5 +- .../pcihole64-q35.x86_64-latest.args | 5 +- .../q35-pcie-autoadd.x86_64-latest.args | 5 +- .../q35-pcie.x86_64-latest.args | 5 +- .../q35-usb2-multi.x86_64-latest.args | 5 +- .../q35-usb2-reorder.x86_64-latest.args | 5 +- .../q35-usb2.x86_64-latest.args | 5 +- tests/qemuxml2argvdata/q35.x86_64-latest.args | 5 +- .../qemu-ns-alt.x86_64-latest.args | 5 +- ...qemu-ns-commandline-ns0.x86_64-latest.args | 5 +- ...qemu-ns-commandline-ns1.x86_64-latest.args | 5 +- .../qemu-ns-commandline.x86_64-latest.args | 5 +- ...-domain-commandline-ns0.x86_64-latest.args | 5 +- ...u-ns-domain-commandline.x86_64-latest.args | 5 +- .../qemu-ns-domain-ns0.x86_64-latest.args | 5 +- .../qemu-ns-no-env.x86_64-latest.args | 5 +- .../qemu-ns.x86_64-latest.args | 5 +- .../restore-v2-fd.x86_64-latest.args | 5 +- .../restore-v2.x86_64-latest.args | 5 +- .../seclabel-dac-none.x86_64-latest.args | 5 +- ...label-dynamic-baselabel.x86_64-latest.args | 5 +- ...label-dynamic-labelskip.x86_64-latest.args | 5 +- ...clabel-dynamic-override.x86_64-latest.args | 10 +- ...eclabel-dynamic-relabel.x86_64-latest.args | 5 +- .../seclabel-dynamic.x86_64-latest.args | 5 +- .../seclabel-none.x86_64-latest.args | 5 +- ...clabel-static-labelskip.x86_64-latest.args | 5 +- ...seclabel-static-relabel.x86_64-latest.args | 5 +- .../seclabel-static.x86_64-latest.args | 5 +- ...rial-dev-chardev-iobase.x86_64-latest.args | 5 +- .../serial-dev-chardev.x86_64-latest.args | 5 +- .../serial-file-chardev.x86_64-latest.args | 5 +- .../serial-file-log.x86_64-latest.args | 5 +- .../serial-many-chardev.x86_64-latest.args | 5 +- .../serial-pty-chardev.x86_64-latest.args | 5 +- .../serial-spiceport.x86_64-latest.args | 5 +- .../serial-tcp-chardev.x86_64-latest.args | 5 +- ...rial-tcp-telnet-chardev.x86_64-latest.args | 5 +- ...p-tlsx509-chardev-notls.x86_64-latest.args | 5 +- ...-tlsx509-chardev-verify.x86_64-latest.args | 5 +- ...ial-tcp-tlsx509-chardev.x86_64-latest.args | 5 +- ...-tlsx509-secret-chardev.x86_64-latest.args | 5 +- .../serial-udp-chardev.x86_64-latest.args | 5 +- .../serial-vc-chardev.x86_64-latest.args | 5 +- .../smbios-type-fwcfg.x86_64-latest.args | 5 +- .../smbios.x86_64-latest.args | 5 +- .../user-aliases.x86_64-latest.args | 10 +- .../user-aliases2.x86_64-latest.args | 5 +- ...host-user-gpu-secondary.x86_64-latest.args | 5 +- .../vhost-user-vga.x86_64-latest.args | 5 +- .../video-none-device.x86_64-latest.args | 5 +- .../video-qxl-heads.x86_64-latest.args | 5 +- .../video-qxl-noheads.x86_64-latest.args | 5 +- .../video-qxl-resolution.x86_64-latest.args | 5 +- .../video-vga-qxl-heads.x86_64-latest.args | 5 +- .../virtio-lun.x86_64-latest.args | 10 +- ...virtio-non-transitional.x86_64-latest.args | 5 +- ...virtio-options-disk-ats.x86_64-latest.args | 10 +- ...rtio-options-disk-iommu.x86_64-latest.args | 10 +- ...tio-options-disk-packed.x86_64-latest.args | 10 +- .../virtio-options.x86_64-latest.args | 5 +- .../virtio-transitional.x86_64-latest.args | 5 +- .../vmcoreinfo.x86_64-latest.args | 5 +- .../watchdog-device.x86_64-latest.args | 5 +- .../watchdog-dump.x86_64-latest.args | 5 +- .../watchdog-injectnmi.x86_64-latest.args | 5 +- .../watchdog.x86_64-latest.args | 5 +- 366 files changed, 1267 insertions(+), 1854 deletions(-) -- 2.43.0

1 5

[PATCH 0/2] qemu: migration fixes
by Peter Krempa 05 Dec '23

05 Dec '23

Peter Krempa (2): qemu: migration: Validate migration XML virsh: migrate: Interlock '--copy-storage-all' and '--copy-storage-inc' src/qemu/qemu_migration.c | 9 +++------ tools/virsh-domain.c | 1 + 2 files changed, 4 insertions(+), 6 deletions(-) -- 2.43.0

2 3

[PATCH 0/2] qemu: Relax check for memory device coldplug
by Michal Privoznik 05 Dec '23

05 Dec '23

*** BLURB HERE *** Michal Prívozník (2): qemu: Move memory device coldplug into a separate function qemu: Relax check for memory device coldplug src/qemu/qemu_driver.c | 45 ++++++++++++++++++++++++++++++++---------- 1 file changed, 35 insertions(+), 10 deletions(-) -- 2.41.0

2 3

[PATCH] vir-qemu-sev-validate: Use string() method in xpath
by Han Han 05 Dec '23

05 Dec '23

For the xpath "/domain/cpu/@mode", it will return a list type not a string. Use string() method in the xpath for the string result. Fixes: 6b95437c17 Signed-off-by: Han Han <hhan(a)redhat.com> --- tools/virt-qemu-sev-validate | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virt-qemu-sev-validate b/tools/virt-qemu-sev-validate index 67edbd085f..115266976b 100755 --- a/tools/virt-qemu-sev-validate +++ b/tools/virt-qemu-sev-validate @@ -1054,7 +1054,7 @@ class LibvirtConfidentialVM(ConfidentialVM): raise InsecureUsageException( "Using CPU SKU from capabilities is not secure") - mode = doc.xpath("/domain/cpu/@mode") + mode = doc.xpath("string(/domain/cpu/@mode)") if mode != "host-passthrough": raise UnsupportedUsageException( "Using CPU family/model/stepping from host not possible unless 'host-passthrough' is used") -- 2.43.0

2 1

[PATCH] gitpublish: Tweak prefix
by Andrea Bolognani 05 Dec '23

05 Dec '23

Having the name of the project as part of the prefix was useful back when we used the mailing list for all subprojects, but these days the only patches that are sent to the list are for the main library so it no longer makes sense to include this. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- .gitpublish | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitpublish b/.gitpublish index 1c89c0039e..01c5c1af21 100644 --- a/.gitpublish +++ b/.gitpublish @@ -1,5 +1,5 @@ [gitpublishprofile "default"] base = master to = devel(a)lists.libvirt.org -prefix = libvirt PATCH +prefix = PATCH suppresscc = misc-by -- 2.43.0

2 2

[libvirt PATCH 0/2] docs: Switch to DuckDuckGo for search
by Andrea Bolognani 05 Dec '23

05 Dec '23

Andrea Bolognani (2): docs: Use DuckDuckGo for website/wiki search docs: Mention use of DuckDuckGo docs/css/libvirt.css | 2 +- docs/js/main.js | 16 +++++++++++----- docs/page.xsl | 8 ++++---- 3 files changed, 16 insertions(+), 10 deletions(-) -- 2.43.0

2 3

[libvirt PATCH 0/9] rpm: Tweak dependencies
by Andrea Bolognani 05 Dec '23

05 Dec '23

Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1092535621 lcitool changes: https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/447 Andrea Bolognani (9): rpm: Drop MinGW BuildRequires on libgcrypt/libgpg-error meson: Stop looking for udevadm at build time meson: Stop looking for scrub at build time meson: Stop looking for passt at build time rpm: Add Requires on scrub rpm: Drop BuildDepends on scrub rpm: Drop BuildDepends on passt ci: Refresh generated files ci: Stop passing --nodeps to rpmbuild ci/buildenv/almalinux-8.sh | 5 ++++- ci/buildenv/alpine-317.sh | 1 + ci/buildenv/alpine-edge.sh | 1 + ci/buildenv/centos-stream-8.sh | 5 ++++- ci/buildenv/centos-stream-9.sh | 5 ++++- ci/buildenv/debian-11-cross-aarch64.sh | 2 +- ci/buildenv/debian-11-cross-armv6l.sh | 2 +- ci/buildenv/debian-11-cross-armv7l.sh | 2 +- ci/buildenv/debian-11-cross-i686.sh | 2 +- ci/buildenv/debian-11-cross-mips64el.sh | 2 +- ci/buildenv/debian-11-cross-mipsel.sh | 2 +- ci/buildenv/debian-11-cross-ppc64le.sh | 2 +- ci/buildenv/debian-11-cross-s390x.sh | 2 +- ci/buildenv/debian-11.sh | 2 +- ci/buildenv/debian-12-cross-aarch64.sh | 2 +- ci/buildenv/debian-12-cross-armv6l.sh | 2 +- ci/buildenv/debian-12-cross-armv7l.sh | 2 +- ci/buildenv/debian-12-cross-i686.sh | 2 +- ci/buildenv/debian-12-cross-mips64el.sh | 2 +- ci/buildenv/debian-12-cross-mipsel.sh | 2 +- ci/buildenv/debian-12-cross-ppc64le.sh | 2 +- ci/buildenv/debian-12-cross-s390x.sh | 2 +- ci/buildenv/debian-12.sh | 2 +- ci/buildenv/debian-sid-cross-aarch64.sh | 2 +- ci/buildenv/debian-sid-cross-armv6l.sh | 2 +- ci/buildenv/debian-sid-cross-armv7l.sh | 2 +- ci/buildenv/debian-sid-cross-i686.sh | 2 +- ci/buildenv/debian-sid-cross-mips64el.sh | 2 +- ci/buildenv/debian-sid-cross-ppc64le.sh | 2 +- ci/buildenv/debian-sid-cross-s390x.sh | 2 +- ci/buildenv/debian-sid.sh | 2 +- ci/buildenv/fedora-37.sh | 2 +- ci/buildenv/fedora-38-cross-mingw32.sh | 2 +- ci/buildenv/fedora-38-cross-mingw64.sh | 2 +- ci/buildenv/fedora-38.sh | 2 +- ci/buildenv/fedora-rawhide-cross-mingw32.sh | 2 +- ci/buildenv/fedora-rawhide-cross-mingw64.sh | 2 +- ci/buildenv/fedora-rawhide.sh | 2 +- ci/buildenv/opensuse-leap-15.sh | 5 ++++- ci/buildenv/opensuse-tumbleweed.sh | 4 ++-- ci/buildenv/ubuntu-2004.sh | 2 +- ci/buildenv/ubuntu-2204.sh | 2 +- ci/cirrus/freebsd-12.vars | 2 +- ci/cirrus/freebsd-13.vars | 2 +- ci/cirrus/macos-13.vars | 2 +- ci/cirrus/macos-14.vars | 2 +- ci/containers/almalinux-8.Dockerfile | 6 +++++- ci/containers/alpine-317.Dockerfile | 1 + ci/containers/alpine-edge.Dockerfile | 1 + ci/containers/centos-stream-8.Dockerfile | 6 +++++- ci/containers/centos-stream-9.Dockerfile | 6 +++++- ci/containers/debian-11-cross-aarch64.Dockerfile | 2 +- ci/containers/debian-11-cross-armv6l.Dockerfile | 2 +- ci/containers/debian-11-cross-armv7l.Dockerfile | 2 +- ci/containers/debian-11-cross-i686.Dockerfile | 2 +- ci/containers/debian-11-cross-mips64el.Dockerfile | 2 +- ci/containers/debian-11-cross-mipsel.Dockerfile | 2 +- ci/containers/debian-11-cross-ppc64le.Dockerfile | 2 +- ci/containers/debian-11-cross-s390x.Dockerfile | 2 +- ci/containers/debian-11.Dockerfile | 2 +- ci/containers/debian-12-cross-aarch64.Dockerfile | 2 +- ci/containers/debian-12-cross-armv6l.Dockerfile | 2 +- ci/containers/debian-12-cross-armv7l.Dockerfile | 2 +- ci/containers/debian-12-cross-i686.Dockerfile | 2 +- ci/containers/debian-12-cross-mips64el.Dockerfile | 2 +- ci/containers/debian-12-cross-mipsel.Dockerfile | 2 +- ci/containers/debian-12-cross-ppc64le.Dockerfile | 2 +- ci/containers/debian-12-cross-s390x.Dockerfile | 2 +- ci/containers/debian-12.Dockerfile | 2 +- ci/containers/debian-sid-cross-aarch64.Dockerfile | 2 +- ci/containers/debian-sid-cross-armv6l.Dockerfile | 2 +- ci/containers/debian-sid-cross-armv7l.Dockerfile | 2 +- ci/containers/debian-sid-cross-i686.Dockerfile | 2 +- ci/containers/debian-sid-cross-mips64el.Dockerfile | 2 +- ci/containers/debian-sid-cross-ppc64le.Dockerfile | 2 +- ci/containers/debian-sid-cross-s390x.Dockerfile | 2 +- ci/containers/debian-sid.Dockerfile | 2 +- ci/containers/fedora-37.Dockerfile | 2 +- ci/containers/fedora-38-cross-mingw32.Dockerfile | 2 +- ci/containers/fedora-38-cross-mingw64.Dockerfile | 2 +- ci/containers/fedora-38.Dockerfile | 2 +- ci/containers/fedora-rawhide-cross-mingw32.Dockerfile | 2 +- ci/containers/fedora-rawhide-cross-mingw64.Dockerfile | 2 +- ci/containers/fedora-rawhide.Dockerfile | 2 +- ci/containers/opensuse-leap-15.Dockerfile | 6 +++++- ci/containers/opensuse-tumbleweed.Dockerfile | 4 ++-- ci/containers/ubuntu-2004.Dockerfile | 2 +- ci/containers/ubuntu-2204.Dockerfile | 2 +- ci/jobs.sh | 1 - libvirt.spec.in | 11 ++--------- meson.build | 3 --- src/qemu/qemu_passt.c | 3 +++ src/storage/storage_util.c | 1 + src/util/virutil.c | 2 ++ 94 files changed, 126 insertions(+), 99 deletions(-) -- 2.43.0

2 10

[PATCH] NEWS: Fix indentation
by Andrea Bolognani 01 Dec '23

01 Dec '23

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. NEWS.rst | 39 ++++++++++++++++++++------------------- 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index c0a6d180a2..dc40602c72 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -176,10 +176,10 @@ v9.6.0 (2023-08-01) * ``CVE-2023-3750``: Fix race condition in storage driver leading to a crash - In **libvirt-8.3** a bug was introduced which in rare cases could cause - ``libvirtd`` or ``virtstoraged`` to crash if multiple clients attempted to - look up a storage volume by key, path or target path, while other clients - attempted to access something from the same storage pool. + In **libvirt-8.3** a bug was introduced which in rare cases could cause + ``libvirtd`` or ``virtstoraged`` to crash if multiple clients attempted to + look up a storage volume by key, path or target path, while other clients + attempted to access something from the same storage pool. * **Improvements** @@ -1983,17 +1983,17 @@ v7.1.0 (2021-03-01) * qemu: Fix disk quiescing rollback when creating external snapshots - If the qemu guest agent call to freeze filesystems failed when creating - an external snapshot with ``VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE`` flag the - filesystems would be unconditionally thawed. This could cause problems when - the filesystems were frozen by an explicit call to ``virDomainFSFreeze`` - since the guest agent then rejects any further freeze attempts once are - filesystems frozen, an explicit freeze followed by a quiesced snapshot - would fail and thaw filesystems. + If the qemu guest agent call to freeze filesystems failed when creating + an external snapshot with ``VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE`` flag the + filesystems would be unconditionally thawed. This could cause problems when + the filesystems were frozen by an explicit call to ``virDomainFSFreeze`` + since the guest agent then rejects any further freeze attempts once are + filesystems frozen, an explicit freeze followed by a quiesced snapshot + would fail and thaw filesystems. - Users are also encouraged to use ``virDomainFSFreeze/Thaw`` manually instead - of relying on ``VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE`` if they need finer - grained control. + Users are also encouraged to use ``virDomainFSFreeze/Thaw`` manually instead + of relying on ``VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE`` if they need finer + grained control. * cgroups: Fix how we setup and configure cgroups on hosts with systemd @@ -2155,11 +2155,12 @@ v6.10.0 (2020-12-01) * qemu: Enable client TLS certificate validation by default for ``chardev``, ``migration``, and ``backup`` servers. - The default value if qemu.conf options ``chardev_tls_x509_verify``, - ``migrate_tls_x509_verify``, or ``backup_tls_x509_verify`` are not specified - explicitly in the config file and also the ``default_tls_x509_verify`` config - option is missing are now '1'. This ensures that only legitimate clients - access servers, which don't have any additional form of authentication. + The default value if qemu.conf options ``chardev_tls_x509_verify``, + ``migrate_tls_x509_verify``, or ``backup_tls_x509_verify`` are not + specified explicitly in the config file and also the + ``default_tls_x509_verify`` config option is missing are now '1'. This + ensures that only legitimate clients access servers, which don't have any + additional form of authentication. * qemu: Introduce "migrate_tls_force" qemu.conf option -- 2.43.0

1 0