- Devel - libvirt List Archives

[libvirt] [PATCH] qemu: Use 'idx' instead of 'index' for variable name
by John Ferlan 14 Apr '15

14 Apr '15

Apparently for Xen-devel 'index' is a global and causes a build failure, so just use the shortened 'idx' instead to avoid the conflict. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- I did try modify cfg.mk to add a syntax check similar to the ii,jj,kk checks, but it tripped up over 'index' declarations inside structures. I'd be happy to add one, but I need some help formatting it... Here's what I had: sc_prohibit_int_index: @prohibit='\<(int|unsigned) ([^(=]* )*(index)\>(\s|,|;)' \ halt='use different name than 'index' for declaration' \ $(_sc_search_regexp) src/qemu/qemu_driver.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e790664..3510690 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -4638,7 +4638,7 @@ static void qemuProcessEventHandler(void *data, void *opaque) static virCgroupPtr qemuDomainAddCgroupForThread(virCgroupPtr cgroup, virCgroupThreadName nameval, - int index, + int idx, char *mem_mask, pid_t pid) { @@ -4646,7 +4646,7 @@ qemuDomainAddCgroupForThread(virCgroupPtr cgroup, int rv = -1; /* Create cgroup */ - if (virCgroupNewThread(cgroup, nameval, index, true, &new_cgroup) < 0) + if (virCgroupNewThread(cgroup, nameval, idx, true, &new_cgroup) < 0) return NULL; if (mem_mask && virCgroupSetCpusetMems(new_cgroup, mem_mask) < 0) @@ -4657,7 +4657,7 @@ qemuDomainAddCgroupForThread(virCgroupPtr cgroup, if (rv < 0) { virReportSystemError(-rv, _("unable to add id %d task %d to cgroup"), - index, pid); + idx, pid); virCgroupRemove(new_cgroup); goto error; } @@ -4671,7 +4671,7 @@ qemuDomainAddCgroupForThread(virCgroupPtr cgroup, static int qemuDomainHotplugAddPin(virBitmapPtr cpumask, - int index, + int idx, virDomainPinDefPtr **pindef_list, size_t *npin) { @@ -4685,7 +4685,7 @@ qemuDomainHotplugAddPin(virBitmapPtr cpumask, VIR_FREE(pindef); goto cleanup; } - pindef->id = index; + pindef->id = idx; if (VIR_APPEND_ELEMENT_COPY(*pindef_list, *npin, pindef) < 0) { virBitmapFree(pindef->cpumask); VIR_FREE(pindef); @@ -4699,7 +4699,7 @@ qemuDomainHotplugAddPin(virBitmapPtr cpumask, static int qemuDomainHotplugPinThread(virBitmapPtr cpumask, - int index, + int idx, pid_t pid, virCgroupPtr cgroup) { @@ -4709,14 +4709,14 @@ qemuDomainHotplugPinThread(virBitmapPtr cpumask, if (qemuSetupCgroupCpusetCpus(cgroup, cpumask) < 0) { virReportError(VIR_ERR_OPERATION_INVALID, _("failed to set cpuset.cpus in cgroup for id %d"), - index); + idx); goto cleanup; } } else { if (virProcessSetAffinity(pid, cpumask) < 0) { virReportError(VIR_ERR_SYSTEM_ERROR, _("failed to set cpu affinity for id %d"), - index); + idx); goto cleanup; } } @@ -4730,12 +4730,12 @@ qemuDomainHotplugPinThread(virBitmapPtr cpumask, static int qemuDomainDelCgroupForThread(virCgroupPtr cgroup, virCgroupThreadName nameval, - int index) + int idx) { virCgroupPtr new_cgroup = NULL; if (cgroup) { - if (virCgroupNewThread(cgroup, nameval, index, false, &new_cgroup) < 0) + if (virCgroupNewThread(cgroup, nameval, idx, false, &new_cgroup) < 0) return -1; /* Remove the offlined cgroup */ -- 2.1.0

2 4

[libvirt] [PATCHv3 0/7] Block job fixes and refactors
by Peter Krempa 14 Apr '15

14 Apr '15

Peter Krempa (7): qemu: monitor: json: Refactor error code class checker qemu: monitor: Extract handling of JSON block job error codes qemu: blockjob: Split qemuDomainBlockJobSetSpeed from qemuDomainBlockJobImpl qemu: blockjob: Separate qemuDomainBlockJobAbort from qemuDomainBlockJobImpl qemu: blockPull: Refactor the rest of qemuDomainBlockJobImpl qemu: drivePivot: Fix assumption when 'block-job-complete' fails qemu: Refactor qemuDomainBlockJobAbort() src/qemu/qemu_driver.c | 367 ++++++++++++++++++++++++------------------- src/qemu/qemu_migration.c | 8 +- src/qemu/qemu_monitor.c | 67 ++++++-- src/qemu/qemu_monitor.h | 29 ++-- src/qemu/qemu_monitor_json.c | 213 ++++++++++++++----------- src/qemu/qemu_monitor_json.h | 24 ++- 6 files changed, 414 insertions(+), 294 deletions(-) -- 2.2.2

2 9

[libvirt] [PATCH 0/5] Refactor vcpupin parser and fix error checking
by Peter Krempa 14 Apr '15

14 Apr '15

Peter Krempa (5): conf: Split out parsing of emulatorpin conf: Split up virDomainVcpuPinDefParseXML conf: Error out if iothread id is missing in iothreadpin conf: Refactor virDomainVcpuPinDefParseXML qemu: Fix condition for checking vcpu when pinning vcpus src/conf/domain_conf.c | 197 +++++++++++++++++++++++++++++-------------------- src/qemu/qemu_driver.c | 13 +++- 2 files changed, 128 insertions(+), 82 deletions(-) -- 2.2.2

2 11

[libvirt] [PATCH] lib: snapshot: Explain that only one layer of images is inserted
by Peter Krempa 14 Apr '15

14 Apr '15

When creating a snapshot with _REUSE_EXTERNAL when the pre-created image does not directly link to the current active layer libvirt would re-detect the backing chain incorrectly and it would not match with qemu's view. Since the configuration is an operator mistake, document that only the top layer image gets inserted. --- src/libvirt-domain-snapshot.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/libvirt-domain-snapshot.c b/src/libvirt-domain-snapshot.c index ac858ba..55826fd 100644 --- a/src/libvirt-domain-snapshot.c +++ b/src/libvirt-domain-snapshot.c @@ -177,8 +177,9 @@ virDomainSnapshotGetConnect(virDomainSnapshotPtr snapshot) * the correct image format and metadata including backing store path * (this allows a management app to pre-create files with relative backing * file names, rather than the default of creating with absolute backing - * file names). Note that setting incorrect metadata in the pre-created - * image may lead to the VM being unable to start. + * file names). Note that only the file specified in the snapshot XML is + * inserted as a snapshot thus setting incorrect metadata in the pre-created + * image may lead to the VM being unable to start or other block jobs may fail. * * Be aware that although libvirt prefers to report errors up front with * no other effect, some hypervisors have certain types of failures where -- 2.3.5

2 2

[libvirt] [PATCH 0/2] Fix handling of disk's WWN (world wide name)
by Peter Krempa 14 Apr '15

14 Apr '15

Peter Krempa (2): conf: ABI: Check WWN in disk abi stability check qemu: Enforce WWN to be unique among VM's disks docs/formatdomain.html.in | 3 ++- src/conf/domain_conf.c | 33 +++++++++++++++++++++++++++++++++ src/conf/domain_conf.h | 3 +++ src/libvirt_private.syms | 1 + src/qemu/qemu_process.c | 3 +++ 5 files changed, 42 insertions(+), 1 deletion(-) -- 2.2.2

2 4

[libvirt] [PATCH v2 0/9] Implement Add/Del IOThreads
by John Ferlan 14 Apr '15

14 Apr '15

v1: http://www.redhat.com/archives/libvir-list/2015-March/msg01014.html v2 is mostly a completely rewrite of v1 - only smart parts were kept, mostly the "concepts" behind adding/removing a thread Patches 1&2: Couple of simple mods - mostly innocuous Patches 3-5 Since it was determined that just setting the IOThread count and keeping sequential IOThread ID's may not be a desired means to add/remove threads, I decided upon a mechanism which to a degree follows the tune/pin mechanism. Rework the existing IOThread logic to make use of a new domain XML element <iothreadids> which will list each of the <iothread>'s with attributes "id" (required) and "name" (optional). The "id" allows one to generate their own ID number/naming mechanism. If <iothreadids> is not found in the XML, then internally will generate the data structures that support it - IOThreadID's. Work the IOThreadID logic into the "live" iothreadpid lists (or now arrays) to manage the live IOThread data Patches 6-7 Add the API/plumbing for two new API's - virDomainAddIOThread and virDomainDelIOThread to complement the existing virDomainPinIOThread. The "Add" API will take two parameters - an iothread_id and an optional "name". The "Del" API will take just one parameter - the iothread_id Patch 8-9 Implement the qemu backend and virsh front end to manage IOThreads either live or just the config file. I did leave some // comments in Patch 8 as a way to ask a reviewer their thoughts in the add live error path whether 'extra' cleanup should be done or just ignored. Those would be cleaned up and removed for the final version. John Ferlan (9): Rename qemuCheckIothreads to qemuCheckIOThreads Convert virDomainPinIsDuplicate into bool return conf: Add new domain XML element 'iothreadids' qemu: Convert iothreadpids into an array of structures qemu: Use domain iothreadids to populate iothreadpids Implement virDomainAddIOThread and virDomainDelIOThread remote: Add support for AddIOThread and DelIOThread qemu: Add support to Add/Delete IOThreads virsh: Add iothreadadd and iothreaddel commands docs/formatdomain.html.in | 28 ++ docs/schemas/domaincommon.rng | 17 + include/libvirt/libvirt-domain.h | 7 + src/conf/domain_audit.c | 9 + src/conf/domain_audit.h | 6 + src/conf/domain_conf.c | 253 ++++++++++- src/conf/domain_conf.h | 29 +- src/driver-hypervisor.h | 13 + src/libvirt-domain.c | 132 ++++++ src/libvirt_private.syms | 7 + src/libvirt_public.syms | 6 + src/qemu/qemu_cgroup.c | 16 +- src/qemu/qemu_command.c | 108 ++++- src/qemu/qemu_command.h | 4 + src/qemu/qemu_domain.c | 55 ++- src/qemu/qemu_domain.h | 12 +- src/qemu/qemu_driver.c | 467 ++++++++++++++++++++- src/qemu/qemu_process.c | 32 +- src/remote/remote_driver.c | 2 + src/remote/remote_protocol.x | 31 +- src/remote_protocol-structs | 13 + .../qemuxml2argv-iothreads-ids-partial.args | 10 + .../qemuxml2argv-iothreads-ids-partial.xml | 33 ++ .../qemuxml2argv-iothreads-ids.args | 8 + .../qemuxml2argv-iothreads-ids.xml | 33 ++ .../qemuxml2argv-iothreads-name.args | 17 + .../qemuxml2argv-iothreads-name.xml | 44 ++ tests/qemuxml2argvtest.c | 4 + tests/qemuxml2xmltest.c | 3 + tools/virsh-domain.c | 174 ++++++++ tools/virsh.pod | 32 ++ 31 files changed, 1546 insertions(+), 59 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-ids-partial.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-ids-partial.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-ids.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-ids.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-name.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-name.xml -- 2.1.0

2 20

[libvirt] [python PATCH] Implement the DEVICE_ADDED event
by Ján Tomko 13 Apr '15

13 Apr '15

--- examples/event-test.py | 4 +++ libvirt-override-virConnect.py | 9 +++++++ libvirt-override.c | 57 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 70 insertions(+) diff --git a/examples/event-test.py b/examples/event-test.py index 452f659..2c6ce7b 100755 --- a/examples/event-test.py +++ b/examples/event-test.py @@ -527,6 +527,9 @@ def myDomainEventTunableCallback(conn, dom, params, opaque): print("myDomainEventTunableCallback: Domain %s(%s) %s" % (dom.name(), dom.ID(), params)) def myDomainEventAgentLifecycleCallback(conn, dom, state, reason, opaque): print("myDomainEventAgentLifecycleCallback: Domain %s(%s) %s %s" % (dom.name(), dom.ID(), agentLifecycleStateToString(state), agentLifecycleReasonToString(reason))) +def myDomainEventDeviceAddedCallback(conn, dom, dev, opaque): + print("myDomainEventDeviceAddedCallback: Domain %s(%s) device added: %s" % ( + dom.name(), dom.ID(), dev)) ########################################################################## # Network events @@ -638,6 +641,7 @@ def main(): vc.domainEventRegisterAny(None, libvirt.VIR_DOMAIN_EVENT_ID_BLOCK_JOB_2, myDomainEventBlockJob2Callback, None) vc.domainEventRegisterAny(None, libvirt.VIR_DOMAIN_EVENT_ID_TUNABLE, myDomainEventTunableCallback, None) vc.domainEventRegisterAny(None, libvirt.VIR_DOMAIN_EVENT_ID_AGENT_LIFECYCLE, myDomainEventAgentLifecycleCallback, None) + vc.domainEventRegisterAny(None, libvirt.VIR_DOMAIN_EVENT_ID_DEVICE_ADDED, myDomainEventDeviceAddedCallback, None) vc.networkEventRegisterAny(None, libvirt.VIR_NETWORK_EVENT_ID_LIFECYCLE, myNetworkEventLifecycleCallback, None) diff --git a/libvirt-override-virConnect.py b/libvirt-override-virConnect.py index 88c864c..821be87 100644 --- a/libvirt-override-virConnect.py +++ b/libvirt-override-virConnect.py @@ -207,6 +207,15 @@ cb(self, virDomain(self, _obj=dom), state, reason, opaque) return 0 + def _dispatchDomainEventDeviceAddedCallback(self, dom, devAlias, cbData): + """Dispatches event to python user domain device added event callbacks + """ + cb = cbData["cb"] + opaque = cbData["opaque"] + + cb(self, virDomain(self, _obj=dom), devAlias, opaque) + return 0 + def domainEventDeregisterAny(self, callbackID): """Removes a Domain Event Callback. De-registering for a domain callback will disable delivery of this event type """ diff --git a/libvirt-override.c b/libvirt-override.c index f770ffe..588dac1 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -6901,6 +6901,58 @@ libvirt_virConnectDomainEventAgentLifecycleCallback(virConnectPtr conn ATTRIBUTE } #endif /* VIR_DOMAIN_EVENT_ID_AGENT_LIFECYCLE */ +#ifdef VIR_DOMAIN_EVENT_ID_DEVICE_ADDED +static int +libvirt_virConnectDomainEventDeviceAddedCallback(virConnectPtr conn ATTRIBUTE_UNUSED, + virDomainPtr dom, + const char *devAlias, + void *opaque) +{ + PyObject *pyobj_cbData = (PyObject*)opaque; + PyObject *pyobj_dom; + PyObject *pyobj_ret = NULL; + PyObject *pyobj_conn; + PyObject *dictKey; + int ret = -1; + + LIBVIRT_ENSURE_THREAD_STATE; + + if (!(dictKey = libvirt_constcharPtrWrap("conn"))) + goto cleanup; + pyobj_conn = PyDict_GetItem(pyobj_cbData, dictKey); + Py_DECREF(dictKey); + + /* Create a python instance of this virDomainPtr */ + virDomainRef(dom); + if (!(pyobj_dom = libvirt_virDomainPtrWrap(dom))) { + virDomainFree(dom); + goto cleanup; + } + Py_INCREF(pyobj_cbData); + + /* Call the Callback Dispatcher */ + pyobj_ret = PyObject_CallMethod(pyobj_conn, + (char*)"_dispatchDomainEventDeviceAddedCallback", + (char*)"OsO", + pyobj_dom, devAlias, pyobj_cbData); + + Py_DECREF(pyobj_cbData); + Py_DECREF(pyobj_dom); + + cleanup: + if (!pyobj_ret) { + DEBUG("%s - ret:%p\n", __FUNCTION__, pyobj_ret); + PyErr_Print(); + } else { + Py_DECREF(pyobj_ret); + ret = 0; + } + + LIBVIRT_RELEASE_THREAD_STATE; + return ret; + +} +#endif /* VIR_DOMAIN_EVENT_ID_DEVICE_ADDED */ static PyObject * libvirt_virConnectDomainEventRegisterAny(ATTRIBUTE_UNUSED PyObject *self, @@ -6999,6 +7051,11 @@ libvirt_virConnectDomainEventRegisterAny(ATTRIBUTE_UNUSED PyObject *self, cb = VIR_DOMAIN_EVENT_CALLBACK(libvirt_virConnectDomainEventAgentLifecycleCallback); break; #endif /* VIR_DOMAIN_EVENT_ID_AGENT_LIFECYCLE */ +#ifdef VIR_DOMAIN_EVENT_ID_DEVICE_ADDED + case VIR_DOMAIN_EVENT_ID_DEVICE_ADDED: + cb = VIR_DOMAIN_EVENT_CALLBACK(libvirt_virConnectDomainEventDeviceAddedCallback); + break; +#endif /* VIR_DOMAIN_EVENT_ID_DEVICE_ADDED */ case VIR_DOMAIN_EVENT_ID_LAST: break; } -- 2.0.5

2 1

[libvirt] [PATCH] configure: Check for libxl_utils.h instead of libxlutil.h
by Michal Privoznik 13 Apr '15

13 Apr '15

The file provided by xen-devel package (or xen-tools in Gentoo) does not provide libxlutil.h. In fact the package provides libxl_utils.h instead which is the one we are looking for anyway. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 38fbbad..0626492 100644 --- a/configure.ac +++ b/configure.ac @@ -915,7 +915,7 @@ fi if test "$with_libxl" = "yes"; then dnl If building with libxl, use the libxl utility header and lib too - AC_CHECK_HEADERS([libxlutil.h]) + AC_CHECK_HEADERS([libxl_utils.h]) LIBXL_LIBS="$LIBXL_LIBS -lxlutil" AC_DEFINE_UNQUOTED([WITH_LIBXL], 1, [whether libxenlight driver is enabled]) if test "x$LIBXL_FIRMWARE_DIR" != "x"; then -- 2.0.5

3 2

[libvirt] [PATCH] Introduce virnetdevtest
by Michal Privoznik 13 Apr '15

13 Apr '15

This is yet another test for check of basic functionality of our NIC state handling code. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/libvirt_private.syms | 1 + src/util/virnetdev.c | 4 +- src/util/virnetdev.h | 4 ++ tests/Makefile.am | 15 +++++ tests/virnetdevmock.c | 48 ++++++++++++++ tests/virnetdevtest.c | 94 +++++++++++++++++++++++++++ tests/virnetdevtestdata/eth0-broken/operstate | 1 + tests/virnetdevtestdata/eth0-broken/speed | 1 + tests/virnetdevtestdata/eth0/operstate | 1 + tests/virnetdevtestdata/eth0/speed | 1 + tests/virnetdevtestdata/lo/operstate | 1 + tests/virnetdevtestdata/lo/speed | 1 + 12 files changed, 170 insertions(+), 2 deletions(-) create mode 100644 tests/virnetdevmock.c create mode 100644 tests/virnetdevtest.c create mode 100644 tests/virnetdevtestdata/eth0-broken/operstate create mode 100644 tests/virnetdevtestdata/eth0-broken/speed create mode 100644 tests/virnetdevtestdata/eth0/operstate create mode 100644 tests/virnetdevtestdata/eth0/speed create mode 100644 tests/virnetdevtestdata/lo/operstate create mode 100644 tests/virnetdevtestdata/lo/speed diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 9f82926..0b42238 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1741,6 +1741,7 @@ virNetDevSetPromiscuous; virNetDevSetRcvAllMulti; virNetDevSetRcvMulti; virNetDevSetupControl; +virNetDevSysfsFile; virNetDevValidateConfig; diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 54d866e..a2d55a8 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -1519,9 +1519,9 @@ int virNetDevValidateConfig(const char *ifname ATTRIBUTE_UNUSED, #ifdef __linux__ # define NET_SYSFS "/sys/class/net/" -static int +int virNetDevSysfsFile(char **pf_sysfs_device_link, const char *ifname, - const char *file) + const char *file) { if (virAsprintf(pf_sysfs_device_link, NET_SYSFS "%s/%s", ifname, file) < 0) diff --git a/src/util/virnetdev.h b/src/util/virnetdev.h index 856127b..999a89a 100644 --- a/src/util/virnetdev.h +++ b/src/util/virnetdev.h @@ -219,4 +219,8 @@ int virNetDevSetRcvAllMulti(const char *ifname, bool receive) ATTRIBUTE_NONNULL(1) ATTRIBUTE_RETURN_CHECK; int virNetDevGetRcvAllMulti(const char *ifname, bool *receive) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_RETURN_CHECK; +int virNetDevSysfsFile(char **pf_sysfs_device_link, + const char *ifname, + const char *file) + ATTRIBUTE_NONNULL(1); #endif /* __VIR_NETDEV_H__ */ diff --git a/tests/Makefile.am b/tests/Makefile.am index 046cd08..9ebedc3 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -176,6 +176,7 @@ test_programs = virshtest sockettest \ domainconftest \ virhostdevtest \ vircaps2xmltest \ + virnetdevtest \ $(NULL) if WITH_REMOTE @@ -402,6 +403,7 @@ test_libraries = libshunload.la \ virnetserverclientmock.la \ vircgroupmock.la \ virpcimock.la \ + virnetdevmock.la \ $(NULL) if WITH_QEMU test_libraries += libqemumonitortestutils.la \ @@ -1029,6 +1031,19 @@ virpcimock_la_LIBADD = $(GNULIB_LIBS) \ virpcimock_la_LDFLAGS = -module -avoid-version \ -rpath /evil/libtool/hack/to/force/shared/lib/creation +virnetdevtest_SOURCES = \ + virnetdevtest.c testutils.h testutils.c +virnetdevtest_CFLAGS = $(AM_CFLAGS) $(LIBNL_CFLAGS) +virnetdevtest_LDADD = $(LDADDS) + +virnetdevmock_la_SOURCES = \ + virnetdevmock.c +virnetdevmock_la_CFLAGS = $(AM_CFLAGS) $(LIBNL_CFLAGS) +virnetdevmock_la_LIBADD = $(GNULIB_LIBS) \ + ../src/libvirt.la +virnetdevmock_la_LDFLAGS = -module -avoid-version \ + -rpath /evil/libtool/hack/to/force/shared/lib/creation + if WITH_LINUX virusbtest_SOURCES = \ virusbtest.c testutils.h testutils.c diff --git a/tests/virnetdevmock.c b/tests/virnetdevmock.c new file mode 100644 index 0000000..681e5fe --- /dev/null +++ b/tests/virnetdevmock.c @@ -0,0 +1,48 @@ +/* + * Copyright (C) 2013 Red Hat, Inc. + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + * Author: Michal Privoznik <mprivozn(a)redhat.com> + */ + +#include <config.h> + +#ifdef __linux__ +# include "internal.h" +# include <stdlib.h> +# include <stdio.h> +# include "virstring.h" +# include "virnetdev.h" + +# define NET_DEV_TEST_DATA_PREFIX abs_srcdir "/virnetdevtestdata" + +int +virNetDevSysfsFile(char **pf_sysfs_device_link, + const char *ifname, + const char *file) +{ + + if (virAsprintfQuiet(pf_sysfs_device_link, "%s/%s/%s", + NET_DEV_TEST_DATA_PREFIX, ifname, file) < 0) { + fprintf(stderr, "Out of memory\n"); + abort(); + } + + return 0; +} +#else +/* Nothing to override on non-__linux__ platforms */ +#endif diff --git a/tests/virnetdevtest.c b/tests/virnetdevtest.c new file mode 100644 index 0000000..8795bf1 --- /dev/null +++ b/tests/virnetdevtest.c @@ -0,0 +1,94 @@ +/* + * Copyright (C) 2014 Red Hat, Inc. + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + * Author: Michal Privoznik <mprivozn(a)redhat.com> + */ + +#include <config.h> + +#include "testutils.h" + +#ifdef __linux__ + +# include "virnetdev.h" + +# define VIR_FROM_THIS VIR_FROM_NONE + +struct testVirNetDevGetLinkInfoData { + const char *ifname; /* ifname to get info on */ + virInterfaceState state; /* expected state */ + unsigned int speed; /* expected speed */ +}; + +static int +testVirNetDevGetLinkInfo(const void *opaque) +{ + int ret = -1; + const struct testVirNetDevGetLinkInfoData *data = opaque; + virInterfaceLink lnk; + + if (virNetDevGetLinkInfo(data->ifname, &lnk) < 0) + goto cleanup; + + if (lnk.state != data->state) { + fprintf(stderr, + "Fetched link state (%s) doesn't match the expected one (%s)", + virInterfaceStateTypeToString(lnk.state), + virInterfaceStateTypeToString(data->state)); + goto cleanup; + } + + if (lnk.speed != data->speed) { + fprintf(stderr, + "Fetched link speed (%u) doesn't match the expected one (%u)", + lnk.speed, data->speed); + goto cleanup; + } + + ret = 0; + cleanup: + return ret; +} + +static int +mymain(void) +{ + int ret = 0; + +# define DO_TEST_LINK(ifname, state, speed) \ + do { \ + struct testVirNetDevGetLinkInfoData data = {ifname, state, speed}; \ + if (virtTestRun("Link info: " # ifname, \ + testVirNetDevGetLinkInfo, &data) < 0) \ + ret = -1; \ + } while (0) + + DO_TEST_LINK("eth0", VIR_INTERFACE_STATE_UP, 1000); + DO_TEST_LINK("lo", VIR_INTERFACE_STATE_UNKNOWN, 0); + DO_TEST_LINK("eth0-broken", VIR_INTERFACE_STATE_DOWN, 0); + + return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; +} + +VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virnetdevmock.so") +#else +int +main(void) +{ + return EXIT_AM_SKIP; +} +#endif diff --git a/tests/virnetdevtestdata/eth0-broken/operstate b/tests/virnetdevtestdata/eth0-broken/operstate new file mode 100644 index 0000000..eb0e904 --- /dev/null +++ b/tests/virnetdevtestdata/eth0-broken/operstate @@ -0,0 +1 @@ +down diff --git a/tests/virnetdevtestdata/eth0-broken/speed b/tests/virnetdevtestdata/eth0-broken/speed new file mode 100644 index 0000000..4f6ff86 --- /dev/null +++ b/tests/virnetdevtestdata/eth0-broken/speed @@ -0,0 +1 @@ +4294967295 diff --git a/tests/virnetdevtestdata/eth0/operstate b/tests/virnetdevtestdata/eth0/operstate new file mode 100644 index 0000000..e31ee94 --- /dev/null +++ b/tests/virnetdevtestdata/eth0/operstate @@ -0,0 +1 @@ +up diff --git a/tests/virnetdevtestdata/eth0/speed b/tests/virnetdevtestdata/eth0/speed new file mode 100644 index 0000000..83b33d2 --- /dev/null +++ b/tests/virnetdevtestdata/eth0/speed @@ -0,0 +1 @@ +1000 diff --git a/tests/virnetdevtestdata/lo/operstate b/tests/virnetdevtestdata/lo/operstate new file mode 100644 index 0000000..3546645 --- /dev/null +++ b/tests/virnetdevtestdata/lo/operstate @@ -0,0 +1 @@ +unknown diff --git a/tests/virnetdevtestdata/lo/speed b/tests/virnetdevtestdata/lo/speed new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/virnetdevtestdata/lo/speed @@ -0,0 +1 @@ +0 -- 2.0.5

3 2

[libvirt] [PATCH v5 0/3] Parallels disk device attach
by Alexander Burluka 13 Apr '15

13 Apr '15

This patchset implements disk device attachment and allows OpenStack to attach volumes to Parallels-driven instances. Parallels Cloud Server SDK supports live attachment of disk devices and virtual interfaces cards. Alexander Burluka (3): Parallels: remove disk serial number check Parallels: implement domainAttachDeviceFlags Parallels: implemented domainAttachDevice

2 4

[libvirt] [PATCHv1 00/13] Support qcow2 features in external snapshots
by Ján Tomko 13 Apr '15

13 Apr '15

https://bugzilla.redhat.com/show_bug.cgi?id=980327 First ten patches contain no functional change. Patches 11 and 12 potentially change the default qcow2 compatibility level. The last patch contains the proposed XML. Ján Tomko (13): Visually separate snapshot disk subelements Remove feature formating funcs from pool-specific options Separate out virStorageFeatureParse Separate virStorageFeatureFormat Split out storage format 'compat' attribute sanity check Use XPath when parsing snapshot disk definition Rename virStorageBackendCreateQemuImgCmd Introduce struct _virStorageBackendQemuImgInfo Split out qemu-img command generation Remove overengineered loop Use qemu-img to precreate the qcow2 disks Rework qemu-img command generation for inactive external snapshots Add qcow2 features to snapshot XML docs/formatsnapshot.html.in | 50 ++- docs/schemas/domainsnapshot.rng | 10 +- po/POTFILES.in | 1 + src/Makefile.am | 5 + src/conf/snapshot_conf.c | 58 ++-- src/conf/storage_conf.c | 83 +---- src/conf/storage_feature_conf.c | 87 +++++ src/conf/storage_feature_conf.h | 25 ++ src/qemu/qemu_driver.c | 57 ++-- src/storage/storage_backend.c | 376 +++++++++++++-------- src/storage/storage_backend.h | 19 +- src/storage/storage_driver.c | 27 ++ src/storage/storage_driver.h | 4 + src/util/virstoragefile.c | 29 ++ src/util/virstoragefile.h | 1 + .../disk_snapshot_features.xml | 30 ++ .../disk_snapshot_features.xml | 30 ++ tests/domainsnapshotxml2xmltest.c | 2 + tests/storagevolxml2argvtest.c | 5 +- 19 files changed, 589 insertions(+), 310 deletions(-) create mode 100644 src/conf/storage_feature_conf.c create mode 100644 src/conf/storage_feature_conf.h create mode 100644 tests/domainsnapshotxml2xmlin/disk_snapshot_features.xml create mode 100644 tests/domainsnapshotxml2xmlout/disk_snapshot_features.xml -- 2.0.5

2 28

[libvirt] Changing media on network disks (was Re: can't bot from scsi http cdrom)
by Paolo Bonzini 13 Apr '15

13 Apr '15

On 13/04/2015 14:34, Vasiliy Tolstov wrote: > Thanks! This is works fine. Last question - does it possible to create > empty cdrom with type='network'? > I'm try this, but libvrit complains with error: > <disk type='network' device='cdrom'> > <driver name='qemu' type='raw'/> > <target dev='sdb' bus='scsi' tray='open'/> > <address type='drive' controller='0' target='1' bus='0' unit='1'/> > <readonly/> > </disk> No, unfortunately not because "virsh change-media" wouldn't be able to convert its argument to the required libvirt XML. I think you would need a new virsh change-media option, e.g. --xml, that takes a <disk> element instead of a source path + target path pair. However, I am not a libvirt developer. Paolo

1 0

[libvirt] XML Parser failing due to cryptic Serial Number.
by Roz Fx 13 Apr '15

13 Apr '15

I set virt-manager in qemu:///system space and tried to add new VM but it didn't proceed. I figured out its duo to serial numbers is in cryptic form. # cat /sys/devices/virtual/dmi/id/product_serial ÿÿÿÿÿÿÿ #virt-manager --debug Traceback (most recent call last): File "/usr/share/virt-manager/virtManager/libvirtobject.py", line 225, in _reparse_xml self._xmlobj = self._build_xmlobj(self._get_raw_xml()) File "/usr/share/virt-manager/virtManager/libvirtobject.py", line 228, in _build_xmlobj return self._parseclass(self.conn.get_backend(), parsexml=xml) File "/usr/share/virt-manager/virtManager/nodedev.py", line 27, in _parse_convert return NodeDevice.parse(conn, parsexml) File "/usr/share/virt-manager/virtinst/nodedev.py", line 95, in parse tmpdev = NodeDevice(conn, parsexml=xml, allow_node_instantiate=True) File "/usr/share/virt-manager/virtinst/nodedev.py", line 106, in __init__ XMLBuilder.__init__(self, *args, **kwargs) File "/usr/share/virt-manager/virtinst/xmlbuilder.py", line 777, in __init__ parent_xpath, relative_object_xpath) File "/usr/share/virt-manager/virtinst/xmlbuilder.py", line 679, in __init__ self._parse(parsexml, parsexmlnode) File "/usr/share/virt-manager/virtinst/xmlbuilder.py", line 692, in _parse doc = libxml2.parseDoc(xml) File "/usr/lib/python2.7/site-packages/libxml2.py", line 1327, in parseDoc if ret is None:raise parserError('xmlParseDoc() failed') libxml2.parserError: xmlParseDoc() failed [Sun, 12 Apr 2015 06:06:16 virt-manager 4241] DEBUG (create:165) Showing new vm wizard [Sun, 12 Apr 2015 06:06:16 virt-manager 4241] DEBUG (create:892) Guest type set to os_type=hvm, arch=x86_64, dom_type=kvm [Sun, 12 Apr 2015 06:06:16 virt-manager 4241] DEBUG (xmlbuilder:694) Error parsing xml= <device> <name>computer</name> <capability type='system'> <product>Vostro</product> <hardware> <vendor>Dell Inc.</vendor> <version>A10</version> <serial>ÿÿÿÿÿÿÿ</serial> <uuid>REMOVED</uuid> </hardware> <firmware> <vendor>Dell Inc.</vendor> <version>A10</version> <release_date>05/18/2013</release_date> </firmware> </capability> </device> [Sun, 12 Apr 2015 06:06:16 virt-manager 4241] ERROR (create:346) Error setting create wizard conn state. Traceback (most recent call last): File "/usr/share/virt-manager/virtManager/create.py", line 344, in reset_state self.set_conn(activeconn, force_validate=True) File "/usr/share/virt-manager/virtManager/create.py", line 225, in set_conn self.set_conn_state() File "/usr/share/virt-manager/virtManager/create.py", line 626, in set_conn_state self.netlist.reset_state() File "/usr/share/virt-manager/virtManager/netlist.py", line 405, in reset_state self._populate_network_list() File "/usr/share/virt-manager/virtManager/netlist.py", line 253, in _populate_network_list vnet_bridges) File "/usr/share/virt-manager/virtManager/netlist.py", line 185, in _find_physical_devices for nodedev in self.conn.get_nodedevs("net"): File "/usr/share/virt-manager/virtManager/connection.py", line 648, in get_nodedevs xmlobj = dev.get_xmlobj() File "/usr/share/virt-manager/virtManager/libvirtobject.py", line 160, in get_xmlobj self._reparse_xml() File "/usr/share/virt-manager/virtManager/libvirtobject.py", line 225, in _reparse_xml self._xmlobj = self._build_xmlobj(self._get_raw_xml()) File "/usr/share/virt-manager/virtManager/libvirtobject.py", line 228, in _build_xmlobj return self._parseclass(self.conn.get_backend(), parsexml=xml) File "/usr/share/virt-manager/virtManager/nodedev.py", line 27, in _parse_convert return NodeDevice.parse(conn, parsexml) File "/usr/share/virt-manager/virtinst/nodedev.py", line 95, in parse tmpdev = NodeDevice(conn, parsexml=xml, allow_node_instantiate=True) File "/usr/share/virt-manager/virtinst/nodedev.py", line 106, in __init__ XMLBuilder.__init__(self, *args, **kwargs) File "/usr/share/virt-manager/virtinst/xmlbuilder.py", line 777, in __init__ parent_xpath, relative_object_xpath) File "/usr/share/virt-manager/virtinst/xmlbuilder.py", line 679, in __init__ self._parse(parsexml, parsexmlnode) File "/usr/share/virt-manager/virtinst/xmlbuilder.py", line 692, in _parse doc = libxml2.parseDoc(xml) File "/usr/lib/python2.7/site-packages/libxml2.py", line 1327, in parseDoc if ret is None:raise parserError('xmlParseDoc() failed') parserError: xmlParseDoc() failed Regards Roz

1 0

[libvirt] [PATCH 1/2] virBitmap: Place virBitmapIsAllClear check after virBitmapParse calls
by Erik Skultety 13 Apr '15

13 Apr '15

This patch adds checks for empty bitmaps right after the calls of virBitmapParse. These only include spots where set API's are called and where domain's XML is parsed. https://bugzilla.redhat.com/show_bug.cgi?id=1210545 --- src/conf/domain_conf.c | 35 +++++++++++++++++++++++++++++++---- src/conf/numa_conf.c | 23 +++++++++++++++++++---- src/qemu/qemu_driver.c | 5 +++-- src/xenconfig/xen_sxpr.c | 7 +++++++ 4 files changed, 60 insertions(+), 10 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1763305..c9488cf 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11563,6 +11563,12 @@ virDomainMemorySourceDefParseXML(xmlNodePtr node, if (virBitmapParse(nodemask, 0, &def->sourceNodes, VIR_DOMAIN_CPUMASK_LEN) < 0) goto cleanup; + + if (virBitmapIsAllClear(def->sourceNodes)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Invalid value of 'nodemask': %s"), nodemask); + goto cleanup; + } } ret = 0; @@ -13251,6 +13257,13 @@ virDomainVcpuPinDefParseXML(xmlNodePtr node, if (virBitmapParse(tmp, 0, &def->cpumask, VIR_DOMAIN_CPUMASK_LEN) < 0) goto error; + if (virBitmapIsAllClear(def->cpumask)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Invalid value of 'cpuset': %s"), + tmp); + goto error; + } + cleanup: VIR_FREE(tmp); ctxt->node = oldnode; @@ -13352,6 +13365,12 @@ virDomainHugepagesParseXML(xmlNodePtr node, if (virBitmapParse(nodeset, 0, &hugepage->nodemask, VIR_DOMAIN_CPUMASK_LEN) < 0) goto cleanup; + + if (virBitmapIsAllClear(hugepage->nodemask)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Invalid value of 'nodeset': %s"), nodeset); + goto cleanup; + } } ret = 0; @@ -13473,13 +13492,14 @@ virDomainThreadSchedParse(xmlNodePtr node, goto error; } - if (!virBitmapParse(tmp, 0, &sp->ids, - VIR_DOMAIN_CPUMASK_LEN) || - virBitmapIsAllClear(sp->ids) || + if (virBitmapParse(tmp, 0, &sp->ids, VIR_DOMAIN_CPUMASK_LEN) < 0) + goto error; + + if (virBitmapIsAllClear(sp->ids) || virBitmapNextSetBit(sp->ids, -1) < minid || virBitmapLastSetBit(sp->ids) > maxid) { - virReportError(VIR_ERR_XML_ERROR, + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("Invalid value of '%s': %s"), name, tmp); goto error; @@ -13847,6 +13867,13 @@ virDomainDefParseXML(xmlDocPtr xml, if (virBitmapParse(tmp, 0, &def->cpumask, VIR_DOMAIN_CPUMASK_LEN) < 0) goto error; + + if (virBitmapIsAllClear(def->cpumask)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Invalid value of 'cpuset': %s"), tmp); + goto error; + } + VIR_FREE(tmp); } } diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c index 8a0f686..7ad3f66 100644 --- a/src/conf/numa_conf.c +++ b/src/conf/numa_conf.c @@ -178,6 +178,12 @@ virDomainNumatuneNodeParseXML(virDomainNumaPtr numa, if (virBitmapParse(tmp, 0, &mem_node->nodeset, VIR_DOMAIN_CPUMASK_LEN) < 0) goto cleanup; + + if (virBitmapIsAllClear(mem_node->nodeset)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Invalid value of 'nodeset': %s"), tmp); + goto cleanup; + } VIR_FREE(tmp); } @@ -233,10 +239,19 @@ virDomainNumatuneParseXML(virDomainNumaPtr numa, } VIR_FREE(tmp); - if ((tmp = virXMLPropString(node, "nodeset")) && - virBitmapParse(tmp, 0, &nodeset, VIR_DOMAIN_CPUMASK_LEN) < 0) - goto cleanup; - VIR_FREE(tmp); + tmp = virXMLPropString(node, "nodeset"); + if (tmp) { + if (virBitmapParse(tmp, 0, &nodeset, VIR_DOMAIN_CPUMASK_LEN) < 0) + goto cleanup; + + if (virBitmapIsAllClear(nodeset)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Invalid value of 'nodeset': %s"), tmp); + goto cleanup; + } + + VIR_FREE(tmp); + } } if (virDomainNumatuneSet(numa, diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 7eb5a7d..eae2809 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -10106,8 +10106,9 @@ qemuDomainSetNumaParameters(virDomainPtr dom, goto endjob; if (virBitmapIsAllClear(nodeset)) { - virReportError(VIR_ERR_OPERATION_INVALID, "%s", - _("Invalid nodeset for numatune")); + virReportError(VIR_ERR_OPERATION_INVALID, + _("Invalid nodeset of 'numatune': %s"), + param->value.s); goto endjob; } } diff --git a/src/xenconfig/xen_sxpr.c b/src/xenconfig/xen_sxpr.c index 5a170d3..d77abf3 100644 --- a/src/xenconfig/xen_sxpr.c +++ b/src/xenconfig/xen_sxpr.c @@ -1165,6 +1165,13 @@ xenParseSxpr(const struct sexpr *root, if (virBitmapParse(cpus, 0, &def->cpumask, VIR_DOMAIN_CPUMASK_LEN) < 0) goto error; + + if (virBitmapIsAllClear(def->cpumask)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Invalid value of 'cpumask': %s"), + cpus); + goto error; + } } def->maxvcpus = sexpr_int(root, "domain/vcpus"); -- 1.9.3

2 4

[libvirt] [libvirt-glib] Support setting of compat XML node
by Richa Sehgal 13 Apr '15

13 Apr '15

This change adds support for setting of compat XML node in libvirt gconfig storage volumes target --- libvirt-gconfig/libvirt-gconfig-storage-vol-target.c | 13 +++++++++++++ libvirt-gconfig/libvirt-gconfig-storage-vol-target.h | 2 ++ libvirt-gconfig/libvirt-gconfig.sym | 5 +++++ libvirt-gconfig/tests/test-domain-create.c | 1 + 4 files changed, 21 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-storage-vol-target.c b/libvirt-gconfig/libvirt-gconfig-storage-vol-target.c index d3151d1..b72b304 100644 --- a/libvirt-gconfig/libvirt-gconfig-storage-vol-target.c +++ b/libvirt-gconfig/libvirt-gconfig-storage-vol-target.c @@ -99,3 +99,16 @@ void gvir_config_storage_vol_target_set_permissions(GVirConfigStorageVolTarget * "permissions", GVIR_CONFIG_OBJECT(perms)); } + +/** + * gvir_config_storage_vol_target_set_compat: + * @compat: (allow-none): + */ +void gvir_config_storage_vol_target_set_compat(GVirConfigStorageVolTarget *target, + const char *compat) +{ + g_return_if_fail(GVIR_CONFIG_IS_STORAGE_VOL_TARGET(target)); + + gvir_config_object_set_node_content(GVIR_CONFIG_OBJECT(target), + "compat", compat); +} diff --git a/libvirt-gconfig/libvirt-gconfig-storage-vol-target.h b/libvirt-gconfig/libvirt-gconfig-storage-vol-target.h index b572381..c165e2b 100644 --- a/libvirt-gconfig/libvirt-gconfig-storage-vol-target.h +++ b/libvirt-gconfig/libvirt-gconfig-storage-vol-target.h @@ -67,6 +67,8 @@ void gvir_config_storage_vol_target_set_format(GVirConfigStorageVolTarget *targe const char *format); void gvir_config_storage_vol_target_set_permissions(GVirConfigStorageVolTarget *target, GVirConfigStoragePermissions *perms); +void gvir_config_storage_vol_target_set_compat(GVirConfigStorageVolTarget *target, + const char *compat); G_END_DECLS diff --git a/libvirt-gconfig/libvirt-gconfig.sym b/libvirt-gconfig/libvirt-gconfig.sym index 8614126..407a52f 100644 --- a/libvirt-gconfig/libvirt-gconfig.sym +++ b/libvirt-gconfig/libvirt-gconfig.sym @@ -714,4 +714,9 @@ global: gvir_config_domain_cpu_set_model; } LIBVIRT_GCONFIG_0.1.8; +LIBVIRT_GCONFIG_0.2.0 { +global: + gvir_config_storage_vol_target_set_compat; +} LIBVIRT_GCONFIG_0.1.9; + # .... define new API here using predicted next version number .... diff --git a/libvirt-gconfig/tests/test-domain-create.c b/libvirt-gconfig/tests/test-domain-create.c index eb4b945..66f618b 100644 --- a/libvirt-gconfig/tests/test-domain-create.c +++ b/libvirt-gconfig/tests/test-domain-create.c @@ -482,6 +482,7 @@ int main(int argc, char **argv) vol_target = gvir_config_storage_vol_target_new(); gvir_config_storage_vol_target_set_format(vol_target, "qcow2"); gvir_config_storage_vol_target_set_permissions(vol_target, perms); + gvir_config_storage_vol_target_set_compat(vol_target, "1.1"); g_object_unref(G_OBJECT(perms)); gvir_config_storage_vol_set_target(vol, vol_target); g_object_unref(G_OBJECT(vol_target)); -- 1.9.1

2 2

[libvirt] luajit binding
by William Adams 13 Apr '15

13 Apr '15

Hello List, I am new to libvirt, and this is my first query. I have started a luajit language binding for libvirt. It can be found here: https://github.com/Wiladams/LJIT2Virt I searched the interwebs before I began, but didn't find any existing lua language bindings. Is this true? Did I just miss it? If it doesn't exist already, I'd like to make this a regular thing, and get it listed on the language bindings page. How can I go about that? -- William =============================== - Shaping clay is easier than digging it out of the ground.

3 2

[libvirt] [PATCH v2 0/3] Honour sparse files on migration
by Michal Privoznik 13 Apr '15

13 Apr '15

When the storage is pre-created on the destination, it might have been allocated as sparse on the source. Let's keep it that way if we can. diff to v1: - in 3/3 I've reworked the handling of @allocation attribute as John suggested Michal Privoznik (3): qemuMigrationPrecreateStorage: Fix debug message qemuMigrationCookieNBD: Turn some items into their own struct qemuMigrationPrecreateDisk: Preserve sparse files src/qemu/qemu_migration.c | 48 ++++++++++++++++++++++++++++++++++++----------- 1 file changed, 37 insertions(+), 11 deletions(-) -- 2.0.5

2 5

[libvirt] [PATCH] conf: Don't output <cpu> tag if it contains no information.
by Andrea Bolognani 13 Apr '15

13 Apr '15

The tag is already marked as optional in the schema, so no changes are needed there. RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1202606 --- Hi everyone, this is my first contribution to libvirt so I wholeheartedly welcome any criticism, suggestion or recommendation :) Cheers. src/conf/cpu_conf.c | 33 ++++++++++++++++------ tests/qemuxml2argvdata/qemuxml2argv-cpu-empty.xml | 23 +++++++++++++++ .../qemuxml2xmlout-cpu-empty.xml | 21 ++++++++++++++ tests/qemuxml2xmltest.c | 1 + 4 files changed, 69 insertions(+), 9 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-empty.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-cpu-empty.xml diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c index cd3882d..8f65d55 100644 --- a/src/conf/cpu_conf.c +++ b/src/conf/cpu_conf.c @@ -435,13 +435,14 @@ virCPUDefFormatBufFull(virBufferPtr buf, bool updateCPU) { int ret = -1; + virBuffer attributeBuf = VIR_BUFFER_INITIALIZER; virBuffer childrenBuf = VIR_BUFFER_INITIALIZER; int indent = virBufferGetIndent(buf, false); if (!def) return 0; - virBufferAddLit(buf, "<cpu"); + /* Format attributes */ if (def->type == VIR_CPU_TYPE_GUEST) { const char *tmp; @@ -451,7 +452,7 @@ virCPUDefFormatBufFull(virBufferPtr buf, _("Unexpected CPU mode %d"), def->mode); goto cleanup; } - virBufferAsprintf(buf, " mode='%s'", tmp); + virBufferAsprintf(&attributeBuf, " mode='%s'", tmp); } if (def->model && @@ -463,10 +464,11 @@ virCPUDefFormatBufFull(virBufferPtr buf, def->match); goto cleanup; } - virBufferAsprintf(buf, " match='%s'", tmp); + virBufferAsprintf(&attributeBuf, " match='%s'", tmp); } } + /* Format children */ virBufferAdjustIndent(&childrenBuf, indent + 2); if (def->arch) virBufferAsprintf(&childrenBuf, "<arch>%s</arch>\n", @@ -477,16 +479,29 @@ virCPUDefFormatBufFull(virBufferPtr buf, if (virDomainNumaDefCPUFormat(&childrenBuf, numa) < 0) goto cleanup; - if (virBufferUse(&childrenBuf)) { - virBufferAddLit(buf, ">\n"); - virBufferAddBuffer(buf, &childrenBuf); - virBufferAddLit(buf, "</cpu>\n"); - } else { - virBufferAddLit(buf, "/>\n"); + /* Put it all together */ + if (virBufferUse(&attributeBuf) || virBufferUse(&childrenBuf)) { + + /* Opening tag */ + virBufferAddLit(buf, "<cpu"); + + /* Attributes (if any) */ + if (virBufferUse(&attributeBuf)) + virBufferAddBuffer(buf, &attributeBuf); + + /* Children (if any) and closing tag */ + if (virBufferUse(&childrenBuf)) { + virBufferAddLit(buf, ">\n"); + virBufferAddBuffer(buf, &childrenBuf); + virBufferAddLit(buf, "</cpu>\n"); + } else { + virBufferAddLit(buf, "/>\n"); + } } ret = 0; cleanup: + virBufferFreeAndReset(&attributeBuf); virBufferFreeAndReset(&childrenBuf); return ret; } diff --git a/tests/qemuxml2argvdata/qemuxml2argv-cpu-empty.xml b/tests/qemuxml2argvdata/qemuxml2argv-cpu-empty.xml new file mode 100644 index 0000000..2a79826 --- /dev/null +++ b/tests/qemuxml2argvdata/qemuxml2argv-cpu-empty.xml @@ -0,0 +1,23 @@ +<domain type='kvm'> + <name>cpu-empty</name> + <uuid>1aed4c39-ad6e-4a78-9264-4ce996290d17</uuid> + <memory unit='KiB'>4000768</memory> + <currentMemory unit='KiB'>1048576</currentMemory> + <vcpu placement='static'>1</vcpu> + <os> + <type arch='x86_64' machine='pc'>hvm</type> + <boot dev='hd'/> + </os> + <cpu> + </cpu> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <emulator>/usr/bin/qemu-kvm</emulator> + <controller type='usb' index='0'/> + <controller type='pci' index='0' model='pci-root'/> + <memballoon model='virtio'/> + </devices> +</domain> diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-cpu-empty.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-cpu-empty.xml new file mode 100644 index 0000000..e678607 --- /dev/null +++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-cpu-empty.xml @@ -0,0 +1,21 @@ +<domain type='kvm'> + <name>cpu-empty</name> + <uuid>1aed4c39-ad6e-4a78-9264-4ce996290d17</uuid> + <memory unit='KiB'>4000768</memory> + <currentMemory unit='KiB'>1048576</currentMemory> + <vcpu placement='static'>1</vcpu> + <os> + <type arch='x86_64' machine='pc'>hvm</type> + <boot dev='hd'/> + </os> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <emulator>/usr/bin/qemu-kvm</emulator> + <controller type='usb' index='0'/> + <controller type='pci' index='0' model='pci-root'/> + <memballoon model='virtio'/> + </devices> +</domain> diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index 817e408..cd0b280 100644 --- a/tests/qemuxml2xmltest.c +++ b/tests/qemuxml2xmltest.c @@ -361,6 +361,7 @@ mymain(void) DO_TEST("clock-utc"); DO_TEST("clock-localtime"); + DO_TEST_DIFFERENT("cpu-empty"); DO_TEST("cpu-kvmclock"); DO_TEST("cpu-host-kvmclock"); DO_TEST("cpu-host-passthrough-features"); -- 2.1.0

2 2

[libvirt] An implementation bug in qemuMigrationWaitForCompletion that introduces an unnecessary sleep of 50 ms when a migration completes
by Xing Lin 13 Apr '15

13 Apr '15

Hi, It seems that I found a bug in the qemuMigrationWaitForCompletion(). It will do a sleep of 50 ms, even when qemuMigrationUpdateJobStatus() detects that a migration has completed. Here is the original implementation of the while loop. while (jobInfo->type == VIR_DOMAIN_JOB_UNBOUNDED) { /* Poll every 50ms for progress & to allow cancellation */ struct timespec ts = { .tv_sec = 0, .tv_nsec = 50 * 1000 * 1000ull }; if (qemuMigrationUpdateJobStatus(driver, vm, job, asyncJob) == -1) break; /* cancel migration if disk I/O error is emitted while migrating */ if (abort_on_error && virDomainObjGetState(vm, &pauseReason) == VIR_DOMAIN_PAUSED && pauseReason == VIR_DOMAIN_PAUSED_IOERROR) { virReportError(VIR_ERR_OPERATION_FAILED, _("%s: %s"), job, _("failed due to I/O error")); break; } if (dconn && virConnectIsAlive(dconn) <= 0) { virReportError(VIR_ERR_OPERATION_FAILED, "%s", _("Lost connection to destination host")); break; } virObjectUnlock(vm); nanosleep(&ts, NULL); virObjectLock(vm); } Even when qemuMigrationUpdateJobStatus() detects a migration has completed, the nanosleep() will be called again. When the while condition is checked, then the program breaks from the while loop. This introduces an unnecessary sleep of 50 ms which can be avoided by doing a sleep first. The code should likely be structured as following. while (jobInfo->type == VIR_DOMAIN_JOB_UNBOUNDED) { /* Poll every 50ms for progress & to allow cancellation */ struct timespec ts = { .tv_sec = 0, .tv_nsec = 50 * 1000 * 1000ull }; // do sleep here. virObjectUnlock(vm); nanosleep(&ts, NULL); virObjectLock(vm); if (qemuMigrationUpdateJobStatus(driver, vm, job, asyncJob) == -1) break; /* cancel migration if disk I/O error is emitted while migrating */ if (abort_on_error && virDomainObjGetState(vm, &pauseReason) == VIR_DOMAIN_PAUSED && pauseReason == VIR_DOMAIN_PAUSED_IOERROR) { virReportError(VIR_ERR_OPERATION_FAILED, _("%s: %s"), job, _("failed due to I/O error")); break; } if (dconn && virConnectIsAlive(dconn) <= 0) { virReportError(VIR_ERR_OPERATION_FAILED, "%s", _("Lost connection to destination host")); break; } } I have filed a bug report at redhat bugzilla, with a bug id 1210502. The link is below. https://bugzilla.redhat.com/show_bug.cgi?id=1210502 I also prepared a patch for fixing it. It is attached. Any comments?

3 4

[libvirt] [PATCH 0/3] Fix usb device version parsing in redir filters
by Ján Tomko 13 Apr '15

13 Apr '15

https://bugzilla.redhat.com/show_bug.cgi?id=1210650 Ján Tomko (3): Do xml->xml test for usb-redir-filter Fix usb device version parsing issues Rewrite usb device version parsing src/conf/domain_conf.c | 68 +++++++--------------- .../qemuxml2argv-usb-redir-filter-version.args | 19 ++++++ .../qemuxml2argv-usb-redir-filter-version.xml | 46 +++++++++++++++ tests/qemuxml2argvtest.c | 6 ++ .../qemuxml2xmlout-usb-redir-filter-version.xml | 46 +++++++++++++++ .../qemuxml2xmlout-usb-redir-filter.xml | 45 ++++++++++++++ tests/qemuxml2xmltest.c | 2 + 7 files changed, 185 insertions(+), 47 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-redir-filter-version.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-redir-filter-version.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-usb-redir-filter-version.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-usb-redir-filter.xml -- 2.0.5

2 6

[libvirt] [PATCH 0/2] virsh vcpupin cleanups
by Ján Tomko 13 Apr '15

13 Apr '15

Ján Tomko (2): Rewrite vshPrintPinInfo Rewrite vshParseCPUList tools/virsh-domain.c | 153 ++++++++++----------------------------------------- 1 file changed, 29 insertions(+), 124 deletions(-) -- 2.0.5

2 4

[libvirt] [PATCH] Do not require virtio-pci devices when using virtio-mmio
by Ján Tomko 13 Apr '15

13 Apr '15

On arm, we probe for virtio-*-pci devices, but use their virtio-*-device variants. Set the capabilities based on the -device variants as well, to make them work with qemus with the PCI devices compiled out. --- src/qemu/qemu_capabilities.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index ce6767c..3b49271 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -1499,6 +1499,7 @@ struct virQEMUCapsStringFlags virQEMUCapsObjectTypes[] = { { "virtio-scsi-pci", QEMU_CAPS_VIRTIO_SCSI }, { "virtio-scsi-s390", QEMU_CAPS_VIRTIO_SCSI }, { "virtio-scsi-ccw", QEMU_CAPS_VIRTIO_SCSI }, + { "virtio-scsi-device", QEMU_CAPS_VIRTIO_SCSI }, { "megasas", QEMU_CAPS_SCSI_MEGASAS }, { "spicevmc", QEMU_CAPS_DEVICE_SPICEVMC }, { "qxl-vga", QEMU_CAPS_DEVICE_QXL_VGA }, @@ -1515,6 +1516,7 @@ struct virQEMUCapsStringFlags virQEMUCapsObjectTypes[] = { { "virtio-rng-pci", QEMU_CAPS_DEVICE_VIRTIO_RNG }, { "virtio-rng-s390", QEMU_CAPS_DEVICE_VIRTIO_RNG }, { "virtio-rng-ccw", QEMU_CAPS_DEVICE_VIRTIO_RNG }, + { "virtio-rng-device", QEMU_CAPS_DEVICE_VIRTIO_RNG }, { "rng-random", QEMU_CAPS_OBJECT_RNG_RANDOM }, { "rng-egd", QEMU_CAPS_OBJECT_RNG_EGD }, { "spapr-nvram", QEMU_CAPS_DEVICE_NVRAM }, -- 2.0.5

2 1

[libvirt] [libvirt-glib] Support setting of compat XML node
by Richa Sehgal 12 Apr '15

12 Apr '15

This change adds support for setting of compat XML node in libvirt gconfig storage volumes target --- libvirt-gconfig/libvirt-gconfig-storage-vol-target.c | 13 +++++++++++++ libvirt-gconfig/libvirt-gconfig-storage-vol-target.h | 2 ++ libvirt-gconfig/libvirt-gconfig.sym | 5 +++++ libvirt-gconfig/tests/test-domain-create.c | 1 + 4 files changed, 21 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-storage-vol-target.c b/libvirt-gconfig/libvirt-gconfig-storage-vol-target.c index d3151d1..b72b304 100644 --- a/libvirt-gconfig/libvirt-gconfig-storage-vol-target.c +++ b/libvirt-gconfig/libvirt-gconfig-storage-vol-target.c @@ -99,3 +99,16 @@ void gvir_config_storage_vol_target_set_permissions(GVirConfigStorageVolTarget * "permissions", GVIR_CONFIG_OBJECT(perms)); } + +/** + * gvir_config_storage_vol_target_set_compat: + * @compat: (allow-none): + */ +void gvir_config_storage_vol_target_set_compat(GVirConfigStorageVolTarget *target, + const char *compat) +{ + g_return_if_fail(GVIR_CONFIG_IS_STORAGE_VOL_TARGET(target)); + + gvir_config_object_set_node_content(GVIR_CONFIG_OBJECT(target), + "compat", compat); +} diff --git a/libvirt-gconfig/libvirt-gconfig-storage-vol-target.h b/libvirt-gconfig/libvirt-gconfig-storage-vol-target.h index b572381..c165e2b 100644 --- a/libvirt-gconfig/libvirt-gconfig-storage-vol-target.h +++ b/libvirt-gconfig/libvirt-gconfig-storage-vol-target.h @@ -67,6 +67,8 @@ void gvir_config_storage_vol_target_set_format(GVirConfigStorageVolTarget *targe const char *format); void gvir_config_storage_vol_target_set_permissions(GVirConfigStorageVolTarget *target, GVirConfigStoragePermissions *perms); +void gvir_config_storage_vol_target_set_compat(GVirConfigStorageVolTarget *target, + const char *compat); G_END_DECLS diff --git a/libvirt-gconfig/libvirt-gconfig.sym b/libvirt-gconfig/libvirt-gconfig.sym index 8614126..407a52f 100644 --- a/libvirt-gconfig/libvirt-gconfig.sym +++ b/libvirt-gconfig/libvirt-gconfig.sym @@ -714,4 +714,9 @@ global: gvir_config_domain_cpu_set_model; } LIBVIRT_GCONFIG_0.1.8; +LIBVIRT_GCONFIG_0.2.0 { +global: + gvir_config_storage_vol_target_set_compat; +} LIBVIRT_GCONFIG_0.1.9; + # .... define new API here using predicted next version number .... diff --git a/libvirt-gconfig/tests/test-domain-create.c b/libvirt-gconfig/tests/test-domain-create.c index eb4b945..66f618b 100644 --- a/libvirt-gconfig/tests/test-domain-create.c +++ b/libvirt-gconfig/tests/test-domain-create.c @@ -482,6 +482,7 @@ int main(int argc, char **argv) vol_target = gvir_config_storage_vol_target_new(); gvir_config_storage_vol_target_set_format(vol_target, "qcow2"); gvir_config_storage_vol_target_set_permissions(vol_target, perms); + gvir_config_storage_vol_target_set_compat(vol_target, "1.1"); g_object_unref(G_OBJECT(perms)); gvir_config_storage_vol_set_target(vol, vol_target); g_object_unref(G_OBJECT(vol_target)); -- 1.9.1

1 0

[libvirt] [libvirt-glib] Support setting of compat XML node
by Richa Sehgal 12 Apr '15

12 Apr '15

This change adds support for setting of compat XML node in libvirt gconfig storage volumes target --- libvirt-gconfig/libvirt-gconfig-storage-vol-target.c | 13 +++++++++++++ libvirt-gconfig/libvirt-gconfig-storage-vol-target.h | 2 ++ libvirt-gconfig/libvirt-gconfig.sym | 5 +++++ libvirt-gconfig/tests/test-domain-create.c | 1 + 4 files changed, 21 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-storage-vol-target.c b/libvirt-gconfig/libvirt-gconfig-storage-vol-target.c index d3151d1..b72b304 100644 --- a/libvirt-gconfig/libvirt-gconfig-storage-vol-target.c +++ b/libvirt-gconfig/libvirt-gconfig-storage-vol-target.c @@ -99,3 +99,16 @@ void gvir_config_storage_vol_target_set_permissions(GVirConfigStorageVolTarget * "permissions", GVIR_CONFIG_OBJECT(perms)); } + +/** + * gvir_config_storage_vol_target_set_compat: + * @compat: (allow-none): + */ +void gvir_config_storage_vol_target_set_compat(GVirConfigStorageVolTarget *target, + const char *compat) +{ + g_return_if_fail(GVIR_CONFIG_IS_STORAGE_VOL_TARGET(target)); + + gvir_config_object_set_node_content(GVIR_CONFIG_OBJECT(target), + "compat", compat); +} diff --git a/libvirt-gconfig/libvirt-gconfig-storage-vol-target.h b/libvirt-gconfig/libvirt-gconfig-storage-vol-target.h index b572381..c165e2b 100644 --- a/libvirt-gconfig/libvirt-gconfig-storage-vol-target.h +++ b/libvirt-gconfig/libvirt-gconfig-storage-vol-target.h @@ -67,6 +67,8 @@ void gvir_config_storage_vol_target_set_format(GVirConfigStorageVolTarget *targe const char *format); void gvir_config_storage_vol_target_set_permissions(GVirConfigStorageVolTarget *target, GVirConfigStoragePermissions *perms); +void gvir_config_storage_vol_target_set_compat(GVirConfigStorageVolTarget *target, + const char *compat); G_END_DECLS diff --git a/libvirt-gconfig/libvirt-gconfig.sym b/libvirt-gconfig/libvirt-gconfig.sym index 8614126..407a52f 100644 --- a/libvirt-gconfig/libvirt-gconfig.sym +++ b/libvirt-gconfig/libvirt-gconfig.sym @@ -714,4 +714,9 @@ global: gvir_config_domain_cpu_set_model; } LIBVIRT_GCONFIG_0.1.8; +LIBVIRT_GCONFIG_0.2.0 { +global: + gvir_config_storage_vol_target_set_compat; +} LIBVIRT_GCONFIG_0.1.9; + # .... define new API here using predicted next version number .... diff --git a/libvirt-gconfig/tests/test-domain-create.c b/libvirt-gconfig/tests/test-domain-create.c index eb4b945..66f618b 100644 --- a/libvirt-gconfig/tests/test-domain-create.c +++ b/libvirt-gconfig/tests/test-domain-create.c @@ -482,6 +482,7 @@ int main(int argc, char **argv) vol_target = gvir_config_storage_vol_target_new(); gvir_config_storage_vol_target_set_format(vol_target, "qcow2"); gvir_config_storage_vol_target_set_permissions(vol_target, perms); + gvir_config_storage_vol_target_set_compat(vol_target, "1.1"); g_object_unref(G_OBJECT(perms)); gvir_config_storage_vol_set_target(vol, vol_target); g_object_unref(G_OBJECT(vol_target)); -- 1.9.1

1 0

[libvirt] [PATCH] AUTHORS: Add my email address to AUTHORS.in
by Dmitry Guryanov 10 Apr '15

10 Apr '15

--- AUTHORS.in | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS.in b/AUTHORS.in index 6673b3f..7e4359f 100644 --- a/AUTHORS.in +++ b/AUTHORS.in @@ -14,6 +14,7 @@ Claudio Bley <claudio.bley(a)gmail.com> Cole Robinson <crobinso(a)redhat.com> Daniel Berrange <berrange(a)redhat.com> Daniel Veillard <veillard(a)redhat.com> +Dmitry Guryanov <dguryanov(a)parallels.com> Doug Goldstein <cardoe(a)gentoo.org> Eric Blake <eblake(a)redhat.com> Erik Skultety <eskultet(a)redhat.com> -- 2.1.0

1 0

[libvirt] [PATCH v2 0/5] Refactor cgroup and qemuDomainHotplugVcpus
by John Ferlan 10 Apr '15

10 Apr '15

v1 here: http://www.redhat.com/archives/libvir-list/2015-April/msg00126.html John Ferlan (5): cgroup: Introduce virCgroupNewThread cgroup: Use virCgroupNewThread qemu: qemuDomainHotplugVcpus - separate out the add cgroup qemu: qemuDomainHotplugVcpus - separate out the del cgroup and pin qemu: qemuDomainHotplugVcpus - separate out pin adjustment code src/libvirt_private.syms | 4 +- src/qemu/qemu_cgroup.c | 22 +++-- src/qemu/qemu_driver.c | 233 ++++++++++++++++++++++++++++++----------------- src/util/vircgroup.c | 144 +++++++---------------------- src/util/vircgroup.h | 30 +++--- 5 files changed, 208 insertions(+), 225 deletions(-) -- 2.1.0

2 13

Re: [libvirt] [openstack-dev] [nova] The risk of hanging when shutdown instance.
by zhang bo 10 Apr '15

10 Apr '15

On 2015/3/28 18:06, Rui Chen wrote: > Thank you for reply, Chris. > > > 2015-03-27 23:15 GMT+08:00 Chris Friesen <chris.friesen(a)windriver.com <mailto:chris.friesen@windriver.com>>: > > On 03/26/2015 07:44 PM, Rui Chen wrote: > > Yes, you are right, but we found our instance hang at first dom.shutdown() call, > if the dom.shutdown() don't return, there is no chance to execute dom.destroy(), > right? > > > Correct. The code is written assuming dom.shutdown() cannot block indefinitely. > > The libvirt docs at "https://libvirt.org/html/__libvirt-libvirt-domain.html#__virDomainShutdown <https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainShutdown>" say "...this command returns as soon as the shutdown request is issued rather than blocking until the guest is no longer running." > > If dom.shutdown() blocks indefinitely, then that's a libvirt bug. > > > Chris The API virDomainShutdown's description is out of date, it's not correct. In fact, virDomainShutdown would block or not, depending on its mode. If it's in mode *agent*, then it would be blocked until qemu founds that the guest actually got down. Otherwise, if it's in mode *acpi*, then it would return immediately. Thus, maybe further more work need to be done in Openstack. What's your opinions, Michal and Daniel (from libvirt.org) and Chris (from openstack.org) :)

5 5

[libvirt] [PATCH] conf: fix crash when parse a invalid vcpus in virDomainThreadSchedParse()
by Luyao Huang 10 Apr '15

10 Apr '15

When we set a invalid vcpus in /domain/cputune/vcpusched, like this: <vcpusched vcpus='0,^0' scheduler='fifo' priority='1'/> libvirtd will get segfault, because we will free bitmap (here is sp->ids) we passed in virBitmapParse() then return -1, then call virBitmapIsAllClear() with a null pointer bitmap will crash libvirtd. Split this check in two part to report parse error when cannot parse vcpus, and report invalid argument error when the cpu number is not correct. virBitmapIsAllClear (bitmap=0x0) at util/virbitmap.c:649 649 for (i = 0; i < bitmap->map_len; i++) (gdb) bt #0 virBitmapIsAllClear (bitmap=0x0) at util/virbitmap.c:649 #1 0x00007f28322f1245 in virDomainThreadSchedParse at conf/domain_conf.c:13464 #2 0x00007f283238aec8 in virDomainDefParseXML at conf/domain_conf.c:14059 #3 0x00007f2832390ddb in virDomainDefParseNode at conf/domain_conf.c:15588 #4 0x00007f2832390f02 in virDomainDefParse at conf/domain_conf.c:15530 #5 0x00007f2832390f53 in virDomainDefParseString at conf/domain_conf.c:15546 #6 0x00007f2819d8e8de in qemuDomainDefineXMLFlags at qemu/qemu_driver.c:7385 Signed-off-by: Luyao Huang <lhuang(a)redhat.com> --- src/conf/domain_conf.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1763305..46dfea1 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -13473,12 +13473,11 @@ virDomainThreadSchedParse(xmlNodePtr node, goto error; } - if (!virBitmapParse(tmp, 0, &sp->ids, - VIR_DOMAIN_CPUMASK_LEN) || - virBitmapIsAllClear(sp->ids) || - virBitmapNextSetBit(sp->ids, -1) < minid || - virBitmapLastSetBit(sp->ids) > maxid) { + if (virBitmapParse(tmp, 0, &sp->ids, VIR_DOMAIN_CPUMASK_LEN) < 0) + goto error; + if (virBitmapNextSetBit(sp->ids, -1) < minid || + virBitmapLastSetBit(sp->ids) > maxid) { virReportError(VIR_ERR_XML_ERROR, _("Invalid value of '%s': %s"), name, tmp); -- 1.8.3.1

2 2

[libvirt] [PATCH v3 00/14] parallels: implement managed save
by Dmitry Guryanov 10 Apr '15

10 Apr '15

This patch series is intended to implement all needed code, so that suspend/resume in openstack nova will work. It implements .domainHasManagedSaveImage, .domainManagedSave and .domainManagedSaveRemove functions. It's not possible to change VM configuration, if it is in suspended state in PCS. It's possible for containers, but it has different meaning from the same action in libvirt: libvirt stores domain config in a save file and restores it if a user decided to start domain. But if the user discarded state file - domain will have new configuration. PCS doesn't store domain config for containers, so it will have new configuration either if the user will start it from, save file or discard state file and start after that. So the idea is to forbid changing domain configuration, if a domain is in managed saved state. We can't forbid calling this function in this state, because openstack/nova calls virDomainDefineXML in suspended state. So I compare current virDomainDef with the new one. And if there are no changes - function does nothing and returns success. Dmitry Guryanov (14): parallels: fix headers in parallels_sdk.h parallels: split prlsdkDomainChangeState function parallels: implement virDomainManagedSave parallels: report, that cdroms are readonly parallels: add controllers in prlsdkLoadDomain parallels: fill adapter model in virDomainNetDef parallels: don't fill net adapter model for containers conf: add VIR_DOMAIN_VIDEO_TYPE_PARALLELS video type conf: return proper default video type for parallels conf: add input device type for parallels containers parallels: add implicit input devices conf: fix virDomainDefParseXML for parallels conf: fix virDomainDefFormatInternal for parallels parallels: fix virDomainDefineXML for domain in saved state src/conf/domain_conf.c | 70 +++++++++++++++++++--- src/conf/domain_conf.h | 2 + src/parallels/parallels_driver.c | 104 ++++++++++++++++++++++++++++++-- src/parallels/parallels_sdk.c | 124 ++++++++++++++++++++++++++++++++++----- src/parallels/parallels_sdk.h | 17 ++++-- src/qemu/qemu_command.c | 6 +- 6 files changed, 285 insertions(+), 38 deletions(-) -- 2.1.0

2 17

Re: [libvirt] [Qemu-devel] can't bot from scsi http cdrom
by Stefan Hajnoczi 10 Apr '15

10 Apr '15

On Mon, Apr 06, 2015 at 01:15:24PM +0300, Vasiliy Tolstov wrote: > Hi. I'm try to boot from http cdrom and can't do that in case of scsi: > <disk type='network' device='cdrom'> > <driver name='qemu' type='raw' cache='unsafe'/> > <source protocol='http' name='/vps/rescue-4.5.2'> > <host name='xx.xx' port='80'/> > </source> > <backingStore/> > <target dev='sdb' bus='scsi'/> > <readonly/> > <alias name='scsi0-0-0-1'/> > <address type='drive' controller='0' bus='0' target='0' unit='1'/> > </disk> > > but in case of ide: > <disk type='network' device='cdrom'> > <driver name='qemu' type='raw' cache='unsafe'/> > <source protocol='http' name='/vps/rescue-4.5.2'> > <host name='xx.xx' port='80'/> > </source> > <backingStore/> > <target dev='hda' bus='ide'/> > <readonly/> > <alias name='ide0-0-0'/> > <address type='drive' controller='0' bus='0' target='0' unit='0'/> > </disk> > > all works fine. > > libvirt - 1.2.10 > qemu - 2.0.0 > seabios - 1.7.5 This is a libvirt question. I have CCed the libvirt mailing list. Stefan

1 0

[libvirt] possible bug regarding cpu flag 'pclmulqdq' in cpu_map.xml
by Sven Kieske 10 Apr '15

10 Apr '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, laine on IRC was so kind to redirect me to this list, so I didn't file a BZ at: https://bugzilla.redhat.com/enter_bug.cgi?product=Virtualization%20Tools &component=libvirt yet. Please keep me CC'ed as I'm not subscribed to the list. So here is my bug report: Description of problem: I believe the flag "pclmulqdq" is wrongly spelled in cpu_map.xml leading to wrong cpu being detected: Version-Release number of selected component (if applicable): current master: https://libvirt.org/git/?p=libvirt.git;a=blob;f=src/cpu/cpu_map.xml;h=21 10c0b9b2a2a70f0334b2ff63416bd1b704b669;hb=HEAD How reproducible: always Steps to Reproduce: 1.install e.g. ovirt, or some other libvirt consumer on a system with a cpu like intel xeon E3-1230 2. it will get reported as nehalem 3. Actual results: cpu gets reported as "nehalem" Expected results: cpu gets reported as "sandy bridge" Additional info: I found no real info on this flag: grep --color pclmuldq /usr/share/libvirt/cpu_map.xml <feature name='pclmuldq'> <feature name='pclmuldq'/> <feature name='pclmuldq'/> wikipedia (not always right, I know) and Intel just seem to know the flag 'pclmulqdq' See: https://en.wikipedia.org/wiki/CLMUL_instruction_set https://en.wikipedia.org/wiki/CPUID#EAX.3D1:_Processor_Info_and_Feature_ Bits https://software.intel.com/file/36945 But the Intel documentation is vast and I might have missed information on their website. So please check if this is the correct cpu flag indeed. Thanks! PS: If this is a real bug, it goes way back into el6 released versions of libvirt, and I would like to see a backport, if possible! Here is the BZ which introduced the flag: https://bugzilla.redhat.com/show_bug.cgi?id=761005 I guess this got wrongly typed, when you look at this comment, which has the correct notation: https://bugzilla.redhat.com/show_bug.cgi?id=761005#c16 - -- Mit freundlichen Grüßen / Regards Sven Kieske Systemadministrator Mittwald CM Service GmbH & Co. KG Königsberger Straße 6 32339 Espelkamp T: +49-5772-293-100 F: +49-5772-293-333 https://www.mittwald.de Geschäftsführer: Robert Meyer St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhaus en Komplementärin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJVJpqoAAoJEMby9TMDAbQRFlcP/1xajVdbv3fNfQPzJ3wIRa6M szkdbqMkI7HZTBjGvgSFXcf/ufb2RNfCU7AXpMi+FsE+oMB6qafke/J5VM6H/GUW TWuOy1wXz6QLxkP/p0VeU6ZX28XmwPOUMPcCQVhexIAbrmpgYCY42iaiEZUStcNp QQIqapOR6kL57WazTjY0U5GlGkV479oYlStF3E4maaJz+viNUqD6pE3WhXTbpcsu 1U1hPYANkfaMiXglm4MqpLklHw2PqgSfRvPzH58JStByuizPiWXZ9h42xE5ykVkW B7sw4XBSVk0mH99LNwnXC/VIw4pPz7uecTSbxdubZ/p4vvlG8JdszOekMfZVhy1+ ic93VPB+jSbiRGjWx8jkyYAsVOREaPBbmFF3ioLkAo9eVl8v8MXcBNppQQASVv7R vidSBu4qAVeu3ghmY5L+zEqTT3cG8pDcqzrFcELOtY1b6qsOOksgUxiylFv25g6F QPoDZpkpTvJ8YjOZx4H3ZjlfPQBhvBqd3QESNR8fKBUcxgxfGRwBVVU+14otvElE buEhBux0DvEfYrLbbiJtlGFtBmuz28RToPM1bmj52ujnGS1+0xYYYrHL35GhwnPc pvJ8mxAIRMYTdhn5eMsIh50N3uxz9Zky0CU8DJZ5St2Fsds3n7fR7Oao+PXOsOX1 mtJPsI1bYnxJ4RYVaIzk =ergB -----END PGP SIGNATURE-----

2 2

[libvirt] [PATCH] doc: Add info (where necessary) that paths should be specified as absolute
by Erik Skultety 09 Apr '15

09 Apr '15

We documented this almost everywhere, but missed it on several places. https://bugzilla.redhat.com/show_bug.cgi?id=1208763 --- Hopefully I didn't miss any place where it should be fixed as well. I also thought about adding a check for this issue in the code, but we probably do not want to do that during parsing, as the existing domains might as well disappear. The other thing is, that if the path is invalid, "No such file or directory" is returned which in my opinion describes the problem quite well. docs/formatdomain.html.in | 35 +++++++++++++++++++---------------- docs/formatstorage.html.in | 7 ++++--- 2 files changed, 23 insertions(+), 19 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 1b496c3..7ceb1fa 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -126,7 +126,8 @@ provides details on allowed values for these. <span class="since">Since 0.0.1</span></dd> <dt><code>loader</code></dt> - <dd>The optional <code>loader</code> tag refers to a firmware blob + <dd>The optional <code>loader</code> tag refers to a firmware blob, + which is specified by absolute path, used to assist the domain creation process. It is used by Xen fully virtualized domains as well as setting the QEMU BIOS file path for QEMU/KVM domains. <span class="since">Xen since 0.1.0, @@ -142,10 +143,10 @@ <code>pflash</code>.</dd> <dt><code>nvram</code></dt> <dd>Some UEFI firmwares may want to use a non-volatile memory to store - some variables. In the host, this is represented as a file and the path - to the file is stored in this element. Moreover, when the domain is - started up libvirt copies so called master NVRAM store file defined - in <code>qemu.conf</code>. If needed, the <code>template</code> + some variables. In the host, this is represented as a file and the + absolute path to the file is stored in this element. Moreover, when the + domain is started up libvirt copies so called master NVRAM store file + defined in <code>qemu.conf</code>. If needed, the <code>template</code> attribute can be used to per domain override map of master NVRAM stores from the config file. Note, that for transient domains if the NVRAM file has been created by libvirt it is left behind and it is management @@ -971,7 +972,7 @@ resource partitions, potentially with nesting of said partitions. The <code>resource</code> element groups together configuration related to resource partitioning. It currently supports a child - element <code>partition</code> whose content defines the path + element <code>partition</code> whose content defines the absolute path of the resource partition in which to place the domain. If no partition is listed, then the domain will be placed in a default partition. It is the responsibility of the app/admin to ensure @@ -1954,8 +1955,8 @@ <dt><code>type='block'</code> <span class="since">since 0.0.3</span></dt> <dd> - The <code>dev</code> attribute specifies the path to the - host device to serve as the disk. + The <code>dev</code> attribute specifies the fully-qualified path + to the host device to serve as the disk. </dd> <dt><code>type='dir'</code> <span class="since">since 0.7.5</span></dt> @@ -3226,7 +3227,7 @@ versions of qemu used a default of "off", while newer qemus have a default of "on"). <span class="since">Since 0.9.7 (QEMU and KVM only)</span>. The optional - <code>file</code> attribute is used to point to a binary file + <code>file</code> attribute contains an absolute path to a binary file to be presented to the guest as the device's ROM BIOS. This can be useful, for example, to provide a PXE boot ROM for a virtual function of an sr-iov capable ethernet device (which @@ -3285,7 +3286,8 @@ <p> Block / character devices from the host can be passed through to the guest using the <code>hostdev</code> element. This is - only possible with container based virtualization. + only possible with container based virtualization. Devices are specified + by a fully qualified path. <span class="since">since after 1.0.1 for LXC</span>: </p> @@ -5486,11 +5488,12 @@ qemu-kvm -net nic,model=? /dev/null <dl> <dt><code>master</code></dt> - <dd>Master device of the pair, that is passed to the hypervisor.</dd> + <dd>Master device of the pair, that is passed to the hypervisor. + Device is specified by a fully qualified path.</dd> <dt><code>slave</code></dt> <dd>Slave device of the pair, that is passed to the clients for connection - to the guest console.</dd> + to the guest console. Device is specified by a fully qualified path.</dd> </dl> <h4><a name="elementsSound">Sound devices</a></h4> @@ -5834,8 +5837,8 @@ qemu-kvm -net nic,model=? /dev/null <p> This backend type requires exclusive access to a TPM device on the host. - An example for such a device is /dev/tpm0. The filename is - specified as path attribute of the <code>source</code> element. + An example for such a device is /dev/tpm0. The fully qualified file + name is specified by path attribute of the <code>source</code> element. If no file name is specified then /dev/tpm0 is automatically used. </p> </dd> @@ -5941,8 +5944,8 @@ qemu-kvm -net nic,model=? /dev/null <dd> The optional <code>server</code> element can be used to configure a server socket the device is supposed to connect to. The optional - <code>path</code> attribute specifies the path to the unix socket and - defaults to <code>/var/lib/libvirt/shmem/$shmem-$name-sock</code>. + <code>path</code> attribute specifies the absolute path to the unix socket + and defaults to <code>/var/lib/libvirt/shmem/$shmem-$name-sock</code>. </dd> <dt><code>msi</code></dt> <dd> diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in index 9c7b1bd..479e73c 100644 --- a/docs/formatstorage.html.in +++ b/docs/formatstorage.html.in @@ -379,9 +379,10 @@ <dl> <dt><code>path</code></dt> <dd>Provides the location at which the pool will be mapped into - the local filesystem namespace. For a filesystem/directory based - pool it will be the name of the directory in which volumes will - be created. For device based pools it will be the name of the directory in which + the local filesystem namespace, as an absolute path. For a + filesystem/directory based pool it will be a fully qualified name of + the directory in which volumes will be created. For device based pools + it will be a fully qualified name of the directory in which devices nodes exist. For the latter <code>/dev/</code> may seem like the logical choice, however, devices nodes there are not guaranteed stable across reboots, since they are allocated on -- 1.9.3

2 2

[libvirt] [PATCH 00/11] qemu: Refactor the block job code
by Peter Krempa 09 Apr '15

09 Apr '15

At the expense of adding 113 lines of code, kill the ugly qemuBlockJobImpl method and spread it's guts into separate functions. This series additionally fixes a issue with failed drive pivot and the abort function now returns errors if the returned event contained failure. Peter Krempa (11): qemu: monitor: Extract handling of JSON block job error codes qemu: domain: Introduce helper to retrieve domain monitor object qemu: domain: Add helper to check block job support qemu: blockjob: Use the new helpers in qemuDomainGetBlockJobInfo qemu: blockjob: Split qemuDomainBlockJobSetSpeed from qemuDomainBlockJobImpl qemu: Clean up old leftovers in qemuMonitorDrivePivot qemu: blockPivot: Don't pause the VM any more since we don't use drive-reopen qemu: blockjob: Separate qemuDomainBlockJobAbort from qemuDomainBlockJobImpl qemu: blockPull: Refactor the rest of qemuDomainBlockJobImpl qemu: drivePivot: Fix assumption when 'block-job-complete' fails qemu: Refactor qemuDomainBlockJobAbort() src/qemu/qemu_domain.c | 43 +++++ src/qemu/qemu_domain.h | 4 + src/qemu/qemu_driver.c | 437 +++++++++++++++++++++---------------------- src/qemu/qemu_migration.c | 8 +- src/qemu/qemu_monitor.c | 88 ++++++--- src/qemu/qemu_monitor.h | 35 ++-- src/qemu/qemu_monitor_json.c | 188 +++++++++++-------- src/qemu/qemu_monitor_json.h | 28 ++- tests/qemumonitorjsontest.c | 2 +- 9 files changed, 473 insertions(+), 360 deletions(-) -- 2.2.2

3 32

[libvirt] [PATCH] qemu: Avoid shadow of 'sync' symbol
by Peter Krempa 09 Apr '15

09 Apr '15

Old compilers whine that 'sync' is being shadowed in the function introduced in 1eccac1d2da7bbe97e1df25fd0ddac6e71b0794a. --- Pushed under the build-breaker rule. src/qemu/qemu_domain.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index c18b864..ae632c5 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -3063,17 +3063,17 @@ qemuDomainSupportsBlockJobs(virDomainObjPtr vm, bool *modern) { qemuDomainObjPrivatePtr priv = vm->privateData; - bool async = virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKJOB_ASYNC); - bool sync = virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKJOB_SYNC); + bool asynchronous = virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKJOB_ASYNC); + bool synchronous = virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKJOB_SYNC); - if (!sync && !async) { + if (!synchronous && !asynchronous) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("block jobs not supported with this QEMU binary")); return -1; } if (modern) - *modern = async; + *modern = asynchronous; return 0; } -- 2.2.2

1 0

[libvirt] [PATCHv2.5 00/10] Add support for memory hotplug
by Peter Krempa 09 Apr '15

09 Apr '15

Rebased version after changes to the prequel series. This applies on top of http://www.redhat.com/archives/libvir-list/2015-March/msg00134.html Convenience branch to pull from: git fetch git://pipo.sk/pipo/libvirt.git memory-hotplug-2.5 Peter Krempa (10): conf: Add support for parsing and formatting max memory and slot count qemu: Implement setup of memory hotplug parameters conf: Add device address type for dimm devices conf: Add interface to parse and format memory device information qemu: memdev: Add infrastructure to load memory device information qemu: migration: Forbid migration with memory modules lacking info qemu: add support for memory devices qemu: conf: Add support for memory device cold(un)plug qemu: Implement memory device hotplug qemu: Implement memory device hotunplug docs/formatdomain.html.in | 98 ++++ docs/schemas/domaincommon.rng | 76 +++ src/bhyve/bhyve_domain.c | 9 +- src/conf/domain_conf.c | 564 ++++++++++++++++++++- src/conf/domain_conf.h | 60 +++ src/libvirt_private.syms | 7 + src/libxl/libxl_domain.c | 8 + src/lxc/lxc_domain.c | 8 + src/openvz/openvz_driver.c | 14 +- src/parallels/parallels_driver.c | 6 +- src/phyp/phyp_driver.c | 6 +- src/qemu/qemu_command.c | 166 +++++- src/qemu/qemu_command.h | 15 + src/qemu/qemu_domain.c | 80 +++ src/qemu/qemu_domain.h | 5 + src/qemu/qemu_driver.c | 29 ++ src/qemu/qemu_hotplug.c | 177 +++++++ src/qemu/qemu_hotplug.h | 6 + src/qemu/qemu_migration.c | 14 + src/qemu/qemu_monitor.c | 42 ++ src/qemu/qemu_monitor.h | 14 + src/qemu/qemu_monitor_json.c | 122 +++++ src/qemu/qemu_monitor_json.h | 5 + src/qemu/qemu_process.c | 4 + src/uml/uml_driver.c | 9 +- src/vbox/vbox_common.c | 6 +- src/vmware/vmware_driver.c | 6 +- src/vmx/vmx.c | 6 +- src/xen/xen_driver.c | 7 + src/xenapi/xenapi_driver.c | 9 +- tests/domainschemadata/maxMemory.xml | 19 + .../qemuxml2argv-memory-hotplug-dimm.args | 11 + .../qemuxml2argv-memory-hotplug-dimm.xml | 50 ++ .../qemuxml2argv-memory-hotplug-nonuma.xml | 22 + .../qemuxml2argv-memory-hotplug.args | 6 + .../qemuxml2argv-memory-hotplug.xml | 34 ++ tests/qemuxml2argvtest.c | 6 + tests/qemuxml2xmltest.c | 4 + 38 files changed, 1707 insertions(+), 23 deletions(-) create mode 100644 tests/domainschemadata/maxMemory.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-dimm.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-dimm.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-nonuma.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug.xml -- 2.2.2

3 27

[libvirt] [PATCH 0/3] Fix some storage issues
by John Ferlan 09 Apr '15

09 Apr '15

Patch 1 & 3 are bz based, while Patch 2 was determined while working on Patch 3. Details in each commit message John Ferlan (3): storage: Fix issues in storageVolResize storage: Need to update freeExtent at delete primary partition storage: Don't duplicate efforts of backend driver src/storage/storage_backend_disk.c | 9 +++-- src/storage/storage_driver.c | 67 ++++++++++++++++++++++++++++++-------- 2 files changed, 59 insertions(+), 17 deletions(-) -- 2.1.0

2 5

[libvirt] [PATCH 0/3] Honour sparse files on migration
by Michal Privoznik 09 Apr '15

09 Apr '15

When the storage is pre-created on the destination, it might have been allocated as sparse on the source. Let's keep it that way if we can. Michal Privoznik (3): qemuMigrationPrecreateStorage: Fix debug message qemuMigrationCookieNBD: Turn some items into their own struct qemuMigrationPrecreateDisk: Preserve sparse files src/qemu/qemu_migration.c | 49 +++++++++++++++++++++++++++++++++++------------ 1 file changed, 37 insertions(+), 12 deletions(-) -- 2.0.5

2 4

[libvirt] securityselinuxlabeltest test fails on v1.2.5
by Scott Sullivan 09 Apr '15

09 Apr '15

I am trying to build v1.2.5-maint, however I have one test failing causing the build to fail: TEST: securityselinuxlabeltest !!!. 4 FAIL PASS: virsh-undefine ======================================= 1 of 112 tests failed Please report to libvir-list(a)redhat.com ======================================= make[2]: *** [check-TESTS] Error 1 make[2]: Leaving directory `/home/rpmbuild/packages/libvirt/tests' make[1]: *** [check-am] Error 2 make[1]: Leaving directory `/home/rpmbuild/packages/libvirt/tests' make: *** [check-recursive] Error 1 error: Bad exit status from /var/tmp/rpm-tmp.UGNUaq (%build) Is anyone else having this problem? Im building on CentOS 6.5. Im happy to provide any further information as needed.

7 12

[libvirt] [PATCH] lxc: create the required directories upon driver start
by Lubomir Rintel 09 Apr '15

09 Apr '15

/var/run may reside on a tmpfs and we fail to create the PID file if /var/run/lxc does not exist. Other drivers (well, BHYVE) seem to do the same thing. Signed-off-by: Lubomir Rintel <lkundrak(a)v3.sk> --- src/lxc/lxc_driver.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index 245000d..4363898 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -1648,6 +1648,20 @@ static int lxcStateInitialize(bool privileged, if (!(caps = virLXCDriverGetCapabilities(lxc_driver, false))) goto cleanup; + if (virFileMakePath(LXC_LOG_DIR) < 0) { + virReportSystemError(errno, + _("Failed to mkdir %s"), + LXC_LOG_DIR); + goto cleanup; + } + + if (virFileMakePath(LXC_STATE_DIR) < 0) { + virReportSystemError(errno, + _("Failed to mkdir %s"), + LXC_STATE_DIR); + goto cleanup; + } + /* Get all the running persistent or transient configs first */ if (virDomainObjListLoadAllConfigs(lxc_driver->domains, cfg->stateDir, -- 2.1.0

3 5

[libvirt] [PATCHv4 0/3] Support IPv6 addresses for graphics listening on networks
by Ján Tomko 09 Apr '15

09 Apr '15

v1: https://www.redhat.com/archives/libvir-list/2015-February/msg00442.html v2: https://www.redhat.com/archives/libvir-list/2015-February/msg01228.html v3: https://www.redhat.com/archives/libvir-list/2015-March/msg00423.html changes in v4: * remove the family attribute and just return the first IP address * rename virNetDevGetIPv4Address to virNetDevGetIPv4AddressIoctl John Ferlan (1): util: Replace virNetDevGetIPv4Address with virNetDevGetIPAddress Ján Tomko (1): Support IPv6 in networkGetNetworkAddress Luyao Huang (1): util: Update virNetDevGetIPAddress to get IPv6 addresses src/libvirt_private.syms | 2 +- src/network/bridge_driver.c | 11 ++-- src/util/virnetdev.c | 119 +++++++++++++++++++++++++++++++++++++++----- src/util/virnetdev.h | 2 +- 4 files changed, 114 insertions(+), 20 deletions(-) -- 2.0.5

3 5

[libvirt] [PATCH 0/2] Fix virVolLookupByPath error msg with pools that use URI as path
by Peter Krempa 09 Apr '15

09 Apr '15

Peter Krempa (2): test: Add tests for virFileSanitizePath util: file: Don't carelessly sanitize URIs src/util/virfile.c | 6 ++++++ tests/virfiletest.c | 60 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 66 insertions(+) -- 2.2.2

2 4

[libvirt] [PATCH] conf: fix memleak in qemuRestoreCgroupState
by Luyao Huang 08 Apr '15

08 Apr '15

131,088 bytes in 16 blocks are definitely lost in loss record 2,174 of 2,176 at 0x4C29BFD: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x4C2BACB: realloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x52A026F: virReallocN (viralloc.c:245) by 0x52BFCB5: saferead_lim (virfile.c:1268) by 0x52C00EF: virFileReadLimFD (virfile.c:1328) by 0x52C019A: virFileReadAll (virfile.c:1351) by 0x52A5D4F: virCgroupGetValueStr (vircgroup.c:763) by 0x1DDA0DA3: qemuRestoreCgroupState (qemu_cgroup.c:805) by 0x1DDA0DA3: qemuConnectCgroup (qemu_cgroup.c:857) by 0x1DDB7BA1: qemuProcessReconnect (qemu_process.c:3694) by 0x52FD171: virThreadHelper (virthread.c:206) by 0x82B8DF4: start_thread (pthread_create.c:308) by 0x85C31AC: clone (clone.S:113) Signed-off-by: Luyao Huang <lhuang(a)redhat.com> --- src/qemu/qemu_cgroup.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 7d64ce7..f872525 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -796,6 +796,7 @@ qemuRestoreCgroupState(virDomainObjPtr vm) virCgroupSetCpusetMems(cgroup_temp, nodeset) < 0) goto cleanup; + VIR_FREE(nodeset); virCgroupFree(&cgroup_temp); } @@ -806,6 +807,7 @@ qemuRestoreCgroupState(virDomainObjPtr vm) virCgroupSetCpusetMems(cgroup_temp, nodeset) < 0) goto cleanup; + VIR_FREE(nodeset); virCgroupFree(&cgroup_temp); } -- 1.8.3.1

3 2

[libvirt] [PATCHv2 0/2] vbox: Add support for virDomainSendKey
by Dawid Zamirski 08 Apr '15

08 Apr '15

Those patches implement support for virDomainSendKey in the VBOX driver. Since VBOX SDK does not support "holdtime" natively, it's being simulated by using usleep to wait for that time before "key-up" scancodes are sent. The "key-up" scancodes are automatically generated by add 0x80 to "key-down" scancodes. This is done to make the implementation match the behavior of how QEMU driver handles this, and therefore is different from what native VBoxManage command does - e.g. one has to type in "key-up" scancodes explicitely and no hold time support at all. --- v1 (for reference): https://www.redhat.com/archives/libvir-list/2015-March/msg01028.html v2: - add virReportError in all potentially failing code paths - coding style adjustment - mark for 1.2.15 Dawid Zamirski (2): vbox: Register IKeyboard with the unified API. vbox: Implement virDomainSendKey src/vbox/vbox_common.c | 120 ++++++++++++++++++++++++++++++++++++++++++ src/vbox/vbox_common.h | 1 + src/vbox/vbox_tmpl.c | 27 ++++++++++ src/vbox/vbox_uniformed_api.h | 8 +++ 4 files changed, 156 insertions(+) -- 2.3.4

2 3

[libvirt] [PATCH] qemu_driver: check caps after starting block job
by Michael Chapman 08 Apr '15

08 Apr '15

Currently we check qemuCaps before starting the block job. But qemuCaps isn't available on a stopped domain, which means we get a misleading error message in this case: # virsh domstate example shut off # virsh blockjob example vda error: unsupported configuration: block jobs not supported with this QEMU binary Move the qemuCaps check into the block job so that we are guaranteed the domain is running. Signed-off-by: Michael Chapman <mike(a)very.puzzling.org> --- src/qemu/qemu_driver.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index becf415..cb9295e 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -16476,12 +16476,6 @@ qemuDomainGetBlockJobInfo(virDomainPtr dom, const char *path, } priv = vm->privateData; - if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKJOB_ASYNC) && - !virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKJOB_SYNC)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("block jobs not supported with this QEMU binary")); - goto cleanup; - } if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_QUERY) < 0) goto cleanup; @@ -16492,6 +16486,13 @@ qemuDomainGetBlockJobInfo(virDomainPtr dom, const char *path, goto endjob; } + if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKJOB_ASYNC) && + !virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKJOB_SYNC)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("block jobs not supported with this QEMU binary")); + goto endjob; + } + device = qemuDiskPathToAlias(vm, path, &idx); if (!device) goto endjob; -- 2.1.0

2 1

[libvirt] [PATCH] qemu_migrate: use nested job when adding NBD to cookie
by Michael Chapman 08 Apr '15

08 Apr '15

qemuMigrationCookieAddNBD is usually called from within an async MIGRATION_OUT or MIGRATION_IN job, so it needs to start a nested job. (The one exception is during the Begin phase when change protection isn't enabled, but qemuDomainObjEnterMonitorAsync will behave the same as qemuDomainObjEnterMonitor in this case.) This bug was encountered with a libvirt client that repeatedly queries the disk mirroring block job info during a migration. If one of these queries occurs just as the Perform migration cookie is baked, libvirt crashes. Relevant logs are as follows: 6701: warning : qemuDomainObjEnterMonitorInternal:1544 : This thread seems to be the async job owner; entering monitor without asking for a nested job is dangerous [1] 6701: info : qemuMonitorSend:972 : QEMU_MONITOR_SEND_MSG: mon=0x7fefdc004700 msg={"execute":"query-block","id":"libvirt-629"} [2] 6699: info : qemuMonitorIOWrite:503 : QEMU_MONITOR_IO_WRITE: mon=0x7fefdc004700 buf={"execute":"query-block","id":"libvirt-629"} [3] 6704: info : qemuMonitorSend:972 : QEMU_MONITOR_SEND_MSG: mon=0x7fefdc004700 msg={"execute":"query-block-jobs","id":"libvirt-630"} [4] 6699: info : qemuMonitorJSONIOProcessLine:203 : QEMU_MONITOR_RECV_REPLY: mon=0x7fefdc004700 reply={"return": [...], "id": "libvirt-629"} 6699: error : qemuMonitorJSONIOProcessLine:211 : internal error: Unexpected JSON reply '{"return": [...], "id": "libvirt-629"}' At [1] qemuMonitorBlockStatsUpdateCapacity sends its request, then waits on mon->notify. At [2] the request is written out to the monitor socket. At [3] qemuMonitorBlockJobInfo sends its request, and also waits on mon->notify. The reply from the first request is received at [4]. However, qemuMonitorJSONIOProcessLine is not expecting this reply since the second request hadn't completed sending. The reply is dropped and an error is returned. qemuMonitorIO signals mon->notify twice during its error handling, waking up both of the threads waiting on it. One of them clears mon->msg as it exits qemuMonitorSend; the other crashes: qemuMonitorSend (mon=0x7fefdc004700, msg=<value optimized out>) at qemu/qemu_monitor.c:975 975 while (!mon->msg->finished) { (gdb) print mon->msg $1 = (qemuMonitorMessagePtr) 0x0 Signed-off-by: Michael Chapman <mike(a)very.puzzling.org> --- src/qemu/qemu_migration.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 5607d1a..d770aea 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -571,7 +571,9 @@ qemuMigrationCookieAddNBD(qemuMigrationCookiePtr mig, if (!(stats = virHashCreate(10, virHashValueFree))) goto cleanup; - qemuDomainObjEnterMonitor(driver, vm); + if (qemuDomainObjEnterMonitorAsync(driver, vm, + priv->job.asyncJob) < 0) + goto cleanup; rc = qemuMonitorBlockStatsUpdateCapacity(priv->mon, stats, false); if (qemuDomainObjExitMonitor(driver, vm) < 0) goto cleanup; -- 2.1.0

2 1

[libvirt] [PATCH v2 0/3] A few NUMA fixes
by Michal Privoznik 08 Apr '15

08 Apr '15

diff to v1: -reworked to follow Jan's review. Hopefully. Michal Privoznik (3): vircgroup: Introduce virCgroupControllerAvailable qemuProcessHook: Call virNuma*() iff needed virLXCControllerSetupResourceLimits: Call virNuma*() iff needed src/libvirt_private.syms | 1 + src/lxc/lxc_controller.c | 22 ++++++++++++++++------ src/qemu/qemu_process.c | 21 +++++++++++++++++---- src/util/vircgroup.c | 19 +++++++++++++++++++ src/util/vircgroup.h | 1 + tests/vircgrouptest.c | 31 +++++++++++++++++++++++++++++++ 6 files changed, 85 insertions(+), 10 deletions(-) -- 2.0.5

2 6

[libvirt] [PATCH 0/3] qemu: fix broken block job handling
by Peter Krempa 08 Apr '15

08 Apr '15

Block job handling violates our usage of domain jobs and changes disk source definition behind our back. Peter Krempa (3): qemu: process: Export qemuProcessFindDomainDiskByAlias qemu: event: Don't fiddle with disk backing trees without a job qemu: Disallow concurrent block jobs on a single disk src/conf/domain_conf.h | 1 + src/qemu/qemu_domain.c | 23 +++++++ src/qemu/qemu_domain.h | 4 ++ src/qemu/qemu_driver.c | 170 +++++++++++++++++++++++++++++++++++++++++++----- src/qemu/qemu_process.c | 131 +++++++------------------------------ src/qemu/qemu_process.h | 3 + 6 files changed, 211 insertions(+), 121 deletions(-) -- 2.2.2

4 11

[libvirt] [PATCH] parallels: delete old networks in prlsdkDoApplyConfig before adding new ones
by Maxim Nestratov 08 Apr '15

08 Apr '15

In order to change an existing domain we delete all existing devices and add new from scratch. In case of network devices we should also delete corresponding virtual networks (if any) before removing actual devices from xml. In the patch, we do it by extending prlsdkDoApplyConfig with a new parameter, which stands for old xml, and calling prlsdkDelNet every time old xml is specified. Signed-off-by: Maxim Nestratov <mnestratov(a)parallels.com> --- src/parallels/parallels_sdk.c | 24 +++++++++++++++--------- 1 files changed, 15 insertions(+), 9 deletions(-) diff --git a/src/parallels/parallels_sdk.c b/src/parallels/parallels_sdk.c index c36b772..64a2d15 100644 --- a/src/parallels/parallels_sdk.c +++ b/src/parallels/parallels_sdk.c @@ -2935,7 +2935,8 @@ prlsdkAddFS(PRL_HANDLE sdkdom, virDomainFSDefPtr fs) static int prlsdkDoApplyConfig(virConnectPtr conn, PRL_HANDLE sdkdom, - virDomainDefPtr def) + virDomainDefPtr def, + virDomainDefPtr olddef) { PRL_RESULT pret; size_t i; @@ -2997,6 +2998,16 @@ prlsdkDoApplyConfig(virConnectPtr conn, if (prlsdkRemoveBootDevices(sdkdom) < 0) goto error; + if(olddef) { + for (i = 0; i < olddef->nnets; i++) + prlsdkDelNet(conn->privateData, olddef->nets[i]); + } + + for (i = 0; i < def->nnets; i++) { + if (prlsdkAddNet(sdkdom, conn->privateData, def->nets[i]) < 0) + goto error; + } + if (prlsdkApplyGraphicsParams(sdkdom, def) < 0) goto error; @@ -3008,11 +3019,6 @@ prlsdkDoApplyConfig(virConnectPtr conn, goto error; } - for (i = 0; i < def->nnets; i++) { - if (prlsdkAddNet(sdkdom, conn->privateData, def->nets[i]) < 0) - goto error; - } - for (i = 0; i < def->ndisks; i++) { bool bootDisk = false; @@ -3060,7 +3066,7 @@ prlsdkApplyConfig(virConnectPtr conn, if (PRL_FAILED(waitJob(job, privconn->jobTimeout))) return -1; - ret = prlsdkDoApplyConfig(conn, sdkdom, new); + ret = prlsdkDoApplyConfig(conn, sdkdom, new, dom->def); if (ret == 0) { job = PrlVm_CommitEx(sdkdom, PVCF_DETACH_HDD_BUNDLE); @@ -3100,7 +3106,7 @@ prlsdkCreateVm(virConnectPtr conn, virDomainDefPtr def) pret = PrlVmCfg_SetOfflineManagementEnabled(sdkdom, 0); prlsdkCheckRetGoto(pret, cleanup); - ret = prlsdkDoApplyConfig(conn, sdkdom, def); + ret = prlsdkDoApplyConfig(conn, sdkdom, def, NULL); if (ret) goto cleanup; @@ -3162,7 +3168,7 @@ prlsdkCreateCt(virConnectPtr conn, virDomainDefPtr def) } - ret = prlsdkDoApplyConfig(conn, sdkdom, def); + ret = prlsdkDoApplyConfig(conn, sdkdom, def, NULL); if (ret) goto cleanup; -- 1.7.1

3 2

[libvirt] [PATCH 0/4] Various bugfixes for cancelled VM migrations
by Michael Chapman 08 Apr '15

08 Apr '15

This patch series contains fixes for several bugs I encountered while deliberately forcing a VM migration to abort by killing the libvirt client. My VM has storage on local disk, which needs to be mirrored during the migration, and this gives ample time for this abort to take place. The particular bug I encountered depended on precisely which phase the migration had made it to (e.g. whether disk mirroring had actually commenced). Patch 1 fixes a crash on the destination libvirt daemon due to a use-after-free of the domain object. Patches 2 and 4 fix some bugs related to the close callback handling on the source libvirt side. Patch 3 ensures that the VM on the source libvirt does not get into an invalid state if its migration is aborted during disk mirroring. All patches are independent of one another and can be applied separately. Michael Chapman (4): qemu: fix crash in qemuProcessAutoDestroy qemu: fix error propagation in qemuMigrationBegin qemu: fix race between disk mirror fail and cancel util: fix removal of callbacks in virCloseCallbacksRun src/qemu/qemu_domain.c | 5 +++++ src/qemu/qemu_migration.c | 12 +++++++++++- src/qemu/qemu_process.c | 4 +++- src/util/virclosecallbacks.c | 10 ++++++---- 4 files changed, 25 insertions(+), 6 deletions(-) -- 2.1.0

2 9

[libvirt] [PATCH 0/2] fail out if enable userns but disable netns
by Chen Hanxiao 08 Apr '15

08 Apr '15

Chen Hanxiao (2): Revert "LXC: create a bind mount for sysfs when enable userns but disable netns" LXC: make sure netns been enabled when trying to enable userns src/lxc/lxc_container.c | 45 ++++++++++++++++----------------------------- 1 file changed, 16 insertions(+), 29 deletions(-) -- 2.1.0

3 8

[libvirt] [RFC PATCH 0/2] Vbox: Add support for virDomainSendKey
by Dawid Zamirski 07 Apr '15

07 Apr '15

Hello, Those small patches implement virDomainSendKey support in VBOX driver. However, the VBOX SDK does not support "holdtime" so I used usleep to wait for that time before sending "key-up" scancodes. This makes it behave similarly to QEMU driver, however I'm not sure if that way of handling this would be preferred. Another option, would be to ignore holdtime argument and make virDomainSendKey work the same as via VBoxManage cli tool where one has to send "key-down" scancodes followed by "key-up" scancodes. For this RFC paches, I've choosen to make it work as close to the public API documentation. Dawid Zamirski (2): vbox: Register IKeyboard with the unified API. vbox: Implement virDomainSendKey src/vbox/vbox_common.c | 107 ++++++++++++++++++++++++++++++++++++++++++ src/vbox/vbox_common.h | 1 + src/vbox/vbox_tmpl.c | 27 +++++++++++ src/vbox/vbox_uniformed_api.h | 8 ++++ 4 files changed, 143 insertions(+) -- 2.3.3

2 4

[libvirt] [PATCH 0/6] Add support for storage pool state XML
by Erik Skultety 07 Apr '15

07 Apr '15

Patches add necessary changes to add support for storage pool state XMLs and thus resolve https://bugzilla.redhat.com/show_bug.cgi?id=1177733 Erik Skultety (6): conf: Introduce virStoragePoolDefFormatBuf conf: Introduce virStoragePoolSaveXML conf: Introduce virStoragePoolSaveState storage: Add support for storage pool state XML conf: Introduce virStoragePoolLoadAllState && virStoragePoolLoadState storage: Introduce storagePoolUpdateAllState function src/conf/storage_conf.c | 233 ++++++++++++++++++++++++++++++++++++------- src/conf/storage_conf.h | 12 ++- src/libvirt_private.syms | 2 + src/storage/storage_driver.c | 188 +++++++++++++++++++++++++++------- 4 files changed, 358 insertions(+), 77 deletions(-) -- 1.9.3

4 22

[libvirt] [PATCH] hostdev: Report the domain name for used hostdevs during nodedev-detach
by Shivaprasad G Bhat 07 Apr '15

07 Apr '15

The nodedev-detach can report the name of the domain using the device just the way nodedev-reattach does it. Signed-off-by: Shivaprasad G Bhat <sbhat(a)linux.vnet.ibm.com> --- src/util/virhostdev.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c index 23365a3..55eb9c9 100644 --- a/src/util/virhostdev.c +++ b/src/util/virhostdev.c @@ -1519,11 +1519,18 @@ int virHostdevPCINodeDeviceDetach(virHostdevManagerPtr hostdev_mgr, virPCIDevicePtr pci) { + virPCIDeviceAddressPtr devAddr = NULL; int ret = -1; virObjectLock(hostdev_mgr->activePCIHostdevs); virObjectLock(hostdev_mgr->inactivePCIHostdevs); + if (!(devAddr = virPCIDeviceGetAddress(pci))) + goto out; + + if (virHostdevIsPCINodeDeviceUsed(devAddr, hostdev_mgr)) + goto out; + if (virPCIDeviceDetach(pci, hostdev_mgr->activePCIHostdevs, hostdev_mgr->inactivePCIHostdevs) < 0) { goto out;

3 2

[libvirt] [PATCH 0/3] Fix couple of memleaks
by Michal Privoznik 07 Apr '15

07 Apr '15

*** BLURB HERE *** Michal Privoznik (3): qemuSetupCgroupForVcpu: Fix memleak virDomainVirtioSerialAddrSetFree: Fix memleak virQEMUDriverGetConfig: Fix memleak src/conf/domain_addr.c | 1 + src/qemu/qemu_cgroup.c | 8 ++++--- src/qemu/qemu_command.c | 5 ++++- src/qemu/qemu_domain.c | 58 +++++++++++++++++++++++-------------------------- 4 files changed, 37 insertions(+), 35 deletions(-) -- 2.0.5

2 6

[libvirt] [libvirt-cmdref PATCH] Adding Documentation for cd
by Swaathi Ramesh 07 Apr '15

07 Apr '15

The documentation for command cd did not have information about the command. Added the required information. --- source/cd.xml | 38 ++++++++++++++++++++++++++++++++++---- 1 file changed, 34 insertions(+), 4 deletions(-) diff --git a/source/cd.xml b/source/cd.xml index 78a13df..d15c74c 100644 --- a/source/cd.xml +++ b/source/cd.xml @@ -9,16 +9,46 @@ </text> </description> - <options /> + <options> + <parameter requirement="optional"> + <keyword requirement="optional">--dir</keyword> + <value type="string" requirement="optional">path</value> + <description> + <text> + directory to switch to (default: home or else root) + </text> + <text> + --dir itself is optional + </text> + </description> + </parameter> + </options> <availability from="0.7.0" /> <notes /> - <examples type="usage" /> + <examples type="usage" > + <example> + <terminal> +virsh # <bold> cd </bold> <value>/tmp</value> </terminal> + <text> + Changes the current working directory to <value> /tmp </value> + </text> + </example> + </examples> <examples type="fullcontext" /> - <reference type="seealso" /> - + <reference type="seealso" > + <item> + <link type="internal" href="pwd"/> + <name> + pwd + </name> + <description> + Displays the current directory + </description> + </item> + </reference> </command> -- 1.9.1

2 1

[libvirt] [PATCH] virsh: Improve change-media success message
by Cole Robinson 06 Apr '15

06 Apr '15

$ sudo virsh change-media f19 hdc /mnt/data/devel/media/Fedora-16-x86_64-Live-KDE.iso succeeded to complete action update on media Change the message to: Successfully {inserted,ejected,changed} media. https://bugzilla.redhat.com/show_bug.cgi?id=967946 --- tools/virsh-domain.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 020a308..928360c 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -12295,6 +12295,7 @@ cmdChangeMedia(vshControl *ctl, const vshCmd *cmd) bool ret = false; vshUpdateDiskXMLType update_type; const char *action = NULL; + const char *success_msg = NULL; bool config = vshCommandOptBool(cmd, "config"); bool live = vshCommandOptBool(cmd, "live"); bool current = vshCommandOptBool(cmd, "current"); @@ -12314,16 +12315,19 @@ cmdChangeMedia(vshControl *ctl, const vshCmd *cmd) if (eject) { update_type = VSH_UPDATE_DISK_XML_EJECT; action = "eject"; + success_msg = _("Successfully ejected media."); } if (insert) { update_type = VSH_UPDATE_DISK_XML_INSERT; action = "insert"; + success_msg = _("Successfully inserted media."); } if (update || (!eject && !insert)) { update_type = VSH_UPDATE_DISK_XML_UPDATE; action = "update"; + success_msg = _("Successfully updated media."); } VSH_EXCLUSIVE_OPTIONS_VAR(current, live); @@ -12367,7 +12371,7 @@ cmdChangeMedia(vshControl *ctl, const vshCmd *cmd) goto cleanup; } - vshPrint(ctl, _("succeeded to complete action %s on media\n"), action); + vshPrint(ctl, "%s", success_msg); } ret = true; -- 2.3.4

2 2

[libvirt] RFC: whether or not to support multiple IDE controllers (and any IDE at all on Q35)
by Laine Stump 05 Apr '15

05 Apr '15

Due to a bug report by someone trying to add two cd drives to a Q35 domain in virt-manager (which assumes all CD drives are IDE), I've learned that libvirt doesn't support adding a "piix3-ide" controller when there is no ide controller for the domain (or when there are more than 4 disk devices that need to be connected to an IDE controller). It does dutifully add: <controller type='ide' index='n'/> as many times as necessary, it's just that there is no code behind that to add the device to the qemu commandline. I first thought I should add support for this, but then had second thoughts after following this reasoning: 1) I'm not sure exactly where the piix3-ide controller was added to qemu, but it was apparently sometime after qemu-1.2.0 (at least according to tests/qemuhelpdata/qemu-1.2.0-device). 2) At some point (again not sure, but it was there at least in qemu 1.0) support for a SATA controller was added (named ich9-achi by qemu), and it can also accept CD devices. So there is no version of qemu that has piix3-ide and no ich9-ahci. 3) "ide old, ahci new" 4) I'm doubtful there is any OS old enough to require an IDE disk controller rather than SATA that anyone would also want to put > 4 disk devices on. That leads me to think that maybe it is a better idea to just log an error if someone tries to add a disk with bus='ide' on a Q35 domain, or add more than 4 of them on an i440fx domain. Does anyone have an opinion, or (better yet) a smoking gun (e.g. problems with piix3-ide, or alternately problems with ahci or a situation where IDE would be required) that will force action in one direction or the other? (One possible example - although ahci was added on or before qemu 1.0, up until the most recent upstream it wasn't possible to migrate or save a domain with an ahci controller. Do we need to worry about people with qemu < 2.3.0 that want > 4 IDE devices? Or should we figure that if none have come up before now, likely none will come up in the future either?)

1 1

[libvirt] [PATCH] libvirt: virsh: Kill all uses of __FUNCTION__ in error messages
by Noella Ashu 04 Apr '15

04 Apr '15

The error output of snapshot-revert should be more friendly. There is no need to show up virDomainRevertToSnapshot to user. virError already includes __FUNCTION__ information in a separate member of the struct, so repeating it in the message is redundant and leads to situations where higher level code ends up reporting the lower level name We correctly converted the error output making it more succinct and user-friendly. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1086726 --- src/libvirt-domain-snapshot.c | 30 +++---- src/libvirt-domain.c | 201 ++++++++++++++++++------------------------ 2 files changed, 96 insertions(+), 135 deletions(-) diff --git a/src/libvirt-domain-snapshot.c b/src/libvirt-domain-snapshot.c index 9feb669..ac858ba 100644 --- a/src/libvirt-domain-snapshot.c +++ b/src/libvirt-domain-snapshot.c @@ -222,26 +222,20 @@ virDomainSnapshotCreateXML(virDomainPtr domain, if ((flags & VIR_DOMAIN_SNAPSHOT_CREATE_CURRENT) && !(flags & VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE)) { - virReportInvalidArg(flags, - _("use of 'current' flag in %s requires " - "'redefine' flag"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("use of 'current' flag in requires 'redefine' flag")); goto error; } if ((flags & VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE) && (flags & VIR_DOMAIN_SNAPSHOT_CREATE_NO_METADATA)) { - virReportInvalidArg(flags, - _("'redefine' and 'no metadata' flags in %s are " - "mutually exclusive"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("'redefine' and 'no metadata' flags in are mutually exclusive")); goto error; } if ((flags & VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE) && (flags & VIR_DOMAIN_SNAPSHOT_CREATE_HALT)) { - virReportInvalidArg(flags, - _("'redefine' and 'halt' flags in %s are mutually " - "exclusive"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("'redefine' and 'halt' flags are mutually exclusive")); goto error; } @@ -1084,10 +1078,8 @@ virDomainRevertToSnapshot(virDomainSnapshotPtr snapshot, if ((flags & VIR_DOMAIN_SNAPSHOT_REVERT_RUNNING) && (flags & VIR_DOMAIN_SNAPSHOT_REVERT_PAUSED)) { - virReportInvalidArg(flags, - _("running and paused flags in %s are mutually " - "exclusive"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("running and paused flags are mutually exclusive")); goto error; } @@ -1146,10 +1138,8 @@ virDomainSnapshotDelete(virDomainSnapshotPtr snapshot, if ((flags & VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN) && (flags & VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN_ONLY)) { - virReportInvalidArg(flags, - _("children and children_only flags in %s are " - "mutually exclusive"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("children and children_only flags are mutually exclusive")); goto error; } diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 8b5f91e..e0be331 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -385,9 +385,7 @@ virDomainLookupByUUIDString(virConnectPtr conn, const char *uuidstr) virCheckNonNullArgGoto(uuidstr, error); if (virUUIDParse(uuidstr, uuid) < 0) { - virReportInvalidArg(uuidstr, - _("uuidstr in %s must be a valid UUID"), - __FUNCTION__); + virReportInvalidArg(uuidstr, "%s", _("Invalid UUID")); goto error; } @@ -1440,9 +1438,9 @@ virDomainScreenshot(virDomainPtr domain, virCheckReadOnlyGoto(domain->conn->flags, error); if (domain->conn != stream->conn) { - virReportInvalidArg(stream, - _("stream in %s must match connection of domain '%s'"), - __FUNCTION__, domain->name); + virReportInvalidArg(stream, "%s", + _("stream must match connection of domain '%s'"), + domain->name); goto error; } @@ -2179,10 +2177,8 @@ virDomainGetMemoryParameters(virDomainPtr domain, /* At most one of these two flags should be set. */ if ((flags & VIR_DOMAIN_AFFECT_LIVE) && (flags & VIR_DOMAIN_AFFECT_CONFIG)) { - virReportInvalidArg(flags, - _("flags 'affect live' and 'affect config' in %s " - "are mutually exclusive"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("flags 'affect live' and 'affect config' are mutually exclusive")); goto error; } conn = domain->conn; @@ -2423,10 +2419,8 @@ virDomainGetBlkioParameters(virDomainPtr domain, /* At most one of these two flags should be set. */ if ((flags & VIR_DOMAIN_AFFECT_LIVE) && (flags & VIR_DOMAIN_AFFECT_CONFIG)) { - virReportInvalidArg(flags, - _("flags 'affect live' and 'affect config' in %s " - "are mutually exclusive"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("flags 'affect live' and 'affect config' are mutually exclusive")); goto error; } conn = domain->conn; @@ -3343,9 +3337,8 @@ virDomainMigratePeer2PeerFull(virDomainPtr domain, if (!(tempuri = virURIParse(dconnuri))) return -1; if (!tempuri->server || STRPREFIX(tempuri->server, "localhost")) { - virReportInvalidArg(dconnuri, - _("unable to parse server from dconnuri in %s"), - __FUNCTION__); + virReportInvalidArg(dconnuri, "%s", + _("unable to parse server from dconnuri")); virURIFree(tempuri); return -1; } @@ -3580,10 +3573,9 @@ virDomainMigrate(virDomainPtr domain, if (flags & VIR_MIGRATE_NON_SHARED_DISK && flags & VIR_MIGRATE_NON_SHARED_INC) { - virReportInvalidArg(flags, - _("flags 'shared disk' and 'shared incremental' " - "in %s are mutually exclusive"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("flags 'shared disk' and 'shared incremental'" + " are mutually exclusive")); goto error; } @@ -3809,10 +3801,9 @@ virDomainMigrate2(virDomainPtr domain, if (flags & VIR_MIGRATE_NON_SHARED_DISK && flags & VIR_MIGRATE_NON_SHARED_INC) { - virReportInvalidArg(flags, + virReportInvalidArg(flags, "%s", _("flags 'shared disk' and 'shared incremental' " - "in %s are mutually exclusive"), - __FUNCTION__); + "are mutually exclusive")); goto error; } @@ -3989,10 +3980,9 @@ virDomainMigrate3(virDomainPtr domain, if (flags & VIR_MIGRATE_NON_SHARED_DISK && flags & VIR_MIGRATE_NON_SHARED_INC) { - virReportInvalidArg(flags, + virReportInvalidArg(flags, "%s", _("flags 'shared disk' and 'shared incremental' " - "in %s are mutually exclusive"), - __FUNCTION__); + "are mutually exclusive")); goto error; } if (flags & VIR_MIGRATE_PEER2PEER) { @@ -4212,10 +4202,9 @@ virDomainMigrateToURI(virDomainPtr domain, if (flags & VIR_MIGRATE_NON_SHARED_DISK && flags & VIR_MIGRATE_NON_SHARED_INC) { - virReportInvalidArg(flags, + virReportInvalidArg(flags, "%s", _("flags 'shared disk' and 'shared incremental' " - "in %s are mutually exclusive"), - __FUNCTION__); + "are mutually exclusive")); goto error; } @@ -4372,10 +4361,9 @@ virDomainMigrateToURI2(virDomainPtr domain, if (flags & VIR_MIGRATE_NON_SHARED_DISK && flags & VIR_MIGRATE_NON_SHARED_INC) { - virReportInvalidArg(flags, + virReportInvalidArg(flags, "%s", _("flags 'shared disk' and 'shared incremental' " - "in %s are mutually exclusive"), - __FUNCTION__); + "are mutually exclusive")); goto error; } @@ -4481,10 +4469,9 @@ virDomainMigrateToURI3(virDomainPtr domain, if (flags & VIR_MIGRATE_NON_SHARED_DISK && flags & VIR_MIGRATE_NON_SHARED_INC) { - virReportInvalidArg(flags, + virReportInvalidArg(flags, "%s", _("flags 'shared disk' and 'shared incremental' " - "in %s are mutually exclusive"), - __FUNCTION__); + "are mutually exclusive")); goto error; } @@ -4791,9 +4778,8 @@ virDomainMigratePrepareTunnel(virConnectPtr conn, virCheckReadOnlyGoto(conn->flags, error); if (conn != st->conn) { - virReportInvalidArg(conn, - _("conn in %s must match stream connection"), - __FUNCTION__); + virReportInvalidArg(conn, "%s", + _("conn must match stream connection")); goto error; } @@ -4937,9 +4923,8 @@ virDomainMigratePrepareTunnel3(virConnectPtr conn, virCheckReadOnlyGoto(conn->flags, error); if (conn != st->conn) { - virReportInvalidArg(conn, - _("conn in %s must match stream connection"), - __FUNCTION__); + virReportInvalidArg(conn, "%s", + _("conn must match stream connection")); goto error; } @@ -5221,8 +5206,7 @@ virDomainMigratePrepareTunnel3Params(virConnectPtr conn, if (conn != st->conn) { virReportInvalidArg(conn, - _("conn in %s must match stream connection"), - __FUNCTION__); + _("conn must match stream connection")); goto error; } @@ -5529,10 +5513,9 @@ virDomainGetSchedulerParametersFlags(virDomainPtr domain, /* At most one of these two flags should be set. */ if ((flags & VIR_DOMAIN_AFFECT_LIVE) && (flags & VIR_DOMAIN_AFFECT_CONFIG)) { - virReportInvalidArg(flags, - _("flags 'affect live' and 'affect config' in %s " - "are mutually exclusive"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("flags 'affect live' and 'affect config' in " + "are mutually exclusive")); goto error; } conn = domain->conn; @@ -5709,9 +5692,9 @@ virDomainBlockStats(virDomainPtr dom, const char *disk, virCheckNonNullArgGoto(disk, error); virCheckNonNullArgGoto(stats, error); if (size > sizeof(stats2)) { - virReportInvalidArg(size, - _("size in %s must not exceed %zu"), - __FUNCTION__, sizeof(stats2)); + virReportInvalidArg(size, "%s", + _("size must not exceed %zu"), + sizeof(stats2)); goto error; } conn = dom->conn; @@ -5850,9 +5833,9 @@ virDomainInterfaceStats(virDomainPtr dom, const char *path, virCheckNonNullArgGoto(path, error); virCheckNonNullArgGoto(stats, error); if (size > sizeof(stats2)) { - virReportInvalidArg(size, - _("size in %s must not exceed %zu"), - __FUNCTION__, sizeof(stats2)); + virReportInvalidArg(size, "%s", + _("size must not exceed %zu"), + sizeof(stats2)); goto error; } @@ -6297,10 +6280,9 @@ virDomainMemoryPeek(virDomainPtr dom, /* Exactly one of these two flags must be set. */ if (!(flags & VIR_MEMORY_VIRTUAL) == !(flags & VIR_MEMORY_PHYSICAL)) { - virReportInvalidArg(flags, - _("flags in %s must include VIR_MEMORY_VIRTUAL or " - "VIR_MEMORY_PHYSICAL"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("flags must include VIR_MEMORY_VIRTUAL or " + "VIR_MEMORY_PHYSICAL")); goto error; } @@ -7144,9 +7126,9 @@ virDomainSendKey(virDomainPtr domain, virCheckPositiveArgGoto(nkeycodes, error); if (nkeycodes > VIR_DOMAIN_SEND_KEY_MAX_KEYS) { - virReportInvalidArg(nkeycodes, - _("nkeycodes in %s must be <= %d"), - __FUNCTION__, VIR_DOMAIN_SEND_KEY_MAX_KEYS); + virReportInvalidArg(nkeycodes, "%s", + _("nkeycodes must be <= %d"), + VIR_DOMAIN_SEND_KEY_MAX_KEYS); goto error; } @@ -7344,8 +7326,8 @@ virDomainSetVcpusFlags(virDomainPtr domain, unsigned int nvcpus, flags & VIR_DOMAIN_VCPU_MAXIMUM) { virReportInvalidArg(flags, _("flags 'VIR_DOMAIN_VCPU_MAXIMUM' and " - "'VIR_DOMAIN_VCPU_GUEST' in '%s' are mutually " - "exclusive"), __FUNCTION__); + "'VIR_DOMAIN_VCPU_GUEST' in are mutually " + "exclusive")); goto error; } @@ -7419,10 +7401,9 @@ virDomainGetVcpusFlags(virDomainPtr domain, unsigned int flags) /* At most one of these two flags should be set. */ if ((flags & VIR_DOMAIN_AFFECT_LIVE) && (flags & VIR_DOMAIN_AFFECT_CONFIG)) { - virReportInvalidArg(flags, - _("flags 'affect live' and 'affect config' in %s " - "are mutually exclusive"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("flags 'affect live' and 'affect config' " + "are mutually exclusive")); goto error; } @@ -7626,9 +7607,8 @@ virDomainGetVcpuPinInfo(virDomainPtr domain, int ncpumaps, if ((flags & VIR_DOMAIN_AFFECT_LIVE) && (flags & VIR_DOMAIN_AFFECT_CONFIG)) { virReportInvalidArg(flags, - _("flags 'affect live' and 'affect config' in %s " - "are mutually exclusive"), - __FUNCTION__); + _("flags 'affect live' and 'affect config' " + "are mutually exclusive")); goto error; } @@ -7756,9 +7736,8 @@ virDomainGetEmulatorPinInfo(virDomainPtr domain, unsigned char *cpumap, if ((flags & VIR_DOMAIN_AFFECT_LIVE) && (flags & VIR_DOMAIN_AFFECT_CONFIG)) { virReportInvalidArg(flags, - _("flags 'affect live' and 'affect config' in %s " - "are mutually exclusive"), - __FUNCTION__); + _("flags 'affect live' and 'affect config' " + "are mutually exclusive")); goto error; } conn = domain->conn; @@ -7925,10 +7904,9 @@ virDomainGetIOThreadInfo(virDomainPtr dom, /* At most one of these two flags should be set. */ if ((flags & VIR_DOMAIN_AFFECT_LIVE) && (flags & VIR_DOMAIN_AFFECT_CONFIG)) { - virReportInvalidArg(flags, - _("flags 'affect live' and 'affect config' in %s " - "are mutually exclusive"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("flags 'affect live' and 'affect config' " + "are mutually exclusive")); goto error; } @@ -8181,10 +8159,9 @@ virDomainSetMetadata(virDomainPtr domain, switch (type) { case VIR_DOMAIN_METADATA_TITLE: if (metadata && strchr(metadata, '\n')) { - virReportInvalidArg(metadata, - _("metadata title in %s can't contain " - "newlines"), - __FUNCTION__); + virReportInvalidArg(metadata, "%s", + _("metadata title can't contain " + "newlines")); goto error; } /* fallthrough */ @@ -8259,10 +8236,9 @@ virDomainGetMetadata(virDomainPtr domain, if ((flags & VIR_DOMAIN_AFFECT_LIVE) && (flags & VIR_DOMAIN_AFFECT_CONFIG)) { - virReportInvalidArg(flags, - _("flags 'affect live' and 'affect config' in %s " - "are mutually exclusive"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("flags 'affect live' and 'affect config' " + "are mutually exclusive")); goto error; } @@ -9199,18 +9175,18 @@ virConnectDomainEventRegisterAny(virConnectPtr conn, if (dom) { virCheckDomainGoto(dom, error); if (dom->conn != conn) { - virReportInvalidArg(dom, - _("domain '%s' in %s must match connection"), - dom->name, __FUNCTION__); + virReportInvalidArg(dom, "%s", + _("domain '%s' must match connection"), + dom->name); goto error; } } virCheckNonNullArgGoto(cb, error); virCheckNonNegativeArgGoto(eventID, error); if (eventID >= VIR_DOMAIN_EVENT_ID_LAST) { - virReportInvalidArg(eventID, - _("eventID in %s must be less than %d"), - __FUNCTION__, VIR_DOMAIN_EVENT_ID_LAST); + virReportInvalidArg(eventID, "%s", + _("eventID must be less than %d"), + VIR_DOMAIN_EVENT_ID_LAST); goto error; } @@ -9311,9 +9287,8 @@ virDomainManagedSave(virDomainPtr dom, unsigned int flags) if ((flags & VIR_DOMAIN_SAVE_RUNNING) && (flags & VIR_DOMAIN_SAVE_PAUSED)) { virReportInvalidArg(flags, - _("running and paused flags in %s are mutually " - "exclusive"), - __FUNCTION__); + _("running and paused flags are mutually " + "exclusive")); goto error; } @@ -9466,9 +9441,9 @@ virDomainOpenConsole(virDomainPtr dom, virCheckReadOnlyGoto(conn->flags, error); if (conn != st->conn) { - virReportInvalidArg(st, - _("stream in %s must match connection of domain '%s'"), - __FUNCTION__, dom->name); + virReportInvalidArg(st, "%s", + _("stream must match connection of domain '%s'"), + dom->name); goto error; } @@ -9531,8 +9506,8 @@ virDomainOpenChannel(virDomainPtr dom, if (conn != st->conn) { virReportInvalidArg(st, - _("stream in %s must match connection of domain '%s'"), - __FUNCTION__, dom->name); + _("stream must match connection of domain '%s'"), + dom->name); goto error; } @@ -9955,9 +9930,8 @@ virDomainBlockRebase(virDomainPtr dom, const char *disk, VIR_DOMAIN_BLOCK_REBASE_REUSE_EXT | VIR_DOMAIN_BLOCK_REBASE_COPY_RAW | VIR_DOMAIN_BLOCK_REBASE_COPY_DEV)) { - virReportInvalidArg(flags, - _("use of flags in %s requires a copy job"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("use of flags requires a copy job")); goto error; } @@ -10276,9 +10250,9 @@ virDomainOpenGraphics(virDomainPtr dom, } if (!S_ISSOCK(sb.st_mode)) { - virReportInvalidArg(fd, - _("fd %d in %s must be a socket"), - fd, __FUNCTION__); + virReportInvalidArg(fd, "%s", + _("fd %d must be a socket"), + fd); goto error; } @@ -10490,9 +10464,8 @@ virDomainGetBlockIoTune(virDomainPtr dom, if ((flags & VIR_DOMAIN_AFFECT_LIVE) && (flags & VIR_DOMAIN_AFFECT_CONFIG)) { virReportInvalidArg(flags, - _("flags 'affect live' and 'affect config' in %s " - "are mutually exclusive"), - __FUNCTION__); + _("flags 'affect live' and 'affect config' " + "are mutually exclusive")); goto error; } conn = dom->conn; @@ -10615,8 +10588,7 @@ virDomainGetCPUStats(virDomainPtr domain, if (start_cpu == -1) { if (ncpus != 1) { virReportInvalidArg(start_cpu, - _("ncpus in %s must be 1 when start_cpu is -1"), - __FUNCTION__); + _("ncpus must be 1 when start_cpu is -1")); goto error; } } else { @@ -11284,9 +11256,8 @@ virDomainListGetStats(virDomainPtr *doms, virCheckNonNullArgGoto(retStats, cleanup); if (!*doms) { - virReportError(VIR_ERR_INVALID_ARG, - _("doms array must contain at least one domain in %s"), - __FUNCTION__); + virReportError(VIR_ERR_INVALID_ARG, "%s", + _("doms array must contain at least one domain")); goto cleanup; } @@ -11304,9 +11275,9 @@ virDomainListGetStats(virDomainPtr *doms, virCheckDomainGoto(dom, cleanup); if (dom->conn != conn) { - virReportError(VIR_ERR_INVALID_ARG, + virReportError(VIR_ERR_INVALID_ARG, "%s", _("domains in 'doms' array must belong to a " - "single connection in %s"), __FUNCTION__); + "single connection")); goto cleanup; } -- 2.1.0

2 2

[libvirt] [PATCH V2 0/3] libxl: domain destroy fixes
by Jim Fehlig 04 Apr '15

04 Apr '15

V2 of a small series to fix issues wrt domain destroy https://www.redhat.com/archives/libvir-list/2015-March/msg01337.html Comments from Konrad and Martin are addressed in this version. Jim Fehlig (3): libxl: Move job acquisition in libxlDomainStart to callers libxl: acquire a job when destroying a domain libxl: drop virDomainObj lock when destroying a domain src/libxl/libxl_domain.c | 81 ++++++++++++++++++------------------------------ src/libxl/libxl_domain.h | 4 --- src/libxl/libxl_driver.c | 80 +++++++++++++++++++++++++++++++++++------------ 3 files changed, 91 insertions(+), 74 deletions(-) -- 1.8.4.5

1 4

[libvirt] [PATCH] virsh.pod: Remove redundant --config from attach-interface
by Jiri Denemark 03 Apr '15

03 Apr '15

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- Pushed as trivial. tools/virsh.pod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 79d50f9..d642a69 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -2458,7 +2458,7 @@ Likewise, I<--shareable> is an alias for I<--mode shareable>. =item B<attach-interface> I<domain> I<type> I<source> [[[I<--live>] [I<--config>] | [I<--current>]] | [I<--persistent>]] [I<--target target>] [I<--mac mac>] [I<--script script>] [I<--model model>] -[I<--config>] [I<--inbound average,peak,burst>] [I<--outbound average,peak,burst>] +[I<--inbound average,peak,burst>] [I<--outbound average,peak,burst>] Attach a new network interface to the domain. I<type> can be I<network> to indicate connection via a libvirt virtual network, or -- 2.3.5

1 0

[libvirt] [PATCH] Fix xlconfigtest with older libxl
by Ján Tomko 03 Apr '15

03 Apr '15

Commit cd5dc30 added this test, but it fails if LIBXL_HAVE_BUILDINFO_USBDEVICE_LIST is not defined: 6) Xen XM-2-XML Format fullvirt-multiusb ... libvirt: error : unsupported configuration: multiple USB devices not supported FAILED --- tests/xlconfigtest.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/xlconfigtest.c b/tests/xlconfigtest.c index 6d4aa6d..c992548 100644 --- a/tests/xlconfigtest.c +++ b/tests/xlconfigtest.c @@ -215,7 +215,10 @@ mymain(void) DO_TEST("new-disk", 3); DO_TEST("spice", 3); + +#ifdef LIBXL_HAVE_BUILDINFO_USBDEVICE_LIST DO_TEST("fullvirt-multiusb", 3); +#endif virObjectUnref(caps); virObjectUnref(xmlopt); -- 2.0.5

2 2

[libvirt] Entering freeze for libvirt-1.2.14
by Daniel Veillard 03 Apr '15

03 Apr '15

I have tagged a release candidate 1 in git and generated signed tarballs and rpms at the usual place: ftp://libvirt.org/libvirt/ This seems to work normally in my limited testing but others need to give it a serious try ! I think I will do an RC2 on Monday, and if everything look file the final release will be on April 1st. Thanks in advance for reports about it ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

3 5

[libvirt] [PATCH] libvirt: virsh: Kill all uses of __FUNCTION__ in error messages
by Noella Ashu 03 Apr '15

03 Apr '15

The error output of snapshot-revert should be more friendly. There is no need to show up virDomainRevertToSnapshot to user. virError already includes __FUNCTION__ information in a separate member of the struct, so repeating it in the message is redundant and leads to situations where higher level code ends up reporting the lower level name We correctly converted the error output making it more succinct and user-friendly. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1086726 --- src/libvirt-domain-snapshot.c | 30 +++---- src/libvirt-domain.c | 201 ++++++++++++++++++------------------------ 2 files changed, 96 insertions(+), 135 deletions(-) diff --git a/src/libvirt-domain-snapshot.c b/src/libvirt-domain-snapshot.c index 9feb669..ac858ba 100644 --- a/src/libvirt-domain-snapshot.c +++ b/src/libvirt-domain-snapshot.c @@ -222,26 +222,20 @@ virDomainSnapshotCreateXML(virDomainPtr domain, if ((flags & VIR_DOMAIN_SNAPSHOT_CREATE_CURRENT) && !(flags & VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE)) { - virReportInvalidArg(flags, - _("use of 'current' flag in %s requires " - "'redefine' flag"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("use of 'current' flag in requires 'redefine' flag")); goto error; } if ((flags & VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE) && (flags & VIR_DOMAIN_SNAPSHOT_CREATE_NO_METADATA)) { - virReportInvalidArg(flags, - _("'redefine' and 'no metadata' flags in %s are " - "mutually exclusive"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("'redefine' and 'no metadata' flags in are mutually exclusive")); goto error; } if ((flags & VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE) && (flags & VIR_DOMAIN_SNAPSHOT_CREATE_HALT)) { - virReportInvalidArg(flags, - _("'redefine' and 'halt' flags in %s are mutually " - "exclusive"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("'redefine' and 'halt' flags are mutually exclusive")); goto error; } @@ -1084,10 +1078,8 @@ virDomainRevertToSnapshot(virDomainSnapshotPtr snapshot, if ((flags & VIR_DOMAIN_SNAPSHOT_REVERT_RUNNING) && (flags & VIR_DOMAIN_SNAPSHOT_REVERT_PAUSED)) { - virReportInvalidArg(flags, - _("running and paused flags in %s are mutually " - "exclusive"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("running and paused flags are mutually exclusive")); goto error; } @@ -1146,10 +1138,8 @@ virDomainSnapshotDelete(virDomainSnapshotPtr snapshot, if ((flags & VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN) && (flags & VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN_ONLY)) { - virReportInvalidArg(flags, - _("children and children_only flags in %s are " - "mutually exclusive"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("children and children_only flags are mutually exclusive")); goto error; } diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 4a45b9e..78b7a93 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -385,9 +385,7 @@ virDomainLookupByUUIDString(virConnectPtr conn, const char *uuidstr) virCheckNonNullArgGoto(uuidstr, error); if (virUUIDParse(uuidstr, uuid) < 0) { - virReportInvalidArg(uuidstr, - _("uuidstr in %s must be a valid UUID"), - __FUNCTION__); + virReportInvalidArg(uuidstr, "%s", _("Invalid UUID")); goto error; } @@ -1440,9 +1438,9 @@ virDomainScreenshot(virDomainPtr domain, virCheckReadOnlyGoto(domain->conn->flags, error); if (domain->conn != stream->conn) { - virReportInvalidArg(stream, - _("stream in %s must match connection of domain '%s'"), - __FUNCTION__, domain->name); + virReportInvalidArg(stream, "%s", + _("stream must match connection of domain '%s'"), + domain->name); goto error; } @@ -2179,10 +2177,8 @@ virDomainGetMemoryParameters(virDomainPtr domain, /* At most one of these two flags should be set. */ if ((flags & VIR_DOMAIN_AFFECT_LIVE) && (flags & VIR_DOMAIN_AFFECT_CONFIG)) { - virReportInvalidArg(flags, - _("flags 'affect live' and 'affect config' in %s " - "are mutually exclusive"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("flags 'affect live' and 'affect config' are mutually exclusive")); goto error; } conn = domain->conn; @@ -2423,10 +2419,8 @@ virDomainGetBlkioParameters(virDomainPtr domain, /* At most one of these two flags should be set. */ if ((flags & VIR_DOMAIN_AFFECT_LIVE) && (flags & VIR_DOMAIN_AFFECT_CONFIG)) { - virReportInvalidArg(flags, - _("flags 'affect live' and 'affect config' in %s " - "are mutually exclusive"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("flags 'affect live' and 'affect config' are mutually exclusive")); goto error; } conn = domain->conn; @@ -3343,9 +3337,8 @@ virDomainMigratePeer2PeerFull(virDomainPtr domain, if (!(tempuri = virURIParse(dconnuri))) return -1; if (!tempuri->server || STRPREFIX(tempuri->server, "localhost")) { - virReportInvalidArg(dconnuri, - _("unable to parse server from dconnuri in %s"), - __FUNCTION__); + virReportInvalidArg(dconnuri, "%s", + _("unable to parse server from dconnuri")); virURIFree(tempuri); return -1; } @@ -3580,10 +3573,9 @@ virDomainMigrate(virDomainPtr domain, if (flags & VIR_MIGRATE_NON_SHARED_DISK && flags & VIR_MIGRATE_NON_SHARED_INC) { - virReportInvalidArg(flags, - _("flags 'shared disk' and 'shared incremental' " - "in %s are mutually exclusive"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("flags 'shared disk' and 'shared incremental'" + " are mutually exclusive")); goto error; } @@ -3809,10 +3801,9 @@ virDomainMigrate2(virDomainPtr domain, if (flags & VIR_MIGRATE_NON_SHARED_DISK && flags & VIR_MIGRATE_NON_SHARED_INC) { - virReportInvalidArg(flags, + virReportInvalidArg(flags, "%s", _("flags 'shared disk' and 'shared incremental' " - "in %s are mutually exclusive"), - __FUNCTION__); + "are mutually exclusive")); goto error; } @@ -3989,10 +3980,9 @@ virDomainMigrate3(virDomainPtr domain, if (flags & VIR_MIGRATE_NON_SHARED_DISK && flags & VIR_MIGRATE_NON_SHARED_INC) { - virReportInvalidArg(flags, + virReportInvalidArg(flags, "%s", _("flags 'shared disk' and 'shared incremental' " - "in %s are mutually exclusive"), - __FUNCTION__); + "are mutually exclusive")); goto error; } if (flags & VIR_MIGRATE_PEER2PEER) { @@ -4212,10 +4202,9 @@ virDomainMigrateToURI(virDomainPtr domain, if (flags & VIR_MIGRATE_NON_SHARED_DISK && flags & VIR_MIGRATE_NON_SHARED_INC) { - virReportInvalidArg(flags, + virReportInvalidArg(flags, "%s", _("flags 'shared disk' and 'shared incremental' " - "in %s are mutually exclusive"), - __FUNCTION__); + "are mutually exclusive")); goto error; } @@ -4372,10 +4361,9 @@ virDomainMigrateToURI2(virDomainPtr domain, if (flags & VIR_MIGRATE_NON_SHARED_DISK && flags & VIR_MIGRATE_NON_SHARED_INC) { - virReportInvalidArg(flags, + virReportInvalidArg(flags, "%s", _("flags 'shared disk' and 'shared incremental' " - "in %s are mutually exclusive"), - __FUNCTION__); + "are mutually exclusive")); goto error; } @@ -4481,10 +4469,9 @@ virDomainMigrateToURI3(virDomainPtr domain, if (flags & VIR_MIGRATE_NON_SHARED_DISK && flags & VIR_MIGRATE_NON_SHARED_INC) { - virReportInvalidArg(flags, + virReportInvalidArg(flags, "%s", _("flags 'shared disk' and 'shared incremental' " - "in %s are mutually exclusive"), - __FUNCTION__); + "are mutually exclusive")); goto error; } @@ -4791,9 +4778,8 @@ virDomainMigratePrepareTunnel(virConnectPtr conn, virCheckReadOnlyGoto(conn->flags, error); if (conn != st->conn) { - virReportInvalidArg(conn, - _("conn in %s must match stream connection"), - __FUNCTION__); + virReportInvalidArg(conn, "%s", + _("conn must match stream connection")); goto error; } @@ -4937,9 +4923,8 @@ virDomainMigratePrepareTunnel3(virConnectPtr conn, virCheckReadOnlyGoto(conn->flags, error); if (conn != st->conn) { - virReportInvalidArg(conn, - _("conn in %s must match stream connection"), - __FUNCTION__); + virReportInvalidArg(conn, "%s", + _("conn must match stream connection")); goto error; } @@ -5221,8 +5206,7 @@ virDomainMigratePrepareTunnel3Params(virConnectPtr conn, if (conn != st->conn) { virReportInvalidArg(conn, - _("conn in %s must match stream connection"), - __FUNCTION__); + _("conn must match stream connection")); goto error; } @@ -5529,10 +5513,9 @@ virDomainGetSchedulerParametersFlags(virDomainPtr domain, /* At most one of these two flags should be set. */ if ((flags & VIR_DOMAIN_AFFECT_LIVE) && (flags & VIR_DOMAIN_AFFECT_CONFIG)) { - virReportInvalidArg(flags, - _("flags 'affect live' and 'affect config' in %s " - "are mutually exclusive"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("flags 'affect live' and 'affect config' in " + "are mutually exclusive")); goto error; } conn = domain->conn; @@ -5709,9 +5692,9 @@ virDomainBlockStats(virDomainPtr dom, const char *disk, virCheckNonNullArgGoto(disk, error); virCheckNonNullArgGoto(stats, error); if (size > sizeof(stats2)) { - virReportInvalidArg(size, - _("size in %s must not exceed %zu"), - __FUNCTION__, sizeof(stats2)); + virReportInvalidArg(size, "%s", + _("size must not exceed %zu"), + sizeof(stats2)); goto error; } conn = dom->conn; @@ -5850,9 +5833,9 @@ virDomainInterfaceStats(virDomainPtr dom, const char *path, virCheckNonNullArgGoto(path, error); virCheckNonNullArgGoto(stats, error); if (size > sizeof(stats2)) { - virReportInvalidArg(size, - _("size in %s must not exceed %zu"), - __FUNCTION__, sizeof(stats2)); + virReportInvalidArg(size, "%s", + _("size must not exceed %zu"), + sizeof(stats2)); goto error; } @@ -6297,10 +6280,9 @@ virDomainMemoryPeek(virDomainPtr dom, /* Exactly one of these two flags must be set. */ if (!(flags & VIR_MEMORY_VIRTUAL) == !(flags & VIR_MEMORY_PHYSICAL)) { - virReportInvalidArg(flags, - _("flags in %s must include VIR_MEMORY_VIRTUAL or " - "VIR_MEMORY_PHYSICAL"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("flags must include VIR_MEMORY_VIRTUAL or " + "VIR_MEMORY_PHYSICAL")); goto error; } @@ -7144,9 +7126,9 @@ virDomainSendKey(virDomainPtr domain, virCheckPositiveArgGoto(nkeycodes, error); if (nkeycodes > VIR_DOMAIN_SEND_KEY_MAX_KEYS) { - virReportInvalidArg(nkeycodes, - _("nkeycodes in %s must be <= %d"), - __FUNCTION__, VIR_DOMAIN_SEND_KEY_MAX_KEYS); + virReportInvalidArg(nkeycodes, "%s", + _("nkeycodes must be <= %d"), + VIR_DOMAIN_SEND_KEY_MAX_KEYS); goto error; } @@ -7344,8 +7326,8 @@ virDomainSetVcpusFlags(virDomainPtr domain, unsigned int nvcpus, flags & VIR_DOMAIN_VCPU_MAXIMUM) { virReportInvalidArg(flags, _("flags 'VIR_DOMAIN_VCPU_MAXIMUM' and " - "'VIR_DOMAIN_VCPU_GUEST' in '%s' are mutually " - "exclusive"), __FUNCTION__); + "'VIR_DOMAIN_VCPU_GUEST' in are mutually " + "exclusive")); goto error; } @@ -7419,10 +7401,9 @@ virDomainGetVcpusFlags(virDomainPtr domain, unsigned int flags) /* At most one of these two flags should be set. */ if ((flags & VIR_DOMAIN_AFFECT_LIVE) && (flags & VIR_DOMAIN_AFFECT_CONFIG)) { - virReportInvalidArg(flags, - _("flags 'affect live' and 'affect config' in %s " - "are mutually exclusive"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("flags 'affect live' and 'affect config' " + "are mutually exclusive")); goto error; } @@ -7626,9 +7607,8 @@ virDomainGetVcpuPinInfo(virDomainPtr domain, int ncpumaps, if ((flags & VIR_DOMAIN_AFFECT_LIVE) && (flags & VIR_DOMAIN_AFFECT_CONFIG)) { virReportInvalidArg(flags, - _("flags 'affect live' and 'affect config' in %s " - "are mutually exclusive"), - __FUNCTION__); + _("flags 'affect live' and 'affect config' " + "are mutually exclusive")); goto error; } @@ -7756,9 +7736,8 @@ virDomainGetEmulatorPinInfo(virDomainPtr domain, unsigned char *cpumap, if ((flags & VIR_DOMAIN_AFFECT_LIVE) && (flags & VIR_DOMAIN_AFFECT_CONFIG)) { virReportInvalidArg(flags, - _("flags 'affect live' and 'affect config' in %s " - "are mutually exclusive"), - __FUNCTION__); + _("flags 'affect live' and 'affect config' " + "are mutually exclusive")); goto error; } conn = domain->conn; @@ -7925,10 +7904,9 @@ virDomainGetIOThreadInfo(virDomainPtr dom, /* At most one of these two flags should be set. */ if ((flags & VIR_DOMAIN_AFFECT_LIVE) && (flags & VIR_DOMAIN_AFFECT_CONFIG)) { - virReportInvalidArg(flags, - _("flags 'affect live' and 'affect config' in %s " - "are mutually exclusive"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("flags 'affect live' and 'affect config' " + "are mutually exclusive")); goto error; } @@ -8181,10 +8159,9 @@ virDomainSetMetadata(virDomainPtr domain, switch (type) { case VIR_DOMAIN_METADATA_TITLE: if (metadata && strchr(metadata, '\n')) { - virReportInvalidArg(metadata, - _("metadata title in %s can't contain " - "newlines"), - __FUNCTION__); + virReportInvalidArg(metadata, "%s", + _("metadata title can't contain " + "newlines")); goto error; } /* fallthrough */ @@ -8259,10 +8236,9 @@ virDomainGetMetadata(virDomainPtr domain, if ((flags & VIR_DOMAIN_AFFECT_LIVE) && (flags & VIR_DOMAIN_AFFECT_CONFIG)) { - virReportInvalidArg(flags, - _("flags 'affect live' and 'affect config' in %s " - "are mutually exclusive"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("flags 'affect live' and 'affect config' " + "are mutually exclusive")); goto error; } @@ -9199,18 +9175,18 @@ virConnectDomainEventRegisterAny(virConnectPtr conn, if (dom) { virCheckDomainGoto(dom, error); if (dom->conn != conn) { - virReportInvalidArg(dom, - _("domain '%s' in %s must match connection"), - dom->name, __FUNCTION__); + virReportInvalidArg(dom, "%s", + _("domain '%s' must match connection"), + dom->name); goto error; } } virCheckNonNullArgGoto(cb, error); virCheckNonNegativeArgGoto(eventID, error); if (eventID >= VIR_DOMAIN_EVENT_ID_LAST) { - virReportInvalidArg(eventID, - _("eventID in %s must be less than %d"), - __FUNCTION__, VIR_DOMAIN_EVENT_ID_LAST); + virReportInvalidArg(eventID, "%s", + _("eventID must be less than %d"), + VIR_DOMAIN_EVENT_ID_LAST); goto error; } @@ -9311,9 +9287,8 @@ virDomainManagedSave(virDomainPtr dom, unsigned int flags) if ((flags & VIR_DOMAIN_SAVE_RUNNING) && (flags & VIR_DOMAIN_SAVE_PAUSED)) { virReportInvalidArg(flags, - _("running and paused flags in %s are mutually " - "exclusive"), - __FUNCTION__); + _("running and paused flags are mutually " + "exclusive")); goto error; } @@ -9466,9 +9441,9 @@ virDomainOpenConsole(virDomainPtr dom, virCheckReadOnlyGoto(conn->flags, error); if (conn != st->conn) { - virReportInvalidArg(st, - _("stream in %s must match connection of domain '%s'"), - __FUNCTION__, dom->name); + virReportInvalidArg(st, "%s", + _("stream must match connection of domain '%s'"), + dom->name); goto error; } @@ -9531,8 +9506,8 @@ virDomainOpenChannel(virDomainPtr dom, if (conn != st->conn) { virReportInvalidArg(st, - _("stream in %s must match connection of domain '%s'"), - __FUNCTION__, dom->name); + _("stream must match connection of domain '%s'"), + dom->name); goto error; } @@ -9955,9 +9930,8 @@ virDomainBlockRebase(virDomainPtr dom, const char *disk, VIR_DOMAIN_BLOCK_REBASE_REUSE_EXT | VIR_DOMAIN_BLOCK_REBASE_COPY_RAW | VIR_DOMAIN_BLOCK_REBASE_COPY_DEV)) { - virReportInvalidArg(flags, - _("use of flags in %s requires a copy job"), - __FUNCTION__); + virReportInvalidArg(flags, "%s", + _("use of flags requires a copy job")); goto error; } @@ -10276,9 +10250,9 @@ virDomainOpenGraphics(virDomainPtr dom, } if (!S_ISSOCK(sb.st_mode)) { - virReportInvalidArg(fd, - _("fd %d in %s must be a socket"), - fd, __FUNCTION__); + virReportInvalidArg(fd, "%s", + _("fd %d must be a socket"), + fd); goto error; } @@ -10490,9 +10464,8 @@ virDomainGetBlockIoTune(virDomainPtr dom, if ((flags & VIR_DOMAIN_AFFECT_LIVE) && (flags & VIR_DOMAIN_AFFECT_CONFIG)) { virReportInvalidArg(flags, - _("flags 'affect live' and 'affect config' in %s " - "are mutually exclusive"), - __FUNCTION__); + _("flags 'affect live' and 'affect config' " + "are mutually exclusive")); goto error; } conn = dom->conn; @@ -10615,8 +10588,7 @@ virDomainGetCPUStats(virDomainPtr domain, if (start_cpu == -1) { if (ncpus != 1) { virReportInvalidArg(start_cpu, - _("ncpus in %s must be 1 when start_cpu is -1"), - __FUNCTION__); + _("ncpus must be 1 when start_cpu is -1")); goto error; } } else { @@ -11284,9 +11256,8 @@ virDomainListGetStats(virDomainPtr *doms, virCheckNonNullArgGoto(retStats, cleanup); if (!*doms) { - virReportError(VIR_ERR_INVALID_ARG, - _("doms array must contain at least one domain in %s"), - __FUNCTION__); + virReportError(VIR_ERR_INVALID_ARG, "%s", + _("doms array must contain at least one domain")); goto cleanup; } @@ -11304,9 +11275,9 @@ virDomainListGetStats(virDomainPtr *doms, virCheckDomainGoto(dom, cleanup); if (dom->conn != conn) { - virReportError(VIR_ERR_INVALID_ARG, + virReportError(VIR_ERR_INVALID_ARG, "%s", _("domains in 'doms' array must belong to a " - "single connection in %s"), __FUNCTION__); + "single connection")); goto cleanup; } -- 2.1.0

2 3

[libvirt] [PATCH] virsh: fix domifaddr no output in quiet mode
by Luyao Huang 03 Apr '15

03 Apr '15

All of print function use vshPrintExtra in cmdDomIfAddr, this will make domifaddr no output in quiet mode, after this patch, quiet mode output will be: # virsh -q domifaddr test3 --source agent lo 00:00:00:00:00:00 ipv4 127.0.0.1/8 - - ipv6 ::1/128 ens8 52:54:00:1a:cb:3f ipv6 fe80::5054:ff:fe1a:cb3f/64 virbr0 52:54:00:db:51:e7 ipv4 192.168.122.1/24 virbr0-nic 52:54:00:db:51:e7 N/A N/A Signed-off-by: Luyao Huang <lhuang(a)redhat.com> --- tools/virsh-domain-monitor.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index 6951db2..9686531 100644 --- a/tools/virsh-domain-monitor.c +++ b/tools/virsh-domain-monitor.c @@ -2278,9 +2278,9 @@ cmdDomIfAddr(vshControl *ctl, const vshCmd *cmd) /* When the interface has no IP address */ if (!iface->naddrs) { - vshPrintExtra(ctl, " %-10s %-17s %-12s %s\n", - iface->name, - iface->hwaddr ? iface->hwaddr : "N/A", "N/A", "N/A"); + vshPrint(ctl, " %-10s %-17s %-12s %s\n", + iface->name, + iface->hwaddr ? iface->hwaddr : "N/A", "N/A", "N/A"); continue; } @@ -2313,12 +2313,12 @@ cmdDomIfAddr(vshControl *ctl, const vshCmd *cmd) /* Don't repeat interface name */ if (full || !j) - vshPrintExtra(ctl, " %-10s %-17s %s\n", - iface->name, - iface->hwaddr ? iface->hwaddr : "", ip_addr_str); + vshPrint(ctl, " %-10s %-17s %s\n", + iface->name, + iface->hwaddr ? iface->hwaddr : "", ip_addr_str); else - vshPrintExtra(ctl, " %-10s %-17s %s\n", - "-", "-", ip_addr_str); + vshPrint(ctl, " %-10s %-17s %s\n", + "-", "-", ip_addr_str); virBufferFreeAndReset(&buf); VIR_FREE(ip_addr_str); -- 1.8.3.1

2 1

[libvirt] [PATCH 0/2] esx: Make esxNodeGetFreeMemory always use ESX host.
by Dawid Zamirski 03 Apr '15

03 Apr '15

This patch is intended to make ESX driver behave more consistently. When calling virNodeGetFreeMemory, it would return the free bytes from a cluster when using vpx connection or ESX host when using esx connection. However, virGetNodeInfo always returns info from ESX host (specifying ESX host is mandatory, even for vpx connections) so to make this consitent, these patches make virNodeGetFreeMemory always return info from the ESX host. Dawid Zamirski (2): esx: add esxVI_GetInt esx: esxNodeGetFreeMemory return info from host. src/esx/esx_driver.c | 53 ++++++++++++++++++-------------------------------- src/esx/esx_vi.c | 32 ++++++++++++++++++++++++++++++ src/esx/esx_vi.h | 3 +++ src/esx/esx_vi_types.c | 3 +++ src/esx/esx_vi_types.h | 1 + 5 files changed, 58 insertions(+), 34 deletions(-) -- 2.1.0

2 3

[libvirt] qemu: migration: continuously sending and receiving ARP packets guest mistakenly thinks there's another guest with the same IP.
by zhang bo 03 Apr '15

03 Apr '15

Problem Description: Live-migrate a guest, which has a tap device and continuously sends and receives ARP packets, it would mistakenly think there's another guest with the same IP, immedially after migration. The steps to reproduce the problem: 1 define and start a domain with its network configured as: <interface type='bridge'> <mac address='52:54:00:7d:b0:af'/> <source bridge='br0'/> <virtualport type='openvswitch'> <parameters interfaceid='e4ad3dbb-7808-4175-83ee-ee0cba1c5456'/> </virtualport> <model type='virtio'/> <driver name='vhost' queues='4'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> </interface> 2 The guest sends ARP packets continuously: arping -I ethX xx.xx.xx.xx(self_ip) 3 Meanwhile, the guest also receives ARP packets continuously: tcpdump -i ethX arp host xx.xx.xx.xx(self_ip) -entttt 4 After migrateion, at the dest side, the guest gets a lot of ARP packets which came from the source-side guest(which was stored while it's suspended.). For example: 2015-03-27 16:45:56.695166 52:54:00:7d:b0:af > ff:ff:ff:ff:ff:ff, ethertype ARP (0x0806), length 60: arp who-has 9.61.108.208 (ff:ff:ff:ff:ff:ff) tell 9.61.108.208 2015-03-27 16:45:56.695197 52:54:00:7d:b0:af > ff:ff:ff:ff:ff:ff, ethertype ARP (0x0806), length 60: arp who-has 9.61.108.208 (ff:ff:ff:ff:ff:ff) tell 9.61.108.208 2015-03-27 16:45:56.695205 52:54:00:7d:b0:af > ff:ff:ff:ff:ff:ff, ethertype ARP (0x0806), length 60: arp who-has 9.61.108.208 (ff:ff:ff:ff:ff:ff) tell 9.61.108.208 2015-03-27 16:45:56.695214 52:54:00:7d:b0:af > ff:ff:ff:ff:ff:ff, ethertype ARP (0x0806), length 60: arp who-has 9.61.108.208 (ff:ff:ff:ff:ff:ff) tell 9.61.108.208 2015-03-27 16:45:56.695244 52:54:00:7d:b0:af > ff:ff:ff:ff:ff:ff, ethertype ARP (0x0806), length 60: arp who-has 9.61.108.208 (ff:ff:ff:ff:ff:ff) tell 9.61.108.208 2015-03-27 16:45:56.695256 52:54:00:7d:b0:af > ff:ff:ff:ff:ff:ff, ethertype ARP (0x0806), length 60: arp who-has 9.61.108.208 (ff:ff:ff:ff:ff:ff) tell 9.61.108.208 2015-03-27 16:45:56.695264 52:54:00:7d:b0:af > ff:ff:ff:ff:ff:ff, ethertype ARP (0x0806), length 60: arp who-has 9.61.108.208 (ff:ff:ff:ff:ff:ff) tell 9.61.108.208 2015-03-27 16:45:56.695291 52:54:00:7d:b0:af > ff:ff:ff:ff:ff:ff, ethertype ARP (0x0806), length 60: arp who-has 9.61.108.208 (ff:ff:ff:ff:ff:ff) tell 9.61.108.208 2015-03-27 16:45:56.695324 52:54:00:7d:b0:af > ff:ff:ff:ff:ff:ff, ethertype ARP (0x0806), length 60: arp who-has 9.61.108.208 (ff:ff:ff:ff:ff:ff) tell 9.61.108.208 2015-03-27 16:45:56.695337 52:54:00:7d:b0:af > ff:ff:ff:ff:ff:ff, ethertype ARP (0x0806), length 60: arp who-has 9.61.108.208 (ff:ff:ff:ff:ff:ff) tell 9.61.108.208 2015-03-27 16:45:56.695344 52:54:00:7d:b0:af > ff:ff:ff:ff:ff:ff, ethertype ARP (0x0806), length 60: arp who-has 9.61.108.208 (ff:ff:ff:ff:ff:ff) tell 9.61.108.208 2015-03-27 16:45:56.695364 52:54:00:7d:b0:af > ff:ff:ff:ff:ff:ff, ethertype ARP (0x0806), length 60: arp who-has 9.61.108.208 (ff:ff:ff:ff:ff:ff) tell 9.61.108.208 5 These packets will confuse my process. It may think that there is another VM has the same IP with itself. Reasons for the problem: The tap device will get up as soon as it's created(in virNetDevTapCreateInBridgePort), before the cpus got un-paused. So, it kept receiving data before the guest starts to run, please note that the data are sent from the source side. As soon as the guest get running, it parses the data stored before, and thinks they were from other guest with the same IP, which is in fact the guest from the source side. There was a patch "network: Bring netdevs online later", it move the virNetDevSetOnline() of network device just before start VM's vcpu. But in the Laine Stump replay mail say "It turns out, though, that regular tap devices which will be connected to a bridge should be ifup'ed and attached to the bridge as soon as possible, so that the forwarding delay timer of the bridge can start to count down." I agree with Laine Stump's idea that it's not a perfect solution to start the tap device right before running vcpu. so, here comes the question: what can we do to insure our guests not receive itself's ARP packets from src side during migrateion?

1 0

[libvirt] [PATCH] conf: Change virStoragePoolSaveConfig prototype s/configDir/configFile
by Erik Skultety 03 Apr '15

03 Apr '15

Just a minor change which might be a little confusing for someone looking only at the API. --- Pushed as trivial. src/conf/storage_conf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/storage_conf.h b/src/conf/storage_conf.h index edcdaed..da378b7 100644 --- a/src/conf/storage_conf.h +++ b/src/conf/storage_conf.h @@ -373,7 +373,7 @@ virStoragePoolObjAssignDef(virStoragePoolObjListPtr pools, int virStoragePoolSaveState(const char *stateFile, virStoragePoolDefPtr def); -int virStoragePoolSaveConfig(const char *configDir, +int virStoragePoolSaveConfig(const char *configFile, virStoragePoolDefPtr def); int virStoragePoolObjSaveDef(virStorageDriverStatePtr driver, virStoragePoolObjPtr pool, -- 1.9.3

1 0

[libvirt] [PATCH 0/3] REWORK/REPOST: Refactor some qemuDomainHotplugVcpus code
by John Ferlan 03 Apr '15

03 Apr '15

Originally these were in the middle of the IOThreads Setting code that needs some rework. So rather than needing to have to continually merge changes in this space, I separated them out. These are (hopefully) pure code motion and will be used in some manner by changes that will come this release cycle for IOThread Add/Del Support. IOThreads's posting: http://www.redhat.com/archives/libvir-list/2015-March/msg01014.html and specifically in order: http://www.redhat.com/archives/libvir-list/2015-March/msg01017.html http://www.redhat.com/archives/libvir-list/2015-March/msg01018.html http://www.redhat.com/archives/libvir-list/2015-March/msg01019.html I did have to make some changes to the last one to account for other recent changes in the code John Ferlan (3): qemu: qemuDomainHotplugVcpus - separate out the add cgroup qemu: qemuDomainHotplugVcpus - separate out the del cgroup and pin qemu: qemuDomainHotplugVcpus - separate out pin adjustment code src/qemu/qemu_driver.c | 201 ++++++++++++++++++++++++++++++++----------------- 1 file changed, 130 insertions(+), 71 deletions(-) -- 2.1.0

2 4

[libvirt] [PATCH V3] libxl: fix dom0 balloon logic
by Jim Fehlig 02 Apr '15

02 Apr '15

Recent testing on large memory systems revealed a bug in the Xen xl tool's freemem() function. When autoballooning is enabled, freemem() is used to ensure enough memory is available to start a domain, ballooning dom0 if necessary. When ballooning large amounts of memory from dom0, freemem() would exceed its self-imposed wait time and return an error. Meanwhile, dom0 continued to balloon. Starting the domain later, after sufficient memory was ballooned from dom0, would succeed. The libvirt implementation in libxlDomainFreeMem() suffers the same bug since it is modeled after freemem(). In the end, the best place to fix the bug on the Xen side was to slightly change the behavior of libxl_wait_for_memory_target(). Instead of failing after caller-provided wait_sec, the function now blocks as long as dom0 memory ballooning is progressing. It will return failure only when more memory is needed to reach the target and wait_sec have expired with no progress being made. See xen.git commit fd3aa246. There was a dicussion on how this would affect other libxl apps like libvirt http://lists.xen.org/archives/html/xen-devel/2015-03/msg00739.html If libvirt containing this patch was build against a Xen containing the old libxl_wait_for_memory_target() behavior, libxlDomainFreeMem() will fail after 30 sec and domain creation will be terminated. Without this patch and with old libxl_wait_for_memory_target() behavior, libxlDomainFreeMem() does not succeed after 30 sec, but returns success anyway. Domain creation continues resulting in all sorts of fun stuff like cpu soft lockups in the guest OS. It was decided to properly fix libxl_wait_for_memory_target(), and if anything improve the default behavior of apps using the freemem reference impl in xl. xl was patched to accommodate the change in libxl_wait_for_memory_target() with xen.git commit 883b30a0. This patch does the same in the libxl driver. While at it, I changed the logic to essentially match freemem() in $xensrc/tools/libxl/xl_cmdimpl.c. It was a bit cleaner IMO and will make it easier to spot future, potentially interesting divergences. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- V3: Remove unneeded local variable 'ret' in libxlDomainFreeMem. src/libxl/libxl_domain.c | 49 ++++++++++++++++++++---------------------------- 1 file changed, 20 insertions(+), 29 deletions(-) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index ce9e4d8..37b2b58 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -811,38 +811,33 @@ libxlDomainFreeMem(libxl_ctx *ctx, libxl_domain_config *d_config) { uint32_t needed_mem; uint32_t free_mem; - size_t i; - int ret = -1; int tries = 3; int wait_secs = 10; - if ((ret = libxl_domain_need_memory(ctx, &d_config->b_info, - &needed_mem)) >= 0) { - for (i = 0; i < tries; ++i) { - if ((ret = libxl_get_free_memory(ctx, &free_mem)) < 0) - break; + if (libxl_domain_need_memory(ctx, &d_config->b_info, &needed_mem) < 0) + goto error; - if (free_mem >= needed_mem) { - ret = 0; - break; - } + do { + if (libxl_get_free_memory(ctx, &free_mem) < 0) + goto error; - if ((ret = libxl_set_memory_target(ctx, 0, - free_mem - needed_mem, - /* relative */ 1, 0)) < 0) - break; + if (free_mem >= needed_mem) + return 0; - ret = libxl_wait_for_free_memory(ctx, 0, needed_mem, - wait_secs); - if (ret == 0 || ret != ERROR_NOMEM) - break; + if (libxl_set_memory_target(ctx, 0, free_mem - needed_mem, + /* relative */ 1, 0) < 0) + goto error; - if ((ret = libxl_wait_for_memory_target(ctx, 0, 1)) < 0) - break; - } - } + if (libxl_wait_for_memory_target(ctx, 0, wait_secs) < 0) + goto error; - return ret; + tries--; + } while (tries > 0); + + error: + virReportError(VIR_ERR_OPERATION_FAILED, "%s", + _("Failed to balloon domain0 memory")); + return -1; } static void @@ -958,12 +953,8 @@ libxlDomainStart(libxlDriverPrivatePtr driver, virDomainObjPtr vm, cfg->ctx, &d_config) < 0) goto endjob; - if (cfg->autoballoon && libxlDomainFreeMem(cfg->ctx, &d_config) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("libxenlight failed to get free memory for domain '%s'"), - d_config.c_info.name); + if (cfg->autoballoon && libxlDomainFreeMem(cfg->ctx, &d_config) < 0) goto endjob; - } if (virHostdevPrepareDomainDevices(hostdev_mgr, LIBXL_DRIVER_NAME, vm->def, VIR_HOSTDEV_SP_PCI) < 0) -- 1.8.4.5

2 2

[libvirt] [PATCH] virNetSocketNewConnectUNIX: Use flocks when spawning a daemon
by Michal Privoznik 02 Apr '15

02 Apr '15

https://bugzilla.redhat.com/show_bug.cgi?id=1200149 Even though we have a mutex mechanism so that two clients don't spawn two daemons, it's not strong enough. It can happen that while one client is spawning the daemon, the other one fails to connect. Basically two possible errors can happen: error: Failed to connect socket to '/home/mprivozn/.cache/libvirt/libvirt-sock': Connection refused or: error: Failed to connect socket to '/home/mprivozn/.cache/libvirt/libvirt-sock': No such file or directory The problem in both cases is, the daemon is only starting up, while we are trying to connect (and fail). We should postpone the connecting phase until the daemon is started (by the other thread that is spawning it). In order to do that, create a file lock 'libvirt-lock' in the directory where session daemon would create its socket. So even when called from multiple processes, spawning a daemon will serialize on the file lock. So only the first to come will spawn the daemon. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/rpc/virnetsocket.c | 46 ++++++++++++++++++++++++++++++---------------- 1 file changed, 30 insertions(+), 16 deletions(-) diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c index 6b019cc..8d8b6e0 100644 --- a/src/rpc/virnetsocket.c +++ b/src/rpc/virnetsocket.c @@ -545,8 +545,10 @@ int virNetSocketNewConnectUNIX(const char *path, { char *binname = NULL; char *pidpath = NULL; + char *lockpath = NULL; int fd, passfd = -1; int pidfd = -1; + int lockfd = -1; virSocketAddr localAddr; virSocketAddr remoteAddr; @@ -561,6 +563,22 @@ int virNetSocketNewConnectUNIX(const char *path, return -1; } + if (spawnDaemon) { + if (virPidFileConstructPath(false, NULL, "libvirt-lock", &lockpath) < 0) + goto error; + + if ((lockfd = open(lockpath, O_RDWR | O_CREAT, 0600)) < 0 || + virSetCloseExec(lockfd) < 0) { + virReportSystemError(errno, _("Unable to create lock '%s'"), lockpath); + goto error; + } + + if (virFileLock(lockfd, false, 0, 1, true) < 0) { + virReportSystemError(errno, _("Unable to lock '%s'"), lockpath); + goto error; + } + } + if ((fd = socket(PF_UNIX, SOCK_STREAM, 0)) < 0) { virReportSystemError(errno, "%s", _("Failed to create socket")); goto error; @@ -595,17 +613,8 @@ int virNetSocketNewConnectUNIX(const char *path, if (virPidFileConstructPath(false, NULL, binname, &pidpath) < 0) goto error; - pidfd = virPidFileAcquirePath(pidpath, false, getpid()); - if (pidfd < 0) { - /* - * This can happen in a very rare case of two clients spawning two - * daemons at the same time, and the error in the logs that gets - * reset here can be a clue to some future debugging. - */ - virResetLastError(); - spawnDaemon = false; - goto retry; - } + if ((pidfd = virPidFileAcquirePath(pidpath, false, getpid())) < 0) + goto error; if ((passfd = socket(PF_UNIX, SOCK_STREAM, 0)) < 0) { virReportSystemError(errno, "%s", _("Failed to create socket")); @@ -668,16 +677,17 @@ int virNetSocketNewConnectUNIX(const char *path, goto error; } - /* - * Do we need to eliminate the super-rare race here any more? It would - * need incorporating the following VIR_FORCE_CLOSE() into a - * virCommandHook inside a virNetSocketForkDaemon(). - */ VIR_FORCE_CLOSE(pidfd); if (virNetSocketForkDaemon(binary, passfd) < 0) goto error; } + if (lockfd) { + unlink(lockpath); + VIR_FORCE_CLOSE(lockfd); + VIR_FREE(lockpath); + } + localAddr.len = sizeof(localAddr.data); if (getsockname(fd, &localAddr.data.sa, &localAddr.len) < 0) { virReportSystemError(errno, "%s", _("Unable to get local socket name")); @@ -694,10 +704,14 @@ int virNetSocketNewConnectUNIX(const char *path, error: if (pidfd >= 0) virPidFileDeletePath(pidpath); + if (lockfd) + unlink(lockpath); VIR_FREE(pidpath); + VIR_FREE(lockpath); VIR_FORCE_CLOSE(fd); VIR_FORCE_CLOSE(passfd); VIR_FORCE_CLOSE(pidfd); + VIR_FORCE_CLOSE(lockfd); if (spawnDaemon) unlink(path); return -1; -- 2.0.5

2 2

Re: [libvirt] [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model
by Eduardo Habkost 02 Apr '15

02 Apr '15

(CCing libvir-list and Jiri Denemark for libvirt-related discussion about -cpu host/none, and live-migration safety expectations) On Wed, Apr 01, 2015 at 06:31:23PM +0200, Michael Mueller wrote: > On Wed, 1 Apr 2015 10:01:13 -0300 > Eduardo Habkost <ehabkost(a)redhat.com> wrote: > > > On Tue, Mar 31, 2015 at 10:09:09PM +0200, Michael Mueller wrote: > > > On Tue, 31 Mar 2015 15:35:26 -0300 > > > Eduardo Habkost <ehabkost(a)redhat.com> wrote: > > > > > > > On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote: > > > > > This patch implements a new QMP request named 'query-cpu-model'. > > > > > It returns the cpu model of cpu 0 and its backing accelerator. > > > > > > > > > > request: > > > > > {"execute" : "query-cpu-model" } > > > > > > > > > > answer: > > > > > {"return" : {"name": "2827-ga2", "accel": "kvm" }} > > > > > > > > > > Alias names are resolved to their respective machine type and GA names > > > > > already during cpu instantiation. Thus, also a cpu model like 'host' > > > > > which is implemented as alias will return its normalized cpu model name. > > > > > > > > > > Furthermore the patch implements the following function: > > > > > > > > > > - s390_cpu_models_used(), returns true if S390 cpu models are in use > > > > > > > > > > Signed-off-by: Michael Mueller <mimu(a)linux.vnet.ibm.com> > > > > > --- > > > > [...] > > > > > +static inline char *strdup_s390_cpu_name(S390CPUClass *cc) > > > > > +{ > > > > > + return g_strdup_printf("%04x-ga%u", cc->proc.type, cc->mach.ga); > > > > > +} > > > > > > > > How exactly is this information going to be used by clients? If getting > > > > the correct type and ga values is important for them, maybe you could > > > > add them as integer fields, instead of requiring clients to parse the > > > > CPU model name? > > > > > > The consumer don't need to parse the name, it is just important for them to have > > > distinctive names that correlate with the names returned by query-cpu-definitions. > > > Once the name of an active guest is known, e.g. ("2827-ga2", "kvm") a potential > > > migration target can be verified, i.e. its query-cpu-definitions answer for "kvm" > > > has to contain "2827-ga2" with the attribute runnable set to true. With that mechanism > > > also the largest common denominator can be calculated. That model will be used then. > > > > Understood. So the point is to really have a name that can be found at > > query-cpu-definitions. Makes sense. > > > > (BTW, if you reused strdup_s390_cpu_name() inside > > s390_cpu_compare_class_name() too, you would automatically ensure that > > query-cpus, query-cpu-definitions and s390_cpu_class_by_name() will > > always agree with each other). > > I have to verify but it seems to make sense from reading... I will do that if it works. :-) > > > > > > > > > I also changed the above mentioned routine to map the cpu model none case: > > > > > > static inline char *strdup_s390_cpu_name(S390CPUClass *cc) > > > { > > > if (cpuid(cc->proc)) { > > > return g_strdup_printf("%04x-ga%u", cc->proc.type, cc->mach.ga); > > > } else { > > > return g_strdup("none"); > > > } > > > } > > > > What about: > > > > static const char *s390_cpu_name(S390CPUClass *cc) > > { > > return cc->model_name; > > } > > > > And then you can just set cc->model_name=_name inside S390_PROC_DEF (and > > set it to "none" inside s390_cpu_class_init()). > > > > Wouldn't that store redundant information... but it would at least shift the work into the > initialization phase and do the format just once per model. To be honest, calculating the CPU model name on the fly with strdup_s390_cpu_name() like you did above wouldn't be a problem to me. I just wanted to avoid having the same CPU model name logic (and special cases like "none") duplicated inside strdup_s390_cpu_name(), S390_PROC_DEF, s390_cpu_class_by_name(), and maybe other places. Maybe this duplication can be eliminated by simply reusing strdup_s390_cpu_name() inside s390_cpu_compare_class_name(). > > > I wonder if this class->model_name conversion could be made generic > > inside the CPU class. We already have a CPU::class_by_name() method, so > > it makes sense to have the opposite function too. > > > > (But I wouldn't mind making this s390-specific first, and converted > > later to generic code if appropriate). > > ok > > > > > > > > > This implicitly will fail a comparison for cpu model ("none", "kvm") as that will > > > never be part of the query-cpu-definitions answer. > > > > I am not sure I follow. If ("none", "kvm") is never in the list, is > > "-cpu none -machine accel=kvm" always an invalid use case? > > Not directly invalid as "-cpu none" will be the same as omitting the -cpu option. > KVM will setup the vcpu properties withou any QEMU control to whatever the hosting > machine and the kvm kernel code offers. That will allow to run QEMU against a KVM > version that is not aware of the s390 cpu model ioctls. It looks like we have conflicting expectations about query-cpu-definitions, it seems: on the one hand, if "-cpu none" is valid I believe it should appear on the query-cpu-definitions return value; on the other hand, it is not (always?) migration-safe, so just comparing the source query-cpus data with the target query-cpu-definitions data wouldn't be enough to ensure live-migration safety. On x86, we have a similar problem with "-cpu host", that changes depending on the host hardware and host kernel. We solve this problem by making libvirt code aware of the set of valid CPU models, and libvirt has special cases for "-cpu host". If you don't want to encode that knowledge in libvirt or other management software for s390, it looks like you need something like a "stable-abi-safe" field on CpuDefinitionInfo? > > > > > (I don't understand completely the meaning of "-cpu none" yet. How does > > the CPU look like for the guest in this case? Is it possible to > > live-migrate when using -cpu none?) > > And yes, that does not make sense in a migration context. The answer on query-cpu-model > (or query-cpus) will be ("none", "kvm") and that will never match a runnable model. > The guest cpu will be derived from the hosting system and the kvm kernel as it is currently > without the cpu model interface. > > I hope I made it better to understand now... Yes, thanks! -- Eduardo

2 5

[libvirt] [PATCH 0/2] fix 2 bugs in virHostdevReAttachPCIDevices
by Huanle Han 02 Apr '15

02 Apr '15

Fix 1: Fix index error in loop after remove an element from the array 'virPCIDeviceList' is actually an array. Removing one element makes the rest of the element move. Use while loop, increase index only when not do 'virPCIDeviceListDel(pcidevs, dev)' Fix 2: In such a case: 1. Domain A and B xml contain the same SRIOV net hostdev(<interface type='hostdev' /> with same pci address). 2. virsh start A (Successfully, and configure the SRIOV net with custom mac) 3. virsh start B (Fail because of the hostdev used by domain A or other reason.) In step 3, 'virHostdevNetConfigRestore' is called for the hostdev which is still used by domain A. It makes the mac/vlan of the SRIOV net change. Code Change in this fix: 1. As the pci used by other domain have been removed from 'pcidevs' in previous loop, we only restore the nic config for the hostdev still in 'pcidevs'(used by this domain) 2. wrap a function 'virHostdevIsPCINetDevice', which detect whether the hostdev is a pci net device or not. 3. update the comments to make it more clear Huanle Han (2): hostdev: Fix index error in loop after remove an element hostdev: fix net config restore error src/util/virhostdev.c | 56 ++++++++++++++++++++++++++++++++++++--------------- 1 file changed, 40 insertions(+), 16 deletions(-) -- 1.9.1

3 9

[libvirt] [PATCH] Typos: Get rid of dependan(t|cies)
by Martin Kletzander 02 Apr '15

02 Apr '15

Dependant is flagged as wrong in US dictionary (only valid in UK dictionary, and even then, it has only the financial sense and not the inter-relatedness sense that we are more prone to be wanting throughout code). Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- Pushed as trivial and already decided on in here: https://www.redhat.com/archives/libvir-list/2015-March/msg01320.html src/libvirt-domain.c | 4 ++-- src/libvirt-secret.c | 2 +- src/util/virkmod.c | 2 +- tools/virsh.pod | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index f1608dc..0d00af8 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -2642,7 +2642,7 @@ virDomainGetXMLDesc(virDomainPtr domain, unsigned int flags) * * Reads native configuration data describing a domain, and * generates libvirt domain XML. The format of the native - * data is hypervisor dependant. + * data is hypervisor dependent. * * Returns a 0 terminated UTF-8 encoded XML instance, or NULL in case of error. * the caller must free() the returned value. @@ -2692,7 +2692,7 @@ virConnectDomainXMLFromNative(virConnectPtr conn, * * Reads a domain XML configuration document, and generates * a native configuration file describing the domain. - * The format of the native data is hypervisor dependant. + * The format of the native data is hypervisor dependent. * * Returns a 0 terminated UTF-8 encoded native config datafile, or NULL in case of error. * the caller must free() the returned value. diff --git a/src/libvirt-secret.c b/src/libvirt-secret.c index 946d1b8..e77f223 100644 --- a/src/libvirt-secret.c +++ b/src/libvirt-secret.c @@ -452,7 +452,7 @@ virSecretGetUsageType(virSecretPtr secret) * * Get the unique identifier of the object with which this * secret is to be used. The format of the identifier is - * dependant on the usage type of the secret. For a secret + * dependent on the usage type of the secret. For a secret * with a usage type of VIR_SECRET_USAGE_TYPE_VOLUME the * identifier will be a fully qualfied path name. The * identifiers are intended to be unique within the set of diff --git a/src/util/virkmod.c b/src/util/virkmod.c index e0bcdfc..219fad6 100644 --- a/src/util/virkmod.c +++ b/src/util/virkmod.c @@ -121,7 +121,7 @@ virKModLoad(const char *module, bool useBlacklist) * Remove or unload a module. * * NB: Do not use 'modprobe -r' here as that code will recursively - * unload any modules that were dependancies of the one being removed + * unload any modules that were dependencies of the one being removed * even if things still require them. e.g. it'll see the 'bridge' * module has refcount of 0 and remove it, even if there are bridges * created on the host diff --git a/tools/virsh.pod b/tools/virsh.pod index 5d52761..79d50f9 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -3235,7 +3235,7 @@ B<Note>: A storage pool that relies on remote resources such as an times in order to have all the volumes detected (see B<pool-refresh>). This is because the corresponding volume devices may not be present in the host's filesystem during the initial pool startup or the current -refresh attempt. The number of refresh retries is dependant upon the +refresh attempt. The number of refresh retries is dependent upon the network connection and the time the host takes to export the corresponding devices. -- 2.3.4

1 0

[libvirt] [PATCH] docs: Add Host sFlow into monitoring apps
by Martin Kletzander 02 Apr '15

02 Apr '15

Reported-by: Peter Phaal <peter.phaal(a)gmail.com> Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- docs/apps.html.in | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/apps.html.in b/docs/apps.html.in index 79ee73a..fd45189 100644 --- a/docs/apps.html.in +++ b/docs/apps.html.in @@ -321,6 +321,12 @@ For a full description, please refer to the libvirt section in the collectd.conf(5) manual page. </dd> + <dt><a href="http://host-sflow.sourceforge.net/">Host sFlow</a></dt> + <dd> + Host sFlow is a lightweight agent running on KVM hypervisors that + links to libvirt library and exports standardized cpu, memory, network + and disk metrics for all virtual machines. + </dd> <dt><a href="http://honk.sigxcpu.org/projects/libvirt/#munin">Munin</a></dt> <dd> The plugins provided by Guido Günther allow to monitor various things -- 2.3.3

2 1

[libvirt] [PATCHv3 0/6] Allocate virtio-serial addresses
by Ján Tomko 02 Apr '15

02 Apr '15

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1076708 https://bugzilla.redhat.com/show_bug.cgi?id=890606 New in v3: * preserve the behavior of honoring the controller if a partial address is specified: <address type='virtio-serial' controller='2'/> * automatically add a controller if we're out of free ports and add a test for it Ján Tomko (6): Add test for virtio serial port assignment Add functions to track virtio-serial addresses Allocate virtio-serial addresses when starting a domain Expand the address set when attaching a virtio-serial controller Assign an address when hotplugging a virtio-serial device Auto add virtio-serial controllers src/conf/domain_addr.c | 435 +++++++++++++++++++++ src/conf/domain_addr.h | 61 +++ src/conf/domain_conf.c | 48 +-- src/conf/domain_conf.h | 1 + src/libvirt_private.syms | 11 + src/qemu/qemu_command.c | 63 +++ src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domain.h | 1 + src/qemu/qemu_hotplug.c | 32 +- src/qemu/qemu_process.c | 2 + tests/qemuhotplugtest.c | 2 +- .../qemuxml2argv-channel-virtio-auto.args | 2 +- .../qemuxml2argv-channel-virtio-autoadd.args | 33 ++ .../qemuxml2argv-channel-virtio-autoadd.xml | 45 +++ .../qemuxml2argv-channel-virtio-autoassign.args | 20 + .../qemuxml2argv-channel-virtio-autoassign.xml | 50 +++ tests/qemuxml2argvtest.c | 4 + .../qemuxml2xmlout-channel-virtio-auto.xml | 9 +- 18 files changed, 777 insertions(+), 43 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-channel-virtio-autoadd.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-channel-virtio-autoadd.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-channel-virtio-autoassign.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-channel-virtio-autoassign.xml -- 2.0.5

2 8

[libvirt] [PATCH v2 0/6] storage: handle scsi/iscsi error paths better
by John Ferlan 02 Apr '15

02 Apr '15

v1 here: http://www.redhat.com/archives/libvir-list/2015-March/msg01562.html changes: 1/6: Removed the virGetLastError() == NULL check 2/6: New - reading more closely showed an error path without a goto 3/6: New - Adjust return for virStorageBackendSCSINewLun to be able to differentiate real error vs. deciding to return because a stable path could not be determined 4/6: New - Found an unused variable in processLU 5/6: Adjust the logic to return -1 for "real" errors and -2 for errors that are "recoverable". Removed the need for goto cleanup. 6/6: Add check for non-existent stable path at startup (and fail). Add check during refresh for a found non standard stable path that returns no volumes in the pool John Ferlan (6): iscsi: Use error message from virStorageBackendSCSIFindLUs iscsi: Fix exit path for virStorageBackendISCSIFindLUs failure scsi: Adjust return value for virStorageBackendSCSINewLun scsi: Remove unused 'type_path' in processLU scsi: Adjust return values from processLU iscsi: Add checks for non standard stable target.path src/storage/storage_backend_iscsi.c | 33 ++++++++++++++++----- src/storage/storage_backend_scsi.c | 59 ++++++++++++++++++++++++------------- 2 files changed, 64 insertions(+), 28 deletions(-) -- 2.1.0

2 12

[libvirt] [PATCH 0/7] Introduce storage pool status XML
by Erik Skultety 02 Apr '15

02 Apr '15

All of the commits resolve BZ https://bugzilla.redhat.com/show_bug.cgi?id=1177733 Erik Skultety (7): storage: Remove unused attribute conn from 'checkPool' callback conf: Add support for storage state directory conf: Add/modify storage formatting functions storage: Modify stateInitialize to support storage state XML conf: Introduce virStoragePoolLoadAllState && virStoragePoolLoadState storage: Introduce storagePoolUpdateAllState function storage: Create/Delete pool status XML src/conf/storage_conf.c | 229 ++++++++++++++++++++++++++++------ src/conf/storage_conf.h | 14 ++- src/libvirt_private.syms | 2 + src/storage/storage_backend.h | 3 +- src/storage/storage_backend_fs.c | 3 +- src/storage/storage_backend_iscsi.c | 3 +- src/storage/storage_backend_logical.c | 3 +- src/storage/storage_backend_mpath.c | 3 +- src/storage/storage_backend_scsi.c | 3 +- src/storage/storage_backend_zfs.c | 3 +- src/storage/storage_driver.c | 166 +++++++++++++++++++----- 11 files changed, 348 insertions(+), 84 deletions(-) -- 1.9.3

3 20

[libvirt] [PATCH] virsh: remove stale comment
by Ján Tomko 02 Apr '15

02 Apr '15

Copied from the vcpupin command, which has two modes of operation. --- Pushed as trivial. tools/virsh-domain.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index eee441f..e7b5eeb 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -6961,7 +6961,6 @@ cmdIOThreadPin(vshControl *ctl, const vshCmd *cmd) goto cleanup; cpumaplen = VIR_CPU_MAPLEN(maxcpu); - /* Pin mode: pinning specified vcpu to specified physical cpus*/ if (!(cpumap = vshParseCPUList(ctl, cpulist, maxcpu, cpumaplen))) goto cleanup; -- 2.0.5

1 0

[libvirt] [python PATCH] Post-release version bump to 1.2.15
by Jiri Denemark 02 Apr '15

02 Apr '15

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- Pushed as trivial. setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 00e6d75..79b048f 100755 --- a/setup.py +++ b/setup.py @@ -309,7 +309,7 @@ class my_clean(clean): _c_modules, _py_modules = get_module_lists() setup(name = 'libvirt-python', - version = '1.2.14', + version = '1.2.15', url = 'http://www.libvirt.org', maintainer = 'Libvirt Maintainers', maintainer_email = 'libvir-list(a)redhat.com', -- 2.3.5

1 0

[libvirt] [PATCH 0/2] qemu: Finish fixing of interlocking domain ops with blockjobs
by Peter Krempa 02 Apr '15

02 Apr '15

Peter Krempa (1): qemu: snapshot: Check for block jobs individually Shanzhi Yu (1): conf: Rename virDomainHasDiskMirror and detect block jobs properly src/conf/domain_conf.c | 25 ++++++++++++++++++++----- src/conf/domain_conf.h | 3 ++- src/libvirt_private.syms | 2 +- src/qemu/qemu_driver.c | 19 +++++++++++-------- src/qemu/qemu_migration.c | 2 +- 5 files changed, 35 insertions(+), 16 deletions(-) -- 2.2.2

2 5

[libvirt] [PATCH 0/6] Cleanups
by Ján Tomko 02 Apr '15

02 Apr '15

First two patches are a result of compiling with -Wunused-macros. They reduce the number of infractions from 111 to 82. The remaining cases are: * unused VIR_FROM_THIS * copies of other headers * in drivers I'm not familiar with enough The next two were found randomly, which lead me to look into virutil.h as well, because just like virsh.c, the util files were split as well. Ján Tomko (6): Remove unused macros Use the DEFAULT_DRIVER_DIR macro Do not include cpu_map.h in libvirtd.c Clean up headers in src/util/virutil.h Remove unused includes from virsh Remove unnecessary includes from virsh.h daemon/libvirtd.c | 2 -- src/conf/network_conf.c | 1 - src/driver.c | 4 ++-- src/locking/lock_daemon.c | 1 - src/locking/lock_driver_lockd.c | 4 ---- src/openvz/openvz_driver.c | 4 ---- src/qemu/qemu_driver.c | 2 -- src/qemu/qemu_monitor_text.c | 3 --- src/test/test_driver.c | 1 - src/uml/uml_driver.c | 3 --- src/util/virutil.c | 4 ---- src/util/virutil.h | 2 -- tests/sockettest.c | 10 ---------- tests/testutils.c | 5 ----- tools/virsh-domain.c | 1 + tools/virsh-network.c | 7 +------ tools/virsh-nodedev.c | 7 +------ tools/virsh-nwfilter.c | 6 ------ tools/virsh-pool.c | 6 ------ tools/virsh-secret.c | 6 ------ tools/virsh-snapshot.c | 1 + tools/virsh.c | 10 ---------- tools/virsh.h | 3 --- 23 files changed, 6 insertions(+), 87 deletions(-) -- 2.0.5

2 13

[libvirt] [PATCH 0/8] Fix cgroups regresion when default cpuset is specified
by Peter Krempa 02 Apr '15

02 Apr '15

Since commit a39f69d2b libvirt would fail to start a VM if the default cpu set was specified and individual vcpus were pinned to cpus outside of that cpuset. Peter Krempa (8): qemu: cgroup: Store auto cpuset instead of re-creating it on demand qemu: cgroup: Refactor setup for IOThread cgroups qemu: cgroup: Properly set up vcpu pinning qemu: cgroup: Use priv->autoCpuset instead of using qemuPrepareCpumap() qemu: cgroup: Rename qemuSetupCgroupEmulatorPin to qemuSetupCgroupCpusetCpus qemu: cgroup: Kill qemuSetupCgroupIOThreadsPin() qemu: cgroup: Kill qemuSetupCgroupVcpuPin() qemu: Copy bitmap in a sane way src/qemu/qemu_cgroup.c | 150 +++++++++++++++--------------------------------- src/qemu/qemu_cgroup.h | 13 +---- src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domain.h | 3 + src/qemu/qemu_driver.c | 21 +++---- src/qemu/qemu_process.c | 93 +++++++++--------------------- src/qemu/qemu_process.h | 2 - 7 files changed, 85 insertions(+), 198 deletions(-) -- 2.2.2

4 12

[libvirt] [PATCH] Bump version to 1.2.15 for new dev cycle
by Peter Krempa 02 Apr '15

02 Apr '15

--- Pushed as trivial. configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index b1193a6..38fbbad 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@ dnl You should have received a copy of the GNU Lesser General Public dnl License along with this library. If not, see dnl <http://www.gnu.org/licenses/>. -AC_INIT([libvirt], [1.2.14], [libvir-list(a)redhat.com] [], [http://libvirt.org] +AC_INIT([libvirt], [1.2.15], [libvir-list(a)redhat.com] [], [http://libvirt.org] AC_CONFIG_SRCDIR([src/libvirt.c]) AC_CONFIG_AUX_DIR([build-aux]) AC_CONFIG_HEADERS([config.h]) -- 2.2.2

1 0

[libvirt] Release of libvirt-1.2.14
by Daniel Veillard 02 Apr '15

02 Apr '15

It's out ! The release is tagged in git, signed tarballs and packages are available from the usual place: ftp://libvirt.org/libvirt/ I also tagged and pushed a libvirt-python-1.2.14 release at: ftp://libvirt.org/libvirt/python/ This is a rather large release, around 350 commits, in a balanced set: a few new features, a reasonable set of fixes and a bunch of improvements :-) Features: - qemu: Implement memory device hotplug (Peter Krempa) - Implement public API for virDomainPinIOThread (John Ferlan) - Implement public API for virDomainGetIOThreadsInfo (John Ferlan) - SRIOV NIC offload feature discovery (James Chapman) Documentation: - virCgroupNewPartition: Fix comment (Michal Privoznik) - route element must specify network address (Chen Fan) - no 'via' attribute in route element (Chen Fan) - Document that USB hostdevs do not need nodeDettach (Ján Tomko) - Document behavior of compat when creating qcow2 volumes (Ján Tomko) - Fix typo in error message (Ján Tomko) - Fix common misspellings (Martin Kletzander) - Fix doc for backingStore (Deepak Shetty) - schema and docs for the midonet virtualport type (Antoni Segura Puimedon) - add a note that spice channel is usable only with spice graphics (Pavel Hrdina) - net-define: update or unify documentation (Pavel Hrdina) - pool-define: update and unify documentation (Pavel Hrdina) - iface-define: update and unify documentation (Pavel Hrdina) - Fix syntax for vcpupin description (John Ferlan) - virsh.pod: Add information regarding LXC for setmem, memtune, and dominfo (John Ferlan) - add a note that attr 'managed' is only used by PCI devices (Erik Skultety) Portability: - build: avoid variable named 'interface', for mingw (Eric Blake) - vircgroup: Fix build issue mingw cross compile (John Ferlan) - vircgroup: Fix build issue on mingw cross compile (John Ferlan) - virnetdev: fix build with old kernel (Pavel Hrdina) - Fix build on mingw (Ján Tomko) Bug fixes: - qemu: blockjob: Synchronously update backing chain in XML on ABORT/PIVOT (Peter Krempa) - qemu: processBlockJob: Don't unlock @vm twice (Peter Krempa) - qemu: blockCopy: Pass adjusted bandwidth when called via blockRebase (Peter Krempa) - virsh: blockCopy: Add missing jump on error path (Luyao Huang) - qemuDomainGetNumaParameters: Check for the correct CGroup controller (Michal Privoznik) - virCgroupController: Check the enum fits into 'int' (Michal Privoznik) - virnetlink: fix build error (Pavel Hrdina) - qemu: end the job when try to blockcopy to non-file destination (Shanzhi Yu) - relaxng: allow : in /dev/disk/by-path names (Eric Blake) - libxl: Fix memory leak if pthread_create fails. (Konrad Rzeszutek Wilk) - util: use netlink to delete bridge devices (Laine Stump) - qemu: command: Fix property name for start address of a pc-dimm module (Luyao Huang) - qemu: command: Check for empty network source when formatting drive cmd (Peter Krempa) - qemu: command: Report error when formatting network source with protocol _NONE (Peter Krempa) - build: fix race when creating the cpu_map.xml symlink (Amy Fong) - Don't validata filesystem target type (Guido Günther) - rpc: Don't unref identity object while callbacks still can be executed (Peter Krempa) - util: identity: Harden virIdentitySetCurrent() (Peter Krempa) - qemu: domain: Don't leak device alias list (Peter Krempa) - rpc: serverclient: Clear pointer with NULL instead of 0 (Peter Krempa) - qemu: fix set vcpus on host without NUMA (Pavel Hrdina) - qemu: monitor: Don't leak @props with non-JSON in qemuMonitorAddObject (Peter Krempa) - qemu: Don't return memory device config on error in qemuBuildMemoryBackendStr (Peter Krempa) - Fix underlinking of libvirt_driver_interface.so (Natanael Copa) - networkStateInitialize: Don't lock network driver (Michal Privoznik) - qemu: Migrate memory on numatune change (Martin Kletzander) - parallels: fix libvirt crash if parallelsNetworkOpen fails (Maxim Nestratov) - qemu: do not overwrite the error in qemuDomainObjExitMonitor (Luyao Huang) - libxl: Don't overwrite errors from xenconfig (Jim Fehlig) - qemu: Fix two issues in qemuDomainSetVcpus error handling (John Ferlan) - qemu: track 'cancelling' migration state (Eric Blake) - parallels: don't prevent domain define if VIR_DOMAIN_NET_TYPE_BRIDGE (Maxim Nestratov) - parallels: switch off offline management feature (Maxim Nestratov) - parallels: set correct network adapter link state (Maxim Nestratov) - parallels: fix parallelsLoadNetworks (Maxim Nestratov) - network: Resolve Coverity FORWARD_NULL (John Ferlan) - qemuGetDHCPInterfaces: Don't leak @network (Michal Privoznik) - cmdDomIfAddr: Free @ip_addr_str (Michal Privoznik) - qemu: read backing chain names from qemu (Eric Blake) - qemu: driver: Fix cold-update of removable storage devices (Peter Krempa) - parallels: fix home directory for VMs (Maxim Nestratov) - parallels: don't forget to unlock domain if unregister fails (Maxim Nestratov) - parallels: set cpu mode when applying xml configuration (Mikhail Feoktistov) - conf: Use correct type for balloon stats period (Martin Kletzander) - qemu: Don't duplicate errors when settings stats period (Martin Kletzander) - libxl: fix regression introduced by commit 4ab8cd77 (Jim Fehlig) - qemu: block-commit: Mark disk in block jobs only on successful command (Peter Krempa) - daemon: avoid memleak when ListAll returns nothing (Eric Blake) - qemu: Fix possible memory leak in qemuDomainPinVcpuFlags (John Ferlan) - qemu: Disallow concurrent block jobs on a single disk (Peter Krempa) - qemu: event: Don't fiddle with disk backing trees without a job (Peter Krempa) - qemu: Check for negative port values in network drive configuration (Erik Skultety) - network: avoid memory leak of dnsmasq capabilities (Eric Blake) - virsh: fix report of non-active commit completion (Eric Blake) - util: don't fail if no PortData is found while getting migrateData (zhang bo) - libxl: prevent attaching multiple netdevs with the same MAC (Marek Marczykowski-Górecki) - parallels: fix prlsdkCheckUnsupportedParams checks (Maxim Nestratov) - Error out on an address for isa-serial in QEMU driver. (Ján Tomko) - xenapi: Resolve Coverity REVERSE_INULL (John Ferlan) - xenapi: Resolve Coverity REVERSE_INULL (John Ferlan) - xenapi: Resolve Coverity NULL_RETURNS (John Ferlan) - xenapi: Resolve Coverity NO_EFFECT (John Ferlan) - xenapi: Resolve Coverity FORWARD_NULL (John Ferlan) - conf: Resolve Coverity RESOURCE_LEAK (John Ferlan) - parallels: prevent domain define only if vcpupin is specified (Maxim Nestratov) - parallels: prevent domain define only if NUMA is really specified (Maxim Nestratov) - parallels: don't forget to unlock domain in parallelsDomainHasManagedSaveImage (Maxim Nestratov) - domain_conf: fix crash in virDomainObjListFindByUUIDInternal (Michael Chapman) - {domain, network}_conf: disable autostart when deleting config (Michael Chapman) - virQEMUCapsInitQMP: Don't dispose locked @vm (Michal Privoznik) - qemu: fix memory leak in qemuAgentGetFSInfo (Chen Fan) - qemu: don't fill in nicindexes for session mode libvirtd (Laine Stump) - virnet*: Don't unlock object in dispose (Michal Privoznik) - sanlock: Don't spam logs with "target pid not found" (Jiri Denemark) - qemu: Resolve Coverity CHECKED_RETURN issue (John Ferlan) - conf: Remove duplicate entries in <metadata> by namespace (Peter Krempa) - qemu: Allow spaces in disk serial (Michal Privoznik) - parallels: Cleanup partly opened drivers on connect open failure (Michal Privoznik) - qemu: snapshot: Don't skip check for qcow2 format with network disks (Shanzhi Yu) - testNetworkUpdate: Unlock network at the end (Michal Privoznik) - qemuProcessReconnect: Fill in pid file path (Michal Privoznik) - qemu: check defaultMode for spice graphics independently (Pavel Hrdina) - schema: Fix interface link state schema (Peter Krempa) - qemu: Don't crash in qemuDomainOpenChannel() (Martin Kletzander) - disk: Provide a default storage source format type. (John Ferlan) - disk: Disallow duplicated target 'dev' values (John Ferlan) - phyp: Fix error messages mentioning memory (Peter Krempa) - storage: sheepdog: Avoid skipping variable initialization (Peter Krempa) - Check if domain is running in qemuDomainAgentIsAvailable (Ján Tomko) - Revert "Restore skipping of setting capacity" (Ján Tomko) Improvements: - tests: nodeinfo: Add test for RHELSA on APM mustang (Cole Robinson) - tests: nodeinfo: Test F21 aarch64 on APM mustang (Cole Robinson) - qemu: Extract internals of processBlockJobEvent into a helper (Peter Krempa) - virCgroupNew: Enhance debug message (Michal Privoznik) - tests: introduce qemucaps2xmlmock (Pavel Hrdina) - nodeinfo: Increase the num of CPU thread siblings to a larger value (Wei Huang) - util: use netlink to create bridge devices (Laine Stump) - util: replace body of virNetDevMacVLanDelete() with virNetlinkDelLink() (Laine Stump) - util: netlink function to delete any network device (Laine Stump) - maint: update to latest gnulib (Eric Blake) - Rename DomainGetIOThreadsInfo to DomainGetIOThreadInfo (Ján Tomko) - Rename qemuMonitorIOThreadsInfo* to qemuMonitorIOThreadInfo* (Ján Tomko) - Rename virDomainIOThreadsInfoFree to virDomainIOThreadInfoFree (Ján Tomko) - virsh: rename iothreadsinfo to iothreadinfo (Ján Tomko) - qemu: Give hint about -noTSX CPU model (Jiri Denemark) - cpu: Add {Haswell,Broadwell}-noTSX CPU models (Jiri Denemark) - tests: qemuxml2xml: Test status XML formatting and parsing (Peter Krempa) - util: buffer: Add support for adding text blocks with indentation (Peter Krempa) - daemon: Clear fake domain def object that is used to check ACL prior to use (Peter Krempa) - tests: qemuxml2xml: Refactor the qemuxml2xml test (Peter Krempa) - qemu: Report better error when memory device source has wrong NUMA node (Luyao Huang) - util: NUMA: Change error code in virNumaNodesetIsAvailable() (Peter Krempa) - conf: Add missing apostrophe to error message (Luyao Huang) - Makefile: fix typo (Pavel Hrdina) - qemu: Add timing to domain jobs (Jiri Denemark) - qemu: Track the API which started the current job (Jiri Denemark) - Set thread job for every RPC call (Jiri Denemark) - virThreadPool: Set thread worker name (Jiri Denemark) - virThread: Set thread job (Jiri Denemark) - Force usage of virThreadCreate (Jiri Denemark) - Add support for tracking thread jobs (Jiri Denemark) - POTFILES.in: Sort (Jiri Denemark) - libxl: remove per-domain libxl_ctx (Jim Fehlig) - libxl: make libxlDomainFreeMem static (Jim Fehlig) - libxl: remove unnecessary libxlDomainEventsRegister (Jim Fehlig) - libxl: use global libxl_ctx in event handler (Jim Fehlig) - libxl: move event registration to driver initialization (Jim Fehlig) - libxl: Move setup of child processing code to driver initialization (Jim Fehlig) - libxl: use driver-wide ctx in fd and timer event handling (Jim Fehlig) - qemu: cleanup setvcpus (Pavel Hrdina) - qemu: move virDomainLiveConfigHelperMethod right after BeginJob (Pavel Hrdina) - qemu: change accidental VIR_WARNING back to VIR_DEBUG (Laine Stump) - qemucaps2xmltest: fix the test to correspond to new domain formatting (Pavel Hrdina) - conf: fix parsing of NUMA settings in VM status XML (Luyao Huang) - qemu: Implement memory device hotunplug (Peter Krempa) - qemu: conf: Add support for memory device cold(un)plug (Peter Krempa) - qemu: add support for memory devices (Peter Krempa) - qemu: migration: Forbid migration with memory modules lacking info (Peter Krempa) - qemu: memdev: Add infrastructure to load memory device information (Peter Krempa) - conf: Add interface to parse and format memory device information (Peter Krempa) - conf: Add device address type for dimm devices (Peter Krempa) - qemu: Implement setup of memory hotplug parameters (Peter Krempa) - conf: Add support for parsing and formatting max memory and slot count (Peter Krempa) - libxl: Refactor logic in domain post parse callback (Peter Krempa) - qemu: Set default SCSI controller model for S390 arch (Boris Fiuczynski) - qemu: skip precreation of network disks (Michael Chapman) - network_conf: Drop virNetworkObjIsDuplicate (Michal Privoznik) - objecteventtest: Check for virNetwork* return values (Michal Privoznik) - cgroup: Add accessors for cpuset.memory_migrate (Martin Kletzander) - maint: update .mailmap for recent contributions (Eric Blake) - libxl: use xenlight pkgconfig file if present (Jim Fehlig) - util: more verbose error when failing to create macvtap device (Laine Stump) - util: clean up #includes of virnetdevopenvswitch.h (Laine Stump) - util: vhost user: support for bootindex (zhang bo) - parallels: make E1000 network adapter model default (Maxim Nestratov) - parallels: better bridge network interface support (Maxim Nestratov) - parallels: introduce and use string constants for network types and names (Maxim Nestratov) - maint: Distribute tests/vircgroupdata (Jiri Denemark) - Use PAUSED state for domains that are starting up (Jiri Denemark) - tests: Add tests for virCgroupDetectMounts (Jiri Denemark) - qemuAgentGetInterfaces: Don't error out on missing HW address (Michal Privoznik) - virsh: Adapt to new HW address scenario (Michal Privoznik) - RPC: Allow HW address in remote_domain_interface struct to be NULL (Michal Privoznik) - network: Add midonet virtual port type support to qemu (Antoni Segura Puimedon) - util: functions to support binding/unbinding midonet virtualports (Antoni Segura Puimedon) - conf: disk: Simplify checking if source definition was parsed (Peter Krempa) - util: storage: Fix check for empty storage device (Peter Krempa) - qemu: hotplug: Use checker function to check if disk is empty (Peter Krempa) - virsh: domain: Fix the change-media command (Peter Krempa) - virsh: domain: Add --print-xml flag for command change-media (Peter Krempa) - virsh: domain: Don't use vshPrepareDiskXML for creating XML to detach disk (Peter Krempa) - parallels_sdk.c: minor cleanup (Maxim Nestratov) - domifaddr: Add virsh support (Nehal J Wani) - domifaddr: Implement the API for qemu (Nehal J Wani) - domifaddr: Implement the remote protocol (Nehal J Wani) - domifaddr: Implement the public APIs (Nehal J Wani) - conf: Reorder elements inside memballoon (Martin Kletzander) - util: Make sure the comment about virBufferAddBuffer is true (Martin Kletzander) - wireshark: fix VPATH build (Pavel Hrdina) - qemu_command: Fix some indentation and a typo (Luyao Huang) - rpm-build: use pkg-config to detect wireshark presence (Pavel Hrdina) - Remove virDomainIOThreadsPinDel (John Ferlan) - Replace virDomainVcpuPinDel with virDomainPinDel (John Ferlan) - Replace virDomainIOThreadsPinAdd with virDomainPinAdd (John Ferlan) - Replace virDomainVcpuPinAdd with virDomainPinAdd (John Ferlan) - Convert virDomainVcpuPinFindByVcpu into virDomainPinFindByVcpu (John Ferlan) - Convert virDomainVcpuPinIsDuplicate into virDomainPinIsDuplicate (John Ferlan) - Convert virDomainVcpuPinDefCopy into virDomainPinDefCopy (John Ferlan) - Convert virDomainVcpuPinDefArrayFree to virDomainPinDefArrayFree (John Ferlan) - Convert virDomainVcpuPinDefFree to virDomainPinDefFree (John Ferlan) - Convert virDomainPinDefPtr->vcpuid to virDomainPinDefPtr->id (John Ferlan) - Convert virDomainVcpuPinDefPtr to virDomainPinDefPtr (John Ferlan) - conf: Make specifying <memory> optional (Peter Krempa) - conf: Automatically use NUMA memory size in case NUMA is enabled (Peter Krempa) - qemu: command: Add helper to align memory sizes (Peter Krempa) - conf: Replace access to def->mem.max_balloon with accessor functions (Peter Krempa) - qemu: process: Export qemuProcessFindDomainDiskByAlias (Peter Krempa) - AUTHORS: add myself to commiters list (Erik Skultety) - netdev: silence valgrind warning about ioctl use (Eric Blake) - conf: add virDomainHasNet (Marek Marczykowski-Górecki) - tests: xenconfig: test for multiple USB devices and other HVM options (Marek Marczykowski-Górecki) - xenconfig: add support for multiple USB devices syntax (Marek Marczykowski-Górecki) - libxl: add tablet/mouse input device support (Marek Marczykowski) - bridge_driver: Use more of networkObjFromNetwork (Michal Privoznik) - parallels_network: Drop parallelsDriverLock() from everywhere. (Michal Privoznik) - test_driver: Drop testDriverLock() from almost everywhere (Michal Privoznik) - bridge_driver: Drop networkDriverLock() from almost everywhere (Michal Privoznik) - struct _virNetworkDriverState: Annotate items (Michal Privoznik) - network_driver: Use accessor for dnsmasqCaps (Michal Privoznik) - bridge_driver: Don't access global driver randomly (Michal Privoznik) - Introduce virBitmapIsBitSet (Ján Tomko) - Clarify the meaning of version in redirdev filters (Ján Tomko) - vmx: add e1000e to supported NIC models. (Dawid Zamirski) - vbox: use user cache dir when screenshotting. (Dawid Zamirski) - parallels: add VIR_ARCH_I686 capability to parallels driver (Maxim Nestratov) - virsh: Add iothreadpin command (John Ferlan) - qemu: Add support to pin IOThreads to specific CPU (John Ferlan) - domain: Introduce virDomainIOThreadsPin{Add|Del} (John Ferlan) - remote: Implement the plumbing for virDomainPinIOThread (John Ferlan) - virNetworkObjFindBy*: Return an reference to found object (Michal Privoznik) - virNetworkObjListPtr: Make APIs self-locking (Michal Privoznik) - network_conf: Introduce locked versions of lookup functions (Michal Privoznik) - virNetworkObjList: Derive from virObjectLockableClass (Michal Privoznik) - parallels_network: Use virNetworkObjEndAPI (Michal Privoznik) - test_driver: Use virNetworkObjEndAPI (Michal Privoznik) - bridge_driver: Use virNetworkObjEndAPI (Michal Privoznik) - network_conf: Introduce virNetworkObjEndAPI (Michal Privoznik) - network_conf: Make virNetworkObj actually virObject (Michal Privoznik) - virNetworkObjListPtr: Turn list into a hash table (Michal Privoznik) - qemu: monitor: Kill qemuMonitorGetBlockStats(Info,ParamsNumber) (Peter Krempa) - test: qemu: json: Avoid using the now obsolete functions (Peter Krempa) - qemu: blockstats: Refactor qemuDomainBlockStatsFlags (Peter Krempa) - qemu: blockstats: Add support for totalled block statistics (Peter Krempa) - qemu: Split out working code qemuDomainBlockStats (Peter Krempa) - qemu: monitor: Count block stats fields in qemuMonitorGetAllBlockStatsInfo (Peter Krempa) - qemu: monitor: Convert common code to a macro (Peter Krempa) - qemu: monitor: Implement HMP version for listing all block device stats (Peter Krempa) - test: qemu: Fix qemu monitor test utils to allow testing HMP (Peter Krempa) - qemu: blockstats: Switch to caller allocated hash table (Peter Krempa) - qemu: monitor: Drop parsing of 'errs' from block info (Peter Krempa) - qemu: Use macro to set block stats typed parameters (Peter Krempa) - RNG: Allow multiple parameters to be passed to an interface filter (Michal Privoznik) - parallels: cpumask support (Maxim Nestratov) - qemu: Remove unnecessary virReportError on networkGetNetworkAddress return (Luyao Huang) - Reverse the logic in virbitmaptest (Ján Tomko) - Use virBitmapNextClearBit in networkNextClassID (Ján Tomko) - network_conf: Turn struct _virNetworkObjList private (Michal Privoznik) - network_conf: Turn virNetworkObjList into virObject (Michal Privoznik) - parallels_network: Adapt to new virNetworkObjList accessors (Michal Privoznik) - test_driver: Adapt to new virNetworkObjList accessors (Michal Privoznik) - bridge_driver: Adapt to new virNetworkObjList accessors (Michal Privoznik) - network_conf: Introduce virNetworkObjListPrune (Michal Privoznik) - network_conf: Introduce virNetworkObjListNumOfNetworks (Michal Privoznik) - network_conf: Introduce virNetworkObjListGetNames (Michal Privoznik) - network_conf: Introduce virNetworkObjListForEach (Michal Privoznik) - locking: Fix flags in virLockManagerLockDaemonNew (Jiri Denemark) - tests: fix qemuxml2argvtest to be arch independent (Pavel Hrdina) - qemu: Change qemuDomainGetEmulatorPinInfo bitmap manipulation (John Ferlan) - qemu: Change qemuDomainGetVcpuPinInfo bitmap manipulation (John Ferlan) - qemu: Change/Fix IOThread CPU affinity bitmap manipulation (John Ferlan) - Remove ReadOnly check for GetIOThreadsInfo (John Ferlan) - tests: Add test for os interleaving (Martin Kletzander) - tests: Add test for virtio-mmio address type (Martin Kletzander) - domain_conf: Format <pvpanic/> without address correctly (Michal Privoznik) - Refresh translations from Zanata (Daniel P. Berrange) - virsh: Add 'iothreadsinfo' command (John Ferlan) - qemu: Implement the qemu driver fetch for IOThreads (John Ferlan) - remote: Implement the remote plumbing for virDomainGetIOThreadsInfo (John Ferlan) - memtune: change the way how we store unlimited value (Pavel Hrdina) - virutil: introduce helper functions for memory limits (Pavel Hrdina) - virsh: fix memtune to also accept 0 as valid value (Pavel Hrdina) - qemu: Pass file descriptor when using TPM passthrough (Stefan Berger) - qemu: Move TPM command line build code into own function (Stefan Berger) - utils: Implement virCommandPassFDGetFDIndex (Stefan Berger) - libxl: remove unneeded cleanup_unlock label (Jim Fehlig) - libxl: use libxl_ctx passed to libxlConsoleCallback (Jim Fehlig) - libxl: remove redundant calls to libxl_evdisable_domain_death (Jim Fehlig) - spec: Enable RBD storage driver in RHEL-7 (Peter Krempa) - storage: tweak condition to properly test lseek (Erik Skultety) - virsh: tweak domif-getlink link state reporting message (Erik Skultety) - qemu: Allow inactive domains in qemuDomainGetControlInfo() (Peter Krempa) - qemu: Properly report error state in qemuDomainGetControlInfo() (Peter Krempa) - conf: s/virNetworkFindByName/virNetworkObjFindByName/ (Michal Privoznik) - conf: s/virNetworkFindByUUID/virNetworkObjFindByUUID/ (Michal Privoznik) - bridge_driver: s/virNetworkObjList/virNetworkObjListPtr/ (Michal Privoznik) - parallels: s/virNetworkObjList/virNetworkObjListPtr/ (Michal Privoznik) - test_driver: s/virNetworkObjList/virNetworkObjListPtr/ (Michal Privoznik) - virNetworkObjListExport: Pass virNetworkObjListPtr (Michal Privoznik) - virNetworkObjListFree: Accept NULL (Michal Privoznik) - virNetworkObjIsDuplicate: s/@doms/@nets/ (Michal Privoznik) - networkGetNetworkAddress: Drop empty 'error' label (Michal Privoznik) - bridge_driver: Don't check network active unlocked (Michal Privoznik) - networkLookupByUUID: Improve error message (Michal Privoznik) - qemu: remove duplicated code for allocating spice ports (Pavel Hrdina) - tests : Add test for 'ppc64le' architecture. (Prerna Saxena) - RNG: Add 'ppc64le' arch and newer pseries-2.* machine types (Prerna Saxena) - conf: De-duplicate scheduling policy enums (Martin Kletzander) - virsh.pod: Update find-storage-pool-sources[-as] man page (John Ferlan) - iscsi: Adjust error message for findStorageSources backend (John Ferlan) - virsh: Adjust domblklist to understand disk volume syntax (John Ferlan) - conf: numa: Add helper to count total memory size configured in NUMA (Peter Krempa) - qemu: Forbid setting maximum memory size with the API with NUMA enabled (Peter Krempa) - Pass virDomainObjPtr to qemuDomainAgentAvailable (Ján Tomko) - Check for qemu guest agent availability after getting the job (Ján Tomko) - Allow creating volumes with a backing store but no capacity (Ján Tomko) - Allow omitting volume capacity when backing store is specified (Ján Tomko) - Probe for capacity in virStorageBackendUpdateVolTargetInfo (Ján Tomko) - Allow cloning volumes with no capacity specified (Ján Tomko) - Allow parsing volumes without specifying the capacity (Ján Tomko) - Parse backingStore before capacity in volume XML (Ján Tomko) - Add flags argument to virStorageVolDefParse* (Ján Tomko) - Add --migratable support to virsh cpu-baseline (Ján Tomko) - Trivially implement VIR_CONNECT_BASELINE_CPU_MIGRATABLE for non-x86 cpus (Ján Tomko) - Implement VIR_CONNECT_BASELINE_CPU_MIGRATABLE in the x86 cpu driver (Ján Tomko) - Add VIR_CONNECT_BASELINE_CPU_MIGRATABLE flag (Ján Tomko) - Use virBufferTrim when generating boot options (Ján Tomko) - Make -boot arg generation more readable (Ján Tomko) - Remove code handling the QEMU_CAPS_DOMID capability (Ján Tomko) - Remove bootloader option from QEMU (Ján Tomko) Thanks everybody who contributed to this release, with code, ideas bug reports, docs, localizations, or patch reviews. Enjoy ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] error: negative width in bit-field '_gl_verify_error_if_negative' ?
by Zhi Yong Wu 02 Apr '15

02 Apr '15

HI, Does anyone hit this issue when compiling libvirt? CCLD libvirt.la CC libvirt_qemu_la-libvirt-qemu.lo CCLD libvirt-qemu.la CC libvirt_lxc_la-libvirt-lxc.lo CCLD libvirt-lxc.la CC lockd_la-lock_driver_lockd.lo CC lockd_la-lock_protocol.lo CCLD lockd.la CC libvirt_driver_qemu_impl_la-qemu_agent.lo CC libvirt_driver_qemu_impl_la-qemu_capabilities.lo qemu/qemu_capabilities.c:55: error: negative width in bit-field '_gl_verify_error_if_negative' make[3]: *** [libvirt_driver_qemu_impl_la-qemu_capabilities.lo] Error 1 make[3]: Leaving directory `/home/zhiyong.wzy/libvirt-source/src' make[2]: *** [all] Error 2 make[2]: Leaving directory `/home/zhiyong.wzy/libvirt-source/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/zhiyong.wzy/libvirt-source' make: *** [all] Error 2 -- Regards, Zhi Yong Wu

2 2

[libvirt] [PATCH 0/3] libxl: domain destroy fixes
by Jim Fehlig 01 Apr '15

01 Apr '15

This small series of patches fixes some issues wrt domain destroy in the libxl driver. The primary motivation for this work is to prevent locking the virDomainObj during long running destroy operations on large memory domains. Patch 1 moves job acquisition from libxlDomainStart to it's callers so they have more control over when the job is acquired. Patch 2 fixes a few spots where we never acquired a job during domain destroy. Patch 3 contains the interesting change, where the virDomainObj is unlocked during the long-running destroy operation. This series wraps up my work to improve parallel OpenStack Tempest runs against the libxl driver. With libvirt.git master + this series + a patched libxl [1], I've successfully run a reproducer that was hitting the same issues encountered by Tempest. [1] libxl commits from xen.git: 93699882d, f1335f0d, 4783c99a, 1c91d6fba, and 188e9c54. I'll contact the stable branch maintainers and ask them to include these commits in the next Xen 4.4.x and 4.5.x releases. Jim Fehlig (3): libxl: Move job acquisition in libxlDomainStart to callers libxl: acquire a job when destroying a domain libxl: drop virDomainObj lock when destroying a domain src/libxl/libxl_domain.c | 77 +++++++++++++++++++---------------------------- src/libxl/libxl_domain.h | 4 --- src/libxl/libxl_driver.c | 78 ++++++++++++++++++++++++++++++++++++------------ 3 files changed, 89 insertions(+), 70 deletions(-) -- 1.8.4.5

5 15

[libvirt] [PATCH] qemu: lifecycle: make agent-mode shutdown and reboot timeout
by zhang bo 01 Apr '15

01 Apr '15

When we shutdown/reboot a guest using agent-mode, if the guest itself blocks infinitely, libvirt would block in qemuAgentShutdown() forever. Thus, we set a timeout for shutdown/reboot, from our experience, 60 seconds would be fine. Signed-off-by: Zhang Bo <oscar.zhangbo(a)huawei.com> Signed-off-by: Wang Yufei <james.wangyufei(a)huawei.com> --- include/libvirt/libvirt-qemu.h | 1 + src/qemu/qemu_agent.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/include/libvirt/libvirt-qemu.h b/include/libvirt/libvirt-qemu.h index 0c5d650..2bb8ee8 100644 --- a/include/libvirt/libvirt-qemu.h +++ b/include/libvirt/libvirt-qemu.h @@ -49,6 +49,7 @@ typedef enum { VIR_DOMAIN_QEMU_AGENT_COMMAND_BLOCK = -2, VIR_DOMAIN_QEMU_AGENT_COMMAND_DEFAULT = -1, VIR_DOMAIN_QEMU_AGENT_COMMAND_NOWAIT = 0, + VIR_DOMAIN_QEMU_AGENT_COMMAND_SHUTDOWN = 60, } virDomainQemuAgentCommandTimeoutValues; char *virDomainQemuAgentCommand(virDomainPtr domain, const char *cmd, diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index a7b3279..548d580 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -1300,7 +1300,7 @@ int qemuAgentShutdown(qemuAgentPtr mon, else mon->await_event = QEMU_AGENT_EVENT_SHUTDOWN; ret = qemuAgentCommand(mon, cmd, &reply, false, - VIR_DOMAIN_QEMU_AGENT_COMMAND_BLOCK); + VIR_DOMAIN_QEMU_AGENT_COMMAND_SHUTDOWN); virJSONValueFree(cmd); virJSONValueFree(reply); -- 1.7.12.4

2 1

[libvirt] [PATCH v2] nodeinfodata: Remove broken symlinks and uneeded files
by Michal Privoznik 01 Apr '15

01 Apr '15

The 7c3c7f217ebae5 and f5c2d6 commits introduced a nodeinfo test. In order to do that, some parts of sysfs had to be copied. However, sysfs is full of symlinks, so during copying some symlinks broke. Remove them, as on different systems they can point to different files or be broken. At the same time, we don't need all files added in those commits. For instance we don't care about 'uevent' files, 'power' folders, and others. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- diff to v1: - remove more files tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/async | 1 - .../linux-f21-mustang/cpu/cpu0/power/autosuspend_delay_ms | 0 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/control | 1 - .../linux-f21-mustang/cpu/cpu0/power/runtime_active_kids | 1 - .../linux-f21-mustang/cpu/cpu0/power/runtime_active_time | 1 - .../nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_enabled | 1 - .../nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_status | 1 - .../linux-f21-mustang/cpu/cpu0/power/runtime_suspended_time | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_usage | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/subsystem | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/uevent | 8 -------- tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/async | 1 - .../linux-f21-mustang/cpu/cpu1/power/autosuspend_delay_ms | 0 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/control | 1 - .../linux-f21-mustang/cpu/cpu1/power/runtime_active_kids | 1 - .../linux-f21-mustang/cpu/cpu1/power/runtime_active_time | 1 - .../nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_enabled | 1 - .../nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_status | 1 - .../linux-f21-mustang/cpu/cpu1/power/runtime_suspended_time | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_usage | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/subsystem | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/uevent | 8 -------- tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/async | 1 - .../linux-f21-mustang/cpu/cpu2/power/autosuspend_delay_ms | 0 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/control | 1 - .../linux-f21-mustang/cpu/cpu2/power/runtime_active_kids | 1 - .../linux-f21-mustang/cpu/cpu2/power/runtime_active_time | 1 - .../nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_enabled | 1 - .../nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_status | 1 - .../linux-f21-mustang/cpu/cpu2/power/runtime_suspended_time | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_usage | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/subsystem | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/uevent | 8 -------- tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/async | 1 - .../linux-f21-mustang/cpu/cpu3/power/autosuspend_delay_ms | 0 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/control | 1 - .../linux-f21-mustang/cpu/cpu3/power/runtime_active_kids | 1 - .../linux-f21-mustang/cpu/cpu3/power/runtime_active_time | 1 - .../nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_enabled | 1 - .../nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_status | 1 - .../linux-f21-mustang/cpu/cpu3/power/runtime_suspended_time | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_usage | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/subsystem | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/uevent | 8 -------- tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/async | 1 - .../linux-f21-mustang/cpu/cpu4/power/autosuspend_delay_ms | 0 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/control | 1 - .../linux-f21-mustang/cpu/cpu4/power/runtime_active_kids | 1 - .../linux-f21-mustang/cpu/cpu4/power/runtime_active_time | 1 - .../nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_enabled | 1 - .../nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_status | 1 - .../linux-f21-mustang/cpu/cpu4/power/runtime_suspended_time | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_usage | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/subsystem | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/uevent | 8 -------- tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/async | 1 - .../linux-f21-mustang/cpu/cpu5/power/autosuspend_delay_ms | 0 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/control | 1 - .../linux-f21-mustang/cpu/cpu5/power/runtime_active_kids | 1 - .../linux-f21-mustang/cpu/cpu5/power/runtime_active_time | 1 - .../nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_enabled | 1 - .../nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_status | 1 - .../linux-f21-mustang/cpu/cpu5/power/runtime_suspended_time | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_usage | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/subsystem | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/uevent | 8 -------- tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/async | 1 - .../linux-f21-mustang/cpu/cpu6/power/autosuspend_delay_ms | 0 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/control | 1 - .../linux-f21-mustang/cpu/cpu6/power/runtime_active_kids | 1 - .../linux-f21-mustang/cpu/cpu6/power/runtime_active_time | 1 - .../nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_enabled | 1 - .../nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_status | 1 - .../linux-f21-mustang/cpu/cpu6/power/runtime_suspended_time | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_usage | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/subsystem | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/uevent | 8 -------- tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/async | 1 - .../linux-f21-mustang/cpu/cpu7/power/autosuspend_delay_ms | 0 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/control | 1 - .../linux-f21-mustang/cpu/cpu7/power/runtime_active_kids | 1 - .../linux-f21-mustang/cpu/cpu7/power/runtime_active_time | 1 - .../nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_enabled | 1 - .../nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_status | 1 - .../linux-f21-mustang/cpu/cpu7/power/runtime_suspended_time | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_usage | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/subsystem | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/uevent | 8 -------- tests/nodeinfodata/linux-f21-mustang/cpu/power/async | 1 - .../nodeinfodata/linux-f21-mustang/cpu/power/autosuspend_delay_ms | 0 tests/nodeinfodata/linux-f21-mustang/cpu/power/control | 1 - .../nodeinfodata/linux-f21-mustang/cpu/power/runtime_active_kids | 1 - .../nodeinfodata/linux-f21-mustang/cpu/power/runtime_active_time | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_enabled | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_status | 1 - .../linux-f21-mustang/cpu/power/runtime_suspended_time | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_usage | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/uevent | 0 .../linux-rhelsa-3.19.0-mustang/cpu/cpu0/firmware_node | 1 - .../cpu/cpu0/power/autosuspend_delay_ms | 0 .../linux-rhelsa-3.19.0-mustang/cpu/cpu0/power/control | 1 - .../cpu/cpu0/power/runtime_active_time | 1 - .../linux-rhelsa-3.19.0-mustang/cpu/cpu0/power/runtime_status | 1 - .../cpu/cpu0/power/runtime_suspended_time | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/subsystem | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/uevent | 2 -- .../linux-rhelsa-3.19.0-mustang/cpu/cpu1/firmware_node | 1 - .../cpu/cpu1/power/autosuspend_delay_ms | 0 .../linux-rhelsa-3.19.0-mustang/cpu/cpu1/power/control | 1 - .../cpu/cpu1/power/runtime_active_time | 1 - .../linux-rhelsa-3.19.0-mustang/cpu/cpu1/power/runtime_status | 1 - .../cpu/cpu1/power/runtime_suspended_time | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/subsystem | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/uevent | 2 -- .../linux-rhelsa-3.19.0-mustang/cpu/cpu2/firmware_node | 1 - .../cpu/cpu2/power/autosuspend_delay_ms | 0 .../linux-rhelsa-3.19.0-mustang/cpu/cpu2/power/control | 1 - .../cpu/cpu2/power/runtime_active_time | 1 - .../linux-rhelsa-3.19.0-mustang/cpu/cpu2/power/runtime_status | 1 - .../cpu/cpu2/power/runtime_suspended_time | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/subsystem | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/uevent | 2 -- .../linux-rhelsa-3.19.0-mustang/cpu/cpu3/firmware_node | 1 - .../cpu/cpu3/power/autosuspend_delay_ms | 0 .../linux-rhelsa-3.19.0-mustang/cpu/cpu3/power/control | 1 - .../cpu/cpu3/power/runtime_active_time | 1 - .../linux-rhelsa-3.19.0-mustang/cpu/cpu3/power/runtime_status | 1 - .../cpu/cpu3/power/runtime_suspended_time | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/subsystem | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/uevent | 2 -- .../linux-rhelsa-3.19.0-mustang/cpu/cpu4/firmware_node | 1 - .../cpu/cpu4/power/autosuspend_delay_ms | 0 .../linux-rhelsa-3.19.0-mustang/cpu/cpu4/power/control | 1 - .../cpu/cpu4/power/runtime_active_time | 1 - .../linux-rhelsa-3.19.0-mustang/cpu/cpu4/power/runtime_status | 1 - .../cpu/cpu4/power/runtime_suspended_time | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/subsystem | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/uevent | 2 -- .../linux-rhelsa-3.19.0-mustang/cpu/cpu5/firmware_node | 1 - .../cpu/cpu5/power/autosuspend_delay_ms | 0 .../linux-rhelsa-3.19.0-mustang/cpu/cpu5/power/control | 1 - .../cpu/cpu5/power/runtime_active_time | 1 - .../linux-rhelsa-3.19.0-mustang/cpu/cpu5/power/runtime_status | 1 - .../cpu/cpu5/power/runtime_suspended_time | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/subsystem | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/uevent | 2 -- .../linux-rhelsa-3.19.0-mustang/cpu/cpu6/firmware_node | 1 - .../cpu/cpu6/power/autosuspend_delay_ms | 0 .../linux-rhelsa-3.19.0-mustang/cpu/cpu6/power/control | 1 - .../cpu/cpu6/power/runtime_active_time | 1 - .../linux-rhelsa-3.19.0-mustang/cpu/cpu6/power/runtime_status | 1 - .../cpu/cpu6/power/runtime_suspended_time | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/subsystem | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/uevent | 2 -- .../linux-rhelsa-3.19.0-mustang/cpu/cpu7/firmware_node | 1 - .../cpu/cpu7/power/autosuspend_delay_ms | 0 .../linux-rhelsa-3.19.0-mustang/cpu/cpu7/power/control | 1 - .../cpu/cpu7/power/runtime_active_time | 1 - .../linux-rhelsa-3.19.0-mustang/cpu/cpu7/power/runtime_status | 1 - .../cpu/cpu7/power/runtime_suspended_time | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/subsystem | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/uevent | 2 -- .../linux-rhelsa-3.19.0-mustang/cpu/power/autosuspend_delay_ms | 0 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/power/control | 1 - .../linux-rhelsa-3.19.0-mustang/cpu/power/runtime_active_time | 1 - .../linux-rhelsa-3.19.0-mustang/cpu/power/runtime_status | 1 - .../linux-rhelsa-3.19.0-mustang/cpu/power/runtime_suspended_time | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/uevent | 0 168 files changed, 212 deletions(-) delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/async delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/autosuspend_delay_ms delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/control delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_active_kids delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_active_time delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_enabled delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_status delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_suspended_time delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_usage delete mode 120000 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/subsystem delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/uevent delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/async delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/autosuspend_delay_ms delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/control delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_active_kids delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_active_time delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_enabled delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_status delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_suspended_time delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_usage delete mode 120000 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/subsystem delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/uevent delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/async delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/autosuspend_delay_ms delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/control delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_active_kids delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_active_time delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_enabled delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_status delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_suspended_time delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_usage delete mode 120000 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/subsystem delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/uevent delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/async delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/autosuspend_delay_ms delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/control delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_active_kids delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_active_time delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_enabled delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_status delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_suspended_time delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_usage delete mode 120000 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/subsystem delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/uevent delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/async delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/autosuspend_delay_ms delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/control delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_active_kids delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_active_time delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_enabled delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_status delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_suspended_time delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_usage delete mode 120000 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/subsystem delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/uevent delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/async delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/autosuspend_delay_ms delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/control delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_active_kids delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_active_time delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_enabled delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_status delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_suspended_time delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_usage delete mode 120000 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/subsystem delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/uevent delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/async delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/autosuspend_delay_ms delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/control delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_active_kids delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_active_time delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_enabled delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_status delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_suspended_time delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_usage delete mode 120000 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/subsystem delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/uevent delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/async delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/autosuspend_delay_ms delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/control delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_active_kids delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_active_time delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_enabled delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_status delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_suspended_time delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_usage delete mode 120000 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/subsystem delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/uevent delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/power/async delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/power/autosuspend_delay_ms delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/power/control delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_active_kids delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_active_time delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_enabled delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_status delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_suspended_time delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_usage delete mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/uevent delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/firmware_node delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/power/autosuspend_delay_ms delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/power/control delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/power/runtime_active_time delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/power/runtime_status delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/power/runtime_suspended_time delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/subsystem delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/uevent delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/firmware_node delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/power/autosuspend_delay_ms delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/power/control delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/power/runtime_active_time delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/power/runtime_status delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/power/runtime_suspended_time delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/subsystem delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/uevent delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/firmware_node delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/power/autosuspend_delay_ms delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/power/control delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/power/runtime_active_time delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/power/runtime_status delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/power/runtime_suspended_time delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/subsystem delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/uevent delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/firmware_node delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/power/autosuspend_delay_ms delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/power/control delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/power/runtime_active_time delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/power/runtime_status delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/power/runtime_suspended_time delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/subsystem delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/uevent delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/firmware_node delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/power/autosuspend_delay_ms delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/power/control delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/power/runtime_active_time delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/power/runtime_status delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/power/runtime_suspended_time delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/subsystem delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/uevent delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/firmware_node delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/power/autosuspend_delay_ms delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/power/control delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/power/runtime_active_time delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/power/runtime_status delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/power/runtime_suspended_time delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/subsystem delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/uevent delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/firmware_node delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/power/autosuspend_delay_ms delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/power/control delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/power/runtime_active_time delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/power/runtime_status delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/power/runtime_suspended_time delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/subsystem delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/uevent delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/firmware_node delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/power/autosuspend_delay_ms delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/power/control delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/power/runtime_active_time delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/power/runtime_status delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/power/runtime_suspended_time delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/subsystem delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/uevent delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/power/autosuspend_delay_ms delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/power/control delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/power/runtime_active_time delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/power/runtime_status delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/power/runtime_suspended_time delete mode 100644 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/uevent diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/async b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/async deleted file mode 100644 index 7a68b11..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/async +++ /dev/null @@ -1 +0,0 @@ -disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/autosuspend_delay_ms b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/autosuspend_delay_ms deleted file mode 100644 index e69de29..0000000 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/control b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/control deleted file mode 100644 index 865faf1..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/control +++ /dev/null @@ -1 +0,0 @@ -auto diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_active_kids b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_active_kids deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_active_kids +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_active_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_active_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_active_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_enabled b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_enabled deleted file mode 100644 index 7a68b11..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_enabled +++ /dev/null @@ -1 +0,0 @@ -disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_status b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_status deleted file mode 100644 index ad7ccf7..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_status +++ /dev/null @@ -1 +0,0 @@ -unsupported diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_suspended_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_suspended_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_suspended_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_usage b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_usage deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_usage +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/subsystem b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/uevent b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/uevent deleted file mode 100644 index ba52083..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/uevent +++ /dev/null @@ -1,8 +0,0 @@ -OF_NAME=cpu -OF_FULLNAME=/cpus/cpu@000 -OF_TYPE=cpu -OF_COMPATIBLE_0=apm,potenza -OF_COMPATIBLE_1=arm,armv8 -OF_COMPATIBLE_N=2 -MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002 - diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/async b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/async deleted file mode 100644 index 7a68b11..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/async +++ /dev/null @@ -1 +0,0 @@ -disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/autosuspend_delay_ms b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/autosuspend_delay_ms deleted file mode 100644 index e69de29..0000000 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/control b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/control deleted file mode 100644 index 865faf1..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/control +++ /dev/null @@ -1 +0,0 @@ -auto diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_active_kids b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_active_kids deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_active_kids +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_active_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_active_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_active_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_enabled b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_enabled deleted file mode 100644 index 7a68b11..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_enabled +++ /dev/null @@ -1 +0,0 @@ -disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_status b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_status deleted file mode 100644 index ad7ccf7..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_status +++ /dev/null @@ -1 +0,0 @@ -unsupported diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_suspended_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_suspended_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_suspended_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_usage b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_usage deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_usage +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/subsystem b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/uevent b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/uevent deleted file mode 100644 index 170ad0b..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/uevent +++ /dev/null @@ -1,8 +0,0 @@ -OF_NAME=cpu -OF_FULLNAME=/cpus/cpu@001 -OF_TYPE=cpu -OF_COMPATIBLE_0=apm,potenza -OF_COMPATIBLE_1=arm,armv8 -OF_COMPATIBLE_N=2 -MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002 - diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/async b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/async deleted file mode 100644 index 7a68b11..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/async +++ /dev/null @@ -1 +0,0 @@ -disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/autosuspend_delay_ms b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/autosuspend_delay_ms deleted file mode 100644 index e69de29..0000000 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/control b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/control deleted file mode 100644 index 865faf1..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/control +++ /dev/null @@ -1 +0,0 @@ -auto diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_active_kids b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_active_kids deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_active_kids +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_active_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_active_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_active_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_enabled b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_enabled deleted file mode 100644 index 7a68b11..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_enabled +++ /dev/null @@ -1 +0,0 @@ -disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_status b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_status deleted file mode 100644 index ad7ccf7..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_status +++ /dev/null @@ -1 +0,0 @@ -unsupported diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_suspended_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_suspended_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_suspended_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_usage b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_usage deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_usage +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/subsystem b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/uevent b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/uevent deleted file mode 100644 index 1f4dcb1..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/uevent +++ /dev/null @@ -1,8 +0,0 @@ -OF_NAME=cpu -OF_FULLNAME=/cpus/cpu@100 -OF_TYPE=cpu -OF_COMPATIBLE_0=apm,potenza -OF_COMPATIBLE_1=arm,armv8 -OF_COMPATIBLE_N=2 -MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002 - diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/async b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/async deleted file mode 100644 index 7a68b11..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/async +++ /dev/null @@ -1 +0,0 @@ -disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/autosuspend_delay_ms b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/autosuspend_delay_ms deleted file mode 100644 index e69de29..0000000 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/control b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/control deleted file mode 100644 index 865faf1..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/control +++ /dev/null @@ -1 +0,0 @@ -auto diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_active_kids b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_active_kids deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_active_kids +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_active_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_active_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_active_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_enabled b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_enabled deleted file mode 100644 index 7a68b11..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_enabled +++ /dev/null @@ -1 +0,0 @@ -disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_status b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_status deleted file mode 100644 index ad7ccf7..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_status +++ /dev/null @@ -1 +0,0 @@ -unsupported diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_suspended_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_suspended_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_suspended_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_usage b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_usage deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_usage +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/subsystem b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/uevent b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/uevent deleted file mode 100644 index 78869cc..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/uevent +++ /dev/null @@ -1,8 +0,0 @@ -OF_NAME=cpu -OF_FULLNAME=/cpus/cpu@101 -OF_TYPE=cpu -OF_COMPATIBLE_0=apm,potenza -OF_COMPATIBLE_1=arm,armv8 -OF_COMPATIBLE_N=2 -MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002 - diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/async b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/async deleted file mode 100644 index 7a68b11..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/async +++ /dev/null @@ -1 +0,0 @@ -disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/autosuspend_delay_ms b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/autosuspend_delay_ms deleted file mode 100644 index e69de29..0000000 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/control b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/control deleted file mode 100644 index 865faf1..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/control +++ /dev/null @@ -1 +0,0 @@ -auto diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_active_kids b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_active_kids deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_active_kids +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_active_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_active_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_active_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_enabled b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_enabled deleted file mode 100644 index 7a68b11..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_enabled +++ /dev/null @@ -1 +0,0 @@ -disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_status b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_status deleted file mode 100644 index ad7ccf7..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_status +++ /dev/null @@ -1 +0,0 @@ -unsupported diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_suspended_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_suspended_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_suspended_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_usage b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_usage deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_usage +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/subsystem b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/uevent b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/uevent deleted file mode 100644 index 5d3a708..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/uevent +++ /dev/null @@ -1,8 +0,0 @@ -OF_NAME=cpu -OF_FULLNAME=/cpus/cpu@200 -OF_TYPE=cpu -OF_COMPATIBLE_0=apm,potenza -OF_COMPATIBLE_1=arm,armv8 -OF_COMPATIBLE_N=2 -MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002 - diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/async b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/async deleted file mode 100644 index 7a68b11..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/async +++ /dev/null @@ -1 +0,0 @@ -disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/autosuspend_delay_ms b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/autosuspend_delay_ms deleted file mode 100644 index e69de29..0000000 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/control b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/control deleted file mode 100644 index 865faf1..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/control +++ /dev/null @@ -1 +0,0 @@ -auto diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_active_kids b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_active_kids deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_active_kids +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_active_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_active_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_active_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_enabled b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_enabled deleted file mode 100644 index 7a68b11..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_enabled +++ /dev/null @@ -1 +0,0 @@ -disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_status b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_status deleted file mode 100644 index ad7ccf7..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_status +++ /dev/null @@ -1 +0,0 @@ -unsupported diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_suspended_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_suspended_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_suspended_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_usage b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_usage deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_usage +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/subsystem b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/uevent b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/uevent deleted file mode 100644 index 00d94c3..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/uevent +++ /dev/null @@ -1,8 +0,0 @@ -OF_NAME=cpu -OF_FULLNAME=/cpus/cpu@201 -OF_TYPE=cpu -OF_COMPATIBLE_0=apm,potenza -OF_COMPATIBLE_1=arm,armv8 -OF_COMPATIBLE_N=2 -MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002 - diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/async b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/async deleted file mode 100644 index 7a68b11..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/async +++ /dev/null @@ -1 +0,0 @@ -disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/autosuspend_delay_ms b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/autosuspend_delay_ms deleted file mode 100644 index e69de29..0000000 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/control b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/control deleted file mode 100644 index 865faf1..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/control +++ /dev/null @@ -1 +0,0 @@ -auto diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_active_kids b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_active_kids deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_active_kids +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_active_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_active_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_active_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_enabled b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_enabled deleted file mode 100644 index 7a68b11..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_enabled +++ /dev/null @@ -1 +0,0 @@ -disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_status b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_status deleted file mode 100644 index ad7ccf7..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_status +++ /dev/null @@ -1 +0,0 @@ -unsupported diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_suspended_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_suspended_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_suspended_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_usage b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_usage deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_usage +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/subsystem b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/uevent b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/uevent deleted file mode 100644 index d612e9c..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/uevent +++ /dev/null @@ -1,8 +0,0 @@ -OF_NAME=cpu -OF_FULLNAME=/cpus/cpu@300 -OF_TYPE=cpu -OF_COMPATIBLE_0=apm,potenza -OF_COMPATIBLE_1=arm,armv8 -OF_COMPATIBLE_N=2 -MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002 - diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/async b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/async deleted file mode 100644 index 7a68b11..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/async +++ /dev/null @@ -1 +0,0 @@ -disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/autosuspend_delay_ms b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/autosuspend_delay_ms deleted file mode 100644 index e69de29..0000000 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/control b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/control deleted file mode 100644 index 865faf1..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/control +++ /dev/null @@ -1 +0,0 @@ -auto diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_active_kids b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_active_kids deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_active_kids +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_active_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_active_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_active_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_enabled b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_enabled deleted file mode 100644 index 7a68b11..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_enabled +++ /dev/null @@ -1 +0,0 @@ -disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_status b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_status deleted file mode 100644 index ad7ccf7..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_status +++ /dev/null @@ -1 +0,0 @@ -unsupported diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_suspended_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_suspended_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_suspended_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_usage b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_usage deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_usage +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/subsystem b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/uevent b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/uevent deleted file mode 100644 index c24e537..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/uevent +++ /dev/null @@ -1,8 +0,0 @@ -OF_NAME=cpu -OF_FULLNAME=/cpus/cpu@301 -OF_TYPE=cpu -OF_COMPATIBLE_0=apm,potenza -OF_COMPATIBLE_1=arm,armv8 -OF_COMPATIBLE_N=2 -MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002 - diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/power/async b/tests/nodeinfodata/linux-f21-mustang/cpu/power/async deleted file mode 100644 index 7a68b11..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/power/async +++ /dev/null @@ -1 +0,0 @@ -disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/power/autosuspend_delay_ms b/tests/nodeinfodata/linux-f21-mustang/cpu/power/autosuspend_delay_ms deleted file mode 100644 index e69de29..0000000 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/power/control b/tests/nodeinfodata/linux-f21-mustang/cpu/power/control deleted file mode 100644 index 865faf1..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/power/control +++ /dev/null @@ -1 +0,0 @@ -auto diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_active_kids b/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_active_kids deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_active_kids +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_active_time b/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_active_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_active_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_enabled b/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_enabled deleted file mode 100644 index 7a68b11..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_enabled +++ /dev/null @@ -1 +0,0 @@ -disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_status b/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_status deleted file mode 100644 index ad7ccf7..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_status +++ /dev/null @@ -1 +0,0 @@ -unsupported diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_suspended_time b/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_suspended_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_suspended_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_usage b/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_usage deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_usage +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/uevent b/tests/nodeinfodata/linux-f21-mustang/cpu/uevent deleted file mode 100644 index e69de29..0000000 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/firmware_node b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/firmware_node deleted file mode 120000 index 1e6224c..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/firmware_node +++ /dev/null @@ -1 +0,0 @@ -../../../LNXSYSTM:00/LNXSYBUS:00/ACPI0007:00 \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/power/autosuspend_delay_ms b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/power/autosuspend_delay_ms deleted file mode 100644 index e69de29..0000000 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/power/control b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/power/control deleted file mode 100644 index 865faf1..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/power/control +++ /dev/null @@ -1 +0,0 @@ -auto diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/power/runtime_active_time b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/power/runtime_active_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/power/runtime_active_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/power/runtime_status b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/power/runtime_status deleted file mode 100644 index ad7ccf7..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/power/runtime_status +++ /dev/null @@ -1 +0,0 @@ -unsupported diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/power/runtime_suspended_time b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/power/runtime_suspended_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/power/runtime_suspended_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/subsystem b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/uevent b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/uevent deleted file mode 100644 index dc40160..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/uevent +++ /dev/null @@ -1,2 +0,0 @@ -MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002 - diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/firmware_node b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/firmware_node deleted file mode 120000 index 63b63d0..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/firmware_node +++ /dev/null @@ -1 +0,0 @@ -../../../LNXSYSTM:00/LNXSYBUS:00/ACPI0007:01 \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/power/autosuspend_delay_ms b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/power/autosuspend_delay_ms deleted file mode 100644 index e69de29..0000000 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/power/control b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/power/control deleted file mode 100644 index 865faf1..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/power/control +++ /dev/null @@ -1 +0,0 @@ -auto diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/power/runtime_active_time b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/power/runtime_active_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/power/runtime_active_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/power/runtime_status b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/power/runtime_status deleted file mode 100644 index ad7ccf7..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/power/runtime_status +++ /dev/null @@ -1 +0,0 @@ -unsupported diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/power/runtime_suspended_time b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/power/runtime_suspended_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/power/runtime_suspended_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/subsystem b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/uevent b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/uevent deleted file mode 100644 index dc40160..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/uevent +++ /dev/null @@ -1,2 +0,0 @@ -MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002 - diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/firmware_node b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/firmware_node deleted file mode 120000 index 85914d0..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/firmware_node +++ /dev/null @@ -1 +0,0 @@ -../../../LNXSYSTM:00/LNXSYBUS:00/ACPI0007:02 \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/power/autosuspend_delay_ms b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/power/autosuspend_delay_ms deleted file mode 100644 index e69de29..0000000 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/power/control b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/power/control deleted file mode 100644 index 865faf1..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/power/control +++ /dev/null @@ -1 +0,0 @@ -auto diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/power/runtime_active_time b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/power/runtime_active_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/power/runtime_active_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/power/runtime_status b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/power/runtime_status deleted file mode 100644 index ad7ccf7..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/power/runtime_status +++ /dev/null @@ -1 +0,0 @@ -unsupported diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/power/runtime_suspended_time b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/power/runtime_suspended_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/power/runtime_suspended_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/subsystem b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/uevent b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/uevent deleted file mode 100644 index dc40160..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/uevent +++ /dev/null @@ -1,2 +0,0 @@ -MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002 - diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/firmware_node b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/firmware_node deleted file mode 120000 index cfa456c..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/firmware_node +++ /dev/null @@ -1 +0,0 @@ -../../../LNXSYSTM:00/LNXSYBUS:00/ACPI0007:03 \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/power/autosuspend_delay_ms b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/power/autosuspend_delay_ms deleted file mode 100644 index e69de29..0000000 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/power/control b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/power/control deleted file mode 100644 index 865faf1..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/power/control +++ /dev/null @@ -1 +0,0 @@ -auto diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/power/runtime_active_time b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/power/runtime_active_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/power/runtime_active_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/power/runtime_status b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/power/runtime_status deleted file mode 100644 index ad7ccf7..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/power/runtime_status +++ /dev/null @@ -1 +0,0 @@ -unsupported diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/power/runtime_suspended_time b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/power/runtime_suspended_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/power/runtime_suspended_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/subsystem b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/uevent b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/uevent deleted file mode 100644 index dc40160..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/uevent +++ /dev/null @@ -1,2 +0,0 @@ -MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002 - diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/firmware_node b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/firmware_node deleted file mode 120000 index b7ae1a3..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/firmware_node +++ /dev/null @@ -1 +0,0 @@ -../../../LNXSYSTM:00/LNXSYBUS:00/ACPI0007:04 \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/power/autosuspend_delay_ms b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/power/autosuspend_delay_ms deleted file mode 100644 index e69de29..0000000 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/power/control b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/power/control deleted file mode 100644 index 865faf1..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/power/control +++ /dev/null @@ -1 +0,0 @@ -auto diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/power/runtime_active_time b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/power/runtime_active_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/power/runtime_active_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/power/runtime_status b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/power/runtime_status deleted file mode 100644 index ad7ccf7..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/power/runtime_status +++ /dev/null @@ -1 +0,0 @@ -unsupported diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/power/runtime_suspended_time b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/power/runtime_suspended_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/power/runtime_suspended_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/subsystem b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/uevent b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/uevent deleted file mode 100644 index dc40160..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/uevent +++ /dev/null @@ -1,2 +0,0 @@ -MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002 - diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/firmware_node b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/firmware_node deleted file mode 120000 index b25a125..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/firmware_node +++ /dev/null @@ -1 +0,0 @@ -../../../LNXSYSTM:00/LNXSYBUS:00/ACPI0007:05 \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/power/autosuspend_delay_ms b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/power/autosuspend_delay_ms deleted file mode 100644 index e69de29..0000000 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/power/control b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/power/control deleted file mode 100644 index 865faf1..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/power/control +++ /dev/null @@ -1 +0,0 @@ -auto diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/power/runtime_active_time b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/power/runtime_active_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/power/runtime_active_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/power/runtime_status b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/power/runtime_status deleted file mode 100644 index ad7ccf7..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/power/runtime_status +++ /dev/null @@ -1 +0,0 @@ -unsupported diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/power/runtime_suspended_time b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/power/runtime_suspended_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/power/runtime_suspended_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/subsystem b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/uevent b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/uevent deleted file mode 100644 index dc40160..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/uevent +++ /dev/null @@ -1,2 +0,0 @@ -MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002 - diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/firmware_node b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/firmware_node deleted file mode 120000 index 1dd9cb9..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/firmware_node +++ /dev/null @@ -1 +0,0 @@ -../../../LNXSYSTM:00/LNXSYBUS:00/ACPI0007:06 \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/power/autosuspend_delay_ms b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/power/autosuspend_delay_ms deleted file mode 100644 index e69de29..0000000 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/power/control b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/power/control deleted file mode 100644 index 865faf1..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/power/control +++ /dev/null @@ -1 +0,0 @@ -auto diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/power/runtime_active_time b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/power/runtime_active_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/power/runtime_active_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/power/runtime_status b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/power/runtime_status deleted file mode 100644 index ad7ccf7..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/power/runtime_status +++ /dev/null @@ -1 +0,0 @@ -unsupported diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/power/runtime_suspended_time b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/power/runtime_suspended_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/power/runtime_suspended_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/subsystem b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/uevent b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/uevent deleted file mode 100644 index dc40160..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/uevent +++ /dev/null @@ -1,2 +0,0 @@ -MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002 - diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/firmware_node b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/firmware_node deleted file mode 120000 index a1a9eed..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/firmware_node +++ /dev/null @@ -1 +0,0 @@ -../../../LNXSYSTM:00/LNXSYBUS:00/ACPI0007:07 \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/power/autosuspend_delay_ms b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/power/autosuspend_delay_ms deleted file mode 100644 index e69de29..0000000 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/power/control b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/power/control deleted file mode 100644 index 865faf1..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/power/control +++ /dev/null @@ -1 +0,0 @@ -auto diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/power/runtime_active_time b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/power/runtime_active_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/power/runtime_active_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/power/runtime_status b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/power/runtime_status deleted file mode 100644 index ad7ccf7..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/power/runtime_status +++ /dev/null @@ -1 +0,0 @@ -unsupported diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/power/runtime_suspended_time b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/power/runtime_suspended_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/power/runtime_suspended_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/subsystem b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/uevent b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/uevent deleted file mode 100644 index dc40160..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/uevent +++ /dev/null @@ -1,2 +0,0 @@ -MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002 - diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/power/autosuspend_delay_ms b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/power/autosuspend_delay_ms deleted file mode 100644 index e69de29..0000000 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/power/control b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/power/control deleted file mode 100644 index 865faf1..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/power/control +++ /dev/null @@ -1 +0,0 @@ -auto diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/power/runtime_active_time b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/power/runtime_active_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/power/runtime_active_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/power/runtime_status b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/power/runtime_status deleted file mode 100644 index ad7ccf7..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/power/runtime_status +++ /dev/null @@ -1 +0,0 @@ -unsupported diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/power/runtime_suspended_time b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/power/runtime_suspended_time deleted file mode 100644 index 573541a..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/power/runtime_suspended_time +++ /dev/null @@ -1 +0,0 @@ -0 diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/uevent b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/uevent deleted file mode 100644 index e69de29..0000000 -- 2.0.5

3 2

[libvirt] [PATCH] nodeinfodata: Remove broken symlinks
by Michal Privoznik 01 Apr '15

01 Apr '15

The 7c3c7f217ebae5 commit introduced a nodeinfo test. In order to do that, some parts of sysfs had to be copied. However, sysfs is full of symlinks, so during copying some symlinks broke. Remove them, as on different systems they can point to different files or be broken. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/subsystem | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/subsystem | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/subsystem | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/subsystem | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/subsystem | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/subsystem | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/subsystem | 1 - tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/subsystem | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/firmware_node | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/subsystem | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/firmware_node | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/subsystem | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/firmware_node | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/subsystem | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/firmware_node | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/subsystem | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/firmware_node | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/subsystem | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/firmware_node | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/subsystem | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/firmware_node | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/subsystem | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/firmware_node | 1 - tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/subsystem | 1 - 24 files changed, 24 deletions(-) delete mode 120000 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/subsystem delete mode 120000 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/subsystem delete mode 120000 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/subsystem delete mode 120000 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/subsystem delete mode 120000 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/subsystem delete mode 120000 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/subsystem delete mode 120000 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/subsystem delete mode 120000 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/subsystem delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/firmware_node delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/subsystem delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/firmware_node delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/subsystem delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/firmware_node delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/subsystem delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/firmware_node delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/subsystem delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/firmware_node delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/subsystem delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/firmware_node delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/subsystem delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/firmware_node delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/subsystem delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/firmware_node delete mode 120000 tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/subsystem diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/subsystem b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/subsystem b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/subsystem b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/subsystem b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/subsystem b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/subsystem b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/subsystem b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/subsystem b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/firmware_node b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/firmware_node deleted file mode 120000 index 1e6224c..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/firmware_node +++ /dev/null @@ -1 +0,0 @@ -../../../LNXSYSTM:00/LNXSYBUS:00/ACPI0007:00 \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/subsystem b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu0/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/firmware_node b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/firmware_node deleted file mode 120000 index 63b63d0..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/firmware_node +++ /dev/null @@ -1 +0,0 @@ -../../../LNXSYSTM:00/LNXSYBUS:00/ACPI0007:01 \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/subsystem b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu1/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/firmware_node b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/firmware_node deleted file mode 120000 index 85914d0..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/firmware_node +++ /dev/null @@ -1 +0,0 @@ -../../../LNXSYSTM:00/LNXSYBUS:00/ACPI0007:02 \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/subsystem b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu2/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/firmware_node b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/firmware_node deleted file mode 120000 index cfa456c..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/firmware_node +++ /dev/null @@ -1 +0,0 @@ -../../../LNXSYSTM:00/LNXSYBUS:00/ACPI0007:03 \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/subsystem b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu3/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/firmware_node b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/firmware_node deleted file mode 120000 index b7ae1a3..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/firmware_node +++ /dev/null @@ -1 +0,0 @@ -../../../LNXSYSTM:00/LNXSYBUS:00/ACPI0007:04 \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/subsystem b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu4/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/firmware_node b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/firmware_node deleted file mode 120000 index b25a125..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/firmware_node +++ /dev/null @@ -1 +0,0 @@ -../../../LNXSYSTM:00/LNXSYBUS:00/ACPI0007:05 \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/subsystem b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu5/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/firmware_node b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/firmware_node deleted file mode 120000 index 1dd9cb9..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/firmware_node +++ /dev/null @@ -1 +0,0 @@ -../../../LNXSYSTM:00/LNXSYBUS:00/ACPI0007:06 \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/subsystem b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu6/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/firmware_node b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/firmware_node deleted file mode 120000 index a1a9eed..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/firmware_node +++ /dev/null @@ -1 +0,0 @@ -../../../LNXSYSTM:00/LNXSYBUS:00/ACPI0007:07 \ No newline at end of file diff --git a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/subsystem b/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/subsystem deleted file mode 120000 index 758c291..0000000 --- a/tests/nodeinfodata/linux-rhelsa-3.19.0-mustang/cpu/cpu7/subsystem +++ /dev/null @@ -1 +0,0 @@ -../../../../bus/cpu \ No newline at end of file -- 2.0.5

2 3

[libvirt] [PATCH 0/3] storage: handle scsi/iscsi error paths better
by John Ferlan 01 Apr '15

01 Apr '15

Adjust error path logic for processing LU's in order to better ascertain the correct cause for failure. The first two patches are merely setting for the third one which determines that the pool definition used a non existent path in the configuration thus no 'real' targets were able to be created. John Ferlan (3): iscsi: Check for presence of error before creating new one scsi: Adjust return values from processLU scsi: Check for invalid target.path after processLU failure src/storage/storage_backend_iscsi.c | 5 +++-- src/storage/storage_backend_scsi.c | 13 +++++++++++-- 2 files changed, 14 insertions(+), 4 deletions(-) -- 2.1.0

2 7

[libvirt] [PATCH] Bug 1086726: Reworked error messages in libvirt.c, libvirt-domain.c removing uses of __FUNCTION__, except one
by Noella Ashu 01 Apr '15

01 Apr '15

--- src/libvirt-domain.c | 13 +++++++------ src/libvirt.c | 4 ++-- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index f1608dc..4a45b9e 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -2613,7 +2613,7 @@ virDomainGetXMLDesc(virDomainPtr domain, unsigned int flags) if ((conn->flags & VIR_CONNECT_RO) && (flags & (VIR_DOMAIN_XML_SECURE | VIR_DOMAIN_XML_MIGRATABLE))) { virReportError(VIR_ERR_OPERATION_DENIED, "%s", - _("virDomainGetXMLDesc with secure flag")); + _("Invalid secure flag for XML domain description")); goto error; } @@ -2793,7 +2793,7 @@ virDomainMigrateVersion1(virDomainPtr domain, if (uri == NULL && uri_out == NULL) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("domainMigratePrepare did not set uri")); + _("unset uri for domain migration preparation")); goto done; } if (uri_out) @@ -2916,7 +2916,7 @@ virDomainMigrateVersion2(virDomainPtr domain, if (uri == NULL && uri_out == NULL) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("domainMigratePrepare2 did not set uri")); + _("unset uri for domain migration preparation2")); cancelled = 1; /* Make sure Finish doesn't overwrite the error */ orig_err = virSaveLastError(); @@ -3124,7 +3124,7 @@ virDomainMigrateVersion3Full(virDomainPtr domain, virTypedParamsGetString(params, nparams, VIR_MIGRATE_PARAM_URI, &uri) <= 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("domainMigratePrepare3 did not set uri")); + _("unset uri for domain migration preparation3")); cancelled = 1; orig_err = virSaveLastError(); goto finish; @@ -11285,7 +11285,7 @@ virDomainListGetStats(virDomainPtr *doms, if (!*doms) { virReportError(VIR_ERR_INVALID_ARG, - _("doms array in %s must contain at least one domain"), + _("doms array must contain at least one domain in %s"), __FUNCTION__); goto cleanup; } @@ -11503,7 +11503,8 @@ virDomainInterfaceAddresses(virDomainPtr dom, return ret; } - virReportError(VIR_ERR_NO_SUPPORT, __FUNCTION__); + virReportError(VIR_ERR_NO_SUPPORT, "%s", + _("No interface address support for domain object")); error: virDispatchError(dom->conn); diff --git a/src/libvirt.c b/src/libvirt.c index c8a5834..0109734 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -558,7 +558,7 @@ virSetSharedInterfaceDriver(virInterfaceDriverPtr driver) if (virSharedInterfaceDriver) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("A interface driver is already registered")); + _("An interface driver is already registered")); return -1; } @@ -1211,7 +1211,7 @@ do_open(const char *name, if (!ret->driver) { /* If we reach here, then all drivers declined the connection. */ - virReportError(VIR_ERR_NO_CONNECT, "%s", NULLSTR(name)); + virReportError(VIR_ERR_NO_CONNECT, "%s", _("All device drivers decline connection")); goto failed; } -- 2.1.0

2 2

[libvirt] [PATCH] virsh: fix forget jump to clean up when set a big bandwidth
by Luyao Huang 01 Apr '15

01 Apr '15

We already have a check for this, just add a jump to cleanup and change to use vshError instead of virReportError. Signed-off-by: Luyao Huang <lhuang(a)redhat.com> --- tools/virsh-domain.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 1d8225c..33fbf9c 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -2253,9 +2253,8 @@ cmdBlockCopy(vshControl *ctl, const vshCmd *cmd) * ullong bytes/s; make sure we don't overflow */ unsigned long long limit = MIN(ULONG_MAX, ULLONG_MAX >> 20); if (bandwidth > limit) { - virReportError(VIR_ERR_OVERFLOW, - _("bandwidth must be less than %llu"), - ULLONG_MAX >> 20); + vshError(ctl, _("bandwidth must be less than %llu"), limit); + goto cleanup; } if (virTypedParameterAssign(&params[nparams++], VIR_DOMAIN_BLOCK_COPY_BANDWIDTH, -- 1.8.3.1

4 4

[libvirt] [PATCH 1/2] tests: nodeinfo: Test F21 aarch64 on APM mustang
by Cole Robinson 01 Apr '15

01 Apr '15

--- tests/nodeinfodata/linux-aarch64-f21-mustang.cpuinfo | 17 +++++++++++++++++ tests/nodeinfodata/linux-aarch64-f21-mustang.expected | 1 + tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/online | 1 + .../nodeinfodata/linux-f21-mustang/cpu/cpu0/power/async | 1 + .../cpu/cpu0/power/autosuspend_delay_ms | 0 .../linux-f21-mustang/cpu/cpu0/power/control | 1 + .../cpu/cpu0/power/runtime_active_kids | 1 + .../cpu/cpu0/power/runtime_active_time | 1 + .../linux-f21-mustang/cpu/cpu0/power/runtime_enabled | 1 + .../linux-f21-mustang/cpu/cpu0/power/runtime_status | 1 + .../cpu/cpu0/power/runtime_suspended_time | 1 + .../linux-f21-mustang/cpu/cpu0/power/runtime_usage | 1 + tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/subsystem | 1 + .../linux-f21-mustang/cpu/cpu0/topology/core_id | 1 + .../linux-f21-mustang/cpu/cpu0/topology/core_siblings | 1 + .../cpu/cpu0/topology/core_siblings_list | 1 + .../cpu/cpu0/topology/physical_package_id | 1 + .../linux-f21-mustang/cpu/cpu0/topology/thread_siblings | 1 + .../cpu/cpu0/topology/thread_siblings_list | 1 + tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/uevent | 8 ++++++++ tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/online | 1 + .../nodeinfodata/linux-f21-mustang/cpu/cpu1/power/async | 1 + .../cpu/cpu1/power/autosuspend_delay_ms | 0 .../linux-f21-mustang/cpu/cpu1/power/control | 1 + .../cpu/cpu1/power/runtime_active_kids | 1 + .../cpu/cpu1/power/runtime_active_time | 1 + .../linux-f21-mustang/cpu/cpu1/power/runtime_enabled | 1 + .../linux-f21-mustang/cpu/cpu1/power/runtime_status | 1 + .../cpu/cpu1/power/runtime_suspended_time | 1 + .../linux-f21-mustang/cpu/cpu1/power/runtime_usage | 1 + tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/subsystem | 1 + .../linux-f21-mustang/cpu/cpu1/topology/core_id | 1 + .../linux-f21-mustang/cpu/cpu1/topology/core_siblings | 1 + .../cpu/cpu1/topology/core_siblings_list | 1 + .../cpu/cpu1/topology/physical_package_id | 1 + .../linux-f21-mustang/cpu/cpu1/topology/thread_siblings | 1 + .../cpu/cpu1/topology/thread_siblings_list | 1 + tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/uevent | 8 ++++++++ tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/online | 1 + .../nodeinfodata/linux-f21-mustang/cpu/cpu2/power/async | 1 + .../cpu/cpu2/power/autosuspend_delay_ms | 0 .../linux-f21-mustang/cpu/cpu2/power/control | 1 + .../cpu/cpu2/power/runtime_active_kids | 1 + .../cpu/cpu2/power/runtime_active_time | 1 + .../linux-f21-mustang/cpu/cpu2/power/runtime_enabled | 1 + .../linux-f21-mustang/cpu/cpu2/power/runtime_status | 1 + .../cpu/cpu2/power/runtime_suspended_time | 1 + .../linux-f21-mustang/cpu/cpu2/power/runtime_usage | 1 + tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/subsystem | 1 + .../linux-f21-mustang/cpu/cpu2/topology/core_id | 1 + .../linux-f21-mustang/cpu/cpu2/topology/core_siblings | 1 + .../cpu/cpu2/topology/core_siblings_list | 1 + .../cpu/cpu2/topology/physical_package_id | 1 + .../linux-f21-mustang/cpu/cpu2/topology/thread_siblings | 1 + .../cpu/cpu2/topology/thread_siblings_list | 1 + tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/uevent | 8 ++++++++ tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/online | 1 + .../nodeinfodata/linux-f21-mustang/cpu/cpu3/power/async | 1 + .../cpu/cpu3/power/autosuspend_delay_ms | 0 .../linux-f21-mustang/cpu/cpu3/power/control | 1 + .../cpu/cpu3/power/runtime_active_kids | 1 + .../cpu/cpu3/power/runtime_active_time | 1 + .../linux-f21-mustang/cpu/cpu3/power/runtime_enabled | 1 + .../linux-f21-mustang/cpu/cpu3/power/runtime_status | 1 + .../cpu/cpu3/power/runtime_suspended_time | 1 + .../linux-f21-mustang/cpu/cpu3/power/runtime_usage | 1 + tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/subsystem | 1 + .../linux-f21-mustang/cpu/cpu3/topology/core_id | 1 + .../linux-f21-mustang/cpu/cpu3/topology/core_siblings | 1 + .../cpu/cpu3/topology/core_siblings_list | 1 + .../cpu/cpu3/topology/physical_package_id | 1 + .../linux-f21-mustang/cpu/cpu3/topology/thread_siblings | 1 + .../cpu/cpu3/topology/thread_siblings_list | 1 + tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/uevent | 8 ++++++++ tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/online | 1 + .../nodeinfodata/linux-f21-mustang/cpu/cpu4/power/async | 1 + .../cpu/cpu4/power/autosuspend_delay_ms | 0 .../linux-f21-mustang/cpu/cpu4/power/control | 1 + .../cpu/cpu4/power/runtime_active_kids | 1 + .../cpu/cpu4/power/runtime_active_time | 1 + .../linux-f21-mustang/cpu/cpu4/power/runtime_enabled | 1 + .../linux-f21-mustang/cpu/cpu4/power/runtime_status | 1 + .../cpu/cpu4/power/runtime_suspended_time | 1 + .../linux-f21-mustang/cpu/cpu4/power/runtime_usage | 1 + tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/subsystem | 1 + .../linux-f21-mustang/cpu/cpu4/topology/core_id | 1 + .../linux-f21-mustang/cpu/cpu4/topology/core_siblings | 1 + .../cpu/cpu4/topology/core_siblings_list | 1 + .../cpu/cpu4/topology/physical_package_id | 1 + .../linux-f21-mustang/cpu/cpu4/topology/thread_siblings | 1 + .../cpu/cpu4/topology/thread_siblings_list | 1 + tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/uevent | 8 ++++++++ tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/online | 1 + .../nodeinfodata/linux-f21-mustang/cpu/cpu5/power/async | 1 + .../cpu/cpu5/power/autosuspend_delay_ms | 0 .../linux-f21-mustang/cpu/cpu5/power/control | 1 + .../cpu/cpu5/power/runtime_active_kids | 1 + .../cpu/cpu5/power/runtime_active_time | 1 + .../linux-f21-mustang/cpu/cpu5/power/runtime_enabled | 1 + .../linux-f21-mustang/cpu/cpu5/power/runtime_status | 1 + .../cpu/cpu5/power/runtime_suspended_time | 1 + .../linux-f21-mustang/cpu/cpu5/power/runtime_usage | 1 + tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/subsystem | 1 + .../linux-f21-mustang/cpu/cpu5/topology/core_id | 1 + .../linux-f21-mustang/cpu/cpu5/topology/core_siblings | 1 + .../cpu/cpu5/topology/core_siblings_list | 1 + .../cpu/cpu5/topology/physical_package_id | 1 + .../linux-f21-mustang/cpu/cpu5/topology/thread_siblings | 1 + .../cpu/cpu5/topology/thread_siblings_list | 1 + tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/uevent | 8 ++++++++ tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/online | 1 + .../nodeinfodata/linux-f21-mustang/cpu/cpu6/power/async | 1 + .../cpu/cpu6/power/autosuspend_delay_ms | 0 .../linux-f21-mustang/cpu/cpu6/power/control | 1 + .../cpu/cpu6/power/runtime_active_kids | 1 + .../cpu/cpu6/power/runtime_active_time | 1 + .../linux-f21-mustang/cpu/cpu6/power/runtime_enabled | 1 + .../linux-f21-mustang/cpu/cpu6/power/runtime_status | 1 + .../cpu/cpu6/power/runtime_suspended_time | 1 + .../linux-f21-mustang/cpu/cpu6/power/runtime_usage | 1 + tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/subsystem | 1 + .../linux-f21-mustang/cpu/cpu6/topology/core_id | 1 + .../linux-f21-mustang/cpu/cpu6/topology/core_siblings | 1 + .../cpu/cpu6/topology/core_siblings_list | 1 + .../cpu/cpu6/topology/physical_package_id | 1 + .../linux-f21-mustang/cpu/cpu6/topology/thread_siblings | 1 + .../cpu/cpu6/topology/thread_siblings_list | 1 + tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/uevent | 8 ++++++++ tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/online | 1 + .../nodeinfodata/linux-f21-mustang/cpu/cpu7/power/async | 1 + .../cpu/cpu7/power/autosuspend_delay_ms | 0 .../linux-f21-mustang/cpu/cpu7/power/control | 1 + .../cpu/cpu7/power/runtime_active_kids | 1 + .../cpu/cpu7/power/runtime_active_time | 1 + .../linux-f21-mustang/cpu/cpu7/power/runtime_enabled | 1 + .../linux-f21-mustang/cpu/cpu7/power/runtime_status | 1 + .../cpu/cpu7/power/runtime_suspended_time | 1 + .../linux-f21-mustang/cpu/cpu7/power/runtime_usage | 1 + tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/subsystem | 1 + .../linux-f21-mustang/cpu/cpu7/topology/core_id | 1 + .../linux-f21-mustang/cpu/cpu7/topology/core_siblings | 1 + .../cpu/cpu7/topology/core_siblings_list | 1 + .../cpu/cpu7/topology/physical_package_id | 1 + .../linux-f21-mustang/cpu/cpu7/topology/thread_siblings | 1 + .../cpu/cpu7/topology/thread_siblings_list | 1 + tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/uevent | 8 ++++++++ tests/nodeinfodata/linux-f21-mustang/cpu/kernel_max | 1 + tests/nodeinfodata/linux-f21-mustang/cpu/modalias | 1 + tests/nodeinfodata/linux-f21-mustang/cpu/offline | 1 + tests/nodeinfodata/linux-f21-mustang/cpu/online | 1 + tests/nodeinfodata/linux-f21-mustang/cpu/possible | 1 + tests/nodeinfodata/linux-f21-mustang/cpu/power/async | 1 + .../linux-f21-mustang/cpu/power/autosuspend_delay_ms | 0 tests/nodeinfodata/linux-f21-mustang/cpu/power/control | 1 + .../linux-f21-mustang/cpu/power/runtime_active_kids | 1 + .../linux-f21-mustang/cpu/power/runtime_active_time | 1 + .../linux-f21-mustang/cpu/power/runtime_enabled | 1 + .../linux-f21-mustang/cpu/power/runtime_status | 1 + .../linux-f21-mustang/cpu/power/runtime_suspended_time | 1 + .../linux-f21-mustang/cpu/power/runtime_usage | 1 + tests/nodeinfodata/linux-f21-mustang/cpu/present | 1 + tests/nodeinfodata/linux-f21-mustang/cpu/uevent | 0 tests/nodeinfotest.c | 1 + 163 files changed, 225 insertions(+) create mode 100644 tests/nodeinfodata/linux-aarch64-f21-mustang.cpuinfo create mode 100644 tests/nodeinfodata/linux-aarch64-f21-mustang.expected create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/online create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/async create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/autosuspend_delay_ms create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/control create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_active_kids create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_active_time create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_enabled create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_status create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_suspended_time create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_usage create mode 120000 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/subsystem create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/topology/core_id create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/uevent create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/online create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/async create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/autosuspend_delay_ms create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/control create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_active_kids create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_active_time create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_enabled create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_status create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_suspended_time create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_usage create mode 120000 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/subsystem create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/topology/core_id create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/uevent create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/online create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/async create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/autosuspend_delay_ms create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/control create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_active_kids create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_active_time create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_enabled create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_status create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_suspended_time create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_usage create mode 120000 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/subsystem create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/topology/core_id create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/uevent create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/online create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/async create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/autosuspend_delay_ms create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/control create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_active_kids create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_active_time create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_enabled create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_status create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_suspended_time create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_usage create mode 120000 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/subsystem create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/topology/core_id create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/uevent create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/online create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/async create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/autosuspend_delay_ms create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/control create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_active_kids create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_active_time create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_enabled create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_status create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_suspended_time create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_usage create mode 120000 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/subsystem create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/topology/core_id create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/uevent create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/online create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/async create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/autosuspend_delay_ms create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/control create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_active_kids create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_active_time create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_enabled create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_status create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_suspended_time create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_usage create mode 120000 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/subsystem create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/topology/core_id create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/uevent create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/online create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/async create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/autosuspend_delay_ms create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/control create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_active_kids create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_active_time create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_enabled create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_status create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_suspended_time create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_usage create mode 120000 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/subsystem create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/topology/core_id create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/uevent create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/online create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/async create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/autosuspend_delay_ms create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/control create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_active_kids create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_active_time create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_enabled create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_status create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_suspended_time create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_usage create mode 120000 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/subsystem create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/topology/core_id create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/uevent create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/kernel_max create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/modalias create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/offline create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/online create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/possible create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/power/async create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/power/autosuspend_delay_ms create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/power/control create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_active_kids create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_active_time create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_enabled create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_status create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_suspended_time create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_usage create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/present create mode 100644 tests/nodeinfodata/linux-f21-mustang/cpu/uevent diff --git a/tests/nodeinfodata/linux-aarch64-f21-mustang.cpuinfo b/tests/nodeinfodata/linux-aarch64-f21-mustang.cpuinfo new file mode 100644 index 0000000..b969946 --- /dev/null +++ b/tests/nodeinfodata/linux-aarch64-f21-mustang.cpuinfo @@ -0,0 +1,17 @@ +Processor : AArch64 Processor rev 0 (aarch64) +processor : 0 +processor : 1 +processor : 2 +processor : 3 +processor : 4 +processor : 5 +processor : 6 +processor : 7 +Features : fp asimd evtstrm +CPU implementer : 0x50 +CPU architecture: AArch64 +CPU variant : 0x0 +CPU part : 0x000 +CPU revision : 0 + +Hardware : APM X-Gene Mustang board diff --git a/tests/nodeinfodata/linux-aarch64-f21-mustang.expected b/tests/nodeinfodata/linux-aarch64-f21-mustang.expected new file mode 100644 index 0000000..ac950dc --- /dev/null +++ b/tests/nodeinfodata/linux-aarch64-f21-mustang.expected @@ -0,0 +1 @@ +CPUs: 8/8, MHz: 0, Nodes: 1, Sockets: 4, Cores: 2, Threads: 1 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/online b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/online new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/online @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/async b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/async new file mode 100644 index 0000000..7a68b11 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/async @@ -0,0 +1 @@ +disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/autosuspend_delay_ms b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/autosuspend_delay_ms new file mode 100644 index 0000000..e69de29 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/control b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/control new file mode 100644 index 0000000..865faf1 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/control @@ -0,0 +1 @@ +auto diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_active_kids b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_active_kids new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_active_kids @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_active_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_active_time new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_active_time @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_enabled b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_enabled new file mode 100644 index 0000000..7a68b11 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_enabled @@ -0,0 +1 @@ +disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_status b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_status new file mode 100644 index 0000000..ad7ccf7 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_status @@ -0,0 +1 @@ +unsupported diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_suspended_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_suspended_time new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_suspended_time @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_usage b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_usage new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/power/runtime_usage @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/subsystem b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/subsystem new file mode 120000 index 0000000..758c291 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/subsystem @@ -0,0 +1 @@ +../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/topology/core_id b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/topology/core_id new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/topology/core_id @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/topology/core_siblings b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/topology/core_siblings new file mode 100644 index 0000000..75016ea --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/topology/core_siblings @@ -0,0 +1 @@ +03 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/topology/core_siblings_list b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/topology/core_siblings_list new file mode 100644 index 0000000..8b0fab8 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/topology/core_siblings_list @@ -0,0 +1 @@ +0-1 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/topology/physical_package_id b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/topology/physical_package_id new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/topology/physical_package_id @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/topology/thread_siblings b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/topology/thread_siblings new file mode 100644 index 0000000..8a0f05e --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/topology/thread_siblings @@ -0,0 +1 @@ +01 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/topology/thread_siblings_list b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/topology/thread_siblings_list new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/topology/thread_siblings_list @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/uevent b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/uevent new file mode 100644 index 0000000..ba52083 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/uevent @@ -0,0 +1,8 @@ +OF_NAME=cpu +OF_FULLNAME=/cpus/cpu@000 +OF_TYPE=cpu +OF_COMPATIBLE_0=apm,potenza +OF_COMPATIBLE_1=arm,armv8 +OF_COMPATIBLE_N=2 +MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002 + diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/online b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/online new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/online @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/async b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/async new file mode 100644 index 0000000..7a68b11 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/async @@ -0,0 +1 @@ +disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/autosuspend_delay_ms b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/autosuspend_delay_ms new file mode 100644 index 0000000..e69de29 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/control b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/control new file mode 100644 index 0000000..865faf1 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/control @@ -0,0 +1 @@ +auto diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_active_kids b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_active_kids new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_active_kids @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_active_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_active_time new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_active_time @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_enabled b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_enabled new file mode 100644 index 0000000..7a68b11 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_enabled @@ -0,0 +1 @@ +disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_status b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_status new file mode 100644 index 0000000..ad7ccf7 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_status @@ -0,0 +1 @@ +unsupported diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_suspended_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_suspended_time new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_suspended_time @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_usage b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_usage new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/power/runtime_usage @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/subsystem b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/subsystem new file mode 120000 index 0000000..758c291 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/subsystem @@ -0,0 +1 @@ +../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/topology/core_id b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/topology/core_id new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/topology/core_id @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/topology/core_siblings b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/topology/core_siblings new file mode 100644 index 0000000..75016ea --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/topology/core_siblings @@ -0,0 +1 @@ +03 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/topology/core_siblings_list b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/topology/core_siblings_list new file mode 100644 index 0000000..8b0fab8 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/topology/core_siblings_list @@ -0,0 +1 @@ +0-1 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/topology/physical_package_id b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/topology/physical_package_id new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/topology/physical_package_id @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/topology/thread_siblings b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/topology/thread_siblings new file mode 100644 index 0000000..9e22bcb --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/topology/thread_siblings @@ -0,0 +1 @@ +02 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/topology/thread_siblings_list b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/topology/thread_siblings_list new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/topology/thread_siblings_list @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/uevent b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/uevent new file mode 100644 index 0000000..170ad0b --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu1/uevent @@ -0,0 +1,8 @@ +OF_NAME=cpu +OF_FULLNAME=/cpus/cpu@001 +OF_TYPE=cpu +OF_COMPATIBLE_0=apm,potenza +OF_COMPATIBLE_1=arm,armv8 +OF_COMPATIBLE_N=2 +MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002 + diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/online b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/online new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/online @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/async b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/async new file mode 100644 index 0000000..7a68b11 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/async @@ -0,0 +1 @@ +disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/autosuspend_delay_ms b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/autosuspend_delay_ms new file mode 100644 index 0000000..e69de29 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/control b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/control new file mode 100644 index 0000000..865faf1 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/control @@ -0,0 +1 @@ +auto diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_active_kids b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_active_kids new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_active_kids @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_active_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_active_time new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_active_time @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_enabled b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_enabled new file mode 100644 index 0000000..7a68b11 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_enabled @@ -0,0 +1 @@ +disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_status b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_status new file mode 100644 index 0000000..ad7ccf7 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_status @@ -0,0 +1 @@ +unsupported diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_suspended_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_suspended_time new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_suspended_time @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_usage b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_usage new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/power/runtime_usage @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/subsystem b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/subsystem new file mode 120000 index 0000000..758c291 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/subsystem @@ -0,0 +1 @@ +../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/topology/core_id b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/topology/core_id new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/topology/core_id @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/topology/core_siblings b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/topology/core_siblings new file mode 100644 index 0000000..8ac4b4c --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/topology/core_siblings @@ -0,0 +1 @@ +0c diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/topology/core_siblings_list b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/topology/core_siblings_list new file mode 100644 index 0000000..7a98575 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/topology/core_siblings_list @@ -0,0 +1 @@ +2-3 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/topology/physical_package_id b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/topology/physical_package_id new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/topology/physical_package_id @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/topology/thread_siblings b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/topology/thread_siblings new file mode 100644 index 0000000..6496923 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/topology/thread_siblings @@ -0,0 +1 @@ +04 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/topology/thread_siblings_list b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/topology/thread_siblings_list new file mode 100644 index 0000000..0cfbf08 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/topology/thread_siblings_list @@ -0,0 +1 @@ +2 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/uevent b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/uevent new file mode 100644 index 0000000..1f4dcb1 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu2/uevent @@ -0,0 +1,8 @@ +OF_NAME=cpu +OF_FULLNAME=/cpus/cpu@100 +OF_TYPE=cpu +OF_COMPATIBLE_0=apm,potenza +OF_COMPATIBLE_1=arm,armv8 +OF_COMPATIBLE_N=2 +MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002 + diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/online b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/online new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/online @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/async b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/async new file mode 100644 index 0000000..7a68b11 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/async @@ -0,0 +1 @@ +disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/autosuspend_delay_ms b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/autosuspend_delay_ms new file mode 100644 index 0000000..e69de29 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/control b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/control new file mode 100644 index 0000000..865faf1 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/control @@ -0,0 +1 @@ +auto diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_active_kids b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_active_kids new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_active_kids @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_active_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_active_time new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_active_time @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_enabled b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_enabled new file mode 100644 index 0000000..7a68b11 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_enabled @@ -0,0 +1 @@ +disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_status b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_status new file mode 100644 index 0000000..ad7ccf7 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_status @@ -0,0 +1 @@ +unsupported diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_suspended_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_suspended_time new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_suspended_time @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_usage b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_usage new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/power/runtime_usage @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/subsystem b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/subsystem new file mode 120000 index 0000000..758c291 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/subsystem @@ -0,0 +1 @@ +../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/topology/core_id b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/topology/core_id new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/topology/core_id @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/topology/core_siblings b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/topology/core_siblings new file mode 100644 index 0000000..8ac4b4c --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/topology/core_siblings @@ -0,0 +1 @@ +0c diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/topology/core_siblings_list b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/topology/core_siblings_list new file mode 100644 index 0000000..7a98575 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/topology/core_siblings_list @@ -0,0 +1 @@ +2-3 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/topology/physical_package_id b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/topology/physical_package_id new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/topology/physical_package_id @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/topology/thread_siblings b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/topology/thread_siblings new file mode 100644 index 0000000..adb9de8 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/topology/thread_siblings @@ -0,0 +1 @@ +08 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/topology/thread_siblings_list b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/topology/thread_siblings_list new file mode 100644 index 0000000..00750ed --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/topology/thread_siblings_list @@ -0,0 +1 @@ +3 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/uevent b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/uevent new file mode 100644 index 0000000..78869cc --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu3/uevent @@ -0,0 +1,8 @@ +OF_NAME=cpu +OF_FULLNAME=/cpus/cpu@101 +OF_TYPE=cpu +OF_COMPATIBLE_0=apm,potenza +OF_COMPATIBLE_1=arm,armv8 +OF_COMPATIBLE_N=2 +MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002 + diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/online b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/online new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/online @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/async b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/async new file mode 100644 index 0000000..7a68b11 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/async @@ -0,0 +1 @@ +disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/autosuspend_delay_ms b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/autosuspend_delay_ms new file mode 100644 index 0000000..e69de29 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/control b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/control new file mode 100644 index 0000000..865faf1 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/control @@ -0,0 +1 @@ +auto diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_active_kids b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_active_kids new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_active_kids @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_active_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_active_time new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_active_time @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_enabled b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_enabled new file mode 100644 index 0000000..7a68b11 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_enabled @@ -0,0 +1 @@ +disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_status b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_status new file mode 100644 index 0000000..ad7ccf7 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_status @@ -0,0 +1 @@ +unsupported diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_suspended_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_suspended_time new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_suspended_time @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_usage b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_usage new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/power/runtime_usage @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/subsystem b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/subsystem new file mode 120000 index 0000000..758c291 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/subsystem @@ -0,0 +1 @@ +../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/topology/core_id b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/topology/core_id new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/topology/core_id @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/topology/core_siblings b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/topology/core_siblings new file mode 100644 index 0000000..64bb6b7 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/topology/core_siblings @@ -0,0 +1 @@ +30 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/topology/core_siblings_list b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/topology/core_siblings_list new file mode 100644 index 0000000..e66d883 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/topology/core_siblings_list @@ -0,0 +1 @@ +4-5 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/topology/physical_package_id b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/topology/physical_package_id new file mode 100644 index 0000000..0cfbf08 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/topology/physical_package_id @@ -0,0 +1 @@ +2 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/topology/thread_siblings b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/topology/thread_siblings new file mode 100644 index 0000000..f599e28 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/topology/thread_siblings @@ -0,0 +1 @@ +10 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/topology/thread_siblings_list b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/topology/thread_siblings_list new file mode 100644 index 0000000..b8626c4 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/topology/thread_siblings_list @@ -0,0 +1 @@ +4 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/uevent b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/uevent new file mode 100644 index 0000000..5d3a708 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu4/uevent @@ -0,0 +1,8 @@ +OF_NAME=cpu +OF_FULLNAME=/cpus/cpu@200 +OF_TYPE=cpu +OF_COMPATIBLE_0=apm,potenza +OF_COMPATIBLE_1=arm,armv8 +OF_COMPATIBLE_N=2 +MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002 + diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/online b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/online new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/online @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/async b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/async new file mode 100644 index 0000000..7a68b11 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/async @@ -0,0 +1 @@ +disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/autosuspend_delay_ms b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/autosuspend_delay_ms new file mode 100644 index 0000000..e69de29 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/control b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/control new file mode 100644 index 0000000..865faf1 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/control @@ -0,0 +1 @@ +auto diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_active_kids b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_active_kids new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_active_kids @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_active_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_active_time new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_active_time @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_enabled b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_enabled new file mode 100644 index 0000000..7a68b11 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_enabled @@ -0,0 +1 @@ +disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_status b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_status new file mode 100644 index 0000000..ad7ccf7 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_status @@ -0,0 +1 @@ +unsupported diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_suspended_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_suspended_time new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_suspended_time @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_usage b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_usage new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/power/runtime_usage @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/subsystem b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/subsystem new file mode 120000 index 0000000..758c291 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/subsystem @@ -0,0 +1 @@ +../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/topology/core_id b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/topology/core_id new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/topology/core_id @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/topology/core_siblings b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/topology/core_siblings new file mode 100644 index 0000000..64bb6b7 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/topology/core_siblings @@ -0,0 +1 @@ +30 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/topology/core_siblings_list b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/topology/core_siblings_list new file mode 100644 index 0000000..e66d883 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/topology/core_siblings_list @@ -0,0 +1 @@ +4-5 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/topology/physical_package_id b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/topology/physical_package_id new file mode 100644 index 0000000..0cfbf08 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/topology/physical_package_id @@ -0,0 +1 @@ +2 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/topology/thread_siblings b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/topology/thread_siblings new file mode 100644 index 0000000..209e3ef --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/topology/thread_siblings @@ -0,0 +1 @@ +20 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/topology/thread_siblings_list b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/topology/thread_siblings_list new file mode 100644 index 0000000..7ed6ff8 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/topology/thread_siblings_list @@ -0,0 +1 @@ +5 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/uevent b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/uevent new file mode 100644 index 0000000..00d94c3 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu5/uevent @@ -0,0 +1,8 @@ +OF_NAME=cpu +OF_FULLNAME=/cpus/cpu@201 +OF_TYPE=cpu +OF_COMPATIBLE_0=apm,potenza +OF_COMPATIBLE_1=arm,armv8 +OF_COMPATIBLE_N=2 +MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002 + diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/online b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/online new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/online @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/async b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/async new file mode 100644 index 0000000..7a68b11 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/async @@ -0,0 +1 @@ +disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/autosuspend_delay_ms b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/autosuspend_delay_ms new file mode 100644 index 0000000..e69de29 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/control b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/control new file mode 100644 index 0000000..865faf1 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/control @@ -0,0 +1 @@ +auto diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_active_kids b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_active_kids new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_active_kids @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_active_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_active_time new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_active_time @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_enabled b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_enabled new file mode 100644 index 0000000..7a68b11 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_enabled @@ -0,0 +1 @@ +disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_status b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_status new file mode 100644 index 0000000..ad7ccf7 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_status @@ -0,0 +1 @@ +unsupported diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_suspended_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_suspended_time new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_suspended_time @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_usage b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_usage new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/power/runtime_usage @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/subsystem b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/subsystem new file mode 120000 index 0000000..758c291 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/subsystem @@ -0,0 +1 @@ +../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/topology/core_id b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/topology/core_id new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/topology/core_id @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/topology/core_siblings b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/topology/core_siblings new file mode 100644 index 0000000..caecf05 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/topology/core_siblings @@ -0,0 +1 @@ +c0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/topology/core_siblings_list b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/topology/core_siblings_list new file mode 100644 index 0000000..fdd9f37 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/topology/core_siblings_list @@ -0,0 +1 @@ +6-7 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/topology/physical_package_id b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/topology/physical_package_id new file mode 100644 index 0000000..00750ed --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/topology/physical_package_id @@ -0,0 +1 @@ +3 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/topology/thread_siblings b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/topology/thread_siblings new file mode 100644 index 0000000..425151f --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/topology/thread_siblings @@ -0,0 +1 @@ +40 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/topology/thread_siblings_list b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/topology/thread_siblings_list new file mode 100644 index 0000000..1e8b314 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/topology/thread_siblings_list @@ -0,0 +1 @@ +6 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/uevent b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/uevent new file mode 100644 index 0000000..d612e9c --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu6/uevent @@ -0,0 +1,8 @@ +OF_NAME=cpu +OF_FULLNAME=/cpus/cpu@300 +OF_TYPE=cpu +OF_COMPATIBLE_0=apm,potenza +OF_COMPATIBLE_1=arm,armv8 +OF_COMPATIBLE_N=2 +MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002 + diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/online b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/online new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/online @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/async b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/async new file mode 100644 index 0000000..7a68b11 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/async @@ -0,0 +1 @@ +disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/autosuspend_delay_ms b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/autosuspend_delay_ms new file mode 100644 index 0000000..e69de29 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/control b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/control new file mode 100644 index 0000000..865faf1 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/control @@ -0,0 +1 @@ +auto diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_active_kids b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_active_kids new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_active_kids @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_active_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_active_time new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_active_time @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_enabled b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_enabled new file mode 100644 index 0000000..7a68b11 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_enabled @@ -0,0 +1 @@ +disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_status b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_status new file mode 100644 index 0000000..ad7ccf7 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_status @@ -0,0 +1 @@ +unsupported diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_suspended_time b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_suspended_time new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_suspended_time @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_usage b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_usage new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/power/runtime_usage @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/subsystem b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/subsystem new file mode 120000 index 0000000..758c291 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/subsystem @@ -0,0 +1 @@ +../../../../bus/cpu \ No newline at end of file diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/topology/core_id b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/topology/core_id new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/topology/core_id @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/topology/core_siblings b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/topology/core_siblings new file mode 100644 index 0000000..caecf05 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/topology/core_siblings @@ -0,0 +1 @@ +c0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/topology/core_siblings_list b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/topology/core_siblings_list new file mode 100644 index 0000000..fdd9f37 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/topology/core_siblings_list @@ -0,0 +1 @@ +6-7 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/topology/physical_package_id b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/topology/physical_package_id new file mode 100644 index 0000000..00750ed --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/topology/physical_package_id @@ -0,0 +1 @@ +3 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/topology/thread_siblings b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/topology/thread_siblings new file mode 100644 index 0000000..d15a2cc --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/topology/thread_siblings @@ -0,0 +1 @@ +80 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/topology/thread_siblings_list b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/topology/thread_siblings_list new file mode 100644 index 0000000..7f8f011 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/topology/thread_siblings_list @@ -0,0 +1 @@ +7 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/uevent b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/uevent new file mode 100644 index 0000000..c24e537 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu7/uevent @@ -0,0 +1,8 @@ +OF_NAME=cpu +OF_FULLNAME=/cpus/cpu@301 +OF_TYPE=cpu +OF_COMPATIBLE_0=apm,potenza +OF_COMPATIBLE_1=arm,armv8 +OF_COMPATIBLE_N=2 +MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002 + diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/kernel_max b/tests/nodeinfodata/linux-f21-mustang/cpu/kernel_max new file mode 100644 index 0000000..7f8f011 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/kernel_max @@ -0,0 +1 @@ +7 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/modalias b/tests/nodeinfodata/linux-f21-mustang/cpu/modalias new file mode 100644 index 0000000..18bb0b6 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/modalias @@ -0,0 +1 @@ +cpu:type:aarch64:feature:,0000,0001,0002 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/offline b/tests/nodeinfodata/linux-f21-mustang/cpu/offline new file mode 100644 index 0000000..8b13789 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/offline @@ -0,0 +1 @@ + diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/online b/tests/nodeinfodata/linux-f21-mustang/cpu/online new file mode 100644 index 0000000..74fc2fb --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/online @@ -0,0 +1 @@ +0-7 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/possible b/tests/nodeinfodata/linux-f21-mustang/cpu/possible new file mode 100644 index 0000000..74fc2fb --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/possible @@ -0,0 +1 @@ +0-7 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/power/async b/tests/nodeinfodata/linux-f21-mustang/cpu/power/async new file mode 100644 index 0000000..7a68b11 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/power/async @@ -0,0 +1 @@ +disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/power/autosuspend_delay_ms b/tests/nodeinfodata/linux-f21-mustang/cpu/power/autosuspend_delay_ms new file mode 100644 index 0000000..e69de29 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/power/control b/tests/nodeinfodata/linux-f21-mustang/cpu/power/control new file mode 100644 index 0000000..865faf1 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/power/control @@ -0,0 +1 @@ +auto diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_active_kids b/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_active_kids new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_active_kids @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_active_time b/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_active_time new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_active_time @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_enabled b/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_enabled new file mode 100644 index 0000000..7a68b11 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_enabled @@ -0,0 +1 @@ +disabled diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_status b/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_status new file mode 100644 index 0000000..ad7ccf7 --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_status @@ -0,0 +1 @@ +unsupported diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_suspended_time b/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_suspended_time new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_suspended_time @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_usage b/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_usage new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/power/runtime_usage @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/present b/tests/nodeinfodata/linux-f21-mustang/cpu/present new file mode 100644 index 0000000..74fc2fb --- /dev/null +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/present @@ -0,0 +1 @@ +0-7 diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/uevent b/tests/nodeinfodata/linux-f21-mustang/cpu/uevent new file mode 100644 index 0000000..e69de29 diff --git a/tests/nodeinfotest.c b/tests/nodeinfotest.c index 3c76e5d..492cc92 100644 --- a/tests/nodeinfotest.c +++ b/tests/nodeinfotest.c @@ -246,6 +246,7 @@ mymain(void) {"test7", VIR_ARCH_X86_64}, {"test8", VIR_ARCH_X86_64}, {"raspberrypi", VIR_ARCH_ARMV6L}, + {"f21-mustang", VIR_ARCH_AARCH64}, }; if (virInitialize() < 0) -- 2.3.4

4 6

[libvirt] [libvirt-perl PATCH] Add VIR_FROM_THREAD constant
by John Ferlan 01 Apr '15

01 Apr '15

Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Changes | 1 + Virt.xs | 1 + lib/Sys/Virt/Error.pm | 4 ++++ 3 files changed, 6 insertions(+) diff --git a/Changes b/Changes index 7a2bc51..1849668 100644 --- a/Changes +++ b/Changes @@ -11,6 +11,7 @@ Revision history for perl module Sys::Virt - Add VIR_DOMAIN_PAUSED_STARTING_UP constant - Adapt to rename of virDomainIOThreadsInfoFree to virDomainIOThreadInfoFree - Adapt to rename of virDomainGetIOThreadsInfo to virDomainGetIOThreadInfo + - Add VIR_FROM_THREAD constant 1.2.13 2015-03-05 diff --git a/Virt.xs b/Virt.xs index 2138530..d01cf05 100644 --- a/Virt.xs +++ b/Virt.xs @@ -8104,6 +8104,7 @@ BOOT: REGISTER_CONSTANT(VIR_FROM_CRYPTO, FROM_CRYPTO); REGISTER_CONSTANT(VIR_FROM_FIREWALL, FROM_FIREWALL); REGISTER_CONSTANT(VIR_FROM_POLKIT, FROM_POLKIT); + REGISTER_CONSTANT(VIR_FROM_THREAD, FROM_THREAD); REGISTER_CONSTANT(VIR_ERR_OK, ERR_OK); diff --git a/lib/Sys/Virt/Error.pm b/lib/Sys/Virt/Error.pm index 2171bf2..e2fdbe1 100644 --- a/lib/Sys/Virt/Error.pm +++ b/lib/Sys/Virt/Error.pm @@ -378,6 +378,10 @@ The firewall helper APIs. The polkit authentication / authorization APIs +=item Sys::Virt::Error::FROM_THREAD + +The thread helper utils + =back =head2 ERROR CODE CONSTANTS -- 2.1.0

2 1

[libvirt] [RFC] How to build libvirt package with git commit info from libvirt.git
by Shanzhi Yu 01 Apr '15

01 Apr '15

Hello there, Currently I am searching a way to build a libvirt package from latest libvirt.git with package name including git commit info. Like # cd libvirt && git describe v1.2.14-rc1-16-g0c4474d then I want to build a libvirt package with name like libvirt-1.2.14-1.el7.v1.2.14-rc1-16-g0c4474d.x86_64 The context why I need this is there are some hosts running scripts for auto QE-consumption testing while there is no job running sometimes.( we won't get a internal release version everyday, it is not necessary also). We can make use of these resource to do some auto testing daily so that we may be able to find the regression problems earlier. So, a package with commit info is required for comparative testing. After talk with eblake I got a way as below: after 'make rpm' , I will get libvirt.spec, then I can tweak libvirt.spec add a line "%define extra_release .git_commit_num" at the top of libvirt.spec then use the tweaked libvirt.spec to build the package I want to get I wonder anybody have a better method to achieve this ? Thanks -- Regards shyu

1 0

[libvirt] Lispvirt: porting Libvirt API for Common Lisp
by Julio Faracco 01 Apr '15

01 Apr '15

Hi everyone! I'm developing a Libvirt bindings for Common Lisp. The project is called "Lispvirt". I created this project because I was doing a project in Lisp to manage Virtual Machines. So, I needed to implement some code using C and set up Lisp to access those methods in C. This project was becoming a mess. The better scenario is using only Lisp. That's why I started to develop this bindings for Lisp. Now, I'm only using Lisp for it. For a while, I'm hosting this project on GitHub: https://github.com/jcfaracco/lispvirt But I'm planning to move it to common-lisp.net. There is still many things to do (callbacks, structures, some project decisions and planings, documentation, etc). Any contribution or suggestions would be helpful. The most important things to do now are test, test and test. Just sharing if someone is interested to help us. Thanks! *--* *Julio Cesar Faracco*

1 0

[libvirt] [PATCH] Add vmport feature
by Marc-André Lureau 01 Apr '15

01 Apr '15

The QEMU machine vmport option allows to set the VMWare IO port emulation. This emulation is useful for absolute pointer input when the guest has vmware input drivers, and is enabled by default for kvm. However it is unnecessary for Spice-enabled VM, since the agent already handles absolute pointer and multi-monitors. Furthermore, it prevents Spice from switching to relative input since the regular ps/2 pointer driver is replaced by the vmware driver. It is thus advised to disable vmport when using a Spice VM. This will permit the Spice client to switch from absolute to relative pointer, as it may be required for certain games or applications. --- docs/formatdomain.html.in | 6 +++++ docs/schemas/domaincommon.rng | 9 +++++++ src/conf/domain_conf.c | 5 +++- src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 6 +++++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 14 +++++++++++ .../qemuxml2argv-machine-vmport-opt.args | 6 +++++ .../qemuxml2argv-machine-vmport-opt.xml | 28 ++++++++++++++++++++++ tests/qemuxml2argvtest.c | 2 ++ 10 files changed, 77 insertions(+), 1 deletion(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-vmport-opt.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-vmport-opt.xml diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 1b496c3..faa22ec 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -1500,6 +1500,12 @@ performance monitoring unit for the guest. <span class="since">Since 1.2.12</span> </dd> + <dt><code>vmport</code></dt> + <dd>Depending on the <code>state</code> attribute (values <code>on</code>, + <code>off</code>, default <code>on</code>) enable or disable the + the emulation of VMWare IO port, for vmmouse etc. + <span class="since">Since 1.2.14</span> + </dd> </dl> <h3><a name="elementsTime">Time keeping</a></h3> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 03fd541..b8e06b3 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -4149,6 +4149,15 @@ <optional> <ref name="pmu"/> </optional> + <optional> + <element name="vmport"> + <optional> + <attribute name="state"> + <ref name="virOnOff"/> + </attribute> + </optional> + </element> + </optional> </interleave> </element> </optional> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index cd6ee22..b92c634 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -139,7 +139,8 @@ VIR_ENUM_IMPL(virDomainFeature, VIR_DOMAIN_FEATURE_LAST, "kvm", "pvspinlock", "capabilities", - "pmu") + "pmu", + "vmport") VIR_ENUM_IMPL(virDomainCapabilitiesPolicy, VIR_DOMAIN_CAPABILITIES_POLICY_LAST, "default", @@ -14223,6 +14224,7 @@ virDomainDefParseXML(xmlDocPtr xml, case VIR_DOMAIN_FEATURE_PMU: case VIR_DOMAIN_FEATURE_PVSPINLOCK: + case VIR_DOMAIN_FEATURE_VMPORT: node = ctxt->node; ctxt->node = nodes[i]; if ((tmp = virXPathString("string(./@state)", ctxt))) { @@ -20858,6 +20860,7 @@ virDomainDefFormatInternal(virDomainDefPtr def, case VIR_DOMAIN_FEATURE_PMU: case VIR_DOMAIN_FEATURE_PVSPINLOCK: + case VIR_DOMAIN_FEATURE_VMPORT: switch ((virTristateSwitch) def->features[i]) { case VIR_TRISTATE_SWITCH_LAST: case VIR_TRISTATE_SWITCH_ABSENT: diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 84e880a..b29767e 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -1634,6 +1634,7 @@ typedef enum { VIR_DOMAIN_FEATURE_PVSPINLOCK, VIR_DOMAIN_FEATURE_CAPABILITIES, VIR_DOMAIN_FEATURE_PMU, + VIR_DOMAIN_FEATURE_VMPORT, VIR_DOMAIN_FEATURE_LAST } virDomainFeature; diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index ce6767c..8782613 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -279,6 +279,8 @@ VIR_ENUM_IMPL(virQEMUCaps, QEMU_CAPS_LAST, "qxl.vgamem_mb", "qxl-vga.vgamem_mb", "pc-dimm", + + "machine-vmport-opt", /* 185 */ ); @@ -3239,6 +3241,10 @@ virQEMUCapsInitQMPMonitor(virQEMUCapsPtr qemuCaps, if (qemuCaps->version >= 1003000) virQEMUCapsSet(qemuCaps, QEMU_CAPS_MACHINE_USB_OPT); + /* vmport option is supported v2.2.0 onwards */ + if (qemuCaps->version >= 2002000) + virQEMUCapsSet(qemuCaps, QEMU_CAPS_MACHINE_VMPORT_OPT); + /* WebSockets were introduced between 1.3.0 and 1.3.1 */ if (qemuCaps->version >= 1003001) virQEMUCapsSet(qemuCaps, QEMU_CAPS_VNC_WEBSOCKET); diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h index c7b1ac7..48c8f96 100644 --- a/src/qemu/qemu_capabilities.h +++ b/src/qemu/qemu_capabilities.h @@ -224,6 +224,7 @@ typedef enum { QEMU_CAPS_QXL_VGAMEM = 182, /* -device qxl.vgamem_mb */ QEMU_CAPS_QXL_VGA_VGAMEM = 183, /* -device qxl-vga.vgamem_mb */ QEMU_CAPS_DEVICE_PC_DIMM = 184, /* pc-dimm device */ + QEMU_CAPS_MACHINE_VMPORT_OPT = 185, /* -machine xxx,vmport=on/off/auto */ QEMU_CAPS_LAST, /* this must always be the last item */ } virQEMUCapsFlags; diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index bcb54fa..8b111a5 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -7248,6 +7248,7 @@ qemuBuildMachineArgStr(virCommandPtr cmd, obsoleteAccel = true; } else { virBuffer buf = VIR_BUFFER_INITIALIZER; + virTristateSwitch vmport = def->features[VIR_DOMAIN_FEATURE_VMPORT]; virCommandAddArg(cmd, "-machine"); virBufferAdd(&buf, def->os.machine, -1); @@ -7265,6 +7266,19 @@ qemuBuildMachineArgStr(virCommandPtr cmd, if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_MACHINE_USB_OPT)) virBufferAddLit(&buf, ",usb=off"); + if (vmport) { + if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_MACHINE_VMPORT_OPT)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("vmport is not available " + "with this QEMU binary")); + virBufferFreeAndReset(&buf); + return -1; + } + + virBufferAsprintf(&buf, ",vmport=%s", + virTristateSwitchTypeToString(vmport)); + } + if (def->mem.dump_core) { if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_DUMP_GUEST_CORE)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", diff --git a/tests/qemuxml2argvdata/qemuxml2argv-machine-vmport-opt.args b/tests/qemuxml2argvdata/qemuxml2argv-machine-vmport-opt.args new file mode 100644 index 0000000..ea1a11f --- /dev/null +++ b/tests/qemuxml2argvdata/qemuxml2argv-machine-vmport-opt.args @@ -0,0 +1,6 @@ +LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test QEMU_AUDIO_DRV=none \ +/usr/bin/qemu \ +-S -machine pc,accel=tcg,vmport=off -m 214 -smp 1 -nographic \ +-monitor unix:/tmp/test-monitor,server,nowait -no-acpi -boot c -usb \ +-hda /dev/HostVG/QEMUGuest1 -net none -serial \ +none -parallel none diff --git a/tests/qemuxml2argvdata/qemuxml2argv-machine-vmport-opt.xml b/tests/qemuxml2argvdata/qemuxml2argv-machine-vmport-opt.xml new file mode 100644 index 0000000..671d3a9 --- /dev/null +++ b/tests/qemuxml2argvdata/qemuxml2argv-machine-vmport-opt.xml @@ -0,0 +1,28 @@ +<domain type='qemu'> + <name>QEMUGuest1</name> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> + <memory unit='KiB'>219100</memory> + <currentMemory unit='KiB'>219100</currentMemory> + <vcpu placement='static'>1</vcpu> + <os> + <type arch='i686' machine='pc'>hvm</type> + <boot dev='hd'/> + </os> + <features> + <vmport state='off'/> + </features> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <emulator>/usr/bin/qemu</emulator> + <disk type='block' device='disk'> + <source dev='/dev/HostVG/QEMUGuest1'/> + <target dev='hda' bus='ide'/> + <address type='drive' controller='0' bus='0' target='0' unit='0'/> + </disk> + <controller type='ide' index='0'/> + <memballoon model='virtio'/> + </devices> +</domain> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 57ef053..f6ce2c1 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -608,6 +608,8 @@ mymain(void) DO_TEST_FAILURE("machine-core-on", QEMU_CAPS_MACHINE_OPT); DO_TEST("machine-usb-opt", QEMU_CAPS_MACHINE_OPT, QEMU_CAPS_MACHINE_USB_OPT); + DO_TEST("machine-vmport-opt", QEMU_CAPS_MACHINE_OPT, + QEMU_CAPS_MACHINE_VMPORT_OPT); DO_TEST("kvm", QEMU_CAPS_MACHINE_OPT); DO_TEST("boot-cdrom", NONE); DO_TEST("boot-network", NONE); -- 2.1.0

1 1

[libvirt] [PATCH V2] libxl: fix dom0 balloon logic
by Jim Fehlig 31 Mar '15

31 Mar '15

Recent testing on large memory systems revealed a bug in the Xen xl tool's freemem() function. When autoballooning is enabled, freemem() is used to ensure enough memory is available to start a domain, ballooning dom0 if necessary. When ballooning large amounts of memory from dom0, freemem() would exceed its self-imposed wait time and return an error. Meanwhile, dom0 continued to balloon. Starting the domain later, after sufficient memory was ballooned from dom0, would succeed. The libvirt implementation in libxlDomainFreeMem() suffers the same bug since it is modeled after freemem(). In the end, the best place to fix the bug on the Xen side was to slightly change the behavior of libxl_wait_for_memory_target(). Instead of failing after caller-provided wait_sec, the function now blocks as long as dom0 memory ballooning is progressing. It will return failure only when more memory is needed to reach the target and wait_sec have expired with no progress being made. See xen.git commit fd3aa246. There was a dicussion on how this would affect other libxl apps like libvirt http://lists.xen.org/archives/html/xen-devel/2015-03/msg00739.html If libvirt containing this patch was build against a Xen containing the old libxl_wait_for_memory_target() behavior, libxlDomainFreeMem() will fail after 30 sec and domain creation will be terminated. Without this patch and with old libxl_wait_for_memory_target() behavior, libxlDomainFreeMem() does not succeed after 30 sec, but returns success anyway. Domain creation continues resulting in all sorts of fun stuff like cpu soft lockups in the guest OS. It was decided to properly fix libxl_wait_for_memory_target(), and if anything improve the default behavior of apps using the freemem reference impl in xl. xl was patched to accommodate the change in libxl_wait_for_memory_target() with xen.git commit 883b30a0. This patch does the same in the libxl driver. While at it, I changed the logic to essentially match freemem() in $xensrc/tools/libxl/xl_cmdimpl.c. It was a bit cleaner IMO and will make it easier to spot future, potentially interesting divergences. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- V2: Actually use libxl_wait_for_memory_target(), instead of libxl_wait_for_free_memory() src/libxl/libxl_domain.c | 55 +++++++++++++++++++++++------------------------- 1 file changed, 26 insertions(+), 29 deletions(-) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index 407a9bd..a1739aa 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -1121,38 +1121,39 @@ libxlDomainFreeMem(libxlDomainObjPrivatePtr priv, libxl_domain_config *d_config) { uint32_t needed_mem; uint32_t free_mem; - size_t i; - int ret = -1; + int ret; int tries = 3; int wait_secs = 10; - if ((ret = libxl_domain_need_memory(priv->ctx, &d_config->b_info, - &needed_mem)) >= 0) { - for (i = 0; i < tries; ++i) { - if ((ret = libxl_get_free_memory(priv->ctx, &free_mem)) < 0) - break; + ret = libxl_domain_need_memory(priv->ctx, &d_config->b_info, &needed_mem); + if (ret < 0) + goto error; - if (free_mem >= needed_mem) { - ret = 0; - break; - } + do { + ret = libxl_get_free_memory(priv->ctx, &free_mem); + if (ret < 0) + goto error; - if ((ret = libxl_set_memory_target(priv->ctx, 0, - free_mem - needed_mem, - /* relative */ 1, 0)) < 0) - break; + if (free_mem >= needed_mem) + return 0; - ret = libxl_wait_for_free_memory(priv->ctx, 0, needed_mem, - wait_secs); - if (ret == 0 || ret != ERROR_NOMEM) - break; + ret = libxl_set_memory_target(priv->ctx, 0, + free_mem - needed_mem, + /* relative */ 1, 0); + if (ret < 0) + goto error; - if ((ret = libxl_wait_for_memory_target(priv->ctx, 0, 1)) < 0) - break; - } - } + ret = libxl_wait_for_memory_target(priv->ctx, 0, wait_secs); + if (ret < 0) + goto error; - return ret; + tries--; + } while (tries > 0); + + error: + virReportSystemError(ret, "%s", + _("Failed to balloon domain0 memory")); + return -1; } static void @@ -1271,12 +1272,8 @@ libxlDomainStart(libxlDriverPrivatePtr driver, virDomainObjPtr vm, priv->ctx, &d_config) < 0) goto endjob; - if (cfg->autoballoon && libxlDomainFreeMem(priv, &d_config) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("libxenlight failed to get free memory for domain '%s'"), - d_config.c_info.name); + if (cfg->autoballoon && libxlDomainFreeMem(priv, &d_config) < 0) goto endjob; - } if (virHostdevPrepareDomainDevices(hostdev_mgr, LIBXL_DRIVER_NAME, vm->def, VIR_HOSTDEV_SP_PCI) < 0) -- 1.8.4.5

3 4

[libvirt] [PATCH] virsh: add check for exclusive options for domstats command
by Pavel Hrdina 31 Mar '15

31 Mar '15

Option --domain cannot be combined with options --list-*. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1143837 Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- tools/virsh-domain-monitor.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index 6951db2..e683a6d 100644 --- a/tools/virsh-domain-monitor.c +++ b/tools/virsh-domain-monitor.c @@ -2110,6 +2110,15 @@ cmdDomstats(vshControl *ctl, const vshCmd *cmd) const vshCmdOpt *opt = NULL; bool ret = false; + VSH_EXCLUSIVE_OPTIONS("domain", "list-active"); + VSH_EXCLUSIVE_OPTIONS("domain", "list-inactive"); + VSH_EXCLUSIVE_OPTIONS("domain", "list-persistent"); + VSH_EXCLUSIVE_OPTIONS("domain", "list-transient"); + VSH_EXCLUSIVE_OPTIONS("domain", "list-running"); + VSH_EXCLUSIVE_OPTIONS("domain", "list-paused"); + VSH_EXCLUSIVE_OPTIONS("domain", "list-shutoff"); + VSH_EXCLUSIVE_OPTIONS("domain", "list-other"); + if (vshCommandOptBool(cmd, "state")) stats |= VIR_DOMAIN_STATS_STATE; -- 2.0.5

2 1

[libvirt] [PATCH] virDomainShutdown*: Describe blocking behaviour
by Michal Privoznik 31 Mar '15

31 Mar '15

The description to both virDomainShutdown() and virDomainShutdownFlags() is quite misleading when it comes to blocking behaviour of these two APIs. Firstly, we support many shutdown methods, from signalizing an ACPI event, through sending a signal to guest agent assisted shutdown. Some of these methods make the API return immediately, while others block the API until domain is actually shut of. And since virDomainShutdown() is equivalent to calling virDomainShutdownFlags(0), it's up to each driver which methods to try. So the bare virDomainShutdown() may block or may return immediately at the same time. I know, it's confusing, but at least let users know. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/libvirt-domain.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index f1608dc..03b342f 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -1474,9 +1474,12 @@ virDomainScreenshot(virDomainPtr domain, * 'on_poweroff' XML setting resulting in a domain that reboots instead of * shutting down. For guests that react to a shutdown request, the differences * from virDomainDestroy() are that the guests disk storage will be in a - * stable state rather than having the (virtual) power cord pulled, and - * this command returns as soon as the shutdown request is issued rather - * than blocking until the guest is no longer running. + * stable state rather than having the (virtual) power cord pulled. It's up to + * hypervisor's driver implementation what methods of + * virDomainShutdownFlagValues are tried and in which order. As described in + * virDomainShutdownFlags, this call may return immediately after the shutdown + * request is send, or it may block indefinitely long, until the domain is + * actually shut off. * * If the domain is transient and has any snapshot metadata (see * virDomainSnapshotNum()), then that metadata will automatically @@ -1540,7 +1543,9 @@ virDomainShutdown(virDomainPtr domain) * and a hypervisor is not required to support all methods. * * To use guest agent (VIR_DOMAIN_SHUTDOWN_GUEST_AGENT) the domain XML - * must have <channel> configured. + * must have <channel> configured. Moreover, depending on underlying + * hypervisor used, passing this flag may block the API until the domain + * is shut off (which is not guaranteed to happen anyway). * * Returns 0 in case of success and -1 in case of failure. */ -- 2.0.5

2 3