- Devel - libvirt List Archives

[libvirt] [PATCH] iscsi: do not fail to stop a stopped pool
by Ján Tomko 30 Apr '15

30 Apr '15

Just as we allow stopping filesystem pools when they were unmounted externally, do not fail to stop an iscsi pool when someone else closed the session externally. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1171984 --- src/storage/storage_backend_iscsi.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/storage/storage_backend_iscsi.c b/src/storage/storage_backend_iscsi.c index 197d333..bea6758 100644 --- a/src/storage/storage_backend_iscsi.c +++ b/src/storage/storage_backend_iscsi.c @@ -449,8 +449,13 @@ virStorageBackendISCSIStopPool(virConnectPtr conn ATTRIBUTE_UNUSED, virStoragePoolObjPtr pool) { char *portal; + char *session; int ret = -1; + if ((session = virStorageBackendISCSISession(pool, false)) == NULL) + return 0; + VIR_FREE(session); + if ((portal = virStorageBackendISCSIPortal(&pool->def->source)) == NULL) return -1; -- 2.0.5

3 8

[libvirt] RFC: a couple ideas regarding selinux/DAC labeling
by Cole Robinson 30 Apr '15

30 Apr '15

Hi all, libvirt's selinux/DAC labeling behavior has been a repeated source of frustration for desktop virt users. Granted much of the frustration comes from the fact that virt-manager runs as $user, talks to libvirtd running as root, which launches VMs running as qemu, and we are mixing it all with selinux :) But the flip side is that I've lost count of how many times I've heard someone complain 'why is libvirt chowning/relabeling my .iso? it's world readable' I spent some time looking at bug reports and looking at the relevant libvirt code, and I have a couple ideas for reducing user complaints in this area. The patches should be pretty simple but I haven't written them yet since I'd like other opinions on this stuff, given it could impact security. Here's my two suggestions: 1) Don't attempt to change selinux label for readonly/shareable images, if the image already has a label that svirt_t can access. Background: svirt is about giving r/w disk images a unique selinux label tied to one running VM, so that if other VMs are compromised, they can't access another VMs disk image. Maintaining this guarantee is important, which is why libvirt will raise an explicit error if attempting to change the disk image label errors with EPERM and selinux==Enforcing. Makes sense. The problem is with readonly media. We don't give a unique label to RO media, we just give it plain virt_content_t. RO media labeling isn't about VM isolation, it's about ensuring the svirt VM can even access the media. However, if labeling fails with EPERM, we still fail in the same way mentioned above. Here's a situation where that is problematic: - Running as qemu:///session (unprivileged) - Point a VM at /path/to/my/isos/foo.iso - foo.iso is: owner=root, mode=644, label=public_content_t. We are sharing this media for qemu:///system usage as well Without any libvirt label changing, the VM should be able to access that ISO: permissions are fine, and svirt_t can access public_content_t. However the unprivileged user does not have permissions to change the label to virt_content_t, libvirt fails to set the label, raises the error, VM startup fails. I suggest that in the case of readonly (and maybe shareable which uses the plain svirt_image_t label) disk, we first check to see if svirt_t can access the existing label, and if so, don't do any explicit labeling. This makes things 'just work' in the above example, and doesn't seem to have a detrimental effect on security. I don't know exactly how to do this with the selinux API but I assume there's something that reproduces what sesearch does on the CLI. Another case this helps: qemu:///system VM wants to use /dev/sr0, changes the label to virt_content_t, which can generate selinux violations from udev when media is ejected/inserted and the VM is running (I don't remember specifics here but we've had bug reports in the past). Instead it just leaves /dev/sr0 as removable_device_t, which svirt_t can already read from. (Libvirt already does something along these lines: If the labeling fails, it checks to see if the disk image _already_ has the label we just requested, and if so, it's not an error condition. But this suggestion goes a step further than that) 2) DAC shouldn't change owner if qemu will be able to access the disk. Background: My understanding of the DAC driver is it's _just_ to facilitate running qemu as non-root; we chown the image to ensure the emulator has permissions to access it so that VM startup doesn't fail. So I suggest that if libvirt determines the disk is already accessible by the qemu user, we skip the chown step. Coupled with the above selinux erroring mentioned above, unnecessary chowning can cause issues when sharing media between qemu:///system and qemu:///session; once the file is owned by qemu, qemu:///session can't change the selinux label ever again, and labeling failures may mean the VM fails to start. Thankfully we have libvirt infrastructure for checking whether a file can be read by arbitrary uid:gid: virStorageFileInitAs and friends. We already use that to check the file is searchable at qemu startup time, via: qemuProcessState-> qemuDomainCheckDiskPresence-> qemuDomainDetermineDiskChain-> virStorageFileGetMetadata-> virStorageFileGetMetadataRecurse So I suggest we add a check along those lines in security_dac.c, and if the file is already accessible for the disk's needs, we skip the chown'ing. Thoughts/comments appreciated. Thanks, Cole

3 3

[libvirt] [PATCH] qemu: Check address type for USB disks
by Jiri Denemark 30 Apr '15

30 Apr '15

Only USB addresses are allowed for USB disks. Report an error if another address is configured. https://bugzilla.redhat.com/show_bug.cgi?id=1043436 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_command.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index e62833f..0dc8628 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -4057,6 +4057,7 @@ qemuBuildDriveDevStr(virDomainDefPtr def, disk->info.addr.drive.bus, disk->info.addr.drive.unit); break; + case VIR_DOMAIN_DISK_BUS_SCSI: if (disk->device == VIR_DOMAIN_DISK_DEVICE_LUN) { if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_SCSI_BLOCK)) { @@ -4155,6 +4156,7 @@ qemuBuildDriveDevStr(virDomainDefPtr def, disk->info.addr.drive.unit); } break; + case VIR_DOMAIN_DISK_BUS_SATA: if (disk->info.addr.drive.bus != 0) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", @@ -4194,6 +4196,7 @@ qemuBuildDriveDevStr(virDomainDefPtr def, disk->info.addr.drive.unit); } break; + case VIR_DOMAIN_DISK_BUS_VIRTIO: if (disk->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW) { virBufferAddLit(&opt, "virtio-blk-ccw"); @@ -4227,7 +4230,14 @@ qemuBuildDriveDevStr(virDomainDefPtr def, if (qemuBuildDeviceAddressStr(&opt, def, &disk->info, qemuCaps) < 0) goto error; break; + case VIR_DOMAIN_DISK_BUS_USB: + if (disk->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE && + disk->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_USB) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("unexpected address type for usb disk")); + goto error; + } if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_USB_STORAGE)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("This QEMU doesn't support '-device " @@ -4240,11 +4250,13 @@ qemuBuildDriveDevStr(virDomainDefPtr def, if (qemuBuildDeviceAddressStr(&opt, def, &disk->info, qemuCaps) < 0) goto error; break; + default: virReportError(VIR_ERR_INTERNAL_ERROR, _("unsupported disk bus '%s' with device setup"), bus); goto error; } + virBufferAsprintf(&opt, ",drive=%s%s", QEMU_DRIVE_HOST_PREFIX, disk->info.alias); virBufferAsprintf(&opt, ",id=%s", disk->info.alias); if (bootindex && virQEMUCapsGet(qemuCaps, QEMU_CAPS_BOOTINDEX)) -- 2.3.6

2 2

[libvirt] [PATCH] cpu: Honor vendor_id override in host-model
by Jiri Denemark 30 Apr '15

30 Apr '15

https://bugzilla.redhat.com/show_bug.cgi?id=858147 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/cpu/cpu_x86.c | 6 ++++++ .../qemuxml2argv-cpu-host-model-vendor.args | 20 ++++++++++++++++++++ .../qemuxml2argv-cpu-host-model-vendor.xml | 21 +++++++++++++++++++++ tests/qemuxml2argvtest.c | 1 + 4 files changed, 48 insertions(+) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-host-model-vendor.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-host-model-vendor.xml diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index bf1867b..2a14705 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -2107,6 +2107,12 @@ x86UpdateHostModel(virCPUDefPtr guest, if (virCPUDefCopyModel(guest, host, true) < 0) goto cleanup; + if (oldguest->vendor_id) { + VIR_FREE(guest->vendor_id); + if (VIR_STRDUP(guest->vendor_id, oldguest->vendor_id) < 0) + goto cleanup; + } + /* Remove non-migratable features by default * Note: this only works as long as no CPU model contains non-migratable * features directly */ diff --git a/tests/qemuxml2argvdata/qemuxml2argv-cpu-host-model-vendor.args b/tests/qemuxml2argvdata/qemuxml2argv-cpu-host-model-vendor.args new file mode 100644 index 0000000..5d67d55 --- /dev/null +++ b/tests/qemuxml2argvdata/qemuxml2argv-cpu-host-model-vendor.args @@ -0,0 +1,20 @@ +LC_ALL=C \ +PATH=/bin \ +HOME=/home/test \ +USER=test \ +LOGNAME=test QEMU_AUDIO_DRV=none \ +/usr/bin/qemu \ +-S \ +-M pc \ +-cpu 'core2duo,vendor=Libvirt QEMU,+lahf_lm,+xtpr,+cx16,+tm2,+est,+vmx,\ ++ds_cpl,+pbe,+tm,+ht,+ss,+acpi,+ds' \ +-m 214 \ +-smp 6 \ +-nographic \ +-monitor unix:/tmp/test-monitor,server,nowait \ +-no-acpi \ +-boot n \ +-usb \ +-net none \ +-serial none \ +-parallel none diff --git a/tests/qemuxml2argvdata/qemuxml2argv-cpu-host-model-vendor.xml b/tests/qemuxml2argvdata/qemuxml2argv-cpu-host-model-vendor.xml new file mode 100644 index 0000000..a33362f --- /dev/null +++ b/tests/qemuxml2argvdata/qemuxml2argv-cpu-host-model-vendor.xml @@ -0,0 +1,21 @@ +<domain type='qemu'> + <name>QEMUGuest1</name> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> + <memory unit='KiB'>219100</memory> + <currentMemory unit='KiB'>219100</currentMemory> + <vcpu placement='static'>6</vcpu> + <os> + <type arch='x86_64' machine='pc'>hvm</type> + <boot dev='network'/> + </os> + <cpu mode='host-model'> + <model vendor_id="Libvirt QEMU"/> + </cpu> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <emulator>/usr/bin/qemu</emulator> + </devices> +</domain> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 0763068..670465e 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1245,6 +1245,7 @@ mymain(void) QEMU_CAPS_OBJECT_MEMORY_RAM); DO_TEST_FAILURE("cpu-numa-memshared", QEMU_CAPS_SMP_TOPOLOGY); DO_TEST("cpu-host-model", NONE); + DO_TEST("cpu-host-model-vendor", NONE); skipLegacyCPUs = true; DO_TEST("cpu-host-model-fallback", NONE); DO_TEST_FAILURE("cpu-host-model-nofallback", NONE); -- 2.3.6

2 2

[libvirt] [PATCH] build-aux: make bracket-space.pl more python like
by Daniel P. Berrange 30 Apr '15

30 Apr '15

The libvirt developer community is generally more comfortable with python like languages, so this converts the bracket-spacing.pl test to use python like syntax. It includes one extra external Perl dependancy, but after applying this, there should be no functional change - just prettier syntax. If this is appealing it can be extended to all the Perl scripts in the tree. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- bootstrap.conf | 1 + build-aux/bracket-spacing.pl | 2866 +++++++++++++++++++++++++++++++++++++++--- cfg.mk | 4 +- 3 files changed, 2665 insertions(+), 206 deletions(-) diff --git a/bootstrap.conf b/bootstrap.conf index c06ee4c..f55466f 100644 --- a/bootstrap.conf +++ b/bootstrap.conf @@ -210,6 +210,7 @@ gzip - libtool - patch - perl 5.5 +perl::Acme::Python - perl::XML::XPath - pkg-config - python-config - diff --git a/build-aux/bracket-spacing.pl b/build-aux/bracket-spacing.pl index 5bc96d2..9114352 100755 --- a/build-aux/bracket-spacing.pl +++ b/build-aux/bracket-spacing.pl @@ -1,204 +1,2662 @@ -#!/usr/bin/perl -# -# bracket-spacing.pl: Report any usage of 'function (..args..)' -# Also check for other syntax issues, such as correct use of ';' -# -# This library is free software; you can redistribute it and/or -# modify it under the terms of the GNU Lesser General Public -# License as published by the Free Software Foundation; either -# version 2.1 of the License, or (at your option) any later version. -# -# This library is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -# Lesser General Public License for more details. -# -# You should have received a copy of the GNU Lesser General Public -# License along with this library. If not, see -# <http://www.gnu.org/licenses/>. -# -# Authors: -# Daniel P. Berrange <berrange(a)redhat.com> - -use strict; -use warnings; - -my $ret = 0; -my $incomment = 0; - -foreach my $file (@ARGV) { - # Per-file variables for multiline Curly Bracket (cb_) check - my $cb_linenum = 0; - my $cb_code = ""; - my $cb_scolon = 0; - - open FILE, $file; - - while (defined (my $line = <FILE>)) { - my $data = $line; - # For temporary modifications - my $tmpdata; - - # Kill any quoted , ; = or " - $data =~ s/'[";,=]'/'X'/g; - - # Kill any quoted strings - $data =~ s,"([^\\\"]|\\.)*","XXX",g; - - # Kill any C++ style comments - $data =~ s,//.*$,//,; - - next if $data =~ /^#/; - - # Kill contents of multi-line comments - # and detect end of multi-line comments - if ($incomment) { - if ($data =~ m,\*/,) { - $incomment = 0; - $data =~ s,^.*\*/,*/,; - } else { - $data = ""; - } - } - - # Kill single line comments, and detect - # start of multi-line comments - if ($data =~ m,/\*.*\*/,) { - $data =~ s,/\*.*\*/,/* */,; - } elsif ($data =~ m,/\*,) { - $incomment = 1; - $data =~ s,/\*.*,/*,; - } - - # We need to match things like - # - # int foo (int bar, bool wizz); - # foo (bar, wizz); - # - # but not match things like: - # - # typedef int (*foo)(bar wizz) - # - # we can't do this (efficiently) without - # missing things like - # - # foo (*bar, wizz); - # - # We also don't want to spoil the $data so it can be used - # later on. - $tmpdata = $data; - while ($tmpdata =~ /(\w+)\s$(?!\*)/) { - my $kw = $1; - - # Allow space after keywords only - if ($kw =~ /^(if|for|while|switch|return)$/) { - $tmpdata =~ s/($kw\s\()/XXX(/; - } else { - print "Whitespace after non-keyword:\n"; - print "$file:$.: $line"; - $ret = 1; - last; - } - } - - # Require whitespace immediately after keywords, - # but none after the opening bracket - if ($data =~ /\b(if|for|while|switch|return)\(/ || - $data =~ /\b(if|for|while|switch|return)\s+\(\s/) { - print "No whitespace after keyword:\n"; - print "$file:$.: $line"; - $ret = 1; - } - - # Forbid whitespace between )( of a function typedef - if ($data =~ /\(\*\w+$\s+$/) { - print "Whitespace between ')' and '(':\n"; - print "$file:$.: $line"; - $ret = 1; - } - - # Forbid whitespace following ( or prior to ) - if ($data =~ /\S\s+$/ || - $data =~ /\(\s+\S/) { - print "Whitespace after '(' or before ')':\n"; - print "$file:$.: $line"; - $ret = 1; - } - - # Forbid whitespace before ";" or ",". Things like below are allowed: - # - # 1) The expression is empty for "for" loop. E.g. - # for (i = 0; ; i++) - # - # 2) An empty statement. E.g. - # while (write(statuswrite, &status, 1) == -1 && - # errno == EINTR) - # ; - # - if ($data =~ /[^;\s]\s+[;,]/) { - print "Whitespace before (semi)colon:\n"; - print "$file:$.: $line"; - $ret = 1; - } - - # Require EOL, macro line continuation, or whitespace after ";". - # Allow "for (;;)" as an exception. - if ($data =~ /;[^ \\\n;)]/) { - print "Invalid character after semicolon:\n"; - print "$file:$.: $line"; - $ret = 1; - } - - # Require EOL, space, or enum/struct end after comma. - if ($data =~ /,[^ \\\n)}]/) { - print "Invalid character after comma:\n"; - print "$file:$.: $line"; - $ret = 1; - } - - # Require spaces around assignment '=', compounds and '==' - # with the exception of virAssertCmpInt() - $tmpdata = $data; - $tmpdata =~ s/(virAssertCmpInt\(.* ).?=,/$1op,/; - if ($tmpdata =~ /[^ ]\b[!<>&|\-+*\/%\^=]?=[^=]/ || - $tmpdata =~ /=[^= \\\n]/) { - print "Spacing around '=' or '==':\n"; - print "$file:$.: $line"; - $ret = 1; - } - - # One line conditional statements with one line bodies should - # not use curly brackets. - if ($data =~ /^\s*(if|while|for)\b.*\{$/) { - $cb_linenum = $.; - $cb_code = $line; - $cb_scolon = 0; - } - - # We need to check for exactly one semicolon inside the body, - # because empty statements (e.g. with comment only) are - # allowed - if ($cb_linenum == $. - 1 && $data =~ /^[^;]*;[^;]*$/) { - $cb_code .= $line; - $cb_scolon = 1; - } - - if ($data =~ /^\s*}\s*$/ && - $cb_linenum == $. - 2 && - $cb_scolon) { - - print "Curly brackets around single-line body:\n"; - print "$file:$cb_linenum-$.:\n$cb_code$line"; - $ret = 1; - - # There _should_ be no need to reset the values; but to - # keep my inner peace... - $cb_linenum = 0; - $cb_scolon = 0; - $cb_code = ""; - } - } - close FILE; -} - -exit $ret; +use Acme::Python; +Hisssssssssssssssss +Hiss hiss Hiss hiss Hissss hiss Hisss hisss +Hissss hiss Hiss hiss Hiss hisss Hisss hisssssss +Hiss hisss Hisss hisss Hissss hissss Hiss +hiss Hissss hisss Hiss hisss Hissss hiss +Hiss hisss Hiss hiss Hisss hiss Hisss hissss +Hisss hissss Hiss hiss Hissss hiss Hisss +hiss Hissss hissss Hiss hiss Hiss hisssss +Hiss hiss Hiss hiss Hissss hiss Hisss hisss +Hissss hiss Hiss hiss Hiss hisss Hisss hisssssss +Hiss hisss Hissss hiss Hissss hiss Hiss hisssss +Hisss hisss Hiss hisss Hissss hisss Hissss +hiss Hisss hiss Hiss hisss Hiss hiss Hisss +hisss Hissss hiss Hisss hiss Hissss hisss +Hisss hiss Hisss hisss Hissss hiss Hisss +hiss Hissss hissss Hiss hiss Hiss hissssss +Hiss hiss Hiss hisssss Hiss hiss Hisss hiss +Hisss hiss Hiss hisss Hisssss hisssssss Hiss +hisssss Hiss hisss Hiss hissss Hiss hisss +Hissss hiss Hiss hiss Hiss hisss Hisss hissss +Hiss hiss Hissss hisssssss Hiss hisss Hiss +hiss Hisssss hissssssss Hiss hisssssss Hisss +hisss Hisss hiss Hissss hissss Hiss hiss +Hiss hisssss Hiss hiss Hisss hiss Hisss hiss +Hiss hisss Hisssss hisssssss Hiss hisssss +Hiss hisss Hiss hisss Hiss hisss Hiss hiss +Hisss hisss Hissss hiss Hisss hiss Hisss +hissss Hisss hiss Hisssss hiss Hisss hiss +Hiss hiss Hisss hiss Hisss hiss Hiss hiss +Hisss hiss Hisss hiss Hiss hiss Hiss hisss +Hisss hisss Hissss hiss Hisss hissss Hiss +hiss Hissss hisssssss Hiss hisss Hiss hiss +Hisssss hissssssss Hiss hisssssss Hisss hisss +Hisss hiss Hissss hissss Hiss hiss Hiss hissssss +Hiss hiss Hiss hissssss Hisss hisss Hisss +hiss Hisssss hiss Hisss hisss Hiss hisss +Hissss hiss Hiss hiss Hiss hisss Hisss hiss +Hiss hisssss Hisss hiss Hisss hissss Hisss +hisssss Hiss hiss Hisss hisssssss Hiss hisss +Hiss hiss Hisss hiss Hisss hiss Hiss hisss +Hisssss hisssssss Hiss hisssss Hiss hisss +Hiss hissss Hisss hisss Hisss hiss Hiss hisss +Hiss hiss Hisss hissss Hisss hiss Hisss hiss +Hiss hiss Hiss hisss Hisss hisssssss Hiss +hissssss Hiss hiss Hiss hisssssssss Hiss +hiss Hiss hissssss Hiss hisss Hiss hisss +Hiss hiss Hiss hiss Hissss hissss Hiss hisss +Hisss hiss Hiss hiss Hiss hiss Hiss hisss +Hiss hiss Hiss hissssssss Hiss hisss Hisss +hiss Hisssss hisss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisss Hisss hissss Hiss hissssssss Hiss +hisssssss Hiss hiss Hiss hiss Hiss hiss Hiss +hisss Hisss hisss Hiss hisss Hissss hiss +Hiss hiss Hisss hiss Hiss hissss Hisss hisss +Hisss hiss Hiss hisss Hiss hiss Hisss hissss +Hisss hiss Hisss hiss Hiss hiss Hiss hisss +Hisss hisssssss Hiss hissss Hisss hiss Hissss +hiss Hiss hisssss Hisss hisss Hiss hisss +Hissss hiss Hiss hisss Hiss hiss Hisss hiss +Hiss hisssss Hisss hisss Hiss hissss Hisss +hissss Hisss hiss Hisss hiss Hiss hiss Hiss +hisss Hisss hiss Hisss hisss Hissss hisssssss +Hiss hissss Hisss hisss Hisss hiss Hisssss +hiss Hisss hisss Hiss hisss Hissss hisssssss +Hiss hisss Hiss hiss Hisss hiss Hisss hiss +Hiss hiss Hiss hiss Hissss hissss Hisss hiss +Hisss hissss Hiss hiss Hissss hiss Hiss hisss +Hiss hiss Hisss hissss Hisss hiss Hisss hiss +Hiss hisss Hiss hiss Hisss hisss Hissss hiss +Hisss hiss Hiss hiss Hiss hisss Hisss hisssssss +Hiss hisss Hisss hisssss Hiss hiss Hiss hiss +Hiss hiss Hissss hisss Hiss hisss Hissss +hissss Hisss hiss Hisss hiss Hiss hisss Hisssss +hisssssss Hiss hissss Hiss hisssss Hiss hisss +Hiss hisss Hissss hiss Hiss hisssss Hisss +hiss Hisss hissss Hisss hiss Hisss hiss Hiss +hiss Hisss hiss Hiss hiss Hiss hisss Hisss +hissss Hiss hiss Hissss hisssssss Hiss hissssss +Hiss hiss Hiss hisss Hisss hissss Hisss hisss +Hiss hissss Hisss hiss Hissssss hiss Hiss +hiss Hiss hisss Hiss hiss Hiss hissssssss +Hiss hisss Hisss hissss Hisss hisssss Hiss +hiss Hisss hiss Hiss hiss Hiss hisss Hisss +hiss Hisss hissss Hisss hiss Hisss hiss Hiss +hiss Hisss hisss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisss Hiss hiss Hisss hiss Hisss hiss +Hiss hisss Hisssss hisssssss Hiss hisssss +Hiss hisss Hiss hisss Hisss hissss Hisss +hisss Hiss hissss Hisss hiss Hissssss hiss +Hiss hissss Hisss hiss Hisss hiss Hiss hisss +Hiss hiss Hisss hisss Hissss hiss Hisss hiss +Hiss hiss Hiss hisss Hisss hisss Hissss hiss +Hisss hiss Hiss hiss Hiss hiss Hissss hiss +Hiss hiss Hisss hiss Hisss hisssssss Hiss +hisss Hiss hiss Hisssss hissssssss Hiss hisssssss +Hisss hisss Hisss hiss Hissss hissss Hiss +hiss Hiss hissssssssss Hiss hissssssss Hiss +hissssssss Hiss hissssssss Hiss hisss Hiss +hiss Hisss hiss Hisss hiss Hiss hisss Hisssss +hisssssss Hiss hisssss Hiss hisss Hiss hisss +Hisss hissss Hisss hisss Hiss hissss Hisss +hiss Hissssss hiss Hiss hiss Hisss hissss +Hisss hiss Hisssss hiss Hisss hissss Hiss +hisss Hisss hiss Hiss hiss Hiss hisss Hisss +hisssssss Hiss hisss Hiss hiss Hisssss hissssssss +Hiss hissss Hiss hissss Hiss hissss Hiss +hissss Hiss hisss Hisss hiss Hissss hissss +Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisss +Hiss hiss Hisss hiss Hisss hiss Hiss hisss +Hisssss hisssssss Hiss hisssss Hiss hisss +Hiss hisss Hisss hissss Hisss hisss Hiss +hissss Hisss hiss Hissssss hiss Hiss hiss +Hisss hisss Hissss hiss Hisss hissss Hisss +hiss Hisssss hiss Hisss hissss Hisss hiss +Hisss hiss Hisssss hiss Hisss hisss Hissss +hiss Hisss hisssssss Hiss hisss Hiss hiss +Hisssss hissssssss Hiss hisssssss Hisss hisss +Hisss hiss Hissss hissss Hiss hiss Hiss hissssss +Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisss +Hisssss hiss Hisss hissssss Hissss hiss Hiss +hiss Hiss hisss Hisss hisss Hissss hiss Hisss +hisssssss Hiss hissss Hisss hissss Hiss hiss +Hiss hisss Hiss hisss Hiss hissss Hisss hisss +Hiss hiss Hiss hiss Hiss hissss Hiss hissss +Hisss hiss Hiss hissssssss Hiss hisssss Hiss +hisss Hiss hissss Hisss hisss Hisss hiss +Hiss hisss Hiss hiss Hisss hissss Hisss hiss +Hisss hiss Hiss hiss Hiss hisss Hisss hiss +Hisss hiss Hissss hissss Hiss hiss Hiss hissssss +Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisss +Hissss hiss Hissss hisssss Hiss hiss Hisss +hiss Hiss hisss Hiss hiss Hisss hissss Hisss +hiss Hisss hiss Hiss hiss Hiss hisss Hisss +hisssssss Hiss hissssss Hiss hiss Hiss hisssss +Hiss hisss Hisss hiss Hiss hiss Hiss hisss +Hisss hisss Hisss hisss Hisss hiss Hiss hisss +Hiss hiss Hisss hisss Hissss hiss Hisss hiss +Hiss hiss Hiss hisss Hisss hissss Hiss hisss +Hisss hisssssss Hiss hissssss Hiss hiss Hiss +hisss Hiss hiss Hisss hiss Hisss hiss Hiss +hisss Hisssss hisssssss Hiss hisssss Hiss +hisss Hiss hisssss Hisss hiss Hisss hiss +Hiss hisss Hiss hiss Hisss hisss Hissss hiss +Hisss hiss Hiss hiss Hiss hisss Hisss hisssssss +Hiss hisss Hiss hiss Hisssss hissssssss Hiss +hisssss Hisssss hissss Hisss hissss Hiss +hiss Hiss hisss Hiss hisss Hiss hissss Hisss +hisss Hiss hiss Hiss hiss Hiss hissss Hiss +hisss Hissssss hisss Hiss hisss Hiss hiss +Hiss hisss Hiss hisss Hiss hiss Hiss hissssssss +Hiss hisss Hisss hiss Hisssss hisss Hiss +hiss Hiss hissssssssss Hiss hissssssss Hiss +hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisss Hiss hiss Hisss hiss Hisss hiss +Hiss hisss Hisssss hisssssss Hiss hisssss +Hiss hisss Hiss hisssss Hiss hisss Hisss +hiss Hiss hisssss Hisss hissss Hiss hiss +Hissss hiss Hiss hisssss Hisss hisssssss +Hiss hisss Hiss hiss Hisssss hissssssss Hiss +hisssss Hiss hisss Hiss hisssss Hisss hiss +Hisss hiss Hiss hisss Hiss hiss Hisss hisss +Hissss hiss Hisss hiss Hiss hiss Hiss hisss +Hisss hiss Hisss hiss Hissss hissss Hiss +hiss Hiss hissssssssss Hiss hissssssss Hiss +hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisss Hisss hissss Hiss hissssssss Hiss +hissss Hisss hissss Hiss hiss Hisssss hiss +Hisss hisss Hiss hisss Hissss hisssssss Hiss +hisssss Hiss hiss Hissss hiss Hiss hiss Hiss +hisss Hisss hiss Hiss hiss Hisss hiss Hisss +hissssss Hissss hiss Hisssss hiss Hisss hisss +Hiss hisss Hissss hiss Hiss hisssss Hisss +hisss Hiss hisss Hissss hiss Hiss hisss Hisssss +hisssssss Hiss hisss Hiss hiss Hisss hiss +Hisss hiss Hisssss hiss Hisss hissss Hiss +hisss Hisss hiss Hiss hisss Hiss hiss Hisss +hisss Hisss hisss Hisss hiss Hiss hisss Hiss +hiss Hisss hiss Hisss hissss Hisss hiss Hiss +hisssss Hisss hissss Hiss hiss Hissss hiss +Hiss hisss Hiss hiss Hisss hiss Hisssss hiss +Hisss hisss Hissss hiss Hisss hiss Hisss +hisss Hissss hisss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hiss hiss Hisss +hiss Hisss hiss Hiss hisss Hisssss hisssssss +Hiss hisssss Hiss hisss Hiss hisssss Hiss +hiss Hissss hiss Hiss hiss Hisss hiss Hisss +hissssss Hissss hissss Hiss hisss Hisss hiss +Hiss hisssss Hisss hissss Hiss hiss Hissss +hiss Hiss hisssss Hisss hiss Hisss hiss Hissss +hissss Hiss hiss Hiss hissssss Hiss hiss +Hiss hissssssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisss +Hisss hissss Hiss hissssssss Hiss hisss Hisss +hiss Hiss hisss Hiss hiss Hiss hisss Hiss +hiss Hisss hissss Hisss hiss Hisss hissss +Hisss hiss Hisss hisssssss Hiss hisss Hiss +hisssss Hisss hisss Hissss hiss Hisss hiss +Hiss hisss Hisssss hisssssss Hiss hisss Hiss +hissss Hissss hiss Hiss hiss Hiss hiss Hissss +hiss Hisssss hiss Hisss hissss Hiss hiss +Hissss hiss Hiss hiss Hiss hisss Hisss hissss +Hiss hisss Hisss hisssssss Hiss hisssss Hisss +hiss Hiss hissssssss Hiss hisss Hisss hiss +Hissss hissssssss Hiss hisss Hiss hiss Hisssss +hissssssss Hiss hisss Hisssss hiss Hisss +hisss Hiss hisss Hissss hisssssss Hiss hissss +Hiss hissss Hiss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssss Hiss hisss Hiss +hisssss Hiss hisss Hisss hiss Hiss hisssss +Hisss hissss Hiss hiss Hissss hiss Hiss hisssss +Hisss hisssssss Hiss hisss Hiss hiss Hisssss +hissss Hisssssss hisssssss Hiss hisss Hisss +hisss Hissss hiss Hisssss hiss Hiss hisss +Hissss hisss Hiss hisss Hisss hiss Hisss +hiss Hiss hisss Hiss hissss Hiss hisss Hisss +hiss Hissss hisssss Hisss hiss Hiss hisss +Hiss hiss Hisssss hisss Hiss hiss Hissss +hiss Hiss hiss Hissss hisss Hiss hisss Hisssss +hiss Hiss hisss Hissss hisss Hiss hissssss +Hisss hiss Hiss hiss Hissss hisss Hiss hisss +Hisssss hiss Hiss hisss Hissss hisss Hisss +hiss Hisss hiss Hissss hissss Hiss hiss Hiss +hissssss Hiss hiss Hiss hissssssssss Hiss +hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hisss hissss Hiss +hissssssss Hiss hisss Hisss hiss Hiss hisss +Hiss hiss Hiss hisss Hiss hiss Hisss hissss +Hisss hiss Hisss hissss Hisss hiss Hisss +hisssssss Hiss hisss Hiss hisssss Hisss hisss +Hissss hiss Hisss hiss Hiss hisss Hisssss +hisssssss Hiss hisss Hiss hissss Hissss hiss +Hiss hiss Hiss hiss Hissss hiss Hisssss hiss +Hisss hissss Hiss hiss Hissss hiss Hiss hiss +Hiss hisss Hisss hissss Hiss hisss Hisss +hisssssss Hiss hisss Hisss hisss Hissss hissss +Hiss hiss Hissss hisss Hiss hisss Hissss +hiss Hiss hisss Hiss hiss Hisss hisss Hissss +hiss Hisss hiss Hissss hisss Hisss hiss Hisss +hisss Hissss hisss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssss Hiss hisss Hiss +hisssss Hiss hisss Hisss hiss Hiss hisssss +Hisss hissss Hiss hiss Hissss hiss Hiss hisssss +Hisss hisssssss Hiss hisss Hiss hiss Hisssss +hissss Hisssssss hisssssss Hiss hisss Hisss +hisss Hissss hissss Hisss hiss Hiss hissss +Hiss hissss Hiss hissssss Hiss hiss Hiss +hisss Hisss hiss Hisss hiss Hiss hisss Hisssss +hiss Hiss hissss Hissss hiss Hiss hissss +Hissss hiss Hiss hissss Hissss hiss Hiss +hisss Hiss hissss Hiss hisss Hiss hiss Hissss +hiss Hiss hissss Hissssss hissss Hissss hiss +Hiss hissss Hissss hiss Hiss hisss Hissss +hiss Hiss hisss Hiss hisss Hiss hiss Hiss +hissss Hiss hiss Hiss hiss Hiss hissss Hiss +hissss Hiss hisssss Hisss hiss Hiss hissss +Hiss hissss Hiss hissssss Hisss hiss Hiss +hisssss Hisss hiss Hiss hisssss Hisss hiss +Hiss hisss Hiss hissss Hiss hisssss Hisss +hiss Hiss hisss Hissss hisss Hisss hiss Hisss +hiss Hissss hissss Hiss hiss Hiss hissssss +Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisss Hisss hissss Hiss hissssssss Hiss +hisss Hisss hiss Hiss hisss Hiss hiss Hiss +hisss Hiss hiss Hisss hissss Hisss hiss Hisss +hissss Hisss hiss Hisss hisssssss Hiss hisss +Hiss hisssss Hisss hisss Hissss hiss Hisss +hiss Hiss hisss Hisssss hisssssss Hiss hisss +Hisss hisssss Hiss hiss Hisss hiss Hiss hiss +Hiss hisss Hisss hiss Hiss hiss Hiss hissssssss +Hiss hisss Hisss hisss Hissss hissss Hiss +hiss Hissss hiss Hiss hisss Hisssss hissss +Hisss hiss Hisss hiss Hiss hiss Hiss hisss +Hisss hisssssss Hiss hisss Hisss hissss Hisss +hiss Hisssss hiss Hisss hiss Hiss hiss Hisss +hiss Hisss hiss Hiss hiss Hisss hiss Hisss +hiss Hiss hiss Hiss hisss Hisss hisss Hissss +hiss Hisss hissss Hiss hiss Hissss hiss Hisss +hisss Hissss hisss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssss Hiss hisss Hiss +hisssss Hiss hisss Hisss hiss Hiss hisssss +Hisss hissss Hiss hiss Hissss hiss Hiss hisssss +Hisss hisssssss Hiss hisss Hiss hiss Hisssss +hissss Hisssssss hisssssss Hiss hisss Hisss +hisss Hissss hissss Hisss hiss Hiss hisss +Hisssss hiss Hiss hisss Hisssss hiss Hiss +hissss Hissss hiss Hiss hissss Hiss hiss +Hiss hiss Hiss hisssss Hiss hisss Hiss hisssss +Hisss hiss Hiss hisss Hisssss hiss Hiss hisss +Hisssss hiss Hiss hisssss Hisss hiss Hiss +hisss Hisss hiss Hissss hissss Hiss hiss +Hiss hissssss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissss Hissss hiss Hisss +hiss Hiss hiss Hiss hisss Hisss hisssss Hisssss +hissss Hiss hiss Hissss hisssssss Hiss hisss +Hiss hisss Hiss hiss Hisss hisss Hisss hisss +Hisss hisssssss Hiss hisssss Hiss hisss Hiss +hisssss Hiss hisss Hisss hiss Hiss hisssss +Hisss hissss Hiss hiss Hissss hiss Hiss hisssss +Hisss hisssssss Hiss hisss Hiss hiss Hisssss +hissss Hisssssss hisssssss Hiss hisss Hisssss +hiss Hiss hissss Hisssss hiss Hiss hiss Hisss +hissss Hiss hisss Hisssss hiss Hiss hisss +Hisss hiss Hissss hissss Hiss hiss Hiss hissssss +Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisss Hisss hissss Hiss hissssssss Hiss +hisss Hisss hiss Hiss hisss Hiss hiss Hiss +hisss Hiss hiss Hisss hissss Hisss hiss Hisss +hissss Hisss hiss Hisss hisssssss Hiss hisss +Hisss hissss Hisss hiss Hisssss hiss Hisss +hisss Hissss hiss Hisss hissss Hiss hiss +Hissss hiss Hiss hiss Hiss hisss Hisss hisss +Hissss hiss Hisss hissss Hiss hiss Hissss +hiss Hisss hisss Hissss hisssssss Hiss hisss +Hisssss hiss Hisss hisss Hisss hisss Hisss +hisssssss Hiss hisss Hiss hiss Hisss hiss +Hisss hiss Hiss hiss Hiss hiss Hissss hissss +Hisss hiss Hisss hissss Hiss hiss Hissss +hiss Hiss hisss Hiss hiss Hisss hiss Hiss +hiss Hisss hiss Hiss hisssss Hisss hiss Hisss +hiss Hiss hisss Hiss hiss Hisss hisss Hissss +hiss Hisss hiss Hiss hiss Hiss hisss Hisss +hisssssss Hiss hisss Hisss hissss Hisss hiss +Hisssss hiss Hisss hiss Hiss hiss Hisss hiss +Hisss hiss Hiss hiss Hisss hiss Hisss hiss +Hiss hiss Hiss hisss Hisss hisss Hissss hiss +Hisss hissss Hiss hiss Hissss hiss Hisss +hisss Hissss hisss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hisss hissss Hiss +hissssssss Hiss hisss Hiss hisssss Hisss +hisss Hissss hiss Hisss hissss Hiss hisss +Hisss hisssssss Hiss hisssss Hiss hisss Hisss +hiss Hiss hiss Hiss hisss Hisss hissss Hiss +hiss Hissss hiss Hiss hiss Hiss hisss Hisss +hiss Hisss hissss Hisss hissss Hiss hiss +Hissss hisssssss Hiss hisss Hiss hiss Hiss +hisss Hisss hisss Hissss hiss Hisss hissss +Hiss hisss Hisss hisssssss Hiss hisss Hisssss +hiss Hisss hisss Hisss hisss Hisss hisssssss +Hiss hisss Hiss hiss Hisss hiss Hisss hiss +Hiss hiss Hiss hiss Hissss hissss Hisss hiss +Hisss hissss Hiss hiss Hissss hiss Hiss hisss +Hiss hiss Hisss hiss Hiss hiss Hisss hiss +Hiss hisssss Hisss hiss Hisss hiss Hiss hisss +Hiss hiss Hisss hisss Hissss hiss Hisss hiss +Hiss hiss Hiss hisss Hisss hisssssss Hiss +hisss Hisss hissss Hisss hiss Hisssss hiss +Hisss hiss Hiss hiss Hisss hiss Hisss hiss +Hiss hiss Hisss hiss Hisss hiss Hiss hiss +Hiss hisss Hisss hisss Hissss hiss Hisss +hissss Hiss hiss Hissss hiss Hisss hisss +Hissss hisss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hiss hisss Hiss +hiss Hisss hisss Hisss hisss Hisss hisssssss +Hiss hissssss Hiss hiss Hiss hisssss Hiss +hisss Hiss hisss Hiss hisss Hiss hiss Hisss +hisss Hissss hiss Hisss hiss Hisss hissss +Hisss hiss Hisssss hiss Hisss hiss Hiss hiss +Hisss hiss Hisss hiss Hiss hiss Hisss hiss +Hisss hiss Hiss hiss Hiss hisss Hisss hisss +Hissss hiss Hisss hissss Hiss hiss Hissss +hiss Hiss hisss Hiss hiss Hiss hissssssss +Hiss hisss Hisss hiss Hisssss hisss Hiss +hiss Hiss hissssssssss Hiss hissssssss Hiss +hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hiss hisss Hiss +hiss Hisss hisss Hisss hisss Hisss hisssssss +Hiss hissssss Hiss hiss Hiss hisssss Hiss +hisss Hiss hisssss Hiss hisss Hisss hiss +Hiss hisssss Hisss hissss Hiss hiss Hissss +hiss Hiss hisssss Hisss hisssssss Hiss hisss +Hiss hiss Hisssss hissss Hisssssss hisssssss +Hiss hisss Hiss hiss Hisss hiss Hisss hissss +Hisss hiss Hiss hisssss Hissss hiss Hiss +hisss Hiss hiss Hiss hiss Hiss hisss Hisssss +hiss Hiss hisssss Hisss hiss Hiss hisss Hiss +hisss Hiss hiss Hiss hissssssss Hiss hisss +Hisss hiss Hisssss hisss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisssss Hiss hisss Hiss hisss Hiss hisss +Hiss hiss Hisss hisss Hissss hiss Hisss hiss +Hisss hissss Hisss hiss Hisssss hiss Hisss +hiss Hiss hiss Hisss hiss Hisss hiss Hiss +hiss Hisss hiss Hisss hiss Hiss hiss Hiss +hisss Hisss hisss Hissss hiss Hisss hissss +Hiss hiss Hissss hisssssss Hiss hisss Hiss +hiss Hisssss hissssssss Hiss hisssssss Hisss +hisss Hisss hiss Hissss hissss Hiss hiss +Hiss hissssssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssss Hiss hisss Hiss +hisssss Hiss hisss Hisss hiss Hiss hisssss +Hisss hissss Hiss hiss Hissss hiss Hiss hisssss +Hisss hisssssss Hiss hisss Hiss hiss Hisssss +hissss Hisssssss hisssssss Hiss hisss Hisss +hisss Hissss hissss Hisss hiss Hiss hissss +Hisssss hiss Hiss hisss Hissss hiss Hiss +hissss Hiss hiss Hiss hiss Hiss hisssss Hissss +hiss Hiss hisss Hiss hiss Hiss hiss Hiss +hisss Hisssss hiss Hiss hisssss Hisss hiss +Hiss hissss Hiss hiss Hiss hiss Hiss hisss +Hisssss hiss Hiss hisssss Hisss hiss Hiss +hisss Hisss hiss Hissss hissss Hiss hiss +Hiss hissssssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisss Hiss hiss Hissssss hisssssss Hiss +hisss Hiss hiss Hiss hisss Hisss hissss Hisss +hiss Hisss hiss Hisss hisss Hissss hiss Hiss +hiss Hiss hisss Hisss hisssssss Hiss hisss +Hisss hiss Hisssss hisss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisssss Hiss hisss Hiss hisssss Hiss +hisss Hisss hiss Hiss hisssss Hisss hissss +Hiss hiss Hissss hiss Hiss hisssss Hisss +hisssssss Hiss hisss Hiss hiss Hisssss hissssssss +Hiss hissss Hiss hissss Hiss hissss Hiss +hissss Hiss hisss Hisss hiss Hissss hissss +Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hiss hiss Hissssss +hisss Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisss Hiss hiss Hissssss hisss Hiss +hiss Hiss hissssss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hisss hissss Hiss +hissssssss Hiss hisss Hisss hiss Hiss hisss +Hiss hiss Hiss hisss Hiss hiss Hisss hissss +Hisss hiss Hisss hissss Hisss hiss Hisss +hisssssss Hiss hisss Hisss hisss Hissss hiss +Hiss hisss Hiss hiss Hisss hisss Hissss hiss +Hisss hiss Hissss hisss Hisss hissss Hisss +hiss Hisss hiss Hiss hiss Hiss hisss Hisss +hisssssss Hiss hisssss Hisss hiss Hisss hiss +Hiss hisss Hiss hiss Hisss hisss Hissss hiss +Hisss hiss Hiss hiss Hiss hisss Hisss hisssssss +Hiss hisss Hisss hissss Hisss hiss Hisssss +hiss Hisss hiss Hiss hiss Hisss hiss Hisss +hiss Hiss hiss Hisss hiss Hisss hiss Hiss +hiss Hiss hisss Hisss hisss Hissss hiss Hisss +hissss Hiss hiss Hissss hiss Hisss hisss +Hissss hissss Hisss hiss Hiss hissssssss +Hiss hisss Hiss hisssss Hisss hisss Hissss +hiss Hisss hissss Hiss hisss Hisss hisssssss +Hiss hisssss Hiss hisss Hisss hiss Hiss hiss +Hiss hisss Hisss hissss Hiss hiss Hissss +hiss Hiss hiss Hiss hisss Hisss hiss Hisss +hissss Hisss hissss Hiss hiss Hissss hisss +Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisss Hisss hissss Hiss hissssssss Hiss +hisss Hisss hisss Hissss hissss Hiss hiss +Hissss hiss Hiss hisssss Hisss hisss Hiss +hisss Hissss hissss Hiss hiss Hissss hisssssss +Hiss hisss Hisssss hiss Hisss hisss Hisss +hisss Hisss hisssssss Hiss hisss Hiss hiss +Hisss hiss Hisss hiss Hiss hiss Hiss hiss +Hissss hissss Hisss hiss Hisss hissss Hiss +hiss Hissss hiss Hiss hisss Hiss hiss Hisss +hiss Hiss hiss Hisss hiss Hiss hisssss Hisss +hiss Hisss hiss Hiss hisss Hiss hiss Hisss +hisss Hissss hiss Hisss hiss Hiss hiss Hiss +hisss Hisss hisssssss Hiss hisss Hisss hissss +Hisss hiss Hisssss hiss Hisss hiss Hiss hiss +Hisss hiss Hisss hiss Hiss hiss Hisss hiss +Hisss hiss Hiss hiss Hiss hisss Hisss hisss +Hissss hiss Hisss hissss Hiss hiss Hissss +hiss Hisss hisss Hissss hisss Hiss hiss Hiss +hissssssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisss +Hiss hisss Hiss hiss Hisss hisss Hisss hisss +Hisss hisssssss Hiss hissssss Hiss hiss Hiss +hisssss Hiss hisss Hiss hisssss Hiss hisss +Hisss hiss Hiss hisssss Hisss hissss Hiss +hiss Hissss hiss Hiss hisssss Hisss hisssssss +Hiss hisss Hiss hiss Hisssss hissss Hisssssss +hisssssss Hiss hisss Hiss hiss Hisss hiss +Hisss hissss Hisss hiss Hiss hisss Hisssss +hiss Hiss hisssss Hissss hiss Hiss hisss +Hiss hiss Hiss hiss Hiss hissss Hissss hiss +Hiss hissss Hiss hiss Hiss hiss Hiss hisssss +Hissss hiss Hiss hisss Hiss hiss Hiss hiss +Hiss hisss Hisssss hiss Hiss hisssss Hisss +hiss Hiss hisss Hiss hisss Hiss hiss Hiss +hissssssss Hiss hisss Hisss hiss Hisssss +hisss Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssss Hiss hisss Hiss +hisssss Hiss hisss Hisss hiss Hiss hisssss +Hisss hissss Hiss hiss Hissss hiss Hiss hisssss +Hisss hisssssss Hiss hisss Hiss hiss Hisssss +hissss Hisssssss hisssssss Hiss hisss Hisss +hisss Hissss hissss Hisss hiss Hiss hisss +Hisssss hiss Hiss hisssss Hissss hiss Hiss +hisss Hiss hiss Hiss hiss Hiss hissss Hissss +hiss Hiss hissss Hiss hiss Hiss hiss Hiss +hisssss Hissss hiss Hiss hisss Hiss hiss +Hiss hiss Hiss hisss Hisssss hiss Hiss hisssss +Hisss hiss Hiss hisss Hisssss hiss Hiss hissss +Hiss hiss Hiss hiss Hiss hissssssss Hiss +hissss Hiss hiss Hiss hiss Hiss hisss Hisssss +hiss Hiss hisssss Hisss hiss Hiss hisss Hisss +hiss Hissss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hiss hiss Hissssss +hisssssss Hiss hisss Hiss hiss Hiss hisss +Hisss hissss Hisss hiss Hisss hiss Hisss +hisss Hissss hiss Hiss hisss Hiss hiss Hisss +hisss Hisss hisss Hisss hisssssss Hiss hissssss +Hiss hiss Hiss hisssss Hiss hisss Hiss hisssss +Hiss hisss Hisss hiss Hiss hisssss Hisss +hissss Hiss hiss Hissss hiss Hiss hisssss +Hisss hisssssss Hiss hisss Hiss hiss Hisssss +hissss Hisssssss hisssssss Hiss hisss Hiss +hiss Hisss hiss Hisss hissss Hisss hiss Hiss +hisss Hisssss hiss Hiss hisssss Hissss hiss +Hiss hisss Hiss hiss Hiss hiss Hiss hisssss +Hisss hiss Hiss hisss Hiss hisss Hiss hiss +Hiss hissssssss Hiss hisss Hisss hiss Hisssss +hisss Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssss Hiss hisss Hiss +hisss Hiss hisss Hiss hiss Hisss hisss Hissss +hiss Hisss hiss Hisss hissss Hisss hiss Hisssss +hiss Hisss hiss Hiss hiss Hisss hiss Hisss +hiss Hiss hiss Hisss hiss Hisss hiss Hiss +hiss Hiss hisss Hisss hisss Hissss hiss Hisss +hissss Hiss hiss Hissss hisssssss Hiss hisss +Hiss hiss Hisssss hissssssss Hiss hisss Hiss +hissss Hisss hisss Hisss hiss Hissss hissss +Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssss Hiss hisss Hiss +hisssss Hiss hisss Hisss hiss Hiss hisssss +Hisss hissss Hiss hiss Hissss hiss Hiss hisssss +Hisss hisssssss Hiss hisss Hiss hiss Hisssss +hissss Hisssssss hisssssss Hiss hisss Hisss +hisss Hissss hissss Hisss hiss Hiss hisss +Hisssss hiss Hiss hisssss Hissss hiss Hiss +hisss Hiss hiss Hiss hiss Hiss hissss Hissss +hiss Hiss hissss Hiss hiss Hiss hiss Hiss +hisssss Hisss hiss Hiss hisss Hisssss hiss +Hiss hissss Hiss hiss Hiss hiss Hiss hisssss +Hisss hiss Hiss hisss Hisss hiss Hissss hissss +Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisss Hiss hiss Hissssss hisss Hiss +hiss Hiss hissssss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hisss hissss Hiss +hissssssss Hiss hisss Hissss hiss Hiss hiss +Hiss hiss Hiss hiss Hiss hisss Hisss hisssssss +Hiss hissss Hissss hiss Hisss hiss Hiss hiss +Hiss hisss Hisss hiss Hiss hiss Hiss hisss +Hisss hissss Hiss hisss Hisss hisssssss Hiss +hisssss Hiss hiss Hissss hiss Hisssss hiss +Hisss hisssssss Hiss hisss Hiss hiss Hisss +hiss Hisss hiss Hiss hisssss Hisss hissss +Hiss hiss Hissss hiss Hisss hissss Hisss +hisssss Hiss hiss Hisss hisssssss Hiss hisssss +Hiss hiss Hissss hisssss Hiss hiss Hisss +hiss Hiss hisss Hiss hiss Hisss hisss Hissss +hiss Hisss hiss Hissss hisss Hisss hiss Hisss +hisss Hissss hisssssss Hiss hisssss Hisss +hiss Hisss hiss Hiss hisss Hiss hiss Hisss +hiss Hisss hiss Hiss hiss Hisss hiss Hiss +hiss Hiss hisss Hisss hisss Hiss hiss Hiss +hissssssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisss +Hisss hissss Hiss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hisss hissss Hiss +hissssssss Hiss hissssssss Hiss hisss Hiss +hisss Hiss hiss Hisss hisss Hissss hiss Hisss +hissss Hiss hiss Hissss hisssssss Hiss hissss +Hisss hisss Hisss hiss Hisssss hiss Hisss +hiss Hisssss hiss Hisss hisssssss Hiss hissssss +Hiss hiss Hiss hisss Hiss hisss Hiss hiss +Hisss hisss Hissss hiss Hisss hissss Hiss +hiss Hissss hisssssss Hiss hissss Hiss hissss +Hisss hiss Hiss hisssss Hisss hisss Hiss +hisss Hissss hissss Hisss hiss Hiss hissssssss +Hiss hissss Hiss hissss Hisss hiss Hisssss +hiss Hisss hiss Hisssss hiss Hisss hissss +Hisss hiss Hisss hisssssss Hiss hisss Hissss +hiss Hissss hiss Hiss hisss Hiss hiss Hisss +hisss Hiss hiss Hisssss hisss Hiss hiss Hisssss +hiss Hiss hisss Hiss hiss Hiss hisss Hisss +hiss Hissss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hisss hissss Hiss +hissssssss Hiss hissssssss Hiss hissss Hisss +hisss Hisss hiss Hisssss hiss Hisss hiss +Hisssss hiss Hisss hisssssss Hiss hissssss +Hiss hiss Hiss hissss Hiss hissss Hisss hiss +Hiss hisssss Hisss hisss Hiss hisss Hissss +hissss Hisss hiss Hiss hissssssss Hiss hisss +Hissss hiss Hissss hiss Hiss hisss Hiss hiss +Hisss hisss Hiss hiss Hisssss hisss Hiss +hiss Hisssss hiss Hiss hisss Hiss hiss Hiss +hisss Hisss hiss Hissss hissss Hiss hiss +Hiss hissssssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisss +Hisss hissss Hiss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hisss hissss Hiss +hissssssss Hiss hissss Hiss hissss Hisss +hiss Hiss hiss Hiss hiss Hissss hissss Hiss +hiss Hissss hisssssss Hiss hissss Hissss +hiss Hisss hiss Hisssss hiss Hisss hissss +Hiss hiss Hissss hisssssss Hiss hisss Hiss +hiss Hisss hiss Hisss hiss Hiss hisssss Hisss +hissss Hiss hiss Hissss hiss Hisss hissss +Hisss hisssss Hiss hiss Hisss hisssssss Hiss +hisssss Hiss hiss Hissss hisssss Hiss hiss +Hisss hiss Hiss hisss Hiss hiss Hisss hisss +Hissss hiss Hisss hiss Hissss hisss Hisss +hiss Hisss hisss Hissss hisssssss Hiss hisssss +Hisss hiss Hisss hiss Hiss hisss Hiss hiss +Hisss hiss Hisss hiss Hiss hiss Hisss hiss +Hiss hiss Hiss hisss Hisss hisss Hiss hiss +Hissss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hisss hissss Hiss +hissss Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisss Hisss hissss Hiss hissssssss Hiss +hissssssss Hiss hisssss Hiss hiss Hissss +hiss Hiss hisss Hisssss hissssss Hissss hiss +Hiss hiss Hiss hisss Hisss hissss Hiss hisss +Hisss hiss Hiss hiss Hiss hisss Hisss hisss +Hisss hisss Hisss hisssssss Hiss hisss Hiss +hisss Hiss hiss Hisss hisss Hissss hiss Hisss +hissss Hiss hiss Hissss hisssssss Hiss hissssss +Hiss hiss Hiss hissss Hiss hiss Hiss hiss +Hiss hissss Hisss hisss Hisss hiss Hisssss +hiss Hisss hiss Hisssss hiss Hisss hiss Hiss +hisss Hiss hiss Hiss hissssss Hiss hiss Hiss +hissss Hiss hissss Hisss hiss Hiss hisssss +Hisss hisss Hiss hisss Hissss hisssssss Hiss +hisss Hissss hiss Hissss hiss Hiss hisss +Hiss hiss Hisss hisss Hiss hiss Hisssss hisss +Hiss hiss Hisssss hiss Hiss hisss Hiss hiss +Hiss hissss Hiss hiss Hiss hissssssssss Hiss +hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hisss hissss Hiss +hissss Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisss Hisss hissss Hiss hissssssss Hiss +hisss Hissss hiss Hissss hiss Hiss hiss Hiss +hisss Hisss hisssssss Hiss hisss Hisss hissss +Hisss hiss Hiss hisssss Hisss hisss Hissss +hiss Hisss hiss Hissss hisss Hiss hisssss +Hiss hiss Hissss hisssssss Hiss hisssss Hiss +hisss Hisss hiss Hisssss hiss Hisss hisssssss +Hiss hisssss Hiss hiss Hissss hisssss Hiss +hiss Hisss hiss Hiss hisss Hiss hiss Hisss +hiss Hisss hisss Hissss hisssssss Hiss hissssss +Hiss hiss Hiss hisss Hiss hiss Hiss hisss +Hisss hisss Hisss hisss Hisss hisss Hisss +hisss Hisss hiss Hiss hisss Hiss hiss Hisss +hiss Hisss hissss Hisss hiss Hiss hisss Hiss +hiss Hisss hiss Hiss hiss Hiss hisss Hisss +hisss Hissss hiss Hisss hissss Hiss hiss +Hissss hissss Hisss hiss Hisss hiss Hiss +hisss Hisssss hiss Hiss hisss Hiss hiss Hiss +hissssssss Hiss hisss Hissss hiss Hissss +hiss Hiss hisss Hiss hiss Hisss hissss Hiss +hiss Hissss hisssss Hiss hiss Hisss hiss +Hisssss hiss Hisss hiss Hiss hiss Hiss hiss +Hissss hissss Hiss hiss Hissss hisss Hiss +hiss Hiss hissssssssss Hiss hissssssss Hiss +hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisss Hisss hissss Hiss hissssssss Hiss +hisss Hiss hiss Hisss hiss Hisss hiss Hiss +hisss Hiss hiss Hisss hiss Hisss hisss Hissss +hiss Hisss hisss Hissss hiss Hiss hisss Hiss +hiss Hisss hisss Hissss hiss Hisss hiss Hissss +hisss Hisss hisssssss Hiss hisssss Hiss hiss +Hissss hisssss Hiss hiss Hisss hiss Hiss +hisss Hiss hiss Hisss hisss Hissss hiss Hisss +hiss Hissss hisss Hisss hiss Hisss hisss +Hissss hisssssss Hiss hisssss Hisss hiss +Hisss hiss Hiss hisss Hiss hiss Hisss hiss +Hisss hiss Hiss hiss Hisss hiss Hiss hiss +Hiss hisss Hisss hisss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hisss hissss Hiss +hissss Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisss Hisss hissss Hiss hissssssss Hiss +hissssssss Hiss hissss Hisss hisss Hisss +hiss Hisssss hiss Hisss hiss Hisssss hiss +Hisss hisssssss Hiss hissssss Hiss hiss Hiss +hissss Hiss hiss Hiss hiss Hiss hissss Hiss +hissss Hisss hiss Hiss hisssss Hisss hisss +Hiss hisss Hissss hissss Hisss hiss Hiss +hissssssss Hiss hisss Hissss hiss Hissss +hiss Hiss hisss Hiss hiss Hisss hisss Hiss +hiss Hisssss hisss Hiss hiss Hisssss hiss +Hiss hisss Hiss hiss Hiss hisss Hisss hiss +Hissss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hisss hissss Hiss +hissss Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisss Hisss hissss Hiss hissssssss Hiss +hisss Hissss hiss Hiss hiss Hiss hiss Hiss +hiss Hiss hisss Hisss hisssssss Hiss hisss +Hiss hisssss Hisss hissss Hisss hiss Hisss +hiss Hisss hisss Hissss hiss Hisssss hiss +Hisss hisssssss Hiss hisssss Hiss hisss Hisss +hiss Hisssss hiss Hisss hisss Hissss hiss +Hisss hiss Hissss hisss Hiss hisssss Hiss +hiss Hissss hisssssss Hiss hisss Hissss hiss +Hissss hiss Hiss hisssss Hisss hisss Hissss +hiss Hisss hissss Hiss hiss Hissss hisssssss +Hiss hisssss Hiss hiss Hissss hiss Hisssss +hiss Hisss hisssssss Hiss hisss Hisss hisss +Hissss hissssss Hissss hiss Hisssss hiss +Hisss hiss Hiss hisss Hiss hiss Hisss hissss +Hisss hiss Hisss hisssssss Hiss hisssss Hiss +hiss Hissss hisssss Hiss hiss Hisss hiss +Hiss hiss Hiss hisss Hisss hisssssss Hiss +hisssss Hiss hisss Hiss hisssss Hiss hisss +Hisss hiss Hiss hisssss Hisss hissss Hiss +hiss Hissss hiss Hiss hisssss Hisss hisssssss +Hiss hisss Hisss hisss Hissss hiss Hisssss +hiss Hisss hisssssss Hiss hisss Hiss hisss +Hiss hiss Hisss hissss Hiss hiss Hissss hisssssss +Hiss hisss Hisss hissss Hisss hiss Hiss hisssss +Hisss hisss Hissss hiss Hisss hisssssss Hiss +hissss Hiss hissss Hisss hiss Hiss hiss Hiss +hisss Hisss hisssssss Hiss hisss Hiss hiss +Hiss hiss Hissss hiss Hisss hisss Hissss +hiss Hiss hiss Hiss hisss Hisss hissss Hiss +hisss Hisss hisss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hisss hissss Hiss +hissssssss Hiss hisssss Hisss hiss Hisss +hiss Hiss hisssss Hisss hissss Hiss hiss +Hissss hiss Hiss hiss Hiss hisss Hisss hisss +Hiss hisss Hissss hisssssss Hiss hisss Hisssss +hiss Hisss hisss Hissss hiss Hisss hisss +Hissss hiss Hiss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssss Hiss hisss Hiss +hisssss Hiss hiss Hissss hiss Hiss hiss Hisss +hiss Hisss hissssss Hissss hissss Hiss hisss +Hisss hiss Hiss hisssss Hisss hissss Hiss +hiss Hissss hiss Hiss hisssss Hisss hisssssss +Hiss hisss Hiss hiss Hisssss hissssssss Hiss +hisssss Hiss hisss Hiss hisssss Hiss hisss +Hisss hiss Hiss hisssss Hisss hissss Hiss +hiss Hissss hiss Hiss hisssss Hisss hiss +Hisss hiss Hissss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hissss hiss Hissss +hisssss Hiss hiss Hisss hiss Hiss hisss Hiss +hiss Hisss hissss Hisss hiss Hisss hiss Hiss +hiss Hiss hisss Hisss hisssssss Hiss hissssss +Hiss hiss Hiss hisssss Hiss hisss Hiss hisssss +Hiss hiss Hissss hiss Hiss hiss Hisss hiss +Hisss hissssss Hissss hissss Hiss hisss Hisss +hiss Hiss hisssss Hisss hissss Hiss hiss +Hissss hiss Hiss hisssss Hisss hisssssss +Hiss hisss Hiss hiss Hisssss hissss Hisssssss +hisssssss Hiss hisss Hisssss hiss Hiss hissssss +Hiss hiss Hiss hisssss Hissss hiss Hiss hiss +Hissss hiss Hissss hiss Hisss hiss Hiss hiss +Hiss hisss Hiss hisss Hiss hiss Hiss hisssss +Hissss hiss Hiss hiss Hisss hisss Hissss +hissss Hissss hiss Hiss hisssss Hiss hiss +Hiss hissssss Hiss hiss Hiss hisss Hisssssss +hisss Hiss hisssss Hiss hisssss Hissss hiss +Hiss hisss Hiss hiss Hiss hiss Hiss hisss +Hiss hisss Hiss hiss Hiss hisss Hisssss hiss +Hiss hisss Hiss hisss Hiss hiss Hiss hissssssss +Hiss hisss Hisss hiss Hisssss hisss Hiss +hiss Hiss hissssssssss Hiss hissssssss Hiss +hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hiss hiss Hisss +hiss Hisss hiss Hiss hisss Hisssss hisssssss +Hiss hisssss Hiss hisss Hiss hisss Hisss +hiss Hiss hiss Hisss hiss Hissss hiss Hissss +hisssssss Hiss hisss Hiss hiss Hisssss hissssssss +Hiss hisssss Hiss hisss Hiss hisss Hiss hissss +Hisss hisss Hisss hiss Hissss hissss Hiss +hiss Hiss hissssss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisss +Hisss hissss Hiss hissssssss Hiss hisss Hiss +hissssss Hiss hissss Hisss hiss Hisss hissss +Hisss hiss Hisss hiss Hisssss hiss Hisss +hiss Hissss hiss Hissss hisssssss Hiss hisss +Hisss hisss Hissss hissssss Hissss hiss Hiss +hisssss Hisss hiss Hisss hissss Hisss hiss +Hiss hiss Hiss hisss Hisss hisssssss Hiss +hisss Hiss hisssss Hisss hisss Hisss hisss +Hisss hissss Hiss hiss Hissss hiss Hiss hiss +Hiss hisss Hisss hisss Hiss hisss Hissss +hisssssss Hiss hisss Hisss hiss Hiss hiss +Hisss hiss Hiss hiss Hiss hisss Hisss hiss +Hiss hisss Hisssss hiss Hissss hiss Hissss +hiss Hisssss hiss Hisss hisss Hiss hisss +Hissss hissss Hiss hisss Hisss hiss Hisss +hisss Hissss hisssssss Hiss hisss Hisssss +hiss Hisss hisss Hissss hiss Hisss hissss +Hisss hiss Hisss hiss Hiss hisss Hisssss +hisss Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hiss hisss Hiss +hiss Hisss hisss Hisss hisss Hisss hisssssss +Hiss hissssss Hiss hiss Hiss hisssss Hiss +hisss Hiss hisss Hisss hiss Hiss hiss Hisss +hiss Hissss hiss Hissss hisssssss Hiss hisss +Hiss hiss Hisssss hissss Hisssssss hisssssss +Hiss hisss Hisssss hiss Hiss hissss Hisssss +hiss Hiss hisssss Hiss hiss Hiss hisss Hiss +hisss Hiss hiss Hisss hisss Hisss hisss Hisss +hissss Hissssss hisss Hisss hisss Hisss hiss +Hisssss hiss Hisss hisss Hiss hisss Hissss +hissss Hissssss hiss Hissss hiss Hissss hisssss +Hiss hiss Hisss hiss Hiss hisss Hiss hiss +Hisss hissss Hisss hiss Hisss hiss Hiss hiss +Hiss hisss Hisss hissss Hissssss hiss Hisss +hisss Hissss hiss Hissss hiss Hissss hiss +Hiss hisss Hiss hiss Hisss hissss Hiss hiss +Hissss hiss Hisss hissss Hisss hisssss Hiss +hiss Hisss hissss Hissssss hisss Hiss hisss +Hissss hiss Hiss hiss Hiss hisss Hisss hissss +Hiss hiss Hissss hiss Hiss hiss Hiss hiss +Hissss hisss Hiss hisss Hissss hisss Hissss +hiss Hisss hiss Hiss hisss Hiss hiss Hiss +hisssss Hiss hisss Hiss hisss Hisssss hiss +Hiss hisss Hiss hisss Hiss hiss Hiss hissssssss +Hiss hisss Hisss hiss Hisssss hisss Hiss +hiss Hiss hissssssssss Hiss hissssssss Hiss +hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisssss +Hiss hisss Hiss hisssss Hiss hiss Hissss +hiss Hiss hiss Hisss hiss Hisss hissssss +Hissss hissss Hiss hisss Hisss hiss Hiss +hisssss Hisss hissss Hiss hiss Hissss hiss +Hiss hisssss Hisss hisssssss Hiss hisss Hiss +hiss Hisssss hissss Hisssssss hisssssss Hiss +hisss Hisss hisss Hissss hiss Hisssss hiss +Hiss hissssss Hiss hiss Hiss hisssss Hiss +hisss Hiss hisss Hisss hiss Hiss hiss Hisss +hiss Hissss hiss Hissss hissss Hissss hiss +Hiss hiss Hisss hisss Hissss hissss Hissss +hiss Hiss hisssss Hiss hiss Hiss hisss Hiss +hisss Hiss hiss Hiss hisss Hisssss hiss Hiss +hissssss Hisss hiss Hiss hisssss Hisss hiss +Hiss hisssss Hisss hiss Hiss hisssss Hiss +hiss Hiss hisss Hisssss hiss Hiss hisss Hisss +hiss Hissss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisss +Hiss hiss Hissssss hisssssss Hiss hisss Hiss +hiss Hiss hisss Hisss hissss Hisss hiss Hisss +hiss Hisss hisss Hissss hiss Hiss hiss Hiss +hisss Hisss hisssssss Hiss hisss Hisss hiss +Hisssss hisss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisssssss Hissss hisss Hiss hisss Hissss +hiss Hiss hisss Hiss hiss Hisss hisss Hissss +hiss Hisss hissss Hiss hiss Hissss hisssssss +Hiss hissss Hiss hissss Hiss hisss Hissss +hiss Hiss hiss Hiss hisssss Hiss hiss Hisss +hiss Hiss hisss Hiss hiss Hisss hissss Hiss +hiss Hissss hiss Hiss hiss Hiss hisss Hisss +hiss Hisss hisss Hissss hissssss Hissss hiss +Hiss hisssss Hisss hiss Hisss hissss Hisss +hiss Hiss hiss Hiss hisss Hisss hisssssss +Hiss hisss Hiss hisssss Hisss hisss Hisss +hisss Hisss hissss Hiss hiss Hissss hiss +Hiss hiss Hiss hisss Hisss hisss Hiss hisss +Hissss hisssssss Hiss hissss Hissss hiss +Hisss hiss Hisssss hiss Hisss hisss Hissss +hiss Hisss hiss Hiss hiss Hisss hiss Hiss +hisss Hisss hiss Hiss hiss Hisss hiss Hiss +hiss Hiss hisss Hisss hiss Hiss hisss Hisssss +hiss Hissss hiss Hissss hiss Hisssss hiss +Hisss hisss Hiss hisss Hissss hissss Hiss +hisss Hisss hisss Hiss hiss Hissss hisssss +Hissss hiss Hiss hisss Hissss hiss Hisss +hisss Hiss hissss Hiss hisss Hisss hiss Hissss +hissss Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisssssss +Hissss hisss Hiss hisss Hissss hiss Hiss +hisss Hiss hiss Hisss hisss Hissss hiss Hisss +hissss Hiss hiss Hissss hisssssss Hiss hissss +Hiss hissss Hiss hisssss Hiss hisss Hiss +hissss Hisss hisss Hisss hiss Hiss hisss +Hiss hiss Hisss hissss Hisss hiss Hisss hiss +Hiss hiss Hiss hisss Hisss hisss Hiss hiss +Hissss hisssss Hiss hisss Hiss hissss Hissss +hiss Hiss hissss Hiss hiss Hissss hissssssss +Hiss hisssss Hiss hisss Hiss hisssss Hisss +hiss Hisss hiss Hiss hisss Hiss hiss Hisss +hisss Hissss hiss Hisss hiss Hiss hiss Hiss +hisss Hisss hisss Hiss hissss Hiss hisss +Hisss hiss Hissss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisssss Hiss hisss Hiss hissss Hiss +hisss Hissss hiss Hiss hiss Hiss hisss Hisss +hissss Hiss hiss Hissss hisssssss Hiss hisss +Hiss hiss Hisssss hissssssss Hiss hisss Hiss +hissss Hisss hisss Hisss hiss Hissss hissss +Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisssss +Hisss hiss Hisss hiss Hiss hisssss Hisss +hiss Hisss hisss Hissss hissss Hiss hiss +Hissss hiss Hisss hiss Hissss hissss Hiss +hiss Hiss hissssssssss Hiss hissssssss Hiss +hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hiss hiss Hissssss +hisss Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisss Hiss hiss Hissssss hisss Hiss +hiss Hiss hissssss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hisss hissss Hiss +hissssssss Hiss hissss Hiss hisss Hiss hiss +Hiss hiss Hiss hiss Hiss hisss Hisss hiss +Hiss hissss Hissss hiss Hiss hiss Hiss hiss +Hissss hiss Hiss hisss Hiss hiss Hisss hisss +Hiss hisss Hissss hiss Hiss hiss Hiss hisss +Hisss hisssssss Hiss hisss Hissss hiss Hissss +hisssss Hiss hiss Hisss hiss Hiss hisss Hiss +hiss Hisss hissss Hiss hiss Hissss hiss Hiss +hiss Hiss hisss Hisss hiss Hisss hisss Hissss +hissssss Hissss hiss Hiss hisssss Hisss hiss +Hisss hissss Hisss hiss Hiss hiss Hiss hisss +Hisss hisssssss Hiss hisss Hiss hisss Hiss +hiss Hisss hiss Hiss hiss Hisss hiss Hisss +hiss Hiss hiss Hisss hiss Hisss hiss Hiss +hiss Hiss hisss Hisss hissss Hiss hisss Hisss +hiss Hiss hisss Hiss hiss Hisss hiss Hiss +hisssss Hisss hissss Hiss hiss Hissss hiss +Hiss hiss Hiss hisss Hisss hissss Hisss hiss +Hisss hiss Hiss hisss Hisssss hisssssss Hiss +hisss Hiss hisssss Hisss hisss Hisss hisss +Hisss hissss Hiss hiss Hissss hiss Hiss hiss +Hiss hisss Hisss hisss Hiss hisss Hissss +hisssssss Hiss hisss Hisss hiss Hiss hiss +Hisss hiss Hiss hiss Hiss hisss Hisss hiss +Hiss hisss Hisssss hiss Hissss hiss Hissss +hiss Hisssss hiss Hisss hisss Hiss hisss +Hissss hissss Hiss hisss Hisss hiss Hisss +hisss Hissss hissss Hisss hiss Hiss hissss +Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisss Hisss hissss Hiss hissssssss Hiss +hissss Hiss hissss Hisss hiss Hiss hiss Hiss +hiss Hissss hissss Hiss hiss Hissss hisssssss +Hiss hissss Hissss hiss Hisss hiss Hisssss +hiss Hisss hisss Hissss hiss Hisss hiss Hiss +hiss Hiss hisss Hisss hisssssss Hiss hisss +Hiss hisssss Hisss hisss Hisss hisss Hisss +hissss Hiss hiss Hissss hiss Hiss hiss Hiss +hisss Hisss hisss Hiss hisss Hissss hisssssss +Hiss hisssss Hiss hiss Hissss hisssss Hiss +hiss Hisss hiss Hiss hiss Hiss hisss Hisss +hisssssss Hiss hisss Hisssss hiss Hisss hissssss +Hissss hiss Hiss hiss Hiss hisss Hisss hisss +Hissss hiss Hisss hiss Hiss hisss Hiss hiss +Hisss hisss Hissss hiss Hisss hiss Hissss +hisss Hisss hisssssss Hiss hissss Hiss hissss +Hisss hisss Hiss hisss Hissss hiss Hiss hisssss +Hisss hiss Hisss hissss Hisss hiss Hisss +hiss Hiss hiss Hisss hiss Hiss hiss Hiss +hisss Hisss hissss Hiss hiss Hissss hisss +Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisss Hiss hisss Hiss hiss Hisss hisss +Hisss hisss Hisss hisssssss Hiss hissssss +Hiss hiss Hiss hisssss Hiss hisss Hiss hisssss +Hiss hisss Hisss hiss Hiss hisssss Hisss +hissss Hiss hiss Hissss hiss Hiss hisssss +Hisss hisssssss Hiss hisss Hiss hiss Hisssss +hissss Hisssssss hisssssss Hiss hisss Hisssss +hiss Hiss hisssss Hissss hiss Hiss hisss +Hiss hissss Hisss hisssss Hiss hiss Hiss +hisss Hiss hisss Hiss hiss Hisss hisss Hisss +hisss Hisss hissss Hissssss hisss Hisss hisss +Hisss hiss Hisssss hiss Hisss hisss Hiss +hisss Hissss hissss Hissssss hiss Hissss +hiss Hissss hisssss Hiss hiss Hisss hiss +Hiss hisss Hiss hiss Hisss hissss Hisss hiss +Hisss hiss Hiss hiss Hiss hisss Hisss hissss +Hissssss hiss Hisss hisss Hissss hiss Hissss +hiss Hissss hiss Hiss hisss Hiss hiss Hisss +hissss Hiss hiss Hissss hiss Hisss hissss +Hisss hisssss Hiss hiss Hisss hissss Hissssss +hisss Hiss hisss Hissss hiss Hiss hiss Hiss +hisss Hisss hissss Hiss hiss Hissss hiss +Hiss hiss Hiss hiss Hissss hisss Hiss hisss +Hissss hisss Hissss hiss Hisss hiss Hiss +hisss Hiss hiss Hiss hisssss Hissss hiss +Hiss hisssss Hiss hiss Hiss hisss Hisssss +hiss Hiss hissssssss Hiss hisssss Hissssss +hissss Hissssss hisss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisssss +Hiss hisss Hiss hisssss Hiss hisss Hisss +hiss Hiss hisssss Hisss hissss Hiss hiss +Hissss hiss Hiss hisssss Hisss hisssssss +Hiss hisss Hiss hiss Hisssss hissss Hisssssss +hisssssss Hiss hisss Hisssss hiss Hiss hisssss +Hissss hiss Hiss hisss Hiss hissss Hisss +hisssss Hiss hiss Hiss hisss Hiss hisss Hiss +hiss Hisss hisss Hisss hisss Hisss hissss +Hissssss hisss Hisss hisss Hisss hiss Hisssss +hiss Hisss hisss Hiss hisss Hissss hissss +Hissssss hiss Hissss hiss Hissss hisssss +Hiss hiss Hisss hiss Hiss hisss Hiss hiss +Hisss hissss Hisss hiss Hisss hiss Hiss hiss +Hiss hisss Hisss hissss Hissssss hiss Hisss +hisss Hissss hiss Hissss hiss Hissss hiss +Hiss hisss Hiss hiss Hisss hissss Hiss hiss +Hissss hiss Hisss hissss Hisss hisssss Hiss +hiss Hisss hissss Hissssss hisss Hiss hisss +Hissss hiss Hiss hiss Hiss hisss Hisss hissss +Hiss hiss Hissss hiss Hiss hiss Hiss hiss +Hissss hisss Hiss hisss Hissss hisss Hissss +hiss Hisss hiss Hiss hisss Hiss hiss Hiss +hisssss Hissss hiss Hiss hiss Hisss hisss +Hissss hiss Hisss hiss Hiss hiss Hiss hisssss +Hissss hiss Hiss hisssss Hiss hiss Hiss hisssss +Hissss hiss Hiss hiss Hisss hisss Hissss +hiss Hisssss hiss Hiss hisss Hiss hisss Hiss +hiss Hiss hissssssss Hiss hisss Hisss hiss +Hisssss hisss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisssssss +Hissss hisss Hiss hisss Hissss hiss Hiss +hisss Hiss hiss Hisss hisss Hissss hiss Hisss +hissss Hiss hiss Hissss hisssssss Hiss hissss +Hiss hissss Hiss hissss Hissss hisss Hiss +hiss Hisssss hiss Hisss hisssssss Hiss hisss +Hissss hiss Hissss hisssss Hiss hiss Hisss +hiss Hiss hisss Hiss hiss Hisss hissss Hiss +hiss Hissss hiss Hiss hiss Hiss hisss Hisss +hiss Hisss hisss Hissss hissssss Hissss hiss +Hiss hisssss Hisss hiss Hisss hissss Hisss +hiss Hiss hiss Hiss hisss Hisss hisssssss +Hiss hisss Hiss hisssss Hisss hisss Hisss +hisss Hisss hissss Hiss hiss Hissss hiss +Hiss hiss Hiss hisss Hisss hisss Hiss hisss +Hissss hisssssss Hiss hisss Hisss hiss Hiss +hiss Hisss hiss Hiss hiss Hiss hisss Hisss +hiss Hiss hisss Hisssss hiss Hissss hiss +Hissss hiss Hisssss hiss Hisss hisss Hiss +hisss Hissss hissss Hiss hisss Hisss hisss +Hiss hiss Hissss hisssss Hissss hiss Hiss +hisss Hissss hiss Hisss hisss Hiss hissss +Hiss hisss Hisss hiss Hissss hissss Hiss +hiss Hiss hissssssssss Hiss hissssssss Hiss +hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssssss Hissss hisss +Hiss hisss Hissss hiss Hiss hisss Hiss hiss +Hisss hisss Hissss hiss Hisss hissss Hiss +hiss Hissss hisssssss Hiss hissss Hiss hissss +Hiss hisssss Hiss hisss Hiss hissss Hisss +hisss Hisss hiss Hiss hisss Hiss hiss Hisss +hissss Hisss hiss Hisss hiss Hiss hiss Hiss +hisss Hisss hisss Hiss hiss Hissss hisssss +Hiss hisss Hiss hissss Hissss hiss Hiss hissss +Hiss hiss Hissss hissssssss Hiss hisssss +Hiss hisss Hiss hisssss Hisss hiss Hisss +hiss Hiss hisss Hiss hiss Hisss hisss Hissss +hiss Hisss hiss Hiss hiss Hiss hisss Hisss +hisss Hiss hissss Hiss hisss Hisss hiss Hissss +hissss Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssss Hiss hisss Hiss +hissss Hiss hisss Hissss hiss Hiss hiss Hiss +hisss Hisss hissss Hiss hiss Hissss hisssssss +Hiss hisss Hiss hiss Hisssss hissssssss Hiss +hisss Hiss hissss Hisss hisss Hisss hiss +Hissss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hiss hiss Hissssss +hisss Hiss hiss Hiss hissssss Hiss hiss Hiss +hissssssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisss +Hisss hissss Hiss hissssssss Hiss hissss +Hisss hissss Hiss hiss Hisssss hiss Hisss +hisss Hiss hisss Hissss hisss Hiss hissss +Hisss hiss Hiss hisss Hiss hiss Hisss hissss +Hiss hisss Hisss hisssssss Hiss hisss Hissss +hiss Hissss hisssss Hiss hiss Hisss hiss +Hiss hisss Hiss hiss Hisss hissss Hiss hiss +Hissss hiss Hiss hiss Hiss hisss Hisss hiss +Hisss hisss Hissss hissssss Hissss hiss Hiss +hisssss Hisss hiss Hisss hissss Hisss hiss +Hiss hiss Hiss hisss Hisss hisssssss Hiss +hissss Hiss hissss Hisss hiss Hiss hiss Hiss +hisss Hisss hissss Hiss hiss Hissss hiss +Hissss hiss Hissss hiss Hiss hiss Hiss hisss +Hisss hiss Hiss hiss Hiss hisss Hisss hisss +Hissss hiss Hisss hisssssss Hiss hisss Hiss +hisss Hiss hiss Hiss hissssss Hiss hiss Hiss +hissssssss Hiss hisss Hisssss hiss Hisss +hisss Hisss hisss Hisss hisssssss Hiss hisss +Hiss hisssss Hisss hisssssss Hiss hissss +Hisss hisss Hisss hiss Hiss hiss Hiss hiss +Hissss hisss Hissss hiss Hisss hiss Hisss +hissss Hisss hissss Hiss hiss Hissss hiss +Hiss hisss Hiss hiss Hisss hiss Hisssss hiss +Hisss hisss Hissss hiss Hisss hisssssss Hiss +hisssss Hiss hiss Hissss hiss Hiss hisss +Hisssss hissssss Hissss hiss Hiss hiss Hiss +hisss Hisss hissss Hiss hisss Hisss hiss +Hiss hiss Hiss hisss Hisss hisss Hisss hisss +Hisss hisss Hiss hiss Hiss hissssssssss Hiss +hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hiss hisss Hiss +hiss Hisss hisss Hisss hisss Hisss hisssssss +Hiss hissssss Hiss hiss Hiss hisssss Hiss +hisss Hiss hisssss Hiss hisss Hisss hiss +Hiss hisssss Hisss hissss Hiss hiss Hissss +hiss Hiss hisssss Hisss hisssssss Hiss hisss +Hiss hiss Hisssss hissss Hisssssss hisssssss +Hiss hisss Hisssss hiss Hiss hisssss Hissss +hiss Hiss hisssss Hiss hiss Hiss hisssss +Hissss hiss Hiss hisss Hiss hiss Hiss hiss +Hiss hisssss Hissss hiss Hiss hiss Hissss +hiss Hissss hiss Hisss hiss Hiss hiss Hiss +hisssss Hissss hiss Hiss hiss Hiss hisss +Hiss hiss Hiss hisssss Hissss hiss Hiss hiss +Hisss hisss Hissss hiss Hisss hiss Hiss hiss +Hiss hisssss Hissss hiss Hiss hisssss Hiss +hiss Hiss hisss Hisssss hiss Hiss hisss Hiss +hisss Hiss hiss Hiss hissssssss Hiss hisss +Hisss hiss Hisssss hisss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisssssss +Hissss hisss Hiss hisss Hissss hiss Hiss +hisss Hiss hiss Hisss hisss Hissss hiss Hisss +hissss Hiss hiss Hissss hisssssss Hiss hissss +Hiss hissss Hiss hisss Hissss hiss Hiss hiss +Hiss hisssss Hiss hiss Hisss hiss Hiss hisss +Hiss hiss Hisss hissss Hiss hiss Hissss hiss +Hiss hiss Hiss hisss Hisss hiss Hisss hisss +Hissss hissssss Hissss hiss Hiss hisssss +Hisss hiss Hisss hissss Hisss hiss Hiss hiss +Hiss hisss Hisss hisssssss Hiss hissss Hiss +hissss Hisss hiss Hiss hiss Hiss hisss Hisss +hissss Hiss hiss Hissss hiss Hissss hiss +Hissss hiss Hiss hiss Hiss hisss Hisss hiss +Hiss hiss Hiss hisss Hisss hisss Hissss hiss +Hisss hisssssss Hiss hisss Hissss hisss Hiss +hisss Hiss hisss Hiss hiss Hiss hisss Hissss +hisss Hiss hissssssss Hiss hisss Hiss hisssss +Hisss hisss Hissss hiss Hisss hissss Hiss +hisss Hisss hisssssss Hiss hisss Hissss hisss +Hiss hissssss Hiss hiss Hiss hisss Hissss +hisss Hiss hissss Hiss hiss Hissss hisssss +Hissss hiss Hiss hisss Hissss hiss Hisss +hisss Hiss hissss Hiss hisss Hisss hiss Hissss +hissss Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssssss Hissss hisss +Hiss hisss Hissss hiss Hiss hisss Hiss hiss +Hisss hisss Hissss hiss Hisss hissss Hiss +hiss Hissss hisssssss Hiss hissss Hiss hissss +Hiss hisssss Hiss hisss Hiss hissss Hisss +hisss Hisss hiss Hiss hisss Hiss hiss Hisss +hissss Hisss hiss Hisss hiss Hiss hiss Hiss +hisss Hisss hisss Hiss hiss Hissss hisssss +Hiss hisss Hiss hissss Hissss hiss Hiss hissss +Hiss hiss Hissss hissssssss Hiss hisssss +Hiss hisss Hiss hisssss Hisss hiss Hisss +hiss Hiss hisss Hiss hiss Hisss hisss Hissss +hiss Hisss hiss Hiss hiss Hiss hisss Hisss +hisss Hiss hissss Hiss hisss Hisss hiss Hissss +hissss Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssss Hiss hisss Hiss +hissss Hiss hisss Hissss hiss Hiss hiss Hiss +hisss Hisss hissss Hiss hiss Hissss hisssssss +Hiss hisss Hiss hiss Hisssss hissssssss Hiss +hisss Hiss hissss Hisss hisss Hisss hiss +Hissss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hiss hiss Hissssss +hisss Hiss hiss Hiss hissssss Hiss hiss Hiss +hissssssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisss +Hisss hissss Hiss hissssssss Hiss hissss +Hisss hissss Hiss hiss Hisssss hiss Hisss +hisss Hiss hisss Hissss hisss Hiss hissss +Hisss hiss Hiss hisss Hiss hiss Hisss hissss +Hiss hisss Hisss hisssssss Hiss hisss Hissss +hiss Hissss hisssss Hiss hiss Hisss hiss +Hiss hisss Hiss hiss Hisss hissss Hiss hiss +Hissss hiss Hiss hiss Hiss hisss Hisss hiss +Hisss hisss Hissss hissssss Hissss hiss Hiss +hisssss Hisss hiss Hisss hissss Hisss hiss +Hiss hiss Hiss hisss Hisss hisssssss Hiss +hissss Hisss hisss Hisss hiss Hisssss hiss +Hisss hissss Hisss hiss Hisss hissss Hisss +hiss Hisss hiss Hisssss hiss Hisss hiss Hissss +hiss Hissss hiss Hiss hisss Hiss hiss Hisss +hisss Hissss hiss Hisss hiss Hissss hisss +Hisss hisssssss Hiss hissssss Hiss hiss Hiss +hissssssss Hiss hisss Hisssss hiss Hisss +hisss Hiss hisss Hissss hisssssss Hiss hisssssss +Hissss hisss Hiss hisss Hissss hiss Hiss +hisss Hiss hiss Hisss hiss Hisssss hiss Hisss +hisss Hiss hisss Hissss hisssssss Hiss hisssss +Hiss hiss Hissss hiss Hisssss hiss Hisss +hisssssss Hiss hisss Hiss hisss Hiss hiss +Hiss hissss Hiss hiss Hiss hissssssssss Hiss +hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hiss hisss Hiss +hiss Hisss hisss Hisss hisss Hisss hisssssss +Hiss hissssss Hiss hiss Hiss hisssss Hiss +hisss Hiss hisssss Hiss hisss Hisss hiss +Hiss hisssss Hisss hissss Hiss hiss Hissss +hiss Hiss hisssss Hisss hisssssss Hiss hisss +Hiss hiss Hisssss hissss Hisssssss hisssssss +Hiss hisss Hisssss hiss Hiss hisssss Hissss +hiss Hiss hiss Hisss hisss Hiss hiss Hiss +hissss Hissss hiss Hiss hiss Hisss hisss +Hissss hiss Hisss hiss Hiss hiss Hiss hisssss +Hissss hiss Hiss hiss Hiss hisss Hiss hiss +Hiss hisss Hisssss hiss Hiss hissssssss Hiss +hisssss Hissssss hissss Hissssss hisss Hiss +hiss Hiss hissssssssss Hiss hissssssss Hiss +hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssss Hiss hisss Hiss +hisssss Hiss hisss Hisss hiss Hiss hisssss +Hisss hissss Hiss hiss Hissss hiss Hiss hisssss +Hisss hisssssss Hiss hisss Hiss hiss Hisssss +hissss Hisssssss hisssssss Hiss hisss Hisssss +hiss Hiss hisssss Hissss hiss Hiss hisssss +Hiss hiss Hiss hisssss Hissss hiss Hiss hiss +Hisss hisss Hissss hiss Hisss hiss Hiss hiss +Hiss hisssss Hissss hiss Hiss hiss Hisss +hisss Hiss hiss Hiss hiss Hisssss hiss Hiss +hisss Hiss hisss Hiss hiss Hiss hissssssss +Hiss hisss Hisss hiss Hisssss hisss Hiss +hiss Hiss hissssssssss Hiss hissssssss Hiss +hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssssss Hissss hisss +Hiss hisss Hissss hiss Hiss hisss Hiss hiss +Hisss hisss Hissss hiss Hisss hissss Hiss +hiss Hissss hisssssss Hiss hissss Hiss hissss +Hiss hisss Hissss hiss Hiss hiss Hiss hisssss +Hiss hiss Hisss hiss Hiss hisss Hiss hiss +Hisss hissss Hiss hiss Hissss hiss Hiss hiss +Hiss hisss Hisss hiss Hisss hisss Hissss +hissssss Hissss hiss Hiss hisssss Hisss hiss +Hisss hissss Hisss hiss Hiss hiss Hiss hisss +Hisss hisssssss Hiss hisss Hiss hisssss Hisss +hisss Hisss hisss Hisss hissss Hiss hiss +Hissss hiss Hiss hiss Hiss hisss Hisss hisss +Hiss hisss Hissss hisssssss Hiss hisss Hissss +hisss Hiss hissssss Hiss hiss Hiss hisss +Hissss hisss Hiss hissssssss Hiss hisss Hisssss +hiss Hisss hisss Hiss hisss Hissss hisssssss +Hiss hissss Hiss hissss Hisss hiss Hiss hiss +Hiss hisss Hisss hisss Hisss hisss Hisss +hiss Hisssss hiss Hisss hisss Hiss hisss +Hissss hiss Hiss hiss Hiss hisss Hisss hisssssss +Hiss hisss Hissss hisss Hiss hisss Hiss hisss +Hiss hiss Hiss hisss Hissss hisss Hiss hissss +Hiss hiss Hissss hisssss Hissss hiss Hiss +hisss Hissss hiss Hisss hisss Hiss hissss +Hiss hisss Hisss hiss Hissss hissss Hiss +hiss Hiss hissssssssss Hiss hissssssss Hiss +hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssssss Hissss hisss +Hiss hisss Hissss hiss Hiss hisss Hiss hiss +Hisss hisss Hissss hiss Hisss hissss Hiss +hiss Hissss hisssssss Hiss hissss Hiss hissss +Hiss hisssss Hiss hisss Hiss hissss Hisss +hisss Hisss hiss Hiss hisss Hiss hiss Hisss +hissss Hisss hiss Hisss hiss Hiss hiss Hiss +hisss Hisss hisss Hiss hiss Hissss hisssss +Hiss hisss Hiss hissss Hissss hiss Hiss hissss +Hiss hiss Hissss hissssssss Hiss hisssss +Hiss hisss Hiss hisssss Hisss hiss Hisss +hiss Hiss hisss Hiss hiss Hisss hisss Hissss +hiss Hisss hiss Hiss hiss Hiss hisss Hisss +hisss Hiss hissss Hiss hisss Hisss hiss Hissss +hissss Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssss Hiss hisss Hiss +hissss Hiss hisss Hissss hiss Hiss hiss Hiss +hisss Hisss hissss Hiss hiss Hissss hisssssss +Hiss hisss Hiss hiss Hisssss hissssssss Hiss +hisss Hiss hissss Hisss hisss Hisss hiss +Hissss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hiss hiss Hissssss +hisss Hiss hiss Hiss hissssss Hiss hiss Hiss +hissssssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisss +Hisss hissss Hiss hissssssss Hiss hissss +Hisss hissss Hiss hiss Hisssss hiss Hisss +hisss Hiss hisss Hissss hisss Hiss hissss +Hisss hiss Hiss hisss Hiss hiss Hisss hissss +Hiss hisss Hisss hisssssss Hiss hisss Hissss +hiss Hissss hisssss Hiss hiss Hisss hiss +Hiss hisss Hiss hiss Hisss hissss Hiss hiss +Hissss hiss Hiss hiss Hiss hisss Hisss hiss +Hisss hisss Hissss hissssss Hissss hiss Hiss +hisssss Hisss hiss Hisss hissss Hisss hiss +Hiss hiss Hiss hisss Hisss hisssssss Hiss +hissss Hiss hissss Hisss hiss Hiss hiss Hiss +hisss Hisss hisss Hisss hisss Hisss hiss +Hisssss hiss Hisss hisss Hiss hisss Hissss +hiss Hiss hiss Hiss hisss Hisss hisssssss +Hiss hissss Hiss hissss Hiss hisss Hisss +hiss Hissss hissss Hiss hissss Hiss hissssssss +Hiss hisss Hisssss hiss Hisss hisss Hiss +hisss Hissss hisssssss Hiss hissss Hiss hissss +Hiss hisssss Hisss hiss Hiss hissss Hiss +hissss Hiss hissss Hissss hiss Hiss hissssssss +Hiss hisssss Hiss hiss Hiss hiss Hiss hisssss +Hiss hiss Hisss hiss Hiss hisss Hiss hiss +Hisss hisss Hissss hiss Hisss hiss Hissss +hisss Hisss hiss Hisss hisss Hissss hisssssss +Hiss hisssss Hisss hiss Hisss hiss Hiss hisss +Hiss hiss Hisss hiss Hisss hiss Hiss hiss +Hisss hiss Hiss hiss Hiss hisss Hisss hisssssss +Hiss hissss Hiss hissss Hisss hiss Hiss hiss +Hiss hisss Hisss hissss Hisss hiss Hisss +hiss Hisssss hiss Hisss hiss Hissss hiss +Hissss hisssssss Hiss hisss Hiss hisssss +Hisss hisss Hiss hisss Hissss hiss Hiss hiss +Hiss hisss Hisss hisssssss Hiss hisss Hiss +hisssss Hisss hissss Hisss hiss Hisss hissss +Hisss hiss Hisss hiss Hisssss hiss Hisss +hiss Hissss hiss Hissss hiss Hiss hiss Hiss +hisss Hisss hissss Hiss hisss Hisss hisss +Hiss hiss Hissss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hisss hissss Hiss +hissss Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisss Hisss hissss Hiss hissssssss Hiss +hisss Hiss hissss Hisss hisss Hiss hisss +Hiss hiss Hiss hissssssss Hiss hisssss Hiss +hiss Hiss hiss Hiss hisssss Hiss hiss Hisss +hiss Hiss hiss Hiss hisss Hisss hisssssss +Hiss hisss Hiss hiss Hiss hisss Hisss hisssss +Hisssss hissssss Hissss hisss Hiss hisss +Hissss hiss Hiss hiss Hiss hisss Hisss hiss +Hisss hisss Hissss hiss Hisss hisss Hissss +hiss Hiss hisss Hiss hiss Hisss hiss Hisssss +hiss Hisss hisss Hissss hiss Hisss hisssssss +Hiss hisss Hiss hisss Hiss hiss Hisss hiss +Hisss hisss Hissss hisssssss Hiss hisss Hiss +hiss Hiss hisss Hisss hiss Hiss hiss Hisss +hiss Hisss hissssss Hissss hissss Hiss hiss +Hissss hiss Hiss hisss Hisssss hisssssss +Hiss hissss Hisss hisss Hisss hiss Hisssss +hiss Hisss hisss Hiss hisss Hissss hisssssss +Hiss hissss Hiss hissss Hiss hissss Hisss +hisss Hisss hiss Hisssss hiss Hisss hisss +Hiss hisss Hissss hisss Hiss hissss Hiss +hissssssss Hiss hisssss Hisss hiss Hisss +hiss Hisssss hiss Hisss hiss Hisssss hiss +Hisss hissssss Hissss hisss Hissss hiss Hiss +hissssssss Hiss hisss Hiss hiss Hiss hissss +Hiss hisss Hissss hiss Hiss hisss Hissss +hisss Hisss hisss Hissss hiss Hiss hissss +Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisss Hisss hissss Hiss hissssssss Hiss +hissssssss Hiss hissssssss Hiss hissss Hisss +hisss Hisss hiss Hisssss hiss Hisss hisss +Hiss hisss Hissss hisssssss Hiss hissssss +Hiss hiss Hiss hisss Hiss hisss Hiss hiss +Hisss hisssssss Hiss hisss Hiss hiss Hisssss +hissssssss Hiss hisssssss Hisss hisss Hisss +hiss Hissss hissssssss Hiss hisss Hisss hiss +Hissss hissssssss Hiss hisss Hiss hisss Hiss +hiss Hisss hiss Hisss hiss Hiss hiss Hiss +hisss Hisss hiss Hiss hiss Hiss hisss Hiss +hisss Hiss hiss Hiss hissss Hiss hiss Hiss +hissssssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisss +Hisss hissss Hiss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hisss hissss Hiss +hissssssss Hiss hissss Hiss hisss Hisss hisss +Hiss hisss Hiss hiss Hiss hissssssss Hiss +hisss Hiss hissssss Hiss hisss Hissss hiss +Hisss hisssssss Hiss hisss Hiss hiss Hiss +hisss Hisss hiss Hiss hiss Hisss hiss Hisss +hissssss Hissss hissss Hiss hiss Hissss hiss +Hiss hisss Hisssss hisssssss Hiss hisss Hisss +hisss Hissss hissss Hiss hiss Hissss hiss +Hiss hisssss Hisss hissss Hiss hiss Hissss +hiss Hiss hiss Hiss hisss Hisss hiss Hiss +hiss Hisss hiss Hisss hiss Hiss hiss Hiss +hisss Hisss hisss Hissss hiss Hisss hissss +Hiss hiss Hissss hisss Hissss hiss Hiss hissssssss +Hiss hisss Hiss hiss Hiss hissss Hiss hisss +Hissss hiss Hiss hisss Hissss hisss Hisss +hisss Hissss hiss Hiss hissss Hiss hiss Hiss +hissssssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisss +Hisss hissss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hissss hiss Hissss +hisssss Hiss hiss Hisss hiss Hiss hisss Hiss +hiss Hisss hissss Hisss hiss Hisss hiss Hiss +hiss Hiss hisss Hisss hisssssss Hiss hissssss +Hiss hiss Hiss hisss Hissss hiss Hissss hisss +Hiss hisss Hissss hiss Hiss hisss Hiss hiss +Hisss hissss Hiss hiss Hissss hiss Hiss hiss +Hiss hisss Hisss hisssss Hiss hiss Hiss hisss +Hisss hisss Hissss hissss Hiss hiss Hissss +hiss Hiss hisssss Hisss hissss Hiss hiss +Hissss hiss Hiss hiss Hiss hiss Hissss hiss +Hisss hisss Hissss hiss Hissss hiss Hissss +hisss Hiss hisss Hissss hiss Hiss hisss Hiss +hiss Hisss hissss Hiss hiss Hissss hiss Hiss +hiss Hiss hisss Hisss hissss Hisss hiss Hiss +hissssssss Hiss hissss Hisss hisss Hiss hisss +Hisss hisss Hissss hissss Hiss hiss Hissss +hiss Hiss hisssss Hisss hissss Hiss hiss +Hissss hiss Hiss hiss Hiss hiss Hissss hiss +Hisss hisss Hissss hissss Hisss hiss Hiss +hissssssss Hiss hisss Hiss hissss Hisss hisss +Hiss hisss Hiss hiss Hiss hissssssss Hiss +hisss Hiss hiss Hisssss hisss Hiss hiss Hisssss +hissssssss Hiss hisss Hiss hiss Hisss hiss +Hiss hisss Hiss hissss Hisss hissssssss Hiss +hissss Hisss hisss Hiss hissss Hisss hisss +Hiss hissss Hiss hiss Hiss hissssssssss Hiss +hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hisss hissss Hiss +hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hiss hiss Hiss +hisss Hisss hisss Hiss hisss Hissss hisss +Hiss hisss Hissss hisss Hissss hiss Hisss +hiss Hisssss hiss Hisss hisssssss Hiss hisss +Hiss hiss Hisssss hisss Hiss hiss Hisssss +hissssssss Hiss hisss Hiss hiss Hiss hissss +Hiss hiss Hiss hisss Hiss hisss Hiss hisss +Hissss hisss Hiss hissss Hiss hiss Hiss hiss +Hiss hisss Hiss hisss Hiss hiss Hiss hiss +Hiss hisss Hiss hiss Hiss hissss Hiss hiss +Hiss hissssssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisss +Hisss hissss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisss +Hisss hiss Hissss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hisss hissss Hiss +hissss Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisss Hiss hisss Hiss hiss Hisss hisss +Hisss hisss Hisss hisssssss Hiss hissssss +Hiss hiss Hiss hisssss Hiss hisss Hiss hisssss +Hiss hisss Hisss hiss Hiss hisssss Hisss +hissss Hiss hiss Hissss hiss Hiss hisssss +Hisss hisssssss Hiss hisss Hiss hiss Hisssss +hissss Hisssssss hisssssss Hiss hisss Hisssss +hiss Hiss hisss Hisss hiss Hisss hiss Hiss +hisss Hisssss hiss Hiss hiss Hisss hiss Hissss +hisssss Hissss hiss Hiss hiss Hisss hisss +Hissss hiss Hiss hiss Hissss hiss Hiss hissss +Hissss hiss Hiss hiss Hisss hisss Hissss +hiss Hisss hiss Hiss hiss Hiss hisss Hisss +hiss Hisss hiss Hiss hiss Hisss hiss Hissss +hisssss Hisss hiss Hiss hisss Hiss hiss Hissss +hiss Hiss hiss Hisssss hiss Hiss hisss Hiss +hisss Hiss hiss Hiss hissssssss Hiss hisss +Hisss hiss Hisssss hisss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisssssss +Hissss hisss Hiss hisss Hissss hiss Hiss +hisss Hiss hiss Hisss hisss Hissss hiss Hisss +hissss Hiss hiss Hissss hisssssss Hiss hissss +Hiss hissss Hiss hisss Hissss hiss Hiss hiss +Hiss hisssss Hiss hiss Hisss hiss Hiss hisss +Hiss hiss Hisss hissss Hiss hiss Hissss hiss +Hiss hiss Hiss hisss Hisss hiss Hisss hisss +Hissss hissssss Hissss hiss Hiss hisssss +Hisss hiss Hisss hissss Hisss hiss Hiss hiss +Hiss hisss Hisss hisssssss Hiss hissss Hiss +hissss Hisss hiss Hiss hiss Hiss hisss Hisss +hisss Hisss hisss Hisss hiss Hisssss hiss +Hisss hisss Hiss hisss Hissss hiss Hiss hiss +Hiss hisss Hisss hisssssss Hiss hissssss +Hiss hiss Hiss hisss Hisss hisss Hissss hiss +Hiss hiss Hiss hisss Hisss hiss Hiss hiss +Hisss hiss Hisss hiss Hiss hisss Hiss hiss +Hisss hiss Hiss hisss Hiss hiss Hiss hisss +Hisss hissss Hisss hiss Hisssss hiss Hisss +hissss Hisss hiss Hisss hiss Hisssss hiss +Hisss hisss Hissss hiss Hisss hisss Hiss +hiss Hissss hisssss Hissss hiss Hiss hisss +Hissss hiss Hisss hisss Hiss hissss Hiss +hisss Hisss hiss Hissss hissss Hiss hiss +Hiss hissssssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisssssss Hissss hisss Hiss hisss Hissss +hiss Hiss hisss Hiss hiss Hisss hisss Hissss +hiss Hisss hissss Hiss hiss Hissss hisssssss +Hiss hissss Hiss hissss Hiss hisssss Hiss +hisss Hiss hissss Hisss hisss Hisss hiss +Hiss hisss Hiss hiss Hisss hissss Hisss hiss +Hisss hiss Hiss hiss Hiss hisss Hisss hisss +Hiss hiss Hissss hisssss Hiss hisss Hiss +hissss Hissss hiss Hiss hissss Hiss hiss +Hissss hissssssss Hiss hisssss Hiss hisss +Hiss hisssss Hisss hiss Hisss hiss Hiss hisss +Hiss hiss Hisss hisss Hissss hiss Hisss hiss +Hiss hiss Hiss hisss Hisss hisss Hiss hissss +Hiss hisss Hisss hiss Hissss hissss Hiss +hiss Hiss hissssssssss Hiss hissssssss Hiss +hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssss Hiss hisss Hiss +hissss Hiss hisss Hissss hiss Hiss hiss Hiss +hisss Hisss hissss Hiss hiss Hissss hisssssss +Hiss hisss Hiss hiss Hisssss hissssssss Hiss +hisss Hiss hissss Hisss hisss Hisss hiss +Hissss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hiss hiss Hissssss +hisss Hiss hiss Hiss hissssss Hiss hiss Hiss +hissssssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisss +Hisss hissss Hiss hissssssss Hiss hissss +Hiss hisss Hiss hiss Hiss hiss Hiss hiss +Hiss hisss Hisss hiss Hiss hissss Hissss +hiss Hiss hiss Hiss hiss Hissss hiss Hiss +hisss Hiss hiss Hisss hisss Hiss hisss Hissss +hiss Hiss hiss Hiss hisss Hisss hisssssss +Hiss hisss Hiss hiss Hiss hissss Hiss hiss +Hisssss hisss Hiss hissss Hisss hisss Hiss +hissss Hisss hiss Hiss hissssssss Hiss hisss +Hiss hiss Hisss hiss Hisss hiss Hiss hisssss +Hisss hiss Hisss hissss Hisss hisss Hiss +hisss Hissss hiss Hisssss hiss Hisss hisssssss +Hiss hisssss Hisss hiss Hisss hiss Hiss hisss +Hiss hiss Hisss hisss Hissss hiss Hisss hiss +Hiss hiss Hiss hisss Hisss hisssssss Hiss +hisss Hisss hissss Hisss hiss Hisssss hiss +Hisss hisss Hissss hiss Hisss hissss Hiss +hiss Hissss hiss Hiss hisss Hiss hiss Hisss +hisss Hissss hiss Hisss hiss Hiss hiss Hiss +hiss Hissss hiss Hiss hisssss Hisss hissss +Hiss hiss Hissss hiss Hiss hisss Hiss hiss +Hisss hiss Hisssss hiss Hisss hisss Hissss +hiss Hisss hissss Hisss hiss Hiss hissssssss +Hiss hisss Hisssss hiss Hisss hisss Hiss +hisss Hissss hisssssss Hiss hisss Hissss +hiss Hissss hisssss Hiss hiss Hisss hiss +Hiss hisss Hiss hiss Hisss hissss Hiss hiss +Hissss hiss Hiss hiss Hiss hisss Hisss hiss +Hisss hisss Hissss hissssss Hissss hiss Hiss +hisssss Hisss hiss Hisss hissss Hisss hiss +Hiss hiss Hiss hisss Hisss hisssssss Hiss +hisss Hiss hisssss Hisss hisss Hisss hisss +Hisss hissss Hiss hiss Hissss hiss Hiss hiss +Hiss hisss Hisss hisss Hiss hisss Hissss +hisssssss Hiss hissss Hiss hissss Hiss hisss +Hisss hiss Hissss hissss Hiss hissss Hiss +hissss Hissss hiss Hiss hissss Hiss hiss +Hiss hissssssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisss +Hisss hissss Hiss hissssssss Hiss hisss Hiss +hissssss Hiss hissss Hisss hiss Hisss hissss +Hisss hiss Hisss hiss Hisssss hiss Hisss +hiss Hissss hiss Hissss hisssssss Hiss hissss +Hiss hissss Hiss hissss Hisss hisss Hisss +hiss Hisssss hiss Hisss hisss Hiss hisss +Hissss hisssssss Hiss hissssss Hiss hiss +Hiss hisss Hisss hiss Hissss hisss Hisss +hiss Hissss hisss Hiss hisss Hiss hiss Hiss +hissss Hiss hissss Hiss hissssssss Hiss hisss +Hiss hisssss Hisss hiss Hisss hisss Hissss +hisssssss Hiss hisss Hiss hisssss Hisss hisss +Hissss hiss Hisss hisssssss Hiss hisss Hiss +hiss Hiss hisss Hisss hisssss Hisssss hiss +Hisss hissss Hisss hiss Hiss hiss Hiss hisss +Hisss hissssss Hissss hissss Hiss hiss Hissss +hiss Hiss hisss Hiss hiss Hisss hiss Hisssss +hiss Hisss hisss Hissss hiss Hisss hisss +Hissss hiss Hiss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hiss hisss Hiss +hiss Hisss hisss Hisss hisss Hisss hisssssss +Hiss hissssss Hiss hiss Hiss hisssss Hiss +hisss Hiss hisssss Hiss hisss Hisss hiss +Hiss hisssss Hisss hissss Hiss hiss Hissss +hiss Hiss hisssss Hisss hisssssss Hiss hisss +Hiss hiss Hisssss hissss Hisssssss hisssssss +Hiss hisss Hisssss hiss Hiss hisss Hisss +hiss Hissss hisss Hisss hiss Hisss hiss Hiss +hisss Hisssss hiss Hiss hiss Hiss hisss Hiss +hissssssssss Hiss hisssss Hissss hiss Hiss +hissss Hissss hiss Hiss hissss Hissss hiss +Hiss hisss Hissss hiss Hisss hiss Hisss hiss +Hissss hisss Hiss hisss Hiss hiss Hiss hisss +Hiss hiss Hissss hiss Hiss hiss Hisssss hiss +Hiss hisss Hiss hisss Hiss hiss Hiss hissssssss +Hiss hisss Hisss hiss Hisssss hisss Hiss +hiss Hiss hissssssssss Hiss hissssssss Hiss +hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssssss Hissss hisss +Hiss hisss Hissss hiss Hiss hisss Hiss hiss +Hisss hisss Hissss hiss Hisss hissss Hiss +hiss Hissss hisssssss Hiss hissss Hiss hissss +Hiss hisss Hiss hisss Hiss hisss Hiss hisss +Hissss hiss Hisss hisss Hisss hiss Hissss +hiss Hiss hisssss Hisss hissss Hisss hiss +Hisss hiss Hiss hisss Hiss hiss Hisss hissss +Hiss hisss Hisss hisssssss Hiss hisss Hisss +hissss Hisss hisssss Hiss hiss Hisss hiss +Hiss hisssss Hisss hisss Hiss hisss Hissss +hiss Hiss hisssss Hisss hiss Hisss hissss +Hisss hissss Hiss hiss Hissss hiss Hiss hiss +Hiss hisss Hisss hisss Hiss hisss Hissss +hisssssss Hiss hisss Hiss hisssss Hisss hisss +Hisss hisss Hisss hissss Hiss hiss Hissss +hiss Hiss hiss Hiss hisss Hisss hisss Hiss +hisss Hissss hisssssss Hiss hisss Hisss hisss +Hissss hiss Hiss hiss Hiss hisss Hisss hiss +Hiss hiss Hisss hiss Hisss hiss Hiss hisss +Hiss hiss Hisss hiss Hisss hissss Hisss hiss +Hisssss hiss Hisss hissss Hisss hiss Hisss +hiss Hisssss hiss Hisss hisss Hissss hiss +Hisss hisss Hiss hiss Hissss hisssss Hissss +hiss Hiss hisss Hissss hiss Hisss hisss Hiss +hissss Hiss hisss Hisss hiss Hissss hissss +Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssssss Hissss hisss +Hiss hisss Hissss hiss Hiss hisss Hiss hiss +Hisss hisss Hissss hiss Hisss hissss Hiss +hiss Hissss hisssssss Hiss hissss Hiss hissss +Hiss hisssss Hiss hisss Hiss hissss Hisss +hisss Hisss hiss Hiss hisss Hiss hiss Hisss +hissss Hisss hiss Hisss hiss Hiss hiss Hiss +hisss Hisss hisss Hiss hiss Hissss hisssss +Hiss hisss Hiss hissss Hissss hiss Hiss hissss +Hiss hiss Hissss hissssssss Hiss hisssss +Hiss hisss Hiss hisssss Hisss hiss Hisss +hiss Hiss hisss Hiss hiss Hisss hisss Hissss +hiss Hisss hiss Hiss hiss Hiss hisss Hisss +hisss Hiss hissss Hiss hisss Hisss hiss Hissss +hissss Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssss Hiss hisss Hiss +hissss Hiss hisss Hissss hiss Hiss hiss Hiss +hisss Hisss hissss Hiss hiss Hissss hisssssss +Hiss hisss Hiss hiss Hisssss hissssssss Hiss +hisss Hiss hissss Hisss hisss Hisss hiss +Hissss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hiss hiss Hissssss +hisss Hiss hiss Hiss hissssss Hiss hiss Hiss +hissssssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisss +Hisss hissss Hiss hissssssss Hiss hissss +Hiss hisss Hiss hiss Hiss hiss Hiss hiss +Hiss hisss Hisss hiss Hiss hissss Hissss +hiss Hiss hiss Hiss hiss Hissss hiss Hiss +hisss Hiss hiss Hisss hisss Hiss hisss Hissss +hiss Hiss hiss Hiss hisss Hisss hisssssss +Hiss hisss Hiss hiss Hiss hissss Hiss hiss +Hisssss hisss Hiss hissss Hisss hisss Hiss +hissss Hisss hiss Hiss hissssssss Hiss hisss +Hisss hisss Hissss hissssss Hissss hiss Hiss +hisssss Hisss hiss Hisss hissss Hisss hiss +Hiss hiss Hiss hisss Hisss hissss Hisss hiss +Hiss hissssssss Hiss hisss Hisssss hiss Hisss +hisss Hiss hisss Hissss hisssssss Hiss hisss +Hiss hiss Hiss hisss Hisss hisss Hissss hiss +Hisss hiss Hiss hiss Hiss hiss Hissss hiss +Hiss hiss Hisss hiss Hisss hiss Hisssss hiss +Hiss hisss Hisss hisss Hissss hissss Hiss +hiss Hissss hisss Hiss hisss Hissss hiss +Hiss hiss Hiss hiss Hissss hiss Hisss hissss +Hisss hissss Hiss hiss Hissss hisssssss Hiss +hisss Hiss hiss Hiss hisss Hisss hisss Hissss +hiss Hisss hissss Hiss hisss Hisss hisssssss +Hiss hisss Hiss hisssss Hisss hisss Hisss +hisss Hisss hissss Hiss hiss Hissss hiss +Hiss hiss Hiss hisss Hisss hisss Hiss hisss +Hissss hisssssss Hiss hisss Hisss hissss +Hisss hiss Hisssss hiss Hisss hiss Hiss hiss +Hisss hiss Hisss hiss Hiss hiss Hisss hiss +Hisss hiss Hiss hisssss Hisss hisss Hissss +hiss Hiss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hiss hisss Hiss +hiss Hisss hisss Hisss hisss Hisss hisssssss +Hiss hissssss Hiss hiss Hiss hisssss Hiss +hisss Hiss hisssss Hiss hisss Hisss hiss +Hiss hisssss Hisss hissss Hiss hiss Hissss +hiss Hiss hisssss Hisss hisssssss Hiss hisss +Hiss hiss Hisssss hissss Hisssssss hisssssss +Hiss hisss Hisssss hiss Hiss hisssss Hisss +hiss Hiss hisss Hisss hiss Hisss hiss Hiss +hisss Hisssss hiss Hiss hisssssss Hiss hisssss +Hissss hiss Hiss hissss Hissss hiss Hiss +hissss Hissss hiss Hiss hisss Hissss hiss +Hisss hiss Hiss hisss Hiss hiss Hiss hisss +Hiss hiss Hissssss hiss Hiss hiss Hissss +hiss Hiss hiss Hisssss hiss Hiss hisss Hiss +hisss Hiss hiss Hiss hissssssss Hiss hisss +Hisss hiss Hisssss hisss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisssssss +Hissss hisss Hiss hisss Hissss hiss Hiss +hisss Hiss hiss Hisss hisss Hissss hiss Hisss +hissss Hiss hiss Hissss hisssssss Hiss hissss +Hiss hissss Hiss hisss Hiss hisss Hiss hisss +Hiss hisss Hissss hiss Hisss hisss Hisss +hiss Hissss hiss Hiss hisssss Hisss hissss +Hisss hiss Hisss hiss Hiss hisss Hiss hiss +Hisss hissss Hiss hisss Hisss hisssssss Hiss +hisss Hisss hissss Hisss hisssss Hiss hiss +Hisss hiss Hiss hisssss Hisss hisss Hiss +hisss Hissss hiss Hiss hisssss Hisss hiss +Hisss hissss Hisss hissss Hiss hiss Hissss +hiss Hiss hiss Hiss hisss Hisss hisss Hiss +hisss Hissss hisssssss Hiss hisss Hiss hisssss +Hisss hisss Hisss hisss Hisss hissss Hiss +hiss Hissss hiss Hiss hiss Hiss hisss Hisss +hisss Hiss hisss Hissss hisssssss Hiss hisss +Hisss hissss Hisss hiss Hisssss hiss Hisss +hiss Hiss hiss Hisss hiss Hisss hiss Hiss +hiss Hisss hiss Hisss hiss Hiss hisssss Hisss +hisss Hiss hiss Hissss hisssss Hissss hiss +Hiss hisss Hissss hiss Hisss hisss Hiss hissss +Hiss hisss Hisss hiss Hissss hissss Hiss +hiss Hiss hissssssssss Hiss hissssssss Hiss +hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssssss Hissss hisss +Hiss hisss Hissss hiss Hiss hisss Hiss hiss +Hisss hisss Hissss hiss Hisss hissss Hiss +hiss Hissss hisssssss Hiss hissss Hiss hissss +Hiss hisssss Hiss hisss Hiss hissss Hisss +hisss Hisss hiss Hiss hisss Hiss hiss Hisss +hissss Hisss hiss Hisss hiss Hiss hiss Hiss +hisss Hisss hisss Hiss hiss Hissss hisssss +Hiss hisss Hiss hissss Hissss hiss Hiss hissss +Hiss hiss Hissss hissssssss Hiss hisssss +Hiss hisss Hiss hisssss Hisss hiss Hisss +hiss Hiss hisss Hiss hiss Hisss hisss Hissss +hiss Hisss hiss Hiss hiss Hiss hisss Hisss +hisss Hiss hissss Hiss hisss Hisss hiss Hissss +hissss Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssss Hiss hisss Hiss +hissss Hiss hisss Hissss hiss Hiss hiss Hiss +hisss Hisss hissss Hiss hiss Hissss hisssssss +Hiss hisss Hiss hiss Hisssss hissssssss Hiss +hisss Hiss hissss Hisss hisss Hisss hiss +Hissss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hiss hiss Hissssss +hisss Hiss hiss Hiss hissssss Hiss hiss Hiss +hissssssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisss +Hisss hissss Hiss hissssssss Hiss hissss +Hiss hisss Hiss hiss Hiss hiss Hiss hiss +Hiss hisss Hisss hiss Hiss hissss Hissss +hiss Hiss hiss Hiss hiss Hissss hiss Hiss +hisss Hiss hiss Hisss hisss Hiss hisss Hissss +hiss Hiss hiss Hiss hisss Hisss hisssssss +Hiss hisss Hisss hisss Hissss hissssss Hissss +hiss Hiss hisssss Hisss hiss Hisss hissss +Hisss hiss Hiss hiss Hiss hisss Hisss hiss +Hisss hisss Hissss hisssssss Hiss hisss Hiss +hisssss Hisss hisss Hiss hisss Hissss hiss +Hisssss hiss Hisss hiss Hiss hiss Hiss hiss +Hissss hisss Hissss hiss Hisss hissss Hiss +hisss Hisss hisssssss Hiss hisss Hiss hisssss +Hisss hiss Hisss hisss Hissss hiss Hisss +hisss Hissss hiss Hiss hisss Hiss hiss Hisss +hiss Hissss hisss Hisss hisss Hissss hiss +Hisss hiss Hiss hiss Hisss hiss Hisss hiss +Hiss hiss Hiss hisss Hisss hisss Hissss hiss +Hisss hissss Hiss hiss Hissss hisssssss Hiss +hisss Hissss hisss Hiss hisss Hiss hiss Hisssss +hisss Hissss hisss Hiss hisssss Hisss hiss +Hiss hissssssss Hiss hisss Hisss hissss Hisss +hiss Hisssss hiss Hisss hiss Hiss hiss Hisss +hiss Hisss hissssss Hissss hiss Hisssss hiss +Hisss hiss Hiss hiss Hiss hiss Hissss hisss +Hissss hiss Hisss hissss Hiss hisss Hisss +hiss Hisss hisss Hissss hisssssss Hiss hisss +Hiss hisssss Hisss hisss Hissss hiss Hisss +hissss Hiss hisss Hisss hisssssss Hiss hisss +Hissss hisss Hiss hisss Hiss hiss Hisssss +hisss Hiss hiss Hisssss hisss Hissss hisss +Hiss hissss Hiss hiss Hiss hissssssssss Hiss +hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hisss hissss Hiss +hissssssss Hiss hisss Hissss hiss Hissss +hiss Hiss hisss Hiss hiss Hisss hissss Hiss +hiss Hissss hisssss Hiss hiss Hisss hisssssss +Hiss hisssss Hiss hiss Hissss hisssss Hiss +hiss Hisss hiss Hiss hiss Hiss hisss Hisss +hisssssss Hiss hisss Hiss hiss Hiss hisss +Hisss hisssss Hisssss hiss Hisss hissss Hisss +hiss Hiss hiss Hiss hisss Hisss hissssss +Hissss hissss Hiss hiss Hissss hiss Hiss +hisss Hiss hiss Hisss hiss Hisssss hiss Hisss +hisss Hissss hiss Hisss hisssssss Hiss hisss +Hisssss hiss Hisss hisss Hisss hisss Hisss +hisssssss Hiss hissss Hisss hiss Hissss hiss +Hiss hisss Hiss hiss Hisss hisss Hiss hisss +Hissss hiss Hiss hissssss Hiss hiss Hisss +hisss Hissss hiss Hisss hisss Hissss hiss +Hiss hiss Hiss hisss Hisss hisss Hiss hisss +Hissss hissss Hiss hiss Hissss hiss Hisss +hisssss Hiss hiss Hiss hiss Hisss hiss Hisss +hissssss Hissss hiss Hiss hisss Hiss hisss +Hiss hisss Hissss hiss Hisss hissss Hiss +hiss Hissss hisssss Hiss hiss Hiss hisss +Hiss hisss Hiss hiss Hiss hissss Hiss hiss +Hiss hissssssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisssss +Hiss hisss Hiss hisssss Hiss hiss Hissss +hiss Hiss hiss Hisss hiss Hisss hissssss +Hissss hissss Hiss hisss Hisss hiss Hiss +hisssss Hisss hissss Hiss hiss Hissss hiss +Hiss hisssss Hisss hisssssss Hiss hisss Hiss +hiss Hisssss hissssssss Hiss hisssss Hiss +hisss Hiss hisssss Hiss hisss Hisss hiss +Hiss hisssss Hisss hissss Hiss hiss Hissss +hiss Hiss hisssss Hisss hiss Hisss hiss Hissss +hissss Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisssss Hiss hisss Hiss hisssss Hiss +hiss Hissss hiss Hiss hiss Hisss hiss Hisss +hissssss Hissss hissss Hiss hisss Hisss hiss +Hiss hisssss Hisss hissss Hiss hiss Hissss +hiss Hiss hisssss Hisss hisssssss Hiss hisss +Hiss hiss Hisssss hissss Hisssssss hisssssss +Hiss hisss Hisss hisss Hissss hiss Hisssss +hiss Hiss hissssss Hiss hiss Hiss hissss +Hisss hiss Hissss hiss Hiss hisss Hiss hiss +Hisss hisss Hiss hisss Hissss hiss Hiss hissssss +Hiss hiss Hisss hisss Hissss hiss Hisss hisss +Hissss hiss Hiss hiss Hiss hisss Hisss hisss +Hiss hisss Hissss hissss Hiss hiss Hissss +hiss Hisss hisssss Hiss hiss Hiss hiss Hisss +hiss Hisss hissssss Hissss hiss Hiss hisss +Hiss hisss Hiss hisss Hissss hiss Hisss hissss +Hiss hiss Hissss hissss Hissss hiss Hiss +hisssss Hiss hiss Hiss hissss Hissss hiss +Hiss hissss Hiss hiss Hiss hiss Hiss hissssssss +Hiss hisss Hiss hisss Hiss hiss Hiss hissss +Hissss hiss Hiss hisss Hisssssss hisss Hiss +hiss Hisssss hisssss Hisss hiss Hiss hisss +Hisssss hiss Hiss hisssss Hiss hisss Hiss +hisss Hiss hissss Hisss hisss Hisssss hiss +Hisss hissssss Hissss hissss Hisss hiss Hiss +hisss Hisssss hiss Hiss hisss Hisss hiss +Hissss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hiss hisss Hiss +hiss Hisss hisss Hisss hisss Hisss hisssssss +Hiss hissssss Hiss hiss Hiss hisssss Hiss +hisss Hiss hisssss Hiss hiss Hissss hiss +Hiss hiss Hisss hiss Hisss hissssss Hissss +hissss Hiss hisss Hisss hiss Hiss hisssss +Hisss hissss Hiss hiss Hissss hiss Hiss hisssss +Hisss hisssssss Hiss hisss Hiss hiss Hisssss +hissss Hisssssss hisssssss Hiss hisss Hisssss +hiss Hiss hisss Hisss hiss Hisss hiss Hiss +hisss Hisssss hiss Hiss hisssssss Hiss hisss +Hiss hiss Hissss hiss Hiss hissss Hissss +hiss Hiss hisss Hiss hissss Hisss hiss Hisss +hiss Hisss hiss Hiss hiss Hiss hisssss Hiss +hisssss Hisssss hissss Hissssss hissss Hisss +hisss Hiss hisssss Hissssss hissss Hissss +hiss Hiss hiss Hiss hiss Hisss hiss Hiss +hisss Hisss hiss Hiss hiss Hiss hissss Hiss +hiss Hiss hiss Hiss hisssss Hissss hiss Hiss +hiss Hisssss hiss Hiss hisss Hiss hiss Hiss +hisss Hiss hisssss Hissss hiss Hiss hisss +Hisssss hiss Hiss hiss Hiss hiss Hisssss +hisss Hiss hiss Hissss hiss Hiss hiss Hisssssss +hisss Hiss hiss Hisssss hisss Hisss hiss +Hisss hiss Hiss hisss Hisssss hiss Hiss hiss +Hiss hiss Hisssss hisss Hiss hiss Hissss +hiss Hiss hiss Hisssss hiss Hiss hissssssss +Hiss hisssss Hissssss hissss Hissssss hisss +Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssss Hiss hisss Hiss +hisssss Hiss hiss Hissss hiss Hiss hiss Hisss +hiss Hisss hissssss Hissss hissss Hiss hisss +Hisss hiss Hiss hisssss Hisss hissss Hiss +hiss Hissss hiss Hiss hisssss Hisss hisssssss +Hiss hisss Hiss hiss Hisssss hissss Hisssssss +hisssssss Hiss hisss Hisssss hiss Hiss hisss +Hiss hiss Hisssss hisss Hisss hiss Hisss +hiss Hiss hisss Hisssss hiss Hiss hiss Hiss +hiss Hisssss hissssssss Hiss hisssss Hissss +hiss Hiss hissss Hissss hiss Hiss hissss +Hissss hiss Hiss hisss Hissss hiss Hisss +hiss Hiss hiss Hissss hiss Hiss hiss Hisssss +hiss Hiss hisss Hiss hisss Hiss hiss Hiss +hissssssss Hiss hisss Hisss hiss Hisssss +hisss Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssssss Hissss hisss +Hiss hisss Hissss hiss Hiss hisss Hiss hiss +Hisss hisss Hissss hiss Hisss hissss Hiss +hiss Hissss hisssssss Hiss hissss Hiss hissss +Hiss hisss Hisss hisss Hiss hiss Hiss hissssss +Hissss hiss Hiss hisssss Hisss hiss Hisss +hissss Hisss hiss Hiss hisss Hiss hiss Hisss +hisss Hissss hiss Hisss hiss Hissss hisss +Hisss hisssssss Hiss hisss Hiss hisssss Hisss +hisss Hiss hisss Hissss hiss Hisssss hiss +Hisss hiss Hiss hiss Hiss hiss Hissss hisss +Hissss hiss Hisss hissss Hiss hisss Hisss +hisssssss Hiss hisss Hissss hisss Hiss hisss +Hiss hiss Hisssss hisss Hissss hisss Hiss +hissssssss Hiss hisss Hisssss hiss Hisss +hisss Hiss hisss Hissss hisssssss Hiss hisss +Hissss hisss Hiss hisss Hiss hiss Hisssss +hisss Hiss hiss Hisssss hisss Hissss hisss +Hiss hissss Hiss hiss Hissss hisssss Hissss +hiss Hiss hisss Hissss hiss Hisss hisss Hiss +hissss Hiss hisss Hisss hiss Hissss hissss +Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssssss Hissss hisss +Hiss hisss Hissss hiss Hiss hisss Hiss hiss +Hisss hisss Hissss hiss Hisss hissss Hiss +hiss Hissss hisssssss Hiss hissss Hiss hissss +Hiss hisssss Hiss hisss Hiss hissss Hisss +hisss Hisss hiss Hiss hisss Hiss hiss Hisss +hissss Hisss hiss Hisss hiss Hiss hiss Hiss +hisss Hisss hisss Hiss hiss Hissss hisssss +Hiss hisss Hiss hissss Hissss hiss Hiss hissss +Hiss hiss Hissss hissssssss Hiss hisssss +Hiss hisss Hiss hisssss Hisss hiss Hisss +hiss Hiss hisss Hiss hiss Hisss hisss Hissss +hiss Hisss hiss Hiss hiss Hiss hisss Hisss +hisss Hiss hissss Hiss hisss Hisss hiss Hissss +hissss Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssss Hiss hisss Hiss +hissss Hiss hisss Hissss hiss Hiss hiss Hiss +hisss Hisss hissss Hiss hiss Hissss hisssssss +Hiss hisss Hiss hiss Hisssss hissssssss Hiss +hisss Hiss hissss Hisss hisss Hisss hiss +Hissss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hiss hiss Hissssss +hisss Hiss hiss Hiss hissssss Hiss hiss Hiss +hissssssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisss +Hisss hissss Hiss hissssssss Hiss hisss Hisssss +hisss Hiss hisss Hissss hiss Hisss hiss Hiss +hiss Hiss hisss Hisss hisssssss Hiss hisssss +Hisss hiss Hisss hiss Hiss hisss Hiss hiss +Hisss hisss Hissss hiss Hisss hiss Hiss hiss +Hiss hisss Hisss hisssssss Hiss hisss Hisss +hissss Hisss hiss Hisssss hiss Hisss hisss +Hissss hiss Hisss hissss Hiss hisss Hisss +hiss Hiss hisss Hiss hiss Hisss hissss Hiss +hiss Hissss hiss Hiss hisss Hiss hiss Hisss +hiss Hisssss hiss Hisss hisss Hissss hiss +Hisss hiss Hiss hisssss Hisss hissss Hisss +hiss Hisss hisssssss Hiss hisss Hisss hisss +Hissss hissss Hiss hiss Hissss hiss Hiss +hisssss Hisss hissss Hiss hiss Hissss hiss +Hiss hiss Hiss hisss Hisss hiss Hiss hiss +Hisss hiss Hisss hiss Hiss hiss Hiss hisss +Hisss hisss Hissss hiss Hisss hissss Hiss +hiss Hissss hiss Hisss hisss Hissss hisssssss +Hiss hisss Hissss hiss Hissss hiss Hiss hisss +Hiss hiss Hisss hissss Hiss hiss Hissss hisssss +Hiss hiss Hisss hisssssss Hiss hisss Hisssss +hiss Hisss hisss Hissss hiss Hisss hiss Hiss +hiss Hiss hisss Hisss hisssssss Hiss hisssss +Hisss hiss Hisss hiss Hiss hisss Hiss hiss +Hisss hisss Hissss hiss Hisss hiss Hiss hiss +Hiss hisss Hisss hisssssss Hiss hissss Hiss +hissss Hisss hiss Hisssss hiss Hisss hissss +Hiss hisss Hisss hiss Hiss hisss Hiss hiss +Hisss hiss Hiss hiss Hiss hisss Hisss hiss +Hisss hisss Hissss hisssssss Hiss hisss Hisss +hisss Hissss hisssss Hiss hiss Hisss hiss +Hisssss hiss Hisss hiss Hiss hiss Hiss hiss +Hissss hissss Hisss hiss Hisss hissss Hiss +hisss Hisss hisss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hisss hissss Hiss +hissssssss Hiss hissss Hissss hiss Hisss +hiss Hisssss hiss Hisss hissss Hiss hiss +Hissss hisssssss Hiss hisss Hiss hiss Hiss +hiss Hissss hiss Hisss hisss Hissss hiss +Hiss hiss Hiss hisss Hisss hisssssss Hiss +hisss Hisss hissss Hisss hiss Hiss hiss Hiss +hiss Hissss hisss Hiss hisss Hissss hissss +Hisss hiss Hisss hiss Hiss hisss Hisssss +hisssssss Hiss hissss Hiss hissss Hisss hisss +Hiss hisss Hissss hiss Hiss hisssss Hisss +hiss Hisss hissss Hisss hiss Hisss hiss Hiss +hiss Hisss hiss Hiss hiss Hiss hisss Hisss +hissss Hiss hiss Hissss hiss Hisss hisss +Hissss hisss Hissss hiss Hiss hissss Hiss +hiss Hiss hissssssssss Hiss hissssssss Hiss +hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisss Hiss hisss Hiss hiss Hisss hisss +Hisss hisss Hisss hisssssss Hiss hissssss +Hiss hiss Hiss hisssss Hiss hisss Hiss hisssss +Hiss hisss Hisss hiss Hiss hisssss Hisss +hissss Hiss hiss Hissss hiss Hiss hisssss +Hisss hisssssss Hiss hisss Hiss hiss Hisssss +hissss Hisssssss hisssssss Hiss hisss Hisssss +hiss Hiss hissss Hisssss hiss Hiss hissss +Hissss hiss Hiss hiss Hisss hisss Hissss +hisss Hiss hiss Hiss hiss Hiss hissssss Hiss +hiss Hiss hisss Hiss hisss Hiss hiss Hisss +hisss Hisss hisss Hisss hissss Hissssss hiss +Hissss hiss Hissss hisssss Hiss hiss Hisss +hiss Hiss hisss Hiss hiss Hisss hissss Hisss +hiss Hisss hiss Hiss hiss Hiss hisss Hisss +hissss Hissssss hisss Hisss hisss Hisss hiss +Hisssss hiss Hisss hisss Hiss hisss Hissss +hiss Hiss hisss Hiss hiss Hiss hisssss Hissss +hiss Hiss hisss Hiss hissss Hisss hisss Hissss +hiss Hiss hissss Hiss hiss Hiss hiss Hiss +hisssss Hissss hiss Hiss hiss Hisss hiss +Hisssss hissss Hiss hisss Hiss hisss Hisssss +hiss Hiss hisss Hiss hisss Hiss hiss Hiss +hissssssss Hiss hisss Hisss hiss Hisssss +hisss Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssss Hiss hisss Hiss +hisss Hisss hissss Hisss hisss Hiss hissss +Hisss hiss Hissssss hiss Hiss hissss Hisss +hiss Hisss hiss Hiss hisss Hiss hiss Hisss +hisss Hissss hiss Hisss hiss Hiss hiss Hiss +hisss Hisss hisss Hissss hiss Hisss hiss +Hiss hiss Hiss hiss Hissss hiss Hiss hiss +Hisss hiss Hisss hisssssss Hiss hisss Hiss +hiss Hisssss hissssssss Hiss hisssss Hiss +hisss Hiss hissss Hissss hiss Hiss hisss +Hisss hiss Hissss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisssss +Hiss hisss Hiss hisss Hisss hissss Hisss +hisss Hiss hissss Hisss hiss Hissssss hiss +Hiss hiss Hisss hissss Hisss hiss Hisssss +hiss Hisss hissss Hiss hisss Hisss hiss Hiss +hiss Hiss hisss Hisss hisssssss Hiss hisss +Hiss hiss Hisssss hissssssss Hiss hisssss +Hiss hisss Hiss hisssss Hisss hiss Hisss +hiss Hiss hisss Hiss hiss Hisss hisss Hissss +hiss Hisss hiss Hiss hiss Hiss hisss Hisss +hiss Hisss hiss Hissss hissss Hiss hiss Hiss +hissssssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisssss Hiss hisss Hiss hisss Hisss +hissss Hisss hisss Hiss hissss Hisss hiss +Hissssss hiss Hiss hiss Hisss hisss Hissss +hiss Hisss hissss Hisss hiss Hisssss hiss +Hisss hissss Hisss hiss Hisss hiss Hisssss +hiss Hisss hisss Hissss hiss Hisss hisssssss +Hiss hisss Hiss hiss Hisssss hissssssss Hiss +hisssssss Hisss hisss Hisss hiss Hissss hissss +Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisss Hiss hiss Hissssss hisss Hiss +hiss Hiss hissssss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hisss hissss Hiss +hissssssss Hiss hisss Hissss hiss Hiss hiss +Hiss hiss Hiss hiss Hiss hisss Hisss hisssssss +Hiss hissss Hissss hiss Hisss hiss Hiss hiss +Hiss hisss Hisss hiss Hiss hiss Hiss hisss +Hisss hissss Hiss hisss Hisss hisssssss Hiss +hisssss Hiss hiss Hissss hiss Hisssss hiss +Hisss hisssssss Hiss hisss Hisss hissss Hisss +hisssss Hiss hiss Hisss hiss Hiss hiss Hiss +hisss Hisss hiss Hisss hissss Hisss hiss +Hisss hiss Hiss hiss Hisss hisssssss Hiss +hissss Hisss hisss Hisss hiss Hisssss hiss +Hisss hisss Hiss hisss Hissss hisssssss Hiss +hisss Hiss hiss Hiss hisss Hisss hisssss +Hisssss hiss Hiss hisssss Hisss hiss Hisss +hissss Hisss hissss Hiss hiss Hissss hissss +Hisss hiss Hisss hiss Hiss hisss Hisssss +hisssssss Hiss hisss Hisssss hiss Hisss hisss +Hissss hiss Hisss hiss Hiss hiss Hiss hisss +Hisss hisssssss Hiss hisss Hisss hisss Hissss +hiss Hiss hiss Hiss hisss Hisss hiss Hiss +hiss Hisss hiss Hisss hiss Hiss hisss Hiss +hiss Hisss hiss Hisss hissss Hisss hiss Hisssss +hiss Hisss hissss Hisss hiss Hisss hiss Hisssss +hiss Hisss hisss Hissss hiss Hisss hisssssss +Hiss hisss Hiss hisss Hiss hiss Hisss hisss +Hissss hiss Hisss hiss Hisss hisss Hissss +hiss Hiss hisss Hiss hiss Hisss hissss Hiss +hisss Hisss hiss Hiss hiss Hiss hisss Hisss +hisssssss Hiss hisssss Hiss hiss Hissss hisssss +Hiss hiss Hisss hiss Hiss hiss Hiss hisss +Hisss hisssssss Hiss hissss Hiss hissss Hisss +hiss Hisssss hiss Hisss hissss Hiss hisss +Hisss hiss Hiss hisss Hisssss hissss Hisss +hiss Hiss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hisss hissss Hiss +hissssssss Hiss hissss Hiss hissss Hisss +hiss Hiss hiss Hiss hisss Hisss hiss Hisss +hissss Hisss hiss Hiss hisssss Hisss hiss +Hiss hiss Hiss hiss Hissss hiss Hisss hisss +Hissss hiss Hiss hiss Hiss hisss Hisss hisssssss +Hiss hisss Hiss hiss Hiss hisss Hisss hiss +Hiss hiss Hisss hiss Hisss hissssss Hissss +hissss Hiss hiss Hissss hiss Hiss hisss Hisssss +hisssssss Hiss hisss Hisss hisss Hissss hissss +Hiss hiss Hissss hiss Hiss hisssss Hisss +hissss Hiss hiss Hissss hiss Hiss hiss Hiss +hisss Hisss hiss Hiss hiss Hisss hiss Hisss +hiss Hiss hiss Hiss hisss Hisss hisss Hissss +hiss Hisss hissss Hiss hiss Hissss hiss Hisss +hisss Hissss hisssssss Hiss hissssss Hiss +hiss Hiss hisss Hiss hiss Hiss hisss Hisss +hisss Hissss hiss Hiss hisss Hissss hisss +Hisss hisss Hissss hiss Hiss hissssssss Hiss +hisss Hissss hiss Hissss hiss Hiss hisss +Hiss hiss Hisss hissss Hiss hiss Hissss hisssss +Hiss hiss Hisss hisssssss Hiss hisss Hisss +hissss Hisss hiss Hisssss hiss Hisss hiss +Hiss hiss Hisss hiss Hisss hiss Hiss hiss +Hisss hiss Hisss hiss Hiss hiss Hiss hisss +Hisss hisss Hissss hiss Hisss hissss Hiss +hiss Hissss hisssssss Hiss hisss Hisssss +hiss Hisss hisss Hissss hiss Hisss hissss +Hisss hiss Hisss hiss Hiss hisss Hisssss +hiss Hiss hisss Hiss hiss Hiss hissssssss +Hiss hisss Hiss hisssss Hisss hisss Hiss +hisss Hissss hiss Hiss hiss Hiss hisss Hisss +hisss Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisss Hisss hissss Hiss hissssssss Hiss +hisss Hiss hisssss Hisss hissss Hisss hiss +Hisss hissss Hisss hiss Hisss hiss Hisssss +hiss Hisss hiss Hissss hiss Hissss hiss Hiss +hiss Hiss hisss Hisss hissss Hiss hisss Hisss +hisss Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisss Hiss hisss Hiss hiss Hisss hisss +Hisss hisss Hisss hisssssss Hiss hissssss +Hiss hiss Hiss hisssss Hiss hisss Hiss hisss +Hisss hissss Hisss hisss Hiss hissss Hisss +hiss Hissssss hiss Hiss hissss Hisss hiss +Hisss hiss Hiss hisss Hiss hiss Hisss hisss +Hissss hiss Hisss hiss Hiss hiss Hiss hisss +Hisss hisss Hissss hiss Hisss hiss Hiss hiss +Hiss hiss Hissss hiss Hiss hiss Hisss hiss +Hisss hisssssss Hiss hisss Hiss hiss Hisssss +hisss Hiss hiss Hisssss hissssssss Hiss hisssss +Hiss hisss Hiss hissss Hissss hiss Hiss hissssssss +Hiss hisss Hiss hiss Hisss hiss Hiss hissssssss +Hiss hisss Hiss hissss Hisss hissssssss Hiss +hissss Hisss hisss Hiss hissss Hisss hisss +Hiss hissssssss Hiss hisssss Hiss hisss Hiss +hisssss Hiss hisss Hisss hiss Hiss hisssss +Hisss hissss Hiss hiss Hissss hiss Hiss hisssss +Hisss hisssssss Hiss hisss Hiss hiss Hisssss +hissss Hisssssss hisssssss Hiss hisss Hisssss +hiss Hiss hissss Hisssss hiss Hiss hiss Hisss +hiss Hisss hiss Hiss hisss Hisssss hiss Hiss +hiss Hisss hiss Hissss hisss Hiss hiss Hissss +hiss Hiss hisss Hiss hiss Hiss hiss Hiss +hisss Hisss hiss Hissss hisss Hisss hiss +Hisss hiss Hiss hisss Hisssss hiss Hiss hiss +Hisss hiss Hissss hisss Hiss hiss Hissss +hiss Hiss hisss Hiss hiss Hiss hiss Hiss +hisssss Hiss hisss Hiss hisss Hisssss hiss +Hiss hisss Hiss hisss Hiss hiss Hiss hissssssss +Hiss hisss Hisss hiss Hisssss hisss Hiss +hiss Hiss hissssssssss Hiss hissssssss Hiss +hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssss Hiss hisss Hiss +hisss Hisss hissss Hisss hisss Hiss hissss +Hisss hiss Hissssss hiss Hiss hiss Hisss +hissss Hisss hiss Hisssss hiss Hisss hissss +Hiss hisss Hisss hiss Hiss hiss Hiss hisss +Hisss hisssssss Hiss hissss Hissss hiss Hiss +hisss Hiss hiss Hisssss hissssssss Hiss hisssss +Hiss hisss Hiss hisssss Hisss hiss Hisss +hiss Hiss hisss Hiss hiss Hisss hisss Hissss +hiss Hisss hiss Hiss hiss Hiss hisss Hisss +hiss Hisss hiss Hissss hissss Hiss hiss Hiss +hissssssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisssss Hiss hisss Hiss hisss Hisss +hissss Hisss hisss Hiss hissss Hisss hiss +Hissssss hiss Hiss hiss Hisss hisss Hissss +hiss Hisss hissss Hisss hiss Hisssss hiss +Hisss hissss Hisss hiss Hisss hiss Hisssss +hiss Hisss hisss Hissss hiss Hisss hisssssss +Hiss hisss Hiss hiss Hisssss hissssssss Hiss +hisss Hiss hissss Hisss hisss Hisss hiss +Hissss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisss Hiss hiss Hissssss +hisss Hiss hiss Hiss hissssss Hiss hiss Hiss +hissssssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisss +Hiss hisss Hiss hiss Hisss hisss Hisss hisss +Hisss hisssssss Hiss hissssss Hiss hiss Hiss +hisssss Hiss hisss Hiss hisssss Hiss hisss +Hisss hiss Hiss hisssss Hisss hissss Hiss +hiss Hissss hiss Hiss hisssss Hisss hisssssss +Hiss hisss Hiss hiss Hisssss hissss Hisssssss +hisssssss Hiss hisss Hisssss hiss Hiss hissss +Hisssss hiss Hiss hissss Hissss hiss Hiss +hiss Hisss hisss Hissss hisss Hiss hiss Hiss +hiss Hiss hisss Hiss hiss Hissssss hissss +Hissss hiss Hiss hiss Hisss hisss Hissss +hisss Hiss hiss Hiss hiss Hiss hisssss Hiss +hisss Hiss hisss Hisssss hiss Hiss hissssssss +Hiss hissss Hisss hisss Hiss hissss Hisss +hisss Hiss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisssss +Hiss hisss Hiss hisss Hisss hissss Hisss +hisss Hiss hissss Hisss hiss Hissssss hiss +Hiss hissss Hisss hiss Hisss hiss Hiss hisss +Hiss hiss Hisss hisss Hissss hiss Hisss hiss +Hiss hiss Hiss hisss Hisss hisss Hissss hiss +Hisss hiss Hiss hiss Hiss hiss Hissss hiss +Hiss hiss Hisss hiss Hisss hisssssss Hiss +hisss Hiss hiss Hisssss hisss Hiss hiss Hisssss +hissssssss Hiss hisssss Hiss hisss Hiss hissss +Hissss hiss Hiss hissssssss Hiss hisss Hiss +hiss Hisss hiss Hiss hissssssss Hiss hissss +Hiss hisss Hisss hissssssss Hiss hissss Hisss +hisss Hiss hissss Hisss hisss Hiss hissss +Hiss hiss Hiss hissssssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssss Hiss hisss Hiss +hisss Hisss hissss Hisss hisss Hiss hissss +Hisss hiss Hissssss hiss Hiss hiss Hisss +hisss Hissss hiss Hisss hissss Hisss hiss +Hisssss hiss Hisss hissss Hisss hiss Hisss +hiss Hisssss hiss Hisss hisss Hissss hiss +Hisss hiss Hiss hisss Hiss hiss Hiss hissssssss +Hiss hisss Hisss hiss Hisssss hisss Hiss +hiss Hiss hissssss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisssssss +Hissss hisss Hiss hisss Hissss hiss Hiss +hisss Hiss hiss Hisss hisss Hissss hiss Hisss +hissss Hiss hiss Hissss hisssssss Hiss hissss +Hiss hissss Hiss hisss Hisss hisssss Hiss +hiss Hiss hiss Hiss hiss Hissss hisss Hiss +hisss Hissss hissss Hisss hiss Hisss hiss +Hiss hisss Hisssss hisssssss Hiss hissss +Hiss hissss Hisss hisss Hiss hisss Hissss +hiss Hiss hisssss Hisss hiss Hisss hissss +Hisss hiss Hisss hiss Hiss hiss Hisss hiss +Hiss hiss Hiss hisss Hisss hissss Hiss hiss +Hissss hiss Hisss hisss Hissss hisssssss +Hiss hisss Hiss hisssss Hisss hisss Hiss +hisss Hissss hiss Hisssss hiss Hisss hiss +Hiss hiss Hiss hiss Hissss hisss Hissss hiss +Hisss hissss Hiss hisss Hisss hisssssss Hiss +hisss Hisss hisss Hissss hiss Hiss hisss +Hiss hiss Hisss hisss Hissss hiss Hisss hiss +Hissss hisss Hisss hissss Hisss hiss Hisss +hiss Hiss hiss Hiss hisss Hisss hiss Hiss +hiss Hisss hiss Hiss hisssss Hisss hiss Hisss +hiss Hiss hisss Hiss hiss Hisss hisss Hissss +hiss Hisss hiss Hiss hiss Hiss hisss Hisss +hisssssss Hiss hissss Hiss hissss Hisss hiss +Hisssss hiss Hisss hissss Hiss hisss Hisss +hiss Hiss hisss Hisssss hisss Hiss hiss Hissss +hisssss Hissss hiss Hiss hisss Hissss hiss +Hisss hisss Hiss hissss Hiss hisss Hisss +hiss Hissss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisssssss +Hissss hisss Hiss hisss Hissss hiss Hiss +hisss Hiss hiss Hisss hisss Hissss hiss Hisss +hissss Hiss hiss Hissss hisssssss Hiss hissss +Hiss hissss Hiss hisssss Hiss hisss Hiss +hissss Hisss hisss Hisss hiss Hiss hisss +Hiss hiss Hisss hissss Hisss hiss Hisss hiss +Hiss hiss Hiss hisss Hisss hisss Hiss hiss +Hissss hisssss Hiss hisss Hiss hisss Hisss +hissss Hisss hisss Hiss hissss Hisss hiss +Hissssss hiss Hiss hissss Hisss hiss Hisss +hiss Hiss hisss Hiss hiss Hisss hisss Hissss +hiss Hisss hiss Hiss hiss Hiss hisss Hisss +hisss Hissss hiss Hisss hiss Hiss hiss Hiss +hiss Hissss hiss Hiss hiss Hisss hiss Hisss +hiss Hiss hiss Hisss hiss Hiss hisssss Hiss +hisss Hiss hissss Hissss hiss Hiss hissss +Hiss hiss Hissss hisssss Hissss hiss Hiss +hisss Hissss hiss Hisss hissss Hiss hisss +Hiss hisss Hisss hissss Hisss hisss Hiss +hissss Hisss hiss Hissssss hiss Hiss hiss +Hisss hissss Hisss hiss Hisssss hiss Hisss +hissss Hiss hisss Hisss hiss Hiss hiss Hiss +hisss Hisss hissss Hiss hisss Hiss hisssss +Hisss hiss Hisss hiss Hiss hisss Hiss hiss +Hisss hisss Hissss hiss Hisss hiss Hiss hiss +Hiss hisss Hisss hisss Hiss hissss Hiss hisss +Hisss hiss Hissss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisssss +Hiss hisss Hiss hissss Hiss hisss Hissss +hiss Hiss hiss Hiss hisss Hisss hissss Hiss +hiss Hissss hisssssss Hiss hisss Hiss hiss +Hisssss hissssssss Hiss hisss Hiss hissss +Hisss hisss Hisss hiss Hissss hissss Hiss +hiss Hiss hissssss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisss +Hisss hissss Hiss hissssssss Hiss hisssss +Hiss hiss Hiss hiss Hiss hisssss Hiss hiss +Hisss hiss Hiss hiss Hiss hisss Hisss hisss +Hiss hisss Hissss hiss Hiss hiss Hiss hisss +Hisss hisssssss Hiss hisss Hissssss hiss +Hiss hiss Hisss hisss Hissss hisssss Hiss +hiss Hisss hiss Hisssss hiss Hisss hiss Hiss +hiss Hiss hiss Hissss hissss Hisss hiss Hisss +hissss Hiss hisss Hisss hiss Hissssss hiss +Hiss hisssssss Hiss hissss Hiss hissss Hisss +hiss Hiss hiss Hiss hisss Hisss hisssssss +Hiss hissss Hissss hiss Hisss hiss Hisssss +hiss Hisss hisssssss Hiss hissss Hissss hiss +Hisss hiss Hiss hiss Hiss hisss Hisss hiss +Hiss hiss Hiss hisss Hisss hissss Hiss hisss +Hisss hisssssss Hiss hisssss Hiss hiss Hissss +hiss Hisssss hiss Hisss hisssssss Hiss hissss +Hiss hisss Hissss hiss Hiss hiss Hiss hisss +Hisss hiss Hisss hisss Hissss hiss Hiss hiss +Hiss hisss Hisss hissss Hiss hiss Hissss +hisssssss Hiss hisssss Hiss hiss Hissss hisssss +Hiss hiss Hisss hiss Hiss hiss Hiss hisss +Hisss hisssssss Hiss hissss Hisss hiss Hissss +hiss Hiss hisssss Hisss hissss Hisss hiss +Hisss hiss Hiss hiss Hiss hiss Hissss hiss +Hiss hiss Hiss hisss Hisss hiss Hisss hisss +Hissss hiss Hisss hiss Hissss hissssssss +Hiss hissss Hiss hissss Hisss hiss Hiss hiss +Hiss hiss Hissss hissss Hiss hiss Hissss +hisssssss Hiss hisssss Hiss hiss Hissss hiss +Hisssss hiss Hisss hisss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisss +Hisss hissss Hiss hissssssss Hiss hisss Hisss +hiss Hiss hiss Hisss hiss Hiss hiss Hiss +hisss Hisss hiss Hiss hiss Hiss hisss Hisss +hissssss Hissss hisssssss Hiss hisss Hiss +hiss Hisss hiss Hisss hiss Hiss hisss Hisssss +hisssssss Hiss hisss Hiss hisss Hiss hiss +Hisss hisss Hissss hiss Hisss hisss Hissss +hiss Hisss hiss Hiss hiss Hiss hisss Hisss +hisss Hiss hisss Hissss hisssssss Hiss hisssssss +Hissss hiss Hiss hiss Hiss hisss Hisss hiss +Hiss hisssss Hisss hiss Hisss hissss Hisss +hiss Hiss hiss Hiss hisss Hisss hisss Hissss +hiss Hiss hissss Hissss hiss Hiss hissss +Hissss hiss Hiss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisssss +Hiss hisss Hiss hisss Hisss hissss Hisss +hisss Hiss hissss Hisss hiss Hissssss hiss +Hiss hissss Hisss hiss Hisss hiss Hiss hisss +Hiss hiss Hisss hisss Hissss hiss Hisss hiss +Hiss hiss Hiss hisss Hisss hisss Hissss hiss +Hisss hiss Hiss hiss Hiss hiss Hissss hiss +Hiss hiss Hisss hiss Hisss hisssssss Hiss +hisss Hiss hiss Hisssss hissssssss Hiss hisssssss +Hisss hisss Hisss hiss Hissss hissss Hiss +hiss Hiss hissssssssss Hiss hissssssss Hiss +hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hisssss Hiss hisss Hiss +hisss Hisss hissss Hisss hisss Hiss hissss +Hisss hiss Hissssss hiss Hiss hiss Hisss +hisss Hissss hiss Hisss hissss Hisss hiss +Hisssss hiss Hisss hissss Hisss hiss Hisss +hiss Hisssss hiss Hisss hisss Hissss hiss +Hisss hisssssss Hiss hisss Hiss hiss Hisssss +hissssssss Hiss hisssssss Hisss hisss Hisss +hiss Hissss hissss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisssss +Hiss hisss Hiss hisss Hisss hissss Hisss +hisss Hiss hissss Hisss hiss Hissssss hiss +Hiss hiss Hisss hissss Hisss hiss Hisssss +hiss Hisss hissss Hiss hisss Hisss hiss Hiss +hiss Hiss hisss Hisss hisssssss Hiss hisss +Hiss hiss Hisssss hissssssss Hiss hissss +Hiss hissss Hiss hissss Hiss hissss Hiss +hisss Hisss hiss Hissss hissss Hiss hiss +Hiss hissssssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hissssssss Hiss hissssssss Hiss hisss +Hiss hiss Hissssss hisss Hiss hiss Hiss hissssssssss +Hiss hissssssss Hiss hissssssss Hiss hissssssss +Hiss hisss Hiss hiss Hissssss hisss Hiss +hiss Hiss hissssssssss Hiss hissssssss Hiss +hissssssss Hiss hissssssss Hiss hisss Hisss +hissss Hisss hissss Hisss hiss Hisss hiss +Hisssss hiss Hisss hiss Hisss hisss Hissss +hiss Hiss hiss Hiss hisss Hisss hisssssss +Hiss hissss Hisss hissss Hiss hiss Hiss hisss +Hiss hisss Hiss hissss Hisss hisss Hiss hiss +Hiss hiss Hiss hissss Hiss hiss Hisss hiss +Hissss hissss Hiss hiss Hiss hisssss Hiss +hiss Hissssss hisss Hiss hiss Hiss hissssss +Hiss hiss Hiss hisssss Hiss hiss Hiss hisss +Hisss hisssss Hisssss hiss Hiss hisss Hiss +hiss Hisss hissss Hiss hiss Hissss hisssssss +Hiss hisssss Hiss hisss Hiss hissss Hiss +hisss Hissss hiss Hiss hiss Hiss hisss Hisss +hissss Hiss hiss Hissss hiss Hisss hiss Hissss +hissss Hiss hiss Hiss hisssss \ No newline at end of file diff --git a/cfg.mk b/cfg.mk index 9ba2134..3c5b4a9 100644 --- a/cfg.mk +++ b/cfg.mk @@ -1114,7 +1114,7 @@ exclude_file_name_regexp--sc_prohibit_close = \ (\.p[yl]$$|\.spec\.in$$|^docs/|^(src/util/virfile\.c|src/libvirt-stream\.c|tests/vir(cgroup|pci)mock\.c)$$) exclude_file_name_regexp--sc_prohibit_empty_lines_at_EOF = \ - (^tests/(qemuhelp|nodeinfo|virpcitest)data/|\.diff$$) + (^tests/(qemuhelp|nodeinfo|virpcitest)data/|\.diff$$|build-aux/bracket-spacing.pl) _src2=src/(util/vircommand|libvirt|lxc/lxc_controller|locking/lock_daemon) exclude_file_name_regexp--sc_prohibit_fork_wrappers = \ @@ -1159,7 +1159,7 @@ exclude_file_name_regexp--sc_require_config_h_first = \ ^(examples/|tools/virsh-edit\.c$$) exclude_file_name_regexp--sc_trailing_blank = \ - /qemuhelpdata/|/sysinfodata/.*\.data|/nodeinfodata/.*\.cpuinfo$$ + /qemuhelpdata/|/sysinfodata/.*\.data|/nodeinfodata/.*\.cpuinfo$$|build-aux/bracket-spacing.pl exclude_file_name_regexp--sc_unmarked_diagnostics = \ ^(docs/apibuild.py|tests/virt-aa-helper-test)$$ -- 2.1.0

3 2

[libvirt] [PATCHv2] iscsi: do not fail to stop a stopped pool
by Ján Tomko 30 Apr '15

30 Apr '15

Just as we allow stopping filesystem pools when they were unmounted externally, do not fail to stop an iscsi pool when someone else closed the session externally. Reported at: https://bugzilla.redhat.com/show_bug.cgi?id=1171984 --- v2: Do not report errors when returning success (use probe=true) refrain from making controversial claims in the commit message src/storage/storage_backend_iscsi.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/storage/storage_backend_iscsi.c b/src/storage/storage_backend_iscsi.c index 197d333..9e2d01e 100644 --- a/src/storage/storage_backend_iscsi.c +++ b/src/storage/storage_backend_iscsi.c @@ -449,8 +449,13 @@ virStorageBackendISCSIStopPool(virConnectPtr conn ATTRIBUTE_UNUSED, virStoragePoolObjPtr pool) { char *portal; + char *session; int ret = -1; + if ((session = virStorageBackendISCSISession(pool, true)) == NULL) + return 0; + VIR_FREE(session); + if ((portal = virStorageBackendISCSIPortal(&pool->def->source)) == NULL) return -1; -- 2.0.5

2 2

[libvirt] [PATCH] polkit: Allow password-less access for 'libvirt' group
by Cole Robinson 30 Apr '15

30 Apr '15

Many users, who admin their own machines, want to be able to access system libvirtd via tools like virt-manager without having to enter a root password. Just google 'virt-manager without password' and you'll find many hits. I've read at least 5 blog posts over the years describing slightly different ways of achieving this goal. Let's finally add official support for this. Install a polkit-1 rules file granting password-less auth for any user in the new 'libvirt' group. Create the group on RPM install https://bugzilla.redhat.com/show_bug.cgi?id=957300 --- daemon/50-libvirt.rules | 9 +++++++++ daemon/Makefile.am | 13 +++++++++++++ libvirt.spec.in | 15 +++++++++++++-- 3 files changed, 35 insertions(+), 2 deletions(-) create mode 100644 daemon/50-libvirt.rules diff --git a/daemon/50-libvirt.rules b/daemon/50-libvirt.rules new file mode 100644 index 0000000..01a15fa --- /dev/null +++ b/daemon/50-libvirt.rules @@ -0,0 +1,9 @@ +// Allow any user in the 'libvirt' group to connect to system libvirtd +// without entering a password. + +polkit.addRule(function(action, subject) { + if (action.id == "org.libvirt.unix.manage" && + subject.isInGroup("libvirt")) { + return polkit.Result.YES; + } +}); diff --git a/daemon/Makefile.am b/daemon/Makefile.am index 300b9a5..e200ac1 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -53,6 +53,7 @@ EXTRA_DIST = \ libvirtd.init.in \ libvirtd.upstart \ libvirtd.policy.in \ + 50-libvirt.rules \ libvirtd.sasl \ libvirtd.service.in \ libvirtd.socket.in \ @@ -233,6 +234,8 @@ policyauth = auth_admin_keep_session else ! WITH_POLKIT0 policydir = $(datadir)/polkit-1/actions policyauth = auth_admin_keep +rulesdir = $(datadir)/polkit-1/rules.d +rulesfile = 50-libvirt.rules endif ! WITH_POLKIT0 endif WITH_POLKIT @@ -263,9 +266,19 @@ if WITH_POLKIT install-data-polkit:: $(MKDIR_P) $(DESTDIR)$(policydir) $(INSTALL_DATA) libvirtd.policy $(DESTDIR)$(policydir)/org.libvirt.unix.policy +if ! WITH_POLKIT0 + $(MKDIR_P) $(DESTDIR)$(rulesdir) + $(INSTALL_DATA) $(srcdir)/$(rulesfile) $(DESTDIR)$(rulesdir) +endif ! WITH_POLKIT0 + uninstall-data-polkit:: rm -f $(DESTDIR)$(policydir)/org.libvirt.unix.policy rmdir $(DESTDIR)$(policydir) || : +if ! WITH_POLKIT0 + rm -f $(DESTDIR)$(rulesdir)/$(rulesfile) + rmdir $(DESTDIR)$(rulesdir) +endif ! WITH_POLKIT0 + else ! WITH_POLKIT install-data-polkit:: uninstall-data-polkit:: diff --git a/libvirt.spec.in b/libvirt.spec.in index 20af502..c71ef25 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1645,9 +1645,9 @@ then fi %if %{with_libvirtd} +%pre daemon %if ! %{with_driver_modules} %if %{with_qemu} -%pre daemon %if 0%{?fedora} || 0%{?rhel} >= 6 # We want soft static allocation of well-known ids, as disk images # are commonly shared across NFS mounts by id rather than name; see @@ -1661,11 +1661,21 @@ if ! getent passwd qemu >/dev/null; then useradd -r -g qemu -G kvm -d / -s /sbin/nologin -c "qemu user" qemu fi fi -exit 0 %endif %endif %endif + %if %{with_polkit} + %if 0%{?fedora} || 0%{?rhel} >= 6 +# 'libvirt' group is just to allow password-less polkit access to +# libvirtd. The uid number is irrelevant, so we use dynamic allocation +# described at the above link. +getent group libvirt >/dev/null || groupadd -r libvirt + %endif + %endif + +exit 0 + %post daemon %if %{with_systemd} @@ -1939,6 +1949,7 @@ exit 0 %if 0%{?fedora} || 0%{?rhel} >= 6 %{_datadir}/polkit-1/actions/org.libvirt.unix.policy %{_datadir}/polkit-1/actions/org.libvirt.api.policy +%{_datadir}/polkit-1/rules.d/50-libvirt.rules %else %{_datadir}/PolicyKit/policy/org.libvirt.unix.policy %endif -- 2.3.6

5 7

[libvirt] [PATCH] qemu: Unlock NW filter lock earlier when not necessary
by Erik Skultety 30 Apr '15

30 Apr '15

The lock is dropped always at the end of an API, but for example when attaching devices, there's no point in having the NW filter locked if the device being attached isn't a network interface. It's always a nice practice to drop unnecessary locks as soon as possible. --- src/qemu/qemu_driver.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) BZ 1181074 reported the daemon to hang (not completely true btw) after trying to attach /dev/ttyX to a running domain. When going through the code I realized we acquire a read lock for NW filter, although the device itself is not a network interface and then releasing it at the end. First clue was that this lock which won't be unlocked as the thread is blocked in reading header of /dev/ttyX causes the freeze. As it turned out, the problem resides in calling virsh list afterwards (Peter already does have some patches prepared), but I think the NW filter might be released earlier in this case with no harm done. diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 74dcb0a..04887e0 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -8764,6 +8764,7 @@ static int qemuDomainAttachDeviceFlags(virDomainPtr dom, const char *xml, virDomainDeviceDefPtr dev = NULL, dev_copy = NULL; int ret = -1; unsigned int affect, parse_flags = VIR_DOMAIN_DEF_PARSE_INACTIVE; + bool nwfilter_locked = false; virQEMUCapsPtr qemuCaps = NULL; qemuDomainObjPrivatePtr priv; virQEMUDriverConfigPtr cfg = NULL; @@ -8773,6 +8774,7 @@ static int qemuDomainAttachDeviceFlags(virDomainPtr dom, const char *xml, VIR_DOMAIN_AFFECT_CONFIG, -1); virNWFilterReadLockFilterUpdates(); + nwfilter_locked = true; cfg = virQEMUDriverGetConfig(driver); @@ -8819,6 +8821,11 @@ static int qemuDomainAttachDeviceFlags(virDomainPtr dom, const char *xml, if (dev == NULL) goto endjob; + if (dev->type != VIR_DOMAIN_DEVICE_NET) { + virNWFilterUnlockFilterUpdates(); + nwfilter_locked = false; + } + if (flags & VIR_DOMAIN_AFFECT_CONFIG && flags & VIR_DOMAIN_AFFECT_LIVE) { /* If we are affecting both CONFIG and LIVE @@ -8884,11 +8891,12 @@ static int qemuDomainAttachDeviceFlags(virDomainPtr dom, const char *xml, virDomainDefFree(vmdef); if (dev != dev_copy) virDomainDeviceDefFree(dev_copy); + if (nwfilter_locked) + virNWFilterUnlockFilterUpdates(); virDomainDeviceDefFree(dev); virDomainObjEndAPI(&vm); virObjectUnref(caps); virObjectUnref(cfg); - virNWFilterUnlockFilterUpdates(); return ret; } @@ -8908,6 +8916,7 @@ static int qemuDomainUpdateDeviceFlags(virDomainPtr dom, virDomainDefPtr vmdef = NULL; virDomainDeviceDefPtr dev = NULL, dev_copy = NULL; bool force = (flags & VIR_DOMAIN_DEVICE_MODIFY_FORCE) != 0; + bool nwfilter_locked = false; int ret = -1; unsigned int affect; virQEMUCapsPtr qemuCaps = NULL; @@ -8920,6 +8929,7 @@ static int qemuDomainUpdateDeviceFlags(virDomainPtr dom, VIR_DOMAIN_DEVICE_MODIFY_FORCE, -1); virNWFilterReadLockFilterUpdates(); + nwfilter_locked = true; cfg = virQEMUDriverGetConfig(driver); @@ -8966,6 +8976,11 @@ static int qemuDomainUpdateDeviceFlags(virDomainPtr dom, if (dev == NULL) goto endjob; + if (dev->type != VIR_DOMAIN_DEVICE_NET) { + virNWFilterUnlockFilterUpdates(); + nwfilter_locked = false; + } + if (flags & VIR_DOMAIN_AFFECT_CONFIG && flags & VIR_DOMAIN_AFFECT_LIVE) { /* If we are affecting both CONFIG and LIVE @@ -9031,11 +9046,12 @@ static int qemuDomainUpdateDeviceFlags(virDomainPtr dom, virDomainDefFree(vmdef); if (dev != dev_copy) virDomainDeviceDefFree(dev_copy); + if (nwfilter_locked) + virNWFilterUnlockFilterUpdates(); virDomainDeviceDefFree(dev); virDomainObjEndAPI(&vm); virObjectUnref(caps); virObjectUnref(cfg); - virNWFilterUnlockFilterUpdates(); return ret; } -- 1.9.3

3 2

[libvirt] [PATCH 0/2] Introduce GIC for aarch64
by Michal Privoznik 30 Apr '15

30 Apr '15

There's no APIC on aarch64. It's replaced by GIC (Generic Interrupt Controller). Michal Privoznik (2): Introduce GIC feature qemu: Implement GIC docs/formatdomain.html.in | 9 ++++++ docs/schemas/domaincommon.rng | 11 ++++++- src/conf/domain_conf.c | 34 +++++++++++++++++++++- src/conf/domain_conf.h | 2 ++ src/qemu/qemu_command.c | 13 +++++++++ .../qemuxml2argvdata/qemuxml2argv-aarch64-gic.args | 6 ++++ .../qemuxml2argvdata/qemuxml2argv-aarch64-gic.xml | 26 +++++++++++++++++ tests/qemuxml2argvtest.c | 2 ++ 8 files changed, 101 insertions(+), 2 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic.xml -- 2.0.5

2 6

[libvirt] [PATCH 0/2] Don't rely on cached topology information
by Andrea Bolognani 30 Apr '15

30 Apr '15

Currently, if CPUs are brought online or offline during the lifetime of a libvirtd instance, the output of commands such as `virsh capabilities' will not reflect the actual topology, eg. displaying empty <cpu> tags for CPUs that have been brought offline and not displaying at all CPUs that have been brought online. This happens because the list of CPUs in a node is queried using libnuma, which maintains its internal cache. This patch changes the code so that the required information is extracted from sysfs instead, making the data displayed to the user always fresh. Andrea Bolognani (2): nodeinfo: Export nodeGetCPUValue() after renaming it. numa: Rewrite virNumaGetNodeCPUs() to query CPUs dynamically. src/libvirt_private.syms | 1 + src/nodeinfo.c | 28 +++++---- src/nodeinfo.h | 6 +- src/util/virnuma.c | 158 ++++++++++++++++++++++++----------------------- 4 files changed, 102 insertions(+), 91 deletions(-) -- 2.1.0

3 6

[libvirt] [PATCH] qemu: Make sure permissions are set on VNC auto socket
by Cole Robinson 30 Apr '15

30 Apr '15

This can cause permissions failures if qemu.conf user/group is changed. Fix this by filling in the VNC auto socket path in the same code area that we fill in default listen address, ports, etc. https://bugzilla.redhat.com/show_bug.cgi?id=1151762 --- src/qemu/qemu_command.c | 10 ++-------- src/qemu/qemu_process.c | 11 ++++++++++- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index ba15dc9..45fc63c 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -7544,7 +7544,6 @@ qemuBuildNumaArgStr(virQEMUDriverConfigPtr cfg, static int qemuBuildGraphicsVNCCommandLine(virQEMUDriverConfigPtr cfg, virCommandPtr cmd, - virDomainDefPtr def, virQEMUCapsPtr qemuCaps, virDomainGraphicsDefPtr graphics) { @@ -7561,12 +7560,7 @@ qemuBuildGraphicsVNCCommandLine(virQEMUDriverConfigPtr cfg, goto error; } - if (graphics->data.vnc.socket || cfg->vncAutoUnixSocket) { - if (!graphics->data.vnc.socket && - virAsprintf(&graphics->data.vnc.socket, - "%s/%s.vnc", cfg->libDir, def->name) == -1) - goto error; - + if (graphics->data.vnc.socket) { virBufferAsprintf(&opt, "unix:%s", graphics->data.vnc.socket); } else if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_VNC_COLON)) { @@ -7944,7 +7938,7 @@ qemuBuildGraphicsCommandLine(virQEMUDriverConfigPtr cfg, break; case VIR_DOMAIN_GRAPHICS_TYPE_VNC: - return qemuBuildGraphicsVNCCommandLine(cfg, cmd, def, qemuCaps, graphics); + return qemuBuildGraphicsVNCCommandLine(cfg, cmd, qemuCaps, graphics); case VIR_DOMAIN_GRAPHICS_TYPE_SPICE: return qemuBuildGraphicsSPICECommandLine(cfg, cmd, qemuCaps, graphics); diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 605b3c6..5de46e2 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -4479,7 +4479,16 @@ int qemuProcessStart(virConnectPtr conn, goto cleanup; } - if (graphics->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC || + if (graphics->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC && + !graphics->data.vnc.socket && + cfg->vncAutoUnixSocket) { + if (virAsprintf(&graphics->data.vnc.socket, + "%s/%s.vnc", cfg->libDir, vm->def->name) < 0) + goto cleanup; + } + + if ((graphics->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC && + !graphics->data.vnc.socket) || graphics->type == VIR_DOMAIN_GRAPHICS_TYPE_SPICE) { if (graphics->nListens == 0) { if (VIR_EXPAND_N(graphics->listens, graphics->nListens, 1) < 0) -- 2.3.6

2 3

[libvirt] [PATCH v2] polkit: Allow password-less access for 'libvirtadm' group
by Cole Robinson 29 Apr '15

29 Apr '15

Many users, who admin their own machines, want to be able to access system libvirtd via tools like virt-manager without having to enter a root password. Just google 'virt-manager without password' and you'll find many hits. I've read at least 5 blog posts over the years describing slightly different ways of achieving this goal. Let's finally add official support for this. Install a polkit-1 rules file granting password-less auth for any user in the new 'libvirtadm' group. Create the group on RPM install https://bugzilla.redhat.com/show_bug.cgi?id=957300 --- v2: - Name the group libvirtadm (danpb) - Name the source file libvirt.rules and rename on install (eblake) daemon/Makefile.am | 13 +++++++++++++ daemon/libvirt.rules | 9 +++++++++ libvirt.spec.in | 15 +++++++++++++-- 3 files changed, 35 insertions(+), 2 deletions(-) create mode 100644 daemon/libvirt.rules diff --git a/daemon/Makefile.am b/daemon/Makefile.am index 300b9a5..974feed 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -53,6 +53,7 @@ EXTRA_DIST = \ libvirtd.init.in \ libvirtd.upstart \ libvirtd.policy.in \ + libvirt.rules \ libvirtd.sasl \ libvirtd.service.in \ libvirtd.socket.in \ @@ -233,6 +234,8 @@ policyauth = auth_admin_keep_session else ! WITH_POLKIT0 policydir = $(datadir)/polkit-1/actions policyauth = auth_admin_keep +rulesdir = $(datadir)/polkit-1/rules.d +rulesfile = libvirt.rules endif ! WITH_POLKIT0 endif WITH_POLKIT @@ -263,9 +266,19 @@ if WITH_POLKIT install-data-polkit:: $(MKDIR_P) $(DESTDIR)$(policydir) $(INSTALL_DATA) libvirtd.policy $(DESTDIR)$(policydir)/org.libvirt.unix.policy +if ! WITH_POLKIT0 + $(MKDIR_P) $(DESTDIR)$(rulesdir) + $(INSTALL_DATA) $(srcdir)/$(rulesfile) $(DESTDIR)$(rulesdir)/50-libvirt.rules +endif ! WITH_POLKIT0 + uninstall-data-polkit:: rm -f $(DESTDIR)$(policydir)/org.libvirt.unix.policy rmdir $(DESTDIR)$(policydir) || : +if ! WITH_POLKIT0 + rm -f $(DESTDIR)$(rulesdir)/50-libvirt.rules + rmdir $(DESTDIR)$(rulesdir) || : +endif ! WITH_POLKIT0 + else ! WITH_POLKIT install-data-polkit:: uninstall-data-polkit:: diff --git a/daemon/libvirt.rules b/daemon/libvirt.rules new file mode 100644 index 0000000..e70c09b --- /dev/null +++ b/daemon/libvirt.rules @@ -0,0 +1,9 @@ +// Allow any user in the 'libvirtadm' group to connect to system libvirtd +// without entering a password. + +polkit.addRule(function(action, subject) { + if (action.id == "org.libvirt.unix.manage" && + subject.isInGroup("libvirtadm")) { + return polkit.Result.YES; + } +}); diff --git a/libvirt.spec.in b/libvirt.spec.in index 20af502..10a28a2 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1645,9 +1645,9 @@ then fi %if %{with_libvirtd} +%pre daemon %if ! %{with_driver_modules} %if %{with_qemu} -%pre daemon %if 0%{?fedora} || 0%{?rhel} >= 6 # We want soft static allocation of well-known ids, as disk images # are commonly shared across NFS mounts by id rather than name; see @@ -1661,11 +1661,21 @@ if ! getent passwd qemu >/dev/null; then useradd -r -g qemu -G kvm -d / -s /sbin/nologin -c "qemu user" qemu fi fi -exit 0 %endif %endif %endif + %if %{with_polkit} + %if 0%{?fedora} || 0%{?rhel} >= 6 +# 'libvirtadm' group is just to allow password-less polkit access to +# libvirtd. The uid number is irrelevant, so we use dynamic allocation +# described at the above link. +getent group libvirtadm >/dev/null || groupadd -r libvirtadm + %endif + %endif + +exit 0 + %post daemon %if %{with_systemd} @@ -1939,6 +1949,7 @@ exit 0 %if 0%{?fedora} || 0%{?rhel} >= 6 %{_datadir}/polkit-1/actions/org.libvirt.unix.policy %{_datadir}/polkit-1/actions/org.libvirt.api.policy +%{_datadir}/polkit-1/rules.d/50-libvirt.rules %else %{_datadir}/PolicyKit/policy/org.libvirt.unix.policy %endif -- 2.3.6

3 5

[libvirt] [PATCH v2 0/7] Cleanup flags checking and fix setvcpus
by Pavel Hrdina 29 Apr '15

29 Apr '15

The first four patches only cleanup the flags checking in our APIs by introducing new macros to check exclusive flags and requirements. Patch 5/7 uses the new macros to do better flags checking for virDomainSetvcpusFlags API. Patch 6/7 introduces macro to check virsh options requirements. The last patch uses the requirement macro to cleanup virsh setvcpus code and fixes a bug with --maximum option. Because only the last patch actually fixes a bug issue, I'm not sure whether this patch series should wait for next release cycle. Luyao Huang (1): tools: fix the wrong check when use virsh setvcpus --maximum Pavel Hrdina (6): internal: introduce macro helpers to reject exclusive flags internal: introduce macro helpers to check flag requirements use new macro helpers to check exclusive flags use new macro helpers to check flag requirements qemu: use new macros for setvcpus to check flags and cleanup the code virsh: introduce new macros to help check flag requirements src/internal.h | 87 +++++++++++ src/libvirt-domain-snapshot.c | 56 +++----- src/libvirt-domain.c | 286 +++++++++++-------------------------- src/qemu/qemu_driver.c | 33 +---- src/storage/storage_backend_disk.c | 10 +- src/storage/storage_backend_fs.c | 11 +- tools/virsh-domain.c | 30 +--- tools/virsh.h | 52 +++++++ 8 files changed, 256 insertions(+), 309 deletions(-) -- 2.0.5

3 14

[libvirt] [python PATCH] examples: Add example to make guest agent lifecycle event useful
by Peter Krempa 29 Apr '15

29 Apr '15

This example allows to use the guest agent event and metadata to track vCPU count set via the guest agent (agent-based onlining/offlining) and keep it persistent accross domain restarts. The daemon listens for the agent lifecycle event, and if it's received it looks into doman's metadata to see whether a desired count was set and issues the guest agent command. --- MANIFEST.in | 2 + examples/README | 2 + examples/guest-vcpus/guest-vcpu-daemon.py | 131 ++++++++++++++++++++++++++++++ examples/guest-vcpus/guest-vcpu.py | 76 +++++++++++++++++ 4 files changed, 211 insertions(+) create mode 100755 examples/guest-vcpus/guest-vcpu-daemon.py create mode 100755 examples/guest-vcpus/guest-vcpu.py diff --git a/MANIFEST.in b/MANIFEST.in index dd05221..2cd1b46 100644 --- a/MANIFEST.in +++ b/MANIFEST.in @@ -11,6 +11,8 @@ include examples/domsave.py include examples/domstart.py include examples/esxlist.py include examples/event-test.py +include examples/guest-vcpus/guest-vcpu-daemon.py +include examples/guest-vcpus/guest-vcpu.py include examples/topology.py include generator.py include libvirt-lxc-override-api.xml diff --git a/examples/README b/examples/README index 1d4b425..0cb4513 100644 --- a/examples/README +++ b/examples/README @@ -12,6 +12,8 @@ esxlist.py - list active domains of an VMware ESX host and print some info. also demonstrates how to use the libvirt.openAuth() method dhcpleases.py - list dhcp leases for a given virtual network domipaddrs.py - list IP addresses for guest domains +guest-vcpus - two helpers to make the guest agent event useful with agent based + vCPU state modification The XML files in this directory are examples of the XML format that libvirt expects, and will have to be adapted for your setup. They are only needed diff --git a/examples/guest-vcpus/guest-vcpu-daemon.py b/examples/guest-vcpus/guest-vcpu-daemon.py new file mode 100755 index 0000000..e5a389e --- /dev/null +++ b/examples/guest-vcpus/guest-vcpu-daemon.py @@ -0,0 +1,131 @@ +#!/usr/bin/env python + +import libvirt +import threading +from xml.dom import minidom +import time + +uri = "qemu:///system" +customXMLuri = "guest-cpu.python.libvirt.org" +connectRetryTimeout = 5 + +class workerData: + def __init__(self): + self.doms = list() + self.conn = None + self.cond = threading.Condition() + + def notify(self): + self.cond.acquire() + self.cond.notify() + self.cond.release() + + def waitNotify(self): + self.cond.acquire() + self.cond.wait() + self.cond.release() + + def addDomainNotify(self, dom): + self.doms.append(dom) + self.notify() + + def closeConnectNotify(self): + conn = self.conn + self.conn = None + conn.close() + self.notify() + + def setConnect(self, conn): + self.conn = conn + + def hasConn(self): + return self.conn is not None + + def hasDom(self): + return len(self.doms) > 0 + + def getDom(self): + return self.doms.pop() + + def setDoms(self, doms): + self.doms = doms + + +def virEventLoopNativeRun(): + while True: + libvirt.virEventRunDefaultImpl() + +def handleAgentLifecycleEvent(conn, dom, state, reason, opaque): + if state == libvirt.VIR_CONNECT_DOMAIN_EVENT_AGENT_LIFECYCLE_STATE_CONNECTED: + opaque.addDomainNotify(dom) + +def handleConnectClose(conn, reason, opaque): + print('Disconnected from ' + uri) + opaque.closeConnectNotify() + +def handleLibvirtLibraryError(opaque, error): + pass + +def processAgentConnect(dom): + try: + cpus = dom.metadata(libvirt.VIR_DOMAIN_METADATA_ELEMENT, customXMLuri, + libvirt.VIR_DOMAIN_AFFECT_LIVE) + doc = minidom.parseString(cpus) + ncpus = int(doc.getElementsByTagName('ncpus')[0].getAttribute('count')) + except: + return + + try: + dom.setVcpusFlags(ncpus, libvirt.VIR_DOMAIN_AFFECT_LIVE | libvirt.VIR_DOMAIN_VCPU_GUEST) + print("seting vcpus for domain " + dom.name() + " count " + str(ncpus)) + except: + print("failed to set vcpu count for domain " + dom.name()) + +def work(): + data = workerData() + + print("Using uri: " + uri) + + while True: + if not data.hasConn(): + try: + conn = libvirt.open(uri) + except: + print('Failed to connect to ' + uri + ' Retry in ' + str(connectRetryTimeout)) + ' seconds' + time.sleep(connectRetryTimeout) + continue + + print('Connected to ' + uri) + + data.setConnect(conn) + conn.registerCloseCallback(handleConnectClose, data) + conn.setKeepAlive(5, 3) + conn.domainEventRegisterAny(None, + libvirt.VIR_DOMAIN_EVENT_ID_AGENT_LIFECYCLE, + handleAgentLifecycleEvent, + data) + + data.setDoms(conn.listAllDomains(libvirt.VIR_CONNECT_LIST_DOMAINS_ACTIVE)) + + while data.hasConn() and data.hasDom(): + processAgentConnect(data.getDom()) + + data.waitNotify() + +def main(): + libvirt.virEventRegisterDefaultImpl() + libvirt.registerErrorHandler(handleLibvirtLibraryError, None) + + worker = threading.Thread(target=work) + worker.setDaemon(True) + worker.start() + + eventLoop = threading.Thread(target=virEventLoopNativeRun) + eventLoop.setDaemon(True) + eventLoop.start() + + while True: + time.sleep(1) + +if __name__ == "__main__": + main() diff --git a/examples/guest-vcpus/guest-vcpu.py b/examples/guest-vcpus/guest-vcpu.py new file mode 100755 index 0000000..965b09c --- /dev/null +++ b/examples/guest-vcpus/guest-vcpu.py @@ -0,0 +1,76 @@ +#!/usr/bin/env python + +import libvirt +import sys +import getopt +import os + +customXMLuri = "guest-cpu.python.libvirt.org" + +def usage(): + print("usage: "+os.path.basename(sys.argv[0])+" [-hcl] domain count [uri]") + print(" uri will default to qemu:///system") + print(" --help, -h Print(this help message") + print(" --config, -c Modify persistent domain configuration") + print(" --live, -l Modify live domain configuration") + print("") + print("Sets the vCPU count via the guest agent and sets the metadata element " + + "used by guest-vcpu-daemon.py example") + +uri = "qemu:///system" +flags = 0 +live = False; +config = False; + +try: + opts, args = getopt.getopt(sys.argv[1:], "hcl", ["help", "config", "live"]) +except getopt.GetoptError as err: + # print help information and exit: + print(str(err)) # will print something like "option -a not recognized" + usage() + sys.exit(2) +for o, a in opts: + if o in ("-h", "--help"): + usage() + sys.exit() + if o in ("-c", "--config"): + config = True + flags |= libvirt.VIR_DOMAIN_AFFECT_CONFIG + + if o in ("-l", "--live"): + live = True + flags |= libvirt.VIR_DOMAIN_AFFECT_LIVE + +if len(args) < 2: + usage() + sys.exit(1) +elif len(args) >= 3: + uri = args[2] + +domain = args[0] +count = int(args[1]) + +conn = libvirt.open(uri) +dom = conn.lookupByName(domain) + +if flags == 0 or config: + confvcpus = dom.vcpusFlags(libvirt.VIR_DOMAIN_AFFECT_CONFIG) + + if confvcpus < count: + print("Persistent domain configuration has only " + str(confvcpus) + " vcpus configured") + sys.exit(1) + +if flags == 0 or live: + livevcpus = dom.vcpusFlags(libvirt.VIR_DOMAIN_AFFECT_LIVE) + + if livevcpus < count: + print("Live domain configuration has only " + str(livevcpus) + " vcpus configured") + sys.exit(1) + + +if flags == 0 or live: + dom.setVcpusFlags(count, libvirt.VIR_DOMAIN_AFFECT_LIVE | libvirt.VIR_DOMAIN_VCPU_GUEST) + +meta = "<ncpus count='" + str(count) + "'/>" + +dom.setMetadata(libvirt.VIR_DOMAIN_METADATA_ELEMENT, meta, "guestvcpudaemon", customXMLuri, flags) -- 2.3.5

2 1

[libvirt] [PATCH] domain: conf: Drop unused OSTYPE_AIX
by Cole Robinson 29 Apr '15

29 Apr '15

The phyp driver stuffed it into a DomainDefPtr during its attachdevice routine, but the value is never advertised via capabilities so it should be safe to drop. Have the phyp driver use OSTYPE_LINUX, which is what it advertises via capabilities. --- docs/schemas/capability.rng | 3 ++- src/conf/domain_conf.c | 3 +-- src/conf/domain_conf.h | 1 - src/phyp/phyp_driver.c | 2 +- tests/vircapstest.c | 2 +- 5 files changed, 5 insertions(+), 6 deletions(-) diff --git a/docs/schemas/capability.rng b/docs/schemas/capability.rng index 5f3ec70..88e08d2 100644 --- a/docs/schemas/capability.rng +++ b/docs/schemas/capability.rng @@ -262,7 +262,8 @@ <element name='os_type'> <choice> <value>xen</value>  - <value>linux</value>  + <value>linux</value>  <value>hvm</value>  <value>exe</value>  <value>uml</value>  diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 479b4c2..6565350 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -120,8 +120,7 @@ VIR_ENUM_IMPL(virDomainOS, VIR_DOMAIN_OSTYPE_LAST, "xen", "linux", "exe", - "uml", - "aix") + "uml") VIR_ENUM_IMPL(virDomainBoot, VIR_DOMAIN_BOOT_LAST, "fd", diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 25d3ee6..7a374d7 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -233,7 +233,6 @@ typedef enum { VIR_DOMAIN_OSTYPE_LINUX, VIR_DOMAIN_OSTYPE_EXE, VIR_DOMAIN_OSTYPE_UML, - VIR_DOMAIN_OSTYPE_AIX, VIR_DOMAIN_OSTYPE_LAST } virDomainOSType; diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index e9a31d0..c558c48 100644 --- a/src/phyp/phyp_driver.c +++ b/src/phyp/phyp_driver.c @@ -1720,7 +1720,7 @@ phypDomainAttachDevice(virDomainPtr domain, const char *xml) if (domain_name == NULL) goto cleanup; - def->os.type = VIR_DOMAIN_OSTYPE_AIX; + def->os.type = VIR_DOMAIN_OSTYPE_LINUX; dev = virDomainDeviceDefParse(xml, def, phyp_driver->caps, NULL, VIR_DOMAIN_DEF_PARSE_INACTIVE); diff --git a/tests/vircapstest.c b/tests/vircapstest.c index 5a43d63..0c79af8 100644 --- a/tests/vircapstest.c +++ b/tests/vircapstest.c @@ -250,7 +250,7 @@ test_virCapsDomainDataLookupQEMU(const void *data ATTRIBUTE_UNUSED) VIR_DOMAIN_OSTYPE_HVM, VIR_ARCH_PPC64LE, VIR_DOMAIN_VIRT_QEMU, "/usr/bin/qemu-system-ppc64", "pseries"); - CAPS_EXPECT_ERR(VIR_DOMAIN_OSTYPE_AIX, VIR_ARCH_NONE, -1, NULL, NULL); + CAPS_EXPECT_ERR(VIR_DOMAIN_OSTYPE_LINUX, VIR_ARCH_NONE, -1, NULL, NULL); CAPS_EXPECT_ERR(-1, VIR_ARCH_PPC64LE, -1, NULL, "pc"); CAPS_EXPECT_ERR(-1, VIR_ARCH_MIPS, -1, NULL, NULL); CAPS_EXPECT_ERR(-1, VIR_ARCH_AARCH64, VIR_DOMAIN_VIRT_KVM, -- 2.3.5

2 3

[libvirt] [PATCH 0/5] Use synchronous block job events in qemu_migration
by Michael Chapman 29 Apr '15

29 Apr '15

This patch series converts qemu_migration to use the synchronous block job event code introduced in commit 630ee5ac. It fixes two problems: - Drive mirroring has been broken since that commit, since the event indicating mirror readiness isn't processed while the VM object is locked. - Migration did not wait until the drive mirrors were properly cancelled, and this could cause disk corruption. Patch 1 moves qemuBlockJobEventProcess into a separate source file so it can be used by both qemu_driver and qemu_migration. Patch 2 introduces new qemuBlockJobSync* help functions to manage a synchronous block job. Patch 3 ensures that a thread waiting on a synchronous block job event is woken up should the domain crash. Patches 4 and 5 use the new synchronous block job helpers in qemu_driver and qemu_migration respectively. Michael Chapman (5): qemuBlockJobEventProcess: move to new source file qemuBlockJobSync*: introduce sync block job helpers qemuProcessStop: wake up pending sync block jobs qemuDomainBlockJobAbort: use sync block job helpers qemu: migration: use sync block job helpers po/POTFILES.in | 1 + src/Makefile.am | 1 + src/qemu/qemu_blockjob.c | 331 ++++++++++++++++++++++++++++++++++ src/qemu/qemu_blockjob.h | 49 ++++++ src/qemu/qemu_driver.c | 174 +++--------------- src/qemu/qemu_migration.c | 439 ++++++++++++++++++++++++++++------------------ src/qemu/qemu_process.c | 7 + 7 files changed, 676 insertions(+), 326 deletions(-) create mode 100644 src/qemu/qemu_blockjob.c create mode 100644 src/qemu/qemu_blockjob.h -- 2.1.0

2 6

[libvirt] [libvirt-test-api][PATCH 1/3] introduce 2 functions in utils
by Luyao Huang 29 Apr '15

29 Apr '15

get_standard_deviation() is to get Standard Deviation, and param_to_tuple_nolength() allow do not pass lengh when use param_to_tuple(). Signed-off-by: Luyao Huang <lhuang(a)redhat.com> --- utils/utils.py | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/utils/utils.py b/utils/utils.py index c3e46f6..954b2bf 100644 --- a/utils/utils.py +++ b/utils/utils.py @@ -31,6 +31,7 @@ import string import subprocess import hashlib import libvirt +import math from xml.dom import minidom from urlparse import urlparse @@ -896,3 +897,30 @@ def validate_remote_blk_type(hostname, username, password, else: logger.info("lspci and lsmod return nothing") return 1 + +def get_standard_deviation(cb1, cb2, opaque1, opaque2, number = 1000): + """ pass two callback functions and opaque return Standard Deviation, + this function will be useful when need equal some quick change + value (like memory, cputime), default loop times are 1000, + and notice callback functions cb1 and cb2 should allways success + """ + D = 0 + for i in range(number): + a = cb1(opaque1) + b = cb2(opaque2) + D += (int(a) - int(b))**2 + return math.sqrt(D/number) + +def param_to_tuple_nolength(paramlist): + """paramlist contains numbers which can be divided by '-', '^' and + ',', return tuple only have True or False value + """ + d = [] + a = paramlist.split(',') + for i in range(len(a)): + if a[i].find('^') >= 0: + continue + d += a[i].split('-') + lengh = max(d) + + return param_to_tuple(paramlist, int(lengh) + 1) -- 1.8.3.1

4 6

[libvirt] [PATCH 0/3] qemu: Add baybysitting for memory hotplug users
by Peter Krempa 29 Apr '15

29 Apr '15

Add sanity checks for some unsupported/invalid configs of memory devices. Peter Krempa (3): qemu: conf: Reject memory device if it would exceed configured max size qemu: command: Validate that memory devices slot ID is in range qemu: Validate available slot count for memory devices src/conf/domain_conf.c | 11 +++++++++++ src/qemu/qemu_command.c | 19 ++++++++++++++++++- src/qemu/qemu_command.h | 1 + src/qemu/qemu_driver.c | 6 ++++++ src/qemu/qemu_hotplug.c | 8 +++++++- 5 files changed, 43 insertions(+), 2 deletions(-) -- 2.3.5

2 5

[libvirt] [PATCHv2] qemu: blockCopy: Allow reuse of raw image for shallow block copy
by Peter Krempa 29 Apr '15

29 Apr '15

The documentation states that for shallow block copy the image has to have the same guest visible content as backing file of the current image if the file is being reused. This condition can be achieved also with a raw file (or a qcow without a backing file) so remove the condition that would disallow it. (This patch additionally fixes crash described in https://bugzilla.redhat.com/show_bug.cgi?id=1215569 ) --- V2: - different approach to fix Eric's comment src/qemu/qemu_driver.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 80463f2..581211a 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -17122,11 +17122,17 @@ qemuDomainBlockCopyCommon(virDomainObjPtr vm, if (qemuDomainDetermineDiskChain(driver, vm, disk, false, true) < 0) goto endjob; + /* clear the _SHALLOW flag if there is only one layer */ + if (!disk->src->backingStore) + flags &= ~VIR_DOMAIN_BLOCK_COPY_SHALLOW; + + /* unless the user provides a pre-created file, shallow copy into a raw + * file is not possible */ if ((flags & VIR_DOMAIN_BLOCK_COPY_SHALLOW) && - mirror->format == VIR_STORAGE_FILE_RAW && - disk->src->backingStore->path) { + !(flags & VIR_DOMAIN_BLOCK_COPY_REUSE_EXT) && + mirror->format == VIR_STORAGE_FILE_RAW) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("disk '%s' has backing file, so raw shallow copy " + _("shallow copy of disk '%s' into a raw file " "is not possible"), disk->dst); goto endjob; -- 2.3.5

2 2

[libvirt] [libvirt-test-API][PATCH 0/3] Modify the existing cases to cover 4 new APIs
by jiahu 29 Apr '15

29 Apr '15

Modify the existing cases to cover below 4 new APIs: networkLookupByUUIDString/networkLookupByUUID storagePoolLookupByUUIDString/storagePoolLookupByUUID jiahu (3): Add two testing cases to test_connection.conf Modify the case to cover two new APIs Modify the case to cover two new APIs cases/test_connection.conf | 8 +++++ repos/network/network_uuid.py | 68 ++++++++++++++++++++++++++++++++++++------- repos/storage/pool_uuid.py | 49 ++++++++++++++++++++++++++++++- 3 files changed, 114 insertions(+), 11 deletions(-) -- 1.8.3.1

2 4

[libvirt] [PATCH] openvz: Drop useless domain lookup
by Michal Privoznik 29 Apr '15

29 Apr '15

The lookup is just for check whether a domain we are about to add does not already exists. Well, the virDomainObjListAdd() function does that for us already so there's no need to duplicate the check. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/openvz/openvz_driver.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index 10d94ff..d1a327c 100644 --- a/src/openvz/openvz_driver.c +++ b/src/openvz/openvz_driver.c @@ -1001,14 +1001,6 @@ openvzDomainDefineXMLFlags(virConnectPtr conn, const char *xml, unsigned int fla parse_flags)) == NULL) goto cleanup; - vm = virDomainObjListFindByName(driver->domains, vmdef->name); - if (vm) { - virReportError(VIR_ERR_OPERATION_FAILED, - _("Already an OPENVZ VM active with the id '%s'"), - vmdef->name); - virDomainObjEndAPI(&vm); - goto cleanup; - } if (!(vm = virDomainObjListAdd(driver->domains, vmdef, driver->xmlopt, 0, NULL))) @@ -1098,14 +1090,6 @@ openvzDomainCreateXML(virConnectPtr conn, const char *xml, parse_flags)) == NULL) goto cleanup; - vm = virDomainObjListFindByName(driver->domains, vmdef->name); - if (vm) { - virReportError(VIR_ERR_OPERATION_FAILED, - _("Already an OPENVZ VM defined with the id '%s'"), - vmdef->name); - virDomainObjEndAPI(&vm); - goto cleanup; - } if (!(vm = virDomainObjListAdd(driver->domains, vmdef, driver->xmlopt, -- 2.0.5

3 2

[libvirt] [PATCH] qemu: blockCopy: Allow shallow block copy into a raw image
by Peter Krempa 29 Apr '15

29 Apr '15

The documentation states that for shallow block copy the image has to have the same guest visible content as backing file of the current image. This condition can be achieved also with a raw file (or a qcow without a backing file) so remove the condition that would disallow it. (This patch additionally fixes crash described in https://bugzilla.redhat.com/show_bug.cgi?id=1215569 since it removes the code) --- src/qemu/qemu_driver.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 70bf7aa..f979d33 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -16815,16 +16815,6 @@ qemuDomainBlockCopyCommon(virDomainObjPtr vm, if (qemuDomainDetermineDiskChain(driver, vm, disk, false, true) < 0) goto endjob; - if ((flags & VIR_DOMAIN_BLOCK_COPY_SHALLOW) && - mirror->format == VIR_STORAGE_FILE_RAW && - disk->src->backingStore->path) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("disk '%s' has backing file, so raw shallow copy " - "is not possible"), - disk->dst); - goto endjob; - } - /* Prepare the destination file. */ /* XXX Allow non-file mirror destinations */ if (!virStorageSourceIsLocalStorage(mirror)) { -- 2.3.5

3 5

[libvirt] [BUG?] EAGAIN not triggering error and 'events' gets cleared
by Pavel Boldin 28 Apr '15

28 Apr '15

Dear Libvirt Developers, There seems to be a bug or at least a bad behavior in `src/qemu/qemu_monitor.c' lines 683-689 function `qemuMonitorIO': if (qemuMonitorIOWrite(mon) < 0) { error = true; if (errno == ECONNRESET) hangup = true; } events &= ~VIR_EVENT_HANDLE_WRITABLE; The `qemuMonitorIOWrite' is returning 0 in case 'write' returns EAGAIN thus 'events' is always cleared of `VIR_EVENT_HANDLE_WRITABLE' even in case no message have been sent indeed. The question is: who is responsible for handling this? It seems like 'errno' is getting overwritten inside all of qemuMonitorJSON* functions so the caller can't rely on it and it needs to be fixed inside the `qemuMonitorIO'. Pavel

3 4

[libvirt] [PATCH v1] [libvirt-php] add stream support and upload/resize/download for volume
by Vasiliy Tolstov 28 Apr '15

28 Apr '15

This patch add to libvirt php binding libvirt stream support Also provide resize/upload/download for libvirt volume Signed-off-by: Vasiliy Tolstov <v.tolstov(a)selfip.ru> --- configure.ac | 3 +- src/libvirt-php.c | 382 +++++++++++++++++++++++++++++++++++++++++++++++++++++- src/libvirt-php.h | 17 +++ 3 files changed, 395 insertions(+), 7 deletions(-) diff --git a/configure.ac b/configure.ac index b854153..7099f9d 100644 --- a/configure.ac +++ b/configure.ac @@ -1,7 +1,6 @@ AC_INIT([libvirt-php], [0.5.0], [http://libvirt.org] -AM_INIT_AUTOMAKE([-Wall -Werror]) +AM_INIT_AUTOMAKE([-Wall -Werror -Wno-portability]) AC_CONFIG_FILES([Makefile tools/Makefile src/Makefile tests/Makefile docs/Makefile]) -AM_INIT_AUTOMAKE([-Wno-portability]) AM_MAINTAINER_MODE([enable]) dnl Checks for programs. diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 6d6fa81..0adc4be 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -61,6 +61,7 @@ int le_libvirt_storagepool; int le_libvirt_volume; int le_libvirt_network; int le_libvirt_nodedev; +int le_libvirt_stream; #if LIBVIR_VERSION_NUMBER>=8000 int le_libvirt_snapshot; #endif @@ -90,6 +91,13 @@ static zend_function_entry libvirt_functions[] = { PHP_FE(libvirt_connect_get_maxvcpus, NULL) PHP_FE(libvirt_connect_get_encrypted, NULL) PHP_FE(libvirt_connect_get_secure, NULL) + /* Stream functions */ + PHP_FE(libvirt_stream_create, NULL) + PHP_FE(libvirt_stream_close, NULL) + PHP_FE(libvirt_stream_abort, NULL) + PHP_FE(libvirt_stream_finish, NULL) + PHP_FE(libvirt_stream_send, NULL) + PHP_FE(libvirt_stream_recv, NULL) /* Domain functions */ PHP_FE(libvirt_domain_new, NULL) PHP_FE(libvirt_domain_new_get_vnc, NULL) @@ -148,7 +156,7 @@ static zend_function_entry libvirt_functions[] = { PHP_FE(libvirt_domain_get_screen_dimensions, NULL) PHP_FE(libvirt_domain_send_keys, NULL) PHP_FE(libvirt_domain_send_pointer_event, NULL) - PHP_FE(libvirt_domain_update_device, NULL) + PHP_FE(libvirt_domain_update_device, NULL) /* Domain snapshot functions */ PHP_FE(libvirt_domain_has_current_snapshot, NULL) PHP_FE(libvirt_domain_snapshot_create, NULL) @@ -169,6 +177,9 @@ static zend_function_entry libvirt_functions[] = { PHP_FE(libvirt_storagevolume_create_xml,NULL) PHP_FE(libvirt_storagevolume_create_xml_from,NULL) PHP_FE(libvirt_storagevolume_delete,NULL) + PHP_FE(libvirt_storagevolume_download,NULL) + PHP_FE(libvirt_storagevolume_upload,NULL) + PHP_FE(libvirt_storagevolume_resize,NULL) PHP_FE(libvirt_storagepool_get_uuid_string, NULL) PHP_FE(libvirt_storagepool_get_name, NULL) PHP_FE(libvirt_storagepool_lookup_by_uuid_string, NULL) @@ -370,6 +381,8 @@ char *translate_counter_type(int type) break; case INT_RESOURCE_DOMAIN: return "domain"; break; + case INT_RESOURCE_STREAM: return "stream"; + break; case INT_RESOURCE_NETWORK: return "network"; break; case INT_RESOURCE_NODEDEV: return "node device"; @@ -444,7 +457,7 @@ void free_tokens(tTokenizer t) Private function name: resource_change_counter Since version: 0.4.2 Description: Function to increment (inc = 1) / decrement (inc = 0) the resource pointers count including the memory location - Arguments: @type [int]: type of resource (INT_RESOURCE_x defines where x can be { CONNECTION | DOMAIN | NETWORK | NODEDEV | STORAGEPOOL | VOLUME | SNAPSHOT }) + Arguments: @type [int]: type of resource (INT_RESOURCE_x defines where x can be { CONNECTION | DOMAIN | NETWORK | NODEDEV | STORAGEPOOL | VOLUME | SNAPSHOT | STREAM }) @conn [virConnectPtr]: libvirt connection pointer associated with the resource, NULL for libvirt connection objects @mem [pointer]: Pointer to memory location for the resource. Will be converted to appropriate uint for the arch. @inc [int/bool]: Increment the counter (1 = add memory location) or decrement the counter (0 = remove memory location) from entries. @@ -724,6 +737,18 @@ void free_resource(int type, arch_uint mem TSRMLS_DC) } } + if (type == INT_RESOURCE_STREAM) { + rv = virStreamFree( (virStreamPtr)mem ); + if (rv != 0) { + DPRINTF("%s: virStreamFree(%p) returned %d (%s)\n", __FUNCTION__, (virStreamPtr)mem, rv, LIBVIRT_G (last_error)); + php_error_docref(NULL TSRMLS_CC, E_WARNING,"virStreamFree failed with %i on destructor: %s", rv, LIBVIRT_G (last_error)); + } + else { + DPRINTF("%s: virStreamFree(%p) completed successfully\n", __FUNCTION__, (virStreamPtr)mem); + resource_change_counter(INT_RESOURCE_STREAM, NULL, (virStreamPtr)mem, 0 TSRMLS_CC); + } + } + if (type == INT_RESOURCE_NETWORK) { rv = virNetworkFree( (virNetworkPtr)mem ); if (rv != 0) { @@ -986,6 +1011,36 @@ static void php_libvirt_domain_dtor(zend_rsrc_list_entry *rsrc TSRMLS_DC) } } +/* Destructor for stream resource */ +static void php_libvirt_stream_dtor(zend_rsrc_list_entry *rsrc TSRMLS_DC) +{ + php_libvirt_stream *stream = (php_libvirt_stream*)rsrc->ptr; + int rv = 0; + + if (stream != NULL) + { + if (stream->stream != NULL) + { + if (!check_resource_allocation(NULL, INT_RESOURCE_STREAM, stream->stream TSRMLS_CC)) { + stream->stream=NULL; + efree (stream); + return; + } + rv = virStreamFree(stream->stream); + if (rv != 0) { + DPRINTF("%s: virStreamFree(%p) returned %d (%s)\n", __FUNCTION__, stream->stream, rv, LIBVIRT_G (last_error)); + php_error_docref(NULL TSRMLS_CC, E_WARNING,"virStreamFree failed with %i on destructor: %s", rv, LIBVIRT_G (last_error)); + } + else { + DPRINTF("%s: virStreamFree(%p) completed successfully\n", __FUNCTION__, stream->stream); + resource_change_counter(INT_RESOURCE_STREAM, NULL, stream->stream, 0 TSRMLS_CC); + } + stream->stream=NULL; + } + efree (stream); + } +} + /* Destructor for storagepool resource */ static void php_libvirt_storagepool_dtor(zend_rsrc_list_entry *rsrc TSRMLS_DC) { @@ -1144,6 +1199,7 @@ PHP_MINIT_FUNCTION(libvirt) /* register resource types and their descriptors */ le_libvirt_connection = zend_register_list_destructors_ex(php_libvirt_connection_dtor, NULL, PHP_LIBVIRT_CONNECTION_RES_NAME, module_number); le_libvirt_domain = zend_register_list_destructors_ex(php_libvirt_domain_dtor, NULL, PHP_LIBVIRT_DOMAIN_RES_NAME, module_number); + le_libvirt_stream = zend_register_list_destructors_ex(php_libvirt_stream_dtor, NULL, PHP_LIBVIRT_STREAM_RES_NAME, module_number); le_libvirt_storagepool = zend_register_list_destructors_ex(php_libvirt_storagepool_dtor, NULL, PHP_LIBVIRT_STORAGEPOOL_RES_NAME, module_number); le_libvirt_volume = zend_register_list_destructors_ex(php_libvirt_volume_dtor, NULL, PHP_LIBVIRT_VOLUME_RES_NAME, module_number); le_libvirt_network = zend_register_list_destructors_ex(php_libvirt_network_dtor, NULL, PHP_LIBVIRT_NETWORK_RES_NAME, module_number); @@ -1171,6 +1227,11 @@ PHP_MINIT_FUNCTION(libvirt) REGISTER_LONG_CONSTANT("VIR_DOMAIN_SHUTOFF", 5, CONST_CS | CONST_PERSISTENT); REGISTER_LONG_CONSTANT("VIR_DOMAIN_CRASHED", 6, CONST_CS | CONST_PERSISTENT); + /* Volume constants */ + REGISTER_LONG_CONSTANT("VIR_STORAGE_VOL_RESIZE_ALLOCATE", 1, CONST_CS | CONST_PERSISTENT); + REGISTER_LONG_CONSTANT("VIR_STORAGE_VOL_RESIZE_DELTA", 2, CONST_CS | CONST_PERSISTENT); + REGISTER_LONG_CONSTANT("VIR_STORAGE_VOL_RESIZE_SHRINK", 4, CONST_CS | CONST_PERSISTENT); + /* Domain vCPU flags */ REGISTER_LONG_CONSTANT("VIR_DOMAIN_VCPU_CONFIG", VIR_DOMAIN_VCPU_CONFIG, CONST_CS | CONST_PERSISTENT); REGISTER_LONG_CONSTANT("VIR_DOMAIN_VCPU_CURRENT", VIR_DOMAIN_VCPU_CURRENT, CONST_CS | CONST_PERSISTENT); @@ -3456,6 +3517,207 @@ PHP_FUNCTION(libvirt_domain_lookup_by_uuid_string) } /* + Function name: libvirt_stream_create + Since version: 0.5.0 + Description: Function is used to create new stream from libvirt conn + Arguments: @res [resource]: libvirt connection resource from libvirt_connect() + Returns: resource libvirt stream resource +*/ +PHP_FUNCTION(libvirt_stream_create) +{ + php_libvirt_connection *conn=NULL; + zval *zconn; + virStreamPtr stream = NULL; + php_libvirt_stream *res_stream; + + if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "r", &zconn) == FAILURE) { + RETURN_FALSE; + } + ZEND_FETCH_RESOURCE (conn, php_libvirt_connection*, &zconn, -1, PHP_LIBVIRT_CONNECTION_RES_NAME, le_libvirt_connection); + if ((conn==NULL)||(conn->conn==NULL))RETURN_FALSE; + + stream = virStreamNew(conn->conn, 0); + if (stream==NULL) { + set_error("Cannot create new stream" TSRMLS_CC); + RETURN_FALSE; + } + + res_stream = (php_libvirt_stream *)emalloc(sizeof(php_libvirt_stream)); + res_stream->stream = stream; + res_stream->conn = conn; + + resource_change_counter(INT_RESOURCE_STREAM, conn->conn, res_stream->stream, 1 TSRMLS_CC); + ZEND_REGISTER_RESOURCE(return_value, res_stream, le_libvirt_stream); +} + +/* + Function name: libvirt_stream_close + Since version: 0.5.0 + Description: Function is used to close stream + Arguments: @res [resource]: libvirt stream resource from libvirt_stream_create() + Returns: int +*/ +PHP_FUNCTION(libvirt_stream_close) +{ + zval *zstream; + php_libvirt_stream *stream=NULL; + int retval = -1; + + if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "r", &zstream) == FAILURE) { + RETURN_LONG(retval); + } + ZEND_FETCH_RESOURCE (stream, php_libvirt_stream*, &zstream, -1, PHP_LIBVIRT_STREAM_RES_NAME, le_libvirt_stream); + if ((stream==NULL)||(stream->stream==NULL))RETURN_LONG(retval); + + retval = virStreamFree(stream->stream); + if (retval != 0) { + set_error("Cannot free stream" TSRMLS_CC); + RETURN_LONG(retval); + } + + resource_change_counter(INT_RESOURCE_STREAM, stream->conn, stream->stream, 0 TSRMLS_CC); + RETURN_LONG(retval); +} + +/* + Function name: libvirt_stream_abort + Since version: 0.5.0 + Description: Function is used to abort transfer + Arguments: @res [resource]: libvirt stream resource from libvirt_stream_create() + Returns: int +*/ +PHP_FUNCTION(libvirt_stream_abort) +{ + zval *zstream; + php_libvirt_stream *stream=NULL; + int retval = -1; + + if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "r", &zstream) == FAILURE) { + RETURN_LONG(retval); + } + ZEND_FETCH_RESOURCE (stream, php_libvirt_stream*, &zstream, -1, PHP_LIBVIRT_STREAM_RES_NAME, le_libvirt_stream); + if ((stream==NULL)||(stream->stream==NULL))RETURN_LONG(retval); + + retval = virStreamAbort(stream->stream); + if (retval != 0) { + set_error("Cannot abort stream" TSRMLS_CC); + RETURN_LONG(retval); + } + RETURN_LONG(retval); +} + +/* + Function name: libvirt_stream_finish + Since version: 0.5.0 + Description: Function is used to finish transfer + Arguments: @res [resource]: libvirt stream resource from libvirt_stream_create() + Returns: int +*/ +PHP_FUNCTION(libvirt_stream_finish) +{ + zval *zstream; + php_libvirt_stream *stream=NULL; + int retval = -1; + + if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "r", &zstream) == FAILURE) { + RETURN_LONG(retval); + } + ZEND_FETCH_RESOURCE (stream, php_libvirt_stream*, &zstream, -1, PHP_LIBVIRT_STREAM_RES_NAME, le_libvirt_stream); + if ((stream==NULL)||(stream->stream==NULL))RETURN_LONG(retval); + + retval = virStreamFinish(stream->stream); + if (retval != 0) { + set_error("Cannot finish stream" TSRMLS_CC); + RETURN_LONG(retval); + } + RETURN_LONG(retval); +} + +/* + Function name: libvirt_stream_recv + Since version: 0.5.0 + Description: Function is used to close stream from libvirt conn + Arguments: @res [resource]: libvirt stream resource from libvirt_stream_create() + @data [string]: buffer + @len [int]: amout of data to recieve + Returns: int +*/ +PHP_FUNCTION(libvirt_stream_recv) +{ + zval *zstream, *zbuf; + char *recv_buf; + php_libvirt_stream *stream=NULL; + int retval = -1; + long length = 0; + + if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "rz|l", &zstream, &zbuf, &length) == FAILURE) { + RETURN_LONG(retval); + } + ZEND_FETCH_RESOURCE (stream, php_libvirt_stream*, &zstream, -1, PHP_LIBVIRT_STREAM_RES_NAME, le_libvirt_stream); + if ((stream==NULL)||(stream->stream==NULL))RETURN_LONG(retval); + + recv_buf = emalloc(length + 1); + memset(recv_buf, 0, length + 1); + + retval = virStreamRecv(stream->stream, recv_buf, length); + if (retval < 0) { + efree(recv_buf); + zval_dtor(zbuf); + Z_TYPE_P(zbuf) = IS_NULL; + } else { + recv_buf[retval] = '\0'; + /* Rebuild buffer zval */ + zval_dtor(zbuf); + Z_STRVAL_P(zbuf) = recv_buf; + Z_STRLEN_P(zbuf) = retval; + Z_TYPE_P(zbuf) = IS_STRING; + } + + if (retval == -1) { + set_error("Cannot recv from stream" TSRMLS_CC); + RETURN_LONG(retval); + } + + RETURN_LONG(retval); +} + +/* + Function name: libvirt_stream_send + Since version: 0.5.0 + Description: Function is used to close stream from libvirt conn + Arguments: @res [resource]: libvirt stream resource from libvirt_stream_create() + @data [string]: buffer + @length [int]: amout of data to send + Returns: int +*/ +PHP_FUNCTION(libvirt_stream_send) +{ + zval *zstream, *zbuf; + php_libvirt_stream *stream=NULL; + int retval = -1; + long length = 0; + char *cstr; + //int cstrlen; + + if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "rz|l", &zstream, &zbuf, &length) == FAILURE) { + RETURN_LONG(retval); + } + ZEND_FETCH_RESOURCE (stream, php_libvirt_stream*, &zstream, -1, PHP_LIBVIRT_STREAM_RES_NAME, le_libvirt_stream); + if ((stream==NULL)||(stream->stream==NULL))RETURN_LONG(retval); + + cstr = Z_STRVAL_P(zbuf); + //cstrlen = Z_STRLEN_P(zbuf); + + retval = virStreamSend(stream->stream, cstr, length); + if (retval == -1) { + set_error("Cannot send to stream" TSRMLS_CC); + RETURN_LONG(retval); + } + + RETURN_LONG(retval); +} + +/* Function name: libvirt_domain_lookup_by_id Since version: 0.4.1(-1) Description: Function is used to get domain by it's ID, applicable only to running guests @@ -3544,13 +3806,12 @@ PHP_FUNCTION(libvirt_domain_get_uuid_string) @opaque [void *]: used for file descriptor Returns: write() error code as it's calling write */ - static int streamSink(virStreamPtr st ATTRIBUTE_UNUSED, const char *bytes, size_t nbytes, void *opaque) { - int *fd = (int *)opaque; + int *fd = (int *)opaque; - return write(*fd, bytes, nbytes); + return write(*fd, bytes, nbytes); } /* @@ -6782,6 +7043,117 @@ PHP_FUNCTION(libvirt_storagevolume_delete) } /* + Function name: libvirt_storagevolume_resize + Since version: 0.5.0 + Description: Function is used to resize volume identified by it's resource + Arguments: @res [resource]: libvirt storagevolume resource + @capacity [int]: capacity for the storage volume + @flags [int]: optional flags for the storage volume resize for virStorageVolResize() + Returns: int +*/ +PHP_FUNCTION(libvirt_storagevolume_resize) +{ + php_libvirt_volume *volume=NULL; + zval *zvolume; + long flags = 0; + long capacity = 0; + int retval = -1; + + GET_VOLUME_FROM_ARGS("rl|l", &zvolume, &capacity, &flags); + + retval = virStorageVolResize(volume->volume, capacity, flags); + DPRINTF("%s: virStorageVolResize(%p, %d, %d) returned %d\n", PHPFUNC, volume->volume, (int) capacity, (int) flags, retval); + if (retval != 0) { + set_error_if_unset("Cannot resize storage volume" TSRMLS_CC); + RETURN_LONG(retval); + } + + RETURN_LONG(retval); +} + +/* + Function name: libvirt_storagevolume_download + Since version: 0.5.0 + Description: Function is used to download volume identified by it's resource + Arguments: @res [resource]: libvirt storagevolume resource + @stream [resource]: stream to use as output + @offset [int]: position to start reading from + @length [int] : limit on amount of data to download + @flags [int]: optional flags for the storage volume download for virStorageVolDownload() + Returns: int +*/ +PHP_FUNCTION(libvirt_storagevolume_download) +{ + php_libvirt_volume *volume=NULL; + php_libvirt_stream *stream=NULL; + zval *zvolume; + zval *zstream; + long flags = 0; + long offset = 0; + long length = 0; + int retval = -1; + + if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "rr|l|l|l", &zvolume, &zstream, &offset, &length, &flags) == FAILURE) { + RETURN_LONG(retval); + } + ZEND_FETCH_RESOURCE (volume, php_libvirt_volume*, &zvolume, -1, PHP_LIBVIRT_VOLUME_RES_NAME, le_libvirt_volume); + if ((volume==NULL)||(volume->volume==NULL))RETURN_LONG(retval); + ZEND_FETCH_RESOURCE (stream, php_libvirt_stream*, &zstream, -1, PHP_LIBVIRT_STREAM_RES_NAME, le_libvirt_stream); + if ((stream==NULL)||(stream->stream==NULL))RETURN_LONG(retval); + + retval = virStorageVolDownload(volume->volume, stream->stream, offset, length, flags); + DPRINTF("%s: virStorageVolDownload(%p, %p, %d, %d, %d) returned %d\n", PHPFUNC, volume->volume, stream->stream, (int) offset, (int) length, (int) flags, retval); + + if (retval == -1) { + set_error("Cannot download from stream" TSRMLS_CC); + RETURN_LONG(retval); + } + + RETURN_LONG(retval); +} + +/* + Function name: libvirt_storagevolume_upload + Since version: 0.5.0 + Description: Function is used to upload volume identified by it's resource + Arguments: @res [resource]: libvirt storagevolume resource + @stream [resource]: stream to use as input + @offset [int]: position to start writing to + @length [int] : limit on amount of data to upload + @flags [int]: optional flags for the storage volume upload for virStorageVolUpload() + Returns: int +*/ +PHP_FUNCTION(libvirt_storagevolume_upload) +{ + php_libvirt_volume *volume=NULL; + php_libvirt_stream *stream=NULL; + zval *zvolume; + zval *zstream; + long flags = 0; + long offset = 0; + long length = 0; + int retval = -1; + + if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "rr|l|l|l", &zvolume, &zstream, &offset, &length, &flags) == FAILURE) { + RETURN_LONG(retval); + } + ZEND_FETCH_RESOURCE (volume, php_libvirt_volume*, &zvolume, -1, PHP_LIBVIRT_VOLUME_RES_NAME, le_libvirt_volume); + if ((volume==NULL)||(volume->volume==NULL))RETURN_LONG(retval); + ZEND_FETCH_RESOURCE (stream, php_libvirt_stream*, &zstream, -1, PHP_LIBVIRT_STREAM_RES_NAME, le_libvirt_stream); + if ((stream==NULL)||(stream->stream==NULL))RETURN_LONG(retval); + + retval = virStorageVolUpload(volume->volume, stream->stream, offset, length, flags); + DPRINTF("%s: virStorageVolUpload(%p, %p, %d, %d, %d) returned %d\n", PHPFUNC, volume->volume, stream->stream, (int) offset, (int) length, (int) flags, retval); + + if (retval == -1) { + set_error_if_unset("Cannot upload storage volume" TSRMLS_CC); + RETURN_LONG(retval); + } + + RETURN_LONG(retval); +} + +/* Function name: libvirt_storagepool_get_uuid_string Since version: 0.4.1(-1) Description: Function is used to get storage pool by UUID string diff --git a/src/libvirt-php.h b/src/libvirt-php.h index 450fbea..3bcc682 100644 --- a/src/libvirt-php.h +++ b/src/libvirt-php.h @@ -214,6 +214,7 @@ ZEND_END_MODULE_GLOBALS(libvirt) #define INT_RESOURCE_STORAGEPOOL 0x10 #define INT_RESOURCE_VOLUME 0x20 #define INT_RESOURCE_SNAPSHOT 0x40 +#define INT_RESOURCE_STREAM 0x50 typedef struct tVMDisk { char *path; @@ -257,6 +258,11 @@ typedef struct _php_libvirt_connection { long resource_id; } php_libvirt_connection; +typedef struct _php_libvirt_stream { + virStreamPtr stream; + php_libvirt_connection* conn; +} php_libvirt_stream; + typedef struct _php_libvirt_domain { virDomainPtr domain; php_libvirt_connection* conn; @@ -311,6 +317,7 @@ int gdebug; #define PHP_LIBVIRT_CONNECTION_RES_NAME "Libvirt connection" #define PHP_LIBVIRT_DOMAIN_RES_NAME "Libvirt domain" +#define PHP_LIBVIRT_STREAM_RES_NAME "Libvirt stream" #define PHP_LIBVIRT_STORAGEPOOL_RES_NAME "Libvirt storagepool" #define PHP_LIBVIRT_VOLUME_RES_NAME "Libvirt volume" #define PHP_LIBVIRT_NETWORK_RES_NAME "Libvirt virtual network" @@ -347,6 +354,13 @@ PHP_FUNCTION(libvirt_node_get_info); PHP_FUNCTION(libvirt_node_get_cpu_stats); PHP_FUNCTION(libvirt_node_get_cpu_stats_for_each_cpu); PHP_FUNCTION(libvirt_node_get_mem_stats); +/* Stream functions */ +PHP_FUNCTION(libvirt_stream_create); +PHP_FUNCTION(libvirt_stream_close); +PHP_FUNCTION(libvirt_stream_abort); +PHP_FUNCTION(libvirt_stream_finish); +PHP_FUNCTION(libvirt_stream_recv); +PHP_FUNCTION(libvirt_stream_send); /* Domain functions */ PHP_FUNCTION(libvirt_domain_new); PHP_FUNCTION(libvirt_domain_new_get_vnc); @@ -427,6 +441,9 @@ PHP_FUNCTION(libvirt_storagevolume_get_xml_desc); PHP_FUNCTION(libvirt_storagevolume_create_xml); PHP_FUNCTION(libvirt_storagevolume_create_xml_from); PHP_FUNCTION(libvirt_storagevolume_delete); +PHP_FUNCTION(libvirt_storagevolume_download); +PHP_FUNCTION(libvirt_storagevolume_upload); +PHP_FUNCTION(libvirt_storagevolume_resize); PHP_FUNCTION(libvirt_storagepool_get_uuid_string); PHP_FUNCTION(libvirt_storagepool_get_name); PHP_FUNCTION(libvirt_storagepool_lookup_by_uuid_string); -- 2.3.3

1 0

[libvirt] missing php binding to storage volume download , resize and upload
by Vasiliy Tolstov 28 Apr '15

28 Apr '15

Can somebody add missed functions to libvirt php api binding to download,resize and upload volume? -- Vasiliy Tolstov, e-mail: v.tolstov(a)selfip.ru jabber: vase(a)selfip.ru

3 4

[libvirt] ANNOUNCE: libvirt 1.2.9.3 maintenance release
by Cole Robinson 28 Apr '15

28 Apr '15

libvirt 1.2.9.3 is now available. This is a maintenance release of libvirt 1.2.9 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-1.2.9.3.tar.gz Changes in this version: * storage: fs: Ignore volumes that fail to open with EACCESS/EPERM * domain: conf: Don't validate VM ostype/arch at daemon startup * domain: conf: Better errors on bad os <type> values * Report original error when QMP probing fails with new QEMU * cpu: Add {Haswell,Broadwell}-noTSX CPU models * storage: qemu: Fix security labelling of new image chain elements * Ignore CPU features without a model for host-passthrough * Do not format CPU features without a model * domcaps: Check for architecture more wisely * daemon: Clear fake domain def object that is used to check ACL prior to use * util: identity: Harden virIdentitySetCurrent() * qemu: Build nvram directory at driver startup * qemu: Build channel autosocket directory at driver startup * qemu: chown autoDumpPath on driver startup * qemu: conf: Clarify paths that are relative to libDir * avoid using deprecated udev logging functions * qemu: Always refresh capabilities if no <guests> found * qemu: move setting emulatorpin ahead of monitor showing up * rpc: Don't unref identity object while callbacks still can be executed * conf: tests: fix virDomainNetDefFormat for vhost-user in client mode * Document that USB hostdevs do not need nodeDettach * Document behavior of compat when creating qcow2 volumes * Clarify the meaning of version in redirdev filters * Strip control codes in virBufferEscapeString * Ignore storage volumes with control codes in their names * Strip control characters from sysfs attributes * Add functions dealing with control characters in strings * virNetworkDefUpdateIPDHCPHost: Don't crash when updating network * daemon: avoid memleak when ListAll returns nothing * conf: error out on missing dhcp host attributes * conf: error out on invalid host id * conf: Don't format actual network definition in migratable XML * conf: Fix libvirtd crash and memory leak caused by virDomainVcpuPinDel() For info about past maintenance releases, see: http://wiki.libvirt.org/page/Maintenance_Releases Thanks, Cole

1 0

[libvirt] ANNOUNCE: libvirt 1.2.13.1 maintenance release
by Cole Robinson 28 Apr '15

28 Apr '15

libvirt 1.2.13.1 is now available. This is a maintenance release of libvirt 1.2.13 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-1.2.13.1.tar.gz Changes in this version: * Fix memory leak in virNetSocketNewConnectUNIX * rng: fix port number range validation * qemu: Don't fail to reboot domains with unresponsive agent * vircommand: fix polling in virCommandProcessIO * util: storage: Fix possible crash when source path is NULL * qemu: set macvtap physdevs online when macvtap is set online * util: set MAC address for VF via netlink message to PF+VF# when possible * xend: Remove a couple of unused function prototypes. * qemuDomainShutdownFlags: Set fakeReboot more frequently * nwfilter: Partly initialize driver even for non-privileged users * virNetSocketNewConnectUNIX: Don't unlink(NULL) * sanlock: Use VIR_ERR_RESOURCE_BUSY if sanlock_acquire fails * qemuMigrationPrecreateStorage: Fix debug message * qemu_migration.c: sleep first before checking for migration status. * qemu_driver: check caps after starting block job * qemu_migrate: use nested job when adding NBD to cookie * util: fix removal of callbacks in virCloseCallbacksRun * qemu: fix race between disk mirror fail and cancel * qemu: fix error propagation in qemuMigrationBegin * qemu: fix crash in qemuProcessAutoDestroy * qemu: blockCopy: Pass adjusted bandwidth when called via blockRebase * virsh: blockCopy: Add missing jump on error path * qemu: end the job when try to blockcopy to non-file destination * nodeinfo: Increase the num of CPU thread siblings to a larger value * relaxng: allow : in /dev/disk/by-path names * qemu: Give hint about -noTSX CPU model * build: fix race when creating the cpu_map.xml symlink * Don't validata filesystem target type * Document behavior of compat when creating qcow2 volumes * Fix typo in error message * qemu: change accidental VIR_WARNING back to VIR_DEBUG * conf: fix parsing of NUMA settings in VM status XML * qemu: skip precreation of network disks * qemu: do not overwrite the error in qemuDomainObjExitMonitor * libxl: Don't overwrite errors from xenconfig * util: more verbose error when failing to create macvtap device * qemu: hotplug: Use checker function to check if disk is empty * qemu: driver: Fix cold-update of removable storage devices * qemu: Check for negative port values in network drive configuration * virsh: fix report of non-active commit completion * util: don't fail if no PortData is found while getting migrateData * Clarify the meaning of version in redirdev filters * xenapi: Resolve Coverity REVERSE_INULL * xenapi: Resolve Coverity REVERSE_INULL * xenapi: Resolve Coverity NULL_RETURNS * xenapi: Resolve Coverity NO_EFFECT * xenapi: Resolve Coverity FORWARD_NULL * RNG: Allow multiple parameters to be passed to an interface filter * domain_conf: fix crash in virDomainObjListFindByUUIDInternal * {domain, network}_conf: disable autostart when deleting config * qemu: Remove unnecessary virReportError on networkGetNetworkAddress return * virQEMUCapsInitQMP: Don't dispose locked @vm * qemu: fix memory leak in qemuAgentGetFSInfo * docs: add a note that spice channel is usable only with spice graphics * locking: Fix flags in virLockManagerLockDaemonNew * tests: fix qemuxml2argvtest to be arch independent * tests: Add test for virtio-mmio address type * qemu: Allow spaces in disk serial * storage: tweak condition to properly test lseek * virsh: tweak domif-getlink link state reporting message * qemu: snapshot: Don't skip check for qcow2 format with network disks * networkLookupByUUID: Improve error message * qemuProcessReconnect: Fill in pid file path * tests : Add test for 'ppc64le' architecture. * RNG: Add 'ppc64le' arch and newer pseries-2.* machine types * schema: Fix interface link state schema * conf: De-duplicate scheduling policy enums * qemu: Don't crash in qemuDomainOpenChannel() * virsh.pod: Update find-storage-pool-sources[-as] man page * iscsi: Adjust error message for findStorageSources backend * virsh.pod: Add information regarding LXC for setmem, memtune, and dominfo * docs: add a note that attr 'managed' is only used by PCI devices * Check if domain is running in qemuDomainAgentIsAvailable * Pass virDomainObjPtr to qemuDomainAgentAvailable * Check for qemu guest agent availability after getting the job * storage: fs: Ignore volumes that fail to open with EACCESS/EPERM * domain: conf: Don't validate VM ostype/arch at daemon startup * domain: conf: Better errors on bad os <type> values * spec: Point fedora --with-loader-nvram at nightly firmware repo * configure: Report --with-loader-nvram value in summary * configure: Fix --loader-nvram typo * cpu: Add {Haswell,Broadwell}-noTSX CPU models * domcaps: Check for architecture more wisely * daemon: Clear fake domain def object that is used to check ACL prior to use * util: identity: Harden virIdentitySetCurrent() * qemu: Always refresh capabilities if no <guests> found * qemu: Build nvram directory at driver startup * qemu: Build channel autosocket directory at driver startup * virQEMUDriverGetConfig: Fix memleak * qemu: chown autoDumpPath on driver startup * qemu: conf: Clarify paths that are relative to libDir * Strip control codes in virBufferEscapeString * util: buffer: Add support for adding text blocks with indentation * Ignore storage volumes with control codes in their names * Strip control characters from sysfs attributes * Add functions dealing with control characters in strings * tests: rename testStripIPv6BracketsData to testStripData * lxc: fix starting a domain with non-strict numa memory mode * lxc: fix starting a domain with a cpuset but no numatune * virsh: fix regression in 'virsh event' by domain * virsh: Improve change-media success message * virNetSocketNewConnectUNIX: Use flocks when spawning a daemon * rpc: Don't unref identity object while callbacks still can be executed * lxc: create the required directories upon driver start * qemu: read backing chain names from qemu * daemon: avoid memleak when ListAll returns nothing * qemu: don't fill in nicindexes for session mode libvirtd For info about past maintenance releases, see: http://wiki.libvirt.org/page/Maintenance_Releases Thanks, Cole

1 0

[libvirt] [PATCH 0/2] parallels: implement domainDetachDevice and domainDetachDeviceFlags
by Maxim Nestratov 28 Apr '15

28 Apr '15

Maxim Nestratov (2): parallels: add prlsdkDelDisk and prlsdkGetDiskIndex functions parallels: implement domainDetachDevice and domainDetachDeviceFlags

2 4

[libvirt] [PATCH 0/2] tests: fix memleak in qemumonitorjsontest
by Zhang Bo 28 Apr '15

28 Apr '15

the free callback should be qemuMonitorChardevInfoFree rather than just 'free' when virHashCreate'ing the chardevInfo hash. Zhang Bo (2): qemu: make qemuMonitorChardevInfoFree non-static tests: free ChardevInfo correctly in qemumonitorjsontest src/qemu/qemu_monitor.c | 2 +- src/qemu/qemu_monitor.h | 1 + tests/qemumonitorjsontest.c | 4 ++-- 3 files changed, 4 insertions(+), 3 deletions(-) -- 1.7.12.4

2 3

[libvirt] [PATCH] Fix building virnetserverclientmock with MinGW
by Martin Kletzander 28 Apr '15

28 Apr '15

Signed-off-by: Pavel Fedin <p.fedin(a)samsung.com> Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- Notes: This was a part of commit 9dc57ce2, but separable; plus the library should be in LIBADD and not LDFLAGS. Depends on my previous cleanup [2] [1] https://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=9dc57ce2 [2] https://www.redhat.com/archives/libvir-list/2015-April/msg01336.html v2: Use LIBADD instead of LDADDS (which doesn't even exist) tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index dc7daaa..8e2dbec 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -931,6 +931,7 @@ virnetserverclientmock_la_SOURCES = \ virnetserverclientmock.c virnetserverclientmock_la_CFLAGS = $(AM_CFLAGS) virnetserverclientmock_la_LDFLAGS = $(MOCKLIBS_LDFLAGS) +virnetserverclientmock_la_LIBADD = $(GNULIB_LIBS) if WITH_GNUTLS virnettlscontexttest_SOURCES = \ -- 2.3.6

2 1

[libvirt] [libvirt-cim][PATCH] list_util.h: Drop inline modifiers
by Michal Privoznik 28 Apr '15

28 Apr '15

There's no need to mark a function as inline in the function declaration. In fact, it causes a compilation error: CC xmlgen.lo In file included from acl_parsing.h:29:0, from xmlgen.h:26, from capability_parsing.c:37: list_util.h:67:21: error: inline function ‘list_node_prev_node’ declared but never defined [-Werror] inline list_node_t *list_node_prev_node(list_node_t *node); ^ list_util.h:66:14: error: inline function ‘list_node_prev’ declared but never defined [-Werror] inline void *list_node_prev(list_node_t *node); ^ list_util.h:64:21: error: inline function ‘list_node_next_node’ declared but never defined [-Werror] inline list_node_t *list_node_next_node(list_node_t *node); ^ list_util.h:63:14: error: inline function ‘list_node_next’ declared but never defined [-Werror] inline void *list_node_next(list_node_t *node); ^ list_util.h:61:21: error: inline function ‘list_last_node’ declared but never defined [-Werror] inline list_node_t *list_last_node(list_t *list); ^ list_util.h:60:14: error: inline function ‘list_last’ declared but never defined [-Werror] inline void *list_last(list_t *list); ^ list_util.h:58:21: error: inline function ‘list_first_node’ declared but never defined [-Werror] inline list_node_t *list_first_node(list_t *list); ^ list_util.h:57:14: error: inline function ‘list_first’ declared but never defined [-Werror] inline void *list_first(list_t *list); ^ list_util.h:55:13: error: inline function ‘list_node_data_set’ declared but never defined [-Werror] inline void list_node_data_set(list_node_t *node, void *data); ^ list_util.h:54:14: error: inline function ‘list_node_data_get’ declared but never defined [-Werror] inline void *list_node_data_get(list_node_t *node); ^ list_util.h:52:21: error: inline function ‘list_count’ declared but never defined [-Werror] inline unsigned int list_count(list_t *list); ^ cc1: all warnings being treated as errors Makefile:499: recipe for target 'capability_parsing.lo' failed make[2]: *** [capability_parsing.lo] Error 1 make[2]: *** Waiting for unfinished jobs.... Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- libxkutil/list_util.h | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/libxkutil/list_util.h b/libxkutil/list_util.h index 6510272..6582dfe 100644 --- a/libxkutil/list_util.h +++ b/libxkutil/list_util.h @@ -49,22 +49,22 @@ void list_remove_node(list_t *list, list_node_t *node); bool list_foreach(list_t *list, list_foreach_cb cb, void *user_data); -inline unsigned int list_count(list_t *list); +unsigned int list_count(list_t *list); -inline void *list_node_data_get(list_node_t *node); -inline void list_node_data_set(list_node_t *node, void *data); +void *list_node_data_get(list_node_t *node); +void list_node_data_set(list_node_t *node, void *data); -inline void *list_first(list_t *list); -inline list_node_t *list_first_node(list_t *list); +void *list_first(list_t *list); +list_node_t *list_first_node(list_t *list); -inline void *list_last(list_t *list); -inline list_node_t *list_last_node(list_t *list); +void *list_last(list_t *list); +list_node_t *list_last_node(list_t *list); -inline void *list_node_next(list_node_t *node); -inline list_node_t *list_node_next_node(list_node_t *node); +void *list_node_next(list_node_t *node); +list_node_t *list_node_next_node(list_node_t *node); -inline void *list_node_prev(list_node_t *node); -inline list_node_t *list_node_prev_node(list_node_t *node); +void *list_node_prev(list_node_t *node); +list_node_t *list_node_prev_node(list_node_t *node); #ifdef __cplusplus } /* extern "C" */ -- 2.0.5

4 5

[libvirt] virtual smartcard support for GPG backend?
by roky＠openmailbox.org 28 Apr '15

28 Apr '15

Hi. I am trying to get a virtual smartcard attached to a vm but I want it to use GPG instead of NSS. RedHat focuses on NSS becuase of PKCS#11 requirements and FIPS approval, but for most of the community its GPG that matters for smartcards. Is is possible to use GPG on the host instead of NSS with virtual smartcards? Please document how or add support for it. Is using a virtual smartcard make the host less secure from a rogue vm? If there are bugs in GPG/NSS backend on the host can they be abused by untrusted code in the vm?

1 1

[libvirt] [PATCH] storage: fs: Ignore volumes that fail to open with EPERM
by Cole Robinson 28 Apr '15

28 Apr '15

Trying to use qemu:///session to create a storage pool pointing at /tmp will usually fail with something like: $ virsh pool-start tmp error: Failed to start pool tmp error: cannot open volume '/tmp/systemd-private-c38cf0418d7a4734a66a8175996c384f-colord.service-kEyiTA': Permission denied If any volume in an FS pool can't be opened by the daemon, the refresh fails, and the pool can't be used. This causes pain for virt-install/virt-manager though. Imaging a user downloads a disk image to /tmp. virt-manager wants to import /tmp as a storage pool, so we can detect what disk format it is, and set the XML correctly. However this case will likely fail as explained above. Change the logic here to skip volumes that fail to open. This could conceivably cause user complaints along the lines of 'why doesn't libvirt show $ROOT-OWNED-VOLUME-FOO', but figuring that currently the pool won't even startup, I don't think there are any current users that care about that case. https://bugzilla.redhat.com/show_bug.cgi?id=1103308 --- src/storage/storage_backend.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c index e0311e1..186013c 100644 --- a/src/storage/storage_backend.c +++ b/src/storage/storage_backend.c @@ -1445,6 +1445,10 @@ virStorageBackendVolOpen(const char *path, struct stat *sb, VIR_WARN("ignoring missing fifo '%s'", path); return -2; } + if (errno == EACCES && noerror) { + VIR_WARN("ignore permission error for '%s'", path); + return -2; + } virReportSystemError(errno, _("cannot open volume '%s'"), path); return -1; -- 2.3.6

2 2

[libvirt] [PATCH 0/4] storage: Fix a few issues with pool state tracking
by Cole Robinson 28 Apr '15

28 Apr '15

First patch fixes a regression introduced with pool state patches Last 3 patches help fix other issues with the state tracking Cole Robinson (4): storage: Fix autostart dir for qemu:///session storage: Don't leave stale state file if pool startup fails storage: Break out storageDriverLoadPoolState storage: If driver startup state syncing fails, delete statefile src/storage/storage_driver.c | 109 ++++++++++++++++++++++++++----------------- 1 file changed, 67 insertions(+), 42 deletions(-) -- 2.3.6

2 6

[libvirt] Repo link for libvirt-cim throws 404
by Nehal J Wani 28 Apr '15

28 Apr '15

The repository link for libvirt-cim at http://libvirt.org/CIM/downloads.html seems outdated. Shouldn't it be: git clone git://libvirt.org/libvirt-cim instead of hg clone http://libvirt.org/hg/libvirt-cim -- Nehal J Wani

2 1

[libvirt] [PATCH v2 0/3] IOThread algorithm followups
by John Ferlan 28 Apr '15

28 Apr '15

v1 here: http://www.redhat.com/archives/libvir-list/2015-April/msg01382.html v2 changes: Patch 1 - Add a !STRPREFIX(tmp, "iothread") of the returned iothreads to ignore anything that doesn't start with "iothread". Patch 2 - already ACKed, just difficult to extract. Patch 3 - NEW: remove qemuMonitorIOThreadInfoFree as requested from review of patch 1. John Ferlan (3): qemu: Remove need for qemuDomainParseIOThreadAlias qemu: qemuProcessDetectIOThreadPIDs invert checks qemu: Remove need for qemuMonitorIOThreadInfoFree src/qemu/qemu_command.c | 17 ----------------- src/qemu/qemu_command.h | 3 --- src/qemu/qemu_driver.c | 15 +++++---------- src/qemu/qemu_monitor.c | 10 ---------- src/qemu/qemu_monitor.h | 4 +--- src/qemu/qemu_monitor_json.c | 22 +++++++++++++++------- src/qemu/qemu_process.c | 25 +++++++++++-------------- tests/qemumonitorjsontest.c | 14 +++++++------- 8 files changed, 39 insertions(+), 71 deletions(-) -- 2.1.0

2 8

[libvirt] [PATCH v4 0/6] Add vmport feature
by Marc-André Lureau 28 Apr '15

28 Apr '15

Hi, The QEMU machine vmport option allows to set the VMWare IO port emulation. This emulation is useful for absolute pointer input when the guest has vmware input drivers, and is enabled by default for kvm. However it is unnecessary for Spice-enabled VM, since the agent already handles absolute pointer and multi-monitors. Furthermore, it prevents Spice from switching to relative input since the regular ps/2 pointer driver is replaced by the vmware driver. It is thus advised to disable vmport when using a Spice VM. This will permit the Spice client to switch from absolute to relative pointer, as it may be required for certain games or applications. The following patch series allows to configure the vmport feature. v2: - use a feature instead of a domain attribute, suggested by D. Berrange v3: - use qmp query for caps instead of version v4: - use vesion check & qmp, add runtime check for machine kind Marc-André Lureau (6): docs: add domain vmport feature domain/conf: add VIR_DOMAIN_FEATURE_VMPORT qemu: add QEMU_CAPS_MACHINE_VMPORT_OPT qemu: add virQEMUCapsSupportsVmport qemu: add machine vmport argument tests: add machine-vmport-opt qemu test docs/formatdomain.html.in | 6 ++++ docs/schemas/domaincommon.rng | 9 ++++++ src/conf/domain_conf.c | 5 +++- src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 20 +++++++++++++ src/qemu/qemu_capabilities.h | 4 +++ src/qemu/qemu_command.c | 33 +++++++++------------- src/qemu/qemu_domain.c | 19 +++++++++++++ src/qemu/qemu_domain.h | 3 ++ .../qemuxml2argv-machine-vmport-opt.args | 6 ++++ .../qemuxml2argv-machine-vmport-opt.xml | 28 ++++++++++++++++++ tests/qemuxml2argvtest.c | 2 ++ 12 files changed, 116 insertions(+), 20 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-vmport-opt.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-vmport-opt.xml -- 2.1.0

2 12

[libvirt] [libvirt-perl PATCH] Add virDomainAddIOThread and virDomainDelIOThread support
by John Ferlan 28 Apr '15

28 Apr '15

Add support for the new IOThread APIs Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Changes | 1 + Virt.xs | 20 ++++++++++++++++++++ lib/Sys/Virt/Domain.pm | 12 ++++++++++++ 3 files changed, 33 insertions(+) diff --git a/Changes b/Changes index ead8f8e..58efa37 100644 --- a/Changes +++ b/Changes @@ -6,6 +6,7 @@ Revision history for perl module Sys::Virt event callback & constants. - Add JOB_DOWNTIME_NET constant - Add JOB_TIME_ELAPSED_NET constant + - Add virDomainAddIOThread and virDomainDelIOThread API bindings 1.2.14 2015-04-09 diff --git a/Virt.xs b/Virt.xs index debb8f4..29f20ec 100644 --- a/Virt.xs +++ b/Virt.xs @@ -5100,6 +5100,26 @@ PREINIT: _croak_error(); +void +add_iothread(dom, iothread_id, flags=0) + virDomainPtr dom; + unsigned int iothread_id; + unsigned int flags; + PPCODE: + if (virDomainAddIOThread(dom, iothread_id, flags) < 0) + _croak_error(); + + +void +del_iothread(dom, iothread_id, flags=0) + virDomainPtr dom; + unsigned int iothread_id; + unsigned int flags; + PPCODE: + if (virDomainDelIOThread(dom, iothread_id, flags) < 0) + _croak_error(); + + int num_of_snapshots(dom, flags=0) virDomainPtr dom; diff --git a/lib/Sys/Virt/Domain.pm b/lib/Sys/Virt/Domain.pm index f12abd1..2fda74d 100644 --- a/lib/Sys/Virt/Domain.pm +++ b/lib/Sys/Virt/Domain.pm @@ -1237,6 +1237,18 @@ Pin the IOThread given by index C<$iothread> to physical CPUs given by C<$mask>. The C<$mask> is a string representing a bitmask against physical CPUs, 8 cpus per character. +=item $dom->add_iothread($iothread, $flags=0) + +Add a new IOThread by the C<$iothread> value to the guest domain. +The C<$flags> parameter accepts one or more the CONFIG OPTION constants +documented later, and defaults to 0 if omitted. + +=item $dom->del_iothread($iothread, $flags=0) + +Delete an existing IOThread by the C<$iothread> value from the guest domain. +The C<$flags> parameter accepts one or more the CONFIG OPTION constants +documented later, and defaults to 0 if omitted. + =item my @stats = $dom->get_cpu_stats($startCpu, $numCpus, $flags=0) Requests the guests host physical CPU usage statistics, starting -- 2.1.0

2 1

[libvirt] [PATCH] Add missing linker flags for MinGW build
by Pavel Fedin 28 Apr '15

28 Apr '15

This fix should completely close https://bugzilla.redhat.com/show_bug.cgi?id=1214605 Signed-off-by: Pavel Fedin <p.fedin(a)samsung.com> tests/Makefile.am | 40 +++++++++++++++++++++++++++------------- 1 file changed, 27 insertions(+), 13 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 09dc2cb..e69235b 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -553,7 +553,8 @@ qemuxml2argvmock_la_SOURCES = \ qemuxml2argvmock.c qemuxml2argvmock_la_CFLAGS = $(AM_CFLAGS) qemuxml2argvmock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation + -rpath /evil/libtool/hack/to/force/shared/lib/creation \ + $(MINGW_EXTRA_LDFLAGS) qemuxml2xmltest_SOURCES = \ qemuxml2xmltest.c testutilsqemu.c testutilsqemu.h \ @@ -614,7 +615,8 @@ qemucaps2xmlmock_la_SOURCES = \ qemucaps2xmlmock.c qemucaps2xmlmock_la_CFLAGS = $(AM_CFLAGS) qemucaps2xmlmock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation + -rpath /evil/libtool/hack/to/force/shared/lib/creation \ + $(MINGW_EXTRA_LDFLAGS) qemuagenttest_SOURCES = \ qemuagenttest.c \ @@ -722,7 +724,8 @@ bhyvexml2argvmock_la_SOURCES = \ bhyvexml2argvmock.c bhyvexml2argvmock_la_CFLAGS = $(AM_CFLAGS) bhyvexml2argvmock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation + -rpath /evil/libtool/hack/to/force/shared/lib/creation \ + $(MINGW_EXTRA_LDFLAGS) bhyve_LDADDS = ../src/libvirt_driver_bhyve_impl.la if WITH_STORAGE @@ -930,7 +933,9 @@ virnetserverclientmock_la_SOURCES = \ virnetserverclientmock.c virnetserverclientmock_la_CFLAGS = $(AM_CFLAGS) virnetserverclientmock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation + -rpath /evil/libtool/hack/to/force/shared/lib/creation \ + $(GNULIB_LIBS) \ + $(MINGW_EXTRA_LDFLAGS) if WITH_GNUTLS virnettlscontexttest_SOURCES = \ @@ -1009,7 +1014,8 @@ libvirportallocatormock_la_SOURCES = \ virportallocatortest.c libvirportallocatormock_la_CFLAGS = $(AM_CFLAGS) -DMOCK_HELPER=1 libvirportallocatormock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation + -rpath /evil/libtool/hack/to/force/shared/lib/creation \ + $(MINGW_EXTRA_LDFLAGS) vircgrouptest_SOURCES = \ vircgrouptest.c testutils.h testutils.c @@ -1019,7 +1025,8 @@ vircgroupmock_la_SOURCES = \ vircgroupmock.c vircgroupmock_la_CFLAGS = $(AM_CFLAGS) vircgroupmock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation + -rpath /evil/libtool/hack/to/force/shared/lib/creation \ + $(MINGW_EXTRA_LDFLAGS) vircryptotest_SOURCES = \ vircryptotest.c testutils.h testutils.c @@ -1039,7 +1046,8 @@ virpcimock_la_CFLAGS = $(AM_CFLAGS) virpcimock_la_LIBADD = $(GNULIB_LIBS) \ ../src/libvirt.la virpcimock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation + -rpath /evil/libtool/hack/to/force/shared/lib/creation \ + $(MINGW_EXTRA_LDFLAGS) virnetdevtest_SOURCES = \ virnetdevtest.c testutils.h testutils.c @@ -1052,7 +1060,8 @@ virnetdevmock_la_CFLAGS = $(AM_CFLAGS) $(LIBNL_CFLAGS) virnetdevmock_la_LIBADD = $(GNULIB_LIBS) \ ../src/libvirt.la virnetdevmock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation + -rpath /evil/libtool/hack/to/force/shared/lib/creation \ + $(MINGW_EXTRA_LDFLAGS) if WITH_LINUX virusbtest_SOURCES = \ @@ -1066,13 +1075,15 @@ virnetdevbandwidthtest_LDADD = $(LDADDS) $(LIBXML_LIBS) virusbmock_la_SOURCES = virusbmock.c virusbmock_la_CFLAGS = $(AM_CFLAGS) virusbmock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation + -rpath /evil/libtool/hack/to/force/shared/lib/creation \ + $(MINGW_EXTRA_LDFLAGS) virnetdevbandwidthmock_la_SOURCES = \ virnetdevbandwidthmock.c virnetdevbandwidthmock_la_CFLAGS = $(AM_CFLAGS) virnetdevbandwidthmock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation + -rpath /evil/libtool/hack/to/force/shared/lib/creation \ + $(MINGW_EXTRA_LDFLAGS) else ! WITH_LINUX EXTRA_DIST += virusbtest.c virusbmock.c \ @@ -1089,7 +1100,8 @@ virmockdbus_la_SOURCES = \ virmockdbus.c virmockdbus_la_CFLAGS = $(AM_CFLAGS) $(DBUS_CFLAGS) virmockdbus_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation + -rpath /evil/libtool/hack/to/force/shared/lib/creation \ + $(MINGW_EXTRA_LDFLAGS) virpolkittest_SOURCES = \ virpolkittest.c testutils.h testutils.c @@ -1136,7 +1148,8 @@ endif ! WITH_TESTS libsecurityselinuxhelper_la_SOURCES = \ securityselinuxhelper.c libsecurityselinuxhelper_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation + -rpath /evil/libtool/hack/to/force/shared/lib/creation \ + $(MINGW_EXTRA_LDFLAGS) securityselinuxtest_SOURCES = \ securityselinuxtest.c testutils.h testutils.c @@ -1209,7 +1222,8 @@ endif WITH_LIBVIRTD libshunload_la_SOURCES = shunloadhelper.c libshunload_la_LIBADD = ../src/libvirt.la libshunload_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation + -rpath /evil/libtool/hack/to/force/shared/lib/creation \ + $(MINGW_EXTRA_LDFLAGS) shunloadtest_SOURCES = \ shunloadtest.c Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia

2 8

[libvirt] FYI: Hacking on Sys::Virt libvirt Perl binding
by Daniel P. Berrange 28 Apr '15

28 Apr '15

Historically I have taken care of everything related to the Sys::Virt Perl binding for libvirt. Recently a couple of adventurous people have started sending patches too. Perl may have a reputation for being scary, but at this point extending the Sys::Virt binding when new APIs or constants are added is actually pretty straightforward. The majority of new libvirt APIs calls look very similar to one or more existing APIs, so you can usually get away with just doing a copy+paste job from some existing Perl API binding. To assist people in understanding how todo this, I've updated the HACKING file with some guidance. I'm including it inline here for reference. I'm not expecting everyone to submit Perl binding code for APIs they add. If people do submit binding code for new APIs though, it will be more than welcome - if not I'll continue to watch for changes and update things myself when required. Hacking on libvirt perl ======================= The libvirt Perl release versions are tied directly to the libvirt C library release versions. ie Sys::Virt 1.2.10 will require libvirt version 1.2.10 or newer in order to build. We do not aim to support conditional compilation against versions of libvirt that are older than the version of Sys::Virt. General changes for new APIs ---------------------------- Additions to the libvirt C API will require changes to a minimum of two parts of the Sys::Virt codebase. - Virt.xs - this provides the C glue code to access the libvirt C library APIs and constants from the Perl interpretor. As a general rule, every new function and header file constant/enum requires an addition to this file. The exceptions are functions that are only provided for the benefit of language bindings and not intended for use by application code. For example the reference counting APIs don't need exposing to Perl applications - lib/ - this directory contains the pure Perl part of the binding. There are separate files for each core libvirt object type - lib/Sys/Virt.pm - mapping for virConnectPtr - lib/Sys/Virt/Domain.pm - mapping for virDomainPtr - lib/Sys/Virt/Error.pm - mapping for virErrorPtr - lib/Sys/Virt/Event.pm - mapping for virEventPtr - lib/Sys/Virt/Interface.pm - mapping for virInterfacePtr - lib/Sys/Virt/Network.pm - mapping for virNetworkPtr - lib/Sys/Virt/NodeDevice.pm - mapping for virNodeDevicePtr - lib/Sys/Virt/NWFilter.pm - mapping for virNWFilterPtr - lib/Sys/Virt/Secret.pm - mapping for virSecretPtr - lib/Sys/Virt/StoragePool.pm - mapping for virStoragePoolPtr - lib/Sys/Virt/StorageVol.pm - mapping for virStorageVolPtr - lib/Sys/Virt/Stream.pm - mapping for virStreamPtr There is rarely a need to write Perl code in the .pm modules, as the mapping in the Virt.xs file is usually sufficient. As such the primary purpose of the .pm modules is to hold the POD inline documentation. Every function and constants is required to have full API documentation provided There are a number of unit tests available in the t/ directory which assist in creation of new APIs. - t/010-pod-coverage.t - ensures that every Perl method and constant has POD documentation present - t/030-api-coverage.t - ensures that every C library method/constant in the libvirt-api.xml file has corresponding code in the Virt.xs. Certain functions can be blacklisted in t/030-api-coverage.t as not needed mapping to Perl. This only runs if TEST_MAINTAINER=1 is set. - t/*.t - the other files mostly do functional testing against the test:///default API - if the new function has support in the test driver, then suitable additions should be made If use of the API is not obvious, it is often worth providing a small example program in the examples/ directory. These examples are also useful when adding APIs to ensure that they are operating correctly, if it wasn't possible to unit test them with test:///default. Every addition / change to the API must be documented in the Changes file. New API addition workflow ------------------------- When the libvirt C library is changed, the following workflow is an effective way to update the Perl binding. - Build the libvirt C library # cd $HOME/src/libvirt # ./autogen.sh --system # make - Configure & build the Sys::Virt module to build against the just built libvirt library # cd $HOME/src/libvirt-perl # ../libvirt/run perl Makefile.PL # ../libvirt/run make - Run the test suite to identify which new functions/constants need handling # ../libvirt/run make test TEST_MAINTAINER=1 - For each missing item reported in the test suite... - Edit Virt.xs to add the C binding - Edit lib/*.pm to add the POD documentation (and occassionally Perl glue code) - Edit Changes to document the addition - Run the test suite (without maintainer mode) to verify POD docs # ../libvirt/run make test - Optionally add to one of the t/*.t test cases - Optionally add demo to examples/ - Commit the changes to GIT Understanding Virt.xs glue layer -------------------------------- The Perl XS glue (Virt.xs) is a pretty bizarre language, that mostly looks like C but is actually run through a Perl specific preprocessor to turn it into real C code. Learning and understanding XS code well is a really difficult task, but fortunately such knowledge is rarely required in order to add new APIs to the Perl Sys::Virt code. When adding constants just look for the REGISTER_CONSTANT() macro at the end of Virt.xs. Make sure that the constant is registered against the correct Sys::Virt::XXXX object namespace - look for the adjacent 'gv_stashpv' calls to see which namespace is currently in effect. When adding methods, you must again make sure they are put in the correct object namespace. For methods, look for the statements that look like: MODULE = Sys::Virt::NWFilter PACKAGE = Sys::Virt::NWFilter these indicate the start of a namespace for the object in question. When implementing the binding for a method, if not already familiar with XS code, the best technique is to just do cut+paste programming. Find an existing libvirt API call that has the same kind of API signature as the new API. Then just copy the XS code for that method and tweak the parameter names as needed. Async event callbacks have a little bit of special handling too. The callbacks are all implemented as static methods at the very top of the Virt.XS file. Look for method names like _domain_event_pmsuspend_callback and just copy the code for an existing callback method that has a similar set of parameters to the new callback. Once the callback is implemented look for the domain_event_register_any() or network_event_register_any() methods and extend the switch() statement so that it maps the event ID constant to your new callback. Making new releases ------------------- The Sys::Virt releases are hosted on the Perl project CPAN infrastructure rather than libvirt.org 1. Build the new release of libvirt as an RPM and install it on the local machine. 2. Set the release date in the Changes file and commit the change 3. Tag the release with a GPG signed tag using vX.Y.Z syntax for the tag name git tag -s -m 'Release 1.2.14' v1.2.14 4. Clone the repository or run 'git clean -x -f -d' to ensure a 100% pristine state 5. Run autobuild.sh to test the full test suite and generate local RPMs. This results in Sys-Virt-1.2.14.tar.gz file being created 6. Take the src.rpm file that was just generated by autobuild.sh and run a scratch build against Fedora rawhide # cd $HOME/src/fedora/perl-Sys-Virt # fedpkg scratch-build --srpm /path/to/src/rpm/file 7. Push the Changes commit and tag to GIT master # git push # git push origin v1.2.14 If there is a failure at any step then this must be corrected as follows a. Delete the signed release tag git tag -d v1.2.14 b. Fix whatever the problem was and update the Changes file if appropriate c. Go to release process step 3 again. Assuming the release has now been made, the Sys-Virt-1.2.14.tar.gz file should be uploaded to CPAN using https://pause.cpan.org form. The upload is currently done by Daniel Berrange (username DANBERR). Now open the tree for the next release version by editing the files lib/Sys/Virt.pm, README, Makefile.PL to update the version number listed. Also edit Changes to add a placeholder entry for the new release number. Run 'make test' to ensure Changes file is syntax valid. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

1 0

[libvirt] [perl][PATCH 0/4] Fix coverage
by Michal Privoznik 28 Apr '15

28 Apr '15

In order to match the newish things in libvirt. Michal Privoznik (4): domain_event_register_any: Align the code Add support for VIR_DOMAIN_EVENT_ID_DEVICE_ADDED Add JOB_DOWNTIME_NET constant Add JOB_TIME_ELAPSED_NET constant Changes | 5 ++++- Virt.xs | 48 ++++++++++++++++++++++++++++++++++++++++++++++-- lib/Sys/Virt/Domain.pm | 16 ++++++++++++++++ t/030-api-coverage.t | 1 + 4 files changed, 67 insertions(+), 3 deletions(-) -- 2.0.5

2 8

[libvirt] [PATCH 0/2] IOThread algorithm followups
by John Ferlan 28 Apr '15

28 Apr '15

During Peter's review of the recent IOThreads Add/Del series he noted two outstanding issues: 1. The qemuDomainParseIOThreadAlias should be done within the context of the qemuMonitorJSONGetIOThreads and return an iothread_id instead of a name which must be parsed by everyone 2. The order of checks in qemuProcessDetectIOThreadPIDs to compare the returned niothreads against zero, should have been done after the comparison of whether the number returned matches what the domain expects. If the domain had expected some number of iothreads and none were returned, then that needs to be noted. For review details, see: http://www.redhat.com/archives/libvir-list/2015-April/msg01361.html John Ferlan (2): qemu: Remove need for qemuDomainParseIOThreadAlias qemu: qemuProcessDetectIOThreadPIDs invert checks src/qemu/qemu_command.c | 17 ----------------- src/qemu/qemu_command.h | 3 --- src/qemu/qemu_driver.c | 9 ++------- src/qemu/qemu_monitor.c | 1 - src/qemu/qemu_monitor.h | 2 +- src/qemu/qemu_monitor_json.c | 7 ++++++- src/qemu/qemu_process.c | 23 ++++++++++------------- tests/qemumonitorjsontest.c | 12 ++++++------ 8 files changed, 25 insertions(+), 49 deletions(-) -- 2.1.0

2 6

[libvirt] [PATCH] conf: explicitly initialize 'cpumask' variable
by Roman Bogorodskiy 28 Apr '15

28 Apr '15

Build with clang fails with: CC conf/libvirt_conf_la-domain_conf.lo conf/domain_conf.c:13377:9: error: variable 'cpumask' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized] if (!(tmp = virXMLPropString(node, "cpuset"))) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ and many other similar errors regarding the 'cpuset' variable. Fix by explicitly initializing it with NULL. --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0b18720..957221b 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -13342,7 +13342,7 @@ virDomainIOThreadPinDefParseXML(xmlNodePtr node, { int ret = -1; virDomainIOThreadIDDefPtr iothrid; - virBitmapPtr cpumask; + virBitmapPtr cpumask = NULL; xmlNodePtr oldnode = ctxt->node; unsigned int iothreadid; char *tmp = NULL; -- 2.3.5

2 2

[libvirt] [PATCH 0/2] skip names of devices already existing on host when auto-assigning bridge name
by Laine Stump 28 Apr '15

28 Apr '15

Shivaprasad Bhat earlier sent patches to fix this problem which added a call to virNetDevExists() in the conf directory: https://www.redhat.com/archives/libvir-list/2015-March/msg00397.html (V1) https://www.redhat.com/archives/libvir-list/2015-March/msg00569.html (V2) https://www.redhat.com/archives/libvir-list/2015-March/msg01174.html (V3) https://www.redhat.com/archives/libvir-list/2015-March/msg01297.html (V4) After discussing it with him a few times (both email and irc), I decided that the only way to really understand the problems he described (related to locking) with my counterproposal (do the checking in the bridge driver itself), was to try fixing it myself. I do now understand the problems he encountered with locking, but also found that the instance of the call to the "Find a bridge name and set it" function that caused the problem was unnecessary (see the commit message of patch 1). The first patch here essentially reimplements current functionality but moving the majority of the code from conf/network_conf.c to network/bridge_driver.c. The 2nd patch adds the all-important virNetDevExists() call to the function that is looking for an unused bridge name. Laine Stump (2): network: move auto-assign of bridge name from XML parser to net driver network: check for bridge name conflict with existing devices src/conf/network_conf.c | 60 --------------------------- src/conf/network_conf.h | 9 +---- src/libvirt_private.syms | 2 +- src/network/bridge_driver.c | 98 ++++++++++++++++++++++++++++++++++++++++++++- 4 files changed, 99 insertions(+), 70 deletions(-) -- 2.1.0

2 9

[libvirt] [PATCH 0/4] enable s390 support for crypto key mgmt operations
by akrowiak＠linux.vnet.ibm.com 27 Apr '15

27 Apr '15

From: Tony Krowiak <akrowiak(a)linux.vnet.ibm.com> The IBM System z Central Processor Assist for Cryptographic Functions (CPACF) hardware provides a set of CPU instructions for use in clear-key encryption, pseudo random number generation, hash functions, and protected-key encryption. The CPACF protected key cryptographic functions operate with a protected key that is encrypted under a unique wrapping key stored in the Hardware System Area (HSA) of the machine and can only be accessed by firmware. The wrapping key cannot be accessed by the operating system or application programs. There are two wrapping keys: One for wrapping AES keys and one for wrapping DEA/TDEA (DES/TDES) keys. This patch set enables the support for encrypting clear keys under the AES or DEA/TDEA wrapping key on a guest VM running on an s390 host that supports key wrapping. Tony Krowiak (4): libvirt: docs: XML to enable/disable protected key mgmt ops libvirt: conf: parse XML for protected key management ops libvirt: qemu: enable/disable protected key management ops libvirt: tests: test protected key mgmt ops support

1 0

[libvirt] [PATCH] test: Fix actual vs. expected in virtTestCompareFiles
by Laine Stump 27 Apr '15

27 Apr '15

Commit ca329299 added a utility function virtTestCompareFiles() to eliminate repetitive code in several test programs. It unfortunately calls virtTestDifference() with the arguments in the wrong order - strcontent is the "actual" output gathered by the test rig, while filecontent is the "expected", and virtTestDifference() wants expected (filecontent) followed by actual (strcontent), but virtTestCompareFiles() does the opposite, which can make the output a bit confusing when there is a failure. --- tests/testutils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/testutils.c b/tests/testutils.c index acb2ef1..6a8fe6a 100644 --- a/tests/testutils.c +++ b/tests/testutils.c @@ -1,7 +1,7 @@ /* * testutils.c: basic test utils * - * Copyright (C) 2005-2014 Red Hat, Inc. + * Copyright (C) 2005-2015 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -641,7 +641,7 @@ virtTestCompareToFile(const char *strcontent, goto failure; goto out; } - virtTestDifference(stderr, strcontent, filecontent); + virtTestDifference(stderr, filecontent, strcontent); goto failure; } -- 2.1.0

2 1

[libvirt] [PATCH v5 00/10] Implement Add/Del IOThreads
by John Ferlan 27 Apr '15

27 Apr '15

v4 here: http://www.redhat.com/archives/libvir-list/2015-April/msg01008.html I was asked to post a complete series by Peter, so rather than repeat v5 changes described here: http://www.redhat.com/archives/libvir-list/2015-April/msg01192.html John Ferlan (10): conf: Add new domain XML element 'iothreadids' qemu: Use domain iothreadids to IOThread's 'thread_id' conf: Move virDomainPinIsDuplicate and make static Move iothreadspin information into iothreadids conf: Adjust the iothreadsched expectations Implement virDomainAddIOThread and virDomainDelIOThread remote: Add support for AddIOThread and DelIOThread domain: Introduce virDomainIOThreadSchedDelId qemu: Add support to Add/Delete IOThreads virsh: Add iothreadadd and iothreaddel commands docs/formatdomain.html.in | 56 ++- docs/schemas/domaincommon.rng | 12 + include/libvirt/libvirt-domain.h | 6 + src/conf/domain_audit.c | 9 + src/conf/domain_audit.h | 6 + src/conf/domain_conf.c | 359 ++++++++++++--- src/conf/domain_conf.h | 27 +- src/driver-hypervisor.h | 12 + src/libvirt-domain.c | 118 +++++ src/libvirt_private.syms | 7 +- src/libvirt_public.syms | 6 + src/qemu/qemu_cgroup.c | 34 +- src/qemu/qemu_command.c | 38 +- src/qemu/qemu_command.h | 3 + src/qemu/qemu_domain.c | 36 -- src/qemu/qemu_domain.h | 3 - src/qemu/qemu_driver.c | 486 +++++++++++++++++---- src/qemu/qemu_process.c | 43 +- src/remote/remote_driver.c | 2 + src/remote/remote_protocol.x | 30 +- src/remote_protocol-structs | 12 + .../qemuxml2argv-cputune-iothreadsched-toomuch.xml | 3 +- .../qemuxml2argv-iothreads-ids-partial.args | 10 + .../qemuxml2argv-iothreads-ids-partial.xml | 33 ++ .../qemuxml2argv-iothreads-ids.args | 8 + .../qemuxml2argv-iothreads-ids.xml | 33 ++ tests/qemuxml2argvtest.c | 2 + .../qemuxml2xmlout-cputune-iothreads.xml | 2 +- tests/qemuxml2xmltest.c | 2 + tools/virsh-domain.c | 164 +++++++ tools/virsh.pod | 31 ++ 31 files changed, 1333 insertions(+), 260 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-ids-partial.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-ids-partial.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-ids.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-ids.xml -- 2.1.0

2 32

[libvirt] [PATCH] qemu: Resolve Coverity DEADCODE
by John Ferlan 27 Apr '15

27 Apr '15

Coverity notes taht the switch() used to check 'connected' values has two DEADCODE paths (_DEFAULT & _LAST). Since 'connected' is a boolean it can only be one or the other (CONNECTED or DISCONNECTED), so it just seems pointless to use a switch to get "all" values. Convert to if-else Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- src/qemu/qemu_driver.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 31cbccb..1c72844 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -4497,8 +4497,7 @@ processSerialChangedEvent(virQEMUDriverPtr driver, goto endjob; if (STREQ_NULLABLE(dev.data.chr->target.name, "org.qemu.guest_agent.0")) { - switch (newstate) { - case VIR_DOMAIN_CHR_DEVICE_STATE_CONNECTED: + if (newstate == VIR_DOMAIN_CHR_DEVICE_STATE_CONNECTED) { if (!priv->agent) { if ((rc = qemuConnectAgent(driver, vm)) == -2) goto endjob; @@ -4506,20 +4505,13 @@ processSerialChangedEvent(virQEMUDriverPtr driver, if (rc < 0) priv->agentError = true; } - break; - - case VIR_DOMAIN_CHR_DEVICE_STATE_DISCONNECTED: + } else { if (priv->agent) { qemuAgentClose(priv->agent); priv->agent = NULL; priv->agentError = false; } - break; - - case VIR_DOMAIN_CHR_DEVICE_STATE_DEFAULT: - case VIR_DOMAIN_CHR_DEVICE_STATE_LAST: - break; - }; + } if ((event = virDomainEventAgentLifecycleNewFromObj(vm, newstate, VIR_CONNECT_DOMAIN_EVENT_AGENT_LIFECYCLE_REASON_CHANNEL))) -- 2.1.0

3 5

[libvirt] KVM Forum 2015 Call for Participation
by Paolo Bonzini 27 Apr '15

27 Apr '15

================================================================= KVM Forum 2015: Call For Participation August 19-21, 2015 - Sheraton Seattle - Seattle, WA (All submissions must be received before midnight May 1, 2015) ================================================================= KVM is an industry leading open source hypervisor that provides an ideal platform for datacenter virtualization, virtual desktop infrastructure, and cloud computing. Once again, it's time to bring together the community of developers and users that define the KVM ecosystem for our annual technical conference. We will discuss the current state of affairs and plan for the future of KVM, its surrounding infrastructure, and management tools. Mark your calendar and join us in advancing KVM. http://events.linuxfoundation.org/events/kvm-forum/ This year, the KVM Forum is moving back to North America. We will be colocated with the Linux Foundation's LinuxCon North America, CloudOpen North America, ContainerCon and Linux Plumbers Conference events. Attendees of KVM Forum will also be able to attend a shared hackathon event with Xen Project Developer Summit on August 18, 2015. We invite you to lead part of the discussion by submitting a speaking proposal for KVM Forum 2015. http://events.linuxfoundation.org/cfp Suggested topics: KVM/Kernel * Scaling and optimizations * Nested virtualization * Linux kernel performance improvements * Resource management (CPU, I/O, memory) * Hardening and security * VFIO: SR-IOV, GPU, platform device assignment * Architecture ports QEMU * Management interfaces: QOM and QMP * New devices, new boards, new architectures * Scaling and optimizations * Desktop virtualization and SPICE * Virtual GPU * virtio and vhost, including non-Linux or non-virtualized uses * Hardening and security * New storage features * Live migration and fault tolerance * High availability and continuous backup * Real-time guest support * Emulation and TCG * Firmware: ACPI, UEFI, coreboot, u-Boot, etc. * Testing Management and infrastructure * Managing KVM: Libvirt, OpenStack, oVirt, etc. * Storage: glusterfs, Ceph, etc. * Software defined networking: Open vSwitch, OpenDaylight, etc. * Network Function Virtualization * Security * Provisioning * Performance tuning =============== SUBMITTING YOUR PROPOSAL =============== Abstracts due: May 1, 2015 Please submit a short abstract (~150 words) describing your presentation proposal. Slots vary in length up to 45 minutes. Also include in your proposal the proposal type -- one of: - technical talk - end-user talk Submit your proposal here: http://events.linuxfoundation.org/cfp Please only use the categories "presentation" and "panel discussion" You will receive a notification whether or not your presentation proposal was accepted by May 29, 2015. Speakers will receive a complimentary pass for the event. In the instance that your submission has multiple presenters, only the primary speaker for a proposal will receive a complementary event pass. For panel discussions, all panelists will receive a complimentary event pass. TECHNICAL TALKS A good technical talk should not just report on what has happened over the last year; it should present a concrete problem and how it impacts the user and/or developer community. Whenever applicable, focus on work that needs to be done, difficulties that haven't yet been solved, and on decisions that other developers should be aware of. Summarizing recent developments is okay but it should not be more than a small portion of the overall talk. END-USER TALKS One of the big challenges as developers is to know what, where and how people actually use our software. We will reserve a few slots for end users talking about their deployment challenges and achievements. If you are using KVM in production you are encouraged submit a speaking proposal. Simply mark it as an end-user talk. As an end user, this is a unique opportunity to get your input to developers. HANDS-ON / BOF SESSIONS We will reserve some time for people to get together and discuss strategic decisions as well as other topics that are best solved within smaller groups. These sessions will be announced during the event. If you are interested in organizing such a session, please add it to the list at http://www.linux-kvm.org/page/KVM_Forum_2015_BOF Let people you think might be interested know about it, and encourage them to add their names to the wiki page as well. Please try to add your ideas to the list before KVM Forum starts. PANEL DISCUSSIONS If you are proposing a panel discussion, please make sure that you list all of your potential panelists in your abstract. We will request full biographies if a panel is accepted. =============== HOTEL / TRAVEL =============== KVM Forum 2015 will be taking place at the Sheraton Seattle Hotel. We are pleased to offer attendees a discounted room rate of US$199/night (plus applicable taxes) which includes wifi in your guest room. http://events.linuxfoundation.org/events/kvm-forum/attend/hotel-and-travel includes further information on the Sheraton Seattle and the discounted room rate, as well as on transportation and parking options for the hotel. =============== IMPORTANT DATES =============== Notification: May 29, 2015 Schedule announced: June 3, 2015 Event dates: August 19-21, 2015 Thank you for your interest in KVM. We're looking forward to your submissions and seeing you at the KVM Forum 2015 in August! -your KVM Forum 2015 Program Committee Please contact us with any questions or comments.

2 1

[libvirt] [PATCH] Do not inline virNumaNodeIsAvailable
by Ján Tomko 27 Apr '15

27 Apr '15

Explicitly request that virNumaNodeIsAvailable not be inlined. This fixes the test suite when building with clang (3.5.1). --- This only leaves the mysterious check-protocol failure. And too large stack frame size when building the tests with -O0. src/internal.h | 10 ++++++++++ src/util/virnuma.h | 3 ++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/internal.h b/src/internal.h index 4d473af..84aa330 100644 --- a/src/internal.h +++ b/src/internal.h @@ -139,6 +139,16 @@ # endif /** + * ATTRIBUTE_NOINLINE: + * + * Macro to indicate a function that cannot be inlined + * (e.g. a function that is mocked in the test suite) + */ +# ifndef ATTRIBUTE_NOINLINE +# define ATTRIBUTE_NOINLINE __attribute__((__noinline__)) +# endif + +/** * ATTRIBUTE_SENTINEL: * * Macro to check for NULL-terminated varargs lists diff --git a/src/util/virnuma.h b/src/util/virnuma.h index 1f3c0ad..4ddcc5a 100644 --- a/src/util/virnuma.h +++ b/src/util/virnuma.h @@ -37,7 +37,8 @@ virBitmapPtr virNumaGetHostNodeset(void); bool virNumaNodesetIsAvailable(virBitmapPtr nodeset); bool virNumaIsAvailable(void); int virNumaGetMaxNode(void); -bool virNumaNodeIsAvailable(int node); +bool virNumaNodeIsAvailable(int node) + ATTRIBUTE_NOINLINE; int virNumaGetDistances(int node, int **distances, int *ndistances); -- 2.0.5

4 11

[libvirt] [PATCH] Cleanup parameters for mock libraries
by Martin Kletzander 27 Apr '15

27 Apr '15

All the libraries use same parameters when building, why not have it in one place at the begining of the Makefile. This will also ensure no new mock library will have a problem with missing e.g. MINGW_EXTRA_LDFLAGS. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- tests/Makefile.am | 58 +++++++++++++++++-------------------------------------- 1 file changed, 18 insertions(+), 40 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 03c2c8a..dc7daaa 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -1,6 +1,6 @@ ## Process this file with automake to produce Makefile.in -## Copyright (C) 2005-2014 Red Hat, Inc. +## Copyright (C) 2005-2015 Red Hat, Inc. ## ## This library is free software; you can redistribute it and/or ## modify it under the terms of the GNU Lesser General Public @@ -47,6 +47,10 @@ AM_CFLAGS = \ AM_LDFLAGS = \ -export-dynamic +MOCKLIBS_LDFLAGS = -module -avoid-version \ + -rpath /evil/libtool/hack/to/force/shared/lib/creation \ + $(MINGW_EXTRA_LDFLAGS) + if WITH_DRIVER_MODULES INCLUDES += \ -DTEST_DRIVER_DIR=\"$(top_builddir)/src/.libs\" @@ -552,9 +556,7 @@ qemuxml2argvtest_LDADD = $(qemu_LDADDS) $(LDADDS) $(LIBXML_LIBS) qemuxml2argvmock_la_SOURCES = \ qemuxml2argvmock.c qemuxml2argvmock_la_CFLAGS = $(AM_CFLAGS) -qemuxml2argvmock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation \ - $(MINGW_EXTRA_LDFLAGS) +qemuxml2argvmock_la_LDFLAGS = $(MOCKLIBS_LDFLAGS) qemuxml2xmltest_SOURCES = \ qemuxml2xmltest.c testutilsqemu.c testutilsqemu.h \ @@ -614,9 +616,7 @@ qemucaps2xmltest_LDADD = $(qemu_LDADDS) $(LDADDS) qemucaps2xmlmock_la_SOURCES = \ qemucaps2xmlmock.c qemucaps2xmlmock_la_CFLAGS = $(AM_CFLAGS) -qemucaps2xmlmock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation \ - $(MINGW_EXTRA_LDFLAGS) +qemucaps2xmlmock_la_LDFLAGS = $(MOCKLIBS_LDFLAGS) qemuagenttest_SOURCES = \ qemuagenttest.c \ @@ -723,9 +723,7 @@ if WITH_BHYVE bhyvexml2argvmock_la_SOURCES = \ bhyvexml2argvmock.c bhyvexml2argvmock_la_CFLAGS = $(AM_CFLAGS) -bhyvexml2argvmock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation \ - $(MINGW_EXTRA_LDFLAGS) +bhyvexml2argvmock_la_LDFLAGS = $(MOCKLIBS_LDFLAGS) bhyve_LDADDS = ../src/libvirt_driver_bhyve_impl.la if WITH_STORAGE @@ -932,9 +930,7 @@ virnetserverclienttest_LDADD = $(LDADDS) virnetserverclientmock_la_SOURCES = \ virnetserverclientmock.c virnetserverclientmock_la_CFLAGS = $(AM_CFLAGS) -virnetserverclientmock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation \ - $(MINGW_EXTRA_LDFLAGS) +virnetserverclientmock_la_LDFLAGS = $(MOCKLIBS_LDFLAGS) if WITH_GNUTLS virnettlscontexttest_SOURCES = \ @@ -1012,9 +1008,7 @@ virportallocatortest_LDADD = $(LDADDS) libvirportallocatormock_la_SOURCES = \ virportallocatortest.c libvirportallocatormock_la_CFLAGS = $(AM_CFLAGS) -DMOCK_HELPER=1 -libvirportallocatormock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation \ - $(MINGW_EXTRA_LDFLAGS) +libvirportallocatormock_la_LDFLAGS = $(MOCKLIBS_LDFLAGS) vircgrouptest_SOURCES = \ vircgrouptest.c testutils.h testutils.c @@ -1023,9 +1017,7 @@ vircgrouptest_LDADD = $(LDADDS) vircgroupmock_la_SOURCES = \ vircgroupmock.c vircgroupmock_la_CFLAGS = $(AM_CFLAGS) -vircgroupmock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation \ - $(MINGW_EXTRA_LDFLAGS) +vircgroupmock_la_LDFLAGS = $(MOCKLIBS_LDFLAGS) vircryptotest_SOURCES = \ vircryptotest.c testutils.h testutils.c @@ -1044,9 +1036,7 @@ virpcimock_la_SOURCES = \ virpcimock_la_CFLAGS = $(AM_CFLAGS) virpcimock_la_LIBADD = $(GNULIB_LIBS) \ ../src/libvirt.la -virpcimock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation \ - $(MINGW_EXTRA_LDFLAGS) +virpcimock_la_LDFLAGS = $(MOCKLIBS_LDFLAGS) virnetdevtest_SOURCES = \ virnetdevtest.c testutils.h testutils.c @@ -1058,9 +1048,7 @@ virnetdevmock_la_SOURCES = \ virnetdevmock_la_CFLAGS = $(AM_CFLAGS) $(LIBNL_CFLAGS) virnetdevmock_la_LIBADD = $(GNULIB_LIBS) \ ../src/libvirt.la -virnetdevmock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation \ - $(MINGW_EXTRA_LDFLAGS) +virnetdevmock_la_LDFLAGS = $(MOCKLIBS_LDFLAGS) if WITH_LINUX virusbtest_SOURCES = \ @@ -1073,16 +1061,12 @@ virnetdevbandwidthtest_LDADD = $(LDADDS) $(LIBXML_LIBS) virusbmock_la_SOURCES = virusbmock.c virusbmock_la_CFLAGS = $(AM_CFLAGS) -virusbmock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation \ - $(MINGW_EXTRA_LDFLAGS) +virusbmock_la_LDFLAGS = $(MOCKLIBS_LDFLAGS) virnetdevbandwidthmock_la_SOURCES = \ virnetdevbandwidthmock.c virnetdevbandwidthmock_la_CFLAGS = $(AM_CFLAGS) -virnetdevbandwidthmock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation \ - $(MINGW_EXTRA_LDFLAGS) +virnetdevbandwidthmock_la_LDFLAGS = $(MOCKLIBS_LDFLAGS) else ! WITH_LINUX EXTRA_DIST += virusbtest.c virusbmock.c \ @@ -1098,9 +1082,7 @@ virdbustest_LDADD = $(LDADDS) $(DBUS_LIBS) virmockdbus_la_SOURCES = \ virmockdbus.c virmockdbus_la_CFLAGS = $(AM_CFLAGS) $(DBUS_CFLAGS) -virmockdbus_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation \ - $(MINGW_EXTRA_LDFLAGS) +virmockdbus_la_LDFLAGS = $(MOCKLIBS_LDFLAGS) virpolkittest_SOURCES = \ virpolkittest.c testutils.h testutils.c @@ -1146,9 +1128,7 @@ endif ! WITH_TESTS libsecurityselinuxhelper_la_SOURCES = \ securityselinuxhelper.c -libsecurityselinuxhelper_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation \ - $(MINGW_EXTRA_LDFLAGS) +libsecurityselinuxhelper_la_LDFLAGS = $(MOCKLIBS_LDFLAGS) securityselinuxtest_SOURCES = \ securityselinuxtest.c testutils.h testutils.c @@ -1220,9 +1200,7 @@ endif WITH_LIBVIRTD libshunload_la_SOURCES = shunloadhelper.c libshunload_la_LIBADD = ../src/libvirt.la -libshunload_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation \ - $(MINGW_EXTRA_LDFLAGS) +libshunload_la_LDFLAGS = $(MOCKLIBS_LDFLAGS) shunloadtest_SOURCES = \ shunloadtest.c -- 2.3.6

2 1

[libvirt] [PATCH] Fix building virnetserverclientmock with MinGW
by Martin Kletzander 27 Apr '15

27 Apr '15

Signed-off-by: Pavel Fedin <p.fedin(a)samsung.com> Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index dc7daaa..e3ba12b 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -931,6 +931,7 @@ virnetserverclientmock_la_SOURCES = \ virnetserverclientmock.c virnetserverclientmock_la_CFLAGS = $(AM_CFLAGS) virnetserverclientmock_la_LDFLAGS = $(MOCKLIBS_LDFLAGS) +virnetserverclientmock_la_LDADDS = $(GNULIB_LIBS) if WITH_GNUTLS virnettlscontexttest_SOURCES = \ -- 2.3.6

1 1

[libvirt] [PATCH] util: fix memleak in virStorageSourceClear
by zhang bo 27 Apr '15

27 Apr '15

snapshot and configFile are not freed, free them. Signed-off-by: Zhang Bo <oscar.zhangbo(a)huawei.com> --- src/util/virstoragefile.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index 9507ca1..6c3017c 100644 --- a/src/util/virstoragefile.c +++ b/src/util/virstoragefile.c @@ -2038,6 +2038,8 @@ virStorageSourceClear(virStorageSourcePtr def) VIR_FREE(def->path); VIR_FREE(def->volume); + VIR_FREE(def->snapshot); + VIR_FREE(def->configFile); virStorageSourcePoolDefFree(def->srcpool); VIR_FREE(def->driverName); virBitmapFree(def->features); -- 1.7.12.4

2 1

[libvirt] [PATCH] Cleanup srcdir usage
by Michal Privoznik 27 Apr '15

27 Apr '15

In a lot places we use path like this: $(srcdir)/../src/.... when in fact it can be: $(top_srcdir)/src/ Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- daemon/Makefile.am | 12 ++++++------ docs/Makefile.am | 50 ++++++++++++++++++++++++------------------------ src/Makefile.am | 2 +- tests/schematestutils.sh | 2 +- 4 files changed, 33 insertions(+), 33 deletions(-) diff --git a/daemon/Makefile.am b/daemon/Makefile.am index bceaeb2..300b9a5 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -77,21 +77,21 @@ REMOTE_PROTOCOL = $(top_srcdir)/src/remote/remote_protocol.x LXC_PROTOCOL = $(top_srcdir)/src/remote/lxc_protocol.x QEMU_PROTOCOL = $(top_srcdir)/src/remote/qemu_protocol.x -remote_dispatch.h: $(srcdir)/../src/rpc/gendispatch.pl \ +remote_dispatch.h: $(top_srcdir)/src/rpc/gendispatch.pl \ $(REMOTE_PROTOCOL) - $(AM_V_GEN)$(PERL) -w $(srcdir)/../src/rpc/gendispatch.pl \ + $(AM_V_GEN)$(PERL) -w $(top_srcdir)/src/rpc/gendispatch.pl \ --mode=server remote REMOTE $(REMOTE_PROTOCOL) \ > $(srcdir)/remote_dispatch.h -lxc_dispatch.h: $(srcdir)/../src/rpc/gendispatch.pl \ +lxc_dispatch.h: $(top_srcdir)/src/rpc/gendispatch.pl \ $(LXC_PROTOCOL) - $(AM_V_GEN)$(PERL) -w $(srcdir)/../src/rpc/gendispatch.pl \ + $(AM_V_GEN)$(PERL) -w $(top_srcdir)/src/rpc/gendispatch.pl \ --mode=server lxc LXC $(LXC_PROTOCOL) \ > $(srcdir)/lxc_dispatch.h -qemu_dispatch.h: $(srcdir)/../src/rpc/gendispatch.pl \ +qemu_dispatch.h: $(top_srcdir)/src/rpc/gendispatch.pl \ $(QEMU_PROTOCOL) - $(AM_V_GEN)$(PERL) -w $(srcdir)/../src/rpc/gendispatch.pl \ + $(AM_V_GEN)$(PERL) -w $(top_srcdir)/src/rpc/gendispatch.pl \ --mode=server qemu QEMU $(QEMU_PROTOCOL) \ > $(srcdir)/qemu_dispatch.h diff --git a/docs/Makefile.am b/docs/Makefile.am index a497256..f43da93 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -199,10 +199,10 @@ todo: hvsupport.html:: $(srcdir)/hvsupport.html.in $(srcdir)/hvsupport.html.in: $(srcdir)/hvsupport.pl $(api_DATA) \ - $(srcdir)/../src/libvirt_public.syms \ - $(srcdir)/../src/libvirt_qemu.syms $(srcdir)/../src/libvirt_lxc.syms \ - $(srcdir)/../src/driver.h - $(AM_V_GEN)$(PERL) $(srcdir)/hvsupport.pl $(srcdir)/../src > $@ \ + $(top_srcdir)/src/libvirt_public.syms \ + $(top_srcdir)/src/libvirt_qemu.syms $(top_srcdir)/src/libvirt_lxc.syms \ + $(top_srcdir)/src/driver.h + $(AM_V_GEN)$(PERL) $(srcdir)/hvsupport.pl $(top_srcdir)/src > $@ \ || { rm $@ && exit 1; } .PHONY: todo @@ -290,27 +290,27 @@ EXTRA_DIST += $(APIBUILD_STAMP) $(python_generated_files): $(APIBUILD_STAMP) $(APIBUILD_STAMP): $(srcdir)/apibuild.py \ - $(srcdir)/../include/libvirt/libvirt.h.in \ - $(srcdir)/../include/libvirt/libvirt-domain-snapshot.h \ - $(srcdir)/../include/libvirt/libvirt-domain.h \ - $(srcdir)/../include/libvirt/libvirt-event.h \ - $(srcdir)/../include/libvirt/libvirt-host.h \ - $(srcdir)/../include/libvirt/libvirt-interface.h \ - $(srcdir)/../include/libvirt/libvirt-network.h \ - $(srcdir)/../include/libvirt/libvirt-nodedev.h \ - $(srcdir)/../include/libvirt/libvirt-nwfilter.h \ - $(srcdir)/../include/libvirt/libvirt-secret.h \ - $(srcdir)/../include/libvirt/libvirt-storage.h \ - $(srcdir)/../include/libvirt/libvirt-stream.h \ - $(srcdir)/../include/libvirt/libvirt-lxc.h \ - $(srcdir)/../include/libvirt/libvirt-qemu.h \ - $(srcdir)/../include/libvirt/virterror.h \ - $(srcdir)/../src/libvirt.c \ - $(srcdir)/../src/libvirt-lxc.c \ - $(srcdir)/../src/libvirt-qemu.c \ - $(srcdir)/../src/util/virerror.c \ - $(srcdir)/../src/util/virevent.c \ - $(srcdir)/../src/util/virtypedparam.c + $(top_srcdir)/include/libvirt/libvirt.h.in \ + $(top_srcdir)/include/libvirt/libvirt-domain-snapshot.h \ + $(top_srcdir)/include/libvirt/libvirt-domain.h \ + $(top_srcdir)/include/libvirt/libvirt-event.h \ + $(top_srcdir)/include/libvirt/libvirt-host.h \ + $(top_srcdir)/include/libvirt/libvirt-interface.h \ + $(top_srcdir)/include/libvirt/libvirt-network.h \ + $(top_srcdir)/include/libvirt/libvirt-nodedev.h \ + $(top_srcdir)/include/libvirt/libvirt-nwfilter.h \ + $(top_srcdir)/include/libvirt/libvirt-secret.h \ + $(top_srcdir)/include/libvirt/libvirt-storage.h \ + $(top_srcdir)/include/libvirt/libvirt-stream.h \ + $(top_srcdir)/include/libvirt/libvirt-lxc.h \ + $(top_srcdir)/include/libvirt/libvirt-qemu.h \ + $(top_srcdir)/include/libvirt/virterror.h \ + $(top_srcdir)/src/libvirt.c \ + $(top_srcdir)/src/libvirt-lxc.c \ + $(top_srcdir)/src/libvirt-qemu.c \ + $(top_srcdir)/src/util/virerror.c \ + $(top_srcdir)/src/util/virevent.c \ + $(top_srcdir)/src/util/virtypedparam.c $(AM_V_GEN)srcdir=$(srcdir) $(PYTHON) $(APIBUILD) touch $@ diff --git a/src/Makefile.am b/src/Makefile.am index 33ee723..17cf318 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -20,7 +20,7 @@ abs_builddir = $(shell pwd) abs_topbuilddir = $(shell cd .. && pwd) abs_srcdir = $(shell cd $(srcdir) && pwd) -abs_topsrcdir = $(shell cd $(srcdir)/.. && pwd) +abs_topsrcdir = $(shell cd $(top_srcdir) && pwd) # No libraries with the exception of LIBXML should be listed # here. List them against the individual XXX_la_CFLAGS targets diff --git a/tests/schematestutils.sh b/tests/schematestutils.sh index a0ff77e..e07e9b9 100644 --- a/tests/schematestutils.sh +++ b/tests/schematestutils.sh @@ -5,7 +5,7 @@ check_schema () { DIRS=$1 -SCHEMA="$abs_srcdir/../docs/schemas/$2" +SCHEMA="$abs_top_srcdir/docs/schemas/$2" test_intro $this_test -- 2.0.5

2 1

[libvirt] [PATCH] qemu: Fix the crash in qemuDomainBlockCopyCommon
by Shanzhi Yu 27 Apr '15

27 Apr '15

The crash caused when checking the backing file path of a disk while the disk has no backing file, add a check before using disk->src->backingStore->path Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1215569 --- src/qemu/qemu_driver.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 70bf7aa..175d00b 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -16816,6 +16816,15 @@ qemuDomainBlockCopyCommon(virDomainObjPtr vm, goto endjob; if ((flags & VIR_DOMAIN_BLOCK_COPY_SHALLOW) && + !disk->src->backingStore) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("disk '%s' has no backing file, so shallow copy " + "is not possible"), + disk->src->path); + goto endjob; + } + + if ((flags & VIR_DOMAIN_BLOCK_COPY_SHALLOW) && mirror->format == VIR_STORAGE_FILE_RAW && disk->src->backingStore->path) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, -- 2.1.0

2 2

[libvirt] question: any conference available?
by zhang bo 27 Apr '15

27 Apr '15

Besides the maillist and IRC, are there any other means of communication available for libvirt? I'm much concerned about scheduled conference, including online conferences(weekly? monthly?) or face-to-face conference. so that developers from all around could join together to share about libvirt's roadmap, release plan, etc. Thank you for your reply in advance.

2 1

[libvirt] [PATCH] Fix check for return value of qemuDomainAgentAvailable()
by Martin Kletzander 27 Apr '15

27 Apr '15

Commit dcbb243bbc3470431d15cec4c5bb96d2de89a88b used the return value of the function as int even though it returns bool. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 70bf7aa..31cbccb 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -19829,7 +19829,7 @@ qemuDomainInterfaceAddresses(virDomainPtr dom, if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_QUERY) < 0) goto cleanup; - if (qemuDomainAgentAvailable(vm, true) < 0) + if (!qemuDomainAgentAvailable(vm, true)) goto endjob; qemuDomainObjEnterAgent(vm); -- 2.3.6

2 1

[libvirt] [PATCH 0/6] fix a serial of memleaks
by Zhang Bo 27 Apr '15

27 Apr '15

Zhang Bo (6): tests: fix some memleaks in tests util: fix memleak in virFindSCSIHostByPCI qemu: fix memleaks in qemuBuildCommandLine qemu: fix memleak in virCapabilitiesDomainDataLookup conf: fix memleak in virDomainNetIpParseXML conf: fix memleak in virDomainHostdevDefClear src/conf/capabilities.c | 5 +++-- src/conf/domain_conf.c | 18 ++++++++++-------- src/qemu/qemu_command.c | 2 ++ src/util/virutil.c | 3 +++ tests/commandtest.c | 1 + tests/domaincapstest.c | 1 + tests/qemucommandutiltest.c | 1 + 7 files changed, 21 insertions(+), 10 deletions(-) -- 1.7.12.4

2 8

[libvirt] [PATCH] qemu: Fix comment for timeDelta
by Jiri Denemark 27 Apr '15

27 Apr '15

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- Pushed as trivial. src/qemu/qemu_domain.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index 76a4819..1d3c77a 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -107,7 +107,7 @@ struct _qemuDomainJobInfo { /* Computed values */ unsigned long long timeElapsed; unsigned long long timeRemaining; - long long timeDelta; /* delta = sent - received, i.e., the difference + long long timeDelta; /* delta = received - sent, i.e., the difference between the source and the destination time plus the time between the end of Perform phase on the source and the beginning of Finish phase on the -- 2.3.5

1 0

[libvirt] [PATCH] migration: Usable time statistics without requiring NTP
by Jiri Denemark 27 Apr '15

27 Apr '15

virDomainGetJobStats is able to report statistics of a completed migration, however to get usable downtime and total time statistics both hosts have to keep synchronized time. To provide at least some estimation of the times even when NTP daemons are not running on both hosts we can just ignore the time needed to transfer a migration cookie to the destination host. The result will be also inaccurate but a bit more predictable. The total/down time will just be at least what we report. https://bugzilla.redhat.com/show_bug.cgi?id=1213434 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- include/libvirt/libvirt-domain.h | 23 ++++++++++++++++++++++- src/qemu/qemu_domain.c | 15 +++++++++++++++ src/qemu/qemu_domain.h | 9 +++++++++ src/qemu/qemu_migration.c | 26 +++++++++++++------------- tools/virsh-domain.c | 16 ++++++++++++++++ 5 files changed, 75 insertions(+), 14 deletions(-) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index 8a4fe53..5c0a382 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -2548,6 +2548,16 @@ int virDomainAbortJob(virDomainPtr dom); # define VIR_DOMAIN_JOB_TIME_ELAPSED "time_elapsed" /** + * VIR_DOMAIN_JOB_TIME_ELAPSED_NET: + * + * virDomainGetJobStats field: time (ms) since the beginning of the + * migration job NOT including the time required to transfer control + * flow from the source host to the destination host, + * as VIR_TYPED_PARAM_ULLONG. + */ +# define VIR_DOMAIN_JOB_TIME_ELAPSED_NET "time_elapsed_net" + +/** * VIR_DOMAIN_JOB_TIME_REMAINING: * * virDomainGetJobStats field: remaining time (ms) for VIR_DOMAIN_JOB_BOUNDED @@ -2561,11 +2571,22 @@ int virDomainAbortJob(virDomainPtr dom); * VIR_DOMAIN_JOB_DOWNTIME: * * virDomainGetJobStats field: downtime (ms) that is expected to happen - * during migration, as VIR_TYPED_PARAM_ULLONG. + * during migration, as VIR_TYPED_PARAM_ULLONG. The real computed downtime + * between the time guest CPUs were paused and the time they were resumed + * is reported for completed migration. */ # define VIR_DOMAIN_JOB_DOWNTIME "downtime" /** + * VIR_DOMAIN_JOB_DOWNTIME_NET: + * + * virDomainGetJobStats field: real measured downtime (ms) NOT including + * the time required to transfer control flow from the source host to the + * destination host, as VIR_TYPED_PARAM_ULLONG. + */ +# define VIR_DOMAIN_JOB_DOWNTIME_NET "downtime_net" + +/** * VIR_DOMAIN_JOB_SETUP_TIME: * * virDomainGetJobStats field: total time in milliseconds spent preparing diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 1368386..ff223a0 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -288,6 +288,13 @@ qemuDomainJobInfoToParams(qemuDomainJobInfoPtr jobInfo, jobInfo->timeElapsed) < 0) goto error; + if (jobInfo->timeDelta && + jobInfo->timeElapsed > jobInfo->timeDelta && + virTypedParamsAddULLong(&par, &npar, &maxpar, + VIR_DOMAIN_JOB_TIME_ELAPSED_NET, + jobInfo->timeElapsed - jobInfo->timeDelta) < 0) + goto error; + if (jobInfo->type == VIR_DOMAIN_JOB_BOUNDED && virTypedParamsAddULLong(&par, &npar, &maxpar, VIR_DOMAIN_JOB_TIME_REMAINING, @@ -300,6 +307,14 @@ qemuDomainJobInfoToParams(qemuDomainJobInfoPtr jobInfo, status->downtime) < 0) goto error; + if (status->downtime_set && + jobInfo->timeDelta && + status->downtime > jobInfo->timeDelta && + virTypedParamsAddULLong(&par, &npar, &maxpar, + VIR_DOMAIN_JOB_DOWNTIME_NET, + status->downtime - jobInfo->timeDelta) < 0) + goto error; + if (status->setup_time_set && virTypedParamsAddULLong(&par, &npar, &maxpar, VIR_DOMAIN_JOB_SETUP_TIME, diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index 6bea7c7..1b93f7d 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -100,9 +100,18 @@ struct _qemuDomainJobInfo { virDomainJobType type; unsigned long long started; /* When the async job started */ unsigned long long stopped; /* When the domain's CPUs were stopped */ + unsigned long long sent; /* When the source sent status info to the + destination (only for migrations). */ + unsigned long long received; /* When the destination host received status + info from the source (migrations only). */ /* Computed values */ unsigned long long timeElapsed; unsigned long long timeRemaining; + long long timeDelta; /* delta = sent - received, i.e., the difference + between the source and the destination time plus + the time between the end of Perform phase on the + source and the beginning of Finish phase on the + destination. */ /* Raw values from QEMU */ qemuMonitorMigrationStatus status; }; diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 1da687c..4b3143f 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -688,6 +688,8 @@ qemuMigrationCookieStatisticsXMLFormat(virBufferPtr buf, virBufferAsprintf(buf, "<started>%llu</started>\n", jobInfo->started); virBufferAsprintf(buf, "<stopped>%llu</stopped>\n", jobInfo->stopped); + virBufferAsprintf(buf, "<sent>%llu</sent>\n", jobInfo->sent); + virBufferAsprintf(buf, "<delta>%lld</delta>\n", jobInfo->timeDelta); virBufferAsprintf(buf, "<%1$s>%2$llu</%1$s>\n", VIR_DOMAIN_JOB_TIME_ELAPSED, @@ -1046,11 +1048,14 @@ qemuMigrationCookieStatisticsXMLParse(xmlXPathContextPtr ctxt) virXPathULongLong("string(./started[1])", ctxt, &jobInfo->started); virXPathULongLong("string(./stopped[1])", ctxt, &jobInfo->stopped); + virXPathULongLong("string(./sent[1])", ctxt, &jobInfo->sent); + virXPathLongLong("string(./delta[1])", ctxt, &jobInfo->timeDelta); virXPathULongLong("string(./" VIR_DOMAIN_JOB_TIME_ELAPSED "[1])", ctxt, &jobInfo->timeElapsed); virXPathULongLong("string(./" VIR_DOMAIN_JOB_TIME_REMAINING "[1])", ctxt, &jobInfo->timeRemaining); + if (virXPathULongLong("string(./" VIR_DOMAIN_JOB_DOWNTIME "[1])", ctxt, &status->downtime) == 0) status->downtime_set = true; @@ -3438,18 +3443,9 @@ qemuMigrationConfirmPhase(virQEMUDriverPtr driver, /* Update total times with the values sent by the destination daemon */ if (mig->jobInfo) { qemuDomainObjPrivatePtr priv = vm->privateData; - if (priv->job.completed) { - qemuDomainJobInfoPtr jobInfo = priv->job.completed; - if (mig->jobInfo->status.downtime_set) { - jobInfo->status.downtime = mig->jobInfo->status.downtime; - jobInfo->status.downtime_set = true; - } - if (mig->jobInfo->timeElapsed) - jobInfo->timeElapsed = mig->jobInfo->timeElapsed; - } else { - priv->job.completed = mig->jobInfo; - mig->jobInfo = NULL; - } + VIR_FREE(priv->job.completed); + priv->job.completed = mig->jobInfo; + mig->jobInfo = NULL; } if (flags & VIR_MIGRATE_OFFLINE) @@ -4041,6 +4037,7 @@ qemuMigrationRun(virQEMUDriverPtr driver, if (priv->job.completed) { qemuDomainJobInfoUpdateTime(priv->job.completed); qemuDomainJobInfoUpdateDowntime(priv->job.completed); + ignore_value(virTimeMillisNow(&priv->job.completed->sent)); } if (priv->job.current->type == VIR_DOMAIN_JOB_UNBOUNDED) @@ -5164,8 +5161,11 @@ qemuMigrationFinish(virQEMUDriverPtr driver, } if (mig->jobInfo) { - priv->job.completed = mig->jobInfo; + qemuDomainJobInfoPtr jobInfo = mig->jobInfo; + priv->job.completed = jobInfo; mig->jobInfo = NULL; + if (jobInfo->sent && virTimeMillisNow(&jobInfo->received) == 0) + jobInfo->timeDelta = jobInfo->received - jobInfo->sent; } if (!(flags & VIR_MIGRATE_OFFLINE)) { diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 4f58f07..6e79c4d 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -5764,6 +5764,15 @@ cmdDomjobinfo(vshControl *ctl, const vshCmd *cmd) } vshPrint(ctl, "%-17s %-12llu ms\n", _("Time elapsed:"), info.timeElapsed); + if ((rc = virTypedParamsGetULLong(params, nparams, + VIR_DOMAIN_JOB_TIME_ELAPSED_NET, + &value)) < 0) { + goto save_error; + } else if (rc && value) { + vshPrint(ctl, "%-17s %-12llu ms\n", _("Time elapsed w/o network:"), + value); + } + if (info.type == VIR_DOMAIN_JOB_BOUNDED) vshPrint(ctl, "%-17s %-12llu ms\n", _("Time remaining:"), info.timeRemaining); @@ -5853,6 +5862,13 @@ cmdDomjobinfo(vshControl *ctl, const vshCmd *cmd) } if ((rc = virTypedParamsGetULLong(params, nparams, + VIR_DOMAIN_JOB_DOWNTIME_NET, + &value)) < 0) + goto save_error; + else if (rc) + vshPrint(ctl, "%-17s %-12llu ms\n", _("Downtime w/o network:"), value); + + if ((rc = virTypedParamsGetULLong(params, nparams, VIR_DOMAIN_JOB_SETUP_TIME, &value)) < 0) goto save_error; -- 2.3.5

3 6

[libvirt] [PATCH] storage: Resolve Coverity UNINIT
by John Ferlan 27 Apr '15

27 Apr '15

commit id '1e13eff4' didn't init found when changed from a bool to an int in virStoragePoolFCRefreshThread and Coverity... Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- src/storage/storage_backend_scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/storage/storage_backend_scsi.c b/src/storage/storage_backend_scsi.c index f381ddb..e6c8bb5 100644 --- a/src/storage/storage_backend_scsi.c +++ b/src/storage/storage_backend_scsi.c @@ -581,7 +581,7 @@ virStoragePoolFCRefreshThread(void *opaque) const char *name = cbdata->name; virStoragePoolObjPtr pool = cbdata->pool; unsigned int host; - int found; + int found = 0; int tries = 2; do { -- 2.1.0

2 1

[libvirt] [PATCH] typo: fix typo error in virLXCControllerSetupResourceLimits
by zhang bo 27 Apr '15

27 Apr '15

iff -> if rather then -> rather than Signed-off-by: YueWenyuan <yuewenyuan(a)huawei.com> --- src/lxc/lxc_controller.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c index e144c2d..7ad9d50 100644 --- a/src/lxc/lxc_controller.c +++ b/src/lxc/lxc_controller.c @@ -745,9 +745,9 @@ static int virLXCControllerSetupResourceLimits(virLXCControllerPtr ctrl) if (mode == VIR_DOMAIN_NUMATUNE_MEM_STRICT && virCgroupControllerAvailable(VIR_CGROUP_CONTROLLER_CPUSET)) { - /* Use virNuma* API iff necessary. Once set and child is exec()-ed, + /* Use virNuma* API if necessary. Once set and child is exec()-ed, * there's no way for us to change it. Rely on cgroups (if available - * and enabled in the config) rather then virNuma*. */ + * and enabled in the config) rather than virNuma*. */ VIR_DEBUG("Relying on CGroups for memory binding"); } else { -- 1.7.12.4

2 1

[libvirt] [PATCH 0/5] qemu: Connect to guest agent after channel hotplug
by Peter Krempa 26 Apr '15

26 Apr '15

Clean up some parts of the agent code, fix a recently added bug and add support for guest agent hotplug, all this while removing more lines than adding. Peter Krempa (5): qemu: agent: Reuse virJSONValueObjectCreateVArgs in qemuAgentMakeCommand qemu: Fix domain object leak in qemuDomainInterfaceAddresses qemu: Reuse qemuDomainAgentAvailable in qemuDomainInterfaceAddresses qemu: agent: Differentiate errors when the agent channel was hotplugged qemu: Connect to guest agent after channel hotplug src/qemu/qemu_agent.c | 73 ++----------------------------------------------- src/qemu/qemu_domain.c | 45 +++++++++++++++++++++++++++--- src/qemu/qemu_domain.h | 2 ++ src/qemu/qemu_driver.c | 56 +++++++++++++++++++++---------------- src/qemu/qemu_process.c | 22 +-------------- src/qemu/qemu_process.h | 2 ++ 6 files changed, 81 insertions(+), 119 deletions(-) -- 2.3.5

2 8

[libvirt] [PATCH] libxl: remove duplicate check for pci subsystem type
by Olaf Hering 24 Apr '15

24 Apr '15

Both attach and detach functions get called only if the type matches. Signed-off-by: Olaf Hering <olaf(a)aepfle.de> Cc: Jim Fehlig <jfehlig(a)suse.com> --- src/libxl/libxl_driver.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index d76efda..f915f91 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -2901,9 +2901,6 @@ libxlDomainAttachHostPCIDevice(libxlDriverPrivatePtr driver, libxl_device_pci_init(&pcidev); - if (hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI) - goto cleanup; - if (virDomainHostdevFind(vm->def, hostdev, &found) >= 0) { virReportError(VIR_ERR_OPERATION_FAILED, _("target pci device %.4x:%.2x:%.2x.%.1x already exists"), @@ -3239,9 +3236,6 @@ libxlDomainDetachHostPCIDevice(libxlDriverPrivatePtr driver, libxl_device_pci_init(&pcidev); - if (subsys->type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI) - goto cleanup; - idx = virDomainHostdevFind(vm->def, hostdev, &detach); if (idx < 0) { virReportError(VIR_ERR_OPERATION_FAILED,

2 1

[libvirt] [PATCH] libxl: use pci init and dispose functions
by Olaf Hering 24 Apr '15

24 Apr '15

Rearrange code so that the local variable is always initialized and disposed. Signed-off-by: Olaf Hering <olaf(a)aepfle.de> Cc: Jim Fehlig <jfehlig(a)suse.com> --- src/libxl/libxl_driver.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 393f8bd..d76efda 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -2893,12 +2893,14 @@ libxlDomainAttachHostPCIDevice(libxlDriverPrivatePtr driver, virDomainHostdevDefPtr hostdev) { libxlDriverConfigPtr cfg = libxlDriverConfigGet(driver); - libxl_device_pci pcidev; + libxl_device_pci pcidev; virDomainHostdevDefPtr found; virHostdevManagerPtr hostdev_mgr = driver->hostdevMgr; virDomainHostdevSubsysPCIPtr pcisrc = &hostdev->source.subsys.u.pci; int ret = -1; + libxl_device_pci_init(&pcidev); + if (hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI) goto cleanup; @@ -2939,6 +2941,7 @@ libxlDomainAttachHostPCIDevice(libxlDriverPrivatePtr driver, cleanup: virObjectUnref(cfg); + libxl_device_pci_dispose(&pcidev); return ret; } @@ -3234,6 +3237,8 @@ libxlDomainDetachHostPCIDevice(libxlDriverPrivatePtr driver, virHostdevManagerPtr hostdev_mgr = driver->hostdevMgr; int ret = -1; + libxl_device_pci_init(&pcidev); + if (subsys->type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI) goto cleanup; @@ -3255,8 +3260,6 @@ libxlDomainDetachHostPCIDevice(libxlDriverPrivatePtr driver, } - libxl_device_pci_init(&pcidev); - if (libxlMakePCI(detach, &pcidev) < 0) goto error; @@ -3269,7 +3272,6 @@ libxlDomainDetachHostPCIDevice(libxlDriverPrivatePtr driver, goto error; } - libxl_device_pci_dispose(&pcidev); virDomainHostdevRemove(vm->def, idx); @@ -3283,6 +3285,7 @@ libxlDomainDetachHostPCIDevice(libxlDriverPrivatePtr driver, cleanup: virObjectUnref(cfg); + libxl_device_pci_dispose(&pcidev); return ret; }

2 1

[libvirt] [PATCH] libxl: initialize sdl.opengl defbool in libxlMakeVfb
by Jim Fehlig 24 Apr '15

24 Apr '15

Commit bf32462b missed initializing sdl.opengl. Without the initialization, libvirtd will be terminated by an assert from libxl: Assertion `!libxl_defbool_is_default(db)' failed. Reported-by: Olaf Hering <olaf(a)aepfle.de> Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- Perhaps bending the "trivial rule" a bit, but this patch is trivial and should have been included in bf32462b. I simply forgot to add initialization of sdl.opengl before pushing bf32462b. I'll push this fix shortly. src/libxl/libxl_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 55bd21b..53f327b 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -1243,6 +1243,7 @@ libxlMakeVfb(virPortAllocatorPtr graphicsports, case VIR_DOMAIN_GRAPHICS_TYPE_SDL: libxl_defbool_set(&x_vfb->sdl.enable, 1); libxl_defbool_set(&x_vfb->vnc.enable, 0); + libxl_defbool_set(&x_vfb->sdl.opengl, 0); if (VIR_STRDUP(x_vfb->sdl.display, l_vfb->data.sdl.display) < 0) return -1; if (VIR_STRDUP(x_vfb->sdl.xauthority, l_vfb->data.sdl.xauth) < 0) -- 1.8.4.5

1 0

[libvirt] CfP Virtualization in High-Performance Cloud Computing Workshop (VHPC '15)
by VHPC 15 24 Apr '15

24 Apr '15

================================================================= CALL FOR PAPERS 10th Workshop on Virtualization in High-Performance Cloud Computing (VHPC '15) held in conjunction with Euro-Par 2015, August 24-28, Vienna, Austria (Springer LNCS) ================================================================= Date: August 25, 2015 Workshop URL: http://vhpc.org Paper Submission Deadline: May 22, 2015 CALL FOR PAPERS Virtualization technologies constitute a key enabling factor for flexible resource management in modern data centers, cloud environments, and increasingly in HPC as well. Providers need to dynamically manage complex infrastructures in a seamless fashion for varying workloads and hosted applications, independently of the customers deploying software or users submitting highly dynamic and heterogeneous workloads. Thanks to virtualization, we have the ability to manage vast computing and networking resources dynamically and close to the marginal cost of providing the services, which is unprecedented in the history of scientific and commercial computing. Docker et al. OS-level virtualization, with its capability to isolate multiple user-space environments allows for their co-existence within the same OS kernel. It promises to provide many of the advantages of machine virtualization with high levels of responsiveness and performance; coupled with lightweight OSs it forms a potent architecture with promise to become a mainstream environment for HPC workloads. Machine virtualization, with its capability to enable consolidation of multiple under-utilized servers with heterogeneous software and operating systems (OSes), and its capability to live-migrate a fully operating virtual machine (VM) with a very short downtime, enables novel and dynamic ways to manage physical servers; I/O Virtualization allows physical network adapters to take traffic from multiple VMs; network virtualization, with its capability to create logical network overlays that are independent of the underlying physical topology and IP addressing, provides the fundamental ground on top of which evolved network services can be realized with an unprecedented level of dynamicity and flexibility; These technologies have to be inter-mixed and integrated in an intelligent way, to support workloads that are increasingly demanding in terms of absolute performance, responsiveness and interactivity, and have to respect well-specified Service- Level Agreements (SLAs), as needed for industrial-grade provided services. The Workshop on Virtualization in High-Performance Cloud Computing (VHPC) aims to bring together researchers and industrial practitioners facing the challenges posed by virtualization in order to foster discussion, collaboration, mutual exchange of knowledge and experience, enabling research to ultimately provide novel solutions for virtualized computing systems of tomorrow. The workshop will be one day in length, composed of 20 min paper presentations, each followed by 10 min discussion sections, and lightning talks, limited to 5 minutes. Presentations may be accompanied by interactive demonstrations. TOPICS Topics of interest include, but are not limited to: - Virtualization in supercomputing environments, HPC clusters, cloud HPC and grids - OS-level virtualization including container runtimes (Docker, rkt et al.) - Lightweight compute node operating systems/VMMs - Optimizations of virtual machine monitor platforms, hypervisors and - Hypervisor and network virtualization QoS and SLAs - Cloud based network and system management for SDN and NFV - Management, deployment and monitoring of virtualized environments - Performance measurement, modelling and monitoring of virtualized/cloud workloads - Programming models for virtualized environments - Cloud reliability, fault-tolerance, high-availability and security - Heterogeneous virtualized environments, virtualized accelerators, GPUs and co-processors - Optimized communication libraries/protocols in the cloud and for HPC in the cloud - Topology management and optimization for distributed virtualized applications - Cluster provisioning in the cloud and cloud bursting - Adaptation of emerging HPC technologies (high performance networks, RDMA, etc..) - I/O and storage virtualization, virtualization aware file systems - Job scheduling/control/policy in virtualized environments - Checkpointing and migration of VM-based large compute jobs - Cloud frameworks and APIs - Energy-efficient / power-aware virtualization Important Dates April 29, 2015 - Abstract registration May 22, 2015 - Full paper submission June 19, 2015 - Acceptance notification October 2, 2015 - Camera-ready version due August 25, 2015 - Workshop Date TPC CHAIR Michael Alexander (chair), TU Wien, Austria Anastassios Nanos (co-chair), NTUA, Greece Balazs Gerofi (co-chair), RIKEN Advanced Institute for Computational Science, Japan PROGRAM COMMITTEE Stergios Anastasiadis, University of Ioannina, Greece Costas Bekas, IBM Zurich Research Laboratory, Switzerland Jakob Blomer, CERN Ron Brightwell, Sandia National Laboratories, USA Roberto Canonico, University of Napoli Federico II, Italy Julian Chesterfield, OnApp, UK Patrick Dreher, MIT, USA William Gardner, University of Guelph, Canada Kyle Hale, Northwestern University, USA Marcus Hardt, Karlsruhe Institute of Technology, Germany Iftekhar Hussain, Infinera, USA Krishna Kant, Temple University, USA Eiji Kawai, National Institute of Information and Communications Technology, Japan Romeo Kinzler, IBM, Switzerland Kornilios Kourtis, ETH, Switzerland Nectarios Koziris, National Technical University of Athens, Greece Massimo Lamanna, CERN Che-Rung Roger Lee, National Tsing Hua University, Taiwan William Magato, University of Cincinnati, USA Helge Meinhard, CERN Jean-Marc Menaud, Ecole des Mines de Nantes France Christine Morin, INRIA, France Amer Qouneh, University of Florida, USA Seetharami Seelam, IBM Watson Research Center, USA Josh Simons, VMWare, USA Borja Sotomayor, University of Chicago, USA Kurt Tutschku, Blekinge Institute of Technology, Sweden Yasuhiro Watashiba, Osaka University, Japan Chao-Tung Yang, Tunghai University, Taiwan PAPER SUBMISSION-PUBLICATION Papers submitted to the workshop will be reviewed by at least two members of the program committee and external reviewers. Submissions should include abstract, key words, the e-mail address of the corresponding author, and must not exceed 10 pages, including tables and figures at a main font size no smaller than 11 point. Submission of a paper should be regarded as a commitment that, should the paper be accepted, at least one of the authors will register and attend the conference to present the work. Accepted papers will be published in the Springer LNCS series - the format must be according to the Springer LNCS Style. Initial submissions are in PDF; authors of accepted papers will be requested to provide source files. Format Guidelines: http://www.springer.de/comp/lncs/authors.html Submission Link: https://easychair.org/conferences/?conf=europar2015ws GENERAL INFORMATION The workshop is one day in length and will be held in conjunction with Euro-Par 2015, 24-28 August, Vienna, Austria

1 0

[libvirt] [PATCH 0/2] Prefer virDomainObjListFindByUUID wherever possible
by Michal Privoznik 24 Apr '15

24 Apr '15

This should go on the top of [1] so that both virDomainObjListFindByUUID and virDomainObjListFindByName are both O(1). Then, the only function left that is more time complex is virDomainObjListFindByID. Unfortunately, we can't drop it completely, but we can use it less. 1: https://www.redhat.com/archives/libvir-list/2015-April/msg01168.html Michal Privoznik (2): uml: s/virDomainObjListFindByID/virDomainObjListFindByUUID/ libxl: s/virDomainObjListFindByID/virDomainObjListFindByUUID/ src/libxl/libxl_domain.c | 2 +- src/uml/uml_driver.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) -- 2.0.5

3 5

[libvirt] [PATCH v2] parallels: fix crash in prlsdkAddNet in case of CT definition
by Maxim Nestratov 24 Apr '15

24 Apr '15

Since net->model is not defined for containers we shouldn't touch it. In case network adapter model is defined, a warning about ignoring it is shown. Signed-off-by: Maxim Nestratov <mnestratov(a)parallels.com> --- src/parallels/parallels_sdk.c | 29 ++++++++++++++++++----------- 1 files changed, 18 insertions(+), 11 deletions(-) diff --git a/src/parallels/parallels_sdk.c b/src/parallels/parallels_sdk.c index d54f894..c67044c 100644 --- a/src/parallels/parallels_sdk.c +++ b/src/parallels/parallels_sdk.c @@ -2725,7 +2725,8 @@ static const char * prlsdkFormatMac(virMacAddrPtr mac, char *macstr) static int prlsdkAddNet(PRL_HANDLE sdkdom, parallelsConnPtr privconn, - virDomainNetDefPtr net) + virDomainNetDefPtr net, + bool isCt) { PRL_RESULT pret; PRL_HANDLE sdknet = PRL_INVALID_HANDLE; @@ -2757,19 +2758,25 @@ static int prlsdkAddNet(PRL_HANDLE sdkdom, pret = PrlVmDevNet_SetMacAddress(sdknet, macstr); prlsdkCheckRetGoto(pret, cleanup); - if (STREQ(net->model, "rtl8139")) { - pret = PrlVmDevNet_SetAdapterType(sdknet, PNT_RTL); - } else if (STREQ(net->model, "e1000")) { - pret = PrlVmDevNet_SetAdapterType(sdknet, PNT_E1000); - } else if (STREQ(net->model, "virtio")) { - pret = PrlVmDevNet_SetAdapterType(sdknet, PNT_VIRTIO); + if (isCt) { + if (net->model) + VIR_WARN("Setting network adapter for containers is not " + "supported by Parallels Cloud Server."); } else { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + if (STREQ(net->model, "rtl8139")) { + pret = PrlVmDevNet_SetAdapterType(sdknet, PNT_RTL); + } else if (STREQ(net->model, "e1000")) { + pret = PrlVmDevNet_SetAdapterType(sdknet, PNT_E1000); + } else if (STREQ(net->model, "virtio")) { + pret = PrlVmDevNet_SetAdapterType(sdknet, PNT_VIRTIO); + } else { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("Specified network adapter model is not " "supported by Parallels Cloud Server.")); - goto cleanup; + goto cleanup; + } + prlsdkCheckRetGoto(pret, cleanup); } - prlsdkCheckRetGoto(pret, cleanup); if (net->type == VIR_DOMAIN_NET_TYPE_NETWORK) { if (STREQ(net->data.network.name, PARALLELS_DOMAIN_ROUTED_NETWORK_NAME)) { @@ -3153,7 +3160,7 @@ prlsdkDoApplyConfig(virConnectPtr conn, } for (i = 0; i < def->nnets; i++) { - if (prlsdkAddNet(sdkdom, conn->privateData, def->nets[i]) < 0) + if (prlsdkAddNet(sdkdom, conn->privateData, def->nets[i], IS_CT(def)) < 0) goto error; } -- 1.7.1

2 1

[libvirt] [PATCH v2] parallels: implement .domainGetMaxMemory
by Dmitry Guryanov 24 Apr '15

24 Apr '15

Since we haven't implemented balloon parameters tuning we can just return amount of memory in this function. Signed-off-by: Dmitry Guryanov <dguryanov(a)parallels.com> --- src/parallels/parallels_driver.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) Changes in v2: use parallelsDomObjFromDomain function diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c index 07f1311..c791b5b 100644 --- a/src/parallels/parallels_driver.c +++ b/src/parallels/parallels_driver.c @@ -1098,6 +1098,20 @@ static int parallelsDomainAttachDevice(virDomainPtr dom, const char *xml) VIR_DOMAIN_AFFECT_CONFIG | VIR_DOMAIN_AFFECT_LIVE); } +static unsigned long long +parallelsDomainGetMaxMemory(virDomainPtr domain) +{ + virDomainObjPtr dom = NULL; + int ret = -1; + + if (!(dom = parallelsDomObjFromDomain(domain))) + return -1; + + ret = dom->def->mem.max_balloon; + virObjectUnlock(dom); + return ret; +} + static virHypervisorDriver parallelsDriver = { .name = "Parallels", .connectOpen = parallelsConnectOpen, /* 0.10.0 */ @@ -1144,6 +1158,7 @@ static virHypervisorDriver parallelsDriver = { .domainHasManagedSaveImage = parallelsDomainHasManagedSaveImage, /* 1.2.13 */ .domainManagedSave = parallelsDomainManagedSave, /* 1.2.14 */ .domainManagedSaveRemove = parallelsDomainManagedSaveRemove, /* 1.2.14 */ + .domainGetMaxMemory = parallelsDomainGetMaxMemory, /* 1.2.15 */ }; static virConnectDriver parallelsConnectDriver = { -- 2.1.0

2 3

[libvirt] [PATCH] bhyve: fix build in tests
by Roman Bogorodskiy 24 Apr '15

24 Apr '15

Commit ca32929 caused build errors in bhyvexml2argvtest.c because of some undefined variables. Pushing under the build breaker rule. --- tests/bhyvexml2argvtest.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tests/bhyvexml2argvtest.c b/tests/bhyvexml2argvtest.c index 1cce2aa..1c7bc31 100644 --- a/tests/bhyvexml2argvtest.c +++ b/tests/bhyvexml2argvtest.c @@ -19,7 +19,6 @@ static int testCompareXMLToArgvFiles(const char *xml, const char *ldcmdline, const char *dmcmdline) { - int len; char *actualargv = NULL, *actualld = NULL, *actualdm = NULL; virDomainDefPtr vmdef = NULL; virDomainObj vm; @@ -59,9 +58,6 @@ static int testCompareXMLToArgvFiles(const char *xml, if (virtTestCompareToFile(actualld, ldcmdline) < 0) goto out; - if (virtTestCompareToFile(formatted, xml) < 0) - goto out; - if (virFileExists(dmcmdline) || actualdm) { if (virtTestCompareToFile(actualdm, dmcmdline) < 0) goto out; -- 2.3.5

1 0

[libvirt] [PATCH] hostdev: fix net config restore error
by Huanle Han 24 Apr '15

24 Apr '15

Fix for such a case: 1. Domain A and B xml contain the same SRIOV net hostdev(<interface type='hostdev' /> with same pci address). 2. virsh start A (Successfully, and configure the SRIOV net with custom mac) 3. virsh start B (Fail because of the hostdev used by domain A or other reason.) In step 3, 'virHostdevNetConfigRestore' is called for the hostdev which is still used by domain A. It makes the mac/vlan of the SRIOV net change. Code Change in this fix: 1. As the pci used by other domain have been removed from 'pcidevs' in previous loop, we only restore the nic config for the hostdev still in 'pcidevs'(used by this domain) 2. wrap a function 'virHostdevIsPCINetDevice', which detect whether the hostdev is a pci net device or not. 3. update the comments to make it more clear Signed-off-by: Huanle Han <hanxueluo(a)gmail.com> --- src/util/virhostdev.c | 70 ++++++++++++++++++++++++++++++++++----------------- 1 file changed, 47 insertions(+), 23 deletions(-) diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c index f583e54..a2719d3 100644 --- a/src/util/virhostdev.c +++ b/src/util/virhostdev.c @@ -350,6 +350,14 @@ virHostdevNetDevice(virDomainHostdevDefPtr hostdev, char **linkdev, return ret; } +static int +virHostdevIsPCINetDevice(virDomainHostdevDefPtr hostdev) +{ + return hostdev->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS && + hostdev->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI && + hostdev->parent.type == VIR_DOMAIN_DEVICE_NET && + hostdev->parent.data.net; +} static int virHostdevNetConfigVirtPortProfile(const char *linkdev, int vf, @@ -481,10 +489,7 @@ virHostdevNetConfigRestore(virDomainHostdevDefPtr hostdev, /* This is only needed for PCI devices that have been defined * using <interface type='hostdev'>. For all others, it is a NOP. */ - if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS || - hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI || - hostdev->parent.type != VIR_DOMAIN_DEVICE_NET || - !hostdev->parent.data.net) + if (!virHostdevIsPCINetDevice(hostdev)) return 0; isvf = virHostdevIsVirtualFunction(hostdev); @@ -604,16 +609,11 @@ virHostdevPreparePCIDevices(virHostdevManagerPtr hostdev_mgr, * the network device, set the netdev config */ for (i = 0; i < nhostdevs; i++) { virDomainHostdevDefPtr hostdev = hostdevs[i]; - if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) + if (!virHostdevIsPCINetDevice(hostdev)) continue; - if (hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI) - continue; - if (hostdev->parent.type == VIR_DOMAIN_DEVICE_NET && - hostdev->parent.data.net) { - if (virHostdevNetConfigReplace(hostdev, uuid, - hostdev_mgr->stateDir) < 0) { - goto resetvfnetconfig; - } + if (virHostdevNetConfigReplace(hostdev, uuid, + hostdev_mgr->stateDir) < 0) { + goto resetvfnetconfig; } last_processed_hostdev_vf = i; } @@ -781,19 +781,20 @@ virHostdevReAttachPCIDevices(virHostdevManagerPtr hostdev_mgr, goto cleanup; } - /* Again 4 loops; mark all devices as inactive before reset + /* Here are 4 loops; mark all devices as inactive before reset * them and reset all the devices before re-attach. * Attach mac and port profile parameters to devices */ + + /* Loop 1: delete the copy of the dev from pcidevs if it's used by + * other domain. Or delete it from activePCIHostDevs if it had + * been used by this domain. + */ i = 0; while (i < virPCIDeviceListCount(pcidevs)) { virPCIDevicePtr dev = virPCIDeviceListGet(pcidevs, i); virPCIDevicePtr activeDev = NULL; - /* delete the copy of the dev from pcidevs if it's used by - * other domain. Or delete it from activePCIHostDevs if it had - * been used by this domain. - */ activeDev = virPCIDeviceListFind(hostdev_mgr->activePCIHostdevs, dev); if (activeDev) { const char *usedby_drvname; @@ -815,13 +816,33 @@ virHostdevReAttachPCIDevices(virHostdevManagerPtr hostdev_mgr, */ /* - * For SRIOV net host devices, unset mac and port profile before - * reset and reattach device + * Loop 2: For SRIOV net host devices used by this domain, unset mac and port profile before + * resetting and reattaching device */ - for (i = 0; i < nhostdevs; i++) - virHostdevNetConfigRestore(hostdevs[i], hostdev_mgr->stateDir, - oldStateDir); + for (i = 0; i < nhostdevs; i++) { + virDomainHostdevDefPtr hostdev = hostdevs[i]; + if (virHostdevIsPCINetDevice(hostdev)) { + virDomainHostdevSubsysPCIPtr pcisrc = &hostdev->source.subsys.u.pci; + virPCIDevicePtr dev = NULL; + dev = virPCIDeviceNew(pcisrc->addr.domain, pcisrc->addr.bus, + pcisrc->addr.slot, pcisrc->addr.function); + if (dev) { + if (virPCIDeviceListFind(pcidevs, dev)) { + virHostdevNetConfigRestore(hostdev, hostdev_mgr->stateDir, + oldStateDir); + } + } else { + virErrorPtr err = virGetLastError(); + VIR_ERROR(_("Failed to new PCI device: %s"), + err ? err->message : _("unknown error")); + virResetError(err); + } + virPCIDeviceFree(dev); + } + } + + /* Loop 3: reset pci device used by this domain */ for (i = 0; i < virPCIDeviceListCount(pcidevs); i++) { virPCIDevicePtr dev = virPCIDeviceListGet(pcidevs, i); @@ -834,6 +855,9 @@ virHostdevReAttachPCIDevices(virHostdevManagerPtr hostdev_mgr, } } + /* Loop 4: reattach pci devices used by this domain + * and steal all the devices from pcidevs + */ while (virPCIDeviceListCount(pcidevs) > 0) { virPCIDevicePtr dev = virPCIDeviceListStealIndex(pcidevs, 0); virHostdevReattachPCIDevice(dev, hostdev_mgr); -- 1.9.1

3 3

[libvirt] [PATCH 0/4] qemu: Fix issues with socket/nvram directories
by Cole Robinson 24 Apr '15

24 Apr '15

Couple cleanups and bug fixes dealing with qemu directory creation and permissions. Cole Robinson (4): qemu: conf: Clarify paths that are relative to libDir qemu: chown autoDumpPath on driver startup qemu: Build channel autosocket directory at driver startup qemu: Build nvram directory at driver startup libvirt.spec.in | 6 ------ src/Makefile.am | 2 -- src/qemu/qemu_conf.c | 28 +++++++++++++++++++--------- src/qemu/qemu_conf.h | 2 ++ src/qemu/qemu_domain.c | 9 ++++----- src/qemu/qemu_driver.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ src/qemu/qemu_process.c | 4 ++-- 7 files changed, 76 insertions(+), 24 deletions(-) -- 2.3.5

2 6

[libvirt] [PATCH] tests: qemu: Couple aarch64 CPU tests
by Cole Robinson 24 Apr '15

24 Apr '15

- Make sure aarch64 host-passthrough works correctly - Make sure libvirt doesn't choke on cpu model=host, which is what virt-install/virt-manager were incorrectly specifying up until recently. --- .../qemuxml2argv-aarch64-cpu-model-host.args | 1 + .../qemuxml2argv-aarch64-cpu-model-host.xml | 28 ++++++++++++++++++++++ .../qemuxml2argv-aarch64-cpu-passthrough.args | 1 + .../qemuxml2argv-aarch64-cpu-passthrough.xml | 27 +++++++++++++++++++++ tests/qemuxml2argvtest.c | 6 +++++ .../qemuxml2argv-aarch64-cpu-passthrough.xml | 27 +++++++++++++++++++++ tests/qemuxml2xmltest.c | 2 ++ 7 files changed, 92 insertions(+) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-cpu-model-host.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-cpu-model-host.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-cpu-passthrough.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-cpu-passthrough.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2argv-aarch64-cpu-passthrough.xml diff --git a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-cpu-model-host.args b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-cpu-model-host.args new file mode 100644 index 0000000..802ea11 --- /dev/null +++ b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-cpu-model-host.args @@ -0,0 +1 @@ +LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test QEMU_AUDIO_DRV=none /usr/bin/qemu-system-aarch64 -S -M virt -cpu host -m 1024 -smp 1 -nographic -nodefconfig -nodefaults -monitor unix:/tmp/test-monitor,server,nowait -boot c -usb -drive file=/aarch64.raw,if=none,id=drive-virtio-disk0 -device virtio-blk-device,drive=drive-virtio-disk0,id=virtio-disk0 \ No newline at end of file diff --git a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-cpu-model-host.xml b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-cpu-model-host.xml new file mode 100644 index 0000000..53d528f --- /dev/null +++ b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-cpu-model-host.xml @@ -0,0 +1,28 @@ +<domain type='kvm'> + <name>aarch64test</name> + <uuid>496d7ea8-9739-544b-4ebd-ef08be936e8b</uuid> + <memory unit='KiB'>1048576</memory> + <currentMemory unit='KiB'>1048576</currentMemory> + <vcpu placement='static'>1</vcpu> + <os> + <type arch='aarch64' machine='virt'>hvm</type> + <boot dev='hd'/> + </os> + <features> + <acpi/> + <apic/> + <pae/> + </features> + <cpu mode='host-passthrough'/> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>restart</on_crash> + <devices> + <emulator>/usr/bin/qemu-system-aarch64</emulator> + <disk type='file' device='disk'> + <source file='/aarch64.raw'/> + <target dev='vda' bus='virtio'/> + </disk> + </devices> +</domain> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-cpu-passthrough.args b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-cpu-passthrough.args new file mode 100644 index 0000000..802ea11 --- /dev/null +++ b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-cpu-passthrough.args @@ -0,0 +1 @@ +LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test QEMU_AUDIO_DRV=none /usr/bin/qemu-system-aarch64 -S -M virt -cpu host -m 1024 -smp 1 -nographic -nodefconfig -nodefaults -monitor unix:/tmp/test-monitor,server,nowait -boot c -usb -drive file=/aarch64.raw,if=none,id=drive-virtio-disk0 -device virtio-blk-device,drive=drive-virtio-disk0,id=virtio-disk0 \ No newline at end of file diff --git a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-cpu-passthrough.xml b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-cpu-passthrough.xml new file mode 100644 index 0000000..4cdf387 --- /dev/null +++ b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-cpu-passthrough.xml @@ -0,0 +1,27 @@ +<domain type="kvm"> + <name>aarch64test</name> + <uuid>496d7ea8-9739-544b-4ebd-ef08be936e8b</uuid> + <memory>1048576</memory> + <currentMemory>1048576</currentMemory> + <vcpu placement='static'>1</vcpu> + <os> + <type arch="aarch64" machine="virt">hvm</type> + </os> + <features> + <acpi/> + <apic/> + <pae/> + </features> + <cpu mode='host-passthrough'/> + <clock offset="utc"/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>restart</on_crash> + <devices> + <emulator>/usr/bin/qemu-system-aarch64</emulator> + <disk type='file' device='disk'> + <source file='/aarch64.raw'/> + <target dev='vda' bus='virtio'/> + </disk> + </devices> +</domain> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 1fe445a..055ceee 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1525,6 +1525,12 @@ mymain(void) DO_TEST("aarch64-virt-default-nic", QEMU_CAPS_DEVICE, QEMU_CAPS_NODEFCONFIG, QEMU_CAPS_DEVICE_VIRTIO_MMIO); + DO_TEST("aarch64-cpu-passthrough", QEMU_CAPS_DEVICE, QEMU_CAPS_DRIVE, + QEMU_CAPS_NODEFCONFIG, QEMU_CAPS_DEVICE_VIRTIO_MMIO, + QEMU_CAPS_CPU_HOST, QEMU_CAPS_KVM); + DO_TEST("aarch64-cpu-model-host", QEMU_CAPS_DEVICE, QEMU_CAPS_DRIVE, + QEMU_CAPS_NODEFCONFIG, QEMU_CAPS_DEVICE_VIRTIO_MMIO, + QEMU_CAPS_CPU_HOST, QEMU_CAPS_KVM); DO_TEST("kvm-pit-device", QEMU_CAPS_KVM_PIT_TICK_POLICY); DO_TEST("kvm-pit-delay", QEMU_CAPS_NO_KVM_PIT); diff --git a/tests/qemuxml2xmloutdata/qemuxml2argv-aarch64-cpu-passthrough.xml b/tests/qemuxml2xmloutdata/qemuxml2argv-aarch64-cpu-passthrough.xml new file mode 100644 index 0000000..4cdf387 --- /dev/null +++ b/tests/qemuxml2xmloutdata/qemuxml2argv-aarch64-cpu-passthrough.xml @@ -0,0 +1,27 @@ +<domain type="kvm"> + <name>aarch64test</name> + <uuid>496d7ea8-9739-544b-4ebd-ef08be936e8b</uuid> + <memory>1048576</memory> + <currentMemory>1048576</currentMemory> + <vcpu placement='static'>1</vcpu> + <os> + <type arch="aarch64" machine="virt">hvm</type> + </os> + <features> + <acpi/> + <apic/> + <pae/> + </features> + <cpu mode='host-passthrough'/> + <clock offset="utc"/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>restart</on_crash> + <devices> + <emulator>/usr/bin/qemu-system-aarch64</emulator> + <disk type='file' device='disk'> + <source file='/aarch64.raw'/> + <target dev='vda' bus='virtio'/> + </disk> + </devices> +</domain> diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index bce04b2..45464cc 100644 --- a/tests/qemuxml2xmltest.c +++ b/tests/qemuxml2xmltest.c @@ -612,6 +612,8 @@ mymain(void) DO_TEST("memory-hotplug-nonuma"); DO_TEST("memory-hotplug-dimm"); + DO_TEST("aarch64-cpu-model-host"); + virObjectUnref(driver.caps); virObjectUnref(driver.xmlopt); -- 2.3.5

2 2

[libvirt] [PATCH] qemu: detect-zeroes feature for drives
by Maros Zatko 24 Apr '15

24 Apr '15

This patch adds support for detect-zeroes feature in QEMU. It's intented to be used by libguestfs in virt-sparsify tool. Relates to: RHBZ#1130506 Maros Zatko (1): qemu: add support for detect-zeroes feature docs/schemas/domaincommon.rng | 12 ++++++++++++ src/conf/domain_conf.c | 19 +++++++++++++++++++ src/conf/domain_conf.h | 10 ++++++++++ src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 6 +++++- src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 11 +++++++++++ 7 files changed, 59 insertions(+), 1 deletion(-) -- 1.9.3

2 2

[libvirt] [PATCH v2 0/9] Additional host name check for network storage pools
by John Ferlan 24 Apr '15

24 Apr '15

v1 here: http://www.redhat.com/archives/libvir-list/2015-April/msg00873.html Essentially a rewrite of v1 changing to use virsocketaddr.* rather than virutil.* Also making check for hostname duplication prior to startPool rather than during XML processing John Ferlan (9): socketaddr: Add isNumeric flag to virSocketAddrParseInternal socketaddr: Introduce virSocketAddrParseName iscsi: Check for validity of pool source hostname netfs: Check for validity of pool source hostname gluster: Check for validity of pool source hostname sheepdog: Check for validity of pool source hostname virsockaddr: Split up functionality of virSocketAddrFormatFull virsocketaddr: Introduce virSocketAddrIsSameTCPHost storage: Check for duplicate resolved host name at pool create src/conf/storage_conf.c | 80 ++++++++++++++- src/conf/storage_conf.h | 6 +- src/libvirt_private.syms | 3 + src/storage/storage_backend_fs.c | 5 +- src/storage/storage_backend_gluster.c | 6 +- src/storage/storage_backend_iscsi.c | 6 +- src/storage/storage_backend_sheepdog.c | 38 ++++--- src/storage/storage_driver.c | 9 +- src/util/virsocketaddr.c | 180 ++++++++++++++++++++++++++++----- src/util/virsocketaddr.h | 9 +- 10 files changed, 295 insertions(+), 47 deletions(-) -- 2.1.0

2 12

[libvirt] [PATCH] Fix memory leak in virNetSocketNewConnectUNIX
by Jiri Denemark 24 Apr '15

24 Apr '15

==26726== by 0x673CD67: __vasprintf_chk (vasprintf_chk.c:80) ==26726== by 0x5673605: UnknownInlinedFun (stdio2.h:210) ==26726== by 0x5673605: virVasprintfInternal (virstring.c:476) ==26726== by 0x56736EE: virAsprintfInternal (virstring.c:497) ==26726== by 0x5680C37: virGetUserRuntimeDirectory (virutil.c:866) ==26726== by 0x5783A89: virNetSocketNewConnectUNIX (virnetsocket.c:572) ==26726== by 0x57751AF: virNetClientNewUNIX (virnetclient.c:344) ==26726== by 0x57689B3: doRemoteOpen (remote_driver.c:895) ==26726== by 0x5769F8E: remoteConnectOpen (remote_driver.c:1195) ==26726== by 0x57092DF: do_open (libvirt.c:1189) ==26726== by 0x570A7BF: virConnectOpenAuth (libvirt.c:1341) https://bugzilla.redhat.com/show_bug.cgi?id=1215042 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/rpc/virnetsocket.c | 44 +++++++++++++++++++++----------------------- 1 file changed, 21 insertions(+), 23 deletions(-) diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c index a59e3e1..7ae2796 100644 --- a/src/rpc/virnetsocket.c +++ b/src/rpc/virnetsocket.c @@ -546,6 +546,7 @@ int virNetSocketNewConnectUNIX(const char *path, virSocketAddr localAddr; virSocketAddr remoteAddr; char *rundir = NULL; + int ret = -1; memset(&localAddr, 0, sizeof(localAddr)); memset(&remoteAddr, 0, sizeof(remoteAddr)); @@ -559,50 +560,50 @@ int virNetSocketNewConnectUNIX(const char *path, virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Auto-spawn of daemon requested, " "but no binary specified")); - goto error; + goto cleanup; } if (!(binname = last_component(binary)) || binname[0] == '\0') { virReportError(VIR_ERR_INTERNAL_ERROR, _("Cannot determine basename for binary '%s'"), binary); - goto error; + goto cleanup; } if (!(rundir = virGetUserRuntimeDirectory())) - goto error; + goto cleanup; if (virFileMakePathWithMode(rundir, 0700) < 0) { virReportSystemError(errno, _("Cannot create user runtime directory '%s'"), rundir); - goto error; + goto cleanup; } if (virAsprintf(&lockpath, "%s/%s.lock", rundir, binname) < 0) - goto error; + goto cleanup; if ((lockfd = open(lockpath, O_RDWR | O_CREAT, 0600)) < 0 || virSetCloseExec(lockfd) < 0) { virReportSystemError(errno, _("Unable to create lock '%s'"), lockpath); - goto error; + goto cleanup; } if (virFileLock(lockfd, false, 0, 1, true) < 0) { virReportSystemError(errno, _("Unable to lock '%s'"), lockpath); - goto error; + goto cleanup; } } if ((fd = socket(PF_UNIX, SOCK_STREAM, 0)) < 0) { virReportSystemError(errno, "%s", _("Failed to create socket")); - goto error; + goto cleanup; } remoteAddr.data.un.sun_family = AF_UNIX; if (virStrcpyStatic(remoteAddr.data.un.sun_path, path) == NULL) { virReportSystemError(ENOMEM, _("Path %s too long for unix socket"), path); - goto error; + goto cleanup; } if (remoteAddr.data.un.sun_path[0] == '@') remoteAddr.data.un.sun_path[0] = '\0'; @@ -612,42 +613,39 @@ int virNetSocketNewConnectUNIX(const char *path, if (!(spawnDaemon && errno == ENOENT)) { virReportSystemError(errno, _("Failed to connect socket to '%s'"), path); - goto error; + goto cleanup; } if (virNetSocketForkDaemon(binary) < 0) - goto error; + goto cleanup; retries--; usleep(5000); } - if (lockfd != -1) { - unlink(lockpath); - VIR_FORCE_CLOSE(lockfd); - VIR_FREE(lockpath); - } - localAddr.len = sizeof(localAddr.data); if (getsockname(fd, &localAddr.data.sa, &localAddr.len) < 0) { virReportSystemError(errno, "%s", _("Unable to get local socket name")); - goto error; + goto cleanup; } if (!(*retsock = virNetSocketNew(&localAddr, &remoteAddr, true, fd, -1, 0))) - goto error; + goto cleanup; - return 0; + ret = 0; - error: + cleanup: if (lockfd != -1) { unlink(lockpath); VIR_FORCE_CLOSE(lockfd); } VIR_FREE(lockpath); VIR_FREE(rundir); - VIR_FORCE_CLOSE(fd); - return -1; + + if (ret == -1) + VIR_FORCE_CLOSE(fd); + + return ret; } #else int virNetSocketNewConnectUNIX(const char *path ATTRIBUTE_UNUSED, -- 2.3.5

3 3

[libvirt] [PATCH] build: add pragma directive to fix build on some gcc
by Pavel Hrdina 24 Apr '15

24 Apr '15

Commit 1268820a removed obsolete index() function and replaced it by strchr. Few versions of gcc has a bug and reports a warning about strchr: ../../src/util/virstring.c:1006: error: logical '&&' with non-zero constant will always evaluate as true [-Wlogical-op] Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- Pushed as build-breaker fix. src/util/virstring.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/util/virstring.c b/src/util/virstring.c index 7b0cad7..5794f96 100644 --- a/src/util/virstring.c +++ b/src/util/virstring.c @@ -986,6 +986,16 @@ virStringHasControlChars(const char *str) } +/* Work around spurious strchr() diagnostics given by -Wlogical-op + * for gcc < 4.6. Doing it via a local pragma keeps the damage + * smaller than disabling it on the package level. Unfortunately, the + * affected GCCs don't allow diagnostic push/pop which would have + * further reduced the impact. */ +#if BROKEN_GCC_WLOGICALOP +# pragma GCC diagnostic ignored "-Wlogical-op" +#endif + + /** * virStringStripControlChars: * @str: the string to strip -- 2.0.5

1 0

[libvirt] [PATCH 0/5] Make virDomainObjListFindByName run in O(1)
by Michal Privoznik 24 Apr '15

24 Apr '15

As discussed here: https://www.redhat.com/archives/libvir-list/2015-April/msg01135.html Michal Privoznik (5): virDomainObjListAddLocked: s/false/NULL/ for @oldDef virDomainObjListNew: Use virObjectFreeHashData Introduce virDomainObjEndAPI virDomainObjListFindByName: Return referenced object virDomainObjList: Introduce yet another hash table src/bhyve/bhyve_driver.c | 3 +- src/conf/domain_conf.c | 83 +++++++++++++++++++++++------------ src/conf/domain_conf.h | 2 + src/libvirt_private.syms | 1 + src/libxl/libxl_driver.c | 10 ++--- src/lxc/lxc_driver.c | 3 +- src/openvz/openvz_driver.c | 11 +++-- src/parallels/parallels_driver.c | 3 +- src/qemu/qemu_domain.c | 7 +-- src/qemu/qemu_driver.c | 14 ++---- src/test/test_driver.c | 93 +++++++++++++--------------------------- src/uml/uml_driver.c | 15 +++---- 12 files changed, 110 insertions(+), 135 deletions(-) -- 2.0.5

4 15

[libvirt] [PATCH 0/4] tests: Cleanups and improvements
by Cole Robinson 23 Apr '15

23 Apr '15

First 3 patches are uninteresting cleanups, removing a bunch of boiler plate code. The last patch adds a way to easily regenerate test output, like when adding a new test case (plop in the qemu XML, use the env var and the test suite will create foo.args for you), or when a code changes causes test suite output to expectedly change. Cole Robinson (4): tests: Add VIR_TEST_DEBUG and VIR_TEST_VERBOSE tests: Use *DefParseFile more tests: Add virtTestCompareToFile tests: Add VIR_TEST_REGENERATE_OUTPUT HACKING | 7 ++ docs/hacking.html.in | 12 +++ tests/bhyvexml2argvtest.c | 41 ++-------- tests/bhyvexml2xmltest.c | 18 +---- tests/cputest.c | 45 ++++------- tests/domaincapstest.c | 9 +-- tests/domainconftest.c | 7 +- tests/jsontest.c | 48 +++++------- tests/lxcxml2xmltest.c | 17 +---- tests/networkxml2conftest.c | 16 +--- tests/networkxml2firewalltest.c | 9 +-- tests/networkxml2xmltest.c | 15 +--- tests/networkxml2xmlupdatetest.c | 15 +--- tests/nodeinfotest.c | 20 +---- tests/nwfilterxml2firewalltest.c | 11 +-- tests/nwfilterxml2xmltest.c | 15 +--- tests/qemuagenttest.c | 9 +-- tests/qemuargv2xmltest.c | 15 ++-- tests/qemucaps2xmltest.c | 27 +------ tests/qemuhelptest.c | 6 +- tests/qemuhotplugtest.c | 19 ++--- tests/qemumonitorjsontest.c | 9 +-- tests/qemumonitortest.c | 24 +++--- tests/qemuxml2argvtest.c | 27 ++----- tests/qemuxmlnstest.c | 19 +---- tests/secretxml2xmltest.c | 15 +--- tests/securityselinuxlabeltest.c | 13 +--- tests/sexpr2xmltest.c | 9 +-- tests/statstest.c | 3 +- tests/storagebackendsheepdogtest.c | 20 +---- tests/storagepoolxml2xmltest.c | 15 +--- tests/storagevolxml2argvtest.c | 40 ++-------- tests/storagevolxml2xmltest.c | 21 +---- tests/sysinfotest.c | 10 +-- tests/testutils.c | 74 ++++++++++++++---- tests/testutils.h | 14 ++++ tests/testutilslxc.c | 2 +- tests/testutilsqemu.c | 2 +- tests/utiltest.c | 30 +++----- tests/virbuftest.c | 60 +++++++-------- tests/vircaps2xmltest.c | 10 +-- tests/vircgrouptest.c | 9 +-- tests/virhashtest.c | 152 ++++++++++++------------------------- tests/virpcitest.c | 4 +- tests/virportallocatortest.c | 35 +++------ tests/vmx2xmltest.c | 9 +-- tests/xencapstest.c | 9 +-- tests/xlconfigtest.c | 27 +------ tests/xmconfigtest.c | 27 +------ tests/xml2sexprtest.c | 18 +---- tests/xml2vmxtest.c | 19 +---- 51 files changed, 340 insertions(+), 767 deletions(-) -- 2.3.5

2 9

[libvirt] [PATCH] qemu: cgroup: Fix priorities when setting emulatorpin
by Peter Krempa 23 Apr '15

23 Apr '15

Use the custom emulator pin setting with the highest priority same as with vcpupin. --- src/qemu/qemu_cgroup.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index e83342d..bf0621f 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -1110,10 +1110,10 @@ qemuSetupCgroupForEmulator(virDomainObjPtr vm) if (virCgroupMoveTask(priv->cgroup, cgroup_emulator) < 0) goto cleanup; - if (def->placement_mode == VIR_DOMAIN_CPU_PLACEMENT_MODE_AUTO) - cpumask = priv->autoCpuset; - else if (def->cputune.emulatorpin) + if (def->cputune.emulatorpin) cpumask = def->cputune.emulatorpin->cpumask; + else if (def->placement_mode == VIR_DOMAIN_CPU_PLACEMENT_MODE_AUTO) + cpumask = priv->autoCpuset; else if (def->cpumask) cpumask = def->cpumask; -- 2.3.5

2 1

[libvirt] [PATCH v4 0/9] Implement Add/Del IOThreads
by John Ferlan 23 Apr '15

23 Apr '15

v3 here: http://www.redhat.com/archives/libvir-list/2015-April/msg00621.html Changes since v3 Patch 1: * Add back in and use virDomainIOThreadIDDefFree * Change _virDomainIOThreadIDDef 'undefined' to 'autofill' * Adjust virDomainDefParseXML to only allocate what's defined allowing virDomainDefPostParseInternal to Add in IOThreads which weren't defined and set the 'autofill' boolean * Have virDomainIOThreadIDAdd return a virDomainIOThreadIDDefPtr Patch 2: No changes Patch 3: (NEW) * Discussed in prior review regarding making virDomainPinIsDuplicate a static function (needed to move it) Patch 4: (NEW) * Move the iothreadspin data (e.g., the cpumask) into _virDomainIOThreadIDDef * Kept the 'niothreadspin' and manipulated as necessary since there was code to write out <cputune> data that I didn't want to reinvent/rototill just to search through iothreadids for a cpumask * Adjusted virDomainIOThreadPinDefParseXML to handle storing the cpumask in the right iothreadsid[] entry. If not found (it may not be since the virDomainDefPostParseInternal hasn't run), then create an autofill version of an iothreadids entry. * Remove/adjust a lot of code that used to handle iothreadspin Patch 5: (NEW) * Slight adjustment for iothreadsched to allow for "any" id value. This code stores iothread id's as bitmap entries, so it didn't have the same issues as the iothreadspin code Patch 6-7: Unchanged Patch 8: * Adjusted the search for the new thread code to use existing alias * Use the virDomainIOThreadIDAdd returned pointer * Comment adjustments from code review * Removal of erroneously cut-n-pasted code in Delete path * Use the ->dst for the message * Changes based on having cpumask in the iothrid data Patch 9: No changes John Ferlan (9): conf: Add new domain XML element 'iothreadids' qemu: Use domain iothreadids to IOThread's 'thread_id' conf: Move virDomainPinIsDuplicate and make static Move iothreadspin information into iothreadids conf: Adjust the iothreadsched expectations Implement virDomainAddIOThread and virDomainDelIOThread remote: Add support for AddIOThread and DelIOThread qemu: Add support to Add/Delete IOThreads virsh: Add iothreadadd and iothreaddel commands docs/formatdomain.html.in | 46 +- docs/schemas/domaincommon.rng | 12 + include/libvirt/libvirt-domain.h | 6 + src/conf/domain_audit.c | 9 + src/conf/domain_audit.h | 6 + src/conf/domain_conf.c | 340 ++++++++++---- src/conf/domain_conf.h | 25 +- src/driver-hypervisor.h | 12 + src/libvirt-domain.c | 118 +++++ src/libvirt_private.syms | 6 +- src/libvirt_public.syms | 6 + src/qemu/qemu_cgroup.c | 31 +- src/qemu/qemu_command.c | 38 +- src/qemu/qemu_command.h | 3 + src/qemu/qemu_domain.c | 36 -- src/qemu/qemu_domain.h | 3 - src/qemu/qemu_driver.c | 511 ++++++++++++++++++--- src/qemu/qemu_process.c | 40 +- src/remote/remote_driver.c | 2 + src/remote/remote_protocol.x | 30 +- src/remote_protocol-structs | 12 + .../qemuxml2argv-cputune-iothreadsched-toomuch.xml | 1 + .../qemuxml2argv-iothreads-ids-partial.args | 10 + .../qemuxml2argv-iothreads-ids-partial.xml | 33 ++ .../qemuxml2argv-iothreads-ids.args | 8 + .../qemuxml2argv-iothreads-ids.xml | 33 ++ tests/qemuxml2argvtest.c | 2 + tests/qemuxml2xmltest.c | 2 + tools/virsh-domain.c | 164 +++++++ tools/virsh.pod | 31 ++ 30 files changed, 1320 insertions(+), 256 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-ids-partial.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-ids-partial.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-ids.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-ids.xml -- 2.1.0

2 26

[libvirt] [PATCH] build: avoid obsolete index()
by Eric Blake 23 Apr '15

23 Apr '15

Commit 2a530a3e5 is not portable to mingw, which intentionally avoids declaring the obsolete index(). See also: https://bugzilla.redhat.com/show_bug.cgi?id=1214605 * src/util/virstring.c (virStringStripControlChars): Use strchr. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Pushing under the build-breaker rule. src/util/virstring.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virstring.c b/src/util/virstring.c index 1cd4987..7b0cad7 100644 --- a/src/util/virstring.c +++ b/src/util/virstring.c @@ -1,5 +1,5 @@ /* - * Copyright (C) 2012-2014 Red Hat, Inc. + * Copyright (C) 2012-2015 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -1003,7 +1003,7 @@ virStringStripControlChars(char *str) len = strlen(str); for (i = 0, j = 0; i < len; i++) { - if (index(control_chars, str[i])) + if (strchr(control_chars, str[i])) continue; str[j++] = str[i]; -- 2.1.0

1 0

[libvirt] [PATCH] parallels: implement .domainGetMaxMemory
by Dmitry Guryanov 23 Apr '15

23 Apr '15

Since we haven't implemented balloon parameters tuning we can just return amount of memory in this function. Signed-off-by: Dmitry Guryanov <dguryanov(a)parallels.com> --- src/parallels/parallels_driver.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c index 391e927..d13a4e2 100644 --- a/src/parallels/parallels_driver.c +++ b/src/parallels/parallels_driver.c @@ -1089,6 +1089,24 @@ parallelsDomainManagedSaveRemove(virDomainPtr domain, unsigned int flags) return ret; } +static unsigned long long +parallelsDomainGetMaxMemory(virDomainPtr domain) +{ + parallelsConnPtr privconn = domain->conn->privateData; + virDomainObjPtr dom = NULL; + int ret = -1; + + dom = virDomainObjListFindByUUID(privconn->domains, domain->uuid); + if (dom == NULL) { + parallelsDomNotFoundError(domain); + return -1; + } + + ret = dom->def->mem.max_balloon; + virObjectUnlock(dom); + return ret; +} + static virHypervisorDriver parallelsDriver = { .name = "Parallels", .connectOpen = parallelsConnectOpen, /* 0.10.0 */ @@ -1133,6 +1151,7 @@ static virHypervisorDriver parallelsDriver = { .domainHasManagedSaveImage = parallelsDomainHasManagedSaveImage, /* 1.2.13 */ .domainManagedSave = parallelsDomainManagedSave, /* 1.2.14 */ .domainManagedSaveRemove = parallelsDomainManagedSaveRemove, /* 1.2.14 */ + .domainGetMaxMemory = parallelsDomainGetMaxMemory, /* 1.2.14 */ }; static virConnectDriver parallelsConnectDriver = { -- 2.1.0

2 3

[libvirt] [PATCH 0/2] parallels: some fixes
by Maxim Nestratov 23 Apr '15

23 Apr '15

Maxim Nestratov (2): parallels: fix crash in prlsdkAddNet in case of CT definition parallels: fix IS_CT macro

2 5

[libvirt] [PATCH 0/4] Introduce parallelsDomObjFromDomain()
by Michal Privoznik 23 Apr '15

23 Apr '15

We have such wrapper in other drivers too: qemu, lxc, network, ... Michal Privoznik (4): struct _parallelsConn: Mark @domains as immutable pointer parallels: Introduce parallelsDomObjFromDomain() parallels_driver: Utilize parallelsDomObjFromDomain() parallels_sdk: Utilize parallelsDomObjFromDomain() src/parallels/parallels_driver.c | 93 ++++++---------------------------------- src/parallels/parallels_sdk.c | 5 +-- src/parallels/parallels_utils.c | 32 ++++++++++++++ src/parallels/parallels_utils.h | 5 +++ 4 files changed, 51 insertions(+), 84 deletions(-) -- 2.0.5

3 7

[libvirt] [PATCH] qemu: lock: unlock vm during qemuBuildCommandLine
by zhang bo 23 Apr '15

23 Apr '15

The function qemuBuildCommandLine() may take a long time, for example if we configure tens of vifs for the guest, each may cost hundrands of milliseconds to create tap dev, senconds in total. Thus, unlock vm before calling it. Signed-off-by: Zhang Bo <oscar.zhangbo(a)huawei.com> Signed-off-by: Zhou Yimin <zhouyimin(a)huawei.com> --- src/qemu/qemu_process.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 753afe8..d1aaaec 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -4628,14 +4628,18 @@ int qemuProcessStart(virConnectPtr conn, } VIR_DEBUG("Building emulator command line"); + virObjectUnlock(vm); if (!(cmd = qemuBuildCommandLine(conn, driver, vm->def, priv->monConfig, priv->monJSON, priv->qemuCaps, migrateFrom, stdin_fd, snapshot, vmop, &buildCommandLineCallbacks, false, qemuCheckFips(), priv->autoNodeset, - &nnicindexes, &nicindexes))) + &nnicindexes, &nicindexes))) { + virObjectLock(vm); goto cleanup; + } + virObjectLock(vm); /* now that we know it is about to start call the hook if present */ if (virHookPresent(VIR_HOOK_DRIVER_QEMU)) { -- 1.7.12.4

4 11

[libvirt] [RFCv2 PoCv1 PATCH 00/15] Just Admin API
by Martin Kletzander 23 Apr '15

23 Apr '15

*** BLURB *** ... Just kidding :) Sooo... After very very VERY long time, here's a draft of an admin interface that is supposed to open up new possibilities to be done on a live daemon. The aim here is to create some first inches of that API in order to open up the possibility of new API function creation to more people. I already spent so much time explaining so much of that that I don't know what else to point at in here. Maybe the fact that last three patches are just an example on how this might work. Of course there won't be any functions like listClientIDs with the need of getting each client info by another API. There's going to be e.g. virAdmClientInfo and virAdmGetClients() will return the list of them, etc. Long story short, let's not repeat past mistakes ;) With all that said, feel free to hate, love, comment or just try out compiling this series and let me know how many things I've missed and screwed up (hopefully zero). Martin Kletzander (15): util: add virJSONValueCopy util: Add virabstracts file for keeping abstract classes datatypes: Use abstract connect class in virConnect Break virNetServer into virNetSubServers Teach gendispatch how to handle admin dispatching files Add admin protocol Build client headers for admin protocol Add admin error domain Add libvirt-admin library Add XML files with admin API specification Add configuration options for permissions on daemon's admin socket Add support for admin API in libvirt daemon rpc: Add virNetSubServerGetNClients admin: Add virAdmHello function Example virt-admin .gitignore | 5 + Makefile.am | 4 +- cfg.mk | 11 +- configure.ac | 19 +- daemon/Makefile.am | 33 +- daemon/admin_server.c | 119 +++++ daemon/admin_server.h | 36 ++ daemon/libvirtd-config.c | 5 +- daemon/libvirtd-config.h | 1 + daemon/libvirtd.aug | 1 + daemon/libvirtd.c | 138 ++++-- daemon/libvirtd.conf | 8 + daemon/libvirtd.h | 14 +- daemon/remote.c | 194 ++++----- daemon/test_libvirtd.aug.in | 1 + docs/Makefile.am | 23 +- docs/apibuild.py | 10 +- include/libvirt/Makefile.am | 6 +- include/libvirt/libvirt-admin.h | 63 +++ include/libvirt/virterror.h | 3 +- libvirt-admin.pc.in | 13 + libvirt.spec.in | 10 + po/POTFILES.in | 3 + src/Makefile.am | 134 +++++- src/admin/admin_protocol.x | 73 ++++ src/admin_protocol-structs | 17 + src/datatypes.c | 39 +- src/datatypes.h | 45 +- src/internal.h | 1 + src/libvirt-admin.c | 363 ++++++++++++++++ src/libvirt-host.c | 3 +- src/libvirt_admin.syms | 19 + src/libvirt_private.syms | 6 + src/libvirt_remote.syms | 17 +- src/locking/lock_daemon.c | 40 +- src/locking/lock_daemon_dispatch.c | 18 +- src/lxc/lxc_controller.c | 18 +- src/rpc/gendispatch.pl | 141 +++--- src/rpc/virnetserver.c | 859 +++++++++++++------------------------ src/rpc/virnetserver.h | 61 +-- src/rpc/virnetserverprogram.c | 12 +- src/rpc/virnetserverprogram.h | 9 +- src/rpc/virnetsubserver.c | 672 +++++++++++++++++++++++++++++ src/rpc/virnetsubserver.h | 78 ++++ src/util/virabstracts.c | 100 +++++ src/util/virabstracts.h | 57 +++ src/util/virerror.c | 95 ++-- src/util/virerror.h | 4 +- src/util/virjson.c | 65 ++- src/util/virjson.h | 4 +- tests/confdata/libvirtd.conf | 6 + tests/confdata/libvirtd.out | 5 + tests/jsontest.c | 111 +++++ tools/virt-admin/Makefile.am | 70 +++ tools/virt-admin/virt-admin.c | 68 +++ tools/virt-admin/virt-admin.pod | 43 ++ 56 files changed, 3092 insertions(+), 881 deletions(-) create mode 100644 daemon/admin_server.c create mode 100644 daemon/admin_server.h create mode 100644 include/libvirt/libvirt-admin.h create mode 100644 libvirt-admin.pc.in create mode 100644 src/admin/admin_protocol.x create mode 100644 src/admin_protocol-structs create mode 100644 src/libvirt-admin.c create mode 100644 src/libvirt_admin.syms create mode 100644 src/rpc/virnetsubserver.c create mode 100644 src/rpc/virnetsubserver.h create mode 100644 src/util/virabstracts.c create mode 100644 src/util/virabstracts.h create mode 100644 tools/virt-admin/Makefile.am create mode 100644 tools/virt-admin/virt-admin.c create mode 100644 tools/virt-admin/virt-admin.pod -- 2.3.5

4 29

[libvirt] [PATCH] rng: fix port number range validation
by Daniel P. Berrange 23 Apr '15

23 Apr '15

The PortNumber data type is declared to derive from 'short'. Unfortunately this is an signed type, so validates the range [-32,768, 32,767] which excludes valid port numbers between 32767 and 65535. We can't use 'unsignedShort', since we need -1 to be a valid port number too. This change is to use 'int' and set an explicit max boundary instead of relying on the data types' built-in max. One of the existing tests is changed to use a high port number to validate the schema. https://bugzilla.redhat.com/show_bug.cgi?id=1214664 Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- docs/schemas/basictypes.rng | 3 ++- tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-policy.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-policy.xml | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/schemas/basictypes.rng b/docs/schemas/basictypes.rng index f086ad2..a83063a 100644 --- a/docs/schemas/basictypes.rng +++ b/docs/schemas/basictypes.rng @@ -349,8 +349,9 @@ </define> <define name="PortNumber"> - <data type="short"> + <data type="int"> <param name="minInclusive">-1</param> + <param name="maxInclusive">65535</param> </data> </define> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-policy.args b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-policy.args index 1b61fcf..34dc767 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-policy.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-policy.args @@ -1,4 +1,4 @@ LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test QEMU_AUDIO_DRV=none \ /usr/bin/qemu -S -M pc -m 214 -smp 1 -monitor unix:/tmp/test-monitor,server,nowait \ -no-acpi -boot c -usb -hda /dev/HostVG/QEMUGuest1 \ --net none -serial none -parallel none -vnc 127.0.0.1:0,share=allow-exclusive +-net none -serial none -parallel none -vnc 127.0.0.1:59630,share=allow-exclusive diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-policy.xml b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-policy.xml index f78ff48..4b88e49 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-policy.xml +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-policy.xml @@ -25,7 +25,7 @@ <controller type='pci' index='0' model='pci-root'/> <input type='mouse' bus='ps2'/> <input type='keyboard' bus='ps2'/> - <graphics type='vnc' port='5900' autoport='no' listen='127.0.0.1' sharePolicy='allow-exclusive'> + <graphics type='vnc' port='65530' autoport='no' listen='127.0.0.1' sharePolicy='allow-exclusive'> <listen type='address' address='127.0.0.1'/> </graphics> <video> -- 2.1.0

2 1

[libvirt] [PATCH 0/2] Apparmor PCI passthrough fixes
by Cédric Bosdonnat 23 Apr '15

23 Apr '15

Hi all, These two simple patches intend to fix apparmor profiles for PCI passthrough with the qemu driver. Cédric Bosdonnat (2): Allow access to vendor and device file for PCI device passthrough Apparmor: allow reading block-rbd.so examples/apparmor/libvirt-qemu | 1 + src/util/virpci.c | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) -- 2.1.4

2 3

[libvirt] [PATCH] util: string: Avoid use of deprecated function index()
by Peter Krempa 23 Apr '15

23 Apr '15

--- src/util/virstring.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/src/util/virstring.c b/src/util/virstring.c index 1cd4987..e48c29a 100644 --- a/src/util/virstring.c +++ b/src/util/virstring.c @@ -976,6 +976,21 @@ static const char control_chars[] = "\x10\x11\x12\x13\x14\x15\x16\x17" "\x18\x19\x1A\x1B\x1C\x1D\x1E\x1F"; + +static bool +virStringIsControlChar(char c) +{ + const char *cch; + + for (cch = control_chars; *cch; cch++) { + if (*cch == c) + return true; + } + + return false; +} + + bool virStringHasControlChars(const char *str) { @@ -1003,7 +1018,7 @@ virStringStripControlChars(char *str) len = strlen(str); for (i = 0, j = 0; i < len; i++) { - if (index(control_chars, str[i])) + if (virStringIsControlChar(str[i])) continue; str[j++] = str[i]; -- 2.3.5

2 1

[libvirt] [PATCH] qemu: Don't fail to reboot domains with unresponsive agent
by zhang bo 23 Apr '15

23 Apr '15

just as what b8e25c35d7f80a2fadc0e51e95318e39db3d1687 did, we fall back to the ACPI method when the guest agent is unresponsive in qemuDomainReboot. Signed-off-by: YueWenyuan <yuewenyuan(a)huawei.com> Signed-off-by: Zhang Bo <oscar.zhangbo(a)huawei.com> --- src/qemu/qemu_driver.c | 67 +++++++++++++++++++++++++------------------------- 1 file changed, 34 insertions(+), 33 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 6fc9696..964a9c5 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2002,21 +2002,14 @@ qemuDomainReboot(virDomainPtr dom, unsigned int flags) virDomainObjPtr vm; int ret = -1; qemuDomainObjPrivatePtr priv; - bool useAgent = false; + bool useAgent = false, agentRequested, acpiRequested; bool isReboot = true; + bool agentForced; int agentFlag = QEMU_AGENT_SHUTDOWN_REBOOT; virCheckFlags(VIR_DOMAIN_REBOOT_ACPI_POWER_BTN | VIR_DOMAIN_REBOOT_GUEST_AGENT, -1); - /* At most one of these two flags should be set. */ - if ((flags & VIR_DOMAIN_REBOOT_ACPI_POWER_BTN) && - (flags & VIR_DOMAIN_REBOOT_GUEST_AGENT)) { - virReportInvalidArg(flags, "%s", - _("flags for acpi power button and guest agent are mutually exclusive")); - return -1; - } - if (!(vm = qemuDomObjFromDomain(dom))) goto cleanup; @@ -2028,38 +2021,25 @@ qemuDomainReboot(virDomainPtr dom, unsigned int flags) } priv = vm->privateData; + agentRequested = flags & VIR_DOMAIN_REBOOT_GUEST_AGENT; + acpiRequested = flags & VIR_DOMAIN_REBOOT_ACPI_POWER_BTN; if (virDomainRebootEnsureACL(dom->conn, vm->def, flags) < 0) goto cleanup; - if ((flags & VIR_DOMAIN_REBOOT_GUEST_AGENT) || - (!(flags & VIR_DOMAIN_REBOOT_ACPI_POWER_BTN) && - priv->agent)) + /* Prefer agent unless we were requested to not to. */ + if (agentRequested || (!flags && priv->agent)) useAgent = true; - if (!useAgent) { -#if WITH_YAJL - if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_MONITOR_JSON)) { - if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_NO_SHUTDOWN)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Reboot is not supported with this QEMU binary")); - goto cleanup; - } - } else { -#endif - virReportError(VIR_ERR_OPERATION_INVALID, "%s", - _("Reboot is not supported without the JSON monitor")); - goto cleanup; -#if WITH_YAJL - } -#endif - } - if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_MODIFY) < 0) goto cleanup; - if (useAgent && !qemuDomainAgentAvailable(vm, true)) - goto endjob; + agentForced = agentRequested && !acpiRequested; + if (useAgent && !qemuDomainAgentAvailable(vm, true)) { + if (agentForced) + goto endjob; + useAgent = false; + } if (!virDomainObjIsActive(vm)) { virReportError(VIR_ERR_OPERATION_INVALID, @@ -2071,7 +2051,28 @@ qemuDomainReboot(virDomainPtr dom, unsigned int flags) qemuDomainObjEnterAgent(vm); ret = qemuAgentShutdown(priv->agent, agentFlag); qemuDomainObjExitAgent(vm); - } else { + } + + /* If we are not enforced to use just an agent, try ACPI + * shutdown as well in case agent did not succeed. + */ + if ((!useAgent) || + (ret < 0 && (acpiRequested || !flags))) { +#if WITH_YAJL + if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_MONITOR_JSON)) { + if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_NO_SHUTDOWN)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("ACPI reboot is not supported with this QEMU binary")); + goto endjob; + } + } else { +#endif + virReportError(VIR_ERR_OPERATION_INVALID, "%s", + _("ACPI reboot is not supported without the JSON monitor")); + goto endjob; +#if WITH_YAJL + } +#endif qemuDomainObjEnterMonitor(driver, vm); ret = qemuMonitorSystemPowerdown(priv->mon); if (qemuDomainObjExitMonitor(driver, vm) < 0) -- 1.7.12.4

2 1

[libvirt] [PATCH] bhyve: fix build in tests
by Roman Bogorodskiy 23 Apr '15

23 Apr '15

Commit 835cf84 dropped expectedVirtTypes argument for virDomainDefParse*() functions, however bhyve tests still try to pass that to virDomainDefParseFile(), therefore build fails. Fix build by fixing virDomainDefParseFile() usage. --- tests/bhyvexml2argvtest.c | 1 - tests/bhyvexml2xmltest.c | 1 - 2 files changed, 2 deletions(-) diff --git a/tests/bhyvexml2argvtest.c b/tests/bhyvexml2argvtest.c index c5b0681..26d0075 100644 --- a/tests/bhyvexml2argvtest.c +++ b/tests/bhyvexml2argvtest.c @@ -32,7 +32,6 @@ static int testCompareXMLToArgvFiles(const char *xml, goto out; if (!(vmdef = virDomainDefParseFile(xml, driver.caps, driver.xmlopt, - 1 << VIR_DOMAIN_VIRT_BHYVE, VIR_DOMAIN_DEF_PARSE_INACTIVE))) goto out; diff --git a/tests/bhyvexml2xmltest.c b/tests/bhyvexml2xmltest.c index a1a3701..2e742cf 100644 --- a/tests/bhyvexml2xmltest.c +++ b/tests/bhyvexml2xmltest.c @@ -27,7 +27,6 @@ testCompareXMLToXMLFiles(const char *inxml, const char *outxml) goto fail; if (!(def = virDomainDefParseString(inXmlData, driver.caps, driver.xmlopt, - 1 << VIR_DOMAIN_VIRT_BHYVE, VIR_DOMAIN_DEF_PARSE_INACTIVE))) goto fail; -- 2.3.5

2 2

[libvirt] [PATCH] configure: Report --with-loader-nvram value in summary
by Cole Robinson 23 Apr '15

23 Apr '15

--- configure.ac | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.ac b/configure.ac index 7f6fd7c..d5fb71d 100644 --- a/configure.ac +++ b/configure.ac @@ -2980,6 +2980,7 @@ AC_MSG_NOTICE([ XML Catalog: $XML_CATALOG_FILE]) AC_MSG_NOTICE([ Init script: $with_init_script]) AC_MSG_NOTICE([Char device locks: $with_chrdev_lock_files]) AC_MSG_NOTICE([ Default Editor: $DEFAULT_EDITOR]) +AC_MSG_NOTICE([ Loader/NVRAM: $with_loader_nvram]) AC_MSG_NOTICE([]) AC_MSG_NOTICE([Developer Tools]) AC_MSG_NOTICE([]) -- 2.3.5

2 4

[libvirt] [PATCH V2 0/2] Support libvirt's lock manager in the libxl driver
by Jim Fehlig 22 Apr '15

22 Apr '15

V2 of https://www.redhat.com/archives/libvir-list/2015-April/msg00845.html Patch 2 has been ACKed and pushed since it is independent of the lock manager integration. Patch 1 has been changed to address Daniel's comments. Patch 2 (was patch 3 in V1) is unchanged for the time being. Jim Fehlig (2): locking: relax PID requirement libxl: provide integration with lock manager src/Makefile.am | 12 +++++++++ src/libxl/libvirtd_libxl.aug | 2 ++ src/libxl/libxl.conf | 10 ++++++++ src/libxl/libxl_conf.c | 14 +++++++++++ src/libxl/libxl_conf.h | 6 +++++ src/libxl/libxl_domain.c | 47 ++++++++++++++++++++++++++++++++++-- src/libxl/libxl_domain.h | 1 + src/libxl/libxl_driver.c | 25 +++++++++++++++++++ src/libxl/libxl_migration.c | 6 +++++ src/libxl/test_libvirtd_libxl.aug.in | 1 + src/locking/lock_daemon.c | 2 +- src/locking/lock_daemon_dispatch.c | 16 ++++++------ src/locking/lock_driver_lockd.c | 7 ++---- 13 files changed, 133 insertions(+), 16 deletions(-) -- 1.8.4.5

2 4

[libvirt] [PATCH] spec: Fix libxl build with driver modules
by Cole Robinson 22 Apr '15

22 Apr '15

--- Pushed as build breaker libvirt.spec.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index 5d8a9d4..c5c6608 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -2127,6 +2127,9 @@ exit 0 %if %{with_libxl} %files daemon-driver-libxl %defattr(-, root, root) +%config(noreplace) %{_sysconfdir}/libvirt/libxl.conf +%{_datadir}/augeas/lenses/libvirtd_libxl.aug +%{_datadir}/augeas/lenses/tests/test_libvirtd_libxl.aug %dir %attr(0700, root, root) %{_localstatedir}/log/libvirt/libxl/ %ghost %dir %{_localstatedir}/run/libvirt/libxl/ %dir %attr(0700, root, root) %{_localstatedir}/lib/libvirt/libxl/ -- 2.3.5

1 0

[libvirt] [PATCH] configure: Fix --loader-nvram typo
by Cole Robinson 22 Apr '15

22 Apr '15

--- Pushed as trivial configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index aed0934..7f6fd7c 100644 --- a/configure.ac +++ b/configure.ac @@ -2776,7 +2776,7 @@ AC_ARG_WITH([loader-nvram], fi AC_DEFINE_UNQUOTED([DEFAULT_LOADER_NVRAM], ["$withval"], - [List of laoder:nvram pairs])]) + [List of loader:nvram pairs])]) # Some GNULIB base64 symbols clash with a kerberos library AC_DEFINE_UNQUOTED([isbase64],[libvirt_gl_isbase64],[Hack to avoid symbol clash]) -- 2.3.5

1 0

[libvirt] [PATCH] parallels: don't forget to unlock domain after successful virDomainObjListFindByUUID call
by Maxim Nestratov 22 Apr '15

22 Apr '15

Also a typo is fixed (s/detached/attached/) Signed-off-by: Maxim Nestratov mnestratov(a)parallels.com --- src/parallels/parallels_driver.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c index 46e6c3e..41908a5 100644 --- a/src/parallels/parallels_driver.c +++ b/src/parallels/parallels_driver.c @@ -1081,7 +1081,7 @@ static int parallelsDomainAttachDeviceFlags(virDomainPtr dom, const char *xml, privdom = virDomainObjListFindByUUID(privconn->domains, dom->uuid); if (privdom == NULL) { parallelsDomNotFoundError(dom); - goto cleanup; + return -1; } if (!(flags & VIR_DOMAIN_AFFECT_CONFIG)) { @@ -1120,13 +1120,14 @@ static int parallelsDomainAttachDeviceFlags(virDomainPtr dom, const char *xml, break; default: virReportError(VIR_ERR_OPERATION_UNSUPPORTED, - _("device type '%s' cannot be detached"), + _("device type '%s' cannot be attached"), virDomainDeviceTypeToString(dev->type)); break; } ret = 0; cleanup: + virObjectUnlock(privdom); return ret; } -- 1.7.1

2 2

[libvirt] [PATCH 0/3] Support libvirt's lock manager in the libxl driver
by Jim Fehlig 22 Apr '15

22 Apr '15

Patch 1 relaxes the requirement of PID != 0 in the locking code. danpb and I discussed this on IRC: danpb: jimfehlig: it wouldn't be the end of the world if you leave pid as 0 danpb: jimfehlig: it'd just loose some safety sanity check in that scenario Patch 2 introduces a config file for the libxl driver, with the lone config entry 'autoballoon'. I thought this would make review easier, vs adding all the config file support in patch 3, which is fairly large as is. Jim Fehlig (3): locking: relax PID requirement libxl: Introduce configuration file for libxl driver libxl: provide integration with lock manager libvirt.spec.in | 8 ++++ src/Makefile.am | 36 ++++++++++++++++- src/libxl/libvirtd_libxl.aug | 44 +++++++++++++++++++++ src/libxl/libxl.conf | 22 +++++++++++ src/libxl/libxl_conf.c | 75 +++++++++++++++++++++++++++++++++--- src/libxl/libxl_conf.h | 11 ++++++ src/libxl/libxl_domain.c | 47 +++++++++++++++++++++- src/libxl/libxl_domain.h | 1 + src/libxl/libxl_driver.c | 34 ++++++++++++++++ src/libxl/libxl_migration.c | 6 +++ src/libxl/test_libvirtd_libxl.aug.in | 6 +++ src/locking/lock_daemon.c | 2 +- src/locking/lock_daemon_dispatch.c | 49 +++++++---------------- src/locking/lock_driver_lockd.c | 7 +--- 14 files changed, 298 insertions(+), 50 deletions(-) create mode 100644 src/libxl/libvirtd_libxl.aug create mode 100644 src/libxl/libxl.conf create mode 100644 src/libxl/test_libvirtd_libxl.aug.in -- 1.8.4.5

2 10

[libvirt] [PATCH 0/2] Add tox.ini to run tests with tox
by Victor Stinner 22 Apr '15

22 Apr '15

Tox is a convinient tool creating virtual environment to install dependencies and run tests. To run all tests, just type "tox". To only test a specific Python version, use "tox -e py34" (Python 3.4). Victor Stinner (2): sanitytest.py parameters are now optional Add tox.ini to run tests on Python 2.6, 2.7 & 3.4 .gitignore | 1 + sanitytest.py | 23 ++++++++++++++++++----- tox.ini | 10 ++++++++++ 3 files changed, 29 insertions(+), 5 deletions(-) create mode 100644 tox.ini -- 2.1.0

4 8