- Devel - libvirt List Archives

[libvirt] [PATCH] virsh: Don't output node frequency if unknown
by Martin Kletzander 15 Jul '15

15 Jul '15

Commit ed8155eafbff5c5ca0bdfe84a8388f58b718c2f9 documented that mhz field in virNodeInfo might be 0 if the frequency is unknown. Modify virsh to know about that. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- tools/virsh-host.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/virsh-host.c b/tools/virsh-host.c index 66f7fd9e62e4..7a223931b152 100644 --- a/tools/virsh-host.c +++ b/tools/virsh-host.c @@ -606,7 +606,8 @@ cmdNodeinfo(vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED) } vshPrint(ctl, "%-20s %s\n", _("CPU model:"), info.model); vshPrint(ctl, "%-20s %d\n", _("CPU(s):"), info.cpus); - vshPrint(ctl, "%-20s %d MHz\n", _("CPU frequency:"), info.mhz); + if (info.mhz) + vshPrint(ctl, "%-20s %d MHz\n", _("CPU frequency:"), info.mhz); vshPrint(ctl, "%-20s %d\n", _("CPU socket(s):"), info.sockets); vshPrint(ctl, "%-20s %d\n", _("Core(s) per socket:"), info.cores); vshPrint(ctl, "%-20s %d\n", _("Thread(s) per core:"), info.threads); -- 2.4.5

2 3

[libvirt] [PATCH 0/3] qemu: virtio-9p-ccw support
by Boris Fiuczynski 15 Jul '15

15 Jul '15

Adding support and a test for virtio-9p-ccw. Changing the default from virtio-9p-pci to virtio-9p-ccw for s390-ccw-virtio machines. Boris Fiuczynski (3): qemu: Support for virtio-9p-ccw qemu: Make virtio-9p-ccw the default for s390-ccw-virtio machines qemu: Test for virtio-9p-ccw support src/qemu/qemu_command.c | 14 ++++++++- tests/qemuxml2argvdata/qemuxml2argv-fs9p-ccw.args | 16 ++++++++++ tests/qemuxml2argvdata/qemuxml2argv-fs9p-ccw.xml | 36 +++++++++++++++++++++++ tests/qemuxml2argvtest.c | 4 +++ 4 files changed, 69 insertions(+), 1 deletion(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-fs9p-ccw.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-fs9p-ccw.xml -- 1.8.1.4

2 5

[libvirt] [PATCH] daemonRunStateInit: Fix a typo on a comment
by Michal Privoznik 15 Jul '15

15 Jul '15

s/priviledged/privileged/ Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under trivial and who-cares rules. daemon/libvirtd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index 654e7f4..71db4a0 100644 --- a/daemon/libvirtd.c +++ b/daemon/libvirtd.c @@ -956,7 +956,7 @@ static void daemonRunStateInit(void *opaque) driversInitialized = true; #ifdef HAVE_DBUS - /* Tie the non-priviledged libvirtd to the session/shutdown lifecycle */ + /* Tie the non-privileged libvirtd to the session/shutdown lifecycle */ if (!virNetDaemonIsPrivileged(dmn)) { sessionBus = virDBusGetSessionBus(); -- 2.3.6

1 0

[libvirt] [PATCH 1/6] vz: add migration backbone code
by nshirokovskiy＠virtuozzo.com 15 Jul '15

15 Jul '15

From: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> This patch makes basic vz migration possible. For example by virsh: virsh -c vz:///system migrate $NAME vz+ssh://$DST/system Vz migration is implemented thru interface for managed migrations for drivers although it looks like a candadate for direct migration as all work is done by vz sdk. The reason is that vz sdk lacks rich remote authentication capabilities of libvirt and if we choose to implement direct migration we have to reimplement auth means of libvirt. This brings the requirement that destination side should have running libvirt daemon. This is not the problem as vz is moving in the direction of tight integration with libvirt. Another issue of this choice is that if the managment migration fails on 'finish' step driver is supposed to resume on source. This is not compatible with vz sdk migration but this can be overcome without loosing a constistency, see comments in code. Technically we have a libvirt connection to destination in managed migration scheme and we use this connection to obtain a session_uuid (which acts as authZ token) for vz migration. This uuid is passed from destination through cookie on 'prepare' step. A few words on vz migration uri. I'd probably use just 'hostname:port' uris as we don't have different migration schemes in vz but scheme part is mandatory, so 'tcp' is used. Looks like good name. Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> --- src/vz/vz_driver.c | 250 ++++++++++++++++++++++++++++++++++++++++++++++++++++ src/vz/vz_sdk.c | 79 ++++++++++++++-- src/vz/vz_sdk.h | 2 + src/vz/vz_utils.h | 1 + 4 files changed, 322 insertions(+), 10 deletions(-) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index 9f0c52f..e003646 100644 --- a/src/vz/vz_driver.c +++ b/src/vz/vz_driver.c @@ -1343,6 +1343,250 @@ vzDomainMemoryStats(virDomainPtr domain, return ret; } +static int +vzConnectSupportsFeature(virConnectPtr conn ATTRIBUTE_UNUSED, int feature) +{ + switch (feature) { + case VIR_DRV_FEATURE_MIGRATION_PARAMS: + return 1; + default: + return 0; + } +} + +#define VZ_MIGRATION_PARAMETERS NULL + +static char * +vzDomainMigrateBegin3Params(virDomainPtr domain, + virTypedParameterPtr params, + int nparams, + char **cookieout ATTRIBUTE_UNUSED, + int *cookieoutlen ATTRIBUTE_UNUSED, + unsigned int fflags ATTRIBUTE_UNUSED) +{ + virDomainObjPtr dom = NULL; + char *xml = NULL; + + if (virTypedParamsValidate(params, nparams, VZ_MIGRATION_PARAMETERS) < 0) + goto cleanup; + + if (!(dom = vzDomObjFromDomain(domain))) + goto cleanup; + + xml = virDomainDefFormat(dom->def, VIR_DOMAIN_DEF_FORMAT_SECURE); + + cleanup: + if (dom) + virObjectUnlock(dom); + + return xml; +} + +/* return 'hostname' */ +static char * +vzCreateMigrateUri(void) +{ + char *hostname = NULL; + char *out = NULL; + virURI uri = {}; + + if ((hostname = virGetHostname()) == NULL) + goto cleanup; + + if (STRPREFIX(hostname, "localhost")) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("hostname on destination resolved to localhost," + " but migration requires an FQDN")); + goto cleanup; + } + + /* to set const string to non-const */ + if (VIR_STRDUP(uri.scheme, "tcp") < 0) + goto cleanup; + uri.server = hostname; + out = virURIFormat(&uri); + + cleanup: + VIR_FREE(hostname); + VIR_FREE(uri.scheme); + return out; +} + +static int +vzDomainMigratePrepare3Params(virConnectPtr dconn, + virTypedParameterPtr params ATTRIBUTE_UNUSED, + int nparams ATTRIBUTE_UNUSED, + const char *cookiein ATTRIBUTE_UNUSED, + int cookieinlen ATTRIBUTE_UNUSED, + char **cookieout, + int *cookieoutlen, + char **uri_out, + unsigned int fflags ATTRIBUTE_UNUSED) +{ + vzConnPtr privconn = dconn->privateData; + int ret = -1; + char uuidstr[VIR_UUID_STRING_BUFLEN]; + + *cookieout = NULL; + *uri_out = NULL; + + virUUIDFormat(privconn->session_uuid, uuidstr); + if (VIR_STRDUP(*cookieout, uuidstr) < 0) + goto cleanup; + *cookieoutlen = strlen(*cookieout) + 1; + + if (!(*uri_out = vzCreateMigrateUri())) + goto cleanup; + + ret = 0; + + cleanup: + if (ret != 0) { + VIR_FREE(*cookieout); + VIR_FREE(*uri_out); + *cookieoutlen = 0; + } + + return ret; +} + +static int +vzDomainMigratePerform3Params(virDomainPtr domain, + const char *dconnuri ATTRIBUTE_UNUSED, + virTypedParameterPtr params, + int nparams, + const char *cookiein, + int cookieinlen ATTRIBUTE_UNUSED, + char **cookieout, + int *cookieoutlen, + unsigned int fflags ATTRIBUTE_UNUSED) +{ + int ret = -1; + virDomainObjPtr dom = NULL; + const char *uri = NULL; + unsigned char session_uuid[VIR_UUID_BUFLEN]; + char uuidstr[VIR_UUID_STRING_BUFLEN]; + + *cookieout = NULL; + + if (virTypedParamsGetString(params, nparams, + VIR_MIGRATE_PARAM_URI, + &uri) < 0) + goto cleanup; + + if (!(dom = vzDomObjFromDomain(domain))) + goto cleanup; + + if (!uri) { + virReportError(VIR_ERR_INVALID_ARG, "%s", + _("migration URI should be provided")); + goto cleanup; + } + + if (virUUIDParse(cookiein, session_uuid) < 0) + goto cleanup; + + if (prlsdkMigrate(dom, uri, session_uuid) < 0) + goto cleanup; + + virUUIDFormat(domain->uuid, uuidstr); + if (VIR_STRDUP(*cookieout, uuidstr) < 0) + goto cleanup; + *cookieoutlen = strlen(*cookieout) + 1; + + ret = 0; + + cleanup: + if (dom) + virObjectUnlock(dom); + if (ret != 0) { + VIR_FREE(*cookieout); + *cookieoutlen = 0; + } + + return ret; +} + +/* if we return NULL from this function we are supposed + to cleanup destination side, but we can't do it + because 'perform' step is finished and migration is actually + completed by dispatcher. Unfortunately in OOM situation we + have to return NULL. As a result high level migration + function return NULL which is supposed to be + treated as migration error while migration is + actually successful. This should not be a problem + as we are in consistent state. For example later + attempts to list source and destination domains + will reveal actual situation. */ + +static virDomainPtr +vzDomainMigrateFinish3Params(virConnectPtr dconn, + virTypedParameterPtr params ATTRIBUTE_UNUSED, + int nparams ATTRIBUTE_UNUSED, + const char *cookiein, + int cookieinlen ATTRIBUTE_UNUSED, + char **cookieout ATTRIBUTE_UNUSED, + int *cookieoutlen ATTRIBUTE_UNUSED, + unsigned int fflags ATTRIBUTE_UNUSED, + int cancelled) +{ + vzConnPtr privconn = dconn->privateData; + virDomainObjPtr dom = NULL; + virDomainPtr domain = NULL; + unsigned char domain_uuid[VIR_UUID_BUFLEN]; + + /* we have nothing to cleanup, whole job is done by PCS dispatcher */ + if (cancelled) + return NULL; + + if (virUUIDParse(cookiein, domain_uuid) < 0) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Could not parse UUID from string '%s'"), + cookiein); + goto cleanup; + } + + if (!(dom = prlsdkAddDomain(privconn, domain_uuid))) + goto cleanup; + + domain = virGetDomain(dconn, dom->def->name, dom->def->uuid); + if (domain) + domain->id = dom->def->id; + + cleanup: + if (!domain) + VIR_WARN("Can't provide domain with uuid '%s' after successfull migration.", cookiein); + virDomainObjEndAPI(&dom); + return domain; +} + +/* This is executed only if 'perform' step is successfull that + is migration is completed by PCS dispatcher. Thus we should + ignore 'canceled' parameter and always kill source domain. */ +static int +vzDomainMigrateConfirm3Params(virDomainPtr domain, + virTypedParameterPtr params ATTRIBUTE_UNUSED, + int nparams ATTRIBUTE_UNUSED, + const char *cookiein ATTRIBUTE_UNUSED, + int cookieinlen ATTRIBUTE_UNUSED, + unsigned int fflags ATTRIBUTE_UNUSED, + int cancelled ATTRIBUTE_UNUSED) +{ + vzConnPtr privconn = domain->conn->privateData; + virDomainObjPtr dom = NULL; + + if (!(dom = vzDomObjFromDomain(domain))) + goto cleanup; + + virDomainObjListRemove(privconn->domains, dom); + + cleanup: + if (dom) + virObjectUnlock(dom); + + return 0; +} + static virHypervisorDriver vzDriver = { .name = "vz", .connectOpen = vzConnectOpen, /* 0.10.0 */ @@ -1396,6 +1640,12 @@ static virHypervisorDriver vzDriver = { .domainBlockStatsFlags = vzDomainBlockStatsFlags, /* 1.2.17 */ .domainInterfaceStats = vzDomainInterfaceStats, /* 1.2.17 */ .domainMemoryStats = vzDomainMemoryStats, /* 1.2.17 */ + .connectSupportsFeature = vzConnectSupportsFeature, /* 1.2.18 */ + .domainMigrateBegin3Params = vzDomainMigrateBegin3Params, /* 1.2.18 */ + .domainMigratePrepare3Params = vzDomainMigratePrepare3Params, /* 1.2.18 */ + .domainMigratePerform3Params = vzDomainMigratePerform3Params, /* 1.2.18 */ + .domainMigrateFinish3Params = vzDomainMigrateFinish3Params, /* 1.2.18 */ + .domainMigrateConfirm3Params = vzDomainMigrateConfirm3Params, /* 1.2.18 */ }; static virConnectDriver vzConnectDriver = { diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index d1bc312..908bfc1 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -37,6 +37,9 @@ #define VIR_FROM_THIS VIR_FROM_PARALLELS #define JOB_INFINIT_WAIT_TIMEOUT UINT_MAX +static int +prlsdkUUIDParse(const char *uuidstr, unsigned char *uuid); + VIR_LOG_INIT("parallels.sdk"); /* @@ -228,24 +231,40 @@ prlsdkDeinit(void) int prlsdkConnect(vzConnPtr privconn) { - PRL_RESULT ret; + int ret = -1; + PRL_RESULT pret; PRL_HANDLE job = PRL_INVALID_HANDLE; + PRL_HANDLE result = PRL_INVALID_HANDLE; + PRL_HANDLE response = PRL_INVALID_HANDLE; + char session_uuid[VIR_UUID_STRING_BUFLEN + 2]; + PRL_UINT32 buflen = ARRAY_CARDINALITY(session_uuid); - ret = PrlSrv_Create(&privconn->server); - if (PRL_FAILED(ret)) { - logPrlError(ret); - return -1; - } + pret = PrlSrv_Create(&privconn->server); + prlsdkCheckRetGoto(pret, cleanup); job = PrlSrv_LoginLocalEx(privconn->server, NULL, 0, PSL_HIGH_SECURITY, PACF_NON_INTERACTIVE_MODE); + if (PRL_FAILED(getJobResult(job, &result))) + goto cleanup; + + pret = PrlResult_GetParam(result, &response); + prlsdkCheckRetGoto(pret, cleanup); + + pret = PrlLoginResponse_GetSessionUuid(response, session_uuid, &buflen); + prlsdkCheckRetGoto(pret, cleanup); + + if (prlsdkUUIDParse(session_uuid, privconn->session_uuid) < 0) + goto cleanup; + + ret = 0; - if (waitJob(job)) { + cleanup: + if (ret < 0) PrlHandle_Free(privconn->server); - return -1; - } + PrlHandle_Free(result); + PrlHandle_Free(response); - return 0; + return ret; } void @@ -4035,3 +4054,43 @@ prlsdkGetMemoryStats(virDomainObjPtr dom, return ret; } + +/* high security is default choice for 2 reasons: + 1. as this is the highest set security we can't get + reject from server with high security settings + 2. this is on par with security level of driver + connection to dispatcher */ + +#define PRLSDK_MIGRATION_FLAGS (PSL_HIGH_SECURITY) + +int prlsdkMigrate(virDomainObjPtr dom, const char* uri_str, + const unsigned char *session_uuid) +{ + int ret = -1; + vzDomObjPtr privdom = dom->privateData; + virURIPtr uri = NULL; + PRL_HANDLE job = PRL_INVALID_HANDLE; + char uuidstr[VIR_UUID_STRING_BUFLEN + 2]; + + uri = virURIParse(uri_str); + /* no special error logs as uri should be checked on prepare step */ + if (uri == NULL) + goto cleanup; + + prlsdkUUIDFormat(session_uuid, uuidstr); + job = PrlVm_MigrateEx(privdom->sdkdom, uri->server, uri->port, uuidstr, + "", /* use default dir for migrated instance bundle */ + PRLSDK_MIGRATION_FLAGS, + 0, /* reserved flags */ + PRL_TRUE /* don't ask for confirmations */ + ); + + if (PRL_FAILED(waitJob(job))) + goto cleanup; + + ret = 0; + + cleanup: + virURIFree(uri); + return ret; +} diff --git a/src/vz/vz_sdk.h b/src/vz/vz_sdk.h index ebe4591..1a90eca 100644 --- a/src/vz/vz_sdk.h +++ b/src/vz/vz_sdk.h @@ -76,3 +76,5 @@ int prlsdkGetVcpuStats(virDomainObjPtr dom, int idx, unsigned long long *time); int prlsdkGetMemoryStats(virDomainObjPtr dom, virDomainMemoryStatPtr stats, unsigned int nr_stats); +int +prlsdkMigrate(virDomainObjPtr dom, const char* uri_str, const char unsigned *session_uuid); diff --git a/src/vz/vz_utils.h b/src/vz/vz_utils.h index db09647..a779b03 100644 --- a/src/vz/vz_utils.h +++ b/src/vz/vz_utils.h @@ -62,6 +62,7 @@ struct _vzConn { virDomainObjListPtr domains; PRL_HANDLE server; + unsigned char session_uuid[VIR_UUID_BUFLEN]; virStoragePoolObjList pools; virNetworkObjListPtr networks; virCapsPtr caps; -- 1.7.1

2 6

[libvirt] [PATCH 0/2] Fix some Coverity issues
by Michal Privoznik 15 Jul '15

15 Jul '15

*** BLURB HERE *** Michal Privoznik (2): qemuMigrationRun: Don't leak @fd cmdVcpuPin: Remove dead code src/qemu/qemu_migration.c | 2 +- tools/virsh-domain.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.3.6

3 5

Re: [libvirt] [PING: PATCH v4 0/3] Allow PCI virtio on ARM "virt" machine
by Pavel Fedin 15 Jul '15

15 Jul '15

Knock-knock!!! Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia > -----Original Message----- > From: libvir-list-bounces(a)redhat.com [mailto:libvir-list-bounces@redhat.com] On Behalf Of Pavel Fedin > Sent: Thursday, July 09, 2015 12:11 PM > To: libvir-list(a)redhat.com > Cc: Peter Krempa > Subject: [libvirt] [PATCH v4 0/3] Allow PCI virtio on ARM "virt" machine > > Virt machine in qemu since v2.3.0 has PCI generic host controller, and can use > PCI devices. This provides performance improvement as well as vhost-net with > irqfd support for virtio-net. However libvirt currently does not allow ARM virt > machine to have PCI devices. This patchset adds the necessary support. > > Changes since v3: > - Capability is based not on qemu version but on support of "gpex-pcihost" > device by qemu > - Added a workaround, allowing to pass "make check". The problem is that > test suite does not build capabilities cache. Unfortunately this means > that correct unit-test for the new functionality currently cannot be > written. Test suite framework needs to be improved. > Changes since v2: > Complete rework, use different approach > - Correctly model PCI Express bus on the machine. It is now possible to > explicitly specify <address-type='pci'> with attributes. This allows to > attach not only virtio, but any other PCI device to the model. > - Default is not changed and still mmio, for backwards compatibility with > existing installations. PCI bus has to be explicitly specified. > - Check for the capability in correct place, in v2 it actually did not work > Changes since v1: > - Added capability based on qemu version number > - Recognize also "virt-" prefix > > Pavel Fedin (3): > Introduce QEMU_CAPS_OBJECT_GPEX > Add PCI-Express root to ARM virt machine > Build correct command line for PCI NICs on ARM > > src/qemu/qemu_capabilities.c | 2 ++ > src/qemu/qemu_capabilities.h | 1 + > src/qemu/qemu_command.c | 3 ++- > src/qemu/qemu_domain.c | 17 +++++++++++++---- > 4 files changed, 18 insertions(+), 5 deletions(-) > > -- > 1.9.5.msysgit.0 > > -- > libvir-list mailing list > libvir-list(a)redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list

1 0

[libvirt] [PATCH 0/2] nodeinfo: Various cleanups
by Andrea Bolognani 14 Jul '15

14 Jul '15

The first patch builds on the sysfs_prefix work by John, while the the second one contains unrelated formatting changes that increase internal consistency. Neither introduces behavioral changes. Andrea Bolognani (2): nodeinfo: Make sysfs_prefix usage more consistent nodeinfo: Formatting changes src/nodeinfo.c | 73 ++++++++++++++++++++++++++-------------------------- src/nodeinfopriv.h | 4 +-- tests/nodeinfotest.c | 14 +++++----- 3 files changed, 46 insertions(+), 45 deletions(-) -- 2.4.3

2 3

[libvirt] [PATCH] virsh: Teach cmdFreepages to work with lxc driver
by Michal Privoznik 14 Jul '15

14 Jul '15

Some drivers don't expose available huge page sizes in the capabilities XML. For instance, LXC driver is one of those. This has a downside that when virsh is trying to get aggregated info on free pages per all NUMA nodes, it fails. The problem is that the virNodeGetFreePages() API expects caller to pass an array of page sizes he is interested in. In virsh, this array is filled from the capabilities from '/capabilities/host/cpu/pages' XPath. As said, in LXC there's no such XPath and therefore virsh fails currently. But hey, we can fallback: the page sizes are exposed under '/capabilities/host/topology/cells/cell/pages'. The page size can be collected from there, and voilà the command works again. But now we must make sure that there are no duplicates in the array passed to the public API. Otherwise we won't get as beautiful output as we are getting now. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tools/virsh-host.c | 37 ++++++++++++++++++++++++++++++++++--- 1 file changed, 34 insertions(+), 3 deletions(-) diff --git a/tools/virsh-host.c b/tools/virsh-host.c index 66f7fd9..28f6da1 100644 --- a/tools/virsh-host.c +++ b/tools/virsh-host.c @@ -285,6 +285,15 @@ static const vshCmdOptDef opts_freepages[] = { {.name = NULL} }; +static int +vshPageSizeSorter(const void *a, const void *b) +{ + unsigned int pa = *(unsigned int *)a; + unsigned int pb = *(unsigned int *)b; + + return pa - pb; +} + static bool cmdFreepages(vshControl *ctl, const vshCmd *cmd) { @@ -326,9 +335,15 @@ cmdFreepages(vshControl *ctl, const vshCmd *cmd) nodes_cnt = virXPathNodeSet("/capabilities/host/cpu/pages", ctxt, &nodes); if (nodes_cnt <= 0) { - vshError(ctl, "%s", _("could not get information about " - "supported page sizes")); - goto cleanup; + /* Some drivers don't export page sizes under the + * XPath above. Do another trick to get them */ + nodes_cnt = virXPathNodeSet("/capabilities/host/topology/cells/cell/pages", + ctxt, &nodes); + if (nodes_cnt <= 0) { + vshError(ctl, "%s", _("could not get information about " + "supported page sizes")); + goto cleanup; + } } pagesize = vshCalloc(ctl, nodes_cnt, sizeof(*pagesize)); @@ -345,6 +360,22 @@ cmdFreepages(vshControl *ctl, const vshCmd *cmd) VIR_FREE(val); } + /* Here, if we've done the trick few lines above, + * @pagesize array will contain duplicates. We should + * remove them otherwise not very nice output will be + * produced. */ + qsort(pagesize, nodes_cnt, sizeof(*pagesize), vshPageSizeSorter); + + for (i = 0; i < nodes_cnt - 1; ) { + if (pagesize[i] == pagesize[i + 1]) { + memmove(pagesize + i, pagesize + i + 1, + (nodes_cnt - i + 1) * sizeof(*pagesize)); + nodes_cnt--; + } else { + i++; + } + } + npages = nodes_cnt; VIR_FREE(nodes); } else { -- 2.3.6

2 1

[libvirt] Serial connection between guests
by Marcelo Ricardo Leitner 14 Jul '15

14 Jul '15

Hi, (I'm not subscribed to the list, please keep me on Cc) I'm attempting to get a serial link between two guests, same hypervisor. The only practical way I could find is to add a serial port using a pty to a guest and then manually connecting to the serial (console in my case) of the other guest using socat in the hypervisor. Then it made me think.. we could have this implemented at libvirt level. We could have a serial port on which we choose pty, udp, tcp, etc, and also a serial port from another guest, so that libvirt would handle socat start/stop automatically as both guests come up/down. Maybe libvirt could even do something smarter than that, maybe it can avoid socat somehow. What do you think? My usage is for virtualizing TAHI: http://networktest.sourceforge.net/usage.html I need 2 ethernet links plus a serial one, which TAHI can't break while running the tests. I didn't think this regarding multi-platform & all.. just sharing the idea/need. Thanks, Marcelo

2 4

[libvirt] [PATCH] libxl: rework reference counting
by Jim Fehlig 14 Jul '15

14 Jul '15

Similar to commit 540c339a for the QEMU driver, rework reference counting in the libxl driver to make it more deterministic and the code a bit cleaner. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- I've been testing this patch on and off for a few weeks now using libvirt-tck domain tests, local test scripts, and some manual tests for good measure. I sent the patch to Anthony Perard (cc'd) nearly two weeks ago for testing in his OpenStack+Xen+libvirt CI loop, although I haven't received any feedback thus far. Also included Martin in the cc since he encouraged this patch https://www.redhat.com/archives/libvir-list/2015-April/msg00014.html src/libxl/libxl_domain.c | 32 ++---- src/libxl/libxl_domain.h | 5 +- src/libxl/libxl_driver.c | 274 ++++++++++++++++++-------------------------- src/libxl/libxl_migration.c | 6 +- 4 files changed, 128 insertions(+), 189 deletions(-) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index 0652270..ce188ee 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -96,13 +96,12 @@ libxlDomainObjFreeJob(libxlDomainObjPrivatePtr priv) #define LIBXL_JOB_WAIT_TIME (1000ull * 30) /* - * obj must be locked before calling, libxlDriverPrivatePtr must NOT be locked + * obj must be locked before calling * * This must be called by anything that will change the VM state - * in any way + * in any way. * - * Upon successful return, the object will have its ref count increased, - * successful calls must be followed by EndJob eventually + * Successful calls must eventually result in a call to EndJob. */ int libxlDomainObjBeginJob(libxlDriverPrivatePtr driver ATTRIBUTE_UNUSED, @@ -117,8 +116,6 @@ libxlDomainObjBeginJob(libxlDriverPrivatePtr driver ATTRIBUTE_UNUSED, return -1; then = now + LIBXL_JOB_WAIT_TIME; - virObjectRef(obj); - while (priv->job.active) { VIR_DEBUG("Wait normal job condition for starting job: %s", libxlDomainJobTypeToString(job)); @@ -149,21 +146,16 @@ libxlDomainObjBeginJob(libxlDriverPrivatePtr driver ATTRIBUTE_UNUSED, virReportSystemError(errno, "%s", _("cannot acquire job mutex")); - virObjectUnref(obj); return -1; } /* - * obj must be locked before calling + * obj must be locked and have a reference before calling * * To be called after completing the work associated with the * earlier libxlDomainBeginJob() call - * - * Returns true if the remaining reference count on obj is - * non-zero, false if the reference count has dropped to zero - * and obj is disposed. */ -bool +void libxlDomainObjEndJob(libxlDriverPrivatePtr driver ATTRIBUTE_UNUSED, virDomainObjPtr obj) { @@ -175,8 +167,6 @@ libxlDomainObjEndJob(libxlDriverPrivatePtr driver ATTRIBUTE_UNUSED, libxlDomainObjResetJob(priv); virCondSignal(&priv->job.cond); - - return virObjectUnref(obj); } static void * @@ -485,12 +475,11 @@ libxlDomainShutdownThread(void *opaque) } endjob: - if (!libxlDomainObjEndJob(driver, vm)) - vm = NULL; + libxlDomainObjEndJob(driver, vm); cleanup: - if (vm) - virObjectUnlock(vm); + virObjectUnlock(vm); + virObjectUnref(vm); if (dom_event) libxlDomainEventQueue(driver, dom_event); libxl_event_free(cfg->ctx, ev); @@ -528,6 +517,7 @@ libxlDomainEventHandler(void *data, VIR_LIBXL_EVENT_CONST libxl_event *event) VIR_INFO("Received event for unknown domain ID %d", event->domid); goto error; } + virObjectRef(vm); /* * Start a thread to handle shutdown. We don't want to be tying up @@ -558,8 +548,10 @@ libxlDomainEventHandler(void *data, VIR_LIBXL_EVENT_CONST libxl_event *event) /* Cast away any const */ libxl_event_free(cfg->ctx, (libxl_event *)event); virObjectUnref(cfg); - if (vm) + if (vm) { virObjectUnlock(vm); + virObjectUnref(vm); + } VIR_FREE(shutdown_info); } diff --git a/src/libxl/libxl_domain.h b/src/libxl/libxl_domain.h index 8c73cc4..714ed91 100644 --- a/src/libxl/libxl_domain.h +++ b/src/libxl/libxl_domain.h @@ -83,10 +83,9 @@ libxlDomainObjBeginJob(libxlDriverPrivatePtr driver, enum libxlDomainJob job) ATTRIBUTE_RETURN_CHECK; -bool +void libxlDomainObjEndJob(libxlDriverPrivatePtr driver, - virDomainObjPtr obj) - ATTRIBUTE_RETURN_CHECK; + virDomainObjPtr obj); void libxlDomainEventQueue(libxlDriverPrivatePtr driver, diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index a7be745..c0061b3 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -282,7 +282,7 @@ libxlDomObjFromDomain(virDomainPtr dom) libxlDriverPrivatePtr driver = dom->conn->privateData; char uuidstr[VIR_UUID_STRING_BUFLEN]; - vm = virDomainObjListFindByUUID(driver->domains, dom->uuid); + vm = virDomainObjListFindByUUIDRef(driver->domains, dom->uuid); if (!vm) { virUUIDFormat(dom->uuid, uuidstr); virReportError(VIR_ERR_NO_DOMAIN, @@ -294,6 +294,25 @@ libxlDomObjFromDomain(virDomainPtr dom) return vm; } +/* + * Finish working with a domain object in an API. This function + * clears whatever was left of a domain that was gathered using + * libxlDomObjFromDomain(). Currently that means only unlocking and + * decrementing the reference counter of that domain. And in order to + * make sure the caller does not access the domain, the pointer is + * cleared. + */ +static void +libxlDomObjEndAPI(virDomainObjPtr *vm) +{ + if (!*vm) + return; + + virObjectUnlock(*vm); + virObjectUnref(*vm); + *vm = NULL; +} + static int libxlAutostartDomain(virDomainObjPtr vm, void *opaque) @@ -303,6 +322,7 @@ libxlAutostartDomain(virDomainObjPtr vm, int ret = -1; virObjectLock(vm); + virObjectRef(vm); virResetLastError(); if (libxlDomainObjBeginJob(driver, vm, LIBXL_JOB_MODIFY) < 0) { @@ -322,8 +342,10 @@ libxlAutostartDomain(virDomainObjPtr vm, ret = 0; endjob: - if (libxlDomainObjEndJob(driver, vm)) - virObjectUnlock(vm); + libxlDomainObjEndJob(driver, vm); + + virObjectUnlock(vm); + virObjectUnref(vm); return ret; } @@ -908,19 +930,19 @@ libxlDomainCreateXML(virConnectPtr conn, const char *xml, VIR_DOMAIN_OBJ_LIST_ADD_CHECK_LIVE, NULL))) goto cleanup; + virObjectRef(vm); def = NULL; if (libxlDomainObjBeginJob(driver, vm, LIBXL_JOB_MODIFY) < 0) { - if (!vm->persistent) { + if (!vm->persistent) virDomainObjListRemove(driver->domains, vm); - vm = NULL; - } goto cleanup; } if (libxlDomainStart(driver, vm, (flags & VIR_DOMAIN_START_PAUSED) != 0, -1) < 0) { - virDomainObjListRemove(driver->domains, vm); + if (!vm->persistent) + virDomainObjListRemove(driver->domains, vm); goto endjob; } @@ -929,13 +951,11 @@ libxlDomainCreateXML(virConnectPtr conn, const char *xml, dom->id = vm->def->id; endjob: - if (!libxlDomainObjEndJob(driver, vm)) - vm = NULL; + libxlDomainObjEndJob(driver, vm); cleanup: virDomainDefFree(def); - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); virObjectUnref(cfg); return dom; } @@ -1060,12 +1080,10 @@ libxlDomainSuspend(virDomainPtr dom) ret = 0; endjob: - if (!libxlDomainObjEndJob(driver, vm)) - vm = NULL; + libxlDomainObjEndJob(driver, vm); cleanup: - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); if (event) libxlDomainEventQueue(driver, event); virObjectUnref(cfg); @@ -1117,12 +1135,10 @@ libxlDomainResume(virDomainPtr dom) ret = 0; endjob: - if (!libxlDomainObjEndJob(driver, vm)) - vm = NULL; + libxlDomainObjEndJob(driver, vm); cleanup: - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); if (event) libxlDomainEventQueue(driver, event); virObjectUnref(cfg); @@ -1183,8 +1199,7 @@ libxlDomainShutdownFlags(virDomainPtr dom, unsigned int flags) } cleanup: - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); virObjectUnref(cfg); return ret; } @@ -1232,8 +1247,7 @@ libxlDomainReboot(virDomainPtr dom, unsigned int flags) } cleanup: - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); virObjectUnref(cfg); return ret; } @@ -1281,12 +1295,10 @@ libxlDomainDestroyFlags(virDomainPtr dom, ret = 0; endjob: - if (!libxlDomainObjEndJob(driver, vm)) - vm = NULL; + libxlDomainObjEndJob(driver, vm); cleanup: - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); if (event) libxlDomainEventQueue(driver, event); virObjectUnref(cfg); @@ -1315,8 +1327,7 @@ libxlDomainGetOSType(virDomainPtr dom) goto cleanup; cleanup: - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); return type; } @@ -1335,8 +1346,7 @@ libxlDomainGetMaxMemory(virDomainPtr dom) ret = virDomainDefGetMemoryActual(vm->def); cleanup: - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); return ret; } @@ -1455,12 +1465,10 @@ libxlDomainSetMemoryFlags(virDomainPtr dom, unsigned long newmem, ret = 0; endjob: - if (!libxlDomainObjEndJob(driver, vm)) - vm = NULL; + libxlDomainObjEndJob(driver, vm); cleanup: - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); virObjectUnref(cfg); return ret; } @@ -1513,8 +1521,7 @@ libxlDomainGetInfo(virDomainPtr dom, virDomainInfoPtr info) ret = 0; cleanup: - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); virObjectUnref(cfg); return ret; } @@ -1540,8 +1547,7 @@ libxlDomainGetState(virDomainPtr dom, ret = 0; cleanup: - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); return ret; } @@ -1638,7 +1644,6 @@ libxlDomainSaveFlags(virDomainPtr dom, const char *to, const char *dxml, libxlDriverPrivatePtr driver = dom->conn->privateData; virDomainObjPtr vm; int ret = -1; - bool remove_dom = false; #ifdef LIBXL_HAVE_NO_SUSPEND_RESUME virReportUnsupportedError(); @@ -1670,21 +1675,15 @@ libxlDomainSaveFlags(virDomainPtr dom, const char *to, const char *dxml, goto endjob; if (!vm->persistent) - remove_dom = true; + virDomainObjListRemove(driver->domains, vm); ret = 0; endjob: - if (!libxlDomainObjEndJob(driver, vm)) - vm = NULL; + libxlDomainObjEndJob(driver, vm); cleanup: - if (remove_dom && vm) { - virDomainObjListRemove(driver->domains, vm); - vm = NULL; - } - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); return ret; } @@ -1735,10 +1734,8 @@ libxlDomainRestoreFlags(virConnectPtr conn, const char *from, def = NULL; if (libxlDomainObjBeginJob(driver, vm, LIBXL_JOB_MODIFY) < 0) { - if (!vm->persistent) { + if (!vm->persistent) virDomainObjListRemove(driver->domains, vm); - vm = NULL; - } goto cleanup; } @@ -1746,15 +1743,13 @@ libxlDomainRestoreFlags(virConnectPtr conn, const char *from, if (ret < 0 && !vm->persistent) virDomainObjListRemove(driver->domains, vm); - if (!libxlDomainObjEndJob(driver, vm)) - vm = NULL; + libxlDomainObjEndJob(driver, vm); cleanup: if (VIR_CLOSE(fd) < 0) virReportSystemError(errno, "%s", _("cannot close file")); virDomainDefFree(def); - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); virObjectUnref(cfg); return ret; } @@ -1772,7 +1767,6 @@ libxlDomainCoreDump(virDomainPtr dom, const char *to, unsigned int flags) libxlDriverConfigPtr cfg = libxlDriverConfigGet(driver); virDomainObjPtr vm; virObjectEventPtr event = NULL; - bool remove_dom = false; bool paused = false; int ret = -1; @@ -1828,7 +1822,7 @@ libxlDomainCoreDump(virDomainPtr dom, const char *to, unsigned int flags) event = virDomainEventLifecycleNewFromObj(vm, VIR_DOMAIN_EVENT_STOPPED, VIR_DOMAIN_EVENT_STOPPED_CRASHED); if (!vm->persistent) - remove_dom = true; + virDomainObjListRemove(driver->domains, vm); } ret = 0; @@ -1846,16 +1840,10 @@ libxlDomainCoreDump(virDomainPtr dom, const char *to, unsigned int flags) } endjob: - if (!libxlDomainObjEndJob(driver, vm)) - vm = NULL; + libxlDomainObjEndJob(driver, vm); cleanup: - if (remove_dom && vm) { - virDomainObjListRemove(driver->domains, vm); - vm = NULL; - } - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); if (event) libxlDomainEventQueue(driver, event); virObjectUnref(cfg); @@ -1869,7 +1857,6 @@ libxlDomainManagedSave(virDomainPtr dom, unsigned int flags) virDomainObjPtr vm = NULL; char *name = NULL; int ret = -1; - bool remove_dom = false; virCheckFlags(0, -1); @@ -1902,21 +1889,15 @@ libxlDomainManagedSave(virDomainPtr dom, unsigned int flags) goto endjob; if (!vm->persistent) - remove_dom = true; + virDomainObjListRemove(driver->domains, vm); ret = 0; endjob: - if (!libxlDomainObjEndJob(driver, vm)) - vm = NULL; + libxlDomainObjEndJob(driver, vm); cleanup: - if (remove_dom && vm) { - virDomainObjListRemove(driver->domains, vm); - vm = NULL; - } - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); VIR_FREE(name); return ret; } @@ -1960,8 +1941,7 @@ libxlDomainHasManagedSaveImage(virDomainPtr dom, unsigned int flags) ret = vm->hasManagedSave; cleanup: - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); return ret; } @@ -1990,8 +1970,7 @@ libxlDomainManagedSaveRemove(virDomainPtr dom, unsigned int flags) cleanup: VIR_FREE(name); - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); return ret; } @@ -2119,13 +2098,11 @@ libxlDomainSetVcpusFlags(virDomainPtr dom, unsigned int nvcpus, ret = virDomainSaveConfig(cfg->configDir, def); endjob: - if (!libxlDomainObjEndJob(driver, vm)) - vm = NULL; + libxlDomainObjEndJob(driver, vm); cleanup: VIR_FREE(bitmask); - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); virObjectUnref(cfg); return ret; } @@ -2187,8 +2164,7 @@ libxlDomainGetVcpusFlags(virDomainPtr dom, unsigned int flags) ret = (flags & VIR_DOMAIN_VCPU_MAXIMUM) ? def->maxvcpus : def->vcpus; cleanup: - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); return ret; } @@ -2270,12 +2246,10 @@ libxlDomainPinVcpuFlags(virDomainPtr dom, unsigned int vcpu, } endjob: - if (!libxlDomainObjEndJob(driver, vm)) - vm = NULL; + libxlDomainObjEndJob(driver, vm); cleanup: - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); virBitmapFree(pcpumap); virObjectUnref(cfg); return ret; @@ -2354,8 +2328,7 @@ libxlDomainGetVcpuPinInfo(virDomainPtr dom, int ncpumaps, cleanup: virBitmapFree(allcpumap); - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); virObjectUnref(cfg); return ret; } @@ -2418,8 +2391,7 @@ libxlDomainGetVcpus(virDomainPtr dom, virVcpuInfoPtr info, int maxinfo, ret = maxinfo; cleanup: - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); virObjectUnref(cfg); return ret; } @@ -2442,8 +2414,7 @@ libxlDomainGetXMLDesc(virDomainPtr dom, unsigned int flags) virDomainDefFormatConvertXMLFlags(flags)); cleanup: - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); return ret; } @@ -2618,12 +2589,10 @@ libxlDomainCreateWithFlags(virDomainPtr dom, dom->id = vm->def->id; endjob: - if (!libxlDomainObjEndJob(driver, vm)) - vm = NULL; + libxlDomainObjEndJob(driver, vm); cleanup: - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); return ret; } @@ -2760,8 +2729,7 @@ libxlDomainUndefineFlags(virDomainPtr dom, cleanup: VIR_FREE(name); - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); if (event) libxlDomainEventQueue(driver, event); virObjectUnref(cfg); @@ -3618,14 +3586,12 @@ libxlDomainAttachDeviceFlags(virDomainPtr dom, const char *xml, } endjob: - if (!libxlDomainObjEndJob(driver, vm)) - vm = NULL; + libxlDomainObjEndJob(driver, vm); cleanup: virDomainDefFree(vmdef); virDomainDeviceDefFree(dev); - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); virObjectUnref(cfg); return ret; } @@ -3726,14 +3692,12 @@ libxlDomainDetachDeviceFlags(virDomainPtr dom, const char *xml, } endjob: - if (!libxlDomainObjEndJob(driver, vm)) - vm = NULL; + libxlDomainObjEndJob(driver, vm); cleanup: virDomainDefFree(vmdef); virDomainDeviceDefFree(dev); - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); virObjectUnref(cfg); return ret; } @@ -3833,8 +3797,7 @@ libxlDomainUpdateDeviceFlags(virDomainPtr dom, const char *xml, cleanup: virDomainDefFree(vmdef); virDomainDeviceDefFree(dev); - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); virObjectUnref(cfg); return ret; } @@ -3964,8 +3927,7 @@ libxlDomainGetAutostart(virDomainPtr dom, int *autostart) ret = 0; cleanup: - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); return ret; } @@ -4029,14 +3991,12 @@ libxlDomainSetAutostart(virDomainPtr dom, int autostart) ret = 0; endjob: - if (!libxlDomainObjEndJob(driver, vm)) - vm = NULL; + libxlDomainObjEndJob(driver, vm); cleanup: VIR_FREE(configFile); VIR_FREE(autostartLink); - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); virObjectUnref(cfg); return ret; } @@ -4091,8 +4051,7 @@ libxlDomainGetSchedulerType(virDomainPtr dom, int *nparams) ignore_value(VIR_STRDUP(ret, name)); cleanup: - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); virObjectUnref(cfg); return ret; } @@ -4157,8 +4116,7 @@ libxlDomainGetSchedulerParametersFlags(virDomainPtr dom, ret = 0; cleanup: - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); virObjectUnref(cfg); return ret; } @@ -4241,12 +4199,10 @@ libxlDomainSetSchedulerParametersFlags(virDomainPtr dom, ret = 0; endjob: - if (!libxlDomainObjEndJob(driver, vm)) - vm = NULL; + libxlDomainObjEndJob(driver, vm); cleanup: - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); virObjectUnref(cfg); return ret; } @@ -4316,8 +4272,7 @@ libxlDomainOpenConsole(virDomainPtr dom, } cleanup: - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); return ret; } @@ -4452,8 +4407,7 @@ libxlDomainGetNumaParameters(virDomainPtr dom, VIR_FREE(nodeset); virBitmapFree(nodes); libxl_bitmap_dispose(&nodemap); - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); virObjectUnref(cfg); return ret; } @@ -4474,8 +4428,7 @@ libxlDomainIsActive(virDomainPtr dom) ret = virDomainObjIsActive(obj); cleanup: - if (obj) - virObjectUnlock(obj); + libxlDomObjEndAPI(&obj); return ret; } @@ -4494,8 +4447,7 @@ libxlDomainIsPersistent(virDomainPtr dom) ret = obj->persistent; cleanup: - if (obj) - virObjectUnlock(obj); + libxlDomObjEndAPI(&obj); return ret; } @@ -4514,8 +4466,7 @@ libxlDomainIsUpdated(virDomainPtr dom) ret = vm->updated; cleanup: - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); return ret; } @@ -4780,6 +4731,7 @@ libxlDomainMigrateBegin3Params(virDomainPtr domain, { const char *xmlin = NULL; virDomainObjPtr vm = NULL; + char *ret = NULL; #ifdef LIBXL_HAVE_NO_SUSPEND_RESUME virReportUnsupportedError(); @@ -4798,19 +4750,20 @@ libxlDomainMigrateBegin3Params(virDomainPtr domain, if (!(vm = libxlDomObjFromDomain(domain))) return NULL; - if (virDomainMigrateBegin3ParamsEnsureACL(domain->conn, vm->def) < 0) { - virObjectUnlock(vm); - return NULL; - } + if (virDomainMigrateBegin3ParamsEnsureACL(domain->conn, vm->def) < 0) + goto cleanup; if (!virDomainObjIsActive(vm)) { virReportError(VIR_ERR_OPERATION_INVALID, "%s", _("domain is not running")); - virObjectUnlock(vm); - return NULL; + goto cleanup; } - return libxlDomainMigrationBegin(domain->conn, vm, xmlin); + ret = libxlDomainMigrationBegin(domain->conn, vm, xmlin); + + cleanup: + libxlDomObjEndAPI(&vm); + return ret; } static int @@ -4919,8 +4872,7 @@ libxlDomainMigratePerform3Params(virDomainPtr dom, ret = 0; cleanup: - if (vm) - virObjectUnlock(vm); + libxlDomObjEndAPI(&vm); return ret; } @@ -4963,23 +4915,20 @@ libxlDomainMigrateFinish3Params(virConnectPtr dconn, NULLSTR(dname)); return NULL; } + virObjectRef(vm); - if (virDomainMigrateFinish3ParamsEnsureACL(dconn, vm->def) < 0) { - virDomainObjEndAPI(&vm); - return NULL; - } + if (virDomainMigrateFinish3ParamsEnsureACL(dconn, vm->def) < 0) + goto cleanup; - if (libxlDomainObjBeginJob(driver, vm, LIBXL_JOB_MODIFY) < 0) { - virDomainObjEndAPI(&vm); - return NULL; - } + if (libxlDomainObjBeginJob(driver, vm, LIBXL_JOB_MODIFY) < 0) + goto cleanup; ret = libxlDomainMigrationFinish(dconn, vm, flags, cancelled); - if (!libxlDomainObjEndJob(driver, vm)) - vm = NULL; + libxlDomainObjEndJob(driver, vm); - virDomainObjEndAPI(&vm); + cleanup: + libxlDomObjEndAPI(&vm); return ret; } @@ -4995,6 +4944,7 @@ libxlDomainMigrateConfirm3Params(virDomainPtr domain, { libxlDriverPrivatePtr driver = domain->conn->privateData; virDomainObjPtr vm = NULL; + int ret = -1; #ifdef LIBXL_HAVE_NO_SUSPEND_RESUME virReportUnsupportedError(); @@ -5008,12 +4958,14 @@ libxlDomainMigrateConfirm3Params(virDomainPtr domain, if (!(vm = libxlDomObjFromDomain(domain))) return -1; - if (virDomainMigrateConfirm3ParamsEnsureACL(domain->conn, vm->def) < 0) { - virObjectUnlock(vm); - return -1; - } + if (virDomainMigrateConfirm3ParamsEnsureACL(domain->conn, vm->def) < 0) + goto cleanup; - return libxlDomainMigrationConfirm(driver, vm, flags, cancelled); + ret = libxlDomainMigrationConfirm(driver, vm, flags, cancelled); + + cleanup: + libxlDomObjEndAPI(&vm); + return ret; } static int libxlNodeGetSecurityModel(virConnectPtr conn, diff --git a/src/libxl/libxl_migration.c b/src/libxl/libxl_migration.c index 39e4a65..665b21a 100644 --- a/src/libxl/libxl_migration.c +++ b/src/libxl/libxl_migration.c @@ -257,13 +257,9 @@ libxlDomainMigrationBegin(virConnectPtr conn, xml = virDomainDefFormat(def, VIR_DOMAIN_DEF_FORMAT_SECURE); endjob: - if (!libxlDomainObjEndJob(driver, vm)) - vm = NULL; + libxlDomainObjEndJob(driver, vm); cleanup: - if (vm) - virObjectUnlock(vm); - virDomainDefFree(tmpdef); virObjectUnref(cfg); return xml; -- 2.3.7

3 4

[libvirt] [PATCH v2] Fix qemu-nbd cleanup crashes
by Cédric Bosdonnat 14 Jul '15

14 Jul '15

The virLXCControllerAppendNBDPids function didn't properly initialize pids and npids. In case of failure it was crashing when freeing those. The nbd device pid file doesn't appear immediately after starting qemu-nbd: adding a small loop to wait for it. Diff to v1: * Fixed a typo in a variable name.... working with several repos leads to troubles ;) --- src/lxc/lxc_controller.c | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c index 828b8a8..78d3eee 100644 --- a/src/lxc/lxc_controller.c +++ b/src/lxc/lxc_controller.c @@ -533,16 +533,31 @@ static int virLXCControllerAppendNBDPids(virLXCControllerPtr ctrl, const char *dev) { char *pidpath = NULL; - pid_t *pids; - size_t npids; + pid_t *pids = NULL; + size_t npids = 0; size_t i; int ret = -1; + size_t loops = 0; pid_t pid; if (!STRPREFIX(dev, "/dev/") || virAsprintf(&pidpath, "/sys/devices/virtual/block/%s/pid", dev + 5) < 0) goto cleanup; + /* Wait for the pid file to appear */ + while (!virFileExists(pidpath)) { + /* wait for 100ms before checking again, but don't do it for ever */ + if (errno == ENOENT && loop < 10) { + usleep(100 * 1000); + loop++; + } else { + virReportSystemError(errno, + _("Cannot check NBD device %s pid"), + dev + 5); + goto cleanup; + } + } + if (virPidFileReadPath(pidpath, &pid) < 0) goto cleanup; -- 2.1.4

3 2

[libvirt] [PATCH v2] qemu: process: Improve update of maximum baloon state at startup
by Peter Krempa 14 Jul '15

14 Jul '15

In commit 641a145d73fdc3dd9350fd57b3d3247abf101c05 I've added code that resets the ballon memory value to full size prior to resuming the vCPUs since the size certainly was not reduced at that point. Since qemuProcess start is used also in code paths with already booted up guests (migration, save/restore) the assumption is not entirely true since the guest might already been running before. This patch adds a function that queries the monitor rather than using the full size since a balloon event would not be reissued in case we are recovering a saved migration state. Additionally the new function is used also when reconnecting to a VM after libvirtd restart since we might have missed a few ballon events while libvirtd was not running. --- src/qemu/qemu_process.c | 38 +++++++++++++++++++++++++++++++++++++- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index ba84182..13b1696 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -2065,6 +2065,38 @@ qemuProcessReconnectRefreshChannelVirtioState(virQEMUDriverPtr driver, static int +qemuProcessRefreshBallonState(virQEMUDriverPtr driver, + virDomainObjPtr vm, + int asyncJob) +{ + unsigned long long balloon; + int rc; + + /* if no balloning is available, the current size equals to the current + * full memory size */ + if (!vm->def->memballoon || + vm->def->memballoon->model == VIR_DOMAIN_MEMBALLOON_MODEL_NONE) { + vm->def->mem.cur_balloon = virDomainDefGetMemoryActual(vm->def); + return 0; + } + + if (qemuDomainObjEnterMonitorAsync(driver, vm, asyncJob) < 0) + return -1; + + rc = qemuMonitorGetBalloonInfo(qemuDomainGetMonitor(vm), &balloon); + if (qemuDomainObjExitMonitor(driver, vm) < 0) + rc = -1; + + if (rc < 0) + return -1; + + vm->def->mem.cur_balloon = balloon; + + return 0; +} + + +static int qemuProcessWaitForMonitor(virQEMUDriverPtr driver, virDomainObjPtr vm, int asyncJob, @@ -3779,6 +3811,9 @@ qemuProcessReconnect(void *opaque) if (qemuProcessReconnectRefreshChannelVirtioState(driver, obj) < 0) goto error; + if (qemuProcessRefreshBallonState(driver, obj, QEMU_ASYNC_JOB_NONE) < 0) + goto error; + if (qemuProcessRecoverJob(driver, obj, conn, &oldjob) < 0) goto error; @@ -4922,7 +4957,8 @@ int qemuProcessStart(virConnectPtr conn, /* Since CPUs were not started yet, the ballon could not return the memory * to the host and thus cur_balloon needs to be updated so that GetXMLdesc * and friends return the correct size in case they can't grab the job */ - vm->def->mem.cur_balloon = virDomainDefGetMemoryActual(vm->def); + if (qemuProcessRefreshBallonState(driver, vm, asyncJob) < 0) + goto cleanup; VIR_DEBUG("Detecting actual memory size for video device"); if (qemuProcessUpdateVideoRamSize(driver, vm, asyncJob) < 0) -- 2.4.1

3 4

[libvirt] How to get the fully qualified path for network disks
by Deepak Shetty 14 Jul '15

14 Jul '15

Some background: Looking @ the comments in https://review.openstack.org/#/c/192736/8/nova/virt/libvirt/driver.py we need a way to construct the fully qualified path for a 'network' type disk which can then be passed to qemu-img for the rebase cmd. Checking with some folks offline and on IRC, i was suggested to bring this up here. Is there a way in libvirt to get the full path of network disk that can work with qemu-img given the virDomain pointer ? thanx, deepak

1 0

[libvirt] [PATCH] qemuDomainSetNumaParamsLive:
by Michal Privoznik 14 Jul '15

14 Jul '15

https://bugzilla.redhat.com/show_bug.cgi?id=1232663 In one of my previous ptaches (bcd9a564) I've tried to fix the problem that we blindly assumed strict NUMA mode for guests. This led to several problems like us pinning a domain onto a nodeset via libnuma among with CGroups. Once the nodeset was changed by user, well, it did not result in desired effect. See the original commit for more info. But, the commit I wrote had a bug: when NUMA parameters are changed on a running domain we require domain to be strictly pinned onto a nodeset. Due to a typo a condition was mis-evaluated. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index c8cbd57..8c705c4 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -9954,7 +9954,7 @@ qemuDomainSetNumaParamsLive(virDomainObjPtr vm, size_t i = 0; int ret = -1; - if (virDomainNumatuneGetMode(vm->def->numa, -1, &mode) < 0 || + if (virDomainNumatuneGetMode(vm->def->numa, -1, &mode) == 0 && mode != VIR_DOMAIN_NUMATUNE_MEM_STRICT) { virReportError(VIR_ERR_OPERATION_INVALID, "%s", _("change of nodeset for running domain " -- 2.3.6

2 1

[libvirt] [PATCH 0/2] Check static route collisions
by Martin Kletzander 14 Jul '15

14 Jul '15

Martin Kletzander (2): conf: Add getter for network routes network: Add another collision check into networkCheckRouteCollision src/conf/network_conf.c | 26 ++++++++++++++++++++++++++ src/conf/network_conf.h | 3 +++ src/libvirt_private.syms | 1 + src/network/bridge_driver_linux.c | 29 +++++++++++++++++++++++++++++ 4 files changed, 59 insertions(+) -- 2.4.5

2 4

Re: [libvirt] Supporting remote connections to QEMU session mode
by Spencer Baugh 14 Jul '15

14 Jul '15

Eric Blake <eblake(a)redhat.com> writes: > On 07/03/2015 12:01 AM, sbaugh(a)catern.com wrote: >> Has there been any thought given to supporting remote connections to >> QEMU session instances in virt-manager? >> (i.e. qemu+ssh://hostname/session?socket=path) Manually hacking in the >> URI with dconf seems to mostly work, but (for example) I quickly >> encountered a bug when creating a VM where virt-manager assumed the only >> usable storage pool was my *local* homedir instead of the remote >> homedir. > > Libvirt does not (yet) allow remote connections to qemu://host/session. > You'd first have to figure out how to patch libvirt to allow remote > session connections; part of the problem is that with qemu:///system, > there is a daemon running that is always listening for remote > connections, but with qemu:///session, since libvirtd is only > auto-started as needed, there is no easy way to guarantee that the > remote machine is running a libvirtd process as the correct user. > >> >> virsh and other tools support these connections just fine. > > No, virsh does NOT support remote session connections, at least not > intentionally. If it works for you, it is a pure accident. I'm not sure what you mean by "not support". Connecting to a qemu+ssh://host/session?socket=path url works, and clearly some thought has been put into it because if I leave off the socket argument, I get this message: @sbaugh@earth ~ $ virsh -c qemu+ssh://host/session error: failed to connect to the hypervisor error: Operation not supported: Connecting to session instance without socket path is not supported by the ssh connection driver which is created by this snippet of code: /* Right now we don't support default session connections */ if (STREQ_NULLABLE(conn->uri->path, "/session")) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", _("Connecting to session instance without " "socket path is not supported by the libssh2 " "connection driver")); goto failed; } which certainly suggests to me that *non*-default session connections are supported. No patching is necessary to allow remote session connections, they are implicitly allowed. That if statement could easily disable them, but chose instead to allow them when they are sufficiently specified to actually work. All that aside, it's obvious that not much attention has been paid to making remote session connections work well even in core libvirt. Is improving the support for them something that is interesting to the libvirt developers? Would patches to improve the support be accepted? Well, I guess virt-tools-list isn't the list to discuss that, so I've also CC'd libvirt-list. An explanation of why I want to use remote connections to QEMU session mode is in the description of this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1241311 Thanks, Spencer Baugh

1 0

[libvirt] [PATCH] tests: Add nodeinfo test for non-present CPUs
by Andrea Bolognani 13 Jul '15

13 Jul '15

Some of the possible CPUs in a system might not be present, eg. they might be defective or might have been deconfigured from the ASM console in a Power system. Due to this fact, Linux keeps track of what CPUs are possible and what are present separately. This test uses the data from a system where not all the possible CPUs are present to make sure libvirt handles this situation correctly. --- This patch must be applied on top of John's series of nodeinfo refactors, especially [PATCH 9/9] nodeinfo: fix to parse present cpus rather than possible cpus which introduces the very fix this new test case is meant to test. .../linux-deconfigured-cpus/cpu/cpu0/online | 1 + .../linux-deconfigured-cpus/cpu/cpu1/online | 1 + .../linux-deconfigured-cpus/cpu/cpu10/online | 1 + .../linux-deconfigured-cpus/cpu/cpu100/online | 1 + .../linux-deconfigured-cpus/cpu/cpu101/online | 1 + .../linux-deconfigured-cpus/cpu/cpu102/online | 1 + .../linux-deconfigured-cpus/cpu/cpu103/online | 1 + .../linux-deconfigured-cpus/cpu/cpu104/online | 1 + .../cpu/cpu104/topology/core_id | 1 + .../cpu/cpu104/topology/core_siblings | 1 + .../cpu/cpu104/topology/core_siblings_list | 1 + .../cpu/cpu104/topology/physical_package_id | 1 + .../cpu/cpu104/topology/thread_siblings | 1 + .../cpu/cpu104/topology/thread_siblings_list | 1 + .../linux-deconfigured-cpus/cpu/cpu105/online | 1 + .../linux-deconfigured-cpus/cpu/cpu106/online | 1 + .../linux-deconfigured-cpus/cpu/cpu107/online | 1 + .../linux-deconfigured-cpus/cpu/cpu108/online | 1 + .../linux-deconfigured-cpus/cpu/cpu109/online | 1 + .../linux-deconfigured-cpus/cpu/cpu11/online | 1 + .../linux-deconfigured-cpus/cpu/cpu110/online | 1 + .../linux-deconfigured-cpus/cpu/cpu111/online | 1 + .../linux-deconfigured-cpus/cpu/cpu112/online | 1 + .../cpu/cpu112/topology/core_id | 1 + .../cpu/cpu112/topology/core_siblings | 1 + .../cpu/cpu112/topology/core_siblings_list | 1 + .../cpu/cpu112/topology/physical_package_id | 1 + .../cpu/cpu112/topology/thread_siblings | 1 + .../cpu/cpu112/topology/thread_siblings_list | 1 + .../linux-deconfigured-cpus/cpu/cpu113/online | 1 + .../linux-deconfigured-cpus/cpu/cpu114/online | 1 + .../linux-deconfigured-cpus/cpu/cpu115/online | 1 + .../linux-deconfigured-cpus/cpu/cpu116/online | 1 + .../linux-deconfigured-cpus/cpu/cpu117/online | 1 + .../linux-deconfigured-cpus/cpu/cpu118/online | 1 + .../linux-deconfigured-cpus/cpu/cpu119/online | 1 + .../linux-deconfigured-cpus/cpu/cpu12/online | 1 + .../linux-deconfigured-cpus/cpu/cpu120/online | 1 + .../cpu/cpu120/topology/core_id | 1 + .../cpu/cpu120/topology/core_siblings | 1 + .../cpu/cpu120/topology/core_siblings_list | 1 + .../cpu/cpu120/topology/physical_package_id | 1 + .../cpu/cpu120/topology/thread_siblings | 1 + .../cpu/cpu120/topology/thread_siblings_list | 1 + .../linux-deconfigured-cpus/cpu/cpu121/online | 1 + .../linux-deconfigured-cpus/cpu/cpu122/online | 1 + .../linux-deconfigured-cpus/cpu/cpu123/online | 1 + .../linux-deconfigured-cpus/cpu/cpu124/online | 1 + .../linux-deconfigured-cpus/cpu/cpu125/online | 1 + .../linux-deconfigured-cpus/cpu/cpu126/online | 1 + .../linux-deconfigured-cpus/cpu/cpu127/online | 1 + .../linux-deconfigured-cpus/cpu/cpu128/online | 1 + .../cpu/cpu128/topology/core_id | 1 + .../cpu/cpu128/topology/core_siblings | 1 + .../cpu/cpu128/topology/core_siblings_list | 1 + .../cpu/cpu128/topology/physical_package_id | 1 + .../cpu/cpu128/topology/thread_siblings | 1 + .../cpu/cpu128/topology/thread_siblings_list | 1 + .../linux-deconfigured-cpus/cpu/cpu129/online | 1 + .../linux-deconfigured-cpus/cpu/cpu13/online | 1 + .../linux-deconfigured-cpus/cpu/cpu130/online | 1 + .../linux-deconfigured-cpus/cpu/cpu131/online | 1 + .../linux-deconfigured-cpus/cpu/cpu132/online | 1 + .../linux-deconfigured-cpus/cpu/cpu133/online | 1 + .../linux-deconfigured-cpus/cpu/cpu134/online | 1 + .../linux-deconfigured-cpus/cpu/cpu135/online | 1 + .../linux-deconfigured-cpus/cpu/cpu136/online | 1 + .../cpu/cpu136/topology/core_id | 1 + .../cpu/cpu136/topology/core_siblings | 1 + .../cpu/cpu136/topology/core_siblings_list | 1 + .../cpu/cpu136/topology/physical_package_id | 1 + .../cpu/cpu136/topology/thread_siblings | 1 + .../cpu/cpu136/topology/thread_siblings_list | 1 + .../linux-deconfigured-cpus/cpu/cpu137/online | 1 + .../linux-deconfigured-cpus/cpu/cpu138/online | 1 + .../linux-deconfigured-cpus/cpu/cpu139/online | 1 + .../linux-deconfigured-cpus/cpu/cpu14/online | 1 + .../linux-deconfigured-cpus/cpu/cpu140/online | 1 + .../linux-deconfigured-cpus/cpu/cpu141/online | 1 + .../linux-deconfigured-cpus/cpu/cpu142/online | 1 + .../linux-deconfigured-cpus/cpu/cpu143/online | 1 + .../linux-deconfigured-cpus/cpu/cpu144/online | 1 + .../linux-deconfigured-cpus/cpu/cpu145/online | 1 + .../linux-deconfigured-cpus/cpu/cpu146/online | 1 + .../linux-deconfigured-cpus/cpu/cpu147/online | 1 + .../linux-deconfigured-cpus/cpu/cpu148/online | 1 + .../linux-deconfigured-cpus/cpu/cpu149/online | 1 + .../linux-deconfigured-cpus/cpu/cpu15/online | 1 + .../linux-deconfigured-cpus/cpu/cpu150/online | 1 + .../linux-deconfigured-cpus/cpu/cpu151/online | 1 + .../linux-deconfigured-cpus/cpu/cpu152/online | 1 + .../linux-deconfigured-cpus/cpu/cpu153/online | 1 + .../linux-deconfigured-cpus/cpu/cpu154/online | 1 + .../linux-deconfigured-cpus/cpu/cpu155/online | 1 + .../linux-deconfigured-cpus/cpu/cpu156/online | 1 + .../linux-deconfigured-cpus/cpu/cpu157/online | 1 + .../linux-deconfigured-cpus/cpu/cpu158/online | 1 + .../linux-deconfigured-cpus/cpu/cpu159/online | 1 + .../linux-deconfigured-cpus/cpu/cpu16/online | 1 + .../cpu/cpu16/topology/core_id | 1 + .../cpu/cpu16/topology/core_siblings | 1 + .../cpu/cpu16/topology/core_siblings_list | 1 + .../cpu/cpu16/topology/physical_package_id | 1 + .../cpu/cpu16/topology/thread_siblings | 1 + .../cpu/cpu16/topology/thread_siblings_list | 1 + .../linux-deconfigured-cpus/cpu/cpu17/online | 1 + .../linux-deconfigured-cpus/cpu/cpu18/online | 1 + .../linux-deconfigured-cpus/cpu/cpu19/online | 1 + .../linux-deconfigured-cpus/cpu/cpu2/online | 1 + .../linux-deconfigured-cpus/cpu/cpu20/online | 1 + .../linux-deconfigured-cpus/cpu/cpu21/online | 1 + .../linux-deconfigured-cpus/cpu/cpu22/online | 1 + .../linux-deconfigured-cpus/cpu/cpu23/online | 1 + .../linux-deconfigured-cpus/cpu/cpu24/online | 1 + .../cpu/cpu24/topology/core_id | 1 + .../cpu/cpu24/topology/core_siblings | 1 + .../cpu/cpu24/topology/core_siblings_list | 1 + .../cpu/cpu24/topology/physical_package_id | 1 + .../cpu/cpu24/topology/thread_siblings | 1 + .../cpu/cpu24/topology/thread_siblings_list | 1 + .../linux-deconfigured-cpus/cpu/cpu25/online | 1 + .../linux-deconfigured-cpus/cpu/cpu26/online | 1 + .../linux-deconfigured-cpus/cpu/cpu27/online | 1 + .../linux-deconfigured-cpus/cpu/cpu28/online | 1 + .../linux-deconfigured-cpus/cpu/cpu29/online | 1 + .../linux-deconfigured-cpus/cpu/cpu3/online | 1 + .../linux-deconfigured-cpus/cpu/cpu30/online | 1 + .../linux-deconfigured-cpus/cpu/cpu31/online | 1 + .../linux-deconfigured-cpus/cpu/cpu32/online | 1 + .../linux-deconfigured-cpus/cpu/cpu33/online | 1 + .../linux-deconfigured-cpus/cpu/cpu34/online | 1 + .../linux-deconfigured-cpus/cpu/cpu35/online | 1 + .../linux-deconfigured-cpus/cpu/cpu36/online | 1 + .../linux-deconfigured-cpus/cpu/cpu37/online | 1 + .../linux-deconfigured-cpus/cpu/cpu38/online | 1 + .../linux-deconfigured-cpus/cpu/cpu39/online | 1 + .../linux-deconfigured-cpus/cpu/cpu4/online | 1 + .../linux-deconfigured-cpus/cpu/cpu40/online | 1 + .../cpu/cpu40/topology/core_id | 1 + .../cpu/cpu40/topology/core_siblings | 1 + .../cpu/cpu40/topology/core_siblings_list | 1 + .../cpu/cpu40/topology/physical_package_id | 1 + .../cpu/cpu40/topology/thread_siblings | 1 + .../cpu/cpu40/topology/thread_siblings_list | 1 + .../linux-deconfigured-cpus/cpu/cpu41/online | 1 + .../linux-deconfigured-cpus/cpu/cpu42/online | 1 + .../linux-deconfigured-cpus/cpu/cpu43/online | 1 + .../linux-deconfigured-cpus/cpu/cpu44/online | 1 + .../linux-deconfigured-cpus/cpu/cpu45/online | 1 + .../linux-deconfigured-cpus/cpu/cpu46/online | 1 + .../linux-deconfigured-cpus/cpu/cpu47/online | 1 + .../linux-deconfigured-cpus/cpu/cpu48/online | 1 + .../cpu/cpu48/topology/core_id | 1 + .../cpu/cpu48/topology/core_siblings | 1 + .../cpu/cpu48/topology/core_siblings_list | 1 + .../cpu/cpu48/topology/physical_package_id | 1 + .../cpu/cpu48/topology/thread_siblings | 1 + .../cpu/cpu48/topology/thread_siblings_list | 1 + .../linux-deconfigured-cpus/cpu/cpu49/online | 1 + .../linux-deconfigured-cpus/cpu/cpu5/online | 1 + .../linux-deconfigured-cpus/cpu/cpu50/online | 1 + .../linux-deconfigured-cpus/cpu/cpu51/online | 1 + .../linux-deconfigured-cpus/cpu/cpu52/online | 1 + .../linux-deconfigured-cpus/cpu/cpu53/online | 1 + .../linux-deconfigured-cpus/cpu/cpu54/online | 1 + .../linux-deconfigured-cpus/cpu/cpu55/online | 1 + .../linux-deconfigured-cpus/cpu/cpu56/online | 1 + .../linux-deconfigured-cpus/cpu/cpu57/online | 1 + .../linux-deconfigured-cpus/cpu/cpu58/online | 1 + .../linux-deconfigured-cpus/cpu/cpu59/online | 1 + .../linux-deconfigured-cpus/cpu/cpu6/online | 1 + .../linux-deconfigured-cpus/cpu/cpu60/online | 1 + .../linux-deconfigured-cpus/cpu/cpu61/online | 1 + .../linux-deconfigured-cpus/cpu/cpu62/online | 1 + .../linux-deconfigured-cpus/cpu/cpu63/online | 1 + .../linux-deconfigured-cpus/cpu/cpu64/online | 1 + .../linux-deconfigured-cpus/cpu/cpu65/online | 1 + .../linux-deconfigured-cpus/cpu/cpu66/online | 1 + .../linux-deconfigured-cpus/cpu/cpu67/online | 1 + .../linux-deconfigured-cpus/cpu/cpu68/online | 1 + .../linux-deconfigured-cpus/cpu/cpu69/online | 1 + .../linux-deconfigured-cpus/cpu/cpu7/online | 1 + .../linux-deconfigured-cpus/cpu/cpu70/online | 1 + .../linux-deconfigured-cpus/cpu/cpu71/online | 1 + .../linux-deconfigured-cpus/cpu/cpu72/online | 1 + .../cpu/cpu72/topology/core_id | 1 + .../cpu/cpu72/topology/core_siblings | 1 + .../cpu/cpu72/topology/core_siblings_list | 1 + .../cpu/cpu72/topology/physical_package_id | 1 + .../cpu/cpu72/topology/thread_siblings | 1 + .../cpu/cpu72/topology/thread_siblings_list | 1 + .../linux-deconfigured-cpus/cpu/cpu73/online | 1 + .../linux-deconfigured-cpus/cpu/cpu74/online | 1 + .../linux-deconfigured-cpus/cpu/cpu75/online | 1 + .../linux-deconfigured-cpus/cpu/cpu76/online | 1 + .../linux-deconfigured-cpus/cpu/cpu77/online | 1 + .../linux-deconfigured-cpus/cpu/cpu78/online | 1 + .../linux-deconfigured-cpus/cpu/cpu79/online | 1 + .../linux-deconfigured-cpus/cpu/cpu8/online | 1 + .../linux-deconfigured-cpus/cpu/cpu80/online | 1 + .../linux-deconfigured-cpus/cpu/cpu81/online | 1 + .../linux-deconfigured-cpus/cpu/cpu82/online | 1 + .../linux-deconfigured-cpus/cpu/cpu83/online | 1 + .../linux-deconfigured-cpus/cpu/cpu84/online | 1 + .../linux-deconfigured-cpus/cpu/cpu85/online | 1 + .../linux-deconfigured-cpus/cpu/cpu86/online | 1 + .../linux-deconfigured-cpus/cpu/cpu87/online | 1 + .../linux-deconfigured-cpus/cpu/cpu88/online | 1 + .../linux-deconfigured-cpus/cpu/cpu89/online | 1 + .../linux-deconfigured-cpus/cpu/cpu9/online | 1 + .../linux-deconfigured-cpus/cpu/cpu90/online | 1 + .../linux-deconfigured-cpus/cpu/cpu91/online | 1 + .../linux-deconfigured-cpus/cpu/cpu92/online | 1 + .../linux-deconfigured-cpus/cpu/cpu93/online | 1 + .../linux-deconfigured-cpus/cpu/cpu94/online | 1 + .../linux-deconfigured-cpus/cpu/cpu95/online | 1 + .../linux-deconfigured-cpus/cpu/cpu96/online | 1 + .../linux-deconfigured-cpus/cpu/cpu97/online | 1 + .../linux-deconfigured-cpus/cpu/cpu98/online | 1 + .../linux-deconfigured-cpus/cpu/cpu99/online | 1 + .../linux-deconfigured-cpus/cpu/kernel_max | 1 + .../linux-deconfigured-cpus/cpu/offline | 1 + .../linux-deconfigured-cpus/cpu/online | 1 + .../linux-deconfigured-cpus/cpu/possible | 1 + .../linux-deconfigured-cpus/cpu/present | 1 + .../linux-deconfigured-cpus/node/node0/meminfo | 29 ++++++++++++ .../linux-deconfigured-cpus/node/node1/meminfo | 29 ++++++++++++ .../linux-deconfigured-cpus/node/node16/meminfo | 29 ++++++++++++ .../linux-deconfigured-cpus/node/node17/meminfo | 29 ++++++++++++ .../linux-deconfigured-cpus/node/online | 1 + .../linux-deconfigured-cpus/node/possible | 1 + .../linux-ppc64-deconfigured-cpus.cpuinfo | 55 ++++++++++++++++++++++ .../linux-ppc64-deconfigured-cpus.expected | 1 + tests/nodeinfotest.c | 1 + 234 files changed, 400 insertions(+) create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu0/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu1/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu10/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu100/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu101/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu102/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu103/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/topology/core_id create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu105/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu106/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu107/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu108/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu109/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu11/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu110/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu111/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/topology/core_id create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu113/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu114/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu115/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu116/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu117/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu118/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu119/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu12/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/topology/core_id create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu121/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu122/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu123/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu124/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu125/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu126/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu127/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/topology/core_id create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu129/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu13/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu130/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu131/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu132/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu133/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu134/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu135/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/topology/core_id create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu137/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu138/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu139/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu14/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu140/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu141/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu142/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu143/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu144/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu145/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu146/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu147/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu148/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu149/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu15/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu150/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu151/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu152/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu153/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu154/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu155/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu156/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu157/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu158/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu159/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/topology/core_id create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu17/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu18/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu19/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu2/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu20/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu21/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu22/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu23/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/topology/core_id create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu25/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu26/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu27/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu28/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu29/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu3/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu30/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu31/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu32/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu33/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu34/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu35/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu36/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu37/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu38/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu39/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu4/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/topology/core_id create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu41/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu42/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu43/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu44/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu45/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu46/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu47/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/topology/core_id create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu49/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu5/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu50/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu51/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu52/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu53/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu54/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu55/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu56/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu57/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu58/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu59/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu6/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu60/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu61/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu62/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu63/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu64/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu65/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu66/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu67/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu68/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu69/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu7/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu70/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu71/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/topology/core_id create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu73/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu74/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu75/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu76/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu77/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu78/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu79/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu8/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu80/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu81/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu82/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu83/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu84/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu85/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu86/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu87/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu88/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu89/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu9/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu90/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu91/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu92/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu93/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu94/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu95/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu96/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu97/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu98/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu99/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/kernel_max create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/offline create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/possible create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/cpu/present create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/node/node0/meminfo create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/node/node1/meminfo create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/node/node16/meminfo create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/node/node17/meminfo create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/node/online create mode 100644 tests/nodeinfodata/linux-deconfigured-cpus/node/possible create mode 100644 tests/nodeinfodata/linux-ppc64-deconfigured-cpus.cpuinfo create mode 100644 tests/nodeinfodata/linux-ppc64-deconfigured-cpus.expected diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu0/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu0/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu0/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu1/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu1/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu1/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu10/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu10/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu10/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu100/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu100/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu100/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu101/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu101/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu101/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu102/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu102/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu102/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu103/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu103/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu103/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/online new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/online @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/topology/core_id b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/topology/core_id new file mode 100644 index 0000000..9bb71ca --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/topology/core_id @@ -0,0 +1 @@ +2152 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/topology/core_siblings b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/topology/core_siblings new file mode 100644 index 0000000..267b161 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/topology/core_siblings @@ -0,0 +1 @@ +00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00010100,00000000,00000000,00000000 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/topology/core_siblings_list b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/topology/core_siblings_list new file mode 100644 index 0000000..d11f5b7 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/topology/core_siblings_list @@ -0,0 +1 @@ +104,112 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/topology/physical_package_id b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/topology/physical_package_id new file mode 100644 index 0000000..b6a7d89 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/topology/physical_package_id @@ -0,0 +1 @@ +16 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/topology/thread_siblings b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/topology/thread_siblings new file mode 100644 index 0000000..b4fa391 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/topology/thread_siblings @@ -0,0 +1 @@ +00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000100,00000000,00000000,00000000 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/topology/thread_siblings_list b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/topology/thread_siblings_list new file mode 100644 index 0000000..b16e5f7 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu104/topology/thread_siblings_list @@ -0,0 +1 @@ +104 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu105/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu105/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu105/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu106/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu106/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu106/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu107/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu107/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu107/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu108/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu108/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu108/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu109/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu109/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu109/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu11/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu11/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu11/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu110/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu110/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu110/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu111/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu111/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu111/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/online new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/online @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/topology/core_id b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/topology/core_id new file mode 100644 index 0000000..317509b --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/topology/core_id @@ -0,0 +1 @@ +2160 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/topology/core_siblings b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/topology/core_siblings new file mode 100644 index 0000000..267b161 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/topology/core_siblings @@ -0,0 +1 @@ +00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00010100,00000000,00000000,00000000 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/topology/core_siblings_list b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/topology/core_siblings_list new file mode 100644 index 0000000..d11f5b7 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/topology/core_siblings_list @@ -0,0 +1 @@ +104,112 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/topology/physical_package_id b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/topology/physical_package_id new file mode 100644 index 0000000..b6a7d89 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/topology/physical_package_id @@ -0,0 +1 @@ +16 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/topology/thread_siblings b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/topology/thread_siblings new file mode 100644 index 0000000..968e322 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/topology/thread_siblings @@ -0,0 +1 @@ +00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00010000,00000000,00000000,00000000 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/topology/thread_siblings_list b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/topology/thread_siblings_list new file mode 100644 index 0000000..194b81c --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu112/topology/thread_siblings_list @@ -0,0 +1 @@ +112 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu113/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu113/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu113/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu114/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu114/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu114/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu115/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu115/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu115/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu116/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu116/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu116/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu117/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu117/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu117/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu118/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu118/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu118/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu119/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu119/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu119/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu12/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu12/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu12/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/online new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/online @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/topology/core_id b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/topology/core_id new file mode 100644 index 0000000..b17e4bd --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/topology/core_id @@ -0,0 +1 @@ +2208 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/topology/core_siblings b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/topology/core_siblings new file mode 100644 index 0000000..99374e8 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/topology/core_siblings @@ -0,0 +1 @@ +00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000101,01000000,00000000,00000000,00000000 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/topology/core_siblings_list b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/topology/core_siblings_list new file mode 100644 index 0000000..9764eab --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/topology/core_siblings_list @@ -0,0 +1 @@ +120,128,136 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/topology/physical_package_id b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/topology/physical_package_id new file mode 100644 index 0000000..98d9bcb --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/topology/physical_package_id @@ -0,0 +1 @@ +17 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/topology/thread_siblings b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/topology/thread_siblings new file mode 100644 index 0000000..13eaaf3 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/topology/thread_siblings @@ -0,0 +1 @@ +00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,01000000,00000000,00000000,00000000 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/topology/thread_siblings_list b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/topology/thread_siblings_list new file mode 100644 index 0000000..52bd8e4 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu120/topology/thread_siblings_list @@ -0,0 +1 @@ +120 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu121/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu121/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu121/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu122/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu122/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu122/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu123/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu123/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu123/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu124/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu124/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu124/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu125/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu125/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu125/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu126/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu126/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu126/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu127/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu127/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu127/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/online new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/online @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/topology/core_id b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/topology/core_id new file mode 100644 index 0000000..6edc5b6 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/topology/core_id @@ -0,0 +1 @@ +2224 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/topology/core_siblings b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/topology/core_siblings new file mode 100644 index 0000000..99374e8 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/topology/core_siblings @@ -0,0 +1 @@ +00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000101,01000000,00000000,00000000,00000000 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/topology/core_siblings_list b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/topology/core_siblings_list new file mode 100644 index 0000000..9764eab --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/topology/core_siblings_list @@ -0,0 +1 @@ +120,128,136 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/topology/physical_package_id b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/topology/physical_package_id new file mode 100644 index 0000000..98d9bcb --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/topology/physical_package_id @@ -0,0 +1 @@ +17 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/topology/thread_siblings b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/topology/thread_siblings new file mode 100644 index 0000000..7e18bfb --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/topology/thread_siblings @@ -0,0 +1 @@ +00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000001,00000000,00000000,00000000,00000000 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/topology/thread_siblings_list b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/topology/thread_siblings_list new file mode 100644 index 0000000..a949a93 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu128/topology/thread_siblings_list @@ -0,0 +1 @@ +128 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu129/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu129/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu129/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu13/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu13/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu13/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu130/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu130/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu130/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu131/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu131/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu131/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu132/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu132/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu132/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu133/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu133/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu133/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu134/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu134/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu134/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu135/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu135/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu135/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/online new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/online @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/topology/core_id b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/topology/core_id new file mode 100644 index 0000000..9813cea --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/topology/core_id @@ -0,0 +1 @@ +2272 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/topology/core_siblings b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/topology/core_siblings new file mode 100644 index 0000000..99374e8 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/topology/core_siblings @@ -0,0 +1 @@ +00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000101,01000000,00000000,00000000,00000000 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/topology/core_siblings_list b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/topology/core_siblings_list new file mode 100644 index 0000000..9764eab --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/topology/core_siblings_list @@ -0,0 +1 @@ +120,128,136 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/topology/physical_package_id b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/topology/physical_package_id new file mode 100644 index 0000000..98d9bcb --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/topology/physical_package_id @@ -0,0 +1 @@ +17 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/topology/thread_siblings b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/topology/thread_siblings new file mode 100644 index 0000000..c05c51e --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/topology/thread_siblings @@ -0,0 +1 @@ +00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000100,00000000,00000000,00000000,00000000 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/topology/thread_siblings_list b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/topology/thread_siblings_list new file mode 100644 index 0000000..7296f25 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu136/topology/thread_siblings_list @@ -0,0 +1 @@ +136 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu137/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu137/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu137/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu138/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu138/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu138/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu139/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu139/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu139/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu14/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu14/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu14/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu140/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu140/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu140/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu141/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu141/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu141/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu142/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu142/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu142/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu143/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu143/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu143/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu144/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu144/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu144/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu145/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu145/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu145/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu146/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu146/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu146/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu147/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu147/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu147/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu148/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu148/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu148/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu149/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu149/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu149/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu15/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu15/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu15/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu150/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu150/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu150/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu151/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu151/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu151/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu152/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu152/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu152/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu153/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu153/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu153/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu154/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu154/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu154/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu155/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu155/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu155/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu156/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu156/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu156/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu157/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu157/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu157/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu158/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu158/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu158/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu159/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu159/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu159/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/online new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/online @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/topology/core_id b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/topology/core_id new file mode 100644 index 0000000..f906e18 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/topology/core_id @@ -0,0 +1 @@ +96 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/topology/core_siblings b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/topology/core_siblings new file mode 100644 index 0000000..94bd366 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/topology/core_siblings @@ -0,0 +1 @@ +00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,01010000 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/topology/core_siblings_list b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/topology/core_siblings_list new file mode 100644 index 0000000..2887d7b --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/topology/core_siblings_list @@ -0,0 +1 @@ +16,24 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/topology/physical_package_id b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/topology/physical_package_id new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/topology/physical_package_id @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/topology/thread_siblings b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/topology/thread_siblings new file mode 100644 index 0000000..f15bff6 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/topology/thread_siblings @@ -0,0 +1 @@ +00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00010000 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/topology/thread_siblings_list b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/topology/thread_siblings_list new file mode 100644 index 0000000..b6a7d89 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu16/topology/thread_siblings_list @@ -0,0 +1 @@ +16 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu17/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu17/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu17/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu18/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu18/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu18/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu19/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu19/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu19/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu2/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu2/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu2/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu20/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu20/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu20/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu21/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu21/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu21/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu22/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu22/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu22/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu23/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu23/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu23/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/online new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/online @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/topology/core_id b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/topology/core_id new file mode 100644 index 0000000..b16e5f7 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/topology/core_id @@ -0,0 +1 @@ +104 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/topology/core_siblings b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/topology/core_siblings new file mode 100644 index 0000000..94bd366 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/topology/core_siblings @@ -0,0 +1 @@ +00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,01010000 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/topology/core_siblings_list b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/topology/core_siblings_list new file mode 100644 index 0000000..2887d7b --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/topology/core_siblings_list @@ -0,0 +1 @@ +16,24 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/topology/physical_package_id b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/topology/physical_package_id new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/topology/physical_package_id @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/topology/thread_siblings b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/topology/thread_siblings new file mode 100644 index 0000000..c20308b --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/topology/thread_siblings @@ -0,0 +1 @@ +00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,01000000 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/topology/thread_siblings_list b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/topology/thread_siblings_list new file mode 100644 index 0000000..a45fd52 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu24/topology/thread_siblings_list @@ -0,0 +1 @@ +24 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu25/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu25/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu25/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu26/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu26/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu26/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu27/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu27/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu27/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu28/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu28/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu28/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu29/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu29/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu29/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu3/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu3/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu3/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu30/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu30/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu30/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu31/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu31/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu31/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu32/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu32/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu32/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu33/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu33/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu33/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu34/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu34/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu34/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu35/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu35/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu35/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu36/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu36/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu36/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu37/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu37/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu37/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu38/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu38/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu38/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu39/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu39/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu39/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu4/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu4/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu4/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/online new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/online @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/topology/core_id b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/topology/core_id new file mode 100644 index 0000000..a762560 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/topology/core_id @@ -0,0 +1 @@ +160 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/topology/core_siblings b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/topology/core_siblings new file mode 100644 index 0000000..24976fc --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/topology/core_siblings @@ -0,0 +1 @@ +00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000100,00010100,00000000 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/topology/core_siblings_list b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/topology/core_siblings_list new file mode 100644 index 0000000..b7a5a65 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/topology/core_siblings_list @@ -0,0 +1 @@ +40,48,72 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/topology/physical_package_id b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/topology/physical_package_id new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/topology/physical_package_id @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/topology/thread_siblings b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/topology/thread_siblings new file mode 100644 index 0000000..d98f0b4 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/topology/thread_siblings @@ -0,0 +1 @@ +00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000100,00000000 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/topology/thread_siblings_list b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/topology/thread_siblings_list new file mode 100644 index 0000000..425151f --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu40/topology/thread_siblings_list @@ -0,0 +1 @@ +40 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu41/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu41/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu41/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu42/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu42/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu42/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu43/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu43/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu43/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu44/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu44/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu44/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu45/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu45/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu45/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu46/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu46/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu46/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu47/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu47/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu47/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/online new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/online @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/topology/core_id b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/topology/core_id new file mode 100644 index 0000000..1057e9a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/topology/core_id @@ -0,0 +1 @@ +176 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/topology/core_siblings b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/topology/core_siblings new file mode 100644 index 0000000..24976fc --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/topology/core_siblings @@ -0,0 +1 @@ +00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000100,00010100,00000000 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/topology/core_siblings_list b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/topology/core_siblings_list new file mode 100644 index 0000000..b7a5a65 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/topology/core_siblings_list @@ -0,0 +1 @@ +40,48,72 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/topology/physical_package_id b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/topology/physical_package_id new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/topology/physical_package_id @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/topology/thread_siblings b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/topology/thread_siblings new file mode 100644 index 0000000..943a83a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/topology/thread_siblings @@ -0,0 +1 @@ +00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00010000,00000000 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/topology/thread_siblings_list b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/topology/thread_siblings_list new file mode 100644 index 0000000..21e72e8 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu48/topology/thread_siblings_list @@ -0,0 +1 @@ +48 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu49/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu49/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu49/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu5/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu5/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu5/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu50/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu50/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu50/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu51/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu51/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu51/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu52/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu52/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu52/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu53/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu53/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu53/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu54/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu54/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu54/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu55/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu55/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu55/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu56/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu56/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu56/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu57/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu57/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu57/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu58/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu58/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu58/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu59/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu59/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu59/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu6/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu6/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu6/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu60/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu60/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu60/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu61/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu61/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu61/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu62/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu62/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu62/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu63/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu63/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu63/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu64/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu64/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu64/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu65/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu65/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu65/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu66/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu66/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu66/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu67/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu67/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu67/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu68/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu68/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu68/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu69/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu69/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu69/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu7/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu7/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu7/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu70/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu70/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu70/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu71/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu71/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu71/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/online new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/online @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/topology/core_id b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/topology/core_id new file mode 100644 index 0000000..eb08bc0 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/topology/core_id @@ -0,0 +1 @@ +240 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/topology/core_siblings b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/topology/core_siblings new file mode 100644 index 0000000..24976fc --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/topology/core_siblings @@ -0,0 +1 @@ +00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000100,00010100,00000000 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/topology/core_siblings_list b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/topology/core_siblings_list new file mode 100644 index 0000000..b7a5a65 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/topology/core_siblings_list @@ -0,0 +1 @@ +40,48,72 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/topology/physical_package_id b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/topology/physical_package_id new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/topology/physical_package_id @@ -0,0 +1 @@ +1 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/topology/thread_siblings b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/topology/thread_siblings new file mode 100644 index 0000000..b85a0fd --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/topology/thread_siblings @@ -0,0 +1 @@ +00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000100,00000000,00000000 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/topology/thread_siblings_list b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/topology/thread_siblings_list new file mode 100644 index 0000000..ea70ce0 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu72/topology/thread_siblings_list @@ -0,0 +1 @@ +72 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu73/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu73/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu73/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu74/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu74/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu74/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu75/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu75/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu75/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu76/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu76/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu76/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu77/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu77/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu77/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu78/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu78/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu78/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu79/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu79/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu79/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu8/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu8/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu8/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu80/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu80/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu80/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu81/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu81/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu81/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu82/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu82/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu82/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu83/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu83/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu83/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu84/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu84/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu84/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu85/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu85/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu85/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu86/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu86/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu86/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu87/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu87/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu87/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu88/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu88/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu88/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu89/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu89/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu89/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu9/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu9/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu9/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu90/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu90/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu90/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu91/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu91/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu91/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu92/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu92/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu92/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu93/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu93/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu93/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu94/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu94/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu94/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu95/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu95/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu95/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu96/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu96/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu96/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu97/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu97/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu97/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu98/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu98/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu98/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu99/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu99/online new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/cpu99/online @@ -0,0 +1 @@ +0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/kernel_max b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/kernel_max new file mode 100644 index 0000000..b6ac305 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/kernel_max @@ -0,0 +1 @@ +2047 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/offline b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/offline new file mode 100644 index 0000000..b74672a --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/offline @@ -0,0 +1 @@ +0-15,17-23,25-39,41-47,49-71,73-103,105-111,113-119,121-127,129-135,137-159 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/online b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/online new file mode 100644 index 0000000..dbb065f --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/online @@ -0,0 +1 @@ +16,24,40,48,72,104,112,120,128,136 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/possible b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/possible new file mode 100644 index 0000000..7a662d6 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/possible @@ -0,0 +1 @@ +0-159 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/cpu/present b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/present new file mode 100644 index 0000000..4acfa9b --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/cpu/present @@ -0,0 +1 @@ +16-31,40-55,72-79,104-143 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/node/node0/meminfo b/tests/nodeinfodata/linux-deconfigured-cpus/node/node0/meminfo new file mode 100644 index 0000000..1033a39 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/node/node0/meminfo @@ -0,0 +1,29 @@ +Node 0 MemTotal: 67108864 kB +Node 0 MemFree: 61726720 kB +Node 0 MemUsed: 5382144 kB +Node 0 Active: 276544 kB +Node 0 Inactive: 174848 kB +Node 0 Active(anon): 100928 kB +Node 0 Inactive(anon): 9152 kB +Node 0 Active(file): 175616 kB +Node 0 Inactive(file): 165696 kB +Node 0 Unevictable: 0 kB +Node 0 Mlocked: 0 kB +Node 0 Dirty: 69824 kB +Node 0 Writeback: 0 kB +Node 0 FilePages: 360256 kB +Node 0 Mapped: 42752 kB +Node 0 AnonPages: 93312 kB +Node 0 Shmem: 16768 kB +Node 0 KernelStack: 10208 kB +Node 0 PageTables: 1472 kB +Node 0 NFS_Unstable: 0 kB +Node 0 Bounce: 0 kB +Node 0 WritebackTmp: 0 kB +Node 0 Slab: 184576 kB +Node 0 SReclaimable: 57152 kB +Node 0 SUnreclaim: 127424 kB +Node 0 AnonHugePages: 0 kB +Node 0 HugePages_Total: 0 +Node 0 HugePages_Free: 0 +Node 0 HugePages_Surp: 0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/node/node1/meminfo b/tests/nodeinfodata/linux-deconfigured-cpus/node/node1/meminfo new file mode 100644 index 0000000..600841b --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/node/node1/meminfo @@ -0,0 +1,29 @@ +Node 1 MemTotal: 67108864 kB +Node 1 MemFree: 66225792 kB +Node 1 MemUsed: 883072 kB +Node 1 Active: 247040 kB +Node 1 Inactive: 82752 kB +Node 1 Active(anon): 52800 kB +Node 1 Inactive(anon): 192 kB +Node 1 Active(file): 194240 kB +Node 1 Inactive(file): 82560 kB +Node 1 Unevictable: 0 kB +Node 1 Mlocked: 0 kB +Node 1 Dirty: 64 kB +Node 1 Writeback: 0 kB +Node 1 FilePages: 281344 kB +Node 1 Mapped: 19264 kB +Node 1 AnonPages: 49088 kB +Node 1 Shmem: 4352 kB +Node 1 KernelStack: 2960 kB +Node 1 PageTables: 448 kB +Node 1 NFS_Unstable: 0 kB +Node 1 Bounce: 0 kB +Node 1 WritebackTmp: 0 kB +Node 1 Slab: 106368 kB +Node 1 SReclaimable: 16448 kB +Node 1 SUnreclaim: 89920 kB +Node 1 AnonHugePages: 0 kB +Node 1 HugePages_Total: 0 +Node 1 HugePages_Free: 0 +Node 1 HugePages_Surp: 0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/node/node16/meminfo b/tests/nodeinfodata/linux-deconfigured-cpus/node/node16/meminfo new file mode 100644 index 0000000..78350e1 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/node/node16/meminfo @@ -0,0 +1,29 @@ +Node 16 MemTotal: 67108864 kB +Node 16 MemFree: 66296832 kB +Node 16 MemUsed: 812032 kB +Node 16 Active: 145792 kB +Node 16 Inactive: 131904 kB +Node 16 Active(anon): 36352 kB +Node 16 Inactive(anon): 320 kB +Node 16 Active(file): 109440 kB +Node 16 Inactive(file): 131584 kB +Node 16 Unevictable: 0 kB +Node 16 Mlocked: 0 kB +Node 16 Dirty: 48256 kB +Node 16 Writeback: 0 kB +Node 16 FilePages: 246720 kB +Node 16 Mapped: 7744 kB +Node 16 AnonPages: 35968 kB +Node 16 Shmem: 704 kB +Node 16 KernelStack: 3232 kB +Node 16 PageTables: 512 kB +Node 16 NFS_Unstable: 0 kB +Node 16 Bounce: 0 kB +Node 16 WritebackTmp: 0 kB +Node 16 Slab: 61760 kB +Node 16 SReclaimable: 28736 kB +Node 16 SUnreclaim: 33024 kB +Node 16 AnonHugePages: 0 kB +Node 16 HugePages_Total: 0 +Node 16 HugePages_Free: 0 +Node 16 HugePages_Surp: 0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/node/node17/meminfo b/tests/nodeinfodata/linux-deconfigured-cpus/node/node17/meminfo new file mode 100644 index 0000000..3e691f2 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/node/node17/meminfo @@ -0,0 +1,29 @@ +Node 17 MemTotal: 67108864 kB +Node 17 MemFree: 65890688 kB +Node 17 MemUsed: 1218176 kB +Node 17 Active: 250752 kB +Node 17 Inactive: 181184 kB +Node 17 Active(anon): 100544 kB +Node 17 Inactive(anon): 320 kB +Node 17 Active(file): 150208 kB +Node 17 Inactive(file): 180864 kB +Node 17 Unevictable: 0 kB +Node 17 Mlocked: 0 kB +Node 17 Dirty: 97856 kB +Node 17 Writeback: 0 kB +Node 17 FilePages: 341824 kB +Node 17 Mapped: 2304 kB +Node 17 AnonPages: 100736 kB +Node 17 Shmem: 576 kB +Node 17 KernelStack: 3088 kB +Node 17 PageTables: 768 kB +Node 17 NFS_Unstable: 0 kB +Node 17 Bounce: 0 kB +Node 17 WritebackTmp: 0 kB +Node 17 Slab: 61760 kB +Node 17 SReclaimable: 14912 kB +Node 17 SUnreclaim: 46848 kB +Node 17 AnonHugePages: 49152 kB +Node 17 HugePages_Total: 0 +Node 17 HugePages_Free: 0 +Node 17 HugePages_Surp: 0 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/node/online b/tests/nodeinfodata/linux-deconfigured-cpus/node/online new file mode 100644 index 0000000..a41eb32 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/node/online @@ -0,0 +1 @@ +0-1,16-17 diff --git a/tests/nodeinfodata/linux-deconfigured-cpus/node/possible b/tests/nodeinfodata/linux-deconfigured-cpus/node/possible new file mode 100644 index 0000000..8d232c7 --- /dev/null +++ b/tests/nodeinfodata/linux-deconfigured-cpus/node/possible @@ -0,0 +1 @@ +0-255 diff --git a/tests/nodeinfodata/linux-ppc64-deconfigured-cpus.cpuinfo b/tests/nodeinfodata/linux-ppc64-deconfigured-cpus.cpuinfo new file mode 100644 index 0000000..e5560e2 --- /dev/null +++ b/tests/nodeinfodata/linux-ppc64-deconfigured-cpus.cpuinfo @@ -0,0 +1,55 @@ +processor : 16 +cpu : POWER8E (raw), altivec supported +clock : 3690.000000MHz +revision : 2.1 (pvr 004b 0201) + +processor : 24 +cpu : POWER8E (raw), altivec supported +clock : 3690.000000MHz +revision : 2.1 (pvr 004b 0201) + +processor : 40 +cpu : POWER8E (raw), altivec supported +clock : 3690.000000MHz +revision : 2.1 (pvr 004b 0201) + +processor : 48 +cpu : POWER8E (raw), altivec supported +clock : 3690.000000MHz +revision : 2.1 (pvr 004b 0201) + +processor : 72 +cpu : POWER8E (raw), altivec supported +clock : 3690.000000MHz +revision : 2.1 (pvr 004b 0201) + +processor : 104 +cpu : POWER8E (raw), altivec supported +clock : 3690.000000MHz +revision : 2.1 (pvr 004b 0201) + +processor : 112 +cpu : POWER8E (raw), altivec supported +clock : 3690.000000MHz +revision : 2.1 (pvr 004b 0201) + +processor : 120 +cpu : POWER8E (raw), altivec supported +clock : 3690.000000MHz +revision : 2.1 (pvr 004b 0201) + +processor : 128 +cpu : POWER8E (raw), altivec supported +clock : 3690.000000MHz +revision : 2.1 (pvr 004b 0201) + +processor : 136 +cpu : POWER8E (raw), altivec supported +clock : 3690.000000MHz +revision : 2.1 (pvr 004b 0201) + +timebase : 512000000 +platform : PowerNV +model : 8247-22L +machine : PowerNV 8247-22L +firmware : OPAL v3 diff --git a/tests/nodeinfodata/linux-ppc64-deconfigured-cpus.expected b/tests/nodeinfodata/linux-ppc64-deconfigured-cpus.expected new file mode 100644 index 0000000..304f423 --- /dev/null +++ b/tests/nodeinfodata/linux-ppc64-deconfigured-cpus.expected @@ -0,0 +1 @@ +CPUs: 10/80, MHz: 3690, Nodes: 1, Sockets: 1, Cores: 80, Threads: 1 diff --git a/tests/nodeinfotest.c b/tests/nodeinfotest.c index 8d0a06f..be099f0 100644 --- a/tests/nodeinfotest.c +++ b/tests/nodeinfotest.c @@ -234,6 +234,7 @@ mymain(void) {"raspberrypi", VIR_ARCH_ARMV6L}, {"f21-mustang", VIR_ARCH_AARCH64}, {"rhelsa-3.19.0-mustang", VIR_ARCH_AARCH64}, + {"deconfigured-cpus", VIR_ARCH_PPC64}, }; if (virInitialize() < 0) -- 2.4.3

2 1

[libvirt] [PATCH v3] nodeinfo: fix to parse present cpus rather than possible cpus
by Kothapally Madhu Pavan 13 Jul '15

13 Jul '15

Currently we are parsing all the possible cpus to get the nodeinfo. This fix will perform a check for present cpus before parsing. Signed-off-by: Kothapally Madhu Pavan <kmp(a)linux.vnet.ibm.com> --- src/nodeinfo.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/nodeinfo.c b/src/nodeinfo.c index 2fafe2d..5689c9b 100644 --- a/src/nodeinfo.c +++ b/src/nodeinfo.c @@ -43,6 +43,7 @@ #include "c-ctype.h" #include "viralloc.h" #include "nodeinfopriv.h" +#include "nodeinfo.h" #include "physmem.h" #include "virerror.h" #include "count-one-bits.h" @@ -418,6 +419,7 @@ virNodeParseNode(const char *node, int processors = 0; DIR *cpudir = NULL; struct dirent *cpudirent = NULL; + virBitmapPtr present_cpumap = NULL; int sock_max = 0; cpu_set_t sock_map; int sock; @@ -438,12 +440,17 @@ virNodeParseNode(const char *node, goto cleanup; } + present_cpumap = nodeGetPresentCPUBitmap(); + /* enumerate sockets in the node */ CPU_ZERO(&sock_map); while ((direrr = virDirRead(cpudir, &cpudirent, node)) > 0) { if (sscanf(cpudirent->d_name, "cpu%u", &cpu) != 1) continue; + if (present_cpumap && !(virBitmapIsSet(present_cpumap, cpu))) + continue; + if ((online = virNodeGetCpuValue(node, cpu, "online", 1)) < 0) goto cleanup; @@ -477,6 +484,9 @@ virNodeParseNode(const char *node, if (sscanf(cpudirent->d_name, "cpu%u", &cpu) != 1) continue; + if (present_cpumap && !(virBitmapIsSet(present_cpumap, cpu))) + continue; + if ((online = virNodeGetCpuValue(node, cpu, "online", 1)) < 0) goto cleanup; @@ -537,6 +547,7 @@ virNodeParseNode(const char *node, ret = -1; } VIR_FREE(core_maps); + virBitmapFree(present_cpumap); return ret; }

2 2

[libvirt] [PATCH 0/9] Add sysfs_prefix to nodeinfo.c API's
by John Ferlan 13 Jul '15

13 Jul '15

This series adds/processes a sysfs_prefix for the nodeinfo.c API's. Although the nodeinfotest.c passes a local test directory path, it was never used. This was all brought to light by patch 9 in this series which is essentially Kothapally Madhu Pavan's v3 patch: http://www.redhat.com/archives/libvir-list/2015-June/msg00395.html With the adjustment to call nodeGetPresentCPUBitmap and virNodeParseNode with the sysfs prefix. Without the first 5 patches, the patch as posted caused nodeinfotest failure in my test environment which doesn't have the "larger" environments that the test tried to set up because the test environment used my present mask file. John Ferlan (8): nodeinfo: Introduce local linuxGetCPUPresentPath nodeinfo: Add sysfs_prefix to nodeGetCPUCount nodeinfo: Add sysfs_prefix to nodeGetPresentCPUBitmap nodeinfo: Add sysfs_prefix to nodeGetCPUBitmap nodeinfo: Add sysfs_prefix to nodeGetCPUMap nodeinfo: Add sysfs_prefix to nodeGetInfo nodeinfo: Add sysfs_prefix to nodeCapsInitNUMA nodeinfo: Add sysfs_prefix to nodeGetMemoryStats Kothapally Madhu Pavan (1): nodeinfo: fix to parse present cpus rather than possible cpus src/bhyve/bhyve_capabilities.c | 2 +- src/bhyve/bhyve_driver.c | 6 +- src/lxc/lxc_conf.c | 2 +- src/lxc/lxc_controller.c | 2 +- src/lxc/lxc_driver.c | 6 +- src/nodeinfo.c | 159 +++++++++++++++++++++++++++++------------ src/nodeinfo.h | 16 +++-- src/openvz/openvz_conf.c | 4 +- src/openvz/openvz_driver.c | 6 +- src/phyp/phyp_driver.c | 2 +- src/qemu/qemu_capabilities.c | 4 +- src/qemu/qemu_driver.c | 16 ++--- src/qemu/qemu_process.c | 2 +- src/uml/uml_conf.c | 2 +- src/uml/uml_driver.c | 6 +- src/util/vircgroup.c | 2 +- src/vbox/vbox_common.c | 4 +- src/vmware/vmware_conf.c | 2 +- src/vz/vz_driver.c | 10 +-- src/vz/vz_sdk.c | 2 +- tests/vircgrouptest.c | 4 +- 21 files changed, 166 insertions(+), 93 deletions(-) -- 2.1.0

2 13

[libvirt] PING adding RDMA and tx-udp_tnl-segmentation NIC capabilities
by Moshe Levi 13 Jul '15

13 Jul '15

Hi, Can you please review "nodedev: add RDMA and tx-udp_tnl-segmentation NIC capabilities" patch [1]? [1] - http://www.redhat.com/archives/libvir-list/2015-June/msg00921.html Thanks, Moshe Levi.

1 0

[libvirt] [PATCH 1/2] configure: Move Virtuozzo checks to a specific module
by Michal Privoznik 13 Jul '15

13 Jul '15

Eventually, every driver will be moved to a special module. But for today the winner is Virtuozzo driver. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- configure.ac | 24 ++---------------------- m4/virt-driver-vz.m4 | 46 ++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 48 insertions(+), 22 deletions(-) create mode 100644 m4/virt-driver-vz.m4 diff --git a/configure.ac b/configure.ac index 6533b88..71c3bb6 100644 --- a/configure.ac +++ b/configure.ac @@ -562,10 +562,6 @@ AC_ARG_WITH([hyperv], [AS_HELP_STRING([--with-hyperv], [add Hyper-V support @<:@default=check@:>@])]) m4_divert_text([DEFAULTS], [with_hyperv=check]) -AC_ARG_WITH([vz], - [AS_HELP_STRING([--with-vz], - [add Virtuozzo support @<:@default=check@:>@])]) -m4_divert_text([DEFAULTS], [with_vz=check]) AC_ARG_WITH([test], [AS_HELP_STRING([--with-test], [add test driver support @<:@default=yes@:>@])]) @@ -1081,23 +1077,7 @@ dnl dnl Checks for the Parallels driver dnl - -if test "$with_vz" = "yes" || - test "$with_vz" = "check"; then - PKG_CHECK_MODULES([PARALLELS_SDK], [parallels-sdk], - [PARALLELS_SDK_FOUND=yes], [PARALLELS_SDK_FOUND=no]) - - if test "$with_vz" = "yes" && test "$PARALLELS_SDK_FOUND" = "no"; then - AC_MSG_ERROR([Parallels Virtualization SDK is needed to build the Parallels driver.]) - fi - - with_vz=$PARALLELS_SDK_FOUND - if test "$with_vz" = "yes"; then - AC_DEFINE_UNQUOTED([WITH_VZ], 1, - [whether vz driver is enabled]) - fi -fi -AM_CONDITIONAL([WITH_VZ], [test "$with_vz" = "yes"]) +LIBVIRT_DRIVER_CHECK_VZ dnl dnl Checks for bhyve driver @@ -2833,7 +2813,7 @@ AC_MSG_NOTICE([ LXC: $with_lxc]) AC_MSG_NOTICE([ PHYP: $with_phyp]) AC_MSG_NOTICE([ ESX: $with_esx]) AC_MSG_NOTICE([ Hyper-V: $with_hyperv]) -AC_MSG_NOTICE([ vz: $with_vz]) +LIBVIRT_DRIVER_RESULT_VZ LIBVIRT_DRIVER_RESULT_BHYVE AC_MSG_NOTICE([ Test: $with_test]) AC_MSG_NOTICE([ Remote: $with_remote]) diff --git a/m4/virt-driver-vz.m4 b/m4/virt-driver-vz.m4 new file mode 100644 index 0000000..704976e --- /dev/null +++ b/m4/virt-driver-vz.m4 @@ -0,0 +1,46 @@ +dnl The Virtuozzo driver +dnl +dnl Copyright (C) 2005-2015 Red Hat, Inc. +dnl +dnl This library is free software; you can redistribute it and/or +dnl modify it under the terms of the GNU Lesser General Public +dnl License as published by the Free Software Foundation; either +dnl version 2.1 of the License, or (at your option) any later version. +dnl +dnl This library is distributed in the hope that it will be useful, +dnl but WITHOUT ANY WARRANTY; without even the implied warranty of +dnl MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +dnl Lesser General Public License for more details. +dnl +dnl You should have received a copy of the GNU Lesser General Public +dnl License along with this library. If not, see +dnl <http://www.gnu.org/licenses/>. +dnl + +AC_DEFUN([LIBVIRT_DRIVER_CHECK_VZ],[ + AC_ARG_WITH([vz], + [AS_HELP_STRING([--with-vz], + [add Virtuozzo support @<:@default=check@:>@])]) + m4_divert_text([DEFAULTS], [with_vz=check]) + + if test "$with_vz" = "yes" || + test "$with_vz" = "check"; then + PKG_CHECK_MODULES([PARALLELS_SDK], [parallels-sdk], + [PARALLELS_SDK_FOUND=yes], [PARALLELS_SDK_FOUND=no]) + + if test "$with_vz" = "yes" && test "$PARALLELS_SDK_FOUND" = "no"; then + AC_MSG_ERROR([Parallels Virtualization SDK is needed to build the Virtuozzo driver.]) + fi + + with_vz=$PARALLELS_SDK_FOUND + if test "$with_vz" = "yes"; then + AC_DEFINE_UNQUOTED([WITH_VZ], 1, + [whether vz driver is enabled]) + fi + fi + AM_CONDITIONAL([WITH_VZ], [test "$with_vz" = "yes"]) +]) + +AC_DEFUN([LIBVIRT_DRIVER_RESULT_VZ],[ + AC_MSG_NOTICE([ vz: $with_vz]) +]) -- 2.3.6

2 2

[libvirt] [libvirt-python][PATCH] examples: Introduce nodestats example
by Michal Privoznik 13 Jul '15

13 Jul '15

So, this is an exercise to show libvirt capabilities. Firstly, for each host NUMA nodes some statistics are printed out, i.e. total memory and free memory. Then, for each running domain, that has memory strictly bound to certain host nodes, a small statistics of how much memory it takes is printed out too. For instance: # ./nodestats.py NUMA stats NUMA nodes: 0 1 2 3 MemTotal: 3950 3967 3937 3943 MemFree: 434 674 149 216 Dom 'gentoo': 1048576 1048576 1048576 1048576 We can see 4 host NUMA nodes, all of them having roughly 4GB of RAM. Yeah, some of them has nearly all the memory consumed. Then, there's only one running domain, called 'gentoo', and it has 1GB per each NUMA node configured. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- examples/nodestats.py | 106 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 106 insertions(+) create mode 100755 examples/nodestats.py diff --git a/examples/nodestats.py b/examples/nodestats.py new file mode 100755 index 0000000..dbf5593 --- /dev/null +++ b/examples/nodestats.py @@ -0,0 +1,106 @@ +#!/usr/bin/env python +# Print some host NUMA node statistics +# +# Authors: +# Michal Privoznik <mprivozn(a)redhat.com + +import libvirt +import sys +from xml.dom import minidom +import libxml2 + +class virBitmap: + def __init__(self): + self.bitmap = 0 + + def setBit(self, offset): + mask = 1 << offset + self.bitmap = self.bitmap | mask + + def clearBit(self, offset): + mask = ~(1 << offset) + self.bitmap = self.bitmap & mask + + def isSet(self, offset): + mask = 1 << offset + return(self.bitmap & mask) + + def setRange(self, start, end): + while (start <= end): + self.setBit(start) + start = start + 1 + + def parse(self, string): + for s in string.split(','): + list = s.split('-', 2) + start = int(list[0]) + if len(list) == 2: + end = int(list[1]) + else: + end = start + self.setRange(start, end) + +def xpath_eval(ctxt, path): + res = ctxt.xpathEval(path) + if res is None or len(res) == 0: + value = None + else: + value = res[0].content + return value + +try: + conn = libvirt.openReadOnly(None) +except libvirt.libvirtError: + print('Failed to connect to the hypervisor') + sys.exit(1) + +try: + capsXML = conn.getCapabilities() +except libvirt.libvirtError: + print('Failed to request capabilities') + sys.exit(1) + +caps = minidom.parseString(capsXML) +cells = caps.getElementsByTagName('cells')[0] + +nodesIDs = [ int(proc.getAttribute('id')) + for proc in cells.getElementsByTagName('cell') ] + +nodesMem = [ conn.getMemoryStats(int(proc)) + for proc in nodesIDs] + +doms = conn.listAllDomains(libvirt.VIR_CONNECT_LIST_DOMAINS_ACTIVE) +domsStrict = [ proc + for proc in doms + if proc.numaParameters()['numa_mode'] == libvirt.VIR_DOMAIN_NUMATUNE_MEM_STRICT ] + +domsStrictCfg = {} + +for dom in domsStrict: + xmlStr = dom.XMLDesc() + doc = libxml2.parseDoc(xmlStr) + ctxt = doc.xpathNewContext() + + domsStrictCfg[dom] = [ 0 for node in nodesIDs ] + + for memnode in ctxt.xpathEval("/domain/numatune/memnode"): + ctxt.setContextNode(memnode) + cellid = xpath_eval(ctxt, "@cellid") + mode = xpath_eval(ctxt, "@mode") + nodeset = xpath_eval(ctxt, "@nodeset") + + bitmap = virBitmap() + bitmap.parse(nodeset) + for node in nodesIDs: + if bitmap.isSet(int(node)): + mem = xpath_eval(ctxt, "/domain/cpu/numa/cell[@id='%s']/@memory" % cellid) + domsStrictCfg[dom][int(node)] += int(mem) + +print("NUMA stats") +print("NUMA nodes:\t\t" + "\t".join(str(node) for node in nodesIDs)) +print("MemTotal:\t\t" + "\t".join(str(i.get('total') / 1024) for i in nodesMem)) +print("MemFree:\t\t" + "\t".join(str(i.get('free') / 1024) for i in nodesMem)) + +for dom in domsStrictCfg: + sys.stdout.write("Dom '%s':\t\t" % dom.name()) + print("\t".join(map(str, domsStrictCfg[dom][:]))) -- 2.3.6

2 1

[libvirt] [PATCH] qemuProcessHandleMigrationStatus: Update migration status on ASYNC_JOB_SAVE too
by Michal Privoznik 13 Jul '15

13 Jul '15

After Jirka's migration patches libvirt is listening on migration events from qemu instead of actively polling on the monitor. There is, however, a little regression (introduced in 6d2edb6a42d0d41). The problem is, the current status of migration job is updated in qemuProcessHandleMigrationStatus if and only if migration job was started. But we have a separate job type for saving a domain into a file: QEMU_ASYNC_JOB_SAVE. Therefore, since this job is not strictly a migration job, internal state was not updated and later checks failed: virsh # save fedora22 /tmp/fedora22_ble.save error: Failed to save domain fedora22 to /tmp/fedora22_ble.save error: operation failed: domain save job: is not active Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_process.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 2a529f7..16d39b2 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -1521,29 +1521,30 @@ static int qemuProcessHandleMigrationStatus(qemuMonitorPtr mon ATTRIBUTE_UNUSED, virDomainObjPtr vm, int status, void *opaque ATTRIBUTE_UNUSED) { qemuDomainObjPrivatePtr priv; virObjectLock(vm); VIR_DEBUG("Migration of domain %p %s changed state to %s", vm, vm->def->name, qemuMonitorMigrationStatusTypeToString(status)); priv = vm->privateData; if (priv->job.asyncJob != QEMU_ASYNC_JOB_MIGRATION_OUT && - priv->job.asyncJob != QEMU_ASYNC_JOB_MIGRATION_IN) { + priv->job.asyncJob != QEMU_ASYNC_JOB_MIGRATION_IN && + priv->job.asyncJob != QEMU_ASYNC_JOB_SAVE) { VIR_DEBUG("got MIGRATION event without a migration job"); goto cleanup; } priv->job.current->status.status = status; virDomainObjBroadcast(vm); cleanup: virObjectUnlock(vm); return 0; } -- 2.3.6

2 1

[libvirt] [PATCH] RFC: audit: add shmem resource type
by Marc-André Lureau 13 Jul '15

13 Jul '15

Provide information about shared memory resources in audit log. Notes: - the same shm used several times will add up. This is a very uncommon case, but we may want to account only the different shm names instead. - the shm may exist before the VMs was started, so the shm may not actually be created by the VM (it can be there before, or created by the server for instance). https://bugzilla.redhat.com/show_bug.cgi?id=1218603 Signed-off-by: Marc-André Lureau <marcandre.lureau(a)redhat.com> --- docs/auditlog.html.in | 17 +++++++++++++++++ src/conf/domain_audit.c | 10 ++++++++++ src/conf/domain_audit.h | 6 ++++++ src/conf/domain_conf.c | 21 +++++++++++++++++++++ src/conf/domain_conf.h | 1 + src/libvirt_private.syms | 2 ++ 6 files changed, 57 insertions(+) diff --git a/docs/auditlog.html.in b/docs/auditlog.html.in index 8a007ca..a6e5f6d 100644 --- a/docs/auditlog.html.in +++ b/docs/auditlog.html.in @@ -172,6 +172,23 @@ <dd>Updated memory size in bytes</dd> </dl> + <h4><a name="typeresourceshmem">Shared Memory</a></h4> + + <p> + The <code>msg</code> field will include the following sub-fields + </p> + + <dl> + <dt>reason</dt> + <dd>The reason which caused the resource to be assigned to happen</dd> + <dt>resrc</dt> + <dd>The type of resource assigned. Set to <code>shmem</code></dd> + <dt>old-shmem</dt> + <dd>Original memory size in bytes, or 0</dd> + <dt>new-shmem</dt> + <dd>Updated memory size in bytes</dd> + </dl> + <h4><a name="typeresourcedisk">Disk</a></h4> <p> The <code>msg</code> field will include the following sub-fields diff --git a/src/conf/domain_audit.c b/src/conf/domain_audit.c index caebdba..bc81aec 100644 --- a/src/conf/domain_audit.c +++ b/src/conf/domain_audit.c @@ -783,6 +783,14 @@ virDomainAuditMemory(virDomainObjPtr vm, } void +virDomainAuditShmem(virDomainObjPtr vm, + unsigned long long oldmem, unsigned long long newmem, + const char *reason, bool success) +{ + return virDomainAuditResource(vm, "shmem", oldmem, newmem, reason, success); +} + +void virDomainAuditVcpu(virDomainObjPtr vm, unsigned int oldvcpu, unsigned int newvcpu, const char *reason, bool success) @@ -885,6 +893,8 @@ virDomainAuditStart(virDomainObjPtr vm, const char *reason, bool success) virDomainAuditMemory(vm, 0, virDomainDefGetMemoryActual(vm->def), "start", true); + virDomainAuditShmem(vm, 0, virDomainDefGetShmem(vm->def), + "start", true); virDomainAuditVcpu(vm, 0, vm->def->vcpus, "start", true); if (vm->def->iothreads) virDomainAuditIOThread(vm, 0, vm->def->iothreads, "start", true); diff --git a/src/conf/domain_audit.h b/src/conf/domain_audit.h index 97dadca..3db6ace 100644 --- a/src/conf/domain_audit.h +++ b/src/conf/domain_audit.h @@ -96,6 +96,12 @@ void virDomainAuditMemory(virDomainObjPtr vm, const char *reason, bool success) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(4); +void virDomainAuditShmem(virDomainObjPtr vm, + unsigned long long oldmem, + unsigned long long newmem, + const char *reason, + bool success) + ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(4); void virDomainAuditVcpu(virDomainObjPtr vm, unsigned int oldvcpu, unsigned int newvcpu, diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 5a9a88d..378aa1a 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -7575,6 +7575,27 @@ virDomainDefGetMemoryActual(virDomainDefPtr def) } +/** + * virDomainDefGetShmem: + * @def: domain definition + * + * Returns the current shared memory size usable by the domain described by + * @def. + */ +unsigned long long +virDomainDefGetShmem(virDomainDefPtr def) +{ + unsigned long long ret = 0; + size_t i; + + for (i = 0; i < def->nshmems; i++) { + ret += def->shmems[i]->size; + } + + return ret; +} + + static int virDomainControllerModelTypeFromString(const virDomainControllerDef *def, const char *model) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 50750c1..041d619 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2287,6 +2287,7 @@ struct _virDomainDef { unsigned long long virDomainDefGetMemoryInitial(virDomainDefPtr def); void virDomainDefSetMemoryInitial(virDomainDefPtr def, unsigned long long size); unsigned long long virDomainDefGetMemoryActual(virDomainDefPtr def); +unsigned long long virDomainDefGetShmem(virDomainDefPtr def); typedef enum { VIR_DOMAIN_KEY_WRAP_CIPHER_NAME_AES, diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 720afdf..0bb4513 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -134,6 +134,7 @@ virDomainAuditNetDevice; virDomainAuditRedirdev; virDomainAuditRNG; virDomainAuditSecurityLabel; +virDomainAuditShmem; virDomainAuditStart; virDomainAuditStop; virDomainAuditVcpu; @@ -214,6 +215,7 @@ virDomainDefGetDefaultEmulator; virDomainDefGetMemoryActual; virDomainDefGetMemoryInitial; virDomainDefGetSecurityLabelDef; +virDomainDefGetShmem; virDomainDefHasDeviceAddress; virDomainDefMaybeAddController; virDomainDefMaybeAddInput; -- 2.4.3

4 3

[libvirt] [PATCH] vz: fix cleanup of nets of bridged type
by Dmitry Guryanov 10 Jul '15

10 Jul '15

We create a virtual network of special type, which has the same name as bridge name to create bridged network adapter in vz. So when we delete such an adapter we have to remove corresponding virtual network. So let's rename prlsdkDelNet to prlsdkCleanupBridgedNet and don't check for return value. Signed-off-by: Dmitry Guryanov <dguryanov(a)parallels.com> --- src/vz/vz_sdk.c | 25 ++++++++----------------- 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index a312990..d1bc312 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -2986,20 +2986,15 @@ static int prlsdkAddNet(PRL_HANDLE sdkdom, return ret; } -static int -prlsdkDelNet(vzConnPtr privconn, virDomainNetDefPtr net) +static void +prlsdkCleanupBridgedNet(vzConnPtr privconn, virDomainNetDefPtr net) { - int ret = -1; PRL_RESULT pret; PRL_HANDLE vnet = PRL_INVALID_HANDLE; PRL_HANDLE job = PRL_INVALID_HANDLE; - if (net->type != VIR_DOMAIN_NET_TYPE_BRIDGE) { - virReportError(VIR_ERR_OPERATION_UNSUPPORTED, - _("unplugging network device of type %s is not supported"), - virDomainNetTypeToString(net->type)); - return ret; - } + if (net->type != VIR_DOMAIN_NET_TYPE_BRIDGE) + return; pret = PrlVirtNet_Create(&vnet); prlsdkCheckRetGoto(pret, cleanup); @@ -3011,11 +3006,8 @@ prlsdkDelNet(vzConnPtr privconn, virDomainNetDefPtr net) if (PRL_FAILED(pret = waitJob(job))) goto cleanup; - ret = 0; - cleanup: PrlHandle_Free(vnet); - return ret; } int prlsdkAttachNet(virDomainObjPtr dom, @@ -3107,8 +3099,7 @@ int prlsdkDetachNet(virDomainObjPtr dom, if (sdknet == PRL_INVALID_HANDLE) goto cleanup; - if (prlsdkDelNet(privconn, net) < 0) - goto cleanup; + prlsdkCleanupBridgedNet(privconn, net); pret = PrlVmDev_Remove(sdknet); prlsdkCheckRetGoto(pret, cleanup); @@ -3530,7 +3521,7 @@ prlsdkDoApplyConfig(virConnectPtr conn, if (olddef) { for (i = 0; i < olddef->nnets; i++) - prlsdkDelNet(conn->privateData, olddef->nets[i]); + prlsdkCleanupBridgedNet(conn->privateData, olddef->nets[i]); } for (i = 0; i < def->nnets; i++) { @@ -3575,7 +3566,7 @@ prlsdkDoApplyConfig(virConnectPtr conn, VIR_FREE(mask); for (i = 0; i < def->nnets; i++) - prlsdkDelNet(conn->privateData, def->nets[i]); + prlsdkCleanupBridgedNet(conn->privateData, def->nets[i]); return -1; } @@ -3722,7 +3713,7 @@ prlsdkUnregisterDomain(vzConnPtr privconn, virDomainObjPtr dom) size_t i; for (i = 0; i < dom->def->nnets; i++) - prlsdkDelNet(privconn, dom->def->nets[i]); + prlsdkCleanupBridgedNet(privconn, dom->def->nets[i]); job = PrlVm_Unreg(privdom->sdkdom); if (PRL_FAILED(waitJob(job))) -- 2.4.3

2 2

[libvirt] [PATCH] libxl: set dom0 state to running
by Jim Fehlig 10 Jul '15

10 Jul '15

Commit 45697fe5 added dom0 to driver->domains, but missed setting its state to 'running' > virsh list Id Name State ---------------------------------------------------- 0 Domain-0 shut off Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- src/libxl/libxl_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index e72b12d..5f69b49 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -549,6 +549,7 @@ libxlAddDom0(libxlDriverPrivatePtr driver) def = NULL; + virDomainObjSetState(vm, VIR_DOMAIN_RUNNING, VIR_DOMAIN_RUNNING_BOOTED); vm->def->vcpus = d_info.vcpu_online; vm->def->maxvcpus = d_info.vcpu_max_id + 1; vm->def->mem.cur_balloon = d_info.current_memkb; -- 2.1.4

2 1

[libvirt] [PATCH] Fix qemu-nbd cleanup crashes
by Cédric Bosdonnat 10 Jul '15

10 Jul '15

The virLXCControllerAppendNBDPids function didn't properly initialize pids and npids. In case of failure it was crashing when freeing those. The nbd device pid file doesn't appear immediately after starting qemu-nbd: adding a small loop to wait for it. --- src/lxc/lxc_controller.c | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c index 828b8a8..78d3eee 100644 --- a/src/lxc/lxc_controller.c +++ b/src/lxc/lxc_controller.c @@ -533,16 +533,31 @@ static int virLXCControllerAppendNBDPids(virLXCControllerPtr ctrl, const char *dev) { char *pidpath = NULL; - pid_t *pids; - size_t npids; + pid_t *pids = NULL; + size_t npids = 0; size_t i; int ret = -1; + size_t loops = 0; pid_t pid; if (!STRPREFIX(dev, "/dev/") || virAsprintf(&pidpath, "/sys/devices/virtual/block/%s/pid", dev + 5) < 0) goto cleanup; + /* Wait for the pid file to appear */ + while (!virFileExists(pidpath)) { + /* wait for 100ms before checking again, but don't do it for ever */ + if (errno == ENOENT && loop < 10) { + usleep(100 * 1000); + loop++; + } else { + virReportSystemError(errno, + _("Cannot check NBD device %s pid"), + dev + 5); + goto cleanup; + } + } + if (virPidFileReadPath(pidpath, &pid) < 0) goto cleanup; -- 2.1.4

1 0

[libvirt] [PATCH 0/4] Improve migration errors
by Jiri Denemark 10 Jul '15

10 Jul '15

When QEMU exits on destination during migration, the source reports either success (if the failure happened at the very end) or unhelpful "unexpectedly failed" error message, only the destination host knows more about the error, but usually there's no way to get the error back to the source because the domain is already gone at the time virDomainMigrateFinish* is called. This series changes libvirt to remember incoming migration errors so that they can be sent back to a source host. https://bugzilla.redhat.com/show_bug.cgi?id=1090093 Jiri Denemark (4): Introduce virHashLockable qemu: Remember incoming migration errors qemu: Don't report false error from MigrateFinish qemu: Use error from Finish instead of "unexpectedly failed" include/libvirt/virterror.h | 1 + src/libvirt-domain.c | 21 ++++++++++- src/libvirt_private.syms | 3 ++ src/qemu/qemu_conf.h | 3 ++ src/qemu/qemu_driver.c | 31 +++++++++++---- src/qemu/qemu_migration.c | 91 +++++++++++++++++++++++++++++++++++++++++++-- src/qemu/qemu_migration.h | 7 ++++ src/qemu/qemu_monitor.c | 19 ++++++++++ src/qemu/qemu_monitor.h | 2 + src/qemu/qemu_process.c | 4 ++ src/util/virerror.c | 3 ++ src/util/virhash.c | 81 ++++++++++++++++++++++++++++++++++++++++ src/util/virhash.h | 10 +++++ 13 files changed, 263 insertions(+), 13 deletions(-) -- 2.4.5

2 10

[libvirt] [libvirt-snmp][PATCH] LIBVIRT-MIB: Comply with formatting rules
by Michal Privoznik 10 Jul '15

10 Jul '15

So, I've came along this web site [1] which tries to validate a MIB file. So I fed it with LIBVIRT-MIB and found some errors. This commit fixes them so that the test passes again. This should be no functional change, rather than some formatting change. 1: http://www.simpleweb.org/ietf/mibs/validate/ Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/LIBVIRT-MIB.txt | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/LIBVIRT-MIB.txt b/src/LIBVIRT-MIB.txt index d83db49..a8195ff 100644 --- a/src/LIBVIRT-MIB.txt +++ b/src/LIBVIRT-MIB.txt @@ -6,12 +6,10 @@ LIBVIRT-MIB DEFINITIONS ::= BEGIN IMPORTS MODULE-IDENTITY, OBJECT-TYPE, enterprises, Unsigned32, Gauge32, - Counter64 - FROM SNMPv2-SMI - OBJECT-GROUP, MODULE-COMPLIANCE - FROM SNMPv2-CONF - TEXTUAL-CONVENTION, RowStatus - FROM SNMPv2-TC + Counter64 FROM SNMPv2-SMI + OBJECT-GROUP, MODULE-COMPLIANCE FROM SNMPv2-CONF + TEXTUAL-CONVENTION, RowStatus FROM SNMPv2-TC + NOTIFICATION-TYPE FROM SNMPv2-SMI ; @@ -78,7 +76,7 @@ LibvirtGuestEntry ::= SEQUENCE { libvirtGuestUUID OBJECT-TYPE SYNTAX UUID - MAX-ACCESS not-accessible + MAX-ACCESS accessible-for-notify STATUS current DESCRIPTION "The UUID of the virtual guest." @@ -202,11 +200,11 @@ libvirtGuestGroup OBJECT-GROUP ::= { libvirtGroups 1 } libvirtGuestNotif NOTIFICATION-TYPE - STATUS current OBJECTS { libvirtGuestName, libvirtGuestUUID, libvirtGuestState, libvirtGuestRowStatus } + STATUS current DESCRIPTION "Guest lifecycle notification." ::= { libvirtNotifications 1 } -- 2.3.6

1 0

[libvirt] [PATCH 0/2] Fix timerActive logic in virNetDaemon
by Martin Kletzander 10 Jul '15

10 Jul '15

Nowadays the daemon can quit even if there's a client connected, so let's fix that. If ACK'd, I'll backport this to v1.2.17-maint as well as v1.2.17 is the only affected release. Martin Kletzander (2): rpc: Add virNetDaemonHasClients rpc: Rework timerActive logic in daemon src/libvirt_remote.syms | 1 + src/rpc/virnetdaemon.c | 37 ++++++++++++++++++++++--------------- src/rpc/virnetdaemon.h | 2 ++ 3 files changed, 25 insertions(+), 15 deletions(-) -- 2.4.5

2 3

[libvirt] [PATCH] Document that virNodeGetInfo can return mhz == 0.
by Richard W.M. Jones 10 Jul '15

10 Jul '15

On the s/390x architecture, libvirt may already return 0 in the node_info->mhz field (see src/nodeinfo.c:linuxNodeInfoCPUPopulate). We may also want to return this on aarch64 in future, because calculating the proper value requires SMBIOS, which is not available on non-server-class systems (specifically on systems which don't adhere to the SBSA standard). Therefore this change documents the existing behaviour and provides a valid path for aarch64. Signed-off-by: Richard W.M. Jones <rjones(a)redhat.com> Bug-URL: https://bugzilla.redhat.com/1206353 --- include/libvirt/libvirt-host.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/libvirt/libvirt-host.h b/include/libvirt/libvirt-host.h index 953366b..070550b 100644 --- a/include/libvirt/libvirt-host.h +++ b/include/libvirt/libvirt-host.h @@ -354,7 +354,8 @@ struct _virNodeInfo { char model[32]; /* string indicating the CPU model */ unsigned long memory; /* memory size in kilobytes */ unsigned int cpus; /* the number of active CPUs */ - unsigned int mhz; /* expected CPU frequency */ + unsigned int mhz; /* expected CPU frequency, 0 if not known or + on unusual architectures */ unsigned int nodes; /* the number of NUMA cell, 1 for unusual NUMA topologies or uniform memory access; check capabilities XML for the actual NUMA topology */ -- 2.3.1

3 3

[libvirt] [PATCH] qemu: Reject updating unsupported disk information
by Martin Kletzander 10 Jul '15

10 Jul '15

If one calls update-device with information that is not updatable, libvirt reports success even though no data were updated. The example used in the bug linked below uses updating device with <boot order='2'/> which, in my opinion, is a valid thing to request from user's perspective. Mainly since we properly error out if user wants to update such data on a network device for example. And since there are many things that might happen (update-device on disk basically knows just how to change removable media), check for what's changing and moreover, since the function might be usable in other dirvers (updating only disk path is a valid possibility) let's abstract it for any two disks. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1007228 --- src/conf/domain_conf.c | 111 +++++++++++++++++++++++++++++++++++++++++++++++ src/conf/domain_conf.h | 2 + src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 3 ++ 4 files changed, 117 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0219c3c4814d..a6950087d987 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5687,6 +5687,117 @@ virDomainDiskFindByBusAndDst(virDomainDefPtr def, return NULL; } + +/* + * Makes sure the @disk differs from @orig_disk only by the source + * path and nothing else. Fields that are being checked and the + * information whether they are nullable (can be NULL) or is taken + * from the virDomainDiskDefFormat() code. + */ +bool +virDomainDiskDiffersSourceOnly(virDomainDiskDefPtr disk, + virDomainDiskDefPtr orig_disk) +{ +#define CHECK_EQ(field, field_name, nullable) \ + do { \ + if (nullable && !disk->field) \ + break; \ + if (disk->field != orig_disk->field) { \ + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, \ + _("cannot modify field '%s' of the disk"), \ + field_name); \ + return false; \ + } \ + } while (0) + + CHECK_EQ(device, "device", false); + CHECK_EQ(cachemode, "cache", true); + CHECK_EQ(error_policy, "error_policy", true); + CHECK_EQ(rerror_policy, "rerror_policy", true); + CHECK_EQ(iomode, "io", true); + CHECK_EQ(ioeventfd, "ioeventfd", true); + CHECK_EQ(event_idx, "event_idx", true); + CHECK_EQ(copy_on_read, "copy_on_read", true); + CHECK_EQ(discard, "discard", true); + CHECK_EQ(iothread, "iothread", true); + + if (disk->geometry.cylinders && + disk->geometry.heads && + disk->geometry.sectors) { + CHECK_EQ(geometry.cylinders, "geometry cylinders", false); + CHECK_EQ(geometry.heads, "geometry heads", false); + CHECK_EQ(geometry.sectors, "geometry sectors", false); + CHECK_EQ(geometry.trans, "BIOS-translation-modus", true); + } + + CHECK_EQ(blockio.logical_block_size, + "blockio logical_block_size", false); + CHECK_EQ(blockio.physical_block_size, + "blockio physical_block_size", false); + + if (disk->bus == VIR_DOMAIN_DISK_BUS_USB) + CHECK_EQ(removable, "removable", true); + + CHECK_EQ(blkdeviotune.total_bytes_sec, + "blkdeviotune.total_bytes_sec", + true); + CHECK_EQ(blkdeviotune.read_bytes_sec, + "blkdeviotune.read_bytes_sec", + true); + CHECK_EQ(blkdeviotune.write_bytes_sec, + "blkdeviotune.write_bytes_sec", + true); + CHECK_EQ(blkdeviotune.total_iops_sec, + "blkdeviotune.total_iops_sec", + true); + CHECK_EQ(blkdeviotune.read_iops_sec, + "blkdeviotune.read_iops_sec", + true); + CHECK_EQ(blkdeviotune.write_iops_sec, + "blkdeviotune.write_iops_sec", + true); + CHECK_EQ(blkdeviotune.total_bytes_sec_max, + "blkdeviotune.total_bytes_sec_max", + true); + CHECK_EQ(blkdeviotune.read_bytes_sec_max, + "blkdeviotune.read_bytes_sec_max", + true); + CHECK_EQ(blkdeviotune.write_bytes_sec_max, + "blkdeviotune.write_bytes_sec_max", + true); + CHECK_EQ(blkdeviotune.total_iops_sec_max, + "blkdeviotune.total_iops_sec_max", + true); + CHECK_EQ(blkdeviotune.read_iops_sec_max, + "blkdeviotune.read_iops_sec_max", + true); + CHECK_EQ(blkdeviotune.write_iops_sec_max, + "blkdeviotune.write_iops_sec_max", + true); + CHECK_EQ(blkdeviotune.size_iops_sec, + "blkdeviotune.size_iops_sec", + true); + + CHECK_EQ(transient, "transient", true); + CHECK_EQ(serial, "serial", true); + CHECK_EQ(wwn, "wwn", true); + CHECK_EQ(vendor, "vendor", true); + CHECK_EQ(product, "product", true); + + CHECK_EQ(info.bootIndex, "boot order", true); + + if (disk->info.alias && STRNEQ(disk->info.alias, orig_disk->info.alias)) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, + _("cannot modify field '%s' of the disk"), + "alias name"); + return false; + } + +#undef CHECK_EQ + + return true; +} + int virDomainDiskDefAssignAddress(virDomainXMLOptionPtr xmlopt, virDomainDiskDefPtr def) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 12d945ea7f24..b84640c2de56 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2475,6 +2475,8 @@ int virDomainDeviceFindControllerModel(virDomainDefPtr def, virDomainDiskDefPtr virDomainDiskFindByBusAndDst(virDomainDefPtr def, int bus, char *dst); +bool virDomainDiskDiffersSourceOnly(virDomainDiskDefPtr disk, + virDomainDiskDefPtr orig_disk); void virDomainControllerDefFree(virDomainControllerDefPtr def); void virDomainFSDefFree(virDomainFSDefPtr def); void virDomainActualNetDefFree(virDomainActualNetDefPtr def); diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 1566d11e4156..5534dc7ed704 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -249,6 +249,7 @@ virDomainDiskDefFree; virDomainDiskDefNew; virDomainDiskDefSourceParse; virDomainDiskDeviceTypeToString; +virDomainDiskDiffersSourceOnly; virDomainDiskDiscardTypeToString; virDomainDiskErrorPolicyTypeFromString; virDomainDiskErrorPolicyTypeToString; diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index ba804429a28a..4f1724e92e4a 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7916,6 +7916,9 @@ qemuDomainChangeDiskMediaLive(virConnectPtr conn, goto end; } + if (!virDomainDiskDiffersSourceOnly(disk, orig_disk)) + goto end; + /* Add the new disk src into shared disk hash table */ if (qemuAddSharedDevice(driver, dev, vm->def->name) < 0) goto end; -- 2.4.5

3 3

[libvirt] [PATCH] qemu: Check duplicate WWNs also for hotplugged disks
by Peter Krempa 10 Jul '15

10 Jul '15

In commit 714b38cb232bcbbd7487af4c058fa6d0999b3326 I tried to avoid having two disks with the same WWN in a VM. I forgot to check the hotplug paths though which make it possible bypass that check. Reinforce the fix by checking the wwn when attaching the disk. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1208009 --- src/conf/domain_conf.c | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1f7862b..5a9a88d 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -22135,6 +22135,34 @@ virDomainDeviceInfoCheckBootIndex(virDomainDefPtr def ATTRIBUTE_UNUSED, return 0; } + +/** + * virDomainDefGetDiskByWWN: + * @def: domain definition + * @wwn: wwn of a disk to find + * + * Returns a disk definition pointer corresponding to the given WWN identifier + * or NULL either if @wwn was NULL or if disk with given WWN is not present in + * the domain definition. + */ +static virDomainDiskDefPtr +virDomainDefGetDiskByWWN(virDomainDefPtr def, + const char *wwn) +{ + size_t i; + + if (!wwn) + return NULL; + + for (i = 0; i < def->ndisks; i++) { + if (STREQ_NULLABLE(def->disks[i]->wwn, wwn)) + return def->disks[i]; + } + + return NULL; +} + + int virDomainDefCompatibleDevice(virDomainDefPtr def, virDomainDeviceDefPtr dev, @@ -22178,6 +22206,15 @@ virDomainDefCompatibleDevice(virDomainDefPtr def, } } + if (dev->type == VIR_DOMAIN_DEVICE_DISK) { + if (!!virDomainDefGetDiskByWWN(def, dev->data.disk->wwn)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Domain already has a disk with wwn '%s'"), + dev->data.disk->wwn); + return -1; + } + } + return 0; } -- 2.4.5

2 2

[libvirt] [PATCH] cpu: Add support for MPX and AVX512 Intel features
by Jiri Denemark 10 Jul '15

10 Jul '15

Corresponding QEMU commits: MPX 79e9ebebbf2a00c46fcedb6dc7dd5e12bbd30216 AVX512 9aecd6f8aef653cea58932f06a2740299dbe5fd3 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/cpu/cpu_map.xml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml index b9e95cf..b924bd3 100644 --- a/src/cpu/cpu_map.xml +++ b/src/cpu/cpu_map.xml @@ -317,6 +317,12 @@ <feature name='rtm'> <cpuid function='0x00000007' ebx='0x00000800'/> </feature> + <feature name='mpx'> + <cpuid function='0x00000007' ebx='0x00004000'/> + </feature> + <feature name='avx512f'>  + <cpuid function='0x00000007' ebx='0x00010000'/> + </feature> <feature name='rdseed'> <cpuid function='0x00000007' ebx='0x00040000'/> </feature> @@ -326,6 +332,15 @@ <feature name='smap'> <cpuid function='0x00000007' ebx='0x00100000'/> </feature> + <feature name='avx512pf'>  + <cpuid function='0x00000007' ebx='0x04000000'/> + </feature> + <feature name='avx512er'>  + <cpuid function='0x00000007' ebx='0x08000000'/> + </feature> + <feature name='avx512cd'>  + <cpuid function='0x00000007' ebx='0x10000000'/> + </feature>  <feature name='invtsc' migratable='no'> -- 2.4.5

2 1

[libvirt] [PATCH v3] qemu: Use heads parameter for QXL driver
by Frediano Ziglio 10 Jul '15

10 Jul '15

Allows to specify maximum number of head to QXL driver. The patch to support the "max_outputs" in Qemu is still not merged but I got agreement on the name of the argument. Actually can be a compatiblity problem as heads in the XML configuration was set by default to '1'. Signed-off-by: Frediano Ziglio <fziglio(a)redhat.com> --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 5 +++++ 3 files changed, 8 insertions(+) Changes from v2: - removed capability tests (Martin Kletzander) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 27686c3..68060cd 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -287,6 +287,7 @@ VIR_ENUM_IMPL(virQEMUCaps, QEMU_CAPS_LAST, "aarch64-off", "vhost-user-multiqueue", /* 190 */ + "qxl-vga.max_outputs", ); @@ -1649,6 +1650,7 @@ static struct virQEMUCapsStringFlags virQEMUCapsObjectPropsQxl[] = { static struct virQEMUCapsStringFlags virQEMUCapsObjectPropsQxlVga[] = { { "vgamem_mb", QEMU_CAPS_QXL_VGA_VGAMEM }, + { "max_outputs", QEMU_CAPS_QXL_VGA_MAX_OUTPUTS }, }; struct virQEMUCapsObjectTypeProps { diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h index 30aa504..02f9e81 100644 --- a/src/qemu/qemu_capabilities.h +++ b/src/qemu/qemu_capabilities.h @@ -230,6 +230,7 @@ typedef enum { QEMU_CAPS_DEVICE_PCI_SERIAL = 188, /* -device pci-serial */ QEMU_CAPS_CPU_AARCH64_OFF = 189, /* -cpu ...,aarch64=off */ QEMU_CAPS_VHOSTUSER_MULTIQUEUE = 190, /* vhost-user with -netdev queues= */ + QEMU_CAPS_QXL_VGA_MAX_OUTPUTS = 191, /* qxl-vga.max_outputs */ QEMU_CAPS_LAST, /* this must always be the last item */ } virQEMUCapsFlags; diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 25a7bc6..59666e7 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -5661,6 +5661,11 @@ qemuBuildDeviceVideoStr(virDomainDefPtr def, /* QEMU accepts mebibytes for vgamem_mb. */ virBufferAsprintf(&buf, ",vgamem_mb=%u", video->vgamem / 1024); } + + if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_QXL_VGA_MAX_OUTPUTS) && + video->heads > 0) { + virBufferAsprintf(&buf, ",max_outputs=%u", video->heads); + } } else if (video->vram && ((video->type == VIR_DOMAIN_VIDEO_TYPE_VGA && virQEMUCapsGet(qemuCaps, QEMU_CAPS_VGA_VGAMEM)) || -- 2.1.0

2 2

[libvirt] [PATCH] qemu: don't use initialized ret in qemuRemoveSharedDevice
by Guido Günther 09 Jul '15

09 Jul '15

This fixes CC qemu/libvirt_driver_qemu_impl_la-qemu_conf.lo qemu/qemu_conf.c: In function 'qemuRemoveSharedDevice': qemu/qemu_conf.c:1384:9: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized] --- This is only catched by Debian Wheezy's gcc 4.7.2, Jessies gcc 4.9.2 doesn't trap on it. src/qemu/qemu_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 2ab5494..38d4a86 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -1381,7 +1381,7 @@ qemuRemoveSharedHostdev(virQEMUDriverPtr driver, { char *dev_path = NULL; char *key = NULL; - int ret; + int ret = -1; if (!qemuIsSharedHostdev(hostdev)) return 0; -- 2.1.4

3 3

[libvirt] [PATCH] qemu: Log all arguments of qemuProcessStart
by Jiri Denemark 09 Jul '15

09 Jul '15

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_process.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index ba84182..ee522b9 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -4302,9 +4302,10 @@ int qemuProcessStart(virConnectPtr conn, size_t nnicindexes = 0; int *nicindexes = NULL; - VIR_DEBUG("vm=%p name=%s id=%d pid=%llu", - vm, vm->def->name, vm->def->id, - (unsigned long long)vm->pid); + VIR_DEBUG("vm=%p name=%s id=%d asyncJob=%d migrateFrom=%s stdin_fd=%d " + "stdin_path=%s snapshot=%p vmop=%d flags=0x%x", + vm, vm->def->name, vm->def->id, asyncJob, NULLSTR(migrateFrom), + stdin_fd, NULLSTR(stdin_path), snapshot, vmop, flags); /* Okay, these are just internal flags, * but doesn't hurt to check */ -- 2.4.5

2 2

[libvirt] [PATCH] qemu: Drop LFs at the end of error from QEMU log
by Jiri Denemark 09 Jul '15

09 Jul '15

Libvirt's error messages do not end with a LF. However, when reading the error from QEMU log, we would read the LF from the log and keep it in the message. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_monitor.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 93fcc7f..896d9fd 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -407,6 +407,9 @@ qemuMonitorGetErrorFromLog(qemuMonitorPtr mon) if ((len = qemuProcessReadLog(mon->logfd, logbuf, 4096 - 1, 0, true)) <= 0) goto error; + while (len > 0 && logbuf[len - 1] == '\n') + logbuf[--len] = '\0'; + cleanup: errno = orig_errno; VIR_FORCE_CLOSE(mon->logfd); -- 2.4.5

2 2

[libvirt] [PATCH v4 0/5] Add support for migration event
by Jiri Denemark 09 Jul '15

09 Jul '15

The final version of migration event patches which got accepted upstream had to be slightly modified -- the event is only emitted when "events" migration capability is turned on (default is off). Thus a new patch had to be added to libvirt. I'm resending all migration event patches for context even though they haven't changed at all since they were ACKed. Jiri Denemark (5): qemu_monitor: Wire up MIGRATION event qemu: Enable migration events on QMP monitor qemuDomainGetJobStatsInternal: Support migration events qemu: Update migration state according to MIGRATION event qemu: Wait for migration events on domain condition src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_domain.h | 3 ++ src/qemu/qemu_driver.c | 27 ++++++++++++--- src/qemu/qemu_migration.c | 59 +++++++++++++++++++++++++++----- src/qemu/qemu_monitor.c | 16 ++++++++- src/qemu/qemu_monitor.h | 9 +++++ src/qemu/qemu_monitor_json.c | 23 +++++++++++++ src/qemu/qemu_process.c | 80 +++++++++++++++++++++++++++++++++++++------- 9 files changed, 195 insertions(+), 25 deletions(-) -- 2.4.5

2 9

[libvirt] [java] [PATCH 0/6] Fix JNA wrapping, fix memory leaks and wrap security model / label function
by Claudio Bley 09 Jul '15

09 Jul '15

Hi. First and foremost, this series fixes a few mistakes in the wrapping code found by inspecting the org.libvirt.jna.Libvirt interface and the corresponding C types of the XML API file. The last two patches add two missing functions introduced in libvirt 0.6.1. At the end of the day, this means libvirt-java has gained full coverage of the libvirt functions up to and including version 0.8.5. Yay! Claudio Bley (6): JNA: fix wrong return type void vs. int JNA: add CString class and fix memory leaks JNA: simplify freeing memory for C strings Use the CString class for Arrays of CStrings too Implement Domain.getSecurityLabel and add SecurityLabel class Implement Connect.getSecurityModel and add SecurityModel class src/main/java/org/libvirt/Connect.java | 74 +++++++++-------- src/main/java/org/libvirt/Device.java | 9 +- src/main/java/org/libvirt/Domain.java | 57 ++++++------- src/main/java/org/libvirt/DomainSnapshot.java | 8 +- src/main/java/org/libvirt/Interface.java | 7 +- src/main/java/org/libvirt/Library.java | 44 +++------- src/main/java/org/libvirt/Network.java | 14 +--- src/main/java/org/libvirt/NetworkFilter.java | 2 +- src/main/java/org/libvirt/Secret.java | 2 +- src/main/java/org/libvirt/SecurityLabel.java | 49 +++++++++++ src/main/java/org/libvirt/SecurityModel.java | 37 +++++++++ src/main/java/org/libvirt/StoragePool.java | 9 +- src/main/java/org/libvirt/StorageVol.java | 16 +--- src/main/java/org/libvirt/jna/CString.java | 85 +++++++++++++++++++ src/main/java/org/libvirt/jna/Libvirt.java | 114 +++++++++++++++++--------- 15 files changed, 343 insertions(+), 184 deletions(-) create mode 100644 src/main/java/org/libvirt/SecurityLabel.java create mode 100644 src/main/java/org/libvirt/SecurityModel.java create mode 100644 src/main/java/org/libvirt/jna/CString.java -- 2.2.2

2 9

[libvirt] [PATCHv4 0/2] Fix cloning of sparse raw volumes
by Ján Tomko 09 Jul '15

09 Jul '15

v3: https://www.redhat.com/archives/libvir-list/2015-June/msg01422.html v4: * introduces a new no-op patch changing the calculation of remaining allocation * allows partial allocation of new volumes on systems without fallocate Ján Tomko (1): Rewrite allocation tracking when cloning volumes Prerna Saxena (1): Fix cloning of raw, sparse volumes src/storage/storage_backend.c | 29 ++++++++++++++++++----------- src/storage/storage_driver.c | 5 ----- 2 files changed, 18 insertions(+), 16 deletions(-) -- 2.3.6

2 3

[libvirt] [PATCH v2 0/4] fix ejecting removable media and some cleanup
by Pavel Hrdina 09 Jul '15

09 Jul '15

Pavel Hrdina (4): virCondWaitUntil: add another return value virDomainObjSignal: drop this function monitor: detect that eject fails because the tray is locked qemu_hotplug: try harder to eject media src/conf/domain_conf.c | 27 ++++++++-------- src/conf/domain_conf.h | 1 - src/libvirt_private.syms | 1 - src/qemu/qemu_hotplug.c | 73 +++++++++++++++++++++----------------------- src/qemu/qemu_monitor_json.c | 14 +++++++++ src/qemu/qemu_monitor_text.c | 10 ++++++ src/qemu/qemu_process.c | 6 ++-- 7 files changed, 77 insertions(+), 55 deletions(-) -- 2.4.4

3 9

[libvirt] [PATCH 0/7] Simplify qemuMigrationFinish
by Jiri Denemark 09 Jul '15

09 Jul '15

While hacking qemuMigrationFinish I found it pretty hard to follow and revealed few bugs (patches 3 to 5) in the code. Jiri Denemark (7): qemu: Split qemuMigrationFinish qemu: Simplify qemuMigrationFinish qemu: Don't fail migration on save status failure qemu: Kill domain when migration finish fails qemu: Don't report false errors in migration protocol v2 qemuDomainEventQueue: Check if event is non-NULL qemu: Queue events in migration Finish phase ASAP src/qemu/qemu_blockjob.c | 6 +- src/qemu/qemu_cgroup.c | 3 +- src/qemu/qemu_domain.c | 6 +- src/qemu/qemu_driver.c | 87 +++++++------------- src/qemu/qemu_hotplug.c | 26 +++--- src/qemu/qemu_migration.c | 199 ++++++++++++++++++++++------------------------ src/qemu/qemu_process.c | 72 ++++++----------- 7 files changed, 167 insertions(+), 232 deletions(-) -- 2.4.5

2 14

[libvirt] [PATCH] storage: Revert volume obj list updating after volume creation (4749d82a)
by Erik Skultety 09 Jul '15

09 Jul '15

This patch reverts commit 4749d82a which tried to tweak the logic in volume creation. We did realloc and update our object list before we executed volume building within a specific storage backend. If that failed, we had to update (again) our object list to the original state as it was before the build and delete the volume from the pool (even though it didn't exist - this truly depends on the backend). I misunderstood the base idea to be able to poll the status of the volume creation using vol-info. After commit 4749d82a this wasn't possible anymore, although no BZ has been reported yet. Commit 4749d82a also claimed to fix https://bugzilla.redhat.com/show_bug.cgi?id=1223177, but commit c8be606b of the same series as 4749d82ad (which was more of a refactor than a fix) fixes the same issue so the revert should be pretty straightforward. Further more, BZ https://bugzilla.redhat.com/show_bug.cgi?id=1241454 can be fixed with this revert. --- src/storage/storage_driver.c | 28 ++++++++++++++++++---------- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index d3cdbc5..b67a5d8 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -1803,6 +1803,9 @@ storageVolCreateXML(virStoragePoolPtr obj, goto cleanup; } + if (VIR_REALLOC_N(pool->volumes.objs, + pool->volumes.count+1) < 0) + goto cleanup; if (!backend->createVol) { virReportError(VIR_ERR_NO_SUPPORT, @@ -1817,6 +1820,14 @@ storageVolCreateXML(virStoragePoolPtr obj, if (backend->createVol(obj->conn, pool, voldef) < 0) goto cleanup; + pool->volumes.objs[pool->volumes.count++] = voldef; + volobj = virGetStorageVol(obj->conn, pool->def->name, voldef->name, + voldef->key, NULL, NULL); + if (!volobj) { + pool->volumes.count--; + goto cleanup; + } + if (VIR_ALLOC(buildvoldef) < 0) { voldef = NULL; goto cleanup; @@ -1845,18 +1856,15 @@ storageVolCreateXML(virStoragePoolPtr obj, voldef->building = false; pool->asyncjobs--; - if (buildret < 0) + if (buildret < 0) { + VIR_FREE(buildvoldef); + storageVolDeleteInternal(volobj, backend, pool, voldef, + 0, false); + voldef = NULL; goto cleanup; - } - - if (VIR_REALLOC_N(pool->volumes.objs, - pool->volumes.count+1) < 0) - goto cleanup; + } - pool->volumes.objs[pool->volumes.count++] = voldef; - if (!(volobj = virGetStorageVol(obj->conn, pool->def->name, voldef->name, - voldef->key, NULL, NULL))) - goto cleanup; + } if (backend->refreshVol && backend->refreshVol(obj->conn, pool, voldef) < 0) -- 1.9.3

2 2

[libvirt] shall libvirtd validate guest's name ?
by zhang bo 09 Jul '15

09 Jul '15

linux-ZyvZnF:~ # virsh list --all Id Name State ---------------------------------------------------- - redhat7;reboot shut off - oscar-vm-5 shut off As shown above, 1 we use command "virsh define a.xml" to define a guest with a name containing ';', that's 'redhat7;reboot' 2 then we start the guest: "virsh start redhat7;reboot" 3 shell consider the command as a) run "virsh start redhat7", failed b) run "reboot", to reboot the host And *the host get rebooted*. shall libvirtd do the guest-name-validation work? Or other suggustions? -- Oscar oscar.zhangbo(a)huawei.com

3 2

[libvirt] [PATCH v4 0/3] Allow PCI virtio on ARM "virt" machine
by Pavel Fedin 09 Jul '15

09 Jul '15

Virt machine in qemu since v2.3.0 has PCI generic host controller, and can use PCI devices. This provides performance improvement as well as vhost-net with irqfd support for virtio-net. However libvirt currently does not allow ARM virt machine to have PCI devices. This patchset adds the necessary support. Changes since v3: - Capability is based not on qemu version but on support of "gpex-pcihost" device by qemu - Added a workaround, allowing to pass "make check". The problem is that test suite does not build capabilities cache. Unfortunately this means that correct unit-test for the new functionality currently cannot be written. Test suite framework needs to be improved. Changes since v2: Complete rework, use different approach - Correctly model PCI Express bus on the machine. It is now possible to explicitly specify <address-type='pci'> with attributes. This allows to attach not only virtio, but any other PCI device to the model. - Default is not changed and still mmio, for backwards compatibility with existing installations. PCI bus has to be explicitly specified. - Check for the capability in correct place, in v2 it actually did not work Changes since v1: - Added capability based on qemu version number - Recognize also "virt-" prefix Pavel Fedin (3): Introduce QEMU_CAPS_OBJECT_GPEX Add PCI-Express root to ARM virt machine Build correct command line for PCI NICs on ARM src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 3 ++- src/qemu/qemu_domain.c | 17 +++++++++++++---- 4 files changed, 18 insertions(+), 5 deletions(-) -- 1.9.5.msysgit.0

1 3

[libvirt] [PATCH] conf: Don't allow duplicated targets regardless of bus
by John Ferlan 09 Jul '15

09 Jul '15

https://bugzilla.redhat.com/show_bug.cgi?id=1142631 Commit id 'e0e290552' added a check to determine if the same bus had the same target value. It seems that's not quite good enough as the check should check the target name value regardless of bus type. Also added a DO_TEST_DIFFERENT to exhibit the issue Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- src/conf/domain_conf.c | 3 +- .../qemuxml2argv-disk-same-targets.xml | 35 ++++++++++++++++++++++ tests/qemuxml2argvtest.c | 3 ++ 3 files changed, 39 insertions(+), 2 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-same-targets.xml diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b10f6cd..7855bcb 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -12590,8 +12590,7 @@ virDomainDiskDefDstDuplicates(virDomainDefPtr def) for (i = 1; i < def->ndisks; i++) { for (j = 0; j < i; j++) { - if (def->disks[i]->bus == def->disks[j]->bus && - STREQ(def->disks[i]->dst, def->disks[j]->dst)) { + if (STREQ(def->disks[i]->dst, def->disks[j]->dst)) { virReportError(VIR_ERR_XML_ERROR, _("target '%s' duplicated for disk sources " "'%s' and '%s'"), diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-same-targets.xml b/tests/qemuxml2argvdata/qemuxml2argv-disk-same-targets.xml new file mode 100644 index 0000000..3276ce5 --- /dev/null +++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-same-targets.xml @@ -0,0 +1,35 @@ +<domain type='qemu'> + <name>QEMUGuest1</name> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> + <memory unit='KiB'>219136</memory> + <currentMemory unit='KiB'>219136</currentMemory> + <vcpu placement='static'>1</vcpu> + <os> + <type arch='i686' machine='pc'>hvm</type> + <boot dev='hd'/> + </os> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <emulator>/usr/bin/qemu</emulator> + <disk type='block' device='disk'> + <source dev='/dev/HostVG/QEMUGuest1'/> + <target dev='hda' bus='ide'/> + </disk> + <disk type='file' device='disk'> + <source file='/tmp/usbdisk.img'/> + <target dev='sda' bus='usb'/> + </disk> + <disk type='file' device='disk'> + <source file='/tmp/idedisk.img'/> + <target dev='sda' bus='ide'/> + </disk> + <disk type='file' device='disk'> + <source file='/tmp/scsidisk.img'/> + <target dev='sda' bus='scsi'/> + </disk> + <memballoon model='virtio'/> + </devices> +</domain> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index be82dd2..b066681 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -882,6 +882,9 @@ mymain(void) QEMU_CAPS_DEVICE); DO_TEST("disk-snapshot", QEMU_CAPS_DRIVE, QEMU_CAPS_DRIVE_CACHE_V2, QEMU_CAPS_DRIVE_FORMAT); + DO_TEST_FAILURE("disk-same-targets", + QEMU_CAPS_DRIVE, QEMU_CAPS_DEVICE, QEMU_CAPS_SCSI_LSI, + QEMU_CAPS_DEVICE_USB_STORAGE, QEMU_CAPS_NODEFCONFIG); DO_TEST("event_idx", QEMU_CAPS_DRIVE, QEMU_CAPS_VIRTIO_BLK_EVENT_IDX, -- 2.1.0

2 3

[libvirt] [PATCH v3 0/4] Followup for unpriv_sgio changes
by John Ferlan 09 Jul '15

09 Jul '15

v2: http://www.redhat.com/archives/libvir-list/2015-July/msg00204.html I pushed the first 3 patches already since they were ACK'd This is patches 4-8 adjusted for code review comments Patch1 (former patch4) - change the function to use qemuCheckUnprivSGIO not qemuCheckUnprivSGIO. Also used a -1 or -2 return value for handling the mismatched sgio setting error which requires the caller to have a message including the device with the issue Former patch 5 abandoned Patch2 (former patch6) - completely removed qemuGetSharedHostdevKey and replaced with inline code. Although this looks odd now, a future patch will use the device name on the add side. Patch3 (former patch7) - restored the {} in the right place Patch4 (former patch8) - remove val initialization - already ACK'd, but easier for me to just keep in the current order. Former patches 9 & 10 - keeping separate for downstream John Ferlan (4): qemu: Refactor qemuCheckSharedDisk to create qemuCheckUnprivSGIO qemu: Inline qemuGetHostdevPath qemu: Refactor qemuSetUnprivSGIO return values qemu: Fix integer/boolean logic in qemuSetUnprivSGIO src/qemu/qemu_conf.c | 151 ++++++++++++++++++++++++++++++--------------------- 1 file changed, 89 insertions(+), 62 deletions(-) -- 2.1.0

2 8

[libvirt] [PATCH 00/10] Implement shared memory device - Part 1
by Luyao Huang 09 Jul '15

09 Jul '15

This part contains some small fix and Implement the hot-plug/hot-unplug and cold-plug/cold-unplug for Inter-VM Shared Memory PCI device. Luyao Huang (10): qemu: auto assign pci address for shared memory device qemu: always build id when generate shared memory device CLI qemu: Refactor creation of shared memory device commandline conf: use virDomainChrSourceDef to save the path conf:audit: introduce audit function for shared memory device conf: Add helpers to insert/remove/find shmem devices in domain def qemu: Implement shared memory device cold (un)plug qemu: Implement share memory device hot-plug qemu: Implement shared memory device hot-unplug qemu: report error when shmem have a invalid address docs/auditlog.html.in | 16 +++ src/conf/domain_audit.c | 16 +++ src/conf/domain_audit.h | 6 + src/conf/domain_conf.c | 69 ++++++++++- src/conf/domain_conf.h | 9 +- src/libvirt_private.syms | 5 + src/qemu/qemu_command.c | 82 +++++++------ src/qemu/qemu_command.h | 7 ++ src/qemu/qemu_driver.c | 35 +++++- src/qemu/qemu_hotplug.c | 156 ++++++++++++++++++++++++- src/qemu/qemu_hotplug.h | 6 + tests/qemuxml2argvdata/qemuxml2argv-shmem.args | 16 +-- 12 files changed, 372 insertions(+), 51 deletions(-) -- 1.8.3.1

3 30

[libvirt] [PATCH] qemu: fix no error settings if fail to find a disk match path
by Luyao Huang 09 Jul '15

09 Jul '15

When we use get blockjob info to a unexist disk path, we will get a error like this: # virsh blockjob r7 vdc error: An error occurred, but the cause is unknown This is because we do not set the error when jump to endjob. As virDomainDiskByName won't set the error, we need set them in the callers function. Signed-off-by: Luyao Huang <lhuang(a)redhat.com> --- src/qemu/qemu_driver.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 900740e..f134248 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -16414,8 +16414,11 @@ qemuDomainGetBlockJobInfo(virDomainPtr dom, if (qemuDomainSupportsBlockJobs(vm, NULL) < 0) goto endjob; - if (!(disk = virDomainDiskByName(vm->def, path, true))) + if (!(disk = virDomainDiskByName(vm->def, path, true))) { + virReportError(VIR_ERR_INVALID_ARG, + _("invalid path %s not assigned to domain"), path); goto endjob; + } qemuDomainObjEnterMonitor(driver, vm); ret = qemuMonitorGetBlockJobInfo(qemuDomainGetMonitor(vm), -- 1.8.3.1

3 3

[libvirt] [PATCH] libxl: rework setting the state of virDomainObj
by Jim Fehlig 08 Jul '15

08 Jul '15

Set the state of virDomainObj in the functions that actually change the domain state, instead of the generic libxlDomainCleanup function. This approach gives functions calling libxlDomainCleanup more flexibility wrt when and how they change virDomainObj state via virDomainObjSetState. The prior approach of calling virDomainObjSetState in libxlDomainCleanup resulted in the following incorrect coding pattern in the various functions that change domain state libxlDomain<DoStateTransition> call libxl function to do state transition emit lifecycle event libxlDomainCleanup virDomainObjSetState Once simple manifestation of this bug is seeing a domain running in virt-manager after selecting the shutdown button, even after the domain has long shutdown. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- I considered emitting the lifecycle event in libxlDomainCleanup, but IMO it is best to change the state and emit the event where where the state change actually occurs. src/libxl/libxl_domain.c | 23 ++++++++++++----------- src/libxl/libxl_domain.h | 3 +-- src/libxl/libxl_driver.c | 28 ++++++++++++++++++---------- src/libxl/libxl_migration.c | 8 ++++++-- 4 files changed, 37 insertions(+), 25 deletions(-) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index 8e8a292..224ff77 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -397,7 +397,6 @@ libxlDomainShutdownThread(void *opaque) libxlDriverPrivatePtr driver = shutdown_info->driver; virObjectEventPtr dom_event = NULL; libxl_shutdown_reason xl_reason = ev->u.domain_shutdown.shutdown_reason; - virDomainShutoffReason reason = VIR_DOMAIN_SHUTOFF_SHUTDOWN; libxlDriverConfigPtr cfg; cfg = libxlDriverConfigGet(driver); @@ -406,12 +405,14 @@ libxlDomainShutdownThread(void *opaque) goto cleanup; if (xl_reason == LIBXL_SHUTDOWN_REASON_POWEROFF) { + virDomainObjSetState(vm, VIR_DOMAIN_SHUTOFF, + VIR_DOMAIN_SHUTOFF_SHUTDOWN); + dom_event = virDomainEventLifecycleNewFromObj(vm, VIR_DOMAIN_EVENT_STOPPED, VIR_DOMAIN_EVENT_STOPPED_SHUTDOWN); switch ((virDomainLifecycleAction) vm->def->onPoweroff) { case VIR_DOMAIN_LIFECYCLE_DESTROY: - reason = VIR_DOMAIN_SHUTOFF_SHUTDOWN; goto destroy; case VIR_DOMAIN_LIFECYCLE_RESTART: case VIR_DOMAIN_LIFECYCLE_RESTART_RENAME: @@ -421,12 +422,14 @@ libxlDomainShutdownThread(void *opaque) goto endjob; } } else if (xl_reason == LIBXL_SHUTDOWN_REASON_CRASH) { + virDomainObjSetState(vm, VIR_DOMAIN_SHUTOFF, + VIR_DOMAIN_SHUTOFF_CRASHED); + dom_event = virDomainEventLifecycleNewFromObj(vm, VIR_DOMAIN_EVENT_STOPPED, VIR_DOMAIN_EVENT_STOPPED_CRASHED); switch ((virDomainLifecycleCrashAction) vm->def->onCrash) { case VIR_DOMAIN_LIFECYCLE_CRASH_DESTROY: - reason = VIR_DOMAIN_SHUTOFF_CRASHED; goto destroy; case VIR_DOMAIN_LIFECYCLE_CRASH_RESTART: case VIR_DOMAIN_LIFECYCLE_CRASH_RESTART_RENAME: @@ -442,12 +445,14 @@ libxlDomainShutdownThread(void *opaque) goto restart; } } else if (xl_reason == LIBXL_SHUTDOWN_REASON_REBOOT) { + virDomainObjSetState(vm, VIR_DOMAIN_SHUTOFF, + VIR_DOMAIN_SHUTOFF_SHUTDOWN); + dom_event = virDomainEventLifecycleNewFromObj(vm, VIR_DOMAIN_EVENT_STOPPED, VIR_DOMAIN_EVENT_STOPPED_SHUTDOWN); switch ((virDomainLifecycleAction) vm->def->onReboot) { case VIR_DOMAIN_LIFECYCLE_DESTROY: - reason = VIR_DOMAIN_SHUTOFF_SHUTDOWN; goto destroy; case VIR_DOMAIN_LIFECYCLE_RESTART: case VIR_DOMAIN_LIFECYCLE_RESTART_RENAME: @@ -467,7 +472,7 @@ libxlDomainShutdownThread(void *opaque) dom_event = NULL; } libxlDomainDestroyInternal(driver, vm); - libxlDomainCleanup(driver, vm, reason); + libxlDomainCleanup(driver, vm); if (!vm->persistent) virDomainObjListRemove(driver->domains, vm); @@ -479,7 +484,7 @@ libxlDomainShutdownThread(void *opaque) dom_event = NULL; } libxlDomainDestroyInternal(driver, vm); - libxlDomainCleanup(driver, vm, VIR_DOMAIN_SHUTOFF_SHUTDOWN); + libxlDomainCleanup(driver, vm); if (libxlDomainStart(driver, vm, false, -1) < 0) { virErrorPtr err = virGetLastError(); VIR_ERROR(_("Failed to restart VM '%s': %s"), @@ -685,8 +690,7 @@ libxlDomainDestroyInternal(libxlDriverPrivatePtr driver, */ void libxlDomainCleanup(libxlDriverPrivatePtr driver, - virDomainObjPtr vm, - virDomainShutoffReason reason) + virDomainObjPtr vm) { libxlDomainObjPrivatePtr priv = vm->privateData; libxlDriverConfigPtr cfg = libxlDriverConfigGet(driver); @@ -709,9 +713,6 @@ libxlDomainCleanup(libxlDriverPrivatePtr driver, priv->deathW = NULL; } - if (vm->persistent) - virDomainObjSetState(vm, VIR_DOMAIN_SHUTOFF, reason); - if (virAtomicIntDecAndTest(&driver->nactive) && driver->inhibitCallback) driver->inhibitCallback(false, driver->inhibitOpaque); diff --git a/src/libxl/libxl_domain.h b/src/libxl/libxl_domain.h index 8c73cc4..44b3e0b 100644 --- a/src/libxl/libxl_domain.h +++ b/src/libxl/libxl_domain.h @@ -110,8 +110,7 @@ libxlDomainDestroyInternal(libxlDriverPrivatePtr driver, void libxlDomainCleanup(libxlDriverPrivatePtr driver, - virDomainObjPtr vm, - virDomainShutoffReason reason); + virDomainObjPtr vm); /* * Note: Xen 4.3 removed the const from the event handler signature. diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 149ef70..50861ac 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -383,7 +383,7 @@ libxlReconnectDomain(virDomainObjPtr vm, return 0; out: - libxlDomainCleanup(driver, vm, VIR_DOMAIN_SHUTOFF_UNKNOWN); + libxlDomainCleanup(driver, vm); if (!vm->persistent) virDomainObjListRemoveLocked(driver->domains, vm); else @@ -1266,16 +1266,19 @@ libxlDomainDestroyFlags(virDomainPtr dom, goto endjob; } + if (libxlDomainDestroyInternal(driver, vm) < 0) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Failed to destroy domain '%d'"), vm->def->id); + goto endjob; + } + + virDomainObjSetState(vm, VIR_DOMAIN_SHUTOFF, + VIR_DOMAIN_SHUTOFF_DESTROYED); + event = virDomainEventLifecycleNewFromObj(vm, VIR_DOMAIN_EVENT_STOPPED, VIR_DOMAIN_EVENT_STOPPED_DESTROYED); - if (libxlDomainDestroyInternal(driver, vm) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Failed to destroy domain '%d'"), vm->def->id); - goto endjob; - } - - libxlDomainCleanup(driver, vm, VIR_DOMAIN_SHUTOFF_DESTROYED); + libxlDomainCleanup(driver, vm); if (!vm->persistent) virDomainObjListRemove(driver->domains, vm); @@ -1609,6 +1612,9 @@ libxlDoDomainSave(libxlDriverPrivatePtr driver, virDomainObjPtr vm, goto cleanup; } + virDomainObjSetState(vm, VIR_DOMAIN_SHUTOFF, + VIR_DOMAIN_SHUTOFF_SAVED); + event = virDomainEventLifecycleNewFromObj(vm, VIR_DOMAIN_EVENT_STOPPED, VIR_DOMAIN_EVENT_STOPPED_SAVED); @@ -1618,7 +1624,7 @@ libxlDoDomainSave(libxlDriverPrivatePtr driver, virDomainObjPtr vm, goto cleanup; } - libxlDomainCleanup(driver, vm, VIR_DOMAIN_SHUTOFF_SAVED); + libxlDomainCleanup(driver, vm); vm->hasManagedSave = true; ret = 0; @@ -1825,7 +1831,9 @@ libxlDomainCoreDump(virDomainPtr dom, const char *to, unsigned int flags) goto unpause; } - libxlDomainCleanup(driver, vm, VIR_DOMAIN_SHUTOFF_CRASHED); + libxlDomainCleanup(driver, vm); + virDomainObjSetState(vm, VIR_DOMAIN_SHUTOFF, + VIR_DOMAIN_SHUTOFF_CRASHED); event = virDomainEventLifecycleNewFromObj(vm, VIR_DOMAIN_EVENT_STOPPED, VIR_DOMAIN_EVENT_STOPPED_CRASHED); if (!vm->persistent) diff --git a/src/libxl/libxl_migration.c b/src/libxl/libxl_migration.c index 39e4a65..aa9547b 100644 --- a/src/libxl/libxl_migration.c +++ b/src/libxl/libxl_migration.c @@ -585,7 +585,9 @@ libxlDomainMigrationFinish(virConnectPtr dconn, cleanup: if (dom == NULL) { libxlDomainDestroyInternal(driver, vm); - libxlDomainCleanup(driver, vm, VIR_DOMAIN_SHUTOFF_FAILED); + libxlDomainCleanup(driver, vm); + virDomainObjSetState(vm, VIR_DOMAIN_SHUTOFF, + VIR_DOMAIN_SHUTOFF_FAILED); event = virDomainEventLifecycleNewFromObj(vm, VIR_DOMAIN_EVENT_STOPPED, VIR_DOMAIN_EVENT_STOPPED_FAILED); if (!vm->persistent) @@ -624,7 +626,9 @@ libxlDomainMigrationConfirm(libxlDriverPrivatePtr driver, } libxlDomainDestroyInternal(driver, vm); - libxlDomainCleanup(driver, vm, VIR_DOMAIN_SHUTOFF_MIGRATED); + libxlDomainCleanup(driver, vm); + virDomainObjSetState(vm, VIR_DOMAIN_SHUTOFF, + VIR_DOMAIN_SHUTOFF_MIGRATED); event = virDomainEventLifecycleNewFromObj(vm, VIR_DOMAIN_EVENT_STOPPED, VIR_DOMAIN_EVENT_STOPPED_MIGRATED); -- 2.1.4

2 2

[libvirt] [PATCH] libxl: support dom0
by Jim Fehlig 08 Jul '15

08 Jul '15

In Xen, dom0 is really just another domain that supports ballooning, adding/removing devices, changing vcpu configuration, etc. This patch adds support to the libxl driver for managing dom0. Note that the legacy xend driver has long supported managing dom0. Operations that are not supported on dom0 are filtered in libvirt where a sensible error is reported. Errors from libxl are not always helpful. E.g., attempting a save on dom0 results in 2015-06-23 15:25:05 MDT libxl: debug: libxl_dom.c:1570:libxl__toolstack_save: domain=0 toolstack data size=8 2015-06-23 15:25:05 MDT libxl: debug: libxl.c:979:do_libxl_domain_suspend: ao 0x7f7e68000b70: inprogress: poller=0x7f7e68000930, flags=i 2015-06-23 15:25:05 MDT libxl-save-helper: debug: starting save: Success 2015-06-23 15:25:05 MDT xc: detail: xc_domain_save_suse: starting save of domid 0 2015-06-23 15:25:05 MDT xc: error: Couldn't map live_shinfo (3 = No such process): Internal error 2015-06-23 15:25:05 MDT xc: detail: Save exit of domid 0 with errno=3 2015-06-23 15:25:05 MDT libxl-save-helper: debug: complete r=1: No such process 2015-06-23 15:25:05 MDT libxl: error: libxl_dom.c:1876:libxl__xc_domain_save_done: saving domain: domain did not respond to suspend request: No such process 2015-06-23 15:25:05 MDT libxl: error: libxl_dom.c:2033:remus_teardown_done: Remus: failed to teardown device for guest with domid 0, rc -8 Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- src/libxl/libxl_driver.c | 95 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 95 insertions(+) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 149ef70..d0b76ac 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -79,6 +79,15 @@ VIR_LOG_INIT("libxl.libxl_driver"); /* Number of Xen scheduler parameters */ #define XEN_SCHED_CREDIT_NPARAM 2 +#define LIBXL_CHECK_DOM0_GOTO(name, label) \ + do { \ + if (STREQ_NULLABLE(name, "Domain-0")) { \ + virReportError(VIR_ERR_OPERATION_INVALID, "%s", \ + _("Domain-0 does not support requested operation")); \ + goto label; \ + } \ + } while (0) + static libxlDriverPrivatePtr libxl_driver; @@ -501,6 +510,62 @@ const struct libxl_event_hooks ev_hooks = { }; static int +libxlAddDom0(libxlDriverPrivatePtr driver) +{ + libxlDriverConfigPtr cfg = libxlDriverConfigGet(driver); + virDomainDefPtr def = NULL; + virDomainObjPtr vm = NULL; + virDomainDefPtr oldDef = NULL; + libxl_dominfo d_info; + int ret = -1; + + libxl_dominfo_init(&d_info); + + /* Ensure we have a dom0 */ + if (libxl_domain_info(cfg->ctx, &d_info, 0) != 0) { + virReportError(VIR_ERR_INTERNAL_ERROR, + "%s", _("unable to get Domain-0 information from libxenlight")); + goto cleanup; + } + + if (!(def = virDomainDefNew())) + goto cleanup; + + def->id = 0; + def->virtType = VIR_DOMAIN_VIRT_XEN; + if (VIR_STRDUP(def->name, "Domain-0") < 0) + goto cleanup; + + def->os.type = VIR_DOMAIN_OSTYPE_XEN; + + if (virUUIDParse("00000000-0000-0000-0000-000000000000", def->uuid) < 0) + goto cleanup; + + vm->def->vcpus = d_info.vcpu_online; + vm->def->maxvcpus = d_info.vcpu_max_id + 1; + vm->def->mem.cur_balloon = d_info.current_memkb; + vm->def->mem.max_balloon = d_info.max_memkb; + + if (!(vm = virDomainObjListAdd(driver->domains, def, + driver->xmlopt, + 0, + &oldDef))) + goto cleanup; + + def = NULL; + ret = 0; + + cleanup: + libxl_dominfo_dispose(&d_info); + virDomainDefFree(def); + virDomainDefFree(oldDef); + if (vm) + virObjectUnlock(vm); + virObjectUnref(cfg); + return ret; +} + +static int libxlStateInitialize(bool privileged, virStateInhibitCallback callback ATTRIBUTE_UNUSED, void *opaque ATTRIBUTE_UNUSED) @@ -616,6 +681,10 @@ libxlStateInitialize(bool privileged, if (!(libxl_driver->xmlopt = libxlCreateXMLConf())) goto error; + /* Add Domain-0 */ + if (libxlAddDom0(libxl_driver) < 0) + goto error; + /* Load running domains first. */ if (virDomainObjListLoadAllConfigs(libxl_driver->domains, cfg->stateDir, @@ -1030,6 +1099,8 @@ libxlDomainSuspend(virDomainPtr dom) if (!(vm = libxlDomObjFromDomain(dom))) goto cleanup; + LIBXL_CHECK_DOM0_GOTO(vm->def->name, cleanup); + if (virDomainSuspendEnsureACL(dom->conn, vm->def) < 0) goto cleanup; @@ -1086,6 +1157,8 @@ libxlDomainResume(virDomainPtr dom) if (!(vm = libxlDomObjFromDomain(dom))) goto cleanup; + LIBXL_CHECK_DOM0_GOTO(vm->def->name, cleanup); + if (virDomainResumeEnsureACL(dom->conn, vm->def) < 0) goto cleanup; @@ -1147,6 +1220,8 @@ libxlDomainShutdownFlags(virDomainPtr dom, unsigned int flags) if (!(vm = libxlDomObjFromDomain(dom))) goto cleanup; + LIBXL_CHECK_DOM0_GOTO(vm->def->name, cleanup); + if (virDomainShutdownFlagsEnsureACL(dom->conn, vm->def, flags) < 0) goto cleanup; @@ -1212,6 +1287,8 @@ libxlDomainReboot(virDomainPtr dom, unsigned int flags) if (!(vm = libxlDomObjFromDomain(dom))) goto cleanup; + LIBXL_CHECK_DOM0_GOTO(vm->def->name, cleanup); + if (virDomainRebootEnsureACL(dom->conn, vm->def, flags) < 0) goto cleanup; @@ -1254,6 +1331,8 @@ libxlDomainDestroyFlags(virDomainPtr dom, if (!(vm = libxlDomObjFromDomain(dom))) goto cleanup; + LIBXL_CHECK_DOM0_GOTO(vm->def->name, cleanup); + if (virDomainDestroyFlagsEnsureACL(dom->conn, vm->def) < 0) goto cleanup; @@ -1656,6 +1735,8 @@ libxlDomainSaveFlags(virDomainPtr dom, const char *to, const char *dxml, if (!(vm = libxlDomObjFromDomain(dom))) goto cleanup; + LIBXL_CHECK_DOM0_GOTO(vm->def->name, cleanup); + if (virDomainSaveFlagsEnsureACL(dom->conn, vm->def) < 0) goto cleanup; @@ -1782,6 +1863,8 @@ libxlDomainCoreDump(virDomainPtr dom, const char *to, unsigned int flags) if (!(vm = libxlDomObjFromDomain(dom))) goto cleanup; + LIBXL_CHECK_DOM0_GOTO(vm->def->name, cleanup); + if (virDomainCoreDumpEnsureACL(dom->conn, vm->def) < 0) goto cleanup; @@ -1877,6 +1960,8 @@ libxlDomainManagedSave(virDomainPtr dom, unsigned int flags) if (!(vm = libxlDomObjFromDomain(dom))) goto cleanup; + LIBXL_CHECK_DOM0_GOTO(vm->def->name, cleanup); + if (virDomainManagedSaveEnsureACL(dom->conn, vm->def) < 0) goto cleanup; @@ -4000,6 +4085,8 @@ libxlDomainSetAutostart(virDomainPtr dom, int autostart) if (!(vm = libxlDomObjFromDomain(dom))) goto cleanup; + LIBXL_CHECK_DOM0_GOTO(vm->def->name, cleanup); + if (virDomainSetAutostartEnsureACL(dom->conn, vm->def) < 0) goto cleanup; @@ -4294,6 +4381,8 @@ libxlDomainOpenConsole(virDomainPtr dom, if (!(vm = libxlDomObjFromDomain(dom))) goto cleanup; + LIBXL_CHECK_DOM0_GOTO(vm->def->name, cleanup); + if (virDomainOpenConsoleEnsureACL(dom->conn, vm->def) < 0) goto cleanup; @@ -4817,6 +4906,12 @@ libxlDomainMigrateBegin3Params(virDomainPtr domain, if (!(vm = libxlDomObjFromDomain(domain))) return NULL; + if (STREQ_NULLABLE(vm->def->name, "Domain-0")) { + virReportError(VIR_ERR_OPERATION_INVALID, "%s", + _("Domain-0 cannot be migrated")); + return NULL; + } + if (virDomainMigrateBegin3ParamsEnsureACL(domain->conn, vm->def) < 0) { virObjectUnlock(vm); return NULL; -- 2.1.4

2 3

[libvirt] [PATCH v2 0/4] virt-aa-helper fixes
by Cédric Bosdonnat 08 Jul '15

08 Jul '15

This patch series includes a new version for the trailing slash fix, but also includes other fixes to get virt-sandbox run nicely with apparmor. Thus only one patch has v2 ;) Cédric Bosdonnat (4): virt-aa-helper: fix rules for paths with trailing slash Get more libvirt errors from virt-aa-helper virt-aa-helper: rename ctl->hvm to ctl->os virt-aa-helper: add DomainGuest to mockup caps src/security/security_apparmor.c | 4 ++++ src/security/virt-aa-helper.c | 38 ++++++++++++++++++++++++++++++++++---- tests/virt-aa-helper-test | 3 --- 3 files changed, 38 insertions(+), 7 deletions(-) -- 2.1.4

3 6

[libvirt] [[PATCH v5] autocreate tap device for VIR_DOMAIN_NET_TYPE_ETHERNET] autocreate tap device for VIR_DOMAIN_NET_TYPE_ETHERNET
by Vasiliy Tolstov 08 Jul '15

08 Jul '15

If a user specify ehernet device create it via libvirt and run script if it provided. After this commit user does not need to run external script to create tap device or add root to qemu process. Signed-off-by: Vasiliy Tolstov <v.tolstov(a)selfip.ru> --- src/qemu/qemu_command.c | 139 ++++++++++++++++++++++++++++++------------------ src/qemu/qemu_hotplug.c | 13 ++--- src/qemu/qemu_process.c | 6 +++ 3 files changed, 98 insertions(+), 60 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 3886b4f..f9008e4 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -332,10 +332,39 @@ static int qemuCreateInBridgePortWithHelper(virQEMUDriverConfigPtr cfg, return *tapfd < 0 ? -1 : 0; } +/** + * qemuExecuteEthernetScript: + * @ifname: the interface name + * @script: the script name + * + * This function executes script for new tap device created by libvirt. + * Returns 0 in case of success or -1 on failure + */ +static int +qemuExecuteEthernetScript(const char *ifname, const char *script) +{ + virCommandPtr cmd; + int ret; + + cmd = virCommandNew(script); + virCommandAddArgFormat(cmd, "%s", ifname); + virCommandClearCaps(cmd); +#ifdef CAP_NET_ADMIN + virCommandAllowCap(cmd, CAP_NET_ADMIN); +#endif + virCommandAddEnvPassCommon(cmd); + + ret = virCommandRun(cmd, NULL); + + virCommandFree(cmd); + return ret; +} + /* qemuNetworkIfaceConnect - *only* called if actualType is - * VIR_DOMAIN_NET_TYPE_NETWORK or VIR_DOMAIN_NET_TYPE_BRIDGE (i.e. if - * the connection is made with a tap device connecting to a bridge - * device) + * VIR_DOMAIN_NET_TYPE_NETWORK, VIR_DOMAIN_NET_TYPE_BRIDGE + * VIR_DOMAIN_NET_TYPE_ETHERNET (i.e. if the connection is + * made with a tap device connecting to a bridge device or + * use plain tap device) */ int qemuNetworkIfaceConnect(virDomainDefPtr def, @@ -351,6 +380,7 @@ qemuNetworkIfaceConnect(virDomainDefPtr def, bool template_ifname = false; virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver); const char *tunpath = "/dev/net/tun"; + virMacAddr tapmac; if (net->backend.tap) { tunpath = net->backend.tap; @@ -361,11 +391,6 @@ qemuNetworkIfaceConnect(virDomainDefPtr def, } } - if (!(brname = virDomainNetGetActualBridgeName(net))) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Missing bridge name")); - goto cleanup; - } - if (!net->ifname || STRPREFIX(net->ifname, VIR_NET_GENERATED_PREFIX) || strchr(net->ifname, '%')) { @@ -381,40 +406,62 @@ qemuNetworkIfaceConnect(virDomainDefPtr def, tap_create_flags |= VIR_NETDEV_TAP_CREATE_VNET_HDR; } - if (cfg->privileged) { - if (virNetDevTapCreateInBridgePort(brname, &net->ifname, &net->mac, - def->uuid, tunpath, tapfd, *tapfdSize, - virDomainNetGetActualVirtPortProfile(net), - virDomainNetGetActualVlan(net), - tap_create_flags) < 0) { + if (virDomainNetGetActualType(net) == VIR_DOMAIN_NET_TYPE_ETHERNET) { + if (virNetDevTapCreate(&net->ifname, tunpath, tapfd, *tapfdSize, + tap_create_flags) < 0) { virDomainAuditNetDevice(def, net, tunpath, false); goto cleanup; } - if (virDomainNetGetActualBridgeMACTableManager(net) - == VIR_NETWORK_BRIDGE_MAC_TABLE_MANAGER_LIBVIRT) { - /* libvirt is managing the FDB of the bridge this device - * is attaching to, so we need to turn off learning and - * unicast_flood on the device to prevent the kernel from - * adding any FDB entries for it. We will add add an fdb - * entry ourselves (during qemuInterfaceStartDevices(), - * using the MAC address from the interface config. - */ - if (virNetDevBridgePortSetLearning(brname, net->ifname, false) < 0) - goto cleanup; - if (virNetDevBridgePortSetUnicastFlood(brname, net->ifname, false) < 0) + virMacAddrSet(&tapmac, &net->mac); + + if (virNetDevSetMAC(net->ifname, &tapmac) < 0) + goto cleanup; + + if (net->script) { + if (qemuExecuteEthernetScript(net->ifname, net->script) < 0) goto cleanup; } } else { - if (qemuCreateInBridgePortWithHelper(cfg, brname, - &net->ifname, - tapfd, tap_create_flags) < 0) { - virDomainAuditNetDevice(def, net, tunpath, false); + if (!(brname = virDomainNetGetActualBridgeName(net))) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Missing bridge name")); goto cleanup; } - /* qemuCreateInBridgePortWithHelper can only create a single FD */ - if (*tapfdSize > 1) { - VIR_WARN("Ignoring multiqueue network request"); - *tapfdSize = 1; + + if (cfg->privileged) { + if (virNetDevTapCreateInBridgePort(brname, &net->ifname, &net->mac, + def->uuid, tunpath, tapfd, *tapfdSize, + virDomainNetGetActualVirtPortProfile(net), + virDomainNetGetActualVlan(net), + tap_create_flags) < 0) { + virDomainAuditNetDevice(def, net, tunpath, false); + goto cleanup; + } + if (virDomainNetGetActualBridgeMACTableManager(net) + == VIR_NETWORK_BRIDGE_MAC_TABLE_MANAGER_LIBVIRT) { + /* libvirt is managing the FDB of the bridge this device + * is attaching to, so we need to turn off learning and + * unicast_flood on the device to prevent the kernel from + * adding any FDB entries for it. We will add add an fdb + * entry ourselves (during qemuInterfaceStartDevices(), + * using the MAC address from the interface config. + */ + if (virNetDevBridgePortSetLearning(brname, net->ifname, false) < 0) + goto cleanup; + if (virNetDevBridgePortSetUnicastFlood(brname, net->ifname, false) < 0) + goto cleanup; + } + } else { + if (qemuCreateInBridgePortWithHelper(cfg, brname, + &net->ifname, + tapfd, tap_create_flags) < 0) { + virDomainAuditNetDevice(def, net, tunpath, false); + goto cleanup; + } + /* qemuCreateInBridgePortWithHelper can only create a single FD */ + if (*tapfdSize > 1) { + VIR_WARN("Ignoring multiqueue network request"); + *tapfdSize = 1; + } } } @@ -5221,6 +5268,7 @@ qemuBuildHostNetStr(virDomainNetDefPtr net, case VIR_DOMAIN_NET_TYPE_BRIDGE: case VIR_DOMAIN_NET_TYPE_NETWORK: case VIR_DOMAIN_NET_TYPE_DIRECT: + case VIR_DOMAIN_NET_TYPE_ETHERNET: virBufferAsprintf(&buf, "tap%c", type_sep); /* for one tapfd 'fd=' shall be used, * for more than one 'fds=' is the right choice */ @@ -5238,20 +5286,6 @@ qemuBuildHostNetStr(virDomainNetDefPtr net, is_tap = true; break; - case VIR_DOMAIN_NET_TYPE_ETHERNET: - virBufferAddLit(&buf, "tap"); - if (net->ifname) { - virBufferAsprintf(&buf, "%cifname=%s", type_sep, net->ifname); - type_sep = ','; - } - if (net->script) { - virBufferAsprintf(&buf, "%cscript=%s", type_sep, - net->script); - type_sep = ','; - } - is_tap = true; - break; - case VIR_DOMAIN_NET_TYPE_CLIENT: virBufferAsprintf(&buf, "socket%cconnect=%s:%d", type_sep, @@ -8226,7 +8260,8 @@ qemuBuildInterfaceCommandLine(virCommandPtr cmd, /* Currently nothing besides TAP devices supports multiqueue. */ if (net->driver.virtio.queues > 0 && !(actualType == VIR_DOMAIN_NET_TYPE_NETWORK || - actualType == VIR_DOMAIN_NET_TYPE_BRIDGE)) { + actualType == VIR_DOMAIN_NET_TYPE_BRIDGE || + actualType == VIR_DOMAIN_NET_TYPE_ETHERNET)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("Multiqueue network is not supported for: %s"), virDomainNetTypeToString(actualType)); @@ -8235,7 +8270,8 @@ qemuBuildInterfaceCommandLine(virCommandPtr cmd, if (net->backend.tap && !(actualType == VIR_DOMAIN_NET_TYPE_NETWORK || - actualType == VIR_DOMAIN_NET_TYPE_BRIDGE)) { + actualType == VIR_DOMAIN_NET_TYPE_BRIDGE || + actualType == VIR_DOMAIN_NET_TYPE_ETHERNET)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("Custom tap device path is not supported for: %s"), virDomainNetTypeToString(actualType)); @@ -8245,7 +8281,8 @@ qemuBuildInterfaceCommandLine(virCommandPtr cmd, cfg = virQEMUDriverGetConfig(driver); if (actualType == VIR_DOMAIN_NET_TYPE_NETWORK || - actualType == VIR_DOMAIN_NET_TYPE_BRIDGE) { + actualType == VIR_DOMAIN_NET_TYPE_BRIDGE || + actualType == VIR_DOMAIN_NET_TYPE_ETHERNET) { tapfdSize = net->driver.virtio.queues; if (!tapfdSize) tapfdSize = 1; diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index cc86a3b..21ea3fd 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -908,7 +908,8 @@ int qemuDomainAttachNetDevice(virConnectPtr conn, /* Currently nothing besides TAP devices supports multiqueue. */ if (net->driver.virtio.queues > 0 && !(actualType == VIR_DOMAIN_NET_TYPE_NETWORK || - actualType == VIR_DOMAIN_NET_TYPE_BRIDGE)) { + actualType == VIR_DOMAIN_NET_TYPE_BRIDGE || + actualType == VIR_DOMAIN_NET_TYPE_ETHERNET)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("Multiqueue network is not supported for: %s"), virDomainNetTypeToString(actualType)); @@ -916,7 +917,8 @@ int qemuDomainAttachNetDevice(virConnectPtr conn, } if (actualType == VIR_DOMAIN_NET_TYPE_BRIDGE || - actualType == VIR_DOMAIN_NET_TYPE_NETWORK) { + actualType == VIR_DOMAIN_NET_TYPE_NETWORK || + actualType == VIR_DOMAIN_NET_TYPE_ETHERNET) { tapfdSize = vhostfdSize = net->driver.virtio.queues; if (!tapfdSize) tapfdSize = vhostfdSize = 1; @@ -947,13 +949,6 @@ int qemuDomainAttachNetDevice(virConnectPtr conn, iface_connected = true; if (qemuOpenVhostNet(vm->def, net, priv->qemuCaps, vhostfd, &vhostfdSize) < 0) goto cleanup; - } else if (actualType == VIR_DOMAIN_NET_TYPE_ETHERNET) { - vhostfdSize = 1; - if (VIR_ALLOC(vhostfd) < 0) - goto cleanup; - *vhostfd = -1; - if (qemuOpenVhostNet(vm->def, net, priv->qemuCaps, vhostfd, &vhostfdSize) < 0) - goto cleanup; } /* Set device online immediately */ diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 64ee049..d866e44 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -5205,6 +5205,12 @@ void qemuProcessStop(virQEMUDriverPtr driver, cfg->stateDir)); VIR_FREE(net->ifname); break; + case VIR_DOMAIN_NET_TYPE_ETHERNET: + if (net->ifname) { + ignore_value(virNetDevTapDelete(net->ifname, net->backend.tap)); + VIR_FREE(net->ifname); + } + break; case VIR_DOMAIN_NET_TYPE_BRIDGE: case VIR_DOMAIN_NET_TYPE_NETWORK: #ifdef VIR_NETDEV_TAP_REQUIRE_MANUAL_CLEANUP -- 2.3.3

2 4

[libvirt] [PATCH v3 0/3] Allow PCI virtio on ARM "virt" machine
by Pavel Fedin 08 Jul '15

08 Jul '15

Virt machine in qemu since v2.3.0 has PCI generic host controller, and can use PCI devices. This provides performance improvement as well as vhost-net with irqfd support for virtio-net. However libvirt currently does not allow ARM virt machine to have PCI devices. This patchset adds the necessary support. This version is completely reworked and uses different approach. Changes since v2: - Correctly model PCI Express bus on the machine. It is now possible to explicitly specify <address-type='pci'> with attributes. This allows to attach not only virtio, but any other PCI device to the model. - Default is not changed and still mmio, for backwards compatibility with existing installations. PCI bus has to be explicitly specified. - Check for the capability in correct place, in v2 it actually did not work Changes since v1: - Added capability based on qemu version number - Recognize also "virt-" prefix Pavel Fedin (3): Introduce QEMU_CAPS_ARM_VIRT_PCI Add PCI-Express root to ARM virt machine Build correct command line for PCI NICs on ARM src/qemu/qemu_capabilities.c | 5 +++++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 3 ++- src/qemu/qemu_domain.c | 12 ++++++++---- 4 files changed, 16 insertions(+), 5 deletions(-) -- 1.9.5.msysgit.0

3 8

[libvirt] [PATCH] vz: use PRL_USE_VNET_NAME_FOR_BRIDGE_NAME
by Maxim Nestratov 08 Jul '15

08 Jul '15

It is better not to assume that newly created network should be connected to a bridge with same name, but specify it explicitly by PRL_USE_VNET_NAME_FOR_BRIDGE_NAME flag. Signed-off-by: Maxim Nestratov <mnestratov(a)virtuozzo.com> --- src/vz/vz_sdk.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index 1b66958..1c56655 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -2834,7 +2834,9 @@ static int prlsdkAddNet(PRL_HANDLE sdkdom, pret = PrlVirtNet_SetNetworkType(vnet, PVN_BRIDGED_ETHERNET); prlsdkCheckRetGoto(pret, cleanup); - job = PrlSrv_AddVirtualNetwork(privconn->server, vnet, 0); + job = PrlSrv_AddVirtualNetwork(privconn->server, + vnet, + PRL_USE_VNET_NAME_FOR_BRIDGE_NAME); if (PRL_FAILED(pret = waitJob(job))) goto cleanup; -- 1.7.1

2 2

[libvirt] [PATCH v2 00/10] Restore code to allow unpriv_sgio for hostdev SCSI generic
by John Ferlan 08 Jul '15

08 Jul '15

v1 here: http://www.redhat.com/archives/libvir-list/2015-June/msg00814.html Changes since v1: - Add doc patch 1 to indicate that this feature may only be supported by certain kernels - Adjust former patch 1 to add call to qemuIsSharedHostdev from qemuSetUnprivSGIO - Insert patches 7 & 8 which essentially refactor qemuSetUnprivSGIO a bit. There should be no functional difference - Patch 9 is now a much slimmer former patch 6 The end result is that 'generically speaking' if any kernel supports setting the unprivileged SGIO feature, then these patches provide the capability to do so. Although as pointed out in the review of v1 only one specific downstream kernel supports the feature, that doesn't mean other distros couldn't add support in the same manner. So rather than just remove all traces from libvirt completely, it seems it would be reasonable to keep the checks in place and if a kernel then decides to add support this code exists to assist. John Ferlan (10): docs: Clarify unprivileged sgio feature for host devices qemu: Introduce qemuIsSharedHostdev qemu: Introduce qemuGetHostdevPath qemu: Refactor qemuCheckSharedDisk to create virCheckUnprivSGIO qemu: Refactor qemuAddSharedHostdev and qemuRemoveSharedHostdev qemu: Extract qemuGetHostdevPath from qemuGetSharedHostdevKey qemu: Refactor qemuSetUnprivSGIO return values qemu: Fix integer/boolean logic in qemuSetUnprivSGIO qemu: Add ability to set sgio values for hostdev qemu: Add check for unpriv sgio for SCSI generic host device docs/formatdomain.html.in | 7 +- src/qemu/qemu_conf.c | 226 ++++++++++++++++++++++++++++++---------------- 2 files changed, 154 insertions(+), 79 deletions(-) -- 2.1.0

2 23

[libvirt] [PATCH v2 0/2] Add support for portable-rpcgen from portablexdr library
by Pavel Fedin 08 Jul '15

08 Jul '15

This patch set allows to build libvirt natively under MinGW/MSYS using portablexdr library. An updated version of portablexdr with fixed bugs is available as part of MSYS2 project. Differences from v1: - Split into two parts - Reflect structure definiton change also in xc_monitor_protocol-structs, fix "make syntax-check" Pavel Fedin (2): Remove explicit enum from protocol structures Add support for portable-rpcgen from portablexdr library configure.ac | 2 +- src/lxc/lxc_monitor_protocol.x | 2 +- src/lxc_monitor_protocol-structs | 2 +- src/rpc/genprotocol.pl | 5 ++++- 4 files changed, 7 insertions(+), 4 deletions(-) -- 1.9.5.msysgit.0

2 3

[libvirt] [PATCH] virt-aa-helper: add unix channels for nserials as well
by Serge Hallyn 08 Jul '15

08 Jul '15

Commit 03d7462d added it for channels, but it is also needed for serials. Add it for serials, parallels, and consoles as well. This solves https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1015154 Signed-off-by: Serge Hallyn <serge.hallyn(a)ubuntu.com> --- src/security/virt-aa-helper.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 13f8a6a..4440552 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -951,8 +951,10 @@ get_files(vahControl * ctl) (ctl->def->serials[i]->source.type == VIR_DOMAIN_CHR_TYPE_PTY || ctl->def->serials[i]->source.type == VIR_DOMAIN_CHR_TYPE_DEV || ctl->def->serials[i]->source.type == VIR_DOMAIN_CHR_TYPE_FILE || + ctl->def->serials[i]->source.type == VIR_DOMAIN_CHR_TYPE_UNIX || ctl->def->serials[i]->source.type == VIR_DOMAIN_CHR_TYPE_PIPE) && - ctl->def->serials[i]->source.data.file.path) + ctl->def->serials[i]->source.data.file.path && + ctl->def->serials[i]->source.data.file.path[0] != '\0') if (vah_add_file_chardev(&buf, ctl->def->serials[i]->source.data.file.path, "rw", @@ -964,8 +966,10 @@ get_files(vahControl * ctl) (ctl->def->consoles[i]->source.type == VIR_DOMAIN_CHR_TYPE_PTY || ctl->def->consoles[i]->source.type == VIR_DOMAIN_CHR_TYPE_DEV || ctl->def->consoles[i]->source.type == VIR_DOMAIN_CHR_TYPE_FILE || + ctl->def->consoles[i]->source.type == VIR_DOMAIN_CHR_TYPE_UNIX || ctl->def->consoles[i]->source.type == VIR_DOMAIN_CHR_TYPE_PIPE) && - ctl->def->consoles[i]->source.data.file.path) + ctl->def->consoles[i]->source.data.file.path && + ctl->def->consoles[i]->source.data.file.path[0] != '\0') if (vah_add_file(&buf, ctl->def->consoles[i]->source.data.file.path, "rw") != 0) goto cleanup; @@ -975,8 +979,10 @@ get_files(vahControl * ctl) (ctl->def->parallels[i]->source.type == VIR_DOMAIN_CHR_TYPE_PTY || ctl->def->parallels[i]->source.type == VIR_DOMAIN_CHR_TYPE_DEV || ctl->def->parallels[i]->source.type == VIR_DOMAIN_CHR_TYPE_FILE || + ctl->def->parallels[i]->source.type == VIR_DOMAIN_CHR_TYPE_UNIX || ctl->def->parallels[i]->source.type == VIR_DOMAIN_CHR_TYPE_PIPE) && - ctl->def->parallels[i]->source.data.file.path) + ctl->def->parallels[i]->source.data.file.path && + ctl->def->parallels[i]->source.data.file.path[0] != '\0') if (vah_add_file_chardev(&buf, ctl->def->parallels[i]->source.data.file.path, "rw", -- 2.1.4

2 1

[libvirt] [PATCH v3 0/2] Fix nodeinfo output on PPC64 KVM hosts
by Andrea Bolognani 08 Jul '15

08 Jul '15

I have reworked the original code quite a bit, while maintaining the same logic and hopefully introducing no bugs of my own :) Notable changes from v2 to v3: * the function to get the number of threads per subcore has been moved to the from virarch.c, which deals with architecture names only and is therefore not the right place to read host configuration, to nodeinfo.c where the rest of this stuff lives; * said function has also been given a shorter name; * the "valid subcore mode" boolean has been removed: threads_per_subcore will be a positive number if subcores should be taken into account, and if that's not the case (x86 host, tainted configuration) it will simply be zero, so now the code needs to keep track of a single variable instead of two; * the test case has been renamed to be more descriptive; * the test data has been cleaned up by removing all cpu/cpu*/node* links, which prevented 'make dist' from working due to recursive linking. I've added a Signed-off-by: tag to each commit and maintained Shivaprasad as commit author; if that's not a proper way to handle authorship information in this situation please let me know. Shivaprasad G Bhat (2): Fix nodeinfo output on PPC64 KVM hosts Add testcase for PPC64 kvm host nodeinfo src/libvirt_private.syms | 1 + src/nodeinfo.c | 140 +++++++++++++++++++-- src/nodeinfo.h | 1 + tests/Makefile.am | 6 + tests/nodeinfodata/linux-ppc64-subcores.cpuinfo | 59 +++++++++ tests/nodeinfodata/linux-ppc64-subcores.expected | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu0/online | 1 + .../linux-subcores/cpu/cpu0/physical_id | 1 + .../linux-subcores/cpu/cpu0/topology/core_id | 1 + .../linux-subcores/cpu/cpu0/topology/core_siblings | 1 + .../cpu/cpu0/topology/core_siblings_list | 1 + .../cpu/cpu0/topology/physical_package_id | 1 + .../cpu/cpu0/topology/thread_siblings | 1 + .../cpu/cpu0/topology/thread_siblings_list | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu1/online | 1 + .../linux-subcores/cpu/cpu1/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu10/online | 1 + .../linux-subcores/cpu/cpu10/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu11/online | 1 + .../linux-subcores/cpu/cpu11/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu12/online | 1 + .../linux-subcores/cpu/cpu12/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu13/online | 1 + .../linux-subcores/cpu/cpu13/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu14/online | 1 + .../linux-subcores/cpu/cpu14/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu15/online | 1 + .../linux-subcores/cpu/cpu15/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu16/online | 1 + .../linux-subcores/cpu/cpu16/physical_id | 1 + .../linux-subcores/cpu/cpu16/topology/core_id | 1 + .../cpu/cpu16/topology/core_siblings | 1 + .../cpu/cpu16/topology/core_siblings_list | 1 + .../cpu/cpu16/topology/physical_package_id | 1 + .../cpu/cpu16/topology/thread_siblings | 1 + .../cpu/cpu16/topology/thread_siblings_list | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu17/online | 1 + .../linux-subcores/cpu/cpu17/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu18/online | 1 + .../linux-subcores/cpu/cpu18/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu19/online | 1 + .../linux-subcores/cpu/cpu19/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu2/online | 1 + .../linux-subcores/cpu/cpu2/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu20/online | 1 + .../linux-subcores/cpu/cpu20/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu21/online | 1 + .../linux-subcores/cpu/cpu21/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu22/online | 1 + .../linux-subcores/cpu/cpu22/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu23/online | 1 + .../linux-subcores/cpu/cpu23/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu24/online | 1 + .../linux-subcores/cpu/cpu24/physical_id | 1 + .../linux-subcores/cpu/cpu24/topology/core_id | 1 + .../cpu/cpu24/topology/core_siblings | 1 + .../cpu/cpu24/topology/core_siblings_list | 1 + .../cpu/cpu24/topology/physical_package_id | 1 + .../cpu/cpu24/topology/thread_siblings | 1 + .../cpu/cpu24/topology/thread_siblings_list | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu25/online | 1 + .../linux-subcores/cpu/cpu25/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu26/online | 1 + .../linux-subcores/cpu/cpu26/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu27/online | 1 + .../linux-subcores/cpu/cpu27/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu28/online | 1 + .../linux-subcores/cpu/cpu28/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu29/online | 1 + .../linux-subcores/cpu/cpu29/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu3/online | 1 + .../linux-subcores/cpu/cpu3/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu30/online | 1 + .../linux-subcores/cpu/cpu30/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu31/online | 1 + .../linux-subcores/cpu/cpu31/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu32/online | 1 + .../linux-subcores/cpu/cpu32/physical_id | 1 + .../linux-subcores/cpu/cpu32/topology/core_id | 1 + .../cpu/cpu32/topology/core_siblings | 1 + .../cpu/cpu32/topology/core_siblings_list | 1 + .../cpu/cpu32/topology/physical_package_id | 1 + .../cpu/cpu32/topology/thread_siblings | 1 + .../cpu/cpu32/topology/thread_siblings_list | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu33/online | 1 + .../linux-subcores/cpu/cpu33/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu34/online | 1 + .../linux-subcores/cpu/cpu34/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu35/online | 1 + .../linux-subcores/cpu/cpu35/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu36/online | 1 + .../linux-subcores/cpu/cpu36/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu37/online | 1 + .../linux-subcores/cpu/cpu37/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu38/online | 1 + .../linux-subcores/cpu/cpu38/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu39/online | 1 + .../linux-subcores/cpu/cpu39/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu4/online | 1 + .../linux-subcores/cpu/cpu4/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu40/online | 1 + .../linux-subcores/cpu/cpu40/physical_id | 1 + .../linux-subcores/cpu/cpu40/topology/core_id | 1 + .../cpu/cpu40/topology/core_siblings | 1 + .../cpu/cpu40/topology/core_siblings_list | 1 + .../cpu/cpu40/topology/physical_package_id | 1 + .../cpu/cpu40/topology/thread_siblings | 1 + .../cpu/cpu40/topology/thread_siblings_list | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu41/online | 1 + .../linux-subcores/cpu/cpu41/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu42/online | 1 + .../linux-subcores/cpu/cpu42/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu43/online | 1 + .../linux-subcores/cpu/cpu43/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu44/online | 1 + .../linux-subcores/cpu/cpu44/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu45/online | 1 + .../linux-subcores/cpu/cpu45/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu46/online | 1 + .../linux-subcores/cpu/cpu46/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu47/online | 1 + .../linux-subcores/cpu/cpu47/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu48/online | 1 + .../linux-subcores/cpu/cpu48/physical_id | 1 + .../linux-subcores/cpu/cpu48/topology/core_id | 1 + .../cpu/cpu48/topology/core_siblings | 1 + .../cpu/cpu48/topology/core_siblings_list | 1 + .../cpu/cpu48/topology/physical_package_id | 1 + .../cpu/cpu48/topology/thread_siblings | 1 + .../cpu/cpu48/topology/thread_siblings_list | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu49/online | 1 + .../linux-subcores/cpu/cpu49/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu5/online | 1 + .../linux-subcores/cpu/cpu5/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu50/online | 1 + .../linux-subcores/cpu/cpu50/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu51/online | 1 + .../linux-subcores/cpu/cpu51/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu52/online | 1 + .../linux-subcores/cpu/cpu52/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu53/online | 1 + .../linux-subcores/cpu/cpu53/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu54/online | 1 + .../linux-subcores/cpu/cpu54/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu55/online | 1 + .../linux-subcores/cpu/cpu55/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu56/online | 1 + .../linux-subcores/cpu/cpu56/physical_id | 1 + .../linux-subcores/cpu/cpu56/topology/core_id | 1 + .../cpu/cpu56/topology/core_siblings | 1 + .../cpu/cpu56/topology/core_siblings_list | 1 + .../cpu/cpu56/topology/physical_package_id | 1 + .../cpu/cpu56/topology/thread_siblings | 1 + .../cpu/cpu56/topology/thread_siblings_list | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu57/online | 1 + .../linux-subcores/cpu/cpu57/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu58/online | 1 + .../linux-subcores/cpu/cpu58/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu59/online | 1 + .../linux-subcores/cpu/cpu59/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu6/online | 1 + .../linux-subcores/cpu/cpu6/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu60/online | 1 + .../linux-subcores/cpu/cpu60/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu61/online | 1 + .../linux-subcores/cpu/cpu61/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu62/online | 1 + .../linux-subcores/cpu/cpu62/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu63/online | 1 + .../linux-subcores/cpu/cpu63/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu64/online | 1 + .../linux-subcores/cpu/cpu64/physical_id | 1 + .../linux-subcores/cpu/cpu64/topology/core_id | 1 + .../cpu/cpu64/topology/core_siblings | 1 + .../cpu/cpu64/topology/core_siblings_list | 1 + .../cpu/cpu64/topology/physical_package_id | 1 + .../cpu/cpu64/topology/thread_siblings | 1 + .../cpu/cpu64/topology/thread_siblings_list | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu65/online | 1 + .../linux-subcores/cpu/cpu65/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu66/online | 1 + .../linux-subcores/cpu/cpu66/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu67/online | 1 + .../linux-subcores/cpu/cpu67/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu68/online | 1 + .../linux-subcores/cpu/cpu68/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu69/online | 1 + .../linux-subcores/cpu/cpu69/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu7/online | 1 + .../linux-subcores/cpu/cpu7/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu70/online | 1 + .../linux-subcores/cpu/cpu70/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu71/online | 1 + .../linux-subcores/cpu/cpu71/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu72/online | 1 + .../linux-subcores/cpu/cpu72/physical_id | 1 + .../linux-subcores/cpu/cpu72/topology/core_id | 1 + .../cpu/cpu72/topology/core_siblings | 1 + .../cpu/cpu72/topology/core_siblings_list | 1 + .../cpu/cpu72/topology/physical_package_id | 1 + .../cpu/cpu72/topology/thread_siblings | 1 + .../cpu/cpu72/topology/thread_siblings_list | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu73/online | 1 + .../linux-subcores/cpu/cpu73/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu74/online | 1 + .../linux-subcores/cpu/cpu74/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu75/online | 1 + .../linux-subcores/cpu/cpu75/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu76/online | 1 + .../linux-subcores/cpu/cpu76/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu77/online | 1 + .../linux-subcores/cpu/cpu77/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu78/online | 1 + .../linux-subcores/cpu/cpu78/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu79/online | 1 + .../linux-subcores/cpu/cpu79/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu8/online | 1 + .../linux-subcores/cpu/cpu8/physical_id | 1 + .../linux-subcores/cpu/cpu8/topology/core_id | 1 + .../linux-subcores/cpu/cpu8/topology/core_siblings | 1 + .../cpu/cpu8/topology/core_siblings_list | 1 + .../cpu/cpu8/topology/physical_package_id | 1 + .../cpu/cpu8/topology/thread_siblings | 1 + .../cpu/cpu8/topology/thread_siblings_list | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu80/online | 1 + .../linux-subcores/cpu/cpu80/physical_id | 1 + .../linux-subcores/cpu/cpu80/topology/core_id | 1 + .../cpu/cpu80/topology/core_siblings | 1 + .../cpu/cpu80/topology/core_siblings_list | 1 + .../cpu/cpu80/topology/physical_package_id | 1 + .../cpu/cpu80/topology/thread_siblings | 1 + .../cpu/cpu80/topology/thread_siblings_list | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu81/online | 1 + .../linux-subcores/cpu/cpu81/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu82/online | 1 + .../linux-subcores/cpu/cpu82/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu83/online | 1 + .../linux-subcores/cpu/cpu83/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu84/online | 1 + .../linux-subcores/cpu/cpu84/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu85/online | 1 + .../linux-subcores/cpu/cpu85/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu86/online | 1 + .../linux-subcores/cpu/cpu86/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu87/online | 1 + .../linux-subcores/cpu/cpu87/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu88/online | 1 + .../linux-subcores/cpu/cpu88/physical_id | 1 + .../linux-subcores/cpu/cpu88/topology/core_id | 1 + .../cpu/cpu88/topology/core_siblings | 1 + .../cpu/cpu88/topology/core_siblings_list | 1 + .../cpu/cpu88/topology/physical_package_id | 1 + .../cpu/cpu88/topology/thread_siblings | 1 + .../cpu/cpu88/topology/thread_siblings_list | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu89/online | 1 + .../linux-subcores/cpu/cpu89/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu9/online | 1 + .../linux-subcores/cpu/cpu9/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu90/online | 1 + .../linux-subcores/cpu/cpu90/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu91/online | 1 + .../linux-subcores/cpu/cpu91/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu92/online | 1 + .../linux-subcores/cpu/cpu92/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu93/online | 1 + .../linux-subcores/cpu/cpu93/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu94/online | 1 + .../linux-subcores/cpu/cpu94/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/cpu95/online | 1 + .../linux-subcores/cpu/cpu95/physical_id | 1 + tests/nodeinfodata/linux-subcores/cpu/dscr_default | 1 + tests/nodeinfodata/linux-subcores/cpu/kernel_max | 1 + tests/nodeinfodata/linux-subcores/cpu/offline | 1 + tests/nodeinfodata/linux-subcores/cpu/online | 1 + tests/nodeinfodata/linux-subcores/cpu/possible | 1 + tests/nodeinfodata/linux-subcores/cpu/present | 1 + .../linux-subcores/cpu/subcores_per_core | 1 + tests/nodeinfodata/linux-subcores/node/node0/cpu0 | 1 + tests/nodeinfodata/linux-subcores/node/node0/cpu1 | 1 + tests/nodeinfodata/linux-subcores/node/node0/cpu10 | 1 + tests/nodeinfodata/linux-subcores/node/node0/cpu11 | 1 + tests/nodeinfodata/linux-subcores/node/node0/cpu12 | 1 + tests/nodeinfodata/linux-subcores/node/node0/cpu13 | 1 + tests/nodeinfodata/linux-subcores/node/node0/cpu14 | 1 + tests/nodeinfodata/linux-subcores/node/node0/cpu15 | 1 + tests/nodeinfodata/linux-subcores/node/node0/cpu16 | 1 + tests/nodeinfodata/linux-subcores/node/node0/cpu17 | 1 + tests/nodeinfodata/linux-subcores/node/node0/cpu18 | 1 + tests/nodeinfodata/linux-subcores/node/node0/cpu19 | 1 + tests/nodeinfodata/linux-subcores/node/node0/cpu2 | 1 + tests/nodeinfodata/linux-subcores/node/node0/cpu20 | 1 + tests/nodeinfodata/linux-subcores/node/node0/cpu21 | 1 + tests/nodeinfodata/linux-subcores/node/node0/cpu22 | 1 + tests/nodeinfodata/linux-subcores/node/node0/cpu23 | 1 + tests/nodeinfodata/linux-subcores/node/node0/cpu3 | 1 + tests/nodeinfodata/linux-subcores/node/node0/cpu4 | 1 + tests/nodeinfodata/linux-subcores/node/node0/cpu5 | 1 + tests/nodeinfodata/linux-subcores/node/node0/cpu6 | 1 + tests/nodeinfodata/linux-subcores/node/node0/cpu7 | 1 + tests/nodeinfodata/linux-subcores/node/node0/cpu8 | 1 + tests/nodeinfodata/linux-subcores/node/node0/cpu9 | 1 + .../nodeinfodata/linux-subcores/node/node0/cpulist | 1 + .../nodeinfodata/linux-subcores/node/node0/cpumap | 1 + .../linux-subcores/node/node0/distance | 1 + .../nodeinfodata/linux-subcores/node/node0/meminfo | 29 +++++ .../linux-subcores/node/node0/numastat | 6 + tests/nodeinfodata/linux-subcores/node/node1/cpu24 | 1 + tests/nodeinfodata/linux-subcores/node/node1/cpu25 | 1 + tests/nodeinfodata/linux-subcores/node/node1/cpu26 | 1 + tests/nodeinfodata/linux-subcores/node/node1/cpu27 | 1 + tests/nodeinfodata/linux-subcores/node/node1/cpu28 | 1 + tests/nodeinfodata/linux-subcores/node/node1/cpu29 | 1 + tests/nodeinfodata/linux-subcores/node/node1/cpu30 | 1 + tests/nodeinfodata/linux-subcores/node/node1/cpu31 | 1 + tests/nodeinfodata/linux-subcores/node/node1/cpu32 | 1 + tests/nodeinfodata/linux-subcores/node/node1/cpu33 | 1 + tests/nodeinfodata/linux-subcores/node/node1/cpu34 | 1 + tests/nodeinfodata/linux-subcores/node/node1/cpu35 | 1 + tests/nodeinfodata/linux-subcores/node/node1/cpu36 | 1 + tests/nodeinfodata/linux-subcores/node/node1/cpu37 | 1 + tests/nodeinfodata/linux-subcores/node/node1/cpu38 | 1 + tests/nodeinfodata/linux-subcores/node/node1/cpu39 | 1 + tests/nodeinfodata/linux-subcores/node/node1/cpu40 | 1 + tests/nodeinfodata/linux-subcores/node/node1/cpu41 | 1 + tests/nodeinfodata/linux-subcores/node/node1/cpu42 | 1 + tests/nodeinfodata/linux-subcores/node/node1/cpu43 | 1 + tests/nodeinfodata/linux-subcores/node/node1/cpu44 | 1 + tests/nodeinfodata/linux-subcores/node/node1/cpu45 | 1 + tests/nodeinfodata/linux-subcores/node/node1/cpu46 | 1 + tests/nodeinfodata/linux-subcores/node/node1/cpu47 | 1 + .../nodeinfodata/linux-subcores/node/node1/cpulist | 1 + .../nodeinfodata/linux-subcores/node/node1/cpumap | 1 + .../linux-subcores/node/node1/distance | 1 + .../nodeinfodata/linux-subcores/node/node1/meminfo | 29 +++++ .../linux-subcores/node/node1/numastat | 6 + .../nodeinfodata/linux-subcores/node/node16/cpu48 | 1 + .../nodeinfodata/linux-subcores/node/node16/cpu49 | 1 + .../nodeinfodata/linux-subcores/node/node16/cpu50 | 1 + .../nodeinfodata/linux-subcores/node/node16/cpu51 | 1 + .../nodeinfodata/linux-subcores/node/node16/cpu52 | 1 + .../nodeinfodata/linux-subcores/node/node16/cpu53 | 1 + .../nodeinfodata/linux-subcores/node/node16/cpu54 | 1 + .../nodeinfodata/linux-subcores/node/node16/cpu55 | 1 + .../nodeinfodata/linux-subcores/node/node16/cpu56 | 1 + .../nodeinfodata/linux-subcores/node/node16/cpu57 | 1 + .../nodeinfodata/linux-subcores/node/node16/cpu58 | 1 + .../nodeinfodata/linux-subcores/node/node16/cpu59 | 1 + .../nodeinfodata/linux-subcores/node/node16/cpu60 | 1 + .../nodeinfodata/linux-subcores/node/node16/cpu61 | 1 + .../nodeinfodata/linux-subcores/node/node16/cpu62 | 1 + .../nodeinfodata/linux-subcores/node/node16/cpu63 | 1 + .../nodeinfodata/linux-subcores/node/node16/cpu64 | 1 + .../nodeinfodata/linux-subcores/node/node16/cpu65 | 1 + .../nodeinfodata/linux-subcores/node/node16/cpu66 | 1 + .../nodeinfodata/linux-subcores/node/node16/cpu67 | 1 + .../nodeinfodata/linux-subcores/node/node16/cpu68 | 1 + .../nodeinfodata/linux-subcores/node/node16/cpu69 | 1 + .../nodeinfodata/linux-subcores/node/node16/cpu70 | 1 + .../nodeinfodata/linux-subcores/node/node16/cpu71 | 1 + .../linux-subcores/node/node16/cpulist | 1 + .../nodeinfodata/linux-subcores/node/node16/cpumap | 1 + .../linux-subcores/node/node16/distance | 1 + .../linux-subcores/node/node16/meminfo | 29 +++++ .../linux-subcores/node/node16/numastat | 6 + .../nodeinfodata/linux-subcores/node/node16/uevent | 0 .../nodeinfodata/linux-subcores/node/node16/vmstat | 39 ++++++ .../nodeinfodata/linux-subcores/node/node17/cpu72 | 1 + .../nodeinfodata/linux-subcores/node/node17/cpu73 | 1 + .../nodeinfodata/linux-subcores/node/node17/cpu74 | 1 + .../nodeinfodata/linux-subcores/node/node17/cpu75 | 1 + .../nodeinfodata/linux-subcores/node/node17/cpu76 | 1 + .../nodeinfodata/linux-subcores/node/node17/cpu77 | 1 + .../nodeinfodata/linux-subcores/node/node17/cpu78 | 1 + .../nodeinfodata/linux-subcores/node/node17/cpu79 | 1 + .../nodeinfodata/linux-subcores/node/node17/cpu80 | 1 + .../nodeinfodata/linux-subcores/node/node17/cpu81 | 1 + .../nodeinfodata/linux-subcores/node/node17/cpu82 | 1 + .../nodeinfodata/linux-subcores/node/node17/cpu83 | 1 + .../nodeinfodata/linux-subcores/node/node17/cpu84 | 1 + .../nodeinfodata/linux-subcores/node/node17/cpu85 | 1 + .../nodeinfodata/linux-subcores/node/node17/cpu86 | 1 + .../nodeinfodata/linux-subcores/node/node17/cpu87 | 1 + .../nodeinfodata/linux-subcores/node/node17/cpu88 | 1 + .../nodeinfodata/linux-subcores/node/node17/cpu89 | 1 + .../nodeinfodata/linux-subcores/node/node17/cpu90 | 1 + .../nodeinfodata/linux-subcores/node/node17/cpu91 | 1 + .../nodeinfodata/linux-subcores/node/node17/cpu92 | 1 + .../nodeinfodata/linux-subcores/node/node17/cpu93 | 1 + .../nodeinfodata/linux-subcores/node/node17/cpu94 | 1 + .../nodeinfodata/linux-subcores/node/node17/cpu95 | 1 + .../linux-subcores/node/node17/cpulist | 1 + .../nodeinfodata/linux-subcores/node/node17/cpumap | 1 + .../linux-subcores/node/node17/distance | 1 + .../linux-subcores/node/node17/meminfo | 29 +++++ .../linux-subcores/node/node17/numastat | 6 + .../nodeinfodata/linux-subcores/node/node17/vmstat | 39 ++++++ tests/nodeinfodata/linux-subcores/node/online | 1 + tests/nodeinfodata/linux-subcores/node/possible | 1 + tests/nodeinfomock.c | 35 ++++++ tests/nodeinfotest.c | 3 +- 400 files changed, 831 insertions(+), 14 deletions(-) create mode 100644 tests/nodeinfodata/linux-ppc64-subcores.cpuinfo create mode 100644 tests/nodeinfodata/linux-ppc64-subcores.expected create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu0/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu0/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu0/topology/core_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu0/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu0/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu0/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu0/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu0/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu1/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu1/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu10/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu10/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu11/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu11/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu12/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu12/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu13/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu13/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu14/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu14/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu15/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu15/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu16/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu16/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu16/topology/core_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu16/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu16/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu16/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu16/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu16/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu17/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu17/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu18/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu18/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu19/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu19/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu2/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu2/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu20/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu20/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu21/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu21/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu22/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu22/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu23/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu23/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu24/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu24/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu24/topology/core_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu24/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu24/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu24/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu24/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu24/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu25/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu25/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu26/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu26/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu27/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu27/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu28/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu28/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu29/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu29/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu3/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu3/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu30/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu30/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu31/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu31/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu32/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu32/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu32/topology/core_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu32/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu32/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu32/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu32/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu32/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu33/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu33/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu34/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu34/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu35/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu35/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu36/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu36/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu37/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu37/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu38/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu38/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu39/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu39/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu4/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu4/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu40/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu40/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu40/topology/core_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu40/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu40/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu40/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu40/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu40/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu41/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu41/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu42/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu42/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu43/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu43/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu44/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu44/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu45/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu45/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu46/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu46/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu47/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu47/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu48/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu48/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu48/topology/core_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu48/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu48/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu48/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu48/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu48/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu49/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu49/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu5/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu5/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu50/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu50/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu51/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu51/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu52/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu52/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu53/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu53/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu54/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu54/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu55/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu55/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu56/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu56/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu56/topology/core_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu56/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu56/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu56/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu56/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu56/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu57/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu57/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu58/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu58/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu59/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu59/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu6/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu6/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu60/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu60/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu61/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu61/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu62/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu62/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu63/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu63/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu64/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu64/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu64/topology/core_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu64/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu64/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu64/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu64/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu64/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu65/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu65/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu66/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu66/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu67/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu67/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu68/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu68/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu69/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu69/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu7/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu7/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu70/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu70/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu71/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu71/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu72/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu72/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu72/topology/core_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu72/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu72/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu72/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu72/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu72/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu73/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu73/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu74/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu74/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu75/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu75/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu76/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu76/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu77/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu77/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu78/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu78/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu79/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu79/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu8/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu8/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu8/topology/core_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu8/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu8/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu8/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu8/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu8/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu80/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu80/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu80/topology/core_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu80/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu80/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu80/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu80/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu80/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu81/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu81/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu82/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu82/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu83/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu83/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu84/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu84/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu85/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu85/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu86/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu86/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu87/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu87/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu88/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu88/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu88/topology/core_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu88/topology/core_siblings create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu88/topology/core_siblings_list create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu88/topology/physical_package_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu88/topology/thread_siblings create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu88/topology/thread_siblings_list create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu89/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu89/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu9/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu9/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu90/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu90/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu91/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu91/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu92/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu92/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu93/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu93/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu94/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu94/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu95/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/cpu95/physical_id create mode 100644 tests/nodeinfodata/linux-subcores/cpu/dscr_default create mode 100644 tests/nodeinfodata/linux-subcores/cpu/kernel_max create mode 100644 tests/nodeinfodata/linux-subcores/cpu/offline create mode 100644 tests/nodeinfodata/linux-subcores/cpu/online create mode 100644 tests/nodeinfodata/linux-subcores/cpu/possible create mode 100644 tests/nodeinfodata/linux-subcores/cpu/present create mode 100644 tests/nodeinfodata/linux-subcores/cpu/subcores_per_core create mode 120000 tests/nodeinfodata/linux-subcores/node/node0/cpu0 create mode 120000 tests/nodeinfodata/linux-subcores/node/node0/cpu1 create mode 120000 tests/nodeinfodata/linux-subcores/node/node0/cpu10 create mode 120000 tests/nodeinfodata/linux-subcores/node/node0/cpu11 create mode 120000 tests/nodeinfodata/linux-subcores/node/node0/cpu12 create mode 120000 tests/nodeinfodata/linux-subcores/node/node0/cpu13 create mode 120000 tests/nodeinfodata/linux-subcores/node/node0/cpu14 create mode 120000 tests/nodeinfodata/linux-subcores/node/node0/cpu15 create mode 120000 tests/nodeinfodata/linux-subcores/node/node0/cpu16 create mode 120000 tests/nodeinfodata/linux-subcores/node/node0/cpu17 create mode 120000 tests/nodeinfodata/linux-subcores/node/node0/cpu18 create mode 120000 tests/nodeinfodata/linux-subcores/node/node0/cpu19 create mode 120000 tests/nodeinfodata/linux-subcores/node/node0/cpu2 create mode 120000 tests/nodeinfodata/linux-subcores/node/node0/cpu20 create mode 120000 tests/nodeinfodata/linux-subcores/node/node0/cpu21 create mode 120000 tests/nodeinfodata/linux-subcores/node/node0/cpu22 create mode 120000 tests/nodeinfodata/linux-subcores/node/node0/cpu23 create mode 120000 tests/nodeinfodata/linux-subcores/node/node0/cpu3 create mode 120000 tests/nodeinfodata/linux-subcores/node/node0/cpu4 create mode 120000 tests/nodeinfodata/linux-subcores/node/node0/cpu5 create mode 120000 tests/nodeinfodata/linux-subcores/node/node0/cpu6 create mode 120000 tests/nodeinfodata/linux-subcores/node/node0/cpu7 create mode 120000 tests/nodeinfodata/linux-subcores/node/node0/cpu8 create mode 120000 tests/nodeinfodata/linux-subcores/node/node0/cpu9 create mode 100644 tests/nodeinfodata/linux-subcores/node/node0/cpulist create mode 100644 tests/nodeinfodata/linux-subcores/node/node0/cpumap create mode 100644 tests/nodeinfodata/linux-subcores/node/node0/distance create mode 100644 tests/nodeinfodata/linux-subcores/node/node0/meminfo create mode 100644 tests/nodeinfodata/linux-subcores/node/node0/numastat create mode 120000 tests/nodeinfodata/linux-subcores/node/node1/cpu24 create mode 120000 tests/nodeinfodata/linux-subcores/node/node1/cpu25 create mode 120000 tests/nodeinfodata/linux-subcores/node/node1/cpu26 create mode 120000 tests/nodeinfodata/linux-subcores/node/node1/cpu27 create mode 120000 tests/nodeinfodata/linux-subcores/node/node1/cpu28 create mode 120000 tests/nodeinfodata/linux-subcores/node/node1/cpu29 create mode 120000 tests/nodeinfodata/linux-subcores/node/node1/cpu30 create mode 120000 tests/nodeinfodata/linux-subcores/node/node1/cpu31 create mode 120000 tests/nodeinfodata/linux-subcores/node/node1/cpu32 create mode 120000 tests/nodeinfodata/linux-subcores/node/node1/cpu33 create mode 120000 tests/nodeinfodata/linux-subcores/node/node1/cpu34 create mode 120000 tests/nodeinfodata/linux-subcores/node/node1/cpu35 create mode 120000 tests/nodeinfodata/linux-subcores/node/node1/cpu36 create mode 120000 tests/nodeinfodata/linux-subcores/node/node1/cpu37 create mode 120000 tests/nodeinfodata/linux-subcores/node/node1/cpu38 create mode 120000 tests/nodeinfodata/linux-subcores/node/node1/cpu39 create mode 120000 tests/nodeinfodata/linux-subcores/node/node1/cpu40 create mode 120000 tests/nodeinfodata/linux-subcores/node/node1/cpu41 create mode 120000 tests/nodeinfodata/linux-subcores/node/node1/cpu42 create mode 120000 tests/nodeinfodata/linux-subcores/node/node1/cpu43 create mode 120000 tests/nodeinfodata/linux-subcores/node/node1/cpu44 create mode 120000 tests/nodeinfodata/linux-subcores/node/node1/cpu45 create mode 120000 tests/nodeinfodata/linux-subcores/node/node1/cpu46 create mode 120000 tests/nodeinfodata/linux-subcores/node/node1/cpu47 create mode 100644 tests/nodeinfodata/linux-subcores/node/node1/cpulist create mode 100644 tests/nodeinfodata/linux-subcores/node/node1/cpumap create mode 100644 tests/nodeinfodata/linux-subcores/node/node1/distance create mode 100644 tests/nodeinfodata/linux-subcores/node/node1/meminfo create mode 100644 tests/nodeinfodata/linux-subcores/node/node1/numastat create mode 120000 tests/nodeinfodata/linux-subcores/node/node16/cpu48 create mode 120000 tests/nodeinfodata/linux-subcores/node/node16/cpu49 create mode 120000 tests/nodeinfodata/linux-subcores/node/node16/cpu50 create mode 120000 tests/nodeinfodata/linux-subcores/node/node16/cpu51 create mode 120000 tests/nodeinfodata/linux-subcores/node/node16/cpu52 create mode 120000 tests/nodeinfodata/linux-subcores/node/node16/cpu53 create mode 120000 tests/nodeinfodata/linux-subcores/node/node16/cpu54 create mode 120000 tests/nodeinfodata/linux-subcores/node/node16/cpu55 create mode 120000 tests/nodeinfodata/linux-subcores/node/node16/cpu56 create mode 120000 tests/nodeinfodata/linux-subcores/node/node16/cpu57 create mode 120000 tests/nodeinfodata/linux-subcores/node/node16/cpu58 create mode 120000 tests/nodeinfodata/linux-subcores/node/node16/cpu59 create mode 120000 tests/nodeinfodata/linux-subcores/node/node16/cpu60 create mode 120000 tests/nodeinfodata/linux-subcores/node/node16/cpu61 create mode 120000 tests/nodeinfodata/linux-subcores/node/node16/cpu62 create mode 120000 tests/nodeinfodata/linux-subcores/node/node16/cpu63 create mode 120000 tests/nodeinfodata/linux-subcores/node/node16/cpu64 create mode 120000 tests/nodeinfodata/linux-subcores/node/node16/cpu65 create mode 120000 tests/nodeinfodata/linux-subcores/node/node16/cpu66 create mode 120000 tests/nodeinfodata/linux-subcores/node/node16/cpu67 create mode 120000 tests/nodeinfodata/linux-subcores/node/node16/cpu68 create mode 120000 tests/nodeinfodata/linux-subcores/node/node16/cpu69 create mode 120000 tests/nodeinfodata/linux-subcores/node/node16/cpu70 create mode 120000 tests/nodeinfodata/linux-subcores/node/node16/cpu71 create mode 100644 tests/nodeinfodata/linux-subcores/node/node16/cpulist create mode 100644 tests/nodeinfodata/linux-subcores/node/node16/cpumap create mode 100644 tests/nodeinfodata/linux-subcores/node/node16/distance create mode 100644 tests/nodeinfodata/linux-subcores/node/node16/meminfo create mode 100644 tests/nodeinfodata/linux-subcores/node/node16/numastat create mode 100644 tests/nodeinfodata/linux-subcores/node/node16/uevent create mode 100644 tests/nodeinfodata/linux-subcores/node/node16/vmstat create mode 120000 tests/nodeinfodata/linux-subcores/node/node17/cpu72 create mode 120000 tests/nodeinfodata/linux-subcores/node/node17/cpu73 create mode 120000 tests/nodeinfodata/linux-subcores/node/node17/cpu74 create mode 120000 tests/nodeinfodata/linux-subcores/node/node17/cpu75 create mode 120000 tests/nodeinfodata/linux-subcores/node/node17/cpu76 create mode 120000 tests/nodeinfodata/linux-subcores/node/node17/cpu77 create mode 120000 tests/nodeinfodata/linux-subcores/node/node17/cpu78 create mode 120000 tests/nodeinfodata/linux-subcores/node/node17/cpu79 create mode 120000 tests/nodeinfodata/linux-subcores/node/node17/cpu80 create mode 120000 tests/nodeinfodata/linux-subcores/node/node17/cpu81 create mode 120000 tests/nodeinfodata/linux-subcores/node/node17/cpu82 create mode 120000 tests/nodeinfodata/linux-subcores/node/node17/cpu83 create mode 120000 tests/nodeinfodata/linux-subcores/node/node17/cpu84 create mode 120000 tests/nodeinfodata/linux-subcores/node/node17/cpu85 create mode 120000 tests/nodeinfodata/linux-subcores/node/node17/cpu86 create mode 120000 tests/nodeinfodata/linux-subcores/node/node17/cpu87 create mode 120000 tests/nodeinfodata/linux-subcores/node/node17/cpu88 create mode 120000 tests/nodeinfodata/linux-subcores/node/node17/cpu89 create mode 120000 tests/nodeinfodata/linux-subcores/node/node17/cpu90 create mode 120000 tests/nodeinfodata/linux-subcores/node/node17/cpu91 create mode 120000 tests/nodeinfodata/linux-subcores/node/node17/cpu92 create mode 120000 tests/nodeinfodata/linux-subcores/node/node17/cpu93 create mode 120000 tests/nodeinfodata/linux-subcores/node/node17/cpu94 create mode 120000 tests/nodeinfodata/linux-subcores/node/node17/cpu95 create mode 100644 tests/nodeinfodata/linux-subcores/node/node17/cpulist create mode 100644 tests/nodeinfodata/linux-subcores/node/node17/cpumap create mode 100644 tests/nodeinfodata/linux-subcores/node/node17/distance create mode 100644 tests/nodeinfodata/linux-subcores/node/node17/meminfo create mode 100644 tests/nodeinfodata/linux-subcores/node/node17/numastat create mode 100644 tests/nodeinfodata/linux-subcores/node/node17/vmstat create mode 100644 tests/nodeinfodata/linux-subcores/node/online create mode 100644 tests/nodeinfodata/linux-subcores/node/possible create mode 100644 tests/nodeinfomock.c -- 2.4.3

2 5

[libvirt] [PATCH] storage: Fix regression in storagePoolUpdateAllState
by Erik Skultety 08 Jul '15

08 Jul '15

Commit 2a31c5f0 introduced support for storage pool state XMLs, however it also introduced a regression: if (!virstoragePoolObjIsActive(pool)) { virStoragePoolObjUnlock(pool); continue; } The idea behind this was that since we've got state XMLs and the pool wasn't marked as active by autostart routine (if the autostart flag had been set earlier), the pool is inactive and we can leave it be and continue with other pools. However, filesystem type pools like fs,dir, possibly netfs are supposed to be active if the filesystem is mounted on the host. And this is exactly where the regression occurs, e.g. pool type 'dir' which has been previously destroyed and marked as !autostart gets filtered out by the condition above. The resolution should be simply to remove the condition completely, all pools will get their 'active' flag updated by check callback and if they do not support such callback, the logic doesn't change and such pools will be inactive by default (e.g. RBD, even if a state XML exists). Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1238610 --- src/storage/storage_driver.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index e600514..d3cdbc5 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -142,11 +142,6 @@ storagePoolUpdateAllState(void) virStoragePoolObjPtr pool = driver->pools.objs[i]; virStoragePoolObjLock(pool); - if (!virStoragePoolObjIsActive(pool)) { - virStoragePoolObjUnlock(pool); - continue; - } - storagePoolUpdateState(pool); virStoragePoolObjUnlock(pool); } -- 1.9.3

2 2

[libvirt] [PATCH 0/3] bitmap: Fix regression when getting iothread info
by Peter Krempa 08 Jul '15

08 Jul '15

Peter Krempa (3): vz: Remove dead code from vzDomainGetVcpus vz: Use virBitmapToDataBuf instead of virBitmapToData in vzDomainGetVcpus util: bitmap: Don't alloc overly large binary bitmaps src/util/virbitmap.c | 7 +++++-- src/vz/vz_driver.c | 24 ++++-------------------- 2 files changed, 9 insertions(+), 22 deletions(-) -- 2.4.5

2 5

[libvirt] [PATCH] qemu: move the guest status check before agent config and status check
by Luyao Huang 08 Jul '15

08 Jul '15

When use setvcpus command with --guest option to a offline vm, we will get error: # virsh setvcpus test3 1 --guest error: Guest agent is not responding: QEMU guest agent is not connected However guest is not running, agent status could not be connected. In this case, report domain is not running will be better than agent is not connected. Move the guest status check more early to output error to point out guest status is not right. Also from the logic, a running vm is a basic requirement to use agent, we cannot use agent if vm is not running. Signed-off-by: Luyao Huang <lhuang(a)redhat.com> --- src/qemu/qemu_domain.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index f9bf32c..814fb2c 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -3084,6 +3084,13 @@ qemuDomainAgentAvailable(virDomainObjPtr vm, } return false; } + if (virDomainObjGetState(vm, NULL) != VIR_DOMAIN_RUNNING) { + if (reportError) { + virReportError(VIR_ERR_OPERATION_INVALID, "%s", + _("domain is not running")); + } + return false; + } if (!priv->agent) { if (qemuFindAgentConfig(vm->def)) { if (reportError) { @@ -3099,13 +3106,6 @@ qemuDomainAgentAvailable(virDomainObjPtr vm, return false; } } - if (virDomainObjGetState(vm, NULL) != VIR_DOMAIN_RUNNING) { - if (reportError) { - virReportError(VIR_ERR_OPERATION_INVALID, "%s", - _("domain is not running")); - } - return false; - } return true; } -- 1.8.3.1

3 2

[libvirt] [PATCH] qemu: remove deadcode in qemuDomain{HelperGetVcpus|GetIOThreadsLive}
by Luyao Huang 08 Jul '15

08 Jul '15

We set hostcpus but not use them. Signed-off-by: Luyao Huang <lhuang(a)redhat.com> --- src/qemu/qemu_driver.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 7a04e67..3f002b3 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1418,13 +1418,9 @@ static int qemuDomainHelperGetVcpus(virDomainObjPtr vm, virVcpuInfoPtr info, int maxinfo, unsigned char *cpumaps, int maplen) { - int hostcpus; size_t i, v; qemuDomainObjPrivatePtr priv = vm->privateData; - if ((hostcpus = nodeGetCPUCount()) < 0) - return -1; - if (priv->vcpupids == NULL) { virReportError(VIR_ERR_OPERATION_INVALID, "%s", _("cpu affinity is not supported")); @@ -5579,7 +5575,6 @@ qemuDomainGetIOThreadsLive(virQEMUDriverPtr driver, qemuMonitorIOThreadInfoPtr *iothreads = NULL; virDomainIOThreadInfoPtr *info_ret = NULL; int niothreads = 0; - int hostcpus; size_t i; int ret = -1; @@ -5612,9 +5607,6 @@ qemuDomainGetIOThreadsLive(virQEMUDriverPtr driver, goto endjob; } - if ((hostcpus = nodeGetCPUCount()) < 0) - goto endjob; - if (VIR_ALLOC_N(info_ret, niothreads) < 0) goto endjob; -- 1.8.3.1

3 2

[libvirt] [PATCH] rpc: ensure daemon is spawn even if dead socket exists
by Daniel P. Berrange 08 Jul '15

08 Jul '15

The auto-spawn code would originally attempt to spawn the daemon for both ENOENT and ECONNREFUSED errors from connect(). The various refactorings eventually lost this so we only spawn the daemon on ENOENT. The result is if the daemon exits uncleanly, so that the socket is left in the filesystem, we will never be able to auto-spawn the daemon again. --- src/rpc/virnetsocket.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c index 3d75081..106d09a 100644 --- a/src/rpc/virnetsocket.c +++ b/src/rpc/virnetsocket.c @@ -681,7 +681,8 @@ int virNetSocketNewConnectUNIX(const char *path, while (retries && connect(fd, &remoteAddr.data.sa, remoteAddr.len) < 0) { - if (!(spawnDaemon && errno == ENOENT)) { + if (!(spawnDaemon && (errno == ENOENT || + errno == ECONNREFUSED))) { virReportSystemError(errno, _("Failed to connect socket to '%s'"), path); goto cleanup; -- 2.4.3

2 1

[libvirt] [glib v2 0/2] misc gconfig fixes
by Cédric Bosdonnat 08 Jul '15

08 Jul '15

Hi all, Here is a version fixing two bugs I introduced. Diff to v1: * takes into account teuf's comments. Cédric Bosdonnat (2): Don't overwrite filesystem type when writing format Dsitribute the whole tests/xml folder libvirt-gconfig/libvirt-gconfig-domain-filesys.c | 4 ++-- tests/Makefile.am | 14 +------------- tests/test-gconfig.c | 2 +- tests/xml/gconfig-domain-device-filesys.xml | 2 +- 4 files changed, 5 insertions(+), 17 deletions(-) -- 2.1.4

2 3

[libvirt] [glib] Don't overwrite filesystem type when writing format
by Cédric Bosdonnat 07 Jul '15

07 Jul '15

When setting filesystem driver format first and type, only the type remained and vice-versa. --- libvirt-gconfig/libvirt-gconfig-domain-filesys.c | 8 ++++++-- tests/test-gconfig.c | 2 +- tests/xml/gconfig-domain-device-filesys.xml | 2 +- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-filesys.c b/libvirt-gconfig/libvirt-gconfig-domain-filesys.c index 9b73af5..4e33d5f 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-filesys.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-filesys.c @@ -125,7 +125,9 @@ void gvir_config_domain_filesys_set_driver_type(GVirConfigDomainFilesys *filesys GVirConfigObject *node; g_return_if_fail(GVIR_CONFIG_IS_DOMAIN_FILESYS(filesys)); - node = gvir_config_object_replace_child(GVIR_CONFIG_OBJECT(filesys), "driver"); + node = gvir_config_object_get_child(GVIR_CONFIG_OBJECT(filesys), "driver"); + if (!node) + node = gvir_config_object_add_child(GVIR_CONFIG_OBJECT(filesys), "driver"); g_return_if_fail(GVIR_CONFIG_IS_OBJECT(node)); if (type != GVIR_CONFIG_DOMAIN_FILESYS_DRIVER_DEFAULT) gvir_config_object_set_attribute_with_type( @@ -143,7 +145,9 @@ void gvir_config_domain_filesys_set_driver_format(GVirConfigDomainFilesys *files GVirConfigObject *node; g_return_if_fail(GVIR_CONFIG_IS_DOMAIN_FILESYS(filesys)); - node = gvir_config_object_replace_child(GVIR_CONFIG_OBJECT(filesys), "driver"); + node = gvir_config_object_get_child(GVIR_CONFIG_OBJECT(filesys), "driver"); + if (!node) + node = gvir_config_object_add_child(GVIR_CONFIG_OBJECT(filesys), "driver"); g_return_if_fail(GVIR_CONFIG_IS_OBJECT(node)); gvir_config_object_set_attribute_with_type( diff --git a/tests/test-gconfig.c b/tests/test-gconfig.c index bd2daa6..0eec53e 100644 --- a/tests/test-gconfig.c +++ b/tests/test-gconfig.c @@ -368,7 +368,7 @@ static void test_domain_device_filesystem(void) fs = gvir_config_domain_filesys_new(); gvir_config_domain_filesys_set_type(fs, GVIR_CONFIG_DOMAIN_FILESYS_FILE); gvir_config_domain_filesys_set_access_type(fs, GVIR_CONFIG_DOMAIN_FILESYS_ACCESS_MAPPED); - gvir_config_domain_filesys_set_driver_type(fs, GVIR_CONFIG_DOMAIN_FILESYS_DRIVER_DEFAULT); + gvir_config_domain_filesys_set_driver_type(fs, GVIR_CONFIG_DOMAIN_FILESYS_DRIVER_NBD); gvir_config_domain_filesys_set_driver_format(fs, GVIR_CONFIG_DOMAIN_DISK_FORMAT_QCOW2); gvir_config_domain_filesys_set_source(fs, "/path/to/source"); gvir_config_domain_filesys_set_target(fs, "/path/to/target1"); diff --git a/tests/xml/gconfig-domain-device-filesys.xml b/tests/xml/gconfig-domain-device-filesys.xml index 30152d2..a831c02 100644 --- a/tests/xml/gconfig-domain-device-filesys.xml +++ b/tests/xml/gconfig-domain-device-filesys.xml @@ -1,7 +1,7 @@ <domain> <devices> <filesystem type="file" accessmode="mapped"> - <driver format="qcow2"/> + <driver type="nbd" format="qcow2"/> <source file="/path/to/source"/> <target dir="/path/to/target1"/> <readonly/> -- 2.1.4

3 3

[libvirt] [glib] Add filesys xml file to distribution
by Cédric Bosdonnat 07 Jul '15

07 Jul '15

Tests can't succeed from the distribution tarball: the new gconfig-domain-device-filesys.xml file wasn't included. --- tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index 63865e8..c8bb4c7 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -23,6 +23,7 @@ EXTRA_DIST += \ xml/gconfig-domain-device-channel.xml \ xml/gconfig-domain-device-console.xml \ xml/gconfig-domain-device-disk.xml \ + xml/gconfig-domain-device-filesys.xml \ xml/gconfig-domain-device-graphics.xml \ xml/gconfig-domain-device-input.xml \ xml/gconfig-domain-device-network.xml \ -- 2.1.4

2 1

[libvirt] [PATCH v2 0/1] vz: assign static IPs and default gateways for network adapter
by Mikhail Feoktistov 07 Jul '15

07 Jul '15

fix "avoid_if_before_free" warnings for VIR_FREE calls fix "found diagnostic without %" warnings for virReportError calls use virAsprintf instead of virBufferAsprintf set default gateway only if static ip is present write inet family to log in case of unsupported gateway Mikhail Feoktistov (1): vz: assign static IPs and default gateways for network adapter

2 2

[libvirt] [PATCH RESEND] Added support for portable-rpcgen from portablexdr library
by Pavel Fedin 07 Jul '15

07 Jul '15

This patch allows to build libvirt natively under MinGW/MSYS using portablexdr library. An updated version of portablexdr with fixed bugs is available as part of MSYS2 project. Signed-off-by: Pavel Fedin <p.fedin(a)samsung.com> --- configure.ac | 2 +- src/lxc/lxc_monitor_protocol.x | 2 +- src/rpc/genprotocol.pl | 5 ++++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index aed0934..547a405 100644 --- a/configure.ac +++ b/configure.ac @@ -397,7 +397,7 @@ AM_CONDITIONAL([HAVE_LIBTASN1], [test "x$ac_cv_header_libtasn1_h" = "xyes"]) AC_CHECK_LIB([intl],[gettext],[]) dnl Do we have rpcgen? -AC_PATH_PROG([RPCGEN], [rpcgen], [no]) +AC_PATH_PROGS([RPCGEN], [rpcgen portable-rpcgen], [no]) AM_CONDITIONAL([HAVE_RPCGEN], [test "x$ac_cv_path_RPCGEN" != "xno"]) dnl Is this GLIBC's buggy rpcgen? AM_CONDITIONAL([HAVE_GLIBC_RPCGEN], diff --git a/src/lxc/lxc_monitor_protocol.x b/src/lxc/lxc_monitor_protocol.x index 3b66af5..205d7c2 100644 --- a/src/lxc/lxc_monitor_protocol.x +++ b/src/lxc/lxc_monitor_protocol.x @@ -30,7 +30,7 @@ enum virLXCMonitorExitStatus { }; struct virLXCMonitorExitEventMsg { - enum virLXCMonitorExitStatus status; + virLXCMonitorExitStatus status; }; struct virLXCMonitorInitEventMsg { diff --git a/src/rpc/genprotocol.pl b/src/rpc/genprotocol.pl index 6e6d6d4..1ac2507 100755 --- a/src/rpc/genprotocol.pl +++ b/src/rpc/genprotocol.pl @@ -38,7 +38,10 @@ my $target = shift; unlink $target; -open RPCGEN, "-|", $rpcgen, $mode, $xdrdef +if ($rpcgen =~ /portable-rpcgen/) { + $rpcgen = "$rpcgen -o -"; +} +open RPCGEN, "-|", "$rpcgen $mode $xdrdef" or die "cannot run $rpcgen $mode $xdrdef: $!"; open TARGET, ">$target" or die "cannot create $target: $!"; -- 1.9.5.msysgit.0 -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

2 4

[libvirt] [PATCH] vz: assign static IPs and default gateways for network adapter
by Mikhail Feoktistov 07 Jul '15

07 Jul '15

We support only one IPv4 and one IPv6 default gateway. If static IPs are not present in instance config, then we switch on DHCP for this adapter. PrlVmDevNet_SetAutoApply to makes necessary settings within guest OS In linux case it creates network startup scripts /etc/sysconfig/network-scripts/ifcfg-ethN and fills it with necessary parameters. --- src/vz/vz_sdk.c | 120 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 120 insertions(+), 0 deletions(-) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index f27098c..7d318f8 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -2788,8 +2788,13 @@ static int prlsdkAddNet(PRL_HANDLE sdkdom, PRL_HANDLE sdknet = PRL_INVALID_HANDLE; PRL_HANDLE vnet = PRL_INVALID_HANDLE; PRL_HANDLE job = PRL_INVALID_HANDLE; + PRL_HANDLE addrlist = PRL_INVALID_HANDLE; + size_t i; int ret = -1; char macstr[PRL_MAC_STRING_BUFNAME]; + char *addrstr = NULL; + bool ipv6present = false; + bool ipv4present = false; if (prlsdkCheckNetUnsupportedParams(net) < 0) return -1; @@ -2814,6 +2819,118 @@ static int prlsdkAddNet(PRL_HANDLE sdkdom, pret = PrlVmDevNet_SetMacAddress(sdknet, macstr); prlsdkCheckRetGoto(pret, cleanup); + pret = PrlApi_CreateStringsList(&addrlist); + prlsdkCheckRetGoto(pret, cleanup); + + for (i = 0; i < net->nips; i++) { + virBuffer buf = VIR_BUFFER_INITIALIZER; + char *tmpstr; + + if (AF_INET == VIR_SOCKET_ADDR_FAMILY(&net->ips[i]->address)) + ipv4present = true; + else if (AF_INET6 == VIR_SOCKET_ADDR_FAMILY(&net->ips[i]->address)) + ipv6present = true; + else + continue; + + if (!(tmpstr = virSocketAddrFormat(&net->ips[i]->address))) + goto cleanup; + + virBufferAsprintf(&buf, "%s/%d", tmpstr, net->ips[i]->prefix); + VIR_FREE(tmpstr); + if (!(addrstr = virBufferContentAndReset(&buf))) + goto cleanup; + + pret = PrlStrList_AddItem(addrlist, addrstr); + prlsdkCheckRetGoto(pret, cleanup); + + VIR_FREE(addrstr); + addrstr = NULL; + } + + if (ipv4present || ipv6present) { + pret = PrlVmDevNet_SetNetAddresses(sdknet, addrlist); + prlsdkCheckRetGoto(pret, cleanup); + } + + pret = PrlVmDevNet_SetConfigureWithDhcp(sdknet, !ipv4present); + prlsdkCheckRetGoto(pret, cleanup); + + pret = PrlVmDevNet_SetConfigureWithDhcpIPv6(sdknet, !ipv6present); + prlsdkCheckRetGoto(pret, cleanup); + + pret = PrlVmDevNet_SetAutoApply(sdknet, true); + prlsdkCheckRetGoto(pret, cleanup); + + if (net->nroutes) { + bool alreadySetIPv4Gateway = false; + bool alreadySetIPv6Gateway = false; + + for (i = 0; i < net->nroutes; i++) { + virSocketAddrPtr addrdst, gateway; + virSocketAddr zero; + + addrdst = virNetworkRouteDefGetAddress(net->routes[i]); + gateway = virNetworkRouteDefGetGateway(net->routes[i]); + + ignore_value(virSocketAddrParse(&zero, + (VIR_SOCKET_ADDR_IS_FAMILY(addrdst, AF_INET) + ? VIR_SOCKET_ADDR_IPV4_ALL + : VIR_SOCKET_ADDR_IPV6_ALL), + VIR_SOCKET_ADDR_FAMILY(addrdst))); + + if (!virSocketAddrEqual(addrdst, &zero)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Support only default gateway")); + goto cleanup; + } + + switch (VIR_SOCKET_ADDR_FAMILY(gateway)) { + case AF_INET: + if (alreadySetIPv4Gateway) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Support only one IPv4 default gateway")); + goto cleanup; + } + + if (!(addrstr = virSocketAddrFormat(gateway))) + goto cleanup; + + pret = PrlVmDevNet_SetDefaultGateway(sdknet, addrstr); + prlsdkCheckRetGoto(pret, cleanup); + + alreadySetIPv4Gateway = true; + break; + + case AF_INET6: + if (alreadySetIPv6Gateway) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Support only one IPv6 default gateway")); + goto cleanup; + } + + if (!(addrstr = virSocketAddrFormat(gateway))) + goto cleanup; + + pret = PrlVmDevNet_SetDefaultGatewayIPv6(sdknet, addrstr); + prlsdkCheckRetGoto(pret, cleanup); + + alreadySetIPv6Gateway = true; + break; + + default: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Support only IPv4 and IPv6 default gateways")); + goto cleanup; + } + + if (addrstr) { + VIR_FREE(addrstr); + addrstr = NULL; + } + } + } + if (isCt) { if (net->model) VIR_WARN("Setting network adapter for containers is not " @@ -2879,6 +2996,9 @@ static int prlsdkAddNet(PRL_HANDLE sdkdom, ret = 0; cleanup: + if (addrstr) + VIR_FREE(addrstr); + PrlHandle_Free(addrlist); PrlHandle_Free(vnet); PrlHandle_Free(sdknet); return ret; -- 1.7.1

2 2

[libvirt] More coverage for networking API v4
by Zeeshan Ali (Khattak) 07 Jul '15

07 Jul '15

I wasn't setting return values to GTask correctly in the v3. Fixed now.

2 16

[libvirt] [PATCH v2] vz: fix building capabilities
by Dmitry Guryanov 06 Jul '15

06 Jul '15

There should be at least one domain for each guest in cababilities. And in current code we don't add domain for this guest for example. if ((guest = virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_HVM, VIR_ARCH_X86_64, "vz", NULL, 0, NULL)) == NULL) Anyway, with two virt types it looks a litte messy, so let's move adding guest and domain to a separate function. Signed-off-by: Dmitry Guryanov <dguryanov(a)parallels.com> --- src/vz/vz_driver.c | 92 ++++++++++++++++++++++-------------------------------- 1 file changed, 38 insertions(+), 54 deletions(-) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index 47c5023..8c3c818 100644 --- a/src/vz/vz_driver.c +++ b/src/vz/vz_driver.c @@ -78,14 +78,45 @@ vzDriverUnlock(vzConnPtr driver) virMutexUnlock(&driver->lock); } +static int +vzCapsAddGuestDomain(virCapsPtr caps, + virDomainOSType ostype, + virArch arch, + const char * emulator, + virDomainVirtType virt_type) +{ + virCapsGuestPtr guest; + + if ((guest = virCapabilitiesAddGuest(caps, ostype, arch, emulator, + NULL, 0, NULL)) == NULL) + return -1; + + + if (virCapabilitiesAddGuestDomain(guest, virt_type, + NULL, NULL, 0, NULL) == NULL) + return -1; + + return 0; +} + static virCapsPtr vzBuildCapabilities(void) { virCapsPtr caps = NULL; virCPUDefPtr cpu = NULL; virCPUDataPtr data = NULL; - virCapsGuestPtr guest; virNodeInfo nodeinfo; + virDomainOSType ostypes[] = { + VIR_DOMAIN_OSTYPE_HVM, + VIR_DOMAIN_OSTYPE_EXE + }; + virArch archs[] = { VIR_ARCH_I686, VIR_ARCH_X86_64 }; + const char *const emulators[] = { "parallels", "vz" }; + virDomainVirtType virt_types[] = { + VIR_DOMAIN_VIRT_PARALLELS, + VIR_DOMAIN_VIRT_VZ + }; + size_t i, j, k; if ((caps = virCapabilitiesNew(virArchFromHost(), false, false)) == NULL) @@ -94,59 +125,12 @@ vzBuildCapabilities(void) if (nodeCapsInitNUMA(caps) < 0) goto error; - if ((guest = virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_HVM, - VIR_ARCH_X86_64, - "parallels", - NULL, 0, NULL)) == NULL) - goto error; - - if ((guest = virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_HVM, - VIR_ARCH_I686, - "parallels", - NULL, 0, NULL)) == NULL) - goto error; - - - if (virCapabilitiesAddGuestDomain(guest, VIR_DOMAIN_VIRT_PARALLELS, - NULL, NULL, 0, NULL) == NULL) - goto error; - - if ((guest = virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_EXE, - VIR_ARCH_X86_64, - "parallels", - NULL, 0, NULL)) == NULL) - goto error; - - if (virCapabilitiesAddGuestDomain(guest, VIR_DOMAIN_VIRT_PARALLELS, - NULL, NULL, 0, NULL) == NULL) - goto error; - - if ((guest = virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_HVM, - VIR_ARCH_X86_64, - "vz", - NULL, 0, NULL)) == NULL) - goto error; - - if ((guest = virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_HVM, - VIR_ARCH_I686, - "vz", - NULL, 0, NULL)) == NULL) - goto error; - - - if (virCapabilitiesAddGuestDomain(guest, VIR_DOMAIN_VIRT_VZ, - NULL, NULL, 0, NULL) == NULL) - goto error; - - if ((guest = virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_EXE, - VIR_ARCH_X86_64, - "vz", - NULL, 0, NULL)) == NULL) - goto error; - - if (virCapabilitiesAddGuestDomain(guest, VIR_DOMAIN_VIRT_VZ, - NULL, NULL, 0, NULL) == NULL) - goto error; + for (i = 0; i < 2; i++) + for (j = 0; j < 2; j++) + for (k = 0; k < 2; k++) + if (vzCapsAddGuestDomain(caps, ostypes[i], archs[j], + emulators[k], virt_types[k]) < 0) + goto error; if (nodeGetInfo(&nodeinfo)) goto error; -- 2.4.3

2 2

[libvirt] [PATCH v2 0/2] Allow PCI virtio on ARM "virt" machine
by Pavel Fedin 06 Jul '15

06 Jul '15

Virt machine in qemu since v2.3.0 has PCI generic host controller, and can use PCI devices. This provides performance improvement as well as vhost-net with irqfd support for virtio-net. However libvirt still insists on virtio devices attached to virt machine to have MMIO bindings. This patch allows to use both. If the user doesn't specify <address type='virtio-mmio'>, PCI will be used by default. Changes since v1: - Added capability based on qemu version number - Recognize also "virt-" prefix Pavel Fedin (2): Introduce QEMU_CAPS_ARM_VIRT_PCI Allow PCI virtio on ARM "virt" machine src/qemu/qemu_capabilities.c | 5 +++++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 15 ++++++++++++--- 3 files changed, 18 insertions(+), 3 deletions(-) -- 1.9.5.msysgit.0

4 16

[libvirt] [PATCH] vz: fix building capabilities
by Dmitry Guryanov 03 Jul '15

03 Jul '15

There should be at least one domain for each guest in cababilities. And in current code we don't add domain for this guest for example. if ((guest = virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_HVM, VIR_ARCH_X86_64, "vz", NULL, 0, NULL)) == NULL) Anyway, with two virt types it looks a litte messy, so let's move adding guest and domain to a separate function. --- src/vz/vz_driver.c | 92 +++++++++++++++++++++------------------------------ 1 files changed, 38 insertions(+), 54 deletions(-) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index 47c5023..a86ae28 100644 --- a/src/vz/vz_driver.c +++ b/src/vz/vz_driver.c @@ -78,14 +78,45 @@ vzDriverUnlock(vzConnPtr driver) virMutexUnlock(&driver->lock); } +static int +vzCapsAddGuestDomain(virCapsPtr caps, + virDomainOSType ostype, + virArch arch, + const char * emulator, + virDomainVirtType virt_type) +{ + virCapsGuestPtr guest; + + if ((guest = virCapabilitiesAddGuest(caps, ostype, arch, emulator, + NULL, 0, NULL)) == NULL) + return -1; + + + if (virCapabilitiesAddGuestDomain(guest, virt_type, + NULL, NULL, 0, NULL) == NULL) + return -1; + + return 0; +} + static virCapsPtr vzBuildCapabilities(void) { virCapsPtr caps = NULL; virCPUDefPtr cpu = NULL; virCPUDataPtr data = NULL; - virCapsGuestPtr guest; virNodeInfo nodeinfo; + virDomainOSType ostypes[] = { + VIR_DOMAIN_OSTYPE_HVM, + VIR_DOMAIN_OSTYPE_EXE + }; + virArch archs[] = { VIR_ARCH_I686, VIR_ARCH_X86_64 }; + const char *const emulators[] = { "parallels", "vz" }; + virDomainVirtType virt_types[] = { + VIR_DOMAIN_VIRT_PARALLELS, + VIR_DOMAIN_VIRT_VZ + }; + size_t i, j, k; if ((caps = virCapabilitiesNew(virArchFromHost(), false, false)) == NULL) @@ -94,59 +125,12 @@ vzBuildCapabilities(void) if (nodeCapsInitNUMA(caps) < 0) goto error; - if ((guest = virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_HVM, - VIR_ARCH_X86_64, - "parallels", - NULL, 0, NULL)) == NULL) - goto error; - - if ((guest = virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_HVM, - VIR_ARCH_I686, - "parallels", - NULL, 0, NULL)) == NULL) - goto error; - - - if (virCapabilitiesAddGuestDomain(guest, VIR_DOMAIN_VIRT_PARALLELS, - NULL, NULL, 0, NULL) == NULL) - goto error; - - if ((guest = virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_EXE, - VIR_ARCH_X86_64, - "parallels", - NULL, 0, NULL)) == NULL) - goto error; - - if (virCapabilitiesAddGuestDomain(guest, VIR_DOMAIN_VIRT_PARALLELS, - NULL, NULL, 0, NULL) == NULL) - goto error; - - if ((guest = virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_HVM, - VIR_ARCH_X86_64, - "vz", - NULL, 0, NULL)) == NULL) - goto error; - - if ((guest = virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_HVM, - VIR_ARCH_I686, - "vz", - NULL, 0, NULL)) == NULL) - goto error; - - - if (virCapabilitiesAddGuestDomain(guest, VIR_DOMAIN_VIRT_VZ, - NULL, NULL, 0, NULL) == NULL) - goto error; - - if ((guest = virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_EXE, - VIR_ARCH_X86_64, - "vz", - NULL, 0, NULL)) == NULL) - goto error; - - if (virCapabilitiesAddGuestDomain(guest, VIR_DOMAIN_VIRT_VZ, - NULL, NULL, 0, NULL) == NULL) - goto error; + for (i = 0; i < 1; i++) + for (j = 0; j < 1; j++) + for (k = 0; k < 1; k++) + if (vzCapsAddGuestDomain(caps, ostypes[i], archs[j], + emulators[k], virt_types[k]) < 0) + goto error; if (nodeGetInfo(&nodeinfo)) goto error; -- 1.7.1

2 2

[libvirt] [libvirt-glib] gobject: Remove redundant virtual functions
by Zeeshan Ali (Khattak) 03 Jul '15

03 Jul '15

These virtual functions were most likely a result of copy&paste error. --- libvirt-gobject/libvirt-gobject-network.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libvirt-gobject/libvirt-gobject-network.h b/libvirt-gobject/libvirt-gobject-network.h index 5617ed6..8c31af4 100644 --- a/libvirt-gobject/libvirt-gobject-network.h +++ b/libvirt-gobject/libvirt-gobject-network.h @@ -55,10 +55,7 @@ struct _GVirNetworkClass { GObjectClass parent_class; - void (*started)(GVirNetwork *net); - void (*stopped)(GVirNetwork *net); - - gpointer padding[20]; + gpointer padding[22]; }; -- 2.4.3

2 3

[libvirt] [PATCH 0/2] [V3] Libvirt : Storage fixes
by Prerna Saxena 03 Jul '15

03 Jul '15

Here is V3 of storage fixes, which addresses review comments of v2. Summary: Prerna Saxena (2): Storage: Introduce shadow vol for refresh while the main vol builds. Storage : Fix cloning of raw, sparse volumes src/storage/storage_backend.c | 23 ++++++++++------------- src/storage/storage_driver.c | 19 ++++++++++++------- 2 files changed, 22 insertions(+), 20 deletions(-) V2 : http://www.redhat.com/archives/libvir-list/2015-June/msg01052.html Changelog: Modified patches 1,2 per review comments. -- 1.8.3.1 -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

2 5

[libvirt] [PATCH 0/7] Address some Coverity found issues
by John Ferlan 03 Jul '15

03 Jul '15

The following Coverity issues are flagged in Coverity 7.6.1 compared to not being seen in 7.5.1 - this series just addresses those issues before 7.6.1 is installed in our upstream Jenkins environment: http://jenkins-virt.usersys.redhat.com/job/libvirt-coverity/ It seems the bulk are essentially false positives, but we can do something in order to work around them. For the first 3 patches, Coverity complains that virVasprintfInternal can set "*strp = NULL;" on return (in the error path), but the callers don't associate the error path (< 0) with the 'buffer' and thus believe there could be some path where a return 0 would occur. This would result in the callers of the virPCIFile, virPCIDriverFile, and virPCIDriverDir having an error. Rather than try to add sa_assert()'s for each, adjust the calls and callers to return the buffer For the fourth patch, the strtok_r call expects that the first call will have a non-NULL value for the first parameter and subsequent calls over the same string would pass a NULL value in the first parameter and a non-NULL parameter in the third parameter to be used as the "point" in the string to continue looking for the token. However, Coverity doesn't realize this and thus flags the strtok_r call with a possible forward NULL dereference because we initialize the third parameter to NULL. By adding an 'sa_assert' for what is the first argument lets Coverity know we know what we're doing. Additionally, VIR_STRDUP could return a NULL string and a zero return, the assertion in openvz_conf.c is on the passed value to be scanned. The fifth patch is perhaps the only one fixing a real issue; however, it's been around since 1.2.11, so perhaps it's a less traveled path. The sixth patch seems to be a false positive, but since Coverity doesn't make the connection between nstack and stack, it's just as safe to add the protection in the Free routine against a strange path being hit. For the last patch, this is a false positive, but it also shows up in the 7.5.1 coverity build: http://jenkins-virt.usersys.redhat.com/job/libvirt-coverity/128/ Essentially the issue is that virResizeN can "return 0;" prior to the virExpandN and that causes Coverity some angst since it would then be possible to not have anything returned in "*ret" which would cause a NULL dereference. Stepping through the logic has no path in which that could happen. In order to handle this, rather than use VIR_RESIZE_N for 'n' times through the loop, let's first count the matches, use VIR_ALLOC_N, and then rerun the same loop filling in each address as before. The difference being 'n' VIR_RESIZE_N versus 2*'n' STREQ calls - perhaps a small wash performance wise. John Ferlan (7): util: Resolve Coverity FORWARD_NULL util: Resolve Coverity FORWARD_NULL util: Resolve Coverity FORWARD_NULL Avoid Coverity FORWARD_NULL prior to strtok_r calls phyp: Resolve Coverity FORWARD_NULL util: Resolve Coverity FORWARD_NULL util: Avoid Coverity FORWARD_NULL src/esx/esx_vi.c | 1 + src/libxl/libxl_conf.c | 1 + src/openvz/openvz_conf.c | 2 ++ src/phyp/phyp_driver.c | 3 +-- src/util/virdbus.c | 4 +++ src/util/virpci.c | 67 ++++++++++++++++++++++++----------------------- src/util/virtypedparam.c | 14 ++++++---- src/xenapi/xenapi_utils.c | 1 + 8 files changed, 53 insertions(+), 40 deletions(-) -- 2.1.0

3 19

[libvirt] [PATCH 0/2] some qemu_driver cleanups
by Pavel Hrdina 03 Jul '15

03 Jul '15

Pavel Hrdina (2): qemu_driver: live/config checks cleanup qemu_driver: remove duplicate code src/qemu/qemu_driver.c | 85 ++++++-------------------------------------------- 1 file changed, 9 insertions(+), 76 deletions(-) -- 2.4.5

2 5

[libvirt] Avoid XSS vulnerability on the search engine
by Daniel Veillard 03 Jul '15

03 Jul '15

Raised by https://www.xssposed.org/incidents/69566/ Need to escape the user provided query before displaying it back I pushed immediately as this was made public, Daniel diff --git a/docs/search.php.code.in b/docs/search.php.code.in index df25cd6..84f8759 100644 --- a/docs/search.php.code.in +++ b/docs/search.php.code.in @@ -13,7 +13,7 @@ <form action="<?php echo $_SERVER['PHP_SELF'], "?query=", rawurlencode($query) ?>" enctype="application/x-www-form-urlencoded" method="get"> - <input name="query" type="text" size="50" value="<?php echo $query?>"/> + <input name="query" type="text" size="50" value="<?php echo htmlspecialchars($query, ENT_QUOTES, 'UTF-8')?>"/> <select name="scope"> <option value="any">Search All</option> <option value="API" <?php if ($scope == 'API') print "selected='selected'"?>>Only the APIs</option> -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] [PATCH] Fix nodeinfo output on PPC64 KVM hosts
by Shivaprasad G Bhat 03 Jul '15

03 Jul '15

The nodeinfo is reporting incorrect number of cpus and incorrect host topology on PPC64 KVM hosts. The KVM hypervisor on PPC64 needs only the primary thread in a core to be online, and the secondaries offlined. While scheduling a guest in, the kvm scheduler wakes up the secondaries to run in guest context. The host scheduling of the guests happen at the core level(as only primary thread is online). The kvm scheduler exploits as many threads of the core as needed by guest. Further, starting POWER8, the processor allows splitting a physical core into multiple subcores with 2 or 4 threads each. Again, only the primary thread in a subcore is online in the host. The KVM-PPC scheduler allows guests to exploit all the offline threads in the subcore, by bringing them online when needed. (Kernel patches on split-core http://www.spinics.net/lists/kvm-ppc/msg09121.html) Recently with dynamic micro-threading changes in ppc-kvm, makes sure to utilize all the offline cpus across guests, and across guests with different cpu topologies. (https://www.mail-archive.com/kvm@vger.kernel.org/msg115978.html) Since the offline cpus are brought online in the guest context, it is safe to count them as online. Nodeinfo today discounts these offline cpus from cpu count/topology calclulation, and the nodeinfo output is not of any help and the host appears overcommited when it is actually not. The patch carefully counts those offline threads whose primary threads are online. The host topology displayed by the nodeinfo is also fixed when the host is in valid kvm state. Test results with and without fix: http://ur1.ca/mx25y Signed-off-by: Shivaprasad G Bhat <sbhat(a)linux.vnet.ibm.com> --- src/nodeinfo.c | 85 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 85 insertions(+) diff --git a/src/nodeinfo.c b/src/nodeinfo.c index 2fafe2d..1a27080 100644 --- a/src/nodeinfo.c +++ b/src/nodeinfo.c @@ -32,6 +32,8 @@ #include <sys/utsname.h> #include <sched.h> #include "conf/domain_conf.h" +#include <fcntl.h> +#include <sys/ioctl.h> #if defined(__FreeBSD__) || defined(__APPLE__) # include <sys/time.h> @@ -428,6 +430,10 @@ virNodeParseNode(const char *node, unsigned int cpu; int online; int direrr; + int kvmfd = -1; + int lastonline; + int threads_per_subcore = 1; + bool valid_ppc64_kvmhost_mode = false; *threads = 0; *cores = 0; @@ -464,6 +470,66 @@ virNodeParseNode(const char *node, sock_max++; + if (ARCH_IS_PPC64(arch)) { + /* PPC-KVM needs the secondary threads of a core to be offline on the + * host. The kvm schedular brings the secondary threads online in the + * guest context. Moreover, P8 processor has split-core capability + * where, there can be 1,2 or 4 subcores per core. The primaries of the + * subcores alone will be online on the host for a subcore in the + * host. Even though the actual threads per core for P8 processor is 8, + * depending on the subcores_per_core = 1, 2 or 4, the threads per + * subcore will vary accordingly to 8, 4 and 2 repectively. + * So, On host threads_per_core what is arrived at from sysfs in the + * current logic is actually the subcores_per_core. Threads per subcore + * can only be obtained from the kvm device. For example, on P8 wih 1 + * core having 8 threads, sub_cores_percore=4, the threads 0,2,4 & 6 + * will be online. The sysfs reflects this and in the current logic + * variable 'threads' will be 4 which is nothing but subcores_per_core. + * If the user tampers the cpu online/offline states using chcpu or other + * means, then it is an unsupported configuration for kvm. + * The code below tries to keep in mind + * - when the libvirtd is run inside a KVM guest or Phyp based guest. + * - Or on the kvm host where user manually tampers the cpu states to + * offline/online randomly. + */ +# if HAVE_LINUX_KVM_H +# include <linux/kvm.h> + kvmfd = open("/dev/kvm", O_RDONLY); + if (kvmfd >= 0) { +# ifdef KVM_CAP_PPC_SMT + valid_ppc64_kvmhost_mode = true; + /* For Phyp and KVM based guests the ioctl for KVM_CAP_PPC_SMT + * returns zero and both primary and secondary threads will be + * online. Dont try to alter or interpret anything here. + */ + threads_per_subcore = ioctl(kvmfd, KVM_CHECK_EXTENSION, KVM_CAP_PPC_SMT); + if (threads_per_subcore == 0) + valid_ppc64_kvmhost_mode = false; +# endif + } + VIR_FORCE_CLOSE(kvmfd); +# endif + rewinddir(cpudir); + lastonline = -1; + while (valid_ppc64_kvmhost_mode && + ((direrr = virDirRead(cpudir, &cpudirent, node)) > 0)) { + if (sscanf(cpudirent->d_name, "cpu%u", &cpu) != 1) + continue; + if ((online = virNodeGetCpuValue(node, cpu, "online", 1)) < 0) + goto cleanup; + + if (online) { + if (lastonline != -1 && + (cpu - lastonline) < threads_per_subcore) { + valid_ppc64_kvmhost_mode = false; /* if any of secondaries + * online */ + break; + } + lastonline = cpu; + } + } + } + /* allocate cpu maps for each socket */ if (VIR_ALLOC_N(core_maps, sock_max) < 0) goto cleanup; @@ -473,6 +539,7 @@ virNodeParseNode(const char *node, /* iterate over all CPU's in the node */ rewinddir(cpudir); + lastonline = -1; while ((direrr = virDirRead(cpudir, &cpudirent, node)) > 0) { if (sscanf(cpudirent->d_name, "cpu%u", &cpu) != 1) continue; @@ -480,6 +547,17 @@ virNodeParseNode(const char *node, if ((online = virNodeGetCpuValue(node, cpu, "online", 1)) < 0) goto cleanup; + if (ARCH_IS_PPC64(arch) && valid_ppc64_kvmhost_mode) { + if (online) { + lastonline = cpu; + } else if (lastonline != -1 && + (cpu-lastonline) < threads_per_subcore) { + processors++; /* Count only those secondaries whose primary + subcore is online */ + continue; + } + } + if (!online) { (*offline)++; continue; @@ -528,6 +606,13 @@ virNodeParseNode(const char *node, *cores = core; } + if (ARCH_IS_PPC64(arch) && valid_ppc64_kvmhost_mode) { + /* The actual host threads per core is + * multiple of the subcores_per_core(i.e variable *threads in this case) + * and threads_per_subcore. + */ + *threads = *threads * threads_per_subcore; + } ret = processors; cleanup:

3 4

[libvirt] [PATCH] virsh: report error if vcpu number exceed the guest maxvcpu number
by Luyao Huang 03 Jul '15

03 Jul '15

If usr pass a vcpu which exceed guest maxvcpu number, virsh client will only output an header like this: # virsh vcpupin test3 1000 VCPU: CPU Affinity ---------------------------------- After this patch: # virsh vcpupin test3 1000 error: vcpu 1000 is out of range of cpu count 2 Signed-off-by: Luyao Huang <lhuang(a)redhat.com> --- tools/virsh-domain.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 27d62e9..681fc1a 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -6497,6 +6497,11 @@ cmdVcpuPin(vshControl *ctl, const vshCmd *cmd) goto cleanup; } + if (got_vcpu && vcpu >= ncpus) { + vshError(ctl, _("vcpu %d is out of range of cpu count %d"), vcpu, ncpus); + goto cleanup; + } + cpumaplen = VIR_CPU_MAPLEN(maxcpu); cpumap = vshMalloc(ctl, ncpus * cpumaplen); if ((ncpus = virDomainGetVcpuPinInfo(dom, ncpus, cpumap, -- 1.8.3.1

4 5

[libvirt] Request for libvirt wiki account creation
by Prerna 03 Jul '15

03 Jul '15

Hi, I am interested in contributing some content to the libvirt wiki; and so I need a libvirt wiki account. Could you pls create an account with following credentials: username : prerna Thanks, Prerna Saxena

2 2

[libvirt] Which symbols can be used in file paths in libvirt's XMLs?
by Dmitry Guryanov 02 Jul '15

02 Jul '15

Hello, There is an absFilePatch type in docs/schemas/basictypes.rng rng schema: <define name="absFilePath"> <data type="string"> <param name="pattern">/[a-zA-Z0-9_\.\+\-\\&"'<>/%,:]+</param> </data> </define> There are quite few symbols in this set of the ones, which linux allows to have in file paths. For example spaces or curly braces are not allowed. There are a lot of elements of this type in other rng schems, for example: <define name="diskSourceFile"> <optional> <attribute name="type"> <value>file</value> </attribute> </optional> <interleave> <optional> <element name="source"> <optional> <attribute name="file"> <ref name="absFilePath"/> </attribute> There is no checks in libvirt if the the xml, given to, for example, virDomainDefineXML function conforms to this schema. I've added a disk to the domain with curly braces in path and there were no errors: <disk type='file' device='disk'> <driver name='qemu' type='qcow2'/> <source file='/home/libvirt/{123}.qcow2'/> <target dev='hda' bus='ide'/> <address type='drive' controller='0' bus='0' target='0' unit='0'/> </disk> The domain was successfully defined and virsh dumpxml shows this path in output. So the question is, where did this path pattern come from? Is it possible to use file paths with another symbols or there will be some problems? -- Dmitry Guryanov

2 2

[libvirt] [PATCHv3] virt-aa-helper: Fix permissions for vhost-user socket files
by Michal Dubiel 02 Jul '15

02 Jul '15

QEMU working in vhost-user mode communicates with the other end (i.e. some virtual router application) via unix domain sockets. This requires that permissions for the socket files are correctly written into /etc/apparmor.d/libvirt/libvirt-UUID.files. Signed-off-by: Michal Dubiel <md(a)semihalf.com> --- Changes since v2: - Removed curly braces from one line 'if' block (syntax-check claims) src/security/virt-aa-helper.c | 28 +++++++++++++--------------- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 35423b5..13f8a6a 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -32,7 +32,6 @@ #include <unistd.h> #include <errno.h> #include <sys/types.h> -#include <sys/stat.h> #include <fcntl.h> #include <getopt.h> #include <sys/utsname.h> @@ -542,7 +541,6 @@ array_starts_with(const char *str, const char * const *arr, const long size) static int valid_path(const char *path, const bool readonly) { - struct stat sb; int npaths, opaths; const char * const restricted[] = { "/bin/", @@ -590,20 +588,8 @@ valid_path(const char *path, const bool readonly) if (STRNEQLEN(path, "/", 1)) return 1; - if (!virFileExists(path)) { + if (!virFileExists(path)) vah_warning(_("path does not exist, skipping file type checks")); - } else { - if (stat(path, &sb) == -1) - return -1; - - switch (sb.st_mode & S_IFMT) { - case S_IFSOCK: - return 1; - break; - default: - break; - } - } opaths = sizeof(override)/sizeof(*(override)); @@ -1101,6 +1087,18 @@ get_files(vahControl * ctl) } } + for (i = 0; i < ctl->def->nnets; i++) { + if (ctl->def->nets[i] && + ctl->def->nets[i]->type == VIR_DOMAIN_NET_TYPE_VHOSTUSER && + ctl->def->nets[i]->data.vhostuser) { + virDomainChrSourceDefPtr vhu = ctl->def->nets[i]->data.vhostuser; + + if (vah_add_file_chardev(&buf, vhu->data.nix.path, "rw", + vhu->type) != 0) + goto cleanup; + } + } + if (ctl->def->virtType == VIR_DOMAIN_VIRT_KVM) { for (i = 0; i < ctl->def->nnets; i++) { virDomainNetDefPtr net = ctl->def->nets[i]; -- 1.9.1

3 2

[libvirt] [PATCH 00/20] cpu_map.xml: Make CPU definitions easier to review
by Jiri Denemark 02 Jul '15

02 Jul '15

Inheritance among CPU model is cool but it makes reviewing CPU model definitions and comparing them to CPU models from QEMU rather hard and unpleasant. Let's define all CPU models from scratch with a sorted list of features. Jiri Denemark (20): cpu_map.xml: Sort features in x86 CPU models cpu_map.xml: Expand 486 CPU model cpu_map.xml: Expand pentium CPU model cpu_map.xml: Expand pentium2 CPU model cpu_map.xml: Expand pentiumpro CPU model cpu_map.xml: Expand coreduo CPU model cpu_map.xml: Expand n270 CPU model cpu_map.xml: Expand qemu32 CPU model cpu_map.xml: Expand kvm32 CPU model cpu_map.xml: Expand cpu64-rhel5 CPU model cpu_map.xml: Expand kvm64 CPU model cpu_map.xml: Expand Conroe CPU model cpu_map.xml: Expand Penryn CPU model cpu_map.xml: Expand Nehalem CPU model cpu_map.xml: Expand Westmere CPU model cpu_map.xml: Expand SandyBridge CPU model cpu_map.xml: Expand Haswell-noTSX CPU model cpu_map.xml: Expand Opteron_G1 CPU model cpu_map.xml: Expand Opteron_G2 CPU model cpu_map.xml: Expand Opteron_G4 CPU model src/cpu/cpu_map.xml | 829 +++++++++++++++++++++++++++++++++++++++++++++------- 1 file changed, 729 insertions(+), 100 deletions(-) -- 2.4.4

3 49

[libvirt] How to define QEMU/SMBIOS Attributes in virsh
by Holger Schranz 02 Jul '15

02 Jul '15

Hello, I have a "request for Help" please. Myself: I'm a native german language speaker and I' work with qemu/virsh since 6 months now. At the moment I try to define/configure qemu/smbios attributes in a virsh xml-file. My current problem: I need to configure two on-board lan elements. Thanks to Gerd Hoffmann (Qemu group). He gave me the hint for smbios/acpi configuration. For this configuration I need a type 41 record. I found on http://libvirt.org some descriptions for smbios but only for type 0 and 1. In qemu the solution is available: [Qemu-devel] [PATCH 2/2] smbios: Allow device ID instead of PCI address http://lists.gnu.org/archive/html/qemu-devel/2013-11/msg02350.html @@ -1336,9 +1338,10 @@ Specify SMBIOS type 0 fields Specify SMBIOS type 1 fields @item -smbios type=41,address@hidden,address@hidden,address@hidden,status=on|off][,address@hidden|n}] address@hidden -smbios type=41,address@hidden,address@hidden,address@hidden,status=on|off][,address@hidden|n}] Add SMBIOS type 41 fields (Onboard Devices Extended Information). Could be specified multiple times for different devices. Mandatory options are address@hidden in form "[[<domain>:]<bus>:]<slot>.<func>" and address@hidden in form "[[<domain>:]<bus>:]<slot>.<func>" or @option{id}, and @option{instance} number. @option{instance} shoud be in range [1, 255] and should be unique within specified @option{device-type}. @option{designation} is an optional string that somehow designates device. @option{status} is a device @@ -1365,6 +1368,9 @@ qemu-i386 \ -netdev user,id=hostnet0 \ -device e1000,netdev=hostnet0,id=net0,bus=pci.0,addr=0x1f \ -smbios type=41,address=00:1f.0,instance=1,designation="NIC 1",device-type=ethernet \ +-netdev user,id=hostnet1 \ +-device e1000,netdev=hostnet1,id=net1 \ +-smbios type=41,id=net1,instance=2,designation="NIC 2",device-type=ethernet \ < ... other qemu options ... > @end example So my question: How can I configure such record in a virsh xml-file please. Any help is appreciated. Holger --- Diese E-Mail wurde von Avast Antivirus-Software auf Viren geprüft. https://www.avast.com/antivirus

2 3

[libvirt] [PATCH] lxc: Don't pass a local variable address randomly
by Michal Privoznik 02 Jul '15

02 Jul '15

So, recently I was testing the LXC driver. You know, startup some domains. But to my surprise, I was not able to start a single one: virsh # start --console test error: Reconnected to the hypervisor error: Failed to start domain test error: internal error: guest failed to start: unexpected exit status 125 So I've start digging. It turns out, that in virExec(), when I printed out the @cmd, I got strange values: *(cmd->outfdptr) was certainly not valid FD number: it has random value of several millions. This obviously made prepareStdFd(childout, STDOUT_FILENO) fail (line 611). But outfdptr is set in virCommandSetOutputFD(). The only place within LXC driver where the function is called is in virLXCProcessBuildControllerCmd(). If you take a closer look at the function it looks like this: static virCommandPtr virLXCProcessBuildControllerCmd(virLXCDriverPtr driver, .. int logfd, const char *pidfile) { ... virCommandSetOutputFD(cmd, &logfd); virCommandSetErrorFD(cmd, &logfd); ... } Yes, you guessed it. @logfd is passed into the function by value. However, in the function we try to get its address (an address of a local variable) which is no longer valid once function is finished and stack is cleaned. Therefore when cmd->outfdptr is evaluated at any point after this function, we may get a random number, depending on what's currently on the stack. Of course, this may work sometimes too - it depends on the compiler how it arranges the code, when the stack is wiped out. In order to fix this, lets pass a pointer to @logfd instead of figuring out (wrong) its value in a function. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- I'd love to target this into the current release - in my case LXC driver is unusable without this patch. There might be other users affected too. src/lxc/lxc_process.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c index 6c23a0b..2bdce3b 100644 --- a/src/lxc/lxc_process.c +++ b/src/lxc/lxc_process.c @@ -750,7 +750,7 @@ virLXCProcessBuildControllerCmd(virLXCDriverPtr driver, int *files, size_t nfiles, int handshakefd, - int logfd, + int * const logfd, const char *pidfile) { size_t i; @@ -820,8 +820,8 @@ virLXCProcessBuildControllerCmd(virLXCDriverPtr driver, virCommandPassFD(cmd, handshakefd, 0); virCommandDaemonize(cmd); virCommandSetPidFile(cmd, pidfile); - virCommandSetOutputFD(cmd, &logfd); - virCommandSetErrorFD(cmd, &logfd); + virCommandSetOutputFD(cmd, logfd); + virCommandSetErrorFD(cmd, logfd); /* So we can pause before exec'ing the controller to * write the live domain status XML with the PID */ virCommandRequireHandshake(cmd); @@ -1208,7 +1208,7 @@ int virLXCProcessStart(virConnectPtr conn, ttyFDs, nttyFDs, files, nfiles, handshakefds[1], - logfd, + &logfd, pidfile))) goto cleanup; -- 2.3.6

4 4

[libvirt] Release of libvirt-1.2.17
by Daniel Veillard 02 Jul '15

02 Jul '15

So as planned I tagged it in git, development is open again, I signed tarballs and rpms, they are at the usual place: ftp://libvirt.org/libvirt/ I also made a libvirt-python-1.2.17 release which you can find at ftp://libvirt.org/libvirt/python/ this is a rather large release, even if the Admin APIs didn't fully made it there is 375 commits, lot of refactoring and code hardening, and a fair amount of pure bug fixes: Features: - numerous improvements and refactoring of the parallels driver(Maxim Nestratov) - hardening of vcpu code (Peter Krempa) - hardening of migration code (Jiri Denemark) Documentation: - Fix typo incomaptible -> incompatible (Andrea Bolognani) - docs: Clarification for when allowed to use 'lun' for "volume" (John Ferlan) - docs: document when pcie-root/dmi-to-pci-bridge support was added (Laine Stump) - docs: Fix trivial copy-paste error (Martin Kletzander) - docs: Properly mark acl.html dependencies (Michal Privoznik) - docs: Correct typos in scsi hostdev and address elements (Eric Farman) - docs: Fix XML schema handling of LUN address in hostdev tag (Eric Farman) - virNetSocketRemoveIOCallback: Be explicit about unref (Michal Privoznik) - man: clarify usage of virsh blockcopy with --xml (Ján Tomko) - docs: Clarify that attribute name is not used for vhostuser (Maxime Leroy) - maint: document use of zanata for translations (Eric Blake) - qemu: Capitalize "storage" in qemuDomainAttachUSBMassStorageDevice() (Andrea Bolognani) - docs: php: remove reference to Red Hat (Ján Tomko) - monitor: Move documentation for qemuMonitorGetBalloonInfo (Peter Krempa) Portability: - admin: Fix mingw build by reordering includes (Martin Kletzander) - util: process: fix build on FreeBSD (Roman Bogorodskiy) - util: Properly return error from virGetUserID and virGetGroupID stubs (Peter Krempa) - build: silence ar warnings on rawhide (Eric Blake) - util: process: @pid in virProcessSetAffinity's BSD impl is not unused (Peter Krempa) - libxl: load on FreeBSD (Roman Bogorodskiy) Bug Fixes: - phyp: Resolve Coverity FORWARD_NULL (John Ferlan) - util: Resolve Coverity FORWARD_NULL (John Ferlan) - util: Resolve Coverity FORWARD_NULL (John Ferlan) - util: Resolve Coverity FORWARD_NULL (John Ferlan) - lxc: Don't pass a local variable address randomly (Michal Privoznik) - qemu: Resolve Coverity DEADCODE (John Ferlan) - qemu: Audit memory size with memory hotplug operations (Peter Krempa) - qemu: Avoid using ".(null)" in UNIX socket path (Jiri Denemark) - qemu: agent: Don't automatically disable CPU0 via guest agent (Peter Krempa) - qemu: End job even if exiting monitor after OpenGraphics(FD) fails (Luyao Huang) - qemu: properly free addresses on non-serial chardev unplug (Ján Tomko) - qemu: fix address allocation on chardev attach (Luyao Huang) - libxl: Set def->vcpus after successfully modifying live vcpu count (Jim Fehlig) - libxl: don't remove persistent domain on start failure (Jim Fehlig) - libxl: don't overwrite domain state from statedir config (Jim Fehlig) - qemu: Add missing on_crash lifecycle type (John Ferlan) - Use the correct symbol for 'onCrash' (John Ferlan) - mpath: Don't allow more than one mpath pool at a time (John Ferlan) - mpath: Update path in CheckPool function (John Ferlan) - conf: Validate disk lun using correct types (John Ferlan) - Storage: Introduce shadow vol for refresh while the main vol builds. (Prerna Saxena) - conf: storage: Fix duplicate check for gluster pools (Peter Krempa) - qemu: event: Properly handle spice events (Peter Krempa) - Revert "Introduce QEMU_CAPS_ARM_VIRT_PCI" (Peter Krempa) - qemu: Close the agent connection only on agent channel events (Peter Krempa) - storage: Set correct vol->type at VolCreate (John Ferlan) - qemu: Fix assignment of the default spicevmc channel name (Jiri Denemark) - qemu: Resolve Coverity RESOURCE_LEAK (John Ferlan) - test: qemu: Make sure that wr_highest_offset_valid gets set properly (Peter Krempa) - vz: Fix build after recent commit (Peter Krempa) - qemuBuildMemoryBackendStr: Honour passed @pagesize (Michal Privoznik) - qemuBuildMemoryBackendStr: Fix hugepages lookup process (Michal Privoznik) - conf: Format scheduler priority when it is zero (Luyao Huang) - qemu: Avoid removing persistent config if migration fails (Luyao Huang) - scsi: Force error for SCSI pools on virStorageBackendSCSIFindLUs failure (John Ferlan) - conf: Enforce scheduler name when parsing XML (Peter Krempa) - qemu: caps: Fix syntax-check failure in version based capabilities (Peter Krempa) - libxl: avoid freeing an uninitialised bitmap (Ian Campbell) - virNetServerServiceClose: Don't leak sockets (Michal Privoznik) - virNetSocket: Fix @watch corner case (Michal Privoznik) - daemonSetupNetworking: Don't leak services (Michal Privoznik) - scsi: Adjust return status from getBlockDevice (John Ferlan) - qemuMigrationDriveMirror: Force raw format for NBD (Michal Privoznik) - qemu: Jump to correct label in qemuDomainPinIOThread (Peter Krempa) - conf: Fix virDomainObjGetDefs when getting persistent config on a live vm (Peter Krempa) - rpc: Actually increase reference count on @srv in virNetDaemonAddServer (Peter Krempa) - parallels: Fix false error messages in libvirt log (Mikhail Feoktistov) - parallels: Fix initialization of buflen variable in each loop iteration (Mikhail Feoktistov) - nodedev: update netdev feature bits before each dumpxml (Laine Stump) - tests: Follow virnetserver to virnetdaemon transition (Michal Privoznik) - daemon: Distribute admin_server.h (Michal Privoznik) - daemon/Makefile: Add forgotten dependency (Michal Privoznik) - util: virfile: Fix 'unknown cause' error if NFS mount point creation fails (Erik Skultety) - util: Fix Coverity RESOURCE_LEAK (John Ferlan) - storage: Generate correct parameters for CIFS (John Ferlan) - rpc: Fix possible crash when MDNSAddEntry fails (Martin Kletzander) - qemu: emulatorpin: Don't reset pinning when pinning to all cpus (Peter Krempa) - storage: Disallow wiping an extended disk partition (John Ferlan) - storage: Need to set secrettype for direct iscsi disk volume (John Ferlan) - scsi: Need to translate disk source pool in config attach path (John Ferlan) - network: escape quotes for dsmasq conf contents (Shivaprasad G Bhat) - virsh: change-media: Fix behavior with --update without a source (Peter Krempa) - rpc: Fix reference counting around virNetSocketAddIOCallback (Daniel P. Berrange) - rpc: Don't use unrelated value as privateData of client (Daniel P. Berrange) - mdns: Set error when failing due to missing avahi (Martin Kletzander) - qemu: Update balloon info only if job is allowed (Peter Krempa) - conf: Fix mistakes in pointer usage in virDomainObjGetDefs (Peter Krempa) - check if console/channel PTY is null before attempting to open (Shivaprasad G Bhat) - virnetdev: fix moving of 802.11 phys (Lubomir Rintel) - util: process: Refactor and fix virProcessSetAffinity (Peter Krempa) - util: Clear output broadcast address before filling it in (Martin Kletzander) - virsh: Fix Ctrl-C behavior when watching a job (Jiri Denemark) - libxl: Unbreak vcpu pinning (Peter Krempa) - qemu: Fix possible crash in qemuProcessSetVcpuAffinities (Peter Krempa) - qemu: Do not release device address on successful RNG attach (Luyao Huang) - qemu: Need to return status of RNG device removal (Luyao Huang) - test: fix IP address range failure test (Laine Stump) - storage: RBD: do not return error when deleting non-existent volume (Erik Skultety) - storage: Don't update volume objs list before we successfully create one (Erik Skultety) - nwfilter: Fix sscanf off-by-one error in virNWFilterSnoopLeaseFileLoad (Erik Skultety) - virsh: Fix printing of XML for pool-create-as (John Ferlan) Improvements: - conf: qemu: Taint VMs using custom device tree blob (Peter Krempa) - conf: audit: Audit physical memory size rather than balloon request (Peter Krempa) - libxl: honor domainGetXMLDesc() --inactive flag (Jim Fehlig) - qemu: event: Clean up VNC monitor handling (Peter Krempa) - qemuxml2argv: Remove Haswell CPU from unrelated tests (Jiri Denemark) - Revert "Change livbirt version to 1.3.0 for the next release" (Martin Kletzander) - Temporarily disable admin API (Martin Kletzander) - spec: Remove admin package specification (Martin Kletzander) - qemu: ignore assumptions about hotplug requirement when address is from config (Laine Stump) - qemu: always permit PCI devices to be manually assigned to a PCIe bus (Laine Stump) - qemu: refactor qemuBuildControllerDevStr to eliminate future duplicate code (Laine Stump) - qemu: monitor: Remove qemuMonitorGetBlockExtent (Peter Krempa) - qemu: Refactor qemuDomainGetBlockInfo (Peter Krempa) - qemu: monitor: Open-code retrieval of wr_highest_offset (Peter Krempa) - internal: Introduce virCheckNonEmptyStringArgGoto and reuse it (Peter Krempa) - vz: add memory statistics (Nikolay Shirokovskiy) - vz: add vcpu statistics (Nikolay Shirokovskiy) - vz: cleanup, make in par net device lookup functions (Nikolay Shirokovskiy) - vz: add net dev statistiscs (Nikolay Shirokovskiy) - docs: Don't keep temporary files around (Michal Privoznik) - test: Refactor testNodeGetCPUMap (Peter Krempa) - test: Refactor vcpu pinning and vcpu info retrieval (Peter Krempa) - test: Refactor testDomainSetVcpusFlags (Peter Krempa) - test: Refactor test driver domain object retrieval (Peter Krempa) - test: Drop locked access to testDriver->domains (Peter Krempa) - test: Finalize removal of locking from driver->eventState (Peter Krempa) - test: Refactor test driver event sending (Peter Krempa) - test: Use atomic access to @nextDomID in struct virTestDriver (Peter Krempa) - test: Annotate few fields of testDriver structure (Peter Krempa) - test: Extract common parts of test driver data allocation (Peter Krempa) - test: Extract code to free testDriver into testDriverFree (Peter Krempa) - test: turn 'defaultConn' into a pointer (Peter Krempa) - test: Rename testConn to testDriver (Peter Krempa) - vz: Adapt to driver rename (Michal Privoznik) - json: enhance parser test (Eric Blake) - json: even stricter trailing garbage detection (Eric Blake) - json: reject trailing garbage (Eric Blake) - json: reject javascript comments (Eric Blake) - json: cope with older yajl semantics (Eric Blake) - vz: implementation of attach/detach network devices (Mikhail Feoktistov) - Test for the new watchdog model diag288 (Boris Fiuczynski) - Support for the new watchdog model diag288 (Boris Fiuczynski) - Test for the new watchdog action inject-nmi (Boris Fiuczynski) - Support for a new watchdog action inject-nmi (Boris Fiuczynski) - vircapstest: Properly report error for failed tests (Michal Privoznik) - conf: Adjust invalid secrettype setting during parse (John Ferlan) - conf: improve the way we format blkiotune and cputune (Luyao Huang) - Improve some errors for openconsole/channel (Luyao Huang) - storage: Force setting of disk format type (John Ferlan) - docs: Adjust Disk storage rng (John Ferlan) - Convert SCSI logical unit from unsigned int to unsigned long long (Eric Farman) - Print SCSI address attributes bus, target, unit as unsigned integer (Eric Farman) - Read SCSI address attributes bus, target, unit as positive integer (Eric Farman) - qemu: simplify json parsing (Eric Blake) - json: make it easier to type-check when getting from object (Eric Blake) - json: fully parse input string (Eric Blake) - test: Switch to reference counting with testDomObjFromDomain (Peter Krempa) - test: Reuse virDomainObjGetOneDef in testDomainGetVcpusFlags (Peter Krempa) - virsh: blockcopy: Report error if the copy job fails (Peter Krempa) - Introduce QEMU_CAPS_ARM_VIRT_PCI (Pavel Fedin) - update sheepdog client] update sheepdog client path (Vasiliy Tolstov) - qemu: cancel drive mirrors when p2p connection breaks (Jiri Denemark) - qemu: Refactor qemuMigrationWaitForCompletion (Jiri Denemark) - qemu: Don't pass redundant job name around (Jiri Denemark) - qemu: Refactor qemuMigrationUpdateJobStatus (Jiri Denemark) - qemu: Refactor qemuDomainGetJob{Info,Stats} (Jiri Denemark) - qemu: Do not poll for spice migration status (Jiri Denemark) - qemu_monitor: Wire up SPICE_MIGRATE_COMPLETED event (Jiri Denemark) - qemu: Use domain condition for asyncAbort (Jiri Denemark) - qemu: Cancel disk mirrors after libvirtd restart (Jiri Denemark) - qemu: Refactor qemuMonitorBlockJobInfo (Jiri Denemark) - qemu: Make qemuMigrationCancelDriveMirror usable without async job (Jiri Denemark) - Pass domain object to private data formatter/parser (Jiri Denemark) - qemu: Don't mess with disk->mirrorState (Jiri Denemark) - qemu: Abort migration early if disk mirror failed (Jiri Denemark) - qemu: Cancel storage migration in parallel (Jiri Denemark) - qemu: Use domain condition for synchronous block jobs (Jiri Denemark) - qemu: Properly report failed migration (Jiri Denemark) - qemu: Introduce qemuBlockJobUpdate (Jiri Denemark) - conf: Introduce per-domain condition variable (Jiri Denemark) - lib: setvcpus: Remove bogus flag check (Peter Krempa) - virsh: selective block device migration (Pavel Boldin) - qemu: migration: selective block device migration (Pavel Boldin) - util: add virTypedParamsAddStringList (Pavel Boldin) - util: virTypedParams{Filter,GetStringList} (Pavel Boldin) - util: multi-value parameters in virTypedParamsAdd* (Pavel Boldin) - util: multi-value virTypedParameter (Pavel Boldin) - virDomainDiskGetSource: Mark passed disk as 'const' (Michal Privoznik) - conf: Move vcpu info parsing code into a separate function (Peter Krempa) - qemu: 'privileged' flag is not really configuration (Peter Krempa) - qemu: Reuse virDomainObjGetDefs in qemuDomainGetMemoryParameters (Peter Krempa) - qemu: Refactor qemuDomainGetMemoryParameters (Peter Krempa) - qemu: Refactor qemuDomainSetNumaParameters (Peter Krempa) - qemu: Simplify qemuDomainSetInterfaceParameters by using virDomainObjGetDefs (Peter Krempa) - qemu: Simplify qemuDomainGetVcpusFlags by using virDomainObjGetOneDef (Peter Krempa) - qemu: Simplify qemuDomainGetEmulatorPinInfo by using virDomainObjGetOneDef (Peter Krempa) - qemu: Simplify qemuDomainGetVcpuPinInfo by using virDomainObjGetOneDef (Peter Krempa) - qemu: Simplify qemuDomainGetNumaParameters by using virDomainObjGetOneDef (Peter Krempa) - qemu: Simplify qemuDomainGetInterfaceParameters by using virDomainObjGetOneDef (Peter Krempa) - conf: Introduce helper to help getting correct def for getter functions (Peter Krempa) - qemu: implement address for isa-serial (James Cowgill) - qemu: Add a check for slot and base dimm address conflicts (Luyao Huang) - daemon: Add the admin service to the admin server only if it was allocated (Peter Krempa) - remove redundant condition (Ján Tomko) - virSysinfo: Introduce SMBIOS type 2 support (Michal Privoznik) - qemu: Report all supported machine types in capabilities (Jiri Denemark) - tests: Sort EXTRA_DIST in the Makefile (Michal Privoznik) - daemon: Don't just include admin RPC (Michal Privoznik) - parallels: substitute parallels with vz spec file and Makefile (Maxim Nestratov) - parallels: rename all parallels files and driver directory to vz (Maxim Nestratov) - parallels: substitute parallels with vz in strings (Maxim Nestratov) - parallels: change parallels prefixes to vz (Maxim Nestratov) - virfile: virDirCreate: Insert blank lines to assure slightly better readability (Erik Skultety) - util: virDirCreate: Child now exits with positive errno-code (Erik Skultety) - lxc: set nosuid+nodev+noexec flags on /proc/sys mount (Eric W. Biederman) - lxc: Rename daemon to dmn (Martin Kletzander) - Revert "rpc: Add virNetServerGetNClients" (Martin Kletzander) - Revert "admin: Add virAdmHello function" (Martin Kletzander) - Change livbirt version to 1.3.0 for the next release (Martin Kletzander) - Example virt-admin (Martin Kletzander) - admin: Add virAdmHello function (Martin Kletzander) - rpc: Add virNetServerGetNClients (Martin Kletzander) - Add support for admin API in libvirt daemon (Martin Kletzander) - Add configuration options for permissions on daemon's admin socket (Martin Kletzander) - Add XML files with admin API specification (Martin Kletzander) - Add libvirt-admin library (Martin Kletzander) - Add admin error domain (Martin Kletzander) - Build client headers for admin protocol (Martin Kletzander) - Add admin protocol (Martin Kletzander) - Teach gendispatch how to handle admin dispatching files (Martin Kletzander) - tests: Adapt virnetservertest to daemon refactor (Martin Kletzander) - Move daemon-related parts of virNetServer to virNetDaemon (Martin Kletzander) - lxc: properly clean up qemu-nbd (Cédric Bosdonnat) - Add virProcessGetPids to get all tasks of a process (Cédric Bosdonnat) - storage: Adjust command arglist for gluster (John Ferlan) - storage: Fix the schema and add tests for cifs pool (John Ferlan) - configure: Remove check for pkcheck_supports_uid (Guido Günther) - tests: Use libvirt properly with initialization and error dispatching (Martin Kletzander) - Generate JSON with mDNS entries only when built --with-avahi (Martin Kletzander) - build: Remove unnecessarily repeated rules for syms -> def (Martin Kletzander) - qemu: monitor: Add memory balloon support for virtio-ccw (Boris Fiuczynski) - getOldStyleBlockDevice: Adjust formatting (Michal Privoznik) - getNewStyleBlockDevice: Adjust formatting (Michal Privoznik) - qemu caps: spell queue (Ján Tomko) - qemu: Do not support 'serial' scsi-block 'lun' devices (John Ferlan) - virCapabilitiesDomainDataLookup: Produce saner error message (Michal Privoznik) - libxl: Add timestamp to the libxl driver log. (Anthony PERARD) - qemu: update netdevs of the same mac addrs correctly (zhang bo) - virsysinfo: s/system/sysdef/ (Michal Privoznik) - cmdNetworkList: Introduce --name, --uuid, --table (Michal Privoznik) - cmdNetworkList: switch to FILTER (Michal Privoznik) - qemuBuildDriveStr: s/virBufferEscapeString/virBufferAsprintf/ (Michal Privoznik) - virQEMUCapsArch: openrisc vs or32 (Michal Privoznik) - virSysinfoDef: Exempt SYSTEM variables (Michal Privoznik) - virSysinfoDef: Exempt BIOS variables (Michal Privoznik) - tests: Distribute virnetserverdata (Michal Privoznik) - schema: use arch list from basictypes for os arch attribute (James Cowgill) - util: add virJSONValueCopy (Martin Kletzander) - qemu: add multiqueue vhost-user support (Maxime Leroy) - qemu: Add capability for vhost-user multiqueue (Martin Kletzander) - conf: Ignore multiqueue with one queue. (Martin Kletzander) - util: Make virProcessGetAffinity more readable and fix coverity warning (Peter Krempa) - apibuild: Generate macro/@string attribute (Jiri Denemark) - rpc: add testing of RPC JSON (de)serialization (Daniel P. Berrange) - rpc: add API for checking IPv4/6 availability (Daniel P. Berrange) - rpc: allow selection of TCP address family (Daniel P. Berrange) - virNumaSetPagePoolSize: Produce friendlier error message (Michal Privoznik) - logical: Fix typo in error message (John Ferlan) - conf: fix domaincommon.rng to accept network name with quotes (Shivaprasad G Bhat) - parallels: treat block devices as disks for containers (Maxim Nestratov) - parallels: report SATA bus type for container block devices disks (Maxim Nestratov) - parallels: process '/' mount point correctly for containers (Maxim Nestratov) - parallels: add isCt parameter to prlsdkGetDiskInfo and prlsdkAddDisk (Maxim Nestratov) - parallels: add block device statistics to driver (Nikolay Shirokovskiy) - qemu: caps: Advertise arm 32-on-64 KVM option (Cole Robinson) - qemu: caps: qemu-system-aarch64 supports armv7l (Cole Robinson) - qemu: command: Support arm 32-on-64 KVM with -cpu aarch64=off (Cole Robinson) - parallels: return only success from PCS event handler (Nikolay Shirokovskiy) - parallels: simplify event types discrimination (Nikolay Shirokovskiy) - utiltest: Use int8_t instead of char. (Michal Privoznik) - Turn qemuMonitorFindBalloonObjectPath into a void function (Ján Tomko) - Do not access the domain definition in qemuMonitorFindBalloonObjectPath (Ján Tomko) - Only call SetMemoryStatsPeriod for virtio memballoon (Ján Tomko) - Check for balloon model in qemuDomainSetMemoryStatsPeriod (Ján Tomko) - Only call qemuMonitorGetMemoryStats for virtio memballoon (Ján Tomko) - Invert the condition in qemuDomainMemoryStats (Ján Tomko) - Add endjob label to qemuDomainMemoryStats (Ján Tomko) - Remove path argument from qemuMonitorJSONFindLinkPath (Ján Tomko) - Introduce qemuMonitorJSONFindLinkPath (Ján Tomko) - Move qemuMonitorFindObjectPath to qemu_monitor_json (Ján Tomko) - rpc: Make virNetServerAddClient function dynamic (Daniel P. Berrange) - storage: Add check for valid FS types in checkPool callback (John Ferlan) - storage: FS backend adjust error message on error path (John Ferlan) - storage: Refactor storage pool type checks (John Ferlan) - qemu: Check for qemu capability when calling virDomainGetBlockIoTune() (Martin Kletzander) - qemu: Refactor qemuDomainSetVcpusFlags by reusing virDomainObjGetDefs (Peter Krempa) - qemu: Refactor qemuDomainGetEmulatorPinInfo by reusing virDomainObjGetDefs (Peter Krempa) - qemu: Refactor qemuDomainPinEmulator by reusing virDomainObjGetDefs (Peter Krempa) - qemu: Refactor qemuDomainGetVcpuPinInfo by reusing virDomainObjGetDefs (Peter Krempa) - qemu: Refactor qemuDomainPinVcpuFlags by reusing virDomainObjGetDefs (Peter Krempa) - qemu: Refactor qemuDomainSetBlkioParameters by reusing virDomainObjGetDefs (Peter Krempa) - qemu: Refactor qemuDomainChgIOThread by reusing virDomainObjGetDefs (Peter Krempa) - qemu: Refactor qemuDomainPinIOThread by reusing virDomainObjGetDefs (Peter Krempa) - qemu: Refactor qemuDomainGetIOThreadInfo by reusing virDomainObjGetDefs (Peter Krempa) - qemu: Refactor qemuDomainGetVcpusFlags by reusing virDomainObjGetDefs (Peter Krempa) - qemu: Refactor qemuDomainSetMemoryStatsPeriod by reusing virDomainObjGetDefs (Peter Krempa) - qemu: Refactor qemuDomainSetMemoryFlags by reusing virDomainObjGetDefs (Peter Krempa) - conf: Add new helpers to resolve virDomainModificationImpact to domain defs (Peter Krempa) - libxl: Don't remove vcpu pin definition in libxlDomainCleanup (Peter Krempa) - Revert "cputune: Support cputune for xend driver" (Peter Krempa) - qemu: libxl: vcpupin: Don't reset pinning when pinning to all pcpus (Peter Krempa) - lib: virDomainPinIOThread: Remove spurious overflow check (Peter Krempa) - conf: Store cpu count as unsigned int (Peter Krempa) - qemu: Refactor qemuDomainGetInfo (Peter Krempa) - qemu: Add helper to update domain balloon size and refactor usage places (Peter Krempa) - qemu: process: Update current balloon state to maximum on vm startup (Peter Krempa) - Always add 'console' matching the 'serial' device (Ján Tomko) - qemu: process: Refactor setup of memory ballooning (Peter Krempa) - qemu: monitor: Make qemuMonitorSetBalloon operate on unsinged long long (Peter Krempa) - util: Add macro to overflow check integer assignments (Peter Krempa) - libxl: Refactor libxlDomainGetVcpuPinInfo (Peter Krempa) - libxl: Reuse virBitmapToData in libxlDomainSetVcpuAffinities (Peter Krempa) - qemu: Refactor qemuDomainHelperGetVcpus by reusing virBitmapToDataBuf (Peter Krempa) - qemu: Reuse virBitmapToDataBuf in qemuDomainGetEmulatorPinInfo (Peter Krempa) - qemu: Use virBitmapToDataBuf in qemuDomainGetVcpuPinInfo (Peter Krempa) - util: bitmap: Add virBitmapToDataBuf that does not allocate the buffer (Peter Krempa) - conf: Move pinning information definition closer to the usage place (Peter Krempa) - conf: Refactor emulatorpin handling (Peter Krempa) - parallels: set virtType depending on driver name (Maxim Nestratov) - parallels: recommend to connect to vz:///system when connection fails (Maxim Nestratov) - parallels: increment the number of connection drivers (Maxim Nestratov) - parallels: add a new vz connection driver and hypervisor structures (Maxim Nestratov) - parallels: accept vz as a driver uri and name (Maxim Nestratov) - parallels: add new guest capabilities assigned to vz driver (Maxim Nestratov) - parallels: use newly introduced VIR_DOMAIN_VIRT_VZ (Maxim Nestratov) - parallels: introduce vz driver constant and string (Maxim Nestratov) - audit: Audit number of iothreads at domain startup (Luyao Huang) - util: report all address range errors in virSocketAddrGetRange() (Laine Stump) - network: cleanup range loop in networkDnsmasqConfContents (Laine Stump) - network: validate DHCP ranges are completely within defined network (Laine Stump) - Simplify virNodeCountThreadSiblings (Ján Tomko) - Report errors in virNodeCountThreadSiblings (Ján Tomko) - virsh: Move error messages inside vshCommandOpt*() functions (Andrea Bolognani) - virsh: Pass vshControl to all vshCommandOpt*() calls (Andrea Bolognani) - virsh: Make vshCommandOptScaledInt() use vshCommandOpt() (Andrea Bolognani) - virsh: Improve vshCommandOptTimeoutToMs() (Andrea Bolognani) - virsh: Use standard error messages in vshCommandOptTimeoutToMs() (Andrea Bolognani) - tests: Add a bunch of new tests to virsh-optparse (Andrea Bolognani) - maint: update to latest gnulib (Eric Blake) - spec: fixes for recently introduced libxl conf files (Jim Fehlig) - virsh: make negative values with vol-resize more convenient (Ján Tomko) - qemu: Automatically add <panic> element for pSeries guests. (Andrea Bolognani) - qemu: Allow panic device for pSeries guests (Andrea Bolognani) - qemu: Improve error message for missing QEMU_CAPS_DEVICE_PANIC. (Andrea Bolognani) - Post-release version bump to 1.2.17 (Daniel P. Berrange) Cleanups: - qemu: monitor: Fix indentation in qemuMonitorJSONGetOneBlockStatsInfo (Peter Krempa) - vz_utils: Reformat (Michal Privoznik) - vz_storage: Reformat (Michal Privoznik) - vz_sdk: Reformat (Michal Privoznik) - vz_network: Reformat (Michal Privoznik) - vz_driver: Reformat (Michal Privoznik) - test: Drop unused attribute @path from testDriver struct (Peter Krempa) - test: Drop useless forward declaration (Peter Krempa) - vz: fix syntax-check errors (Dmitry Guryanov) - virQEMUCapsComputeCmdFlags: Indent correctly (Michal Privoznik) - qemuMigrationBeginPhase: Fix function header indentation (Michal Privoznik) - qemu: Fix double space in error message in qemuDomainGetVcpusFlags (Peter Krempa) - libvirt.spec: Don't expect virt-admin in libvirt-admin yet (Michal Privoznik) - netserver: Remove duplicate forward declaration (Martin Kletzander) - Revert "Example virt-admin" (Martin Kletzander) - apibuild: Fix indentation (Jiri Denemark) - parallels: fix formatting errors in parallels driver (Dmitry Guryanov) - storage: Remove extraneous @conn from function comments (John Ferlan) - remote: fix odd comma operator (Eric Blake) - maint: remove incorrect apostrophes from 'its' (Ján Tomko) Thanks everybody for the help bringing those releases, be it with ideas bug report, patches, doc, reviews, etc... Enjoy ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] [PATCH] Revert "Introduce QEMU_CAPS_ARM_VIRT_PCI"
by Peter Krempa 02 Jul '15

02 Jul '15

The capability was not used up to the feature freeze. This reverts commit 7f3515b4bb677d0ead1887547efc844e4761268a. --- src/qemu/qemu_capabilities.c | 4 ---- src/qemu/qemu_capabilities.h | 1 - 2 files changed, 5 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index e7002a3..27686c3 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -287,7 +287,6 @@ VIR_ENUM_IMPL(virQEMUCaps, QEMU_CAPS_LAST, "aarch64-off", "vhost-user-multiqueue", /* 190 */ - "arm-virt-pci", ); @@ -1337,9 +1336,6 @@ virQEMUCapsComputeCmdFlags(const char *help, virQEMUCapsSet(qemuCaps, QEMU_CAPS_VNC_SHARE_POLICY); } - if (version >= 2003000) - virQEMUCapsSet(qemuCaps, QEMU_CAPS_ARM_VIRT_PCI); - return 0; } diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h index f4180a8..30aa504 100644 --- a/src/qemu/qemu_capabilities.h +++ b/src/qemu/qemu_capabilities.h @@ -230,7 +230,6 @@ typedef enum { QEMU_CAPS_DEVICE_PCI_SERIAL = 188, /* -device pci-serial */ QEMU_CAPS_CPU_AARCH64_OFF = 189, /* -cpu ...,aarch64=off */ QEMU_CAPS_VHOSTUSER_MULTIQUEUE = 190, /* vhost-user with -netdev queues= */ - QEMU_CAPS_ARM_VIRT_PCI = 191, /* ARM 'virt' machine has PCI bus */ QEMU_CAPS_LAST, /* this must always be the last item */ } virQEMUCapsFlags; -- 2.4.1

5 6

[libvirt] [libvirt-glib PATCHv3 1/7] gobject: Simplify gvir_connection_list*() implementations
by Zeeshan Ali (Khattak) 01 Jul '15

01 Jul '15

Make use of virConnectListAll* functions to avoid making 4 calls and hence avoid race conditions and complicated code. --- libvirt-gobject/libvirt-gobject-connection.c | 203 ++++----------------------- 1 file changed, 28 insertions(+), 175 deletions(-) diff --git a/libvirt-gobject/libvirt-gobject-connection.c b/libvirt-gobject/libvirt-gobject-connection.c index cf073a5..1576906 100644 --- a/libvirt-gobject/libvirt-gobject-connection.c +++ b/libvirt-gobject/libvirt-gobject-connection.c @@ -680,48 +680,6 @@ void gvir_connection_close(GVirConnection *conn) g_signal_emit(conn, signals[VIR_CONNECTION_CLOSED], 0); } -typedef gint (* CountFunction) (virConnectPtr vconn); -typedef gint (* ListFunction) (virConnectPtr vconn, gchar **lst, gint max); - -static gchar ** fetch_list(virConnectPtr vconn, - const char *name, - CountFunction count_func, - ListFunction list_func, - GCancellable *cancellable, - gint *length, - GError **err) -{ - gchar **lst = NULL; - gint n = 0; - - if ((n = count_func(vconn)) < 0) { - gvir_set_error(err, GVIR_CONNECTION_ERROR, - 0, - _("Unable to count %s"), name); - goto error; - } - - if (n) { - if (g_cancellable_set_error_if_cancelled(cancellable, err)) - goto error; - - lst = g_new0(gchar *, n); - if ((n = list_func(vconn, lst, n)) < 0) { - gvir_set_error(err, GVIR_CONNECTION_ERROR, - 0, - _("Unable to list %s %d"), name, n); - goto error; - } - } - - *length = n; - return lst; - -error: - g_free(lst); - return NULL; -} - /** * gvir_connection_fetch_domains: * @conn: a #GVirConnection @@ -733,14 +691,11 @@ gboolean gvir_connection_fetch_domains(GVirConnection *conn, { GVirConnectionPrivate *priv; GHashTable *doms; - gchar **inactive = NULL; - gint ninactive = 0; - gint *active = NULL; - gint nactive = 0; + virDomainPtr *domains = NULL; + gint ndomains = 0; gboolean ret = FALSE; gint i; virConnectPtr vconn = NULL; - GError *lerr = NULL; g_return_val_if_fail(GVIR_IS_CONNECTION(conn), FALSE); g_return_val_if_fail((cancellable == NULL) || G_IS_CANCELLABLE(cancellable), @@ -761,81 +716,28 @@ gboolean gvir_connection_fetch_domains(GVirConnection *conn, virConnectRef(vconn); g_mutex_unlock(priv->lock); - if (g_cancellable_set_error_if_cancelled(cancellable, err)) - goto cleanup; - - if ((nactive = virConnectNumOfDomains(vconn)) < 0) { - gvir_set_error_literal(err, GVIR_CONNECTION_ERROR, - 0, - _("Unable to count domains")); + ndomains = virConnectListAllDomains(vconn, &domains, 0); + if (ndomains < 0) { + gvir_set_error(err, GVIR_CONNECTION_ERROR, + 0, + _("Failed to fetch list of domains")); goto cleanup; } - if (nactive) { - if (g_cancellable_set_error_if_cancelled(cancellable, err)) - goto cleanup; - - active = g_new(gint, nactive); - if ((nactive = virConnectListDomains(vconn, active, nactive)) < 0) { - gvir_set_error_literal(err, GVIR_CONNECTION_ERROR, - 0, - _("Unable to list domains")); - goto cleanup; - } - } if (g_cancellable_set_error_if_cancelled(cancellable, err)) goto cleanup; - inactive = fetch_list(vconn, - "Domains", - virConnectNumOfDefinedDomains, - virConnectListDefinedDomains, - cancellable, - &ninactive, - &lerr); - if (lerr) { - g_propagate_error(err, lerr); - lerr = NULL; - goto cleanup; - } - doms = g_hash_table_new_full(g_str_hash, g_str_equal, NULL, g_object_unref); - for (i = 0 ; i < nactive ; i++) { - if (g_cancellable_set_error_if_cancelled(cancellable, err)) - goto cleanup; - - virDomainPtr vdom = virDomainLookupByID(vconn, active[i]); + for (i = 0 ; i < ndomains; i++) { GVirDomain *dom; - if (!vdom) - continue; dom = GVIR_DOMAIN(g_object_new(GVIR_TYPE_DOMAIN, - "handle", vdom, + "handle", domains[i], NULL)); - virDomainFree(vdom); - - g_hash_table_insert(doms, - (gpointer)gvir_domain_get_uuid(dom), - dom); - } - - for (i = 0 ; i < ninactive ; i++) { - if (g_cancellable_set_error_if_cancelled(cancellable, err)) - goto cleanup; - - virDomainPtr vdom = virDomainLookupByName(vconn, inactive[i]); - GVirDomain *dom; - if (!vdom) - continue; - - dom = GVIR_DOMAIN(g_object_new(GVIR_TYPE_DOMAIN, - "handle", vdom, - NULL)); - virDomainFree(vdom); g_hash_table_insert(doms, (gpointer)gvir_domain_get_uuid(dom), @@ -852,10 +754,11 @@ gboolean gvir_connection_fetch_domains(GVirConnection *conn, ret = TRUE; cleanup: - g_free(active); - for (i = 0 ; i < ninactive ; i++) - g_free(inactive[i]); - g_free(inactive); + if (ndomains > 0) { + for (i = 0 ; i < ndomains; i++) + virDomainFree(domains[i]); + free(domains); + } return ret; } @@ -870,14 +773,11 @@ gboolean gvir_connection_fetch_storage_pools(GVirConnection *conn, { GVirConnectionPrivate *priv; GHashTable *pools; - gchar **inactive = NULL; - gint ninactive = 0; - gchar **active = NULL; - gint nactive = 0; + virStoragePoolPtr *vpools = NULL; + gint npools = 0; gboolean ret = FALSE; gint i; virConnectPtr vconn = NULL; - GError *lerr = NULL; g_return_val_if_fail(GVIR_IS_CONNECTION(conn), FALSE); g_return_val_if_fail((cancellable == NULL) || G_IS_CANCELLABLE(cancellable), @@ -901,77 +801,31 @@ gboolean gvir_connection_fetch_storage_pools(GVirConnection *conn, if (g_cancellable_set_error_if_cancelled(cancellable, err)) goto cleanup; - active = fetch_list(vconn, - "Storage Pools", - virConnectNumOfStoragePools, - virConnectListStoragePools, - cancellable, - &nactive, - &lerr); - if (lerr) { - g_propagate_error(err, lerr); - lerr = NULL; + npools = virConnectListAllStoragePools(vconn, &vpools, 0); + if (npools < 0) { + gvir_set_error(err, GVIR_CONNECTION_ERROR, + 0, + _("Failed to fetch list of pools")); goto cleanup; } if (g_cancellable_set_error_if_cancelled(cancellable, err)) goto cleanup; - inactive = fetch_list(vconn, - "Storage Pools", - virConnectNumOfDefinedStoragePools, - virConnectListDefinedStoragePools, - cancellable, - &ninactive, - &lerr); - if (lerr) { - g_propagate_error(err, lerr); - lerr = NULL; - goto cleanup; - } - pools = g_hash_table_new_full(g_str_hash, g_str_equal, NULL, g_object_unref); - for (i = 0 ; i < nactive ; i++) { + for (i = 0 ; i < npools; i++) { if (g_cancellable_set_error_if_cancelled(cancellable, err)) goto cleanup; - virStoragePoolPtr vpool; GVirStoragePool *pool; - vpool = virStoragePoolLookupByName(vconn, active[i]); - if (!vpool) - continue; - - pool = GVIR_STORAGE_POOL(g_object_new(GVIR_TYPE_STORAGE_POOL, - "handle", vpool, - NULL)); - virStoragePoolFree(vpool); - - g_hash_table_insert(pools, - (gpointer)gvir_storage_pool_get_uuid(pool), - pool); - } - - for (i = 0 ; i < ninactive ; i++) { - if (g_cancellable_set_error_if_cancelled(cancellable, err)) - goto cleanup; - - virStoragePoolPtr vpool; - GVirStoragePool *pool; - - vpool = virStoragePoolLookupByName(vconn, inactive[i]); - if (!vpool) - continue; - pool = GVIR_STORAGE_POOL(g_object_new(GVIR_TYPE_STORAGE_POOL, - "handle", vpool, + "handle", vpools[i], NULL)); - virStoragePoolFree(vpool); - g_hash_table_insert(pools, (gpointer)gvir_storage_pool_get_uuid(pool), pool); @@ -987,12 +841,11 @@ gboolean gvir_connection_fetch_storage_pools(GVirConnection *conn, ret = TRUE; cleanup: - for (i = 0 ; i < nactive ; i++) - g_free(active[i]); - g_free(active); - for (i = 0 ; i < ninactive ; i++) - g_free(inactive[i]); - g_free(inactive); + if (npools > 0) { + for (i = 0 ; i < npools; i++) + virStoragePoolFree(vpools[i]); + free(vpools); + } return ret; } -- 2.4.3

1 6

[libvirt] ANNOUNCE: libvirt-sandbox "Dashti Margo" release 0.6.0
by Daniel P. Berrange 01 Jul '15

01 Jul '15

I pleased to announce the a new public release of libvirt-sandbox, version 0.6.0, is now available for download ftp://libvirt.org/libvirt/sandbox/ The packages are GPG signed with Key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R) The libvirt-sandbox package provides an API layer on top of libvirt-gobject which facilitates the cration of application sandboxes using virtualization technology. An application sandbox is a virtual machine or container that runs a single application binary, directly from the host OS filesystem. In other words there is no separate guest operating system install to build or manager. At this point in time libvirt-sandbox can create sandboxes using either LXC or KVM, and should in theory be extendable to any libvirt driver. This release contains a mixture of new features and bug fixes - API/ABI in-compatible change, soname increased - Prevent use of virt-sandbox-service as non-root upfront - Fix misc memory leaks - Block SIGHUP from the dhclient binary to prevent accidental death if the controlling terminal is closed & reopened - Add support for re-creating libvirt XML from sandbox config to facilitate upgrades - Switch to standard gobject introspection autoconf macros - Add ability to set filters on network interfaces - Search /usr/lib instead of /lib for systemd unit files, as the former is the canonical location even when / and /usr are merged - Only set SELinux labels on hosts that support SELinux - Explicitly link to selinux, instead of relying on indirect linkage - Update compiler warning flags - Fix misc docs comments - Don't assume use of SELinux in virt-sandbox-service - Fix path checks for SUSUE in virt-sandbox-service - Add support for AppArmour profiles - Mount /var after other FS to ensure host image is available - Ensure state/config dirs can be accessed when QEMU is running non-root for qemu:///system - Fix mounting of host images in QEMU sandboxes - Mount images as ext4 instead of ext3 - Allow use of non-raw disk images as filesystem mounts - Check if required static libs are available at configure time to prevent silent fallback to shared linking - Require libvirt-glib >= 0.2.1 - Add support for loading lzma and gzip compressed kmods - Check for support libvirt URIs when starting guests to ensure clear error message upfront - Add LIBVIRT_SANDBOX_INIT_DEBUG env variable to allow debugging of kernel boot messages and sandbox init process setup - Add support for exposing block devices to sandboxes with a predictable name under /dev/disk/by-tag/TAGNAME - Use devtmpfs instead of tmpfs for auto-populating /dev in QEMU sandboxes - Allow setup of sandbox with custom root filesystem instead of inheriting from host's root. - Allow execution of apps from non-matched ld-linux.so / libc.so, eg executing F19 binaries on F22 host - Use passthrough mode for all QEMU filesystems Thanks to everyone who contributed to this release Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

1 0

[libvirt] [PATCH v2 1/2] Fix nodeinfo output on PPC64 KVM hosts
by Shivaprasad G Bhat 01 Jul '15

01 Jul '15

The nodeinfo is reporting incorrect number of cpus and incorrect host topology on PPC64 KVM hosts. The KVM hypervisor on PPC64 needs only the primary thread in a core to be online, and the secondaries offlined. While scheduling a guest in, the kvm scheduler wakes up the secondaries to run in guest context. The host scheduling of the guests happen at the core level(as only primary thread is online). The kvm scheduler exploits as many threads of the core as needed by guest. Further, starting POWER8, the processor allows splitting a physical core into multiple subcores with 2 or 4 threads each. Again, only the primary thread in a subcore is online in the host. The KVM-PPC scheduler allows guests to exploit all the offline threads in the subcore, by bringing them online when needed. (Kernel patches on split-core http://www.spinics.net/lists/kvm-ppc/msg09121.html) Recently with dynamic micro-threading changes in ppc-kvm, makes sure to utilize all the offline cpus across guests, and across guests with different cpu topologies. (https://www.mail-archive.com/kvm@vger.kernel.org/msg115978.html) Since the offline cpus are brought online in the guest context, it is safe to count them as online. Nodeinfo today discounts these offline cpus from cpu count/topology calclulation, and the nodeinfo output is not of any help and the host appears overcommited when it is actually not. The patch carefully counts those offline threads whose primary threads are online. The host topology displayed by the nodeinfo is also fixed when the host is in valid kvm state. Test results with and without fix: http://ur1.ca/mx25y Signed-off-by: Shivaprasad G Bhat <sbhat(a)linux.vnet.ibm.com> --- src/libvirt_private.syms | 1 + src/nodeinfo.c | 87 ++++++++++++++++++++++++++++++++++++++++------ src/util/virarch.c | 35 +++++++++++++++++++ src/util/virarch.h | 2 + 4 files changed, 114 insertions(+), 11 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 1566d11..071fe6e 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1075,6 +1075,7 @@ virArchFromHost; virArchFromString; virArchGetEndian; virArchGetWordSize; +virArchPPCGetKvmHostCoreMode; virArchToString; diff --git a/src/nodeinfo.c b/src/nodeinfo.c index 2fafe2d..9d1dc84 100644 --- a/src/nodeinfo.c +++ b/src/nodeinfo.c @@ -428,25 +428,77 @@ virNodeParseNode(const char *node, unsigned int cpu; int online; int direrr; + int lastonline; + virBitmapPtr nodecpus = NULL; + int threads_per_subcore = 1; + bool valid_ppc64_kvmhost_mode = false; *threads = 0; *cores = 0; *sockets = 0; + if (ARCH_IS_PPC64(arch)) { + /* PPC-KVM needs the secondary threads of a core to be offline on the + * host. The kvm scheduler brings the secondary threads online in the + * guest context. Moreover, P8 processor has split-core capability + * where, there can be 1,2 or 4 subcores per core. The primaries of the + * subcores alone will be online on the host for a subcore in the + * host. Even though the actual threads per core for P8 processor is 8, + * depending on the subcores_per_core = 1, 2 or 4, the threads per + * subcore will vary accordingly to 8, 4 and 2 repectively. + * So, On host threads_per_core what is arrived at from sysfs in the + * current logic is actually the subcores_per_core. Threads per subcore + * can only be obtained from the kvm device. For example, on P8 wih 1 + * core having 8 threads, sub_cores_percore=4, the threads 0,2,4 & 6 + * will be online. The sysfs reflects this and in the current logic + * variable 'threads' will be 4 which is nothing but subcores_per_core. + * If the user tampers the cpu online/offline states using chcpu or other + * means, then it is an unsupported configuration for kvm. + * The code below tries to keep in mind + * - when the libvirtd is run inside a KVM guest or Phyp based guest. + * - Or on the kvm host where user manually tampers the cpu states to + * offline/online randomly. + */ + valid_ppc64_kvmhost_mode = virArchPPCGetKvmHostCoreMode(&threads_per_subcore); + } + + nodecpus = virBitmapNew(VIR_DOMAIN_CPUMASK_LEN); + if (!(cpudir = opendir(node))) { virReportSystemError(errno, _("cannot opendir %s"), node); goto cleanup; } - /* enumerate sockets in the node */ - CPU_ZERO(&sock_map); while ((direrr = virDirRead(cpudir, &cpudirent, node)) > 0) { if (sscanf(cpudirent->d_name, "cpu%u", &cpu) != 1) continue; + if (virBitmapSetBit(nodecpus, cpu)) + goto cleanup; + } + + if (direrr < 0) + goto cleanup; + + /* enumerate sockets in the node */ + CPU_ZERO(&sock_map); + lastonline = -1; + for (cpu = 0; cpu < virBitmapSize(nodecpus); cpu++) { + if (!virBitmapIsBitSet(nodecpus, cpu)) + continue; + if ((online = virNodeGetCpuValue(node, cpu, "online", 1)) < 0) goto cleanup; + if (online && valid_ppc64_kvmhost_mode) { + if (lastonline != -1 && + (cpu - lastonline) < threads_per_subcore) { + /* if any of secondaries online */ + valid_ppc64_kvmhost_mode = false; + } + lastonline = cpu; + } + if (!online) continue; @@ -459,9 +511,6 @@ virNodeParseNode(const char *node, sock_max = sock; } - if (direrr < 0) - goto cleanup; - sock_max++; /* allocate cpu maps for each socket */ @@ -472,14 +521,25 @@ virNodeParseNode(const char *node, CPU_ZERO(&core_maps[i]); /* iterate over all CPU's in the node */ - rewinddir(cpudir); - while ((direrr = virDirRead(cpudir, &cpudirent, node)) > 0) { - if (sscanf(cpudirent->d_name, "cpu%u", &cpu) != 1) + lastonline = -1; + for (cpu = 0; cpu < virBitmapSize(nodecpus); cpu++) { + if (!virBitmapIsBitSet(nodecpus, cpu)) continue; if ((online = virNodeGetCpuValue(node, cpu, "online", 1)) < 0) goto cleanup; + if (valid_ppc64_kvmhost_mode) { + if (online) { + lastonline = cpu; + } else if (lastonline != -1 && + (cpu-lastonline) < threads_per_subcore) { + processors++; /* Count only those secondaries whose primary + subcore is online */ + continue; + } + } + if (!online) { (*offline)++; continue; @@ -513,9 +573,6 @@ virNodeParseNode(const char *node, *threads = siblings; } - if (direrr < 0) - goto cleanup; - /* finalize the returned data */ *sockets = CPU_COUNT(&sock_map); @@ -528,6 +585,13 @@ virNodeParseNode(const char *node, *cores = core; } + if (valid_ppc64_kvmhost_mode) { + /* The actual host threads per core is + * multiple of the subcores_per_core(i.e variable *threads in this case) + * and threads_per_subcore. + */ + *threads = *threads * threads_per_subcore; + } ret = processors; cleanup: @@ -537,6 +601,7 @@ virNodeParseNode(const char *node, ret = -1; } VIR_FREE(core_maps); + virBitmapFree(nodecpus); return ret; } diff --git a/src/util/virarch.c b/src/util/virarch.c index be48bcf..3717de0 100644 --- a/src/util/virarch.c +++ b/src/util/virarch.c @@ -25,8 +25,16 @@ #include "virlog.h" #include "virarch.h" +#include "virfile.h" #include "verify.h" +#include <fcntl.h> +#include <sys/ioctl.h> + +#if HAVE_LINUX_KVM_H +# include <linux/kvm.h> +#endif + VIR_LOG_INIT("util.arch"); /* The canonical names are used in XML documents. ie ABI sensitive */ @@ -182,3 +190,30 @@ virArch virArchFromHost(void) return arch; } + +bool virArchPPCGetKvmHostCoreMode(int *threads_per_subcore) +{ + int kvmfd; + bool valid_ppc64_kvmhost_mode = false; + +#if HAVE_LINUX_KVM_H + kvmfd = open("/dev/kvm", O_RDONLY); + if (kvmfd >= 0) { +# ifdef KVM_CAP_PPC_SMT + + valid_ppc64_kvmhost_mode = true; + /* For Phyp and KVM based guests the ioctl for KVM_CAP_PPC_SMT + * returns zero and both primary and secondary threads will be + * online. + */ + *threads_per_subcore = ioctl(kvmfd, KVM_CHECK_EXTENSION, KVM_CAP_PPC_SMT); + if (*threads_per_subcore == 0) + valid_ppc64_kvmhost_mode = false; + +# endif + } + VIR_FORCE_CLOSE(kvmfd); +#endif + + return valid_ppc64_kvmhost_mode; +} diff --git a/src/util/virarch.h b/src/util/virarch.h index 3206ce2..6e196ff 100644 --- a/src/util/virarch.h +++ b/src/util/virarch.h @@ -102,4 +102,6 @@ virArch virArchFromString(const char *name); virArch virArchFromHost(void); +bool virArchPPCGetKvmHostCoreMode(int *threads_per_subcore); + #endif /* __VIR_ARCH_H__ */

1 1

[libvirt] [sandbox] Get gvir_sandbox_util_guess_image_format search for the last '.'
by Cédric Bosdonnat 01 Jul '15

01 Jul '15

gvir_sandbox_util_guess_image_format is failing to find the extension in paths like /tmp/tmp.mg0tQ1JLFl/mine.img --- libvirt-sandbox/libvirt-sandbox-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-sandbox/libvirt-sandbox-util.c b/libvirt-sandbox/libvirt-sandbox-util.c index 6385291..d73fc8b 100644 --- a/libvirt-sandbox/libvirt-sandbox-util.c +++ b/libvirt-sandbox/libvirt-sandbox-util.c @@ -40,7 +40,7 @@ gint gvir_sandbox_util_guess_image_format(const gchar *path, { gchar *tmp; - if ((tmp = strchr(path, '.')) == NULL) { + if ((tmp = g_strrstr(path, ".")) == NULL) { g_set_error(error, GVIR_SANDBOX_UTIL_ERROR, 0, _("Cannot identify file extension in '%s'"), path); return -1; -- 2.1.4

2 1

[libvirt] [PATCH] storage: add RBD support to disk source pool translation
by Thibault VINCENT 01 Jul '15

01 Jul '15

Hello, We needed this to avoid redundancies when defining domains with RBD backends, because monitor list and authentication secret could not be pulled from the storage pool. I didn't find any bit of documentation to update, actually it already implies that disks with source type 'volume' would work with all kinds of backing pools. But mpath, sheepdog, and gluster would still require an implementation if it's possible. Using RBD volumes this way still has a limitation, we cannot list snapshots in libvirt pools. Whereas they could be accessed read-only if the domain is using a network source explicitely with a 'snapshot' attribute. How could we implement this so that snapshots are seen as pool volumes? There are real use-cases for this like attaching to a VM a backup from it's own disks. Also it would work the same way with ZFS snapshots, but AFAIK not for LVM pools. Cheers Thibault VINCENT (1): storage: add RBD support to generic disk source pool translation src/storage/storage_driver.c | 49 +++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 48 insertions(+), 1 deletion(-) -- 2.1.4

3 9

[libvirt] [PATCH] qemu: Resolve Coverity DEADCODE
by John Ferlan 01 Jul '15

01 Jul '15

Commit id 'f967e7a6' didn't place the closing parentheses quite right causing DEADCODE errors since the rc setting/comparison was wrong. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- src/qemu/qemu_hotplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 391190d..79338cf 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -1586,7 +1586,7 @@ int qemuDomainAttachChrDevice(virQEMUDriverPtr driver, if (qemuAssignDeviceChrAlias(vmdef, chr, -1) < 0) goto cleanup; - if ((rc = qemuDomainAttachChrDeviceAssignAddr(priv, chr) < 0)) + if ((rc = qemuDomainAttachChrDeviceAssignAddr(priv, chr)) < 0) goto cleanup; if (rc == 1) need_release = true; -- 2.1.0

2 1

[libvirt] [PATCH 0/2][1.2.17] qemu: fix address allocation on chardev hotplug
by Ján Tomko 01 Jul '15

01 Jul '15

For bug https://bugzilla.redhat.com/show_bug.cgi?id=1230039 Patch 1/2 fixes a regression in channel device hotplug which was introduced in the last release and I would like to get it fixed before the next one. Patch 2/2 is not that important, but still a bugfix. Luyao Huang (1): qemu: fix address allocation on chardev attach Ján Tomko (1): qemu: properly free addresses on non-serial chardev unplug src/qemu/qemu_command.c | 4 +++ src/qemu/qemu_hotplug.c | 78 +++++++++++++++++++++++++++---------------------- 2 files changed, 47 insertions(+), 35 deletions(-) -- 2.3.6

3 4

[libvirt] [PATCH] conf: qemu: Taint VMs using custom device tree blob
by Peter Krempa 01 Jul '15

01 Jul '15

Using a custom device tree image may cause unexpected behavior in architectures that use this approach to detect platform devices. Since usually the device tree is generated by qemu and thus it's not normally used let's taint VMs using it to make it obvious as a possible source of problems. --- src/conf/domain_conf.c | 3 ++- src/conf/domain_conf.h | 1 + src/qemu/qemu_domain.c | 3 +++ 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 2c3b96b..9280a76 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -102,7 +102,8 @@ VIR_ENUM_IMPL(virDomainTaint, VIR_DOMAIN_TAINT_LAST, "external-launch", "host-cpu", "hook-script", - "cdrom-passthrough"); + "cdrom-passthrough", + "custom-dtb"); VIR_ENUM_IMPL(virDomainVirt, VIR_DOMAIN_VIRT_LAST, "qemu", diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index aeba5a5..2bdbff1 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2305,6 +2305,7 @@ typedef enum { VIR_DOMAIN_TAINT_HOST_CPU, /* Host CPU passthrough in use */ VIR_DOMAIN_TAINT_HOOK, /* Domain (possibly) changed via hook script */ VIR_DOMAIN_TAINT_CDROM_PASSTHROUGH,/* CDROM passthrough */ + VIR_DOMAIN_TAINT_CUSTOM_DTB, /* Custom device tree blob was specifed */ VIR_DOMAIN_TAINT_LAST } virDomainTaintFlags; diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 6213fd9..22ffa83 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -2105,6 +2105,9 @@ void qemuDomainObjCheckTaint(virQEMUDriverPtr driver, for (i = 0; i < obj->def->nnets; i++) qemuDomainObjCheckNetTaint(driver, obj, obj->def->nets[i], logFD); + if (obj->def->os.dtb) + qemuDomainObjTaint(driver, obj, VIR_DOMAIN_TAINT_CUSTOM_DTB, logFD); + virObjectUnref(cfg); } -- 2.4.1

2 2

[libvirt] add optional redundancy element to storage
by Vasiliy Tolstov 01 Jul '15

01 Jul '15

some storages have ability to provide redundancy, for example sheepdog via full copies or erasure Signed-off-by: Vasiliy Tolstov <v.tolstov(a)selfip.ru> --- docs/schemas/storagevol.rng | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/docs/schemas/storagevol.rng b/docs/schemas/storagevol.rng index 7450547..bd3b698 100644 --- a/docs/schemas/storagevol.rng +++ b/docs/schemas/storagevol.rng @@ -105,6 +105,9 @@ </choice> </element> </optional> + <optional> + <ref name='redundancy'/> + </optional> <ref name='format'/> <ref name='permissions'/> <ref name='timestamps'/> @@ -138,6 +141,27 @@ </element> </define> + <define name='redundancy'> + <optional> + <element name='replica'> + <element name='copies'> + <ref name='scaledInteger'/> + </element> + </element> + </optional> + <optional> + <element name='erasure'> + <element name='strips'> + <attribute name='data'> + <ref name='scaledInteger'/> + </attribute> + <attribute name='parity'> + <ref name='scaledInteger'/> + </attribute> + </element> + </element> + </optional> + </define> <define name='source'> <element name='source'> -- 2.3.3

1 1

[libvirt] [sandbox] Cleanup the disks.cfg file
by Cédric Bosdonnat 01 Jul '15

01 Jul '15

The newly introduced disks.cfg file is still remaining in the configuration folder after the sandbox is stopped. Let's remove it like the other things there. --- libvirt-sandbox/libvirt-sandbox-builder.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/libvirt-sandbox/libvirt-sandbox-builder.c b/libvirt-sandbox/libvirt-sandbox-builder.c index e615606..ea7d064 100644 --- a/libvirt-sandbox/libvirt-sandbox-builder.c +++ b/libvirt-sandbox/libvirt-sandbox-builder.c @@ -22,6 +22,7 @@ #include <config.h> #include <string.h> +#include <errno.h> #include "libvirt-sandbox/libvirt-sandbox.h" #include "libvirt-sandbox/libvirt-sandbox-builder-private.h" @@ -717,10 +718,15 @@ gboolean gvir_sandbox_builder_clean_post_stop(GVirSandboxBuilder *builder, GFileEnumerator *enumerator = NULL; GFileInfo *info = NULL; GFile *child = NULL; + gchar *dskfile = g_build_filename(statedir, "config", "disks.cfg", NULL); gboolean ret = TRUE; ret = klass->clean_post_stop(builder, config, statedir, error); + if (unlink(dskfile) < 0 && + errno != ENOENT) + ret = FALSE; + if (!(enumerator = g_file_enumerate_children(libsFile, "*", G_FILE_QUERY_INFO_NONE, NULL, error)) && (*error)->code != G_IO_ERROR_NOT_FOUND) { -- 2.1.4

2 1