- Devel - libvirt List Archives

[libvirt] [PATCH 0/4] Automatically choose usable GIC version
by Andrea Bolognani 13 May '16

13 May '16

Currently, if no GIC version has been provided by the user, libvirt will default to GIC v2. This is a problem when trying to create new guests on hardware that only supports GIC v3 guests: QEMU will refuse to start a GIC v2 guest, and guest installation will abort immediately. This series implements a way for libvirt to figure out a suitable GIC version itself, without relying on tools such as virt-install to parse the domain capabilities before attempting installation. Andrea Bolognani (4): qemu: Automatically choose usable GIC version qemu: Add virQEMUCapsSetGICCapabilities() tests: Prepare to have different usable GIC versions tests: Try different usable GIC versions src/conf/domain_capabilities.c | 25 +++ src/conf/domain_capabilities.h | 8 + src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 29 +++- src/qemu/qemu_capabilities.h | 5 + src/qemu/qemu_domain.c | 66 ++++++-- .../qemuxml2argv-aarch64-gic-none-both.args | 1 + .../qemuxml2argv-aarch64-gic-none-both.xml | 1 + .../qemuxml2argv-aarch64-gic-none-v2.args | 1 + .../qemuxml2argv-aarch64-gic-none-v2.xml | 1 + .../qemuxml2argv-aarch64-gic-none-v3.args | 1 + .../qemuxml2argv-aarch64-gic-none-v3.xml | 1 + tests/qemuxml2argvtest.c | 153 +++++++++++++---- .../qemuxml2xmlout-aarch64-gic-none-both.xml | 1 + .../qemuxml2xmlout-aarch64-gic-none-v2.xml | 1 + .../qemuxml2xmlout-aarch64-gic-none-v3.xml | 1 + tests/qemuxml2xmltest.c | 184 +++++++++++++-------- 17 files changed, 368 insertions(+), 112 deletions(-) create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-none-both.args create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-none-both.xml create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-none-v2.args create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-none-v2.xml create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-none-v3.args create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-none-v3.xml create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-aarch64-gic-none-both.xml create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-aarch64-gic-none-v2.xml create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-aarch64-gic-none-v3.xml -- 2.5.5

3 10

[libvirt] [PATCH 0/2] libxl: A few more fixes related to vram
by Jim Fehlig 13 May '16

13 May '16

Commit 3e428670 broke the xlconfigtests, which commit 96b21fb0 mostly fixed. I found that running 'make check' on a machine with Xen installed (/usr/lib/xen/bin/qemu-{dm,system-i386} exists) failed. Test files containing <emulator>/usr/lib/xen/bin/qemu-dm</emulator> resulted in vram being set to the lower default values defined by the old qemu-dm. This series takes one possible approach to fixing the problem by only using qemu-xen (aka qemu upstream) in the test files (note that libxl defaults to qemu-xen if an emulator is not specified). Actually, it's patch 2 that changes the test files. I added patch 1 after seeing errors such as libvirt: error : internal error: Child process (/usr/lib/xen/bin/qemu-dm -help) unexpected exit status 127: libvirt: error : cannot execute binary /usr/lib/xen/bin/qemu-dm: No such file or directory when specifying a non-existent emulator. Another approach, suggested by Joao, is to allow vram == 0 and when building the domain, set video_memkb in the libxl_domain_build_info struct to LIBXL_MEMKB_DEFAULT, allowing libxl to pick the correct default. For this approach, the <video> parsing logic would have to change again. Currently, it sets a vram defaults if not done by the driver post parse function. Along with adjusting the libxl driver to handle vram = 0, all the xlconfigtests would have to change. E.g. - <model type='cirrus' vram='8192' heads='1' primary='yes'/> + <model type='cirrus' heads='1' primary='yes'/> Jim Fehlig (2): libxl: don't attempt to probe a non-existent emulator xlconfigtests: use qemu-xen in all test data files src/libxl/libxl_conf.c | 3 +++ tests/xlconfigdata/test-disk-positional-parms-full.cfg | 2 +- tests/xlconfigdata/test-disk-positional-parms-full.xml | 2 +- tests/xlconfigdata/test-disk-positional-parms-partial.cfg | 2 +- tests/xlconfigdata/test-disk-positional-parms-partial.xml | 2 +- tests/xlconfigdata/test-fullvirt-multiusb.cfg | 2 +- tests/xlconfigdata/test-fullvirt-multiusb.xml | 2 +- tests/xlconfigdata/test-fullvirt-nohap.cfg | 2 +- tests/xlconfigdata/test-fullvirt-nohap.xml | 2 +- tests/xlconfigdata/test-new-disk.cfg | 2 +- tests/xlconfigdata/test-new-disk.xml | 2 +- tests/xlconfigdata/test-rbd-multihost-noauth.cfg | 2 +- tests/xlconfigdata/test-rbd-multihost-noauth.xml | 2 +- tests/xlconfigdata/test-spice-features.cfg | 2 +- tests/xlconfigdata/test-spice-features.xml | 2 +- tests/xlconfigdata/test-spice.cfg | 2 +- tests/xlconfigdata/test-spice.xml | 2 +- tests/xlconfigdata/test-vif-rate.cfg | 2 +- tests/xlconfigdata/test-vif-rate.xml | 2 +- 19 files changed, 21 insertions(+), 18 deletions(-) -- 2.8.2

2 7

[libvirt] [PATCH] virt-aa-helper: remove replace_string and use virStringReplace instead
by Pavel Hrdina 13 May '16

13 May '16

Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/security/virt-aa-helper.c | 76 +++++-------------------------------------- 1 file changed, 9 insertions(+), 67 deletions(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 7eeb4ef..537e89d 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -148,62 +148,6 @@ vah_info(const char *str) } /* - * Replace @oldstr in @orig with @repstr - * @len is number of bytes allocated for @orig. Assumes @orig, @oldstr and - * @repstr are null terminated - */ -static int -replace_string(char *orig, const size_t len, const char *oldstr, - const char *repstr) -{ - int idx; - char *pos = NULL; - char *tmp = NULL; - - if ((pos = strstr(orig, oldstr)) == NULL) { - vah_error(NULL, 0, _("could not find replacement string")); - return -1; - } - - if (VIR_ALLOC_N_QUIET(tmp, len) < 0) { - vah_error(NULL, 0, _("could not allocate memory for string")); - return -1; - } - tmp[0] = '\0'; - - idx = abs(pos - orig); - - /* copy everything up to oldstr */ - strncat(tmp, orig, idx); - - /* add the replacement string */ - if (strlen(tmp) + strlen(repstr) > len - 1) { - vah_error(NULL, 0, _("not enough space in target buffer")); - VIR_FREE(tmp); - return -1; - } - strcat(tmp, repstr); - - /* add everything after oldstr */ - if (strlen(tmp) + strlen(orig) - (idx + strlen(oldstr)) > len - 1) { - vah_error(NULL, 0, _("not enough space in target buffer")); - VIR_FREE(tmp); - return -1; - } - strncat(tmp, orig + idx + strlen(oldstr), - strlen(orig) - (idx + strlen(oldstr))); - - if (virStrcpy(orig, tmp, len) == NULL) { - vah_error(NULL, 0, _("error replacing string")); - VIR_FREE(tmp); - return -1; - } - VIR_FREE(tmp); - - return 0; -} - -/* * run an apparmor_parser command */ static int @@ -340,6 +284,7 @@ create_profile(const char *profile, const char *profile_name, char *pcontent = NULL; char *replace_name = NULL; char *replace_files = NULL; + char *tmp = NULL; const char *template_name = "\nprofile LIBVIRT_TEMPLATE"; const char *template_end = "\n}"; int tlen, plen; @@ -412,19 +357,16 @@ create_profile(const char *profile, const char *profile_name, goto clean_replace; } - if (VIR_ALLOC_N_QUIET(pcontent, plen) < 0) { - vah_error(NULL, 0, _("could not allocate memory for profile")); - goto clean_replace; - } - pcontent[0] = '\0'; - strcpy(pcontent, tcontent); - - if (replace_string(pcontent, plen, template_name, replace_name) < 0) + if (!(pcontent = virStringReplace(tcontent, template_name, replace_name))) goto clean_all; - if ((virtType != VIR_DOMAIN_VIRT_LXC) && - replace_string(pcontent, plen, template_end, replace_files) < 0) - goto clean_all; + if (virtType != VIR_DOMAIN_VIRT_LXC) { + if (!(tmp = virStringReplace(pcontent, template_end, replace_files))) + goto clean_all; + VIR_FREE(pcontent); + pcontent = tmp; + tmp = NULL; + } /* write the file */ if ((fd = open(profile, O_CREAT | O_EXCL | O_WRONLY, 0644)) == -1) { -- 2.8.2

2 2

[libvirt] [PATCH] leave out the default USB controller only on i440fx during migration
by Shivaprasad G Bhat 13 May '16

13 May '16

Further followup discussions in list on commit 192a53e concluded that we should be leaving out the USB controller only for i440fx machines as default USB can be used by someone on q35 at random slots. Signed-off-by: Shivaprasad G Bhat <sbhat(a)linux.vnet.ibm.com> --- src/qemu/qemu_domain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 173f82c..5a9b48b 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -2884,7 +2884,8 @@ qemuDomainDefFormatBuf(virQEMUDriverPtr driver, * with libvirt <= 0.9.4. Limitation doesn't apply to other archs * and can cause problems on PPC64. */ - if (ARCH_IS_X86(def->os.arch) && usb && usb->idx == 0 && usb->model == -1) { + if (ARCH_IS_X86(def->os.arch) && qemuDomainMachineIsI440FX(def) && + usb && usb->idx == 0 && usb->model == -1) { VIR_DEBUG("Removing default USB controller from domain '%s'" " for migration compatibility", def->name); toremove++;

3 2

[libvirt] [PATCH v3 0/4] Introduce big test mock
by Michal Privoznik 13 May '16

13 May '16

diff to v2: - Peter's review suggestions worked in Note that patch 2/4 is ACKed already, but without the rest it makes no sense, so I've not pushed it yet and sending it here for completeness. Michal Privoznik (4): virfile: Introduce virFileRemoveLastComponent tests: Introduce global mock library virtestmock: Print invalid file accesses into a file tests: Introduce check-file-access.pl .gitignore | 1 + HACKING | 9 ++ Makefile.am | 3 + cfg.mk | 2 +- docs/hacking.html.in | 11 ++ src/libvirt_private.syms | 1 + src/util/virfile.c | 17 +++ src/util/virfile.h | 1 + src/util/virstoragefile.c | 6 +- tests/Makefile.am | 28 ++++- tests/check-file-access.pl | 104 ++++++++++++++++ tests/file_access_whitelist.txt | 23 ++++ tests/testutils.c | 32 +++-- tests/testutils.h | 10 +- tests/vircgroupmock.c | 15 +-- tests/virpcimock.c | 14 +-- tests/virtestmock.c | 266 ++++++++++++++++++++++++++++++++++++++++ 17 files changed, 503 insertions(+), 40 deletions(-) create mode 100755 tests/check-file-access.pl create mode 100644 tests/file_access_whitelist.txt create mode 100644 tests/virtestmock.c -- 2.8.1

2 10

[libvirt] [PATCH v2] secret: Alter virSecretGetSecretString
by John Ferlan 13 May '16

13 May '16

Rather than returning a "char *" indicating perhaps some sized set of characters that is NUL terminated, alter the function to return 0 or -1 for success/failure and add two parameters to handle returning the buffer and it's size. The function no longer encodes the returned secret, rather it returns the unencoded secret forcing callers to make the necessary adjustments. Alter the callers to handle the adjusted model. Add a new function virStringBufferIsPrintable to handle checking if the plaintext secret that is about to be printed on the command line has non-printable characters and cause failure if it does. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- v1: http://www.redhat.com/archives/libvir-list/2016-May/msg00870.html Changes since v1: libvirt_private.syms, virstring.c, virstring.h: - Introduce virStringBufferIsPrintable. I could make it a separate patch if so desired. libxl_conf.c, qemu_domain.c, qemu_command.c - Use new format of virSecretGetSecretString - Encode the secret after the call now when necessary - Use virStringBufferIsPrintable before printing iSCSI password secret_util.c: - Return int instead of uint8_t * - Remove 'encode' parameter - Add parameter "*ret_secret", alloc and return the secret in uint8_t * buf src/libvirt_private.syms | 1 + src/libxl/libxl_conf.c | 24 +++++++++++++++++------- src/qemu/qemu_command.c | 18 +++++++++++++++++- src/qemu/qemu_domain.c | 17 +++++------------ src/qemu/qemu_domain.h | 3 ++- src/secret/secret_util.c | 45 ++++++++++++++++++++++----------------------- src/secret/secret_util.h | 15 ++++++++------- src/util/virstring.c | 19 +++++++++++++++++++ src/util/virstring.h | 1 + 9 files changed, 92 insertions(+), 51 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index a980a32..b76d9d5 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -2301,6 +2301,7 @@ virSkipSpacesBackwards; virStrcpy; virStrdup; virStringArrayHasString; +virStringBufferIsPrintable; virStringFreeList; virStringFreeListCount; virStringGetFirstWithPrefix; diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index d927b37..2dfd03d 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -47,6 +47,7 @@ #include "libxl_utils.h" #include "virstoragefile.h" #include "secret_util.h" +#include "base64.h" #define VIR_FROM_THIS VIR_FROM_LIBXL @@ -1018,7 +1019,9 @@ static int libxlMakeNetworkDiskSrc(virStorageSourcePtr src, char **srcstr) { virConnectPtr conn = NULL; - char *secret = NULL; + uint8_t *secret = NULL; + char *base64secret = NULL; + size_t secretlen; char *username = NULL; int ret = -1; @@ -1030,21 +1033,28 @@ libxlMakeNetworkDiskSrc(virStorageSourcePtr src, char **srcstr) if (!(conn = virConnectOpen("xen:///system"))) goto cleanup; - if (!(secret = virSecretGetSecretString(conn, - protocol, - true, - src->auth, - VIR_SECRET_USAGE_TYPE_CEPH))) + if (virSecretGetSecretString(conn, protocol, src->auth, + VIR_SECRET_USAGE_TYPE_CEPH, + &secret, &secretlen) < 0) goto cleanup; + + /* RBD expects an encoded secret */ + base64_encode_alloc((const char *)secret, secretlen, &base64secret); + memset(secret, 0, secretlen); + if (!base64secret) { + virReportOOMError(); + goto cleanup; + } } - if (!(*srcstr = libxlMakeNetworkDiskSrcStr(src, username, secret))) + if (!(*srcstr = libxlMakeNetworkDiskSrcStr(src, username, base64secret))) goto cleanup; ret = 0; cleanup: VIR_FREE(secret); + VIR_FREE(base64secret); virObjectUnref(conn); return ret; } diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 0d6d5f8..18b268a 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -56,6 +56,7 @@ #include "virscsi.h" #include "virnuma.h" #include "virgic.h" +#include "base64.h" #if defined(__linux__) # include <linux/capability.h> #endif @@ -628,6 +629,12 @@ qemuBuildGeneralSecinfoURI(virURIPtr uri, switch ((qemuDomainSecretInfoType) secinfo->type) { case VIR_DOMAIN_SECRET_INFO_TYPE_PLAIN: if (secinfo->s.plain.secret) { + if (!virStringBufferIsPrintable(secinfo->s.plain.secret, + secinfo->s.plain.secretlen)) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("found non printable characters in secret")); + return -1; + } if (virAsprintf(&uri->user, "%s:%s", secinfo->s.plain.username, secinfo->s.plain.secret) < 0) @@ -662,6 +669,8 @@ static int qemuBuildRBDSecinfoURI(virBufferPtr buf, qemuDomainSecretInfoPtr secinfo) { + char *base64secret = NULL; + if (!secinfo) { virBufferAddLit(buf, ":auth_supported=none"); return 0; @@ -669,11 +678,18 @@ qemuBuildRBDSecinfoURI(virBufferPtr buf, switch ((qemuDomainSecretInfoType) secinfo->type) { case VIR_DOMAIN_SECRET_INFO_TYPE_PLAIN: + base64_encode_alloc((const char *)secinfo->s.plain.secret, + secinfo->s.plain.secretlen, &base64secret); + if (!base64secret) { + virReportOOMError(); + return -1; + } virBufferEscape(buf, '\\', ":", ":id=%s", secinfo->s.plain.username); virBufferEscape(buf, '\\', ":", ":key=%s:auth_supported=cephx\\;none", - secinfo->s.plain.secret); + base64secret); + VIR_FREE(base64secret); break; case VIR_DOMAIN_SECRET_INFO_TYPE_AES: diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 39a50e6..2f94f23 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -731,7 +731,7 @@ static void qemuDomainSecretPlainFree(qemuDomainSecretPlain secret) { VIR_FREE(secret.username); - memset(secret.secret, 0, strlen(secret.secret)); + memset(secret.secret, 0, secret.secretlen); VIR_FREE(secret.secret); } @@ -870,7 +870,6 @@ qemuDomainSecretPlainSetup(virConnectPtr conn, virStorageNetProtocol protocol, virStorageAuthDefPtr authdef) { - bool encode = false; int secretType = VIR_SECRET_USAGE_TYPE_ISCSI; const char *protocolstr = virStorageNetProtocolTypeToString(protocol); @@ -878,18 +877,12 @@ qemuDomainSecretPlainSetup(virConnectPtr conn, if (VIR_STRDUP(secinfo->s.plain.username, authdef->username) < 0) return -1; - if (protocol == VIR_STORAGE_NET_PROTOCOL_RBD) { - /* qemu requires the secret to be encoded for RBD */ - encode = true; + if (protocol == VIR_STORAGE_NET_PROTOCOL_RBD) secretType = VIR_SECRET_USAGE_TYPE_CEPH; - } - - if (!(secinfo->s.plain.secret = - virSecretGetSecretString(conn, protocolstr, encode, - authdef, secretType))) - return -1; - return 0; + return virSecretGetSecretString(conn, protocolstr, authdef, secretType, + &secinfo->s.plain.secret, + &secinfo->s.plain.secretlen); } diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index 331ade0..f074ca5 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -251,7 +251,8 @@ typedef struct _qemuDomainSecretPlain qemuDomainSecretPlain; typedef struct _qemuDomainSecretPlain *qemuDomainSecretPlainPtr; struct _qemuDomainSecretPlain { char *username; - char *secret; + uint8_t *secret; + size_t secretlen; }; # define QEMU_DOMAIN_AES_IV_KEY_LEN 16 /* 16 bytes for 128 bit random */ diff --git a/src/secret/secret_util.c b/src/secret/secret_util.c index 217584f..5dff57c 100644 --- a/src/secret/secret_util.c +++ b/src/secret/secret_util.c @@ -27,7 +27,6 @@ #include "virlog.h" #include "virobject.h" #include "viruuid.h" -#include "base64.h" #include "datatypes.h" #define VIR_FROM_THIS VIR_FROM_SECRET @@ -38,27 +37,30 @@ VIR_LOG_INIT("secret.secret_util"); /* virSecretGetSecretString: * @conn: Pointer to the connection driver to make secret driver call * @scheme: Unique enough string for error message to help determine cause - * @encoded: Whether the returned secret needs to be base64 encoded * @authdef: Pointer to the disk storage authentication * @secretUsageType: Type of secret usage for authdef lookup + * @ret_secret: returned secret as a sized stream of unsigned chars + * @ret_secret_size: Return size of the secret - either raw text or base64 * - * Lookup the secret for the authdef usage type and return it either as - * raw text or encoded based on the caller's need. + * Lookup the secret for the authdef usage type and return it as raw text. + * It is up to the caller to encode the secret further. * - * Returns a pointer to memory that needs to be cleared and free'd after - * usage or NULL on error. + * Returns 0 on success, -1 on failure. On success the memory in ret_secret + * needs to be cleared and free'd after usage. */ -char * +int virSecretGetSecretString(virConnectPtr conn, const char *scheme, - bool encoded, virStorageAuthDefPtr authdef, - virSecretUsageType secretUsageType) + virSecretUsageType secretUsageType, + uint8_t **ret_secret, + size_t *ret_secret_size) { size_t secret_size; virSecretPtr sec = NULL; - char *secret = NULL; + unsigned char *secret = NULL; char uuidStr[VIR_UUID_STRING_BUFLEN]; + int ret = -1; /* look up secret */ switch (authdef->secretType) { @@ -85,8 +87,8 @@ virSecretGetSecretString(virConnectPtr conn, goto cleanup; } - secret = (char *)conn->secretDriver->secretGetValue(sec, &secret_size, 0, - VIR_SECRET_GET_VALUE_INTERNAL_CALL); + secret = conn->secretDriver->secretGetValue(sec, &secret_size, 0, + VIR_SECRET_GET_VALUE_INTERNAL_CALL); if (!secret) { if (authdef->secretType == VIR_STORAGE_SECRET_TYPE_UUID) { virReportError(VIR_ERR_INTERNAL_ERROR, @@ -102,19 +104,16 @@ virSecretGetSecretString(virConnectPtr conn, goto cleanup; } - if (encoded) { - char *base64 = NULL; + if (VIR_ALLOC_N(*ret_secret, secret_size) < 0) + goto cleanup; - base64_encode_alloc(secret, secret_size, &base64); - VIR_FREE(secret); - if (!base64) { - virReportOOMError(); - goto cleanup; - } - secret = base64; - } + memcpy(*ret_secret, secret, secret_size); + *ret_secret_size = secret_size; + ret = 0; cleanup: virObjectUnref(sec); - return secret; + memset(secret, 0, secret_size); + VIR_FREE(secret); + return ret; } diff --git a/src/secret/secret_util.h b/src/secret/secret_util.h index c707599..0520db3 100644 --- a/src/secret/secret_util.h +++ b/src/secret/secret_util.h @@ -25,11 +25,12 @@ # include "internal.h" # include "virstoragefile.h" -char *virSecretGetSecretString(virConnectPtr conn, - const char *scheme, - bool encoded, - virStorageAuthDefPtr authdef, - virSecretUsageType secretUsageType) - ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(4) - ATTRIBUTE_RETURN_CHECK; +int virSecretGetSecretString(virConnectPtr conn, + const char *scheme, + virStorageAuthDefPtr authdef, + virSecretUsageType secretUsageType, + uint8_t **ret_secret, + size_t *ret_secret_size) + ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3) + ATTRIBUTE_NONNULL(5) ATTRIBUTE_NONNULL(6) ATTRIBUTE_RETURN_CHECK; #endif /* __VIR_SECRET_H__ */ diff --git a/src/util/virstring.c b/src/util/virstring.c index 735e65b..1679266 100644 --- a/src/util/virstring.c +++ b/src/util/virstring.c @@ -1066,3 +1066,22 @@ virStringIsPrintable(const char *str) return true; } + + +/** + * virBufferIsPrintable: + * + * Returns true if @buf of @buflen contains only printable characters + */ +bool +virStringBufferIsPrintable(const uint8_t *buf, + size_t buflen) +{ + size_t i; + + for (i = 0; i < buflen; i++) + if (!c_isprint(buf[i])) + return false; + + return true; +} diff --git a/src/util/virstring.h b/src/util/virstring.h index fd2868a..9203aa3 100644 --- a/src/util/virstring.h +++ b/src/util/virstring.h @@ -276,5 +276,6 @@ bool virStringHasControlChars(const char *str); void virStringStripControlChars(char *str); bool virStringIsPrintable(const char *str); +bool virStringBufferIsPrintable(const uint8_t *buf, size_t buflen); #endif /* __VIR_STRING_H__ */ -- 2.5.5

2 1

[libvirt] [PATCH] network: log error when <bandwidth> is requested for hostdev interfaces
by Laine Stump 13 May '16

13 May '16

This would previously be silently ignored. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1319044 --- src/network/bridge_driver.c | 25 +++++++++++++++++++++++++ src/qemu/qemu_domain.c | 21 ++++++++++++++++----- 2 files changed, 41 insertions(+), 5 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index bef8a78..0fd2095 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -3126,6 +3126,20 @@ networkValidate(virNetworkDriverStatePtr driver, def->name); return -1; } + + if (def->forward.type == VIR_NETWORK_FORWARD_HOSTDEV) { + for (i = 0; i < def->nPortGroups; i++) { + if (def->portGroups[i].bandwidth) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("unsupported <bandwidth> element " + "in <portgroup name='%s'> of " + "network '%s' with forward mode='%s'"), + def->portGroups[i].name, def->name, + virNetworkForwardTypeToString(def->forward.type)); + return -1; + } + } + } return 0; } @@ -4305,6 +4319,17 @@ networkAllocateActualDevice(virDomainDefPtr dom, goto error; } } + if (virDomainNetGetActualBandwidth(iface)) { + /* bandwidth configuration via libvirt is not supported for + * hostdev network devices + */ + if (actualType == VIR_DOMAIN_NET_TYPE_HOSTDEV) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("bandwidth settings are not supported " + "for hostdev interfaces")); + goto error; + } + } if (netdef) { netdef->connections++; diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index f7356a2..4e32251 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -2119,12 +2119,23 @@ qemuDomainDeviceDefPostParse(virDomainDeviceDefPtr dev, qemuCaps = virQEMUCapsCacheLookup(driver->qemuCapsCache, def->emulator); - if (dev->type == VIR_DOMAIN_DEVICE_NET && - dev->data.net->type != VIR_DOMAIN_NET_TYPE_HOSTDEV && - !dev->data.net->model) { - if (VIR_STRDUP(dev->data.net->model, - qemuDomainDefaultNetModel(def, qemuCaps)) < 0) + if (dev->type == VIR_DOMAIN_DEVICE_NET) { + virDomainNetDefPtr net = dev->data.net; + + if (net->type != VIR_DOMAIN_NET_TYPE_HOSTDEV && !net->model && + VIR_STRDUP(net->model, qemuDomainDefaultNetModel(def, qemuCaps)) < 0) + goto cleanup; + + if (net->type == VIR_DOMAIN_NET_TYPE_HOSTDEV && + virDomainNetGetActualBandwidth(net)) { + /* bandwidth configuration via libvirt is not supported + * for hostdev network devices + */ + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("bandwidth settings are not supported " + "for hostdev interfaces")); goto cleanup; + } } /* set default disk types and drivers */ -- 2.5.5

2 3

[libvirt] [PATCH] Fix tests to include video ram size
by Ján Tomko 12 May '16

12 May '16

My commit 3e42867 started filling out the video size in post-parse, but did not adjust the tests. --- Pushed under the build breaker rule. tests/sexpr2xmldata/sexpr2xml-curmem.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-fv-autoport.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-fv-empty-kernel.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-fv-force-hpet.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-fv-force-nohpet.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-fv-localtime.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-fv-net-netfront.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-fv-parallel-tcp.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2-ports.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2nd-port.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-fv-serial-file.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-fv-serial-null.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-fv-serial-pipe.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-fv-serial-pty.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-fv-serial-stdio.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp-telnet.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-fv-serial-udp.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-fv-serial-unix.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-fv-sound-all.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-fv-sound.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-fv-usbmouse.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-fv-usbtablet.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-fv-utc.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-fv-v2.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-fv.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-pv-vfb-new-vncdisplay.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-pv-vfb-new.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-pv-vfb-type-crash.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-vif-rate.xml | 2 +- tests/xlconfigdata/test-disk-positional-parms-full.xml | 2 +- tests/xlconfigdata/test-disk-positional-parms-partial.xml | 2 +- tests/xlconfigdata/test-fullvirt-direct-kernel-boot-bogus-extra.xml | 2 +- tests/xlconfigdata/test-fullvirt-direct-kernel-boot-extra.xml | 2 +- tests/xlconfigdata/test-fullvirt-direct-kernel-boot.xml | 2 +- tests/xlconfigdata/test-fullvirt-multiusb.xml | 2 +- tests/xlconfigdata/test-fullvirt-nohap.xml | 2 +- tests/xlconfigdata/test-new-disk.xml | 2 +- tests/xlconfigdata/test-rbd-multihost-noauth.xml | 2 +- tests/xlconfigdata/test-spice-features.xml | 2 +- tests/xlconfigdata/test-spice.xml | 2 +- tests/xlconfigdata/test-vif-rate.xml | 2 +- tests/xmconfigdata/test-escape-paths.xml | 2 +- tests/xmconfigdata/test-fullvirt-default-feature.xml | 2 +- tests/xmconfigdata/test-fullvirt-force-hpet.xml | 2 +- tests/xmconfigdata/test-fullvirt-force-nohpet.xml | 2 +- tests/xmconfigdata/test-fullvirt-localtime.xml | 2 +- tests/xmconfigdata/test-fullvirt-net-netfront.xml | 2 +- tests/xmconfigdata/test-fullvirt-new-cdrom.xml | 2 +- tests/xmconfigdata/test-fullvirt-nohap.xml | 2 +- tests/xmconfigdata/test-fullvirt-parallel-tcp.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-dev-2-ports.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-dev-2nd-port.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-file.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-null.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-pipe.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-pty.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-stdio.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-tcp-telnet.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-tcp.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-udp.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-unix.xml | 2 +- tests/xmconfigdata/test-fullvirt-sound.xml | 2 +- tests/xmconfigdata/test-fullvirt-usbmouse.xml | 2 +- tests/xmconfigdata/test-fullvirt-usbtablet.xml | 2 +- tests/xmconfigdata/test-fullvirt-utc.xml | 2 +- tests/xmconfigdata/test-no-source-cdrom.xml | 2 +- tests/xmconfigdata/test-paravirt-net-e1000.xml | 2 +- tests/xmconfigdata/test-paravirt-net-vifname.xml | 2 +- tests/xmconfigdata/test-paravirt-new-pvfb-vncdisplay.xml | 2 +- tests/xmconfigdata/test-paravirt-new-pvfb.xml | 2 +- tests/xmconfigdata/test-pci-devs.xml | 2 +- 73 files changed, 73 insertions(+), 73 deletions(-) diff --git a/tests/sexpr2xmldata/sexpr2xml-curmem.xml b/tests/sexpr2xmldata/sexpr2xml-curmem.xml index a2668d1..6932e33 100644 --- a/tests/sexpr2xmldata/sexpr2xml-curmem.xml +++ b/tests/sexpr2xmldata/sexpr2xml-curmem.xml @@ -35,7 +35,7 @@ <input type='keyboard' bus='xen'/> <graphics type='vnc' port='-1' autoport='yes'/> <video> - <model type='xen' heads='1' primary='yes'/> + <model type='xen' vram='4096' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-autoport.xml b/tests/sexpr2xmldata/sexpr2xml-fv-autoport.xml index c4b22f6..fdd7c7d 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-autoport.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-autoport.xml @@ -51,7 +51,7 @@ <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='5925' autoport='yes' keymap='en-us'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-empty-kernel.xml b/tests/sexpr2xmldata/sexpr2xml-fv-empty-kernel.xml index 17d4016..42d529c 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-empty-kernel.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-empty-kernel.xml @@ -44,7 +44,7 @@ <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes' keymap='ja'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-force-hpet.xml b/tests/sexpr2xmldata/sexpr2xml-fv-force-hpet.xml index 20a0d76..5e26804 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-force-hpet.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-force-hpet.xml @@ -47,7 +47,7 @@ <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-force-nohpet.xml b/tests/sexpr2xmldata/sexpr2xml-fv-force-nohpet.xml index 13fb299..f6af578 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-force-nohpet.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-force-nohpet.xml @@ -47,7 +47,7 @@ <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-localtime.xml b/tests/sexpr2xmldata/sexpr2xml-fv-localtime.xml index 1380426..aba6045 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-localtime.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-localtime.xml @@ -44,7 +44,7 @@ <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes' keymap='ja'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-net-netfront.xml b/tests/sexpr2xmldata/sexpr2xml-fv-net-netfront.xml index 64111fe..22e2035 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-net-netfront.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-net-netfront.xml @@ -45,7 +45,7 @@ <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes' keymap='ja'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-parallel-tcp.xml b/tests/sexpr2xmldata/sexpr2xml-fv-parallel-tcp.xml index f362aee..aa5122b 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-parallel-tcp.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-parallel-tcp.xml @@ -49,7 +49,7 @@ <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2-ports.xml b/tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2-ports.xml index 4d3bdde..bcccb94 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2-ports.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2-ports.xml @@ -56,7 +56,7 @@ <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2nd-port.xml b/tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2nd-port.xml index d3eaf82..82c41a6 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2nd-port.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2nd-port.xml @@ -52,7 +52,7 @@ <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-serial-file.xml b/tests/sexpr2xmldata/sexpr2xml-fv-serial-file.xml index 0f209d6..062f349 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-serial-file.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-serial-file.xml @@ -52,7 +52,7 @@ <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-serial-null.xml b/tests/sexpr2xmldata/sexpr2xml-fv-serial-null.xml index b157f63..38a2fb3 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-serial-null.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-serial-null.xml @@ -50,7 +50,7 @@ <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-serial-pipe.xml b/tests/sexpr2xmldata/sexpr2xml-fv-serial-pipe.xml index d9cd840..4d76e34 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-serial-pipe.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-serial-pipe.xml @@ -52,7 +52,7 @@ <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-serial-pty.xml b/tests/sexpr2xmldata/sexpr2xml-fv-serial-pty.xml index 2cffa65..e0f90ef 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-serial-pty.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-serial-pty.xml @@ -50,7 +50,7 @@ <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-serial-stdio.xml b/tests/sexpr2xmldata/sexpr2xml-fv-serial-stdio.xml index 6e473d4..7de5731 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-serial-stdio.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-serial-stdio.xml @@ -50,7 +50,7 @@ <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp-telnet.xml b/tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp-telnet.xml index f03bd29..c22e2a5 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp-telnet.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp-telnet.xml @@ -54,7 +54,7 @@ <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp.xml b/tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp.xml index 2e9c629..439a66e 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp.xml @@ -54,7 +54,7 @@ <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-serial-udp.xml b/tests/sexpr2xmldata/sexpr2xml-fv-serial-udp.xml index 3f3f676..b4bdc8a 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-serial-udp.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-serial-udp.xml @@ -54,7 +54,7 @@ <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-serial-unix.xml b/tests/sexpr2xmldata/sexpr2xml-fv-serial-unix.xml index 4f28511..af9f928 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-serial-unix.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-serial-unix.xml @@ -52,7 +52,7 @@ <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-sound-all.xml b/tests/sexpr2xmldata/sexpr2xml-fv-sound-all.xml index f934a85..d0240c4 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-sound-all.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-sound-all.xml @@ -46,7 +46,7 @@ <sound model='sb16'/> <sound model='es1370'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-sound.xml b/tests/sexpr2xmldata/sexpr2xml-fv-sound.xml index f934a85..d0240c4 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-sound.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-sound.xml @@ -46,7 +46,7 @@ <sound model='sb16'/> <sound model='es1370'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-usbmouse.xml b/tests/sexpr2xmldata/sexpr2xml-fv-usbmouse.xml index 8b5887e..e84e172 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-usbmouse.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-usbmouse.xml @@ -45,7 +45,7 @@ <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes' keymap='ja'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-usbtablet.xml b/tests/sexpr2xmldata/sexpr2xml-fv-usbtablet.xml index 3e4b366..187d867 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-usbtablet.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-usbtablet.xml @@ -45,7 +45,7 @@ <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes' keymap='ja'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-utc.xml b/tests/sexpr2xmldata/sexpr2xml-fv-utc.xml index 9c2b9e3..2816f4a 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-utc.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-utc.xml @@ -44,7 +44,7 @@ <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes' keymap='ja'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-fv-v2.xml b/tests/sexpr2xmldata/sexpr2xml-fv-v2.xml index 9c2b9e3..2816f4a 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv-v2.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv-v2.xml @@ -44,7 +44,7 @@ <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes' keymap='ja'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-fv.xml b/tests/sexpr2xmldata/sexpr2xml-fv.xml index 9c2b9e3..2816f4a 100644 --- a/tests/sexpr2xmldata/sexpr2xml-fv.xml +++ b/tests/sexpr2xmldata/sexpr2xml-fv.xml @@ -44,7 +44,7 @@ <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes' keymap='ja'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml b/tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml index 97d9482..41fb3b7 100644 --- a/tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml +++ b/tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml @@ -49,7 +49,7 @@ <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-pv-vfb-new-vncdisplay.xml b/tests/sexpr2xmldata/sexpr2xml-pv-vfb-new-vncdisplay.xml index dbdacf9..72fec25 100644 --- a/tests/sexpr2xmldata/sexpr2xml-pv-vfb-new-vncdisplay.xml +++ b/tests/sexpr2xmldata/sexpr2xml-pv-vfb-new-vncdisplay.xml @@ -30,7 +30,7 @@ <listen type='address' address='0.0.0.0'/> </graphics> <video> - <model type='xen' heads='1' primary='yes'/> + <model type='xen' vram='4096' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-pv-vfb-new.xml b/tests/sexpr2xmldata/sexpr2xml-pv-vfb-new.xml index c415aab..0fd7a88 100644 --- a/tests/sexpr2xmldata/sexpr2xml-pv-vfb-new.xml +++ b/tests/sexpr2xmldata/sexpr2xml-pv-vfb-new.xml @@ -30,7 +30,7 @@ <listen type='address' address='0.0.0.0'/> </graphics> <video> - <model type='xen' heads='1' primary='yes'/> + <model type='xen' vram='4096' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-pv-vfb-type-crash.xml b/tests/sexpr2xmldata/sexpr2xml-pv-vfb-type-crash.xml index c1acba1..ee24536 100644 --- a/tests/sexpr2xmldata/sexpr2xml-pv-vfb-type-crash.xml +++ b/tests/sexpr2xmldata/sexpr2xml-pv-vfb-type-crash.xml @@ -33,7 +33,7 @@ <input type='keyboard' bus='xen'/> <graphics type='vnc' port='-1' autoport='yes'/> <video> - <model type='xen' heads='1' primary='yes'/> + <model type='xen' vram='4096' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/sexpr2xmldata/sexpr2xml-vif-rate.xml b/tests/sexpr2xmldata/sexpr2xml-vif-rate.xml index 45887e5..1ebd5f0 100644 --- a/tests/sexpr2xmldata/sexpr2xml-vif-rate.xml +++ b/tests/sexpr2xmldata/sexpr2xml-vif-rate.xml @@ -48,7 +48,7 @@ <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes' keymap='ja'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xlconfigdata/test-disk-positional-parms-full.xml b/tests/xlconfigdata/test-disk-positional-parms-full.xml index 3d4868c..41e8804 100644 --- a/tests/xlconfigdata/test-disk-positional-parms-full.xml +++ b/tests/xlconfigdata/test-disk-positional-parms-full.xml @@ -52,7 +52,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='8192' heads='1' primary='yes'/> </video> </devices> </domain> diff --git a/tests/xlconfigdata/test-disk-positional-parms-partial.xml b/tests/xlconfigdata/test-disk-positional-parms-partial.xml index 402f479..6578e59 100644 --- a/tests/xlconfigdata/test-disk-positional-parms-partial.xml +++ b/tests/xlconfigdata/test-disk-positional-parms-partial.xml @@ -52,7 +52,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='8192' heads='1' primary='yes'/> </video> </devices> </domain> diff --git a/tests/xlconfigdata/test-fullvirt-direct-kernel-boot-bogus-extra.xml b/tests/xlconfigdata/test-fullvirt-direct-kernel-boot-bogus-extra.xml index 686a409..3738c8e 100644 --- a/tests/xlconfigdata/test-fullvirt-direct-kernel-boot-bogus-extra.xml +++ b/tests/xlconfigdata/test-fullvirt-direct-kernel-boot-bogus-extra.xml @@ -49,7 +49,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='8192' heads='1' primary='yes'/> </video> </devices> </domain> diff --git a/tests/xlconfigdata/test-fullvirt-direct-kernel-boot-extra.xml b/tests/xlconfigdata/test-fullvirt-direct-kernel-boot-extra.xml index 686a409..3738c8e 100644 --- a/tests/xlconfigdata/test-fullvirt-direct-kernel-boot-extra.xml +++ b/tests/xlconfigdata/test-fullvirt-direct-kernel-boot-extra.xml @@ -49,7 +49,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='8192' heads='1' primary='yes'/> </video> </devices> </domain> diff --git a/tests/xlconfigdata/test-fullvirt-direct-kernel-boot.xml b/tests/xlconfigdata/test-fullvirt-direct-kernel-boot.xml index 686a409..3738c8e 100644 --- a/tests/xlconfigdata/test-fullvirt-direct-kernel-boot.xml +++ b/tests/xlconfigdata/test-fullvirt-direct-kernel-boot.xml @@ -49,7 +49,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='8192' heads='1' primary='yes'/> </video> </devices> </domain> diff --git a/tests/xlconfigdata/test-fullvirt-multiusb.xml b/tests/xlconfigdata/test-fullvirt-multiusb.xml index 5ec72c4..d7df23a 100644 --- a/tests/xlconfigdata/test-fullvirt-multiusb.xml +++ b/tests/xlconfigdata/test-fullvirt-multiusb.xml @@ -48,7 +48,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='8192' heads='1' primary='yes'/> </video> </devices> </domain> diff --git a/tests/xlconfigdata/test-fullvirt-nohap.xml b/tests/xlconfigdata/test-fullvirt-nohap.xml index a997c7a..9cd7b0b 100644 --- a/tests/xlconfigdata/test-fullvirt-nohap.xml +++ b/tests/xlconfigdata/test-fullvirt-nohap.xml @@ -56,7 +56,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='8192' heads='1' primary='yes'/> </video> </devices> </domain> diff --git a/tests/xlconfigdata/test-new-disk.xml b/tests/xlconfigdata/test-new-disk.xml index 3d4868c..41e8804 100644 --- a/tests/xlconfigdata/test-new-disk.xml +++ b/tests/xlconfigdata/test-new-disk.xml @@ -52,7 +52,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='8192' heads='1' primary='yes'/> </video> </devices> </domain> diff --git a/tests/xlconfigdata/test-rbd-multihost-noauth.xml b/tests/xlconfigdata/test-rbd-multihost-noauth.xml index f8f663f..728aa1e 100644 --- a/tests/xlconfigdata/test-rbd-multihost-noauth.xml +++ b/tests/xlconfigdata/test-rbd-multihost-noauth.xml @@ -49,7 +49,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='8192' heads='1' primary='yes'/> </video> </devices> </domain> diff --git a/tests/xlconfigdata/test-spice-features.xml b/tests/xlconfigdata/test-spice-features.xml index f9eb857..3820732 100644 --- a/tests/xlconfigdata/test-spice-features.xml +++ b/tests/xlconfigdata/test-spice-features.xml @@ -48,7 +48,7 @@ <clipboard copypaste='yes'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='8192' heads='1' primary='yes'/> </video> </devices> </domain> diff --git a/tests/xlconfigdata/test-spice.xml b/tests/xlconfigdata/test-spice.xml index fc2fa3f..f33691f 100644 --- a/tests/xlconfigdata/test-spice.xml +++ b/tests/xlconfigdata/test-spice.xml @@ -48,7 +48,7 @@ <clipboard copypaste='no'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='8192' heads='1' primary='yes'/> </video> </devices> </domain> diff --git a/tests/xlconfigdata/test-vif-rate.xml b/tests/xlconfigdata/test-vif-rate.xml index 0e13f2e..3620e2a 100644 --- a/tests/xlconfigdata/test-vif-rate.xml +++ b/tests/xlconfigdata/test-vif-rate.xml @@ -55,7 +55,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='8192' heads='1' primary='yes'/> </video> </devices> </domain> diff --git a/tests/xmconfigdata/test-escape-paths.xml b/tests/xmconfigdata/test-escape-paths.xml index 6373fdf..a5daa2c 100644 --- a/tests/xmconfigdata/test-escape-paths.xml +++ b/tests/xmconfigdata/test-escape-paths.xml @@ -54,7 +54,7 @@ <sound model='sb16'/> <sound model='es1370'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-fullvirt-default-feature.xml b/tests/xmconfigdata/test-fullvirt-default-feature.xml index 6f4dae6..ce1280d 100644 --- a/tests/xmconfigdata/test-fullvirt-default-feature.xml +++ b/tests/xmconfigdata/test-fullvirt-default-feature.xml @@ -48,7 +48,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-fullvirt-force-hpet.xml b/tests/xmconfigdata/test-fullvirt-force-hpet.xml index 6f4dae6..ce1280d 100644 --- a/tests/xmconfigdata/test-fullvirt-force-hpet.xml +++ b/tests/xmconfigdata/test-fullvirt-force-hpet.xml @@ -48,7 +48,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-fullvirt-force-nohpet.xml b/tests/xmconfigdata/test-fullvirt-force-nohpet.xml index 6015405..7636f31 100644 --- a/tests/xmconfigdata/test-fullvirt-force-nohpet.xml +++ b/tests/xmconfigdata/test-fullvirt-force-nohpet.xml @@ -48,7 +48,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-fullvirt-localtime.xml b/tests/xmconfigdata/test-fullvirt-localtime.xml index 5f81e25..b3adf86 100644 --- a/tests/xmconfigdata/test-fullvirt-localtime.xml +++ b/tests/xmconfigdata/test-fullvirt-localtime.xml @@ -46,7 +46,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-fullvirt-net-netfront.xml b/tests/xmconfigdata/test-fullvirt-net-netfront.xml index cb0615b..c22ad8d 100644 --- a/tests/xmconfigdata/test-fullvirt-net-netfront.xml +++ b/tests/xmconfigdata/test-fullvirt-net-netfront.xml @@ -46,7 +46,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-fullvirt-new-cdrom.xml b/tests/xmconfigdata/test-fullvirt-new-cdrom.xml index d29892e..2bb3d72 100644 --- a/tests/xmconfigdata/test-fullvirt-new-cdrom.xml +++ b/tests/xmconfigdata/test-fullvirt-new-cdrom.xml @@ -46,7 +46,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-fullvirt-nohap.xml b/tests/xmconfigdata/test-fullvirt-nohap.xml index f38366c..234856c 100644 --- a/tests/xmconfigdata/test-fullvirt-nohap.xml +++ b/tests/xmconfigdata/test-fullvirt-nohap.xml @@ -47,7 +47,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-fullvirt-parallel-tcp.xml b/tests/xmconfigdata/test-fullvirt-parallel-tcp.xml index 3269aee..be149fd 100644 --- a/tests/xmconfigdata/test-fullvirt-parallel-tcp.xml +++ b/tests/xmconfigdata/test-fullvirt-parallel-tcp.xml @@ -51,7 +51,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-fullvirt-serial-dev-2-ports.xml b/tests/xmconfigdata/test-fullvirt-serial-dev-2-ports.xml index a20d6c8..753043d 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-dev-2-ports.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-dev-2-ports.xml @@ -58,7 +58,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-fullvirt-serial-dev-2nd-port.xml b/tests/xmconfigdata/test-fullvirt-serial-dev-2nd-port.xml index 8344da3..a104c6f 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-dev-2nd-port.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-dev-2nd-port.xml @@ -54,7 +54,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-fullvirt-serial-file.xml b/tests/xmconfigdata/test-fullvirt-serial-file.xml index b9439d7..f27aba9 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-file.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-file.xml @@ -54,7 +54,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-fullvirt-serial-null.xml b/tests/xmconfigdata/test-fullvirt-serial-null.xml index 6e8196b..ea29944 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-null.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-null.xml @@ -52,7 +52,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-fullvirt-serial-pipe.xml b/tests/xmconfigdata/test-fullvirt-serial-pipe.xml index da0c9bd..69bf51c 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-pipe.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-pipe.xml @@ -54,7 +54,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-fullvirt-serial-pty.xml b/tests/xmconfigdata/test-fullvirt-serial-pty.xml index acff588..0c6e477 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-pty.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-pty.xml @@ -52,7 +52,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-fullvirt-serial-stdio.xml b/tests/xmconfigdata/test-fullvirt-serial-stdio.xml index 6909053..1f12081 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-stdio.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-stdio.xml @@ -52,7 +52,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-fullvirt-serial-tcp-telnet.xml b/tests/xmconfigdata/test-fullvirt-serial-tcp-telnet.xml index a3fd449..47544df 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-tcp-telnet.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-tcp-telnet.xml @@ -56,7 +56,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-fullvirt-serial-tcp.xml b/tests/xmconfigdata/test-fullvirt-serial-tcp.xml index 9dba76d..8f1777a 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-tcp.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-tcp.xml @@ -56,7 +56,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-fullvirt-serial-udp.xml b/tests/xmconfigdata/test-fullvirt-serial-udp.xml index 3577f92..c59e2b6 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-udp.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-udp.xml @@ -56,7 +56,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-fullvirt-serial-unix.xml b/tests/xmconfigdata/test-fullvirt-serial-unix.xml index 919108b..e678786 100644 --- a/tests/xmconfigdata/test-fullvirt-serial-unix.xml +++ b/tests/xmconfigdata/test-fullvirt-serial-unix.xml @@ -54,7 +54,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-fullvirt-sound.xml b/tests/xmconfigdata/test-fullvirt-sound.xml index 0e85953..3bd2e76 100644 --- a/tests/xmconfigdata/test-fullvirt-sound.xml +++ b/tests/xmconfigdata/test-fullvirt-sound.xml @@ -48,7 +48,7 @@ <sound model='sb16'/> <sound model='es1370'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-fullvirt-usbmouse.xml b/tests/xmconfigdata/test-fullvirt-usbmouse.xml index 8eb5aa5..f1421b6 100644 --- a/tests/xmconfigdata/test-fullvirt-usbmouse.xml +++ b/tests/xmconfigdata/test-fullvirt-usbmouse.xml @@ -47,7 +47,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-fullvirt-usbtablet.xml b/tests/xmconfigdata/test-fullvirt-usbtablet.xml index dcdd951..566c842 100644 --- a/tests/xmconfigdata/test-fullvirt-usbtablet.xml +++ b/tests/xmconfigdata/test-fullvirt-usbtablet.xml @@ -47,7 +47,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-fullvirt-utc.xml b/tests/xmconfigdata/test-fullvirt-utc.xml index d29892e..2bb3d72 100644 --- a/tests/xmconfigdata/test-fullvirt-utc.xml +++ b/tests/xmconfigdata/test-fullvirt-utc.xml @@ -46,7 +46,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-no-source-cdrom.xml b/tests/xmconfigdata/test-no-source-cdrom.xml index d4c2fd6..246123c 100644 --- a/tests/xmconfigdata/test-no-source-cdrom.xml +++ b/tests/xmconfigdata/test-no-source-cdrom.xml @@ -49,7 +49,7 @@ <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-paravirt-net-e1000.xml b/tests/xmconfigdata/test-paravirt-net-e1000.xml index ad44d11..735e8b0 100644 --- a/tests/xmconfigdata/test-paravirt-net-e1000.xml +++ b/tests/xmconfigdata/test-paravirt-net-e1000.xml @@ -33,7 +33,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='xen' heads='1' primary='yes'/> + <model type='xen' vram='4096' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-paravirt-net-vifname.xml b/tests/xmconfigdata/test-paravirt-net-vifname.xml index e94b685..3ce3639 100644 --- a/tests/xmconfigdata/test-paravirt-net-vifname.xml +++ b/tests/xmconfigdata/test-paravirt-net-vifname.xml @@ -34,7 +34,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='xen' heads='1' primary='yes'/> + <model type='xen' vram='4096' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-paravirt-new-pvfb-vncdisplay.xml b/tests/xmconfigdata/test-paravirt-new-pvfb-vncdisplay.xml index 3ca3023..20c31ec 100644 --- a/tests/xmconfigdata/test-paravirt-new-pvfb-vncdisplay.xml +++ b/tests/xmconfigdata/test-paravirt-new-pvfb-vncdisplay.xml @@ -32,7 +32,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='xen' heads='1' primary='yes'/> + <model type='xen' vram='4096' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-paravirt-new-pvfb.xml b/tests/xmconfigdata/test-paravirt-new-pvfb.xml index d97799a..33c48f4 100644 --- a/tests/xmconfigdata/test-paravirt-new-pvfb.xml +++ b/tests/xmconfigdata/test-paravirt-new-pvfb.xml @@ -32,7 +32,7 @@ <listen type='address' address='127.0.0.1'/> </graphics> <video> - <model type='xen' heads='1' primary='yes'/> + <model type='xen' vram='4096' heads='1' primary='yes'/> </video> <memballoon model='xen'/> </devices> diff --git a/tests/xmconfigdata/test-pci-devs.xml b/tests/xmconfigdata/test-pci-devs.xml index 4c3f5f2..a88853d 100644 --- a/tests/xmconfigdata/test-pci-devs.xml +++ b/tests/xmconfigdata/test-pci-devs.xml @@ -49,7 +49,7 @@ <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes'/> <video> - <model type='cirrus' heads='1' primary='yes'/> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> </video> <hostdev mode='subsystem' type='pci' managed='no'> <source> -- 2.7.3

2 1

[libvirt] adding a new libvirt xml element for File Descriptor backed memory for use with vhost-user
by Mooney, Sean K 12 May '16

12 May '16

Hi I work mostly in OpenStack on enabling ovs with dpdk. When deploying vms on host running ovs with dpdk vms are booted utilizing Vhost-user interfaces. Qemu support creating vms with vhost-user network interfaces as of v2.1. Libvirt currently has support for requesting the use of vhost-user interfaces by added the following xml fragment <interface type='vhostuser'> <mac address='fa:16:3e:ea:2a:08'/> <source type='unix' path='/var/run/openvswitch/vhuf1204e0c-98' mode='client'/> <model type='virtio'/> <alias name='net0'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> </interface> Send traffic via a vhost-user interface, the vhost-user frontend (provided by qemu) must share the virtios ring to the vhost-backed via passing a file descript to the memory backing object of the qemu instance as part of the port creation. Today the only native way to request Libvirt to create a vm who's memory is backed by a memdev which can be Accessed via a file descriptor is to request hugepage backed memory. This requires the operator to Manage and configure hugepage on each of their compute hosts and take special care to ensure that vms are Not placed on host were vhost-user interface are used if they do not request hugepages. Today it is possible to use Libvirt to spawn a vm without hugepage memory and a file descriptor backed memdev Via the use of the qemu:commandline element. <qemu:commandline> <qemu:arg value='-object'/> <qemu:arg value='memory-backend-file,id=mem,size=1024M,mem-path=/var/lib/libvirt/qemu,share=on'/> <qemu:arg value='-numa'/> <qemu:arg value='node,memdev=mem'/> <qemu:arg value='-mem-prealloc'/> </qemu:commandline> I created a proof of concept patch to nova to demonstrate that this works however to support this usecase in Nova a new xml element is required. https://review.openstack.org/#/c/309565/1 I would like to propose the introduction of a new subelemnt to the memorybacking element to request file discrptro backed memory <memoryBacking> <filedescriptor size_mb="1024" path="/var/lib/libvirt/qemu" prealloc="true" shared="on" /> </memoryBacking> The above filedescriptor xml fragment above would then be parsed to generate the same qemu argument as the qemu:commandline fragment Therefor allowing the creation of a vm with vhost-user interface without hugepage memory backing. Before I start looking at the Libvirt code base I wanted to ask if the Libvirt community would be open to this change and what would be the best way To approach enabling this feature. Regards Sean.

2 4

[libvirt] [PATCH] qemu: domain: Fix name of macro defining AES IV length
by Peter Krempa 12 May '16

12 May '16

The initialization vector is a technical term by itself different from the key. --- src/qemu/qemu_domain.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index 331ade0..dd90e67 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -254,8 +254,8 @@ struct _qemuDomainSecretPlain { char *secret; }; -# define QEMU_DOMAIN_AES_IV_KEY_LEN 16 /* 16 bytes for 128 bit random */ - /* initialization vector */ +# define QEMU_DOMAIN_AES_IV_LEN 16 /* 16 bytes for 128 bit random */ + /* initialization vector */ typedef struct _qemuDomainSecretAES qemuDomainSecretAES; typedef struct _qemuDomainSecretAES *qemuDomainSecretAESPtr; struct _qemuDomainSecretAES { -- 2.8.2

2 1

[libvirt] [PATCH 0/3] libxl: support Xen migration stream V2
by Jim Fehlig 12 May '16

12 May '16

Hi all, This patch adds support for Xen migration stream V2 to the libvirt libxl driver. In the process it fixes save/restore and migration tests in OSSTest, which have been failing since libvirt commit e7440656. Patch1 changes the libxl API requirement from version 4.2 to 4.4, enabling use of an extended libxl_domain_create_restore() function that allows passing restore parameters such as stream version. Patch2 adds support for migration stream V2 in the basic save/restore logic, taking advantage of a save image header that includes a version field. The version is set to '2' if the host produces a V2 migration stream. This patch fixes the failing save/restore tests in OSSTest. Patch3 adds support for migration stream V2 in the migration logic. The migration code does not use the save image header and instead uses libvirt's migration protocol to transfer domain configuration and other such goodies from source to destination. The patch enables sending version information in the Begin and Prepare migration phases so the correct stream version information can be passed to libxl_domain_create_restore(). An upshot of this approach is safely detecting and aborting a migration from a V2 host to a V1-only host. This patch fixes the failing migration tests in OSSTest. Jim Fehlig (3): libxl: switch to using libxl_domain_create_restore from v4.4 API libxl: support Xen migration stream V2 in save/restore libxl: support migration stream V2 in migration configure.ac | 9 +- src/libxl/libxl_conf.h | 6 +- src/libxl/libxl_domain.c | 46 ++++++++-- src/libxl/libxl_domain.h | 14 ++- src/libxl/libxl_driver.c | 27 +++--- src/libxl/libxl_migration.c | 204 +++++++++++++++++++++++++++++++++++++++++++- src/libxl/libxl_migration.h | 6 +- 7 files changed, 282 insertions(+), 30 deletions(-) -- 2.1.4

5 13

[libvirt] [PATCH] libxl: fix default vram setting for implicit video device
by Jim Fehlig 12 May '16

12 May '16

Commit 6879be48 moved adding of an implicit video device after XML parsing. As a result, libxlDomainDeviceDefPostParse() is no longer called to set the default vram when adding an implicit device. Commit 6879be48 assumes virDomainVideoDefaultRAM() will set the default vram, but it returns 0 if the domain virtType is VIR_DOMAIN_VIRT_XEN. Attempting to start an HVM domain with vram=0 results in error: unsupported configuration: videoram must be at least 4MB for CIRRUS The default vram setting for Xen HVM domains depends on the device model used (qemu-xen vs qemu-traditional), hence setting the default is deferred to libxlDomainDeviceDefPostParse(). This patch addresses the problem during creation of the video device. If vram is 0, it is assumed unset and the default (depending on qemu-xen vs qemu-traditional) is applied. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1334557 Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- src/libxl/libxl_conf.c | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index d927b37..1973ded 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -1916,6 +1916,40 @@ libxlMakePCIList(virDomainDefPtr def, libxl_domain_config *d_config) return -1; } +static unsigned int +libxlVideoDefaultRAM(const virDomainVideoType type, int dm_type) +{ + unsigned int ret = 0; + + switch (type) { + case VIR_DOMAIN_VIDEO_TYPE_VGA: + case VIR_DOMAIN_VIDEO_TYPE_XEN: + if (dm_type == LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) + ret = 16 * 1024; + else + ret = 8 * 1024; + break; + + case VIR_DOMAIN_VIDEO_TYPE_CIRRUS: + if (dm_type == LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) + ret = 8 * 1024; + else + ret = 4 * 1024; + break; + +#ifdef LIBXL_HAVE_QXL + case VIR_DOMAIN_VIDEO_TYPE_QXL: + ret = 128 * 1024; + break; +#endif + + default: + break; + } + + return ret; +} + static int libxlMakeVideo(virDomainDefPtr def, libxl_domain_config *d_config) @@ -1931,6 +1965,10 @@ libxlMakeVideo(virDomainDefPtr def, libxl_domain_config *d_config) * on the first graphics device (display). */ if (def->nvideos) { + if (def->videos[0]->vram == 0) + def->videos[0]->vram = libxlVideoDefaultRAM(def->videos[0]->type, + dm_type); + switch (def->videos[0]->type) { case VIR_DOMAIN_VIDEO_TYPE_VGA: case VIR_DOMAIN_VIDEO_TYPE_XEN: -- 2.1.4

3 4

Re: [libvirt] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types
by Eduardo Habkost 12 May '16

12 May '16

On Thu, May 12, 2016 at 12:29:55PM +0200, Igor Mammedov wrote: > On Thu, 12 May 2016 10:07:03 +0300 > "Michael S. Tsirkin" <mst(a)redhat.com> wrote: > > > On Wed, May 11, 2016 at 08:28:59PM -0300, Eduardo Habkost wrote: > > > On Thu, May 12, 2016 at 12:51:55AM +0300, Michael S. Tsirkin wrote: > > > > On Wed, May 11, 2016 at 03:50:39PM +0200, Igor Mammedov wrote: > > > > > On Tue, 10 May 2016 17:24:14 -0300 > > > > > Eduardo Habkost <ehabkost(a)redhat.com> wrote: > > > > > > > > > > > On Mon, May 02, 2016 at 02:33:21PM +0200, Igor Mammedov wrote: > > > > > > > on old machine types CPU hotplug was uncondtionally > > > > > > > enabled since it was introduced, consuming IO ports > > > > > > > and providing AML regardles of whether it was actually > > > > > > > in use or not. Keep it so for 2.6 and older machines. > > > > > > > > > > > > > > New machine types will have an option to turn CPU > > > > > > > hotplug on if it's needed while by default it stays > > > > > > > disabled not consuming extra RAM/IO resources. > > > > > > > > > > > > > > Signed-off-by: Igor Mammedov <imammedo(a)redhat.com> > > > > > > > > > > > > What if people are using "-machine pc -smp N,max_cpus=M"? > > > > > > Shouldn't we at least warning about missing CPU hotplug support > > > > > > when using just "max_cpus" with no "cpu-hotplug=on" with pc-2.7 > > > > > > and newer? > > > > > Yep, I'll add it on next respin. > > > > > Would hard error better than warning? > > > > > > > > Most people don't need cpu hotplug, attempts > > > > to hotplug fail, should be enough. > > > > > > People who don't need CPU hotplug shouldn't be using the max_cpus > > > option. > > > > I agree. > > > > > I believe we should at least warn people (early, during > > > initialization) that their configuration don't make sense > > > anymore. > > > > I think we should try to keep old command line working > > if we can. > this patch won't break old command line for old machine types, > but for new machine type users would need to fix it > and be explicit if they want cpu-hotplug. I don't think we should do that, unless users already had time to update their scripts and libvirt had time to implement code supporting the new method. I believe libvirt (and people's scripts) use maxcpus only when they want CPU hotplug, so making max_cpus > smp_cpus enable CPU hotplug implicitly would probably solve the compatibility issue. If we want to deprecate the use of maxcpus to enable CPU hotplug, then we can make it print a warning for a few releases, so people have time to update their code. -- Eduardo

3 4

[libvirt] [PATCH 1/2] tests: Adding <backenddomain/> option for xml2sexpr-net-bridge data test.
by Julio Faracco 12 May '16

12 May '16

There is no XML data file that is using <backenddomain/> option for network. It is a good opportunity to test/check this option for Xen. Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- tests/xml2sexprdata/xml2sexpr-net-bridged.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/xml2sexprdata/xml2sexpr-net-bridged.xml b/tests/xml2sexprdata/xml2sexpr-net-bridged.xml index d995d19..aec2c0d 100644 --- a/tests/xml2sexprdata/xml2sexpr-net-bridged.xml +++ b/tests/xml2sexprdata/xml2sexpr-net-bridged.xml @@ -22,6 +22,7 @@ <source bridge="xenbr2"/> <script path="vif-bridge"/> <target dev="vif4.0"/> + <backenddomain name='pvtest'/> </interface> <console tty='/dev/pts/4'/> </devices> -- 1.9.1

1 1

[libvirt] [PATCH 0/3] Secrets adjustments
by John Ferlan 12 May '16

12 May '16

Fallout from review of v3 of the IV Secrets: http://www.redhat.com/archives/libvir-list/2016-May/msg00444.html Add a new buffer escape API to handle printing a sized buffer Alter the existing fetch, store, and printing of the secret to be a "uint8_t *" rather than "(unsigned) char *". Change the name of SecretIV to SecretAES Figured I'd work through the getting the naming right first... John Ferlan (3): util: Introduce virBufferEscapeSizedBuf secret: Alter virSecretGetSecretString qemu: Change from SecretIV or _IV to SecretAES or _AES src/libvirt_private.syms | 1 + src/libxl/libxl_conf.c | 18 +++++++++------- src/qemu/qemu_command.c | 11 +++++----- src/qemu/qemu_domain.c | 11 +++++----- src/qemu/qemu_domain.h | 17 ++++++++------- src/secret/secret_util.c | 19 +++++++++++++---- src/secret/secret_util.h | 13 ++++++------ src/util/virbuffer.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++++ src/util/virbuffer.h | 3 +++ 9 files changed, 112 insertions(+), 35 deletions(-) -- 2.5.5

2 8

[libvirt] [PATCH v2 0/3] Introduce big test mock
by Michal Privoznik 12 May '16

12 May '16

v2 of: https://www.redhat.com/archives/libvir-list/2016-April/msg01410.html diff to v1: - I've pushed the first patch of the original series - Rebased onto current master (as Jirka's introduction of qemucapsprobe made my patches not applicable). Michal Privoznik (3): tests: Introduce global mock library virtestmock: Print invalid file accesses into a file tests: Introduce check-file-access.pl .gitignore | 1 + HACKING | 11 ++ Makefile.am | 3 + cfg.mk | 8 +- docs/hacking.html.in | 15 +++ tests/Makefile.am | 26 +++- tests/check-file-access.pl | 106 +++++++++++++++ tests/file_access_whitelist.txt | 23 ++++ tests/testutils.c | 34 ++++- tests/testutils.h | 10 +- tests/vircgroupmock.c | 6 +- tests/virpcimock.c | 6 +- tests/virtestmock.c | 279 ++++++++++++++++++++++++++++++++++++++++ 13 files changed, 507 insertions(+), 21 deletions(-) create mode 100755 tests/check-file-access.pl create mode 100644 tests/file_access_whitelist.txt create mode 100644 tests/virtestmock.c -- 2.8.1

2 11

[libvirt] [PATCH v2 00/12] improve graphics listen configuration
by Pavel Hrdina 12 May '16

12 May '16

This patch series improves the way how different listen types can be specified and also introduce a new listen types for graphics devices. First improvement is to move ports out of graphics element into listen element with type address or network. This is a first step to make the code listen-driven. Second step is to create a new listen type socket to improve the current vnc configuration and to print only socket path witout any other listen types. With the new socket type now we can add support also to spice graphics. The last improvement is to introduce new listen type none for spice graphics to specify that the spice graphics shouldn't listen anywhere by default. In case of spice graphics the new listen types socket or none are required to start a guest with OpenGL support. Changes in v2: - don't remove vnc_auto_unix_socket from qemu.conf - add spice_auto_unix_socket Pavel Hrdina (12): graphics: don't parse listens if socket attribute is present domain_conf: parse listen attribute while parsing listen elements graphics: make address attribute for listen type='address' optional domain_conf: cleanup virDomainGraphicsListenDefParseXML graphics: move port definition to listen element graphics: introduce listen type=socket and use it for VNC qemu_capabilites: add QEMU_CAPS_SPICE_UNIX spice: add support for listen type socket qemu_process: separate graphics socket and address generation tests: cleanup vnc auto socket test spice: introduce spice_auto_unix_socket config option spice: introduce listen type none docs/formatdomain.html.in | 138 +++-- docs/schemas/domaincommon.rng | 63 ++- src/conf/domain_conf.c | 602 +++++++++++++-------- src/conf/domain_conf.h | 31 +- src/libvirt_private.syms | 1 + src/libxl/libxl_conf.c | 53 +- src/libxl/libxl_domain.c | 17 +- src/qemu/qemu.conf | 11 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 256 ++++----- src/qemu/qemu_conf.c | 1 + src/qemu/qemu_conf.h | 1 + src/qemu/qemu_domain.c | 19 +- src/qemu/qemu_hotplug.c | 40 +- src/qemu/qemu_migration.c | 50 +- src/qemu/qemu_parse_command.c | 41 +- src/qemu/qemu_process.c | 351 +++++++----- src/security/virt-aa-helper.c | 15 +- src/vbox/vbox_common.c | 30 +- src/vbox/vbox_tmpl.c | 34 +- src/vbox/vbox_uniformed_api.h | 4 +- src/vmx/vmx.c | 54 +- src/vz/vz_sdk.c | 30 +- src/xenconfig/xen_common.c | 74 +-- src/xenconfig/xen_sxpr.c | 71 +-- src/xenconfig/xen_xl.c | 45 +- .../generic-graphics-listen-back-compat-ports.xml | 30 + ...generic-graphics-vnc-listen-element-minimal.xml | 2 +- ...aphics-vnc-listen-element-with-address-port.xml | 30 + .../generic-graphics-listen-back-compat-ports.xml | 30 + .../generic-graphics-listen-back-compat.xml | 2 +- .../generic-graphics-vnc-listen-attr-only.xml | 2 +- ...generic-graphics-vnc-listen-element-minimal.xml | 4 +- ...aphics-vnc-listen-element-with-address-port.xml | 30 + ...ic-graphics-vnc-listen-element-with-address.xml | 2 +- .../generic-graphics-vnc-manual-port.xml | 4 +- .../generic-graphics-vnc-minimal.xml | 4 +- .../generic-graphics-vnc-socket-listen.xml | 2 +- .../generic-graphics-vnc-socket.xml | 4 +- tests/genericxml2xmltest.c | 3 + .../qemuargv2xml-graphics-vnc-policy.xml | 2 +- .../qemuargv2xml-graphics-vnc-sasl.xml | 2 +- .../qemuargv2xml-graphics-vnc-socket.xml | 4 +- .../qemuargv2xml-graphics-vnc-tls.xml | 2 +- .../qemuargv2xml-graphics-vnc-websocket.xml | 2 +- .../qemuargv2xmldata/qemuargv2xml-graphics-vnc.xml | 2 +- ...qemuhotplug-console-compat-2+console-virtio.xml | 2 +- .../qemuxml2argv-console-compat-2.xml | 2 +- ...emuxml2argv-graphics-spice-auto-socket-cfg.args | 20 + ...qemuxml2argv-graphics-spice-auto-socket-cfg.xml | 30 + .../qemuxml2argv-graphics-spice-auto-socket.args | 20 + .../qemuxml2argv-graphics-spice-auto-socket.xml | 30 + .../qemuxml2argv-graphics-spice-socket.args | 20 + .../qemuxml2argv-graphics-spice-socket.xml | 30 + .../qemuxml2argv-graphics-vnc-auto-socket-cfg.args | 22 + .../qemuxml2argv-graphics-vnc-auto-socket-cfg.xml | 34 ++ .../qemuxml2argv-graphics-vnc-auto-socket.args | 20 + .../qemuxml2argv-graphics-vnc-auto-socket.xml | 30 + .../qemuxml2argv-graphics-vnc-autosocket.args | 22 - .../qemuxml2argv-graphics-vnc-autosocket.xml | 34 -- .../qemuxml2argv-graphics-vnc-socket.args | 4 +- .../qemuxml2argv-graphics-vnc-socket.xml | 10 +- .../qemuxml2argv-video-virtio-gpu-spice-gl.args | 2 +- tests/qemuxml2argvtest.c | 16 + .../qemuxml2xmlout-graphics-listen-network.xml | 2 +- .../qemuxml2xmlout-graphics-listen-network2.xml | 4 +- ...muxml2xmlout-graphics-spice-auto-socket-cfg.xml | 35 ++ .../qemuxml2xmlout-graphics-spice-auto-socket.xml | 35 ++ .../qemuxml2xmlout-graphics-spice-compression.xml | 2 +- .../qemuxml2xmlout-graphics-spice-qxl-vga.xml | 2 +- .../qemuxml2xmlout-graphics-spice-socket.xml | 35 ++ .../qemuxml2xmlout-graphics-spice-timeout.xml | 4 +- .../qemuxml2xmlout-graphics-spice.xml | 2 +- ...qemuxml2xmlout-graphics-vnc-auto-socket-cfg.xml | 41 ++ .../qemuxml2xmlout-graphics-vnc-auto-socket.xml | 35 ++ .../qemuxml2xmlout-graphics-vnc-autosocket.xml | 39 -- .../qemuxml2xmlout-graphics-vnc-no-listen-attr.xml | 2 +- .../qemuxml2xmlout-graphics-vnc-sasl.xml | 2 +- .../qemuxml2xmlout-graphics-vnc-socket.xml | 35 ++ .../qemuxml2xmlout-graphics-vnc-tls.xml | 2 +- .../qemuxml2xmlout-graphics-vnc-websocket.xml | 2 +- .../qemuxml2xmlout-graphics-vnc.xml | 2 +- .../qemuxml2xmlout-interface-server.xml | 4 +- .../qemuxml2xmlout-net-bandwidth.xml | 4 +- .../qemuxml2xmlout-net-bandwidth2.xml | 4 +- .../qemuxml2xmlout-pci-bridge.xml | 2 +- ...emuxml2xmlout-seclabel-dynamic-none-relabel.xml | 2 +- .../qemuxml2xmlout-serial-spiceport.xml | 2 +- .../qemuxml2xmlout-video-virtio-gpu-spice-gl.xml | 3 +- tests/qemuxml2xmltest.c | 19 +- tests/sexpr2xmldata/sexpr2xml-curmem.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-autoport.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-empty-kernel.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-force-hpet.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-force-nohpet.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-localtime.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-net-netfront.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-parallel-tcp.xml | 4 +- .../sexpr2xml-fv-serial-dev-2-ports.xml | 4 +- .../sexpr2xml-fv-serial-dev-2nd-port.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-serial-file.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-serial-null.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-serial-pipe.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-serial-pty.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-serial-stdio.xml | 4 +- .../sexpr2xml-fv-serial-tcp-telnet.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-serial-udp.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-serial-unix.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-sound-all.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-sound.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-usbmouse.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-usbtablet.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-utc.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-v2.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml | 4 +- .../sexpr2xml-pv-vfb-new-vncdisplay.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-pv-vfb-new.xml | 2 +- .../sexpr2xmldata/sexpr2xml-pv-vfb-type-crash.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-vif-rate.xml | 4 +- tests/vmx2xmldata/vmx2xml-graphics-vnc.xml | 4 +- .../test-disk-positional-parms-full.xml | 2 +- .../test-disk-positional-parms-partial.xml | 2 +- ...est-fullvirt-direct-kernel-boot-bogus-extra.xml | 2 +- .../test-fullvirt-direct-kernel-boot-extra.xml | 2 +- .../test-fullvirt-direct-kernel-boot.xml | 2 +- tests/xlconfigdata/test-fullvirt-multiusb.xml | 2 +- tests/xlconfigdata/test-fullvirt-nohap.xml | 2 +- tests/xlconfigdata/test-new-disk.xml | 2 +- tests/xlconfigdata/test-rbd-multihost-noauth.xml | 2 +- tests/xlconfigdata/test-spice-features.xml | 2 +- tests/xlconfigdata/test-spice.xml | 2 +- tests/xlconfigdata/test-vif-rate.xml | 2 +- tests/xmconfigdata/test-escape-paths.xml | 2 +- .../xmconfigdata/test-fullvirt-default-feature.xml | 2 +- tests/xmconfigdata/test-fullvirt-force-hpet.xml | 2 +- tests/xmconfigdata/test-fullvirt-force-nohpet.xml | 2 +- tests/xmconfigdata/test-fullvirt-localtime.xml | 2 +- tests/xmconfigdata/test-fullvirt-net-netfront.xml | 2 +- tests/xmconfigdata/test-fullvirt-new-cdrom.xml | 2 +- tests/xmconfigdata/test-fullvirt-nohap.xml | 2 +- tests/xmconfigdata/test-fullvirt-parallel-tcp.xml | 2 +- .../test-fullvirt-serial-dev-2-ports.xml | 2 +- .../test-fullvirt-serial-dev-2nd-port.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-file.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-null.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-pipe.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-pty.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-stdio.xml | 2 +- .../test-fullvirt-serial-tcp-telnet.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-tcp.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-udp.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-unix.xml | 2 +- tests/xmconfigdata/test-fullvirt-sound.xml | 2 +- tests/xmconfigdata/test-fullvirt-usbmouse.xml | 2 +- tests/xmconfigdata/test-fullvirt-usbtablet.xml | 2 +- tests/xmconfigdata/test-fullvirt-utc.xml | 2 +- tests/xmconfigdata/test-no-source-cdrom.xml | 4 +- tests/xmconfigdata/test-paravirt-net-e1000.xml | 2 +- tests/xmconfigdata/test-paravirt-net-vifname.xml | 2 +- .../test-paravirt-new-pvfb-vncdisplay.xml | 2 +- tests/xmconfigdata/test-paravirt-new-pvfb.xml | 2 +- tests/xmconfigdata/test-pci-devs.xml | 4 +- 165 files changed, 2092 insertions(+), 987 deletions(-) create mode 100644 tests/genericxml2xmlindata/generic-graphics-listen-back-compat-ports.xml create mode 100644 tests/genericxml2xmlindata/generic-graphics-vnc-listen-element-with-address-port.xml create mode 100644 tests/genericxml2xmloutdata/generic-graphics-listen-back-compat-ports.xml create mode 100644 tests/genericxml2xmloutdata/generic-graphics-vnc-listen-element-with-address-port.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-auto-socket-cfg.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-auto-socket-cfg.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-auto-socket.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-auto-socket.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-socket.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-socket.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-auto-socket-cfg.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-auto-socket-cfg.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-auto-socket.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-auto-socket.xml delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-autosocket.args delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-autosocket.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-spice-auto-socket-cfg.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-spice-auto-socket.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-spice-socket.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-vnc-auto-socket-cfg.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-vnc-auto-socket.xml delete mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-vnc-autosocket.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-vnc-socket.xml -- 2.8.2

3 40

Re: [libvirt] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types
by Eduardo Habkost 12 May '16

12 May '16

On Wed, May 11, 2016 at 03:50:39PM +0200, Igor Mammedov wrote: > On Tue, 10 May 2016 17:24:14 -0300 > Eduardo Habkost <ehabkost(a)redhat.com> wrote: > > > On Mon, May 02, 2016 at 02:33:21PM +0200, Igor Mammedov wrote: > > > on old machine types CPU hotplug was uncondtionally > > > enabled since it was introduced, consuming IO ports > > > and providing AML regardles of whether it was actually > > > in use or not. Keep it so for 2.6 and older machines. > > > > > > New machine types will have an option to turn CPU > > > hotplug on if it's needed while by default it stays > > > disabled not consuming extra RAM/IO resources. > > > > > > Signed-off-by: Igor Mammedov <imammedo(a)redhat.com> > > > > What if people are using "-machine pc -smp N,max_cpus=M"? > > Shouldn't we at least warning about missing CPU hotplug support > > when using just "max_cpus" with no "cpu-hotplug=on" with pc-2.7 > > and newer? > Yep, I'll add it on next respin. > Would hard error better than warning? Not sure. It would break older libvirt versions, wouldn't it? But: isn't the new legacy-cpu-hotplug=false default going to break old libvirt versions anyway? Should we? (CCing libvirt list) > > > Should max_cpus > smp_cpus automatically set > > cpu-hotplug=on? > I'd prefer dumb explicit feature enablement, > as it doesn't put any assumptions on other options and > QEMU + mgmt don't have to maintain logic for implicit > rules that might enable it. > > and if I didn't manage to push 'device_add x86cpu' in 2.7 time frame, > guess work gets a bit confusing with current cpu-add semantic, > consider current: > > SRC-QEMU -smp 1,maxcpus=2 > cpu-add 1 > DST-QEMU -smp 2,maxcpus=2 > > vs would be device_add: > > SRC-QEMU -smp 1,maxcpus=2 > device_add cpu > DST-QEMU -smp 1,maxcpus=2 -device cpu > > so instead of qemu/users guessing, I suggest to make it explictly > enabled to get feature (which is mostly optional) or > cleanly fail qemu start if confusing options are specified > with a clear error message. Agreed we shouldn't encourage people to use the old option to get the new behavior. But I am worried about breaking existing configurations on a machine-type change. Is it possible to avoid that? -- Eduardo

3 2

[libvirt] [PATCH] schemas: Improve outdated comment
by Christophe Fergeau 12 May '16

12 May '16

--- docs/schemas/domaincommon.rng | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 273715c..8798001 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -2622,10 +2622,7 @@ </element> </define>  <define name="graphic"> <element name="graphics"> -- 2.7.4

2 1

[libvirt] [PATCH 1/1] perf: add support to perf event for MBM
by Qiaowei Ren 12 May '16

12 May '16

Some Intel processor families (e.g. the Intel Xeon processor E5 v3 family) introduced some RDT (Resource Director Technology) features to monitor or control shared resource. Among these features, MBM (Memory Bandwidth Monitoring), which is build on the CMT (Cache Monitoring Technology) infrastructure, provides OS/VMM a way to monitor bandwidth from one level of cache to another. With current perf framework, this patch adds support to perf event for MBM. Signed-off-by: Qiaowei Ren <qiaowei.ren(a)intel.com> --- include/libvirt/libvirt-domain.h | 18 ++++++++++++ src/qemu/qemu_driver.c | 35 +++++++++++++++++++---- src/util/virperf.c | 60 ++++++++++++++++++++++++---------------- src/util/virperf.h | 2 ++ 4 files changed, 85 insertions(+), 30 deletions(-) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index 160f20f..e4594f0 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -1904,6 +1904,24 @@ void virDomainStatsRecordListFree(virDomainStatsRecordPtr *stats); */ # define VIR_PERF_PARAM_CMT "cmt" +/** + * VIR_PERF_PARAM_MBMT: + * + * Macro for typed parameter name that represents MBMT perf event + * which can be used to monitor total system bandwidth (bytes/s) + * from one level of cache to another. + */ +# define VIR_PERF_PARAM_MBMT "mbmt" + +/** + * VIR_PERF_PARAM_MBML: + * + * Macro for typed parameter name that represents MBML perf event + * which can be used to monitor the amount of data (bytes/s) sent + * through the memory controller on the socket. + */ +# define VIR_PERF_PARAM_MBML "mbml" + int virDomainGetPerfEvents(virDomainPtr dom, virTypedParameterPtr *params, int *nparams, diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index c4c4968..a3bd7ec 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -10051,6 +10051,8 @@ qemuDomainSetPerfEvents(virDomainPtr dom, if (virTypedParamsValidate(params, nparams, VIR_PERF_PARAM_CMT, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_MBMT, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_MBML, VIR_TYPED_PARAM_BOOLEAN, NULL) < 0) return -1; @@ -19495,20 +19497,38 @@ qemuDomainGetStatsBlock(virQEMUDriverPtr driver, #undef QEMU_ADD_COUNT_PARAM static int -qemuDomainGetStatsPerfCmt(virPerfPtr perf, +qemuDomainGetStatsPerfRdt(virPerfPtr perf, + virPerfEventType type, virDomainStatsRecordPtr record, int *maxparams) { - uint64_t cache = 0; + uint64_t value = 0; - if (virPerfReadEvent(perf, VIR_PERF_EVENT_CMT, &cache) < 0) + if (virPerfReadEvent(perf, type, &value) < 0) return -1; - if (virTypedParamsAddULLong(&record->params, + if (type == VIR_PERF_EVENT_CMT && + virTypedParamsAddULLong(&record->params, &record->nparams, maxparams, "perf.cache", - cache) < 0) + value) < 0) + return -1; + + if (type == VIR_PERF_EVENT_MBMT && + virTypedParamsAddULLong(&record->params, + &record->nparams, + maxparams, + "perf.total_bytes", + value) < 0) + return -1; + + if (type == VIR_PERF_EVENT_MBML && + virTypedParamsAddULLong(&record->params, + &record->nparams, + maxparams, + "perf.local_bytes", + value) < 0) return -1; return 0; @@ -19531,7 +19551,10 @@ qemuDomainGetStatsPerf(virQEMUDriverPtr driver ATTRIBUTE_UNUSED, switch (i) { case VIR_PERF_EVENT_CMT: - if (qemuDomainGetStatsPerfCmt(priv->perf, record, maxparams) < 0) + case VIR_PERF_EVENT_MBMT: + case VIR_PERF_EVENT_MBML: + if (qemuDomainGetStatsPerfRdt(priv->perf, i, + record, maxparams) < 0) goto cleanup; break; } diff --git a/src/util/virperf.c b/src/util/virperf.c index bd65587..826d36a 100644 --- a/src/util/virperf.c +++ b/src/util/virperf.c @@ -38,7 +38,7 @@ VIR_LOG_INIT("util.perf"); #define VIR_FROM_THIS VIR_FROM_PERF VIR_ENUM_IMPL(virPerfEvent, VIR_PERF_EVENT_LAST, - "cmt"); + "cmt", "mbmt", "mbml"); struct virPerfEvent { int type; @@ -110,10 +110,10 @@ virPerfGetEvent(virPerfPtr perf, } static int -virPerfCmtEnable(virPerfEventPtr event, +virPerfRdtEnable(virPerfEventPtr event, pid_t pid) { - struct perf_event_attr cmt_attr; + struct perf_event_attr rdt_attr; char *buf = NULL; char *tmp = NULL; unsigned int event_type, scale; @@ -127,32 +127,42 @@ virPerfCmtEnable(virPerfEventPtr event, if (virStrToLong_ui(buf, NULL, 10, &event_type) < 0) { virReportSystemError(errno, "%s", - _("failed to get cmt event type")); + _("failed to get rdt event type")); goto error; } VIR_FREE(buf); - if (virFileReadAll("/sys/devices/intel_cqm/events/llc_occupancy.scale", - 10, &buf) < 0) - goto error; + memset(&rdt_attr, 0, sizeof(rdt_attr)); + rdt_attr.size = sizeof(rdt_attr); + rdt_attr.type = event_type; + rdt_attr.inherit = 1; + rdt_attr.disabled = 1; + rdt_attr.enable_on_exec = 0; - if (virStrToLong_ui(buf, NULL, 10, &scale) < 0) { - virReportSystemError(errno, "%s", - _("failed to get cmt scaling factor")); - goto error; + switch (event->type) { + case VIR_PERF_EVENT_CMT: + if (virFileReadAll("/sys/devices/intel_cqm/events/llc_occupancy.scale", + 10, &buf) < 0) + goto error; + + if (virStrToLong_ui(buf, NULL, 10, &scale) < 0) { + virReportSystemError(errno, "%s", + _("failed to get cmt scaling factor")); + goto error; + } + event->efields.cmt.scale = scale; + + rdt_attr.config = 1; + break; + case VIR_PERF_EVENT_MBMT: + rdt_attr.config = 2; + break; + case VIR_PERF_EVENT_MBML: + rdt_attr.config = 3; + break; } - event->efields.cmt.scale = scale; - - memset(&cmt_attr, 0, sizeof(cmt_attr)); - cmt_attr.size = sizeof(cmt_attr); - cmt_attr.type = event_type; - cmt_attr.config = 1; - cmt_attr.inherit = 1; - cmt_attr.disabled = 1; - cmt_attr.enable_on_exec = 0; - - event->fd = syscall(__NR_perf_event_open, &cmt_attr, pid, -1, -1, 0); + event->fd = syscall(__NR_perf_event_open, &rdt_attr, pid, -1, -1, 0); if (event->fd < 0) { virReportSystemError(errno, _("Unable to open perf type=%d for pid=%d"), @@ -162,7 +172,7 @@ virPerfCmtEnable(virPerfEventPtr event, if (ioctl(event->fd, PERF_EVENT_IOC_ENABLE) < 0) { virReportSystemError(errno, "%s", - _("Unable to enable perf event for CMT")); + _("Unable to enable perf event for RDT")); goto error; } @@ -186,7 +196,9 @@ virPerfEventEnable(virPerfPtr perf, switch (type) { case VIR_PERF_EVENT_CMT: - if (virPerfCmtEnable(event, pid) < 0) + case VIR_PERF_EVENT_MBMT: + case VIR_PERF_EVENT_MBML: + if (virPerfRdtEnable(event, pid) < 0) return -1; break; case VIR_PERF_EVENT_LAST: diff --git a/src/util/virperf.h b/src/util/virperf.h index 8ec8753..769e85a 100644 --- a/src/util/virperf.h +++ b/src/util/virperf.h @@ -26,6 +26,8 @@ typedef enum { VIR_PERF_EVENT_CMT, + VIR_PERF_EVENT_MBMT, + VIR_PERF_EVENT_MBML, VIR_PERF_EVENT_LAST } virPerfEventType; -- 1.9.1

3 2

[libvirt] docs: Change or update the hacking page
by Nishith Shah 12 May '16

12 May '16

6 8

[libvirt] Introducing Fabian Freyer (GSoC 2016 student)
by Roman Bogorodskiy 12 May '16

12 May '16

Hi, I'd like to introduce Fabian Freyer (CCed), he's taking part in Google Support of Code this year within FreeBSD organization and his project is called "Improving libvirt support for bhyve". Below I'm sharing a tentative plan we currently have. Or, to be more specific, it's a list of ideas for the bhyve driver with things were implementation is clear going first, followed by items were some additional research and working on approach needed. There's no goal to implement everything from this list though. This list was assembled by Fabian with some minor edits from me. Suggestions and ideas are very welcome. --- The primary aim of this project is to implement missing calls and functionality in the libvirt bhyve driver. According to the libvirt API Support Matrix [1], there are a large number of calls not yet implemented. While some missing API calls are not applicable to bhyve, a number of them are, among them the following calls: General calls: - virConnectDomainXMLFromNative This would mostly be an argument parser for a bhyve(8) and bhyvectl(8) command line. - virConnectGetCPUModelNames This needs a research: bhyve is not very flexible in configuration of what CPU model is exposed to the guest, need to figure out if that’s worth implementing now. Connection calls: Most of these include some form of authentication handling and are therefore not applicable. However, the following do apply to bhyve and are easy to implement: - virConnectGetType Trivially return “BHYVE” - virConnectIsAlive Trivially return 1, since “A connection will be classed as alive if it is [...] local” and /dev/vmm is local. - virConnectIsEncrypted Trivially return 0, since bhyve does not support encrypted interfaces. General Domain calls: - virDomainGetMaxMemory Since bhyve does not support memory ballooning, just return the amount of memory allocated here - virDomainGetMaxVcpus, virDomainGetVcpus Would use the approach described in this mailing list thread: “Until the vCPU state is exposed by bhyvectl, or we provide a sysctl, you can use heuristics: the number of vCPU threads for the bhyve process, or scan all vCPUs and only count those that have a non-zero RIP.” [2] - virDomainGetCPUStats - virDomainGetTime - virDomainInjectNMI Call bhyvectl --inject-nmi - virDomainReset Reset a bhyve VM with ‘bhyvectl --force-reset’ and then clean things up using bhyvectl --destroy; update bhyve monitor code to handle exit code 0 from bhyve(8) that’s corresponding to reset (0 - reset / reboot, 1 - shutdown, 2 - halt) to trigger re-starting of the VM. - virDomainReboot Block-Device level calls: These would implement access to the vdev block storage layer. The plan is implement support for both file-backed and zvol-backed virtual machines for the following API calls: - virDomainGetBlockInfo - virDomainBlockPeek - virDomainBlockCopy - virDomainBlockStats - virDomainBlockStatsFlags Going further, since zvols support snapshotting, I plan to implement the following for zvol-backed storage: - virDomainBlockCommit - virDomainBlockPull VirtFS layer I would like to create patches to support specifying filesystems when creating the domain as well as the following calls to be merged at a later time when VirtFS-9p support for bhyve becomes ready: - virDomainFSFreeze - virDomainFSThaw Memory inspection - virDomainMemoryPeek A guest’s memory space is exposed in /dev/vmm, so this call would have to read from that. - virDomainMemoryStats Virt-host-validate(1) bhyve support Add bhyve support to virt-host-validate: - Check support of CPU supports features required for bhyve - Check if the vmm module is available - Check if essential networking things are available (if_bridge(4), if_tap(4)) + nmdm(4) for console Networking support Currently the bhyve’s libvirt driver (as well as libxl/FreeBSD driver) only supports L2 interface bridging. There’s no support for upper level schemas like NAT for example. This is a huge task that involves research of what firefall is more applicable (ipfw or pf), designing of the firewall rules and the actual implemtation. PCI passthrough support I.e. the the "bhyve ... -s 7:0,passthru,4/0/0" thing. Probably that will involve the HAL nodedev driver modifications. --- PS For historic purposes, I've stashed the original proposal: https://people.freebsd.org/~novel/misc/FabianFreyer_GoogleSummerofCode2016p… 1: https://libvirt.org/hvsupport.html 2: https://lists.freebsd.org/pipermail/freebsd-virtualization/2014-April/00246… Roman Bogorodskiy

5 5

[libvirt] [PATCH] util: Fix virGetLastErrorMessage to return proper error when 'err' is NULL
by Erik Skultety 12 May '16

12 May '16

Both virGetLastError and virGetLastErrorMessage call virLastErrorObject method that returns a thread-local error object. However, if a direct call to malloc or pthread_setspecific (probably also due to malloc, since it sets ENOMEM) fail, virLastErrorObject returns NULL which, although incorrectly interpreted by virGetLastError as no error, still requires the caller to check for NULL pointer. This isn't the case with virGetLastErrorMessage that also treated it incorrectly as no error, but returned the literal "no error". This patch tweaks the checks in the virGetLastErrorMessage function, so that if virLastErrorObject failed, it returned "unknown error" which is equivalent to the current approach with virGetLastError and if it returned NULL, "unknown error" was set. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- src/util/virerror.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virerror.c b/src/util/virerror.c index 5d875e3..1177570 100644 --- a/src/util/virerror.c +++ b/src/util/virerror.c @@ -281,9 +281,9 @@ const char * virGetLastErrorMessage(void) { virErrorPtr err = virLastErrorObject(); - if (!err || err->code == VIR_ERR_OK) + if (err && err->code == VIR_ERR_OK) return _("no error"); - if (err->message == NULL) + if (!err || !err->message) return _("unknown error"); return err->message; } -- 2.5.5

2 2

[libvirt] [PATCH v3 0/2] Add IV Secret Object support (for RBD only)
by John Ferlan 11 May '16

11 May '16

v2 here: http://www.redhat.com/archives/libvir-list/2016-May/msg00067.html First 6 patches from v2 were pushed since they were ACK'd I modified the 7th patch to add the ATTRIBUTE_UNUSED to the static functions qemuDomainSecretHaveEncypt and qemuDomainSecretIVSetup and merged in the HAVE_GNUTLS_CIPHER_ENCRYPT. This should address Michal's point in patch 7 review. Patch 2 thus becomes the "remainder" of the work necessary in order to get IV Secrets available for RBD volumes. It's most of the former patch 8 with removal if iSCSI oddities. Patch 8 will then remove the ATTRIBUTE_UNUSED from the 2 static functions now that qemuDomainSecretSetup exists to call it. The change here was to add the check for protocol == VIR_STORAGE_NET_PROTOCOL_RBD before "defaulting" to using the IV secret (e.g., the magic decision point). Since the command code didn't need the secret setup for iSCSI, it's been extracted to another safe place just in case it needs to be resurrected. John Ferlan (2): qemu: Introduce new Secret IV API's qemu: Utilize qemu secret objects for RBD auth/secret configure.ac | 1 + src/qemu/qemu_alias.c | 23 +++ src/qemu/qemu_alias.h | 2 + src/qemu/qemu_command.c | 130 +++++++++++++- src/qemu/qemu_domain.c | 189 ++++++++++++++++++++- ...emuxml2argv-disk-drive-network-rbd-auth-IV.args | 31 ++++ ...qemuxml2argv-disk-drive-network-rbd-auth-IV.xml | 42 +++++ tests/qemuxml2argvmock.c | 31 +++- tests/qemuxml2argvtest.c | 11 ++ 9 files changed, 451 insertions(+), 9 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd-auth-IV.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd-auth-IV.xml -- 2.5.5

3 8

[libvirt] [PATCH] tests: qemu: mock master key generation
by Peter Krempa 11 May '16

11 May '16

The master key generation is using host state to get the random bytes. Currently it's not used so it doesn't break any tests, but it may become a problem in the future. Fix it by mocking qemuDomainGenerateRandomKey. This is possible after exporting it and switching to the dynamically linked qemu driver object for tests. --- This also makes the test not call any gnutls function which crashed certain gnutls versions as we did not initialize it (gnutls_global_init()). It may be also worth adding the call to virtTestMain so that tests don't run into that problem, but I'm not totaly persuaded that it's a good idea. src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_domain.h | 2 ++ tests/Makefile.am | 2 +- tests/qemuxml2argvmock.c | 21 +++++++++++++++++++++ 4 files changed, 25 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 3da0079..d955ed4 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -640,7 +640,7 @@ qemuDomainMasterKeyReadFile(qemuDomainObjPrivatePtr priv) * * Returns pointer memory containing key on success, NULL on failure */ -static uint8_t * +uint8_t * qemuDomainGenerateRandomKey(size_t nbytes) { uint8_t *key; diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index c711188..b116949 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -669,4 +669,6 @@ int qemuDomainSecretPrepare(virConnectPtr conn, virDomainObjPtr vm) int qemuDomainDefValidateDiskLunSource(const virStorageSource *src) ATTRIBUTE_NONNULL(1); +uint8_t *qemuDomainGenerateRandomKey(size_t nbytes); + #endif /* __QEMU_DOMAIN_H__ */ diff --git a/tests/Makefile.am b/tests/Makefile.am index 75efb90..ba14b8f 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -561,7 +561,7 @@ libqemutestdriver_la_LIBADD = $(qemu_LDADDS) qemuxml2argvtest_SOURCES = \ qemuxml2argvtest.c testutilsqemu.c testutilsqemu.h \ testutils.c testutils.h -qemuxml2argvtest_LDADD = $(qemu_LDADDS) $(LDADDS) $(LIBXML_LIBS) +qemuxml2argvtest_LDADD = libqemutestdriver.la $(LDADDS) $(LIBXML_LIBS) qemuxml2argvmock_la_SOURCES = \ qemuxml2argvmock.c diff --git a/tests/qemuxml2argvmock.c b/tests/qemuxml2argvmock.c index 1616eed..1bad3ae 100644 --- a/tests/qemuxml2argvmock.c +++ b/tests/qemuxml2argvmock.c @@ -30,6 +30,10 @@ #include "virstring.h" #include "virtpm.h" #include "virutil.h" +#include "viralloc.h" + +#include "qemu/qemu_domain.h" + #include <time.h> #include <unistd.h> @@ -145,3 +149,20 @@ virCommandPassFD(virCommandPtr cmd ATTRIBUTE_UNUSED, { /* nada */ } + + +uint8_t * +qemuDomainGenerateRandomKey(size_t nbytes) +{ + size_t i; + uint8_t seq = 0; + uint8_t *key; + + if (VIR_ALLOC_N(key, nbytes) < 0) + return NULL; + + for (i = 0; i < nbytes; i++) + key[i] = seq++; + + return key; +} -- 2.8.2

2 4

[libvirt] [PATCH] spec: Fix broken indentation reported by syntax-check
by Erik Skultety 11 May '16

11 May '16

syntax-check complained about broken indentation in libvirt.spec.in which was broken by commit 3694e038 Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- Pushed under trivial rule. Erik libvirt.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 886f5cf..d96917b 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -4,9 +4,9 @@ # or for RHEL 6 or newer. It may need some tweaks for other distros. # If neither fedora nor rhel was defined, try to guess them from dist %if (0%{?fedora} && 0%{?fedora} >= 20) || (0%{?rhel} && 0%{?rhel} >= 6) -%define supported_platform 1 + %define supported_platform 1 %else -%define supported_platform 0 + %define supported_platform 0 %endif # Default to skipping autoreconf. Distros can change just this one line -- 2.5.5

1 0

[libvirt] [PATCH REPOST 0/5] admin: Introduce APIs to get/set client processing
by Erik Skultety 11 May '16

11 May '16

This is just a rebased version of https://www.redhat.com/archives/libvir-list/2016-April/msg00466.html. Patches 1/7 and 2/7 of the original series were already pushed with another series. Erik Skultety (5): virnetserver: Introduce client processing controls getters admin: Introduce some public constants related to client processing controls admin: Introduce virAdmServerGetClientProcessingControls admin: Introduce virAdmServerSetClientProcessingControls virt-admin: Introduce commands srv-clients-info and srv-clients-set daemon/admin.c | 86 +++++++++++++++++++ daemon/admin_server.c | 76 +++++++++++++++++ daemon/admin_server.h | 10 +++ include/libvirt/libvirt-admin.h | 52 ++++++++++++ src/admin/admin_protocol.x | 30 ++++++- src/admin/admin_remote.c | 74 +++++++++++++++++ src/admin_protocol-structs | 20 +++++ src/libvirt-admin.c | 89 ++++++++++++++++++++ src/libvirt_admin_private.syms | 3 + src/libvirt_admin_public.syms | 2 + src/rpc/virnetserver.c | 83 +++++++++++++++++++ src/rpc/virnetserver.h | 9 ++ tools/virt-admin.c | 177 ++++++++++++++++++++++++++++++++++++++++ 13 files changed, 710 insertions(+), 1 deletion(-) -- 2.5.5

2 15

[libvirt] [PATCH 0/5] domaincaps: Report spice GL capabilities
by Cole Robinson 11 May '16

11 May '16

This extends domain capabilities to report some bits apps will want to determine if spice GL is supported: <domainCapabilities> <devices> <video supported='yes'> <enum name='modelType'/> <enum name='virtioAccel3D'/> </video> <graphics supported='yes'> <enum name='type'/> <enum name='spiceGL'/> </graphics> </devices> </domainCapabilities> Cole Robinson (5): domaincaps: Report graphics type enum domaincaps: Report video modelType domaincaps: Report graphics spiceGL qemu: command: unconditionally allow accel3d='no' domaincaps: Report graphics spiceGL docs/formatdomaincaps.html.in | 76 +++++++++++++++++++++- docs/schemas/domaincaps.rng | 16 +++++ src/conf/domain_capabilities.c | 28 ++++++++ src/conf/domain_capabilities.h | 21 ++++++ src/qemu/qemu_capabilities.c | 53 ++++++++++++++- src/qemu/qemu_command.c | 2 +- tests/domaincapsschemadata/domaincaps-basic.xml | 2 + tests/domaincapsschemadata/domaincaps-full.xml | 31 +++++++++ .../domaincaps-qemu_1.6.50-1.xml | 21 ++++++ .../domaincaps-qemu_2.6.0-1.xml | 24 +++++++ .../domaincaps-qemu_2.6.0-2.xml | 19 ++++++ .../domaincaps-qemu_2.6.0-3.xml | 19 ++++++ .../domaincaps-qemu_2.6.0-4.xml | 19 ++++++ .../domaincaps-qemu_2.6.0-5.xml | 19 ++++++ tests/domaincapstest.c | 10 +++ 15 files changed, 357 insertions(+), 3 deletions(-) -- 2.7.4

5 25

[libvirt] [PATCH 0/2] *** use virGetLastErrorMessage ***
by Jovanka Gulicoska 11 May '16

11 May '16

*** BLURB HERE *** Jovanka Gulicoska (2): tests: use virGetLastErrorMessage() Use virGetLastErrorMessage()

3 9

[libvirt] [PATCH 0/3] Patches for some device mapper multipath issues
by John Ferlan 11 May '16

11 May '16

Patch 1 just makes sure that prior to calling refreshPool we make sure to clear the objects; otherwise, the refresh code will duplicate. Text within patch 3 seems to indicate that entries were showing up more than once - although those may be bug related. In any case, although perhaps not necessary here - better safe than sorry. Patch 2 is a rework of changes that went into 1.3.2 related to how libvirt_parthelper generates the volume target path name that didn't quite get the algorithm right when the device source path ended with a non numeric value. As it turns out it seems the naming algorithm is much "simpler"; however, rather than just remove the attribute, I figured it should be kept "just in case" something *needed* to add that "p" it would be possible. It seems from output described here: https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/7/ht… That it would be possible. Patch 3 was probably seen because Patch 2 testing occurs, so the same "sequence" used in other disk backend based testing was attempted. As it turns out, I don't believe the deletion for a multipath device ever really worked. The original patch could have been reverted except that it intermingled changes to support linking device-mapper with parthelper. John Ferlan (3): storage: Need to clear pool prior to calling the refreshPool storage: Fix algorithm generating path names for devmapper storage: Fix virStorageBackendDiskDeleteVol for device mapper configure.ac | 15 ++---- docs/formatstorage.html.in | 18 ++----- src/storage/parthelper.c | 13 +++-- src/storage/storage_backend_disk.c | 108 ++++++++++++++++++++++++------------- src/storage/storage_driver.c | 3 ++ 5 files changed, 89 insertions(+), 68 deletions(-) -- 2.5.5

2 6

[libvirt] [PATCH] libxl: fix vm lock overwritten bug
by Wang Yufei 11 May '16

11 May '16

In libxl driver we do virObjectRef in libxlDomainObjBeginJob, If virCondWaitUntil failed, it goes to error, do virObjectUnref, There's a chance that someone undefine the vm at the same time, and refs unref to zero, vm is freed in libxlDomainObjBeginJob. But the vm outside function is not Null, we do virObjectUnlock(vm). That's how we overwrite the vm memory after it's freed. Because the coding amount is much, I fix it partly in libxlDomainCreateWithFlags. If my opinion is right and there're no problems, I'll fix them all later. Signed-off-by: Wang Yufei <james.wangyufei(a)huawei.com> --- .gnulib | 1 - src/libxl/libxl_domain.c | 6 +----- src/libxl/libxl_domain.h | 2 +- src/libxl/libxl_driver.c | 5 ++--- 4 files changed, 4 insertions(+), 10 deletions(-) delete mode 160000 .gnulib diff --git a/.gnulib b/.gnulib deleted file mode 160000 index 6cc32c6..0000000 --- a/.gnulib +++ /dev/null @@ -1 +0,0 @@ -Subproject commit 6cc32c63e80bc1a30c521b2f07f2b54909b59892 diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index 14a900c..a90ce53 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -123,7 +123,6 @@ libxlDomainObjBeginJob(libxlDriverPrivatePtr driver ATTRIBUTE_UNUSED, return -1; then = now + LIBXL_JOB_WAIT_TIME; - virObjectRef(obj); while (priv->job.active) { VIR_DEBUG("Wait normal job condition for starting job: %s", @@ -157,7 +156,6 @@ libxlDomainObjBeginJob(libxlDriverPrivatePtr driver ATTRIBUTE_UNUSED, virReportSystemError(errno, "%s", _("cannot acquire job mutex")); - virObjectUnref(obj); return -1; } @@ -171,7 +169,7 @@ libxlDomainObjBeginJob(libxlDriverPrivatePtr driver ATTRIBUTE_UNUSED, * non-zero, false if the reference count has dropped to zero * and obj is disposed. */ -bool +void libxlDomainObjEndJob(libxlDriverPrivatePtr driver ATTRIBUTE_UNUSED, virDomainObjPtr obj) { @@ -183,8 +181,6 @@ libxlDomainObjEndJob(libxlDriverPrivatePtr driver ATTRIBUTE_UNUSED, libxlDomainObjResetJob(priv); virCondSignal(&priv->job.cond); - - return virObjectUnref(obj); } int diff --git a/src/libxl/libxl_domain.h b/src/libxl/libxl_domain.h index 1c1eba3..ce28944 100644 --- a/src/libxl/libxl_domain.h +++ b/src/libxl/libxl_domain.h @@ -85,7 +85,7 @@ libxlDomainObjBeginJob(libxlDriverPrivatePtr driver, enum libxlDomainJob job) ATTRIBUTE_RETURN_CHECK; -bool +void libxlDomainObjEndJob(libxlDriverPrivatePtr driver, virDomainObjPtr obj) ATTRIBUTE_RETURN_CHECK; diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index bf97c9c..a46994a 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -294,7 +294,7 @@ libxlDomObjFromDomain(virDomainPtr dom) libxlDriverPrivatePtr driver = dom->conn->privateData; char uuidstr[VIR_UUID_STRING_BUFLEN]; - vm = virDomainObjListFindByUUID(driver->domains, dom->uuid); + vm = virDomainObjListFindByUUIDRef(driver->domains, dom->uuid); if (!vm) { virUUIDFormat(dom->uuid, uuidstr); virReportError(VIR_ERR_NO_DOMAIN, @@ -2691,8 +2691,7 @@ libxlDomainCreateWithFlags(virDomainPtr dom, vm = NULL; cleanup: - if (vm) - virObjectUnlock(vm); + virDomainObjEndAPI(&vm); return ret; } -- 1.9.5.msysgit.1

3 3

[libvirt] [PATCH v2] storage: Fix regression cloning volume into a logical pool
by John Ferlan 11 May '16

11 May '16

https://bugzilla.redhat.com/show_bug.cgi?id=1318993 Commit id 'dd519a294' caused a regression cloning a volume into a logical pool by removing just the 'allocation' adjustment during storageVolCreateXMLFrom. Combined with the change to not require the new volume input XML to have a capacity listed (commit id 'e3f1d2a8') left the possibility that a copy from a larger volume into a smaller volume would create a thin/sparse logical volume. If a thin lv becomes fully populated, then LVM will set the partition 'inactive' and the subsequent fdatasync() would fail. In order to fix this in a backend agnostic manner, only adjust the new capacity if not provided. Likewise, if the new allocation is not provided, then use the capacity value as we document that if omitted, the volume will be fully allocated at time of creation. In order to ascertain that <allocation> == 0 was because it was not provided and not because it was provided as a 0 value, add a has_allocation flag which will be checked during in order to honor the possibility that <capacity> was provided as some value and <allocation> was provided as 0. For a logical backend, that creation time is 'createVol', while for a file backend, creation doesn't set the size, but the 'createRaw' called during buildVolFrom will decide whether the file is sparse or not based on the provided capacity and allocation value. For volume clones that provide different allocation and capacity values to allow for sparse files, there is no change. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- v1: http://www.redhat.com/archives/libvir-list/2016-April/msg01994.html src/conf/storage_conf.c | 1 + src/storage/storage_driver.c | 18 +++++++++++++++--- src/util/virstoragefile.c | 1 + src/util/virstoragefile.h | 2 ++ 4 files changed, 19 insertions(+), 3 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 0b91956..6932195 100644 --- a/src/conf/storage_conf.c +++ b/src/conf/storage_conf.c @@ -1370,6 +1370,7 @@ virStorageVolDefParseXML(virStoragePoolDefPtr pool, unit = virXPathString("string(./allocation/@unit)", ctxt); if (virStorageSize(unit, allocation, &ret->target.allocation) < 0) goto error; + ret->target.has_allocation = true; } else { ret->target.allocation = ret->target.capacity; } diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 1d42f24..0afe522 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -2034,11 +2034,23 @@ storageVolCreateXMLFrom(virStoragePoolPtr obj, goto cleanup; } - /* Use the original volume's capacity in case the new capacity - * is less than that, or it was omitted */ - if (newvol->target.capacity < origvol->target.capacity) + /* Use the original volume's capacity if the new capacity was omitted. + * If the provided newvol capacity is less than original, we cannot just + * use the original since the subsequent createVol has "competing needs" + * for backends. A logical volume backend could then create a thin lv + * that has different characteristics when copying from the original + * volume than perhaps a raw disk file. */ + if (newvol->target.capacity == 0) newvol->target.capacity = origvol->target.capacity; + /* If the new allocation is 0 and the allocation was not provided in + * the XML, then use capacity as it's specifically documented "If + * omitted when creating a volume, the volume will be fully allocated + * at time of creation.". This is especially important for logical + * volume creation. */ + if (newvol->target.allocation == 0 && !newvol->target.has_allocation) + newvol->target.allocation = newvol->target.capacity; + if (!backend->buildVolFrom) { virReportError(VIR_ERR_NO_SUPPORT, "%s", _("storage pool does not support" diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index 4f44e05..d4e61ca 100644 --- a/src/util/virstoragefile.c +++ b/src/util/virstoragefile.c @@ -1835,6 +1835,7 @@ virStorageSourceCopy(const virStorageSource *src, ret->format = src->format; ret->capacity = src->capacity; ret->allocation = src->allocation; + ret->has_allocation = src->has_allocation; ret->physical = src->physical; ret->readonly = src->readonly; ret->shared = src->shared; diff --git a/src/util/virstoragefile.h b/src/util/virstoragefile.h index 17e1277..b88e715 100644 --- a/src/util/virstoragefile.h +++ b/src/util/virstoragefile.h @@ -260,6 +260,8 @@ struct _virStorageSource { unsigned long long capacity; /* in bytes, 0 if unknown */ unsigned long long allocation; /* in bytes, 0 if unknown */ unsigned long long physical; /* in bytes, 0 if unknown */ + bool has_allocation; /* Set to true when provided in XML */ + size_t nseclabels; virSecurityDeviceLabelDefPtr *seclabels; -- 2.5.5

2 2

[libvirt] [PATCH] virt-aa-helper: fix clang build
by Pavel Hrdina 11 May '16

11 May '16

Clang complains about wrong argument type: libvirt/src/security/virt-aa-helper.c:174:11: error: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Werror,-Wabsolute-value] idx = abs(pos - orig); ^ Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/security/virt-aa-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 7eeb4ef..14f8afb 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -171,7 +171,7 @@ replace_string(char *orig, const size_t len, const char *oldstr, } tmp[0] = '\0'; - idx = abs(pos - orig); + idx = abs((int)(pos - orig)); /* copy everything up to oldstr */ strncat(tmp, orig, idx); -- 2.8.2

3 4

[libvirt] [PATCH 1/1] perf: add support to perf event for MBM
by Qiaowei Ren 11 May '16

11 May '16

MBM (Memory Bandwidth Monitoring) is a new feature introduced in some Intel processor families. MBM is build on the CMT (Cache Monitoring Technology) infrastructure to allow monitoring of bandwidth from one level of the cache hierarchy to the next. With current perf framework, this patch adds support to perf event for MBM. Signed-off-by: Qiaowei Ren <qiaowei.ren(a)intel.com> --- include/libvirt/libvirt-domain.h | 14 +++++++++++ src/qemu/qemu_driver.c | 50 ++++++++++++++++++++++++++++++++++++++++ src/util/virperf.c | 40 +++++++++++++++++++++----------- src/util/virperf.h | 2 ++ 4 files changed, 92 insertions(+), 14 deletions(-) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index 160f20f..9c3795c 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -1904,6 +1904,20 @@ void virDomainStatsRecordListFree(virDomainStatsRecordPtr *stats); */ # define VIR_PERF_PARAM_CMT "cmt" +/** + * VIR_PERF_PARAM_MBMT: + * + * Macro for typed parameter name that represents MBMT perf event. + */ +# define VIR_PERF_PARAM_MBMT "mbmt" + +/** + * VIR_PERF_PARAM_MBML: + * + * Macro for typed parameter name that represents MBML perf event. + */ +# define VIR_PERF_PARAM_MBML "mbml" + int virDomainGetPerfEvents(virDomainPtr dom, virTypedParameterPtr *params, int *nparams, diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index c4c4968..8c79e49 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -10051,6 +10051,8 @@ qemuDomainSetPerfEvents(virDomainPtr dom, if (virTypedParamsValidate(params, nparams, VIR_PERF_PARAM_CMT, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_MBMT, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_MBML, VIR_TYPED_PARAM_BOOLEAN, NULL) < 0) return -1; @@ -19515,6 +19517,46 @@ qemuDomainGetStatsPerfCmt(virPerfPtr perf, } static int +qemuDomainGetStatsPerfMbmt(virPerfPtr perf, + virDomainStatsRecordPtr record, + int *maxparams) +{ + uint64_t total_bytes = 0; + + if (virPerfReadEvent(perf, VIR_PERF_EVENT_MBMT, &total_bytes) < 0) + return -1; + + if (virTypedParamsAddDouble(&record->params, + &record->nparams, + maxparams, + "perf.total_bytes", + total_bytes*1e-6) < 0) + return -1; + + return 0; +} + +static int +qemuDomainGetStatsPerfMbml(virPerfPtr perf, + virDomainStatsRecordPtr record, + int *maxparams) +{ + uint64_t local_bytes = 0; + + if (virPerfReadEvent(perf, VIR_PERF_EVENT_MBML, &local_bytes) < 0) + return -1; + + if (virTypedParamsAddDouble(&record->params, + &record->nparams, + maxparams, + "perf.local_bytes", + local_bytes*1e-6) < 0) + return -1; + + return 0; +} + +static int qemuDomainGetStatsPerf(virQEMUDriverPtr driver ATTRIBUTE_UNUSED, virDomainObjPtr dom, virDomainStatsRecordPtr record, @@ -19534,6 +19576,14 @@ qemuDomainGetStatsPerf(virQEMUDriverPtr driver ATTRIBUTE_UNUSED, if (qemuDomainGetStatsPerfCmt(priv->perf, record, maxparams) < 0) goto cleanup; break; + case VIR_PERF_EVENT_MBMT: + if (qemuDomainGetStatsPerfMbmt(priv->perf, record, maxparams) < 0) + goto cleanup; + break; + case VIR_PERF_EVENT_MBML: + if (qemuDomainGetStatsPerfMbml(priv->perf, record, maxparams) < 0) + goto cleanup; + break; } } diff --git a/src/util/virperf.c b/src/util/virperf.c index bd65587..7cfdd77 100644 --- a/src/util/virperf.c +++ b/src/util/virperf.c @@ -38,7 +38,7 @@ VIR_LOG_INIT("util.perf"); #define VIR_FROM_THIS VIR_FROM_PERF VIR_ENUM_IMPL(virPerfEvent, VIR_PERF_EVENT_LAST, - "cmt"); + "cmt", "mbmt", "mbml"); struct virPerfEvent { int type; @@ -132,26 +132,36 @@ virPerfCmtEnable(virPerfEventPtr event, } VIR_FREE(buf); - if (virFileReadAll("/sys/devices/intel_cqm/events/llc_occupancy.scale", - 10, &buf) < 0) - goto error; - - if (virStrToLong_ui(buf, NULL, 10, &scale) < 0) { - virReportSystemError(errno, "%s", - _("failed to get cmt scaling factor")); - goto error; - } - - event->efields.cmt.scale = scale; - memset(&cmt_attr, 0, sizeof(cmt_attr)); cmt_attr.size = sizeof(cmt_attr); cmt_attr.type = event_type; - cmt_attr.config = 1; cmt_attr.inherit = 1; cmt_attr.disabled = 1; cmt_attr.enable_on_exec = 0; + switch (event->type) { + case VIR_PERF_EVENT_CMT: + if (virFileReadAll("/sys/devices/intel_cqm/events/llc_occupancy.scale", + 10, &buf) < 0) + goto error; + + if (virStrToLong_ui(buf, NULL, 10, &scale) < 0) { + virReportSystemError(errno, "%s", + _("failed to get cmt scaling factor")); + goto error; + } + event->efields.cmt.scale = scale; + + cmt_attr.config = 1; + break; + case VIR_PERF_EVENT_MBMT: + cmt_attr.config = 2; + break; + case VIR_PERF_EVENT_MBML: + cmt_attr.config = 3; + break; + } + event->fd = syscall(__NR_perf_event_open, &cmt_attr, pid, -1, -1, 0); if (event->fd < 0) { virReportSystemError(errno, @@ -186,6 +196,8 @@ virPerfEventEnable(virPerfPtr perf, switch (type) { case VIR_PERF_EVENT_CMT: + case VIR_PERF_EVENT_MBMT: + case VIR_PERF_EVENT_MBML: if (virPerfCmtEnable(event, pid) < 0) return -1; break; diff --git a/src/util/virperf.h b/src/util/virperf.h index 8ec8753..769e85a 100644 --- a/src/util/virperf.h +++ b/src/util/virperf.h @@ -26,6 +26,8 @@ typedef enum { VIR_PERF_EVENT_CMT, + VIR_PERF_EVENT_MBMT, + VIR_PERF_EVENT_MBML, VIR_PERF_EVENT_LAST } virPerfEventType; -- 1.9.1

2 1

[libvirt] [PATCH] headers: Remove unnecessary keyword extern from function declaration
by Erik Skultety 11 May '16

11 May '16

Usage of this keyword in front of function declaration that is exported via a header file is unnecessary, since internally, this has been the default for most compilers for quite some time. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- src/conf/capabilities.h | 28 +++++++------- src/cpu/cpu.h | 24 ++++++------ src/cpu/cpu_map.h | 2 +- src/lxc/lxc_fuse.h | 6 +-- src/util/virhashcode.h | 2 +- src/util/virlog.h | 78 +++++++++++++++++++-------------------- src/util/virstats.h | 4 +- src/xen/block_stats.h | 4 +- src/xen/xen_driver.h | 2 +- src/xenapi/xenapi_driver.h | 2 +- tools/virt-host-validate-common.h | 62 +++++++++++++++---------------- tools/virt-host-validate-lxc.h | 2 +- tools/virt-host-validate-qemu.h | 2 +- 13 files changed, 109 insertions(+), 109 deletions(-) diff --git a/src/conf/capabilities.h b/src/conf/capabilities.h index 2767f48..cfdc34a 100644 --- a/src/conf/capabilities.h +++ b/src/conf/capabilities.h @@ -204,27 +204,27 @@ struct _virCapsDomainData { }; -extern virCapsPtr +virCapsPtr virCapabilitiesNew(virArch hostarch, bool offlineMigrate, bool liveMigrate); -extern void +void virCapabilitiesFreeNUMAInfo(virCapsPtr caps); -extern int +int virCapabilitiesAddHostFeature(virCapsPtr caps, const char *name); -extern int +int virCapabilitiesAddHostMigrateTransport(virCapsPtr caps, const char *name); -extern int +int virCapabilitiesSetNetPrefix(virCapsPtr caps, const char *prefix); -extern int +int virCapabilitiesAddHostNUMACell(virCapsPtr caps, int num, unsigned long long mem, @@ -236,19 +236,19 @@ virCapabilitiesAddHostNUMACell(virCapsPtr caps, virCapsHostNUMACellPageInfoPtr pageinfo); -extern int +int virCapabilitiesSetHostCPU(virCapsPtr caps, virCPUDefPtr cpu); -extern virCapsGuestMachinePtr * +virCapsGuestMachinePtr * virCapabilitiesAllocMachines(const char *const *names, int nnames); -extern void +void virCapabilitiesFreeMachines(virCapsGuestMachinePtr *machines, int nmachines); -extern virCapsGuestPtr +virCapsGuestPtr virCapabilitiesAddGuest(virCapsPtr caps, int ostype, virArch arch, @@ -257,7 +257,7 @@ virCapabilitiesAddGuest(virCapsPtr caps, int nmachines, virCapsGuestMachinePtr *machines); -extern virCapsGuestDomainPtr +virCapsGuestDomainPtr virCapabilitiesAddGuestDomain(virCapsGuestPtr guest, int hvtype, const char *emulator, @@ -265,13 +265,13 @@ virCapabilitiesAddGuestDomain(virCapsGuestPtr guest, int nmachines, virCapsGuestMachinePtr *machines); -extern virCapsGuestFeaturePtr +virCapsGuestFeaturePtr virCapabilitiesAddGuestFeature(virCapsGuestPtr guest, const char *name, bool defaultOn, bool toggle); -extern int +int virCapabilitiesHostSecModelAddBaseLabel(virCapsHostSecModelPtr secmodel, const char *type, const char *label); @@ -288,7 +288,7 @@ void virCapabilitiesClearHostNUMACellCPUTopology(virCapsHostNUMACellCPUPtr cpu, size_t ncpus); -extern char * +char * virCapabilitiesFormatXML(virCapsPtr caps); virBitmapPtr virCapabilitiesGetCpusForNodemask(virCapsPtr caps, diff --git a/src/cpu/cpu.h b/src/cpu/cpu.h index 7375876..f15dc16 100644 --- a/src/cpu/cpu.h +++ b/src/cpu/cpu.h @@ -122,19 +122,19 @@ struct cpuArchDriver { }; -extern virCPUCompareResult +virCPUCompareResult cpuCompareXML(virCPUDefPtr host, const char *xml, bool failIncompatible) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -extern virCPUCompareResult +virCPUCompareResult cpuCompare (virCPUDefPtr host, virCPUDefPtr cpu, bool failIncompatible) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -extern int +int cpuDecode (virCPUDefPtr cpu, const virCPUData *data, const char **models, @@ -142,7 +142,7 @@ cpuDecode (virCPUDefPtr cpu, const char *preferred) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -extern int +int cpuEncode (virArch arch, const virCPUDef *cpu, virCPUDataPtr *forced, @@ -153,27 +153,27 @@ cpuEncode (virArch arch, virCPUDataPtr *vendor) ATTRIBUTE_NONNULL(2); -extern void +void cpuDataFree (virCPUDataPtr data); -extern virCPUDataPtr +virCPUDataPtr cpuNodeData (virArch arch); -extern virCPUCompareResult +virCPUCompareResult cpuGuestData(virCPUDefPtr host, virCPUDefPtr guest, virCPUDataPtr *data, char **msg) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -extern char * +char * cpuBaselineXML(const char **xmlCPUs, unsigned int ncpus, const char **models, unsigned int nmodels, unsigned int flags); -extern virCPUDefPtr +virCPUDefPtr cpuBaseline (virCPUDefPtr *cpus, unsigned int ncpus, const char **models, @@ -181,12 +181,12 @@ cpuBaseline (virCPUDefPtr *cpus, unsigned int flags) ATTRIBUTE_NONNULL(1); -extern int +int cpuUpdate (virCPUDefPtr guest, const virCPUDef *host) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -extern int +int cpuHasFeature(const virCPUData *data, const char *feature) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); @@ -198,7 +198,7 @@ cpuModelIsAllowed(const char *model, unsigned int nmodels) ATTRIBUTE_NONNULL(1); -extern int +int cpuGetModels(const char *arch, char ***models) ATTRIBUTE_NONNULL(1); diff --git a/src/cpu/cpu_map.h b/src/cpu/cpu_map.h index fcd6c34..6b476fd 100644 --- a/src/cpu/cpu_map.h +++ b/src/cpu/cpu_map.h @@ -43,7 +43,7 @@ typedef int xmlXPathContextPtr ctxt, void *data); -extern int +int cpuMapLoad(const char *arch, cpuMapLoadCallback cb, void *data); diff --git a/src/lxc/lxc_fuse.h b/src/lxc/lxc_fuse.h index d60492b..38bbe22 100644 --- a/src/lxc/lxc_fuse.h +++ b/src/lxc/lxc_fuse.h @@ -57,8 +57,8 @@ struct virLXCFuse { }; typedef struct virLXCFuse *virLXCFusePtr; -extern int lxcSetupFuse(virLXCFusePtr *f, virDomainDefPtr def); -extern int lxcStartFuse(virLXCFusePtr f); -extern void lxcFreeFuse(virLXCFusePtr *f); +int lxcSetupFuse(virLXCFusePtr *f, virDomainDefPtr def); +int lxcStartFuse(virLXCFusePtr f); +void lxcFreeFuse(virLXCFusePtr *f); #endif /* LXC_FUSE_H */ diff --git a/src/util/virhashcode.h b/src/util/virhashcode.h index 09e6eeb..7732f81 100644 --- a/src/util/virhashcode.h +++ b/src/util/virhashcode.h @@ -30,6 +30,6 @@ # include "internal.h" -extern uint32_t virHashCodeGen(const void *key, size_t len, uint32_t seed); +uint32_t virHashCodeGen(const void *key, size_t len, uint32_t seed); #endif /* __VIR_HASH_CODE_H__ */ diff --git a/src/util/virlog.h b/src/util/virlog.h index b5056f5..3ad00d4 100644 --- a/src/util/virlog.h +++ b/src/util/virlog.h @@ -170,50 +170,50 @@ typedef enum { VIR_LOG_STACK_TRACE = (1 << 0), } virLogFlags; -extern int virLogGetNbFilters(void); -extern int virLogGetNbOutputs(void); -extern char *virLogGetFilters(void); -extern char *virLogGetOutputs(void); -extern virLogPriority virLogGetDefaultPriority(void); -extern int virLogSetDefaultPriority(virLogPriority priority); -extern void virLogSetFromEnv(void); -extern int virLogDefineFilter(const char *match, - virLogPriority priority, - unsigned int flags); -extern int virLogDefineOutput(virLogOutputFunc f, - virLogCloseFunc c, - void *data, - virLogPriority priority, - virLogDestination dest, - const char *name, - unsigned int flags); +int virLogGetNbFilters(void); +int virLogGetNbOutputs(void); +char *virLogGetFilters(void); +char *virLogGetOutputs(void); +virLogPriority virLogGetDefaultPriority(void); +int virLogSetDefaultPriority(virLogPriority priority); +void virLogSetFromEnv(void); +int virLogDefineFilter(const char *match, + virLogPriority priority, + unsigned int flags); +int virLogDefineOutput(virLogOutputFunc f, + virLogCloseFunc c, + void *data, + virLogPriority priority, + virLogDestination dest, + const char *name, + unsigned int flags); /* * Internal logging API */ -extern void virLogLock(void); -extern void virLogUnlock(void); -extern int virLogReset(void); -extern int virLogParseDefaultPriority(const char *priority); -extern int virLogParseFilters(const char *filters); -extern int virLogParseOutputs(const char *output); -extern int virLogPriorityFromSyslog(int priority); -extern void virLogMessage(virLogSourcePtr source, - virLogPriority priority, - const char *filename, - int linenr, - const char *funcname, - virLogMetadataPtr metadata, - const char *fmt, ...) ATTRIBUTE_FMT_PRINTF(7, 8); -extern void virLogVMessage(virLogSourcePtr source, - virLogPriority priority, - const char *filename, - int linenr, - const char *funcname, - virLogMetadataPtr metadata, - const char *fmt, - va_list vargs) ATTRIBUTE_FMT_PRINTF(7, 0); +void virLogLock(void); +void virLogUnlock(void); +int virLogReset(void); +int virLogParseDefaultPriority(const char *priority); +int virLogParseFilters(const char *filters); +int virLogParseOutputs(const char *output); +int virLogPriorityFromSyslog(int priority); +void virLogMessage(virLogSourcePtr source, + virLogPriority priority, + const char *filename, + int linenr, + const char *funcname, + virLogMetadataPtr metadata, + const char *fmt, ...) ATTRIBUTE_FMT_PRINTF(7, 8); +void virLogVMessage(virLogSourcePtr source, + virLogPriority priority, + const char *filename, + int linenr, + const char *funcname, + virLogMetadataPtr metadata, + const char *fmt, + va_list vargs) ATTRIBUTE_FMT_PRINTF(7, 0); bool virLogProbablyLogMessage(const char *str); diff --git a/src/util/virstats.h b/src/util/virstats.h index d2c6b64..69f4cf1 100644 --- a/src/util/virstats.h +++ b/src/util/virstats.h @@ -25,7 +25,7 @@ # include "internal.h" -extern int virNetInterfaceStats(const char *path, - virDomainInterfaceStatsPtr stats); +int virNetInterfaceStats(const char *path, + virDomainInterfaceStatsPtr stats); #endif /* __STATS_LINUX_H__ */ diff --git a/src/xen/block_stats.h b/src/xen/block_stats.h index 6cc9959..b9c5ad6 100644 --- a/src/xen/block_stats.h +++ b/src/xen/block_stats.h @@ -27,11 +27,11 @@ # include "xen_driver.h" -extern int xenLinuxDomainBlockStats (xenUnifiedPrivatePtr priv, +int xenLinuxDomainBlockStats (xenUnifiedPrivatePtr priv, virDomainDefPtr def, const char *path, virDomainBlockStatsPtr stats); -extern int xenLinuxDomainDeviceID(int domid, const char *dev); +int xenLinuxDomainDeviceID(int domid, const char *dev); # endif /* __linux__ */ diff --git a/src/xen/xen_driver.h b/src/xen/xen_driver.h index 5d50a90..8578324 100644 --- a/src/xen/xen_driver.h +++ b/src/xen/xen_driver.h @@ -51,7 +51,7 @@ # define MAX_VIRT_CPUS XEN_LEGACY_MAX_VCPUS # endif -extern int xenRegister (void); +int xenRegister (void); # define XEN_UNIFIED_HYPERVISOR_OFFSET 0 # define XEN_UNIFIED_XEND_OFFSET 1 diff --git a/src/xenapi/xenapi_driver.h b/src/xenapi/xenapi_driver.h index 0925731..1051997 100644 --- a/src/xenapi/xenapi_driver.h +++ b/src/xenapi/xenapi_driver.h @@ -23,6 +23,6 @@ #ifndef __VIR_XENAPI_PRIV_H__ # define __VIR_XENAPI_PRIV_H__ -extern int xenapiRegister(void); +int xenapiRegister(void); #endif /* __VIR_XENAPI_PRIV_H__ */ diff --git a/tools/virt-host-validate-common.h b/tools/virt-host-validate-common.h index c14e922..b6fe17d 100644 --- a/tools/virt-host-validate-common.h +++ b/tools/virt-host-validate-common.h @@ -44,45 +44,45 @@ typedef enum { VIR_ENUM_DECL(virHostValidateCPUFlag); -extern void virHostMsgSetQuiet(bool quietFlag); +void virHostMsgSetQuiet(bool quietFlag); -extern void virHostMsgCheck(const char *prefix, - const char *format, - ...) ATTRIBUTE_FMT_PRINTF(2, 3); +void virHostMsgCheck(const char *prefix, + const char *format, + ...) ATTRIBUTE_FMT_PRINTF(2, 3); -extern void virHostMsgPass(void); -extern void virHostMsgFail(virHostValidateLevel level, - const char *format, - ...) ATTRIBUTE_FMT_PRINTF(2, 3); +void virHostMsgPass(void); +void virHostMsgFail(virHostValidateLevel level, + const char *format, + ...) ATTRIBUTE_FMT_PRINTF(2, 3); -extern int virHostValidateDeviceExists(const char *hvname, - const char *dev_name, - virHostValidateLevel level, - const char *hint); +int virHostValidateDeviceExists(const char *hvname, + const char *dev_name, + virHostValidateLevel level, + const char *hint); -extern int virHostValidateDeviceAccessible(const char *hvname, - const char *dev_name, - virHostValidateLevel level, - const char *hint); +int virHostValidateDeviceAccessible(const char *hvname, + const char *dev_name, + virHostValidateLevel level, + const char *hint); -extern virBitmapPtr virHostValidateGetCPUFlags(void); +virBitmapPtr virHostValidateGetCPUFlags(void); -extern int virHostValidateLinuxKernel(const char *hvname, - int version, - virHostValidateLevel level, - const char *hint); +int virHostValidateLinuxKernel(const char *hvname, + int version, + virHostValidateLevel level, + const char *hint); -extern int virHostValidateNamespace(const char *hvname, - const char *ns_name, - virHostValidateLevel level, - const char *hint); +int virHostValidateNamespace(const char *hvname, + const char *ns_name, + virHostValidateLevel level, + const char *hint); -extern int virHostValidateCGroupController(const char *hvname, - const char *cg_name, - virHostValidateLevel level, - const char *config_name); +int virHostValidateCGroupController(const char *hvname, + const char *cg_name, + virHostValidateLevel level, + const char *config_name); -extern int virHostValidateIOMMU(const char *hvname, - virHostValidateLevel level); +int virHostValidateIOMMU(const char *hvname, + virHostValidateLevel level); #endif /* __VIRT_HOST_VALIDATE_COMMON_H__ */ diff --git a/tools/virt-host-validate-lxc.h b/tools/virt-host-validate-lxc.h index 6f1b3e6..17b02a3 100644 --- a/tools/virt-host-validate-lxc.h +++ b/tools/virt-host-validate-lxc.h @@ -22,6 +22,6 @@ #ifndef __VIRT_HOST_VALIDATE_LXC_H__ # define __VIRT_HOST_VALIDATE_LXC_H__ -extern int virHostValidateLXC(void); +int virHostValidateLXC(void); #endif /* __VIRT_HOST_VALIDATE_LXC_H__ */ diff --git a/tools/virt-host-validate-qemu.h b/tools/virt-host-validate-qemu.h index 01d72bb..8a0ce46 100644 --- a/tools/virt-host-validate-qemu.h +++ b/tools/virt-host-validate-qemu.h @@ -22,6 +22,6 @@ #ifndef __VIRT_HOST_VALIDATE_QEMU_H__ # define __VIRT_HOST_VALIDATE_QEMU_H__ -extern int virHostValidateQEMU(void); +int virHostValidateQEMU(void); #endif /* __VIRT_HOST_VALIDATE_QEMU_H__ */ -- 2.5.5

2 2

[libvirt] [PATCH sandbox] pkgconfig: remove non-existent requirement on 'sandbox-2.0'
by Cole Robinson 11 May '16

11 May '16

From: Gary Tierney <gary.tierney(a)gmx.com> $ pkg-config --cflags libvirt-sandbox-1.0 Package sandbox-2.0 was not found in the pkg-config search path. Perhaps you should add the directory containing `sandbox-2.0.pc' to the PKG_CONFIG_PATH environment variable Package 'sandbox-2.0', required by 'libvirt-sandbox-1.0', not found https://bugzilla.redhat.com/show_bug.cgi?id=1327908 --- libvirt-sandbox-1.0.pc.in | 1 - 1 file changed, 1 deletion(-) diff --git a/libvirt-sandbox-1.0.pc.in b/libvirt-sandbox-1.0.pc.in index 1fb25bd..d444bba 100644 --- a/libvirt-sandbox-1.0.pc.in +++ b/libvirt-sandbox-1.0.pc.in @@ -6,6 +6,5 @@ includedir=@includedir@ Name: libvirt-sandbox Version: @VERSION@ Description: libvirt sandbox library -Requires: sandbox-2.0 Libs: -L${libdir} -lvirt-sandbox-1.0 @LIBVIRT_GOBJECT_LIBS@ Cflags: -I${includedir}/libvirt-sandbox-1.0 @LIBVIRT_GOBJECT_CFLAGS@ -- 2.7.4

2 1

[libvirt] Error in `virsh': corrupted double-linked list while running virsh domstate
by Eric Wheeler 11 May '16

11 May '16

Hello all, We've been using libvirt for years and it works great, however we just hit a bug. This is running libvirt-1.2.17-13.el7_2.4, however strangely, we had the same backtrace on a complete difference system in a different data center using version libvirt-1.2.17-13.el7_2.3. Both traces are pasted below. This rarely happens, so I'm not sure how to reproduce it. I'm opening to suggestions if you would like to try anything. -Eric ======== This is the backtrace using libvirt-1.2.17-13.el7_2.4 ======== May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ *** Error in `virsh': corrupted double-linked list: 0x000055f89e7035d0 *** ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ ======= Backtrace: ========= ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ /lib64/libc.so.6(+0x7b184)[0x7eff8922c184] ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ /lib64/libc.so.6(+0x7d235)[0x7eff8922e235] ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ /lib64/libvirt.so.0(virFree+0x1a)[0x7eff8c4fd55a] ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ /lib64/libvirt.so.0(virObjectUnref+0x145)[0x7eff8c5443b5] ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ /lib64/libvirt.so.0(+0x81794)[0x7eff8c51a794] ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ /lib64/libvirt.so.0(virEventPollRunOnce+0x69f)[0x7eff8c51baff] ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ /lib64/libvirt.so.0(virEventRunDefaultImpl+0x42)[0x7eff8c51a2f2] ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ virsh(+0x26545)[0x55f89d613545] ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ /lib64/libvirt.so.0(+0xc3f42)[0x7eff8c55cf42] ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ /lib64/libpthread.so.0(+0x7dc5)[0x7eff89579dc5] ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ /lib64/libc.so.6(clone+0x6d)[0x7eff892a728d] ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ ======= Memory map: ======== ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 55f89d5ed000-55f89d664000 r-xp 00000000 fd:02 135495 /usr/bin/virsh ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 55f89d864000-55f89d877000 r--p 00077000 fd:02 135495 /usr/bin/virsh ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 55f89d877000-55f89d878000 rw-p 0008a000 fd:02 135495 /usr/bin/virsh ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 55f89e6e5000-55f89e71e000 rw-p 00000000 00:00 0 [heap] ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff7c000000-7eff7c021000 rw-p 00000000 00:00 0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff7c021000-7eff80000000 ---p 00000000 00:00 0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff82601000-7eff82602000 ---p 00000000 00:00 0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff82602000-7eff82e02000 rw-p 00000000 00:00 0 [stack:15324] ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff82e02000-7eff82e05000 r-xp 00000000 fd:02 4520 /usr/lib64/libkeyutils.so.1.5 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff82e05000-7eff83004000 ---p 00003000 fd:02 4520 /usr/lib64/libkeyutils.so.1.5 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff83004000-7eff83005000 r--p 00002000 fd:02 4520 /usr/lib64/libkeyutils.so.1.5 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff83005000-7eff83006000 rw-p 00003000 fd:02 4520 /usr/lib64/libkeyutils.so.1.5 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff83006000-7eff83013000 r-xp 00000000 fd:02 5750 /usr/lib64/libkrb5support.so.0.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff83013000-7eff83213000 ---p 0000d000 fd:02 5750 /usr/lib64/libkrb5support.so.0.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff83213000-7eff83214000 r--p 0000d000 fd:02 5750 /usr/lib64/libkrb5support.so.0.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff83214000-7eff83215000 rw-p 0000e000 fd:02 5750 /usr/lib64/libkrb5support.so.0.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff83215000-7eff83217000 r-xp 00000000 fd:02 2428 /usr/lib64/libfreebl3.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff83217000-7eff83416000 ---p 00002000 fd:02 2428 /usr/lib64/libfreebl3.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff83416000-7eff83417000 r--p 00001000 fd:02 2428 /usr/lib64/libfreebl3.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff83417000-7eff83418000 rw-p 00002000 fd:02 2428 /usr/lib64/libfreebl3.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff83418000-7eff8347b000 r-xp 00000000 fd:02 5772 /usr/lib64/libssl.so.1.0.1e ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8347b000-7eff8367a000 ---p 00063000 fd:02 5772 /usr/lib64/libssl.so.1.0.1e ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8367a000-7eff8367e000 r--p 00062000 fd:02 5772 /usr/lib64/libssl.so.1.0.1e ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8367e000-7eff83685000 rw-p 00066000 fd:02 5772 /usr/lib64/libssl.so.1.0.1e ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff83685000-7eff83843000 r-xp 00000000 fd:02 5770 /usr/lib64/libcrypto.so.1.0.1e ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff83843000-7eff83a43000 ---p 001be000 fd:02 5770 /usr/lib64/libcrypto.so.1.0.1e ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff83a43000-7eff83a5d000 r--p 001be000 fd:02 5770 /usr/lib64/libcrypto.so.1.0.1e ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff83a5d000-7eff83a69000 rw-p 001d8000 fd:02 5770 /usr/lib64/libcrypto.so.1.0.1e ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff83a69000-7eff83a6d000 rw-p 00000000 00:00 0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff83a6d000-7eff83a74000 r-xp 00000000 fd:02 3798 /usr/lib64/libffi.so.6.0.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff83a74000-7eff83c73000 ---p 00007000 fd:02 3798 /usr/lib64/libffi.so.6.0.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff83c73000-7eff83c74000 r--p 00006000 fd:02 3798 /usr/lib64/libffi.so.6.0.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff83c74000-7eff83c75000 rw-p 00007000 fd:02 3798 /usr/lib64/libffi.so.6.0.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff83c75000-7eff83c84000 r-xp 00000000 fd:02 3702 /usr/lib64/libbz2.so.1.0.6 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff83c84000-7eff83e83000 ---p 0000f000 fd:02 3702 /usr/lib64/libbz2.so.1.0.6 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff83e83000-7eff83e84000 r--p 0000e000 fd:02 3702 /usr/lib64/libbz2.so.1.0.6 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff83e84000-7eff83e85000 rw-p 0000f000 fd:02 3702 /usr/lib64/libbz2.so.1.0.6 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff83e85000-7eff83e9a000 r-xp 00000000 fd:02 3767 /usr/lib64/libelf-0.163.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff83e9a000-7eff84099000 ---p 00015000 fd:02 3767 /usr/lib64/libelf-0.163.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff84099000-7eff8409a000 r--p 00014000 fd:02 3767 /usr/lib64/libelf-0.163.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8409a000-7eff8409b000 rw-p 00015000 fd:02 3767 /usr/lib64/libelf-0.163.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8409b000-7eff8409f000 r-xp 00000000 fd:02 3803 /usr/lib64/libattr.so.1.1.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8409f000-7eff8429e000 ---p 00004000 fd:02 3803 /usr/lib64/libattr.so.1.1.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8429e000-7eff8429f000 r--p 00003000 fd:02 3803 /usr/lib64/libattr.so.1.1.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8429f000-7eff842a0000 rw-p 00004000 fd:02 3803 /usr/lib64/libattr.so.1.1.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff842a0000-7eff842c5000 r-xp 00000000 fd:02 3382 /usr/lib64/libtinfo.so.5.9 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff842c5000-7eff844c5000 ---p 00025000 fd:02 3382 /usr/lib64/libtinfo.so.5.9 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff844c5000-7eff844c9000 r--p 00025000 fd:02 3382 /usr/lib64/libtinfo.so.5.9 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff844c9000-7eff844ca000 rw-p 00029000 fd:02 3382 /usr/lib64/libtinfo.so.5.9 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff844ca000-7eff8452a000 r-xp 00000000 fd:02 3469 /usr/lib64/libpcre.so.1.2.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8452a000-7eff84729000 ---p 00060000 fd:02 3469 /usr/lib64/libpcre.so.1.2.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff84729000-7eff8472a000 r--p 0005f000 fd:02 3469 /usr/lib64/libpcre.so.1.2.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8472a000-7eff8472b000 rw-p 00060000 fd:02 3469 /usr/lib64/libpcre.so.1.2.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8472b000-7eff8477b000 r-xp 00000000 fd:02 8402 /usr/lib64/libldap-2.4.so.2.10.3 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8477b000-7eff8497a000 ---p 00050000 fd:02 8402 /usr/lib64/libldap-2.4.so.2.10.3 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8497a000-7eff8497d000 r--p 0004f000 fd:02 8402 /usr/lib64/libldap-2.4.so.2.10.3 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8497d000-7eff8497e000 rw-p 00052000 fd:02 8402 /usr/lib64/libldap-2.4.so.2.10.3 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8497e000-7eff8498c000 r-xp 00000000 fd:02 8400 /usr/lib64/liblber-2.4.so.2.10.3 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8498c000-7eff84b8b000 ---p 0000e000 fd:02 8400 /usr/lib64/liblber-2.4.so.2.10.3 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff84b8b000-7eff84b8c000 r--p 0000d000 fd:02 8400 /usr/lib64/liblber-2.4.so.2.10.3 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff84b8c000-7eff84b8d000 rw-p 0000e000 fd:02 8400 /usr/lib64/liblber-2.4.so.2.10.3 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff84b8d000-7eff84b90000 r-xp 00000000 fd:02 3556 /usr/lib64/libcom_err.so.2.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff84b90000-7eff84d8f000 ---p 00003000 fd:02 3556 /usr/lib64/libcom_err.so.2.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff84d8f000-7eff84d90000 r--p 00002000 fd:02 3556 /usr/lib64/libcom_err.so.2.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff84d90000-7eff84d91000 rw-p 00003000 fd:02 3556 /usr/lib64/libcom_err.so.2.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff84d91000-7eff84dc0000 r-xp 00000000 fd:02 5738 /usr/lib64/libk5crypto.so.3.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff84dc0000-7eff84fbf000 ---p 0002f000 fd:02 5738 /usr/lib64/libk5crypto.so.3.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff84fbf000-7eff84fc1000 r--p 0002e000 fd:02 5738 /usr/lib64/libk5crypto.so.3.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff84fc1000-7eff84fc2000 rw-p 00030000 fd:02 5738 /usr/lib64/libk5crypto.so.3.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff84fc2000-7eff84fc3000 rw-p 00000000 00:00 0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff84fc3000-7eff85098000 r-xp 00000000 fd:02 5748 /usr/lib64/libkrb5.so.3.3 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff85098000-7eff85298000 ---p 000d5000 fd:02 5748 /usr/lib64/libkrb5.so.3.3 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff85298000-7eff852a5000 r--p 000d5000 fd:02 5748 /usr/lib64/libkrb5.so.3.3 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff852a5000-7eff852a8000 rw-p 000e2000 fd:02 5748 /usr/lib64/libkrb5.so.3.3 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff852a8000-7eff852f1000 r-xp 00000000 fd:02 5734 /usr/lib64/libgssapi_krb5.so.2.2 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff852f1000-7eff854f1000 ---p 00049000 fd:02 5734 /usr/lib64/libgssapi_krb5.so.2.2 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff854f1000-7eff854f2000 r--p 00049000 fd:02 5734 /usr/lib64/libgssapi_krb5.so.2.2 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff854f2000-7eff854f4000 rw-p 0004a000 fd:02 5734 /usr/lib64/libgssapi_krb5.so.2.2 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff854f4000-7eff8552e000 r-xp 00000000 fd:02 19690 /usr/lib64/libnspr4.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8552e000-7eff8572d000 ---p 0003a000 fd:02 19690 /usr/lib64/libnspr4.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8572d000-7eff8572e000 r--p 00039000 fd:02 19690 /usr/lib64/libnspr4.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8572e000-7eff85730000 rw-p 0003a000 fd:02 19690 /usr/lib64/libnspr4.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff85730000-7eff85732000 rw-p 00000000 00:00 0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff85732000-7eff85736000 r-xp 00000000 fd:02 19695 /usr/lib64/libplc4.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff85736000-7eff85935000 ---p 00004000 fd:02 19695 /usr/lib64/libplc4.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff85935000-7eff85936000 r--p 00003000 fd:02 19695 /usr/lib64/libplc4.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff85936000-7eff85937000 rw-p 00004000 fd:02 19695 /usr/lib64/libplc4.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff85937000-7eff8593a000 r-xp 00000000 fd:02 19696 /usr/lib64/libplds4.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8593a000-7eff85b39000 ---p 00003000 fd:02 19696 /usr/lib64/libplds4.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff85b39000-7eff85b3a000 r--p 00002000 fd:02 19696 /usr/lib64/libplds4.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff85b3a000-7eff85b3b000 rw-p 00003000 fd:02 19696 /usr/lib64/libplds4.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff85b3b000-7eff85b61000 r-xp 00000000 fd:02 19697 /usr/lib64/libnssutil3.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff85b61000-7eff85d60000 ---p 00026000 fd:02 19697 /usr/lib64/libnssutil3.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff85d60000-7eff85d66000 r--p 00025000 fd:02 19697 /usr/lib64/libnssutil3.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff85d66000-7eff85d67000 rw-p 0002b000 fd:02 19697 /usr/lib64/libnssutil3.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff85d67000-7eff85e85000 r-xp 00000000 fd:02 4102 /usr/lib64/libnss3.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff85e85000-7eff86084000 ---p 0011e000 fd:02 4102 /usr/lib64/libnss3.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff86084000-7eff86089000 r--p 0011d000 fd:02 4102 /usr/lib64/libnss3.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff86089000-7eff8608b000 rw-p 00122000 fd:02 4102 /usr/lib64/libnss3.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8608b000-7eff8608d000 rw-p 00000000 00:00 0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8608d000-7eff860b1000 r-xp 00000000 fd:02 19704 /usr/lib64/libsmime3.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff860b1000-7eff862b0000 ---p 00024000 fd:02 19704 /usr/lib64/libsmime3.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff862b0000-7eff862b3000 r--p 00023000 fd:02 19704 /usr/lib64/libsmime3.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff862b3000-7eff862b4000 rw-p 00026000 fd:02 19704 /usr/lib64/libsmime3.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff862b4000-7eff862f2000 r-xp 00000000 fd:02 19705 /usr/lib64/libssl3.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff862f2000-7eff864f1000 ---p 0003e000 fd:02 19705 /usr/lib64/libssl3.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff864f1000-7eff864f5000 r--p 0003d000 fd:02 19705 /usr/lib64/libssl3.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff864f5000-7eff864f6000 rw-p 00041000 fd:02 19705 /usr/lib64/libssl3.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff864f6000-7eff864f7000 rw-p 00000000 00:00 0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff864f7000-7eff8651f000 r-xp 00000000 fd:02 8358 /usr/lib64/libssh2.so.1.0.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8651f000-7eff8671f000 ---p 00028000 fd:02 8358 /usr/lib64/libssh2.so.1.0.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8671f000-7eff86720000 r--p 00028000 fd:02 8358 /usr/lib64/libssh2.so.1.0.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff86720000-7eff86721000 rw-p 00029000 fd:02 8358 /usr/lib64/libssh2.so.1.0.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff86721000-7eff86753000 r-xp 00000000 fd:02 4032 /usr/lib64/libidn.so.11.6.11 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff86753000-7eff86952000 ---p 00032000 fd:02 4032 /usr/lib64/libidn.so.11.6.11 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff86952000-7eff86953000 r--p 00031000 fd:02 4032 /usr/lib64/libidn.so.11.6.11 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff86953000-7eff86954000 rw-p 00032000 fd:02 4032 /usr/lib64/libidn.so.11.6.11 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff86954000-7eff8695c000 r-xp 00000000 fd:02 3019 /usr/lib64/libcrypt-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8695c000-7eff86b5b000 ---p 00008000 fd:02 3019 /usr/lib64/libcrypt-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff86b5b000-7eff86b5c000 r--p 00007000 fd:02 3019 /usr/lib64/libcrypt-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff86b5c000-7eff86b5d000 rw-p 00008000 fd:02 3019 /usr/lib64/libcrypt-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff86b5d000-7eff86b8b000 rw-p 00000000 00:00 0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff86b8b000-7eff86c01000 r-xp 00000000 fd:02 4076 /usr/lib64/libgmp.so.10.2.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff86c01000-7eff86e00000 ---p 00076000 fd:02 4076 /usr/lib64/libgmp.so.10.2.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff86e00000-7eff86e01000 r--p 00075000 fd:02 4076 /usr/lib64/libgmp.so.10.2.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff86e01000-7eff86e02000 rw-p 00076000 fd:02 4076 /usr/lib64/libgmp.so.10.2.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff86e02000-7eff86e28000 r-xp 00000000 fd:02 4571 /usr/lib64/libhogweed.so.2.5 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff86e28000-7eff87027000 ---p 00026000 fd:02 4571 /usr/lib64/libhogweed.so.2.5 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff87027000-7eff87028000 r--p 00025000 fd:02 4571 /usr/lib64/libhogweed.so.2.5 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff87028000-7eff87029000 rw-p 00026000 fd:02 4571 /usr/lib64/libhogweed.so.2.5 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff87029000-7eff87058000 r-xp 00000000 fd:02 4573 /usr/lib64/libnettle.so.4.7 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff87058000-7eff87258000 ---p 0002f000 fd:02 4573 /usr/lib64/libnettle.so.4.7 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff87258000-7eff87259000 r--p 0002f000 fd:02 4573 /usr/lib64/libnettle.so.4.7 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff87259000-7eff8725a000 rw-p 00030000 fd:02 4573 /usr/lib64/libnettle.so.4.7 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8725a000-7eff8726c000 r-xp 00000000 fd:02 4524 /usr/lib64/libtasn1.so.6.2.3 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8726c000-7eff8746c000 ---p 00012000 fd:02 4524 /usr/lib64/libtasn1.so.6.2.3 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8746c000-7eff8746d000 r--p 00012000 fd:02 4524 /usr/lib64/libtasn1.so.6.2.3 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8746d000-7eff8746e000 rw-p 00013000 fd:02 4524 /usr/lib64/libtasn1.so.6.2.3 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8746e000-7eff874dc000 r-xp 00000000 fd:02 9719 /usr/lib64/libtspi.so.1.2.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff874dc000-7eff876db000 ---p 0006e000 fd:02 9719 /usr/lib64/libtspi.so.1.2.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff876db000-7eff876dc000 r--p 0006d000 fd:02 9719 /usr/lib64/libtspi.so.1.2.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff876dc000-7eff876de000 rw-p 0006e000 fd:02 9719 /usr/lib64/libtspi.so.1.2.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff876de000-7eff876df000 rw-p 00000000 00:00 0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff876df000-7eff8771b000 r-xp 00000000 fd:02 3878 /usr/lib64/libp11-kit.so.0.0.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8771b000-7eff8791a000 ---p 0003c000 fd:02 3878 /usr/lib64/libp11-kit.so.0.0.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8791a000-7eff87923000 r--p 0003b000 fd:02 3878 /usr/lib64/libp11-kit.so.0.0.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff87923000-7eff87925000 rw-p 00044000 fd:02 3878 /usr/lib64/libp11-kit.so.0.0.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff87925000-7eff8793a000 r-xp 00000000 fd:02 3487 /usr/lib64/libz.so.1.2.7 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8793a000-7eff87b39000 ---p 00015000 fd:02 3487 /usr/lib64/libz.so.1.2.7 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff87b39000-7eff87b3a000 r--p 00014000 fd:02 3487 /usr/lib64/libz.so.1.2.7 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff87b3a000-7eff87b3b000 rw-p 00015000 fd:02 3487 /usr/lib64/libz.so.1.2.7 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff87b3b000-7eff87b80000 r-xp 00000000 fd:02 3918 /usr/lib64/libdw-0.163.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff87b80000-7eff87d7f000 ---p 00045000 fd:02 3918 /usr/lib64/libdw-0.163.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff87d7f000-7eff87d81000 r--p 00044000 fd:02 3918 /usr/lib64/libdw-0.163.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff87d81000-7eff87d82000 rw-p 00046000 fd:02 3918 /usr/lib64/libdw-0.163.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff87d82000-7eff87d98000 r-xp 00000000 fd:02 3048 /usr/lib64/libresolv-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff87d98000-7eff87f98000 ---p 00016000 fd:02 3048 /usr/lib64/libresolv-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff87f98000-7eff87f99000 r--p 00016000 fd:02 3048 /usr/lib64/libresolv-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff87f99000-7eff87f9a000 rw-p 00017000 fd:02 3048 /usr/lib64/libresolv-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff87f9a000-7eff87f9c000 rw-p 00000000 00:00 0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff87f9c000-7eff87fa0000 r-xp 00000000 fd:02 3779 /usr/lib64/libgpg-error.so.0.10.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff87fa0000-7eff8819f000 ---p 00004000 fd:02 3779 /usr/lib64/libgpg-error.so.0.10.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8819f000-7eff881a0000 r--p 00003000 fd:02 3779 /usr/lib64/libgpg-error.so.0.10.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff881a0000-7eff881a1000 rw-p 00004000 fd:02 3779 /usr/lib64/libgpg-error.so.0.10.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff881a1000-7eff8821d000 r-xp 00000000 fd:02 3819 /usr/lib64/libgcrypt.so.11.8.2 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8821d000-7eff8841d000 ---p 0007c000 fd:02 3819 /usr/lib64/libgcrypt.so.11.8.2 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8841d000-7eff8841e000 r--p 0007c000 fd:02 3819 /usr/lib64/libgcrypt.so.11.8.2 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8841e000-7eff88421000 rw-p 0007d000 fd:02 3819 /usr/lib64/libgcrypt.so.11.8.2 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff88421000-7eff88422000 rw-p 00000000 00:00 0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff88422000-7eff88446000 r-xp 00000000 fd:02 3334 /usr/lib64/liblzma.so.5.0.99 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff88446000-7eff88645000 ---p 00024000 fd:02 3334 /usr/lib64/liblzma.so.5.0.99 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff88645000-7eff88646000 r--p 00023000 fd:02 3334 /usr/lib64/liblzma.so.5.0.99 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff88646000-7eff88647000 rw-p 00024000 fd:02 3334 /usr/lib64/liblzma.so.5.0.99 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff88647000-7eff8864b000 r-xp 00000000 fd:02 3808 /usr/lib64/libcap.so.2.22 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8864b000-7eff8884a000 ---p 00004000 fd:02 3808 /usr/lib64/libcap.so.2.22 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8884a000-7eff8884b000 r--p 00003000 fd:02 3808 /usr/lib64/libcap.so.2.22 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8884b000-7eff8884c000 rw-p 00004000 fd:02 3808 /usr/lib64/libcap.so.2.22 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8884c000-7eff88861000 r-xp 00000000 fd:02 13 /usr/lib64/libgcc_s-4.8.5-20150702.so.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff88861000-7eff88a60000 ---p 00015000 fd:02 13 /usr/lib64/libgcc_s-4.8.5-20150702.so.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff88a60000-7eff88a61000 r--p 00014000 fd:02 13 /usr/lib64/libgcc_s-4.8.5-20150702.so.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff88a61000-7eff88a62000 rw-p 00015000 fd:02 13 /usr/lib64/libgcc_s-4.8.5-20150702.so.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff88a62000-7eff88aa6000 r-xp 00000000 fd:02 3467 /usr/lib64/libsepol.so.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff88aa6000-7eff88ca5000 ---p 00044000 fd:02 3467 /usr/lib64/libsepol.so.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff88ca5000-7eff88ca6000 r--p 00043000 fd:02 3467 /usr/lib64/libsepol.so.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff88ca6000-7eff88ca7000 rw-p 00044000 fd:02 3467 /usr/lib64/libsepol.so.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff88ca7000-7eff88cae000 r-xp 00000000 fd:02 3050 /usr/lib64/librt-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff88cae000-7eff88ead000 ---p 00007000 fd:02 3050 /usr/lib64/librt-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff88ead000-7eff88eae000 r--p 00006000 fd:02 3050 /usr/lib64/librt-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff88eae000-7eff88eaf000 rw-p 00007000 fd:02 3050 /usr/lib64/librt-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff88eaf000-7eff88fb0000 r-xp 00000000 fd:02 3024 /usr/lib64/libm-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff88fb0000-7eff891af000 ---p 00101000 fd:02 3024 /usr/lib64/libm-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff891af000-7eff891b0000 r--p 00100000 fd:02 3024 /usr/lib64/libm-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff891b0000-7eff891b1000 rw-p 00101000 fd:02 3024 /usr/lib64/libm-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff891b1000-7eff89367000 r-xp 00000000 fd:02 3015 /usr/lib64/libc-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff89367000-7eff89567000 ---p 001b6000 fd:02 3015 /usr/lib64/libc-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff89567000-7eff8956b000 r--p 001b6000 fd:02 3015 /usr/lib64/libc-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8956b000-7eff8956d000 rw-p 001ba000 fd:02 3015 /usr/lib64/libc-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8956d000-7eff89572000 rw-p 00000000 00:00 0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff89572000-7eff89588000 r-xp 00000000 fd:02 3046 /usr/lib64/libpthread-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff89588000-7eff89788000 ---p 00016000 fd:02 3046 /usr/lib64/libpthread-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff89788000-7eff89789000 r--p 00016000 fd:02 3046 /usr/lib64/libpthread-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff89789000-7eff8978a000 rw-p 00017000 fd:02 3046 /usr/lib64/libpthread-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8978a000-7eff8978e000 rw-p 00000000 00:00 0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8978e000-7eff89791000 r-xp 00000000 fd:02 3022 /usr/lib64/libdl-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff89791000-7eff89990000 ---p 00003000 fd:02 3022 /usr/lib64/libdl-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff89990000-7eff89991000 r--p 00002000 fd:02 3022 /usr/lib64/libdl-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff89991000-7eff89992000 rw-p 00003000 fd:02 3022 /usr/lib64/libdl-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff89992000-7eff899ce000 r-xp 00000000 fd:02 3708 /usr/lib64/libreadline.so.6.2 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff899ce000-7eff89bce000 ---p 0003c000 fd:02 3708 /usr/lib64/libreadline.so.6.2 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff89bce000-7eff89bd0000 r--p 0003c000 fd:02 3708 /usr/lib64/libreadline.so.6.2 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff89bd0000-7eff89bd6000 rw-p 0003e000 fd:02 3708 /usr/lib64/libreadline.so.6.2 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff89bd6000-7eff89bd8000 rw-p 00000000 00:00 0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff89bd8000-7eff89d36000 r-xp 00000000 fd:02 3850 /usr/lib64/libxml2.so.2.9.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff89d36000-7eff89f35000 ---p 0015e000 fd:02 3850 /usr/lib64/libxml2.so.2.9.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff89f35000-7eff89f3d000 r--p 0015d000 fd:02 3850 /usr/lib64/libxml2.so.2.9.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff89f3d000-7eff89f3f000 rw-p 00165000 fd:02 3850 /usr/lib64/libxml2.so.2.9.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff89f3f000-7eff89f41000 rw-p 00000000 00:00 0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff89f41000-7eff89f43000 r-xp 00000000 fd:02 3054 /usr/lib64/libutil-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff89f43000-7eff8a142000 ---p 00002000 fd:02 3054 /usr/lib64/libutil-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8a142000-7eff8a143000 r--p 00001000 fd:02 3054 /usr/lib64/libutil-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8a143000-7eff8a144000 rw-p 00002000 fd:02 3054 /usr/lib64/libutil-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8a144000-7eff8a165000 r-xp 00000000 fd:02 3485 /usr/lib64/libselinux.so.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8a165000-7eff8a365000 ---p 00021000 fd:02 3485 /usr/lib64/libselinux.so.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8a365000-7eff8a366000 r--p 00021000 fd:02 3485 /usr/lib64/libselinux.so.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8a366000-7eff8a367000 rw-p 00022000 fd:02 3485 /usr/lib64/libselinux.so.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8a367000-7eff8a369000 rw-p 00000000 00:00 0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8a369000-7eff8a3cd000 r-xp 00000000 fd:02 8361 /usr/lib64/libcurl.so.4.3.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8a3cd000-7eff8a5cd000 ---p 00064000 fd:02 8361 /usr/lib64/libcurl.so.4.3.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8a5cd000-7eff8a5cf000 r--p 00064000 fd:02 8361 /usr/lib64/libcurl.so.4.3.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8a5cf000-7eff8a5d0000 rw-p 00066000 fd:02 8361 /usr/lib64/libcurl.so.4.3.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8a5d0000-7eff8a5d1000 rw-p 00000000 00:00 0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8a5d1000-7eff8a5ed000 r-xp 00000000 fd:02 4135 /usr/lib64/libsasl2.so.3.0.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8a5ed000-7eff8a7ec000 ---p 0001c000 fd:02 4135 /usr/lib64/libsasl2.so.3.0.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8a7ec000-7eff8a7ed000 r--p 0001b000 fd:02 4135 /usr/lib64/libsasl2.so.3.0.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8a7ed000-7eff8a7ee000 rw-p 0001c000 fd:02 4135 /usr/lib64/libsasl2.so.3.0.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8a7ee000-7eff8a916000 r-xp 00000000 fd:02 9724 /usr/lib64/libgnutls.so.28.41.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8a916000-7eff8ab16000 ---p 00128000 fd:02 9724 /usr/lib64/libgnutls.so.28.41.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8ab16000-7eff8ab20000 r--p 00128000 fd:02 9724 /usr/lib64/libgnutls.so.28.41.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8ab20000-7eff8ab23000 rw-p 00132000 fd:02 9724 /usr/lib64/libgnutls.so.28.41.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8ab23000-7eff8ab69000 r-xp 00000000 fd:02 3706 /usr/lib64/libdbus-1.so.3.7.4 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8ab69000-7eff8ad69000 ---p 00046000 fd:02 3706 /usr/lib64/libdbus-1.so.3.7.4 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8ad69000-7eff8ad6a000 r--p 00046000 fd:02 3706 /usr/lib64/libdbus-1.so.3.7.4 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8ad6a000-7eff8ad6b000 rw-p 00047000 fd:02 3706 /usr/lib64/libdbus-1.so.3.7.4 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8ad6b000-7eff8ad7b000 r-xp 00000000 fd:02 5547 /usr/lib64/libavahi-client.so.3.2.9 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8ad7b000-7eff8af7a000 ---p 00010000 fd:02 5547 /usr/lib64/libavahi-client.so.3.2.9 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8af7a000-7eff8af7b000 r--p 0000f000 fd:02 5547 /usr/lib64/libavahi-client.so.3.2.9 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8af7b000-7eff8af7c000 rw-p 00010000 fd:02 5547 /usr/lib64/libavahi-client.so.3.2.9 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8af7c000-7eff8af88000 r-xp 00000000 fd:02 5549 /usr/lib64/libavahi-common.so.3.5.3 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8af88000-7eff8b187000 ---p 0000c000 fd:02 5549 /usr/lib64/libavahi-common.so.3.5.3 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8b187000-7eff8b188000 r--p 0000b000 fd:02 5549 /usr/lib64/libavahi-common.so.3.5.3 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8b188000-7eff8b189000 rw-p 0000c000 fd:02 5549 /usr/lib64/libavahi-common.so.3.5.3 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8b189000-7eff8b193000 r-xp 00000000 fd:02 19638 /usr/lib64/libnuma.so.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8b193000-7eff8b393000 ---p 0000a000 fd:02 19638 /usr/lib64/libnuma.so.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8b393000-7eff8b394000 r--p 0000a000 fd:02 19638 /usr/lib64/libnuma.so.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8b394000-7eff8b395000 rw-p 0000b000 fd:02 19638 /usr/lib64/libnuma.so.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8b395000-7eff8b3e9000 r-xp 00000000 fd:02 8681 /usr/lib64/libdevmapper.so.1.02 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8b3e9000-7eff8b5e9000 ---p 00054000 fd:02 8681 /usr/lib64/libdevmapper.so.1.02 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8b5e9000-7eff8b5ea000 r--p 00054000 fd:02 8681 /usr/lib64/libdevmapper.so.1.02 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8b5ea000-7eff8b5ed000 rw-p 00055000 fd:02 8681 /usr/lib64/libdevmapper.so.1.02 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8b5ed000-7eff8b5ef000 rw-p 00000000 00:00 0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8b5ef000-7eff8b60a000 r-xp 00000000 fd:02 3502 /usr/lib64/libaudit.so.1.0.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8b60a000-7eff8b80a000 ---p 0001b000 fd:02 3502 /usr/lib64/libaudit.so.1.0.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8b80a000-7eff8b80b000 r--p 0001b000 fd:02 3502 /usr/lib64/libaudit.so.1.0.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8b80b000-7eff8b80c000 rw-p 0001c000 fd:02 3502 /usr/lib64/libaudit.so.1.0.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8b80c000-7eff8b816000 rw-p 00000000 00:00 0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8b816000-7eff8b830000 r-xp 00000000 fd:02 3862 /usr/lib64/libnl-3.so.200.16.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8b830000-7eff8ba2f000 ---p 0001a000 fd:02 3862 /usr/lib64/libnl-3.so.200.16.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8ba2f000-7eff8ba31000 r--p 00019000 fd:02 3862 /usr/lib64/libnl-3.so.200.16.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8ba31000-7eff8ba32000 rw-p 0001b000 fd:02 3862 /usr/lib64/libnl-3.so.200.16.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8ba32000-7eff8ba79000 r-xp 00000000 fd:02 3868 /usr/lib64/libnl-route-3.so.200.16.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8ba79000-7eff8bc78000 ---p 00047000 fd:02 3868 /usr/lib64/libnl-route-3.so.200.16.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8bc78000-7eff8bc7b000 r--p 00046000 fd:02 3868 /usr/lib64/libnl-route-3.so.200.16.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8bc7b000-7eff8bc7f000 rw-p 00049000 fd:02 3868 /usr/lib64/libnl-route-3.so.200.16.1 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8bc7f000-7eff8bc81000 rw-p 00000000 00:00 0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8bc81000-7eff8bc89000 r-xp 00000000 fd:02 11228 /usr/lib64/libyajl.so.2.0.4 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8bc89000-7eff8be89000 ---p 00008000 fd:02 11228 /usr/lib64/libyajl.so.2.0.4 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8be89000-7eff8be8a000 r--p 00008000 fd:02 11228 /usr/lib64/libyajl.so.2.0.4 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8be8a000-7eff8be8b000 rw-p 00009000 fd:02 11228 /usr/lib64/libyajl.so.2.0.4 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8be8b000-7eff8be8f000 r-xp 00000000 fd:02 4028 /usr/lib64/libcap-ng.so.0.0.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8be8f000-7eff8c08f000 ---p 00004000 fd:02 4028 /usr/lib64/libcap-ng.so.0.0.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8c08f000-7eff8c090000 r--p 00004000 fd:02 4028 /usr/lib64/libcap-ng.so.0.0.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8c090000-7eff8c091000 rw-p 00005000 fd:02 4028 /usr/lib64/libcap-ng.so.0.0.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8c091000-7eff8c094000 r-xp 00000000 fd:02 17293 /usr/lib64/libvirt-qemu.so.0.1002.17 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8c094000-7eff8c293000 ---p 00003000 fd:02 17293 /usr/lib64/libvirt-qemu.so.0.1002.17 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8c293000-7eff8c294000 r--p 00002000 fd:02 17293 /usr/lib64/libvirt-qemu.so.0.1002.17 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8c294000-7eff8c295000 rw-p 00003000 fd:02 17293 /usr/lib64/libvirt-qemu.so.0.1002.17 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8c295000-7eff8c298000 r-xp 00000000 fd:02 17291 /usr/lib64/libvirt-lxc.so.0.1002.17 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8c298000-7eff8c497000 ---p 00003000 fd:02 17291 /usr/lib64/libvirt-lxc.so.0.1002.17 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8c497000-7eff8c498000 r--p 00002000 fd:02 17291 /usr/lib64/libvirt-lxc.so.0.1002.17 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8c498000-7eff8c499000 rw-p 00003000 fd:02 17291 /usr/lib64/libvirt-lxc.so.0.1002.17 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8c499000-7eff8c7c7000 r-xp 00000000 fd:02 17295 /usr/lib64/libvirt.so.0.1002.17 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8c7c7000-7eff8c9c6000 ---p 0032e000 fd:02 17295 /usr/lib64/libvirt.so.0.1002.17 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8c9c6000-7eff8c9d3000 r--p 0032d000 fd:02 17295 /usr/lib64/libvirt.so.0.1002.17 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8c9d3000-7eff8c9df000 rw-p 0033a000 fd:02 17295 /usr/lib64/libvirt.so.0.1002.17 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8c9df000-7eff8c9e0000 rw-p 00000000 00:00 0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8c9e0000-7eff8ca01000 r-xp 00000000 fd:02 2421 /usr/lib64/ld-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8cb99000-7eff8cbb2000 rw-p 00000000 00:00 0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8cbb2000-7eff8cbc4000 r-xp 00000000 fd:02 7931 /usr/lib64/libudev.so.1.6.2 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8cbc4000-7eff8cbc5000 ---p 00012000 fd:02 7931 /usr/lib64/libudev.so.1.6.2 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8cbc5000-7eff8cbc6000 r--p 00012000 fd:02 7931 /usr/lib64/libudev.so.1.6.2 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8cbc6000-7eff8cbc7000 rw-p 00013000 fd:02 7931 /usr/lib64/libudev.so.1.6.2 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8cbc7000-7eff8cbcd000 rw-p 00000000 00:00 0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8cbcd000-7eff8cbf3000 r-xp 00000000 fd:02 7929 /usr/lib64/libsystemd.so.0.6.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8cbf3000-7eff8cbf4000 r--p 00025000 fd:02 7929 /usr/lib64/libsystemd.so.0.6.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8cbf4000-7eff8cbf5000 rw-p 00026000 fd:02 7929 /usr/lib64/libsystemd.so.0.6.0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8cbf5000-7eff8cbf8000 rw-p 00000000 00:00 0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8cbfe000-7eff8cc01000 rw-p 00000000 00:00 0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8cc01000-7eff8cc02000 r--p 00021000 fd:02 2421 /usr/lib64/ld-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8cc02000-7eff8cc03000 rw-p 00022000 fd:02 2421 /usr/lib64/ld-2.17.so ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7eff8cc03000-7eff8cc04000 rw-p 00000000 00:00 0 ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7fff526c8000-7fff526e9000 rw-p 00000000 00:00 0 [stack] ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7fff527c3000-7fff527c5000 r--p 00000000 00:00 0 [vvar] ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ 7fff527c5000-7fff527c7000 r-xp 00000000 00:00 0 [vdso] ] May 10 10:21:14 lrmd[6469]: notice: vm1_monitor_30000:14937:stderr [ ffffffffff600000-ffffffffff601000 r-xp 00000000 00:00 0 [vsyscall] ] ===== This is the second trace using version libvirt-1.2.17-13.el7_2.3 ====== May 10 06:31:57 vm-drbd(vm7)[98278]: ERROR: Virtual domain vm7 has unknown status "*** error in `virsh': corrupted double-linked list: 0x000055802eeb75d0 *** ======= backtrace: ========= /lib64/libc.so.6(+0x7b184)[0x7f9d18443184] /lib64/libc.so.6(+0x7d235)[0x7f9d18445235] /lib64/libvirt.so.0(virfree+0x1a)[0x7f9d1b71444a] /lib64/libvirt.so.0(virobjectunref+0x145)[0x7f9d1b75b0e5] /lib64/libvirt.so.0(+0x814d4)[0x7f9d1b7314d4] /lib64/libvirt.so.0(vireventpollrunonce+0x69f)[0x7f9d1b73283f] /lib64/libvirt.so.0(vireventrundefaultimpl+0x42)[0x7f9d1b731032] virsh(+0x26545)[0x55802d6fe545] /lib64/libvirt.so.0(+0xc3a42)[0x7f9d1b773a42] /lib64/libpthread.so.0(+0x7dc5)[0x7f9d18790dc5] /lib64/libc.so.6(clone+0x6d)[0x7f9d184be28d] ======= memory map: ======== 55802d6d8000-55802d74f000 r-xp 00000000 fd:01 1018 /usr/bin/virsh 55802d94f000-55802d962000 r--p 00077000 fd:01 1018 /usr/bin/virsh 55802d962000-55802d963000 rw-p 0008a000 fd:01 1018 /usr/bin/virsh 55802ee99000-55802eed2000 rw-p 00000000 00:00 0 [heap] 7f9d0c000000-7f9d0c021000 rw-p 00000000 00:00 0 7f9d0c021000-7f9d10000000 ---p 00000000 00:00 0 7f9d11819000-7f9d1181a000 ---p 00000000 00:00 0 7f9d1181a000-7f9d1201a000 rw-p 00000000 00:00 0 [stack:98383] 7f9d1201a000-7f9d1201d000 r-xp 00000000 fd:01 11124 /usr/lib64/libkeyutils.so.1.5 7f9d1201d000-7f9d1221c000 ---p 00003000 fd:01 11124 /usr/lib64/libkeyutils.so.1.5 7f9d1221c000-7f9d1221d000 r--p 00002000 fd:01 11124 /usr/lib64/libkeyutils.so.1.5 7f9d1221d000-7f9d1221e000 rw-p 00003000 fd:01 11124 /usr/lib64/libkeyutils.so.1.5 7f9d1221e000-7f9d1222b000 r-xp 00000000 fd:01 11129 /usr/lib64/libkrb5support.so.0.1 7f9d1222b000-7f9d1242b000 ---p 0000d000 fd:01 11129 /usr/lib64/libkrb5support.so.0.1 7f9d1242b000-7f9d1242c000 r--p 0000d000 fd:01 11129 /usr/lib64/libkrb5support.so.0.1 7f9d1242c000-7f9d1242d000 rw-p 0000e000 fd:01 11129 /usr/lib64/libkrb5support.so.0.1 7f9d1242d000-7f9d1242f000 r-xp 00000000 fd:01 11060 /usr/lib64/libfreebl3.so 7f9d1242f000-7f9d1262e000 ---p 00002000 fd:01 11060 /usr/lib64/libfreebl3.so 7f9d1262e000-7f9d1262f000 r--p 00001000 fd:01 11060 /usr/lib64/libfreebl3.so 7f9d1262f000-7f9d12630000 rw-p 00002000 fd:01 11060 /usr/lib64/libfreebl3.so 7f9d12630000-7f9d12693000 r-xp 00000000 fd:01 11306 /usr/lib64/libssl.so.1.0.1e 7f9d12693000-7f9d12892000 ---p 00063000 fd:01 11306 /usr/lib64/libssl.so.1.0.1e 7f9d12892000-7f9d12896000 r--p 00062000 fd:01 11306 /usr/lib64/libssl.so.1.0.1e 7f9d12896000-7f9d1289d000 rw-p 00066000 fd:01 11306 /usr/lib64/libssl.so.1.0.1e 7f9d1289d000-7f9d12a5b000 r-xp 00000000 fd:01 11022 /usr/lib64/libcrypto.so.1.0.1e 7f9d12a5b000-7f9d12c5b000 ---p 001be000 fd:01 11022 /usr/lib64/libcrypto.so.1.0.1e 7f9d12c5b000-7f9d12c75000 r--p 001be000 fd:01 11022 /usr/lib64/libcrypto.so.1.0.1e 7f9d12c75000-7f9d12c81000 rw-p 001d8000 fd:01 11022 /usr/lib64/libcrypto.so.1.0.1e 7f9d12c81000-7f9d12c85000 rw-p 00000000 00:00 0 7f9d12c85000-7f9d12c8c000 r-xp 00000000 fd:01 11055 /usr/lib64/libffi.so.6.0.1 7f9d12c8c000-7f9d12e8b000 ---p 00007000 fd:01 11055 /usr/lib64/libffi.so.6.0.1 7f9d12e8b000-7f9d12e8c000 r--p 00006000 fd:01 11055 /usr/lib64/libffi.so.6.0.1 7f9d12e8c000-7f9d12e8d000 rw-p 00007000 fd:01 11055 /usr/lib64/libffi.so.6.0.1 7f9d12e8d000-7f9d12e9c000 r-xp 00000000 fd:01 11001 /usr/lib64/libbz2.so.1.0.6 7f9d12e9c000-7f9d1309b000 ---p 0000f000 fd:01 11001 /usr/lib64/libbz2.so.1.0.6 7f9d1309b000-7f9d1309c000 r--p 0000e000 fd:01 11001 /usr/lib64/libbz2.so.1.0.6 7f9d1309c000-7f9d1309d000 rw-p 0000f000 fd:01 11001 /usr/lib64/libbz2.so.1.0.6 7f9d1309d000-7f9d130b2000 r-xp 00000000 fd:01 11044 /usr/lib64/libelf-0.163.so 7f9d130b2000-7f9d132b1000 ---p 00015000 fd:01 11044 /usr/lib64/libelf-0.163.so 7f9d132b1000-7f9d132b2000 r--p 00014000 fd:01 11044 /usr/lib64/libelf-0.163.so 7f9d132b2000-7f9d132b3000 rw-p 00015000 fd:01 11044 /usr/lib64/libelf-0.163.so 7f9d132b3000-7f9d132b7000 r-xp 00000000 fd:01 10987 /usr/lib64/libattr.so.1.1.0 7f9d132b7000-7f9d134b6000 ---p 00004000 fd:01 10987 /usr/lib64/libattr.so.1.1.0 7f9d134b6000-7f9d134b7000 r--p 00003000 fd:01 10987 /usr/lib64/libattr.so.1.1.0 7f9d134b7000-7f9d134b8000 rw-p 00004000 fd:01 10987 /usr/lib64/libattr.so.1.1.0 7f9d134b8000-7f9d134dd000 r-xp 00000000 fd:01 11329 /usr/lib64/libtinfo.so.5.9 7f9d134dd000-7f9d136dd000 ---p 00025000 fd:01 11329 /usr/lib64/libtinfo.so.5.9 7f9d136dd000-7f9d136e1000 r--p 00025000 fd:01 11329 /usr/lib64/libtinfo.so.5.9 7f9d136e1000-7f9d136e2000 rw-p 00029000 fd:01 11329 /usr/lib64/libtinfo.so.5.9 7f9d136e2000-7f9d13742000 r-xp 00000000 fd:01 11236 /usr/lib64/libpcre.so.1.2.0 7f9d13742000-7f9d13941000 ---p 00060000 fd:01 11236 /usr/lib64/libpcre.so.1.2.0 7f9d13941000-7f9d13942000 r--p 0005f000 fd:01 11236 /usr/lib64/libpcre.so.1.2.0 7f9d13942000-7f9d13943000 rw-p 00060000 fd:01 11236 /usr/lib64/libpcre.so.1.2.0 7f9d13943000-7f9d13993000 r-xp 00000000 fd:01 11131 /usr/lib64/libldap-2.4.so.2.10.3 7f9d13993000-7f9d13b92000 ---p 00050000 fd:01 11131 /usr/lib64/libldap-2.4.so.2.10.3 7f9d13b92000-7f9d13b95000 r--p 0004f000 fd:01 11131 /usr/lib64/libldap-2.4.so.2.10.3 7f9d13b95000-7f9d13b96000 rw-p 00052000 fd:01 11131 /usr/lib64/libldap-2.4.so.2.10.3 7f9d13b96000-7f9d13ba4000 r-xp 00000000 fd:01 11130 /usr/lib64/liblber-2.4.so.2.10.3 7f9d13ba4000-7f9d13da3000 ---p 0000e000 fd:01 11130 /usr/lib64/liblber-2.4.so.2.10.3 7f9d13da3000-7f9d13da4000 r--p 0000d000 fd:01 11130 /usr/lib64/liblber-2.4.so.2.10.3 7f9d13da4000-7f9d13da5000 rw-p 0000e000 fd:01 11130 /usr/lib64/liblber-2.4.so.2.10.3 7f9d13da5000-7f9d13da8000 r-xp 00000000 fd:01 11012 /usr/lib64/libcom_err.so.2.1 7f9d13da8000-7f9d13fa7000 ---p 00003000 fd:01 11012 /usr/lib64/libcom_err.so.2.1 7f9d13fa7000-7f9d13fa8000 r--p 00002000 fd:01 11012 /usr/lib64/libcom_err.so.2.1 7f9d13fa8000-7f9d13fa9000 rw-p 00003000 fd:01 11012 /usr/lib64/libcom_err.so.2.1 7f9d13fa9000-7f9d13fd8000 r-xp 00000000 fd:01 11120 /usr/lib64/libk5crypto.so.3.1 7f9d13fd8000-7f9d141d7000 ---p 0002f000 fd:01 11120 /usr/lib64/libk5crypto.so.3.1 7f9d141d7000-7f9d141d9000 r--p 0002e000 fd:01 11120 /usr/lib64/libk5crypto.so.3.1 7f9d141d9000-7f9d141da000 rw-p 00030000 fd:01 11120 /usr/lib64/libk5crypto.so.3.1 7f9d141da000-7f9d141db000 rw-p 00000000 00:00 0 7f9d141db000-7f9d142b0000 r-xp 00000000 fd:01 11128 /usr/lib64/libkrb5.so.3.3 7f9d142b0000-7f9d144b0000 ---p 000d5000 fd:01 11128 /usr/lib64/libkrb5.so.3.3 7f9d144b0000-7f9d144bd000 r--p 000d5000 fd:01 11128 /usr/lib64/libkrb5.so.3.3 7f9d144 -- Eric Wheeler

2 1

[libvirt] libvirt should not disable auto_login of iscsi-targets that are *not* used by libvirt
by Fritz Elfert 10 May '16

10 May '16

Hi, Cole Robinson asked me to post the attached patch here. For more info, see https://bugzilla.redhat.com/show_bug.cgi?id=1331552 Cheers -Fritz

2 1

[libvirt] [PATCH] docs: Fix disk "volume" description
by John Ferlan 10 May '16

10 May '16

Missing a close single quote and a 'be' before used. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Pushed as trivial. docs/formatdomain.html.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 7b29e78..58b8cb6 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -2158,9 +2158,9 @@ Using a LUN from an iSCSI source pool provides the same features as a <code>disk</code> configured using - <code>type</code> 'block' or 'network and <code>device</code> + <code>type</code> 'block' or 'network' and <code>device</code> of 'lun' with respect to how the LUN is presented to and - may used by the guest. + may be used by the guest. <span class="since">Since 1.0.5</span> </p> -- 2.5.5

1 0

[libvirt] [PATCH] qemu: Add extra checks for secret destroy API's
by John Ferlan 10 May '16

10 May '16

Remove the possibility that a NULL hostdev->privateData or a disk->privateData could crash libvirtd by checking for NULL before dereferencing for the secinfo structure in the qemuDomainSecret{Disk|Hostdev}Destroy functions. The hostdevPriv could be NULL if qemuProcessNetworkPrepareDevices adds a new hostdev during virDomainNetGetActualHostdev that then gets inserted via virDomainHostdevInsert. The hostdevPriv was added by commit id '27726d8' and is currently only used by scsi hostdev. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Discovered by laine and debugged on private IRC channel. src/qemu/qemu_domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 93f0a01..0cddb86 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -903,7 +903,7 @@ qemuDomainSecretDiskDestroy(virDomainDiskDefPtr disk) { qemuDomainDiskPrivatePtr diskPriv = QEMU_DOMAIN_DISK_PRIVATE(disk); - if (!diskPriv->secinfo) + if (!diskPriv || !diskPriv->secinfo) return; qemuDomainSecretInfoFree(&diskPriv->secinfo); @@ -964,7 +964,7 @@ qemuDomainSecretHostdevDestroy(virDomainHostdevDefPtr hostdev) qemuDomainHostdevPrivatePtr hostdevPriv = QEMU_DOMAIN_HOSTDEV_PRIVATE(hostdev); - if (!hostdevPriv->secinfo) + if (!hostdevPriv || !hostdevPriv->secinfo) return; qemuDomainSecretInfoFree(&hostdevPriv->secinfo); -- 2.5.5

2 1

[libvirt] [PATCH] util: set vlan tag for macvtap passthrough mode on SRIOV VFs
by Laine Stump 10 May '16

10 May '16

SRIOV VFs used in macvtap passthrough mode can take advantage of the SRIOV card's transparent vlan tagging. All the code was there to set the vlan tag, and it has been used for SRIOV VFs used for hostdev interfaces for several years, but for some reason, the vlan tag for macvtap passthrough devices was stubbed out with a -1. This patch moves a bit of common validation down to a lower level (virNetDevReplaceNetConfig()) so it is shared by hostdev and macvtap modes, and updates the macvtap caller to actually send the vlan config instead of -1. --- While adding the info to the docs, I got a bit carried away fixing up the vlan-specific paragraphs. It someone really wants me to I can move it into a separate patch, but it seemed like more trouble than it was worth at the time... docs/formatdomain.html.in | 61 +++++++++++++++++++++++++++------------------ src/lxc/lxc_process.c | 3 ++- src/network/bridge_driver.c | 17 ++++++++----- src/qemu/qemu_interface.c | 1 + src/util/virhostdev.c | 23 ++--------------- src/util/virnetdev.c | 29 +++++++++++++++++---- src/util/virnetdev.h | 6 +++-- src/util/virnetdevmacvlan.c | 4 ++- src/util/virnetdevmacvlan.h | 2 ++ 9 files changed, 86 insertions(+), 60 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 97794b7..68f0295 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -4032,7 +4032,7 @@ <p> On Linux systems, the bridge device is normally a standard Linux host bridge. On hosts that support Open vSwitch, it is also - possible to connect to an open vSwitch bridge device by adding + possible to connect to an Open vSwitch bridge device by adding a <code><virtualport type='openvswitch'/></code> to the interface definition. (<span class="since">Since 0.9.11</span>). The Open vSwitch type virtualport accepts two @@ -4816,34 +4816,47 @@ qemu-kvm -net nic,model=? /dev/null <p> If (and only if) the network connection used by the guest - supports vlan tagging transparent to the guest, an + supports VLAN tagging transparent to the guest, an optional <code><vlan></code> element can specify one or - more vlan tags to apply to the guest's network - traffic <span class="since">Since 0.10.0</span>. (openvswitch - and type='hostdev' SR-IOV interfaces do support transparent vlan - tagging of guest traffic; everything else, including standard + more VLAN tags to apply to the guest's network + traffic <span class="since">Since 0.10.0</span>. Network + connections that support guest-transparent VLAN tagging include + 1) type='bridge' interfaces connected to an Open vSwitch bridge + <span class="since">Since 0.10.0</span>, 2) SRIOV Virtual + Functions (VF) used via type='hostdev' (direct device + assignment) <span class="since">Since 0.10.0</span>, and 3) + SRIOV VFs used via type='direct' with mode='passthrough' + (macvtap "passthru" mode) <span class="since">Since + 1.3.4</span>; all other connection types, including standard linux bridges and libvirt's own virtual networks, <b>do not</b> support it. 802.1Qbh (vn-link) and 802.1Qbg (VEPA) switches provide their own way (outside of libvirt) to tag guest traffic - onto specific vlans.) To allow for specification of multiple - tags (in the case of vlan trunking), a - subelement, <code><tag></code>, specifies which vlan tag - to use (for example: <code><tag id='42'/></code>. If an - interface has more than one <code><vlan></code> element - defined, it is assumed that the user wants to do VLAN trunking - using all the specified tags. In the case that vlan trunking - with a single tag is desired, the optional + onto specific vlans.) Each tag is given in a + separate <code><tag></code> subelement + of <code><vlan></code> (for example: <code><tag + id='42'/></code>). For VLAN trunking of multiple tags (which + is supported only on Open vSwitch connections), + multiple <code><tag></code> subelements can be specified, + which implies that the user wants to do VLAN trunking on the + interface for all the specified tags. In the case that VLAN + trunking of a single tag is desired, the optional attribute <code>trunk='yes'</code> can be added to the toplevel - vlan element. - </p> - - <p> - For network connections using openvswitch it is possible to - configure the 'native-tagged' and 'native-untagged' vlan modes - <span class="since">Since 1.1.0.</span> This uses the optional - <code>nativeMode</code> attribute on the <code><tag></code> - element: <code>nativeMode</code> may be set to 'tagged' or - 'untagged'. The id attribute of the element sets the native vlan. + <code><vlan></code> element to differentiate trunking of a + single tag from normal tagging. + </p> + + <p> + For network connections using Open vSwitch it is also possible + to configure 'native-tagged' and 'native-untagged' VLAN modes + <span class="since">Since 1.1.0.</span> This is done with the + optional <code>nativeMode</code> attribute on + the <code><tag></code> subelement: <code>nativeMode</code> + may be set to 'tagged' or 'untagged'. The <code>id</code> + attribute of the <code><tag></code> subelement + containing <code>nativeMode</code> sets which VLAN is considered + to be the "native" VLAN for this interface, and + the <code>nativeMode</code> attribute determines whether or not + traffic for that VLAN will be tagged. </p> <h5><a name="elementLink">Modifying virtual link state</a></h5> diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c index 0044ee5..8981d9a 100644 --- a/src/lxc/lxc_process.c +++ b/src/lxc/lxc_process.c @@ -1,5 +1,5 @@ /* - * Copyright (C) 2010-2015 Red Hat, Inc. + * Copyright (C) 2010-2016 Red Hat, Inc. * Copyright IBM Corp. 2008 * * lxc_process.c: LXC process lifecycle management @@ -343,6 +343,7 @@ char *virLXCProcessSetupInterfaceDirect(virConnectPtr conn, net->ifname, &net->mac, linkdev, virDomainNetGetActualDirectMode(net), + virDomainNetGetActualVlan(net), def->uuid, prof, &res_ifname, diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index a34da2a..7a2cadb 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -3058,11 +3058,12 @@ networkValidate(virNetworkDriverStatePtr driver, * a pool, and those using an Open vSwitch bridge. */ - vlanAllowed = ((def->forward.type == VIR_NETWORK_FORWARD_BRIDGE && + vlanAllowed = (def->forward.type == VIR_NETWORK_FORWARD_HOSTDEV || + def->forward.type == VIR_NETWORK_FORWARD_PASSTHROUGH || + (def->forward.type == VIR_NETWORK_FORWARD_BRIDGE && def->virtPortProfile && def->virtPortProfile->virtPortType - == VIR_NETDEV_VPORT_PROFILE_OPENVSWITCH) || - def->forward.type == VIR_NETWORK_FORWARD_HOSTDEV); + == VIR_NETDEV_VPORT_PROFILE_OPENVSWITCH)); vlanUsed = def->vlan.nTags > 0; for (i = 0; i < def->nPortGroups; i++) { @@ -4277,11 +4278,15 @@ networkAllocateActualDevice(virDomainDefPtr dom, */ if (virDomainNetGetActualVlan(iface)) { - /* vlan configuration via libvirt is only supported for - * PCI Passthrough SR-IOV devices and openvswitch bridges. - * otherwise log an error and fail + /* vlan configuration via libvirt is only supported for PCI + * Passthrough SR-IOV devices (hostdev or macvtap passthru + * mode) and openvswitch bridges. Otherwise log an error and + * fail */ if (!(actualType == VIR_DOMAIN_NET_TYPE_HOSTDEV || + (actualType == VIR_DOMAIN_NET_TYPE_DIRECT && + virDomainNetGetActualDirectMode(iface) + == VIR_NETDEV_MACVLAN_MODE_PASSTHRU) || (actualType == VIR_DOMAIN_NET_TYPE_BRIDGE && virtport && virtport->virtPortType == VIR_NETDEV_VPORT_PROFILE_OPENVSWITCH))) { diff --git a/src/qemu/qemu_interface.c b/src/qemu/qemu_interface.c index ef789fa..b48ae50 100644 --- a/src/qemu/qemu_interface.c +++ b/src/qemu/qemu_interface.c @@ -266,6 +266,7 @@ qemuInterfaceDirectConnect(virDomainDefPtr def, &net->mac, virDomainNetGetActualDirectDev(net), virDomainNetGetActualDirectMode(net), + virDomainNetGetActualVlan(net), def->uuid, virDomainNetGetActualVirtPortProfile(net), &res_ifname, diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c index 933c942..980e590 100644 --- a/src/util/virhostdev.c +++ b/src/util/virhostdev.c @@ -1,6 +1,6 @@ /* virhostdev.c: hostdev management * - * Copyright (C) 2006-2007, 2009-2015 Red Hat, Inc. + * Copyright (C) 2006-2007, 2009-2016 Red Hat, Inc. * Copyright (C) 2006 Daniel P. Berrange * Copyright (C) 2014 SUSE LINUX Products GmbH, Nuernberg, Germany. * @@ -387,7 +387,6 @@ virHostdevNetConfigReplace(virDomainHostdevDefPtr hostdev, virNetDevVPortProfilePtr virtPort; int ret = -1; int vf = -1; - int vlanid = -1; bool port_profile_associate = true; if (virHostdevIsVirtualFunction(hostdev) != 1) { @@ -416,27 +415,9 @@ virHostdevNetConfigReplace(virDomainHostdevDefPtr hostdev, port_profile_associate); } else { /* Set only mac and vlan */ - if (vlan) { - if (vlan->nTags != 1 || vlan->trunk) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("vlan trunking is not supported " - "by SR-IOV network devices")); - goto cleanup; - } - if (vf == -1) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("vlan can only be set for SR-IOV VFs, but " - "%s is not a VF"), linkdev); - goto cleanup; - } - vlanid = vlan->tag[0]; - } else if (vf >= 0) { - vlanid = 0; /* assure any current vlan tag is reset */ - } - ret = virNetDevReplaceNetConfig(linkdev, vf, &hostdev->parent.data.net->mac, - vlanid, stateDir); + vlan, stateDir); } cleanup: VIR_FREE(linkdev); diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index bb17b84..7db4497 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -1,5 +1,5 @@ /* - * Copyright (C) 2007-2015 Red Hat, Inc. + * Copyright (C) 2007-2016 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -2547,7 +2547,8 @@ virNetDevRestoreVfConfig(const char *pflinkdev, */ int virNetDevReplaceNetConfig(const char *linkdev, int vf, - const virMacAddr *macaddress, int vlanid, + const virMacAddr *macaddress, + virNetDevVlanPtr vlan, const char *stateDir) { int ret = -1; @@ -2566,11 +2567,29 @@ virNetDevReplaceNetConfig(const char *linkdev, int vf, linkdev = pfdevname; } - if (vf == -1) + if (vf == -1) { + if (vlan) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("vlan can only be set for SR-IOV VFs, but " + "%s is not a VF"), linkdev); + goto cleanup; + } ret = virNetDevReplaceMacAddress(linkdev, macaddress, stateDir); - else + } else { + int vlanid = 0; /* assure any current vlan tag is reset */ + + if (vlan) { + if (vlan->nTags != 1 || vlan->trunk) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("vlan trunking is not supported " + "by SR-IOV network devices")); + goto cleanup; + } + vlanid = vlan->tag[0]; + } ret = virNetDevReplaceVfConfig(linkdev, vf, macaddress, vlanid, stateDir); + } cleanup: VIR_FREE(pfdevname); @@ -2636,7 +2655,7 @@ int virNetDevReplaceNetConfig(const char *linkdev ATTRIBUTE_UNUSED, int vf ATTRIBUTE_UNUSED, const virMacAddr *macaddress ATTRIBUTE_UNUSED, - int vlanid ATTRIBUTE_UNUSED, + virNetDevVlanPtr vlan ATTRIBUTE_UNUSED, const char *stateDir ATTRIBUTE_UNUSED) { virReportSystemError(ENOSYS, "%s", diff --git a/src/util/virnetdev.h b/src/util/virnetdev.h index dcc81a6..cbe7938 100644 --- a/src/util/virnetdev.h +++ b/src/util/virnetdev.h @@ -1,5 +1,5 @@ /* - * Copyright (C) 2007-2015 Red Hat, Inc. + * Copyright (C) 2007-2016 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -30,6 +30,7 @@ # include "virnetlink.h" # include "virmacaddr.h" # include "virpci.h" +# include "virnetdevvlan.h" # include "device_conf.h" # ifdef HAVE_STRUCT_IFREQ @@ -175,7 +176,8 @@ int virNetDevLinkDump(const char *ifname, int ifindex, ATTRIBUTE_RETURN_CHECK; int virNetDevReplaceNetConfig(const char *linkdev, int vf, - const virMacAddr *macaddress, int vlanid, + const virMacAddr *macaddress, + virNetDevVlanPtr vlan, const char *stateDir) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(5); diff --git a/src/util/virnetdevmacvlan.c b/src/util/virnetdevmacvlan.c index d755b93..c05c67f 100644 --- a/src/util/virnetdevmacvlan.c +++ b/src/util/virnetdevmacvlan.c @@ -975,6 +975,7 @@ virNetDevMacVLanCreateWithVPortProfile(const char *ifnameRequested, const virMacAddr *macaddress, const char *linkdev, virNetDevMacVLanMode mode, + virNetDevVlanPtr vlan, const unsigned char *vmuuid, virNetDevVPortProfilePtr virtPortProfile, char **ifnameResult, @@ -1021,7 +1022,7 @@ virNetDevMacVLanCreateWithVPortProfile(const char *ifnameRequested, if (virNetDevReplaceMacAddress(linkdev, macaddress, stateDir) < 0) return -1; } else { - if (virNetDevReplaceNetConfig(linkdev, -1, macaddress, -1, stateDir) < 0) + if (virNetDevReplaceNetConfig(linkdev, -1, macaddress, vlan, stateDir) < 0) return -1; } } @@ -1281,6 +1282,7 @@ int virNetDevMacVLanCreateWithVPortProfile(const char *ifname ATTRIBUTE_UNUSED, const virMacAddr *macaddress ATTRIBUTE_UNUSED, const char *linkdev ATTRIBUTE_UNUSED, virNetDevMacVLanMode mode ATTRIBUTE_UNUSED, + virNetDevVlanPtr vlan ATTRIBUTE_UNUSED, const unsigned char *vmuuid ATTRIBUTE_UNUSED, virNetDevVPortProfilePtr virtPortProfile ATTRIBUTE_UNUSED, char **res_ifname ATTRIBUTE_UNUSED, diff --git a/src/util/virnetdevmacvlan.h b/src/util/virnetdevmacvlan.h index 560593e..179a8a1 100644 --- a/src/util/virnetdevmacvlan.h +++ b/src/util/virnetdevmacvlan.h @@ -28,6 +28,7 @@ # include "virsocketaddr.h" # include "virnetdevbandwidth.h" # include "virnetdevvportprofile.h" +# include "virnetdevvlan.h" /* the mode type for macvtap devices */ typedef enum { @@ -69,6 +70,7 @@ int virNetDevMacVLanCreateWithVPortProfile(const char *ifname, const virMacAddr *macaddress, const char *linkdev, virNetDevMacVLanMode mode, + virNetDevVlanPtr vlan, const unsigned char *vmuuid, virNetDevVPortProfilePtr virtPortProfile, char **res_ifname, -- 2.5.5

2 2

[libvirt] [PATCH 0/8] disk device="lun" related fixes
by Peter Krempa 10 May '16

10 May '16

Fix a few invalid error messages, remove code that would make certain configs vanish and reject block copy to a regular file. Peter Krempa (8): util: Replace virDomainDiskSourceIsBlockType with a new helper lxc: Fix wrong error message on disk hotplug qemu: Support <disk device='lun'> for iSCSI direct mapped volumes qemu: command: Use more appropriate checking function for block devices conf: Kill now unused virDomainDiskSourceIsBlockType qemu: command: Remove unnecessary label in qemuCheckDiskConfig qemu: Reject invalid block copy targets for <disk device='lun'> Revert "conf: Validate disk lun using correct types" src/conf/domain_conf.c | 74 ----------------------------------------------- src/conf/domain_conf.h | 3 -- src/libvirt_private.syms | 2 +- src/lxc/lxc_cgroup.c | 3 +- src/lxc/lxc_driver.c | 9 ++++-- src/qemu/qemu_command.c | 29 +++++++------------ src/qemu/qemu_conf.c | 10 +++++-- src/qemu/qemu_domain.c | 31 ++++++++++++++++++++ src/qemu/qemu_domain.h | 3 ++ src/qemu/qemu_driver.c | 4 +++ src/util/virstoragefile.c | 16 +++++++++- src/util/virstoragefile.h | 3 +- tests/qemuxml2argvtest.c | 3 +- 13 files changed, 82 insertions(+), 108 deletions(-) -- 2.8.1

4 25

[libvirt] [PATCH 0/7] Introduce APIs to get/set client processing controls
by Erik Skultety 10 May '16

10 May '16

- APIs enable retrieval of values for maximum number of clients allowed to be connected, maximum number of clients allowed to wait for authentication, as well as current (dynamic) values for both cases; expectedly, setter only allows to set the limits available through libvirtd.conf - until patch "makefile: Move include/Makefile.am to include/libvirt/Makefile.am" is reviewed an pushed, config.status must be run after after 1/7 for a successful build. Erik Skultety (7): libvirt-host: Move virTypedParam* to libvirt-common admin: Enable usage of typed parameters virnetserver: Introduce client processing controls getters admin: Introduce some public constants related to client processing controls admin: Introduce virAdmServerGetClientProcessingControls admin: Introduce virAdmServerSetClientProcessingControls virt-admin: Introduce commands srv-clients-info and srv-clients-set cfg.mk | 2 +- daemon/admin.c | 85 ++++++++++++++++ daemon/admin_server.c | 77 +++++++++++++++ daemon/admin_server.h | 10 ++ include/libvirt/libvirt-admin.h | 52 ++++++++++ include/libvirt/libvirt-common.h.in | 185 +++++++++++++++++++++++++++++++++++ include/libvirt/libvirt-host.h | 186 ------------------------------------ src/admin/admin_protocol.x | 54 ++++++++++- src/admin/admin_remote.c | 81 ++++++++++++++++ src/admin_protocol-structs | 45 +++++++++ src/libvirt-admin.c | 89 +++++++++++++++++ src/libvirt_admin_private.syms | 3 + src/libvirt_admin_public.syms | 2 + src/rpc/virnetserver.c | 82 ++++++++++++++++ src/rpc/virnetserver.h | 9 ++ tools/virt-admin.c | 182 +++++++++++++++++++++++++++++++++++ 16 files changed, 956 insertions(+), 188 deletions(-) -- 2.4.11

2 9

[libvirt] [PATCH REPOST 0/2] Admin API: Add support for client disconnect
by Erik Skultety 10 May '16

10 May '16

Rebased version of https://www.redhat.com/archives/libvir-list/2016-April/msg01987.html onto current HEAD to resolve some rebase conflicts. The original patch 1/3 was dropped, since it has already been merged with client-info series: https://www.redhat.com/archives/libvir-list/2016-April/msg01979.html, so Erik Skultety (2): admin: Introduce virAdmClientClose API virt-admin: Introduce client-disconnect command daemon/admin.c | 6 ++++ daemon/admin_server.c | 9 +++++ daemon/admin_server.h | 3 ++ include/libvirt/libvirt-admin.h | 2 ++ src/admin/admin_protocol.x | 12 ++++++- src/admin_protocol-structs | 5 +++ src/libvirt-admin.c | 30 +++++++++++++++++ src/libvirt_admin_private.syms | 1 + src/libvirt_admin_public.syms | 1 + tools/virt-admin.c | 73 +++++++++++++++++++++++++++++++++++++++++ tools/virt-admin.pod | 5 +++ 11 files changed, 146 insertions(+), 1 deletion(-) -- 2.4.11

3 9

[libvirt] [PATCH 0/2] Some trivial admin fixes
by Erik Skultety 10 May '16

10 May '16

Flags checking should be done solely on the daemon side and therefore such checks need to be removed from public APIs. Erik Skultety (2): admin: Remove flags checking from public API entry points admin: Remove flags checking from virAdmConnectOpen public API src/admin/admin_remote.c | 2 +- src/libvirt-admin.c | 9 ++------- 2 files changed, 3 insertions(+), 8 deletions(-) -- 2.4.11

3 7

[libvirt] [PATCH] storage: Fix regression cloning volume into a logical pool
by John Ferlan 10 May '16

10 May '16

https://bugzilla.redhat.com/show_bug.cgi?id=1318993 Commit id 'dd519a294' caused a regression cloning a volume into a logical pool by removing just the 'allocation' adjustment during storageVolCreateXMLFrom. Combined with the change to not require the new volume input XML to have a capacity listed (commit id 'e3f1d2a8') left the possibility that a copy from a larger volume into a smaller volume would create a thin/sparse logical volume. If a thin lv becomes fully populated, then LVM will set the partition 'inactive' and the subsequent fdatasync() would fail. In order to fix this in a backend agnostic manner, only adjust the new capacity if not provided. Likewise, if the new allocation is not provided, then use the capacity value as we document that if omitted, the volume will be fully allocated at time of creation. For a logical backend, that creation time is 'createVol', while for a file backend, creation doesn't set the size, but the 'createRaw' called during buildVolFrom will decide whether the file is sparse or not based on the provided capacity and allocation value. For volume clones that provide different allocation and capacity values to allow for sparse files, there is no change. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- NOTE: Related bz's to previous changes: https://bugzilla.redhat.com/show_bug.cgi?id=1130739 https://bugzilla.redhat.com/show_bug.cgi?id=1298065 I have tested using 'virsh vol-clone' and 'virt-clone' with and without this patch applied. Both tests have the same results for the 'qemu-img info' on the cloned file. src/storage/storage_driver.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index fcc0991..4415a4c 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -2034,11 +2034,22 @@ storageVolCreateXMLFrom(virStoragePoolPtr obj, goto cleanup; } - /* Use the original volume's capacity in case the new capacity - * is less than that, or it was omitted */ - if (newvol->target.capacity < origvol->target.capacity) + /* Use the original volume's capacity if the new capacity was omitted. + * If the provided newvol capacity is less than original, we cannot just + * use the original since the subsequent createVol has "competing needs" + * for backends. A logical volume backend could then create a thin lv + * that has different characteristics when copying from the original + * volume than perhaps a raw disk file. */ + if (newvol->target.capacity == 0) newvol->target.capacity = origvol->target.capacity; + /* If the new allocation is 0, then use capacity as it's specifically + * documented "If omitted when creating a volume, the volume will be + * fully allocated at time of creation.". This is especially important + * for logical volume creation. */ + if (newvol->target.allocation == 0) + newvol->target.allocation = newvol->target.capacity; + if (!backend->buildVolFrom) { virReportError(VIR_ERR_NO_SUPPORT, "%s", _("storage pool does not support" -- 2.5.5

3 5

[libvirt] [PATCH 0/4] some graphics cleanups and improvements
by Pavel Hrdina 10 May '16

10 May '16

Pavel Hrdina (4): qemu_process: separate graphics port reservation graphics: generate fake ports also for tests qemu_process: merge graphics code into qemuProcessSetupGraphics qemu_hotplug: fix checking graphics ports src/qemu/qemu_driver.c | 12 --- src/qemu/qemu_hotplug.c | 13 ++-- src/qemu/qemu_process.c | 86 +++++++++++----------- src/qemu/qemu_process.h | 8 -- .../qemuhotplug-graphics-spice-listen-network.xml | 2 +- .../qemuxml2argv-controller-order.args | 2 +- .../qemuxml2argv-hugepages-numa.args | 2 +- .../qemuxml2argv-video-device-pciaddr-default.args | 2 +- 8 files changed, 51 insertions(+), 76 deletions(-) -- 2.8.2

2 9

[libvirt] [PATCH v2 0/2] uml: only build on Linux
by Roman Bogorodskiy 10 May '16

10 May '16

Changes since v1: - Add forgotten with_libvirtd check and unite it with the with_linux check - Minor code formatting fixes in m4/virt-driver-uml.m4 Roman Bogorodskiy (2): configure: split out UML driver checks uml: only build on Linux configure.ac | 28 ++------------------------ m4/virt-driver-uml.m4 | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 57 insertions(+), 26 deletions(-) create mode 100644 m4/virt-driver-uml.m4 -- 2.7.4

2 4

[libvirt] [PATCH] conf: don't redefine virDomainCapsDeviceHostdev
by Roman Bogorodskiy 10 May '16

10 May '16

Commit 5ed235c6 added unnecessary redifinition of virDomainCapsDeviceHostdev in conf/domain_capabilities.h. This breaks build with clang 3.4: In file included from conf/domain_capabilities.c:25: conf/domain_capabilities.h:88:44: error: redefinition of typedef 'virDomainCapsDeviceHostdev' is a C11 feature [-Werror,-Wtypedef-redefinition] typedef struct _virDomainCapsDeviceHostdev virDomainCapsDeviceHostdev; ^ conf/domain_capabilities.h:86:44: note: previous definition is here typedef struct _virDomainCapsDeviceHostdev virDomainCapsDeviceHostdev; So drop one of those. Pushed under the build breaker fix rule. --- src/conf/domain_capabilities.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/conf/domain_capabilities.h b/src/conf/domain_capabilities.h index d0ca009..492a9cf 100644 --- a/src/conf/domain_capabilities.h +++ b/src/conf/domain_capabilities.h @@ -84,8 +84,6 @@ struct _virDomainCapsDeviceVideo { }; typedef struct _virDomainCapsDeviceHostdev virDomainCapsDeviceHostdev; - -typedef struct _virDomainCapsDeviceHostdev virDomainCapsDeviceHostdev; typedef virDomainCapsDeviceHostdev *virDomainCapsDeviceHostdevPtr; struct _virDomainCapsDeviceHostdev { bool supported; -- 2.7.4

1 0

[libvirt] (no subject)
by Lovely K. 10 May '16

10 May '16

plz added me ...i need a some application for development

2 1

[libvirt] [PATCHv2] virsh: blkdeviotune: accept human readable values for bytes
by Nishith Shah 10 May '16

10 May '16

Use vshCommandOptScaledInt instead of vshCommandOptULongLong so that values with suffixes can be passed when bytes are being passed along. Values for the iops parameters still need to be given in the absolute form as they are not bytes but numbers. Please refer to the bug link https://bugzilla.redhat.com/show_bug.cgi?id=885380 which can be closed. Signed-off-by: Nishith Shah <nishithshah.2211(a)gmail.com> --- tools/virsh-domain.c | 24 ++++++++++++------------ tools/virsh.pod | 18 ++++++++++++------ 2 files changed, 24 insertions(+), 18 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 0a6caae..336a65f 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -1164,7 +1164,7 @@ static const vshCmdOptDef opts_blkdeviotune[] = { }, {.name = "total-bytes-sec", .type = VSH_OT_INT, - .help = N_("total throughput limit in bytes per second") + .help = N_("total throughput limit, as scaled integer (default bytes)") }, {.name = "read_bytes_sec", .type = VSH_OT_ALIAS, @@ -1172,7 +1172,7 @@ static const vshCmdOptDef opts_blkdeviotune[] = { }, {.name = "read-bytes-sec", .type = VSH_OT_INT, - .help = N_("read throughput limit in bytes per second") + .help = N_("read throughput limit, as scaled integer (default bytes)") }, {.name = "write_bytes_sec", .type = VSH_OT_ALIAS, @@ -1180,7 +1180,7 @@ static const vshCmdOptDef opts_blkdeviotune[] = { }, {.name = "write-bytes-sec", .type = VSH_OT_INT, - .help = N_("write throughput limit in bytes per second") + .help = N_("write throughput limit, as scaled integer (default bytes)") }, {.name = "total_iops_sec", .type = VSH_OT_ALIAS, @@ -1212,7 +1212,7 @@ static const vshCmdOptDef opts_blkdeviotune[] = { }, {.name = "total-bytes-sec-max", .type = VSH_OT_INT, - .help = N_("total max in bytes") + .help = N_("total max, as scaled integer (default bytes)") }, {.name = "read_bytes_sec_max", .type = VSH_OT_ALIAS, @@ -1220,7 +1220,7 @@ static const vshCmdOptDef opts_blkdeviotune[] = { }, {.name = "read-bytes-sec-max", .type = VSH_OT_INT, - .help = N_("read max in bytes") + .help = N_("read max, as scaled integer (default bytes)") }, {.name = "write_bytes_sec_max", .type = VSH_OT_ALIAS, @@ -1228,7 +1228,7 @@ static const vshCmdOptDef opts_blkdeviotune[] = { }, {.name = "write-bytes-sec-max", .type = VSH_OT_INT, - .help = N_("write max in bytes") + .help = N_("write max, as scaled integer (default bytes)") }, {.name = "total_iops_sec_max", .type = VSH_OT_ALIAS, @@ -1299,7 +1299,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) if (vshCommandOptStringReq(ctl, cmd, "device", &disk) < 0) goto cleanup; - if ((rv = vshCommandOptULongLong(ctl, cmd, "total-bytes-sec", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "total-bytes-sec", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1308,7 +1308,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "read-bytes-sec", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "read-bytes-sec", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1317,7 +1317,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "write-bytes-sec", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "write-bytes-sec", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1326,7 +1326,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "total-bytes-sec-max", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "total-bytes-sec-max", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1335,7 +1335,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "read-bytes-sec-max", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "read-bytes-sec-max", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1344,7 +1344,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "write-bytes-sec-max", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "write-bytes-sec-max", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, diff --git a/tools/virsh.pod b/tools/virsh.pod index 2a95df7..6844823 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -1097,15 +1097,21 @@ I<domain> (see also B<domblklist> for listing these names). If no limit is specified, it will query current I/O limits setting. Otherwise, alter the limits with these flags: -I<--total-bytes-sec> specifies total throughput limit in bytes per second. -I<--read-bytes-sec> specifies read throughput limit in bytes per second. -I<--write-bytes-sec> specifies write throughput limit in bytes per second. +I<--total-bytes-sec> specifies total throughput limit as a scaled integer, the +default being bytes per second if no suffix is specified. +I<--read-bytes-sec> specifies read throughput limit as a scaled integer, the +default being bytes per second if no suffix is specified. +I<--write-bytes-sec> specifies write throughput limit as a scaled integer, the +default being bytes per second if no suffix is specified. I<--total-iops-sec> specifies total I/O operations limit per second. I<--read-iops-sec> specifies read I/O operations limit per second. I<--write-iops-sec> specifies write I/O operations limit per second. -I<--total-bytes-sec-max> specifies maximum total throughput limit in bytes per second. -I<--read-bytes-sec-max> specifies maximum read throughput limit in bytes per second. -I<--write-bytes-sec-max> specifies maximum write throughput limit in bytes per second. +I<--total-bytes-sec-max> specifies maximum total throughput limit as a scaled +integer, the default being bytes per second if no suffix is specified +I<--read-bytes-sec-max> specifies maximum read throughput limit as a scaled +integer, the default being bytes per second if no suffix is specified. +I<--write-bytes-sec-max> specifies maximum write throughput limit as a scaled +integer, the default being bytes per second if no suffix is specified. I<--total-iops-sec-max> specifies maximum total I/O operations limit per second. I<--read-iops-sec-max> specifies maximum read I/O operations limit per second. I<--write-iops-sec-max> specifies maximum write I/O operations limit per second. -- 2.1.4

2 2

[libvirt] [PATCH] qemu: add default pci-root device to mips*/malta guests
by Aurelien Jarno 09 May '16

09 May '16

The MIPS Malta board has a root PCI controller. It is not sent during migration, so it needs to be added by default. Signed-off-by: Aurelien Jarno <aurelien(a)aurel32.net> --- src/qemu/qemu_domain.c | 15 ++++++++++++++- src/qemu/qemu_domain.h | 1 + 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 173f82c..75b0545 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -1763,6 +1763,14 @@ qemuDomainDefAddDefaultDevices(virDomainDefPtr def, addPCIeRoot = virQEMUCapsGet(qemuCaps, QEMU_CAPS_OBJECT_GPEX); break; + case VIR_ARCH_MIPS: + case VIR_ARCH_MIPSEL: + case VIR_ARCH_MIPS64: + case VIR_ARCH_MIPS64EL: + if (qemuDomainMachineIsMalta(def)) + addPCIRoot = true; + break; + case VIR_ARCH_PPC64: case VIR_ARCH_PPC64LE: addPCIRoot = true; @@ -4654,6 +4662,11 @@ qemuDomainMachineIsVirt(const virDomainDef *def) STRPREFIX(def->os.machine, "virt-"); } +bool +qemuDomainMachineIsMalta(const virDomainDef *def) +{ + return STRPREFIX(def->os.machine, "malta"); +} static bool qemuCheckMemoryDimmConflict(const virDomainDef *def, @@ -4830,7 +4843,7 @@ bool qemuDomainMachineHasBuiltinIDE(const virDomainDef *def) { return qemuDomainMachineIsI440FX(def) || - STREQ(def->os.machine, "malta") || + qemuDomainMachineIsMalta(def) || STREQ(def->os.machine, "sun4u") || STREQ(def->os.machine, "g3beige"); } diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index 95f821c..adba5fa 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -585,6 +585,7 @@ bool qemuDomainMachineIsI440FX(const virDomainDef *def); bool qemuDomainMachineNeedsFDC(const virDomainDef *def); bool qemuDomainMachineIsS390CCW(const virDomainDef *def); bool qemuDomainMachineIsVirt(const virDomainDef *def); +bool qemuDomainMachineIsMalta(const virDomainDef *def); bool qemuDomainMachineHasBuiltinIDE(const virDomainDef *def); int qemuDomainUpdateCurrentMemorySize(virQEMUDriverPtr driver, -- 2.8.1

2 3

[libvirt] Introducing myself (GSoC 2016 student)
by Katerina Koukiou 09 May '16

09 May '16

Hi, my name is Katerina Koukiou and I got selected as a GSoC student this year to work on libvirt. My project is to add libvirt support for migration of lxc containers using a tool called CRIU. For the time, I am in my final year of undergraduate studies in Electrical and Computer Engineering, at NTUA university, Greece. Looking forward to share some patches here! Katerina

2 1

[libvirt] [PATCH 00/27] Introduce sparse streams
by Michal Privoznik 09 May '16

09 May '16

So, after couple of sleepless nights and headaches I'm proud to announce that finally got this working. What? Our regular streams that are can be used to transfer disk images for domains are unaware of any sparseness. Therefore they have two limitations: a) transferring big but sparse image can take ages as all the holes (interpreted by kernel as '\0') have to go through our event loop. b) resulting volume is not sparse even if the source was. How? I went by verified approach that linux kernel has. One way to look at our streams is just like read() and write() with a different names: virStreamRecv() and virStreamSend(). They even have the same prototype (if 'int fd' is substituted with 'virStreamPtr'). Now, holes in files are created and detected via third API: lseek(). Therefore I'm introducing new virStreamSkip() API that mimics the missing primitive. Now, because our streams do not necessarily have to work over files (they are for generic data transfer), I had to let users register a callback that is called whenever the other side calls virStreamSkip(). So now that we have all three primitives, we can focus on making life easier for our users. Nobody is actually using bare virStreamSend() and virStreamRecv() rather than our wrappers: virStreamSendAll() and virStreamRecvAll(). With my approach described above just virStreamSendAll() needs to be adjusted so that it's 'sparse file' aware. The virStreamRecvAll() will only get the data to write (just like it is now) with skip callback called automatically whenever needed. In order for virStreamSendAll() to skip holes I'm introducing yet another callback: virStreamInDataFunc(). This callback will help us to create a map of a file: before each virStreamSend() it checks whether we are in a data section or a hole and calls virStreamSend() or virStreamSkip() respectively. Do not worry - it will all become clear once you see the code. Now question is - how will users enable this feature? I mean, we have take into account that we might be talking to an older daemon that does not know how to skip a hole. Or vice versa - older client. The solution I came up with is to introduce flags to APIs where sparse streams make sense. I guess it makes sense for volume upload and download, but almost certainly makes no sense for virDomainOpenConsole(). Code? >From users POV they just need to pass correct argument to 'vol-upload' or 'vol-download' virsh commands. One layer down, on programming level they need to merely: st = virStreamNew(conn, 0); virStreamRegisterSkip(st, skipFunc, &fd); virStorageVolDownload(st, ...); virStreamRecvAll(st, sinkFunc, &fd); where: int skipFunc(virStreamPtr st, unsigned long long offset, void *opaque) { int *fd = opaque; return lseek(*fd, offset, SEEK_CUR) == (off_t) -1 ? -1 : 0; } And for uploading it's slightly more verbose - see patch 24. Limitations? While testing this on my machine with XFS, I've noticed that the resulting map of a transferred file is not exactly the same as the source's. Checksums are the same though. After digging deeper I found this commit in the kernel: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=0… Thing is, as we transfer the file, we are practically just seeking at EOF and thus creating holes. But if the hole size is small enough, XFS will use some speculative file allocation algorithm and eventually fully allocate the blocks even if we intended to create a hole. This does not occur when punching a hole into a file though. Well, I guess XFS devels have some reasons to do that. This behaviour has not been observed on EXT4. Notes? Oh, patches 01-03 have been ACKed already, but are not pushed yet because of the freeze. But since this feature build on the top of them, I'm sending them too. Also the whole patch set is accessible at my github: https://github.com/zippy2/libvirt/tree/sparse_streams4 Michal Privoznik (27): Revert "rpc: Fix slow volume download (virsh vol-download)" virnetclientstream: Process stream messages later virStream{Recv,Send}All: Increase client buffer Introduce virStreamSkip Introduce virStreamRegisterSkip and virStreamSkipCallback Introduce virStreamInData and virStreamRegisterInData virNetClientStreamNew: Track origin stream Track if stream is seekable RPC: Introduce virNetStreamSkip Introduce VIR_NET_STREAM_SKIP message type Teach wireshark plugin about VIR_NET_STREAM_SKIP daemon: Implement VIR_NET_STREAM_SKIP handling daemon: Introduce virNetServerProgramSendStreamSkip virnetclientstream: Introduce virNetClientStreamSendSkip virnetclientstream: Introduce virNetClientStreamHandleSkip remote_driver: Implement virStreamSkip daemonStreamHandleRead: Wire up seekable stream virNetClientStream: Wire up VIR_NET_STREAM_SKIP virStreamSendAll: Wire up sparse streams fdstream: Implement seek gendispatch: Introduce @sparseflag for our calls Introduce virStorageVol{Download,Upload}Flags virsh: Implement sparse stream to vol-download virsh: Implement sparse stream to vol-upload fdstream: Suppress use of IO helper for sparse streams daemon: Don't call virStreamInData so often storage: Enable sparse streams for virStorageVol{Download,Upload} daemon/remote.c | 2 +- daemon/stream.c | 134 +++++++++++++-- daemon/stream.h | 3 +- include/libvirt/libvirt-storage.h | 9 + include/libvirt/libvirt-stream.h | 47 ++++++ src/datatypes.h | 8 + src/driver-stream.h | 5 + src/fdstream.c | 156 +++++++++++++++--- src/fdstream.h | 3 +- src/libvirt-storage.c | 4 +- src/libvirt-stream.c | 238 ++++++++++++++++++++++++++- src/libvirt_internal.h | 7 + src/libvirt_private.syms | 2 + src/libvirt_public.syms | 7 + src/libvirt_remote.syms | 2 + src/remote/remote_driver.c | 41 ++++- src/remote/remote_protocol.x | 2 + src/rpc/gendispatch.pl | 21 ++- src/rpc/virnetclient.c | 1 + src/rpc/virnetclientstream.c | 308 ++++++++++++++++++++++++----------- src/rpc/virnetclientstream.h | 10 +- src/rpc/virnetprotocol.x | 16 +- src/rpc/virnetserverprogram.c | 33 ++++ src/rpc/virnetserverprogram.h | 7 + src/storage/storage_backend.c | 12 +- src/storage/storage_driver.c | 4 +- src/virnetprotocol-structs | 4 + tools/virsh-volume.c | 40 ++++- tools/virsh.c | 79 +++++++++ tools/virsh.h | 12 ++ tools/virsh.pod | 6 +- tools/wireshark/src/packet-libvirt.c | 40 +++++ tools/wireshark/src/packet-libvirt.h | 2 + 33 files changed, 1104 insertions(+), 161 deletions(-) -- 2.8.1

4 45

[libvirt] [PATCH] util: polkit: Fix polkit agent startup
by Peter Krempa 09 May '16

09 May '16

Commit 0b36b0e9 broke polkit agent startup when attempting to fix a coverity warning. Refactor it properly so that we don't need the 'cmd' intermediate variable. --- src/util/virpolkit.c | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/src/util/virpolkit.c b/src/util/virpolkit.c index 2038744..e7e46b8 100644 --- a/src/util/virpolkit.c +++ b/src/util/virpolkit.c @@ -167,7 +167,6 @@ virPolkitAgentPtr virPolkitAgentCreate(void) { virPolkitAgentPtr agent = NULL; - virCommandPtr cmd = virCommandNewArgList(PKTTYAGENT, "--process", NULL); int pipe_fd[2] = {-1, -1}; struct pollfd pollfd; int outfd = STDOUT_FILENO; @@ -181,18 +180,18 @@ virPolkitAgentCreate(void) if (VIR_ALLOC(agent) < 0) goto error; - agent->cmd = cmd; - cmd = NULL; - - virCommandAddArgFormat(cmd, "%lld", (long long int) getpid()); - virCommandAddArg(cmd, "--notify-fd"); - virCommandAddArgFormat(cmd, "%d", pipe_fd[1]); - virCommandAddArg(cmd, "--fallback"); - virCommandSetInputFD(cmd, STDIN_FILENO); - virCommandSetOutputFD(cmd, &outfd); - virCommandSetErrorFD(cmd, &errfd); - virCommandPassFD(cmd, pipe_fd[1], VIR_COMMAND_PASS_FD_CLOSE_PARENT); - if (virCommandRunAsync(cmd, NULL) < 0) + + agent->cmd = virCommandNewArgList(PKTTYAGENT, "--process", NULL); + + virCommandAddArgFormat(agent->cmd, "%lld", (long long int) getpid()); + virCommandAddArg(agent->cmd, "--notify-fd"); + virCommandAddArgFormat(agent->cmd, "%d", pipe_fd[1]); + virCommandAddArg(agent->cmd, "--fallback"); + virCommandSetInputFD(agent->cmd, STDIN_FILENO); + virCommandSetOutputFD(agent->cmd, &outfd); + virCommandSetErrorFD(agent->cmd, &errfd); + virCommandPassFD(agent->cmd, pipe_fd[1], VIR_COMMAND_PASS_FD_CLOSE_PARENT); + if (virCommandRunAsync(agent->cmd, NULL) < 0) goto error; pollfd.fd = pipe_fd[0]; @@ -207,7 +206,6 @@ virPolkitAgentCreate(void) VIR_FORCE_CLOSE(pipe_fd[0]); VIR_FORCE_CLOSE(pipe_fd[1]); virPolkitAgentDestroy(agent); - virCommandFree(cmd); return NULL; } -- 2.8.2

2 1

[libvirt] [PATCH v2 0/8] Add support for fetching statistics of completed jobs
by Jiri Denemark 09 May '16

09 May '16

Using virDomainGetJobStats, we can monitor running jobs but sometimes it may be useful to get statistics about a job that already finished, for example, to get the final amount of data transferred during migration or to get an idea about total downtime. This is what the following patches are about. Version 2: - changed according to John's review (see individual patches for details) Jiri Denemark (8): Refactor job statistics qemu: Avoid incrementing jobs_queued if virTimeMillisNow fails Add support for fetching statistics of completed jobs qemu: Silence coverity on optional migration stats virsh: Add support for completed job stats qemu: Transfer migration statistics to destination qemu: Recompute downtime and total time when migration completes qemu: Transfer recomputed stats back to source include/libvirt/libvirt.h.in | 11 ++ src/libvirt.c | 11 +- src/qemu/qemu_domain.c | 189 ++++++++++++++++++++++++++- src/qemu/qemu_domain.h | 32 ++++- src/qemu/qemu_driver.c | 130 ++++-------------- src/qemu/qemu_migration.c | 304 ++++++++++++++++++++++++++++++++++++------- src/qemu/qemu_monitor_json.c | 10 +- src/qemu/qemu_process.c | 9 +- tools/virsh-domain.c | 27 +++- tools/virsh.pod | 10 +- 10 files changed, 557 insertions(+), 176 deletions(-) -- 2.1.0

3 12

[libvirt] [PATCH 0/4] qemu_monitor_json: Refactor even more
by Michal Privoznik 09 May '16

09 May '16

All these patches will be squashed into one, but I've split them into multiple because of easier review. Michal Privoznik (4): qemu_monitor_json: Follow refactor qemu_monitor_json: Follow refactor qemu_monitor_json: Follow refactor qemu_monitor_json: Follow refactor src/qemu/qemu_monitor_json.c | 673 ++++++++++++++++++++++--------------------- 1 file changed, 349 insertions(+), 324 deletions(-) -- 2.8.1

2 6

[libvirt] [PATCH] qemu: domain: Don't treat unknown storage type as not having backing chain
by Peter Krempa 09 May '16

09 May '16

qemuDomainCheckDiskPresence has short-circuit code to skip the determination of the disk backing chain for storage formats that can't have backing volumes. The code treats VIR_STORAGE_FILE_NONE as not having backing chain and skips the call to qemuDomainDetermineDiskChain. This is wrong as qemuDomainDetermineDiskChain is responsible for storage format detection and has logic to determine the default type if format detection is disabled. This allows to storage passed via <disk type="volume"> to circumvent the enforcement to have correct storage format or that we shall default to format='raw', since we don't set the default type via the post parse callback for "volume" backed disks as the translation code could come up with a better guess. This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1328003 --- src/qemu/qemu_domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index cae356c..78a717a 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -3817,7 +3817,7 @@ qemuDomainCheckDiskPresence(virQEMUDriverPtr driver, * without backing support, the fact that the file exists is * more than enough */ if (virStorageSourceIsLocalStorage(disk->src) && - format >= VIR_STORAGE_FILE_NONE && + format > VIR_STORAGE_FILE_NONE && format < VIR_STORAGE_FILE_BACKING && virFileExists(virDomainDiskGetSource(disk))) continue; -- 2.8.2

2 2

[libvirt] [PATCH] cpu: add ABM to Haswell* and Broadwell* CPU models
by Eli Qiao 09 May '16

09 May '16

Corresponding QEMU commits: becb66673ec30cb604926d247ab9449a60ad8b11 Signed-off-by: Eli Qiao <liyong.qiao(a)intel.com> --- src/cpu/cpu_map.xml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml index 0b6d424..d9eb729 100644 --- a/src/cpu/cpu_map.xml +++ b/src/cpu/cpu_map.xml @@ -919,6 +919,7 @@ <model name='Haswell-noTSX'> <vendor name='Intel'/> + <feature name='abm'/> <feature name='aes'/> <feature name='apic'/> <feature name='avx'/> @@ -971,6 +972,7 @@ <model name='Haswell'> <vendor name='Intel'/> + <feature name='abm'/> <feature name='aes'/> <feature name='apic'/> <feature name='avx'/> @@ -1026,6 +1028,7 @@ <model name='Broadwell-noTSX'> <vendor name='Intel'/> <feature name='3dnowprefetch'/> + <feature name='abm'/> <feature name='adx'/> <feature name='aes'/> <feature name='apic'/> @@ -1082,6 +1085,7 @@ <model name='Broadwell'> <vendor name='Intel'/> <feature name='3dnowprefetch'/> + <feature name='abm'/> <feature name='adx'/> <feature name='aes'/> <feature name='apic'/> -- 1.9.1

3 2

[libvirt] [PATCH 0/3] Couple of patches to resolve recent Coverity issues
by John Ferlan 07 May '16

07 May '16

Recent changes have tripped my Coverity checker. John Ferlan (3): Use virGetLastErrorMessage to avoid Coverity message admin: Clean up error path in adminServerListClients conf: Fix error path in virNodeDevPCICapabilityParseXML daemon/admin_server.c | 3 +-- src/conf/node_device_conf.c | 5 ++++- src/network/bridge_driver.c | 3 +-- src/node_device/node_device_hal.c | 3 +-- 4 files changed, 7 insertions(+), 7 deletions(-) -- 2.5.5

3 9

[libvirt] [PATCH 00/17] improve graphics listen configuration
by Pavel Hrdina 06 May '16

06 May '16

This patch series improves the way how different listen types can be specified and also introduce a new listen types for graphics devices. First improvement is to move ports auto of graphics element into listen element with type address or network. This is a first step to make the code listen-driven. Second step is to create a new listen type socket to improve the current vnc configuration and to print only socket path witout any other listen types. With the new socket type now we can add support also to spice graphics. The last improvement is to introduce new listen type none for spice graphics to specify that the spice graphics shouldn't listen anywhere by default. In case of spice graphics the new listen types socket or none are required to start a guest with OpenGL support. Pavel Hrdina (17): graphics: use enums instead of int qemu_process: move listen code out of qemuProcessSetupGraphics qemu_process: handle port allocation for VNC the same way as for Spice graphics: generate fake ports also for tests qemu_hotplug: cleanup qemuDomainChangeGraphics genericxml2xml: add several graphics tests qemu_hotplug: fix checking graphics ports graphics: don't parse listens if socket attribute is present domain_conf: parse listen attr from graphics while parsing listen elements graphics: make address attribute for listen type='address' optional domain_conf: cleanup virDomainGraphicsListenDefParseXML graphics: move port definition to listen element qemu.conf: remove vnc_auto_unix_socket vnc: use listen type=socket instead of socket attribute qemu_capabilites: add QEMU_CAPS_SPICE_UNIX spice: add support for listen type socket spice: introduce listen type none docs/formatdomain.html.in | 138 +++-- docs/schemas/domaincommon.rng | 63 ++- src/conf/domain_conf.c | 604 ++++++++++++++------- src/conf/domain_conf.h | 45 +- src/libvirt_private.syms | 1 + src/libxl/libxl_conf.c | 61 ++- src/libxl/libxl_domain.c | 17 +- src/qemu/libvirtd_qemu.aug | 1 - src/qemu/qemu.conf | 10 - src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 239 ++++---- src/qemu/qemu_conf.c | 1 - src/qemu/qemu_conf.h | 1 - src/qemu/qemu_domain.c | 19 +- src/qemu/qemu_driver.c | 12 - src/qemu/qemu_hotplug.c | 76 +-- src/qemu/qemu_migration.c | 41 +- src/qemu/qemu_parse_command.c | 41 +- src/qemu/qemu_process.c | 386 ++++++++----- src/qemu/qemu_process.h | 3 + src/qemu/test_libvirtd_qemu.aug.in | 1 - src/security/virt-aa-helper.c | 15 +- src/vbox/vbox_common.c | 30 +- src/vbox/vbox_tmpl.c | 34 +- src/vbox/vbox_uniformed_api.h | 4 +- src/vmx/vmx.c | 54 +- src/vz/vz_sdk.c | 30 +- src/xenconfig/xen_common.c | 74 +-- src/xenconfig/xen_sxpr.c | 71 +-- src/xenconfig/xen_xl.c | 45 +- .../generic-graphics-listen-back-compat-ports.xml | 30 + .../generic-graphics-vnc-listen-attr-only.xml | 28 + ...generic-graphics-vnc-listen-element-minimal.xml | 30 + ...aphics-vnc-listen-element-with-address-port.xml | 30 + ...ic-graphics-vnc-listen-element-with-address.xml | 30 + .../generic-graphics-vnc-manual-port.xml | 28 + .../generic-graphics-vnc-minimal.xml | 28 + .../generic-graphics-vnc-socket-listen.xml | 30 + .../generic-graphics-vnc-socket.xml | 28 + .../generic-graphics-listen-back-compat-ports.xml | 30 + .../generic-graphics-listen-back-compat.xml | 2 +- .../generic-graphics-vnc-listen-attr-only.xml | 30 + ...generic-graphics-vnc-listen-element-minimal.xml | 30 + ...aphics-vnc-listen-element-with-address-port.xml | 30 + ...ic-graphics-vnc-listen-element-with-address.xml | 30 + .../generic-graphics-vnc-manual-port.xml | 30 + .../generic-graphics-vnc-minimal.xml | 30 + .../generic-graphics-vnc-socket-listen.xml | 30 + .../generic-graphics-vnc-socket.xml | 30 + tests/genericxml2xmltest.c | 10 + .../qemuargv2xml-graphics-vnc-policy.xml | 2 +- .../qemuargv2xml-graphics-vnc-sasl.xml | 2 +- .../qemuargv2xml-graphics-vnc-socket.xml | 4 +- .../qemuargv2xml-graphics-vnc-tls.xml | 2 +- .../qemuargv2xml-graphics-vnc-websocket.xml | 2 +- .../qemuargv2xmldata/qemuargv2xml-graphics-vnc.xml | 2 +- ...qemuhotplug-console-compat-2+console-virtio.xml | 2 +- .../qemuhotplug-graphics-spice-listen-network.xml | 2 +- .../qemuxml2argv-console-compat-2.xml | 2 +- .../qemuxml2argv-controller-order.args | 2 +- ...muxml2argv-graphics-spice-auto-unix-socket.args | 21 + ...emuxml2argv-graphics-spice-auto-unix-socket.xml | 30 + .../qemuxml2argv-graphics-spice-unix-socket.args | 20 + .../qemuxml2argv-graphics-spice-unix-socket.xml | 30 + ...qemuxml2argv-graphics-vnc-auto-unix-socket.args | 20 + .../qemuxml2argv-graphics-vnc-auto-unix-socket.xml | 30 + .../qemuxml2argv-graphics-vnc-autosocket.args | 22 - .../qemuxml2argv-graphics-vnc-autosocket.xml | 34 -- .../qemuxml2argv-graphics-vnc-unix-socket.args | 20 + .../qemuxml2argv-graphics-vnc-unix-socket.xml | 30 + .../qemuxml2argv-hugepages-numa.args | 2 +- .../qemuxml2argv-video-device-pciaddr-default.args | 2 +- .../qemuxml2argv-video-virtio-gpu-spice-gl.args | 2 +- tests/qemuxml2argvtest.c | 8 + .../qemuxml2xmlout-graphics-listen-network.xml | 2 +- .../qemuxml2xmlout-graphics-listen-network2.xml | 4 +- ...uxml2xmlout-graphics-spice-auto-unix-socket.xml | 35 ++ .../qemuxml2xmlout-graphics-spice-compression.xml | 2 +- .../qemuxml2xmlout-graphics-spice-qxl-vga.xml | 2 +- .../qemuxml2xmlout-graphics-spice-timeout.xml | 4 +- .../qemuxml2xmlout-graphics-spice-unix-socket.xml | 35 ++ .../qemuxml2xmlout-graphics-spice.xml | 2 +- ...emuxml2xmlout-graphics-vnc-auto-unix-socket.xml | 35 ++ .../qemuxml2xmlout-graphics-vnc-autosocket.xml | 39 -- .../qemuxml2xmlout-graphics-vnc-no-listen-attr.xml | 2 +- .../qemuxml2xmlout-graphics-vnc-sasl.xml | 2 +- .../qemuxml2xmlout-graphics-vnc-tls.xml | 2 +- .../qemuxml2xmlout-graphics-vnc-unix-socket.xml | 35 ++ .../qemuxml2xmlout-graphics-vnc-websocket.xml | 2 +- .../qemuxml2xmlout-graphics-vnc.xml | 2 +- .../qemuxml2xmlout-interface-server.xml | 4 +- .../qemuxml2xmlout-net-bandwidth.xml | 4 +- .../qemuxml2xmlout-net-bandwidth2.xml | 4 +- .../qemuxml2xmlout-pci-bridge.xml | 2 +- ...emuxml2xmlout-seclabel-dynamic-none-relabel.xml | 2 +- .../qemuxml2xmlout-serial-spiceport.xml | 2 +- .../qemuxml2xmlout-video-virtio-gpu-spice-gl.xml | 3 +- tests/qemuxml2xmltest.c | 11 +- tests/sexpr2xmldata/sexpr2xml-curmem.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-autoport.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-empty-kernel.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-force-hpet.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-force-nohpet.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-localtime.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-net-netfront.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-parallel-tcp.xml | 4 +- .../sexpr2xml-fv-serial-dev-2-ports.xml | 4 +- .../sexpr2xml-fv-serial-dev-2nd-port.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-serial-file.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-serial-null.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-serial-pipe.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-serial-pty.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-serial-stdio.xml | 4 +- .../sexpr2xml-fv-serial-tcp-telnet.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-serial-udp.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-serial-unix.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-sound-all.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-sound.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-usbmouse.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-usbtablet.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-utc.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv-v2.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-fv.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml | 4 +- .../sexpr2xml-pv-vfb-new-vncdisplay.xml | 2 +- tests/sexpr2xmldata/sexpr2xml-pv-vfb-new.xml | 2 +- .../sexpr2xmldata/sexpr2xml-pv-vfb-type-crash.xml | 4 +- tests/sexpr2xmldata/sexpr2xml-vif-rate.xml | 4 +- tests/vmx2xmldata/vmx2xml-graphics-vnc.xml | 4 +- .../test-disk-positional-parms-full.xml | 2 +- .../test-disk-positional-parms-partial.xml | 2 +- ...est-fullvirt-direct-kernel-boot-bogus-extra.xml | 2 +- .../test-fullvirt-direct-kernel-boot-extra.xml | 2 +- .../test-fullvirt-direct-kernel-boot.xml | 2 +- tests/xlconfigdata/test-fullvirt-multiusb.xml | 2 +- tests/xlconfigdata/test-fullvirt-nohap.xml | 2 +- tests/xlconfigdata/test-new-disk.xml | 2 +- tests/xlconfigdata/test-rbd-multihost-noauth.xml | 2 +- tests/xlconfigdata/test-spice-features.xml | 2 +- tests/xlconfigdata/test-spice.xml | 2 +- tests/xlconfigdata/test-vif-rate.xml | 2 +- tests/xmconfigdata/test-escape-paths.xml | 2 +- .../xmconfigdata/test-fullvirt-default-feature.xml | 2 +- tests/xmconfigdata/test-fullvirt-force-hpet.xml | 2 +- tests/xmconfigdata/test-fullvirt-force-nohpet.xml | 2 +- tests/xmconfigdata/test-fullvirt-localtime.xml | 2 +- tests/xmconfigdata/test-fullvirt-net-netfront.xml | 2 +- tests/xmconfigdata/test-fullvirt-new-cdrom.xml | 2 +- tests/xmconfigdata/test-fullvirt-nohap.xml | 2 +- tests/xmconfigdata/test-fullvirt-parallel-tcp.xml | 2 +- .../test-fullvirt-serial-dev-2-ports.xml | 2 +- .../test-fullvirt-serial-dev-2nd-port.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-file.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-null.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-pipe.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-pty.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-stdio.xml | 2 +- .../test-fullvirt-serial-tcp-telnet.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-tcp.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-udp.xml | 2 +- tests/xmconfigdata/test-fullvirt-serial-unix.xml | 2 +- tests/xmconfigdata/test-fullvirt-sound.xml | 2 +- tests/xmconfigdata/test-fullvirt-usbmouse.xml | 2 +- tests/xmconfigdata/test-fullvirt-usbtablet.xml | 2 +- tests/xmconfigdata/test-fullvirt-utc.xml | 2 +- tests/xmconfigdata/test-no-source-cdrom.xml | 4 +- tests/xmconfigdata/test-paravirt-net-e1000.xml | 2 +- tests/xmconfigdata/test-paravirt-net-vifname.xml | 2 +- .../test-paravirt-new-pvfb-vncdisplay.xml | 2 +- tests/xmconfigdata/test-paravirt-new-pvfb.xml | 2 +- tests/xmconfigdata/test-pci-devs.xml | 4 +- 173 files changed, 2392 insertions(+), 1014 deletions(-) create mode 100644 tests/genericxml2xmlindata/generic-graphics-listen-back-compat-ports.xml create mode 100644 tests/genericxml2xmlindata/generic-graphics-vnc-listen-attr-only.xml create mode 100644 tests/genericxml2xmlindata/generic-graphics-vnc-listen-element-minimal.xml create mode 100644 tests/genericxml2xmlindata/generic-graphics-vnc-listen-element-with-address-port.xml create mode 100644 tests/genericxml2xmlindata/generic-graphics-vnc-listen-element-with-address.xml create mode 100644 tests/genericxml2xmlindata/generic-graphics-vnc-manual-port.xml create mode 100644 tests/genericxml2xmlindata/generic-graphics-vnc-minimal.xml create mode 100644 tests/genericxml2xmlindata/generic-graphics-vnc-socket-listen.xml create mode 100644 tests/genericxml2xmlindata/generic-graphics-vnc-socket.xml create mode 100644 tests/genericxml2xmloutdata/generic-graphics-listen-back-compat-ports.xml create mode 100644 tests/genericxml2xmloutdata/generic-graphics-vnc-listen-attr-only.xml create mode 100644 tests/genericxml2xmloutdata/generic-graphics-vnc-listen-element-minimal.xml create mode 100644 tests/genericxml2xmloutdata/generic-graphics-vnc-listen-element-with-address-port.xml create mode 100644 tests/genericxml2xmloutdata/generic-graphics-vnc-listen-element-with-address.xml create mode 100644 tests/genericxml2xmloutdata/generic-graphics-vnc-manual-port.xml create mode 100644 tests/genericxml2xmloutdata/generic-graphics-vnc-minimal.xml create mode 100644 tests/genericxml2xmloutdata/generic-graphics-vnc-socket-listen.xml create mode 100644 tests/genericxml2xmloutdata/generic-graphics-vnc-socket.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-auto-unix-socket.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-auto-unix-socket.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-unix-socket.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-unix-socket.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-auto-unix-socket.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-auto-unix-socket.xml delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-autosocket.args delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-autosocket.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-unix-socket.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-unix-socket.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-spice-auto-unix-socket.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-spice-unix-socket.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-vnc-auto-unix-socket.xml delete mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-vnc-autosocket.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-vnc-unix-socket.xml -- 2.8.2

4 33

[libvirt] [PATCH v2 0/4] qemu: handle ',' and '=' in VM name
by Cole Robinson 06 May '16

06 May '16

This series adds qemu cli comma escaping to several places that are dependent on the VM name, to enable names with embedded commas. Patch 4 makes use of qemu -name guest=X value to allow names with '=' in them. https://bugzilla.redhat.com/show_bug.cgi?id=639926 https://bugzilla.redhat.com/show_bug.cgi?id=1276485 Note: There's likely other places that are VM name dependent that need comma escaping too, but this hits the mandatory ones. I've listed some more on the BiteSizedTasks page: http://wiki.libvirt.org/page/BiteSizedTasks#qemu:_Use_comma_escaping_for_mo… v2: Rebase to master Cole Robinson (4): qemu: command: escape commas in VM name qemu: command: escape commas in secret master path qemu: command: escape commas in chardev socket path qemu: command: Use -name guest= if available src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 22 ++++++++++++-------- tests/qemucapabilitiesdata/caps_2.1.1-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.4.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.5.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.6.0-1.caps | 1 + .../qemuxml2argvdata/qemuxml2argv-name-escape.args | 24 ++++++++++++++++++++++ .../qemuxml2argvdata/qemuxml2argv-name-escape.xml | 18 ++++++++++++++++ tests/qemuxml2argvtest.c | 2 ++ 10 files changed, 65 insertions(+), 8 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-name-escape.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-name-escape.xml -- 2.7.4

2 10

[libvirt] [PATCH] domain_conf: fix migration/managedsave with usb keyboad
by Pavel Hrdina 06 May '16

06 May '16

Commint 36785c7e refactored the code for input devices but introduced a bug that we removed all keyboard from migratable XML. We have to remove only implicit keyboards like PS2 or XEN. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/conf/domain_conf.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 2c97bc1..b90c2b6 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -21193,8 +21193,10 @@ virDomainInputDefFormat(virBufferPtr buf, const char *bus = virDomainInputBusTypeToString(def->bus); /* don't format keyboard into migratable XML for backward compatibility */ - if (def->type == VIR_DOMAIN_INPUT_TYPE_KBD && - flags & VIR_DOMAIN_DEF_FORMAT_MIGRATABLE) + if (flags & VIR_DOMAIN_DEF_FORMAT_MIGRATABLE && + def->type == VIR_DOMAIN_INPUT_TYPE_KBD && + (def->bus == VIR_DOMAIN_INPUT_BUS_PS2 || + def->bus == VIR_DOMAIN_INPUT_BUS_XEN)) return 0; if (!type) { -- 2.8.2

2 1

[libvirt] [PATCH] virCgroupValidateMachineGroup: Reflect change in CGroup struct naming
by Michal Privoznik 06 May '16

06 May '16

Fron c3bd0019c0e on instead of creating the following path for cgroups: /sys/fs/cgroupX/$name.libvirt-$driver we generate rather more verbose one: /sys/fs/cgroupX/$driver-$id-$name.libvirt-$driver where $name is optional and included iff contains allowed chars. See original commit for more reasoning. Now, problem with the original commit is that we are unable to start any LXC domain after it. Because when starting LXC container, the CGroup layout is created by our lxc_controller process and then detected and validated by libvirtd. The validation is done by trying to match detected layout against all the possible patterns for cgroup paths that we've ever had. And the commit in question forgot to update this part of the code. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- I am really surprised how long this bug went unnoticed. Is anybody using LXC? When pushed, it should be backported to 1.3.2+. src/util/vircgroup.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index da5ccff..add6c5f 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -261,12 +261,17 @@ virCgroupValidateMachineGroup(virCgroupPtr group, char *scopename_new = NULL; char *machinename = virSystemdMakeMachineName(drivername, id, name, privileged); + char *partmachinename = NULL; if (virAsprintf(&partname, "%s.libvirt-%s", - name, drivername) < 0) + name, drivername) < 0 || + (machinename && + virAsprintf(&partmachinename, "%s.libvirt-%s", + machinename, drivername) < 0)) goto cleanup; - if (virCgroupPartitionEscape(&partname) < 0) + if (virCgroupPartitionEscape(&partname) < 0 || + (machinename && virCgroupPartitionEscape(&partmachinename) < 0)) goto cleanup; if (!(scopename_old = virSystemdMakeScopeName(name, drivername, true))) @@ -315,6 +320,7 @@ virCgroupValidateMachineGroup(virCgroupPtr group, if (STRNEQ(tmp, name) && STRNEQ_NULLABLE(tmp, machinename) && STRNEQ(tmp, partname) && + STRNEQ_NULLABLE(tmp, partmachinename) && STRNEQ(tmp, scopename_old) && STRNEQ_NULLABLE(tmp, scopename_new)) { VIR_DEBUG("Name '%s' for controller '%s' does not match " @@ -329,6 +335,7 @@ virCgroupValidateMachineGroup(virCgroupPtr group, valid = true; cleanup: + VIR_FREE(partmachinename); VIR_FREE(partname); VIR_FREE(scopename_old); VIR_FREE(scopename_new); -- 2.8.1

3 2

[libvirt] [PATCH 00/12] Enhance QEMU/domain capabilities tests
by Jiri Denemark 06 May '16

06 May '16

Jiri Denemark (12): tests: Refactor domaincapstest qemucapabilitiestest: Prepare for testing non-x86_64 archs qemu: Separate formatting from saving into caps cache qemu: Export caps cache APIs for tests qemucapabilitiestest: Uses consistent names qemucapabilitiestest: Reindent *.caps files qemucapabilitiestest: Reorder flags in caps files qemucapabilitiestest: Test all capabilities qemucapabilitiestest: Rename *.caps to *.xml domaincapstest: Use default machine type qemucapabilitiestest: Add tests for aarch64 and ppc64le domaincapstest: Add tests for QEMU 2.6 src/qemu/qemu_capabilities.c | 34 +- src/qemu/qemu_capspriv.h | 9 + .../domaincaps-qemu_1.6.50-1.xml | 3 +- .../domaincaps-qemu_2.6.0-1.xml | 63 + .../domaincaps-qemu_2.6.0-2.xml | 63 + .../domaincaps-qemu_2.6.0-3.xml | 67 + .../domaincaps-qemu_2.6.0-4.xml | 67 + .../domaincaps-qemu_2.6.0-5.xml | 61 + tests/domaincapstest.c | 209 +- tests/qemucapabilitiesdata/caps_1.2.2-1.caps | 117 - ...1.2.2-1.replies => caps_1.2.2-1.x86_64.replies} | 0 tests/qemucapabilitiesdata/caps_1.2.2-1.x86_64.xml | 159 + tests/qemucapabilitiesdata/caps_1.3.1-1.caps | 133 - ...1.3.1-1.replies => caps_1.3.1-1.x86_64.replies} | 0 tests/qemucapabilitiesdata/caps_1.3.1-1.x86_64.xml | 179 + tests/qemucapabilitiesdata/caps_1.4.2-1.caps | 134 - ...1.4.2-1.replies => caps_1.4.2-1.x86_64.replies} | 0 tests/qemucapabilitiesdata/caps_1.4.2-1.x86_64.xml | 181 + tests/qemucapabilitiesdata/caps_1.5.3-1.caps | 143 - ...1.5.3-1.replies => caps_1.5.3-1.x86_64.replies} | 0 tests/qemucapabilitiesdata/caps_1.5.3-1.x86_64.xml | 190 + tests/qemucapabilitiesdata/caps_1.6.0-1.caps | 149 - ...1.6.0-1.replies => caps_1.6.0-1.x86_64.replies} | 0 tests/qemucapabilitiesdata/caps_1.6.0-1.x86_64.xml | 200 + tests/qemucapabilitiesdata/caps_1.6.50-1.caps | 149 - ...6.50-1.replies => caps_1.6.50-1.x86_64.replies} | 0 .../qemucapabilitiesdata/caps_1.6.50-1.x86_64.xml | 202 + tests/qemucapabilitiesdata/caps_2.1.1-1.caps | 167 - ...2.1.1-1.replies => caps_2.1.1-1.x86_64.replies} | 0 tests/qemucapabilitiesdata/caps_2.1.1-1.x86_64.xml | 225 + tests/qemucapabilitiesdata/caps_2.4.0-1.caps | 180 - ...2.4.0-1.replies => caps_2.4.0-1.x86_64.replies} | 0 tests/qemucapabilitiesdata/caps_2.4.0-1.x86_64.xml | 245 + tests/qemucapabilitiesdata/caps_2.5.0-1.caps | 181 - ...2.5.0-1.replies => caps_2.5.0-1.x86_64.replies} | 0 tests/qemucapabilitiesdata/caps_2.5.0-1.x86_64.xml | 246 + .../caps_2.6.0-1.aarch64.replies | 4940 ++++++++++++++++ .../qemucapabilitiesdata/caps_2.6.0-1.aarch64.xml | 238 + tests/qemucapabilitiesdata/caps_2.6.0-1.caps | 186 - .../caps_2.6.0-1.ppc64le.replies | 6163 ++++++++++++++++++++ .../qemucapabilitiesdata/caps_2.6.0-1.ppc64le.xml | 604 ++ ...2.6.0-1.replies => caps_2.6.0-1.x86_64.replies} | 0 tests/qemucapabilitiesdata/caps_2.6.0-1.x86_64.xml | 251 + .../caps_2.6.0-2.aarch64.replies | 4940 ++++++++++++++++ .../qemucapabilitiesdata/caps_2.6.0-2.aarch64.xml | 238 + tests/qemucapabilitiestest.c | 92 +- tests/testutilsqemu.c | 41 +- 47 files changed, 19740 insertions(+), 1709 deletions(-) create mode 100644 tests/domaincapsschemadata/domaincaps-qemu_2.6.0-1.xml create mode 100644 tests/domaincapsschemadata/domaincaps-qemu_2.6.0-2.xml create mode 100644 tests/domaincapsschemadata/domaincaps-qemu_2.6.0-3.xml create mode 100644 tests/domaincapsschemadata/domaincaps-qemu_2.6.0-4.xml create mode 100644 tests/domaincapsschemadata/domaincaps-qemu_2.6.0-5.xml delete mode 100644 tests/qemucapabilitiesdata/caps_1.2.2-1.caps rename tests/qemucapabilitiesdata/{caps_1.2.2-1.replies => caps_1.2.2-1.x86_64.replies} (100%) create mode 100644 tests/qemucapabilitiesdata/caps_1.2.2-1.x86_64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_1.3.1-1.caps rename tests/qemucapabilitiesdata/{caps_1.3.1-1.replies => caps_1.3.1-1.x86_64.replies} (100%) create mode 100644 tests/qemucapabilitiesdata/caps_1.3.1-1.x86_64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_1.4.2-1.caps rename tests/qemucapabilitiesdata/{caps_1.4.2-1.replies => caps_1.4.2-1.x86_64.replies} (100%) create mode 100644 tests/qemucapabilitiesdata/caps_1.4.2-1.x86_64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_1.5.3-1.caps rename tests/qemucapabilitiesdata/{caps_1.5.3-1.replies => caps_1.5.3-1.x86_64.replies} (100%) create mode 100644 tests/qemucapabilitiesdata/caps_1.5.3-1.x86_64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_1.6.0-1.caps rename tests/qemucapabilitiesdata/{caps_1.6.0-1.replies => caps_1.6.0-1.x86_64.replies} (100%) create mode 100644 tests/qemucapabilitiesdata/caps_1.6.0-1.x86_64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_1.6.50-1.caps rename tests/qemucapabilitiesdata/{caps_1.6.50-1.replies => caps_1.6.50-1.x86_64.replies} (100%) create mode 100644 tests/qemucapabilitiesdata/caps_1.6.50-1.x86_64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_2.1.1-1.caps rename tests/qemucapabilitiesdata/{caps_2.1.1-1.replies => caps_2.1.1-1.x86_64.replies} (100%) create mode 100644 tests/qemucapabilitiesdata/caps_2.1.1-1.x86_64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_2.4.0-1.caps rename tests/qemucapabilitiesdata/{caps_2.4.0-1.replies => caps_2.4.0-1.x86_64.replies} (100%) create mode 100644 tests/qemucapabilitiesdata/caps_2.4.0-1.x86_64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_2.5.0-1.caps rename tests/qemucapabilitiesdata/{caps_2.5.0-1.replies => caps_2.5.0-1.x86_64.replies} (100%) create mode 100644 tests/qemucapabilitiesdata/caps_2.5.0-1.x86_64.xml create mode 100644 tests/qemucapabilitiesdata/caps_2.6.0-1.aarch64.replies create mode 100644 tests/qemucapabilitiesdata/caps_2.6.0-1.aarch64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_2.6.0-1.caps create mode 100644 tests/qemucapabilitiesdata/caps_2.6.0-1.ppc64le.replies create mode 100644 tests/qemucapabilitiesdata/caps_2.6.0-1.ppc64le.xml rename tests/qemucapabilitiesdata/{caps_2.6.0-1.replies => caps_2.6.0-1.x86_64.replies} (100%) create mode 100644 tests/qemucapabilitiesdata/caps_2.6.0-1.x86_64.xml create mode 100644 tests/qemucapabilitiesdata/caps_2.6.0-2.aarch64.replies create mode 100644 tests/qemucapabilitiesdata/caps_2.6.0-2.aarch64.xml -- 2.8.2

3 29

[libvirt] [PATCH] conf: Skip generating random MAC in DetachDevice xml
by Kothapally Madhu Pavan 06 May '16

06 May '16

When we try to detach a network device without specifying the mac address, random mac address is generated. As the generated mac address will not be available in the running vm, detaching device will fail erroring out "error: operation failed: no device matching mac address xx:xx:xx:xx:xx:xx found". Signed-off-by: Kothapally Madhu Pavan <kmp(a)linux.vnet.ibm.com> --- src/conf/domain_conf.c | 4 ++++ src/conf/domain_conf.h | 3 +++ src/libxl/libxl_driver.c | 12 ++++++------ src/lxc/lxc_driver.c | 7 ++++--- src/qemu/qemu_driver.c | 2 ++ src/uml/uml_driver.c | 6 ++++-- src/vbox/vbox_common.c | 6 ++++-- src/vz/vz_driver.c | 4 +++- src/xen/xend_internal.c | 6 ++++-- src/xen/xm_internal.c | 8 ++++---- 10 files changed, 38 insertions(+), 20 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 28248c8..512d877 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8784,6 +8784,10 @@ virDomainNetDefParseXML(virDomainXMLOptionPtr xmlopt, (const char *)macaddr); goto error; } + } else if (flags & VIR_DOMAIN_DEF_PARSE_SKIP_GENERATE_MACADDR) { + virReportError(VIR_ERR_XML_ERROR, "%s", + _("mac address not specified in the device xml")); + goto error; } else { virDomainNetGenerateMAC(xmlopt, &def->mac); } diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 1986f53..74692f1 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2679,6 +2679,9 @@ typedef enum { VIR_DOMAIN_DEF_PARSE_SKIP_OSTYPE_CHECKS = 1 << 8, /* allow updates in post parse callback that would break ABI otherwise */ VIR_DOMAIN_DEF_PARSE_ABI_UPDATE = 1 << 9, + /* don't generate random mac address when a network device without mac address + * is detached */ + VIR_DOMAIN_DEF_PARSE_SKIP_GENERATE_MACADDR = 1 << 10, } virDomainDefParseFlags; typedef enum { diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index bf97c9c..507edcf 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -3726,6 +3726,8 @@ libxlDomainDetachDeviceFlags(virDomainPtr dom, const char *xml, virDomainDefPtr vmdef = NULL; virDomainDeviceDefPtr dev = NULL; int ret = -1; + unsigned int parse_flags = VIR_DOMAIN_DEF_PARSE_INACTIVE | + VIR_DOMAIN_DEF_PARSE_SKIP_GENERATE_MACADDR; virCheckFlags(VIR_DOMAIN_DEVICE_MODIFY_LIVE | VIR_DOMAIN_DEVICE_MODIFY_CONFIG, -1); @@ -3743,9 +3745,8 @@ libxlDomainDetachDeviceFlags(virDomainPtr dom, const char *xml, goto endjob; if (flags & VIR_DOMAIN_DEVICE_MODIFY_CONFIG) { - if (!(dev = virDomainDeviceDefParse(xml, vm->def, - cfg->caps, driver->xmlopt, - VIR_DOMAIN_DEF_PARSE_INACTIVE))) + if (!(dev = virDomainDeviceDefParse(xml, vm->def, cfg->caps, + driver->xmlopt, parse_flags))) goto endjob; /* Make a copy for updated domain. */ @@ -3760,9 +3761,8 @@ libxlDomainDetachDeviceFlags(virDomainPtr dom, const char *xml, if (flags & VIR_DOMAIN_DEVICE_MODIFY_LIVE) { /* If dev exists it was created to modify the domain config. Free it. */ virDomainDeviceDefFree(dev); - if (!(dev = virDomainDeviceDefParse(xml, vm->def, - cfg->caps, driver->xmlopt, - VIR_DOMAIN_DEF_PARSE_INACTIVE))) + if (!(dev = virDomainDeviceDefParse(xml, vm->def, cfg->caps, + driver->xmlopt, parse_flags))) goto endjob; if (libxlDomainDetachDeviceLive(driver, vm, dev) < 0) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index ef48812..23f0d80 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -5196,6 +5196,8 @@ static int lxcDomainDetachDeviceFlags(virDomainPtr dom, virDomainDefPtr vmdef = NULL; virDomainDeviceDefPtr dev = NULL, dev_copy = NULL; int ret = -1; + unsigned int parse_flags = VIR_DOMAIN_DEF_PARSE_INACTIVE | + VIR_DOMAIN_DEF_PARSE_SKIP_GENERATE_MACADDR; virLXCDriverConfigPtr cfg = virLXCDriverGetConfig(driver); virCheckFlags(VIR_DOMAIN_AFFECT_LIVE | @@ -5213,9 +5215,8 @@ static int lxcDomainDetachDeviceFlags(virDomainPtr dom, if (!(caps = virLXCDriverGetCapabilities(driver, false))) goto cleanup; - dev = dev_copy = virDomainDeviceDefParse(xml, vm->def, - caps, driver->xmlopt, - VIR_DOMAIN_DEF_PARSE_INACTIVE); + dev = dev_copy = virDomainDeviceDefParse(xml, vm->def, caps, + driver->xmlopt, parse_flags); if (dev == NULL) goto cleanup; diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 862c44c..df85fd5 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -8486,6 +8486,8 @@ static int qemuDomainDetachDeviceFlags(virDomainPtr dom, const char *xml, !(flags & VIR_DOMAIN_AFFECT_LIVE)) parse_flags |= VIR_DOMAIN_DEF_PARSE_INACTIVE; + parse_flags |= VIR_DOMAIN_DEF_PARSE_SKIP_GENERATE_MACADDR; + dev = dev_copy = virDomainDeviceDefParse(xml, vm->def, caps, driver->xmlopt, parse_flags); diff --git a/src/uml/uml_driver.c b/src/uml/uml_driver.c index 84e1df8..c232435 100644 --- a/src/uml/uml_driver.c +++ b/src/uml/uml_driver.c @@ -2346,6 +2346,8 @@ static int umlDomainDetachDevice(virDomainPtr dom, const char *xml) virDomainObjPtr vm; virDomainDeviceDefPtr dev = NULL; int ret = -1; + unsigned int parse_flags = VIR_DOMAIN_DEF_PARSE_INACTIVE | + VIR_DOMAIN_DEF_PARSE_SKIP_GENERATE_MACADDR; umlDriverLock(driver); vm = virDomainObjListFindByUUID(driver->domains, dom->uuid); @@ -2366,8 +2368,8 @@ static int umlDomainDetachDevice(virDomainPtr dom, const char *xml) goto cleanup; } - dev = virDomainDeviceDefParse(xml, vm->def, driver->caps, driver->xmlopt, - VIR_DOMAIN_DEF_PARSE_INACTIVE); + dev = virDomainDeviceDefParse(xml, vm->def, driver->caps, + driver->xmlopt, parse_flags); if (dev == NULL) goto cleanup; diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index 0cead10..4c539ef 100644 --- a/src/vbox/vbox_common.c +++ b/src/vbox/vbox_common.c @@ -4228,6 +4228,8 @@ static int vboxDomainDetachDevice(virDomainPtr dom, const char *xml) virDomainDeviceDefPtr dev = NULL; nsresult rc; int ret = -1; + unsigned int parse_flags = VIR_DOMAIN_DEF_PARSE_INACTIVE | + VIR_DOMAIN_DEF_PARSE_SKIP_GENERATE_MACADDR; if (!data->vboxObj) return ret; @@ -4238,8 +4240,8 @@ static int vboxDomainDetachDevice(virDomainPtr dom, const char *xml) def->os.type = VIR_DOMAIN_OSTYPE_HVM; - dev = virDomainDeviceDefParse(xml, def, data->caps, data->xmlopt, - VIR_DOMAIN_DEF_PARSE_INACTIVE); + dev = virDomainDeviceDefParse(xml, def, data->caps, + data->xmlopt, parse_flags); if (dev == NULL) goto cleanup; diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index ffa6f45..f5f5395 100644 --- a/src/vz/vz_driver.c +++ b/src/vz/vz_driver.c @@ -1172,6 +1172,8 @@ static int vzDomainDetachDeviceFlags(virDomainPtr dom, const char *xml, vzConnPtr privconn = dom->conn->privateData; virDomainDeviceDefPtr dev = NULL; virDomainObjPtr privdom = NULL; + unsigned int parse_flags = VIR_DOMAIN_XML_INACTIVE | + VIR_DOMAIN_DEF_PARSE_SKIP_GENERATE_MACADDR; virCheckFlags(VIR_DOMAIN_AFFECT_LIVE | VIR_DOMAIN_AFFECT_CONFIG, -1); @@ -1184,7 +1186,7 @@ static int vzDomainDetachDeviceFlags(virDomainPtr dom, const char *xml, goto cleanup; dev = virDomainDeviceDefParse(xml, privdom->def, privconn->driver->caps, - privconn->driver->xmlopt, VIR_DOMAIN_XML_INACTIVE); + privconn->driver->xmlopt, parse_flags); if (dev == NULL) goto cleanup; diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c index cf7cdd0..216c4f4 100644 --- a/src/xen/xend_internal.c +++ b/src/xen/xend_internal.c @@ -2327,6 +2327,8 @@ xenDaemonDetachDeviceFlags(virConnectPtr conn, int ret = -1; char *xendev = NULL; virBuffer buf = VIR_BUFFER_INITIALIZER; + unsigned int parse_flags = VIR_DOMAIN_DEF_PARSE_INACTIVE | + VIR_DOMAIN_DEF_PARSE_SKIP_GENERATE_MACADDR; virCheckFlags(VIR_DOMAIN_AFFECT_LIVE | VIR_DOMAIN_AFFECT_CONFIG, -1); @@ -2354,8 +2356,8 @@ xenDaemonDetachDeviceFlags(virConnectPtr conn, NULL))) goto cleanup; - if (!(dev = virDomainDeviceDefParse(xml, def, priv->caps, priv->xmlopt, - VIR_DOMAIN_DEF_PARSE_INACTIVE))) + if (!(dev = virDomainDeviceDefParse(xml, def, priv->caps, + priv->xmlopt, parse_flags); goto cleanup; if (virDomainXMLDevID(conn, minidef, dev, class, ref, sizeof(ref))) diff --git a/src/xen/xm_internal.c b/src/xen/xm_internal.c index ef1a460..ae142a3 100644 --- a/src/xen/xm_internal.c +++ b/src/xen/xm_internal.c @@ -1322,6 +1322,8 @@ xenXMDomainDetachDeviceFlags(virConnectPtr conn, int ret = -1; size_t i; xenUnifiedPrivatePtr priv = conn->privateData; + unsigned int parse_flags = VIR_DOMAIN_DEF_PARSE_INACTIVE | + VIR_DOMAIN_DEF_PARSE_SKIP_GENERATE_MACADDR; virCheckFlags(VIR_DOMAIN_AFFECT_LIVE | VIR_DOMAIN_AFFECT_CONFIG, -1); @@ -1340,10 +1342,8 @@ xenXMDomainDetachDeviceFlags(virConnectPtr conn, goto cleanup; def = entry->def; - if (!(dev = virDomainDeviceDefParse(xml, entry->def, - priv->caps, - priv->xmlopt, - VIR_DOMAIN_DEF_PARSE_INACTIVE))) + if (!(dev = virDomainDeviceDefParse(xml, entry->def, priv->caps, + priv->xmlopt, parse_flags))) goto cleanup; switch (dev->type) {

2 1

[libvirt] [PATCH 0/4] rpc: Fix fd leak and potential crash
by Cole Robinson 05 May '16

05 May '16

Patch 1 was already sent, I'd like to get it in for the release, it should be quite safe. Remaining patches centralize some cleanup code and fix a potential crasher, but since it should be rare I'd like to wait till after the release. Previous thread: http://www.redhat.com/archives/libvir-list/2016-April/msg01618.html Ben Gray (1): rpc: Don't leak fd via CreateXMLWithFiles Cole Robinson (3): rpc: Add virNetMessageClearPayload rpc: Clear more in virNetMessageClearPayload rpc: use virNetMessageClearPayload in client src/libvirt_remote.syms | 1 + src/rpc/virnetclient.c | 5 +---- src/rpc/virnetmessage.c | 28 +++++++++++++++++++--------- src/rpc/virnetmessage.h | 2 ++ 4 files changed, 23 insertions(+), 13 deletions(-) -- 2.7.4

2 10

[libvirt] [PATCH v2 0/8] Add IV Secret Object support
by John Ferlan 05 May '16

05 May '16

v1 here (specifically patches 11 & 12) http://www.redhat.com/archives/libvir-list/2016-April/msg01077.html What's new/changed: Patches 1-3 address comments made by Jan in his review of v1. Patch 4 is essentially following through on the Patch 3 comment Patch 5 was part of patch 11, but I split it out for easier review Patch 6 is the remainder of the former patch 11. Other than using the ...SECRET_INFO_TYPE_xxx nomenclature, no other real changes. Patch 7 was part of patch 12, but I split it out to reduce the amount to review. Beyond the aforementioned ...SECRET_INFO_TYPE_xxx changes, I removed qemuDomainSecretInfoGetAlias. Initially created to help with any hotplug code, but that's not necessary, so remove it for now. It was brought up on Jan's comments as well. Create qemuDomainSecretSetup in order to address Jan's other comment about a common API This code could be merged with patch 8, but separating it *and* leaving qemuDomainSecretHaveEncrypt essentially brain-dead worked made for a shorter pile to look at Patch 8 is the remainder of patch 12. I investigated extracting the iSCSI and RBD code out, but it really just didn't make practice sense. I altered qemuBuildSecretIVCommandLine to just access the IV alias directly since the callers were adjusted to only try to build the IV object if necessary. The qemuBuild{Disk|Hostdev}iSCSICommandLine were renamed to qemuBuild{Disk|Hostdev}SecinfoCommandLine and each encapsulated the call to qemuBuildSecretIVCommandLine rather than inlining it in each of the callers The qemuDomainSecretHaveEncrypt will not be braindead. None of the tests changed, so it doesn't seem I messed anything up with all the requested adjustments. John Ferlan (8): qemu: Adjust names of qemuDomainSecretInfoType enums qemu: Split out the master key create and write qemu: Move qemuDomainSecretPrepare to qemuProcessPrepareDomain qemu: Move qemuDomainSecretDestroy to qemuProcessLaunch qemu: Separate network URI command building code qemu: Introduce qemuDomainSecretIV qemu: Introduce new Secret IV API's qemu: Utilize qemu secret objects for SCSI/RBD auth/secret configure.ac | 1 + src/qemu/qemu_alias.c | 23 ++ src/qemu/qemu_alias.h | 2 + src/qemu/qemu_command.c | 359 +++++++++++++++++++-- src/qemu/qemu_domain.c | 242 ++++++++++++-- src/qemu/qemu_domain.h | 34 +- src/qemu/qemu_hotplug.c | 6 +- src/qemu/qemu_process.c | 23 +- ...uxml2argv-disk-drive-network-iscsi-auth-IV.args | 39 +++ ...muxml2argv-disk-drive-network-iscsi-auth-IV.xml | 43 +++ ...emuxml2argv-disk-drive-network-rbd-auth-IV.args | 31 ++ ...qemuxml2argv-disk-drive-network-rbd-auth-IV.xml | 42 +++ ...emuxml2argv-hostdev-scsi-lsi-iscsi-auth-IV.args | 41 +++ ...qemuxml2argv-hostdev-scsi-lsi-iscsi-auth-IV.xml | 48 +++ ...xml2argv-hostdev-scsi-virtio-iscsi-auth-IV.args | 43 +++ ...uxml2argv-hostdev-scsi-virtio-iscsi-auth-IV.xml | 48 +++ tests/qemuxml2argvmock.c | 31 +- tests/qemuxml2argvtest.c | 19 ++ 18 files changed, 1009 insertions(+), 66 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-iscsi-auth-IV.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-iscsi-auth-IV.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd-auth-IV.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd-auth-IV.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-lsi-iscsi-auth-IV.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-lsi-iscsi-auth-IV.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-virtio-iscsi-auth-IV.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-virtio-iscsi-auth-IV.xml -- 2.5.5

3 20

[libvirt] Fwd: Dump network traffic from each VM.
by Julio Faracco 05 May '16

05 May '16

Forwarding to devel-list. Julio Cesar Faracco ---------- Forwarded message ---------- From: Julio Faracco <jcfaracco(a)gmail.com> Date: 2016-05-04 12:37 GMT-03:00 Subject: Dump network traffic from each VM. To: libvirt-users(a)redhat.com Hi guys, Does anybody know how to dump the network trafic from each virtual machine using libvirt? Here, we usually use VPN softwares and other network tools inside Virtual Machines (Windows and Linux). Sometimes, this applications does not work properly, so we need to dump the network traffic of each Virtual Machine to compare and debug. How can I enable it using libvirt? I know that if you use a QEMU instance, you can enable the dump using "-netdev dump,...". Thanks! :-) Julio Cesar Faracco

1 0

[libvirt] [PATCH 00/27] Remove many conditionals from the RPM
by Daniel P. Berrange 05 May '16

05 May '16

Cole previously suggested that we should simplify the RPM spec by removing conditionals that we never need to toggle for RHEL / Fedora builds, rather than having conditionals for every single feature that exists. This series does just that.... Daniel P. Berrange (27): libvirt.spec.in: explicitly disable xenapi & vz drivers libvirt.spec.in: drop Fedora < 20 and RHEL < 6 libvirt.spec.in: remove client only build option libvirt.spec.in: remove conditional for driver modules libvirt.spec.in: remove libvirtd conditional libvirt.spec.in: remove avahi conditional libvirt.spec.in: remove hal conditional libvirt.spec.in: remove apparmor conditional libvirt.spec.in: remove capng conditional libvirt.spec.in: remove udev conditional libvirt.spec.in: remove netcf conditional libvirt.spec.in: remove audit conditional libvirt.spec.in: remove dtrace conditional libvirt.spec.in: remove sasl conditionals libvirt.spec.in: remove polkit conditional libvirt.spec.in: remove yajl conditional libvirt.spec.in: remove selinux conditional libvirt.spec.in: remove interface driver conditional libvirt.spec.in: remove network driver conditiaonl libvirt.spec.in: remove most storage conditionals libvirt.spec.in: remove nodedev conditional libvirt.spec.in: remove nwfilter driver conditional libvirt.spec.in: remove libpcap conditional libvirt.spec.in: remove macvtap conditional libvirt.spec.in: remove libnl conditional libvirt.spec.in: remove nss plugin conditional libvirt.spec.in: use explicit --with-xxx for all features libvirt.spec.in | 1205 +++++++++++++++---------------------------------------- 1 file changed, 333 insertions(+), 872 deletions(-) -- 2.5.5

2 30

[libvirt] [PATCH 0/2] Two trivial fixes
by Michal Privoznik 05 May '16

05 May '16

*** BLURB HERE *** Michal Privoznik (2): virNetServerClientNewPostExecRestart: Drop useless typecasts virNetServerClientNewPostExecRestart: Avoid align problems src/rpc/virnetserverclient.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) -- 2.8.1

2 6

[libvirt] [PATCH v2] Get the maxvcpus from both the qemuCaps and /dev/kvm
by Shivaprasad G Bhat 05 May '16

05 May '16

For some archs and machines, the maxvcpus defined in the kernel can be different from the qemu-caps maxvcpus. Just reporting the kernel defined maxvcpus is not be sufficient. virsh domacapabilities and virsh maxvcpus --type kvm return different maxvcpus values and is confusing as to know what actually works. The minimum of the two values is what actually works. For example on PPC64, the KVM_MAX_VCPUS is defined to be 1024 in kernel where as qemu has MAX_CPUMASK_BITS defined at 255 in include/sysemu/sysemu.h. The guest can go upto 256 vcpus here. Signed-off-by: Shivaprasad G Bhat <sbhat(a)linux.vnet.ibm.com> --- src/qemu/qemu_driver.c | 27 ++++++++++++++++++++++++--- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 3d0c7c8..2716af8 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1255,10 +1255,31 @@ static int qemuConnectIsAlive(virConnectPtr conn ATTRIBUTE_UNUSED) static int -kvmGetMaxVCPUs(void) +kvmGetMaxVCPUs(virConnectPtr conn) { int fd; int ret; + int qemuCapsMaxVcpus = 0; + virArch arch = virArchFromHost(); + virQEMUCapsPtr qemuCaps = NULL; + virQEMUDriverPtr driver = conn->privateData; + const char *machine; + + if (!(qemuCaps = virQEMUCapsCacheLookupByArch(driver->qemuCapsCache, + arch))) { + virReportError(VIR_ERR_INVALID_ARG, + _("unable to find any emulator to serve '%s' " + "architecture"), virArchToString(arch)); + return -1; + } + + if (!(machine = virQEMUCapsGetDefaultMachine(qemuCaps))) { + virObjectUnref(qemuCaps); + return -1; + } + + qemuCapsMaxVcpus = virQEMUCapsGetMachineMaxCpus(qemuCaps, machine); + virObjectUnref(qemuCaps); if ((fd = open(KVM_DEVICE, O_RDONLY)) < 0) { virReportSystemError(errno, _("Unable to open %s"), KVM_DEVICE); @@ -1282,7 +1303,7 @@ kvmGetMaxVCPUs(void) cleanup: VIR_FORCE_CLOSE(fd); - return ret; + return ret > qemuCapsMaxVcpus ? qemuCapsMaxVcpus : ret; } @@ -1323,7 +1344,7 @@ qemuConnectGetMaxVcpus(virConnectPtr conn ATTRIBUTE_UNUSED, const char *type) return 16; if (STRCASEEQ(type, "kvm")) - return kvmGetMaxVCPUs(); + return kvmGetMaxVCPUs(conn); if (STRCASEEQ(type, "kqemu")) return 1;

5 11

[libvirt] [PATCH] Add qemucapsprobe in .gitignore
by Jiri Denemark 05 May '16

05 May '16

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- Pushed as trivial. I forgot to squash this into the patch which adds qemucapsprobe :( .gitignore | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index ba537d8..fc21bad 100644 --- a/.gitignore +++ b/.gitignore @@ -159,8 +159,9 @@ /tests/*.log /tests/*.pid /tests/*.trs -/tests/commandhelper /tests/*test +/tests/commandhelper +/tests/qemucapsprobe !/tests/*schematest !/tests/virt-aa-helper-test /tests/objectlocking -- 2.8.2

1 0

[libvirt] [PATCH 0/6] tests: Add qemucapsprobe helper
by Jiri Denemark 05 May '16

05 May '16

Adding new *.replies files for qemucapabilitiestest or updating the files when libvirt adds an additional QMP command into the probing process is quite painful. The goal of the new qemucapsprobe command is to make this process as easy as tests/qemucapsprobe /path/to/qemu/binary >caps.replies Jiri Denemark (6): tests: Create a shared library with qemu driver tests: Decouple preload code from main() qemu: Make virQEMUCapsNewForBinary usable from tests qemu: Make qemuMonitorJSONIOProcessLine available for tests virjson: Make pretty format more compact tests: Add qemucapsprobe helper src/qemu/qemu_capabilities.c | 38 ++- src/qemu/qemu_capspriv.h | 8 + src/qemu/qemu_monitor_json.c | 2 +- src/qemu/qemu_monitor_json.h | 4 + src/util/virjson.c | 4 +- tests/Makefile.am | 23 ++ tests/qemucapabilitiestest.c | 5 + tests/qemucapsprobe.c | 82 +++++++ tests/qemucapsprobemock.c | 93 ++++++++ tests/testutils.h | 9 +- .../virnetdaemondata/output-data-admin-nomdns.json | 254 ++++++++++----------- .../output-data-admin-server-names.json | 254 ++++++++++----------- .../virnetdaemondata/output-data-anon-clients.json | 128 +++++------ tests/virnetdaemondata/output-data-client-ids.json | 128 +++++------ .../output-data-client-timestamp.json | 132 +++++------ .../output-data-initial-nomdns.json | 128 +++++------ tests/virnetdaemondata/output-data-initial.json | 130 +++++------ .../output-data-no-keepalive-required.json | 254 ++++++++++----------- 18 files changed, 960 insertions(+), 716 deletions(-) create mode 100644 tests/qemucapsprobe.c create mode 100644 tests/qemucapsprobemock.c -- 2.8.2

2 13

[libvirt] [PATCH 1/2] configure: split out UML driver checks
by Roman Bogorodskiy 05 May '16

05 May '16

Move all the UML driver related routines into m4/virt-driver-uml.m4. --- configure.ac | 28 ++-------------------------- m4/virt-driver-uml.m4 | 47 +++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 49 insertions(+), 26 deletions(-) create mode 100644 m4/virt-driver-uml.m4 diff --git a/configure.ac b/configure.ac index 88e2e20..d19c1a9 100644 --- a/configure.ac +++ b/configure.ac @@ -537,10 +537,6 @@ AC_ARG_WITH([qemu], [AS_HELP_STRING([--with-qemu], [add QEMU/KVM support @<:@default=yes@:>@])]) m4_divert_text([DEFAULTS], [with_qemu=yes]) -AC_ARG_WITH([uml], - [AS_HELP_STRING([--with-uml], - [add UML support @<:@default=check@:>@])]) -m4_divert_text([DEFAULTS], [with_uml=check]) AC_ARG_WITH([openvz], [AS_HELP_STRING([--with-openvz], [add OpenVZ support @<:@default=check@:>@])]) @@ -1561,27 +1557,7 @@ dnl dnl Checks for the UML driver dnl -if test "$with_libvirtd" = "no" ; then - with_uml=no -fi -if test "$with_uml" = "yes" || test "$with_uml" = "check"; then - AC_CHECK_HEADER([sys/inotify.h], [ - with_uml=yes - ], [ - if test "$with_uml" = "check"; then - with_uml=no - AC_MSG_NOTICE([<sys/inotify.h> is required for the UML driver, disabling it]) - else - AC_MSG_ERROR([The <sys/inotify.h> is required for the UML driver. Upgrade your libc6.]) - fi - ]) -fi -if test "$with_uml" = "yes" ; then - AC_DEFINE_UNQUOTED([WITH_UML], 1, [whether UML driver is enabled]) -fi -AM_CONDITIONAL([WITH_UML], [test "$with_uml" = "yes"]) - - +LIBVIRT_DRIVER_CHECK_UML dnl dnl check for PHYP @@ -2747,7 +2723,7 @@ AC_MSG_NOTICE([Drivers]) AC_MSG_NOTICE([]) AC_MSG_NOTICE([ Xen: $with_xen]) AC_MSG_NOTICE([ QEMU: $with_qemu]) -AC_MSG_NOTICE([ UML: $with_uml]) +LIBVIRT_DRIVER_RESULT_UML AC_MSG_NOTICE([ OpenVZ: $with_openvz]) AC_MSG_NOTICE([ VMware: $with_vmware]) AC_MSG_NOTICE([ VBox: $with_vbox]) diff --git a/m4/virt-driver-uml.m4 b/m4/virt-driver-uml.m4 new file mode 100644 index 0000000..4132315 --- /dev/null +++ b/m4/virt-driver-uml.m4 @@ -0,0 +1,47 @@ +dnl The UML driver +dnl +dnl Copyright (C) 2005-2015 Red Hat, Inc. +dnl +dnl This library is free software; you can redistribute it and/or +dnl modify it under the terms of the GNU Lesser General Public +dnl License as published by the Free Software Foundation; either +dnl version 2.1 of the License, or (at your option) any later version. +dnl +dnl This library is distributed in the hope that it will be useful, +dnl but WITHOUT ANY WARRANTY; without even the implied warranty of +dnl MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +dnl Lesser General Public License for more details. +dnl +dnl You should have received a copy of the GNU Lesser General Public +dnl License along with this library. If not, see +dnl <http://www.gnu.org/licenses/>. +dnl + +AC_DEFUN([LIBVIRT_DRIVER_CHECK_UML],[ + AC_ARG_WITH([uml], + [AS_HELP_STRING([--with-uml], + [add UML support @<:@default=check@:>@])]) + m4_divert_text([DEFAULTS], [with_uml=check]) + + if test "$with_uml" = "yes" || test "$with_uml" = "check"; then + AC_CHECK_HEADER([sys/inotify.h], [ + with_uml=yes + ], [ + if test "$with_uml" = "check"; then + with_uml=no + AC_MSG_NOTICE([<sys/inotify.h> is required for the UML driver, disabling it]) + else + AC_MSG_ERROR([The <sys/inotify.h> is required for the UML driver. Upgrade your libc6.]) + fi + ]) + fi + + if test "$with_uml" = "yes" ; then + AC_DEFINE_UNQUOTED([WITH_UML], 1, [whether UML driver is enabled]) + fi + AM_CONDITIONAL([WITH_UML], [test "$with_uml" = "yes"]) +]) + +AC_DEFUN([LIBVIRT_DRIVER_RESULT_UML],[ + AC_MSG_NOTICE([ UML: $with_uml]) +]) -- 2.7.4

1 2

[libvirt] [PATCH v3 0/2] bhyve: implement domainShutdown
by Roman Bogorodskiy 05 May '16

05 May '16

Changes from v2: - Split domainDestroy changes and domainShutdown addition into two patches - In bhyveDestroy, close bhyve monitor after running 'bhyvectl --destroy' (reasoning in the commit message) Roman Bogorodskiy (2): bhyve: drop virProcessKillPainfully() from destroy bhyve: implement domainShutdown src/bhyve/bhyve_driver.c | 27 +++++++++++++++++++++++++++ src/bhyve/bhyve_process.c | 43 +++++++++++++++++++++++++++++-------------- src/bhyve/bhyve_process.h | 2 ++ 3 files changed, 58 insertions(+), 14 deletions(-) -- 2.7.4

2 5

[libvirt] ANNOUNCE: libvirt 1.3.3.1 maintenance release
by Cole Robinson 05 May '16

05 May '16

libvirt 1.3.3.1 is now available. This is a maintenance release of libvirt 1.3.3 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-1.3.3.1.tar.gz Changes in this version: * spec: Use proper indentation * libvirt.spec: remove duplicate files from -docs package * network: Fix segfault on daemon reload * send default USB controller in xml to destination during migration * virsh: Fix support for 64 migration options * qemu: Regenerate VNC socket paths * qemu: conf: Set default logging approach in virQEMUDriverConfigNew * qemu: Unref cfg in qemuDomainDefPostParse * spec: If installing default network, restart libvirtd * qemu: fix error log in qemuAssignPCIAddresses() * virsh: host: Use bitmap size in bytes rather than bit count * qemu: Fix off-by-one error in block I/O throttle messages * conf: Drop restrictions on rng backend path * vbox: VIR_WARN if we don't support the API version * qemu: Limit maximum block device I/O tune values * virconf: Handle conf file without ending newline * network: fix DHCPv6 on networks with prefix != 64 * rpc: Don't leak fd via CreateXMLWithFiles * libvirt: Fix crash on URI without scheme * tests: fix xen-related tests * man: Clarify virsh vol-clone works within a single pool * network: Don't use ERR_NO_SUPPORT for invalid net-update requests * Revert "daemon: use socket activation with systemd" * Explicitly error on uri=qemu://system * lxc: explicitly error on interface type=ethernet * tests: Fix syntax in iSCSI auth/secret tests * Libvirt: virTypedParamsValidate: Fix detection of multiple parameters * Resolve a couple of memory leaks * libxl: use LIBXL_API_VERSION 0x040200 * Add functions for handling exponential backoff loops. * spec: Only pull in API docs with -devel package * util: Add virGettextInitialize, convert the code * man: virsh: Document lxc-enter-namespace --noseclabel * storage: mpath: Don't error on target_type=NULL * qemu: command: don't overwrite watchdog dump action * rpc: daemon: Fix virtlog/virtlock daemon reload * conf: also mark the implicit video as primary * conf: move default video addition after XML parsing * virtlogd: Fix a couple minor memory leaks * qemu: Free priv->machineName * configure: Fix check for --with-login-shell on Windows * util: move ENODATA redefine to internal.h * libxl: libxl_domain_create_restore has an extra argument * qemu: perf: Fix crash/memory corruption on failed VM start * qemu: alias: Fix calculation of memory device aliases * Link libvirt_xenconfig instead of libvirt against libxl * virt-admin: get rid of LIBVIRT_DEFAULT_ADMIN_URI env var * libvirt-admin: do not crash on URI without a scheme * virsh: read default connection uri from env later * build: add GCC 6.0 -Wlogical-op workaround * build: cleanup GCC < 4.6 -Wlogical-op workaround * qemu: support virt-2.6 machine type on arm For info about past maintenance releases, see: http://wiki.libvirt.org/page/Maintenance_Releases Thanks, Cole

1 0

[libvirt] ANNOUNCE: libvirt 1.2.18.3 maintenance release
by Cole Robinson 05 May '16

05 May '16

libvirt 1.2.18.3 is now available. This is a maintenance release of libvirt 1.2.18 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-1.2.18.3.tar.gz Changes in this version: * spec: Use proper indentation * spec: If installing default network, restart libvirtd * rpc: Don't leak fd via CreateXMLWithFiles * libvirt.spec: remove duplicate files from -docs package * wireshark: Fix header of get_message_len() * wireshark: Replace WIRESHARK_COMPAT with actual version comparison * wireshark: s/tvb_length/tvb_captured_length/ * wireshark: s/ep_alloc/wmem_alloc/ * wireshark: s/proto_tree_add_text/proto_tree_add_item/ * spec: Only pull in API docs with -devel package * build: accomodate selinux 2.5 header API change * build: add GCC 6.0 -Wlogical-op workaround * build: cleanup GCC < 4.6 -Wlogical-op workaround * lxc: don't try to hide parent cgroups inside container * driver: log missing modules as INFO, not WARN * rpc: wait longer for session daemon to start up * util: virfile: Only setuid for virFileRemove if on NFS * util: virfile: Clarify setuid usage for virFileRemove * lxc: fuse: Stub out Slab bits in /proc/meminfo * lxc: fuse: Fill in MemAvailable for /proc/meminfo * lxc: fuse: Fix /proc/meminfo size calculation * lxc: fuse: Unindent meminfo logic * virfile: Fix error path for forked virFileRemove * security: Do not restore kernel and initrd labels * rpc: socket: Don't repeatedly attempt to launch daemon * rpc: socket: Explicitly error if we exceed retry count * rpc: socket: Minor cleanups * build: predictably generate systemtap tapsets (bz 1173641) * leaseshelper: fix crash when no mac is specified * schema: interleave domain name and uuid with other elements For info about past maintenance releases, see: http://wiki.libvirt.org/page/Maintenance_Releases Thanks, Cole

1 0

[libvirt] [PATCH] build: fix 32-bit build of admin
by Eric Blake 04 May '16

04 May '16

We can't guarantee which 64-bit type will be used in an RPC struct; while %lu worked on 64-bit Linux, that won't always be the type used on all 64-bit platforms; and certainly is not right for 32-bit: admin.c: In function 'adminDispatchClientGetInfo': admin.c:265:25: error: format '%lu' expects argument of type 'long unsigned int', but argument 7 has type 'uint64_t {aka long long unsigned int}' [-Werror=format=] Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Pushing under the build-breaker rule daemon/admin.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/daemon/admin.c b/daemon/admin.c index 3de09ca..dbf49dd 100644 --- a/daemon/admin.c +++ b/daemon/admin.c @@ -262,8 +262,8 @@ adminDispatchClientGetInfo(virNetServerPtr server ATTRIBUTE_UNUSED, if (!(clnt = virNetServerGetClient(srv, args->clnt.id))) { virReportError(VIR_ERR_NO_CLIENT, - _("no client with matching id '%lu' found"), - args->clnt.id); + _("no client with matching id '%llu' found"), + (unsigned long long) args->clnt.id); goto cleanup; } -- 2.5.5

1 0

[libvirt] [PATCH] libvirt.spec.in: remove all changelog entries
by Daniel P. Berrange 04 May '16

04 May '16

The %changelog entries in the RPM are just a poor immitation of the release notes, which is not what %changelog section is for. It should be reflecting changes in the RPM packaging, not changes in the application releases. Further, this bogus list of changes has to be manually deleted every time we sync the RPM with Fedora. Remove them, since they serve no useful purpose. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- libvirt.spec.in | 804 -------------------------------------------------------- 1 file changed, 804 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 78eb8aa..2afe437 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1867,807 +1867,3 @@ exit 0 %changelog -* Sun May 1 2016 Daniel Veillard <veillard(a)redhat.com> - 1.3.4-1 -- Lot of work on documentation -- Add support for migration data compression -- many bug fixes and various improvements - -* Wed Apr 6 2016 Daniel Veillard <veillard(a)redhat.com> - 1.3.3-1 -- perf events -- post-copy migration support -- NSS module -- a lot of various improvements, and large number of bugs fixes - -* Tue Mar 1 2016 Daniel Veillard <veillard(a)redhat.com> - 1.3.2-1 -- Various improvements for the Xen libxl driver -- virt-admin improvement -- Various improvements for the RDB volumes -- many bug fixes and improvements - -* Sun Jan 17 2016 Daniel Veillard <veillard(a)redhat.com> - 1.3.1-1 -- Various improvements for the Xen libxl driver -- rbd: Add support for wiping and cloning images to storage driver -- PCI hostdev improvements and fixes -- many bug fixes and improvements - -* Wed Dec 9 2015 Daniel Veillard <veillard(a)redhat.com> - 1.3.0-1 -- virt-admin and administration API -- various improvements in virtio devices support -- log daemon, logging improvements and protocol -- many bug fixes and improvements - -* Wed Nov 4 2015 Daniel Veillard <veillard(a)redhat.com> - 1.2.21-1 -- a number of improvements and bug fixes - -* Fri Oct 2 2015 Daniel Veillard <veillard(a)redhat.com> - 1.2.20-1 -- security fixes for CVE-2015-5247 -- a number of improvements and bug fixes - -* Wed Sep 2 2015 Daniel Veillard <veillard(a)redhat.com> - 1.2.19-1 -- Big improvements on ppc64 support -- New virDomainRename API -- Support for QEMU new pci emulations -- a number of improvements and bug fixes - -* Mon Aug 3 2015 Daniel Veillard <veillard(a)redhat.com> - 1.2.18-1 -- libxl: support dom0 -- a number of improvements and bug fixes - -* Thu Jul 2 2015 Daniel Veillard <veillard(a)redhat.com> - 1.2.17-1 -- numerous improvements and refactoring of the parallels driver -- hardening of vcpu code -- hardening of migration code -- a lot of improvement and bug fixes - -* Mon Jun 1 2015 Daniel Veillard <veillard(a)redhat.com> - 1.2.16-1 -- Introduce pci-serial -- Introduce virDomainSetUserPassword API -- libvirt: Introduce protected key mgmt ops -- add domain vmport feature -- various bug fixes and improvements - -* Mon May 4 2015 Daniel Veillard <veillard(a)redhat.com> - 1.2.15-1 -- Implement virDomainAddIOThread and virDomainDelIOThread -- libxl: Introduce configuration file for libxl driver -- Add VIR_DOMAIN_EVENT_ID_DEVICE_ADDED event -- various improvements to parallels driver -- a lot of improvement and bug fixes - -* Thu Apr 2 2015 Daniel Veillard <veillard(a)redhat.com> - 1.2.14-1 -- qemu: Implement memory device hotplug -- Implement public API for virDomainPinIOThread -- Implement public API for virDomainGetIOThreadsInfo -- SRIOV NIC offload feature discovery -- a lot of improvement and bug fixes - -* Mon Mar 2 2015 Daniel Veillard <veillard(a)redhat.com> - 1.2.13-1 -- lot of improvements around NUMA code -- a lot of improvement and bug fixes - -* Tue Jan 27 2015 Daniel Veillard <veillard(a)redhat.com> - 1.2.12-1 -- CVE-2015-0236: qemu: Check ACLs when dumping security info from snapshots -- CVE-2015-0236: qemu: Check ACLs when dumping security info from save image -- a lot of improvement and bug fixes - -* Sat Dec 13 2014 Daniel Veillard <veillard(a)redhat.com> - 1.2.11-1 -- CVE-2014-8131: Fix possible deadlock and segfault in qemuConnectGetAllDomainStats() -- CVE-2014-7823: dumpxml: security hole with migratable flag -- Implement public API for virDomainGetFSInfo -- Add define support for the new throttle options -- a number of improvements and bug fixes - -* Mon Nov 3 2014 Daniel Veillard <veillard(a)redhat.com> - 1.2.10-1 -- vbox: various drivers improvements -- libxl: various drivers improvements -- Internal driver refactoring -- a number of improvements and bug fixes - -* Wed Oct 1 2014 Daniel Veillard <veillard(a)redhat.com> - 1.2.9-1 -- CVE-2014-3657: domain_conf: fix domain deadlock -- CVE-2014-3633: qemu: blkiotune: Use correct definition when looking up disk -- Introduce virNodeAllocPages -- event: introduce new event for tunable values -- add migration support for OpenVZ driver -- Add support for fetching statistics of completed jobs -- many improvements and bug fixes - -* Tue Sep 2 2014 Daniel Veillard <veillard(a)redhat.com> - 1.2.8-1 -- blockcopy: virDomainBlockCopy with XML destination, typed params -- Introduce API for retrieving bulk domain stats -- Introduce virDomainOpenGraphicsFD API -- storage: ZFS support -- many improvements and bug fixes - -* Sun Aug 3 2014 Daniel Veillard <veillard(a)redhat.com> - 1.2.7-1 -- Introduce virConnectGetDomainCapabilities -- many improvements and bug fixes - -* Wed Jul 2 2014 Daniel Veillard <veillard(a)redhat.com> - 1.2.6-1 -- libxl: add migration support and fixes -- various improvements and fixes for NUMA -- many improvements and bug fixes - -* Mon Jun 2 2014 Daniel Veillard <veillard(a)redhat.com> - 1.2.5-1 -- LSN-2014-0003: Don't expand entities when parsing XML (security) -- Introduce virDomain{Get,Set}Time APIs -- Introduce virDomainFSFreeze() and virDomainFSThaw() public API -- various improvements and bug fixes - -* Sun May 4 2014 Daniel Veillard <veillard(a)redhat.com> - 1.2.4-1 -- various improvements and bug fixes -- lot of internal code refactoring - -* Tue Apr 1 2014 Daniel Veillard <veillard(a)redhat.com> - 1.2.3-1 -- add new virDomainCoreDumpWithFormat API -- conf: Introduce virDomainDeviceGetInfo API -- more features and fixes on bhyve driver -- lot of cleanups and improvement on the Xen driver -- a lot of various improvements and bug fixes - -* Sun Mar 2 2014 Daniel Veillard <veillard(a)redhat.com> - 1.2.2-1 -- add LXC from native conversion tool -- vbox: add support for v4.2.20+ and v4.3.4+ -- Introduce Libvirt Wireshark dissector -- Fix CVE-2013-6456: Avoid unsafe use of /proc/$PID/root in LXC -- a lot of various improvements and bug fixes - -* Thu Jan 16 2014 Daniel Veillard <veillard(a)redhat.com> - 1.2.1-1 -- Fix s CVE-2014-0028 event: filter global events by domain:getattr ACL -- Fix CVE-2014-1447 Don't crash if a connection closes early -- Fix CVE-2013-6458-1 qemu: Do not access stale data in virDomainBlockStats -- Fix CVE-2013-6457 libxl: avoid crashing if calling `virsh numatune' on inactive domain -- Fix CVE-2013-6436: fix crash in lxcDomainGetMemoryParameters -- many doc and bug fixes and improvements - -* Mon Dec 2 2013 Daniel Veillard <veillard(a)redhat.com> - 1.2.0-1 -- Separation of python binding as libvirt-python srpm -- Add support for gluster pool -- vbox: add support for 4.3 APIs -- a number of doc, bug fixes and various improvements - -* Mon Nov 4 2013 Daniel Veillard <veillard(a)redhat.com> - 1.1.4-1 -- Add support for AArch64 architecture -- Various improvements on test code and test driver -- 4 security bug fixes -- a lot of bug fixes and various improvements - -* Tue Oct 1 2013 Daniel Veillard <veillard(a)redhat.com> - 1.1.3-1 -- VMware: Initial VMware Fusion support and various improvements -- libvirt: add new public API virConnectGetCPUModelNames -- various libxl driver improvements -- LXC many container driver improvement -- ARM cpu improvements -- 3 security bug fixes -- a lot of bug and leak fixes and various improvements - -* Mon Sep 2 2013 Daniel Veillard <veillard(a)redhat.com> - 1.1.2-1 -- various improvements to libxl driver -- systemd integration improvements -- Add flag to BaselineCPU API to return detailed CPU features -- Introduce a virt-login-shell binary -- conf: add startupPolicy attribute for harddisk -- various bug fixes and improvements including localizations - -* Tue Jul 30 2013 Daniel Veillard <veillard(a)redhat.com> - 1.1.1-1 -- Adding device removal or deletion events -- Introduce new domain create APIs to pass pre-opened FDs to LXC -- Add interface versions for Xen 4.3 -- Add new public API virDomainSetMemoryStatsPeriod -- Various LXC improvements -- various bug fixes and improvements including localizations - -* Mon Jul 1 2013 Daniel Veillard <veillard(a)redhat.com> - 1.1.0-1 -- CVE-2013-2218: Fix crash listing network interfaces with filters -- Fine grained ACL support for the API -- Extensible migration APIs -- various improvements in the Xen driver -- agent based vCPU hotplug support -- various bug fixes and improvements including localizations - -* Mon Jun 3 2013 Daniel Veillard <veillard(a)redhat.com> - 1.0.6-1 -- Move VirtualBox driver into libvirtd -- Support for static routes on a virtual bridge -- Various improvement for hostdev SCSI support -- Switch to VIR_STRDUP and VIR_STRNDUP -- Various cleanups and improvement in Xen and LXC drivers -- various bug fixes and improvements including localizations - -* Thu May 2 2013 Daniel Veillard <veillard(a)redhat.com> - 1.0.5-1 -- add support for NVRAM device -- Add XML config for resource partitions -- Add support for TPM -- NPIV storage migration support -- various bug fixes and improvements including localizations - -* Mon Apr 1 2013 Daniel Veillard <veillard(a)redhat.com> - 1.0.4-1 -- qemu: support passthrough for iscsi disks -- various S390 improvements -- various LXC bugs fixes and improvements -- Add API for thread cancellation -- various bug fixes and improvements - -* Tue Mar 5 2013 Daniel Veillard <veillard(a)redhat.com> - 1.0.3-1 -- Introduce virDomainMigrate*CompressionCache APIs -- Introduce virDomainGetJobStats API -- Add basic support for VDI images -- Introduce API virNodeDeviceLookupSCSIHostByWWN -- Various locking improvements -- a lot of bug fixes and overall improvements - -* Wed Jan 30 2013 Daniel Veillard <veillard(a)redhat.com> - 1.0.2-1 -- LXC improvements -- S390 architecture improvement -- Power architecture improvement -- large Coverity report cleanups and associated bug fixes -- virTypedParams* APIs to helps with those data structures -- a lot of bug fixes and overall improvements - -* Fri Nov 2 2012 Daniel Veillard <veillard(a)redhat.com> - 1.0.0-1 -- virNodeGetCPUMap: Define public API -- Add systemd journal support -- Add a qemu capabilities cache manager -- USB migration support -- various improvement and fixes when using QMP QEmu interface -- Support for Xen 4.2 -- Lot of localization enhancements -- a lot of bug fixes, improvements and portability work - -* Mon Sep 24 2012 Daniel Veillard <veillard(a)redhat.com> - 0.10.2-1 -- network: define new API virNetworkUpdate -- add support for QEmu sandbox support -- blockjob: add virDomainBlockCommit -- New APIs to get/set Node memory parameters -- new API virConnectListAllSecrets -- new API virConnectListAllNWFilters -- new API virConnectListAllNodeDevices -- parallels: add support of containers to the driver -- new API virConnectListAllInterfaces -- new API virConnectListAllNetworks -- new API virStoragePoolListAllVolumes -- Add PMSUSPENDED life cycle event -- new API virStorageListAllStoragePools -- Add per-guest S3/S4 state configuration -- qemu: Support for Block Device IO Limits -- a lot of bug fixes, improvements and portability work - -* Fri Aug 31 2012 Daniel Veillard <veillard(a)redhat.com> - 0.10.1-1 -- bugfixes and a brown paper bag - -* Wed Aug 29 2012 Daniel Veillard <veillard(a)redhat.com> - 0.10.0-1 -- agent: add qemuAgentArbitraryCommand() for general qemu agent command -- Introduce virDomainPinEmulator and virDomainGetEmulatorPinInfo functions -- network: use firewalld instead of iptables, when available -- network: make network driver vlan-aware -- esx: Implement network driver -- driver for parallels hypervisor -- Various LXC improvements -- Add virDomainGetHostname -- a lot of bug fixes, improvements and portability work - -* Mon Jul 2 2012 Daniel Veillard <veillard(a)redhat.com> - 0.9.13-1 -- S390: support for s390(x) -- snapshot: implement new APIs for esx and vbox -- snapshot: new query APIs and many improvements -- virsh: Allow users to reedit rejected XML -- nwfilter: add DHCP snooping -- Enable driver modules in libvirt RPM -- Default to enable driver modules for libvirtd -- storage backend: Add RBD (RADOS Block Device) support -- sVirt support for LXC domains inprovement -- a lot of bug fixes, improvements and portability work - -* Mon May 14 2012 Daniel Veillard <veillard(a)redhat.com> - 0.9.12-1 -- qemu: allow snapshotting of sheepdog and rbd disks -- blockjob: add new APIs -- a lot of bug fixes, improvements and portability work - -* Tue Apr 3 2012 Daniel Veillard <veillard(a)redhat.com> - 0.9.11-1 -- Add support for the suspend event -- Add support for event tray moved of removable disks -- qemu: Support numad -- cpustats: API, improvements and qemu support -- qemu: support type='hostdev' network devices at domain start -- Introduce virDomainPMWakeup API -- network: support Open vSwitch -- a number of snapshot improvements -- many improvements and bug fixes - -* Mon Feb 13 2012 Daniel Veillard <veillard(a)redhat.com> - 0.9.10-1 -- Add support for sVirt in the LXC driver -- block rebase: add new API virDomainBlockRebase -- API: Add api to set and get domain metadata -- virDomainGetDiskErrors public API -- conf: add rawio attribute to disk element of domain XML -- Add new public API virDomainGetCPUStats() -- Introduce virDomainPMSuspendForDuration API -- resize: add virStorageVolResize() API -- Add a virt-host-validate command to sanity check HV config -- Add new virDomainShutdownFlags API -- QEMU guest agent support -- many improvements and bug fixes - -* Sat Jan 7 2012 Daniel Veillard <veillard(a)redhat.com> - 0.9.9-1 -- Add API virDomain{S,G}etInterfaceParameters -- Add API virDomain{G, S}etNumaParameters -- Add support for ppc64 qemu -- Support Xen domctl v8 -- many improvements and bug fixes - -* Thu Dec 8 2011 Daniel Veillard <veillard(a)redhat.com> - 0.9.8-1 -- Add support for QEMU 1.0 -- Add preliminary PPC cpu driver -- Add new API virDomain{Set, Get}BlockIoTune -- block_resize: Define the new API -- Add a public API to invoke suspend/resume on the host -- various improvements for LXC containers -- Define keepalive protocol and add virConnectIsAlive API -- Add support for STP and VLAN filtering -- many improvements and bug fixes - -* Tue Nov 8 2011 Daniel Veillard <veillard(a)redhat.com> - 0.9.7-1 -- esx: support vSphere 5.x -- vbox: support for VirtualBox 4.1 -- Introduce the virDomainOpenGraphics API -- Add AHCI support to qemu driver -- snapshot: many improvements and 2 new APIs -- api: Add public api for 'reset' -- many improvements and bug fixes - -* Thu Sep 22 2011 Daniel Veillard <veillard(a)redhat.com> - 0.9.6-1 -- Fix the qemu reboot bug and a few others bug fixes - -* Tue Sep 20 2011 Daniel Veillard <veillard(a)redhat.com> - 0.9.5-1 -- many snapshot improvements (Eric Blake) -- latency: Define new public API and structure (Osier Yang) -- USB2 and various USB improvements (Marc-André Lureau) -- storage: Add fs pool formatting (Osier Yang) -- Add public API for getting migration speed (Jim Fehlig) -- Add basic driver for Microsoft Hyper-V (Matthias Bolte) -- many improvements and bug fixes - -* Wed Aug 3 2011 Daniel Veillard <veillard(a)redhat.com> - 0.9.4-1 -- network bandwidth QoS control -- Add new API virDomainBlockPull* -- save: new API to manipulate save file images -- CPU bandwidth limits support -- allow to send NMI and key event to guests -- new API virDomainUndefineFlags -- Implement code to attach to external QEMU instances -- bios: Add support for SGA -- various missing python binding -- many improvements and bug fixes - -* Mon Jul 4 2011 Daniel Veillard <veillard(a)redhat.com> - 0.9.3-1 -- new API virDomainGetVcpupinInfo -- Add TXT record support for virtual DNS service -- Support reboots with the QEMU driver -- New API virDomainGetControlInfo API -- New API virNodeGetMemoryStats -- New API virNodeGetCPUTime -- New API for send-key -- New API virDomainPinVcpuFlags -- support multifunction PCI device -- lxc: various improvements -- many improvements and bug fixes - -* Mon Jun 6 2011 Daniel Veillard <veillard(a)redhat.com> - 0.9.2-1 -- Framework for lock manager plugins -- API for network config change transactions -- flags for setting memory parameters -- virDomainGetState public API -- qemu: allow blkstat/blkinfo calls during migration -- Introduce migration v3 API -- Defining the Screenshot public API -- public API for NMI injection -- Various improvements and bug fixes - -* Thu May 5 2011 Daniel Veillard <veillard(a)redhat.com> - 0.9.1-1 -- support various persistent domain updates -- improvements on memory APIs -- Add virDomainEventRebootNew -- various improvements to libxl driver -- Spice: support audio, images and stream compression -- Various improvements and bug fixes - -* Mon Apr 4 2011 Daniel Veillard <veillard(a)redhat.com> - 0.9.0-1 -- Support cputune cpu usage tuning -- Add public APIs for storage volume upload/download -- Add public API for setting migration speed on the fly -- Add libxenlight driver -- qemu: support migration to fd -- libvirt: add virDomain{Get,Set}BlkioParameters -- setmem: introduce a new libvirt API (virDomainSetMemoryFlags) -- Expose event loop implementation as a public API -- Dump the debug buffer to libvirtd.log on fatal signal -- Audit support -- Various improvements and bug fixes - -* Thu Feb 17 2011 Daniel Veillard <veillard(a)redhat.com> - 0.8.8-1 -- expose new API for sysinfo extraction -- cgroup blkio weight support -- smartcard device support -- qemu: Support per-device boot ordering -- Various improvements and bug fixes - -* Tue Jan 4 2011 Daniel Veillard <veillard(a)redhat.com> - 0.8.7-1 -- Preliminary support for VirtualBox 4.0 -- IPv6 support -- Add VMware Workstation and Player driver driver -- Add network disk support -- Various improvements and bug fixes - -* Tue Nov 30 2010 Daniel Veillard <veillard(a)redhat.com> - 0.8.6-1 -- Add support for iSCSI target auto-discovery -- QED: Basic support for QED images -- remote console support -- support for SPICE graphics -- sysinfo and VMBIOS support -- virsh qemu-monitor-command -- various improvements and bug fixes - -* Fri Oct 29 2010 Daniel Veillard <veillard(a)redhat.com> - 0.8.5-1 -- Enable JSON and netdev features in QEMU >= 0.13 -- framework for auditing integration -- framework DTrace/SystemTap integration -- Setting the number of vcpu at boot -- Enable support for nested SVM -- Virtio plan9fs filesystem QEMU -- Memory parameter controls -- various improvements and bug fixes - -* Fri Sep 10 2010 Daniel Veillard <veillard(a)redhat.com> - 0.8.4-1 -- big improvements to UML driver -- various improvements and bug fixes - -* Wed Aug 4 2010 Daniel Veillard <veillard(a)redhat.com> - 0.8.3-1 -- esx: Support vSphere 4.1 -- Qemu arbitrary monitor commands -- Qemu Monitor API entry point -- various improvements and bug fixes - -* Mon Jul 5 2010 Daniel Veillard <veillard(a)redhat.com> - 0.8.2-1 -- phyp: adding support for IVM -- libvirt: introduce domainCreateWithFlags API -- add 802.1Qbh and 802.1Qbg switches handling -- Support for VirtualBox version 3.2 -- Init script for handling guests on shutdown/boot -- qemu: live migration with non-shared storage for kvm - -* Fri Apr 30 2010 Daniel Veillard <veillard(a)redhat.com> - 0.8.1-1 -- Starts dnsmasq from libvirtd with --dhcp-hostsfile -- Add virDomainGetBlockInfo API to query disk sizing -- a lot of bug fixes and cleanups - -* Mon Apr 12 2010 Daniel Veillard <veillard(a)redhat.com> - 0.8.0-1 -- Snapshotting support (QEmu/VBox/ESX) -- Network filtering API -- XenAPI driver -- new APIs for domain events -- Libvirt managed save API -- timer subselection for domain clock -- synchronous hooks -- API to update guest CPU to host CPU -- virDomainUpdateDeviceFlags new API -- migrate max downtime API -- volume wiping API -- and many bug fixes - -* Fri Mar 5 2010 Daniel Veillard <veillard(a)redhat.com> - 0.7.7-1 -- macvtap support -- async job handling -- virtio channel -- computing baseline CPU -- virDomain{Attach,Detach}DeviceFlags -- assorted bug fixes and lots of cleanups - -* Wed Feb 3 2010 Daniel Veillard <veillard(a)redhat.com> - 0.7.6-1 - -* Wed Dec 23 2009 Daniel Veillard <veillard(a)redhat.com> - 0.7.5-1 -- Add new API virDomainMemoryStats -- Public API and domain extension for CPU flags -- vbox: Add support for version 3.1 -- Support QEMU's virtual FAT block device driver -- a lot of fixes - -* Fri Nov 20 2009 Daniel Veillard <veillard(a)redhat.com> - 0.7.3-1 -- udev node device backend -- API to check object properties -- better QEmu monitor processing -- MAC address based port filtering for qemu -- support IPv6 and multiple addresses per interfaces -- a lot of fixes - -* Tue Sep 15 2009 Daniel Veillard <veillard(a)redhat.com> - 0.7.1-1 -- ESX, VBox driver updates -- mutipath support -- support for encrypted (qcow) volume -- compressed save image format for Qemu/KVM -- QEmu host PCI device hotplug support -- configuration of huge pages in guests -- a lot of fixes - -* Wed Aug 5 2009 Daniel Veillard <veillard(a)redhat.com> - 0.7.0-1 -- ESX, VBox3, Power Hypervisor drivers -- new net filesystem glusterfs -- Storage cloning for LVM and Disk backends -- interface implementation based on netcf -- Support cgroups in QEMU driver -- QEmu hotplug NIC support -- a lot of fixes - -* Fri Jul 3 2009 Daniel Veillard <veillard(a)redhat.com> - 0.6.5-1 -- release of 0.6.5 - -* Fri May 29 2009 Daniel Veillard <veillard(a)redhat.com> - 0.6.4-1 -- release of 0.6.4 -- various new APIs - -* Fri Apr 24 2009 Daniel Veillard <veillard(a)redhat.com> - 0.6.3-1 -- release of 0.6.3 -- VirtualBox driver - -* Fri Apr 3 2009 Daniel Veillard <veillard(a)redhat.com> - 0.6.2-1 -- release of 0.6.2 - -* Wed Mar 4 2009 Daniel Veillard <veillard(a)redhat.com> - 0.6.1-1 -- release of 0.6.1 - -* Sat Jan 31 2009 Daniel Veillard <veillard(a)redhat.com> - 0.6.0-1 -- release of 0.6.0 - -* Tue Nov 25 2008 Daniel Veillard <veillard(a)redhat.com> - 0.5.0-1 -- release of 0.5.0 - -* Tue Sep 23 2008 Daniel Veillard <veillard(a)redhat.com> - 0.4.6-1 -- release of 0.4.6 - -* Mon Sep 8 2008 Daniel Veillard <veillard(a)redhat.com> - 0.4.5-1 -- release of 0.4.5 - -* Wed Jun 25 2008 Daniel Veillard <veillard(a)redhat.com> - 0.4.4-1 -- release of 0.4.4 -- mostly a few bug fixes from 0.4.3 - -* Thu Jun 12 2008 Daniel Veillard <veillard(a)redhat.com> - 0.4.3-1 -- release of 0.4.3 -- lots of bug fixes and small improvements - -* Tue Apr 8 2008 Daniel Veillard <veillard(a)redhat.com> - 0.4.2-1 -- release of 0.4.2 -- lots of bug fixes and small improvements - -* Mon Mar 3 2008 Daniel Veillard <veillard(a)redhat.com> - 0.4.1-1 -- Release of 0.4.1 -- Storage APIs -- xenner support -- lots of assorted improvements, bugfixes and cleanups -- documentation and localization improvements - -* Tue Dec 18 2007 Daniel Veillard <veillard(a)redhat.com> - 0.4.0-1 -- Release of 0.4.0 -- SASL based authentication -- PolicyKit authentication -- improved NUMA and statistics support -- lots of assorted improvements, bugfixes and cleanups -- documentation and localization improvements - -* Sun Sep 30 2007 Daniel Veillard <veillard(a)redhat.com> - 0.3.3-1 -- Release of 0.3.3 -- Avahi support -- NUMA support -- lots of assorted improvements, bugfixes and cleanups -- documentation and localization improvements - -* Tue Aug 21 2007 Daniel Veillard <veillard(a)redhat.com> - 0.3.2-1 -- Release of 0.3.2 -- API for domains migration -- APIs for collecting statistics on disks and interfaces -- lots of assorted bugfixes and cleanups -- documentation and localization improvements - -* Tue Jul 24 2007 Daniel Veillard <veillard(a)redhat.com> - 0.3.1-1 -- Release of 0.3.1 -- localtime clock support -- PS/2 and USB input devices -- lots of assorted bugfixes and cleanups -- documentation and localization improvements - -* Mon Jul 9 2007 Daniel Veillard <veillard(a)redhat.com> - 0.3.0-1 -- Release of 0.3.0 -- Secure remote access support -- unification of daemons -- lots of assorted bugfixes and cleanups -- documentation and localization improvements - -* Fri Jun 8 2007 Daniel Veillard <veillard(a)redhat.com> - 0.2.3-1 -- Release of 0.2.3 -- lot of assorted bugfixes and cleanups -- support for Xen-3.1 -- new scheduler API - -* Tue Apr 17 2007 Daniel Veillard <veillard(a)redhat.com> - 0.2.2-1 -- Release of 0.2.2 -- lot of assorted bugfixes and cleanups -- preparing for Xen-3.0.5 - -* Thu Mar 22 2007 Jeremy Katz <katzj(a)redhat.com> - 0.2.1-2.fc7 -- don't require xen; we don't need the daemon and can control non-xen now -- fix scriptlet error (need to own more directories) -- update description text - -* Fri Mar 16 2007 Daniel Veillard <veillard(a)redhat.com> - 0.2.1-1 -- Release of 0.2.1 -- lot of bug and portability fixes -- Add support for network autostart and init scripts -- New API to detect the virtualization capabilities of a host -- Documentation updates - -* Fri Feb 23 2007 Daniel P. Berrange <berrange(a)redhat.com> - 0.2.0-4.fc7 -- Fix loading of guest & network configs - -* Fri Feb 16 2007 Daniel P. Berrange <berrange(a)redhat.com> - 0.2.0-3.fc7 -- Disable kqemu support since its not in Fedora qemu binary -- Fix for -vnc arg syntax change in 0.9.0 QEMU - -* Thu Feb 15 2007 Daniel P. Berrange <berrange(a)redhat.com> - 0.2.0-2.fc7 -- Fixed path to qemu daemon for autostart -- Fixed generation of <features> block in XML -- Pre-create config directory at startup - -* Wed Feb 14 2007 Daniel Veillard <veillard(a)redhat.com> 0.2.0-1.fc7 -- support for KVM and QEmu -- support for network configuration -- assorted fixes - -* Mon Jan 22 2007 Daniel Veillard <veillard(a)redhat.com> 0.1.11-1.fc7 -- finish inactive Xen domains support -- memory leak fix -- RelaxNG schemas for XML configs - -* Wed Dec 20 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.10-1.fc7 -- support for inactive Xen domains -- improved support for Xen display and vnc -- a few bug fixes -- localization updates - -* Thu Dec 7 2006 Jeremy Katz <katzj(a)redhat.com> - 0.1.9-2 -- rebuild against python 2.5 - -* Wed Nov 29 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.9-1 -- better error reporting -- python bindings fixes and extensions -- add support for shareable drives -- add support for non-bridge style networking -- hot plug device support -- added support for inactive domains -- API to dump core of domains -- various bug fixes, cleanups and improvements -- updated the localization - -* Tue Nov 7 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.8-3 -- it's pkgconfig not pgkconfig ! - -* Mon Nov 6 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.8-2 -- fixing spec file, added %%dist, -devel requires pkgconfig and xen-devel -- Resolves: rhbz#202320 - -* Mon Oct 16 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.8-1 -- fix missing page size detection code for ia64 -- fix mlock size when getting domain info list from hypervisor -- vcpu number initialization -- don't label crashed domains as shut off -- fix virsh man page -- blktapdd support for alternate drivers like blktap -- memory leak fixes (xend interface and XML parsing) -- compile fix -- mlock/munlock size fixes - -* Fri Sep 22 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.7-1 -- Fix bug when running against xen-3.0.3 hypercalls -- Fix memory bug when getting vcpus info from xend - -* Fri Sep 22 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.6-1 -- Support for localization -- Support for new Xen-3.0.3 cdrom and disk configuration -- Support for setting VNC port -- Fix bug when running against xen-3.0.2 hypercalls -- Fix reconnection problem when talking directly to http xend - -* Tue Sep 5 2006 Jeremy Katz <katzj(a)redhat.com> - 0.1.5-3 -- patch from danpb to support new-format cd devices for HVM guests - -* Tue Sep 5 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.5-2 -- reactivating ia64 support - -* Tue Sep 5 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.5-1 -- new release -- bug fixes -- support for new hypervisor calls -- early code for config files and defined domains - -* Mon Sep 4 2006 Daniel Berrange <berrange(a)redhat.com> - 0.1.4-5 -- add patch to address dom0_ops API breakage in Xen 3.0.3 tree - -* Mon Aug 28 2006 Jeremy Katz <katzj(a)redhat.com> - 0.1.4-4 -- add patch to support paravirt framebuffer in Xen - -* Mon Aug 21 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.4-3 -- another patch to fix network handling in non-HVM guests - -* Thu Aug 17 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.4-2 -- patch to fix virParseUUID() - -* Wed Aug 16 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.4-1 -- vCPUs and affinity support -- more complete XML, console and boot options -- specific features support -- enforced read-only connections -- various improvements, bug fixes - -* Wed Aug 2 2006 Jeremy Katz <katzj(a)redhat.com> - 0.1.3-6 -- add patch from pvetere to allow getting uuid from libvirt - -* Wed Aug 2 2006 Jeremy Katz <katzj(a)redhat.com> - 0.1.3-5 -- build on ia64 now - -* Thu Jul 27 2006 Jeremy Katz <katzj(a)redhat.com> - 0.1.3-4 -- don't BR xen, we just need xen-devel - -* Thu Jul 27 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.3-3 -- need rebuild since libxenstore is now versionned - -* Mon Jul 24 2006 Mark McLoughlin <markmc(a)redhat.com> - 0.1.3-2 -- Add BuildRequires: xen-devel - -* Wed Jul 12 2006 Jesse Keating <jkeating(a)redhat.com> - 0.1.3-1.1 -- rebuild - -* Tue Jul 11 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.3-1 -- support for HVM Xen guests -- various bugfixes - -* Mon Jul 3 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.2-1 -- added a proxy mechanism for read only access using httpu -- fixed header includes paths - -* Wed Jun 21 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.1-1 -- extend and cleanup the driver infrastructure and code -- python examples -- extend uuid support -- bug fixes, buffer handling cleanups -- support for new Xen hypervisor API -- test driver for unit testing -- virsh --conect argument - -* Mon Apr 10 2006 Daniel Veillard <veillard(a)redhat.com> 0.1.0-1 -- various fixes -- new APIs: for Node information and Reboot -- virsh improvements and extensions -- documentation updates and man page -- enhancement and fixes of the XML description format - -* Tue Feb 28 2006 Daniel Veillard <veillard(a)redhat.com> 0.0.6-1 -- added error handling APIs -- small bug fixes -- improve python bindings -- augment documentation and regression tests - -* Thu Feb 23 2006 Daniel Veillard <veillard(a)redhat.com> 0.0.5-1 -- new domain creation API -- new UUID based APIs -- more tests, documentation, devhelp -- bug fixes - -* Fri Feb 10 2006 Daniel Veillard <veillard(a)redhat.com> 0.0.4-1 -- fixes some problems in 0.0.3 due to the change of names - -* Wed Feb 8 2006 Daniel Veillard <veillard(a)redhat.com> 0.0.3-1 -- changed library name to libvirt from libvir, complete and test the python - bindings - -* Sun Jan 29 2006 Daniel Veillard <veillard(a)redhat.com> 0.0.2-1 -- upstream release of 0.0.2, use xend, save and restore added, python bindings - fixed - -* Wed Nov 2 2005 Daniel Veillard <veillard(a)redhat.com> 0.0.1-1 -- created -- 2.5.5

2 1

[libvirt] [PATCH 0/2] virsh: Properly handle detach-interface --live --config.
by Nitesh Konkar 04 May '16

04 May '16

The virsh attach virsh detach interface command fails when both live and config are set and when the interface gets attached to different pci slots on live and config xml respectively. When we attach an interface with both --live and --config, the first time they get the same PCI slots, but the second time onwards it differs and hence the virsh detach-interface --live --config command fails. This patch makes sure that when both --live --config are set , qemuDomainDetachDeviceFlags is called twice, once with config xml and once with live xml. Steps to see the issue: virsh attach-interface --domain DomainName --type network --source default --mac 52:54:00:4b:76:5f --live --config virsh detach-interface --domain DomainName --type network --mac 52:54:00:4b:76:5f --live --config virsh attach-interface --domain DomainName --type network --source default --mac 52:54:00:4b:76:5f --live --config virsh detach-interface --domain DomainName --type network --mac 52:54:00:4b:76:5f --live --config Nitesh Konkar (2): virsh: Introduce virshDomainDetachInterface function virsh: Pass the correct live/config xml to virshDomainDetachInterface tools/virsh-domain.c | 128 +++++++++++++++++++++++++++++---------------------- 1 file changed, 73 insertions(+), 55 deletions(-) -- 1.8.3.1

2 5

[libvirt] [PATCH v2] bhyve: implement domainShutdown
by Roman Bogorodskiy 04 May '16

04 May '16

Bhyve supports ACPI shutdown by issuing SIGTERM signal to the bhyve process. Add the bhyveDomainShutdown() function and virBhyveProcessShutdown() helper function that just sends SIGTERM to VM's bhyve process. If a guest supports ACPI shutdown then process will be terminated and this event will be noticed by the bhyve monitor code that will handle setting proper status and clean up VM's resources. Also, remove usage of virProcessKillPainfully() from domainDestroy. First, it sends SIGTERM to the process that actually triggers ACPI reset and that's not we want to do. Second, we're doing bhyvectl --destroy later and it kills bhyve process, so there's no need to manually kill it. --- Changes from v1: - Sending SIGKILL dropped completely for destroy due to reasons described in the commit message. This is mainly based on the results of this (ongoing) discussion: https://lists.freebsd.org/pipermail/freebsd-virtualization/2016-April/00434… src/bhyve/bhyve_driver.c | 27 +++++++++++++++++++++++++++ src/bhyve/bhyve_process.c | 39 +++++++++++++++++++++++++++------------ src/bhyve/bhyve_process.h | 2 ++ 3 files changed, 56 insertions(+), 12 deletions(-) diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index 5526bb0..4fc504e 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@ -1018,6 +1018,32 @@ bhyveDomainDestroy(virDomainPtr dom) } static int +bhyveDomainShutdown(virDomainPtr dom) +{ + virDomainObjPtr vm; + int ret = -1; + + if (!(vm = bhyveDomObjFromDomain(dom))) + goto cleanup; + + if (virDomainShutdownEnsureACL(dom->conn, vm->def) < 0) + goto cleanup; + + if (!virDomainObjIsActive(vm)) { + virReportError(VIR_ERR_OPERATION_INVALID, + "%s", _("Domain is not running")); + goto cleanup; + } + + ret = virBhyveProcessShutdown(vm); + + cleanup: + if (vm) + virObjectUnlock(vm); + return ret; +} + +static int bhyveDomainOpenConsole(virDomainPtr dom, const char *dev_name ATTRIBUTE_UNUSED, virStreamPtr st, @@ -1502,6 +1528,7 @@ static virHypervisorDriver bhyveHypervisorDriver = { .domainCreateWithFlags = bhyveDomainCreateWithFlags, /* 1.2.3 */ .domainCreateXML = bhyveDomainCreateXML, /* 1.2.4 */ .domainDestroy = bhyveDomainDestroy, /* 1.2.2 */ + .domainShutdown = bhyveDomainShutdown, /* 1.3.3 */ .domainLookupByUUID = bhyveDomainLookupByUUID, /* 1.2.2 */ .domainLookupByName = bhyveDomainLookupByName, /* 1.2.2 */ .domainLookupByID = bhyveDomainLookupByID, /* 1.2.3 */ diff --git a/src/bhyve/bhyve_process.c b/src/bhyve/bhyve_process.c index 14588a9..e42ed74 100644 --- a/src/bhyve/bhyve_process.c +++ b/src/bhyve/bhyve_process.c @@ -281,23 +281,15 @@ virBhyveProcessStop(bhyveConnPtr driver, if ((priv != NULL) && (priv->mon != NULL)) bhyveMonitorClose(priv->mon); - /* First, try to kill 'bhyve' process */ - if (virProcessKillPainfully(vm->pid, true) != 0) - VIR_WARN("Failed to gracefully stop bhyve VM '%s' (pid: %d)", - vm->def->name, - (int)vm->pid); - - /* Cleanup network interfaces */ - bhyveNetCleanup(vm); - - /* No matter if shutdown was successful or not, we - * need to unload the VM */ if (!(cmd = virBhyveProcessBuildDestroyCmd(driver, vm->def))) - goto cleanup; + return -1; if (virCommandRun(cmd, NULL) < 0) goto cleanup; + /* Cleanup network interfaces */ + bhyveNetCleanup(vm); + ret = 0; virCloseCallbacksUnset(driver->closeCallbacks, vm, @@ -317,6 +309,29 @@ virBhyveProcessStop(bhyveConnPtr driver, } int +virBhyveProcessShutdown(virDomainObjPtr vm) +{ + if (vm->pid <= 0) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Invalid PID %d for VM"), + (int)vm->pid); + return -1; + } + + /* Bhyve tries to perform ACPI shutdown when it receives + * SIGTERM signal. So we just issue SIGTERM here and rely + * on the bhyve monitor to clean things up if process disappears. + */ + if (virProcessKill(vm->pid, SIGTERM) != 0) { + VIR_WARN("Failed to terminate bhyve process for VM '%s': %s", + vm->def->name, virGetLastErrorMessage()); + return -1; + } + + return 0; +} + +int virBhyveGetDomainTotalCpuStats(virDomainObjPtr vm, unsigned long long *cpustats) { diff --git a/src/bhyve/bhyve_process.h b/src/bhyve/bhyve_process.h index cfa80af..ebabe17 100644 --- a/src/bhyve/bhyve_process.h +++ b/src/bhyve/bhyve_process.h @@ -34,6 +34,8 @@ int virBhyveProcessStop(bhyveConnPtr driver, virDomainObjPtr vm, virDomainShutoffReason reason); +int virBhyveProcessShutdown(virDomainObjPtr vm); + int virBhyveGetDomainTotalCpuStats(virDomainObjPtr vm, unsigned long long *cpustats); -- 2.7.4

2 3

Re: [libvirt] [PATCHv2] virsh: blkdeviotune: accept human readable values for bytes
by Nitesh Konkar 04 May '16

04 May '16

Hello Nishith, Just a small suggestion on the indentation part of the patch. I think your indentation is off by 1 space. Thanks, Nitesh Konkar. On Wed, May 4, 2016 at 8:22 PM, Nitesh Konkar < niteshkonkar.libvirt(a)gmail.com> wrote: > Hello Nishith, > > Just a small suggestion on the indentation part of the patch. I think your > indentation is off by 1 space. > > Thanks, > Nitesh Konkar. > > > On Wed, May 4, 2016 at 7:55 PM, Nishith Shah <nishithshah.2211(a)gmail.com> > wrote: > >> Use vshCommandOptScaledInt instead of vshCommandOptULongLong so that >> values with suffixes can be passed when bytes are being passed along. >> Values for the iops parameters still need to be given in the absolute >> form as they are not bytes but numbers. Please refer to the bug link >> https://bugzilla.redhat.com/show_bug.cgi?id=885380 which can be closed. >> >> Signed-off-by: Nishith Shah <nishithshah.2211(a)gmail.com> >> --- >> tools/virsh-domain.c | 24 ++++++++++++------------ >> tools/virsh.pod | 18 ++++++++++++------ >> 2 files changed, 24 insertions(+), 18 deletions(-) >> >> diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c >> index 0a6caae..336a65f 100644 >> --- a/tools/virsh-domain.c >> +++ b/tools/virsh-domain.c >> @@ -1164,7 +1164,7 @@ static const vshCmdOptDef opts_blkdeviotune[] = { >> }, >> {.name = "total-bytes-sec", >> .type = VSH_OT_INT, >> - .help = N_("total throughput limit in bytes per second") >> + .help = N_("total throughput limit, as scaled integer (default >> bytes)") >> }, >> {.name = "read_bytes_sec", >> .type = VSH_OT_ALIAS, >> @@ -1172,7 +1172,7 @@ static const vshCmdOptDef opts_blkdeviotune[] = { >> }, >> {.name = "read-bytes-sec", >> .type = VSH_OT_INT, >> - .help = N_("read throughput limit in bytes per second") >> + .help = N_("read throughput limit, as scaled integer (default >> bytes)") >> }, >> {.name = "write_bytes_sec", >> .type = VSH_OT_ALIAS, >> @@ -1180,7 +1180,7 @@ static const vshCmdOptDef opts_blkdeviotune[] = { >> }, >> {.name = "write-bytes-sec", >> .type = VSH_OT_INT, >> - .help = N_("write throughput limit in bytes per second") >> + .help = N_("write throughput limit, as scaled integer (default >> bytes)") >> }, >> {.name = "total_iops_sec", >> .type = VSH_OT_ALIAS, >> @@ -1212,7 +1212,7 @@ static const vshCmdOptDef opts_blkdeviotune[] = { >> }, >> {.name = "total-bytes-sec-max", >> .type = VSH_OT_INT, >> - .help = N_("total max in bytes") >> + .help = N_("total max, as scaled integer (default bytes)") >> }, >> {.name = "read_bytes_sec_max", >> .type = VSH_OT_ALIAS, >> @@ -1220,7 +1220,7 @@ static const vshCmdOptDef opts_blkdeviotune[] = { >> }, >> {.name = "read-bytes-sec-max", >> .type = VSH_OT_INT, >> - .help = N_("read max in bytes") >> + .help = N_("read max, as scaled integer (default bytes)") >> }, >> {.name = "write_bytes_sec_max", >> .type = VSH_OT_ALIAS, >> @@ -1228,7 +1228,7 @@ static const vshCmdOptDef opts_blkdeviotune[] = { >> }, >> {.name = "write-bytes-sec-max", >> .type = VSH_OT_INT, >> - .help = N_("write max in bytes") >> + .help = N_("write max, as scaled integer (default bytes)") >> }, >> {.name = "total_iops_sec_max", >> .type = VSH_OT_ALIAS, >> @@ -1299,7 +1299,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) >> if (vshCommandOptStringReq(ctl, cmd, "device", &disk) < 0) >> goto cleanup; >> >> - if ((rv = vshCommandOptULongLong(ctl, cmd, "total-bytes-sec", >> &value)) < 0) { >> + if ((rv = vshCommandOptScaledInt(ctl, cmd, "total-bytes-sec", >> &value, 1, ULLONG_MAX)) < 0) { >> goto interror; >> } else if (rv > 0) { >> if (virTypedParamsAddULLong(&params, &nparams, &maxparams, >> @@ -1308,7 +1308,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) >> goto save_error; >> } >> >> - if ((rv = vshCommandOptULongLong(ctl, cmd, "read-bytes-sec", >> &value)) < 0) { >> + if ((rv = vshCommandOptScaledInt(ctl, cmd, "read-bytes-sec", &value, >> 1, ULLONG_MAX)) < 0) { >> goto interror; >> } else if (rv > 0) { >> if (virTypedParamsAddULLong(&params, &nparams, &maxparams, >> @@ -1317,7 +1317,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) >> goto save_error; >> } >> >> - if ((rv = vshCommandOptULongLong(ctl, cmd, "write-bytes-sec", >> &value)) < 0) { >> + if ((rv = vshCommandOptScaledInt(ctl, cmd, "write-bytes-sec", >> &value, 1, ULLONG_MAX)) < 0) { >> goto interror; >> } else if (rv > 0) { >> if (virTypedParamsAddULLong(&params, &nparams, &maxparams, >> @@ -1326,7 +1326,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) >> goto save_error; >> } >> >> - if ((rv = vshCommandOptULongLong(ctl, cmd, "total-bytes-sec-max", >> &value)) < 0) { >> + if ((rv = vshCommandOptScaledInt(ctl, cmd, "total-bytes-sec-max", >> &value, 1, ULLONG_MAX)) < 0) { >> goto interror; >> } else if (rv > 0) { >> if (virTypedParamsAddULLong(&params, &nparams, &maxparams, >> @@ -1335,7 +1335,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) >> goto save_error; >> } >> >> - if ((rv = vshCommandOptULongLong(ctl, cmd, "read-bytes-sec-max", >> &value)) < 0) { >> + if ((rv = vshCommandOptScaledInt(ctl, cmd, "read-bytes-sec-max", >> &value, 1, ULLONG_MAX)) < 0) { >> goto interror; >> } else if (rv > 0) { >> if (virTypedParamsAddULLong(&params, &nparams, &maxparams, >> @@ -1344,7 +1344,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) >> goto save_error; >> } >> >> - if ((rv = vshCommandOptULongLong(ctl, cmd, "write-bytes-sec-max", >> &value)) < 0) { >> + if ((rv = vshCommandOptScaledInt(ctl, cmd, "write-bytes-sec-max", >> &value, 1, ULLONG_MAX)) < 0) { >> goto interror; >> } else if (rv > 0) { >> if (virTypedParamsAddULLong(&params, &nparams, &maxparams, >> diff --git a/tools/virsh.pod b/tools/virsh.pod >> index 2a95df7..6844823 100644 >> --- a/tools/virsh.pod >> +++ b/tools/virsh.pod >> @@ -1097,15 +1097,21 @@ I<domain> (see also B<domblklist> for listing >> these names). >> >> If no limit is specified, it will query current I/O limits setting. >> Otherwise, alter the limits with these flags: >> -I<--total-bytes-sec> specifies total throughput limit in bytes per >> second. >> -I<--read-bytes-sec> specifies read throughput limit in bytes per second. >> -I<--write-bytes-sec> specifies write throughput limit in bytes per >> second. >> +I<--total-bytes-sec> specifies total throughput limit as a scaled >> integer, the >> +default being bytes per second if no suffix is specified. >> +I<--read-bytes-sec> specifies read throughput limit as a scaled integer, >> the >> +default being bytes per second if no suffix is specified. >> +I<--write-bytes-sec> specifies write throughput limit as a scaled >> integer, the >> +default being bytes per second if no suffix is specified. >> I<--total-iops-sec> specifies total I/O operations limit per second. >> I<--read-iops-sec> specifies read I/O operations limit per second. >> I<--write-iops-sec> specifies write I/O operations limit per second. >> -I<--total-bytes-sec-max> specifies maximum total throughput limit in >> bytes per second. >> -I<--read-bytes-sec-max> specifies maximum read throughput limit in bytes >> per second. >> -I<--write-bytes-sec-max> specifies maximum write throughput limit in >> bytes per second. >> +I<--total-bytes-sec-max> specifies maximum total throughput limit as a >> scaled >> +integer, the default being bytes per second if no suffix is specified >> +I<--read-bytes-sec-max> specifies maximum read throughput limit as a >> scaled >> +integer, the default being bytes per second if no suffix is specified. >> +I<--write-bytes-sec-max> specifies maximum write throughput limit as a >> scaled >> +integer, the default being bytes per second if no suffix is specified. >> I<--total-iops-sec-max> specifies maximum total I/O operations limit per >> second. >> I<--read-iops-sec-max> specifies maximum read I/O operations limit per >> second. >> I<--write-iops-sec-max> specifies maximum write I/O operations limit per >> second. >> -- >> 2.1.4 >> >> -- >> libvir-list mailing list >> libvir-list(a)redhat.com >> https://www.redhat.com/mailman/listinfo/libvir-list >> > >

3 3

[libvirt] [PATCH] admin: Add a check to reject negative argument for number of typed params
by Erik Skultety 04 May '16

04 May '16

Since nparams can be technically negative, it is a good practice throughout our code to check if nparams actually has a non-negative value. The same effect would be achieved by converting our internal typed params serializer argument to 'unsigned' type, but it definitely would not be the path of least resistance. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- src/libvirt-admin.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libvirt-admin.c b/src/libvirt-admin.c index a94f5dd..4ad816b 100644 --- a/src/libvirt-admin.c +++ b/src/libvirt-admin.c @@ -838,6 +838,7 @@ virAdmServerSetThreadPoolParameters(virAdmServerPtr srv, virCheckAdmServerReturn(srv, -1); virCheckNonNullArgGoto(params, error); + virCheckNonNegativeArgGoto(nparams, error); if (remoteAdminServerSetThreadPoolParameters(srv, params, nparams, flags) < 0) -- 2.4.11

2 2

[libvirt] [PATCH 0/4] virt-host-validate: add s390 support
by Bjoern Walk 04 May '16

04 May '16

This patch series adds support to the s390 platform for the virt-host-validate tool which detects virtualization capabilities of the host. It has been tested on x86 that no regression is introduced. Bjoern Walk (4): tools: virt-host-validate: fix missing translation marker tools: virt-host-validate: fix CPU flag detection tools: virt-host-validate: improve error handling tools: virt-host-validate: HW virt support on s390 tools/virt-host-validate-common.c | 12 +++++++----- tools/virt-host-validate-common.h | 1 + tools/virt-host-validate-qemu.c | 31 ++++++++++++++++++++++++------- 3 files changed, 32 insertions(+), 12 deletions(-) -- 2.6.6

2 5

[libvirt] RFC: migration with temporary external snapshot design considerations
by Nikolay Shirokovskiy 04 May '16

04 May '16

Hi, all. The result of "[RFC] live migration of VMs with internal snapshots" discussion is that it is nice to have ability to migrate images with internal snapshots while keeping intact their internal snaphot structure. Current qemu drive mirror functionality drops this structure and it is possible to workaround the issue with the help of taking extenal snapshot on source and then blockcommiting it back on destination after migration. The technique of creating temporary external snapshot could be useful in other cases too. For example in case of migration with disks on non cache coherent shared filesystem AFAIU. Thus I want to consider (and in case it is reasonable implement too) this functionality aside from migration with internal snapshots task where we have another issue of moving snapshot metadata to destination. The whole topic of design comes from the fact that blockcommit can fail. The fail itself is not a problem as AFAIK commiting active image does not invalidate it and can be restarted later. So the question is to when and how handle it. This can happen on source when we rollback after unsuccessfull migration or on destination as on finish phase in case of blockcommit fail we can't fail the migration anymore. I see two options. 1. Leave this situation to the mgmt. Thus we need to expose the fact of external snapshot in domain config and somehow signal that mgmt need to take care of situation. Well the fact that we expose this technical snapshot to upper level doubts the whole idea of making the workaround in libvirt itself. 2. Have some kind of background task in libvirt that will try to blockcomit with some policy. Well again, we introduce a policy which is considered to reside in mgmt and introduce background task which makes libvirt mgmt-like too. In anyway we will need to take special care while we have uncommited temporary snapshot. For example if we take internal snapshot at this time then it will be in temporary snapshot and be melted away after temporary snapshot is committed. Other block operations are probably are be affected too in this or another way. We can disable such operations for uncommited temporary snapshot. In case of mgmt managment this is job of mgmt and in case of libvirt managment this should be done in libvirt. All that said I guess the first approach is not the way to go as it fails to archive the goal - hide the details from mgmt layer. As to the second one I'd be glad to hear opinions of the community. Nikolay

1 0

[libvirt] [PATCH 0/3] Admin API: Add support for client disconnect
by Erik Skultety 04 May '16

04 May '16

This series adds a simple support for a client force disconnect. As with the series about client identity retrieval, this series is rebased on listing clients due to some gendispatch stuff needed in all of them. To test it, you checkout my remote branch https://github.com/eskultety/libvirt/tree/list-clients-info-disconnect Erik Skultety (3): admin: Introduce virAdmServerLookupClient admin: Introduce virAdmClientClose API virt-admin: Introduce client-disconnect command daemon/admin.c | 6 ++++ daemon/admin_server.c | 19 +++++++++++ daemon/admin_server.h | 7 ++++ include/libvirt/libvirt-admin.h | 7 ++++ include/libvirt/virterror.h | 1 + src/admin/admin_protocol.x | 27 +++++++++++++++- src/admin/admin_remote.c | 10 ++++++ src/admin_protocol-structs | 14 ++++++++ src/libvirt-admin.c | 66 +++++++++++++++++++++++++++++++++++++ src/libvirt_admin_private.syms | 3 ++ src/libvirt_admin_public.syms | 2 ++ src/rpc/virnetserver.c | 23 +++++++++++++ src/rpc/virnetserver.h | 3 ++ src/util/virerror.c | 6 ++++ tools/virt-admin.c | 72 +++++++++++++++++++++++++++++++++++++++++ tools/virt-admin.pod | 16 +++++++++ 16 files changed, 281 insertions(+), 1 deletion(-) -- 2.4.11

2 4

[libvirt] RFC filesystem pool proposal description.
by Olga Krishtal 04 May '16

04 May '16

In this proposal description we would like to introduce a separate pool type:fspool. Fspool provides and manages filesystems. Below are listed possible examples of fspool, depending on source type: volume, directory or network. Volume fspool uses storage pool volume to reside upon. <fspool type = 'volume'> <name>fspool</name> <uuid>cb07b799-8e03-485c-aaa0-7c88f60b37b0</uuid> <allocation>0</allocation> <capacity>0<capacity> <source> <pool ='pool name'/> <volume='volume name'/> <format type = 'ext4'/> (ext4, zfs - depending on type of volume that is used as a backend). <source/> <target> <path>/path/to/fspool</path> <permissions> <mode>0777</mode> <owner>0</owner> <group>0</group> </permissions> </target> </fspool> Directory fspool represents a host directory: <fspool type = 'dir'> <name>fspool</name> <uuid>cb07b799-8e03-485c-aaa0-7c88f60b37b0</uuid> <target> <path>/path/to/fspool/root</path> <permissions> <mode>0777</mode> <owner>0</owner> <group>0</group> </permissions> </target> </fspool> Network fspool is similar to previous one, except it is remote: <fspool type='network'> <name>fspool</name> <uuid>b27a72b5-a92e-4e58-a172-a80ba73b30fe</uuid> <source> <host name='X.X.X.X'/> - if the pool is not on the host <dir path='some/directory/exposed/to/our/host'/> </source> <target> <path>/fspool</path> </target> </fspool> basic API for fspool management: fspool-define fspool-build fspool-start fspool-stop fspool-destroy fspool-undefine Fspools are divided into fs items. Single item is a directory inside the fspool root directory. Fs item example is listed below: <fs> <name>item</name> <allocation>0</allocation> <capacity>0<capacity> <source>fspool='name'</source> <target> <path>/fspool</path> </target> <permissions> <mode>0777</mode> <owner>0</owner> <group>0</group> <cgroups> Limits</cgroups> </permissions> </fs> - allocation/capacity - is omitted when fspools type is directory. - target path is a path to fs item from the fspool root. If it is not present then the content of item is placed directly in fspool root. - cgroups can be used in order to manipulate space usage politics. Fs items will be manipulated via fs API: fs-define fs-delete fs-list In addition to containers use-cases, fspools are also useful for libvirt itself - they will help store and easily manage some internal metadata, such as snapshots or internal connection driver information (logs, domain configurations, etc). Please, take a look and share your opinion. Olga

4 7

[libvirt] [Ceph] blockInfo cannot work with network type disk
by ZhiQiang Fan 04 May '16

04 May '16

Hi devs & users, The Telemetry service of OpenStack, project code name Ceilometer, is using libvirt.domain.blockInfo() to get disk's physical, allocation and capacity information [1]. However, when disk is network type with protocol ceph, the blockInfo() always fail with: libvirtError: internal error: missing storage backend for network files using rbd protocol. [2] After reading some libvirt code, I think it might due to blockInfo() always assume disk is file backend [3], and file backend doesn't support network type [4]. I want to know if such limitation is by design? - If yes, then how should I get the network type disk's physical, allocation and capacity info? - If not, is there any plan to implement it? Thanks! [1] https://github.com/openstack/ceilometer/blob/stable/mitaka/ceilometer/compu… [2] https://bugs.launchpad.net/ceilometer/+bug/1457440 [3] https://github.com/libvirt/libvirt/blob/d6c25c34ef682a69f73f6ec200129e61b29… [4] https://github.com/libvirt/libvirt/blob/d6c25c34ef682a69f73f6ec200129e61b29…

1 0

[libvirt] [PATCH] libvirt.spec: remove duplicate files from -docs package
by Daniel P. Berrange 04 May '16

04 May '16

Previous commit moved some lists out of the -devel package and into the -docs package commit feffcc03a0d3690dcffd860682dcbaa61d726b39 Author: Cole Robinson <crobinso(a)redhat.com> Date: Wed Apr 13 10:37:42 2016 -0400 spec: Only pull in API docs with -devel package What was not realized is that the rule 'libvirt-docs/*' and ' docs/*.html docs/html docs/*.gif' actually point to the exact same content. ie, we had previously included the website HTML in *both* the -docs and -devel packages. So this change ended up listing the files twice, which caused RPM to print a load of warnings: warning: File listed twice: /usr/share/doc/libvirt-docs/html warning: File listed twice: /usr/share/doc/libvirt-docs/html/32favicon.png warning: File listed twice: /usr/share/doc/libvirt-docs/html/404.html warning: File listed twice: /usr/share/doc/libvirt-docs/html/acl.html warning: File listed twice: /usr/share/doc/libvirt-docs/html/aclpolkit.html Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- libvirt.spec.in | 1 - 1 file changed, 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index f441c51..a24be32 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1956,7 +1956,6 @@ exit 0 %defattr(-, root, root) %doc AUTHORS ChangeLog.gz NEWS README TODO %doc libvirt-docs/* -%doc docs/*.html docs/html docs/*.gif # API docs %dir %{_datadir}/gtk-doc/html/libvirt/ -- 2.5.5

2 1

[libvirt] [libvirt-perl][PATCH] Add VIR_ERR_NO_CLIENT constant
by Michal Privoznik 04 May '16

04 May '16

Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Changes | 1 + Virt.xs | 1 + lib/Sys/Virt/Error.pm | 4 ++++ 3 files changed, 6 insertions(+) diff --git a/Changes b/Changes index 106b812..5303c0e 100644 --- a/Changes +++ b/Changes @@ -8,6 +8,7 @@ Revision history for perl module Sys::Virt - Add VIR_STORAGE_VOL_PLOOP constant - Add VIR_MIGRATE_PARAM_COMPRESSION* constants - Add VIR_MIGRATE_PARAM_PERSIST_XML constant + - Add VIR_ERR_NO_CLIENT constant 1.3.3 2016-04-07 diff --git a/Virt.xs b/Virt.xs index b0c3282..d069abd 100644 --- a/Virt.xs +++ b/Virt.xs @@ -8530,4 +8530,5 @@ BOOT: REGISTER_CONSTANT(VIR_ERR_MIGRATE_FINISH_OK, ERR_MIGRATE_FINISH_OK); REGISTER_CONSTANT(VIR_ERR_AUTH_UNAVAILABLE, ERR_AUTH_UNAVAILABLE); REGISTER_CONSTANT(VIR_ERR_NO_SERVER, ERR_NO_SERVER); + REGISTER_CONSTANT(VIR_ERR_NO_CLIENT, ERR_NO_CLIENT); } diff --git a/lib/Sys/Virt/Error.pm b/lib/Sys/Virt/Error.pm index b54f876..db23f1e 100644 --- a/lib/Sys/Virt/Error.pm +++ b/lib/Sys/Virt/Error.pm @@ -792,6 +792,10 @@ Authentication services were not available Libvirt server was not found +=item Sys::Virt::Error::ERR_NO_CLIENT + +Libvirt client was not found + =back =head1 AUTHORS -- 2.8.1

2 1

[libvirt] [PATCH 0/7] Admin API: Add support for client identity info retrieval
by Erik Skultety 04 May '16

04 May '16

This series adds support for client identity retrieval, i.e. information like remote IP (if connected remotely), uid,gid,pid, as well as username if connected locally and also information regarding authentication (if used). The series is rebased on the listing clients series, because it relies on the gendispatch stuff, so for testing purposes checkout my remote branch https://github.com/eskultety/libvirt/tree/list-clients-info-disconnect which also covers the next series about client disconnect. Erik Skultety (7): admin: Introduce virAdmServerLookupClient admin: include: Introduce some client's identity related typed params macros virnetsocket: Provide socket address format in a more standard form virneserverclient: Introduce virNetServerClientHasSASLSession virnetserverclient: Add an internal method to retrieve client's identity admin: Introduce virAdmClientGetInfo API virt-admin: Introduce command client-info daemon/admin.c | 59 ++++++++++++++++++ daemon/admin_server.c | 102 +++++++++++++++++++++++++++++++ daemon/admin_server.h | 9 +++ daemon/remote.c | 13 +++- include/libvirt/libvirt-admin.h | 130 ++++++++++++++++++++++++++++++++++++++++ include/libvirt/virterror.h | 1 + src/admin/admin_protocol.x | 34 ++++++++++- src/admin/admin_remote.c | 47 +++++++++++++++ src/admin_protocol-structs | 20 +++++++ src/libvirt-admin.c | 75 +++++++++++++++++++++++ src/libvirt_admin_private.syms | 4 ++ src/libvirt_admin_public.syms | 2 + src/remote/remote_driver.c | 7 +++ src/rpc/virnetclient.c | 10 ++++ src/rpc/virnetclient.h | 2 + src/rpc/virnetserver.c | 23 +++++++ src/rpc/virnetserver.h | 3 + src/rpc/virnetserverclient.c | 48 +++++++++++++++ src/rpc/virnetserverclient.h | 6 ++ src/rpc/virnetsocket.c | 17 +++++- src/rpc/virnetsocket.h | 2 + src/util/virerror.c | 6 ++ src/util/virsocketaddr.c | 24 ++++++-- tests/virnetsockettest.c | 10 ++-- tools/virt-admin.c | 91 ++++++++++++++++++++++++++++ 25 files changed, 731 insertions(+), 14 deletions(-) -- 2.4.11

3 15

[libvirt] [PATCH] daemon: Add VIR_ERR_NO_SERVER and VIR_ERR_NO_CLIENT to daemonErrorLogFilter
by Erik Skultety 04 May '16

04 May '16

Commits 52a2eef9 and 62be5486 forgot to add these errors to daemon's error whitelist, i.e. in order to avoid log file pollution with errors like "Domain not found" or "Server not found" in this case, since these events are valid and expected to occur. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- Pushed under trivial rule. daemon/libvirtd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index f0fdaed..cc5190f 100644 --- a/daemon/libvirtd.c +++ b/daemon/libvirtd.c @@ -333,6 +333,8 @@ static int daemonErrorLogFilter(virErrorPtr err, int priority) case VIR_ERR_NO_DOMAIN_SNAPSHOT: case VIR_ERR_OPERATION_INVALID: case VIR_ERR_NO_DOMAIN_METADATA: + case VIR_ERR_NO_SERVER: + case VIR_ERR_NO_CLIENT: return VIR_LOG_DEBUG; } -- 2.4.11

1 0

[libvirt] [PATCH v2] send default USB controller in xml to destination during migration
by Shivaprasad G Bhat 04 May '16

04 May '16

The default USB controller is not sent to destination as the older versions of libvirt(0.9.4 or earlier as I see in commit log of 409b5f54) didn't support them. For some archs where the support started much later can safely send the USB controllers without this worry. So, send the controller to destination for all archs except x86. Moreover this is not very applicable to x86 as the USB controller has model ich9_ehci1 on q35 and for pc-i440fx, there cant be any slots before USB as it is fixed on slot 1. The patch fixes a bug that, if the USB controller happens to occupy a slot after disks/interfaces and one of them is hot-unplugged, then the default USB controller added on destination takes the smallest slot number and that would lead to savestate mismatch and migration failure. Seen and verified on PPC64. Signed-off-by: Shivaprasad G Bhat <sbhat(a)linux.vnet.ibm.com> --- src/qemu/qemu_domain.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 6262bfe..963ff35 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -2599,7 +2599,11 @@ qemuDomainDefFormatBuf(virQEMUDriverPtr driver, usb = def->controllers[i]; } } - if (usb && usb->idx == 0 && usb->model == -1) { + /* The original purpose of the check was the migration compatibility + * with libvirt <= 0.9.4. Limitation doesn't apply to other archs + * and can cause problems on PPC64. + */ + if (ARCH_IS_X86(def->os.arch) && usb && usb->idx == 0 && usb->model == -1) { VIR_DEBUG("Removing default USB controller from domain '%s'" " for migration compatibility", def->name); toremove++;

5 5

[libvirt] [PATCH] dist: ln(1) is not guaranteed to have a '-f' option
by Andrea Bolognani 04 May '16

04 May '16

According to the autoconf manual, using '$(LN_S) -f' is not portable; remove the target explicitly beforehand to work around this limitation. Adjust some slightly awkward indentation while at it. --- src/Makefile.am | 3 ++- tools/Makefile.am | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index c639e37..b71e694 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -3079,7 +3079,8 @@ if WITH_NETWORK $(DESTDIR)$(confdir)/qemu/networks/default.xml && \ rm $(DESTDIR)$(confdir)/qemu/networks/default.xml.t; } ( cd $(DESTDIR)$(confdir)/qemu/networks/autostart && \ - $(LN_S) -f ../default.xml default.xml ) + rm -f default.xml && \ + $(LN_S) ../default.xml default.xml ) endif WITH_NETWORK uninstall-local:: uninstall-init uninstall-systemd diff --git a/tools/Makefile.am b/tools/Makefile.am index e963b91..c5a6a0d 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -424,7 +424,8 @@ NSS_SO_VER = 1 install-exec-hook: ( cd $(DESTDIR)$(libdir) && \ - $(LN_S) -f libnss_libvirt.so.$(NSS_SO_VER) nss_libvirt.so.$(NSS_SO_VER) ) + rm -f nss_libvirt.so.$(NSS_SO_VER) && \ + $(LN_S) libnss_libvirt.so.$(NSS_SO_VER) nss_libvirt.so.$(NSS_SO_VER) ) uninstall-local: -rm -f $(DESTDIR)$(libdir)/nss_libvirt.so.$(NSS_SO_VER) -- 2.5.5

3 3

[libvirt] [PATCH v2 0/3] Add support for virtio-scsi-{pci, ccw} iothread support
by John Ferlan 03 May '16

03 May '16

v1 here: http://www.redhat.com/archives/libvir-list/2016-May/msg00077.html (patches 1-4 were pushed already, the following are patches 5-7) Changes: Patch 1: - Clean up docs, use 1.3.5 as the version instead of 1.3.4. - Use post parse callback virDomainDeviceDefPostParseInternal to handle the controller check if iothread's are set on a controller (rather than during Controller Def parsing Patch 2: - Clean up commit message - Use the _() for message - Use 'target' not 'dst' in message (more specific) Patch 3: - No changes John Ferlan (3): conf: Add support for virtio-scsi iothreads qemu: Use switch for qemuCheckIOThreads qemu: Add 'iothread' to command line for supported controller docs/formatdomain.html.in | 21 ++++ docs/schemas/domaincommon.rng | 3 + src/conf/domain_conf.c | 32 +++++- src/conf/domain_conf.h | 1 + src/qemu/qemu_command.c | 115 ++++++++++++++++++--- .../qemuxml2argv-iothreads-virtio-scsi-ccw.args | 28 +++++ .../qemuxml2argv-iothreads-virtio-scsi-ccw.xml | 39 +++++++ .../qemuxml2argv-iothreads-virtio-scsi-pci.args | 32 ++++++ .../qemuxml2argv-iothreads-virtio-scsi-pci.xml | 47 +++++++++ tests/qemuxml2argvtest.c | 6 ++ .../qemuxml2xmlout-iothreads-virtio-scsi-ccw.xml | 40 +++++++ .../qemuxml2xmlout-iothreads-virtio-scsi-pci.xml | 51 +++++++++ tests/qemuxml2xmltest.c | 7 ++ 13 files changed, 409 insertions(+), 13 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-virtio-scsi-ccw.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-virtio-scsi-ccw.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-virtio-scsi-pci.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-virtio-scsi-pci.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-iothreads-virtio-scsi-ccw.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-iothreads-virtio-scsi-pci.xml -- 2.5.5

2 4

[libvirt] [PATCH REPOST 0/7] Add support for virtio-scsi-{pci, ccw} iothread support
by John Ferlan 03 May '16

03 May '16

Repost of : http://www.redhat.com/archives/libvir-list/2016-April/msg01539.html Essentially the same patches as previous, but refreshed to current HEAD of '6620cd1ef'. I did remove patch 5 since it's not necessary. Also had to adjust one test to add the new default panic device for ccw. John Ferlan (7): qemu: Add capability for virtio-scsi iothreads docs: clarify disk iothread support docs: Reformat the Controllers description conf: Move virDomainControllerModelTypeToString conf: Add support for virtio-scsi iothreads qemu: Use switch for qemuCheckIOThreads qemu: Add 'iothread' to command line for supported controller docs/formatdomain.html.in | 87 ++++++--- docs/schemas/domaincommon.rng | 3 + src/conf/domain_conf.c | 54 ++++-- src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 9 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 115 ++++++++++-- tests/qemucapabilitiesdata/caps_1.2.2-1.replies | 80 +++++---- tests/qemucapabilitiesdata/caps_1.3.1-1.replies | 80 +++++---- tests/qemucapabilitiesdata/caps_1.4.2-1.replies | 88 +++++---- tests/qemucapabilitiesdata/caps_1.5.3-1.replies | 88 +++++---- tests/qemucapabilitiesdata/caps_1.6.0-1.replies | 88 +++++---- tests/qemucapabilitiesdata/caps_1.6.50-1.replies | 88 +++++---- tests/qemucapabilitiesdata/caps_2.1.1-1.replies | 88 +++++---- tests/qemucapabilitiesdata/caps_2.4.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.4.0-1.replies | 177 ++++++++++++++---- tests/qemucapabilitiesdata/caps_2.5.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.5.0-1.replies | 197 +++++++++++++++++---- tests/qemucapabilitiesdata/caps_2.6.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.6.0-1.replies | 192 ++++++++++++++++---- .../qemuxml2argv-iothreads-virtio-scsi-ccw.args | 28 +++ .../qemuxml2argv-iothreads-virtio-scsi-ccw.xml | 39 ++++ .../qemuxml2argv-iothreads-virtio-scsi-pci.args | 32 ++++ .../qemuxml2argv-iothreads-virtio-scsi-pci.xml | 47 +++++ tests/qemuxml2argvtest.c | 6 + .../qemuxml2xmlout-iothreads-virtio-scsi-ccw.xml | 40 +++++ .../qemuxml2xmlout-iothreads-virtio-scsi-pci.xml | 51 ++++++ tests/qemuxml2xmltest.c | 7 + 28 files changed, 1308 insertions(+), 381 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-virtio-scsi-ccw.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-virtio-scsi-ccw.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-virtio-scsi-pci.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-virtio-scsi-pci.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-iothreads-virtio-scsi-ccw.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-iothreads-virtio-scsi-pci.xml -- 2.5.5

2 21

[libvirt] [PATCH] Allow blkdeviotune to take human readable values
by Nishith Shah 03 May '16

03 May '16

Use vshCommandOptScaledInt instead of vshCommandOptULongLong so there is no need to pass values in raw bytes, which is seldom the case. --- tools/virsh-domain.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 0a6caae..3843675 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -1299,7 +1299,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) if (vshCommandOptStringReq(ctl, cmd, "device", &disk) < 0) goto cleanup; - if ((rv = vshCommandOptULongLong(ctl, cmd, "total-bytes-sec", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "total-bytes-sec", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1308,7 +1308,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "read-bytes-sec", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "read-bytes-sec", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1317,7 +1317,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "write-bytes-sec", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "write-bytes-sec", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1326,7 +1326,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "total-bytes-sec-max", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "total-bytes-sec-max", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1335,7 +1335,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "read-bytes-sec-max", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "read-bytes-sec-max", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1344,7 +1344,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "write-bytes-sec-max", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "write-bytes-sec-max", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1353,7 +1353,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "total-iops-sec", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "total-iops-sec", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1362,7 +1362,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "read-iops-sec", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "read-iops-sec", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1371,7 +1371,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "write-iops-sec", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "write-iops-sec", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1380,7 +1380,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "write-iops-sec-max", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "write-iops-sec-max", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1389,7 +1389,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "read-iops-sec-max", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "read-iops-sec-max", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1398,7 +1398,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "total-iops-sec-max", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "total-iops-sec-max", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1407,7 +1407,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "size-iops-sec", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "size-iops-sec", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, -- 2.1.4

4 6

[libvirt] [PATCH] virsh: volume: Add --bytes to 'vol-info'
by Peter Krempa 03 May '16

03 May '16

--- tools/virsh-volume.c | 23 +++++++++++++++++++---- tools/virsh.pod | 4 +++- 2 files changed, 22 insertions(+), 5 deletions(-) diff --git a/tools/virsh-volume.c b/tools/virsh-volume.c index 9cc8e52..d35fee1 100644 --- a/tools/virsh-volume.c +++ b/tools/virsh-volume.c @@ -992,6 +992,10 @@ static const vshCmdInfo info_vol_info[] = { static const vshCmdOptDef opts_vol_info[] = { VIRSH_COMMON_OPT_VOLUME_VOL, VIRSH_COMMON_OPT_POOL_OPTIONAL, + {.name = "bytes", + .type = VSH_OT_BOOL, + .help = N_("sizes are represented in bytes rather than pretty units") + }, {.name = NULL} }; @@ -1000,6 +1004,7 @@ cmdVolInfo(vshControl *ctl, const vshCmd *cmd) { virStorageVolInfo info; virStorageVolPtr vol; + bool bytes = vshCommandOptBool(cmd, "bytes"); bool ret = true; if (!(vol = virshCommandOptVol(ctl, cmd, "vol", "pool", NULL))) @@ -1014,11 +1019,21 @@ cmdVolInfo(vshControl *ctl, const vshCmd *cmd) vshPrint(ctl, "%-15s %s\n", _("Type:"), virshVolumeTypeToString(info.type)); - val = vshPrettyCapacity(info.capacity, &unit); - vshPrint(ctl, "%-15s %2.2lf %s\n", _("Capacity:"), val, unit); + if (bytes) { + vshPrint(ctl, "%-15s %llu %s\n", _("Capacity:"), + info.capacity, _("bytes")); + } else { + val = vshPrettyCapacity(info.capacity, &unit); + vshPrint(ctl, "%-15s %2.2lf %s\n", _("Capacity:"), val, unit); + } - val = vshPrettyCapacity(info.allocation, &unit); - vshPrint(ctl, "%-15s %2.2lf %s\n", _("Allocation:"), val, unit); + if (bytes) { + vshPrint(ctl, "%-15s %llu %s\n", _("Allocation:"), + info.allocation, _("bytes")); + } else { + val = vshPrettyCapacity(info.allocation, &unit); + vshPrint(ctl, "%-15s %2.2lf %s\n", _("Allocation:"), val, unit); + } } else { ret = false; } diff --git a/tools/virsh.pod b/tools/virsh.pod index 90ab47d..2a95df7 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -3639,11 +3639,13 @@ is in. I<vol-name-or-key-or-path> is the name or key or path of the volume to output the XML of. =item B<vol-info> [I<--pool> I<pool-or-uuid>] I<vol-name-or-key-or-path> +[I<--bytes>] Returns basic information about the given storage volume. I<--pool> I<pool-or-uuid> is the name or UUID of the storage pool the volume is in. I<vol-name-or-key-or-path> is the name or key or path of the volume -to return information for. +to return information for. If I<--bytes> is specified the sizes are not +converted to human friendly units. =item B<vol-list> [I<--pool> I<pool-or-uuid>] [I<--details>] -- 2.8.1

2 1

[libvirt] [PATCH 0/4] configure: Fix init script choice
by Andrea Bolognani 03 May '16

03 May '16

The changes pushed yesterday have introduced an issue where systemd was turned into systemd+redhat on RHEL systems, which in turn caused RPM building to fail[1]. Patch 1/4 is the actual fix; patch 2/4 changes the code so that breaking it again is hopefully a bit harder. Patches 3/4 and 4/4 clean up a couple of barely related issues in the spec file that I've ran into while investigating this. [1] https://ci.centos.org/view/libvirt-project/job/libvirt-daemon-rpm/systems=l… Andrea Bolognani (4): configure: Change RHEL default from systemd+redhat to systemd configure: Remove nested conditionals in LIBVIRT_CHECK_INIT_SCRIPT spec: Type --with-init-script correctly spec: Rename %{init_scripts} -> %{with_init_script} libvirt.spec.in | 6 +++--- m4/virt-init-script.m4 | 21 ++++++--------------- 2 files changed, 9 insertions(+), 18 deletions(-) -- 2.5.5

2 6