- Devel - libvirt List Archives

[libvirt] [PATCH 0/3] allow fixing tap-bridge connections when network is restarted
by Laine Stump 22 Mar '17

22 Mar '17

It's been a long-standing problem that when you stop and restart a libvirt network, the guest tap devices are no longer connected to the network. Until now the only way to recover from this was to either shutdown and restart all the affected guests, or to detach and then re-attach all affected guest network devices. These patches permit the situation to be remedied by just restarting libvirtd - when the hypervisor drivers are notifying the network drivers of each connection, the network can retrieve the current "master" for the tap device and compare it to the network's bridge device. If they don't match, then it disconnects the tap from any incorrect bridge and connects to the correct bridge. *** For now, that's as far as we go - *semi*-automated (since you need to restart libvirtd for it to happen). My intent is for this to be completely automated, but the logic to do that is a bit "convoluted" so I've deferred trying to implement it until I've given it more thought - a few different trains of thought have led to dead-ends, and so far only one seems reasonably doable: * add a networkStartCallback list to the network driver state object. * as each hypervisor driver that uses the network driver is initialized, it will call an internal-only function in the network driver to register a callback. * whenever a network is started, it will call all the registered callback functions (sending the name of the network being started, and some HV-specific context pointer). * Each hypervisor's callback function will look through all of its active domains for interfaces that are using the given network, and for each such interface, will call networkNotifyActualDevice() (the function that has been updated in Patch 3/3 to reconnect taps to bridges). The "convoluted" part here is that we need to make sure there is enough (but not too much!) locking/refcounting both when adding items to the callback list (which should only be done single threaded, since it happens during the driver initializations) and when the networkStart() function (in some state of lockedness/refcountedness) calls over to some e.g. qemu function that will then need to do some amount of locking (at least on each domain as it is processed) and then calls back into the network driver (which will need "some amount" of locking/refcounting). Since we're calling from network driver into qemu into network driver, while the normal nesting is just calling from qemu into network, I want to be sure there is no possibility for a deadlock. (Also, I want to avoid making the list of callbacks any more complicated than absolutely necessary - the "in" thing to do these days seems to be to allocate a hash table, but there's a lot of extra code required for that (see util/virclosecallbacks.[hc]) which seems like overkill for a list of maximum 4-5 items that will *never* change after the driver initialization - if anyone has ideas/opinions about that, please speak up. Laine Stump (2): util: new function virNetDevGetMaster() util: new function virNetDevTapAttachBridge() root (1): network: reconnect tap devices during networkNotifyActualDevice src/libvirt_private.syms | 2 + src/network/bridge_driver.c | 30 +++++++++++- src/util/virnetdev.c | 49 +++++++++++++++++++ src/util/virnetdev.h | 3 ++ src/util/virnetdevtap.c | 111 +++++++++++++++++++++++++++++--------------- src/util/virnetdevtap.h | 12 +++++ 6 files changed, 169 insertions(+), 38 deletions(-) -- 2.9.3

2 4

[libvirt] [PATCH 00/22] Resolve Coverity and build issues
by John Ferlan 22 Mar '17

22 Mar '17

Hopefully the quantity doesn't scare anyone off... These are mostly innocuous, but separated each out to appease the masses. The first patch fixes a recently uncovered Coverity warning regarding FORWARD_NULL of the 'formatStr'... According to an IRC response from pkrempa the format should be set up properly in qemuDomainSnapshotPrepare Patches 2-22 resolve various different build issues in the Coverity environment that sets "lv_cv_static_analysis=yes" during the build. This is 'reproducible' if one sets that as part of their autogen.sh processing - something that we should probably do in the CI build environment so we can get all those ATTRIBUTE_NONNULL checks to be run on a daily basis. John Ferlan (22): qemu: Always format formatStr for blockdev-snapshot-sync util: Remove NONNULL(1) for virNetDevGetName conf: Remove NONNULL(2) for virNetDevBandwidthParse conf: Remove NONNULL(1,2) for virNetDevBandwidthFormat conf: Remove NONNULL(1) for virDomainNumaGetNodeCount network: Remove null newBandwidth check from networkBandwidthUpdate qemu: Remove non null 'vm' check from qemuMonitorOpen qemu: Remove NONNULL(1) for qemu_monitor prototypes util: Change return argument for virBitmapParseUnlimited util: Remove NONNULL(1) for virBitmapParseUnlimited util: Remove NONNULL(2,3) for virHostdevReAttachPCIDevices util: Remove NONNULL(2,3) for virHostdevReAttachUSBDevices util: Remove NONNULL(2,3) for virHostdevReAttachSCSIVHostDevices util: Remove NONNULL(1) for virHostdevPrepareDomainDevices util: Remove NONNULL(1) for virHostdevReAttachDomainDevices util: Remove NONNULL(1) for virNetDevOpenvswitchSetMigrateData util: Remove NONNULL(1,3,4) from virTypedParamsFilter util: Remove NONNULL(2) for virNetDevBandwidthPlug util: Remove NONNULL(1) for virNetDevOpenvswitchGetVhostuserIfname util: Remove NONNULL's for virNetDevVPortProfile[Associate|Disassociate] util: Remove NONNULL(1) for virNetDevMacVLanDeleteWithVPortProfile cpu: Remove NONNULL(1) for cpuBaseline src/conf/netdev_bandwidth_conf.c | 2 +- src/conf/netdev_bandwidth_conf.h | 5 ++--- src/conf/numa_conf.h | 4 ++-- src/cpu/cpu.h | 3 +-- src/network/bridge_driver.c | 2 +- src/qemu/qemu_driver.c | 3 +-- src/qemu/qemu_monitor.c | 3 +-- src/qemu/qemu_monitor.h | 8 ++++---- src/util/virbitmap.c | 28 +++++++++++++--------------- src/util/virbitmap.h | 6 ++---- src/util/virhostdev.c | 9 ++++++--- src/util/virhostdev.h | 10 +++++----- src/util/virnetdev.h | 2 +- src/util/virnetdevbandwidth.h | 3 +-- src/util/virnetdevmacvlan.h | 2 +- src/util/virnetdevopenvswitch.h | 4 ++-- src/util/virnetdevvportprofile.h | 10 ++++------ src/util/virtypedparam.h | 3 +-- tests/testutils.c | 2 +- tests/virbitmaptest.c | 2 +- 20 files changed, 51 insertions(+), 60 deletions(-) -- 2.9.3

3 25

[libvirt] [PATCH 0/3] Three random small patches
by Laine Stump 22 Mar '17

22 Mar '17

I found these while trying out some other code I decided not to use (I was going to add more attributes to the <link> element, virNetDevIfLink, and virNetDevGetLinkInfo(), but then decided not to for now (in case Michal has a different idea of the meaning of "link" than, e.g., iproute's "ip link" command). The first two taken together actually have a very positive impact - they make the output of "virsh nodedev-dumpxml" much more informative when run as non-root. Laine Stump (3): util: use AF_UNIX family (not AF_PACKET) for ioctl sockets util: allow retrieving ethtool features when unprivileged network: remove unused typedef for networkDnsmasqLeaseFileNameFunc src/network/bridge_driver.h | 2 -- src/util/virnetdev.c | 8 +------- src/util/virnetdevip.c | 2 +- 3 files changed, 2 insertions(+), 10 deletions(-) -- 2.9.3

2 5

[libvirt] [PATCH v3 00/15] Introduce vGPU mdev framework to libvirt
by Erik Skultety 22 Mar '17

22 Mar '17

since v1: - new <hostdev> attribute model introduced which tells libvirt which device API should be considered when auto-assigning guest address - device_api is properly checked, thus taking the 'model' attribute only as a hint to assign "some" address - new address type 'mdev' is introduced rather than using plain <uuid> element, since the address element is more conveniently extendable. - the emulated mtty driver now works as well out of the box, so no HW needed to review this series --> let's try it :) - fixed all the nits from v1 since v2: - dropped the patch introducing new address type 'mdev' since I added by mistake and only after that realized that the device address type enum is used for guest addresses only --> the mdevs are still identified by address element containing an 'uuid' attribute, I just dropped the enum - resolved the driver hostdev list race condition raised by Pavel in his review --> the device API is now checked every time our internal mdev object is created as opposed to the previous version where because of the model being checked separately, the locking issues arose. - rewrote the docs, reflecting the mdev address type drop change - squashed all security related stuff into 1 patch, also added app-armor bits - as Pavel suggested, moved most of the mdev-related functions out of virhostdev.c to virmdev.c - added a few more test cases I also created a new branch 'mdev-next' (more suitable name than a strict version number) on https://github.com/eskultety/libvirt/commits/mdev-next Erik Erik Skultety (15): conf: hostdev: Enforce enum-in-switch compile-time checks conf: hostdev: Introduce virDomainHostdevSubsysSCSIClear conf: Introduce virDomainHostdevDefPostParse conf: Introduce new hostdev device type mdev conf: Add post parse code for mdevs to virDomainHostdevDefPostParse security: Enable labeling of vfio mediated devices conf: Enable cold-plug of a mediated device qemu: Assign PCI addresses for mediated devices as well hostdev: Maintain a driver list of active mediated devices qemu: cgroup: Adjust cgroups' logic to allow mediated devices qemu: Bump the memory locking limit for mdevs as well qemu: Format mdevs on qemu command line test: Add some test cases for our test suite regarding the mdevs docs: Document the new hostdev and address type 'mdev' news: Update the NEWS.xml about the new mdev feature docs/formatdomain.html.in | 46 +- docs/news.xml | 10 + docs/schemas/domaincommon.rng | 22 + po/POTFILES.in | 1 + src/Makefile.am | 1 + src/conf/domain_conf.c | 225 ++++++++-- src/conf/domain_conf.h | 9 + src/libvirt_private.syms | 25 ++ src/qemu/qemu_command.c | 45 ++ src/qemu/qemu_command.h | 5 + src/qemu/qemu_domain.c | 24 +- src/qemu/qemu_domain.h | 1 + src/qemu/qemu_domain_address.c | 14 +- src/qemu/qemu_hostdev.c | 56 +++ src/qemu/qemu_hostdev.h | 10 + src/qemu/qemu_hotplug.c | 2 + src/security/security_apparmor.c | 22 + src/security/security_dac.c | 43 ++ src/security/security_selinux.c | 45 ++ src/util/virhostdev.c | 165 ++++++- src/util/virhostdev.h | 23 + src/util/virmdev.c | 487 +++++++++++++++++++++ src/util/virmdev.h | 123 ++++++ tests/domaincapsschemadata/full.xml | 1 + ...ml2argv-hostdev-mdev-invalid-target-address.xml | 33 ++ ...muxml2argv-hostdev-mdev-src-address-invalid.xml | 35 ++ .../qemuxml2argv-hostdev-mdev-unmanaged.args | 25 ++ .../qemuxml2argv-hostdev-mdev-unmanaged.xml | 35 ++ tests/qemuxml2argvtest.c | 9 + .../qemuxml2xmlout-hostdev-mdev-unmanaged.xml | 40 ++ tests/qemuxml2xmltest.c | 1 + 31 files changed, 1528 insertions(+), 55 deletions(-) create mode 100644 src/util/virmdev.c create mode 100644 src/util/virmdev.h create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-mdev-invalid-target-address.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-mdev-src-address-invalid.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-mdev-unmanaged.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-mdev-unmanaged.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-hostdev-mdev-unmanaged.xml -- 2.12.0

3 20

[libvirt] [BUG] mlock support breakage
by Luiz Capitulino 22 Mar '17

22 Mar '17

Libvirt commit c2e60ad0e51 added a new check to the XML validation logic where XMLs containing <memoryBacking><mlocked/> must also contain <memtune><hard_limit>. This causes two breakages where working guests won't start anymore: 1. Systems where mlock limit was set in /etc/security/limits.conf 2. Guests using hugeTLB pages. In this case, guests were relying on the fact that libvirt automagically increases mlock limit to 1GB While it's true that <memoryBacking><mlocked/> documentation says that <memtune><hard_limit> is required, this is actually an extremely bad request because: A. <memtune><hard_limit> own documention strongly recommends NOT using it B. <memtune><hard_limit> does more than setting memory locking limit C. <memtune><hard_limit> does not support infinity, so you have to guess a limit D. If <memtune><hard_limit> is less than 1GB, it will lower VFIO's automatic limit of "guest memory + 1GB" Here's two possible solutions to fix this all: 1. Drop change c2e60ad0e51 and drop automatic increases. Let users configure limits in /etc/security/limits.conf pros: this is the most correct way to do it, and how it should be done originally IMHO cons: will break working VFIO setups, so probably undoable 2. Drop change c2e60ad0e51 and automtically increase memory locking limit to infinity when seeing <memoryBacking><locked/> pros: make all cases work, no more <hard_limit> requirement cons: allows guests with <locked/> to lock all memory assigned to them plus QEMU allocations. While this seems undesirable or even a security issue, using <hard_limit> will have the same effect Lastly, <locked/> doesn't belong to <memoryBacking>, it should be in <memtune>. I recommend deprecating it from <memoryBacking> and adding it where it belongs.

5 18

[libvirt] [PATCH 0/3] Debug: Improve log messages.
by Prerna Saxena 22 Mar '17

22 Mar '17

Libvirt logs include many snippets for debugging daemon state, but some of those messages are either missing vital information or end up logging "errors" for normal operating conditions as well. This series improves log messages, also adding additional WARN'ings for connection instantiation and closure. Prerna Saxena (3): Debug: Add WARN'ing messages for when a client has opened/closed connection. Debug: Remove unnecessary errors reported while parsing non-existent sysfs files. Debug: Report VM errors more concisely. src/qemu/qemu_process.c | 4 ++-- src/rpc/virnetserverclient.c | 18 ++++++++++++++---- src/util/virnetdev.c | 2 +- 3 files changed, 17 insertions(+), 7 deletions(-) -- 1.8.1.2

3 10

Re: [libvirt] [PATCH 3/3] Debug: Report VM errors more concisely.
by Prerna 22 Mar '17

22 Mar '17

Oops, sorry. Dropping the list was not intentional. I didnt realise I had sent a "reply" in place of "reply-all" . Adding back :) I still would argue that having the VM's name narrows down the problem space. If a client knows what operations have been fired for a VM over the last time window, it is not too difficult to deduce which of them could have caused this message to occur. As I said before, use of libvirt Debug logs adds way too much logspew. If we have more pointed error/warning messages, it can largely help debugging on its own. Even if we turn debugging on, libvirt honestly has way too many messages that look like an en-masse CTRL-C/V operation. Sample: All qemuMonitorEmit* except one have this message: VIR_DEBUG("mon=%p", mon); Even if this message shows up in logs, it is near impossible to trace which event was seen by the VM. And it is quite another task to see which VM this monitor belonged to. Not that more vebosity wont help here. However, I am only trying to make logs easier to work with. Every message should ideally contribute to something meaningful, else it has little value to add while debugging. On Wed, Mar 22, 2017 at 1:59 PM, Peter Krempa <pkrempa(a)redhat.com> wrote: > [Please don't drop the list on the responses.] > > On Wed, Mar 22, 2017 at 13:52:14 +0530, Prerna wrote: > > Always enabling debug logs adds a *lot* of logspew. > > It would be good to have self-sufficient error messages, dont you think ? > > What is wrong with adding a VM name field here ? > > It's mostly useless. You get the VM name, but you don't have the > operation that failed. So it's useless for debugging. >

1 0

[libvirt] [PATCH] cleanup: qemu_capabilities: remove redundant error messages
by Chen Hanxiao 22 Mar '17

22 Mar '17

From: Chen Hanxiao <chenhanxiao(a)gmail.com> We reported error in caller qemuConnectGetDomainCapabilities. So the same error messages in virQEMUCapsCacheLookupByArch are useless. Signed-off-by: Chen Hanxiao <chenhanxiao(a)gmail.com> --- src/qemu/qemu_capabilities.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 5a3b4ac..eca46e7 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -5192,10 +5192,6 @@ virQEMUCapsCacheLookupByArch(virCapsPtr caps, virQEMUCapsCacheValidate(cache, binary, caps, &ret); VIR_FREE(binary); } - } else { - virReportError(VIR_ERR_INVALID_ARG, - _("unable to find any emulator to serve '%s' " - "architecture"), virArchToString(arch)); } virObjectRef(ret); -- 2.7.4

2 3

[libvirt] [PATCH] qemu: Fix qemuMonitorOpen prototype
by John Ferlan 21 Mar '17

21 Mar '17

Commit id '85af0b8' added a 'timeout' as the 4th parameter to qemuMonitorOpen, but neglected to update the ATTRIBUTE_NONNULL(4) to be (5) for the cb parameter. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Pushed as a Coverity build breaker. src/qemu/qemu_monitor.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h index c3d3f2f..cf79424 100644 --- a/src/qemu/qemu_monitor.h +++ b/src/qemu/qemu_monitor.h @@ -249,7 +249,7 @@ qemuMonitorPtr qemuMonitorOpen(virDomainObjPtr vm, unsigned long long timeout, qemuMonitorCallbacksPtr cb, void *opaque) - ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(4); + ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(5); qemuMonitorPtr qemuMonitorOpenFD(virDomainObjPtr vm, int sockfd, bool json, -- 2.9.3

1 0

[libvirt] [PATCH v2] cleanup: qemu_capabilities: remove redundant error messages
by Chen Hanxiao 21 Mar '17

21 Mar '17

From: Chen Hanxiao <chenhanxiao(a)gmail.com> We reported error in caller virQEMUCapsCacheLookupByArch. So the same error messages in qemuConnectGetDomainCapabilities is useless. Signed-off-by: Chen Hanxiao <chenhanxiao(a)gmail.com> --- v2: remove extra error message in qemuConnectGetDomainCapabilities instead of virQEMUCapsCacheLookupByArch. src/qemu/qemu_driver.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index dcd823f..0e06508 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -18713,12 +18713,8 @@ qemuConnectGetDomainCapabilities(virConnectPtr conn, } else { if (!(qemuCaps = virQEMUCapsCacheLookupByArch(caps, driver->qemuCapsCache, - arch))) { - virReportError(VIR_ERR_INVALID_ARG, - _("unable to find any emulator to serve '%s' " - "architecture"), virArchToString(arch)); + arch))) goto cleanup; - } emulatorbin = virQEMUCapsGetBinary(qemuCaps); } -- 2.7.4

2 1

[libvirt] [PATCH] network: don't add "no-resolv" if we still need DNS servers from resolv.conf
by Laine Stump 21 Mar '17

21 Mar '17

It was pointed out here: https://bugzilla.redhat.com/show_bug.cgi?id=1331796#c4 that we shouldn't be adding a "no-resolv" to the dnsmasq.conf file for a network if there isn't any <forwarder> element that specifies an IP address but no qualifying domain. If there is such an element, it will handle all DNS requests that weren't otherwise handled by one of the forwarder entries with a matching domain attribute. If not, then DNS requests that don't match the domain of any <forwarder> would not be resolved if we added no-resolv. So, only add "no-resolv" when there is at least one <forwarder> element that specifies an IP address but no qualifying domain. --- src/network/bridge_driver.c | 14 +++++++++++++- .../nat-network-dns-forwarder-no-resolv.conf | 12 ++++++++++++ .../nat-network-dns-forwarder-no-resolv.xml | 11 +++++++++++ tests/networkxml2confdata/nat-network-dns-forwarders.conf | 2 +- tests/networkxml2conftest.c | 1 + .../nat-network-dns-forwarder-no-resolv.xml | 11 +++++++++++ .../nat-network-dns-forwarder-no-resolv.xml | 11 +++++++++++ tests/networkxml2xmltest.c | 1 + 8 files changed, 61 insertions(+), 2 deletions(-) create mode 100644 tests/networkxml2confdata/nat-network-dns-forwarder-no-resolv.conf create mode 100644 tests/networkxml2confdata/nat-network-dns-forwarder-no-resolv.xml create mode 100644 tests/networkxml2xmlin/nat-network-dns-forwarder-no-resolv.xml create mode 100644 tests/networkxml2xmlout/nat-network-dns-forwarder-no-resolv.xml diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index c5ec282..32c5ab7 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -1085,7 +1085,15 @@ networkDnsmasqConfContents(virNetworkObjPtr network, virBufferAddLit(&configbuf, "port=0\n"); if (wantDNS && network->def->dns.forwarders) { - virBufferAddLit(&configbuf, "no-resolv\n"); + /* addNoResolv should be set to true if there are any entries + * that specify an IP address for requests, but no domain + * qualifier (implying that all requests otherwise "unclaimed" + * should be sent to that address). if it is still false when + * we've looked at all entries, it means we still need the + * host's resolv.conf for some cases. + */ + bool addNoResolv = false; + for (i = 0; i < network->def->dns.nfwds; i++) { virNetworkDNSForwarderPtr fwd = &network->def->dns.forwarders[i]; @@ -1099,11 +1107,15 @@ networkDnsmasqConfContents(virNetworkObjPtr network, goto cleanup; virBufferAsprintf(&configbuf, "%s\n", addr); VIR_FREE(addr); + if (!fwd->domain) + addNoResolv = true; } else { /* "don't forward requests for this domain" */ virBufferAddLit(&configbuf, "#\n"); } } + if (addNoResolv) + virBufferAddLit(&configbuf, "no-resolv\n"); } if (network->def->domain) { diff --git a/tests/networkxml2confdata/nat-network-dns-forwarder-no-resolv.conf b/tests/networkxml2confdata/nat-network-dns-forwarder-no-resolv.conf new file mode 100644 index 0000000..52d000a --- /dev/null +++ b/tests/networkxml2confdata/nat-network-dns-forwarder-no-resolv.conf @@ -0,0 +1,12 @@ +##WARNING: THIS IS AN AUTO-GENERATED FILE. CHANGES TO IT ARE LIKELY TO BE +##OVERWRITTEN AND LOST. Changes to this configuration should be made using: +## virsh net-edit default +## or other application using the libvirt API. +## +## dnsmasq conf file created by libvirt +strict-order +server=/example.com/192.168.1.1 +except-interface=lo +bind-dynamic +interface=virbr0 +addn-hosts=/var/lib/libvirt/dnsmasq/default.addnhosts diff --git a/tests/networkxml2confdata/nat-network-dns-forwarder-no-resolv.xml b/tests/networkxml2confdata/nat-network-dns-forwarder-no-resolv.xml new file mode 100644 index 0000000..9661ce5 --- /dev/null +++ b/tests/networkxml2confdata/nat-network-dns-forwarder-no-resolv.xml @@ -0,0 +1,11 @@ +<network> + <name>default</name> + <uuid>81ff0d90-c91e-6742-64da-4a736edb9a9c</uuid> + <forward mode='nat'/> + <bridge name='virbr0' stp='on' delay='0'/> + <dns> + <forwarder domain='example.com' addr='192.168.1.1'/> + </dns> + <ip address='192.168.122.1' netmask='255.255.255.0'> + </ip> +</network> diff --git a/tests/networkxml2confdata/nat-network-dns-forwarders.conf b/tests/networkxml2confdata/nat-network-dns-forwarders.conf index 0bd76bf..1b0c94c 100644 --- a/tests/networkxml2confdata/nat-network-dns-forwarders.conf +++ b/tests/networkxml2confdata/nat-network-dns-forwarders.conf @@ -5,11 +5,11 @@ ## ## dnsmasq conf file created by libvirt strict-order -no-resolv server=8.8.8.8 server=8.8.4.4 server=/example.com/192.168.1.1 server=/www.example.com/# +no-resolv except-interface=lo bind-dynamic interface=virbr0 diff --git a/tests/networkxml2conftest.c b/tests/networkxml2conftest.c index 9b61077..e2522fc 100644 --- a/tests/networkxml2conftest.c +++ b/tests/networkxml2conftest.c @@ -137,6 +137,7 @@ mymain(void) DO_TEST("nat-network-dns-hosts", full); DO_TEST("nat-network-dns-forward-plain", full); DO_TEST("nat-network-dns-forwarders", full); + DO_TEST("nat-network-dns-forwarder-no-resolv", full); DO_TEST("nat-network-dns-local-domain", full); DO_TEST("dhcp6-network", dhcpv6); DO_TEST("dhcp6-nat-network", dhcpv6); diff --git a/tests/networkxml2xmlin/nat-network-dns-forwarder-no-resolv.xml b/tests/networkxml2xmlin/nat-network-dns-forwarder-no-resolv.xml new file mode 100644 index 0000000..9661ce5 --- /dev/null +++ b/tests/networkxml2xmlin/nat-network-dns-forwarder-no-resolv.xml @@ -0,0 +1,11 @@ +<network> + <name>default</name> + <uuid>81ff0d90-c91e-6742-64da-4a736edb9a9c</uuid> + <forward mode='nat'/> + <bridge name='virbr0' stp='on' delay='0'/> + <dns> + <forwarder domain='example.com' addr='192.168.1.1'/> + </dns> + <ip address='192.168.122.1' netmask='255.255.255.0'> + </ip> +</network> diff --git a/tests/networkxml2xmlout/nat-network-dns-forwarder-no-resolv.xml b/tests/networkxml2xmlout/nat-network-dns-forwarder-no-resolv.xml new file mode 100644 index 0000000..9661ce5 --- /dev/null +++ b/tests/networkxml2xmlout/nat-network-dns-forwarder-no-resolv.xml @@ -0,0 +1,11 @@ +<network> + <name>default</name> + <uuid>81ff0d90-c91e-6742-64da-4a736edb9a9c</uuid> + <forward mode='nat'/> + <bridge name='virbr0' stp='on' delay='0'/> + <dns> + <forwarder domain='example.com' addr='192.168.1.1'/> + </dns> + <ip address='192.168.122.1' netmask='255.255.255.0'> + </ip> +</network> diff --git a/tests/networkxml2xmltest.c b/tests/networkxml2xmltest.c index cfaf718..effd85a 100644 --- a/tests/networkxml2xmltest.c +++ b/tests/networkxml2xmltest.c @@ -141,6 +141,7 @@ mymain(void) DO_TEST("nat-network-dns-hosts"); DO_TEST("nat-network-dns-forward-plain"); DO_TEST("nat-network-dns-forwarders"); + DO_TEST("nat-network-dns-forwarder-no-resolv"); DO_TEST("nat-network-forward-nat-address"); DO_TEST("nat-network-forward-nat-no-address"); DO_TEST("8021Qbh-net"); -- 2.9.3

2 3

Re: [libvirt] [libvirt-users] [RFC] per-device metadata
by Francesco Romani 21 Mar '17

21 Mar '17

(CC devel list - better late than never) On 03/16/2017 04:23 PM, Daniel P. Berrange wrote: > On Thu, Mar 16, 2017 at 04:17:51PM +0100, Peter Krempa wrote: >> On Thu, Mar 16, 2017 at 14:52:47 +0000, Daniel Berrange wrote: >>> On Thu, Mar 16, 2017 at 03:50:51PM +0100, Peter Krempa wrote: >>>> On Thu, Mar 16, 2017 at 14:42:30 +0000, Daniel Berrange wrote: >>>>> On Thu, Mar 16, 2017 at 01:46:38PM +0100, Peter Krempa wrote: >>>>>> On Mon, Feb 27, 2017 at 16:41:28 +0100, Francesco Romani wrote: >> [...] >> >>> The scenario where device attach fails is not the problem - you can >>> get the same level of reliabilty to that by simply updating the >>> global metadata before & after hotplug in the same way. What is >>> difficult is when libvirt fails to persist the XML config on disk >>> or when libvirt crashes part way through the operation, and other >>> akward failure scenarios unrelated to QEMU itself. >> In that case you lose the device definition too, since saving the XML is >> the integral part of the hotplug operation. > Agreed, but that just re-inforces my view that we don't need to provide > extra metadata against the device for sake of atomicity. Even the existing > hotplug doesn't guarantee any kind of atomicity, so you're not making life > worse by performing a separate API call to update the global metadata. > > > Regards, > Daniel Thanks everyone, I will file a bug so we can move forward on this. Bests, -- Francesco Romani Red Hat Engineering Virtualization R & D IRC: fromani

1 0

[libvirt] [PATCH] tests: update QEMU 2.9.0 caps data
by Pavel Hrdina 21 Mar '17

21 Mar '17

Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- .../qemucapabilitiesdata/caps_2.9.0.x86_64.replies | 3701 +++++++++++--------- tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 7 +- 2 files changed, 2122 insertions(+), 1586 deletions(-) diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.replies b/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.replies index f6109513a2..b6fd75090c 100644 --- a/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.replies +++ b/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.replies @@ -2,11 +2,11 @@ "QMP": { "version": { "qemu": { - "micro": 50, + "micro": 90, "minor": 8, "major": 2 }, - "package": " (v2.8.0-1961-g5b10b94bd5)" + "package": " (v2.9.0-rc0-142-g940a8ce)" }, "capabilities": [ ] @@ -22,11 +22,11 @@ { "return": { "qemu": { - "micro": 50, + "micro": 90, "minor": 8, "major": 2 }, - "package": " (v2.8.0-1961-g5b10b94bd5)" + "package": " (v2.9.0-rc0-142-g940a8ce)" }, "id": "libvirt-2" } @@ -41,6 +41,18 @@ { "return": [ { + "name": "netdev_add" + }, + { + "name": "device_add" + }, + { + "name": "query-qmp-schema" + }, + { + "name": "xen-set-replication" + }, + { "name": "xen-set-global-dirty-log" }, { @@ -50,6 +62,9 @@ "name": "xen-load-devices-state" }, { + "name": "xen-colo-do-checkpoint" + }, + { "name": "x-colo-lost-heartbeat" }, { @@ -113,12 +128,18 @@ "name": "quit" }, { + "name": "query-xen-replication-status" + }, + { "name": "query-vnc-servers" }, { "name": "query-vnc" }, { + "name": "query-vm-generation-id" + }, + { "name": "query-version" }, { @@ -456,15 +477,6 @@ }, { "name": "add-fd" - }, - { - "name": "netdev_add" - }, - { - "name": "device_add" - }, - { - "name": "query-qmp-schema" } ], "id": "libvirt-4" @@ -710,6 +722,9 @@ "name": "secret" }, { + "name": "qio-channel-tls" + }, + { "name": "filter-buffer" }, { @@ -746,12 +761,12 @@ "name": "pci-serial-2x" }, { - "name": "scsi-generic" - }, - { "name": "piix4-ide" }, { + "name": "scsi-generic" + }, + { "name": "pc-1.0-machine" }, { @@ -773,12 +788,15 @@ "name": "pc-i440fx-2.1-machine" }, { - "name": "virtio-mouse-device" - }, - { "name": "virtio-mouse-pci" }, { + "name": "virtio-mouse-device" + }, + { + "name": "isa-ipmi-bt" + }, + { "name": "isa-debugcon" }, { @@ -794,9 +812,6 @@ "name": "qemu64-x86_64-cpu" }, { - "name": "isa-ipmi-bt" - }, - { "name": "rng-egd" }, { @@ -989,6 +1004,9 @@ "name": "core2duo-x86_64-cpu" }, { + "name": "qio-channel-command" + }, + { "name": "virtio-9p-pci" }, { @@ -1163,18 +1181,18 @@ "name": "isa-ipmi-kcs" }, { - "name": "isa-ide" - }, - { - "name": "rng-random" - }, - { "name": "virtio-crypto-pci" }, { + "name": "rng-random" + }, + { "name": "isa-vga" }, { + "name": "isa-ide" + }, + { "name": "virtio-keyboard-device" }, { @@ -1244,7 +1262,7 @@ "name": "chardev-gdb" }, { - "name": "qio-channel-command" + "name": "virtio-pci-bus" }, { "name": "chardev-vc" @@ -1283,6 +1301,9 @@ "name": "phenom-x86_64-cpu" }, { + "name": "usb-ccid" + }, + { "name": "fw_cfg_io" }, { @@ -1304,6 +1325,9 @@ "name": "nvme" }, { + "name": "chardev-wctablet" + }, + { "name": "i82801b11-bridge" }, { @@ -1313,7 +1337,7 @@ "name": "usb-tablet" }, { - "name": "usb-ccid" + "name": "usb-bot" }, { "name": "sdhci-bus" @@ -1337,9 +1361,6 @@ "name": "tcg-accel" }, { - "name": "usb-bot" - }, - { "name": "isa-cirrus-vga" }, { @@ -1382,6 +1403,9 @@ "name": "nvdimm" }, { + "name": "x3130-upstream" + }, + { "name": "ich9-usb-uhci6" }, { @@ -1394,9 +1418,6 @@ "name": "virtio-balloon-device" }, { - "name": "x3130-upstream" - }, - { "name": "ich9-usb-uhci5" }, { @@ -1565,7 +1586,7 @@ "name": "xen-backend" }, { - "name": "qio-channel-tls" + "name": "usb-redir" }, { "name": "virtio-serial-pci" @@ -1601,7 +1622,7 @@ "name": "chardev-parallel" }, { - "name": "virtio-pci-bus" + "name": "qemu-xhci" }, { "name": "pxb" @@ -1619,7 +1640,7 @@ "name": "kvm64-x86_64-cpu" }, { - "name": "usb-redir" + "name": "usb-storage" }, { "name": "vt82c686b-usb-uhci" @@ -1628,7 +1649,7 @@ "name": "HDA" }, { - "name": "usb-storage" + "name": "vmgenid" }, { "name": "pc-1.3-machine" @@ -1823,11 +1844,20 @@ "type": "bool" }, { + "name": "x-pcie-lnkctl-init", + "description": "on/off", + "type": "bool" + }, + { "name": "werror", "description": "Error handling policy, report/ignore/enospc/stop/auto", "type": "BlockdevOnError" }, { + "name": "bootindex", + "type": "int32" + }, + { "name": "discard_granularity", "type": "uint32" }, @@ -1842,16 +1872,12 @@ "type": "bool" }, { - "name": "bootindex", - "type": "int32" - }, - { - "name": "x-pcie-lnksta-dllla", + "name": "x-pcie-deverr-init", "description": "on/off", "type": "bool" }, { - "name": "notify_on_empty", + "name": "x-pcie-pm-init", "description": "on/off", "type": "bool" }, @@ -1861,44 +1887,58 @@ "type": "bool" }, { - "name": "class", - "type": "uint32" - }, - { - "name": "migrate-extra", + "name": "x-pcie-lnksta-dllla", "description": "on/off", "type": "bool" }, { - "name": "addr", - "description": "Slot and optional function number, example: 06.0 or 06", - "type": "int32" - }, - { - "name": "modern-pio-notify", - "description": "on/off", + "name": "share-rw", "type": "bool" }, { - "name": "vectors", - "type": "uint32" - }, - { "name": "physical_block_size", "description": "A power of two between 512 and 32768", "type": "uint16" }, { - "name": "iommu_platform", - "description": "on/off", - "type": "bool" - }, - { "name": "config-wce", "description": "on/off", "type": "bool" }, { + "name": "class", + "type": "uint32" + }, + { + "name": "addr", + "description": "Slot and optional function number, example: 06.0 or 06", + "type": "int32" + }, + { + "name": "migrate-extra", + "description": "on/off", + "type": "bool" + }, + { + "name": "modern-pio-notify", + "description": "on/off", + "type": "bool" + }, + { + "name": "vectors", + "type": "uint32" + }, + { + "name": "iommu_platform", + "description": "on/off", + "type": "bool" + }, + { + "name": "x-pcie-extcap-init", + "description": "on/off", + "type": "bool" + }, + { "name": "virtio-backend", "type": "child<virtio-blk-device>" }, @@ -1907,6 +1947,11 @@ "type": "bool" }, { + "name": "notify_on_empty", + "description": "on/off", + "type": "bool" + }, + { "name": "write-cache", "description": "on/off/auto", "type": "OnOffAuto" @@ -1916,20 +1961,20 @@ "type": "uint16" }, { - "name": "virtio-pci-bus-master-bug-migration", - "description": "on/off", - "type": "bool" - }, - { - "name": "ats", - "description": "on/off", - "type": "bool" - }, - { "name": "opt_io_size", "type": "uint32" }, { + "name": "ats", + "description": "on/off", + "type": "bool" + }, + { + "name": "virtio-pci-bus-master-bug-migration", + "description": "on/off", + "type": "bool" + }, + { "name": "romfile", "type": "str" } @@ -1940,26 +1985,16 @@ { "return": [ { - "name": "indirect_desc", + "name": "ctrl_mac_addr", "description": "on/off", "type": "bool" }, { - "name": "x-txtimer", - "type": "uint32" + "name": "romfile", + "type": "str" }, { - "name": "notify_on_empty", - "description": "on/off", - "type": "bool" - }, - { - "name": "guest_ufo", - "description": "on/off", - "type": "bool" - }, - { - "name": "mq", + "name": "x-pcie-lnksta-dllla", "description": "on/off", "type": "bool" }, @@ -1969,113 +2004,51 @@ "type": "bool" }, { - "name": "host_ecn", + "name": "notify_on_empty", "description": "on/off", "type": "bool" }, { - "name": "ioeventfd", + "name": "command_serr_enable", "description": "on/off", "type": "bool" }, { - "name": "tx", - "type": "str" - }, - { - "name": "multifunction", - "description": "on/off", - "type": "bool" - }, - { - "name": "rombar", - "type": "uint32" - }, - { - "name": "ctrl_rx_extra", - "description": "on/off", - "type": "bool" - }, - { - "name": "ctrl_vq", - "description": "on/off", - "type": "bool" - }, - { - "name": "mac", - "description": "Ethernet 6-byte MAC Address, example: 52:54:00:12:34:56", - "type": "str" - }, - { - "name": "rx_queue_size", - "type": "uint16" - }, - { - "name": "x-disable-pcie", + "name": "x-pcie-pm-init", "description": "on/off", "type": "bool" }, { - "name": "guest_tso6", + "name": "indirect_desc", "description": "on/off", "type": "bool" }, { - "name": "gso", - "description": "on/off", - "type": "bool" - }, - { - "name": "guest_ecn", - "description": "on/off", - "type": "bool" - }, - { - "name": "ctrl_rx", - "description": "on/off", - "type": "bool" - }, - { - "name": "guest_tso4", - "description": "on/off", - "type": "bool" - }, - { - "name": "disable-modern", - "type": "bool" - }, - { "name": "guest_csum", "description": "on/off", "type": "bool" }, { - "name": "guest_announce", + "name": "ctrl_rx", "description": "on/off", "type": "bool" }, { - "name": "disable-legacy", - "description": "on/off/auto", - "type": "OnOffAuto" - }, - { - "name": "command_serr_enable", + "name": "ctrl_vq", "description": "on/off", "type": "bool" }, { - "name": "x-txburst", + "name": "bootindex", "type": "int32" }, { - "name": "ctrl_vlan", + "name": "multifunction", "description": "on/off", "type": "bool" }, { - "name": "csum", - "description": "on/off", + "name": "disable-modern", "type": "bool" }, { @@ -2084,57 +2057,46 @@ "type": "bool" }, { - "name": "page-per-vq", - "description": "on/off", - "type": "bool" - }, - { - "name": "any_layout", - "description": "on/off", - "type": "bool" - }, - { - "name": "x-pcie-lnksta-dllla", - "description": "on/off", - "type": "bool" - }, - { - "name": "ctrl_guest_offloads", - "description": "on/off", - "type": "bool" - }, - { "name": "host_tso6", "description": "on/off", "type": "bool" }, { - "name": "bootindex", - "type": "int32" + "name": "x-txtimer", + "type": "uint32" }, { - "name": "ctrl_mac_addr", + "name": "host_tso4", "description": "on/off", "type": "bool" }, { - "name": "addr", - "description": "Slot and optional function number, example: 06.0 or 06", - "type": "int32" + "name": "rombar", + "type": "uint32" }, { - "name": "migrate-extra", + "name": "ctrl_rx_extra", "description": "on/off", "type": "bool" }, { - "name": "modern-pio-notify", + "name": "gso", "description": "on/off", "type": "bool" }, { - "name": "vectors", - "type": "uint32" + "name": "page-per-vq", + "description": "on/off", + "type": "bool" + }, + { + "name": "x-disable-pcie", + "description": "on/off", + "type": "bool" + }, + { + "name": "x-ignore-backend-features", + "type": "bool" }, { "name": "vlan", @@ -2142,12 +2104,25 @@ "type": "int32" }, { - "name": "host_tso4", + "name": "x-txburst", + "type": "int32" + }, + { + "name": "iommu_platform", + "description": "on/off", + "type": "bool" + }, + { + "name": "x-pcie-lnkctl-init", "description": "on/off", "type": "bool" }, { - "name": "host_ufo", + "name": "host_mtu", + "type": "uint16" + }, + { + "name": "ctrl_vlan", "description": "on/off", "type": "bool" }, @@ -2156,7 +2131,116 @@ "type": "child<virtio-net-device>" }, { - "name": "x-ignore-backend-features", + "name": "event_idx", + "description": "on/off", + "type": "bool" + }, + { + "name": "vectors", + "type": "uint32" + }, + { + "name": "guest_announce", + "description": "on/off", + "type": "bool" + }, + { + "name": "host_ecn", + "description": "on/off", + "type": "bool" + }, + { + "name": "addr", + "description": "Slot and optional function number, example: 06.0 or 06", + "type": "int32" + }, + { + "name": "ats", + "description": "on/off", + "type": "bool" + }, + { + "name": "host_ufo", + "description": "on/off", + "type": "bool" + }, + { + "name": "guest_tso4", + "description": "on/off", + "type": "bool" + }, + { + "name": "guest_tso6", + "description": "on/off", + "type": "bool" + }, + { + "name": "ctrl_guest_offloads", + "description": "on/off", + "type": "bool" + }, + { + "name": "csum", + "description": "on/off", + "type": "bool" + }, + { + "name": "modern-pio-notify", + "description": "on/off", + "type": "bool" + }, + { + "name": "ioeventfd", + "description": "on/off", + "type": "bool" + }, + { + "name": "mq", + "description": "on/off", + "type": "bool" + }, + { + "name": "any_layout", + "description": "on/off", + "type": "bool" + }, + { + "name": "guest_ecn", + "description": "on/off", + "type": "bool" + }, + { + "name": "guest_ufo", + "description": "on/off", + "type": "bool" + }, + { + "name": "virtio-pci-bus-master-bug-migration", + "description": "on/off", + "type": "bool" + }, + { + "name": "mac", + "description": "Ethernet 6-byte MAC Address, example: 52:54:00:12:34:56", + "type": "str" + }, + { + "name": "disable-legacy", + "description": "on/off/auto", + "type": "OnOffAuto" + }, + { + "name": "tx", + "type": "str" + }, + { + "name": "x-pcie-extcap-init", + "description": "on/off", + "type": "bool" + }, + { + "name": "x-pcie-deverr-init", + "description": "on/off", "type": "bool" }, { @@ -2165,32 +2249,13 @@ "type": "str" }, { - "name": "event_idx", + "name": "migrate-extra", "description": "on/off", "type": "bool" }, { - "name": "host_mtu", + "name": "rx_queue_size", "type": "uint16" - }, - { - "name": "iommu_platform", - "description": "on/off", - "type": "bool" - }, - { - "name": "ats", - "description": "on/off", - "type": "bool" - }, - { - "name": "virtio-pci-bus-master-bug-migration", - "description": "on/off", - "type": "bool" - }, - { - "name": "romfile", - "type": "str" } ], "id": "libvirt-11" @@ -2228,18 +2293,18 @@ "type": "bool" }, { - "name": "disable-modern", - "type": "bool" - }, - { - "name": "num_queues", - "type": "uint32" - }, - { "name": "cmd_per_lun", "type": "uint32" }, { + "name": "disable-modern", + "type": "bool" + }, + { + "name": "num_queues", + "type": "uint32" + }, + { "name": "disable-legacy", "description": "on/off/auto", "type": "OnOffAuto" @@ -2250,7 +2315,7 @@ "type": "bool" }, { - "name": "page-per-vq", + "name": "x-pcie-lnkctl-init", "description": "on/off", "type": "bool" }, @@ -2260,6 +2325,21 @@ "type": "bool" }, { + "name": "page-per-vq", + "description": "on/off", + "type": "bool" + }, + { + "name": "x-pcie-deverr-init", + "description": "on/off", + "type": "bool" + }, + { + "name": "x-pcie-pm-init", + "description": "on/off", + "type": "bool" + }, + { "name": "x-pcie-lnksta-dllla", "description": "on/off", "type": "bool" @@ -2302,6 +2382,11 @@ "type": "uint32" }, { + "name": "x-pcie-extcap-init", + "description": "on/off", + "type": "bool" + }, + { "name": "virtio-backend", "type": "child<virtio-scsi-device>" }, @@ -2424,6 +2509,11 @@ "type": "str" }, { + "name": "x-pcie-extcap-init", + "description": "on/off", + "type": "bool" + }, + { "name": "command_serr_enable", "description": "on/off", "type": "bool" @@ -2524,6 +2614,11 @@ "type": "bool" }, { + "name": "x-pcie-extcap-init", + "description": "on/off", + "type": "bool" + }, + { "name": "addr", "description": "Slot and optional function number, example: 06.0 or 06", "type": "int32" @@ -2595,6 +2690,10 @@ "type": "OnOffAuto" }, { + "name": "share-rw", + "type": "bool" + }, + { "name": "opt_io_size", "type": "uint32" }, @@ -2684,6 +2783,10 @@ "type": "OnOffAuto" }, { + "name": "share-rw", + "type": "bool" + }, + { "name": "opt_io_size", "type": "uint32" }, @@ -2763,6 +2866,11 @@ "type": "uint8" }, { + "name": "x-pcie-extcap-init", + "description": "on/off", + "type": "bool" + }, + { "name": "command_serr_enable", "description": "on/off", "type": "bool" @@ -3080,6 +3188,10 @@ "type": "OnOffAuto" }, { + "name": "share-rw", + "type": "bool" + }, + { "name": "opt_io_size", "type": "uint32" }, @@ -3167,6 +3279,11 @@ "type": "uint32" }, { + "name": "x-pcie-extcap-init", + "description": "on/off", + "type": "bool" + }, + { "name": "command_serr_enable", "description": "on/off", "type": "bool" @@ -3205,6 +3322,11 @@ "type": "uint32" }, { + "name": "x-pcie-extcap-init", + "description": "on/off", + "type": "bool" + }, + { "name": "command_serr_enable", "description": "on/off", "type": "bool" @@ -3277,6 +3399,11 @@ "type": "uint32" }, { + "name": "x-pcie-extcap-init", + "description": "on/off", + "type": "bool" + }, + { "name": "guestdebug", "type": "uint32" }, @@ -3346,11 +3473,26 @@ "type": "bool" }, { + "name": "x-pcie-lnkctl-init", + "description": "on/off", + "type": "bool" + }, + { "name": "page-per-vq", "description": "on/off", "type": "bool" }, { + "name": "x-pcie-deverr-init", + "description": "on/off", + "type": "bool" + }, + { + "name": "x-pcie-pm-init", + "description": "on/off", + "type": "bool" + }, + { "name": "max_outputs", "type": "uint32" }, @@ -3389,6 +3531,11 @@ "type": "bool" }, { + "name": "x-pcie-extcap-init", + "description": "on/off", + "type": "bool" + }, + { "name": "virtio-backend", "type": "child<virtio-gpu-device>" }, @@ -3532,22 +3679,27 @@ "type": "bool" }, { + "name": "disable_s3", + "type": "uint8" + }, + { "name": "romfile", "type": "str" }, { - "name": "disable_s3", - "type": "uint8" - }, - { - "name": "s4_val", - "type": "uint8" - }, - { "name": "acpi_enable_cmd", "type": "uint8" }, { + "name": "s4_val", + "type": "uint8" + }, + { + "name": "x-pcie-extcap-init", + "description": "on/off", + "type": "bool" + }, + { "name": "command_serr_enable", "description": "on/off", "type": "bool" @@ -3618,6 +3770,11 @@ "type": "bool" }, { + "name": "x-pcie-lnkctl-init", + "description": "on/off", + "type": "bool" + }, + { "name": "guest-stats", "type": "guest statistics" }, @@ -3632,6 +3789,16 @@ "type": "bool" }, { + "name": "x-pcie-deverr-init", + "description": "on/off", + "type": "bool" + }, + { + "name": "x-pcie-pm-init", + "description": "on/off", + "type": "bool" + }, + { "name": "x-pcie-lnksta-dllla", "description": "on/off", "type": "bool" @@ -3661,6 +3828,11 @@ "type": "bool" }, { + "name": "x-pcie-extcap-init", + "description": "on/off", + "type": "bool" + }, + { "name": "virtio-backend", "type": "child<virtio-balloon-device>" }, @@ -3674,12 +3846,12 @@ "type": "bool" }, { - "name": "ats", + "name": "iommu_platform", "description": "on/off", "type": "bool" }, { - "name": "iommu_platform", + "name": "ats", "description": "on/off", "type": "bool" }, @@ -3803,6 +3975,11 @@ "type": "bool" }, { + "name": "x-pcie-extcap-init", + "description": "on/off", + "type": "bool" + }, + { "name": "addr", "description": "Slot and optional function number, example: 06.0 or 06", "type": "int32" @@ -4427,10 +4604,22 @@ { "parameters": [ { + "name": "rendernode", + "type": "string" + }, + { "name": "gl", "type": "boolean" }, { + "name": "head", + "type": "number" + }, + { + "name": "display", + "type": "string" + }, + { "name": "seamless-migration", "type": "boolean" }, @@ -4591,6 +4780,101 @@ { "parameters": [ { + "name": "throttling.iops-size", + "help": "when limiting by iops max size of an I/O in bytes", + "type": "number" + }, + { + "name": "throttling.bps-write-max-length", + "help": "length of the bps-write-max burst period, in seconds", + "type": "number" + }, + { + "name": "throttling.bps-read-max-length", + "help": "length of the bps-read-max burst period, in seconds", + "type": "number" + }, + { + "name": "throttling.bps-total-max-length", + "help": "length of the bps-total-max burst period, in seconds", + "type": "number" + }, + { + "name": "throttling.iops-write-max-length", + "help": "length of the iops-write-max burst period, in seconds", + "type": "number" + }, + { + "name": "throttling.iops-read-max-length", + "help": "length of the iops-read-max burst period, in seconds", + "type": "number" + }, + { + "name": "throttling.iops-total-max-length", + "help": "length of the iops-total-max burst period, in seconds", + "type": "number" + }, + { + "name": "throttling.bps-write-max", + "help": "total bytes write burst", + "type": "number" + }, + { + "name": "throttling.bps-read-max", + "help": "total bytes read burst", + "type": "number" + }, + { + "name": "throttling.bps-total-max", + "help": "total bytes burst", + "type": "number" + }, + { + "name": "throttling.iops-write-max", + "help": "I/O operations write burst", + "type": "number" + }, + { + "name": "throttling.iops-read-max", + "help": "I/O operations read burst", + "type": "number" + }, + { + "name": "throttling.iops-total-max", + "help": "I/O operations burst", + "type": "number" + }, + { + "name": "throttling.bps-write", + "help": "limit write bytes per second", + "type": "number" + }, + { + "name": "throttling.bps-read", + "help": "limit read bytes per second", + "type": "number" + }, + { + "name": "throttling.bps-total", + "help": "limit total bytes per second", + "type": "number" + }, + { + "name": "throttling.iops-write", + "help": "limit write operations per second", + "type": "number" + }, + { + "name": "throttling.iops-read", + "help": "limit read operations per second", + "type": "number" + }, + { + "name": "throttling.iops-total", + "help": "limit total I/O operations per second", + "type": "number" + }, + { "name": "sock_fd", "type": "number" }, @@ -4847,6 +5131,21 @@ { "parameters": [ { + "name": "thread", + "help": "Enable/disable multi-threaded TCG", + "type": "string" + }, + { + "name": "accel", + "help": "Select the type of accelerator", + "type": "string" + } + ], + "option": "accel" + }, + { + "parameters": [ + { "name": "dea-key-wrap", "help": "enable/disable DEA key wrapping using the CPACF wrapping key", "type": "boolean" @@ -6375,14 +6674,26 @@ "arg-type": "17" }, { - "name": "query-vnc", + "name": "query-vm-generation-id", "ret-type": "156", "meta-type": "command", "arg-type": "17" }, { + "name": "query-vnc", + "ret-type": "157", + "meta-type": "command", + "arg-type": "17" + }, + { "name": "query-vnc-servers", - "ret-type": "[157]", + "ret-type": "[158]", + "meta-type": "command", + "arg-type": "17" + }, + { + "name": "query-xen-replication-status", + "ret-type": "159", "meta-type": "command", "arg-type": "17" }, @@ -6396,19 +6707,19 @@ "name": "remove-fd", "ret-type": "17", "meta-type": "command", - "arg-type": "158" + "arg-type": "160" }, { "name": "ringbuf-read", "ret-type": "str", "meta-type": "command", - "arg-type": "159" + "arg-type": "161" }, { "name": "ringbuf-write", "ret-type": "17", "meta-type": "command", - "arg-type": "160" + "arg-type": "162" }, { "name": "rtc-reset-reinjection", @@ -6420,25 +6731,25 @@ "name": "screendump", "ret-type": "17", "meta-type": "command", - "arg-type": "161" + "arg-type": "163" }, { "name": "send-key", "ret-type": "17", "meta-type": "command", - "arg-type": "162" + "arg-type": "164" }, { "name": "set_link", "ret-type": "17", "meta-type": "command", - "arg-type": "163" + "arg-type": "165" }, { "name": "set_password", "ret-type": "17", "meta-type": "command", - "arg-type": "164" + "arg-type": "166" }, { "name": "stop", @@ -6466,45 +6777,45 @@ }, { "name": "trace-event-get-state", - "ret-type": "[166]", - "meta-type": "command", - "arg-type": "165" - }, - { - "name": "trace-event-set-state", - "ret-type": "17", + "ret-type": "[168]", "meta-type": "command", "arg-type": "167" }, { + "name": "trace-event-set-state", + "ret-type": "17", + "meta-type": "command", + "arg-type": "169" + }, + { "name": "transaction", "ret-type": "17", "meta-type": "command", - "arg-type": "168" + "arg-type": "170" }, { "name": "x-blockdev-change", "ret-type": "17", "meta-type": "command", - "arg-type": "169" + "arg-type": "171" }, { "name": "x-blockdev-del", "ret-type": "17", "meta-type": "command", - "arg-type": "170" + "arg-type": "172" }, { "name": "x-blockdev-insert-medium", "ret-type": "17", "meta-type": "command", - "arg-type": "171" + "arg-type": "173" }, { "name": "x-blockdev-remove-medium", "ret-type": "17", "meta-type": "command", - "arg-type": "172" + "arg-type": "174" }, { "name": "x-colo-lost-heartbeat", @@ -6513,22 +6824,34 @@ "arg-type": "17" }, { + "name": "xen-colo-do-checkpoint", + "ret-type": "17", + "meta-type": "command", + "arg-type": "17" + }, + { "name": "xen-load-devices-state", "ret-type": "17", "meta-type": "command", - "arg-type": "173" + "arg-type": "175" }, { "name": "xen-save-devices-state", "ret-type": "17", "meta-type": "command", - "arg-type": "174" + "arg-type": "176" }, { "name": "xen-set-global-dirty-log", "ret-type": "17", "meta-type": "command", - "arg-type": "175" + "arg-type": "177" + }, + { + "name": "xen-set-replication", + "ret-type": "17", + "meta-type": "command", + "arg-type": "178" }, { "name": "0", @@ -6596,11 +6919,11 @@ }, { "name": "operation", - "type": "176" + "type": "179" }, { "name": "action", - "type": "177" + "type": "180" }, { "name": "nospace", @@ -6619,7 +6942,7 @@ "members": [ { "name": "type", - "type": "178" + "type": "181" }, { "name": "device", @@ -6645,7 +6968,7 @@ "members": [ { "name": "type", - "type": "178" + "type": "181" }, { "name": "device", @@ -6680,11 +7003,11 @@ }, { "name": "operation", - "type": "176" + "type": "179" }, { "name": "action", - "type": "177" + "type": "180" } ], "meta-type": "object" @@ -6694,7 +7017,7 @@ "members": [ { "name": "type", - "type": "178" + "type": "181" }, { "name": "device", @@ -6786,12 +7109,12 @@ "members": [ { "name": "action", - "type": "179" + "type": "182" }, { "name": "info", "default": null, - "type": "180" + "type": "183" } ], "meta-type": "object" @@ -6815,7 +7138,7 @@ "members": [ { "name": "status", - "type": "181" + "type": "184" } ], "meta-type": "object" @@ -6874,7 +7197,7 @@ "members": [ { "name": "type", - "type": "182" + "type": "185" }, { "name": "error", @@ -6911,11 +7234,11 @@ "members": [ { "name": "server", - "type": "183" + "type": "186" }, { "name": "client", - "type": "183" + "type": "186" } ], "meta-type": "object" @@ -6925,11 +7248,11 @@ "members": [ { "name": "server", - "type": "183" + "type": "186" }, { "name": "client", - "type": "183" + "type": "186" } ], "meta-type": "object" @@ -6939,25 +7262,25 @@ "members": [ { "name": "server", - "type": "184" - }, - { - "name": "client", - "type": "185" - } - ], - "meta-type": "object" - }, - { - "name": "24", - "members": [ - { - "name": "server", - "type": "186" - }, - { - "name": "client", "type": "187" + }, + { + "name": "client", + "type": "188" + } + ], + "meta-type": "object" + }, + { + "name": "24", + "members": [ + { + "name": "server", + "type": "189" + }, + { + "name": "client", + "type": "190" } ], "meta-type": "object" @@ -6967,11 +7290,11 @@ "members": [ { "name": "server", - "type": "186" + "type": "189" }, { "name": "client", - "type": "188" + "type": "191" } ], "meta-type": "object" @@ -6981,11 +7304,11 @@ "members": [ { "name": "server", - "type": "186" + "type": "189" }, { "name": "client", - "type": "188" + "type": "191" } ], "meta-type": "object" @@ -7009,7 +7332,7 @@ "members": [ { "name": "action", - "type": "189" + "type": "192" } ], "meta-type": "object" @@ -7109,6 +7432,11 @@ "name": "speed", "default": null, "type": "int" + }, + { + "name": "filter-node-name", + "default": null, + "type": "str" } ], "meta-type": "object" @@ -7254,7 +7582,7 @@ { "name": "on-error", "default": null, - "type": "190" + "type": "193" } ], "meta-type": "object" @@ -7414,138 +7742,146 @@ "tag": "driver", "variants": [ { - "case": "archipelago", - "type": "195" - }, - { "case": "blkdebug", - "type": "196" + "type": "198" }, { "case": "blkverify", - "type": "197" + "type": "199" }, { "case": "bochs", - "type": "198" + "type": "200" }, { "case": "cloop", - "type": "198" + "type": "200" }, { "case": "dmg", - "type": "198" + "type": "200" }, { "case": "file", - "type": "199" + "type": "201" }, { "case": "ftp", - "type": "200" + "type": "202" }, { "case": "ftps", - "type": "200" + "type": "202" }, { "case": "gluster", - "type": "201" + "type": "203" }, { "case": "host_cdrom", - "type": "199" + "type": "201" }, { "case": "host_device", - "type": "199" + "type": "201" }, { "case": "http", - "type": "200" + "type": "202" }, { "case": "https", - "type": "200" - }, - { - "case": "luks", "type": "202" }, { + "case": "iscsi", + "type": "204" + }, + { + "case": "luks", + "type": "205" + }, + { "case": "nbd", - "type": "203" + "type": "206" }, { "case": "nfs", - "type": "204" + "type": "207" }, { "case": "null-aio", - "type": "205" + "type": "208" }, { "case": "null-co", - "type": "205" + "type": "208" }, { "case": "parallels", - "type": "198" + "type": "200" }, { "case": "qcow2", - "type": "206" + "type": "209" }, { "case": "qcow", - "type": "207" + "type": "210" }, { "case": "qed", - "type": "207" + "type": "210" }, { "case": "quorum", - "type": "208" + "type": "211" }, { "case": "raw", - "type": "209" + "type": "212" + }, + { + "case": "rbd", + "type": "213" }, { "case": "replication", - "type": "210" + "type": "214" + }, + { + "case": "sheepdog", + "type": "215" }, { "case": "ssh", - "type": "211" + "type": "216" }, { "case": "vdi", - "type": "198" + "type": "200" }, { "case": "vhdx", - "type": "198" + "type": "200" }, { "case": "vmdk", - "type": "207" + "type": "210" }, { "case": "vpc", - "type": "198" + "type": "200" }, { "case": "vvfat", - "type": "212" + "type": "217" } ], "members": [ { "name": "driver", - "type": "191" + "type": "194" }, { "name": "node-name", @@ -7555,12 +7891,12 @@ { "name": "discard", "default": null, - "type": "192" + "type": "195" }, { "name": "cache", "default": null, - "type": "193" + "type": "196" }, { "name": "read-only", @@ -7570,7 +7906,7 @@ { "name": "detect-zeroes", "default": null, - "type": "194" + "type": "197" } ], "meta-type": "object" @@ -7593,7 +7929,7 @@ }, { "name": "sync", - "type": "213" + "type": "218" }, { "name": "speed", @@ -7608,12 +7944,12 @@ { "name": "on-source-error", "default": null, - "type": "190" + "type": "193" }, { "name": "on-target-error", "default": null, - "type": "190" + "type": "193" } ], "meta-type": "object" @@ -7643,7 +7979,7 @@ { "name": "read-only-mode", "default": null, - "type": "214" + "type": "219" } ], "meta-type": "object" @@ -7687,7 +8023,7 @@ }, { "name": "sync", - "type": "213" + "type": "218" }, { "name": "speed", @@ -7707,12 +8043,17 @@ { "name": "on-source-error", "default": null, - "type": "190" + "type": "193" }, { "name": "on-target-error", "default": null, - "type": "190" + "type": "193" + }, + { + "name": "filter-node-name", + "default": null, + "type": "str" } ], "meta-type": "object" @@ -7850,7 +8191,7 @@ { "name": "mode", "default": null, - "type": "215" + "type": "220" } ], "meta-type": "object" @@ -7911,7 +8252,7 @@ }, { "name": "backend", - "type": "216" + "type": "221" } ], "meta-type": "object" @@ -8083,12 +8424,12 @@ }, { "name": "sync", - "type": "213" + "type": "218" }, { "name": "mode", "default": null, - "type": "215" + "type": "220" }, { "name": "speed", @@ -8108,12 +8449,12 @@ { "name": "on-source-error", "default": null, - "type": "190" + "type": "193" }, { "name": "on-target-error", "default": null, - "type": "190" + "type": "193" } ], "meta-type": "object" @@ -8151,12 +8492,12 @@ }, { "name": "sync", - "type": "213" + "type": "218" }, { "name": "mode", "default": null, - "type": "215" + "type": "220" }, { "name": "speed", @@ -8176,12 +8517,12 @@ { "name": "on-source-error", "default": null, - "type": "190" + "type": "193" }, { "name": "on-target-error", "default": null, - "type": "190" + "type": "193" }, { "name": "unmap", @@ -8220,7 +8561,7 @@ { "name": "format", "default": null, - "type": "217" + "type": "222" } ], "meta-type": "object" @@ -8315,7 +8656,7 @@ }, { "name": "events", - "type": "[218]" + "type": "[223]" } ], "meta-type": "object" @@ -8494,7 +8835,7 @@ "members": [ { "name": "addr", - "type": "219" + "type": "224" }, { "name": "tls-creds", @@ -8691,7 +9032,7 @@ }, { "name": "slot-type", - "type": "220" + "type": "225" }, { "name": "source", @@ -8751,12 +9092,12 @@ { "name": "io-status", "default": null, - "type": "221" + "type": "226" }, { "name": "dirty-bitmaps", "default": null, - "type": "[222]" + "type": "[227]" } ], "meta-type": "object" @@ -8799,7 +9140,7 @@ }, { "name": "io-status", - "type": "221" + "type": "226" }, { "name": "ready", @@ -8839,7 +9180,7 @@ }, { "name": "stats", - "type": "223" + "type": "228" }, { "name": "parent", @@ -8917,7 +9258,7 @@ }, { "name": "parameters", - "type": "[224]" + "type": "[229]" } ], "meta-type": "object" @@ -8975,11 +9316,11 @@ "members": [ { "name": "modela", - "type": "225" + "type": "230" }, { "name": "modelb", - "type": "225" + "type": "230" } ], "meta-type": "object" @@ -8989,7 +9330,7 @@ "members": [ { "name": "model", - "type": "225" + "type": "230" } ], "meta-type": "object" @@ -8999,11 +9340,11 @@ "members": [ { "name": "modela", - "type": "225" + "type": "230" }, { "name": "modelb", - "type": "225" + "type": "230" } ], "meta-type": "object" @@ -9013,7 +9354,7 @@ "members": [ { "name": "result", - "type": "226" + "type": "231" }, { "name": "responsible-properties", @@ -9027,11 +9368,11 @@ "members": [ { "name": "type", - "type": "227" + "type": "232" }, { "name": "model", - "type": "225" + "type": "230" } ], "meta-type": "object" @@ -9041,7 +9382,7 @@ "members": [ { "name": "model", - "type": "225" + "type": "230" } ], "meta-type": "object" @@ -9057,27 +9398,27 @@ "variants": [ { "case": "x86", - "type": "229" + "type": "234" }, { "case": "sparc", - "type": "230" + "type": "235" }, { "case": "ppc", - "type": "231" + "type": "236" }, { "case": "mips", - "type": "232" + "type": "237" }, { "case": "tricore", - "type": "233" + "type": "238" }, { "case": "other", - "type": "234" + "type": "239" } ], "members": [ @@ -9103,7 +9444,7 @@ }, { "name": "arch", - "type": "228" + "type": "233" } ], "meta-type": "object" @@ -9113,7 +9454,7 @@ "members": [ { "name": "status", - "type": "235" + "type": "240" }, { "name": "completed", @@ -9131,7 +9472,7 @@ "members": [ { "name": "formats", - "type": "[217]" + "type": "[222]" } ], "meta-type": "object" @@ -9165,7 +9506,7 @@ }, { "name": "fds", - "type": "[236]" + "type": "[241]" } ], "meta-type": "object" @@ -9211,7 +9552,7 @@ }, { "name": "props", - "type": "237" + "type": "242" }, { "name": "qom-path", @@ -9236,6 +9577,18 @@ { "name": "thread-id", "type": "int" + }, + { + "name": "poll-max-ns", + "type": "int" + }, + { + "name": "poll-grow", + "type": "int" + }, + { + "name": "poll-shrink", + "type": "int" } ], "meta-type": "object" @@ -9322,7 +9675,7 @@ }, { "name": "policy", - "type": "238" + "type": "243" } ], "meta-type": "object" @@ -9338,13 +9691,13 @@ "variants": [ { "case": "dimm", - "type": "240" + "type": "245" } ], "members": [ { "name": "type", - "type": "239" + "type": "244" } ], "meta-type": "object" @@ -9382,22 +9735,22 @@ { "name": "status", "default": null, - "type": "181" + "type": "184" }, { "name": "ram", "default": null, - "type": "241" + "type": "246" }, { "name": "disk", "default": null, - "type": "241" + "type": "246" }, { "name": "xbzrle-cache", "default": null, - "type": "242" + "type": "247" }, { "name": "total-time", @@ -9447,7 +9800,7 @@ "members": [ { "name": "capability", - "type": "243" + "type": "248" }, { "name": "state", @@ -9511,7 +9864,7 @@ }, { "name": "detect_zeroes", - "type": "194" + "type": "197" }, { "name": "bps", @@ -9539,7 +9892,7 @@ }, { "name": "image", - "type": "244" + "type": "249" }, { "name": "bps_max", @@ -9613,7 +9966,7 @@ }, { "name": "cache", - "type": "245" + "type": "250" }, { "name": "write_threshold", @@ -9636,7 +9989,7 @@ }, { "name": "devices", - "type": "[246]" + "type": "[251]" } ], "meta-type": "object" @@ -9652,31 +10005,31 @@ "variants": [ { "case": "builtin", - "type": "248" + "type": "253" }, { "case": "enum", - "type": "249" + "type": "254" }, { "case": "array", - "type": "250" + "type": "255" }, { "case": "object", - "type": "251" + "type": "256" }, { "case": "alternate", - "type": "252" + "type": "257" }, { "case": "command", - "type": "253" + "type": "258" }, { "case": "event", - "type": "254" + "type": "259" } ], "members": [ @@ -9686,7 +10039,7 @@ }, { "name": "meta-type", - "type": "247" + "type": "252" } ], "meta-type": "object" @@ -9752,15 +10105,15 @@ }, { "name": "key", - "type": "255" + "type": "260" }, { "name": "mask", - "type": "256" + "type": "261" }, { "name": "action", - "type": "257" + "type": "262" } ], "meta-type": "object" @@ -9890,11 +10243,11 @@ }, { "name": "duplex", - "type": "258" + "type": "263" }, { "name": "autoneg", - "type": "259" + "type": "264" } ], "meta-type": "object" @@ -9928,15 +10281,15 @@ }, { "name": "multicast", - "type": "260" + "type": "265" }, { "name": "unicast", - "type": "260" + "type": "265" }, { "name": "vlan", - "type": "260" + "type": "265" }, { "name": "broadcast-allowed", @@ -10007,12 +10360,12 @@ }, { "name": "mouse-mode", - "type": "261" + "type": "266" }, { "name": "channels", "default": null, - "type": "[185]" + "type": "[188]" } ], "meta-type": "object" @@ -10030,7 +10383,7 @@ }, { "name": "status", - "type": "262" + "type": "267" } ], "meta-type": "object" @@ -10063,7 +10416,7 @@ }, { "name": "options", - "type": "263" + "type": "268" } ], "meta-type": "object" @@ -10107,7 +10460,7 @@ "members": [ { "name": "qemu", - "type": "264" + "type": "269" }, { "name": "package", @@ -10120,85 +10473,80 @@ "name": "156", "members": [ { - "name": "enabled", - "type": "bool" - }, - { - "name": "host", - "default": null, + "name": "guid", "type": "str" - }, - { - "name": "family", - "default": null, - "type": "265" - }, - { - "name": "service", - "default": null, - "type": "str" - }, - { - "name": "auth", - "default": null, - "type": "str" - }, - { - "name": "clients", - "default": null, - "type": "[188]" } ], "meta-type": "object" }, { - "name": "[157]", - "element-type": "157", - "meta-type": "array" - }, - { "name": "157", "members": [ { - "name": "id", + "name": "enabled", + "type": "bool" + }, + { + "name": "host", + "default": null, "type": "str" }, { - "name": "server", - "type": "[266]" + "name": "family", + "default": null, + "type": "270" }, { - "name": "clients", - "type": "[188]" + "name": "service", + "default": null, + "type": "str" }, { "name": "auth", - "type": "267" - }, - { - "name": "vencrypt", - "default": null, - "type": "268" - }, - { - "name": "display", "default": null, "type": "str" + }, + { + "name": "clients", + "default": null, + "type": "[191]" } ], "meta-type": "object" }, { + "name": "[158]", + "element-type": "158", + "meta-type": "array" + }, + { "name": "158", "members": [ { - "name": "fdset-id", - "type": "int" + "name": "id", + "type": "str" }, { - "name": "fd", + "name": "server", + "type": "[271]" + }, + { + "name": "clients", + "type": "[191]" + }, + { + "name": "auth", + "type": "272" + }, + { + "name": "vencrypt", + "default": null, + "type": "273" + }, + { + "name": "display", "default": null, - "type": "int" + "type": "str" } ], "meta-type": "object" @@ -10207,17 +10555,13 @@ "name": "159", "members": [ { - "name": "device", - "type": "str" + "name": "error", + "type": "bool" }, { - "name": "size", - "type": "int" - }, - { - "name": "format", + "name": "desc", "default": null, - "type": "269" + "type": "str" } ], "meta-type": "object" @@ -10226,17 +10570,13 @@ "name": "160", "members": [ { - "name": "device", - "type": "str" + "name": "fdset-id", + "type": "int" }, { - "name": "data", - "type": "str" - }, - { - "name": "format", + "name": "fd", "default": null, - "type": "269" + "type": "int" } ], "meta-type": "object" @@ -10245,8 +10585,17 @@ "name": "161", "members": [ { - "name": "filename", + "name": "device", "type": "str" + }, + { + "name": "size", + "type": "int" + }, + { + "name": "format", + "default": null, + "type": "274" } ], "meta-type": "object" @@ -10255,13 +10604,17 @@ "name": "162", "members": [ { - "name": "keys", - "type": "[270]" + "name": "device", + "type": "str" }, { - "name": "hold-time", + "name": "data", + "type": "str" + }, + { + "name": "format", "default": null, - "type": "int" + "type": "274" } ], "meta-type": "object" @@ -10270,12 +10623,8 @@ "name": "163", "members": [ { - "name": "name", + "name": "filename", "type": "str" - }, - { - "name": "up", - "type": "bool" } ], "meta-type": "object" @@ -10284,17 +10633,13 @@ "name": "164", "members": [ { - "name": "protocol", - "type": "str" + "name": "keys", + "type": "[275]" }, { - "name": "password", - "type": "str" - }, - { - "name": "connected", + "name": "hold-time", "default": null, - "type": "str" + "type": "int" } ], "meta-type": "object" @@ -10307,32 +10652,27 @@ "type": "str" }, { - "name": "vcpu", - "default": null, - "type": "int" + "name": "up", + "type": "bool" } ], "meta-type": "object" }, { - "name": "[166]", - "element-type": "166", - "meta-type": "array" - }, - { "name": "166", "members": [ { - "name": "name", + "name": "protocol", "type": "str" }, { - "name": "state", - "type": "271" + "name": "password", + "type": "str" }, { - "name": "vcpu", - "type": "bool" + "name": "connected", + "default": null, + "type": "str" } ], "meta-type": "object" @@ -10345,15 +10685,6 @@ "type": "str" }, { - "name": "enable", - "type": "bool" - }, - { - "name": "ignore-unavailable", - "default": null, - "type": "bool" - }, - { "name": "vcpu", "default": null, "type": "int" @@ -10362,16 +10693,24 @@ "meta-type": "object" }, { + "name": "[168]", + "element-type": "168", + "meta-type": "array" + }, + { "name": "168", "members": [ { - "name": "actions", - "type": "[272]" + "name": "name", + "type": "str" }, { - "name": "properties", - "default": null, - "type": "273" + "name": "state", + "type": "276" + }, + { + "name": "vcpu", + "type": "bool" } ], "meta-type": "object" @@ -10380,18 +10719,22 @@ "name": "169", "members": [ { - "name": "parent", + "name": "name", "type": "str" }, { - "name": "child", + "name": "enable", + "type": "bool" + }, + { + "name": "ignore-unavailable", "default": null, - "type": "str" + "type": "bool" }, { - "name": "node", + "name": "vcpu", "default": null, - "type": "str" + "type": "int" } ], "meta-type": "object" @@ -10400,8 +10743,13 @@ "name": "170", "members": [ { - "name": "node-name", - "type": "str" + "name": "actions", + "type": "[277]" + }, + { + "name": "properties", + "default": null, + "type": "278" } ], "meta-type": "object" @@ -10410,17 +10758,17 @@ "name": "171", "members": [ { - "name": "device", - "default": null, + "name": "parent", "type": "str" }, { - "name": "id", + "name": "child", "default": null, "type": "str" }, { - "name": "node-name", + "name": "node", + "default": null, "type": "str" } ], @@ -10430,13 +10778,7 @@ "name": "172", "members": [ { - "name": "device", - "default": null, - "type": "str" - }, - { - "name": "id", - "default": null, + "name": "node-name", "type": "str" } ], @@ -10446,7 +10788,17 @@ "name": "173", "members": [ { - "name": "filename", + "name": "device", + "default": null, + "type": "str" + }, + { + "name": "id", + "default": null, + "type": "str" + }, + { + "name": "node-name", "type": "str" } ], @@ -10456,7 +10808,13 @@ "name": "174", "members": [ { - "name": "filename", + "name": "device", + "default": null, + "type": "str" + }, + { + "name": "id", + "default": null, "type": "str" } ], @@ -10466,6 +10824,26 @@ "name": "175", "members": [ { + "name": "filename", + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "176", + "members": [ + { + "name": "filename", + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "177", + "members": [ + { "name": "enable", "type": "bool" } @@ -10473,12 +10851,31 @@ "meta-type": "object" }, { + "name": "178", + "members": [ + { + "name": "enable", + "type": "bool" + }, + { + "name": "primary", + "type": "bool" + }, + { + "name": "failover", + "default": null, + "type": "bool" + } + ], + "meta-type": "object" + }, + { "name": "bool", "json-type": "boolean", "meta-type": "builtin" }, { - "name": "176", + "name": "179", "meta-type": "enum", "values": [ "read", @@ -10486,7 +10883,7 @@ ] }, { - "name": "177", + "name": "180", "meta-type": "enum", "values": [ "ignore", @@ -10495,7 +10892,7 @@ ] }, { - "name": "178", + "name": "181", "meta-type": "enum", "values": [ "commit", @@ -10505,7 +10902,7 @@ ] }, { - "name": "179", + "name": "182", "meta-type": "enum", "values": [ "pause", @@ -10513,24 +10910,24 @@ ] }, { - "name": "180", + "name": "183", "tag": "type", "variants": [ { "case": "hyper-v", - "type": "275" + "type": "280" } ], "members": [ { "name": "type", - "type": "274" + "type": "279" } ], "meta-type": "object" }, { - "name": "181", + "name": "184", "meta-type": "enum", "values": [ "none", @@ -10545,7 +10942,7 @@ ] }, { - "name": "182", + "name": "185", "meta-type": "enum", "values": [ "read", @@ -10554,81 +10951,6 @@ ] }, { - "name": "183", - "members": [ - { - "name": "host", - "type": "str" - }, - { - "name": "port", - "type": "str" - }, - { - "name": "family", - "type": "265" - } - ], - "meta-type": "object" - }, - { - "name": "184", - "members": [ - { - "name": "host", - "type": "str" - }, - { - "name": "port", - "type": "str" - }, - { - "name": "family", - "type": "265" - }, - { - "name": "auth", - "default": null, - "type": "str" - } - ], - "meta-type": "object" - }, - { - "name": "185", - "members": [ - { - "name": "host", - "type": "str" - }, - { - "name": "port", - "type": "str" - }, - { - "name": "family", - "type": "265" - }, - { - "name": "connection-id", - "type": "int" - }, - { - "name": "channel-type", - "type": "int" - }, - { - "name": "channel-id", - "type": "int" - }, - { - "name": "tls", - "type": "bool" - } - ], - "meta-type": "object" - }, - { "name": "186", "members": [ { @@ -10636,21 +10958,12 @@ "type": "str" }, { - "name": "service", + "name": "port", "type": "str" }, { "name": "family", - "type": "265" - }, - { - "name": "websocket", - "type": "bool" - }, - { - "name": "auth", - "default": null, - "type": "str" + "type": "270" } ], "meta-type": "object" @@ -10663,16 +10976,17 @@ "type": "str" }, { - "name": "service", + "name": "port", "type": "str" }, { "name": "family", - "type": "265" + "type": "270" }, { - "name": "websocket", - "type": "bool" + "name": "auth", + "default": null, + "type": "str" } ], "meta-type": "object" @@ -10685,12 +10999,95 @@ "type": "str" }, { + "name": "port", + "type": "str" + }, + { + "name": "family", + "type": "270" + }, + { + "name": "connection-id", + "type": "int" + }, + { + "name": "channel-type", + "type": "int" + }, + { + "name": "channel-id", + "type": "int" + }, + { + "name": "tls", + "type": "bool" + } + ], + "meta-type": "object" + }, + { + "name": "189", + "members": [ + { + "name": "host", + "type": "str" + }, + { + "name": "service", + "type": "str" + }, + { + "name": "family", + "type": "270" + }, + { + "name": "websocket", + "type": "bool" + }, + { + "name": "auth", + "default": null, + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "190", + "members": [ + { + "name": "host", + "type": "str" + }, + { + "name": "service", + "type": "str" + }, + { + "name": "family", + "type": "270" + }, + { + "name": "websocket", + "type": "bool" + } + ], + "meta-type": "object" + }, + { + "name": "191", + "members": [ + { + "name": "host", + "type": "str" + }, + { "name": "service", "type": "str" }, { "name": "family", - "type": "265" + "type": "270" }, { "name": "websocket", @@ -10710,7 +11107,7 @@ "meta-type": "object" }, { - "name": "189", + "name": "192", "meta-type": "enum", "values": [ "reset", @@ -10723,7 +11120,7 @@ ] }, { - "name": "190", + "name": "193", "meta-type": "enum", "values": [ "report", @@ -10734,10 +11131,9 @@ ] }, { - "name": "191", + "name": "194", "meta-type": "enum", "values": [ - "archipelago", "blkdebug", "blkverify", "bochs", @@ -10751,6 +11147,7 @@ "host_device", "http", "https", + "iscsi", "luks", "nbd", "nfs", @@ -10762,7 +11159,9 @@ "qed", "quorum", "raw", + "rbd", "replication", + "sheepdog", "ssh", "vdi", "vhdx", @@ -10772,69 +11171,44 @@ ] }, { - "name": "192", - "meta-type": "enum", - "values": [ - "ignore", - "unmap" - ] - }, - { - "name": "193", - "members": [ - { - "name": "direct", - "default": null, - "type": "bool" - }, - { - "name": "no-flush", - "default": null, - "type": "bool" - } - ], - "meta-type": "object" - }, - { - "name": "194", - "meta-type": "enum", - "values": [ - "off", - "on", - "unmap" - ] - }, - { "name": "195", - "members": [ - { - "name": "volume", - "type": "str" - }, - { - "name": "mport", - "default": null, - "type": "int" - }, - { - "name": "vport", - "default": null, - "type": "int" - }, - { - "name": "segment", - "default": null, - "type": "str" - } - ], - "meta-type": "object" + "meta-type": "enum", + "values": [ + "ignore", + "unmap" + ] }, { "name": "196", "members": [ { + "name": "direct", + "default": null, + "type": "bool" + }, + { + "name": "no-flush", + "default": null, + "type": "bool" + } + ], + "meta-type": "object" + }, + { + "name": "197", + "meta-type": "enum", + "values": [ + "off", + "on", + "unmap" + ] + }, + { + "name": "198", + "members": [ + { "name": "image", - "type": "276" + "type": "281" }, { "name": "config", @@ -10849,51 +11223,26 @@ { "name": "inject-error", "default": null, - "type": "[277]" + "type": "[282]" }, { "name": "set-state", "default": null, - "type": "[278]" + "type": "[283]" } ], "meta-type": "object" }, { - "name": "197", + "name": "199", "members": [ { "name": "test", - "type": "276" + "type": "281" }, { "name": "raw", - "type": "276" - } - ], - "meta-type": "object" - }, - { - "name": "198", - "members": [ - { - "name": "file", - "type": "276" - } - ], - "meta-type": "object" - }, - { - "name": "199", - "members": [ - { - "name": "filename", - "type": "str" - }, - { - "name": "aio", - "default": null, - "type": "279" + "type": "281" } ], "meta-type": "object" @@ -10902,8 +11251,8 @@ "name": "200", "members": [ { - "name": "filename", - "type": "str" + "name": "file", + "type": "281" } ], "meta-type": "object" @@ -10912,26 +11261,13 @@ "name": "201", "members": [ { - "name": "volume", + "name": "filename", "type": "str" }, { - "name": "path", - "type": "str" - }, - { - "name": "server", - "type": "[280]" - }, - { - "name": "debug", + "name": "aio", "default": null, - "type": "int" - }, - { - "name": "logfile", - "default": null, - "type": "str" + "type": "284" } ], "meta-type": "object" @@ -10940,12 +11276,7 @@ "name": "202", "members": [ { - "name": "file", - "type": "276" - }, - { - "name": "key-secret", - "default": null, + "name": "filename", "type": "str" } ], @@ -10955,16 +11286,24 @@ "name": "203", "members": [ { + "name": "volume", + "type": "str" + }, + { + "name": "path", + "type": "str" + }, + { "name": "server", - "type": "219" + "type": "[285]" }, { - "name": "export", + "name": "debug", "default": null, - "type": "str" + "type": "int" }, { - "name": "tls-creds", + "name": "logfile", "default": null, "type": "str" } @@ -10975,10 +11314,93 @@ "name": "204", "members": [ { - "name": "server", + "name": "transport", + "type": "286" + }, + { + "name": "portal", + "type": "str" + }, + { + "name": "target", + "type": "str" + }, + { + "name": "lun", + "default": null, + "type": "int" + }, + { + "name": "user", + "default": null, + "type": "str" + }, + { + "name": "password-secret", + "default": null, + "type": "str" + }, + { + "name": "initiator-name", + "default": null, + "type": "str" + }, + { + "name": "header-digest", + "default": null, + "type": "287" + }, + { + "name": "timeout", + "default": null, + "type": "int" + } + ], + "meta-type": "object" + }, + { + "name": "205", + "members": [ + { + "name": "file", "type": "281" }, { + "name": "key-secret", + "default": null, + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "206", + "members": [ + { + "name": "server", + "type": "224" + }, + { + "name": "export", + "default": null, + "type": "str" + }, + { + "name": "tls-creds", + "default": null, + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "207", + "members": [ + { + "name": "server", + "type": "288" + }, + { "name": "path", "type": "str" }, @@ -11016,7 +11438,7 @@ "meta-type": "object" }, { - "name": "205", + "name": "208", "members": [ { "name": "size", @@ -11032,16 +11454,16 @@ "meta-type": "object" }, { - "name": "206", + "name": "209", "members": [ { "name": "file", - "type": "276" + "type": "281" }, { "name": "backing", "default": null, - "type": "276" + "type": "281" }, { "name": "lazy-refcounts", @@ -11066,7 +11488,7 @@ { "name": "overlap-check", "default": null, - "type": "282" + "type": "289" }, { "name": "cache-size", @@ -11092,22 +11514,22 @@ "meta-type": "object" }, { - "name": "207", + "name": "210", "members": [ { "name": "file", - "type": "276" + "type": "281" }, { "name": "backing", "default": null, - "type": "276" + "type": "281" } ], "meta-type": "object" }, { - "name": "208", + "name": "211", "members": [ { "name": "blkverify", @@ -11116,7 +11538,7 @@ }, { "name": "children", - "type": "[276]" + "type": "[281]" }, { "name": "vote-threshold", @@ -11130,65 +11552,7 @@ { "name": "read-pattern", "default": null, - "type": "283" - } - ], - "meta-type": "object" - }, - { - "name": "209", - "members": [ - { - "name": "file", - "type": "276" - }, - { - "name": "offset", - "default": null, - "type": "int" - }, - { - "name": "size", - "default": null, - "type": "int" - } - ], - "meta-type": "object" - }, - { - "name": "210", - "members": [ - { - "name": "file", - "type": "276" - }, - { - "name": "mode", - "type": "284" - }, - { - "name": "top-id", - "default": null, - "type": "str" - } - ], - "meta-type": "object" - }, - { - "name": "211", - "members": [ - { - "name": "server", - "type": "285" - }, - { - "name": "path", - "type": "str" - }, - { - "name": "user", - "default": null, - "type": "str" + "type": "290" } ], "meta-type": "object" @@ -11197,6 +11561,132 @@ "name": "212", "members": [ { + "name": "file", + "type": "281" + }, + { + "name": "offset", + "default": null, + "type": "int" + }, + { + "name": "size", + "default": null, + "type": "int" + } + ], + "meta-type": "object" + }, + { + "name": "213", + "members": [ + { + "name": "pool", + "type": "str" + }, + { + "name": "image", + "type": "str" + }, + { + "name": "conf", + "default": null, + "type": "str" + }, + { + "name": "snapshot", + "default": null, + "type": "str" + }, + { + "name": "user", + "default": null, + "type": "str" + }, + { + "name": "server", + "default": null, + "type": "[291]" + }, + { + "name": "auth-supported", + "default": null, + "type": "[292]" + }, + { + "name": "password-secret", + "default": null, + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "214", + "members": [ + { + "name": "file", + "type": "281" + }, + { + "name": "mode", + "type": "293" + }, + { + "name": "top-id", + "default": null, + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "215", + "members": [ + { + "name": "addr", + "type": "285" + }, + { + "name": "vdi", + "type": "str" + }, + { + "name": "snap-id", + "default": null, + "type": "int" + }, + { + "name": "tag", + "default": null, + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "216", + "members": [ + { + "name": "server", + "type": "291" + }, + { + "name": "path", + "type": "str" + }, + { + "name": "user", + "default": null, + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "217", + "members": [ + { "name": "dir", "type": "str" }, @@ -11224,7 +11714,7 @@ "meta-type": "object" }, { - "name": "213", + "name": "218", "meta-type": "enum", "values": [ "top", @@ -11234,7 +11724,7 @@ ] }, { - "name": "214", + "name": "219", "meta-type": "enum", "values": [ "retain", @@ -11243,7 +11733,7 @@ ] }, { - "name": "215", + "name": "220", "meta-type": "enum", "values": [ "existing", @@ -11251,96 +11741,100 @@ ] }, { - "name": "216", + "name": "221", "tag": "type", "variants": [ { "case": "file", - "type": "287" + "type": "295" }, { "case": "serial", - "type": "288" + "type": "296" }, { "case": "parallel", - "type": "288" + "type": "296" }, { "case": "pipe", - "type": "288" + "type": "296" }, { "case": "socket", - "type": "289" + "type": "297" }, { "case": "udp", - "type": "290" + "type": "298" }, { "case": "pty", - "type": "291" + "type": "299" }, { "case": "null", - "type": "291" + "type": "299" }, { "case": "mux", - "type": "292" + "type": "300" }, { "case": "msmouse", - "type": "291" + "type": "299" + }, + { + "case": "wctablet", + "type": "299" }, { "case": "braille", - "type": "291" + "type": "299" }, { "case": "testdev", - "type": "291" + "type": "299" }, { "case": "stdio", - "type": "293" + "type": "301" }, { "case": "console", - "type": "291" + "type": "299" }, { "case": "spicevmc", - "type": "294" + "type": "302" }, { "case": "spiceport", - "type": "295" + "type": "303" }, { "case": "vc", - "type": "296" + "type": "304" }, { "case": "ringbuf", - "type": "297" + "type": "305" }, { "case": "memory", - "type": "297" + "type": "305" } ], "members": [ { "name": "type", - "type": "286" + "type": "294" } ], "meta-type": "object" }, { - "name": "217", + "name": "222", "meta-type": "enum", "values": [ "elf", @@ -11350,35 +11844,35 @@ ] }, { - "name": "[218]", - "element-type": "218", + "name": "[223]", + "element-type": "223", "meta-type": "array" }, { - "name": "218", + "name": "223", "tag": "type", "variants": [ { "case": "key", - "type": "299" + "type": "307" }, { "case": "btn", - "type": "300" + "type": "308" }, { "case": "rel", - "type": "301" + "type": "309" }, { "case": "abs", - "type": "301" + "type": "309" } ], "members": [ { "name": "type", - "type": "298" + "type": "306" } ], "meta-type": "object" @@ -11389,36 +11883,36 @@ "meta-type": "builtin" }, { - "name": "219", + "name": "224", "tag": "type", "variants": [ { "case": "inet", - "type": "303" + "type": "311" }, { "case": "unix", - "type": "304" + "type": "312" }, { "case": "vsock", - "type": "305" + "type": "313" }, { "case": "fd", - "type": "306" + "type": "314" } ], "members": [ { "name": "type", - "type": "302" + "type": "310" } ], "meta-type": "object" }, { - "name": "220", + "name": "225", "meta-type": "enum", "values": [ "DIMM", @@ -11426,7 +11920,7 @@ ] }, { - "name": "221", + "name": "226", "meta-type": "enum", "values": [ "ok", @@ -11435,12 +11929,12 @@ ] }, { - "name": "[222]", - "element-type": "222", + "name": "[227]", + "element-type": "227", "meta-type": "array" }, { - "name": "222", + "name": "227", "members": [ { "name": "name", @@ -11457,13 +11951,13 @@ }, { "name": "status", - "type": "307" + "type": "315" } ], "meta-type": "object" }, { - "name": "223", + "name": "228", "members": [ { "name": "rd_bytes", @@ -11548,18 +12042,18 @@ }, { "name": "timed_stats", - "type": "[308]" + "type": "[316]" } ], "meta-type": "object" }, { - "name": "[224]", - "element-type": "224", + "name": "[229]", + "element-type": "229", "meta-type": "array" }, { - "name": "224", + "name": "229", "members": [ { "name": "name", @@ -11567,7 +12061,7 @@ }, { "name": "type", - "type": "309" + "type": "317" }, { "name": "help", @@ -11588,7 +12082,7 @@ "meta-type": "array" }, { - "name": "225", + "name": "230", "members": [ { "name": "name", @@ -11603,7 +12097,7 @@ "meta-type": "object" }, { - "name": "226", + "name": "231", "meta-type": "enum", "values": [ "incompatible", @@ -11613,7 +12107,7 @@ ] }, { - "name": "227", + "name": "232", "meta-type": "enum", "values": [ "static", @@ -11621,7 +12115,7 @@ ] }, { - "name": "228", + "name": "233", "meta-type": "enum", "values": [ "x86", @@ -11633,96 +12127,35 @@ ] }, { - "name": "229", - "members": [ - { - "name": "pc", - "type": "int" - } - ], - "meta-type": "object" - }, - { - "name": "230", - "members": [ - { - "name": "pc", - "type": "int" - }, - { - "name": "npc", - "type": "int" - } - ], - "meta-type": "object" - }, - { - "name": "231", - "members": [ - { - "name": "nip", - "type": "int" - } - ], - "meta-type": "object" - }, - { - "name": "232", - "members": [ - { - "name": "PC", - "type": "int" - } - ], - "meta-type": "object" - }, - { - "name": "233", - "members": [ - { - "name": "PC", - "type": "int" - } - ], - "meta-type": "object" - }, - { "name": "234", "members": [ + { + "name": "pc", + "type": "int" + } ], "meta-type": "object" }, { "name": "235", - "meta-type": "enum", - "values": [ - "none", - "active", - "completed", - "failed" - ] - }, - { - "name": "[217]", - "element-type": "217", - "meta-type": "array" - }, - { - "name": "[236]", - "element-type": "236", - "meta-type": "array" + "members": [ + { + "name": "pc", + "type": "int" + }, + { + "name": "npc", + "type": "int" + } + ], + "meta-type": "object" }, { "name": "236", "members": [ { - "name": "fd", + "name": "nip", "type": "int" - }, - { - "name": "opaque", - "default": null, - "type": "str" } ], "meta-type": "object" @@ -11731,6 +12164,67 @@ "name": "237", "members": [ { + "name": "PC", + "type": "int" + } + ], + "meta-type": "object" + }, + { + "name": "238", + "members": [ + { + "name": "PC", + "type": "int" + } + ], + "meta-type": "object" + }, + { + "name": "239", + "members": [ + ], + "meta-type": "object" + }, + { + "name": "240", + "meta-type": "enum", + "values": [ + "none", + "active", + "completed", + "failed" + ] + }, + { + "name": "[222]", + "element-type": "222", + "meta-type": "array" + }, + { + "name": "[241]", + "element-type": "241", + "meta-type": "array" + }, + { + "name": "241", + "members": [ + { + "name": "fd", + "type": "int" + }, + { + "name": "opaque", + "default": null, + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "242", + "members": [ + { "name": "node-id", "default": null, "type": "int" @@ -11759,7 +12253,7 @@ "meta-type": "array" }, { - "name": "238", + "name": "243", "meta-type": "enum", "values": [ "default", @@ -11769,24 +12263,24 @@ ] }, { - "name": "239", + "name": "244", "meta-type": "enum", "values": [ "dimm" ] }, { - "name": "240", + "name": "245", "members": [ { "name": "data", - "type": "310" + "type": "318" } ], "meta-type": "object" }, { - "name": "241", + "name": "246", "members": [ { "name": "transferred", @@ -11836,7 +12330,7 @@ "meta-type": "object" }, { - "name": "242", + "name": "247", "members": [ { "name": "cache-size", @@ -11866,7 +12360,7 @@ "meta-type": "object" }, { - "name": "243", + "name": "248", "meta-type": "enum", "values": [ "xbzrle", @@ -11881,7 +12375,7 @@ ] }, { - "name": "244", + "name": "249", "members": [ { "name": "filename", @@ -11943,18 +12437,18 @@ { "name": "backing-image", "default": null, - "type": "244" + "type": "249" }, { "name": "format-specific", "default": null, - "type": "311" + "type": "319" } ], "meta-type": "object" }, { - "name": "245", + "name": "250", "members": [ { "name": "writeback", @@ -11972,12 +12466,12 @@ "meta-type": "object" }, { - "name": "[246]", - "element-type": "246", + "name": "[251]", + "element-type": "251", "meta-type": "array" }, { - "name": "246", + "name": "251", "members": [ { "name": "bus", @@ -11993,11 +12487,11 @@ }, { "name": "class_info", - "type": "312" + "type": "320" }, { "name": "id", - "type": "313" + "type": "321" }, { "name": "irq", @@ -12011,17 +12505,17 @@ { "name": "pci_bridge", "default": null, - "type": "314" + "type": "322" }, { "name": "regions", - "type": "[315]" + "type": "[323]" } ], "meta-type": "object" }, { - "name": "247", + "name": "252", "meta-type": "enum", "values": [ "builtin", @@ -12034,17 +12528,17 @@ ] }, { - "name": "248", + "name": "253", "members": [ { "name": "json-type", - "type": "316" + "type": "324" } ], "meta-type": "object" }, { - "name": "249", + "name": "254", "members": [ { "name": "values", @@ -12054,7 +12548,7 @@ "meta-type": "object" }, { - "name": "250", + "name": "255", "members": [ { "name": "element-type", @@ -12064,11 +12558,11 @@ "meta-type": "object" }, { - "name": "251", + "name": "256", "members": [ { "name": "members", - "type": "[317]" + "type": "[325]" }, { "name": "tag", @@ -12078,23 +12572,23 @@ { "name": "variants", "default": null, - "type": "[318]" + "type": "[326]" } ], "meta-type": "object" }, { - "name": "252", + "name": "257", "members": [ { "name": "members", - "type": "[319]" + "type": "[327]" } ], "meta-type": "object" }, { - "name": "253", + "name": "258", "members": [ { "name": "arg-type", @@ -12108,7 +12602,7 @@ "meta-type": "object" }, { - "name": "254", + "name": "259", "members": [ { "name": "arg-type", @@ -12118,7 +12612,7 @@ "meta-type": "object" }, { - "name": "255", + "name": "260", "members": [ { "name": "priority", @@ -12177,7 +12671,7 @@ "meta-type": "object" }, { - "name": "256", + "name": "261", "members": [ { "name": "in-pport", @@ -12218,7 +12712,7 @@ "meta-type": "object" }, { - "name": "257", + "name": "262", "members": [ { "name": "goto-tbl", @@ -12254,7 +12748,7 @@ "meta-type": "object" }, { - "name": "258", + "name": "263", "meta-type": "enum", "values": [ "half", @@ -12262,7 +12756,7 @@ ] }, { - "name": "259", + "name": "264", "meta-type": "enum", "values": [ "off", @@ -12270,7 +12764,7 @@ ] }, { - "name": "260", + "name": "265", "meta-type": "enum", "values": [ "normal", @@ -12279,7 +12773,7 @@ ] }, { - "name": "261", + "name": "266", "meta-type": "enum", "values": [ "client", @@ -12288,12 +12782,12 @@ ] }, { - "name": "[185]", - "element-type": "185", + "name": "[188]", + "element-type": "188", "meta-type": "array" }, { - "name": "262", + "name": "267", "meta-type": "enum", "values": [ "debug", @@ -12315,24 +12809,24 @@ ] }, { - "name": "263", + "name": "268", "tag": "type", "variants": [ { "case": "passthrough", - "type": "321" + "type": "329" } ], "members": [ { "name": "type", - "type": "320" + "type": "328" } ], "meta-type": "object" }, { - "name": "264", + "name": "269", "members": [ { "name": "major", @@ -12350,7 +12844,7 @@ "meta-type": "object" }, { - "name": "265", + "name": "270", "meta-type": "enum", "values": [ "ipv4", @@ -12361,17 +12855,17 @@ ] }, { - "name": "[188]", - "element-type": "188", + "name": "[191]", + "element-type": "191", "meta-type": "array" }, { - "name": "[266]", - "element-type": "266", + "name": "[271]", + "element-type": "271", "meta-type": "array" }, { - "name": "266", + "name": "271", "members": [ { "name": "host", @@ -12383,7 +12877,7 @@ }, { "name": "family", - "type": "265" + "type": "270" }, { "name": "websocket", @@ -12391,18 +12885,18 @@ }, { "name": "auth", - "type": "267" + "type": "272" }, { "name": "vencrypt", "default": null, - "type": "268" + "type": "273" } ], "meta-type": "object" }, { - "name": "267", + "name": "272", "meta-type": "enum", "values": [ "none", @@ -12417,7 +12911,7 @@ ] }, { - "name": "268", + "name": "273", "meta-type": "enum", "values": [ "plain", @@ -12432,7 +12926,7 @@ ] }, { - "name": "269", + "name": "274", "meta-type": "enum", "values": [ "utf8", @@ -12440,33 +12934,33 @@ ] }, { - "name": "[270]", - "element-type": "270", + "name": "[275]", + "element-type": "275", "meta-type": "array" }, { - "name": "270", + "name": "275", "tag": "type", "variants": [ { "case": "number", - "type": "323" + "type": "331" }, { "case": "qcode", - "type": "324" + "type": "332" } ], "members": [ { "name": "type", - "type": "322" + "type": "330" } ], "meta-type": "object" }, { - "name": "271", + "name": "276", "meta-type": "enum", "values": [ "unavailable", @@ -12475,85 +12969,101 @@ ] }, { - "name": "[272]", - "element-type": "272", + "name": "[277]", + "element-type": "277", "meta-type": "array" }, { - "name": "272", + "name": "277", "tag": "type", "variants": [ { "case": "abort", - "type": "326" + "type": "334" }, { "case": "block-dirty-bitmap-add", - "type": "327" + "type": "335" }, { "case": "block-dirty-bitmap-clear", - "type": "328" + "type": "336" }, { "case": "blockdev-backup", - "type": "329" + "type": "337" }, { "case": "blockdev-snapshot", - "type": "330" + "type": "338" }, { "case": "blockdev-snapshot-internal-sync", - "type": "331" + "type": "339" }, { "case": "blockdev-snapshot-sync", - "type": "332" + "type": "340" }, { "case": "drive-backup", + "type": "341" + } + ], + "members": [ + { + "name": "type", "type": "333" } ], - "members": [ - { - "name": "type", - "type": "325" - } - ], "meta-type": "object" }, { - "name": "273", + "name": "278", "members": [ { "name": "completion-mode", "default": null, - "type": "334" + "type": "342" } ], "meta-type": "object" }, { - "name": "274", + "name": "279", "meta-type": "enum", "values": [ "hyper-v" ] }, { - "name": "275", + "name": "280", "members": [ { - "name": "data", - "type": "335" + "name": "arg1", + "type": "int" + }, + { + "name": "arg2", + "type": "int" + }, + { + "name": "arg3", + "type": "int" + }, + { + "name": "arg4", + "type": "int" + }, + { + "name": "arg5", + "type": "int" } ], "meta-type": "object" }, { - "name": "276", + "name": "281", "members": [ { "type": "46" @@ -12565,16 +13075,16 @@ "meta-type": "alternate" }, { - "name": "[277]", - "element-type": "277", + "name": "[282]", + "element-type": "282", "meta-type": "array" }, { - "name": "277", + "name": "282", "members": [ { "name": "event", - "type": "336" + "type": "343" }, { "name": "state", @@ -12605,16 +13115,16 @@ "meta-type": "object" }, { - "name": "[278]", - "element-type": "278", + "name": "[283]", + "element-type": "283", "meta-type": "array" }, { - "name": "278", + "name": "283", "members": [ { "name": "event", - "type": "336" + "type": "343" }, { "name": "state", @@ -12629,7 +13139,7 @@ "meta-type": "object" }, { - "name": "279", + "name": "284", "meta-type": "enum", "values": [ "threads", @@ -12637,37 +13147,55 @@ ] }, { - "name": "[280]", - "element-type": "280", + "name": "[285]", + "element-type": "285", "meta-type": "array" }, { - "name": "280", + "name": "285", "tag": "type", "variants": [ { "case": "unix", - "type": "338" + "type": "345" }, { - "case": "tcp", - "type": "285" + "case": "inet", + "type": "291" } ], "members": [ { "name": "type", - "type": "337" + "type": "344" } ], "meta-type": "object" }, { - "name": "281", + "name": "286", + "meta-type": "enum", + "values": [ + "tcp", + "iser" + ] + }, + { + "name": "287", + "meta-type": "enum", + "values": [ + "crc32c", + "none", + "crc32c-none", + "none-crc32c" + ] + }, + { + "name": "288", "members": [ { "name": "type", - "type": "339" + "type": "346" }, { "name": "host", @@ -12677,24 +13205,24 @@ "meta-type": "object" }, { - "name": "282", + "name": "289", "members": [ { - "type": "340" + "type": "347" }, { - "type": "341" + "type": "348" } ], "meta-type": "alternate" }, { - "name": "[276]", - "element-type": "276", + "name": "[281]", + "element-type": "281", "meta-type": "array" }, { - "name": "283", + "name": "290", "meta-type": "enum", "values": [ "quorum", @@ -12702,7 +13230,61 @@ ] }, { - "name": "284", + "name": "[291]", + "element-type": "291", + "meta-type": "array" + }, + { + "name": "291", + "members": [ + { + "name": "host", + "type": "str" + }, + { + "name": "port", + "type": "str" + }, + { + "name": "numeric", + "default": null, + "type": "bool" + }, + { + "name": "to", + "default": null, + "type": "int" + }, + { + "name": "ipv4", + "default": null, + "type": "bool" + }, + { + "name": "ipv6", + "default": null, + "type": "bool" + } + ], + "meta-type": "object" + }, + { + "name": "[292]", + "element-type": "292", + "meta-type": "array" + }, + { + "name": "292", + "members": [ + { + "name": "auth", + "type": "349" + } + ], + "meta-type": "object" + }, + { + "name": "293", "meta-type": "enum", "values": [ "primary", @@ -12710,41 +13292,7 @@ ] }, { - "name": "285", - "members": [ - { - "name": "host", - "type": "str" - }, - { - "name": "port", - "type": "str" - }, - { - "name": "numeric", - "default": null, - "type": "bool" - }, - { - "name": "to", - "default": null, - "type": "int" - }, - { - "name": "ipv4", - "default": null, - "type": "bool" - }, - { - "name": "ipv6", - "default": null, - "type": "bool" - } - ], - "meta-type": "object" - }, - { - "name": "286", + "name": "294", "meta-type": "enum", "values": [ "file", @@ -12757,6 +13305,7 @@ "null", "mux", "msmouse", + "wctablet", "braille", "testdev", "stdio", @@ -12769,86 +13318,6 @@ ] }, { - "name": "287", - "members": [ - { - "name": "data", - "type": "342" - } - ], - "meta-type": "object" - }, - { - "name": "288", - "members": [ - { - "name": "data", - "type": "343" - } - ], - "meta-type": "object" - }, - { - "name": "289", - "members": [ - { - "name": "data", - "type": "344" - } - ], - "meta-type": "object" - }, - { - "name": "290", - "members": [ - { - "name": "data", - "type": "345" - } - ], - "meta-type": "object" - }, - { - "name": "291", - "members": [ - { - "name": "data", - "type": "346" - } - ], - "meta-type": "object" - }, - { - "name": "292", - "members": [ - { - "name": "data", - "type": "347" - } - ], - "meta-type": "object" - }, - { - "name": "293", - "members": [ - { - "name": "data", - "type": "348" - } - ], - "meta-type": "object" - }, - { - "name": "294", - "members": [ - { - "name": "data", - "type": "349" - } - ], - "meta-type": "object" - }, - { "name": "295", "members": [ { @@ -12880,16 +13349,6 @@ }, { "name": "298", - "meta-type": "enum", - "values": [ - "key", - "btn", - "rel", - "abs" - ] - }, - { - "name": "299", "members": [ { "name": "data", @@ -12899,7 +13358,7 @@ "meta-type": "object" }, { - "name": "300", + "name": "299", "members": [ { "name": "data", @@ -12909,7 +13368,7 @@ "meta-type": "object" }, { - "name": "301", + "name": "300", "members": [ { "name": "data", @@ -12919,21 +13378,31 @@ "meta-type": "object" }, { + "name": "301", + "members": [ + { + "name": "data", + "type": "356" + } + ], + "meta-type": "object" + }, + { "name": "302", - "meta-type": "enum", - "values": [ - "inet", - "unix", - "vsock", - "fd" - ] + "members": [ + { + "name": "data", + "type": "357" + } + ], + "meta-type": "object" }, { "name": "303", "members": [ { "name": "data", - "type": "285" + "type": "358" } ], "meta-type": "object" @@ -12943,7 +13412,7 @@ "members": [ { "name": "data", - "type": "338" + "type": "359" } ], "meta-type": "object" @@ -12953,39 +13422,119 @@ "members": [ { "name": "data", - "type": "356" + "type": "360" } ], "meta-type": "object" }, { "name": "306", - "members": [ - { - "name": "data", - "type": "357" - } - ], - "meta-type": "object" + "meta-type": "enum", + "values": [ + "key", + "btn", + "rel", + "abs" + ] }, { "name": "307", - "meta-type": "enum", - "values": [ - "active", - "disabled", - "frozen" - ] - }, - { - "name": "[308]", - "element-type": "308", - "meta-type": "array" + "members": [ + { + "name": "data", + "type": "361" + } + ], + "meta-type": "object" }, { "name": "308", "members": [ { + "name": "data", + "type": "362" + } + ], + "meta-type": "object" + }, + { + "name": "309", + "members": [ + { + "name": "data", + "type": "363" + } + ], + "meta-type": "object" + }, + { + "name": "310", + "meta-type": "enum", + "values": [ + "inet", + "unix", + "vsock", + "fd" + ] + }, + { + "name": "311", + "members": [ + { + "name": "data", + "type": "291" + } + ], + "meta-type": "object" + }, + { + "name": "312", + "members": [ + { + "name": "data", + "type": "345" + } + ], + "meta-type": "object" + }, + { + "name": "313", + "members": [ + { + "name": "data", + "type": "364" + } + ], + "meta-type": "object" + }, + { + "name": "314", + "members": [ + { + "name": "data", + "type": "365" + } + ], + "meta-type": "object" + }, + { + "name": "315", + "meta-type": "enum", + "values": [ + "active", + "disabled", + "frozen" + ] + }, + { + "name": "[316]", + "element-type": "316", + "meta-type": "array" + }, + { + "name": "316", + "members": [ + { "name": "interval_length", "type": "int" }, @@ -13037,7 +13586,7 @@ "meta-type": "object" }, { - "name": "309", + "name": "317", "meta-type": "enum", "values": [ "string", @@ -13047,7 +13596,7 @@ ] }, { - "name": "310", + "name": "318", "members": [ { "name": "id", @@ -13091,32 +13640,32 @@ "meta-type": "array" }, { - "name": "311", + "name": "319", "tag": "type", "variants": [ { "case": "qcow2", - "type": "359" + "type": "367" }, { "case": "vmdk", - "type": "360" + "type": "368" }, { "case": "luks", - "type": "361" + "type": "369" } ], "members": [ { "name": "type", - "type": "358" + "type": "366" } ], "meta-type": "object" }, { - "name": "312", + "name": "320", "members": [ { "name": "desc", @@ -13131,7 +13680,7 @@ "meta-type": "object" }, { - "name": "313", + "name": "321", "members": [ { "name": "device", @@ -13145,27 +13694,27 @@ "meta-type": "object" }, { - "name": "314", + "name": "322", "members": [ { "name": "bus", - "type": "362" + "type": "370" }, { "name": "devices", "default": null, - "type": "[246]" + "type": "[251]" } ], "meta-type": "object" }, { - "name": "[315]", - "element-type": "315", + "name": "[323]", + "element-type": "323", "meta-type": "array" }, { - "name": "315", + "name": "323", "members": [ { "name": "bar", @@ -13197,7 +13746,7 @@ "meta-type": "object" }, { - "name": "316", + "name": "324", "meta-type": "enum", "values": [ "string", @@ -13211,12 +13760,12 @@ ] }, { - "name": "[317]", - "element-type": "317", + "name": "[325]", + "element-type": "325", "meta-type": "array" }, { - "name": "317", + "name": "325", "members": [ { "name": "name", @@ -13235,12 +13784,12 @@ "meta-type": "object" }, { - "name": "[318]", - "element-type": "318", + "name": "[326]", + "element-type": "326", "meta-type": "array" }, { - "name": "318", + "name": "326", "members": [ { "name": "case", @@ -13254,12 +13803,12 @@ "meta-type": "object" }, { - "name": "[319]", - "element-type": "319", + "name": "[327]", + "element-type": "327", "meta-type": "array" }, { - "name": "319", + "name": "327", "members": [ { "name": "type", @@ -13269,24 +13818,24 @@ "meta-type": "object" }, { - "name": "320", + "name": "328", "meta-type": "enum", "values": [ "passthrough" ] }, { - "name": "321", + "name": "329", "members": [ { "name": "data", - "type": "363" + "type": "371" } ], "meta-type": "object" }, { - "name": "322", + "name": "330", "meta-type": "enum", "values": [ "number", @@ -13294,7 +13843,7 @@ ] }, { - "name": "323", + "name": "331", "members": [ { "name": "data", @@ -13304,17 +13853,17 @@ "meta-type": "object" }, { - "name": "324", + "name": "332", "members": [ { "name": "data", - "type": "364" + "type": "372" } ], "meta-type": "object" }, { - "name": "325", + "name": "333", "meta-type": "enum", "values": [ "abort", @@ -13328,17 +13877,17 @@ ] }, { - "name": "326", + "name": "334", "members": [ { "name": "data", - "type": "365" + "type": "373" } ], "meta-type": "object" }, { - "name": "327", + "name": "335", "members": [ { "name": "data", @@ -13348,7 +13897,7 @@ "meta-type": "object" }, { - "name": "328", + "name": "336", "members": [ { "name": "data", @@ -13358,7 +13907,7 @@ "meta-type": "object" }, { - "name": "329", + "name": "337", "members": [ { "name": "data", @@ -13368,7 +13917,7 @@ "meta-type": "object" }, { - "name": "330", + "name": "338", "members": [ { "name": "data", @@ -13378,7 +13927,7 @@ "meta-type": "object" }, { - "name": "331", + "name": "339", "members": [ { "name": "data", @@ -13388,7 +13937,7 @@ "meta-type": "object" }, { - "name": "332", + "name": "340", "members": [ { "name": "data", @@ -13398,7 +13947,7 @@ "meta-type": "object" }, { - "name": "333", + "name": "341", "members": [ { "name": "data", @@ -13408,7 +13957,7 @@ "meta-type": "object" }, { - "name": "334", + "name": "342", "meta-type": "enum", "values": [ "individual", @@ -13416,33 +13965,7 @@ ] }, { - "name": "335", - "members": [ - { - "name": "arg1", - "type": "int" - }, - { - "name": "arg2", - "type": "int" - }, - { - "name": "arg3", - "type": "int" - }, - { - "name": "arg4", - "type": "int" - }, - { - "name": "arg5", - "type": "int" - } - ], - "meta-type": "object" - }, - { - "name": "336", + "name": "343", "meta-type": "enum", "values": [ "l1_update", @@ -13491,15 +14014,15 @@ ] }, { - "name": "337", + "name": "344", "meta-type": "enum", "values": [ "unix", - "tcp" + "inet" ] }, { - "name": "338", + "name": "345", "members": [ { "name": "path", @@ -13509,19 +14032,19 @@ "meta-type": "object" }, { - "name": "339", + "name": "346", "meta-type": "enum", "values": [ "inet" ] }, { - "name": "340", + "name": "347", "members": [ { "name": "template", "default": null, - "type": "341" + "type": "348" }, { "name": "main-header", @@ -13567,7 +14090,7 @@ "meta-type": "object" }, { - "name": "341", + "name": "348", "meta-type": "enum", "values": [ "none", @@ -13577,206 +14100,12 @@ ] }, { - "name": "342", - "members": [ - { - "name": "logfile", - "default": null, - "type": "str" - }, - { - "name": "logappend", - "default": null, - "type": "bool" - }, - { - "name": "in", - "default": null, - "type": "str" - }, - { - "name": "out", - "type": "str" - }, - { - "name": "append", - "default": null, - "type": "bool" - } - ], - "meta-type": "object" - }, - { - "name": "343", - "members": [ - { - "name": "logfile", - "default": null, - "type": "str" - }, - { - "name": "logappend", - "default": null, - "type": "bool" - }, - { - "name": "device", - "type": "str" - } - ], - "meta-type": "object" - }, - { - "name": "344", - "members": [ - { - "name": "logfile", - "default": null, - "type": "str" - }, - { - "name": "logappend", - "default": null, - "type": "bool" - }, - { - "name": "addr", - "type": "219" - }, - { - "name": "tls-creds", - "default": null, - "type": "str" - }, - { - "name": "server", - "default": null, - "type": "bool" - }, - { - "name": "wait", - "default": null, - "type": "bool" - }, - { - "name": "nodelay", - "default": null, - "type": "bool" - }, - { - "name": "telnet", - "default": null, - "type": "bool" - }, - { - "name": "reconnect", - "default": null, - "type": "int" - } - ], - "meta-type": "object" - }, - { - "name": "345", - "members": [ - { - "name": "logfile", - "default": null, - "type": "str" - }, - { - "name": "logappend", - "default": null, - "type": "bool" - }, - { - "name": "remote", - "type": "219" - }, - { - "name": "local", - "default": null, - "type": "219" - } - ], - "meta-type": "object" - }, - { - "name": "346", - "members": [ - { - "name": "logfile", - "default": null, - "type": "str" - }, - { - "name": "logappend", - "default": null, - "type": "bool" - } - ], - "meta-type": "object" - }, - { - "name": "347", - "members": [ - { - "name": "logfile", - "default": null, - "type": "str" - }, - { - "name": "logappend", - "default": null, - "type": "bool" - }, - { - "name": "chardev", - "type": "str" - } - ], - "meta-type": "object" - }, - { - "name": "348", - "members": [ - { - "name": "logfile", - "default": null, - "type": "str" - }, - { - "name": "logappend", - "default": null, - "type": "bool" - }, - { - "name": "signal", - "default": null, - "type": "bool" - } - ], - "meta-type": "object" - }, - { "name": "349", - "members": [ - { - "name": "logfile", - "default": null, - "type": "str" - }, - { - "name": "logappend", - "default": null, - "type": "bool" - }, - { - "name": "type", - "type": "str" - } - ], - "meta-type": "object" + "meta-type": "enum", + "values": [ + "cephx", + "none" + ] }, { "name": "350", @@ -13792,8 +14121,18 @@ "type": "bool" }, { - "name": "fqdn", + "name": "in", + "default": null, "type": "str" + }, + { + "name": "out", + "type": "str" + }, + { + "name": "append", + "default": null, + "type": "bool" } ], "meta-type": "object" @@ -13812,24 +14151,8 @@ "type": "bool" }, { - "name": "width", - "default": null, - "type": "int" - }, - { - "name": "height", - "default": null, - "type": "int" - }, - { - "name": "cols", - "default": null, - "type": "int" - }, - { - "name": "rows", - "default": null, - "type": "int" + "name": "device", + "type": "str" } ], "meta-type": "object" @@ -13848,7 +14171,36 @@ "type": "bool" }, { - "name": "size", + "name": "addr", + "type": "224" + }, + { + "name": "tls-creds", + "default": null, + "type": "str" + }, + { + "name": "server", + "default": null, + "type": "bool" + }, + { + "name": "wait", + "default": null, + "type": "bool" + }, + { + "name": "nodelay", + "default": null, + "type": "bool" + }, + { + "name": "telnet", + "default": null, + "type": "bool" + }, + { + "name": "reconnect", "default": null, "type": "int" } @@ -13859,12 +14211,23 @@ "name": "353", "members": [ { - "name": "key", - "type": "270" + "name": "logfile", + "default": null, + "type": "str" }, { - "name": "down", + "name": "logappend", + "default": null, "type": "bool" + }, + { + "name": "remote", + "type": "224" + }, + { + "name": "local", + "default": null, + "type": "224" } ], "meta-type": "object" @@ -13873,11 +14236,13 @@ "name": "354", "members": [ { - "name": "button", - "type": "366" + "name": "logfile", + "default": null, + "type": "str" }, { - "name": "down", + "name": "logappend", + "default": null, "type": "bool" } ], @@ -13887,12 +14252,18 @@ "name": "355", "members": [ { - "name": "axis", - "type": "367" + "name": "logfile", + "default": null, + "type": "str" }, { - "name": "value", - "type": "int" + "name": "logappend", + "default": null, + "type": "bool" + }, + { + "name": "chardev", + "type": "str" } ], "meta-type": "object" @@ -13901,12 +14272,19 @@ "name": "356", "members": [ { - "name": "cid", + "name": "logfile", + "default": null, "type": "str" }, { - "name": "port", - "type": "str" + "name": "logappend", + "default": null, + "type": "bool" + }, + { + "name": "signal", + "default": null, + "type": "bool" } ], "meta-type": "object" @@ -13915,7 +14293,17 @@ "name": "357", "members": [ { - "name": "str", + "name": "logfile", + "default": null, + "type": "str" + }, + { + "name": "logappend", + "default": null, + "type": "bool" + }, + { + "name": "type", "type": "str" } ], @@ -13923,19 +14311,56 @@ }, { "name": "358", - "meta-type": "enum", - "values": [ - "qcow2", - "vmdk", - "luks" - ] + "members": [ + { + "name": "logfile", + "default": null, + "type": "str" + }, + { + "name": "logappend", + "default": null, + "type": "bool" + }, + { + "name": "fqdn", + "type": "str" + } + ], + "meta-type": "object" }, { "name": "359", "members": [ { - "name": "data", - "type": "368" + "name": "logfile", + "default": null, + "type": "str" + }, + { + "name": "logappend", + "default": null, + "type": "bool" + }, + { + "name": "width", + "default": null, + "type": "int" + }, + { + "name": "height", + "default": null, + "type": "int" + }, + { + "name": "cols", + "default": null, + "type": "int" + }, + { + "name": "rows", + "default": null, + "type": "int" } ], "meta-type": "object" @@ -13944,8 +14369,19 @@ "name": "360", "members": [ { - "name": "data", - "type": "369" + "name": "logfile", + "default": null, + "type": "str" + }, + { + "name": "logappend", + "default": null, + "type": "bool" + }, + { + "name": "size", + "default": null, + "type": "int" } ], "meta-type": "object" @@ -13954,8 +14390,12 @@ "name": "361", "members": [ { - "name": "data", - "type": "370" + "name": "key", + "type": "275" + }, + { + "name": "down", + "type": "bool" } ], "meta-type": "object" @@ -13964,6 +14404,97 @@ "name": "362", "members": [ { + "name": "button", + "type": "374" + }, + { + "name": "down", + "type": "bool" + } + ], + "meta-type": "object" + }, + { + "name": "363", + "members": [ + { + "name": "axis", + "type": "375" + }, + { + "name": "value", + "type": "int" + } + ], + "meta-type": "object" + }, + { + "name": "364", + "members": [ + { + "name": "cid", + "type": "str" + }, + { + "name": "port", + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "365", + "members": [ + { + "name": "str", + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "366", + "meta-type": "enum", + "values": [ + "qcow2", + "vmdk", + "luks" + ] + }, + { + "name": "367", + "members": [ + { + "name": "data", + "type": "376" + } + ], + "meta-type": "object" + }, + { + "name": "368", + "members": [ + { + "name": "data", + "type": "377" + } + ], + "meta-type": "object" + }, + { + "name": "369", + "members": [ + { + "name": "data", + "type": "378" + } + ], + "meta-type": "object" + }, + { + "name": "370", + "members": [ + { "name": "number", "type": "int" }, @@ -13977,21 +14508,21 @@ }, { "name": "io_range", - "type": "371" + "type": "379" }, { "name": "memory_range", - "type": "371" + "type": "379" }, { "name": "prefetchable_range", - "type": "371" + "type": "379" } ], "meta-type": "object" }, { - "name": "363", + "name": "371", "members": [ { "name": "path", @@ -14007,7 +14538,7 @@ "meta-type": "object" }, { - "name": "364", + "name": "372", "meta-type": "enum", "values": [ "unmapped", @@ -14143,13 +14674,13 @@ ] }, { - "name": "365", + "name": "373", "members": [ ], "meta-type": "object" }, { - "name": "366", + "name": "374", "meta-type": "enum", "values": [ "left", @@ -14162,7 +14693,7 @@ ] }, { - "name": "367", + "name": "375", "meta-type": "enum", "values": [ "x", @@ -14170,7 +14701,7 @@ ] }, { - "name": "368", + "name": "376", "members": [ { "name": "compat", @@ -14194,7 +14725,7 @@ "meta-type": "object" }, { - "name": "369", + "name": "377", "members": [ { "name": "create-type", @@ -14210,34 +14741,34 @@ }, { "name": "extents", - "type": "[244]" + "type": "[249]" } ], "meta-type": "object" }, { - "name": "370", + "name": "378", "members": [ { "name": "cipher-alg", - "type": "372" + "type": "380" }, { "name": "cipher-mode", - "type": "373" + "type": "381" }, { "name": "ivgen-alg", - "type": "374" + "type": "382" }, { "name": "ivgen-hash-alg", "default": null, - "type": "375" + "type": "383" }, { "name": "hash-alg", - "type": "375" + "type": "383" }, { "name": "payload-offset", @@ -14253,13 +14784,13 @@ }, { "name": "slots", - "type": "[376]" + "type": "[384]" } ], "meta-type": "object" }, { - "name": "371", + "name": "379", "members": [ { "name": "base", @@ -14273,12 +14804,12 @@ "meta-type": "object" }, { - "name": "[244]", - "element-type": "244", + "name": "[249]", + "element-type": "249", "meta-type": "array" }, { - "name": "372", + "name": "380", "meta-type": "enum", "values": [ "aes-128", @@ -14296,7 +14827,7 @@ ] }, { - "name": "373", + "name": "381", "meta-type": "enum", "values": [ "ecb", @@ -14306,7 +14837,7 @@ ] }, { - "name": "374", + "name": "382", "meta-type": "enum", "values": [ "plain", @@ -14315,7 +14846,7 @@ ] }, { - "name": "375", + "name": "383", "meta-type": "enum", "values": [ "md5", @@ -14328,12 +14859,12 @@ ] }, { - "name": "[376]", - "element-type": "376", + "name": "[384]", + "element-type": "384", "meta-type": "array" }, { - "name": "376", + "name": "384", "members": [ { "name": "active", @@ -14738,6 +15269,7 @@ "hv-vpindex": false, "xlevel2": 0, "clflushopt": true, + "kvm-no-smi-migration": false, "monitor": false, "avx512er": false, "pmm-en": false, @@ -15508,6 +16040,7 @@ "hv-vpindex": false, "xlevel2": 0, "clflushopt": true, + "kvm-no-smi-migration": false, "monitor": true, "avx512er": false, "pmm-en": false, diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml index 000df939b1..f1adb4ddc9 100644 --- a/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml @@ -202,11 +202,12 @@ <flag name='drive-iotune-group'/> <flag name='query-cpu-model-expansion'/> <flag name='virtio-net.host_mtu'/> + <flag name='spice-rendernode'/> <flag name='pcie-root-port'/> <flag name='query-cpu-definitions'/> - <version>2008050</version> + <version>2008090</version> <kvmVersion>0</kvmVersion> - <package> (v2.8.0-1961-g5b10b94bd5)</package> + <package> (v2.9.0-rc0-142-g940a8ce)</package> <arch>x86_64</arch> <hostCPU type='kvm' model='base'> <property name='phys-bits' type='number' value='0'/> @@ -403,6 +404,7 @@ <property name='hv-vpindex' type='boolean' value='false'/> <property name='xlevel2' type='number' value='0'/> <property name='clflushopt' type='boolean' value='true'/> + <property name='kvm-no-smi-migration' type='boolean' value='false'/> <property name='monitor' type='boolean' value='false'/> <property name='avx512er' type='boolean' value='false'/> <property name='pmm-en' type='boolean' value='false'/> @@ -634,6 +636,7 @@ <property name='hv-vpindex' type='boolean' value='false'/> <property name='xlevel2' type='number' value='0'/> <property name='clflushopt' type='boolean' value='true'/> + <property name='kvm-no-smi-migration' type='boolean' value='false'/> <property name='monitor' type='boolean' value='true'/> <property name='avx512er' type='boolean' value='false'/> <property name='pmm-en' type='boolean' value='false'/> -- 2.12.0

2 1

[libvirt] [PATCH] news: Document "Enforce guest CPU specification" series
by Jiri Denemark 21 Mar '17

21 Mar '17

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- docs/news.xml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 3501f89ab..f1bfeda55 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -39,6 +39,19 @@ the QEMU binary supports it. </description> </change> + <change> + <summary> + qemu: Add support for checking guest CPU ABI compatibility + </summary> + <description> + When migrating a domain to a different host, restoring a domain from + a file or reverting a snapshot libvirt will make sure the guest CPU + QEMU presents to the guest OS exactly matches the one provided on + the source host (or before the domain's state was saved). This + enhanced check may also be requested when starting a new domain to + ensure the virtual CPU exactly matches the one specified in the XML. + </description> + </change> </section> <section title="Improvements"> <change> -- 2.12.0

2 1

[libvirt] [RFC PATCH v2 REBASE 00/18] Introduce vGPU mdev framework to libvirt
by Erik Skultety 21 Mar '17

21 Mar '17

since the original v2 [1]: - resolved a few merge conflicts caused by @9d92f533 which refactored out some duplicate code which eventually lead to dropping patch 14/18 from the original series due to being unnecessary - rebased onto fresh HEAD [1] https://www.redhat.com/archives/libvir-list/2017-February/msg00739.html Erik Skultety (18): util: Introduce new module virmdev conf: Introduce new hostdev device type mdev conf: Introduce new address type mdev conf: Update XML parser, formatter, and RNG schema to support mdev conf: Introduce virDomainHostdevDefPostParse conf: Add post parse code for mdevs to virDomainHostdevDefPostParse security: dac: Enable labeling of vfio mediated devices security: selinux: Enable labeling of vfio mediated devices conf: Enable cold-plug of a mediated device qemu: Assign PCI addresses for mediated devices as well hostdev: Maintain a driver list of active mediated devices hostdev: Introduce a reattach method for mediated devices qemu: cgroup: Adjust cgroups' logic to allow mediated devices qemu: Bump the memory locking limit for mdevs as well qemu: Format mdevs on qemu command line test: Add some test cases for our test suite regarding the mdevs docs: Document the new hostdev and address type 'mdev' news: Update the NEWS.xml about the new mdev feature docs/formatdomain.html.in | 48 ++- docs/news.xml | 9 + docs/schemas/domaincommon.rng | 26 ++ po/POTFILES.in | 1 + src/Makefile.am | 1 + src/conf/device_conf.h | 1 + src/conf/domain_conf.c | 203 ++++++++++-- src/conf/domain_conf.h | 9 + src/libvirt_private.syms | 20 ++ src/qemu/qemu_command.c | 49 +++ src/qemu/qemu_command.h | 5 + src/qemu/qemu_domain.c | 23 +- src/qemu/qemu_domain.h | 1 + src/qemu/qemu_domain_address.c | 16 +- src/qemu/qemu_hostdev.c | 37 +++ src/qemu/qemu_hostdev.h | 8 + src/qemu/qemu_hotplug.c | 2 + src/security/security_apparmor.c | 3 + src/security/security_dac.c | 55 ++++ src/security/security_selinux.c | 54 ++++ src/util/virhostdev.c | 229 ++++++++++++- src/util/virhostdev.h | 16 + src/util/virmdev.c | 358 +++++++++++++++++++++ src/util/virmdev.h | 93 ++++++ tests/domaincapsschemadata/full.xml | 1 + .../qemuxml2argv-hostdev-mdev-unmanaged.args | 25 ++ .../qemuxml2argv-hostdev-mdev-unmanaged.xml | 37 +++ tests/qemuxml2argvtest.c | 6 + .../qemuxml2xmlout-hostdev-mdev-unmanaged.xml | 40 +++ tests/qemuxml2xmltest.c | 1 + 30 files changed, 1333 insertions(+), 44 deletions(-) create mode 100644 src/util/virmdev.c create mode 100644 src/util/virmdev.h create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-mdev-unmanaged.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-mdev-unmanaged.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-hostdev-mdev-unmanaged.xml -- 2.10.2

8 45

[libvirt] [PATCH 00/11] storage: modularize the storage driver backends
by Peter Krempa 20 Mar '17

20 Mar '17

Split up the storage driver backends into loadable modules so that binary distributions don't have to compromise on shipping the storage driver with all backends which may pull in too many dependencies. Peter Krempa (11): configure: Fix configure output for RBD storage backend tests: storagepoolxml2xml: Remove compile conditionals tests: drivermodule: Drop unused macro arguments driver: Split/refactor driver module loading daemon: Refactor connection driver module loading storage: backend: Refactor registration of the backend drivers storage: Turn driver backends into (static) modules storage: Turn storage backends into dynamic modules tests: drivermodule: Make sure that all compiled storage backends can be loaded spec: Modularize the storage driver news: Mention storage driver split daemon/libvirtd.c | 136 +++++++++------------- docs/news.xml | 10 ++ libvirt.spec.in | 185 +++++++++++++++++++++++++----- m4/virt-storage-rbd.m4 | 2 +- src/Makefile.am | 199 ++++++++++++++++++++++++++++++--- src/driver.c | 136 ++++++++++++++-------- src/driver.h | 6 +- src/libvirt_driver_modules.syms | 1 + src/storage/storage_backend.c | 151 +++++++++++++++++++------ src/storage/storage_backend.h | 5 + src/storage/storage_backend_disk.c | 7 ++ src/storage/storage_backend_disk.h | 4 +- src/storage/storage_backend_fs.c | 27 +++++ src/storage/storage_backend_fs.h | 11 +- src/storage/storage_backend_gluster.c | 13 ++- src/storage/storage_backend_gluster.h | 5 +- src/storage/storage_backend_iscsi.c | 7 ++ src/storage/storage_backend_iscsi.h | 4 +- src/storage/storage_backend_logical.c | 7 ++ src/storage/storage_backend_logical.h | 4 +- src/storage/storage_backend_mpath.c | 8 ++ src/storage/storage_backend_mpath.h | 4 +- src/storage/storage_backend_rbd.c | 7 ++ src/storage/storage_backend_rbd.h | 4 +- src/storage/storage_backend_scsi.c | 7 ++ src/storage/storage_backend_scsi.h | 4 +- src/storage/storage_backend_sheepdog.c | 7 ++ src/storage/storage_backend_sheepdog.h | 4 +- src/storage/storage_backend_vstorage.c | 7 ++ src/storage/storage_backend_vstorage.h | 4 +- src/storage/storage_backend_zfs.c | 7 ++ src/storage/storage_backend_zfs.h | 4 +- src/storage/storage_driver.c | 19 +++- src/storage/storage_driver.h | 1 + tests/Makefile.am | 4 +- tests/storagepoolxml2xmltest.c | 6 - tests/virdrivermoduletest.c | 52 +++++---- tests/virstoragetest.c | 4 + 38 files changed, 788 insertions(+), 285 deletions(-) -- 2.11.0

3 25

[libvirt] [RFC] finegrained disk driver options control
by Denis V. Lunev 20 Mar '17

20 Mar '17

Hello, All! There is a problem in the current libvirt implementation. domain.xml allows to specify only basic set of options, especially in the case of QEMU, when there are really a lot of tweaks in format drivers. Most likely these options will never be supported in a good way in libvirt as recognizable entities. Right now in order to debug libvirt QEMU VM in production I am using very strange approach: - disk section of domain XML is removed - exact command line options to start the disk are specified at the end of domain.xml whithin <qemu:commandline> as described by Stefan http://blog.vmsplice.net/2011/04/how-to-pass-qemu-command-line-options.html The problem is that when debug is finished and viable combinations of options is found I can not drop VM in such state in the production. This is the pain and problem. For example, I have spend 3 days with the VM of one customer which blames us for slow IO in the guest. I have found very good combination of non-standard options which increases disk performance 5 times (not 5%). Currently I can not put this combination in the production as libvirt does not see the disk. I propose to do very simple thing, may be I am not the first one here, but it would be nice to allow to pass arbitrary option to the QEMU command line. This could be done in a very generic way if we will allow to specify additional options inside <driver> section like this: <disk type='file' device='disk'> <driver name='qemu' type='qcow2' cache='none' io='native' iothread='1'> <option name='l2-cache-size' value='64M/> <option name='cache-clean-interval' value='32'/> </driver> <source file='/var/lib/libvirt/images/rhel7.qcow2'/> <target dev='sda' bus='scsi'/> <address type='drive' controller='0' bus='0' target='0' unit='0'/> </disk> and so on. The meaning (at least for QEMU) is quite simple - these options will just be added to the end of the -drive command line. The meaning for other drivers should be the same and I think that there are ways to pass generic options in them. Any opinion? Den

4 19

[libvirt] [PATCH] qemu: Don't try to update undefined guest CPU
by Jiri Denemark 20 Mar '17

20 Mar '17

Calling virCPUUpdateLive on a domain with no guest CPU configuration does not make sense. Especially when doing so would crash libvirtd. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_process.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 780f9587a..ec0e36d2e 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -3815,11 +3815,6 @@ qemuProcessVerifyCPUFeatures(virDomainDefPtr def, { int rc; - if (!def->cpu || - (def->cpu->mode == VIR_CPU_MODE_CUSTOM && - !def->cpu->model)) - return 0; - rc = virCPUCheckFeature(def->os.arch, def->cpu, "invtsc"); if (rc < 0) { @@ -3870,6 +3865,13 @@ qemuProcessUpdateLiveGuestCPU(virQEMUDriverPtr driver, qemuProcessVerifyHypervFeatures(def, cpu) < 0) goto cleanup; + if (!def->cpu || + (def->cpu->mode == VIR_CPU_MODE_CUSTOM && + !def->cpu->model)) { + ret = 0; + goto cleanup; + } + if (qemuProcessVerifyCPUFeatures(def, cpu) < 0) goto cleanup; -- 2.12.0

2 1

Re: [libvirt] [PATCH 2/2] qemu: Validate the domain after marking the current domain as transient
by Daniel P. Berrange 20 Mar '17

20 Mar '17

On Wed, Mar 08, 2017 at 10:32:32AM +0100, Marc Hartmayer wrote: > On Mon, Feb 27, 2017 at 11:20 AM +0100, "Daniel P. Berrange" <berrange(a)redhat.com> wrote: > > On Mon, Feb 27, 2017 at 10:59:39AM +0100, Marc Hartmayer wrote: > >> On Thu, Feb 23, 2017 at 05:36 PM +0100, "Daniel P. Berrange" <berrange(a)redhat.com> wrote: > >> > On Thu, Feb 23, 2017 at 05:22:44PM +0100, Marc Hartmayer wrote: > >> >> On Thu, Feb 23, 2017 at 03:33 PM +0100, Michal Privoznik <mprivozn(a)redhat.com> wrote: > >> >> > On 02/23/2017 10:44 AM, Marc Hartmayer wrote: > >> >> >> Validate the domain that actually will be started. It's semantically > >> >> >> more clear and also it can detect failures that may have happened in > >> >> >> virDomainObjSetDefTransient(). > >> >> >> > >> >> >> Signed-off-by: Marc Hartmayer <mhartmay(a)linux.vnet.ibm.com> > >> >> >> Reviewed-by: Bjoern Walk <bwalk(a)linux.vnet.ibm.com> > >> >> >> Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com> > >> >> >> --- > >> >> >> src/qemu/qemu_process.c | 6 +++--- > >> >> >> 1 file changed, 3 insertions(+), 3 deletions(-) > >> >> >> > >> >> >> diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c > >> >> >> index a57d136..bd3a8b8 100644 > >> >> >> --- a/src/qemu/qemu_process.c > >> >> >> +++ b/src/qemu/qemu_process.c > >> >> >> @@ -4746,9 +4746,6 @@ qemuProcessInit(virQEMUDriverPtr driver, > >> >> >> vm->def->os.machine))) > >> >> >> goto cleanup; > >> >> >> > >> >> >> - if (qemuProcessStartValidate(driver, vm, priv->qemuCaps, caps, flags) < 0) > >> >> >> - goto cleanup; > >> >> >> - > >> >> >> /* Do this upfront, so any part of the startup process can add > >> >> >> * runtime state to vm->def that won't be persisted. This let's us > >> >> >> * report implicit runtime defaults in the XML, like vnc listen/socket > >> >> >> @@ -4757,6 +4754,9 @@ qemuProcessInit(virQEMUDriverPtr driver, > >> >> >> if (virDomainObjSetDefTransient(caps, driver->xmlopt, vm) < 0) > >> >> >> goto cleanup; > >> >> >> > >> >> >> + if (qemuProcessStartValidate(driver, vm, priv->qemuCaps, caps, flags) < 0) > >> >> >> + goto cleanup; > >> >> >> + > >> >> > > >> >> > This needs to be goto stop for the reasons described in the previous e-mail. > >> >> > > >> >> >> if (flags & VIR_QEMU_PROCESS_START_PRETEND) { > >> >> >> if (qemuDomainSetPrivatePaths(driver, vm) < 0) > >> >> >> goto cleanup; > >> >> >> > >> >> > > >> >> > Honestly, I like what we have now better. I mean, SetDefTransient() is > >> >> > very unlikely to fail. It's just doing a copy of domain definition (in a > >> >> > very stupid way, but lets save that for a different discussion). > >> >> > Basically, it will fail on OOM only (which you will not get on a Linux > >> >> > system, unless you really try). > >> >> > >> >> It's semantically more clear (at least for me) and for example it > >> >> enables us to change some parts of the transient domain before > >> >> validation (affect the transient domain only, not the persistent). > >> > > >> > What are you planning to change in the config before validation ? > >> > > >> > >> I'm implementing a feature which allows to select the boot device at > >> domain start time (something like 'virsh start --with-bootdevice sda > >> domain1'). The main reason why we want this is because the s390 > >> architecture boots only from the first device specified in the boot > >> order. > > > > There's no need to changes in the QEMU driver todo this. You can just > > query the current XML config, change the boot device in it, and then > > run virDomainCreateXML to launch the guest with the changed config, > > or virDomainDefineXML again to make the changed boot device permanent. > > > > First of all, I hope I understand you right :) (you can tell me as soon > as you have read the following text) > > I've followed your advice and tried to add this functionality without > any changes in the QEMU/hypervisor. For this I've created a new function > in the remote driver which will call the needed functions (get current > XML config for the domain, manipulate the XML config, and then use > virDomainCreateXML for starting). > > To get the current XML config is straightforward as you've mentioned - > just use 'virDomanGetXMLDesc(...)'. > > But how can I change the boot device? > 1) I could use libxml2 for manipulating the XML string which we will get > with calling 'virDomainGetXMLDesc(..)' but this is error-prone and just > duplicate work as we have to parse the XML string and the information of > it. Also, if there are any additions in the future for boot devices > there will be no 'compile time reminder' that you have to edit this > function. Yes, this is the way it is normally done. There is a tradeoff here between wanting to be reminded at compile time but seeing build breakage, and libvirt wanting to be able to extend its config info without breaking apps. The libvirt view is that the latter is more important. > or > 2) Parse the XML string into our internal representation (virDomainDef), > adjust the boot orders and create a new XML string out of this internal > representation (reverse to the way how virDomainDefCopy(...) works). But > there is the huge problem: > > We need 'virCapsPtr caps' and 'virDomainXMLOptionPtr xmlopt' for > virDomainDefFormat(...) and virDomainDefParseString(...) but we're on > the remote driver layer and therefore we've no direct access to this. We > could add a function to the hypervisor driver interface for getting > these but this is just awkward. The virDomainDef are private data structures just for internal libvirt usage. Even though virsh is in the libvirt source tree, it should be treated as if it were a standalone application and thus only use the public APIs. > So my question to you is: do you have a better idea for this? > > Many thanks in advance. > > PS. I hope it's okay for you that I'm writing to you only for the moment > (as it's somehow off topic). If not I'll send it to the mailing list :) It isn't off-topic, so I'm copying back in the list. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|

2 1

[libvirt] [PATCH 0/3] log|lock daemon: Don't spam logs with IO error messages after client disconnects
by Peter Krempa 17 Mar '17

17 Mar '17

See patch 3 for explanation Peter Krempa (3): rpc: socket: Add possibility to suppress errors on read hangup rpc: serverclient: Add option to suppress errors on EOF (log|lock)daemon: Don't spam logs with IO error messages after client disconnects src/locking/lock_daemon.c | 3 +++ src/logging/log_daemon.c | 3 +++ src/rpc/virnetserverclient.c | 13 +++++++++++++ src/rpc/virnetserverclient.h | 2 ++ src/rpc/virnetsocket.c | 33 +++++++++++++++++++++++++++------ src/rpc/virnetsocket.h | 2 ++ 6 files changed, 50 insertions(+), 6 deletions(-) -- 2.12.0

2 8

[libvirt] [REPOST PATCH 0/4] Split out storage object into its own module
by John Ferlan 17 Mar '17

17 Mar '17

Repost after merging with latest changes of: http://www.redhat.com/archives/libvir-list/2017-March/msg00305.html Continuing down the pile of drivers from my RFC for making a common pool object - we're now at storage... For reference see patch 3 of: http://www.redhat.com/archives/libvir-list/2017-February/msg00519.html This series works through the storage conf adjustments. This pile is fairly straightforward. The virStorageVol* API's make it a bit more interesting, but like other series we split out anything referencing virStoragePoolObj and go from there. John Ferlan (4): conf: Introduce virstorageobj conf: Adjust coding style for storage conf sources conf: Alter coding style of storage conf function prototypes conf: Use consistent function name prefixes for virstorageobj po/POTFILES.in | 1 + src/Makefile.am | 3 +- src/conf/storage_conf.c | 975 ++--------------------------------------- src/conf/storage_conf.h | 174 ++------ src/conf/virstorageobj.c | 997 ++++++++++++++++++++++++++++++++++++++++++ src/conf/virstorageobj.h | 156 +++++++ src/libvirt_private.syms | 34 +- src/storage/storage_backend.h | 2 +- src/storage/storage_driver.c | 24 +- src/storage/storage_driver.h | 2 +- src/storage/storage_util.h | 1 - src/test/test_driver.c | 1 + 12 files changed, 1263 insertions(+), 1107 deletions(-) create mode 100644 src/conf/virstorageobj.c create mode 100644 src/conf/virstorageobj.h -- 2.9.3

2 5

[libvirt] [PATCH 0/4] Split out storage object into its own module
by John Ferlan 17 Mar '17

17 Mar '17

Continuing down the pile of drivers from my RFC for making a common pool object - we're now at storage... For reference see patch 3 of: http://www.redhat.com/archives/libvir-list/2017-February/msg00519.html This series works through the storage conf adjustments. This pile is fairly straightforward. The virStorageVol* API's make it a bit more interesting, but like other series we split out anything referencing virStoragePoolObj and go from there. John Ferlan (4): conf: Introduce virstorageobj conf: Adjust coding style for storage conf sources conf: Alter coding style of storage conf function prototypes conf: Use consistent function name prefixes for virstorageobj po/POTFILES.in | 1 + src/Makefile.am | 3 +- src/conf/storage_conf.c | 965 ++--------------------------------------- src/conf/storage_conf.h | 174 ++------ src/conf/virstorageobj.c | 986 ++++++++++++++++++++++++++++++++++++++++++ src/conf/virstorageobj.h | 156 +++++++ src/libvirt_private.syms | 34 +- src/storage/storage_backend.h | 2 +- src/storage/storage_driver.c | 24 +- src/storage/storage_driver.h | 2 +- src/storage/storage_util.h | 1 - src/test/test_driver.c | 1 + 12 files changed, 1255 insertions(+), 1094 deletions(-) create mode 100644 src/conf/virstorageobj.c create mode 100644 src/conf/virstorageobj.h -- 2.9.3

2 6

[libvirt] [PATCH v2 0/4] qemu: Add support for generic PCIe Root Ports
by Andrea Bolognani 17 Mar '17

17 Mar '17

Blurby McBlurbface. Andrea Bolognani (4): qemu: Add support for generic PCIe Root Ports qemu: Use generic PCIe Root Ports by default when available tests: Test generic PCIe Root Ports news: Document support for generic PCIe Root Ports docs/news.xml | 10 ++++++ docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c | 4 ++- src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 18 ++++++++-- src/qemu/qemu_domain_address.c | 13 +++++-- tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 + .../qemuxml2argv-pcie-root-port-model-generic.args | 22 ++++++++++++ .../qemuxml2argv-pcie-root-port-model-generic.xml | 22 ++++++++++++ .../qemuxml2argv-pcie-root-port-model-ioh3420.args | 21 ++++++++++++ .../qemuxml2argv-pcie-root-port-model-ioh3420.xml | 19 ++++++++++ tests/qemuxml2argvtest.c | 14 ++++++++ ...qemuxml2xmlout-pcie-root-port-model-generic.xml | 40 ++++++++++++++++++++++ ...qemuxml2xmlout-pcie-root-port-model-ioh3420.xml | 35 +++++++++++++++++++ tests/qemuxml2xmltest.c | 14 ++++++++ 17 files changed, 231 insertions(+), 7 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pcie-root-port-model-generic.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pcie-root-port-model-generic.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pcie-root-port-model-ioh3420.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pcie-root-port-model-ioh3420.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-pcie-root-port-model-generic.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-pcie-root-port-model-ioh3420.xml -- 2.7.4

2 10

[libvirt] [PATCH v1 0/2] libvirt-python: virEventAsyncIOImpl (was: libvirtaio)
by Wojtek Porczyk 17 Mar '17

17 Mar '17

Hello, As promised, this is the event loop implementation which dispatches the callbacks via asyncio's event loop. There are two patches: the first one fixes the bug around freeing opaque objects [1][2], and the second one is the actual implementation. Compared to standalone version I did earlier, this has public names more similar in style to other functions in the module. Also some comments are corrected, and packaging code is lightly touched. [1] https://www.redhat.com/archives/libvir-list/2017-January/msg00863.html [2] https://bugzilla.redhat.com/show_bug.cgi?id=1433028 Wojtek Porczyk (2): Allow for ff callbacks to be called by custom event implementations Add asyncio event loop implementation libvirt-override.c | 36 ++--- libvirt-override.py | 45 ++++++ libvirt-python.spec.in | 1 + libvirtaio.py | 398 +++++++++++++++++++++++++++++++++++++++++++++++++ sanitytest.py | 5 +- setup.py | 12 ++ 6 files changed, 471 insertions(+), 26 deletions(-) create mode 100644 libvirtaio.py -- pozdrawiam / best regards _.-._ Wojtek Porczyk .-^' '^-. Invisible Things Lab |'-.-^-.-'| | | | | I do not fear computers, | '-.-' | I fear lack of them. '-._ : ,-' -- Isaac Asimov `^-^-_>

2 3

[libvirt] [PATCH 00/12] qemu: Enforce guest CPU specification
by Jiri Denemark 17 Mar '17

17 Mar '17

When starting a domain with custom guest CPU specification QEMU may add or remove some CPU features. There are several reasons for this, e.g., QEMU/KVM does not support some requested features or the definition of the requested CPU model in libvirt's cpu_map.xml differs from the one QEMU is using. We can't really avoid this because CPU models are allowed to change with machine types and libvirt doesn't know (and probably doesn't even want to know) about such changes. Thus when we want to make sure guest ABI doesn't change when a domain gets migrated to another host, we need to update our live CPU definition according to the CPU QEMU created. Once updated, we will change CPU checking to VIR_CPU_CHECK_FULL to make sure the virtual CPU created after migration exactly matches the one on the source. https://bugzilla.redhat.com/show_bug.cgi?id=822148 https://bugzilla.redhat.com/show_bug.cgi?id=824989 Jiri Denemark (12): tests: Switch to sparse initialization of virCPUDef docs: Clarify /domain/cpu/@match description Introduce /domain/cpu/@check XML attribute qemu: Set default values for CPU check attribute qemu: Refactor Hyper-V features check qemu: Refactor KVM features check qemu: Refactor CPU features check qemu: Refactor qemuProcessVerifyGuestCPU qemu: Use ARCH_IS_X86 in qemuMonitorJSONGetGuestCPU qemu: Ask QEMU for filtered CPU features qemu: Update CPU definition according to QEMU qemu: Enforce guest CPU specification docs/formatdomain.html.in | 52 ++++- docs/schemas/cputypes.rng | 10 + docs/schemas/domaincommon.rng | 3 + src/conf/cpu_conf.c | 30 +++ src/conf/cpu_conf.h | 12 ++ src/conf/domain_conf.c | 21 ++ src/cpu/cpu.c | 45 +++++ src/cpu/cpu.h | 12 ++ src/cpu/cpu_x86.c | 105 ++++++++++ src/libvirt_private.syms | 1 + src/qemu/qemu_domain.c | 42 ++++ src/qemu/qemu_monitor.c | 11 +- src/qemu/qemu_monitor.h | 3 +- src/qemu/qemu_monitor_json.c | 38 +++- src/qemu/qemu_monitor_json.h | 3 +- src/qemu/qemu_process.c | 225 +++++++++++++-------- tests/domaincapstest.c | 38 ++-- tests/qemumonitorjsontest.c | 4 +- .../qemuxml2argv-aarch64-gic-host.xml | 2 +- .../qemuxml2argv-aarch64-gic-v2.xml | 2 +- .../qemuxml2argv-aarch64-gic-v3.xml | 2 +- .../qemuxml2argv-cpu-check-default-none.args | 21 ++ .../qemuxml2argv-cpu-check-default-none.xml | 19 ++ .../qemuxml2argv-cpu-check-default-none2.args | 21 ++ .../qemuxml2argv-cpu-check-default-none2.xml | 21 ++ .../qemuxml2argv-cpu-check-default-partial.args | 22 ++ .../qemuxml2argv-cpu-check-default-partial.xml | 19 ++ .../qemuxml2argv-cpu-check-default-partial2.args | 21 ++ .../qemuxml2argv-cpu-check-default-partial2.xml | 21 ++ .../qemuxml2argv-cpu-check-full.args | 1 + .../qemuxml2argv-cpu-check-full.xml | 21 ++ .../qemuxml2argv-cpu-check-none.args | 21 ++ .../qemuxml2argv-cpu-check-none.xml | 21 ++ .../qemuxml2argv-cpu-check-partial.args | 1 + .../qemuxml2argv-cpu-check-partial.xml | 21 ++ tests/qemuxml2argvtest.c | 8 + .../qemuxml2xmlout-aarch64-aavmf-virtio-mmio.xml | 2 +- ...qemuxml2xmlout-aarch64-video-virtio-gpu-pci.xml | 2 +- .../qemuxml2xmlout-aarch64-virtio-pci-default.xml | 2 +- ...2xmlout-aarch64-virtio-pci-manual-addresses.xml | 2 +- .../qemuxml2xmlout-cpu-check-default-none.xml | 28 +++ .../qemuxml2xmlout-cpu-check-default-none2.xml | 30 +++ .../qemuxml2xmlout-cpu-check-default-partial.xml | 30 +++ .../qemuxml2xmlout-cpu-check-default-partial2.xml | 30 +++ .../qemuxml2xmlout-cpu-check-full.xml | 30 +++ .../qemuxml2xmlout-cpu-check-none.xml | 30 +++ .../qemuxml2xmlout-cpu-check-partial.xml | 30 +++ .../qemuxml2xmlout-cpu-eoi-disabled.xml | 2 +- .../qemuxml2xmlout-cpu-eoi-enabled.xml | 2 +- .../qemuxml2xmlout-cpu-host-kvmclock.xml | 2 +- .../qemuxml2xmlout-cpu-host-model-features.xml | 2 +- ...emuxml2xmlout-cpu-host-passthrough-features.xml | 2 +- .../qemuxml2xmlout-cpu-kvmclock.xml | 2 +- .../qemuxml2xmlout-graphics-spice-timeout.xml | 2 +- tests/qemuxml2xmltest.c | 8 + tests/testutilsqemu.c | 48 ++--- 56 files changed, 1039 insertions(+), 167 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-check-default-none.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-check-default-none.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-check-default-none2.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-check-default-none2.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-check-default-partial.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-check-default-partial.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-check-default-partial2.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-check-default-partial2.xml create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-cpu-check-full.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-check-full.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-check-none.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-check-none.xml create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-cpu-check-partial.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-check-partial.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-cpu-check-default-none.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-cpu-check-default-none2.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-cpu-check-default-partial.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-cpu-check-default-partial2.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-cpu-check-full.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-cpu-check-none.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-cpu-check-partial.xml -- 2.12.0

2 16

[libvirt] [PATCH 0/4] qemu: fix handling of 'group_name' disk io tuning parameter
by Peter Krempa 17 Mar '17

17 Mar '17

Fix a crasher and an invalid configuration. Peter Krempa (4): qemu: Don't steal pointers from 'persistentDef' in qemuDomainGetBlockIoTune qemu: command: Extract blkdeviotune checks into a separate function qemu: command: Extract tests for subsets of blkdeviotune settings qemu: command: Don't allow setting 'group_name' alone src/qemu/qemu_command.c | 181 ++++++++++++++++++++++++++++++------------------ src/qemu/qemu_driver.c | 22 ++++-- 2 files changed, 127 insertions(+), 76 deletions(-) -- 2.12.0

2 5

[libvirt] Failure to probe cpu definitions for e.g. qemu-system-mips
by Guido Günther 17 Mar '17

17 Mar '17

Hi, while looking into a regression failing to start any mips qemu systems (http://bugs.debian.org/854125) I noticed that querying cpu definition does not work for lots of non intel architectures like mips due to lack of support for the query-cpu-definition monitor command: 2017-03-15 04:23:55.336+0000: 4238: warning : virQEMUCapsLogProbeFailure:4838 : Failed to probe capabilities for /usr/bin/qemu-system-mips: internal error: unable to execute QEMU command 'query-cpu-definitions': The command query-cpu-definitions has not been found 2017-03-15 04:23:55.374+0000: 4238: error : qemuMonitorJSONCheckError:387 : internal error: unable to execute QEMU command 'query-cpu-definitions': The command query-cpu-definitions has not been found Is support for query-cpu-definition a hard requirement or should we fail gracefully in this case? If not I can look into restoring that behaviour but would be happy about pointers what would be the best way forward. Cheers, -- Guido

3 6

[libvirt] [PATCH] perf: remote: Compare perf nparams against the correct constant
by Nitesh Konkar 17 Mar '17

17 Mar '17

Currently 'virsh perf domain' errors out as the perf nparams is incorrectly compared against REMOTE_DOMAIN_MEMORY_PARAMETERS_MAX instead of REMOTE_DOMAIN_PERF_EVENTS_MAX. Signed-off-by: Nitesh Konkar <nitkon12(a)linux.vnet.ibm.com> --- daemon/remote.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemon/remote.c b/daemon/remote.c index f2b9b9a..1c9708c 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -3105,7 +3105,7 @@ remoteDispatchDomainGetPerfEvents(virNetServerPtr server ATTRIBUTE_UNUSED, if (virDomainGetPerfEvents(dom, &params, &nparams, args->flags) < 0) goto cleanup; - if (nparams > REMOTE_DOMAIN_MEMORY_PARAMETERS_MAX) { + if (nparams > REMOTE_DOMAIN_PERF_EVENTS_MAX) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large")); goto cleanup; } -- 1.9.3

2 1

[libvirt] [PATCH] vz: Remove unused variable
by Mikhail Feoktistov 17 Mar '17

17 Mar '17

emulatedType is not used in prlsdkAddDomainHardDisksInfo() --- src/vz/vz_sdk.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index 3fd17db..8e6e89d 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -817,14 +817,9 @@ prlsdkAddDomainHardDisksInfo(vzDriverPtr driver, PRL_HANDLE sdkdom, virDomainDef for (i = 0; i < hddCount; ++i) { - PRL_UINT32 emulatedType; - pret = PrlVmCfg_GetHardDisk(sdkdom, i, &hdd); prlsdkCheckRetGoto(pret, error); - pret = PrlVmDev_GetEmulatedType(hdd, &emulatedType); - prlsdkCheckRetGoto(pret, error); - if (IS_CT(def) && prlsdkInBootList(sdkdom, hdd)) { -- 1.8.3.1

1 0

[libvirt] [PATCH] apparmor: allow /usr/lib/qemu/qemu-bridge-helper
by Guido Günther 17 Mar '17

17 Mar '17

This is where e.g. Debian puts it. --- examples/apparmor/usr.sbin.libvirtd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/apparmor/usr.sbin.libvirtd b/examples/apparmor/usr.sbin.libvirtd index 8893e75fe..03a80b7e6 100644 --- a/examples/apparmor/usr.sbin.libvirtd +++ b/examples/apparmor/usr.sbin.libvirtd @@ -67,7 +67,7 @@ # allow changing to our UUID-based named profiles change_profile -> @{LIBVIRT}-[0-9a-f]*-[0-9a-f]*-[0-9a-f]*-[0-9a-f]*-[0-9a-f]*, - /usr/{lib,libexec}/qemu-bridge-helper Cx -> qemu_bridge_helper, + /usr/{lib,lib/qemu,libexec}/qemu-bridge-helper Cx -> qemu_bridge_helper, # child profile for bridge helper process profile qemu_bridge_helper { #include <abstractions/base> -- 2.11.0

2 4

[libvirt] [PATCH 1/1] perf: list all supported events when get domain stats
by Qiaowei Ren 16 Mar '17

16 Mar '17

Currently when virDomainListGetStats is called, the stats for those disabled perf events won't be showed in result. This will produce some problems for applications based on libvirt sometime, e.g. the OpenStack bug https://bugs.launchpad.net/ceilometer/+bug/1670948 This patch just show '0' in result for disabled events for virDomainListGetStats API. I guess this should be also rational to show all stats even though the events are not enabled. Signed-off-by: Qiaowei Ren <qiaowei.ren(a)intel.com> --- src/qemu/qemu_driver.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 2032fac..237bf57 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -19355,8 +19355,10 @@ qemuDomainGetStatsPerfOneEvent(virPerfPtr perf, char param_name[VIR_TYPED_PARAM_FIELD_LENGTH]; uint64_t value = 0; - if (virPerfReadEvent(perf, type, &value) < 0) - return -1; + if (virPerfEventIsEnabled(perf, type)) { + if (virPerfReadEvent(perf, type, &value) < 0) + return -1; + } snprintf(param_name, VIR_TYPED_PARAM_FIELD_LENGTH, "perf.%s", virPerfEventTypeToString(type)); @@ -19383,9 +19385,6 @@ qemuDomainGetStatsPerf(virQEMUDriverPtr driver ATTRIBUTE_UNUSED, int ret = -1; for (i = 0; i < VIR_PERF_EVENT_LAST; i++) { - if (!virPerfEventIsEnabled(priv->perf, i)) - continue; - if (qemuDomainGetStatsPerfOneEvent(priv->perf, i, record, maxparams) < 0) goto cleanup; -- 1.9.1

2 1

[libvirt] libvirtaio: libvirt-python asyncio event impl
by Wojtek Porczyk 16 Mar '17

16 Mar '17

Hello, libvirt-list, I wrote an event implementation wrapping an asyncio event loop [1]. I would like to contribute it back to libvirt-python, to be offered alongside the Default Impl in C. [1] https://github.com/woju/libvirtaio Also it contains a workaround for a memory leak around the custom loop implementation: https://github.com/woju/libvirtaio/blob/8685cfc/libvirtaio.py#L66-L92 How should I submit this? As a patch against libvirt-python.git, appending to libvirt-override.py? -- pozdrawiam / best regards _.-._ Wojtek Porczyk .-^' '^-. Invisible Things Lab |'-.-^-.-'| | | | | I do not fear computers, | '-.-' | I fear lack of them. '-._ : ,-' -- Isaac Asimov `^-^-_>

2 3

[libvirt] limit cpu speed in domain xml
by Vasiliy Tolstov 16 Mar '17

16 Mar '17

Hi. Does it possible to limit vm cpu speed for example to 1Ghz or 500Mhz ? I need to simulate some hardware with specific cpu speed and test my application inside this vm , i want to measure results from each test and need constant cpu speed for testing (i need to run test not only my notebook but on server too and want identical cpu speed inside vm) -- Vasiliy Tolstov, e-mail: v.tolstov(a)selfip.ru

3 4

[libvirt] libvirt-python bug: custom event loop impl calls ff callback from *Remove(Handle|Timeout)Func
by Wojtek Porczyk 16 Mar '17

16 Mar '17

Hello libvirt-list, As of current libvirt-python.git, according to libvirt-override.c, if implementing custom event loop in Python, ff callback is called from libvirt_virEventRemoveHandleFunc, which is a C glue between virEventRegisterImpl and actual removeHandle function written in Python: > result = PyEval_CallObject(removeHandleObj, pyobj_args); > if (!result) { > PyErr_Print(); > PyErr_Clear(); > } else if (!PyTuple_Check(result) || PyTuple_Size(result) != 3) { > DEBUG("%s: %s must return opaque obj registered with %s" > "to avoid leaking libvirt memory\n", > __FUNCTION__, NAME(removeHandle), NAME(addHandle)); > } else { > opaque = PyTuple_GetItem(result, 1); > ff = PyTuple_GetItem(result, 2); > cff = PyvirFreeCallback_Get(ff); > if (cff) > (*cff)(PyvirVoidPtr_Get(opaque)); > retval = 0; > } This is exactly what one shoud not be doing according to documentation [1]: > If the opaque user data requires free'ing when the handle is unregistered, > then a 2nd callback can be supplied for this purpose. This callback needs to > be invoked from a clean stack. If 'ff' callbacks are invoked directly from the > virEventRemoveHandleFunc they will likely deadlock in libvirt. [1] https://libvirt.org/html/libvirt-libvirt-event.html#virEventAddHandleFunc This is true, the deadlock occurs. When the "result" tuple is mangled to have None as third item ("ff"), then cff = PyvirFreeCallback_Get(ff) is NULL and the deadlock does not happen. That's also why script examples/event-test.py does not deadlock, because it does not return anything (that is, returns None) from Python, so the second if block happens and the ff callback, if any, is not executed (and probably something leaks, but I didn't check for that). Everything also applies to to timeouts (libvirt_virEventRemoteTimeoutFunc). -- pozdrawiam / best regards _.-._ Wojtek Porczyk .-^' '^-. Invisible Things Lab |'-.-^-.-'| | | | | I do not fear computers, | '-.-' | I fear lack of them. '-._ : ,-' -- Isaac Asimov `^-^-_>

3 4

[libvirt] [PATCH 0/4] qemu: Add support for generic PCIe Root Ports
by Andrea Bolognani 16 Mar '17

16 Mar '17

Andrea Bolognani (4): qemu: Add support for generic PCIe Root Ports qemu: Use generic PCIe Root Ports by default for aarch64/virt tests: Test generic PCIe Root Ports news: Document support for generic PCIe Root Ports docs/news.xml | 9 +++++ docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c | 4 ++- src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 18 ++++++++-- src/qemu/qemu_domain_address.c | 15 +++++++-- tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 + ...uxml2argv-pcie-root-port-mach-virt-generic.args | 22 +++++++++++++ ...muxml2argv-pcie-root-port-mach-virt-generic.xml | 22 +++++++++++++ ...uxml2argv-pcie-root-port-mach-virt-ioh3420.args | 21 ++++++++++++ ...muxml2argv-pcie-root-port-mach-virt-ioh3420.xml | 19 +++++++++++ ...t.args => qemuxml2argv-pcie-root-port-q35.args} | 7 ++-- .../qemuxml2argv-pcie-root-port-q35.xml | 23 +++++++++++++ .../qemuxml2argv-pcie-root-port.xml | 36 -------------------- tests/qemuxml2argvtest.c | 27 ++++++++++++--- ...xml2xmlout-pcie-root-port-mach-virt-generic.xml | 38 ++++++++++++++++++++++ ...xml2xmlout-pcie-root-port-mach-virt-ioh3420.xml | 33 +++++++++++++++++++ ...t.xml => qemuxml2xmlout-pcie-root-port-q35.xml} | 19 +++++------ tests/qemuxml2xmltest.c | 22 ++++++++++--- 21 files changed, 272 insertions(+), 69 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pcie-root-port-mach-virt-generic.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pcie-root-port-mach-virt-generic.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pcie-root-port-mach-virt-ioh3420.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pcie-root-port-mach-virt-ioh3420.xml rename tests/qemuxml2argvdata/{qemuxml2argv-pcie-root-port.args => qemuxml2argv-pcie-root-port-q35.args} (59%) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pcie-root-port-q35.xml delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pcie-root-port.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-pcie-root-port-mach-virt-generic.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-pcie-root-port-mach-virt-ioh3420.xml rename tests/qemuxml2xmloutdata/{qemuxml2xmlout-pcie-root-port.xml => qemuxml2xmlout-pcie-root-port-q35.xml} (71%) -- 2.7.4

2 14

[libvirt] [PATCH] qemucapstest: Update test data for QEMU 2.9.0
by Michal Privoznik 16 Mar '17

16 Mar '17

Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- .../qemucapabilitiesdata/caps_2.9.0.x86_64.replies | 3254 +++++++++++--------- tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 11 +- 2 files changed, 1806 insertions(+), 1459 deletions(-) diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.replies b/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.replies index f6109513a..357042017 100644 --- a/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.replies +++ b/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.replies @@ -2,11 +2,11 @@ "QMP": { "version": { "qemu": { - "micro": 50, + "micro": 90, "minor": 8, "major": 2 }, - "package": " (v2.8.0-1961-g5b10b94bd5)" + "package": " (v2.9.0-rc0-15-g1883ff34b5)" }, "capabilities": [ ] @@ -22,11 +22,11 @@ { "return": { "qemu": { - "micro": 50, + "micro": 90, "minor": 8, "major": 2 }, - "package": " (v2.8.0-1961-g5b10b94bd5)" + "package": " (v2.9.0-rc0-15-g1883ff34b5)" }, "id": "libvirt-2" } @@ -40,6 +40,18 @@ { "return": [ + { + "name": "netdev_add" + }, + { + "name": "device_add" + }, + { + "name": "query-qmp-schema" + }, + { + "name": "xen-set-replication" + }, { "name": "xen-set-global-dirty-log" }, @@ -49,6 +61,9 @@ { "name": "xen-load-devices-state" }, + { + "name": "xen-colo-do-checkpoint" + }, { "name": "x-colo-lost-heartbeat" }, @@ -112,12 +127,18 @@ { "name": "quit" }, + { + "name": "query-xen-replication-status" + }, { "name": "query-vnc-servers" }, { "name": "query-vnc" }, + { + "name": "query-vm-generation-id" + }, { "name": "query-version" }, @@ -456,15 +477,6 @@ }, { "name": "add-fd" - }, - { - "name": "netdev_add" - }, - { - "name": "device_add" - }, - { - "name": "query-qmp-schema" } ], "id": "libvirt-4" @@ -472,7 +484,7 @@ { "return": { - "fd": 15, + "fd": 16, "fdset-id": 0 }, "id": "libvirt-5" @@ -710,7 +722,7 @@ "name": "secret" }, { - "name": "filter-buffer" + "name": "qio-channel-tls" }, { "name": "PIIX3-xen" @@ -734,7 +746,7 @@ "name": "container" }, { - "name": "qio-channel-rdma" + "name": "filter-buffer" }, { "name": "chardev-null" @@ -841,9 +853,6 @@ { "name": "PCIE" }, - { - "name": "qio-channel-buffer" - }, { "name": "chardev-pty" }, @@ -874,6 +883,9 @@ { "name": "pcie-root-port" }, + { + "name": "qio-channel-buffer" + }, { "name": "chardev-serial" }, @@ -940,9 +952,6 @@ { "name": "pc-i440fx-1.5-machine" }, - { - "name": "tls-creds-x509" - }, { "name": "or-irq" }, @@ -988,6 +997,12 @@ { "name": "core2duo-x86_64-cpu" }, + { + "name": "qio-channel-command" + }, + { + "name": "tls-creds-x509" + }, { "name": "virtio-9p-pci" }, @@ -1003,9 +1018,6 @@ { "name": "sb16" }, - { - "name": "chardev-socket" - }, { "name": "qemu-console" }, @@ -1018,6 +1030,9 @@ { "name": "usb-mouse" }, + { + "name": "virtio-blk-pci" + }, { "name": "xenfv-machine" }, @@ -1025,7 +1040,7 @@ "name": "filter-dump" }, { - "name": "virtio-blk-pci" + "name": "virtio-keyboard-pci" }, { "name": "chardev-stdio" @@ -1057,14 +1072,11 @@ { "name": "i8257" }, - { - "name": "filter-mirror" - }, { "name": "Opteron_G4-x86_64-cpu" }, { - "name": "qio-channel-file" + "name": "filter-mirror" }, { "name": "virtio-mmio" @@ -1094,10 +1106,7 @@ "name": "sd-bus" }, { - "name": "ib700" - }, - { - "name": "virtio-keyboard-pci" + "name": "qio-channel-file" }, { "name": "usb-hub" @@ -1115,7 +1124,7 @@ "name": "igd-passthrough-i440FX" }, { - "name": "ccid-card-passthru" + "name": "chardev-socket" }, { "name": "chardev-hci" @@ -1123,6 +1132,9 @@ { "name": "igd-passthrough-isa-bridge" }, + { + "name": "rocker" + }, { "name": "nec-usb-xhci" }, @@ -1133,7 +1145,7 @@ "name": "pci-ohci" }, { - "name": "qemu:memory-region" + "name": "ib700" }, { "name": "xio3130-downstream" @@ -1162,27 +1174,27 @@ { "name": "isa-ipmi-kcs" }, - { - "name": "isa-ide" - }, - { - "name": "rng-random" - }, { "name": "virtio-crypto-pci" }, - { - "name": "isa-vga" - }, { "name": "virtio-keyboard-device" }, { - "name": "rocker" + "name": "isa-vga" + }, + { + "name": "isa-ide" + }, + { + "name": "qemu:memory-region" }, { "name": "ipmi-bmc-extern" }, + { + "name": "rng-random" + }, { "name": "kvm-i8259" }, @@ -1244,7 +1256,7 @@ "name": "chardev-gdb" }, { - "name": "qio-channel-command" + "name": "virtio-pci-bus" }, { "name": "chardev-vc" @@ -1252,9 +1264,6 @@ { "name": "lsi53c895a" }, - { - "name": "usb-audio" - }, { "name": "chardev-udp" }, @@ -1265,7 +1274,7 @@ "name": "pxb-bus" }, { - "name": "dc390" + "name": "usb-audio" }, { "name": "usb-wacom-tablet" @@ -1282,6 +1291,9 @@ { "name": "phenom-x86_64-cpu" }, + { + "name": "usb-ccid" + }, { "name": "fw_cfg_io" }, @@ -1298,11 +1310,14 @@ "name": "cs4231a" }, { - "name": "chardev-braille" + "name": "dc390" }, { "name": "nvme" }, + { + "name": "chardev-wctablet" + }, { "name": "i82801b11-bridge" }, @@ -1313,7 +1328,7 @@ "name": "usb-tablet" }, { - "name": "usb-ccid" + "name": "usb-bot" }, { "name": "sdhci-bus" @@ -1336,9 +1351,6 @@ { "name": "tcg-accel" }, - { - "name": "usb-bot" - }, { "name": "isa-cirrus-vga" }, @@ -1381,6 +1393,9 @@ { "name": "nvdimm" }, + { + "name": "x3130-upstream" + }, { "name": "ich9-usb-uhci6" }, @@ -1393,9 +1408,6 @@ { "name": "virtio-balloon-device" }, - { - "name": "x3130-upstream" - }, { "name": "ich9-usb-uhci5" }, @@ -1483,9 +1495,6 @@ { "name": "virtio-rng-device" }, - { - "name": "ccid-card-emulated" - }, { "name": "am53c974" }, @@ -1565,7 +1574,7 @@ "name": "xen-backend" }, { - "name": "qio-channel-tls" + "name": "usb-redir" }, { "name": "virtio-serial-pci" @@ -1601,7 +1610,7 @@ "name": "chardev-parallel" }, { - "name": "virtio-pci-bus" + "name": "qemu-xhci" }, { "name": "pxb" @@ -1619,7 +1628,7 @@ "name": "kvm64-x86_64-cpu" }, { - "name": "usb-redir" + "name": "usb-storage" }, { "name": "vt82c686b-usb-uhci" @@ -1628,7 +1637,7 @@ "name": "HDA" }, { - "name": "usb-storage" + "name": "vmgenid" }, { "name": "pc-1.3-machine" @@ -1845,6 +1854,11 @@ "name": "bootindex", "type": "int32" }, + { + "name": "any_layout", + "description": "on/off", + "type": "bool" + }, { "name": "x-pcie-lnksta-dllla", "description": "on/off", @@ -1856,8 +1870,7 @@ "type": "bool" }, { - "name": "any_layout", - "description": "on/off", + "name": "share-rw", "type": "bool" }, { @@ -2594,6 +2607,10 @@ "description": "on/off/auto", "type": "OnOffAuto" }, + { + "name": "share-rw", + "type": "bool" + }, { "name": "opt_io_size", "type": "uint32" @@ -2683,6 +2700,10 @@ "description": "on/off/auto", "type": "OnOffAuto" }, + { + "name": "share-rw", + "type": "bool" + }, { "name": "opt_io_size", "type": "uint32" @@ -3079,6 +3100,10 @@ "description": "on/off/auto", "type": "OnOffAuto" }, + { + "name": "share-rw", + "type": "bool" + }, { "name": "opt_io_size", "type": "uint32" @@ -4300,41 +4325,6 @@ { "return": [ - { - "parameters": [ - { - "name": "timeout", - "help": "Request timeout in seconds (default 0 = no timeout)", - "type": "number" - }, - { - "name": "initiator-name", - "help": "Initiator iqn name to use when connecting", - "type": "string" - }, - { - "name": "header-digest", - "help": "HeaderDigest setting. {CRC32C|CRC32C-NONE|NONE-CRC32C|NONE}", - "type": "string" - }, - { - "name": "password-secret", - "help": "ID of the secret providing password for CHAP authentication to target", - "type": "string" - }, - { - "name": "password", - "help": "password for CHAP authentication to target", - "type": "string" - }, - { - "name": "user", - "help": "username for CHAP authentication to target", - "type": "string" - } - ], - "option": "iscsi" - }, { "parameters": [ { @@ -4426,10 +4416,22 @@ }, { "parameters": [ + { + "name": "rendernode", + "type": "string" + }, { "name": "gl", "type": "boolean" }, + { + "name": "head", + "type": "number" + }, + { + "name": "display", + "type": "string" + }, { "name": "seamless-migration", "type": "boolean" @@ -4590,6 +4592,101 @@ }, { "parameters": [ + { + "name": "throttling.iops-size", + "help": "when limiting by iops max size of an I/O in bytes", + "type": "number" + }, + { + "name": "throttling.bps-write-max-length", + "help": "length of the bps-write-max burst period, in seconds", + "type": "number" + }, + { + "name": "throttling.bps-read-max-length", + "help": "length of the bps-read-max burst period, in seconds", + "type": "number" + }, + { + "name": "throttling.bps-total-max-length", + "help": "length of the bps-total-max burst period, in seconds", + "type": "number" + }, + { + "name": "throttling.iops-write-max-length", + "help": "length of the iops-write-max burst period, in seconds", + "type": "number" + }, + { + "name": "throttling.iops-read-max-length", + "help": "length of the iops-read-max burst period, in seconds", + "type": "number" + }, + { + "name": "throttling.iops-total-max-length", + "help": "length of the iops-total-max burst period, in seconds", + "type": "number" + }, + { + "name": "throttling.bps-write-max", + "help": "total bytes write burst", + "type": "number" + }, + { + "name": "throttling.bps-read-max", + "help": "total bytes read burst", + "type": "number" + }, + { + "name": "throttling.bps-total-max", + "help": "total bytes burst", + "type": "number" + }, + { + "name": "throttling.iops-write-max", + "help": "I/O operations write burst", + "type": "number" + }, + { + "name": "throttling.iops-read-max", + "help": "I/O operations read burst", + "type": "number" + }, + { + "name": "throttling.iops-total-max", + "help": "I/O operations burst", + "type": "number" + }, + { + "name": "throttling.bps-write", + "help": "limit write bytes per second", + "type": "number" + }, + { + "name": "throttling.bps-read", + "help": "limit read bytes per second", + "type": "number" + }, + { + "name": "throttling.bps-total", + "help": "limit total bytes per second", + "type": "number" + }, + { + "name": "throttling.iops-write", + "help": "limit write operations per second", + "type": "number" + }, + { + "name": "throttling.iops-read", + "help": "limit read operations per second", + "type": "number" + }, + { + "name": "throttling.iops-total", + "help": "limit total I/O operations per second", + "type": "number" + }, { "name": "sock_fd", "type": "number" @@ -4844,6 +4941,21 @@ ], "option": "memory" }, + { + "parameters": [ + { + "name": "thread", + "help": "Enable/disable multi-threaded TCG", + "type": "string" + }, + { + "name": "accel", + "help": "Select the type of accelerator", + "type": "string" + } + ], + "option": "accel" + }, { "parameters": [ { @@ -6375,14 +6487,26 @@ "arg-type": "17" }, { - "name": "query-vnc", + "name": "query-vm-generation-id", "ret-type": "156", "meta-type": "command", "arg-type": "17" }, + { + "name": "query-vnc", + "ret-type": "157", + "meta-type": "command", + "arg-type": "17" + }, { "name": "query-vnc-servers", - "ret-type": "[157]", + "ret-type": "[158]", + "meta-type": "command", + "arg-type": "17" + }, + { + "name": "query-xen-replication-status", + "ret-type": "159", "meta-type": "command", "arg-type": "17" }, @@ -6396,19 +6520,19 @@ "name": "remove-fd", "ret-type": "17", "meta-type": "command", - "arg-type": "158" + "arg-type": "160" }, { "name": "ringbuf-read", "ret-type": "str", "meta-type": "command", - "arg-type": "159" + "arg-type": "161" }, { "name": "ringbuf-write", "ret-type": "17", "meta-type": "command", - "arg-type": "160" + "arg-type": "162" }, { "name": "rtc-reset-reinjection", @@ -6420,25 +6544,25 @@ "name": "screendump", "ret-type": "17", "meta-type": "command", - "arg-type": "161" + "arg-type": "163" }, { "name": "send-key", "ret-type": "17", "meta-type": "command", - "arg-type": "162" + "arg-type": "164" }, { "name": "set_link", "ret-type": "17", "meta-type": "command", - "arg-type": "163" + "arg-type": "165" }, { "name": "set_password", "ret-type": "17", "meta-type": "command", - "arg-type": "164" + "arg-type": "166" }, { "name": "stop", @@ -6466,45 +6590,45 @@ }, { "name": "trace-event-get-state", - "ret-type": "[166]", - "meta-type": "command", - "arg-type": "165" - }, - { - "name": "trace-event-set-state", - "ret-type": "17", + "ret-type": "[168]", "meta-type": "command", "arg-type": "167" }, + { + "name": "trace-event-set-state", + "ret-type": "17", + "meta-type": "command", + "arg-type": "169" + }, { "name": "transaction", "ret-type": "17", "meta-type": "command", - "arg-type": "168" + "arg-type": "170" }, { "name": "x-blockdev-change", "ret-type": "17", "meta-type": "command", - "arg-type": "169" + "arg-type": "171" }, { "name": "x-blockdev-del", "ret-type": "17", "meta-type": "command", - "arg-type": "170" + "arg-type": "172" }, { "name": "x-blockdev-insert-medium", "ret-type": "17", "meta-type": "command", - "arg-type": "171" + "arg-type": "173" }, { "name": "x-blockdev-remove-medium", "ret-type": "17", "meta-type": "command", - "arg-type": "172" + "arg-type": "174" }, { "name": "x-colo-lost-heartbeat", @@ -6512,23 +6636,35 @@ "meta-type": "command", "arg-type": "17" }, + { + "name": "xen-colo-do-checkpoint", + "ret-type": "17", + "meta-type": "command", + "arg-type": "17" + }, { "name": "xen-load-devices-state", "ret-type": "17", "meta-type": "command", - "arg-type": "173" + "arg-type": "175" }, { "name": "xen-save-devices-state", "ret-type": "17", "meta-type": "command", - "arg-type": "174" + "arg-type": "176" }, { "name": "xen-set-global-dirty-log", "ret-type": "17", "meta-type": "command", - "arg-type": "175" + "arg-type": "177" + }, + { + "name": "xen-set-replication", + "ret-type": "17", + "meta-type": "command", + "arg-type": "178" }, { "name": "0", @@ -6596,11 +6732,11 @@ }, { "name": "operation", - "type": "176" + "type": "179" }, { "name": "action", - "type": "177" + "type": "180" }, { "name": "nospace", @@ -6619,7 +6755,7 @@ "members": [ { "name": "type", - "type": "178" + "type": "181" }, { "name": "device", @@ -6645,7 +6781,7 @@ "members": [ { "name": "type", - "type": "178" + "type": "181" }, { "name": "device", @@ -6680,11 +6816,11 @@ }, { "name": "operation", - "type": "176" + "type": "179" }, { "name": "action", - "type": "177" + "type": "180" } ], "meta-type": "object" @@ -6694,7 +6830,7 @@ "members": [ { "name": "type", - "type": "178" + "type": "181" }, { "name": "device", @@ -6786,12 +6922,12 @@ "members": [ { "name": "action", - "type": "179" + "type": "182" }, { "name": "info", "default": null, - "type": "180" + "type": "183" } ], "meta-type": "object" @@ -6815,7 +6951,7 @@ "members": [ { "name": "status", - "type": "181" + "type": "184" } ], "meta-type": "object" @@ -6874,7 +7010,7 @@ "members": [ { "name": "type", - "type": "182" + "type": "185" }, { "name": "error", @@ -6911,11 +7047,11 @@ "members": [ { "name": "server", - "type": "183" + "type": "186" }, { "name": "client", - "type": "183" + "type": "186" } ], "meta-type": "object" @@ -6925,11 +7061,11 @@ "members": [ { "name": "server", - "type": "183" + "type": "186" }, { "name": "client", - "type": "183" + "type": "186" } ], "meta-type": "object" @@ -6939,25 +7075,25 @@ "members": [ { "name": "server", - "type": "184" - }, - { - "name": "client", - "type": "185" - } - ], - "meta-type": "object" - }, - { - "name": "24", - "members": [ - { - "name": "server", - "type": "186" - }, - { - "name": "client", "type": "187" + }, + { + "name": "client", + "type": "188" + } + ], + "meta-type": "object" + }, + { + "name": "24", + "members": [ + { + "name": "server", + "type": "189" + }, + { + "name": "client", + "type": "190" } ], "meta-type": "object" @@ -6967,11 +7103,11 @@ "members": [ { "name": "server", - "type": "186" + "type": "189" }, { "name": "client", - "type": "188" + "type": "191" } ], "meta-type": "object" @@ -6981,11 +7117,11 @@ "members": [ { "name": "server", - "type": "186" + "type": "189" }, { "name": "client", - "type": "188" + "type": "191" } ], "meta-type": "object" @@ -7009,7 +7145,7 @@ "members": [ { "name": "action", - "type": "189" + "type": "192" } ], "meta-type": "object" @@ -7109,6 +7245,11 @@ "name": "speed", "default": null, "type": "int" + }, + { + "name": "filter-node-name", + "default": null, + "type": "str" } ], "meta-type": "object" @@ -7254,7 +7395,7 @@ { "name": "on-error", "default": null, - "type": "190" + "type": "193" } ], "meta-type": "object" @@ -7413,139 +7554,147 @@ "name": "46", "tag": "driver", "variants": [ - { - "case": "archipelago", - "type": "195" - }, { "case": "blkdebug", - "type": "196" + "type": "198" }, { "case": "blkverify", - "type": "197" + "type": "199" }, { "case": "bochs", - "type": "198" + "type": "200" }, { "case": "cloop", - "type": "198" + "type": "200" }, { "case": "dmg", - "type": "198" + "type": "200" }, { "case": "file", - "type": "199" + "type": "201" }, { "case": "ftp", - "type": "200" + "type": "202" }, { "case": "ftps", - "type": "200" + "type": "202" }, { "case": "gluster", - "type": "201" + "type": "203" }, { "case": "host_cdrom", - "type": "199" + "type": "201" }, { "case": "host_device", - "type": "199" + "type": "201" }, { "case": "http", - "type": "200" + "type": "202" }, { "case": "https", - "type": "200" - }, - { - "case": "luks", "type": "202" }, + { + "case": "iscsi", + "type": "204" + }, + { + "case": "luks", + "type": "205" + }, { "case": "nbd", - "type": "203" + "type": "206" }, { "case": "nfs", - "type": "204" + "type": "207" }, { "case": "null-aio", - "type": "205" + "type": "208" }, { "case": "null-co", - "type": "205" + "type": "208" }, { "case": "parallels", - "type": "198" + "type": "200" }, { "case": "qcow2", - "type": "206" + "type": "209" }, { "case": "qcow", - "type": "207" + "type": "210" }, { "case": "qed", - "type": "207" + "type": "210" }, { "case": "quorum", - "type": "208" + "type": "211" }, { "case": "raw", - "type": "209" + "type": "212" + }, + { + "case": "rbd", + "type": "213" }, { "case": "replication", - "type": "210" + "type": "214" + }, + { + "case": "sheepdog", + "type": "215" }, { "case": "ssh", - "type": "211" + "type": "216" }, { "case": "vdi", - "type": "198" + "type": "200" }, { "case": "vhdx", - "type": "198" + "type": "200" }, { "case": "vmdk", - "type": "207" + "type": "210" }, { "case": "vpc", - "type": "198" + "type": "200" }, { "case": "vvfat", - "type": "212" + "type": "217" } ], "members": [ { "name": "driver", - "type": "191" + "type": "194" }, { "name": "node-name", @@ -7555,12 +7704,12 @@ { "name": "discard", "default": null, - "type": "192" + "type": "195" }, { "name": "cache", "default": null, - "type": "193" + "type": "196" }, { "name": "read-only", @@ -7570,7 +7719,7 @@ { "name": "detect-zeroes", "default": null, - "type": "194" + "type": "197" } ], "meta-type": "object" @@ -7593,7 +7742,7 @@ }, { "name": "sync", - "type": "213" + "type": "218" }, { "name": "speed", @@ -7608,12 +7757,12 @@ { "name": "on-source-error", "default": null, - "type": "190" + "type": "193" }, { "name": "on-target-error", "default": null, - "type": "190" + "type": "193" } ], "meta-type": "object" @@ -7643,7 +7792,7 @@ { "name": "read-only-mode", "default": null, - "type": "214" + "type": "219" } ], "meta-type": "object" @@ -7687,7 +7836,7 @@ }, { "name": "sync", - "type": "213" + "type": "218" }, { "name": "speed", @@ -7707,12 +7856,17 @@ { "name": "on-source-error", "default": null, - "type": "190" + "type": "193" }, { "name": "on-target-error", "default": null, - "type": "190" + "type": "193" + }, + { + "name": "filter-node-name", + "default": null, + "type": "str" } ], "meta-type": "object" @@ -7850,7 +8004,7 @@ { "name": "mode", "default": null, - "type": "215" + "type": "220" } ], "meta-type": "object" @@ -7911,7 +8065,7 @@ }, { "name": "backend", - "type": "216" + "type": "221" } ], "meta-type": "object" @@ -8083,12 +8237,12 @@ }, { "name": "sync", - "type": "213" + "type": "218" }, { "name": "mode", "default": null, - "type": "215" + "type": "220" }, { "name": "speed", @@ -8108,12 +8262,12 @@ { "name": "on-source-error", "default": null, - "type": "190" + "type": "193" }, { "name": "on-target-error", "default": null, - "type": "190" + "type": "193" } ], "meta-type": "object" @@ -8151,12 +8305,12 @@ }, { "name": "sync", - "type": "213" + "type": "218" }, { "name": "mode", "default": null, - "type": "215" + "type": "220" }, { "name": "speed", @@ -8176,12 +8330,12 @@ { "name": "on-source-error", "default": null, - "type": "190" + "type": "193" }, { "name": "on-target-error", "default": null, - "type": "190" + "type": "193" }, { "name": "unmap", @@ -8220,7 +8374,7 @@ { "name": "format", "default": null, - "type": "217" + "type": "222" } ], "meta-type": "object" @@ -8315,7 +8469,7 @@ }, { "name": "events", - "type": "[218]" + "type": "[223]" } ], "meta-type": "object" @@ -8494,7 +8648,7 @@ "members": [ { "name": "addr", - "type": "219" + "type": "224" }, { "name": "tls-creds", @@ -8691,7 +8845,7 @@ }, { "name": "slot-type", - "type": "220" + "type": "225" }, { "name": "source", @@ -8751,12 +8905,12 @@ { "name": "io-status", "default": null, - "type": "221" + "type": "226" }, { "name": "dirty-bitmaps", "default": null, - "type": "[222]" + "type": "[227]" } ], "meta-type": "object" @@ -8799,7 +8953,7 @@ }, { "name": "io-status", - "type": "221" + "type": "226" }, { "name": "ready", @@ -8839,7 +8993,7 @@ }, { "name": "stats", - "type": "223" + "type": "228" }, { "name": "parent", @@ -8917,7 +9071,7 @@ }, { "name": "parameters", - "type": "[224]" + "type": "[229]" } ], "meta-type": "object" @@ -8975,11 +9129,11 @@ "members": [ { "name": "modela", - "type": "225" + "type": "230" }, { "name": "modelb", - "type": "225" + "type": "230" } ], "meta-type": "object" @@ -8989,7 +9143,7 @@ "members": [ { "name": "model", - "type": "225" + "type": "230" } ], "meta-type": "object" @@ -8999,11 +9153,11 @@ "members": [ { "name": "modela", - "type": "225" + "type": "230" }, { "name": "modelb", - "type": "225" + "type": "230" } ], "meta-type": "object" @@ -9013,7 +9167,7 @@ "members": [ { "name": "result", - "type": "226" + "type": "231" }, { "name": "responsible-properties", @@ -9027,11 +9181,11 @@ "members": [ { "name": "type", - "type": "227" + "type": "232" }, { "name": "model", - "type": "225" + "type": "230" } ], "meta-type": "object" @@ -9041,7 +9195,7 @@ "members": [ { "name": "model", - "type": "225" + "type": "230" } ], "meta-type": "object" @@ -9057,27 +9211,27 @@ "variants": [ { "case": "x86", - "type": "229" + "type": "234" }, { "case": "sparc", - "type": "230" + "type": "235" }, { "case": "ppc", - "type": "231" + "type": "236" }, { "case": "mips", - "type": "232" + "type": "237" }, { "case": "tricore", - "type": "233" + "type": "238" }, { "case": "other", - "type": "234" + "type": "239" } ], "members": [ @@ -9103,7 +9257,7 @@ }, { "name": "arch", - "type": "228" + "type": "233" } ], "meta-type": "object" @@ -9113,7 +9267,7 @@ "members": [ { "name": "status", - "type": "235" + "type": "240" }, { "name": "completed", @@ -9131,7 +9285,7 @@ "members": [ { "name": "formats", - "type": "[217]" + "type": "[222]" } ], "meta-type": "object" @@ -9165,7 +9319,7 @@ }, { "name": "fds", - "type": "[236]" + "type": "[241]" } ], "meta-type": "object" @@ -9211,7 +9365,7 @@ }, { "name": "props", - "type": "237" + "type": "242" }, { "name": "qom-path", @@ -9236,6 +9390,18 @@ { "name": "thread-id", "type": "int" + }, + { + "name": "poll-max-ns", + "type": "int" + }, + { + "name": "poll-grow", + "type": "int" + }, + { + "name": "poll-shrink", + "type": "int" } ], "meta-type": "object" @@ -9322,7 +9488,7 @@ }, { "name": "policy", - "type": "238" + "type": "243" } ], "meta-type": "object" @@ -9338,13 +9504,13 @@ "variants": [ { "case": "dimm", - "type": "240" + "type": "245" } ], "members": [ { "name": "type", - "type": "239" + "type": "244" } ], "meta-type": "object" @@ -9382,22 +9548,22 @@ { "name": "status", "default": null, - "type": "181" + "type": "184" }, { "name": "ram", "default": null, - "type": "241" + "type": "246" }, { "name": "disk", "default": null, - "type": "241" + "type": "246" }, { "name": "xbzrle-cache", "default": null, - "type": "242" + "type": "247" }, { "name": "total-time", @@ -9447,7 +9613,7 @@ "members": [ { "name": "capability", - "type": "243" + "type": "248" }, { "name": "state", @@ -9511,7 +9677,7 @@ }, { "name": "detect_zeroes", - "type": "194" + "type": "197" }, { "name": "bps", @@ -9539,7 +9705,7 @@ }, { "name": "image", - "type": "244" + "type": "249" }, { "name": "bps_max", @@ -9613,7 +9779,7 @@ }, { "name": "cache", - "type": "245" + "type": "250" }, { "name": "write_threshold", @@ -9636,7 +9802,7 @@ }, { "name": "devices", - "type": "[246]" + "type": "[251]" } ], "meta-type": "object" @@ -9652,31 +9818,31 @@ "variants": [ { "case": "builtin", - "type": "248" + "type": "253" }, { "case": "enum", - "type": "249" + "type": "254" }, { "case": "array", - "type": "250" + "type": "255" }, { "case": "object", - "type": "251" + "type": "256" }, { "case": "alternate", - "type": "252" + "type": "257" }, { "case": "command", - "type": "253" + "type": "258" }, { "case": "event", - "type": "254" + "type": "259" } ], "members": [ @@ -9686,7 +9852,7 @@ }, { "name": "meta-type", - "type": "247" + "type": "252" } ], "meta-type": "object" @@ -9752,15 +9918,15 @@ }, { "name": "key", - "type": "255" + "type": "260" }, { "name": "mask", - "type": "256" + "type": "261" }, { "name": "action", - "type": "257" + "type": "262" } ], "meta-type": "object" @@ -9890,11 +10056,11 @@ }, { "name": "duplex", - "type": "258" + "type": "263" }, { "name": "autoneg", - "type": "259" + "type": "264" } ], "meta-type": "object" @@ -9928,15 +10094,15 @@ }, { "name": "multicast", - "type": "260" + "type": "265" }, { "name": "unicast", - "type": "260" + "type": "265" }, { "name": "vlan", - "type": "260" + "type": "265" }, { "name": "broadcast-allowed", @@ -10007,12 +10173,12 @@ }, { "name": "mouse-mode", - "type": "261" + "type": "266" }, { "name": "channels", "default": null, - "type": "[185]" + "type": "[188]" } ], "meta-type": "object" @@ -10030,7 +10196,7 @@ }, { "name": "status", - "type": "262" + "type": "267" } ], "meta-type": "object" @@ -10063,7 +10229,7 @@ }, { "name": "options", - "type": "263" + "type": "268" } ], "meta-type": "object" @@ -10107,7 +10273,7 @@ "members": [ { "name": "qemu", - "type": "264" + "type": "269" }, { "name": "package", @@ -10120,85 +10286,80 @@ "name": "156", "members": [ { - "name": "enabled", - "type": "bool" - }, - { - "name": "host", - "default": null, + "name": "guid", "type": "str" - }, - { - "name": "family", - "default": null, - "type": "265" - }, - { - "name": "service", - "default": null, - "type": "str" - }, - { - "name": "auth", - "default": null, - "type": "str" - }, - { - "name": "clients", - "default": null, - "type": "[188]" } ], "meta-type": "object" }, - { - "name": "[157]", - "element-type": "157", - "meta-type": "array" - }, { "name": "157", "members": [ { - "name": "id", + "name": "enabled", + "type": "bool" + }, + { + "name": "host", + "default": null, "type": "str" }, { - "name": "server", - "type": "[266]" + "name": "family", + "default": null, + "type": "270" }, { - "name": "clients", - "type": "[188]" + "name": "service", + "default": null, + "type": "str" }, { "name": "auth", - "type": "267" - }, - { - "name": "vencrypt", - "default": null, - "type": "268" - }, - { - "name": "display", "default": null, "type": "str" + }, + { + "name": "clients", + "default": null, + "type": "[191]" } ], "meta-type": "object" }, + { + "name": "[158]", + "element-type": "158", + "meta-type": "array" + }, { "name": "158", "members": [ { - "name": "fdset-id", - "type": "int" + "name": "id", + "type": "str" }, { - "name": "fd", + "name": "server", + "type": "[271]" + }, + { + "name": "clients", + "type": "[191]" + }, + { + "name": "auth", + "type": "272" + }, + { + "name": "vencrypt", + "default": null, + "type": "273" + }, + { + "name": "display", "default": null, - "type": "int" + "type": "str" } ], "meta-type": "object" @@ -10207,17 +10368,13 @@ "name": "159", "members": [ { - "name": "device", - "type": "str" + "name": "error", + "type": "bool" }, { - "name": "size", - "type": "int" - }, - { - "name": "format", + "name": "desc", "default": null, - "type": "269" + "type": "str" } ], "meta-type": "object" @@ -10226,17 +10383,13 @@ "name": "160", "members": [ { - "name": "device", - "type": "str" + "name": "fdset-id", + "type": "int" }, { - "name": "data", - "type": "str" - }, - { - "name": "format", + "name": "fd", "default": null, - "type": "269" + "type": "int" } ], "meta-type": "object" @@ -10245,8 +10398,17 @@ "name": "161", "members": [ { - "name": "filename", + "name": "device", "type": "str" + }, + { + "name": "size", + "type": "int" + }, + { + "name": "format", + "default": null, + "type": "274" } ], "meta-type": "object" @@ -10255,13 +10417,17 @@ "name": "162", "members": [ { - "name": "keys", - "type": "[270]" + "name": "device", + "type": "str" }, { - "name": "hold-time", + "name": "data", + "type": "str" + }, + { + "name": "format", "default": null, - "type": "int" + "type": "274" } ], "meta-type": "object" @@ -10270,12 +10436,8 @@ "name": "163", "members": [ { - "name": "name", + "name": "filename", "type": "str" - }, - { - "name": "up", - "type": "bool" } ], "meta-type": "object" @@ -10284,17 +10446,13 @@ "name": "164", "members": [ { - "name": "protocol", - "type": "str" + "name": "keys", + "type": "[275]" }, { - "name": "password", - "type": "str" - }, - { - "name": "connected", + "name": "hold-time", "default": null, - "type": "str" + "type": "int" } ], "meta-type": "object" @@ -10307,32 +10465,27 @@ "type": "str" }, { - "name": "vcpu", - "default": null, - "type": "int" + "name": "up", + "type": "bool" } ], "meta-type": "object" }, - { - "name": "[166]", - "element-type": "166", - "meta-type": "array" - }, { "name": "166", "members": [ { - "name": "name", + "name": "protocol", "type": "str" }, { - "name": "state", - "type": "271" + "name": "password", + "type": "str" }, { - "name": "vcpu", - "type": "bool" + "name": "connected", + "default": null, + "type": "str" } ], "meta-type": "object" @@ -10344,15 +10497,6 @@ "name": "name", "type": "str" }, - { - "name": "enable", - "type": "bool" - }, - { - "name": "ignore-unavailable", - "default": null, - "type": "bool" - }, { "name": "vcpu", "default": null, @@ -10361,17 +10505,25 @@ ], "meta-type": "object" }, + { + "name": "[168]", + "element-type": "168", + "meta-type": "array" + }, { "name": "168", "members": [ { - "name": "actions", - "type": "[272]" + "name": "name", + "type": "str" }, { - "name": "properties", - "default": null, - "type": "273" + "name": "state", + "type": "276" + }, + { + "name": "vcpu", + "type": "bool" } ], "meta-type": "object" @@ -10380,18 +10532,22 @@ "name": "169", "members": [ { - "name": "parent", + "name": "name", "type": "str" }, { - "name": "child", + "name": "enable", + "type": "bool" + }, + { + "name": "ignore-unavailable", "default": null, - "type": "str" + "type": "bool" }, { - "name": "node", + "name": "vcpu", "default": null, - "type": "str" + "type": "int" } ], "meta-type": "object" @@ -10400,8 +10556,13 @@ "name": "170", "members": [ { - "name": "node-name", - "type": "str" + "name": "actions", + "type": "[277]" + }, + { + "name": "properties", + "default": null, + "type": "278" } ], "meta-type": "object" @@ -10410,17 +10571,17 @@ "name": "171", "members": [ { - "name": "device", - "default": null, + "name": "parent", "type": "str" }, { - "name": "id", + "name": "child", "default": null, "type": "str" }, { - "name": "node-name", + "name": "node", + "default": null, "type": "str" } ], @@ -10430,13 +10591,7 @@ "name": "172", "members": [ { - "name": "device", - "default": null, - "type": "str" - }, - { - "name": "id", - "default": null, + "name": "node-name", "type": "str" } ], @@ -10446,7 +10601,17 @@ "name": "173", "members": [ { - "name": "filename", + "name": "device", + "default": null, + "type": "str" + }, + { + "name": "id", + "default": null, + "type": "str" + }, + { + "name": "node-name", "type": "str" } ], @@ -10456,7 +10621,13 @@ "name": "174", "members": [ { - "name": "filename", + "name": "device", + "default": null, + "type": "str" + }, + { + "name": "id", + "default": null, "type": "str" } ], @@ -10464,6 +10635,26 @@ }, { "name": "175", + "members": [ + { + "name": "filename", + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "176", + "members": [ + { + "name": "filename", + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "177", "members": [ { "name": "enable", @@ -10472,13 +10663,32 @@ ], "meta-type": "object" }, + { + "name": "178", + "members": [ + { + "name": "enable", + "type": "bool" + }, + { + "name": "primary", + "type": "bool" + }, + { + "name": "failover", + "default": null, + "type": "bool" + } + ], + "meta-type": "object" + }, { "name": "bool", "json-type": "boolean", "meta-type": "builtin" }, { - "name": "176", + "name": "179", "meta-type": "enum", "values": [ "read", @@ -10486,7 +10696,7 @@ ] }, { - "name": "177", + "name": "180", "meta-type": "enum", "values": [ "ignore", @@ -10495,7 +10705,7 @@ ] }, { - "name": "178", + "name": "181", "meta-type": "enum", "values": [ "commit", @@ -10505,7 +10715,7 @@ ] }, { - "name": "179", + "name": "182", "meta-type": "enum", "values": [ "pause", @@ -10513,24 +10723,24 @@ ] }, { - "name": "180", + "name": "183", "tag": "type", "variants": [ { "case": "hyper-v", - "type": "275" + "type": "280" } ], "members": [ { "name": "type", - "type": "274" + "type": "279" } ], "meta-type": "object" }, { - "name": "181", + "name": "184", "meta-type": "enum", "values": [ "none", @@ -10545,7 +10755,7 @@ ] }, { - "name": "182", + "name": "185", "meta-type": "enum", "values": [ "read", @@ -10553,81 +10763,6 @@ "flush" ] }, - { - "name": "183", - "members": [ - { - "name": "host", - "type": "str" - }, - { - "name": "port", - "type": "str" - }, - { - "name": "family", - "type": "265" - } - ], - "meta-type": "object" - }, - { - "name": "184", - "members": [ - { - "name": "host", - "type": "str" - }, - { - "name": "port", - "type": "str" - }, - { - "name": "family", - "type": "265" - }, - { - "name": "auth", - "default": null, - "type": "str" - } - ], - "meta-type": "object" - }, - { - "name": "185", - "members": [ - { - "name": "host", - "type": "str" - }, - { - "name": "port", - "type": "str" - }, - { - "name": "family", - "type": "265" - }, - { - "name": "connection-id", - "type": "int" - }, - { - "name": "channel-type", - "type": "int" - }, - { - "name": "channel-id", - "type": "int" - }, - { - "name": "tls", - "type": "bool" - } - ], - "meta-type": "object" - }, { "name": "186", "members": [ @@ -10636,21 +10771,12 @@ "type": "str" }, { - "name": "service", + "name": "port", "type": "str" }, { "name": "family", - "type": "265" - }, - { - "name": "websocket", - "type": "bool" - }, - { - "name": "auth", - "default": null, - "type": "str" + "type": "270" } ], "meta-type": "object" @@ -10663,22 +10789,106 @@ "type": "str" }, { - "name": "service", + "name": "port", "type": "str" }, { "name": "family", - "type": "265" + "type": "270" }, { - "name": "websocket", - "type": "bool" + "name": "auth", + "default": null, + "type": "str" } ], "meta-type": "object" }, { "name": "188", + "members": [ + { + "name": "host", + "type": "str" + }, + { + "name": "port", + "type": "str" + }, + { + "name": "family", + "type": "270" + }, + { + "name": "connection-id", + "type": "int" + }, + { + "name": "channel-type", + "type": "int" + }, + { + "name": "channel-id", + "type": "int" + }, + { + "name": "tls", + "type": "bool" + } + ], + "meta-type": "object" + }, + { + "name": "189", + "members": [ + { + "name": "host", + "type": "str" + }, + { + "name": "service", + "type": "str" + }, + { + "name": "family", + "type": "270" + }, + { + "name": "websocket", + "type": "bool" + }, + { + "name": "auth", + "default": null, + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "190", + "members": [ + { + "name": "host", + "type": "str" + }, + { + "name": "service", + "type": "str" + }, + { + "name": "family", + "type": "270" + }, + { + "name": "websocket", + "type": "bool" + } + ], + "meta-type": "object" + }, + { + "name": "191", "members": [ { "name": "host", @@ -10690,7 +10900,7 @@ }, { "name": "family", - "type": "265" + "type": "270" }, { "name": "websocket", @@ -10710,7 +10920,7 @@ "meta-type": "object" }, { - "name": "189", + "name": "192", "meta-type": "enum", "values": [ "reset", @@ -10723,7 +10933,7 @@ ] }, { - "name": "190", + "name": "193", "meta-type": "enum", "values": [ "report", @@ -10734,10 +10944,9 @@ ] }, { - "name": "191", + "name": "194", "meta-type": "enum", "values": [ - "archipelago", "blkdebug", "blkverify", "bochs", @@ -10751,6 +10960,7 @@ "host_device", "http", "https", + "iscsi", "luks", "nbd", "nfs", @@ -10762,7 +10972,9 @@ "qed", "quorum", "raw", + "rbd", "replication", + "sheepdog", "ssh", "vdi", "vhdx", @@ -10771,70 +10983,45 @@ "vvfat" ] }, - { - "name": "192", - "meta-type": "enum", - "values": [ - "ignore", - "unmap" - ] - }, - { - "name": "193", - "members": [ - { - "name": "direct", - "default": null, - "type": "bool" - }, - { - "name": "no-flush", - "default": null, - "type": "bool" - } - ], - "meta-type": "object" - }, - { - "name": "194", - "meta-type": "enum", - "values": [ - "off", - "on", - "unmap" - ] - }, { "name": "195", - "members": [ - { - "name": "volume", - "type": "str" - }, - { - "name": "mport", - "default": null, - "type": "int" - }, - { - "name": "vport", - "default": null, - "type": "int" - }, - { - "name": "segment", - "default": null, - "type": "str" - } - ], - "meta-type": "object" + "meta-type": "enum", + "values": [ + "ignore", + "unmap" + ] }, { "name": "196", + "members": [ + { + "name": "direct", + "default": null, + "type": "bool" + }, + { + "name": "no-flush", + "default": null, + "type": "bool" + } + ], + "meta-type": "object" + }, + { + "name": "197", + "meta-type": "enum", + "values": [ + "off", + "on", + "unmap" + ] + }, + { + "name": "198", "members": [ { "name": "image", - "type": "276" + "type": "281" }, { "name": "config", @@ -10849,51 +11036,26 @@ { "name": "inject-error", "default": null, - "type": "[277]" + "type": "[282]" }, { "name": "set-state", "default": null, - "type": "[278]" + "type": "[283]" } ], "meta-type": "object" }, { - "name": "197", + "name": "199", "members": [ { "name": "test", - "type": "276" + "type": "281" }, { "name": "raw", - "type": "276" - } - ], - "meta-type": "object" - }, - { - "name": "198", - "members": [ - { - "name": "file", - "type": "276" - } - ], - "meta-type": "object" - }, - { - "name": "199", - "members": [ - { - "name": "filename", - "type": "str" - }, - { - "name": "aio", - "default": null, - "type": "279" + "type": "281" } ], "meta-type": "object" @@ -10902,8 +11064,8 @@ "name": "200", "members": [ { - "name": "filename", - "type": "str" + "name": "file", + "type": "281" } ], "meta-type": "object" @@ -10912,26 +11074,13 @@ "name": "201", "members": [ { - "name": "volume", + "name": "filename", "type": "str" }, { - "name": "path", - "type": "str" - }, - { - "name": "server", - "type": "[280]" - }, - { - "name": "debug", + "name": "aio", "default": null, - "type": "int" - }, - { - "name": "logfile", - "default": null, - "type": "str" + "type": "284" } ], "meta-type": "object" @@ -10940,12 +11089,7 @@ "name": "202", "members": [ { - "name": "file", - "type": "276" - }, - { - "name": "key-secret", - "default": null, + "name": "filename", "type": "str" } ], @@ -10954,17 +11098,25 @@ { "name": "203", "members": [ + { + "name": "volume", + "type": "str" + }, + { + "name": "path", + "type": "str" + }, { "name": "server", - "type": "219" + "type": "[285]" }, { - "name": "export", + "name": "debug", "default": null, - "type": "str" + "type": "int" }, { - "name": "tls-creds", + "name": "logfile", "default": null, "type": "str" } @@ -10975,9 +11127,92 @@ "name": "204", "members": [ { - "name": "server", + "name": "transport", + "type": "286" + }, + { + "name": "portal", + "type": "str" + }, + { + "name": "target", + "type": "str" + }, + { + "name": "lun", + "default": null, + "type": "int" + }, + { + "name": "user", + "default": null, + "type": "str" + }, + { + "name": "password-secret", + "default": null, + "type": "str" + }, + { + "name": "initiator-name", + "default": null, + "type": "str" + }, + { + "name": "header-digest", + "default": null, + "type": "287" + }, + { + "name": "timeout", + "default": null, + "type": "int" + } + ], + "meta-type": "object" + }, + { + "name": "205", + "members": [ + { + "name": "file", "type": "281" }, + { + "name": "key-secret", + "default": null, + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "206", + "members": [ + { + "name": "server", + "type": "224" + }, + { + "name": "export", + "default": null, + "type": "str" + }, + { + "name": "tls-creds", + "default": null, + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "207", + "members": [ + { + "name": "server", + "type": "288" + }, { "name": "path", "type": "str" @@ -11016,7 +11251,7 @@ "meta-type": "object" }, { - "name": "205", + "name": "208", "members": [ { "name": "size", @@ -11032,16 +11267,16 @@ "meta-type": "object" }, { - "name": "206", + "name": "209", "members": [ { "name": "file", - "type": "276" + "type": "281" }, { "name": "backing", "default": null, - "type": "276" + "type": "281" }, { "name": "lazy-refcounts", @@ -11066,7 +11301,7 @@ { "name": "overlap-check", "default": null, - "type": "282" + "type": "289" }, { "name": "cache-size", @@ -11092,22 +11327,22 @@ "meta-type": "object" }, { - "name": "207", + "name": "210", "members": [ { "name": "file", - "type": "276" + "type": "281" }, { "name": "backing", "default": null, - "type": "276" + "type": "281" } ], "meta-type": "object" }, { - "name": "208", + "name": "211", "members": [ { "name": "blkverify", @@ -11116,7 +11351,7 @@ }, { "name": "children", - "type": "[276]" + "type": "[281]" }, { "name": "vote-threshold", @@ -11130,71 +11365,139 @@ { "name": "read-pattern", "default": null, - "type": "283" - } - ], - "meta-type": "object" - }, - { - "name": "209", - "members": [ - { - "name": "file", - "type": "276" - }, - { - "name": "offset", - "default": null, - "type": "int" - }, - { - "name": "size", - "default": null, - "type": "int" - } - ], - "meta-type": "object" - }, - { - "name": "210", - "members": [ - { - "name": "file", - "type": "276" - }, - { - "name": "mode", - "type": "284" - }, - { - "name": "top-id", - "default": null, - "type": "str" - } - ], - "meta-type": "object" - }, - { - "name": "211", - "members": [ - { - "name": "server", - "type": "285" - }, - { - "name": "path", - "type": "str" - }, - { - "name": "user", - "default": null, - "type": "str" + "type": "290" } ], "meta-type": "object" }, { "name": "212", + "members": [ + { + "name": "file", + "type": "281" + }, + { + "name": "offset", + "default": null, + "type": "int" + }, + { + "name": "size", + "default": null, + "type": "int" + } + ], + "meta-type": "object" + }, + { + "name": "213", + "members": [ + { + "name": "pool", + "type": "str" + }, + { + "name": "image", + "type": "str" + }, + { + "name": "conf", + "default": null, + "type": "str" + }, + { + "name": "snapshot", + "default": null, + "type": "str" + }, + { + "name": "user", + "default": null, + "type": "str" + }, + { + "name": "server", + "default": null, + "type": "[291]" + }, + { + "name": "auth-supported", + "default": null, + "type": "[292]" + }, + { + "name": "password-secret", + "default": null, + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "214", + "members": [ + { + "name": "file", + "type": "281" + }, + { + "name": "mode", + "type": "293" + }, + { + "name": "top-id", + "default": null, + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "215", + "members": [ + { + "name": "addr", + "type": "285" + }, + { + "name": "vdi", + "type": "str" + }, + { + "name": "snap-id", + "default": null, + "type": "int" + }, + { + "name": "tag", + "default": null, + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "216", + "members": [ + { + "name": "server", + "type": "291" + }, + { + "name": "path", + "type": "str" + }, + { + "name": "user", + "default": null, + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "217", "members": [ { "name": "dir", @@ -11224,7 +11527,7 @@ "meta-type": "object" }, { - "name": "213", + "name": "218", "meta-type": "enum", "values": [ "top", @@ -11234,7 +11537,7 @@ ] }, { - "name": "214", + "name": "219", "meta-type": "enum", "values": [ "retain", @@ -11243,7 +11546,7 @@ ] }, { - "name": "215", + "name": "220", "meta-type": "enum", "values": [ "existing", @@ -11251,96 +11554,100 @@ ] }, { - "name": "216", + "name": "221", "tag": "type", "variants": [ { "case": "file", - "type": "287" + "type": "295" }, { "case": "serial", - "type": "288" + "type": "296" }, { "case": "parallel", - "type": "288" + "type": "296" }, { "case": "pipe", - "type": "288" + "type": "296" }, { "case": "socket", - "type": "289" + "type": "297" }, { "case": "udp", - "type": "290" + "type": "298" }, { "case": "pty", - "type": "291" + "type": "299" }, { "case": "null", - "type": "291" + "type": "299" }, { "case": "mux", - "type": "292" + "type": "300" }, { "case": "msmouse", - "type": "291" + "type": "299" + }, + { + "case": "wctablet", + "type": "299" }, { "case": "braille", - "type": "291" + "type": "299" }, { "case": "testdev", - "type": "291" + "type": "299" }, { "case": "stdio", - "type": "293" + "type": "301" }, { "case": "console", - "type": "291" + "type": "299" }, { "case": "spicevmc", - "type": "294" + "type": "302" }, { "case": "spiceport", - "type": "295" + "type": "303" }, { "case": "vc", - "type": "296" + "type": "304" }, { "case": "ringbuf", - "type": "297" + "type": "305" }, { "case": "memory", - "type": "297" + "type": "305" } ], "members": [ { "name": "type", - "type": "286" + "type": "294" } ], "meta-type": "object" }, { - "name": "217", + "name": "222", "meta-type": "enum", "values": [ "elf", @@ -11350,35 +11657,35 @@ ] }, { - "name": "[218]", - "element-type": "218", + "name": "[223]", + "element-type": "223", "meta-type": "array" }, { - "name": "218", + "name": "223", "tag": "type", "variants": [ { "case": "key", - "type": "299" + "type": "307" }, { "case": "btn", - "type": "300" + "type": "308" }, { "case": "rel", - "type": "301" + "type": "309" }, { "case": "abs", - "type": "301" + "type": "309" } ], "members": [ { "name": "type", - "type": "298" + "type": "306" } ], "meta-type": "object" @@ -11389,36 +11696,36 @@ "meta-type": "builtin" }, { - "name": "219", + "name": "224", "tag": "type", "variants": [ { "case": "inet", - "type": "303" + "type": "311" }, { "case": "unix", - "type": "304" + "type": "312" }, { "case": "vsock", - "type": "305" + "type": "313" }, { "case": "fd", - "type": "306" + "type": "314" } ], "members": [ { "name": "type", - "type": "302" + "type": "310" } ], "meta-type": "object" }, { - "name": "220", + "name": "225", "meta-type": "enum", "values": [ "DIMM", @@ -11426,7 +11733,7 @@ ] }, { - "name": "221", + "name": "226", "meta-type": "enum", "values": [ "ok", @@ -11435,12 +11742,12 @@ ] }, { - "name": "[222]", - "element-type": "222", + "name": "[227]", + "element-type": "227", "meta-type": "array" }, { - "name": "222", + "name": "227", "members": [ { "name": "name", @@ -11457,13 +11764,13 @@ }, { "name": "status", - "type": "307" + "type": "315" } ], "meta-type": "object" }, { - "name": "223", + "name": "228", "members": [ { "name": "rd_bytes", @@ -11548,18 +11855,18 @@ }, { "name": "timed_stats", - "type": "[308]" + "type": "[316]" } ], "meta-type": "object" }, { - "name": "[224]", - "element-type": "224", + "name": "[229]", + "element-type": "229", "meta-type": "array" }, { - "name": "224", + "name": "229", "members": [ { "name": "name", @@ -11567,7 +11874,7 @@ }, { "name": "type", - "type": "309" + "type": "317" }, { "name": "help", @@ -11588,7 +11895,7 @@ "meta-type": "array" }, { - "name": "225", + "name": "230", "members": [ { "name": "name", @@ -11603,7 +11910,7 @@ "meta-type": "object" }, { - "name": "226", + "name": "231", "meta-type": "enum", "values": [ "incompatible", @@ -11613,7 +11920,7 @@ ] }, { - "name": "227", + "name": "232", "meta-type": "enum", "values": [ "static", @@ -11621,7 +11928,7 @@ ] }, { - "name": "228", + "name": "233", "meta-type": "enum", "values": [ "x86", @@ -11632,103 +11939,103 @@ "other" ] }, - { - "name": "229", - "members": [ - { - "name": "pc", - "type": "int" - } - ], - "meta-type": "object" - }, - { - "name": "230", - "members": [ - { - "name": "pc", - "type": "int" - }, - { - "name": "npc", - "type": "int" - } - ], - "meta-type": "object" - }, - { - "name": "231", - "members": [ - { - "name": "nip", - "type": "int" - } - ], - "meta-type": "object" - }, - { - "name": "232", - "members": [ - { - "name": "PC", - "type": "int" - } - ], - "meta-type": "object" - }, - { - "name": "233", - "members": [ - { - "name": "PC", - "type": "int" - } - ], - "meta-type": "object" - }, { "name": "234", "members": [ + { + "name": "pc", + "type": "int" + } ], "meta-type": "object" }, { "name": "235", - "meta-type": "enum", - "values": [ - "none", - "active", - "completed", - "failed" - ] - }, - { - "name": "[217]", - "element-type": "217", - "meta-type": "array" - }, - { - "name": "[236]", - "element-type": "236", - "meta-type": "array" + "members": [ + { + "name": "pc", + "type": "int" + }, + { + "name": "npc", + "type": "int" + } + ], + "meta-type": "object" }, { "name": "236", "members": [ { - "name": "fd", + "name": "nip", "type": "int" - }, - { - "name": "opaque", - "default": null, - "type": "str" } ], "meta-type": "object" }, { "name": "237", + "members": [ + { + "name": "PC", + "type": "int" + } + ], + "meta-type": "object" + }, + { + "name": "238", + "members": [ + { + "name": "PC", + "type": "int" + } + ], + "meta-type": "object" + }, + { + "name": "239", + "members": [ + ], + "meta-type": "object" + }, + { + "name": "240", + "meta-type": "enum", + "values": [ + "none", + "active", + "completed", + "failed" + ] + }, + { + "name": "[222]", + "element-type": "222", + "meta-type": "array" + }, + { + "name": "[241]", + "element-type": "241", + "meta-type": "array" + }, + { + "name": "241", + "members": [ + { + "name": "fd", + "type": "int" + }, + { + "name": "opaque", + "default": null, + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "242", "members": [ { "name": "node-id", @@ -11759,7 +12066,7 @@ "meta-type": "array" }, { - "name": "238", + "name": "243", "meta-type": "enum", "values": [ "default", @@ -11769,24 +12076,24 @@ ] }, { - "name": "239", + "name": "244", "meta-type": "enum", "values": [ "dimm" ] }, { - "name": "240", + "name": "245", "members": [ { "name": "data", - "type": "310" + "type": "318" } ], "meta-type": "object" }, { - "name": "241", + "name": "246", "members": [ { "name": "transferred", @@ -11836,7 +12143,7 @@ "meta-type": "object" }, { - "name": "242", + "name": "247", "members": [ { "name": "cache-size", @@ -11866,7 +12173,7 @@ "meta-type": "object" }, { - "name": "243", + "name": "248", "meta-type": "enum", "values": [ "xbzrle", @@ -11881,7 +12188,7 @@ ] }, { - "name": "244", + "name": "249", "members": [ { "name": "filename", @@ -11943,18 +12250,18 @@ { "name": "backing-image", "default": null, - "type": "244" + "type": "249" }, { "name": "format-specific", "default": null, - "type": "311" + "type": "319" } ], "meta-type": "object" }, { - "name": "245", + "name": "250", "members": [ { "name": "writeback", @@ -11972,12 +12279,12 @@ "meta-type": "object" }, { - "name": "[246]", - "element-type": "246", + "name": "[251]", + "element-type": "251", "meta-type": "array" }, { - "name": "246", + "name": "251", "members": [ { "name": "bus", @@ -11993,11 +12300,11 @@ }, { "name": "class_info", - "type": "312" + "type": "320" }, { "name": "id", - "type": "313" + "type": "321" }, { "name": "irq", @@ -12011,17 +12318,17 @@ { "name": "pci_bridge", "default": null, - "type": "314" + "type": "322" }, { "name": "regions", - "type": "[315]" + "type": "[323]" } ], "meta-type": "object" }, { - "name": "247", + "name": "252", "meta-type": "enum", "values": [ "builtin", @@ -12034,17 +12341,17 @@ ] }, { - "name": "248", + "name": "253", "members": [ { "name": "json-type", - "type": "316" + "type": "324" } ], "meta-type": "object" }, { - "name": "249", + "name": "254", "members": [ { "name": "values", @@ -12054,7 +12361,7 @@ "meta-type": "object" }, { - "name": "250", + "name": "255", "members": [ { "name": "element-type", @@ -12064,11 +12371,11 @@ "meta-type": "object" }, { - "name": "251", + "name": "256", "members": [ { "name": "members", - "type": "[317]" + "type": "[325]" }, { "name": "tag", @@ -12078,23 +12385,23 @@ { "name": "variants", "default": null, - "type": "[318]" + "type": "[326]" } ], "meta-type": "object" }, { - "name": "252", + "name": "257", "members": [ { "name": "members", - "type": "[319]" + "type": "[327]" } ], "meta-type": "object" }, { - "name": "253", + "name": "258", "members": [ { "name": "arg-type", @@ -12108,7 +12415,7 @@ "meta-type": "object" }, { - "name": "254", + "name": "259", "members": [ { "name": "arg-type", @@ -12118,7 +12425,7 @@ "meta-type": "object" }, { - "name": "255", + "name": "260", "members": [ { "name": "priority", @@ -12177,7 +12484,7 @@ "meta-type": "object" }, { - "name": "256", + "name": "261", "members": [ { "name": "in-pport", @@ -12218,7 +12525,7 @@ "meta-type": "object" }, { - "name": "257", + "name": "262", "members": [ { "name": "goto-tbl", @@ -12254,7 +12561,7 @@ "meta-type": "object" }, { - "name": "258", + "name": "263", "meta-type": "enum", "values": [ "half", @@ -12262,7 +12569,7 @@ ] }, { - "name": "259", + "name": "264", "meta-type": "enum", "values": [ "off", @@ -12270,7 +12577,7 @@ ] }, { - "name": "260", + "name": "265", "meta-type": "enum", "values": [ "normal", @@ -12279,7 +12586,7 @@ ] }, { - "name": "261", + "name": "266", "meta-type": "enum", "values": [ "client", @@ -12288,12 +12595,12 @@ ] }, { - "name": "[185]", - "element-type": "185", + "name": "[188]", + "element-type": "188", "meta-type": "array" }, { - "name": "262", + "name": "267", "meta-type": "enum", "values": [ "debug", @@ -12315,24 +12622,24 @@ ] }, { - "name": "263", + "name": "268", "tag": "type", "variants": [ { "case": "passthrough", - "type": "321" + "type": "329" } ], "members": [ { "name": "type", - "type": "320" + "type": "328" } ], "meta-type": "object" }, { - "name": "264", + "name": "269", "members": [ { "name": "major", @@ -12350,7 +12657,7 @@ "meta-type": "object" }, { - "name": "265", + "name": "270", "meta-type": "enum", "values": [ "ipv4", @@ -12361,17 +12668,17 @@ ] }, { - "name": "[188]", - "element-type": "188", + "name": "[191]", + "element-type": "191", "meta-type": "array" }, { - "name": "[266]", - "element-type": "266", + "name": "[271]", + "element-type": "271", "meta-type": "array" }, { - "name": "266", + "name": "271", "members": [ { "name": "host", @@ -12383,7 +12690,7 @@ }, { "name": "family", - "type": "265" + "type": "270" }, { "name": "websocket", @@ -12391,18 +12698,18 @@ }, { "name": "auth", - "type": "267" + "type": "272" }, { "name": "vencrypt", "default": null, - "type": "268" + "type": "273" } ], "meta-type": "object" }, { - "name": "267", + "name": "272", "meta-type": "enum", "values": [ "none", @@ -12417,7 +12724,7 @@ ] }, { - "name": "268", + "name": "273", "meta-type": "enum", "values": [ "plain", @@ -12432,7 +12739,7 @@ ] }, { - "name": "269", + "name": "274", "meta-type": "enum", "values": [ "utf8", @@ -12440,33 +12747,33 @@ ] }, { - "name": "[270]", - "element-type": "270", + "name": "[275]", + "element-type": "275", "meta-type": "array" }, { - "name": "270", + "name": "275", "tag": "type", "variants": [ { "case": "number", - "type": "323" + "type": "331" }, { "case": "qcode", - "type": "324" + "type": "332" } ], "members": [ { "name": "type", - "type": "322" + "type": "330" } ], "meta-type": "object" }, { - "name": "271", + "name": "276", "meta-type": "enum", "values": [ "unavailable", @@ -12475,85 +12782,101 @@ ] }, { - "name": "[272]", - "element-type": "272", + "name": "[277]", + "element-type": "277", "meta-type": "array" }, { - "name": "272", + "name": "277", "tag": "type", "variants": [ { "case": "abort", - "type": "326" + "type": "334" }, { "case": "block-dirty-bitmap-add", - "type": "327" + "type": "335" }, { "case": "block-dirty-bitmap-clear", - "type": "328" + "type": "336" }, { "case": "blockdev-backup", - "type": "329" + "type": "337" }, { "case": "blockdev-snapshot", - "type": "330" + "type": "338" }, { "case": "blockdev-snapshot-internal-sync", - "type": "331" + "type": "339" }, { "case": "blockdev-snapshot-sync", - "type": "332" + "type": "340" }, { "case": "drive-backup", + "type": "341" + } + ], + "members": [ + { + "name": "type", "type": "333" } ], - "members": [ - { - "name": "type", - "type": "325" - } - ], "meta-type": "object" }, { - "name": "273", + "name": "278", "members": [ { "name": "completion-mode", "default": null, - "type": "334" + "type": "342" } ], "meta-type": "object" }, { - "name": "274", + "name": "279", "meta-type": "enum", "values": [ "hyper-v" ] }, { - "name": "275", + "name": "280", "members": [ { - "name": "data", - "type": "335" + "name": "arg1", + "type": "int" + }, + { + "name": "arg2", + "type": "int" + }, + { + "name": "arg3", + "type": "int" + }, + { + "name": "arg4", + "type": "int" + }, + { + "name": "arg5", + "type": "int" } ], "meta-type": "object" }, { - "name": "276", + "name": "281", "members": [ { "type": "46" @@ -12565,16 +12888,16 @@ "meta-type": "alternate" }, { - "name": "[277]", - "element-type": "277", + "name": "[282]", + "element-type": "282", "meta-type": "array" }, { - "name": "277", + "name": "282", "members": [ { "name": "event", - "type": "336" + "type": "343" }, { "name": "state", @@ -12605,16 +12928,16 @@ "meta-type": "object" }, { - "name": "[278]", - "element-type": "278", + "name": "[283]", + "element-type": "283", "meta-type": "array" }, { - "name": "278", + "name": "283", "members": [ { "name": "event", - "type": "336" + "type": "343" }, { "name": "state", @@ -12629,7 +12952,7 @@ "meta-type": "object" }, { - "name": "279", + "name": "284", "meta-type": "enum", "values": [ "threads", @@ -12637,37 +12960,55 @@ ] }, { - "name": "[280]", - "element-type": "280", + "name": "[285]", + "element-type": "285", "meta-type": "array" }, { - "name": "280", + "name": "285", "tag": "type", "variants": [ { "case": "unix", - "type": "338" + "type": "345" }, { - "case": "tcp", - "type": "285" + "case": "inet", + "type": "291" } ], "members": [ { "name": "type", - "type": "337" + "type": "344" } ], "meta-type": "object" }, { - "name": "281", + "name": "286", + "meta-type": "enum", + "values": [ + "tcp", + "iser" + ] + }, + { + "name": "287", + "meta-type": "enum", + "values": [ + "crc32c", + "none", + "crc32c-none", + "none-crc32c" + ] + }, + { + "name": "288", "members": [ { "name": "type", - "type": "339" + "type": "346" }, { "name": "host", @@ -12677,24 +13018,24 @@ "meta-type": "object" }, { - "name": "282", + "name": "289", "members": [ { - "type": "340" + "type": "347" }, { - "type": "341" + "type": "348" } ], "meta-type": "alternate" }, { - "name": "[276]", - "element-type": "276", + "name": "[281]", + "element-type": "281", "meta-type": "array" }, { - "name": "283", + "name": "290", "meta-type": "enum", "values": [ "quorum", @@ -12702,7 +13043,61 @@ ] }, { - "name": "284", + "name": "[291]", + "element-type": "291", + "meta-type": "array" + }, + { + "name": "291", + "members": [ + { + "name": "host", + "type": "str" + }, + { + "name": "port", + "type": "str" + }, + { + "name": "numeric", + "default": null, + "type": "bool" + }, + { + "name": "to", + "default": null, + "type": "int" + }, + { + "name": "ipv4", + "default": null, + "type": "bool" + }, + { + "name": "ipv6", + "default": null, + "type": "bool" + } + ], + "meta-type": "object" + }, + { + "name": "[292]", + "element-type": "292", + "meta-type": "array" + }, + { + "name": "292", + "members": [ + { + "name": "auth", + "type": "349" + } + ], + "meta-type": "object" + }, + { + "name": "293", "meta-type": "enum", "values": [ "primary", @@ -12710,41 +13105,7 @@ ] }, { - "name": "285", - "members": [ - { - "name": "host", - "type": "str" - }, - { - "name": "port", - "type": "str" - }, - { - "name": "numeric", - "default": null, - "type": "bool" - }, - { - "name": "to", - "default": null, - "type": "int" - }, - { - "name": "ipv4", - "default": null, - "type": "bool" - }, - { - "name": "ipv6", - "default": null, - "type": "bool" - } - ], - "meta-type": "object" - }, - { - "name": "286", + "name": "294", "meta-type": "enum", "values": [ "file", @@ -12757,6 +13118,7 @@ "null", "mux", "msmouse", + "wctablet", "braille", "testdev", "stdio", @@ -12768,86 +13130,6 @@ "memory" ] }, - { - "name": "287", - "members": [ - { - "name": "data", - "type": "342" - } - ], - "meta-type": "object" - }, - { - "name": "288", - "members": [ - { - "name": "data", - "type": "343" - } - ], - "meta-type": "object" - }, - { - "name": "289", - "members": [ - { - "name": "data", - "type": "344" - } - ], - "meta-type": "object" - }, - { - "name": "290", - "members": [ - { - "name": "data", - "type": "345" - } - ], - "meta-type": "object" - }, - { - "name": "291", - "members": [ - { - "name": "data", - "type": "346" - } - ], - "meta-type": "object" - }, - { - "name": "292", - "members": [ - { - "name": "data", - "type": "347" - } - ], - "meta-type": "object" - }, - { - "name": "293", - "members": [ - { - "name": "data", - "type": "348" - } - ], - "meta-type": "object" - }, - { - "name": "294", - "members": [ - { - "name": "data", - "type": "349" - } - ], - "meta-type": "object" - }, { "name": "295", "members": [ @@ -12880,16 +13162,6 @@ }, { "name": "298", - "meta-type": "enum", - "values": [ - "key", - "btn", - "rel", - "abs" - ] - }, - { - "name": "299", "members": [ { "name": "data", @@ -12899,7 +13171,7 @@ "meta-type": "object" }, { - "name": "300", + "name": "299", "members": [ { "name": "data", @@ -12909,7 +13181,7 @@ "meta-type": "object" }, { - "name": "301", + "name": "300", "members": [ { "name": "data", @@ -12918,22 +13190,32 @@ ], "meta-type": "object" }, + { + "name": "301", + "members": [ + { + "name": "data", + "type": "356" + } + ], + "meta-type": "object" + }, { "name": "302", - "meta-type": "enum", - "values": [ - "inet", - "unix", - "vsock", - "fd" - ] + "members": [ + { + "name": "data", + "type": "357" + } + ], + "meta-type": "object" }, { "name": "303", "members": [ { "name": "data", - "type": "285" + "type": "358" } ], "meta-type": "object" @@ -12943,7 +13225,7 @@ "members": [ { "name": "data", - "type": "338" + "type": "359" } ], "meta-type": "object" @@ -12953,37 +13235,117 @@ "members": [ { "name": "data", - "type": "356" + "type": "360" } ], "meta-type": "object" }, { "name": "306", - "members": [ - { - "name": "data", - "type": "357" - } - ], - "meta-type": "object" + "meta-type": "enum", + "values": [ + "key", + "btn", + "rel", + "abs" + ] }, { "name": "307", - "meta-type": "enum", - "values": [ - "active", - "disabled", - "frozen" - ] - }, - { - "name": "[308]", - "element-type": "308", - "meta-type": "array" + "members": [ + { + "name": "data", + "type": "361" + } + ], + "meta-type": "object" }, { "name": "308", + "members": [ + { + "name": "data", + "type": "362" + } + ], + "meta-type": "object" + }, + { + "name": "309", + "members": [ + { + "name": "data", + "type": "363" + } + ], + "meta-type": "object" + }, + { + "name": "310", + "meta-type": "enum", + "values": [ + "inet", + "unix", + "vsock", + "fd" + ] + }, + { + "name": "311", + "members": [ + { + "name": "data", + "type": "291" + } + ], + "meta-type": "object" + }, + { + "name": "312", + "members": [ + { + "name": "data", + "type": "345" + } + ], + "meta-type": "object" + }, + { + "name": "313", + "members": [ + { + "name": "data", + "type": "364" + } + ], + "meta-type": "object" + }, + { + "name": "314", + "members": [ + { + "name": "data", + "type": "365" + } + ], + "meta-type": "object" + }, + { + "name": "315", + "meta-type": "enum", + "values": [ + "active", + "disabled", + "frozen" + ] + }, + { + "name": "[316]", + "element-type": "316", + "meta-type": "array" + }, + { + "name": "316", "members": [ { "name": "interval_length", @@ -13037,7 +13399,7 @@ "meta-type": "object" }, { - "name": "309", + "name": "317", "meta-type": "enum", "values": [ "string", @@ -13047,7 +13409,7 @@ ] }, { - "name": "310", + "name": "318", "members": [ { "name": "id", @@ -13091,32 +13453,32 @@ "meta-type": "array" }, { - "name": "311", + "name": "319", "tag": "type", "variants": [ { "case": "qcow2", - "type": "359" + "type": "367" }, { "case": "vmdk", - "type": "360" + "type": "368" }, { "case": "luks", - "type": "361" + "type": "369" } ], "members": [ { "name": "type", - "type": "358" + "type": "366" } ], "meta-type": "object" }, { - "name": "312", + "name": "320", "members": [ { "name": "desc", @@ -13131,7 +13493,7 @@ "meta-type": "object" }, { - "name": "313", + "name": "321", "members": [ { "name": "device", @@ -13145,27 +13507,27 @@ "meta-type": "object" }, { - "name": "314", + "name": "322", "members": [ { "name": "bus", - "type": "362" + "type": "370" }, { "name": "devices", "default": null, - "type": "[246]" + "type": "[251]" } ], "meta-type": "object" }, { - "name": "[315]", - "element-type": "315", + "name": "[323]", + "element-type": "323", "meta-type": "array" }, { - "name": "315", + "name": "323", "members": [ { "name": "bar", @@ -13197,7 +13559,7 @@ "meta-type": "object" }, { - "name": "316", + "name": "324", "meta-type": "enum", "values": [ "string", @@ -13211,12 +13573,12 @@ ] }, { - "name": "[317]", - "element-type": "317", + "name": "[325]", + "element-type": "325", "meta-type": "array" }, { - "name": "317", + "name": "325", "members": [ { "name": "name", @@ -13235,12 +13597,12 @@ "meta-type": "object" }, { - "name": "[318]", - "element-type": "318", + "name": "[326]", + "element-type": "326", "meta-type": "array" }, { - "name": "318", + "name": "326", "members": [ { "name": "case", @@ -13254,12 +13616,12 @@ "meta-type": "object" }, { - "name": "[319]", - "element-type": "319", + "name": "[327]", + "element-type": "327", "meta-type": "array" }, { - "name": "319", + "name": "327", "members": [ { "name": "type", @@ -13269,24 +13631,24 @@ "meta-type": "object" }, { - "name": "320", + "name": "328", "meta-type": "enum", "values": [ "passthrough" ] }, { - "name": "321", + "name": "329", "members": [ { "name": "data", - "type": "363" + "type": "371" } ], "meta-type": "object" }, { - "name": "322", + "name": "330", "meta-type": "enum", "values": [ "number", @@ -13294,7 +13656,7 @@ ] }, { - "name": "323", + "name": "331", "members": [ { "name": "data", @@ -13304,17 +13666,17 @@ "meta-type": "object" }, { - "name": "324", + "name": "332", "members": [ { "name": "data", - "type": "364" + "type": "372" } ], "meta-type": "object" }, { - "name": "325", + "name": "333", "meta-type": "enum", "values": [ "abort", @@ -13328,17 +13690,17 @@ ] }, { - "name": "326", + "name": "334", "members": [ { "name": "data", - "type": "365" + "type": "373" } ], "meta-type": "object" }, { - "name": "327", + "name": "335", "members": [ { "name": "data", @@ -13348,7 +13710,7 @@ "meta-type": "object" }, { - "name": "328", + "name": "336", "members": [ { "name": "data", @@ -13358,7 +13720,7 @@ "meta-type": "object" }, { - "name": "329", + "name": "337", "members": [ { "name": "data", @@ -13368,7 +13730,7 @@ "meta-type": "object" }, { - "name": "330", + "name": "338", "members": [ { "name": "data", @@ -13378,7 +13740,7 @@ "meta-type": "object" }, { - "name": "331", + "name": "339", "members": [ { "name": "data", @@ -13388,7 +13750,7 @@ "meta-type": "object" }, { - "name": "332", + "name": "340", "members": [ { "name": "data", @@ -13398,7 +13760,7 @@ "meta-type": "object" }, { - "name": "333", + "name": "341", "members": [ { "name": "data", @@ -13408,7 +13770,7 @@ "meta-type": "object" }, { - "name": "334", + "name": "342", "meta-type": "enum", "values": [ "individual", @@ -13416,33 +13778,7 @@ ] }, { - "name": "335", - "members": [ - { - "name": "arg1", - "type": "int" - }, - { - "name": "arg2", - "type": "int" - }, - { - "name": "arg3", - "type": "int" - }, - { - "name": "arg4", - "type": "int" - }, - { - "name": "arg5", - "type": "int" - } - ], - "meta-type": "object" - }, - { - "name": "336", + "name": "343", "meta-type": "enum", "values": [ "l1_update", @@ -13491,15 +13827,15 @@ ] }, { - "name": "337", + "name": "344", "meta-type": "enum", "values": [ "unix", - "tcp" + "inet" ] }, { - "name": "338", + "name": "345", "members": [ { "name": "path", @@ -13509,19 +13845,19 @@ "meta-type": "object" }, { - "name": "339", + "name": "346", "meta-type": "enum", "values": [ "inet" ] }, { - "name": "340", + "name": "347", "members": [ { "name": "template", "default": null, - "type": "341" + "type": "348" }, { "name": "main-header", @@ -13567,7 +13903,7 @@ "meta-type": "object" }, { - "name": "341", + "name": "348", "meta-type": "enum", "values": [ "none", @@ -13576,207 +13912,13 @@ "all" ] }, - { - "name": "342", - "members": [ - { - "name": "logfile", - "default": null, - "type": "str" - }, - { - "name": "logappend", - "default": null, - "type": "bool" - }, - { - "name": "in", - "default": null, - "type": "str" - }, - { - "name": "out", - "type": "str" - }, - { - "name": "append", - "default": null, - "type": "bool" - } - ], - "meta-type": "object" - }, - { - "name": "343", - "members": [ - { - "name": "logfile", - "default": null, - "type": "str" - }, - { - "name": "logappend", - "default": null, - "type": "bool" - }, - { - "name": "device", - "type": "str" - } - ], - "meta-type": "object" - }, - { - "name": "344", - "members": [ - { - "name": "logfile", - "default": null, - "type": "str" - }, - { - "name": "logappend", - "default": null, - "type": "bool" - }, - { - "name": "addr", - "type": "219" - }, - { - "name": "tls-creds", - "default": null, - "type": "str" - }, - { - "name": "server", - "default": null, - "type": "bool" - }, - { - "name": "wait", - "default": null, - "type": "bool" - }, - { - "name": "nodelay", - "default": null, - "type": "bool" - }, - { - "name": "telnet", - "default": null, - "type": "bool" - }, - { - "name": "reconnect", - "default": null, - "type": "int" - } - ], - "meta-type": "object" - }, - { - "name": "345", - "members": [ - { - "name": "logfile", - "default": null, - "type": "str" - }, - { - "name": "logappend", - "default": null, - "type": "bool" - }, - { - "name": "remote", - "type": "219" - }, - { - "name": "local", - "default": null, - "type": "219" - } - ], - "meta-type": "object" - }, - { - "name": "346", - "members": [ - { - "name": "logfile", - "default": null, - "type": "str" - }, - { - "name": "logappend", - "default": null, - "type": "bool" - } - ], - "meta-type": "object" - }, - { - "name": "347", - "members": [ - { - "name": "logfile", - "default": null, - "type": "str" - }, - { - "name": "logappend", - "default": null, - "type": "bool" - }, - { - "name": "chardev", - "type": "str" - } - ], - "meta-type": "object" - }, - { - "name": "348", - "members": [ - { - "name": "logfile", - "default": null, - "type": "str" - }, - { - "name": "logappend", - "default": null, - "type": "bool" - }, - { - "name": "signal", - "default": null, - "type": "bool" - } - ], - "meta-type": "object" - }, { "name": "349", - "members": [ - { - "name": "logfile", - "default": null, - "type": "str" - }, - { - "name": "logappend", - "default": null, - "type": "bool" - }, - { - "name": "type", - "type": "str" - } - ], - "meta-type": "object" + "meta-type": "enum", + "values": [ + "cephx", + "none" + ] }, { "name": "350", @@ -13792,8 +13934,18 @@ "type": "bool" }, { - "name": "fqdn", + "name": "in", + "default": null, "type": "str" + }, + { + "name": "out", + "type": "str" + }, + { + "name": "append", + "default": null, + "type": "bool" } ], "meta-type": "object" @@ -13812,24 +13964,8 @@ "type": "bool" }, { - "name": "width", - "default": null, - "type": "int" - }, - { - "name": "height", - "default": null, - "type": "int" - }, - { - "name": "cols", - "default": null, - "type": "int" - }, - { - "name": "rows", - "default": null, - "type": "int" + "name": "device", + "type": "str" } ], "meta-type": "object" @@ -13848,7 +13984,36 @@ "type": "bool" }, { - "name": "size", + "name": "addr", + "type": "224" + }, + { + "name": "tls-creds", + "default": null, + "type": "str" + }, + { + "name": "server", + "default": null, + "type": "bool" + }, + { + "name": "wait", + "default": null, + "type": "bool" + }, + { + "name": "nodelay", + "default": null, + "type": "bool" + }, + { + "name": "telnet", + "default": null, + "type": "bool" + }, + { + "name": "reconnect", "default": null, "type": "int" } @@ -13859,12 +14024,23 @@ "name": "353", "members": [ { - "name": "key", - "type": "270" + "name": "logfile", + "default": null, + "type": "str" }, { - "name": "down", + "name": "logappend", + "default": null, "type": "bool" + }, + { + "name": "remote", + "type": "224" + }, + { + "name": "local", + "default": null, + "type": "224" } ], "meta-type": "object" @@ -13873,11 +14049,13 @@ "name": "354", "members": [ { - "name": "button", - "type": "366" + "name": "logfile", + "default": null, + "type": "str" }, { - "name": "down", + "name": "logappend", + "default": null, "type": "bool" } ], @@ -13887,12 +14065,18 @@ "name": "355", "members": [ { - "name": "axis", - "type": "367" + "name": "logfile", + "default": null, + "type": "str" }, { - "name": "value", - "type": "int" + "name": "logappend", + "default": null, + "type": "bool" + }, + { + "name": "chardev", + "type": "str" } ], "meta-type": "object" @@ -13901,12 +14085,19 @@ "name": "356", "members": [ { - "name": "cid", + "name": "logfile", + "default": null, "type": "str" }, { - "name": "port", - "type": "str" + "name": "logappend", + "default": null, + "type": "bool" + }, + { + "name": "signal", + "default": null, + "type": "bool" } ], "meta-type": "object" @@ -13915,7 +14106,17 @@ "name": "357", "members": [ { - "name": "str", + "name": "logfile", + "default": null, + "type": "str" + }, + { + "name": "logappend", + "default": null, + "type": "bool" + }, + { + "name": "type", "type": "str" } ], @@ -13923,19 +14124,56 @@ }, { "name": "358", - "meta-type": "enum", - "values": [ - "qcow2", - "vmdk", - "luks" - ] + "members": [ + { + "name": "logfile", + "default": null, + "type": "str" + }, + { + "name": "logappend", + "default": null, + "type": "bool" + }, + { + "name": "fqdn", + "type": "str" + } + ], + "meta-type": "object" }, { "name": "359", "members": [ { - "name": "data", - "type": "368" + "name": "logfile", + "default": null, + "type": "str" + }, + { + "name": "logappend", + "default": null, + "type": "bool" + }, + { + "name": "width", + "default": null, + "type": "int" + }, + { + "name": "height", + "default": null, + "type": "int" + }, + { + "name": "cols", + "default": null, + "type": "int" + }, + { + "name": "rows", + "default": null, + "type": "int" } ], "meta-type": "object" @@ -13944,8 +14182,19 @@ "name": "360", "members": [ { - "name": "data", - "type": "369" + "name": "logfile", + "default": null, + "type": "str" + }, + { + "name": "logappend", + "default": null, + "type": "bool" + }, + { + "name": "size", + "default": null, + "type": "int" } ], "meta-type": "object" @@ -13954,14 +14203,109 @@ "name": "361", "members": [ { - "name": "data", - "type": "370" + "name": "key", + "type": "275" + }, + { + "name": "down", + "type": "bool" } ], "meta-type": "object" }, { "name": "362", + "members": [ + { + "name": "button", + "type": "374" + }, + { + "name": "down", + "type": "bool" + } + ], + "meta-type": "object" + }, + { + "name": "363", + "members": [ + { + "name": "axis", + "type": "375" + }, + { + "name": "value", + "type": "int" + } + ], + "meta-type": "object" + }, + { + "name": "364", + "members": [ + { + "name": "cid", + "type": "str" + }, + { + "name": "port", + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "365", + "members": [ + { + "name": "str", + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "366", + "meta-type": "enum", + "values": [ + "qcow2", + "vmdk", + "luks" + ] + }, + { + "name": "367", + "members": [ + { + "name": "data", + "type": "376" + } + ], + "meta-type": "object" + }, + { + "name": "368", + "members": [ + { + "name": "data", + "type": "377" + } + ], + "meta-type": "object" + }, + { + "name": "369", + "members": [ + { + "name": "data", + "type": "378" + } + ], + "meta-type": "object" + }, + { + "name": "370", "members": [ { "name": "number", @@ -13977,21 +14321,21 @@ }, { "name": "io_range", - "type": "371" + "type": "379" }, { "name": "memory_range", - "type": "371" + "type": "379" }, { "name": "prefetchable_range", - "type": "371" + "type": "379" } ], "meta-type": "object" }, { - "name": "363", + "name": "371", "members": [ { "name": "path", @@ -14007,7 +14351,7 @@ "meta-type": "object" }, { - "name": "364", + "name": "372", "meta-type": "enum", "values": [ "unmapped", @@ -14143,13 +14487,13 @@ ] }, { - "name": "365", + "name": "373", "members": [ ], "meta-type": "object" }, { - "name": "366", + "name": "374", "meta-type": "enum", "values": [ "left", @@ -14162,7 +14506,7 @@ ] }, { - "name": "367", + "name": "375", "meta-type": "enum", "values": [ "x", @@ -14170,7 +14514,7 @@ ] }, { - "name": "368", + "name": "376", "members": [ { "name": "compat", @@ -14194,7 +14538,7 @@ "meta-type": "object" }, { - "name": "369", + "name": "377", "members": [ { "name": "create-type", @@ -14210,34 +14554,34 @@ }, { "name": "extents", - "type": "[244]" + "type": "[249]" } ], "meta-type": "object" }, { - "name": "370", + "name": "378", "members": [ { "name": "cipher-alg", - "type": "372" + "type": "380" }, { "name": "cipher-mode", - "type": "373" + "type": "381" }, { "name": "ivgen-alg", - "type": "374" + "type": "382" }, { "name": "ivgen-hash-alg", "default": null, - "type": "375" + "type": "383" }, { "name": "hash-alg", - "type": "375" + "type": "383" }, { "name": "payload-offset", @@ -14253,13 +14597,13 @@ }, { "name": "slots", - "type": "[376]" + "type": "[384]" } ], "meta-type": "object" }, { - "name": "371", + "name": "379", "members": [ { "name": "base", @@ -14273,12 +14617,12 @@ "meta-type": "object" }, { - "name": "[244]", - "element-type": "244", + "name": "[249]", + "element-type": "249", "meta-type": "array" }, { - "name": "372", + "name": "380", "meta-type": "enum", "values": [ "aes-128", @@ -14296,7 +14640,7 @@ ] }, { - "name": "373", + "name": "381", "meta-type": "enum", "values": [ "ecb", @@ -14306,7 +14650,7 @@ ] }, { - "name": "374", + "name": "382", "meta-type": "enum", "values": [ "plain", @@ -14315,7 +14659,7 @@ ] }, { - "name": "375", + "name": "383", "meta-type": "enum", "values": [ "md5", @@ -14328,12 +14672,12 @@ ] }, { - "name": "[376]", - "element-type": "376", + "name": "[384]", + "element-type": "384", "meta-type": "array" }, { - "name": "376", + "name": "384", "members": [ { "name": "active", @@ -14521,7 +14865,7 @@ "rdseed": true, "avx512-4vnniw": false, "vme": true, - "vmx": true, + "vmx": false, "dtes64": false, "mtrr": true, "rdtscp": true, @@ -14738,6 +15082,7 @@ "hv-vpindex": false, "xlevel2": 0, "clflushopt": true, + "kvm-no-smi-migration": false, "monitor": false, "avx512er": false, "pmm-en": false, @@ -14760,7 +15105,7 @@ "rdseed": true, "avx512-4vnniw": false, "vme": true, - "vmx": true, + "vmx": false, "dtes64": false, "mtrr": true, "rdtscp": true, @@ -15508,6 +15853,7 @@ "hv-vpindex": false, "xlevel2": 0, "clflushopt": true, + "kvm-no-smi-migration": false, "monitor": true, "avx512er": false, "pmm-en": false, diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml index 334f8e74b..f55b1f827 100644 --- a/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml @@ -26,8 +26,6 @@ <flag name='hda-duplex'/> <flag name='drive-aio'/> <flag name='pci-bootindex'/> - <flag name='ccid-emulated'/> - <flag name='ccid-passthru'/> <flag name='chardev-spicevmc'/> <flag name='virtio-tx-alg'/> <flag name='pci-multifunction'/> @@ -202,9 +200,10 @@ <flag name='drive-iotune-group'/> <flag name='query-cpu-model-expansion'/> <flag name='virtio-net.host_mtu'/> - <version>2008050</version> + <flag name='spice-rendernode'/> + <version>2008090</version> <kvmVersion>0</kvmVersion> - <package> (v2.8.0-1961-g5b10b94bd5)</package> + <package> (v2.9.0-rc0-15-g1883ff34b5)</package> <arch>x86_64</arch> <hostCPU type='kvm' model='base'> <property name='phys-bits' type='number' value='0'/> @@ -401,6 +400,7 @@ <property name='hv-vpindex' type='boolean' value='false'/> <property name='xlevel2' type='number' value='0'/> <property name='clflushopt' type='boolean' value='true'/> + <property name='kvm-no-smi-migration' type='boolean' value='false'/> <property name='monitor' type='boolean' value='false'/> <property name='avx512er' type='boolean' value='false'/> <property name='pmm-en' type='boolean' value='false'/> @@ -423,7 +423,7 @@ <property name='rdseed' type='boolean' value='true'/> <property name='avx512-4vnniw' type='boolean' value='false'/> <property name='vme' type='boolean' value='true'/> - <property name='vmx' type='boolean' value='true'/> + <property name='vmx' type='boolean' value='false'/> <property name='dtes64' type='boolean' value='false'/> <property name='mtrr' type='boolean' value='true'/> <property name='rdtscp' type='boolean' value='true'/> @@ -632,6 +632,7 @@ <property name='hv-vpindex' type='boolean' value='false'/> <property name='xlevel2' type='number' value='0'/> <property name='clflushopt' type='boolean' value='true'/> + <property name='kvm-no-smi-migration' type='boolean' value='false'/> <property name='monitor' type='boolean' value='true'/> <property name='avx512er' type='boolean' value='false'/> <property name='pmm-en' type='boolean' value='false'/> -- 2.11.0

2 1

[libvirt] [PATCH] docs: Document NVDIMM
by Michal Privoznik 16 Mar '17

16 Mar '17

Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- docs/news.xml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 3500df714..59e954f88 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -17,6 +17,18 @@ The virt-host-validate tool now supports bhyve hypervisor </summary> </change> + <change> + <summary> + Introduce NVDIMM memory model + </summary> + <description> + NVDIMM is new type of memory introduced into QEMU 2.6. The idea is + that we have a Non-Volatile memory module that keeps the data + persistent across domain reboots and offers much faster data accesses + without causing VMEXITs. However, due to a bug in QEMU, this feature + is not enabled for QEMUs older than 2.9.0. + </description> + </change> </section> <section title="Improvements"> <change> -- 2.11.0

2 1

[libvirt] [PATCH] Report what TLS priority string we use for a session
by Daniel P. Berrange 16 Mar '17

16 Mar '17

Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- src/rpc/virnettlscontext.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/rpc/virnettlscontext.c b/src/rpc/virnettlscontext.c index 847d457..0d5928e 100644 --- a/src/rpc/virnettlscontext.c +++ b/src/rpc/virnettlscontext.c @@ -1208,6 +1208,7 @@ virNetTLSSessionPtr virNetTLSSessionNew(virNetTLSContextPtr ctxt, /* avoid calling all the priority functions, since the defaults * are adequate. */ + VIR_DEBUG("Setting priority string '%s'", ctxt->priority ? ctxt->priority : TLS_PRIORITY); if ((err = gnutls_priority_set_direct(sess->session, ctxt->priority ? ctxt->priority : TLS_PRIORITY, NULL)) != 0) { -- 2.9.3

2 2

[libvirt] [PATCH] remote: Make Upper limit on list of memory parameters to 64
by Nitesh Konkar 16 Mar '17

16 Mar '17

'virsh perf domain' errors out as the number of perf events now exceeds the previous memory parameter limit of 16. The fix is to set it to 64, as the upper limit on list of perf events, is also set to the same. Signed-off-by: Nitesh Konkar <nitkon12(a)linux.vnet.ibm.com> --- src/remote/remote_protocol.x | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x index abe63af..fd6f3af 100644 --- a/src/remote/remote_protocol.x +++ b/src/remote/remote_protocol.x @@ -101,7 +101,7 @@ const REMOTE_DOMAIN_SCHEDULER_PARAMETERS_MAX = 16; const REMOTE_DOMAIN_BLKIO_PARAMETERS_MAX = 16; /* Upper limit on list of memory parameters. */ -const REMOTE_DOMAIN_MEMORY_PARAMETERS_MAX = 16; +const REMOTE_DOMAIN_MEMORY_PARAMETERS_MAX = 64; /* Upper limit on list of blockio tuning parameters. */ const REMOTE_DOMAIN_BLOCK_IO_TUNE_PARAMETERS_MAX = 32; -- 1.9.3

2 1

[libvirt] [PATCH] Increase default file handle limits for daemons
by Daniel P. Berrange 16 Mar '17

16 Mar '17

Linux still defaults to a 1024 open file handle limit. This causes scalability problems for libvirtd / virtlockd / virtlogd on large hosts which might want > 1024 guest to be running. In fact if each guest needs > 1 FD, we can't even get to 500 guests. This is not good enough when we see machines with 100's of physical cores and TBs of RAM. In comparison to other memory requirements of libvirtd & related daemons, the resource usage associated with open file handles is essentially line noise. It is thus reasonable to increase the limits unconditionally for all installs. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- daemon/libvirtd.service.in | 7 +++++-- src/locking/virtlockd.service.in | 4 ++++ src/logging/virtlogd.service.in | 5 +++++ 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/daemon/libvirtd.service.in b/daemon/libvirtd.service.in index c72dde5..22fc156 100644 --- a/daemon/libvirtd.service.in +++ b/daemon/libvirtd.service.in @@ -24,8 +24,11 @@ ExecStart=@sbindir@/libvirtd $LIBVIRTD_ARGS ExecReload=/bin/kill -HUP $MAINPID KillMode=process Restart=on-failure -# Override the maximum number of opened files -#LimitNOFILE=2048 +# At least 1 FD per guest, often 2 (eg qemu monitor + qemu agent). +# If we want to support 2048 guests, we'll typically need 4096 FDs +# If changing this, also consider virtlogd.service & virtlockd.service +# limits which are also related to number of guests +LimitNOFILE=8192 [Install] WantedBy=multi-user.target diff --git a/src/locking/virtlockd.service.in b/src/locking/virtlockd.service.in index 69b568f..c369591 100644 --- a/src/locking/virtlockd.service.in +++ b/src/locking/virtlockd.service.in @@ -13,6 +13,10 @@ ExecReload=/bin/kill -USR1 $MAINPID # cause the machine to be fenced (rebooted), so make # sure we discourage OOM killer OOMScoreAdjust=-900 +# Needs to allow for max guests * average disks per guest +# libvirtd.service written to expect 4096 guests, so if we +# allow for 4 disks per guest, we get: +LimitNOFILE=16384 [Install] Also=virtlockd.socket diff --git a/src/logging/virtlogd.service.in b/src/logging/virtlogd.service.in index 09e0740..be039c6 100644 --- a/src/logging/virtlogd.service.in +++ b/src/logging/virtlogd.service.in @@ -13,6 +13,11 @@ ExecReload=/bin/kill -USR1 $MAINPID # cause the machine to be fenced (rebooted), so make # sure we discourage OOM killer OOMScoreAdjust=-900 +# Need to have at least one file open per guest (eg QEMU +# stdio log), but might be more (eg serial console logs) +# libvirtd.service written to expect 2048 guests, so if we +# guess at 2 log files per guest here (stdio + 1 serial): +LimitNOFILE=8192 [Install] Also=virtlogd.socket -- 2.9.3

3 3

[libvirt] [PATCH] libxl: fix typo in debug message
by Guido Günther 16 Mar '17

16 Mar '17

--- src/libxl/libxl_migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libxl/libxl_migration.c b/src/libxl/libxl_migration.c index fb833d1a3..6b5b981f1 100644 --- a/src/libxl/libxl_migration.c +++ b/src/libxl/libxl_migration.c @@ -325,7 +325,7 @@ libxlMigrateReceive(virNetSocketPtr sock, goto fail; } VIR_DEBUG("Accepted migration connection." - " Spawing thread to process migration data"); + " Spawning thread to process migration data"); recvfd = virNetSocketDupFD(client_sock, true); virObjectUnref(client_sock); -- 2.11.0

2 2

[libvirt] [PATCH 0/2] Adaptive timeout for connecting to qemu monitor
by Michal Privoznik 16 Mar '17

16 Mar '17

I am not able to test this properly (my host has "just" 32GiB of RAM), but I've patched qemu to insert some delay into its init process and it worked just fine. Michal Privoznik (2): virTimeBackOffWait: Avoid long periods of sleep qemu: Adaptive timeout for connecting to monitor src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_monitor.c | 36 +++++++++++++++++++++++++++++++----- src/qemu/qemu_monitor.h | 1 + src/qemu/qemu_process.c | 8 ++++++++ src/util/virtime.c | 14 ++++++++++++-- tests/qemumonitortestutils.c | 1 + 6 files changed, 54 insertions(+), 8 deletions(-) -- 2.11.0

4 13

[libvirt] [PATCH] Short circuit SASL auth when no mechanisms are available
by Daniel P. Berrange 16 Mar '17

16 Mar '17

If the SASL config does not have any mechanisms we currently just report an empty list to the client which will then fail to identify a usable mechanism. This is a server config error, so we should fail immediately on the server side. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- src/rpc/virnetsaslcontext.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/rpc/virnetsaslcontext.c b/src/rpc/virnetsaslcontext.c index 37a5da2..c4492ec 100644 --- a/src/rpc/virnetsaslcontext.c +++ b/src/rpc/virnetsaslcontext.c @@ -390,6 +390,12 @@ char *virNetSASLSessionListMechanisms(virNetSASLSessionPtr sasl) err, sasl_errdetail(sasl->conn)); goto cleanup; } + VIR_DEBUG("SASL mechanism list is '%s'", mechlist); + if (STREQ(mechlist, "")) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("no SASL mechanisms are available")); + goto cleanup; + } ignore_value(VIR_STRDUP(ret, mechlist)); cleanup: -- 2.9.3

2 1

[libvirt] [PATCH] Sanity check explicit TLS file paths
by Daniel P. Berrange 16 Mar '17

16 Mar '17

When providing explicit x509 cert/key paths in libvirtd.conf, the user must provide all three. If one or more is missed, this leads to obscure errors at runtime when negotiating the TLS session Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- daemon/libvirtd.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index 9b98f33..40aa2b6 100644 --- a/daemon/libvirtd.c +++ b/daemon/libvirtd.c @@ -544,6 +544,22 @@ daemonSetupNetworking(virNetServerPtr srv, if (config->ca_file || config->cert_file || config->key_file) { + if (!config->ca_file) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + "No CA certificate path set to match server key/cert"); + goto cleanup; + } + if (!config->cert_file) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + "No server certificate path set to match server key"); + goto cleanup; + } + if (!config->key_file) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + "No server key path set to match server cert"); + goto cleanup; + } + VIR_DEBUG("Using CA='%s' cert='%s' key='%s'", config->ca_file, config->cert_file, config->key_file); if (!(ctxt = virNetTLSContextNewServer(config->ca_file, config->crl_file, config->cert_file, -- 2.9.3

2 1

[libvirt] [PATCH 0/2] Fix nodedev error message and test driver logic
by John Ferlan 15 Mar '17

15 Mar '17

The first patch is related to review comments from my Converge Storage Pool vHBA logic Patch1 w/r/t a weak error message The second patch is pulled from Patch17 of that series and is just an adjustment in the storage pool create xml logic Neither of these require news.xml updates... John Ferlan (2): conf: Alter error message for vHBA creation using parent wwnn/wwpn test: Don't assume a configFile exists for Storage Pool tests src/conf/node_device_conf.c | 17 +++++++++++++---- src/test/test_driver.c | 6 ++++++ 2 files changed, 19 insertions(+), 4 deletions(-) -- 2.9.3

2 4

[libvirt] [PATCH v3 00/18] Converge Storage Pool vHBA logic with Node Device
by John Ferlan 15 Mar '17

15 Mar '17

v2: http://www.redhat.com/archives/libvir-list/2017-March/msg00161.html Changes since v2: - Pushed the former patch1 after a slight adjustment replace a spurrious lost line - [NEW] Patch 1 - Fixes an existing bug - details in patch - [UPD] Patch 2 - Split out what Jano noted about new checks into it's own - [UPD] Patch 3->14 - Rework the former patch2 to split out the step by step details it took to get to patch2. - [No Change] Patch 15-18 -> Patch15->16 ACKed in v1, but I just left these in the order I had -> Patch17->18 Unchanged - same comment as v2 (copied so as to not force someone would go back to v2): Even though there is concern over usage of API's in this manner (e.g. calling virNodeDeviceLookupSCSIHostByWWN as well as virNodeDeviceCreateXML) - the "purpose" of the exercise is a means to have the StoragePool code use the same algorithms as the node device code instead of what could be a potentially long slow journey through the sysfs file system. The key piece being the replication of the API's that find the parent in the node device object list. I suppose it would be possible to add even more API's to get that answer, but I'm not sure it'd be worthwhile at this point. As for the concern about deadlock - I understand it, but since the whole purpose of the API is to essentially utilize the nodedev create algorithm there'd be no reason for nodedev to call it. If it doesn't get ACK'd - that's OK - I can hold onto it and reconsider some other means at some point in time in the future (probably distant future too). John Ferlan (18): conf: Ensure both parent_wwnn/parent_wwpn provided conf: Add missing validate for fchost search fields conf: Split out storage pool source adapter helpers conf: Rework parsing in virStoragePoolDefParseSourceAdapter conf: Introduce storage_adapter_conf conf: Rename API's in storage_adapter_conf conf: Extract FCHost adapter type processing into their own helpers conf: Extract SCSI adapter type processing into their own helpers conf: Split up virStoragePoolSourceAdapter conf: Rework storage_adapter_conf to use adapter specific typedefs conf: Rework storage_conf to use adapter specific typedefs storage: Rework getAdapterName to use adapter specific typedefs storage: Rework createVport and deleteVport conf: Convert virStoragePoolSourceAdapter to virStorageAdapter util: Rename virFileWaitForDevices conf: Move/rename createVport and deleteVport util: Alter virNodeDevice{Create|Delete}Vport to use nodedev APIs tests: Add more storage pool vHBA tests po/POTFILES.in | 1 + src/Makefile.am | 1 + src/conf/node_device_conf.c | 332 ++++++++++++++++++++++++++++++++ src/conf/node_device_conf.h | 9 + src/conf/storage_adapter_conf.c | 330 ++++++++++++++++++++++++++++++++ src/conf/storage_adapter_conf.h | 84 ++++++++ src/conf/storage_conf.c | 348 ++++++++-------------------------- src/conf/storage_conf.h | 36 +--- src/libvirt_private.syms | 13 +- src/node_device/node_device_driver.c | 2 +- src/phyp/phyp_driver.c | 3 +- src/storage/storage_backend_disk.c | 6 +- src/storage/storage_backend_iscsi.c | 2 +- src/storage/storage_backend_logical.c | 4 +- src/storage/storage_backend_mpath.c | 2 +- src/storage/storage_backend_scsi.c | 267 +++++--------------------- src/storage/storage_util.c | 2 +- src/test/test_driver.c | 11 +- src/util/virfile.h | 2 - src/util/virutil.c | 4 +- src/util/virutil.h | 2 + tests/fchosttest.c | 47 +++++ 22 files changed, 968 insertions(+), 540 deletions(-) create mode 100644 src/conf/storage_adapter_conf.c create mode 100644 src/conf/storage_adapter_conf.h -- 2.9.3

3 61

[libvirt] [PATCH v3 00/17] Introduce NVDIMM support
by Michal Privoznik 15 Mar '17

15 Mar '17

NVDIMMs are new type of ultra fast storage that's plugged into DIMM slot and can hold the stored info throughout reboots. After all, NV stands for non-volatile. In virtualization world, this has an awesome advantage - less VM_EXITs on 'disk' IO. https://nvdimm.wiki.kernel.org/ How to test this feature? $ > /tmp/nvdimm $ truncate --size 512M /tmp/nvdimm $ virsh edit $mydom <memory model='nvdimm' access='shared'> <source> <path>/tmp/nvdimm</path> </source> <target> <size unit='MiB'>512</size> <node>0</node> <label> <size unit='KiB'>128</size> </label> </target> <address type='dimm' slot='0'/> </memory> $ virsh start $mydom $ ssh $mydom "echo \"Hello world\" > /dev/pmem0" $ hexdump -C /tmp/nvdimm 00000000 48 65 6c 6c 6f 20 77 6f 72 6c 64 0a 00 00 00 00 |Hello world.....| 00000010 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| * 20000000 diff to v2: - John's review points worked in - Couple of more patches to clean up qemuBuildMemoryBackendStr Michal Privoznik (17): qemuBuildMemoryBackendStr: Don't overwrite @force qemuBuildMemoryBackendStr: Check for @memAccess properly qemuBuildMemoryBackendStr: Pass virDomainMemoryDefPtr qemuBuildMemoryBackendStr: Reorder args and update comment Introduce NVDIMM memory model qemu: Introduce QEMU_CAPS_DEVICE_NVDIMM qemu: Implement NVDIMM conf: Introduce @access to <memory/> qemu: Implement @access for <memory/> banks qemu: Introduce label-size for NVDIMMs security_dac: Label host side of NVDIMM security_selinux: Label host side of NVDIMM security: Introduce internal APIs for memdev labelling secdrivers: Implement memdev relabel APIs qemu_hotplug: Relabel memdev qemu: Allow nvdimm in devices CGroups qemu: Namespaces for NVDIMM docs/formatdomain.html.in | 83 ++++++++-- docs/schemas/domaincommon.rng | 47 ++++-- src/conf/domain_conf.c | 146 +++++++++++++---- src/conf/domain_conf.h | 5 + src/libvirt_private.syms | 2 + src/qemu/qemu_alias.c | 10 +- src/qemu/qemu_capabilities.c | 9 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_cgroup.c | 49 ++++++ src/qemu/qemu_cgroup.h | 4 + src/qemu/qemu_command.c | 172 +++++++++++++-------- src/qemu/qemu_command.h | 15 +- src/qemu/qemu_domain.c | 113 +++++++++++++- src/qemu/qemu_domain.h | 8 + src/qemu/qemu_hotplug.c | 40 ++++- src/qemu/qemu_security.c | 56 +++++++ src/qemu/qemu_security.h | 8 + src/security/security_dac.c | 76 +++++++++ src/security/security_driver.h | 9 ++ src/security/security_manager.c | 56 +++++++ src/security/security_manager.h | 7 + src/security/security_nop.c | 19 +++ src/security/security_selinux.c | 69 +++++++++ src/security/security_stack.c | 38 +++++ .../qemuxml2argv-memory-hotplug-nvdimm-access.args | 26 ++++ .../qemuxml2argv-memory-hotplug-nvdimm-access.xml | 56 +++++++ .../qemuxml2argv-memory-hotplug-nvdimm-label.args | 26 ++++ .../qemuxml2argv-memory-hotplug-nvdimm-label.xml | 59 +++++++ .../qemuxml2argv-memory-hotplug-nvdimm.args | 26 ++++ .../qemuxml2argv-memory-hotplug-nvdimm.xml | 56 +++++++ tests/qemuxml2argvtest.c | 8 +- ...qemuxml2xmlout-memory-hotplug-nvdimm-access.xml | 1 + .../qemuxml2xmlout-memory-hotplug-nvdimm-label.xml | 1 + .../qemuxml2xmlout-memory-hotplug-nvdimm.xml | 1 + tests/qemuxml2xmltest.c | 3 + 35 files changed, 1164 insertions(+), 141 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-nvdimm-access.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-nvdimm-access.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-nvdimm-label.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-nvdimm-label.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-nvdimm.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-nvdimm.xml create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-memory-hotplug-nvdimm-access.xml create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-memory-hotplug-nvdimm-label.xml create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-memory-hotplug-nvdimm.xml -- 2.11.0

2 36

[libvirt] libvirt and dmesg
by Michel Pierre-Jacques 15 Mar '17

15 Mar '17

Hi all, il try to find the way to obtain the same use as in the lxc config file lxc.kmsg=0 how to do that, with the xml of a lxc domain, i make lot of try without success . is there another way to deny access to the dmesg for a libvirt lxc domain ? --- Kogitae AE Infogérance Linux / Administrateur Système le Domaine Picard 21-23 rue de la cornée 70800 Anjeux -------------------------- Tel : +33 (0)3 68 33 53 64 IRC : http://kogitae.fr/irc ------------------------------------ 9h-12h & 14h-18h / Lundi au Vendredi Sur RDV en dehors

2 2

[libvirt] 1GB huge pages and incompatible VM memory size
by Jim Fehlig 14 Mar '17

14 Mar '17

Hi All, Matt encountered the following issue when using 1GB huge pages with libvirt > This problem turned out to be entirely my fault because I didn't round > the VM's memory size to a 1G multiple, and the kernel tried to split > the VMA at the end of the region, triggering this code in the kernel > do_mbind() path, > > static int __split_vma(struct mm_struct *mm, struct vm_area_struct *vma, > unsigned long addr, int new_below) > { > struct vm_area_struct *new; > int err; > > if (is_vm_hugetlb_page(vma) && (addr & > ~(huge_page_mask(hstate_vma(vma))))) > return -EINVAL; > > I have no idea how a less fortunate developer without access to MM > experts would have figured this out. It's a shame virsh didn't error > out when I initially setup 1G hugepages with an incompatible VM memory > size. What do folks think about improving libvirt to warn or error when using a VM memory size that is not compatible with the host hugepage configuration? Regards, Jim

3 4

[libvirt] [PATCH] bhyve: add config file support
by Roman Bogorodskiy 14 Mar '17

14 Mar '17

Introduce config file support for the bhyve driver. The only available setting at present is 'firmware_dir' for specifying a directory with UEFI firmware files. --- src/Makefile.am | 25 +++++++- src/bhyve/bhyve.conf | 7 +++ src/bhyve/bhyve_capabilities.c | 9 ++- src/bhyve/bhyve_capabilities.h | 5 +- src/bhyve/bhyve_conf.c | 112 +++++++++++++++++++++++++++++++++++ src/bhyve/bhyve_conf.h | 32 ++++++++++ src/bhyve/bhyve_driver.c | 11 +++- src/bhyve/bhyve_utils.h | 12 ++++ src/bhyve/libvirtd_bhyve.aug | 39 ++++++++++++ src/bhyve/test_libvirtd_bhyve.aug.in | 5 ++ 10 files changed, 252 insertions(+), 5 deletions(-) create mode 100644 src/bhyve/bhyve.conf create mode 100644 src/bhyve/bhyve_conf.c create mode 100644 src/bhyve/bhyve_conf.h create mode 100644 src/bhyve/libvirtd_bhyve.aug create mode 100644 src/bhyve/test_libvirtd_bhyve.aug.in diff --git a/src/Makefile.am b/src/Makefile.am index 02579659a..f0d8efe50 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -930,6 +930,8 @@ BHYVE_DRIVER_SOURCES = \ bhyve/bhyve_capabilities.h \ bhyve/bhyve_command.c \ bhyve/bhyve_command.h \ + bhyve/bhyve_conf.c \ + bhyve/bhyve_conf.h \ bhyve/bhyve_parse_command.c \ bhyve/bhyve_parse_command.h \ bhyve/bhyve_device.c \ @@ -1575,7 +1577,14 @@ libvirt_driver_bhyve_impl_la_CFLAGS = \ $(AM_CFLAGS) libvirt_driver_bhyve_impl_la_LDFLAGS = $(AM_LDFLAGS) libvirt_driver_bhyve_impl_la_SOURCES = $(BHYVE_DRIVER_SOURCES) + +conf_DATA += bhyve/bhyve.conf +augeas_DATA += bhyve/libvirtd_bhyve.aug +augeastest_DATA += test_libvirtd_bhyve.aug endif WITH_BHYVE +EXTRA_DIST += bhyve/bhyve.conf \ + bhyve/libvirtd_bhyve.aug \ + bhyve/test_libvirtd_bhyve.aug.in if WITH_NETWORK noinst_LTLIBRARIES += libvirt_driver_network_impl.la @@ -2125,11 +2134,12 @@ check-local: check-augeas check-augeas-sanlock \ check-augeas-lockd \ check-augeas-libxl \ + check-augeas-bhyve \ $(NULL) check-augeas: check-augeas-qemu check-augeas-lxc check-augeas-sanlock \ check-augeas-lockd check-augeas-virtlockd check-augeas-libxl \ - check-augeas-virtlogd + check-augeas-bhyve check-augeas-virtlogd AUG_GENTEST = $(PERL) $(top_srcdir)/build-aux/augeas-gentest.pl EXTRA_DIST += $(top_srcdir)/build-aux/augeas-gentest.pl @@ -2212,6 +2222,19 @@ else ! WITH_LIBXL check-augeas-libxl: endif ! WITH_LIBXL +if WITH_BHYVE +test_libvirtd_bhyve.aug: bhyve/test_libvirtd_bhyve.aug.in \ + $(srcdir)/bhyve/bhyve.conf $(AUG_GENTEST) + $(AM_V_GEN)$(AUG_GENTEST) $(srcdir)/bhyve/bhyve.conf $< $@ + +check-augeas-bhyve: test_libvirtd_bhyve.aug + $(AM_V_GEN)if test -x '$(AUGPARSE)'; then \ + '$(AUGPARSE)' -I $(srcdir)/bhyve test_libvirtd_bhyve.aug; \ + fi +else ! WITH_BHYVE +check-augeas-bhyve: +endif ! WITH_BHYVE + test_virtlogd.aug: logging/test_virtlogd.aug.in \ logging/virtlogd.conf $(AUG_GENTEST) $(AM_V_GEN)$(AUG_GENTEST) $(srcdir)/logging/virtlogd.conf $< $@ diff --git a/src/bhyve/bhyve.conf b/src/bhyve/bhyve.conf new file mode 100644 index 000000000..2a8baacff --- /dev/null +++ b/src/bhyve/bhyve.conf @@ -0,0 +1,7 @@ +# Master configuration file for the bhyve driver. +# All settings described here are optional - if omitted, sensible +# defaults are used. + +# Path to a directory with firmware files. By default it's pointing +# to the directory that sysutils/bhyve-firmware installs files into. +#firmware_dir = "/usr/local/share/uefi-firmware" diff --git a/src/bhyve/bhyve_capabilities.c b/src/bhyve/bhyve_capabilities.c index 5e6094e3c..da06ba711 100644 --- a/src/bhyve/bhyve_capabilities.c +++ b/src/bhyve/bhyve_capabilities.c @@ -111,7 +111,8 @@ virBhyveCapsBuild(void) } virDomainCapsPtr -virBhyveDomainCapsBuild(const char *emulatorbin, +virBhyveDomainCapsBuild(bhyveConnPtr conn, + const char *emulatorbin, const char *machine, virArch arch, virDomainVirtType virttype) @@ -120,8 +121,9 @@ virBhyveDomainCapsBuild(const char *emulatorbin, unsigned int bhyve_caps = 0; DIR *dir; struct dirent *entry; - const char *firmware_dir = "/usr/local/share/uefi-firmware"; size_t firmwares_alloc = 0; + virBhyveDriverConfigPtr cfg = virBhyveDriverGetConfig(conn); + const char *firmware_dir = cfg->firmwareDir; if (!(caps = virDomainCapsNew(emulatorbin, machine, arch, virttype))) goto cleanup; @@ -152,7 +154,10 @@ virBhyveDomainCapsBuild(const char *emulatorbin, caps->os.loader.values.nvalues++; } + } else { + VIR_WARN("Cannot open firmware directory %s", firmware_dir); } + caps->disk.supported = true; VIR_DOMAIN_CAPS_ENUM_SET(caps->disk.diskDevice, VIR_DOMAIN_DISK_DEVICE_DISK, diff --git a/src/bhyve/bhyve_capabilities.h b/src/bhyve/bhyve_capabilities.h index 8fb97d730..3d8edb490 100644 --- a/src/bhyve/bhyve_capabilities.h +++ b/src/bhyve/bhyve_capabilities.h @@ -25,8 +25,11 @@ # include "capabilities.h" # include "conf/domain_capabilities.h" +# include "bhyve_conf.h" + virCapsPtr virBhyveCapsBuild(void); -virDomainCapsPtr virBhyveDomainCapsBuild(const char *emulatorbin, +virDomainCapsPtr virBhyveDomainCapsBuild(bhyveConnPtr, + const char *emulatorbin, const char *machine, virArch arch, virDomainVirtType virttype); diff --git a/src/bhyve/bhyve_conf.c b/src/bhyve/bhyve_conf.c new file mode 100644 index 000000000..b0b40c575 --- /dev/null +++ b/src/bhyve/bhyve_conf.c @@ -0,0 +1,112 @@ +/* + * bhyve_conf.c: bhyve config file + * + * Copyright (C) 2017 Roman Bogorodskiy + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + */ + +#include <config.h> + +#include "viralloc.h" +#include "virlog.h" +#include "virstring.h" +#include "bhyve_conf.h" +#include "configmake.h" + +#define VIR_FROM_THIS VIR_FROM_BHYVE + +VIR_LOG_INIT("bhyve.bhyve_conf"); + +static virClassPtr virBhyveDriverConfigClass; +static void virBhyveDriverConfigDispose(void *obj); + +static int virBhyveConfigOnceInit(void) +{ + if (!(virBhyveDriverConfigClass = virClassNew(virClassForObject(), + "virBhyveDriverConfig", + sizeof(virBhyveDriverConfig), + virBhyveDriverConfigDispose))) + return -1; + + return 0; +} + +VIR_ONCE_GLOBAL_INIT(virBhyveConfig) + +virBhyveDriverConfigPtr +virBhyveDriverConfigNew(void) +{ + virBhyveDriverConfigPtr cfg; + + if (virBhyveConfigInitialize() < 0) + return NULL; + + if (!(cfg = virObjectNew(virBhyveDriverConfigClass))) + return NULL; + + if (VIR_STRDUP(cfg->firmwareDir, DATADIR "/uefi-firmware") < 0) + goto error; + + return cfg; + + error: + virObjectUnref(cfg); + return NULL; +} + +int +virBhyveLoadDriverConfig(virBhyveDriverConfigPtr cfg, + const char *filename) +{ + virConfPtr conf; + int ret = -1; + + if (access(filename, R_OK) == -1) { + VIR_INFO("Could not read bhyve config file %s", filename); + return 0; + } + + if (!(conf = virConfReadFile(filename, 0))) + return -1; + + if (virConfGetValueString(conf, "firmware_dir", + &cfg->firmwareDir) < 0) + goto cleanup; + + ret = 0; + cleanup: + virConfFree(conf); + return ret; +} + +virBhyveDriverConfigPtr +virBhyveDriverGetConfig(bhyveConnPtr driver) +{ + virBhyveDriverConfigPtr cfg; + bhyveDriverLock(driver); + cfg = virObjectRef(driver->config); + bhyveDriverUnlock(driver); + return cfg; +} + +static void +virBhyveDriverConfigDispose(void *obj) +{ + virBhyveDriverConfigPtr cfg = obj; + + VIR_FREE(cfg->firmwareDir); +} diff --git a/src/bhyve/bhyve_conf.h b/src/bhyve/bhyve_conf.h new file mode 100644 index 000000000..3f105ace1 --- /dev/null +++ b/src/bhyve/bhyve_conf.h @@ -0,0 +1,32 @@ +/* + * bhyve_conf.h: bhyve config file + * + * Copyright (C) 2017 Roman Bogorodskiy + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + */ + +#ifndef BHYVE_CONF_H +# define BHYVE_CONF_H + +# include "bhyve_utils.h" + +virBhyveDriverConfigPtr virBhyveDriverConfigNew(void); +virBhyveDriverConfigPtr virBhyveDriverGetConfig(bhyveConnPtr driver); +int virBhyveLoadDriverConfig(virBhyveDriverConfigPtr cfg, + const char *filename); + +#endif /* BHYVE_CONF_H */ diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index 759825c28..3258c2720 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@ -55,6 +55,7 @@ #include "virhostmem.h" #include "conf/domain_capabilities.h" +#include "bhyve_conf.h" #include "bhyve_device.h" #include "bhyve_driver.h" #include "bhyve_command.h" @@ -1228,6 +1229,7 @@ bhyveStateCleanup(void) virSysinfoDefFree(bhyve_driver->hostsysinfo); virObjectUnref(bhyve_driver->closeCallbacks); virObjectUnref(bhyve_driver->domainEventState); + virObjectUnref(bhyve_driver->config); virMutexDestroy(&bhyve_driver->lock); VIR_FREE(bhyve_driver); @@ -1276,6 +1278,12 @@ bhyveStateInitialize(bool privileged, bhyve_driver->hostsysinfo = virSysinfoRead(); + if (!(bhyve_driver->config = virBhyveDriverConfigNew())) + goto cleanup; + + if (virBhyveLoadDriverConfig(bhyve_driver->config, SYSCONFDIR "/libvirt/bhyve.conf") < 0) + goto cleanup; + if (virFileMakePath(BHYVE_LOG_DIR) < 0) { virReportSystemError(errno, _("Failed to mkdir %s"), @@ -1657,7 +1665,8 @@ bhyveConnectGetDomainCapabilities(virConnectPtr conn, goto cleanup; } - if (!(caps = virBhyveDomainCapsBuild(emulatorbin, machine, arch, virttype))) + if (!(caps = virBhyveDomainCapsBuild(conn->privateData, emulatorbin, + machine, arch, virttype))) goto cleanup; ret = virDomainCapsFormat(caps); diff --git a/src/bhyve/bhyve_utils.h b/src/bhyve/bhyve_utils.h index 9a911608c..db50e012a 100644 --- a/src/bhyve/bhyve_utils.h +++ b/src/bhyve/bhyve_utils.h @@ -34,8 +34,20 @@ # define BHYVE_STATE_DIR LOCALSTATEDIR "/run/libvirt/bhyve" # define BHYVE_LOG_DIR LOCALSTATEDIR "/log/libvirt/bhyve" +typedef struct _virBhyveDriverConfig virBhyveDriverConfig; +typedef struct _virBhyveDriverConfig *virBhyveDriverConfigPtr; + +struct _virBhyveDriverConfig { + virObject parent; + + char *firmwareDir; +}; + struct _bhyveConn { virMutex lock; + + virBhyveDriverConfigPtr config; + virDomainObjListPtr domains; virCapsPtr caps; virDomainXMLOptionPtr xmlopt; diff --git a/src/bhyve/libvirtd_bhyve.aug b/src/bhyve/libvirtd_bhyve.aug new file mode 100644 index 000000000..66079376c --- /dev/null +++ b/src/bhyve/libvirtd_bhyve.aug @@ -0,0 +1,39 @@ +(* /etc/libvirt/bhyve.conf *) + +module Libvirtd_bhyve = + autoload xfm + + let eol = del /[ \t]*\n/ "\n" + let value_sep = del /[ \t]*=[ \t]*/ " = " + let indent = del /[ \t]*/ "" + + let array_sep = del /,[ \t\n]*/ ", " + let array_start = del /\[[ \t\n]*/ "[ " + let array_end = del /\]/ "]" + + let str_val = del /\"/ "\"" . store /[^\"]*/ . del /\"/ "\"" + let bool_val = store /0|1/ + let int_val = store /[0-9]+/ + let str_array_element = [ seq "el" . str_val ] . del /[ \t\n]*/ "" + let str_array_val = counter "el" . array_start . ( str_array_element . ( array_sep . str_array_element ) * ) ? . array_end + + let str_entry (kw:string) = [ key kw . value_sep . str_val ] + let bool_entry (kw:string) = [ key kw . value_sep . bool_val ] + let int_entry (kw:string) = [ key kw . value_sep . int_val ] + let str_array_entry (kw:string) = [ key kw . value_sep . str_array_val ] + + let log_entry = str_entry "firmware_dir" + + (* Each enty in the config is one of the following three ... *) + let entry = log_entry + let comment = [ label "#comment" . del /#[ \t]*/ "# " . store /([^ \t\n][^\n]*)?/ . del /\n/ "\n" ] + let empty = [ label "#empty" . eol ] + + let record = indent . entry . eol + + let lns = ( record | comment | empty ) * + + let filter = incl "/etc/libvirt/bhyve.conf" + . Util.stdexcl + + let xfm = transform lns filter diff --git a/src/bhyve/test_libvirtd_bhyve.aug.in b/src/bhyve/test_libvirtd_bhyve.aug.in new file mode 100644 index 000000000..f28e58614 --- /dev/null +++ b/src/bhyve/test_libvirtd_bhyve.aug.in @@ -0,0 +1,5 @@ +module Test_libvirtd_bhyve = + ::CONFIG:: + + test Libvirtd_bhyve.lns get conf = +{ "firmware_dir" = "/usr/local/share/uefi-firmware" } -- 2.11.0

3 3

[libvirt] [PATCH] docs: moved 'timestamps' and 'encryption' sub-element description in formatstorage doc
by Alexander Vasilenko 14 Mar '17

14 Mar '17

--- docs/formatstorage.html.in | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in index c787a059d..225e19000 100644 --- a/docs/formatstorage.html.in +++ b/docs/formatstorage.html.in @@ -456,24 +456,6 @@ will be filled with the values used by the existing directory. <span class="since">Since 1.2.16</span> </dd> - <dt><code>timestamps</code></dt> - <dd>Provides timing information about the volume. Up to four - sub-elements are present, - where <code>atime</code>, <code>btime</code>, <code>ctime</code> - and <code>mtime</code> hold the access, birth, change and - modification time of the volume, where known. The used time - format is <seconds>.<nanoseconds> since the - beginning of the epoch (1 Jan 1970). If nanosecond resolution - is 0 or otherwise unsupported by the host OS or filesystem, - then the nanoseconds part is omitted. This is a readonly - attribute and is ignored when creating a volume. - <span class="since">Since 0.10.0</span> - </dd> - <dt><code>encryption</code></dt> - <dd>If present, specifies how the volume is encrypted. See - the <a href="formatstorageencryption.html">Storage Encryption</a> page - for more information. - </dd> </dl> <h3><a name="StoragePoolExtents">Device extents</a></h3> @@ -658,6 +640,24 @@ will be filled with the values used by the existing file. <span class="since">Since 0.4.1</span> </dd> + <dt><code>timestamps</code></dt> + <dd>Provides timing information about the volume. Up to four + sub-elements are present, + where <code>atime</code>, <code>btime</code>, <code>ctime</code> + and <code>mtime</code> hold the access, birth, change and + modification time of the volume, where known. The used time + format is <seconds>.<nanoseconds> since the + beginning of the epoch (1 Jan 1970). If nanosecond resolution + is 0 or otherwise unsupported by the host OS or filesystem, + then the nanoseconds part is omitted. This is a readonly + attribute and is ignored when creating a volume. + <span class="since">Since 0.10.0</span> + </dd> + <dt><code>encryption</code></dt> + <dd>If present, specifies how the volume is encrypted. See + the <a href="formatstorageencryption.html">Storage Encryption</a> page + for more information. + </dd> <dt><code>compat</code></dt> <dd>Specify compatibility level. So far, this is only used for <code>type='qcow2'</code> volumes. Valid values are <code>0.10</code> -- 2.12.0

2 1

[libvirt] [PATCH] virtperf: Revert PERF_COUNT_HW_REF_CPU_CYCLES conditional
by Olaf Hering 14 Mar '17

14 Mar '17

All PERF_* names are enmus. Enums are ordinary code for CPP. An ifdef does not trigger. Fixes 1d29c889a ("Make use of PERF_COUNT_HW_REF_CPU_CYCLES conditional") Signed-off-by: Olaf Hering <olaf(a)aepfle.de> --- src/util/virperf.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/util/virperf.c b/src/util/virperf.c index e39cebbe0..33039544a 100644 --- a/src/util/virperf.c +++ b/src/util/virperf.c @@ -108,13 +108,8 @@ static struct virPerfEventAttr attrs[] = { .attrType = PERF_TYPE_HARDWARE, .attrConfig = PERF_COUNT_HW_STALLED_CYCLES_BACKEND}, {.type = VIR_PERF_EVENT_REF_CPU_CYCLES, -# ifdef PERF_COUNT_HW_REF_CPU_CYCLES .attrType = PERF_TYPE_HARDWARE, .attrConfig = PERF_COUNT_HW_REF_CPU_CYCLES -# else - .attrType = 0, - .attrConfig = 0, -# endif }, {.type = VIR_PERF_EVENT_CPU_CLOCK, .attrType = PERF_TYPE_SOFTWARE,

2 3

[libvirt] [PATCH] [Changelog]:If there is a process with a client which registers event callbacks, and it calls libvirt's API which uses the same virConnectPtr in that callback function. When this process exit abnormally lead to client disconnect, there is a possibility that the libvirtd's main thread is use virServerClient to send event just after the virServerClient been freed by job thread. Following is backtrace:
by xinhua.Cao 13 Mar '17

13 Mar '17

#0 0x00007fda223d66d8 in virClassIsDerivedFrom (klass=0xdeadbeef, parent=0x7fda24c81b40) at util/virobject.c:169 #1 0x00007fda223d6a1e in virObjectIsClass (anyobj=anyobj@entry=0x7fd9e575b400, klass=<optimized out>) at util/virobject.c:365 #2 0x00007fda223d6a44 in virObjectLock (anyobj=0x7fd9e575b400) at util/virobject.c:317 #3 0x00007fda22507f71 in virNetServerClientSendMessage (client=client@entry=0x7fd9e575b400, msg=msg@entry=0x7fd9ec30de90) at rpc/virnetserverclient.c:1422 #4 0x00007fda230d714d in remoteDispatchObjectEventSend (client=0x7fd9e575b400, program=0x7fda24c844e0, procnr=348, proc=0x7fda2310e5e0 <xdr_remote_domain_event_callback_tunable_msg>, data=0x7ffc3857fdb0) at remote.c:3803 #5 0x00007fda230dd71b in remoteRelayDomainEventTunable (conn=<optimized out>, dom=0x7fda27cd7660, params=0x7fda27f3aae0, nparams=1,opaque=0x7fd9e6c99e00) at remote.c:1033 #6 0x00007fda224484cb in virDomainEventDispatchDefaultFunc (conn=0x7fda27cd0120, event=0x7fda2736ea00, cb=0x7fda230dd610 <remoteRelayDomainEventTunable>, cbopaque=0x7fd9e6c99e00) at conf/domain_event.c:1910 #7 0x00007fda22446871 in virObjectEventStateDispatchCallbacks (callbacks=<optimized out>, callbacks=<optimized out>, event=0x7fda2736ea00,state=0x7fda24ca3960) at conf/object_event.c:722 #8 virObjectEventStateQueueDispatch (callbacks=0x7fda24c65800, queue=0x7ffc3857fe90, state=0x7fda24ca3960) at conf/object_event.c:736 #9 virObjectEventStateFlush (state=0x7fda24ca3960) at conf/object_event.c:814 #10 virObjectEventTimer (timer=<optimized out>, opaque=0x7fda24ca3960) at conf/object_event.c:560 #11 0x00007fda223ae8b9 in virEventPollDispatchTimeouts () at util/vireventpoll.c:458 #12 virEventPollRunOnce () at util/vireventpoll.c:654 #13 0x00007fda223ad1d2 in virEventRunDefaultImpl () at util/virevent.c:314 #14 0x00007fda225046cd in virNetDaemonRun (dmn=0x7fda24c775c0) at rpc/virnetdaemon.c:818 #15 0x00007fda230d6351 in main (argc=<optimized out>, argv=<optimized out>) at libvirtd.c:1623 Let's clean all event callback when client close. Signed-off-by: xinhua.Cao <caoxinhua(a)huawei.com> this patch resolved the bug which reported by Wang King. and the prior patch link is http://www.redhat.com/archives/libvir-list/2017-February/msg00452.html --- daemon/remote.c | 60 +++++++++++++++++++++++++++------------------------------ 1 file changed, 28 insertions(+), 32 deletions(-) diff --git a/daemon/remote.c b/daemon/remote.c index 4aa43c223..22330307f 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -100,6 +100,7 @@ static void make_nonnull_node_device(remote_nonnull_node_device *dev_dst, virNod static void make_nonnull_secret(remote_nonnull_secret *secret_dst, virSecretPtr secret_src); static void make_nonnull_nwfilter(remote_nonnull_nwfilter *net_dst, virNWFilterPtr nwfilter_src); static void make_nonnull_domain_snapshot(remote_nonnull_domain_snapshot *snapshot_dst, virDomainSnapshotPtr snapshot_src); +static void remoteClientCleanEventCallbacks(struct daemonClientPrivate *priv); static int remoteSerializeDomainDiskErrors(virDomainDiskErrorPtr errors, @@ -1389,24 +1390,15 @@ void remoteRelayConnectionClosedEvent(virConnectPtr conn ATTRIBUTE_UNUSED, int r &msg); } -/* - * You must hold lock for at least the client - * We don't free stuff here, merely disconnect the client's - * network socket & resources. - * We keep the libvirt connection open until any async - * jobs have finished, then clean it up elsewhere - */ -void remoteClientFreeFunc(void *data) +static void remoteClientCleanEventCallbacks(struct daemonClientPrivate *priv) { - struct daemonClientPrivate *priv = data; - /* Deregister event delivery callback */ - if (priv->conn) { - virIdentityPtr sysident = virIdentityGetSystem(); + if (priv && priv->conn) { size_t i; - + virIdentityPtr sysident = virIdentityGetSystem(); virIdentitySetCurrent(sysident); + virMutexLock(&priv->lock); for (i = 0; i < priv->ndomainEventCallbacks; i++) { int callbackID = priv->domainEventCallbacks[i]->callbackID; if (callbackID < 0) { @@ -1420,6 +1412,7 @@ void remoteClientFreeFunc(void *data) VIR_WARN("unexpected domain event deregister failure"); } VIR_FREE(priv->domainEventCallbacks); + priv->ndomainEventCallbacks = 0; for (i = 0; i < priv->nnetworkEventCallbacks; i++) { int callbackID = priv->networkEventCallbacks[i]->callbackID; @@ -1435,21 +1428,7 @@ void remoteClientFreeFunc(void *data) VIR_WARN("unexpected network event deregister failure"); } VIR_FREE(priv->networkEventCallbacks); - - for (i = 0; i < priv->nstorageEventCallbacks; i++) { - int callbackID = priv->storageEventCallbacks[i]->callbackID; - if (callbackID < 0) { - VIR_WARN("unexpected incomplete storage pool callback %zu", i); - continue; - } - VIR_DEBUG("Deregistering remote storage pool event relay %d", - callbackID); - priv->storageEventCallbacks[i]->callbackID = -1; - if (virConnectStoragePoolEventDeregisterAny(priv->conn, - callbackID) < 0) - VIR_WARN("unexpected storage pool event deregister failure"); - } - VIR_FREE(priv->storageEventCallbacks); + priv->nnetworkEventCallbacks = 0; for (i = 0; i < priv->nqemuEventCallbacks; i++) { int callbackID = priv->qemuEventCallbacks[i]->callbackID; @@ -1465,28 +1444,45 @@ void remoteClientFreeFunc(void *data) VIR_WARN("unexpected qemu monitor event deregister failure"); } VIR_FREE(priv->qemuEventCallbacks); + priv->nqemuEventCallbacks = 0; if (priv->closeRegistered) { if (virConnectUnregisterCloseCallback(priv->conn, remoteRelayConnectionClosedEvent) < 0) VIR_WARN("unexpected close callback event deregister failure"); } - - virConnectClose(priv->conn); - + virMutexUnlock(&priv->lock); virIdentitySetCurrent(NULL); virObjectUnref(sysident); } +} + + +/* + * You must hold lock for at least the client + * We don't free stuff here, merely disconnect the client's + * network socket & resources. + * We keep the libvirt connection open until any async + * jobs have finished, then clean it up elsewhere + */ +void remoteClientFreeFunc(void *data) +{ + struct daemonClientPrivate *priv = data; + if (!priv || !priv->conn) + return; + + remoteClientCleanEventCallbacks(priv); + virConnectClose(priv->conn); VIR_FREE(priv); } - static void remoteClientCloseFunc(virNetServerClientPtr client) { struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client); daemonRemoveAllClientStreams(priv->streams); + remoteClientCleanEventCallbacks(priv); } -- 2.12.0.windows.1

2 1

[libvirt] [PATCH 0/4] Prevent loosing IPv6 routes due to forwarding
by Cédric Bosdonnat 13 Mar '17

13 Mar '17

Hi all, When enabling IPv6 forwarding on hosts getting Router Advertised routes, the host looses the RA routes. To prevent this, check if the host has such routes. In case there are some, check that the accept_ra is set to 2 before bringing the network up. Cédric Bosdonnat (4): util: extract the request sending code from virNetlinkCommand() util: add virNetlinkDumpCommand() bridge_driver.c: more uses of SYSCTL_PATH network: check accept_ra before enabling ipv6 forwarding src/libvirt_private.syms | 1 + src/network/bridge_driver.c | 187 +++++++++++++++++++++++++++++++++++++++++--- src/util/virnetlink.c | 145 +++++++++++++++++++++++++--------- src/util/virnetlink.h | 9 +++ 4 files changed, 298 insertions(+), 44 deletions(-) -- 2.11.0

3 9

[libvirt] [PATCH] docs: document virt-host-validate bhyve support
by Roman Bogorodskiy 13 Mar '17

13 Mar '17

Add an entry about virt-host-validate bhyve support and update the driver's page. --- docs/drvbhyve.html.in | 13 ++++++++++++- docs/news.xml | 10 +++++++++- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/docs/drvbhyve.html.in b/docs/drvbhyve.html.in index da6f1e0b2..64a1ff694 100644 --- a/docs/drvbhyve.html.in +++ b/docs/drvbhyve.html.in @@ -13,9 +13,20 @@ of bhyve are supported. In order to enable bhyve on your FreeBSD host, you'll need to load the <code>vmm</code> kernel module. Additionally, <code>if_tap</code> and <code>if_bridge</code> modules -should be loaded for networking support. +should be loaded for networking support. Also, <span class="since">since 3.2.0</span> the +<code>virt-host-validate(1)</code> supports the bhyve host validation and could be +used like this: </p> +<pre> +$ virt-host-validate bhyve + BHYVE: Checking for vmm module : PASS + BHYVE: Checking for if_tap module : PASS + BHYVE: Checking for if_bridge module : PASS + BHYVE: Checking for nmdm module : PASS +$ +</pre> + <p> Additional information on bhyve could be obtained on <a href="http://bhyve.org/">bhyve.org</a>. </p> diff --git a/docs/news.xml b/docs/news.xml index 951539575..57fafebb8 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -12,7 +12,15 @@ <libvirt> <release version="v3.2.0" date="unreleased"> <section title="New features"> - <change/> + <change> + <summary> + virt-host-validate: Add bhyve support + </summary> + <description> + Add support for validation of the bhyve hypervisor hosts + using the virt-host-validate tool. + </description> + </change> </section> <section title="Improvements"> <change> -- 2.11.0

2 2

[libvirt] [PATCH] Switch to GSSAPI (kerberos) instead of the insecure DIGEST-MD5
by Daniel P. Berrange 13 Mar '17

13 Mar '17

RFC 6331 documents a number of serious security weaknesses in the SASL DIGEST-MD5 mechanism. As such, libvirtd should not by using it as a default mechanism. GSSAPI is the only other viable SASL mechanism that can provide secure session encryption so enable that by defalt as the replacement. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- daemon/libvirtd.sasl | 44 +++++++++++++++++--------- docs/auth.html.in | 89 +++++++++++++++++++++++++++++++++++++++++----------- libvirt.spec.in | 6 ++-- 3 files changed, 102 insertions(+), 37 deletions(-) diff --git a/daemon/libvirtd.sasl b/daemon/libvirtd.sasl index 5e2528d..2be99ef 100644 --- a/daemon/libvirtd.sasl +++ b/daemon/libvirtd.sasl @@ -1,31 +1,45 @@ -# If you want to use the non-TLS socket, then you *must* include -# the GSSAPI or DIGEST-MD5 mechanisms, because they are the only -# ones that can offer session encryption as well as authentication. +# If you want to use the non-TLS socket, then you *must* pick a +# mechanism which provides session encryption as well as +# authentication. # -# If you're only using TLS, then you can turn on any mechanisms +# If you are only using TLS, then you can turn on any mechanisms # you like for authentication, because TLS provides the encryption # -# Default to a simple username+password mechanism -mech_list: digest-md5 +# If you are only using UNIX, sockets then encryption is not +# required at all. +# +# Since SASL is the default for the libvirtd non-TLS socket, we +# pick a strong mechanism by default. +# +# NB, previously DIGEST-MD5 was set as the default mechanism for +# libvirt. Per RFC 6331 this is vulnerable to many serious security +# flaws as should no longer be used. Thus GSSAPI is now the default. +# +# To use GSSAPI requires that a libvirtd service principal is +# added to the Kerberos server for each host running libvirtd. +# This principal needs to be exported to the keytab file listed below +mech_list: gssapi + +# If using a TLS socket or UNIX socket only, it is possible to +# enable plugins which don't provide session encryption. The +# 'scram-sha-1' plugin allows plain username/password authentication +# to be performed +# +#mech_list: scram-sha-1 -# Before you can use GSSAPI, you need a service principle on the -# KDC server for libvirt, and that to be exported to the keytab -# file listed below -#mech_list: gssapi # # You can also list many mechanisms at once, then the user can choose # by adding '?auth=sasl.gssapi' to their libvirt URI, eg # qemu+tcp://hostname/system?auth=sasl.gssapi -#mech_list: digest-md5 gssapi +#mech_list: scram-sha-1 gssapi # Some older builds of MIT kerberos on Linux ignore this option & # instead need KRB5_KTNAME env var. # For modern Linux, and other OS, this should be sufficient # -# There is no default value here, uncomment if you need this -#keytab: /etc/libvirt/krb5.tab +keytab: /etc/libvirt/krb5.tab -# If using digest-md5 for username/passwds, then this is the file +# If using scram-sha-1 for username/passwds, then this is the file # containing the passwds. Use 'saslpasswd2 -a libvirt [username]' # to add entries, and 'sasldblistusers2 -f [sasldb_path]' to browse it -sasldb_path: /etc/libvirt/passwd.db +#sasldb_path: /etc/libvirt/passwd.db diff --git a/docs/auth.html.in b/docs/auth.html.in index 08feacc..9f2e317 100644 --- a/docs/auth.html.in +++ b/docs/auth.html.in @@ -204,16 +204,71 @@ ResultActive=yes</pre> Further examples of PolicyKit setup can be found on the <a href="http://wiki.libvirt.org/page/SSHPolicyKitSetup">wiki page</a>. </p> - <h2><a name="ACL_server_username">Username/password auth</a></h2> + <h2><a name="ACL_server_sasl">SASL pluggable authentication</a></h2> + <p> -The plain TCP socket of the libvirt daemon defaults to using SASL for authentication. -The SASL mechanism configured by default is DIGEST-MD5, which provides a basic -username+password style authentication. It also provides for encryption of the data -stream, so the security of the plain TCP socket is on a par with that of the TLS -socket. If desired the UNIX socket and TLS socket can also have SASL enabled by -setting the <code>auth_unix_ro</code>, <code>auth_unix_rw</code>, <code>auth_tls</code> -config params in <code>libvirt.conf</code>. -</p> +Libvirt integrates with the cyrus-sasl library to provide a pluggable authentication +system using the SASL protocol. SASL can be used in combination with libvirtd's TLS +or TCP socket listeners. When used with the TCP listener, the SASL mechanism is +rqeuired to provide session encryption in addition to authentication. Only a very +few SASL mechanisms are able todo this, and of those that can do it, only the +GSSAPI plugin is considered acceptably secure by modern standards: + </p> + + <dl> + <dt>GSSAPI</dt> + <dd><strong>This is the current default mechanism to use with libvirtd</strong>. + It uses the Kerberos v5 authentication protocol underneath, and assuming + the Kerberos client/server are configured with modern ciphers (AES), + it provides strong session encryption capabilities.</dd> + + <dt>DIGEST-MD5</dt> + <dd>This was previously set as the default mechanism to use with libvirtd. + It provides a simple username/password based authentication mechanism + that includes session encryption. + <a href="https://tools.ietf.org/html/rfc6331">RFC 6331</a>, however, + documents a number of serious security flaws with DIGEST-MD5 and as a + result marks it as <code>OBSOLETE</code>. Specific concerns are that + it is vulnerable to MITM attacks and the MD5 hash can be brute-forced + to reveal the password. A replacement is provided via the SCRAM mechanism, + however, note that this is does not provide encryption, so the SCRAM + mechanism can only be used on the libvirtd TLS listener. + </dd> + + <dt>PASSDSS-3DES-1</dt> + <dd>This provides a simple username/password based authentication + mechanism that includes session encryption. The current cyrus-sasl + implementation does not provide a way to validate the server's + public key identity, thus it is susceptible to a MITM attacker + impersonating the server.</dd> + + <dt>KERBEROS_V4</dt> + <dd>This uses the obsolete Kerberos v4 protocol to provide both authentication + and session encryption. Kerberos v4 protocol has been obsolete since the + early 1990's and has known security vulnerabilities so this will never be + used in practice.</dd> + </dl> + + <p> + Other SASL mechanisms, not listed above, can only be used when the libvirtd + TLS or UNIX socket listeners. + </p> + + <h3><a name="ACL_server_username">Username/password auth</a></h3> + <p> +As noted above, the DIGEST-MD5 mechanism is considered obsolete and should +not be used anymore. To provide a simple username/password auth scheme on +the libvirt UNIX socket or TLS listeners, however, it is possible to use +the SCRAM mechanism. The <code>auth_unix_ro</code>, <code>auth_unix_rw</code>, +<code>auth_tls</code> config params in <code>libvirt.conf</code> can be used +to turn on SASL auth in these listeners. + </p> + <p> +Since the libvirt SASL config file defaults to using GSSAPI (Kerberos), a +config change is rquired to enable plain password auth. This is done by +editting <code>/etc/sasl2/libvirt.conf</code> to set the <code>mech_list</code> +parameter to <code>scram-sha-1</code>. + </p> <p> Out of the box, no user accounts are defined, so no clients will be able to authenticate on the TCP socket. Adding users and setting their passwords is done with the <code>saslpasswd2</code> @@ -241,17 +296,13 @@ again: <pre> # saslpasswd2 -a libvirt -d fred </pre> - <h2><a name="ACL_server_kerberos">Kerberos auth</a></h2> + <h3><a name="ACL_server_kerberos">GSSAPI/Kerberos auth</a></h3> <p> -The plain TCP socket of the libvirt daemon defaults to using SASL for authentication. -The SASL mechanism configured by default is DIGEST-MD5, which provides a basic -username+password style authentication. To enable Kerberos single-sign-on instead, -the libvirt SASL configuration file must be changed. This is <code>/etc/sasl2/libvirt.conf</code>. -The <code>mech_list</code> parameter must first be changed to <code>gssapi</code> -instead of the default <code>digest-md5</code>, and keytab should be set to -<code>/etc/libvirt/krb5.tab</code> . If SASL is enabled on the UNIX -and/or TLS sockets, Kerberos will also be used for them. Like DIGEST-MD5, the Kerberos -mechanism provides data encryption of the session. +The plain TCP listener of the libvirt daemon defaults to using SASL for authentication. +The libvirt SASL config also defaults to GSSAPI, so there is no need to edit the +SASL config when using GSSAPI. If the libvirtd TLS or UNIX listeners are used, +then the Kerberos session encryption will be disabled since it is not required +in these scenarios - only the plain TCP listener needs encryption </p> <p> Some operating systems do not install the SASL kerberos plugin by default. It diff --git a/libvirt.spec.in b/libvirt.spec.in index 57ac88e..1d24985 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -979,9 +979,9 @@ Group: Development/Libraries # (client invokes 'nc' against the UNIX socket on the server) Requires: nc Requires: cyrus-sasl -# Not technically required, but makes 'out-of-box' config -# work correctly & doesn't have onerous dependencies -Requires: cyrus-sasl-md5 +# Needed by default sasl.conf - no onerous extra deps, since +# 100's of other things on a system already pull in krb5-libs +Requires: cyrus-sasl-gssapi %description libs Shared libraries for accessing the libvirt daemon. -- 2.9.3

3 2

[libvirt] [PATCH 0/7] qemu: Report better host-model CPUs in domain caps
by Jiri Denemark 13 Mar '17

13 Mar '17

One of the main reasons for introducing host-model CPU definition in a domain capabilities XML was the inability to express disabled features in a host capabilities XML. That is, when a host CPU is, e.g., Haswell without x2apic support, host capabilities XML will have to report it as Westmere + a bunch of additional features., but we really want to use Haswell - x2apic when creating a host-model CPU. Unfortunately, I somehow forgot to do the last step and the code would just copy the CPU definition found in the host capabilities XML. This changed recently for new QEMU versions which allow us to query host CPU, but any slightly older QEMU will not benefit from any change I did. This patch makes sure the right CPU model is filled in the domain capabilities even with old QEMU. The issue was reported in https://bugzilla.redhat.com/show_bug.cgi?id=1426456 Jiri Denemark (7): Do not format <arch> in guest CPU XML cpu: Replace cpuNodeData with virCPUGetHost cpu: Add virCPUType parameter to virCPUGetHost cpu: Add list of allowed CPU models to virCPUGetHost qemu: Refactor virQEMUCapsInitCPU qemu: Report better host-model CPUs in domain caps cputest: New test for Intel Core i7-4510U src/bhyve/bhyve_capabilities.c | 35 +--- src/conf/cpu_conf.c | 2 +- src/cpu/cpu.c | 100 ++++++++-- src/cpu/cpu.h | 16 +- src/cpu/cpu_arm.c | 1 - src/cpu/cpu_ppc64.c | 30 +-- src/cpu/cpu_s390.c | 1 - src/cpu/cpu_x86.c | 29 ++- src/libvirt_private.syms | 2 +- src/qemu/qemu_capabilities.c | 61 +++---- src/qemu/qemu_capspriv.h | 5 + src/vmware/vmware_conf.c | 20 +- src/vz/vz_driver.c | 22 +-- tests/Makefile.am | 11 +- tests/cputest.c | 1 + tests/cputestdata/x86_64-cpuid-A10-5800K-guest.xml | 1 - tests/cputestdata/x86_64-cpuid-A10-5800K-json.xml | 1 - tests/cputestdata/x86_64-cpuid-Atom-D510-guest.xml | 1 - tests/cputestdata/x86_64-cpuid-Atom-N450-guest.xml | 1 - .../x86_64-cpuid-Core-i5-2500-guest.xml | 1 - .../cputestdata/x86_64-cpuid-Core-i5-2500-json.xml | 1 - .../x86_64-cpuid-Core-i5-2540M-guest.xml | 1 - .../x86_64-cpuid-Core-i5-2540M-json.xml | 1 - .../x86_64-cpuid-Core-i5-4670T-guest.xml | 1 - .../x86_64-cpuid-Core-i5-4670T-json.xml | 1 - .../x86_64-cpuid-Core-i5-6600-guest.xml | 1 - .../cputestdata/x86_64-cpuid-Core-i5-6600-json.xml | 1 - .../x86_64-cpuid-Core-i7-2600-guest.xml | 1 - .../cputestdata/x86_64-cpuid-Core-i7-2600-json.xml | 1 - .../x86_64-cpuid-Core-i7-3520M-guest.xml | 1 - .../x86_64-cpuid-Core-i7-3740QM-guest.xml | 1 - .../x86_64-cpuid-Core-i7-3740QM-json.xml | 1 - .../x86_64-cpuid-Core-i7-3770-guest.xml | 1 - .../cputestdata/x86_64-cpuid-Core-i7-3770-json.xml | 1 - .../x86_64-cpuid-Core-i7-4510U-guest.xml | 29 +++ .../x86_64-cpuid-Core-i7-4510U-host.xml | 44 +++++ .../x86_64-cpuid-Core-i7-4510U-json.xml | 15 ++ tests/cputestdata/x86_64-cpuid-Core-i7-4510U.json | 203 +++++++++++++++++++++ tests/cputestdata/x86_64-cpuid-Core-i7-4510U.xml | 34 ++++ .../x86_64-cpuid-Core-i7-4600U-guest.xml | 1 - .../x86_64-cpuid-Core-i7-4600U-json.xml | 1 - .../x86_64-cpuid-Core-i7-5600U-guest.xml | 1 - .../x86_64-cpuid-Core-i7-5600U-json.xml | 1 - .../cputestdata/x86_64-cpuid-Core2-E6850-guest.xml | 1 - .../cputestdata/x86_64-cpuid-Core2-E6850-json.xml | 1 - .../cputestdata/x86_64-cpuid-Core2-Q9500-guest.xml | 1 - tests/cputestdata/x86_64-cpuid-FX-8150-guest.xml | 1 - .../x86_64-cpuid-Opteron-1352-guest.xml | 1 - .../x86_64-cpuid-Opteron-2350-guest.xml | 1 - .../cputestdata/x86_64-cpuid-Opteron-2350-json.xml | 1 - .../x86_64-cpuid-Opteron-6234-guest.xml | 1 - .../cputestdata/x86_64-cpuid-Opteron-6234-json.xml | 1 - .../x86_64-cpuid-Opteron-6282-guest.xml | 1 - .../x86_64-cpuid-Pentium-P6100-guest.xml | 1 - .../cputestdata/x86_64-cpuid-Phenom-B95-guest.xml | 1 - tests/cputestdata/x86_64-cpuid-Phenom-B95-json.xml | 1 - tests/cputestdata/x86_64-cpuid-Xeon-5110-guest.xml | 1 - .../x86_64-cpuid-Xeon-E3-1245-guest.xml | 1 - .../cputestdata/x86_64-cpuid-Xeon-E3-1245-json.xml | 1 - .../x86_64-cpuid-Xeon-E5-2630-guest.xml | 1 - .../cputestdata/x86_64-cpuid-Xeon-E5-2630-json.xml | 1 - .../x86_64-cpuid-Xeon-E5-2650-guest.xml | 1 - .../cputestdata/x86_64-cpuid-Xeon-E5-2650-json.xml | 1 - .../x86_64-cpuid-Xeon-E7-4820-guest.xml | 1 - .../cputestdata/x86_64-cpuid-Xeon-E7-4820-json.xml | 1 - .../x86_64-cpuid-Xeon-E7-8890-guest.xml | 1 - .../cputestdata/x86_64-cpuid-Xeon-W3520-guest.xml | 1 - tests/cputestdata/x86_64-cpuid-Xeon-W3520-json.xml | 1 - .../cputestdata/x86_64-cpuid-Xeon-X5460-guest.xml | 1 - tests/domaincapstest.c | 6 + tests/qemucpumock.c | 35 ++++ tests/qemuxml2argvtest.c | 6 +- 72 files changed, 560 insertions(+), 197 deletions(-) create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-4510U-guest.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-4510U-host.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-4510U-json.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-4510U.json create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-4510U.xml create mode 100644 tests/qemucpumock.c -- 2.12.0

2 8

[libvirt] [PATCH] qemuDomainBuildNamespace: Handle file mount points
by Michal Privoznik 13 Mar '17

13 Mar '17

https://bugzilla.redhat.com/show_bug.cgi?id=1431112 Yeah, that's right. A mount point doesn't have to be a directory. It can be a file too. However, the code that tries to preserve mount points under /dev for new namespace for qemu does not count with that option. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_domain.c | 37 +++++++++++++++++++++++++++++++++---- 1 file changed, 33 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index d5833b026..07ce22417 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -7741,10 +7741,21 @@ qemuDomainBuildNamespace(virQEMUDriverConfigPtr cfg, /* Save some mount points because we want to share them with the host */ for (i = 0; i < ndevMountsPath; i++) { + struct stat sb; + if (devMountsSavePath[i] == devPath) continue; - if (virFileMakePath(devMountsSavePath[i]) < 0) { + if (stat(devMountsPath[i], &sb) < 0) { + virReportSystemError(errno, + _("Unable to stat: %s"), + devMountsPath[i]); + goto cleanup; + } + + /* At this point, devMountsPath is either a regular file or a directory. */ + if ((S_ISDIR(sb.st_mode) && virFileMakePath(devMountsSavePath[i]) < 0) || + (S_ISREG(sb.st_mode) && virFileTouch(devMountsSavePath[i], sb.st_mode) < 0)) { virReportSystemError(errno, _("Failed to create %s"), devMountsSavePath[i]); @@ -7780,15 +7791,33 @@ qemuDomainBuildNamespace(virQEMUDriverConfigPtr cfg, goto cleanup; for (i = 0; i < ndevMountsPath; i++) { + struct stat sb; + if (devMountsSavePath[i] == devPath) continue; - if (virFileMakePath(devMountsPath[i]) < 0) { - virReportSystemError(errno, _("Cannot create %s"), - devMountsPath[i]); + if (stat(devMountsSavePath[i], &sb) < 0) { + virReportSystemError(errno, + _("Unable to stat: %s"), + devMountsSavePath[i]); goto cleanup; } + if (S_ISDIR(sb.st_mode)) { + if (virFileMakePath(devMountsPath[i]) < 0) { + virReportSystemError(errno, _("Cannot create %s"), + devMountsPath[i]); + goto cleanup; + } + } else { + if (virFileMakeParentPath(devMountsPath[i]) < 0 || + virFileTouch(devMountsPath[i], sb.st_mode) < 0) { + virReportSystemError(errno, _("Cannot create %s"), + devMountsPath[i]); + goto cleanup; + } + } + if (virFileMoveMount(devMountsSavePath[i], devMountsPath[i]) < 0) goto cleanup; } -- 2.11.0

2 1

[libvirt] [PATCH] Enable forgotten VIR_CONNECT_LIST_STORAGE_POOLS_* flags
by Jiri Denemark 13 Mar '17

13 Mar '17

VIR_CONNECT_LIST_STORAGE_POOLS_VSTORAGE and VIR_CONNECT_LIST_STORAGE_POOLS_ZFS were added to libvirt but the listing API was not properly updated to use them. https://bugzilla.redhat.com/show_bug.cgi?id=1431543 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/conf/storage_conf.c | 6 +++++- src/conf/storage_conf.h | 3 ++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index a52eeba07..3cfaf2b9b 100644 --- a/src/conf/storage_conf.c +++ b/src/conf/storage_conf.c @@ -2671,7 +2671,11 @@ virStoragePoolMatch(virStoragePoolObjPtr poolobj, (MATCH(VIR_CONNECT_LIST_STORAGE_POOLS_SHEEPDOG) && (poolobj->def->type == VIR_STORAGE_POOL_SHEEPDOG)) || (MATCH(VIR_CONNECT_LIST_STORAGE_POOLS_GLUSTER) && - (poolobj->def->type == VIR_STORAGE_POOL_GLUSTER)))) + (poolobj->def->type == VIR_STORAGE_POOL_GLUSTER)) || + (MATCH(VIR_CONNECT_LIST_STORAGE_POOLS_ZFS) && + poolobj->def->type == VIR_STORAGE_POOL_ZFS) || + (MATCH(VIR_CONNECT_LIST_STORAGE_POOLS_VSTORAGE) && + poolobj->def->type == VIR_STORAGE_POOL_VSTORAGE))) return false; } diff --git a/src/conf/storage_conf.h b/src/conf/storage_conf.h index 1723afc0a..c3a88d284 100644 --- a/src/conf/storage_conf.h +++ b/src/conf/storage_conf.h @@ -544,7 +544,8 @@ VIR_ENUM_DECL(virStoragePartedFs) VIR_CONNECT_LIST_STORAGE_POOLS_RBD | \ VIR_CONNECT_LIST_STORAGE_POOLS_SHEEPDOG | \ VIR_CONNECT_LIST_STORAGE_POOLS_GLUSTER | \ - VIR_CONNECT_LIST_STORAGE_POOLS_ZFS) + VIR_CONNECT_LIST_STORAGE_POOLS_ZFS | \ + VIR_CONNECT_LIST_STORAGE_POOLS_VSTORAGE) # define VIR_CONNECT_LIST_STORAGE_POOLS_FILTERS_ALL \ (VIR_CONNECT_LIST_STORAGE_POOLS_FILTERS_ACTIVE | \ -- 2.12.0

2 1

[libvirt] [PATCH 7/7] docs: moved 'timestamps' and 'encryption' sub-element description in formatstorage doc
by Alexander Vasilenko 12 Mar '17

12 Mar '17

--- docs/formatstorage.html.in | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in index c787a059d..225e19000 100644 --- a/docs/formatstorage.html.in +++ b/docs/formatstorage.html.in @@ -456,24 +456,6 @@ will be filled with the values used by the existing directory. <span class="since">Since 1.2.16</span> </dd> - <dt><code>timestamps</code></dt> - <dd>Provides timing information about the volume. Up to four - sub-elements are present, - where <code>atime</code>, <code>btime</code>, <code>ctime</code> - and <code>mtime</code> hold the access, birth, change and - modification time of the volume, where known. The used time - format is <seconds>.<nanoseconds> since the - beginning of the epoch (1 Jan 1970). If nanosecond resolution - is 0 or otherwise unsupported by the host OS or filesystem, - then the nanoseconds part is omitted. This is a readonly - attribute and is ignored when creating a volume. - <span class="since">Since 0.10.0</span> - </dd> - <dt><code>encryption</code></dt> - <dd>If present, specifies how the volume is encrypted. See - the <a href="formatstorageencryption.html">Storage Encryption</a> page - for more information. - </dd> </dl> <h3><a name="StoragePoolExtents">Device extents</a></h3> @@ -658,6 +640,24 @@ will be filled with the values used by the existing file. <span class="since">Since 0.4.1</span> </dd> + <dt><code>timestamps</code></dt> + <dd>Provides timing information about the volume. Up to four + sub-elements are present, + where <code>atime</code>, <code>btime</code>, <code>ctime</code> + and <code>mtime</code> hold the access, birth, change and + modification time of the volume, where known. The used time + format is <seconds>.<nanoseconds> since the + beginning of the epoch (1 Jan 1970). If nanosecond resolution + is 0 or otherwise unsupported by the host OS or filesystem, + then the nanoseconds part is omitted. This is a readonly + attribute and is ignored when creating a volume. + <span class="since">Since 0.10.0</span> + </dd> + <dt><code>encryption</code></dt> + <dd>If present, specifies how the volume is encrypted. See + the <a href="formatstorageencryption.html">Storage Encryption</a> page + for more information. + </dd> <dt><code>compat</code></dt> <dd>Specify compatibility level. So far, this is only used for <code>type='qcow2'</code> volumes. Valid values are <code>0.10</code> -- 2.12.0

1 0

[libvirt] [PATCH 0/6] bhyve UEFI and graphics support
by Roman Bogorodskiy 12 Mar '17

12 Mar '17

Fabian Freyer (5): bhyve: virBhyveProbeCaps: BHYVE_CAP_LPC_BOOTROM bhyve: add support for booting from UEFI bhyve: test cases for UEFI bhyvexml2argvtest bhyve: enumerate UEFI firmwares bhyve: add video support Roman Bogorodskiy (1): bhyve: test cases for VNC docs/formatdomain.html.in | 3 +- docs/schemas/domaincommon.rng | 1 + po/POTFILES.in | 1 + src/bhyve/bhyve_capabilities.c | 93 ++++++++++++++++ src/bhyve/bhyve_capabilities.h | 2 + src/bhyve/bhyve_command.c | 130 +++++++++++++++++++++- src/bhyve/bhyve_device.c | 11 ++ src/bhyve/bhyve_driver.c | 27 ++++- src/bhyve/bhyve_process.c | 55 ++++----- src/conf/domain_conf.c | 5 +- src/conf/domain_conf.h | 1 + src/qemu/qemu_command.c | 9 +- src/qemu/qemu_domain_address.c | 1 + tests/bhyvexml2argvdata/bhyvexml2argv-uefi.args | 11 ++ tests/bhyvexml2argvdata/bhyvexml2argv-uefi.ldargs | 1 + tests/bhyvexml2argvdata/bhyvexml2argv-uefi.xml | 23 ++++ tests/bhyvexml2argvdata/bhyvexml2argv-vnc.args | 12 ++ tests/bhyvexml2argvdata/bhyvexml2argv-vnc.ldargs | 1 + tests/bhyvexml2argvdata/bhyvexml2argv-vnc.xml | 26 +++++ tests/bhyvexml2argvtest.c | 18 ++- tests/domaincapsschemadata/full.xml | 1 + 21 files changed, 394 insertions(+), 38 deletions(-) create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-uefi.args create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-uefi.ldargs create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-uefi.xml create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-vnc.args create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-vnc.ldargs create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-vnc.xml -- 2.11.0

4 18

[libvirt] [PATCH] virt-host-validate: add bhyve support
by Roman Bogorodskiy 11 Mar '17

11 Mar '17

Add bhyve support to virt-host-validate(1). It checks for the essential kernel modules to be available so that user can actually start VMs, have networking and console access. It uses the kldnext(2)/kldstat(2) routines to retrieve modules list. As bhyve is only available on FreeBSD and these routines were available long before bhyve appeared, not adding any specific configure checks for that. --- po/POTFILES.in | 1 + tools/Makefile.am | 1 + tools/virt-host-validate-bhyve.c | 78 ++++++++++++++++++++++++++++++++++++++++ tools/virt-host-validate-bhyve.h | 27 ++++++++++++++ tools/virt-host-validate.c | 12 +++++++ tools/virt-host-validate.pod | 4 +-- 6 files changed, 121 insertions(+), 2 deletions(-) create mode 100644 tools/virt-host-validate-bhyve.c create mode 100644 tools/virt-host-validate-bhyve.h diff --git a/po/POTFILES.in b/po/POTFILES.in index 9f66697d7..51b5859cb 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -306,6 +306,7 @@ tools/virsh-snapshot.c tools/virsh-volume.c tools/virsh.c tools/virt-admin.c +tools/virt-host-validate-bhyve.c tools/virt-host-validate-common.c tools/virt-host-validate-lxc.c tools/virt-host-validate-qemu.c diff --git a/tools/Makefile.am b/tools/Makefile.am index e6ae15025..a8bd3d1c2 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -142,6 +142,7 @@ virt_host_validate_SOURCES = \ virt-host-validate-common.c virt-host-validate-common.h \ virt-host-validate-qemu.c virt-host-validate-qemu.h \ virt-host-validate-lxc.c virt-host-validate-lxc.h \ + virt-host-validate-bhyve.c virt-host-validate-bhyve.h \ $(NULL) virt_host_validate_LDFLAGS = \ diff --git a/tools/virt-host-validate-bhyve.c b/tools/virt-host-validate-bhyve.c new file mode 100644 index 000000000..c7bf96f05 --- /dev/null +++ b/tools/virt-host-validate-bhyve.c @@ -0,0 +1,78 @@ +/* + * virt-host-validate-bhyve.c: Sanity check a bhyve hypervisor host + * + * Copyright (C) 2017 Roman Bogorodskiy + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + */ + +#include <config.h> + +#include <sys/param.h> +#include <sys/linker.h> +#include <stdio.h> + +#include "virt-host-validate-bhyve.h" +#include "virt-host-validate-common.h" + +#define MODULE_STATUS(mod, err_msg, err_code) \ + virHostMsgCheck("BHYVE", _("for %s module"), #mod); \ + if (mod ## _loaded) { \ + virHostMsgPass(); \ + } else { \ + virHostMsgFail(err_code, \ + _("%s module is not loaded, " err_msg), \ + #mod); \ + ret = -1; \ + } \ + +#define MODULE_STATUS_FAIL(mod, err_msg) \ + MODULE_STATUS(mod, err_msg, VIR_HOST_VALIDATE_FAIL) + +#define MODULE_STATUS_WARN(mod, err_msg) \ + MODULE_STATUS(mod, err_msg, VIR_HOST_VALIDATE_WARN) + + +int virHostValidateBhyve(void) +{ + int ret = 0; + int fileid = 0; + struct kld_file_stat stat; + bool vmm_loaded = false, if_tap_loaded = false; + bool if_bridge_loaded = false, nmdm_loaded = false; + + for (fileid = kldnext(0); fileid > 0; fileid = kldnext(fileid)) { + stat.version = sizeof(struct kld_file_stat); + if (kldstat(fileid, &stat) < 0) + continue; + + if (STREQ(stat.name, "vmm.ko")) + vmm_loaded = true; + else if (STREQ(stat.name, "if_tap.ko")) + if_tap_loaded = true; + else if (STREQ(stat.name, "if_bridge.ko")) + if_bridge_loaded = true; + else if (STREQ(stat.name, "nmdm.ko")) + nmdm_loaded = true; + } + + MODULE_STATUS_FAIL(vmm, "will not be able to start VMs"); + MODULE_STATUS_WARN(if_tap, "networking will not work"); + MODULE_STATUS_WARN(if_bridge, "bridged networking will not work"); + MODULE_STATUS_WARN(nmdm, "nmdm console will not work"); + + return ret; +} diff --git a/tools/virt-host-validate-bhyve.h b/tools/virt-host-validate-bhyve.h new file mode 100644 index 000000000..290d4336f --- /dev/null +++ b/tools/virt-host-validate-bhyve.h @@ -0,0 +1,27 @@ +/* + * virt-host-validate-bhyve.h: Sanity check a bhyve hypervisor host + * + * Copyright (C) 2017 Roman Bogorodskiy + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + */ + +#ifndef __VIRT_HOST_VALIDATE_BHYVE_H__ +# define __VIRT_HOST_VALIDATE_BHYVE_H__ + +int virHostValidateBhyve(void); + +#endif /* __VIRT_HOST_VALIDATE_BHYVE_H__ */ diff --git a/tools/virt-host-validate.c b/tools/virt-host-validate.c index f09282412..29d2482b6 100644 --- a/tools/virt-host-validate.c +++ b/tools/virt-host-validate.c @@ -36,6 +36,9 @@ #if WITH_LXC # include "virt-host-validate-lxc.h" #endif +#if WITH_BHYVE +# include "virt-host-validate-bhyve.h" +#endif static void show_help(FILE *out, const char *argv0) @@ -48,6 +51,7 @@ show_help(FILE *out, const char *argv0) "\n" " - qemu\n" " - lxc\n" + " - bhyve\n" "\n" " Options:\n" " -h, --help Display command line help\n" @@ -130,6 +134,14 @@ main(int argc, char **argv) } #endif +#if WITH_BHYVE + if (!hvname || STREQ(hvname, "bhyve")) { + usedHvname = true; + if (virHostValidateBhyve() < 0) + ret = EXIT_FAILURE; + } +#endif + if (hvname && !usedHvname) { fprintf(stderr, _("%s: unsupported hypervisor name %s\n"), argv[0], hvname); diff --git a/tools/virt-host-validate.pod b/tools/virt-host-validate.pod index 84917c83b..910114175 100644 --- a/tools/virt-host-validate.pod +++ b/tools/virt-host-validate.pod @@ -12,8 +12,8 @@ This tool validates that the host is configured in a suitable way to run libvirt hypervisor drivers. If invoked without any arguments it will check support for all hypervisor drivers it is aware of. Optionally it can be given a particular hypervisor -type ('qemu' or 'lxc') to restrict the checks to those relevant -for that virtualization technology +type ('qemu', 'lxc' or 'bhyve') to restrict the checks +to those relevant for that virtualization technology =head1 OPTIONS -- 2.11.0

2 2

[libvirt] [REPOST PATCHv2 0/6] Converge Storage Pool vHBA logic with Node Device
by John Ferlan 10 Mar '17

10 Mar '17

Repost to merge in recent changes (thru commit id 'dec6d9df') v1: http://www.redhat.com/archives/libvir-list/2017-February/msg00963.html Changes since v1: NB: Former Patch 1 - was pushed Patch 1 - Was the old patch 2... Similar for rest of series... Altered to match the adjusted testNodeDeviceMockCreateVport from commit 2a862092 Patch 2 - reworked the code to not place the new module in src/util, but rather in src/conf as storage_adapter_conf.{c,h}. The concepts didn't change - only the name/location. Removed the changes for util/virvirscsi.c since virSCSIHostGetNameByParentaddr wouldn't be allowed to use virStorageAdapterSCSIHostPtr since it's a conf definition. Patch 3 - Unchanged, ACK'd in v1 Patch 4 - Unchanged, ACK'd in v1 Patch 5 - Unchanged... Even though there is concern over usage of API's in this manner (e.g. calling virNodeDeviceLookupSCSIHostByWWN as well as virNodeDeviceCreateXML) - the "purpose" of the exercise is a means to have the StoragePool code use the same algorithms as the node device code instead of what could be a potentially long slow journey through the sysfs file system. The key piece being the replication of the API's that find the parent in the node device object list. I suppose it would be possible to add even more API's to get that answer, but I'm not sure it'd be worthwhile at this point. As for the concern about deadlock - I understand it, but since the whole purpose of the API is to essentially utilize the nodedev create algorithm there'd be no reason for nodedev to call it. If it doesn't get ACK'd - that's OK - I can hold onto it and reconsider some other means at some point in time in the future (probably distant future too). Patch 6 - Unchanged The former patch 8 is dropped for now - needs some more "discussion" as to viability and/or need. John Ferlan (6): tests: Add createVHBAByStoragePool-by-parent to fchosttest conf: Convert virStoragePoolSourceAdapter to virStorageAdapter util: Rename virFileWaitForDevices conf: Move/rename createVport and deleteVport util: Alter virNodeDevice{Create|Delete}Vport to use nodedev APIs tests: Add more storage pool vHBA tests po/POTFILES.in | 1 + src/Makefile.am | 1 + src/conf/node_device_conf.c | 332 +++++++++++++++++++++++++++++++++ src/conf/node_device_conf.h | 9 + src/conf/storage_adapter_conf.c | 291 +++++++++++++++++++++++++++++ src/conf/storage_adapter_conf.h | 89 +++++++++ src/conf/storage_conf.c | 333 ++++++++-------------------------- src/conf/storage_conf.h | 35 +--- src/libvirt_private.syms | 20 +- src/node_device/node_device_driver.c | 2 +- src/phyp/phyp_driver.c | 3 +- src/storage/storage_backend_disk.c | 6 +- src/storage/storage_backend_iscsi.c | 2 +- src/storage/storage_backend_logical.c | 4 +- src/storage/storage_backend_mpath.c | 2 +- src/storage/storage_backend_scsi.c | 267 +++++---------------------- src/storage/storage_util.c | 2 +- src/test/test_driver.c | 99 +++++++++- src/util/virfile.h | 2 - src/util/virutil.c | 4 +- src/util/virutil.h | 2 + tests/fchosttest.c | 111 ++++++++++++ 22 files changed, 1087 insertions(+), 530 deletions(-) create mode 100644 src/conf/storage_adapter_conf.c create mode 100644 src/conf/storage_adapter_conf.h -- 2.9.3

2 9

[libvirt] [PATCH for-2.9 v3 0/3] Use non-blacklisted family/model/stepping for Haswell CPU model
by Eduardo Habkost 10 Mar '17

10 Mar '17

I plan to merge this bug fix into 2.9. Changes v2 -> v3: * Rebase to latest master * Don't touch max_x86_cpu_initfn() to reduce risk post hard freeze Changes v1 -> v2: * Coding style fixes * Make series simpler: * Don't use trick: char vendor[static (CPUID_VENDOR_SZ + 1)] because it confuses checkpatch.pl * Removed patch "Add explicit array size to x86_cpu_vendor_words2str()" * Rebased on top of my x86-next branch: https://github.com/ehabkost/qemu x86-next Git branch for testing: https://github.com/ehabkost/qemu-hacks work/x86-rtm-blacklist Diff from v1: diff --git a/target/i386/cpu.h b/target/i386/cpu.h index cd94726e43..647435a1d9 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -1431,7 +1431,7 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, uint32_t count, void cpu_clear_apic_feature(CPUX86State *env); void host_cpuid(uint32_t function, uint32_t count, uint32_t *eax, uint32_t *ebx, uint32_t *ecx, uint32_t *edx); -void host_vendor_fms(char vendor[static (CPUID_VENDOR_SZ + 1)], int *family, int *model, int *stepping); +void host_vendor_fms(char *vendor, int *family, int *model, int *stepping); /* helper.c */ int x86_cpu_handle_mmu_fault(CPUState *cpu, vaddr addr, diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 25c6c5e115..eab1ad7935 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -682,7 +682,7 @@ void host_cpuid(uint32_t function, uint32_t count, *edx = vec[3]; } -void host_vendor_fms(char vendor[static (CPUID_VENDOR_SZ + 1)], int *family, int *model, int *stepping) +void host_vendor_fms(char *vendor, int *family, int *model, int *stepping) { uint32_t eax, ebx, ecx, edx; @@ -1570,7 +1570,8 @@ static void host_x86_cpu_class_init(ObjectClass *oc, void *data) xcc->kvm_required = true; xcc->ordering = 9; - host_vendor_fms(host_cpudef.vendor, &host_cpudef.family, &host_cpudef.model, &host_cpudef.stepping); + host_vendor_fms(host_cpudef.vendor, &host_cpudef.family, + &host_cpudef.model, &host_cpudef.stepping); cpu_x86_fill_model_id(host_cpudef.model_id); --- A recent glibc commit[1] added a blacklist to ensure it won't use TSX on hosts that are known to have a broken TSX implementation. Our existing Haswell CPU model has a blacklisted family/model/stepping combination, so it has to be updated to make sure guests will really use TSX. This is done by patch 5/5. However, to do this safely we need to ensure the host CPU is not a blacklisted one, so we won't mislead guests by exposing known-to-be-good FMS values on a known-to-be-broken host. This is done by patch 3/5. [1] https://sourceware.org/git/?p=glibc.git;a=commit;h=2702856bf45c82cf8e69f206… --- Cc: dgilbert(a)redhat.com Cc: fweimer(a)redhat.com Cc: carlos(a)redhat.com Cc: triegel(a)redhat.com Cc: berrange(a)redhat.com Cc: jdenemar(a)redhat.com Cc: pbonzini(a)redhat.com Eduardo Habkost (3): i386: host_vendor_fms() helper function i386/kvm: Blacklist TSX on known broken hosts i386: Change stepping of Haswell to non-blacklisted value include/hw/i386/pc.h | 5 +++++ target/i386/cpu.h | 1 + target/i386/cpu.c | 21 ++++++++++++++++++++- target/i386/kvm.c | 17 +++++++++++++++++ 4 files changed, 43 insertions(+), 1 deletion(-) -- 2.11.0.259.g40922b1

1 4

[libvirt] [PATCH v3] Document preferred naming conventions
by Daniel P. Berrange 10 Mar '17

10 Mar '17

This documents the preferred conventions for naming files, structs, enums, typedefs and functions. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- Changed in v3: - Clarify function naming wrt verb & subject - Simplify macro naming, since in practice libvirt code doesn't follow any rules consistently aside from having a VIR_ prefix. HACKING | 80 ++++++++++++++++++++++++++++++++++++++++++++ docs/hacking.html.in | 93 ++++++++++++++++++++++++++++++++++++++++++++++++++++ docs/hacking2.xsl | 4 +++ 3 files changed, 177 insertions(+) diff --git a/HACKING b/HACKING index fff003b..2c65985 100644 --- a/HACKING +++ b/HACKING @@ -239,6 +239,86 @@ on the subject, on Richard Jones' guide to working with open source projects <http://people.redhat.com/rjones/how-to-supply-code-to-open-source-projects/>. +Naming conventions +================== +When reading libvirt code, a number of different naming conventions will be +evident due to various changes in thinking over the course of the project's +lifetime. The conventions documented below should be followed when creating +any entirely new files in libvirt. When working on existing files, while it is +desirable to apply these conventions, keeping a consistent style with existing +code in that particular file is generally more important. The overall guiding +principal is that every file, enum, struct, function, macro and typedef name +must have a 'vir' or 'VIR' prefix. All local scope variable names are exempt, +and global variables are exempt, unless exported in a header file. + +*File names* + +File naming varies depending on the subdirectory. The preferred style is to +have a 'vir' prefix, followed by a name which matches the name of the +functions / objects inside the file. For example, a file containing an object +'virHashtable' is stored in files 'virhashtable.c' and 'virhashtable.h'. +Sometimes, methods which would otherwise be declared 'static' need to be +exported for use by a test suite. For this purpose a second header file should +be added with a suffix of 'priv'. e.g. 'virhashtablepriv.h'. Use of +underscores in file names is discouraged when using the 'vir' prefix style. +The 'vir' prefix naming applies to src/util, src/rpc and tests/ directories. +Most other directories do not follow this convention. + + + +*Enum type & field names* + +All enums should have a 'vir' prefix in their typedef name, and each following +word should have its first letter in uppercase. The enum name should match the +typedef name with a leading underscore. The enum member names should be in all +uppercase, and use an underscore to separate each word. The enum member name +prefix should match the enum typedef name. + + typedef enum _virSocketType virSocketType; + enum _virSocketType { + VIR_SOCKET_TYPE_IPV4, + VIR_SOCKET_TYPE_IPV6, + }; + + +*Struct type names* + +All structs should have a 'vir' prefix in their typedef name, and each +following word should have its first letter in uppercase. The struct name +should be the same as the typedef name with a leading underscore. A second +typedef should be given for a pointer to the struct with a 'Ptr' suffix. + + typedef struct _virHashTable virHashTable; + typedef virHashTable *virHashTablePtr; + struct _virHashTable { + ... + }; + + +*Function names* + +All functions should have a 'vir' prefix in their name, followed by one or +more words with first letter of each word capitalized. Underscores should not +be used in function names. If the function is operating on an object, then the +function name prefix should match the object typedef name, otherwise it should +match the filename. Following this comes the verb / action name, and finally +an optional subject name. For example, given an object 'virHashTable', all +functions should have a name 'virHashTable$VERB' or +'virHashTable$VERB$SUBJECT". e.g. 'virHashTableLookup' or +'virHashTableGetValue'. + + + +*Macro names* + +All macros should have a "VIR" prefix in their name, followed by one or more +uppercase words separated by underscores. The macro argument names should be +in lowercase. Aside from having a "VIR" prefix there are no common practices +for the rest of the macro name. + + + + Code indentation ================ Libvirt's C source code generally adheres to some basic code-formatting diff --git a/docs/hacking.html.in b/docs/hacking.html.in index b1bb149..d904c3a 100644 --- a/docs/hacking.html.in +++ b/docs/hacking.html.in @@ -314,6 +314,99 @@ Richard Jones' guide to working with open source projects</a>. </p> + <h2><a name="naming">Naming conventions</a></h2> + + <p> + When reading libvirt code, a number of different naming conventions will + be evident due to various changes in thinking over the course of the + project's lifetime. The conventions documented below should be followed + when creating any entirely new files in libvirt. When working on existing + files, while it is desirable to apply these conventions, keeping a + consistent style with existing code in that particular file is generally + more important. The overall guiding principal is that every file, enum, + struct, function, macro and typedef name must have a 'vir' or 'VIR' prefix. + All local scope variable names are exempt, and global variables are exempt, + unless exported in a header file. + </p> + + <dl> + <dt>File names</dt> + <dd> + <p> + File naming varies depending on the subdirectory. The preferred + style is to have a 'vir' prefix, followed by a name which matches + the name of the functions / objects inside the file. For example, + a file containing an object 'virHashtable' is stored in files + 'virhashtable.c' and 'virhashtable.h'. Sometimes, methods which + would otherwise be declared 'static' need to be exported for use + by a test suite. For this purpose a second header file should be + added with a suffix of 'priv'. e.g. 'virhashtablepriv.h'. Use of + underscores in file names is discouraged when using the 'vir' + prefix style. The 'vir' prefix naming applies to src/util, + src/rpc and tests/ directories. Most other directories do not + follow this convention. + </p> + </dd> + <dt>Enum type & field names</dt> + <dd> + <p> + All enums should have a 'vir' prefix in their typedef name, + and each following word should have its first letter in + uppercase. The enum name should match the typedef name with + a leading underscore. The enum member names should be in all + uppercase, and use an underscore to separate each word. The + enum member name prefix should match the enum typedef name. + </p> + <pre> + typedef enum _virSocketType virSocketType; + enum _virSocketType { + VIR_SOCKET_TYPE_IPV4, + VIR_SOCKET_TYPE_IPV6, + };</pre> + </dd> + <dt>Struct type names</dt> + <dd> + <p> + All structs should have a 'vir' prefix in their typedef name, + and each following word should have its first letter in + uppercase. The struct name should be the same as the typedef + name with a leading underscore. A second typedef should be + given for a pointer to the struct with a 'Ptr' suffix. + </p> + <pre> + typedef struct _virHashTable virHashTable; + typedef virHashTable *virHashTablePtr; + struct _virHashTable { + ... + };</pre> + </dd> + <dt>Function names</dt> + <dd> + <p> + All functions should have a 'vir' prefix in their name, + followed by one or more words with first letter of each + word capitalized. Underscores should not be used in function + names. If the function is operating on an object, then the + function name prefix should match the object typedef name, + otherwise it should match the filename. Following this + comes the verb / action name, and finally an optional + subject name. For example, given an object 'virHashTable', + all functions should have a name 'virHashTable$VERB' or + 'virHashTable$VERB$SUBJECT". e.g. 'virHashTableLookup' + or 'virHashTableGetValue'. + </p> + </dd> + <dt>Macro names</dt> + <dd> + <p> + All macros should have a "VIR" prefix in their name, followed + by one or more uppercase words separated by underscores. The + macro argument names should be in lowercase. Aside from having + a "VIR" prefix there are no common practices for the rest of + the macro name. + </p> + </dd> + </dl> <h2><a name="indent">Code indentation</a></h2> <p> diff --git a/docs/hacking2.xsl b/docs/hacking2.xsl index 3595b7e..7e5ac82 100644 --- a/docs/hacking2.xsl +++ b/docs/hacking2.xsl @@ -114,6 +114,10 @@ from docs/hacking.html.in! <xsl:template match="html:li/html:ul/html:li">-- <xsl:apply-templates/><xsl:value-of select="$newline"/><xsl:value-of select="$newline"/> </xsl:template> +<xsl:template match="html:dl/html:dt">*<xsl:apply-templates/>*<xsl:value-of select="$newline"/><xsl:value-of select="$newline"/> +</xsl:template> +<xsl:template match="html:dl/html:dd"><xsl:apply-templates/><xsl:value-of select="$newline"/><xsl:value-of select="$newline"/> +</xsl:template>  -- 2.9.3

5 7

[libvirt] [PATCH] qemuProcessHandleMonitorEOF: Disable namespace for domain
by Michal Privoznik 10 Mar '17

10 Mar '17

https://bugzilla.redhat.com/show_bug.cgi?id=1430634 If a qemu process has died, we get EOF on its monitor. At this point, since qemu process was the only one running in the namespace kernel has already cleaned the namespace up. Any attempt of ours to enter it has to fail. This really happened in the bug linked above. We've tried to attach a disk to qemu and while we were in the monitor talking to qemu it just died. Therefore our code tried to do some roll back (e.g. deny the device in cgroups again, restore labels, etc.). However, during the roll back (esp. when restoring labels) we still thought that domain has a namespace. So we used secdriver's transactions. This failed as there is no namespace to enter. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_domain.c | 25 +++++++++++++++++++++++++ src/qemu/qemu_domain.h | 3 +++ src/qemu/qemu_process.c | 4 ++++ 3 files changed, 32 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 1a42fcf1b..d5833b026 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -201,6 +201,22 @@ qemuDomainEnableNamespace(virDomainObjPtr vm, } +static void +qemuDomainDisableNamespace(virDomainObjPtr vm, + qemuDomainNamespace ns) +{ + qemuDomainObjPrivatePtr priv = vm->privateData; + + if (priv->namespaces) { + ignore_value(virBitmapClearBit(priv->namespaces, ns)); + if (virBitmapIsAllClear(priv->namespaces)) { + virBitmapFree(priv->namespaces); + priv->namespaces = NULL; + } + } +} + + void qemuDomainEventQueue(virQEMUDriverPtr driver, virObjectEventPtr event) { @@ -7805,6 +7821,15 @@ qemuDomainCreateNamespace(virQEMUDriverPtr driver, } +void +qemuDomainDestroyNamespace(virQEMUDriverPtr driver ATTRIBUTE_UNUSED, + virDomainObjPtr vm) +{ + if (qemuDomainNamespaceEnabled(vm, QEMU_DOMAIN_NS_MOUNT)) + qemuDomainDisableNamespace(vm, QEMU_DOMAIN_NS_MOUNT); +} + + bool qemuDomainNamespaceAvailable(qemuDomainNamespace ns ATTRIBUTE_UNUSED) { diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index 7fa717390..c646828e6 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -816,6 +816,9 @@ int qemuDomainBuildNamespace(virQEMUDriverConfigPtr cfg, int qemuDomainCreateNamespace(virQEMUDriverPtr driver, virDomainObjPtr vm); +void qemuDomainDestroyNamespace(virQEMUDriverPtr driver, + virDomainObjPtr vm); + bool qemuDomainNamespaceAvailable(qemuDomainNamespace ns); int qemuDomainNamespaceSetupDisk(virQEMUDriverPtr driver, diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index fcba7d309..b9c1847bb 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -314,6 +314,10 @@ qemuProcessHandleMonitorEOF(qemuMonitorPtr mon ATTRIBUTE_UNUSED, */ qemuMonitorUnregister(mon); + /* We don't want any cleanup from EOF handler (or any other + * thread) to enter qemu namespace. */ + qemuDomainDestroyNamespace(driver, vm); + cleanup: virObjectUnlock(vm); } -- 2.11.0

2 2

[libvirt] [PATCH] qemuxml2argvtest: Don't overwrite driver stateDir
by Michal Privoznik 10 Mar '17

10 Mar '17

This is a very historic artefact. Back in the old days of 830ba76c3e when we had macros to add arguments onto qemu command line (!) we thought it was a good idea to let qemu write out the PID file. So we passed -pidfile $stateDir/$domName onto the command line. Thus, in order for tests to work we needed stable stateDir in the qemu driver. Unfortunately, after 16efa11aa696 where stateDir is mkdtemp()-d, this approach lead to a leak of temp dir. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tests/qemuxml2argvtest.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index d2d267fce..00b0e25cd 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -581,9 +581,6 @@ mymain(void) if (VIR_STRDUP_QUIET(driver.config->chardevTLSx509certdir, "/etc/pki/libvirt-chardev") < 0) return EXIT_FAILURE; - VIR_FREE(driver.config->stateDir); - if (VIR_STRDUP_QUIET(driver.config->stateDir, "/nowhere") < 0) - return EXIT_FAILURE; VIR_FREE(driver.config->hugetlbfs); if (VIR_ALLOC_N(driver.config->hugetlbfs, 2) < 0) return EXIT_FAILURE; -- 2.11.0

2 1

[libvirt] [PATCH 0/2] qemu: properly handle delayed vCPU hotunplug
by Peter Krempa 10 Mar '17

10 Mar '17

Patch 1 would help in debugging this issue. Patch 2 fixes the bug. Peter Krempa (2): qemu: hotplug: Add debug log when dispatching device removal to existing thread qemu: hotplug: Reset device removal waiting code after vCPU unplug src/qemu/qemu_hotplug.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) -- 2.12.0

3 6

[libvirt] [RFC PATCH 0/2] qemu: Fix ACPI on aarch64
by Andrea Bolognani 09 Mar '17

09 Mar '17

Posted as RFC due to the concerns outlined in patch 1. Andrea Bolognani (2): qemu: Advertise ACPI support for aarch64 guests tests: Initialize basic capabilities properly src/qemu/qemu_capabilities.c | 30 +++++++++++++++++----- .../caps_2.6.0-gicv2.aarch64.xml | 1 + .../caps_2.6.0-gicv3.aarch64.xml | 1 + .../qemuxml2argv-balloon-ccw-deflate.args | 1 - .../qemuxml2argv-console-sclp.args | 1 - .../qemuxml2argv-console-virtio-ccw.args | 1 - .../qemuxml2argv-console-virtio-s390.args | 1 - .../qemuxml2argv-cpu-s390-features.args | 1 - .../qemuxml2argv-cpu-s390-zEC12.args | 1 - .../qemuxml2argv-disk-virtio-ccw-many.args | 1 - .../qemuxml2argv-disk-virtio-ccw.args | 1 - .../qemuxml2argv-disk-virtio-s390.args | 1 - .../qemuxml2argv-disk-virtio-scsi-ccw.args | 1 - tests/qemuxml2argvdata/qemuxml2argv-fs9p-ccw.args | 1 - .../qemuxml2argv-hostdev-scsi-vhost-scsi-ccw.args | 1 - .../qemuxml2argv-hugepages-numa.args | 1 + .../qemuxml2argv-iothreads-disk-virtio-ccw.args | 1 - .../qemuxml2argv-iothreads-virtio-scsi-ccw.args | 1 - .../qemuxml2argv-machine-aeskeywrap-off-cap.args | 1 - .../qemuxml2argv-machine-aeskeywrap-off-caps.args | 1 - .../qemuxml2argv-machine-aeskeywrap-on-cap.args | 1 - .../qemuxml2argv-machine-aeskeywrap-on-caps.args | 1 - .../qemuxml2argv-machine-deakeywrap-off-cap.args | 1 - .../qemuxml2argv-machine-deakeywrap-off-caps.args | 1 - .../qemuxml2argv-machine-deakeywrap-on-cap.args | 1 - .../qemuxml2argv-machine-deakeywrap-on-caps.args | 1 - .../qemuxml2argv-machine-keywrap-none-caps.args | 1 - .../qemuxml2argv-machine-keywrap-none.args | 1 - .../qemuxml2argv-memory-hotplug-ppc64-nonuma.args | 1 - .../qemuxml2argv-net-virtio-ccw.args | 1 - .../qemuxml2argv-net-virtio-s390.args | 1 - tests/qemuxml2argvdata/qemuxml2argv-ppc-dtb.args | 1 - .../qemuxml2argv-ppce500-serial.args | 1 - .../qemuxml2argv-pseries-basic.args | 1 - .../qemuxml2argv-pseries-cpu-compat.args | 1 - .../qemuxml2argv-pseries-cpu-exact.args | 1 - .../qemuxml2argv-pseries-cpu-le.args | 1 - .../qemuxml2argv-pseries-nvram.args | 1 - .../qemuxml2argv-pseries-panic-missing.args | 1 - .../qemuxml2argv-pseries-panic-no-address.args | 1 - .../qemuxml2argv-pseries-usb-default.args | 1 - .../qemuxml2argv-pseries-usb-kbd.args | 1 - .../qemuxml2argv-pseries-usb-multi.args | 1 - .../qemuxml2argv-pseries-vio-user-assigned.args | 1 - .../qemuxml2argvdata/qemuxml2argv-pseries-vio.args | 1 - .../qemuxml2argv-q35-virt-manager-basic.args | 1 + ...muxml2argv-s390-allow-bogus-usb-controller.args | 1 - .../qemuxml2argv-s390-allow-bogus-usb-none.args | 1 - .../qemuxml2argv-s390-panic-missing.args | 1 - .../qemuxml2argv-s390-panic-no-address.args | 1 - .../qemuxml2argv-virtio-rng-ccw.args | 1 - .../qemuxml2argv-watchdog-diag288.args | 1 - tests/qemuxml2argvtest.c | 16 ++++++++++-- 53 files changed, 41 insertions(+), 56 deletions(-) -- 2.7.4

3 9

[libvirt] [PATCH v2] Revert "conf: move iothread XML validation from qemu_command"
by Pavel Hrdina 09 Mar '17

09 Mar '17

This reverts commit c96bd78e4e71c799dc391566fa9f0652dec55dca. So our code is one big mess and we modify domain definition while building qemu_command line and our hotplug code share only part of the parsing and command line building code. Let's revert that change because to fix it properly would require refactor and move a lot of things. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1430275 --- src/conf/domain_conf.c | 62 ++------------------------------ src/qemu/qemu_command.c | 96 +++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 99 insertions(+), 59 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index a58f997621..569becb99d 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -4737,8 +4737,7 @@ virDomainDiskAddressDiskBusCompatibility(virDomainDiskBus bus, static int -virDomainDiskDefValidate(const virDomainDef *def, - const virDomainDiskDef *disk) +virDomainDiskDefValidate(const virDomainDiskDef *disk) { /* Validate LUN configuration */ if (disk->device == VIR_DOMAIN_DISK_DEVICE_LUN) { @@ -4768,24 +4767,6 @@ virDomainDiskDefValidate(const virDomainDef *def, return -1; } - if (disk->iothread > 0) { - if (disk->bus != VIR_DOMAIN_DISK_BUS_VIRTIO || - (disk->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI && - disk->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("IOThreads are only available for virtio pci and " - "virtio ccw disk")); - return -1; - } - - if (!virDomainIOThreadIDFind(def, disk->iothread)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("Invalid IOThread id '%u' for disk '%s'"), - disk->iothread, disk->dst); - return -1; - } - } - return 0; } @@ -4837,47 +4818,12 @@ virDomainNetDefValidate(const virDomainNetDef *net) static int -virDomainControllerDefValidate(const virDomainDef *def, - const virDomainControllerDef *cont) -{ - if (cont->iothread > 0) { - if (cont->type != VIR_DOMAIN_CONTROLLER_TYPE_SCSI || - cont->model != VIR_DOMAIN_CONTROLLER_MODEL_SCSI_VIRTIO_SCSI) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("IOThreads are only supported for virtio-scsi " - "controllers, model is '%s'"), - virDomainControllerModelSCSITypeToString(cont->model)); - return -1; - } - - if (cont->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI && - cont->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("IOThreads are only available for virtio pci and " - "virtio ccw controllers")); - return -1; - } - - if (!virDomainIOThreadIDFind(def, cont->iothread)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("Invalid IOThread id '%u' for controller '%s'"), - cont->iothread, - virDomainControllerTypeToString(cont->type)); - return -1; - } - } - - return 0; -} - - -static int virDomainDeviceDefValidateInternal(const virDomainDeviceDef *dev, const virDomainDef *def) { switch ((virDomainDeviceType) dev->type) { case VIR_DOMAIN_DEVICE_DISK: - return virDomainDiskDefValidate(def, dev->data.disk); + return virDomainDiskDefValidate(dev->data.disk); case VIR_DOMAIN_DEVICE_REDIRDEV: return virDomainRedirdevDefValidate(def, dev->data.redirdev); @@ -4885,9 +4831,6 @@ virDomainDeviceDefValidateInternal(const virDomainDeviceDef *dev, case VIR_DOMAIN_DEVICE_NET: return virDomainNetDefValidate(dev->data.net) - case VIR_DOMAIN_DEVICE_CONTROLLER: - return virDomainControllerDefValidate(def, dev->data.controller); - case VIR_DOMAIN_DEVICE_LEASE: case VIR_DOMAIN_DEVICE_FS: case VIR_DOMAIN_DEVICE_INPUT: @@ -4895,6 +4838,7 @@ virDomainDeviceDefValidateInternal(const virDomainDeviceDef *dev, case VIR_DOMAIN_DEVICE_VIDEO: case VIR_DOMAIN_DEVICE_HOSTDEV: case VIR_DOMAIN_DEVICE_WATCHDOG: + case VIR_DOMAIN_DEVICE_CONTROLLER: case VIR_DOMAIN_DEVICE_GRAPHICS: case VIR_DOMAIN_DEVICE_HUB: case VIR_DOMAIN_DEVICE_SMARTCARD: diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 6545a93259..145a0127f2 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -1871,6 +1871,49 @@ qemuBuildDriveStr(virDomainDiskDefPtr disk, } +static bool +qemuCheckIOThreads(const virDomainDef *def, + virDomainDiskDefPtr disk) +{ + /* Right "type" of disk" */ + switch ((virDomainDiskBus)disk->bus) { + case VIR_DOMAIN_DISK_BUS_VIRTIO: + if (disk->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI && + disk->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("IOThreads only available for virtio pci and " + "virtio ccw disk")); + return false; + } + break; + + case VIR_DOMAIN_DISK_BUS_IDE: + case VIR_DOMAIN_DISK_BUS_FDC: + case VIR_DOMAIN_DISK_BUS_SCSI: + case VIR_DOMAIN_DISK_BUS_XEN: + case VIR_DOMAIN_DISK_BUS_USB: + case VIR_DOMAIN_DISK_BUS_UML: + case VIR_DOMAIN_DISK_BUS_SATA: + case VIR_DOMAIN_DISK_BUS_SD: + case VIR_DOMAIN_DISK_BUS_LAST: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("IOThreads not available for bus %s target %s"), + virDomainDiskBusTypeToString(disk->bus), disk->dst); + return false; + } + + /* Can we find the disk iothread in the iothreadid list? */ + if (!virDomainIOThreadIDFind(def, disk->iothread)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Disk iothread '%u' not defined in iothreadid"), + disk->iothread); + return false; + } + + return true; +} + + char * qemuBuildDriveDevStr(const virDomainDef *def, virDomainDiskDefPtr disk, @@ -1889,6 +1932,9 @@ qemuBuildDriveDevStr(const virDomainDef *def, if (!qemuCheckCCWS390AddressSupport(def, disk->info, qemuCaps, disk->dst)) goto error; + if (disk->iothread && !qemuCheckIOThreads(def, disk)) + goto error; + switch (disk->bus) { case VIR_DOMAIN_DISK_BUS_IDE: if (disk->info.addr.drive.target != 0) { @@ -2521,6 +2567,52 @@ qemuBuildUSBControllerDevStr(virDomainControllerDefPtr def, } +/* qemuCheckSCSIControllerIOThreads: + * @domainDef: Pointer to domain def + * @def: Pointer to controller def + * @qemuCaps: Capabilities + * + * If this controller definition has iothreads set, let's make sure the + * configuration is right before adding to the command line + * + * Returns true if either supported or there are no iothreads for controller; + * otherwise, returns false if configuration is not quite right. + */ +static bool +qemuCheckSCSIControllerIOThreads(const virDomainDef *domainDef, + virDomainControllerDefPtr def) +{ + if (!def->iothread) + return true; + + if (def->model != VIR_DOMAIN_CONTROLLER_MODEL_SCSI_VIRTIO_SCSI) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("IOThreads only supported for virtio-scsi " + "controllers model is '%s'"), + virDomainControllerModelSCSITypeToString(def->model)); + return false; + } + + if (def->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI && + def->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("IOThreads only available for virtio pci and " + "virtio ccw controllers")); + return false; + } + + /* Can we find the controller iothread in the iothreadid list? */ + if (!virDomainIOThreadIDFind(domainDef, def->iothread)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("controller iothread '%u' not defined in iothreadid"), + def->iothread); + return false; + } + + return true; +} + + char * qemuBuildControllerDevStr(const virDomainDef *domainDef, virDomainControllerDefPtr def, @@ -2571,6 +2663,8 @@ qemuBuildControllerDevStr(const virDomainDef *domainDef, if (def->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW) { virBufferAddLit(&buf, "virtio-scsi-ccw"); if (def->iothread) { + if (!qemuCheckSCSIControllerIOThreads(domainDef, def)) + goto error; virBufferAsprintf(&buf, ",iothread=iothread%u", def->iothread); } @@ -2583,6 +2677,8 @@ qemuBuildControllerDevStr(const virDomainDef *domainDef, } else { virBufferAddLit(&buf, "virtio-scsi-pci"); if (def->iothread) { + if (!qemuCheckSCSIControllerIOThreads(domainDef, def)) + goto error; virBufferAsprintf(&buf, ",iothread=iothread%u", def->iothread); } -- 2.12.0

2 1

[libvirt] Revisiting qemu monitor timeout on VM start
by Jim Fehlig 09 Mar '17

09 Mar '17

Hi All, Encountering a qemu monitor timeout when starting a VM has been discussed here before, e.g. https://www.redhat.com/archives/libvir-list/2014-January/msg00060.html https://www.redhat.com/archives/libvir-list/2014-January/msg00408.html Recently I've received reports of the same when starting large memory VMs backed by 1G huge pages. In one of the reports, Matt timed how long it takes to allocate 402GB worth of hugetlbfs pages (these are 1G pages, but the time is similar for 2M): real 105.47 user 0.05 sys 105.42 The time is spent entirely in the kernel zero'ing pages and as you can see it exceeds the 30 second monitor timeout in libvirt. Do folks have any suggestions on how to avoid the timeout? Obviously one solution is to introduce a knob in qemu.conf to control the timeout, as was proposed in the above threads. Another solution that came to mind is changing qemu to open the monitor earlier, making it available while the kernel is off scrubbing pages. I'm not familiar enough with qemu code to know if such a change is possible, but given the amount of initialization done in main() prior to calling mon_init_func(), my confidence in this idea is low. Perhaps someone more familiar with qemu initialization can comment on that. Thanks in advance for comments on these ideas or alternate proposals! Regards, Jim

3 2

[libvirt] [PATCH] configure: disable scsi stroage driver on non-Linux
by Roman Bogorodskiy 09 Mar '17

09 Mar '17

Even though scsi storage driver builds fine on non-Linux, it will not work properly because it relies on Linux procfs, so disable that in configure if we're not building for Linux. --- configure.ac | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.ac b/configure.ac index e61ab7ba6..cf50422d5 100644 --- a/configure.ac +++ b/configure.ac @@ -192,6 +192,7 @@ if test $with_linux = no; then with_lxc=no fi with_dtrace=no + with_storage_scsi=no fi if test $with_freebsd = yes; then -- 2.11.0

2 2

[libvirt] [PATCH v2 00/14] Introduce NVDIMM support
by Michal Privoznik 09 Mar '17

09 Mar '17

v2 of: https://www.redhat.com/archives/libvir-list/2017-February/msg01229.html How to test this feature? $ > /tmp/nvdimm $ truncate --size 512M /tmp/nvdimm $ virsh edit $mydom <memory model='nvdimm' access='shared'> <source> <path>/tmp/nvdimm</path> </source> <target> <size unit='MiB'>512</size> <node>0</node> <label> <size unit='KiB'>128</size> </label> </target> <address type='dimm' slot='0'/> </memory> $ virsh start $mydom $ ssh $mydom "echo \"Hello world\" > /dev/pmem0" $ hexdump -C /tmp/nvdimm 00000000 48 65 6c 6c 6f 20 77 6f 72 6c 64 0a 00 00 00 00 |Hello world.....| 00000010 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| * 20000000 Michal Privoznik (14): qemuBuildMemoryBackendStr: Reorder args and update comment Introduce NVDIMM memory model qemu: Introduce QEMU_CAPS_DEVICE_NVDIMM qemu: Implement NVDIMM conf: Introduce @access to <memory/> qemu: Implement @access for <memory/> banks qemu: Introduce label-size for NVDIMMs security_dac: Label host side of NVDIMM security_selinux: Label host side of NVDIMM security: Introduce internal APIs for memdev labelling secdrivers: Implement memdev relabel APIs qemu_hotplug: Relabel memdev qemu: Allow nvdimm in devices CGroups qemu: Namespaces for NVDIMM docs/formatdomain.html.in | 79 ++++++++--- docs/schemas/domaincommon.rng | 47 +++++-- src/conf/domain_conf.c | 131 +++++++++++++---- src/conf/domain_conf.h | 5 + src/libvirt_private.syms | 2 + src/qemu/qemu_alias.c | 10 +- src/qemu/qemu_capabilities.c | 9 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_cgroup.c | 49 +++++++ src/qemu/qemu_cgroup.h | 4 + src/qemu/qemu_command.c | 155 +++++++++++++++------ src/qemu/qemu_command.h | 16 ++- src/qemu/qemu_domain.c | 105 +++++++++++++- src/qemu/qemu_domain.h | 8 ++ src/qemu/qemu_hotplug.c | 42 +++++- src/qemu/qemu_security.c | 56 ++++++++ src/qemu/qemu_security.h | 8 ++ src/security/security_dac.c | 76 ++++++++++ src/security/security_driver.h | 9 ++ src/security/security_manager.c | 56 ++++++++ src/security/security_manager.h | 7 + src/security/security_nop.c | 19 +++ src/security/security_selinux.c | 69 +++++++++ src/security/security_stack.c | 38 +++++ .../qemuxml2argv-memory-hotplug-nvdimm-access.args | 26 ++++ .../qemuxml2argv-memory-hotplug-nvdimm-access.xml | 56 ++++++++ .../qemuxml2argv-memory-hotplug-nvdimm-label.args | 26 ++++ .../qemuxml2argv-memory-hotplug-nvdimm-label.xml | 59 ++++++++ .../qemuxml2argv-memory-hotplug-nvdimm.args | 26 ++++ .../qemuxml2argv-memory-hotplug-nvdimm.xml | 56 ++++++++ tests/qemuxml2argvtest.c | 8 +- ...qemuxml2xmlout-memory-hotplug-nvdimm-access.xml | 1 + .../qemuxml2xmlout-memory-hotplug-nvdimm-label.xml | 1 + .../qemuxml2xmlout-memory-hotplug-nvdimm.xml | 1 + tests/qemuxml2xmltest.c | 3 + 35 files changed, 1144 insertions(+), 120 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-nvdimm-access.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-nvdimm-access.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-nvdimm-label.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-nvdimm-label.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-nvdimm.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-nvdimm.xml create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-memory-hotplug-nvdimm-access.xml create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-memory-hotplug-nvdimm-label.xml create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-memory-hotplug-nvdimm.xml -- 2.11.0

2 37

[libvirt] [PATCH] domain_conf: move iothread check for address type back to qemu_command
by Pavel Hrdina 09 Mar '17

09 Mar '17

This partially reverts commit c96bd78e4e. If an API virDomainAttachDevice(Flags) is used the device address is assigned after the validation and the address type may not be set. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1430275 Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/conf/domain_conf.c | 18 ++++-------------- src/qemu/qemu_command.c | 22 ++++++++++++++++++++++ 2 files changed, 26 insertions(+), 14 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 97d42fe993..747706e673 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -4769,12 +4769,10 @@ virDomainDiskDefValidate(const virDomainDef *def, } if (disk->iothread > 0) { - if (disk->bus != VIR_DOMAIN_DISK_BUS_VIRTIO || - (disk->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI && - disk->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("IOThreads are only available for virtio pci and " - "virtio ccw disk")); + if (disk->bus != VIR_DOMAIN_DISK_BUS_VIRTIO) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("IOThreads are not available for bus '%s', disk '%s'"), + virDomainDiskBusTypeToString(disk->bus), disk->dst); return -1; } @@ -4850,14 +4848,6 @@ virDomainControllerDefValidate(const virDomainDef *def, return -1; } - if (cont->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI && - cont->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("IOThreads are only available for virtio pci and " - "virtio ccw controllers")); - return -1; - } - if (!virDomainIOThreadIDFind(def, cont->iothread)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("Invalid IOThread id '%u' for controller '%s'"), diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 6545a93259..b49242a7df 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -1871,6 +1871,21 @@ qemuBuildDriveStr(virDomainDiskDefPtr disk, } +static int +qemuBuildCheckIOThreadAddress(virDomainDeviceInfo info) +{ + if (info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI && + info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("IOThreads are only available for virtio pci and " + "virtio ccw")); + return -1; + } + + return 0; +} + + char * qemuBuildDriveDevStr(const virDomainDef *def, virDomainDiskDefPtr disk, @@ -1889,6 +1904,9 @@ qemuBuildDriveDevStr(const virDomainDef *def, if (!qemuCheckCCWS390AddressSupport(def, disk->info, qemuCaps, disk->dst)) goto error; + if (disk->iothread > 0 && qemuBuildCheckIOThreadAddress(disk->info) < 0) + goto error; + switch (disk->bus) { case VIR_DOMAIN_DISK_BUS_IDE: if (disk->info.addr.drive.target != 0) { @@ -2571,6 +2589,8 @@ qemuBuildControllerDevStr(const virDomainDef *domainDef, if (def->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW) { virBufferAddLit(&buf, "virtio-scsi-ccw"); if (def->iothread) { + if (qemuBuildCheckIOThreadAddress(def->info) < 0) + goto error; virBufferAsprintf(&buf, ",iothread=iothread%u", def->iothread); } @@ -2583,6 +2603,8 @@ qemuBuildControllerDevStr(const virDomainDef *domainDef, } else { virBufferAddLit(&buf, "virtio-scsi-pci"); if (def->iothread) { + if (qemuBuildCheckIOThreadAddress(def->info) < 0) + goto error; virBufferAsprintf(&buf, ",iothread=iothread%u", def->iothread); } -- 2.12.0

2 1

[libvirt] [PATCH] doc updates
by Philipp Hahn 09 Mar '17

09 Mar '17

3 13

[libvirt] Making containers creation easy
by Cedric Bosdonnat 09 Mar '17

09 Mar '17

Hi all, I've worked on making the containers rootfs creation easy. Here is a wrap-up of my work: http://bosdonnat.fr/system-container-images.html Any opinion on that? Anything to do to move it forward? -- Cedric

3 4

[libvirt] [PATCH v2 0/2] fix migration related graphics listen code bugs
by Pavel Hrdina 09 Mar '17

09 Mar '17

Pavel Hrdina (2): conf: store "autoGenerated" for graphics listen in status XML conf: properly skip graphics listen element in migratable XML src/conf/domain_conf.c | 20 +++++++++++++++++++- src/qemu/qemu_domain.c | 3 ++- 2 files changed, 21 insertions(+), 2 deletions(-) -- 2.12.0

2 3

[libvirt] [PATCH v2 00/10] perf: Add software perf events
by Nitesh Konkar 09 Mar '17

09 Mar '17

This patch series adds software perf events. The perl and go patches shall follow shortly. Nitesh Konkar (10): perf: add cpu_clock software perf event support perf: add task_clock software perf event support perf: add page_faults software perf event support perf: add context_switches software perf event support perf: add cpu_migrations software perf event support perf: add page_faults_min software perf event support perf: add page_faults_maj software perf event support perf: add alignment_faults software perf event support perf: add emulation_faults software perf event support news: Update the news.xml about perf events added docs/formatdomain.html.in | 74 +++++++++++++++++++++++ docs/news.xml | 11 ++++ docs/schemas/domaincommon.rng | 9 +++ include/libvirt/libvirt-domain.h | 92 +++++++++++++++++++++++++++++ src/libvirt-domain.c | 25 ++++++++ src/qemu/qemu_driver.c | 9 +++ src/util/virperf.c | 33 ++++++++++- src/util/virperf.h | 9 +++ tests/genericxml2xmlindata/generic-perf.xml | 9 +++ tools/virsh.pod | 27 +++++++++ 10 files changed, 297 insertions(+), 1 deletion(-) -- 1.9.3

3 14

[libvirt] [PATCH 0/2] fix migration related graphics listen code bugs
by Pavel Hrdina 09 Mar '17

09 Mar '17

Pavel Hrdina (2): conf: store "autoGenerated" for graphics listen in status XML conf: properly skip graphics listen element in migratable XML src/conf/domain_conf.c | 18 +++++++++++++++++- src/qemu/qemu_domain.c | 3 ++- 2 files changed, 19 insertions(+), 2 deletions(-) -- 2.11.1

2 3

[libvirt] ANNOUNCE: virt-manager 1.4.1 released
by Cole Robinson 09 Mar '17

09 Mar '17

I'm happy to announce the release of virt-manager 1.4.1! virt-manager is a desktop application for managing KVM, Xen, and LXC virtualization via libvirt. The release can be downloaded from: http://virt-manager.org/download/ This release includes: - storage/nodedev event API support (Jovanka Gulicoska) - UI options for enabling spice GL (Marc-André Lureau) - Add default virtio-rng /dev/urandom for supported guest OS - Cloning and rename support for UEFI VMs (Pavel Hrdina) - libguestfs inspection UI improvements (Pino Toscano) - virt-install: Add --qemu-commandline - virt-install: Add --network vhostuser (Chen Hanxiao) - virt-install: Add --sysinfo (Charles Arnold) Thanks to everyone who has contributed to this release through testing, bug reporting, submitting patches, and otherwise sending in feedback! Thanks, Cole

1 0

[libvirt] [PATCH] qemu: Rename variable
by John Ferlan 08 Mar '17

08 Mar '17

Rename 'secretUsageType' to 'usageType' since it's superfluous in an API qemu*Secret* Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Pushed as trivial - based upon Jirka's review comment from patch 1 of the "Alter TLS/UUID algorithms to be a bit more generic" series. src/qemu/qemu_domain.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index bffb8ac..4d184d3 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -965,7 +965,7 @@ qemuDomainChrSourcePrivateDispose(void *obj) /* qemuDomainSecretPlainSetup: * @conn: Pointer to connection * @secinfo: Pointer to secret info - * @secretUsageType: The virSecretUsageType + * @usageType: The virSecretUsageType * @username: username to use for authentication (may be NULL) * @seclookupdef: Pointer to seclookupdef data * @@ -976,7 +976,7 @@ qemuDomainChrSourcePrivateDispose(void *obj) static int qemuDomainSecretPlainSetup(virConnectPtr conn, qemuDomainSecretInfoPtr secinfo, - virSecretUsageType secretUsageType, + virSecretUsageType usageType, const char *username, virSecretLookupTypeDefPtr seclookupdef) { @@ -984,7 +984,7 @@ qemuDomainSecretPlainSetup(virConnectPtr conn, if (VIR_STRDUP(secinfo->s.plain.username, username) < 0) return -1; - return virSecretGetSecretString(conn, seclookupdef, secretUsageType, + return virSecretGetSecretString(conn, seclookupdef, usageType, &secinfo->s.plain.secret, &secinfo->s.plain.secretlen); } @@ -995,7 +995,7 @@ qemuDomainSecretPlainSetup(virConnectPtr conn, * @priv: pointer to domain private object * @secinfo: Pointer to secret info * @srcalias: Alias of the disk/hostdev used to generate the secret alias - * @secretUsageType: The virSecretUsageType + * @usageType: The virSecretUsageType * @username: username to use for authentication (may be NULL) * @seclookupdef: Pointer to seclookupdef data * @isLuks: True/False for is for luks (alias generation) @@ -1009,7 +1009,7 @@ qemuDomainSecretAESSetup(virConnectPtr conn, qemuDomainObjPrivatePtr priv, qemuDomainSecretInfoPtr secinfo, const char *srcalias, - virSecretUsageType secretUsageType, + virSecretUsageType usageType, const char *username, virSecretLookupTypeDefPtr seclookupdef, bool isLuks) @@ -1038,7 +1038,7 @@ qemuDomainSecretAESSetup(virConnectPtr conn, goto cleanup; /* Grab the unencoded secret */ - if (virSecretGetSecretString(conn, seclookupdef, secretUsageType, + if (virSecretGetSecretString(conn, seclookupdef, usageType, &secret, &secretlen) < 0) goto cleanup; @@ -1072,7 +1072,7 @@ qemuDomainSecretAESSetup(virConnectPtr conn, * @priv: pointer to domain private object * @secinfo: Pointer to secret info * @srcalias: Alias of the disk/hostdev used to generate the secret alias - * @secretUsageType: The virSecretUsageType + * @usageType: The virSecretUsageType * @username: username to use for authentication (may be NULL) * @seclookupdef: Pointer to seclookupdef data * @isLuks: True when is luks (generates different alias) @@ -1089,22 +1089,22 @@ qemuDomainSecretSetup(virConnectPtr conn, qemuDomainObjPrivatePtr priv, qemuDomainSecretInfoPtr secinfo, const char *srcalias, - virSecretUsageType secretUsageType, + virSecretUsageType usageType, const char *username, virSecretLookupTypeDefPtr seclookupdef, bool isLuks) { if (virCryptoHaveCipher(VIR_CRYPTO_CIPHER_AES256CBC) && virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_OBJECT_SECRET) && - (secretUsageType == VIR_SECRET_USAGE_TYPE_CEPH || - secretUsageType == VIR_SECRET_USAGE_TYPE_VOLUME || - secretUsageType == VIR_SECRET_USAGE_TYPE_TLS)) { + (usageType == VIR_SECRET_USAGE_TYPE_CEPH || + usageType == VIR_SECRET_USAGE_TYPE_VOLUME || + usageType == VIR_SECRET_USAGE_TYPE_TLS)) { if (qemuDomainSecretAESSetup(conn, priv, secinfo, srcalias, - secretUsageType, username, + usageType, username, seclookupdef, isLuks) < 0) return -1; } else { - if (qemuDomainSecretPlainSetup(conn, secinfo, secretUsageType, + if (qemuDomainSecretPlainSetup(conn, secinfo, usageType, username, seclookupdef) < 0) return -1; } @@ -1253,14 +1253,14 @@ qemuDomainSecretDiskPrepare(virConnectPtr conn, qemuDomainDiskPrivatePtr diskPriv = QEMU_DOMAIN_DISK_PRIVATE(disk); if (qemuDomainSecretDiskCapable(src)) { - virSecretUsageType secretUsageType = VIR_SECRET_USAGE_TYPE_ISCSI; + virSecretUsageType usageType = VIR_SECRET_USAGE_TYPE_ISCSI; if (src->protocol == VIR_STORAGE_NET_PROTOCOL_RBD) - secretUsageType = VIR_SECRET_USAGE_TYPE_CEPH; + usageType = VIR_SECRET_USAGE_TYPE_CEPH; if (!(diskPriv->secinfo = qemuDomainSecretInfoNew(conn, priv, disk->info.alias, - secretUsageType, src->auth->username, + usageType, src->auth->username, &src->auth->seclookupdef, false))) return -1; } -- 2.9.3

1 0

[libvirt] [PATCH] tests: Add storagevol tests for format=iso
by Cole Robinson 08 Mar '17

08 Mar '17

Demonstrates the bug fix in commit 0e5db762627 --- tests/storagevolxml2argvdata/iso-input.argv | 1 + tests/storagevolxml2argvdata/iso.argv | 1 + tests/storagevolxml2argvtest.c | 7 +++++++ tests/storagevolxml2xmlin/vol-file-iso.xml | 10 ++++++++++ tests/storagevolxml2xmlout/vol-file-iso.xml | 11 +++++++++++ tests/storagevolxml2xmltest.c | 1 + 6 files changed, 31 insertions(+) create mode 100644 tests/storagevolxml2argvdata/iso-input.argv create mode 100644 tests/storagevolxml2argvdata/iso.argv create mode 100644 tests/storagevolxml2xmlin/vol-file-iso.xml create mode 100644 tests/storagevolxml2xmlout/vol-file-iso.xml diff --git a/tests/storagevolxml2argvdata/iso-input.argv b/tests/storagevolxml2argvdata/iso-input.argv new file mode 100644 index 0000000..333d7e6 --- /dev/null +++ b/tests/storagevolxml2argvdata/iso-input.argv @@ -0,0 +1 @@ +qemu-img convert -f raw -O raw /var/lib/libvirt/images/test.iso /var/lib/libvirt/images/sparse.img \ No newline at end of file diff --git a/tests/storagevolxml2argvdata/iso.argv b/tests/storagevolxml2argvdata/iso.argv new file mode 100644 index 0000000..40b99c5 --- /dev/null +++ b/tests/storagevolxml2argvdata/iso.argv @@ -0,0 +1 @@ +qemu-img create -f raw /var/lib/libvirt/images/test.iso 1024K \ No newline at end of file diff --git a/tests/storagevolxml2argvtest.c b/tests/storagevolxml2argvtest.c index bf9dbe5..24c3bac 100644 --- a/tests/storagevolxml2argvtest.c +++ b/tests/storagevolxml2argvtest.c @@ -272,6 +272,13 @@ mymain(void) "pool-dir", "vol-qcow2-nocapacity-backing", NULL, NULL, "qcow2-nocapacity", 0, FMT_OPTIONS); + DO_TEST("pool-dir", "vol-file-iso", + NULL, NULL, + "iso", 0, FMT_OPTIONS); + DO_TEST("pool-dir", "vol-file", + "pool-dir", "vol-file-iso", + "iso-input", 0, FMT_OPTIONS); + return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } diff --git a/tests/storagevolxml2xmlin/vol-file-iso.xml b/tests/storagevolxml2xmlin/vol-file-iso.xml new file mode 100644 index 0000000..b1f0756 --- /dev/null +++ b/tests/storagevolxml2xmlin/vol-file-iso.xml @@ -0,0 +1,10 @@ +<volume> + <name>test.iso</name> + <source/> + <capacity unit="MiB">1</capacity> + <allocation unit="MiB">1</allocation> + <target> + <format type='iso'/> + <path>/var/lib/libvirt/images/test.iso</path> + </target> +</volume> diff --git a/tests/storagevolxml2xmlout/vol-file-iso.xml b/tests/storagevolxml2xmlout/vol-file-iso.xml new file mode 100644 index 0000000..9783124 --- /dev/null +++ b/tests/storagevolxml2xmlout/vol-file-iso.xml @@ -0,0 +1,11 @@ +<volume type='file'> + <name>test.iso</name> + <source> + </source> + <capacity unit='bytes'>1048576</capacity> + <allocation unit='bytes'>1048576</allocation> + <target> + <path>/var/lib/libvirt/images/test.iso</path> + <format type='iso'/> + </target> +</volume> diff --git a/tests/storagevolxml2xmltest.c b/tests/storagevolxml2xmltest.c index db82bea..18e8016 100644 --- a/tests/storagevolxml2xmltest.c +++ b/tests/storagevolxml2xmltest.c @@ -100,6 +100,7 @@ mymain(void) DO_TEST("pool-dir", "vol-file"); DO_TEST("pool-dir", "vol-file-naming"); DO_TEST("pool-dir", "vol-file-backing"); + DO_TEST("pool-dir", "vol-file-iso"); DO_TEST("pool-dir", "vol-qcow2"); DO_TEST("pool-dir", "vol-qcow2-1.1"); DO_TEST("pool-dir", "vol-qcow2-lazy"); -- 2.9.3

2 1

[libvirt] [PATCH] Make use of PERF_COUNT_HW_REF_CPU_CYCLES conditional
by Daniel P. Berrange 08 Mar '17

08 Mar '17

The PERF_COUNT_HW_REF_CPU_CYCLES constant is not available on all Linux distros libvirt targets, so its use must be made conditional. Other constant have existed long enough that we can assume they exist, as we don't support very old distros like RHEL-5 any more. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- src/util/virperf.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/util/virperf.c b/src/util/virperf.c index 49ec258..f64692b 100644 --- a/src/util/virperf.c +++ b/src/util/virperf.c @@ -104,8 +104,14 @@ static struct virPerfEventAttr attrs[] = { .attrType = PERF_TYPE_HARDWARE, .attrConfig = PERF_COUNT_HW_STALLED_CYCLES_BACKEND}, {.type = VIR_PERF_EVENT_REF_CPU_CYCLES, +# ifdef PERF_COUNT_HW_REF_CPU_CYCLES .attrType = PERF_TYPE_HARDWARE, - .attrConfig = PERF_COUNT_HW_REF_CPU_CYCLES}, + .attrConfig = PERF_COUNT_HW_REF_CPU_CYCLES +# else + .attrType = 0, + .attrConfig = 0, +# endif + }, }; typedef struct virPerfEventAttr *virPerfEventAttrPtr; -- 2.9.3

2 2

[libvirt] [PATCH v3 0/8] Alter TLS/UUID algorithms to be a bit more generic
by John Ferlan 08 Mar '17

08 Mar '17

This is a *split* from the v2 series for migration TLS. I figure what's here may be useful for the Veritas code... The most recent qemu patches ar using TLS, which means when the libvirt patches are updated they'll need similar type support. v2: http://www.redhat.com/archives/libvir-list/2017-February/msg01374.html Adjustments here are mainly in patch 2 which is new - the former patch2 is migrate TLS specific so it's moved later, but not in this series. The patch2 here does the TLS setup with the UUID. Essentially the end result is creation of a TLS/UUID secret info setup API and the splitting of the hotplug code for chardev to allow creation of TLS objects. John Ferlan (8): qemu: Introduce qemuDomainSecretInfoNew qemu: Introduce qemuDomainSecretInfoTLSNew qemu: Move exit monitor calls in failure paths qemu: Refactor hotplug to introduce qemuDomain{Add|Del}TLSObjects qemu: Refactor qemuDomainGetChardevTLSObjects to converge code qemu: Move qemuDomainSecretChardevPrepare call qemu: Move qemuDomainPrepareChardevSourceTLS call qemu: Introduce qemuDomainGetTLSObjects src/qemu/qemu_domain.c | 182 +++++++++++++++----------- src/qemu/qemu_hotplug.c | 341 +++++++++++++++++++++++++----------------------- src/qemu/qemu_hotplug.h | 24 ++++ 3 files changed, 309 insertions(+), 238 deletions(-) -- 2.9.3

2 16

[libvirt] [PATCH v1 0/3] libxl: nestedhvm support
by Wim Ten Have 08 Mar '17

08 Mar '17

From: Wim ten Have <wim.ten.have(a)oracle.com> This patch enhances host-passthrough capability to advertise the required vendor CPU virtualization feature which will be used to enable 'nestedhvm' in the libxl driver. For Intel virtualization (VT-x) .. <cpu mode='host-passthrough'> <feature policy='require' name='vmx'/> </cpu> For AMD virtualization (AMD-V) .. <cpu mode='host-passthrough'> <feature policy='require' name='svm'/> </cpu> Joao Martins (2): libxl: set nestedhvm when vmx|svm is required xenconfig: add conversion of domxml nestedhvm Wim ten Have (1): xlconfigtest: add test and data for 'nestedhvm' support src/libxl/libxl_conf.c | 9 ++++ src/xenconfig/xen_xl.c | 41 +++++++++++++++++ tests/xlconfigdata/test-fullvirt-nestedhvm.cfg | 26 +++++++++++ tests/xlconfigdata/test-fullvirt-nestedhvm.xml | 61 ++++++++++++++++++++++++++ tests/xlconfigtest.c | 1 + 5 files changed, 138 insertions(+) create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm.cfg create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm.xml -- 2.9.3

3 7

[libvirt] [PATCH] qemuTestDriverInit: Don't access live data
by Michal Privoznik 08 Mar '17

08 Mar '17

Some of our tests (e.g. qemuhotplugtest) call virDomainSaveConfig(). Now the problem is, qemuTestDriverInit() creates a fake qemu driver and fills it with some fake configuration. At least so we hoped. The truth is, it calls regular virQEMUDriverConfigNew() and then fix couple of paths. Literally. Therefore our tests see regular stateDir and configDir for the user that is running the tests. Directories, where live domain XMLs are stored. Let's just hope our test suite hasn't mangled any of them. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tests/testutilsqemu.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c index 56a89c913..0726cd317 100644 --- a/tests/testutilsqemu.c +++ b/tests/testutilsqemu.c @@ -513,6 +513,10 @@ qemuTestParseCapabilities(virCapsPtr caps, void qemuTestDriverFree(virQEMUDriver *driver) { virMutexDestroy(&driver->lock); + if (driver->config) { + virFileDeleteTree(driver->config->stateDir); + virFileDeleteTree(driver->config->configDir); + } virQEMUCapsCacheFree(driver->qemuCapsCache); virObjectUnref(driver->xmlopt); virObjectUnref(driver->caps); @@ -548,9 +552,14 @@ int qemuTestCapsCacheInsert(virQEMUCapsCachePtr cache, const char *binary, return ret; } +# define STATEDIRTEMPLATE abs_builddir "/qemustatedir-XXXXXX" +# define CONFIGDIRTEMPLATE abs_builddir "/qemuconfigdir-XXXXXX" + int qemuTestDriverInit(virQEMUDriver *driver) { virSecurityManagerPtr mgr = NULL; + char statedir[] = STATEDIRTEMPLATE; + char configdir[] = CONFIGDIRTEMPLATE; memset(driver, 0, sizeof(*driver)); @@ -561,6 +570,11 @@ int qemuTestDriverInit(virQEMUDriver *driver) if (!driver->config) goto error; + /* Do this early so that qemuTestDriverFree() doesn't see (unlink) the real + * dirs. */ + VIR_FREE(driver->config->stateDir); + VIR_FREE(driver->config->configDir); + /* Overwrite some default paths so it's consistent for tests. */ VIR_FREE(driver->config->libDir); VIR_FREE(driver->config->channelTargetDir); @@ -568,6 +582,26 @@ int qemuTestDriverInit(virQEMUDriver *driver) VIR_STRDUP(driver->config->channelTargetDir, "/tmp/channel") < 0) goto error; + if (!mkdtemp(statedir)) { + virFilePrintf(stderr, "Cannot create fake stateDir"); + goto error; + } + + if (VIR_STRDUP(driver->config->stateDir, statedir) < 0) { + rmdir(statedir); + goto error; + } + + if (!mkdtemp(configdir)) { + virFilePrintf(stderr, "Cannot create fake configDir"); + goto error; + } + + if (VIR_STRDUP(driver->config->configDir, configdir) < 0) { + rmdir(configdir); + goto error; + } + driver->caps = testQemuCapsInit(); if (!driver->caps) goto error; -- 2.11.0

3 4

[libvirt] [PATCH] qemu_process: don't probe iothreads if it's not supported by QEMU
by Pavel Hrdina 08 Mar '17

08 Mar '17

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1430258 Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/qemu/qemu_process.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 78d10099af..fcba7d3097 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -2098,6 +2098,11 @@ qemuProcessDetectIOThreadPIDs(virQEMUDriverPtr driver, int ret = -1; size_t i; + if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_OBJECT_IOTHREAD)) { + ret = 0; + goto cleanup; + } + /* Get the list of IOThreads from qemu */ if (qemuDomainObjEnterMonitorAsync(driver, vm, asyncJob) < 0) goto cleanup; -- 2.12.0

2 1

[libvirt] [PATCH v2 0/2] default USB controller for PPC fix and API_UPDATE patch
by Pavel Hrdina 08 Mar '17

08 Mar '17

Pavel Hrdina (2): qemu_migration: don't allow ABI changes for persistent migration qemu_domain: use correct default USB controller on ppc64 src/qemu/qemu_domain.c | 16 ++++++++++++---- src/qemu/qemu_migration.c | 1 - 2 files changed, 12 insertions(+), 5 deletions(-) -- 2.12.0

3 4

[libvirt] [PATCH] libvirt-remote:fix use-after-free when sending event message
by Caoxinhua 08 Mar '17

08 Mar '17

>From 6b42792cfee124a742999e698e348e99b382ba16 Mon Sep 17 00:00:00 2001 From: c00207022 <caoxinhua(a)huawei.com> Date: Thu, 2 Mar 2017 12:07:27 +0800 Subject: [PATCH] libvirt-remote:fix use-after-free when sending event message [Changelog]:If there is a process with a client which registers event callbacks, and it calls libvirt's API which uses the same virConnectPtr in that callback function. When this process exit abnormally lead to client disconnect, there is a possibility that the libvirtd's main thread is use virServerClient to send event just after the virServerClient been freed by job thread. Following is backtrace: #0 0x00007fda223d66d8 in virClassIsDerivedFrom (klass=0xdeadbeef, parent=0x7fda24c81b40) at util/virobject.c:169 #1 0x00007fda223d6a1e in virObjectIsClass (anyobj=anyobj@entry=0x7fd9e575b400, klass=<optimized out>) at util/virobject.c:365 #2 0x00007fda223d6a44 in virObjectLock (anyobj=0x7fd9e575b400) at util/virobject.c:317 #3 0x00007fda22507f71 in virNetServerClientSendMessage (client=client@entry=0x7fd9e575b400, msg=msg@entry=0x7fd9ec30de90) at rpc/virnetserverclient.c:1422 #4 0x00007fda230d714d in remoteDispatchObjectEventSend (client=0x7fd9e575b400, program=0x7fda24c844e0, procnr=348, proc=0x7fda2310e5e0 <xdr_remote_domain_event_callback_tunable_msg>, data=0x7ffc3857fdb0) at remote.c:3803 #5 0x00007fda230dd71b in remoteRelayDomainEventTunable (conn=<optimized out>, dom=0x7fda27cd7660, params=0x7fda27f3aae0, nparams=1, opaque=0x7fd9e6c99e00) at remote.c:1033 #6 0x00007fda224484cb in virDomainEventDispatchDefaultFunc (conn=0x7fda27cd0120, event=0x7fda2736ea00, cb=0x7fda230dd610 <remoteRelayDomainEventTunable>, cbopaque=0x7fd9e6c99e00) at conf/domain_event.c:1910 #7 0x00007fda22446871 in virObjectEventStateDispatchCallbacks (callbacks=<optimized out>, callbacks=<optimized out>, event=0x7fda2736ea00, state=0x7fda24ca3960) at conf/object_event.c:722 #8 virObjectEventStateQueueDispatch (callbacks=0x7fda24c65800, queue=0x7ffc3857fe90, state=0x7fda24ca3960) at conf/object_event.c:736 #9 virObjectEventStateFlush (state=0x7fda24ca3960) at conf/object_event.c:814 #10 virObjectEventTimer (timer=<optimized out>, opaque=0x7fda24ca3960) at conf/object_event.c:560 #11 0x00007fda223ae8b9 in virEventPollDispatchTimeouts () at util/vireventpoll.c:458 #12 virEventPollRunOnce () at util/vireventpoll.c:654 #13 0x00007fda223ad1d2 in virEventRunDefaultImpl () at util/virevent.c:314 #14 0x00007fda225046cd in virNetDaemonRun (dmn=0x7fda24c775c0) at rpc/virnetdaemon.c:818 #15 0x00007fda230d6351 in main (argc=<optimized out>, argv=<optimized out>) at libvirtd.c:1623 Let's clean all event callback when client close. Signed-off-by: Caoxinhua <caoxinhua(a)huawei.com> --- daemon/remote.c | 76 +++++++++++++++++++++------------------------------------ 1 file changed, 28 insertions(+), 48 deletions(-) diff --git a/daemon/remote.c b/daemon/remote.c index 23c9de4..fb7cd50 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -101,6 +101,7 @@ static void make_nonnull_node_device(remote_nonnull_node_device *dev_dst, virNod static void make_nonnull_secret(remote_nonnull_secret *secret_dst, virSecretPtr secret_src); static void make_nonnull_nwfilter(remote_nonnull_nwfilter *net_dst, virNWFilterPtr nwfilter_src); static void make_nonnull_domain_snapshot(remote_nonnull_domain_snapshot *snapshot_dst, virDomainSnapshotPtr snapshot_src); +static void remoteClientCleanEventCallbacks(struct daemonClientPrivate *priv); static int remoteSerializeDomainDiskErrors(virDomainDiskErrorPtr errors, @@ -1483,24 +1484,15 @@ void remoteRelayConnectionClosedEvent(virConnectPtr conn ATTRIBUTE_UNUSED, int r &msg); } -/* - * You must hold lock for at least the client - * We don't free stuff here, merely disconnect the client's - * network socket & resources. - * We keep the libvirt connection open until any async - * jobs have finished, then clean it up elsewhere - */ -void remoteClientFreeFunc(void *data) +static void remoteClientCleanEventCallbacks(struct daemonClientPrivate *priv) { - struct daemonClientPrivate *priv = data; - /* Deregister event delivery callback */ - if (priv->conn) { - virIdentityPtr sysident = virIdentityGetSystem(); + if (priv && priv->conn) { size_t i; - + virIdentityPtr sysident = virIdentityGetSystem(); virIdentitySetCurrent(sysident); + virMutexLock(&priv->lock); for (i = 0; i < priv->ndomainEventCallbacks; i++) { int callbackID = priv->domainEventCallbacks[i]->callbackID; if (callbackID < 0) { @@ -1514,6 +1506,7 @@ void remoteClientFreeFunc(void *data) VIR_WARN("unexpected domain event deregister failure"); } VIR_FREE(priv->domainEventCallbacks); + priv->ndomainEventCallbacks = 0; for (i = 0; i < priv->nnetworkEventCallbacks; i++) { int callbackID = priv->networkEventCallbacks[i]->callbackID; @@ -1529,36 +1522,7 @@ void remoteClientFreeFunc(void *data) VIR_WARN("unexpected network event deregister failure"); } VIR_FREE(priv->networkEventCallbacks); - - for (i = 0; i < priv->nstorageEventCallbacks; i++) { - int callbackID = priv->storageEventCallbacks[i]->callbackID; - if (callbackID < 0) { - VIR_WARN("unexpected incomplete storage pool callback %zu", i); - continue; - } - VIR_DEBUG("Deregistering remote storage pool event relay %d", - callbackID); - priv->storageEventCallbacks[i]->callbackID = -1; - if (virConnectStoragePoolEventDeregisterAny(priv->conn, - callbackID) < 0) - VIR_WARN("unexpected storage pool event deregister failure"); - } - VIR_FREE(priv->storageEventCallbacks); - - for (i = 0; i < priv->nnodeDeviceEventCallbacks; i++) { - int callbackID = priv->nodeDeviceEventCallbacks[i]->callbackID; - if (callbackID < 0) { - VIR_WARN("unexpected incomplete node device callback %zu", i); - continue; - } - VIR_DEBUG("Deregistering remote node device event relay %d", - callbackID); - priv->nodeDeviceEventCallbacks[i]->callbackID = -1; - if (virConnectNodeDeviceEventDeregisterAny(priv->conn, - callbackID) < 0) - VIR_WARN("unexpected node device event deregister failure"); - } - VIR_FREE(priv->nodeDeviceEventCallbacks); + priv->nnetworkEventCallbacks = 0; for (i = 0; i < priv->nqemuEventCallbacks; i++) { int callbackID = priv->qemuEventCallbacks[i]->callbackID; @@ -1574,31 +1538,47 @@ void remoteClientFreeFunc(void *data) VIR_WARN("unexpected qemu monitor event deregister failure"); } VIR_FREE(priv->qemuEventCallbacks); + priv->nqemuEventCallbacks = 0; if (priv->closeRegistered) { if (virConnectUnregisterCloseCallback(priv->conn, remoteRelayConnectionClosedEvent) < 0) VIR_WARN("unexpected close callback event deregister failure"); } - - virConnectClose(priv->conn); - + virMutexUnlock(&priv->lock); virIdentitySetCurrent(NULL); virObjectUnref(sysident); } +} + + +/* + * You must hold lock for at least the client + * We don't free stuff here, merely disconnect the client's + * network socket & resources. + * We keep the libvirt connection open until any async + * jobs have finished, then clean it up elsewhere + */ +void remoteClientFreeFunc(void *data) +{ + struct daemonClientPrivate *priv = data; + if (!priv || !priv->conn) + return; + + remoteClientCleanEventCallbacks(priv); + virConnectClose(priv->conn); VIR_FREE(priv); } - static void remoteClientCloseFunc(virNetServerClientPtr client) { struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client); daemonRemoveAllClientStreams(priv->streams); + remoteClientCleanEventCallbacks(priv); } - void *remoteClientInitHook(virNetServerClientPtr client, void *opaque ATTRIBUTE_UNUSED) { -- 1.8.3.1

2 2

[libvirt] [PATCH] network: don't use dhcp-authoritative on static networks
by Martin Wilck 07 Mar '17

07 Mar '17

"Static" DHCP networks are those where no dynamic DHCP range is defined, only a list of host entries is used to serve permanent IP addresses. On such networks, we don't want dnsmasq to reply to other requests than those statically defined. But "dhcp-authoritative" will cause dnsmasq to do just that. Therefore we can't use "dhcp-authoritative" for static networks. Fixes: 4ac20b3ae "network: add dnsmasq option 'dhcp-authoritative'" Signed-off-by: Martin Wilck <mwilck(a)suse.com> --- src/network/bridge_driver.c | 9 ++++++++- tests/networkxml2confdata/dhcp6host-routed-network.conf | 1 - 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index ae1589d8c..17c6f3a0f 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -1355,7 +1355,14 @@ networkDnsmasqConfContents(virNetworkObjPtr network, if (VIR_SOCKET_ADDR_IS_FAMILY(&ipdef->address, AF_INET)) { if (ipdef->nranges || ipdef->nhosts) { virBufferAddLit(&configbuf, "dhcp-no-override\n"); - virBufferAddLit(&configbuf, "dhcp-authoritative\n"); + /* + * Use "dhcp-authoritative" only for dynamic DHCP. + * In a static-only network, it would cause dnsmasq + * to reply to requests from other hosts than those + * statically defined. + */ + if (ipdef->nranges || !ipdef->nhosts) + virBufferAddLit(&configbuf, "dhcp-authoritative\n"); } if (ipdef->tftproot) { diff --git a/tests/networkxml2confdata/dhcp6host-routed-network.conf b/tests/networkxml2confdata/dhcp6host-routed-network.conf index 87a149880..5728ee430 100644 --- a/tests/networkxml2confdata/dhcp6host-routed-network.conf +++ b/tests/networkxml2confdata/dhcp6host-routed-network.conf @@ -10,7 +10,6 @@ bind-dynamic interface=virbr1 dhcp-range=192.168.122.1,static dhcp-no-override -dhcp-authoritative dhcp-range=2001:db8:ac10:fd01::1,static,64 dhcp-hostsfile=/var/lib/libvirt/dnsmasq/local.hostsfile addn-hosts=/var/lib/libvirt/dnsmasq/local.addnhosts -- 2.11.0

2 5

[libvirt] [PATCH] qemuDomainSaveImageUpdateDef: Don't overwrite errors from virDomainDefCheckABIStability
by Michal Privoznik 07 Mar '17

07 Mar '17

https://bugzilla.redhat.com/show_bug.cgi?id=1379200 When we are restoring a domain from a saved image, or just updating its XML in the saved image - we have to make sure that the ABI guests sees will not change. We have a function for that which reports errors. But for some reason if this function fails, we call it again with slightly different argument. Therefore it might happen that we overwrite the original error and leave user with less helpful one. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_driver.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 77d81755a..2bef0f200 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -6109,7 +6109,7 @@ qemuDomainSaveImageUpdateDef(virQEMUDriverPtr driver, goto cleanup; if (!virDomainDefCheckABIStability(def, newdef_migr)) { - virResetLastError(); + virErrorPtr err = virSaveLastError(); /* Due to a bug in older version of external snapshot creation * code, the XML saved in the save image was not a migratable @@ -6117,8 +6117,12 @@ qemuDomainSaveImageUpdateDef(virQEMUDriverPtr driver, * saved XML type, we need to check the ABI compatibility against * the user provided XML if the check against the migratable XML * fails. Snapshots created prior to v1.1.3 have this issue. */ - if (!virDomainDefCheckABIStability(def, newdef)) + if (!virDomainDefCheckABIStability(def, newdef)) { + virSetError(err); + virFreeError(err); goto cleanup; + } + virFreeError(err); /* use the user provided XML */ ret = newdef; -- 2.11.0

2 1

[libvirt] [PATCH go v3] Add support for perf events
by Nitesh Konkar 07 Mar '17

07 Mar '17

Signed-off-by: Nitesh Konkar <nitkon12(a)linux.vnet.ibm.com> --- connect.go | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ domain.go | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ domain_compat.h | 36 ++++++++++++++++++++++++++++++++++++ 3 files changed, 144 insertions(+) diff --git a/connect.go b/connect.go index 3c53485..a4dd21b 100644 --- a/connect.go +++ b/connect.go @@ -2264,6 +2264,24 @@ type DomainStatsPerf struct { StalledCyclesBackend uint64 RefCpuCyclesSet bool RefCpuCycles uint64 + CpuClockSet bool + CpuClock uint64 + TaskClockSet bool + TaskClock uint64 + PageFaultsSet bool + PageFaults uint64 + ContextSwitchesSet bool + ContextSwitches uint64 + CpuMigrationsSet bool + CpuMigrations uint64 + PageFaultsMinSet bool + PageFaultsMin uint64 + PageFaultsMajSet bool + PageFaultsMaj uint64 + AlignmentFaultsSet bool + AlignmentFaults uint64 + EmulationFaultsSet bool + EmulationFaults uint64 } func getDomainStatsPerfFieldInfo(params *DomainStatsPerf) map[string]typedParamsFieldInfo { @@ -2320,6 +2338,42 @@ func getDomainStatsPerfFieldInfo(params *DomainStatsPerf) map[string]typedParams set: &params.RefCpuCyclesSet, ul: &params.RefCpuCycles, }, + "perf.cpu_clock": typedParamsFieldInfo{ + set: &params.CpuClockSet, + ul: &params.CpuClock, + }, + "perf.task_clock": typedParamsFieldInfo{ + set: &params.TaskClockSet, + ul: &params.TaskClock, + }, + "perf.page_faults": typedParamsFieldInfo{ + set: &params.PageFaultsSet, + ul: &params.PageFaults, + }, + "perf.context_switches": typedParamsFieldInfo{ + set: &params.ContextSwitchesSet, + ul: &params.ContextSwitches, + }, + "perf.cpu_migrations": typedParamsFieldInfo{ + set: &params.CpuMigrationsSet, + ul: &params.CpuMigrations, + }, + "perf.page_faults_min": typedParamsFieldInfo{ + set: &params.PageFaultsMinSet, + ul: &params.PageFaultsMin, + }, + "perf.page_faults_maj": typedParamsFieldInfo{ + set: &params.PageFaultsMajSet, + ul: &params.PageFaultsMaj, + }, + "perf.alignment_faults": typedParamsFieldInfo{ + set: &params.AlignmentFaultsSet, + ul: &params.AlignmentFaults, + }, + "perf.emulation_faults": typedParamsFieldInfo{ + set: &params.EmulationFaultsSet, + ul: &params.EmulationFaults, + }, } } diff --git a/domain.go b/domain.go index 2bd9852..9f3ecc3 100644 --- a/domain.go +++ b/domain.go @@ -3195,6 +3195,24 @@ type DomainPerfEvents struct { StalledCyclesBackend bool RefCpuCyclesSet bool RefCpuCycles bool + CpuClockSet bool + CpuClock bool + TaskClockSet bool + TaskClock bool + PageFaultsSet bool + PageFaults bool + ContextSwitchesSet bool + ContextSwitches bool + CpuMigrationsSet bool + CpuMigrations bool + PageFaultsMinSet bool + PageFaultsMin bool + PageFaultsMajSet bool + PageFaultsMaj bool + AlignmentFaultsSet bool + AlignmentFaults bool + EmulationFaultsSet bool + EmulationFaults bool } /* Remember to also update DomainStatsPerf in connect.go when adding to the stuct above */ @@ -3253,6 +3271,42 @@ func getDomainPerfEventsFieldInfo(params *DomainPerfEvents) map[string]typedPara set: &params.RefCpuCyclesSet, b: &params.RefCpuCycles, }, + C.VIR_PERF_PARAM_CPU_CLOCK: typedParamsFieldInfo{ + set: &params.CpuClockSet, + b: &params.CpuClock, + }, + C.VIR_PERF_PARAM_TASK_CLOCK: typedParamsFieldInfo{ + set: &params.TaskClockSet, + b: &params.TaskClock, + }, + C.VIR_PERF_PARAM_PAGE_FAULTS: typedParamsFieldInfo{ + set: &params.PageFaultsSet, + b: &params.PageFaults, + }, + C.VIR_PERF_PARAM_CONTEXT_SWITCHES: typedParamsFieldInfo{ + set: &params.ContextSwitchesSet, + b: &params.ContextSwitches, + }, + C.VIR_PERF_PARAM_CPU_MIGRATIONS: typedParamsFieldInfo{ + set: &params.CpuMigrationsSet, + b: &params.CpuMigrations, + }, + C.VIR_PERF_PARAM_PAGE_FAULTS_MIN: typedParamsFieldInfo{ + set: &params.PageFaultsMinSet, + b: &params.PageFaultsMin, + }, + C.VIR_PERF_PARAM_PAGE_FAULTS_MAJ: typedParamsFieldInfo{ + set: &params.PageFaultsMajSet, + b: &params.PageFaultsMaj, + }, + C.VIR_PERF_PARAM_ALIGNMENT_FAULTS: typedParamsFieldInfo{ + set: &params.AlignmentFaultsSet, + b: &params.AlignmentFaults, + }, + C.VIR_PERF_PARAM_REF_EMULATION_FAULTS: typedParamsFieldInfo{ + set: &params.EmulationFaultsSet, + b: &params.EmulationFaults, + }, } } diff --git a/domain_compat.h b/domain_compat.h index 9540435..a114173 100644 --- a/domain_compat.h +++ b/domain_compat.h @@ -45,6 +45,42 @@ #define VIR_PERF_PARAM_REF_CPU_CYCLES "ref_cpu_cycles" #endif +#ifndef VIR_PERF_PARAM_CPU_CLOCK +#define VIR_PERF_PARAM_CPU_CLOCK "cpu_clock" +#endif + +#ifndef VIR_PERF_PARAM_TASK_CLOCK +#define VIR_PERF_PARAM_TASK_CLOCK "task_clock" +#endif + +#ifndef VIR_PERF_PARAM_PAGE_FAULTS +#define VIR_PERF_PARAM_PAGE_FAULTS "page_faults" +#endif + +#ifndef VIR_PERF_PARAM_CONTEXT_SWITCHES +#define VIR_PERF_PARAM_CONTEXT_SWITCHES "context_switches" +#endif + +#ifndef VIR_PERF_PARAM_CPU_MIGRATIONS +#define VIR_PERF_PARAM_CPU_MIGRATIONS "cpu_migrations" +#endif + +#ifndef VIR_PERF_PARAM_PAGE_FAULTS_MIN +#define VIR_PERF_PARAM_PAGE_FAULTS_MIN "page_faults_min" +#endif + +#ifndef VIR_PERF_PARAM_PAGE_FAULTS_MAJ +#define VIR_PERF_PARAM_PAGE_FAULTS_MAJ "page_faults_maj" +#endif + +#ifndef VIR_PERF_PARAM_ALIGNMENT_FAULTS +#define VIR_PERF_PARAM__ALIGNMENT_FAULTS "alignment_faults" +#endif + +#ifndef VIR_PERF_PARAM_EMULATION_FAULTS +#define VIR_PERF_PARAM_EMULATION_FAULTS "emulation_faults" +#endif + #ifndef VIR_DOMAIN_EVENT_ID_METADATA_CHANGE #define VIR_DOMAIN_EVENT_ID_METADATA_CHANGE 23 #endif -- 1.9.3

3 3

[libvirt] [PATCH perl v2] Add constants for new perf event support
by Nitesh Konkar 07 Mar '17

07 Mar '17

Signed-off-by: Nitesh Konkar <nitkon12(a)linux.vnet.ibm.com> --- Changes | 9 +++++++++ Virt.xs | 9 +++++++++ lib/Sys/Virt/Domain.pm | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 72 insertions(+) diff --git a/Changes b/Changes index 842f21f..7d637f5 100644 --- a/Changes +++ b/Changes @@ -5,6 +5,15 @@ Revision history for perl module Sys::Virt - Add VIR_CONNECT_LIST_STORAGE_POOLS_VSTORAGE constant - Add VIR_CONNECT_LIST_NODE_DEVICES_CAP_DRM constant - Add virDomainSetVcpu API + - Add PERF_PARAM_CPU_CLOCK constant + - Add PERF_PARAM_TASK_CLOCK constant + - Add PERF_PARAM_PAGE_FAULTS constant + - Add PERF_PARAM_CONTEXT_SWITCHES constant + - Add PERF_PARAM_CPU_MIGRATIONS constant + - Add PERF_PARAM_PAGE_FAULTS_MIN constant + - Add PERF_PARAM_PAGE_FAULTS_MAJ constant + - Add PERF_PARAM_ALIGNMENT_FAULTS constant + - Add PERF_PARAM_EMULATION_FAULTS constant 3.0.0 2017-01-19 diff --git a/Virt.xs b/Virt.xs index 9728fb0..e80182f 100644 --- a/Virt.xs +++ b/Virt.xs @@ -8500,6 +8500,15 @@ BOOT: REGISTER_CONSTANT_STR(VIR_PERF_PARAM_STALLED_CYCLES_FRONTEND, PERF_PARAM_STALLED_CYCLES_FRONTEND); REGISTER_CONSTANT_STR(VIR_PERF_PARAM_STALLED_CYCLES_BACKEND, PERF_PARAM_STALLED_CYCLES_BACKEND); REGISTER_CONSTANT_STR(VIR_PERF_PARAM_REF_CPU_CYCLES, PERF_PARAM_REF_CPU_CYCLES); + REGISTER_CONSTANT_STR(VIR_PERF_PARAM_CPU_CLOCK, PERF_PARAM_CPU_CLOCK); + REGISTER_CONSTANT_STR(VIR_PERF_PARAM_TASK_CLOCK, PERF_PARAM_TASK_CLOCK); + REGISTER_CONSTANT_STR(VIR_PERF_PARAM_PAGE_FAULTS, PERF_PARAM_PAGE_FAULTS); + REGISTER_CONSTANT_STR(VIR_PERF_PARAM_CONTEXT_SWITCHES, PERF_PARAM_CONTEXT_SWITCHES); + REGISTER_CONSTANT_STR(VIR_PERF_PARAM_CPU_MIGRATIONS, PERF_PARAM_CPU_MIGRATIONS); + REGISTER_CONSTANT_STR(VIR_PERF_PARAM_PAGE_FAULTS_MIN, PERF_PARAM_PAGE_FAULTS_MIN); + REGISTER_CONSTANT_STR(VIR_PERF_PARAM_PAGE_FAULTS_MAJ, PERF_PARAM_PAGE_FAULTS_MAJ); + REGISTER_CONSTANT_STR(VIR_PERF_PARAM_ALIGNMENT_FAULTS, PERF_PARAM_ALIGNMENT_FAULTS); + REGISTER_CONSTANT_STR(VIR_PERF_PARAM_EMULATION_FAULTS, PERF_PARAM_EMULATION_FAULTS); REGISTER_CONSTANT_STR(VIR_DOMAIN_BANDWIDTH_IN_AVERAGE, BANDWIDTH_IN_AVERAGE); REGISTER_CONSTANT_STR(VIR_DOMAIN_BANDWIDTH_IN_PEAK, BANDWIDTH_IN_PEAK); diff --git a/lib/Sys/Virt/Domain.pm b/lib/Sys/Virt/Domain.pm index 6b36e73..eea8b26 100644 --- a/lib/Sys/Virt/Domain.pm +++ b/lib/Sys/Virt/Domain.pm @@ -2814,6 +2814,60 @@ frequency scaling by applications running on the platform. It corresponds to the "perf.ref_cpu_cycles" field in the *Stats APIs. +=item Sys::Virt::Domain::PERF_PARAM_CPU_CLOCK +The cpu_clock perf event counter which can be used to +measure the count of cpu clock time by applications +running on the platform. It corresponds to the +"perf.cpu_clock" field in the *Stats APIs. + +=item Sys::Virt::Domain::PERF_PARAM_TASK_CLOCK +The task_clock perf event counter which can be used to +measure the count of task clock time by applications +running on the platform. It corresponds to the +"perf.task_clock" field in the *Stats APIs. + +=item Sys::Virt::Domain::PERF_PARAM_PAGE_FAULTS +The page_faults perf event counter which can be used to +measure the count of page faults by applications running +on the platform. It corresponds to the "perf.page_faults" +field in the *Stats APIs. + +=item Sys::Virt::Domain::PERF_PARAM_CONTEXT_SWITCHES +The context_switches perf event counter which can be used to +measure the count of context switches by applications running +on the platform. It corresponds to the "perf.context_switches" +field in the *Stats APIs. + +=item Sys::Virt::Domain::PERF_PARAM_CPU_MIGRATIONS +The cpu_migrations perf event counter which can be used to +measure the count of cpu migrations by applications running +on the platform. It corresponds to the "perf.cpu_migrations" +field in the *Stats APIs. + +=item Sys::Virt::Domain::PERF_PARAM_PAGE_FAULTS_MIN +The page_faults_min perf event counter which can be used to +measure the count of minor page faults by applications running +on the platform. It corresponds to the "perf.page_faults_min" +field in the *Stats APIs. + +=item Sys::Virt::Domain::PERF_PARAM_PAGE_FAULTS_MAJ +The page_faults_maj perf event counter which can be used to +measure the count of major page faults by applications running +on the platform. It corresponds to the "perf.page_faults_maj" +field in the *Stats APIs. + +=item Sys::Virt::Domain::PERF_PARAM_ALIGNMENT_FAULTS +The alignment_faults perf event counter which can be used to +measure the count of alignment faults by applications running +on the platform. It corresponds to the "perf.alignment_faults" +field in the *Stats APIs. + +=item Sys::Virt::Domain::PERF_PARAM_EMULATION_FAULTS +The emulation_faults perf event counter which can be used to +measure the count of emulation faults by applications running +on the platform. It corresponds to the "perf.emulation_faults" +field in the *Stats APIs. + =back =head2 VCPU FLAGS -- 1.9.3

2 2

[libvirt] [PATCH 0/6] Split out nwfilter object into its own module
by John Ferlan 07 Mar '17

07 Mar '17

Continuing down the pile of drivers from my RFC for making a common pool object - we're now at nwfilter (still have storage and network to go). For reference see patch 3 of: http://www.redhat.com/archives/libvir-list/2017-February/msg00519.html This series works through the nwfilter conf adjustments. We start by fixing a couple of API's that aren't using objects, then launch into the repetitive type actions of moving the code into it's own module, fixing up the "style", altering the function prototypes, and finally using virNWFilterObj prefix for any API's in virnwfilterobj. John Ferlan (6): conf: Change virNWFilterObjSaveDef to virNWFilterSaveDef conf: Change virNWFilterObjDeleteDef to virNWFilterDeleteDef conf: Introduce virnwfilterobj conf: Adjust coding style for nwfilter conf sources conf: Alter coding style of nwfilter function prototypes conf: Use consistent function name prefixes for virnwfilterobj po/POTFILES.in | 1 + src/Makefile.am | 6 +- src/conf/nwfilter_conf.c | 498 +++++++-------------------------- src/conf/nwfilter_conf.h | 157 +++++------ src/conf/virnwfilterobj.c | 388 +++++++++++++++++++++++++ src/conf/virnwfilterobj.h | 94 +++++++ src/libvirt_private.syms | 26 +- src/nwfilter/nwfilter_driver.c | 13 +- src/nwfilter/nwfilter_gentech_driver.h | 2 +- src/nwfilter/nwfilter_tech_driver.h | 2 +- 10 files changed, 676 insertions(+), 511 deletions(-) create mode 100644 src/conf/virnwfilterobj.c create mode 100644 src/conf/virnwfilterobj.h -- 2.9.3

2 9

[libvirt] [PATCH 0/3] use USB nec-usb-xhci controller as default if possible for ppc64
by Pavel Hrdina 07 Mar '17

07 Mar '17

Pavel Hrdina (3): qemu_domain: move controller post parse code into its own function qemu_domain: cleanup the controller post parse code qemu_domain: use correct default USB controller on ppc64 src/qemu/qemu_domain.c | 218 +++++++++++++++++++++++++++---------------------- 1 file changed, 120 insertions(+), 98 deletions(-) -- 2.12.0

3 14

[libvirt] [PATCH] storage: Don't pass 'iso' format to qemu-img
by Cole Robinson 07 Mar '17

07 Mar '17

$ virsh vol-clone /tmp/test.iso new.iso error: Failed to clone vol from test.iso error: internal error: Child process (/bin/qemu-img convert -f iso -O iso /tmp/test.iso /tmp/new.iso) unexpected exit status 1: qemu-img: Could not open '/tmp/test.iso': Unknown driver 'iso' Map iso->raw before sending the format value to qemu-img https://bugzilla.redhat.com/show_bug.cgi?id=972784 https://bugzilla.redhat.com/show_bug.cgi?id=1419395 --- src/storage/storage_util.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index 41253b9..bf6f0b3 100644 --- a/src/storage/storage_util.c +++ b/src/storage/storage_util.c @@ -1009,6 +1009,8 @@ storageBackendCreateQemuImgSetInput(virStorageVolDefPtr inputvol, info->inputFormat = inputvol->target.format; if (inputvol->type == VIR_STORAGE_VOL_BLOCK) info->inputFormat = VIR_STORAGE_FILE_RAW; + if (info->inputFormat == VIR_STORAGE_FILE_ISO) + info->inputFormat = VIR_STORAGE_FILE_RAW; if (!(info->inputFormatStr = virStorageFileFormatTypeToString(info->inputFormat))) { virReportError(VIR_ERR_INTERNAL_ERROR, @@ -1175,6 +1177,9 @@ virStorageBackendCreateQemuImgCmdFromVol(virConnectPtr conn, if (vol->type == VIR_STORAGE_VOL_BLOCK) info.format = VIR_STORAGE_FILE_RAW; + if (info.format == VIR_STORAGE_FILE_ISO) + info.format = VIR_STORAGE_FILE_RAW; + if (!(type = virStorageFileFormatTypeToString(info.format))) { virReportError(VIR_ERR_INTERNAL_ERROR, _("unknown storage vol type %d"), -- 2.9.3

3 3

[libvirt] [PATCH 0/2] Fix a couple of Coverity found issues from recent patches
by John Ferlan 07 Mar '17

07 Mar '17

The virsysinfo changes caused Coverity to "take another look" at the code and it found some issues. Each is described in the patch commit. John Ferlan (2): util: Resource some resource leaks in virsysinfo code util: Avoid possible NULL dereference in virSysinfoParsePPCProcessor src/util/virsysinfo.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) -- 2.9.3

2 3

[libvirt] [PATCH 0/4] Refactor and fix sysinfo data retrieval and the testing of the code
by Peter Krempa 07 Mar '17

07 Mar '17

src/util/virsysinfo.c was a big mess of conditionally compiled functions with the same name for each platform. Also the test was run only for the current platform. Remove the churn and make all tests run on all platforms since there is no platform dependency. Peter Krempa (4): util: sysinfo: Reduce amount of conditionally compiled code tests: sysinfo: Export virSysinfoSetup via the private header tests: sysinfo: Run all sysinfo tests all the time tests: sysinfo: Add test data for HP moonshot aarch64 box src/Makefile.am | 2 +- src/libvirt_private.syms | 7 + src/util/virsysinfo.c | 172 ++++++++++++----------- src/util/virsysinfopriv.h | 44 ++++++ tests/sysinfodata/aarch64-moonshotcpuinfo.data | 72 ++++++++++ tests/sysinfodata/aarch64-moonshotsysinfo.expect | 1 + tests/sysinfotest.c | 115 ++++----------- 7 files changed, 241 insertions(+), 172 deletions(-) create mode 100644 src/util/virsysinfopriv.h create mode 100644 tests/sysinfodata/aarch64-moonshotcpuinfo.data create mode 100644 tests/sysinfodata/aarch64-moonshotsysinfo.expect -- 2.11.0

2 6

[libvirt] [PATCH] libvirt: document UNDEFINE_KEEP_NVRAM in UndefineFlags docs
by Cole Robinson 07 Mar '17

07 Mar '17

--- src/libvirt-domain.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 619a9fc..749297f 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -6287,9 +6287,9 @@ virDomainUndefine(virDomainPtr domain) * whether this flag is present. On hypervisors where snapshots do * not use libvirt metadata, this flag has no effect. * - * If the domain has any nvram specified, then including - * VIR_DOMAIN_UNDEFINE_NVRAM will also remove that file, and omitting the flag - * will cause the undefine process to fail. + * If the domain has any nvram specified, the undefine process will fail + * unless VIR_DOMAIN_UNDEFINE_KEEP_NVRAM is specified, or if + * VIR_DOMAIN_UNDEFINE_NVRAM is specified to remove the nvram file. * * Returns 0 in case of success, -1 in case of error */ -- 2.9.3

2 1

[libvirt] [PATH V10 00/12] Support cache tune in libvirt
by Eli Qiao 07 Mar '17

07 Mar '17

Addressed comment from v9 -> v8 Marcelo: * Improve default schemata calculate, support allocate from low schemata bits for other APP. Addressed comment from v9 -> v8 Marcelo: * New public API to query cache usage Eli: * Fix core dump while multiple tasks are added. Addressed comment from v8 -> v7 Martin: * Patch subject prefix. * Move some of cpu related information to virhostcpu.c. * Fix some memory leak in src/utils/resctrl.c Martin & Marcelo: * Don't remove directories which are not maintained by libvirt. Addressed comment from v7 -> v6 Marcelo: * Fix flock usage while VM initialization. Addressed comment from v6 -> v5 Marcelo: * Support other APPs to operate /sys/fs/resctrl at same time Libvirt will scan /sys/fs/resctrl again before doing cache allocation. patch 10 will address this. Addressed comment from v4 -> v5: Marcelo: * Several typos * Use flock instead of virFileLock Addressed comment from v3 -> v4: Daniel & Marcelo: * Added concurrence support Addressed comment from v2 -> v3: Daniel: * Fixed coding style, passed `make check` and `make syntax-check` * Variables renaming and move from header file to c file. * For locking/mutex support, no progress. There are some discussion from mailing list, but I can not find a better way to add locking support without performance impact. I'll explain the process and please help to advice what shoud we do. VM create: 1) Get the cache left value on each bank of the host. This should be shared amount all VMs. 2) Calculate the schemata on the bank based on all created resctrl domain's schemata 3) Calculate the default schemata by scaning all domain's schemata. 4) Flush default schemata to /sys/fs/resctrl/schemata VM destroy: 1) Remove the resctrl domain of that VM 2) Recalculate default schemata 3) Flush default schemata to /sys/fs/resctrl/schemata The key point is that all VMs shares /sys/fs/resctrl/schemata, and when a VM create a resctrl domain, the schemata of that VM depends on the default schemata and all other exsited schematas. So a global mutex is reqired. Before calculate a schemata or update default schemata, libvirt should gain this global mutex. I will try to think more about how to support this gracefully in next patch set. Marcelo: * Added vcpu support for cachetune, this will allow user to define which vcpu using which cache allocation bank. <cachetune id='0' host_id=0 size='3072' unit='KiB' vcpus='0,1'/> vcpus is a cpumap, the vcpu pids will be added to tasks file * Added cdp compatible, user can specify l3 cache even host enable cdp. See patch 8. On a cdp enabled host, specify l3code/l3data by <cachetune id='0' host_id='0' type='l3' size='3072' unit='KiB'/> This will create a schemata like: L3data:0=0xff00;... L3code:0=0xff00;... * Would you please help to test if the functions work. Martin: * Xml test case, I have no time to work on this yet, would you please show me an example, would like to amend it later. This series patches are for supportting CAT featues, which also called cache tune in libvirt. First to expose cache information which could be tuned in capabilites XML. Then add new domain xml element support to add cacahe bank which will apply on this libvirt domain. This series patches add a util file `resctrl.c/h`, an interface to talk with linux kernel's system fs. There are still one TODO left: 1. Expose a new public interface to get free cache information. 2. Expose a new public interface to set cachetune lively. Some discussion about this feature support can be found from: https://www.redhat.com/archives/libvir-list/2017-January/msg00644.html Eli Qiao (12): Resctrl: Add some utils functions Resctrl: expose cache information to capabilities Resctrl: Add new xml element to support cache tune Resctrl: Add private interfaces to operate cache bank Qemu: Set cache tune while booting a new domain. Resctrl: enable l3code/l3data Resctrl: Make sure l3data/l3code are pairs Resctrl: Compatible mode for cdp enabled Resctrl: concurrence support Resctrl: Scan resctrl before doing cache allocation Resctrl: Add Public API for nodecachestats Resctrl: Add nodecachestats daemon/remote.c | 67 +++ docs/schemas/domaincommon.rng | 46 ++ include/libvirt/libvirt-host.h | 32 ++ include/libvirt/virterror.h | 1 + po/POTFILES.in | 1 + src/Makefile.am | 1 + src/conf/capabilities.c | 56 ++ src/conf/capabilities.h | 23 + src/conf/domain_conf.c | 182 +++++++ src/conf/domain_conf.h | 19 + src/driver-hypervisor.h | 7 + src/libvirt-host.c | 41 ++ src/libvirt_private.syms | 12 + src/libvirt_public.syms | 1 + src/nodeinfo.c | 64 +++ src/nodeinfo.h | 1 + src/qemu/qemu_capabilities.c | 8 + src/qemu/qemu_driver.c | 18 + src/qemu/qemu_process.c | 54 ++ src/remote/remote_driver.c | 52 ++ src/remote/remote_protocol.x | 25 +- src/remote_protocol-structs | 16 + src/util/virerror.c | 1 + src/util/virhostcpu.c | 186 ++++++- src/util/virhostcpu.h | 6 + src/util/virresctrl.c | 1098 ++++++++++++++++++++++++++++++++++++++++ src/util/virresctrl.h | 96 ++++ tools/virsh-host.c | 49 ++ 28 files changed, 2145 insertions(+), 18 deletions(-) create mode 100644 src/util/virresctrl.c create mode 100644 src/util/virresctrl.h -- 1.9.1

4 15