- Devel - libvirt List Archives

[libvirt] [PATCH] conf: format only relevant attributes for graphics based on listen type
by Pavel Hrdina 28 Apr '17

28 Apr '17

This patch changes following output: ... <graphics type='vnc' port='-1' autoport='yes'> <listen type='none'/> </graphics> ... into this output: ... <graphics type='vnc'> <listen type='none'/> </graphics> ... Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/conf/domain_conf.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index fe9b7c7273..88bcd6c052 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -23297,7 +23297,8 @@ virDomainGraphicsDefFormat(virBufferPtr buf, return -1; } - if (glisten->type == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET) { + switch (glisten->type) { + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET: /* To not break migration we shouldn't print the 'socket' attribute * if it's auto-generated or if it's based on config option from * qemu.conf. If the socket is provided by user we need to print it @@ -23307,7 +23308,10 @@ virDomainGraphicsDefFormat(virBufferPtr buf, (flags & VIR_DOMAIN_DEF_FORMAT_MIGRATABLE))) { virBufferEscapeString(buf, " socket='%s'", glisten->socket); } - } else { + break; + + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS: + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK: if (def->data.vnc.port && (!def->data.vnc.autoport || !(flags & VIR_DOMAIN_DEF_FORMAT_INACTIVE))) virBufferAsprintf(buf, " port='%d'", @@ -23325,6 +23329,10 @@ virDomainGraphicsDefFormat(virBufferPtr buf, virBufferAsprintf(buf, " websocket='%d'", def->data.vnc.websocket); virDomainGraphicsListenDefFormatAddr(buf, glisten, flags); + break; + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NONE: + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_LAST: + break; } if (def->data.vnc.keymap) -- 2.12.2

2 1

[libvirt] [PATCH v2 0/3] conf: don't ignore <target dev='blah'/> for macvtap interfaces
by Laine Stump 28 Apr '17

28 Apr '17

The parser had been clearing out *all* suggested device names for type='direct' (aka macvtap) interfaces. All of the code implementing macvtap allows for a user-specified device name, so we should allow it. In the case that an interface name starts with "macvtap" or "macvlan" though, we do still clear it out, just as we do with "vnet" (which is the prefix used for automatically generated tap device names), since those are the prefixes for the names we autogenerate for macvtap and macvlan devices. Resolves: https://bugzilla.redhat.com/1335798 Changes since V1: * make a single #define for each of MACVLAN_PREFIX and MACVTAP_PREFIX in virnetdevmacvlan.h rather than duplicating #defines from virnetdevmacvlan.c into domain_conf.h (as suggested by Martin * move/rename the auto-generated prefix for regular tap devices to be consistent with the macvtap/macvlan prefixes. Laine Stump (3): util: make macvtap/macvlan generated name #defines available to other files conf: don't ignore <target dev='blah'/> for macvtap interfaces util: rename/move VIR_NET_GENERATED_PREFIX to be consistent docs/formatdomain.html.in | 6 ++-- src/bhyve/bhyve_command.c | 4 +-- src/conf/domain_conf.c | 11 ++++-- src/conf/domain_conf.h | 4 --- src/interface/interface_backend_udev.c | 2 +- src/qemu/qemu_interface.c | 8 ++--- src/uml/uml_conf.c | 4 +-- src/util/virnetdev.h | 5 +++ src/util/virnetdevmacvlan.c | 65 ++++++++++++++-------------------- src/util/virnetdevmacvlan.h | 6 ++++ 10 files changed, 57 insertions(+), 58 deletions(-) -- 2.9.3

2 5

[libvirt] [PATCH v2 0/5] add support for qemu-xhci USB controller
by Pavel Hrdina 28 Apr '17

28 Apr '17

Pavel Hrdina (5): qemu: change the logic of setting default USB controller qemu: use nec-usb-xhci as a default controller for aarch64 if available qemu: introduce QEMU_CAPS_DEVICE_QEMU_XHCI qemu: add support for qemu-xhci USB controller qemu: use qemu-xhci USB controller by default for ppc64 and aarch64 docs/formatdomain.html.in | 4 +- docs/schemas/domaincommon.rng | 1 + src/conf/domain_addr.c | 1 + src/conf/domain_conf.c | 1 + src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 8 +++- src/qemu/qemu_domain.c | 47 ++++++++++++++-------- src/qemu/qemu_domain_address.c | 1 + tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 + ...muxml2argv-aarch64-usb-controller-nec-xhci.args | 19 +++++++++ ...emuxml2argv-aarch64-usb-controller-nec-xhci.xml | 16 ++++++++ ...uxml2argv-aarch64-usb-controller-qemu-xhci.args | 19 +++++++++ ...muxml2argv-aarch64-usb-controller-qemu-xhci.xml | 16 ++++++++ ...emuxml2argv-ppc64-usb-controller-qemu-xhci.args | 19 +++++++++ ...qemuxml2argv-ppc64-usb-controller-qemu-xhci.xml | 1 + ...qemuxml2argv-usb-controller-qemu-xhci-limit.xml | 14 +++++++ ...l2argv-usb-controller-qemu-xhci-unavailable.xml | 1 + .../qemuxml2argv-usb-controller-qemu-xhci.args | 19 +++++++++ .../qemuxml2argv-usb-controller-qemu-xhci.xml | 14 +++++++ tests/qemuxml2argvtest.c | 15 +++++++ 22 files changed, 201 insertions(+), 20 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-usb-controller-nec-xhci.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-usb-controller-nec-xhci.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-usb-controller-qemu-xhci.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-usb-controller-qemu-xhci.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-ppc64-usb-controller-qemu-xhci.args create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-ppc64-usb-controller-qemu-xhci.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-controller-qemu-xhci-limit.xml create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-usb-controller-qemu-xhci-unavailable.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-controller-qemu-xhci.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-controller-qemu-xhci.xml -- 2.12.2

2 17

[libvirt] [PATCH v2 0/2] don't kill qemu process on restart if networkNotify fails
by Laine Stump 28 Apr '17

28 Apr '17

John thought I didn't go far enough in my removal of return codes in V1... Laine Stump (2): qemu: don't kill qemu process on restart if networkNotify fails network: better log message when network is inactive during reconnect src/network/bridge_driver.c | 17 +++++++++++------ src/network/bridge_driver.h | 7 +++---- src/qemu/qemu_process.c | 9 +++------ 3 files changed, 17 insertions(+), 16 deletions(-) -- 2.9.3

2 3

[libvirt] [PATCH v4 0/3] libxl: nestedhvm support
by Wim Ten Have 27 Apr '17

27 Apr '17

From: Wim ten Have <wim.ten.have(a)oracle.com> This patch enhances host-passthrough capability to advertise the required vendor CPU virtualization feature which will be used to enable 'nestedhvm' in the libxl driver. Wim ten Have (3): libxl: set nestedhvm for mode host-passthrough xenconfig: add conversions for xen-xl xlconfigtest: add tests for 'nestedhvm' support cfg.mk | 4 +- src/libxl/libxl_conf.c | 39 ++++++++++- src/libxl/libxl_conf.h | 1 + src/libxl/libxl_domain.c | 2 +- src/xenconfig/xen_xl.c | 76 ++++++++++++++++++++++ tests/testutilsxen.c | 30 +++++++++ .../test-fullvirt-nestedhvm-disabled.cfg | 26 ++++++++ .../test-fullvirt-nestedhvm-disabled.xml | 61 +++++++++++++++++ tests/xlconfigdata/test-fullvirt-nestedhvm.cfg | 26 ++++++++ tests/xlconfigdata/test-fullvirt-nestedhvm.xml | 59 +++++++++++++++++ tests/xlconfigtest.c | 2 + 11 files changed, 322 insertions(+), 4 deletions(-) create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm-disabled.cfg create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm-disabled.xml create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm.cfg create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm.xml -- 2.9.3

2 5

[libvirt] [PATCH 0/4] qemu: process: Fix memleaks on VM restart
by Peter Krempa 27 Apr '17

27 Apr '17

Few leaks with automatic pinning, USB addresses and TLS migration, since the private data structure needs to be cleared manually in qemuProcessStop. Peter Krempa (4): qemu: process: Clean automatic NUMA/cpu pinning information on shutdown qemu: process: Don't leak priv->usbaddrs after VM restart qemu: process: Clean up priv->migTLSAlias qemu: Move freeing of PCI address list to qemuProcessStop src/qemu/qemu_domain_address.c | 1 - src/qemu/qemu_process.c | 15 +++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) -- 2.12.2

2 5

[libvirt] [PATCH] qemu: Don't fail if physical size can't be updated in qemuDomainGetBlockInfo
by Peter Krempa 27 Apr '17

27 Apr '17

Since commit c5f6151390 qemuDomainBlockInfo tries to update the "physical" storage size for all network storage and not only block devices. Since the storage driver APIs to do this are not implemented for certain storage types (RBD, iSCSI, ...) the code would fail to retrieve any data since the failure of qemuDomainStorageUpdatePhysical is fatal. Since it's desired to return data even if the total size can't be updated we need to ignore errors from that fucntion and return plausible data. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1442344 --- Notes: This function will require more fixing though. This is just a bandaid to remove the regression. I'll post other patches as follow up later. src/qemu/qemu_driver.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e39de625d..8ff242597 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -11553,10 +11553,12 @@ qemuDomainGetBlockInfo(virDomainPtr dom, if (info->allocation == 0) info->allocation = entry->physical; - if (qemuDomainStorageUpdatePhysical(driver, cfg, vm, disk->src) < 0) - goto endjob; - - info->physical = disk->src->physical; + if (qemuDomainStorageUpdatePhysical(driver, cfg, vm, disk->src) == 0) { + info->physical = disk->src->physical; + } else { + virResetLastError(); + info->physical = entry->physical; + } } else { info->physical = entry->physical; } -- 2.12.2

2 2

[libvirt] [PATCH 00/14] network schema refactor and addition of cookies for http disks
by Peter Krempa 27 Apr '17

27 Apr '17

Peter Krempa (14): docs: schemas: Remove <interleave> from file/block/dir/volume disks docs: schemas: Extract disk source host specification docs: schemas: Move the interleave definition into network disk source docs: schemas: Extract RBD-specific data docs: schemas: Extract HTTP disk source specification docs: schemas: Split out simple network protocols docs: schemas: Split up definitions for NBD and gluster conf: Extract formatting of network disk source into separate function tests: genericxml2xml: Add test case for HTTP based disk util: string: Introduce virStringHasChars conf: Add support for cookies for HTTP based disks qemu: command: Use switch to formatting additional network disk params qemu: capabilities: Add capability for the new curl driver options qemu: command: Add support for HTTP cookies docs/formatdomain.html.in | 9 + docs/schemas/domaincommon.rng | 316 +++++++++++++-------- src/conf/domain_conf.c | 205 ++++++++++--- src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 48 +++- src/util/virstoragefile.c | 124 ++++++++ src/util/virstoragefile.h | 14 + src/util/virstring.c | 23 +- src/util/virstring.h | 2 + .../generic-disk-network-http.xml | 48 ++++ tests/genericxml2xmltest.c | 1 + tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 + .../qemuxml2argv-disk-drive-network-http.args | 32 +++ .../qemuxml2argv-disk-drive-network-http.xml | 48 ++++ tests/qemuxml2argvtest.c | 1 + 16 files changed, 701 insertions(+), 174 deletions(-) create mode 100644 tests/genericxml2xmlindata/generic-disk-network-http.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-http.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-http.xml -- 2.12.2

3 31

[libvirt] [PATCH 0/3] qemu: Allow turing of SSL verification for https/ftps drives
by Peter Krempa 27 Apr '17

27 Apr '17

This is a followup to the qemu cookie series and should be applied on top of it. Since I already fixed a few things in the original series this would not apply cleanly, thus you can fetch it at: git fetch git://pipo.sk/pipo/libvirt.git qemu-ssl-verify-off Peter Krempa (3): conf: Use only one temporary string in virDomainDiskSourceParse conf: Add support for modifying ssl validation for https/ftps disks qemu: command: Implement ssl verification configuration docs/formatdomain.html.in | 9 ++++ docs/schemas/domaincommon.rng | 50 +++++++++++++++++++++- src/conf/domain_conf.c | 34 ++++++++++++--- src/qemu/qemu_command.c | 27 +++++++++++- src/util/virstoragefile.h | 1 + .../generic-disk-network-http.xml | 2 + .../qemuxml2argv-disk-drive-network-http.args | 2 +- .../qemuxml2argv-disk-drive-network-http.xml | 1 + 8 files changed, 114 insertions(+), 12 deletions(-) -- 2.12.2

1 3

[libvirt] [PATCH 0/3] add support for qemu-xhci USB controller
by Pavel Hrdina 27 Apr '17

27 Apr '17

Pavel Hrdina (3): qemu: introduce QEMU_CAPS_DEVICE_QEMU_XHCI qemu: add support for qemu-xhci USB controller qemu: use qemu-xhci USB controller by default for ppc64 and aarch64 docs/formatdomain.html.in | 2 +- docs/schemas/domaincommon.rng | 1 + src/conf/domain_addr.c | 1 + src/conf/domain_conf.c | 1 + src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 8 +++++-- src/qemu/qemu_domain.c | 25 ++++++++++++++------ src/qemu/qemu_domain_address.c | 1 + tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 + ...uxml2argv-aarch64-usb-controller-qemu-xhci.args | 20 ++++++++++++++++ ...muxml2argv-aarch64-usb-controller-qemu-xhci.xml | 27 ++++++++++++++++++++++ ...emuxml2argv-ppc64-usb-controller-qemu-xhci.args | 19 +++++++++++++++ ...qemuxml2argv-ppc64-usb-controller-qemu-xhci.xml | 1 + ...qemuxml2argv-usb-controller-qemu-xhci-limit.xml | 15 ++++++++++++ ...l2argv-usb-controller-qemu-xhci-unavailable.xml | 15 ++++++++++++ .../qemuxml2argv-usb-controller-qemu-xhci.args | 19 +++++++++++++++ .../qemuxml2argv-usb-controller-qemu-xhci.xml | 15 ++++++++++++ tests/qemuxml2argvtest.c | 12 ++++++++++ 20 files changed, 177 insertions(+), 10 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-usb-controller-qemu-xhci.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-usb-controller-qemu-xhci.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-ppc64-usb-controller-qemu-xhci.args create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-ppc64-usb-controller-qemu-xhci.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-controller-qemu-xhci-limit.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-controller-qemu-xhci-unavailable.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-controller-qemu-xhci.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-controller-qemu-xhci.xml -- 2.12.2

4 14

[libvirt] [PATCH 0/2] Report VIR_DOMAIN_JOB_OPERATION in job stats
by Jiri Denemark 27 Apr '17

27 Apr '17

As agreed in [1] we should enhance job statistics returned by virDomainGetJobStats API and VIR_DOMAIN_EVENT_ID_JOB_COMPLETED event with a new typed parameter which would indicate what operation (migration, snapshot, ...) the reported statistics belong to. https://bugzilla.redhat.com/show_bug.cgi?id=1441563 [1] https://www.redhat.com/archives/libvir-list/2017-April/msg00540.html Jiri Denemark (2): Add VIR_DOMAIN_JOB_OPERATION typed parameter qemu: Report VIR_DOMAIN_JOB_OPERATION include/libvirt/libvirt-domain.h | 25 +++++++++++++++++++++++++ src/qemu/qemu_domain.c | 16 +++++++++++++--- src/qemu/qemu_domain.h | 4 +++- src/qemu/qemu_driver.c | 32 ++++++++++++++++++++++---------- src/qemu/qemu_migration.c | 19 ++++++++++++------- src/qemu/qemu_process.c | 6 ++++-- src/qemu/qemu_process.h | 3 ++- tools/virsh-domain.c | 29 +++++++++++++++++++++++++++++ 8 files changed, 110 insertions(+), 24 deletions(-) -- 2.12.2

2 4

[libvirt] [PATCH 0/2] don't kill qemu process on restart if networkNotify fails
by Laine Stump 27 Apr '17

27 Apr '17

The individual patches explain themselves. Laine Stump (2): qemu: don't kill qemu process on restart if networkNotify fails network: better log message when network is inactive during reconnect src/network/bridge_driver.c | 7 +++++++ src/qemu/qemu_process.c | 9 +++------ 2 files changed, 10 insertions(+), 6 deletions(-) -- 2.9.3

2 8

[libvirt] [PATCH 0/4] Couple of trivial c89 style fixes
by Michal Privoznik 27 Apr '17

27 Apr '17

*** BLURB HERE *** BLURB Michal Privoznik (4): examples: Properly include getopt.h vmwarevertest: drop VIR_FROM_THIS definition lib: Fix c99 style comments cpu: Avoid c99 style of assembler examples/admin/logging.c | 14 +++++++------- examples/openauth/openauth.c | 2 +- src/cpu/cpu_ppc64.c | 4 ++-- src/cpu/cpu_x86.c | 44 +++++++++++++++++++++---------------------- src/lxc/lxc_controller.c | 2 +- src/remote/remote_driver.c | 2 +- src/rpc/virnetservermdns.c | 2 +- src/security/security_stack.c | 8 ++++---- src/uml/uml_conf.c | 2 +- src/util/virhostcpu.c | 4 ++-- src/util/virhostmem.c | 4 ++-- src/vbox/vbox_snapshot_conf.c | 2 +- tests/eventtest.c | 2 +- tests/virhostcpumock.c | 2 +- tests/vmwarevertest.c | 2 -- 15 files changed, 47 insertions(+), 49 deletions(-) -- 2.10.2

3 14

[libvirt] [PATCH v2 0/3] Cleanup messages after hotplug of scsi hostdev
by Eric Farman 27 Apr '17

27 Apr '17

v1 was here: https://www.redhat.com/archives/libvir-list/2017-April/msg01066.html Per review, removed the "internal error" messages and split the resulting patch into patches 2 (virtio-scsi) and 3 (vhost-scsi). Patch 1 fixes a return code check that is a little off. Eric Farman (3): qemu: Check return code from qemuHostdevPrepareSCSIDevices qemu: Remove extra messages from virtio-scsi hotplug qemu: Remove extra messages for vhost-scsi hotplug src/qemu/qemu_hotplug.c | 24 ++---------------------- 1 file changed, 2 insertions(+), 22 deletions(-) -- 1.9.1

2 4

[libvirt] [PATCH 0/2] qemu: migration: bugfixes for cancelling drive mirror
by Nikolay Shirokovskiy 27 Apr '17

27 Apr '17

Nikolay Shirokovskiy (2): qemu: take current async job into account in qemuBlockNodeNamesDetect qemu: migration: fix race on cancelling drive mirror src/qemu/qemu_block.c | 6 ++++-- src/qemu/qemu_block.h | 4 +++- src/qemu/qemu_blockjob.c | 9 ++++++--- src/qemu/qemu_blockjob.h | 4 ++++ src/qemu/qemu_driver.c | 11 ++++++----- src/qemu/qemu_migration.c | 43 +++++++++++++++++++++++++++++++------------ src/qemu/qemu_process.c | 2 +- 7 files changed, 55 insertions(+), 24 deletions(-) -- 1.8.3.1

2 5

Re: [libvirt] [PATCH v3] Add support for Veritas HyperScale (VxHS) block device protocol
by ashish mittal 27 Apr '17

27 Apr '17

Hi, I'm trying to figure out what changes are needed in the libvirt vxhs patch to support passing TLS X509 arguments to qemu, similar to the following - Sample QEMU command line passing TLS credentials to the VxHS block device (run in secure mode): ./qemu-io --object tls-creds-x509,id=tls0,dir=/etc/pki/qemu/vxhs,endpoint=client -c 'read -v 66000 2.5k' 'json:{"server.host": "127.0.0.1", "server.port": "9999", "vdisk-id": "/test.raw", "driver": "vxhs", "tls-creds":"tls0"}' I was hoping to find some NBD code related to this, but not able to locate it. Any pointers will be appreciated. Thanks, Ashish On Wed, Feb 1, 2017 at 8:36 AM, John Ferlan <jferlan(a)redhat.com> wrote: > [...] > Pressed send too soon, sigh. > > >>>> >>>> #1. Based on Peter's v2 comments, we don't want to support the >>>> older/legacy syntax for VxHS, so it's something that should be removed - >>>> although we should check for it being present and fail if found. >>>> >>> >>> I am testing with changed code to return error if legacy syntax is >>> found for VxHS. Also added a test case to check for failure on legacy >>> syntax and it seems to pass (test #41 below). >>> >>> Then I added a pass test case to check conversion from new native >>> syntax to XML (test #40 below). That test fails with error >>> 'qemuParseCommandLineDisk:901 : internal error: missing file parameter >>> in drive 'file.driver=vxhs,file.vdisk-id=eb90327c-8302-4725-9e1b...' >> >> The qemu_parse_command.c changes while nice to have weren't even updated >> when multiple gluster servers were added (e.g. commit id '' or '7b7da9e28') >> Check the changes to add the new s >> >> IOW: This code knows how to parse something like: >> >> -drive >> 'file=gluster+unix:///Volume2/Image?socket=/path/to/sock,format=raw,if=none,id=drive-virtio-disk1' >> >> but it's clueless for: >> >> -drive file.driver=gluster,file.volume=Volume3,file.path=/Image.qcow2,\ >> file.server.0.type=tcp,file.server.0.host=example.org,file.server.0.port=6000,\ >> file.server.1.type=tcp,file.server.1.host=example.org,file.server.1.port=24007,\ >> file.server.2.type=unix,file.server.2.socket=/path/to/sock,format=qcow2,\ >> if=none,id=drive-virtio-disk2 \ >> -device virtio-blk-pci,bus=pci.0,addr=0x5,drive=drive-virtio-disk2,\ >> id=virtio-disk2 >> >> See >>> >>> Looks like none of the existing tests in qemuargv2xmltest test for the >>> parsing of new syntax, and qemuParseCommandLineDisk() expects to find >>> 'file=' for a drive or it errors out. If this is true, will it be able >>> to parse the new syntax? Some help here please! > > So I wouldn't expect the VxHS code to be able to do that unless you > wanted to be adventurous. The good news is that this code is primarily > for developers that need to take a qemu command line to generate the > libvirt syntax. It has not really been kept up to date with all the most > recent command line changes. I started to try over a year ago, but got > very side tracked. > >>> >>> Output from the newly added test cases (40 should pass and 41 checks >>> for error) : >>> >>> 40) QEMU ARGV-2-XML disk-drive-network-vxhs >>> ... Got unexpected warning from qemuParseCommandLineString: >>> 2017-01-28 00:57:30.814+0000: 10391: info : libvirt version: 3.0.0 >>> 2017-01-28 00:57:30.814+0000: 10391: info : hostname: localhost.localdomain >>> 2017-01-28 00:57:30.814+0000: 10391: error : >>> qemuParseCommandLineDisk:901 : internal error: missing file parameter >>> in drive 'file.driver=vxhs,file.vdisk-id=eb90327c-8302-4725-9e1b-4e85ed4dc251,file.server.host=192.168.0.1,file.server.port=9999,format=raw,if=none,id=drive-virtio-disk0,cache=none' >>> libvirt: QEMU Driver error : internal error: missing file parameter in >>> drive 'file.driver=vxhs,file.vdisk-id=eb90327c-8302-4725-9e1b-4e85ed4dc251,file.server.host=192.168.0.1,file.server.port=9999,format=raw,if=none,id=drive-virtio-disk0,cache=none' >>> FAILED >>> >>> 41) QEMU ARGV-2-XML disk-drive-network-vxhs-fail >>> ... Got expected error from qemuParseCommandLineString: >>> libvirt: QEMU Driver error : internal error: VxHS protocol does not >>> support URI syntax >>> 'vxhs://192.168.0.1:9999/eb90327c-8302-4725-9e1b-4e85ed4dc251' >>> OK >>> 42) QEMU ARGV-2-XML disk-usb ... OK >>> >>> >>> >>>> #2. Is the desire to ever support more than 1 host? If not, then is the >>>> "server" syntax you've borrowed from the Gluster code necessary? Could >>>> you just go with the single "host" like NBD and SSH. As it relates to >>>> the qemu command line - I'm not quite as clear. From the example I see >>>> in commit id '7b7da9e28', the gluster syntax would have: >>>> >>> >>> Present understanding is to have only one host. You are right, the >>> "server" part is not necessary. Will have to check with the qemu >>> community on this change. >>> >>>> +file.server.0.type=tcp,file.server.0.host=example.org,file.server.0.port=6000,\ >>>> +file.server.1.type=tcp,file.server.1.host=example.org,file.server.1.port=24007,\ >>>> +file.server.2.type=unix,file.server.2.socket=/path/to/sock,format=qcow2,\ >>>> >>>> whereas, the VxHS syntax is: >>>> +file.server.host=192.168.0.1,file.server.port=9999,format=raw,if=none,\ >>>> >>>> FWIW: I also note there is no ".type=tcp" in your output - so perhaps >>>> the "default" is tcp unless otherwise specified, but I'm sure of the >>>> qemu syntax requirements in this area. I assume that since there's only >>>> 1 server, the ".0, .1, .2" become unnecessary (something added by commit >>>> id 'f1bbc7df4' for multiple gluster hosts). >>>> >>> >>> That's correct. TCP is the default. >>> >>>> I haven't closedly followed the qemu syntax discussion, but it would it >>>> would be possible to use: >>>> >>>> +file.host=192.168.0.1,file.port=9999 >>>> >>> >>> That is correct. Above syntax would also work for us. I will pose this >>> suggestion to the qemu community and update with their response. >>> > > It's not that important... I was looking for a simplification and > generation of only what's required. You can continue using the server > syntax - perhaps just leave a note/comment in the code indicating the > decision point and move on. > > [...] > > John

2 11

[libvirt] [PATCH] qemu: numa: Don't return automatic nodeset for inactive domain
by Peter Krempa 27 Apr '17

27 Apr '17

qemuDomainGetNumaParameters would return the automatic nodeset even for the persistent config if the domain was running. This is incorrect since the automatic nodeset will be re-queried upon starting the vm. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1445325 --- src/qemu/qemu_driver.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e39de625d..1ba3e0943 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -9461,6 +9461,8 @@ qemuDomainGetNumaParameters(virDomainPtr dom, char *nodeset = NULL; int ret = -1; virDomainDefPtr def = NULL; + bool live = false; + virBitmapPtr autoNodeset = NULL; virCheckFlags(VIR_DOMAIN_AFFECT_LIVE | VIR_DOMAIN_AFFECT_CONFIG | @@ -9473,9 +9475,12 @@ qemuDomainGetNumaParameters(virDomainPtr dom, if (virDomainGetNumaParametersEnsureACL(dom->conn, vm->def) < 0) goto cleanup; - if (!(def = virDomainObjGetOneDef(vm, flags))) + if (!(def = virDomainObjGetOneDefState(vm, flags, &live))) goto cleanup; + if (live) + autoNodeset = priv->autoNodeset; + if ((*nparams) == 0) { *nparams = QEMU_NB_NUMA_PARAM; ret = 0; @@ -9496,8 +9501,7 @@ qemuDomainGetNumaParameters(virDomainPtr dom, break; case 1: /* fill numa nodeset here */ - nodeset = virDomainNumatuneFormatNodeset(def->numa, - priv->autoNodeset, -1); + nodeset = virDomainNumatuneFormatNodeset(def->numa, autoNodeset, -1); if (!nodeset || virTypedParameterAssign(param, VIR_DOMAIN_NUMA_NODESET, VIR_TYPED_PARAM_STRING, nodeset) < 0) -- 2.12.2

2 1

[libvirt] [PATCH] qemu: Properly reset non-p2p migration
by Jiri Denemark 27 Apr '17

27 Apr '17

While peer-to-peer migration enters the Confirm phase even if the Perform phase fails, the client which initiated a non-p2p migration will never call virDomainMigrateConfirm* API if the Perform phase failed. Thus we need to explicitly reset migration before reporting a failure from the Perform phase API. https://bugzilla.redhat.com/show_bug.cgi?id=1425003 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_migration.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 09adb0484..42da706c9 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -4914,10 +4914,13 @@ qemuMigrationPerformPhase(virQEMUDriverPtr driver, goto endjob; endjob: - if (ret < 0) + if (ret < 0) { + qemuMigrationReset(driver, vm, QEMU_ASYNC_JOB_MIGRATION_OUT); qemuMigrationJobFinish(driver, vm); - else + } else { qemuMigrationJobContinue(vm); + } + if (!virDomainObjIsActive(vm)) qemuDomainRemoveInactive(driver, vm); -- 2.12.2

2 1

[libvirt] [PATCH] util: Remove unused variate @errbuf in virPCIGetDeviceAddressFromSysfsLink
by Wang King 27 Apr '17

27 Apr '17

From: w00185384 <king.wang(a)huawei.com> Since refactoring by commit id 'a7035662', @errbuf is no longer used. --- src/util/virpci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/util/virpci.c b/src/util/virpci.c index c89b94b..83c7e74 100644 --- a/src/util/virpci.c +++ b/src/util/virpci.c @@ -2618,7 +2618,6 @@ virPCIGetDeviceAddressFromSysfsLink(const char *device_link) virPCIDeviceAddressPtr bdf = NULL; char *config_address = NULL; char *device_path = NULL; - char errbuf[64]; if (!virFileExists(device_link)) { VIR_DEBUG("'%s' does not exist", device_link); @@ -2627,7 +2626,6 @@ virPCIGetDeviceAddressFromSysfsLink(const char *device_link) device_path = canonicalize_file_name(device_link); if (device_path == NULL) { - memset(errbuf, '\0', sizeof(errbuf)); virReportSystemError(errno, _("Failed to resolve device link '%s'"), device_link); -- 2.8.3

2 1

[libvirt] [PATCH] locking: Add support for sanlock_strerror
by Jiri Denemark 27 Apr '17

27 Apr '17

The recently added sanlock_strerror function can be used to translate sanlock's numeric errors into human readable strings. https://bugzilla.redhat.com/show_bug.cgi?id=1409511 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- m4/virt-sanlock.m4 | 7 ++ src/locking/lock_driver_sanlock.c | 154 ++++++++++++++++++++++++++------------ 2 files changed, 115 insertions(+), 46 deletions(-) diff --git a/m4/virt-sanlock.m4 b/m4/virt-sanlock.m4 index e4476cae4..00de7980e 100644 --- a/m4/virt-sanlock.m4 +++ b/m4/virt-sanlock.m4 @@ -61,6 +61,13 @@ AC_DEFUN([LIBVIRT_CHECK_SANLOCK],[ [whether sanlock supports sanlock_write_lockspace]) fi + AC_CHECK_LIB([sanlock_client], [sanlock_strerror], + [sanlock_strerror=yes], [sanlock_strerror=no]) + if test "x$sanlock_strerror" = "xyes" ; then + AC_DEFINE_UNQUOTED([HAVE_SANLOCK_STRERROR], 1, + [whether sanlock supports sanlock_strerror]) + fi + CPPFLAGS="$old_cppflags" LIBS="$old_libs" fi diff --git a/src/locking/lock_driver_sanlock.c b/src/locking/lock_driver_sanlock.c index 280219f72..b5e69c472 100644 --- a/src/locking/lock_driver_sanlock.c +++ b/src/locking/lock_driver_sanlock.c @@ -97,6 +97,25 @@ struct _virLockManagerSanlockPrivate { bool registered; }; + +static bool +ATTRIBUTE_NONNULL(2) +virLockManagerSanlockError(int err, + char **message) +{ + if (err <= -200) { +#if HAVE_SANLOCK_STRERROR + ignore_value(VIR_STRDUP_QUIET(*message, sanlock_strerror(err))); +#else + ignore_value(virAsprintfQuiet(message, _("sanlock error %d"), err)); +#endif + return true; + } else { + return false; + } +} + + /* * sanlock plugin for the libvirt virLockManager API */ @@ -263,14 +282,17 @@ virLockManagerSanlockSetupLockspace(virLockManagerSanlockDriverPtr driver) } if ((rv = sanlock_align(&ls.host_id_disk)) < 0) { - if (rv <= -200) + char *err = NULL; + if (virLockManagerSanlockError(rv, &err)) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unable to query sector size %s: error %d"), - path, rv); - else + _("Unable to query sector size %s: %s"), + path, NULLSTR(err)); + VIR_FREE(err); + } else { virReportSystemError(-rv, _("Unable to query sector size %s"), path); + } goto error_unlink; } @@ -292,14 +314,17 @@ virLockManagerSanlockSetupLockspace(virLockManagerSanlockDriverPtr driver) } if ((rv = virLockManagerSanlockInitLockspace(driver, &ls) < 0)) { - if (rv <= -200) + char *err = NULL; + if (virLockManagerSanlockError(rv, &err)) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unable to initialize lockspace %s: error %d"), - path, rv); - else + _("Unable to initialize lockspace %s: %s"), + path, NULLSTR(err)); + VIR_FREE(err); + } else { virReportSystemError(-rv, _("Unable to initialize lockspace %s"), path); + } goto error_unlink; } VIR_DEBUG("Lockspace %s has been initialized", path); @@ -362,14 +387,17 @@ virLockManagerSanlockSetupLockspace(virLockManagerSanlockDriverPtr driver) goto retry; } if (-rv != EEXIST) { - if (rv <= -200) + char *err = NULL; + if (virLockManagerSanlockError(rv, &err)) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unable to add lockspace %s: error %d"), - path, rv); - else + _("Unable to add lockspace %s: %s"), + path, NULLSTR(err)); + VIR_FREE(err); + } else { virReportSystemError(-rv, _("Unable to add lockspace %s"), path); + } goto error; } else { VIR_DEBUG("Lockspace %s is already registered", path); @@ -694,14 +722,17 @@ virLockManagerSanlockCreateLease(virLockManagerSanlockDriverPtr driver, } if ((rv = sanlock_align(&res->disks[0])) < 0) { - if (rv <= -200) + char *err = NULL; + if (virLockManagerSanlockError(rv, &err)) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unable to query sector size %s: error %d"), - res->disks[0].path, rv); - else + _("Unable to query sector size %s: %s"), + res->disks[0].path, NULLSTR(err)); + VIR_FREE(err); + } else { virReportSystemError(-rv, _("Unable to query sector size %s"), res->disks[0].path); + } goto error_unlink; } @@ -723,14 +754,17 @@ virLockManagerSanlockCreateLease(virLockManagerSanlockDriverPtr driver, } if ((rv = sanlock_init(NULL, res, 0, 0)) < 0) { - if (rv <= -200) + char *err = NULL; + if (virLockManagerSanlockError(rv, &err)) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unable to initialize lease %s: error %d"), - res->disks[0].path, rv); - else + _("Unable to initialize lease %s: %s"), + res->disks[0].path, NULLSTR(err)); + VIR_FREE(err); + } else { virReportSystemError(-rv, _("Unable to initialize lease %s"), res->disks[0].path); + } goto error_unlink; } VIR_DEBUG("Lease %s has been initialized", res->disks[0].path); @@ -867,10 +901,12 @@ virLockManagerSanlockRegisterKillscript(int sock, } if ((rv = sanlock_killpath(sock, 0, path, args)) < 0) { - if (rv <= -200) { + char *err = NULL; + if (virLockManagerSanlockError(rv, &err)) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Failed to register lock failure action:" - " error %d"), rv); + _("Failed to register lock failure action: %s"), + NULLSTR(err)); + VIR_FREE(err); } else { virReportSystemError(-rv, "%s", _("Failed to register lock failure" @@ -934,13 +970,16 @@ static int virLockManagerSanlockAcquire(virLockManagerPtr lock, if (priv->vm_pid == getpid()) { VIR_DEBUG("Register sanlock %d", flags); if ((sock = sanlock_register()) < 0) { - if (sock <= -200) + char *err = NULL; + if (virLockManagerSanlockError(sock, &err)) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Failed to open socket to sanlock daemon: error %d"), - sock); - else + _("Failed to open socket to sanlock daemon: %s"), + NULLSTR(err)); + VIR_FREE(err); + } else { virReportSystemError(-sock, "%s", _("Failed to open socket to sanlock daemon")); + } goto error; } @@ -971,14 +1010,17 @@ static int virLockManagerSanlockAcquire(virLockManagerPtr lock, if ((rv = sanlock_state_to_args((char *)state, &res_count, &res_args)) < 0) { - if (rv <= -200) + char *err = NULL; + if (virLockManagerSanlockError(rv, &err)) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unable to parse lock state %s: error %d"), - state, rv); - else + _("Unable to parse lock state %s: %s"), + state, NULLSTR(err)); + VIR_FREE(err); + } else { virReportSystemError(-rv, _("Unable to parse lock state %s"), state); + } goto error; } res_free = true; @@ -992,12 +1034,16 @@ static int virLockManagerSanlockAcquire(virLockManagerPtr lock, if ((rv = sanlock_acquire(sock, priv->vm_pid, 0, priv->res_count, priv->res_args, opt)) < 0) { - if (rv <= -200) + char *err = NULL; + if (virLockManagerSanlockError(rv, &err)) { virReportError(VIR_ERR_RESOURCE_BUSY, - _("Failed to acquire lock: error %d"), rv); - else + _("Failed to acquire lock: %s"), + NULLSTR(err)); + VIR_FREE(err); + } else { virReportSystemError(-rv, "%s", _("Failed to acquire lock")); + } goto error; } } @@ -1016,12 +1062,16 @@ static int virLockManagerSanlockAcquire(virLockManagerPtr lock, if (flags & VIR_LOCK_MANAGER_ACQUIRE_RESTRICT) { if ((rv = sanlock_restrict(sock, SANLK_RESTRICT_ALL)) < 0) { - if (rv <= -200) + char *err = NULL; + if (virLockManagerSanlockError(rv, &err)) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Failed to restrict process: error %d"), rv); - else + _("Failed to restrict process: %s"), + NULLSTR(err)); + VIR_FREE(err); + } else { virReportSystemError(-rv, "%s", _("Failed to restrict process")); + } goto error; } } @@ -1068,12 +1118,16 @@ static int virLockManagerSanlockRelease(virLockManagerPtr lock, if (state) { if ((rv = sanlock_inquire(-1, priv->vm_pid, 0, &res_count, state)) < 0) { - if (rv <= -200) + char *err = NULL; + if (virLockManagerSanlockError(rv, &err)) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Failed to inquire lock: error %d"), rv); - else + _("Failed to inquire lock: %s"), + NULLSTR(err)); + VIR_FREE(err); + } else { virReportSystemError(-rv, "%s", _("Failed to inquire lock")); + } return -1; } @@ -1083,12 +1137,16 @@ static int virLockManagerSanlockRelease(virLockManagerPtr lock, if ((rv = sanlock_release(-1, priv->vm_pid, 0, res_count, priv->res_args)) < 0) { - if (rv <= -200) + char *err = NULL; + if (virLockManagerSanlockError(rv, &err)) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Failed to release lock: error %d"), rv); - else + _("Failed to release lock: %s"), + NULLSTR(err)); + VIR_FREE(err); + } else { virReportSystemError(-rv, "%s", _("Failed to release lock")); + } return -1; } @@ -1118,12 +1176,16 @@ static int virLockManagerSanlockInquire(virLockManagerPtr lock, } if ((rv = sanlock_inquire(-1, priv->vm_pid, 0, &res_count, state)) < 0) { - if (rv <= -200) + char *err; + if (virLockManagerSanlockError(rv, &err)) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Failed to inquire lock: error %d"), rv); - else + _("Failed to inquire lock: %s"), + NULLSTR(err)); + VIR_FREE(err); + } else { virReportSystemError(-rv, "%s", _("Failed to inquire lock")); + } return -1; } -- 2.12.2

2 2

[libvirt] [PATCH] qemu: Ignore missing query-migrate-parameters
by Jiri Denemark 27 Apr '17

27 Apr '17

Trivially no migration parameters are supported when query-migrate-parameters QMP command is missing. There's no need to report an error in such case especially when doing so breaks compatibility with old QEMU. https://bugzilla.redhat.com/show_bug.cgi?id=1441934 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_monitor_json.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 98e3c53f5..083729003 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -2660,6 +2660,11 @@ qemuMonitorJSONGetMigrationParams(qemuMonitorPtr mon, if (qemuMonitorJSONCommand(mon, cmd, &reply) < 0) goto cleanup; + if (qemuMonitorJSONHasError(reply, "CommandNotFound")) { + ret = 0; + goto cleanup; + } + if (qemuMonitorJSONCheckError(cmd, reply) < 0) goto cleanup; -- 2.12.2

2 3

[libvirt] [ROC] migration: set cpu throttle value by workload
by Chao Fan 27 Apr '17

27 Apr '17

Hi all, When migrating a guest which consumes too much CPU & memory, dirty pages amount will increase significantly, so does the migration time, migration can not even complete, at worst. So I made an RFC patch in QEMU to set cpu throttle value by workload when migration. The test result and the RFC patch are here: https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg03479.html But this idea was not accepted by QEMU community. So I want to do a similar feature in libvirt: Step 1: Add --auto-converge-smart parameter to migrate. Step 2: Add a timer in qemu-driver to get the 'info migrate' to check if the dirty-pages-rate updated every 1 second or 0.5 second when migration. Step 3: If updated, change the cpu throttle value according to the dirty-pages-rate and page-size by 'migrate_set_parameter cpu-throttle-increment' I think this feature makes auto-converge smarter than leaving the cpu throttle value with default 20/10 or set by users. And also it can save time. Any comments will be welcome. Thanks, Chao Fan

3 3

[libvirt] Errors related to Per-node memory binding and huge pages per NUMA node.
by Vinod Chegu 27 Apr '17

27 Apr '17

Hi Daniel et.al, Running into the following errors when attempting to start up a multi-vNUMA node VM backed by 1G huge page per physical NUMA node. (details below) error: unsupported configuration: Per-node memory binding is not supported with this QEMU (or in another case) error: unsupported configuration: huge pages per NUMA node are not supported with this QEMU What am I missing ? Thanks! Vinod System : (CentOS 7.3) --------- # numactl -H available: 2 nodes (0-1) node 0 cpus: 0 1 2 3 4 5 6 7 16 17 18 19 20 21 22 23 node 0 size: 65320 MB node 0 free: 62672 MB node 1 cpus: 8 9 10 11 12 13 14 15 24 25 26 27 28 29 30 31 node 1 size: 65536 MB node 1 free: 63323 MB node distances: node 0 1 0: 10 20 1: 20 10 # uname -a Linux <hostname> 3.10.0-514.el7.x86_64 #1 SMP Tue Nov 22 16:42:41 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux # virsh version Compiled against library: libvirt 2.0.0 Using library: libvirt 2.0.0 Using API: QEMU 2.0.0 Running hypervisor: QEMU 1.5.3 # cat /proc/cmdline BOOT_IMAGE=/vmlinuz-3.10.0-514.el7.x86_64 root=/dev/mapper/cl-root ro crashkernel=auto rd.lvm.lv=cl/root rd.lvm.lv=cl/swap rhgb quiet LANG=en_US.UTF-8 intel_iommu=on iommu=pt default_hugepagesz=1G hugepagesz=1G hugepages=16 hugepagesz=2M hugepages=4096 # mount ... ... none on /dev/hugepages1G type hugetlbfs (rw,relatime,seclabel,pagesize=1G) none on /dev/hugepages2M type hugetlbfs (rw,relatime,seclabel,pagesize=2M) ----------- Test 1: 1G Huge page memoryBacking & memory binding per numa node, and virtual numa nodes. -------- <domain type='kvm'> <name>vm1</name> <uuid>62077ba4-9d7a-4b81-8dfb-b0cd55693cc2</uuid> <memory unit='KiB'>8388608</memory> <currentMemory unit='KiB'>8388608</currentMemory> <memtune> <hard_limit unit='KiB'>9437184</hard_limit> </memtune> <memoryBacking> <hugepages> <page size='1048576' unit='KiB' nodeset='0'/> <page size='1048576' unit='KiB' nodeset='1'/> </hugepages> </memoryBacking> <vcpu placement='static'>4</vcpu> <cputune> <vcpupin vcpu='0' cpuset='1'/> <vcpupin vcpu='1' cpuset='2'/> <vcpupin vcpu='2' cpuset='8'/> <vcpupin vcpu='3' cpuset='9'/> </cputune> <numatune> <memory mode='strict' nodeset='0-1'/> <memnode cellid='0' mode='strict' nodeset='0'/> <memnode cellid='1' mode='strict' nodeset='1'/> </numatune> <os> <type arch='x86_64' machine='pc-i440fx-rhel7.0.0'>hvm</type> <boot dev='hd'/> </os> <features> <acpi/> <apic/> </features> <cpu mode='custom' match='exact'> <model fallback='allow'>IvyBridge</model> <numa> <cell id='0' cpus='0-1' memory='4194304' unit='KiB'/> <cell id='1' cpus='2-3' memory='4194304' unit='KiB'/> </numa> </cpu> ... # virsh start vm1 error: Failed to start domain vm1 error: unsupported configuration: Per-node memory binding is not supported with this QEMU Test 2: 1G Huge page memoryBacking per NUMA node and virtual numa nodes. ------ <domain type='kvm'> <name>vm1</name> <uuid>62077ba4-9d7a-4b81-8dfb-b0cd55693cc2</uuid> <memory unit='KiB'>8388608</memory> <currentMemory unit='KiB'>8388608</currentMemory> <memtune> <hard_limit unit='KiB'>9437184</hard_limit> </memtune> <memoryBacking> <hugepages> <page size='1048576' unit='KiB' nodeset='0'/> <page size='1048576' unit='KiB' nodeset='1'/> </hugepages> </memoryBacking> <vcpu placement='static'>4</vcpu> <cputune> <vcpupin vcpu='0' cpuset='1'/> <vcpupin vcpu='1' cpuset='2'/> <vcpupin vcpu='2' cpuset='8'/> <vcpupin vcpu='3' cpuset='9'/> </cputune> <os> <type arch='x86_64' machine='pc-i440fx-rhel7.0.0'>hvm</type> <boot dev='hd'/> </os> <features> <acpi/> <apic/> </features> <cpu mode='custom' match='exact'> <model fallback='allow'>IvyBridge</model> <numa> <cell id='0' cpus='0-1' memory='4194304' unit='KiB'/> <cell id='1' cpus='2-3' memory='4194304' unit='KiB'/> </numa> </cpu> ... # virsh start vm1 error: Failed to start domain vm1 error: unsupported configuration: huge pages per NUMA node are not supported with this QEMU Test 3: Only virtual numa nodes. ------ <main type='kvm'> <name>vm1</name> <uuid>62077ba4-9d7a-4b81-8dfb-b0cd55693cc2</uuid> <memory unit='KiB'>8388608</memory> <currentMemory unit='KiB'>8388608</currentMemory> <memtune> <hard_limit unit='KiB'>9437184</hard_limit> </memtune> <vcpu placement='static'>4</vcpu> <cputune> <vcpupin vcpu='0' cpuset='1'/> <vcpupin vcpu='1' cpuset='2'/> <vcpupin vcpu='2' cpuset='8'/> <vcpupin vcpu='3' cpuset='9'/> </cputune> <os> <type arch='x86_64' machine='pc-i440fx-rhel7.0.0'>hvm</type> <boot dev='hd'/> </os> <features> <acpi/> <apic/> </features> <cpu mode='custom' match='exact'> <model fallback='allow'>IvyBridge</model> <numa> <cell id='0' cpus='0-1' memory='4194304' unit='KiB'/> <cell id='1' cpus='2-3' memory='4194304' unit='KiB'/> </numa> </cpu> ... # virsh start vm1 <Success and the guest OS shows the virtual NUMA nodes etc.> Test 4: Only 1G huge page backing per NUMA node ------ <domain type='kvm'> <name>vm1</name> <uuid>62077ba4-9d7a-4b81-8dfb-b0cd55693cc2</uuid> <memory unit='KiB'>8388608</memory> <currentMemory unit='KiB'>8388608</currentMemory> <memtune> <hard_limit unit='KiB'>9437184</hard_limit> </memtune> <memoryBacking> <hugepages> <page size='1048576' unit='KiB' nodeset='0'/> <page size='1048576' unit='KiB' nodeset='1'/> </hugepages> </memoryBacking> <vcpu placement='static'>4</vcpu> <cputune> <vcpupin vcpu='0' cpuset='1'/> <vcpupin vcpu='1' cpuset='2'/> <vcpupin vcpu='2' cpuset='8'/> <vcpupin vcpu='3' cpuset='9'/> </cputune> <os> <type arch='x86_64' machine='pc-i440fx-rhel7.0.0'>hvm</type> <boot dev='hd'/> </os> <features> <acpi/> <apic/> </features> <cpu mode='custom' match='exact'> <model fallback='allow'>IvyBridge</model> </cpu> ... # virsh start vm1 <Success and the 1G pages on the host are consumed for backing VM's memory>

2 1

[libvirt] [PATCH] qemu: Do not overwrite existing messages in hotplug
by Eric Farman 26 Apr '17

26 Apr '17

I tried to attach a SCSI LUN to two different guests, and forgot to specify "shareable" in the hostdev XML. Attaching the device to the second guest failed, but the message was not helpful in telling me what I was doing wrong: $ cat scsi_scratch_disk.xml <hostdev mode='subsystem' type='scsi'> <source> <adapter name='scsi_host3'/> <address bus='0' target='15' unit='1074151456'/> </source> </hostdev> $ virsh attach-device dasd_sles_d99c scsi_scratch_disk.xml Device attached successfully $ virsh attach-device dasd_fedora_0e1e scsi_scratch_disk.xml error: Failed to attach device from scsi_scratch_disk.xml error: internal error: Unable to prepare scsi hostdev: scsi_host3:0:15:1074151456 I eventually discovered my error, but thought it was weird that Libvirt doesn't provide something more helpful in this case. Looking over the code we had just gone through, I commented out the "internal error" message, and got something more useful: $ virsh attach-device dasd_fedora_0e1e scsi_scratch_disk.xml error: Failed to attach device from scsi_scratch_disk.xml error: Requested operation is not valid: SCSI device 3:0:15:1074151456 is already in use by other domain(s) as 'non-shareable' Seems that the virReportError issued for an internal error overwrites one that might have already existed. Rather than remove them altogether (there may be error paths that don't spit out a more helpful message), I thought maybe it'd be best to check if one exists, and exit if one does. If not, the existing internal error messages are probably helpful. Make this adjustment for both virtio-scsi and vhost-scsi devices. Signed-off-by: Eric Farman <farman(a)linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bwalk(a)linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com> --- src/qemu/qemu_hotplug.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 120bcdc..d421a77 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -2470,6 +2470,10 @@ qemuDomainAttachHostSCSIDevice(virConnectPtr conn, if (qemuHostdevPrepareSCSIDevices(driver, vm->def->name, &hostdev, 1)) { virDomainHostdevSubsysSCSIPtr scsisrc = &hostdev->source.subsys.u.scsi; + + if (virGetLastError()) + return -1; + if (scsisrc->protocol == VIR_DOMAIN_HOSTDEV_SCSI_PROTOCOL_TYPE_ISCSI) { virDomainHostdevSubsysSCSIiSCSIPtr iscsisrc = &scsisrc->u.iscsi; virReportError(VIR_ERR_INTERNAL_ERROR, @@ -2595,9 +2599,12 @@ qemuDomainAttachSCSIVHostDevice(virQEMUDriverPtr driver, if (qemuHostdevPrepareSCSIVHostDevices(driver, vm->def->name, &hostdev, 1) < 0) { virDomainHostdevSubsysSCSIVHostPtr hostsrc = &hostdev->source.subsys.u.scsi_host; - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unable to prepare scsi_host hostdev: %s"), - hostsrc->wwpn); + + if (!virGetLastError()) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Unable to prepare scsi_host hostdev: %s"), + hostsrc->wwpn); + } return -1; } -- 1.9.1

2 2

[libvirt] [PATCH] tests: update QEMU 2.9.0 caps data to final version
by Pavel Hrdina 26 Apr '17

26 Apr '17

Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- .../qemucapabilitiesdata/caps_2.9.0.x86_64.replies | 4329 ++++++++++---------- tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 5 +- 2 files changed, 2248 insertions(+), 2086 deletions(-) diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.replies b/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.replies index bae24750ca..ca206b3e86 100644 --- a/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.replies +++ b/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.replies @@ -2,11 +2,11 @@ "QMP": { "version": { "qemu": { - "micro": 90, - "minor": 8, + "micro": 0, + "minor": 9, "major": 2 }, - "package": " (v2.9.0-rc0-142-g940a8ce)" + "package": " (v2.9.0)" }, "capabilities": [ ] @@ -22,11 +22,11 @@ { "return": { "qemu": { - "micro": 90, - "minor": 8, + "micro": 0, + "minor": 9, "major": 2 }, - "package": " (v2.9.0-rc0-142-g940a8ce)" + "package": " (v2.9.0)" }, "id": "libvirt-2" } @@ -74,9 +74,6 @@ "name": "x-blockdev-insert-medium" }, { - "name": "x-blockdev-del" - }, - { "name": "x-blockdev-change" }, { @@ -416,6 +413,9 @@ "name": "blockdev-mirror" }, { + "name": "blockdev-del" + }, + { "name": "blockdev-close-tray" }, { @@ -6080,84 +6080,90 @@ "arg-type": "49" }, { - "name": "blockdev-mirror", + "name": "blockdev-del", "ret-type": "17", "meta-type": "command", "arg-type": "50" }, { - "name": "blockdev-open-tray", + "name": "blockdev-mirror", "ret-type": "17", "meta-type": "command", "arg-type": "51" }, { - "name": "blockdev-snapshot", + "name": "blockdev-open-tray", "ret-type": "17", "meta-type": "command", "arg-type": "52" }, { - "name": "blockdev-snapshot-delete-internal-sync", - "ret-type": "54", + "name": "blockdev-snapshot", + "ret-type": "17", "meta-type": "command", "arg-type": "53" }, { + "name": "blockdev-snapshot-delete-internal-sync", + "ret-type": "55", + "meta-type": "command", + "arg-type": "54" + }, + { "name": "blockdev-snapshot-internal-sync", "ret-type": "17", "meta-type": "command", - "arg-type": "55" - }, - { - "name": "blockdev-snapshot-sync", - "ret-type": "17", - "meta-type": "command", "arg-type": "56" }, { - "name": "change", + "name": "blockdev-snapshot-sync", "ret-type": "17", "meta-type": "command", "arg-type": "57" }, { - "name": "change-backing-file", + "name": "change", "ret-type": "17", "meta-type": "command", "arg-type": "58" }, { - "name": "change-vnc-password", + "name": "change-backing-file", "ret-type": "17", "meta-type": "command", "arg-type": "59" }, { - "name": "chardev-add", - "ret-type": "61", + "name": "change-vnc-password", + "ret-type": "17", "meta-type": "command", "arg-type": "60" }, { + "name": "chardev-add", + "ret-type": "62", + "meta-type": "command", + "arg-type": "61" + }, + { "name": "chardev-remove", "ret-type": "17", "meta-type": "command", - "arg-type": "62" - }, - { - "name": "client_migrate_info", - "ret-type": "17", - "meta-type": "command", "arg-type": "63" }, { - "name": "closefd", + "name": "client_migrate_info", "ret-type": "17", "meta-type": "command", "arg-type": "64" }, { + "name": "closefd", + "ret-type": "17", + "meta-type": "command", + "arg-type": "65" + }, + { "name": "cont", "ret-type": "17", "meta-type": "command", @@ -6167,81 +6173,81 @@ "name": "cpu", "ret-type": "17", "meta-type": "command", - "arg-type": "65" - }, - { - "name": "cpu-add", - "ret-type": "17", - "meta-type": "command", "arg-type": "66" }, { - "name": "device-list-properties", - "ret-type": "[68]", + "name": "cpu-add", + "ret-type": "17", "meta-type": "command", "arg-type": "67" }, { + "name": "device-list-properties", + "ret-type": "[69]", + "meta-type": "command", + "arg-type": "68" + }, + { "name": "device_add", "ret-type": "17", "meta-type": "command", - "arg-type": "69" - }, - { - "name": "device_del", - "ret-type": "17", - "meta-type": "command", "arg-type": "70" }, { - "name": "drive-backup", + "name": "device_del", "ret-type": "17", "meta-type": "command", "arg-type": "71" }, { - "name": "drive-mirror", + "name": "drive-backup", "ret-type": "17", "meta-type": "command", "arg-type": "72" }, { - "name": "dump-guest-memory", + "name": "drive-mirror", "ret-type": "17", "meta-type": "command", "arg-type": "73" }, { - "name": "dump-skeys", + "name": "dump-guest-memory", "ret-type": "17", "meta-type": "command", "arg-type": "74" }, { - "name": "eject", + "name": "dump-skeys", "ret-type": "17", "meta-type": "command", "arg-type": "75" }, { - "name": "expire_password", + "name": "eject", "ret-type": "17", "meta-type": "command", "arg-type": "76" }, { - "name": "getfd", + "name": "expire_password", "ret-type": "17", "meta-type": "command", "arg-type": "77" }, { - "name": "human-monitor-command", - "ret-type": "str", + "name": "getfd", + "ret-type": "17", "meta-type": "command", "arg-type": "78" }, { + "name": "human-monitor-command", + "ret-type": "str", + "meta-type": "command", + "arg-type": "79" + }, + { "name": "inject-nmi", "ret-type": "17", "meta-type": "command", @@ -6251,45 +6257,45 @@ "name": "input-send-event", "ret-type": "17", "meta-type": "command", - "arg-type": "79" - }, - { - "name": "memsave", - "ret-type": "17", - "meta-type": "command", "arg-type": "80" }, { - "name": "migrate", + "name": "memsave", "ret-type": "17", "meta-type": "command", "arg-type": "81" }, { - "name": "migrate-incoming", + "name": "migrate", "ret-type": "17", "meta-type": "command", "arg-type": "82" }, { - "name": "migrate-set-cache-size", + "name": "migrate-incoming", "ret-type": "17", "meta-type": "command", "arg-type": "83" }, { - "name": "migrate-set-capabilities", + "name": "migrate-set-cache-size", "ret-type": "17", "meta-type": "command", "arg-type": "84" }, { - "name": "migrate-set-parameters", + "name": "migrate-set-capabilities", "ret-type": "17", "meta-type": "command", "arg-type": "85" }, { + "name": "migrate-set-parameters", + "ret-type": "17", + "meta-type": "command", + "arg-type": "86" + }, + { "name": "migrate-start-postcopy", "ret-type": "17", "meta-type": "command", @@ -6305,27 +6311,27 @@ "name": "migrate_set_downtime", "ret-type": "17", "meta-type": "command", - "arg-type": "86" - }, - { - "name": "migrate_set_speed", - "ret-type": "17", - "meta-type": "command", "arg-type": "87" }, { - "name": "nbd-server-add", + "name": "migrate_set_speed", "ret-type": "17", "meta-type": "command", "arg-type": "88" }, { - "name": "nbd-server-start", + "name": "nbd-server-add", "ret-type": "17", "meta-type": "command", "arg-type": "89" }, { + "name": "nbd-server-start", + "ret-type": "17", + "meta-type": "command", + "arg-type": "90" + }, + { "name": "nbd-server-stop", "ret-type": "17", "meta-type": "command", @@ -6335,33 +6341,33 @@ "name": "netdev_add", "ret-type": "17", "meta-type": "command", - "arg-type": "90" - }, - { - "name": "netdev_del", - "ret-type": "17", - "meta-type": "command", "arg-type": "91" }, { - "name": "object-add", + "name": "netdev_del", "ret-type": "17", "meta-type": "command", "arg-type": "92" }, { - "name": "object-del", + "name": "object-add", "ret-type": "17", "meta-type": "command", "arg-type": "93" }, { - "name": "pmemsave", + "name": "object-del", "ret-type": "17", "meta-type": "command", "arg-type": "94" }, { + "name": "pmemsave", + "ret-type": "17", + "meta-type": "command", + "arg-type": "95" + }, + { "name": "qmp_capabilities", "ret-type": "17", "meta-type": "command", @@ -6371,185 +6377,185 @@ "name": "qom-get", "ret-type": "any", "meta-type": "command", - "arg-type": "95" - }, - { - "name": "qom-list", - "ret-type": "[97]", - "meta-type": "command", "arg-type": "96" }, { + "name": "qom-list", + "ret-type": "[98]", + "meta-type": "command", + "arg-type": "97" + }, + { "name": "qom-list-types", - "ret-type": "[99]", + "ret-type": "[100]", "meta-type": "command", - "arg-type": "98" + "arg-type": "99" }, { "name": "qom-set", "ret-type": "17", "meta-type": "command", - "arg-type": "100" + "arg-type": "101" }, { "name": "query-acpi-ospm-status", - "ret-type": "[101]", + "ret-type": "[102]", "meta-type": "command", "arg-type": "17" }, { "name": "query-balloon", - "ret-type": "102", + "ret-type": "103", "meta-type": "command", "arg-type": "17" }, { "name": "query-block", - "ret-type": "[103]", - "meta-type": "command", - "arg-type": "17" - }, - { - "name": "query-block-jobs", "ret-type": "[104]", "meta-type": "command", "arg-type": "17" }, { + "name": "query-block-jobs", + "ret-type": "[105]", + "meta-type": "command", + "arg-type": "17" + }, + { "name": "query-blockstats", - "ret-type": "[106]", - "meta-type": "command", - "arg-type": "105" - }, - { - "name": "query-chardev", "ret-type": "[107]", "meta-type": "command", - "arg-type": "17" + "arg-type": "106" }, { - "name": "query-chardev-backends", + "name": "query-chardev", "ret-type": "[108]", "meta-type": "command", "arg-type": "17" }, { + "name": "query-chardev-backends", + "ret-type": "[109]", + "meta-type": "command", + "arg-type": "17" + }, + { "name": "query-command-line-options", - "ret-type": "[110]", - "meta-type": "command", - "arg-type": "109" - }, - { - "name": "query-commands", "ret-type": "[111]", "meta-type": "command", - "arg-type": "17" + "arg-type": "110" }, { - "name": "query-cpu-definitions", + "name": "query-commands", "ret-type": "[112]", "meta-type": "command", "arg-type": "17" }, { + "name": "query-cpu-definitions", + "ret-type": "[113]", + "meta-type": "command", + "arg-type": "17" + }, + { "name": "query-cpu-model-baseline", - "ret-type": "114", + "ret-type": "115", "meta-type": "command", - "arg-type": "113" + "arg-type": "114" }, { "name": "query-cpu-model-comparison", - "ret-type": "116", + "ret-type": "117", "meta-type": "command", - "arg-type": "115" + "arg-type": "116" }, { "name": "query-cpu-model-expansion", - "ret-type": "118", + "ret-type": "119", "meta-type": "command", - "arg-type": "117" + "arg-type": "118" }, { "name": "query-cpus", - "ret-type": "[119]", + "ret-type": "[120]", "meta-type": "command", "arg-type": "17" }, { "name": "query-dump", - "ret-type": "120", - "meta-type": "command", - "arg-type": "17" - }, - { - "name": "query-dump-guest-memory-capability", "ret-type": "121", "meta-type": "command", "arg-type": "17" }, { + "name": "query-dump-guest-memory-capability", + "ret-type": "122", + "meta-type": "command", + "arg-type": "17" + }, + { "name": "query-events", - "ret-type": "[122]", - "meta-type": "command", - "arg-type": "17" - }, - { - "name": "query-fdsets", "ret-type": "[123]", "meta-type": "command", "arg-type": "17" }, { - "name": "query-gic-capabilities", + "name": "query-fdsets", "ret-type": "[124]", "meta-type": "command", "arg-type": "17" }, { - "name": "query-hotpluggable-cpus", + "name": "query-gic-capabilities", "ret-type": "[125]", "meta-type": "command", "arg-type": "17" }, { - "name": "query-iothreads", + "name": "query-hotpluggable-cpus", "ret-type": "[126]", "meta-type": "command", "arg-type": "17" }, { + "name": "query-iothreads", + "ret-type": "[127]", + "meta-type": "command", + "arg-type": "17" + }, + { "name": "query-kvm", - "ret-type": "127", + "ret-type": "128", "meta-type": "command", "arg-type": "17" }, { "name": "query-machines", - "ret-type": "[128]", - "meta-type": "command", - "arg-type": "17" - }, - { - "name": "query-memdev", "ret-type": "[129]", "meta-type": "command", "arg-type": "17" }, { - "name": "query-memory-devices", + "name": "query-memdev", "ret-type": "[130]", "meta-type": "command", "arg-type": "17" }, { - "name": "query-mice", + "name": "query-memory-devices", "ret-type": "[131]", "meta-type": "command", "arg-type": "17" }, { + "name": "query-mice", + "ret-type": "[132]", + "meta-type": "command", + "arg-type": "17" + }, + { "name": "query-migrate", - "ret-type": "132", + "ret-type": "133", "meta-type": "command", "arg-type": "17" }, @@ -6561,139 +6567,139 @@ }, { "name": "query-migrate-capabilities", - "ret-type": "[133]", + "ret-type": "[134]", "meta-type": "command", "arg-type": "17" }, { "name": "query-migrate-parameters", - "ret-type": "85", + "ret-type": "86", "meta-type": "command", "arg-type": "17" }, { "name": "query-name", - "ret-type": "134", + "ret-type": "135", "meta-type": "command", "arg-type": "17" }, { "name": "query-named-block-nodes", - "ret-type": "[135]", - "meta-type": "command", - "arg-type": "17" - }, - { - "name": "query-pci", "ret-type": "[136]", "meta-type": "command", "arg-type": "17" }, { - "name": "query-qmp-schema", + "name": "query-pci", "ret-type": "[137]", "meta-type": "command", "arg-type": "17" }, { + "name": "query-qmp-schema", + "ret-type": "[138]", + "meta-type": "command", + "arg-type": "17" + }, + { "name": "query-rocker", - "ret-type": "139", + "ret-type": "140", "meta-type": "command", - "arg-type": "138" + "arg-type": "139" }, { "name": "query-rocker-of-dpa-flows", - "ret-type": "[141]", + "ret-type": "[142]", "meta-type": "command", - "arg-type": "140" + "arg-type": "141" }, { "name": "query-rocker-of-dpa-groups", - "ret-type": "[143]", + "ret-type": "[144]", "meta-type": "command", - "arg-type": "142" + "arg-type": "143" }, { "name": "query-rocker-ports", - "ret-type": "[145]", + "ret-type": "[146]", "meta-type": "command", - "arg-type": "144" + "arg-type": "145" }, { "name": "query-rx-filter", - "ret-type": "[147]", + "ret-type": "[148]", "meta-type": "command", - "arg-type": "146" + "arg-type": "147" }, { "name": "query-spice", - "ret-type": "148", - "meta-type": "command", - "arg-type": "17" - }, - { - "name": "query-status", "ret-type": "149", "meta-type": "command", "arg-type": "17" }, { - "name": "query-target", + "name": "query-status", "ret-type": "150", "meta-type": "command", "arg-type": "17" }, { + "name": "query-target", + "ret-type": "151", + "meta-type": "command", + "arg-type": "17" + }, + { "name": "query-tpm", - "ret-type": "[151]", - "meta-type": "command", - "arg-type": "17" - }, - { - "name": "query-tpm-models", "ret-type": "[152]", "meta-type": "command", "arg-type": "17" }, { - "name": "query-tpm-types", + "name": "query-tpm-models", "ret-type": "[153]", "meta-type": "command", "arg-type": "17" }, { + "name": "query-tpm-types", + "ret-type": "[154]", + "meta-type": "command", + "arg-type": "17" + }, + { "name": "query-uuid", - "ret-type": "154", - "meta-type": "command", - "arg-type": "17" - }, - { - "name": "query-version", "ret-type": "155", "meta-type": "command", "arg-type": "17" }, { - "name": "query-vm-generation-id", + "name": "query-version", "ret-type": "156", "meta-type": "command", "arg-type": "17" }, { - "name": "query-vnc", + "name": "query-vm-generation-id", "ret-type": "157", "meta-type": "command", "arg-type": "17" }, { + "name": "query-vnc", + "ret-type": "158", + "meta-type": "command", + "arg-type": "17" + }, + { "name": "query-vnc-servers", - "ret-type": "[158]", + "ret-type": "[159]", "meta-type": "command", "arg-type": "17" }, { "name": "query-xen-replication-status", - "ret-type": "159", + "ret-type": "160", "meta-type": "command", "arg-type": "17" }, @@ -6707,21 +6713,21 @@ "name": "remove-fd", "ret-type": "17", "meta-type": "command", - "arg-type": "160" - }, - { - "name": "ringbuf-read", - "ret-type": "str", - "meta-type": "command", "arg-type": "161" }, { - "name": "ringbuf-write", - "ret-type": "17", + "name": "ringbuf-read", + "ret-type": "str", "meta-type": "command", "arg-type": "162" }, { + "name": "ringbuf-write", + "ret-type": "17", + "meta-type": "command", + "arg-type": "163" + }, + { "name": "rtc-reset-reinjection", "ret-type": "17", "meta-type": "command", @@ -6731,27 +6737,27 @@ "name": "screendump", "ret-type": "17", "meta-type": "command", - "arg-type": "163" - }, - { - "name": "send-key", - "ret-type": "17", - "meta-type": "command", "arg-type": "164" }, { - "name": "set_link", + "name": "send-key", "ret-type": "17", "meta-type": "command", "arg-type": "165" }, { - "name": "set_password", + "name": "set_link", "ret-type": "17", "meta-type": "command", "arg-type": "166" }, { + "name": "set_password", + "ret-type": "17", + "meta-type": "command", + "arg-type": "167" + }, + { "name": "stop", "ret-type": "17", "meta-type": "command", @@ -6777,30 +6783,24 @@ }, { "name": "trace-event-get-state", - "ret-type": "[168]", + "ret-type": "[169]", "meta-type": "command", - "arg-type": "167" + "arg-type": "168" }, { "name": "trace-event-set-state", "ret-type": "17", "meta-type": "command", - "arg-type": "169" - }, - { - "name": "transaction", - "ret-type": "17", - "meta-type": "command", "arg-type": "170" }, { - "name": "x-blockdev-change", + "name": "transaction", "ret-type": "17", "meta-type": "command", "arg-type": "171" }, { - "name": "x-blockdev-del", + "name": "x-blockdev-change", "ret-type": "17", "meta-type": "command", "arg-type": "172" @@ -6858,7 +6858,7 @@ "members": [ { "name": "info", - "type": "101" + "type": "102" } ], "meta-type": "object" @@ -7094,7 +7094,7 @@ "members": [ { "name": "result", - "type": "120" + "type": "121" }, { "name": "error", @@ -7771,13 +7771,13 @@ }, { "case": "ftps", - "type": "202" - }, - { - "case": "gluster", "type": "203" }, { + "case": "gluster", + "type": "204" + }, + { "case": "host_cdrom", "type": "201" }, @@ -7787,35 +7787,35 @@ }, { "case": "http", - "type": "202" + "type": "205" }, { "case": "https", - "type": "202" + "type": "206" }, { "case": "iscsi", - "type": "204" + "type": "207" }, { "case": "luks", - "type": "205" + "type": "208" }, { "case": "nbd", - "type": "206" + "type": "209" }, { "case": "nfs", - "type": "207" + "type": "210" }, { "case": "null-aio", - "type": "208" + "type": "211" }, { "case": "null-co", - "type": "208" + "type": "211" }, { "case": "parallels", @@ -7823,39 +7823,39 @@ }, { "case": "qcow2", - "type": "209" + "type": "212" }, { "case": "qcow", - "type": "210" + "type": "213" }, { "case": "qed", - "type": "210" + "type": "213" }, { "case": "quorum", - "type": "211" + "type": "214" }, { "case": "raw", - "type": "212" + "type": "215" }, { "case": "rbd", - "type": "213" + "type": "216" }, { "case": "replication", - "type": "214" + "type": "217" }, { "case": "sheepdog", - "type": "215" + "type": "218" }, { "case": "ssh", - "type": "216" + "type": "219" }, { "case": "vdi", @@ -7867,7 +7867,7 @@ }, { "case": "vmdk", - "type": "210" + "type": "213" }, { "case": "vpc", @@ -7875,7 +7875,7 @@ }, { "case": "vvfat", - "type": "217" + "type": "220" } ], "members": [ @@ -7929,7 +7929,7 @@ }, { "name": "sync", - "type": "218" + "type": "221" }, { "name": "speed", @@ -7979,7 +7979,7 @@ { "name": "read-only-mode", "default": null, - "type": "219" + "type": "222" } ], "meta-type": "object" @@ -8004,55 +8004,7 @@ "name": "50", "members": [ { - "name": "job-id", - "default": null, - "type": "str" - }, - { - "name": "device", - "type": "str" - }, - { - "name": "target", - "type": "str" - }, - { - "name": "replaces", - "default": null, - "type": "str" - }, - { - "name": "sync", - "type": "218" - }, - { - "name": "speed", - "default": null, - "type": "int" - }, - { - "name": "granularity", - "default": null, - "type": "int" - }, - { - "name": "buf-size", - "default": null, - "type": "int" - }, - { - "name": "on-source-error", - "default": null, - "type": "193" - }, - { - "name": "on-target-error", - "default": null, - "type": "193" - }, - { - "name": "filter-node-name", - "default": null, + "name": "node-name", "type": "str" } ], @@ -8062,19 +8014,56 @@ "name": "51", "members": [ { + "name": "job-id", + "default": null, + "type": "str" + }, + { "name": "device", - "default": null, "type": "str" }, { - "name": "id", + "name": "target", + "type": "str" + }, + { + "name": "replaces", "default": null, "type": "str" }, { - "name": "force", + "name": "sync", + "type": "221" + }, + { + "name": "speed", + "default": null, + "type": "int" + }, + { + "name": "granularity", + "default": null, + "type": "int" + }, + { + "name": "buf-size", + "default": null, + "type": "int" + }, + { + "name": "on-source-error", "default": null, - "type": "bool" + "type": "193" + }, + { + "name": "on-target-error", + "default": null, + "type": "193" + }, + { + "name": "filter-node-name", + "default": null, + "type": "str" } ], "meta-type": "object" @@ -8083,12 +8072,19 @@ "name": "52", "members": [ { - "name": "node", + "name": "device", + "default": null, "type": "str" }, { - "name": "overlay", + "name": "id", + "default": null, "type": "str" + }, + { + "name": "force", + "default": null, + "type": "bool" } ], "meta-type": "object" @@ -8097,17 +8093,11 @@ "name": "53", "members": [ { - "name": "device", + "name": "node", "type": "str" }, { - "name": "id", - "default": null, - "type": "str" - }, - { - "name": "name", - "default": null, + "name": "overlay", "type": "str" } ], @@ -8117,6 +8107,26 @@ "name": "54", "members": [ { + "name": "device", + "type": "str" + }, + { + "name": "id", + "default": null, + "type": "str" + }, + { + "name": "name", + "default": null, + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "55", + "members": [ + { "name": "id", "type": "str" }, @@ -8148,24 +8158,24 @@ "meta-type": "object" }, { - "name": "55", - "members": [ - { - "name": "device", - "type": "str" - }, - { - "name": "name", - "type": "str" - } - ], - "meta-type": "object" - }, - { "name": "56", "members": [ { "name": "device", + "type": "str" + }, + { + "name": "name", + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "57", + "members": [ + { + "name": "device", "default": null, "type": "str" }, @@ -8191,26 +8201,7 @@ { "name": "mode", "default": null, - "type": "220" - } - ], - "meta-type": "object" - }, - { - "name": "57", - "members": [ - { - "name": "device", - "type": "str" - }, - { - "name": "target", - "type": "str" - }, - { - "name": "arg", - "default": null, - "type": "str" + "type": "223" } ], "meta-type": "object" @@ -8223,11 +8214,12 @@ "type": "str" }, { - "name": "image-node-name", + "name": "target", "type": "str" }, { - "name": "backing-file", + "name": "arg", + "default": null, "type": "str" } ], @@ -8237,7 +8229,15 @@ "name": "59", "members": [ { - "name": "password", + "name": "device", + "type": "str" + }, + { + "name": "image-node-name", + "type": "str" + }, + { + "name": "backing-file", "type": "str" } ], @@ -8247,12 +8247,8 @@ "name": "60", "members": [ { - "name": "id", + "name": "password", "type": "str" - }, - { - "name": "backend", - "type": "221" } ], "meta-type": "object" @@ -8261,9 +8257,12 @@ "name": "61", "members": [ { - "name": "pty", - "default": null, + "name": "id", "type": "str" + }, + { + "name": "backend", + "type": "224" } ], "meta-type": "object" @@ -8272,7 +8271,8 @@ "name": "62", "members": [ { - "name": "id", + "name": "pty", + "default": null, "type": "str" } ], @@ -8282,6 +8282,16 @@ "name": "63", "members": [ { + "name": "id", + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "64", + "members": [ + { "name": "protocol", "type": "str" }, @@ -8308,21 +8318,11 @@ "meta-type": "object" }, { - "name": "64", - "members": [ - { - "name": "fdname", - "type": "str" - } - ], - "meta-type": "object" - }, - { "name": "65", "members": [ { - "name": "index", - "type": "int" + "name": "fdname", + "type": "str" } ], "meta-type": "object" @@ -8331,7 +8331,7 @@ "name": "66", "members": [ { - "name": "id", + "name": "index", "type": "int" } ], @@ -8341,50 +8341,40 @@ "name": "67", "members": [ { - "name": "typename", - "type": "str" + "name": "id", + "type": "int" } ], "meta-type": "object" }, { - "name": "[68]", - "element-type": "68", - "meta-type": "array" - }, - { "name": "68", "members": [ { - "name": "name", - "type": "str" - }, - { - "name": "type", - "type": "str" - }, - { - "name": "description", - "default": null, + "name": "typename", "type": "str" } ], "meta-type": "object" }, { + "name": "[69]", + "element-type": "69", + "meta-type": "array" + }, + { "name": "69", "members": [ { - "name": "driver", + "name": "name", "type": "str" }, { - "name": "bus", - "default": null, + "name": "type", "type": "str" }, { - "name": "id", + "name": "description", "default": null, "type": "str" } @@ -8395,7 +8385,17 @@ "name": "70", "members": [ { + "name": "driver", + "type": "str" + }, + { + "name": "bus", + "default": null, + "type": "str" + }, + { "name": "id", + "default": null, "type": "str" } ], @@ -8405,56 +8405,8 @@ "name": "71", "members": [ { - "name": "job-id", - "default": null, + "name": "id", "type": "str" - }, - { - "name": "device", - "type": "str" - }, - { - "name": "target", - "type": "str" - }, - { - "name": "format", - "default": null, - "type": "str" - }, - { - "name": "sync", - "type": "218" - }, - { - "name": "mode", - "default": null, - "type": "220" - }, - { - "name": "speed", - "default": null, - "type": "int" - }, - { - "name": "bitmap", - "default": null, - "type": "str" - }, - { - "name": "compress", - "default": null, - "type": "bool" - }, - { - "name": "on-source-error", - "default": null, - "type": "193" - }, - { - "name": "on-target-error", - "default": null, - "type": "193" } ], "meta-type": "object" @@ -8481,23 +8433,13 @@ "type": "str" }, { - "name": "node-name", - "default": null, - "type": "str" - }, - { - "name": "replaces", - "default": null, - "type": "str" - }, - { "name": "sync", - "type": "218" + "type": "221" }, { "name": "mode", "default": null, - "type": "220" + "type": "223" }, { "name": "speed", @@ -8505,14 +8447,14 @@ "type": "int" }, { - "name": "granularity", + "name": "bitmap", "default": null, - "type": "int" + "type": "str" }, { - "name": "buf-size", + "name": "compress", "default": null, - "type": "int" + "type": "bool" }, { "name": "on-source-error", @@ -8523,11 +8465,6 @@ "name": "on-target-error", "default": null, "type": "193" - }, - { - "name": "unmap", - "default": null, - "type": "bool" } ], "meta-type": "object" @@ -8536,6 +8473,79 @@ "name": "73", "members": [ { + "name": "job-id", + "default": null, + "type": "str" + }, + { + "name": "device", + "type": "str" + }, + { + "name": "target", + "type": "str" + }, + { + "name": "format", + "default": null, + "type": "str" + }, + { + "name": "node-name", + "default": null, + "type": "str" + }, + { + "name": "replaces", + "default": null, + "type": "str" + }, + { + "name": "sync", + "type": "221" + }, + { + "name": "mode", + "default": null, + "type": "223" + }, + { + "name": "speed", + "default": null, + "type": "int" + }, + { + "name": "granularity", + "default": null, + "type": "int" + }, + { + "name": "buf-size", + "default": null, + "type": "int" + }, + { + "name": "on-source-error", + "default": null, + "type": "193" + }, + { + "name": "on-target-error", + "default": null, + "type": "193" + }, + { + "name": "unmap", + "default": null, + "type": "bool" + } + ], + "meta-type": "object" + }, + { + "name": "74", + "members": [ + { "name": "paging", "type": "bool" }, @@ -8561,17 +8571,7 @@ { "name": "format", "default": null, - "type": "222" - } - ], - "meta-type": "object" - }, - { - "name": "74", - "members": [ - { - "name": "filename", - "type": "str" + "type": "225" } ], "meta-type": "object" @@ -8580,19 +8580,8 @@ "name": "75", "members": [ { - "name": "device", - "default": null, + "name": "filename", "type": "str" - }, - { - "name": "id", - "default": null, - "type": "str" - }, - { - "name": "force", - "default": null, - "type": "bool" } ], "meta-type": "object" @@ -8601,12 +8590,19 @@ "name": "76", "members": [ { - "name": "protocol", + "name": "device", + "default": null, "type": "str" }, { - "name": "time", + "name": "id", + "default": null, "type": "str" + }, + { + "name": "force", + "default": null, + "type": "bool" } ], "meta-type": "object" @@ -8615,7 +8611,11 @@ "name": "77", "members": [ { - "name": "fdname", + "name": "protocol", + "type": "str" + }, + { + "name": "time", "type": "str" } ], @@ -8625,6 +8625,16 @@ "name": "78", "members": [ { + "name": "fdname", + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "79", + "members": [ + { "name": "command-line", "type": "str" }, @@ -8642,44 +8652,21 @@ "meta-type": "builtin" }, { - "name": "79", - "members": [ - { - "name": "device", - "default": null, - "type": "str" - }, - { - "name": "head", - "default": null, - "type": "int" - }, - { - "name": "events", - "type": "[223]" - } - ], - "meta-type": "object" - }, - { "name": "80", "members": [ { - "name": "val", - "type": "int" - }, - { - "name": "size", - "type": "int" - }, - { - "name": "filename", + "name": "device", + "default": null, "type": "str" }, { - "name": "cpu-index", + "name": "head", "default": null, "type": "int" + }, + { + "name": "events", + "type": "[226]" } ], "meta-type": "object" @@ -8688,6 +8675,29 @@ "name": "81", "members": [ { + "name": "val", + "type": "int" + }, + { + "name": "size", + "type": "int" + }, + { + "name": "filename", + "type": "str" + }, + { + "name": "cpu-index", + "default": null, + "type": "int" + } + ], + "meta-type": "object" + }, + { + "name": "82", + "members": [ + { "name": "uri", "type": "str" }, @@ -8710,21 +8720,11 @@ "meta-type": "object" }, { - "name": "82", - "members": [ - { - "name": "uri", - "type": "str" - } - ], - "meta-type": "object" - }, - { "name": "83", "members": [ { - "name": "value", - "type": "int" + "name": "uri", + "type": "str" } ], "meta-type": "object" @@ -8733,8 +8733,8 @@ "name": "84", "members": [ { - "name": "capabilities", - "type": "[133]" + "name": "value", + "type": "int" } ], "meta-type": "object" @@ -8743,6 +8743,16 @@ "name": "85", "members": [ { + "name": "capabilities", + "type": "[134]" + } + ], + "meta-type": "object" + }, + { + "name": "86", + "members": [ + { "name": "compress-level", "default": null, "type": "int" @@ -8796,21 +8806,11 @@ "meta-type": "object" }, { - "name": "86", - "members": [ - { - "name": "value", - "type": "number" - } - ], - "meta-type": "object" - }, - { "name": "87", "members": [ { "name": "value", - "type": "int" + "type": "number" } ], "meta-type": "object" @@ -8819,13 +8819,8 @@ "name": "88", "members": [ { - "name": "device", - "type": "str" - }, - { - "name": "writable", - "default": null, - "type": "bool" + "name": "value", + "type": "int" } ], "meta-type": "object" @@ -8834,13 +8829,13 @@ "name": "89", "members": [ { - "name": "addr", - "type": "224" + "name": "device", + "type": "str" }, { - "name": "tls-creds", + "name": "writable", "default": null, - "type": "str" + "type": "bool" } ], "meta-type": "object" @@ -8849,11 +8844,12 @@ "name": "90", "members": [ { - "name": "type", - "type": "str" + "name": "addr", + "type": "227" }, { - "name": "id", + "name": "tls-creds", + "default": null, "type": "str" } ], @@ -8863,6 +8859,10 @@ "name": "91", "members": [ { + "name": "type", + "type": "str" + }, + { "name": "id", "type": "str" } @@ -8873,17 +8873,8 @@ "name": "92", "members": [ { - "name": "qom-type", - "type": "str" - }, - { "name": "id", "type": "str" - }, - { - "name": "props", - "default": null, - "type": "any" } ], "meta-type": "object" @@ -8892,8 +8883,17 @@ "name": "93", "members": [ { + "name": "qom-type", + "type": "str" + }, + { "name": "id", "type": "str" + }, + { + "name": "props", + "default": null, + "type": "any" } ], "meta-type": "object" @@ -8902,15 +8902,7 @@ "name": "94", "members": [ { - "name": "val", - "type": "int" - }, - { - "name": "size", - "type": "int" - }, - { - "name": "filename", + "name": "id", "type": "str" } ], @@ -8920,6 +8912,24 @@ "name": "95", "members": [ { + "name": "val", + "type": "int" + }, + { + "name": "size", + "type": "int" + }, + { + "name": "filename", + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "96", + "members": [ + { "name": "path", "type": "str" }, @@ -8936,38 +8946,38 @@ "meta-type": "builtin" }, { - "name": "96", - "members": [ - { - "name": "path", - "type": "str" - } - ], - "meta-type": "object" - }, - { - "name": "[97]", - "element-type": "97", - "meta-type": "array" - }, - { "name": "97", "members": [ { - "name": "name", - "type": "str" - }, - { - "name": "type", + "name": "path", "type": "str" } ], "meta-type": "object" }, { + "name": "[98]", + "element-type": "98", + "meta-type": "array" + }, + { "name": "98", "members": [ { + "name": "name", + "type": "str" + }, + { + "name": "type", + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "99", + "members": [ + { "name": "implements", "default": null, "type": "str" @@ -8981,47 +8991,47 @@ "meta-type": "object" }, { - "name": "[99]", - "element-type": "99", + "name": "[100]", + "element-type": "100", "meta-type": "array" }, { - "name": "99", - "members": [ - { - "name": "name", - "type": "str" - } - ], - "meta-type": "object" - }, - { "name": "100", "members": [ { - "name": "path", + "name": "name", "type": "str" - }, - { - "name": "property", - "type": "str" - }, - { - "name": "value", - "type": "any" } ], "meta-type": "object" }, { - "name": "[101]", - "element-type": "101", - "meta-type": "array" - }, - { "name": "101", "members": [ { + "name": "path", + "type": "str" + }, + { + "name": "property", + "type": "str" + }, + { + "name": "value", + "type": "any" + } + ], + "meta-type": "object" + }, + { + "name": "[102]", + "element-type": "102", + "meta-type": "array" + }, + { + "name": "102", + "members": [ + { "name": "device", "default": null, "type": "str" @@ -9032,7 +9042,7 @@ }, { "name": "slot-type", - "type": "225" + "type": "228" }, { "name": "source", @@ -9046,24 +9056,24 @@ "meta-type": "object" }, { - "name": "102", - "members": [ - { - "name": "actual", - "type": "int" - } - ], - "meta-type": "object" - }, - { - "name": "[103]", - "element-type": "103", - "meta-type": "array" - }, - { "name": "103", "members": [ { + "name": "actual", + "type": "int" + } + ], + "meta-type": "object" + }, + { + "name": "[104]", + "element-type": "104", + "meta-type": "array" + }, + { + "name": "104", + "members": [ + { "name": "device", "type": "str" }, @@ -9082,7 +9092,7 @@ { "name": "inserted", "default": null, - "type": "135" + "type": "136" }, { "name": "tray_open", @@ -9092,23 +9102,23 @@ { "name": "io-status", "default": null, - "type": "226" + "type": "229" }, { "name": "dirty-bitmaps", "default": null, - "type": "[227]" + "type": "[230]" } ], "meta-type": "object" }, { - "name": "[104]", - "element-type": "104", + "name": "[105]", + "element-type": "105", "meta-type": "array" }, { - "name": "104", + "name": "105", "members": [ { "name": "type", @@ -9140,7 +9150,7 @@ }, { "name": "io-status", - "type": "226" + "type": "229" }, { "name": "ready", @@ -9150,47 +9160,12 @@ "meta-type": "object" }, { - "name": "105", - "members": [ - { - "name": "query-nodes", - "default": null, - "type": "bool" - } - ], - "meta-type": "object" - }, - { - "name": "[106]", - "element-type": "106", - "meta-type": "array" - }, - { "name": "106", "members": [ { - "name": "device", + "name": "query-nodes", "default": null, - "type": "str" - }, - { - "name": "node-name", - "default": null, - "type": "str" - }, - { - "name": "stats", - "type": "228" - }, - { - "name": "parent", - "default": null, - "type": "106" - }, - { - "name": "backing", - "default": null, - "type": "106" + "type": "bool" } ], "meta-type": "object" @@ -9204,16 +9179,28 @@ "name": "107", "members": [ { - "name": "label", + "name": "device", + "default": null, "type": "str" }, { - "name": "filename", + "name": "node-name", + "default": null, "type": "str" }, { - "name": "frontend-open", - "type": "bool" + "name": "stats", + "type": "231" + }, + { + "name": "parent", + "default": null, + "type": "107" + }, + { + "name": "backing", + "default": null, + "type": "107" } ], "meta-type": "object" @@ -9227,38 +9214,42 @@ "name": "108", "members": [ { - "name": "name", + "name": "label", "type": "str" + }, + { + "name": "filename", + "type": "str" + }, + { + "name": "frontend-open", + "type": "bool" } ], "meta-type": "object" }, { + "name": "[109]", + "element-type": "109", + "meta-type": "array" + }, + { "name": "109", "members": [ { - "name": "option", - "default": null, + "name": "name", "type": "str" } ], "meta-type": "object" }, { - "name": "[110]", - "element-type": "110", - "meta-type": "array" - }, - { "name": "110", "members": [ { "name": "option", + "default": null, "type": "str" - }, - { - "name": "parameters", - "type": "[229]" } ], "meta-type": "object" @@ -9272,8 +9263,12 @@ "name": "111", "members": [ { - "name": "name", + "name": "option", "type": "str" + }, + { + "name": "parameters", + "type": "[232]" } ], "meta-type": "object" @@ -9289,6 +9284,21 @@ { "name": "name", "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "[113]", + "element-type": "113", + "meta-type": "array" + }, + { + "name": "113", + "members": [ + { + "name": "name", + "type": "str" }, { "name": "migration-safe", @@ -9312,25 +9322,15 @@ "meta-type": "object" }, { - "name": "113", - "members": [ - { - "name": "modela", - "type": "230" - }, - { - "name": "modelb", - "type": "230" - } - ], - "meta-type": "object" - }, - { "name": "114", "members": [ { - "name": "model", - "type": "230" + "name": "modela", + "type": "233" + }, + { + "name": "modelb", + "type": "233" } ], "meta-type": "object" @@ -9339,12 +9339,8 @@ "name": "115", "members": [ { - "name": "modela", - "type": "230" - }, - { - "name": "modelb", - "type": "230" + "name": "model", + "type": "233" } ], "meta-type": "object" @@ -9353,12 +9349,12 @@ "name": "116", "members": [ { - "name": "result", - "type": "231" + "name": "modela", + "type": "233" }, { - "name": "responsible-properties", - "type": "[str]" + "name": "modelb", + "type": "233" } ], "meta-type": "object" @@ -9367,12 +9363,12 @@ "name": "117", "members": [ { - "name": "type", - "type": "232" + "name": "result", + "type": "234" }, { - "name": "model", - "type": "230" + "name": "responsible-properties", + "type": "[str]" } ], "meta-type": "object" @@ -9381,44 +9377,58 @@ "name": "118", "members": [ { + "name": "type", + "type": "235" + }, + { "name": "model", - "type": "230" + "type": "233" } ], "meta-type": "object" }, { - "name": "[119]", - "element-type": "119", - "meta-type": "array" - }, - { "name": "119", + "members": [ + { + "name": "model", + "type": "233" + } + ], + "meta-type": "object" + }, + { + "name": "[120]", + "element-type": "120", + "meta-type": "array" + }, + { + "name": "120", "tag": "arch", "variants": [ { "case": "x86", - "type": "234" + "type": "237" }, { "case": "sparc", - "type": "235" + "type": "238" }, { "case": "ppc", - "type": "236" + "type": "239" }, { "case": "mips", - "type": "237" + "type": "240" }, { "case": "tricore", - "type": "238" + "type": "241" }, { "case": "other", - "type": "239" + "type": "242" } ], "members": [ @@ -9444,25 +9454,7 @@ }, { "name": "arch", - "type": "233" - } - ], - "meta-type": "object" - }, - { - "name": "120", - "members": [ - { - "name": "status", - "type": "240" - }, - { - "name": "completed", - "type": "int" - }, - { - "name": "total", - "type": "int" + "type": "236" } ], "meta-type": "object" @@ -9471,23 +9463,26 @@ "name": "121", "members": [ { - "name": "formats", - "type": "[222]" + "name": "status", + "type": "243" + }, + { + "name": "completed", + "type": "int" + }, + { + "name": "total", + "type": "int" } ], "meta-type": "object" }, { - "name": "[122]", - "element-type": "122", - "meta-type": "array" - }, - { "name": "122", "members": [ { - "name": "name", - "type": "str" + "name": "formats", + "type": "[225]" } ], "meta-type": "object" @@ -9501,12 +9496,8 @@ "name": "123", "members": [ { - "name": "fdset-id", - "type": "int" - }, - { - "name": "fds", - "type": "[241]" + "name": "name", + "type": "str" } ], "meta-type": "object" @@ -9520,16 +9511,12 @@ "name": "124", "members": [ { - "name": "version", + "name": "fdset-id", "type": "int" }, { - "name": "emulated", - "type": "bool" - }, - { - "name": "kernel", - "type": "bool" + "name": "fds", + "type": "[244]" } ], "meta-type": "object" @@ -9543,21 +9530,16 @@ "name": "125", "members": [ { - "name": "type", - "type": "str" - }, - { - "name": "vcpus-count", + "name": "version", "type": "int" }, { - "name": "props", - "type": "242" + "name": "emulated", + "type": "bool" }, { - "name": "qom-path", - "default": null, - "type": "str" + "name": "kernel", + "type": "bool" } ], "meta-type": "object" @@ -9571,6 +9553,34 @@ "name": "126", "members": [ { + "name": "type", + "type": "str" + }, + { + "name": "vcpus-count", + "type": "int" + }, + { + "name": "props", + "type": "245" + }, + { + "name": "qom-path", + "default": null, + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "[127]", + "element-type": "127", + "meta-type": "array" + }, + { + "name": "127", + "members": [ + { "name": "id", "type": "str" }, @@ -9594,28 +9604,28 @@ "meta-type": "object" }, { - "name": "127", - "members": [ - { - "name": "enabled", - "type": "bool" - }, - { - "name": "present", - "type": "bool" - } - ], - "meta-type": "object" - }, - { - "name": "[128]", - "element-type": "128", - "meta-type": "array" - }, - { "name": "128", "members": [ { + "name": "enabled", + "type": "bool" + }, + { + "name": "present", + "type": "bool" + } + ], + "meta-type": "object" + }, + { + "name": "[129]", + "element-type": "129", + "meta-type": "array" + }, + { + "name": "129", + "members": [ + { "name": "name", "type": "str" }, @@ -9641,12 +9651,12 @@ "meta-type": "object" }, { - "name": "[129]", - "element-type": "129", + "name": "[130]", + "element-type": "130", "meta-type": "array" }, { - "name": "129", + "name": "130", "members": [ { "name": "id", @@ -9675,29 +9685,7 @@ }, { "name": "policy", - "type": "243" - } - ], - "meta-type": "object" - }, - { - "name": "[130]", - "element-type": "130", - "meta-type": "array" - }, - { - "name": "130", - "tag": "type", - "variants": [ - { - "case": "dimm", - "type": "245" - } - ], - "members": [ - { - "name": "type", - "type": "244" + "type": "246" } ], "meta-type": "object" @@ -9709,30 +9697,52 @@ }, { "name": "131", + "tag": "type", + "variants": [ + { + "case": "dimm", + "type": "248" + } + ], "members": [ { - "name": "name", - "type": "str" - }, - { - "name": "index", - "type": "int" - }, - { - "name": "current", - "type": "bool" - }, - { - "name": "absolute", - "type": "bool" + "name": "type", + "type": "247" } ], "meta-type": "object" }, { + "name": "[132]", + "element-type": "132", + "meta-type": "array" + }, + { "name": "132", "members": [ { + "name": "name", + "type": "str" + }, + { + "name": "index", + "type": "int" + }, + { + "name": "current", + "type": "bool" + }, + { + "name": "absolute", + "type": "bool" + } + ], + "meta-type": "object" + }, + { + "name": "133", + "members": [ + { "name": "status", "default": null, "type": "184" @@ -9740,17 +9750,17 @@ { "name": "ram", "default": null, - "type": "246" + "type": "249" }, { "name": "disk", "default": null, - "type": "246" + "type": "249" }, { "name": "xbzrle-cache", "default": null, - "type": "247" + "type": "250" }, { "name": "total-time", @@ -9791,44 +9801,44 @@ "meta-type": "builtin" }, { - "name": "[133]", - "element-type": "133", + "name": "[134]", + "element-type": "134", "meta-type": "array" }, { - "name": "133", - "members": [ - { - "name": "capability", - "type": "248" - }, - { - "name": "state", - "type": "bool" - } - ], - "meta-type": "object" - }, - { "name": "134", "members": [ { - "name": "name", - "default": null, - "type": "str" + "name": "capability", + "type": "251" + }, + { + "name": "state", + "type": "bool" } ], "meta-type": "object" }, { - "name": "[135]", - "element-type": "135", - "meta-type": "array" - }, - { "name": "135", "members": [ { + "name": "name", + "default": null, + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "[136]", + "element-type": "136", + "meta-type": "array" + }, + { + "name": "136", + "members": [ + { "name": "file", "type": "str" }, @@ -9892,7 +9902,7 @@ }, { "name": "image", - "type": "249" + "type": "252" }, { "name": "bps_max", @@ -9966,7 +9976,7 @@ }, { "name": "cache", - "type": "250" + "type": "253" }, { "name": "write_threshold", @@ -9976,60 +9986,60 @@ "meta-type": "object" }, { - "name": "[136]", - "element-type": "136", - "meta-type": "array" - }, - { - "name": "136", - "members": [ - { - "name": "bus", - "type": "int" - }, - { - "name": "devices", - "type": "[251]" - } - ], - "meta-type": "object" - }, - { "name": "[137]", "element-type": "137", "meta-type": "array" }, { "name": "137", + "members": [ + { + "name": "bus", + "type": "int" + }, + { + "name": "devices", + "type": "[254]" + } + ], + "meta-type": "object" + }, + { + "name": "[138]", + "element-type": "138", + "meta-type": "array" + }, + { + "name": "138", "tag": "meta-type", "variants": [ { "case": "builtin", - "type": "253" + "type": "256" }, { "case": "enum", - "type": "254" + "type": "257" }, { "case": "array", - "type": "255" + "type": "258" }, { "case": "object", - "type": "256" + "type": "259" }, { "case": "alternate", - "type": "257" + "type": "260" }, { "case": "command", - "type": "258" + "type": "261" }, { "case": "event", - "type": "259" + "type": "262" } ], "members": [ @@ -10039,17 +10049,7 @@ }, { "name": "meta-type", - "type": "252" - } - ], - "meta-type": "object" - }, - { - "name": "138", - "members": [ - { - "name": "name", - "type": "str" + "type": "255" } ], "meta-type": "object" @@ -10060,14 +10060,6 @@ { "name": "name", "type": "str" - }, - { - "name": "id", - "type": "int" - }, - { - "name": "ports", - "type": "int" } ], "meta-type": "object" @@ -10080,22 +10072,40 @@ "type": "str" }, { - "name": "tbl-id", - "default": null, + "name": "id", + "type": "int" + }, + { + "name": "ports", "type": "int" } ], "meta-type": "object" }, { - "name": "[141]", - "element-type": "141", - "meta-type": "array" - }, - { "name": "141", "members": [ { + "name": "name", + "type": "str" + }, + { + "name": "tbl-id", + "default": null, + "type": "int" + } + ], + "meta-type": "object" + }, + { + "name": "[142]", + "element-type": "142", + "meta-type": "array" + }, + { + "name": "142", + "members": [ + { "name": "cookie", "type": "int" }, @@ -10105,43 +10115,43 @@ }, { "name": "key", - "type": "260" + "type": "263" }, { "name": "mask", - "type": "261" + "type": "264" }, { "name": "action", - "type": "262" + "type": "265" } ], "meta-type": "object" }, { - "name": "142", - "members": [ - { - "name": "name", - "type": "str" - }, - { - "name": "type", - "default": null, - "type": "int" - } - ], - "meta-type": "object" - }, - { - "name": "[143]", - "element-type": "143", - "meta-type": "array" - }, - { "name": "143", "members": [ { + "name": "name", + "type": "str" + }, + { + "name": "type", + "default": null, + "type": "int" + } + ], + "meta-type": "object" + }, + { + "name": "[144]", + "element-type": "144", + "meta-type": "array" + }, + { + "name": "144", + "members": [ + { "name": "id", "type": "int" }, @@ -10208,26 +10218,26 @@ "meta-type": "object" }, { - "name": "144", - "members": [ - { - "name": "name", - "type": "str" - } - ], - "meta-type": "object" - }, - { - "name": "[145]", - "element-type": "145", - "meta-type": "array" - }, - { "name": "145", "members": [ { "name": "name", "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "[146]", + "element-type": "146", + "meta-type": "array" + }, + { + "name": "146", + "members": [ + { + "name": "name", + "type": "str" }, { "name": "enabled", @@ -10243,36 +10253,36 @@ }, { "name": "duplex", - "type": "263" + "type": "266" }, { "name": "autoneg", - "type": "264" + "type": "267" } ], "meta-type": "object" }, { - "name": "146", - "members": [ - { - "name": "name", - "default": null, - "type": "str" - } - ], - "meta-type": "object" - }, - { - "name": "[147]", - "element-type": "147", - "meta-type": "array" - }, - { "name": "147", "members": [ { "name": "name", + "default": null, + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "[148]", + "element-type": "148", + "meta-type": "array" + }, + { + "name": "148", + "members": [ + { + "name": "name", "type": "str" }, { @@ -10281,15 +10291,15 @@ }, { "name": "multicast", - "type": "265" + "type": "268" }, { "name": "unicast", - "type": "265" + "type": "268" }, { "name": "vlan", - "type": "265" + "type": "268" }, { "name": "broadcast-allowed", @@ -10323,7 +10333,7 @@ "meta-type": "object" }, { - "name": "148", + "name": "149", "members": [ { "name": "enabled", @@ -10360,7 +10370,7 @@ }, { "name": "mouse-mode", - "type": "266" + "type": "269" }, { "name": "channels", @@ -10371,7 +10381,7 @@ "meta-type": "object" }, { - "name": "149", + "name": "150", "members": [ { "name": "running", @@ -10383,40 +10393,17 @@ }, { "name": "status", - "type": "267" + "type": "270" } ], "meta-type": "object" }, { - "name": "150", - "members": [ - { - "name": "arch", - "type": "str" - } - ], - "meta-type": "object" - }, - { - "name": "[151]", - "element-type": "151", - "meta-type": "array" - }, - { "name": "151", "members": [ { - "name": "id", + "name": "arch", "type": "str" - }, - { - "name": "model", - "type": "152" - }, - { - "name": "options", - "type": "268" } ], "meta-type": "object" @@ -10428,10 +10415,21 @@ }, { "name": "152", - "meta-type": "enum", - "values": [ - "tpm-tis" - ] + "members": [ + { + "name": "id", + "type": "str" + }, + { + "name": "model", + "type": "153" + }, + { + "name": "options", + "type": "271" + } + ], + "meta-type": "object" }, { "name": "[153]", @@ -10442,25 +10440,37 @@ "name": "153", "meta-type": "enum", "values": [ - "passthrough" + "tpm-tis" ] }, { + "name": "[154]", + "element-type": "154", + "meta-type": "array" + }, + { "name": "154", - "members": [ - { - "name": "UUID", - "type": "str" - } - ], - "meta-type": "object" + "meta-type": "enum", + "values": [ + "passthrough" + ] }, { "name": "155", "members": [ { + "name": "UUID", + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "156", + "members": [ + { "name": "qemu", - "type": "269" + "type": "272" }, { "name": "package", @@ -10470,96 +10480,81 @@ "meta-type": "object" }, { - "name": "156", - "members": [ - { - "name": "guid", - "type": "str" - } - ], - "meta-type": "object" - }, - { "name": "157", "members": [ { - "name": "enabled", - "type": "bool" - }, - { - "name": "host", - "default": null, + "name": "guid", "type": "str" - }, - { - "name": "family", - "default": null, - "type": "270" - }, - { - "name": "service", - "default": null, - "type": "str" - }, - { - "name": "auth", - "default": null, - "type": "str" - }, - { - "name": "clients", - "default": null, - "type": "[191]" } ], "meta-type": "object" }, { - "name": "[158]", - "element-type": "158", - "meta-type": "array" - }, - { "name": "158", "members": [ { - "name": "id", + "name": "enabled", + "type": "bool" + }, + { + "name": "host", + "default": null, + "type": "str" + }, + { + "name": "family", + "default": null, + "type": "273" + }, + { + "name": "service", + "default": null, "type": "str" }, { - "name": "server", - "type": "[271]" + "name": "auth", + "default": null, + "type": "str" }, { "name": "clients", + "default": null, "type": "[191]" - }, - { - "name": "auth", - "type": "272" - }, - { - "name": "vencrypt", - "default": null, - "type": "273" - }, - { - "name": "display", - "default": null, - "type": "str" } ], "meta-type": "object" }, { + "name": "[159]", + "element-type": "159", + "meta-type": "array" + }, + { "name": "159", "members": [ { - "name": "error", - "type": "bool" + "name": "id", + "type": "str" }, { - "name": "desc", + "name": "server", + "type": "[274]" + }, + { + "name": "clients", + "type": "[191]" + }, + { + "name": "auth", + "type": "275" + }, + { + "name": "vencrypt", + "default": null, + "type": "276" + }, + { + "name": "display", "default": null, "type": "str" } @@ -10570,13 +10565,13 @@ "name": "160", "members": [ { - "name": "fdset-id", - "type": "int" + "name": "error", + "type": "bool" }, { - "name": "fd", + "name": "desc", "default": null, - "type": "int" + "type": "str" } ], "meta-type": "object" @@ -10585,17 +10580,13 @@ "name": "161", "members": [ { - "name": "device", - "type": "str" - }, - { - "name": "size", + "name": "fdset-id", "type": "int" }, { - "name": "format", + "name": "fd", "default": null, - "type": "274" + "type": "int" } ], "meta-type": "object" @@ -10608,13 +10599,13 @@ "type": "str" }, { - "name": "data", - "type": "str" + "name": "size", + "type": "int" }, { "name": "format", "default": null, - "type": "274" + "type": "277" } ], "meta-type": "object" @@ -10623,8 +10614,17 @@ "name": "163", "members": [ { - "name": "filename", + "name": "device", "type": "str" + }, + { + "name": "data", + "type": "str" + }, + { + "name": "format", + "default": null, + "type": "277" } ], "meta-type": "object" @@ -10633,8 +10633,18 @@ "name": "164", "members": [ { + "name": "filename", + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "165", + "members": [ + { "name": "keys", - "type": "[275]" + "type": "[278]" }, { "name": "hold-time", @@ -10645,34 +10655,15 @@ "meta-type": "object" }, { - "name": "165", - "members": [ - { - "name": "name", - "type": "str" - }, - { - "name": "up", - "type": "bool" - } - ], - "meta-type": "object" - }, - { "name": "166", "members": [ { - "name": "protocol", + "name": "name", "type": "str" }, { - "name": "password", - "type": "str" - }, - { - "name": "connected", - "default": null, - "type": "str" + "name": "up", + "type": "bool" } ], "meta-type": "object" @@ -10681,23 +10672,22 @@ "name": "167", "members": [ { - "name": "name", + "name": "protocol", "type": "str" }, { - "name": "vcpu", + "name": "password", + "type": "str" + }, + { + "name": "connected", "default": null, - "type": "int" + "type": "str" } ], "meta-type": "object" }, { - "name": "[168]", - "element-type": "168", - "meta-type": "array" - }, - { "name": "168", "members": [ { @@ -10705,17 +10695,19 @@ "type": "str" }, { - "name": "state", - "type": "276" - }, - { "name": "vcpu", - "type": "bool" + "default": null, + "type": "int" } ], "meta-type": "object" }, { + "name": "[169]", + "element-type": "169", + "meta-type": "array" + }, + { "name": "169", "members": [ { @@ -10723,18 +10715,12 @@ "type": "str" }, { - "name": "enable", - "type": "bool" - }, - { - "name": "ignore-unavailable", - "default": null, - "type": "bool" + "name": "state", + "type": "279" }, { "name": "vcpu", - "default": null, - "type": "int" + "type": "bool" } ], "meta-type": "object" @@ -10743,33 +10729,37 @@ "name": "170", "members": [ { + "name": "name", + "type": "str" + }, + { + "name": "enable", + "type": "bool" + }, + { + "name": "ignore-unavailable", + "default": null, + "type": "bool" + }, + { + "name": "vcpu", + "default": null, + "type": "int" + } + ], + "meta-type": "object" + }, + { + "name": "171", + "members": [ + { "name": "actions", - "type": "[277]" + "type": "[280]" }, { "name": "properties", "default": null, - "type": "278" - } - ], - "meta-type": "object" - }, - { - "name": "171", - "members": [ - { - "name": "parent", - "type": "str" - }, - { - "name": "child", - "default": null, - "type": "str" - }, - { - "name": "node", - "default": null, - "type": "str" + "type": "281" } ], "meta-type": "object" @@ -10778,7 +10768,17 @@ "name": "172", "members": [ { - "name": "node-name", + "name": "parent", + "type": "str" + }, + { + "name": "child", + "default": null, + "type": "str" + }, + { + "name": "node", + "default": null, "type": "str" } ], @@ -10915,13 +10915,13 @@ "variants": [ { "case": "hyper-v", - "type": "280" + "type": "283" } ], "members": [ { "name": "type", - "type": "279" + "type": "282" } ], "meta-type": "object" @@ -10963,7 +10963,7 @@ }, { "name": "family", - "type": "270" + "type": "273" } ], "meta-type": "object" @@ -10981,7 +10981,7 @@ }, { "name": "family", - "type": "270" + "type": "273" }, { "name": "auth", @@ -11004,7 +11004,7 @@ }, { "name": "family", - "type": "270" + "type": "273" }, { "name": "connection-id", @@ -11038,7 +11038,7 @@ }, { "name": "family", - "type": "270" + "type": "273" }, { "name": "websocket", @@ -11065,7 +11065,7 @@ }, { "name": "family", - "type": "270" + "type": "273" }, { "name": "websocket", @@ -11087,7 +11087,7 @@ }, { "name": "family", - "type": "270" + "type": "273" }, { "name": "websocket", @@ -11208,7 +11208,7 @@ "members": [ { "name": "image", - "type": "281" + "type": "284" }, { "name": "config", @@ -11223,12 +11223,12 @@ { "name": "inject-error", "default": null, - "type": "[282]" + "type": "[285]" }, { "name": "set-state", "default": null, - "type": "[283]" + "type": "[286]" } ], "meta-type": "object" @@ -11238,11 +11238,11 @@ "members": [ { "name": "test", - "type": "281" + "type": "284" }, { "name": "raw", - "type": "281" + "type": "284" } ], "meta-type": "object" @@ -11252,7 +11252,7 @@ "members": [ { "name": "file", - "type": "281" + "type": "284" } ], "meta-type": "object" @@ -11267,7 +11267,7 @@ { "name": "aio", "default": null, - "type": "284" + "type": "287" } ], "meta-type": "object" @@ -11276,7 +11276,37 @@ "name": "202", "members": [ { - "name": "filename", + "name": "url", + "type": "str" + }, + { + "name": "readahead", + "default": null, + "type": "int" + }, + { + "name": "timeout", + "default": null, + "type": "int" + }, + { + "name": "username", + "default": null, + "type": "str" + }, + { + "name": "password-secret", + "default": null, + "type": "str" + }, + { + "name": "proxy-username", + "default": null, + "type": "str" + }, + { + "name": "proxy-password-secret", + "default": null, "type": "str" } ], @@ -11286,26 +11316,43 @@ "name": "203", "members": [ { - "name": "volume", + "name": "url", "type": "str" }, { - "name": "path", + "name": "readahead", + "default": null, + "type": "int" + }, + { + "name": "timeout", + "default": null, + "type": "int" + }, + { + "name": "username", + "default": null, "type": "str" }, { - "name": "server", - "type": "[285]" + "name": "password-secret", + "default": null, + "type": "str" }, { - "name": "debug", + "name": "proxy-username", "default": null, - "type": "int" + "type": "str" }, { - "name": "logfile", + "name": "proxy-password-secret", "default": null, "type": "str" + }, + { + "name": "sslverify", + "default": null, + "type": "bool" } ], "meta-type": "object" @@ -11314,8 +11361,131 @@ "name": "204", "members": [ { + "name": "volume", + "type": "str" + }, + { + "name": "path", + "type": "str" + }, + { + "name": "server", + "type": "[288]" + }, + { + "name": "debug", + "default": null, + "type": "int" + }, + { + "name": "logfile", + "default": null, + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "205", + "members": [ + { + "name": "url", + "type": "str" + }, + { + "name": "readahead", + "default": null, + "type": "int" + }, + { + "name": "timeout", + "default": null, + "type": "int" + }, + { + "name": "username", + "default": null, + "type": "str" + }, + { + "name": "password-secret", + "default": null, + "type": "str" + }, + { + "name": "proxy-username", + "default": null, + "type": "str" + }, + { + "name": "proxy-password-secret", + "default": null, + "type": "str" + }, + { + "name": "cookie", + "default": null, + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "206", + "members": [ + { + "name": "url", + "type": "str" + }, + { + "name": "readahead", + "default": null, + "type": "int" + }, + { + "name": "timeout", + "default": null, + "type": "int" + }, + { + "name": "username", + "default": null, + "type": "str" + }, + { + "name": "password-secret", + "default": null, + "type": "str" + }, + { + "name": "proxy-username", + "default": null, + "type": "str" + }, + { + "name": "proxy-password-secret", + "default": null, + "type": "str" + }, + { + "name": "cookie", + "default": null, + "type": "str" + }, + { + "name": "sslverify", + "default": null, + "type": "bool" + } + ], + "meta-type": "object" + }, + { + "name": "207", + "members": [ + { "name": "transport", - "type": "286" + "type": "289" }, { "name": "portal", @@ -11348,7 +11518,7 @@ { "name": "header-digest", "default": null, - "type": "287" + "type": "290" }, { "name": "timeout", @@ -11359,11 +11529,11 @@ "meta-type": "object" }, { - "name": "205", + "name": "208", "members": [ { "name": "file", - "type": "281" + "type": "284" }, { "name": "key-secret", @@ -11374,11 +11544,11 @@ "meta-type": "object" }, { - "name": "206", + "name": "209", "members": [ { "name": "server", - "type": "224" + "type": "288" }, { "name": "export", @@ -11394,11 +11564,11 @@ "meta-type": "object" }, { - "name": "207", + "name": "210", "members": [ { "name": "server", - "type": "288" + "type": "291" }, { "name": "path", @@ -11438,7 +11608,7 @@ "meta-type": "object" }, { - "name": "208", + "name": "211", "members": [ { "name": "size", @@ -11454,16 +11624,16 @@ "meta-type": "object" }, { - "name": "209", + "name": "212", "members": [ { "name": "file", - "type": "281" + "type": "284" }, { "name": "backing", "default": null, - "type": "281" + "type": "284" }, { "name": "lazy-refcounts", @@ -11488,7 +11658,7 @@ { "name": "overlap-check", "default": null, - "type": "289" + "type": "292" }, { "name": "cache-size", @@ -11514,22 +11684,22 @@ "meta-type": "object" }, { - "name": "210", + "name": "213", "members": [ { "name": "file", - "type": "281" + "type": "284" }, { "name": "backing", "default": null, - "type": "281" + "type": "284" } ], "meta-type": "object" }, { - "name": "211", + "name": "214", "members": [ { "name": "blkverify", @@ -11538,7 +11708,7 @@ }, { "name": "children", - "type": "[281]" + "type": "[284]" }, { "name": "vote-threshold", @@ -11552,17 +11722,17 @@ { "name": "read-pattern", "default": null, - "type": "290" + "type": "293" } ], "meta-type": "object" }, { - "name": "212", + "name": "215", "members": [ { "name": "file", - "type": "281" + "type": "284" }, { "name": "offset", @@ -11578,7 +11748,7 @@ "meta-type": "object" }, { - "name": "213", + "name": "216", "members": [ { "name": "pool", @@ -11606,31 +11776,21 @@ { "name": "server", "default": null, - "type": "[291]" - }, - { - "name": "auth-supported", - "default": null, - "type": "[292]" - }, - { - "name": "password-secret", - "default": null, - "type": "str" + "type": "[294]" } ], "meta-type": "object" }, { - "name": "214", + "name": "217", "members": [ { "name": "file", - "type": "281" + "type": "284" }, { "name": "mode", - "type": "293" + "type": "295" }, { "name": "top-id", @@ -11641,11 +11801,11 @@ "meta-type": "object" }, { - "name": "215", + "name": "218", "members": [ { - "name": "addr", - "type": "285" + "name": "server", + "type": "288" }, { "name": "vdi", @@ -11665,11 +11825,11 @@ "meta-type": "object" }, { - "name": "216", + "name": "219", "members": [ { "name": "server", - "type": "291" + "type": "296" }, { "name": "path", @@ -11684,7 +11844,7 @@ "meta-type": "object" }, { - "name": "217", + "name": "220", "members": [ { "name": "dir", @@ -11714,7 +11874,7 @@ "meta-type": "object" }, { - "name": "218", + "name": "221", "meta-type": "enum", "values": [ "top", @@ -11724,7 +11884,7 @@ ] }, { - "name": "219", + "name": "222", "meta-type": "enum", "values": [ "retain", @@ -11733,7 +11893,7 @@ ] }, { - "name": "220", + "name": "223", "meta-type": "enum", "values": [ "existing", @@ -11741,100 +11901,100 @@ ] }, { - "name": "221", + "name": "224", "tag": "type", "variants": [ { "case": "file", - "type": "295" + "type": "298" }, { "case": "serial", - "type": "296" + "type": "299" }, { "case": "parallel", - "type": "296" + "type": "299" }, { "case": "pipe", - "type": "296" + "type": "299" }, { "case": "socket", - "type": "297" + "type": "300" }, { "case": "udp", - "type": "298" + "type": "301" }, { "case": "pty", - "type": "299" + "type": "302" }, { "case": "null", - "type": "299" + "type": "302" }, { "case": "mux", - "type": "300" + "type": "303" }, { "case": "msmouse", - "type": "299" + "type": "302" }, { "case": "wctablet", - "type": "299" + "type": "302" }, { "case": "braille", - "type": "299" + "type": "302" }, { "case": "testdev", - "type": "299" + "type": "302" }, { "case": "stdio", - "type": "301" + "type": "304" }, { "case": "console", - "type": "299" + "type": "302" }, { "case": "spicevmc", - "type": "302" + "type": "305" }, { "case": "spiceport", - "type": "303" + "type": "306" }, { "case": "vc", - "type": "304" + "type": "307" }, { "case": "ringbuf", - "type": "305" + "type": "308" }, { "case": "memory", - "type": "305" + "type": "308" } ], "members": [ { "name": "type", - "type": "294" + "type": "297" } ], "meta-type": "object" }, { - "name": "222", + "name": "225", "meta-type": "enum", "values": [ "elf", @@ -11844,35 +12004,35 @@ ] }, { - "name": "[223]", - "element-type": "223", + "name": "[226]", + "element-type": "226", "meta-type": "array" }, { - "name": "223", + "name": "226", "tag": "type", "variants": [ { "case": "key", - "type": "307" + "type": "310" }, { "case": "btn", - "type": "308" + "type": "311" }, { "case": "rel", - "type": "309" + "type": "312" }, { "case": "abs", - "type": "309" + "type": "312" } ], "members": [ { "name": "type", - "type": "306" + "type": "309" } ], "meta-type": "object" @@ -11883,36 +12043,36 @@ "meta-type": "builtin" }, { - "name": "224", + "name": "227", "tag": "type", "variants": [ { "case": "inet", - "type": "311" - }, - { - "case": "unix", - "type": "312" - }, - { - "case": "vsock", - "type": "313" - }, - { - "case": "fd", "type": "314" + }, + { + "case": "unix", + "type": "315" + }, + { + "case": "vsock", + "type": "316" + }, + { + "case": "fd", + "type": "317" } ], "members": [ { "name": "type", - "type": "310" + "type": "313" } ], "meta-type": "object" }, { - "name": "225", + "name": "228", "meta-type": "enum", "values": [ "DIMM", @@ -11920,7 +12080,7 @@ ] }, { - "name": "226", + "name": "229", "meta-type": "enum", "values": [ "ok", @@ -11929,12 +12089,12 @@ ] }, { - "name": "[227]", - "element-type": "227", + "name": "[230]", + "element-type": "230", "meta-type": "array" }, { - "name": "227", + "name": "230", "members": [ { "name": "name", @@ -11951,13 +12111,13 @@ }, { "name": "status", - "type": "315" + "type": "318" } ], "meta-type": "object" }, { - "name": "228", + "name": "231", "members": [ { "name": "rd_bytes", @@ -12042,18 +12202,18 @@ }, { "name": "timed_stats", - "type": "[316]" + "type": "[319]" } ], "meta-type": "object" }, { - "name": "[229]", - "element-type": "229", + "name": "[232]", + "element-type": "232", "meta-type": "array" }, { - "name": "229", + "name": "232", "members": [ { "name": "name", @@ -12061,7 +12221,7 @@ }, { "name": "type", - "type": "317" + "type": "320" }, { "name": "help", @@ -12082,7 +12242,7 @@ "meta-type": "array" }, { - "name": "230", + "name": "233", "members": [ { "name": "name", @@ -12097,7 +12257,7 @@ "meta-type": "object" }, { - "name": "231", + "name": "234", "meta-type": "enum", "values": [ "incompatible", @@ -12107,7 +12267,7 @@ ] }, { - "name": "232", + "name": "235", "meta-type": "enum", "values": [ "static", @@ -12115,7 +12275,7 @@ ] }, { - "name": "233", + "name": "236", "meta-type": "enum", "values": [ "x86", @@ -12127,44 +12287,10 @@ ] }, { - "name": "234", - "members": [ - { - "name": "pc", - "type": "int" - } - ], - "meta-type": "object" - }, - { - "name": "235", - "members": [ - { - "name": "pc", - "type": "int" - }, - { - "name": "npc", - "type": "int" - } - ], - "meta-type": "object" - }, - { - "name": "236", - "members": [ - { - "name": "nip", - "type": "int" - } - ], - "meta-type": "object" - }, - { "name": "237", "members": [ { - "name": "PC", + "name": "pc", "type": "int" } ], @@ -12174,7 +12300,11 @@ "name": "238", "members": [ { - "name": "PC", + "name": "pc", + "type": "int" + }, + { + "name": "npc", "type": "int" } ], @@ -12183,40 +12313,29 @@ { "name": "239", "members": [ + { + "name": "nip", + "type": "int" + } ], "meta-type": "object" }, { "name": "240", - "meta-type": "enum", - "values": [ - "none", - "active", - "completed", - "failed" - ] - }, - { - "name": "[222]", - "element-type": "222", - "meta-type": "array" - }, - { - "name": "[241]", - "element-type": "241", - "meta-type": "array" + "members": [ + { + "name": "PC", + "type": "int" + } + ], + "meta-type": "object" }, { "name": "241", "members": [ { - "name": "fd", + "name": "PC", "type": "int" - }, - { - "name": "opaque", - "default": null, - "type": "str" } ], "meta-type": "object" @@ -12224,6 +12343,47 @@ { "name": "242", "members": [ + ], + "meta-type": "object" + }, + { + "name": "243", + "meta-type": "enum", + "values": [ + "none", + "active", + "completed", + "failed" + ] + }, + { + "name": "[225]", + "element-type": "225", + "meta-type": "array" + }, + { + "name": "[244]", + "element-type": "244", + "meta-type": "array" + }, + { + "name": "244", + "members": [ + { + "name": "fd", + "type": "int" + }, + { + "name": "opaque", + "default": null, + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "245", + "members": [ { "name": "node-id", "default": null, @@ -12253,7 +12413,7 @@ "meta-type": "array" }, { - "name": "243", + "name": "246", "meta-type": "enum", "values": [ "default", @@ -12263,24 +12423,24 @@ ] }, { - "name": "244", + "name": "247", "meta-type": "enum", "values": [ "dimm" ] }, { - "name": "245", + "name": "248", "members": [ { "name": "data", - "type": "318" + "type": "321" } ], "meta-type": "object" }, { - "name": "246", + "name": "249", "members": [ { "name": "transferred", @@ -12330,7 +12490,7 @@ "meta-type": "object" }, { - "name": "247", + "name": "250", "members": [ { "name": "cache-size", @@ -12360,7 +12520,7 @@ "meta-type": "object" }, { - "name": "248", + "name": "251", "meta-type": "enum", "values": [ "xbzrle", @@ -12375,7 +12535,7 @@ ] }, { - "name": "249", + "name": "252", "members": [ { "name": "filename", @@ -12432,23 +12592,23 @@ { "name": "snapshots", "default": null, - "type": "[54]" + "type": "[55]" }, { "name": "backing-image", "default": null, - "type": "249" + "type": "252" }, { "name": "format-specific", "default": null, - "type": "319" + "type": "322" } ], "meta-type": "object" }, { - "name": "250", + "name": "253", "members": [ { "name": "writeback", @@ -12466,12 +12626,12 @@ "meta-type": "object" }, { - "name": "[251]", - "element-type": "251", + "name": "[254]", + "element-type": "254", "meta-type": "array" }, { - "name": "251", + "name": "254", "members": [ { "name": "bus", @@ -12487,11 +12647,11 @@ }, { "name": "class_info", - "type": "320" + "type": "323" }, { "name": "id", - "type": "321" + "type": "324" }, { "name": "irq", @@ -12505,17 +12665,17 @@ { "name": "pci_bridge", "default": null, - "type": "322" + "type": "325" }, { "name": "regions", - "type": "[323]" + "type": "[326]" } ], "meta-type": "object" }, { - "name": "252", + "name": "255", "meta-type": "enum", "values": [ "builtin", @@ -12528,51 +12688,11 @@ ] }, { - "name": "253", - "members": [ - { - "name": "json-type", - "type": "324" - } - ], - "meta-type": "object" - }, - { - "name": "254", - "members": [ - { - "name": "values", - "type": "[str]" - } - ], - "meta-type": "object" - }, - { - "name": "255", - "members": [ - { - "name": "element-type", - "type": "str" - } - ], - "meta-type": "object" - }, - { "name": "256", "members": [ { - "name": "members", - "type": "[325]" - }, - { - "name": "tag", - "default": null, - "type": "str" - }, - { - "name": "variants", - "default": null, - "type": "[326]" + "name": "json-type", + "type": "327" } ], "meta-type": "object" @@ -12581,8 +12701,8 @@ "name": "257", "members": [ { - "name": "members", - "type": "[327]" + "name": "values", + "type": "[str]" } ], "meta-type": "object" @@ -12591,11 +12711,7 @@ "name": "258", "members": [ { - "name": "arg-type", - "type": "str" - }, - { - "name": "ret-type", + "name": "element-type", "type": "str" } ], @@ -12605,8 +12721,18 @@ "name": "259", "members": [ { - "name": "arg-type", + "name": "members", + "type": "[328]" + }, + { + "name": "tag", + "default": null, "type": "str" + }, + { + "name": "variants", + "default": null, + "type": "[329]" } ], "meta-type": "object" @@ -12615,6 +12741,40 @@ "name": "260", "members": [ { + "name": "members", + "type": "[330]" + } + ], + "meta-type": "object" + }, + { + "name": "261", + "members": [ + { + "name": "arg-type", + "type": "str" + }, + { + "name": "ret-type", + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "262", + "members": [ + { + "name": "arg-type", + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "263", + "members": [ + { "name": "priority", "type": "int" }, @@ -12671,7 +12831,7 @@ "meta-type": "object" }, { - "name": "261", + "name": "264", "members": [ { "name": "in-pport", @@ -12712,7 +12872,7 @@ "meta-type": "object" }, { - "name": "262", + "name": "265", "members": [ { "name": "goto-tbl", @@ -12748,7 +12908,7 @@ "meta-type": "object" }, { - "name": "263", + "name": "266", "meta-type": "enum", "values": [ "half", @@ -12756,7 +12916,7 @@ ] }, { - "name": "264", + "name": "267", "meta-type": "enum", "values": [ "off", @@ -12764,7 +12924,7 @@ ] }, { - "name": "265", + "name": "268", "meta-type": "enum", "values": [ "normal", @@ -12773,7 +12933,7 @@ ] }, { - "name": "266", + "name": "269", "meta-type": "enum", "values": [ "client", @@ -12787,7 +12947,7 @@ "meta-type": "array" }, { - "name": "267", + "name": "270", "meta-type": "enum", "values": [ "debug", @@ -12809,24 +12969,24 @@ ] }, { - "name": "268", + "name": "271", "tag": "type", "variants": [ { "case": "passthrough", - "type": "329" + "type": "332" } ], "members": [ { "name": "type", - "type": "328" + "type": "331" } ], "meta-type": "object" }, { - "name": "269", + "name": "272", "members": [ { "name": "major", @@ -12844,7 +13004,7 @@ "meta-type": "object" }, { - "name": "270", + "name": "273", "meta-type": "enum", "values": [ "ipv4", @@ -12860,12 +13020,12 @@ "meta-type": "array" }, { - "name": "[271]", - "element-type": "271", + "name": "[274]", + "element-type": "274", "meta-type": "array" }, { - "name": "271", + "name": "274", "members": [ { "name": "host", @@ -12877,7 +13037,7 @@ }, { "name": "family", - "type": "270" + "type": "273" }, { "name": "websocket", @@ -12885,18 +13045,18 @@ }, { "name": "auth", - "type": "272" + "type": "275" }, { "name": "vencrypt", "default": null, - "type": "273" + "type": "276" } ], "meta-type": "object" }, { - "name": "272", + "name": "275", "meta-type": "enum", "values": [ "none", @@ -12911,7 +13071,7 @@ ] }, { - "name": "273", + "name": "276", "meta-type": "enum", "values": [ "plain", @@ -12926,7 +13086,7 @@ ] }, { - "name": "274", + "name": "277", "meta-type": "enum", "values": [ "utf8", @@ -12934,33 +13094,33 @@ ] }, { - "name": "[275]", - "element-type": "275", + "name": "[278]", + "element-type": "278", "meta-type": "array" }, { - "name": "275", + "name": "278", "tag": "type", "variants": [ { "case": "number", - "type": "331" + "type": "334" }, { "case": "qcode", - "type": "332" + "type": "335" } ], "members": [ { "name": "type", - "type": "330" + "type": "333" } ], "meta-type": "object" }, { - "name": "276", + "name": "279", "meta-type": "enum", "values": [ "unavailable", @@ -12969,75 +13129,75 @@ ] }, { - "name": "[277]", - "element-type": "277", + "name": "[280]", + "element-type": "280", "meta-type": "array" }, { - "name": "277", + "name": "280", "tag": "type", "variants": [ { "case": "abort", - "type": "334" + "type": "337" }, { "case": "block-dirty-bitmap-add", - "type": "335" + "type": "338" }, { "case": "block-dirty-bitmap-clear", - "type": "336" + "type": "339" }, { "case": "blockdev-backup", - "type": "337" + "type": "340" }, { "case": "blockdev-snapshot", - "type": "338" + "type": "341" }, { "case": "blockdev-snapshot-internal-sync", - "type": "339" + "type": "342" }, { "case": "blockdev-snapshot-sync", - "type": "340" + "type": "343" }, { "case": "drive-backup", - "type": "341" + "type": "344" } ], "members": [ { "name": "type", - "type": "333" + "type": "336" } ], "meta-type": "object" }, { - "name": "278", + "name": "281", "members": [ { "name": "completion-mode", "default": null, - "type": "342" + "type": "345" } ], "meta-type": "object" }, { - "name": "279", + "name": "282", "meta-type": "enum", "values": [ "hyper-v" ] }, { - "name": "280", + "name": "283", "members": [ { "name": "arg1", @@ -13063,7 +13223,7 @@ "meta-type": "object" }, { - "name": "281", + "name": "284", "members": [ { "type": "46" @@ -13075,16 +13235,16 @@ "meta-type": "alternate" }, { - "name": "[282]", - "element-type": "282", + "name": "[285]", + "element-type": "285", "meta-type": "array" }, { - "name": "282", + "name": "285", "members": [ { "name": "event", - "type": "343" + "type": "346" }, { "name": "state", @@ -13115,16 +13275,16 @@ "meta-type": "object" }, { - "name": "[283]", - "element-type": "283", + "name": "[286]", + "element-type": "286", "meta-type": "array" }, { - "name": "283", + "name": "286", "members": [ { "name": "event", - "type": "343" + "type": "346" }, { "name": "state", @@ -13139,7 +13299,7 @@ "meta-type": "object" }, { - "name": "284", + "name": "287", "meta-type": "enum", "values": [ "threads", @@ -13147,33 +13307,41 @@ ] }, { - "name": "[285]", - "element-type": "285", + "name": "[288]", + "element-type": "288", "meta-type": "array" }, { - "name": "285", + "name": "288", "tag": "type", "variants": [ { - "case": "unix", - "type": "345" - }, - { "case": "inet", - "type": "291" + "type": "296" + }, + { + "case": "unix", + "type": "348" + }, + { + "case": "vsock", + "type": "349" + }, + { + "case": "fd", + "type": "350" } ], "members": [ { "name": "type", - "type": "344" + "type": "347" } ], "meta-type": "object" }, { - "name": "286", + "name": "289", "meta-type": "enum", "values": [ "tcp", @@ -13181,7 +13349,7 @@ ] }, { - "name": "287", + "name": "290", "meta-type": "enum", "values": [ "crc32c", @@ -13191,108 +13359,107 @@ ] }, { - "name": "288", - "members": [ - { - "name": "type", - "type": "346" - }, - { - "name": "host", - "type": "str" - } - ], - "meta-type": "object" - }, - { - "name": "289", - "members": [ - { - "type": "347" - }, - { - "type": "348" - } - ], - "meta-type": "alternate" - }, - { - "name": "[281]", - "element-type": "281", - "meta-type": "array" - }, - { - "name": "290", - "meta-type": "enum", - "values": [ - "quorum", - "fifo" - ] - }, - { - "name": "[291]", - "element-type": "291", - "meta-type": "array" - }, - { "name": "291", "members": [ { + "name": "type", + "type": "351" + }, + { "name": "host", "type": "str" - }, - { - "name": "port", - "type": "str" - }, - { - "name": "numeric", - "default": null, - "type": "bool" - }, - { - "name": "to", - "default": null, - "type": "int" - }, - { - "name": "ipv4", - "default": null, - "type": "bool" - }, - { - "name": "ipv6", - "default": null, - "type": "bool" } ], "meta-type": "object" }, { - "name": "[292]", - "element-type": "292", - "meta-type": "array" - }, - { "name": "292", "members": [ { - "name": "auth", - "type": "349" + "type": "352" + }, + { + "type": "353" } ], - "meta-type": "object" + "meta-type": "alternate" + }, + { + "name": "[284]", + "element-type": "284", + "meta-type": "array" }, { "name": "293", "meta-type": "enum", "values": [ + "quorum", + "fifo" + ] + }, + { + "name": "[294]", + "element-type": "294", + "meta-type": "array" + }, + { + "name": "294", + "members": [ + { + "name": "host", + "type": "str" + }, + { + "name": "port", + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "295", + "meta-type": "enum", + "values": [ "primary", "secondary" ] }, { - "name": "294", + "name": "296", + "members": [ + { + "name": "host", + "type": "str" + }, + { + "name": "port", + "type": "str" + }, + { + "name": "numeric", + "default": null, + "type": "bool" + }, + { + "name": "to", + "default": null, + "type": "int" + }, + { + "name": "ipv4", + "default": null, + "type": "bool" + }, + { + "name": "ipv6", + "default": null, + "type": "bool" + } + ], + "meta-type": "object" + }, + { + "name": "297", "meta-type": "enum", "values": [ "file", @@ -13318,57 +13485,17 @@ ] }, { - "name": "295", - "members": [ - { - "name": "data", - "type": "350" - } - ], - "meta-type": "object" - }, - { - "name": "296", - "members": [ - { - "name": "data", - "type": "351" - } - ], - "meta-type": "object" - }, - { - "name": "297", - "members": [ - { - "name": "data", - "type": "352" - } - ], - "meta-type": "object" - }, - { "name": "298", "members": [ { "name": "data", - "type": "353" - } - ], - "meta-type": "object" - }, - { - "name": "299", - "members": [ - { - "name": "data", "type": "354" } ], "meta-type": "object" }, { - "name": "300", + "name": "299", "members": [ { "name": "data", @@ -13378,7 +13505,7 @@ "meta-type": "object" }, { - "name": "301", + "name": "300", "members": [ { "name": "data", @@ -13388,7 +13515,7 @@ "meta-type": "object" }, { - "name": "302", + "name": "301", "members": [ { "name": "data", @@ -13398,7 +13525,7 @@ "meta-type": "object" }, { - "name": "303", + "name": "302", "members": [ { "name": "data", @@ -13408,7 +13535,7 @@ "meta-type": "object" }, { - "name": "304", + "name": "303", "members": [ { "name": "data", @@ -13418,7 +13545,7 @@ "meta-type": "object" }, { - "name": "305", + "name": "304", "members": [ { "name": "data", @@ -13428,7 +13555,47 @@ "meta-type": "object" }, { + "name": "305", + "members": [ + { + "name": "data", + "type": "361" + } + ], + "meta-type": "object" + }, + { "name": "306", + "members": [ + { + "name": "data", + "type": "362" + } + ], + "meta-type": "object" + }, + { + "name": "307", + "members": [ + { + "name": "data", + "type": "363" + } + ], + "meta-type": "object" + }, + { + "name": "308", + "members": [ + { + "name": "data", + "type": "364" + } + ], + "meta-type": "object" + }, + { + "name": "309", "meta-type": "enum", "values": [ "key", @@ -13438,51 +13605,21 @@ ] }, { - "name": "307", - "members": [ - { - "name": "data", - "type": "361" - } - ], - "meta-type": "object" - }, - { - "name": "308", - "members": [ - { - "name": "data", - "type": "362" - } - ], - "meta-type": "object" - }, - { - "name": "309", - "members": [ - { - "name": "data", - "type": "363" - } - ], - "meta-type": "object" - }, - { "name": "310", - "meta-type": "enum", - "values": [ - "inet", - "unix", - "vsock", - "fd" - ] + "members": [ + { + "name": "data", + "type": "365" + } + ], + "meta-type": "object" }, { "name": "311", "members": [ { "name": "data", - "type": "291" + "type": "366" } ], "meta-type": "object" @@ -13492,49 +13629,79 @@ "members": [ { "name": "data", - "type": "345" + "type": "367" } ], "meta-type": "object" }, { "name": "313", - "members": [ - { - "name": "data", - "type": "364" - } - ], - "meta-type": "object" + "meta-type": "enum", + "values": [ + "inet", + "unix", + "vsock", + "fd" + ] }, { "name": "314", "members": [ { "name": "data", - "type": "365" + "type": "296" } ], "meta-type": "object" }, { "name": "315", - "meta-type": "enum", - "values": [ - "active", - "disabled", - "frozen" - ] - }, - { - "name": "[316]", - "element-type": "316", - "meta-type": "array" + "members": [ + { + "name": "data", + "type": "348" + } + ], + "meta-type": "object" }, { "name": "316", "members": [ { + "name": "data", + "type": "349" + } + ], + "meta-type": "object" + }, + { + "name": "317", + "members": [ + { + "name": "data", + "type": "350" + } + ], + "meta-type": "object" + }, + { + "name": "318", + "meta-type": "enum", + "values": [ + "active", + "disabled", + "frozen" + ] + }, + { + "name": "[319]", + "element-type": "319", + "meta-type": "array" + }, + { + "name": "319", + "members": [ + { "name": "interval_length", "type": "int" }, @@ -13586,7 +13753,7 @@ "meta-type": "object" }, { - "name": "317", + "name": "320", "meta-type": "enum", "values": [ "string", @@ -13596,7 +13763,7 @@ ] }, { - "name": "318", + "name": "321", "members": [ { "name": "id", @@ -13635,150 +13802,75 @@ "meta-type": "object" }, { - "name": "[54]", - "element-type": "54", + "name": "[55]", + "element-type": "55", "meta-type": "array" }, { - "name": "319", - "tag": "type", - "variants": [ - { - "case": "qcow2", - "type": "367" - }, - { - "case": "vmdk", - "type": "368" - }, - { - "case": "luks", - "type": "369" - } - ], - "members": [ - { - "name": "type", - "type": "366" - } - ], - "meta-type": "object" - }, - { - "name": "320", - "members": [ - { - "name": "desc", - "default": null, - "type": "str" - }, - { - "name": "class", - "type": "int" - } - ], - "meta-type": "object" - }, - { - "name": "321", - "members": [ - { - "name": "device", - "type": "int" - }, - { - "name": "vendor", - "type": "int" - } - ], - "meta-type": "object" - }, - { "name": "322", - "members": [ + "tag": "type", + "variants": [ { - "name": "bus", + "case": "qcow2", + "type": "369" + }, + { + "case": "vmdk", "type": "370" }, { - "name": "devices", - "default": null, - "type": "[251]" + "case": "luks", + "type": "371" + } + ], + "members": [ + { + "name": "type", + "type": "368" } ], "meta-type": "object" }, { - "name": "[323]", - "element-type": "323", - "meta-type": "array" - }, - { "name": "323", "members": [ { - "name": "bar", - "type": "int" - }, - { - "name": "type", + "name": "desc", + "default": null, "type": "str" }, { - "name": "address", + "name": "class", "type": "int" - }, - { - "name": "size", - "type": "int" - }, - { - "name": "prefetch", - "default": null, - "type": "bool" - }, - { - "name": "mem_type_64", - "default": null, - "type": "bool" } ], "meta-type": "object" }, { "name": "324", - "meta-type": "enum", - "values": [ - "string", - "number", - "int", - "boolean", - "null", - "object", - "array", - "value" - ] - }, - { - "name": "[325]", - "element-type": "325", - "meta-type": "array" + "members": [ + { + "name": "device", + "type": "int" + }, + { + "name": "vendor", + "type": "int" + } + ], + "meta-type": "object" }, { "name": "325", "members": [ { - "name": "name", - "type": "str" + "name": "bus", + "type": "372" }, { - "name": "type", - "type": "str" - }, - { - "name": "default", + "name": "devices", "default": null, - "type": "any" + "type": "[254]" } ], "meta-type": "object" @@ -13792,72 +13884,119 @@ "name": "326", "members": [ { - "name": "case", - "type": "str" + "name": "bar", + "type": "int" }, { "name": "type", "type": "str" + }, + { + "name": "address", + "type": "int" + }, + { + "name": "size", + "type": "int" + }, + { + "name": "prefetch", + "default": null, + "type": "bool" + }, + { + "name": "mem_type_64", + "default": null, + "type": "bool" } ], "meta-type": "object" }, { - "name": "[327]", - "element-type": "327", - "meta-type": "array" - }, - { "name": "327", - "members": [ - { - "name": "type", - "type": "str" - } - ], - "meta-type": "object" + "meta-type": "enum", + "values": [ + "string", + "number", + "int", + "boolean", + "null", + "object", + "array", + "value" + ] + }, + { + "name": "[328]", + "element-type": "328", + "meta-type": "array" }, { "name": "328", - "meta-type": "enum", - "values": [ - "passthrough" - ] + "members": [ + { + "name": "name", + "type": "str" + }, + { + "name": "type", + "type": "str" + }, + { + "name": "default", + "default": null, + "type": "any" + } + ], + "meta-type": "object" + }, + { + "name": "[329]", + "element-type": "329", + "meta-type": "array" }, { "name": "329", "members": [ { - "name": "data", - "type": "371" + "name": "case", + "type": "str" + }, + { + "name": "type", + "type": "str" } ], "meta-type": "object" }, { + "name": "[330]", + "element-type": "330", + "meta-type": "array" + }, + { "name": "330", - "meta-type": "enum", - "values": [ - "number", - "qcode" - ] + "members": [ + { + "name": "type", + "type": "str" + } + ], + "meta-type": "object" }, { "name": "331", - "members": [ - { - "name": "data", - "type": "int" - } - ], - "meta-type": "object" + "meta-type": "enum", + "values": [ + "passthrough" + ] }, { "name": "332", "members": [ { "name": "data", - "type": "372" + "type": "373" } ], "meta-type": "object" @@ -13866,6 +14005,34 @@ "name": "333", "meta-type": "enum", "values": [ + "number", + "qcode" + ] + }, + { + "name": "334", + "members": [ + { + "name": "data", + "type": "int" + } + ], + "meta-type": "object" + }, + { + "name": "335", + "members": [ + { + "name": "data", + "type": "374" + } + ], + "meta-type": "object" + }, + { + "name": "336", + "meta-type": "enum", + "values": [ "abort", "block-dirty-bitmap-add", "block-dirty-bitmap-clear", @@ -13877,41 +14044,11 @@ ] }, { - "name": "334", - "members": [ - { - "name": "data", - "type": "373" - } - ], - "meta-type": "object" - }, - { - "name": "335", - "members": [ - { - "name": "data", - "type": "34" - } - ], - "meta-type": "object" - }, - { - "name": "336", - "members": [ - { - "name": "data", - "type": "35" - } - ], - "meta-type": "object" - }, - { "name": "337", "members": [ { "name": "data", - "type": "47" + "type": "375" } ], "meta-type": "object" @@ -13921,7 +14058,7 @@ "members": [ { "name": "data", - "type": "52" + "type": "34" } ], "meta-type": "object" @@ -13931,7 +14068,7 @@ "members": [ { "name": "data", - "type": "55" + "type": "35" } ], "meta-type": "object" @@ -13941,7 +14078,7 @@ "members": [ { "name": "data", - "type": "56" + "type": "47" } ], "meta-type": "object" @@ -13951,13 +14088,43 @@ "members": [ { "name": "data", - "type": "71" + "type": "53" } ], "meta-type": "object" }, { "name": "342", + "members": [ + { + "name": "data", + "type": "56" + } + ], + "meta-type": "object" + }, + { + "name": "343", + "members": [ + { + "name": "data", + "type": "57" + } + ], + "meta-type": "object" + }, + { + "name": "344", + "members": [ + { + "name": "data", + "type": "72" + } + ], + "meta-type": "object" + }, + { + "name": "345", "meta-type": "enum", "values": [ "individual", @@ -13965,7 +14132,7 @@ ] }, { - "name": "343", + "name": "346", "meta-type": "enum", "values": [ "l1_update", @@ -14014,37 +14181,63 @@ ] }, { - "name": "344", - "meta-type": "enum", - "values": [ - "unix", - "inet" - ] - }, - { - "name": "345", - "members": [ - { - "name": "path", - "type": "str" - } - ], - "meta-type": "object" - }, - { - "name": "346", - "meta-type": "enum", - "values": [ - "inet" - ] - }, - { "name": "347", + "meta-type": "enum", + "values": [ + "inet", + "unix", + "vsock", + "fd" + ] + }, + { + "name": "348", + "members": [ + { + "name": "path", + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "349", + "members": [ + { + "name": "cid", + "type": "str" + }, + { + "name": "port", + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "350", + "members": [ + { + "name": "str", + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "351", + "meta-type": "enum", + "values": [ + "inet" + ] + }, + { + "name": "352", "members": [ { "name": "template", "default": null, - "type": "348" + "type": "353" }, { "name": "main-header", @@ -14090,7 +14283,7 @@ "meta-type": "object" }, { - "name": "348", + "name": "353", "meta-type": "enum", "values": [ "none", @@ -14100,15 +14293,7 @@ ] }, { - "name": "349", - "meta-type": "enum", - "values": [ - "cephx", - "none" - ] - }, - { - "name": "350", + "name": "354", "members": [ { "name": "logfile", @@ -14138,117 +14323,6 @@ "meta-type": "object" }, { - "name": "351", - "members": [ - { - "name": "logfile", - "default": null, - "type": "str" - }, - { - "name": "logappend", - "default": null, - "type": "bool" - }, - { - "name": "device", - "type": "str" - } - ], - "meta-type": "object" - }, - { - "name": "352", - "members": [ - { - "name": "logfile", - "default": null, - "type": "str" - }, - { - "name": "logappend", - "default": null, - "type": "bool" - }, - { - "name": "addr", - "type": "224" - }, - { - "name": "tls-creds", - "default": null, - "type": "str" - }, - { - "name": "server", - "default": null, - "type": "bool" - }, - { - "name": "wait", - "default": null, - "type": "bool" - }, - { - "name": "nodelay", - "default": null, - "type": "bool" - }, - { - "name": "telnet", - "default": null, - "type": "bool" - }, - { - "name": "reconnect", - "default": null, - "type": "int" - } - ], - "meta-type": "object" - }, - { - "name": "353", - "members": [ - { - "name": "logfile", - "default": null, - "type": "str" - }, - { - "name": "logappend", - "default": null, - "type": "bool" - }, - { - "name": "remote", - "type": "224" - }, - { - "name": "local", - "default": null, - "type": "224" - } - ], - "meta-type": "object" - }, - { - "name": "354", - "members": [ - { - "name": "logfile", - "default": null, - "type": "str" - }, - { - "name": "logappend", - "default": null, - "type": "bool" - } - ], - "meta-type": "object" - }, - { "name": "355", "members": [ { @@ -14262,7 +14336,7 @@ "type": "bool" }, { - "name": "chardev", + "name": "device", "type": "str" } ], @@ -14282,9 +14356,38 @@ "type": "bool" }, { - "name": "signal", + "name": "addr", + "type": "227" + }, + { + "name": "tls-creds", + "default": null, + "type": "str" + }, + { + "name": "server", + "default": null, + "type": "bool" + }, + { + "name": "wait", + "default": null, + "type": "bool" + }, + { + "name": "nodelay", + "default": null, + "type": "bool" + }, + { + "name": "telnet", "default": null, "type": "bool" + }, + { + "name": "reconnect", + "default": null, + "type": "int" } ], "meta-type": "object" @@ -14303,8 +14406,13 @@ "type": "bool" }, { - "name": "type", - "type": "str" + "name": "remote", + "type": "227" + }, + { + "name": "local", + "default": null, + "type": "227" } ], "meta-type": "object" @@ -14321,10 +14429,6 @@ "name": "logappend", "default": null, "type": "bool" - }, - { - "name": "fqdn", - "type": "str" } ], "meta-type": "object" @@ -14343,24 +14447,8 @@ "type": "bool" }, { - "name": "width", - "default": null, - "type": "int" - }, - { - "name": "height", - "default": null, - "type": "int" - }, - { - "name": "cols", - "default": null, - "type": "int" - }, - { - "name": "rows", - "default": null, - "type": "int" + "name": "chardev", + "type": "str" } ], "meta-type": "object" @@ -14379,9 +14467,9 @@ "type": "bool" }, { - "name": "size", + "name": "signal", "default": null, - "type": "int" + "type": "bool" } ], "meta-type": "object" @@ -14390,12 +14478,18 @@ "name": "361", "members": [ { - "name": "key", - "type": "275" + "name": "logfile", + "default": null, + "type": "str" }, { - "name": "down", + "name": "logappend", + "default": null, "type": "bool" + }, + { + "name": "type", + "type": "str" } ], "meta-type": "object" @@ -14404,12 +14498,18 @@ "name": "362", "members": [ { - "name": "button", - "type": "374" + "name": "logfile", + "default": null, + "type": "str" }, { - "name": "down", + "name": "logappend", + "default": null, "type": "bool" + }, + { + "name": "fqdn", + "type": "str" } ], "meta-type": "object" @@ -14418,11 +14518,33 @@ "name": "363", "members": [ { - "name": "axis", - "type": "375" + "name": "logfile", + "default": null, + "type": "str" }, { - "name": "value", + "name": "logappend", + "default": null, + "type": "bool" + }, + { + "name": "width", + "default": null, + "type": "int" + }, + { + "name": "height", + "default": null, + "type": "int" + }, + { + "name": "cols", + "default": null, + "type": "int" + }, + { + "name": "rows", + "default": null, "type": "int" } ], @@ -14432,12 +14554,19 @@ "name": "364", "members": [ { - "name": "cid", + "name": "logfile", + "default": null, "type": "str" }, { - "name": "port", - "type": "str" + "name": "logappend", + "default": null, + "type": "bool" + }, + { + "name": "size", + "default": null, + "type": "int" } ], "meta-type": "object" @@ -14446,42 +14575,54 @@ "name": "365", "members": [ { - "name": "str", - "type": "str" + "name": "key", + "type": "278" + }, + { + "name": "down", + "type": "bool" } ], "meta-type": "object" }, { "name": "366", - "meta-type": "enum", - "values": [ - "qcow2", - "vmdk", - "luks" - ] - }, - { - "name": "367", "members": [ { - "name": "data", + "name": "button", "type": "376" + }, + { + "name": "down", + "type": "bool" } ], "meta-type": "object" }, { - "name": "368", + "name": "367", "members": [ { - "name": "data", + "name": "axis", "type": "377" + }, + { + "name": "value", + "type": "int" } ], "meta-type": "object" }, { + "name": "368", + "meta-type": "enum", + "values": [ + "qcow2", + "vmdk", + "luks" + ] + }, + { "name": "369", "members": [ { @@ -14495,6 +14636,26 @@ "name": "370", "members": [ { + "name": "data", + "type": "379" + } + ], + "meta-type": "object" + }, + { + "name": "371", + "members": [ + { + "name": "data", + "type": "380" + } + ], + "meta-type": "object" + }, + { + "name": "372", + "members": [ + { "name": "number", "type": "int" }, @@ -14508,21 +14669,21 @@ }, { "name": "io_range", - "type": "379" + "type": "381" }, { "name": "memory_range", - "type": "379" + "type": "381" }, { "name": "prefetchable_range", - "type": "379" + "type": "381" } ], "meta-type": "object" }, { - "name": "371", + "name": "373", "members": [ { "name": "path", @@ -14538,7 +14699,7 @@ "meta-type": "object" }, { - "name": "372", + "name": "374", "meta-type": "enum", "values": [ "unmapped", @@ -14674,13 +14835,13 @@ ] }, { - "name": "373", + "name": "375", "members": [ ], "meta-type": "object" }, { - "name": "374", + "name": "376", "meta-type": "enum", "values": [ "left", @@ -14693,7 +14854,7 @@ ] }, { - "name": "375", + "name": "377", "meta-type": "enum", "values": [ "x", @@ -14701,7 +14862,7 @@ ] }, { - "name": "376", + "name": "378", "members": [ { "name": "compat", @@ -14725,7 +14886,7 @@ "meta-type": "object" }, { - "name": "377", + "name": "379", "members": [ { "name": "create-type", @@ -14741,34 +14902,34 @@ }, { "name": "extents", - "type": "[249]" + "type": "[252]" } ], "meta-type": "object" }, { - "name": "378", + "name": "380", "members": [ { "name": "cipher-alg", - "type": "380" + "type": "382" }, { "name": "cipher-mode", - "type": "381" + "type": "383" }, { "name": "ivgen-alg", - "type": "382" + "type": "384" }, { "name": "ivgen-hash-alg", "default": null, - "type": "383" + "type": "385" }, { "name": "hash-alg", - "type": "383" + "type": "385" }, { "name": "payload-offset", @@ -14784,13 +14945,13 @@ }, { "name": "slots", - "type": "[384]" + "type": "[386]" } ], "meta-type": "object" }, { - "name": "379", + "name": "381", "members": [ { "name": "base", @@ -14804,12 +14965,12 @@ "meta-type": "object" }, { - "name": "[249]", - "element-type": "249", + "name": "[252]", + "element-type": "252", "meta-type": "array" }, { - "name": "380", + "name": "382", "meta-type": "enum", "values": [ "aes-128", @@ -14827,7 +14988,7 @@ ] }, { - "name": "381", + "name": "383", "meta-type": "enum", "values": [ "ecb", @@ -14837,7 +14998,7 @@ ] }, { - "name": "382", + "name": "384", "meta-type": "enum", "values": [ "plain", @@ -14846,7 +15007,7 @@ ] }, { - "name": "383", + "name": "385", "meta-type": "enum", "values": [ "md5", @@ -14859,12 +15020,12 @@ ] }, { - "name": "[384]", - "element-type": "384", + "name": "[386]", + "element-type": "386", "meta-type": "array" }, { - "name": "384", + "name": "386", "members": [ { "name": "active", diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml index 6386c4ed0d..d238078af9 100644 --- a/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml @@ -203,13 +203,14 @@ <flag name='query-cpu-model-expansion'/> <flag name='virtio-net.host_mtu'/> <flag name='spice-rendernode'/> + <flag name='nvdimm'/> <flag name='pcie-root-port'/> <flag name='query-cpu-definitions'/> <flag name='block-write-threshold'/> <flag name='query-named-block-nodes'/> - <version>2008090</version> + <version>2009000</version> <kvmVersion>0</kvmVersion> - <package> (v2.9.0-rc0-142-g940a8ce)</package> + <package> (v2.9.0)</package> <arch>x86_64</arch> <hostCPU type='kvm' model='base' migratability='yes'> <property name='phys-bits' type='number' value='0'/> -- 2.12.2

2 1

[libvirt] [PATCH v2 00/11]
by John Ferlan 26 Apr '17

26 Apr '17

v1: https://www.redhat.com/archives/libvir-list/2017-April/msg01051.html Changes since v1: - Patches 1, 2, 4, and 14 were pushed since they were ACK and "separable" - Former patch 3 is now patch 1 -> Restore the comments for the functions. - Former patch 5 is now split into patch 2 and 3 -> Patch 2 addresses the "if (!obj)" check in virSecretObjListRemove -> Patch 3 handles the naming of the variables - Former patch 6 is now patch 4 -> Alterations here are not creating a @def for the express purpose of only dereferencing obj->def if that's all that's used. If though there is an obj->def->X, then the @def is created - Former patch 7 is removed (e.g. keep virSecretObjListGetUUIDs where it was). A battle for a different day perhaps. - Former patch 8 is now patches 5 and 6 -> Patch 5 handles just the cleanup path for virSecretObjListGetUUIDs -> Patch 6 changes the variable names - Former patch 9 is now patches 7 and 8 -> Patch 7 focuses only on changing the name of @filter to @aclfilter (something that wasn't called out specifically in the initial review but that I figured I'd do anyway) -> Patch 8 does the split and keeps the Callback functions together so it doesn't appear that virSecretObjListNumOfSecrets moved. Again I'll pick that battle another day. I did change the name of the structures to include "virSecret" prefix though. - Former patch 10 is now patch 9 -> This was ACK'd but not "easy" to extract out, so nothing to do here. - Former patch 11 is now patch 10 -> Perhaps merge conflicts were changed here. The algorithm hasn't changed though. - Former patch 12 is now patch 11 -> This was ACKd already - just forgot to extract it out for a push. - Former patch 13 is removed So I've tried to go with the spirit of the review even though I disagree with the don't do the code motion part. I'll deal with that later when things really converge and the functions are shorter. John Ferlan (11): secret: Make some virSecretObj* functions static secret: Add NULL obj check to virSecretObjListRemove secret: Use consistent naming for variables secret: Use virSecretDefPtr rather than deref from virSecretObjPtr secret: Alter cleanup path for virSecretObjListGetUUIDs secret: Change variable names for list traversals secret: Rename 'filter' to 'aclfilter' secret: Split apart NumOfSecrets and GetUUIDs callback function secret: Combine virSecretObjListAdd with Locked function secret: Alter FindByUUID to expect the formatted uuidstr secret: Generate configDir during driver initialization src/conf/virsecretobj.c | 428 ++++++++++++++++++++++++--------------------- src/conf/virsecretobj.h | 54 ++---- src/secret/secret_driver.c | 170 +++++++++--------- 3 files changed, 328 insertions(+), 324 deletions(-) -- 2.9.3

2 16

[libvirt] [PATCH] IPv6 route check: list devices only once
by Cédric Bosdonnat 26 Apr '17

26 Apr '17

If several RA routes are found for the same device, only list that device once in the error message. --- src/util/virnetdevip.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/util/virnetdevip.c b/src/util/virnetdevip.c index 09925e1d7..bf98ed8a5 100644 --- a/src/util/virnetdevip.c +++ b/src/util/virnetdevip.c @@ -551,6 +551,8 @@ virNetDevIPCheckIPv6ForwardingCallback(const struct nlmsghdr *resp, int ret = 0; int len = RTM_PAYLOAD(resp); int oif = -1; + size_t i; + bool hasDevice; /* Ignore messages other than route ones */ if (resp->nlmsg_type != RTM_NEWROUTE) @@ -587,7 +589,13 @@ virNetDevIPCheckIPv6ForwardingCallback(const struct nlmsghdr *resp, accept_ra = virNetDevIPGetAcceptRA(ifname); VIR_DEBUG("Checking route for device %s, accept_ra: %d", ifname, accept_ra); - if (accept_ra != 2 && VIR_APPEND_ELEMENT(data->devices, data->ndevices, ifname) < 0) + hasDevice = false; + for (i = 0; i < data->ndevices && !hasDevice; i++) { + if (STREQ(data->devices[i], ifname)) + hasDevice = true; + } + if (accept_ra != 2 && !hasDevice && + VIR_APPEND_ELEMENT(data->devices, data->ndevices, ifname) < 0) goto error; cleanup: -- 2.12.2

2 1

[libvirt] Plans for next release
by Daniel Veillard 26 Apr '17

26 Apr '17

I didn't realized that end of month was getting that close. So I suggest to enter freeze for 3.3.0 on Friday. I can then push an RC2 on Monday evening or Tuesday and push the release Wed or Thursday, I hope that works for everybody, there is roughtly 2 days to push patches you want in (except bug fixes of course :) thanks, Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] [RFC] Adopting 'Tested-by' tag (and probably other tags)?
by Kashyap Chamarthy 26 Apr '17

26 Apr '17

Hi folks, I was wondering if the upstream would be receptive to adding a 'Tested-by' tag for patches that had someone give tested feedback on the list. Personally, what I consider a bar for giving a 'Tested-by' is, when someone: - Applies a patch or a series (following the iterations as needed, over time) locally, compile them, spend time understanding the functional change in question, and its implications.) - Do a concrete test (w/ either a Python API or a `virsh`-based command-line) that exercises the said code path. - *Post* the above test procedure / and necessary outputs as evidence to the list, in reasonable detail. (Not a: "yeah, I tested and it works" -- this isn't a 'rule'; it can have exceptions) >From a quick glance, in its 10-year history, libvirt upstream had about a mere 21 entries of 'Tested-by' tags: $ git log | grep Tested-by | wc -l 21 I bring this up because, when someone spends effort following (sometimes over weeks / months) a patch (or a series) from the list, gives reasonably detailed test feedback, in my books, it would be fair to acknowledge it in the Git. And it will encourage them to spend time in future. --- I realize that if it's not automated (via Git hooks or similar), it can become "lossy", i.e. if Joe posts v1 of a patch, you give a 'Tested-by', then there are two scenarios that immediately spring to mind: (1) Joe respins a v2 to make some corrections, adds your 'Tested-by' tag, and whoever applies the patch picks it up -- all good. (b) However, if a v2 was _not_ necessary, then whoever is applying the patch / series must remember to add the tag -- "lossy". Thoughts / remarks / rotten tomatoes welcome. -- /kashyap

5 9

[libvirt] [PATCH v2 00/10] Add mdev reporting capability to the nodedev driver
by Erik Skultety 26 Apr '17

26 Apr '17

since v1: - dropped the <description> element from the parent device nested capability - added missing RNG schema and tests - updated the documentation to describe the MDEV elements in both the parent and the child So, regarding the discussion about the presence of <description> element in the device XML, I dropped it for v2. There were points that we could continue debating about, but one of the major points against it is that libvirt should understand the information it's gathering and then exposing it in a structured way, which in this case wasn't the case, which wouldn't make the management layer's job any easier in any way, since they'd have to parse it either way (from libvirt or on their own). So, until this is resolved among vendors so that we can apply some kind of device classification (no userspace DB), management will have to simply read the description directly from sysfs. As part of a private discussion, another interesting point has been raised - virsh nodedev-list does support '--cap' option which filters only devices matching the pattern. However, with SRIOV, NPIV, and MDEV we have nested capabilities which are kept private and cannot be filtered by. That might be a nice feature for users: 1) OK, let's see what MDEVs are there on the host virsh nodedev-list --cap="mdev-<child|whatever>" 2) I'd like to create some on my own, so which physical devices do support MDEV? virsh nodedev-list --cap='mdev-<parent|whatever>' 3) create the device on that physical device The same goes for SRIOV, where we have virt_functions in parent and phys_function in child and NPIV (I don't remember what it was here), I didn't check in depth, but I think it should be possible for us to do and it's a valid use case where users don't have to parse dumpxml's output for information about the parent's nested capabilities. Erik Erik Skultety (10): nodedev: Make use of the compile-time missing enum in switch error conf: nodedev: Split virNodeDeviceDefFormat into more functions nodedev: udevProcessPCI: Drop syspath variable docs: Utilize our XSLT list generating template more nodedev: conf: Split PCI sub-capability parsing to a separate method nodedev: Introduce the mdev capability to the nodedev driver structure nodedev: Introduce the mdev capability to a PCI parent device nodedev: Introduce mdev capability for child devices docs: Provide a nodedev driver stub documentation docs: Document the mediated devices within the nodedev driver docs/drivers.html.in | 6 +- docs/drvnodedev.html.in | 344 +++++++++ docs/remote.html.in | 106 +-- docs/schemas/nodedev.rng | 41 ++ docs/storage.html.in | 62 +- include/libvirt/libvirt-nodedev.h | 1 + src/conf/node_device_conf.c | 812 +++++++++++++-------- src/conf/node_device_conf.h | 21 +- src/conf/virnodedeviceobj.c | 3 +- src/libvirt-nodedev.c | 1 + src/libvirt_private.syms | 1 + src/node_device/node_device_driver.c | 1 + src/node_device/node_device_udev.c | 242 +++++- .../mdev_3627463d_b7f0_4fea_b468_f1da537d301b.xml | 8 + tests/nodedevschemadata/pci_0000_02_10_7_mdev.xml | 27 + tests/nodedevxml2xmltest.c | 1 + tools/virsh-nodedev.c | 2 + 17 files changed, 1223 insertions(+), 456 deletions(-) create mode 100644 docs/drvnodedev.html.in create mode 100644 tests/nodedevschemadata/mdev_3627463d_b7f0_4fea_b468_f1da537d301b.xml create mode 100644 tests/nodedevschemadata/pci_0000_02_10_7_mdev.xml -- 2.12.2

3 23

Re: [libvirt] How to get VM memory usage
by Eric Blake 26 Apr '17

26 Apr '17

[moderator note: I'm forwarding a stripped down version of the original mail which was rejected in the moderator queue. I stripped the .jpg attachments, which are inappropriate for a technical list. Either paste the text contents (rather than a screenshot) of the window you are describing, or host your images elsewhere and have your list email merely give a URL of the externally-hosted images] > ForwardedMessage.eml > > Subject: > Re: Re: [libvirt] How to get VM memory usage > From: > "wangyufeng(a)cloudguarding.com" <wangyufeng(a)cloudguarding.com> > Date: > 04/26/2017 01:21 AM > > To: > "Daniel P. Berrange" <berrange(a)redhat.com> > CC: > libvir-list <libvir-list(a)redhat.com> > > > Hi Daniel, > > I found method MemoryStats in domain.go: > func (d *Domain) MemoryStats(nrStats uint32, flags uint32) ([]DomainMemoryStat, error) { > ptr := make([]C.virDomainMemoryStatStruct, nrStats) > > result := C.virDomainMemoryStats( > d.ptr, (C.virDomainMemoryStatPtr)(unsafe.Pointer(&ptr[0])), > C.uint(nrStats), C.uint(flags)) > > if result == -1 { > return []DomainMemoryStat{}, GetLastError() > } > > out := make([]DomainMemoryStat, result) > for i := 0; i < int(result); i++ { > out = append(out, DomainMemoryStat{ > Tag: int32(ptr[i].tag), > Val: uint64(ptr[i].val), > }) > } > return out, nil > } > > Do you mean this method can get used memory info? > While I invoke the method, which can only get values of tag 0 and tag 6: > > And the balloon driver have been activated on the monitored vm: > > Below is my code, could you tell me what's wrong with my code? > > Thank you very much. > > ---------------------------------------------------------------------------------------------------------- > On Fri, Apr 21, 2017 at 09:58:12AM +0800, wangyufeng(a)cloudguarding.com wrote: >> Hi Daniel, >> >> In method 'GetInfo', we can only get memory and max memory. However I >> need to get used memory for calculating memory usage. The virsh command >> 'dommemstat' can obtain used memory, is there a method in libvirt-go to >> obtain used memory? > > That command uses the virDomainMemoryStats() API call > > > Regards, > Daniel > -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange > :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: > https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org

1 0

[libvirt] [PATCH v3 0/5] Alter the clearing of device for new partition table
by John Ferlan 26 Apr '17

26 Apr '17

Well kind of a v2/v3 type mashup - essentially reworked the portion of the series: https://www.redhat.com/archives/libvir-list/2017-April/msg00402.html that dealt with the zeroing of the header of the device path. The changes now will allow both the head and tail of the device path to be cleared rather than just the header of the file which was ACK'd for at least the logical backend. Additionally, bump the size of the clear/zero from 2048KB to 1MB and use it for both the logical and disk backends. John Ferlan (5): storage: Modify storageBackendWipeLocal to allow zero from end of device storage: Introduce virStorageBackendZeroPartitionTable logical: Use virStorageBackendZeroPartitionTable logical: Increase the size of the data to wipe disk: Use virStorageBackendZeroPartitionTable src/storage/storage_backend_disk.c | 6 ++- src/storage/storage_backend_logical.c | 44 +--------------------- src/storage/storage_util.c | 70 ++++++++++++++++++++++++++++------- src/storage/storage_util.h | 4 ++ 4 files changed, 67 insertions(+), 57 deletions(-) -- 2.9.3

2 10

[libvirt] [PATCH] Update keycodemapdb submodule for python2 compat fixes
by Daniel P. Berrange 26 Apr '17

26 Apr '17

There were a few bugs in keycodemap tool that broke it when run on python circa 2.7.5 or older, which affected RHEL builds. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- Pushed as a CI build fix for rhel6/7 src/keycodemapdb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/keycodemapdb b/src/keycodemapdb index bd754b8..7bf5710 160000 --- a/src/keycodemapdb +++ b/src/keycodemapdb @@ -1 +1 @@ -Subproject commit bd754b861e7de5c7919aa249a975913cb207b85d +Subproject commit 7bf5710b22aa8d58b7eeaaf3dc6960c26cade4f0 -- 2.9.3

1 0

[libvirt] [PATCH v2 00/13] Multiple cleanups within nwfilterobj and nwfilter drivers
by John Ferlan 26 Apr '17

26 Apr '17

v1: https://www.redhat.com/archives/libvir-list/2017-April/msg01074.html Changes since v1: * Patch 2 -> Do not add the local @def when just dereference obj->def * Patch 13 & 15 dropped Most patches were ACK'd, but patch 2's impact was felt in a few other patches so I just resent the whole thing. In particular patch 5 for nwfilterUndefine and nwfilterGetXMLDesc as well as patch 7 for the _virNWFilterObjListDefLoopDetect call w/ _virNWFilterObjListDefLoopDetect John Ferlan (13): nwfilter: Use consistent naming for variables nwfilter: Use virNWFilterDefPtr rather than deref virNWFilterObjPtr nwfilter: Remove unused 'active' in virNWFilterObj nwfilter: Convert wantRemoved to bool nwfilter: Make _virNWFilterObjPtr private nwfilter: Introduce virNWFilterObjNew nwfilter: Rename some virNWFilterObj* API's nwfilter: Make _virNWFilterObjList private nwfilter: Make a common UUID lookup function from driver nwfilter: Replace virNWFilterConfigFile with virFileBuildPath nwfilter: Replace virNWFilterSaveDef with virNWFilterSaveConfig nwfilter: Move creation of configDir to driver initialization nwfilter: Move save of config until after successful assign src/conf/nwfilter_conf.c | 57 +------ src/conf/nwfilter_conf.h | 8 - src/conf/virnwfilterobj.c | 270 +++++++++++++++++++++------------ src/conf/virnwfilterobj.h | 70 ++++----- src/libvirt_private.syms | 20 ++- src/nwfilter/nwfilter_driver.c | 138 ++++++++++------- src/nwfilter/nwfilter_gentech_driver.c | 42 ++--- 7 files changed, 320 insertions(+), 285 deletions(-) -- 2.9.3 FWIW: The diffs between this series and the previous taking away patches 13/15: diff --git a/src/conf/virnwfilterobj.c b/src/conf/virnwfilterobj.c index 62206b8..8c9da13 100644 --- a/src/conf/virnwfilterobj.c +++ b/src/conf/virnwfilterobj.c @@ -92,16 +92,11 @@ virNWFilterObjWantRemoved(virNWFilterObjPtr obj) static void virNWFilterObjFree(virNWFilterObjPtr obj) { - virNWFilterDefPtr def; - virNWFilterDefPtr newDef; - if (!obj) return; - def = obj->def; - newDef = obj->newDef; - virNWFilterDefFree(def); - virNWFilterDefFree(newDef); + virNWFilterDefFree(obj->def); + virNWFilterDefFree(obj->newDef); virMutexDestroy(&obj->lock); @@ -204,7 +199,6 @@ _virNWFilterObjListDefLoopDetect(virNWFilterObjListPtr nwfilters, size_t i; virNWFilterEntryPtr entry; virNWFilterObjPtr obj; - virNWFilterDefPtr objdef; if (!def) return 0; @@ -221,8 +215,7 @@ _virNWFilterObjListDefLoopDetect(virNWFilterObjListPtr nwfilters, obj = virNWFilterObjListFindByName(nwfilters, entry->include->filterref); if (obj) { - objdef = obj->def; - rc = _virNWFilterObjListDefLoopDetect(nwfilters, objdef, + rc = _virNWFilterObjListDefLoopDetect(nwfilters, obj->def, filtername); virNWFilterObjUnlock(obj); if (rc < 0) @@ -386,13 +379,11 @@ virNWFilterObjListNumOfNWFilters(virNWFilterObjListPtr nwfilters, { size_t i; int nfilters = 0; - virNWFilterDefPtr def; for (i = 0; i < nwfilters->count; i++) { virNWFilterObjPtr obj = nwfilters->objs[i]; virNWFilterObjLock(obj); - def = obj->def; - if (!aclfilter || aclfilter(conn, def)) + if (!aclfilter || aclfilter(conn, obj->def)) nfilters++; virNWFilterObjUnlock(obj); }

2 14

[libvirt] Unbounded client streams
by Michal Privoznik 26 Apr '17

26 Apr '17

Dear list, as you might have seen, I've been playing with our streams lately. One of the things I wanted to try was how my sparse streams deal with vol-download and slow writer (e.g. slow disk). Note to whomever wants to try that out: blkio,throttle.write_* is no good for this. So I went the old way: diff --git i/tools/virsh-util.c w/tools/virsh-util.c index 4b86e29..8f5738d 100644 --- i/tools/virsh-util.c +++ w/tools/virsh-util.c @@ -149,6 +149,8 @@ virshStreamSink(virStreamPtr st ATTRIBUTE_UNUSED, { int *fd = opaque; + sleep(60); + return safewrite(*fd, bytes, nbytes); } And found out something ugly: the memory footprint of virsh just keeps growing as vol-download progresses. I've tracked down the problem to: 1) The client event loop (virNetClientIOEventLoop) sees some incoming data, so it reads it (virNetClientIOHandleInput -> virNetClientCallDispatch) and queues the packet (virNetClientCallDispatchStream) regardless of the length of already queued packets 2) Since the server sees client has read all the data, it sends even more data. And the queue in step 1) just grows and grows. Ideally, the packets are taken out from the queue by virStreamRecv (which boils down to virNetClientStreamRecvPacket), but that is not on the schedule for the next minute. Frankly, I don't have any idea how to fix this. We can stop reading the data (i.e. not set POLLIN on the client <-> server socket) if the queue reaches certain length. BUT, this would mean no other call is processed. Not even keepalive - and the connection would break. The other option is to pretend I've never send this e-mail and you've read nothing O:-) Michal

4 9

[libvirt] [PATCHv2 0/6] Support more options for intel-iommu
by Ján Tomko 26 Apr '17

26 Apr '17

For https://bugzilla.redhat.com/show_bug.cgi?id=1427005 v2: * use != VIR_TRISTATE_SWITCH_ABSENT more often * use symlinks for identical XMLs * move capability checks in qemuBuildIOMMUCommandLine to the beginning, to be shared with qemuBuildIOMMUCommandLine Documentation changes reflecting current QEMU implementation limits are not included. Ján Tomko (6): conf: add <irqchip mode> to <features> qemu: format kernel_irqchip on the command line conf: add <driver intremap> to <iommu> qemu: format intremap= on intel-iommu command line conf: add caching attribute to iommu device qemu: format caching-mode on iommu command line docs/formatdomain.html.in | 41 +++++++++- docs/schemas/domaincommon.rng | 30 ++++++++ src/conf/domain_conf.c | 90 ++++++++++++++++++++-- src/conf/domain_conf.h | 14 ++++ src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 12 +++ src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_command.c | 40 ++++++++++ tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_2.4.0.x86_64.replies | 22 ++++-- tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_2.5.0.x86_64.replies | 24 ++++-- tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 1 + .../caps_2.6.0-gicv2.aarch64.xml | 1 + .../caps_2.6.0-gicv3.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml | 1 + .../qemucapabilitiesdata/caps_2.6.0.x86_64.replies | 24 ++++-- tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml | 1 + .../qemucapabilitiesdata/caps_2.7.0.x86_64.replies | 28 +++++-- tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 1 + .../qemucapabilitiesdata/caps_2.8.0.x86_64.replies | 37 +++++++-- tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 2 + .../qemucapabilitiesdata/caps_2.9.0.x86_64.replies | 49 +++++++++--- tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 3 + .../qemuxml2argv-intel-iommu-caching.args | 19 +++++ .../qemuxml2argv-intel-iommu-caching.xml | 28 +++++++ .../qemuxml2argv-intel-iommu-irqchip.args | 19 +++++ .../qemuxml2argv-intel-iommu-irqchip.xml | 31 ++++++++ tests/qemuxml2argvtest.c | 10 +++ .../qemuxml2xmlout-intel-iommu-caching.xml | 1 + .../qemuxml2xmlout-intel-iommu-irqchip.xml | 1 + tests/qemuxml2xmltest.c | 2 + 37 files changed, 496 insertions(+), 49 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-intel-iommu-caching.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-intel-iommu-caching.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-intel-iommu-irqchip.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-intel-iommu-irqchip.xml create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-intel-iommu-caching.xml create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-intel-iommu-irqchip.xml -- 2.10.2

2 14

[libvirt] [PATCH] Support CPU less NUMA node.
by Shaohe Feng 26 Apr '17

26 Apr '17

Some platform NUMA node does not include cpu, such as Phi. This patch support CPU less NUMA node. But there must be one CPU cell node for a guest. Also must assign the host nodeset for this guest cell node. please enable numactl with "--with-numactl" for libvirt config. Test this patch: 1. define a numa cell without "cpus", such as cell 1. <numatune> <memnode cellid='1' mode='strict' nodeset='0'/> </numatune> <cpu> <numa> <cell id='0' cpus='0-1' memory='512000' unit='KiB'/> <cell id='1' memory='512000' unit='KiB'/> </numa> </cpu> libvirt can edit and start the VM successfully. 2. define a numa cell without "cpus", without nodeset. <cpu> <numa> <cell id='0' cpus='0-1' memory='512000' unit='KiB'/> <cell id='1' memory='512000' unit='KiB'/> </numa> </cpu> This case, libvirt will failed to edit the CPUS. --- src/conf/domain_conf.c | 4 +++ src/conf/numa_conf.c | 89 ++++++++++++++++++++++++++++++++++--------------- src/conf/numa_conf.h | 2 ++ src/qemu/qemu_command.c | 12 ++++--- src/util/virbitmap.c | 10 ++++-- 5 files changed, 83 insertions(+), 34 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 705deb3..d6e5489 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -17330,6 +17330,10 @@ virDomainDefParseXML(xmlDocPtr xml, ctxt) < 0) goto error; + if (virDomainNumaCPULessCheck(def->numa) < 0){ + goto error; + } + if (virDomainNumatuneHasPlacementAuto(def->numa) && !def->cpumask && !virDomainDefHasVcpuPin(def) && !def->cputune.emulatorpin && diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c index bfd3703..1b6f7ff 100644 --- a/src/conf/numa_conf.c +++ b/src/conf/numa_conf.c @@ -742,34 +742,31 @@ virDomainNumaDefCPUParseXML(virDomainNumaPtr def, goto cleanup; } - if (!(tmp = virXMLPropString(nodes[i], "cpus"))) { - virReportError(VIR_ERR_XML_ERROR, "%s", - _("Missing 'cpus' attribute in NUMA cell")); - goto cleanup; - } - - if (virBitmapParse(tmp, &def->mem_nodes[cur_cell].cpumask, - VIR_DOMAIN_CPUMASK_LEN) < 0) - goto cleanup; - - if (virBitmapIsAllClear(def->mem_nodes[cur_cell].cpumask)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("NUMA cell %d has no vCPUs assigned"), cur_cell); - goto cleanup; - } - VIR_FREE(tmp); - - for (j = 0; j < n; j++) { - if (j == cur_cell || !def->mem_nodes[j].cpumask) - continue; + tmp = virXMLPropString(nodes[i], "cpus"); + if (tmp) { + if (virBitmapParse(tmp, &def->mem_nodes[cur_cell].cpumask, + VIR_DOMAIN_CPUMASK_LEN) < 0) + goto cleanup; - if (virBitmapOverlaps(def->mem_nodes[j].cpumask, - def->mem_nodes[cur_cell].cpumask)) { + if (virBitmapIsAllClear(def->mem_nodes[cur_cell].cpumask)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("NUMA cells %u and %zu have overlapping vCPU ids"), - cur_cell, j); + _("NUMA cell %d has no vCPUs assigned"), cur_cell); goto cleanup; } + VIR_FREE(tmp); + + for (j = 0; j < n; j++) { + if (j == cur_cell || !def->mem_nodes[j].cpumask) + continue; + + if (virBitmapOverlaps(def->mem_nodes[j].cpumask, + def->mem_nodes[cur_cell].cpumask)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("NUMA cells %u and %zu have overlapping vCPU ids"), + cur_cell, j); + goto cleanup; + } + } } ctxt->node = nodes[i]; @@ -808,6 +805,7 @@ virDomainNumaDefCPUFormat(virBufferPtr buf, char *cpustr; size_t ncells = virDomainNumaGetNodeCount(def); size_t i; + size_t ncpuless = 0; if (ncells == 0) return 0; @@ -817,12 +815,24 @@ virDomainNumaDefCPUFormat(virBufferPtr buf, for (i = 0; i < ncells; i++) { memAccess = virDomainNumaGetNodeMemoryAccessMode(def, i); - if (!(cpustr = virBitmapFormat(virDomainNumaGetNodeCpumask(def, i)))) - return -1; + cpustr = virBitmapFormat(virDomainNumaGetNodeCpumask(def, i)); virBufferAddLit(buf, "<cell"); virBufferAsprintf(buf, " id='%zu'", i); - virBufferAsprintf(buf, " cpus='%s'", cpustr); + if (cpustr && (*cpustr != 0)) + virBufferAsprintf(buf, " cpus='%s'", cpustr); + else { + /* Note, at present we only allow cpuless numa node with */ + /* nodeset assign. */ + ncpuless++; + if (!virDomainNumatuneNodeSpecified(def, i)) { + VIR_FREE(cpustr); + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("CPUless NUMA node cellid %zu must be " + "specified node set."), i); + return -1; + } + } virBufferAsprintf(buf, " memory='%llu'", virDomainNumaGetNodeMemorySize(def, i)); virBufferAddLit(buf, " unit='KiB'"); @@ -835,6 +845,12 @@ virDomainNumaDefCPUFormat(virBufferPtr buf, virBufferAdjustIndent(buf, -2); virBufferAddLit(buf, "</numa>\n"); + if (ncpuless == ncells) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("At lease one NUMA node should " + "include CPU element.")); + return -1; + } return 0; } @@ -861,6 +877,7 @@ virDomainNumaGetMaxCPUID(virDomainNumaPtr numa) int bit; bit = virBitmapLastSetBit(virDomainNumaGetNodeCpumask(numa, i)); + bit = (bit > 0) ? bit : 0; if (bit > ret) ret = bit; } @@ -973,3 +990,21 @@ virDomainNumaGetMemorySize(virDomainNumaPtr numa) return ret; } + +// NOTE, For some plateforms, there are some node without cpus, such as Phi. +// We just need do some check for these plateforms, we must assigned nodeset +// for CPU less node. +int +virDomainNumaCPULessCheck(virDomainNumaPtr numa) +{ + int ret = 0; + int i = 0; + for (i = 0; i < numa->nmem_nodes; i++){ + if (!numa->mem_nodes[i].cpumask && !numa->mem_nodes[i].nodeset) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Cell: %d is a cpuless numa, must specfiy the nodeset."), i); + return -1; + } + } + return ret; +} diff --git a/src/conf/numa_conf.h b/src/conf/numa_conf.h index b6a5354..1f711e6 100644 --- a/src/conf/numa_conf.h +++ b/src/conf/numa_conf.h @@ -155,5 +155,7 @@ int virDomainNumaDefCPUFormat(virBufferPtr buf, virDomainNumaPtr def); unsigned int virDomainNumaGetCPUCountTotal(virDomainNumaPtr numa); +int virDomainNumaCPULessCheck(virDomainNumaPtr numa); + #endif /* __NUMA_CONF_H__ */ diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index b2e76ca..b07ca66 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -7665,11 +7665,13 @@ qemuBuildNumaArgStr(virQEMUDriverConfigPtr cfg, virCommandAddArg(cmd, "-numa"); virBufferAsprintf(&buf, "node,nodeid=%zu", i); - for (tmpmask = cpumask; tmpmask; tmpmask = next) { - if ((next = strchr(tmpmask, ','))) - *(next++) = '\0'; - virBufferAddLit(&buf, ",cpus="); - virBufferAdd(&buf, tmpmask, -1); + if (*cpumask != 0) { + for (tmpmask = cpumask; tmpmask; tmpmask = next) { + if ((next = strchr(tmpmask, ','))) + *(next++) = '\0'; + virBufferAddLit(&buf, ",cpus="); + virBufferAdd(&buf, tmpmask, -1); + } } if (needBackend) diff --git a/src/util/virbitmap.c b/src/util/virbitmap.c index eac63d9..b2803ce 100644 --- a/src/util/virbitmap.c +++ b/src/util/virbitmap.c @@ -953,6 +953,9 @@ virBitmapLastSetBit(virBitmapPtr bitmap) unsigned long bits; /* If bitmap is empty then there is no set bit */ + if (!bitmap) + return -1; + if (bitmap->map_len == 0) return -1; @@ -1039,9 +1042,12 @@ virBitmapCountBits(virBitmapPtr bitmap) size_t i; size_t ret = 0; - for (i = 0; i < bitmap->map_len; i++) - ret += count_one_bits_l(bitmap->map[i]); + if (bitmap == NULL) + return ret; + for (i = 0; i < bitmap->map_len; i++) { + ret += count_one_bits_l(bitmap->map[i]); + } return ret; } -- 2.7.4

3 4

[libvirt] [PATCH] virsh-domain: update attach-interface to support bridge type
by ZhiPeng Lu 26 Apr '17

26 Apr '17

Adding this feature will allow users to attach a network to linux bridge or openvswitch. The interface can be attached using --brtype=linux or --brtype=openvswitch. If --brtype is not set, the network is attached to linux bridge. Signed-off-by: ZhiPeng Lu <lu.zhipeng(a)zte.com.cn> --- tools/virsh-domain.c | 23 +++++++++++++++++++++-- tools/virsh.pod | 3 +++ 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index db8accf..2690689 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -766,6 +766,10 @@ static const vshCmdOptDef opts_attach_interface[] = { .type = VSH_OT_BOOL, .help = N_("libvirt will automatically detach/attach the device from/to host") }, + {.name = "brtype", + .type = VSH_OT_STRING, + .help = N_("Bridge type: linux / openvswitch") + }, {.name = NULL} }; @@ -819,7 +823,8 @@ cmdAttachInterface(vshControl *ctl, const vshCmd *cmd) virDomainPtr dom = NULL; const char *mac = NULL, *target = NULL, *script = NULL, *type = NULL, *source = NULL, *model = NULL, - *inboundStr = NULL, *outboundStr = NULL; + *inboundStr = NULL, *outboundStr = NULL, + *brtype = NULL; virNetDevBandwidthRate inbound, outbound; virDomainNetType typ; int ret; @@ -850,7 +855,8 @@ cmdAttachInterface(vshControl *ctl, const vshCmd *cmd) vshCommandOptStringReq(ctl, cmd, "script", &script) < 0 || vshCommandOptStringReq(ctl, cmd, "model", &model) < 0 || vshCommandOptStringReq(ctl, cmd, "inbound", &inboundStr) < 0 || - vshCommandOptStringReq(ctl, cmd, "outbound", &outboundStr) < 0) + vshCommandOptStringReq(ctl, cmd, "outbound", &outboundStr) < 0 || + vshCommandOptStringReq(ctl, cmd, "brtype", &brtype) < 0) goto cleanup; /* check interface type */ @@ -946,6 +952,19 @@ cmdAttachInterface(vshControl *ctl, const vshCmd *cmd) if (model != NULL) virBufferAsprintf(&buf, "<model type='%s'/>\n", model); + if ((brtype != NULL)) { + if (STRNEQ(brtype , "linux") && STRNEQ(brtype , "openvswitch")) { + vshError(ctl, _("bridge type is incorrect, should be linux " + "or openvswitch")); + goto cleanup; + } + if (typ != VIR_DOMAIN_NET_TYPE_BRIDGE) { + vshError(ctl, _("No support for %s with bridge type"), type); + goto cleanup; + } + if (STREQ(brtype , "openvswitch")) + virBufferAsprintf(&buf, " <virtualport type='openvswitch'/>\n"); + } if (inboundStr || outboundStr) { virBufferAddLit(&buf, "<bandwidth>\n"); virBufferAdjustIndent(&buf, 2); diff --git a/tools/virsh.pod b/tools/virsh.pod index e16f62f..3cd0490 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -2935,6 +2935,9 @@ B<--managed> is usable only for I<hostdev> type and tells libvirt that the interface should be managed, which means detached and reattached from/to the host by libvirt. +B<--brtype> is usable only for I<bridge> type and tells libvirt +that the interface attached to bridge type (linux bridge or openvswitch). + If B<--print-xml> is specified, then the XML of the interface that would be attached is printed instead. -- 1.8.3.1

2 1

[libvirt] [PATCH 00/15] Multiple cleanups within nwfilterobj and nwfilter drivers
by John Ferlan 25 Apr '17

25 Apr '17

More adjustments in preparation for having virobject code handle the bulk of the object management code. I know it's a lot of patches, but reducing the amount of change overall has the opposite effect of increasing the number patches to show the work flow. Should make the "next" steps easier to review, but a couple of these will be tedious. John Ferlan (15): nwfilter: Use consistent naming for variables nwfilter: Use virNWFilterDefPtr rather than deref virNWFilterObjPtr nwfilter: Remove unused 'active' in virNWFilterObj nwfilter: Convert wantRemoved to bool nwfilter: Make _virNWFilterObjPtr private nwfilter: Introduce virNWFilterObjNew nwfilter: Rename some virNWFilterObj* API's nwfilter: Make _virNWFilterObjList private nwfilter: Make a common UUID lookup function from driver nwfilter: Replace virNWFilterConfigFile with virFileBuildPath nwfilter: Replace virNWFilterSaveDef with virNWFilterSaveConfig nwfilter: Move creation of configDir to driver initialization nwfilter: Move configFile name processing into driver nwfilter: Move save of config until after successful assign nwfilter: Move and rename virNWFilterSaveConfig src/conf/nwfilter_conf.c | 107 +----------- src/conf/nwfilter_conf.h | 16 +- src/conf/virnwfilterobj.c | 308 ++++++++++++++++++++++----------- src/conf/virnwfilterobj.h | 74 ++++---- src/libvirt_private.syms | 21 ++- src/nwfilter/nwfilter_driver.c | 148 ++++++++++------ src/nwfilter/nwfilter_gentech_driver.c | 42 +++-- 7 files changed, 377 insertions(+), 339 deletions(-) -- 2.9.3

2 33

[libvirt] [PATCH v3 0/2] Use the shared keycodemap database
by Daniel P. Berrange 25 Apr '17

25 Apr '17

Follow up to: v1: https://www.redhat.com/archives/libvir-list/2017-March/msg00070.html v2: https://www.redhat.com/archives/libvir-list/2017-March/msg00136.html Changed in v3: - Rebase onto new autogen.sh - Use VIR_KEYMAP_ENTRY_MAX constant more - Change style of make vars - Fix & verify distcheck Changed in v2: - Fixed make syntax-check errors - Auto-generate man pages listing value key codes for use with the virDomainSendKey API / virsh send-key command Daniel P. Berrange (2): util: switch over to use keycodemapdb GIT submodule Add ability to generate man page describing key code names & values .gitignore | 3 +- .gitmodules | 3 + libvirt.spec.in | 1 + mingw-libvirt.spec.in | 2 + src/Makefile.am | 86 ++++++-- src/keycodemapdb | 1 + src/util/keymaps.csv | 464 ------------------------------------------ src/util/virkeycode-mapgen.py | 97 --------- src/util/virkeycode.c | 94 ++++----- tests/virkeycodetest.c | 5 + tools/virsh.pod | 20 ++ 11 files changed, 153 insertions(+), 623 deletions(-) create mode 160000 src/keycodemapdb delete mode 100644 src/util/keymaps.csv delete mode 100755 src/util/virkeycode-mapgen.py -- 2.9.3

2 5

[libvirt] [PATCH 00/14] Multiple cleanups within secretobj and secret_driver
by John Ferlan 25 Apr '17

25 Apr '17

More adjustments in preparation for having virobject code handle the bulk of the object management code. I know it's a lot of patches, but most should be relatively simple - especially the first 10... The last 4 set up for a "common" way to handle the config directory space as well and could be a bit more controversial. Perhaps the most being patch 12 which attempts to perform the mkdir of the configDir during initialization rather than first "define" of secret. Although someone could also pick out their own most favorite/controversial and surprise me. John Ferlan (14): secret: Need to set data->error on VIR_ALLOC_N failure secret: Convert virsecretobjs.h to use "newer" formatting style secret: Make some virSecretObj* functions static secret: Have virSecretObjNew return locked object secret: Use consistent naming for variables secret: Use virSecretDefPtr rather than deref from virSecretObjPtr secret: Move virSecretObjListGetUUIDs secret: Change variable names for list traversals secret: Split apart NumOfSecrets and GetUUIDs callback function secret: Combine virSecretObjListAdd with Locked function secret: Alter FindByUUID to expect the formatted uuidstr secret: Generate configDir during driver initialization secret: Alter configFile/base64File mgmt secret: Clean up virSecretObjListExport logic src/conf/virsecretobj.c | 557 +++++++++++++++++++++++---------------------- src/conf/virsecretobj.h | 120 +++++----- src/secret/secret_driver.c | 178 ++++++++------- 3 files changed, 442 insertions(+), 413 deletions(-) -- 2.9.3

2 51

[libvirt] [PATCH v2 0/2] Augment debug messages.
by Prerna Saxena 25 Apr '17

25 Apr '17

This is a v2 of the previous set of debug enhancements posted at : https://www.redhat.com/archives/libvir-list/2017-March/msg00959.html Changelog: --------- 1) Patch 1/3 : virNetSocketGetFD() is reverted to its old state, and only new DEBUG messages are introduced. 2) Patch 2/3 : Dropped, per list suggestions. 3) Patch 3/3 : Same as v1 Prerna Saxena (2): Debug: Add DEBUG messages for when a client has opened/closed connection. Debug: Report VM errors more concisely. src/qemu/qemu_process.c | 4 ++-- src/rpc/virnetserverclient.c | 10 +++++++++- 2 files changed, 11 insertions(+), 3 deletions(-) -- 1.8.1.2

3 4

[libvirt] [PATCH v4 1/2] daemon: Fix domain name leak in error path
by Wang King 25 Apr '17

25 Apr '17

Domain name duplicated in make_nonnull_domain, but not freed when virTypedParamsSerialize return negative. --- daemon/remote.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/daemon/remote.c b/daemon/remote.c index 1610fea..a8c21fd 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -1066,8 +1066,10 @@ remoteRelayDomainEventTunable(virConnectPtr conn, if (virTypedParamsSerialize(params, nparams, (virTypedParameterRemotePtr *) &data.params.params_val, &data.params.params_len, - VIR_TYPED_PARAM_STRING_OKAY) < 0) + VIR_TYPED_PARAM_STRING_OKAY) < 0) { + VIR_FREE(data.dom.name); return -1; + } remoteDispatchObjectEventSend(callback->client, remoteProgram, REMOTE_PROC_DOMAIN_EVENT_CALLBACK_TUNABLE, @@ -1206,8 +1208,10 @@ remoteRelayDomainEventJobCompleted(virConnectPtr conn, if (virTypedParamsSerialize(params, nparams, (virTypedParameterRemotePtr *) &data.params.params_val, &data.params.params_len, - VIR_TYPED_PARAM_STRING_OKAY) < 0) + VIR_TYPED_PARAM_STRING_OKAY) < 0) { + VIR_FREE(data.dom.name); return -1; + } remoteDispatchObjectEventSend(callback->client, remoteProgram, REMOTE_PROC_DOMAIN_EVENT_CALLBACK_JOB_COMPLETED, -- 2.8.3

2 3

[libvirt] [PATCH] qemu: fix argument of virDomainNetGetActualDirectMode
by ZhiPeng Lu 25 Apr '17

25 Apr '17

it should be a comparison of modes between new and old devices. So the argument of the second virDomainNetGetActualDirectMode should be newdev. Signed-off-by: ZhiPeng Lu <lu.zhipeng(a)zte.com.cn> --- src/qemu/qemu_hotplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 120bcdc..eec99af 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -3273,7 +3273,7 @@ qemuDomainChangeNet(virQEMUDriverPtr driver, if (STRNEQ_NULLABLE(virDomainNetGetActualDirectDev(olddev), virDomainNetGetActualDirectDev(newdev)) || - virDomainNetGetActualDirectMode(olddev) != virDomainNetGetActualDirectMode(olddev) || + virDomainNetGetActualDirectMode(olddev) != virDomainNetGetActualDirectMode(newdev) || !virNetDevVPortProfileEqual(virDomainNetGetActualVirtPortProfile(olddev), virDomainNetGetActualVirtPortProfile(newdev)) || !virNetDevVlanEqual(virDomainNetGetActualVlan(olddev), -- 1.8.3.1

2 1

[libvirt] [PATCH v2] autogen.sh: Improve and generalize
by Andrea Bolognani 25 Apr '17

25 Apr '17

The goal is twofold: firstly, we want to extend the script so that it can deal with more than a single git submodule, and secondly we'd like to reduce the amount of duplicated code. Moreover, since we're making heavy changes to the code anyway, we might as well make sure it follows a somewhat consistent coding style too. To reduce code duplication, we introduce a new --dry-run option, which can be used by third parties to figure out whether calling autogen.sh is necessary or not: this allows us to get rid of the reimplementation of part of the logic in cfg.mk and guarantee they'll never get out of sync. Other changes include: making dirty submodules checking and cleaning entirely independent of other operations; removing the use of 'set -e' and handling errors explicitly instead; better parsing of command line arguments. --- Changes from [v1]: * drop the generic submodule update framework and simply update all submodules unconditionally, *then* perform any required gnulib-specific step; * handle "autogen not required" and "dry run error" differently in cfg.mk; * improve comments. [v1] https://www.redhat.com/archives/libvir-list/2017-April/msg00816.html autogen.sh | 253 ++++++++++++++++++++++++++++++++++++++++--------------------- cfg.mk | 53 ++++++------- 2 files changed, 193 insertions(+), 113 deletions(-) diff --git a/autogen.sh b/autogen.sh index d1c319d..d5d836a 100755 --- a/autogen.sh +++ b/autogen.sh @@ -1,117 +1,196 @@ #!/bin/sh # Run this to generate all the initial makefiles, etc. -set -e +die() +{ + echo "error: $1" >&2 + exit 1 +} -srcdir=`dirname "$0"` -test -z "$srcdir" && srcdir=. +starting_point=$(pwd) -THEDIR=`pwd` -cd "$srcdir" +srcdir=$(dirname "$0") +test "$srcdir" || srcdir=. -test -f src/libvirt.c || { - echo "You must run this script in the top-level libvirt directory" - exit 1 +cd "$srcdir" || { + die "Failed to cd into $srcdir" } +test -f src/libvirt.c || { + die "$0 must live in the top-level libvirt directory" +} -EXTRA_ARGS= +dry_run= no_git= -if test "x$1" = "x--no-git"; then - no_git=" $1" - shift - case "$1 $2" in - --gnulib-srcdir=*) no_git="$no_git $1"; shift ;; - --gnulib-srcdir\ *) no_git="$no_git $1=$2"; shift; shift;; - esac -fi -if test -z "$NOCONFIGURE" ; then - if test "x$1" = "x--system"; then - shift - prefix=/usr - libdir=$prefix/lib - sysconfdir=/etc - localstatedir=/var - if [ -d /usr/lib64 ]; then - libdir=$prefix/lib64 - fi - EXTRA_ARGS="--prefix=$prefix --sysconfdir=$sysconfdir --localstatedir=$localstatedir --libdir=$libdir" - echo "Running ./configure with $EXTRA_ARGS $@" - else - if test -z "$*" && test ! -f "$THEDIR/config.status"; then - echo "I am going to run ./configure with no arguments - if you wish" - echo "to pass any to it, please specify them on the $0 command line." - fi - fi -fi +gnulib_srcdir= +extra_args= +while test "$#" -gt 0; do + case "$1" in + --dry-run) + # This variable will serve both as an indicator of the fact that + # a dry run has been requested, and to store the result of the + # dry run. It will be ultimately used as return code for the + # script: 0 means no action is necessary, 2 means that autogen.sh + # needs to be executed, and 1 is reserved for failures + dry_run=0 + shift + ;; + --no-git) + no_git=" $1" + shift + ;; + --gnulib-srcdir=*) + gnulib_srcdir=" $1" + shift + ;; + --gnulib-srcdir) + gnulib_srcdir=" $1=$2" + shift + shift + ;; + --system) + prefix=/usr + sysconfdir=/etc + localstatedir=/var + if test -d $prefix/lib64; then + libdir=$prefix/lib64 + else + libdir=$prefix/lib + fi + extra_args="--prefix=$prefix --localstatedir=$localstatedir" + extra_args="$extra_args --sysconfdir=$sysconfdir --libdir=$libdir" + shift + ;; + *) + # All remaining arguments will be passed to configure verbatim + break + ;; + esac +done +no_git="$no_git$gnulib_srcdir" -# Compute the hash we'll use to determine whether rerunning bootstrap -# is required. The first is just the SHA1 that selects a gnulib snapshot. -# The second ensures that whenever we change the set of gnulib modules used -# by this package, we rerun bootstrap to pull in the matching set of files. -# The third ensures that whenever we change the set of local gnulib diffs, -# we rerun bootstrap to pull in those diffs. -bootstrap_hash() +gnulib_hash() { + local no_git=$1 + if test "$no_git"; then - echo no-git + echo "no-git" return fi - git submodule status | sed 's/^[ +-]//;s/ .*//' + + # Compute the hash we'll use to determine whether rerunning bootstrap + # is required. The first is just the SHA1 that selects a gnulib snapshot. + # The second ensures that whenever we change the set of gnulib modules used + # by this package, we rerun bootstrap to pull in the matching set of files. + # The third ensures that whenever we change the set of local gnulib diffs, + # we rerun bootstrap to pull in those diffs. + git submodule status .gnulib | awk '{ print $1 }' git hash-object bootstrap.conf - git ls-tree -d HEAD gnulib/local | awk '{print $3}' + git ls-tree -d HEAD gnulib/local | awk '{ print $3 }' } -# Ensure that whenever we pull in a gnulib update or otherwise change to a -# different version (i.e., when switching branches), we also rerun ./bootstrap. -# Also, running 'make rpm' tends to litter the po/ directory, and some people -# like to run 'git clean -x -f po' to fix it; but only ./bootstrap regenerates -# the required file po/Makevars. -# Only run bootstrap from a git checkout, never from a tarball. +# Only look into git submodules if we're in a git checkout if test -d .git || test -f .git; then - curr_status=.git-module-status t= - if test "$no_git"; then - t=no-git - elif test -d .gnulib; then - t=$(bootstrap_hash; git diff .gnulib) + + # Check for dirty submodules + if test -z "$CLEAN_SUBMODULE"; then + for path in $(git submodule status | awk '{ print $2 }'); do + case "$(git diff "$path")" in + *-dirty*) + echo "error: $path is dirty, please investigate" >&2 + echo "set CLEAN_SUBMODULE to discard submodule changes" >&2 + exit 1 + ;; + esac + done fi - case $t:${CLEAN_SUBMODULE+set} in - *:set) ;; - *-dirty*) - echo "error: gnulib submodule is dirty, please investigate" 2>&1 - echo "set env-var CLEAN_SUBMODULE to discard gnulib changes" 2>&1 - exit 1 ;; - esac - # Keep this test in sync with cfg.mk:_update_required - if test "$t" = "$(cat $curr_status 2>/dev/null)" \ - && test -f "po/Makevars" && test -f AUTHORS; then - # good, it's up to date, all we need is autoreconf - autoreconf -if + if test "$CLEAN_SUBMODULE" && test -z "$no_git"; then + if test -z "$dry_run"; then + echo "Cleaning up submodules..." + git submodule foreach 'git clean -dfqx && git reset --hard' || { + die "Cleaning up submodules failed" + } + fi + fi + + # Update all submodules. If any of the submodules has not been + # initialized yet, it will be initialized now; moreover, any submodule + # with uncommitted changes will be returned to the expected state + echo "Updating submodules..." + git submodule update --init || { + die "Updating submodules failed" + } + + # The expected hash, eg. the one computed after the last + # successful bootstrap run, is stored on disk + state_file=.git-module-status + expected_hash=$(cat "$state_file" 2>/dev/null) + actual_hash=$(gnulib_hash "$no_git") + + if test "$actual_hash" = "$expected_hash" && \ + test -f po/Makevars && test -f AUTHORS; then + # The gnulib hash matches our expectations, and all the files + # that can only be generated through bootstrap are present: + # we just need to run autoreconf. Unless we're performing a + # dry run, of course... + if test -z "$dry_run"; then + echo "Running autoreconf..." + autoreconf -if || { + die "autoreconf failed" + } + fi else - if test -z "$no_git" && test ${CLEAN_SUBMODULE+set}; then - echo cleaning up submodules... - git submodule foreach 'git clean -dfqx && git reset --hard' + # Whenever the gnulib submodule or any of the related bits + # has been changed in some way (see gnulib_hash) we need to + # run bootstrap again. If we're performing a dry run, we + # change the return code instead to signal our caller + if test "$dry_run"; then + dry_run=2 + else + echo "Running bootstrap..." + ./bootstrap$no_git --bootstrap-sync || { + die "bootstrap failed" + } + gnulib_hash >"$state_file" fi - echo running bootstrap$no_git... - ./bootstrap$no_git --bootstrap-sync && bootstrap_hash > $curr_status \ - || { echo "Failed to bootstrap, please investigate."; exit 1; } fi fi -test -n "$NOCONFIGURE" && exit 0 +# When performing a dry run, we can stop here +test "$dry_run" && exit "$dry_run" -cd "$THEDIR" +# If asked not to run configure, we can stop here +test "$NOCONFIGURE" && exit 0 -if test "x$OBJ_DIR" != x; then - mkdir -p "$OBJ_DIR" - cd "$OBJ_DIR" +cd "$starting_point" || { + die "Failed to cd into $starting_point" +} + +if test "$OBJ_DIR"; then + mkdir -p "$OBJ_DIR" || { + die "Failed to create $OBJ_DIR" + } + cd "$OBJ_DIR" || { + die "Failed to cd into $OBJ_DIR" + } fi -if test -z "$*" && test -z "$EXTRA_ARGS" && test -f config.status; then - ./config.status --recheck +if test -z "$*" && test -z "$extra_args" && test -f config.status; then + echo "Running config.status..." + ./config.status --recheck || { + die "config.status failed" + } else - $srcdir/configure $EXTRA_ARGS "$@" -fi && { - echo - echo "Now type 'make' to compile libvirt." -} + if test -z "$*" && test -z "$extra_args"; then + echo "I am going to run configure with no arguments - if you wish" + echo "to pass any to it, please specify them on the $0 command line." + else + echo "Running configure with $extra_args $@" + fi + "$srcdir/configure" $extra_args "$@" || { + die "configure failed" + } +fi + +echo +echo "Now type 'make' to compile libvirt." diff --git a/cfg.mk b/cfg.mk index 09548fe..c04a991 100644 --- a/cfg.mk +++ b/cfg.mk @@ -1026,33 +1026,30 @@ prev_version_file = /dev/null ifneq ($(_gl-Makefile),) ifeq (0,$(MAKELEVEL)) - _curr_status = .git-module-status - # The sed filter accommodates those who check out on a commit from which - # no tag is reachable. In that case, git submodule status prints a "-" - # in column 1 and does not print a "git describe"-style string after the - # submodule name. Contrast these: - # -b653eda3ac4864de205419d9f41eec267cb89eeb .gnulib - # b653eda3ac4864de205419d9f41eec267cb89eeb .gnulib (v0.0-2286-gb653eda) - # $ cat .git-module-status - # b653eda3ac4864de205419d9f41eec267cb89eeb - # - # Keep this logic in sync with autogen.sh. - _submodule_hash = $(SED) 's/^[ +-]//;s/ .*//' - _update_required := $(shell \ - cd '$(srcdir)'; \ - test -d .git || { echo 0; exit; }; \ - test -f po/Makevars || { echo 1; exit; }; \ - test -f AUTHORS || { echo 1; exit; }; \ - test "no-git" = "$$(cat $(_curr_status))" && { echo 0; exit; }; \ - actual=$$(git submodule status | $(_submodule_hash); \ - git hash-object bootstrap.conf; \ - git ls-tree -d HEAD gnulib/local | awk '{print $$3}'; \ - git diff .gnulib); \ - stamp="$$($(_submodule_hash) $(_curr_status) 2>/dev/null)"; \ - test "$$stamp" = "$$actual"; echo $$?) + _dry_run_result := $(shell \ + cd '$(srcdir)'; \ + test -d .git || test -f .git || { echo 0; exit; }; \ + $(srcdir)/autogen.sh --dry-run >/dev/null 2>&1; \ + echo $$?; \ + ) _clean_requested = $(filter %clean,$(MAKECMDGOALS)) - ifeq (1,$(_update_required)$(_clean_requested)) - $(info INFO: gnulib update required; running ./autogen.sh first) + + # A return value of 0 means no action is required + + # A return value of 1 means a genuine error has occurred while + # performing the dry run, and it should be reported so it can + # be investigated + ifeq (1,$(_dry_run_result)) + $(info INFO: autogen.sh error, running again to show details) +maint.mk Makefile: _autogen_error + endif + + # A return value of 2 means that autogen.sh needs to be executed + # in earnest before building, probably because of gnulib updates. + # We don't run autogen.sh if the clean target has been invoked, + # though, as it would be quite pointless + ifeq (2,$(_dry_run_result)$(_clean_requested)) + $(info INFO: running autogen.sh is required, running it now...) $(shell touch $(srcdir)/AUTHORS $(srcdir)/ChangeLog) maint.mk Makefile: _autogen endif @@ -1066,6 +1063,10 @@ _autogen: $(srcdir)/autogen.sh ./config.status +.PHONY: _autogen_error +_autogen_error: + $(srcdir)/autogen.sh --dry-run + # regenerate HACKING as part of the syntax-check ifneq ($(_gl-Makefile),) syntax-check: $(top_srcdir)/HACKING spacing-check test-wrap-argv \ -- 2.7.4

2 2

[libvirt] [PATCH] test: Remove unnecessary unlocks in cleanup paths
by John Ferlan 25 Apr '17

25 Apr '17

Commit id '865f479da' altered the logic to use a common test*ObjFindByName helpers which would lock/unlock the test driver; however, a few cleanup paths in that cleanup missed removing the Unlock, so remove it now. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- src/test/test_driver.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 00999b1..2db3f7d 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -3931,7 +3931,6 @@ testInterfaceUndefine(virInterfacePtr iface) ret = 0; cleanup: - testDriverUnlock(privconn); return ret; } @@ -3960,7 +3959,6 @@ testInterfaceCreate(virInterfacePtr iface, cleanup: if (privinterface) virInterfaceObjUnlock(privinterface); - testDriverUnlock(privconn); return ret; } @@ -3989,7 +3987,6 @@ testInterfaceDestroy(virInterfacePtr iface, cleanup: if (privinterface) virInterfaceObjUnlock(privinterface); - testDriverUnlock(privconn); return ret; } @@ -4480,7 +4477,6 @@ testStoragePoolUndefine(virStoragePoolPtr pool) if (privpool) virStoragePoolObjUnlock(privpool); testObjectEventQueue(privconn, event); - testDriverUnlock(privconn); return ret; } @@ -4591,7 +4587,6 @@ testStoragePoolDestroy(virStoragePoolPtr pool) testObjectEventQueue(privconn, event); if (privpool) virStoragePoolObjUnlock(privpool); - testDriverUnlock(privconn); return ret; } -- 2.9.3

2 1

[libvirt] [PATCH] util: relax virNetDevSetCoalesce() stub
by Roman Bogorodskiy 24 Apr '17

24 Apr '17

Currently, virNetDevSetCoalesce() stub is always returning error. As it's used by virNetDevTapCreateInBridgePort(), it essentially breaks bridged networking if coalesce is not supported. To make it work, relax the stub to trigger error only when its coalesce argument is not NULL, otherwise report success. --- src/util/virnetdev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 131a56a8d..131c4d983 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -3155,8 +3155,11 @@ int virNetDevSetCoalesce(const char *ifname, } # else int virNetDevSetCoalesce(const char *ifname, - virNetDevCoalescePtr coalesce ATTRIBUTE_UNUSED) + virNetDevCoalescePtr coalesce) { + if (!coalesce) + return 0; + virReportSystemError(ENOSYS, _("Cannot set coalesce info on interface '%s'"), ifname); -- 2.11.0

2 2

[libvirt] [PATCH] Fix minor typos
by Yuri Chornoivan 24 Apr '17

24 Apr '17

Hi, Attached is a minor fix for the typos in libvirt's git/master. Best regards, Yuri P. S. Sorry for the lame format. My mail provider rejects direct sending emails from git send.

2 1

[libvirt] [PATCH go-xml] Support for filesystem devices
by Ryan Goodfellow 24 Apr '17

24 Apr '17

This commit adds filesystem device support. A new family of types DomainFilesystem* are introduced and plumbed into the DomainDeviceList struct. Testing has also been included. --- domain.go | 40 ++++++++++++++++++++++++++++++++++++++++ domain_test.go | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 95 insertions(+) diff --git a/domain.go b/domain.go index 307c71c..cccd9a6 100644 --- a/domain.go +++ b/domain.go @@ -81,6 +81,45 @@ type DomainDisk struct { Target *DomainDiskTarget `xml:"target"` } +type DomainFilesystemDriver struct { + Type string `xml:"type,attr"` + Name string `xml:"name,attr,omitempty"` + WRPolicy string `xml:"wrpolicy,attr,omitempty"` +} + +type DomainFilesystemSource struct { + Dir string `xml:"dir,attr,omitempty"` + File string `xml:"file,attr,omitempty"` +} + +type DomainFilesystemTarget struct { + Dir string `xml:"dir,attr"` +} + +type DomainFilesystemReadOnly struct { +} + +type DomainFilesystemSpaceHardLimit struct { + Value int `xml:",chardata"` + Unit string `xml:"unit,attr,omitempty"` +} + +type DomainFilesystemSpaceSoftLimit struct { + Value int `xml:",chardata"` + Unit string `xml:"unit,attr,omitempty"` +} + +type DomainFilesystem struct { + Type string `xml:"type,attr"` + AccessMode string `xml:"accessmode,attr"` + Driver *DomainFilesystemDriver `xml:"driver"` + Source *DomainFilesystemSource `xml:"source"` + Target *DomainFilesystemTarget `xml:"target"` + ReadOnly *DomainFilesystemReadOnly `xml:"readonly"` + SpaceHardLimit *DomainFilesystemSpaceHardLimit `xml:"space_hard_limit"` + SpaceSoftLimit *DomainFilesystemSpaceSoftLimit `xml:"space_soft_limit"` +} + type DomainInterfaceMAC struct { Address string `xml:"address,attr"` } @@ -212,6 +251,7 @@ type DomainVideo struct { type DomainDeviceList struct { Controllers []DomainController `xml:"controller"` Disks []DomainDisk `xml:"disk"` + Filesystems []DomainFilesystem `xml:"filesystem"` Interfaces []DomainInterface `xml:"interface"` Serials []DomainChardev `xml:"serial"` Consoles []DomainChardev `xml:"console"` diff --git a/domain_test.go b/domain_test.go index e5347ea..06d585c 100644 --- a/domain_test.go +++ b/domain_test.go @@ -690,6 +690,61 @@ var domainTestData = []struct { `</domain>`, }, }, + { + Object: &Domain{ + Type: "kvm", + Name: "test", + Devices: &DomainDeviceList{ + Filesystems: []DomainFilesystem{ + DomainFilesystem{ + Type: "mount", + AccessMode: "mapped", + Driver: &DomainFilesystemDriver{ + Type: "path", + WRPolicy: "immediate", + }, + Source: &DomainFilesystemSource{ + Dir: "/home/user/test", + }, + Target: &DomainFilesystemTarget{ + Dir: "user-test-mount", + }, + }, + DomainFilesystem{ + Type: "file", + AccessMode: "passthrough", + Driver: &DomainFilesystemDriver{ + Name: "loop", + Type: "raw", + }, + Source: &DomainFilesystemSource{ + File: "/home/user/test.img", + }, + Target: &DomainFilesystemTarget{ + Dir: "user-file-test-mount", + }, + }, + }, + }, + }, + Expected: []string{ + `<domain type="kvm">`, + ` <name>test</name>`, + ` <devices>`, + ` <filesystem type="mount" accessmode="mapped">`, + ` <driver type="path" wrpolicy="immediate"></driver>`, + ` <source dir="/home/user/test"></source>`, + ` <target dir="user-test-mount"></target>`, + ` </filesystem>`, + ` <filesystem type="file" accessmode="passthrough">`, + ` <driver type="raw" name="loop"></driver>`, + ` <source file="/home/user/test.img"></source>`, + ` <target dir="user-file-test-mount"></target>`, + ` </filesystem>`, + ` </devices>`, + `</domain>`, + }, + }, } func TestDomain(t *testing.T) { -- 2.11.0

2 3

[libvirt] [PATCH] [PATCH] rpc: fix keep alive timer segfault
by Yi Wang 24 Apr '17

24 Apr '17

ka maybe have been freeed in virObjectUnref, application using virKeepAliveTimer will segfault when unlock ka. We should keep ka's refs positive before using it. Signed-off-by: Yi Wang <wang.yi59(a)zte.com.cn> --- src/rpc/virkeepalive.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/rpc/virkeepalive.c b/src/rpc/virkeepalive.c index c9faf88..4f666fd 100644 --- a/src/rpc/virkeepalive.c +++ b/src/rpc/virkeepalive.c @@ -160,17 +160,17 @@ virKeepAliveTimer(int timer ATTRIBUTE_UNUSED, void *opaque) bool dead; void *client; + virObjectRef(ka); virObjectLock(ka); client = ka->client; dead = virKeepAliveTimerInternal(ka, &msg); + virObjectUnlock(ka); + if (!dead && !msg) goto cleanup; - virObjectRef(ka); - virObjectUnlock(ka); - if (dead) { ka->deadCB(client); } else if (ka->sendCB(client, msg) < 0) { @@ -178,11 +178,8 @@ virKeepAliveTimer(int timer ATTRIBUTE_UNUSED, void *opaque) virNetMessageFree(msg); } - virObjectLock(ka); - virObjectUnref(ka); - cleanup: - virObjectUnlock(ka); + virObjectUnref(ka); } -- 1.8.3.1

4 5

[libvirt] [PATCH v2 0/2] Fix possible use-after-free when sending event message
by John Ferlan 24 Apr '17

24 Apr '17

v1: https://www.redhat.com/archives/libvir-list/2017-March/msg01228.html Change since v1, add the derefFcn as an argument to the renamed macro (not quite sure how I missed that originally. John Ferlan (2): daemon: Rework remoteClientFreeFunc cleanup loops into C macro remote: Fix possible use-after-free when sending event message daemon/remote.c | 164 ++++++++++++++++++++------------------------------------ 1 file changed, 58 insertions(+), 106 deletions(-) -- 2.9.3

3 7

[libvirt] [PATCH] util: fix virNetDevSetCoalesce fallback on Win32/FreeBSD
by Daniel P. Berrange 23 Apr '17

23 Apr '17

The current fallback stub for virNetDevSetCoalesce is inside an earlier conditional block. This deals with the feature being missing on older Linux platforms. We need a second fallback stub though, outside the top level conditional, to ensure builds work on Win32/FreeBSD platforms too. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- Pushed as a build fix src/util/virnetdev.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 6ff1b48..27f1637 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -3207,6 +3207,15 @@ virNetDevGetFeatures(const char *ifname ATTRIBUTE_UNUSED, ifname); return 0; } + +int virNetDevSetCoalesce(const char *ifname, + virNetDevCoalescePtr coalesce ATTRIBUTE_UNUSED) +{ + virReportSystemError(ENOSYS, + _("Cannot set coalesce info on interface '%s'"), + ifname); + return -1; +} #endif -- 2.9.3

3 3

[libvirt] [PATCH] Remove pointless check for !ret in virDomainNetDefCoalesceParseXML
by Martin Kletzander 22 Apr '17

22 Apr '17

It was left there after removing a macro it was part of in first version or so. Now it will always be NULL. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- Pushed as trivial src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 4a777d67bfad..7d3cf178eaf6 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6789,7 +6789,7 @@ virDomainNetDefCoalesceParseXML(xmlNodePtr node, if (!str) goto cleanup; - if (!ret && VIR_ALLOC(ret) < 0) + if (VIR_ALLOC(ret) < 0) goto cleanup; if (virStrToLong_ullp(str, NULL, 10, &tmp) < 0) { -- 2.12.2

1 0

[libvirt] [PATCH] Don't leak str in virDomainNetDefCoalesceParseXML
by Martin Kletzander 22 Apr '17

22 Apr '17

Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- Pushed as trivial. src/conf/domain_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index cbeebdc56880..4a777d67bfad 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6811,6 +6811,7 @@ virDomainNetDefCoalesceParseXML(xmlNodePtr node, ret->rx_max_coalesced_frames = tmp; cleanup: + VIR_FREE(str); ctxt->node = save; return ret; -- 2.12.2

1 0

[libvirt] [PATCH v2 0/3] Add support for coalesce settings on interfaces
by Martin Kletzander 22 Apr '17

22 Apr '17

In linux this is supported since 4.11-rc3, I tested it with 4.11.0-rc5-next-20170407. The particular patch can be found here: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?… Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1414627 In this version the XML is different so that there are no underscores (and it's actually more readable, IMHO). Plus some minor adjustments needed after rebase. Martin Kletzander (3): util: Add virNetDevSetCoalesce function conf, docs: Add support for coalesce setting(s) Set coalesce settings for domain interfaces configure.ac | 3 +- docs/formatdomain.html.in | 24 ++++ docs/schemas/domaincommon.rng | 131 +++++++++++++++++++++ src/bhyve/bhyve_command.c | 2 +- src/conf/domain_conf.c | 80 +++++++++++++ src/conf/domain_conf.h | 2 + src/libvirt_private.syms | 1 + src/network/bridge_driver.c | 2 +- src/qemu/qemu_domain.c | 31 +++++ src/qemu/qemu_interface.c | 2 +- src/uml/uml_conf.c | 2 +- src/util/virnetdev.c | 83 +++++++++++++ src/util/virnetdev.h | 34 ++++++ src/util/virnetdevtap.c | 5 + src/util/virnetdevtap.h | 2 + tests/bhyvexml2argvmock.c | 1 + .../qemuxml2argvdata/qemuxml2argv-net-coalesce.xml | 68 +++++++++++ .../qemuxml2xmlout-net-coalesce.xml | 71 +++++++++++ tests/qemuxml2xmltest.c | 1 + 19 files changed, 540 insertions(+), 5 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-net-coalesce.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-net-coalesce.xml -- 2.12.2

3 8

[libvirt] [PATCH v2 0/5] Hyper-V method invocation
by Sri Ramanujam 22 Apr '17

22 Apr '17

Changes from v1: * Removed unneeded util function Sri Ramanujam (5): hyperv: Functions to work with invocation parameters. hyperv: Generate object property type information. hyperv: add hypervInvokeMethod hyperv: support virDomainSendKey hyperv: Add support for virDomainSetMemory src/hyperv/hyperv_driver.c | 182 +++++++ src/hyperv/hyperv_wmi.c | 879 ++++++++++++++++++++++++++++++++++ src/hyperv/hyperv_wmi.h | 93 +++- src/hyperv/hyperv_wmi_classes.h | 19 + src/hyperv/hyperv_wmi_generator.input | 116 +++++ src/hyperv/hyperv_wmi_generator.py | 15 +- src/hyperv/openwsman.h | 4 + 7 files changed, 1306 insertions(+), 2 deletions(-) -- 2.9.3

2 7

Re: [libvirt] creating stream
by Michal Privoznik 21 Apr '17

21 Apr '17

On 04/20/2017 03:55 PM, Vasiliy Tolstov wrote: > 2017-04-06 14:59 GMT+03:00 Michal Privoznik <mprivozn(a)redhat.com>: >> That is not going to be enough. The RPC protocol is spread among other files >> too. You really should not hook into our RPC protocol. My question is still >> unanswered though - why do you need it anyway? > > Thanks for all your help, i'm create mostly complete libvirt binding > using generator. Last problem - do you know binary representation ofr > virTypedParams? Does it xdr encoded when passed via wire or not? And > format of this field? You can see for yourself - just fire up wireshark with libvirt dissector installed and issue the API. Also, you may look at remote_typed_param_value and remote_typed_param structs defined in src/remote/remote_protocol.h. Michal

2 7

[libvirt] [PATCH v3 0/3] libxl: nestedhvm support
by Wim Ten Have 21 Apr '17

21 Apr '17

From: Wim ten Have <wim.ten.have(a)oracle.com> This patch enhances host-passthrough capability to advertise the required vendor CPU virtualization feature which will be used to enable 'nestedhvm' in the libxl driver. Wim ten Have (3): libxl: set nestedhvm for mode host-passthrough xenconfig: add conversions for xen-xl xlconfigtest: add tests for 'nestedhvm' support cfg.mk | 2 +- src/libxl/libxl_conf.c | 46 ++++++++++++++-- src/libxl/libxl_conf.h | 2 +- src/libxl/libxl_domain.c | 2 +- src/xenconfig/xen_xl.c | 64 ++++++++++++++++++++++ .../test-fullvirt-nestedhvm-disabled.cfg | 26 +++++++++ .../test-fullvirt-nestedhvm-disabled.xml | 61 +++++++++++++++++++++ tests/xlconfigdata/test-fullvirt-nestedhvm.cfg | 26 +++++++++ tests/xlconfigdata/test-fullvirt-nestedhvm.xml | 59 ++++++++++++++++++++ tests/xlconfigtest.c | 2 + 10 files changed, 282 insertions(+), 8 deletions(-) create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm-disabled.cfg create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm-disabled.xml create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm.cfg create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm.xml -- 2.9.3

3 8

[libvirt] [PATCH] docs: fix typo in closing HTML element
by Daniel P. Berrange 21 Apr '17

21 Apr '17

Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- Pushed as a build fix docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 5469fc3..9bea3bc 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -5425,7 +5425,7 @@ qemu-kvm -net nic,model=? /dev/null This element provides means of setting coalesce settings for some interface devices (currently only type <code>network</code> and <code>bridge</code>. Currently there is just one attribute, - <code>max</code>, to tweak, in element <code>frames<code> for + <code>max</code>, to tweak, in element <code>frames</code> for the <code>rx</code> group, which accepts a non-negative integer that specifies the maximum number of packets that will be received before an interrupt. -- 2.9.3

1 0

[libvirt] [PATCH] util: check ifa_addr pointer before accessing its elements
by Pavel Hrdina 21 Apr '17

21 Apr '17

Reported by Rafał Wojciechowski <it(a)rafalwojciechowski.pl>. Thread 1 (Thread 0x7f194b99d700 (LWP 5631)): 0 virNetDevGetifaddrsAddress (addr=0x7f194b99c7c0, ifname=0x7f193400e2b0 "ovirtmgmt") at util/virnetdevip.c:738 1 virNetDevIPAddrGet (ifname=0x7f193400e2b0 "ovirtmgmt", addr=addr@entry=0x7f194b99c7c0) at util/virnetdevip.c:795 2 0x00007f19467800d6 in networkGetNetworkAddress (netname=<optimized out>, netaddr=netaddr@entry=0x7f1924013f18) at network/bridge_driver.c:4780 3 0x00007f193e43a33c in qemuProcessGraphicsSetupNetworkAddress (listenAddr=0x7f19340f7650 "127.0.0.1", glisten=0x7f1924013f10) at qemu/qemu_process.c:4062 4 qemuProcessGraphicsSetupListen (vm=<optimized out>, graphics=0x7f1924014f10, cfg=0x7f1934119f00) at qemu/qemu_process.c:4133 5 qemuProcessSetupGraphics (flags=17, vm=0x7f19240155d0, driver=0x7f193411f1d0) at qemu/qemu_process.c:4196 6 qemuProcessPrepareDomain (conn=conn@entry=0x7f192c00ab50, driver=driver@entry=0x7f193411f1d0, vm=vm@entry=0x7f19240155d0, flags=flags@entry=17) at qemu/qemu_process.c:4969 7 0x00007f193e4417c0 in qemuProcessStart (conn=conn@entry=0x7f192c00ab50, driver=driver@entry=0x7f193411f1d0, vm=0x7f19240155d0,asyncJob=asyncJob@entry=QEMU_ASYNC_JOB_START, migrateFrom=migrateFrom@entry=0x0, migrateFd=migrateFd@entry=-1, migratePath=migratePath@entry=0x0,snapshot=snapshot@entry=0x0, vmop=vmop@entry=VIR_NETDEV_VPORT_PROFILE_OP_CREATE, flags=17, flags@entry=1) at qemu/qemu_process.c:5553 Man page for getifaddrs also states that the "ifa_addr" may contain a null pointer which happens if there is an existing network interface on the host without IP address. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/util/virnetdevip.c | 7 ++++++- src/util/virnetdevtap.c | 3 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/util/virnetdevip.c b/src/util/virnetdevip.c index 726fa6c3e3..09925e1d74 100644 --- a/src/util/virnetdevip.c +++ b/src/util/virnetdevip.c @@ -902,10 +902,15 @@ virNetDevGetifaddrsAddress(const char *ifname, } for (ifa = ifap; ifa; ifa = ifa->ifa_next) { - int family = ifa->ifa_addr->sa_family; + int family; if (STRNEQ_NULLABLE(ifa->ifa_name, ifname)) continue; + + if (!ifa->ifa_addr) + continue; + family = ifa->ifa_addr->sa_family; + if (family != AF_INET6 && family != AF_INET) continue; diff --git a/src/util/virnetdevtap.c b/src/util/virnetdevtap.c index 02ef7fd240..93002b9294 100644 --- a/src/util/virnetdevtap.c +++ b/src/util/virnetdevtap.c @@ -762,6 +762,9 @@ virNetDevTapInterfaceStats(const char *ifname, } for (ifa = ifap; ifa; ifa = ifa->ifa_next) { + if (!ifa->ifa_addr) + continue; + if (ifa->ifa_addr->sa_family != AF_LINK) continue; -- 2.12.2

2 1

[libvirt] [PATCH] Use port range 5901-5999 if not set in qemu.conf, avoid port 5900
by Christophe de Dinechin 21 Apr '17

21 Apr '17

In order to avoid conflict with the default port (5900) for host VNC server (vino-server for example), or to conflict with X11 (starting at port 6000), restrict range of ports to 5901-5999 unless explicitly specified in qemu.conf. On the other hand, if port range is explicitly specified in qemu.conf, there is no reason not to allow ports 1024-5900 (system ports are below 1024). Addresses https://bugzilla.redhat.com/show_bug.cgi?id=1442235 Signed-off-by: Christophe de Dinechin <dinechin(a)redhat.com> --- src/qemu/qemu_conf.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 1b704da..07f3177 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -65,9 +65,15 @@ VIR_LOG_INIT("qemu.qemu_conf"); * This limitation is mentioned in qemu.conf, so bear in mind that the * configuration file should reflect any changes made to these values. */ -#define QEMU_REMOTE_PORT_MIN 5900 + +// Range of available ports - Avoid ports below 1024 (system ports) +#define QEMU_REMOTE_PORT_MIN 1024 #define QEMU_REMOTE_PORT_MAX 65535 +// Default min and max if not configured in qemu.conf +#define QEMU_REMOTE_PORT_MIN_DEFAULT 5901 +#define QEMU_REMOTE_PORT_MAX_DEFAULT 5999 + #define QEMU_WEBSOCKET_PORT_MIN 5700 #define QEMU_WEBSOCKET_PORT_MAX 65535 @@ -283,8 +289,8 @@ virQEMUDriverConfigPtr virQEMUDriverConfigNew(bool privileged) #undef SET_TLS_X509_CERT_DEFAULT - cfg->remotePortMin = QEMU_REMOTE_PORT_MIN; - cfg->remotePortMax = QEMU_REMOTE_PORT_MAX; + cfg->remotePortMin = QEMU_REMOTE_PORT_MIN_DEFAULT; + cfg->remotePortMax = QEMU_REMOTE_PORT_MAX_DEFAULT; cfg->webSocketPortMin = QEMU_WEBSOCKET_PORT_MIN; cfg->webSocketPortMax = QEMU_WEBSOCKET_PORT_MAX; -- 2.9.3

3 6

[libvirt] How to get VM memory usage
by wangyufeng＠cloudguarding.com 21 Apr '17

21 Apr '17

Hello everyone, Could you tell me how to get VM memory usage from libvirt-go? Thanks wangyufeng(a)cloudguarding.com

2 3

[libvirt] [PATCH] util: allow ignoring SIOCSIFHWADDR when errno is EPERM
by Laine Stump 21 Apr '17

21 Apr '17

From: Laine Stump <laine(a)redhat.com> Commit f4ef3a71 made a variation of virNetDevSetMAC that would return without logging an error message if errno was set to EADDRNOTAVAIL. This errno is set by some SRIOV VF drivers (in particular igbvf) when they fail to set the device's MAC address due to the PF driver refusing the request. This is useful if we want to try a different method of setting the VF MAC address before giving up (Commit 86556e16 actually does this, setting the desired MAC address to the "admin MAC in the PF, then detaching and reattaching the VF netdev driver to force a reinit of the MAC address). During testing of Bug 1442040 t was discovered that the ixgbe driver returns EPERM in this situation, so this patch changes the exception case for silent+non-terminal failure to account for this difference. Completes resolution to: https://bugzilla.redhat.com/1415609 (RHEL 7.4) https://bugzilla.redhat.com/1442040 (RHEL 7.3.z) --- src/util/virnetdev.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 170e348..9aa9c9f 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -226,7 +226,8 @@ int virNetDevExists(const char *ifname) * virNetDevSetMACInternal: * @ifname: interface name to set MTU for * @macaddr: MAC address - * @quiet: true if a failure to set MAC address with errno == EADDRNOTAVAIL + * @quiet: true if a failure to set MAC address with + * errno == EADDRNOTAVAIL || errno == EPERM * should be silent (still returns error, but without log) * * This function sets the @macaddr for a given interface @ifname. @@ -258,7 +259,8 @@ virNetDevSetMACInternal(const char *ifname, if (ioctl(fd, SIOCSIFHWADDR, &ifr) < 0) { - if (quiet && errno == EADDRNOTAVAIL) + if (quiet && + (errno == EADDRNOTAVAIL || errno == EPERM)) goto cleanup; virReportSystemError(errno, @@ -305,7 +307,8 @@ virNetDevSetMACInternal(const char *ifname, ifr.ifr_addr.sa_len = VIR_MAC_BUFLEN; if (ioctl(s, SIOCSIFLLADDR, &ifr) < 0) { - if (quiet && errno == EADDRNOTAVAIL) + if (quiet && + (errno == EADDRNOTAVAIL || errno == EPERM)) goto cleanup; virReportSystemError(errno, @@ -2229,11 +2232,12 @@ virNetDevSetNetConfig(const char *linkdev, int vf, int retries = 100; /* if pfDevOrig == NULL, this isn't a VF, so we've failed */ - if (!pfDevOrig || errno != EADDRNOTAVAIL) + if (!pfDevOrig || + (errno != EADDRNOTAVAIL && errno != EPERM)) goto cleanup; /* Otherwise this is a VF, and virNetDevSetMAC failed with - * EADDRNOTAVAIL, which could be due to the + * EADDRNOTAVAIL/EPERM, which could be due to the * "administratively set" flag being set in the PF for * this VF. When this happens, we can attempt to use an * alternate method to set the VF MAC: first set it into -- 2.9.3

2 1

[libvirt] [PATCH v3 1/2] daemon: Fix domain name leak in error path
by Wang King 21 Apr '17

21 Apr '17

Domain name duplicated in make_nonnull_domain, but not freed when virTypedParamsSerialize return negative. --- daemon/remote.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/daemon/remote.c b/daemon/remote.c index 1610fea..5d726f4 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -1067,7 +1067,7 @@ remoteRelayDomainEventTunable(virConnectPtr conn, (virTypedParameterRemotePtr *) &data.params.params_val, &data.params.params_len, VIR_TYPED_PARAM_STRING_OKAY) < 0) - return -1; + goto error; remoteDispatchObjectEventSend(callback->client, remoteProgram, REMOTE_PROC_DOMAIN_EVENT_CALLBACK_TUNABLE, @@ -1075,6 +1075,10 @@ remoteRelayDomainEventTunable(virConnectPtr conn, &data); return 0; + error: + VIR_FREE(data.dom.name); + return -1; + } @@ -1207,13 +1211,16 @@ remoteRelayDomainEventJobCompleted(virConnectPtr conn, (virTypedParameterRemotePtr *) &data.params.params_val, &data.params.params_len, VIR_TYPED_PARAM_STRING_OKAY) < 0) - return -1; + goto error; remoteDispatchObjectEventSend(callback->client, remoteProgram, REMOTE_PROC_DOMAIN_EVENT_CALLBACK_JOB_COMPLETED, (xdrproc_t)xdr_remote_domain_event_callback_job_completed_msg, &data); return 0; + error: + VIR_FREE(data.dom.name); + return -1; } -- 2.8.3

2 2

[libvirt] [PATCH] util: allow ignoring SIOCSIFHWADDR when errno is EPERM
by Laine Stump 20 Apr '17

20 Apr '17

From: Laine Stump <laine(a)redhat.com> Commit f4ef3a71 made a variation of virNetDevSetMAC that would return without logging an error message if errno was set to EADDRNOTAVAIL. This errno is set by some SRIOV VF drivers (in particular igbvf) when they fail to set the device's MAC address due to the PF driver refusing the request. This is useful if we want to try a different method of setting the VF MAC address before giving up (Commit 86556e16 actually does this, setting the desired MAC address to the "admin MAC in the PF, then detaching and reattaching the VF netdev driver to force a reinit of the MAC address). During testing of Bug 1442040 t was discovered that the ixgbe driver returns EPERM in this situation, so this patch changes the exception case for silent+non-terminal failure to account for this difference. Completes resolution to: https://bugzilla.redhat.com/1415609 (RHEL 7.4) https://bugzilla.redhat.com/1442040 (RHEL 7.3.z) --- NB: I could also change it to be silent on *any* error, but this could lead to situations where the actual cause of a failure to set the MAC address is obscured to the point of being unable to figure out the problem (because the error would instead show up when the kernel is trying to initialize the MAC address as it reattached the VF net driver, for example). Limiting the errno's that warrant the silent treatment allows us to give more useful error reporting in these other cases. src/util/virnetdev.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 170e348..9aa9c9f 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -226,7 +226,8 @@ int virNetDevExists(const char *ifname) * virNetDevSetMACInternal: * @ifname: interface name to set MTU for * @macaddr: MAC address - * @quiet: true if a failure to set MAC address with errno == EADDRNOTAVAIL + * @quiet: true if a failure to set MAC address with + * errno == EADDRNOTAVAIL || errno == EPERM * should be silent (still returns error, but without log) * * This function sets the @macaddr for a given interface @ifname. @@ -258,7 +259,8 @@ virNetDevSetMACInternal(const char *ifname, if (ioctl(fd, SIOCSIFHWADDR, &ifr) < 0) { - if (quiet && errno == EADDRNOTAVAIL) + if (quiet && + (errno == EADDRNOTAVAIL || errno == EPERM)) goto cleanup; virReportSystemError(errno, @@ -305,7 +307,8 @@ virNetDevSetMACInternal(const char *ifname, ifr.ifr_addr.sa_len = VIR_MAC_BUFLEN; if (ioctl(s, SIOCSIFLLADDR, &ifr) < 0) { - if (quiet && errno == EADDRNOTAVAIL) + if (quiet && + (errno == EADDRNOTAVAIL || errno == EPERM)) goto cleanup; virReportSystemError(errno, @@ -2229,11 +2232,12 @@ virNetDevSetNetConfig(const char *linkdev, int vf, int retries = 100; /* if pfDevOrig == NULL, this isn't a VF, so we've failed */ - if (!pfDevOrig || errno != EADDRNOTAVAIL) + if (!pfDevOrig || + (errno != EADDRNOTAVAIL && errno != EPERM)) goto cleanup; /* Otherwise this is a VF, and virNetDevSetMAC failed with - * EADDRNOTAVAIL, which could be due to the + * EADDRNOTAVAIL/EPERM, which could be due to the * "administratively set" flag being set in the PF for * this VF. When this happens, we can attempt to use an * alternate method to set the VF MAC: first set it into -- 2.9.3

1 0

[libvirt] [PATCH v2 0/3] libxl: nestedhvm support
by Wim Ten Have 20 Apr '17

20 Apr '17

From: Wim ten Have <wim.ten.have(a)oracle.com> This patch enhances host-passthrough capability to advertise the required vendor CPU virtualization feature which will be used to enable 'nestedhvm' in the libxl driver. Wim ten Have (3): libxl: set nestedhvm for mode host-passthrough xenconfig: add conversions for xen-xl xlconfigtest: add tests for 'nestedhvm' support src/libxl/libxl_conf.c | 47 +++++++++++++-- src/libxl/libxl_conf.h | 2 +- src/libxl/libxl_domain.c | 2 +- src/xenconfig/xen_xl.c | 67 ++++++++++++++++++++++ .../test-fullvirt-nestedhvm-disabled.cfg | 26 +++++++++ .../test-fullvirt-nestedhvm-disabled.xml | 62 ++++++++++++++++++++ .../test-fullvirt-nestedhvm-undefined.cfg | 25 ++++++++ .../test-fullvirt-nestedhvm-undefined.xml | 58 +++++++++++++++++++ tests/xlconfigdata/test-fullvirt-nestedhvm.cfg | 26 +++++++++ tests/xlconfigdata/test-fullvirt-nestedhvm.xml | 59 +++++++++++++++++++ tests/xlconfigtest.c | 3 + 11 files changed, 370 insertions(+), 7 deletions(-) create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm-disabled.cfg create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm-disabled.xml create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm-undefined.cfg create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm-undefined.xml create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm.cfg create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm.xml -- 2.9.3

3 12

[libvirt] [RFC] Add support for QEMU's l3-cache CPU property
by Jiri Denemark 20 Apr '17

20 Apr '17

Hi, Apparently, reporting a level 3 cache on a virtual CPU can dramatically increase performance in some use cases [1]. The interesting part is that l3-cache=on does not provide the real CPU cache data, it's just making it up. Anyway, we should be able to enable this via libvirt. And since there is another property which enables real CPU cache data to be passed to a guest, I suggest the following /domain/cpu/cache element equivalent to l3-cache=on: <cache level='3' mode='emulate'/> If we need to add support for passing the real CPU cache data, we can do that with <cache level='3' mode='passthrough'/> or we can even make the level attribute optional and support <cache mode='passthrough'/> Missing cache element means default behaviour of the hypervisor and we can eventually add <cache mode='disable'/> to turn off passing any CPU cache info to the guest. But I think we should now focus only on <cache level='3' mode='emulate'/> and leaving the rest for the future when we actually need it. This is how a more complete example would look like: <cpu mode='custom' match='exact'> <model>Broadwell</model> <cache level='3' mode='emulate'/> </cpu> And libvirt would translate it into -cpu Broadwell,l3-cache=on. Do you have any thoughts about the XML schema or naming? Thanks, Jirka [1] https://patchwork.kernel.org/patch/9308401/

2 5

[libvirt] [PATCH] virsh: report errors in virshInit()
by Daniel P. Berrange 20 Apr '17

20 Apr '17

There are several functions in virshInit which can fail, especially when running win32 builds under WINE. Currently virsh just exits without reporting what error happened. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- tools/virsh.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 31e23bd..90f8125 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -358,16 +358,22 @@ virshInit(vshControl *ctl) /* set up the library error handler */ virSetErrorFunc(NULL, vshErrorHandler); - if (virEventRegisterDefaultImpl() < 0) + if (virEventRegisterDefaultImpl() < 0) { + vshReportError(ctl); return false; + } - if (virThreadCreate(&ctl->eventLoop, true, vshEventLoop, ctl) < 0) + if (virThreadCreate(&ctl->eventLoop, true, vshEventLoop, ctl) < 0) { + vshReportError(ctl); return false; + } ctl->eventLoopStarted = true; if ((ctl->eventTimerId = virEventAddTimeout(-1, vshEventTimeout, ctl, - NULL)) < 0) + NULL)) < 0) { + vshReportError(ctl); return false; + } if (ctl->connname) { /* Connecting to a named connection must succeed, but we delay -- 2.9.3

2 2

[libvirt] [PATCH] Increase default task limit for libvirtd
by Jim Fehlig 20 Apr '17

20 Apr '17

libvirtd can spawn threads/tasks when creating new domains for some hypervisors such as Xen's libxl driver, quickly reaching the cgroups pids controller default TasksMax setting of 512. When the limit is reached, attempting to create additional domains results in an error from the cgroups pids controller, e.g. kernel: [71282.213347] cgroup: fork rejected by pids controller in /system.slice/libvirtd.service Depending on domain type and configuration, anywhere from 4-7 threads/tasks may be created by libxl when starting a domain. In order to support 4096 domains, similar to commit 27cd763500, increase the TasksMax setting in libvirtd.service to 4096 * 8 = 32768 tasks. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- daemon/libvirtd.service.in | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/daemon/libvirtd.service.in b/daemon/libvirtd.service.in index 899abdf37..fbaf02f3b 100644 --- a/daemon/libvirtd.service.in +++ b/daemon/libvirtd.service.in @@ -29,6 +29,11 @@ Restart=on-failure # If changing this, also consider virtlogd.service & virtlockd.service # limits which are also related to number of guests LimitNOFILE=8192 +# The cgroups pids controller can limit the number of tasks started by +# the daemon, which can limit the number of domains for some hypervisors. +# A conservative default of 8 tasks per guest results in a TasksMax of +# 32k to support 4096 guests. +TasksMax=32768 [Install] WantedBy=multi-user.target -- 2.11.0

2 1

[libvirt] increase daemon task limit
by Jim Fehlig 20 Apr '17

20 Apr '17

I recently received a report of a libvirt+Xen installation reaching the pids cgroup controller TasksMax limit kernel: [71282.213347] cgroup: fork rejected by pids controller in /system.slice/libvirtd.service The default setting of TaskMax is 512 on this system # cat /sys/fs/cgroup/pids/system.slice/libvirtd.service/pids.max 512 Depending on domain type and configuration, I've noticed between 5-7 tasks (IO threads, qemu process, etc.) are created when starting a domain. It doesn't take too many domains before the 512 limit is reached. LimitNOFILE was recently changed by commit 27cd763500 to support 4096 domains. Following similar logic, would it be ok to increase TasksMax to 32768? That would accommodate 4096 domains with 8 tasks each. TasksMax also supports the special value of "infinity", but that seems a bit aggressive to me. Regards, Jim

2 3

[libvirt] [PATCH] Fix error reporting when poll returns POLLHUP/POLLERR
by Daniel P. Berrange 20 Apr '17

20 Apr '17

In the RPC client event loop code, if poll() returns only a POLLHUP or POLLERR status, then we end up reporting a bogus error message: error: failed to connect to the hypervisor error: An error occurred, but the cause is unknown We do actually report an error, but we virNetClientMarkClose method has already captured the error status before we report it, so the real error gets thrown away. The key fix is to report the error before calling virNetClientMarkClose(). In changing this, we also split out reporting of POLLHUP vs POLLERR to make any future bugs easier to diagnose. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- src/rpc/virnetclient.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index 5174614..c959747 100644 --- a/src/rpc/virnetclient.c +++ b/src/rpc/virnetclient.c @@ -1743,10 +1743,16 @@ static int virNetClientIOEventLoop(virNetClientPtr client, if (error) goto error; - if (fds[0].revents & (POLLHUP | POLLERR)) { + if (fds[0].revents & POLLHUP) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("received hangup event on socket")); virNetClientMarkClose(client, VIR_CONNECT_CLOSE_REASON_EOF); + goto error; + } + if (fds[0].revents & POLLERR) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("received hangup / error event on socket")); + _("received error event on socket")); + virNetClientMarkClose(client, VIR_CONNECT_CLOSE_REASON_ERROR); goto error; } } -- 2.9.3

2 1

[libvirt] [PATCH v2] daemon: Fix domain name leak in error path
by Wang King 20 Apr '17

20 Apr '17

Domain name duplicated in make_nonnull_domain, but not freed when virTypedParamsSerialize return negative. Remove useless error label incidentally. --- daemon/remote.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/daemon/remote.c b/daemon/remote.c index 1610fea..d8a55c7 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -648,7 +648,7 @@ remoteRelayDomainEventBlockJob(virConnectPtr conn, /* build return data */ memset(&data, 0, sizeof(data)); if (VIR_STRDUP(data.path, path) < 0) - goto error; + return -1; data.type = type; data.status = status; make_nonnull_domain(&data.dom, dom); @@ -667,9 +667,6 @@ remoteRelayDomainEventBlockJob(virConnectPtr conn, } return 0; - error: - VIR_FREE(data.path); - return -1; } @@ -1025,7 +1022,7 @@ remoteRelayDomainEventBlockJob2(virConnectPtr conn, memset(&data, 0, sizeof(data)); data.callbackID = callback->callbackID; if (VIR_STRDUP(data.dst, dst) < 0) - goto error; + return -1; data.type = type; data.status = status; make_nonnull_domain(&data.dom, dom); @@ -1035,9 +1032,6 @@ remoteRelayDomainEventBlockJob2(virConnectPtr conn, (xdrproc_t)xdr_remote_domain_event_block_job_2_msg, &data); return 0; - error: - VIR_FREE(data.dst); - return -1; } @@ -1067,7 +1061,7 @@ remoteRelayDomainEventTunable(virConnectPtr conn, (virTypedParameterRemotePtr *) &data.params.params_val, &data.params.params_len, VIR_TYPED_PARAM_STRING_OKAY) < 0) - return -1; + goto error; remoteDispatchObjectEventSend(callback->client, remoteProgram, REMOTE_PROC_DOMAIN_EVENT_CALLBACK_TUNABLE, @@ -1075,6 +1069,10 @@ remoteRelayDomainEventTunable(virConnectPtr conn, &data); return 0; + error: + VIR_FREE(data.dom.name); + return -1; + } @@ -1207,13 +1205,16 @@ remoteRelayDomainEventJobCompleted(virConnectPtr conn, (virTypedParameterRemotePtr *) &data.params.params_val, &data.params.params_len, VIR_TYPED_PARAM_STRING_OKAY) < 0) - return -1; + goto error; remoteDispatchObjectEventSend(callback->client, remoteProgram, REMOTE_PROC_DOMAIN_EVENT_CALLBACK_JOB_COMPLETED, (xdrproc_t)xdr_remote_domain_event_callback_job_completed_msg, &data); return 0; + error: + VIR_FREE(data.dom.name); + return -1; } -- 2.8.3

2 1

[libvirt] [PATCH 0/2] qemu: hotplug: Write status XML only during successful vcpu hot(un)plug
by Peter Krempa 20 Apr '17

20 Apr '17

See the second patch. Peter Krempa (2): qemu: hotplug: Unexport qemuDomainHotplugDelVcpu qemu: hotplug: Don't save status XML when monitor is closed src/qemu/qemu_hotplug.c | 31 +++++++++++++++++-------------- src/qemu/qemu_hotplug.h | 3 --- 2 files changed, 17 insertions(+), 17 deletions(-) -- 2.12.2

2 3

[libvirt] [PATCH 0/9] qemu: More CPU enhancements and fixes
by Jiri Denemark 19 Apr '17

19 Apr '17

This is technically a v2 of the not yet pushed part of "qemu: Use migratable host CPU model from QEMU" series, but the patches were significantly rewritten based on the review comments and on the need for additional regression fix. Current libvirt makes a migratable host CPU model by removing features marked in cpu_map.xml with migratable='no'. This is not ideal because cpu_map.xml is a static database while feature migratability may differ depending on a hypervisor or its version. Thus we should preferably use the data we got from QEMU. And to make things even more complicated, we need to use both CPUID data we probed and data from QEMU when checking whether a guest CPU can run on the host to maintain backward compatibility with older libvirt. Thus we need to store three different views of the host CPU model with each QEMU binary. Jiri Denemark (9): qemu: Introduce virQEMUCapsSetHostModel qemu: Move qemuCaps CPU data copying into a separate function qemu: Introduce virQEMUCapsHostCPUDataClear qemu: Move qemuCaps host CPU data in a struct qemu: Prepare qemuCaps for multiple host CPU defs qemu: Pass migratable host CPU model to virCPUUpdate cpu: Drop feature filtering from virCPUUpdate cpu: Introduce virCPUGetHostIsSupported qemu: Use more data for comparing CPUs src/cpu/cpu.c | 20 +++ src/cpu/cpu.h | 3 + src/cpu/cpu_x86.c | 9 +- src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 288 +++++++++++++++++++++++++++++-------------- src/qemu/qemu_capabilities.h | 16 ++- src/qemu/qemu_command.c | 3 +- src/qemu/qemu_process.c | 6 +- tests/cputest.c | 7 +- 9 files changed, 247 insertions(+), 106 deletions(-) -- 2.12.2

2 19

[libvirt] [PATCH] virt-storage-rbd: fix typo s/RDB/RBD/ in configure check
by Daniel P. Berrange 19 Apr '17

19 Apr '17

Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- Pushed as trivial build fix. m4/virt-storage-rbd.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/virt-storage-rbd.m4 b/m4/virt-storage-rbd.m4 index 727bd71..17e2115 100644 --- a/m4/virt-storage-rbd.m4 +++ b/m4/virt-storage-rbd.m4 @@ -36,7 +36,7 @@ AC_DEFUN([LIBVIRT_STORAGE_CHECK_RBD], [ LIBS="$old_LIBS" fi - if test "$LIBRDB_FOUND" = "yes"; then + if test "$LIBRBD_FOUND" = "yes"; then with_storage_rbd=yes AC_DEFINE_UNQUOTED([WITH_STORAGE_RBD], [1], [whether RBD backend for storage driver is enabled]) -- 2.9.3

1 0

[libvirt] [PATCH v3 0/2] default USB controller for PPC
by Pavel Hrdina 19 Apr '17

19 Apr '17

Pavel Hrdina (2): conf: add a new parse flag VIR_DOMAIN_DEF_PARSE_ABI_UPDATE_MIGRATION qemu_domain: use correct default USB controller on ppc64 src/conf/domain_conf.c | 3 ++- src/conf/domain_conf.h | 4 ++++ src/qemu/qemu_domain.c | 16 ++++++++++++---- src/qemu/qemu_migration_cookie.c | 2 +- 4 files changed, 19 insertions(+), 6 deletions(-) -- 2.12.2

2 3

[libvirt] [PATCH 0/2] autogen.sh: Rewrite and modularize
by Andrea Bolognani 19 Apr '17

19 Apr '17

This work was motivated by Dan's intention to introduce the keycodemapdb module into libvirt[1]. As it is, we have a few useful submodule-related features in our build system, but they are limited in that they assume there will be a single submodule, and it will be gnulib. This series removes such assumptions, making it possible to introduce more submodules without having to sacrifice any convenience. [1] https://www.redhat.com/archives/libvir-list/2017-March/msg00136.html Andrea Bolognani (2): autogen.sh: Rewrite autogen.sh: Modularize .gitignore | 2 +- .submodules/gnulib.functions | 65 ++++++++++ autogen.sh | 286 +++++++++++++++++++++++++++++-------------- cfg.mk | 34 ++--- 4 files changed, 265 insertions(+), 122 deletions(-) create mode 100644 .submodules/gnulib.functions -- 2.7.4

2 7

[libvirt] [PATCH] spec: Avoid RPM verification errors on nwfilter XMLs
by Jiri Denemark 19 Apr '17

19 Apr '17

/etc/libvirt/nwfilter/*.xml files are installed with no UUID, which means libvirtd will automatically alter all of them once it starts. Thus RPM verification will always fail on them. Let's use a trick similar to the default network XML and store nwfilter XMLs in /usr/share. They will be copied into /etc in %post. Additionally the /etc files are marked as %ghost so that they are uninstalled if the RPM package is removed. Note that the %post script overwrites existing files with new ones on upgrade, which is what has always been happening. https://bugzilla.redhat.com/show_bug.cgi?id=1431581 https://bugzilla.redhat.com/show_bug.cgi?id=1378774 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- libvirt.spec.in | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 1d249851a..78c3c28e1 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1360,6 +1360,13 @@ cp $RPM_BUILD_ROOT%{_sysconfdir}/libvirt/qemu/networks/default.xml \ $RPM_BUILD_ROOT%{_datadir}/libvirt/networks/default.xml rm -f $RPM_BUILD_ROOT%{_sysconfdir}/libvirt/qemu/networks/default.xml rm -f $RPM_BUILD_ROOT%{_sysconfdir}/libvirt/qemu/networks/autostart/default.xml + +# nwfilter files are installed in /usr/share/libvirt and copied to /etc in %post +# to avoid verification errors on changed files in /etc +install -d -m 0755 $RPM_BUILD_ROOT%{_datadir}/libvirt/nwfilter/ +cp -a $RPM_BUILD_ROOT%{_sysconfdir}/libvirt/nwfilter/*.xml \ + $RPM_BUILD_ROOT%{_datadir}/libvirt/nwfilter/ + # Strip auto-generated UUID - we need it generated per-install sed -i -e "/<uuid>/d" $RPM_BUILD_ROOT%{_datadir}/libvirt/networks/default.xml %if ! %{with_qemu} @@ -1586,6 +1593,17 @@ if test $1 -eq 1 && test ! -f %{_sysconfdir}/libvirt/qemu/networks/default.xml ; fi + +%post daemon-config-nwfilter +cp %{_datadir}/libvirt/nwfilter/*.xml %{_sysconfdir}/libvirt/nwfilter/ +# Make sure libvirt picks up the new nwfilter defininitons +%if %{with_systemd} + /bin/systemctl try-restart libvirtd.service >/dev/null 2>&1 ||: +%else + /sbin/service libvirtd condrestart > /dev/null 2>&1 || : +%endif + + %if %{with_systemd} %triggerun -- libvirt < 0.9.4 %{_bindir}/systemd-sysv-convert --save libvirtd >/dev/null 2>&1 ||: @@ -1767,7 +1785,9 @@ exit 0 %{_datadir}/libvirt/networks/default.xml %files daemon-config-nwfilter -%{_sysconfdir}/libvirt/nwfilter/*.xml +%dir %{_datadir}/libvirt/nwfilter/ +%{_datadir}/libvirt/nwfilter/*.xml +%ghost %{_sysconfdir}/libvirt/nwfilter/*.xml %files daemon-driver-interface %{_libdir}/%{name}/connection-driver/libvirt_driver_interface.so -- 2.12.2

2 4

[libvirt] [libvirt-perl][PATCH] Fix typo in NodeDevice.pm
by Dan Zheng 19 Apr '17

19 Apr '17

In commit 24a7f8b41ed09e885120af5336de69d3d4c91980, node device events were written with storage pool prefix by mistake. Signed-off-by: Dan Zheng <dzheng(a)redhat.com> --- lib/Sys/Virt/NodeDevice.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Sys/Virt/NodeDevice.pm b/lib/Sys/Virt/NodeDevice.pm index 97a5fad..3528c41 100644 --- a/lib/Sys/Virt/NodeDevice.pm +++ b/lib/Sys/Virt/NodeDevice.pm @@ -193,11 +193,11 @@ reason though the reason is currently unsed. =over 4 -=item Sys::Virt::StoragePool::EVENT_CREATED +=item Sys::Virt::NodeDevice::EVENT_CREATED Indicates that a device was created -=item Sys::Virt::StoragePool::EVENT_DELETED +=item Sys::Virt::NodeDevice::EVENT_DELETED Indicates that a device has been deleted -- 1.8.3.1

2 1

[libvirt] server side copy from one volume to another
by Vasiliy Tolstov 19 Apr '17

19 Apr '17

Hi! I have two pools pool_a and pool_b and need to copy volume from pool_a to pool_b. Now i can use volume download/upload to transfer data, but this is not optimal because all traffic goes via client. Does it possible to signal libvirt copy volume from pool_a to pool_b not transfer all data via client? Like server side copy? If this is not possible - may be someone from redhat team can do that? (Or provide some tips how can i do that?) -- Vasiliy Tolstov, e-mail: v.tolstov(a)selfip.ru

4 12

[libvirt] Incompatible CPU after upgrading qemu
by Jim Fehlig 19 Apr '17

19 Apr '17

Hi All, I've been doing some upgrade testing and noticed a problem starting some existing VMs after upgrading qemu from 2.6 to 2.9 on one of my AMD machines. Using libvirt 3.2.0 and qemu 2.6, I have no problems starting a VM with the following machine/CPU config <os> <type arch='x86_64' machine='pc-i440fx-2.6'>hvm</type> <boot dev='hd'/> </os> <cpu mode='custom' match='exact'> <model fallback='allow'>Opteron_G4</model> </cpu> After upgrading qemu to 2.9 the VM fails to start with error: the CPU is incompatible with host CPU: Host CPU does not provide required features: svm I see that qemu commit 75d373ef disables SVM in KVM mode, but that change was made quite some time ago and pertains to all machine types > pc-i440fx-2.2. Perhaps the problem was revealed by Jiri's recent libvirt changes to detect host CPU model by asking qemu? My knee-jerk reaction is to remove 'svm' from Opteron CPUs in cpu_map.xml, but I'm far from the expert on the evolving CPU code in libvirt, so asking the experts here for some guidance. Regards, Jim

2 2

[libvirt] [PATCH 0/6] Hyper-V method invocation support
by Sri Ramanujam 18 Apr '17

18 Apr '17

This patchset introduces functionality to support invoking Hyper-V methods over WMI. It also includes implementations for virDomainSendKey and virDomainSetMemory as examples of how to use the new functionality. With this patchset, all the pieces should be in place to implement all parts of the driver. I've got about 30 functions pending, to be submitted after this patchset is ACKed. Additionally, this patchset includes a new function under util that converts numbers into their string representation. There is a variant for both signed and unsigned numbers. Since everything must be represented as a string at the XML layer, this function comes in handy throughout the Hyper-V driver and I thought it would have some utility as a convenience method for the whole project. Sri Ramanujam (6): hyperv: Functions to work with invocation parameters. hyperv: Generate object property type information. hyperv: add hypervInvokeMethod hyperv: support virDomainSendKey util: add virNumToStr hyperv: Add support for virDomainSetMemory src/hyperv/hyperv_driver.c | 182 +++++++ src/hyperv/hyperv_wmi.c | 879 ++++++++++++++++++++++++++++++++++ src/hyperv/hyperv_wmi.h | 93 +++- src/hyperv/hyperv_wmi_classes.h | 19 + src/hyperv/hyperv_wmi_generator.input | 116 +++++ src/hyperv/hyperv_wmi_generator.py | 15 +- src/hyperv/openwsman.h | 4 + src/util/virstring.c | 34 ++ src/util/virstring.h | 8 + 9 files changed, 1348 insertions(+), 2 deletions(-) -- 2.9.3

2 8

[libvirt] [PATCH v3] hyperv: recognize array property as distinct type.
by Dawid Zamirski 18 Apr '17

18 Apr '17

When hyperv code generator for WMI classes identifies common properties, it needs to take into account array type as a distinct type, i.e string != string[]. This is the case where v1 of the Msvm_VirtualSystemSettingData has Notes property as string whereas v2 uses Notes[], therefore they have to be treated as different fields and cannot be placed in the "common" struct. --- changes in v3: * add virBufferCheckError before calling virBufferContentAndReset. src/hyperv/hyperv_driver.c | 28 ++++++++++++++++++++++++++-- src/hyperv/hyperv_wmi_generator.py | 2 +- 2 files changed, 27 insertions(+), 3 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 090ea24..8e5eeda 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c @@ -894,8 +894,32 @@ hypervDomainGetXMLDesc(virDomainPtr domain, unsigned int flags) if (VIR_STRDUP(def->name, computerSystem->data.common->ElementName) < 0) goto cleanup; - if (VIR_STRDUP(def->description, virtualSystemSettingData->data.common->Notes) < 0) - goto cleanup; + if (priv->wmiVersion == HYPERV_WMI_VERSION_V1) { + if (VIR_STRDUP(def->description, + virtualSystemSettingData->data.v1->Notes) < 0) + goto cleanup; + } else if (priv->wmiVersion == HYPERV_WMI_VERSION_V2 && + virtualSystemSettingData->data.v2->Notes.data != NULL) { + char **notes = (char **) virtualSystemSettingData->data.v2->Notes.data; + virBuffer buf = VIR_BUFFER_INITIALIZER; + size_t i = 0; + + /* in practice Notes has 1 element */ + for (i = 0; i < virtualSystemSettingData->data.v2->Notes.count; i++) { + /* but if there's more than 1, separate by double new line */ + if (virBufferUse(&buf) > 0) + virBufferAddLit(&buf, "\n\n"); + + virBufferAdd(&buf, *notes, -1); + notes++; + } + + if (virBufferCheckError(&buf)) + cleanup; + + def->description = virBufferContentAndReset(&buf); + } + virDomainDefSetMemoryTotal(def, memorySettingData->data.common->Limit * 1024); /* megabyte to kilobyte */ def->mem.cur_balloon = memorySettingData->data.common->VirtualQuantity * 1024; /* megabyte to kilobyte */ diff --git a/src/hyperv/hyperv_wmi_generator.py b/src/hyperv/hyperv_wmi_generator.py index c15d97a..9aee0b9 100755 --- a/src/hyperv/hyperv_wmi_generator.py +++ b/src/hyperv/hyperv_wmi_generator.py @@ -251,7 +251,7 @@ class WmiClass: for cls in self.versions: for prop in cls.properties: # consdered same if matches by name AND type - key = "%s_%s" % (prop.name, prop.type) + key = "%s_%s_%s" % (prop.name, prop.type, prop.is_array) if key in property_info: property_info[key][1] += 1 -- 2.9.3

2 1

[libvirt] [PATCH] xenconfig: avoid double free on OOM testing
by Jim Fehlig 18 Apr '17

18 Apr '17

Fix xlconfig channel tests when OOM testing is enabled. TEST: xlconfigtest 32) Xen XL-2-XML Format channel-unix ... OK Test OOM for nalloc=55 ................................................*** Error in `/home/jfehlig/virt/upstream/libvirt/tests/.libs/xlconfigtest': double free or corruption (fasttop): 0x0000000000679550 *** ... (gdb) bt #0 0x00007ffff36875af in raise () from /lib64/libc.so.6 #1 0x00007ffff36889aa in abort () from /lib64/libc.so.6 #2 0x00007ffff36c5150 in __libc_message () from /lib64/libc.so.6 #3 0x00007ffff36cb4f6 in malloc_printerr () from /lib64/libc.so.6 #4 0x00007ffff36cbcee in _int_free () from /lib64/libc.so.6 #5 0x00007ffff782babf in virFree (ptrptr=0x7fffffffdca8) at util/viralloc.c:582 #6 0x000000000042f2f3 in xenParseXLChannel (conf=0x677350, def=0x6815b0) at xenconfig/xen_xl.c:788 #7 0x000000000042f44e in xenParseXL (conf=0x677350, caps=0x6832b0, xmlopt=0x67f6e0) at xenconfig/xen_xl.c:828 #8 0x00000000004105a3 in testCompareFormatXML ( xlcfg=0x6811e0 "/home/jfehlig/virt/upstream/libvirt/tests/xlconfigdata/test-channel-unix.cfg", xml=0x681110 "/home/jfehlig/virt/upstream/libvirt/tests/xlconfigdata/test-channel-unix.xml", replaceVars=false) at xlconfigtest.c:152 When a channel is successfully parsed and its path and name fields assigned from local variables, set the local variables to NULL to prevent a double free on error. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- src/xenconfig/xen_xl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c index 43ecf4114..a5b342a86 100644 --- a/src/xenconfig/xen_xl.c +++ b/src/xenconfig/xen_xl.c @@ -759,8 +759,9 @@ xenParseXLChannel(virConfPtr conf, virDomainDefPtr def) if (STRPREFIX(type, "socket")) { channel->source->type = VIR_DOMAIN_CHR_TYPE_UNIX; - channel->source->data.nix.path = path; channel->source->data.nix.listen = 1; + channel->source->data.nix.path = path; + path = NULL; } else if (STRPREFIX(type, "pty")) { channel->source->type = VIR_DOMAIN_CHR_TYPE_PTY; VIR_FREE(path); @@ -771,6 +772,7 @@ xenParseXLChannel(virConfPtr conf, virDomainDefPtr def) channel->deviceType = VIR_DOMAIN_CHR_DEVICE_TYPE_CHANNEL; channel->targetType = VIR_DOMAIN_CHR_CHANNEL_TARGET_TYPE_XEN; channel->target.name = name; + name = NULL; if (VIR_APPEND_ELEMENT(def->channels, def->nchannels, channel) < 0) goto cleanup; -- 2.11.0

2 2

[libvirt] VHPC at ISC extension - Papers due May 2
by VHPC 17 18 Apr '17

18 Apr '17

==================================================================== CALL FOR PAPERS 12th Workshop on Virtualization in High-Performance Cloud Computing (VHPC '17) held in conjunction with the International Supercomputing Conference - High Performance, June 18-22, 2017, Frankfurt, Germany. (Springer LNCS Proceedings) ==================================================================== Date: June 22, 2017 Workshop URL: http://vhpc.org Paper Submission Deadline: May 2, 2017 (extended), Springer LNCS, rolling abstract submission Abstract/Paper Submission Link: https://edas.info/newPaper.php?c=23179 Keynotes: Satoshi Matsuoka, Professor of Computer Science, Tokyo Institute of Technology and John Goodacre, Professor in Computer Architectures University of Manchester, Director of Technology and Systems ARM Ltd. Research Group and Chief Scientific Officer Kaleao Ltd. Call for Papers Virtualization technologies constitute a key enabling factor for flexible resource management in modern data centers, and particularly in cloud environments. Cloud providers need to manage complex infrastructures in a seamless fashion to support the highly dynamic and heterogeneous workloads and hosted applications customers deploy. Similarly, HPC environments have been increasingly adopting techniques that enable flexible management of vast computing and networking resources, close to marginal provisioning cost, which is unprecedented in the history of scientific and commercial computing. Various virtualization technologies contribute to the overall picture in different ways: machine virtualization, with its capability to enable consolidation of multiple underutilized servers with heterogeneous software and operating systems (OSes), and its capability to live-migrate a fully operating virtual machine (VM) with a very short downtime, enables novel and dynamic ways to manage physical servers; OS-level virtualization (i.e., containerization), with its capability to isolate multiple user-space environments and to allow for their coexistence within the same OS kernel, promises to provide many of the advantages of machine virtualization with high levels of responsiveness and performance; I/O Virtualization allows physical NICs/HBAs to take traffic from multiple VMs or containers; network virtualization, with its capability to create logical network overlays that are independent of the underlying physical topology and IP addressing, provides the fundamental ground on top of which evolved network services can be realized with an unprecedented level of dynamicity and flexibility; the increasingly adopted paradigm of Software-Defined Networking (SDN) promises to extend this flexibility to the control and data planes of network paths. Publication Accepted papers will be published in a Springer LNCS proceedings volume. Topics of Interest The VHPC program committee solicits original, high-quality submissions related to virtualization across the entire software stack with a special focus on the intersection of HPC and the cloud. Major Topics - Virtualization in supercomputing environments, HPC clusters, HPC in the cloud and grids - OS-level virtualization and containers (Docker, rkt, Singularity, Shifter, i.a.) - Lightweight/specialized operating systems, unikernels - Optimizations of virtual machine monitor platforms and hypervisors - Hypervisor support for heterogenous resources (GPUs, co-processors, FPGAs, etc.) - Virtualization support for emerging memory technologies - Virtualization in enterprise HPC and microvisors - Software defined networks and network virtualization - Management, deployment of virtualized environments and orchestration (Kubernetes i.a.), - Workflow-pipeline container-based composability - Performance measurement, modelling and monitoring of virtualized/cloud workloads - Virtualization in data intensive computing and Big Data processing - HPC convergence - Adaptation of HPC technologies in the cloud (high performance networks, RDMA, etc.) - ARM-based hypervisors, ARM virtualization extensions - I/O virtualization and cloud based storage systems - GPU, FPGA and many-core accelerator virtualization - Job scheduling/control/policy and container placement in virtualized environments - Cloud reliability, fault-tolerance and high-availability - QoS and SLA in virtualized environments - IaaS platforms, cloud frameworks and APIs - Large-scale virtualization in domains such as finance and government - Energy-efficient and power-aware virtualization - Container security - Configuration management tools for containers (including CFEngine, Puppet, i.a.) - Emerging topics including multi-kernel approaches and,NUMA in hypervisors The Workshop on Virtualization in High-Performance Cloud Computing (VHPC) aims to bring together researchers and industrial practitioners facing the challenges posed by virtualization in order to foster discussion, collaboration, mutual exchange of knowledge and experience, enabling research to ultimately provide novel solutions for virtualized computing systems of tomorrow. The workshop will be one day in length, composed of 20 min paper presentations, each followed by 10 min discussion sections, plus lightning talks that are limited to 5 minutes. Presentations may be accompanied by interactive demonstrations. Important Dates Rolling Abstract Submission May 2, 2017 - Paper submission deadline (extended) May 30, 2017 - Acceptance notification June 22, 2017 - Workshop Day July 18, 2017 - Camera-ready version due Chair Michael Alexander (chair), scaledinfra technologies, Austria Anastassios Nanos (co-chair), NTUA, Greece Balazs Gerofi (co-chair), RIKEN Advanced Institute for Computational Science, Japan Program committee Stergios Anastasiadis, University of Ioannina, Greece Jakob Blomer, CERN, Europe Ron Brightwell, Sandia National Laboratories, USA Eduardo César, Universidad Autonoma de Barcelona, Spain Julian Chesterfield, OnApp, UK Stephen Crago, USC ISI, USA Christoffer Dall, Columbia University, USA Patrick Dreher, MIT, USA Robert Futrick, Cycle Computing, USA Maria Girone, CERN, Europe Kyle Hale, Northwestern University, USA Romeo Kinzler, IBM, Switzerland Brian Kocoloski, University of Pittsburgh, USA Nectarios Koziris, National Technical University of Athens, Greece John Lange, University of Pittsburgh, USA Che-Rung Lee, National Tsing Hua University, Taiwan Giuseppe Lettieri, University of Pisa, Italy Qing Liu, Oak Ridge National Laboratory, USA Nikos Parlavantzas, IRISA, France Kevin Pedretti, Sandia National Laboratories, USA Amer Qouneh, University of Florida, USA Carlos Reaño, Technical University of Valencia, Spain Thomas Ryd, CFEngine, Norway Na Zhang, VMWare, USA Borja Sotomayor, University of Chicago, USA Craig Stewart, Indiana University, USA Anata Tiwari, San Diego Supercomputer Center, USA Kurt Tutschku, Blekinge Institute of Technology, Sweden Yasuhiro Watashiba, Osaka University, Japan Nicholas Wright, Lawrence Berkeley National Laboratory, USA Chao-Tung Yang, Tunghai University, Taiwan Paper Submission-Publication Papers submitted to the workshop will be reviewed by at least two members of the program committee and external reviewers. Submissions should include abstract, key words, the e-mail address of the corresponding author, and must not exceed 10 pages, including tables and figures at a main font size no smaller than 11 point. Submission of a paper should be regarded as a commitment that, should the paper be accepted, at least one of the authors will register and attend the conference to present the work. Accepted papers will be published in a Springer LNCS volume. . The format must be according to the Springer LNCS Style. Initial submissions are in PDF; authors of accepted papers will be requested to provide source files. Format Guidelines: ftp://ftp.springer.de/pub/tex/latex/llncs/latex2e/llncs2e.zip Abstract, Paper Submission Link: https://edas.info/newPaper.php?c=23179 Lightning Talks Lightning Talks are non-paper track, synoptical in nature and are strictly limited to 5 minutes. They can be used to gain early feedback on ongoing research, for demonstrations, to present research results, early research ideas, perspectives and positions of interest to the community. Submit abstract via the main submission link. General Information The workshop is one day in length and will be held in conjunction with the International Supercomputing Conference - High Performance (ISC) 2017, June 18-22, Frankfurt, Germany.

1 0

[libvirt] [RFC PATCH 00/11] Add mdev reporting capability to the nodedev driver
by Erik Skultety 18 Apr '17

18 Apr '17

This series enables the node device driver to report information about the existing mediated devices on the host. There is no device creation involved yet. The information reported by the node device driver is split into two parts, one that is reported within the physical parent's capabilities (the generic stuff that comes from the mdev types' sysfs attributes, note the 'description' attribute which is verbatim - raw,unstructured string) and the other that is reported within the mdev child device and merely contains the mdev type id, which the device was instantiated from, and the iommu group number. Basically, the format of the XML I went for is as follows: PCI parent: <device> <name>pci_0000_06_00_0</name> <path>/sys/devices/.../0000:06:00.0</path> <parent>pci_0000_05_08_0</parent> ... <capability type='pci'> ... <capability type='mdev'> <type id='nvidia-11'> <name>GRID M60-0B</name> <description>num_heads=2, frl_config=45, framebuffer=512M, max_resolution=2560x1600, max_instance=16</description> <device_api>vfio-pci</device_api> <available_instances>16</available_instances> </type> ... </capability> <iommuGroup number='20'> <address domain='0x0000' bus='0x06' slot='0x00' function='0x0'/> </iommuGroup> ... </capability> </device> mdev child: <device> <name>mdev_ef1212ff_ff23_4534_ffcd_01ff12017801</name> <path>/sys/devices/.../ef1212ff-ff23-4534-ffcd-01ff12017801</path> <parent>pci_0000_06_00_0</parent> <driver> <name>vfio_mdev</name> </driver> <capability type='mdev'> <type id='nvidia-18'/> <iommuGroup number='63'/> </capability> </device> Also, since we didn't have any node device driver documentation, I created a stub (comments are very welcome, you can shred it to pieces ;)) focusing on the PCI devices and then adding the mdev part into that. As I said, it's still a stub that needs lots of work on it, namely adding USBs and SCSI devices, but I figured that the fact some parts are missing should not be a show stopper for the nodedev-mdev patches. Thanks, Erik Erik Skultety (11): nodedev: Fix guideline violations in nodedev modules nodedev: Make use of the compile-time missing enum in switch error conf: nodedev: Split virNodeDeviceDefFormat into more functions nodedev: udevProcessPCI: Drop syspath variable docs: Use our XSLT template to generate list of supported pool types nodedev: Introduce the mdev capability to the nodedev driver structure nodedev: Fill in the mdev info for the parent PCI device nodedev: Introduce udevProcessMediatedDevice nodedev: Format the mdev capability of the PCI parent device docs: Provide a nodedev driver stub documentation docs: Document the mediated devices within the nodedev driver docs/drivers.html.in | 6 +- docs/drvnodedev.html.in | 275 +++++++++++++ docs/storage.html.in | 62 +-- include/libvirt/libvirt-nodedev.h | 1 + src/conf/node_device_conf.c | 625 ++++++++++++++++++------------ src/conf/node_device_conf.h | 21 +- src/conf/virnodedeviceobj.c | 3 +- src/libvirt-nodedev.c | 1 + src/libvirt_private.syms | 1 + src/node_device/node_device_driver.c | 30 +- src/node_device/node_device_driver.h | 82 ++-- src/node_device/node_device_hal.c | 9 + src/node_device/node_device_linux_sysfs.c | 1 + src/node_device/node_device_linux_sysfs.h | 9 +- src/node_device/node_device_udev.c | 456 ++++++++++++++++------ tools/virsh-nodedev.c | 2 + 16 files changed, 1110 insertions(+), 474 deletions(-) create mode 100644 docs/drvnodedev.html.in -- 2.12.2

6 29

[libvirt] Trouble with virsh on Windows
by Charles Bancroft 18 Apr '17

18 Apr '17

Hi List, I have a question about some troubles I am having with virsh on Windows x64. I am currently running a KVM server on a linux box and need to allow Windows clients to access it. I have set up the server for access with: ``` listen_tls = 0 listen_tcp = 1 auth_tcp = "none" ``` to allow for remote access while testing things. I have verified that I can connect remotely from other linux machines, but my windows machine always reports: ``` error: failed to connect to the hypervisor error: An error occurred, but the cause is unknown ``` On the server side I see: ``` 10435: error : virNetSocketReadWire:1793 : Cannot recv data: Connection reset by peer ``` This happens no matter what build of virsh for windows I am using. I have tried 3 different mingw-64 builds and versions and am about to just build my own from scratch. I have verified that it is not the firewall or the version of Windows I am using. I am also able to use virsh within a docker or from the Windows Subsystem for Linux bash prompt. Any ideas as to what could be causing this connection reset? It happens as soon as a connection attempt occurs and I am running out of idea. Thanks! Charles Bancroft Principal Scientist Siege Technologies

2 6

[libvirt] [PATCH v2 0/2] Use the shared keycodemap database
by Daniel P. Berrange 18 Apr '17

18 Apr '17

Changed in v2: - Fixed make syntax-check errors - Auto-generate man pages listing value key codes for use with the virDomainSendKey API / virsh send-key command Daniel P. Berrange (2): util: switch over to use keycodemapdb GIT submodule Add ability to generate man page describing key code names & values .gitignore | 3 +- .gitmodules | 3 + libvirt.spec.in | 1 + mingw-libvirt.spec.in | 2 + src/Makefile.am | 81 ++++++-- src/keycodemapdb | 1 + src/util/keymaps.csv | 464 ------------------------------------------ src/util/virkeycode-mapgen.py | 97 --------- src/util/virkeycode.c | 94 ++++----- tests/virkeycodetest.c | 5 + tools/virsh.pod | 20 ++ 11 files changed, 148 insertions(+), 623 deletions(-) create mode 160000 src/keycodemapdb delete mode 100644 src/util/keymaps.csv delete mode 100755 src/util/virkeycode-mapgen.py -- 2.9.3

2 9

[libvirt] [REPOST PATCH 0/5] Split out network object into its own module
by John Ferlan 18 Apr '17

18 Apr '17

Reposting with update to top of git tree commit id '0563d3f06' from: https://www.redhat.com/archives/libvir-list/2017-March/msg00892.html Previous cover letter - cut-n-pasted: Reached the last of the code from my RFC for making a common pool object - networkobj... For reference see patch 3 of: http://www.redhat.com/archives/libvir-list/2017-February/msg00519.html This series works through the network conf adjustments. This pile is fairly straightforward, like other series we split out anything referencing virNetworkPoolObj and go from there. There was one small detour to avoid a potentially conflict in names. John Ferlan (5): conf: Introduce virnetworkobj conf: Adjust coding style for network conf sources conf: Alter coding style of network conf function prototypes conf: Rename virNetworkObjAssignDef to virNetworkObjUpdateAssignDef conf: Use consistent function name prefixes for virnetworkobj po/POTFILES.in | 1 + src/Makefile.am | 3 +- src/conf/network_conf.c | 1388 ++-------------------------------- src/conf/network_conf.h | 204 ++--- src/conf/virnetworkobj.c | 1372 +++++++++++++++++++++++++++++++++ src/conf/virnetworkobj.h | 185 +++++ src/libvirt_private.syms | 57 +- src/network/bridge_driver.c | 62 +- src/network/bridge_driver.h | 2 +- src/network/bridge_driver_platform.h | 2 +- src/test/test_driver.c | 16 +- 11 files changed, 1763 insertions(+), 1529 deletions(-) create mode 100644 src/conf/virnetworkobj.c create mode 100644 src/conf/virnetworkobj.h -- 2.9.3

2 6

[libvirt] [PATCH 00/38] Implement sparse streams for libvirt
by Michal Privoznik 18 Apr '17

18 Apr '17

There were already some attempts to do this in the past, but neither of them was successful. Anyway, let me just show you how good these perform: 7.9G -rw-r--r-- 1 root root 21G Feb 15 14:04 /var/lib/libvirt/images/gentoo.qcow2 libvirt.git # time virsh vol-download --sparse /var/lib/libvirt/images/gentoo.qcow2 /mnt/floppy/gentoo.qcow2 real 0m41.627s user 0m3.880s sys 0m5.720s libvirt.git # time virsh vol-download /var/lib/libvirt/images/gentoo.qcow2 /mnt/floppy/gentoo.qcow2 real 2m22.357s user 1m20.590s sys 0m12.510s All the patches can be found on my github: https://github.com/zippy2/libvirt/tree/sparse_iohelper5 (Yes, weird name, but there were plenty of local attempts to implement this and I'm not throwing them away until the feature is merged) Michal Privoznik (38): fdstreamtest: Rename tempdir fdstreamtest: Print more info on read failure fdstream: s/struct virFDStreamData */virFDStreamDataPtr/ virFDStreamData: Turn into virObjectLockable virfdstream: Drop iohelper in favour of a thread virfdstream: Use messages instead of pipe iohelper: Remove unused mode util: Introduce virFileInData Introduce virStreamRecvFlags Implement virStreamRecvFlags to some drivers Introduce virStreamSkip Introduce virStreamHoleSize Introduce VIR_STREAM_RECV_STOP_AT_HOLE flag Introduce virStreamSparseRecvAll Introduce virStreamSparseSendAll Introduce virStreamInData virNetClientStreamNew: Track origin stream Track if stream is skippable RPC: Introduce virNetStreamSkip Introduce VIR_NET_STREAM_SKIP message type Teach wireshark plugin about VIR_NET_STREAM_SKIP daemon: Introduce virNetServerProgramSendStreamSkip virnetclientstream: Introduce virNetClientStreamSendSkip daemon: Implement VIR_NET_STREAM_SKIP handling virnetclientstream: Introduce virNetClientStreamHandleSkip remote_driver: Implement virStreamSkip virNetClientStreamRecvPacket: Introduce @flags argument Introduce virNetClientStreamHoleSize remote: Implement virStreamHoleSize virNetClientStream: Wire up VIR_NET_STREAM_SKIP remote_driver: Implement VIR_STREAM_RECV_STOP_AT_HOLE daemonStreamHandleRead: Wire up seekable stream daemon: Don't call virStreamInData so often fdstream: Implement sparse stream gendispatch: Introduce @sparseflag for our calls Introduce virStorageVol{Download,Upload}Flags virsh: Implement sparse stream to vol-download virsh: Implement sparse stream to vol-upload daemon/remote.c | 2 +- daemon/stream.c | 147 +++++- daemon/stream.h | 3 +- include/libvirt/libvirt-storage.h | 9 + include/libvirt/libvirt-stream.h | 86 +++- src/driver-stream.h | 23 + src/esx/esx_stream.c | 16 +- src/libvirt-storage.c | 4 +- src/libvirt-stream.c | 453 ++++++++++++++++++ src/libvirt_internal.h | 3 + src/libvirt_private.syms | 2 + src/libvirt_public.syms | 9 + src/libvirt_remote.syms | 3 + src/remote/remote_driver.c | 89 +++- src/remote/remote_protocol.x | 2 + src/rpc/gendispatch.pl | 21 +- src/rpc/virnetclient.c | 1 + src/rpc/virnetclientstream.c | 202 +++++++- src/rpc/virnetclientstream.h | 17 +- src/rpc/virnetprotocol.x | 16 +- src/rpc/virnetserverprogram.c | 33 ++ src/rpc/virnetserverprogram.h | 7 + src/storage/storage_driver.c | 4 +- src/storage/storage_util.c | 10 +- src/util/iohelper.c | 72 +-- src/util/virfdstream.c | 888 ++++++++++++++++++++++++++++------- src/util/virfdstream.h | 2 +- src/util/virfile.c | 81 ++++ src/util/virfile.h | 3 + src/virnetprotocol-structs | 4 + tests/fdstreamtest.c | 12 +- tests/virfiletest.c | 203 ++++++++ tools/virsh-util.c | 49 ++ tools/virsh-util.h | 24 + tools/virsh-volume.c | 49 +- tools/virsh.pod | 6 +- tools/wireshark/src/packet-libvirt.c | 48 ++ tools/wireshark/src/packet-libvirt.h | 2 + 38 files changed, 2284 insertions(+), 321 deletions(-) -- 2.10.2

2 44

[libvirt] [PATCH 0/4] domain capabilities fix and test improvement
by Pavel Hrdina 18 Apr '17

18 Apr '17

Pavel Hrdina (4): qemu: refactor qemuDomainMachineIs* and qemuDomainMachineNeedsFDC qemu: use qemuDomainMachineIsPSeries qemu: report IDE bus in domain capabilities only if it's supported tests: domaincapstest: add test for Q35 machine type src/qemu/qemu_alias.c | 4 +- src/qemu/qemu_capabilities.c | 20 ++-- src/qemu/qemu_command.c | 42 +++---- src/qemu/qemu_domain.c | 79 ++++++------- src/qemu/qemu_domain.h | 14 +-- src/qemu/qemu_domain_address.c | 16 +-- src/qemu/qemu_hotplug.c | 14 +-- src/qemu/qemu_parse_command.c | 8 +- .../qemu_2.6.0-gicv2-virt.aarch64.xml | 1 - .../qemu_2.6.0-gicv3-virt.aarch64.xml | 1 - tests/domaincapsschemadata/qemu_2.6.0.aarch64.xml | 1 - tests/domaincapsschemadata/qemu_2.6.0.ppc64le.xml | 1 - tests/domaincapsschemadata/qemu_2.7.0.s390x.xml | 1 - tests/domaincapsschemadata/qemu_2.8.0.s390x.xml | 1 - .../domaincapsschemadata/qemu_2.9.0-q35.x86_64.xml | 125 +++++++++++++++++++++ tests/domaincapstest.c | 4 + 16 files changed, 229 insertions(+), 103 deletions(-) create mode 100644 tests/domaincapsschemadata/qemu_2.9.0-q35.x86_64.xml -- 2.12.2

2 15

[libvirt] [PATCH V3] Expose resource control capabilites on cache bank
by Eli Qiao 18 Apr '17

18 Apr '17

This patch is based on Martin's cache branch. This patch amends the cache bank capability as follow: <cache> <bank id='0' level='3' type='unified' size='15360' unit='KiB' cpus='0-5'> <control min='768' unit='KiB' type='unified' nallocations='4'/> </bank> <bank id='1' level='3' type='unified' size='15360' unit='KiB' cpus='6-11'> <control min='768' unit='KiB' type='unified' nallocations='4'/> </bank> </cache> Along with vircaps2xmltest case updated. Signed-off-by: Eli Qiao <liyong.qiao(a)intel.com> --- src/conf/capabilities.c | 120 ++++++++++++++++++++++- src/conf/capabilities.h | 13 ++- tests/vircaps2xmldata/vircaps-x86_64-resctrl.xml | 8 +- tests/vircaps2xmltest.c | 13 +++ 4 files changed, 148 insertions(+), 6 deletions(-) diff --git a/src/conf/capabilities.c b/src/conf/capabilities.c index 416dd1a..3094e48 100644 --- a/src/conf/capabilities.c +++ b/src/conf/capabilities.c @@ -52,6 +52,7 @@ #define VIR_FROM_THIS VIR_FROM_CAPABILITIES #define SYSFS_SYSTEM_PATH "/sys/devices/system/" +#define SYSFS_RESCTRL_PATH "/sys/fs/resctrl/" VIR_LOG_INIT("conf.capabilities") @@ -873,6 +874,7 @@ virCapabilitiesFormatCaches(virBufferPtr buf, virCapsHostCacheBankPtr *caches) { size_t i = 0; + size_t j = 0; if (!ncaches) return 0; @@ -894,13 +896,32 @@ virCapabilitiesFormatCaches(virBufferPtr buf, */ virBufferAsprintf(buf, "<bank id='%u' level='%u' type='%s' " - "size='%llu' unit='%s' cpus='%s'/>\n", + "size='%llu' unit='%s' cpus='%s'", bank->id, bank->level, virCacheTypeToString(bank->type), bank->size >> (kilos * 10), kilos ? "KiB" : "B", cpus_str); + if (bank->ncontrol > 0) { + virBufferAddLit(buf, ">\n"); + virBufferAdjustIndent(buf, 2); + for (j = 0; j < bank->ncontrol; j++) { + bool min_kilos = !(bank->controls[j]->min % 1024); + virBufferAsprintf(buf, + "<control min='%llu' unit='%s' " + "type='%s' nallocations='%u'/>\n", + bank->controls[j]->min >> (min_kilos * 10), + min_kilos ? "KiB" : "B", + virCacheTypeToString(bank->controls[j]->type), + bank->controls[j]->nallocations); + } + virBufferAdjustIndent(buf, -2); + virBufferAddLit(buf, "</bank>\n"); + } else { + virBufferAddLit(buf, "/>\n"); + } + VIR_FREE(cpus_str); } @@ -1513,13 +1534,97 @@ virCapsHostCacheBankEquals(virCapsHostCacheBankPtr a, void virCapsHostCacheBankFree(virCapsHostCacheBankPtr ptr) { + size_t i; + if (!ptr) return; virBitmapFree(ptr->cpus); + for (i = 0; i < ptr->ncontrol; i++) + VIR_FREE(ptr->controls[i]); + VIR_FREE(ptr->controls); VIR_FREE(ptr); } +/* test which kinds of cache control supported + * -1: don't support + * 0: cat + * 1: cdp + */ +static int +virCapabilitiesGetCacheControlType(virCapsHostCacheBankPtr bank) +{ + int ret = -1; + char *path = NULL; + if (virAsprintf(&path, SYSFS_RESCTRL_PATH "info/L%u", bank->level) < 0) + return -1; + + if (virFileExists(path)) { + ret = 0; + } else { + VIR_FREE(path); + if (virAsprintf(&path, SYSFS_RESCTRL_PATH "info/L%uCODE", bank->level) < 0) + return -1; + if (virFileExists(path)) + ret = 1; + } + + VIR_FREE(path); + return ret; +} + +static int +virCapabilitiesGetCacheControl(virCapsHostCacheBankPtr bank, const char* type) +{ + int ret = -1; + char *path = NULL; + char *cbm_mask = NULL; + virCapsHostCacheControlPtr control; + + if (VIR_ALLOC(control) < 0) + goto cleanup; + + if (virFileReadValueUint(&control->nallocations, + SYSFS_RESCTRL_PATH "info/L%u%s/num_closids", + bank->level, + type) < 0) + goto cleanup; + + if (virFileReadValueString(&cbm_mask, + SYSFS_RESCTRL_PATH + "info/L%u%s/cbm_mask", + bank->level, + type) < 0) + goto cleanup; + + virStringTrimOptionalNewline(cbm_mask); + + control->min = bank->size / (strlen(cbm_mask) * 4); + + if (STREQ("", type)) + control->type = VIR_CACHE_TYPE_UNIFIED; + else if (STREQ("CODE", type)) + control->type = VIR_CACHE_TYPE_INSTRUCTION; + else if (STREQ("DATA", type)) + control->type = VIR_CACHE_TYPE_DATA; + else + goto cleanup; + + if (VIR_APPEND_ELEMENT(bank->controls, + bank->ncontrol, + control) < 0) + goto error; + + ret = 0; + + cleanup: + VIR_FREE(path); + return ret; + error: + VIR_FREE(control); + return -1; +} + int virCapabilitiesInitCaches(virCapsPtr caps) { @@ -1595,7 +1700,18 @@ virCapabilitiesInitCaches(virCapsPtr caps) pos, ent->d_name) < 0) goto cleanup; - if (bank->level < cache_min_level) { + ret = virCapabilitiesGetCacheControlType(bank); + + if ((bank->level >= cache_min_level) || (ret >= 0)) { + if (ret == 0) { + if (virCapabilitiesGetCacheControl(bank, "") < 0) + goto cleanup; + } else if (ret == 1) { + if ((virCapabilitiesGetCacheControl(bank, "CODE") < 0) || + (virCapabilitiesGetCacheControl(bank, "DATA") < 0)) + goto cleanup; + } + } else { virCapsHostCacheBankFree(bank); bank = NULL; continue; diff --git a/src/conf/capabilities.h b/src/conf/capabilities.h index e099ccc..1007c30 100644 --- a/src/conf/capabilities.h +++ b/src/conf/capabilities.h @@ -139,15 +139,22 @@ struct _virCapsHostSecModel { }; typedef enum { - VIR_CACHE_TYPE_DATA, - VIR_CACHE_TYPE_INSTRUCTION, VIR_CACHE_TYPE_UNIFIED, + VIR_CACHE_TYPE_INSTRUCTION, + VIR_CACHE_TYPE_DATA, VIR_CACHE_TYPE_LAST } virCacheType; VIR_ENUM_DECL(virCache); +typedef struct _virCapsHostCacheControl virCapsHostCacheControl; +typedef virCapsHostCacheControl *virCapsHostCacheControlPtr; +struct _virCapsHostCacheControl { + unsigned long long min; /* B */ + virCacheType type; /* Data, Instruction or Unified */ + unsigned int nallocations; /* number of supported allocation */ +}; typedef struct _virCapsHostCacheBank virCapsHostCacheBank; typedef virCapsHostCacheBank *virCapsHostCacheBankPtr; struct _virCapsHostCacheBank { @@ -156,6 +163,8 @@ struct _virCapsHostCacheBank { unsigned long long size; /* B */ virCacheType type; /* Data, Instruction or Unified */ virBitmapPtr cpus; /* All CPUs that share this bank */ + size_t ncontrol; + virCapsHostCacheControlPtr *controls; }; typedef struct _virCapsHost virCapsHost; diff --git a/tests/vircaps2xmldata/vircaps-x86_64-resctrl.xml b/tests/vircaps2xmldata/vircaps-x86_64-resctrl.xml index c30ea87..32a9549 100644 --- a/tests/vircaps2xmldata/vircaps-x86_64-resctrl.xml +++ b/tests/vircaps2xmldata/vircaps-x86_64-resctrl.xml @@ -41,8 +41,12 @@ </cells> </topology> <cache> - <bank id='0' level='3' type='unified' size='15360' unit='KiB' cpus='0-5'/> - <bank id='1' level='3' type='unified' size='15360' unit='KiB' cpus='6-11'/> + <bank id='0' level='3' type='unified' size='15360' unit='KiB' cpus='0-5'> + <control min='768' unit='KiB' type='unified' nallocations='4'/> + </bank> + <bank id='1' level='3' type='unified' size='15360' unit='KiB' cpus='6-11'> + <control min='768' unit='KiB' type='unified' nallocations='4'/> + </bank> </cache> </host> diff --git a/tests/vircaps2xmltest.c b/tests/vircaps2xmltest.c index f590249..3d1ad43 100644 --- a/tests/vircaps2xmltest.c +++ b/tests/vircaps2xmltest.c @@ -47,6 +47,7 @@ test_virCapabilities(const void *opaque) char *capsXML = NULL; char *path = NULL; char *dir = NULL; + char *resctrl_dir = NULL; int ret = -1; /* @@ -58,6 +59,17 @@ test_virCapabilities(const void *opaque) data->resctrl ? "/system" : "") < 0) goto cleanup; + if (data->resctrl) { + if (virAsprintf(&resctrl_dir, "%s/vircaps2xmldata/linux-%s/resctrl", + abs_srcdir, data->filename) < 0) + goto cleanup; + } else { + /* Mock to bad directory to avoid using /sys/fs/resctrl */ + if (VIR_STRDUP(resctrl_dir, "") < 0) + goto cleanup; + } + + virFileMockAddPrefix("/sys/fs/resctrl", resctrl_dir); virFileMockAddPrefix("/sys/devices/system", dir); caps = virCapabilitiesNew(data->arch, data->offlineMigrate, data->liveMigrate); @@ -84,6 +96,7 @@ test_virCapabilities(const void *opaque) cleanup: VIR_FREE(dir); + VIR_FREE(resctrl_dir); VIR_FREE(path); VIR_FREE(capsXML); virObjectUnref(caps); -- 1.9.1

4 15

[libvirt] [PATCH 0/5] Use-after-free fix and cleanups
by Marc Hartmayer 18 Apr '17

18 Apr '17

While looking at a use-after-free situation going through how the QEMU monitor is set up I noticed some things. These cleanups and the fix for the use-after-free are the result of that. Marc Hartmayer (5): qemu: Fix two use-after-free situations qemu: Turn qemuDomainLogContext into virObject qemu: Implement qemuMonitorRegister() qemu: remove ATTRIBUTE_UNUSED in qemuProcessHandleMonitorEOF refactoring: Use the return value of virObjectRef directly src/datatypes.c | 6 ++-- src/qemu/qemu_domain.c | 72 ++++++++++++++++++++------------------ src/qemu/qemu_domain.h | 2 -- src/qemu/qemu_monitor.c | 82 ++++++++++++++++++++++++++++++++++---------- src/qemu/qemu_monitor.h | 6 ++++ src/qemu/qemu_process.c | 12 +++---- src/rpc/virnetclientstream.c | 4 +-- src/rpc/virnetserver.c | 9 ++--- tests/qemumonitortestutils.c | 3 +- 9 files changed, 121 insertions(+), 75 deletions(-) -- 2.5.5

2 8

[libvirt] [PATCH] hyperv: recognize array property as distinct type.
by Dawid Zamirski 18 Apr '17

18 Apr '17

When hyperv code generator for WMI classes identifies common properties, it needs to take into account array type as a distinct type, i.e string != string[]. This is the case where v1 of the Msvm_VirtualSystemSettingData has Notes property as string whereas v2 uses Notes[], therefore they have to be treated as different fields and cannot be placed in the "common" struct. --- src/hyperv/hyperv_driver.c | 26 ++++++++++++++++++++++++-- src/hyperv/hyperv_wmi_generator.py | 2 +- 2 files changed, 25 insertions(+), 3 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 090ea24..5a27908 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c @@ -894,8 +894,30 @@ hypervDomainGetXMLDesc(virDomainPtr domain, unsigned int flags) if (VIR_STRDUP(def->name, computerSystem->data.common->ElementName) < 0) goto cleanup; - if (VIR_STRDUP(def->description, virtualSystemSettingData->data.common->Notes) < 0) - goto cleanup; + if (priv->wmiVersion == HYPERV_WMI_VERSION_V1) { + if (VIR_STRDUP(def->description, + virtualSystemSettingData->data.v1->Notes) < 0) + goto cleanup; + } else if (priv->wmiVersion == HYPERV_WMI_VERSION_V2 && + virtualSystemSettingData->data.v2->Notes.data != NULL) { + char **notes = NULL; + virBuffer buf = VIR_BUFFER_INITIALIZER; + size_t i = 0; + + /* in practice Notes has 1 element */ + for (i = 0; i < virtualSystemSettingData->data.v2->Notes.count; i++) { + /* but if there's more than 1, separate by double new line */ + if (virBufferUse(&buf) > 0) + virBufferAddLit(&buf, "\n\n"); + + notes = (char **) virtualSystemSettingData->data.v2->Notes.data; + virBufferAdd(&buf, *notes, -1); + notes++; + } + + def->description = virBufferContentAndReset(&buf); + } + virDomainDefSetMemoryTotal(def, memorySettingData->data.common->Limit * 1024); /* megabyte to kilobyte */ def->mem.cur_balloon = memorySettingData->data.common->VirtualQuantity * 1024; /* megabyte to kilobyte */ diff --git a/src/hyperv/hyperv_wmi_generator.py b/src/hyperv/hyperv_wmi_generator.py index c15d97a..9aee0b9 100755 --- a/src/hyperv/hyperv_wmi_generator.py +++ b/src/hyperv/hyperv_wmi_generator.py @@ -251,7 +251,7 @@ class WmiClass: for cls in self.versions: for prop in cls.properties: # consdered same if matches by name AND type - key = "%s_%s" % (prop.name, prop.type) + key = "%s_%s_%s" % (prop.name, prop.type, prop.is_array) if key in property_info: property_info[key][1] += 1 -- 2.9.3

2 3

[libvirt] How do you use Ceph/RBD pools with a VM?
by Erik Andersen 17 Apr '17

17 Apr '17

I have used Ceph/RBD images for libvirt manage KVM virtual machines before. I did this by including the Monitor addresses and Ceph authentication details directly in the <disk> section of the Domain's XML. I'm trying to add Ceph support to the Kimchi project. They use pools for disk storage. So I attempted to add support for adding pools to Kimchi, and that seems to have worked. The resulting pool definition is such: <pool type='rbd'> <name>cephpooltest3</name> <uuid>ed08f580-f841-48cb-ba05-747aef3cee12</uuid> <capacity unit='bytes'>144881172480</capacity> <allocation unit='bytes'>114</allocation> <available unit='bytes'>139953623040</available> <source> <host name='192.168.122.254'/> <host name='192.168.122.253'/> <host name='192.168.122.252'/> <name>prod-virt-pool</name> <auth type='ceph' username='libvirt'> <secret usage='cephpooltest3'/> </auth> </source> </pool> But the thing I can't seem to figure out is what XML should I be using under a VM/Domain to have a disk that is stored on that pool? Is this even possible right now? I found https://www.redhat.com/archives/libvirt-users/2015-March/msg00123.html which seems to indicate that this was not possible as of about a year ago. If that is still the case, is there any usefulness to being able to define an RBD pool? What needs to be done before the patches mentioned could be applied?

1 0

[libvirt] [PATCH 1/2] vz: support virDomainSetVcpus
by Konstantin Neumoin 17 Apr '17

17 Apr '17

Acked-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> Signed-off-by: Konstantin Neumoin <kneumoin(a)virtuozzo.com> --- src/vz/vz_driver.c | 43 +++++++++++++++++++++++++++++++++++++++++++ src/vz/vz_sdk.c | 23 +++++++++++++++++++++++ src/vz/vz_sdk.h | 1 + 3 files changed, 67 insertions(+) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index da83a8f..ed7132f 100644 --- a/src/vz/vz_driver.c +++ b/src/vz/vz_driver.c @@ -3905,6 +3905,47 @@ vzDomainReset(virDomainPtr domain, unsigned int flags) return ret; } +static int vzDomainSetVcpusFlags(virDomainPtr domain, unsigned int nvcpus, + unsigned int flags) +{ + virDomainObjPtr dom = NULL; + int ret = -1; + bool job = false; + + virCheckFlags(VIR_DOMAIN_AFFECT_LIVE | + VIR_DOMAIN_AFFECT_CONFIG, -1); + + if (!(dom = vzDomObjFromDomainRef(domain))) + goto cleanup; + + if (vzCheckConfigUpdateFlags(dom, &flags) < 0) + goto cleanup; + + if (virDomainSetVcpusFlagsEnsureACL(domain->conn, dom->def, flags) < 0) + goto cleanup; + + if (vzDomainObjBeginJob(dom) < 0) + goto cleanup; + job = true; + + if (vzEnsureDomainExists(dom) < 0) + goto cleanup; + + ret = prlsdkSetCpuCount(dom, nvcpus); + + cleanup: + if (job) + vzDomainObjEndJob(dom); + virDomainObjEndAPI(&dom); + return ret; +} + +static int vzDomainSetVcpus(virDomainPtr dom, unsigned int nvcpus) +{ + return vzDomainSetVcpusFlags(dom, nvcpus, + VIR_DOMAIN_AFFECT_LIVE | VIR_DOMAIN_AFFECT_CONFIG); +} + static virHypervisorDriver vzHypervisorDriver = { .name = "vz", .connectOpen = vzConnectOpen, /* 0.10.0 */ @@ -3954,6 +3995,8 @@ static virHypervisorDriver vzHypervisorDriver = { .domainDetachDeviceFlags = vzDomainDetachDeviceFlags, /* 1.2.15 */ .domainIsActive = vzDomainIsActive, /* 1.2.10 */ .domainIsUpdated = vzDomainIsUpdated, /* 1.2.21 */ + .domainSetVcpus = vzDomainSetVcpus, /* 3.3.0 */ + .domainSetVcpusFlags = vzDomainSetVcpusFlags, /* 3.3.0 */ .domainGetVcpusFlags = vzDomainGetVcpusFlags, /* 1.2.21 */ .domainGetMaxVcpus = vzDomainGetMaxVcpus, /* 1.2.21 */ .domainSetUserPassword = vzDomainSetUserPassword, /* 2.0.0 */ diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index c1a50fd..2daa44a 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -4902,3 +4902,26 @@ int prlsdkMigrate(virDomainObjPtr dom, virURIPtr uri, cleanup: return ret; } + +int prlsdkSetCpuCount(virDomainObjPtr dom, unsigned int count) +{ + vzDomObjPtr privdom = dom->privateData; + PRL_HANDLE job; + PRL_RESULT pret; + + job = PrlVm_BeginEdit(privdom->sdkdom); + if (PRL_FAILED(waitDomainJob(job, dom))) + goto error; + + pret = PrlVmCfg_SetCpuCount(privdom->sdkdom, count); + prlsdkCheckRetGoto(pret, error); + + job = PrlVm_CommitEx(privdom->sdkdom, 0); + if (PRL_FAILED(waitDomainJob(job, dom))) + goto error; + + return 0; + + error: + return -1; +} diff --git a/src/vz/vz_sdk.h b/src/vz/vz_sdk.h index f8da2ad..100a5e3 100644 --- a/src/vz/vz_sdk.h +++ b/src/vz/vz_sdk.h @@ -71,6 +71,7 @@ int prlsdkGetMemoryStats(PRL_HANDLE sdkstas, virDomainMemoryStatPtr stats, unsigned int nr_stats); /* memsize is in MiB */ int prlsdkSetMemsize(virDomainObjPtr dom, unsigned int memsize); +int prlsdkSetCpuCount(virDomainObjPtr dom, unsigned int count); int prlsdkDomainSetUserPassword(virDomainObjPtr dom, const char *user, -- 2.7.4

2 2

[libvirt] [PATCH 1/2] vz: support virDomainSetVcpus
by Konstantin Neumoin 14 Apr '17

14 Apr '17

Signed-off-by: Konstantin Neumoin <kneumoin(a)virtuozzo.com> --- src/vz/vz_driver.c | 43 +++++++++++++++++++++++++++++++++++++++++++ src/vz/vz_sdk.c | 23 +++++++++++++++++++++++ src/vz/vz_sdk.h | 1 + 3 files changed, 67 insertions(+) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index da83a8f..ed7132f 100644 --- a/src/vz/vz_driver.c +++ b/src/vz/vz_driver.c @@ -3905,6 +3905,47 @@ vzDomainReset(virDomainPtr domain, unsigned int flags) return ret; } +static int vzDomainSetVcpusFlags(virDomainPtr domain, unsigned int nvcpus, + unsigned int flags) +{ + virDomainObjPtr dom = NULL; + int ret = -1; + bool job = false; + + virCheckFlags(VIR_DOMAIN_AFFECT_LIVE | + VIR_DOMAIN_AFFECT_CONFIG, -1); + + if (!(dom = vzDomObjFromDomainRef(domain))) + goto cleanup; + + if (vzCheckConfigUpdateFlags(dom, &flags) < 0) + goto cleanup; + + if (virDomainSetVcpusFlagsEnsureACL(domain->conn, dom->def, flags) < 0) + goto cleanup; + + if (vzDomainObjBeginJob(dom) < 0) + goto cleanup; + job = true; + + if (vzEnsureDomainExists(dom) < 0) + goto cleanup; + + ret = prlsdkSetCpuCount(dom, nvcpus); + + cleanup: + if (job) + vzDomainObjEndJob(dom); + virDomainObjEndAPI(&dom); + return ret; +} + +static int vzDomainSetVcpus(virDomainPtr dom, unsigned int nvcpus) +{ + return vzDomainSetVcpusFlags(dom, nvcpus, + VIR_DOMAIN_AFFECT_LIVE | VIR_DOMAIN_AFFECT_CONFIG); +} + static virHypervisorDriver vzHypervisorDriver = { .name = "vz", .connectOpen = vzConnectOpen, /* 0.10.0 */ @@ -3954,6 +3995,8 @@ static virHypervisorDriver vzHypervisorDriver = { .domainDetachDeviceFlags = vzDomainDetachDeviceFlags, /* 1.2.15 */ .domainIsActive = vzDomainIsActive, /* 1.2.10 */ .domainIsUpdated = vzDomainIsUpdated, /* 1.2.21 */ + .domainSetVcpus = vzDomainSetVcpus, /* 3.3.0 */ + .domainSetVcpusFlags = vzDomainSetVcpusFlags, /* 3.3.0 */ .domainGetVcpusFlags = vzDomainGetVcpusFlags, /* 1.2.21 */ .domainGetMaxVcpus = vzDomainGetMaxVcpus, /* 1.2.21 */ .domainSetUserPassword = vzDomainSetUserPassword, /* 2.0.0 */ diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index c1a50fd..2daa44a 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -4902,3 +4902,26 @@ int prlsdkMigrate(virDomainObjPtr dom, virURIPtr uri, cleanup: return ret; } + +int prlsdkSetCpuCount(virDomainObjPtr dom, unsigned int count) +{ + vzDomObjPtr privdom = dom->privateData; + PRL_HANDLE job; + PRL_RESULT pret; + + job = PrlVm_BeginEdit(privdom->sdkdom); + if (PRL_FAILED(waitDomainJob(job, dom))) + goto error; + + pret = PrlVmCfg_SetCpuCount(privdom->sdkdom, count); + prlsdkCheckRetGoto(pret, error); + + job = PrlVm_CommitEx(privdom->sdkdom, 0); + if (PRL_FAILED(waitDomainJob(job, dom))) + goto error; + + return 0; + + error: + return -1; +} diff --git a/src/vz/vz_sdk.h b/src/vz/vz_sdk.h index f8da2ad..100a5e3 100644 --- a/src/vz/vz_sdk.h +++ b/src/vz/vz_sdk.h @@ -71,6 +71,7 @@ int prlsdkGetMemoryStats(PRL_HANDLE sdkstas, virDomainMemoryStatPtr stats, unsigned int nr_stats); /* memsize is in MiB */ int prlsdkSetMemsize(virDomainObjPtr dom, unsigned int memsize); +int prlsdkSetCpuCount(virDomainObjPtr dom, unsigned int count); int prlsdkDomainSetUserPassword(virDomainObjPtr dom, const char *user, -- 2.7.4

2 3

[libvirt] [PATCH] virConfSaveValue: protect against a NULL pointer reference
by Wim Ten Have 13 Apr '17

13 Apr '17

From: Wim ten Have <wim.ten.have(a)oracle.com> This patch protects against a NULL pointer dereference leading to a SEGV under xlconfigtest per DO_TEST("channel-pty"); VIR_TEST_OOM=1 VIR_TEST_RANGE=29 ./tests/xlconfigtest Wim ten Have (1): virConfSaveValue: protect against a NULL pointer reference src/util/virconf.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) -- 2.9.3

3 3

[libvirt] [PATCH] virpci: Enable GEN4 card Link speed (16GT/s)
by Shivaprasad G Bhat 13 Apr '17

13 Apr '17

This enables GEN4 link speed (16GT/s) property to be fetched properly and thus allows the detach/reattach/dumpxml to work. Signed-off-by: Shivaprasad G Bhat <sbhat(a)linux.vnet.ibm.com> --- Verified on Mellanox MT27800 Family ConnectX-5 IB card. # lspci -kvvvs 0001:01:00.4 0001:01:00.4 Infiniband controller: Mellanox Technologies MT27800 Family [ConnectX-5 Virtual Function] Subsystem: IBM MT28800 Family [ConnectX-5 Virtual Function] Control: I/O- Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 0 Region 0: [virtual] Memory at 21000e000000 (64-bit, prefetchable) [size=32M] Capabilities: [60] Express (v2) Endpoint, MSI 00 DevCap: MaxPayload 512 bytes, PhantFunc 0, Latency L0s unlimited, L1 unlimited ExtTag+ AttnBtn- AttnInd- PwrInd- RBE+ FLReset+ DevCtl: Report errors: Correctable- Non-Fatal- Fatal- Unsupported- RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop- FLReset- MaxPayload 128 bytes, MaxReadReq 128 bytes DevSta: CorrErr- UncorrErr- FatalErr- UnsuppReq- AuxPwr- TransPend- LnkCap: Port #0, Speed 16GT/s, Width x16, ASPM not supported, Exit Latency L0s unlimited, L1 unlimited ClockPM- Surprise- LLActRep- BwNot- ASPMOptComp+ LnkCtl: ASPM Disabled; RCB 64 bytes Disabled- CommClk- ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt- LnkSta: Speed unknown, Width x0, TrErr- Train- SlotClk- DLActive- BWMgmt- ABWMgmt- DevCap2: Completion Timeout: Range ABCD, TimeoutDis+, LTR-, OBFF Not Supported DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis-, LTR-, OBFF Disabled LnkSta2: Current De-emphasis Level: -6dB, EqualizationComplete-, EqualizationPhase1- EqualizationPhase2-, EqualizationPhase3-, LinkEqualizationRequest- Capabilities: [48] Vital Product Data Product Name: PCIe4 2-port 100Gb EDR Adapter x16 Read-only fields: [PN] Part number: 00WT174 [EC] Engineering changes: P40094 [VF] Vendor specific: 00WT176 [SN] Serial number: YA50YF6AL00B [Z0] Unknown: 49 42 4d 30 30 30 30 30 30 30 30 30 32 [VC] Vendor specific: EC64 [MN] Manufacture ID: 36 34 31 58 34 38 31 31 37 34 30 30 33 34 20 [VH] Vendor specific: 2CF2 [VK] Vendor specific: ipzSeries [RV] Reserved: checksum good, 0 byte(s) reserved End Capabilities: [9c] MSI-X: Enable+ Count=12 Masked- Vector table: BAR=0 offset=00002000 PBA: BAR=0 offset=00003000 Kernel driver in use: mlx5_core Kernel modules: mlx5_core Before fix : # virsh nodedev-dumpxml pci_0001_01_00_4 <device> <name>pci_0001_01_00_4</name> <path>/sys/devices/pci0001:00/0001:00:00.0/0001:01:00.4</path> <parent>pci_0001_00_00_0</parent> <driver> <name>vfio-pci</name> </driver> <capability type='pci'> <domain>1</domain> <bus>1</bus> <slot>0</slot> <function>4</function> <product id='0x1018'>MT27800 Family [ConnectX-5 Virtual Function]</product> <vendor id='0x15b3'>Mellanox Technologies</vendor> <capability type='phys_function'> <address domain='0x0001' bus='0x01' slot='0x00' function='0x0'/> </capability> <iommuGroup number='10'> <address domain='0x0001' bus='0x01' slot='0x00' function='0x4'/> </iommuGroup> <numa node='0'/> <pci-express> <link validity='cap' port='0' speed='(null)' width='16'/> <link validity='sta' width='0'/> </pci-express> </capability> </device> # virsh nodedev-detach pci_0001_01_00_4 error: Failed to detach device pci_0001_01_00_4 error: malformed 'speed' attribute: (null) After Fix: # ./run tools/virsh nodedev-dumpxml pci_0001_01_00_4 <device> <name>pci_0001_01_00_4</name> <path>/sys/devices/pci0001:00/0001:00:00.0/0001:01:00.4</path> <parent>pci_0001_00_00_0</parent> <driver> <name>mlx5_core</name> </driver> <capability type='pci'> <domain>1</domain> <bus>1</bus> <slot>0</slot> <function>4</function> <product id='0x1018'>MT27800 Family [ConnectX-5 Virtual Function]</product> <vendor id='0x15b3'>Mellanox Technologies</vendor> <capability type='phys_function'> <address domain='0x0001' bus='0x01' slot='0x00' function='0x0'/> </capability> <iommuGroup number='10'> <address domain='0x0001' bus='0x01' slot='0x00' function='0x4'/> </iommuGroup> <numa node='0'/> <pci-express> <link validity='cap' port='0' speed='16' width='16'/> <link validity='sta' width='0'/> </pci-express> </capability> </device> # ./run tools/virsh nodedev-detach pci_0001_01_00_4 Device pci_0001_01_00_4 detached --- src/util/virpci.c | 4 ++-- src/util/virpci.h | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/util/virpci.c b/src/util/virpci.c index 3c1e13b..1e0d903 100644 --- a/src/util/virpci.c +++ b/src/util/virpci.c @@ -53,7 +53,7 @@ VIR_LOG_INIT("util.pci"); #define PCI_ADDR_LEN 13 /* "XXXX:XX:XX.X" */ VIR_ENUM_IMPL(virPCIELinkSpeed, VIR_PCIE_LINK_SPEED_LAST, - "", "2.5", "5", "8") + "", "2.5", "5", "8", "16") VIR_ENUM_IMPL(virPCIStubDriver, VIR_PCI_STUB_DRIVER_LAST, "none", @@ -147,7 +147,7 @@ struct _virPCIDeviceList { #define PCI_EXP_DEVCAP 0x4 /* Device capabilities */ #define PCI_EXP_DEVCAP_FLR (1<<28) /* Function Level Reset */ #define PCI_EXP_LNKCAP 0xc /* Link Capabilities */ -#define PCI_EXP_LNKCAP_SPEED 0x0000f /* Maximum Link Speed */ +#define PCI_EXP_LNKCAP_SPEED 0x0001f /* Maximum Link Speed */ #define PCI_EXP_LNKCAP_WIDTH 0x003f0 /* Maximum Link Width */ #define PCI_EXP_LNKSTA 0x12 /* Link Status */ #define PCI_EXP_LNKSTA_SPEED 0x000f /* Negotiated Link Speed */ diff --git a/src/util/virpci.h b/src/util/virpci.h index a5e8d00..50e8b3c 100644 --- a/src/util/virpci.h +++ b/src/util/virpci.h @@ -58,6 +58,7 @@ typedef enum { VIR_PCIE_LINK_SPEED_25, VIR_PCIE_LINK_SPEED_5, VIR_PCIE_LINK_SPEED_8, + VIR_PCIE_LINK_SPEED_16, VIR_PCIE_LINK_SPEED_LAST } virPCIELinkSpeed;

2 1

[libvirt] [PATCH] xenFormatXLDomainDisks: avoid double free on OOM testing
by Wim Ten Have 13 Apr '17

13 Apr '17

From: Wim ten Have <wim.ten.have(a)oracle.com> This patch fixes a double free that exposed under OOM testing xlconfigtest per DO_TEST("new-disk"); VIR_TEST_OOM=1 VIR_TEST_RANGE=5 ./tests/xlconfigtest Wim ten Have (1): xenFormatXLDomainDisks: avoid double free on OOM testing src/xenconfig/xen_xl.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) -- 2.9.3

2 2