- Devel - libvirt List Archives

[libvirt] [PATCH] virt-aa-helper: Allow parsing supported features for qemu/kvm
by Shivaprasad G Bhat 19 Jan '18

19 Jan '18

The virt-aa-helper fails to parse the xmls with the memory/cpu hotplug features or user assigned aliases. Set the features in xmlopt->config for the parsing to succeed. Signed-off-by: Shivaprasad G Bhat <sbhat(a)linux.vnet.ibm.com> --- src/conf/domain_conf.c | 21 --------------------- src/conf/domain_conf.h | 21 +++++++++++++++++++++ src/security/virt-aa-helper.c | 7 +++++++ 3 files changed, 28 insertions(+), 21 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index a1c2506..20ce83e 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -64,27 +64,6 @@ VIR_LOG_INIT("conf.domain_conf"); -/* This structure holds various callbacks and data needed - * while parsing and creating domain XMLs */ -struct _virDomainXMLOption { - virObject parent; - - /* XML parser callbacks and defaults */ - virDomainDefParserConfig config; - - /* domain private data management callbacks */ - virDomainXMLPrivateDataCallbacks privateData; - - /* XML namespace callbacks */ - virDomainXMLNamespace ns; - - /* ABI stability callbacks */ - virDomainABIStability abi; - - /* Private data for save image stored in snapshot XML */ - virSaveCookieCallbacks saveCookie; -}; - #define VIR_DOMAIN_DEF_FORMAT_COMMON_FLAGS \ (VIR_DOMAIN_DEF_FORMAT_SECURE | \ VIR_DOMAIN_DEF_FORMAT_INACTIVE | \ diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 6f7f96b..aacb88a 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2662,6 +2662,27 @@ struct _virDomainABIStability { virDomainABIStabilityDomain domain; }; +/* This structure holds various callbacks and data needed + * while parsing and creating domain XMLs */ +struct _virDomainXMLOption { + virObject parent; + + /* XML parser callbacks and defaults */ + virDomainDefParserConfig config; + + /* domain private data management callbacks */ + virDomainXMLPrivateDataCallbacks privateData; + + /* XML namespace callbacks */ + virDomainXMLNamespace ns; + + /* ABI stability callbacks */ + virDomainABIStability abi; + + /* Private data for save image stored in snapshot XML */ + virSaveCookieCallbacks saveCookie; +}; + virDomainXMLOptionPtr virDomainXMLOptionNew(virDomainDefParserConfigPtr config, virDomainXMLPrivateDataCallbacksPtr priv, virDomainXMLNamespacePtr xmlns, diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index f7ccae0..8b0ca46 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -699,6 +699,13 @@ get_definition(vahControl * ctl, const char *xmlStr) goto exit; } + if (virtType == VIR_DOMAIN_VIRT_QEMU || virtType == VIR_DOMAIN_VIRT_KVM) { + ctl->xmlopt->config.features = VIR_DOMAIN_DEF_FEATURE_MEMORY_HOTPLUG | + VIR_DOMAIN_DEF_FEATURE_OFFLINE_VCPUPIN | + VIR_DOMAIN_DEF_FEATURE_INDIVIDUAL_VCPUS | + VIR_DOMAIN_DEF_FEATURE_USER_ALIAS; + } + if (virCapabilitiesAddGuestDomain(guest, virtType, NULL,

3 2

[libvirt] Release of libvirt-4.0.0
by Daniel Veillard 19 Jan '18

19 Jan '18

First release of the year ! A bit late but it is now tagged in git and signed tarball and rpms are at the usual place: ftp://libvirt.org/libvirt/ I also pushed a release of the python bindings in git and at ftp://libvirt.org/libvirt/python/ This is a relatively small release, probably due to the end of year slowdown though there is some notable addition: * New features - tools: Provide bash completion support. Both virsh and virt-admin now implement basic bash completion support. - qemu: Refresh capabilities on host microcode update A microcode update can cause the CPUID bits to change; therefore, the capabilities cache should be rebuilt when such an update is detected on the host. - lxc: Set hostname based on container name * Improvements - CPU frequency reporting improvements The CPU frequency will now be reported by virsh nodeinfo and other tools for s390 hosts; at the same time; CPU frequency has been disabled on aarch64 hosts because there's no way to detect it reliably. - libxl: Mark domain0 as persistent - Xen: Add support for multiple IP addresses on interface devices - qemu: Add support for hot unplugging redirdev device * Bug fixes - qemu: Enforce vCPU hotplug granularity constraints QEMU 2.7 and newer don't allow guests to start unless the initial vCPUs count is a multiple of the vCPU hotplug granularity, so validate it and report an error if needed. thanks everybody for your help with this release, be it code, bug reports reviews, documentation, etc ... Enjoy the new release ! Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] [PATCH] Revert "qemu: monitor: do not report error on shutdown"
by Michal Privoznik 19 Jan '18

19 Jan '18

This reverts commit aeda1b8c56dc58b0a413acc61bbea938b40499e1. Problem is that we need mon->lastError to be set because it's used all over the place. Also, there's nothing wrong with reporting error if one occurred. I mean, if there's a thread executing an API and which currently is talking on monitor it definitely wants the error reported. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_monitor.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 85c7d68a1..fc146bdbf 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -78,7 +78,6 @@ struct _qemuMonitor { * < 0: an error occurred during the registration of @fd */ int watch; int hasSendFD; - int willhangup; virDomainObjPtr vm; @@ -716,10 +715,8 @@ qemuMonitorIO(int watch, int fd, int events, void *opaque) if (events & VIR_EVENT_HANDLE_HANGUP) { hangup = true; if (!error) { - if (!mon->willhangup) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("End of file from qemu monitor")); - } + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("End of file from qemu monitor")); eof = true; events &= ~VIR_EVENT_HANDLE_HANGUP; } @@ -758,7 +755,7 @@ qemuMonitorIO(int watch, int fd, int events, void *opaque) if (mon->lastError.code != VIR_ERR_OK) { /* Already have an error, so clear any new error */ virResetLastError(); - } else if (!mon->willhangup) { + } else { virErrorPtr err = virGetLastError(); if (!err) virReportError(VIR_ERR_INTERNAL_ERROR, "%s", @@ -1352,7 +1349,6 @@ qemuMonitorEmitShutdown(qemuMonitorPtr mon, virTristateBool guest) { int ret = -1; VIR_DEBUG("mon=%p guest=%u", mon, guest); - mon->willhangup = 1; QEMU_MONITOR_CALLBACK(mon, ret, domainShutdown, mon->vm, guest); return ret; -- 2.13.6

2 2

[libvirt] [PATCH] qemu: Don't send any monitor commands afer SHUTDOWN event
by Michal Privoznik 19 Jan '18

19 Jan '18

After aeda1b8c56dc5 we tried to stop reporting I/O errors on expected monitor HUP. We've achieved that by not setting mon->lastError once we've received SHUTDOWN event. However, this makes us to deadlock in case there's thread that enters the monitor after the event is received. The problem is, we're no longer setting mon->lastError and therefore qemuMonitorSend() does not return early and continues execution until virCondWait() (which will never wake up). Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_monitor.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 85c7d68a1..9f3e3eb14 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -1063,7 +1063,7 @@ qemuMonitorSend(qemuMonitorPtr mon, { int ret = -1; - /* Check whether qemu quit unexpectedly */ + /* Check whether qemu quit unexpectedly, */ if (mon->lastError.code != VIR_ERR_OK) { VIR_DEBUG("Attempt to send command while error is set %s", NULLSTR(mon->lastError.message)); @@ -1071,6 +1071,12 @@ qemuMonitorSend(qemuMonitorPtr mon, return -1; } + /* or expectedly. */ + if (mon->willhangup) { + VIR_DEBUG("Attempt to send command while domain is shutting down"); + return -1; + } + mon->msg = msg; qemuMonitorUpdateWatch(mon); -- 2.13.6

2 2

[libvirt] [PATCH] qemu: Fix crash in offline migration
by Jiri Denemark 19 Jan '18

19 Jan '18

When migrating a shutoff domain (i.e., offline migration), we have no statistics to report and thus jobInfo will be NULL in qemuMigrationFinish. Broken by me in v3.10.0-183-ge8784e7868. https://bugzilla.redhat.com/show_bug.cgi?id=1536351 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_migration.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index a56bc596ff..1854900c9a 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -5481,8 +5481,10 @@ qemuMigrationFinish(virQEMUDriverPtr driver, } if (dom) { - VIR_STEAL_PTR(priv->job.completed, jobInfo); - priv->job.completed->status = QEMU_DOMAIN_JOB_STATUS_COMPLETED; + if (jobInfo) { + VIR_STEAL_PTR(priv->job.completed, jobInfo); + priv->job.completed->status = QEMU_DOMAIN_JOB_STATUS_COMPLETED; + } if (qemuMigrationBakeCookie(mig, driver, vm, cookieout, cookieoutlen, QEMU_MIGRATION_COOKIE_STATS) < 0) -- 2.16.0

2 1

[libvirt] [PATCH 00/17] CPU models and features for Spectre, CVE-2017-5715
by Jiri Denemark 18 Jan '18

18 Jan '18

This is the libvirt's part of the changes related to CVE-2017-5715. The new models can be used to pass the protective CPU features to guests. But remember, the host CPU microcode, host kernel, QEMU, and libvirt all need to be updated for this to be any useful. Based on a patch from Paolo Bonzini. See QEMU patches from Eduardo for more details: https://patchew.org/QEMU/20180109154519.25634-1-ehabkost@redhat.com/ Jiri Denemark (16): cputest: Add data for Intel(R) Xeon(R) CPU E5-2609 v3 cputest: Add data for Intel(R) Xeon(R) CPU E5-2623 v4 cputest: Add data for Intel(R) Xeon(R) Gold 5115 CPU cputest: Add data for updated AMD EPYC 7601 32-Core Processor cputest: Add data for updated Intel(R) Core(TM) i7-5600U CPU cpu: Add Nehalem-IBRS CPU model cpu: Add Westmere-IBRS CPU model cpu: Add SandyBridge-IBRS CPU model cpu: Add IvyBridge-IBRS CPU model cpu: Add Haswell-noTSX-IBRS CPU model cpu: Add Haswell-IBRS CPU model cpu: Add Broadwell-noTSX-IBRS CPU model cpu: Add Broadwell-IBRS CPU model cpu: Add Skylake-Client-IBRS CPU model cpu: Add Skylake-Server-IBRS CPU model cpu: Add EPYC-IBPB CPU model Paolo Bonzini (1): cpu: add CPU features for indirect branch prediction protection src/cpu/cpu_map.xml | 622 ++++++++++++++++++ tests/cputest.c | 5 + .../x86_64-cpuid-Core-i7-5600U-ibrs-disabled.xml | 6 + .../x86_64-cpuid-Core-i7-5600U-ibrs-enabled.xml | 8 + .../x86_64-cpuid-Core-i7-5600U-ibrs-guest.xml | 29 + .../x86_64-cpuid-Core-i7-5600U-ibrs-host.xml | 30 + .../x86_64-cpuid-Core-i7-5600U-ibrs-json.xml | 15 + .../x86_64-cpuid-Core-i7-5600U-ibrs.json | 525 +++++++++++++++ .../x86_64-cpuid-Core-i7-5600U-ibrs.xml | 41 ++ ...86_64-cpuid-EPYC-7601-32-Core-ibpb-disabled.xml | 7 + ...x86_64-cpuid-EPYC-7601-32-Core-ibpb-enabled.xml | 9 + .../x86_64-cpuid-EPYC-7601-32-Core-ibpb-guest.xml | 17 + .../x86_64-cpuid-EPYC-7601-32-Core-ibpb-host.xml | 17 + .../x86_64-cpuid-EPYC-7601-32-Core-ibpb-json.xml | 12 + .../x86_64-cpuid-EPYC-7601-32-Core-ibpb.json | 722 ++++++++++++++++++++ .../x86_64-cpuid-EPYC-7601-32-Core-ibpb.xml | 54 ++ .../x86_64-cpuid-Xeon-E5-2609-v3-disabled.xml | 6 + .../x86_64-cpuid-Xeon-E5-2609-v3-enabled.xml | 8 + .../x86_64-cpuid-Xeon-E5-2609-v3-guest.xml | 31 + .../x86_64-cpuid-Xeon-E5-2609-v3-host.xml | 32 + .../x86_64-cpuid-Xeon-E5-2609-v3-json.xml | 14 + .../cputestdata/x86_64-cpuid-Xeon-E5-2609-v3.json | 726 +++++++++++++++++++++ tests/cputestdata/x86_64-cpuid-Xeon-E5-2609-v3.xml | 37 ++ .../x86_64-cpuid-Xeon-E5-2623-v4-disabled.xml | 7 + .../x86_64-cpuid-Xeon-E5-2623-v4-enabled.xml | 8 + .../x86_64-cpuid-Xeon-E5-2623-v4-guest.xml | 30 + .../x86_64-cpuid-Xeon-E5-2623-v4-host.xml | 34 + .../x86_64-cpuid-Xeon-E5-2623-v4-json.xml | 11 + .../cputestdata/x86_64-cpuid-Xeon-E5-2623-v4.json | 662 +++++++++++++++++++ tests/cputestdata/x86_64-cpuid-Xeon-E5-2623-v4.xml | 43 ++ .../x86_64-cpuid-Xeon-Gold-5115-disabled.xml | 8 + .../x86_64-cpuid-Xeon-Gold-5115-enabled.xml | 8 + .../x86_64-cpuid-Xeon-Gold-5115-guest.xml | 29 + .../x86_64-cpuid-Xeon-Gold-5115-host.xml | 30 + .../x86_64-cpuid-Xeon-Gold-5115-json.xml | 8 + tests/cputestdata/x86_64-cpuid-Xeon-Gold-5115.json | 614 +++++++++++++++++ tests/cputestdata/x86_64-cpuid-Xeon-Gold-5115.xml | 54 ++ 37 files changed, 4519 insertions(+) create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-5600U-ibrs-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-5600U-ibrs-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-5600U-ibrs-guest.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-5600U-ibrs-host.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-5600U-ibrs-json.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-5600U-ibrs.json create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-5600U-ibrs.xml create mode 100644 tests/cputestdata/x86_64-cpuid-EPYC-7601-32-Core-ibpb-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-EPYC-7601-32-Core-ibpb-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-EPYC-7601-32-Core-ibpb-guest.xml create mode 100644 tests/cputestdata/x86_64-cpuid-EPYC-7601-32-Core-ibpb-host.xml create mode 100644 tests/cputestdata/x86_64-cpuid-EPYC-7601-32-Core-ibpb-json.xml create mode 100644 tests/cputestdata/x86_64-cpuid-EPYC-7601-32-Core-ibpb.json create mode 100644 tests/cputestdata/x86_64-cpuid-EPYC-7601-32-Core-ibpb.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E5-2609-v3-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E5-2609-v3-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E5-2609-v3-guest.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E5-2609-v3-host.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E5-2609-v3-json.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E5-2609-v3.json create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E5-2609-v3.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E5-2623-v4-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E5-2623-v4-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E5-2623-v4-guest.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E5-2623-v4-host.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E5-2623-v4-json.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E5-2623-v4.json create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E5-2623-v4.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-Gold-5115-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-Gold-5115-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-Gold-5115-guest.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-Gold-5115-host.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-Gold-5115-json.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-Gold-5115.json create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-Gold-5115.xml -- 2.15.1

4 24

[libvirt] Test failures in libvirt RHEL-6.2.AUS errata job
by Jingjing Shao 18 Jan '18

18 Jan '18

Hi admin, I met the error as below in the in libvirt RHEL-6.2.AUS errata job, can you help to check it ? ======================================= 1 of 54 tests failed (2 tests were not run) Please report to libvir-list(a)redhat.com ======================================= make[1]: *** [check-TESTS] Error 1 make[1]: Leaving directory `/home/test/rpmbuild/BUILD/libvirt-0.9.4/tests' make: *** [check-am] Error 2 error: Bad exit status from /var/tmp/rpm-tmp.FOpZXU (%check) Details can be seen in attachment. Reference: http://nest.test.redhat.com/mnt/qa/scratch/x86-64-6s-2aus-v1/2017:32031/tps… -- Regards, Jingjing Shao

2 1

[libvirt] [PATCH] Add Eduardo Otubo to Planet Virt-Tools
by Eduardo Otubo 18 Jan '18

18 Jan '18

Adding Eduardo Otubo's blog information and avatar to config.ini at Planet Virt-Tools. Signed-ff-by: Eduardo Otubo <otubo(a)redhat.com> --- updater/virt-tools/config.ini | 6 ++++++ updater/virt-tools/images/otubo.png | Bin 0 -> 10597 bytes 2 files changed, 6 insertions(+) create mode 100644 updater/virt-tools/images/otubo.png diff --git a/updater/virt-tools/config.ini b/updater/virt-tools/config.ini index 988e572..d47e82f 100644 --- a/updater/virt-tools/config.ini +++ b/updater/virt-tools/config.ini @@ -167,3 +167,9 @@ name = Nathan Gauër [https://virtualpenguins.blogspot.com/feeds/posts/default] name = Cornelia Huck + +[http://www.otubo.net/feeds/posts/default/-/virt/?alt=rss] +name = Eduardo Otubo +face = otubo.png +facewidth = 80 +faceheight = 80 diff --git a/updater/virt-tools/images/otubo.png b/updater/virt-tools/images/otubo.png new file mode 100644 index 0000000000000000000000000000000000000000..9dfd30fce1c7b06bac5ad9b07052ad170bbe768a GIT binary patch literal 10597 zcmZX41yEc;v+hE0cXxLW?y$HnE<u9@2oAfrJ1nxeYY4%egy8Ow1a|_9YXSs){P$M9 zy7#?vs;5W3o^z^eW~%3#iPO<i#>Sw)0002ksw#@0SFQ6OK|^^>lku-=Ulo#roTeNA z&<MqRv_^g{)7h$kGywpA762eL5&*b=tqMH=0DSlWfFmmaKs*}&Aa&3Gsw?^0fMTPr ztO$7d&s+TcQ~GNSs<)~p5Oo`i7!eEcYH;2T0AO`fRg}{Qul&k)sCf^EY=*dr*&VqC zO!)F-ne%+>V9+F1Z*o*KG%sgMhN+-op`t(1TZSW{;US@w0>W&ERP?AQ(GZ!!^zd@D zYDPa8hB2E(0i%Fi-`4ih*8Cp|d{@k_wxtC9&f-CiJmjjV*#*m;UiQ-uGTH$}@E6Jc zfOAL$^km$i@Snp=+G)KE;@|o)6~?ky7oqn{$F?;UEzAoNiMOKX9-)^w$5J@Zzc{F1 zNi;k}7_5Z?JIy}AI&<6QZgB0A60+4ElJMqs?K-+nvwLpK;0Xa9d@j@Y^jG<kr<k=> zUJ3u7qv8hbPW}MI%$Ab{o_t<|SAQ`?(}ikFJ-{^rBTizHV~;}>E|i&A47uKQ$(MNe zfxQ*=^5kSFa}9LI;YZ<39*tp)w~qE9IhUG_xGj{z;153aqqV`ZcyfSC4paC)AuJfr zi^{1-0eEB{$)Jy4Le%HZU%U}JuGh$UWd4lYjfdh@iOL_vcF8c%CO0f>6^w{MZ<8A* zA#mTYKeoNTVZ^N};^&u07o4_lVi!^r@zvNOiSl3Ojlj>^-FH7wi*E}#iyjDuqSVnU zW>pjQb8SRR$Grl%Aqcdzk*<kzWG!)uTB?<}UnL+R7%H~h-=Fc$sXeGlA_w8jpI#Pe zQ(fI&yb+cH?!^{*{usO`!hZ|uy8a!3Us)CY^B-WvVr}rZ6xtET(wF%<X+Nx;yX~$K ze{CnM*KQCLb&<frJug8Eg^>MEsIuvM=HLUpyA43WV0KqA)t;#Bg>==YD*6G53!L-y z-`_8<@0vFP29el|Bnq4=a6qELJ$%s{R-t$)<>((pcgA-&0~7#1-3GI8EWxSUyPL{r zVPl>yb^tsO19CA^e<&&9A=5l(OEVa0T0)Y>ncE`N0|!Ze!P>*PS3G7w&zMlZ17#ih z!h+N-5WAg{<C|x!Z2mmlP8N7K&;ln7z5@IS<y3F_^)~)5_CojLf7B$~NCt`<_q3@C zcUWDfD6}`503LKo7FgRR=Yt%sqLS}dt`?4li`zkA&WkiGfrq#&RpCeGAct0SjTNI{ z?_fX5Ygyv=?+QvQ3#YQ@W3qh5_zj%X*Lj_2(X9fp%XrQqWovJ1D8n*>eS;elGL54; zUA0!z_lhT6^Q@uuh}=+0;8;qeuD`@d6(s;;s~PDX)zHP|mG}+OsBj#({-Bsc?(j3+ z#Ny`bi+19Snh7tb`MUz63eIIlZfrMgFDA*aFtgZ2+T9_^Zw*o~9Q=yjp{eI%&I<?Q z$o`{1K?r~Msh7u5K6cC@kXq&8v)7Yo%OwI(1R0EH9hcHKh{>I*mdeH5blxq}eEu`f zSlS17oiWB~nwM_R*$-KUNcLRn-!MzW4~ONu{W6!JUEL;9UYlktH|~WM(<emHZK@cb z%IBV<F51CaZ4${16R;(3TW}#x`N&JMTw$cd?)C7Z7)s4^OHrU&181`yJODbI`~G9* zeyRdjkv}2ohNq1BC#^YiQwFUc$8Tm$CT^NPE#F<oEZ;ZBj9G%?K75M#T-`wW7sr{S zhQD?2blAb#!`Enht!^+1diwm6bG`lW_NJ?FV;r5oVp^jYL!`JH-}Yi~V+Kk+{l0cO z=E=KR?s``4rr>KHW$-fs&iAL&maI$`goiIEeBYYJD`f7uz7#z(?CpKYZYr<F;Lro* zV8Eq7YF%&BS9^}}d~F5cz7dv|JtT6OEIa$G+vA+H0kT)m6o=P@R!@aq*|F`UdiBf5 z7pT+dd>SsEKVA3&j?t5)?*JmtSG<kx*KxE?f~<hLkYj#}XWX8dtuY6Fpq!K1xWK0x zwfyEqb31nyd87b%7iP6soBEmQ;gt$KOTufHtitE0B(2WZl?Z>ORi=Ks*_Z<Tc;^CS z5IpL0&((Z-1ICAwE0zMv=UZ@2;j;lWTMIom)`n+aDL?<@eA96`>L+@88KNBgjA&<~ zLqwiY8y@4`HyoweqmUS3)$`5K<5d3kWa6$QO&Gy#yy2fSsp+}E@Tdk!(k7<Rw+B0; zkOj?<8QA4Ia*N^9;o{%7XyHeg?2goHGgCeHMxvM7J>xr5tT%`q|0cbjhoCPw655iQ zy1(`9!u;qRxiwYoG)K$9P=ZzpahXQk#g$qqz;h4Pqp{{E0@P>X{BhjTYgl^$%BZHr zd9FFMNM%)M>&N`rP-_}nUFR_(Ju{}?=5*f6#^&BI>ZYKs^WS#uwadoZ`k;h4_t0jN za;x`hN(N!=B*>2RI`Rxhv;?h0DxXv2AJK{{?esM)r!Cm??(bTs?X(>Q_e^e8j$s_y zFC2gWqKxG|Khge-fA@pqraB;~?l#5JWN%)iTTa)0vPe>O&9OMR_WNC9-x0@xDF?!F zne+w)0aBxmBYUd6Mn8I3RfXHhKdN2h_ciE0$k6DsYf7a3NckG!%RTd@7Tbk)&iHsX zQ1z>T=?%;^&UG6ZX7`WUv%yIR7-7_QE`hfm8X3*rGg1eEK1od+mugK5tEKeCpUXbG zhSigvv3B=aa!Mc~d1~jAO77H6*_f(T%GELZ+rTR|2Vkzbq0R6!q>#O#rDuzPpq<=2 zIu^_J5$`U<V(H?zlz`M*G>uG;{o5DR%M-2@(}?S2U0sI!PX*<p9`*yjO2)wSdUW*1 zUs4vU_L+YDX1O~HzZ+my(CAjykUYH`)^xk9BaYt+8yq~gNQm2f&<p6RwjKO_7vDI# zHNszhJ396^3Q$9pD0(|4qo_wYFirugjf2(Q)(}Jvh|74Kb{qCI&SA^`k`ZgP+z#3X zqLqL0BSGv+DQ2=jPuXTDATlQ2C_?H%gr$s9P&r`1i0cIU;!H>d7I!J7I`y`5>#)s& z0YC4T<D7f*@+l@4mSn}w@z9u>gcHI~`t7{oH|bd2Z3wdELLiR(dhNfqi{~Cc{2(*H zpJ7+tp%R9?=p<pfh^w(F1uWG+<ozhCjAM!e2}JH!EaKy~v((C3lvLuzyfiYcuc`D5 zI_9mu#8+3zrwP{=3&qYe)GCNUZ|Iz}-g5W-kkz7Efr%BimGncAm9zvlJ<UPxB;Oyq zQH@`2{O0VEYecsCA(1I)hkcy+?Mvb+?u4rZYDwQrDP`R^Y~A0h>9pDmx+HjaYpyuW zIf}$FQ0J%BbN>`Qxoj2xMZgQgKxQMR=_c1pvhk+TBVn$@X*AabWfDV7bTgw%**?c( zWKovR6PPIv_)}Qm(fcYizLQeYKsdTBmAL$EEBGF5>>Utb!27f|({%I8jqm=1bTkQl zt_=X6DwKGOqfd=c)4;p2&SXOSGYD0=K5y1M$L^y?wALr!N^G2ukZu6~4Q@KXf3ep8 z++%@0vIgNN8v6x<JS)#ZIBZm27I|8{#fQx)Rjt%EX*P{xjwr)g-^5ToVv>7(yxEcY z5>}qDvT+t&WUGs%4N8n~)nyHos<;)3EcV*PKB)S!9c}r-CNWdEy$9FQOEOr7xD;U1 zY!V*_6<i`8Q)gfTFUBP>&W(LCr~a|{t@&p^J=i-65$uS{IYki>xN*y)!IFKclf8^> zJ%+WKMAg_E{@&=s7GvucXb>}~d`cUYFKJOy<_GPiIP}$v#lX^3*v(H=KqFfE?*7IX zHin*gv5u;*aZ(&nNt<q&DD}IfQ|h-{^AYWZon~6@=Q59|^d;f}BeiRfe$OOjA(w7s zb*_Ay9~cW1j0HVd(p{nf2_pbzzN_T0W*4!EW&O)aN?iB5ErMD@!dgasDr5;3A`noe z0O>Qus)mDyT^u)th6$XcV8}pNg%hzv2rVw2Nk0B7U;Tie5r1_xo=0RX5yv=tJcb^5 zO#_%W&K3$n<V4cWqnCh8e-|&|w$nL|`>{maP1`U63Qg&#-Wh$my-E(b*ESaO`5?mh z{Ut~S8Y`sz{AH8*TVRG#npM66fh31vI6(=DV#=VJEIS>l1p$rJ=HAvkVr>qO>WU%| zokL4Ei9~lrj>WY+xlg=H5Y24odtVl^FlF%smD%s5>i&JP4YEiO8ufMtB3zbz7Q@<> z4@D!27o+7Tll)ezQdPd>#HF2k2ne0Rw2_VpGh<JKzu1=Z3~x*^D2i<4+qZovI~{@m zd*{Ch+O4pVKe#z!o=DkhhnVckFIzLIT$5h+GSAWyn?d0nsXNyz-4Hw<>VcicP<qi> ztfe@{WZucfh7Ra{zks-Fi8q0)`szVTLLvp)=UziAK{iyd-s>+6<2Oy}F5~GD(Nk1a z1B&Ot<R9ouxh}LABC)HJ0JfLo@-RAlmE+Xm()<xf0u1ppvY_rD!ZEn9=-S4@L(!ys zGeg28MgY_>qNG$ya(%l#kwp6lXzw~FRr$6a7qXOhKoI^<&(G_qh<5j?=vgf5`A&N) z2ktH*A*z=6S-xUYT#Zyk#sW=^*&``?ImcxGmX@VpGbYg{a<-TtQG+dCo&vK?b_H=y zy}X%TcU!)N*(XwaervmCh@F^8>$6pFfwCxO#sFB|nyakKDx3IEG<jLmplL)c)&?pn zo@x{xU8^Gd)I8RtD-IbkG0?RqLr3L^;#_e@l0(&4(g(Nw<-XqI&$>)IYKIX@gY-@g zkFv}~LQU84X-)8Hp85SG=~Cbh``XQo;+0V5c!VbnGqT70`@=2#uj;6Css!@X$A?gi zIvjtjiFn-}<&8}xF$D@$)1+*D&fL^;d}X2eY-8uh<nWcR>(q5#IJWZH0^@@BW%;eA zuEM_lE`Lx@umrD~kl-q<rNrzY_Ja?q5=n@Z8ctu=V}lA<NCTD!uakdRbSD$MPvZ+& zRn-dqUGK4D6r3~s_=r2D^)h;;FCa0necJ=A@axW~J(uiLFM5{Dq76oB?8eb2L(OOp zvspN5aD&Kre4*Z9ab7;cg&ZD{I6u+nt(u*<xPlT<20^p2NaGUoD(N4_T)vFW_ftLW zJ2<giD%!oSCSQf3bqfW_a1NnLCs@%gIQK3mf7m(HiP-Vbfd(k2qu5a}GHS^ija<4G zCCt7@jf7TCGnMxRSAO7<SO@#1m&$J)d#^)xX+}oY!7l1$@v{0TVC)2o6SpfO$n86{ z_EX`0e^&SSkel@6%D?La3up;}5QXN-I*u;Ub{G8Wo&_rPmujXkB<?gADmjz7LEnXG zr{#b*o&I6UrhVvnnFp+GkjXVYGZ!nQg;vuDgY?l+@{bB$F|hKgT`|}?^VzuS^Ko#h z3DymDY;7eDnJDY2W=_PLrDaF8gz2XVX{uB(_@=a(a;<|CcV%vQKKh?Wob)_=oY#W? z>LsYzaHco*hmS4_F9qJ4)CE5TNIndv2U@#k`1RZtv{0gJOWsOu1|N|(aluE!-mJMF z;60G;JA&w4qia3yzq|6(*Ii#JL9-V9Mib)m3^O~9hZ$?QCY$*dftXd%Z%`ywv6}E9 zCOZ1W4o2;e`z!H^&&FrMVqLS=ovWqf&P?G=)dvpDMh}cUF1TXt8v_y}mr>-&ywgo$ zWCB#8!KX&jy>WhzT&U*|!h(tlRq{W)o?R?}da3Tq*7|Gc%jL+dnoe$fa7gbZ;{#+d z=+@(+S1#8nv5oj+ho;z(E|wqJ-}cdHh5Wx{B^?bJm$g55ODlGG*ZtxL9!Q<qDYNCE z8!Hs65@w0<`RC?qzt>hs{HU_`?&h(Qm>L>jpg}bP=eT~`BzjH`wPTYR?hyYQj!(R` zbFuQG-WLbhkGC;2JF_JUi>)_{6^ixq*)<%OkfFW|<jnn*$MJ{F2^(jULpe_E<<0lU z^T366zmAUX;a`8>j_WGvaoo)Kh;{Kzj0d$}cCyY~j%@lTqMmi+__iwuQ>3}Nf$SKk zU6R1o&Ut>DO+`VUZ5;T1S7476W0k0Jg1p~OR^$$K3QsB0b51nrcik>9qER=_9XB>g zSs4=<JJ$!CE@E#j3?=9rEs8<z=w^yS;=Fjxe@mTr#e8Iy`-*soBq8B!9&{*aRCi;- zjpe{w*WCJpb#rBZt6x%UpJ<382AAt{Bj9|iCwLEE`t}c`1!UeGnA$ZO2OFgCIA3@Y zve&Z+hD0RBnu~~jYaFhcj13&qe8?grW*(S}jY#ksbP6XetYq(Wf~3NE&F!V<0)Laf z5U^V%b@Eh?_{^<d1w*rFf+DYWCb|xL1#r7h9UO%~TKSTye)c4jq0dK<X-mlw!Ytk& z^^)yRlM;vCq$=M(l@KSjgvHzV59F8D80Qr2F64bIwWNql;qn%DtR;s<E2`RO*)I)x z_&CP`@s-ir*pANCa^6{3vk?}4`#Lq$s@cRf0+}^!4%wty*NRE!#B>Qc{_?oJ`GQ?| z_eX&cvG>IfoyxVQ@!wrp)foe;o9KA)+*Y2p^w8vqw7q>Mxjl2lFU_6uu_;tsx;FKW zKMbt)-?(z^7zDKy&|3bKV>Szk3l2`<U|wGf%@o2J&mp+izJtpSMLT-hk`tpQ<sRT| zlfq*H^cVqhx0N2*9<ErMBpR#+pb{0(e0e$rBq+fcn+CJbopllx6<sV(J)Ip_pANji z?YMM3x3P!3yo3NIYO$4gEv;s$W~KaLogZVgz5q=ORX)ef^9Uv=J7ptUd#(i*c`oht zHU_~sv7=XmP@cHl%QK4S)??IiiR}8!HUoKYH+@LIlNKsX`iZs*O^DQe+**84VLlYf zn`|>31b<AKO1ZCJwt%cKaN6FR07Hxk4)Z?}*-AQYo8%tP#>z9;x*rleeaQ-z1gy-( z2Ex)g2cEUEeA}nGJH>eN15zbkDFydJCN0$+rKR%reYSuv`Vlmyp?DPZ4CAE?XTCWF zMX!6*wl;ssyDc+31AGDud3W#1AzPz`v81vx;zRRvQ8iVJ2rVRCE_~q&Uj}rLO1Vz9 zxaR(MD~T@$ifNr%={7>eT%3thjlj!X{tg}hC1!$mR#vuIXPEsrAOUbK=or2G?|~n9 z>(q_W5WjjEU6IL64*k!gbR-DOdf^d98ecivLV8n@o_%f9<~YPJQd47fP2X?oUZ_RY zxE9;lA@zGJ6<9hRR*MIUa?ONoA%o<o)VVM|pVkGbn|8TdClDr3=XxYU8OG&kK5Q>~ zm}e0>(Tew9t$#8W1p~~NdN=(R3sh?VP5X5#m)gSSt+4Ax8!G$l#Dwd6BMkWq_UuSL zimEmLsFb~4cbL9PmN;kPz&vpe_4_EVA>KG^=Ni!aYXhw)3+(2>epflToEu8Rw#Y`W z3aiX1_x{#gGiTq@I$X<njfRlApi-;r5&nz`TCorT?E1!ZuAb3-c#8(qKWH)Sdijof z<p2%NBb_c{jk9G!bO`_2p%SihP!22;RJW~EUvt$tisY5KAyRkhryfa;LIe>T*NG>q z?qoj|u&|Pf2cGX4EIcq$;k?aDX|ato)NydRp#QR=p|>(cGT@zgUKm{1PIEG^#n2Vw zq8~obBq%6k4}TpOh%F?fsirYq)b!4ttFKJy<{R9LSqJGELTyRa{Bj|2YJEW<T2#E5 z%I8br@@rmKth=9CFZtV1UXT5&8}chBbm>SXL~Kb~c|vJ0-!%7!c`DTTY`1RrI6<R! zvNIx>R75)sJ+pYcN}i^;V6%_|yi+lvUMeVB<ow54R|t(smR1ZT$ZH-2q+AbqTBKHC ztu<5;174Q<?sV-wi>#}*|N4z-`HTUTc@SzZ5}kf@LDeP8_aK7w9r;3=v+CXV=7Gtr zglECWK__PBa>MNN`o;4179;$sxw8$-Q>9xsQ9NJD5}UIYI@e}Izq(~+bP8)$%sGV% zhEF}GkhY@|MNn@*9HSKy1Vxdw(D;0c;=Pzoaa5b1cHi)Q5Y|l{#^TuFryhtA`dK>y z^>F;hDEa(HFz{va`p-kq71w|Pb9UOO8IBLZS?3;L{fuh;jR>BIsY(Hz($iN%)>$=t zV7ySA<0tkqCb)66r~vB{hjmc%%+OyN8t6Pn`63flp0n5P6lXcM6nk+(?hK(*6gOw? z^+W9ZFcepI-7#f)GUb&4d++O;CBrO_-mvU)(H3yNx3TJ0*50h?W?K-rD`3+A<dV{@ z@c<FF?&nyFB_=EQrNU^~W!0c*nW89gCNF8=J^B4|sA#e%p2+K>H7-8hq^KrGr97Cb z$Qh?^(>_cuFEz51azxNOe(JY?zC}wI3SwVD#iiGhiD|6lNek#oLBrRmseh1NNrElR zOIPdbB$;N<0c<(Sbz0y?v9?j10ccF70g2vhmfKMkX(@wgOj=GX_+!a*U(~)9uq0_w zx=B?E5T<pK*73wI`iy^0Gt)K9t}YGu%_q|Rw7$qHyNF3A`?Wz<Tn3tl=ngW=ATXzc zgYi$w^f8EmcWhwAxr5SOB>$|=i=XL#5_j%S+r!D}gW`G{n%CiDq&!VRKX%&kaI7_e zbAkt=3|b6KTQwL=V23x~GG#qITfb0=7`=zYCB9|dc$nZ?bAP-?I`|9Va}su%np!-h z?=j0x-BoK<=7_t%3B&gJ&cSDG(5(K`q!)9nYH`HnW24VAux(+X&&)hyZgY8OyuzTa z?#z8}2c@#<J&+u&u&K`0F)CTebmAiRs7JLii)u^K#A0?mB*lydy!pju=cQ`bCsmdn zDd}U@>6a`-VvVFuw*X4isEaM`4H#ID-aGMZx{Tsod7=k{^>ZPQdJ>DSg0(O&3QKsX zLX1(iSvDiBeV4aK!MIp%fxXK1Dn<noC@%LGz!<6=jSnEaiS0Fw;m<5{3&w1IsOQbO z|B8Ud7jl7@HB*FHi$~a&%$(AN=pL@4bGyM%O17R2tl-w4m#s!3&^hI?@~|hXa!=w> z6&b0fuZZbKVNGcR!4^tJ-LQv4l^6|{rXh&f3TpT(&d2Ia!}v3kUUwVq-z$lpDN%~! zOTPw7u;6IobJq^#Av#R-hUii(f1pb@)T9B0Q62;q`+zA|%<##08xOI%h3?oChVfUB z_cK%EM83c7^6|j=*pvQ<gl`TdwUAh{eF{r!9Jy(2UXnz5c#ebD0p1&WrqIUZS@_AD z^gi+~c8^Ll?q_+~H7pKiY^`M-D-naGv1|-JHaGsZLD3ik{$a8F3o!bEco%lz1|&uy z6)lM$$H<V4dK^nW7EoGWF^eK#4-;0cvweAp22{Z+b4v{pR?Z-1+b11wC$}q5m_J|T z&$+8qaF)}gmM6_xpHZ2HHWSxzRB=q)+d~6w)0vj{m?>;W)e=a<nUYmq6gdsqtUYKV zKO=szwuyO@_sckj)ITfyZ#tsYii+y0YqclQeMrHOnIJ^e`GbFb@hE0noAC15N~Py) zL5`j8M;vQghR<*QE>Z-V*jy!km}Q(Js6~>-DaaZIo7<6-Fq@f#{cRBV@xHDk&R~kC z;KMBip;%JPo`Uk+ob%>OH$4D@PD^jx8kf=}5*Gj>oiAt)Ew90nkT7$pduQhp^d|pP z#&C8j3qH4ZS<)Y#s+QaG)Sb~JWjwp0t{ypy-|rz|)yvmq<0%fvs{>SSoI6p%3^?BA z%x|*XsruQNFF}o-2WY2;$E=vL6+|O$-8l~J!u*x;ak7Pf+E}#WQ$DOLFWUz^aSUt- zKh<iQdPG(u0&6|#nh{g6>1I+0K(+36T65>SO#%%S`W-Gtdg0BwRV(Q9Y#a)L@!<*r z!YMyTh~6<@I_0$pMzjh?O3JVU5V^Q`1lqeaI(?DZdnKT6g_jgRH&nhCI?%)N#}ZjQ ztgYYOK_ML%Z29(}QihVMuVTay#kgP<Pyc-iyU9f{6ON@M_S95-l{rt&MMKWMa*A>) zgosq9r9ifeA3T|t3d>+F+?=WP+jzTd|E!3>7F8@JII(ra40{d2*(V4pn5w(2%=Q!8 zM8+OgsiYbP=giK^f0-asmIQ`h5a|B?{bZo@9XmQG;*uXkHm|ak&SzXIKdVVNuS6sZ zi`OEU(_n;=7~=x%Qk05eifl_%zYiD_T2^a6cSDQl00`pEUR{n-shHTy3t}~I2UCXw z)S09jBO_361Vgsiu1Au8m>A2Ix|_ruVmC^l?CG_*%;l)M8z{9kYw}a*=ENfZQer_Y zK?Yg~jC-c3{D^(4O3>zB$tUWJuNM7L@Ax2&MaF9}kDukeUoZngenDPYXT#|91l)0` zWNWuzV0m`Euo7Jz6?gt%GHseWRVX*?><jW&_Brw4w;*puW}3Gi)1kUTaG}b{&(&1B z9Er7TSBTD7Q%Z@3^bNiXJ6%<%4?okB@^{Czl#VMOI$uuRm^Cc}?vJohb)11K1$$8& zp%Lpu+_D@}<UA#L-1F01;!Xt2ny@r0^%~AMmuq5O?%>ml@og96c}7Zn4+VP9uo<dh z7`<^8Vg<20%1mAs4!c5qTv{>ADm%-Z%s+U$_T0wTe*f>g^JDB{yl`8Qjoy_C%s)Jm zGl3G=>&((R5p(<kPIP6x3nLHy$%acwch$XnLDkQ~dybKxIm$0onB_@Ea%TywU9B3_ z5G-~Avl#^^F-=qHs+;+zAv_;(awI%t-2N^5b!|)p*(%BSth#EgKiGTjjy7RAa2x3A z7!ogF#+T+(a2P^?jU>+428Ftb(L`nWfiT^DWT38&J-MB5DTim`=Z1w}*Y^G0i(qY; z`U5-UveFu5d~h^m?882I1~oY2<Lxg(R?E}N=)_<|M<I%q6<40`frU>AUMiBq##f~b zs%c|)EK=(Y?-oHW-#_tiCe&7cwH!n&i5WDGX#BXA5P^C%-tcy^syaUN^;B4oY+|`p z`n&nXQhSg3O2O{$F+!%r)c&3u@IYnza<$FoBbGcnkEKaPm0Dsg>NWU7bPrO+C1}?! z(ujXhGjL6j$<=!W<GmL<pOy|Rv#X{`0|1e1tmTWIM_C9aV?H7yA~p&jCl!eidi!|R z^T;iI_k4Rz8S)@<ca_y0&cFY45v^GIrV$!+@)za2Q*h?`pLS6EUJgqV6Ar*$%v7z3 zi<K9HVv0nUiqRla2VcHg6=UI>KZS}(bZGmudkj9Pl17JQr?20*En2Liktn00nuDUz zUdPyCjSSCusxRmr&Q$B+?L**o>d4&=X%CvpnV1jmz4(ai_m2QmIC%SU;&F_$r@!a9 z7TU}kl?SC&_^d;{y0IY_g+szYc%NF4EFUC4KC2FwYU60MlZI$i;zCGWiumQO@@@6? zPq4i1P3UrshKrB>JY`r+YZ-dFKnhiyZIDMu9AaDcAAe!fK<=!SOr}c)l(X~lf~Gz{ zEe@g7)wy15K948_-v21Fa}LS?zVqCC*8}==`}X?!T2!y8u}v<25Dj5qJGNi61-8ZI zkzag#gQjPY-Bk0CuJGd;%#)RpR$6rc?bpb&*45FEo;OA@=?mnv))8B{Cs!tQa1<e^ z_V-RmOQR%}kPLE4uXPzbf0|~!J8_U6s1H6+2)u|0$=Ma5e!)D4S_+141Q;#~-;EbN zlNUYyro9^6)h_jpY!Vy!C?)^p7sj3jaW=Bo^)(T&Z)F8V9{7HUO-Fj3jJY^RI5tBu zc|=_-!4JhuWGV8{tz;uDBl?TPo7_}1y+Cz!6GNRhT~ebaj-P5KeRM!NxhX$oWf={< z38wbh+{<UALvo=n`)*g8!7n{mb3K>3(pPg(_q&U2BdL@VUaZ&q2M*drdoPcd@PFyN zfnh&BY46r5D0@`JfYm>(=l-ND$HN;MOkzn;pLlQ5mq5yso)JB6N&??!zs~n%{29>d zhvx7(9?Jj<^8}~twgt#yaM-d(S{dvAX(Hg3Y_5&8wvH|TJ-UOXT0VevbopD9RtarT zTxD5Qoe3#FWSgt!$&40WB6Ig9_%bUv4maqa-t%g~?3ll_o-h<>a;04KOjUF@c<y<> z?BKpIf9B2qGkQHTsIGO_&;X6=4T6V!*`XNtz{+Y-<~k6&skmBABPU%|P7jk|J7v05 z5v^&2aiG7vBW1a*x45dKNor91K-lJLd`?S9*<qDQRpl^mT*F=@adn_fJay~wBWDgM zZCpQJ$}2bIB@PZbNPkI3r43B!d46@-`S)A=my}t!fkbN3lxy&<%p+?s+%FhPI#bYR zs=ngLkb(6Lnb^7js6J*RxKpU-hkwYn_R7LFP&rNYn`bGi^VHUP`M9Q+vZZd=Of>NX zkboWL7>Ew8OVQTk&&l@0jM`DnH%=NCXmw4LDV$-UQCbmit_7J?iH4ED+IH9m#Iczm zr<!Z?HL3<-uH&$_hE+e>wop@cln4ZE=}S?|$9_`LrxPzU_Uyc(vSk+mDe$(knw1?E zuVu%e(aT9*;Muk1P8@4td3&pp2~oKdAv^KH(ioqj1Gk|wkHxx`gLBOOa|@4CwQTBZ z06$XRA`01I*>{i#e0XrUd(OFb`S^PFqGoa+<fv#ZzvlT#uKewHxooilV&*InKjU+3 zlU17H@?!j$)2+E72#JHKV=c>%WS82?AA;2im8M!2ixJW+F^ou;yGqBuTCtzutTJN` zG7sb*JNHO}pZicD7gFcjZ4zg6nv^nVRwf4K@7}>LU&-B>o@YL&^c5N0QdGGxi>Z-; z@@8NXv0`AlghnSC*TiyH(#Q`bU+MvIf^*{UpLdjBr_oOz)RbSxEa!s}Sh=~+<y)T@ ze7gB-C(z{mplRx>qY0w?3QIAVCko_->2SGgQw>j!E4gM`OmdwBe_+{e^({(}n?czw zTFFz><J3zFNdyeH5Bb^T(P}WUVY?pw8~!K}^qUVGx8TRik$=1||75&go^G#8a6?2} z{OusqL+VE0tB0A3zps?E;7tDZUY3Q8m+f~Ns^hpFGBaW<-?rEN9Gg}uXg9y4T8&~# zYcvI*iG1F@OV;x&@`6%pU!06i-qiooXNM2g)~}CjC;b{vd2RRG87?lEY%Z0HknPl3 z!$@JnrS4?Ty7B^xS|&$AqQ(*!%zNNSs%i1Wx35tXCufu72pOS0*J!Mq)7?$y+wK65 zg87a{hkUFLFoD6cZTsGigm+-*g181gJ|di|z!&o=ujk1P{CtA>Isr0UTYcgg+zqeh zLdW%0$U#6vwkzu(kzZ$2`t0(F!iDE>E+wGk(<5YB@|wzTEr?Yudixzndq4K)+f^Ow zgmj`>CRQ`eWLk;A;!Rrz=Y&8}rU?Q62>M16CR2P>xi9#(<7rIEpWvdu6u?LCFs%88 z!AB_|3TSatp|0JBu{GOimL{@&hBGaaLdQ@1DsUZ83CxO*qU2?r^;yb;N_2W7DwScH zqPiN5!6E{l-<SQNx-3A$tgJBTJVoB7tIv2s$sY12Raw+~K-c~obve$^X`}0<&24xp zMoE7c53!i|E0r=&WVYW?jrEPt?AP0Ue^`_H#b0wnw|7-NiG9~$ib6D(>=jDKvEy=f zl24_%8aO1eI?9E)NUY`A6eK*AUexKG4bw4lL@%V>lO^0-wUWuNxACm(j8*MbRXG4? zuZ1@N0)#gJgxB1EgdYJBfcL5eUd1T}>A&jaU-SQY^c>y1{p?&^==gX9gn0x3hycW5 z^#4M1yqdoGANl{FKPsXA=Q<&?H_+Joy|uTUxUHw%s{#n{@r!Wt3vdhY>+|!8^9hRc zz2)TN7w6+U$kSf_Uk0vj@15)+|I^?V$1fnxC-C0}0xiJ(R|B&De8CRvWG@bUO;la2 z9qcshK00_i0)&M4z~f$LuNcz*A7kY7{=Xr61~-qd5Q6^&(YCkuvhxNA3yb(USiiPX i|KC<UH+yeCYfroX*BxIKPpMyl09BxtVx7EI`2PXnNgkE} literal 0 HcmV?d00001 -- 2.14.3

2 1

[libvirt] [RFC PATCH 00/10] Resolve libvirtd hang on termination with connected long running client
by John Ferlan 17 Jan '18

17 Jan '18

This RFC is a combination of a couple of different patch postings that I've combined into one central "stream" of patches that can be discussed for their relative importance or need to fix the problem. Although a bit long winded, I think I've captured enough history for anyone so inclined to walk through the history to understand the maze of twisty patches that it takes to hopefully resolve the issue. The first two patches were presented previously, but not accepted: https://www.redhat.com/archives/libvir-list/2017-November/msg00296.html https://www.redhat.com/archives/libvir-list/2017-November/msg00297.html However since that time, it seems "some form" of the patches is necessary. Most importantly making sure the virObjectUnref for @srv and @srvAdm occurs *prior to* the virNetDaemonClose(dmn); at cleanup (IOW: out of order for a reason). Doing that also requires any program started on the servers also has the virObjectUnref prior to daemon close. The 3rd and 4th patches are a result of discussions held in mid December related to libvirtd crashes/hangs and some possible adjustments to help. Discussion starts here: https://www.redhat.com/archives/libvir-list/2017-December/msg00515.html This led to suggestions to move the toggling of services from Dispose to Close *and* to split the virThreadPoolFree into a Drain function that could also be called during the Close function rather than waiting for the Dispose to occur. Still testing showed that just those 4 patches it still wasn't enough as libvirtd ended up just "hung" because of some patches Nikolay posted that add a new shutdown state, see: https://www.redhat.com/archives/libvir-list/2017-October/msg01134.html Those patches languished mainly because it wasn't clear (at the time) the relationship between them and another series dealing with libvirtd crashes that was partially accepted and pushed: https://www.redhat.com/archives/libvir-list/2017-October/msg01347.html and followup discussion starting here: https://www.redhat.com/archives/libvir-list/2017-November/msg00023.html The 9th patch can be used to test that the first 8 do the job. The details on how I set up the test environment is in the patch. If the sequence is run before the first 8 patches, you will end up with a couple of different hang scenarios. So if you're compelled to see what the big deal is, then apply this one alone and have fun playing. The 10th patch is the one patch from the partially pushed series that wasn't pushed as it was not deemed necessary. It's presented here mainly for completeness. John Ferlan (5): libvirtd: Alter refcnt processing for domain server objects libvirtd: Alter refcnt processing for server program objects netserver: Toggle service off during close qemu: Introduce virTheadPoolDrain APPLY ONLY FOR TESTING PURPOSES Nikolay Shirokovskiy (5): libvirt: introduce hypervisor driver shutdown function qemu: implement state driver shutdown function qemu: agent: fix monitor close during first sync qemu: monitor: check monitor not closed upon send libvirtd: fix crash on termination daemon/libvirtd.c | 46 ++++++++++++++++++++++++++++++++----------- src/driver-state.h | 4 ++++ src/libvirt.c | 18 +++++++++++++++++ src/libvirt_internal.h | 1 + src/libvirt_private.syms | 2 ++ src/qemu/qemu_agent.c | 14 ++++++------- src/qemu/qemu_driver.c | 44 +++++++++++++++++++++++++++++++++++++++++ src/qemu/qemu_monitor.c | 27 ++++++++++++------------- src/rpc/virnetdaemon.c | 1 + src/rpc/virnetserver.c | 5 ++--- src/rpc/virnetserverservice.c | 2 ++ src/util/virthreadpool.c | 19 ++++++++++++------ src/util/virthreadpool.h | 2 ++ 13 files changed, 143 insertions(+), 42 deletions(-) -- 2.13.6

3 19

[libvirt] [PATCH V2] nodedev: Fix failing to parse PCI address for non-PCI network devices
by Jim Fehlig 17 Jan '18

17 Jan '18

Based loosely on a patch from Fei Li <fli(a)suse.com>. Commit 8708ca01c added virNetDevSwitchdevFeature() to check if a network device has Switchdev capabilities. virNetDevSwitchdevFeature() attempts to retrieve the PCI device associated with the network device, ignoring non-PCI devices. It does so via the following call chain virNetDevSwitchdevFeature()->virNetDevGetPCIDevice()-> virPCIGetDeviceAddressFromSysfsLink() For non-PCI network devices (qeth, Xen vif, etc), virPCIGetDeviceAddressFromSysfsLink() will report an error when virPCIDeviceAddressParse() fails. virPCIDeviceAddressParse() also logs an error. After commit 8708ca01c there are now two errors reported for each non-PCI network device even though the errors are harmless. To avoid changing virPCIGetDeviceAddressFromSysfsLink(), virPCIDeviceAddressParse() and related code that has quite a few call sites, add a function to check if a network device is a PCI device and use it in virNetDevSwitchdevFeature() before attempting to retrieve the PCI device. --- Suggestions welcome on a better name for virPCIIsPCIDevice, or even a better approach to solving this issue. Currently virPCIIsPCIDevice assumes the device is PCI if its subsystem starts with 'pci'. I'd be happy to hear if there is a better way to determine if a network device is PCI. src/libvirt_private.syms | 1 + src/util/virnetdev.c | 25 ++++++++++++++++++++++--- src/util/virpci.c | 32 ++++++++++++++++++++++++++++++++ src/util/virpci.h | 3 +++ 4 files changed, 58 insertions(+), 3 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index a705fa846..bdf98ded1 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -2458,6 +2458,7 @@ virPCIGetVirtualFunctionInfo; virPCIGetVirtualFunctions; virPCIHeaderTypeFromString; virPCIHeaderTypeToString; +virPCIIsPCIDevice; virPCIIsVirtualFunction; virPCIStubDriverTypeFromString; virPCIStubDriverTypeToString; diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index eb2d119bf..a9af08797 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -1148,6 +1148,21 @@ virNetDevSysfsDeviceFile(char **pf_sysfs_device_link, const char *ifname, } +static bool +virNetDevIsPCIDevice(const char *devName) +{ + char *vfSysfsDevicePath = NULL; + bool ret; + + if (virNetDevSysfsFile(&vfSysfsDevicePath, devName, "device/subsystem") < 0) + return false; + + ret = virPCIIsPCIDevice(vfSysfsDevicePath); + VIR_FREE(vfSysfsDevicePath); + return ret; +} + + static virPCIDevicePtr virNetDevGetPCIDevice(const char *devName) { @@ -3236,14 +3251,18 @@ virNetDevSwitchdevFeature(const char *ifname, if (is_vf == 1 && virNetDevGetPhysicalFunction(ifname, &pfname) < 0) goto cleanup; - pci_device_ptr = pfname ? virNetDevGetPCIDevice(pfname) : - virNetDevGetPCIDevice(ifname); + if (pfname == NULL && VIR_STRDUP(pfname, ifname) < 0) + goto cleanup; + /* No PCI device, then no feature bit to check/add */ - if (pci_device_ptr == NULL) { + if (!virNetDevIsPCIDevice(pfname)) { ret = 0; goto cleanup; } + if ((pci_device_ptr = virNetDevGetPCIDevice(pfname)) == NULL) + goto cleanup; + if (!(nl_msg = nlmsg_alloc_simple(family_id, NLM_F_REQUEST | NLM_F_ACK))) { virReportOOMError(); diff --git a/src/util/virpci.c b/src/util/virpci.c index fe57bef32..f22d89cd7 100644 --- a/src/util/virpci.c +++ b/src/util/virpci.c @@ -2651,6 +2651,38 @@ virPCIGetDeviceAddressFromSysfsLink(const char *device_link) return bdf; } +/** + * virPCIIsPCIDevice: + * @device_link: sysfs path for the device + * + * Returns true if the device specified in @device_link sysfs + * path is a PCI device, otherwise returns false. + */ +bool +virPCIIsPCIDevice(const char *device_link) +{ + char *device_path = NULL; + char *subsys = NULL; + bool ret; + + if (!virFileExists(device_link)) { + VIR_DEBUG("'%s' does not exist", device_link); + return false; + } + + device_path = canonicalize_file_name(device_link); + if (device_path == NULL) { + VIR_DEBUG("Failed to resolve device link '%s'", device_link); + return false; + } + + subsys = last_component(device_path); + ret = STRPREFIX(subsys, "pci"); + + VIR_FREE(device_path); + return ret; +} + /** * virPCIGetPhysicalFunction: * @vf_sysfs_path: sysfs path for the virtual function diff --git a/src/util/virpci.h b/src/util/virpci.h index f1fbe39e6..489d8a777 100644 --- a/src/util/virpci.h +++ b/src/util/virpci.h @@ -190,6 +190,9 @@ int virPCIDeviceWaitForCleanup(virPCIDevicePtr dev, const char *matcher); virPCIDeviceAddressPtr virPCIGetDeviceAddressFromSysfsLink(const char *device_link); +bool +virPCIIsPCIDevice(const char *device_link); + int virPCIGetPhysicalFunction(const char *vf_sysfs_path, virPCIDeviceAddressPtr *pf); -- 2.15.1

2 2

[libvirt] [PATCH] news: Update for 4.0.0
by Andrea Bolognani 17 Jan '18

17 Jan '18

As usual, a bunch of changes slipped through the cracks during the development cycle. Update the release notes to include at least the most notable. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- I'll push this tomorrow morning under the "can't possibly be worse than leaving it alone" rule, so that it makes it into the release, unless I get feedback earlier. docs/news.xml | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 064b9ae83..d034be99a 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -35,8 +35,48 @@ <libvirt> <release version="v4.0.0" date="unreleased"> <section title="New features"> + <change> + <summary> + tools: Provide bash completion support + </summary> + <description> + Both <code>virsh</code> and <code>virt-admin</code> now implement + basic bash completion support. + </description> + </change> + <change> + <summary> + qemu: Refresh capabilities on host microcode update + </summary> + <description> + A microcode update can cause the CPUID bits to change; therefore, + the capabilities cache should be rebuilt when such an update is + detected on the host. + </description> + </change> + <change> + <summary> + lxc: Set hostname based on container name + </summary> + </change> </section> <section title="Improvements"> + <change> + <summary> + CPU frequency reporting improvements + </summary> + <description> + The CPU frequency will now be reported by <code>virsh nodeinfo</code> + and other tools for s390 hosts; at the same time; CPU frequency has + been disabled on aarch64 hosts because there's no way to detect it + reliably. + </description> + </change> + <change> + <summary> + libxl: Mark domain0 as persistent + </summary> + </change> <change> <summary> Xen: Add support for multiple IP addresses on interface devices @@ -49,6 +89,16 @@ </change> </section> <section title="Bug fixes"> + <change> + <summary> + qemu: Enforce vCPU hotplug granularity constraints + </summary> + <description> + QEMU 2.7 and newer don't allow guests to start unless the initial + vCPUs count is a multiple of the vCPU hotplug granularity, so + validate it and report an error if needed. + </description> + </change> </section> </release> <release version="v3.10.0" date="2017-12-04"> -- 2.14.3

2 3

[libvirt] [PATCH] qemu: avoid denial of service reading from QEMU monitor (CVE-2018-xxxx)
by Daniel P. Berrange 17 Jan '18

17 Jan '18

We read from QEMU until seeing a \r\n pair to indicate a completed reply or event. To avoid memory denial-of-service though, we must have a size limit on amount of data we buffer. 10 MB is large enough that it ought to cope with normal QEMU replies, and small enough that we're not consuming unreasonable mem. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- src/qemu/qemu_monitor.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 046caf001c..85c7d68a13 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -55,6 +55,15 @@ VIR_LOG_INIT("qemu.qemu_monitor"); #define DEBUG_IO 0 #define DEBUG_RAW_IO 0 +/* We read from QEMU until seeing a \r\n pair to indicate a + * completed reply or event. To avoid memory denial-of-service + * though, we must have a size limit on amount of data we + * buffer. 10 MB is large enough that it ought to cope with + * normal QEMU replies, and small enough that we're not + * consuming unreasonable mem. + */ +#define QEMU_MONITOR_MAX_RESPONSE (10 * 1024 * 1024) + struct _qemuMonitor { virObjectLockable parent; @@ -575,6 +584,12 @@ qemuMonitorIORead(qemuMonitorPtr mon) int ret = 0; if (avail < 1024) { + if (mon->bufferLength >= QEMU_MONITOR_MAX_RESPONSE) { + virReportSystemError(ERANGE, + _("No complete monitor response found in %d bytes"), + QEMU_MONITOR_MAX_RESPONSE); + return -1; + } if (VIR_REALLOC_N(mon->buffer, mon->bufferLength + 1024) < 0) return -1; -- 2.14.3

3 3

[libvirt] [PATCH] qemu: qemuDomainNamespaceUnlinkPaths: Return 0 in case of success
by Marc Hartmayer 17 Jan '18

17 Jan '18

Commit 7a931a4204af refactored the code and probably forgot to add this line. Signed-off-by: Marc Hartmayer <mhartmay(a)linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com> --- src/qemu/qemu_domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 5c171e4cbd6c..441bf5935b14 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -10212,7 +10212,7 @@ qemuDomainNamespaceUnlinkPaths(virDomainObjPtr vm, goto cleanup; } - + ret = 0; cleanup: virStringListFreeCount(devMountsPath, ndevMountsPath); virObjectUnref(cfg); -- 2.13.4

2 1

[libvirt] [PATCH] AppArmor: Allow libvirtd to kill unconfined processes
by intrigeri+libvirt＠boum.org 17 Jan '18

17 Jan '18

From: intrigeri <intrigeri+libvirt(a)boum.org> On startup libvirtd runs a number of QEMU processes unconfined such as: /usr/bin/qemu-system-x86_64 -S -no-user-config -nodefaults -nographic -machine none,accel=kvm:tcg -qmp unix:/var/lib/libvirt/qemu/capabilities.monitor.sock,server,nowait -pidfile /var/lib/libvirt/qemu/capabilities.pidfile -daemonize libvirtd needs to be allowed to kill these processes, otherwise they remain running. --- examples/apparmor/usr.sbin.libvirtd | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/apparmor/usr.sbin.libvirtd b/examples/apparmor/usr.sbin.libvirtd index a1083b0410..0ddec3f6e2 100644 --- a/examples/apparmor/usr.sbin.libvirtd +++ b/examples/apparmor/usr.sbin.libvirtd @@ -63,6 +63,7 @@ signal (send) peer=/usr/sbin/dnsmasq, signal (read, send) peer=libvirt-*, + signal (send) set=("kill") peer=unconfined, # Very lenient profile for libvirtd since we want to first focus on confining # the guests. Guests will have a very restricted profile. -- 2.15.1

4 3

[libvirt] [PATCH libvirt] qemu: Fix segmentation fault when attaching a non iSCSI host device
by Marc Hartmayer 17 Jan '18

17 Jan '18

Add a check if it's a iSCSI hostdev and if it's not then don't use the union member 'iscsi'. The segmentation fault occured when accessing secinfo->type, but this can vary from case to case. Signed-off-by: Marc Hartmayer <mhartmay(a)linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bwalk(a)linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com> --- src/qemu/qemu_hotplug.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 6dc16a1054af..83d0e1c71a8e 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -2343,8 +2343,7 @@ qemuDomainAttachHostSCSIDevice(virConnectPtr conn, bool secobjAdded = false; virJSONValuePtr secobjProps = NULL; virDomainHostdevSubsysSCSIPtr scsisrc = &hostdev->source.subsys.u.scsi; - virDomainHostdevSubsysSCSIiSCSIPtr iscsisrc = &scsisrc->u.iscsi; - qemuDomainStorageSourcePrivatePtr srcPriv; + qemuDomainStorageSourcePrivatePtr srcPriv = NULL; qemuDomainSecretInfoPtr secinfo = NULL; if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DEVICE_SCSI_GENERIC)) { @@ -2386,7 +2385,8 @@ qemuDomainAttachHostSCSIDevice(virConnectPtr conn, if (qemuDomainSecretHostdevPrepare(conn, priv, hostdev) < 0) goto cleanup; - srcPriv = QEMU_DOMAIN_STORAGE_SOURCE_PRIVATE(iscsisrc->src); + if (scsisrc->protocol == VIR_DOMAIN_HOSTDEV_SCSI_PROTOCOL_TYPE_ISCSI) + srcPriv = QEMU_DOMAIN_STORAGE_SOURCE_PRIVATE(scsisrc->u.iscsi.src); if (srcPriv) secinfo = srcPriv->secinfo; if (secinfo && secinfo->type == VIR_DOMAIN_SECRET_INFO_TYPE_AES) { -- 2.13.4

2 2

[libvirt] [PATCH] remove bogus casts of arg to g_object_ref
by Daniel P. Berrange 17 Jan '18

17 Jan '18

Latest version of glib uses typeof() magic to cast the return value of g_object_ref to match its argument, instead of returning a 'void *'. A few places in the code were casting the arg to G_OBJECT() which was then incompatible with the variable we assigned the result to. The parameter casts were always redundant so just remove them. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- libvirt-gconfig/libvirt-gconfig-object.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-object.c b/libvirt-gconfig/libvirt-gconfig-object.c index 851e35c..ca2c6e6 100644 --- a/libvirt-gconfig/libvirt-gconfig-object.c +++ b/libvirt-gconfig/libvirt-gconfig-object.c @@ -572,7 +572,7 @@ gvir_config_object_set_node_content(GVirConfigObject *object, node = gvir_config_object_replace_child(object, node_name); g_return_if_fail(node != NULL); } else { - node = g_object_ref(G_OBJECT(object)); + node = g_object_ref(object); } encoded_data = xmlEncodeEntitiesReentrant(node->priv->node->doc, (xmlChar *)value); @@ -896,7 +896,7 @@ gvir_config_object_attach(GVirConfigObject *parent, GVirConfigObject *child, gbo child->priv->doc = NULL; } if (parent->priv->doc != NULL) { - child->priv->doc = g_object_ref(G_OBJECT(parent->priv->doc)); + child->priv->doc = g_object_ref(parent->priv->doc); } } -- 2.14.3

1 1

[libvirt] New GIT repos for libvirt wiki & virt tools planet
by Daniel P. Berrange 17 Jan '18

17 Jan '18

Hi Folks, Just let you all know that I've moved various libvirt related websites over to hosting on Red Hat's OpenShift v3 infrastructure. With the new v3 that is based on Kubernetes, I'm able to publish the GIT repos containing the core content & software setup. For wiki.libvirt.org: https://libvirt.org/git/?p=libvirt-wiki.git;a=summary For planet.virt-tools.org: https://libvirt.org/git/?p=virttools-planet.git;a=summary For www.virt-tools.org: https://libvirt.org/git/?p=virttools-web.git;a=summary These are setup to mirror to github, and with a github webhook installed. So if when changes to the *content*, it will get automatically deployed to the live site by OpenShift. NB, auto-deploy doesn't apply to the actual OpenShift configuration, only the static config. I still need to manualy deploy OpenShift config changes for security reasons :-) The key benefit here is that adding people to the blog aggregator on planet.virt-tools.org is now easier. Just send a patch for this file: https://libvirt.org/git/?p=virttools-planet.git;a=blob;f=updater/virt-tools… Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|

1 0

[libvirt] [PATCH] rpm: updates wrt min required fedora version
by Daniel P. Berrange 17 Jan '18

17 Jan '18

Update the min fedora to 25. Use a macro to record the min versions so that the later error message is always in sync with the earlier version check. Clarify the comment that refers to guessing of dist which does not actually happen. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- libvirt.spec.in | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 7e1b6a27d3..713961573a 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1,10 +1,12 @@ # -*- rpm-spec -*- # This spec file assumes you are building on a Fedora or RHEL version -# that's still supported by the vendor: that means Fedora 23 or newer, -# or RHEL 6 or newer. It may need some tweaks for other distros. -# If neither fedora nor rhel was defined, try to guess them from dist -%if (0%{?fedora} && 0%{?fedora} >= 23) || (0%{?rhel} && 0%{?rhel} >= 6) +# that's still supported by the vendor. It may work on other distros +# or versions, but no effort will be made to ensure that going forward. +%define min_rhel 6 +%define min_fedora 25 + +%if (0%{?fedora} && 0%{?fedora} >= %{min_fedora}) || (0%{?rhel} && 0%{?rhel} >= %{min_rhel}) %define supported_platform 1 %else %define supported_platform 0 @@ -1132,7 +1134,7 @@ rm -rf .git %build %if ! %{supported_platform} -echo "This RPM requires either Fedora >= 20 or RHEL >= 6" +echo "This RPM requires either Fedora >= %{min_fedora} or RHEL >= %{min_rhel}" exit 1 %endif -- 2.14.3

3 2

[libvirt] [PATCH] spec: enable bash completion only on new enough distros
by Pavel Hrdina 17 Jan '18

17 Jan '18

RHEL-6 doesn't have bash-completion package by default, it has to be installed from EPEL. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- libvirt.spec.in | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index d4ef116b2d..ef96888d09 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -87,6 +87,7 @@ %define with_libssh2 0%{!?_without_libssh2:0} %define with_wireshark 0%{!?_without_wireshark:0} %define with_libssh 0%{!?_without_libssh:0} +%define with_bash_completion 0%{!?_without_bash_completion:0} %define with_pm_utils 1 # Finally set the OS / architecture specific special cases @@ -190,6 +191,11 @@ %define with_libssh 0%{!?_without_libssh:1} %endif +# Enable bash-completion for new enough distros +%if 0%{?fedora} || 0%{?rhel} >= 7 + %define with_bash_completion 0%{!?_without_bash_completion:1} +%endif + %if %{with_qemu} || %{with_lxc} || %{with_uml} # numad is used to manage the CPU and memory placement dynamically, @@ -306,7 +312,9 @@ BuildRequires: xen-devel BuildRequires: libxml2-devel BuildRequires: libxslt BuildRequires: readline-devel +%if %{with_bash_completion} BuildRequires: bash-completion >= 2.0 +%endif BuildRequires: ncurses-devel BuildRequires: gettext BuildRequires: libtasn1-devel @@ -2048,7 +2056,9 @@ exit 0 %{_datadir}/systemtap/tapset/libvirt_qemu_probes*.stp %{_datadir}/systemtap/tapset/libvirt_functions.stp +%if %{with_bash_completion} %{_datadir}/bash-completion/completions/vsh +%endif %if %{with_systemd} -- 2.14.3

2 1

[libvirt] [jenkins-ci PATCH] guests: install bash-completion when building libvirt
by Pavel Hrdina 17 Jan '18

17 Jan '18

Libvirt recently added bash-completion support. On CentOS6 the package is available only from EPEL repositories. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- guests/vars/mappings.yml | 4 ++++ guests/vars/projects/libvirt.yml | 1 + 2 files changed, 5 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index e669b6c..440123c 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -53,6 +53,10 @@ mappings: pkg: avahi rpm: avahi-devel + bash-completion: + default: bash-completion + CentOS6: + ccache: default: ccache CentOS: diff --git a/guests/vars/projects/libvirt.yml b/guests/vars/projects/libvirt.yml index 598dfc4..9f027f8 100644 --- a/guests/vars/projects/libvirt.yml +++ b/guests/vars/projects/libvirt.yml @@ -3,6 +3,7 @@ packages: - apparmor - augeas - avahi + - bash-completion - cyrus-sasl - device-mapper - dnsmasq -- 2.14.3

2 1

[libvirt] Entering freeze for libvirt-4.0.0
by Daniel Veillard 17 Jan '18

17 Jan '18

Hi all, as planned I just tagged the Release Candidate 1 in git for 4.0.0, I also pushed signed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ No issue found in my limited testing, weirdly the CI says master is red for 4 days but it build just fine here so there has to be something on jenkins: https://ci.centos.org/view/libvirt/ Please give it a try, I will likely push an RC2 end of Monday, and then we can have the final release around Wed if everything looks fine. Feedback on other architectures and OSes always welcome :-) thanks ! Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

2 2

[libvirt] [PATCH 0/3] Couple of build fixes for readline stuff
by Michal Privoznik 16 Jan '18

16 Jan '18

After I've merged bash completion patches, couple of build problems emerged. Michal Privoznik (3): vsh: Mark cmdComplete arguments as unused tools: Always compile {virsh,virt-admin}-completer.c m4: Check for rl_completion_quote_character m4/virt-readline.m4 | 13 +++++++++++++ tools/Makefile.am | 20 ++------------------ tools/vsh.c | 3 ++- 3 files changed, 17 insertions(+), 19 deletions(-) -- 2.13.6

4 14

[libvirt] [PATCH] check/add for mdev_types capability
by Dan Zheng 16 Jan '18

16 Jan '18

>From be62ea5394d52fa168079edc3aa7e558363a3026 Mon Sep 17 00:00:00 2001 From: Dan Zheng <dzheng(a)redhat.com> Date: Tue, 16 Jan 2018 12:21:21 +0800 Subject: [PATCH] nodedev: check/add for mdev_types capability This is similar to commit f44ec9c1. Commit id '500cbc06' introduced a new nested capability element of type 'mdev_types' and the ability to use the flag as a way to search for a specific subset of a 'pci' device - namely a 'mdev_types'. The code modified the virNodeDeviceCapMatch whichs allows for searching using the 'virsh nodedev-list [cap]' via virConnectListAllNodeDevices. However, the original patches did not account for other searches for the same capability key from virNodeDeviceNumOfCaps and virNodeDeviceListCaps using nodeDeviceNumOfCaps and nodeDeviceListCaps. This patch adds the check for the 'mdev_types' bits within a 'pci' device and allows the following python code to find the capabilities for the device: import libvirt conn = libvirt.openReadOnly('qemu:///system') devs = conn.listAllDevices() for dev in devs: if 'mdev_types' in dev.listCaps(): print dev.name(),dev.numOfCaps(),dev.listCaps() Signed-off-by: Dan Zheng <dzheng(a)redhat.com> --- src/node_device/node_device_driver.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_device_driver.c index facfeb6..6216a69 100644 --- a/src/node_device/node_device_driver.c +++ b/src/node_device/node_device_driver.c @@ -382,6 +382,12 @@ nodeDeviceNumOfCaps(virNodeDevicePtr device) VIR_NODE_DEV_CAP_FLAG_HBA_VPORT_OPS) ncaps++; } + if (caps->data.type == VIR_NODE_DEV_CAP_PCI_DEV) { + if (caps->data.pci_dev.flags & + VIR_NODE_DEV_CAP_FLAG_PCI_MDEV) + ncaps++; + } + } ret = ncaps; @@ -432,6 +438,15 @@ nodeDeviceListCaps(virNodeDevicePtr device, goto cleanup; } } + if (caps->data.type == VIR_NODE_DEV_CAP_PCI_DEV) { + if (ncaps < maxnames && + caps->data.pci_dev.flags & + VIR_NODE_DEV_CAP_FLAG_PCI_MDEV) { + if (VIR_STRDUP(names[ncaps++], + virNodeDevCapTypeToString(VIR_NODE_DEV_CAP_MDEV_TYPES)) < 0) + goto cleanup; + } + } } ret = ncaps; -- 1.8.3.1 -- Best Regards, Dan Zheng(郑丹) Red Hat Software (Beijing) Co. 9/F, North Tower C, Raycom Infotech Park No.2 Ke Xueyuan Nanlu, Haidian District Beijing 100190

2 1

[libvirt] [libvirt-tck] [PATCH] Add new option for virt-builder
by Dan Zheng 16 Jan '18

16 Jan '18

>From 0cbe381e782a18cfa9730e8791a80ff01497d8fc Mon Sep 17 00:00:00 2001 From: Dan Zheng <dzheng(a)redhat.com> Date: Tue, 16 Jan 2018 13:39:50 +0800 Subject: [PATCH] Add new option for virt-builder Using --selinux-relabel is required by Fedora and RHEL guests to ensure SELinux labels correctly in the disk image. Signed-off-by: Dan Zheng <dzheng(a)redhat.com> --- lib/Sys/Virt/TCK.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Sys/Virt/TCK.pm b/lib/Sys/Virt/TCK.pm index e9da8d2..1621342 100644 --- a/lib/Sys/Virt/TCK.pm +++ b/lib/Sys/Virt/TCK.pm @@ -405,7 +405,7 @@ sub create_virt_builder_disk { } print "# running virt-builder $osname\n"; - system "virt-builder", "--install", "dsniff", "--root-password", "password:$password", "--output", $target, $osname; + system "virt-builder", "--install", "dsniff", "--root-password", "password:$password", "--output", $target, $osname, "--selinux-relabel"; die "cannot run virt-builder: $?" if $? != 0; -- 1.8.3.1 -- Best Regards, Dan Zheng(郑丹) Red Hat Software (Beijing) Co. 9/F, North Tower C, Raycom Infotech Park No.2 Ke Xueyuan Nanlu, Haidian District Beijing 100190

1 0

[libvirt] [PATCH perl] block_stats: Fix rd_req and wr_req compat hash keys
by Ville Skyttä 15 Jan '18

15 Jan '18

When virDomainBlockStatsFlags with NULL params fails, the returned read and write requests hash keys are said to be backwards compatible with the key names success case. However, they were rd_reqs and wr_reqs (in plural) as opposed to the success case's rd_req and wr_req. There is also a similar flush_reqs key, but that one does not have a corresponding value in the success case's hash, so it is left unmodified here. --- Virt.xs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Virt.xs b/Virt.xs index c47b915..a6f0477 100644 --- a/Virt.xs +++ b/Virt.xs @@ -5611,9 +5611,9 @@ block_stats(dom, path, flags=0) field = NULL; /* For back compat with previous hash above */ if (strcmp(params[i].field, "rd_operations") == 0) - field = "rd_reqs"; + field = "rd_req"; else if (strcmp(params[i].field, "wr_operations") == 0) - field = "wr_reqs"; + field = "wr_req"; else if (strcmp(params[i].field, "flush_operations") == 0) field = "flush_reqs"; if (field) { -- 2.14.1

2 1

[libvirt] [PATCH perl] Spelling fixes
by Ville Skyttä 15 Jan '18

15 Jan '18

--- Changes | 4 ++-- HACKING | 4 ++-- lib/Sys/Virt.pm | 6 +++--- lib/Sys/Virt/Domain.pm | 14 +++++++------- lib/Sys/Virt/Interface.pm | 2 +- lib/Sys/Virt/NWFilter.pm | 2 +- lib/Sys/Virt/Network.pm | 4 ++-- lib/Sys/Virt/NodeDevice.pm | 4 ++-- lib/Sys/Virt/Secret.pm | 4 ++-- lib/Sys/Virt/StoragePool.pm | 4 ++-- lib/Sys/Virt/StorageVol.pm | 8 ++++---- lib/Sys/Virt/Stream.pm | 2 +- 12 files changed, 29 insertions(+), 29 deletions(-) diff --git a/Changes b/Changes index 96b42f8..0571cf8 100644 --- a/Changes +++ b/Changes @@ -472,7 +472,7 @@ Revision history for perl module Sys::Virt 0.2.6 2011-02-16 - Fix build with 0.8.7 libvirt by removing reference to - non-existant constant only introduced in libvirt > 0.8.7 + non-existent constant only introduced in libvirt > 0.8.7 - Fix test script when hostname is undefined 0.2.5 2011-02-04 @@ -533,7 +533,7 @@ Revision history for perl module Sys::Virt - Added networking APIs - Added APIs for host capabilities - Added APIs for inactive domains - - Switch licensse to GPLv2+ or Artistic for CPAN compatability + - Switch licensse to GPLv2+ or Artistic for CPAN compatibility - Fix return values for reboot/shutdown/undefine/create APIs - Expanded documentation coverage diff --git a/HACKING b/HACKING index bb8b0f0..bfd1212 100644 --- a/HACKING +++ b/HACKING @@ -15,7 +15,7 @@ Additions to the libvirt C API will require changes to a minimum of two parts of the Sys::Virt codebase. - Virt.xs - this provides the C glue code to access the libvirt C - library APIs and constants from the Perl interpretor. As a general + library APIs and constants from the Perl interpreter. As a general rule, every new function and header file constant/enum requires an addition to this file. The exceptions are functions that are only provided for the benefit of language bindings and not intended for @@ -93,7 +93,7 @@ effective way to update the Perl binding. - For each missing item reported in the test suite... - Edit Virt.xs to add the C binding - - Edit lib/*.pm to add the POD documentation (and occassionally Perl glue code) + - Edit lib/*.pm to add the POD documentation (and occasionally Perl glue code) - Edit Changes to document the addition - Run the test suite (without maintainer mode) to verify POD docs # ../libvirt/run make test diff --git a/lib/Sys/Virt.pm b/lib/Sys/Virt.pm index 2ce7ed5..faaf668 100644 --- a/lib/Sys/Virt.pm +++ b/lib/Sys/Virt.pm @@ -135,7 +135,7 @@ types that will be supported. The credential constants in this module can be used as values in this list. The C<callback> parameter should be a subroutine reference containing the code necessary to gather the credentials. When invoked it -will be supplied with a single parameter, a array reference +will be supplied with a single parameter, an array reference of requested credentials. The elements of the array are hash references, with keys C<type> giving the type of credential, C<prompt> giving a user descriptive user @@ -1164,7 +1164,7 @@ pool sources. =item my @stats = $vmm->get_all_domain_stats($stats, \@doms=undef, $flags=0); -Get an list of all statistics for domains known to the hypervisor. +Get a list of all statistics for domains known to the hypervisor. The C<$stats> parameter controls which data fields to return and should be a combination of the DOMAIN STATS FIELD CONSTANTS. @@ -1469,7 +1469,7 @@ how long the node is suspended for before waking up. =item $conn->domain_event_register($callback) -Register a callback to received notificaitons of domain state change +Register a callback to received notifications of domain state change events. Only a single callback can be registered with each connection instance. The callback will be invoked with four parameters, an instance of C<Sys::Virt> for the connection, an instance of C<Sys::Virt::Domain> diff --git a/lib/Sys/Virt/Domain.pm b/lib/Sys/Virt/Domain.pm index 38b9c9b..7b90b68 100644 --- a/lib/Sys/Virt/Domain.pm +++ b/lib/Sys/Virt/Domain.pm @@ -45,7 +45,7 @@ sub _new { my $class = ref($proto) || $proto; my %params = @_; - my $con = exists $params{connection} ? $params{connection} : die "connection parameter is requried"; + my $con = exists $params{connection} ? $params{connection} : die "connection parameter is required"; my $self; if (exists $params{name}) { $self = Sys::Virt::Domain::_lookup_by_name($con, $params{name}); @@ -490,7 +490,7 @@ One of the CONTROL INFO constants listed later =item C<details> -Currently unsed, always 0. +Currently unused, always 0. =item C<stateTime> @@ -658,7 +658,7 @@ later. =item $dom->detach_device($xml[, $flags]) -Hotunplug a existing device whose configuration is given by C<$xml>, +Hotunplug an existing device whose configuration is given by C<$xml>, from the running guest. The optional <$flags> parameter defaults to 0, but can accept one of the device hotplug flags described later. @@ -1719,7 +1719,7 @@ instead of MB/s. Abort the current job that is executing for the block device associated with C<$path> -=item $dom->block_pull($path, $bandwith, $flags=0) +=item $dom->block_pull($path, $bandwidth, $flags=0) Merge the backing files associated with C<$path> into the top level file. The C<$bandwidth> parameter specifies the @@ -1735,7 +1735,7 @@ instead of MB/s. =back -=item $dom->block_rebase($path, $base, $bandwith, $flags=0) +=item $dom->block_rebase($path, $base, $bandwidth, $flags=0) Switch the backing path associated with C<$path> to instead use C<$base>. The C<$bandwidth> parameter specifies the @@ -1774,7 +1774,7 @@ The maximum amount of data in flight in bytes. =back -=item $dom->block_commit($path, $base, $top, $bandwith, $flags=0) +=item $dom->block_commit($path, $base, $top, $bandwidth, $flags=0) Commit changes there were made to the temporary top level file C<$top>. Takes all the differences between C<$top> and C<$base> and merge them @@ -3827,7 +3827,7 @@ The host storage has run out of free space =item Sys::Virt::Domain::DISK_ERROR_UNSPEC -An unspecified error has ocurred. +An unspecified error has occurred. =back diff --git a/lib/Sys/Virt/Interface.pm b/lib/Sys/Virt/Interface.pm index 58fa2af..8f6112a 100644 --- a/lib/Sys/Virt/Interface.pm +++ b/lib/Sys/Virt/Interface.pm @@ -45,7 +45,7 @@ sub _new { my $class = ref($proto) || $proto; my %params = @_; - my $con = exists $params{connection} ? $params{connection} : die "connection parameter is requried"; + my $con = exists $params{connection} ? $params{connection} : die "connection parameter is required"; my $self; if (exists $params{name}) { $self = Sys::Virt::Interface::_lookup_by_name($con, $params{name}); diff --git a/lib/Sys/Virt/NWFilter.pm b/lib/Sys/Virt/NWFilter.pm index 927b038..8ede8a0 100644 --- a/lib/Sys/Virt/NWFilter.pm +++ b/lib/Sys/Virt/NWFilter.pm @@ -45,7 +45,7 @@ sub _new { my $class = ref($proto) || $proto; my %params = @_; - my $con = exists $params{connection} ? $params{connection} : die "connection parameter is requried"; + my $con = exists $params{connection} ? $params{connection} : die "connection parameter is required"; my $self; if (exists $params{name}) { $self = Sys::Virt::NWFilter::_lookup_by_name($con, $params{name}); diff --git a/lib/Sys/Virt/Network.pm b/lib/Sys/Virt/Network.pm index d90b58b..415e629 100644 --- a/lib/Sys/Virt/Network.pm +++ b/lib/Sys/Virt/Network.pm @@ -45,7 +45,7 @@ sub _new { my $class = ref($proto) || $proto; my %params = @_; - my $con = exists $params{connection} ? $params{connection} : die "connection parameter is requried"; + my $con = exists $params{connection} ? $params{connection} : die "connection parameter is required"; my $self; if (exists $params{name}) { $self = Sys::Virt::Network::_lookup_by_name($con, $params{name}); @@ -363,7 +363,7 @@ Network lifecycle events The following constants allow network lifecycle change events to be interpreted. The events contain both a state change, and a -reason though the reason is currently unsed. +reason though the reason is currently unused. =over 4 diff --git a/lib/Sys/Virt/NodeDevice.pm b/lib/Sys/Virt/NodeDevice.pm index 0539b9e..1ca3fa3 100644 --- a/lib/Sys/Virt/NodeDevice.pm +++ b/lib/Sys/Virt/NodeDevice.pm @@ -47,7 +47,7 @@ sub _new { my $class = ref($proto) || $proto; my %params = @_; - my $con = exists $params{connection} ? $params{connection} : die "connection parameter is requried"; + my $con = exists $params{connection} ? $params{connection} : die "connection parameter is required"; my $self; if (exists $params{name}) { $self = Sys::Virt::NodeDevice::_lookup_by_name($con, $params{name}); @@ -201,7 +201,7 @@ Node device config update events The following constants allow node device lifecycle change events to be interpreted. The events contain both a state change, and a -reason though the reason is currently unsed. +reason though the reason is currently unused. =over 4 diff --git a/lib/Sys/Virt/Secret.pm b/lib/Sys/Virt/Secret.pm index 0c6a021..a5ae9eb 100644 --- a/lib/Sys/Virt/Secret.pm +++ b/lib/Sys/Virt/Secret.pm @@ -45,7 +45,7 @@ sub _new { my $class = ref($proto) || $proto; my %params = @_; - my $con = exists $params{connection} ? $params{connection} : die "connection parameter is requried"; + my $con = exists $params{connection} ? $params{connection} : die "connection parameter is required"; my $self; if (exists $params{usageID} || exists $params{usageType}) { @@ -200,7 +200,7 @@ Secret value change events The following constants allow secret lifecycle change events to be interpreted. The events contain both a state change, and a -reason though the reason is currently unsed. +reason though the reason is currently unused. =over 4 diff --git a/lib/Sys/Virt/StoragePool.pm b/lib/Sys/Virt/StoragePool.pm index f4d5696..3c8abda 100644 --- a/lib/Sys/Virt/StoragePool.pm +++ b/lib/Sys/Virt/StoragePool.pm @@ -47,7 +47,7 @@ sub _new { my $class = ref($proto) || $proto; my %params = @_; - my $con = exists $params{connection} ? $params{connection} : die "connection parameter is requried"; + my $con = exists $params{connection} ? $params{connection} : die "connection parameter is required"; my $self; if (exists $params{name}) { $self = Sys::Virt::StoragePool::_lookup_by_name($con, $params{name}); @@ -496,7 +496,7 @@ Storage pool volume refresh events The following constants allow storage pool lifecycle change events to be interpreted. The events contain both a state change, and a -reason though the reason is currently unsed. +reason though the reason is currently unused. =over 4 diff --git a/lib/Sys/Virt/StorageVol.pm b/lib/Sys/Virt/StorageVol.pm index 82c3df2..917eb82 100644 --- a/lib/Sys/Virt/StorageVol.pm +++ b/lib/Sys/Virt/StorageVol.pm @@ -48,16 +48,16 @@ sub _new { my $self; if (exists $params{name}) { - my $pool = exists $params{pool} ? $params{pool} : die "pool parameter is requried"; + my $pool = exists $params{pool} ? $params{pool} : die "pool parameter is required"; $self = Sys::Virt::StorageVol::_lookup_by_name($pool, $params{name}); } elsif (exists $params{key}) { - my $con = exists $params{connection} ? $params{connection} : die "connection parameter is requried"; + my $con = exists $params{connection} ? $params{connection} : die "connection parameter is required"; $self = Sys::Virt::StorageVol::_lookup_by_key($con, $params{key}); } elsif (exists $params{path}) { - my $con = exists $params{connection} ? $params{connection} : die "connection parameter is requried"; + my $con = exists $params{connection} ? $params{connection} : die "connection parameter is required"; $self = Sys::Virt::StorageVol::_lookup_by_path($con, $params{path}); } elsif (exists $params{xml}) { - my $pool = exists $params{pool} ? $params{pool} : die "pool parameter is requried"; + my $pool = exists $params{pool} ? $params{pool} : die "pool parameter is required"; if ($params{clone}) { $self = Sys::Virt::StorageVol::_create_xml_from($pool, $params{xml}, $params{clone}, 0); } else { diff --git a/lib/Sys/Virt/Stream.pm b/lib/Sys/Virt/Stream.pm index a2fbc2b..9e4855e 100644 --- a/lib/Sys/Virt/Stream.pm +++ b/lib/Sys/Virt/Stream.pm @@ -44,7 +44,7 @@ sub _new { my $class = ref($proto) || $proto; my %params = @_; - my $con = exists $params{connection} ? $params{connection} : die "connection parameter is requried"; + my $con = exists $params{connection} ? $params{connection} : die "connection parameter is required"; my $self = Sys::Virt::Stream::_new_obj($con, $params{flags}); bless $self, $class; -- 2.14.1

2 1

[libvirt] [PATCH] libvirt-guests: make async stop work with transient guest domains
by Vincent Bernat 15 Jan '18

15 Jan '18

After being stopped, a transient guest domain doesn't appear in the list of guests anymore. Therefore, we can't get its state anymore. The branch handling this case displays an error message on stdout. This error message confuses the script which expects to get a list of "still up" guests. We just remove the message. Also, since we can't get a name, display the UUID of the stopped domain. --- tools/libvirt-guests.sh.in | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/libvirt-guests.sh.in b/tools/libvirt-guests.sh.in index 8a158cca434d..e272325f7d5d 100644 --- a/tools/libvirt-guests.sh.in +++ b/tools/libvirt-guests.sh.in @@ -337,8 +337,6 @@ check_guests_shutdown() guests_up= for guest in $guests; do if ! guest_is_on "$uri" "$guest" >/dev/null 2>&1; then - eval_gettext "Failed to determine state of guest: \$guest. Not tracking it anymore." - echo continue fi if "$guest_running"; then @@ -363,6 +361,7 @@ print_guests_shutdown() esac name=$(guest_name "$uri" "$guest") + [ -n "$name" ] || name="$guest" eval_gettext "Shutdown of guest \$name complete." echo done -- 2.15.1

1 0

[libvirt] [PATCH] vshReadlineOptionsGenerator: Don't add already specified options to the list
by Michal Privoznik 15 Jan '18

15 Jan '18

The current state of art is as follows: 1) vshReadlineOptionsGenerator() generate all possible --options for given command, and then 2) vshReadlineOptionsPrune() clears out already provided ones from the list. Not only this brings needless memory complexity it is also not trivial to get right. We can switch to easier approach: just don't add already specified --options in the first step. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tools/vsh.c | 80 +++++++++++++++---------------------------------------------- 1 file changed, 19 insertions(+), 61 deletions(-) diff --git a/tools/vsh.c b/tools/vsh.c index 4426c08d6..a99d47bfc 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -2663,7 +2663,9 @@ vshReadlineCommandGenerator(const char *text) } static char ** -vshReadlineOptionsGenerator(const char *text, const vshCmdDef *cmd) +vshReadlineOptionsGenerator(const char *text, + const vshCmdDef *cmd, + vshCmd *last) { size_t list_index = 0; size_t len = strlen(text); @@ -2678,6 +2680,8 @@ vshReadlineOptionsGenerator(const char *text, const vshCmdDef *cmd) return NULL; while ((name = cmd->opts[list_index].name)) { + bool exists = false; + vshCmdOpt *opt = last->opts; size_t name_len; list_index++; @@ -2692,6 +2696,18 @@ vshReadlineOptionsGenerator(const char *text, const vshCmdDef *cmd) return NULL; } + while (opt) { + if (STREQ(opt->def->name, name)) { + exists = true; + break; + } + + opt = opt->next; + } + + if (exists) + continue; + if (VIR_REALLOC_N(ret, ret_size + 2) < 0) { virStringListFree(ret); return NULL; @@ -2772,60 +2788,6 @@ vshCompleterFilter(char ***list, } -static int -vshReadlineOptionsPrune(char ***list, - vshCmd *last) -{ - char **newList = NULL; - size_t newList_len = 0; - size_t list_len; - size_t i; - - if (!list || !*list) - return -1; - - if (!last->opts) - return 0; - - list_len = virStringListLength((const char **) *list); - - if (VIR_ALLOC_N(newList, list_len + 1) < 0) - return -1; - - for (i = 0; i < list_len; i++) { - const char *list_opt = STRSKIP((*list)[i], "--"); - bool exist = false; - vshCmdOpt *opt = last->opts; - - /* Should never happen (TM) */ - if (!list_opt) - return -1; - - while (opt) { - if (STREQ(opt->def->name, list_opt)) { - exist = true; - break; - } - - opt = opt->next; - } - - if (exist) { - VIR_FREE((*list)[i]); - continue; - } - - VIR_STEAL_PTR(newList[newList_len], (*list)[i]); - newList_len++; - } - - ignore_value(VIR_REALLOC_N_QUIET(newList, newList_len + 1)); - VIR_FREE(*list); - *list = newList; - return 0; -} - - static char * vshReadlineParse(const char *text, int state) { @@ -2874,12 +2836,8 @@ vshReadlineParse(const char *text, int state) if (!cmd) { list = vshReadlineCommandGenerator(text); } else { - if (!opt || (opt->type != VSH_OT_DATA && opt->type != VSH_OT_STRING)) { - list = vshReadlineOptionsGenerator(text, cmd); - - if (vshReadlineOptionsPrune(&list, partial) < 0) - goto cleanup; - } + if (!opt || (opt->type != VSH_OT_DATA && opt->type != VSH_OT_STRING)) + list = vshReadlineOptionsGenerator(text, cmd, partial); if (opt && opt->completer) { char **completer_list = opt->completer(autoCompleteOpaque, -- 2.13.6

2 1

[libvirt] [jenkins-ci PATCH] guests: Enable readline compat on FreeBSD CURRENT
by Andrea Bolognani 15 Jan '18

15 Jan '18

FreeBSD 10 is the only version *not* to need the compat hack, so special-case it instead of the other way around. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/tasks/compat.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/guests/tasks/compat.yml b/guests/tasks/compat.yml index 001b5c6..d48834b 100644 --- a/guests/tasks/compat.yml +++ b/guests/tasks/compat.yml @@ -15,8 +15,8 @@ when: - os_name == 'FreeBSD' -# Same as above, except we only need to do it on FreeBSD 11 because -# FreeBSD 10 shipped (an old version of) readline in the base system +# Same as above, except we only need to do it on FreeBSD 11 and later +# because FreeBSD 10 shipped (an old version of) readline in the base system - name: Create compatibility symlinks file: src: '/usr/local/{{ item }}' @@ -28,4 +28,4 @@ - lib/libreadline.so when: - os_name == 'FreeBSD' - - os_version == '11' + - os_version != '10' -- 2.14.3

1 0

[libvirt] [PATCH v2] virsh: fix build without readline
by Roman Bogorodskiy 15 Jan '18

15 Jan '18

Completion in virsh is enabled when readline is available. In order to fix build when it's not available, do the following: * Unconditionally add virsh-completer.[ch] and virt-admin-completer.[ch] to the build, and provide stub functions for when readline is not available. This way virsh builds without complaining about missing symbols used for 'completer' in vshCmdOptDef; * In cmdComplete(), mark unused arguments when there's no readline with ATTRIBUTE_UNUSED. --- tools/Makefile.am | 20 ++------------------ tools/virsh-completer.c | 23 +++++++++++++++++++++++ tools/virt-admin-completer.c | 12 ++++++++++++ tools/vsh.c | 2 +- 4 files changed, 38 insertions(+), 19 deletions(-) diff --git a/tools/Makefile.am b/tools/Makefile.am index 48125f516..8cb66db7d 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -229,17 +229,9 @@ virsh_SOURCES = \ virsh-snapshot.c virsh-snapshot.h \ virsh-util.c virsh-util.h \ virsh-volume.c virsh-volume.h \ + virsh-completer.c virsh-completer.h \ $(NULL) -VIRSH_COMPLETER = \ - virsh-completer.c virsh-completer.h - -if WITH_READLINE -virsh_SOURCES += $(VIRSH_COMPLETER) -else ! WITH_READLINE -EXTRA_DIST += $(VIRSH_COMPLETER) -endif ! WITH_READLINE - virsh_LDFLAGS = \ $(AM_LDFLAGS) \ $(PIE_LDFLAGS) \ @@ -256,17 +248,9 @@ virsh_CFLAGS = \ virt_admin_SOURCES = \ virt-admin.c virt-admin.h \ + virt-admin-completer.c virt-admin-completer.h \ $(NULL) -VIRT_ADMIN_COMPLETER = \ - virt-admin-completer.c virt-admin-completer.h - -if WITH_READLINE -virt_admin_SOURCES += $(VIRT_ADMIN_COMPLETER) -else ! WITH_READLINE -EXTRA_DIST += $(VIRT_ADMIN_COMPLETER) -endif ! WITH_READLINE - virt_admin_LDFLAGS = \ $(AM_LDFLAGS) \ $(COVERAGE_LDFLAGS) \ diff --git a/tools/virsh-completer.c b/tools/virsh-completer.c index 48dd9fbc2..fd92ee8db 100644 --- a/tools/virsh-completer.c +++ b/tools/virsh-completer.c @@ -31,6 +31,7 @@ #include "virxml.h" +#ifdef WITH_READLINE char ** virshDomainNameCompleter(vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED, @@ -147,3 +148,25 @@ virshDomainInterfaceCompleter(vshControl *ctl, virStringListFree(ret); return NULL; } +#else +char ** +virshDomainNameCompleter(vshControl *ctl ATTRIBUTE_UNUSED, + const vshCmd *cmd ATTRIBUTE_UNUSED, + unsigned int flags) +{ + virCheckFlags(-1, NULL); + + return NULL; +} + + +char ** +virshDomainInterfaceCompleter(vshControl *ctl ATTRIBUTE_UNUSED, + const vshCmd *cmd ATTRIBUTE_UNUSED, + unsigned int flags) +{ + virCheckFlags(-1, NULL); + + return NULL; +} +#endif /* WITH_READLINE */ diff --git a/tools/virt-admin-completer.c b/tools/virt-admin-completer.c index 2cd471f32..a432f0977 100644 --- a/tools/virt-admin-completer.c +++ b/tools/virt-admin-completer.c @@ -30,6 +30,7 @@ #include "virstring.h" +#ifdef WITH_READLINE char ** vshAdmServerCompleter(vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED, @@ -74,3 +75,14 @@ vshAdmServerCompleter(vshControl *ctl, VIR_FREE(ret); return ret; } +#else +char ** +vshAdmServerCompleter(vshControl *ctl ATTRIBUTE_UNUSED, + const vshCmd *cmd ATTRIBUTE_UNUSED, + unsigned int flags) +{ + virCheckFlags(-1, NULL); + + return NULL; +} +#endif /* WITH_READLINE */ diff --git a/tools/vsh.c b/tools/vsh.c index 4426c08d6..59c8a440e 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -3500,7 +3500,7 @@ const vshCmdInfo info_complete[] = { }; bool -cmdComplete(vshControl *ctl, const vshCmd *cmd) +cmdComplete(vshControl *ctl ATTRIBUTE_UNUSED, const vshCmd *cmd ATTRIBUTE_UNUSED) { bool ret = false; #ifdef WITH_READLINE -- 2.15.1

2 2

[libvirt] [jenkins-ci PATCH] guests: Install libtirpc when building libvirt
by Andrea Bolognani 15 Jan '18

15 Jan '18

Recent glibc versions don't include an RPC library anymore, so we need to make sure an alternative implementation is available for libvirt to use. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/vars/mappings.yml | 4 ++++ guests/vars/projects/libvirt.yml | 1 + 2 files changed, 5 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 9c194d0..e669b6c 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -279,6 +279,10 @@ mappings: pkg: libssh2 rpm: libssh2-devel + libtirpc: + deb: libtirpc-dev + rpm: libtirpc-devel + libtool: default: libtool Debian: libtool-bin diff --git a/guests/vars/projects/libvirt.yml b/guests/vars/projects/libvirt.yml index ba1e4c3..598dfc4 100644 --- a/guests/vars/projects/libvirt.yml +++ b/guests/vars/projects/libvirt.yml @@ -32,6 +32,7 @@ packages: - libselinux - libssh - libssh2 + - libtirpc - libudev - libxml2 - lvm2 -- 2.14.3

2 1

[libvirt] [PATCH] vshReadlineOptionsPrune: Fix possible leak
by Michal Privoznik 15 Jan '18

15 Jan '18

The function should prune list of --options so that options already specified are not offered to user for completion again. However, if the list of offered options contains a string that doesn't start with double dash the function returns leaking partially constructed list. There's not much benefit from trying to roll back. Just free everything up - our only caller would do that anyway. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tools/vsh.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tools/vsh.c b/tools/vsh.c index 4426c08d6..7db0a16f1 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -2798,8 +2798,17 @@ vshReadlineOptionsPrune(char ***list, vshCmdOpt *opt = last->opts; /* Should never happen (TM) */ - if (!list_opt) + if (!list_opt) { + /* But in case it does, we're in a tough situation + * because @list[0..i-1] is possibly sparse. That + * means if caller were to call virStringListFree + * over it some memory is definitely going to be + * leaked. The best we can do is to free from list[i] + * as our only caller is just fine with it. */ + virStringListFree(list[i]); + virStringListFree(newList); return -1; + } while (opt) { if (STREQ(opt->def->name, list_opt)) { -- 2.13.6

2 2

[libvirt] [PATCH] virsh: fix build without readline
by Roman Bogorodskiy 13 Jan '18

13 Jan '18

Completion in virsh is enabled when readline is available. However, when it's not available, we should: * avoid defining completers with completion functions; * in cmdComplete(), mark unused arguments when there's no readline with ATTRIBUTE_UNUSED. --- tools/virsh-domain-monitor.c | 6 ++++++ tools/virsh-domain.c | 6 ++++++ tools/virsh.h | 11 ++++++++++- tools/virt-admin.c | 14 ++++++++++++++ tools/vsh.c | 2 +- 5 files changed, 37 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index 32a42707e..0df20eea0 100644 --- a/tools/virsh-domain-monitor.c +++ b/tools/virsh-domain-monitor.c @@ -659,7 +659,9 @@ static const vshCmdOptDef opts_domif_getlink[] = { {.name = "interface", .type = VSH_OT_DATA, .flags = VSH_OFLAG_REQ, +#if WITH_READLINE .completer = virshDomainInterfaceCompleter, +#endif .help = N_("interface device (MAC Address)") }, {.name = "persistent", @@ -996,7 +998,9 @@ static const vshCmdOptDef opts_domifstat[] = { {.name = "interface", .type = VSH_OT_DATA, .flags = VSH_OFLAG_REQ, +#ifdef WITH_READLINE .completer = virshDomainInterfaceCompleter, +#endif .help = N_("interface device specified by name or MAC Address") }, {.name = NULL} @@ -2151,7 +2155,9 @@ static const vshCmdOptDef opts_domifaddr[] = { {.name = "interface", .type = VSH_OT_STRING, .flags = VSH_OFLAG_NONE, +#ifdef WITH_READLINE .completer = virshDomainInterfaceCompleter, +#endif .help = N_("network interface name")}, {.name = "full", .type = VSH_OT_BOOL, diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 0f329d6d7..c5511adbf 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -2977,7 +2977,9 @@ static const vshCmdOptDef opts_domif_setlink[] = { {.name = "interface", .type = VSH_OT_DATA, .flags = VSH_OFLAG_REQ, +#ifdef WITH_READLINE .completer = virshDomainInterfaceCompleter, +#endif .help = N_("interface device (MAC Address)") }, {.name = "state", @@ -3148,7 +3150,9 @@ static const vshCmdOptDef opts_domiftune[] = { {.name = "interface", .type = VSH_OT_DATA, .flags = VSH_OFLAG_REQ, +#ifdef WITH_READLINE .completer = virshDomainInterfaceCompleter, +#endif .help = N_("interface device (MAC Address)") }, {.name = "inbound", @@ -11985,8 +11989,10 @@ static const vshCmdOptDef opts_detach_interface[] = { }, {.name = "mac", .type = VSH_OT_STRING, +#ifdef WITH_READLINE .completer = virshDomainInterfaceCompleter, .completer_flags = VIRSH_DOMAIN_INTERFACE_COMPLETER_MAC, +#endif .help = N_("MAC address") }, VIRSH_COMMON_OPT_DOMAIN_PERSISTENT, diff --git a/tools/virsh.h b/tools/virsh.h index 528e04558..b3cb15ac4 100644 --- a/tools/virsh.h +++ b/tools/virsh.h @@ -71,7 +71,8 @@ .help = _helpstr \ } -# define VIRSH_COMMON_OPT_DOMAIN(_helpstr, cflags) \ +# ifdef WITH_READLINE +# define VIRSH_COMMON_OPT_DOMAIN(_helpstr, cflags) \ {.name = "domain", \ .type = VSH_OT_DATA, \ .flags = VSH_OFLAG_REQ, \ @@ -79,6 +80,14 @@ .completer = virshDomainNameCompleter, \ .completer_flags = cflags, \ } +# else +# define VIRSH_COMMON_OPT_DOMAIN(_helpstr, cflags) \ + {.name = "domain", \ + .type = VSH_OT_DATA, \ + .flags = VSH_OFLAG_REQ, \ + .help = _helpstr, \ + } +# endif # define VIRSH_COMMON_OPT_CONFIG(_helpstr) \ {.name = "config", \ diff --git a/tools/virt-admin.c b/tools/virt-admin.c index c86b5763a..ac4d00dd7 100644 --- a/tools/virt-admin.c +++ b/tools/virt-admin.c @@ -429,7 +429,9 @@ static const vshCmdOptDef opts_srv_threadpool_info[] = { {.name = "server", .type = VSH_OT_DATA, .flags = VSH_OFLAG_REQ, +#ifdef WITH_READLINE .completer = vshAdmServerCompleter, +#endif .help = N_("Server to retrieve threadpool attributes from."), }, {.name = NULL} @@ -491,7 +493,9 @@ static const vshCmdOptDef opts_srv_threadpool_set[] = { {.name = "server", .type = VSH_OT_DATA, .flags = VSH_OFLAG_REQ, +#ifdef WITH_READLINE .completer = vshAdmServerCompleter, +#endif .help = N_("Server to alter threadpool attributes on."), }, {.name = "min-workers", @@ -598,7 +602,9 @@ static const vshCmdOptDef opts_srv_clients_list[] = { {.name = "server", .type = VSH_OT_DATA, .flags = VSH_OFLAG_REQ, +#ifdef WITH_READLINE .completer = vshAdmServerCompleter, +#endif .help = N_("server which to list connected clients from"), }, {.name = NULL} @@ -680,7 +686,9 @@ static const vshCmdOptDef opts_client_info[] = { {.name = "server", .type = VSH_OT_DATA, .flags = VSH_OFLAG_REQ, +#ifdef WITH_READLINE .completer = vshAdmServerCompleter, +#endif .help = N_("server to which <client> is connected to"), }, {.name = "client", @@ -768,7 +776,9 @@ static const vshCmdOptDef opts_client_disconnect[] = { {.name = "server", .type = VSH_OT_DATA, .flags = VSH_OFLAG_REQ, +#ifdef WITH_READLINE .completer = vshAdmServerCompleter, +#endif .help = N_("server which the client is currently connected to"), }, {.name = "client", @@ -834,7 +844,9 @@ static const vshCmdOptDef opts_srv_clients_info[] = { {.name = "server", .type = VSH_OT_DATA, .flags = VSH_OFLAG_REQ, +#ifdef WITH_READLINE .completer = vshAdmServerCompleter, +#endif .help = N_("Server to retrieve the client limits from."), }, {.name = NULL} @@ -894,7 +906,9 @@ static const vshCmdOptDef opts_srv_clients_set[] = { {.name = "server", .type = VSH_OT_DATA, .flags = VSH_OFLAG_REQ, +#ifdef WITH_READLINE .completer = vshAdmServerCompleter, +#endif .help = N_("Server to alter the client-related configuration limits on."), }, {.name = "max-clients", diff --git a/tools/vsh.c b/tools/vsh.c index 4426c08d6..59c8a440e 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -3500,7 +3500,7 @@ const vshCmdInfo info_complete[] = { }; bool -cmdComplete(vshControl *ctl, const vshCmd *cmd) +cmdComplete(vshControl *ctl ATTRIBUTE_UNUSED, const vshCmd *cmd ATTRIBUTE_UNUSED) { bool ret = false; #ifdef WITH_READLINE -- 2.15.1

2 2

[libvirt] [resend][PATCH] deamon: use default value if ca_file, cert_file or key_file not set
by Chen Hanxiao 13 Jan '18

13 Jan '18

From: Chen Hanxiao <chenhanxiao(a)gmail.com> As the description of daemon/libvirtd.conf, setting key_file, cert_file or key_file will override the default value. But if we set any one of them, we need to set all the rest of them. This patch set default value to them as daemon/libvirtd.conf described. Signed-off-by: Chen Hanxiao <chenhanxiao(a)gmail.com> --- daemon/libvirtd.c | 27 ++++++++++++++++++--------- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index 6d3b83355..93983f63b 100644 --- a/daemon/libvirtd.c +++ b/daemon/libvirtd.c @@ -493,19 +493,28 @@ daemonSetupNetworking(virNetServerPtr srv, config->cert_file || config->key_file) { if (!config->ca_file) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("No CA certificate path set to match server key/cert")); - goto cleanup; + VIR_WARN("Using default path for ca_file"); + if (VIR_STRDUP(config->ca_file, LIBVIRT_CACERT) < 0) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("No CA certificate path set to match server key/cert")); + goto cleanup; + } } if (!config->cert_file) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("No server certificate path set to match server key")); - goto cleanup; + VIR_WARN("Using default path for cert_file"); + if (VIR_STRDUP(config->cert_file, LIBVIRT_SERVERCERT) < 0) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("No server certificate path set to match server key")); + goto cleanup; + } } if (!config->key_file) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("No server key path set to match server cert")); - goto cleanup; + VIR_WARN("Using default path for key_file"); + if (VIR_STRDUP(config->key_file, LIBVIRT_SERVERKEY) < 0) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("No server key path set to match server cert")); + goto cleanup; + } } VIR_DEBUG("Using CA='%s' cert='%s' key='%s'", config->ca_file, config->cert_file, config->key_file); -- 2.14.3

3 3

[libvirt] [PATCH v2] domain_conf: skip boot order check of CD-ROM or floppy device when change-media
by Chen Hanxiao 12 Jan '18

12 Jan '18

From: Chen Hanxiao <chenhanxiao(a)gmail.com> If we insert or eject a CD-ROM/floppy device by: 'virsh change-media VM --eject/--insert some.iso --live', and the original CD-ROM device was configed with a boot order, we may get: unsupported configuration: boot order 2 is already used by another device We just updated 'source file' section rather than hotplug a new device. This check should be skipped in this case. Signed-off-by: Chen Hanxiao <chenhanxiao(a)gmail.com> --- v2: commit message updated remove ATTRIBUTE_UNUSED from @device src/conf/domain_conf.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index a1c25060f..e006cea0a 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -26881,17 +26881,26 @@ virDomainDeviceIsUSB(virDomainDeviceDefPtr dev) static int virDomainDeviceInfoCheckBootIndex(virDomainDefPtr def ATTRIBUTE_UNUSED, - virDomainDeviceDefPtr device ATTRIBUTE_UNUSED, + virDomainDeviceDefPtr device, virDomainDeviceInfoPtr info, void *opaque) { virDomainDeviceInfoPtr newinfo = opaque; + virDomainDiskDefPtr disk = device->data.disk; + int disk_device = disk->device; if (info->bootIndex == newinfo->bootIndex) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("boot order %u is already used by another device"), - newinfo->bootIndex); - return -1; + /* Skip check for insert or eject CD-ROM device */ + if (disk_device == VIR_DOMAIN_DISK_DEVICE_FLOPPY || + disk_device == VIR_DOMAIN_DISK_DEVICE_CDROM) { + VIR_DEBUG("Skip boot index check for floppy or CDROM"); + return 0; + } else { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("boot order %u is already used by another device"), + newinfo->bootIndex); + return -1; + } } return 0; } -- 2.14.3

2 2

[libvirt] [PATCH v2 0/2] qemu_hotplug: introduce VIR_ERR_DEVICE_MISSING for failing to find the desired device
by Chen Hanxiao 12 Jan '18

12 Jan '18

We used VIR_ERR_OPERATION_INVALID for failing to find the desired device. But this error code is widely used. This brings troubles to the project(i.e nova) powered by libvirt, they had to analyze error messages to find out what had happened. Chen Hanxiao (2): qemu_hotplug: more proper error messages when target detaching device is not found qemu_hotplug: introduce VIR_ERR_DEVICE_MISSING for failing to find desired device include/libvirt/virterror.h | 1 + src/libvirt_private.syms | 2 ++ src/qemu/qemu_hotplug.c | 54 +++++++++++++++++++++++++++++---------------- src/util/virerror.c | 6 +++++ 4 files changed, 44 insertions(+), 19 deletions(-) -- 2.14.3

2 4

[libvirt] [PATCH python v2 0/9] Various improvements to RPM spec
by Daniel P. Berrange 12 Jan '18

12 Jan '18

Daniel P. Berrange (9): Allow disabling of python2 RPM build Allow override of which sub-RPMs to build Add checks for min supported distros Add emacs mode marker to activate rpm-spec highlighting Adapt to rename of py2 RPMs from python- to python2- prefix Turn on python3 sub-RPMs for RHEL > 7 Require libvirt native version matching py version by default Fix filtering of RPM provides for .so files Use python*_sitearch macros instead of manually defining the dir libvirt-python.spec.in | 89 +++++++++++++++++++++++++++++++++++++++----------- setup.py | 3 +- 2 files changed, 71 insertions(+), 21 deletions(-) -- 2.14.3

2 10

[libvirt] [PATCH python 0/7] Misc improvements to RPM spec
by Daniel P. Berrange 12 Jan '18

12 Jan '18

Various improvements to the RPM spec to help future Fedora/RHEL maint Daniel P. Berrange (7): Allow disabling of python2 RPM build Allow override of which sub-RPMs to build Add checks for min supported distros Add emacs mode marker to activate rpm-spec highlighting Adapt to rename of py2 RPMs from python- to python2- prefix Turn on python3 sub-RPMs for RHEL > 7 Require libvirt native version matching py version by default libvirt-python.spec.in | 54 ++++++++++++++++++++++++++++++++++++++++++++++---- setup.py | 3 +-- 2 files changed, 51 insertions(+), 6 deletions(-) -- 2.14.3

4 23

[libvirt] [PATCH] fixed bug:if expand thread pool, will lose some one
by Di Wei 12 Jan '18

12 Jan '18

--- src/util/virthreadpool.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/virthreadpool.c b/src/util/virthreadpool.c index 10f2bd2..0983ee2 100644 --- a/src/util/virthreadpool.c +++ b/src/util/virthreadpool.c @@ -186,6 +186,7 @@ virThreadPoolExpand(virThreadPoolPtr pool, size_t gain, bool priority) size_t *curWorkers = priority ? &pool->nPrioWorkers : &pool->nWorkers; size_t i = 0; struct virThreadPoolWorkerData *data = NULL; + size_t oldNWorkers = *curWorkers; if (VIR_EXPAND_N(*workers, *curWorkers, gain) < 0) return -1; @@ -198,7 +199,7 @@ virThreadPoolExpand(virThreadPoolPtr pool, size_t gain, bool priority) data->cond = priority ? &pool->prioCond : &pool->cond; data->priority = priority; - if (virThreadCreateFull(&(*workers)[i], + if (virThreadCreateFull(&(*workers)[i + oldNWorkers], false, virThreadPoolWorker, pool->jobFuncName, -- 2.9.3

3 2

[libvirt] [PATCH 00/18] Make bash completion great again
by Michal Privoznik 12 Jan '18

12 Jan '18

Technically, this is a v2 of [1], but this implements the feature from different angle and therefore it's a start of new series. What's implemented? =================== Auto completion for both interactive and non-interactive virsh/virt-admin. Known limitations ================= Currently, just options completers work. I mean, to bring up list of domains you have to: virsh # start --domain <TAB><TAB> Doing bare: virsh # start <TAB><TAB> brings up list of --options. With the new approach implemented here it should be easy to implement this. But that can be saved for later. How to test this? ================= Interactive completion should work out of the box. Just make sure you're connected. Completers don't connect! You certainly don't want ssh's 'Password:' prompt show on <TAB><TAB>, do you? Non-interactive completers do connect, but in order to avoid any password prompts, /dev/stdin is closed before anything else is done. In order to test it, just: libvirt.git $ source tools/bash-completion/vsh Now, bash completion should work: libvirt.git $ ./tools/virsh -c qemu:///system start --domain <TAB><TAB> Notes ===== As usual, you can find all the patches on my github [2]. I've tried to work in all the review suggestions from v1. Due to changes in design (reusing parse code instead of duplicating it) not all suggestions were possible to work in though. Michal 1: https://www.redhat.com/archives/libvir-list/2017-November/msg00213.html 2: https://github.com/zippy2/libvirt/tree/bash_autocomplete_v3 (yeah v3, don't ask) Michal Privoznik (18): vsh: Drop useless check for opts != NULL vsh: Drop useless check for cmd != NULL vshCommandParse: Don't leak @tkdata vshCommandStringParse: Allow retrieving partial result vshReadlineParse: Drop code duplication vshReadlineParse: Escape returned results if needed vshReadlineParse: Use string list vshCommandOpt: Allow caller avoiding assert() util: Introduce virStringListMerge vsh: Fix vshCompleter signature vsh: Call vshCmdOptDef completer vsh: Prune string list returned by completer vsh: Filter --options vsh: Introduce complete command tools: Provide bash autompletion file virsh: Introduce virshDomainNameCompleter virsh: Introduce virshDomainInterfaceCompleter virt-admin: Introduce vshAdmServerCompleter configure.ac | 3 + libvirt.spec.in | 3 + m4/virt-bash-completion.m4 | 74 +++++ src/libvirt_private.syms | 1 + src/util/virstring.c | 36 +++ src/util/virstring.h | 3 + tools/Makefile.am | 40 ++- tools/bash-completion/vsh | 67 +++++ tools/virsh-completer.c | 150 ++++++++++ tools/virsh-completer.h | 41 +++ tools/virsh-domain-monitor.c | 33 ++- tools/virsh-domain.c | 186 ++++++------ tools/virsh-snapshot.c | 24 +- tools/virsh.c | 5 +- tools/virsh.h | 7 +- tools/virt-admin-completer.c | 76 +++++ tools/virt-admin-completer.h | 33 +++ tools/virt-admin.c | 13 +- tools/vsh.c | 663 ++++++++++++++++++++++++++----------------- tools/vsh.h | 23 +- 20 files changed, 1097 insertions(+), 384 deletions(-) create mode 100644 m4/virt-bash-completion.m4 create mode 100644 tools/bash-completion/vsh create mode 100644 tools/virsh-completer.c create mode 100644 tools/virsh-completer.h create mode 100644 tools/virt-admin-completer.c create mode 100644 tools/virt-admin-completer.h -- 2.13.6

3 33

[libvirt] [jenkins-ci PATCH v2 0/2] guests: Make rpcgen mapping more future-proof
by Andrea Bolognani 12 Jan '18

12 Jan '18

Changes from [v1]: * use the rpcgen name instead of glibc-rpcgen, which is a just temporary hack and will go away. [v1] https://www.redhat.com/archives/libvir-list/2018-January/msg00422.html Andrea Bolognani (2): guests: Fix package name for rpcgen guests: Make rpcgen mapping more future-proof guests/vars/mappings.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.14.3

2 3

[libvirt] [PATCH v2 0/2] processor frequency information on S390
by Bjoern Walk 12 Jan '18

12 Jan '18

Since kernel version 4.7, processor frequency information is available on S390. This patch series extends the parser for system information. Let's also add a testcase to the test suite for a S390 CPU configuration running kernel version 4.14 on LPAR. This is basically patch 3 of this series: https://www.redhat.com/archives/libvir-list/2017-December/msg00633.html v1 -> v2: - add debug logging - don't discard the whole hostsysinfo when the parsing fails - don't try to parse a value for external_clock, that information is not available on S390 - add test case for to sysinfotest.c Bjoern Walk (2): util: virsysinfo: parse frequency information on S390 tests: sysinfotest: add new test case for S390 src/util/virsysinfo.c | 41 ++++++- tests/sysinfodata/s390-freqcpuinfo.data | 52 +++++++++ tests/sysinfodata/s390-freqsysinfo.data | 173 ++++++++++++++++++++++++++++++ tests/sysinfodata/s390-freqsysinfo.expect | 63 +++++++++++ tests/sysinfotest.c | 1 + 5 files changed, 325 insertions(+), 5 deletions(-) create mode 100644 tests/sysinfodata/s390-freqcpuinfo.data create mode 100644 tests/sysinfodata/s390-freqsysinfo.data create mode 100644 tests/sysinfodata/s390-freqsysinfo.expect -- 2.13.4

3 9

[libvirt] [jenkins-ci PATCH] guests: Make rpcgen mapping more future-proof
by Andrea Bolognani 12 Jan '18

12 Jan '18

Since whatever is in Fedora Rawhide will end up in future Fedora releases, it makes sense to use the newer package as default and override it for existing releases (as well as CentOS), so that no tweaking will be needed when Fedora 28 and later are added to the CI setup. Suggested-by: Peter Krempa <pkrempa(a)redhat.com> Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/vars/mappings.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index b79757e..0b32f90 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -606,8 +606,10 @@ mappings: rpcgen: deb: libc-dev-bin - rpm: glibc-common - FedoraRawhide: glibc-rpcgen + rpm: glibc-rpcgen + CentOS: glibc-common + Fedora26: glibc-common + Fedora27: glibc-common FreeBSD: rpmbuild: -- 2.14.3

2 2

[libvirt] [PATCH 0/2] travis: Fix build failure
by Andrea Bolognani 12 Jan '18

12 Jan '18

It would be nice to have all greens before the release :) Andrea Bolognani (2): travis: Sync packages with libvirt-jenkins-ci travis: Skip nfs-common installation .travis.yml | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) -- 2.14.3

2 3

[libvirt] [PATCH V4] blockjob: Fix error checking of blockjob status
by Jie Wang 12 Jan '18

12 Jan '18

offset and len can also be equal to 0 on failed if blockjob return status:"BLOCK_JOB_COMPLETED" with error:"File descriptor in bad state", so we need to check 'error' in this case. --- src/qemu/qemu_monitor_json.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index e45868b..39c0909 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -886,7 +886,7 @@ qemuMonitorJSONHandleBlockJobImpl(qemuMonitorPtr mon, case VIR_DOMAIN_BLOCK_JOB_COMPLETED: error = virJSONValueObjectGetString(data, "error"); /* Make sure the whole device has been processed */ - if (offset != len) + if (offset != len || error) event = VIR_DOMAIN_BLOCK_JOB_FAILED; break; case VIR_DOMAIN_BLOCK_JOB_CANCELED: -- 1.8.3.1

2 2

[libvirt] [jenkins-ci PATCH] guests: Install rpcgen when building libvirt
by Andrea Bolognani 12 Jan '18

12 Jan '18

The dependency on rpcgen had not been made explicit up until now because the command was part of the base glibc development packages; however, Fedora Rawhide now ships it in a separate package, so we need to list it along with all other dependencies in order for it to get installed. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/vars/mappings.yml | 6 ++++++ guests/vars/projects/libvirt.yml | 1 + 2 files changed, 7 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index eca8dbe..b79757e 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -604,6 +604,12 @@ mappings: pkg: readline rpm: readline-devel + rpcgen: + deb: libc-dev-bin + rpm: glibc-common + FedoraRawhide: glibc-rpcgen + FreeBSD: + rpmbuild: rpm: rpm-build diff --git a/guests/vars/projects/libvirt.yml b/guests/vars/projects/libvirt.yml index 407881d..ba1e4c3 100644 --- a/guests/vars/projects/libvirt.yml +++ b/guests/vars/projects/libvirt.yml @@ -67,6 +67,7 @@ packages: - qemu-img - radvd - readline + - rpcgen - sanlock - scrub - sheepdog -- 2.14.3

2 1

[libvirt] [PATCH] libvirtd: clarify the TLS conf default vaule setting
by Chen Hanxiao 12 Jan '18

12 Jan '18

From: Chen Hanxiao <chenhanxiao(a)gmail.com> As the description of daemon/libvirtd.conf, setting key_file, cert_file or key_file will override the default value. But if we set any one of them, we need to set all the rest of them. This patch clarify that description. Signed-off-by: Chen Hanxiao <chenhanxiao(a)gmail.com> --- daemon/libvirtd.conf | 3 +++ 1 file changed, 3 insertions(+) diff --git a/daemon/libvirtd.conf b/daemon/libvirtd.conf index 8e0c0d96d..7040ff26b 100644 --- a/daemon/libvirtd.conf +++ b/daemon/libvirtd.conf @@ -183,6 +183,9 @@ # +# NB, if the default value of 'key_file', 'cert_file" or +# 'ca_file' would be changed, +# all of them should be changed together. # Override the default server key file path # #key_file = "/etc/pki/libvirt/private/serverkey.pem" -- 2.14.3

1 0

[libvirt] [PATCH] m4: Don't enable bash-completion by default
by Michal Privoznik 12 Jan '18

12 Jan '18

Due to the way that check logic was written we basically enabled bash completion whenever readline was enabled. This is not right because it made bash-completion pkg-config module required. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Even though this would qualify as a build breaker, I'd rather have another pair of eyes to look at it (sorry Cyclops). m4/virt-bash-completion.m4 | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/m4/virt-bash-completion.m4 b/m4/virt-bash-completion.m4 index e1ef58740..c8342176f 100644 --- a/m4/virt-bash-completion.m4 +++ b/m4/virt-bash-completion.m4 @@ -30,14 +30,10 @@ AC_DEFUN([LIBVIRT_CHECK_BASH_COMPLETION], [ AC_REQUIRE([LIBVIRT_CHECK_READLINE]) if test "x$with_readline" != "xyes" ; then - if test "x$with_bash_completion" != "xyes" ; then - with_bash_completion=no - else + if test "x$with_bash_completion" = "xyes" ; then AC_MSG_ERROR([readline is required for bash completion support]) - fi - else - if test "x$with_bash_completion" = "xcheck" ; then - with_bash_completion=yes + else + with_bash_completion=no fi fi -- 2.13.6

2 1

[libvirt] [PATCH] qemu: Fix type of a completed job
by Jiri Denemark 12 Jan '18

12 Jan '18

Libvirt 3.7.0 and earlier libvirt reported a migration job as completed immediately after QEMU finished sending migration data at which point migration was not really complete yet. Commit v3.7.0-29-g3f2d6d829e fixed this, but caused a regression in reporting statistics for completed jobs which started reporting the job as still running. This happened because the completed job statistics including the job status are copied from the running job before we finally mark it as completed. Let's make sure QEMU_DOMAIN_JOB_STATUS_COMPLETED is always set in the completed job info even when the job has not finished yet. https://bugzilla.redhat.com/show_bug.cgi?id=1523036 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_migration.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index c1ceb164d1..a56bc596ff 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -1646,8 +1646,10 @@ qemuMigrationWaitForCompletion(virQEMUDriverPtr driver, qemuDomainJobInfoUpdateTime(jobInfo); qemuDomainJobInfoUpdateDowntime(jobInfo); VIR_FREE(priv->job.completed); - if (VIR_ALLOC(priv->job.completed) == 0) + if (VIR_ALLOC(priv->job.completed) == 0) { *priv->job.completed = *jobInfo; + priv->job.completed->status = QEMU_DOMAIN_JOB_STATUS_COMPLETED; + } if (asyncJob != QEMU_ASYNC_JOB_MIGRATION_OUT && jobInfo->status == QEMU_DOMAIN_JOB_STATUS_QEMU_COMPLETED) @@ -5479,8 +5481,9 @@ qemuMigrationFinish(virQEMUDriverPtr driver, } if (dom) { - priv->job.completed = jobInfo; - jobInfo = NULL; + VIR_STEAL_PTR(priv->job.completed, jobInfo); + priv->job.completed->status = QEMU_DOMAIN_JOB_STATUS_COMPLETED; + if (qemuMigrationBakeCookie(mig, driver, vm, cookieout, cookieoutlen, QEMU_MIGRATION_COOKIE_STATS) < 0) VIR_WARN("Unable to encode migration cookie"); -- 2.15.1

2 1

[libvirt] [PATCH] qemu: Ignore fallback CPU attribute on reconnect
by Jiri Denemark 12 Jan '18

12 Jan '18

When reconnecting to a running domain with host-model CPU started by old libvirt which did not store the actual CPU in the status XML, we need to ignore the fallback attribute to make sure we can translate the detected host CPU model to a model which is supported by the running QEMU. https://bugzilla.redhat.com/show_bug.cgi?id=1532980 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_process.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 1a0923af36..25ec464d3e 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -3887,6 +3887,11 @@ qemuProcessUpdateCPU(virQEMUDriverPtr driver, virDomainCapsCPUModelsPtr models = NULL; int ret = -1; + /* The host CPU model comes from host caps rather than QEMU caps so + * fallback must be allowed no matter what the user specified in the XML. + */ + vm->def->cpu->fallback = VIR_CPU_FALLBACK_ALLOW; + if (qemuProcessFetchGuestCPU(driver, vm, asyncJob, &cpu, &disabled) < 0) goto cleanup; -- 2.15.1

2 1

[libvirt] [RFC PATCH] lxc: Up back the veth interfaces by default
by Benjamin Cama 12 Jan '18

12 Jan '18

Upping an interface without configuring it is not a “cardinal sin” but a sensible way to achieve auto-configuration, e.g. with IPv6 SLAAC (RFC 4862). If NetworkManager has troube with interfaces having only a link-local address, this is a bug in NetworkManager, not in libvirt; it should listen for router advertisements to decide if some interface has global connectivity or not. With network interfaces up by default, stateless containers can be easily auto-configured through the network with SLAAC, without any specific configuration from the host system. This reverts commit c3cf3c43a0bb2e0e4909c32821e20f607635ec85. Signed-off-by: Benjamin Cama <b.cama(a)kerlink.fr> --- Hi, The patch that I propose to revert basically broke my workflow for light stateless containers, where they could be auto-configured on IPv6-only network through SLAAC. Of course, fully-fledged containers can bring up the interface themselves, but this behavior had previously been the default for quite some time, and is even indicated as default in src/conf/domain_conf.h ("Default link state (up)"). I cannot find any real justification for the patch I am reverting, and the bugzilla looks private so I can not comment on the NetworkManager behavior, which looks very buggy to me. Please tell me if you think this is wrong. Also, please Cc me, I am not subscribed. Regards. .mailmap | 1 + src/lxc/lxc_container.c | 7 +------ src/lxc/lxc_native.c | 10 ++++++---- 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a/.mailmap b/.mailmap index 2f0fc901e..9dc3bff85 100644 --- a/.mailmap +++ b/.mailmap @@ -36,6 +36,7 @@ <gerd(a)egidy.de> <lists(a)egidy.de> <gerd(a)egidy.de> <gerd.von.egidy(a)intra2net.com> <benoar(a)dolka.fr> <benjamin.cama(a)telecom-bretagne.eu> +<benoar(a)dolka.fr> <b.cama(a)kerlink.fr> <zhlcindy(a)linux.vnet.ibm.com> <zhlcindy(a)gmail.com> <serge.hallyn(a)canonical.com> <serue(a)us.ibm.com> <pritesh.kothari(a)sun.com> <Pritesh.Kothari(a)Sun.COM> diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 96fceaf1b..e546f0aaf 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -517,12 +517,7 @@ lxcContainerRenameAndEnableInterfaces(virDomainDefPtr vmDef, if (virNetDevSetName(veths[i], newname) < 0) goto cleanup; - /* Only enable this device if there is a reason to do so (either - * at least one IP was specified, or link state was set to up in - * the config) - */ - if (netDef->guestIP.nips || - netDef->linkstate == VIR_DOMAIN_NET_INTERFACE_LINK_STATE_UP) { + if (netDef->linkstate != VIR_DOMAIN_NET_INTERFACE_LINK_STATE_DOWN) { VIR_DEBUG("Enabling %s", newname); if (virNetDevSetOnline(newname, true) < 0) goto cleanup; diff --git a/src/lxc/lxc_native.c b/src/lxc/lxc_native.c index fdc03a57e..f77a2a910 100644 --- a/src/lxc/lxc_native.c +++ b/src/lxc/lxc_native.c @@ -349,10 +349,12 @@ lxcCreateNetDef(const char *type, if (VIR_ALLOC(net) < 0) goto error; - if (STREQ_NULLABLE(flag, "up")) - net->linkstate = VIR_DOMAIN_NET_INTERFACE_LINK_STATE_UP; - else - net->linkstate = VIR_DOMAIN_NET_INTERFACE_LINK_STATE_DOWN; + if (flag) { + if (STREQ(flag, "up")) + net->linkstate = VIR_DOMAIN_NET_INTERFACE_LINK_STATE_UP; + else + net->linkstate = VIR_DOMAIN_NET_INTERFACE_LINK_STATE_DOWN; + } if (VIR_STRDUP(net->ifname_guest, name) < 0) goto error; -- 2.11.0

1 1

[libvirt] [BUG] virsh list didn,t clean vm when qemu destroy failed
by wang.guang55＠zte.com.cn 11 Jan '18

11 Jan '18

U3RlcHMgdG8gcmVwcm9kdWNlIA0KDQoNCjEgdmlyc2ggY3JlYXRlICB0ZXN0dm0gICANCg0KDQoy IGdkYiBhdHRjaCBxZW11LGFuZCBub3QgY29udGludWUNCg0KDQozICB2aXJzaCBkZXN0cm95ICB0 ZXN0dm0gICDvvIx0aGVuIGRlc3RvcnkgZmFpbGVk44CCDQoNCg0KNCBnZGIgcWVtdSBjb250aW51 ZSBhbmQgZXhpdCx0aGVuIHFlbXUgZXhpdC4NCg0KDQoNCg0KDQoNCltyb290QGhvc3QtMTIwLTUx IGhvbWVdIyBwcyAtYXV4IHxncmVwIHFlbXUNCg0KDQpyb290ICAgICAgMjgxNCAgMC4wICAwLjAg MTEyNjQ0ICAgOTU2IHB0cy8zICAgIFMrICAgMTE6NDAgICAwOjAwIGdyZXAgLS1jb2xvcj1hdXRv IHFlbXUNCg0KW3Jvb3RAaG9zdC0xMjAtNTEgaG9tZV0jIHZpcnNoIGxpc3QNCg0KIElkICAgIE5h bWUgICAgICAgICAgICAgICAgICAgICAgICAgICBTdGF0ZQ0KDQotLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tDQoNCiAzICAgIHRlc3R2bSAgICAgICAg ICAgICAgICAgICAgICAgcnVubmluZw0KDQoNCg0KDQoNCg0KDQoNCg0KDQpjYW4gd2UgdHJpZ2dl ciBxZW11UHJvY2Vzc0hhbmRsZU1vbml0b3JFT0YgYWdhaW4gdG8gcmVtb3ZlIHZtPz8=

1 0

[libvirt] [PATCH v2] treat host models as case-insensitive strings
by Scott Garfinkle 11 Jan '18

11 Jan '18

Qemu now allows case-insensitive specification of CPU models. This fixes the resulting problems on (at least) POWER arch machines. Patch V2: Change only the internal interface. This solves the actual problem at hand of reporting unsupported models now that qemu allows case-insensitive strings (e.g. "Power8" instead of "POWER8"). Signed-off-by: Scott Garfinkle <scottgar(a)linux.vnet.ibm.com> --- src/conf/domain_capabilities.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_capabilities.c b/src/conf/domain_capabilities.c index e7323a8..f7d9be5 100644 --- a/src/conf/domain_capabilities.c +++ b/src/conf/domain_capabilities.c @@ -271,7 +271,7 @@ virDomainCapsCPUModelsGet(virDomainCapsCPUModelsPtr cpuModels, return NULL; for (i = 0; i < cpuModels->nmodels; i++) { - if (STREQ(cpuModels->models[i].name, name)) + if (STRCASEEQ(cpuModels->models[i].name, name)) return cpuModels->models + i; } -- 1.8.3.1

2 2

[libvirt] [PATCH] vsh: add a necessary assertion
by Marc Hartmayer 11 Jan '18

11 Jan '18

This fixes the compilation error (compiled with the compiler option '-03'). In file included from ../../tools/vsh.c:28:0: ../../tools/vsh.c: In function 'vshCommandOptStringQuiet': ../../tools/vsh.c:838:30: error: potential null pointer dereference [-Werror=null-dereference] assert(!needData || valid->type != VSH_OT_BOOL); Signed-off-by: Marc Hartmayer <mhartmay(a)linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com> --- tools/vsh.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/vsh.c b/tools/vsh.c index e878119b988f..677eb9db3e41 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -816,8 +816,8 @@ vshCommandFree(vshCmd *cmd) * to the option if found, 0 with *OPT set to NULL if the name is * valid and the option is not required, -1 with *OPT set to NULL if * the option is required but not present, and assert if NAME is not - * valid (which indicates a programming error). No error messages are - * issued if a value is returned. + * valid or the option was not found (which indicates a programming + * error). No error messages are issued if a value is returned. */ static int vshCommandOpt(const vshCmd *cmd, const char *name, vshCmdOpt **opt, @@ -835,6 +835,8 @@ vshCommandOpt(const vshCmd *cmd, const char *name, vshCmdOpt **opt, break; valid++; } + assert(valid); + assert(!needData || valid->type != VSH_OT_BOOL); if (valid->flags & VSH_OFLAG_REQ) ret = -1; -- 2.13.4

2 5

[libvirt] [PATCH] docs: Add missing encryption type
by John Ferlan 11 Jan '18

11 Jan '18

Update the text to include "luks" as a possible value. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Pushed as trivial. docs/formatstorageencryption.html.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/formatstorageencryption.html.in b/docs/formatstorageencryption.html.in index c4b209527..23efbf932 100644 --- a/docs/formatstorageencryption.html.in +++ b/docs/formatstorageencryption.html.in @@ -17,7 +17,8 @@ The top-level tag of volume encryption specification is <code>encryption</code>, with a mandatory attribute <code>format</code>. Currently defined values - of <code>format</code> are <code>default</code> and <code>qcow</code>. + of <code>format</code> are <code>default</code>, <code>qcow</code>, + and <code>luks</code>. Each value of <code>format</code> implies some expectations about the content of the <code>encryption</code> tag. Other format values may be defined in the future. -- 2.13.6

1 0

[libvirt] [PATCH] tests: Break symlink loop
by Andrea Bolognani 11 Jan '18

11 Jan '18

distcheck, and possibly more stuff, breaks because of it. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu0/node0 | 1 - tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu1/node0 | 1 - tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu2/node0 | 1 - tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu3/node0 | 1 - tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu4/node0 | 1 - tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu5/node0 | 1 - tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu6/node0 | 1 - tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu7/node0 | 1 - 8 files changed, 8 deletions(-) delete mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu0/node0 delete mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu1/node0 delete mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu2/node0 delete mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu3/node0 delete mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu4/node0 delete mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu5/node0 delete mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu6/node0 delete mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu7/node0 diff --git a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu0/node0 b/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu0/node0 deleted file mode 120000 index 222b6af32..000000000 --- a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu0/node0 +++ /dev/null @@ -1 +0,0 @@ -../../node/node0 \ No newline at end of file diff --git a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu1/node0 b/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu1/node0 deleted file mode 120000 index 222b6af32..000000000 --- a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu1/node0 +++ /dev/null @@ -1 +0,0 @@ -../../node/node0 \ No newline at end of file diff --git a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu2/node0 b/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu2/node0 deleted file mode 120000 index 222b6af32..000000000 --- a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu2/node0 +++ /dev/null @@ -1 +0,0 @@ -../../node/node0 \ No newline at end of file diff --git a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu3/node0 b/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu3/node0 deleted file mode 120000 index 222b6af32..000000000 --- a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu3/node0 +++ /dev/null @@ -1 +0,0 @@ -../../node/node0 \ No newline at end of file diff --git a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu4/node0 b/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu4/node0 deleted file mode 120000 index 222b6af32..000000000 --- a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu4/node0 +++ /dev/null @@ -1 +0,0 @@ -../../node/node0 \ No newline at end of file diff --git a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu5/node0 b/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu5/node0 deleted file mode 120000 index 222b6af32..000000000 --- a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu5/node0 +++ /dev/null @@ -1 +0,0 @@ -../../node/node0 \ No newline at end of file diff --git a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu6/node0 b/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu6/node0 deleted file mode 120000 index 222b6af32..000000000 --- a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu6/node0 +++ /dev/null @@ -1 +0,0 @@ -../../node/node0 \ No newline at end of file diff --git a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu7/node0 b/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu7/node0 deleted file mode 120000 index 222b6af32..000000000 --- a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu7/node0 +++ /dev/null @@ -1 +0,0 @@ -../../node/node0 \ No newline at end of file -- 2.14.3

2 1

[libvirt] [PATCH 0/5] Proof of concept for libvirt_qemu shim process
by Daniel P. Berrange 11 Jan '18

11 Jan '18

This patch series provides a proof of concept impl of the libvirt_qemu shim process I previously suggested here: https://www.redhat.com/archives/libvir-list/2017-November/msg00526.html The end goal is that we'll be able to fully isolate managemen to each QEMU process. ie all the virDomain* APIs would be executed inside the libvirt_qemu shim process. The QEMU driver in libvirtd would merely deal with aggregating the views / tracking central resource allocations. This series, however, does *not* do that. It is a very much smaller proof of concept, principally to: - Learn about pros/cons of different approaches for the long term goal - Provide a working PoC that can be used by the KubeVirt project such that they can spawn QEMU in a separate docker container than libvirtd is in, and inherit namespaces & cgroup placement, etc So, in this series, libvirtd functionality remains essentially unchanged. All I have done is provide a new binary 'libvirt_qemu' that accepts an XML file as input, launches the QEMU process directly, and then calls a new virDomainQemuReconnect() API to make libvirtd aware of its existance. At this point libvirtd can deal with it normally (some caveats listed in last patch). Usage is pretty simple - start libvirtd normally, then to launch a guest just use $ libvirt_qemu /path/to/xml/file It'll be associated with whatever libvirtd instance is running with the same user account. ie if you launch libvirt_qemu as root, it'll associate with qemu:///system. By default it will still place VMs in a dedicated cgroup. To inherit the cgroup of the caller, use <resource register="none"/> in the XML schema to turn off cgroup setup in libvirt_qemu. Having written this PoC, however, I'm less convinced that a bottom up, minimal impl which incrementally picks certain subsets of QEMU driver APIs to call is the right way to attack this problem. ie I was intending to have this minimal shim, then gradually move functionality into it from libvirtd. This feels like it is going to create alot of busy-work, delaying the end goal. I think instead a different approach might be better in the short term. Take the existing libvirtd code as a starting point, clone it to a libvirt_qemu and just start cutting out existing code to make a lighter weight binary that can only run a single guest, whose XML is passed in. We would still ultimately need to deal with much of the same issues, like getting VMs reported to the central libvirtd, but I think that might get to the end result, where all APIs run inside the shim, quicker. The key difference is that we could sooner focus on the harder problems of dealing with shared resource allocation tracking, instead of doing lots of code rewiring for API execution. Daniel P. Berrange (5): conf: allow different resource registration modes conf: expose APIs to let drivers load individual config / status files qemu: add a public API to trigger QEMU driver to connect to running guest qemu: implement the new virDomainQemuReconnect method qemu: implement the 'libvirt_qemu' shim for launching guests externally include/libvirt/libvirt-qemu.h | 4 + po/POTFILES.in | 1 + src/Makefile.am | 49 ++++ src/conf/domain_conf.c | 42 +++- src/conf/domain_conf.h | 12 + src/conf/virdomainobjlist.c | 98 +++++--- src/conf/virdomainobjlist.h | 17 ++ src/driver-hypervisor.h | 5 + src/libvirt-qemu.c | 48 ++++ src/libvirt_private.syms | 4 + src/libvirt_qemu.syms | 5 + src/lxc/lxc_cgroup.c | 34 +++ src/lxc/lxc_cgroup.h | 3 + src/lxc/lxc_process.c | 11 +- src/qemu/qemu_cgroup.c | 69 +++++- src/qemu/qemu_conf.h | 2 +- src/qemu/qemu_controller.c | 551 +++++++++++++++++++++++++++++++++++++++++ src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_driver.c | 59 ++++- src/qemu/qemu_process.c | 31 ++- src/qemu/qemu_process.h | 1 + src/remote/qemu_protocol.x | 18 +- src/remote/remote_driver.c | 1 + src/util/vircgroup.c | 55 ++-- src/util/vircgroup.h | 10 +- 25 files changed, 1046 insertions(+), 86 deletions(-) create mode 100644 src/qemu/qemu_controller.c -- 2.14.3

3 15

[libvirt] Plan for next release
by Daniel Veillard 11 Jan '18

11 Jan '18

So first release for the year comes with a renumbering, so 4.0.0 should come soon, usually we target mid january, so I suggest to enter freeze tomorrow get an RC2 on Monday and hence have the first release Wed next week. I hope this works for everyone, thanks Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] [PATCH 0/3] processor frequency information on S390
by Bjoern Walk 11 Jan '18

11 Jan '18

Since kernel version 4.7, processor frequency information is available on S390. This patch series extends the parser for both node information and system information, respectively. Let's also add a testcase to the test suite for a S390 CPU configuration running kernel version 4.14 on LPAR. This goes on top of Andrea's changes in here: https://www.redhat.com/archives/libvir-list/2017-December/msg00519.html Bjoern Walk (3): util: virhostcpu: parse frequency information on S390 tests: virhostcputest: testcase for S390 system util: virsysinfo: parse frequency information on S390 src/util/virhostcpu.c | 2 + src/util/virsysinfo.c | 31 +++++++++++++ .../linux-s390x-with-frequency.cpuinfo | 52 ++++++++++++++++++++++ .../linux-s390x-with-frequency.expected | 1 + .../linux-with-frequency/cpu/cpu0/online | 1 + .../linux-with-frequency/cpu/cpu0/topology/book_id | 1 + .../cpu/cpu0/topology/book_siblings | 1 + .../cpu/cpu0/topology/book_siblings_list | 1 + .../linux-with-frequency/cpu/cpu0/topology/core_id | 1 + .../cpu/cpu0/topology/core_siblings | 1 + .../cpu/cpu0/topology/core_siblings_list | 1 + .../cpu/cpu0/topology/drawer_id | 1 + .../cpu/cpu0/topology/drawer_siblings | 1 + .../cpu/cpu0/topology/drawer_siblings_list | 1 + .../cpu/cpu0/topology/physical_package_id | 1 + .../cpu/cpu0/topology/thread_siblings | 1 + .../cpu/cpu0/topology/thread_siblings_list | 1 + .../linux-with-frequency/cpu/cpu1/online | 1 + .../linux-with-frequency/cpu/cpu1/topology/book_id | 1 + .../cpu/cpu1/topology/book_siblings | 1 + .../cpu/cpu1/topology/book_siblings_list | 1 + .../linux-with-frequency/cpu/cpu1/topology/core_id | 1 + .../cpu/cpu1/topology/core_siblings | 1 + .../cpu/cpu1/topology/core_siblings_list | 1 + .../cpu/cpu1/topology/drawer_id | 1 + .../cpu/cpu1/topology/drawer_siblings | 1 + .../cpu/cpu1/topology/drawer_siblings_list | 1 + .../cpu/cpu1/topology/physical_package_id | 1 + .../cpu/cpu1/topology/thread_siblings | 1 + .../cpu/cpu1/topology/thread_siblings_list | 1 + .../linux-with-frequency/cpu/cpu2/online | 1 + .../linux-with-frequency/cpu/cpu2/topology/book_id | 1 + .../cpu/cpu2/topology/book_siblings | 1 + .../cpu/cpu2/topology/book_siblings_list | 1 + .../linux-with-frequency/cpu/cpu2/topology/core_id | 1 + .../cpu/cpu2/topology/core_siblings | 1 + .../cpu/cpu2/topology/core_siblings_list | 1 + .../cpu/cpu2/topology/drawer_id | 1 + .../cpu/cpu2/topology/drawer_siblings | 1 + .../cpu/cpu2/topology/drawer_siblings_list | 1 + .../cpu/cpu2/topology/physical_package_id | 1 + .../cpu/cpu2/topology/thread_siblings | 1 + .../cpu/cpu2/topology/thread_siblings_list | 1 + .../linux-with-frequency/cpu/cpu3/online | 1 + .../linux-with-frequency/cpu/cpu3/topology/book_id | 1 + .../cpu/cpu3/topology/book_siblings | 1 + .../cpu/cpu3/topology/book_siblings_list | 1 + .../linux-with-frequency/cpu/cpu3/topology/core_id | 1 + .../cpu/cpu3/topology/core_siblings | 1 + .../cpu/cpu3/topology/core_siblings_list | 1 + .../cpu/cpu3/topology/drawer_id | 1 + .../cpu/cpu3/topology/drawer_siblings | 1 + .../cpu/cpu3/topology/drawer_siblings_list | 1 + .../cpu/cpu3/topology/physical_package_id | 1 + .../cpu/cpu3/topology/thread_siblings | 1 + .../cpu/cpu3/topology/thread_siblings_list | 1 + .../linux-with-frequency/cpu/cpu4/online | 1 + .../linux-with-frequency/cpu/cpu4/topology/book_id | 1 + .../cpu/cpu4/topology/book_siblings | 1 + .../cpu/cpu4/topology/book_siblings_list | 1 + .../linux-with-frequency/cpu/cpu4/topology/core_id | 1 + .../cpu/cpu4/topology/core_siblings | 1 + .../cpu/cpu4/topology/core_siblings_list | 1 + .../cpu/cpu4/topology/drawer_id | 1 + .../cpu/cpu4/topology/drawer_siblings | 1 + .../cpu/cpu4/topology/drawer_siblings_list | 1 + .../cpu/cpu4/topology/physical_package_id | 1 + .../cpu/cpu4/topology/thread_siblings | 1 + .../cpu/cpu4/topology/thread_siblings_list | 1 + .../linux-with-frequency/cpu/cpu5/online | 1 + .../linux-with-frequency/cpu/cpu5/topology/book_id | 1 + .../cpu/cpu5/topology/book_siblings | 1 + .../cpu/cpu5/topology/book_siblings_list | 1 + .../linux-with-frequency/cpu/cpu5/topology/core_id | 1 + .../cpu/cpu5/topology/core_siblings | 1 + .../cpu/cpu5/topology/core_siblings_list | 1 + .../cpu/cpu5/topology/drawer_id | 1 + .../cpu/cpu5/topology/drawer_siblings | 1 + .../cpu/cpu5/topology/drawer_siblings_list | 1 + .../cpu/cpu5/topology/physical_package_id | 1 + .../cpu/cpu5/topology/thread_siblings | 1 + .../cpu/cpu5/topology/thread_siblings_list | 1 + .../linux-with-frequency/cpu/cpu6/online | 1 + .../linux-with-frequency/cpu/cpu6/topology/book_id | 1 + .../cpu/cpu6/topology/book_siblings | 1 + .../cpu/cpu6/topology/book_siblings_list | 1 + .../linux-with-frequency/cpu/cpu6/topology/core_id | 1 + .../cpu/cpu6/topology/core_siblings | 1 + .../cpu/cpu6/topology/core_siblings_list | 1 + .../cpu/cpu6/topology/drawer_id | 1 + .../cpu/cpu6/topology/drawer_siblings | 1 + .../cpu/cpu6/topology/drawer_siblings_list | 1 + .../cpu/cpu6/topology/physical_package_id | 1 + .../cpu/cpu6/topology/thread_siblings | 1 + .../cpu/cpu6/topology/thread_siblings_list | 1 + .../linux-with-frequency/cpu/cpu7/online | 1 + .../linux-with-frequency/cpu/cpu7/topology/book_id | 1 + .../cpu/cpu7/topology/book_siblings | 1 + .../cpu/cpu7/topology/book_siblings_list | 1 + .../linux-with-frequency/cpu/cpu7/topology/core_id | 1 + .../cpu/cpu7/topology/core_siblings | 1 + .../cpu/cpu7/topology/core_siblings_list | 1 + .../cpu/cpu7/topology/drawer_id | 1 + .../cpu/cpu7/topology/drawer_siblings | 1 + .../cpu/cpu7/topology/drawer_siblings_list | 1 + .../cpu/cpu7/topology/physical_package_id | 1 + .../cpu/cpu7/topology/thread_siblings | 1 + .../cpu/cpu7/topology/thread_siblings_list | 1 + .../virhostcpudata/linux-with-frequency/cpu/online | 1 + .../linux-with-frequency/cpu/present | 1 + tests/virhostcputest.c | 1 + 111 files changed, 193 insertions(+) create mode 100644 tests/virhostcpudata/linux-s390x-with-frequency.cpuinfo create mode 100644 tests/virhostcpudata/linux-s390x-with-frequency.expected create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu0/online create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu0/topology/book_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu0/topology/book_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu0/topology/book_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu0/topology/core_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu0/topology/core_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu0/topology/core_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu0/topology/drawer_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu0/topology/drawer_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu0/topology/drawer_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu0/topology/physical_package_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu0/topology/thread_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu0/topology/thread_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu1/online create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu1/topology/book_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu1/topology/book_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu1/topology/book_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu1/topology/core_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu1/topology/core_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu1/topology/core_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu1/topology/drawer_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu1/topology/drawer_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu1/topology/drawer_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu1/topology/physical_package_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu1/topology/thread_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu1/topology/thread_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu2/online create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu2/topology/book_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu2/topology/book_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu2/topology/book_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu2/topology/core_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu2/topology/core_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu2/topology/core_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu2/topology/drawer_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu2/topology/drawer_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu2/topology/drawer_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu2/topology/physical_package_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu2/topology/thread_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu2/topology/thread_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu3/online create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu3/topology/book_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu3/topology/book_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu3/topology/book_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu3/topology/core_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu3/topology/core_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu3/topology/core_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu3/topology/drawer_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu3/topology/drawer_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu3/topology/drawer_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu3/topology/physical_package_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu3/topology/thread_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu3/topology/thread_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu4/online create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu4/topology/book_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu4/topology/book_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu4/topology/book_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu4/topology/core_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu4/topology/core_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu4/topology/core_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu4/topology/drawer_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu4/topology/drawer_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu4/topology/drawer_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu4/topology/physical_package_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu4/topology/thread_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu4/topology/thread_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu5/online create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu5/topology/book_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu5/topology/book_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu5/topology/book_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu5/topology/core_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu5/topology/core_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu5/topology/core_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu5/topology/drawer_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu5/topology/drawer_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu5/topology/drawer_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu5/topology/physical_package_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu5/topology/thread_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu5/topology/thread_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu6/online create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu6/topology/book_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu6/topology/book_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu6/topology/book_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu6/topology/core_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu6/topology/core_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu6/topology/core_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu6/topology/drawer_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu6/topology/drawer_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu6/topology/drawer_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu6/topology/physical_package_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu6/topology/thread_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu6/topology/thread_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu7/online create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu7/topology/book_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu7/topology/book_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu7/topology/book_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu7/topology/core_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu7/topology/core_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu7/topology/core_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu7/topology/drawer_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu7/topology/drawer_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu7/topology/drawer_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu7/topology/physical_package_id create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu7/topology/thread_siblings create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu7/topology/thread_siblings_list create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/online create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/present -- 2.13.4

2 16

[libvirt] [PATCH] tests: Remove trailing whitespace
by John Ferlan 10 Jan '18

10 Jan '18

Commit/push resulted in following error: remote: tests/virhostcpudata/linux-s390x-with-frequency.cpuinfo:5: trailing whitespace. remote: +features : esan3 zarch stfle msa ldisp eimm dfp edat etf3eh highgprs te vx sie remote: error: hook declined to update refs/heads/master Just removed the trailing whitespace. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Missed this during 'git am' processing and the syntax-check didn't find it either, but the push hook did. Just update the file to remove the trailing whitespace (built and tested just fine). tests/virhostcpudata/linux-s390x-with-frequency.cpuinfo | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/virhostcpudata/linux-s390x-with-frequency.cpuinfo b/tests/virhostcpudata/linux-s390x-with-frequency.cpuinfo index 0edc371dd..b50aa18c3 100644 --- a/tests/virhostcpudata/linux-s390x-with-frequency.cpuinfo +++ b/tests/virhostcpudata/linux-s390x-with-frequency.cpuinfo @@ -2,7 +2,7 @@ vendor_id : IBM/S390 # processors : 8 bogomips per cpu: 20325.00 max thread id : 1 -features : esan3 zarch stfle msa ldisp eimm dfp edat etf3eh highgprs te vx sie +features : esan3 zarch stfle msa ldisp eimm dfp edat etf3eh highgprs te vx sie facilities : 0 1 2 3 4 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 30 31 32 33 34 35 36 37 40 41 42 43 44 45 46 47 48 49 50 51 52 53 55 57 64 65 66 67 68 69 70 71 72 73 75 76 77 78 80 128 129 131 132 142 143 cache0 : level=1 type=Data scope=Private size=128K line_size=256 associativity=8 cache1 : level=1 type=Instruction scope=Private size=96K line_size=256 associativity=6 -- 2.13.6

1 1

[libvirt] [PATCH] docs: formatdomain: Specify the default value of 'check' attribute
by Kashyap Chamarthy 10 Jan '18

10 Jan '18

The 'check' attribute is referring to this: <cpu mode='custom' match='exact' check='full'> Upstream documentation says, it is: used to request a specific way of checking whether the virtual CPU matches the specification. It is usually safe to omit this attribute when starting a domain and stick with the default value. But doesn't tell *what* the default value is. It is check='partial'. Mention it so. Thanks: Jiri Denemark --- docs/formatdomain.html.in | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index d272cc1ba..8985da836 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -1287,10 +1287,11 @@ attribute can be used to request a specific way of checking whether the virtual CPU matches the specification. It is usually safe to omit this attribute when starting a domain and stick with the default - value. Once the domain starts, libvirt will automatically change the - <code>check</code> attribute to the best supported value to ensure the - virtual CPU does not change when the domain is migrated to another - host. The following values can be used: + value (<code>partial>/code>). Once the domain starts, libvirt will + automatically change the <code>check</code> attribute to the best + supported value to ensure the virtual CPU does not change when the + domain is migrated to another host. The following values can be + used: <dl> <dt><code>none</code></dt> @@ -1303,7 +1304,7 @@ <dt><code>partial</code></dt> <dd>Libvirt will check the guest CPU specification before starting a domain, but the rest is left on the hypervisor. It can still - provide a different virtual CPU.</dd> + provide a different virtual CPU. (This is the default.)</dd> <dt><code>full</code></dt> <dd>The virtual CPU created by the hypervisor will be checked -- 2.13.6

3 9

[libvirt] [PATCH 0/4] Alter Disk Volume logic to use objects
by John Ferlan 10 Jan '18

10 Jan '18

This series converts the storage volume forward linked list into an object that contains hash tables of volume objects. The first two patches resolve issues seen during testing with the Disk backend which had some special cased code to handle the Create/Delete paths and interactions with the partition logic. The first patch was much more quickly seen with object free logic in place. The second two patches make the conversion to objects and hash tables in "smaller chunks", but they could easily be combined. John Ferlan (4): storage: When delete volume avoid disk backend removal storage: Modify virStorageBackendDiskMakeDataVol logic storage: Introduce _virStorageVolObj[List] storage: Complete implementation volume by hash object src/conf/virstorageobj.c | 540 ++++++++++++++++++++++++++++++------- src/storage/storage_backend_disk.c | 40 +-- src/storage/storage_driver.c | 14 +- 3 files changed, 471 insertions(+), 123 deletions(-) -- 2.13.6

2 8

[libvirt] [PATCH 0/5] Refresh QEMU caps when CPU microcode changes
by Jiri Denemark 10 Jan '18

10 Jan '18

Jiri Denemark (1): cpu_x86: Rename virCPUx86MapInitialize Paolo Bonzini (4): util: add virFileReadHeaderQuiet wrapper around virFileReadHeaderFD util: introduce virHostCPUGetMicrocodeVersion conf: include x86 microcode version in virsh capabilities qemu: capabilities: force update if the microcode version does not match src/conf/cpu_conf.c | 14 +++++++ src/conf/cpu_conf.h | 1 + src/cpu/cpu_x86.c | 17 +++++++-- src/libvirt_private.syms | 2 + src/qemu/qemu_capabilities.c | 40 +++++++++++++++++++- src/qemu/qemu_capabilities.h | 6 ++- src/qemu/qemu_capspriv.h | 5 +++ src/qemu/qemu_driver.c | 9 ++++- src/util/virfile.c | 19 ++++++++++ src/util/virfile.h | 2 + src/util/virhostcpu.c | 43 ++++++++++++++++++++++ src/util/virhostcpu.h | 2 + tests/qemucapabilitiesdata/caps_1.2.2.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_1.3.1.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_1.4.2.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 1 + .../caps_2.10.0-gicv2.aarch64.xml | 1 + .../caps_2.10.0-gicv3.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 1 + .../caps_2.6.0-gicv2.aarch64.xml | 1 + .../caps_2.6.0-gicv3.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 + tests/qemucapabilitiestest.c | 14 +++++-- tests/qemucapsprobe.c | 2 +- tests/testutilsqemu.c | 2 +- 40 files changed, 189 insertions(+), 14 deletions(-) -- 2.15.1

5 15

[libvirt] [PATCH 0/3] cpu_x86: Few small fixes
by Jiri Denemark 10 Jan '18

10 Jan '18

I found these issues when working on patches and tests for CVE-2017-5715 part of Spectre. Jiri Denemark (3): cputest: Fix cpu-cpuid.py diff command cpu_x86: Add debug messages to x86DecodeUseCandidate cpu_x86: Copy CPU signature from ancestor src/cpu/cpu_x86.c | 26 ++++++++--- tests/cputestdata/cpu-cpuid.py | 52 +++++++++++++++------- .../x86_64-cpuid-A10-5800K-disabled.xml | 1 - .../cputestdata/x86_64-cpuid-A10-5800K-enabled.xml | 2 - .../x86_64-cpuid-Core-i5-2500-enabled.xml | 1 - .../x86_64-cpuid-Core-i5-2540M-enabled.xml | 1 - .../x86_64-cpuid-Core-i5-4670T-enabled.xml | 1 - .../x86_64-cpuid-Core-i5-6600-enabled.xml | 1 - .../x86_64-cpuid-Core-i7-2600-enabled.xml | 1 - ...x86_64-cpuid-Core-i7-2600-xsaveopt-disabled.xml | 1 - .../x86_64-cpuid-Core-i7-2600-xsaveopt-enabled.xml | 1 - .../x86_64-cpuid-Core-i7-3740QM-enabled.xml | 1 - .../x86_64-cpuid-Core-i7-3770-enabled.xml | 1 - .../x86_64-cpuid-Core-i7-4510U-enabled.xml | 1 - .../x86_64-cpuid-Core-i7-4600U-enabled.xml | 1 - .../x86_64-cpuid-Core-i7-5600U-arat-disabled.xml | 1 + .../x86_64-cpuid-Core-i7-5600U-arat-enabled.xml | 1 - .../x86_64-cpuid-Core-i7-5600U-enabled.xml | 1 - .../x86_64-cpuid-Core-i7-7700-enabled.xml | 1 - .../x86_64-cpuid-Core2-E6850-enabled.xml | 1 - .../x86_64-cpuid-EPYC-7601-32-Core-disabled.xml | 1 - .../x86_64-cpuid-EPYC-7601-32-Core-enabled.xml | 2 - .../x86_64-cpuid-Opteron-2350-disabled.xml | 1 - .../x86_64-cpuid-Opteron-2350-enabled.xml | 2 - .../x86_64-cpuid-Opteron-6234-disabled.xml | 1 - .../x86_64-cpuid-Opteron-6234-enabled.xml | 2 - .../x86_64-cpuid-Phenom-B95-disabled.xml | 1 - .../x86_64-cpuid-Phenom-B95-enabled.xml | 2 - ..._64-cpuid-Ryzen-7-1800X-Eight-Core-disabled.xml | 1 - ...6_64-cpuid-Ryzen-7-1800X-Eight-Core-enabled.xml | 2 - .../x86_64-cpuid-Xeon-E3-1245-v5-enabled.xml | 1 - .../x86_64-cpuid-Xeon-E5-2630-v3-enabled.xml | 1 - .../x86_64-cpuid-Xeon-E5-2650-v3-enabled.xml | 1 - .../x86_64-cpuid-Xeon-E5-2650-v4-disabled.xml | 1 + .../x86_64-cpuid-Xeon-E5-2650-v4-enabled.xml | 1 - .../x86_64-cpuid-Xeon-E7-4820-enabled.xml | 1 - .../x86_64-cpuid-Xeon-E7-4830-enabled.xml | 1 - .../x86_64-cpuid-Xeon-E7-8890-v3-enabled.xml | 1 - .../x86_64-cpuid-Xeon-Gold-6148-disabled.xml | 1 + .../x86_64-cpuid-Xeon-Gold-6148-enabled.xml | 1 - .../x86_64-cpuid-Xeon-W3520-enabled.xml | 1 - 41 files changed, 60 insertions(+), 63 deletions(-) -- 2.15.1

2 4

[libvirt] [PATCH v2] nodedev: update mdev_types caps before dumpxml
by Wu Zongyong 09 Jan '18

09 Jan '18

In current implemention, mdev_types caps keep constant all the time. But, it is possible that a device capable of mdev_types sometime(for example:bind to proper driver) and incapable of mdev_types at other times(for example: unbind from its driver). We should keep the info of xml dumped out consistent with real status of the device. Signed-off-by: Wu Zongyong <cordius.wu(a)huawei.com> --- v2: - fix mistakes pointed out by Erik src/node_device/node_device_linux_sysfs.c | 21 +++++++++++++++++++++ src/node_device/node_device_udev.c | 29 +++++++++++++++++++++++++++++ src/node_device/node_device_udev.h | 18 +++++++++++++----- 3 files changed, 63 insertions(+), 5 deletions(-) diff --git a/src/node_device/node_device_linux_sysfs.c b/src/node_device/node_device_linux_sysfs.c index 6f438e5..8b00aff 100644 --- a/src/node_device/node_device_linux_sysfs.c +++ b/src/node_device/node_device_linux_sysfs.c @@ -29,6 +29,7 @@ #include "dirname.h" #include "node_device_driver.h" #include "node_device_hal.h" +#include "node_device_udev.h" #include "node_device_linux_sysfs.h" #include "virerror.h" #include "viralloc.h" @@ -175,6 +176,24 @@ nodeDeviceSysfsGetPCIIOMMUGroupCaps(virNodeDevCapPCIDevPtr pci_dev) return ret; } +static int +nodeDeviceSysfsGetPCIMdevTypesCaps(const char *sysfsPath, + virNodeDevCapPCIDevPtr pci_dev) +{ + size_t i; + + /* this could be a refresh, so clear out the old data */ + for (i = 0; i < pci_dev->nmdev_types; i++) + virNodeDevCapMdevTypeFree(pci_dev->mdev_types[i]); + VIR_FREE(pci_dev->mdev_types); + pci_dev->nmdev_types = 0; + + if (udevPCISysfsGetMdevTypesCap(sysfsPath, pci_dev) < 0) + return -1; + + return 0; +} + /* nodeDeviceSysfsGetPCIRelatedCaps() get info that is stored in sysfs * about devices related to this device, i.e. things that can change @@ -190,6 +209,8 @@ nodeDeviceSysfsGetPCIRelatedDevCaps(const char *sysfsPath, return -1; if (nodeDeviceSysfsGetPCIIOMMUGroupCaps(pci_dev) < 0) return -1; + if (nodeDeviceSysfsGetPCIMdevTypesCaps(sysfsPath, pci_dev) < 0) + return -1; return 0; } diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c index e0fca61..781facf 100644 --- a/src/node_device/node_device_udev.c +++ b/src/node_device/node_device_udev.c @@ -506,6 +506,35 @@ udevPCIGetMdevTypesCap(struct udev_device *device, } +int +udevPCISysfsGetMdevTypesCap(const char *sysfsPath, + virNodeDevCapPCIDevPtr pci_dev) +{ + int ret = -1; + udevEventDataPtr priv = NULL; + struct udev *udev = NULL; + struct udev_device *device = NULL; + + priv = driver->privateData; + udev = udev_monitor_get_udev(priv->udev_monitor); + device = udev_device_new_from_syspath(udev, sysfsPath); + if (!device) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("failed to create udev device from path %s"), + sysfsPath); + goto cleanup; + } + + if (udevPCIGetMdevTypesCap(device, pci_dev) < 0) + goto cleanup; + + ret = 0; + cleanup: + udev_device_unref(device); + return ret; +} + + static int udevProcessPCI(struct udev_device *device, virNodeDeviceDefPtr def) diff --git a/src/node_device/node_device_udev.h b/src/node_device/node_device_udev.h index f15e520..bbdc70f 100644 --- a/src/node_device/node_device_udev.h +++ b/src/node_device/node_device_udev.h @@ -19,10 +19,18 @@ * * Author: Dave Allan <dallan(a)redhat.com> */ +#ifndef __VIR_NODE_DEVICE_UDEV_H__ +# define __VIR_NODE_DEVICE_UDEV_H__ -#include <libudev.h> -#include <stdint.h> +# include <libudev.h> +# include <stdint.h> -#define SYSFS_DATA_SIZE 4096 -#define DMI_DEVPATH "/sys/devices/virtual/dmi/id" -#define DMI_DEVPATH_FALLBACK "/sys/class/dmi/id" +# define SYSFS_DATA_SIZE 4096 +# define DMI_DEVPATH "/sys/devices/virtual/dmi/id" +# define DMI_DEVPATH_FALLBACK "/sys/class/dmi/id" + +int +udevPCISysfsGetMdevTypesCap(const char *sysfsPath, virNodeDevCapPCIDevPtr pci_dev); + + +#endif /* __VIR_NODE_DEVICE_UDEV_H__ */ -- 1.8.3.1

2 1

[libvirt] [PATCH 0/4] apparmor: implement more domain callbacks
by Christian Ehrhardt 09 Jan '18

09 Jan '18

Based on a discussion in [1] I found that the AppArmor security module lacked some callbacks. Implementing those not only fixes the issue I had before but will also cover a few more cases I didn't even run into so far. [1]: https://www.redhat.com/archives/libvir-list/2017-December/msg00726.html Christian Ehrhardt (4): security, apparmor: implement domainSetPathLabel security: full path option for DomainSetPathLabel security, apparmor: add (Set|Restore)ChardevLabel apparmor, virt-aa-helper: drop static channel rule src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_process.c | 4 +- src/security/security_apparmor.c | 96 ++++++++++++++++++++++++++++++++++++++++ src/security/security_dac.c | 3 +- src/security/security_driver.h | 3 +- src/security/security_manager.c | 5 ++- src/security/security_manager.h | 3 +- src/security/security_selinux.c | 3 +- src/security/security_stack.c | 5 ++- src/security/virt-aa-helper.c | 2 - 10 files changed, 113 insertions(+), 13 deletions(-) -- 2.7.4

2 18

[libvirt] [cim][PATCH 0/2] memory leak fixes in CIM provider
by Adam Majer 09 Jan '18

09 Jan '18

In some instances, asprintf allocated memory is not freed resulting in a slow memory leak. Adam Majer (2): Fix memory leak in set_other_id_info Fix memory leak in set_input_props src/Virt_ComputerSystem.c | 2 ++ src/Virt_SettingsDefineCapabilities.c | 6 ++++-- 2 files changed, 6 insertions(+), 2 deletions(-) -- 2.13.6

1 2

[libvirt] [cim][PATCH 1/2] Fix memory leak in set_other_id_info
by Adam Majer 09 Jan '18

09 Jan '18

model was allocated by asprintf but never freed after usage and assignement. Signed-off-by: Adam Majer <amajer(a)suse.de> --- src/Virt_ComputerSystem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/Virt_ComputerSystem.c b/src/Virt_ComputerSystem.c index da07f93..b4930ac 100644 --- a/src/Virt_ComputerSystem.c +++ b/src/Virt_ComputerSystem.c @@ -417,6 +417,8 @@ static int set_other_id_info(const CMPIBroker *broker, CMPI_string); } + free(model); + CMSetProperty(instance, "OtherIdentifyingInfo", &id_info, CMPI_stringA); -- 2.13.6

2 4

[libvirt] [PATCH] tests: Only format the CPU frequency if it's known
by Andrea Bolognani 09 Jan '18

09 Jan '18

Instead of formatting 'MHz: 0', which can be confusing, skip the field altogether. This behavior is consistent with that of 'virsh nodeinfo'. Suggested-by: John Ferlan <jferlan(a)redhat.com> Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- .../linux-aarch64-f21-mustang.expected | 2 +- .../linux-aarch64-rhel74-moonshot.expected | 2 +- .../linux-aarch64-rhelsa-3.19.0-mustang.expected | 2 +- .../linux-armv6l-raspberrypi.expected | 2 +- tests/virhostcputest.c | 28 +++++++++++++++++----- 5 files changed, 26 insertions(+), 10 deletions(-) diff --git a/tests/virhostcpudata/linux-aarch64-f21-mustang.expected b/tests/virhostcpudata/linux-aarch64-f21-mustang.expected index ac950dc15..1ee3cf737 100644 --- a/tests/virhostcpudata/linux-aarch64-f21-mustang.expected +++ b/tests/virhostcpudata/linux-aarch64-f21-mustang.expected @@ -1 +1 @@ -CPUs: 8/8, MHz: 0, Nodes: 1, Sockets: 4, Cores: 2, Threads: 1 +CPUs: 8/8, Nodes: 1, Sockets: 4, Cores: 2, Threads: 1 diff --git a/tests/virhostcpudata/linux-aarch64-rhel74-moonshot.expected b/tests/virhostcpudata/linux-aarch64-rhel74-moonshot.expected index 6776aa6c2..1926af836 100644 --- a/tests/virhostcpudata/linux-aarch64-rhel74-moonshot.expected +++ b/tests/virhostcpudata/linux-aarch64-rhel74-moonshot.expected @@ -1 +1 @@ -CPUs: 8/8, MHz: 0, Nodes: 1, Sockets: 1, Cores: 8, Threads: 1 +CPUs: 8/8, Nodes: 1, Sockets: 1, Cores: 8, Threads: 1 diff --git a/tests/virhostcpudata/linux-aarch64-rhelsa-3.19.0-mustang.expected b/tests/virhostcpudata/linux-aarch64-rhelsa-3.19.0-mustang.expected index 6776aa6c2..1926af836 100644 --- a/tests/virhostcpudata/linux-aarch64-rhelsa-3.19.0-mustang.expected +++ b/tests/virhostcpudata/linux-aarch64-rhelsa-3.19.0-mustang.expected @@ -1 +1 @@ -CPUs: 8/8, MHz: 0, Nodes: 1, Sockets: 1, Cores: 8, Threads: 1 +CPUs: 8/8, Nodes: 1, Sockets: 1, Cores: 8, Threads: 1 diff --git a/tests/virhostcpudata/linux-armv6l-raspberrypi.expected b/tests/virhostcpudata/linux-armv6l-raspberrypi.expected index 1c4c713d5..4961316fb 100644 --- a/tests/virhostcpudata/linux-armv6l-raspberrypi.expected +++ b/tests/virhostcpudata/linux-armv6l-raspberrypi.expected @@ -1 +1 @@ -CPUs: 1/1, MHz: 0, Nodes: 1, Sockets: 1, Cores: 1, Threads: 1 +CPUs: 1/1, Nodes: 1, Sockets: 1, Cores: 1, Threads: 1 diff --git a/tests/virhostcputest.c b/tests/virhostcputest.c index d3ee18461..9a1a48098 100644 --- a/tests/virhostcputest.c +++ b/tests/virhostcputest.c @@ -32,6 +32,7 @@ linuxTestCompareFiles(const char *cpuinfofile, const char *outputfile) { int ret = -1; + virBuffer buf = VIR_BUFFER_INITIALIZER; char *actualData = NULL; virNodeInfo nodeinfo; FILE *cpuinfo; @@ -57,20 +58,35 @@ linuxTestCompareFiles(const char *cpuinfofile, } VIR_FORCE_FCLOSE(cpuinfo); - if (virAsprintf(&actualData, - "CPUs: %u/%u, MHz: %u, Nodes: %u, Sockets: %u, " - "Cores: %u, Threads: %u\n", - nodeinfo.cpus, VIR_NODEINFO_MAXCPUS(nodeinfo), - nodeinfo.mhz, nodeinfo.nodes, nodeinfo.sockets, - nodeinfo.cores, nodeinfo.threads) < 0) + virBufferAsprintf(&buf, + "CPUs: %u/%u, ", + nodeinfo.cpus, VIR_NODEINFO_MAXCPUS(nodeinfo)); + + /* Only format the CPU frequency if it's known. This behavior is + * consistent with that of 'virsh nodeinfo' */ + if (nodeinfo.mhz) { + virBufferAsprintf(&buf, + "MHz: %u, ", + nodeinfo.mhz); + } + + virBufferAsprintf(&buf, + "Nodes: %u, Sockets: %u, Cores: %u, Threads: %u\n", + nodeinfo.nodes, nodeinfo.sockets, + nodeinfo.cores, nodeinfo.threads); + + if (virBufferError(&buf)) goto fail; + actualData = virBufferContentAndReset(&buf); + if (virTestCompareToFile(actualData, outputfile) < 0) goto fail; ret = 0; fail: + virBufferFreeAndReset(&buf); VIR_FREE(actualData); return ret; } -- 2.14.3

3 4

[libvirt] [PATCH] add support of iSER transport type in qemu with libiscsi
by lichstor＠gmail.com 09 Jan '18

09 Jan '18

From: zhangshengyu <zhangshengyu(a)fusionstack.cn> --- src/conf/domain_conf.c | 10 ++++++ src/qemu/qemu_block.c | 24 +++++++++++-- src/qemu/qemu_command.c | 3 ++ src/qemu/qemu_parse_command.c | 10 +++++- src/storage/storage_backend_gluster.c | 1 + src/util/virstoragefile.c | 3 +- src/util/virstoragefile.h | 1 + .../qemuargv2xmldata/disk-drive-network-iser.args | 25 +++++++++++++ tests/qemuargv2xmldata/disk-drive-network-iser.xml | 41 ++++++++++++++++++++++ tests/qemuargv2xmltest.c | 1 + .../qemuxml2argvdata/disk-drive-network-iser.args | 29 +++++++++++++++ tests/qemuxml2argvdata/disk-drive-network-iser.xml | 37 +++++++++++++++++++ tests/qemuxml2argvtest.c | 1 + .../qemuxml2xmloutdata/disk-drive-network-iser.xml | 41 ++++++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 15 files changed, 224 insertions(+), 4 deletions(-) create mode 100644 tests/qemuargv2xmldata/disk-drive-network-iser.args create mode 100644 tests/qemuargv2xmldata/disk-drive-network-iser.xml create mode 100644 tests/qemuxml2argvdata/disk-drive-network-iser.args create mode 100644 tests/qemuxml2argvdata/disk-drive-network-iser.xml create mode 100644 tests/qemuxml2xmloutdata/disk-drive-network-iser.xml diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9a62bc472..5767575d0 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -7080,6 +7080,7 @@ virDomainStorageNetworkParseHosts(xmlNodePtr node, virStorageNetHostDefPtr *hosts, size_t *nhosts) { + char *transport = NULL; xmlNodePtr child; for (child = node->children; child; child = child->next) { @@ -7091,6 +7092,11 @@ virDomainStorageNetworkParseHosts(xmlNodePtr node, } } + if ((*hosts) && (transport = virXMLPropString(node, "transport"))) { + //VIR_WARN("missing network source transport type"); + (*hosts)->transport = virStorageNetHostTransportTypeFromString(transport); + } + return 0; } @@ -8495,6 +8501,7 @@ virDomainDiskSourceNetworkParse(xmlNodePtr node, if (virDomainStorageNetworkParseHosts(node, &src->hosts, &src->nhosts) < 0) goto cleanup; + virStorageSourceNetworkAssignDefaultPorts(src); ret = 0; @@ -22364,6 +22371,9 @@ virDomainDiskSourceFormatNetwork(virBufferPtr attrBuf, VIR_FREE(path); + if (src->hosts->transport == VIR_STORAGE_NET_HOST_TRANS_ISER) + virBufferEscapeString(attrBuf, " transport='%s'", "iser"); + if (src->haveTLS != VIR_TRISTATE_BOOL_ABSENT && !(flags & VIR_DOMAIN_DEF_FORMAT_MIGRATABLE && src->tlsFromConfig)) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index 585f0255e..49837205f 100644 --- a/src/qemu/qemu_block.c +++ b/src/qemu/qemu_block.c @@ -433,6 +433,12 @@ qemuBlockStorageSourceGetURI(virStorageSourcePtr src) if (VIR_STRDUP(uri->scheme, virStorageNetProtocolTypeToString(src->protocol)) < 0) goto cleanup; + } else if (src->hosts->transport == VIR_STORAGE_NET_HOST_TRANS_ISER) { + uri->port = src->hosts->port; + + if (VIR_STRDUP(uri->scheme, + virStorageNetHostTransportTypeToString(src->hosts->transport)) < 0) + goto cleanup; } else { if (virAsprintf(&uri->scheme, "%s+%s", virStorageNetProtocolTypeToString(src->protocol), @@ -506,6 +512,19 @@ qemuBlockStorageSourceBuildJSONSocketAddress(virStorageNetHostDefPtr host, goto cleanup; break; + case VIR_STORAGE_NET_HOST_TRANS_ISER: + transport = "iser"; + if (virAsprintf(&port, "%u", host->port) < 0) + goto cleanup; + + if (virJSONValueObjectCreate(&server, + "s:type", transport, + "s:host", host->name, + "s:port", port, + NULL) < 0) + goto cleanup; + break; + case VIR_STORAGE_NET_HOST_TRANS_UNIX: if (virJSONValueObjectCreate(&server, "s:type", "unix", @@ -590,7 +609,8 @@ qemuBlockStorageSourceBuildJSONInetSocketAddress(virStorageNetHostDefPtr host) virJSONValuePtr ret = NULL; char *port = NULL; - if (host->transport != VIR_STORAGE_NET_HOST_TRANS_TCP) { + if (host->transport != VIR_STORAGE_NET_HOST_TRANS_TCP && + host->transport != VIR_STORAGE_NET_HOST_TRANS_ISER) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("only TCP protocol can be converted to InetSocketAddress")); return NULL; @@ -831,7 +851,7 @@ qemuBlockStorageSourceGetISCSIProps(virStorageSourcePtr src) "s:portal", portal, "s:target", target, "u:lun", lun, - "s:transport", "tcp", + "s:transport", virStorageNetHostTransportTypeToString(src->hosts->transport), "S:user", username, "S:password-secret", objalias, NULL)); diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 4d0c141e5..eb482097f 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -883,6 +883,8 @@ qemuBuildNetworkDriveStr(virStorageSourcePtr src, if (!((src->hosts->name && strchr(src->hosts->name, ':')) || (src->hosts->transport == VIR_STORAGE_NET_HOST_TRANS_TCP && !src->hosts->name) || + (src->hosts->transport == VIR_STORAGE_NET_HOST_TRANS_ISER && + !src->hosts->name) || (src->hosts->transport == VIR_STORAGE_NET_HOST_TRANS_UNIX && src->hosts->socket && src->hosts->socket[0] != '/'))) { @@ -891,6 +893,7 @@ qemuBuildNetworkDriveStr(virStorageSourcePtr src, switch (src->hosts->transport) { case VIR_STORAGE_NET_HOST_TRANS_TCP: + case VIR_STORAGE_NET_HOST_TRANS_ISER: virBufferAsprintf(&buf, "%s:%u", src->hosts->name, src->hosts->port); break; diff --git a/src/qemu/qemu_parse_command.c b/src/qemu/qemu_parse_command.c index 5fe3f97d0..d376af208 100644 --- a/src/qemu/qemu_parse_command.c +++ b/src/qemu/qemu_parse_command.c @@ -70,7 +70,9 @@ qemuParseDriveURIString(virDomainDiskDefPtr def, virURIPtr uri, if (transp) *transp++ = 0; - if (STRNEQ(uri->scheme, scheme)) { + if (STREQ(uri->scheme, "iser")) { + transp = (char *)"iser"; + } else if (STRNEQ(uri->scheme, scheme)) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Invalid transport/scheme '%s'"), uri->scheme); goto error; @@ -709,6 +711,12 @@ qemuParseCommandLineDisk(virDomainXMLOptionPtr xmlopt, if (qemuParseISCSIString(def) < 0) goto error; + } else if (STRPREFIX(def->src->path, "iser:")) { + def->src->type = VIR_STORAGE_TYPE_NETWORK; + def->src->protocol = VIR_STORAGE_NET_PROTOCOL_ISCSI; + + if (qemuParseISCSIString(def) < 0) + goto error; } else if (STRPREFIX(def->src->path, "sheepdog:")) { char *p = def->src->path; char *port, *vdi; diff --git a/src/storage/storage_backend_gluster.c b/src/storage/storage_backend_gluster.c index 5eea84f16..1452fa0cd 100644 --- a/src/storage/storage_backend_gluster.c +++ b/src/storage/storage_backend_gluster.c @@ -608,6 +608,7 @@ virStorageFileBackendGlusterInitServer(virStorageFileBackendGlusterPrivPtr priv, hoststr = host->socket; break; + case VIR_STORAGE_NET_HOST_TRANS_ISER: case VIR_STORAGE_NET_HOST_TRANS_LAST: break; } diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index 5780180a9..63253a9c4 100644 --- a/src/util/virstoragefile.c +++ b/src/util/virstoragefile.c @@ -92,7 +92,8 @@ VIR_ENUM_IMPL(virStorageNetProtocol, VIR_STORAGE_NET_PROTOCOL_LAST, VIR_ENUM_IMPL(virStorageNetHostTransport, VIR_STORAGE_NET_HOST_TRANS_LAST, "tcp", "unix", - "rdma") + "rdma", + "iser") VIR_ENUM_IMPL(virStorageSourcePoolMode, VIR_STORAGE_SOURCE_POOL_MODE_LAST, diff --git a/src/util/virstoragefile.h b/src/util/virstoragefile.h index ecd806c93..5a6ec7776 100644 --- a/src/util/virstoragefile.h +++ b/src/util/virstoragefile.h @@ -147,6 +147,7 @@ typedef enum { VIR_STORAGE_NET_HOST_TRANS_TCP, VIR_STORAGE_NET_HOST_TRANS_UNIX, VIR_STORAGE_NET_HOST_TRANS_RDMA, + VIR_STORAGE_NET_HOST_TRANS_ISER, VIR_STORAGE_NET_HOST_TRANS_LAST } virStorageNetHostTransport; diff --git a/tests/qemuargv2xmldata/disk-drive-network-iser.args b/tests/qemuargv2xmldata/disk-drive-network-iser.args new file mode 100644 index 000000000..c476e759e --- /dev/null +++ b/tests/qemuargv2xmldata/disk-drive-network-iser.args @@ -0,0 +1,25 @@ +LC_ALL=C \ +PATH=/bin \ +HOME=/home/test \ +USER=test \ +LOGNAME=test \ +QEMU_AUDIO_DRV=none \ +/usr/bin/qemu-system-i686 \ +-name QEMUGuest1 \ +-S \ +-M pc \ +-m 214 \ +-smp 1 \ +-uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ +-nographic \ +-monitor unix:/tmp/test-monitor,server,nowait \ +-no-acpi \ +-boot c \ +-usb \ +-drive file=iser://example.org:6000/iqn.1992-01.com.example,format=raw,\ +if=virtio \ +-drive file=iser://example.org:6000/iqn.1992-01.com.example/1,format=raw,\ +if=virtio \ +-net none \ +-serial none \ +-parallel none diff --git a/tests/qemuargv2xmldata/disk-drive-network-iser.xml b/tests/qemuargv2xmldata/disk-drive-network-iser.xml new file mode 100644 index 000000000..88f043f66 --- /dev/null +++ b/tests/qemuargv2xmldata/disk-drive-network-iser.xml @@ -0,0 +1,41 @@ +<domain type='qemu'> + <name>QEMUGuest1</name> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> + <memory unit='KiB'>219136</memory> + <currentMemory unit='KiB'>219136</currentMemory> + <vcpu placement='static'>1</vcpu> + <os> + <type arch='i686' machine='pc'>hvm</type> + <boot dev='hd'/> + </os> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <emulator>/usr/bin/qemu-system-i686</emulator> + <disk type='network' device='disk'> + <driver name='qemu' type='raw'/> + <source protocol='iscsi' name='iqn.1992-01.com.example/0' transport='iser'> + <host name='example.org' port='6000' transport='iser'/> + </source> + <target dev='vda' bus='virtio'/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> + </disk> + <disk type='network' device='disk'> + <driver name='qemu' type='raw'/> + <source protocol='iscsi' name='iqn.1992-01.com.example/1' transport='iser'> + <host name='example.org' port='6000' transport='iser'/> + </source> + <target dev='vdb' bus='virtio'/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/> + </disk> + <controller type='usb' index='0'> + <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x2'/> + </controller> + <controller type='pci' index='0' model='pci-root'/> + <input type='mouse' bus='ps2'/> + <input type='keyboard' bus='ps2'/> + <memballoon model='none'/> + </devices> +</domain> diff --git a/tests/qemuargv2xmltest.c b/tests/qemuargv2xmltest.c index cb010268c..3a82630e0 100644 --- a/tests/qemuargv2xmltest.c +++ b/tests/qemuargv2xmltest.c @@ -213,6 +213,7 @@ mymain(void) DO_TEST("disk-drive-network-nbd-unix"); DO_TEST("disk-drive-network-iscsi"); DO_TEST("disk-drive-network-iscsi-auth"); + DO_TEST("disk-drive-network-iser"); DO_TEST("disk-drive-network-gluster"); DO_TEST("disk-drive-network-rbd"); DO_TEST("disk-drive-network-rbd-auth"); diff --git a/tests/qemuxml2argvdata/disk-drive-network-iser.args b/tests/qemuxml2argvdata/disk-drive-network-iser.args new file mode 100644 index 000000000..49ea467ff --- /dev/null +++ b/tests/qemuxml2argvdata/disk-drive-network-iser.args @@ -0,0 +1,29 @@ +LC_ALL=C \ +PATH=/bin \ +HOME=/home/test \ +USER=test \ +LOGNAME=test \ +QEMU_AUDIO_DRV=none \ +/usr/bin/qemu-system-i686 \ +-name QEMUGuest1 \ +-S \ +-M pc \ +-m 214 \ +-smp 1,sockets=1,cores=1,threads=1 \ +-uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ +-nographic \ +-nodefaults \ +-chardev socket,id=charmonitor,path=/tmp/lib/domain--1-QEMUGuest1/monitor.sock,\ +server,nowait \ +-mon chardev=charmonitor,id=monitor,mode=readline \ +-no-acpi \ +-boot c \ +-usb \ +-drive file=iser://example.org:6000/iqn.1992-01.com.example/0,format=raw,\ +if=none,id=drive-virtio-disk0 \ +-device virtio-blk-pci,bus=pci.0,addr=0x3,drive=drive-virtio-disk0,\ +id=virtio-disk0 \ +-drive file=iser://example.org:6000/iqn.1992-01.com.example/1,format=raw,\ +if=none,id=drive-virtio-disk1 \ +-device virtio-blk-pci,bus=pci.0,addr=0x4,drive=drive-virtio-disk1,\ +id=virtio-disk1 diff --git a/tests/qemuxml2argvdata/disk-drive-network-iser.xml b/tests/qemuxml2argvdata/disk-drive-network-iser.xml new file mode 100644 index 000000000..b1634555c --- /dev/null +++ b/tests/qemuxml2argvdata/disk-drive-network-iser.xml @@ -0,0 +1,37 @@ +<domain type='qemu'> + <name>QEMUGuest1</name> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> + <memory unit='KiB'>219136</memory> + <currentMemory unit='KiB'>219136</currentMemory> + <vcpu placement='static'>1</vcpu> + <os> + <type arch='i686' machine='pc'>hvm</type> + <boot dev='hd'/> + </os> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <emulator>/usr/bin/qemu-system-i686</emulator> + <disk type='network' device='disk'> + <driver name='qemu' type='raw'/> + <source protocol='iscsi' name='iqn.1992-01.com.example' transport='iser'> + <host name='example.org' port='6000'/> + </source> + <target dev='vda' bus='virtio'/> + </disk> + <disk type='network' device='disk'> + <driver name='qemu' type='raw'/> + <source protocol='iscsi' name='iqn.1992-01.com.example/1' transport='iser'> + <host name='example.org' port='6000'/> + </source> + <target dev='vdb' bus='virtio'/> + </disk> + <controller type='usb' index='0'/> + <controller type='pci' index='0' model='pci-root'/> + <input type='mouse' bus='ps2'/> + <input type='keyboard' bus='ps2'/> + <memballoon model='none'/> + </devices> +</domain> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index ca24e0bbb..accfdaf4b 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -936,6 +936,7 @@ mymain(void) DO_TEST("disk-drive-network-iscsi-lun", QEMU_CAPS_NODEFCONFIG, QEMU_CAPS_VIRTIO_SCSI, QEMU_CAPS_SCSI_BLOCK); + DO_TEST("disk-drive-network-iser", NONE); DO_TEST("disk-drive-network-gluster", QEMU_CAPS_GLUSTER_DEBUG_LEVEL); DO_TEST("disk-drive-network-rbd", NONE); diff --git a/tests/qemuxml2xmloutdata/disk-drive-network-iser.xml b/tests/qemuxml2xmloutdata/disk-drive-network-iser.xml new file mode 100644 index 000000000..88f043f66 --- /dev/null +++ b/tests/qemuxml2xmloutdata/disk-drive-network-iser.xml @@ -0,0 +1,41 @@ +<domain type='qemu'> + <name>QEMUGuest1</name> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> + <memory unit='KiB'>219136</memory> + <currentMemory unit='KiB'>219136</currentMemory> + <vcpu placement='static'>1</vcpu> + <os> + <type arch='i686' machine='pc'>hvm</type> + <boot dev='hd'/> + </os> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <emulator>/usr/bin/qemu-system-i686</emulator> + <disk type='network' device='disk'> + <driver name='qemu' type='raw'/> + <source protocol='iscsi' name='iqn.1992-01.com.example/0' transport='iser'> + <host name='example.org' port='6000' transport='iser'/> + </source> + <target dev='vda' bus='virtio'/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> + </disk> + <disk type='network' device='disk'> + <driver name='qemu' type='raw'/> + <source protocol='iscsi' name='iqn.1992-01.com.example/1' transport='iser'> + <host name='example.org' port='6000' transport='iser'/> + </source> + <target dev='vdb' bus='virtio'/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/> + </disk> + <controller type='usb' index='0'> + <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x2'/> + </controller> + <controller type='pci' index='0' model='pci-root'/> + <input type='mouse' bus='ps2'/> + <input type='keyboard' bus='ps2'/> + <memballoon model='none'/> + </devices> +</domain> diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index 2be8eb2c1..23f9292c4 100644 --- a/tests/qemuxml2xmltest.c +++ b/tests/qemuxml2xmltest.c @@ -515,6 +515,7 @@ mymain(void) DO_TEST("disk-drive-network-nbd-unix", NONE); DO_TEST("disk-drive-network-iscsi", NONE); DO_TEST("disk-drive-network-iscsi-auth", NONE); + DO_TEST("disk-drive-network-iser", NONE); DO_TEST("disk-drive-network-gluster", NONE); DO_TEST("disk-drive-network-rbd", NONE); DO_TEST("disk-drive-network-rbd-auth", NONE); -- 2.13.6 (Apple Git-96)

3 3

Re: [libvirt] [PATCH] usb: allow host devices to be specified by port
by Xen Mann 09 Jan '18

09 Jan '18

> [libvirt] [PATCH] usb: allow host devices to be specified by port > > ------------------------------------------------------------ > > From: Thomas Hebb <thomas hebb editshare com>To: libvir-list redhat comCc: Thomas Hebb <thomas hebb editshare com>Subject: [libvirt] [PATCH] usb: allow host devices to be specified by portDate: Tue, 5 Jul 2016 17:21:24 -0400 > ------------------------------------------------------------ > Previously, only VID/PID and bus/device matching were supported. Neither > of these provide a stable and persistent way of assigning a guest a > specific host device out of several with the same VID and PID, as device > numbers change on every enumeration. Hey there, is this patch already part of libvirt? As mentioned by DanielB. (https://stackoverflow.com/questions/46421962/from-qemu-to-libvirtvirsh-add-…) this feature is probably already implemented by now. If so, I really would like to use it, it would save me lot's of work. Is this feature already part of libvirt? If it is already implemented, how can I use it? If not, is this on schedule? Thx in advance! Xensemann

1 0

[libvirt] [PATCH v4.1 0/2] qemu: Add support for hot unplugging redirdev
by Chen Hanxiao 08 Jan '18

08 Jan '18

v4.1: call qemuDomainRemoveRedirdevDevice in qemuDomainRemoveDevice v4: update commit messages and news v3: use helper qemuDomainDelChardevTLSObjects and address some comments v2: rebased on master Chen Hanxiao (2): qemu: Add support for hot unplugging redirdev device which can use the detach-device --live news: add change of hot unplug redirdev docs/news.xml | 5 +++ src/qemu/qemu_driver.c | 4 ++- src/qemu/qemu_hotplug.c | 96 ++++++++++++++++++++++++++++++++++++++++++++++++- src/qemu/qemu_hotplug.h | 4 +++ 4 files changed, 107 insertions(+), 2 deletions(-) -- 2.14.3

2 3

[libvirt] [PATCH] nodedev: Fix failing to parse PCI address for non-PCI network devices
by Fei Li 08 Jan '18

08 Jan '18

Commit 8708ca01c added virNetDevSwitchdevFeature to check whether the NIC had Switchdev capabilities; however this causes errors for network devices whose address is not in PCI format, like qeth device whose address is 0.0.0800, when calling virPCIDeviceAddressParse. Change virReportError to VIR_DEBUG to avoid these two error messages occuring when starting the libvirtd service, just leave their callers to handle the return values respectively. Signed-off-by: Fei Li <fli(a)suse.com> --- src/util/virpci.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/util/virpci.c b/src/util/virpci.c index fe57bef32..880d7baba 100644 --- a/src/util/virpci.c +++ b/src/util/virpci.c @@ -2561,7 +2561,7 @@ logStrToLong_ui(char const *s, ret = virStrToLong_ui(s, end_ptr, base, result); if (ret != 0) - VIR_ERROR(_("Failed to convert '%s' to unsigned int"), s); + VIR_DEBUG("Failed to convert '%s' to unsigned int", s); return ret; } @@ -2638,9 +2638,7 @@ virPCIGetDeviceAddressFromSysfsLink(const char *device_link) goto out; if (virPCIDeviceAddressParse(config_address, bdf) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Failed to parse PCI config address '%s'"), - config_address); + VIR_DEBUG("Failed to parse PCI config address '%s'", config_address); VIR_FREE(bdf); goto out; } -- 2.13.5

4 4

[libvirt] [PATCH] qemu: Prepare BIOS/UEFI when starting a domain
by Michal Privoznik 08 Jan '18

08 Jan '18

https://bugzilla.redhat.com/show_bug.cgi?id=1527740 Users might use a block device as UEFI VAR store. Or even have OVMF stored there. Therefore, when starting a domain and separate mount namespace is used, we have to create all the /dev entries that are configured for the domain. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_domain.c | 41 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 43bd0fff4..04af68809 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -9470,6 +9470,44 @@ qemuDomainSetupAllRNGs(virQEMUDriverConfigPtr cfg, } +static int +qemuDomainSetupLoader(virQEMUDriverConfigPtr cfg ATTRIBUTE_UNUSED, + virDomainObjPtr vm, + const struct qemuDomainCreateDeviceData *data) +{ + virDomainLoaderDefPtr loader = vm->def->os.loader; + int ret = -1; + + VIR_DEBUG("Setting up loader"); + + if (loader) { + switch ((virDomainLoader) loader->type) { + case VIR_DOMAIN_LOADER_TYPE_ROM: + if (qemuDomainCreateDevice(loader->path, data, false) < 0) + goto cleanup; + break; + + case VIR_DOMAIN_LOADER_TYPE_PFLASH: + if (qemuDomainCreateDevice(loader->path, data, false) < 0) + goto cleanup; + + if (loader->nvram && + qemuDomainCreateDevice(loader->nvram, data, false) < 0) + goto cleanup; + break; + + case VIR_DOMAIN_LOADER_TYPE_LAST: + break; + } + } + + VIR_DEBUG("Setup loader"); + ret = 0; + cleanup: + return ret; +} + + int qemuDomainBuildNamespace(virQEMUDriverConfigPtr cfg, virSecurityManagerPtr mgr, @@ -9538,6 +9576,9 @@ qemuDomainBuildNamespace(virQEMUDriverConfigPtr cfg, if (qemuDomainSetupAllRNGs(cfg, vm, &data) < 0) goto cleanup; + if (qemuDomainSetupLoader(cfg, vm, &data) < 0) + goto cleanup; + /* Save some mount points because we want to share them with the host */ for (i = 0; i < ndevMountsPath; i++) { struct stat sb; -- 2.13.6

2 1

[libvirt] [PATCH v3 0/5] Improvements to CPU frequency reporting
by Andrea Bolognani 08 Jan '18

08 Jan '18

Changes from [v2]: * improve the parser; * print the architecture name instead of "your architecture". Changes from [v1]: * adopt Bjoern's approach to refactoring. [v2] https://www.redhat.com/archives/libvir-list/2017-December/msg00467.html [v1] https://www.redhat.com/archives/libvir-list/2017-December/msg00356.html Andrea Bolognani (4): tests: Add host CPU data for Moonshot (RHEL 7.4) util: Print architecture name in /proc/cpuinfo parser util: Improve CPU frequency parsing util: Don't report CPU frequency for ARM hosts Bjoern Walk (1): util: virhostcpu: factor out frequency parsing src/Makefile.am | 1 + src/util/virhostcpu.c | 188 ++++++++++++--------- .../linux-aarch64-rhel74-moonshot.cpuinfo | 72 ++++++++ .../linux-aarch64-rhel74-moonshot.expected | 1 + .../linux-armv6l-raspberrypi.expected | 2 +- .../linux-rhel74-moonshot/cpu/cpu0/node0 | 1 + .../linux-rhel74-moonshot/cpu/cpu0/online | 1 + .../cpu/cpu0/topology/core_id | 1 + .../cpu/cpu0/topology/core_siblings | 1 + .../cpu/cpu0/topology/core_siblings_list | 1 + .../cpu/cpu0/topology/physical_package_id | 1 + .../cpu/cpu0/topology/thread_siblings | 1 + .../cpu/cpu0/topology/thread_siblings_list | 1 + .../linux-rhel74-moonshot/cpu/cpu1/node0 | 1 + .../linux-rhel74-moonshot/cpu/cpu1/online | 1 + .../cpu/cpu1/topology/core_id | 1 + .../cpu/cpu1/topology/core_siblings | 1 + .../cpu/cpu1/topology/core_siblings_list | 1 + .../cpu/cpu1/topology/physical_package_id | 1 + .../cpu/cpu1/topology/thread_siblings | 1 + .../cpu/cpu1/topology/thread_siblings_list | 1 + .../linux-rhel74-moonshot/cpu/cpu2/node0 | 1 + .../linux-rhel74-moonshot/cpu/cpu2/online | 1 + .../cpu/cpu2/topology/core_id | 1 + .../cpu/cpu2/topology/core_siblings | 1 + .../cpu/cpu2/topology/core_siblings_list | 1 + .../cpu/cpu2/topology/physical_package_id | 1 + .../cpu/cpu2/topology/thread_siblings | 1 + .../cpu/cpu2/topology/thread_siblings_list | 1 + .../linux-rhel74-moonshot/cpu/cpu3/node0 | 1 + .../linux-rhel74-moonshot/cpu/cpu3/online | 1 + .../cpu/cpu3/topology/core_id | 1 + .../cpu/cpu3/topology/core_siblings | 1 + .../cpu/cpu3/topology/core_siblings_list | 1 + .../cpu/cpu3/topology/physical_package_id | 1 + .../cpu/cpu3/topology/thread_siblings | 1 + .../cpu/cpu3/topology/thread_siblings_list | 1 + .../linux-rhel74-moonshot/cpu/cpu4/node0 | 1 + .../linux-rhel74-moonshot/cpu/cpu4/online | 1 + .../cpu/cpu4/topology/core_id | 1 + .../cpu/cpu4/topology/core_siblings | 1 + .../cpu/cpu4/topology/core_siblings_list | 1 + .../cpu/cpu4/topology/physical_package_id | 1 + .../cpu/cpu4/topology/thread_siblings | 1 + .../cpu/cpu4/topology/thread_siblings_list | 1 + .../linux-rhel74-moonshot/cpu/cpu5/node0 | 1 + .../linux-rhel74-moonshot/cpu/cpu5/online | 1 + .../cpu/cpu5/topology/core_id | 1 + .../cpu/cpu5/topology/core_siblings | 1 + .../cpu/cpu5/topology/core_siblings_list | 1 + .../cpu/cpu5/topology/physical_package_id | 1 + .../cpu/cpu5/topology/thread_siblings | 1 + .../cpu/cpu5/topology/thread_siblings_list | 1 + .../linux-rhel74-moonshot/cpu/cpu6/node0 | 1 + .../linux-rhel74-moonshot/cpu/cpu6/online | 1 + .../cpu/cpu6/topology/core_id | 1 + .../cpu/cpu6/topology/core_siblings | 1 + .../cpu/cpu6/topology/core_siblings_list | 1 + .../cpu/cpu6/topology/physical_package_id | 1 + .../cpu/cpu6/topology/thread_siblings | 1 + .../cpu/cpu6/topology/thread_siblings_list | 1 + .../linux-rhel74-moonshot/cpu/cpu7/node0 | 1 + .../linux-rhel74-moonshot/cpu/cpu7/online | 1 + .../cpu/cpu7/topology/core_id | 1 + .../cpu/cpu7/topology/core_siblings | 1 + .../cpu/cpu7/topology/core_siblings_list | 1 + .../cpu/cpu7/topology/physical_package_id | 1 + .../cpu/cpu7/topology/thread_siblings | 1 + .../cpu/cpu7/topology/thread_siblings_list | 1 + .../linux-rhel74-moonshot/cpu/kernel_max | 1 + .../linux-rhel74-moonshot/cpu/offline | 1 + .../linux-rhel74-moonshot/cpu/online | 1 + .../linux-rhel74-moonshot/cpu/possible | 1 + .../linux-rhel74-moonshot/cpu/present | 1 + .../linux-rhel74-moonshot/node/has_cpu | 1 + .../linux-rhel74-moonshot/node/has_memory | 1 + .../linux-rhel74-moonshot/node/has_normal_memory | 1 + .../linux-rhel74-moonshot/node/node0/cpu0 | 1 + .../linux-rhel74-moonshot/node/node0/cpu1 | 1 + .../linux-rhel74-moonshot/node/node0/cpu2 | 1 + .../linux-rhel74-moonshot/node/node0/cpu3 | 1 + .../linux-rhel74-moonshot/node/node0/cpu4 | 1 + .../linux-rhel74-moonshot/node/node0/cpu5 | 1 + .../linux-rhel74-moonshot/node/node0/cpu6 | 1 + .../linux-rhel74-moonshot/node/node0/cpu7 | 1 + .../linux-rhel74-moonshot/node/node0/cpulist | 1 + .../linux-rhel74-moonshot/node/node0/cpumap | 1 + .../linux-rhel74-moonshot/node/online | 1 + .../linux-rhel74-moonshot/node/possible | 1 + tests/virhostcpudata/linux-x86_64-test1.cpuinfo | 4 + tests/virhostcputest.c | 1 + 91 files changed, 273 insertions(+), 80 deletions(-) create mode 100644 tests/virhostcpudata/linux-aarch64-rhel74-moonshot.cpuinfo create mode 100644 tests/virhostcpudata/linux-aarch64-rhel74-moonshot.expected create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu0/node0 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu0/online create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu0/topology/core_id create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu0/topology/core_siblings create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu0/topology/core_siblings_list create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu0/topology/physical_package_id create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu0/topology/thread_siblings create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu0/topology/thread_siblings_list create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu1/node0 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu1/online create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu1/topology/core_id create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu1/topology/core_siblings create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu1/topology/core_siblings_list create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu1/topology/physical_package_id create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu1/topology/thread_siblings create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu1/topology/thread_siblings_list create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu2/node0 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu2/online create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu2/topology/core_id create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu2/topology/core_siblings create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu2/topology/core_siblings_list create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu2/topology/physical_package_id create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu2/topology/thread_siblings create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu2/topology/thread_siblings_list create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu3/node0 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu3/online create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu3/topology/core_id create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu3/topology/core_siblings create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu3/topology/core_siblings_list create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu3/topology/physical_package_id create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu3/topology/thread_siblings create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu3/topology/thread_siblings_list create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu4/node0 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu4/online create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu4/topology/core_id create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu4/topology/core_siblings create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu4/topology/core_siblings_list create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu4/topology/physical_package_id create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu4/topology/thread_siblings create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu4/topology/thread_siblings_list create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu5/node0 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu5/online create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu5/topology/core_id create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu5/topology/core_siblings create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu5/topology/core_siblings_list create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu5/topology/physical_package_id create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu5/topology/thread_siblings create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu5/topology/thread_siblings_list create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu6/node0 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu6/online create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu6/topology/core_id create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu6/topology/core_siblings create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu6/topology/core_siblings_list create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu6/topology/physical_package_id create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu6/topology/thread_siblings create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu6/topology/thread_siblings_list create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu7/node0 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu7/online create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu7/topology/core_id create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu7/topology/core_siblings create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu7/topology/core_siblings_list create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu7/topology/physical_package_id create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu7/topology/thread_siblings create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu7/topology/thread_siblings_list create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/kernel_max create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/offline create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/online create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/possible create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/cpu/present create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/node/has_cpu create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/node/has_memory create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/node/has_normal_memory create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/node/node0/cpu0 create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/node/node0/cpu1 create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/node/node0/cpu2 create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/node/node0/cpu3 create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/node/node0/cpu4 create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/node/node0/cpu5 create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/node/node0/cpu6 create mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/node/node0/cpu7 create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/node/node0/cpulist create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/node/node0/cpumap create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/node/online create mode 100644 tests/virhostcpudata/linux-rhel74-moonshot/node/possible -- 2.14.3

3 15

[libvirt] [PATCH] virsh: Checking the volume capacity before uploading a new file.
by Julio Faracco 08 Jan '18

08 Jan '18

The current command 'vol-upload' is not checking if the volume accepts a file bigger than its capacity. It can cause an interrupt of the upload stream. This commit adds a check that fails before starting to send new file to volume if the file is bigger. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1529059 Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- tools/virsh-volume.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tools/virsh-volume.c b/tools/virsh-volume.c index 8265a39..1359dba 100644 --- a/tools/virsh-volume.c +++ b/tools/virsh-volume.c @@ -672,6 +672,7 @@ cmdVolUpload(vshControl *ctl, const vshCmd *cmd) { const char *file = NULL; virStorageVolPtr vol = NULL; + virStorageVolInfo volumeInfo; bool ret = false; int fd = -1; virStreamPtr st = NULL; @@ -701,6 +702,9 @@ cmdVolUpload(vshControl *ctl, const vshCmd *cmd) cbData.ctl = ctl; cbData.fd = fd; + if (virStorageVolGetInfo(vol, &volumeInfo) < 0) + goto cleanup; + if (vshCommandOptBool(cmd, "sparse")) flags |= VIR_STORAGE_VOL_UPLOAD_SPARSE_STREAM; @@ -709,6 +713,11 @@ cmdVolUpload(vshControl *ctl, const vshCmd *cmd) goto cleanup; } + if (volumeInfo.capacity <= virFileLength(file, fd)) { + vshError(ctl, _("file is bigger than volume %s capacity"), name); + goto cleanup; + } + if (virStorageVolUpload(vol, st, offset, length, flags) < 0) { vshError(ctl, _("cannot upload to volume %s"), name); goto cleanup; -- 2.7.4

2 2

[libvirt] [PATCH v2 0/2] Introducing testDomainRename().
by Julio Faracco 08 Jan '18

08 Jan '18

This commit introduces the testDomainRename() for test driver. It includes: - testDomainRename() implementation. - Test case for virshtest to test 'domrename' command. Julio Faracco (2): test: Implementing testDomainRename(). tests: Adding test case for 'domrename' command inside virshtest. src/test/test_driver.c | 72 ++++++++++++++++++++++++++++++++++++++++++++++++++ tests/virshtest.c | 13 +++++++++ 2 files changed, 85 insertions(+) -- 2.7.4

2 4

[libvirt] [PATCH] domain_conf: skip boot order check of CD-ROM or floppy device
by Chen Hanxiao 06 Jan '18

06 Jan '18

From: Chen Hanxiao <chenhanxiao(a)gmail.com> If we insert or eject a CD-ROM/floppy device with a boot order, we may get: unsupported configuration: boot order 2 is already used by another device This check should be skipped in this case. Signed-off-by: Chen Hanxiao <chenhanxiao(a)gmail.com> --- src/conf/domain_conf.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9a62bc472..885ab88d2 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -26880,11 +26880,19 @@ virDomainDeviceInfoCheckBootIndex(virDomainDefPtr def ATTRIBUTE_UNUSED, { virDomainDeviceInfoPtr newinfo = opaque; + int disk_device = device->data.disk->device; if (info->bootIndex == newinfo->bootIndex) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("boot order %u is already used by another device"), - newinfo->bootIndex); - return -1; + /* Skip check for insert or eject CD-ROM device */ + if (disk_device == VIR_DOMAIN_DISK_DEVICE_FLOPPY || + disk_device == VIR_DOMAIN_DISK_DEVICE_CDROM) { + VIR_DEBUG("Skip boot index check for floppy or CDROM"); + return 0; + } else { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("boot order %u is already used by another device"), + newinfo->bootIndex); + return -1; + } } return 0; } -- 2.14.3

3 3

[libvirt] [PATCH v3 0/2] qemu: Add support for hot unplugging
by Chen Hanxiao 06 Jan '18

06 Jan '18

v3: use helper qemuDomainDelChardevTLSObjects and address some comments v2: rebased on master Chen Hanxiao (2): qemu: Add support for hot unplugging redirdev device which can use the detach-device --live news: add change of hot unplug redirdev docs/news.xml | 11 ++++++ src/qemu/qemu_driver.c | 4 ++- src/qemu/qemu_hotplug.c | 91 +++++++++++++++++++++++++++++++++++++++++++++++++ src/qemu/qemu_hotplug.h | 4 +++ 4 files changed, 109 insertions(+), 1 deletion(-) -- 2.14.3

3 7

[libvirt] [PATCH v4 00/13] Move qemu command line controller checks to qemuDomainDeviceDefValidateController* checks
by John Ferlan 06 Jan '18

06 Jan '18

v3: https://www.redhat.com/archives/libvir-list/2017-December/msg00209.html Differences since v3: * Pushed first 4 ACK'd patches of v3 * Rework/Separate out a few patches for the SCSI handling * Alter the PCI handling as requested by code review (although I still had a question to a review comment regarding whether or not the model should be handled in PostParse). * Alter the SATA code as indicated by code review * Add Andrea's patch into the series Andrea Bolognani (1): qemu: Add missing checks for pcie-root-port options John Ferlan (12): qemu: Introduce qemuDomainDeviceDefValidateControllerAttributes qemu: Move model set for qemuBuildControllerDevStr qemu: Adjust SCSI controller switch in qemuBuildControllerDevStr qemu: Add check for iothread attribute in validate controller qemu: Introduce qemuDomainDeviceDefValidateControllerSCSI qemu: Introduce qemuDomainDeviceDefValidateControllerPCI qemu: Use virDomainPCIControllerOpts in qemuBuildControllerDevStr qemu: Move PCI command modelName check to controller def validate qemu: Move PCI command modelName TypeToString to controller def validate qemu: Move PCI more command checks to controller def validate qemu: Complete PCI command checks to controller def validate qemu: Introduce qemuDomainDeviceDefValidateControllerSATA src/qemu/qemu_command.c | 403 ++++------------------------------------------ src/qemu/qemu_domain.c | 420 +++++++++++++++++++++++++++++++++++++++++++++++- tests/qemumemlocktest.c | 14 ++ tests/qemuxml2xmltest.c | 5 +- 4 files changed, 466 insertions(+), 376 deletions(-) -- 2.13.6

2 20

[libvirt] [PATCH] [PATCH] vcpupin: add clear feature
by Yi Wang 05 Jan '18

05 Jan '18

We can't clear vcpupin settings of XML once we did vcpupin command, this is not convenient under some condition such as migration. This patch introduces clear feature, which can clear vcpuin setting of XML. Signed-off-by: Yi Wang <wang.yi59(a)zte.com.cn> Signed-off-by: Xi Xu <xu.xi8(a)zte.com.cn> --- include/libvirt/libvirt-domain.h | 1 + src/qemu/qemu_driver.c | 24 +++++++++++++++++++----- tools/virsh-domain.c | 5 ++++- tools/virsh.pod | 1 + 4 files changed, 25 insertions(+), 6 deletions(-) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index 4048acf..7b171df 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -1837,6 +1837,7 @@ typedef enum { VIR_DOMAIN_VCPU_MAXIMUM = (1 << 2), /* Max rather than current count */ VIR_DOMAIN_VCPU_GUEST = (1 << 3), /* Modify state of the cpu in the guest */ VIR_DOMAIN_VCPU_HOTPLUGGABLE = (1 << 4), /* Make vcpus added hot(un)pluggable */ + VIR_DOMAIN_VCPU_CLEAR = (1 << 5), /* Clear vcpus pin info */ } virDomainVcpuFlags; int virDomainSetVcpus (virDomainPtr domain, diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 97b194b..9e8759f 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -5001,7 +5001,7 @@ qemuDomainPinVcpuLive(virDomainObjPtr vm, int vcpu, virQEMUDriverPtr driver, virQEMUDriverConfigPtr cfg, - virBitmapPtr cpumap) + virBitmapPtr cpumap, bool clear) { virBitmapPtr tmpmap = NULL; virDomainVcpuDefPtr vcpuinfo; @@ -5049,7 +5049,12 @@ qemuDomainPinVcpuLive(virDomainObjPtr vm, } virBitmapFree(vcpuinfo->cpumask); - vcpuinfo->cpumask = tmpmap; + if (clear) { + virBitmapFree(tmpmap); + vcpuinfo->cpumask = NULL; + } else { + vcpuinfo->cpumask = tmpmap; + } tmpmap = NULL; if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps) < 0) @@ -5093,9 +5098,11 @@ qemuDomainPinVcpuFlags(virDomainPtr dom, virBitmapPtr pcpumap = NULL; virDomainVcpuDefPtr vcpuinfo = NULL; virQEMUDriverConfigPtr cfg = NULL; + bool clear = false; virCheckFlags(VIR_DOMAIN_AFFECT_LIVE | - VIR_DOMAIN_AFFECT_CONFIG, -1); + VIR_DOMAIN_AFFECT_CONFIG | + VIR_DOMAIN_VCPU_CLEAR, -1); cfg = virQEMUDriverGetConfig(driver); @@ -5111,6 +5118,8 @@ qemuDomainPinVcpuFlags(virDomainPtr dom, if (virDomainObjGetDefs(vm, flags, &def, &persistentDef) < 0) goto endjob; + clear = !!(flags & VIR_DOMAIN_VCPU_CLEAR); + if ((def && def->virtType == VIR_DOMAIN_VIRT_QEMU) || (persistentDef && persistentDef->virtType == VIR_DOMAIN_VIRT_QEMU)) { virReportError(VIR_ERR_OPERATION_FAILED, "%s", @@ -5136,12 +5145,17 @@ qemuDomainPinVcpuFlags(virDomainPtr dom, } if (def && - qemuDomainPinVcpuLive(vm, def, vcpu, driver, cfg, pcpumap) < 0) + qemuDomainPinVcpuLive(vm, def, vcpu, driver, cfg, pcpumap, clear) < 0) goto endjob; if (persistentDef) { virBitmapFree(vcpuinfo->cpumask); - vcpuinfo->cpumask = pcpumap; + if (clear) { + virBitmapFree(pcpumap); + vcpuinfo->cpumask = NULL; + } else { + vcpuinfo->cpumask = pcpumap; + } pcpumap = NULL; ret = virDomainSaveConfig(cfg->configDir, driver->caps, persistentDef); diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 93cb020..4bad9e7 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -6860,7 +6860,7 @@ virshParseCPUList(vshControl *ctl, int *cpumaplen, unsigned char *cpumap = NULL; virBitmapPtr map = NULL; - if (cpulist[0] == 'r') { + if (cpulist[0] == 'r' || STREQ("clear", cpulist)) { if (!(map = virBitmapNew(maxcpu))) return NULL; virBitmapSetAll(map); @@ -6938,6 +6938,9 @@ cmdVcpuPin(vshControl *ctl, const vshCmd *cmd) goto cleanup; } + if (STREQ(cpulist, "clear")) + flags |= VIR_DOMAIN_VCPU_CLEAR; + /* Pin mode: pinning specified vcpu to specified physical cpus*/ if (!(cpumap = virshParseCPUList(ctl, &cpumaplen, cpulist, maxcpu))) goto cleanup; diff --git a/tools/virsh.pod b/tools/virsh.pod index 69cc423..caaa230 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -2857,6 +2857,7 @@ I<cpulist> is a list of physical CPU numbers. Its syntax is a comma separated list and a special markup using '-' and '^' (ex. '0-4', '0-3,^2') can also be allowed. The '-' denotes the range and the '^' denotes exclusive. For pinning the I<vcpu> to all physical cpus specify 'r' as a I<cpulist>. +For clearing pinning info, specify 'clear' as a I<cpulist>. If I<--live> is specified, affect a running guest. If I<--config> is specified, affect the next boot of a persistent guest. If I<--current> is specified, affect the current guest state. -- 1.8.3.1

3 2

[libvirt] [PATCH v2 0/2] Enable pseries machine's max-cpu-compat parameter
by Shivaprasad G Bhat 05 Jan '18

05 Jan '18

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1519146 --- Shivaprasad G Bhat (2): qemu: Add capability for pseries machine's max-cpu-compat= parameter qemu: Add support for pseries machine's max-cpu-compat= parameter src/qemu/qemu_capabilities.c | 7 +++++++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 11 ++++++++++ tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml | 1 + .../pseries-machine-max-cpu-compat.args | 21 ++++++++++++++++++++ .../pseries-machine-max-cpu-compat.xml | 17 ++++++++++++++++ tests/qemuxml2argvtest.c | 5 +++++ 7 files changed, 62 insertions(+), 1 deletion(-) create mode 100644 tests/qemuxml2argvdata/pseries-machine-max-cpu-compat.args create mode 100644 tests/qemuxml2argvdata/pseries-machine-max-cpu-compat.xml -- Signature

2 3

[libvirt] [PATCH] nodedev: update mdev_types caps before dumpxml
by Wu Zongyong 05 Jan '18

05 Jan '18

Wu Zongyong (1): nodedev: update mdev_types caps before dumpxml src/node_device/node_device_linux_sysfs.c | 42 +++++++++++++++++++++++++++++++ src/node_device/node_device_udev.c | 11 ++++++-- src/node_device/node_device_udev.h | 8 ++++++ 3 files changed, 59 insertions(+), 2 deletions(-) -- 1.9.1

2 2

[libvirt] [PATCH] qemuDomainDiskChangeSupported: Forbid alias change
by Michal Privoznik 05 Jan '18

05 Jan '18

Since we have user aliases it may happen that users want to change it using 'update-device'. Instead of ignoring it silently, error out loudly. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_domain.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 347fc0742..00d6c41c9 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -6762,6 +6762,14 @@ qemuDomainDiskChangeSupported(virDomainDiskDefPtr disk, return false; } + if (disk->info.alias && + STRNEQ_NULLABLE(disk->info.alias, orig_disk->info.alias)) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, + _("cannot modify field '%s' of the disk"), + "alias"); + return false; + } + CHECK_EQ(info.bootIndex, "boot order", true); CHECK_EQ(rawio, "rawio", true); CHECK_EQ(sgio, "sgio", true); -- 2.13.6

3 7

[libvirt] [PATCH] qemuDomainAttachDeviceMknodHelper: Remove symlink before creating it
by Michal Privoznik 05 Jan '18

05 Jan '18

https://bugzilla.redhat.com/show_bug.cgi?id=1528502 So imagine you have /dev/blah symlink which points to /dev/sda. You attach /dev/blah as disk to your domain. Libvirt correctly creates the /dev/blah -> /dev/sda symlink in the qemu namespace. However, then you detach the disk, change the symlink so that it points to /dev/sdb and tries to attach the disk again. This time, however, the attach fails (well, qemu attaches wrong disk) because the code assumes that symlinks don't change. Well they do. This is inspired by test fix written by Eduardo Habkost. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_domain.c | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 70fb40650..5f29d1ad5 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -9737,13 +9737,23 @@ qemuDomainAttachDeviceMknodHelper(pid_t pid ATTRIBUTE_UNUSED, if (isLink) { VIR_DEBUG("Creating symlink %s -> %s", data->file, data->target); + + /* First, unlink the symlink target. Symlinks change and + * therefore we have no guarantees that pre-existing + * symlink is still valid. */ + if (unlink(data->file) < 0 && + errno != ENOENT) { + virReportSystemError(errno, + _("Unable to remove symlink %s"), + data->file); + goto cleanup; + } + if (symlink(data->target, data->file) < 0) { - if (errno != EEXIST) { - virReportSystemError(errno, - _("Unable to create symlink %s"), - data->target); - goto cleanup; - } + virReportSystemError(errno, + _("Unable to create symlink %s"), + data->target); + goto cleanup; } else { delDevice = true; } -- 2.13.6

2 4

[libvirt] About CVE-2017-5715
by Wang King 05 Jan '18

05 Jan '18

As CVE-2017-5715 described on https://access.redhat.com/security/cve/cve-2017-5715, libvirt under the influence yet, So what's coming next for this? Signed-off-by: Wang King <king.wang(a)huawei.com> -- 2.8.3

3 3

[libvirt] [PATCH 0/2] Enable pseries machine's max-cpu-compat parameter
by Shivaprasad G Bhat 05 Jan '18

05 Jan '18

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1519146 --- Shivaprasad G Bhat (2): qemu: Add capability for pseries machine's max-cpu-compat= parameter qemu: Add support for pseries machine's max-cpu-compat= parameter src/qemu/qemu_capabilities.c | 7 ++++++ src/qemu/qemu_capabilities.h | 2 ++ src/qemu/qemu_command.c | 14 ++++++++++-- tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml | 1 + .../pseries-machine-max-cpu-compat.args | 23 ++++++++++++++++++++ .../pseries-machine-max-cpu-compat.xml | 21 ++++++++++++++++++ tests/qemuxml2argvtest.c | 5 ++++ 7 files changed, 70 insertions(+), 3 deletions(-) create mode 100644 tests/qemuxml2argvdata/pseries-machine-max-cpu-compat.args create mode 100644 tests/qemuxml2argvdata/pseries-machine-max-cpu-compat.xml -- Signature

2 4

[libvirt] [PATCH] Fixed documentation for destroy storage pool
by frankie＠telecos.upc.edu 05 Jan '18

05 Jan '18

From: Francesc Guasch <frankie(a)telecos.upc.edu> --- lib/Sys/Virt/StoragePool.pm | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/Sys/Virt/StoragePool.pm b/lib/Sys/Virt/StoragePool.pm index 0bc1d50..2ba5101 100644 --- a/lib/Sys/Virt/StoragePool.pm +++ b/lib/Sys/Virt/StoragePool.pm @@ -115,14 +115,11 @@ C<define_storage_pool> method in L<Sys::Virt>. Remove the configuration associated with a storage pool previously defined with the C<define_storage pool> method in L<Sys::Virt>. If the storage pool is -running, you probably want to use the C<shutdown> or C<destroy> -methods instead. +running, you probably want to use the C<destroy> method instead. =item $pool->destroy() -Immediately terminate the machine, and remove it from the virtual -machine monitor. The C<$pool> handle is invalid after this call -completes and should not be used again. +Immediately stop the storage pool. =item $flag = $pool->get_autostart(); -- 2.14.1

3 3

[libvirt] [REBASE PATCH v2 0/8] Implement query-dump command
by John Ferlan 05 Jan '18

05 Jan '18

Previous rebase: https://www.redhat.com/archives/libvir-list/2017-December/msg00124.html Rebase after pushing first 2 ACK'd patches and for recent capabilities adjustments. Plus it's been a month... Original v2: https://www.redhat.com/archives/libvir-list/2017-November/msg00779.html Rebase due to additional capabilitiies v2 Cover: v1: https://www.redhat.com/archives/libvir-list/2017-November/msg00731.html Differences from v1 (besides more patches) Rather than use a timing loop in order to fetch the dump stats and the presence of the 'query-dump' command, let's use the DUMP_COMPLETED event and wire that up in order to determine when the dump has been completed. In the mean time, the previous timing loop is converted into a qemuDomainGetJobInfoDumpStats to be called if the "right conditions" exist. Also found/fixed a couple of minor issues from v1 regarding usage "dumpformat" instead of just "format" from my patch 2 adjustment and a type for qemuMonitorDumpStatus (was qemuMontiorDumpStatus in v1). NB: (from v1 cover): Details in the patches. Essentially though QEMU 2.6 added the ability to perform the 'dump-guest-memory' via a thread by adding a 'detach' boolean to the command. In order to watch the progress of the thread the 'query-dump' command was added. The query-dump will return just the current status, the total size to be dumped, and the current progress. So using the migrate stats data in the DomainJobInfo we can then save our current progress allowing tools such as virsh to watch that progress. As an added benefit, the dump-guest-memory is now truly asynchronous. John Ferlan (8): qemu: Add support for DUMP_COMPLETED event qemu: Introduce qemuProcessHandleDumpCompleted qemu: Introduce qemuMonitor[JSON]QueryDump qemu: Add new parameter to qemuMonitorDumpToFd qemu: Introduce qemuDomainGetJobInfoMigrationStats qemu: Introduce qemuDomainGetJobInfoDumpStats qemu: Add dump completed event to the capabilities qemu: Allow showing the dump progress for memory only dump src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_domain.c | 2 + src/qemu/qemu_domain.h | 2 + src/qemu/qemu_driver.c | 146 ++++++++++++++++++--- src/qemu/qemu_monitor.c | 39 +++++- src/qemu/qemu_monitor.h | 33 ++++- src/qemu/qemu_monitor_json.c | 104 ++++++++++++++- src/qemu/qemu_monitor_json.h | 7 +- src/qemu/qemu_process.c | 23 ++++ .../caps_2.10.0-gicv2.aarch64.xml | 1 + .../caps_2.10.0-gicv3.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 1 + .../caps_2.6.0-gicv2.aarch64.xml | 1 + .../caps_2.6.0-gicv3.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 + tests/qemumonitorjsontest.c | 3 +- 27 files changed, 352 insertions(+), 26 deletions(-) -- 2.13.6

2 9

[libvirt] [PATCH v4 0/2] qemu: Add support for hot unplugging redirdev
by Chen Hanxiao 05 Jan '18

05 Jan '18

v4: update commit messages and news v3: use helper qemuDomainDelChardevTLSObjects and address some comments v2: rebased on master Chen Hanxiao (2): qemu: Add support for hot unplugging redirdev device which can use the detach-device --live news: add change of hot unplug redirdev docs/news.xml | 5 +++ src/qemu/qemu_driver.c | 4 ++- src/qemu/qemu_hotplug.c | 90 +++++++++++++++++++++++++++++++++++++++++++++++++ src/qemu/qemu_hotplug.h | 4 +++ 4 files changed, 102 insertions(+), 1 deletion(-) -- 2.14.3

1 2

[libvirt] [PATCH v3 0/6] Add setting CPU features (CPUID) with libxenlight driver.
by Marek Marczykowski-Górecki 05 Jan '18

05 Jan '18

Add support for CPUID setting based on <cpu> element. Since libxl format support only adjusting specific bits over host CPU, only mode='host-passthrough' is supported - other values are rejected (including default 'custom'). This will break some configurations working before (bare <cpu> element with for example NUMA configuration), but libxl driver never supported full 'custom' mode - it was silently ignored, which might lead to some unexpected effects. Since mode='host-passthrough' is now necessary to specify CPU options, do not enable nested HVM feature by mere presence of this element, require explicit enabling "vmx" or "svm" bits. Nested HVM is still in "preview" state, so better be explicit here. v2 of this patch series: https://www.redhat.com/archives/libvir-list/2017-July/msg00050.html Marek Marczykowski-Górecki (6): libxl: error out on not supported CPU mode, instead of silently ignoring libxl: do not enable nested HVM by mere presence of <cpu> element libxl: add support for CPUID features policy tests: check CPU features handling in libxl driver xenconfig: add CPUID handling to domXML <-> xl.cfg conversion tests: add test case for CPUID in xenconfig driver src/libxl/libxl_conf.c | 53 +- src/xenconfig/xen_xl.c | 260 ++++++++- src/xenconfig/xen_xl.h | 2 +- tests/libxlxml2domconfigdata/fullvirt-cpuid.json | 64 ++- tests/libxlxml2domconfigdata/fullvirt-cpuid.xml | 37 +- tests/libxlxml2domconfigdata/vnuma-hvm.json | 1 +- tests/libxlxml2domconfigtest.c | 1 +- tests/xlconfigdata/test-fullvirt-cpuid.cfg | 25 +- tests/xlconfigdata/test-fullvirt-cpuid.xml | 36 +- tests/xlconfigdata/test-fullvirt-nestedhvm.xml | 4 +- tests/xlconfigdata/test-fullvirt-vnuma-autocomplete.xml | 2 +- tests/xlconfigdata/test-fullvirt-vnuma-nodistances.xml | 2 +- tests/xlconfigdata/test-fullvirt-vnuma-partialdist.xml | 2 +- tests/xlconfigdata/test-fullvirt-vnuma.xml | 2 +- tests/xlconfigtest.c | 1 +- 15 files changed, 453 insertions(+), 39 deletions(-) create mode 100644 tests/libxlxml2domconfigdata/fullvirt-cpuid.json create mode 100644 tests/libxlxml2domconfigdata/fullvirt-cpuid.xml create mode 100644 tests/xlconfigdata/test-fullvirt-cpuid.cfg create mode 100644 tests/xlconfigdata/test-fullvirt-cpuid.xml base-commit: 984c534a3f2219444f4cb4df61d77b8c6e5054d7 -- git-series 0.9.1

4 22

[libvirt] [PATCH V3] blockjob: Fix error checking of blockjob status
by Jie Wang 05 Jan '18

05 Jan '18

offset and len can also be equal to 0 on failed if blockjob return status:"BLOCK_JOB_COMPLETED" with error:"File descriptor in bad state", so it's better to make our decision based on whether 'error' is non-NULL. --- src/qemu/qemu_monitor_json.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index e45868b..18b2ad6 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -885,8 +885,7 @@ qemuMonitorJSONHandleBlockJobImpl(qemuMonitorPtr mon, switch ((virConnectDomainEventBlockJobStatus) event) { case VIR_DOMAIN_BLOCK_JOB_COMPLETED: error = virJSONValueObjectGetString(data, "error"); - /* Make sure the whole device has been processed */ - if (offset != len) + if (offset != len || error) event = VIR_DOMAIN_BLOCK_JOB_FAILED; break; case VIR_DOMAIN_BLOCK_JOB_CANCELED: -- 1.8.3.1

1 0

[libvirt] [PATCH] qemu_hotplug: use VIR_ERR_NO_DEVICE when target detaching device is not found
by Chen Hanxiao 05 Jan '18

05 Jan '18

From: Chen Hanxiao <chenhanxiao(a)gmail.com> We used VIR_ERR_OPERATION_FAILED when target detaching device is not found. That error code VIR_ERR_OPERATION_FAILED is widely used, so the tools powered by libvirt, such as nova, can't catch the exact errors from libvirt. This patch uses VIR_ERR_NO_DEVICE instead. Signed-off-by: Chen Hanxiao <chenhanxiao(a)gmail.com> --- src/libvirt_private.syms | 2 ++ src/qemu/qemu_hotplug.c | 51 +++++++++++++++++++++++++++++++----------------- 2 files changed, 35 insertions(+), 18 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index d5c3b9abb..31e83f152 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -203,6 +203,7 @@ virDomainChrConsoleTargetTypeToString; virDomainChrDefForeach; virDomainChrDefFree; virDomainChrDefNew; +virDomainChrDeviceTypeToString; virDomainChrEquals; virDomainChrFind; virDomainChrGetDomainPtrs; @@ -427,6 +428,7 @@ virDomainMemoryDefFree; virDomainMemoryFindByDef; virDomainMemoryFindInactiveByDef; virDomainMemoryInsert; +virDomainMemoryModelTypeToString; virDomainMemoryRemove; virDomainMemorySourceTypeFromString; virDomainMemorySourceTypeToString; diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 7de04c85a..0fa3c54c0 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -3454,7 +3454,7 @@ qemuDomainChangeGraphics(virQEMUDriverPtr driver, int ret = -1; if (!olddev) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + virReportError(VIR_ERR_NO_DEVICE, "%s", _("cannot find existing graphics device to modify")); goto cleanup; } @@ -4743,7 +4743,7 @@ int qemuDomainDetachControllerDevice(virQEMUDriverPtr driver, if ((idx = virDomainControllerFind(vm->def, dev->data.controller->type, dev->data.controller->idx)) < 0) { - virReportError(VIR_ERR_OPERATION_FAILED, + virReportError(VIR_ERR_NO_DEVICE, _("controller %s:%d not found"), virDomainControllerTypeToString(dev->data.controller->type), dev->data.controller->idx); @@ -4972,18 +4972,18 @@ int qemuDomainDetachHostDevice(virQEMUDriverPtr driver, if (idx < 0) { switch (subsys->type) { case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI: - virReportError(VIR_ERR_OPERATION_FAILED, + virReportError(VIR_ERR_NO_DEVICE, _("host pci device %.4x:%.2x:%.2x.%.1x not found"), pcisrc->addr.domain, pcisrc->addr.bus, pcisrc->addr.slot, pcisrc->addr.function); break; case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB: if (usbsrc->bus && usbsrc->device) { - virReportError(VIR_ERR_OPERATION_FAILED, + virReportError(VIR_ERR_NO_DEVICE, _("host usb device %03d.%03d not found"), usbsrc->bus, usbsrc->device); } else { - virReportError(VIR_ERR_OPERATION_FAILED, + virReportError(VIR_ERR_NO_DEVICE, _("host usb device vendor=0x%.4x product=0x%.4x not found"), usbsrc->vendor, usbsrc->product); } @@ -4992,13 +4992,13 @@ int qemuDomainDetachHostDevice(virQEMUDriverPtr driver, if (scsisrc->protocol == VIR_DOMAIN_HOSTDEV_SCSI_PROTOCOL_TYPE_ISCSI) { virDomainHostdevSubsysSCSIiSCSIPtr iscsisrc = &scsisrc->u.iscsi; - virReportError(VIR_ERR_OPERATION_FAILED, + virReportError(VIR_ERR_NO_DEVICE, _("host scsi iSCSI path %s not found"), iscsisrc->src->path); } else { virDomainHostdevSubsysSCSIHostPtr scsihostsrc = &scsisrc->u.host; - virReportError(VIR_ERR_OPERATION_FAILED, + virReportError(VIR_ERR_NO_DEVICE, _("host scsi device %s:%u:%u.%llu not found"), scsihostsrc->adapter, scsihostsrc->bus, scsihostsrc->target, scsihostsrc->unit); @@ -5036,8 +5036,10 @@ qemuDomainDetachShmemDevice(virQEMUDriverPtr driver, qemuDomainObjPrivatePtr priv = vm->privateData; if ((idx = virDomainShmemDefFind(vm->def, dev)) < 0) { - virReportError(VIR_ERR_OPERATION_INVALID, "%s", - _("device not present in domain configuration")); + virReportError(VIR_ERR_NO_DEVICE, + _("Shmem device of model '%s' not found " + "in domain configuration"), + virDomainShmemModelTypeToString(dev->model)); return -1; } @@ -5093,8 +5095,10 @@ qemuDomainDetachWatchdog(virQEMUDriverPtr driver, watchdog->model == dev->model && watchdog->action == dev->action && virDomainDeviceInfoAddressIsEqual(&dev->info, &watchdog->info))) { - virReportError(VIR_ERR_OPERATION_INVALID, "%s", - _("watchdog device not present in domain configuration")); + virReportError(VIR_ERR_NO_DEVICE, + _("watchdog device of model '%s' is not " + "found in domain configuration"), + virDomainWatchdogModelTypeToString(watchdog->model)); return -1; } @@ -5134,8 +5138,13 @@ qemuDomainDetachNetDevice(virQEMUDriverPtr driver, virDomainNetDefPtr detach = NULL; qemuDomainObjPrivatePtr priv = vm->privateData; - if ((detachidx = virDomainNetFindIdx(vm->def, dev->data.net)) < 0) + if ((detachidx = virDomainNetFindIdx(vm->def, dev->data.net)) < 0) { + char mac[VIR_MAC_STRING_BUFLEN]; + virReportError(VIR_ERR_NO_DEVICE, + _("netdev '%s' not found in domain configuration"), + virMacAddrFormat(&dev->data.net->mac, mac)); goto cleanup; + } detach = vm->def->nets[detachidx]; @@ -5321,8 +5330,10 @@ int qemuDomainDetachChrDevice(virQEMUDriverPtr driver, char *devstr = NULL; if (!(tmpChr = virDomainChrFind(vmdef, chr))) { - virReportError(VIR_ERR_OPERATION_INVALID, "%s", - _("device not present in domain configuration")); + virReportError(VIR_ERR_NO_DEVICE, + _("Chr device of type '%s' not found " + "in domain configuration"), + virDomainChrDeviceTypeToString(chr->deviceType)); goto cleanup; } @@ -5368,8 +5379,10 @@ qemuDomainDetachRNGDevice(virQEMUDriverPtr driver, int ret = -1; if ((idx = virDomainRNGFind(vm->def, rng)) < 0) { - virReportError(VIR_ERR_OPERATION_INVALID, "%s", - _("device not present in domain configuration")); + virReportError(VIR_ERR_NO_DEVICE, + _("RNG device of model '%s' not found " + "in domain configuration"), + virDomainRNGBackendTypeToString(rng->model)); return -1; } @@ -5411,8 +5424,10 @@ qemuDomainDetachMemoryDevice(virQEMUDriverPtr driver, qemuDomainMemoryDeviceAlignSize(vm->def, memdef); if ((idx = virDomainMemoryFindByDef(vm->def, memdef)) < 0) { - virReportError(VIR_ERR_OPERATION_INVALID, "%s", - _("device not present in domain configuration")); + virReportError(VIR_ERR_NO_DEVICE, + _("memory device of model '%s' not found " + "in domain configuration"), + virDomainMemoryModelTypeToString(memdef->model)); return -1; } -- 2.14.3

2 1

[libvirt] [PATCH V2] blockjob: Fix error checking of blockjob status
by Jie Wang 04 Jan '18

04 Jan '18

offset and len can also be equal to 0 on failed if blockjob return status:"BLOCK_JOB_COMPLETED" with error:"File descriptor in bad state", so it's better to make our decision based on whether 'error' is non-NULL. --- src/qemu/qemu_monitor_json.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index e45868b..ae64a5a 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -885,8 +885,7 @@ qemuMonitorJSONHandleBlockJobImpl(qemuMonitorPtr mon, switch ((virConnectDomainEventBlockJobStatus) event) { case VIR_DOMAIN_BLOCK_JOB_COMPLETED: error = virJSONValueObjectGetString(data, "error"); - /* Make sure the whole device has been processed */ - if (offset != len) + if (error != NULL) event = VIR_DOMAIN_BLOCK_JOB_FAILED; break; case VIR_DOMAIN_BLOCK_JOB_CANCELED: -- 1.8.3.1

2 1

[libvirt] [PATCH v2 0/3] Storage pool common object fixes
by John Ferlan 04 Jan '18

04 Jan '18

v1: https://www.redhat.com/archives/libvir-list/2017-December/msg00543.html Changes since v1... * Added a patch to handle a NULL return with pool obj lock * Alter the IsDuplicate API to use a bool parameter * Use the IsDuplicate API from the test driver. This would have generated the correct error message about a duplicate UUID instead of the Duplicate key that was generated. Ran virt-manager tests prior to Cole's fixes and of course after. John Ferlan (3): conf: Need to unlock pools on object allocation failure conf: Use bool for @check_active parameter test: Use virStoragePoolObjIsDuplicate for storage define/create src/conf/virstorageobj.c | 4 ++-- src/conf/virstorageobj.h | 2 +- src/storage/storage_driver.c | 4 ++-- src/test/test_driver.c | 11 ++++------- 4 files changed, 9 insertions(+), 12 deletions(-) -- 2.13.6

2 6

[libvirt] [PATCH] rpc: remove redundant logic
by Pavel Hrdina 04 Jan '18

04 Jan '18

Introduced by commit <0eaa59dce1>. That comparison already returns true or false. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- Pushed under trivial rule. src/rpc/virnetserverclient.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rpc/virnetserverclient.c b/src/rpc/virnetserverclient.c index cae5375359..1f335d3b1e 100644 --- a/src/rpc/virnetserverclient.c +++ b/src/rpc/virnetserverclient.c @@ -1090,7 +1090,7 @@ virNetServerClientClose(virNetServerClientPtr client) bool virNetServerClientIsClosedLocked(virNetServerClientPtr client) { - return client->sock == NULL ? true : false; + return client->sock == NULL; } -- 2.14.3

1 0

[libvirt] [PATCH 0/4] Resolve issue with duplicated SCSI hostdev addresses
by John Ferlan 04 Jan '18

04 Jan '18

Details in the various patches. John Ferlan (4): qemu: Tolerate storage source private data being NULL for hotplug SCSI hostdev qemu: Use same model when adding hostdev SCSI controller conf: Use existing SCSI hostdev model to create new conf: Fix generating addresses for SCSI hostdev src/conf/domain_conf.c | 44 ++++++++++++---------- src/qemu/qemu_hotplug.c | 19 +++++++--- .../hostdev-scsi-autogen-address.xml | 2 +- 3 files changed, 39 insertions(+), 26 deletions(-) -- 2.13.6

3 22

[libvirt] Qemu Commandline options are ignored during migration
by Tim Foerster 04 Jan '18

04 Jan '18

Heyho Guys, The domain defintion xml allows to extend the qemu command. For example: ``` <qemu:commandline> <qemu:arg value='-cpu'/> <qemu:arg value='SandyBridge,-kvm_steal_time'/> </qemu:commandline> ``` The options are correctly passed on startup, but the migration will ignore them. The desination xml is dumped with the flags 1|2|8. (secure, inactive and migrateable) `secure` flag is required to keep vnc passwords, and inactive to keep the metadata section. But i also mentioned that qemu:commandline section needs inactive flag too. -- Tim Foerster

1 0

[libvirt] [PATCH] vhost-user: no need to remove chardev when remove netdev
by linzhecheng 04 Jan '18

04 Jan '18

We use virsh detach-device to hot-unplug a vhost-user net card, and libvirtd will issue qmp_netdev_del, qmp_chardev_remove and qmp_netdev_del. However, in qmp_netdev_del, qemu will remove the chardev when cleanup the netdev. So libvirtd has no need to issue qmp_chardev_remove to qemu any more. Change-Id: I4883c17bbb8dce088406f6a8a9ca4e02612d21f4 diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 7de04c85a..c4787dd60 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -4014,7 +4014,6 @@ qemuDomainRemoveNetDevice(virQEMUDriverPtr driver, qemuDomainObjPrivatePtr priv = vm->privateData; virObjectEventPtr event; char *hostnet_name = NULL; - char *charDevAlias = NULL; size_t i; int ret = -1; int actualType = virDomainNetGetActualType(net); @@ -4029,8 +4028,7 @@ qemuDomainRemoveNetDevice(virQEMUDriverPtr driver, VIR_DEBUG("Removing network interface %s from domain %p %s", net->info.alias, vm, vm->def->name); - if (virAsprintf(&hostnet_name, "host%s", net->info.alias) < 0 || - !(charDevAlias = qemuAliasChardevFromDevAlias(net->info.alias))) + if (virAsprintf(&hostnet_name, "host%s", net->info.alias) < 0) goto cleanup; @@ -4057,15 +4055,6 @@ qemuDomainRemoveNetDevice(virQEMUDriverPtr driver, } } - if (actualType == VIR_DOMAIN_NET_TYPE_VHOSTUSER) { - /* vhostuser has a chardev too */ - if (qemuMonitorDetachCharDev(priv->mon, charDevAlias) < 0) { - /* well, this is a messy situation. Guest visible PCI device has - * been removed, netdev too but chardev not. The best seems to be - * to just ignore the error and carry on. - */ - } - } if (qemuDomainObjExitMonitor(driver, vm) < 0) goto cleanup; @@ -4108,7 +4097,6 @@ qemuDomainRemoveNetDevice(virQEMUDriverPtr driver, cleanup: virObjectUnref(cfg); - VIR_FREE(charDevAlias); VIR_FREE(hostnet_name); return ret; } -- 2.12.2.windows.2

2 1

[libvirt] [PATCH 0/2] Introducing testDomainRename().
by Julio Faracco 04 Jan '18

04 Jan '18

This commit introduces the testDomainRename() for test driver. It includes: - testDomainRename() implementation. - Testcase script to test 'domrename' command. Julio Faracco (2): test: Implementing testDomainRename(). tests: Adding test case for virsh 'domrename' command. src/test/test_driver.c | 96 ++++++++++++++++++++++++++++++++++++++++++++++++++ tests/Makefile.am | 1 + tests/virsh-rename | 43 ++++++++++++++++++++++ 3 files changed, 140 insertions(+) create mode 100755 tests/virsh-rename -- 2.7.4

2 3