- Devel - libvirt List Archives

[libvirt] [PATCH] appdev-guide/Connections: Remove duplicated entries
by Marcos Paulo de Souza 25 Jun '18

25 Jun '18

Both /hosts/cpu/arch and /hosts/cpu/features appear twice in the documentation. Signed-off-by: Marcos Paulo de Souza <marcos.souza.org(a)gmail.com> --- This is my first submission to libvirt, so let me know if I forgot something. en-US/Connections.xml | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/en-US/Connections.xml b/en-US/Connections.xml index 96fe011..d7b6af6 100644 --- a/en-US/Connections.xml +++ b/en-US/Connections.xml @@ -963,17 +963,6 @@ int main(int argc, char *argv[]) CPU architecture. As of this writing, all libvirt drivers initialize this from the output of uname(2). </para> - <para> - <literal>/host/cpu/features</literal> is an optional sub-document that describes additional cpu - features present on the host. As of this writing, it is only used by the - xen driver to report on the presence or lack of the svm or vmx flag, and to - report on the presence or lack of the pae flag. - </para> - <para> - <literal>/host/cpu/arch</literal> is a required XML node that describes the underlying - host CPU architecture. As of this writing, all libvirt drivers - initialize this from the output of uname(2). - </para> <para> <literal>/host/cpu/model</literal> is an optional element that describes the CPU model that the host CPUs most closely resemble. The list of CPU models -- 2.17.1

2 4

[libvirt] [PATCH] docs: schema: Add missing <interleave> to devices
by Han Han 25 Jun '18

25 Jun '18

For input,hub,redirdev devices, their sub-elements should be interleaved. input device: interleave for <driver>, <alias>, <address> hub device: interleave for <alias>, <address> redirdev device: interleave for <source>, <alias>, <address>, <boot> Signed-off-by: Han Han <hhan(a)redhat.com> --- docs/schemas/domaincommon.rng | 60 +++++++++++++++++++---------------- 1 file changed, 33 insertions(+), 27 deletions(-) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 4a454dddb4..d262eb2b1b 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -4270,11 +4270,19 @@ <define name="input"> <element name="input"> - <optional> - <element name="driver"> - <ref name="virtioOptions"/> - </element> - </optional> + <interleave> + <optional> + <element name="driver"> + <ref name="virtioOptions"/> + </element> + </optional> + <optional> + <ref name="alias"/> + </optional> + <optional> + <ref name="address"/> + </optional> + </interleave> <choice> <group> <attribute name="type"> @@ -4309,12 +4317,6 @@ </element> </group> </choice> - <optional> - <ref name="alias"/> - </optional> - <optional> - <ref name="address"/> - </optional> </element> </define> <define name="hub"> @@ -4322,12 +4324,14 @@ <attribute name="type"> <value>usb</value> </attribute> - <optional> - <ref name="alias"/> - </optional> - <optional> - <ref name="address"/> - </optional> + <interleave> + <optional> + <ref name="alias"/> + </optional> + <optional> + <ref name="address"/> + </optional> + </interleave> </element> </define> <define name="redirdev"> @@ -4338,16 +4342,18 @@ <attribute name="type"> <ref name="qemucdevSrcTypeChoice"/> </attribute> - <ref name="qemucdevSrcDef"/> - <optional> - <ref name="alias"/> - </optional> - <optional> - <ref name="address"/> - </optional> - <optional> - <ref name="deviceBoot"/> - </optional> + <interleave> + <ref name="qemucdevSrcDef"/> + <optional> + <ref name="alias"/> + </optional> + <optional> + <ref name="address"/> + </optional> + <optional> + <ref name="deviceBoot"/> + </optional> + </interleave> </element> </define> <define name="redirfilter"> -- 2.17.1

2 1

[libvirt] [PATCH] qemu: Fix memory leak in qemuDomainBlockJobSetSpeed()
by w00251574 25 Jun '18

25 Jun '18

Subject: [PATCH] qemu: Fix memory leak in qemuDomainBlockJobSetSpeed() fix 'device' leak in qemuDomainBlockJobSetSpeed Signed-off-by: Jie Wang <wangjie88.huawei.com> --- src/qemu/qemu_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 921aafcd79..b45c26eb3b 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -17395,6 +17395,7 @@ qemuDomainBlockJobSetSpeed(virDomainPtr dom, qemuDomainObjEndJob(driver, vm); cleanup: + VIR_FREE(device); virDomainObjEndAPI(&vm); return ret; -- 2.15.0.windows.1

2 1

[libvirt] [PATCH] spec: Move SASL configuration file from -libs to -daemon
by Andrea Bolognani 25 Jun '18

25 Jun '18

SASL authentication is configured server-side, so the sample configuration file should be shipped along with the daemon rather than with the libraries. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- libvirt.spec.in | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index ace05820aa..54549cc737 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1773,6 +1773,7 @@ exit 0 %config(noreplace) %{_sysconfdir}/libvirt/libvirtd.conf %config(noreplace) %{_sysconfdir}/libvirt/virtlogd.conf %config(noreplace) %{_sysconfdir}/libvirt/virtlockd.conf +%config(noreplace) %{_sysconfdir}/sasl2/libvirt.conf %config(noreplace) %{_prefix}/lib/sysctl.d/60-libvirtd.conf %config(noreplace) %{_sysconfdir}/logrotate.d/libvirtd @@ -2060,8 +2061,6 @@ exit 0 %{_datadir}/libvirt/test-screenshot.png -%config(noreplace) %{_sysconfdir}/sasl2/libvirt.conf - %files admin %{_mandir}/man1/virt-admin.1* %{_bindir}/virt-admin -- 2.17.1

2 1

[libvirt] [PATCH v1 00/21] use GCC's cleanup attribute in src/util
by Sukrit Bhatnagar 25 Jun '18

25 Jun '18

This series of patches introduces a new set of macros which help in using GCC's __attribute__((cleanup)) in the code. Then the patches modify a few files in src/util to use VIR_AUTOFREE and VIR_AUTOPTR for automatic freeing of memory and get rid of some VIR_FREE macro invocations and *Free function calls. Sukrit Bhatnagar (21): add macros for implementing automatic cleanup functionality util: arptable: use VIR_AUTOFREE instead of VIR_FREE for scalar types util: iohelper: use VIR_AUTOFREE instead of VIR_FREE for scalar types util: audit: use VIR_AUTOFREE instead of VIR_FREE for scalar types util: fcp: use VIR_AUTOFREE instead of VIR_FREE for scalar types util: eventpoll: use VIR_AUTOFREE instead of VIR_FREE for scalar types util: filecache: use VIR_AUTOFREE instead of VIR_FREE for scalar types util: authconfig: define cleanup function using VIR_DEFINE_AUTOPTR_FUNC util: authconfig: remove redundant include directive util: authconfig: use VIR_AUTOFREE instead of VIR_FREE for scalar types util: auth: remove redundant include directive util: auth: use VIR_AUTOFREE instead of VIR_FREE for scalar types util: auth: use VIR_AUTOPTR for aggregate types util: json: define cleanup function using VIR_DEFINE_AUTOPTR_FUNC util: json: remove redundant include directive util: json: use VIR_AUTOFREE instead of VIR_FREE for scalar types util: json: use VIR_AUTOPTR for aggregate types util: identity: use VIR_AUTOFREE instead of VIR_FREE for scalar types util: bitmap: define cleanup function using VIR_DEFINE_AUTOPTR_FUNC util: bitmap: remove redundant include directive util: bitmap: use VIR_AUTOPTR for aggregate types src/util/iohelper.c | 4 +-- src/util/viralloc.h | 68 ++++++++++++++++++++++++++++++++++++++++++++++++ src/util/virarptable.c | 14 +++------- src/util/viraudit.c | 3 +-- src/util/virauth.c | 61 +++++++++++++------------------------------ src/util/virauthconfig.c | 35 +++++++++---------------- src/util/virauthconfig.h | 3 +++ src/util/virbitmap.c | 8 ++---- src/util/virbitmap.h | 3 +++ src/util/vireventpoll.c | 7 ++--- src/util/virfcp.c | 20 +++++--------- src/util/virfilecache.c | 35 ++++++++----------------- src/util/viridentity.c | 54 ++++++++++++++++---------------------- src/util/virjson.c | 45 +++++++++----------------------- src/util/virjson.h | 3 +++ 15 files changed, 168 insertions(+), 195 deletions(-) -- 1.8.3.1

2 22

[libvirt] [dbus PATCH] connect: fix deregistering of NodeDevice events
by Anya Harter 25 Jun '18

25 Jun '18

Signed-off-by: Anya Harter <aharter(a)redhat.com> --- src/connect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/connect.c b/src/connect.c index 09e5628..32dda14 100644 --- a/src/connect.c +++ b/src/connect.c @@ -68,7 +68,7 @@ virtDBusConnectClose(virtDBusConnect *connect, for (gint i = 0; i < VIR_NODE_DEVICE_EVENT_ID_LAST; i++) { if (connect->nodeDevCallbackIds[i] >= 0) { if (deregisterEvents) { - virConnectNetworkEventDeregisterAny(connect->connection, + virConnectNodeDeviceEventDeregisterAny(connect->connection, connect->nodeDevCallbackIds[i]); } connect->nodeDevCallbackIds[i] = -1; -- 2.17.1

2 1

[libvirt] [PATCH] qemu: format serial, geometry and error policy on frontend disk device
by Daniel P. Berrangé 25 Jun '18

25 Jun '18

Currently we format the serial, geometry and error policy on the -drive backend argument. QEMU added the ability to set serial and geometry on the frontend in the 1.2 release, and ability to set error policy in the 2.7 release. usb-storage is an oddity, however, as it lacks error policy support right now. Setting any of these on -drive has been deprecated and support for this will be removed very soon. Note that some disk buses (sd) still don't support -device. Although QEMU allowed these properties to be set on -drive for if=sd, they have been ignored so we don't loose anything by removing this. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 31 ++++++++++++++++--- .../caps_2.10.0.aarch64.xml | 1 + .../caps_2.10.0.ppc64.xml | 1 + .../caps_2.10.0.s390x.xml | 1 + .../caps_2.10.0.x86_64.xml | 1 + .../caps_2.11.0.s390x.xml | 1 + .../caps_2.12.0.aarch64.xml | 1 + .../caps_2.12.0.ppc64.xml | 1 + .../caps_2.12.0.s390x.xml | 1 + .../caps_2.12.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_2.7.0.s390x.xml | 1 + .../caps_2.7.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_2.8.0.s390x.xml | 1 + .../caps_2.8.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_2.9.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_2.9.0.s390x.xml | 1 + .../caps_2.9.0.x86_64.xml | 1 + .../disk-drive-network-tlsx509.args | 12 +++---- .../disk-drive-network-vxhs.args | 4 +-- tests/qemuxml2argvdata/disk-drive-shared.args | 5 +-- tests/qemuxml2argvdata/disk-geometry.args | 6 ++-- tests/qemuxml2argvdata/disk-ide-wwn.args | 5 ++- .../qemuxml2argvdata/disk-scsi-disk-wwn.args | 4 +-- tests/qemuxml2argvdata/disk-serial.args | 10 +++--- tests/qemuxml2argvdata/disk-serial.xml | 1 - tests/qemuxml2argvtest.c | 1 + tests/qemuxml2xmloutdata/disk-serial.xml | 1 - 29 files changed, 69 insertions(+), 30 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 419208ad5c..b9a6c2d612 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -500,6 +500,7 @@ VIR_ENUM_IMPL(virQEMUCaps, QEMU_CAPS_LAST, /* 310 */ "sev-guest", + "disk-error", ); @@ -1162,6 +1163,7 @@ static struct virQEMUCapsStringFlags virQEMUCapsDevicePropsVirtioBlk[] = { { "iommu_platform", QEMU_CAPS_VIRTIO_PCI_IOMMU_PLATFORM }, { "ats", QEMU_CAPS_VIRTIO_PCI_ATS }, { "write-cache", QEMU_CAPS_DISK_WRITE_CACHE }, + { "werror", QEMU_CAPS_DISK_ERROR }, }; static struct virQEMUCapsStringFlags virQEMUCapsDevicePropsVirtioNet[] = { diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h index 3519a194e9..1245fb46cf 100644 --- a/src/qemu/qemu_capabilities.h +++ b/src/qemu/qemu_capabilities.h @@ -484,6 +484,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for syntax-check */ /* 310 */ QEMU_CAPS_SEV_GUEST, /* -object sev-guest,... */ + QEMU_CAPS_DISK_ERROR, /* -device $DISK,werror=,rerror=X */ QEMU_CAPS_LAST /* this must always be the last item */ } virQEMUCapsFlags; diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 446df3e1d8..e97158fe64 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -1621,8 +1621,6 @@ qemuBuildDiskFrontendAttributes(virDomainDiskDefPtr disk, virBufferAddLit(buf, ",serial="); virBufferEscape(buf, '\\', " ", "%s", disk->serial); } - - qemuBuildDiskFrontendAttributeErrorPolicy(disk, buf); } @@ -1662,11 +1660,29 @@ qemuBuildDriveStr(virDomainDiskDefPtr disk, virBufferAsprintf(&opt, "if=%s", virDomainDiskQEMUBusTypeToString(disk->bus)); virBufferAsprintf(&opt, ",index=%d", idx); + + if (disk->serial) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Serial property not supported for drive bus '%s'"), + virDomainDiskBusTypeToString(disk->bus)); + goto error; + } + if (disk->geometry.cylinders > 0 && + disk->geometry.heads > 0 && + disk->geometry.sectors > 0) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Geometry not supported for drive bus '%s'"), + virDomainDiskBusTypeToString(disk->bus)); + goto error; + } } - /* Format attributes for the drive itself (not the storage backing it) which - * we've formatted historically with -drive */ - qemuBuildDiskFrontendAttributes(disk, &opt); + /* werror/rerror are really frontend attributes, but older + * qemu requires them on -drive instead of -device */ + if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_DISK_ERROR) || + disk->bus == VIR_DOMAIN_DISK_BUS_USB) + qemuBuildDiskFrontendAttributeErrorPolicy(disk, &opt); + /* While this is a frontend attribute, it only makes sense to be used when * legacy -drive is used. In modern qemu the 'ide-cd' or 'scsi-cd' are used. @@ -2125,6 +2141,11 @@ qemuBuildDriveDevStr(const virDomainDef *def, if (qemuBuildDriveDevCacheStr(disk, &opt, qemuCaps) < 0) goto error; + qemuBuildDiskFrontendAttributes(disk, &opt); + if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DISK_ERROR) && + disk->bus != VIR_DOMAIN_DISK_BUS_USB) + qemuBuildDiskFrontendAttributeErrorPolicy(disk, &opt); + if (virBufferCheckError(&opt) < 0) goto error; diff --git a/tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml b/tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml index 169641063c..35893bdac4 100644 --- a/tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml +++ b/tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml @@ -159,6 +159,7 @@ <flag name='hda-output'/> <flag name='blockdev-del'/> <flag name='vhost-vsock'/> + <flag name='disk-error'/> <version>2010000</version> <kvmVersion>0</kvmVersion> <microcodeVersion>307647</microcodeVersion> diff --git a/tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml b/tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml index 92c095abd2..0c7249a24b 100644 --- a/tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml +++ b/tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml @@ -158,6 +158,7 @@ <flag name='hda-output'/> <flag name='blockdev-del'/> <flag name='vhost-vsock'/> + <flag name='disk-error'/> <version>2010000</version> <kvmVersion>0</kvmVersion> <microcodeVersion>386992</microcodeVersion> diff --git a/tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml index 5e22e21224..7576c59cb0 100644 --- a/tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml +++ b/tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml @@ -119,6 +119,7 @@ <flag name='sdl-gl'/> <flag name='blockdev-del'/> <flag name='vhost-vsock'/> + <flag name='disk-error'/> <version>2010000</version> <kvmVersion>0</kvmVersion> <microcodeVersion>307899</microcodeVersion> diff --git a/tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml index 10b066bff1..2cc10e2192 100644 --- a/tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml @@ -203,6 +203,7 @@ <flag name='vmgenid'/> <flag name='vhost-vsock'/> <flag name='mch'/> + <flag name='disk-error'/> <version>2010000</version> <kvmVersion>0</kvmVersion> <microcodeVersion>367995</microcodeVersion> diff --git a/tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml index 6ca2e57ef8..58ec9f4e02 100644 --- a/tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml +++ b/tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml @@ -126,6 +126,7 @@ <flag name='blockdev-del'/> <flag name='vhost-vsock'/> <flag name='tpm-emulator'/> + <flag name='disk-error'/> <version>2011000</version> <kvmVersion>0</kvmVersion> <microcodeVersion>346751</microcodeVersion> diff --git a/tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml b/tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml index 5ed0290397..3073ea10f5 100644 --- a/tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml +++ b/tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml @@ -169,6 +169,7 @@ <flag name='vhost-vsock'/> <flag name='chardev-fd-pass'/> <flag name='tpm-emulator'/> + <flag name='disk-error'/> <version>2011090</version> <kvmVersion>0</kvmVersion> <microcodeVersion>347313</microcodeVersion> diff --git a/tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml b/tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml index c61029e479..acd6a8d8c4 100644 --- a/tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml +++ b/tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml @@ -166,6 +166,7 @@ <flag name='vhost-vsock'/> <flag name='chardev-fd-pass'/> <flag name='tpm-emulator'/> + <flag name='disk-error'/> <version>2011090</version> <kvmVersion>0</kvmVersion> <microcodeVersion>424244</microcodeVersion> diff --git a/tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml index 6fac6d6906..7aa7e8d889 100644 --- a/tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml +++ b/tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml @@ -133,6 +133,7 @@ <flag name='vhost-vsock'/> <flag name='chardev-fd-pass'/> <flag name='tpm-emulator'/> + <flag name='disk-error'/> <version>2012000</version> <kvmVersion>0</kvmVersion> <microcodeVersion>375762</microcodeVersion> diff --git a/tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml index 2167f06976..92871de23f 100644 --- a/tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml @@ -211,6 +211,7 @@ <flag name='mch'/> <flag name='mch.extended-tseg-mbytes'/> <flag name='sev-guest'/> + <flag name='disk-error'/> <version>2011090</version> <kvmVersion>0</kvmVersion> <microcodeVersion>415959</microcodeVersion> diff --git a/tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml index 9ed25178f8..ce1752934c 100644 --- a/tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml +++ b/tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml @@ -107,6 +107,7 @@ <flag name='nbd-tls'/> <flag name='virtual-css-bridge'/> <flag name='sdl-gl'/> + <flag name='disk-error'/> <version>2007000</version> <kvmVersion>0</kvmVersion> <microcodeVersion>220792</microcodeVersion> diff --git a/tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml index 959a858349..3be3b383ec 100644 --- a/tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml @@ -180,6 +180,7 @@ <flag name='sdl-gl'/> <flag name='hda-output'/> <flag name='mch'/> + <flag name='disk-error'/> <version>2007000</version> <kvmVersion>0</kvmVersion> <microcodeVersion>244005</microcodeVersion> diff --git a/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml index 646239ff25..1cecf68b23 100644 --- a/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml +++ b/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml @@ -110,6 +110,7 @@ <flag name='virtual-css-bridge'/> <flag name='sdl-gl'/> <flag name='vhost-vsock'/> + <flag name='disk-error'/> <version>2007093</version> <kvmVersion>0</kvmVersion> <microcodeVersion>246206</microcodeVersion> diff --git a/tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml index 3af44f0904..6ed95782ae 100644 --- a/tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml @@ -183,6 +183,7 @@ <flag name='hda-output'/> <flag name='vhost-vsock'/> <flag name='mch'/> + <flag name='disk-error'/> <version>2008000</version> <kvmVersion>0</kvmVersion> <microcodeVersion>260660</microcodeVersion> diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml b/tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml index 70a5936439..1ee5079ee8 100644 --- a/tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml +++ b/tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml @@ -150,6 +150,7 @@ <flag name='hda-output'/> <flag name='blockdev-del'/> <flag name='vhost-vsock'/> + <flag name='disk-error'/> <version>2009000</version> <kvmVersion>0</kvmVersion> <microcodeVersion>350708</microcodeVersion> diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml index 09d68e1f18..a25f49f375 100644 --- a/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml +++ b/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml @@ -114,6 +114,7 @@ <flag name='sdl-gl'/> <flag name='blockdev-del'/> <flag name='vhost-vsock'/> + <flag name='disk-error'/> <version>2009000</version> <kvmVersion>0</kvmVersion> <microcodeVersion>269625</microcodeVersion> diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml index 31ce52c787..0627d42bf3 100644 --- a/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml @@ -198,6 +198,7 @@ <flag name='vmgenid'/> <flag name='vhost-vsock'/> <flag name='mch'/> + <flag name='disk-error'/> <version>2009000</version> <kvmVersion>0</kvmVersion> <microcodeVersion>343984</microcodeVersion> diff --git a/tests/qemuxml2argvdata/disk-drive-network-tlsx509.args b/tests/qemuxml2argvdata/disk-drive-network-tlsx509.args index e25f45742c..b5e73064c0 100644 --- a/tests/qemuxml2argvdata/disk-drive-network-tlsx509.args +++ b/tests/qemuxml2argvdata/disk-drive-network-tlsx509.args @@ -28,22 +28,22 @@ server,nowait \ -drive file.driver=vxhs,file.tls-creds=objvirtio-disk0_tls0,\ file.vdisk-id=eb90327c-8302-4725-9e1b-4e85ed4dc251,\ file.server.host=192.168.0.1,file.server.port=9999,format=raw,if=none,\ -id=drive-virtio-disk0,serial=eb90327c-8302-4725-9e1b-4e85ed4dc251,cache=none \ +id=drive-virtio-disk0,cache=none \ -device virtio-blk-pci,bus=pci.0,addr=0x4,drive=drive-virtio-disk0,\ -id=virtio-disk0 \ +id=virtio-disk0,serial=eb90327c-8302-4725-9e1b-4e85ed4dc251 \ -object tls-creds-x509,id=objvirtio-disk1_tls0,dir=/etc/pki/libvirt-vxhs/dummy,\ ,path,endpoint=client,verify-peer=yes \ -drive file.driver=vxhs,file.tls-creds=objvirtio-disk1_tls0,\ file.vdisk-id=eb90327c-8302-4725-9e1b-4e85ed4dc252,\ file.server.host=192.168.0.2,file.server.port=9999,format=raw,if=none,\ -id=drive-virtio-disk1,serial=eb90327c-8302-4725-9e1b-4e85ed4dc252,cache=none \ +id=drive-virtio-disk1,cache=none \ -device virtio-blk-pci,bus=pci.0,addr=0x5,drive=drive-virtio-disk1,\ -id=virtio-disk1 \ +id=virtio-disk1,serial=eb90327c-8302-4725-9e1b-4e85ed4dc252 \ -drive file.driver=vxhs,file.vdisk-id=eb90327c-8302-4725-9e1b-4e85ed4dc253,\ file.server.host=192.168.0.3,file.server.port=9999,format=raw,if=none,\ -id=drive-virtio-disk2,serial=eb90327c-8302-4725-9e1b-4e85ed4dc252,cache=none \ +id=drive-virtio-disk2,cache=none \ -device virtio-blk-pci,bus=pci.0,addr=0x6,drive=drive-virtio-disk2,\ -id=virtio-disk2 \ +id=virtio-disk2,serial=eb90327c-8302-4725-9e1b-4e85ed4dc252 \ -object tls-creds-x509,id=objvirtio-disk3_tls0,dir=/etc/pki/libvirt-nbd/dummy,,\ path,endpoint=client,verify-peer=yes \ -drive file.driver=nbd,file.server.type=inet,file.server.host=example.com,\ diff --git a/tests/qemuxml2argvdata/disk-drive-network-vxhs.args b/tests/qemuxml2argvdata/disk-drive-network-vxhs.args index c2a1d4681f..fad4dfd942 100644 --- a/tests/qemuxml2argvdata/disk-drive-network-vxhs.args +++ b/tests/qemuxml2argvdata/disk-drive-network-vxhs.args @@ -25,6 +25,6 @@ server,nowait \ -usb \ -drive file.driver=vxhs,file.vdisk-id=eb90327c-8302-4725-9e1b-4e85ed4dc251,\ file.server.host=192.168.0.1,file.server.port=9999,format=raw,if=none,\ -id=drive-virtio-disk0,serial=eb90327c-8302-4725-9e1b-4e85ed4dc251,cache=none \ +id=drive-virtio-disk0,cache=none \ -device virtio-blk-pci,bus=pci.0,addr=0x4,drive=drive-virtio-disk0,\ -id=virtio-disk0 +id=virtio-disk0,serial=eb90327c-8302-4725-9e1b-4e85ed4dc251 diff --git a/tests/qemuxml2argvdata/disk-drive-shared.args b/tests/qemuxml2argvdata/disk-drive-shared.args index 5306fdf750..032e86e291 100644 --- a/tests/qemuxml2argvdata/disk-drive-shared.args +++ b/tests/qemuxml2argvdata/disk-drive-shared.args @@ -23,8 +23,9 @@ server,nowait \ -boot c \ -usb \ -drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-ide0-0-0,\ -serial=XYZXYZXYZYXXYZYZYXYZY,cache=none \ --device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 \ +cache=none \ +-device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0,\ +serial=XYZXYZXYZYXXYZYZYXYZY \ -drive file=/dev/HostVG/QEMUGuest2,format=raw,if=none,id=drive-ide0-1-0,\ media=cdrom,readonly=on \ -device ide-drive,bus=ide.1,unit=0,drive=drive-ide0-1-0,id=ide0-1-0 \ diff --git a/tests/qemuxml2argvdata/disk-geometry.args b/tests/qemuxml2argvdata/disk-geometry.args index b173ab6407..db0c7fb561 100644 --- a/tests/qemuxml2argvdata/disk-geometry.args +++ b/tests/qemuxml2argvdata/disk-geometry.args @@ -22,7 +22,7 @@ server,nowait \ -no-acpi \ -boot c \ -usb \ --drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-ide0-0-0,\ -cyls=16383,heads=16,secs=63,trans=lba \ --device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 \ +-drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-ide0-0-0 \ +-device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0,cyls=16383,\ +heads=16,secs=63,trans=lba \ -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x3 diff --git a/tests/qemuxml2argvdata/disk-ide-wwn.args b/tests/qemuxml2argvdata/disk-ide-wwn.args index e6d2758ec3..a0e3f06b68 100644 --- a/tests/qemuxml2argvdata/disk-ide-wwn.args +++ b/tests/qemuxml2argvdata/disk-ide-wwn.args @@ -22,8 +22,7 @@ server,nowait \ -no-acpi \ -boot c \ -usb \ --drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-ide0-0-1,\ -serial=WD-WMAP9A966149 \ +-drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-ide0-0-1 \ -device ide-hd,bus=ide.0,unit=1,drive=drive-ide0-0-1,id=ide0-0-1,\ -wwn=0x5000c50015ea71ad \ +wwn=0x5000c50015ea71ad,serial=WD-WMAP9A966149 \ -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x3 diff --git a/tests/qemuxml2argvdata/disk-scsi-disk-wwn.args b/tests/qemuxml2argvdata/disk-scsi-disk-wwn.args index 29607e8927..6407fd002d 100644 --- a/tests/qemuxml2argvdata/disk-scsi-disk-wwn.args +++ b/tests/qemuxml2argvdata/disk-scsi-disk-wwn.args @@ -25,9 +25,9 @@ server,nowait \ -device lsi,id=scsi1,bus=pci.0,addr=0x4 \ -usb \ -drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-scsi0-0-1-0,\ -serial=WD-WMAP9A966149,readonly=on \ +readonly=on \ -device scsi-cd,bus=scsi0.0,channel=0,scsi-id=1,lun=0,drive=drive-scsi0-0-1-0,\ -id=scsi0-0-1-0,wwn=0x5000c50015ea71ac \ +id=scsi0-0-1-0,wwn=0x5000c50015ea71ac,serial=WD-WMAP9A966149 \ -drive file=/dev/HostVG/QEMUGuest2,format=raw,if=none,id=drive-scsi0-0-0-0 \ -device scsi-hd,bus=scsi0.0,channel=0,scsi-id=0,lun=0,drive=drive-scsi0-0-0-0,\ id=scsi0-0-0-0,wwn=0x5000c50015ea71ad \ diff --git a/tests/qemuxml2argvdata/disk-serial.args b/tests/qemuxml2argvdata/disk-serial.args index 88310b009f..5892f64c29 100644 --- a/tests/qemuxml2argvdata/disk-serial.args +++ b/tests/qemuxml2argvdata/disk-serial.args @@ -22,11 +22,11 @@ server,nowait \ -no-acpi \ -boot c \ -usb \ --drive 'file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-ide0-0-1,\ +-drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-ide0-0-1 \ +-device 'ide-drive,bus=ide.0,unit=1,drive=drive-ide0-0-1,id=ide0-0-1,\ serial=\ \ WD-WMAP9A966149' \ --device ide-drive,bus=ide.0,unit=1,drive=drive-ide0-0-1,id=ide0-0-1 \ --drive 'file=/dev/HostVG/AllSerialChars,format=raw,if=none,id=drive-ide0-0-2,\ +-drive file=/dev/HostVG/AllSerialChars,format=raw,if=none,id=drive-ide0-0-2 \ +-device 'ide-drive,bus=ide.0,unit=2,drive=drive-ide0-0-2,id=ide0-0-2,\ serial=abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_\ .+' \ --device ide-drive,bus=ide.0,unit=2,drive=drive-ide0-0-2,id=ide0-0-2 \ --drive file=/some/file,format=raw,if=sd,index=0,serial=sdserial \ +-drive file=/some/file,format=raw,if=sd,index=0 \ -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x3 diff --git a/tests/qemuxml2argvdata/disk-serial.xml b/tests/qemuxml2argvdata/disk-serial.xml index ea71f2c339..18e72bb4ba 100644 --- a/tests/qemuxml2argvdata/disk-serial.xml +++ b/tests/qemuxml2argvdata/disk-serial.xml @@ -29,7 +29,6 @@ <disk type='file' device='disk'> <source file='/some/file'/> <target dev='sda' bus='sd'/> - <serial>sdserial</serial> </disk> <controller type='usb' index='0'/> <controller type='ide' index='0'/> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 582a9de7bb..06b94be625 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1038,6 +1038,7 @@ mymain(void) DO_TEST("disk-drive-error-policy-stop", NONE); DO_TEST("disk-drive-error-policy-enospace", NONE); DO_TEST("disk-drive-error-policy-wreport-rignore", NONE); + DO_TEST("disk-drive-error-policy-front", QEMU_CAPS_DISK_ERROR); DO_TEST("disk-drive-cache-v2-wt", NONE); DO_TEST("disk-drive-cache-v2-wb", NONE); DO_TEST("disk-drive-cache-v2-none", NONE); diff --git a/tests/qemuxml2xmloutdata/disk-serial.xml b/tests/qemuxml2xmloutdata/disk-serial.xml index 9313c699b6..a803cd959c 100644 --- a/tests/qemuxml2xmloutdata/disk-serial.xml +++ b/tests/qemuxml2xmloutdata/disk-serial.xml @@ -32,7 +32,6 @@ <driver name='qemu' type='raw'/> <source file='/some/file'/> <target dev='sda' bus='sd'/> - <serial>sdserial</serial> </disk> <controller type='usb' index='0'> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x2'/> -- 2.17.1

2 3

[libvirt] [PATCH] formatdomain.html.in: Amend the 'random' RNG backend section
by Kashyap Chamarthy 25 Jun '18

25 Jun '18

Since libvirt 1.3.4, any RNG source is accepted for the 'random' backend. However, '/dev/urandom' is the _recommended_ source of entropy. Mention it so in the docs. Suggested-by: Daniel P. Berrangé <berrange(a)redhat.com> Signed-off-by: Kashyap Chamarthy <kchamart(a)redhat.com> --- docs/formatdomain.html.in | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 89672a0486..3dd6a59a01 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -7738,12 +7738,16 @@ qemu-kvm -net nic,model=? /dev/null <dt><code>random</code></dt> <dd> <p> - This backend type expects a non-blocking character device as - input. The file name is specified as contents of the - <code>backend</code> element. <span class='since'>Since 1.3.4</span> - any path is accepted. Before that /dev/random and /dev/hwrng were - the only accepted paths. When no file name is specified the hypervisor - default is used. For qemu, the default is /dev/random + This backend type expects a non-blocking character device + as input. The file name is specified as contents of the + <code>backend</code> element. <span class='since'>Since + 1.3.4</span> any path is accepted. Before that + <code>/dev/random</code> and <code>/dev/hwrng</code> were + the only accepted paths. When no file name is specified, + the hypervisor default is used. For QEMU, the default is + <code>/dev/random</code>. However, the recommended source + of entropy is <code>/dev/urandom</code> (as it doesn't + have the limitations of <code>/dev/random</code>). </p> </dd> <dt><code>egd</code></dt> -- 2.17.0

2 3

[libvirt] [PATCH 0/2] qemu: Improve error/debug messages if unable to acquire a job
by Michal Privoznik 25 Jun '18

25 Jun '18

*** BLURB HERE *** Michal Privoznik (2): qemuDomainObjBeginJobInternal: Log agent job too qemuDomainObjBeginJobInternal: Report agent job in error message src/qemu/qemu_domain.c | 42 +++++++++++++++++++++++++++--------------- 1 file changed, 27 insertions(+), 15 deletions(-) -- 2.16.4

3 5

[libvirt] [PATCH] qemu: ensure FDs passed to QEMU for chardevs have correct SELinux labels
by Daniel P. Berrangé 25 Jun '18

25 Jun '18

The UNIX socket FDs were we passing to QEMU inherited a label based on libvirtd's context. QEMU is thus denied ability to access the UNIX socket. We need to use the security manager to change our current context temporarily when creating the UNIX socket FD. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/qemu/qemu_command.c | 86 ++++++++++++++++++++++++++++------------- src/qemu/qemu_command.h | 1 + src/qemu/qemu_process.c | 2 + 3 files changed, 63 insertions(+), 26 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 1ffcb5b1ae..146f671663 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -4931,6 +4931,7 @@ qemuOpenChrChardevUNIXSocket(const virDomainChrSourceDef *dev) * host side of the character device */ static char * qemuBuildChrChardevStr(virLogManagerPtr logManager, + virSecurityManagerPtr secManager, virCommandPtr cmd, virQEMUDriverConfigPtr cfg, const virDomainDef *def, @@ -5065,7 +5066,13 @@ qemuBuildChrChardevStr(virLogManagerPtr logManager, case VIR_DOMAIN_CHR_TYPE_UNIX: if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_CHARDEV_FD_PASS)) { + if (qemuSecuritySetSocketLabel(secManager, (virDomainDefPtr)def) < 0) + goto cleanup; int fd = qemuOpenChrChardevUNIXSocket(dev); + if (qemuSecurityClearSocketLabel(secManager, (virDomainDefPtr)def) < 0) { + VIR_FORCE_CLOSE(fd); + goto cleanup; + } if (fd < 0) goto cleanup; @@ -5404,6 +5411,7 @@ qemuBuildHostdevCommandLine(virCommandPtr cmd, static int qemuBuildMonitorCommandLine(virLogManagerPtr logManager, + virSecurityManagerPtr secManager, virCommandPtr cmd, virQEMUDriverConfigPtr cfg, virDomainDefPtr def, @@ -5414,7 +5422,8 @@ qemuBuildMonitorCommandLine(virLogManagerPtr logManager, if (!priv->monConfig) return 0; - if (!(chrdev = qemuBuildChrChardevStr(logManager, cmd, cfg, def, + if (!(chrdev = qemuBuildChrChardevStr(logManager, secManager, + cmd, cfg, def, priv->monConfig, "monitor", priv->qemuCaps, true, priv->chardevStdioLogd))) @@ -5533,6 +5542,7 @@ qemuBuildSclpDevStr(virDomainChrDefPtr dev) static int qemuBuildRNGBackendChrdevStr(virLogManagerPtr logManager, + virSecurityManagerPtr secManager, virCommandPtr cmd, virQEMUDriverConfigPtr cfg, const virDomainDef *def, @@ -5550,7 +5560,8 @@ qemuBuildRNGBackendChrdevStr(virLogManagerPtr logManager, return 0; case VIR_DOMAIN_RNG_BACKEND_EGD: - if (!(*chr = qemuBuildChrChardevStr(logManager, cmd, cfg, def, + if (!(*chr = qemuBuildChrChardevStr(logManager, secManager, + cmd, cfg, def, rng->source.chardev, rng->info.alias, qemuCaps, true, chardevStdioLogd))) @@ -5680,6 +5691,7 @@ qemuBuildRNGDevStr(const virDomainDef *def, static int qemuBuildRNGCommandLine(virLogManagerPtr logManager, + virSecurityManagerPtr secManager, virCommandPtr cmd, virQEMUDriverConfigPtr cfg, const virDomainDef *def, @@ -5702,7 +5714,7 @@ qemuBuildRNGCommandLine(virLogManagerPtr logManager, } /* possibly add character device for backend */ - if (qemuBuildRNGBackendChrdevStr(logManager, cmd, cfg, def, + if (qemuBuildRNGBackendChrdevStr(logManager, secManager, cmd, cfg, def, rng, qemuCaps, &tmp, chardevStdioLogd) < 0) return -1; @@ -8135,6 +8147,7 @@ qemuBuildGraphicsCommandLine(virQEMUDriverConfigPtr cfg, static int qemuBuildVhostuserCommandLine(virQEMUDriverPtr driver, virLogManagerPtr logManager, + virSecurityManagerPtr secManager, virCommandPtr cmd, virDomainDefPtr def, virDomainNetDefPtr net, @@ -8157,7 +8170,8 @@ qemuBuildVhostuserCommandLine(virQEMUDriverPtr driver, switch ((virDomainChrType)net->data.vhostuser->type) { case VIR_DOMAIN_CHR_TYPE_UNIX: - if (!(chardev = qemuBuildChrChardevStr(logManager, cmd, cfg, def, + if (!(chardev = qemuBuildChrChardevStr(logManager, secManager, + cmd, cfg, def, net->data.vhostuser, net->info.alias, qemuCaps, false, chardevStdioLogd))) @@ -8225,6 +8239,7 @@ qemuBuildVhostuserCommandLine(virQEMUDriverPtr driver, static int qemuBuildInterfaceCommandLine(virQEMUDriverPtr driver, virLogManagerPtr logManager, + virSecurityManagerPtr secManager, virCommandPtr cmd, virDomainDefPtr def, virDomainNetDefPtr net, @@ -8356,7 +8371,7 @@ qemuBuildInterfaceCommandLine(virQEMUDriverPtr driver, break; case VIR_DOMAIN_NET_TYPE_VHOSTUSER: - ret = qemuBuildVhostuserCommandLine(driver, logManager, cmd, def, + ret = qemuBuildVhostuserCommandLine(driver, logManager, secManager, cmd, def, net, qemuCaps, bootindex, chardevStdioLogd); goto cleanup; @@ -8534,6 +8549,7 @@ qemuBuildInterfaceCommandLine(virQEMUDriverPtr driver, static int qemuBuildNetCommandLine(virQEMUDriverPtr driver, virLogManagerPtr logManager, + virSecurityManagerPtr secManager, virCommandPtr cmd, virDomainDefPtr def, virQEMUCapsPtr qemuCaps, @@ -8566,7 +8582,7 @@ qemuBuildNetCommandLine(virQEMUDriverPtr driver, for (i = 0; i < def->nnets; i++) { virDomainNetDefPtr net = def->nets[i]; - if (qemuBuildInterfaceCommandLine(driver, logManager, cmd, def, net, + if (qemuBuildInterfaceCommandLine(driver, logManager, secManager, cmd, def, net, qemuCaps, bootNet, vmop, standalone, nnicindexes, nicindexes, @@ -8629,6 +8645,7 @@ qemuBuildSmartcardFindCCIDController(const virDomainDef *def, static int qemuBuildSmartcardCommandLine(virLogManagerPtr logManager, + virSecurityManagerPtr secManager, virCommandPtr cmd, virQEMUDriverConfigPtr cfg, const virDomainDef *def, @@ -8702,7 +8719,8 @@ qemuBuildSmartcardCommandLine(virLogManagerPtr logManager, return -1; } - if (!(devstr = qemuBuildChrChardevStr(logManager, cmd, cfg, def, + if (!(devstr = qemuBuildChrChardevStr(logManager, secManager, + cmd, cfg, def, smartcard->data.passthru, smartcard->info.alias, qemuCaps, true, @@ -8862,6 +8880,7 @@ qemuBuildShmemBackendMemProps(virDomainShmemDefPtr shmem) static int qemuBuildShmemCommandLine(virLogManagerPtr logManager, + virSecurityManagerPtr secManager, virCommandPtr cmd, virQEMUDriverConfigPtr cfg, virDomainDefPtr def, @@ -8933,7 +8952,8 @@ qemuBuildShmemCommandLine(virLogManagerPtr logManager, VIR_FREE(devstr); if (shmem->server.enabled) { - devstr = qemuBuildChrChardevStr(logManager, cmd, cfg, def, + devstr = qemuBuildChrChardevStr(logManager, secManager, + cmd, cfg, def, &shmem->server.chr, shmem->info.alias, qemuCaps, true, chardevStdioLogd); @@ -9020,6 +9040,7 @@ qemuChrIsPlatformDevice(const virDomainDef *def, static int qemuBuildSerialCommandLine(virLogManagerPtr logManager, + virSecurityManagerPtr secManager, virCommandPtr cmd, virQEMUDriverConfigPtr cfg, const virDomainDef *def, @@ -9043,7 +9064,8 @@ qemuBuildSerialCommandLine(virLogManagerPtr logManager, if (serial->source->type == VIR_DOMAIN_CHR_TYPE_SPICEPORT && !havespice) continue; - if (!(devstr = qemuBuildChrChardevStr(logManager, cmd, cfg, def, + if (!(devstr = qemuBuildChrChardevStr(logManager, secManager, + cmd, cfg, def, serial->source, serial->info.alias, qemuCaps, true, @@ -9080,6 +9102,7 @@ qemuBuildSerialCommandLine(virLogManagerPtr logManager, static int qemuBuildParallelsCommandLine(virLogManagerPtr logManager, + virSecurityManagerPtr secManager, virCommandPtr cmd, virQEMUDriverConfigPtr cfg, const virDomainDef *def, @@ -9092,7 +9115,8 @@ qemuBuildParallelsCommandLine(virLogManagerPtr logManager, virDomainChrDefPtr parallel = def->parallels[i]; char *devstr; - if (!(devstr = qemuBuildChrChardevStr(logManager, cmd, cfg, def, + if (!(devstr = qemuBuildChrChardevStr(logManager, secManager, + cmd, cfg, def, parallel->source, parallel->info.alias, qemuCaps, true, @@ -9113,6 +9137,7 @@ qemuBuildParallelsCommandLine(virLogManagerPtr logManager, static int qemuBuildChannelsCommandLine(virLogManagerPtr logManager, + virSecurityManagerPtr secManager, virCommandPtr cmd, virQEMUDriverConfigPtr cfg, const virDomainDef *def, @@ -9127,7 +9152,8 @@ qemuBuildChannelsCommandLine(virLogManagerPtr logManager, switch (channel->targetType) { case VIR_DOMAIN_CHR_CHANNEL_TARGET_TYPE_GUESTFWD: - if (!(devstr = qemuBuildChrChardevStr(logManager, cmd, cfg, def, + if (!(devstr = qemuBuildChrChardevStr(logManager, secManager, + cmd, cfg, def, channel->source, channel->info.alias, qemuCaps, true, @@ -9144,7 +9170,8 @@ qemuBuildChannelsCommandLine(virLogManagerPtr logManager, break; case VIR_DOMAIN_CHR_CHANNEL_TARGET_TYPE_VIRTIO: - if (!(devstr = qemuBuildChrChardevStr(logManager, cmd, cfg, def, + if (!(devstr = qemuBuildChrChardevStr(logManager, secManager, + cmd, cfg, def, channel->source, channel->info.alias, qemuCaps, true, @@ -9166,6 +9193,7 @@ qemuBuildChannelsCommandLine(virLogManagerPtr logManager, static int qemuBuildConsoleCommandLine(virLogManagerPtr logManager, + virSecurityManagerPtr secManager, virCommandPtr cmd, virQEMUDriverConfigPtr cfg, const virDomainDef *def, @@ -9187,7 +9215,8 @@ qemuBuildConsoleCommandLine(virLogManagerPtr logManager, return -1; } - if (!(devstr = qemuBuildChrChardevStr(logManager, cmd, cfg, def, + if (!(devstr = qemuBuildChrChardevStr(logManager, secManager, + cmd, cfg, def, console->source, console->info.alias, qemuCaps, true, @@ -9208,7 +9237,8 @@ qemuBuildConsoleCommandLine(virLogManagerPtr logManager, return -1; } - if (!(devstr = qemuBuildChrChardevStr(logManager, cmd, cfg, def, + if (!(devstr = qemuBuildChrChardevStr(logManager, secManager, + cmd, cfg, def, console->source, console->info.alias, qemuCaps, true, @@ -9223,7 +9253,8 @@ qemuBuildConsoleCommandLine(virLogManagerPtr logManager, break; case VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_VIRTIO: - if (!(devstr = qemuBuildChrChardevStr(logManager, cmd, cfg, def, + if (!(devstr = qemuBuildChrChardevStr(logManager, secManager, + cmd, cfg, def, console->source, console->info.alias, qemuCaps, true, @@ -9342,6 +9373,7 @@ qemuBuildRedirdevDevStr(const virDomainDef *def, static int qemuBuildRedirdevCommandLine(virLogManagerPtr logManager, + virSecurityManagerPtr secManager, virCommandPtr cmd, virQEMUDriverConfigPtr cfg, const virDomainDef *def, @@ -9354,7 +9386,8 @@ qemuBuildRedirdevCommandLine(virLogManagerPtr logManager, virDomainRedirdevDefPtr redirdev = def->redirdevs[i]; char *devstr; - if (!(devstr = qemuBuildChrChardevStr(logManager, cmd, cfg, def, + if (!(devstr = qemuBuildChrChardevStr(logManager, secManager, + cmd, cfg, def, redirdev->source, redirdev->info.alias, qemuCaps, true, @@ -10065,6 +10098,7 @@ qemuBuildVsockCommandLine(virCommandPtr cmd, virCommandPtr qemuBuildCommandLine(virQEMUDriverPtr driver, virLogManagerPtr logManager, + virSecurityManagerPtr secManager, virDomainObjPtr vm, const char *migrateURI, virDomainSnapshotObjPtr snapshot, @@ -10181,7 +10215,7 @@ qemuBuildCommandLine(virQEMUDriverPtr driver, if (qemuBuildSgaCommandLine(cmd, def, qemuCaps) < 0) goto error; - if (qemuBuildMonitorCommandLine(logManager, cmd, cfg, def, priv) < 0) + if (qemuBuildMonitorCommandLine(logManager, secManager, cmd, cfg, def, priv) < 0) goto error; if (qemuBuildClockCommandLine(cmd, def, qemuCaps) < 0) @@ -10211,29 +10245,29 @@ qemuBuildCommandLine(virQEMUDriverPtr driver, if (qemuBuildFSDevCommandLine(cmd, def, qemuCaps) < 0) goto error; - if (qemuBuildNetCommandLine(driver, logManager, cmd, def, + if (qemuBuildNetCommandLine(driver, logManager, secManager, cmd, def, qemuCaps, vmop, standalone, nnicindexes, nicindexes, &bootHostdevNet, chardevStdioLogd) < 0) goto error; - if (qemuBuildSmartcardCommandLine(logManager, cmd, cfg, def, qemuCaps, + if (qemuBuildSmartcardCommandLine(logManager, secManager, cmd, cfg, def, qemuCaps, chardevStdioLogd) < 0) goto error; - if (qemuBuildSerialCommandLine(logManager, cmd, cfg, def, qemuCaps, + if (qemuBuildSerialCommandLine(logManager, secManager, cmd, cfg, def, qemuCaps, chardevStdioLogd) < 0) goto error; - if (qemuBuildParallelsCommandLine(logManager, cmd, cfg, def, qemuCaps, + if (qemuBuildParallelsCommandLine(logManager, secManager, cmd, cfg, def, qemuCaps, chardevStdioLogd) < 0) goto error; - if (qemuBuildChannelsCommandLine(logManager, cmd, cfg, def, qemuCaps, + if (qemuBuildChannelsCommandLine(logManager, secManager, cmd, cfg, def, qemuCaps, chardevStdioLogd) < 0) goto error; - if (qemuBuildConsoleCommandLine(logManager, cmd, cfg, def, qemuCaps, + if (qemuBuildConsoleCommandLine(logManager, secManager, cmd, cfg, def, qemuCaps, chardevStdioLogd) < 0) goto error; @@ -10258,7 +10292,7 @@ qemuBuildCommandLine(virQEMUDriverPtr driver, if (qemuBuildWatchdogCommandLine(cmd, def, qemuCaps) < 0) goto error; - if (qemuBuildRedirdevCommandLine(logManager, cmd, cfg, def, qemuCaps, + if (qemuBuildRedirdevCommandLine(logManager, secManager, cmd, cfg, def, qemuCaps, chardevStdioLogd) < 0) goto error; @@ -10271,7 +10305,7 @@ qemuBuildCommandLine(virQEMUDriverPtr driver, if (qemuBuildMemballoonCommandLine(cmd, def, qemuCaps) < 0) goto error; - if (qemuBuildRNGCommandLine(logManager, cmd, cfg, def, qemuCaps, + if (qemuBuildRNGCommandLine(logManager, secManager, cmd, cfg, def, qemuCaps, chardevStdioLogd) < 0) goto error; @@ -10306,7 +10340,7 @@ qemuBuildCommandLine(virQEMUDriverPtr driver, goto error; for (i = 0; i < def->nshmems; i++) { - if (qemuBuildShmemCommandLine(logManager, cmd, cfg, + if (qemuBuildShmemCommandLine(logManager, secManager, cmd, cfg, def, def->shmems[i], qemuCaps, chardevStdioLogd)) goto error; diff --git a/src/qemu/qemu_command.h b/src/qemu/qemu_command.h index c78282eb09..4f1b360130 100644 --- a/src/qemu/qemu_command.h +++ b/src/qemu/qemu_command.h @@ -46,6 +46,7 @@ VIR_ENUM_DECL(qemuVideo) virCommandPtr qemuBuildCommandLine(virQEMUDriverPtr driver, virLogManagerPtr logManager, + virSecurityManagerPtr secManager, virDomainObjPtr vm, const char *migrateURI, virDomainSnapshotObjPtr snapshot, diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 2967568f62..7e9ad01e61 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -6174,6 +6174,7 @@ qemuProcessLaunch(virConnectPtr conn, VIR_DEBUG("Building emulator command line"); if (!(cmd = qemuBuildCommandLine(driver, qemuDomainLogContextGetManager(logCtxt), + driver->securityManager, vm, incoming ? incoming->launchURI : NULL, snapshot, vmop, @@ -6642,6 +6643,7 @@ qemuProcessCreatePretendCmd(virQEMUDriverPtr driver, VIR_DEBUG("Building emulator command line"); cmd = qemuBuildCommandLine(driver, NULL, + driver->securityManager, vm, migrateURI, NULL, -- 2.17.1

2 1

[libvirt] [PATCH] docs: formatdomain: Note the caveats for CPU policy option "force"
by Kashyap Chamarthy 22 Jun '18

22 Jun '18

Eduardo Habkost has pointed out that the current documentation of libvirt's CPU feature policy "require" vs. "force" does not match QEMU's behaviour. Update the documentation by spelling out the QEMU version dependency and explain in which scenarios the usage of "policy = 'force'" is applicable or not. Signed-off-by: Kashyap Chamarthy <kchamart(a)redhat.com> --- Wordsmithing / corrections welcome. --- docs/formatdomain.html.in | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 6912762f28..4d6c3892ee 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -1566,8 +1566,17 @@ <dl> <dt><code>force</code></dt> - <dd>The virtual CPU will claim the feature is supported regardless - of it being supported by host CPU.</dd> + <dd>The virtual CPU will claim the feature is supported + regardless of it being supported by host CPU -- this is only + true for QEMU version older than 2.9.0. I.e. when using the + CPU mode 'host-model', libvirt identifies which CPU features + to use by looking at host CPUID. For that to take effect, it + is mandatory to use <code>force</code> to tell libvirt that a + said CPU feature must be used despite it not existing in the + host -- this applicable only for a very limited set of CPU + features, such as 'x2apic', virt-ssbd' (for AMD CPUs).</dd> + <dd>However, when using QEMU 2.9.0 and above, there should + never be any need to use <code>force</code>.</dd> <dt><code>require</code></dt> <dd>Guest creation will fail unless the feature is supported by the host CPU or the hypervisor is able to emulate it.</dd> -- 2.17.0

3 3

[libvirt] [PATCH v3 00/20] nwfilter: refactor the driver to make it independent of virt drivers
by Daniel P. Berrangé 22 Jun '18

22 Jun '18

v1: https://www.redhat.com/archives/libvir-list/2018-April/msg02616.html v2: https://www.redhat.com/archives/libvir-list/2018-May/msg01145.html Today the nwfilter driver is entangled with the virt drivers in both directions. At various times when rebuilding filters nwfilter will call out to the virt driver to iterate over running guest's NICs. This has caused very complicated lock ordering rules to be required. If we are to split the virt drivers out into separate daemons we need to get rid of this coupling since we don't want the separate daemons calling each other, as that risks deadlock if all of the RPC workers are busy. The obvious way to solve this is to have the nwfilter driver remember all the filters it has active, avoiding the need to iterate over running guests. Still todo - Document the new XML format Changed in v3: - Updated API version numbers - Use accessors for virNWFilterBindingObjPtr struct - Other fixes John mentioned Changed in v2: - The virNWFilterBindingPtr was renamed virNWFilterBindingDefPtr - New virNWFilterBindingObjPtr & virNWFilterBindingObjListPtr structs added to track the objects in the driver - New virNWFilterBindingPtr public API type was added - New public APIs for listing filter bindings, querying XML, and creating/deleting them - Convert the virt drivers to use the public API for creating and deleting bindings - Persistent active bindings out to disk so they're preserved across restarts - Added RNG schema and XML-2-XML test - New virsh commands for listing/querying XML/creating/deleting bindings Daniel P. Berrangé (20): conf: change virNWFilterBindingPtr to virNWFilterBindingDefPtr conf: add missing virxml.h include for nwfilter_params.h conf: move virNWFilterBindingDefPtr into its own files conf: add support for parsing/formatting virNWFilterBindingDefPtr schemas: add schema for nwfilter binding XML document nwfilter: export port binding concept in the public API access: add nwfilter binding object permissions remote: add support for nwfilter binding objects virsh: add nwfilter binding commands nwfilter: convert the gentech driver code to use virNWFilterBindingDefPtr nwfilter: convert IP address learning code to virNWFilterBindingDefPtr nwfilter: convert DHCP address snooping code to virNWFilterBindingDefPtr conf: report an error if nic needs filtering by no driver is present conf: introduce a virNWFilterBindingObjPtr struct conf: introduce a virNWFilterBindingObjListPtr struct nwfilter: keep track of active filter bindings nwfilter: remove virt driver callback layer for rebuilding filters nwfilter: wire up new APIs for listing and querying filter bindings nwfilter: wire up new APIs for creating and deleting nwfilter bindings nwfilter: convert virt drivers to use public API for nwfilter bindings docs/schemas/domaincommon.rng | 27 +- docs/schemas/nwfilter.rng | 29 +- docs/schemas/nwfilter_params.rng | 32 ++ docs/schemas/nwfilterbinding.rng | 49 ++ include/libvirt/libvirt-nwfilter.h | 39 ++ include/libvirt/virterror.h | 2 + src/access/viraccessdriver.h | 5 + src/access/viraccessdrivernop.c | 10 + src/access/viraccessdriverpolkit.c | 21 + src/access/viraccessdriverstack.c | 24 + src/access/viraccessmanager.c | 15 + src/access/viraccessmanager.h | 5 + src/access/viraccessperm.c | 7 +- src/access/viraccessperm.h | 38 ++ src/conf/Makefile.inc.am | 6 + src/conf/domain_nwfilter.c | 125 ++++- src/conf/domain_nwfilter.h | 13 - src/conf/nwfilter_conf.c | 188 +------ src/conf/nwfilter_conf.h | 68 +-- src/conf/nwfilter_params.h | 1 + src/conf/virnwfilterbindingdef.c | 280 ++++++++++ src/conf/virnwfilterbindingdef.h | 65 +++ src/conf/virnwfilterbindingobj.c | 299 +++++++++++ src/conf/virnwfilterbindingobj.h | 69 +++ src/conf/virnwfilterbindingobjlist.c | 487 ++++++++++++++++++ src/conf/virnwfilterbindingobjlist.h | 69 +++ src/conf/virnwfilterobj.c | 4 +- src/conf/virnwfilterobj.h | 4 + src/datatypes.c | 67 +++ src/datatypes.h | 31 ++ src/driver-nwfilter.h | 30 ++ src/libvirt-nwfilter.c | 305 +++++++++++ src/libvirt_private.syms | 45 +- src/libvirt_public.syms | 9 + src/lxc/lxc_driver.c | 28 - src/nwfilter/nwfilter_dhcpsnoop.c | 158 +++--- src/nwfilter/nwfilter_dhcpsnoop.h | 7 +- src/nwfilter/nwfilter_driver.c | 218 ++++++-- src/nwfilter/nwfilter_gentech_driver.c | 337 ++++++------ src/nwfilter/nwfilter_gentech_driver.h | 22 +- src/nwfilter/nwfilter_learnipaddr.c | 104 ++-- src/nwfilter/nwfilter_learnipaddr.h | 7 +- src/qemu/qemu_driver.c | 25 - src/remote/remote_daemon_dispatch.c | 15 + src/remote/remote_driver.c | 20 + src/remote/remote_protocol.x | 90 +++- src/remote_protocol-structs | 43 ++ src/rpc/gendispatch.pl | 15 +- src/uml/uml_driver.c | 29 -- src/util/virerror.c | 12 + tests/Makefile.am | 7 + .../filter-vars.xml | 11 + .../virnwfilterbindingxml2xmldata/simple.xml | 9 + tests/virnwfilterbindingxml2xmltest.c | 112 ++++ tests/virschematest.c | 1 + tools/virsh-completer.c | 45 ++ tools/virsh-completer.h | 4 + tools/virsh-nwfilter.c | 317 ++++++++++++ tools/virsh-nwfilter.h | 8 + 59 files changed, 3283 insertions(+), 829 deletions(-) create mode 100644 docs/schemas/nwfilter_params.rng create mode 100644 docs/schemas/nwfilterbinding.rng create mode 100644 src/conf/virnwfilterbindingdef.c create mode 100644 src/conf/virnwfilterbindingdef.h create mode 100644 src/conf/virnwfilterbindingobj.c create mode 100644 src/conf/virnwfilterbindingobj.h create mode 100644 src/conf/virnwfilterbindingobjlist.c create mode 100644 src/conf/virnwfilterbindingobjlist.h create mode 100644 tests/virnwfilterbindingxml2xmldata/filter-vars.xml create mode 100644 tests/virnwfilterbindingxml2xmldata/simple.xml create mode 100644 tests/virnwfilterbindingxml2xmltest.c -- 2.17.0

2 37

[libvirt] [PATCH] qemu: fix msg could be a wild pointer in qemuMonitorIOProcess()
by Weilun Zhu 22 Jun '18

22 Jun '18

As qemuMonitorJSONIOProcess will call qemuMonitorJSONIOProcessEvent which unlocks the monitor mutex, there is some extreme situation, eg qemu send message to monitor twice in a short time, where the local viriable 'msg' of qemuMonitorIOProcess could be a wild point: 1. qemuMonitorSend() assign mon->msg to parameter 'msg', which is alse a local variable of its caller qemuMonitorJSONCommandWithFd(), cause eventloop to send message to monitor, then wait condition. 2. qemu send message to monitor for the first time immediately. 3. qemuMonitorIOProcess() is called, then wake up the qemuMonitorSend() thread, but the qemuMonitorSend() thread stuck for a while as cpu pressure or some other reasons, which means the qemu monitor is still unlocked. 4. qemu send event message to monitor for the second time, such as RTC_CHANGE event 5. qemuMonitorIOProcess() is called again, the local viriable 'msg' is assigned to mon->msg. 6. qemuMonitorIOProcess() call qemuMonitorJSONIOProcess() to deal with the qemu event. 7. qemuMonitorJSONIOProcess() unlock the qemu monitor in the macro 'QEMU_MONITOR_CALLBACK', then qemuMonitorSend() thread get the mutex and free the mon->msg, assign mon->msg to NULL. Signed-off-by: Weilun Zhu <zhuweilun(a)huawei.com> --- src/qemu/qemu_monitor.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index d6771c1d52..6ed475ede0 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -466,7 +466,11 @@ qemuMonitorIOProcess(qemuMonitorPtr mon) #if DEBUG_IO VIR_DEBUG("Process done %d used %d", (int)mon->bufferOffset, len); #endif - if (msg && msg->finished) + + /* As the monitor mutex was unlocked in qemuMonitorJSONIOProcess() + * while dealing with qemu event, mon->msg could be changed which + * means the above 'msg' may be invalid, thus we use 'mon->msg' here */ + if (mon->msg && mon->msg->finished) virCondBroadcast(&mon->notify); return len; } -- 2.18.0.rc1

2 1

[libvirt] [PATCH] news: Document recent agent job change
by Michal Privoznik 22 Jun '18

22 Jun '18

Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- docs/news.xml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 08e5dcbda3..a3eea4eff6 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -71,6 +71,19 @@ Capabilities XML now provide information about host IOMMU support. </description> </change> + <change> + <summary> + qemu: Allow concurrent access to monitor and guest agent + </summary> + <description> + Historically libvirt prevented concurrent accesses to + the qemu monitor and the guest agent. Therefore two + independent calls (one querying the monitor and the + other querying guest agent) would serialize which hurts + performance. The code was reworked to allow two + independent calls run at the same time. + </description> + </change> </section> <section title="Bug fixes"> <change> -- 2.16.4

2 1

[libvirt] [PATCH] vmx: allow an odd number of vCPUs
by Pino Toscano 22 Jun '18

22 Jun '18

Most probably this was a limitation in older ESX versions, and it seems it does not exist anymore in more recent versions; see the following thread: https://www.redhat.com/archives/libvir-list/2018-May/msg02159.html https://www.redhat.com/archives/libvir-list/2018-June/msg00043.html Hence, allow an odd number (greater than 1) of vCPUs, since most probably older versions of ESXi will error out anyway. https://bugzilla.redhat.com/show_bug.cgi?id=1584091 Signed-off-by: Pino Toscano <ptoscano(a)redhat.com> --- src/vmx/vmx.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 35b4807d22..fe24b060d7 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -59,7 +59,7 @@ def->name = <value> <=> displayName = "<value>" def->mem.max_balloon = <value kilobyte> <=> memsize = "<value megabyte>" # must be a multiple of 4, defaults to 32 def->mem.cur_balloon = <value kilobyte> <=> sched.mem.max = "<value megabyte>" # defaults to "unlimited" -> def->mem.cur_balloon = def->mem.max_balloon def->mem.min_guarantee = <value kilobyte> <=> sched.mem.minsize = "<value megabyte>" # defaults to 0 -def->maxvcpus = <value> <=> numvcpus = "<value>" # must be 1 or a multiple of 2, defaults to 1 +def->maxvcpus = <value> <=> numvcpus = "<value>" # must be greater than 0, defaults to 1 def->cpumask = <uint list> <=> sched.cpu.affinity = "<uint list>" def->cputune.shares = <value> <=> sched.cpu.shares = "<value>" # with handling for special values # "high", "normal", "low" @@ -1452,10 +1452,10 @@ virVMXParseConfig(virVMXContext *ctx, if (virVMXGetConfigLong(conf, "numvcpus", &numvcpus, 1, true) < 0) goto cleanup; - if (numvcpus <= 0 || (numvcpus % 2 != 0 && numvcpus != 1)) { + if (numvcpus <= 0) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Expecting VMX entry 'numvcpus' to be an unsigned " - "integer (1 or a multiple of 2) but found %lld"), numvcpus); + "integer greater than 0 but found %lld"), numvcpus); goto cleanup; } @@ -3183,11 +3183,10 @@ virVMXFormatConfig(virVMXContext *ctx, virDomainXMLOptionPtr xmlopt, virDomainDe goto cleanup; } maxvcpus = virDomainDefGetVcpusMax(def); - if (maxvcpus == 0 || (maxvcpus % 2 != 0 && maxvcpus != 1)) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Expecting domain XML entry 'vcpu' to be 1 or a " - "multiple of 2 but found %d"), - maxvcpus); + if (maxvcpus == 0) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("Expecting domain XML entry 'vcpu' to be greater " + "than 0")); goto cleanup; } -- 2.17.1

2 2

[libvirt] [PATCH] virDomainSnapshotDefParse: Prefer VIR_STEAL_PTR
by Michal Privoznik 22 Jun '18

22 Jun '18

Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/conf/snapshot_conf.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c index 787c3d0feb..9c537ac7d1 100644 --- a/src/conf/snapshot_conf.c +++ b/src/conf/snapshot_conf.c @@ -331,8 +331,7 @@ virDomainSnapshotDefParse(xmlXPathContextPtr ctxt, "disk-only snapshot")); goto cleanup; } - def->file = memoryFile; - memoryFile = NULL; + VIR_STEAL_PTR(def->file, memoryFile); /* verify that memory path is absolute */ if (def->file && def->file[0] != '/') { @@ -372,7 +371,7 @@ virDomainSnapshotDefParse(xmlXPathContextPtr ctxt, if (!offline && virSaveCookieParse(ctxt, &def->cookie, saveCookie) < 0) goto cleanup; - ret = def; + VIR_STEAL_PTR(ret, def); cleanup: VIR_FREE(creation); @@ -380,8 +379,7 @@ virDomainSnapshotDefParse(xmlXPathContextPtr ctxt, VIR_FREE(nodes); VIR_FREE(memorySnapshot); VIR_FREE(memoryFile); - if (ret == NULL) - virDomainSnapshotDefFree(def); + virDomainSnapshotDefFree(def); return ret; } -- 2.16.4

2 1

[libvirt] [PATCH] qemu: Escape commas for qemuBuildDiskThrottling
by Anya Harter 21 Jun '18

21 Jun '18

Add comma escaping for disk->blkdeviotune.group_name. Signed-off-by: Anya Harter <aharter(a)redhat.com> --- src/qemu/qemu_command.c | 4 ++-- tests/qemuxml2argvdata/name-escape.args | 5 +++++ tests/qemuxml2argvdata/name-escape.xml | 13 +++++++++++++ tests/qemuxml2argvtest.c | 2 ++ 4 files changed, 22 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 20c6ac2a04..e05b106a5e 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -1554,8 +1554,8 @@ qemuBuildDiskThrottling(virDomainDiskDefPtr disk, IOTUNE_ADD(size_iops_sec, "iops-size"); if (disk->blkdeviotune.group_name) { - virBufferEscapeString(buf, ",throttling.group=%s", - disk->blkdeviotune.group_name); + virBufferAddLit(buf, ",throttling.group="); + virQEMUBuildBufferEscapeComma(buf, disk->blkdeviotune.group_name); } IOTUNE_ADD(total_bytes_sec_max_length, "bps-total-max-length"); diff --git a/tests/qemuxml2argvdata/name-escape.args b/tests/qemuxml2argvdata/name-escape.args index 72ed2e8410..aef7c238ca 100644 --- a/tests/qemuxml2argvdata/name-escape.args +++ b/tests/qemuxml2argvdata/name-escape.args @@ -24,6 +24,11 @@ bar=2/monitor.sock,server,nowait \ -boot c \ -device usb-ccid,id=ccid0,bus=usb.0,port=1 \ -usb \ +-drive file=/dev/HostVG/QEMUGuest1,format=qcow2,if=none,id=drive-ide0-0-0,\ +cache=none,throttling.bps-total=5000,throttling.iops-total=6000,\ +throttling.bps-total-max=10000,throttling.iops-total-max=11000,\ +throttling.group=libvirt_iotune_group1,,foo \ +-device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 \ -device ccid-card-emulated,backend=certificates,cert1=cert1,,foo,cert2=cert2,\ cert3=cert3,db=/etc/pki/nssdb,,foo,id=smartcard0,bus=ccid0.0 \ -chardev tty,id=charserial0,path=/dev/ttyS2,,foo \ diff --git a/tests/qemuxml2argvdata/name-escape.xml b/tests/qemuxml2argvdata/name-escape.xml index 0580de1813..70a1ce09d3 100644 --- a/tests/qemuxml2argvdata/name-escape.xml +++ b/tests/qemuxml2argvdata/name-escape.xml @@ -14,6 +14,19 @@ <on_crash>destroy</on_crash> <devices> <emulator>/usr/bin/qemu-system-i686</emulator> + <disk type='block' device='disk'> + <driver name='qemu' type='qcow2' cache='none'/> + <source dev='/dev/HostVG/QEMUGuest1'/> + <target dev='hda' bus='ide'/> + <iotune> + <total_bytes_sec>5000</total_bytes_sec> + <total_iops_sec>6000</total_iops_sec> + <total_bytes_sec_max>10000</total_bytes_sec_max> + <total_iops_sec_max>11000</total_iops_sec_max> + <group_name>libvirt_iotune_group1,foo</group_name> + </iotune> + <address type='drive' controller='0' bus='0' target='0' unit='0'/> + </disk> <graphics type='vnc'> <listen type='socket'/> </graphics> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index a9a493e308..582a9de7bb 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -2758,6 +2758,8 @@ mymain(void) DO_TEST("name-escape", QEMU_CAPS_NAME_DEBUG_THREADS, QEMU_CAPS_OBJECT_SECRET, + QEMU_CAPS_DRIVE_IOTUNE_MAX, + QEMU_CAPS_DRIVE_IOTUNE_GROUP, QEMU_CAPS_VNC, QEMU_CAPS_NAME_GUEST, QEMU_CAPS_DEVICE_CIRRUS_VGA, -- 2.17.1

2 1

[libvirt] [PATCH v3 0/4] cmdDomblkinfo: introduce --all to show all block devices info
by Chen Hanxiao 21 Jun '18

21 Jun '18

This series introduce --all to cmdDomblkinfo to show all block devices info in one cmd. Likes a combination of domblklist and domblkinfo. v3: check error code on network disk v2: add support --human for --all v1.1 fix a self test Chen Hanxiao (4): cmdDomblkinfo: introduce helper cmdDomblkinfoPrint cmdDomblkinfo: add --all to show all block devices info cmdDomblkinfoPrint: support printing "-" for invalid virDomainBlockInfo news: add cmdDomblkinfo --all option docs/news.xml | 10 +++ tools/virsh-domain-monitor.c | 160 ++++++++++++++++++++++++++++++----- tools/virsh.pod | 5 +- 3 files changed, 155 insertions(+), 20 deletions(-) -- 2.17.1

2 7

[libvirt] ANNOUNCE: libvirt-dbus 1.1.0 released
by Pavel Hrdina 21 Jun '18

21 Jun '18

I'm happy to announce the release of libvirt-dbus 1.1.0. libvirt-dbus wraps libvirt API to provide high-level object-oriented API better suited for dbus-based applications. You can download it here: https://libvirt.org/sources/dbus/libvirt-dbus-1.1.0.tar.gz * New features - Support for all relevant nwfilter APIs up to libvirt 3.0.0 - Support for all relevant storage volume APIs up to libvirt 3.0.0 - Support for all relevant node device APIs up to libvirt 3.0.0 * Bug fixes - Don't report error for GetAll on properties if some property is not accessible Thanks everybody who contributed! Pavel

1 0

[libvirt] [jenkins-ci PATCH 0/2] git changes to reflect new CI configuration
by Pavel Hrdina 21 Jun '18

21 Jun '18

Pavel Hrdina (2): jobs: Change git URL to github jobs: Switch to github webhook instead of polling jobs/autotools.yaml | 5 ++--- jobs/generic.yaml | 5 ++--- jobs/go.yaml | 5 ++--- jobs/perl-modulebuild.yaml | 5 ++--- jobs/python-distutils.yaml | 5 ++--- 5 files changed, 10 insertions(+), 15 deletions(-) -- 2.17.1

3 6

[libvirt] [dbus PATCH v2 0/5] tests: Some fixes and cleanups
by Andrea Bolognani 21 Jun '18

21 Jun '18

Changes from [v1]: * use the correct paths; * fix running libvirt-dbus from VPATH builds; * fix distcheck. [v1] https://www.redhat.com/archives/libvir-list/2018-June/msg01453.html Andrea Bolognani (5): tests: Include xmldata.py in EXTRA_DIST run: Fix VIRT_DBUS_INTERFACES_DIR run: Export abs_top_builddir tests: Drop fallback path for abs_top_builddir tests: Use AM_TESTS_ENVIRONMENT run.in | 6 ++---- tests/Makefile.am | 7 ++++--- tests/libvirttest.py | 2 +- 3 files changed, 7 insertions(+), 8 deletions(-) -- 2.17.1

2 6

[libvirt] [PATCH] cpu: add 'amd-ssbd' and 'amd-no-ssb' CPU features (CVE-2018-3639)
by Daniel P. Berrangé 21 Jun '18

21 Jun '18

AMD x86 CPUs have two separate ways to mitigate the Speculative Store Bypass hardware flaw. In current processors only non-architectural MSRs are available, and so hypervisors must expose a virtualized MSR and CPU flag "virt-ssbd" (CPUID Function 8000_0008, EBX[25]=1). In future processors AMD will provide an architectural MSR, indicated by existance of the CPUID Function 8000_0008, EBX[24]=1, to which QEMU has given the name "amd-ssbd". The "amd-ssbd" flag should be used in preference to "virt-ssbd", if it is available, since it provides improved performance. For virtual machine configuration, both should be exposed when available, to allow for maximal guest OS compatibility as not all guests yet support both. If future processes are not vulnerable to the flaw, this will be indicated by the existance of CPUID Function 8000_0008, EBX[26]=1, to which QEMU has given the name "amd-no-ssb". See also 124441_AMD64_SpeculativeStoreBypassDisable_Whitepaper_final.pdf from: https://bugzilla.kernel.org/show_bug.cgi?id=199889 Note that neither amd-ssbd or amd-no-ssb will be reported by the kernel in /proc/cpuinfo. It knows about these CPUID bits and does the right thing, but doesn't report their existance as distinct flags in /proc/cpuinfo. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/cpu/cpu_map.xml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml index 96daa0f9af..9af190a579 100644 --- a/src/cpu/cpu_map.xml +++ b/src/cpu/cpu_map.xml @@ -433,9 +433,15 @@ <feature name='ibpb'> <cpuid eax_in='0x80000008' ebx='0x00001000'/> </feature> + <feature name='amd-ssbd'> + <cpuid eax_in='0x80000008' ebx='0x01000000'/> + </feature> <feature name='virt-ssbd'> <cpuid eax_in='0x80000008' ebx='0x02000000'/> </feature> + <feature name='amd-no-ssb'> + <cpuid eax_in='0x80000008' ebx='0x04000000'/> + </feature>  <model name='486'> -- 2.17.0

3 4

[libvirt] [PATCH 0/1] *** SUBJECT HERE ***
by Han Han 21 Jun '18

21 Jun '18

*** BLURB HERE *** Han Han (1): docs: schema: Add missing <interleave> to devices docs/schemas/domaincommon.rng | 60 +++++++++++++++++++---------------- 1 file changed, 33 insertions(+), 27 deletions(-) -- 2.17.1

1 1

[libvirt] [PATCH] schema: allow a <rule> element with no subelements in a nwfilter
by Laine Stump 21 Jun '18

21 Jun '18

This is a regression in behavior caused by commit 37359814. It was intended to limit the schema to allow only a single subelement of <rule>, but it is also acceptable for <rule> to have no subelement at all. To prevent the same error from reoccurring in the future, the examples/xml/nwfilter directory was added to the list of nwfilter schema test directories. Resolves: https://bugzilla.redhat.com/1593549 Signed-off-by: Laine Stump <laine(a)laine.org> --- docs/schemas/nwfilter.rng | 1 + tests/virschematest.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/schemas/nwfilter.rng b/docs/schemas/nwfilter.rng index cca6ff2954..17cda5c78d 100644 --- a/docs/schemas/nwfilter.rng +++ b/docs/schemas/nwfilter.rng @@ -20,6 +20,7 @@ <element name="rule"> <ref name="rule-node-attributes"/> <choice> + <empty/> <element name="mac"> <ref name="match-attribute"/> <ref name="common-l2-attributes"/> diff --git a/tests/virschematest.c b/tests/virschematest.c index 2d35833919..aa65a434ff 100644 --- a/tests/virschematest.c +++ b/tests/virschematest.c @@ -229,7 +229,7 @@ mymain(void) DO_TEST_DIR("network.rng", "../src/network", "networkxml2xmlin", "networkxml2xmlout", "networkxml2confdata"); DO_TEST_DIR("nodedev.rng", "nodedevschemadata"); - DO_TEST_DIR("nwfilter.rng", "nwfilterxml2xmlout"); + DO_TEST_DIR("nwfilter.rng", "nwfilterxml2xmlout", "../examples/xml/nwfilter"); DO_TEST_DIR("secret.rng", "secretxml2xmlin"); DO_TEST_DIR("storagepool.rng", "storagepoolxml2xmlin", "storagepoolxml2xmlout", "storagepoolschemadata"); -- 2.14.4

2 1

[libvirt] [PATCH 0/2] Two small problems with hyperv Makefile
by Laine Stump 21 Jun '18

21 Jun '18

I found these when make failed after running "make maintainer-clean". Laine Stump (2): hyperv: fix typo in Makefile.am.inc hyperv: erase "generated files" sentinel during make maintainer-clean src/hyperv/Makefile.inc.am | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.14.4

2 3

[libvirt] [dbus PATCH 0/3] tests: Some fixes and cleanups
by Andrea Bolognani 21 Jun '18

21 Jun '18

The first patch fixes an actual bug, the rest just makes things a bit nicer. Andrea Bolognani (3): tests: Fix VIRT_DBUS_INTERFACES_DIR tests: Don't loop up abs_top_builddir in the environment tests: Use AM_TESTS_ENVIRONMENT tests/Makefile.am | 5 ++--- tests/libvirttest.py | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) -- 2.17.1

2 6

Re: [libvirt] [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine
by Eduardo Habkost 21 Jun '18

21 Jun '18

Getting back to this discussion: On Tue, Jun 05, 2018 at 09:43:00AM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 05, 2018 at 09:27:46AM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > > Add to that shortcuts like -cdrom > > > > stop working, > > > > > > Maybe is fixable. > > > > Already fixed for ages. > > > > > I see marking Q35 as the default machine a first step. > > > > Maybe the better option is to go the arm route: Just don't define a > > default, so users have to specify pc or q35. That will make them notice > > there is a world beside 'pc', and we also avoid breaking things > > silently. > > If QEMU removes the default, then libvirt will have to hardcode > 'pc' as the default to maintain back compatibility, so I don't > think that ends up as a net win I believe there's consensus that applications blindly relying on the default machine-type when creating a domain is a bad idea. That said, can we deprecate this feature in libvirt, encourage applications to always specify an explicit machine-type, thus making it possible to deprecate the i440fx machine-types one day? -- Eduardo

4 9

[libvirt] [PATCH 0/3] some small fix for guest SEV related code
by Luyao Huang 21 Jun '18

21 Jun '18

*** BLURB HERE *** Luyao Huang (3): qemu: correct the ret value qemu: improve the debug message when preparing SEV guest docs: remove extra space in the SEV xml element example docs/formatdomain.html.in | 10 +++++----- src/qemu/qemu_process.c | 3 ++- 2 files changed, 7 insertions(+), 6 deletions(-) -- 1.8.3.1

2 5

Re: [libvirt] [Qemu-devel] [PATCH] hw/i386: Deprecate the machine types pc-0.10 and pc-0.11
by Eduardo Habkost 20 Jun '18

20 Jun '18

(CCing Markus and libvir-list) On Wed, Jun 20, 2018 at 08:40:38PM +0200, Thomas Huth wrote: > On 12.06.2018 00:18, Eduardo Habkost wrote: > > On Mon, Jun 11, 2018 at 05:41:04AM +0200, Thomas Huth wrote: > >> The oldest machine type which is still used in a maintained distribution > >> is a pc-0.12 based machine type in RHEL6, so everything that is older > >> than pc-0.12 should not be used anymore. Thus let's deprecate pc-0.10 > >> and pc-0.11 so that we can finally remove them in a future release. > [...] > >> @@ -3952,6 +3953,10 @@ int main(int argc, char **argv, char **envp) > >> } > >> > >> machine_class = select_machine(); > >> + if (machine_class->deprecation_msg) { > >> + error_report("Machine type '%s' is deprecated: %s", > >> + machine_class->name, machine_class->deprecation_msg); > >> + } > > > > Do you plan to add this info to 'query-machines' QMP command? > > No, I'm not planning to add this. We'd need a request from upper layers > (i.e. libvirt) for this first, otherwise it's just a dead interface that > nobody is using. I believe that useful information being available only through stderr is at least as bad as being available only through HMP. Should we extend QMP more proactively in cases like this, too? (In either case, I don't think this should block your series) -- Eduardo

1 0

[libvirt] [PATCH 0/5] Fix a couple of force snapshot revert issues
by John Ferlan 20 Jun '18

20 Jun '18

Well, at least I hope so. There's a couple of related bz's in the last two patches with gobs more details, but the long and short of it is that when using the force flag, the domain is Stop'd and re-Start'd without applying any snapshot. For both issues I've seen, the "error: internal error: unexpected async job 6" occurs on the Start and thus the CPU's aren't started. For one bz, when running managedsave the call never returns. For the other bz, one cannot restart the paused domain. If there's a better way to do this - I'm sure someone will let me know. John Ferlan (5): qemu: Adjust async job failure message qemu: Promote start_flags in qemuDomainRevertToSnapshot qemu: Use start_flags for RUNNING and PAUSED transitions qemu: Unset the genid start change flag for revert force qemu: Don't use asyncJob after stop during snapshot revert src/qemu/qemu_domain.c | 3 ++- src/qemu/qemu_driver.c | 22 +++++++++++++++------- 2 files changed, 17 insertions(+), 8 deletions(-) -- 2.14.4

2 8

[libvirt] [PATCH 0/6] qemu: command: Replace vlan= with netdev=
by Cole Robinson 20 Jun '18

20 Jun '18

Most VMs libvirt knows how to launch will have qemu network config like: -netdev $NETDEV_OPTS,id=netdev1 -device e1000,id=netdev1 However for machine types with built-in platform network devices, we currently do: -net nic,model=e1000,vlan=1 -net $NETDEV_OPTS,vlan=1 However for the platform case, all qemu versions we support can do: -netdev $NETDEV_OPTS,id=netdev1 -net nic,model=e1000,netdev=netdev1 Which simplifies our code, and is more future proof as qemu has deprecated the vlan= option. This series switches to the netdev= method, and performs some cleanups in related code. Thanks, Cole Cole Robinson (6): qemu: command: Make qemuBuildNicStr static qemu: command: Rename BuildNicStr to BuildLegacyNicStr qemu: command: remove unused LegacyNicStr arg 'prefix' qemu: command: replace vlan= with netdev= for legacy nic qemu: Remove vlan function arguments qemu: command: vhost: cleanup error reporting src/qemu/qemu_command.c | 99 ++++++------------- src/qemu/qemu_command.h | 8 -- src/qemu/qemu_hotplug.c | 3 +- .../arm-vexpressa9-basic.args | 4 +- 4 files changed, 33 insertions(+), 81 deletions(-) -- 2.17.1

2 9

[libvirt] [PATCH 0/4] qemu: add comma escaping in qemu_command.c
by Anya Harter 20 Jun '18

20 Jun '18

The function virQEMUBuildBufferEscapeComma is used to escape commas in user provided fields for qemu command line processing in the four functions listed below. A corresponding test for each comma escaping instance has been added to tests/qemuxml2argvdata/name-escape.xml. This should complete the BiteSizedTask entry at https://wiki.libvirt.org/page/BiteSizedTasks#qemu:_Use_comma_escaping_for_m…. Anya Harter (4): qemu: Escape commas for qemuBuildChrChardevStr qemu: Escape commas for qemuBuildChrChardevFileStr qemu: Escape commas for qemuBuildSmartcardCommandLine qemu: Escape commas for qemuBuildGrapicsSPICECommandLine src/qemu/qemu_command.c | 44 +++++++++++-------------- tests/qemuxml2argvdata/name-escape.args | 14 ++++++-- tests/qemuxml2argvdata/name-escape.xml | 18 ++++++++++ tests/qemuxml2argvtest.c | 10 +++++- 4 files changed, 58 insertions(+), 28 deletions(-) -- 2.17.1

3 13

[libvirt] libvirt profiles (a.k.a. virtuned) design ideas draft
by Martin Kletzander 20 Jun '18

20 Jun '18

After some discussion with people from various management apps we decided to try and create something that would help with common, duplicated, and perhaps easy to extract things for which the code exists in some (or most) of the projects. I'd be glad for any feedback, so here is the rendered document: https://github.com/nertpinx/virt-manager/blob/virtuned-docs/docs/virtuned.md and here you can comment: https://github.com/nertpinx/virt-manager/pull/1/files Even though this does not concern libvirt developers, I'm adding pointers here in case someone wants to chime in.

1 0

[libvirt] [PATCH v3 0/4] qemu: Allow concurrent access to monitor and guest agent
by Michal Privoznik 20 Jun '18

20 Jun '18

v3 of: https://www.redhat.com/archives/libvir-list/2018-June/msg01358.html Patches 1/4 and 2/4 are ACKed already. Patch 3/4 is new and implements agent job acquiring when doing snapshots (as suggested by Jirka in his review). Patch 4/4 is written differently (again as suggested by him) although the semantic is the same as in previous version of the patch. Michal Privoznik (4): qemu: Introduce qemuDomainAgentJob qemu: Introduce APIs for manipulating qemuDomainAgentJob qemuDomainSnapshotCreateActiveExternal: Grab agent job qemu: Switch code to use new agent job APIs src/qemu/THREADS.txt | 112 +++++++++++++++++++++++--- src/qemu/qemu_domain.c | 211 ++++++++++++++++++++++++++++++++++++++++--------- src/qemu/qemu_domain.h | 30 +++++++ src/qemu/qemu_driver.c | 124 ++++++++++++++++++++--------- 4 files changed, 390 insertions(+), 87 deletions(-) -- 2.16.4

2 6

[libvirt] [PATCH 0/2] Fixes for segfault and deadlock
by Marc Hartmayer 20 Jun '18

20 Jun '18

One way to reproduce the bugs is to set admin_max_workers=0 in libvirtd.conf, restart libvirtd, and then call: $ virt-admin server-threadpool-info admin Marc Hartmayer (2): rpc: Fix deadlock if there is no worker pool available rpc: Fix segmentation fault when no worker pool is available src/rpc/virnetserver.c | 33 ++++++++++++++++++++++----------- 1 file changed, 22 insertions(+), 11 deletions(-) -- 2.13.6

3 15

[libvirt] [PATCH v2] qemu: fix msg could be a wild pointer in qemuMonitorIOProcess()
by Weilun Zhu 20 Jun '18

20 Jun '18

As qemuMonitorJSONIOProcess() will unlock the qemu monitor, there is some extreme situation, eg qemu send message to monitor twice in a short time, where the local viriable 'msg' of qemuMonitorIOProcess() could be a wild point: 1. qemuMonitorSend() assign mon->msg to parameter 'msg', which is alse a local variable of its caller qemuMonitorJSONCommandWithFd(), cause eventloop to send message to monitor, then wait condition. 2. qemu send message to monitor for the first time immediately. 3. qemuMonitorIOProcess() is called, then wake up the qemuMonitorSend() thread, but the qemuMonitorSend() thread stuck for a while as cpu pressure or some other reasons,, which means the qemu monitor is still unlocked. 4. qemu send event message to monitor for the second time, such as RTC_CHANGE event 5. qemuMonitorIOProcess() is called, the local viriable 'msg' is assigned to mon->msg. 6. qemuMonitorIOProcess() call qemuMonitorJSONIOProcess() to deal with the qemu event. 7. qemuMonitorJSONIOProcess() unlock the qemu monitor in the macro 'QEMU_MONITOR_CALLBACK', then qemuMonitorSend() thread get the mutex and free the mon->msg, assign mon->msg to NULL. so the local viriable 'msg' of qemuMonitorIOProcess() is a wild pointer now. AFAIK, it is not harmful to call again virCondBroadcast() while msg is a wild pointer, but just in case, we fix it in this patch. --- src/qemu/qemu_monitor.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 215135aa3e..a4b8572e24 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -463,6 +463,14 @@ qemuMonitorIOProcess(qemuMonitorPtr mon) #if DEBUG_IO VIR_DEBUG("Process done %d used %d", (int)mon->bufferOffset, len); #endif + + /* As the monitor mutex was unlocked in qemuMonitorJSONIOProcess() + * while dealing with qemu event, mon->msg could be changed, + * thus we re-acquire the msg here */ + msg = NULL; + if (mon->msg && mon->msg->txOffset == mon->msg->txLength) { + msg = mon->msg; + if (msg && msg->finished) virCondBroadcast(&mon->notify); return len; -- 2.18.0.rc1

3 2

Re: [libvirt] [Qemu-devel] [PATCH v7 1/3] qmp: adding 'wakeup-suspend-support' in query-target
by Markus Armbruster 20 Jun '18

20 Jun '18

Cc'ing a few more people. Daniel Henrique Barboza <danielhb(a)linux.ibm.com> writes: > When issuing the qmp/hmp 'system_wakeup' command, what happens in a > nutshell is: > > - qmp_system_wakeup_request set runstate to RUNNING, sets a wakeup_reason > and notify the event > - in the main_loop, all vcpus are paused, a system reset is issued, all > subscribers of wakeup_notifiers receives a notification, vcpus are then > resumed and the wake up QAPI event is fired > > Note that this procedure alone doesn't ensure that the guest will awake > from SUSPENDED state - the subscribers of the wake up event must take > action to resume the guest, otherwise the guest will simply reboot. > > At this moment there are only two subscribers of the wake up event: one > in hw/acpi/core.c and another one in hw/i386/xen/xen-hvm.c. This means > that system_wakeup does not work as intended with other architectures. > > However, only the presence of 'system_wakeup' is required for QGA to > support 'guest-suspend-ram' and 'guest-suspend-hybrid' at this moment. > This means that the user/management will expect to suspend the guest using > one of those suspend commands and then resume execution using system_wakeup, > regardless of the support offered in system_wakeup in the first place. > > This patch adds a new flag called 'wakeup-suspend-support' in TargetInfo > that allows the caller to query if the guest supports wake up from > suspend via system_wakeup. It goes over the subscribers of the wake up > event and, if it's empty, it assumes that the guest does not support > wake up from suspend (and thus, pm-suspend itself). > > This is the expected output of query-target when running a x86 guest: > > {"execute" : "query-target"} > {"return": {"arch": "x86_64", "wakeup-suspend-support": true}} > > This is the output when running a pseries guest: > > {"execute" : "query-target"} > {"return": {"arch": "ppc64", "wakeup-suspend-support": false}} > > Given that the TargetInfo structure is read-only, adding a new flag to > it is backwards compatible. There is no need to deprecate the old > TargetInfo format. > > With this extra tool, management can avoid situations where a guest > that does not have proper suspend/wake capabilities ends up in > inconsistent state (e.g. > https://github.com/open-power-host-os/qemu/issues/31) > > Reported-by: Balamuruhan S <bala24(a)linux.vnet.ibm.com> > Signed-off-by: Daniel Henrique Barboza <danielhb(a)linux.ibm.com> Is query-target is the right place to carry this flag? v7 is rather late for this kind of question; my sincere apologies. The flag is true after qemu_register_wakeup_notifier(). Callers so far: * piix4_pm_realize() via acpi_pm1_cnt_init() This is the realize method of device PIIX4_PM. It's an optional onboard device (suppressed by -no-acpi) of machine types pc-i440fx-VERSION, pc-VERSION, malta. * pc_q35_init() via ich9_lpc_pm_init(), ich9_pm_init(), acpi_pm1_cnt_init() This is the initialization method of machine types pc-q35-VERSION. Note that -no-acpi is not honored. * vt82c686b_pm_realize() via acpi_pm1_cnt_init() This is the realize method of device VT82C686B_PM. It's an onboard device of machine type fulong2e. Again, -no-acpi is not honored. * xen_hvm_init() This one gets called with -accel xen. I suspect the actual callback xen_wakeup_notifier() doesn't actually make wakeup work, unlike the acpi_notify_wakeup() callback registered by the other callers. Issue#1: this calls into question your assumption that the existence of a wake-up notifier implies wake-up works. It still holds if --accel xen is only accepted together with other configuration that triggers registration of acpi_notify_wakeup(). Is it? Stefano, Anthony? Issue#2: the flag isn't a property of the target. Due to -no-acpi, it's not even a property of the machine type. If it was, query-machines would be the natural owner of the flag. Perhaps query-machines is still the proper owner. The value of wakeup-suspend-support would have to depend on -no-acpi for the machine types that honor it. Not ideal; I'd prefer MachineInfo to be static. Tolerable? I guess that's also a libvirt question.

3 14

[libvirt] [dbus PATCH] maint: fix coding style
by Katerina Koukiou 20 Jun '18

20 Jun '18

Signed-off-by: Katerina Koukiou <kkoukiou(a)redhat.com> --- src/connect.c | 12 ++++++------ src/domain.c | 2 +- src/events.c | 24 ++++++++++++------------ src/network.c | 2 +- src/util.c | 6 +++--- src/util.h | 4 ++-- 6 files changed, 25 insertions(+), 25 deletions(-) diff --git a/src/connect.c b/src/connect.c index 2e57d69..09e5628 100644 --- a/src/connect.c +++ b/src/connect.c @@ -1187,12 +1187,12 @@ virtDBusConnectNWFilterDefineXML(GVariant *inArgs, static void virtDBusConnectNWFilterLookupByName(GVariant *inArgs, - GUnixFDList *inFDs G_GNUC_UNUSED, - const gchar *objectPath G_GNUC_UNUSED, - gpointer userData, - GVariant **outArgs, - GUnixFDList **outFDs G_GNUC_UNUSED, - GError **error) + GUnixFDList *inFDs G_GNUC_UNUSED, + const gchar *objectPath G_GNUC_UNUSED, + gpointer userData, + GVariant **outArgs, + GUnixFDList **outFDs G_GNUC_UNUSED, + GError **error) { virtDBusConnect *connect = userData; g_autoptr(virNWFilter) nwfilter = NULL; diff --git a/src/domain.c b/src/domain.c index 4aeb855..5c5e6da 100644 --- a/src/domain.c +++ b/src/domain.c @@ -2189,7 +2189,7 @@ virtDBusDomainMigrateToURI3(GVariant *inArgs, virtDBusConnect *connect = userData; g_autoptr(virDomain) domain = NULL; g_autoptr(GVariantIter) iter = NULL; - const gchar* dconuri; + const gchar *dconuri; g_auto(virtDBusUtilTypedParams) params = { 0 }; guint flags; diff --git a/src/events.c b/src/events.c index 7cdc71d..e635a61 100644 --- a/src/events.c +++ b/src/events.c @@ -546,10 +546,10 @@ virtDBusEventsDomainDiskChange(virConnectPtr connection G_GNUC_UNUSED, static gint virtDBusEventsNetworkEvent(virConnectPtr connection G_GNUC_UNUSED, - virNetworkPtr network, - gint event, - gint detail G_GNUC_UNUSED, - gpointer opaque) + virNetworkPtr network, + gint event, + gint detail G_GNUC_UNUSED, + gpointer opaque) { virtDBusConnect *connect = opaque; g_autofree gchar *path = NULL; @@ -592,10 +592,10 @@ virtDBusEventsNodeDeviceEvent(virConnectPtr connection G_GNUC_UNUSED, static gint virtDBusEventsSecretEvent(virConnectPtr connection G_GNUC_UNUSED, - virSecretPtr secret, - gint event, - gint detail, - gpointer opaque) + virSecretPtr secret, + gint event, + gint detail, + gpointer opaque) { virtDBusConnect *connect = opaque; g_autofree gchar *path = NULL; @@ -615,10 +615,10 @@ virtDBusEventsSecretEvent(virConnectPtr connection G_GNUC_UNUSED, static gint virtDBusEventsStoragePoolEvent(virConnectPtr connection G_GNUC_UNUSED, - virStoragePoolPtr storagePool, - gint event, - gint detail, - gpointer opaque) + virStoragePoolPtr storagePool, + gint event, + gint detail, + gpointer opaque) { virtDBusConnect *connect = opaque; g_autofree gchar *path = NULL; diff --git a/src/network.c b/src/network.c index 1bacb81..3957ee6 100644 --- a/src/network.c +++ b/src/network.c @@ -235,7 +235,7 @@ virtDBusNetworkGetDHCPLeases(GVariant *inArgs, g_variant_builder_add(&builder, "(sxisssuss)", lease->iface, lease->expirytime, lease->type, lease->mac, - lease->iaid ? lease->iaid : "" , + lease->iaid ? lease->iaid : "", lease->ipaddr, lease->prefix, lease->hostname ? lease->hostname : "", lease->clientid ? lease->clientid : ""); diff --git a/src/util.c b/src/util.c index a1b29dd..8c822f2 100644 --- a/src/util.c +++ b/src/util.c @@ -348,8 +348,8 @@ virtDBusUtilVirNodeDeviceListFree(virNodeDevicePtr *devs) virNWFilterPtr virtDBusUtilVirNWFilterFromBusPath(virConnectPtr connection, - const gchar *path, - const gchar *nwfilterPath) + const gchar *path, + const gchar *nwfilterPath) { g_autofree gchar *name = NULL; gsize prefixLen = strlen(nwfilterPath) + 1; @@ -361,7 +361,7 @@ virtDBusUtilVirNWFilterFromBusPath(virConnectPtr connection, gchar * virtDBusUtilBusPathForVirNWFilter(virNWFilterPtr nwfilter, - const gchar *nwfilterPath) + const gchar *nwfilterPath) { gchar uuid[VIR_UUID_STRING_BUFLEN] = ""; g_autofree gchar *newUuid = NULL; diff --git a/src/util.h b/src/util.h index 7db0e25..a688a3d 100644 --- a/src/util.h +++ b/src/util.h @@ -67,8 +67,8 @@ G_DEFINE_AUTOPTR_CLEANUP_FUNC(virDomainStatsRecordPtr, virDomainStatsRecordListF virNetworkPtr virtDBusUtilVirNetworkFromBusPath(virConnectPtr connection, - const gchar *path, - const gchar *networkPath); + const gchar *path, + const gchar *networkPath); gchar * virtDBusUtilBusPathForVirNetwork(virNetworkPtr network, -- 2.15.0

2 1

[libvirt] [PATCH] conf: Remove unused virDomainDefNewFull
by Cole Robinson 20 Jun '18

20 Jun '18

The last usages were removed with the xend driver in 1dac5fbbbb0 Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- src/conf/domain_conf.c | 22 ---------------------- src/conf/domain_conf.h | 3 --- src/libvirt_private.syms | 1 - 3 files changed, 26 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 522e0c2bf3..f0b604e125 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -3241,28 +3241,6 @@ virDomainDefNew(void) } -virDomainDefPtr -virDomainDefNewFull(const char *name, - const unsigned char *uuid, - int id) -{ - virDomainDefPtr def; - - if (!(def = virDomainDefNew())) - return NULL; - - if (VIR_STRDUP(def->name, name) < 0) { - VIR_FREE(def); - return NULL; - } - - memcpy(def->uuid, uuid, VIR_UUID_BUFLEN); - def->id = id; - - return def; -} - - void virDomainObjAssignDef(virDomainObjPtr domain, virDomainDefPtr def, bool live, diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 6344c02d1c..8cefef535a 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2919,9 +2919,6 @@ virDomainChrSourceDefNew(virDomainXMLOptionPtr xmlopt); virDomainChrDefPtr virDomainChrDefNew(virDomainXMLOptionPtr xmlopt); virDomainDefPtr virDomainDefNew(void); -virDomainDefPtr virDomainDefNewFull(const char *name, - const unsigned char *uuid, - int id); void virDomainObjAssignDef(virDomainObjPtr domain, virDomainDefPtr def, diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index ea24f2847c..98913a577a 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -287,7 +287,6 @@ virDomainDefMaybeAddController; virDomainDefMaybeAddInput; virDomainDefNeedsPlacementAdvice; virDomainDefNew; -virDomainDefNewFull; virDomainDefParseFile; virDomainDefParseNode; virDomainDefParseString; -- 2.17.1

2 2

[libvirt] [PATCH] qemu: Fix domain resume after failed migration
by Jiri Denemark 19 Jun '18

19 Jun '18

Libvirt relies on being able to kill the destination domain and resume the source one during migration until we called "cont" on the destination. Unfortunately, QEMU automatically activates block devices at the end of migration even when it's called with -S. This wasn't a big issue in the past since the guest is not running and thus no data are written to the block devices. However, when QEMU introduced its internal block device locks, we can no longer resume the source domain once the destination domain already activated the block devices (and thus acquired all locks) unless the destination domain is killed first. Since it's impossible to synchronize the destination and the source libvirt daemons after a failed migration, QEMU introduced a new migration capability called "late-block-activat" which ensures QEMU won't activate block devices until it gets "cont". The only thing we need to do is to enable this capability whenever QEMU supports it. https://bugzilla.redhat.com/show_bug.cgi?id=1568407 QEMU commit implementing the capability: v2.12.0-952-g0f073f44df Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_migration_params.c | 4 ++++ src/qemu/qemu_migration_params.h | 1 + 2 files changed, 5 insertions(+) diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_params.c index 2083563d32..63d20ff5dc 100644 --- a/src/qemu/qemu_migration_params.c +++ b/src/qemu/qemu_migration_params.c @@ -84,6 +84,7 @@ VIR_ENUM_IMPL(qemuMigrationCapability, QEMU_MIGRATION_CAP_LAST, "postcopy-ram", "compress", "pause-before-switchover", + "late-block-activate", ); @@ -129,6 +130,9 @@ struct _qemuMigrationParamsTPMapItem { static const qemuMigrationParamsAlwaysOnItem qemuMigrationParamsAlwaysOn[] = { {QEMU_MIGRATION_CAP_PAUSE_BEFORE_SWITCHOVER, QEMU_MIGRATION_SOURCE}, + + {QEMU_MIGRATION_CAP_LATE_BLOCK_ACTIVATE, + QEMU_MIGRATION_DESTINATION}, }; /* Translation from virDomainMigrateFlags to qemuMigrationCapability. */ diff --git a/src/qemu/qemu_migration_params.h b/src/qemu/qemu_migration_params.h index 9a865b19f3..bee503d0f4 100644 --- a/src/qemu/qemu_migration_params.h +++ b/src/qemu/qemu_migration_params.h @@ -37,6 +37,7 @@ typedef enum { QEMU_MIGRATION_CAP_POSTCOPY, QEMU_MIGRATION_CAP_COMPRESS, QEMU_MIGRATION_CAP_PAUSE_BEFORE_SWITCHOVER, + QEMU_MIGRATION_CAP_LATE_BLOCK_ACTIVATE, QEMU_MIGRATION_CAP_LAST } qemuMigrationCapability; -- 2.17.1

4 3

[libvirt] [v2 RESEND 0/3] qemu: Allow concurrent access to monitor and guest agent
by Michal Privoznik 19 Jun '18

19 Jun '18

Obsoletes: https://www.redhat.com/archives/libvir-list/2018-June/msg01320.html This is the same version as the one linked above, but since I've merged my other patchset that touches the same area in the code reviewers will get merge conflicts when applying these. Rebase & resend. Michal Privoznik (3): qemu: Introduce qemuDomainAgentJob qemu: Introduce APIs for manipulating qemuDomainAgentJob qemu: Switch code to use new agent job APIs src/qemu/THREADS.txt | 112 +++++++++++++++++++++++++--- src/qemu/qemu_domain.c | 193 ++++++++++++++++++++++++++++++++++++++++--------- src/qemu/qemu_domain.h | 30 ++++++++ src/qemu/qemu_driver.c | 91 ++++++++++++++--------- 4 files changed, 346 insertions(+), 80 deletions(-) -- 2.16.4

3 8

[libvirt] [dbus PATCH 00/14] Introduce NodeDevice APIs
by Katerina Koukiou 19 Jun '18

19 Jun '18

Katerina Koukiou (14): Introduce NodeDevice Interface Implement ListNodeDevices method for Connect Interface Register NodeDevice Lifecycle Events Implement NodeDeviceCreateXML method for Connect Interface Implement Destroy method for NodeDevice Interface Implement Detach method for NodeDevice Interface Implement Name property for NodeDevice Interface Implement Parent property for NodeDevice Interface Implement GetXMLDesc property for NodeDevice Interface Implement ListCaps method for NodeDevicesInterface Implement NodeDeviceLookupByName method for Connect Interface Implement NodeDeviceLookupSCSIHostByWWN method for Connect Interface Implement ReAttach method for NodeDevice Interface Implement Reset method for NodeDevice Interface data/Makefile.am | 1 + data/org.libvirt.Connect.xml | 34 +++++ data/org.libvirt.NodeDevice.xml | 45 +++++++ src/Makefile.am | 1 + src/connect.c | 148 +++++++++++++++++++++ src/connect.h | 2 + src/events.c | 42 ++++++ src/nodedev.c | 283 ++++++++++++++++++++++++++++++++++++++++ src/nodedev.h | 9 ++ src/util.c | 35 +++++ src/util.h | 15 +++ tests/Makefile.am | 1 + tests/libvirttest.py | 13 ++ tests/test_connect.py | 27 ++++ tests/test_nodedev.py | 52 ++++++++ tests/xmldata.py | 16 +++ 16 files changed, 724 insertions(+) create mode 100644 data/org.libvirt.NodeDevice.xml create mode 100644 src/nodedev.c create mode 100644 src/nodedev.h create mode 100755 tests/test_nodedev.py -- 2.15.0

2 28

[libvirt] [PATCH 0/2] A potential deadlock fix for SEV and a tiny cleanup
by Erik Skultety 19 Jun '18

19 Jun '18

*** BLURB HERE *** Erik Skultety (2): qemu: sev: Use EnterMonitor instead of EnterMonitorAsync qemu: sev: Don't jump to endjob if SEV measurement retrieval fails src/qemu/qemu_driver.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) -- 2.14.4

2 5

[libvirt] [PATCH v2 0/3] Implement the HTM pSeries feature
by Andrea Bolognani 19 Jun '18

19 Jun '18

Applies cleanly on top of b1acfaaf890a16ecb2fecdbe7f121eff314dd0e9. Changes from [v1]: * drop qom-list-properties machinery, as equivalent functionality has been merged in the meantime; * don't introduce scaffolding for uniform machine option handling as a requirement for implementing this specific feature: we can do ad-hoc processing for now, per the status quo, then clean up everything (including existing features) with a separate series later. Changes from [RFC v3]: * can be considered for merging, since the QEMU part already has; * fix compatibility issues with QEMU <2.12 spotted by Shivaprasad; * drop all features except for HTM, at least for the time being; * add documentation. Changes from [RFC v2]: * use qom-list-properties to probe availability; * test all features with a single XML file. Changes from [RFC v1]: * don't nest features inside a <pseries/> element; * implement all optional features. [v1] https://www.redhat.com/archives/libvir-list/2018-March/msg00474.html [RFC v3] https://www.redhat.com/archives/libvir-list/2018-March/msg00042.html [RFC v2] https://www.redhat.com/archives/libvir-list/2018-February/msg00310.html [RFC v1] https://www.redhat.com/archives/libvir-list/2018-January/msg00779.html Andrea Bolognani (3): qemu: Add capability for the HTM pSeries feature qemu: Implement the HTM pSeries feature news: Update for the HTM pSeries feature docs/formatdomain.html.in | 8 + docs/news.xml | 9 + docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c | 19 ++ src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 8 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 20 ++ src/qemu/qemu_domain.c | 13 ++ .../caps_2.12.0.aarch64.replies | 48 +++-- .../caps_2.12.0.aarch64.xml | 2 +- .../caps_2.12.0.ppc64.replies | 197 ++++++++++++++++-- .../caps_2.12.0.ppc64.xml | 3 +- .../caps_2.12.0.s390x.replies | 52 +++-- .../caps_2.12.0.s390x.xml | 2 +- .../caps_2.12.0.x86_64.replies | 64 +++--- .../caps_2.12.0.x86_64.xml | 2 +- tests/qemuxml2argvdata/pseries-features.args | 3 +- tests/qemuxml2argvdata/pseries-features.xml | 1 + tests/qemuxml2argvtest.c | 1 + tests/qemuxml2xmltest.c | 1 + 21 files changed, 383 insertions(+), 77 deletions(-) -- 2.17.1

1 3

[libvirt] [PATCH] tests: Fix qemucapsfixreplies
by Andrea Bolognani 19 Jun '18

19 Jun '18

Since e6be524508d5 we include the executed command along with the reply in *.replies files, which breaks the renumbering logic implemented in qemucapsfixreplies. Adapt the script so that it works with the new format. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- tests/qemucapsfixreplies | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/qemucapsfixreplies b/tests/qemucapsfixreplies index 4e3371a1f7..597f9ecd6e 100755 --- a/tests/qemucapsfixreplies +++ b/tests/qemucapsfixreplies @@ -8,7 +8,7 @@ if [ "$#" -ne 1 ] || [ "$1" = "--help" ] || [ ! -f "$1" ]; then fi awk -i inplace \ - 'BEGIN {count=1; pattern="libvirt-[0-9]+"} + 'BEGIN {last=0; pattern="libvirt-[0-9]+"} { if (match($0, "libvirt-1[^0-9]")) { count=1; @@ -16,7 +16,11 @@ awk -i inplace \ if (match($0, pattern)) { str="libvirt-" count; sub(pattern, str, $0); - count++; + if (last != count) { + last=count; + } else { + count++; + } } print }' "$1" -- 2.17.1

2 1

[libvirt] [PATCH] Add condiitonal definition for constants
by Daniel P. Berrangé 19 Jun '18

19 Jun '18

To be able to build against older libvirt, we need to conditionally define the constants, even though they're not exposed in the public API. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as build fix. connect_compat.h | 16 ++++++++++++++++ domain_compat.h | 4 ++++ 2 files changed, 20 insertions(+) diff --git a/connect_compat.h b/connect_compat.h index cd6d678..f780e58 100644 --- a/connect_compat.h +++ b/connect_compat.h @@ -243,4 +243,20 @@ int virNodeGetSEVInfoCompat(virConnectPtr conn, int *nparams, unsigned int flags); +#ifndef VIR_NODE_SEV_CBITPOS +#define VIR_NODE_SEV_CBITPOS "cbitpos" +#endif + +#ifndef VIR_NODE_SEV_REDUCED_PHYS_BITS +#define VIR_NODE_SEV_REDUCED_PHYS_BITS "reduced-phys-bits" +#endif + +#ifndef VIR_NODE_SEV_PDH +#define VIR_NODE_SEV_PDH "pdh" +#endif + +#ifndef VIR_NODE_SEV_CERT_CHAIN +#define VIR_NODE_SEV_CERT_CHAIN "cert-chain" +#endif + #endif /* LIBVIRT_GO_CONNECT_COMPAT_H__ */ diff --git a/domain_compat.h b/domain_compat.h index 5c93ef5..345505c 100644 --- a/domain_compat.h +++ b/domain_compat.h @@ -1042,4 +1042,8 @@ int virDomainGetLaunchSecurityInfoCompat(virDomainPtr domain, int *nparams, unsigned int flags); +#ifndef VIR_DOMAIN_LAUNCH_SECURITY_SEV_MEASUREMENT +#define VIR_DOMAIN_LAUNCH_SECURITY_SEV_MEASUREMENT "sev-measurement" +#endif + #endif /* LIBVIRT_GO_DOMAIN_COMPAT_H__ */ -- 2.17.0

2 1

[libvirt] [dbus PATCH] README: Drop warning about lack of API/ABI guarantees
by Andrea Bolognani 19 Jun '18

19 Jun '18

We have promised not to break compatibility after v1.0.0, which means the warning is no longer accurate and should be dropped. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- README.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/README.md b/README.md index 1ce265c..66aa6f6 100644 --- a/README.md +++ b/README.md @@ -18,9 +18,6 @@ The latest official releases can be found at: * [https://libvirt.org/sources/dbus/](https://libvirt.org/sources/dbus/) -NB: at this time, libvirt-dbus is *NOT* considered API/ABI stable. Future -releases may still include API/ABI incompatible changes. - Dependencies / supported platforms ---------------------------------- -- 2.17.1

2 1

[libvirt] [PATCH v2 0/5] Introduce VIR_CONNECT_GET_ALL_DOMAINS_STATS_NOWAIT
by Michal Privoznik 19 Jun '18

19 Jun '18

v2 of: https://www.redhat.com/archives/libvir-list/2018-June/msg00546.html diff to v1: - Rename to STATS_NOWAIT - John's review worked in - added comment to qemuDomainObjBeginJobNowait Michal Privoznik (5): qemu_domain: Document qemuDomainObjBeginJob qemuDomainObjBeginJobInternal: Remove spurious @ret assignment qemu_domain: Introduce qemuDomainObjBeginJobNowait Introduce VIR_CONNECT_GET_ALL_DOMAINS_STATS_NOWAIT virsh: Introduce --nowait to domstats include/libvirt/libvirt-domain.h | 2 ++ src/libvirt-domain.c | 12 ++++++++ src/qemu/qemu_domain.c | 60 +++++++++++++++++++++++++++++++++++----- src/qemu/qemu_domain.h | 4 +++ src/qemu/qemu_driver.c | 15 ++++++++-- tools/virsh-domain-monitor.c | 7 +++++ tools/virsh.pod | 16 +++++++---- 7 files changed, 101 insertions(+), 15 deletions(-) -- 2.16.4

3 9

[libvirt] [PATCH] tests: add test file for smartcard database
by Anya Harter 18 Jun '18

18 Jun '18

Add test case explicitly defining a smartcard host certificates database via the following xml: <smartcard mode='host-certificates'> <database>/tmp/foo</database> </smartcard> This case is not currently covered in the test suite. Signed-off-by: Anya Harter <aharter(a)redhat.com> --- .../smartcard-host-certificates-database.args | 28 +++++++++++++++ .../smartcard-host-certificates-database.xml | 21 +++++++++++ tests/qemuxml2argvtest.c | 2 ++ .../smartcard-host-certificates-database.xml | 35 +++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 5 files changed, 87 insertions(+) create mode 100644 tests/qemuxml2argvdata/smartcard-host-certificates-database.args create mode 100644 tests/qemuxml2argvdata/smartcard-host-certificates-database.xml create mode 100644 tests/qemuxml2xmloutdata/smartcard-host-certificates-database.xml diff --git a/tests/qemuxml2argvdata/smartcard-host-certificates-database.args b/tests/qemuxml2argvdata/smartcard-host-certificates-database.args new file mode 100644 index 0000000000..bc159f234d --- /dev/null +++ b/tests/qemuxml2argvdata/smartcard-host-certificates-database.args @@ -0,0 +1,28 @@ +LC_ALL=C \ +PATH=/bin \ +HOME=/home/test \ +USER=test \ +LOGNAME=test \ +QEMU_AUDIO_DRV=none \ +/usr/bin/qemu-system-i686 \ +-name QEMUGuest1 \ +-S \ +-machine pc,accel=tcg,usb=off,dump-guest-core=off \ +-m 214 \ +-smp 1,sockets=1,cores=1,threads=1 \ +-uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ +-display none \ +-no-user-config \ +-nodefaults \ +-chardev socket,id=charmonitor,path=/tmp/lib/domain--1-QEMUGuest1/monitor.sock,\ +server,nowait \ +-mon chardev=charmonitor,id=monitor,mode=control \ +-rtc base=utc \ +-no-shutdown \ +-no-acpi \ +-boot c \ +-device usb-ccid,id=ccid0,bus=usb.0,port=1 \ +-usb \ +-device ccid-card-emulated,backend=certificates,cert1=cert1,cert2=cert2,\ +cert3=cert3,db=/tmp/foo,id=smartcard0,bus=ccid0.0 \ +-device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x3 diff --git a/tests/qemuxml2argvdata/smartcard-host-certificates-database.xml b/tests/qemuxml2argvdata/smartcard-host-certificates-database.xml new file mode 100644 index 0000000000..fa35645736 --- /dev/null +++ b/tests/qemuxml2argvdata/smartcard-host-certificates-database.xml @@ -0,0 +1,21 @@ +<domain type='qemu'> + <name>QEMUGuest1</name> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> + <memory unit='KiB'>219136</memory> + <currentMemory unit='KiB'>219136</currentMemory> + <vcpu placement='static'>1</vcpu> + <os> + <type arch='i686' machine='pc'>hvm</type> + <boot dev='hd'/> + </os> + <devices> + <emulator>/usr/bin/qemu-system-i686</emulator> + <smartcard mode='host-certificates'> + <certificate>cert1</certificate> + <certificate>cert2</certificate> + <certificate>cert3</certificate> + <database>/tmp/foo</database> + </smartcard> + <memballoon model='virtio'/> + </devices> +</domain> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index f44cac9fef..194a8d2bab 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1404,6 +1404,8 @@ mymain(void) QEMU_CAPS_CCID_EMULATED); DO_TEST("smartcard-host-certificates", QEMU_CAPS_CCID_EMULATED); + DO_TEST("smartcard-host-certificates-database", + QEMU_CAPS_CCID_EMULATED); DO_TEST("smartcard-passthrough-tcp", QEMU_CAPS_CCID_PASSTHRU); DO_TEST("smartcard-passthrough-spicevmc", diff --git a/tests/qemuxml2xmloutdata/smartcard-host-certificates-database.xml b/tests/qemuxml2xmloutdata/smartcard-host-certificates-database.xml new file mode 100644 index 0000000000..55d54a4355 --- /dev/null +++ b/tests/qemuxml2xmloutdata/smartcard-host-certificates-database.xml @@ -0,0 +1,35 @@ +<domain type='qemu'> + <name>QEMUGuest1</name> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> + <memory unit='KiB'>219136</memory> + <currentMemory unit='KiB'>219136</currentMemory> + <vcpu placement='static'>1</vcpu> + <os> + <type arch='i686' machine='pc'>hvm</type> + <boot dev='hd'/> + </os> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <emulator>/usr/bin/qemu-system-i686</emulator> + <controller type='usb' index='0'> + <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x2'/> + </controller> + <controller type='pci' index='0' model='pci-root'/> + <controller type='ccid' index='0'/> + <smartcard mode='host-certificates'> + <certificate>cert1</certificate> + <certificate>cert2</certificate> + <certificate>cert3</certificate> + <database>/tmp/foo</database> + <address type='ccid' controller='0' slot='0'/> + </smartcard> + <input type='mouse' bus='ps2'/> + <input type='keyboard' bus='ps2'/> + <memballoon model='virtio'> + <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> + </memballoon> + </devices> +</domain> diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index f5805c7f50..4449954ad4 100644 --- a/tests/qemuxml2xmltest.c +++ b/tests/qemuxml2xmltest.c @@ -1163,6 +1163,7 @@ mymain(void) DO_TEST("smartcard-host", NONE); DO_TEST("smartcard-host-certificates", NONE); + DO_TEST("smartcard-host-certificates-database", NONE); DO_TEST("smartcard-passthrough-tcp", NONE); DO_TEST("smartcard-passthrough-spicevmc", NONE); DO_TEST("smartcard-controller", NONE); -- 2.17.1

2 1

[libvirt] [PATCH] qemu: Fix qemuMonitorCreateObjectProps
by John Ferlan 18 Jun '18

18 Jun '18

Commit id f0a23c0c3 introduced qemuMonitorCreateObjectProps to manage wrapping the object name and alias; however, calling virJSONValueObjectCreateVArgs and checking a unary ! return status meant when the CreateVAArgs function returned zero, then rather than generating a @propsret, the jump to cleanup would result in an unexpected failure and cause virsh to issue the "error: An error occurred, but the cause is unknown" error message for something like "virsh iothreadadd $DOM 10" (assuming that IOThread 10 didn't already exist). Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- src/qemu/qemu_monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index b29672d4f1..d6771c1d52 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -3051,7 +3051,7 @@ qemuMonitorCreateObjectProps(virJSONValuePtr *propsret, va_start(args, alias); - if (!(virJSONValueObjectCreateVArgs(&props, args))) + if (virJSONValueObjectCreateVArgs(&props, args) < 0) goto cleanup; if (!(*propsret = qemuMonitorCreateObjectPropsWrap(type, alias, &props))) -- 2.14.4

2 2

[libvirt] [libvirt-go-xml PATCH v2 0/2] Add support for domain launch security
by Erik Skultety 18 Jun '18

18 Jun '18

since v1: - added a launch security subtype for SEV to avoid having a 'type' XML attribute Erik Skultety (2): Add support for domain launch security Add support for SEV in domain capabilities XML domain.go | 162 ++++++++++++++++++++++++++++++++++++++++++++++++- domain_capabilities.go | 7 +++ 2 files changed, 168 insertions(+), 1 deletion(-) -- 2.14.4

2 5

[libvirt] [dockerfiles PATCH] README: Provide information about the images
by Andrea Bolognani 18 Jun '18

18 Jun '18

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Note that this document will be displayed both for the repository containing the Dockerfiles https://github.com/libvirt/libvirt-dockerfiles and for the images produced by said Dockerfiles, eg. https://hub.docker.com/r/libvirt/buildenv-centos-7/ so the language is intentionally vague at times. I believe I've achieved a decent balance between the needs of the two scenarios, but I'm of course totally open to feedback :) README.md | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/README.md b/README.md index a84caf3..ccd7ad1 100644 --- a/README.md +++ b/README.md @@ -1,2 +1,52 @@ Docker-based build environments for libvirt =========================================== + +These images come with all libvirt build dependencies, including +optional ones, already installed: this makes it possible to run +something like + + $ docker run \ + -v $(pwd):/libvirt \ + -w /libvirt \ + -it \ + buildenv-centos-7 + +from a git clone and start building libvirt right away. + +Image availability is influenced by libvirt's +[platform support policy](https://libvirt.org/platforms.html), +with the obvious caveat that non-Linux operating systems can't +be run on top of a Linux kernel and as such are not included. + + +Intended use +------------ + +The images are primarily intended for use on +[Travis CI](https://travis-ci.org/libvirt/libvirt). + +The primary CI environment for the libvirt project is hosted on +[CentOS CI](https://ci.centos.org/view/libvirt/); however, since +that environment feeds off the `master` branch of the various +projects, it can only detect issues after the code causing them +has already been merged. + +While testing on Travis CI doesn't cover as many platforms or the +interactions between as many components, it can be very useful as +a smoke test of sorts that allows developers to catch mistakes +before posting patches to the mailing list. + +As an alternative, images can be used locally without relying on +third-party services; in this scenario, the number of platforms +patches are tested against is only limited by image availability +and hardware resources. + + +Information about build dependencies +------------------------------------ + +The list of build dependencies for libvirt (as well as many +other virtualization-related projects) is taken from the +[libvirt-jenkins-ci](https://libvirt.org/git/?p=libvirt-jenkins-ci.git) +repository, which also contains the tooling used to generate +Dockerfiles. -- 2.17.1

2 1

[libvirt] [PATCH v2 0/3] qemu: Allow concurrent access to monitor and guest agent
by Michal Privoznik 18 Jun '18

18 Jun '18

v2 of: https://www.redhat.com/archives/libvir-list/2018-June/msg00700.html diff to v1: - extended THREADS.txt documentation - added more comments - merged 3/4 to 1/4 in original patch set (I think that's everything that was pointed out in John's review) Michal Privoznik (3): qemu: Introduce qemuDomainAgentJob qemu: Introduce APIs for manipulating qemuDomainAgentJob qemu: Switch code to use new agent job APIs src/qemu/THREADS.txt | 112 ++++++++++++++++++++++++++--- src/qemu/qemu_domain.c | 191 ++++++++++++++++++++++++++++++++++++++++--------- src/qemu/qemu_domain.h | 30 ++++++++ src/qemu/qemu_driver.c | 91 ++++++++++++++--------- 4 files changed, 345 insertions(+), 79 deletions(-) -- 2.16.4

1 3

[libvirt] [PATCH] events: Remove ATTRIBUTE_NONNULL for virObjectEventStateQueue[Remote]
by John Ferlan 18 Jun '18

18 Jun '18

Commit aad3a0b5f altered virObjectEventStateQueueRemote to move the "if (!event) return" call added in the previous commit 031eb8f6 to virObjectEventStateQueue. Neither commit altered the function prototype which used ATTRIBUTE_NONNULL(2). This caused Coverity build problems. Since @event is now checked, just remove the ATTRIBUTE_NONNULL check from both prototypes. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- src/conf/object_event.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Although a Coverity build breaker, that doesn't affect everyone so I'll wait for R-By or ACK for push. diff --git a/src/conf/object_event.h b/src/conf/object_event.h index 133f7ed914..70e9579e81 100644 --- a/src/conf/object_event.h +++ b/src/conf/object_event.h @@ -62,13 +62,13 @@ typedef void (*virConnectObjectEventGenericCallback)(virConnectPtr conn, void virObjectEventStateQueue(virObjectEventStatePtr state, virObjectEventPtr event) - ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); + ATTRIBUTE_NONNULL(1); void virObjectEventStateQueueRemote(virObjectEventStatePtr state, virObjectEventPtr event, int remoteID) - ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); + ATTRIBUTE_NONNULL(1); int virObjectEventStateDeregisterID(virConnectPtr conn, -- 2.14.4

2 1

[libvirt] [libvirt-go PATCH 0/2] Add bindings for recent libvirt SEV APIs
by Erik Skultety 18 Jun '18

18 Jun '18

*** BLURB HERE *** Erik Skultety (2): Add support for AMD SEV launch security info Add support for AMD SEV platform info connect.go | 59 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ connect_compat.go | 12 +++++++++++ connect_compat.h | 7 +++++++ domain.go | 41 ++++++++++++++++++++++++++++++++++++++ domain_compat.go | 13 ++++++++++++ domain_compat.h | 6 ++++++ 6 files changed, 138 insertions(+) -- 2.14.4

2 5

[libvirt] [PATCH] qemuDomainDetachDeviceConfig: Don't free device from @dev
by Michal Privoznik 18 Jun '18

18 Jun '18

https://bugzilla.redhat.com/show_bug.cgi?id=1591561 For reasons I don't understand my original patch of 75f0fd51124 freed not only the chardev from domain but also the one from passed virDomainDeviceDefPtr. This caused no troubles until now, because those two pointers were separate, but after I've introduced virDomainDetachDeviceAlias() they became the same resulting in double free on detach. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 42069ee617..7fe86d4d2e 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -8241,8 +8241,6 @@ qemuDomainDetachDeviceConfig(virDomainDefPtr vmdef, return -1; virDomainChrDefFree(chr); - virDomainChrDefFree(dev->data.chr); - dev->data.chr = NULL; break; case VIR_DOMAIN_DEVICE_FS: -- 2.16.4

2 1

[libvirt] [PATCH v2 0/3] cmdDomblkinfo: introduce --all to show all block devices info
by Chen Hanxiao 15 Jun '18

15 Jun '18

This series introduce --all to cmdDomblkinfo to show all block devices info in one cmd. Likes a combination of domblklist and domblkinfo. v2: add support --human for --all v1.1 fix a self test Chen Hanxiao (3): cmdDomblkinfo: introduce helper cmdDomblkinfoPrint cmdDomblkinfo: add --all to show all block devices info news: add cmdDomblkinfo --all option docs/news.xml | 8 +++ tools/virsh-domain-monitor.c | 125 +++++++++++++++++++++++++++++------ tools/virsh.pod | 5 +- 3 files changed, 118 insertions(+), 20 deletions(-) -- 2.17.1

2 8

[libvirt] [PATCH v2 0/5] travis: Use pre-built Docker images
by Andrea Bolognani 15 Jun '18

15 Jun '18

Changes from [v1]: * store Dockerfiles in git so that we can have automated builds on Docker Hub; * add MinGW builds; * change image naming convention, from eg. libvirt/build:fedora-28 to libvirt/buildenv-fedora-28. [v1] https://www.redhat.com/archives/libvir-list/2018-June/msg00920.html Andrea Bolognani (5): docker: Commit initial Dockerfiles travis: Drop Ubuntu 16.04 build travis: Use pre-built Docker images travis: Add CentOS 7 build travis: Add MinGW builds .docker/buildenv-centos-7.Dockerfile | 70 ++++++++++++++ .docker/buildenv-debian-8.Dockerfile | 76 +++++++++++++++ .docker/buildenv-debian-9.Dockerfile | 78 ++++++++++++++++ .docker/buildenv-debian-sid.Dockerfile | 78 ++++++++++++++++ .docker/buildenv-fedora-27.Dockerfile | 78 ++++++++++++++++ .docker/buildenv-fedora-28.Dockerfile | 78 ++++++++++++++++ .docker/buildenv-fedora-rawhide.Dockerfile | 102 +++++++++++++++++++++ .docker/buildenv-ubuntu-16.Dockerfile | 79 ++++++++++++++++ .docker/buildenv-ubuntu-18.Dockerfile | 79 ++++++++++++++++ .travis.yml | 101 ++++++-------------- 10 files changed, 745 insertions(+), 74 deletions(-) create mode 100644 .docker/buildenv-centos-7.Dockerfile create mode 100644 .docker/buildenv-debian-8.Dockerfile create mode 100644 .docker/buildenv-debian-9.Dockerfile create mode 100644 .docker/buildenv-debian-sid.Dockerfile create mode 100644 .docker/buildenv-fedora-27.Dockerfile create mode 100644 .docker/buildenv-fedora-28.Dockerfile create mode 100644 .docker/buildenv-fedora-rawhide.Dockerfile create mode 100644 .docker/buildenv-ubuntu-16.Dockerfile create mode 100644 .docker/buildenv-ubuntu-18.Dockerfile -- 2.17.1

2 14

[libvirt] [jenkins-ci POC 0/2] guests: Add Dockerfile generator
by Andrea Bolognani 15 Jun '18

15 Jun '18

See 2/2 for details. Andrea Bolognani (2): guests: Remove OS detection guests: Add Dockerfile generator guests/dockerfile-generator | 72 +++++++++++++++++++ guests/host_vars/libvirt-centos-7/docker.yml | 2 + guests/host_vars/libvirt-centos-7/main.yml | 4 ++ guests/host_vars/libvirt-debian-8/docker.yml | 2 + guests/host_vars/libvirt-debian-8/main.yml | 4 ++ guests/host_vars/libvirt-debian-9/docker.yml | 2 + guests/host_vars/libvirt-debian-9/main.yml | 4 ++ .../host_vars/libvirt-debian-sid/docker.yml | 2 + guests/host_vars/libvirt-debian-sid/main.yml | 4 ++ guests/host_vars/libvirt-fedora-27/docker.yml | 2 + guests/host_vars/libvirt-fedora-27/main.yml | 4 ++ guests/host_vars/libvirt-fedora-28/docker.yml | 2 + guests/host_vars/libvirt-fedora-28/main.yml | 4 ++ .../libvirt-fedora-rawhide/docker.yml | 2 + .../host_vars/libvirt-fedora-rawhide/main.yml | 4 ++ guests/host_vars/libvirt-freebsd-10/main.yml | 4 ++ guests/host_vars/libvirt-freebsd-11/main.yml | 4 ++ .../libvirt-freebsd-current/main.yml | 4 ++ guests/host_vars/libvirt-ubuntu-16/docker.yml | 2 + guests/host_vars/libvirt-ubuntu-16/main.yml | 4 ++ guests/host_vars/libvirt-ubuntu-18/docker.yml | 2 + guests/host_vars/libvirt-ubuntu-18/main.yml | 4 ++ guests/tasks/base.yml | 51 ------------- 23 files changed, 138 insertions(+), 51 deletions(-) create mode 100755 guests/dockerfile-generator create mode 100644 guests/host_vars/libvirt-centos-7/docker.yml create mode 100644 guests/host_vars/libvirt-debian-8/docker.yml create mode 100644 guests/host_vars/libvirt-debian-9/docker.yml create mode 100644 guests/host_vars/libvirt-debian-sid/docker.yml create mode 100644 guests/host_vars/libvirt-fedora-27/docker.yml create mode 100644 guests/host_vars/libvirt-fedora-28/docker.yml create mode 100644 guests/host_vars/libvirt-fedora-rawhide/docker.yml create mode 100644 guests/host_vars/libvirt-ubuntu-16/docker.yml create mode 100644 guests/host_vars/libvirt-ubuntu-18/docker.yml -- 2.17.1

2 5

[libvirt] [PATCH 0/5] Introduce VIR_CONNECT_GET_ALL_DOMAINS_STATS_BEST_EFFORT
by Michal Privoznik 15 Jun '18

15 Jun '18

Problem is, if there is a long standing job on a domain fetching statistics might hiccup which might be a problem for mgmt apps that query stats every few seconds. Orthogonal to this, I think we should break our sync QEMU_JOB_* into two separate jobs: one for qemu monitor the other for qemu guest agent. Problem is, if thread A grabs QEMU_JOB_MODIFY and talks only to guest agent it prevents thread B from grabbing QEMU_JOB_QUERY which wants to talk only to qemu monitor. But this is a different can of worms and I haven't thought it through completely just yet. Michal Privoznik (5): qemu_domain: Document qemuDomainObjBeginJob qemuDomainObjBeginJobInternal: Remove spurious @ret assignment qemu_domain: Introduce qemuDomainObjBeginJobInstant Introcude VIR_CONNECT_GET_ALL_DOMAINS_STATS_BEST_EFFORT virsh: Introduce --best-effort to domstats include/libvirt/libvirt-domain.h | 1 + src/libvirt-domain.c | 10 +++++++++ src/qemu/qemu_domain.c | 47 ++++++++++++++++++++++++++++++++++------ src/qemu/qemu_domain.h | 4 ++++ src/qemu/qemu_driver.c | 15 ++++++++++--- tools/virsh-domain-monitor.c | 7 ++++++ tools/virsh.pod | 16 +++++++++----- 7 files changed, 85 insertions(+), 15 deletions(-) -- 2.16.4

3 20

[libvirt] [PATCH 0/2] SEV: Always format the <sev> element to the domcaps XML
by Erik Skultety 15 Jun '18

15 Jun '18

*** BLURB HERE *** Erik Skultety (2): schema: Fix the definition of SEV in domain capabilities schema conf: Fix formatting of <sev> element in domain capabilities XML docs/schemas/domaincaps.rng | 19 ++++++++++--------- src/conf/domain_capabilities.c | 20 ++++++++++++-------- tests/domaincapsschemadata/basic.xml | 1 + tests/domaincapsschemadata/bhyve_basic.x86_64.xml | 1 + tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml | 1 + tests/domaincapsschemadata/bhyve_uefi.x86_64.xml | 1 + tests/domaincapsschemadata/full.xml | 1 + tests/domaincapsschemadata/libxl-xenfv-usb.xml | 1 + tests/domaincapsschemadata/libxl-xenfv.xml | 1 + tests/domaincapsschemadata/libxl-xenpv-usb.xml | 1 + tests/domaincapsschemadata/libxl-xenpv.xml | 1 + tests/domaincapsschemadata/qemu_1.7.0.x86_64.xml | 1 + .../qemu_2.12.0-virt.aarch64.xml | 1 + tests/domaincapsschemadata/qemu_2.12.0.ppc64.xml | 1 + tests/domaincapsschemadata/qemu_2.12.0.s390x.xml | 1 + tests/domaincapsschemadata/qemu_2.12.0.x86_64.xml | 1 + .../domaincapsschemadata/qemu_2.6.0-virt.aarch64.xml | 1 + tests/domaincapsschemadata/qemu_2.6.0.aarch64.xml | 1 + tests/domaincapsschemadata/qemu_2.6.0.ppc64.xml | 1 + tests/domaincapsschemadata/qemu_2.6.0.x86_64.xml | 1 + tests/domaincapsschemadata/qemu_2.7.0.s390x.xml | 1 + tests/domaincapsschemadata/qemu_2.8.0-tcg.x86_64.xml | 1 + tests/domaincapsschemadata/qemu_2.8.0.s390x.xml | 1 + tests/domaincapsschemadata/qemu_2.8.0.x86_64.xml | 1 + tests/domaincapsschemadata/qemu_2.9.0-q35.x86_64.xml | 1 + tests/domaincapsschemadata/qemu_2.9.0-tcg.x86_64.xml | 1 + tests/domaincapsschemadata/qemu_2.9.0.x86_64.xml | 1 + 27 files changed, 47 insertions(+), 17 deletions(-) -- 2.14.4

2 7

Re: [libvirt] [PATCH v4 3/3] hw/vfio/display: add ramfb support
by Alex Williamson 15 Jun '18

15 Jun '18

On Wed, 13 Jun 2018 10:41:49 +0200 Gerd Hoffmann <kraxel(a)redhat.com> wrote: > So we have a boot display when using a vgpu as primary display. > > Use vfio-pci-ramfb instead of vfio-pci to enable it. Using a different device here seems like it almost guarantees a very complicated path to support under libvirt. What necessitates this versus a simple ramfb=on option to vfio-pci? I'm also not sure I understand the usage model, SeaBIOS and OVMF know how to write to this display, but it seems that the guest does not. I suppose in the UEFI case runtime services can be used to continue writing this display, but BIOS doesn't have such an option, unless we're somehow emulating VGA here. So for UEFI, I can imagine this covers us from power on through firmware boot and up to guest drivers initializing the GPU (assuming the vGPU supports a kernel mode driver, does NVIDIA?), but for BIOS it seems we likely still have a break from the bootloader to GPU driver initialization. For instance, what driver is used to draw the boot animation (or blue screen) on SeaBIOS Windows VM? I'm assuming that this display and the vGPU display are one in the same, so there's some cut from one to the other. Thanks, Alex > Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com> > --- > include/hw/vfio/vfio-common.h | 2 ++ > hw/vfio/display.c | 10 ++++++++++ > hw/vfio/pci.c | 15 +++++++++++++++ > 3 files changed, 27 insertions(+) > > diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h > index a9036929b2..a58d7e7e77 100644 > --- a/include/hw/vfio/vfio-common.h > +++ b/include/hw/vfio/vfio-common.h > @@ -26,6 +26,7 @@ > #include "qemu/queue.h" > #include "qemu/notify.h" > #include "ui/console.h" > +#include "hw/display/ramfb.h" > #ifdef CONFIG_LINUX > #include <linux/vfio.h> > #endif > @@ -143,6 +144,7 @@ typedef struct VFIODMABuf { > > typedef struct VFIODisplay { > QemuConsole *con; > + RAMFBState *ramfb; > struct { > VFIORegion buffer; > DisplaySurface *surface; > diff --git a/hw/vfio/display.c b/hw/vfio/display.c > index 59c0e5d1d7..409d5a2e3a 100644 > --- a/hw/vfio/display.c > +++ b/hw/vfio/display.c > @@ -124,6 +124,9 @@ static void vfio_display_dmabuf_update(void *opaque) > > primary = vfio_display_get_dmabuf(vdev, DRM_PLANE_TYPE_PRIMARY); > if (primary == NULL) { > + if (dpy->ramfb) { > + ramfb_display_update(dpy->con, dpy->ramfb); > + } > return; > } > > @@ -181,6 +184,8 @@ static int vfio_display_dmabuf_init(VFIOPCIDevice *vdev, Error **errp) > vdev->dpy->con = graphic_console_init(DEVICE(vdev), 0, > &vfio_display_dmabuf_ops, > vdev); > + if (strcmp(object_get_typename(OBJECT(vdev)), "vfio-pci-ramfb") == 0) > + vdev->dpy->ramfb = ramfb_setup(errp); > return 0; > } > > @@ -228,6 +233,9 @@ static void vfio_display_region_update(void *opaque) > return; > } > if (!plane.drm_format || !plane.size) { > + if (dpy->ramfb) { > + ramfb_display_update(dpy->con, dpy->ramfb); > + } > return; > } > format = qemu_drm_format_to_pixman(plane.drm_format); > @@ -300,6 +308,8 @@ static int vfio_display_region_init(VFIOPCIDevice *vdev, Error **errp) > vdev->dpy->con = graphic_console_init(DEVICE(vdev), 0, > &vfio_display_region_ops, > vdev); > + if (strcmp(object_get_typename(OBJECT(vdev)), "vfio-pci-ramfb") == 0) > + vdev->dpy->ramfb = ramfb_setup(errp); > return 0; > } > > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index 18c493b49e..6a2b42a595 100644 > --- a/hw/vfio/pci.c > +++ b/hw/vfio/pci.c > @@ -3234,9 +3234,24 @@ static const TypeInfo vfio_pci_dev_info = { > }, > }; > > +static void vfio_pci_ramfb_dev_class_init(ObjectClass *klass, void *data) > +{ > + DeviceClass *dc = DEVICE_CLASS(klass); > + > + dc->hotpluggable = false; > +} > + > +static const TypeInfo vfio_pci_ramfb_dev_info = { > + .name = "vfio-pci-ramfb", > + .parent = "vfio-pci", > + .instance_size = sizeof(VFIOPCIDevice), > + .class_init = vfio_pci_ramfb_dev_class_init, > +}; > + > static void register_vfio_pci_dev_type(void) > { > type_register_static(&vfio_pci_dev_info); > + type_register_static(&vfio_pci_ramfb_dev_info); > } > > type_init(register_vfio_pci_dev_type)

4 4

[libvirt] [dbus PATCH v2 00/17] StorageVolume APIs
by Katerina Koukiou 15 Jun '18

15 Jun '18

Changes from v1: - Fixes from reviews - And more: * tests: Moved all xml definitions for tests in separate file. * tests: Renamed all functions that are not supposed to be run as tests, so that they don't have test prefix. I found out that these were running as tests, when I added the new function for listing the volumes from the test driver. test driver doesn't offer any volumes, and the function failed. * tests: To get a test volume I created a pytest fixture, which I add in the setup of the tests that are manipulating with volumes. In this way, the get_test_storage_volume function remained same to the similar purpose functions as suggested in the previous review. Katerina Koukiou (17): Introduce StorageVol Interface Implement ListStorageVolumes for StoragePool Interface test: move XML definition of entities to seperate file tests: rename test_* functions which are not tests Implement StorageVolCreateXML method for StoragePool Interface Implement Name property for StorageVol Interface Implement Key property for StorageVol Interface Implement Path property for StorageVol Interface Implement GetXMLDesc method for StorageVol Interface Implement StorageVolLookupByKey method for Connect Interface Implement StorageVolLookupByName method for StoragePool Interface Implement StorageVolLookupByPath method for Connect Interface Implement Resize method for StorageVol Interface Implement Wipe method for StorageVol Interface Implement GetInfo method for StorageVol Interface Implement Delete method for StorageVol Interface Implement StorageVolCreateXMLFrom method for StoragePool Interface data/Makefile.am | 4 +- data/org.libvirt.Connect.xml | 12 ++ data/org.libvirt.StoragePool.xml | 28 ++++ data/org.libvirt.StorageVol.xml | 51 +++++++ src/Makefile.am | 4 +- src/connect.c | 66 +++++++++ src/connect.h | 1 + src/storagepool.c | 152 ++++++++++++++++++++ src/storagevol.c | 302 +++++++++++++++++++++++++++++++++++++++ src/storagevol.h | 9 ++ src/util.c | 35 +++++ src/util.h | 16 +++ tests/libvirttest.py | 37 ++++- tests/test_connect.py | 69 ++++----- tests/test_domain.py | 20 +-- tests/test_network.py | 14 +- tests/test_storage.py | 79 ++++++++-- tests/xmldata.py | 47 ++++++ 18 files changed, 871 insertions(+), 75 deletions(-) create mode 100644 data/org.libvirt.StorageVol.xml create mode 100644 src/storagevol.c create mode 100644 src/storagevol.h create mode 100644 tests/xmldata.py -- 2.15.0

2 21

[libvirt] [PATCH v2 0/6] travis: Various cleanups and fixes
by Andrea Bolognani 14 Jun '18

14 Jun '18

Changes from [v1]: * keep DOCKER_CMD around instead of removing it completely, which will help once we introduce MinGW builds; * the last two patches are new. [v1] https://www.redhat.com/archives/libvir-list/2018-June/msg00579.html Andrea Bolognani (6): travis: Skip macOS upgrade travis: Don't duplicate Docker invocation travis: Introduce MACOS_CMD travis: Rename DOCKER_CMD to LINUX_CMD travis: Fix error path travis: Skip first compilation for Linux builds .travis.yml | 74 ++++++++++++++++++++++++----------------------------- 1 file changed, 34 insertions(+), 40 deletions(-) -- 2.17.1

2 7

[libvirt] [PATCH 0/4] qemu: Allow concurrent access to monitor and guest agent
by Michal Privoznik 14 Jun '18

14 Jun '18

It is very easy to see these patches in action. Just apply the following diff: diff --git i/src/qemu/qemu_agent.c w/src/qemu/qemu_agent.c index 10c6ef09fa..dd48caecb7 100644 --- i/src/qemu/qemu_agent.c +++ w/src/qemu/qemu_agent.c @@ -1702,6 +1702,8 @@ qemuAgentGetTime(qemuAgentPtr mon, VIR_DOMAIN_QEMU_AGENT_COMMAND_BLOCK) < 0) goto cleanup; + sleep(120); + if (virJSONValueObjectGetNumberUlong(reply, "return", &json_time) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("malformed return value")); This is to simulate a slow guest agent. Then all you need to do is run: 'virsh domtime $dom' and then 'virsh domstats $dom' from another terminal. Enjoy. Michal Privoznik (4): qemu: Introduce qemuDomainAgentJob qemu: Introduce APIs for manipulating qemuDomainAgentJob qemuDomainAgentJob: Introduce query and modify jobs qemu: Switch code to use new agent job APIs src/qemu/THREADS.txt | 62 ++++++++++++++++-- src/qemu/qemu_domain.c | 169 +++++++++++++++++++++++++++++++++++++++---------- src/qemu/qemu_domain.h | 29 +++++++++ src/qemu/qemu_driver.c | 91 ++++++++++++++++---------- 4 files changed, 281 insertions(+), 70 deletions(-) -- 2.16.4

2 15

[libvirt] [libvirt-go-xml PATCH 0/2] Add support for the AMD SEV feature
by Erik Skultety 14 Jun '18

14 Jun '18

*** BLURB HERE *** Erik Skultety (2): Add support for domain launch security Add support for SEV in domain capabilities XML domain.go | 135 ++++++++++++++++++++++++++++++++++++++++++++++++- domain_capabilities.go | 7 +++ 2 files changed, 141 insertions(+), 1 deletion(-) -- 2.14.4

2 5

[libvirt] [PATCH v4 0/2] Finish the conversion to virConfGetValue* functions
by Fabiano Fidêncio 14 Jun '18

14 Jun '18

This patchset finishes the conversion to virConfGetValue* functions, started by Daniel Berrange a few months ago. Please, mind that although we could make virConfGetValue* functions more generic in order to support numbers and booleans as strings, that doesn't seem the safest path to take. The side-effect of this is that we will have to live with some specific code doing that as part of vmx and xen_common. Once this patchset gets merged, https://wiki.libvirt.org/page/BiteSizedTasks#Finish_conversion_to_virConfGe… can be removed. - Changes since v1: All the "values" from virConfGetValueString() are freed - Changes since v2: All comments from Ján Tomko have been addressed; A few leaks were (possibly) found and they're addressed in the last patch of the series; - Changes since v3: All commentes from Ján Tomko have been addressed in order to lower the non-whitespace changes in the first patch; Fabiano Fidêncio (2): xen_common: Split per-Vif logic from xenParseVif() xen_common: convert to typesafe virConf acessors src/xenconfig/xen_common.c | 535 +++++++++++++++++++++++---------------------- 1 file changed, 273 insertions(+), 262 deletions(-) -- 2.14.3

2 4

[libvirt] [libvirt-python PATCH v2 0/2] Provide coverage for the AMD SEV APIs
by Erik Skultety 14 Jun '18

14 Jun '18

Add support for the recently introduced AMD SEV APIs. since v1: - fixed indentation issues - built against a refreshed master and fixed some compilation errors - added virNodeGetSEVInfo to the XML api override list Erik Skultety (2): Add support for virDomainGetLaunchSecurityInfo Add support for virNodeGetSEVInfo generator.py | 2 ++ libvirt-override-api.xml | 12 ++++++++ libvirt-override.c | 74 ++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 88 insertions(+) -- 2.14.4

2 5

[libvirt] [PATCHv2] docs: schema: Add missing <interleave> element to input device
by Lily Zhu 14 Jun '18

14 Jun '18

For the 2 optional sub-elements - <alias> and <address> of input device, make the order of them interchangeable in the XML. Signed-off-by: Lily Zhu <lizhu(a)redhat.com> --- docs/schemas/domaincommon.rng | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 1d06a5e..7c7f956 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -4309,12 +4309,14 @@ </element> </group> </choice> - <optional> - <ref name="alias"/> - </optional> - <optional> - <ref name="address"/> - </optional> + <interleave> + <optional> + <ref name="alias"/> + </optional> + <optional> + <ref name="address"/> + </optional> + </interleave> </element> </define> <define name="hub"> -- 1.8.3.1

2 1

[libvirt] Call to virDomainIsActive hangs forever
by Mathieu Tarral 14 Jun '18

14 Jun '18

Hi ! I'm submitting my messages on this mailing list to request a bit of help on a case that I have where a Python application makes a call to virDomainIsActive, and the call never returns. I have tried to investigate, but as there are no debug symbols for libvirt on Debian Stretch, i can only have the following GDB backtrace: (gdb) bt #0 pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185 #1 0x00007f49026f5b76 in virCondWait () from /usr/lib/libvirt.so.0 #2 0x00007f4902808bab in ?? () from /usr/lib/libvirt.so.0 #3 0x00007f490280a433 in virNetClientSendWithReply () from /usr/lib/libvirt.so.0 #4 0x00007f490280abe2 in virNetClientProgramCall () from /usr/lib/libvirt.so.0 #5 0x00007f49027e0ea4 in ?? () from /usr/lib/libvirt.so.0 #6 0x00007f49027ea1bb in ?? () from /usr/lib/libvirt.so.0 #7 0x00007f49027b0ef3 in virDomainIsActive () from /usr/lib/libvirt.so.0 #8 0x00007f4902b7fbd0 in libvirt_virDomainIsActive () from /usr/lib/python3/dist-packages/libvirtmod.cpython-35m-x86_64-linux-gnu.so #9 0x0000558eeec696df in PyCFunction_Call () at ../Objects/methodobject.c:109 The libvirt driver used is QEMU, and i have a specific monitoring in place using virtual machine introspection: https://github.com/KVM-VMI/kvm-vmi Now this specific monitoring somehow triggers this bug, and at this point, i don't know if it's a corner case in the libvirt QEMU driver or not. That's why i would like to have your lights on this. libvirt version: 3.0.0-4 -> Could you tell me where i should look in the code ? -> Do you have more information about this virCondWait ? Which condition is it waiting for ? -> How can i get the symbols without having the recompile libvirt and install it system wide, erasing the binaries installed by the package ? Best regards, -- Mathieu Tarral

5 11

[libvirt] [dbus PATCH 00/15] StorageVolume APIs
by Katerina Koukiou 14 Jun '18

14 Jun '18

StorageVols logically should be nested under StoragePools, however this implementation does not nest the StorageVol interface under StorageVols. Reason is that the current gdbus.c implementation would not allow nesting of objects. Phrdina checked the posibility of rewritting the gdbus.c to support such requirements, but the effort stopped, since such implentation would interfere with the current lazy loading of objects. Thus, this solution appears to be the only viable. Katerina Koukiou (15): Introduce StorageVol Interface Implement ListStorageVolumes for StoragePool Interface Implement StorageVolCreateXML method for StoragePool Interface Implement Name property for StorageVol Interface Implement Key property for StorageVol Interface Implement Path property for StorageVol Interface Implement GetXMLDesc method for StorageVol Interface Implement StorageVolLookupByKey method for Connect Interface Implement StorageVolLookupByName method for StoragePool Interface Implement StorageVolLookupByPath method for Connect Interface Implement Resize method for StorageVol Interface Implement Wipe method for StorageVol Interface Implement GetInfo method for StorageVol Interface Implement Delete method for StorageVol Interface Implement StorageVolCreateXMLFrom method for StoragePool Interface data/Makefile.am | 3 +- data/org.libvirt.Connect.xml | 12 ++ data/org.libvirt.StoragePool.xml | 28 ++++ data/org.libvirt.StorageVol.xml | 51 +++++++ src/Makefile.am | 3 +- src/connect.c | 65 ++++++++ src/connect.h | 1 + src/storagepool.c | 153 +++++++++++++++++++ src/storagevol.c | 321 +++++++++++++++++++++++++++++++++++++++ src/storagevol.h | 9 ++ src/util.c | 35 +++++ src/util.h | 16 ++ tests/libvirttest.py | 17 +++ tests/test_connect.py | 15 ++ tests/test_storage.py | 57 +++++++ 15 files changed, 784 insertions(+), 2 deletions(-) create mode 100644 data/org.libvirt.StorageVol.xml create mode 100644 src/storagevol.c create mode 100644 src/storagevol.h -- 2.15.0

3 35

Re: [libvirt] [Qemu-devel] [PATCH v6 2/2] vl: fix use of --daemonize with --preconfig
by Eduardo Habkost 14 Jun '18

14 Jun '18

CCing libvir-list. On Mon, Jun 11, 2018 at 11:29:24PM +0200, Igor Mammedov wrote: > On Mon, 11 Jun 2018 16:06:07 -0300 > Eduardo Habkost <ehabkost(a)redhat.com> wrote: > > > On Mon, Jun 11, 2018 at 03:16:25PM +0200, Igor Mammedov wrote: > > > On Fri, 8 Jun 2018 10:21:05 -0300 > > > Eduardo Habkost <ehabkost(a)redhat.com> wrote: > > > > > > > On Thu, Jun 07, 2018 at 02:00:09PM +0200, Igor Mammedov wrote: > > > > > When using --daemonize, the initial lead process will fork a child and > > > > > then wait to be notified that setup is complete via a pipe, before it > > > > > exits. When using --preconfig there is an extra call to main_loop() > > > > > before the notification is done from os_setup_post(). Thus the parent > > > > > process won't exit until the mgmt application connects to the monitor > > > > > and tells QEMU to leave the RUN_STATE_PRECONFIG. The mgmt application > > > > > won't connect to the monitor until daemonizing has completed though. > > > > > > > > > > This is a chicken and egg problem, leading to deadlock at startup. > > > > > > > > > > The only viable way to fix this is to call os_setup_post() before > > > > > the early main_loop() call when --preconfig is used. This has the > > > > > downside that any errors from this point onwards won't be handled > > > > > well by the mgmt application, because it will think QEMU has started > > > > > successfully, so not be expecting an abrupt exit. Moving as much user > > > > > input validation as possible to before the main_loop() call might help, > > > > > but mgmt application should stop assuming that QEMU has started > > > > > successfuly and use other means to collect errors from QEMU (logfile). > > > > > > > > > > Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> > > > > > Signed-off-by: Igor Mammedov <imammedo(a)redhat.com> > > > > > --- > > > > > v5: > > > > > * use original Daniel's patch [1], but addapt it to apply on top of > > > > > "[PATCH v3 1/2] cli: Don't run early event loop if no --preconfig was specified" > > > > > with extra comment and massage commit message a little bit. > > > > > v6: > > > > > * hide os_setup_post_done flag inside of os_setup_post() as it was in v4 > > > > > > > > > > CC: berrange(a)redhat.com > > > > > CC: mreitz(a)redhat.com > > > > > CC: pbonzini(a)redhat.com > > > > > CC: ehabkost(a)redhat.com > > > > > CC: ldoktor(a)redhat.com > > > > > CC: eblake(a)redhat.com > > > > > --- > > > > > os-posix.c | 6 ++++++ > > > > > vl.c | 6 ++++++ > > > > > 2 files changed, 12 insertions(+) > > > > > > > > > > diff --git a/os-posix.c b/os-posix.c > > > > > index 9ce6f74..0246195 100644 > > > > > --- a/os-posix.c > > > > > +++ b/os-posix.c > > > > > @@ -309,8 +309,14 @@ void os_daemonize(void) > > > > > > > > > > void os_setup_post(void) > > > > > { > > > > > + static bool os_setup_post_done; > > > > > int fd = 0; > > > > > > > > > > + if (os_setup_post_done) { > > > > > + return; > > > > > + } > > > > > + os_setup_post_done = true; > > > > > + > > > > > if (daemonize) { > > > > > if (chdir("/")) { > > > > > error_report("not able to chdir to /: %s", strerror(errno)); > > > > > diff --git a/vl.c b/vl.c > > > > > index fa44138..457ff2a 100644 > > > > > --- a/vl.c > > > > > +++ b/vl.c > > > > > @@ -4578,6 +4578,12 @@ int main(int argc, char **argv, char **envp) > > > > > parse_numa_opts(current_machine); > > > > > > > > > > /* do monitor/qmp handling at preconfig state if requested */ > > > > > + if (!preconfig_exit_requested && is_daemonized()) { > > > > > + /* signal parent QEMU to exit, libvirt treats it as a sign > > > > > + * that monitor socket is ready to accept connections > > > > > + */ > > > > > + os_setup_post(); > > > > > + } > > > > > > > > I was looking at the daemonize logic, and noticed it we have a > > > > huge amount of code between this line and the next > > > > os_setup_post() call that could either: > > > > > > > > * call exit() and/or error_report(); or > > > logging would work to the extent mentioned in commit message, > > > i.e. it' would work fine when log file is used otherwise it > > > errors will go to /dev/null > > > > > > so it should be more or less fine on this point > > > > My worry is that most users of error_report() involve an exit() > > call too. > > > > Once we have an active monitor, we must never call exit() > > directly. Even qmp_quit() doesn't call exit() directly. > Is there any reason why exit() can't be called? QMP clients don't expect the QMP socket to be closed except when using the 'quit' command. > > > > > * be unable to finish machine initialization because of > > > > chdir("/"), change_root(), or change_process_uid(). > > > this one really no go. > > > I see 2 options here, > > > > > > * move init code that opens files to early stage (before preconfig monitor) > > > or split it to open files early. > > > (I've spotted several obvious places fwcfg/vnc/replay_start/migration) > > > but there might be code somewhere in callbacks that would do it too, > > > so it rather risky to go this route. > > > (I'd do this anyways one place at the time using sanitizing > > > initialization sequence pretext.) > > > > We might have QMP commands that take file paths as input, so is > > this really an option? > I'd think that in future we would want to enable object_add in preconfig > to create backends at runtime, so yes we can't do chroot at this point > > > > > * split out signaling part that tells parent process to exit into > > > separate helper that's called once before/from main_loop(). > > > This option seems low risk and additionally error output to > > > stderr will work as it does currently (until os_setup_post()) > > > > My assumption is that separating the chdir()/stdout/stderr logic > > from the fork/daemonize/exit steps wouldn't be possible without > > breaking expectations about -daemonize. > it's already separated and that's what creates one side of problem. Is it? Right now '$QEMU -daemonize' will never call exit(0) before the child process it spawned did the chdir()/stdout/stderr/etc trick. > What I suggest is to leave it as is and move out only > len = write(daemon_pipe, &status, 1); > part of os_setup_post() to sync with parent process. That shouldn't > affect daemonizing flow on QEMU side and would let libvirt reuse parent's > exit as sync point to detect moment when monitor is available. > (patch is in testing, I'll post it tomorrow if it doesn't break tests) This will affect the daemonizing flow, won't it? It will make QEMU exit(0) before the child does the chdir()/stderr/stdout/etc cleanup. A well-behaved daemon shouldn't do this. This is probably not a problem for libvirt (which only uses -daemonize as a sync point for QMP), but possibly a problem for other users of -daemonize. > > In worst case if we can't do the later in QEMU, mgmt would have to cope with > monitor in preconfig mode without relying on parent exit(0) sync point. > (a typical daemon would fork/chroot and co in one place and clients would use > other means to detect socket availability other than watching parent process > exiting) Do we really need to make -daemonize and -preconfig work together? libvirt uses -daemonize only for its initial capability probing, which shouldn't require -preconfig at all. Even on that case, I wonder why libvirt doesn't simply create a server socket and waits for QEMU to connect instead of using -daemonize as a sync point. -- Eduardo

5 10

[libvirt] Cannot find suitable emulator for x86_64
by Mathieu Tarral 14 Jun '18

14 Jun '18

Hi ! I'm trying to reproduce a bug that i'm facing with libvirt 3.0.0 on Debian stretch. I compiled the latest stable libvirt (4.4.0), and installed it: ./autogen.sh ./configure --prefix=$HOME/usr --localstatedir=/var make sudo make install But when i try to run ~/usr/bin/virsh version, it complains with this message: virsh # version Compiled against library: libvirt 4.4.0 Using library: libvirt 4.4.0 Using API: QEMU 4.4.0 error: failed to get the hypervisor version error: internal error: Cannot find suitable emulator for x86_64 This is what i can find in the output of ~/usr/sbin/libvirtd: 2018-06-13 11:30:17.361+0000: 27502: error : virCapabilitiesDomainDataLookupInternal:736 : invalid argument: could not find capabilities for arch=x86_64 domaintype=qemu 2018-06-13 11:30:17.361+0000: 27502: error : virQEMUCapsGetDefaultVersion:1455 : internal error: Cannot find suitable emulator for x86_64 My environment has not changed, QEMU is still installed. Can you help me understand what is wrong here ? Thank you in advance ! -- Mathieu Tarral

2 10

[libvirt] [PATCH] qemuxml2argvtest: Don't leak TPM unix path
by Michal Privoznik 14 Jun '18

14 Jun '18

When testing a domain XML with TPM we overwrite UNIX socket path to mimic what qemuTPMEmulatorPrepareHost() is doing (because *PrepareHost() functions are not called from the test). But we are not doing it fully - we need to set the chardev's type too so that virDomainTPMDefFree() can free the path. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tests/qemuxml2argvtest.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index f630185de1..daa8d4ceeb 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -551,9 +551,11 @@ testCompareXMLToArgv(const void *data) if (vm->def->tpm) { switch (vm->def->tpm->type) { case VIR_DOMAIN_TPM_TYPE_EMULATOR: + VIR_FREE(vm->def->tpm->data.emulator.source.data.file.path); if (VIR_STRDUP(vm->def->tpm->data.emulator.source.data.file.path, "/dev/test") < 0) goto cleanup; + vm->def->tpm->data.emulator.source.type = VIR_DOMAIN_CHR_TYPE_UNIX; break; case VIR_DOMAIN_TPM_TYPE_PASSTHROUGH: case VIR_DOMAIN_TPM_TYPE_LAST: -- 2.16.4

2 3

[libvirt] [PATCH] docs: fix some broken HTML links
by Katerina Koukiou 14 Jun '18

14 Jun '18

Replace name with id attribute in headers to fix the links. Signed-off-by: Katerina Koukiou <kkoukiou(a)redhat.com> --- docs/api_extension.html.in | 12 ++++++------ docs/dbus.html.in | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/docs/api_extension.html.in b/docs/api_extension.html.in index 9beec07602..41dd3573f5 100644 --- a/docs/api_extension.html.in +++ b/docs/api_extension.html.in @@ -103,7 +103,7 @@ <p>With that said, let's begin.</p> - <h2><a name='publicapi'>Defining the public API</a></h2> + <h2><a id='publicapi'>Defining the public API</a></h2> <p>The first task is to define the public API. If the new API involves an XML extension, you have to enhance the RelaxNG @@ -137,7 +137,7 @@ and <a href="api_extension/0002-add-new-public-API.patch">0002-add-new-public-API.patch</a> for example code.</p> - <h2><a name='internalapi'>Defining the internal API</a></h2> + <h2><a id='internalapi'>Defining the internal API</a></h2> <p> Each public API call is associated with a driver, such as a host @@ -166,7 +166,7 @@ <p class="example">See <a href="api_extension/0003-define-internal-driver-API.patch">0003-define-internal-driver-API.patch</a></p> - <h2><a name='implpublic'>Implementing the public API</a></h2> + <h2><a id='implpublic'>Implementing the public API</a></h2> <p> Implementing the public API is largely a formality in which we wire up @@ -201,7 +201,7 @@ <p class="example">See <a href="api_extension/0004-implement-the-public-APIs.patch">0004-implement-the-public-APIs.patch</a></p> - <h2><a name='remoteproto'>Implementing the remote protocol</a></h2> + <h2><a id='remoteproto'>Implementing the remote protocol</a></h2> <p> Implementing the remote protocol is essentially a @@ -213,7 +213,7 @@ <p class="example">See <a href="api_extension/0005-implement-the-remote-protocol.patch">0005-implement-the-remote-protocol.patch</a></p> - <h3><a name='wireproto'>Defining the wire protocol format</a></h3> + <h3><a id='wireproto'>Defining the wire protocol format</a></h3> <p> Defining the wire protocol involves making additions to: @@ -252,7 +252,7 @@ src/remote/remote_protocol.h </code></p> - <h3><a name='rpcclient'>Implement the RPC client</a></h3> + <h3><a id='rpcclient'>Implement the RPC client</a></h3> <p> Implementing the uses the rpcgen generated .h files. The remote diff --git a/docs/dbus.html.in b/docs/dbus.html.in index 6ff71d2770..4dfe4ca427 100644 --- a/docs/dbus.html.in +++ b/docs/dbus.html.in @@ -6,14 +6,14 @@ <ul id="toc"></ul> - <h2><a name="description">Description</a></h2> + <h2><a id="description">Description</a></h2> <p> libvirt-dbus wraps libvirt API to provide a high-level object-oriented API better suited for dbus-based applications. </p> - <h2><a name="git">GIT source repository</a></h2> + <h2><a id="git">GIT source repository</a></h2> <p> The D-Bus bindings source code is maintained in a <a href="https://git-scm.com/">git</a> repository available on @@ -32,7 +32,7 @@ git clone https://libvirt.org/git/libvirt-dbus.git <a href="https://libvirt.org/git/?p=libvirt-dbus.git">https://libvirt.org/git/?p=libvirt-dbus.git</a> </pre> - <h2><a name="usage">Usage</a></h2> + <h2><a id="usage">Usage</a></h2> <p> libvirt-dbus exports libvirt API using D-Bus objects with methods and -- 2.15.0

2 1

[libvirt] [PATCH] docs: schema: Add missing <interleave> element to input device
by Lily Zhu 14 Jun '18

14 Jun '18

Input device has 2 optional sub-elements - <alias> and <address> the order of which should be interchangeable in the XML. Signed-off-by: Lily Zhu <lizhu(a)redhat.com> --- docs/schemas/domaincommon.rng | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 1d06a5e..999b863 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -4309,12 +4309,14 @@ </element> </group> </choice> + <interleave> <optional> <ref name="alias"/> </optional> <optional> <ref name="address"/> </optional> + </interleave> </element> </define> <define name="hub"> -- 1.8.3.1

2 1

[libvirt] [PATCH] qemu: ignore query-sev-capabilities errors
by Ján Tomko 14 Jun '18

14 Jun '18

The query-sev-capabilities command fails if SEV is not compiled in, even though both the command and -object sev-guest are present in that case :/ Ignore the errors to avoid spamming the logs: internal error: unable to execute QEMU command 'query-sev-capabilities': SEV feature is not available Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/qemu/qemu_monitor_json.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index c5480a2d0e..aa89ea7056 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -6423,6 +6423,12 @@ qemuMonitorJSONGetSEVCapabilities(qemuMonitorPtr mon, if (qemuMonitorJSONCommand(mon, cmd, &reply) < 0) goto cleanup; + /* Both -object sev-guest and query-sev-capabilities can be present + * even if SEV is not available */ + if (qemuMonitorJSONHasError(reply, "GenericError")) { + ret = 0; + goto cleanup; + } if (qemuMonitorJSONCheckError(cmd, reply) < 0) goto cleanup; -- 2.16.1

4 3

[libvirt] [PATCH] virtportallocator: Change number of ports to 65536
by Pavel Hrdina 14 Jun '18

14 Jun '18

USHRT_MAX is not good enough because the value is 65535 which specifies the number of bits in bitmap. The allowed port range is 0-65535 so we need to increase the number. We could have USHRT_MAX + 1 but let's define the number explicitly. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1590214 Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/util/virportallocator.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/util/virportallocator.c b/src/util/virportallocator.c index 004a2dab81..db95a601c7 100644 --- a/src/util/virportallocator.c +++ b/src/util/virportallocator.c @@ -35,6 +35,8 @@ #define VIR_FROM_THIS VIR_FROM_NONE +#define VIR_PORT_ALLOCATOR_NUM_PORTS 65536 + typedef struct _virPortAllocator virPortAllocator; typedef virPortAllocator *virPortAllocatorPtr; struct _virPortAllocator { @@ -68,7 +70,7 @@ virPortAllocatorNew(void) if (!(pa = virObjectLockableNew(virPortAllocatorClass))) return NULL; - if (!(pa->bitmap = virBitmapNew(USHRT_MAX))) + if (!(pa->bitmap = virBitmapNew(VIR_PORT_ALLOCATOR_NUM_PORTS))) goto error; return pa; -- 2.17.1

2 1

[libvirt] [PATCH 00/10] SEV: use camelCase in XMLs and other cleanups
by Ján Tomko 14 Jun '18

14 Jun '18

The first two patches tune up the XML elements to use camelCase instead of dashes as the word separators. Hopefully our QEMU capability probing is right and we can fix error reporting in patch 3. The rest are minor cleanups and renames to use SEV instead of Sev in internal identifier names. I did not touch virNodeGetSevInfoEnsureACL - not sure if it's all right since the public API uses SEV. Ján Tomko (10): domaincaps: rename reduced-phys-bits to reducedPhysBits conf: prefer camelCase for launchSecurity qemu: fail if virQEMUCapsProbeQMPSEVCapabilities fails remove virQEMUCapsSetSEVCapabilities qemuDomainGetSEVMeasurement: fix possible leak rename qemuBuildSevCreateFile to qemuProcessSEVCreateFile qemuProcessSEVCreateFile: use a cleanup label Rename virDomainSevDefPtr to virDomainSEVDefPtr rename more Sev functions to SEV qemuMonitorJSONGetSEVCapabilities: remove redundant whitespace docs/formatdomain.html.in | 22 +++++++-------- docs/formatdomaincaps.html.in | 2 +- docs/schemas/domaincaps.rng | 2 +- docs/schemas/domaincommon.rng | 10 +++---- src/conf/domain_capabilities.c | 2 +- src/conf/domain_conf.c | 32 +++++++++++----------- src/conf/domain_conf.h | 8 +++--- src/qemu/qemu_capabilities.c | 16 ++--------- src/qemu/qemu_command.c | 6 ++-- src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_monitor_json.c | 1 - src/qemu/qemu_process.c | 26 ++++++++---------- tests/genericxml2xmlindata/launch-security-sev.xml | 8 +++--- tests/qemuxml2argvdata/launch-security-sev.xml | 8 +++--- 14 files changed, 66 insertions(+), 79 deletions(-) -- 2.16.1

3 23

[libvirt] [PATCH v2 0/1] qemu: add entry for balloon stat stat-disk-caches
by Tomáš Golembiovský 13 Jun '18

13 Jun '18

v2: - moved item to last position in array - documented item also in libvirt-domain.c - added item to virsh listing Tomáš Golembiovský (1): qemu: add entry for balloon stat stat-disk-caches include/libvirt/libvirt-domain.h | 9 ++++++++- src/libvirt-domain.c | 3 +++ src/qemu/qemu_monitor_json.c | 2 ++ tools/virsh-domain-monitor.c | 2 ++ 4 files changed, 15 insertions(+), 1 deletion(-) -- 2.17.0

2 2

[libvirt] [RFC v3] external (pull) backup API
by Eric Blake 13 Jun '18

13 Jun '18

Here's my updated counterproposal for a backup API. In comparison to v2 posted by Nikolay: https://www.redhat.com/archives/libvir-list/2018-April/msg00115.html - changed terminology a bit: Nikolay's "BlockSnapshot" is now called a "Checkpoint", and "BlockExportStart/Stop" is now "BackupBegin/End" - flesh out more API descriptions - better documentation of proposed XML, for both checkpoints and backup Barring any major issues turned up during review, I've already starting to code this into libvirt with a goal of getting an implementation ready for review this month. Each domain will gain the ability to track a tree of Checkpoint objects (we've previously mentioned the term "system checkpoint" in the <domainsnapshot> XML as the combination of disk and RAM state; so I'll use the term "disk checkpoint" in prose as needed, to make it obvious that the checkpoints described here do not include RAM state). I will use the virDomainSnapshot API as a guide, meaning that we will track a tree of checkpoints where each checkpoint can have 0 or 1 parent checkpoints, in part because I plan to reuse a lot of the snapshot code as a starting point for implementing checkpoint tracking. Qemu does NOT track a relationship between internal snapshots, so libvirt has to manage the backing tree all by itself; by the same argument, if qemu does not add a parent relationship to dirty bitmaps, libvirt can probably manage everything itself by copying how it manages parent relationships between internal snapshots. However, I think it will be far easier for libvirt to exploit qemu dirty bitmaps if qemu DOES add bitmap tracking; particularly if qemu adds ways to easily compose a temporary bitmap that is the union of one bitmap plus a fixed number of its parents. Design-wise, libvirt will manage things so that there is only one enabled dirty-bitmap per qcow2 image at a time, when no backup operation is in effect. There is a notion of a current (or most recent) checkpoint; when a new checkpoint is created, that becomes the current one and the former checkpoint becomes the parent of the new one. If there is no current checkpoint, then there is no active dirty bitmap managed by libvirt. Representing things on a timeline, when a guest is first created, there is no dirty bitmap; later, the checkpoint "check1" is created, which in turn creates "bitmap1" in the qcow2 image for all changes past that point; when a second checkmark "check2" is created, a qemu transaction is used to create and enable the new "bitmap2" bitmap at the same time as disabling "bitmap1" bitmap. (Actually, it's probably easier to name the bitmap in the qcow2 file with the same name as the Checkpoint object being tracked in libvirt, but for discussion purposes, it's less confusing if I use separate names for now.) creation ....... check1 ....... check2 ....... active no bitmap bitmap1 bitmap2 When a user wants to create a backup, they select which point in time the backup starts from; the default value NULL represents a full backup (all content since disk creation to the point in time of the backup call, no bitmap is needed, use sync=full for push model or sync=none for the pull model); any other value represents the name of a checkpoint to use as an incremental backup (all content from the checkpoint to the point in time of the backup call; libvirt forms a temporary bitmap as needed, the uses sync=incremental for push model or sync=none plus exporting the bitmap for the pull model). For example, requesting an incremental backup from "check2" can just reuse "bitmap2", but requesting an incremental backup from "check1" requires the computation of the bitmap containing the union of "bitmap1" and "bitmap2". Libvirt will always create a new bitmap when starting a backup operation, whether or not the user requests that a checkpoint be created. Most users that want incremental backup sequences will create a new checkpoint every time they do a backup; the new bitmap that libvirt creates is then associated with that new checkpoint, and even after the backup operation completes, the new bitmap remains in the qcow2 file. But it is also possible to request a backup without a new checkpoint (it merely means that it is not possible to create a subsequent incremental backup from the backup just started); in that case, libvirt will have to take care of merging the new bitmap back into the previous one at the end of the backup operation. I think that it should be possible to run multiple backup operations in parallel in the long run. But in the interest of getting a proof of concept implementation out quickly, it's easier to state that for the initial implementation, libvirt supports at most one backup operation at a time (to do another backup, you have to wait for the current one to complete, or else abort and abandon the current one). As there is only one backup job running at a time, the existing virDomainGetJobInfo()/virDomainGetJobStats() will be able to report statistics about the job (insofar as such statistics are available). But in preparation for the future, when libvirt does add parallel job support, starting a backup job will return a job id; and presumably we'd add a new virDomainGetJobStatsByID() for grabbing statistics of an arbitrary (rather than the most-recently-started) job. Since live migration also acts as a job visible through virDomainGetJobStats(), I'm going to treat an active backup job and live migration as mutually exclusive. This is particularly true when we have a pull model backup ongoing: if qemu on the source is acting as an NBD server, you can't migrate away from that qemu and tell the NBD client to reconnect to the NBD server on the migration destination. So, to perform a migration, you have to cancel any pending backup operations. Conversely, if a migration job is underway, it will not be possible to start a new backup job until migration completes. However, we DO need to modify migration to ensure that any persistent bitmaps are migrated. I also think that in the long run, it should be possible to start a backup operation, and while it is still ongoing, create a new external snapshot, and still be able to coordinate the transfer of bitmaps from the old image to the new overlay. But for the first implementation, it's probably easiest to state that an ongoing backup prevents creation of a new snapshot. However, a current checkpoint (which means we DO have an active bitmap, even if there is no active backup) DOES need to be transfered to the new overlay, and conversely, a block commit job needs to merge all bitmaps from the old overlay to the backing file that is now becoming the active layer again. I don't know if qemu has primitives for this in place yet; and if it does not, the only conservative thing we can do in the initial implementation is to state that the use of checkpoints is exclusive from the use of snapshots (using one prevents the use of the other). Hopefully we don't have to stay in that state for long. For now, a user wanting guest I/O to be at a safe point can manually use virDomainFSFreeze()/virDomainBackupBegin()/virDomainFSThaw(); we may decide down the road to use the flags argument of virDomainBackupBegin() to provide automatic guest quiescing through one API (I'm not doing it right away, because we have to worry about undoing effects if we fail to thaw after starting the backup). So, to summarize, creating a backup will involve the following new APIs: /** * virDomainBackupBegin: * @domain: a domain object * @diskXml: description of storage to utilize and expose during * the backup, or NULL * @checkpointXml: description of a checkpoint to create, or NULL * @flags: not used yet, pass 0 * * Start a point-in-time backup job for the specified disks of a * running domain. * * A backup job is mutually exclusive with domain migration * (particularly when the job sets up an NBD export, since it is not * possible to tell any NBD clients about a server migrating between * hosts). For now, backup jobs are also mutually exclusive with any * other block job on the same device, although this restriction may * be lifted in a future release. Progress of the backup job can be * tracked via virDomainGetJobStats(). The job remains active until a * subsequent call to virDomainBackupEnd(), even if it no longer has * anything to copy. * * There are two fundamental backup approaches. The first, called a * push model, instructs the hypervisor to copy the state of the guest * disk to the designated storage destination (which may be on the * local file system or a network device); in this mode, the * hypervisor writes the content of the guest disk to the destination, * then emits VIR_DOMAIN_EVENT_ID_BLOCK_JOB_2 when the backup is * either complete or failed (the backup image is invalid if the job * is ended prior to the event being emitted). The second, called a * pull model, instructs the hypervisor to expose the state of the * guest disk over an NBD export; a third-party client can then * connect to this export, and read whichever portions of the disk it * desires. In this mode, there is no event; libvirt has to be * informed when the third-party NBD client is done and the backup * resources can be released. * * The @diskXml parameter is optional but usually provided, and * contains details about the backup, including which backup mode to * use, whether the backup is incremental from a previous checkpoint, * which disks participate in the backup, the destination for a push * model backup, and the temporary storage and NBD server details for * a pull model backup. If omitted, the backup attempts to default to * a push mode full backup of all disks, where libvirt generates a * filename for each disk by appending a suffix of a timestamp in * seconds since the Epoch. virDomainBackupGetXMLDesc() can be called * to actual values selected. For more information, see * formatcheckpoint.html#BackupAttributes. * * The @checkpointXml parameter is optional; if non-NULL, then libvirt * behaves as if virDomainCheckpointCreateXML() were called with * @checkpointXml, atomically covering the same guest state that will * be part of the backup. The creation of a new checkpoint allows for * future incremental backups. * * Returns a non-negative job id on success, or negative on failure. * This operation returns quickly, such that a user can choose to * start a backup job between virDomainFSFreeze() and * virDomainFSThaw() in order to create the backup while guest I/O is * quiesced. */ int virDomainBackupBegin(virDomainPtr domain, const char *diskXml, const char *checkpointXml, unsigned int flags); Note that this layout says that all disks participating in the backup job have share the same incremental checkpoint as their starting point (no way to have one backup job where disk A copies data since check1 while disk B copies data since check2). If we need the latter, then we could get rid of the 'incremental' parameter, and instead have each <disk> element within checkpointXml all out an optional <checkpoint> name as its starting point. Also, qemu supports exposing multiple disks through a single NBD server (you then connect multiple clients to the one server to grab state from each disk). So the NBD details are listed in parallel to the <disks>. Note that since a backup is NOT a guest-visible action, the backup job does not alter the normal <domain> XML. /** * virDomainBackupGetXMLDesc: * @domain: a domain object * @id: the id of an active backup job previously started with * virDomainBackupBegin() * @flags: not used yet, pass 0 * * In some cases, a user can start a backup job without supplying all * details, and rely on libvirt to fill in the rest (for example, * selecting the port used for an NBD export). This API can then be * used to learn what default values were chosen. * * Returns a NUL-terminated UTF-8 encoded XML instance, or NULL in * case of error. The caller must free() the returned value. */ char * virDomainBackupGetXMLDesc(virDomainPtr domain, int id, unsigned int flags); /** * virDomainBackupEnd: * @domain: a domain object * @id: the id of an active backup job previously started with * virDomainBackupBegin() * @flags: bitwise-OR of supported virDomainBackupEndFlags * * Conclude a point-in-time backup job @id on the given domain. * * If the backup job uses the push model, but the event marking that * all data has been copied has not yet been emitted, then the command * fails unless @flags includes VIR_DOMAIN_BACKUP_END_ABORT. If the * event has been issued, or if the backup uses the pull model, the * flag has no effect. * * Returns 0 on success and -1 on failure. */ int virDomainBackupEnd(virDomainPtr domain, int id, unsigned int flags); /** * virDomainCheckpointCreateXML: * @domain: a domain object * @xmlDesc: description of the checkpoint to create * @flags: bitwise-OR of supported virDomainCheckpointCreateFlags * * Create a new checkpoint using @xmlDesc on a running @domain. * Typically, it is more common to create a new checkpoint as part of * kicking off a backup job with virDomainBackupBegin(); however, it * is also possible to start a checkpoint without a backup. * * See formatcheckpoint.html#CheckpointAttributes document for more * details on @xmlDesc. * * If @flags includes VIR_DOMAIN_CHECKPOINT_CREATE_REDEFINE, then this * is a request to reinstate checkpoint metadata that was previously * discarded, rather than creating a new checkpoint. When redefining * checkpoint metadata, the current checkpoint will not be altered * unless the VIR_DOMAIN_CHECKPOINT_CREATE_CURRENT flag is also * present. It is an error to request the * VIR_DOMAIN_CHECKPOINT_CREATE_CURRENT flag without * VIR_DOMAIN_CHECKPOINT_CREATE_REDEFINE. * * If @flags includes VIR_DOMAIN_CHECKPOINT_CREATE_NO_METADATA, then * the domain's disk images are modified according to @xmlDesc, but * then the just-created checkpoint has its metadata deleted. This * flag is incompatible with VIR_DOMAIN_CHECKPOINT_CREATE_REDEFINE. * * Returns an (opaque) new virDomainCheckpointPtr on success, or NULL * on failure. */ virDomainCheckpointPtr virDomainCheckpointCreateXML(virDomainPtr domain, const char *xmlDesc, unsigned int flags); /** * virDomainCheckpointDelete: * @checkpoint: the checkpoint to remove * @flags: not used yet, pass 0 * @flags: bitwise-OR of supported virDomainCheckpointDeleteFlags * * Removes a checkpoint from the domain. * * When removing a checkpoint, the record of which portions of the * disk were dirtied after the checkpoint will be merged into the * record tracked by the parent checkpoint, if any. Likewise, if the * checkpoint being deleted was the current checkpoint, the parent * checkpoint becomes the new current checkpoint. * * If @flags includes VIR_DOMAIN_CHECKPOINT_DELETE_METADATA_ONLY, then * any checkpoint metadata tracked by libvirt is removed while keeping * the checkpoint contents intact; if a hypervisor does not require * any libvirt metadata to track checkpoints, then this flag is * silently ignored. * * Returns 0 on success, -1 on error. */ int virDomainCheckpointDelete(virDomainCheckpointPtr checkpoint, unsigned int flags); // Many additional functions copying heavily from virDomainSnapshot*: virDomainCheckpointList(virDomainPtr domain, virDomainCheckpointPtr **checkpoints, unsigned int flags); virDomainCheckpointGetXMLDesc(virDomainCheckpointPtr checkpoint, unsigned int flags); virDomainCheckpointPtr virDomainCheckpointLookupByName(virDomainPtr domain, const char *name, unsigned int flags); const char * virDomainCheckpointGetName(virDomainCheckpointPtr checkpoint); virDomainPtr virDomainCheckpointGetDomain(virDomainCheckpointPtr checkpoint); virConnectPtr virDomainCheckpointGetConnect(virDomainCheckpointPtr checkpoint); int virDomainHasCurrentCheckpoint(virDomainPtr domain, unsigned int flags); virDomainCheckpointPtr virDomainCheckpointCurrent(virDomainPtr domain, unsigned int flags); virDomainCheckpointPtr virDomainCheckpointGetParent(virDomainCheckpointPtr checkpoint, unsigned int flags); int virDomainCheckpointIsCurrent(virDomainCheckpointPtr checkpoint, unsigned int flags); int virDomainCheckpointRef(virDomainCheckpointPtr checkpoint); int virDomainCheckpointFree(virDomainCheckpointPtr checkpoint); int virDomainCheckpointListChildren(virDomainCheckpointPtr checkpoint, virDomainCheckpointPtr **children, unsigned int flags); Notably, none of the older racy list functions, like virDomainSnapshotNum, virDomainSnapshotNumChildren, or virDomainSnapshotListChildrenNames; also, for now, there is no revert support like virDomainSnapshotRevert. Eventually, if we add a way to roll back to the state recorded in an earlier bitmap, we'll want to tell libvirt that it needs to create a new bitmap as a child of an existing (non-current) checkpoint. That is, if we have: check1 .... check2 .... active bitmap1 bitmap2 and created a backup at the same time as check2, then when we later roll back to the state of that backup, we would want to end writes to bitmap2 and declare that check2 is no longer current, and create a new current check3 with associated bitmap3 and parent check1 to track all writes since the point of the revert. Until then, I don't think it's possible to have more than one child without manually using the REDEFINE flag to create such scenarios; but the API should not lock us out of supporting multiple children in the future. Here's my proposal for user-facing XML documentation, based on formatsnapshot.html.in: <?xml version="1.0" encoding="UTF-8"?> <!DOCTYPE html> <html xmlns="http://www.w3.org/1999/xhtml"> <body> <h1>Checkpoint and Backup XML format</h1> <ul id="toc"></ul> <h2><a id="CheckpointAttributes">Checkpoint XML</a></h2> <p> Libvirt is able to facilitate incremental backups by tracking disk checkpoints, or points in time against which it is easy to compute which portion of the disk has changed. Given a full backup (a backup created from the creation of the disk to a given point in time, coupled with the creation of a disk checkpoint at that time), and an incremental backup (a backup created from just the dirty portion of the disk between the first checkpoint and the second backup operation), it is possible to do an offline reconstruction of the state of the disk at the time of the second backup, without having to copy as much data as a second full backup would require. Most disk checkpoints are created in concert with a backup, via <code>virDomainBackupBegin()</code>; however, libvirt also exposes enough support to create disk checkpoints independently from a backup operation, via <code>virDomainCheckpointCreateXML()</code>. </p> <p> Attributes of libvirt checkpoints are stored as child elements of the <code>domaincheckpoint</code> element. At checkpoint creation time, normally only the <code>name</code>, <code>description</code>, and <code>disks</code> elements are settable; the rest of the fields are ignored on creation, and will be filled in by libvirt in for informational purposes by <code>virDomainCheckpointGetXMLDesc()</code>. However, when redefining a checkpoint, with the <code>VIR_DOMAIN_CHECKPOINT_CREATE_REDEFINE</code> flag of <code>virDomainCheckpointCreateXML()</code>, all of the XML described here is relevant. </p> <p> Checkpoints are maintained in a hierarchy. A domain can have a current checkpoint, which is the most recent checkpoint compared to the current state of the domain (although a domain might have checkpoints without a current checkpoint, if checkpoints have been deleted in the meantime). Creating or reverting to a checkpoint sets that checkpoint as current, and the prior current checkpoint is the parent of the new checkpoint. Branches in the hierarchy can be formed by reverting to a checkpoint with a child, then creating another checkpoint. </p> <p> The top-level <code>domaincheckpoint</code> element may contain the following elements: </p> <dl> <dt><code>name</code></dt> <dd>The name for this checkpoint. If the name is specified when initially creating the checkpoint, then the checkpoint will have that particular name. If the name is omitted when initially creating the checkpoint, then libvirt will make up a name for the checkpoint, based on the time when it was created. </dd> <dt><code>description</code></dt> <dd>A human-readable description of the checkpoint. If the description is omitted when initially creating the checkpoint, then this field will be empty. </dd> <dt><code>disks</code></dt> <dd>On input, this is an optional listing of specific instructions for disk checkpoints; it is needed when making a checkpoint on only a subset of the disks associated with a domain (in particular, since qemu checkpoints require qcow2 disks, this element may be needed on input for excluding guest disks that are not in qcow2 format); if omitted on input, then all disks participate in the checkpoint. On output, this is fully populated to show the state of each disk in the checkpoint. This element has a list of <code>disk</code> sub-elements, describing anywhere from one to all of the disks associated with the domain. <dl> <dt><code>disk</code></dt> <dd>This sub-element describes the checkpoint properties of a specific disk. The attribute <code>name</code> is mandatory, and must match either the <code><target dev='name'/></code> or an unambiguous <code><source file='name'/></code> of one of the <a href="formatdomain.html#elementsDisks">disk devices</a> specified for the domain at the time of the checkpoint. The attribute <code>checkpoint</code> is optional on input; possible values are <code>no</code> when the disk does not participate in this checkpoint; or <code>bitmap</code> if the disk will track all changes since the creation of this checkpoint via a bitmap, in which case another attribute <code>bitmap</code> will be the name of the tracking bitmap (defaulting to the checkpoint name). </dd> </dl> </dd> <dt><code>creationTime</code></dt> <dd>The time this checkpoint was created. The time is specified in seconds since the Epoch, UTC (i.e. Unix time). Readonly. </dd> <dt><code>parent</code></dt> <dd>The parent of this checkpoint. If present, this element contains exactly one child element, name. This specifies the name of the parent checkpoint of this one, and is used to represent trees of checkpoints. Readonly. </dd> <dt><code>domain</code></dt> <dd>The inactive <a href="formatdomain.html">domain configuration</a> at the time the checkpoint was created. Readonly. </dd> </dl> <h2><a id="BackupAttributes">Backup XML</a></h2> <p> Creating a backup, whether full or incremental, is done via <code>virDomainBackupBegin()</code>, which takes an XML description of the actions to perform. There are two general modes for backups: a push mode (where the hypervisor writes out the data to the destination file, which may be local or remote), and a pull mode (where the hypervisor creates an NBD server that a third-party client can then read as needed, and which requires the use of temporary storage, typically local, until the backup is complete). </p> <p> The instructions for beginning a backup job are provided as attributes and elements of the top-level <code>domainbackup</code> element. This element includes an optional attribute <code>mode</code> which can be either "push" or "pull" (default push). Where elements are optional on creation, <code>virDomainBackupGetXMLDesc()</code> can be used to see the actual values selected (for example, learning which port the NBD server is using in the pull model, or what file names libvirt generated when none were supplied). The following child elements are supported: </p> <dl> <dt><code>incremental</code></dt> <dd>Optional. If this element is present, it must name an existing checkpoint of the domain, which will be used to make this backup an incremental one (in the push model, only changes since the checkpoint are written to the destination; in the pull model, the NBD server uses the NBD_OPT_SET_META_CONTEXT extension to advertise to the client which portions of the export contain changes since the checkpoint). If omitted, a full backup is performed. </dd> <dt><code>server</code></dt> <dd>Present only for a pull mode backup. Contains the same attributes as the <code>protocol</code> element of a disk attached via NBD in the domain (such as transport, socket, name, port, or tls), necessary to set up an NBD server that exposes the content of each disk at the time the backup started. </dd> <dt><code>disks</code></dt> <dd>This is an optional listing of instructions for disks participating in the backup (if omitted, all disks participate, and libvirt attempts to generate filenames by appending the current timestamp as a suffix). When provided on input, disks omitted from the list do not participate in the backup. On output, the list is present but contains only the disks participating in the backup job. This element has a list of <code>disk</code> sub-elements, describing anywhere from one to all of the disks associated with the domain. <dl> <dt><code>disk</code></dt> <dd>This sub-element describes the checkpoint properties of a specific disk. The attribute <code>name</code> is mandatory, and must match either the <code><target dev='name'/></code> or an unambiguous <code><source file='name'/></code> of one of the <a href="formatdomain.html#elementsDisks">disk devices</a> specified for the domain at the time of the checkpoint. The optional attribute <code>type</code> can be <code>file</code>, <code>block</code>, or <code>networks</code>, similar to a disk declaration for a domain, controls what additional sub-elements are needed to describe the destination (such as <code>protocol</code> for a network destination). In push mode backups, the primary subelement is <code>target</code>; in pull mode, the primary sublement is <code>scratch</code>; but either way, the primary sub-element describes the file name to be used during the backup operation, similar to the <code>source</code> sub-element of a domain disk. An optional sublement <code>driver</code> can also be used to specify a destination format different from qcow2. </dd> </dl> </dd> </dl> <h2><a id="example">Examples</a></h2> <p>Using this XML to create a checkpoint of just vda on a qemu domain with two disks and a prior checkpoint:</p> <pre> <domaincheckpoint> <description>Completion of updates after OS install</description> <disks> <disk name='vda' checkpoint='bitmap'/> <disk name='vdb' checkpoint='no'/> </disks> </domaincheckpoint></pre> <p>will result in XML similar to this from <code>virDomainCheckpointGetXMLDesc()</code>:</p> <pre> <domaincheckpoint> <name>1525889631</name> <description>Completion of updates after OS install</description> <creationTime>1525889631</creationTime> <parent> <name>1525111885</name> </parent> <disks> <disk name='vda' checkpoint='bitmap' bitmap='1525889631'/> <disk name='vdb' checkpoint='no'/> </disks> <domain> <name>fedora</name> <uuid>93a5c045-6457-2c09-e56c-927cdf34e178</uuid> <memory>1048576</memory> ... <devices> <disk type='file' device='disk'> <driver name='qemu' type='qcow2'/> <source file='/path/to/file1'/> <target dev='vda' bus='virtio'/> </disk> <disk type='file' device='disk' snapshot='external'> <driver name='qemu' type='raw'/> <source file='/path/to/file2'/> <target dev='vdb' bus='virtio'/> </disk> ... </devices> </domain> </domaincheckpoint></pre> <p>With that checkpoint created, the qcow2 image is now tracking all changes that occur in the image since the checkpoint via the persistent bitmap named <code>1525889631</code>. Now, we can make a subsequent call to <code>virDomainBackupBegin()</code> to perform an incremental backup of just this data, using the following XML to start a pull model NBD export of the vda disk: </p> <pre> <domainbackup mode="pull"> <incremental>1525889631</incremental> <server transport="unix" socket="/path/to/server"/> <disks/> <disk name='vda' type='file'/> <scratch file=/path/to/file1.scratch'/> </disk> </disks/> </domainbackup> </pre> </body> </html> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org

4 10

[libvirt] [PATCH 0/3] travis: Use pre-built Docker images
by Andrea Bolognani 13 Jun '18

13 Jun '18

Applies on top of https://www.redhat.com/archives/libvir-list/2018-June/msg00579.html See patch 2/3 for more information. Andrea Bolognani (3): travis: Drop Ubuntu 16.04 build travis: Use pre-built Docker image travis: Add CentOS 7 build .travis.yml | 77 +++-------------------------------------------------- 1 file changed, 3 insertions(+), 74 deletions(-) -- 2.17.1

2 7

[libvirt] [RFC v2 0/4] LXC with block device and enabled userns
by Radostin Stoyanov 13 Jun '18

13 Jun '18

Hi all, This patch series aims to resolve https://bugzilla.redhat.com/show_bug.cgi?id=1328946 For background information about the issue see v1 of this RFC. https://www.redhat.com/archives/libvir-list/2018-April/msg01270.html The current state of this series enables the start of LXC container with NBD file system and enabled user namespace. However, container shutdown causes "kernel BUG at fs/buffer.c:3058!" https://pastebin.com/raw/y0ycSM0H The reason for this is because qemu-nbd process is terminated/killed without unmounting the container root file system. This issue has been reported in [1] and [2]. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1356110 [2] http://lkml.iu.edu/hypermail/linux/kernel/1509.3/00027.html As a workaround we could unmount the root file system of container before shutdown. For example with: $ CT_PID=$(pidof libvirt_lxc) $ sudo nsenter \ --mount=/proc/$CT_PID/task/$CT_PID/ns/mnt \ /bin/bash -c "umount /var/run/libvirt/lxc/guest.root/" I noticed that we already have the functions lxcContainerUnmountSubtree and virProcessRunInMountNamespace. Any suggestions on how to properly implement this? Thanks, Radostin Stoyanov (4): lxc: Make lxcContainerMountFSBlock non static lxc: Move up virLXCControllerAppendNBDPids lxc: Mount NBD devices before clone lxc: Remove unused lxcContainerPrepareRoot src/lxc/lxc_container.c | 58 +------------- src/lxc/lxc_container.h | 4 + src/lxc/lxc_controller.c | 158 +++++++++++++++++++++++---------------- 3 files changed, 97 insertions(+), 123 deletions(-) -- 2.17.1

2 7

[libvirt] virsh start/list hangs
by Bo YU 13 Jun '18

13 Jun '18

Hello, The libvirt is a cool tool, i like it. But, i have some question to ask. First, i install libvirt-dev virtinst libvirt-daemon libvirt-daemon-system using debian-apt.It works for me a long time.But, i wanted to modify rx_queue_size in net(maybe controled by qemu).So, i git clone libvirt https://libvirt.org/git/?p=libvirt.git;a=summary and make && make install.Maybe you know, i made a mistake meanwhile, i forget delete libvirt relative package from apt(debian). According to error hint, i delete some file and directory :( Then i think out to apt remove : libvirt-dev virtinst libvirt-daemon libvirt-daemon-system It seems look good.But, libvirt does not work at all. The step reproduce is: ```c ./autogen.sh --system make -j4 make install ``` whereis virsh virsh: /usr/bin/virsh /usr/share/man/man1/virsh.1 whereis libvirtd libvirtd: /usr/sbin/libvirtd /usr/share/man/man8/libvirtd.8 sudo ps u -C libvirtd USER PID %CPU %MEM VSZ RSS TTY STAT START TIME COMMAND root 30699 0.0 0.4 483404 17336 ? Sl 10:27 0:00 libvirtd -d uname-r: 4.9.0-3-amd64 lsb_release -a No LSB modules are available. Distributor ID:DebianDescription:Debian GNU/Linux 9.4 (stretch) Release:9.4 Codename:stretch But, if i type ``sudo virsh version`` it hangs.Or ``sudo virsh list`` it hangs too. I deleted some libary file in /lib or somewhere.Maybe? But, i reproduce the trouble on another debian OS without libary. It looks like only you if install libvirt before you will get some troubles then you compile it from source code.Right? Thanks in advance! Here is output of strace: execve("/usr/bin/virsh", ["virsh", "list"], [/* 50 vars */]) = 0 brk(NULL) = 0x55875027f000 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) mmap(NULL, 12288, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efecd633000 access("/etc/ld.so.preload", R_OK) = -1 ENOENT (No such file or directory) open("/etc/ld.so.cache", O_RDONLY|O_CLOEXEC) = 3 fstat(3, {st_mode=S_IFREG|0644, st_size=115763, ...}) = 0 mmap(NULL, 115763, PROT_READ, MAP_PRIVATE, 3, 0) = 0x7efecd616000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/usr/lib/libvirt-lxc.so.0", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\240\17\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0755, st_size=85072, ...}) = 0 mmap(NULL, 2109488, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efecd20f000 mprotect(0x7efecd212000, 2093056, PROT_NONE) = 0 mmap(0x7efecd411000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x2000) = 0x7efecd411000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/usr/lib/libvirt-qemu.so.0", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\220\v\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0755, st_size=82544, ...}) = 0 mmap(NULL, 2109488, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efecd00b000 mprotect(0x7efecd00d000, 2097152, PROT_NONE) = 0 mmap(0x7efecd20d000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x2000) = 0x7efecd20d000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/usr/lib/libvirt.so.0", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\240\304\7\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0755, st_size=15737592, ...}) = 0 mmap(NULL, 5757216, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efecca8d000 mprotect(0x7efeccdf3000, 2093056, PROT_NONE) = 0 mmap(0x7efeccff2000, 98304, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x365000) = 0x7efeccff2000 mmap(0x7efecd00a000, 2336, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7efecd00a000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/usr/lib/x86_64-linux-gnu/libyajl.so.2", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0p\22\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=39200, ...}) = 0 mmap(NULL, 2134264, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efecc883000 mprotect(0x7efecc88c000, 2093056, PROT_NONE) = 0 mmap(0x7efecca8b000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x8000) = 0x7efecca8b000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/usr/local/lib/libnl-route-3.so.200", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0@w\1\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0755, st_size=1846248, ...}) = 0 mmap(NULL, 2494528, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efecc621000 mprotect(0x7efecc67a000, 2093056, PROT_NONE) = 0 mmap(0x7efecc879000, 28672, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x58000) = 0x7efecc879000 mmap(0x7efecc880000, 8256, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7efecc880000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/usr/local/lib/libnl-3.so.200", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\260\204\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0755, st_size=489088, ...}) = 0 mmap(NULL, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efecd614000 mmap(NULL, 2222248, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efecc402000 mprotect(0x7efecc41f000, 2093056, PROT_NONE) = 0 mmap(0x7efecc61e000, 12288, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x1c000) = 0x7efecc61e000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libpthread.so.0", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0Pa\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0755, st_size=135440, ...}) = 0 mmap(NULL, 2212936, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efecc1e5000 mprotect(0x7efecc1fd000, 2093056, PROT_NONE) = 0 mmap(0x7efecc3fc000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x17000) = 0x7efecc3fc000 mmap(0x7efecc3fe000, 13384, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7efecc3fe000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libm.so.6", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\3\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\200V\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=1063328, ...}) = 0 mmap(NULL, 3158248, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efecbee1000 mprotect(0x7efecbfe4000, 2093056, PROT_NONE) = 0 mmap(0x7efecc1e3000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x102000) = 0x7efecc1e3000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libdevmapper.so.1.02.1", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0000\261\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=341688, ...}) = 0 mmap(NULL, 2441040, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efecbc8d000 mprotect(0x7efecbcdd000, 2093056, PROT_NONE) = 0 mmap(0x7efecbedc000, 16384, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x4f000) = 0x7efecbedc000 mmap(0x7efecbee0000, 3920, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7efecbee0000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/usr/lib/x86_64-linux-gnu/libnuma.so.1", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\00003\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=44192, ...}) = 0 mmap(NULL, 2140320, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efecba82000 mprotect(0x7efecba8c000, 2093056, PROT_NONE) = 0 mmap(0x7efecbc8b000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x9000) = 0x7efecbc8b000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/usr/lib/x86_64-linux-gnu/libsasl2.so.2", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\360-\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=109296, ...}) = 0 mmap(NULL, 2204648, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efecb867000 mprotect(0x7efecb881000, 2093056, PROT_NONE) = 0 mmap(0x7efecba80000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x19000) = 0x7efecba80000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libselinux.so.1", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0000k\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=155400, ...}) = 0 mmap(NULL, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efecd612000 mmap(NULL, 2259664, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efecb63f000 mprotect(0x7efecb664000, 2093056, PROT_NONE) = 0 mmap(0x7efecb863000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x24000) = 0x7efecb863000 mmap(0x7efecb865000, 6864, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7efecb865000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libdbus-1.so.3", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\20\324\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=325776, ...}) = 0 mmap(NULL, 2421424, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efecb3ef000 mprotect(0x7efecb43c000, 2097152, PROT_NONE) = 0 mmap(0x7efecb63c000, 12288, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x4d000) = 0x7efecb63c000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/usr/lib/x86_64-linux-gnu/libssh2.so.1", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\200L\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=179480, ...}) = 0 mmap(NULL, 2274552, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efecb1c3000 mprotect(0x7efecb1ee000, 2093056, PROT_NONE) = 0 mmap(0x7efecb3ed000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x2a000) = 0x7efecb3ed000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/usr/lib/x86_64-linux-gnu/libgnutls.so.30", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0@\275\2\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=1670752, ...}) = 0 mmap(NULL, 3771208, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efecae2a000 mprotect(0x7efecafb4000, 2097152, PROT_NONE) = 0 mmap(0x7efecb1b4000, 57344, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x18a000) = 0x7efecb1b4000 mmap(0x7efecb1c2000, 2888, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7efecb1c2000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/usr/lib/x86_64-linux-gnu/libxml2.so.2", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\300\343\2\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=1809656, ...}) = 0 mmap(NULL, 3910072, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efecaa6f000 mprotect(0x7efecac1f000, 2097152, PROT_NONE) = 0 mmap(0x7efecae1f000, 40960, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x1b0000) = 0x7efecae1f000 mmap(0x7efecae29000, 2488, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7efecae29000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libreadline.so.7", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\200f\1\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=309168, ...}) = 0 mmap(NULL, 2409704, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efeca822000 mprotect(0x7efeca866000, 2093056, PROT_NONE) = 0 mmap(0x7efecaa65000, 32768, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x43000) = 0x7efecaa65000 mmap(0x7efecaa6d000, 5352, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7efecaa6d000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libutil.so.1", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0@\16\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=10688, ...}) = 0 mmap(NULL, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efecd610000 mmap(NULL, 2105608, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efeca61f000 mprotect(0x7efeca621000, 2093056, PROT_NONE) = 0 mmap(0x7efeca820000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x1000) = 0x7efeca820000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libdl.so.2", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\200\r\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=14640, ...}) = 0 mmap(NULL, 2109680, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efeca41b000 mprotect(0x7efeca41e000, 2093056, PROT_NONE) = 0 mmap(0x7efeca61d000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x2000) = 0x7efeca61d000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libc.so.6", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\3\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\0\4\2\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0755, st_size=1689360, ...}) = 0 mmap(NULL, 3795296, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efeca07c000 mprotect(0x7efeca211000, 2097152, PROT_NONE) = 0 mmap(0x7efeca411000, 24576, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x195000) = 0x7efeca411000 mmap(0x7efeca417000, 14688, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7efeca417000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/librt.so.1", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\340 \0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=31744, ...}) = 0 mmap(NULL, 2128832, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efec9e74000 mprotect(0x7efec9e7b000, 2093056, PROT_NONE) = 0 mmap(0x7efeca07a000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x6000) = 0x7efeca07a000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libudev.so.1", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\0\0\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=131344, ...}) = 0 mmap(NULL, 135152, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efecd5ef000 mmap(0x7efecd60e000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x1e000) = 0x7efecd60e000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libresolv.so.2", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0p9\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=84848, ...}) = 0 mmap(NULL, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efecd5ed000 mmap(NULL, 2189896, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efec9c5d000 mprotect(0x7efec9c71000, 2093056, PROT_NONE) = 0 mmap(0x7efec9e70000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x13000) = 0x7efec9e70000 mmap(0x7efec9e72000, 6728, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7efec9e72000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libpcre.so.3", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\320\25\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=468920, ...}) = 0 mmap(NULL, 2564360, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efec99ea000 mprotect(0x7efec9a5c000, 2093056, PROT_NONE) = 0 mmap(0x7efec9c5b000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x71000) = 0x7efec9c5b000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libsystemd.so.0", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\0\0\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=557552, ...}) = 0 mmap(NULL, 561809, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efecd563000 mprotect(0x7efecd5e7000, 4096, PROT_NONE) = 0 mmap(0x7efecd5e8000, 16384, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x84000) = 0x7efecd5e8000 mmap(0x7efecd5ec000, 657, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7efecd5ec000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/usr/local/lib/libz.so.1", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0000#\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0755, st_size=121744, ...}) = 0 mmap(NULL, 2208128, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efec97ce000 mprotect(0x7efec97e8000, 2097152, PROT_NONE) = 0 mmap(0x7efec99e8000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x1a000) = 0x7efec99e8000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libgcrypt.so.20", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\200\255\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=1112184, ...}) = 0 mmap(NULL, 3208448, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efec94be000 mprotect(0x7efec95c5000, 2097152, PROT_NONE) = 0 mmap(0x7efec97c5000, 36864, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x107000) = 0x7efec97c5000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/usr/lib/x86_64-linux-gnu/libp11-kit.so.0", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\0\26\1\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=411688, ...}) = 0 mmap(NULL, 2507952, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efec9259000 mprotect(0x7efec92b3000, 2093056, PROT_NONE) = 0 mmap(0x7efec94b2000, 49152, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x59000) = 0x7efec94b2000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libidn.so.11", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0 .\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=210968, ...}) = 0 mmap(NULL, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efecd561000 mmap(NULL, 2306096, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efec9025000 mprotect(0x7efec9057000, 2097152, PROT_NONE) = 0 mmap(0x7efec9257000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x32000) = 0x7efec9257000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/usr/lib/x86_64-linux-gnu/libtasn1.so.6", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0@+\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=75776, ...}) = 0 mmap(NULL, 2171592, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efec8e12000 mprotect(0x7efec8e23000, 2097152, PROT_NONE) = 0 mmap(0x7efec9023000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x11000) = 0x7efec9023000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/usr/lib/x86_64-linux-gnu/libnettle.so.6", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\20\225\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=224504, ...}) = 0 mmap(NULL, 2319552, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efec8bdb000 mprotect(0x7efec8c10000, 2093056, PROT_NONE) = 0 mmap(0x7efec8e0f000, 12288, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x34000) = 0x7efec8e0f000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/usr/lib/x86_64-linux-gnu/libhogweed.so.4", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0000x\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=216776, ...}) = 0 mmap(NULL, 2311792, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efec89a6000 mprotect(0x7efec89d9000, 2097152, PROT_NONE) = 0 mmap(0x7efec8bd9000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x33000) = 0x7efec8bd9000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/usr/lib/x86_64-linux-gnu/libgmp.so.10", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\200\305\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=537448, ...}) = 0 mmap(NULL, 2632576, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efec8723000 mprotect(0x7efec87a4000, 2097152, PROT_NONE) = 0 mmap(0x7efec89a4000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x81000) = 0x7efec89a4000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/usr/lib/x86_64-linux-gnu/libicui18n.so.57", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0p\22\f\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=2591816, ...}) = 0 mmap(NULL, 4690016, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efec82a9000 mprotect(0x7efec8514000, 2093056, PROT_NONE) = 0 mmap(0x7efec8713000, 61440, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x26a000) = 0x7efec8713000 mmap(0x7efec8722000, 96, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7efec8722000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/usr/lib/x86_64-linux-gnu/libicuuc.so.57", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\360\311\5\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=1727216, ...}) = 0 mmap(NULL, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efecd55f000 mmap(NULL, 3833312, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efec7f01000 mprotect(0x7efec8095000, 2093056, PROT_NONE) = 0 mmap(0x7efec8294000, 77824, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x193000) = 0x7efec8294000 mmap(0x7efec82a7000, 7648, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7efec82a7000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/usr/lib/x86_64-linux-gnu/libicudata.so.57", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\20\5\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=25675624, ...}) = 0 mmap(NULL, 27770920, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efec6484000 mprotect(0x7efec7d00000, 2093056, PROT_NONE) = 0 mmap(0x7efec7eff000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x187b000) = 0x7efec7eff000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/liblzma.so.5", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\2200\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=154376, ...}) = 0 mmap(NULL, 2249360, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efec625e000 mprotect(0x7efec6283000, 2093056, PROT_NONE) = 0 mmap(0x7efec6482000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x24000) = 0x7efec6482000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libtinfo.so.5", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\260\315\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=170776, ...}) = 0 mmap(NULL, 2267936, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efec6034000 mprotect(0x7efec605a000, 2093056, PROT_NONE) = 0 mmap(0x7efec6259000, 20480, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x25000) = 0x7efec6259000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/usr/lib/x86_64-linux-gnu/liblz4.so.1", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\300\"\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=72024, ...}) = 0 mmap(NULL, 2167120, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efec5e22000 mprotect(0x7efec5e33000, 2093056, PROT_NONE) = 0 mmap(0x7efec6032000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x10000) = 0x7efec6032000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libgpg-error.so.0", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0p(\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=79936, ...}) = 0 mmap(NULL, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efecd55d000 mmap(NULL, 2175160, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efec5c0e000 mprotect(0x7efec5c21000, 2093056, PROT_NONE) = 0 mmap(0x7efec5e20000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x12000) = 0x7efec5e20000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/usr/lib/x86_64-linux-gnu/libffi.so.6", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\240\31\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=35296, ...}) = 0 mmap(NULL, 2131560, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efec5a05000 mprotect(0x7efec5a0c000, 2097152, PROT_NONE) = 0 mmap(0x7efec5c0c000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x7000) = 0x7efec5c0c000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/usr/lib/x86_64-linux-gnu/libstdc++.so.6", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\3\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\340\267\10\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=1566168, ...}) = 0 mmap(NULL, 3674720, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efec5683000 mprotect(0x7efec57f5000, 2097152, PROT_NONE) = 0 mmap(0x7efec59f5000, 49152, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x172000) = 0x7efec59f5000 mmap(0x7efec5a01000, 12896, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7efec5a01000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libgcc_s.so.1", O_RDONLY|O_CLOEXEC) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\220*\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=92584, ...}) = 0 mmap(NULL, 2188336, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7efec546c000 mprotect(0x7efec5482000, 2093056, PROT_NONE) = 0 mmap(0x7efec5681000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x15000) = 0x7efec5681000 close(3) = 0 mmap(NULL, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efecd55b000 mmap(NULL, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efecd559000 mmap(NULL, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efecd557000 mmap(NULL, 12288, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efecd554000 arch_prctl(ARCH_SET_FS, 0x7efecd5548c0) = 0 mprotect(0x7efeca411000, 16384, PROT_READ) = 0 mprotect(0x7efec5681000, 4096, PROT_READ) = 0 mprotect(0x7efecc1e3000, 4096, PROT_READ) = 0 mprotect(0x7efec59f5000, 40960, PROT_READ) = 0 mprotect(0x7efec5c0c000, 4096, PROT_READ) = 0 mprotect(0x7efec5e20000, 4096, PROT_READ) = 0 mprotect(0x7efec6032000, 4096, PROT_READ) = 0 mprotect(0x7efec6259000, 16384, PROT_READ) = 0 mprotect(0x7efecc3fc000, 4096, PROT_READ) = 0 mprotect(0x7efeca61d000, 4096, PROT_READ) = 0 mprotect(0x7efec6482000, 4096, PROT_READ) = 0 mprotect(0x7efec7eff000, 4096, PROT_READ) = 0 mprotect(0x7efec8294000, 73728, PROT_READ) = 0 mprotect(0x7efec8713000, 53248, PROT_READ) = 0 mprotect(0x7efec89a4000, 4096, PROT_READ) = 0 mprotect(0x7efec8e0f000, 8192, PROT_READ) = 0 mprotect(0x7efec8bd9000, 4096, PROT_READ) = 0 mprotect(0x7efec9023000, 4096, PROT_READ) = 0 mprotect(0x7efec9257000, 4096, PROT_READ) = 0 mprotect(0x7efec94b2000, 40960, PROT_READ) = 0 mprotect(0x7efec97c5000, 8192, PROT_READ) = 0 mprotect(0x7efec99e8000, 4096, PROT_READ) = 0 mprotect(0x7efec9c5b000, 4096, PROT_READ) = 0 mprotect(0x7efecb863000, 4096, PROT_READ) = 0 mprotect(0x7efeca07a000, 4096, PROT_READ) = 0 mprotect(0x7efecd5e8000, 12288, PROT_READ) = 0 mprotect(0x7efec9e70000, 4096, PROT_READ) = 0 mprotect(0x7efecd60e000, 4096, PROT_READ) = 0 mprotect(0x7efeca820000, 4096, PROT_READ) = 0 mprotect(0x7efecaa65000, 8192, PROT_READ) = 0 mprotect(0x7efecae1f000, 32768, PROT_READ) = 0 mprotect(0x7efecb1b4000, 53248, PROT_READ) = 0 mprotect(0x7efecb3ed000, 4096, PROT_READ) = 0 mprotect(0x7efecb63c000, 8192, PROT_READ) = 0 mprotect(0x7efecba80000, 4096, PROT_READ) = 0 mprotect(0x7efecbc8b000, 4096, PROT_READ) = 0 mprotect(0x7efecbedc000, 4096, PROT_READ) = 0 mprotect(0x7efecc61e000, 8192, PROT_READ) = 0 mprotect(0x7efecc879000, 12288, PROT_READ) = 0 mprotect(0x7efecca8b000, 4096, PROT_READ) = 0 mprotect(0x7efeccff2000, 61440, PROT_READ) = 0 mprotect(0x7efecd20d000, 4096, PROT_READ) = 0 mprotect(0x7efecd411000, 4096, PROT_READ) = 0 mprotect(0x55874f98e000, 90112, PROT_READ) = 0 mprotect(0x7efecd636000, 4096, PROT_READ) = 0 munmap(0x7efecd616000, 115763) = 0 set_tid_address(0x7efecd554b90) = 31092 set_robust_list(0x7efecd554ba0, 24) = 0 rt_sigaction(SIGRTMIN, {sa_handler=0x7efecc1eabd0, sa_mask=[], sa_flags=SA_RESTORER|SA_SIGINFO, sa_restorer=0x7efecc1f60c0}, NULL, 8) = 0 rt_sigaction(SIGRT_1, {sa_handler=0x7efecc1eac60, sa_mask=[], sa_flags=SA_RESTORER|SA_RESTART|SA_SIGINFO, sa_restorer=0x7efecc1f60c0}, NULL, 8) = 0 rt_sigprocmask(SIG_UNBLOCK, [RTMIN RT_1], NULL, 8) = 0 getrlimit(RLIMIT_STACK, {rlim_cur=8192*1024, rlim_max=RLIM64_INFINITY}) = 0 brk(NULL) = 0x55875027f000 brk(0x5587502b1000) = 0x5587502b1000 futex(0x7efec94bd460, FUTEX_WAKE_PRIVATE, 2147483647) = 0 statfs("/sys/fs/selinux", 0x7ffeecf6cc70) = -1 ENOENT (No such file or directory) statfs("/selinux", 0x7ffeecf6cc70) = -1 ENOENT (No such file or directory) open("/proc/filesystems", O_RDONLY) = 3 fstat(3, {st_mode=S_IFREG|0444, st_size=0, ...}) = 0 read(3, "nodev\tsysfs\nnodev\trootfs\nnodev\tr"..., 1024) = 311 read(3, "", 1024) = 0 close(3) = 0 access("/etc/selinux/config", F_OK) = -1 ENOENT (No such file or directory) getrandom("\347", 1, GRND_NONBLOCK) = 1 stat("/etc/gnutls/default-priorities", 0x7ffeecf6cc90) = -1 ENOENT (No such file or directory) open("/proc/self/status", O_RDONLY) = 3 fstat(3, {st_mode=S_IFREG|0444, st_size=0, ...}) = 0 read(3, "Name:\tvirsh\nUmask:\t0022\nState:\tR"..., 1024) = 1024 close(3) = 0 open("/sys/devices/system/node", O_RDONLY|O_NONBLOCK|O_DIRECTORY|O_CLOEXEC) = 3 fstat(3, {st_mode=S_IFDIR|0755, st_size=0, ...}) = 0 brk(0x5587502d6000) = 0x5587502d6000 getdents(3, /* 9 entries */, 32768) = 280 open("/sys/devices/system/node/node0/meminfo", O_RDONLY) = 4 fstat(4, {st_mode=S_IFREG|0444, st_size=4096, ...}) = 0 read(4, "Node 0 MemTotal: 3956368 "..., 4096) = 1070 read(4, "", 4096) = 0 close(4) = 0 getdents(3, /* 0 entries */, 32768) = 0 close(3) = 0 sched_getaffinity(0, 512, [0, 1, 2, 3]) = 64 open("/sys/devices/system/cpu", O_RDONLY|O_NONBLOCK|O_DIRECTORY|O_CLOEXEC) = 3 fstat(3, {st_mode=S_IFDIR|0755, st_size=0, ...}) = 0 getdents(3, /* 20 entries */, 32768) = 592 getdents(3, /* 0 entries */, 32768) = 0 brk(0x5587502ce000) = 0x5587502ce000 close(3) = 0 open("/proc/self/status", O_RDONLY) = 3 fstat(3, {st_mode=S_IFREG|0444, st_size=0, ...}) = 0 read(3, "Name:\tvirsh\nUmask:\t0022\nState:\tR"..., 1024) = 1024 read(3, "xt_switches:\t1\n", 1024) = 15 read(3, "", 1024) = 0 close(3) = 0 open("/proc/net/psched", O_RDONLY) = 3 fstat(3, {st_mode=S_IFREG|0444, st_size=0, ...}) = 0 read(3, "000003e8 00000040 000f4240 3b9ac"..., 1024) = 36 close(3) = 0 stat("/usr/local/etc/libnl/classid", {st_mode=S_IFREG|0644, st_size=1130, ...}) = 0 open("/usr/local/etc/libnl/classid", O_RDONLY) = 3 fstat(3, {st_mode=S_IFREG|0644, st_size=1130, ...}) = 0 read(3, "################################"..., 4096) = 1130 read(3, "", 4096) = 0 close(3) = 0 open("/usr/lib/locale/locale-archive", O_RDONLY|O_CLOEXEC) = 3 fstat(3, {st_mode=S_IFREG|0644, st_size=7109136, ...}) = 0 mmap(NULL, 7109136, PROT_READ, MAP_PRIVATE, 3, 0) = 0x7efec4da4000 close(3) = 0 ioctl(0, TCGETS, {B38400 opost isig icanon echo ...}) = 0 ioctl(0, TCGETS, {B38400 opost isig icanon echo ...}) = 0 getuid() = 1000 geteuid() = 1000 open("/usr/lib/x86_64-linux-gnu/gconv/gconv-modules.cache", O_RDONLY) = 3 fstat(3, {st_mode=S_IFREG|0644, st_size=26258, ...}) = 0 mmap(NULL, 26258, PROT_READ, MAP_SHARED, 3, 0) = 0x7efecd62c000 close(3) = 0 futex(0x7efeca4168a8, FUTEX_WAKE_PRIVATE, 2147483647) = 0 uname({sysname="Linux", nodename="debian", ...}) = 0 futex(0x7efecd009b00, FUTEX_WAKE_PRIVATE, 2147483647) = 0 futex(0x7efecd00a700, FUTEX_WAKE_PRIVATE, 2147483647) = 0 pipe2([3, 4], O_NONBLOCK|O_CLOEXEC) = 0 mmap(NULL, 8392704, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS|MAP_STACK, -1, 0) = 0x7efec45a3000 mprotect(0x7efec45a3000, 4096, PROT_NONE) = 0 clone(child_stack=0x7efec4da2e30, flags=CLONE_VM|CLONE_FS|CLONE_FILES|CLONE_SIGHAND|CLONE_THREAD|CLONE_SYSVSEM|CLONE_SETTLS|CLONE_PARENT_SETTID|CLONE_CHILD_CLEARTID, parent_tidptr=0x7efec4da39d0, tls=0x7efec4da3700, child_tidptr=0x7efec4da39d0) = 31093 futex(0x7efecd009dd8, FUTEX_WAKE_PRIVATE, 2147483647) = 0 futex(0x7efecd00a6e8, FUTEX_WAKE_PRIVATE, 2147483647) = 0 geteuid() = 1000 geteuid() = 1000 socket(AF_UNIX, SOCK_STREAM|SOCK_CLOEXEC|SOCK_NONBLOCK, 0) = 5 connect(5, {sa_family=AF_UNIX, sun_path="/var/run/nscd/socket"}, 110) = -1 ENOENT (No such file or directory) close(5) = 0 socket(AF_UNIX, SOCK_STREAM|SOCK_CLOEXEC|SOCK_NONBLOCK, 0) = 5 connect(5, {sa_family=AF_UNIX, sun_path="/var/run/nscd/socket"}, 110) = -1 ENOENT (No such file or directory) close(5) = 0 open("/etc/nsswitch.conf", O_RDONLY|O_CLOEXEC) = 5 fstat(5, {st_mode=S_IFREG|0644, st_size=529, ...}) = 0 read(5, "# /etc/nsswitch.conf\n#\n# Example"..., 4096) = 529 read(5, "", 4096) = 0 close(5) = 0 open("/etc/ld.so.cache", O_RDONLY|O_CLOEXEC) = 5 fstat(5, {st_mode=S_IFREG|0644, st_size=115763, ...}) = 0 mmap(NULL, 115763, PROT_READ, MAP_PRIVATE, 5, 0) = 0x7efecd537000 close(5) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libnss_compat.so.2", O_RDONLY|O_CLOEXEC) = 5 read(5, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\260\22\0\0\0\0\0\0"..., 832) = 832 fstat(5, {st_mode=S_IFREG|0644, st_size=31616, ...}) = 0 mmap(NULL, 2126944, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 5, 0) = 0x7efec439b000 mprotect(0x7efec43a2000, 2093056, PROT_NONE) = 0 mmap(0x7efec45a1000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 5, 0x6000) = 0x7efec45a1000 close(5) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libnsl.so.1", O_RDONLY|O_CLOEXEC) = 5 read(5, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\320?\0\0\0\0\0\0"..., 832) = 832 fstat(5, {st_mode=S_IFREG|0644, st_size=89064, ...}) = 0 mmap(NULL, 2194008, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 5, 0) = 0x7efec4183000 mprotect(0x7efec4197000, 2097152, PROT_NONE) = 0 mmap(0x7efec4397000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 5, 0x14000) = 0x7efec4397000 mmap(0x7efec4399000, 6744, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7efec4399000 close(5) = 0 mprotect(0x7efec4397000, 4096, PROT_READ) = 0 mprotect(0x7efec45a1000, 4096, PROT_READ) = 0 munmap(0x7efecd537000, 115763) = 0 open("/etc/ld.so.cache", O_RDONLY|O_CLOEXEC) = 5 fstat(5, {st_mode=S_IFREG|0644, st_size=115763, ...}) = 0 mmap(NULL, 115763, PROT_READ, MAP_PRIVATE, 5, 0) = 0x7efecd537000 close(5) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libnss_nis.so.2", O_RDONLY|O_CLOEXEC) = 5 read(5, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\340 \0\0\0\0\0\0"..., 832) = 832 fstat(5, {st_mode=S_IFREG|0644, st_size=47688, ...}) = 0 mmap(NULL, 2143656, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 5, 0) = 0x7efebfdf4000 mprotect(0x7efebfdff000, 2093056, PROT_NONE) = 0 mmap(0x7efebfffe000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 5, 0xa000) = 0x7efebfffe000 close(5) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libnss_files.so.2", O_RDONLY|O_CLOEXEC) = 5 read(5, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\320!\0\0\0\0\0\0"..., 832) = 832 fstat(5, {st_mode=S_IFREG|0644, st_size=47632, ...}) = 0 mmap(NULL, 2168600, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 5, 0) = 0x7efebfbe2000 mprotect(0x7efebfbec000, 2097152, PROT_NONE) = 0 mmap(0x7efebfdec000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 5, 0xa000) = 0x7efebfdec000 mmap(0x7efebfdee000, 22296, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7efebfdee000 close(5) = 0 mprotect(0x7efebfdec000, 4096, PROT_READ) = 0 mprotect(0x7efebfffe000, 4096, PROT_READ) = 0 munmap(0x7efecd537000, 115763) = 0 open("/etc/passwd", O_RDONLY|O_CLOEXEC) = 5 lseek(5, 0, SEEK_CUR) = 0 fstat(5, {st_mode=S_IFREG|0644, st_size=1763, ...}) = 0 mmap(NULL, 1763, PROT_READ, MAP_SHARED, 5, 0) = 0x7efecd62b000 lseek(5, 1763, SEEK_SET) = 1763 munmap(0x7efecd62b000, 1763) = 0 close(5) = 0 access("/home/yubo/.config/libvirt/libvirt.conf", F_OK) = -1 ENOENT (No such file or directory) getuid() = 1000 geteuid() = 1000 access("/proc/vz", F_OK) = -1 ENOENT (No such file or directory) geteuid() = 1000 getuid() = 1000 geteuid() = 1000 getuid() = 1000 geteuid() = 1000 stat("/run/user/1000/libvirt", 0x7ffeecf6c1f0) = -1 ENOENT (No such file or directory) stat("/run/user/1000", {st_mode=S_IFDIR|0700, st_size=180, ...}) = 0 mkdir("/run/user/1000/libvirt", 0700) = 0 open("/run/user/1000/libvirt/libvirtd.lock", O_RDWR|O_CREAT, 0600) = 5 fcntl(5, F_GETFD) = 0 fcntl(5, F_SETFD, FD_CLOEXEC) = 0 fcntl(5, F_SETLKW, {l_type=F_WRLCK, l_whence=SEEK_SET, l_start=0, l_len=1}) = 0 socket(AF_UNIX, SOCK_STREAM, 0) = 6 connect(6, {sa_family=AF_UNIX, sun_path="/run/user/1000/libvirt/libvirt-sock"}, 110) = -1 ENOENT (No such file or directory) open("/dev/null", O_RDWR|O_CLOEXEC) = 7 rt_sigprocmask(SIG_SETMASK, ~[RTMIN RT_1], [], 8) = 0 clone(child_stack=NULL, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0x7efecd554b90) = 31094 rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0 close(7) = 0 wait4(31094, [{WIFEXITED(s) && WEXITSTATUS(s) == 0}], 0, NULL) = 31094 --- SIGCHLD {si_signo=SIGCHLD, si_code=CLD_EXITED, si_pid=31094, si_uid=1000, si_status=0, si_utime=0, si_stime=0} --- nanosleep({tv_sec=0, tv_nsec=10000000}, NULL) = 0 connect(6, {sa_family=AF_UNIX, sun_path="/run/user/1000/libvirt/libvirt-sock"}, 110) = -1 ENOENT (No such file or directory) nanosleep({tv_sec=0, tv_nsec=10000000}, NULL) = 0 connect(6, {sa_family=AF_UNIX, sun_path="/run/user/1000/libvirt/libvirt-sock"}, 110) = -1 ENOENT (No such file or directory) nanosleep({tv_sec=0, tv_nsec=10000000}, NULL) = 0 connect(6, {sa_family=AF_UNIX, sun_path="/run/user/1000/libvirt/libvirt-sock"}, 110) = 0 getsockname(6, {sa_family=AF_UNIX}, [128->2]) = 0 futex(0x7efecd00a460, FUTEX_WAKE_PRIVATE, 2147483647) = 0 fcntl(6, F_GETFD) = 0 fcntl(6, F_SETFD, FD_CLOEXEC) = 0 fcntl(6, F_GETFL) = 0x2 (flags O_RDWR) fcntl(6, F_SETFL, O_RDWR|O_NONBLOCK) = 0 unlink("/run/user/1000/libvirt/libvirtd.lock") = 0 close(5) = 0 futex(0x7efecd00a578, FUTEX_WAKE_PRIVATE, 2147483647) = 0 pipe2([5, 7], O_CLOEXEC) = 0 write(4, "\0", 1) = 1 futex(0x7efecd009980, FUTEX_WAKE_PRIVATE, 1) = 1 futex(0x7efecd00a478, FUTEX_WAKE_PRIVATE, 2147483647) = 0 futex(0x7efecd00a548, FUTEX_WAKE_PRIVATE, 2147483647) = 0 write(4, "\0", 1) = 1 futex(0x7efecd009980, FUTEX_WAKE_PRIVATE, 1) = 1 rt_sigprocmask(SIG_BLOCK, [PIPE CHLD WINCH], [], 8) = 0 poll([{fd=6, events=POLLOUT}, {fd=5, events=POLLIN}], 2, -1) = 1 ([{fd=6, revents=POLLOUT}]) rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0 write(6, "\0\0\0\34 \0\200\206\0\0\0\1\0\0\0B\0\0\0\0\0\0\0\0\0\0\0\0", 28) = 28 rt_sigprocmask(SIG_BLOCK, [PIPE CHLD WINCH], [], 8) = 0 poll([{fd=6, events=POLLIN}, {fd=5, events=POLLIN}], 2, -1) = ? ERESTART_RESTARTBLOCK (Interrupted by signal) --- SIGINT {si_signo=SIGINT, si_code=SI_KERNEL} --- +++ killed by SIGINT +++

2 5

[libvirt] [dbus PATCH] tests: include stdlib.h
by Ján Tomko 13 Jun '18

13 Jun '18

On some systems, EXIT_SUCCESS and EXIT_FAILURE require inclusion of stdlib.h Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed as a build breaker fix. tests/test_util.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/test_util.c b/tests/test_util.c index 9611192..b7fafb6 100644 --- a/tests/test_util.c +++ b/tests/test_util.c @@ -1,5 +1,7 @@ #include "util.h" +#include <stdlib.h> + static gint virtTestEncodeStr(const gchar *input, const gchar *expected) -- 2.16.1

1 0

Re: [libvirt] [Qemu-devel] [PATCH 0/3] block: Remove deprecated -drive options
by Cole Robinson 13 Jun '18

13 Jun '18

On 06/13/2018 08:34 AM, Kevin Wolf wrote: > We deprecated a bunch of -drive options in 2.10, so let's remove them > for 3.0. > > Kevin Wolf (3): > block: Remove deprecated -drive geometry options > block: Remove deprecated -drive option addr > block: Remove deprecated -drive option serial > > include/hw/block/block.h | 1 - > include/sysemu/blockdev.h | 3 -- > block/block-backend.c | 1 - > blockdev.c | 110 ---------------------------------------------- > device-hotplug.c | 4 -- > hw/block/block.c | 27 ------------ > hw/block/nvme.c | 1 - > hw/block/virtio-blk.c | 1 - > hw/ide/qdev.c | 1 - > hw/scsi/scsi-disk.c | 1 - > hw/usb/dev-storage.c | 1 - > tests/ahci-test.c | 6 +-- > tests/hd-geo-test.c | 18 -------- > tests/ide-test.c | 8 ++-- > hmp-commands.hx | 1 - > qemu-doc.texi | 15 ------- > qemu-options.hx | 14 +----- > 17 files changed, 8 insertions(+), 205 deletions(-) > I think libvirt needs to be adjusted to handle new style options for patch #1 and patch #3, ccing - Cole

1 0

[libvirt] [PATCH 0/3] Couple of SEV fixes
by Michal Privoznik 13 Jun '18

13 Jun '18

*** BLURB HERE *** Michal Privoznik (3): qemuBuildSevCommandLine: s/obj/buf/ qemuBuildSevCommandLine: fix buffer leak conf: Rework virDomainSEVDefParseXML() src/conf/domain_conf.c | 30 +++++++++--------------------- src/qemu/qemu_command.c | 25 +++++++++++++++---------- 2 files changed, 24 insertions(+), 31 deletions(-) -- 2.16.4

2 6

[libvirt] Likely build race, "/usr/bin/ld: cannot find -lvirt"
by Ian Jackson 13 Jun '18

13 Jun '18

tl;dr: I think there is a bug in libvirt's build system which, with low probability, causes a build failure containing this message: /usr/bin/ld: cannot find -lvirt Complete build logs of two attempts: http://logs.test-lab.xenproject.org/osstest/logs/123046/build-i386-libvirt/… http://logs.test-lab.xenproject.org/osstest/logs/123096/build-i386-libvirt/… Snippet from 123046 containing the error is enclosed below. Longer explanation: I have two new machines for the Xen Project CI, which I am trying to commission. As part of commissioning I run a complete test run (a "flight" in osstest terminology) on just those new hosts. The i386 libvirt build failed: http://logs.test-lab.xenproject.org/osstest/logs/123046/build-i386-libvirt/… Everything else that would be expected to work was fine. The test programme was identical to flight 122815, except that that ran on other hosts in the test farm (and, there, it passed). The error is the kind of error one sees with missing dependencies in parallel builds, etc. I wanted to have some 32-bit libvirt tests actually run, so I reran a new flight containing the relevant parts. That failed too in a very similar way: http://logs.test-lab.xenproject.org/osstest/logs/123096/build-i386-libvirt/… The two machines are Dell R230s (and therefore hardly unusual). The main novelty of these machines is that the firmware is UEFI booting in UEFI mode. I doubt that has anything to do with it. The host, including compiler, is Debian jessie i386. As you can see from the log, we were trying to build libvirt 764a7483f189e6de841163647c14296e693dbb2e What may be less obvious is that we were trying to build it against xen.git#0306a1311d02ea52b4a9a9bc339f8bab9354c5e3. http://logs.test-lab.xenproject.org/osstest/logs/123064/build-i386-libvirt/… http://logs.test-lab.xenproject.org/osstest/logs/123046/build-i386/info.html Does this seem like a likely explanation ? Have other people experienced occasional problems with make -j ? If someone wants to suggest a patch that might fix it I can test it. In the meantime I have set off a number of new attempts, to try to guess the failure probability, and also one attempt on other hosts to check that nothing unexpected was broken. Ian. /usr/bin/ld: cannot find -lvirt /usr/bin/ld: cannot find -lvirt /bin/mkdir -p '/home/osstest/build.123046.build-i386-libvirt/dist/usr/local/lib/libvirt/storage-backend' /bin/bash ../libtool --mode=install /usr/bin/install -c libvirt_storage_backend_fs.la libvirt_storage_backend_logical.la libvirt_storage_backend_scsi.la libvirt_storage_backend_mpath.la '/home/osstest/build.123046.build-i386-libvirt/dist/usr/local/lib/libvirt/storage-backend' libtool: install: warning: relinking `libvirt_storage_backend_fs.la' libtool: install: (cd /home/osstest/build.123046.build-i386-libvirt/libvirt/src; /bin/bash /home/osstest/build.123046.build-i386-libvirt/libvirt/libtool --silent --tag CC --mode=relink gcc -std=gnu99 -I./conf -I/usr/include/libxml2 -fno-common -W -Waddress -Waggressive-loop-optimizations -Wall -Wattributes -Wbad-function-cast -Wbuiltin-macro-redefined -Wcast-align -Wchar-subscripts -Wclobbered -Wcomment -Wcomments -Wcoverage-mismatch -Wcpp -Wdate-time -Wdeprecated-declarations -Wdiv-by-zero -Wdouble-promotion -Wempty-body -Wendif-labels -Wextra -Wformat-contains-nul -Wformat-extra-args -Wformat-security -Wformat-y2k -Wformat-zero-length -Wfree-nonheap-object -Wignored-qualifiers -Wimplicit -Wimplicit-function-declaration -Wimplicit-int -Winit-self -Winline -Wint-to-pointer-cast -Winvalid-memory-model -Winvalid-pch -Wjump-misses-init -Wlogical-op -Wmain -Wmaybe-uninitialized -Wmemset-transposed-args -Wmissing-braces -Wmissing-declarations -Wmissing-field-initializers -Wmissing-include-dirs -Wmissing-parameter-type -Wmissing-prototypes -Wmultichar -Wnarrowing -Wnested-externs -Wnonnull -Wold-style-declaration -Wold-style-definition -Wopenmp-simd -Woverflow -Woverride-init -Wpacked-bitfield-compat -Wparentheses -Wpointer-arith -Wpointer-sign -Wpointer-to-int-cast -Wpragmas -Wpsabi -Wreturn-local-addr -Wreturn-type -Wsequence-point -Wshadow -Wsizeof-pointer-memaccess -Wstrict-aliasing -Wstrict-prototypes -Wsuggest-attribute=const -Wsuggest-attribute=format -Wsuggest-attribute=noreturn -Wsuggest-attribute=pure -Wswitch -Wsync-nand -Wtrampolines -Wtrigraphs -Wtype-limits -Wuninitialized -Wunknown-pragmas -Wunused -Wunused-but-set-parameter -Wunused-but-set-variable -Wunused-function -Wunused-label -Wunused-local-typedefs -Wunused-parameter -Wunused-result -Wunused-value -Wunused-variable -Wvarargs -Wvariadic-macros -Wvector-operation-performance -Wvolatile-register-var -Wwrite-strings -Wnormalized=nfc -Wno-sign-compare -Wjump-misses-init -Wswitch-enum -Wno-format-nonliteral -fstack-protector-strong -fexceptions -fasyn chronous-unwind-tables -fipa-pure-const -Wno-suggest-attribute=pure -Wno-suggest-attribute=const -Werror -Wframe-larger-than=4096 -g -I/home/osstest/build.123046.build-i386-libvirt/xendist/usr/local/include/ -DLIBXL_API_VERSION=0x040400 -module -avoid-version -Wl,-z -Wl,nodelete -export-dynamic -Wl,-z -Wl,relro -Wl,-z -Wl,now -Wl,--no-copy-dt-needed-entries -g -L/home/osstest/build.123046.build-i386-libvirt/xendist/usr/local/lib/ -Wl,-rpath-link=/home/osstest/build.123046.build-i386-libvirt/xendist/usr/local/lib/ -o libvirt_storage_backend_fs.la -rpath /usr/local/lib/libvirt/storage-backend storage/libvirt_storage_backend_fs_la-storage_backend_fs.lo libvirt.la ../gnulib/lib/libgnu.la -ldl -inst-prefix-dir /home/osstest/build.123046.build-i386-libvirt/dist) collect2: error: ld returned 1 exit status Makefile:6410: recipe for target 'install-lockdriverLTLIBRARIES' failed libtool: install: error: relink `lockd.la' with the above command before installing it make[3]: *** [install-lockdriverLTLIBRARIES] Error 1 make[3]: *** Waiting for unfinished jobs.... /usr/bin/ld: cannot find -lvirt

5 7

[libvirt] [PATCH] libvirt: fix a typo
by Chen Hanxiao 13 Jun '18

13 Jun '18

From: Chen Hanxiao <chenhanxiao(a)gmail.com> s/httsp/https Signed-off-by: Chen Hanxiao <chenhanxiao(a)gmail.com> --- src/libvirt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt.c b/src/libvirt.c index ffb002f4e1..52f4dd2808 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -1098,7 +1098,7 @@ virConnectOpenInternal(const char *name, * if not already running. This can be prevented by setting the * environment variable LIBVIRT_AUTOSTART=0 * - * URIs are documented at httsp://libvirt.org/uri.html + * URIs are documented at https://libvirt.org/uri.html * * virConnectClose should be used to release the resources after the connection * is no longer needed. -- 2.17.1

3 3

[libvirt] [jenkins-ci PATCH 0/3] Drop CentOS 6 support
by Andrea Bolognani 13 Jun '18

13 Jun '18

As suggested in https://www.redhat.com/archives/libvir-list/2018-June/msg00943.html Andrea Bolognani (3): projects: Drop libvirt-master-build-website job guests: Drop libvirt+website project guests: Drop CentOS 6 support guests/host_vars/libvirt-centos-6/install.yml | 3 - guests/host_vars/libvirt-centos-6/main.yml | 3 - guests/inventory | 1 - guests/tasks/base.yml | 2 - guests/vars/mappings.yml | 19 +--- guests/vars/projects/libvirt+website.yml | 5 -- guests/vars/projects/libvirt.yml | 1 - guests/vars/vault.yml | 86 +++++++++---------- projects/libvirt.yaml | 11 --- 9 files changed, 42 insertions(+), 89 deletions(-) delete mode 100644 guests/host_vars/libvirt-centos-6/install.yml delete mode 100644 guests/host_vars/libvirt-centos-6/main.yml delete mode 100644 guests/vars/projects/libvirt+website.yml -- 2.17.1

3 5

[libvirt] [libvirt-python PATCH 0/2] Provide coverage for the AMD SEV APIs
by Erik Skultety 13 Jun '18

13 Jun '18

Add support for the recently introduced AMD SEV APIs Erik Skultety (2): Add support for virDomainGetLaunchSecurityInfo Add support for virNodeGetSEVInfo generator.py | 2 ++ libvirt-override-api.xml | 12 ++++++++ libvirt-override.c | 73 ++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 87 insertions(+) -- 2.14.4

2 4

[libvirt] [PATCH libvirt 0/4] rmv virObjectEventStateQueue wrapper funcs
by Anya Harter 13 Jun '18

13 Jun '18

Currently, there are four wrapper functions which call virObjectEventStateQueue: - testObjectEventQueue - libxlDomainEventQueue - qemuDomainEventQueue - umlDomainEventQueue This patch series removes these wrappers makes all calls directly to virObjectEventStateQueue. Since virObjectEventStateQueue takes care of NULL checking, all NULL checking by callers has also been removed. This patch series should complete the BiteSizedTask entry at https://wiki.libvirt.org/page/BiteSizedTasks#Remove_NULL_checking_around_Ev… . Anya Harter (4): events: remove testObjectEventQueue wrapper func events: remove libxlDomainEventQueue wrapper func events: remove qemuDomainEventQueue wrapper func events: remove umlDomainEventQueue wrapper func src/libxl/libxl_domain.c | 24 +++------- src/libxl/libxl_domain.h | 4 -- src/libxl/libxl_driver.c | 21 +++------ src/libxl/libxl_migration.c | 18 +++----- src/qemu/qemu_blockjob.c | 4 +- src/qemu/qemu_cgroup.c | 2 +- src/qemu/qemu_domain.c | 11 +---- src/qemu/qemu_domain.h | 2 - src/qemu/qemu_driver.c | 88 +++++++++++++++++-------------------- src/qemu/qemu_hotplug.c | 26 +++++------ src/qemu/qemu_migration.c | 24 +++++----- src/qemu/qemu_process.c | 54 +++++++++++------------ src/test/test_driver.c | 80 ++++++++++++++++----------------- src/uml/uml_driver.c | 33 ++++---------- 14 files changed, 162 insertions(+), 229 deletions(-) -- 2.17.1

2 5

[libvirt] [PATCH 00/12] Temporarily use other boot configuration
by Marc Hartmayer 13 Jun '18

13 Jun '18

This patch series implements a new API that allows us to temporarily use another boot configuration than defined in the persistent domain definition. The s390 architecture knows only one boot device and therefore the boot order settings doesn't work the way it would work on x86, for example. If the first boot device fails to boot there is no trying to boot from the next boot device. In addition, the architecture/BIOS has no support for interactively changing the boot device during the boot/IPL process. Currently the API is implemented for the remote/QEMU/test driver and for virsh. It can be used as follows $ virsh start {{DOMAIN}} --with-kernel {{KERNEL_FILE}} \ --with-initrd {{INITRD_FILE}} --with-cmdline {{CMDLINE}} \ --with-bootdevice {{DEVICE_IDENTIFIER}} E.g. $ virsh start dom_01 --with-bootdevice='vdb' Marc Hartmayer (12): virsh: Force boot emulation is only required for virDomainCreateWithFlags Introduce new domain create API virDomainCreateWithParams remote: Add support for virDomainCreateWithParams utils: Add virStringUpdate conf: Add functions to change the boot configuration of a domain qemu: Add the functionality to override the boot configuration qemu: Add support for virDomainCreateWithParams test: Implement virConnectSupportsFeature test: Add support for virDomainCreateWithParams tests: Add tests for virDomainCreateWithParams virsh: Add with-{bootdevice,kernel,initrd,cmdline} options for start docs: Add news entry for new API virDomainCreateWithParams docs/news.xml | 11 ++ include/libvirt/libvirt-domain.h | 37 +++++ src/conf/domain_conf.c | 226 +++++++++++++++++++++++++++ src/conf/domain_conf.h | 11 ++ src/driver-hypervisor.h | 6 + src/libvirt-domain.c | 64 ++++++++ src/libvirt_private.syms | 2 + src/libvirt_public.syms | 4 + src/qemu/qemu_driver.c | 83 ++++++++-- src/qemu/qemu_migration.c | 3 +- src/qemu/qemu_process.c | 16 +- src/qemu/qemu_process.h | 2 + src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 22 ++- src/remote_protocol-structs | 12 ++ src/rpc/gendispatch.pl | 18 ++- src/test/test_driver.c | 108 +++++++++++-- src/util/virstring.c | 27 ++++ src/util/virstring.h | 2 + tests/objecteventtest.c | 321 +++++++++++++++++++++++++++++++++++++++ tools/virsh-domain.c | 136 ++++++++++++++--- tools/virsh.pod | 14 ++ 22 files changed, 1064 insertions(+), 62 deletions(-) -- 2.13.4

6 22

[libvirt] [PATCH] lib: Document limitation of virDomainInterfaceAddresses
by Michal Privoznik 12 Jun '18

12 Jun '18

https://bugzilla.redhat.com/show_bug.cgi?id=1588336 This API takes @source argument which tells it where to get domain IP addresses from. However, not all sources are capable of providing all the information we report, for instance ARP table has no notion of IP address prefixes. Document this limitation. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/libvirt-domain.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index dcfc7d4c57..4a899f31c8 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -11780,6 +11780,10 @@ virDomainFSInfoFree(virDomainFSInfoPtr info) * be unreachable. Depending on the route table config of the * guest, the returned mac address may be duplicated. * + * Note that for some @source values some pieces of returned @ifaces + * might be unset (e.g. VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_ARP does not + * set IP address prefix as ARP table does not have any notion of that). + * * @ifaces->name and @ifaces->hwaddr are never NULL. * * The caller *must* free @ifaces when no longer needed. Usual use case -- 2.16.4

2 1

[libvirt] [PATCH v2 00/21] nwfilter: refactor the driver to make it independent of virt drivers
by Daniel P. Berrangé 12 Jun '18

12 Jun '18

v1: https://www.redhat.com/archives/libvir-list/2018-April/msg02616.html Today the nwfilter driver is entangled with the virt drivers in both directions. At various times when rebuilding filters nwfilter will call out to the virt driver to iterate over running guest's NICs. This has caused very complicated lock ordering rules to be required. If we are to split the virt drivers out into separate daemons we need to get rid of this coupling since we don't want the separate daemons calling each other, as that risks deadlock if all of the RPC workers are busy. The obvious way to solve this is to have the nwfilter driver remember all the filters it has active, avoiding the need to iterate over running guests. Easy parts of the v1 posting have already been merged. This v2 is much more complete, though still not entirely ready for merge. - The virNWFilterBindingPtr was renamed virNWFilterBindingDefPtr - New virNWFilterBindingObjPtr & virNWFilterBindingObjListPtr structs added to track the objects in the driver - New virNWFilterBindingPtr public API type was added - New public APIs for listing filter bindings, querying XML, and creating/deleting them - Convert the virt drivers to use the public API for creating and deleting bindings - Persistent active bindings out to disk so they're preserved across restarts - Added RNG schema and XML-2-XML test - New virsh commands for listing/querying XML/creating/deleting bindings Still todo - Document the new XML format - Run the nwfilter stress tests to see what I've undoubtably broken - Think about recording the NIC index in the virNWFilterBindingObjPtr and persisting across restarts, so we can track if the NIC we had previously used was deleted & recreated - in which case we can drop the stale binding. - Probably something else... Daniel P. Berrangé (21): util: fix misleading command for virObjectLock conf: change virNWFilterBindingPtr to virNWFilterBindingDefPtr conf: add missing virxml.h include for nwfilter_params.h conf: move virNWFilterBindingDefPtr into its own files conf: add support for parsing/formatting virNWFilterBindingDefPtr schemas: add schema for nwfilter binding XML document nwfilter: export port binding concept in the public API access: add nwfilter binding object permissions remote: add support for nwfilter binding objects virsh: add nwfilter binding commands nwfilter: convert the gentech driver code to use virNWFilterBindingDefPtr nwfilter: convert IP address learning code to virNWFilterBindingDefPtr nwfilter: convert DHCP address snooping code to virNWFilterBindingDefPtr conf: report an error if nic needs filtering by no driver is present conf: introduce a virNWFilterBindingObjPtr struct conf: introduce a virNWFilterBindingObjListPtr struct nwfilter: keep track of active filter bindings nwfilter: remove virt driver callback layer for rebuilding filters nwfilter: wire up new APIs for listing and querying filter bindings nwfilter: wire up new APIs for creating and deleting nwfilter bindings nwfilter: convert virt drivers to use public API for nwfilter bindings docs/schemas/domaincommon.rng | 27 +- docs/schemas/nwfilter.rng | 29 +- docs/schemas/nwfilter_params.rng | 32 ++ docs/schemas/nwfilterbinding.rng | 49 ++ include/libvirt/libvirt-nwfilter.h | 39 ++ include/libvirt/virterror.h | 2 + src/access/viraccessdriver.h | 5 + src/access/viraccessdrivernop.c | 10 + src/access/viraccessdriverpolkit.c | 21 + src/access/viraccessdriverstack.c | 24 + src/access/viraccessmanager.c | 15 + src/access/viraccessmanager.h | 5 + src/access/viraccessperm.c | 7 +- src/access/viraccessperm.h | 39 ++ src/conf/Makefile.inc.am | 6 + src/conf/domain_nwfilter.c | 125 ++++- src/conf/domain_nwfilter.h | 13 - src/conf/nwfilter_conf.c | 223 ++------ src/conf/nwfilter_conf.h | 68 +-- src/conf/nwfilter_params.h | 1 + src/conf/virnwfilterbindingdef.c | 279 ++++++++++ src/conf/virnwfilterbindingdef.h | 65 +++ src/conf/virnwfilterbindingobj.c | 260 ++++++++++ src/conf/virnwfilterbindingobj.h | 60 +++ src/conf/virnwfilterbindingobjlist.c | 475 ++++++++++++++++++ src/conf/virnwfilterbindingobjlist.h | 66 +++ src/conf/virnwfilterobj.c | 4 +- src/conf/virnwfilterobj.h | 4 + src/datatypes.c | 67 +++ src/datatypes.h | 31 ++ src/driver-nwfilter.h | 30 ++ src/libvirt-nwfilter.c | 305 +++++++++++ src/libvirt_private.syms | 42 +- src/libvirt_public.syms | 13 + src/lxc/lxc_driver.c | 28 -- src/nwfilter/nwfilter_dhcpsnoop.c | 151 +++--- src/nwfilter/nwfilter_dhcpsnoop.h | 7 +- src/nwfilter/nwfilter_driver.c | 211 ++++++-- src/nwfilter/nwfilter_gentech_driver.c | 307 +++++------ src/nwfilter/nwfilter_gentech_driver.h | 22 +- src/nwfilter/nwfilter_learnipaddr.c | 98 ++-- src/nwfilter/nwfilter_learnipaddr.h | 7 +- src/qemu/qemu_driver.c | 25 - src/remote/remote_daemon_dispatch.c | 15 + src/remote/remote_driver.c | 20 + src/remote/remote_protocol.x | 90 +++- src/remote_protocol-structs | 43 ++ src/rpc/gendispatch.pl | 15 +- src/uml/uml_driver.c | 29 -- src/util/virerror.c | 12 + src/util/virobject.c | 2 +- tests/Makefile.am | 7 + .../filter-vars.xml | 11 + .../virnwfilterbindingxml2xmldata/simple.xml | 9 + tests/virnwfilterbindingxml2xmltest.c | 113 +++++ tests/virschematest.c | 1 + tools/virsh-completer.c | 45 ++ tools/virsh-completer.h | 4 + tools/virsh-nwfilter.c | 318 ++++++++++++ tools/virsh-nwfilter.h | 8 + 60 files changed, 3247 insertions(+), 792 deletions(-) create mode 100644 docs/schemas/nwfilter_params.rng create mode 100644 docs/schemas/nwfilterbinding.rng create mode 100644 src/conf/virnwfilterbindingdef.c create mode 100644 src/conf/virnwfilterbindingdef.h create mode 100644 src/conf/virnwfilterbindingobj.c create mode 100644 src/conf/virnwfilterbindingobj.h create mode 100644 src/conf/virnwfilterbindingobjlist.c create mode 100644 src/conf/virnwfilterbindingobjlist.h create mode 100644 tests/virnwfilterbindingxml2xmldata/filter-vars.xml create mode 100644 tests/virnwfilterbindingxml2xmldata/simple.xml create mode 100644 tests/virnwfilterbindingxml2xmltest.c -- 2.17.0

3 46

[libvirt] [PATCH] libvirtd: Add service dependency on systemd-logind
by Cole Robinson 12 Jun '18

12 Jun '18

At daemon startup we query logind for host PM support status. Without a service dependency host startup can trigger libvirtd errors like: error : virNodeSuspendSupportsTarget:336 : internal error: Cannot probe for supported suspend types warning : virQEMUCapsInit:949 : Failed to get host power management capabilities Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1588288 Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- src/remote/libvirtd.service.in | 1 + 1 file changed, 1 insertion(+) diff --git a/src/remote/libvirtd.service.in b/src/remote/libvirtd.service.in index 769702ea75..7f689e08a8 100644 --- a/src/remote/libvirtd.service.in +++ b/src/remote/libvirtd.service.in @@ -15,6 +15,7 @@ After=iscsid.service After=apparmor.service After=local-fs.target After=remote-fs.target +After=systemd-logind.service After=systemd-machined.service Documentation=man:libvirtd(8) Documentation=https://libvirt.org -- 2.17.1

2 1

[libvirt] [PATCH libvirt 0/3] events: clean up NULL checking involving virObjectEventStateQueueRemote
by Anya Harter 12 Jun '18

12 Jun '18

Currently, all virObjectEventStateQueue callers and virObjectEventStateQueueRemote callers need to do NULL checking. In this patch series, all NULL checking has been moved to virObjectEventStateQueueRemote and all callers of the Remote or not Remote function have their NULL checking removed. Anya Harter (3): events: add NULL check in virObjectEventStateQueue events: move NULL check to EventStateQueueRemote events: remove remoteEventQueue wrapper function src/bhyve/bhyve_driver.c | 15 ++---- src/conf/object_event.c | 3 ++ src/lxc/lxc_driver.c | 24 ++++------ src/lxc/lxc_process.c | 9 ++-- src/network/bridge_driver.c | 15 ++---- src/node_device/node_device_udev.c | 6 +-- src/qemu/qemu_domain.c | 3 +- src/remote/remote_driver.c | 75 +++++++++++++----------------- src/secret/secret_driver.c | 9 ++-- src/storage/storage_driver.c | 27 ++++------- src/test/test_driver.c | 3 -- src/vz/vz_sdk.c | 3 +- 12 files changed, 73 insertions(+), 119 deletions(-) -- 2.17.1

2 6

[libvirt] [PATCH] apparmor: fix vfio usage without initial hostdev
by Christian Ehrhardt 12 Jun '18

12 Jun '18

The base vfio has not much functionality but to provide a custom container by opening this path. See https://www.kernel.org/doc/Documentation/vfio.txt for more. Systems with static hostdevs will get /dev/vfio/vfio by virt-aa-hotplug right from the beginning. But if the guest initially had no hostdev at all it will run into the following deny before the security module labelling callbacks will make the actual vfio device (like /dev/vfio/93) known. Access by qemu is "wr" even thou in theory it could maybe be "r": [ 2652.756712] audit: type=1400 audit(1491303691.719:25): apparmor="DENIED" operation="open" profile="libvirt-17a61b87-5132-497c-b928-421ac2ee0c8a" name="/dev/vfio/vfio" pid=8486 comm="qemu-system-x86" requested_mask="wr" denied_mask="wr" fsuid=64055 ouid=0 Bug-Ubuntu: https://bugs.launchpad.net/bugs/1678322 Bug-Ubuntu: https://bugs.launchpad.net/bugs/1775777 Signed-off-by: Christian Ehrhardt <christian.ehrhardt(a)canonical.com> Signed-off-by: Stefan Bader <stefan.bader(a)canonical.com> --- examples/apparmor/libvirt-qemu | 3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/apparmor/libvirt-qemu b/examples/apparmor/libvirt-qemu index 2c47652250..874aca2092 100644 --- a/examples/apparmor/libvirt-qemu +++ b/examples/apparmor/libvirt-qemu @@ -193,6 +193,9 @@ deny /dev/shm/lttng-ust-wait-* r, deny /run/shm/lttng-ust-wait-* r, + # for vfio hotplug on systems without static vfio (LP: #1775777) + /dev/vfio/vfio rw, + # required for sasl GSSAPI plugin /etc/gss/mech.d/ r, /etc/gss/mech.d/* r, -- 2.17.1

3 4

[libvirt] [PATCH] qemu: Check for existing hostdev address for cold attach device
by John Ferlan 12 Jun '18

12 Jun '18

https://bugzilla.redhat.com/show_bug.cgi?id=1559867 Add a check if the incoming <hostdev ...> with specified <address> already exists and if so fail the attach. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- src/qemu/qemu_driver.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 38ea865ce3..7b4cdbcdcf 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -8014,6 +8014,12 @@ qemuDomainAttachDeviceConfig(virDomainDefPtr vmdef, _("device is already in the domain configuration")); return -1; } + if (dev->data.hostdev->info->type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE && + virDomainDefHasDeviceAddress(vmdef, dev->data.hostdev->info)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("a device with the same address already exists ")); + return -1; + } if (virDomainHostdevInsert(vmdef, hostdev)) return -1; dev->data.hostdev = NULL; -- 2.14.4

2 2

[libvirt] [PATCH v2 0/5] Require GnuTLS
by Michal Privoznik 12 Jun '18

12 Jun '18

v2 of: diff to v1: - Reworded commit message of 1/3 - Broken 2/3 into three separate patches: 1) removing WITH_GNUTLS conditional from src/ 2) removing libvirt_gnutls.syms 3) removing WITH_GNUTLS conditional from tests/ Michal Privoznik (5): configure: Require GnuTLS src: Always build virnettlscontext into libvirt-net-rpc.la src: Dissolve libvirt_gnutls.syms in libvirt_remote.syms tests: Always build TLS related tests src: Drop most of #ifdef WITH_GNUTLS configure.ac | 2 -- m4/virt-gnutls.m4 | 4 --- src/Makefile.am | 6 ---- src/libvirt_gnutls.syms | 48 ------------------------------- src/libvirt_remote.syms | 25 ++++++++++++++++ src/locking/lock_daemon.c | 4 --- src/logging/log_daemon.c | 4 --- src/lxc/lxc_controller.c | 2 -- src/qemu/qemu_migration_cookie.c | 12 +++----- src/remote/remote_daemon.c | 23 --------------- src/remote/remote_daemon_dispatch.c | 2 -- src/rpc/Makefile.inc.am | 14 ++------- src/rpc/virnetdaemon.h | 4 +-- src/rpc/virnetserver.c | 6 ---- src/rpc/virnetserver.h | 6 +--- src/rpc/virnetserverclient.c | 57 +++---------------------------------- src/rpc/virnetserverclient.h | 8 ------ src/rpc/virnetserverservice.c | 24 ---------------- src/rpc/virnetserverservice.h | 10 ------- src/util/vircrypto.c | 43 ++-------------------------- tests/Makefile.am | 12 ++------ tests/qemuxml2argvtest.c | 15 ---------- tests/vircryptotest.c | 24 +++++----------- tests/virfilecachetest.c | 18 +++--------- tests/virnetdaemontest.c | 8 ------ tests/virnetserverclienttest.c | 2 -- tests/virrandommock.c | 8 ++---- 27 files changed, 56 insertions(+), 335 deletions(-) delete mode 100644 src/libvirt_gnutls.syms -- 2.16.4

4 28