- Devel - libvirt List Archives

[libvirt] [PATCH] mingw: unconditionally enable libssh2 in RPM
by Daniel P. Berrangé 03 Apr '19

03 Apr '19

The libssh2 support in libvirt is not solely for phyp, it is used by the remote driver too. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- mingw-libvirt.spec.in | 2 -- 1 file changed, 2 deletions(-) diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in index 9983a5013f..913aaa8751 100644 --- a/mingw-libvirt.spec.in +++ b/mingw-libvirt.spec.in @@ -85,10 +85,8 @@ BuildRequires: gettext-devel BuildRequires: libtool %endif -%if %{with_phyp} BuildRequires: mingw32-libssh2 BuildRequires: mingw64-libssh2 -%endif %if %{with_esx} BuildRequires: mingw32-curl BuildRequires: mingw64-curl -- 2.20.1

2 1

[libvirt] [PATCH] mingw: remove obsolete Group tag in RPM spec
by Daniel P. Berrangé 03 Apr '19

03 Apr '19

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- mingw-libvirt.spec.in | 1 - 1 file changed, 1 deletion(-) diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in index bea822fd73..9983a5013f 100644 --- a/mingw-libvirt.spec.in +++ b/mingw-libvirt.spec.in @@ -39,7 +39,6 @@ Release: 1%{?dist} Summary: MinGW Windows libvirt virtualization library License: LGPLv2+ -Group: Development/Libraries URL: https://libvirt.org/ %if %(echo %{version} | grep -q "\.0$"; echo $?) == 1 -- 2.20.1

2 1

[libvirt] [PATCH v3 0/6] Facilitate running libvirt builds via docker containers
by Daniel P. Berrangé 03 Apr '19

03 Apr '19

For a while QEMU has provided simple make rules for building QEMU inside standard docker container environments. This provides an equivalent mechanism for libvirt inspired by QEMU's. QEMU actually builds the container images on developer's machines locally. Libvirt already hosts pre-built images on quay.io, so that is used directly as it is quicker to download them than to build them locally. This also ensures the container contents match what the live CI system is using, as opposed to building an image with newer packages. NB, there is a currently a test failure with this change to travis that we don't currently see. Current travis runs a privileged docker container, but with this change we now run unprivileged containers. This shows that the "virsh-snapshot" test is trying to create a file under $HOME, and docker blocks this. Obviously needs fixing before pushing. Changed in v3: - Lots of new variables & variable renames - Rename to top level Makefile.ci - Rename make targets to have @ separator for the image - Refactor macOS travis config Changed in v2: - Drop cross-compilation patches temporarily. The cross-compiler images are not yet built on quay.io and rather than creating and bulding many more images manually, I'm working on script to automate setup of quay.io images - Many changes to the make rules to make it possible to use them from Travis CI to match its currently testing setup - Modify Travis CI config to use the new make rules for consistency Daniel P. Berrangé (6): tests: don't abort in fopen(/proc/mounts) tests: add targets for building libvirt inside docker containers travis: convert ubuntu, centos & mingw builds to use new make rules travis: use declarative syntax for homebrew packages travis: remove display of test-suite.log from macOS travis: put macOS script inline in the macOS matrix entry .gitignore | 1 + .travis.yml | 78 +++++----------- Makefile.am | 2 + Makefile.ci | 206 ++++++++++++++++++++++++++++++++++++++++++ tests/vircgroupmock.c | 6 +- 5 files changed, 235 insertions(+), 58 deletions(-) create mode 100644 Makefile.ci -- 2.20.1

3 20

[libvirt] [PATCH] virjson: drop compatibility macros
by Ján Tomko 03 Apr '19

03 Apr '19

Since commit 66460e3 dropped support for YAJL 1, we no longer need these. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/util/virjson.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/util/virjson.c b/src/util/virjson.c index bb4052ba81..1dceb746b9 100644 --- a/src/util/virjson.c +++ b/src/util/virjson.c @@ -34,8 +34,6 @@ # include <yajl/yajl_gen.h> # include <yajl/yajl_parse.h> -# define yajl_size_t size_t -# define VIR_YAJL_STATUS_OK(status) ((status) == yajl_status_ok) #endif /* XXX fixme */ @@ -1615,7 +1613,7 @@ virJSONParserHandleBoolean(void *ctx, static int virJSONParserHandleNumber(void *ctx, const char *s, - yajl_size_t l) + size_t l) { virJSONParserPtr parser = ctx; char *str; @@ -1643,7 +1641,7 @@ virJSONParserHandleNumber(void *ctx, static int virJSONParserHandleString(void *ctx, const unsigned char *stringVal, - yajl_size_t stringLen) + size_t stringLen) { virJSONParserPtr parser = ctx; virJSONValuePtr value = virJSONValueNewStringLen((const char *)stringVal, @@ -1666,7 +1664,7 @@ virJSONParserHandleString(void *ctx, static int virJSONParserHandleMapKey(void *ctx, const unsigned char *stringVal, - yajl_size_t stringLen) + size_t stringLen) { virJSONParserPtr parser = ctx; virJSONParserStatePtr state; @@ -1824,7 +1822,7 @@ virJSONValueFromString(const char *jsonstring) /* Yajl 2 is nice enough to default to rejecting trailing garbage. */ rc = yajl_parse(hand, (const unsigned char *)jsonstring, len); - if (!VIR_YAJL_STATUS_OK(rc) || + if (rc != yajl_status_ok || yajl_complete_parse(hand) != yajl_status_ok) { unsigned char *errstr = yajl_get_error(hand, 1, (const unsigned char*)jsonstring, @@ -1935,7 +1933,7 @@ virJSONValueToBuffer(virJSONValuePtr object, { yajl_gen g; const unsigned char *str; - yajl_size_t len; + size_t len; int ret = -1; VIR_DEBUG("object=%p", object); -- 2.19.2

3 2

[libvirt] [PATCH] rbd: fix build with LIBRBD_VERSION_CODE <= 265
by Ján Tomko 03 Apr '19

03 Apr '19

Add ATTRIBUTE_UNUSED to the volStorageBackendRBDGetFlags stub. Fixes: 21deeaf02fdf216b08210fc899579736973ca81d Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed as a build breaker fix src/storage/storage_backend_rbd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c index 29f6a5de60..f8c968e682 100644 --- a/src/storage/storage_backend_rbd.c +++ b/src/storage/storage_backend_rbd.c @@ -501,8 +501,8 @@ virStorageBackendRBDSetAllocation(virStorageVolDefPtr vol, #else static int -volStorageBackendRBDGetFlags(rbd_image_t image, - const char *volname, +volStorageBackendRBDGetFlags(rbd_image_t image ATTRIBUTE_UNUSED, + const char *volname ATTRIBUTE_UNUSED, uint64_t *flags) { *flags = 0; -- 2.19.2

1 0

[libvirt] [PATCHv2 00/14] virjsontest: separate some tests into files
by Ján Tomko 03 Apr '19

03 Apr '19

v1: cover.1549987014.git.jtomko(a)redhat.com v2: prettify output, use VIR_AUTO and better-looking commit messages Ján Tomko (14): virjsontest: switch AddAndRemove tests to work with files testJSONFromString: regroup if blocks virjsontest: reword error messages in testJSONFromString virjsontest: use VIR_AUTOPTR for virJSONValues virjsontest: use VIR_AUTOFREE for strings virjsontest: remove unnecessary cleanup labels virjsontest: introduce DO_TEST_PARSE_FILE virjsontest: switch DO_TEST_PARSE_FILE to use output files virjsontest: reformat add-remove test input data vvv--- squash into: json_reformat add-remove output data virjsontest: prettify AddRemove test virjsondata: json_reformat input data vvv SQUASH HERE: reformat parseFile output data virjsontest: prettify JSONFromFile test tests/virjsondata/add-remove-failure-in.json | 3 + tests/virjsondata/add-remove-success-in.json | 4 + tests/virjsondata/add-remove-success-out.json | 4 + tests/virjsondata/parse-Harder-in.json | 13 + tests/virjsondata/parse-Harder-out.json | 13 + tests/virjsondata/parse-NotSoSimple-in.json | 15 + tests/virjsondata/parse-NotSoSimple-out.json | 15 + tests/virjsondata/parse-Simple-in.json | 6 + tests/virjsondata/parse-Simple-out.json | 6 + tests/virjsondata/parse-VeryHard-in.json | 143 +++++++ tests/virjsondata/parse-VeryHard-out.json | 143 +++++++ tests/virjsontest.c | 370 ++++++++---------- 12 files changed, 531 insertions(+), 204 deletions(-) create mode 100644 tests/virjsondata/add-remove-failure-in.json create mode 100644 tests/virjsondata/add-remove-success-in.json create mode 100644 tests/virjsondata/add-remove-success-out.json create mode 100644 tests/virjsondata/parse-Harder-in.json create mode 100644 tests/virjsondata/parse-Harder-out.json create mode 100644 tests/virjsondata/parse-NotSoSimple-in.json create mode 100644 tests/virjsondata/parse-NotSoSimple-out.json create mode 100644 tests/virjsondata/parse-Simple-in.json create mode 100644 tests/virjsondata/parse-Simple-out.json create mode 100644 tests/virjsondata/parse-VeryHard-in.json create mode 100644 tests/virjsondata/parse-VeryHard-out.json -- 2.19.2

2 22

[libvirt] [PATCH 00/14] virsh: introduce a password completer
by Ján Tomko 03 Apr '19

03 Apr '19

Ján Tomko (14): virsh: fix indentation of info_managed_save_edit virsh-completer: fix typo virsh-completer: reword documentation virsh-completer: switch to using tmp instead of ret virsh-completer: add a cleanup label everywhere virsh-completer: unify cleanup of items in name completers virsh-completer: virStringListFree where possible virsh-completer: use VIR_AUTOSTRINGLIST for tmp use VIR_AUTOFREE for xmlNodePtr* variables virsh-completer: use VIR_AUTOPTR for xml* variables virsh-completer: use VIR_AUTOFREE for char* variables virsh-completer: remove excessive labels virsh-completer: introduce virshPagesizeNodeToString virsh-completer: introduce virshPasswordCompleter tools/virsh-completer.c | 611 +++++++++++++++++++--------------------- tools/virsh-completer.h | 4 + tools/virsh-domain.c | 15 +- 3 files changed, 295 insertions(+), 335 deletions(-) -- 2.20.1

5 30

[libvirt] [PATCH 0/7] qemu: Improve JSON handling in monitor interactions
by Peter Krempa 03 Apr '19

03 Apr '19

Remove a few unnecessary copies of the JSON string as well as duplicate and unneeded debug logs. Peter Krempa (7): util: buffer: Remove struct member munging util: buffer: Use 'size_t' for buffer size variables util: json: Use virBuffer in JSON->string conversion util: json: Don't bother logging output string in virJSONValueToString util: json: Export virJSONValueToBuffer qemu: monitor: Remove few debug statements qemu: monitor: Avoid unnecessary copies of command string src/libvirt_private.syms | 1 + src/qemu/qemu_monitor_json.c | 19 ++++++++----------- src/util/virbuffer.c | 14 +------------- src/util/virbuffer.h | 18 +++++++----------- src/util/virjson.c | 33 ++++++++++++++++++++++++--------- src/util/virjson.h | 5 +++++ tests/virbuftest.c | 4 +++- 7 files changed, 49 insertions(+), 45 deletions(-) -- 2.20.1

2 18

[libvirt] [PATCH v6 00/33] BaselineHypervisorCPU using QEMU QMP exchanges
by Chris Venteicher 02 Apr '19

02 Apr '19

Some architectures (S390) depend on QEMU to compute baseline CPU model and expand a models feature set. Interacting with QEMU requires starting the QEMU process and completing one or more query-cpu-model-baseline QMP exchanges with QEMU in addition to a query-cpu-model-expansion QMP exchange to expand all features in the model. See "s390x CPU models: exposing features" patch set on Qemu-devel for discussion of QEMU aspects. This is part of resolution of: https://bugzilla.redhat.com/show_bug.cgi?id=1511999 ----- v6 addresses these issues from v5: qemu_process: Move process code from qemu_capabilities to qemu_process [x] Remove exception statement from commit message qemu_process: Use qemuProcessQmp prefix [x] s/ProcessQmp/ProcessQMP/ in this and all subsequent patches qemu_process: Refer to proc not cmd in process code [x] Back port indentation fix in qemuProcessQMPRun qemu_capabilities: Stop QEMU process before freeing [x] Back port !proc check in qemuProcessQmpStop qemu_process: Use qemuProcessQmp struct for a single process [x] Remove extra empty lines qemu_process: All ProcessQMP errors are fatal [x] Split into multiple patches qemu_process: Introduce qemuProcessQmpStart [x] Log function parameters separately in the first function debug message [x] Removed NULLSTR check on proc-binary (would fail previously on proc activate) [x] Back port referring to stderr rather than qmperr in comment [ ] Combine qemuProcessQmpStop and qemuProcessQmpFree (See reply to v5 email) emu_process: Collect monitor code in single function [x] Back port qemuMonitorOpen indent fix to earlier patch qemu_process: Don't open monitor if process failed [x] Drop patch qemu_process: Cleanup qemuProcessQmp alloc function [x] s/Qemu/QEMU/ in comments for qemuProcessQMPNew [x] Remove unneeded use of NULLSTR and NULL check before calling qemuProcessQmpFree qemu_process: Cleanup qemuProcessQmpStop function [x] Remove lines from from commit message [x] Remove capitalization from comment [x] Fix func def to match coding style [x] Back port !proc check to earlier patch qemu_process: Catch process free before process stop [x] Remove capitalization from comment [x] Don't do proc NULL check in VIR_DEBUG [ ] Combine qemuProcessQmpStop and qemuProcessQmpFree (See reply to v5 email) qemu_monitor: Make monitor callbacks optional [x] Drop patch qemu_process: Enter QMP command mode when starting QEMU Process [ ] Don't call qemuMonitorSetCapabilities in qemuProcessQMPConnectMonitor (See reply to v5 email) qemu_process: Use unique directories for QMP processes [x] s/qemu./qmp-/ for QMP process directory name prefix [x] Catch mkdtemp returns NULL qemu_process: Stop locking QMP process monitor immediately [x] Drop patch qemu_monitor: Introduce qemuMonitorCPUModelInfoNew [x] Use qemuMonitorCPUModelInfoNew to set model name [x] Drop variable initialization [x] Use qemuMonitorCPUModelInfoNew in qemuMonitorJSONGetCPUModelExpansion (Pull forward) [ ] Remove orig NULL check (Unit tests fail if I do this) qemu_monitor: Introduce qemuMonitorCPUModelInfo / JSON conversion [x] Make variable initialization easier to read in PropAdd [x] Require at least one "prop" (don't allow zero in this commit) qemu_capabilities: Introduce virQEMuCapsMigratablePropsDiff [x] Remove template txt in commit message [x] Change function name [x] Distinguish nmProp from mProp [x] Don't set cpuData->info to NULL [ ] Don't use tmp (defer to next patch set... out of time) qemu_monitor: qemuMonitorGetCPUModelExpansion inputs and outputs CPUModelInfo [x] Remove extra line from commit message [x] Change parameter order [x] Don't use VIR_STEAL_PTR qemu_capabilities: Introduce CPUModelInfo to virCPUDef function [x] Change comment [x] Change parameter order [x] Separate lines [x] Move debug message before alloc [x] Back port function spacing fix from next patch qemu_capabilities: Introduce virCPUDef to CPUModelInfo function [x] Change comment [x] Move debug message before alloc [x] Remove NULL check on feature->name [x] Document prop value semantics Reviewed in v5 but no changes required: qemu_process: Limit qemuProcessQmpNew to const input strings qemu_process: Use consistent name for stop process function qemu_process: Persist stderr in qemuProcessQmp struct qemu_process: Store libDir in qemuProcessQmp struct qemu_process: Setup paths within qemuProcessQmpInit qemu_process: Stop retaining Monitor config in qemuProcessQmp Not reviewed in v5: qemu_monitor: Support query-cpu-model-baseline QMP command qemu_driver: Consolidate code to baseline using libvirt qemu_driver: Decouple code for baseline using libvirt qemu_driver: Identify using libvirt as a distinct way to compute baseline qemu_driver: Support baseline calculation using QEMU qemu_driver: Support feature expansion via QEMU when baselining cpu qemu_driver: Remove unsupported props in expanded hypervisor baseline output qemu_monitor: Default props to migratable when expanding cpu model ----- v5: Fixes all process issues identified here: https://www.redhat.com/archives/libvir-list/2018-November/msg00349.html - Make the process code generic (not capabilities specific) for use by BaselineHypervisorCPU - Many of the process patches are simple code moves with implementation changes in other distinct patches - A thread safe library function creates a unique directory under libDir for each QEMU process (for QMP messaging) to decouple processes in terms of sockets and file system footprint. The remaining (non-process) patches in v4 address all issues in v1-v4 of 'BaselineHypervisorCPU using QEMU QMP exchanges' Thanks, Chris *** BLURB HERE *** Chris Venteicher (33): qEmu_process: Move process code from qemu_capabilities to qemu_process qemu_process: Use qemuProcessQMP prefix qemu_process: Limit qemuProcessQMPNew to const input strings qemu_process: Refer to proc not cmd in process code qemu_process: Use consistent name for stop process function qemu_capabilities: Stop QEMU process before freeing qemu_process: Use qemuProcessQMP struct for a single process qemu_process: All ProcessQMP errors are fatal qemu_process: Expose process exit status code qemu_process: Persist stderr in qemuProcessQMP struct qemu_process: Introduce qemuProcessQMPStart qemu_process: Collect monitor code in single function qemu_process: Store libDir in qemuProcessQMP struct qemu_process: Setup paths within qemuProcessQMPInit qemu_process: Stop retaining Monitor config in qemuProcessQMP qemu_process: Cleanup qemuProcessQMP alloc function qemu_process: Cleanup qemuProcessQMPStop function qemu_process: Catch process free before process stop qemu_process: Enter QMP command mode when starting QEMU Process qemu_process: Use unique directories for QMP processes qemu_monitor: Introduce qemuMonitorCPUModelInfoNew qemu_monitor: Introduce qemuMonitorCPUModelInfo / JSON conversion qemu_capabilities: Introduce virQEMuCapsMigratablePropsCalc qemu_monitor: qemuMonitorGetCPUModelExpansion inputs and outputs CPUModelInfo qemu_capabilities: Introduce CPUModelInfo to virCPUDef function qemu_capabilities: Introduce virCPUDef to CPUModelInfo function qemu_monitor: Support query-cpu-model-baseline QMP command qemu_driver: Consolidate code to baseline using libvirt qemu_driver: Decouple code for baseline using libvirt qemu_driver: Identify using libvirt as a distinct way to compute baseline qemu_driver: Support baseline calculation using QEMU qemu_driver: Support feature expansion via QEMU when baselining cpu qemu_monitor: Default props to migratable when expanding cpu model src/qemu/qemu_capabilities.c | 631 ++++++++---------- src/qemu/qemu_capabilities.h | 4 + src/qemu/qemu_driver.c | 216 +++++- src/qemu/qemu_monitor.c | 165 ++++- src/qemu/qemu_monitor.h | 29 +- src/qemu/qemu_monitor_json.c | 223 +++++-- src/qemu/qemu_monitor_json.h | 10 +- src/qemu/qemu_process.c | 345 ++++++++++ src/qemu/qemu_process.h | 32 + tests/cputest.c | 11 +- .../caps_2.10.0.s390x.xml | 60 +- .../caps_2.11.0.s390x.xml | 58 +- .../caps_2.12.0.s390x.xml | 56 +- .../qemucapabilitiesdata/caps_2.8.0.s390x.xml | 32 +- .../qemucapabilitiesdata/caps_2.9.0.s390x.xml | 34 +- .../qemucapabilitiesdata/caps_3.0.0.s390x.xml | 64 +- tests/qemucapabilitiestest.c | 7 + 17 files changed, 1375 insertions(+), 602 deletions(-) -- 2.17.1

2 34

[libvirt] [PATCH 0/5] qemu: caps: Always assume most of block job capabilities
by Peter Krempa 02 Apr '19

02 Apr '19

Peter Krempa (5): qemu: capabilities: Always assume QEMU_CAPS_BLOCKJOB_ASYNC qemu: domain: drop qemuDomainSupportsBlockJobs qemu: capabilities: Always assume QEMU_CAPS_BLOCK_COMMIT qemu: capabilities: Always assume QEMU_CAPS_DRIVE_MIRROR qemu: capabilities: Always assume disk snapshot caps src/qemu/qemu_capabilities.c | 13 +---- src/qemu/qemu_capabilities.h | 10 ++-- src/qemu/qemu_domain.c | 23 -------- src/qemu/qemu_domain.h | 2 - src/qemu/qemu_driver.c | 34 ------------ src/qemu/qemu_migration.c | 53 ++++++++----------- .../caps_1.5.3.x86_64.xml | 5 -- .../caps_1.6.0.x86_64.xml | 5 -- .../caps_1.7.0.x86_64.xml | 5 -- .../caps_2.1.1.x86_64.xml | 5 -- .../caps_2.10.0.aarch64.xml | 5 -- .../caps_2.10.0.ppc64.xml | 5 -- .../caps_2.10.0.s390x.xml | 5 -- .../caps_2.10.0.x86_64.xml | 5 -- .../caps_2.11.0.s390x.xml | 5 -- .../caps_2.11.0.x86_64.xml | 5 -- .../caps_2.12.0.aarch64.xml | 5 -- .../caps_2.12.0.ppc64.xml | 5 -- .../caps_2.12.0.s390x.xml | 5 -- .../caps_2.12.0.x86_64.xml | 5 -- .../caps_2.4.0.x86_64.xml | 5 -- .../caps_2.5.0.x86_64.xml | 5 -- .../caps_2.6.0.aarch64.xml | 5 -- .../qemucapabilitiesdata/caps_2.6.0.ppc64.xml | 5 -- .../caps_2.6.0.x86_64.xml | 5 -- .../qemucapabilitiesdata/caps_2.7.0.s390x.xml | 5 -- .../caps_2.7.0.x86_64.xml | 5 -- .../qemucapabilitiesdata/caps_2.8.0.s390x.xml | 5 -- .../caps_2.8.0.x86_64.xml | 5 -- .../qemucapabilitiesdata/caps_2.9.0.ppc64.xml | 5 -- .../qemucapabilitiesdata/caps_2.9.0.s390x.xml | 5 -- .../caps_2.9.0.x86_64.xml | 5 -- .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 5 -- .../caps_3.0.0.riscv32.xml | 5 -- .../caps_3.0.0.riscv64.xml | 5 -- .../qemucapabilitiesdata/caps_3.0.0.s390x.xml | 5 -- .../caps_3.0.0.x86_64.xml | 5 -- .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 5 -- .../caps_3.1.0.x86_64.xml | 5 -- .../caps_4.0.0.riscv32.xml | 5 -- .../caps_4.0.0.riscv64.xml | 5 -- .../caps_4.0.0.x86_64.xml | 5 -- 42 files changed, 27 insertions(+), 288 deletions(-) -- 2.20.1

2 6

[libvirt] [PATCH 0/4] Fix various test portability problems
by Daniel P. Berrangé 02 Apr '19

02 Apr '19

This includes a slight tweak to the stat/lstat patch wrt logging and fixes use of the dirent d_type field. Daniel P. Berrangé (4): tests: fix mocking of stat() / lstat() functions qemu: don't rely on the non-portable d_type field in dirent security: avoid use of dirent d_type field cfg.mk: block use of d_type from dirent by default build-aux/mock-noinline.pl | 3 + cfg.mk | 20 +- src/qemu/qemu_firmware.c | 12 +- src/security/security_selinux.c | 6 +- tests/Makefile.am | 1 + tests/qemusecuritymock.c | 131 ++++--------- tests/vircgroupmock.c | 146 ++------------ tests/virfilewrapper.c | 85 ++------- tests/virmock.h | 11 -- tests/virmockstathelpers.c | 326 ++++++++++++++++++++++++++++++++ tests/virpcimock.c | 93 +-------- tests/virtestmock.c | 140 +------------- 12 files changed, 440 insertions(+), 534 deletions(-) create mode 100644 tests/virmockstathelpers.c -- 2.20.1

2 8

[libvirt] [PATCH 00/10] Improve handling of secrets in memory
by Peter Krempa 02 Apr '19

02 Apr '19

Peter Krempa (10): qemu: conf: Clear spice/vnc passwords from memory when freeing conf object util: alloc: Add automatic cleanup/disposal of strings Use VIR_AUTODISPOSE_STR instead of VIR_DISPOSE_STRING where possible util: buffer: Remove struct member munging util: alloc: Clean also stack'd data with VIR_AUTOCLEAN util: alloc: Introduce VIR_TMP qemu: Use VIR_TMP to stop leaking pointer to VNC password pointer to stack util: Introduce 'virpin' module for dealing with PIN numbers util: json: Make sure that Jano's pin is not leaked to the heap util: json: Nuke strings when freeing JSON objects cfg.mk | 2 +- src/Makefile.am | 3 + src/libvirt_private.syms | 6 + src/libxl/libxl_conf.c | 3 +- src/qemu/qemu_command.c | 3 +- src/qemu/qemu_conf.c | 4 +- src/qemu/qemu_hotplug.c | 2 +- src/rpc/virnetlibsshsession.c | 10 +- src/storage/storage_backend_rbd.c | 3 +- src/util/Makefile.inc.am | 2 + src/util/viralloc.c | 23 + src/util/viralloc.h | 32 +- src/util/virbuffer.c | 12 - src/util/virbuffer.h | 16 +- src/util/virjson.c | 8 +- src/util/virpin.c | 1053 +++++++++++++++++++++++++++++ src/util/virpin.h | 30 + tests/utiltest.c | 30 + tests/virbuftest.c | 2 +- tools/virsh-secret.c | 3 +- 20 files changed, 1200 insertions(+), 47 deletions(-) create mode 100644 src/util/virpin.c create mode 100644 src/util/virpin.h -- 2.20.1

2 14

[libvirt] [PATCH 0/5] qemu: Fix memfd with default hugetlbfs mount
by Michal Privoznik 02 Apr '19

02 Apr '19

Michal Prívozník (5): qemuxml2argvdata: Drop useless spaces at the beginning of lines qemuxml2xmltest: Move virObjectUnref() call qemuxml2xmltest: Add memfd tests virfile: Introduce and use virFileGetDefaultHugepage qemuBuildMemoryBackendProps: Get pagesize early src/libvirt_private.syms | 1 + src/qemu/qemu_command.c | 14 ++++ src/qemu/qemu_conf.c | 12 +-- src/util/virfile.c | 25 ++++++ src/util/virfile.h | 3 + .../fd-memory-no-numa-topology.xml | 14 +++- .../fd-memory-numa-topology.xml | 12 ++- .../fd-memory-numa-topology2.xml | 70 +++++++++------- .../fd-memory-numa-topology3.xml | 72 +++++++++-------- ...memory-default-hugepage.x86_64-latest.args | 37 +++++++++ .../memfd-memory-default-hugepage.xml | 42 ++++++++++ .../memfd-memory-numa.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/memfd-memory-numa.xml | 80 ++++++++++--------- tests/qemuxml2argvtest.c | 1 + .../fd-memory-no-numa-topology.xml | 1 + .../fd-memory-numa-topology.xml | 1 + .../fd-memory-numa-topology2.xml | 1 + .../fd-memory-numa-topology3.xml | 1 + .../memfd-memory-default-hugepage.xml | 1 + .../qemuxml2xmloutdata/memfd-memory-numa.xml | 1 + tests/qemuxml2xmltest.c | 18 ++++- 21 files changed, 295 insertions(+), 114 deletions(-) create mode 100644 tests/qemuxml2argvdata/memfd-memory-default-hugepage.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/memfd-memory-default-hugepage.xml create mode 120000 tests/qemuxml2xmloutdata/fd-memory-no-numa-topology.xml create mode 120000 tests/qemuxml2xmloutdata/fd-memory-numa-topology.xml create mode 120000 tests/qemuxml2xmloutdata/fd-memory-numa-topology2.xml create mode 120000 tests/qemuxml2xmloutdata/fd-memory-numa-topology3.xml create mode 120000 tests/qemuxml2xmloutdata/memfd-memory-default-hugepage.xml create mode 120000 tests/qemuxml2xmloutdata/memfd-memory-numa.xml -- 2.21.0

2 11

[libvirt] [PATCH 0/3] maint: Drop ChangeLog*
by Andrea Bolognani 02 Apr '19

02 Apr '19

Rationale in the respective commit messages. Patch 2/3 has been snipped quite extensively so that it would make it to the mailing list: the unabridged version of this series can be fetched from https://github.com/andreabolognani/libvirt/tree/changelog Andrea Bolognani (3): maint: Stop generating ChangeLog from git maint: Drop ChangeLog-old maint: Update references to ChangeLog* .gitignore | 1 - ChangeLog | 15 + ChangeLog-old | 16699 ------------------------------------------ Makefile.am | 15 +- bootstrap.conf | 4 +- cfg.mk | 2 +- docs/news-ascii.xsl | 3 +- 7 files changed, 21 insertions(+), 16718 deletions(-) create mode 100644 ChangeLog delete mode 100644 ChangeLog-old -- 2.20.1

4 12

[libvirt] [PATCH] virDirRead: Fix d_type if needed
by Michal Privoznik 02 Apr '19

02 Apr '19

Some of our code iterates over a directory and does some decisions based on entry type (e.g. if it's not a regular file continue with next iteration). This is done by looking at ent->d_type struct member. However, in some cases (e.g. for some filesystems) the d_type can be set to DT_UNKNOWN which effectively defeats the aforementioned checks. For instance, some XFS' (depending on how they were created) might not bother filling the member. Fix this by running stat() and filling in the member ourselves. If needed. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- With Dan's patch that fixes stat() mocking, I'm passing tests successfully everywhere I tried (32bit fedora and gentoo on RPi, RHEL-7, amd64 gentoo, fedora rawhide on x86_64) src/util/virfile.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/src/util/virfile.c b/src/util/virfile.c index ec8d85929c..7d7c27a7d2 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -2893,6 +2893,39 @@ virDirOpenQuiet(DIR **dirp, const char *name) return virDirOpenInternal(dirp, name, false, true); } +static int +virDirReadFixDType(DIR *dirp, struct dirent *ent) +{ + /* DO NOT CLOSE THIS FD */ + const int fd = dirfd(dirp); + struct stat sb; + + if (fd < 0) + return -1; + + if (fstatat(fd, ent->d_name, &sb, AT_NO_AUTOMOUNT | AT_SYMLINK_NOFOLLOW) < 0) + return -1; + + if (S_ISDIR(sb.st_mode)) + ent->d_type = DT_DIR; + else if (S_ISCHR(sb.st_mode)) + ent->d_type = DT_CHR; + else if (S_ISBLK(sb.st_mode)) + ent->d_type = DT_BLK; + else if (S_ISREG(sb.st_mode)) + ent->d_type = DT_REG; + else if (S_ISFIFO(sb.st_mode)) + ent->d_type = DT_FIFO; + else if (S_ISLNK(sb.st_mode)) + ent->d_type = DT_LNK; + else if (S_ISSOCK(sb.st_mode)) + ent->d_type = DT_SOCK; + else + return -1; + + return 0; +} + /** * virDirRead: * @dirp: directory to read @@ -2926,6 +2959,17 @@ int virDirRead(DIR *dirp, struct dirent **ent, const char *name) } } while (*ent && (STREQ((*ent)->d_name, ".") || STREQ((*ent)->d_name, ".."))); + + if (*ent && + (*ent)->d_type == DT_UNKNOWN && + virDirReadFixDType(dirp, *ent) < 0) { + if (name) + virReportSystemError(errno, + _("Unable to fix d_type of '%s/%s'"), + name, (*ent)->d_name); + return -1; + } + return !!*ent; } -- 2.21.0

2 1

[libvirt] [PATCH v2] examples: fix 64-bit integer formatting on Windows
by Daniel P. Berrangé 02 Apr '19

02 Apr '19

The Windows printf functions don't support %llu/%lld for printing 64-bit integers. For most of libvirt this doesn't matter as we rely on gnulib which provides a replacement printf that is sane. The example code is designed to compile against the normal OS headers, with no use of gnulib and thus has to use the platform specific printf. To deal with this we must use the macros PRI* macros from inttypes.h to get the platform specific format string. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- examples/admin/client_info.c | 7 ++++--- examples/admin/list_clients.c | 3 ++- examples/domtop/domtop.c | 8 ++++++-- 3 files changed, 12 insertions(+), 6 deletions(-) Changed in v2: - Now actually commit the int64 casts diff --git a/examples/admin/client_info.c b/examples/admin/client_info.c index f3f62a656b..7fc6c72bbd 100644 --- a/examples/admin/client_info.c +++ b/examples/admin/client_info.c @@ -3,6 +3,7 @@ #include <stdlib.h> #include <time.h> #include <string.h> +#include <inttypes.h> #include <libvirt/libvirt-admin.h> static const char * @@ -66,11 +67,11 @@ exampleGetTypedParamValue(virTypedParameterPtr item) break; case VIR_TYPED_PARAM_LLONG: - ret = asprintf(&str, "%lld", item->value.l); + ret = asprintf(&str, "%" PRId64, (int64_t)item->value.l); break; case VIR_TYPED_PARAM_ULLONG: - ret = asprintf(&str, "%llu", item->value.ul); + ret = asprintf(&str, "%" PRIu64, (uint64_t)item->value.ul); break; case VIR_TYPED_PARAM_DOUBLE: @@ -143,7 +144,7 @@ int main(int argc, char **argv) if (!(timestr = exampleGetTimeStr(virAdmClientGetTimestamp(clnt)))) goto cleanup; - printf("%-15s: %llu\n", "id", virAdmClientGetID(clnt)); + printf("%-15s: %" PRIu64 "\n", "id", (uint64_t)virAdmClientGetID(clnt)); printf("%-15s: %s\n", "connection_time", timestr); printf("%-15s: %s\n", "transport", exampleTransportToString(virAdmClientGetTransport(clnt))); diff --git a/examples/admin/list_clients.c b/examples/admin/list_clients.c index 5cf8e4c2a6..2876637d42 100644 --- a/examples/admin/list_clients.c +++ b/examples/admin/list_clients.c @@ -1,6 +1,7 @@ #include <stdio.h> #include <stdlib.h> #include <time.h> +#include <inttypes.h> #include <libvirt/libvirt-admin.h> static const char * @@ -96,7 +97,7 @@ int main(int argc, char **argv) exampleGetTimeStr(virAdmClientGetTimestamp(client)))) goto cleanup; - printf(" %-5llu %-15s %-15s\n", id, + printf(" %-5" PRIu64 " %-15s %-15s\n", (uint64_t)id, exampleTransportToString(transport), timestr); free(timestr); } diff --git a/examples/domtop/domtop.c b/examples/domtop/domtop.c index 008065c651..e1e7fbff8b 100644 --- a/examples/domtop/domtop.c +++ b/examples/domtop/domtop.c @@ -29,6 +29,7 @@ #include <string.h> #include <sys/time.h> #include <unistd.h> +#include <inttypes.h> static bool debug; static bool run_top; @@ -226,8 +227,11 @@ print_cpu_usage(const char *dom_name, return; } - DEBUG("now_params=%llu then_params=%llu now=%llu then=%llu", - now_params[pos].value.ul, then_params[pos].value.ul, now, then); + DEBUG("now_params=%" PRIu64 " then_params=%" PRIu64 + " now=%" PRIu64 " then=%" PRIu64, + (uint64_t)now_params[pos].value.ul, + (uint64_t)then_params[pos].value.ul, + (uint64_t)now, (uint64_t)then); /* @now_params and @then_params are in nanoseconds, @now and @then are * in microseconds. In ideal world, we would translate them both into -- 2.20.1

2 1

[libvirt] [PATCH 0/2] qemu: caps: Few more cleanups
by Peter Krempa 02 Apr '19

02 Apr '19

These were prompted by the review on the original series. Both will be pushed as trivial once the release is out. Peter Krempa (2): qemu: Remove ATTRIBUTE_UNUSED from 'qemuCaps' of virQEMUCapsInitQMPMonitorTCG qemu: Remove cleanup section of virQEMUCapsInitQMPMonitorTCG src/qemu/qemu_capabilities.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) -- 2.20.1

1 2

[libvirt] [PATCH 0/5] qemu: hotplug: Media change improvements (blockdev-add saga)
by Peter Krempa 02 Apr '19

02 Apr '19

First patch is not entirely relevant in this series. Peter Krempa (5): qemu: domain: Use VIR_AUTOFREE in qemuDomainObjPrivateXMLParseBlockjobs qemu: hotplug: Remove unused copies of virQEMUDriverConfigPtr qemu: hotplug: Use VIR_AUTOUNREF for virQEMUDriverConfigPtr qemu: hotplug: Disallow media change while blockjob is active qemu: domain: Forbid copy_on_read option also for floppies src/qemu/qemu_domain.c | 23 +++++++++++++------ src/qemu/qemu_hotplug.c | 51 ++++++++++++++++------------------------- 2 files changed, 36 insertions(+), 38 deletions(-) -- 2.20.1

2 10

[libvirt] [PATCH] examples: fix 64-bit integer formatting on Windows
by Daniel P. Berrangé 02 Apr '19

02 Apr '19

The Windows printf functions don't support %llu/%lld for printing 64-bit integers. For most of libvirt this doesn't matter as we rely on gnulib which provides a replacement printf that is sane. The example code is designed to compile against the normal OS headers, with no use of gnulib and thus has to use the platform specific printf. To deal with this we must use the macros PRI* macros from inttypes.h to get the platform specific format string. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- examples/admin/client_info.c | 7 ++++--- examples/admin/list_clients.c | 3 ++- examples/domtop/domtop.c | 4 +++- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/examples/admin/client_info.c b/examples/admin/client_info.c index f3f62a656b..d60512624d 100644 --- a/examples/admin/client_info.c +++ b/examples/admin/client_info.c @@ -3,6 +3,7 @@ #include <stdlib.h> #include <time.h> #include <string.h> +#include <inttypes.h> #include <libvirt/libvirt-admin.h> static const char * @@ -66,11 +67,11 @@ exampleGetTypedParamValue(virTypedParameterPtr item) break; case VIR_TYPED_PARAM_LLONG: - ret = asprintf(&str, "%lld", item->value.l); + ret = asprintf(&str, "%" PRId64, item->value.l); break; case VIR_TYPED_PARAM_ULLONG: - ret = asprintf(&str, "%llu", item->value.ul); + ret = asprintf(&str, "%" PRIu64, item->value.ul); break; case VIR_TYPED_PARAM_DOUBLE: @@ -143,7 +144,7 @@ int main(int argc, char **argv) if (!(timestr = exampleGetTimeStr(virAdmClientGetTimestamp(clnt)))) goto cleanup; - printf("%-15s: %llu\n", "id", virAdmClientGetID(clnt)); + printf("%-15s: %" PRIu64 "\n", "id", virAdmClientGetID(clnt)); printf("%-15s: %s\n", "connection_time", timestr); printf("%-15s: %s\n", "transport", exampleTransportToString(virAdmClientGetTransport(clnt))); diff --git a/examples/admin/list_clients.c b/examples/admin/list_clients.c index 5cf8e4c2a6..545b9cbd01 100644 --- a/examples/admin/list_clients.c +++ b/examples/admin/list_clients.c @@ -1,6 +1,7 @@ #include <stdio.h> #include <stdlib.h> #include <time.h> +#include <inttypes.h> #include <libvirt/libvirt-admin.h> static const char * @@ -96,7 +97,7 @@ int main(int argc, char **argv) exampleGetTimeStr(virAdmClientGetTimestamp(client)))) goto cleanup; - printf(" %-5llu %-15s %-15s\n", id, + printf(" %-5" PRIu64 " %-15s %-15s\n", id, exampleTransportToString(transport), timestr); free(timestr); } diff --git a/examples/domtop/domtop.c b/examples/domtop/domtop.c index 008065c651..33d97c74fe 100644 --- a/examples/domtop/domtop.c +++ b/examples/domtop/domtop.c @@ -29,6 +29,7 @@ #include <string.h> #include <sys/time.h> #include <unistd.h> +#include <inttypes.h> static bool debug; static bool run_top; @@ -226,7 +227,8 @@ print_cpu_usage(const char *dom_name, return; } - DEBUG("now_params=%llu then_params=%llu now=%llu then=%llu", + DEBUG("now_params=%" PRIu64 " then_params=%" PRIu64 + " now=%" PRIu64 " then=%" PRIu64, now_params[pos].value.ul, then_params[pos].value.ul, now, then); /* @now_params and @then_params are in nanoseconds, @now and @then are -- 2.20.1

1 0

[libvirt] [PATCH 0/3] introducing QEMU_CAPS_QUERY_CURRENT_MACHINE and QEMU_CAPS_WAKEUP_SUSPEND_SUPPORT
by Daniel Henrique Barboza 02 Apr '19

02 Apr '19

Hi, In this series, I present the Libvirt support for a QEMU API that will be introduced in QEMU 4.0, called 'query-current-machine'. More background info about the API and its purpose can be found in the commit msg of patch 1. Patch 1 contains the caps declarations (a short patch, perhaps squashable with patch 2). Patch 2 enable the QEMU_CAPS_WAKEUP_SUSPEND_SUPPORT cap by querying 'query-current-machine', if the QEMU binary supports it. Patch 3 uses the caps inside qemuDomainPMSuspendForDuration to avoid suspending a domain that can't wake up from suspend. Daniel Henrique Barboza (3): adding QEMU_CAPS_QUERY_CURRENT_MACHINE and QEMU_CAPS_WAKEUP_SUSPEND_SUPPORT setting QEMU_CAPS_WAKEUP_SUSPEND_SUPPORT qemu capability qemuDomainPMSuspendForDuration: check for QEMU_CAPS_WAKEUP_SUSPEND_SUPPORT src/qemu/qemu_capabilities.c | 5 +++++ src/qemu/qemu_capabilities.h | 4 ++++ src/qemu/qemu_driver.c | 24 +++++++++++++++++++++++ src/qemu/qemu_monitor.c | 8 ++++++++ src/qemu/qemu_monitor.h | 3 +++ src/qemu/qemu_monitor_json.c | 35 +++++++++++++++++++++++++++++++++ src/qemu/qemu_monitor_json.h | 4 ++++ src/qemu/qemu_process.c | 38 ++++++++++++++++++++++++++++++++++++ 8 files changed, 121 insertions(+) -- 2.20.1

2 6

[libvirt] Can jobs suck like qemu-pr-helper does be transfered to libvirtd?
by Zhangbo (Oscar) 02 Apr '19

02 Apr '19

Hi all: qemu-pr-helper exits to help qemu do the high-privileged scsi related jobs. LIBVIRTD is responsible to launch qemu-pr-helper and qemu, and set selinux/DAC labels for them and their socket. # # # # # ___________ # ___________|libvirtd |__________ # | |___________| | # | | | # | | | # _________|________ _____|______ ___|____ # | qemu-pr-helper |__| vm1.sock |_____| qemu1 | # |__________________| |____________| |________| There may be other jobs quite like qemu-pr-helper, shall we make them as "complex" as the qemu-pr-helper scheme? Will it be OK to just let qemu send an EVENT to libvirtd, and let libvirtd do the SCSI/other jobs? Will it be OK if we remove qemu-pr-helper and similar processes? What's the disadvantage if we let libvirtd do there high privileged jobs instead qemu-pr-helper-like processes? Thanks!

2 6

[libvirt] [PATCH] virsh: cmdConsole: make --domain optional
by Ján Tomko 01 Apr '19

01 Apr '19

In the absence of a domain parameter, console the user instead. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- tools/virsh-domain.c | 25 ++++++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index afcd0a5f8d..de41f6312d 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -49,6 +49,7 @@ #include "virsh-console.h" #include "virsh-domain-monitor.h" #include "virerror.h" +#include "virrandom.h" #include "virtime.h" #include "virtypedparam.h" #include "virxml.h" @@ -2972,7 +2973,7 @@ static const vshCmdInfo info_console[] = { }; static const vshCmdOptDef opts_console[] = { - VIRSH_COMMON_OPT_DOMAIN_FULL(VIR_CONNECT_LIST_DOMAINS_ACTIVE), + VIRSH_COMMON_OPT_DOMAIN_OT_STRING_FULL(0, VIR_CONNECT_LIST_DOMAINS_ACTIVE), {.name = "devname", /* sc_prohibit_devname */ .type = VSH_OT_STRING, .help = N_("character device name") @@ -3023,6 +3024,23 @@ cmdRunConsole(vshControl *ctl, virDomainPtr dom, return ret; } +static const char * +constellation_phrases[] = { + "Everything is going to be all right.", + "Things are going to work out in the end.", + "Imagine pleasant nonsense", /* https://www.instagram.com/p/BuRfmkrBigI/ */ + "Ursa Major", + "There, there.", +}; + +static void +cmdConsoleUser(vshControl *ctl) +{ + uint32_t die = virRandomInt(ARRAY_CARDINALITY(constellation_phrases)); + + vshPrintExtra(ctl, "%s", constellation_phrases[die]); +} + static bool cmdConsole(vshControl *ctl, const vshCmd *cmd) { @@ -3033,6 +3051,11 @@ cmdConsole(vshControl *ctl, const vshCmd *cmd) unsigned int flags = 0; const char *name = NULL; + if (!vshCommandOptBool(cmd, "domain")) { + cmdConsoleUser(ctl); + return true; + } + if (!(dom = virshCommandOptDomain(ctl, cmd, NULL))) return false; -- 2.20.1

2 1

[libvirt] vcpupin reports bogus vcpu affinities
by Allen, John 01 Apr '19

01 Apr '19

Sent this out to the list a few days ago, but never saw it appear on the archives. Resending--hopefully this makes it to the list. --- For pinned vcpus, vcpupin will report inaccurate affinity values on machines with high core counts (256 cores in my case). The problem is produced as follows: $ virsh vcpupin myguest 0 4 $ virsh vcpupin myguest 0 VCPU CPU Affinity --------------------------- 0 4,192,194,196-197 Running taskset on the qemu threads shows the correct affinity, so this seems to be a reporting problem. Strangely, the value "192" is significant. If I pin a cpu greater than 192, the problem no longer appears. I believe the cause of the problem in my case is that in this case in src/conf/domain_conf.c:virDomainDefGetVcpuPinInfoHelper: ... if (vcpu && vcpu->cpumask) bitmap = vcpu->cpumask; ... vcpu->cpumask is "shortened" in that it is only long enough to contain the last set bit in the mask. However, when we go to copy the mask to the buffer that is returned, we use the masklen passed to the function which is the "full" masklen with a bit for each cpu. So it seems virBitmapToDataBuf copies some extra data past the end of the bitmask. Why the "192" value is always set and I typically see similar bogus bits set is still unknown. What is the function meant to assume in this case? Is it sane to assume that the bitmask is the full length of the buffer here and it's the responsibility of the setter of vcpu->cpumask to provide the length of the bitmap we're expecting? Or should we assume that we may receive a shortened bitmask here and expand the bitmask before copying to the buffer? -John

2 1

[libvirt] [PATCH] virerror: Make error reporting prettier
by Michal Privoznik 01 Apr '19

01 Apr '19

So far, if something goes wrong we print an error message, e.g. like this: virsh # start fedora error: Failed to start domain fedora error: internal error: process exited while connecting to monitor: 2019-04-01T08:08:49.753850Z qemu-system-x86_64: -object memory-backend-memfd,id=ram-node0,hugetlb=yes,hugetlbsize=0,size=8589934592,host-nodes=0,policy=bind: Property 'memory-backend-memfd.hugetlbsize' doesn't take value '0' This is very boring and usually too low level for users to know what is going on or how to fix the problem. Let's reimplement our error reporting then. After this patch the previous error turns into (my favourite): virsh # start fedora error: Failed to start domain fedora error: operation failed: the printer thinks its a router. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/Makefile.am | 4 +++ src/util/Makefile.inc.am | 2 ++ src/util/virerror.c | 76 ++++++++++++++++++++++++++++++++++------ 3 files changed, 72 insertions(+), 10 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index a73f43c483..387f57f288 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -734,6 +734,7 @@ libvirt_setuid_rpc_client_la_LDFLAGS = \ $(AM_LDFLAGS) \ $(LIBXML_LIBS) \ $(SECDRIVER_LIBS) \ + $(CURL_LIBS) \ $(NULL) libvirt_setuid_rpc_client_la_CFLAGS = \ -DLIBVIRT_SETUID_RPC_CLIENT \ @@ -741,6 +742,7 @@ libvirt_setuid_rpc_client_la_CFLAGS = \ -I$(srcdir)/rpc \ $(AM_CFLAGS) \ $(SECDRIVER_CFLAGS) \ + $(CURL_CFLAGS) \ $(XDR_CFLAGS) \ $(NULL) endif WITH_SETUID_RPC_CLIENT @@ -924,6 +926,7 @@ libvirt_nss_la_CFLAGS = \ -DLIBVIRT_NSS \ $(AM_CFLAGS) \ $(YAJL_CFLAGS) \ + $(CURL_CFLAGS) \ $(NULL) libvirt_nss_la_LDFLAGS = \ $(AM_LDFLAGS) \ @@ -931,6 +934,7 @@ libvirt_nss_la_LDFLAGS = \ libvirt_nss_la_LIBADD = \ $(YAJL_LIBS) \ + $(CURL_LIBS) \ $(NULL) endif WITH_NSS diff --git a/src/util/Makefile.inc.am b/src/util/Makefile.inc.am index aa5c6cbe03..6852d0105d 100644 --- a/src/util/Makefile.inc.am +++ b/src/util/Makefile.inc.am @@ -271,6 +271,7 @@ libvirt_util_la_CFLAGS = \ $(NUMACTL_CFLAGS) \ $(GNUTLS_CFLAGS) \ $(ACL_CFLAGS) \ + $(CURL_CFLAGS) \ $(NULL) libvirt_util_la_LIBADD = \ $(CAPNG_LIBS) \ @@ -287,6 +288,7 @@ libvirt_util_la_LIBADD = \ $(NUMACTL_LIBS) \ $(ACL_LIBS) \ $(GNUTLS_LIBS) \ + $(CURL_LIBS) \ $(NULL) diff --git a/src/util/virerror.c b/src/util/virerror.c index 05e535d859..2687869049 100644 --- a/src/util/virerror.c +++ b/src/util/virerror.c @@ -21,6 +21,7 @@ #include <config.h> #include <stdarg.h> +#include <curl/curl.h> #include "virerror.h" #include "datatypes.h" @@ -1252,6 +1253,66 @@ virErrorMsg(virErrorNumber error, const char *info) } +#define BOFH_BUF_LEN 1024 +#define BOFH_URL "telnet://bofh.jeffballard.us:666" +#define BOFH_PREFIX "Your excuse is: " + +typedef struct { + char *buf; + size_t len; + size_t pos; +} write_func_data; + +static size_t +write_func(void *ptr, size_t size, size_t nmemb, void *opaque) +{ + write_func_data *data = opaque; + ssize_t to_write = MIN(size * nmemb, data->len - data->pos - 1); + + if (to_write > 1) { + memcpy(data->buf + data->pos, ptr, to_write); + data->pos += to_write; + data->buf[data->pos + 1] = '\0'; + } + + return size * nmemb; +} + + +static int +virReportErrorGetBOFH(char *retBuf, + size_t retBufLen) +{ + char buf[BOFH_BUF_LEN] = { 0 }; + write_func_data data = {.buf = buf, .len = sizeof(buf), .pos = 0 }; + const char *tmp; + CURL *curl; + CURLcode result; + + if (!(curl = curl_easy_init())) + return -1; + + curl_easy_setopt(curl, CURLOPT_URL, BOFH_URL); +#ifdef CURLOPT_MUTE + curl_easy_setopt(curl, CURLOPT_MUTE, 1); +#endif + curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, write_func); + curl_easy_setopt(curl, CURLOPT_WRITEDATA, &data); + + result = curl_easy_perform(curl); + curl_easy_cleanup(curl); + if (result != CURLE_OK) + return -1; + + if (!(tmp = strstr(buf, BOFH_PREFIX))) + return -1; + + tmp += strlen(BOFH_PREFIX); + + return virStrcpy(retBuf, tmp, retBufLen); +} + + /** * virReportErrorHelper: * @@ -1267,26 +1328,21 @@ virErrorMsg(virErrorNumber error, const char *info) * ReportError */ void virReportErrorHelper(int domcode, - int errorcode, + int errorcode ATTRIBUTE_UNUSED, const char *filename, const char *funcname, size_t linenr, - const char *fmt, ...) + const char *fmt ATTRIBUTE_UNUSED, + ...) { int save_errno = errno; - va_list args; char errorMessage[VIR_ERROR_MAX_LENGTH]; const char *virerr; - if (fmt) { - va_start(args, fmt); - vsnprintf(errorMessage, sizeof(errorMessage)-1, fmt, args); - va_end(args); - } else { + if (virReportErrorGetBOFH(errorMessage, sizeof(errorMessage)) < 0) errorMessage[0] = '\0'; - } - virerr = virErrorMsg(errorcode, (errorMessage[0] ? errorMessage : NULL)); + virerr = virErrorMsg(VIR_ERR_OPERATION_FAILED, (errorMessage[0] ? errorMessage : NULL)); virRaiseErrorFull(filename, funcname, linenr, domcode, errorcode, VIR_ERR_ERROR, virerr, errorMessage, NULL, -- 2.19.2

3 3

[libvirt] [PATCH v2] qemu: fix domain unlock/unref in qemuMigrationSrcPerform
by Nikolay Shirokovskiy 01 Apr '19

01 Apr '19

qemuMigrationSrcPerform callers expect it to call virDomainObjEndAPI in any case so on error paths we miss the virDomainObjEndAPI call. To fix this let's make qemuMigrationSrcPerform callers responsible for the virDomainObjEndAPI call. Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> --- diff to v1 [1]: - move virDomainObjEndAPI call to qemuMigrationSrcPerform callers [1] https://www.redhat.com/archives/libvir-list/2019-April/msg00032.html src/qemu/qemu_driver.c | 21 +++++++++------------ src/qemu/qemu_migration.c | 2 -- 2 files changed, 9 insertions(+), 14 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 62d8d97..37baa5c 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -12550,7 +12550,7 @@ qemuDomainMigratePerform(virDomainPtr dom, unsigned long resource) { virQEMUDriverPtr driver = dom->conn->privateData; - virDomainObjPtr vm; + virDomainObjPtr vm = NULL; int ret = -1; const char *dconnuri = NULL; qemuMigrationParamsPtr migParams = NULL; @@ -12571,10 +12571,8 @@ qemuDomainMigratePerform(virDomainPtr dom, if (!(vm = qemuDomObjFromDomain(dom))) goto cleanup; - if (virDomainMigratePerformEnsureACL(dom->conn, vm->def) < 0) { - virDomainObjEndAPI(&vm); + if (virDomainMigratePerformEnsureACL(dom->conn, vm->def) < 0) goto cleanup; - } if (flags & VIR_MIGRATE_PEER2PEER) VIR_STEAL_PTR(dconnuri, uri); @@ -12592,6 +12590,7 @@ qemuDomainMigratePerform(virDomainPtr dom, flags, dname, resource, false); cleanup: + virDomainObjEndAPI(&vm); qemuMigrationParamsFree(migParams); return ret; } @@ -12988,7 +12987,7 @@ qemuDomainMigratePerform3(virDomainPtr dom, unsigned long resource) { virQEMUDriverPtr driver = dom->conn->privateData; - virDomainObjPtr vm; + virDomainObjPtr vm = NULL; qemuMigrationParamsPtr migParams = NULL; int ret = -1; @@ -13001,10 +13000,8 @@ qemuDomainMigratePerform3(virDomainPtr dom, if (!(vm = qemuDomObjFromDomain(dom))) goto cleanup; - if (virDomainMigratePerform3EnsureACL(dom->conn, vm->def) < 0) { - virDomainObjEndAPI(&vm); + if (virDomainMigratePerform3EnsureACL(dom->conn, vm->def) < 0) goto cleanup; - } ret = qemuMigrationSrcPerform(driver, dom->conn, vm, xmlin, NULL, dconnuri, uri, NULL, NULL, 0, NULL, 0, @@ -13014,6 +13011,7 @@ qemuDomainMigratePerform3(virDomainPtr dom, flags, dname, resource, true); cleanup: + virDomainObjEndAPI(&vm); qemuMigrationParamsFree(migParams); return ret; } @@ -13030,7 +13028,7 @@ qemuDomainMigratePerform3Params(virDomainPtr dom, unsigned int flags) { virQEMUDriverPtr driver = dom->conn->privateData; - virDomainObjPtr vm; + virDomainObjPtr vm = NULL; const char *dom_xml = NULL; const char *persist_xml = NULL; const char *dname = NULL; @@ -13088,10 +13086,8 @@ qemuDomainMigratePerform3Params(virDomainPtr dom, if (!(vm = qemuDomObjFromDomain(dom))) goto cleanup; - if (virDomainMigratePerform3ParamsEnsureACL(dom->conn, vm->def) < 0) { - virDomainObjEndAPI(&vm); + if (virDomainMigratePerform3ParamsEnsureACL(dom->conn, vm->def) < 0) goto cleanup; - } ret = qemuMigrationSrcPerform(driver, dom->conn, vm, dom_xml, persist_xml, dconnuri, uri, graphicsuri, listenAddress, @@ -13100,6 +13096,7 @@ qemuDomainMigratePerform3Params(virDomainPtr dom, cookiein, cookieinlen, cookieout, cookieoutlen, flags, dname, bandwidth, true); cleanup: + virDomainObjEndAPI(&vm); qemuMigrationParamsFree(migParams); VIR_FREE(migrate_disks); return ret; diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 419a729..bb43aff 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -4686,7 +4686,6 @@ qemuMigrationSrcPerformJob(virQEMUDriverPtr driver, } cleanup: - virDomainObjEndAPI(&vm); virObjectEventStateQueue(driver->domainEventState, event); virObjectUnref(cfg); return ret; @@ -4757,7 +4756,6 @@ qemuMigrationSrcPerformPhase(virQEMUDriverPtr driver, qemuDomainRemoveInactiveJob(driver, vm); cleanup: - virDomainObjEndAPI(&vm); return ret; } -- 1.8.3.1

2 1

[libvirt] [PATCH v2 0/7] extend virsh domstate to show additional information
by Bjoern Walk 01 Apr '19

01 Apr '19

This patch series introduces the ability to save additional information for the domain state and exposes this information in virsh domstate. For example in the case of QEMU guest panic events, we can provide additional information like the crash reason or register state of the domain. This information usually gets logged in the domain log but for debugging it is useful to have it accessible from the client. Therefore, let's introduce a new public API function, virDomainGetStateParams, an extensible version of virDomainGetState, which returns the complete state of the domain, including newly introduced additional information. Let's also extend virsh domstate and introduce a new parameter --info to show the domain state, reason and additional information when available. virsh domstate --info guest1 crashed (panicked: s390: core='1' psw-mask='0x1234000000000000' \ psw-addr='0x0000000000001234' reason='disabled-wait') Previous version is here: https://www.redhat.com/archives/libvir-list/2018-July/msg00686.html v1 -> v2: * refactored the public API according to discussions to provide a more machine-parsable interface Bjoern Walk (7): qemu: monitor: move event data structure to domain qemu: domain: store and update panic info lib: introduce virDomainGetStateParams function remote: implement remoteDomainGetStateParams qemu: implement qemuDomainGetStateParams virsh: domstate: report detailed state if available news: add entry for virDomainGetStateParams docs/news.xml | 11 +++ include/libvirt/libvirt-domain.h | 76 +++++++++++++++++ src/driver-hypervisor.h | 9 ++ src/libvirt-domain.c | 64 ++++++++++++++ src/libvirt_public.syms | 1 + src/qemu/qemu_domain.c | 89 +++++++++++++++++++- src/qemu/qemu_domain.h | 47 +++++++++++ src/qemu/qemu_driver.c | 126 +++++++++++++++++++++++++++- src/qemu/qemu_monitor.c | 53 +----------- src/qemu/qemu_monitor.h | 48 ++--------- src/qemu/qemu_monitor_json.c | 20 ++--- src/qemu/qemu_process.c | 2 +- src/remote/remote_daemon_dispatch.c | 50 +++++++++++ src/remote/remote_driver.c | 44 ++++++++++ src/remote/remote_protocol.x | 22 ++++- src/remote_protocol-structs | 12 +++ tools/virsh-domain-monitor.c | 102 +++++++++++++++++++--- tools/virsh.pod | 5 +- 18 files changed, 658 insertions(+), 123 deletions(-) -- 2.17.0

2 21

[libvirt] [RFC PATCH 0/8] Introduce the virDomainDefineJSONFlags() public API
by Andrea Bolognani 01 Apr '19

01 Apr '19

Back in 2005, when the libvirt project was started, XML was pretty much the only sensible, widely used format one could use to store structured data. A lot has changed since then, and these days you'd be hard pressed to find any API that does not use JSON for encoding information; in fact, we already use JSON heavily inside libvirt, for example to communicate with QEMU processes through QMP or store configuration data for use by the libvirt NSS plugin. The reasons for JSON's success over XML are plain to see: you get the same nicely structured data, but none of the ugly angle brackets or annoying repetition caused by having to both open *and* close elements explicitly; additionally, you get support for extremely useful and common data structures such as lists and dictionary out of the box, and even properly typed strings and numbers. It's just an overall much better data representation language. This RFC series provides the initial, very basic (yet fully functional) implementation of a JSON-based alternative to the existing virDomainDefineXML(); over time, we would introduce similar APIs for defining libvirt objects other than domains, such as for example networks. Once enough time has passed, we might even consider removing the XML-based APIs altogether and drop the XML parsing code along with our libxml2 dependency, making libvirt much leaner in the process. Andrea Bolognani (8): conf: Introduce virDomainDefParseJSONString() tests: Add qemujson2argvtest rpc: Add JSON to the list of fixups in gendispatch Introduce the virDomainDefineJSONFlags() public API remote: Implement virDomainDefineJSONFlags() support qemu: Add virDomainDefineJSONFlags() support virsh: Add JSON support to the 'define' subcommand news: Update for virDomainDefineJSONFlags() docs/news.xml | 11 + include/libvirt/libvirt-domain.h | 3 + include/libvirt/virterror.h | 1 + src/conf/domain_conf.c | 241 ++++ src/conf/domain_conf.h | 5 + src/driver-hypervisor.h | 6 + src/libvirt-domain.c | 45 + src/libvirt_private.syms | 1 + src/libvirt_public.syms | 1 + src/qemu/qemu_driver.c | 84 ++ src/remote/remote_driver.c | 3 +- src/remote/remote_protocol.x | 19 +- src/remote_protocol-structs | 8 + src/rpc/gendispatch.pl | 1 + src/util/virerror.c | 3 + tests/Makefile.am | 15 + tests/qemujson2argvdata/tiny.json | 29 + .../qemujson2argvdata/tiny.x86_64-latest.args | 33 + tests/qemujson2argvtest.c | 1001 +++++++++++++++++ tools/virsh-domain.c | 36 +- 20 files changed, 1540 insertions(+), 6 deletions(-) create mode 100644 tests/qemujson2argvdata/tiny.json create mode 100644 tests/qemujson2argvdata/tiny.x86_64-latest.args create mode 100644 tests/qemujson2argvtest.c -- 2.20.1

1 8

[libvirt] [PATCH] qemu: fix domain unlock/unref in qemuMigrationSrcPerform
by Nikolay Shirokovskiy 01 Apr '19

01 Apr '19

qemuMigrationSrcPerform callers expect it to call virDomainObjEndAPI in any case. Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> --- src/qemu/qemu_migration.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 419a729..ce4c443 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -4799,6 +4799,7 @@ qemuMigrationSrcPerform(virQEMUDriverPtr driver, if (cookieinlen) { virReportError(VIR_ERR_OPERATION_INVALID, "%s", _("received unexpected cookie with P2P migration")); + virDomainObjEndAPI(&vm); return -1; } @@ -4813,6 +4814,7 @@ qemuMigrationSrcPerform(virQEMUDriverPtr driver, if (dconnuri) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Unexpected dconnuri parameter with non-peer2peer migration")); + virDomainObjEndAPI(&vm); return -1; } -- 1.8.3.1

3 2

[libvirt] [PATCH] apparmor: support QEMU hppa, nios2, or1k, riscv32 and riscv64
by intrigeri+libvirt＠boum.org 01 Apr '19

01 Apr '19

From: intrigeri <intrigeri+libvirt(a)boum.org> Fixes: https://bugs.debian.org/914940 --- src/security/apparmor/libvirt-qemu | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/security/apparmor/libvirt-qemu b/src/security/apparmor/libvirt-qemu index 474aaefdf8..165558fe83 100644 --- a/src/security/apparmor/libvirt-qemu +++ b/src/security/apparmor/libvirt-qemu @@ -103,6 +103,7 @@ /usr/bin/qemu-system-alpha rmix, /usr/bin/qemu-system-arm rmix, /usr/bin/qemu-system-cris rmix, + /usr/bin/qemu-system-hppa rmix, /usr/bin/qemu-system-i386 rmix, /usr/bin/qemu-system-lm32 rmix, /usr/bin/qemu-system-m68k rmix, @@ -113,10 +114,14 @@ /usr/bin/qemu-system-mips64el rmix, /usr/bin/qemu-system-mipsel rmix, /usr/bin/qemu-system-moxie rmix, + /usr/bin/qemu-system-nios2 rmix, + /usr/bin/qemu-system-or1k rmix, /usr/bin/qemu-system-or32 rmix, /usr/bin/qemu-system-ppc rmix, /usr/bin/qemu-system-ppc64 rmix, /usr/bin/qemu-system-ppcemb rmix, + /usr/bin/qemu-system-riscv32 rmix, + /usr/bin/qemu-system-riscv64 rmix, /usr/bin/qemu-system-s390x rmix, /usr/bin/qemu-system-sh4 rmix, /usr/bin/qemu-system-sh4eb rmix, -- 2.20.1

3 7

[libvirt] [PATCH v2 0/4] apps: update the listed libvirt apps
by Daniel P. Berrangé 01 Apr '19

01 Apr '19

Purge apps that are dead and fix broken links Daniel P. Berrangé (4): apps: remove dead archipel project apps: update link for buildbot apps: drop link for zenoss software apps: remove VM Manager android app docs/apps.html.in | 39 +-------------------------------------- 1 file changed, 1 insertion(+), 38 deletions(-) -- 2.20.1

2 5

[libvirt] Entering freeze for libvirt-5.2.0
by Daniel Veillard 31 Mar '19

31 Mar '19

I'm a bit late but the Candidate Release 1 is tagged in git and I have pushed the signed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ This seems to be working in my limited testing, the CI is mostly green https://ci.centos.org/view/libvirt/ except for a few side things, so with a bit of luck that will work well. I may push the RC2 saturday morning, and then if everything looks good we can have the release on Tuesday. In the meantime, give it a try, especially on different platforms or OSes, thanks, Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 1

[libvirt] [PATCH] news: Update for 5.2.0 release
by Andrea Bolognani 30 Mar '19

30 Mar '19

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- docs/news.xml | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 2067830848..fcf8520132 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -148,8 +148,45 @@ tables are not required. </description> </change> + <change> + <summary> + Don't default to building the QEMU driver + </summary> + <description> + Historically, the QEMU driver has been special in that it was + enabled by default, with the option to explicitly opt-out of it; + starting now, we're enabling it opportunistically if we detect that + all requirements are available, just like we do with other drivers. + </description> + </change> </section> <section title="Bug fixes"> + <change> + <summary> + virt-host-validate: Fix IOMMU check on s390x + </summary> + </change> + <change> + <summary> + qemu: Allow creating pSeries guests with graphics and no USB mouse + </summary> + <description> + It's now possible to prevent libvirt from automatically adding a + USB mouse to pSeries guests by including a USB tablet in the input + XML: doing so is desiderable as using a tablet results in a much + better user experience when working with GUIs. + </description> + </change> + <change> + <summary> + qemu: Set $HOME and XGD variables for qemu:///system guests + </summary> + <description> + This avoids files being accidentally created under <code>/</code> or + the guests not being able to start because they lack the necessary + permissions to write to that location. + </description> + </change> </section> </release> <release version="v5.1.0" date="2019-03-04"> -- 2.20.1

2 1

[libvirt] [PATCH 0/4] apps: update the listed libvirt apps
by Daniel P. Berrangé 29 Mar '19

29 Mar '19

Purge apps that are dead and fix broken links Daniel P. Berrangé (4): apps: remove dead archipel project apps: update link for buildbot apps: update link for zenoss software apps: remove VM Manager android app docs/apps.html.in | 35 ++--------------------------------- 1 file changed, 2 insertions(+), 33 deletions(-) -- 2.20.1

2 10

[libvirt] [PATCH 0/6] qemu: caps: Clean up virQEMUCapsInitQMPMonitor
by Peter Krempa 29 Mar '19

29 Mar '19

Some cleanups done while attempting to implement a new capability. Peter Krempa (6): qemu: caps: Separate capabilities based on qemu version qemu: caps: Aggregate all caps post-processing into a function qemu: capabilities: Move logic deciding whether to probe into probing functions qemu: caps: Don't leak package name string in virQEMUCapsInitQMPMonitor qemu: caps: Remove cleanup section in virQEMUCapsInitQMPMonitor qemu: caps: Remove pointless debug message in virQEMUCapsInitQMPMonitor src/qemu/qemu_capabilities.c | 278 +++++++++++++++++++---------------- 1 file changed, 150 insertions(+), 128 deletions(-) -- 2.20.1

2 12

[libvirt] [PATCH v2 1/2] qemu: Fix "boolen" typo in API doc
by Christophe Fergeau 29 Mar '19

29 Mar '19

This also adjusts the argument name which should be 'isListen' in both cases rather than 'listen'. Signed-off-by: Christophe Fergeau <cfergeau(a)redhat.com> --- Changes since v1: - really fix 'boolen' typo src/qemu/qemu_command.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index f81d20e5f7..82675c5d4e 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -876,7 +876,7 @@ qemuBuildRBDSecinfoURI(virBufferPtr buf, /* qemuBuildTLSx509BackendProps: * @tlspath: path to the TLS credentials - * @listen: boolen listen for client or server setting + * @isListen: boolean listen for client or server setting * @verifypeer: boolean to enable peer verification (form of authorization) * @alias: alias for the TLS credentials object * @secalias: if one exists, the alias of the security object for passwordid @@ -917,7 +917,7 @@ qemuBuildTLSx509BackendProps(const char *tlspath, /* qemuBuildTLSx509CommandLine: * @cmd: Pointer to command * @tlspath: path to the TLS credentials - * @listen: boolen listen for client or server setting + * @isListen: boolean listen for client or server setting * @verifypeer: boolean to enable peer verification (form of authorization) * @certEncSecretAlias: alias of a 'secret' object for decrypting TLS private key * (optional) -- 2.21.0

2 4

[libvirt] [PULL 00/14] Audio 20190312 patches
by Gerd Hoffmann 29 Mar '19

29 Mar '19

The following changes since commit e2a18635a400b0e68679614132e9ef6316105590: Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2019-03-08' into staging (2019-03-09 20:55:44 +0000) are available in the Git repository at: git://git.kraxel.org/qemu tags/audio-20190312-pull-request for you to fetch changes up to 05d2f2a64dbcaa50370d344ab12081d776ed0f03: audio: -audiodev command line option: cleanup (2019-03-11 10:29:27 +0100) ---------------------------------------------------------------- audio: introduce -audiodev ---------------------------------------------------------------- Kővágó, Zoltán (14): qapi: qapi for audio backends audio: use qapi AudioFormat instead of audfmt_e audio: -audiodev command line option: documentation audio: -audiodev command line option basic implementation alsaaudio: port to -audiodev config coreaudio: port to -audiodev config dsoundaudio: port to -audiodev config noaudio: port to -audiodev config ossaudio: port to -audiodev config paaudio: port to -audiodev config sdlaudio: port to -audiodev config spiceaudio: port to -audiodev config wavaudio: port to -audiodev config audio: -audiodev command line option: cleanup audio/audio.h | 30 +- audio/audio_int.h | 37 +- audio/audio_template.h | 42 +- audio/dsound_template.h | 6 +- audio/alsaaudio.c | 368 ++++++---------- audio/audio.c | 859 +++++++++++++------------------------- audio/audio_legacy.c | 544 ++++++++++++++++++++++++ audio/audio_win_int.c | 18 +- audio/coreaudio.c | 51 +-- audio/dsoundaudio.c | 61 +-- audio/noaudio.c | 3 +- audio/ossaudio.c | 191 +++------ audio/paaudio.c | 111 ++--- audio/sdlaudio.c | 50 +-- audio/spiceaudio.c | 11 +- audio/wavaudio.c | 75 +--- audio/wavcapture.c | 2 +- hw/arm/omap2.c | 2 +- hw/audio/ac97.c | 2 +- hw/audio/adlib.c | 2 +- hw/audio/cs4231a.c | 6 +- hw/audio/es1370.c | 4 +- hw/audio/gus.c | 2 +- hw/audio/hda-codec.c | 18 +- hw/audio/lm4549.c | 6 +- hw/audio/milkymist-ac97.c | 2 +- hw/audio/pcspk.c | 2 +- hw/audio/sb16.c | 14 +- hw/audio/wm8750.c | 6 +- hw/display/xlnx_dp.c | 2 +- hw/input/tsc210x.c | 2 +- hw/usb/dev-audio.c | 2 +- ui/vnc.c | 26 +- vl.c | 7 +- audio/Makefile.objs | 2 +- qapi/Makefile.objs | 6 +- qapi/audio.json | 304 ++++++++++++++ qapi/qapi-schema.json | 1 + qemu-deprecated.texi | 7 + qemu-options.hx | 236 ++++++++++- 40 files changed, 1834 insertions(+), 1286 deletions(-) create mode 100644 audio/audio_legacy.c create mode 100644 qapi/audio.json -- 2.18.1

6 27

[libvirt] [PATCH] tests: Don't use canonical paths in virstoragetest
by Andrea Bolognani 29 Mar '19

29 Mar '19

The layout of my home directory is somewhat peculiar: I store all git repositories in ~/src/upstream, but since I spend almost all of my time hacking on libvirt, I also have a convenience symlink ~/src/libvirt -> ~/src/upstream/libvirt that I use to access that specific git repository. The above setup has served me well for years; however, ever since commit ca1471622dd9 dropped our own custom definitions for abs_{,top_}{src,build}dir and started using the ones provided by autotools, virstoragetest has started reliably failing with errors such as 2) Storage backing chain 2 ... Offset 0 Expect [chain member: 0 path:/home/abologna/src/upstream/libvirt/tests/virstoragedata/raw backingStoreRaw: <null> capacity: 0 encryption: 0 relPath:<null> type:1 format:1 protocol:none hostname:<null> ] Actual [chain member: 0 path:/home/abologna/src/libvirt/tests/virstoragedata/raw backingStoreRaw: <null> capacity: 0 encryption: 0 relPath:<null> type:1 format:1 protocol:none hostname:<null> ] ... FAILED Using abolute paths instead of canonical ones in the tests makes the problem go away. Note that all tests that are specifically designed to test path canonicalization via TEST_PATH_CANONICALIZE() were passing even before this patch and are not touched by it. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- I'm far from being confident this is the correct approach, but I've grown annoyed enough by the constant 'make check' failures that I figured I'd at least get the discussion going :) tests/virstoragetest.c | 50 +++++++++--------------------------------- 1 file changed, 10 insertions(+), 40 deletions(-) diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c index fb98903f02..d2be6fffef 100644 --- a/tests/virstoragetest.c +++ b/tests/virstoragetest.c @@ -46,21 +46,16 @@ VIR_LOG_INIT("tests.storagetest"); * sub/link2: symlink to wrap * * Relative names to these files are known at compile time, but absolute - * and canonical names depend on where the test is run; for convenience, + * names depend on where the test is run; for convenience, * we pre-populate the computation of these names for use during the test. */ static char *qemuimg; static char *absraw; -static char *canonraw; static char *absqcow2; -static char *canonqcow2; static char *abswrap; -static char *canonwrap; static char *absqed; -static char *canonqed; static char *absdir; -static char *canondir; static char *abslink2; static void @@ -68,15 +63,10 @@ testCleanupImages(void) { VIR_FREE(qemuimg); VIR_FREE(absraw); - VIR_FREE(canonraw); VIR_FREE(absqcow2); - VIR_FREE(canonqcow2); VIR_FREE(abswrap); - VIR_FREE(canonwrap); VIR_FREE(absqed); - VIR_FREE(canonqed); VIR_FREE(absdir); - VIR_FREE(canondir); VIR_FREE(abslink2); if (chdir(abs_builddir) < 0) { @@ -165,10 +155,6 @@ testPrepImages(void) fprintf(stderr, "unable to create directory %s\n", datadir "/dir"); goto cleanup; } - if (!(canondir = virFileCanonicalizePath(absdir))) { - virReportOOMError(); - goto cleanup; - } if (chdir(datadir) < 0) { fprintf(stderr, "unable to test relative backing chains\n"); @@ -180,10 +166,6 @@ testPrepImages(void) fprintf(stderr, "unable to create raw file\n"); goto cleanup; } - if (!(canonraw = virFileCanonicalizePath(absraw))) { - virReportOOMError(); - goto cleanup; - } /* Create a qcow2 wrapping relative raw; later on, we modify its * metadata to test other configurations */ @@ -200,10 +182,6 @@ testPrepImages(void) "-F", "raw", "-b", "raw", "qcow2", NULL); if (virCommandRun(cmd, NULL) < 0) goto skip; - if (!(canonqcow2 = virFileCanonicalizePath(absqcow2))) { - virReportOOMError(); - goto cleanup; - } /* Create a second qcow2 wrapping the first, to be sure that we * can correctly avoid insecure probing. */ @@ -214,10 +192,6 @@ testPrepImages(void) virCommandAddArg(cmd, "wrap"); if (virCommandRun(cmd, NULL) < 0) goto skip; - if (!(canonwrap = virFileCanonicalizePath(abswrap))) { - virReportOOMError(); - goto cleanup; - } /* Create a qed file. */ virCommandFree(cmd); @@ -227,10 +201,6 @@ testPrepImages(void) virCommandAddArg(cmd, "qed"); if (virCommandRun(cmd, NULL) < 0) goto skip; - if (!(canonqed = virFileCanonicalizePath(absqed))) { - virReportOOMError(); - goto cleanup; - } #ifdef HAVE_SYMLINK /* Create some symlinks in a sub-directory. */ @@ -731,7 +701,7 @@ mymain(void) /* Raw image, whether with right format or no specified format */ testFileData raw = { - .path = canonraw, + .path = absraw, .type = VIR_STORAGE_TYPE_FILE, .format = VIR_STORAGE_FILE_RAW, }; @@ -743,12 +713,12 @@ mymain(void) testFileData qcow2 = { .expBackingStoreRaw = "raw", .expCapacity = 1024, - .path = canonqcow2, + .path = absqcow2, .type = VIR_STORAGE_TYPE_FILE, .format = VIR_STORAGE_FILE_QCOW2, }; testFileData qcow2_as_raw = { - .path = canonqcow2, + .path = absqcow2, .type = VIR_STORAGE_TYPE_FILE, .format = VIR_STORAGE_FILE_RAW, }; @@ -772,7 +742,7 @@ mymain(void) testFileData wrap = { .expBackingStoreRaw = absqcow2, .expCapacity = 1024, - .path = canonwrap, + .path = abswrap, .type = VIR_STORAGE_TYPE_FILE, .format = VIR_STORAGE_FILE_QCOW2, }; @@ -795,7 +765,7 @@ mymain(void) testFileData wrap_as_raw = { .expBackingStoreRaw = absqcow2, .expCapacity = 1024, - .path = canonwrap, + .path = abswrap, .type = VIR_STORAGE_TYPE_FILE, .format = VIR_STORAGE_FILE_QCOW2, }; @@ -878,12 +848,12 @@ mymain(void) testFileData qed = { .expBackingStoreRaw = absraw, .expCapacity = 1024, - .path = canonqed, + .path = absqed, .type = VIR_STORAGE_TYPE_FILE, .format = VIR_STORAGE_FILE_QED, }; testFileData qed_as_raw = { - .path = canonqed, + .path = absqed, .type = VIR_STORAGE_TYPE_FILE, .format = VIR_STORAGE_FILE_RAW, }; @@ -892,12 +862,12 @@ mymain(void) /* directory */ testFileData dir = { - .path = canondir, + .path = absdir, .type = VIR_STORAGE_TYPE_DIR, .format = VIR_STORAGE_FILE_DIR, }; testFileData dir_as_raw = { - .path = canondir, + .path = absdir, .type = VIR_STORAGE_TYPE_DIR, .format = VIR_STORAGE_FILE_RAW, }; -- 2.20.1

2 3

[libvirt] [PATCH 0/4] Fix checking of blkiotune group name on update
by Ján Tomko 29 Mar '19

29 Mar '19

*** BLURB HERE *** *** BLURB THERE *** *** BLURB EVERYWHERE *** Ján Tomko (4): Revert "qemu: emit error when trying to update blkiotune group_name in qemuDomainChangeDiskLive" qemu: introduce CHECK_STREQ_NULLABLE in qemuDomainDiskChangeSupported qemu: error out on attempt to change blkiotune group name qemuDomainDiskChangeSupported: use CHECK_STREQ_NULLABLE more src/qemu/qemu_domain.c | 64 +++++++++++++++++------------------------- 1 file changed, 26 insertions(+), 38 deletions(-) -- 2.20.1

2 10

Re: [libvirt] [PATCH 1/2] snapshots: allow create --redefine to force a new configuration
by Richard Moore 29 Mar '19

29 Mar '19

> > On Wed, Mar 20, 2019 at 8:53 AM Peter Krempa <pkrempa redhat com> > wrote: > > I'm not persuaded that this workaround is necessary. > > Thanks Peter for taking a deeper look! > > And yes your summary seems correct. > I personally still like to give admins the ability to force configs, > but I'm ok if the general upstream opinion to that is no. > > I have asked the reporter - on the bug that I got - to chime in here > and > do the "convincing" as he is the affected person I think he is more > able > to do so - e.g. express the pain with the suggested workaround. > > -- > Christian Ehrhardt > Software Engineer, Ubuntu Server > Canonical Ltd Hi, I am the original fix requestor who Christian has put up with for quite some time now! I will try and summarise in brief; The initial problem was the machine type I had set in various snapshots/VM's had been deprecated and thus rendered the snapshots all unusable after upgrading O/S (that came packaged with newer libvirt/qemu versions.) I thus needed a simple, intuitive way to edit the snapshots to a machine type that was still supported, permanently. snapshot-edit seemed the appropriate tool for doing this, but alas it would not, a way was needed to force it to save the changes. One of my main reasons for using vm/snapshots is testing software install behaviour/compatibility in Windows, so I have a variety of Windows versions, each with snapshots taken with various levels of core 'things' installed (.net framework , C++ redistributables etc.) Thus the snapshots could be many years old. I need to be able to flick between them, so being able to permanently 'fix' them is my goal. The second issue was similarly being able to edit other 'simple' facets of the snapshots e.g. Attached disks, floppies or ISO's - or paths to them. Memory, if testing something that needed more than I ever invisaged way back when. MAC address (we have to register devices on the network via MAC, which expire, and can then render the snapshot unusable if I cannot change the MAC in the snapshot) I hope this makes sense, I have tried to be brief, I can elaborate further if needed. I think being able to edit existing snapshots simply, with once command, would be very beneficial to many people. (I think most people trying to do this would be aware of the risks, especially if the alternative is that the snapshot doesnt work anyway.) Cheers Richard Moore

1 0

[libvirt] [dockerfiles PATCH 0/2] Drop obsolete Dockerfiles
by Andrea Bolognani 29 Mar '19

29 Mar '19

The corresponding platforms are not longer supported by the libvirt-jenkins-ci project. Series pushed under the Dockerfile refresh rule. Andrea Bolognani (2): Drop Debian 8 Dockerfile Drop Ubuntu 16.04 Dockerfile buildenv-debian-8.Dockerfile | 82 --------------------------------- buildenv-ubuntu-16.Dockerfile | 85 ----------------------------------- 2 files changed, 167 deletions(-) delete mode 100644 buildenv-debian-8.Dockerfile delete mode 100644 buildenv-ubuntu-16.Dockerfile -- 2.20.1

1 2

[libvirt] [jenkins-ci PATCH 0/2] Drop Ubuntu 16.04
by Andrea Bolognani 29 Mar '19

29 Mar '19

I'm a bit conflicted about this one: on one hand, unlike Debian 8 we haven't really run into any issue with Ubuntu 16.04, we can still build almost all projects on it, and it doesn't require any crazy hacks to maintain; on the other hand, perhaps the reason why we still claim we can build almost all projects on it is because we don't actually run any build on it, either on CentOS CI or on Travis CI :D Anyway: here are the patches, let's see what other people think. Andrea Bolognani (2): Stop building on Ubuntu 16.04 guests: Drop Ubuntu 18.04 guests/host_vars/libvirt-ubuntu-16/docker.yml | 2 -- .../host_vars/libvirt-ubuntu-16/install.yml | 2 -- guests/host_vars/libvirt-ubuntu-16/main.yml | 22 ------------------- guests/inventory | 1 - guests/playbooks/build/jobs/defaults.yml | 1 - .../playbooks/build/projects/libvirt-dbus.yml | 5 +---- .../build/projects/libvirt-go-xml.yml | 1 - .../playbooks/build/projects/libvirt-go.yml | 1 - .../build/projects/libvirt-ocaml.yml | 1 - .../build/projects/libvirt-sandbox.yml | 1 - .../playbooks/build/projects/libvirt-tck.yml | 1 - guests/playbooks/build/projects/libvirt.yml | 1 - guests/playbooks/build/projects/osinfo-db.yml | 1 - .../playbooks/build/projects/virt-manager.yml | 4 +--- guests/vars/mappings.yml | 3 --- 15 files changed, 2 insertions(+), 45 deletions(-) delete mode 100644 guests/host_vars/libvirt-ubuntu-16/docker.yml delete mode 100644 guests/host_vars/libvirt-ubuntu-16/install.yml delete mode 100644 guests/host_vars/libvirt-ubuntu-16/main.yml -- 2.20.1

4 8

[libvirt] [jenkins-ci PATCH 0/2] Drop Debian 8
by Andrea Bolognani 29 Mar '19

29 Mar '19

See patch 1/2 and https://www.redhat.com/archives/libvir-list/2019-March/msg01864.html for the rationale. Andrea Bolognani (2): Stop building on Debian 8 guests: Drop Debian 8 guests/host_vars/libvirt-debian-8/docker.yml | 2 - guests/host_vars/libvirt-debian-8/install.yml | 2 - guests/host_vars/libvirt-debian-8/main.yml | 20 ----- guests/inventory | 1 - guests/playbooks/build/jobs/defaults.yml | 1 - .../playbooks/build/projects/libvirt-dbus.yml | 1 - .../build/projects/libvirt-go-xml.yml | 1 - .../playbooks/build/projects/libvirt-go.yml | 1 - .../build/projects/libvirt-ocaml.yml | 1 - .../build/projects/libvirt-sandbox.yml | 1 - .../playbooks/build/projects/libvirt-tck.yml | 1 - guests/playbooks/build/projects/libvirt.yml | 1 - guests/playbooks/build/projects/osinfo-db.yml | 1 - .../playbooks/build/projects/virt-manager.yml | 4 +- guests/playbooks/update/tasks/base.yml | 22 ------ guests/playbooks/update/tasks/bootstrap.yml | 6 -- .../templates/jessie-backports.preferences.j2 | 3 - .../templates/jessie-backports.sources.j2 | 1 - guests/vars/mappings.yml | 7 -- guests/vars/vault.yml | 78 +++++++++---------- jenkins/jobs/defaults.yaml | 1 - jenkins/projects/libvirt-dbus.yaml | 1 - jenkins/projects/libvirt-go-xml.yaml | 1 - jenkins/projects/libvirt-go.yaml | 1 - jenkins/projects/libvirt-ocaml.yaml | 1 - jenkins/projects/libvirt-sandbox.yaml | 1 - jenkins/projects/libvirt-tck.yaml | 1 - jenkins/projects/libvirt.yaml | 1 - jenkins/projects/osinfo-db.yaml | 1 - jenkins/projects/virt-manager.yaml | 4 +- 30 files changed, 41 insertions(+), 127 deletions(-) delete mode 100644 guests/host_vars/libvirt-debian-8/docker.yml delete mode 100644 guests/host_vars/libvirt-debian-8/install.yml delete mode 100644 guests/host_vars/libvirt-debian-8/main.yml delete mode 100644 guests/playbooks/update/templates/jessie-backports.preferences.j2 delete mode 100644 guests/playbooks/update/templates/jessie-backports.sources.j2 -- 2.20.1

2 3

[libvirt] [PATCH] snapashot: Improve logic of virDomainMomentMoveChildren
by Eric Blake 29 Mar '19

29 Mar '19

Even though Coverity can prove that 'last' is always set if the prior loop executed, gcc 8.0.1 cannot: CC conf/libvirt_conf_la-virdomainmomentobjlist.lo ../../src/conf/virdomainmomentobjlist.c: In function 'virDomainMomentMoveChildren': ../../src/conf/virdomainmomentobjlist.c:178:19: error: 'last' may be used uninitialized in this function [-Werror=maybe-uninitialized] last->sibling = to->first_child; ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~ Rewrite the loop to a form that should be easier for static analysis to work with. Fixes: ced0898f86bf Reported-by: Bjoern Walk <bwalk(a)linux.ibm.com> Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Qualifies as a build-breaker fix, but I'd like a review before pushing. src/conf/virdomainmomentobjlist.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/conf/virdomainmomentobjlist.c b/src/conf/virdomainmomentobjlist.c index b9ca5b1318..5a217056d1 100644 --- a/src/conf/virdomainmomentobjlist.c +++ b/src/conf/virdomainmomentobjlist.c @@ -164,18 +164,17 @@ void virDomainMomentMoveChildren(virDomainMomentObjPtr from, virDomainMomentObjPtr to) { - virDomainMomentObjPtr child; - virDomainMomentObjPtr last; + virDomainMomentObjPtr child = from->first_child; - if (!from->first_child) - return; - for (child = from->first_child; child; child = child->sibling) { + while (child) { child->parent = to; - if (!child->sibling) - last = child; + if (!child->sibling) { + child->sibling = to->first_child; + break; + } + child = child->sibling; } to->nchildren += from->nchildren; - last->sibling = to->first_child; to->first_child = from->first_child; from->nchildren = 0; from->first_child = NULL; -- 2.20.1

3 3

Re: [libvirt] [PATCH 1/2] snapshots: allow create --redefine to force a new configuration
by Richard Moore 28 Mar '19

28 Mar '19

> > On Wed, Mar 20, 2019 at 8:53 AM Peter Krempa <pkrempa redhat com> > wrote: > > I'm not persuaded that this workaround is necessary. > > Thanks Peter for taking a deeper look! > > And yes your summary seems correct. > I personally still like to give admins the ability to force configs, > but I'm ok if the general upstream opinion to that is no. > > I have asked the reporter - on the bug that I got - to chime in here > and > do the "convincing" as he is the affected person I think he is more > able > to do so - e.g. express the pain with the suggested workaround. > > -- > Christian Ehrhardt > Software Engineer, Ubuntu Server > Canonical Ltd Hi, I am the original fix requestor who Christian has put up with for quite some time now! I will try and summarise in brief; The initial problem was the machine type I had set in various snapshots/VM's had been deprecated and thus rendered the snapshots all unusable after upgrading O/S (that came packaged with newer libvirt/qemu versions.) I thus needed a simple, intuitive way to edit the snapshots to a machine type that was still supported, permanently. snapshot-edit seemed the appropriate tool for doing this, but alas it would not, a way was needed to force it to save the changes. One of my main reasons for using vm/snapshots is testing software install behaviour/compatibility in Windows, so I have a variety of Windows versions, each with snapshots taken with various levels of core 'things' installed (.net framework , C++ redistributables etc.) Thus the snapshots could be many years old. I need to be able to flick between them, so being able to permanently 'fix' them is my goal. The second issue was similarly being able to edit other 'simple' facets of the snapshots e.g. Attached disks, floppies or ISO's - or paths to them. Memory, if testing something that needed more than I ever invisaged way back when. MAC address (we have to register devices on the network via MAC, which expire, and can then render the snapshot unusable if I cannot change the MAC in the snapshot) I hope this makes sense, I have tried to be brief, I can elaborate further if needed. I think being able to edit existing snapshots simply, with once command, would be very beneficial to many people. (I think most people trying to do this would be aware of the risks, especially if the alternative is that the snapshot doesn’t work anyway.) Cheers Richard Moore

1 0

[libvirt] [perl][PATCH 0/3] Add a bunch of constants
by Michal Privoznik 28 Mar '19

28 Mar '19

*** BLURB HERE *** Michal Privoznik (3): Register new error code constants Add VIR_FROM_DOMAIN_CHECKPOINT constant Add VIR_MIGRATE_PARALLEL and VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS constants Changes | 5 +++++ lib/Sys/Virt.xs | 6 ++++++ lib/Sys/Virt/Domain.pm | 10 ++++++++++ lib/Sys/Virt/Error.pm | 16 ++++++++++++++++ 4 files changed, 37 insertions(+) -- 2.19.2

2 6

[libvirt] Time to drop support for Debian 8 (Jessie)?
by Andrea Bolognani 28 Mar '19

28 Mar '19

We currently support Debian 8 (oldstable) along with Debian 9 (stable), but not without some compromises: * the libvirt-dbus, libvirt-ocaml and virt-manager projects do not support the platform at all because it ships outdated versions of some core components; * on the CI side of things, we are forced to drag in the JRE from backports in order to be able to run the Jenkins agent. All things considered, the situation has been fairly manageable up until now, but a couple of recent developments got me thinking that perhaps it's time to let Jessie go: * the distribution has been moved from the regular Debian infrastructure to archive.debian.org[1], a change which has resulted in the daily update run failing and would require investing time to adapt to; * Debian testing has recently entered the full freeze[2], which means the release of Debian 10 can hopefully be expected to happen within the next few month; * even if the Buster freeze period turned out to be exceedingly long, according to our platform support policy[3] we only promise to support a release for the two years after the most recent major release: given that Debian 9 was released in June 2017[4], we would be able to drop Debian 8 support in three months' time regardless of whether or not Debian 10 has been released in the meantime. Based on the above, I suggest we don't invest any time trying to keep Debian 8 chugging along only to drop it in June, and instead declare it as unsupported right now and move on with our lives. Thoughts? [1] https://lists.debian.org/debian-devel-announce/2019/03/msg00006.html [2] https://lists.debian.org/debian-devel-announce/2019/03/msg00003.html [3] https://libvirt.org/platforms.html [4] https://wiki.debian.org/DebianReleases -- Andrea Bolognani / Red Hat / Virtualization

2 8

[libvirt] [PATCH] virsh: Don't infloop on snapshot/storage_vol failure
by Eric Blake 28 Mar '19

28 Mar '19

Most of our completers used the pattern: if ((nITEM = virITEMListAll()) < 0) return NULL; but the virDomainSnapshot and virStorageVolume completers were instead using goto error because of a prior allocation. If the ListAll fails with -1, the cleanup label was running a loop of 'size_t i < int nITEM', which is an extreme waste of CPU cycles. Reported-by: Ján Tomko <jtomko(a)redhat.com> Signed-off-by: Eric Blake <eblake(a)redhat.com> --- This one is a bug fix, so worth having in 5.2. tools/virsh-completer.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/virsh-completer.c b/tools/virsh-completer.c index c4adbb70d0..e9ef9b99f9 100644 --- a/tools/virsh-completer.c +++ b/tools/virsh-completer.c @@ -278,6 +278,7 @@ virshStorageVolNameCompleter(vshControl *ctl, virshControlPtr priv = ctl->privData; virStoragePoolPtr pool = NULL; virStorageVolPtr *vols = NULL; + int rc; int nvols = 0; size_t i = 0; char **ret = NULL; @@ -290,8 +291,9 @@ virshStorageVolNameCompleter(vshControl *ctl, if (!(pool = virshCommandOptPool(ctl, cmd, "pool", NULL))) return NULL; - if ((nvols = virStoragePoolListAllVolumes(pool, &vols, flags)) < 0) + if ((rc = virStoragePoolListAllVolumes(pool, &vols, flags)) < 0) goto error; + nvols = rc; if (VIR_ALLOC_N(ret, nvols + 1) < 0) goto error; @@ -631,6 +633,7 @@ virshSnapshotNameCompleter(vshControl *ctl, virshControlPtr priv = ctl->privData; virDomainPtr dom = NULL; virDomainSnapshotPtr *snapshots = NULL; + int rc; int nsnapshots = 0; size_t i = 0; char **ret = NULL; @@ -643,8 +646,9 @@ virshSnapshotNameCompleter(vshControl *ctl, if (!(dom = virshCommandOptDomain(ctl, cmd, NULL))) return NULL; - if ((nsnapshots = virDomainListAllSnapshots(dom, &snapshots, flags)) < 0) + if ((rc = virDomainListAllSnapshots(dom, &snapshots, flags)) < 0) goto error; + nsnapshots = rc; if (VIR_ALLOC_N(ret, nsnapshots + 1) < 0) goto error; -- 2.20.1

2 1

[libvirt] [jenkins-ci PATCH] jenkins: only send one email on build failure
by Daniel P. Berrangé 28 Mar '19

28 Mar '19

The current config causes jenkins to send a build on every single failure. This is way too noisy so change it to only send emails on the transition from good to bad. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- jenkins/jobs/autotools.yaml | 8 ++++---- jenkins/jobs/generic.yaml | 8 ++++---- jenkins/jobs/go.yaml | 4 ++-- jenkins/jobs/perl-modulebuild.yaml | 6 +++--- jenkins/jobs/python-distutils.yaml | 6 +++--- 5 files changed, 16 insertions(+), 16 deletions(-) diff --git a/jenkins/jobs/autotools.yaml b/jenkins/jobs/autotools.yaml index e365ec4..f04ec17 100644 --- a/jenkins/jobs/autotools.yaml +++ b/jenkins/jobs/autotools.yaml @@ -50,7 +50,7 @@ publishers: - email: recipients: '{obj:spam}' - notify-every-unstable-build: true + notify-every-unstable-build: false send-to-individuals: false - job-template: @@ -89,7 +89,7 @@ publishers: - email: recipients: '{obj:spam}' - notify-every-unstable-build: true + notify-every-unstable-build: false send-to-individuals: false - job-template: @@ -132,7 +132,7 @@ publishers: - email: recipients: '{obj:spam}' - notify-every-unstable-build: true + notify-every-unstable-build: false send-to-individuals: false - job-template: @@ -174,5 +174,5 @@ publishers: - email: recipients: '{obj:spam}' - notify-every-unstable-build: true + notify-every-unstable-build: false send-to-individuals: false diff --git a/jenkins/jobs/generic.yaml b/jenkins/jobs/generic.yaml index 1990930..ca69513 100644 --- a/jenkins/jobs/generic.yaml +++ b/jenkins/jobs/generic.yaml @@ -45,7 +45,7 @@ publishers: - email: recipients: '{obj:spam}' - notify-every-unstable-build: true + notify-every-unstable-build: false send-to-individuals: false - job-template: @@ -83,7 +83,7 @@ publishers: - email: recipients: '{obj:spam}' - notify-every-unstable-build: true + notify-every-unstable-build: false send-to-individuals: false - job-template: @@ -121,7 +121,7 @@ publishers: - email: recipients: '{obj:spam}' - notify-every-unstable-build: true + notify-every-unstable-build: false send-to-individuals: false - job-template: @@ -159,5 +159,5 @@ publishers: - email: recipients: '{obj:spam}' - notify-every-unstable-build: true + notify-every-unstable-build: false send-to-individuals: false diff --git a/jenkins/jobs/go.yaml b/jenkins/jobs/go.yaml index 3c14c35..1bdcb5f 100644 --- a/jenkins/jobs/go.yaml +++ b/jenkins/jobs/go.yaml @@ -45,7 +45,7 @@ publishers: - email: recipients: '{obj:spam}' - notify-every-unstable-build: true + notify-every-unstable-build: false send-to-individuals: false - job-template: @@ -83,5 +83,5 @@ publishers: - email: recipients: '{obj:spam}' - notify-every-unstable-build: true + notify-every-unstable-build: false send-to-individuals: false diff --git a/jenkins/jobs/perl-modulebuild.yaml b/jenkins/jobs/perl-modulebuild.yaml index 933020a..7173493 100644 --- a/jenkins/jobs/perl-modulebuild.yaml +++ b/jenkins/jobs/perl-modulebuild.yaml @@ -47,7 +47,7 @@ publishers: - email: recipients: '{obj:spam}' - notify-every-unstable-build: true + notify-every-unstable-build: false send-to-individuals: false @@ -86,7 +86,7 @@ publishers: - email: recipients: '{obj:spam}' - notify-every-unstable-build: true + notify-every-unstable-build: false send-to-individuals: false - job-template: @@ -127,5 +127,5 @@ publishers: - email: recipients: '{obj:spam}' - notify-every-unstable-build: true + notify-every-unstable-build: false send-to-individuals: false diff --git a/jenkins/jobs/python-distutils.yaml b/jenkins/jobs/python-distutils.yaml index 6b388f2..f56794c 100644 --- a/jenkins/jobs/python-distutils.yaml +++ b/jenkins/jobs/python-distutils.yaml @@ -47,7 +47,7 @@ publishers: - email: recipients: '{obj:spam}' - notify-every-unstable-build: true + notify-every-unstable-build: false send-to-individuals: false @@ -86,7 +86,7 @@ publishers: - email: recipients: '{obj:spam}' - notify-every-unstable-build: true + notify-every-unstable-build: false send-to-individuals: false - job-template: @@ -127,5 +127,5 @@ publishers: - email: recipients: '{obj:spam}' - notify-every-unstable-build: true + notify-every-unstable-build: false send-to-individuals: false -- 2.20.1

2 4

[libvirt] [jenkins-ci PATCH v2 1/2] guests: Update test dependencies for osinfo-db
by Fabiano Fidêncio 28 Mar '19

28 Mar '19

The new dependencies are: - python3 - python3-lxml - python3-pytest - python3-requests xmllint has been removed in favour of a own crafted test using python3-lxml Signed-off-by: Fabiano Fidêncio <fidencio(a)redhat.com> --- guests/vars/projects/osinfo-db.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/guests/vars/projects/osinfo-db.yml b/guests/vars/projects/osinfo-db.yml index d9320a4..56bd77a 100644 --- a/guests/vars/projects/osinfo-db.yml +++ b/guests/vars/projects/osinfo-db.yml @@ -1,4 +1,7 @@ --- packages: - intltool - - xmllint + - python3 + - python3-lxml + - python3-pytest + - python3-requests -- 2.20.1

3 4

[libvirt] [PATCH] tests: Disable some tests on 32 bit systems
by Michal Privoznik 28 Mar '19

28 Mar '19

On 32 bit systems there are two tests failing currently: qemufirmwaretest and qemuxml2argvtest (not every test case in them is failing, only some of them). There are several problems: 1) in qemufirmwaretest it's 'QEMU FW precedence test' which is failing. This is because the code tests qemuFirmwareFetchConfigs() which tries to compile a list of some paths from the system and if one of the paths is an empty file it should not appear on the returned list. The code uses virFileLength() to query the file size which uses stat() under the hood. The test uses virfilewrapper to redirect stat() into qemufirmwaredata/ but for reasons beyond me real_stat() returns mangled buffer making the code see a file with a real size even for empty files. I've track this one to a problem in virfilewrapper.c which will call real___xstat() which points to a function in libvirt.so (!) which returns stat with 32bit members even though we're compiling with LARGE_FILE and therefore expect 64bit members in the stat struct. 2) qemuxml2argvtest has two tests failing: 2a) [aarch64-]os-firmware-* - These fail because of the same reason as described in 1) 2b) pseries-hostdevs-* - These fail because they again rely on some stat (lstat to be precise). When building the cmd line for these test cases the code does some search in /sys/bus/pci/... and since we have virpcimock everything works just fine. Except when virfilewrapper.c is linked in because then lstat() is taken from there and when it initializes itself it will lookup real_lstat() which will now point not to virpcimock but to glibc. Again, reasons beyond me. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Quite frankly, I hate this patch. But the problem is in our mocking, not in the actual code its testing. And I've tried everything I was able to come up with on how to fix this. So if you have any idea, I'm all ears. tests/qemufirmwaretest.c | 7 +++++++ tests/qemuxml2argvtest.c | 6 ++++++ 2 files changed, 13 insertions(+) diff --git a/tests/qemufirmwaretest.c b/tests/qemufirmwaretest.c index 2b5cbf649b..3332bf0a34 100644 --- a/tests/qemufirmwaretest.c +++ b/tests/qemufirmwaretest.c @@ -52,6 +52,8 @@ testParseFormatFW(const void *opaque) } +#if defined(__x86_64__) || defined(__amd64__) || defined(__aarch64__) +/* XXX Dirty hack, but mocking stat on 32bits is above my skills */ static int testFWPrecedence(const void *opaque ATTRIBUTE_UNUSED) { @@ -97,6 +99,7 @@ testFWPrecedence(const void *opaque ATTRIBUTE_UNUSED) return 0; } +#endif static int @@ -124,8 +127,12 @@ mymain(void) DO_PARSE_TEST("usr/share/qemu/firmware/61-ovmf.json"); DO_PARSE_TEST("usr/share/qemu/firmware/70-aavmf.json"); + +#if defined(__x86_64__) || defined(__amd64__) || defined(__aarch64__) + /* XXX Dirty hack, but mocking stat on 32bits is above my skills */ if (virTestRun("QEMU FW precedence test", testFWPrecedence, NULL) < 0) ret = -1; +#endif virFileWrapperClearPrefixes(); diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 0c0dcae197..364792d24d 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -2038,6 +2038,8 @@ mymain(void) DO_TEST("pseries-many-buses-2", QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, QEMU_CAPS_VIRTIO_SCSI); +# if defined(__x86_64__) || defined(__amd64__) || defined(__aarch64__) + /* XXX Dirty hack, but mocking stat on 32bits is above my skills */ DO_TEST("pseries-hostdevs-1", QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, QEMU_CAPS_VIRTIO_SCSI, @@ -2050,6 +2052,7 @@ mymain(void) QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, QEMU_CAPS_VIRTIO_SCSI, QEMU_CAPS_DEVICE_VFIO_PCI); +# endif DO_TEST("pseries-features", QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, @@ -3157,10 +3160,13 @@ mymain(void) DO_TEST_CAPS_ARCH_LATEST("x86_64-pc-graphics", "x86_64"); DO_TEST_CAPS_ARCH_LATEST("x86_64-q35-graphics", "x86_64"); +# if defined(__x86_64__) || defined(__amd64__) || defined(__aarch64__) + /* XXX Dirty hack, but mocking stat on 32bits is above my skills */ DO_TEST_CAPS_LATEST("os-firmware-bios"); DO_TEST_CAPS_LATEST("os-firmware-efi"); DO_TEST_CAPS_LATEST("os-firmware-efi-secboot"); DO_TEST_CAPS_ARCH_LATEST("aarch64-os-firmware-efi", "aarch64"); +# endif if (getenv("LIBVIRT_SKIP_CLEANUP") == NULL) virFileDeleteTree(fakerootdir); -- 2.19.2

3 2

[libvirt] Planning for next release
by Daniel Veillard 28 Mar '19

28 Mar '19

It's time to get a new release out. Simplest would be to enter freeze tomorrow, then we can plan an RC2 by Friday, and if everything looks good have the release on time next Monday. Hope this works for everybody, thanks, Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

3 3

[libvirt] [PATCH 00/16] snapshot refactoring (incremental backup saga)
by Eric Blake 28 Mar '19

28 Mar '19

A couple of these have seen the list before, but most of them are new. The bulk of this series is about refactoring snapshot_conf.c into smaller pieces that I can then reuse for implementing checkpoints, without having to open-code the hierarchy algorithms a second time (one of John's complaints against my v4 incremental backup series). I suspect that src/vz/ builds may break on one or more of these patches; I could not get a working vz build environment. Eric Blake (16): test: Avoid use-after-free on virDomainSnapshotDelete snapshot: Use accessors for virDomainSnapshot members snapshot: Create virDomainMoment base class vbox: Clean up some snapshot usage snapshot: Drop virDomainSnapshotDef.current snapshot: Track current snapshot in virDomainSnapshotObjList snapshot: Add accessors for updating snapshot list relations snapshot: Access snapshot def directly when needed snapshot: Refactor list filtering snapshot: Factor out virDomainMomentDef class snapshot: Switch type of virDomainSnapshotObj.def snapshot: Rename virDomainSnapshotObjPtr snapshot: Rename file for virDomainMomentObj snapshot: Move snapshot list code into generic file snapshot: Tweaks to support new bulk dumpxml/import API backup: Introduce virDomainCheckpointPtr include/libvirt/virterror.h | 6 +- src/util/virerror.c | 12 +- include/libvirt/libvirt.h | 6 +- src/conf/domain_conf.h | 1 - src/conf/moment_conf.h | 41 +++ src/conf/snapshot_conf.h | 23 +- src/conf/virconftypes.h | 12 +- src/conf/virdomainmomentobjlist.h | 95 +++++ src/conf/virdomainsnapshotobj.h | 50 --- src/conf/virdomainsnapshotobjlist.h | 33 +- src/datatypes.h | 83 ++++- src/qemu/qemu_command.h | 2 +- src/qemu/qemu_domain.h | 6 +- src/qemu/qemu_process.h | 4 +- src/conf/Makefile.inc.am | 6 +- src/conf/moment_conf.c | 40 +++ src/conf/snapshot_conf.c | 179 +++++----- src/conf/virdomainmomentobjlist.c | 521 ++++++++++++++++++++++++++++ src/conf/virdomainsnapshotobj.c | 123 ------- src/conf/virdomainsnapshotobjlist.c | 367 +++++++------------- src/datatypes.c | 132 ++++--- src/esx/esx_driver.c | 82 ++--- src/libvirt-domain-snapshot.c | 26 +- src/libvirt_private.syms | 21 +- src/qemu/qemu_command.c | 2 +- src/qemu/qemu_domain.c | 36 +- src/qemu/qemu_driver.c | 290 ++++++++-------- src/qemu/qemu_process.c | 4 +- src/remote/remote_daemon_dispatch.c | 4 +- src/remote/remote_driver.c | 4 +- src/rpc/gendispatch.pl | 2 +- src/test/test_driver.c | 174 ++++------ src/vbox/vbox_common.c | 207 +++++------ src/vz/vz_driver.c | 89 ++--- src/vz/vz_sdk.c | 4 +- tests/domainsnapshotxml2xmltest.c | 5 +- 36 files changed, 1613 insertions(+), 1079 deletions(-) create mode 100644 src/conf/moment_conf.h create mode 100644 src/conf/virdomainmomentobjlist.h delete mode 100644 src/conf/virdomainsnapshotobj.h create mode 100644 src/conf/moment_conf.c create mode 100644 src/conf/virdomainmomentobjlist.c delete mode 100644 src/conf/virdomainsnapshotobj.c -- 2.20.1

7 70

[libvirt] [PATCH] tests: Avoid writing into $HOME during virsh-snapshot
by Eric Blake 28 Mar '19

28 Mar '19

In a constrained CI environment, where it is intentional that attempts to write outside the current directory will fail, virsh-snapshot was failing: @@ -1,2 +1,3 @@ error: invalid argument: parent s3 for snapshot s2 not found error: marker +error: Failed to create '/home/travis/.cache/libvirt/virsh': Permission denied FAIL virsh-snapshot (exit status: 1) But we've already solved the problem in virsh-uriprecedence: tell virsh to use XDG locations pointing to somewhere we can write rather than its default of falling back to $HOME with the test being at risk of breaking due to the user's environment and/or unacceptably altering the user's normal cache. Hoist that solution into test-lib.sh, so that all scripts can use it as needed. Fixes: 280a2b41e Reported-by: Daniel P. Berrangé <berrange(a)redhat.com> Signed-off-by: Eric Blake <eblake(a)redhat.com> --- tests/test-lib.sh | 13 +++++++++++++ tests/virsh-snapshot | 2 ++ tests/virsh-uriprecedence | 12 +----------- 3 files changed, 16 insertions(+), 11 deletions(-) diff --git a/tests/test-lib.sh b/tests/test-lib.sh index 49e8d22095..64f0b0d401 100644 --- a/tests/test-lib.sh +++ b/tests/test-lib.sh @@ -222,6 +222,19 @@ mkfifo_or_skip_() fi } +# Create mock XDG files/directories to avoid permission problems. +# As it points inside $test_dir_, it is automatically cleaned. +mock_xdg_() +{ + export XDG_CONFIG_HOME="$test_dir_/.config" + export XDG_CACHE_HOME="$test_dir_/.cache" + export XDG_RUNTIME_HOME="XDG_CACHE_HOME" + + mkdir -p "$XDG_CONFIG_HOME/libvirt" "$XDG_CONFIG_HOME/virsh" + mkdir -p "$XDG_CACHE_HOME/libvirt" "$XDG_CACHE_HOME/virsh" + mkdir -p "$XDG_RUNTIME_HOME/libvirt" "$XDG_RUNTIME_HOME/virsh" +} + test_dir_=$(pwd) this_test_() { echo "./$0" | sed 's,.*/,,'; } diff --git a/tests/virsh-snapshot b/tests/virsh-snapshot index fb8a99dd43..cb498cf54e 100755 --- a/tests/virsh-snapshot +++ b/tests/virsh-snapshot @@ -26,6 +26,8 @@ fi fail=0 +mock_xdg_ || framework_failure + # The test driver loses states between restarts, so we perform a script # with some convenient markers for later post-processing of output. $abs_top_builddir/tools/virsh --connect test:///default >out 2>err ' diff --git a/tests/virsh-uriprecedence b/tests/virsh-uriprecedence index 564e3dc42c..fd6ce108c0 100755 --- a/tests/virsh-uriprecedence +++ b/tests/virsh-uriprecedence @@ -11,17 +11,7 @@ virsh_cmd="$virsh_bin" counter=0 ret=0 -cleanup_() { rm -rf "$tmphome"; } - -# Create all mock files/directories to avoid permission problems -tmphome="$PWD/tmp_home" -export XDG_CONFIG_HOME="$tmphome/.config" -export XDG_CACHE_HOME="$tmphome/.cache" -export XDG_RUNTIME_HOME="XDG_CACHE_HOME" - -mkdir -p "$XDG_CONFIG_HOME/libvirt" "$XDG_CONFIG_HOME/virsh" -mkdir -p "$XDG_CACHE_HOME/libvirt" "$XDG_CACHE_HOME/virsh" -mkdir -p "$XDG_RUNTIME_HOME/libvirt" "$XDG_RUNTIME_HOME/virsh" +mock_xdg_ || framework_failure is_uri_good() { -- 2.20.1

3 4

[libvirt] [PATCH 0/3] qemu: clean up USB address releasing
by Peter Krempa 28 Mar '19

28 Mar '19

Peter Krempa (3): qemu: hotplug: Don't release USB address twice when removing disk qemu: Always use 'alias' in warning message when removing USB address qemu: address: Stop reporting warning when USB address can't be released src/qemu/qemu_domain_address.c | 9 ++---- src/qemu/qemu_domain_address.h | 3 +- src/qemu/qemu_hotplug.c | 53 +++++++++++++++++----------------- 3 files changed, 29 insertions(+), 36 deletions(-) -- 2.20.1

2 4

Re: [libvirt] Can jobs suck like qemu-pr-helper does be transfered to libvirtd?
by Zhangbo (Oscar) 28 Mar '19

28 Mar '19

>> Hi all: >> qemu-pr-helper exits to help qemu do the high-privileged scsi related jobs. >LIBVIRTD is responsible to launch qemu-pr-helper and qemu, and set >selinux/DAC labels for them and their socket. >> >> # >> # >> # >> # >> # ___________ >> # ___________|libvirtd |__________ >> # | |___________| | >> # | | | >> # | | | >> # _________|________ _____|______ ___|____ >> # | qemu-pr-helper |__| vm1.sock |_____| qemu1 | >> # |__________________| |____________| |________| >> >> There may be other jobs quite like qemu-pr-helper, shall we make them as >"complex" as the qemu-pr-helper scheme? >> Will it be OK to just let qemu send an EVENT to libvirtd, and let libvirtd do the >SCSI/other jobs? Will it be OK if we remove qemu-pr-helper and similar >processes? >> What's the disadvantage if we let libvirtd do there high privileged jobs instead >qemu-pr-helper-like processes? > >No what you describe is not desired. Any process which is vital for the >runtime of the VM needs to stay as simple and minimal as possible and >separate from libvirtd. > >Libvirtd is a complex big application dealing with multiple things at >once and also the architecture allows for libvirtd to be stopped and >upgraded. > >This does not play well with the fact that processes as the PR helper >are always required. > >Merging them into libvirtd would make the VM stop until libvirtd is >running again. Additionally if any of the operations require persistent >kernel state as e.g. file descriptors, this would be impossible as >stopping libvirtd process would close the FDs which may be then >impossible to reopen properly e.g. due to state. Thanks! Besides these reasons above, will it weaken security if we let libvirtd do these jobs? For example, Such sayings, like, "libvirtd would become the focus suffered from attacking forces", make sense?

1 0

[libvirt] [PATCH] qemu: don't fail on destroy if domain is inactive
by Nikolay Shirokovskiy 28 Mar '19

28 Mar '19

Mgmt can not track if domain is already inactive before calling destroy because domain can become inactive because of crash/shutdown from guest. Thus it is make sense to report success in this case. Another option is to return special error code but this is a bit more complicated. Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> --- src/qemu/qemu_driver.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 62d8d97..0789efc 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2172,8 +2172,10 @@ qemuDomainDestroyFlags(virDomainPtr dom, if (virDomainDestroyFlagsEnsureACL(dom->conn, vm->def) < 0) goto cleanup; - if (virDomainObjCheckActive(vm) < 0) + if (!virDomainObjIsActive(vm)) { + ret = 0; goto cleanup; + } state = virDomainObjGetState(vm, &reason); starting = (state == VIR_DOMAIN_PAUSED && -- 1.8.3.1

3 7

[libvirt] [PATCH] util: suppress unimportant ovs-vsctl errors when getting interface stats
by Laine Stump 28 Mar '19

28 Mar '19

commit edaf13565 modified the stats retrieval for OVS interfaces to not fail when one of the fields was unrecognized by the ovs-vsctl command, but ovs-vsctl was still returning an error, and libvirt was cluttering the logs with these inconsequential error messages. This patch modifies the GET_STAT macro to add "--if-exists" to the ovs-vsctl command, which causes it to return an empty string (and exit with success) if the requested statistic isn't in its database, thus eliminating the ugly error messages from the log. Resolves: https://bugzilla.redhat.com/1683175 Signed-off-by: Laine Stump <laine(a)laine.org> --- src/util/virnetdevopenvswitch.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/util/virnetdevopenvswitch.c b/src/util/virnetdevopenvswitch.c index 4fa3a5742a..e5a45f59ec 100644 --- a/src/util/virnetdevopenvswitch.c +++ b/src/util/virnetdevopenvswitch.c @@ -335,10 +335,10 @@ virNetDevOpenvswitchInterfaceStats(const char *ifname, virCommandFree(cmd); \ cmd = virCommandNew(OVSVSCTL); \ virNetDevOpenvswitchAddTimeout(cmd); \ - virCommandAddArgList(cmd, "get", "Interface", ifname, \ - "statistics:" name, NULL); \ + virCommandAddArgList(cmd, "--if-exists", "get", "Interface", \ + ifname, "statistics:" name, NULL); \ virCommandSetOutputBuffer(cmd, &output); \ - if (virCommandRun(cmd, NULL) < 0) { \ + if (virCommandRun(cmd, NULL) < 0 || !*output || *output == '\n') { \ stats->member = -1; \ } else { \ if (virStrToLong_ll(output, &tmp, 10, &stats->member) < 0 || \ -- 2.20.1

2 1

[libvirt] [PATCH] tools: Tweak workding for iothreadset
by John Ferlan 27 Mar '19

27 Mar '19

Update the wording to note the values for polling are purely dynamic and won't be saved across domain stop/(re)start or save/restore. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- tools/virsh.pod | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index a0fe949c55..f00564fa5f 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -1772,7 +1772,10 @@ reach the maximum polling time. If a 0 (zero) is provided, then the default factor will be used. The I<--poll-shrink> is the quotient by which the current polling time will be reduced in order to get below the maximum polling interval. If a 0 (zero) is provided, then -the default quotient will be used. +the default quotient will be used. The polling values are purely dynamic +for a running guest. Saving, destroying, stopping, etc. the guest will +result in the polling values returning to hypervisor defaults at the +next start, restore, etc. If I<--live> is specified, affect a running guest. If the guest is not running an error is returned. -- 2.20.1

2 2

[libvirt] [PATCH v2 0/2] qemu_capabilities; Drop virQEMUCapsSetVAList
by Michal Privoznik 27 Mar '19

27 Mar '19

Technically, this is v2 of: https://www.redhat.com/archives/libvir-list/2019-March/msg01778.html but is this one implements different approach. Plus it breaks dependency between two unrelated enums that I've noticed when debugging broken build on a 32bit arch. Michal Prívozník (2): qemu_capabilities; Drop virQEMUCapsSetVAList qemuxml2argvtest: Drop dependency between testInfoArgName and virQEMUCapsFlags enums src/qemu/qemu_capabilities.c | 15 +++---------- src/qemu/qemu_capabilities.h | 2 -- tests/qemuxml2argvtest.c | 41 +++++++++++++++++++++++------------- 3 files changed, 29 insertions(+), 29 deletions(-) -- 2.19.2

2 4

[libvirt] [PATCH] qemu_capabilities: Pass pointer to va_list in virQEMUCapsSetVAList
by Michal Privoznik 27 Mar '19

27 Mar '19

There is one specific caller (testInfoSetArgs() in qemuxml2argvtest.c) which expect the va_list argument to change after returning from the virQEMUCapsSetVAList() function. However, since we are passing plain va_list this is not guaranteed. The man page of stdarg(3) says: If ap is passed to a function that uses va_arg(ap,type), then the value of ap is undefined after the return of that function. (ap is a variable of type va_list) I've seen this in action in fact: on i686 the qemuxml2argvtest fails on the second test case because testInfoSetArgs() sees ARG_QEMU_CAPS and callse virQEMUCapsSetVAList to process the capabilities (in this case there's just one QEMU_CAPS_SECCOMP_BLACKLIST). But since the changes are not reflected in the caller, in the next iteration testInfoSetArgs() sees the qemu capability and not ARG_END. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- This passed successfully on x86_64 and i686 in my testing. src/qemu/qemu_capabilities.c | 6 +++--- src/qemu/qemu_capabilities.h | 2 +- tests/qemuxml2argvtest.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index c5954edaf0..e182a2c2e5 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -1665,11 +1665,11 @@ virQEMUCapsSet(virQEMUCapsPtr qemuCaps, void virQEMUCapsSetVAList(virQEMUCapsPtr qemuCaps, - va_list list) + va_list *list) { int flag; - while ((flag = va_arg(list, int)) < QEMU_CAPS_LAST) + while ((flag = va_arg(*list, int)) < QEMU_CAPS_LAST) ignore_value(virBitmapSetBit(qemuCaps->flags, flag)); } @@ -1680,7 +1680,7 @@ virQEMUCapsSetList(virQEMUCapsPtr qemuCaps, ...) va_list list; va_start(list, qemuCaps); - virQEMUCapsSetVAList(qemuCaps, list); + virQEMUCapsSetVAList(qemuCaps, &list); va_end(list); } diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h index 7625d754a3..ceab8c9154 100644 --- a/src/qemu/qemu_capabilities.h +++ b/src/qemu/qemu_capabilities.h @@ -519,7 +519,7 @@ void virQEMUCapsSet(virQEMUCapsPtr qemuCaps, virQEMUCapsFlags flag) ATTRIBUTE_NONNULL(1); void virQEMUCapsSetVAList(virQEMUCapsPtr qemuCaps, - va_list list) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); + va_list *list) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); void virQEMUCapsSetList(virQEMUCapsPtr qemuCaps, ...) ATTRIBUTE_NONNULL(1); void virQEMUCapsClear(virQEMUCapsPtr qemuCaps, diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 6e7d1b0b9a..a7a8d77e1d 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -650,7 +650,7 @@ testInfoSetArgs(struct testInfo *info, case ARG_QEMU_CAPS: if (qemuCaps || !(qemuCaps = virQEMUCapsNew())) goto cleanup; - virQEMUCapsSetVAList(qemuCaps, argptr); + virQEMUCapsSetVAList(qemuCaps, &argptr); break; case ARG_GIC: -- 2.19.2

4 6

[libvirt] [PATCH v7 00/23] Incremental backups
by Eric Blake 27 Mar '19

27 Mar '19

I've finished rebasing my earlier v4/v5 patches on top of cleanups earlier in the series (v6 didn't include the second half of the series). I've pushed a tag backup-v7 to both my libvirt.git and libvirt-python.git repos to match: https://repo.or.cz/libvirt/ericb.git/shortlog/refs/tags/backup-v7 https://repo.or.cz/libvirt-python/ericb.git/shortlog/refs/tags/backup-v7 Here's hoping we're happy enough with the API, including the fact that rudimentary operation of pull mode backups work with qemu 4.0-rc1, for this to make it into the 5.2 release. Diffs from v6 - couple more early easy cleanups - add Dan's R-b where appropriate - drop any attempt at virDomainGetJobIds(), instead: - document that job id 0 always works for the current backup job (if there is just one), which is just fine for now because qemu 4.0 doesn't permit parallel jobs (and we can do full job id support for a later release) - split some more patches; finish moving backup code to a new backup_conf.c and not piggybacked onto checkpoint_conf.c Eric Blake (23): snapshot: Drop pointless function virDomainMomentIsCurrentName snapshot: Allow NULL to virDomainSnapshotObjGetDef snapshot: Refactor qemu to utilize virDomainMoment more backup: Document new XML for checkpoints backup: Document new XML for backups backup: Introduce virDomainCheckpoint APIs backup: Introduce virDomainBackup APIs backup: Document nuances between different state capture APIs backup: Parse and output checkpoint XML backup: Allow for lists of checkpoint objects squash to checkpoint list backup: Add new domain:checkpoint access control backup: Implement backup APIs for remote driver backup: Parse and output backup XML backup: Implement virsh support for checkpoints backup: Implement virsh support for backup backup: Add new qemu monitor interactions backup: qemu: Implement metadata tracking for checkpoint APIs backup: Wire up qemu checkpoint commands over QMP backup: qemu: Implement framework for backup job APIs backup: Wire up qemu full pull backup commands over QMP backup: qemu: Wire up qemu full push backup commands over QMP backup: implement qemu incremental pull backup include/libvirt/libvirt-domain-checkpoint.h | 161 ++ include/libvirt/libvirt-domain-snapshot.h | 8 +- include/libvirt/libvirt-domain.h | 47 +- include/libvirt/libvirt.h | 5 +- src/access/viraccessperm.h | 8 +- src/conf/backup_conf.h | 96 + src/conf/checkpoint_conf.h | 103 ++ src/conf/domain_conf.h | 2 + src/conf/virconftypes.h | 12 + src/conf/virdomaincheckpointobjlist.h | 74 + src/conf/virdomainmomentobjlist.h | 9 +- src/conf/virdomainobjlist.h | 9 +- src/conf/virdomainsnapshotobjlist.h | 4 +- src/driver-hypervisor.h | 81 +- src/qemu/qemu_block.h | 3 + src/qemu/qemu_blockjob.h | 1 + src/qemu/qemu_capabilities.h | 4 + src/qemu/qemu_conf.h | 2 + src/qemu/qemu_domain.h | 39 +- src/qemu/qemu_monitor.h | 21 +- src/qemu/qemu_monitor_json.h | 21 +- tools/virsh-checkpoint.h | 29 + tools/virsh-completer.h | 4 + tools/virsh-util.h | 3 + tools/virsh.h | 1 + docs/Makefile.am | 3 + docs/apibuild.py | 2 + docs/docs.html.in | 10 +- docs/domainstatecapture.html.in | 315 ++++ docs/format.html.in | 2 + docs/formatbackup.html.in | 184 ++ docs/formatcheckpoint.html.in | 204 +++ docs/formatsnapshot.html.in | 2 + docs/index.html.in | 4 +- docs/schemas/domainbackup.rng | 219 +++ docs/schemas/domaincheckpoint.rng | 87 + examples/object-events/event-test.c | 3 + libvirt.spec.in | 3 + mingw-libvirt.spec.in | 6 + po/POTFILES | 3 + src/Makefile.am | 2 + src/access/viraccessperm.c | 5 +- src/conf/Makefile.inc.am | 6 + src/conf/backup_conf.c | 544 ++++++ src/conf/checkpoint_conf.c | 639 +++++++ src/conf/domain_conf.c | 8 +- src/conf/snapshot_conf.c | 2 +- src/conf/virdomaincheckpointobjlist.c | 222 +++ src/conf/virdomainmomentobjlist.c | 49 +- src/conf/virdomainobjlist.c | 13 +- src/conf/virdomainsnapshotobjlist.c | 11 +- src/libvirt-domain-checkpoint.c | 750 ++++++++ src/libvirt-domain-snapshot.c | 89 + src/libvirt-domain.c | 239 ++- src/libvirt_private.syms | 33 +- src/libvirt_public.syms | 20 + src/qemu/qemu_block.c | 12 + src/qemu/qemu_capabilities.c | 6 + src/qemu/qemu_conf.c | 5 + src/qemu/qemu_domain.c | 249 ++- src/qemu/qemu_driver.c | 1609 ++++++++++++++++- src/qemu/qemu_migration.c | 2 +- src/qemu/qemu_monitor.c | 65 +- src/qemu/qemu_monitor_json.c | 201 +- src/qemu/qemu_process.c | 7 + src/remote/remote_daemon_dispatch.c | 22 +- src/remote/remote_driver.c | 34 +- src/remote/remote_protocol.x | 259 ++- src/remote_protocol-structs | 139 ++ src/rpc/gendispatch.pl | 34 +- src/test/test_driver.c | 7 +- tests/Makefile.am | 13 +- tests/domainbackupxml2xmlin/backup-pull.xml | 9 + tests/domainbackupxml2xmlin/backup-push.xml | 9 + tests/domainbackupxml2xmlin/empty.xml | 1 + tests/domainbackupxml2xmlout/backup-pull.xml | 9 + tests/domainbackupxml2xmlout/backup-push.xml | 9 + tests/domainbackupxml2xmlout/empty.xml | 7 + tests/domaincheckpointxml2xmlin/empty.xml | 1 + tests/domaincheckpointxml2xmlin/redefine.xml | 63 + tests/domaincheckpointxml2xmlin/sample.xml | 7 + tests/domaincheckpointxml2xmlin/size.xml | 4 + tests/domaincheckpointxml2xmlout/empty.xml | 7 + tests/domaincheckpointxml2xmlout/sample.xml | 12 + tests/domaincheckpointxml2xmlout/size.xml | 11 + tests/domaincheckpointxml2xmltest.c | 212 +++ .../caps_4.0.0.riscv32.xml | 2 + .../caps_4.0.0.riscv64.xml | 2 + .../caps_4.0.0.x86_64.xml | 2 + tests/qemumonitorjsontest.c | 2 +- tests/virschematest.c | 4 + tools/Makefile.am | 3 +- tools/virsh-checkpoint.c | 1370 ++++++++++++++ tools/virsh-completer.c | 53 +- tools/virsh-domain-monitor.c | 25 +- tools/virsh-domain.c | 270 ++- tools/virsh-snapshot.c | 37 +- tools/virsh-util.c | 11 + tools/virsh.c | 2 + tools/virsh.pod | 302 +++- 100 files changed, 9373 insertions(+), 163 deletions(-) create mode 100644 include/libvirt/libvirt-domain-checkpoint.h create mode 100644 src/conf/backup_conf.h create mode 100644 src/conf/checkpoint_conf.h create mode 100644 src/conf/virdomaincheckpointobjlist.h create mode 100644 tools/virsh-checkpoint.h create mode 100644 docs/domainstatecapture.html.in create mode 100644 docs/formatbackup.html.in create mode 100644 docs/formatcheckpoint.html.in create mode 100644 docs/schemas/domainbackup.rng create mode 100644 docs/schemas/domaincheckpoint.rng create mode 100644 src/conf/backup_conf.c create mode 100644 src/conf/checkpoint_conf.c create mode 100644 src/conf/virdomaincheckpointobjlist.c create mode 100644 src/libvirt-domain-checkpoint.c create mode 100644 tests/domainbackupxml2xmlin/backup-pull.xml create mode 100644 tests/domainbackupxml2xmlin/backup-push.xml create mode 100644 tests/domainbackupxml2xmlin/empty.xml create mode 100644 tests/domainbackupxml2xmlout/backup-pull.xml create mode 100644 tests/domainbackupxml2xmlout/backup-push.xml create mode 100644 tests/domainbackupxml2xmlout/empty.xml create mode 100644 tests/domaincheckpointxml2xmlin/empty.xml create mode 100644 tests/domaincheckpointxml2xmlin/redefine.xml create mode 100644 tests/domaincheckpointxml2xmlin/sample.xml create mode 100644 tests/domaincheckpointxml2xmlin/size.xml create mode 100644 tests/domaincheckpointxml2xmlout/empty.xml create mode 100644 tests/domaincheckpointxml2xmlout/sample.xml create mode 100644 tests/domaincheckpointxml2xmlout/size.xml create mode 100644 tests/domaincheckpointxml2xmltest.c create mode 100644 tools/virsh-checkpoint.c -- 2.20.1

4 63

[libvirt] [PATCH] tests: don't abort in fopen(/proc/mounts)
by Daniel P. Berrangé 27 Mar '19

27 Mar '19

The mock fopen() function will abort if "/proc/mounts" is requested with "r" permissions and VIR_CGROUP_MOCK_FILENAME env var is not set. Unfortunately this is triggering by the libselinux library constructor when it tries to read /proc/mounts to find out if selinuxfs is mounted in an unusual place. This, however, only affects libselinux in Debian as that opens with "r", while in Fedora / RHEL it opens "re" and thus luckily never triggered the abort(), instead getting an EACCESS. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- tests/vircgroupmock.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/vircgroupmock.c b/tests/vircgroupmock.c index 06bd0a5f29..9c67a44b0d 100644 --- a/tests/vircgroupmock.c +++ b/tests/vircgroupmock.c @@ -460,8 +460,10 @@ FILE *fopen(const char *path, const char *mode) } if (type) { - if (!filename) - abort(); + if (!filename) { + errno = EACCES; + return NULL; + } if (virAsprintfQuiet(&filepath, "%s/vircgroupdata/%s.%s", abs_srcdir, filename, type) < 0) { abort(); -- 2.20.1

2 3

[libvirt] [PATCH v6 0/9] Incremental backups, focus on API
by Eric Blake 27 Mar '19

27 Mar '19

I'm fairly confident that these API are ready to go (that is, I've got qemu code in the wings to implement these API for the qemu driver, as demonstrated at last KVM forum, and it shouldn't be too hard to add support in the test driver to get some 'make check' coverage similar to what I recently added for snapshots). I'm hoping the APIs make it in for 5.2, even if I'm still dealing with review churn on the later parts of my v5 series (there has been a lot of rebasing from earlier review comments, so v5 is currently still the most recent version that I was able to run demos with, although I hope to post the rest of v6 soon). The biggest diffs compared to v4/v5 are addressing many of John Ferlan's grammar suggestions, removing some TODO items from the public API (although implementing those changes, such as the new VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE, is still on my todo list), splitting some large patches (checkpoints and backups are now separated), moving the backup APIs into libvirt-domain.c instead of piggybacking on libvirt-domain-checkpoint.c, and adding 2 more API (virDomainSnapshotCreateXML2 to create a checkpoint at the same time as a snapshot; virDomainListJobIds to learn the job ids of all currently running backup jobs [the initial implementation will only ever have job id 1 due to qemu 4.0 limitations, but the API was designed with future expansion in mind]). I've also got some preliminary patches to snapshot in this posting based on things noticed while working checkpoints. 001/9:[down] 'Revert "snapshot: Add virDomainSnapshotObjListParse"' 002/9:[down] 'Revert "snapshot: Add virDomainSnapshotObjListFormat"' 003/9:[down] 'snapshot: Various doc tweaks' 004/9:[0005] [FC] 'backup: Introduce virDomainCheckpointPtr' 005/9:[down] 'backup: Document new XML for checkpoints' 006/9:[0562] [FC] 'backup: Document new XML for backups' 007/9:[0173] [FC] 'backup: Introduce virDomainCheckpoint APIs' 008/9:[0296] [FC] 'backup: Introduce virDomainBackup APIs' 009/9:[0039] [FC] 'backup: Document nuances between different state capture APIs' Eric Blake (9): Revert "snapshot: Add virDomainSnapshotObjListParse" Revert "snapshot: Add virDomainSnapshotObjListFormat" snapshot: Various doc tweaks backup: Introduce virDomainCheckpointPtr backup: Document new XML for checkpoints backup: Document new XML for backups backup: Introduce virDomainCheckpoint APIs backup: Introduce virDomainBackup APIs backup: Document nuances between different state capture APIs include/libvirt/virterror.h | 7 +- src/util/virerror.c | 12 +- include/libvirt/libvirt-domain-checkpoint.h | 161 ++++ include/libvirt/libvirt-domain-snapshot.h | 7 +- include/libvirt/libvirt-domain.h | 59 +- include/libvirt/libvirt.h | 3 +- src/conf/snapshot_conf.h | 7 - src/conf/virdomainmomentobjlist.h | 5 +- src/conf/virdomainsnapshotobjlist.h | 13 - src/datatypes.h | 33 +- src/driver-hypervisor.h | 87 ++- src/qemu/qemu_blockjob.h | 1 + docs/Makefile.am | 3 + docs/apibuild.py | 2 + docs/docs.html.in | 10 +- docs/domainstatecapture.html.in | 313 ++++++++ docs/format.html.in | 2 + docs/formatbackup.html.in | 181 +++++ docs/formatcheckpoint.html.in | 204 +++++ docs/formatsnapshot.html.in | 82 +- docs/index.html.in | 4 +- docs/schemas/domainbackup.rng | 219 ++++++ docs/schemas/domaincheckpoint.rng | 94 +++ examples/object-events/event-test.c | 3 + libvirt.spec.in | 3 + mingw-libvirt.spec.in | 6 + po/POTFILES | 1 + src/Makefile.am | 2 + src/conf/domain_conf.c | 2 +- src/conf/snapshot_conf.c | 2 +- src/conf/virdomainsnapshotobjlist.c | 166 ---- src/datatypes.c | 63 +- src/libvirt-domain-checkpoint.c | 749 +++++++++++++++++++ src/libvirt-domain-snapshot.c | 311 ++++---- src/libvirt-domain.c | 289 ++++++- src/libvirt_private.syms | 4 +- src/libvirt_public.syms | 21 + tests/Makefile.am | 4 + tests/domainbackupxml2xmlin/backup-pull.xml | 9 + tests/domainbackupxml2xmlin/backup-push.xml | 9 + tests/domainbackupxml2xmlin/empty.xml | 1 + tests/domainbackupxml2xmlout/backup-pull.xml | 9 + tests/domainbackupxml2xmlout/backup-push.xml | 9 + tests/domainbackupxml2xmlout/empty.xml | 7 + tests/domaincheckpointxml2xmlin/empty.xml | 1 + tests/domaincheckpointxml2xmlin/sample.xml | 7 + tests/domaincheckpointxml2xmlout/empty.xml | 10 + tests/domaincheckpointxml2xmlout/sample.xml | 16 + tests/virschematest.c | 4 + tools/virsh-domain.c | 8 +- 50 files changed, 2794 insertions(+), 431 deletions(-) create mode 100644 include/libvirt/libvirt-domain-checkpoint.h create mode 100644 docs/domainstatecapture.html.in create mode 100644 docs/formatbackup.html.in create mode 100644 docs/formatcheckpoint.html.in create mode 100644 docs/schemas/domainbackup.rng create mode 100644 docs/schemas/domaincheckpoint.rng create mode 100644 src/libvirt-domain-checkpoint.c create mode 100644 tests/domainbackupxml2xmlin/backup-pull.xml create mode 100644 tests/domainbackupxml2xmlin/backup-push.xml create mode 100644 tests/domainbackupxml2xmlin/empty.xml create mode 100644 tests/domainbackupxml2xmlout/backup-pull.xml create mode 100644 tests/domainbackupxml2xmlout/backup-push.xml create mode 100644 tests/domainbackupxml2xmlout/empty.xml create mode 100644 tests/domaincheckpointxml2xmlin/empty.xml create mode 100644 tests/domaincheckpointxml2xmlin/sample.xml create mode 100644 tests/domaincheckpointxml2xmlout/empty.xml create mode 100644 tests/domaincheckpointxml2xmlout/sample.xml -- 2.20.1

5 28

[libvirt] [PATCH 1/2] qemu: Fix "boolen" typo in API doc
by Christophe Fergeau 27 Mar '19

27 Mar '19

This also adjusts the argument name which should be 'isListen' in both cases rather than 'listen'. Signed-off-by: Christophe Fergeau <cfergeau(a)redhat.com> --- src/qemu/qemu_command.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index f81d20e5f7..bfa7211894 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -876,7 +876,7 @@ qemuBuildRBDSecinfoURI(virBufferPtr buf, /* qemuBuildTLSx509BackendProps: * @tlspath: path to the TLS credentials - * @listen: boolen listen for client or server setting + * @isListen: boolen listen for client or server setting * @verifypeer: boolean to enable peer verification (form of authorization) * @alias: alias for the TLS credentials object * @secalias: if one exists, the alias of the security object for passwordid @@ -917,7 +917,7 @@ qemuBuildTLSx509BackendProps(const char *tlspath, /* qemuBuildTLSx509CommandLine: * @cmd: Pointer to command * @tlspath: path to the TLS credentials - * @listen: boolen listen for client or server setting + * @isListen: boolean listen for client or server setting * @verifypeer: boolean to enable peer verification (form of authorization) * @certEncSecretAlias: alias of a 'secret' object for decrypting TLS private key * (optional) -- 2.21.0

2 3

[libvirt] [PATCH] news: Document parallel migration
by Jiri Denemark 27 Mar '19

27 Mar '19

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- docs/news.xml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 83e965e0f3..2067830848 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -104,6 +104,18 @@ E.g. <code><controller type='xenbus' maxGrantFrames='64'/></code> </description> </change> + <change> + <summary> + qemu: Add support for parallel migration + </summary> + <description> + With QEMU 4.0.0 libvirt can enable parallel migration which causes + the memory pages to be processed in parallel by several threads and + sent to the destination host using several connections at the same + time. This may increase migration speed in case a single thread is + unable to saturate the network link. + </description> + </change> </section> <section title="Removed features"> <change> -- 2.21.0

2 1

[libvirt] [dockerfiles PATCH] Add Dockerfile for i686 cross-compilation
by Andrea Bolognani 27 Mar '19

27 Mar '19

We didn't add this until now because i686 cross-compilation requires special care and lcitool was known to produce broken Dockerfiles, but that's been fixed as of libvirt-jenkins-ci commit f72d09153905 so we can finally go ahead and complete our coverage of non-x86_64 architectures. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- buildenv-debian-sid-cross-i686.Dockerfile | 93 +++++++++++++++++++++++ 1 file changed, 93 insertions(+) create mode 100644 buildenv-debian-sid-cross-i686.Dockerfile diff --git a/buildenv-debian-sid-cross-i686.Dockerfile b/buildenv-debian-sid-cross-i686.Dockerfile new file mode 100644 index 0000000..0ac238b --- /dev/null +++ b/buildenv-debian-sid-cross-i686.Dockerfile @@ -0,0 +1,93 @@ +FROM debian:sid + +RUN export DEBIAN_FRONTEND=noninteractive && \ + apt-get update && \ + apt-get dist-upgrade -y && \ + apt-get install --no-install-recommends -y \ + augeas-tools \ + autoconf \ + automake \ + autopoint \ + bash \ + bash-completion \ + ccache \ + chrony \ + dnsmasq-base \ + dwarves \ + ebtables \ + gcc \ + gettext \ + git \ + iproute2 \ + kmod \ + libc-dev-bin \ + libtool \ + libtool-bin \ + libxml2-utils \ + lvm2 \ + make \ + nfs-common \ + numad \ + open-iscsi \ + parted \ + patch \ + perl \ + pkgconf \ + policykit-1 \ + qemu-utils \ + radvd \ + screen \ + scrub \ + sudo \ + vim \ + xsltproc \ + zfs-fuse && \ + apt-get autoremove -y && \ + apt-get autoclean -y + +RUN export DEBIAN_FRONTEND=noninteractive && \ + dpkg --add-architecture i386 && \ + apt-get update && \ + apt-get dist-upgrade -y && \ + apt-get install --no-install-recommends -y \ + gcc-i686-linux-gnu \ + libacl1-dev:i386 \ + libapparmor-dev:i386 \ + libattr1-dev:i386 \ + libaudit-dev:i386 \ + libavahi-client-dev:i386 \ + libblkid-dev:i386 \ + libc6-dev:i386 \ + libcap-ng-dev:i386 \ + libcurl4-gnutls-dev:i386 \ + libdbus-1-dev:i386 \ + libdevmapper-dev:i386 \ + libfuse-dev:i386 \ + libglusterfs-dev:i386 \ + libgnutls28-dev:i386 \ + libiscsi-dev:i386 \ + libnl-3-dev:i386 \ + libnl-route-3-dev:i386 \ + libnuma-dev:i386 \ + libparted-dev:i386 \ + libpcap0.8-dev:i386 \ + libpciaccess-dev:i386 \ + librbd-dev:i386 \ + libreadline-dev:i386 \ + libsanlock-dev:i386 \ + libsasl2-dev:i386 \ + libselinux1-dev:i386 \ + libssh-gcrypt-dev:i386 \ + libssh2-1-dev:i386 \ + libtirpc-dev:i386 \ + libudev-dev:i386 \ + libxml2-dev:i386 \ + libyajl-dev:i386 \ + xfslibs-dev:i386 && \ + apt-get autoremove -y && \ + apt-get autoclean -y + +ENV ABI "i686-linux-gnu" +ENV CONFIGURE_OPTS "--host=i686-linux-gnu \ + --target=i686-linux-gnu" +ENV PKG_CONFIG_LIBDIR "/usr/lib/i386-linux-gnu/pkgconfig" -- 2.20.1

2 3

[libvirt] [PATCH] spec: Move ldconfig calls from -client to -libs
by Andrea Bolognani 27 Mar '19

27 Mar '19

ldconfig needs to be called after installing or uninstalling shared libraries. For a very long time, libvirt didn't have a separate package containing just the shared libraries, and so it shipped them in the same one as the clients. Since commit 70b4f0e719cd, however, shared libraries have been moved from -client to their own -libs package; unfortunately, the corresponding ldconfig calls were not moved at the same time, which is what this commit takes care of. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- libvirt.spec.in | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index b7a35a0fb1..8ea27c91a3 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1328,6 +1328,16 @@ then exit 1 fi +%post libs +%if 0%{?rhel} == 7 +/sbin/ldconfig +%endif + +%postun libs +%if 0%{?rhel} == 7 +/sbin/ldconfig +%endif + %pre daemon # 'libvirt' group is just to allow password-less polkit access to # libvirtd. The uid number is irrelevant, so we use dynamic allocation @@ -1469,17 +1479,9 @@ exit 0 %systemd_preun libvirt-guests.service %post client - -%if 0%{?rhel} == 7 -/sbin/ldconfig -%endif %systemd_post libvirt-guests.service %postun client - -%if 0%{?rhel} == 7 -/sbin/ldconfig -%endif %systemd_postun libvirt-guests.service %if %{with_sanlock} -- 2.20.1

2 1

[libvirt] [PATCH v2 0/3] qemu: Add support for parallel migration
by Jiri Denemark 27 Mar '19

27 Mar '19

This series adds a new VIR_MIGRATE_PARALLEL flag for migration APIs which will ask the hypervisor to use multiple parallel connections for migrating a domain. The number of parallel connections can be set using VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS typed parameter. Version 2: - rebased Jiri Denemark (3): Public API for parallel migration qemu: Add support for parallel migration virsh: Add options for parallel migration include/libvirt/libvirt-domain.h | 14 ++++++++++++++ src/qemu/qemu_migration.c | 9 ++++++--- src/qemu/qemu_migration.h | 5 ++++- src/qemu/qemu_migration_params.c | 18 ++++++++++++++++++ src/qemu/qemu_migration_params.h | 2 ++ tools/virsh-domain.c | 19 +++++++++++++++++++ tools/virsh.pod | 7 +++++++ 7 files changed, 70 insertions(+), 4 deletions(-) -- 2.20.1

2 8

[libvirt] [PATCH v5 00/20] Incremental Backup API additions
by Eric Blake 27 Mar '19

27 Mar '19

The following is the latest version of my API proposal for incremental backups, and follows along from the demo I presented as part of my KVM Forum 2018 talk: https://kvmforum2018.sched.com/event/FzuB/facilitating-incremental-backup-e… The patches are also available via https://repo.or.cz/libvirt/ericb.git at the tag backup-v5. Depends on my earlier bulk redefine for snapshots, which is pending review at v3: https://www.redhat.com/archives/libvir-list/2019-March/msg00144.html I haven't finished addressing all of John Ferlan's review comments from v4 (including the fact that several of these larger patches need to be split for easier reviews, and the fact that I want virDomainSnapshotObj and virDomainCheckpointObj to share a common base class); but I'm posting this now because I _have_ completed: - push mode backups mostly work (event notification is still not polished, but the fact that I can now do both push and pull modes is nice) - bulk mode list/redefine, accessible via 'virsh dumpxml --checkpoints' and 'virsh snapshot-create --redefine-list' - move virDomainBackup() into libvirt-domain.h (libvirt-domain-checkpoint.h is now JUST about standalone checkpoint objects; then both virDomainBackup() and virDomainSnapshotCreateXML() will be able to create a checkpoint in parallel) - rebase to master (5.2 now instead of 5.1, start using VIR_AUTOFREE in more places, ...) I'm still debating about making <domaincheckpoint> a sub-element of <domainbackup> (in which case I can reuse virDomainSnapshotCreateXML() to create a backup) or keeping it as a separate XML argument (in which case I need to add an API for virDomainSnapshotCreateXMLWithSnapshot()). I also need to work out an API for listing all currently running jobs (even if the current backup code can only run one job at a time, we know we want support in the future for parallel backup jobs). So there WILL be a v6. Hopefully, though, we can start trimming off the front of the series, and at least now the tail of the series currently compiles (John gave up review on v4 when he ran into rebase issues - although with our current rate of VIR_AUTOFREE conversions, there may again be rebase issues soon...) since v4: 001/20:[----] [-C] 'domain_conf: Expose virDomainStorageNetworkParseHost' 002/20:[down] 'qemu: clean up qemuDomainRemoveInactiveCommon' 003/20:[----] [--] 'backup: Document nuances between different state capture APIs' 004/20:[0020] [FC] 'backup: Introduce virDomainCheckpointPtr' 005/20:[down] 'wip: backup: Document new XML for backups' 006/20:[0054] [FC] 'backup: Introduce virDomainCheckpoint APIs' 007/20:[0053] [FC] 'backup: Introduce virDomainBackup APIs' 008/20:[0002] [FC] 'backup: Add new domain:checkpoint access control' 009/20:[0093] [FC] 'backup: Implement backup APIs for remote driver' 010/20:[0381] [FC] 'wip: backup: Parse and output checkpoint XML' 011/20:[0001] [FC] 'wip: backup: Parse and output backup XML' 012/20:[0393] [FC] 'backup: Implement virsh support for checkpoints' 013/20:[0058] [FC] 'wip: backup: virsh support for backup' 014/20:[0019] [FC] 'backup: Add new qemu monitor interactions' 015/20:[0161] [FC] 'backup: qemu: Implement metadata tracking for checkpoint APIs' 016/20:[----] [-C] 'wip: backup: Wire up qemu checkpoint commands over QMP' 017/20:[0006] [FC] 'wip: backup: qemu: Implement framework for backup job APIs' 018/20:[0046] [FC] 'backup: Wire up qemu full pull backup commands over QMP' 019/20:[down] 'wip: backup: qemu: Wire up qemu full push backup commands over QMP' 020/20:[0022] [FC] 'backup: implement qemu incremental pull backup' Eric Blake (20): domain_conf: Expose virDomainStorageNetworkParseHost qemu: clean up qemuDomainRemoveInactiveCommon backup: Document nuances between different state capture APIs backup: Introduce virDomainCheckpointPtr wip: backup: Document new XML for backups backup: Introduce virDomainCheckpoint APIs backup: Introduce virDomainBackup APIs backup: Add new domain:checkpoint access control backup: Implement backup APIs for remote driver wip: backup: Parse and output checkpoint XML wip: backup: Parse and output backup XML backup: Implement virsh support for checkpoints wip: backup: virsh support for backup backup: Add new qemu monitor interactions backup: qemu: Implement metadata tracking for checkpoint APIs wip: backup: Wire up qemu checkpoint commands over QMP wip: backup: qemu: Implement framework for backup job APIs backup: Wire up qemu full pull backup commands over QMP wip: backup: qemu: Wire up qemu full push backup commands over QMP backup: implement qemu incremental pull backup include/libvirt/virterror.h | 6 +- src/util/virerror.c | 12 +- include/libvirt/libvirt-domain-checkpoint.h | 161 ++ include/libvirt/libvirt-domain.h | 48 +- include/libvirt/libvirt.h | 3 +- src/access/viraccessperm.h | 8 +- src/conf/checkpoint_conf.h | 237 +++ src/conf/domain_conf.h | 17 + src/conf/virdomainobjlist.h | 9 +- src/datatypes.h | 31 +- src/driver-hypervisor.h | 74 +- src/qemu/qemu_block.h | 3 + src/qemu/qemu_blockjob.h | 1 + src/qemu/qemu_capabilities.h | 4 + src/qemu/qemu_conf.h | 2 + src/qemu/qemu_domain.h | 32 +- src/qemu/qemu_monitor.h | 21 +- src/qemu/qemu_monitor_json.h | 19 +- tools/virsh-checkpoint.h | 29 + tools/virsh-completer.h | 4 + tools/virsh-util.h | 3 + tools/virsh.h | 1 + docs/Makefile.am | 3 + docs/apibuild.py | 2 + docs/docs.html.in | 10 +- docs/domainstatecapture.html.in | 314 +++ docs/format.html.in | 2 + docs/formatbackup.html.in | 123 ++ docs/formatcheckpoint.html.in | 188 ++ docs/formatsnapshot.html.in | 2 + docs/index.html.in | 4 +- docs/schemas/domainbackup.rng | 185 ++ docs/schemas/domaincheckpoint.rng | 94 + examples/object-events/event-test.c | 3 + libvirt.spec.in | 3 + mingw-libvirt.spec.in | 6 + po/POTFILES | 3 + src/Makefile.am | 2 + src/access/viraccessperm.c | 5 +- src/conf/Makefile.inc.am | 2 + src/conf/checkpoint_conf.c | 1743 +++++++++++++++++ src/conf/domain_conf.c | 73 +- src/conf/virdomainobjlist.c | 12 +- src/datatypes.c | 63 +- src/libvirt-domain-checkpoint.c | 741 +++++++ src/libvirt-domain.c | 217 +- src/libvirt_private.syms | 33 + src/libvirt_public.syms | 19 + src/qemu/qemu_block.c | 12 + src/qemu/qemu_capabilities.c | 6 + src/qemu/qemu_conf.c | 5 + src/qemu/qemu_domain.c | 276 ++- src/qemu/qemu_driver.c | 1661 +++++++++++++++- src/qemu/qemu_migration.c | 2 +- src/qemu/qemu_monitor.c | 65 +- src/qemu/qemu_monitor_json.c | 199 +- src/qemu/qemu_process.c | 7 + src/remote/remote_daemon_dispatch.c | 22 +- src/remote/remote_driver.c | 33 +- src/remote/remote_protocol.x | 239 ++- src/remote_protocol-structs | 129 ++ src/rpc/gendispatch.pl | 32 +- tests/Makefile.am | 15 +- tests/domainbackupxml2xmlin/backup-pull.xml | 9 + tests/domainbackupxml2xmlin/backup-push.xml | 9 + tests/domainbackupxml2xmlin/empty.xml | 1 + tests/domainbackupxml2xmlout/backup-pull.xml | 9 + tests/domainbackupxml2xmlout/backup-push.xml | 9 + tests/domainbackupxml2xmlout/empty.xml | 7 + tests/domaincheckpointxml2xmlin/empty.xml | 1 + tests/domaincheckpointxml2xmlin/sample.xml | 7 + tests/domaincheckpointxml2xmlout/empty.xml | 10 + tests/domaincheckpointxml2xmlout/sample.xml | 16 + tests/domaincheckpointxml2xmltest.c | 233 +++ .../caps_4.0.0.riscv32.xml | 2 + .../caps_4.0.0.riscv64.xml | 2 + tests/qemumonitorjsontest.c | 2 +- tests/virschematest.c | 4 + tools/Makefile.am | 3 +- tools/virsh-checkpoint.c | 1377 +++++++++++++ tools/virsh-completer.c | 52 +- tools/virsh-domain-monitor.c | 25 +- tools/virsh-domain.c | 277 ++- tools/virsh-util.c | 11 + tools/virsh.c | 2 + tools/virsh.pod | 272 ++- 86 files changed, 9510 insertions(+), 110 deletions(-) create mode 100644 include/libvirt/libvirt-domain-checkpoint.h create mode 100644 src/conf/checkpoint_conf.h create mode 100644 tools/virsh-checkpoint.h create mode 100644 docs/domainstatecapture.html.in create mode 100644 docs/formatbackup.html.in create mode 100644 docs/formatcheckpoint.html.in create mode 100644 docs/schemas/domainbackup.rng create mode 100644 docs/schemas/domaincheckpoint.rng create mode 100644 src/conf/checkpoint_conf.c create mode 100644 src/libvirt-domain-checkpoint.c create mode 100644 tests/domainbackupxml2xmlin/backup-pull.xml create mode 100644 tests/domainbackupxml2xmlin/backup-push.xml create mode 100644 tests/domainbackupxml2xmlin/empty.xml create mode 100644 tests/domainbackupxml2xmlout/backup-pull.xml create mode 100644 tests/domainbackupxml2xmlout/backup-push.xml create mode 100644 tests/domainbackupxml2xmlout/empty.xml create mode 100644 tests/domaincheckpointxml2xmlin/empty.xml create mode 100644 tests/domaincheckpointxml2xmlin/sample.xml create mode 100644 tests/domaincheckpointxml2xmlout/empty.xml create mode 100644 tests/domaincheckpointxml2xmlout/sample.xml create mode 100644 tests/domaincheckpointxml2xmltest.c create mode 100644 tools/virsh-checkpoint.c -- 2.20.1

2 29

[libvirt] [PATCH v2 00/14] qemu_hotplug: refactor device detach functions to fix one serious and other minor bugs
by Laine Stump 26 Mar '19

26 Mar '19

V1: https://www.redhat.com/archives/libvir-list/2019-March/msg01455.html I pushed patches 01-12, since they were acked, and pushing them leaves the code in no worse state than it was before (all tests still pass). There are 4 new patches in V2, created as a result of Peter asking for patches to be split, or for further refactoring. Still to be done: Peter pointed out that qemuDomainUpdateDeviceLlist() really shouldn't be called until after qemu has sent the DEVICE_DELETED event. That is on my list of followups, but the patches here are still a valid improvement even without that (After his comment, I noticed that we are also calling virDomainSaveStatus too soon - it also shouldn't be called until after DEVICE_DELETED). Laine Stump (14): qemu_hotplug: move qemuDomainDetachDeviceLive() to qemu_hotplug.c qemu_hotplug: remove extra function in middle of DetachController call chain qemu_hotplug: pull qemuDomainUpdateDeviceList out of qemuDomainDetachDeviceLive test: replace calls to individual detach functions with one call to main detach qemu_hotplug: make Detach functions called only from qemu_hotplug.c static qemu_hotplug: rename dev to match in qemuDomainDetachDeviceLive qemu_hotplug: separate Chr|Lease from other devices in DetachDevice switch qemu_hotplug: standardize the names/args/calling of qemuDomainDetach*() qemu_hotplug: rename Chr and Lease Detach functions qemu_hotplug: new function qemuDomainRemoveAuditDevice() qemu_hotplug: audit *all* auditable device types in qemuDomainRemoveAuditDevice qemu_hotplug: consolidate all common detach code in qemuDomainDetachDeviceLive qemu_hotplug: delay sending DEVICE_REMOVED event until after *all* teardown qemu_hotplug: don't shutdown net device until the guest has released it src/qemu/qemu_driver.c | 109 +---- src/qemu/qemu_hotplug.c | 919 +++++++++++++++++++--------------------- src/qemu/qemu_hotplug.h | 56 +-- tests/qemuhotplugtest.c | 8 +- 4 files changed, 465 insertions(+), 627 deletions(-) -- 2.20.1

3 34

[libvirt] [PATCH v3 0/2] m4: Run QEMU under a distro-specific user when possible
by Andrea Bolognani 26 Mar '19

26 Mar '19

Changes from [v2]: * add explicit fallback to root:root for unrecognized operating systems; * provide logging to help users understand why they ended up with root:root in the first place. Changes from [v1]: * use distro-specific user and group; * warn the user if they are going to be running QEMU as root. [v2] https://www.redhat.com/archives/libvir-list/2019-March/msg01737.html [v1] https://www.redhat.com/archives/libvir-list/2019-March/msg01707.html Andrea Bolognani (2): m4: Run QEMU under a distro-specific user when possible m4: Add warning when running QEMU as root m4/virt-driver-qemu.m4 | 45 +++++++++++++++++++++++++++++++++++++++--- 1 file changed, 42 insertions(+), 3 deletions(-) -- 2.20.1

2 4

[libvirt] [PATCH v2 0/2] m4: Run QEMU under a distro-specific user when possible
by Andrea Bolognani 26 Mar '19

26 Mar '19

Changes from [v1]: * use distro-specific user and group; * warn the user if they are going to be running QEMU as root. [v1] https://www.redhat.com/archives/libvir-list/2019-March/msg01707.html Andrea Bolognani (2): m4: Run QEMU under a distro-specific user when possible m4: Add warning when running QEMU as root m4/virt-driver-qemu.m4 | 37 ++++++++++++++++++++++++++++++++++--- 1 file changed, 34 insertions(+), 3 deletions(-) -- 2.20.1

3 6

[libvirt] [PATCH] m4: Change default QEMU credentials to qemu:qemu
by Andrea Bolognani 26 Mar '19

26 Mar '19

Our current defaults are root:wheel on FreeBSD and macOS, root:root everywhere else. Looking at what downstream distributions actually do, we can see that these defaults are overriden the vast majority of the time, with a number of variations showing up in the wild: * qemu:qemu -> Used by CentOS, Fedora, Gentoo, OpenSUSE, RHEL and... As it turns out, our very own spec file :) * libvirt-qemu:libvirt-qemu -> Used by Debian. * libvirt-qemu:kvm -> Used by Ubuntu. * nobody:nobody -> Used by Arch Linux. Based on the above, we can conclude that qemu:qemu are the preferred credentials to be used when spawning a QEMU process, while our current defaults get very little love. Changing our defaults aligns with what most downstreams are actually doing, promotes running QEMU under a non-root user - which is a very good idea anyway - and shields random people building libvirt from source from unwittingly running their guests as root. Note that there are a very small number of downstreams that don't override our defaults: Alpine Linux, FreeBSD and macOS. Of those, only Alpine Linux is affected by this change; all three should arguably have been setting --with-qemu-user and --with-qemu-group explicitly regardless of this change. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Proof that I'm not making any of this up ;) * Alpine Linux https://github.com/alpinelinux/aports/blob/master/main/libvirt/APKBUILD * Arch Linux https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=libvirt-git#n113 * CentOS https://git.centos.org/blob/rpms!libvirt.git/8d86411e5109d791edf49c7f43c08a… * Debian https://salsa.debian.org/libvirt-team/libvirt/blob/debian/sid/debian/rules#… * Fedora https://src.fedoraproject.org/rpms/libvirt/blob/f29/f/libvirt.spec#_204 * FreeBSD https://github.com/freebsd/freebsd-ports/blob/master/devel/libvirt/Makefile * Gentoo https://github.com/gentoo/gentoo/blob/master/app-emulation/libvirt/libvirt-… * macOS (Homebrew) https://github.com/Homebrew/homebrew-core/blob/master/Formula/libvirt.rb * OpenSUSE https://build.opensuse.org/package/view_file/openSUSE:Leap:15.0:Update/libv… * Ubuntu https://git.launchpad.net/ubuntu/+source/libvirt/tree/debian/rules?h=ubuntu… * Upstream https://libvirt.org/git/?p=libvirt.git;a=blob;f=libvirt.spec.in;h=b7a35a0fb… m4/virt-driver-qemu.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/m4/virt-driver-qemu.m4 b/m4/virt-driver-qemu.m4 index cb05c34265..2a1b86e891 100644 --- a/m4/virt-driver-qemu.m4 +++ b/m4/virt-driver-qemu.m4 @@ -44,8 +44,8 @@ AC_DEFUN([LIBVIRT_DRIVER_CHECK_QEMU], [ default_qemu_user=root default_qemu_group=wheel else - default_qemu_user=root - default_qemu_group=root + default_qemu_user=qemu + default_qemu_group=qemu fi if test "x$with_qemu_user" = "xplatform dependent" ; then -- 2.20.1

3 8

[libvirt] [PATCH] virQEMUDriverPtr parameters clean up in function qemuExtTPMStart() in /src/qemu/qemu_tpm.c
by Humaid 26 Mar '19

26 Mar '19

--- src/qemu/qemu_tpm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_tpm.c b/src/qemu/qemu_tpm.c index 835a9caf46..b60e443f14 100644 --- a/src/qemu/qemu_tpm.c +++ b/src/qemu/qemu_tpm.c @@ -834,16 +834,16 @@ qemuExtTPMStartEmulator(virQEMUDriverPtr driver, int -qemuExtTPMStart(virQEMUDriverPtr driver, - virDomainObjPtr vm, +qemuExtTPMStart(virDomainObjPtr vm, qemuDomainLogContextPtr logCtxt) { int ret = 0; + qemuDomainObjPrivatePtr priv = vm->privateData; virDomainTPMDefPtr tpm = vm->def->tpm; switch (tpm->type) { case VIR_DOMAIN_TPM_TYPE_EMULATOR: - ret = qemuExtTPMStartEmulator(driver, vm, logCtxt); + ret = qemuExtTPMStartEmulator(priv->driver, vm, logCtxt); break; case VIR_DOMAIN_TPM_TYPE_PASSTHROUGH: case VIR_DOMAIN_TPM_TYPE_LAST: -- 2.17.1

6 8

[libvirt] [PATCH 0/2] qemu: Assume presence of 'set_password' and 'expire_password'
by Peter Krempa 26 Mar '19

26 Mar '19

Remove some dead code. Peter Krempa (2): qemu: Assume that 'set_password' and 'expire_password' are supported qemu: monitor: Remove unused qemuMonitor(JSON)SetVNCPassword src/qemu/qemu_hotplug.c | 20 ------------------- src/qemu/qemu_monitor.c | 16 ---------------- src/qemu/qemu_monitor.h | 2 -- src/qemu/qemu_monitor_json.c | 37 ------------------------------------ src/qemu/qemu_monitor_json.h | 2 -- tests/qemumonitorjsontest.c | 2 -- 6 files changed, 79 deletions(-) -- 2.20.1

3 5

[libvirt] [jenkins-ci PATCH] Stop building osinfo-db on CentOS 7
by Fabiano Fidêncio 26 Mar '19

26 Mar '19

osinfo-db tests are Python3 only. Signed-off-by: Fabiano Fidêncio <fidencio(a)redhat.com> --- jenkins/projects/osinfo-db.yaml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/jenkins/projects/osinfo-db.yaml b/jenkins/projects/osinfo-db.yaml index 87b6748..25a6621 100644 --- a/jenkins/projects/osinfo-db.yaml +++ b/jenkins/projects/osinfo-db.yaml @@ -1,7 +1,16 @@ --- - project: name: osinfo-db - machines: '{all_machines}' + # osinfo-db tests are Python 3 only, so they can't be built on + # CentOS 7; + machines: + - libvirt-debian-8 + - libvirt-debian-9 + - libvirt-fedora-28 + - libvirt-fedora-29 + - libvirt-fedora-rawhide + - libvirt-freebsd-11 + - libvirt-freebsd-12 title: osinfo database archive_format: xz git_url: '{git_urls[osinfo-db][default]}' -- 2.20.1

2 1

[libvirt] [jenkins-ci PATCH] guests: Update test dependencies for osinfo-db
by Fabiano Fidêncio 26 Mar '19

26 Mar '19

The new dependencies are: - python3 - python3-libxml2 - python3-pytest - python3-requests xmllint has been removed in favour of a own crafted test using python3-libmlx2 Signed-off-by: Fabiano Fidêncio <fidencio(a)redhat.com> --- guests/vars/projects/osinfo-db.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/guests/vars/projects/osinfo-db.yml b/guests/vars/projects/osinfo-db.yml index d9320a4..2c8a333 100644 --- a/guests/vars/projects/osinfo-db.yml +++ b/guests/vars/projects/osinfo-db.yml @@ -1,4 +1,7 @@ --- packages: - intltool - - xmllint + - python3 + - python3-libxml2 + - python3-pytest + - python3-requests -- 2.20.1

2 1

[libvirt] [PATCH] qemufirmwaretest: Produce better message on error
by Michal Privoznik 26 Mar '19

26 Mar '19

If qemuFirmwareFetchConfigs() returned more or less paths than expected all that we see is the following error message: Expected 5 paths, got 7 While it is technically correct (the best kind of correct), we can do better: Unexpected path (i=0). Expected /some/path got /some/other/path Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tests/qemufirmwaretest.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/tests/qemufirmwaretest.c b/tests/qemufirmwaretest.c index 340344ebba..2b5cbf649b 100644 --- a/tests/qemufirmwaretest.c +++ b/tests/qemufirmwaretest.c @@ -66,6 +66,7 @@ testFWPrecedence(const void *opaque ATTRIBUTE_UNUSED) PREFIX "/share/qemu/firmware/61-ovmf.json", PREFIX "/share/qemu/firmware/70-aavmf.json", }; + const size_t nexpected = ARRAY_CARDINALITY(expected); if (VIR_STRDUP(fakehome, abs_srcdir "/qemufirmwaredata/home/user/.config") < 0) return -1; @@ -81,17 +82,15 @@ testFWPrecedence(const void *opaque ATTRIBUTE_UNUSED) } nfwList = virStringListLength((const char **)fwList); - if (nfwList != ARRAY_CARDINALITY(expected)) { - fprintf(stderr, "Expected %zu paths, got %zu\n", - ARRAY_CARDINALITY(expected), nfwList); - return -1; - } - for (i = 0; i < ARRAY_CARDINALITY(expected); i++) { - if (STRNEQ_NULLABLE(expected[i], fwList[i])) { + for (i = 0; i < MAX(nfwList, nexpected); i++) { + const char *e = i < nexpected ? expected[i] : NULL; + const char *f = i < nfwList ? fwList[i] : NULL; + + if (STRNEQ_NULLABLE(e, f)) { fprintf(stderr, "Unexpected path (i=%zu). Expected %s got %s \n", - i, expected[i], NULLSTR(fwList[i])); + i, NULLSTR(e), NULLSTR(f)); return -1; } } -- 2.19.2

2 1

[libvirt] [PATCH v2] news: Document kernel requirements for virtual networks
by Michal Privoznik 25 Mar '19

25 Mar '19

After 7431b3eb9a05068e4b libvirt requires "filter", "nat" and "mangle" tables to exist for both IPv4 and IPv6. This fact was missed in the news.xml and since we don't have any better place to advertise that let's update old news. This was refined in 686803a1a2e and since that is not released yet create a new entry documenting the refinement. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Even though the v1 was ACKed, I'm sending v2 because things have changed since then. The difference to v1 then is that I've introduced a new news entry for the current release mentioning the refinement. IMO this reflects the reality the best: 5.1.0, which is released and doesn't contain the fix does require all 6 tables (even though Dan created v5.1.0-maint branch where he backported the fix). docs/news.xml | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/docs/news.xml b/docs/news.xml index 5c3028e10b..83e965e0f3 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -124,6 +124,18 @@ Report class information for PCI node device capability. </summary> </change> + <change> + <summary> + Split setup of IPv4 and IPv6 top level chain + </summary> + <description> + The requirement resulting from private chains improvement done + in <code>v5.1.0</code> was refined so that only tables from + corresponding IP version are required. This means that if a + network doesn't have <code>IPv6</code> enabled then those + tables are not required. + </description> + </change> </section> <section title="Bug fixes"> </section> @@ -202,7 +214,9 @@ Historically firewall rules for virtual networks were added straight into the base chains. This works but has a number of bugs and design limitations. To address them, libvirt now puts - firewall rules into its own chains. + firewall rules into its own chains. Note that with this change the + <code>filter</code>, <code>nat</code> and <code>mangle</code> tables + are required for both <code>IPv4</code> and <code>IPv6</code>. </description> </change> <change> -- 2.19.2

2 1

[libvirt] [PATCH] news: Document kernel requirements for virtual networks
by Michal Privoznik 25 Mar '19

25 Mar '19

After 7431b3eb9a05068e4b libvirt requires "filter", "nat" and "mangle" tables to exist for both IPv4 and IPv6. This fact was missed in the news.xml and since we don't have any better place to advertise that let's update old news. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- docs/news.xml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/news.xml b/docs/news.xml index 81466c3d55..8321ed8c43 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -146,7 +146,9 @@ Historically firewall rules for virtual networks were added straight into the base chains. This works but has a number of bugs and design limitations. To address them, libvirt now puts - firewall rules into its own chains. + firewall rules into its own chains. Note that with this change the + <code>filter</code>, <code>nat</code> and <code>mangle</code> tables + are required for both <code>IPv4</code> and <code>IPv6</code>. </description> </change> <change> -- 2.19.2

4 3

[libvirt] [PATCH v3 0/1] domain_conf: check device address before attach
by Daniel Henrique Barboza 25 Mar '19

25 Mar '19

v3: - changed to a simpler and more generic approach - v2 can be found here: https://www.redhat.com/archives/libvir-list/2019-January/msg00673.html Daniel Henrique Barboza (1): domain_conf: check device address before attach src/conf/domain_conf.c | 8 ++++++++ 1 file changed, 8 insertions(+) -- 2.20.1

2 2

[libvirt] [PATCH libvirt-python v2] Implement virDomainGetStateParams API
by Bjoern Walk 25 Mar '19

25 Mar '19

From: Marc Hartmayer <mhartmay(a)linux.ibm.com> This patch adds the Python binding for the virDomainGetStateParams API. The Python side can be generated automatically, the C side cannot. Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com> Signed-off-by: Marc Hartmayer <mhartmay(a)linux.ibm.com> Signed-off-by: Bjoern Walk <bwalk(a)linux.ibm.com> --- Patch series for libvirt is here: https://www.redhat.com/archives/libvir-list/2019-March/msg01648.html generator.py | 1 + libvirt-override-api.xml | 6 +++++ libvirt-override.c | 48 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 55 insertions(+) diff --git a/generator.py b/generator.py index ffa3ce56..005be502 100755 --- a/generator.py +++ b/generator.py @@ -496,6 +496,7 @@ skip_impl = ( 'virConnectBaselineHypervisorCPU', 'virDomainGetLaunchSecurityInfo', 'virNodeGetSEVInfo', + 'virDomainGetStateParams', ) lxc_skip_impl = ( diff --git a/libvirt-override-api.xml b/libvirt-override-api.xml index 7f578e01..fab62447 100644 --- a/libvirt-override-api.xml +++ b/libvirt-override-api.xml @@ -754,5 +754,11 @@ <arg name='conn' type='virConnectPtr' info='pointer to hypervisor connection'/> <arg name='flags' type='int' info='unused, always pass 0'/> </function> + <function name='virDomainGetStateParams' file='python'> + <info>Extract domain state and additional information (if available).</info> + <arg name='dom' type='virDomainPtr' info='pointer to the domain'/> + <arg name='flags' type='unsigned int' info='extra flags; not used yet, so callers should always pass 0'/> + <return type='char *' info="dictionary of state data"/> + </function> </symbols> </api> diff --git a/libvirt-override.c b/libvirt-override.c index c5e2908c..7ae10874 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -9946,6 +9946,51 @@ libvirt_virNodeGetSEVInfo(PyObject *self ATTRIBUTE_UNUSED, #endif /* LIBVIR_CHECK_VERSION(4, 5, 0) */ +#if LIBVIR_CHECK_VERSION(5, 2, 0) +static PyObject * +libvirt_virDomainGetStateParams(PyObject *self ATTRIBUTE_UNUSED, + PyObject *args) +{ + PyObject *py_retval = VIR_PY_NONE; + PyObject *pyobj_domain; + virDomainPtr domain; + int state; + int reason; + virTypedParameterPtr params = NULL; + int nparams = 0; + unsigned int flags; + int c_retval; + + if (!PyArg_ParseTuple(args, (char *)"OI:virDomainGetStateParams", + &pyobj_domain, &flags)) + return NULL; + domain = (virDomainPtr) PyvirDomain_Get(pyobj_domain); + + LIBVIRT_BEGIN_ALLOW_THREADS; + c_retval = virDomainGetStateParams(domain, &state, &reason, &params, + &nparams, flags); + LIBVIRT_END_ALLOW_THREADS; + + if (c_retval < 0) + goto error; + + if ((py_retval = PyTuple_New(3)) == NULL) + goto error; + + VIR_PY_TUPLE_SET_GOTO(py_retval, 0, libvirt_intWrap(state), error); + VIR_PY_TUPLE_SET_GOTO(py_retval, 1, libvirt_intWrap(reason), error); + VIR_PY_TUPLE_SET_GOTO(py_retval, 2, getPyVirTypedParameter(params, nparams), error); + + return py_retval; + +error: + Py_XDECREF(py_retval); + virTypedParamsFree(params, nparams); + return VIR_PY_NONE; +} +#endif /* LIBVIR_CHECK_VERSION(5, 2, 0) */ + + /************************************************************************ * * * The registration stuff * @@ -10192,6 +10237,9 @@ static PyMethodDef libvirtMethods[] = { {(char *) "virDomainGetLaunchSecurityInfo", libvirt_virDomainGetLaunchSecurityInfo, METH_VARARGS, NULL}, {(char *) "virNodeGetSEVInfo", libvirt_virNodeGetSEVInfo, METH_VARARGS, NULL}, #endif /* LIBVIR_CHECK_VERSION(4, 5, 0) */ +#if LIBVIR_CHECK_VERSION(5, 2, 0) + {(char *) "virDomainGetStateParams", libvirt_virDomainGetStateParams, METH_VARARGS, NULL}, +#endif /* LIBVIR_CHECK_VERSION(5, 2, 0) */ {NULL, NULL, 0, NULL} }; -- 2.17.0

1 0

[libvirt] [PATCH] test: Avoid use-after-free on virDomainSnapshotDelete
by Eric Blake 22 Mar '19

22 Mar '19

The following virsh command was triggering a use-after-free: $ virsh -c test:///default ' snapshot-create-as test s1 snapshot-create-as test s2 snapshot-delete --children-only test s1 snapshot-current --name test' Domain snapshot s1 created Domain snapshot s2 created Domain snapshot s1 children deleted error: name in virGetDomainSnapshot must not be NULL I got lucky on that run - although the error message is quite unexpected. On other runs, I was able to get a core dump, and valgrind confirms there is a definitive problem. The culprit? We were inconsistent about whether we set vm->current_snapshot, snap->def->current, or both when updating how the current snapshot was being tracked. As a result, deletion did not see that snapshot s2 was previously current, and failed to update vm->current_snapshot, so that the next API using the current snapshot failed because it referenced stale memory for the now-gone s2 (instead of the intended s1). The test driver code was copied from the qemu code (which DOES track both pieces of state everywhere), but was purposefully simplified because the test driver does not have to write persistent snapshot state to the file system. But when you realize that the only reason snap->def->current needs to exist is when writing out one file per snapshot for qemu, it's just as easy to state that the test driver never has to mess with the field (rather than chasing down which places forgot to set the field), and have vm->current_snapshot be the sole source of truth in the test driver. Ideally, I'd get rid of the 'current' member in virDomainSnapshotDef, as well as the 'current_snapshot' member in virDomainDef, and instead track the current member in virDomainSnapshotObjList, coupled with writing ALL snapshot state for qemu in a single file (where I can use <snapshots current='...'> as a wrapper, rather than VIR_DOMAIN_SNAPSHOT_FORMAT_INTERNAL to output <current>1</current> XML on a per-snapshot file basis). But that's a bigger change, so for now I'm just patching things to avoid the test driver segfault. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- src/test/test_driver.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 0bb48b4364..8e2a9dcff6 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -1,7 +1,7 @@ /* * test_driver.c: A "mock" hypervisor for use by application unit tests * - * Copyright (C) 2006-2015 Red Hat, Inc. + * Copyright (C) 2006-2019 Red Hat, Inc. * Copyright (C) 2006 Daniel P. Berrange * * This library is free software; you can redistribute it and/or @@ -6441,7 +6441,7 @@ testDomainSnapshotDiscardAll(void *payload, virDomainSnapshotObjPtr snap = payload; testSnapRemoveDataPtr curr = data; - if (snap->def->current) + if (curr->vm->current_snapshot == snap) curr->current = true; virDomainSnapshotObjListRemove(curr->vm->snapshots, snap); return 0; @@ -6508,8 +6508,6 @@ testDomainSnapshotDelete(virDomainSnapshotPtr snapshot, testDomainSnapshotDiscardAll, &rem); if (rem.current) { - if (flags & VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN_ONLY) - snap->def->current = true; vm->current_snapshot = snap; } } else if (snap->nchildren) { @@ -6542,8 +6540,6 @@ testDomainSnapshotDelete(virDomainSnapshotPtr snapshot, if (!parentsnap) { VIR_WARN("missing parent snapshot matching name '%s'", snap->def->parent); - } else { - parentsnap->def->current = true; } } vm->current_snapshot = parentsnap; @@ -6623,12 +6619,9 @@ testDomainRevertToSnapshot(virDomainSnapshotPtr snapshot, } - if (vm->current_snapshot) { - vm->current_snapshot->def->current = false; + if (vm->current_snapshot) vm->current_snapshot = NULL; - } - snap->def->current = true; config = virDomainDefCopy(snap->def->dom, privconn->caps, privconn->xmlopt, NULL, true); if (!config) -- 2.20.1

3 4

[libvirt] [PATCH 0/2] tests: qemuxml2argv updates and tweaks
by Andrea Bolognani 22 Mar '19

22 Mar '19

Andrea Bolognani (2): tests: Update aarch64-virt-graphics for virtio-blk tests: Add s390x-ccw-graphics test case .../aarch64-virt-graphics.aarch64-latest.args | 9 ++-- .../aarch64-virt-graphics.xml | 3 +- .../s390x-ccw-graphics.s390x-latest.args | 49 +++++++++++++++++++ ...rt-graphics.xml => s390x-ccw-graphics.xml} | 21 +++----- tests/qemuxml2argvtest.c | 1 + 5 files changed, 62 insertions(+), 21 deletions(-) create mode 100644 tests/qemuxml2argvdata/s390x-ccw-graphics.s390x-latest.args copy tests/qemuxml2argvdata/{aarch64-virt-graphics.xml => s390x-ccw-graphics.xml} (61%) -- 2.20.1

2 3

[libvirt] [PATCH 00/21] qemu_hotplug: refactor device detach functions to fix one serious and other minor bugs
by Laine Stump 22 Mar '19

22 Mar '19

This all started with the observation that we were sending the DEVICE_REMOVED events for unplugged devices too soon (reported in https://bugzilla.redhat.com/1658198 ). While noticing that *all* of the device types send their DEVICE_REMOVED event too early, I also noticed how eerily similar all the different detach functions are (they have converged over time, as legacy code supporting old qemus with different methods of deleting different types of devices has been removed - pkrempa and mprivozn committed patches just in the last week that contributed to this convergence and removed some duplicated code). I also saw a few other definite bugs, as well as a couple that I think are bugs, but am not enough informed about zPCI to be certain (I've Cc'ed the author and reviewers of the original patch adding that code to the patches so that they can verify, or negate, my suspicions). Many/most of these patches are either very simple / easily verifiable code movement / removal / renaming of variables. Patch 20 is a bit more involved; viewing the new versions of the functions along with the patch would probably help it go much quicker. The first two patches in the series eliminate what I'm 99% certain is erroneous calling of the qemuDomainDetachExtensionDevice() when detaching a PCI device on S390. The commit log details my reasons for believing this code should be removed. The rest of the series eliminates small differences iteratively, arriving at a set of detach functions which are completely identical at the end (and only called from one place), and then replaces all those duplicates with a single block of common code in a higher level function that calls all of the individual functions (it was their only caller anyway). This eliminated the inconsistent application of checking for multifunction PCI devices and for the existence of a device alias. It also eliminated individual calls to qemuDomainRemove*Device() calls, and replaced them with a single call to qemuDomainRemoveDevice(). Eliminating all the calls (except one) to the individual qemuDomainRemove*Device() functions in turn made it possible to move the code that builds and queues the DEVICE_REMOVED event into a single place in the one remaining higher level caller - qemuDomainRemoveDevice() - thus eliminating the "premature event" for *all* device types at once. Laine Stump (21): qemu_hotplug: remove erroneous call to qemuDomainDetachExtensionDevice() qemu_hotplug: remove another erroneous qemuDomainDetachExtensionDevice() call qemu_hotplug: remove unnecessary check for valid PCI address qemu_hotplug: rename a virDomainDeviceInfoPtr to avoid confusion qemu_hotplug: eliminate multiple identical qemuDomainDetachHost*Device() functions qemu_hotplug: eliminate unnecessary call to qemuDomainDetachNetDevice() qemu_hotplug: refactor qemuDomainDetachDiskLive and qemuDomainDetachDiskDevice qemu_hotplug: don't call DetachThisHostDevice for hostdev network devices qemu_hotplug: merge qemuDomainDetachThisHostDevice into qemuDomainDetachHostDevice qemu_hotplug: move qemuDomainChangeGraphicsPasswords() qemu_hotplug: move (almost) all qemuDomainDetach*() functions together qemu_hotplug: move (Attach|Detach)Lease functions with others of same type qemu_hotplug: move qemuDomainDetachDeviceLive() to qemu_hotplug.c qemu_hotplug: remove extra function in middle of DetachController call chain qemu_hotplug: pull qemuDomainUpdateDeviceList out of qemuDomainDetachDeviceLive test: replace calls to individual detach functions with one call to main detach qemu_hotplug: rename dev to match in qemuDomainDetachDeviceLive qemu_hotplug: standardize the names/args/calling of qemuDomainDetach*() qemu_hotplug: new function qemuDomainRemoveAuditDevice() qemu_hotplug: consolidate all common detach code in qemuDomainDetachDeviceLive qemu_hotplug: delay sending DEVICE_REMOVED event until after *all* teardown src/qemu/qemu_driver.c | 102 +-- src/qemu/qemu_hotplug.c | 1407 ++++++++++++++++++--------------------- src/qemu/qemu_hotplug.h | 56 +- tests/qemuhotplugtest.c | 8 +- 4 files changed, 655 insertions(+), 918 deletions(-) Yay! jtomko would be proud - more deletions than insertions!!! -- 2.20.1

4 63

[libvirt] Bite sized task: #pragma once
by Daniel P. Berrangé 22 Mar '19

22 Mar '19

A heads up that I added a trivial bite sized task to convert header files to use #pragma once https://wiki.libvirt.org/page/BiteSizedTasks#Switch_headers_to_use_.23pragm… Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|

1 0

[libvirt] [PATCH] virDomainMomentAssignDef: Don't dereference a NULL pointer
by Michal Privoznik 22 Mar '19

22 Mar '19

This functions tries to add a domain moment (love the name!) onto a list of domain moments. Firstly, it checks if another moment with the same name already exists. Then, it creates an empty moment (without initializing its definition) and tries to add the moment onto the list dereferencing moment definition in that process. If it succeeds (which it never can), only after that it sets moment->def. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/conf/virdomainmomentobjlist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/virdomainmomentobjlist.c b/src/conf/virdomainmomentobjlist.c index b2122e7292..01e50ae1d4 100644 --- a/src/conf/virdomainmomentobjlist.c +++ b/src/conf/virdomainmomentobjlist.c @@ -227,7 +227,7 @@ virDomainMomentAssignDef(virDomainMomentObjListPtr moments, if (!(moment = virDomainMomentObjNew())) return NULL; - if (virHashAddEntry(moments->objs, moment->def->name, moment) < 0) { + if (virHashAddEntry(moments->objs, def->name, moment) < 0) { VIR_FREE(moment); return NULL; } -- 2.19.2

3 2

[libvirt] [PATCH] nwfilter: fix adding std MAC and IP values to filter binding
by Nikolay Shirokovskiy 22 Mar '19

22 Mar '19

Commit d1a7c08eb changed filter instantiation code to ignore MAC and IP variables explicitly specified for filter binding. It just replaces explicit values with values associated with the binding. Before the commit virNWFilterCreateVarsFrom was used so that explicit value take precedence. Let's bring old behavior back. This is useful. For example if domain has two interfaces it makes sense to list both mac adresses in MAC var of every interface filterref. So that if guest make a bond of these interfaces and start sending frames with one of the mac adresses from both interfaces we can pass outgress traffic from both interfaces too. Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> --- src/nwfilter/nwfilter_gentech_driver.c | 92 ++++++++++++---------------------- 1 file changed, 32 insertions(+), 60 deletions(-) diff --git a/src/nwfilter/nwfilter_gentech_driver.c b/src/nwfilter/nwfilter_gentech_driver.c index 655f088..6d68189 100644 --- a/src/nwfilter/nwfilter_gentech_driver.c +++ b/src/nwfilter/nwfilter_gentech_driver.c @@ -127,60 +127,6 @@ virNWFilterRuleInstFree(virNWFilterRuleInstPtr inst) /** - * virNWFilterVarHashmapAddStdValues: - * @tables: pointer to hash tabel to add values to - * @macaddr: The string of the MAC address to add to the hash table, - * may be NULL - * @ipaddr: The string of the IP address to add to the hash table; - * may be NULL - * - * Returns 0 in case of success, -1 in case an error happened with - * error having been reported. - * - * Adds a couple of standard keys (MAC, IP) to the hash table. - */ -static int -virNWFilterVarHashmapAddStdValues(virHashTablePtr table, - const char *macaddr, - const virNWFilterVarValue *ipaddr) -{ - virNWFilterVarValue *val; - - if (macaddr) { - val = virNWFilterVarValueCreateSimpleCopyValue(macaddr); - if (!val) - return -1; - - if (virHashUpdateEntry(table, - NWFILTER_STD_VAR_MAC, - val) < 0) { - virNWFilterVarValueFree(val); - virReportError(VIR_ERR_INTERNAL_ERROR, - "%s", _("Could not add variable 'MAC' to hashmap")); - return -1; - } - } - - if (ipaddr) { - val = virNWFilterVarValueCopy(ipaddr); - if (!val) - return -1; - - if (virHashUpdateEntry(table, - NWFILTER_STD_VAR_IP, - val) < 0) { - virNWFilterVarValueFree(val); - virReportError(VIR_ERR_INTERNAL_ERROR, - "%s", _("Could not add variable 'IP' to hashmap")); - return -1; - } - } - - return 0; -} - - -/** * Convert a virHashTable into a string of comma-separated * variable names. */ @@ -705,6 +651,28 @@ virNWFilterDoInstantiate(virNWFilterTechDriverPtr techdriver, } +static int +virNWFilterVarHashmapAddStdValue(virHashTablePtr table, + const char *var, + const char *value) +{ + virNWFilterVarValue *val; + + if (virHashLookup(table, var)) + return 0; + + if (!(val = virNWFilterVarValueCreateSimpleCopyValue(value))) + return -1; + + if (virHashAddEntry(table, var, val) < 0) { + virNWFilterVarValueFree(val); + return -1; + } + + return 0; +} + + /* * Call this function while holding the NWFilter filter update lock */ @@ -717,7 +685,7 @@ virNWFilterInstantiateFilterUpdate(virNWFilterDriverStatePtr driver, bool forceWithPendingReq, bool *foundNewFilter) { - int rc; + int rc = -1; const char *drvname = EBIPTABLES_DRIVER_ID; virNWFilterTechDriverPtr techdriver; virNWFilterObjPtr obj; @@ -743,14 +711,18 @@ virNWFilterInstantiateFilterUpdate(virNWFilterDriverStatePtr driver, return -1; virMacAddrFormat(&binding->mac, vmmacaddr); + if (virNWFilterVarHashmapAddStdValue(binding->filterparams, + NWFILTER_STD_VAR_MAC, + vmmacaddr) < 0) + goto err_exit; ipaddr = virNWFilterIPAddrMapGetIPAddr(binding->portdevname); - - if (virNWFilterVarHashmapAddStdValues(binding->filterparams, - vmmacaddr, ipaddr) < 0) { - rc = -1; + if (ipaddr && + virNWFilterVarHashmapAddStdValue(binding->filterparams, + NWFILTER_STD_VAR_IP, + virNWFilterVarValueGetSimple(ipaddr)) < 0) goto err_exit; - } + filter = virNWFilterObjGetDef(obj); -- 1.8.3.1

2 4

[libvirt] [PATCH] xml: nodedev: make pci capability class element optional
by Nikolay Shirokovskiy 22 Mar '19

22 Mar '19

Commit 3bd4ed46 introduced this element as required which breaks backcompat for test driver. Let's make the element optional. Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> --- docs/formatnode.html.in | 2 +- docs/schemas/nodedev.rng | 12 ++++++----- src/conf/node_device_conf.c | 23 +++++++++++----------- src/conf/node_device_conf.h | 2 +- src/node_device/node_device_udev.c | 2 +- .../pci_0000_02_10_7_sriov_pf_vfs_all.xml | 1 - 6 files changed, 22 insertions(+), 20 deletions(-) diff --git a/docs/formatnode.html.in b/docs/formatnode.html.in index 5095b97..c2a8f8f 100644 --- a/docs/formatnode.html.in +++ b/docs/formatnode.html.in @@ -71,7 +71,7 @@ include: <dl> <dt><code>class</code></dt> - <dd>Combined class, subclass and + <dd>Optional element for combined class, subclass and programming interface codes as 6-digit hexadecimal number. <span class="since">Since 5.2.0</span></dd> <dt><code>domain</code></dt> diff --git a/docs/schemas/nodedev.rng b/docs/schemas/nodedev.rng index 0f45d79..fe6ffa0 100644 --- a/docs/schemas/nodedev.rng +++ b/docs/schemas/nodedev.rng @@ -133,11 +133,13 @@ <value>pci</value> </attribute> - <element name='class'> - <data type="string"> - <param name="pattern">0x[0-9a-fA-F]{6}</param> - </data> - </element> + <optional> + <element name='class'> + <data type="string"> + <param name="pattern">0x[0-9a-fA-F]{6}</param> + </data> + </element> + </optional> <element name='domain'> <ref name='unsignedLong'/> </element> diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index 19c601a..b96d10c 100644 --- a/src/conf/node_device_conf.c +++ b/src/conf/node_device_conf.c @@ -208,7 +208,8 @@ virNodeDeviceCapPCIDefFormat(virBufferPtr buf, { size_t i; - virBufferAsprintf(buf, "<class>0x%.6x</class>\n", data->pci_dev.klass); + if (data->pci_dev.klass >= 0) + virBufferAsprintf(buf, "<class>0x%.6x</class>\n", data->pci_dev.klass); virBufferAsprintf(buf, "<domain>%d</domain>\n", data->pci_dev.domain); virBufferAsprintf(buf, "<bus>%d</bus>\n", data->pci_dev.bus); @@ -1645,16 +1646,16 @@ virNodeDevCapPCIDevParseXML(xmlXPathContextPtr ctxt, orignode = ctxt->node; ctxt->node = node; - if (virNodeDevCapsDefParseHexId("string(./class[1])", ctxt, - &pci_dev->klass, def, - _("no PCI class supplied for '%s'"), - _("invalid PCI class supplied for '%s'")) < 0) - goto out; - - if (pci_dev->klass > 0xffffff) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("invalid PCI class supplied for '%s'"), def->name); - goto out; + if ((tmp = virXPathString("string(./class[1])", ctxt))) { + if (virStrToLong_i(tmp, NULL, 16, &pci_dev->klass) < 0 || + pci_dev->klass > 0xffffff) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("invalid PCI class supplied for '%s'"), def->name); + goto out; + } + VIR_FREE(tmp); + } else { + pci_dev->klass = -1; } if (virNodeDevCapsDefParseULong("number(./domain[1])", ctxt, diff --git a/src/conf/node_device_conf.h b/src/conf/node_device_conf.h index b13bc13..e8cb315 100644 --- a/src/conf/node_device_conf.h +++ b/src/conf/node_device_conf.h @@ -153,7 +153,7 @@ struct _virNodeDevCapPCIDev { unsigned int function; unsigned int product; unsigned int vendor; - unsigned int klass; + int klass; char *product_name; char *vendor_name; virPCIDeviceAddressPtr physical_function; diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c index f0e61e4..5ed3463 100644 --- a/src/node_device/node_device_udev.c +++ b/src/node_device/node_device_udev.c @@ -402,7 +402,7 @@ udevProcessPCI(struct udev_device *device, privileged = driver->privileged; nodeDeviceUnlock(); - if (udevGetUintProperty(device, "PCI_CLASS", &pci_dev->klass, 16) < 0) + if (udevGetIntProperty(device, "PCI_CLASS", &pci_dev->klass, 16) < 0) goto cleanup; if ((p = strrchr(def->sysfs_path, '/')) == NULL || diff --git a/tests/nodedevschemadata/pci_0000_02_10_7_sriov_pf_vfs_all.xml b/tests/nodedevschemadata/pci_0000_02_10_7_sriov_pf_vfs_all.xml index 74036a6..9e8dace 100644 --- a/tests/nodedevschemadata/pci_0000_02_10_7_sriov_pf_vfs_all.xml +++ b/tests/nodedevschemadata/pci_0000_02_10_7_sriov_pf_vfs_all.xml @@ -2,7 +2,6 @@ <name>pci_0000_02_10_7</name> <parent>pci_0000_00_04_0</parent> <capability type='pci'> - <class>0xffffff</class> <domain>0</domain> <bus>2</bus> <slot>16</slot> -- 1.8.3.1

2 6

[libvirt] [PATCH v2 0/4] tests: qemuxml2argv: support optional arguments
by Cole Robinson 22 Mar '19

22 Mar '19

Small/completion follow up to v1 here, which is mostly pushed: https://www.redhat.com/archives/libvir-list/2019-March/msg00943.html Patch 1 and 3 are new additions based on Andrea's reviews. Rest of the review comments should be addressed Cole Robinson (4): tests: qemuxml2argv: Tweak TEST_CAPS_PATH tests: qemuxml2argv: move DO_CAPS_TEST* qemuCaps init tests: qemuxml2argv: report error on ARG_* collisions tests: qemuxml2argv: add DO_TEST_INTERNAL tests/qemuxml2argvtest.c | 102 +++++++++++++++++++++++++-------------- 1 file changed, 66 insertions(+), 36 deletions(-) -- 2.21.0

2 8

[libvirt] [PATCH 00/21] tests: qemuxml2argv: support optional arguments
by Cole Robinson 21 Mar '19

21 Mar '19

Right now in qemuxml2argv we have a proliferation of DO_*TEST* macros. They essentially fill in data in the testInfo struct and invoke the test function. There's several bits of data that we want to specify for a small subset of tests: flags, parseFlags, migrateFrom/migrateFd, gic. The base macros need to handle these in their argument lists, and we provide many convenience macros that fill in default values for the less common parameters. Any time we want to add a new bit of data though, the base macros are extended, and every caller of those needs to be adjusted, and we are faced with the question of whether to extend the combinatorial explosion of convenience macros which have only a subset of options exposed. This series adds a testInfoSetArgs which uses va_args to make these mandatory parameters optional. The general format is: DO_TEST_FULL(... ARG_FOO, foovalue, ARG_BAR, barvalue, ...) Specifically, one of the migrate tests went from: DO_TEST_FULL("restore-v2", "exec:cat", 7, 0, 0, GIC_NONE, NONE); to: DO_TEST_FULL("restore-v2", ARG_MIGRATE_FROM, "exec:cat", ARG_MIGRATE_FD, 7, ARG_QEMU_CAPS, NONE); Which may not seem directly compelling, but adding new testInfo fields will be much easier. This will also be a base for a later series to share the VIR_TEST_CAPS infrastructure with qemuxml2xmltest Cole Robinson (21): qemu: add virQEMUCapsSetVList tests: qemuxml2argv: add testInfoSetArgs tests: qemuxml2argv: add va_arg enum handling tests: qemuxml2argv: push ARG_QEMU_CAPS to callers tests: qemuxml2argv: break apart testInitQEMUCaps tests: qemuxml2argv: handle gic with vaargs tests: qemuxml2argv: handle migrate* with varargs tests: qemuxml2argv: handle flags with varargs tests: qemuxml2argv: handle parseFlags with varargs tests: qemuxml2argv: remove DO_TEST_PARSE_FLAGS_ERROR tests: qemuxml2argv: remove unused DO_TEST_CAPS* macros tests: qemuxml2argv: add a comment separating DO_TEST* macros tests: qemuxml2argv: remove unused CAPS migrateFrom tests: qemuxml2argv: use varargs for CAPS flags tests: qemuxml2argv: remove full testInfo initialization tests: qemuxml2argv: centralize CAPS suffix building tests: qemuxml2argv: build capsfile in DO_TEST_CAPS_INTERNAL tests: qemuxml2argv: add testInfoClear tests: qemuxml2argv: move DO_TEST qemuCaps init tests: qemuxml2argv: move DO_CAPS_TEST* qemuCaps init tests: qemuxml2argv: add TEST_INTERNAL src/qemu/qemu_capabilities.c | 14 +- src/qemu/qemu_capabilities.h | 2 + tests/qemuxml2argvtest.c | 273 +++++++++++++++++++++++------------ 3 files changed, 193 insertions(+), 96 deletions(-) -- 2.20.1

4 56

Re: [libvirt] [Qemu-devel] [PULL v3 00/54] Kconfig conversion, excluding ARM and MIPS
by Laszlo Ersek 21 Mar '19

21 Mar '19

Hi Paolo, (+libvir-list) I'd like to report a regression introduced by this patch set: On 03/07/19 21:58, Paolo Bonzini wrote: > The following changes since commit > 6cb4f6db4f4367faa33da85b15f75bbbd2bed2a6: > > Merge remote-tracking branch > 'remotes/cleber/tags/python-next-pull-request' into staging > (2019-03-07 16:16:02 +0000) > > are available in the Git repository at: > > git://github.com/bonzini/qemu.git tags/for-upstream-kconfig > > for you to fetch changes up to > 576c3f2f16e7392e28cc9fe10d9a920d67d3645b: > > kconfig: add documentation (2019-03-07 21:54:22 +0100) > > ---------------------------------------------------------------- > Initial Kconfig work, excluding ARM and MIPS > > ---------------------------------------------------------------- I use "libvirt-daemon-4.5.0-10.el7.x86_64" at the moment. Here are the symptoms: (1) the output of the following command changes across this series: virsh domcapabilities qemu /opt/qemu-installed-optimized/bin/qemu-system-aarch64 aarch64 virt-4.0 as shown by the diff > @@ -92,6 +92,8 @@ > <video supported='yes'> > <enum name='modelType'> > <value>vga</value> > + <value>cirrus</value> > + <value>vmvga</value> > <value>virtio</value> > </enum> > </video> > @@ -111,10 +113,7 @@ > <value>scsi</value> > </enum> > <enum name='capsType'/> > - <enum name='pciBackend'> > - <value>default</value> > - <value>vfio</value> > - </enum> > + <enum name='pciBackend'/> > </hostdev> > </devices> > <features> (2) given the following domain XML snippet, in a qemu (not KVM) aarch64 guest that I have, > <video> > <model type='virtio' heads='1' primary='yes'/> > <address type='pci' domain='0x0000' bus='0x04' slot='0x00' function='0x0'/> > </video> the QEMU command line generated by libvirt changes: > - -device virtio-gpu-pci,id=video0,max_outputs=1,bus=pci.4,addr=0x0 \ > + -device virtio-vga,id=video0,max_outputs=1,bus=pci.4,addr=0x0 \ Perhaps this series causes (1), which in turn causes (2), or else this series causes both (1) and (2) independently of each other. I'm not sure about that. Either way, (2) is a problem, because virtio-vga is inappropriate for aarch64 guests (and the ArmVirtQemu platform firmware in edk2 won't even try to drive it -- a blank screen is the result). Now, I can't pinpoint an exact commit, because (after a *brutal* bisection) I get: > There are only 'skip'ped commits left to test. > The first bad commit could be any of: > a02c0edb35662de38d400f42b68845540669ca3d > 03b348bdcbd1eda4ce097b2b84527dec774d80c4 > d6e9c470fc91f75db1785f17a9d3567d5a27953d > a7e23159074c9d774fb1e88357b778994a0c9365 > bcb129b3154ba743f8e52c21c331a0dfcaee7c38 > 02017ee385ef574133c4a978d368640772978178 > 7c28b925b7e176b4e44ed05d23cf883561000546 > 1550b0e6bfe3ab6985e5ad75df1c528a0ca39468 > e9947d18df97e6c6584f020cf9cc995404cc8061 > 8f01b41e1098d8cb9491fa3ea7bd59cf187a5bd7 > 9533dcdd416530a0d72140c122bf90517b6c81eb > 32690c8bed5762518272876dcb6dd39a54f54fd1 > c3a98aa54c734dcb7a36d193c6330d8f04d4bf8e > ccf222a816d59af1318a7efb59c6b9c5578d1abf > f349474920d80838ecea3d421531fdb0660b8740 > 2ac041c2c3d89691cda1657981c41fe4bc20244b > e0e312f3525ad6ac18ba6633af29190dd9620cbc > b42075bb77672616127c9452c0f836e757e9ce1a > We cannot bisect more! Here's how I built each step of the bisection: - "git clean -ffdx" and "git submodule deinit --all --force" on the source directory - create a new, pristine build directory - configure QEMU for out-of-tree build, in that directory - select the i386, x86_64, arm, and aarch64 targets (all softmmu) - report "skip" to git-bisect iff the build breaks, otherwise test the aarch64 emulator through libvirt, and report good/bad dependent on the test result. The bisection log is attached -- "git bisect replay" and "git bisect visualize" should tell the story better than the above dump of commit hashes. Basically: - The tree builds up to and including commit 82f5181777eb ("kconfig: introduce kconfig files", 2019-03-07), and that commit works fine as well. - Then the build breaks (starting with commit e0e312f3525a, "build: switch to Kconfig", 2019-03-07). - The tree becomes buildable again at commit b42075bb7767 ("virtio: express virtio dependencies with Kconfig", 2019-03-07), but at that point, the functionality has been regressed. Thanks, Laszlo

4 8

[libvirt] [PATCH v2] numa: warn if numa 'mem' option or default RAM splitting between nodes is used.
by Igor Mammedov 20 Mar '19

20 Mar '19

Amend -numa option docs and print warnings if 'mem' option or default RAM splitting between nodes is used. It's intended to discourage users from using configuration that allows only to fake NUMA on guest side while leading to reduced performance of the guest due to inability to properly configure VM's RAM on the host. In NUMA case, it's recommended to always explicitly configure guest RAM using -numa node,memdev={backend-id} option. Signed-off-by: Igor Mammedov <imammedo(a)redhat.com> --- numa.c | 5 +++++ qemu-options.hx | 12 ++++++++---- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/numa.c b/numa.c index 3875e1e..42838f9 100644 --- a/numa.c +++ b/numa.c @@ -121,6 +121,8 @@ static void parse_numa_node(MachineState *ms, NumaNodeOptions *node, if (node->has_mem) { numa_info[nodenr].node_mem = node->mem; + warn_report("Parameter -numa node,mem is obsolete," + " use -numa node,memdev instead"); } if (node->has_memdev) { Object *o; @@ -407,6 +409,9 @@ void numa_complete_configuration(MachineState *ms) if (i == nb_numa_nodes) { assert(mc->numa_auto_assign_ram); mc->numa_auto_assign_ram(mc, numa_info, nb_numa_nodes, ram_size); + warn_report("Default splitting of RAM between nodes is obsolete," + " Use '-numa node,memdev' to explicitly define RAM" + " allocation per node"); } numa_total = 0; diff --git a/qemu-options.hx b/qemu-options.hx index 1cf9aac..61035cb 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -206,10 +206,14 @@ For example: -numa cpu,node-id=0,socket-id=0 -numa cpu,node-id=1,socket-id=1 @end example -@samp{mem} assigns a given RAM amount to a node. @samp{memdev} -assigns RAM from a given memory backend device to a node. If -@samp{mem} and @samp{memdev} are omitted in all nodes, RAM is -split equally between them. +@samp{memdev} assigns RAM from a given memory backend device to a node. + +Legacy options/behaviour: @samp{mem} assigns a given RAM amount to a node. +If @samp{mem} and @samp{memdev} are omitted in all nodes, RAM is split equally +between them. Option @samp{mem} and default RAM splitting are obsolete as they +do not provide means to manage RAM on the host side and only allow QEMU to fake +NUMA support which in practice could degrade VM performance. +It's advised to always explicitly configure NUMA RAM by using the @samp{memdev} option. @samp{mem} and @samp{memdev} are mutually exclusive. Furthermore, if one node uses @samp{memdev}, all of them have to use it. -- 2.7.4

5 19

[libvirt] [PATCH 1/2] snapshots: allow create --redefine to force a new configuration
by Christian Ehrhardt 20 Mar '19

20 Mar '19

Currently there is no means to permanently modify the metadata stored within a snapshot if it does not pass the ABI compat checker. That is pretty much intentional but there are use cases where users verified that the change will work according to their needs and don't want to: snapshot-revert -> edit -> start, but instead store the modified domain definition within the metadata. To achive that this adds a --force argument to snapshot-create --redefine which will make it skip the check. Signed-off-by: Christian Ehrhardt <christian.ehrhardt(a)canonical.com> --- include/libvirt/libvirt-domain-snapshot.h | 3 +++ src/conf/snapshot_conf.c | 3 ++- src/qemu/qemu_driver.c | 7 ++++++- tools/virsh-snapshot.c | 6 ++++++ tools/virsh.pod | 8 +++++++- 5 files changed, 24 insertions(+), 3 deletions(-) diff --git a/include/libvirt/libvirt-domain-snapshot.h b/include/libvirt/libvirt-domain-snapshot.h index 602e5def59..dc8ba2b4a9 100644 --- a/include/libvirt/libvirt-domain-snapshot.h +++ b/include/libvirt/libvirt-domain-snapshot.h @@ -71,6 +71,9 @@ typedef enum { VIR_DOMAIN_SNAPSHOT_CREATE_LIVE = (1 << 8), /* create the snapshot while the guest is running */ + VIR_DOMAIN_SNAPSHOT_CREATE_NOCHECK = (1 << 9), /* take definition as + provided without + ABI compat check */ } virDomainSnapshotCreateFlags; /* Take a snapshot of the current VM state */ diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c index ffb1313c89..f95b104ad5 100644 --- a/src/conf/snapshot_conf.c +++ b/src/conf/snapshot_conf.c @@ -474,7 +474,8 @@ virDomainSnapshotRedefineValidate(virDomainSnapshotDefPtr def, if (other->def->dom) { if (def->dom) { - if (!virDomainDefCheckABIStability(other->def->dom, + if (!(flags & VIR_DOMAIN_SNAPSHOT_CREATE_NOCHECK) && + !virDomainDefCheckABIStability(other->def->dom, def->dom, xmlopt)) return -1; } else { diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index a16eab5467..f3d032f633 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -15680,7 +15680,8 @@ qemuDomainSnapshotCreateXML(virDomainPtr domain, VIR_DOMAIN_SNAPSHOT_CREATE_REUSE_EXT | VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE | VIR_DOMAIN_SNAPSHOT_CREATE_ATOMIC | - VIR_DOMAIN_SNAPSHOT_CREATE_LIVE, NULL); + VIR_DOMAIN_SNAPSHOT_CREATE_LIVE | + VIR_DOMAIN_SNAPSHOT_CREATE_NOCHECK, NULL); VIR_REQUIRE_FLAG_RET(VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE, VIR_DOMAIN_SNAPSHOT_CREATE_DISK_ONLY, @@ -15689,6 +15690,10 @@ qemuDomainSnapshotCreateXML(virDomainPtr domain, VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE, NULL); + VIR_REQUIRE_FLAG_RET(VIR_DOMAIN_SNAPSHOT_CREATE_NOCHECK, + VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE, + NULL); + if ((redefine && !(flags & VIR_DOMAIN_SNAPSHOT_CREATE_CURRENT)) || (flags & VIR_DOMAIN_SNAPSHOT_CREATE_NO_METADATA)) update_current = false; diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c index 6ea6e2744a..a680d2b410 100644 --- a/tools/virsh-snapshot.c +++ b/tools/virsh-snapshot.c @@ -146,6 +146,10 @@ static const vshCmdOptDef opts_snapshot_create[] = { .type = VSH_OT_BOOL, .help = N_("require atomic operation") }, + {.name = "force", + .type = VSH_OT_BOOL, + .help = N_("do not check XML for ABI compatibility") + }, VIRSH_COMMON_OPT_LIVE(N_("take a live snapshot")), {.name = NULL} }; @@ -177,6 +181,8 @@ cmdSnapshotCreate(vshControl *ctl, const vshCmd *cmd) flags |= VIR_DOMAIN_SNAPSHOT_CREATE_ATOMIC; if (vshCommandOptBool(cmd, "live")) flags |= VIR_DOMAIN_SNAPSHOT_CREATE_LIVE; + if (vshCommandOptBool(cmd, "force")) + flags |= VIR_DOMAIN_SNAPSHOT_CREATE_NOCHECK; if (!(dom = virshCommandOptDomain(ctl, cmd, NULL))) goto cleanup; diff --git a/tools/virsh.pod b/tools/virsh.pod index db72343159..a8cd15bad2 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -4570,7 +4570,7 @@ used to represent properties of snapshots. =item B<snapshot-create> I<domain> [I<xmlfile>] {[I<--redefine> [I<--current>]] | [I<--no-metadata>] [I<--halt>] [I<--disk-only>] [I<--reuse-external>] -[I<--quiesce>] [I<--atomic>] [I<--live>]} +[I<--quiesce>] [I<--atomic>] [I<--live>] [I<--force>]} Create a snapshot for domain I<domain> with the properties specified in I<xmlfile>. Normally, the only properties settable for a domain snapshot @@ -4629,6 +4629,12 @@ the guest is running. Both disk snapshot and domain memory snapshot are taken. This increases the size of the memory image of the external snapshot. This is currently supported only for full system external snapshots. +If I<--force> is specified, then the usual ABI compatibility check that +would be done on I<--redefine> will be skipped allowing to update the +domain definition stored in the snapshot metadata arbitrarily. +Note: this obviously involves extra risk, supplying I<--force> assures +libvirt that the snapshot will be compatible with the new configuration. + Existence of snapshot metadata will prevent attempts to B<undefine> a persistent domain. However, for transient domains, snapshot metadata is silently lost when the domain quits running (whether -- 2.17.1

3 7

[libvirt] [jenkins-ci] defaults.yaml: Only spam libvirt-ci@redhat.com
by Yash Mankad 20 Mar '19

20 Mar '19

The libvirt CI maintainers/contributors have agreed to update the default spam e-mail to include only the libvirt-ci mailing list and remove my e-mail from the spam list in the defaults.yaml Signed-off-by: Yash Mankad <ymankad(a)redhat.com> --- jenkins/jobs/defaults.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jenkins/jobs/defaults.yaml b/jenkins/jobs/defaults.yaml index 230eaf0..b0deb0d 100644 --- a/jenkins/jobs/defaults.yaml +++ b/jenkins/jobs/defaults.yaml @@ -71,4 +71,4 @@ default: https://github.com/virt-manager/virt-manager.git virt-viewer: default: https://pagure.io/virt-viewer.git - spam: ymankad(a)redhat.com libvirt-ci(a)redhat.com + spam: libvirt-ci(a)redhat.com -- 2.20.1

3 2

[libvirt] [PATCH] virnwfilterbindingobj: Introduce and use virNWFilterBindingObjStealDef
by Michal Privoznik 20 Mar '19

20 Mar '19

https://bugzilla.redhat.com/show_bug.cgi?id=1686927 When trying to create a nwfilter binding via nwfilterBindingCreateXML() we may encounter a crash. The sequence of functions called is as follows: 1) nwfilterBindingCreateXML() parses the XML and calls virNWFilterBindingObjListAdd() which calls virNWFilterBindingObjListAddLocked() 2) Here, @binding is not found because binding->remove is set. 3) Therefore, controls continue with creating new @binding, setting its def to the one from 1) and adding it to the hash table. 4) This fails, because the binding is still in the hash table (duplicate key is detected). 5) The control jumps to 'error' label where virNWFilterBindingObjEndAPI() is called which frees the binding definition passed. 6) Error is propagated to the caller, which calls virNWFilterBindingDefFree() over the definition again. The solution is to unset binding->def in case of failure so it's not freed in step 5). Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Technically, this is a v2 of: https://www.redhat.com/archives/libvir-list/2019-March/msg01209.html But since this one implements different approach than v1 I'm not marking it as such. src/conf/virnwfilterbindingobj.c | 10 ++++++++++ src/conf/virnwfilterbindingobj.h | 3 +++ src/conf/virnwfilterbindingobjlist.c | 4 ++++ src/libvirt_private.syms | 1 + 4 files changed, 18 insertions(+) diff --git a/src/conf/virnwfilterbindingobj.c b/src/conf/virnwfilterbindingobj.c index 23978d4207..68afb9c434 100644 --- a/src/conf/virnwfilterbindingobj.c +++ b/src/conf/virnwfilterbindingobj.c @@ -88,6 +88,16 @@ virNWFilterBindingObjSetDef(virNWFilterBindingObjPtr obj, } +virNWFilterBindingDefPtr +virNWFilterBindingObjStealDef(virNWFilterBindingObjPtr obj) +{ + virNWFilterBindingDefPtr def; + + VIR_STEAL_PTR(def, obj->def); + return def; +} + + bool virNWFilterBindingObjGetRemoving(virNWFilterBindingObjPtr obj) { diff --git a/src/conf/virnwfilterbindingobj.h b/src/conf/virnwfilterbindingobj.h index 8e5fbee35f..b26bb3c8ec 100644 --- a/src/conf/virnwfilterbindingobj.h +++ b/src/conf/virnwfilterbindingobj.h @@ -39,6 +39,9 @@ void virNWFilterBindingObjSetDef(virNWFilterBindingObjPtr obj, virNWFilterBindingDefPtr def); +virNWFilterBindingDefPtr +virNWFilterBindingObjStealDef(virNWFilterBindingObjPtr obj); + bool virNWFilterBindingObjGetRemoving(virNWFilterBindingObjPtr obj); diff --git a/src/conf/virnwfilterbindingobjlist.c b/src/conf/virnwfilterbindingobjlist.c index 06ccbf53af..4ee2c1b194 100644 --- a/src/conf/virnwfilterbindingobjlist.c +++ b/src/conf/virnwfilterbindingobjlist.c @@ -167,6 +167,7 @@ virNWFilterBindingObjListAddLocked(virNWFilterBindingObjListPtr bindings, virNWFilterBindingDefPtr def) { virNWFilterBindingObjPtr binding; + bool stealDef = false; /* See if a binding with matching portdev already exists */ if ((binding = virNWFilterBindingObjListFindByPortDevLocked( @@ -181,6 +182,7 @@ virNWFilterBindingObjListAddLocked(virNWFilterBindingObjListPtr bindings, goto error; virNWFilterBindingObjSetDef(binding, def); + stealDef = true; if (virNWFilterBindingObjListAddObjLocked(bindings, binding) < 0) goto error; @@ -188,6 +190,8 @@ virNWFilterBindingObjListAddLocked(virNWFilterBindingObjListPtr bindings, return binding; error: + if (stealDef) + virNWFilterBindingObjStealDef(binding); virNWFilterBindingObjEndAPI(&binding); return NULL; } diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 26f10bd47f..a33f9e61b1 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1101,6 +1101,7 @@ virNWFilterBindingObjParseFile; virNWFilterBindingObjSave; virNWFilterBindingObjSetDef; virNWFilterBindingObjSetRemoving; +virNWFilterBindingObjStealDef; # conf/virnwfilterbindingobjlist.h -- 2.19.2

3 4

[libvirt] [PATCH] rpm: fix upgrades when RBD is disabled in a new version
by Daniel P. Berrangé 20 Mar '19

20 Mar '19

We previously had to disable RBD on 32-bit platforms since Ceph has dropped all support for 32-bit. Unfortunately anyone with the RPM libvirt-daemon-driver-storage-rbd installed on 32-bit now has a broken upgrade path. To fix this we must make libvirt-daemon-driver-storage-common have an Obsoletes: libvirt-daemon-driver-storage-rbd < $VER-$REL Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- libvirt.spec.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index 1497cad3d2..79f3d31d19 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -550,6 +550,9 @@ Requires: util-linux # From QEMU RPMs Requires: /usr/bin/qemu-img %endif +%if !%{with_storage_rbd} +Obsoletes: libvirt-daemon-driver-storage-rbd < %{version}-%{release} +%endif %description daemon-driver-storage-core The storage driver plugin for the libvirtd daemon, providing -- 2.20.1

2 2

[libvirt] [PATCH v2 0/3] nodedev: add class info for pci capability
by Nikolay Shirokovskiy 20 Mar '19

20 Mar '19

Diff from v1 [1] =============== - add patch to use/restrict name "klass" in headers instead of class, _class - add news patch [1] https://www.redhat.com/archives/libvir-list/2019-February/msg01036.html Nikolay Shirokovskiy (3): conf: don't use "class" as name in _virNodeDevCapPCIDev xml: nodedev: add class info for pci capability news: update for new class element of PCI nodedev capability cfg.mk | 8 ++++++++ docs/formatnode.html.in | 5 +++++ docs/news.xml | 5 +++++ docs/schemas/nodedev.rng | 5 +++++ src/conf/node_device_conf.c | 17 +++++++++++++++-- src/conf/node_device_conf.h | 4 ++-- src/node_device/node_device_udev.c | 4 ++-- .../nodedevschemadata/pci_0000_00_02_0_header_type.xml | 1 + .../nodedevschemadata/pci_0000_00_1c_0_header_type.xml | 1 + tests/nodedevschemadata/pci_0000_02_10_7_mdev_types.xml | 1 + tests/nodedevschemadata/pci_0000_02_10_7_sriov.xml | 1 + .../pci_0000_02_10_7_sriov_pf_vfs_all.xml | 1 + .../pci_0000_02_10_7_sriov_pf_vfs_all_header_type.xml | 1 + tests/nodedevschemadata/pci_0000_02_10_7_sriov_vfs.xml | 1 + .../pci_0000_02_10_7_sriov_zero_vfs_max_count.xml | 1 + tests/nodedevschemadata/pci_1002_71c4.xml | 1 + tests/nodedevschemadata/pci_8086_0c0c_snd_hda_intel.xml | 1 + tests/nodedevschemadata/pci_8086_10c9_sriov_pf.xml | 1 + tests/nodedevschemadata/pci_8086_4238_pcie_wireless.xml | 1 + tests/nodedevschemadata/pci_82579LM_network_adapter.xml | 1 + 20 files changed, 55 insertions(+), 6 deletions(-) -- 2.16.5

3 9

[libvirt] [PATCH] virStoragePoolDefParseSource: Don't leak @port
by Michal Privoznik 19 Mar '19

19 Mar '19

In a1c453dc088, during VIR_AUTOFREE() rewrite this wasn't done properly. @port might be leaked because it's allocated in a for() loop. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under trivial rule. src/conf/storage_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 7dff566641..3ae0d7ab77 100644 --- a/src/conf/storage_conf.c +++ b/src/conf/storage_conf.c @@ -588,6 +588,7 @@ virStoragePoolDefParseSource(xmlXPathContextPtr ctxt, goto cleanup; } } + VIR_FREE(port); } } -- 2.19.2

1 0

[libvirt] [PATCH] virStoragePoolDefFree: Free @def->refresh
by Michal Privoznik 19 Mar '19

19 Mar '19

In 669018bc9cb I've introduced def->refresh which might be allocated by virStoragePoolDefRefreshParse() but is never freed. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under trivial rule. src/conf/storage_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index b797a405f7..7dff566641 100644 --- a/src/conf/storage_conf.c +++ b/src/conf/storage_conf.c @@ -509,6 +509,7 @@ virStoragePoolDefFree(virStoragePoolDefPtr def) VIR_FREE(def->target.path); VIR_FREE(def->target.perms.label); + VIR_FREE(def->refresh); if (def->namespaceData && def->ns.free) (def->ns.free)(def->namespaceData); VIR_FREE(def); -- 2.19.2

1 0