- Devel - libvirt List Archives

[libvirt] [PATCH v2 1/1] tests/virhostdevtest: remove virHostdevHostSupportsPassthroughKVM
by Daniel Henrique Barboza 03 May '19

03 May '19

virhostdevtest is using pci mock to emulate all PCI attach/detach operations. This means that that this test does not rely on KVM support of the host anymore and the tests in this file shouldn't be affected by it. Suggested-by: Michal Privoznik <mprivozn(a)redhat.com> Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com> --- tests/virhostdevtest.c | 61 +++++++++--------------------------------- 1 file changed, 12 insertions(+), 49 deletions(-) diff --git a/tests/virhostdevtest.c b/tests/virhostdevtest.c index 4e067b10d1..20eaca82e0 100644 --- a/tests/virhostdevtest.c +++ b/tests/virhostdevtest.c @@ -126,37 +126,6 @@ myInit(void) return -1; } -# if HAVE_LINUX_KVM_H -# include <linux/kvm.h> -static bool -virHostdevHostSupportsPassthroughKVM(void) -{ - int kvmfd = -1; - bool ret = false; - - if ((kvmfd = open("/dev/kvm", O_RDONLY)) < 0) - goto cleanup; - -# ifdef KVM_CAP_IOMMU - if ((ioctl(kvmfd, KVM_CHECK_EXTENSION, KVM_CAP_IOMMU)) <= 0) - goto cleanup; - - ret = true; -# endif - - cleanup: - VIR_FORCE_CLOSE(kvmfd); - - return ret; -} -# else -static bool -virHostdevHostSupportsPassthroughKVM(void) -{ - return false; -} -# endif - static int testVirHostdevPreparePCIHostdevs_unmanaged(void) { @@ -483,12 +452,10 @@ testVirHostdevRoundtripUnmanaged(const void *opaque ATTRIBUTE_UNUSED) if (testVirHostdevDetachPCINodeDevice() < 0) goto out; - if (virHostdevHostSupportsPassthroughKVM()) { - if (testVirHostdevPreparePCIHostdevs_unmanaged() < 0) - goto out; - if (testVirHostdevReAttachPCIHostdevs_unmanaged() < 0) - goto out; - } + if (testVirHostdevPreparePCIHostdevs_unmanaged() < 0) + goto out; + if (testVirHostdevReAttachPCIHostdevs_unmanaged() < 0) + goto out; if (testVirHostdevReAttachPCINodeDevice() < 0) goto out; @@ -512,12 +479,10 @@ testVirHostdevRoundtripManaged(const void *opaque ATTRIBUTE_UNUSED) { int ret = -1; - if (virHostdevHostSupportsPassthroughKVM()) { - if (testVirHostdevPreparePCIHostdevs_managed(false) < 0) - goto out; - if (testVirHostdevReAttachPCIHostdevs_managed(false) < 0) - goto out; - } + if (testVirHostdevPreparePCIHostdevs_managed(false) < 0) + goto out; + if (testVirHostdevReAttachPCIHostdevs_managed(false) < 0) + goto out; ret = 0; @@ -544,12 +509,10 @@ testVirHostdevRoundtripMixed(const void *opaque ATTRIBUTE_UNUSED) if (testVirHostdevDetachPCINodeDevice() < 0) goto out; - if (virHostdevHostSupportsPassthroughKVM()) { - if (testVirHostdevPreparePCIHostdevs_managed(true) < 0) - goto out; - if (testVirHostdevReAttachPCIHostdevs_managed(true) < 0) - goto out; - } + if (testVirHostdevPreparePCIHostdevs_managed(true) < 0) + goto out; + if (testVirHostdevReAttachPCIHostdevs_managed(true) < 0) + goto out; if (testVirHostdevReAttachPCINodeDevice() < 0) goto out; -- 2.20.1

2 1

[libvirt] [PATCH] qemuConnectOpen: Drop unused @cfg and simplify
by Michal Privoznik 03 May '19

03 May '19

After 65a372d6e0 the @cfg variable is no longer used. This means we can drop it and therefore drop 'cleanup' label with it. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_driver.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index c072bed1ce..30945d1545 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1094,44 +1094,37 @@ static virDrvOpenStatus qemuConnectOpen(virConnectPtr conn, virConfPtr conf ATTRIBUTE_UNUSED, unsigned int flags) { - virQEMUDriverConfigPtr cfg = NULL; - virDrvOpenStatus ret = VIR_DRV_OPEN_ERROR; virCheckFlags(VIR_CONNECT_RO, VIR_DRV_OPEN_ERROR); if (qemu_driver == NULL) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("qemu state driver is not active")); - goto cleanup; + return VIR_DRV_OPEN_ERROR; } - cfg = virQEMUDriverGetConfig(qemu_driver); - if (virQEMUDriverIsPrivileged(qemu_driver)) { if (STRNEQ(conn->uri->path, "/system") && STRNEQ(conn->uri->path, "/session")) { virReportError(VIR_ERR_INTERNAL_ERROR, _("unexpected QEMU URI path '%s', try qemu:///system"), conn->uri->path); - goto cleanup; + return VIR_DRV_OPEN_ERROR; } } else { if (STRNEQ(conn->uri->path, "/session")) { virReportError(VIR_ERR_INTERNAL_ERROR, _("unexpected QEMU URI path '%s', try qemu:///session"), conn->uri->path); - goto cleanup; + return VIR_DRV_OPEN_ERROR; } } if (virConnectOpenEnsureACL(conn) < 0) - goto cleanup; + return VIR_DRV_OPEN_ERROR; conn->privateData = qemu_driver; - ret = VIR_DRV_OPEN_SUCCESS; - cleanup: - virObjectUnref(cfg); - return ret; + return VIR_DRV_OPEN_SUCCESS; } static int qemuConnectClose(virConnectPtr conn) -- 2.21.0

2 1

[libvirt] [PATCH v2 0/8] CPU Model Baseline and Comparison for s390x
by walling＠linux.ibm.com 02 May '19

02 May '19

From: Collin Walling <walling(a)linux.ibm.com> Changelog: v1 - introduce baseline - split patches into small chunks - free'd lingering qemuMonitorCPUModelInfo pointer - when converting from virCPUDef -> virJSON, consider feature policy FORCED for enabled This is the second iteration of the CPU Model Comparison and Baseline patches for s390x. The previous version only showed comparison as a preview, and it can be found here: https://www.redhat.com/archives/libvir-list/2019-April/msg01046.html The first patch pull some code out of the CPU Model Expansion JSON function so that it can be later used for the Comparison and Baseline JSON functions. The rest of the patches follow this sequence: - introduce JSON monitor functions - introduce capability and update test files - hook up monitor functions to virsh command Thanks @Daniel, I added your Tested-by where I felt made most sense. Collin Walling (8): qemu_monitor: helper functions for CPU models qemu_monitor: implement query-cpu-model-baseline qemu_capabilities: introduce QEMU_CAPS_QUERY_CPU_MODEL_BASELINE qemu_driver: hook up query-cpu-model-baseline qemu_monitor: implement query-cpu-model-comparison qemu_capabilities: introduce QEMU_CAPS_QUERY_CPU_MODEL_COMPARISON cpu_conf: xml to cpu definition parse helper qemu_driver: hook up query-cpu-model-comparison src/conf/cpu_conf.c | 30 +++ src/conf/cpu_conf.h | 6 + src/cpu/cpu.c | 14 +- src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 156 +++++++++++++ src/qemu/qemu_capabilities.h | 20 ++ src/qemu/qemu_driver.c | 38 +++ src/qemu/qemu_monitor.c | 44 ++++ src/qemu/qemu_monitor.h | 18 ++ src/qemu/qemu_monitor_json.c | 285 ++++++++++++++++++++--- src/qemu/qemu_monitor_json.h | 20 ++ tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml | 2 + tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 2 + tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 2 + tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 2 + tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml | 2 + tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml | 2 + 17 files changed, 595 insertions(+), 49 deletions(-) -- 2.7.4

3 18

[libvirt] [jenkins-ci PATCH] lcitool: use slirp networking if running non-root
by Daniel P. Berrangé 02 May '19

02 May '19

The virtual networks are only available to the system libvirt instance. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- guests/lcitool | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/guests/lcitool b/guests/lcitool index 0f60704..9d17f1a 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -511,9 +511,12 @@ class Application: facts["install_disk_size"], facts["install_storage_pool"], ) - network_arg = "network={},model=virtio".format( - facts["install_network"], - ) + if os.geteuid() == 0: + network_arg = "network={},model=virtio".format( + facts["install_network"], + ) + else: + network_arg = "user,model=virtio" # Different operating systems require different configuration # files for unattended installation to work, but some operating -- 2.21.0

1 1

[libvirt] [jenkins-ci PATCH] lcitool: check for virt-install existing
by Daniel P. Berrangé 02 May '19

02 May '19

This improves: $ ./lcitool install libvirt-fedora-29 ./lcitool: Failed to install 'libvirt-fedora-29': [Errno 2] No such file or directory To $ ./lcitool install libvirt-fedora-29 ./lcitool: Cannot find virt-install in $PATH Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- guests/lcitool | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/guests/lcitool b/guests/lcitool index 0f60704..3be16c8 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -37,6 +37,23 @@ except ImportError: class Util: + @staticmethod + def which(program): + def is_exe(fpath): + return os.path.isfile(fpath) and os.access(fpath, os.X_OK) + + fpath, fname = os.path.split(program) + if fpath: + if is_exe(program): + return program + else: + for path in os.environ["PATH"].split(os.pathsep): + exe_file = os.path.join(path, program) + if is_exe(exe_file): + return exe_file + + return None + @staticmethod def get_base(): return os.path.dirname(os.path.abspath(__file__)) @@ -534,8 +551,12 @@ class Application: # a kernel argument extra_arg = "console=ttyS0 ks=file:/{}".format(install_config) + vipath = Util.which("virt-install") + if vipath is None: + raise Exception("Cannot find virt-install in $PATH") + cmd = [ - "virt-install", + vipath, "--name", host, "--location", facts["install_url"], "--virt-type", facts["install_virt_type"], -- 2.21.0

2 1

[libvirt] [PATCH v3] qemu.conf: Make nvram list obsolete
by Michal Privoznik 02 May '19

02 May '19

Now that libvirt has firmware auto selection feature the nvram config knob is more or less obsolete. It still makes sense in cases where distro users are using does not provide FW descriptor files, therefore I'm not removing it. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu.conf | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf index 334b4cd4ee..5a85789d81 100644 --- a/src/qemu/qemu.conf +++ b/src/qemu/qemu.conf @@ -740,6 +740,14 @@ # Location of master nvram file # +# This configuration option is obsolete. Libvirt will follow the +# QEMU firmware metadata specification to automatically locate +# firmware images. See docs/interop/firmware.json in the QEMU +# source tree. These metadata files are distributed alongside any +# firmware images intended for use with QEMU. +# +# ------------------------------------------ +# # When a domain is configured to use UEFI instead of standard # BIOS it may use a separate storage for UEFI variables. If # that's the case libvirt creates the variable store per domain -- 2.21.0

2 1

[libvirt] [PATCH 1/1] util/virhostdev: consolidate duplicated KVM support code
by Daniel Henrique Barboza 02 May '19

02 May '19

tests/virhostdevtest.c implements a function called 'virHostdevHostSupportsPassthroughKVM', that is equal to 'qemuHostdevHostSupportsPassthroughLegacy' that is declared inside qemu/qemu_hostdev.c. This patch removes the duplicated code from both files and and puts it inside util/virhostdev.c, under the name virHostdev...KVM, which represents what the code does better than using 'Legacy'. Based-on-work-of: Shivaprasad G Bhat <sbhat(a)linux.vnet.ibm.com> Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com> --- src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_driver.c | 6 +++--- src/qemu/qemu_hostdev.c | 34 +--------------------------------- src/qemu/qemu_hostdev.h | 1 - src/util/virhostdev.c | 31 +++++++++++++++++++++++++++++++ src/util/virhostdev.h | 1 + tests/virhostdevtest.c | 31 ------------------------------- 8 files changed, 38 insertions(+), 69 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index a03cf0b645..a6747684ea 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -2044,6 +2044,7 @@ virHostCPUStatsAssign; # util/virhostdev.h virHostdevFindUSBDevice; +virHostdevHostSupportsPassthroughKVM; virHostdevIsMdevDevice; virHostdevIsSCSIDevice; virHostdevManagerGetDefault; diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index a0b2ca73fb..515db0112f 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -5152,7 +5152,7 @@ static int virQEMUCapsFillDomainDeviceHostdevCaps(virQEMUCapsPtr qemuCaps, virDomainCapsDeviceHostdevPtr hostdev) { - bool supportsPassthroughKVM = qemuHostdevHostSupportsPassthroughLegacy(); + bool supportsPassthroughKVM = virHostdevHostSupportsPassthroughKVM(); bool supportsPassthroughVFIO = qemuHostdevHostSupportsPassthroughVFIO(); hostdev->supported = VIR_TRISTATE_BOOL_YES; diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index b2ac737d1f..c02482337a 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -13283,7 +13283,7 @@ qemuNodeDeviceDetachFlags(virNodeDevicePtr dev, int ret = -1; virNodeDeviceDefPtr def = NULL; char *xml = NULL; - bool legacy = qemuHostdevHostSupportsPassthroughLegacy(); + bool kvm = virHostdevHostSupportsPassthroughKVM(); bool vfio = qemuHostdevHostSupportsPassthroughVFIO(); virHostdevManagerPtr hostdev_mgr = driver->hostdevMgr; @@ -13310,7 +13310,7 @@ qemuNodeDeviceDetachFlags(virNodeDevicePtr dev, if (!driverName) { if (vfio) { driverName = "vfio"; - } else if (legacy) { + } else if (kvm) { driverName = "kvm"; } else { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", @@ -13329,7 +13329,7 @@ qemuNodeDeviceDetachFlags(virNodeDevicePtr dev, } virPCIDeviceSetStubDriver(pci, VIR_PCI_STUB_DRIVER_VFIO); } else if (STREQ(driverName, "kvm")) { - if (!legacy) { + if (!kvm) { virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", _("KVM device assignment is currently not " "supported on this system")); diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index 4eb3f1d7f1..b6cb4d0980 100644 --- a/src/qemu/qemu_hostdev.c +++ b/src/qemu/qemu_hostdev.c @@ -132,44 +132,12 @@ qemuHostdevHostSupportsPassthroughVFIO(void) } -#if HAVE_LINUX_KVM_H -# include <linux/kvm.h> -bool -qemuHostdevHostSupportsPassthroughLegacy(void) -{ - int kvmfd = -1; - bool ret = false; - - if ((kvmfd = open("/dev/kvm", O_RDONLY)) < 0) - goto cleanup; - -# ifdef KVM_CAP_IOMMU - if ((ioctl(kvmfd, KVM_CHECK_EXTENSION, KVM_CAP_IOMMU)) <= 0) - goto cleanup; - - ret = true; -# endif - - cleanup: - VIR_FORCE_CLOSE(kvmfd); - - return ret; -} -#else -bool -qemuHostdevHostSupportsPassthroughLegacy(void) -{ - return false; -} -#endif - - static bool qemuHostdevPreparePCIDevicesCheckSupport(virDomainHostdevDefPtr *hostdevs, size_t nhostdevs, virQEMUCapsPtr qemuCaps) { - bool supportsPassthroughKVM = qemuHostdevHostSupportsPassthroughLegacy(); + bool supportsPassthroughKVM = virHostdevHostSupportsPassthroughKVM(); bool supportsPassthroughVFIO = qemuHostdevHostSupportsPassthroughVFIO(); size_t i; diff --git a/src/qemu/qemu_hostdev.h b/src/qemu/qemu_hostdev.h index 41f254ab81..be6faa2c35 100644 --- a/src/qemu/qemu_hostdev.h +++ b/src/qemu/qemu_hostdev.h @@ -25,7 +25,6 @@ # include "qemu_conf.h" # include "domain_conf.h" -bool qemuHostdevHostSupportsPassthroughLegacy(void); bool qemuHostdevHostSupportsPassthroughVFIO(void); int qemuHostdevUpdateActiveMediatedDevices(virQEMUDriverPtr driver, diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c index 19ae001971..872528fdb2 100644 --- a/src/util/virhostdev.c +++ b/src/util/virhostdev.c @@ -2245,3 +2245,34 @@ virHostdevUpdateActiveDomainDevices(virHostdevManagerPtr mgr, return 0; } + +#if HAVE_LINUX_KVM_H +# include <linux/kvm.h> +bool +virHostdevHostSupportsPassthroughKVM(void) +{ + int kvmfd = -1; + bool ret = false; + + if ((kvmfd = open("/dev/kvm", O_RDONLY)) < 0) + goto cleanup; + +# ifdef KVM_CAP_IOMMU + if ((ioctl(kvmfd, KVM_CHECK_EXTENSION, KVM_CAP_IOMMU)) <= 0) + goto cleanup; + + ret = true; +# endif + + cleanup: + VIR_FORCE_CLOSE(kvmfd); + + return ret; +} +#else +bool +virHostdevHostSupportsPassthroughKVM(void) +{ + return false; +} +#endif diff --git a/src/util/virhostdev.h b/src/util/virhostdev.h index 7263f320a2..32fa36cdef 100644 --- a/src/util/virhostdev.h +++ b/src/util/virhostdev.h @@ -203,4 +203,5 @@ int virHostdevPCINodeDeviceReset(virHostdevManagerPtr mgr, virPCIDevicePtr pci) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); +bool virHostdevHostSupportsPassthroughKVM(void); #endif /* LIBVIRT_VIRHOSTDEV_H */ diff --git a/tests/virhostdevtest.c b/tests/virhostdevtest.c index 4e067b10d1..1258338949 100644 --- a/tests/virhostdevtest.c +++ b/tests/virhostdevtest.c @@ -126,37 +126,6 @@ myInit(void) return -1; } -# if HAVE_LINUX_KVM_H -# include <linux/kvm.h> -static bool -virHostdevHostSupportsPassthroughKVM(void) -{ - int kvmfd = -1; - bool ret = false; - - if ((kvmfd = open("/dev/kvm", O_RDONLY)) < 0) - goto cleanup; - -# ifdef KVM_CAP_IOMMU - if ((ioctl(kvmfd, KVM_CHECK_EXTENSION, KVM_CAP_IOMMU)) <= 0) - goto cleanup; - - ret = true; -# endif - - cleanup: - VIR_FORCE_CLOSE(kvmfd); - - return ret; -} -# else -static bool -virHostdevHostSupportsPassthroughKVM(void) -{ - return false; -} -# endif - static int testVirHostdevPreparePCIHostdevs_unmanaged(void) { -- 2.20.1

2 1

[libvirt] [PATCH] docs: Update drivers page to link to storage.html
by John Ferlan 02 May '19

02 May '19

Rather than duplicate a list of storage pool backends on the drivers.html page, let's just link directly to the storage driver page similar to how the node device driver is done. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- docs/drivers.html.in | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/docs/drivers.html.in b/docs/drivers.html.in index a66651df2f..4539eedbcd 100644 --- a/docs/drivers.html.in +++ b/docs/drivers.html.in @@ -6,7 +6,7 @@ <ul> <li><a href="#hypervisor">Hypervisor drivers</a></li> - <li><a href="#storage">Storage drivers</a></li> + <li><a href="storage.html">Storage drivers</a></li> <li><a href="drvnodedev.html">Node device driver</a></li> </ul> @@ -39,19 +39,5 @@ <li><strong><a href="drvbhyve.html">Bhyve</a></strong> - The BSD Hypervisor</li> </ul> - <h2><a id="storage">Storage drivers</a></h2> - - <ul> - <li><strong><a href="storage.html#StorageBackendDir">Directory backend</a></strong></li> - <li><strong><a href="storage.html#StorageBackendFS">Local filesystem backend</a></strong></li> - <li><strong><a href="storage.html#StorageBackendNetFS">Network filesystem backend</a></strong></li> - <li><strong><a href="storage.html#StorageBackendLogical">Logical Volume Manager (LVM) backend</a></strong></li> - <li><strong><a href="storage.html#StorageBackendDisk">Disk backend</a></strong></li> - <li><strong><a href="storage.html#StorageBackendISCSI">iSCSI backend</a></strong></li> - <li><strong><a href="storage.html#StorageBackendSCSI">SCSI backend</a></strong></li> - <li><strong><a href="storage.html#StorageBackendMultipath">Multipath backend</a></strong></li> - <li><strong><a href="storage.html#StorageBackendRBD">RBD (RADOS Block Device) backend</a></strong></li> - <li><strong><a href="storage.html#StorageBackendSheepdog">Sheepdog backend</a></strong></li> - </ul> </body> </html> -- 2.20.1

2 1

[libvirt] [PATCH] qemu: Disable console device detach from live mode.
by Julio Faracco 01 May '19

01 May '19

Console Char devices cannot be attached as qemuDomainChrRemove() function suggests. After moved to async mode, qemuDomainRemoveChrDevice() is not part of the removal process. So, we need to check if device is able to be detached before calling removal procedures. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1447183 Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- src/qemu/qemu_hotplug.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index f3c5f44a23..2c65df6d7b 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -5844,6 +5844,14 @@ qemuDomainDetachDeviceChr(virQEMUDriverPtr driver, goto cleanup; } + if (tmpChr->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_CONSOLE && + tmpChr->targetType == VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_SERIAL) { + virReportError(VIR_ERR_OPERATION_INVALID, "%s", + _("detaching serial console is not supported")); + goto cleanup; + } + + /* guestfwd channels are not really -device rather than * -netdev. We need to treat them slightly differently. */ guestfwd = tmpChr->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_CHANNEL && -- 2.20.1

1 0

[libvirt] Entering freeze for libvirt-5.3.0
by Daniel Veillard 30 Apr '19

30 Apr '19

One day late but RC1 is tagged in git, and I pushed the signed tarball and rpms to the new usual place, it's the same dir, same content, just though https https://libvirt.org/sources/ Looks fine in my minimal testing, but give it a try especially on diverse system and architecture. The fact that https://ci.centos.org/view/libvirt/ is all green except for one edge case is also a good indication. So assuming everything goes as planned, I think RC2 should be cut on Tuesday and we can plan for a May 2nd final release is everything goes well. Give it a good testing, thanks ! Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 1

[libvirt] [PATCH 0/2] conf: DEF_FEATURE tweaks
by Cole Robinson 30 Apr '19

30 Apr '19

After the net model enum patches, the test driver started rejecting non-enum model strings. It should continue to accept unknown models and generally act closer to the qemu driver. So let's add all of qemu's DEF_FEATURE bits to match while we are at it (virt-manager will want this for os firmware XML testing at least) Fix an issue in the area while I'm here Cole Robinson (2): test: match qemu VIR_DOMAIN_DEF_FEATURE* usage conf: Fix VIR_DOMAIN_DEF_FEATURE_FW_AUTOSELECT validation src/conf/domain_conf.c | 6 ++---- src/test/test_driver.c | 10 +++++++++- src/vmx/vmx.c | 3 ++- 3 files changed, 13 insertions(+), 6 deletions(-) -- 2.21.0

2 5

[libvirt] [PATCH] spec: fix f28 rpm without firewalld zone
by Cole Robinson 30 Apr '19

30 Apr '19

Commit 3b71f2e42d added spec handling for with_firewalld_zone. We now call %firewalld_reload if with_firewalld is set. But the matching 'BuildRequires: firewalld-filesystem' is only applied if with_firewalld_zone is set. Fix the former bit to use with_firewalld_zone Reported-by: Yuval Turgeman <yturgema(a)redhat.com> Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- libvirt.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 18f0a0e217..876b2f0897 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1387,12 +1387,12 @@ fi rm -rf %{_localstatedir}/lib/rpm-state/libvirt || : %post daemon-driver-network -%if %{with_firewalld} +%if %{with_firewalld_zone} %firewalld_reload %endif %postun daemon-driver-network -%if %{with_firewalld} +%if %{with_firewalld_zone} %firewalld_reload %endif -- 2.21.0

2 2

[libvirt] [PATCH] lib: Preserve error around virDomainNetReleaseActualDevice()
by Michal Privoznik 30 Apr '19

30 Apr '19

This function is calling public API virNetworkLookupByName() which resets the error. Therefore, if virDomainNetReleaseActualDevice() is used in cleanup path it actually resets the original error that got us jump into 'cleanup' label. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- I've found this issue when trying to change QoS on an domain's <interface/> and I've intentionally entered @floor bigger than corresponding network's average. Orders bigger. I mean, with this change the QoS is still kind of broken [1] but at least I'm getting some sensible error instead of "An error occurred, but the cause is unknown". 1: Thing is, when an <interface type='network'/> is being updated (virsh update-device) then a new interface is actually created (virDomainNetAllocateActualDevice() is called), which is then set up and the old interface is then released. This works in theory, but for a fraction of a second we have two interfaces. Therefore the sum of their @floor-s might exceed the limit (which is MAX(network average, network peak)) and thus allocating new device will fail. Unfortunately, I don't have any bright idea around this. Maybe temporary setting newdev->bandwidth = NULL; then allocating new device and trying to set new bandwidth ourselves? That is still going to fail until the old interface is not released. Ideas are welcome. src/libxl/libxl_driver.c | 6 ++++++ src/lxc/lxc_driver.c | 3 +++ src/lxc/lxc_process.c | 3 +++ src/qemu/qemu_hotplug.c | 6 ++++++ 4 files changed, 18 insertions(+) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index e7234c1479..2b9c6f1866 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -3380,6 +3380,7 @@ libxlDomainAttachNetDevice(libxlDriverPrivatePtr driver, int ret = -1; char mac[VIR_MAC_STRING_BUFLEN]; virConnectPtr conn = NULL; + virErrorPtr save_err = NULL; libxl_device_nic_init(&nic); @@ -3440,6 +3441,7 @@ libxlDomainAttachNetDevice(libxlDriverPrivatePtr driver, ret = 0; cleanup: + virErrorPreserveLast(&save_err); libxl_device_nic_dispose(&nic); if (!ret) { vm->def->nets[vm->def->nnets++] = net; @@ -3450,6 +3452,7 @@ libxlDomainAttachNetDevice(libxlDriverPrivatePtr driver, } virObjectUnref(conn); virObjectUnref(cfg); + virErrorRestore(&save_err); return ret; } @@ -3838,6 +3841,7 @@ libxlDomainDetachNetDevice(libxlDriverPrivatePtr driver, libxl_device_nic nic; char mac[VIR_MAC_STRING_BUFLEN]; int ret = -1; + virErrorPtr save_err = NULL; libxl_device_nic_init(&nic); @@ -3868,6 +3872,7 @@ libxlDomainDetachNetDevice(libxlDriverPrivatePtr driver, ret = 0; cleanup: + virErrorPreserveLast(&save_err); libxl_device_nic_dispose(&nic); if (!ret) { if (detach->type == VIR_DOMAIN_NET_TYPE_NETWORK) { @@ -3882,6 +3887,7 @@ libxlDomainDetachNetDevice(libxlDriverPrivatePtr driver, virDomainNetRemove(vm->def, detachidx); } virObjectUnref(cfg); + virErrorRestore(&save_err); return ret; } diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index 1980d0804e..9db2a02dee 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -4337,6 +4337,7 @@ lxcDomainDetachDeviceNetLive(virDomainObjPtr vm, virDomainNetType actualType; virDomainNetDefPtr detach = NULL; virNetDevVPortProfilePtr vport = NULL; + virErrorPtr save_err = NULL; if ((detachidx = virDomainNetFindIdx(vm->def, dev->data.net)) < 0) goto cleanup; @@ -4396,6 +4397,7 @@ lxcDomainDetachDeviceNetLive(virDomainObjPtr vm, ret = 0; cleanup: if (!ret) { + virErrorPreserveLast(&save_err); if (detach->type == VIR_DOMAIN_NET_TYPE_NETWORK) { virConnectPtr conn = virGetConnectNetwork(); if (conn) { @@ -4407,6 +4409,7 @@ lxcDomainDetachDeviceNetLive(virDomainObjPtr vm, } virDomainNetRemove(vm->def, detachidx); virDomainNetDefFree(detach); + virErrorRestore(&save_err); } return ret; } diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c index 3a33418aca..de4d7c73fb 100644 --- a/src/lxc/lxc_process.c +++ b/src/lxc/lxc_process.c @@ -550,6 +550,7 @@ static int virLXCProcessSetupInterfaces(virConnectPtr conn, virDomainNetDefPtr net; virDomainNetType type; virConnectPtr netconn = NULL; + virErrorPtr save_err = NULL; if (VIR_ALLOC_N(*veths, def->nnets + 1) < 0) return -1; @@ -642,6 +643,7 @@ static int virLXCProcessSetupInterfaces(virConnectPtr conn, cleanup: if (ret < 0) { + virErrorPreserveLast(&save_err); for (i = 0; i < def->nnets; i++) { virDomainNetDefPtr iface = def->nets[i]; virNetDevVPortProfilePtr vport = virDomainNetGetActualVirtPortProfile(iface); @@ -652,6 +654,7 @@ static int virLXCProcessSetupInterfaces(virConnectPtr conn, if (iface->type == VIR_DOMAIN_NET_TYPE_NETWORK && netconn) virDomainNetReleaseActualDevice(netconn, def, iface); } + virErrorRestore(&save_err); } virObjectUnref(netconn); return ret; diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index e199368e8a..f3c5f44a23 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -1383,6 +1383,7 @@ qemuDomainAttachNetDevice(virQEMUDriverPtr driver, bool netdevPlugged = false; char *netdev_name; virConnectPtr conn = NULL; + virErrorPtr save_err = NULL; /* preallocate new slot for device */ if (VIR_REALLOC_N(vm->def->nets, vm->def->nnets + 1) < 0) @@ -1678,6 +1679,7 @@ qemuDomainAttachNetDevice(virQEMUDriverPtr driver, if (!ret) { vm->def->nets[vm->def->nnets++] = net; } else { + virErrorPreserveLast(&save_err); if (releaseaddr) qemuDomainReleaseDeviceAddress(vm, &net->info); @@ -1706,6 +1708,7 @@ qemuDomainAttachNetDevice(virQEMUDriverPtr driver, else VIR_WARN("Unable to release network device '%s'", NULLSTR(net->ifname)); } + virErrorRestore(&save_err); } VIR_FREE(nicstr); @@ -3756,6 +3759,7 @@ qemuDomainChangeNet(virQEMUDriverPtr driver, int ret = -1; int changeidx = -1; virConnectPtr conn = NULL; + virErrorPtr save_err = NULL; if ((changeidx = virDomainNetFindIdx(vm->def, newdev)) < 0) goto cleanup; @@ -4173,6 +4177,7 @@ qemuDomainChangeNet(virQEMUDriverPtr driver, ret = 0; cleanup: + virErrorPreserveLast(&save_err); /* When we get here, we will be in one of these two states: * * 1) newdev has been moved into the domain's list of nets and @@ -4194,6 +4199,7 @@ qemuDomainChangeNet(virQEMUDriverPtr driver, if (newdev && newdev->type == VIR_DOMAIN_NET_TYPE_NETWORK && conn) virDomainNetReleaseActualDevice(conn, vm->def, newdev); virObjectUnref(conn); + virErrorRestore(&save_err); return ret; } -- 2.21.0

2 1

[libvirt] [PATCH for 5.3.0] news: Update for 5.3.0 release
by Michal Privoznik 30 Apr '19

30 Apr '19

Some basic features/bugfixes/removed features. Of course we've done a lot more than recoded here. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- docs/news.xml | 62 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index e0cab23c49..745bf64a5d 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -48,6 +48,18 @@ </description> </change> </section> + <section title="Removed features"> + <change> + <summary> + Drop support for VirtualBox 4.x releases + </summary> + <description> + Support for all the 4.x releases was ended by + VirtualBox maintainers in December 2015. Therefore, + libvirt support for these releases is dropped. + </description> + </change> + </section> <section title="Improvements"> <change> <summary> @@ -73,6 +85,27 @@ Firmware Secure Boot support is also advertised. </description> </change> + <change> + <summary> + Drop yajl-1 support in favour of yajl-2 + </summary> + <description> + Yajl-2 is widely adapted and maintaining side by side + support for two versions is needless. + </description> + </change> + <change> + <summary> + tests: add targets for building libvirt inside Docker containers + </summary> + <description> + Strictly speaking this does not concern users, but it + is still worth mentioning. New build targets are + introduced to build and test libvirt under various + docker images, for instance make + <code>ci-build@fedora-28</code> + </description> + </change> </section> <section title="Bug fixes"> <change> @@ -85,6 +118,35 @@ leaks may also occur. </description> </change> + <change> + <summary> + virsh: various completers fixes + </summary> + <description> + There were some possible crashers, memory leaks, etc. + which are now fixed. + </description> + </change> + <change> + <summary> + qemu: Make hugepages work with memfd backend + </summary> + <description> + Due to a bug in command line generation libvirt did not + honoured hugepages setting with memfd backend. + </description> + </change> + <change> + <summary> + Enforce ACL write permission for getting guest time & hostname + </summary> + <description> + Getting the guest time and hostname both require use of + guest agent commands. These must not be allowed for + read-only users, so the permissions check must validate + "write" permission not "read". + </description> + </change> </section> </release> <release version="v5.2.0" date="2019-04-03"> -- 2.21.0

2 1

[libvirt] [PATCH 0/2] Fix regression with network type handling
by Daniel P. Berrangé 30 Apr '19

30 Apr '19

Problems pointed out at https://www.redhat.com/archives/libvir-list/2019-April/msg01412.html It certainly isn't possible to fix these problems in time for release, and probably never. So reverting is best, probably only, option. Daniel P. Berrangé (2): Revert "virt drivers: don't handle type=network after resolving actual network type" Revert "network: use 'bridge' as actual type instead of 'network'" src/conf/domain_conf.c | 33 +++---------------- src/libxl/libxl_conf.c | 21 ++++++++++-- src/lxc/lxc_driver.c | 15 +++------ src/network/bridge_driver.c | 11 +++++-- src/qemu/qemu_command.c | 8 ++--- src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_hotplug.c | 13 ++------ src/qemu/qemu_interface.c | 12 ++----- src/qemu/qemu_process.c | 5 +-- .../disk-secinfo-upgrade-out.xml | 2 +- .../migration-in-params-in.xml | 2 +- .../migration-out-nbd-out.xml | 2 +- .../migration-out-nbd-tls-out.xml | 2 +- .../migration-out-params-in.xml | 2 +- tests/qemustatusxml2xmldata/modern-in.xml | 2 +- 15 files changed, 49 insertions(+), 83 deletions(-) -- 2.20.1

2 3

[libvirt] [PATCH] tests: qemucaps: Bump capability test data for qemu-4.0 release on x86_64
by Peter Krempa 30 Apr '19

30 Apr '19

Capture and update the 4.0.0 qemu version replies now that it was released. I opted to keep the CPU differences as there was a qemu bug which reported an empty string in CPU caps. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- .../qemu_4.0.0.x86_64.xml | 2 +- .../caps_4.0.0.x86_64.replies | 3161 +++++++++-------- .../caps_4.0.0.x86_64.xml | 26 +- 3 files changed, 1670 insertions(+), 1519 deletions(-) diff --git a/tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml b/tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml index 42d8949e61..cba841d844 100644 --- a/tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml +++ b/tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml @@ -33,11 +33,11 @@ <model fallback='forbid'>Skylake-Client-IBRS</model> <vendor>Intel</vendor> <feature policy='require' name='ss'/> + <feature policy='require' name='vmx'/> <feature policy='require' name='hypervisor'/> <feature policy='require' name='tsc_adjust'/> <feature policy='require' name='clflushopt'/> <feature policy='require' name='umip'/> - <feature policy='require' name='arch-capabilities'/> <feature policy='require' name='ssbd'/> <feature policy='require' name='xsaves'/> <feature policy='require' name='pdpe1gb'/> diff --git a/tests/qemucapabilitiesdata/caps_4.0.0.x86_64.replies b/tests/qemucapabilitiesdata/caps_4.0.0.x86_64.replies index aa9ee38c80..1482f85846 100644 --- a/tests/qemucapabilitiesdata/caps_4.0.0.x86_64.replies +++ b/tests/qemucapabilitiesdata/caps_4.0.0.x86_64.replies @@ -17,11 +17,11 @@ { "return": { "qemu": { - "micro": 50, - "minor": 1, - "major": 3 + "micro": 0, + "minor": 0, + "major": 4 }, - "package": "v3.1.0-1445-ga61faa3d02" + "package": "v4.0.0" }, "id": "libvirt-2" } @@ -55,7 +55,10 @@ "name": "query-qmp-schema" }, { - "name": "set-numa-node" + "name": "query-cpu-definitions" + }, + { + "name": "query-cpu-model-expansion" }, { "name": "query-sev-capabilities" @@ -66,6 +69,12 @@ { "name": "query-sev" }, + { + "name": "rtc-reset-reinjection" + }, + { + "name": "set-numa-node" + }, { "name": "query-vm-generation-id" }, @@ -75,9 +84,6 @@ { "name": "xen-load-devices-state" }, - { - "name": "rtc-reset-reinjection" - }, { "name": "query-acpi-ospm-status" }, @@ -102,12 +108,6 @@ { "name": "add-fd" }, - { - "name": "query-cpu-model-expansion" - }, - { - "name": "query-cpu-definitions" - }, { "name": "query-memory-size-summary" }, @@ -375,6 +375,9 @@ { "name": "query-rocker" }, + { + "name": "announce-self" + }, { "name": "query-rx-filter" }, @@ -462,6 +465,9 @@ { "name": "blockdev-del" }, + { + "name": "x-blockdev-reopen" + }, { "name": "blockdev-add" }, @@ -559,7 +565,7 @@ "name": "query-block" }, { - "name": "x-block-latency-histogram-set" + "name": "block-latency-histogram-set" }, { "name": "query-jobs" @@ -1124,6 +1130,10 @@ "name": "pc-0.15-machine", "parent": "generic-pc-machine" }, + { + "name": "authz-list-file", + "parent": "authz" + }, { "name": "kvmvapic", "parent": "sys-bus-device" @@ -1168,6 +1178,10 @@ "name": "virtio-blk-device", "parent": "virtio-device" }, + { + "name": "chardev-pipe", + "parent": "chardev-fd" + }, { "name": "nvdimm", "parent": "pc-dimm" @@ -1188,10 +1202,6 @@ "name": "chardev-msmouse", "parent": "chardev" }, - { - "name": "chardev-pipe", - "parent": "chardev-fd" - }, { "name": "pc-q35-2.9-machine", "parent": "generic-pc-machine" @@ -1372,14 +1382,14 @@ "name": "Westmere-IBRS-x86_64-cpu", "parent": "x86_64-cpu" }, - { - "name": "usb-serial", - "parent": "usb-serial-dev" - }, { "name": "Cascadelake-Server-x86_64-cpu", "parent": "x86_64-cpu" }, + { + "name": "usb-serial", + "parent": "usb-serial-dev" + }, { "name": "vt82c686b-usb-uhci", "parent": "pci-uhci-usb" @@ -1488,6 +1498,10 @@ "name": "virtio-serial-pci-transitional", "parent": "virtio-serial-pci-base" }, + { + "name": "ati-vga", + "parent": "pci-device" + }, { "name": "pc-q35-3.0-machine", "parent": "generic-pc-machine" @@ -2060,6 +2074,10 @@ "name": "igd-passthrough-i440FX", "parent": "i440FX" }, + { + "name": "authz-pam", + "parent": "authz" + }, { "name": "colo-compare", "parent": "object" @@ -2148,6 +2166,10 @@ "name": "hda-duplex", "parent": "hda-audio" }, + { + "name": "authz-simple", + "parent": "authz" + }, { "name": "kvm32-x86_64-cpu", "parent": "x86_64-cpu" @@ -2296,6 +2318,10 @@ "name": "pc-1.3-machine", "parent": "generic-pc-machine" }, + { + "name": "authz-list", + "parent": "authz" + }, { "name": "ide-drive", "parent": "ide-device" @@ -2308,17 +2334,13 @@ "name": "pvrdma", "parent": "pci-device" }, - { - "name": "isa-pit", - "parent": "pit-common" - }, { "name": "pc-1.2-machine", "parent": "generic-pc-machine" }, { - "name": "vfio-platform", - "parent": "sys-bus-device" + "name": "isa-pit", + "parent": "pit-common" }, { "name": "pxb", @@ -2406,6 +2428,11 @@ "name": "iothread", "type": "link<iothread>" }, + { + "name": "notify_on_empty", + "description": "on/off", + "type": "bool" + }, { "name": "request-merging", "description": "on/off", @@ -2446,6 +2473,11 @@ "name": "rombar", "type": "uint32" }, + { + "name": "write-zeroes", + "description": "on/off", + "type": "bool" + }, { "name": "scsi", "description": "on/off", @@ -2465,11 +2497,19 @@ "description": "A power of two between 512 and 32768", "type": "uint16" }, + { + "name": "bootindex", + "type": "int32" + }, { "name": "indirect_desc", "description": "on/off", "type": "bool" }, + { + "name": "max-write-zeroes-sectors", + "type": "uint32" + }, { "name": "queue-size", "type": "uint16" @@ -2504,8 +2544,9 @@ "type": "BlockdevOnError" }, { - "name": "bootindex", - "type": "int32" + "name": "any_layout", + "description": "on/off", + "type": "bool" }, { "name": "discard_granularity", @@ -2532,9 +2573,8 @@ "type": "bool" }, { - "name": "any_layout", - "description": "on/off", - "type": "bool" + "name": "max-discard-sectors", + "type": "uint32" }, { "name": "x-pcie-lnksta-dllla", @@ -2597,7 +2637,7 @@ "type": "bool" }, { - "name": "notify_on_empty", + "name": "discard", "description": "on/off", "type": "bool" }, @@ -3179,6 +3219,10 @@ "name": "x-pci-vendor-id", "type": "uint32" }, + { + "name": "yres", + "type": "uint32" + }, { "name": "x-pci-sub-device-id", "type": "uint32" @@ -3187,13 +3231,17 @@ "name": "x-no-kvm-ioeventfd", "type": "bool" }, + { + "name": "multifunction", + "description": "on/off", + "type": "bool" + }, { "name": "rombar", "type": "uint32" }, { - "name": "multifunction", - "description": "on/off", + "name": "x-no-kvm-msi", "type": "bool" }, { @@ -3202,8 +3250,8 @@ "type": "bool" }, { - "name": "x-no-kvm-msi", - "type": "bool" + "name": "xres", + "type": "uint32" }, { "name": "x-no-vfio-ioeventfd", @@ -4272,6 +4320,11 @@ "description": "on/off", "type": "bool" }, + { + "name": "edid", + "description": "on/off", + "type": "bool" + }, { "name": "addr", "description": "Slot and optional function number, example: 06.0 or 06", @@ -4372,6 +4425,10 @@ "description": "on/off", "type": "bool" }, + { + "name": "xres", + "type": "uint32" + }, { "name": "yres", "type": "uint32" @@ -4387,7 +4444,7 @@ "type": "bool" }, { - "name": "virgl", + "name": "edid", "description": "on/off", "type": "bool" }, @@ -4396,8 +4453,9 @@ "type": "uint32" }, { - "name": "xres", - "type": "uint32" + "name": "virgl", + "description": "on/off", + "type": "bool" }, { "name": "max_hostmem", @@ -4549,12 +4607,17 @@ "description": "on/off", "type": "bool" }, + { + "name": "x-pcie-lnkctl-init", + "description": "on/off", + "type": "bool" + }, { "name": "disable-modern", "type": "bool" }, { - "name": "x-pcie-lnkctl-init", + "name": "free-page-hint", "description": "on/off", "type": "bool" }, @@ -4602,6 +4665,10 @@ "description": "on/off", "type": "bool" }, + { + "name": "iothread", + "type": "link<iothread>" + }, { "name": "class", "type": "uint32" @@ -4711,11 +4778,20 @@ "name": "guest-stats-polling-interval", "type": "int" }, + { + "name": "iothread", + "type": "link<iothread>" + }, { "name": "event_idx", "description": "on/off", "type": "bool" }, + { + "name": "free-page-hint", + "description": "on/off", + "type": "bool" + }, { "name": "iommu_platform", "description": "on/off", @@ -4850,6 +4926,10 @@ "name": "version", "type": "uint32" }, + { + "name": "x-scalable-mode", + "type": "bool" + }, { "name": "dma-drain", "type": "bool" @@ -5690,13 +5770,11 @@ "avx512f", "avx512dq", "clwb", - "intel-pt", "avx512cd", "avx512bw", "avx512vl", "avx512vbmi", "pku", - "", "avx512vbmi2", "gfni", "vaes", @@ -5705,7 +5783,6 @@ "avx512bitalg", "avx512-vpopcntdq", "la57", - "pconfig", "wbnoinvd", "avx512f", "avx512f", @@ -5719,10 +5796,8 @@ "name": "Icelake-Client", "typename": "Icelake-Client-x86_64-cpu", "unavailable-features": [ - "intel-pt", "avx512vbmi", "pku", - "", "avx512vbmi2", "gfni", "vaes", @@ -5818,12 +5893,10 @@ "avx512f", "avx512dq", "clwb", - "intel-pt", "avx512cd", "avx512bw", "avx512vl", "pku", - "", "avx512vnni", "avx512f", "avx512f", @@ -5955,6 +6028,14 @@ "name": "lossy", "type": "boolean" }, + { + "name": "sasl-authz", + "type": "string" + }, + { + "name": "tls-authz", + "type": "string" + }, { "name": "acl", "type": "boolean" @@ -6873,6 +6954,10 @@ "name": "websocket", "type": "boolean" }, + { + "name": "tls-authz", + "type": "string" + }, { "name": "tls-creds", "type": "string" @@ -7235,7 +7320,7 @@ }, { "state": false, - "capability": "x-multifd" + "capability": "multifd" }, { "state": false, @@ -7248,6 +7333,10 @@ { "state": false, "capability": "late-block-activate" + }, + { + "state": false, + "capability": "x-ignore-shared" } ], "id": "libvirt-43" @@ -7370,7 +7459,7 @@ "arg-type": "0" }, { - "name": "x-block-latency-histogram-set", + "name": "block-latency-histogram-set", "ret-type": "0", "meta-type": "command", "arg-type": "15" @@ -7567,6 +7656,12 @@ "meta-type": "command", "arg-type": "45" }, + { + "name": "x-blockdev-reopen", + "ret-type": "0", + "meta-type": "command", + "arg-type": "45" + }, { "name": "blockdev-del", "ret-type": "0", @@ -7817,50 +7912,56 @@ "meta-type": "event", "arg-type": "91" }, + { + "name": "announce-self", + "ret-type": "0", + "meta-type": "command", + "arg-type": "92" + }, { "name": "RDMA_GID_STATUS_CHANGED", "meta-type": "event", - "arg-type": "92" + "arg-type": "93" }, { "name": "query-rocker", - "ret-type": "94", + "ret-type": "95", "meta-type": "command", - "arg-type": "93" + "arg-type": "94" }, { "name": "query-rocker-ports", - "ret-type": "[96]", + "ret-type": "[97]", "meta-type": "command", - "arg-type": "95" + "arg-type": "96" }, { "name": "query-rocker-of-dpa-flows", - "ret-type": "[98]", + "ret-type": "[99]", "meta-type": "command", - "arg-type": "97" + "arg-type": "98" }, { "name": "query-rocker-of-dpa-groups", - "ret-type": "[100]", + "ret-type": "[101]", "meta-type": "command", - "arg-type": "99" + "arg-type": "100" }, { "name": "query-tpm-models", - "ret-type": "[101]", + "ret-type": "[102]", "meta-type": "command", "arg-type": "0" }, { "name": "query-tpm-types", - "ret-type": "[102]", + "ret-type": "[103]", "meta-type": "command", "arg-type": "0" }, { "name": "query-tpm", - "ret-type": "[103]", + "ret-type": "[104]", "meta-type": "command", "arg-type": "0" }, @@ -7868,40 +7969,40 @@ "name": "set_password", "ret-type": "0", "meta-type": "command", - "arg-type": "104" + "arg-type": "105" }, { "name": "expire_password", "ret-type": "0", "meta-type": "command", - "arg-type": "105" + "arg-type": "106" }, { "name": "screendump", "ret-type": "0", "meta-type": "command", - "arg-type": "106" + "arg-type": "107" }, { "name": "query-spice", - "ret-type": "107", + "ret-type": "108", "meta-type": "command", "arg-type": "0" }, { "name": "SPICE_CONNECTED", "meta-type": "event", - "arg-type": "108" + "arg-type": "109" }, { "name": "SPICE_INITIALIZED", "meta-type": "event", - "arg-type": "109" + "arg-type": "110" }, { "name": "SPICE_DISCONNECTED", "meta-type": "event", - "arg-type": "110" + "arg-type": "111" }, { "name": "SPICE_MIGRATE_COMPLETED", @@ -7910,13 +8011,13 @@ }, { "name": "query-vnc", - "ret-type": "111", + "ret-type": "112", "meta-type": "command", "arg-type": "0" }, { "name": "query-vnc-servers", - "ret-type": "[112]", + "ret-type": "[113]", "meta-type": "command", "arg-type": "0" }, @@ -7924,26 +8025,26 @@ "name": "change-vnc-password", "ret-type": "0", "meta-type": "command", - "arg-type": "113" + "arg-type": "114" }, { "name": "VNC_CONNECTED", "meta-type": "event", - "arg-type": "114" + "arg-type": "115" }, { "name": "VNC_INITIALIZED", "meta-type": "event", - "arg-type": "115" + "arg-type": "116" }, { "name": "VNC_DISCONNECTED", "meta-type": "event", - "arg-type": "116" + "arg-type": "117" }, { "name": "query-mice", - "ret-type": "[117]", + "ret-type": "[118]", "meta-type": "command", "arg-type": "0" }, @@ -7951,23 +8052,23 @@ "name": "send-key", "ret-type": "0", "meta-type": "command", - "arg-type": "118" + "arg-type": "119" }, { "name": "input-send-event", "ret-type": "0", "meta-type": "command", - "arg-type": "119" + "arg-type": "120" }, { "name": "query-display-options", - "ret-type": "120", + "ret-type": "121", "meta-type": "command", "arg-type": "0" }, { "name": "query-migrate", - "ret-type": "121", + "ret-type": "122", "meta-type": "command", "arg-type": "0" }, @@ -7975,11 +8076,11 @@ "name": "migrate-set-capabilities", "ret-type": "0", "meta-type": "command", - "arg-type": "122" + "arg-type": "123" }, { "name": "query-migrate-capabilities", - "ret-type": "[123]", + "ret-type": "[124]", "meta-type": "command", "arg-type": "0" }, @@ -7987,11 +8088,11 @@ "name": "migrate-set-parameters", "ret-type": "0", "meta-type": "command", - "arg-type": "124" + "arg-type": "125" }, { "name": "query-migrate-parameters", - "ret-type": "125", + "ret-type": "126", "meta-type": "command", "arg-type": "0" }, @@ -7999,7 +8100,7 @@ "name": "client_migrate_info", "ret-type": "0", "meta-type": "command", - "arg-type": "126" + "arg-type": "127" }, { "name": "migrate-start-postcopy", @@ -8010,17 +8111,17 @@ { "name": "MIGRATION", "meta-type": "event", - "arg-type": "127" + "arg-type": "128" }, { "name": "MIGRATION_PASS", "meta-type": "event", - "arg-type": "128" + "arg-type": "129" }, { "name": "COLO_EXIT", "meta-type": "event", - "arg-type": "129" + "arg-type": "130" }, { "name": "x-colo-lost-heartbeat", @@ -8038,25 +8139,25 @@ "name": "migrate-continue", "ret-type": "0", "meta-type": "command", - "arg-type": "130" + "arg-type": "131" }, { "name": "migrate_set_downtime", "ret-type": "0", "meta-type": "command", - "arg-type": "131" + "arg-type": "132" }, { "name": "migrate_set_speed", "ret-type": "0", "meta-type": "command", - "arg-type": "132" + "arg-type": "133" }, { "name": "migrate-set-cache-size", "ret-type": "0", "meta-type": "command", - "arg-type": "133" + "arg-type": "134" }, { "name": "query-migrate-cache-size", @@ -8068,29 +8169,29 @@ "name": "migrate", "ret-type": "0", "meta-type": "command", - "arg-type": "134" + "arg-type": "135" }, { "name": "migrate-incoming", "ret-type": "0", "meta-type": "command", - "arg-type": "135" + "arg-type": "136" }, { "name": "xen-save-devices-state", "ret-type": "0", "meta-type": "command", - "arg-type": "136" + "arg-type": "137" }, { "name": "xen-set-replication", "ret-type": "0", "meta-type": "command", - "arg-type": "137" + "arg-type": "138" }, { "name": "query-xen-replication-status", - "ret-type": "138", + "ret-type": "139", "meta-type": "command", "arg-type": "0" }, @@ -8102,7 +8203,7 @@ }, { "name": "query-colo-status", - "ret-type": "139", + "ret-type": "140", "meta-type": "command", "arg-type": "0" }, @@ -8111,7 +8212,7 @@ "ret-type": "0", "allow-oob": true, "meta-type": "command", - "arg-type": "140" + "arg-type": "141" }, { "name": "migrate-pause", @@ -8124,23 +8225,23 @@ "name": "transaction", "ret-type": "0", "meta-type": "command", - "arg-type": "141" + "arg-type": "142" }, { "name": "trace-event-get-state", - "ret-type": "[143]", + "ret-type": "[144]", "meta-type": "command", - "arg-type": "142" + "arg-type": "143" }, { "name": "trace-event-set-state", "ret-type": "0", "meta-type": "command", - "arg-type": "144" + "arg-type": "145" }, { "name": "query-qmp-schema", - "ret-type": "[145]", + "ret-type": "[146]", "meta-type": "command", "arg-type": "0" }, @@ -8148,17 +8249,17 @@ "name": "qmp_capabilities", "ret-type": "0", "meta-type": "command", - "arg-type": "146" + "arg-type": "147" }, { "name": "query-version", - "ret-type": "147", + "ret-type": "148", "meta-type": "command", "arg-type": "0" }, { "name": "query-commands", - "ret-type": "[148]", + "ret-type": "[149]", "meta-type": "command", "arg-type": "0" }, @@ -8166,64 +8267,64 @@ "name": "add_client", "ret-type": "0", "meta-type": "command", - "arg-type": "149" + "arg-type": "150" }, { "name": "query-name", - "ret-type": "150", + "ret-type": "151", "meta-type": "command", "arg-type": "0" }, { "name": "query-kvm", - "ret-type": "151", + "ret-type": "152", "meta-type": "command", "arg-type": "0" }, { "name": "query-uuid", - "ret-type": "152", + "ret-type": "153", "meta-type": "command", "arg-type": "0" }, { "name": "query-events", - "ret-type": "[153]", + "ret-type": "[154]", "meta-type": "command", "arg-type": "0" }, { "name": "query-cpus", - "ret-type": "[154]", + "ret-type": "[155]", "meta-type": "command", "arg-type": "0" }, { "name": "query-cpus-fast", - "ret-type": "[155]", + "ret-type": "[156]", "meta-type": "command", "arg-type": "0" }, { "name": "query-iothreads", - "ret-type": "[156]", + "ret-type": "[157]", "meta-type": "command", "arg-type": "0" }, { "name": "query-balloon", - "ret-type": "157", + "ret-type": "158", "meta-type": "command", "arg-type": "0" }, { "name": "BALLOON_CHANGE", "meta-type": "event", - "arg-type": "158" + "arg-type": "159" }, { "name": "query-pci", - "ret-type": "[159]", + "ret-type": "[160]", "meta-type": "command", "arg-type": "0" }, @@ -8255,19 +8356,19 @@ "name": "cpu-add", "ret-type": "0", "meta-type": "command", - "arg-type": "160" + "arg-type": "161" }, { "name": "memsave", "ret-type": "0", "meta-type": "command", - "arg-type": "161" + "arg-type": "162" }, { "name": "pmemsave", "ret-type": "0", "meta-type": "command", - "arg-type": "162" + "arg-type": "163" }, { "name": "cont", @@ -8297,108 +8398,102 @@ "name": "balloon", "ret-type": "0", "meta-type": "command", - "arg-type": "163" + "arg-type": "164" }, { "name": "human-monitor-command", "ret-type": "str", "meta-type": "command", - "arg-type": "164" + "arg-type": "165" }, { "name": "qom-list", - "ret-type": "[166]", + "ret-type": "[167]", "meta-type": "command", - "arg-type": "165" + "arg-type": "166" }, { "name": "qom-get", "ret-type": "any", "meta-type": "command", - "arg-type": "167" + "arg-type": "168" }, { "name": "qom-set", "ret-type": "0", "meta-type": "command", - "arg-type": "168" + "arg-type": "169" }, { "name": "change", "ret-type": "0", "meta-type": "command", - "arg-type": "169" + "arg-type": "170" }, { "name": "qom-list-types", - "ret-type": "[171]", + "ret-type": "[172]", "meta-type": "command", - "arg-type": "170" + "arg-type": "171" }, { "name": "device-list-properties", - "ret-type": "[166]", + "ret-type": "[167]", "meta-type": "command", - "arg-type": "172" + "arg-type": "173" }, { "name": "qom-list-properties", - "ret-type": "[166]", + "ret-type": "[167]", "meta-type": "command", - "arg-type": "173" + "arg-type": "174" }, { "name": "xen-set-global-dirty-log", "ret-type": "0", "meta-type": "command", - "arg-type": "174" + "arg-type": "175" }, { "name": "device_add", "ret-type": "0", "meta-type": "command", - "arg-type": "175" + "arg-type": "176" }, { "name": "device_del", "ret-type": "0", "meta-type": "command", - "arg-type": "176" + "arg-type": "177" }, { "name": "DEVICE_DELETED", "meta-type": "event", - "arg-type": "177" + "arg-type": "178" }, { "name": "dump-guest-memory", "ret-type": "0", "meta-type": "command", - "arg-type": "178" + "arg-type": "179" }, { "name": "query-dump", - "ret-type": "179", + "ret-type": "180", "meta-type": "command", "arg-type": "0" }, { "name": "DUMP_COMPLETED", "meta-type": "event", - "arg-type": "180" + "arg-type": "181" }, { "name": "query-dump-guest-memory-capability", - "ret-type": "181", + "ret-type": "182", "meta-type": "command", "arg-type": "0" }, - { - "name": "dump-skeys", - "ret-type": "0", - "meta-type": "command", - "arg-type": "182" - }, { "name": "object-add", "ret-type": "0", @@ -8441,146 +8536,128 @@ "meta-type": "command", "arg-type": "0" }, - { - "name": "query-cpu-definitions", - "ret-type": "[190]", - "meta-type": "command", - "arg-type": "0" - }, - { - "name": "query-cpu-model-expansion", - "ret-type": "192", - "meta-type": "command", - "arg-type": "191" - }, - { - "name": "query-cpu-model-comparison", - "ret-type": "194", - "meta-type": "command", - "arg-type": "193" - }, - { - "name": "query-cpu-model-baseline", - "ret-type": "196", - "meta-type": "command", - "arg-type": "195" - }, { "name": "add-fd", - "ret-type": "198", + "ret-type": "191", "meta-type": "command", - "arg-type": "197" + "arg-type": "190" }, { "name": "remove-fd", "ret-type": "0", "meta-type": "command", - "arg-type": "199" + "arg-type": "192" }, { "name": "query-fdsets", - "ret-type": "[200]", + "ret-type": "[193]", "meta-type": "command", "arg-type": "0" }, { "name": "query-target", - "ret-type": "201", + "ret-type": "194", "meta-type": "command", "arg-type": "0" }, { "name": "query-command-line-options", - "ret-type": "[203]", + "ret-type": "[196]", "meta-type": "command", - "arg-type": "202" + "arg-type": "195" }, { "name": "query-memdev", - "ret-type": "[204]", + "ret-type": "[197]", "meta-type": "command", "arg-type": "0" }, { "name": "query-memory-devices", - "ret-type": "[205]", + "ret-type": "[198]", "meta-type": "command", "arg-type": "0" }, { "name": "MEM_UNPLUG_ERROR", "meta-type": "event", - "arg-type": "206" + "arg-type": "199" }, { "name": "query-acpi-ospm-status", - "ret-type": "[207]", + "ret-type": "[200]", "meta-type": "command", "arg-type": "0" }, { "name": "ACPI_DEVICE_OST", "meta-type": "event", - "arg-type": "208" + "arg-type": "201" }, { - "name": "rtc-reset-reinjection", + "name": "xen-load-devices-state", "ret-type": "0", "meta-type": "command", - "arg-type": "0" - }, - { - "name": "RTC_CHANGE", - "meta-type": "event", - "arg-type": "209" + "arg-type": "202" }, { - "name": "xen-load-devices-state", - "ret-type": "0", + "name": "query-hotpluggable-cpus", + "ret-type": "[203]", "meta-type": "command", - "arg-type": "210" + "arg-type": "0" }, { - "name": "query-gic-capabilities", - "ret-type": "[211]", + "name": "query-vm-generation-id", + "ret-type": "204", "meta-type": "command", "arg-type": "0" }, { - "name": "query-hotpluggable-cpus", - "ret-type": "[212]", + "name": "set-numa-node", + "ret-type": "0", "meta-type": "command", - "arg-type": "0" + "arg-type": "205" }, { - "name": "query-vm-generation-id", - "ret-type": "213", + "name": "RTC_CHANGE", + "meta-type": "event", + "arg-type": "206" + }, + { + "name": "rtc-reset-reinjection", + "ret-type": "0", "meta-type": "command", "arg-type": "0" }, { "name": "query-sev", - "ret-type": "214", + "ret-type": "207", "meta-type": "command", "arg-type": "0" }, { "name": "query-sev-launch-measure", - "ret-type": "215", + "ret-type": "208", "meta-type": "command", "arg-type": "0" }, { "name": "query-sev-capabilities", - "ret-type": "216", + "ret-type": "209", "meta-type": "command", "arg-type": "0" }, { - "name": "set-numa-node", - "ret-type": "0", + "name": "query-cpu-model-expansion", + "ret-type": "217", + "meta-type": "command", + "arg-type": "216" + }, + { + "name": "query-cpu-definitions", + "ret-type": "[218]", "meta-type": "command", - "arg-type": "217" + "arg-type": "0" }, { "name": "0", @@ -8601,7 +8678,7 @@ }, { "name": "status", - "type": "218" + "type": "219" } ], "meta-type": "object" @@ -8615,7 +8692,7 @@ }, { "name": "reason", - "type": "219" + "type": "220" } ], "meta-type": "object" @@ -8629,7 +8706,7 @@ }, { "name": "reason", - "type": "219" + "type": "220" } ], "meta-type": "object" @@ -8639,7 +8716,7 @@ "members": [ { "name": "action", - "type": "220" + "type": "221" } ], "meta-type": "object" @@ -8649,7 +8726,7 @@ "members": [ { "name": "action", - "type": "220" + "type": "221" } ], "meta-type": "object" @@ -8659,12 +8736,12 @@ "members": [ { "name": "action", - "type": "221" + "type": "222" }, { "name": "info", "default": null, - "type": "222" + "type": "223" } ], "meta-type": "object" @@ -8678,7 +8755,7 @@ }, { "name": "status", - "type": "223" + "type": "224" } ], "meta-type": "object" @@ -8757,11 +8834,11 @@ }, { "name": "type", - "type": "224" + "type": "225" }, { "name": "status", - "type": "223" + "type": "224" }, { "name": "current-progress", @@ -8783,7 +8860,7 @@ "name": "15", "members": [ { - "name": "device", + "name": "id", "type": "str" }, { @@ -8851,12 +8928,12 @@ { "name": "io-status", "default": null, - "type": "225" + "type": "226" }, { "name": "dirty-bitmaps", "default": null, - "type": "[226]" + "type": "[227]" } ], "meta-type": "object" @@ -8897,7 +8974,7 @@ }, { "name": "stats", - "type": "227" + "type": "228" }, { "name": "parent", @@ -8950,7 +9027,7 @@ }, { "name": "io-status", - "type": "225" + "type": "226" }, { "name": "ready", @@ -8958,7 +9035,7 @@ }, { "name": "status", - "type": "223" + "type": "224" }, { "name": "auto-finalize", @@ -9046,7 +9123,7 @@ { "name": "mode", "default": null, - "type": "228" + "type": "229" } ], "meta-type": "object" @@ -9166,12 +9243,12 @@ }, { "name": "sync", - "type": "229" + "type": "230" }, { "name": "mode", "default": null, - "type": "228" + "type": "229" }, { "name": "speed", @@ -9191,12 +9268,12 @@ { "name": "on-source-error", "default": null, - "type": "230" + "type": "231" }, { "name": "on-target-error", "default": null, - "type": "230" + "type": "231" }, { "name": "auto-finalize", @@ -9229,7 +9306,7 @@ }, { "name": "sync", - "type": "229" + "type": "230" }, { "name": "speed", @@ -9249,12 +9326,12 @@ { "name": "on-source-error", "default": null, - "type": "230" + "type": "231" }, { "name": "on-target-error", "default": null, - "type": "230" + "type": "231" }, { "name": "auto-finalize", @@ -9313,7 +9390,7 @@ }, { "name": "detect_zeroes", - "type": "231" + "type": "232" }, { "name": "bps", @@ -9341,7 +9418,7 @@ }, { "name": "image", - "type": "232" + "type": "233" }, { "name": "bps_max", @@ -9415,7 +9492,7 @@ }, { "name": "cache", - "type": "233" + "type": "234" }, { "name": "write_threshold", @@ -9429,11 +9506,11 @@ "members": [ { "name": "nodes", - "type": "[234]" + "type": "[235]" }, { "name": "edges", - "type": "[235]" + "type": "[236]" } ], "meta-type": "object" @@ -9471,12 +9548,12 @@ }, { "name": "sync", - "type": "229" + "type": "230" }, { "name": "mode", "default": null, - "type": "228" + "type": "229" }, { "name": "speed", @@ -9496,12 +9573,12 @@ { "name": "on-source-error", "default": null, - "type": "230" + "type": "231" }, { "name": "on-target-error", "default": null, - "type": "230" + "type": "231" }, { "name": "unmap", @@ -9511,7 +9588,7 @@ { "name": "copy-mode", "default": null, - "type": "236" + "type": "237" }, { "name": "auto-finalize", @@ -9625,7 +9702,7 @@ }, { "name": "sync", - "type": "229" + "type": "230" }, { "name": "speed", @@ -9645,12 +9722,12 @@ { "name": "on-source-error", "default": null, - "type": "230" + "type": "231" }, { "name": "on-target-error", "default": null, - "type": "230" + "type": "231" }, { "name": "filter-node-name", @@ -9660,7 +9737,7 @@ { "name": "copy-mode", "default": null, - "type": "236" + "type": "237" }, { "name": "auto-finalize", @@ -9820,7 +9897,7 @@ { "name": "on-error", "default": null, - "type": "230" + "type": "231" }, { "name": "auto-finalize", @@ -9920,165 +9997,165 @@ "variants": [ { "case": "blkdebug", - "type": "240" + "type": "241" }, { "case": "blklogwrites", - "type": "241" + "type": "242" }, { "case": "blkverify", - "type": "242" + "type": "243" }, { "case": "bochs", - "type": "243" + "type": "244" }, { "case": "cloop", - "type": "243" + "type": "244" }, { "case": "copy-on-read", - "type": "243" + "type": "244" }, { "case": "dmg", - "type": "243" + "type": "244" }, { "case": "file", - "type": "244" + "type": "245" }, { "case": "ftp", - "type": "245" + "type": "246" }, { "case": "ftps", - "type": "246" + "type": "247" }, { "case": "gluster", - "type": "247" + "type": "248" }, { "case": "host_cdrom", - "type": "244" + "type": "245" }, { "case": "host_device", - "type": "244" + "type": "245" }, { "case": "http", - "type": "248" + "type": "249" }, { "case": "https", - "type": "249" + "type": "250" }, { "case": "iscsi", - "type": "250" + "type": "251" }, { "case": "luks", - "type": "251" + "type": "252" }, { "case": "nbd", - "type": "252" + "type": "253" }, { "case": "nfs", - "type": "253" + "type": "254" }, { "case": "null-aio", - "type": "254" + "type": "255" }, { "case": "null-co", - "type": "254" + "type": "255" }, { "case": "nvme", - "type": "255" + "type": "256" }, { "case": "parallels", - "type": "243" + "type": "244" }, { "case": "qcow2", - "type": "256" + "type": "257" }, { "case": "qcow", - "type": "257" + "type": "258" }, { "case": "qed", - "type": "258" + "type": "259" }, { "case": "quorum", - "type": "259" + "type": "260" }, { "case": "raw", - "type": "260" + "type": "261" }, { "case": "rbd", - "type": "261" + "type": "262" }, { "case": "replication", - "type": "262" + "type": "263" }, { "case": "sheepdog", - "type": "263" + "type": "264" }, { "case": "ssh", - "type": "264" + "type": "265" }, { "case": "throttle", - "type": "265" + "type": "266" }, { "case": "vdi", - "type": "243" + "type": "244" }, { "case": "vhdx", - "type": "243" + "type": "244" }, { "case": "vmdk", - "type": "258" + "type": "259" }, { "case": "vpc", - "type": "243" + "type": "244" }, { "case": "vvfat", - "type": "266" + "type": "267" }, { "case": "vxhs", - "type": "267" + "type": "268" } ], "members": [ { "name": "driver", - "type": "237" + "type": "238" }, { "name": "node-name", @@ -10088,12 +10165,12 @@ { "name": "discard", "default": null, - "type": "238" + "type": "239" }, { "name": "cache", "default": null, - "type": "239" + "type": "240" }, { "name": "read-only", @@ -10113,7 +10190,7 @@ { "name": "detect-zeroes", "default": null, - "type": "231" + "type": "232" } ], "meta-type": "object" @@ -10137,7 +10214,7 @@ }, { "name": "options", - "type": "268" + "type": "269" } ], "meta-type": "object" @@ -10228,7 +10305,7 @@ { "name": "read-only-mode", "default": null, - "type": "269" + "type": "270" } ], "meta-type": "object" @@ -10280,11 +10357,11 @@ }, { "name": "operation", - "type": "270" + "type": "271" }, { "name": "action", - "type": "271" + "type": "272" }, { "name": "nospace", @@ -10303,7 +10380,7 @@ "members": [ { "name": "type", - "type": "224" + "type": "225" }, { "name": "device", @@ -10334,7 +10411,7 @@ "members": [ { "name": "type", - "type": "224" + "type": "225" }, { "name": "device", @@ -10364,11 +10441,11 @@ }, { "name": "operation", - "type": "270" + "type": "271" }, { "name": "action", - "type": "271" + "type": "272" } ], "meta-type": "object" @@ -10378,7 +10455,7 @@ "members": [ { "name": "type", - "type": "224" + "type": "225" }, { "name": "device", @@ -10404,7 +10481,7 @@ "members": [ { "name": "type", - "type": "224" + "type": "225" }, { "name": "id", @@ -10474,7 +10551,7 @@ }, { "name": "iothread", - "type": "272" + "type": "273" }, { "name": "force", @@ -10597,12 +10674,17 @@ "members": [ { "name": "addr", - "type": "273" + "type": "274" }, { "name": "tls-creds", "default": null, "type": "str" + }, + { + "name": "tls-authz", + "default": null, + "type": "str" } ], "meta-type": "object" @@ -10642,7 +10724,7 @@ { "name": "mode", "default": null, - "type": "274" + "type": "275" } ], "meta-type": "object" @@ -10702,7 +10784,7 @@ "members": [ { "name": "type", - "type": "275" + "type": "276" }, { "name": "error", @@ -10776,7 +10858,7 @@ { "name": "format", "default": null, - "type": "276" + "type": "277" } ], "meta-type": "object" @@ -10795,7 +10877,7 @@ { "name": "format", "default": null, - "type": "276" + "type": "277" } ], "meta-type": "object" @@ -10814,7 +10896,7 @@ }, { "name": "backend", - "type": "277" + "type": "278" } ], "meta-type": "object" @@ -10839,7 +10921,7 @@ }, { "name": "backend", - "type": "277" + "type": "278" } ], "meta-type": "object" @@ -10945,15 +11027,15 @@ }, { "name": "multicast", - "type": "278" + "type": "279" }, { "name": "unicast", - "type": "278" + "type": "279" }, { "name": "vlan", - "type": "278" + "type": "279" }, { "name": "broadcast-allowed", @@ -11003,6 +11085,28 @@ }, { "name": "92", + "members": [ + { + "name": "initial", + "type": "int" + }, + { + "name": "max", + "type": "int" + }, + { + "name": "rounds", + "type": "int" + }, + { + "name": "step", + "type": "int" + } + ], + "meta-type": "object" + }, + { + "name": "93", "members": [ { "name": "netdev", @@ -11024,7 +11128,7 @@ "meta-type": "object" }, { - "name": "93", + "name": "94", "members": [ { "name": "name", @@ -11034,7 +11138,7 @@ "meta-type": "object" }, { - "name": "94", + "name": "95", "members": [ { "name": "name", @@ -11052,7 +11156,7 @@ "meta-type": "object" }, { - "name": "95", + "name": "96", "members": [ { "name": "name", @@ -11062,12 +11166,12 @@ "meta-type": "object" }, { - "name": "[96]", - "element-type": "96", + "name": "[97]", + "element-type": "97", "meta-type": "array" }, { - "name": "96", + "name": "97", "members": [ { "name": "name", @@ -11087,17 +11191,17 @@ }, { "name": "duplex", - "type": "279" + "type": "280" }, { "name": "autoneg", - "type": "280" + "type": "281" } ], "meta-type": "object" }, { - "name": "97", + "name": "98", "members": [ { "name": "name", @@ -11112,12 +11216,12 @@ "meta-type": "object" }, { - "name": "[98]", - "element-type": "98", + "name": "[99]", + "element-type": "99", "meta-type": "array" }, { - "name": "98", + "name": "99", "members": [ { "name": "cookie", @@ -11129,21 +11233,21 @@ }, { "name": "key", - "type": "281" + "type": "282" }, { "name": "mask", - "type": "282" + "type": "283" }, { "name": "action", - "type": "283" + "type": "284" } ], "meta-type": "object" }, { - "name": "99", + "name": "100", "members": [ { "name": "name", @@ -11158,12 +11262,12 @@ "meta-type": "object" }, { - "name": "[100]", - "element-type": "100", + "name": "[101]", + "element-type": "101", "meta-type": "array" }, { - "name": "100", + "name": "101", "members": [ { "name": "id", @@ -11232,12 +11336,12 @@ "meta-type": "object" }, { - "name": "[101]", - "element-type": "101", + "name": "[102]", + "element-type": "102", "meta-type": "array" }, { - "name": "101", + "name": "102", "meta-type": "enum", "values": [ "tpm-tis", @@ -11245,12 +11349,12 @@ ] }, { - "name": "[102]", - "element-type": "102", + "name": "[103]", + "element-type": "103", "meta-type": "array" }, { - "name": "102", + "name": "103", "meta-type": "enum", "values": [ "passthrough", @@ -11258,12 +11362,12 @@ ] }, { - "name": "[103]", - "element-type": "103", + "name": "[104]", + "element-type": "104", "meta-type": "array" }, { - "name": "103", + "name": "104", "members": [ { "name": "id", @@ -11271,17 +11375,17 @@ }, { "name": "model", - "type": "101" + "type": "102" }, { "name": "options", - "type": "284" + "type": "285" } ], "meta-type": "object" }, { - "name": "104", + "name": "105", "members": [ { "name": "protocol", @@ -11300,7 +11404,7 @@ "meta-type": "object" }, { - "name": "105", + "name": "106", "members": [ { "name": "protocol", @@ -11314,7 +11418,7 @@ "meta-type": "object" }, { - "name": "106", + "name": "107", "members": [ { "name": "filename", @@ -11334,7 +11438,7 @@ "meta-type": "object" }, { - "name": "107", + "name": "108", "members": [ { "name": "enabled", @@ -11371,60 +11475,60 @@ }, { "name": "mouse-mode", - "type": "285" + "type": "286" }, { "name": "channels", "default": null, - "type": "[286]" + "type": "[287]" } ], "meta-type": "object" }, { - "name": "108", + "name": "109", "members": [ { "name": "server", - "type": "287" + "type": "288" }, { "name": "client", - "type": "287" + "type": "288" } ], "meta-type": "object" }, { - "name": "109", + "name": "110", "members": [ { "name": "server", - "type": "288" + "type": "289" }, { "name": "client", - "type": "286" + "type": "287" } ], "meta-type": "object" }, { - "name": "110", + "name": "111", "members": [ { "name": "server", - "type": "287" + "type": "288" }, { "name": "client", - "type": "287" + "type": "288" } ], "meta-type": "object" }, { - "name": "111", + "name": "112", "members": [ { "name": "enabled", @@ -11438,7 +11542,7 @@ { "name": "family", "default": null, - "type": "289" + "type": "290" }, { "name": "service", @@ -11453,18 +11557,18 @@ { "name": "clients", "default": null, - "type": "[290]" + "type": "[291]" } ], "meta-type": "object" }, { - "name": "[112]", - "element-type": "112", + "name": "[113]", + "element-type": "113", "meta-type": "array" }, { - "name": "112", + "name": "113", "members": [ { "name": "id", @@ -11472,20 +11576,20 @@ }, { "name": "server", - "type": "[291]" + "type": "[292]" }, { "name": "clients", - "type": "[290]" + "type": "[291]" }, { "name": "auth", - "type": "292" + "type": "293" }, { "name": "vencrypt", "default": null, - "type": "293" + "type": "294" }, { "name": "display", @@ -11496,7 +11600,7 @@ "meta-type": "object" }, { - "name": "113", + "name": "114", "members": [ { "name": "password", @@ -11506,54 +11610,54 @@ "meta-type": "object" }, { - "name": "114", + "name": "115", "members": [ { "name": "server", - "type": "294" + "type": "295" }, { "name": "client", - "type": "295" + "type": "296" } ], "meta-type": "object" }, { - "name": "115", + "name": "116", "members": [ { "name": "server", - "type": "294" + "type": "295" }, { "name": "client", - "type": "290" + "type": "291" } ], "meta-type": "object" }, { - "name": "116", + "name": "117", "members": [ { "name": "server", - "type": "294" + "type": "295" }, { "name": "client", - "type": "290" + "type": "291" } ], "meta-type": "object" }, { - "name": "[117]", - "element-type": "117", + "name": "[118]", + "element-type": "118", "meta-type": "array" }, { - "name": "117", + "name": "118", "members": [ { "name": "name", @@ -11575,11 +11679,11 @@ "meta-type": "object" }, { - "name": "118", + "name": "119", "members": [ { "name": "keys", - "type": "[296]" + "type": "[297]" }, { "name": "hold-time", @@ -11590,7 +11694,7 @@ "meta-type": "object" }, { - "name": "119", + "name": "120", "members": [ { "name": "device", @@ -11604,22 +11708,26 @@ }, { "name": "events", - "type": "[297]" + "type": "[298]" } ], "meta-type": "object" }, { - "name": "120", + "name": "121", "tag": "type", "variants": [ { "case": "gtk", - "type": "300" + "type": "301" + }, + { + "case": "curses", + "type": "302" }, { "case": "egl-headless", - "type": "301" + "type": "303" }, { "case": "default", @@ -11634,18 +11742,18 @@ "type": "0" }, { - "case": "curses", + "case": "cocoa", "type": "0" }, { - "case": "cocoa", + "case": "spice-app", "type": "0" } ], "members": [ { "name": "type", - "type": "298" + "type": "299" }, { "name": "full-screen", @@ -11660,33 +11768,33 @@ { "name": "gl", "default": null, - "type": "299" + "type": "300" } ], "meta-type": "object" }, { - "name": "121", + "name": "122", "members": [ { "name": "status", "default": null, - "type": "302" + "type": "304" }, { "name": "ram", "default": null, - "type": "303" + "type": "305" }, { "name": "disk", "default": null, - "type": "303" + "type": "305" }, { "name": "xbzrle-cache", "default": null, - "type": "304" + "type": "306" }, { "name": "total-time", @@ -11731,32 +11839,37 @@ { "name": "compression", "default": null, - "type": "305" + "type": "307" + }, + { + "name": "socket-address", + "default": null, + "type": "[308]" } ], "meta-type": "object" }, { - "name": "122", + "name": "123", "members": [ { "name": "capabilities", - "type": "[123]" + "type": "[124]" } ], "meta-type": "object" }, { - "name": "[123]", - "element-type": "123", + "name": "[124]", + "element-type": "124", "meta-type": "array" }, { - "name": "123", + "name": "124", "members": [ { "name": "capability", - "type": "306" + "type": "309" }, { "name": "state", @@ -11766,8 +11879,28 @@ "meta-type": "object" }, { - "name": "124", + "name": "125", "members": [ + { + "name": "announce-initial", + "default": null, + "type": "int" + }, + { + "name": "announce-max", + "default": null, + "type": "int" + }, + { + "name": "announce-rounds", + "default": null, + "type": "int" + }, + { + "name": "announce-step", + "default": null, + "type": "int" + }, { "name": "compress-level", "default": null, @@ -11801,12 +11934,17 @@ { "name": "tls-creds", "default": null, - "type": "272" + "type": "273" }, { "name": "tls-hostname", "default": null, - "type": "272" + "type": "273" + }, + { + "name": "tls-authz", + "default": null, + "type": "273" }, { "name": "max-bandwidth", @@ -11829,12 +11967,7 @@ "type": "bool" }, { - "name": "x-multifd-channels", - "default": null, - "type": "int" - }, - { - "name": "x-multifd-page-count", + "name": "multifd-channels", "default": null, "type": "int" }, @@ -11857,8 +11990,28 @@ "meta-type": "object" }, { - "name": "125", + "name": "126", "members": [ + { + "name": "announce-initial", + "default": null, + "type": "int" + }, + { + "name": "announce-max", + "default": null, + "type": "int" + }, + { + "name": "announce-rounds", + "default": null, + "type": "int" + }, + { + "name": "announce-step", + "default": null, + "type": "int" + }, { "name": "compress-level", "default": null, @@ -11899,6 +12052,11 @@ "default": null, "type": "str" }, + { + "name": "tls-authz", + "default": null, + "type": "str" + }, { "name": "max-bandwidth", "default": null, @@ -11920,12 +12078,7 @@ "type": "bool" }, { - "name": "x-multifd-channels", - "default": null, - "type": "int" - }, - { - "name": "x-multifd-page-count", + "name": "multifd-channels", "default": null, "type": "int" }, @@ -11948,7 +12101,7 @@ "meta-type": "object" }, { - "name": "126", + "name": "127", "members": [ { "name": "protocol", @@ -11977,17 +12130,17 @@ "meta-type": "object" }, { - "name": "127", + "name": "128", "members": [ { "name": "status", - "type": "302" + "type": "304" } ], "meta-type": "object" }, { - "name": "128", + "name": "129", "members": [ { "name": "pass", @@ -11997,31 +12150,31 @@ "meta-type": "object" }, { - "name": "129", + "name": "130", "members": [ { "name": "mode", - "type": "307" + "type": "310" }, { "name": "reason", - "type": "308" + "type": "311" } ], "meta-type": "object" }, { - "name": "130", + "name": "131", "members": [ { "name": "state", - "type": "302" + "type": "304" } ], "meta-type": "object" }, { - "name": "131", + "name": "132", "members": [ { "name": "value", @@ -12031,7 +12184,7 @@ "meta-type": "object" }, { - "name": "132", + "name": "133", "members": [ { "name": "value", @@ -12041,7 +12194,7 @@ "meta-type": "object" }, { - "name": "133", + "name": "134", "members": [ { "name": "value", @@ -12056,7 +12209,7 @@ "meta-type": "builtin" }, { - "name": "134", + "name": "135", "members": [ { "name": "uri", @@ -12086,7 +12239,7 @@ "meta-type": "object" }, { - "name": "135", + "name": "136", "members": [ { "name": "uri", @@ -12096,7 +12249,7 @@ "meta-type": "object" }, { - "name": "136", + "name": "137", "members": [ { "name": "filename", @@ -12111,7 +12264,7 @@ "meta-type": "object" }, { - "name": "137", + "name": "138", "members": [ { "name": "enable", @@ -12130,7 +12283,7 @@ "meta-type": "object" }, { - "name": "138", + "name": "139", "members": [ { "name": "error", @@ -12145,21 +12298,25 @@ "meta-type": "object" }, { - "name": "139", + "name": "140", "members": [ { "name": "mode", - "type": "307" + "type": "310" + }, + { + "name": "last-mode", + "type": "310" }, { "name": "reason", - "type": "308" + "type": "311" } ], "meta-type": "object" }, { - "name": "140", + "name": "141", "members": [ { "name": "uri", @@ -12169,22 +12326,22 @@ "meta-type": "object" }, { - "name": "141", + "name": "142", "members": [ { "name": "actions", - "type": "[309]" + "type": "[312]" }, { "name": "properties", "default": null, - "type": "310" + "type": "313" } ], "meta-type": "object" }, { - "name": "142", + "name": "143", "members": [ { "name": "name", @@ -12199,12 +12356,12 @@ "meta-type": "object" }, { - "name": "[143]", - "element-type": "143", + "name": "[144]", + "element-type": "144", "meta-type": "array" }, { - "name": "143", + "name": "144", "members": [ { "name": "name", @@ -12212,7 +12369,7 @@ }, { "name": "state", - "type": "311" + "type": "314" }, { "name": "vcpu", @@ -12222,7 +12379,7 @@ "meta-type": "object" }, { - "name": "144", + "name": "145", "members": [ { "name": "name", @@ -12246,41 +12403,41 @@ "meta-type": "object" }, { - "name": "[145]", - "element-type": "145", + "name": "[146]", + "element-type": "146", "meta-type": "array" }, { - "name": "145", + "name": "146", "tag": "meta-type", "variants": [ { "case": "builtin", - "type": "313" + "type": "316" }, { "case": "enum", - "type": "314" + "type": "317" }, { "case": "array", - "type": "315" + "type": "318" }, { "case": "object", - "type": "316" + "type": "319" }, { "case": "alternate", - "type": "317" + "type": "320" }, { "case": "command", - "type": "318" + "type": "321" }, { "case": "event", - "type": "319" + "type": "322" } ], "members": [ @@ -12290,28 +12447,28 @@ }, { "name": "meta-type", - "type": "312" + "type": "315" } ], "meta-type": "object" }, { - "name": "146", + "name": "147", "members": [ { "name": "enable", "default": null, - "type": "[320]" + "type": "[323]" } ], "meta-type": "object" }, { - "name": "147", + "name": "148", "members": [ { "name": "qemu", - "type": "321" + "type": "324" }, { "name": "package", @@ -12321,12 +12478,12 @@ "meta-type": "object" }, { - "name": "[148]", - "element-type": "148", + "name": "[149]", + "element-type": "149", "meta-type": "array" }, { - "name": "148", + "name": "149", "members": [ { "name": "name", @@ -12336,7 +12493,7 @@ "meta-type": "object" }, { - "name": "149", + "name": "150", "members": [ { "name": "protocol", @@ -12360,7 +12517,7 @@ "meta-type": "object" }, { - "name": "150", + "name": "151", "members": [ { "name": "name", @@ -12371,7 +12528,7 @@ "meta-type": "object" }, { - "name": "151", + "name": "152", "members": [ { "name": "enabled", @@ -12385,7 +12542,7 @@ "meta-type": "object" }, { - "name": "152", + "name": "153", "members": [ { "name": "UUID", @@ -12395,12 +12552,12 @@ "meta-type": "object" }, { - "name": "[153]", - "element-type": "153", + "name": "[154]", + "element-type": "154", "meta-type": "array" }, { - "name": "153", + "name": "154", "members": [ { "name": "name", @@ -12410,41 +12567,41 @@ "meta-type": "object" }, { - "name": "[154]", - "element-type": "154", + "name": "[155]", + "element-type": "155", "meta-type": "array" }, { - "name": "154", + "name": "155", "tag": "arch", "variants": [ { "case": "x86", - "type": "324" + "type": "327" }, { "case": "sparc", - "type": "325" + "type": "328" }, { "case": "ppc", - "type": "326" + "type": "329" }, { "case": "mips", - "type": "327" + "type": "330" }, { "case": "tricore", - "type": "328" + "type": "331" }, { "case": "s390", - "type": "329" + "type": "332" }, { "case": "riscv", - "type": "330" + "type": "333" }, { "case": "other", @@ -12475,27 +12632,27 @@ { "name": "props", "default": null, - "type": "322" + "type": "325" }, { "name": "arch", - "type": "323" + "type": "326" } ], "meta-type": "object" }, { - "name": "[155]", - "element-type": "155", + "name": "[156]", + "element-type": "156", "meta-type": "array" }, { - "name": "155", + "name": "156", "tag": "target", "variants": [ { "case": "s390x", - "type": "329" + "type": "332" }, { "case": "aarch64", @@ -12634,26 +12791,26 @@ { "name": "props", "default": null, - "type": "322" + "type": "325" }, { "name": "arch", - "type": "323" + "type": "326" }, { "name": "target", - "type": "331" + "type": "334" } ], "meta-type": "object" }, { - "name": "[156]", - "element-type": "156", + "name": "[157]", + "element-type": "157", "meta-type": "array" }, { - "name": "156", + "name": "157", "members": [ { "name": "id", @@ -12679,7 +12836,7 @@ "meta-type": "object" }, { - "name": "157", + "name": "158", "members": [ { "name": "actual", @@ -12689,7 +12846,7 @@ "meta-type": "object" }, { - "name": "158", + "name": "159", "members": [ { "name": "actual", @@ -12699,12 +12856,12 @@ "meta-type": "object" }, { - "name": "[159]", - "element-type": "159", + "name": "[160]", + "element-type": "160", "meta-type": "array" }, { - "name": "159", + "name": "160", "members": [ { "name": "bus", @@ -12712,13 +12869,13 @@ }, { "name": "devices", - "type": "[332]" + "type": "[335]" } ], "meta-type": "object" }, { - "name": "160", + "name": "161", "members": [ { "name": "id", @@ -12728,7 +12885,7 @@ "meta-type": "object" }, { - "name": "161", + "name": "162", "members": [ { "name": "val", @@ -12751,7 +12908,7 @@ "meta-type": "object" }, { - "name": "162", + "name": "163", "members": [ { "name": "val", @@ -12769,7 +12926,7 @@ "meta-type": "object" }, { - "name": "163", + "name": "164", "members": [ { "name": "value", @@ -12779,7 +12936,7 @@ "meta-type": "object" }, { - "name": "164", + "name": "165", "members": [ { "name": "command-line", @@ -12794,7 +12951,7 @@ "meta-type": "object" }, { - "name": "165", + "name": "166", "members": [ { "name": "path", @@ -12804,12 +12961,12 @@ "meta-type": "object" }, { - "name": "[166]", - "element-type": "166", + "name": "[167]", + "element-type": "167", "meta-type": "array" }, { - "name": "166", + "name": "167", "members": [ { "name": "name", @@ -12828,7 +12985,7 @@ "meta-type": "object" }, { - "name": "167", + "name": "168", "members": [ { "name": "path", @@ -12847,7 +13004,7 @@ "meta-type": "builtin" }, { - "name": "168", + "name": "169", "members": [ { "name": "path", @@ -12865,7 +13022,7 @@ "meta-type": "object" }, { - "name": "169", + "name": "170", "members": [ { "name": "device", @@ -12884,7 +13041,7 @@ "meta-type": "object" }, { - "name": "170", + "name": "171", "members": [ { "name": "implements", @@ -12900,12 +13057,12 @@ "meta-type": "object" }, { - "name": "[171]", - "element-type": "171", + "name": "[172]", + "element-type": "172", "meta-type": "array" }, { - "name": "171", + "name": "172", "members": [ { "name": "name", @@ -12925,7 +13082,7 @@ "meta-type": "object" }, { - "name": "172", + "name": "173", "members": [ { "name": "typename", @@ -12935,7 +13092,7 @@ "meta-type": "object" }, { - "name": "173", + "name": "174", "members": [ { "name": "typename", @@ -12945,7 +13102,7 @@ "meta-type": "object" }, { - "name": "174", + "name": "175", "members": [ { "name": "enable", @@ -12955,7 +13112,7 @@ "meta-type": "object" }, { - "name": "175", + "name": "176", "members": [ { "name": "driver", @@ -12975,7 +13132,7 @@ "meta-type": "object" }, { - "name": "176", + "name": "177", "members": [ { "name": "id", @@ -12985,7 +13142,7 @@ "meta-type": "object" }, { - "name": "177", + "name": "178", "members": [ { "name": "device", @@ -13000,7 +13157,7 @@ "meta-type": "object" }, { - "name": "178", + "name": "179", "members": [ { "name": "paging", @@ -13028,17 +13185,17 @@ { "name": "format", "default": null, - "type": "333" + "type": "336" } ], "meta-type": "object" }, { - "name": "179", + "name": "180", "members": [ { "name": "status", - "type": "334" + "type": "337" }, { "name": "completed", @@ -13052,11 +13209,11 @@ "meta-type": "object" }, { - "name": "180", + "name": "181", "members": [ { "name": "result", - "type": "179" + "type": "180" }, { "name": "error", @@ -13066,22 +13223,12 @@ ], "meta-type": "object" }, - { - "name": "181", - "members": [ - { - "name": "formats", - "type": "[333]" - } - ], - "meta-type": "object" - }, { "name": "182", "members": [ { - "name": "filename", - "type": "str" + "name": "formats", + "type": "[336]" } ], "meta-type": "object" @@ -13193,34 +13340,17 @@ ], "meta-type": "object" }, - { - "name": "[190]", - "element-type": "190", - "meta-type": "array" - }, { "name": "190", "members": [ { - "name": "name", - "type": "str" - }, - { - "name": "migration-safe", + "name": "fdset-id", "default": null, - "type": "bool" - }, - { - "name": "static", - "type": "bool" + "type": "int" }, { - "name": "unavailable-features", + "name": "opaque", "default": null, - "type": "[str]" - }, - { - "name": "typename", "type": "str" } ], @@ -13230,12 +13360,12 @@ "name": "191", "members": [ { - "name": "type", - "type": "335" + "name": "fdset-id", + "type": "int" }, { - "name": "model", - "type": "336" + "name": "fd", + "type": "int" } ], "meta-type": "object" @@ -13244,22 +13374,32 @@ "name": "192", "members": [ { - "name": "model", - "type": "336" + "name": "fdset-id", + "type": "int" + }, + { + "name": "fd", + "default": null, + "type": "int" } ], "meta-type": "object" }, + { + "name": "[193]", + "element-type": "193", + "meta-type": "array" + }, { "name": "193", "members": [ { - "name": "modela", - "type": "336" + "name": "fdset-id", + "type": "int" }, { - "name": "modelb", - "type": "336" + "name": "fds", + "type": "[338]" } ], "meta-type": "object" @@ -13268,12 +13408,8 @@ "name": "194", "members": [ { - "name": "result", - "type": "337" - }, - { - "name": "responsible-properties", - "type": "[str]" + "name": "arch", + "type": "334" } ], "meta-type": "object" @@ -13282,145 +13418,47 @@ "name": "195", "members": [ { - "name": "modela", - "type": "336" - }, - { - "name": "modelb", - "type": "336" + "name": "option", + "default": null, + "type": "str" } ], "meta-type": "object" }, + { + "name": "[196]", + "element-type": "196", + "meta-type": "array" + }, { "name": "196", "members": [ { - "name": "model", - "type": "336" + "name": "option", + "type": "str" + }, + { + "name": "parameters", + "type": "[339]" } ], "meta-type": "object" }, + { + "name": "[197]", + "element-type": "197", + "meta-type": "array" + }, { "name": "197", "members": [ { - "name": "fdset-id", - "default": null, - "type": "int" - }, - { - "name": "opaque", + "name": "id", "default": null, "type": "str" - } - ], - "meta-type": "object" - }, - { - "name": "198", - "members": [ + }, { - "name": "fdset-id", - "type": "int" - }, - { - "name": "fd", - "type": "int" - } - ], - "meta-type": "object" - }, - { - "name": "199", - "members": [ - { - "name": "fdset-id", - "type": "int" - }, - { - "name": "fd", - "default": null, - "type": "int" - } - ], - "meta-type": "object" - }, - { - "name": "[200]", - "element-type": "200", - "meta-type": "array" - }, - { - "name": "200", - "members": [ - { - "name": "fdset-id", - "type": "int" - }, - { - "name": "fds", - "type": "[338]" - } - ], - "meta-type": "object" - }, - { - "name": "201", - "members": [ - { - "name": "arch", - "type": "331" - } - ], - "meta-type": "object" - }, - { - "name": "202", - "members": [ - { - "name": "option", - "default": null, - "type": "str" - } - ], - "meta-type": "object" - }, - { - "name": "[203]", - "element-type": "203", - "meta-type": "array" - }, - { - "name": "203", - "members": [ - { - "name": "option", - "type": "str" - }, - { - "name": "parameters", - "type": "[339]" - } - ], - "meta-type": "object" - }, - { - "name": "[204]", - "element-type": "204", - "meta-type": "array" - }, - { - "name": "204", - "members": [ - { - "name": "id", - "default": null, - "type": "str" - }, - { - "name": "size", + "name": "size", "type": "int" }, { @@ -13447,12 +13485,12 @@ "meta-type": "object" }, { - "name": "[205]", - "element-type": "205", + "name": "[198]", + "element-type": "198", "meta-type": "array" }, { - "name": "205", + "name": "198", "tag": "type", "variants": [ { @@ -13473,7 +13511,7 @@ "meta-type": "object" }, { - "name": "206", + "name": "199", "members": [ { "name": "device", @@ -13487,12 +13525,12 @@ "meta-type": "object" }, { - "name": "[207]", - "element-type": "207", + "name": "[200]", + "element-type": "200", "meta-type": "array" }, { - "name": "207", + "name": "200", "members": [ { "name": "device", @@ -13519,27 +13557,17 @@ "meta-type": "object" }, { - "name": "208", + "name": "201", "members": [ { "name": "info", - "type": "207" - } - ], - "meta-type": "object" - }, - { - "name": "209", - "members": [ - { - "name": "offset", - "type": "int" + "type": "200" } ], "meta-type": "object" }, { - "name": "210", + "name": "202", "members": [ { "name": "filename", @@ -13549,68 +13577,80 @@ "meta-type": "object" }, { - "name": "[211]", - "element-type": "211", + "name": "[203]", + "element-type": "203", "meta-type": "array" }, { - "name": "211", + "name": "203", "members": [ { - "name": "version", + "name": "type", + "type": "str" + }, + { + "name": "vcpus-count", "type": "int" }, { - "name": "emulated", - "type": "bool" + "name": "props", + "type": "325" }, { - "name": "kernel", - "type": "bool" + "name": "qom-path", + "default": null, + "type": "str" } ], "meta-type": "object" }, { - "name": "[212]", - "element-type": "212", - "meta-type": "array" - }, - { - "name": "212", + "name": "204", "members": [ { - "name": "type", + "name": "guid", "type": "str" - }, + } + ], + "meta-type": "object" + }, + { + "name": "205", + "tag": "type", + "variants": [ { - "name": "vcpus-count", - "type": "int" + "case": "node", + "type": "345" }, { - "name": "props", - "type": "322" + "case": "dist", + "type": "346" }, { - "name": "qom-path", - "default": null, - "type": "str" + "case": "cpu", + "type": "347" + } + ], + "members": [ + { + "name": "type", + "type": "344" } ], "meta-type": "object" }, { - "name": "213", + "name": "206", "members": [ { - "name": "guid", - "type": "str" + "name": "offset", + "type": "int" } ], "meta-type": "object" }, { - "name": "214", + "name": "207", "members": [ { "name": "enabled", @@ -13634,7 +13674,7 @@ }, { "name": "state", - "type": "344" + "type": "348" }, { "name": "handle", @@ -13644,7 +13684,7 @@ "meta-type": "object" }, { - "name": "215", + "name": "208", "members": [ { "name": "data", @@ -13654,7 +13694,7 @@ "meta-type": "object" }, { - "name": "216", + "name": "209", "members": [ { "name": "pdh", @@ -13676,26 +13716,58 @@ "meta-type": "object" }, { - "name": "217", - "tag": "type", - "variants": [ + "name": "216", + "members": [ { - "case": "node", - "type": "346" + "name": "type", + "type": "351" }, { - "case": "dist", - "type": "347" - }, + "name": "model", + "type": "349" + } + ], + "meta-type": "object" + }, + { + "name": "217", + "members": [ { - "case": "cpu", - "type": "348" + "name": "model", + "type": "349" } ], + "meta-type": "object" + }, + { + "name": "[218]", + "element-type": "218", + "meta-type": "array" + }, + { + "name": "218", "members": [ { - "name": "type", - "type": "345" + "name": "name", + "type": "str" + }, + { + "name": "migration-safe", + "default": null, + "type": "bool" + }, + { + "name": "static", + "type": "bool" + }, + { + "name": "unavailable-features", + "default": null, + "type": "[str]" + }, + { + "name": "typename", + "type": "str" } ], "meta-type": "object" @@ -13706,7 +13778,7 @@ "meta-type": "builtin" }, { - "name": "218", + "name": "219", "meta-type": "enum", "values": [ "debug", @@ -13729,7 +13801,7 @@ ] }, { - "name": "219", + "name": "220", "meta-type": "enum", "values": [ "none", @@ -13745,7 +13817,7 @@ ] }, { - "name": "220", + "name": "221", "meta-type": "enum", "values": [ "reset", @@ -13758,7 +13830,7 @@ ] }, { - "name": "221", + "name": "222", "meta-type": "enum", "values": [ "pause", @@ -13766,28 +13838,28 @@ ] }, { - "name": "222", + "name": "223", "tag": "type", "variants": [ { "case": "hyper-v", - "type": "350" + "type": "353" }, { "case": "s390", - "type": "351" + "type": "354" } ], "members": [ { "name": "type", - "type": "349" + "type": "352" } ], "meta-type": "object" }, { - "name": "223", + "name": "224", "meta-type": "enum", "values": [ "undefined", @@ -13804,7 +13876,7 @@ ] }, { - "name": "224", + "name": "225", "meta-type": "enum", "values": [ "commit", @@ -13820,7 +13892,7 @@ "meta-type": "array" }, { - "name": "225", + "name": "226", "meta-type": "enum", "values": [ "ok", @@ -13829,12 +13901,12 @@ ] }, { - "name": "[226]", - "element-type": "226", + "name": "[227]", + "element-type": "227", "meta-type": "array" }, { - "name": "226", + "name": "227", "members": [ { "name": "name", @@ -13849,15 +13921,32 @@ "name": "granularity", "type": "int" }, + { + "name": "recording", + "type": "bool" + }, + { + "name": "busy", + "type": "bool" + }, { "name": "status", - "type": "352" + "type": "355" + }, + { + "name": "persistent", + "type": "bool" + }, + { + "name": "inconsistent", + "default": null, + "type": "bool" } ], "meta-type": "object" }, { - "name": "227", + "name": "228", "members": [ { "name": "rd_bytes", @@ -13942,28 +14031,28 @@ }, { "name": "timed_stats", - "type": "[353]" + "type": "[356]" }, { - "name": "x_rd_latency_histogram", + "name": "rd_latency_histogram", "default": null, - "type": "354" + "type": "357" }, { - "name": "x_wr_latency_histogram", + "name": "wr_latency_histogram", "default": null, - "type": "354" + "type": "357" }, { - "name": "x_flush_latency_histogram", + "name": "flush_latency_histogram", "default": null, - "type": "354" + "type": "357" } ], "meta-type": "object" }, { - "name": "228", + "name": "229", "meta-type": "enum", "values": [ "existing", @@ -13971,7 +14060,7 @@ ] }, { - "name": "229", + "name": "230", "meta-type": "enum", "values": [ "top", @@ -13981,7 +14070,7 @@ ] }, { - "name": "230", + "name": "231", "meta-type": "enum", "values": [ "report", @@ -13992,7 +14081,7 @@ ] }, { - "name": "231", + "name": "232", "meta-type": "enum", "values": [ "off", @@ -14001,7 +14090,7 @@ ] }, { - "name": "232", + "name": "233", "members": [ { "name": "filename", @@ -14063,18 +14152,18 @@ { "name": "backing-image", "default": null, - "type": "232" + "type": "233" }, { "name": "format-specific", "default": null, - "type": "355" + "type": "358" } ], "meta-type": "object" }, { - "name": "233", + "name": "234", "members": [ { "name": "writeback", @@ -14092,12 +14181,12 @@ "meta-type": "object" }, { - "name": "[234]", - "element-type": "234", + "name": "[235]", + "element-type": "235", "meta-type": "array" }, { - "name": "234", + "name": "235", "members": [ { "name": "id", @@ -14105,7 +14194,7 @@ }, { "name": "type", - "type": "356" + "type": "359" }, { "name": "name", @@ -14115,12 +14204,12 @@ "meta-type": "object" }, { - "name": "[235]", - "element-type": "235", + "name": "[236]", + "element-type": "236", "meta-type": "array" }, { - "name": "235", + "name": "236", "members": [ { "name": "parent", @@ -14136,17 +14225,17 @@ }, { "name": "perm", - "type": "[357]" + "type": "[360]" }, { "name": "shared-perm", - "type": "[357]" + "type": "[360]" } ], "meta-type": "object" }, { - "name": "236", + "name": "237", "meta-type": "enum", "values": [ "background", @@ -14159,7 +14248,7 @@ "meta-type": "array" }, { - "name": "237", + "name": "238", "meta-type": "enum", "values": [ "blkdebug", @@ -14204,7 +14293,7 @@ ] }, { - "name": "238", + "name": "239", "meta-type": "enum", "values": [ "ignore", @@ -14212,7 +14301,7 @@ ] }, { - "name": "239", + "name": "240", "members": [ { "name": "direct", @@ -14228,11 +14317,11 @@ "meta-type": "object" }, { - "name": "240", + "name": "241", "members": [ { "name": "image", - "type": "358" + "type": "361" }, { "name": "config", @@ -14272,26 +14361,26 @@ { "name": "inject-error", "default": null, - "type": "[359]" + "type": "[362]" }, { "name": "set-state", "default": null, - "type": "[360]" + "type": "[363]" } ], "meta-type": "object" }, { - "name": "241", + "name": "242", "members": [ { "name": "file", - "type": "358" + "type": "361" }, { "name": "log", - "type": "358" + "type": "361" }, { "name": "log-sector-size", @@ -14312,31 +14401,31 @@ "meta-type": "object" }, { - "name": "242", + "name": "243", "members": [ { "name": "test", - "type": "358" + "type": "361" }, { "name": "raw", - "type": "358" + "type": "361" } ], "meta-type": "object" }, { - "name": "243", + "name": "244", "members": [ { "name": "file", - "type": "358" + "type": "361" } ], "meta-type": "object" }, { - "name": "244", + "name": "245", "members": [ { "name": "filename", @@ -14350,12 +14439,17 @@ { "name": "locking", "default": null, - "type": "361" + "type": "364" }, { "name": "aio", "default": null, - "type": "362" + "type": "365" + }, + { + "name": "drop-cache", + "default": null, + "type": "bool" }, { "name": "x-check-cache-dropped", @@ -14366,7 +14460,7 @@ "meta-type": "object" }, { - "name": "245", + "name": "246", "members": [ { "name": "url", @@ -14406,7 +14500,7 @@ "meta-type": "object" }, { - "name": "246", + "name": "247", "members": [ { "name": "url", @@ -14451,7 +14545,7 @@ "meta-type": "object" }, { - "name": "247", + "name": "248", "members": [ { "name": "volume", @@ -14463,7 +14557,7 @@ }, { "name": "server", - "type": "[363]" + "type": "[308]" }, { "name": "debug", @@ -14479,7 +14573,7 @@ "meta-type": "object" }, { - "name": "248", + "name": "249", "members": [ { "name": "url", @@ -14529,7 +14623,7 @@ "meta-type": "object" }, { - "name": "249", + "name": "250", "members": [ { "name": "url", @@ -14584,11 +14678,11 @@ "meta-type": "object" }, { - "name": "250", + "name": "251", "members": [ { "name": "transport", - "type": "364" + "type": "366" }, { "name": "portal", @@ -14621,7 +14715,7 @@ { "name": "header-digest", "default": null, - "type": "365" + "type": "367" }, { "name": "timeout", @@ -14632,11 +14726,11 @@ "meta-type": "object" }, { - "name": "251", + "name": "252", "members": [ { "name": "file", - "type": "358" + "type": "361" }, { "name": "key-secret", @@ -14647,11 +14741,11 @@ "meta-type": "object" }, { - "name": "252", + "name": "253", "members": [ { "name": "server", - "type": "363" + "type": "308" }, { "name": "export", @@ -14672,11 +14766,11 @@ "meta-type": "object" }, { - "name": "253", + "name": "254", "members": [ { "name": "server", - "type": "366" + "type": "368" }, { "name": "path", @@ -14716,7 +14810,7 @@ "meta-type": "object" }, { - "name": "254", + "name": "255", "members": [ { "name": "size", @@ -14732,7 +14826,7 @@ "meta-type": "object" }, { - "name": "255", + "name": "256", "members": [ { "name": "device", @@ -14746,16 +14840,16 @@ "meta-type": "object" }, { - "name": "256", + "name": "257", "members": [ { "name": "file", - "type": "358" + "type": "361" }, { "name": "backing", "default": null, - "type": "367" + "type": "369" }, { "name": "lazy-refcounts", @@ -14780,7 +14874,7 @@ { "name": "overlap-check", "default": null, - "type": "368" + "type": "370" }, { "name": "cache-size", @@ -14810,48 +14904,53 @@ { "name": "encrypt", "default": null, - "type": "369" + "type": "371" + }, + { + "name": "data-file", + "default": null, + "type": "361" } ], "meta-type": "object" }, { - "name": "257", + "name": "258", "members": [ { "name": "file", - "type": "358" + "type": "361" }, { "name": "backing", "default": null, - "type": "367" + "type": "369" }, { "name": "encrypt", "default": null, - "type": "370" + "type": "372" } ], "meta-type": "object" }, { - "name": "258", + "name": "259", "members": [ { "name": "file", - "type": "358" + "type": "361" }, { "name": "backing", "default": null, - "type": "367" + "type": "369" } ], "meta-type": "object" }, { - "name": "259", + "name": "260", "members": [ { "name": "blkverify", @@ -14860,7 +14959,7 @@ }, { "name": "children", - "type": "[358]" + "type": "[361]" }, { "name": "vote-threshold", @@ -14874,17 +14973,17 @@ { "name": "read-pattern", "default": null, - "type": "371" + "type": "373" } ], "meta-type": "object" }, { - "name": "260", + "name": "261", "members": [ { "name": "file", - "type": "358" + "type": "361" }, { "name": "offset", @@ -14900,7 +14999,7 @@ "meta-type": "object" }, { - "name": "261", + "name": "262", "members": [ { "name": "pool", @@ -14928,7 +15027,7 @@ { "name": "auth-client-required", "default": null, - "type": "[372]" + "type": "[374]" }, { "name": "key-secret", @@ -14938,21 +15037,21 @@ { "name": "server", "default": null, - "type": "[373]" + "type": "[375]" } ], "meta-type": "object" }, { - "name": "262", + "name": "263", "members": [ { "name": "file", - "type": "358" + "type": "361" }, { "name": "mode", - "type": "374" + "type": "376" }, { "name": "top-id", @@ -14963,11 +15062,11 @@ "meta-type": "object" }, { - "name": "263", + "name": "264", "members": [ { "name": "server", - "type": "363" + "type": "308" }, { "name": "vdi", @@ -14987,11 +15086,11 @@ "meta-type": "object" }, { - "name": "264", + "name": "265", "members": [ { "name": "server", - "type": "375" + "type": "377" }, { "name": "path", @@ -15005,13 +15104,13 @@ { "name": "host-key-check", "default": null, - "type": "376" + "type": "378" } ], "meta-type": "object" }, { - "name": "265", + "name": "266", "members": [ { "name": "throttle-group", @@ -15019,13 +15118,13 @@ }, { "name": "file", - "type": "358" + "type": "361" } ], "meta-type": "object" }, { - "name": "266", + "name": "267", "members": [ { "name": "dir", @@ -15055,7 +15154,7 @@ "meta-type": "object" }, { - "name": "267", + "name": "268", "members": [ { "name": "vdisk-id", @@ -15063,7 +15162,7 @@ }, { "name": "server", - "type": "373" + "type": "375" }, { "name": "tls-creds", @@ -15074,68 +15173,68 @@ "meta-type": "object" }, { - "name": "268", + "name": "269", "tag": "driver", "variants": [ { "case": "file", - "type": "377" + "type": "379" }, { "case": "gluster", - "type": "378" + "type": "380" }, { "case": "luks", - "type": "379" + "type": "381" }, { "case": "nfs", - "type": "380" + "type": "382" }, { "case": "parallels", - "type": "381" + "type": "383" }, { "case": "qcow", - "type": "382" + "type": "384" }, { "case": "qcow2", - "type": "383" + "type": "385" }, { "case": "qed", - "type": "384" + "type": "386" }, { "case": "rbd", - "type": "385" + "type": "387" }, { "case": "sheepdog", - "type": "386" + "type": "388" }, { "case": "ssh", - "type": "387" + "type": "389" }, { "case": "vdi", - "type": "388" + "type": "390" }, { "case": "vhdx", - "type": "389" + "type": "391" }, { "case": "vmdk", - "type": "390" + "type": "392" }, { "case": "vpc", - "type": "391" + "type": "393" }, { "case": "blkdebug", @@ -15237,13 +15336,13 @@ "members": [ { "name": "driver", - "type": "237" + "type": "238" } ], "meta-type": "object" }, { - "name": "269", + "name": "270", "meta-type": "enum", "values": [ "retain", @@ -15252,7 +15351,7 @@ ] }, { - "name": "270", + "name": "271", "meta-type": "enum", "values": [ "read", @@ -15260,7 +15359,7 @@ ] }, { - "name": "271", + "name": "272", "meta-type": "enum", "values": [ "ignore", @@ -15269,7 +15368,7 @@ ] }, { - "name": "272", + "name": "273", "members": [ { "type": "str" @@ -15281,36 +15380,36 @@ "meta-type": "alternate" }, { - "name": "273", + "name": "274", "tag": "type", "variants": [ { "case": "inet", - "type": "393" + "type": "395" }, { "case": "unix", - "type": "394" + "type": "396" }, { "case": "vsock", - "type": "395" + "type": "397" }, { "case": "fd", - "type": "396" + "type": "398" } ], "members": [ { "name": "type", - "type": "392" + "type": "394" } ], "meta-type": "object" }, { - "name": "274", + "name": "275", "meta-type": "enum", "values": [ "safe", @@ -15318,7 +15417,7 @@ ] }, { - "name": "275", + "name": "276", "meta-type": "enum", "values": [ "read", @@ -15327,7 +15426,7 @@ ] }, { - "name": "276", + "name": "277", "meta-type": "enum", "values": [ "utf8", @@ -15335,100 +15434,100 @@ ] }, { - "name": "277", + "name": "278", "tag": "type", "variants": [ { "case": "file", - "type": "398" + "type": "400" }, { "case": "serial", - "type": "399" + "type": "401" }, { "case": "parallel", - "type": "399" + "type": "401" }, { "case": "pipe", - "type": "399" + "type": "401" }, { "case": "socket", - "type": "400" + "type": "402" }, { "case": "udp", - "type": "401" + "type": "403" }, { "case": "pty", - "type": "402" + "type": "404" }, { "case": "null", - "type": "402" + "type": "404" }, { "case": "mux", - "type": "403" + "type": "405" }, { "case": "msmouse", - "type": "402" + "type": "404" }, { "case": "wctablet", - "type": "402" + "type": "404" }, { "case": "braille", - "type": "402" + "type": "404" }, { "case": "testdev", - "type": "402" + "type": "404" }, { "case": "stdio", - "type": "404" + "type": "406" }, { "case": "console", - "type": "402" + "type": "404" }, { "case": "spicevmc", - "type": "405" + "type": "407" }, { "case": "spiceport", - "type": "406" + "type": "408" }, { "case": "vc", - "type": "407" + "type": "409" }, { "case": "ringbuf", - "type": "408" + "type": "410" }, { "case": "memory", - "type": "408" + "type": "410" } ], "members": [ { "name": "type", - "type": "397" + "type": "399" } ], "meta-type": "object" }, { - "name": "278", + "name": "279", "meta-type": "enum", "values": [ "normal", @@ -15437,7 +15536,7 @@ ] }, { - "name": "279", + "name": "280", "meta-type": "enum", "values": [ "half", @@ -15445,7 +15544,7 @@ ] }, { - "name": "280", + "name": "281", "meta-type": "enum", "values": [ "off", @@ -15453,7 +15552,7 @@ ] }, { - "name": "281", + "name": "282", "members": [ { "name": "priority", @@ -15512,7 +15611,7 @@ "meta-type": "object" }, { - "name": "282", + "name": "283", "members": [ { "name": "in-pport", @@ -15553,7 +15652,7 @@ "meta-type": "object" }, { - "name": "283", + "name": "284", "members": [ { "name": "goto-tbl", @@ -15589,28 +15688,28 @@ "meta-type": "object" }, { - "name": "284", + "name": "285", "tag": "type", "variants": [ { "case": "passthrough", - "type": "410" + "type": "412" }, { "case": "emulator", - "type": "411" + "type": "413" } ], "members": [ { "name": "type", - "type": "409" + "type": "411" } ], "meta-type": "object" }, { - "name": "285", + "name": "286", "meta-type": "enum", "values": [ "client", @@ -15619,12 +15718,12 @@ ] }, { - "name": "[286]", - "element-type": "286", + "name": "[287]", + "element-type": "287", "meta-type": "array" }, { - "name": "286", + "name": "287", "members": [ { "name": "host", @@ -15636,7 +15735,7 @@ }, { "name": "family", - "type": "289" + "type": "290" }, { "name": "connection-id", @@ -15658,7 +15757,7 @@ "meta-type": "object" }, { - "name": "287", + "name": "288", "members": [ { "name": "host", @@ -15670,13 +15769,13 @@ }, { "name": "family", - "type": "289" + "type": "290" } ], "meta-type": "object" }, { - "name": "288", + "name": "289", "members": [ { "name": "host", @@ -15688,7 +15787,7 @@ }, { "name": "family", - "type": "289" + "type": "290" }, { "name": "auth", @@ -15699,7 +15798,7 @@ "meta-type": "object" }, { - "name": "289", + "name": "290", "meta-type": "enum", "values": [ "ipv4", @@ -15710,12 +15809,12 @@ ] }, { - "name": "[290]", - "element-type": "290", + "name": "[291]", + "element-type": "291", "meta-type": "array" }, { - "name": "290", + "name": "291", "members": [ { "name": "host", @@ -15727,7 +15826,7 @@ }, { "name": "family", - "type": "289" + "type": "290" }, { "name": "websocket", @@ -15747,12 +15846,12 @@ "meta-type": "object" }, { - "name": "[291]", - "element-type": "291", + "name": "[292]", + "element-type": "292", "meta-type": "array" }, { - "name": "291", + "name": "292", "members": [ { "name": "host", @@ -15764,7 +15863,7 @@ }, { "name": "family", - "type": "289" + "type": "290" }, { "name": "websocket", @@ -15772,18 +15871,18 @@ }, { "name": "auth", - "type": "292" + "type": "293" }, { "name": "vencrypt", "default": null, - "type": "293" + "type": "294" } ], "meta-type": "object" }, { - "name": "292", + "name": "293", "meta-type": "enum", "values": [ "none", @@ -15798,7 +15897,7 @@ ] }, { - "name": "293", + "name": "294", "meta-type": "enum", "values": [ "plain", @@ -15813,7 +15912,7 @@ ] }, { - "name": "294", + "name": "295", "members": [ { "name": "host", @@ -15825,7 +15924,7 @@ }, { "name": "family", - "type": "289" + "type": "290" }, { "name": "websocket", @@ -15840,7 +15939,7 @@ "meta-type": "object" }, { - "name": "295", + "name": "296", "members": [ { "name": "host", @@ -15852,7 +15951,7 @@ }, { "name": "family", - "type": "289" + "type": "290" }, { "name": "websocket", @@ -15862,67 +15961,67 @@ "meta-type": "object" }, { - "name": "[296]", - "element-type": "296", + "name": "[297]", + "element-type": "297", "meta-type": "array" }, { - "name": "296", + "name": "297", "tag": "type", "variants": [ { "case": "number", - "type": "413" + "type": "415" }, { "case": "qcode", - "type": "414" + "type": "416" } ], "members": [ { "name": "type", - "type": "412" + "type": "414" } ], "meta-type": "object" }, { - "name": "[297]", - "element-type": "297", + "name": "[298]", + "element-type": "298", "meta-type": "array" }, { - "name": "297", + "name": "298", "tag": "type", "variants": [ { "case": "key", - "type": "416" + "type": "418" }, { "case": "btn", - "type": "417" + "type": "419" }, { "case": "rel", - "type": "418" + "type": "420" }, { "case": "abs", - "type": "418" + "type": "420" } ], "members": [ { "name": "type", - "type": "415" + "type": "417" } ], "meta-type": "object" }, { - "name": "298", + "name": "299", "meta-type": "enum", "values": [ "default", @@ -15931,11 +16030,12 @@ "sdl", "egl-headless", "curses", - "cocoa" + "cocoa", + "spice-app" ] }, { - "name": "299", + "name": "300", "meta-type": "enum", "values": [ "off", @@ -15945,7 +16045,7 @@ ] }, { - "name": "300", + "name": "301", "members": [ { "name": "grab-on-hover", @@ -15961,7 +16061,18 @@ "meta-type": "object" }, { - "name": "301", + "name": "302", + "members": [ + { + "name": "charset", + "default": null, + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "303", "members": [ { "name": "rendernode", @@ -15972,7 +16083,7 @@ "meta-type": "object" }, { - "name": "302", + "name": "304", "meta-type": "enum", "values": [ "none", @@ -15991,7 +16102,7 @@ ] }, { - "name": "303", + "name": "305", "members": [ { "name": "transferred", @@ -16053,7 +16164,7 @@ "meta-type": "object" }, { - "name": "304", + "name": "306", "members": [ { "name": "cache-size", @@ -16083,7 +16194,7 @@ "meta-type": "object" }, { - "name": "305", + "name": "307", "members": [ { "name": "pages", @@ -16109,7 +16220,41 @@ "meta-type": "object" }, { - "name": "306", + "name": "[308]", + "element-type": "308", + "meta-type": "array" + }, + { + "name": "308", + "tag": "type", + "variants": [ + { + "case": "inet", + "type": "377" + }, + { + "case": "unix", + "type": "422" + }, + { + "case": "vsock", + "type": "423" + }, + { + "case": "fd", + "type": "424" + } + ], + "members": [ + { + "name": "type", + "type": "421" + } + ], + "meta-type": "object" + }, + { + "name": "309", "meta-type": "enum", "values": [ "xbzrle", @@ -16124,14 +16269,15 @@ "block", "return-path", "pause-before-switchover", - "x-multifd", + "multifd", "dirty-bitmaps", "postcopy-blocktime", - "late-block-activate" + "late-block-activate", + "x-ignore-shared" ] }, { - "name": "307", + "name": "310", "meta-type": "enum", "values": [ "none", @@ -16140,12 +16286,13 @@ ] }, { - "name": "308", + "name": "311", "meta-type": "enum", "values": [ "none", "request", - "error" + "error", + "processing" ] }, { @@ -16154,80 +16301,80 @@ "meta-type": "builtin" }, { - "name": "[309]", - "element-type": "309", + "name": "[312]", + "element-type": "312", "meta-type": "array" }, { - "name": "309", + "name": "312", "tag": "type", "variants": [ { "case": "abort", - "type": "420" + "type": "426" }, { "case": "block-dirty-bitmap-add", - "type": "421" + "type": "427" }, { "case": "block-dirty-bitmap-clear", - "type": "422" + "type": "428" }, { "case": "block-dirty-bitmap-enable", - "type": "422" + "type": "428" }, { "case": "block-dirty-bitmap-disable", - "type": "422" + "type": "428" }, { "case": "block-dirty-bitmap-merge", - "type": "423" + "type": "429" }, { "case": "blockdev-backup", - "type": "424" + "type": "430" }, { "case": "blockdev-snapshot", - "type": "425" + "type": "431" }, { "case": "blockdev-snapshot-internal-sync", - "type": "426" + "type": "432" }, { "case": "blockdev-snapshot-sync", - "type": "427" + "type": "433" }, { "case": "drive-backup", - "type": "428" + "type": "434" } ], "members": [ { "name": "type", - "type": "419" + "type": "425" } ], "meta-type": "object" }, { - "name": "310", + "name": "313", "members": [ { "name": "completion-mode", "default": null, - "type": "429" + "type": "435" } ], "meta-type": "object" }, { - "name": "311", + "name": "314", "meta-type": "enum", "values": [ "unavailable", @@ -16236,7 +16383,7 @@ ] }, { - "name": "312", + "name": "315", "meta-type": "enum", "values": [ "builtin", @@ -16249,17 +16396,17 @@ ] }, { - "name": "313", + "name": "316", "members": [ { "name": "json-type", - "type": "430" + "type": "436" } ], "meta-type": "object" }, { - "name": "314", + "name": "317", "members": [ { "name": "values", @@ -16269,7 +16416,7 @@ "meta-type": "object" }, { - "name": "315", + "name": "318", "members": [ { "name": "element-type", @@ -16279,11 +16426,11 @@ "meta-type": "object" }, { - "name": "316", + "name": "319", "members": [ { "name": "members", - "type": "[431]" + "type": "[437]" }, { "name": "tag", @@ -16293,23 +16440,23 @@ { "name": "variants", "default": null, - "type": "[432]" + "type": "[438]" } ], "meta-type": "object" }, { - "name": "317", + "name": "320", "members": [ { "name": "members", - "type": "[433]" + "type": "[439]" } ], "meta-type": "object" }, { - "name": "318", + "name": "321", "members": [ { "name": "arg-type", @@ -16328,7 +16475,7 @@ "meta-type": "object" }, { - "name": "319", + "name": "322", "members": [ { "name": "arg-type", @@ -16338,19 +16485,19 @@ "meta-type": "object" }, { - "name": "[320]", - "element-type": "320", + "name": "[323]", + "element-type": "323", "meta-type": "array" }, { - "name": "320", + "name": "323", "meta-type": "enum", "values": [ "oob" ] }, { - "name": "321", + "name": "324", "members": [ { "name": "major", @@ -16368,7 +16515,7 @@ "meta-type": "object" }, { - "name": "322", + "name": "325", "members": [ { "name": "node-id", @@ -16394,7 +16541,7 @@ "meta-type": "object" }, { - "name": "323", + "name": "326", "meta-type": "enum", "values": [ "x86", @@ -16408,7 +16555,7 @@ ] }, { - "name": "324", + "name": "327", "members": [ { "name": "pc", @@ -16418,7 +16565,7 @@ "meta-type": "object" }, { - "name": "325", + "name": "328", "members": [ { "name": "pc", @@ -16432,7 +16579,7 @@ "meta-type": "object" }, { - "name": "326", + "name": "329", "members": [ { "name": "nip", @@ -16442,7 +16589,7 @@ "meta-type": "object" }, { - "name": "327", + "name": "330", "members": [ { "name": "PC", @@ -16452,7 +16599,7 @@ "meta-type": "object" }, { - "name": "328", + "name": "331", "members": [ { "name": "PC", @@ -16462,17 +16609,17 @@ "meta-type": "object" }, { - "name": "329", + "name": "332", "members": [ { "name": "cpu-state", - "type": "434" + "type": "440" } ], "meta-type": "object" }, { - "name": "330", + "name": "333", "members": [ { "name": "pc", @@ -16482,7 +16629,7 @@ "meta-type": "object" }, { - "name": "331", + "name": "334", "meta-type": "enum", "values": [ "aarch64", @@ -16519,12 +16666,12 @@ ] }, { - "name": "[332]", - "element-type": "332", + "name": "[335]", + "element-type": "335", "meta-type": "array" }, { - "name": "332", + "name": "335", "members": [ { "name": "bus", @@ -16540,11 +16687,11 @@ }, { "name": "class_info", - "type": "435" + "type": "441" }, { "name": "id", - "type": "436" + "type": "442" }, { "name": "irq", @@ -16558,17 +16705,17 @@ { "name": "pci_bridge", "default": null, - "type": "437" + "type": "443" }, { "name": "regions", - "type": "[438]" + "type": "[444]" } ], "meta-type": "object" }, { - "name": "333", + "name": "336", "meta-type": "enum", "values": [ "elf", @@ -16579,7 +16726,7 @@ ] }, { - "name": "334", + "name": "337", "meta-type": "enum", "values": [ "none", @@ -16589,43 +16736,10 @@ ] }, { - "name": "[333]", - "element-type": "333", + "name": "[336]", + "element-type": "336", "meta-type": "array" }, - { - "name": "335", - "meta-type": "enum", - "values": [ - "static", - "full" - ] - }, - { - "name": "336", - "members": [ - { - "name": "name", - "type": "str" - }, - { - "name": "props", - "default": null, - "type": "any" - } - ], - "meta-type": "object" - }, - { - "name": "337", - "meta-type": "enum", - "values": [ - "incompatible", - "identical", - "superset", - "subset" - ] - }, { "name": "[338]", "element-type": "338", @@ -16660,7 +16774,7 @@ }, { "name": "type", - "type": "439" + "type": "445" }, { "name": "help", @@ -16698,33 +16812,21 @@ "members": [ { "name": "data", - "type": "440" + "type": "446" } ], "meta-type": "object" }, { - "name": "343", - "meta-type": "enum", - "values": [ - "DIMM", - "CPU" - ] - }, - { - "name": "344", - "meta-type": "enum", - "values": [ - "uninit", - "launch-update", - "launch-secret", - "running", - "send-update", - "receive-update" + "name": "343", + "meta-type": "enum", + "values": [ + "DIMM", + "CPU" ] }, { - "name": "345", + "name": "344", "meta-type": "enum", "values": [ "node", @@ -16733,7 +16835,7 @@ ] }, { - "name": "346", + "name": "345", "members": [ { "name": "nodeid", @@ -16759,7 +16861,7 @@ "meta-type": "object" }, { - "name": "347", + "name": "346", "members": [ { "name": "src", @@ -16777,7 +16879,7 @@ "meta-type": "object" }, { - "name": "348", + "name": "347", "members": [ { "name": "node-id", @@ -16802,8 +16904,53 @@ ], "meta-type": "object" }, + { + "name": "348", + "meta-type": "enum", + "values": [ + "uninit", + "launch-update", + "launch-secret", + "running", + "send-update", + "receive-update" + ] + }, { "name": "349", + "members": [ + { + "name": "name", + "type": "str" + }, + { + "name": "props", + "default": null, + "type": "any" + } + ], + "meta-type": "object" + }, + { + "name": "350", + "meta-type": "enum", + "values": [ + "incompatible", + "identical", + "superset", + "subset" + ] + }, + { + "name": "351", + "meta-type": "enum", + "values": [ + "static", + "full" + ] + }, + { + "name": "352", "meta-type": "enum", "values": [ "hyper-v", @@ -16811,7 +16958,7 @@ ] }, { - "name": "350", + "name": "353", "members": [ { "name": "arg1", @@ -16837,7 +16984,7 @@ "meta-type": "object" }, { - "name": "351", + "name": "354", "members": [ { "name": "core", @@ -16853,28 +17000,29 @@ }, { "name": "reason", - "type": "441" + "type": "447" } ], "meta-type": "object" }, { - "name": "352", + "name": "355", "meta-type": "enum", "values": [ "active", "disabled", "frozen", - "locked" + "locked", + "inconsistent" ] }, { - "name": "[353]", - "element-type": "353", + "name": "[356]", + "element-type": "356", "meta-type": "array" }, { - "name": "353", + "name": "356", "members": [ { "name": "interval_length", @@ -16928,7 +17076,7 @@ "meta-type": "object" }, { - "name": "354", + "name": "357", "members": [ { "name": "boundaries", @@ -16947,32 +17095,32 @@ "meta-type": "array" }, { - "name": "355", + "name": "358", "tag": "type", "variants": [ { "case": "qcow2", - "type": "443" + "type": "449" }, { "case": "vmdk", - "type": "444" + "type": "450" }, { "case": "luks", - "type": "445" + "type": "451" } ], "members": [ { "name": "type", - "type": "442" + "type": "448" } ], "meta-type": "object" }, { - "name": "356", + "name": "359", "meta-type": "enum", "values": [ "block-backend", @@ -16981,12 +17129,12 @@ ] }, { - "name": "[357]", - "element-type": "357", + "name": "[360]", + "element-type": "360", "meta-type": "array" }, { - "name": "357", + "name": "360", "meta-type": "enum", "values": [ "consistent-read", @@ -16997,7 +17145,7 @@ ] }, { - "name": "358", + "name": "361", "members": [ { "type": "45" @@ -17009,16 +17157,16 @@ "meta-type": "alternate" }, { - "name": "[359]", - "element-type": "359", + "name": "[362]", + "element-type": "362", "meta-type": "array" }, { - "name": "359", + "name": "362", "members": [ { "name": "event", - "type": "446" + "type": "452" }, { "name": "state", @@ -17049,16 +17197,16 @@ "meta-type": "object" }, { - "name": "[360]", - "element-type": "360", + "name": "[363]", + "element-type": "363", "meta-type": "array" }, { - "name": "360", + "name": "363", "members": [ { "name": "event", - "type": "446" + "type": "452" }, { "name": "state", @@ -17073,7 +17221,7 @@ "meta-type": "object" }, { - "name": "361", + "name": "364", "meta-type": "enum", "values": [ "auto", @@ -17082,7 +17230,7 @@ ] }, { - "name": "362", + "name": "365", "meta-type": "enum", "values": [ "threads", @@ -17090,41 +17238,7 @@ ] }, { - "name": "[363]", - "element-type": "363", - "meta-type": "array" - }, - { - "name": "363", - "tag": "type", - "variants": [ - { - "case": "inet", - "type": "375" - }, - { - "case": "unix", - "type": "448" - }, - { - "case": "vsock", - "type": "449" - }, - { - "case": "fd", - "type": "450" - } - ], - "members": [ - { - "name": "type", - "type": "447" - } - ], - "meta-type": "object" - }, - { - "name": "364", + "name": "366", "meta-type": "enum", "values": [ "tcp", @@ -17132,7 +17246,7 @@ ] }, { - "name": "365", + "name": "367", "meta-type": "enum", "values": [ "crc32c", @@ -17142,11 +17256,11 @@ ] }, { - "name": "366", + "name": "368", "members": [ { "name": "type", - "type": "451" + "type": "453" }, { "name": "host", @@ -17156,7 +17270,7 @@ "meta-type": "object" }, { - "name": "367", + "name": "369", "members": [ { "type": "45" @@ -17171,62 +17285,62 @@ "meta-type": "alternate" }, { - "name": "368", + "name": "370", "members": [ { - "type": "452" + "type": "454" }, { - "type": "453" + "type": "455" } ], "meta-type": "alternate" }, { - "name": "369", + "name": "371", "tag": "format", "variants": [ { "case": "aes", - "type": "455" + "type": "457" }, { "case": "luks", - "type": "456" + "type": "458" } ], "members": [ { "name": "format", - "type": "454" + "type": "456" } ], "meta-type": "object" }, { - "name": "370", + "name": "372", "tag": "format", "variants": [ { "case": "aes", - "type": "455" + "type": "457" } ], "members": [ { "name": "format", - "type": "457" + "type": "459" } ], "meta-type": "object" }, { - "name": "[358]", - "element-type": "358", + "name": "[361]", + "element-type": "361", "meta-type": "array" }, { - "name": "371", + "name": "373", "meta-type": "enum", "values": [ "quorum", @@ -17234,12 +17348,12 @@ ] }, { - "name": "[372]", - "element-type": "372", + "name": "[374]", + "element-type": "374", "meta-type": "array" }, { - "name": "372", + "name": "374", "meta-type": "enum", "values": [ "cephx", @@ -17247,12 +17361,12 @@ ] }, { - "name": "[373]", - "element-type": "373", + "name": "[375]", + "element-type": "375", "meta-type": "array" }, { - "name": "373", + "name": "375", "members": [ { "name": "host", @@ -17266,7 +17380,7 @@ "meta-type": "object" }, { - "name": "374", + "name": "376", "meta-type": "enum", "values": [ "primary", @@ -17274,7 +17388,7 @@ ] }, { - "name": "375", + "name": "377", "members": [ { "name": "host", @@ -17308,12 +17422,12 @@ "meta-type": "object" }, { - "name": "376", + "name": "378", "tag": "mode", "variants": [ { "case": "hash", - "type": "459" + "type": "461" }, { "case": "none", @@ -17327,13 +17441,13 @@ "members": [ { "name": "mode", - "type": "458" + "type": "460" } ], "meta-type": "object" }, { - "name": "377", + "name": "379", "members": [ { "name": "filename", @@ -17346,7 +17460,7 @@ { "name": "preallocation", "default": null, - "type": "460" + "type": "462" }, { "name": "nocow", @@ -17357,11 +17471,11 @@ "meta-type": "object" }, { - "name": "378", + "name": "380", "members": [ { "name": "location", - "type": "247" + "type": "248" }, { "name": "size", @@ -17370,13 +17484,13 @@ { "name": "preallocation", "default": null, - "type": "460" + "type": "462" } ], "meta-type": "object" }, { - "name": "379", + "name": "381", "members": [ { "name": "key-secret", @@ -17386,27 +17500,27 @@ { "name": "cipher-alg", "default": null, - "type": "461" + "type": "463" }, { "name": "cipher-mode", "default": null, - "type": "462" + "type": "464" }, { "name": "ivgen-alg", "default": null, - "type": "463" + "type": "465" }, { "name": "ivgen-hash-alg", "default": null, - "type": "464" + "type": "466" }, { "name": "hash-alg", "default": null, - "type": "464" + "type": "466" }, { "name": "iter-time", @@ -17415,7 +17529,7 @@ }, { "name": "file", - "type": "358" + "type": "361" }, { "name": "size", @@ -17425,11 +17539,11 @@ "meta-type": "object" }, { - "name": "380", + "name": "382", "members": [ { "name": "location", - "type": "253" + "type": "254" }, { "name": "size", @@ -17439,11 +17553,11 @@ "meta-type": "object" }, { - "name": "381", + "name": "383", "members": [ { "name": "file", - "type": "358" + "type": "361" }, { "name": "size", @@ -17458,11 +17572,11 @@ "meta-type": "object" }, { - "name": "382", + "name": "384", "members": [ { "name": "file", - "type": "358" + "type": "361" }, { "name": "size", @@ -17476,17 +17590,27 @@ { "name": "encrypt", "default": null, - "type": "465" + "type": "467" } ], "meta-type": "object" }, { - "name": "383", + "name": "385", "members": [ { "name": "file", - "type": "358" + "type": "361" + }, + { + "name": "data-file", + "default": null, + "type": "361" + }, + { + "name": "data-file-raw", + "default": null, + "type": "bool" }, { "name": "size", @@ -17495,7 +17619,7 @@ { "name": "version", "default": null, - "type": "466" + "type": "468" }, { "name": "backing-file", @@ -17505,12 +17629,12 @@ { "name": "backing-fmt", "default": null, - "type": "237" + "type": "238" }, { "name": "encrypt", "default": null, - "type": "465" + "type": "467" }, { "name": "cluster-size", @@ -17520,7 +17644,7 @@ { "name": "preallocation", "default": null, - "type": "460" + "type": "462" }, { "name": "lazy-refcounts", @@ -17536,11 +17660,11 @@ "meta-type": "object" }, { - "name": "384", + "name": "386", "members": [ { "name": "file", - "type": "358" + "type": "361" }, { "name": "size", @@ -17554,7 +17678,7 @@ { "name": "backing-fmt", "default": null, - "type": "237" + "type": "238" }, { "name": "cluster-size", @@ -17570,11 +17694,11 @@ "meta-type": "object" }, { - "name": "385", + "name": "387", "members": [ { "name": "location", - "type": "261" + "type": "262" }, { "name": "size", @@ -17589,11 +17713,11 @@ "meta-type": "object" }, { - "name": "386", + "name": "388", "members": [ { "name": "location", - "type": "263" + "type": "264" }, { "name": "size", @@ -17607,12 +17731,12 @@ { "name": "preallocation", "default": null, - "type": "460" + "type": "462" }, { "name": "redundancy", "default": null, - "type": "467" + "type": "469" }, { "name": "object-size", @@ -17623,11 +17747,11 @@ "meta-type": "object" }, { - "name": "387", + "name": "389", "members": [ { "name": "location", - "type": "264" + "type": "265" }, { "name": "size", @@ -17637,11 +17761,11 @@ "meta-type": "object" }, { - "name": "388", + "name": "390", "members": [ { "name": "file", - "type": "358" + "type": "361" }, { "name": "size", @@ -17650,17 +17774,17 @@ { "name": "preallocation", "default": null, - "type": "460" + "type": "462" } ], "meta-type": "object" }, { - "name": "389", + "name": "391", "members": [ { "name": "file", - "type": "358" + "type": "361" }, { "name": "size", @@ -17679,7 +17803,7 @@ { "name": "subformat", "default": null, - "type": "468" + "type": "470" }, { "name": "block-state-zero", @@ -17690,11 +17814,11 @@ "meta-type": "object" }, { - "name": "390", + "name": "392", "members": [ { "name": "file", - "type": "358" + "type": "361" }, { "name": "size", @@ -17703,12 +17827,12 @@ { "name": "extents", "default": null, - "type": "[358]" + "type": "[361]" }, { "name": "subformat", "default": null, - "type": "469" + "type": "471" }, { "name": "backing-file", @@ -17718,7 +17842,7 @@ { "name": "adapter-type", "default": null, - "type": "470" + "type": "472" }, { "name": "hwversion", @@ -17734,11 +17858,11 @@ "meta-type": "object" }, { - "name": "391", + "name": "393", "members": [ { "name": "file", - "type": "358" + "type": "361" }, { "name": "size", @@ -17747,7 +17871,7 @@ { "name": "subformat", "default": null, - "type": "471" + "type": "473" }, { "name": "force-size", @@ -17763,7 +17887,7 @@ "meta-type": "builtin" }, { - "name": "392", + "name": "394", "meta-type": "enum", "values": [ "inet", @@ -17773,47 +17897,47 @@ ] }, { - "name": "393", + "name": "395", "members": [ { "name": "data", - "type": "375" + "type": "377" } ], "meta-type": "object" }, { - "name": "394", + "name": "396", "members": [ { "name": "data", - "type": "448" + "type": "422" } ], "meta-type": "object" }, { - "name": "395", + "name": "397", "members": [ { "name": "data", - "type": "449" + "type": "423" } ], "meta-type": "object" }, { - "name": "396", + "name": "398", "members": [ { "name": "data", - "type": "450" + "type": "424" } ], "meta-type": "object" }, { - "name": "397", + "name": "399", "meta-type": "enum", "values": [ "file", @@ -17838,26 +17962,6 @@ "memory" ] }, - { - "name": "398", - "members": [ - { - "name": "data", - "type": "472" - } - ], - "meta-type": "object" - }, - { - "name": "399", - "members": [ - { - "name": "data", - "type": "473" - } - ], - "meta-type": "object" - }, { "name": "400", "members": [ @@ -17950,6 +18054,26 @@ }, { "name": "409", + "members": [ + { + "name": "data", + "type": "483" + } + ], + "meta-type": "object" + }, + { + "name": "410", + "members": [ + { + "name": "data", + "type": "484" + } + ], + "meta-type": "object" + }, + { + "name": "411", "meta-type": "enum", "values": [ "passthrough", @@ -17957,27 +18081,27 @@ ] }, { - "name": "410", + "name": "412", "members": [ { "name": "data", - "type": "483" + "type": "485" } ], "meta-type": "object" }, { - "name": "411", + "name": "413", "members": [ { "name": "data", - "type": "484" + "type": "486" } ], "meta-type": "object" }, { - "name": "412", + "name": "414", "meta-type": "enum", "values": [ "number", @@ -17985,7 +18109,7 @@ ] }, { - "name": "413", + "name": "415", "members": [ { "name": "data", @@ -17995,17 +18119,17 @@ "meta-type": "object" }, { - "name": "414", + "name": "416", "members": [ { "name": "data", - "type": "485" + "type": "487" } ], "meta-type": "object" }, { - "name": "415", + "name": "417", "meta-type": "enum", "values": [ "key", @@ -18015,37 +18139,81 @@ ] }, { - "name": "416", + "name": "418", "members": [ { "name": "data", - "type": "486" + "type": "488" } ], "meta-type": "object" }, { - "name": "417", + "name": "419", "members": [ { "name": "data", - "type": "487" + "type": "489" } ], "meta-type": "object" }, { - "name": "418", + "name": "420", "members": [ { "name": "data", - "type": "488" + "type": "490" } ], "meta-type": "object" }, { - "name": "419", + "name": "421", + "meta-type": "enum", + "values": [ + "inet", + "unix", + "vsock", + "fd" + ] + }, + { + "name": "422", + "members": [ + { + "name": "path", + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "423", + "members": [ + { + "name": "cid", + "type": "str" + }, + { + "name": "port", + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "424", + "members": [ + { + "name": "str", + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "425", "meta-type": "enum", "values": [ "abort", @@ -18062,17 +18230,17 @@ ] }, { - "name": "420", + "name": "426", "members": [ { "name": "data", - "type": "489" + "type": "491" } ], "meta-type": "object" }, { - "name": "421", + "name": "427", "members": [ { "name": "data", @@ -18082,7 +18250,7 @@ "meta-type": "object" }, { - "name": "422", + "name": "428", "members": [ { "name": "data", @@ -18092,7 +18260,7 @@ "meta-type": "object" }, { - "name": "423", + "name": "429", "members": [ { "name": "data", @@ -18102,7 +18270,7 @@ "meta-type": "object" }, { - "name": "424", + "name": "430", "members": [ { "name": "data", @@ -18112,7 +18280,7 @@ "meta-type": "object" }, { - "name": "425", + "name": "431", "members": [ { "name": "data", @@ -18122,7 +18290,7 @@ "meta-type": "object" }, { - "name": "426", + "name": "432", "members": [ { "name": "data", @@ -18132,7 +18300,7 @@ "meta-type": "object" }, { - "name": "427", + "name": "433", "members": [ { "name": "data", @@ -18142,7 +18310,7 @@ "meta-type": "object" }, { - "name": "428", + "name": "434", "members": [ { "name": "data", @@ -18152,7 +18320,7 @@ "meta-type": "object" }, { - "name": "429", + "name": "435", "meta-type": "enum", "values": [ "individual", @@ -18160,7 +18328,7 @@ ] }, { - "name": "430", + "name": "436", "meta-type": "enum", "values": [ "string", @@ -18174,12 +18342,12 @@ ] }, { - "name": "[431]", - "element-type": "431", + "name": "[437]", + "element-type": "437", "meta-type": "array" }, { - "name": "431", + "name": "437", "members": [ { "name": "name", @@ -18198,12 +18366,12 @@ "meta-type": "object" }, { - "name": "[432]", - "element-type": "432", + "name": "[438]", + "element-type": "438", "meta-type": "array" }, { - "name": "432", + "name": "438", "members": [ { "name": "case", @@ -18217,12 +18385,12 @@ "meta-type": "object" }, { - "name": "[433]", - "element-type": "433", + "name": "[439]", + "element-type": "439", "meta-type": "array" }, { - "name": "433", + "name": "439", "members": [ { "name": "type", @@ -18232,7 +18400,7 @@ "meta-type": "object" }, { - "name": "434", + "name": "440", "meta-type": "enum", "values": [ "uninitialized", @@ -18243,7 +18411,7 @@ ] }, { - "name": "435", + "name": "441", "members": [ { "name": "desc", @@ -18258,7 +18426,7 @@ "meta-type": "object" }, { - "name": "436", + "name": "442", "members": [ { "name": "device", @@ -18282,27 +18450,27 @@ "meta-type": "object" }, { - "name": "437", + "name": "443", "members": [ { "name": "bus", - "type": "490" + "type": "492" }, { "name": "devices", "default": null, - "type": "[332]" + "type": "[335]" } ], "meta-type": "object" }, { - "name": "[438]", - "element-type": "438", + "name": "[444]", + "element-type": "444", "meta-type": "array" }, { - "name": "438", + "name": "444", "members": [ { "name": "bar", @@ -18334,7 +18502,7 @@ "meta-type": "object" }, { - "name": "439", + "name": "445", "meta-type": "enum", "values": [ "string", @@ -18344,7 +18512,7 @@ ] }, { - "name": "440", + "name": "446", "members": [ { "name": "id", @@ -18383,7 +18551,7 @@ "meta-type": "object" }, { - "name": "441", + "name": "447", "meta-type": "enum", "values": [ "unknown", @@ -18394,7 +18562,7 @@ ] }, { - "name": "442", + "name": "448", "meta-type": "enum", "values": [ "qcow2", @@ -18403,37 +18571,37 @@ ] }, { - "name": "443", + "name": "449", "members": [ { "name": "data", - "type": "491" + "type": "493" } ], "meta-type": "object" }, { - "name": "444", + "name": "450", "members": [ { "name": "data", - "type": "492" + "type": "494" } ], "meta-type": "object" }, { - "name": "445", + "name": "451", "members": [ { "name": "data", - "type": "493" + "type": "495" } ], "meta-type": "object" }, { - "name": "446", + "name": "452", "meta-type": "enum", "values": [ "l1_update", @@ -18473,75 +18641,31 @@ "flush_to_disk", "pwritev_rmw_head", "pwritev_rmw_after_head", - "pwritev_rmw_tail", - "pwritev_rmw_after_tail", - "pwritev", - "pwritev_zero", - "pwritev_done", - "empty_image_prepare", - "l1_shrink_write_table", - "l1_shrink_free_l2_clusters", - "cor_write" - ] - }, - { - "name": "447", - "meta-type": "enum", - "values": [ - "inet", - "unix", - "vsock", - "fd" + "pwritev_rmw_tail", + "pwritev_rmw_after_tail", + "pwritev", + "pwritev_zero", + "pwritev_done", + "empty_image_prepare", + "l1_shrink_write_table", + "l1_shrink_free_l2_clusters", + "cor_write" ] }, { - "name": "448", - "members": [ - { - "name": "path", - "type": "str" - } - ], - "meta-type": "object" - }, - { - "name": "449", - "members": [ - { - "name": "cid", - "type": "str" - }, - { - "name": "port", - "type": "str" - } - ], - "meta-type": "object" - }, - { - "name": "450", - "members": [ - { - "name": "str", - "type": "str" - } - ], - "meta-type": "object" - }, - { - "name": "451", + "name": "453", "meta-type": "enum", "values": [ "inet" ] }, { - "name": "452", + "name": "454", "members": [ { "name": "template", "default": null, - "type": "453" + "type": "455" }, { "name": "main-header", @@ -18592,7 +18716,7 @@ "meta-type": "object" }, { - "name": "453", + "name": "455", "meta-type": "enum", "values": [ "none", @@ -18602,7 +18726,7 @@ ] }, { - "name": "454", + "name": "456", "meta-type": "enum", "values": [ "aes", @@ -18610,7 +18734,7 @@ ] }, { - "name": "455", + "name": "457", "members": [ { "name": "key-secret", @@ -18621,7 +18745,7 @@ "meta-type": "object" }, { - "name": "456", + "name": "458", "members": [ { "name": "key-secret", @@ -18632,14 +18756,14 @@ "meta-type": "object" }, { - "name": "457", + "name": "459", "meta-type": "enum", "values": [ "aes" ] }, { - "name": "458", + "name": "460", "meta-type": "enum", "values": [ "none", @@ -18648,11 +18772,11 @@ ] }, { - "name": "459", + "name": "461", "members": [ { "name": "type", - "type": "494" + "type": "496" }, { "name": "hash", @@ -18662,7 +18786,7 @@ "meta-type": "object" }, { - "name": "460", + "name": "462", "meta-type": "enum", "values": [ "off", @@ -18672,7 +18796,7 @@ ] }, { - "name": "461", + "name": "463", "meta-type": "enum", "values": [ "aes-128", @@ -18690,7 +18814,7 @@ ] }, { - "name": "462", + "name": "464", "meta-type": "enum", "values": [ "ecb", @@ -18700,7 +18824,7 @@ ] }, { - "name": "463", + "name": "465", "meta-type": "enum", "values": [ "plain", @@ -18709,7 +18833,7 @@ ] }, { - "name": "464", + "name": "466", "meta-type": "enum", "values": [ "md5", @@ -18722,28 +18846,28 @@ ] }, { - "name": "465", + "name": "467", "tag": "format", "variants": [ { "case": "qcow", - "type": "455" + "type": "457" }, { "case": "luks", - "type": "496" + "type": "498" } ], "members": [ { "name": "format", - "type": "495" + "type": "497" } ], "meta-type": "object" }, { - "name": "466", + "name": "468", "meta-type": "enum", "values": [ "v2", @@ -18751,28 +18875,28 @@ ] }, { - "name": "467", + "name": "469", "tag": "type", "variants": [ { "case": "full", - "type": "498" + "type": "500" }, { "case": "erasure-coded", - "type": "499" + "type": "501" } ], "members": [ { "name": "type", - "type": "497" + "type": "499" } ], "meta-type": "object" }, { - "name": "468", + "name": "470", "meta-type": "enum", "values": [ "dynamic", @@ -18780,7 +18904,7 @@ ] }, { - "name": "469", + "name": "471", "meta-type": "enum", "values": [ "monolithicSparse", @@ -18791,7 +18915,7 @@ ] }, { - "name": "470", + "name": "472", "meta-type": "enum", "values": [ "ide", @@ -18801,7 +18925,7 @@ ] }, { - "name": "471", + "name": "473", "meta-type": "enum", "values": [ "dynamic", @@ -18809,7 +18933,7 @@ ] }, { - "name": "472", + "name": "474", "members": [ { "name": "logfile", @@ -18839,7 +18963,7 @@ "meta-type": "object" }, { - "name": "473", + "name": "475", "members": [ { "name": "logfile", @@ -18859,7 +18983,7 @@ "meta-type": "object" }, { - "name": "474", + "name": "476", "members": [ { "name": "logfile", @@ -18873,13 +18997,18 @@ }, { "name": "addr", - "type": "273" + "type": "274" }, { "name": "tls-creds", "default": null, "type": "str" }, + { + "name": "tls-authz", + "default": null, + "type": "str" + }, { "name": "server", "default": null, @@ -18919,7 +19048,7 @@ "meta-type": "object" }, { - "name": "475", + "name": "477", "members": [ { "name": "logfile", @@ -18933,18 +19062,18 @@ }, { "name": "remote", - "type": "273" + "type": "274" }, { "name": "local", "default": null, - "type": "273" + "type": "274" } ], "meta-type": "object" }, { - "name": "476", + "name": "478", "members": [ { "name": "logfile", @@ -18960,7 +19089,7 @@ "meta-type": "object" }, { - "name": "477", + "name": "479", "members": [ { "name": "logfile", @@ -18980,7 +19109,7 @@ "meta-type": "object" }, { - "name": "478", + "name": "480", "members": [ { "name": "logfile", @@ -19001,7 +19130,7 @@ "meta-type": "object" }, { - "name": "479", + "name": "481", "members": [ { "name": "logfile", @@ -19021,7 +19150,7 @@ "meta-type": "object" }, { - "name": "480", + "name": "482", "members": [ { "name": "logfile", @@ -19041,7 +19170,7 @@ "meta-type": "object" }, { - "name": "481", + "name": "483", "members": [ { "name": "logfile", @@ -19077,7 +19206,7 @@ "meta-type": "object" }, { - "name": "482", + "name": "484", "members": [ { "name": "logfile", @@ -19098,7 +19227,7 @@ "meta-type": "object" }, { - "name": "483", + "name": "485", "members": [ { "name": "path", @@ -19114,7 +19243,7 @@ "meta-type": "object" }, { - "name": "484", + "name": "486", "members": [ { "name": "chardev", @@ -19124,7 +19253,7 @@ "meta-type": "object" }, { - "name": "485", + "name": "487", "meta-type": "enum", "values": [ "unmapped", @@ -19278,11 +19407,11 @@ ] }, { - "name": "486", + "name": "488", "members": [ { "name": "key", - "type": "296" + "type": "297" }, { "name": "down", @@ -19292,11 +19421,11 @@ "meta-type": "object" }, { - "name": "487", + "name": "489", "members": [ { "name": "button", - "type": "500" + "type": "502" }, { "name": "down", @@ -19306,11 +19435,11 @@ "meta-type": "object" }, { - "name": "488", + "name": "490", "members": [ { "name": "axis", - "type": "501" + "type": "503" }, { "name": "value", @@ -19320,13 +19449,13 @@ "meta-type": "object" }, { - "name": "489", + "name": "491", "members": [ ], "meta-type": "object" }, { - "name": "490", + "name": "492", "members": [ { "name": "number", @@ -19342,26 +19471,36 @@ }, { "name": "io_range", - "type": "502" + "type": "504" }, { "name": "memory_range", - "type": "502" + "type": "504" }, { "name": "prefetchable_range", - "type": "502" + "type": "504" } ], "meta-type": "object" }, { - "name": "491", + "name": "493", "members": [ { "name": "compat", "type": "str" }, + { + "name": "data-file", + "default": null, + "type": "str" + }, + { + "name": "data-file-raw", + "default": null, + "type": "bool" + }, { "name": "lazy-refcounts", "default": null, @@ -19379,13 +19518,18 @@ { "name": "encrypt", "default": null, - "type": "503" + "type": "505" + }, + { + "name": "bitmaps", + "default": null, + "type": "[506]" } ], "meta-type": "object" }, { - "name": "492", + "name": "494", "members": [ { "name": "create-type", @@ -19401,34 +19545,34 @@ }, { "name": "extents", - "type": "[232]" + "type": "[233]" } ], "meta-type": "object" }, { - "name": "493", + "name": "495", "members": [ { "name": "cipher-alg", - "type": "461" + "type": "463" }, { "name": "cipher-mode", - "type": "462" + "type": "464" }, { "name": "ivgen-alg", - "type": "463" + "type": "465" }, { "name": "ivgen-hash-alg", "default": null, - "type": "464" + "type": "466" }, { "name": "hash-alg", - "type": "464" + "type": "466" }, { "name": "payload-offset", @@ -19444,13 +19588,13 @@ }, { "name": "slots", - "type": "[504]" + "type": "[507]" } ], "meta-type": "object" }, { - "name": "494", + "name": "496", "meta-type": "enum", "values": [ "md5", @@ -19458,7 +19602,7 @@ ] }, { - "name": "495", + "name": "497", "meta-type": "enum", "values": [ "qcow", @@ -19466,7 +19610,7 @@ ] }, { - "name": "496", + "name": "498", "members": [ { "name": "key-secret", @@ -19476,27 +19620,27 @@ { "name": "cipher-alg", "default": null, - "type": "461" + "type": "463" }, { "name": "cipher-mode", "default": null, - "type": "462" + "type": "464" }, { "name": "ivgen-alg", "default": null, - "type": "463" + "type": "465" }, { "name": "ivgen-hash-alg", "default": null, - "type": "464" + "type": "466" }, { "name": "hash-alg", "default": null, - "type": "464" + "type": "466" }, { "name": "iter-time", @@ -19507,7 +19651,7 @@ "meta-type": "object" }, { - "name": "497", + "name": "499", "meta-type": "enum", "values": [ "full", @@ -19515,7 +19659,7 @@ ] }, { - "name": "498", + "name": "500", "members": [ { "name": "copies", @@ -19525,7 +19669,7 @@ "meta-type": "object" }, { - "name": "499", + "name": "501", "members": [ { "name": "data-strips", @@ -19539,7 +19683,7 @@ "meta-type": "object" }, { - "name": "500", + "name": "502", "meta-type": "enum", "values": [ "left", @@ -19552,7 +19696,7 @@ ] }, { - "name": "501", + "name": "503", "meta-type": "enum", "values": [ "x", @@ -19560,7 +19704,7 @@ ] }, { - "name": "502", + "name": "504", "members": [ { "name": "base", @@ -19574,12 +19718,12 @@ "meta-type": "object" }, { - "name": "503", + "name": "505", "tag": "format", "variants": [ { "case": "luks", - "type": "493" + "type": "495" }, { "case": "aes", @@ -19589,23 +19733,46 @@ "members": [ { "name": "format", - "type": "454" + "type": "456" + } + ], + "meta-type": "object" + }, + { + "name": "[506]", + "element-type": "506", + "meta-type": "array" + }, + { + "name": "506", + "members": [ + { + "name": "name", + "type": "str" + }, + { + "name": "granularity", + "type": "int" + }, + { + "name": "flags", + "type": "[508]" } ], "meta-type": "object" }, { - "name": "[232]", - "element-type": "232", + "name": "[233]", + "element-type": "233", "meta-type": "array" }, { - "name": "[504]", - "element-type": "504", + "name": "[507]", + "element-type": "507", "meta-type": "array" }, { - "name": "504", + "name": "507", "members": [ { "name": "active", @@ -19627,6 +19794,19 @@ } ], "meta-type": "object" + }, + { + "name": "[508]", + "element-type": "508", + "meta-type": "array" + }, + { + "name": "508", + "meta-type": "enum", + "values": [ + "in-use", + "auto" + ] } ], "id": "libvirt-44" @@ -19758,7 +19938,6 @@ "fma": true, "cx16": true, "de": true, - "pconfig": false, "stepping": 3, "xsave": true, "clflush": true, @@ -19829,7 +20008,7 @@ "rdseed": true, "avx512-4vnniw": false, "vme": true, - "vmx": false, + "vmx": true, "dtes64": false, "mtrr": true, "rdtscp": true, @@ -19965,7 +20144,6 @@ "fma": true, "cx16": true, "de": true, - "pconfig": false, "stepping": 3, "xsave": true, "clflush": true, @@ -20036,7 +20214,7 @@ "rdseed": true, "avx512-4vnniw": false, "vme": true, - "vmx": false, + "vmx": true, "dtes64": false, "mtrr": true, "rdtscp": true, @@ -20078,6 +20256,7 @@ "hv-frequencies": false, "tsc-frequency": 0, "xd": true, + "x-intel-pt-auto-level": true, "hv-vendor-id": "", "kvm-asyncpf": true, "kvm_asyncpf": true, @@ -20216,7 +20395,6 @@ "fma": true, "cx16": true, "de": true, - "pconfig": false, "enforce": false, "stepping": 3, "xsave": true, @@ -20313,7 +20491,7 @@ "rdrand": true, "rdseed": true, "avx512-4vnniw": false, - "vmx": false, + "vmx": true, "vme": true, "dtes64": false, "mtrr": true, @@ -20463,7 +20641,6 @@ "fma": true, "cx16": true, "de": true, - "pconfig": false, "stepping": 3, "xsave": true, "clflush": true, @@ -20519,7 +20696,7 @@ "avx512er": false, "pmm-en": false, "pcid": true, - "arch-capabilities": true, + "arch-capabilities": false, "3dnow": false, "erms": true, "lahf-lm": true, @@ -20534,7 +20711,7 @@ "rdseed": true, "avx512-4vnniw": false, "vme": true, - "vmx": false, + "vmx": true, "dtes64": false, "mtrr": true, "rdtscp": true, @@ -20670,7 +20847,6 @@ "fma": true, "cx16": true, "de": true, - "pconfig": false, "stepping": 3, "xsave": true, "clflush": true, @@ -20726,7 +20902,7 @@ "avx512er": false, "pmm-en": false, "pcid": true, - "arch-capabilities": true, + "arch-capabilities": false, "3dnow": false, "erms": true, "lahf-lm": true, @@ -20741,7 +20917,7 @@ "rdseed": true, "avx512-4vnniw": false, "vme": true, - "vmx": false, + "vmx": true, "dtes64": false, "mtrr": true, "rdtscp": true, @@ -20783,6 +20959,7 @@ "hv-frequencies": false, "tsc-frequency": 0, "xd": true, + "x-intel-pt-auto-level": true, "hv-vendor-id": "", "kvm-asyncpf": true, "kvm_asyncpf": true, @@ -20921,7 +21098,6 @@ "fma": true, "cx16": true, "de": true, - "pconfig": false, "enforce": false, "stepping": 3, "xsave": true, @@ -20997,7 +21173,7 @@ "avx512er": false, "pmm-en": false, "pcid": true, - "arch-capabilities": true, + "arch-capabilities": false, "3dnow": false, "erms": true, "lahf-lm": true, @@ -21018,7 +21194,7 @@ "rdrand": true, "rdseed": true, "avx512-4vnniw": false, - "vmx": false, + "vmx": true, "vme": true, "dtes64": false, "mtrr": true, @@ -21482,13 +21658,11 @@ "avx512f", "avx512dq", "rdseed", - "intel-pt", "avx512cd", "avx512bw", "avx512vl", "avx512vbmi", "umip", - "", "avx512vbmi2", "gfni", "vaes", @@ -21496,7 +21670,6 @@ "avx512vnni", "avx512bitalg", "avx512-vpopcntdq", - "pconfig", "spec-ctrl", "ssbd", "3dnowprefetch", @@ -21522,10 +21695,8 @@ "invpcid", "rtm", "rdseed", - "intel-pt", "avx512vbmi", "umip", - "", "avx512vbmi2", "gfni", "vaes", @@ -21687,11 +21858,9 @@ "avx512f", "avx512dq", "rdseed", - "intel-pt", "avx512cd", "avx512bw", "avx512vl", - "", "avx512vnni", "spec-ctrl", "ssbd", @@ -21921,7 +22090,6 @@ "fma": false, "cx16": true, "de": true, - "pconfig": false, "stepping": 3, "xsave": true, "clflush": true, @@ -22128,7 +22296,6 @@ "fma": false, "cx16": true, "de": true, - "pconfig": false, "stepping": 3, "xsave": true, "clflush": true, @@ -22241,6 +22408,7 @@ "hv-frequencies": false, "tsc-frequency": 0, "xd": true, + "x-intel-pt-auto-level": true, "hv-vendor-id": "", "kvm-asyncpf": false, "kvm_asyncpf": false, @@ -22379,7 +22547,6 @@ "fma": false, "cx16": true, "de": true, - "pconfig": false, "enforce": false, "stepping": 3, "xsave": true, @@ -22626,7 +22793,6 @@ "fma": false, "cx16": true, "de": true, - "pconfig": false, "stepping": 3, "xsave": true, "clflush": true, @@ -22833,7 +22999,6 @@ "fma": false, "cx16": true, "de": true, - "pconfig": false, "stepping": 3, "xsave": true, "clflush": true, @@ -22946,6 +23111,7 @@ "hv-frequencies": false, "tsc-frequency": 0, "xd": true, + "x-intel-pt-auto-level": true, "hv-vendor-id": "", "kvm-asyncpf": false, "kvm_asyncpf": false, @@ -23084,7 +23250,6 @@ "fma": false, "cx16": true, "de": true, - "pconfig": false, "enforce": false, "stepping": 3, "xsave": true, diff --git a/tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml index f4be7017fe..ca7174e3b9 100644 --- a/tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml @@ -202,10 +202,10 @@ <flag name='virtio-pci-non-transitional'/> <flag name='overcommit'/> <flag name='query-current-machine'/> - <version>3001050</version> + <version>4000000</version> <kvmVersion>0</kvmVersion> <microcodeVersion>43100758</microcodeVersion> - <package>v3.1.0-1445-ga61faa3d02</package> + <package>v4.0.0</package> <arch>x86_64</arch> <hostCPU type='kvm' model='base' migratability='yes'> <property name='phys-bits' type='number' value='0'/> @@ -226,6 +226,7 @@ <property name='hv-frequencies' type='boolean' value='false'/> <property name='tsc-frequency' type='number' value='0'/> <property name='xd' type='boolean' value='true' migratable='yes'/> + <property name='x-intel-pt-auto-level' type='boolean' value='true' migratable='yes'/> <property name='hv-vendor-id' type='string' value=''/> <property name='kvm-asyncpf' type='boolean' value='true' migratable='yes'/> <property name='kvm_asyncpf' type='boolean' value='true' migratable='yes'/> @@ -364,7 +365,6 @@ <property name='fma' type='boolean' value='true' migratable='yes'/> <property name='cx16' type='boolean' value='true' migratable='yes'/> <property name='de' type='boolean' value='true' migratable='yes'/> - <property name='pconfig' type='boolean' value='false'/> <property name='enforce' type='boolean' value='false'/> <property name='stepping' type='number' value='3'/> <property name='xsave' type='boolean' value='true' migratable='yes'/> @@ -440,7 +440,7 @@ <property name='avx512er' type='boolean' value='false'/> <property name='pmm-en' type='boolean' value='false'/> <property name='pcid' type='boolean' value='true' migratable='yes'/> - <property name='arch-capabilities' type='boolean' value='true' migratable='no'/> + <property name='arch-capabilities' type='boolean' value='false'/> <property name='3dnow' type='boolean' value='false'/> <property name='erms' type='boolean' value='true' migratable='yes'/> <property name='lahf-lm' type='boolean' value='true' migratable='yes'/> @@ -461,7 +461,7 @@ <property name='rdrand' type='boolean' value='true' migratable='yes'/> <property name='rdseed' type='boolean' value='true' migratable='yes'/> <property name='avx512-4vnniw' type='boolean' value='false'/> - <property name='vmx' type='boolean' value='false'/> + <property name='vmx' type='boolean' value='true' migratable='yes'/> <property name='vme' type='boolean' value='true' migratable='yes'/> <property name='dtes64' type='boolean' value='false'/> <property name='mtrr' type='boolean' value='true' migratable='yes'/> @@ -496,6 +496,7 @@ <property name='hv-frequencies' type='boolean' value='false'/> <property name='tsc-frequency' type='number' value='0'/> <property name='xd' type='boolean' value='true' migratable='yes'/> + <property name='x-intel-pt-auto-level' type='boolean' value='true' migratable='yes'/> <property name='hv-vendor-id' type='string' value=''/> <property name='kvm-asyncpf' type='boolean' value='false'/> <property name='kvm_asyncpf' type='boolean' value='false'/> @@ -634,7 +635,6 @@ <property name='fma' type='boolean' value='false'/> <property name='cx16' type='boolean' value='true' migratable='yes'/> <property name='de' type='boolean' value='true' migratable='yes'/> - <property name='pconfig' type='boolean' value='false'/> <property name='enforce' type='boolean' value='false'/> <property name='stepping' type='number' value='3'/> <property name='xsave' type='boolean' value='true' migratable='yes'/> @@ -849,13 +849,11 @@ <blocker name='avx512f'/> <blocker name='avx512dq'/> <blocker name='clwb'/> - <blocker name='intel-pt'/> <blocker name='avx512cd'/> <blocker name='avx512bw'/> <blocker name='avx512vl'/> <blocker name='avx512vbmi'/> <blocker name='pku'/> - <blocker name=''/> <blocker name='avx512vbmi2'/> <blocker name='gfni'/> <blocker name='vaes'/> @@ -864,7 +862,6 @@ <blocker name='avx512bitalg'/> <blocker name='avx512-vpopcntdq'/> <blocker name='la57'/> - <blocker name='pconfig'/> <blocker name='wbnoinvd'/> <blocker name='avx512f'/> <blocker name='avx512f'/> @@ -872,10 +869,8 @@ <blocker name='pku'/> </cpu> <cpu type='kvm' name='Icelake-Client' usable='no'> - <blocker name='intel-pt'/> <blocker name='avx512vbmi'/> <blocker name='pku'/> - <blocker name=''/> <blocker name='avx512vbmi2'/> <blocker name='gfni'/> <blocker name='vaes'/> @@ -918,12 +913,10 @@ <blocker name='avx512f'/> <blocker name='avx512dq'/> <blocker name='clwb'/> - <blocker name='intel-pt'/> <blocker name='avx512cd'/> <blocker name='avx512bw'/> <blocker name='avx512vl'/> <blocker name='pku'/> - <blocker name=''/> <blocker name='avx512vnni'/> <blocker name='avx512f'/> <blocker name='avx512f'/> @@ -1122,13 +1115,11 @@ <blocker name='avx512f'/> <blocker name='avx512dq'/> <blocker name='rdseed'/> - <blocker name='intel-pt'/> <blocker name='avx512cd'/> <blocker name='avx512bw'/> <blocker name='avx512vl'/> <blocker name='avx512vbmi'/> <blocker name='umip'/> - <blocker name=''/> <blocker name='avx512vbmi2'/> <blocker name='gfni'/> <blocker name='vaes'/> @@ -1136,7 +1127,6 @@ <blocker name='avx512vnni'/> <blocker name='avx512bitalg'/> <blocker name='avx512-vpopcntdq'/> - <blocker name='pconfig'/> <blocker name='spec-ctrl'/> <blocker name='ssbd'/> <blocker name='3dnowprefetch'/> @@ -1156,10 +1146,8 @@ <blocker name='invpcid'/> <blocker name='rtm'/> <blocker name='rdseed'/> - <blocker name='intel-pt'/> <blocker name='avx512vbmi'/> <blocker name='umip'/> - <blocker name=''/> <blocker name='avx512vbmi2'/> <blocker name='gfni'/> <blocker name='vaes'/> @@ -1272,11 +1260,9 @@ <blocker name='avx512f'/> <blocker name='avx512dq'/> <blocker name='rdseed'/> - <blocker name='intel-pt'/> <blocker name='avx512cd'/> <blocker name='avx512bw'/> <blocker name='avx512vl'/> - <blocker name=''/> <blocker name='avx512vnni'/> <blocker name='spec-ctrl'/> <blocker name='ssbd'/> -- 2.20.1

2 1

[libvirt] [PATCH v2] qemu.conf: Make nvram list obsolete
by Michal Privoznik 30 Apr '19

30 Apr '19

Now that libvirt has firmware auto selection feature the nvram config knob is more or less obsolete. It still makes sense in cases where distro users are using does not provide FW descriptor files, therefore I'm not removing it. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- diff to v1: - Use more verbose wording as suggested by Dan. src/qemu/qemu.conf | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf index 334b4cd4ee..ace5e85e35 100644 --- a/src/qemu/qemu.conf +++ b/src/qemu/qemu.conf @@ -740,6 +740,14 @@ # Location of master nvram file # +# This configuration option is obsolete. Libvirt will follow the +# QEMU firmware metadata specification to automatically locate +# firmware images: +# +# https://git.qemu.org/gitweb.cgi?p=qemu.git;a=blob_plain;f=docs/interop/firm… +# +# These metadata files are distributed alongside any firmware +# images intended for use with QEMU. # When a domain is configured to use UEFI instead of standard # BIOS it may use a separate storage for UEFI variables. If # that's the case libvirt creates the variable store per domain -- 2.21.0

2 2

[libvirt] [PATCH v4 00/29] network: refactor to decouple virt drivers from network driver
by Daniel P. Berrangé 30 Apr '19

30 Apr '19

An update to v1: https://www.redhat.com/archives/libvir-list/2018-December/msg00681.html v2: https://www.redhat.com/archives/libvir-list/2019-February/msg01581.html v3: https://www.redhat.com/archives/libvir-list/2019-March/msg01259.html Currently the network driver registers a set of callbacks with the virt driver in order to handle allocating/releasing network ports associated with guest NICs. This series introduces a virNetworkPortPtr object and associated XML that describes a network port. The virt drivers now call public APIs associated with this new object to create/delete ports for guest NICs. Changed in 4: - Merged the ACKd patches which didn't depend on other un-acked parts - Improve bandwidth error messages - Ensure we set floor sum to zero when starting network - Misc fixes for previous review comments NB, I have not added missing docs for the new XML doc format yet. This is work in progress. Changed in v3: - Remove unused API symbol - Fix dist of test data files Changed in v2: - Fix many bugs related to upgrades with running VMs - Convert over bandwidth controls to the new APIs - Handle reconnecting VIFs to bridges during startup - Much much more that I can't remember Daniel P. Berrangé (29): network: ensure floor sum is reset to zero when starting networks network: explain reason for bandwidth floor rejection conf: don't pass interface type into virNetDevBandwidthParse network: use 'bridge' as actual type instead of 'network' virt drivers: don't handle type=network after resolving actual network type network: move re-attach of bridge device out of network driver network: move fixup for domain actual net def out of network driver conf: introduce virNetworkPortDefPtr struct and XML support network: make networkLogAllocation independent of domain conf conf: add APIs to convert virDomainNetDef to virNetworkPortDef network: convert networkAllocateActualDevice to virNetworkPortDef network: convert networkNotifyActualDevice to virNetworkPortDef network: convert networkReleaseActualDevice to virNetworkPortDef network: convert hook script to take a network port XML network: remove the virDomainNetBandwidthChangeAllowed callback network: introduce networkAllocatePort network: introduce networkNotifyPort network: introduce networkReleasePort network: introduce networkUpdatePortBandwidth network: add public APIs for network port object access: add permissions for network port objects remote: add support for new network port APIs virsh: add support for network port APIs conf: support recording ports against virNetworkObjPtr network: add implementation of network port APIs lxc, libxl: notify network driver of NICs during reconnect lxc, libxl: save domain status after reconnect conf: record a portid against the domain conf conf: switch over to use network port APIs for virt drivers docs/formatdomain.html.in | 8 + docs/hooks.html.in | 24 +- docs/schemas/domaincommon.rng | 5 + include/libvirt/libvirt-network.h | 122 ++ include/libvirt/virterror.h | 3 + src/access/genpolkit.pl | 2 +- src/access/viraccessdriver.h | 6 + src/access/viraccessdrivernop.c | 11 + src/access/viraccessdriverpolkit.c | 26 + src/access/viraccessdriverstack.c | 25 + src/access/viraccessmanager.c | 16 + src/access/viraccessmanager.h | 6 + src/access/viraccessperm.c | 6 + src/access/viraccessperm.h | 44 + src/conf/Makefile.inc.am | 2 + src/conf/domain_conf.c | 549 +++++++- src/conf/domain_conf.h | 49 +- src/conf/netdev_bandwidth_conf.c | 22 +- src/conf/netdev_bandwidth_conf.h | 2 +- src/conf/network_conf.c | 4 +- src/conf/virnetworkobj.c | 303 ++++ src/conf/virnetworkobj.h | 34 + src/conf/virnetworkportdef.c | 515 +++++++ src/conf/virnetworkportdef.h | 112 ++ src/datatypes.c | 60 + src/datatypes.h | 41 + src/driver-network.h | 41 + src/libvirt-network.c | 444 ++++++ src/libvirt_private.syms | 23 +- src/libvirt_public.syms | 15 + src/libxl/libxl_conf.c | 21 +- src/libxl/libxl_driver.c | 33 + src/lxc/lxc_driver.c | 15 +- src/lxc/lxc_process.c | 35 + src/network/bridge_driver.c | 1219 +++++++++-------- src/qemu/qemu_command.c | 8 +- src/qemu/qemu_driver.c | 10 +- src/qemu/qemu_hotplug.c | 13 +- src/qemu/qemu_interface.c | 12 +- src/qemu/qemu_process.c | 5 +- src/remote/remote_daemon_dispatch.c | 73 + src/remote/remote_driver.c | 69 + src/remote/remote_protocol.x | 124 +- src/remote_protocol-structs | 69 + src/rpc/gendispatch.pl | 18 +- src/util/virerror.c | 9 + src/util/virhook.c | 4 +- src/util/virhook.h | 4 +- tests/Makefile.am | 7 + .../net-virtio-network-portgroup.xml | 6 +- tests/virnetdevbandwidthtest.c | 2 +- .../plug-bridge-mactbl.xml | 9 + .../virnetworkportxml2xmldata/plug-bridge.xml | 12 + .../virnetworkportxml2xmldata/plug-direct.xml | 12 + .../plug-hostdev-pci.xml | 12 + tests/virnetworkportxml2xmldata/plug-none.xml | 8 + tests/virnetworkportxml2xmltest.c | 104 ++ tools/virsh-completer.c | 50 + tools/virsh-completer.h | 4 + tools/virsh-network.c | 399 +++++- tools/virsh-network.h | 5 + 61 files changed, 4171 insertions(+), 720 deletions(-) create mode 100644 src/conf/virnetworkportdef.c create mode 100644 src/conf/virnetworkportdef.h create mode 100644 tests/virnetworkportxml2xmldata/plug-bridge-mactbl.xml create mode 100644 tests/virnetworkportxml2xmldata/plug-bridge.xml create mode 100644 tests/virnetworkportxml2xmldata/plug-direct.xml create mode 100644 tests/virnetworkportxml2xmldata/plug-hostdev-pci.xml create mode 100644 tests/virnetworkportxml2xmldata/plug-none.xml create mode 100644 tests/virnetworkportxml2xmltest.c -- 2.20.1

3 39

[libvirt] [PATCH v2] test_driver: provide virDomainGetTime implementation
by Ilias Stamatis 30 Apr '19

30 Apr '19

Implement testDomainGetTime by returning a fixed timestamp. Signed-off-by: Ilias Stamatis <stamatis.iliass(a)gmail.com> --- src/test/test_driver.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index d5eecf4b7f..9b78c5c2ca 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -1943,6 +1943,18 @@ testDomainGetState(virDomainPtr domain, return 0; } +static int +testDomainGetTime(virDomainPtr dom ATTRIBUTE_UNUSED, + long long *seconds, + unsigned int *nseconds, + unsigned int flags ATTRIBUTE_UNUSED) +{ + *seconds = 627319920; + *nseconds = 0; + + return 0; +} + #define TEST_SAVE_MAGIC "TestGuestMagic" static int @@ -6786,6 +6798,7 @@ static virHypervisorDriver testHypervisorDriver = { .domainSetMemory = testDomainSetMemory, /* 0.1.4 */ .domainGetInfo = testDomainGetInfo, /* 0.1.1 */ .domainGetState = testDomainGetState, /* 0.9.2 */ + .domainGetTime = testDomainGetTime, /* 5.3.0 */ .domainSave = testDomainSave, /* 0.3.2 */ .domainSaveFlags = testDomainSaveFlags, /* 0.9.4 */ .domainRestore = testDomainRestore, /* 0.3.2 */ -- 2.21.0

3 4

[libvirt] [PATCH] qemu_command: fix double_close vhostfd in qemuBuildHostdevCommandLine
by Jie Wang 30 Apr '19

30 Apr '19

vhostfd passed to cmd->passfd in virCommandPassFD, virCommandFree will always close cmd->passfd when qemuBuildSCSIVHostHostdevDevStr failed. Signed-off-by: Jie Wang <wangjie88(a)huawei.com> --- src/qemu/qemu_command.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 029780fe86..3fc2dfa2f1 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -5819,7 +5819,6 @@ qemuBuildHostdevCommandLine(virCommandPtr cmd, qemuCaps, vhostfdName))) { VIR_FREE(vhostfdName); - VIR_FORCE_CLOSE(vhostfd); return -1; } virCommandAddArg(cmd, devstr); -- 2.16.2.windows.1

2 1

[libvirt] [PATCH] util: Fix uninitalized variable to avoid garbage value.
by Julio Faracco 30 Apr '19

30 Apr '19

This commit is similar with 692400f4. It fixes an uninitialized variable to avoid garbage value. This case, returns 0 jiffies if an error occurs with virNetDevBridgeGet. Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- src/util/virnetdevbridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virnetdevbridge.c b/src/util/virnetdevbridge.c index 0f301d9216..4f21a82fb7 100644 --- a/src/util/virnetdevbridge.c +++ b/src/util/virnetdevbridge.c @@ -713,7 +713,7 @@ int virNetDevBridgeGetSTPDelay(const char *brname, int *delayms) { int ret = -1; - unsigned long val; + unsigned long val = 0; ret = virNetDevBridgeGet(brname, "forward_delay", &val); *delayms = JIFFIES_TO_MS(val); -- 2.20.1

2 1

[libvirt] [PATCH 00/21] qemu: qapi: Schema query improvements and feature detection (blockdev-add saga)
by Peter Krempa 30 Apr '19

30 Apr '19

Allow detecting dynamic auto-read-only which will be possible in qemu 4.1 by fixing and improving QAPI schema queries. Note that the last two patches should not be pushed and will require tweaking once qemu 4.0 is released. Peter Krempa (21): tests: qemumonitorjson: Rename schema validation test cases qemu: qapi: Use automatic memory cleanup tests: qemumonitorjson: Add tests for QAPI schema query qemu: qapi: Fix return value of impossible case in virQEMUQAPISchemaTraverse qemu: qapi: Return schema entry via argument in virQEMUQAPISchemaTraverse qemu: qapi: Modify values returned by virQEMUQAPISchemaPathGet qemu: qapi: Convert virQEMUQAPISchemaTraverse to recursive lookup qemu: qapi: Separate virQEMUQAPISchemaTraverse into functions by object type qemu: qapi: Optimize out some helper functions qemu: qapi: Convert arguments of QAPI traversal helpers to a struct qemu: qapi: Rename local vars in virQEMUQAPISchemaTraverseObject qemu: qapi: Add helpers for virQEMUQAPISchemaTraverseContext qemu: qapi: Use declarative approach for meta-type parsers in virQEMUQAPISchemaTraverse qemu: qapi: Report schema and user errors for QAPI queries qemu: qapi: Prepare for extension of virQEMUQAPISchemaPathGet docs qemu: qapi: Implement worker for introspecting enums qemu: qapi: Implement worker for introspecting builtin types qemu: qapi: Implement worker for introspecting alternate types qemu: qapi: Implement support for 'features' DO NOT PUSH: bump capabilities to 4.0.0 + patches qemu: caps: Add capability for dynamic 'auto-read-only' support for files src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_qapi.c | 419 ++- .../qemu_4.0.0.x86_64.xml | 2 +- .../caps_4.0.0.x86_64.replies | 3167 +++++++++-------- .../caps_4.0.0.x86_64.xml | 27 +- tests/qemumonitorjsontest.c | 113 +- 7 files changed, 2081 insertions(+), 1654 deletions(-) -- 2.20.1

2 42

[libvirt] [PATCH] test: Use nodeInfo content for virNodeGetCPUMap
by Cole Robinson 29 Apr '19

29 Apr '19

Right now the test driver implementation of virNodeGetCPUMap uses hardcoded data. Instead use cpu data from our nodeInfo, which can be overridden with input test XML. This helps to emulate some virsh commands (vcpupin, hostcpumap) with a large number of host cpus. [1] The content reported for test:///default is now slightly different: previously it would report 8 total cpus with 0,2,4 online. Now it reports 16 cpus with all online, which is the pre-existing nodeInfo default. [1] https://www.redhat.com/archives/libvir-list/2019-March/msg02042.html Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- John, in trying to understand and test your bitmap patch, I added this to the test driver. I think there's a bigger issue at play but I'm still trying to work it out, I'll send a follow up email when I've collected my thoughts src/test/test_driver.c | 35 +++++++++++++++++++++++++++++------ 1 file changed, 29 insertions(+), 6 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index d5eecf4b7f..f00b6eb1c8 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -5811,23 +5811,46 @@ static int testConnectListAllDomains(virConnectPtr conn, } static int -testNodeGetCPUMap(virConnectPtr conn ATTRIBUTE_UNUSED, +testNodeGetCPUMap(virConnectPtr conn, unsigned char **cpumap, unsigned int *online, unsigned int flags) { + testDriverPtr privconn = conn->privateData; + int maxcpus = VIR_NODEINFO_MAXCPUS(privconn->nodeInfo); + virBitmapPtr cpus = NULL; + int ret = -1; + int dummy; + size_t i; + virCheckFlags(0, -1); + if (!cpumap && !online) + return maxcpus; + + if (!(cpus = virBitmapNew(maxcpus))) + goto cleanup; + if (cpumap) { - if (VIR_ALLOC_N(*cpumap, 1) < 0) - return -1; - *cpumap[0] = 0x15; + for (i = 0; i < privconn->nodeInfo.cpus; i++) { + if (virBitmapSetBit(cpus, i) < 0) + goto cleanup; + } + + if (virBitmapToData(cpus, cpumap, &dummy) < 0) + goto cleanup; } if (online) - *online = 3; + *online = privconn->nodeInfo.cpus; - return 8; + ret = maxcpus; + + cleanup: + if (ret < 0 && cpumap) + VIR_FREE(*cpumap); + VIR_FREE(cpus); + return ret; } static char * -- 2.21.0

2 1

[libvirt] [PATCH] docs: Fix typo in the firmware value
by Fabiano Fidêncio 29 Apr '19

29 Apr '19

firmware attribute from <os/> takes either 'efi' or 'bios' as its allowed values. However, the current documentation mistakenly mentions 'uefi' instead of 'efi'. Signed-off-by: Fabiano Fidêncio <fidencio(a)redhat.com> --- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index d27ab07cbb..e1da878fcc 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -128,7 +128,7 @@ <pre> ... -<os firmware='uefi'> +<os firmware='efi'> <type>hvm</type> <loader readonly='yes' secure='no' type='rom'>/usr/lib/xen/boot/hvmloader</loader> <nvram template='/usr/share/OVMF/OVMF_VARS.fd'>/var/lib/libvirt/nvram/guest_VARS.fd</nvram> -- 2.21.0

2 1

[libvirt] [PATCH 0/2] Fix a couple of minor doc issues
by John Ferlan 29 Apr '19

29 Apr '19

The QE processing of the feature found a couple of minor doc type issues so just fix an error message and add the command to the man page. Both are rather trivial, but I can wait for reviews rather than push directly as trivial.. John Ferlan (2): conf: Fix typo in error message virsh: Add source-protocol-ver to pool-define-as docs src/conf/storage_conf.c | 2 +- tools/virsh.pod | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) -- 2.20.1

2 3

[libvirt] [PATCH for 5.3.0] storage_backend_rbd: Don't fail iterating over snapshots
by Michal Privoznik 29 Apr '19

29 Apr '19

When cloning an RBD volume we try to find a snapshot which is not different to the image we're trying to clone. This boils down to calling rbd_diff_iterate() or rbd_diff_iterate2() on systems with newer ceph. These two are passed a callback - virStorageBackendRBDIterateCb() which mistakenly states that if a negative value is returned from the callback, the iteration is stopped but no error is reported. Well, that is not the case. I've looked into librbd sources and found that a negative value does mean stop of iteration but it also means an error. That's why any attempt to clone an RBD image results in the following error: virsh # vol-clone --pool rbd_image_root coreos_2023 coreos00.disk error: Failed to clone vol from coreos_2023 error: failed to iterate RBD snapshot coreos_2023@base: Operation not permitted Reported on libvirt-users list: https://www.redhat.com/archives/libvirt-users/2019-April/msg00060.html Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/storage/storage_backend_rbd.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c index f8c968e682..3fe188551c 100644 --- a/src/storage/storage_backend_rbd.c +++ b/src/storage/storage_backend_rbd.c @@ -1031,14 +1031,9 @@ virStorageBackendRBDIterateCb(uint64_t offset ATTRIBUTE_UNUSED, { /* * Just set that there is a diff for this snapshot, we do not care where - * - * When it returns a negative number the rbd_diff_iterate() function will stop - * - * That's why we return -1, meaning that there is a difference and we can stop - * searching any further. */ *(int*) arg = 1; - return -1; + return 0; } static int -- 2.21.0

2 2

[libvirt] [python PATCH] Allow virConnect.getDomainCapabilities() to have no arguments
by Michal Privoznik 29 Apr '19

29 Apr '19

Our C API allows no values to be passed (well, it accepts all NULLs). There's no reason that python binding should require all arguments. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- libvirt-override-api.xml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/libvirt-override-api.xml b/libvirt-override-api.xml index 7f578e0..53b15c5 100644 --- a/libvirt-override-api.xml +++ b/libvirt-override-api.xml @@ -754,5 +754,15 @@ <arg name='conn' type='virConnectPtr' info='pointer to hypervisor connection'/> <arg name='flags' type='int' info='unused, always pass 0'/> </function> + <function name='virConnectGetDomainCapabilities' file='libvirt-domain' module='libvirt-domain'> + <info>Query domain capabilities</info> + <return type='char *' info='NULL in case of error or an XML string defining the capabilities.'/> + <arg name='conn' type='virConnectPtr' info='pointer to the hypervisor connection'/> + <arg name='emulatorbin' type='const char *' info='optional path to emulator'/> + <arg name='arch' type='const char *' info='optional domain architecture'/> + <arg name='machine' type='const char *' info='optional machine type'/> + <arg name='virttype' type='const char *' info='optional virtualization type'/> + <arg name='flags' type='int' info='unused, always pass 0'/> + </function> </symbols> </api> -- 2.21.0

2 1

[libvirt] [PATCH] CONF: bug, release 'alloc' object in cleanup
by Wang Huaqiang 29 Apr '19

29 Apr '19

In case error happens before 'alloc' is transferred to 'resctrl', the 'alloc' object should be released. Signed-off-by: Wang Huaqiang <huaqiang.wang(a)intel.com> --- src/conf/domain_conf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 6331424..7d20276 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -19396,6 +19396,7 @@ virDomainCachetuneDefParse(virDomainDefPtr def, ret = 0; cleanup: + virObjectUnref(alloc); virDomainResctrlDefFree(resctrl); return ret; } @@ -19597,6 +19598,7 @@ virDomainMemorytuneDefParse(virDomainDefPtr def, ret = 0; cleanup: + virObjectUnref(alloc); virDomainResctrlDefFree(resctrl); return ret; } -- 2.7.4

3 2

[libvirt] [PATCH 0/4] Couple of almost trivial disk cold-/hot-plug fixes
by Michal Privoznik 29 Apr '19

29 Apr '19

*** BLURB HERE *** Michal Prívozník (4): src: Check for virDomainDiskInsert() retval properly qemuDomainAttachDeviceLiveAndConfig: Don't overwrite @ret qemu: On attach to live XML check for user alias collision only live XML qemu: Check for user alias collisions in coldplug src/libxl/libxl_driver.c | 2 +- src/lxc/lxc_driver.c | 2 +- src/qemu/qemu_driver.c | 32 ++++++++++++++++++-------------- 3 files changed, 20 insertions(+), 16 deletions(-) -- 2.21.0

3 10

[libvirt] [PATCH] qemu: Add entry for balloon stats stat-htlb-pgalloc and stat-htlb-pgfail
by Han Han 28 Apr '19

28 Apr '19

Qemu added reporting of virtio balloon new statistics stat-htlb-pgalloc and stat-htlb-pgfail since qemu-3.0 commit b7b12644297. The value of stat-htlb-pgalloc represents the number of successful hugetlb page allocations while stat-htlb-pgfail represents the number of failed ones. Add this statistics reporting to libvirt. Signed-off-by: Han Han <hhan(a)redhat.com> --- include/libvirt/libvirt-domain.h | 14 +++++++++++++- src/libvirt-domain.c | 5 ++++- src/qemu/qemu_driver.c | 2 ++ src/qemu/qemu_monitor_json.c | 5 +++++ tools/virsh-domain-monitor.c | 4 ++++ tools/virsh.pod | 2 ++ 6 files changed, 30 insertions(+), 2 deletions(-) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index 7d36820b5a..192d25c1db 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -636,11 +636,23 @@ typedef enum { */ VIR_DOMAIN_MEMORY_STAT_DISK_CACHES = 10, + /* + * The amount of successful hugetlb(Huge Page Tables) allocations via + * virtio balloon. + */ + VIR_DOMAIN_MEMORY_STAT_HUGETLB_PGALLOC = 11, + + /* + * The amount of failed hugetlb(Huge Page Tables) allocations via + * virtio balloon. + */ + VIR_DOMAIN_MEMORY_STAT_HUGETLB_PGFAIL = 12, + /* * The number of statistics supported by this version of the interface. * To add new statistics, add them to the enum and increase this value. */ - VIR_DOMAIN_MEMORY_STAT_NR = 11, + VIR_DOMAIN_MEMORY_STAT_NR = 13, # ifdef VIR_ENUM_SENTINELS VIR_DOMAIN_MEMORY_STAT_LAST = VIR_DOMAIN_MEMORY_STAT_NR diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 80284a99f0..a95690e8a4 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -5734,7 +5734,10 @@ virDomainGetInterfaceParameters(virDomainPtr domain, * VIR_DOMAIN_MEMORY_STAT_DISK_CACHES * Memory that can be reclaimed without additional I/O, typically disk * caches (in kb). - * + * VIR_DOMAIN_MEMORY_STAT_HUGETLB_PGALLOC + * The amount of successful hugetlb(Huge Page Tables) allocations + * VIR_DOMAIN_MEMORY_STAT_HUGETLB_PGFAIL + * The amount of failed hugetlb(Huge Page Tables) allocations * Returns: The number of stats provided or -1 in case of failure. */ int diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index f48d9256e4..2d849beac8 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -20245,6 +20245,8 @@ qemuDomainGetStatsBalloon(virQEMUDriverPtr driver, STORE_MEM_RECORD(LAST_UPDATE, "last-update") STORE_MEM_RECORD(USABLE, "usable") STORE_MEM_RECORD(DISK_CACHES, "disk_caches") + STORE_MEM_RECORD(HUGETLB_PGALLOC, "hugetlb_pgalloc") + STORE_MEM_RECORD(HUGETLB_PGFAIL, "hugetlb_pgfail") } #undef STORE_MEM_RECORD diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 908967f46c..5e3df5e759 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -2150,6 +2150,11 @@ int qemuMonitorJSONGetMemoryStats(qemuMonitorPtr mon, VIR_DOMAIN_MEMORY_STAT_LAST_UPDATE, 1); GET_BALLOON_STATS(statsdata, "stat-disk-caches", VIR_DOMAIN_MEMORY_STAT_DISK_CACHES, 1024); + GET_BALLOON_STATS(statsdata, "stat-htlb-pgalloc", + VIR_DOMAIN_MEMORY_STAT_HUGETLB_PGALLOC, 1); + GET_BALLOON_STATS(statsdata, "stat-htlb-pgfail", + VIR_DOMAIN_MEMORY_STAT_HUGETLB_PGFAIL, 1); + ret = got; cleanup: virJSONValueFree(cmd); diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index d87475f6f6..0092a9786e 100644 --- a/tools/virsh-domain-monitor.c +++ b/tools/virsh-domain-monitor.c @@ -376,6 +376,10 @@ cmdDomMemStat(vshControl *ctl, const vshCmd *cmd) vshPrint(ctl, "last_update %llu\n", stats[i].val); if (stats[i].tag == VIR_DOMAIN_MEMORY_STAT_DISK_CACHES) vshPrint(ctl, "disk_caches %llu\n", stats[i].val); + if (stats[i].tag == VIR_DOMAIN_MEMORY_STAT_HUGETLB_PGALLOC) + vshPrint(ctl, "hugetlb_pgalloc %llu\n", stats[i].val); + if (stats[i].tag == VIR_DOMAIN_MEMORY_STAT_HUGETLB_PGFAIL) + vshPrint(ctl, "hugetlb_pgfail %llu\n", stats[i].val); } ret = true; diff --git a/tools/virsh.pod b/tools/virsh.pod index afc1684db0..ef27c527d6 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -938,6 +938,8 @@ without causing host swapping (in KiB) last-update - Timestamp of the last update of statistics (in seconds) disk_caches - The amount of memory that can be reclaimed without additional I/O, typically disk caches (in KiB) + hugetlb_pgalloc - The number of successful huge page table allocations + hugetlb_pgfail - The number of failed huge page table allocations For QEMU/KVM with a memory balloon, setting the optional I<--period> to a value larger than 0 in seconds will allow the balloon driver to return -- 2.20.1

1 0

[libvirt] Plans for next release
by Daniel Veillard 26 Apr '19

26 Apr '19

I think we need to enter freeze soon if we want to release mid next week if we do so tomorrow, then we can push rc2 on Monday and have a release around May first. Any problem with that plan ? thanks, Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

2 1

[libvirt] [PATCH] storage: escape ipv6 for ceph mon hosts to librados
by Yi Li 26 Apr '19

26 Apr '19

Hosts for rbd are ceph monitor daemons. These have fixed IP addresses, so they are often referenced by IP rather than hostname for convenience, or to avoid relying on DNS. Using IPv4 addresses as the host name works already, but IPv6 addresses require rbd-specific escaping because the colon is used as an option separator in the string passed to librados. Escape these colons, and enclose the IPv6 address in square brackets so it is distinguished from the port, which is currently mandatory. Signed-off-by: Yi Li <yili(a)winhong.com> --- docs/schemas/storagepool.rng | 5 ++++- src/storage/storage_backend_rbd.c | 13 ++++++++++--- tests/storagepoolxml2xmlin/pool-rbd-ipv6.xml | 13 +++++++++++++ tests/storagepoolxml2xmlout/pool-rbd-ipv6.xml | 16 ++++++++++++++++ tests/storagepoolxml2xmltest.c | 1 + 5 files changed, 44 insertions(+), 4 deletions(-) create mode 100644 tests/storagepoolxml2xmlin/pool-rbd-ipv6.xml create mode 100644 tests/storagepoolxml2xmlout/pool-rbd-ipv6.xml diff --git a/docs/schemas/storagepool.rng b/docs/schemas/storagepool.rng index 3ca8e79..976a02b 100644 --- a/docs/schemas/storagepool.rng +++ b/docs/schemas/storagepool.rng @@ -305,7 +305,10 @@ <oneOrMore> <element name='host'> <attribute name='name'> - <text/> + <choice> + <ref name="dnsName"/> + <ref name="ipAddr"/> + </choice> </attribute> <optional> <attribute name='port'> diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c index f8c968e..3056563 100644 --- a/src/storage/storage_backend_rbd.c +++ b/src/storage/storage_backend_rbd.c @@ -268,9 +268,16 @@ virStorageBackendRBDOpenRADOSConn(virStorageBackendRBDStatePtr ptr, source->hosts[i].name); } else if (source->hosts[i].name != NULL && source->hosts[i].port) { - virBufferAsprintf(&mon_host, "%s:%d,", - source->hosts[i].name, - source->hosts[i].port); + /* assume host containing : is ipv6 */ + if (strchr(source->hosts[i].name, ':')) { + virBufferAsprintf(&mon_host, "[%s]:%d,", + source->hosts[i].name, + source->hosts[i].port); + } else { + virBufferAsprintf(&mon_host, "%s:%d,", + source->hosts[i].name, + source->hosts[i].port); + } } else { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("received malformed monitor, check the XML definition")); diff --git a/tests/storagepoolxml2xmlin/pool-rbd-ipv6.xml b/tests/storagepoolxml2xmlin/pool-rbd-ipv6.xml new file mode 100644 index 0000000..0744b33 --- /dev/null +++ b/tests/storagepoolxml2xmlin/pool-rbd-ipv6.xml @@ -0,0 +1,13 @@ +<pool type='rbd'> + <name>ceph</name> + <uuid>47c1faee-0207-e741-f5ae-d9b019b98fe2</uuid> + <source> + <name>rbd</name> + <host name='localhost' port='6789'/> + <host name='localhost' port='6790'/> + <host name='2205::192:168:205:141' port='6789'/> + <auth username='admin' type='ceph'> + <secret uuid='2ec115d7-3a88-3ceb-bc12-0ac909a6fd87'/> + </auth> + </source> +</pool> diff --git a/tests/storagepoolxml2xmlout/pool-rbd-ipv6.xml b/tests/storagepoolxml2xmlout/pool-rbd-ipv6.xml new file mode 100644 index 0000000..cc2a379 --- /dev/null +++ b/tests/storagepoolxml2xmlout/pool-rbd-ipv6.xml @@ -0,0 +1,16 @@ +<pool type='rbd'> + <name>ceph</name> + <uuid>47c1faee-0207-e741-f5ae-d9b019b98fe2</uuid> + <capacity unit='bytes'>0</capacity> + <allocation unit='bytes'>0</allocation> + <available unit='bytes'>0</available> + <source> + <host name='localhost' port='6789'/> + <host name='localhost' port='6790'/> + <host name='2205::192:168:205:141' port='6789'/> + <name>rbd</name> + <auth type='ceph' username='admin'> + <secret uuid='2ec115d7-3a88-3ceb-bc12-0ac909a6fd87'/> + </auth> + </source> +</pool> diff --git a/tests/storagepoolxml2xmltest.c b/tests/storagepoolxml2xmltest.c index 2ae514f..b6f4cb4 100644 --- a/tests/storagepoolxml2xmltest.c +++ b/tests/storagepoolxml2xmltest.c @@ -95,6 +95,7 @@ mymain(void) DO_TEST("pool-zfs-sourcedev"); DO_TEST("pool-rbd"); #ifdef WITH_STORAGE_RBD + DO_TEST("pool-rbd-ipv6"); DO_TEST("pool-rbd-refresh-volume-allocation"); DO_TEST("pool-rbd-ns-configopts"); #endif -- 2.7.5

2 1

[libvirt] [PATCH] virsh: Put a new line char after <alias/> in attach-disk
by Michal Privoznik 26 Apr '19

26 Apr '19

Each attribute is on its own line. We forgot to add new line character for <alias/> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under trivial rule. tools/virsh-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index da57d96d1a..82140feb57 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -683,7 +683,7 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd) virBufferAsprintf(&buf, "<serial>%s</serial>\n", serial); if (alias) - virBufferAsprintf(&buf, "<alias name='%s'/>", alias); + virBufferAsprintf(&buf, "<alias name='%s'/>\n", alias); if (wwn) virBufferAsprintf(&buf, "<wwn>%s</wwn>\n", wwn); -- 2.21.0

1 0

[libvirt] [PATCH 0/2] Couple of interface type fixes
by Michal Privoznik 26 Apr '19

26 Apr '19

See the following link for more info: https://www.redhat.com/archives/libvir-list/2019-April/msg01412.html Be aware that these are very hackish and I don't like them. There's still one problem - virsh domiftune still doesn't work, as in it doesn't set floor on the network bridge because the code expects interface type of network but it sees type bridge. Michal Prívozník (2): conf: Parse bandwidth.floor for interface type='bridge' too qemu: Relax interface type change check when changing an interface src/conf/domain_conf.c | 7 ++++--- src/qemu/qemu_hotplug.c | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) -- 2.21.0

1 2

[libvirt] RFC: Introducing Memory Bandwidth Monitoring (MBM)
by Huaqiang,Wang 26 Apr '19

26 Apr '19

RFC: Introducing Memory Bandwidth Monitoring (MBM) ================================================== Kernel has removed the interfaces of getting memory bandwidth utilization interfaces from `perf` sub-module, refer to https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id…. Afterwards, kernel implements the `resctrl` sub-module and provides the alternative interfaces to allocate/monitor resource of cache/memory bandwidth. The cache monitoring based on `resctr` interface is already implemented, this RFC is to raise discussion on implement the memory bandwidth monitoring functionality. Very similar to the way of implementing 'cache monitoring', to support memory bandwidth monitoring, it could be considered in three aspects: * Identifying the host capability for MBM * Creating MBM groups * Reporting the result of the monitoring Identify the host capability of MBM ----------------------------------- Host MBM feature coud be identified through the standard way of enumerating host capability, such as command `virsh capability <domain>`. A host with MBM, the result of command above may contain following lines:: <capabilities> <host> … <cache> <bank id='0' level='3' type='both' size='15' unit='MiB' cpus='0-5'> <control granularity='768' min='1536' unit='KiB' type='both' maxAllocs='4'/> </bank> <monitor level='3' reuseThreshold='270336' maxMonitors='176'> <feature name='llc_occupancy'/> </monitor> </cache> <memory_bandwidth> <node id='0' cpus='0-5'> <control granularity='10' min ='10' maxAllocs='4'/> </node> <node id='1' cpus='6-11'> <control granularity='10' min ='10' maxAllocs='4'/> </node> + <monitor maxMonitors='176'> + <feature name='mbm_total_bytes'/> + <feature name='mbm_local_bytes'/> + </monitor> </memory_bandwidth> </host> </capabilities> The <monitor> element under <memory_bandwidth> indicates a memory bandwidth monitor exists, and the property 'maxMonitors' tells how many monitors could be generated, which is shared with cache monitor. The feature list inside the <monitor> element indicates MBM feature set. Create the MBM group -------------------- It is supported to create multiple monitors to a vm instance and each monitor is capable to track the memory bandwidth utilization accumulatively in bytes for specific vCPUs. To create a memory bandwidth monitor for specific vCPUs, for example create 2 memory bandwidth monitors, one is tracking the memory BW usage for vCPU0 and another is for vCPU 0-4, then you can set the request for two monitors in following way by editing the domain XML file:: <cputune> <memorytune vcpus='0-4'> <node id='0' bandwidth='20'/> <node id='1' bandwidth='30'/> + <monitor vcpus='0-4'/> + <monitor vcpus='0'/> </memorytune> </cputune> Report the result of monitor ---------------------------- The statistical results of memory bandwidth monitors could be demonstrated through command `virsh domstat <doman>` in following arrangement. virsh domstats <domain>:: ... memory.bw.monitor.count=<total number of MBM monitors> memory.bw.monitor.<monitor index>.name=<resctrl group name for this monitor> memory.bw.monitor.<monitor index>.vcpus=<vcpu set list monitored by this monitor> memory.bw.monitor.<monitor index>.controller.count=<memory controller number> memory.bw.monitor.<monitor index>.controller.<index>.local.bytes=<bytes> memory.bw.monitor.<monitor index>.controller.<index>.total.bytes=<bytes> ...

1 0

[libvirt] [PATCH] Handle copying bitmaps to larger data buffers
by Allen, John 25 Apr '19

25 Apr '19

If a bitmap of a shorter length than the data buffer is passed to virBitmapToDataBuf, it will read off the end of the bitmap and copy junk into the returned buffer. Add a check to only copy the length of the bitmap to the buffer. The problem can be observed after setting a vcpu affinity using the vcpupin command on a system with a large number of cores: # virsh vcpupin example_domain 0 0 # virsh vcpupin example_domain 0 VCPU CPU Affinity --------------------------- 0 0,192,197-198,202 Signed-off-by: John Allen <john.allen(a)amd.com> --- diff --git a/src/util/virbitmap.c b/src/util/virbitmap.c index d074f29e54..021174cbb3 100644 --- a/src/util/virbitmap.c +++ b/src/util/virbitmap.c @@ -824,11 +824,15 @@ virBitmapToDataBuf(virBitmapPtr bitmap, unsigned char *bytes, size_t len) { + size_t nbytes = bitmap->map_len * (VIR_BITMAP_BITS_PER_UNIT / CHAR_BIT); unsigned long *l; size_t i, j; memset(bytes, 0, len); + /* If bitmap and buffer differ in size, only fill to the smaller length */ + len = MIN(len, nbytes); + /* htole64 is not provided by gnulib, so we do the conversion by hand */ l = bitmap->map; for (i = j = 0; i < len; i++, j++) {

3 3

[libvirt] [PATCH] cpu_map: Add support for cldemote CPU feature
by Jiri Denemark 25 Apr '19

25 Apr '19

Added in QEMU by v2.12.0-481-g0da0fb0628 (released in 3.0). Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 02431bea29..efcc10b1ae 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -310,6 +310,9 @@ <feature name='la57'> <cpuid eax_in='0x07' ecx_in='0x00' ecx='0x00010000'/> </feature> + <feature name='cldemote'> + <cpuid eax_in='0x07' ecx_in='0x00' ecx='0x02000000'/> + </feature> <feature name='avx512-4vnniw'> <cpuid eax_in='0x07' ecx_in='0x00' edx='0x00000004'/> -- 2.21.0

2 1

[libvirt] [PATCH v4 0/3] Don't pm suspend guest if it's unable to wake up
by Daniel Henrique Barboza 25 Apr '19

25 Apr '19

changes from v3: - patch 3 removed. We no longer consider PM_WAKEUP_SUPPORT a cap. It is confusing to have a 'runtime cap' that can't be resolved inside qemu_capabilities.c. The suspend operation isn't time critical per se, and a call to QMP each time 'virsh dompmsuspend' is executed is not dreadful to the user experience. More information and discussion can be found at [1]. - due to the change above, patch 4 now executes the query-current-machine QMP call (if the running QEMU instance supports it) during qemuDomainPMSuspendForDuration to check if the guest has wakeup support. - previous patch link: [1] https://www.redhat.com/archives/libvir-list/2019-April/msg00767.html Daniel Henrique Barboza (2): qemu_capabilities: Add QEMU_CAPS_QUERY_CURRENT_MACHINE qemuDomainPMSuspendForDuration: check for wake-up support Michal Prívozník (1): qemu_monitor: Introduce handler for 'query-current-machine' command src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_driver.c | 54 +++++++++++++++++++ src/qemu/qemu_monitor.c | 10 ++++ src/qemu/qemu_monitor.h | 9 ++++ src/qemu/qemu_monitor_json.c | 50 +++++++++++++++++ src/qemu/qemu_monitor_json.h | 5 ++ .../caps_4.0.0.riscv32.xml | 1 + .../caps_4.0.0.riscv64.xml | 1 + .../caps_4.0.0.x86_64.xml | 1 + 10 files changed, 134 insertions(+) -- 2.20.1

2 7

[libvirt] [PATCH] vircgroup: no need to ifdef virCgroupFree
by Pavel Hrdina 25 Apr '19

25 Apr '19

virCgroup struct is always defined and the free function is not calling anything that would require OS supporting cgroups. This fixes an issue if we try to start a VM with QEMU binary that doesn't support QXL. The start operation will fail in qemuProcessStartValidateVideo() which will set correct error message, but later in one of the cleanup paths we will call qemuDomainObjPrivateDataClear() which always calls virCgroupFree() and that will fail on OS that doesn't support cgroups and it will set a new error which will be eventually reported to user. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/util/vircgroup.c | 62 +++++++++++++++++++------------------------- 1 file changed, 27 insertions(+), 35 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 4238d7014b..f58e336404 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -1279,33 +1279,6 @@ virCgroupNewIgnoreError(void) } -/** - * virCgroupFree: - * - * @group: The group structure to free - */ -void -virCgroupFree(virCgroupPtr *group) -{ - size_t i; - - if (*group == NULL) - return; - - for (i = 0; i < VIR_CGROUP_CONTROLLER_LAST; i++) { - VIR_FREE((*group)->legacy[i].mountPoint); - VIR_FREE((*group)->legacy[i].linkPoint); - VIR_FREE((*group)->legacy[i].placement); - } - - VIR_FREE((*group)->unified.mountPoint); - VIR_FREE((*group)->unified.placement); - - VIR_FREE((*group)->path); - VIR_FREE(*group); -} - - /** * virCgroupHasController: query whether a cgroup controller is present * @@ -2917,14 +2890,6 @@ virCgroupNewIgnoreError(void) } -void -virCgroupFree(virCgroupPtr *group ATTRIBUTE_UNUSED) -{ - virReportSystemError(ENXIO, "%s", - _("Control groups not supported on this platform")); -} - - bool virCgroupHasController(virCgroupPtr cgroup ATTRIBUTE_UNUSED, int controller ATTRIBUTE_UNUSED) @@ -3565,6 +3530,33 @@ virCgroupControllerAvailable(int controller ATTRIBUTE_UNUSED) #endif /* !__linux__ */ +/** + * virCgroupFree: + * + * @group: The group structure to free + */ +void +virCgroupFree(virCgroupPtr *group) +{ + size_t i; + + if (*group == NULL) + return; + + for (i = 0; i < VIR_CGROUP_CONTROLLER_LAST; i++) { + VIR_FREE((*group)->legacy[i].mountPoint); + VIR_FREE((*group)->legacy[i].linkPoint); + VIR_FREE((*group)->legacy[i].placement); + } + + VIR_FREE((*group)->unified.mountPoint); + VIR_FREE((*group)->unified.placement); + + VIR_FREE((*group)->path); + VIR_FREE(*group); +} + + int virCgroupDelThread(virCgroupPtr cgroup, virCgroupThreadName nameval, -- 2.20.1

2 1

[libvirt] [PATCH] storage: escape ipv6 for ceph mon hosts to librados
by winhong-yili 25 Apr '19

25 Apr '19

Hosts for rbd are ceph monitor daemons. These have fixed IP addresses, so they are often referenced by IP rather than hostname for convenience, or to avoid relying on DNS. Using IPv4 addresses as the host name works already, but IPv6 addresses require rbd-specific escaping because the colon is used as an option separator in the string passed to librados. Escape these colons, and enclose the IPv6 address in square brackets so it is distinguished from the port, which is currently mandatory. Signed-off-by: Yi Li <yili(a)winhong.com> --- docs/schemas/storagepool.rng | 5 ++++- src/storage/storage_backend_rbd.c | 13 ++++++++++--- tests/storagepoolxml2xmlin/pool-rbd-ipv6.xml | 13 +++++++++++++ tests/storagepoolxml2xmlout/pool-rbd-ipv6.xml | 16 ++++++++++++++++ tests/storagepoolxml2xmltest.c | 1 + 5 files changed, 44 insertions(+), 4 deletions(-) create mode 100644 tests/storagepoolxml2xmlin/pool-rbd-ipv6.xml create mode 100644 tests/storagepoolxml2xmlout/pool-rbd-ipv6.xml diff --git a/docs/schemas/storagepool.rng b/docs/schemas/storagepool.rng index 3ca8e79..976a02b 100644 --- a/docs/schemas/storagepool.rng +++ b/docs/schemas/storagepool.rng @@ -305,7 +305,10 @@ <oneOrMore> <element name='host'> <attribute name='name'> - <text/> + <choice> + <ref name="dnsName"/> + <ref name="ipAddr"/> + </choice> </attribute> <optional> <attribute name='port'> diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c index f8c968e..3056563 100644 --- a/src/storage/storage_backend_rbd.c +++ b/src/storage/storage_backend_rbd.c @@ -268,9 +268,16 @@ virStorageBackendRBDOpenRADOSConn(virStorageBackendRBDStatePtr ptr, source->hosts[i].name); } else if (source->hosts[i].name != NULL && source->hosts[i].port) { - virBufferAsprintf(&mon_host, "%s:%d,", - source->hosts[i].name, - source->hosts[i].port); + /* assume host containing : is ipv6 */ + if (strchr(source->hosts[i].name, ':')) { + virBufferAsprintf(&mon_host, "[%s]:%d,", + source->hosts[i].name, + source->hosts[i].port); + } else { + virBufferAsprintf(&mon_host, "%s:%d,", + source->hosts[i].name, + source->hosts[i].port); + } } else { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("received malformed monitor, check the XML definition")); diff --git a/tests/storagepoolxml2xmlin/pool-rbd-ipv6.xml b/tests/storagepoolxml2xmlin/pool-rbd-ipv6.xml new file mode 100644 index 0000000..0744b33 --- /dev/null +++ b/tests/storagepoolxml2xmlin/pool-rbd-ipv6.xml @@ -0,0 +1,13 @@ +<pool type='rbd'> + <name>ceph</name> + <uuid>47c1faee-0207-e741-f5ae-d9b019b98fe2</uuid> + <source> + <name>rbd</name> + <host name='localhost' port='6789'/> + <host name='localhost' port='6790'/> + <host name='2205::192:168:205:141' port='6789'/> + <auth username='admin' type='ceph'> + <secret uuid='2ec115d7-3a88-3ceb-bc12-0ac909a6fd87'/> + </auth> + </source> +</pool> diff --git a/tests/storagepoolxml2xmlout/pool-rbd-ipv6.xml b/tests/storagepoolxml2xmlout/pool-rbd-ipv6.xml new file mode 100644 index 0000000..cc2a379 --- /dev/null +++ b/tests/storagepoolxml2xmlout/pool-rbd-ipv6.xml @@ -0,0 +1,16 @@ +<pool type='rbd'> + <name>ceph</name> + <uuid>47c1faee-0207-e741-f5ae-d9b019b98fe2</uuid> + <capacity unit='bytes'>0</capacity> + <allocation unit='bytes'>0</allocation> + <available unit='bytes'>0</available> + <source> + <host name='localhost' port='6789'/> + <host name='localhost' port='6790'/> + <host name='2205::192:168:205:141' port='6789'/> + <name>rbd</name> + <auth type='ceph' username='admin'> + <secret uuid='2ec115d7-3a88-3ceb-bc12-0ac909a6fd87'/> + </auth> + </source> +</pool> diff --git a/tests/storagepoolxml2xmltest.c b/tests/storagepoolxml2xmltest.c index 2ae514f..b6f4cb4 100644 --- a/tests/storagepoolxml2xmltest.c +++ b/tests/storagepoolxml2xmltest.c @@ -95,6 +95,7 @@ mymain(void) DO_TEST("pool-zfs-sourcedev"); DO_TEST("pool-rbd"); #ifdef WITH_STORAGE_RBD + DO_TEST("pool-rbd-ipv6"); DO_TEST("pool-rbd-refresh-volume-allocation"); DO_TEST("pool-rbd-ns-configopts"); #endif -- 2.7.5

1 0

[libvirt] [PATCH] conf: add cpu check attribute to ABI check
by Nikolay Shirokovskiy 24 Apr '19

24 Apr '19

Different check values is not ABI compatible. For example if on migration we change 'full' to 'partial' then guest cpu on destination can be different. Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> --- src/conf/cpu_conf.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c index 33c8b99..bd2beab 100644 --- a/src/conf/cpu_conf.c +++ b/src/conf/cpu_conf.c @@ -894,6 +894,13 @@ virCPUDefIsEqual(virCPUDefPtr src, goto cleanup; } + if (src->check != dst->check) { + MISMATCH(_("Target CPU check %s does not match source %s"), + virCPUCheckTypeToString(dst->check), + virCPUCheckTypeToString(src->check)); + goto cleanup; + } + if (src->arch != dst->arch) { MISMATCH(_("Target CPU arch %s does not match source %s"), virArchToString(dst->arch), -- 1.8.3.1

2 1

[libvirt] JVM crashes during GC
by Sachin Soman 24 Apr '19

24 Apr '19

Hi, Could you tell me if the following is some known issue? While performing the following simple test, I see my JVM crashing (consistently): 1. Open a connection to an ESXi driver/host (passing ConnectAuthDefault instance). 2. Close the connection. 3. Invoke GC When GC is triggered, at some point, some unallocated native memory is being tried to release. That's failing. The error thrown is: java(78745,0x70000241e000) malloc: *** error for object 0x7fd5df561390: pointer being freed was not allocated *** set a breakpoint in malloc_error_break to debug Frames from core dump: frame #0: 0x00007fff5b274b66 libsystem_kernel.dylib`__pthread_kill + 10 frame #1: 0x00007fff5b43f080 libsystem_pthread.dylib`pthread_kill + 333 frame #2: 0x00007fff5b1d01ae libsystem_c.dylib`abort + 127 frame #3: 0x00007fff5b2ce8a6 libsystem_malloc.dylib`free + 521 frame #4: 0x00000001127f43a7 frame #5: 0x00000001127e3ffd frame #6: 0x00000001127e3ffd frame #7: 0x00000001127e3ffd frame #8: 0x00000001127e3ffd frame #9: 0x00000001127e4042 frame #10: 0x00000001127e3ffd frame #11: 0x00000001127e3ffd frame #12: 0x00000001127dc4e7 frame #13: 0x000000010c0e235e libjvm.dylib`JavaCalls::call_helper(JavaValue*, methodHandle*, JavaCallArguments*, Thread*) + 1710 frame #14: 0x000000010c0e2b02 libjvm.dylib`JavaCalls::call_virtual(JavaValue*, KlassHandle, Symbol*, Symbol*, JavaCallArguments*, Thread*) + 356 frame #15: 0x000000010c0e2cae libjvm.dylib`JavaCalls::call_virtual(JavaValue*, Handle, KlassHandle, Symbol*, Symbol*, Thread*) + 74 frame #16: 0x000000010c1208ee libjvm.dylib`thread_entry(JavaThread*, Thread*) + 124 frame #17: 0x000000010c33e84d libjvm.dylib`JavaThread::thread_main_inner() + 155 frame #18: 0x000000010c33ff12 libjvm.dylib`JavaThread::run() + 448 frame #19: 0x000000010c26058a libjvm.dylib`java_start(Thread*) + 246 frame #20: 0x00007fff5b43c661 libsystem_pthread.dylib`_pthread_body + 340 frame #21: 0x00007fff5b43c50d libsystem_pthread.dylib`_pthread_start + 377 frame #22: 0x00007fff5b43bbf9 libsystem_pthread.dylib`thread_start + 13 I have installed Libvirt 5.2.0. Java bindings libvirt-java 0.5.1 JNA 4.0.0 Tested Java environments: Oracle Java 8 and OpenJDK 8 on MAC, OpenJDK 11 on Ubuntu 16 Thanks & Regards Sachin Soman

3 11

[libvirt] [PATCH] networkStartNetworkVirtual: Don't overwrite error in 'err5'
by Michal Privoznik 23 Apr '19

23 Apr '19

If there's an error when setting up QoS on a bridge the control jumps over to 'err5' label. Here, the virNetDevBandwidthClear() is called to clear out any partially set QoS. This function can also report an error which would overwrite the actual error that caused us jumping here. 🤦 Use virErrorPreserveLast() to preserve the original error. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/network/bridge_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index ce4f4890f1..77206b4584 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -2493,6 +2493,7 @@ networkStartNetworkVirtual(virNetworkDriverStatePtr driver, return 0; err5: + virErrorPreserveLast(&save_err); if (def->bandwidth) virNetDevBandwidthClear(def->bridge); -- 2.21.0

2 3

[libvirt] [PATCH 0/3] Emit event on lease attach/detach
by Michal Privoznik 23 Apr '19

23 Apr '19

Unfortunately, we can't emit VIR_DOMAIN_EVENT_ID_DEVICE_ADDED or VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED event because that carries device alias within itself and leases don't have one. Michal Prívozník (3): qemuDomainAttachDeviceLive: Rework event emitting Introduce VIR_DOMAIN_EVENT_ID_LEASE_CHANGE qemu: Emit event on lease attach/detach examples/object-events/event-test.c | 34 +++++++++++ include/libvirt/libvirt-domain.h | 33 +++++++++++ src/conf/domain_event.c | 89 +++++++++++++++++++++++++++++ src/conf/domain_event.h | 12 ++++ src/libvirt_private.syms | 2 + src/qemu/qemu_driver.c | 43 +++++++------- src/qemu/qemu_hotplug.c | 7 +++ src/remote/remote_daemon_dispatch.c | 40 +++++++++++++ src/remote/remote_driver.c | 32 +++++++++++ src/remote/remote_protocol.x | 16 +++++- src/remote_protocol-structs | 8 +++ tools/virsh-domain.c | 31 ++++++++++ 12 files changed, 325 insertions(+), 22 deletions(-) -- 2.21.0

3 7

[libvirt] [PATCH v1] network: Convert to virErrorRestore/virErrorPreserveLast
by Syed Humaid 23 Apr '19

23 Apr '19

Replaced usage of virSaveLastError and virSetError/virFreeError with virErrorPreserveLast and virErrorRestore respectively. Signed-off-by: Syed Humaid <syedhumaidbinharoon(a)gmail.com> --- src/network/bridge_driver.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index f824b8b4f3..dc21ac642c 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -2495,7 +2495,7 @@ networkStartNetworkVirtual(virNetworkDriverStatePtr driver, err4: if (!save_err) - save_err = virSaveLastError(); + virErrorPreserveLast(&save_err); dnsmasqPid = virNetworkObjGetDnsmasqPid(obj); if (dnsmasqPid > 0) { @@ -2505,18 +2505,18 @@ networkStartNetworkVirtual(virNetworkDriverStatePtr driver, err3: if (!save_err) - save_err = virSaveLastError(); + virErrorPreserveLast(&save_err); ignore_value(virNetDevSetOnline(def->bridge, 0)); err2: if (!save_err) - save_err = virSaveLastError(); + virErrorPreserveLast(&save_err); if (def->forward.type != VIR_NETWORK_FORWARD_OPEN) networkRemoveFirewallRules(def); err1: if (!save_err) - save_err = virSaveLastError(); + virErrorPreserveLast(&save_err); if (macTapIfName) { VIR_FORCE_CLOSE(tapfd); @@ -2528,13 +2528,10 @@ networkStartNetworkVirtual(virNetworkDriverStatePtr driver, err0: if (!save_err) - save_err = virSaveLastError(); + virErrorPreserveLast(&save_err); ignore_value(virNetDevBridgeDelete(def->bridge)); - if (save_err) { - virSetError(save_err); - virFreeError(save_err); - } + virErrorRestore(&save_err); /* coverity[leaked_handle] - 'tapfd' is not leaked */ return -1; } -- 2.20.1

2 1

[libvirt] [PATCH 0/3] Couple of mem leak fixes
by Michal Privoznik 23 Apr '19

23 Apr '19

*** BLURB HERE *** Michal Prívozník (3): qemucaps2xmltest: Don't leak @binary libxlDriverConfigDispose: Free @configBaseDir too vmx: Free @firmware in virVMXParseConfig src/libxl/libxl_conf.c | 1 + src/vmx/vmx.c | 1 + tests/qemucaps2xmltest.c | 3 +-- 3 files changed, 3 insertions(+), 2 deletions(-) -- 2.21.0

3 6

[libvirt] [PATCH 0/3] qemu: monitor: detect more snapshot errors
by Cole Robinson 23 Apr '19

23 Apr '19

qemu in Fedora 30 rejects migration if the VM has nested VMX configured. This means managedsave and snapshots are rejected too. Unfortunately the scraping we need to resort to with the text monitor snapshot commands is not detecting that 'savevm' actually failed, so the snapshot appears to succeed. https://bugzilla.redhat.com/show_bug.cgi?id=1697997 qemu 4.0.0 will add an 'Error: ' prefix to most hmp command errors (qemu commit 66363e9a43f), let's use that to detect error as well Cole Robinson (3): qemu: monitor: cleanup loadvm error handling qemu: monitor cleanup delvm error handling qemu: monitor: check for common 'Error: ' string src/qemu/qemu_monitor_text.c | 39 ++++++++++++++++++------------------ 1 file changed, 20 insertions(+), 19 deletions(-) -- 2.21.0

2 4

[libvirt] New Feature: Intel MKTME Support
by Carvalho, Larkins L 23 Apr '19

23 Apr '19

Hello Team, Greetings. We want to add Intel MKTME support to the Libvirt. Intel MKTME is a capability to encrypt entirety of physical memory of a system similar to AMD SEV. Please let us know what are the expectations from us to initiate the design and development of the feature. Regards, Larkins Carvalho Intel Corporation

5 15

[libvirt] [PATCH] news: add note about optional "Removed features" section
by Daniel P. Berrangé 18 Apr '19

18 Apr '19

Most releases don't need a "Removed features" section so don't include it in the template by default, but leave a reminder in case it is relevant. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/news.xml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index b4926dd906..5346a25132 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -30,6 +30,12 @@ </section> </release> + If relevant for a given release, add a section for removed + features too + + <section title="Removed features"> + </section> + --> <libvirt> -- 2.20.1

2 1

[libvirt] [PATCH v3 0/2] qemu: Honor memory mode='strict'
by Michal Privoznik 18 Apr '19

18 Apr '19

v3 of: diff to v2: - Not calling qemuSetupCpusetMems() in qemuProcessLaunch - Dropping qemuSetupCpusetMems() Michal Prívozník (2): qemu: Set up EMULATOR thread and cpuset.mems before exec()-ing qemu qemu_cgroup: Remove unused qemuSetupCpusetMems src/qemu/qemu_cgroup.c | 35 ----------------------------------- src/qemu/qemu_cgroup.h | 1 - src/qemu/qemu_process.c | 8 ++++---- 3 files changed, 4 insertions(+), 40 deletions(-) -- 2.21.0

2 3

[libvirt] [PATCH 0/4] qemu_hotplug: Check for duplicate drive addresses
by Michal Privoznik 18 Apr '19

18 Apr '19

This is an alternative approach to: https://www.redhat.com/archives/libvir-list/2019-March/msg01111.html which caused regression to which a proposed fix is here: https://www.redhat.com/archives/libvir-list/2019-April/msg00756.html One of the selling points was that having this check in virDomainDefCompatibleDevice() will fix the problem across all drivers. Well, turns out, some drivers don't care (e.g. lxc) and some have a different workflow and thus don't need that check. Michal Prívozník (4): conf: Expose virDomainSCSIDriveAddressIsUsed qemuhotplugtest: Don't plug a SCSI disk at unit 7 qemu_hotplug: Check for duplicate drive addresses Revert "domain_conf: check device address before attach" src/conf/domain_conf.c | 11 +---------- src/conf/domain_conf.h | 4 ++++ src/libvirt_private.syms | 1 + src/qemu/qemu_hotplug.c | 6 ++++++ tests/qemuhotplugtest.c | 2 +- .../qemuhotplug-disk-scsi-2.xml | 2 +- ...-base-without-scsi-controller-live+disk-scsi-2.xml | 4 ++-- 7 files changed, 16 insertions(+), 14 deletions(-) -- 2.21.0

3 10

[libvirt] [PATCH 0/3] qemu: more firmware path improvements
by Daniel P. Berrangé 18 Apr '19

18 Apr '19

Daniel P. Berrangé (3): m4: allow default firmware list to be empty rpm: disable default firmware list on RHEL and Fedora >= 31 qemu: stop including real paths in nvram config option libvirt.spec.in | 6 +++++- m4/virt-loader-nvram.m4 | 16 ++++++++++------ src/qemu/qemu.conf | 11 +++++------ 3 files changed, 20 insertions(+), 13 deletions(-) -- 2.20.1

2 4

[libvirt] Why virsh domxml-to-native qemu-argv changes PCI slot number
by Tal Attaly 18 Apr '19

18 Apr '19

Hi, I have bridge type interface defined with slot 3 - <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> but after running virsh domxml-to-native qemu-argv I get slot 2- -netdev tap,fd=21,id=hostnet0 -device e1000,netdev=hostnet0,id=net0,mac=f2:ff:ff:ff:ff:07,bus=pci.0,addr=0x2 Any idea why it's happen and how to keep the slot number? Libvirt version is 4.5.0 here is the full domain XML - <domain type='kvm' xmlns:qemu='http://libvirt.org/schemas/domain/qemu/1.0'> <name>vm1</name> <uuid>dbad303e-fc1b-454e-8861-712bf1766a64</uuid> <memory unit='KiB'>4194304</memory> <currentMemory unit='KiB'>4194304</currentMemory> <vcpu placement='static'>1</vcpu> <os> <type arch='x86_64' machine='pc-i440fx-2.12'>hvm</type> <boot dev='hd'/> </os> <features> <acpi/> <apic/> </features> <cpu mode='custom' match='exact' check='partial'> <model fallback='allow'>SandyBridge-IBRS</model> </cpu> <clock offset='utc'> <timer name='rtc' tickpolicy='catchup'/> <timer name='pit' tickpolicy='delay'/> <timer name='hpet' present='no'/> </clock> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>destroy</on_crash> <pm> <suspend-to-mem enabled='no'/> <suspend-to-disk enabled='no'/> </pm> <devices> <emulator>/qemu/x86_64-softmmu/qemu-system-x86_64</emulator> <disk type='file' device='disk'> <driver name='qemu' type='qcow2'/> <source file='/var/lib/libvirt/images/vm.img'/> <target dev='hda' bus='ide'/> <address type='drive' controller='0' bus='0' target='0' unit='0'/> </disk> <controller type='usb' index='0' model='ich9-ehci1'> <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x7'/> </controller> <controller type='usb' index='0' model='ich9-uhci1'> <master startport='0'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0' multifunction='on'/> </controller> <controller type='usb' index='0' model='ich9-uhci2'> <master startport='2'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x1'/> </controller> <controller type='usb' index='0' model='ich9-uhci3'> <master startport='4'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x2'/> </controller> <controller type='ide' index='0'> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/> </controller> <controller type='pci' index='0' model='pci-root'/> <interface type='bridge'> <mac address='f2:ff:ff:ff:ff:07'/> <source bridge='br0:'/> <model type='e1000'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> </interface> <serial type='tcp'> <source mode='bind' host='10.210.27.119' service='9999'/> <protocol type='telnet'/> <target type='isa-serial' port='0'> <model name='isa-serial'/> </target> </serial> <console type='tcp'> <source mode='bind' host='10.210.27.119' service='9999'/> <protocol type='telnet'/> <target type='serial' port='0'/> </console> <input type='mouse' bus='ps2'/> <input type='keyboard' bus='ps2'/> <memballoon model='virtio'> <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/> </memballoon> </devices> <qemu:commandline> <qemu:env name='CONFIG_FILE' value='/opt/cfg/qemu.cfg'/> </qemu:commandline> </domain> Thanks, Tal

3 2

[libvirt] [PATCH v1 0/4] RFC CPU Model Comparison via QMP
by Collin Walling 18 Apr '19

18 Apr '19

This is a preview of the CPU comparison (and soon baseline) patches. Comments are welcome on all aspects, as they will help guide the development of the baseline implementation. The first couple of patches simply refactor code. The first introduces an XML -> CPU def helper to be used to extract the CPU definition prior to sending it to the comparison functions. The second patch refactors some of the code from CPU model expansion to be later used by comparison and baseline. Currently, only one of the functions from the refactoring is reused for comparison. The other two will come into play when baseline is implemented. The third is the typical "new capability" patch to introduce query-cpu-model-comparison and test data for s390x. The last patch implements the qemuMonitorJSON function for query-cpu-model-comparison and hooks it up to virsh hypervisor-cpu-compare. This is posted as an RFC to make sure these patches are set in the correct direction before tackling the baseline patches. Thanks! Collin Walling (4): cpu_conf: xml to cpu definition parse helper qemu: monitor: helper functions for CPU models qemu_capabilities: introduce QEMU_CAPS_QUERY_CPU_MODEL_COMPARISON qemu: monitor: implement query-cpu-model-comparison src/conf/cpu_conf.c | 30 +++ src/conf/cpu_conf.h | 6 + src/cpu/cpu.c | 14 +- src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 49 ++++ src/qemu/qemu_capabilities.h | 10 + src/qemu/qemu_driver.c | 10 + src/qemu/qemu_monitor.c | 22 ++ src/qemu/qemu_monitor.h | 10 + src/qemu/qemu_monitor_json.c | 223 +++++++++++++++--- src/qemu/qemu_monitor_json.h | 11 + .../caps_2.10.0.s390x.xml | 1 + .../caps_2.11.0.s390x.xml | 1 + .../caps_2.12.0.s390x.xml | 1 + .../qemucapabilitiesdata/caps_2.8.0.s390x.xml | 1 + .../qemucapabilitiesdata/caps_2.9.0.s390x.xml | 1 + .../qemucapabilitiesdata/caps_3.0.0.s390x.xml | 1 + 17 files changed, 343 insertions(+), 49 deletions(-) -- 2.20.1

2 8

[libvirt] [PATCH] testQemuGetLatestCaps: Lower chances of hash collision
by Michal Privoznik 18 Apr '19

18 Apr '19

This function creates a list of paths to the latest capabilities and returns them in a hash table where key is an arch string and value is the path. Well, we know how many arches there are so might as well use that as initial hash size. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tests/testutilsqemu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c index bce847ce5e..2d6a84d017 100644 --- a/tests/testutilsqemu.c +++ b/tests/testutilsqemu.c @@ -879,7 +879,7 @@ testQemuGetLatestCaps(void) virHashTablePtr capslatest; size_t i; - if (!(capslatest = virHashCreate(4, virHashValueFree))) + if (!(capslatest = virHashCreate(ARRAY_CARDINALITY(archs), virHashValueFree))) goto error; VIR_TEST_VERBOSE("\n"); -- 2.21.0

1 0

[libvirt] [PATCH] qemu.conf: Make nvram list obsolete
by Michal Privoznik 18 Apr '19

18 Apr '19

Now that libvirt has firmware auto selection feature the nvram config knob is more or less obsolete. It still makes sense in cases where distro users are using does not provide FW descriptor files, therefore I'm not removing it. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu.conf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf index 334b4cd4ee..ecde8f0181 100644 --- a/src/qemu/qemu.conf +++ b/src/qemu/qemu.conf @@ -740,6 +740,8 @@ # Location of master nvram file # +# This is now obsoleted by firmware auto selection feature. +# Prefer that before this. # When a domain is configured to use UEFI instead of standard # BIOS it may use a separate storage for UEFI variables. If # that's the case libvirt creates the variable store per domain -- 2.21.0

2 1

[libvirt] [PATCH v2 00/11] conf: partial net model enum conversion
by Cole Robinson 18 Apr '19

18 Apr '19

v1 here: https://www.redhat.com/archives/libvir-list/2019-January/msg00763.html Changes since v1: - patch #7, case insensitive model input comparison - Add xml2xml testing - compile tested on freebsd12.0 This series partially converts the net->model value from a string to an enum. We wrap the existing ->model string in accessor functions, rename it to ->modelstr, add a ->model enum, and convert internal driver usage bit by bit. At the end, all driver code that is acting on specific network model values is comparing against an enum, not a string. This is only partial because of xen/libxl/xm and qemu drivers, which if they don't know anything particular about the model string will just place it on the qemu command line/xen config and see what happens. So basically if I were to pass in <model type='idontexist'/> qemu would turn that into -device idontexist,... That behavior is untouched by this series, as fully unwinding that will take some more work: * Figuring out all reasonable qemu + xen values that could actually result in a working VM config, and adding them to the enum * Figuring out a long term plan for disabling passthrough entirely. There's some discussion in the v1 thread about this. Some caveats: * vz driver is not compile tested. What's the sdk magic to actually get this building? * net model enum lookup is done case insensitive. this is to maintain the behavior of the vmx and virtualbox drivers, but it's different than all our other enum usage. Cole Robinson (11): tests: Add several net model passthrough tests conf: net: Add wrapper functions for <model> value conf: net: Rename 'model' to 'modelstr' conf: net: Add model enum, and netfront value vz: convert to net model enum bhyve: convert to net model enum qemu: Partially convert to net model enum conf: Make net model enum compare case insensitive vmx: convert to net model enum vbox: Convert to net enum model conf: Add VIR_DOMAIN_DEF_FEATURE_NET_MODEL_STRING src/bhyve/bhyve_command.c | 15 +-- src/bhyve/bhyve_parse_command.c | 10 +- src/conf/domain_conf.c | 111 ++++++++++++++---- src/conf/domain_conf.h | 35 +++++- src/libvirt_private.syms | 4 + src/libxl/libxl_conf.c | 8 +- src/libxl/libxl_domain.c | 1 + src/qemu/qemu_command.c | 13 +- src/qemu/qemu_domain.c | 32 +++-- src/qemu/qemu_domain_address.c | 13 +- src/qemu/qemu_driver.c | 14 ++- src/qemu/qemu_hotplug.c | 15 ++- src/qemu/qemu_parse_command.c | 5 +- src/security/virt-aa-helper.c | 3 +- src/vbox/vbox_common.c | 29 ++--- src/vmx/vmx.c | 55 ++++----- src/vz/vz_driver.c | 7 +- src/vz/vz_sdk.c | 17 ++- src/xenconfig/xen_common.c | 31 ++--- src/xenconfig/xen_sxpr.c | 30 ++--- tests/qemuxml2argvdata/net-many-models.args | 39 ++++++ tests/qemuxml2argvdata/net-many-models.xml | 38 ++++++ tests/qemuxml2argvtest.c | 1 + tests/qemuxml2xmloutdata/net-many-models.xml | 53 +++++++++ tests/qemuxml2xmltest.c | 1 + tests/xlconfigdata/test-net-fakemodel.cfg | 24 ++++ tests/xlconfigdata/test-net-fakemodel.xml | 39 ++++++ tests/xlconfigtest.c | 1 + .../test-paravirt-net-fakemodel.cfg | 13 ++ .../test-paravirt-net-fakemodel.xml | 40 +++++++ .../test-paravirt-net-modelstr.cfg | 13 ++ tests/xmconfigtest.c | 1 + .../xml2sexpr-fv-net-many-models.sexpr | 1 + .../xml2sexpr-fv-net-many-models.xml | 43 +++++++ tests/xml2sexprtest.c | 1 + 35 files changed, 586 insertions(+), 170 deletions(-) create mode 100644 tests/qemuxml2argvdata/net-many-models.args create mode 100644 tests/qemuxml2argvdata/net-many-models.xml create mode 100644 tests/qemuxml2xmloutdata/net-many-models.xml create mode 100644 tests/xlconfigdata/test-net-fakemodel.cfg create mode 100644 tests/xlconfigdata/test-net-fakemodel.xml create mode 100644 tests/xmconfigdata/test-paravirt-net-fakemodel.cfg create mode 100644 tests/xmconfigdata/test-paravirt-net-fakemodel.xml create mode 100644 tests/xmconfigdata/test-paravirt-net-modelstr.cfg create mode 100644 tests/xml2sexprdata/xml2sexpr-fv-net-many-models.sexpr create mode 100644 tests/xml2sexprdata/xml2sexpr-fv-net-many-models.xml -- 2.20.1

3 24

[libvirt] [PATCH v3 0/4] Don't pm suspend guest if it's unable to wake up
by Michal Privoznik 18 Apr '19

18 Apr '19

This is v3 of: https://www.redhat.com/archives/libvir-list/2019-April/msg00690.html I've taken Daniel's patches and reworked them. Diff to v2: - Patches 1-2/3 are split into three patches - Capability is checked for when querying other capabilities - Fixed a small security issue in 3/3 Daniel Henrique Barboza (2): qemu_capabilities: Add QEMU_CAPS_QUERY_CURRENT_MACHINE qemuDomainPMSuspendForDuration: check for QEMU_CAPS_PM_WAKEUP_SUPPORT Michal Prívozník (2): qemu_monitor: Introduce handler for 'query-current-machine' command qemu_capabilities: Introduce QEMU_CAPS_PM_WAKEUP_SUPPORT src/qemu/qemu_capabilities.c | 26 ++++++++++ src/qemu/qemu_capabilities.h | 4 ++ src/qemu/qemu_driver.c | 21 ++++++++ src/qemu/qemu_monitor.c | 10 ++++ src/qemu/qemu_monitor.h | 9 ++++ src/qemu/qemu_monitor_json.c | 50 +++++++++++++++++++ src/qemu/qemu_monitor_json.h | 5 ++ .../caps_4.0.0.riscv32.replies | 11 ++++ .../caps_4.0.0.riscv32.xml | 2 + .../caps_4.0.0.riscv64.replies | 11 ++++ .../caps_4.0.0.riscv64.xml | 2 + .../caps_4.0.0.x86_64.replies | 11 ++++ .../caps_4.0.0.x86_64.xml | 2 + 13 files changed, 164 insertions(+) -- 2.21.0

3 14

[libvirt] [PATCH v2 0/3] Add 'label' arg to VIR_ENUM_IMPL
by Cole Robinson 17 Apr '19

17 Apr '19

4 9

[libvirt] On the content of 'nvram' section in /etc/libvirt/qemu.conf
by Kashyap Chamarthy 17 Apr '19

17 Apr '19

I learnt from Dan Berrangé that the 'nvram' section in `/etc/libvirt/qemu.conf` will now go away in light of all the work done in QEMU ('firmware.json', et al) and libvirt (the firmware auto-selection). But for my own education, can anyone confirm that the current content of 'nvram' is out of date in terms of mapping of OVMF binaries to their corresponding variable store ("VARS") files? Let's see what I mean. On my Fedora 29 box, in `/etc/libvirt/qemu.conf`, I see the following mapping of OVMF binaries to their correspoindg "VARS" file under the 'nvram' section: #nvram = [ # "/usr/share/OVMF/OVMF_CODE.fd:/usr/share/OVMF/OVMF_VARS.fd", # "/usr/share/OVMF/OVMF_CODE.secboot.fd:/usr/share/OVMF/OVMF_VARS.fd", # "/usr/share/AAVMF/AAVMF_CODE.fd:/usr/share/AAVMF/AAVMF_VARS.fd", # "/usr/share/AAVMF/AAVMF32_CODE.fd:/usr/share/AAVMF/AAVMF32_VARS.fd" #] Now let's enumerate the content of 'edk2-ovmf' package: $> rpm -ql edk2-ovmf /usr/share/OVMF /usr/share/OVMF/OVMF_CODE.fd /usr/share/OVMF/OVMF_CODE.secboot.fd /usr/share/OVMF/OVMF_VARS.fd /usr/share/OVMF/OVMF_VARS.secboot.fd /usr/share/OVMF/UefiShell.iso /usr/share/doc/edk2-ovmf /usr/share/doc/edk2-ovmf/README /usr/share/doc/edk2-ovmf/ovmf-whitepaper-c770f8c.txt /usr/share/edk2 /usr/share/edk2/ovmf /usr/share/edk2/ovmf/EnrollDefaultKeys.efi /usr/share/edk2/ovmf/OVMF_CODE.fd /usr/share/edk2/ovmf/OVMF_CODE.secboot.fd /usr/share/edk2/ovmf/OVMF_VARS.fd /usr/share/edk2/ovmf/OVMF_VARS.secboot.fd /usr/share/edk2/ovmf/Shell.efi /usr/share/edk2/ovmf/UefiShell.iso /usr/share/licenses/edk2-ovmf /usr/share/licenses/edk2-ovmf/LICENSE.openssl /usr/share/licenses/edk2-ovmf/License.txt There is the /usr/share/edk2/ovmf/OVMF_VARS.secboot.fd file (which comes with the default UEFI keys enrolled). So, the mapping of OVMF binary to VARS file in the earlier mentioned 'nvram' section should have been: /usr/share/OVMF/OVMF_CODE.secboot.fd:/usr/share/edk2/ovmf/OVMF_VARS.secboot.fd Yes? -- /kashyap

2 2

[libvirt] Virtual machine
by achamusse＠isutc.transcom.co.mz 17 Apr '19

17 Apr '19

My Ubuntu16.04.5 server is installed qemo-kvm and libvirt-manager but virt-manager is not starting. consequently when I install vncserver the keyboard does not work on the virtual machine. But in ubuntu 14.04 it works perfectly. can my help ?? ERRO when try run : virt-manager Could not connect: Connection refused Failed to connect to Mir: Failed to connect to server socket: No such file or directory Unable to init server: Could not connect: Connection refused (virt-manager:7676): Gtk-CRITICAL **: gtk_settings_get_for_screen: assertion 'GDK_IS_SCREEN (screen)' failed Melhores Cumprimentos Armando Chamusse Departamento de Operações e Infraestruturas Prolongamento Av. Kim Il Sung, Edf. D1, C.P. 2088 - Maputo - Moçambique Telefone: (+258) 21 48 87 92/5 Celular: (+258) 82 30 62 620 |82 31 26 200 | 84 31 29 246 | 87 16 28 785 <http://www.facebook.com/isutc> www.facebook.com/isutc <http://www.transcom.co.mz/isutc/> www.transcom.co.mz/isutc

2 1

[libvirt] [PATCH] qemu: Simplify interface handling in qemuConnectDomainXMLToNative()
by Michal Privoznik 17 Apr '19

17 Apr '19

Firstly, VIR_STRDUP() accepts NULL, so there is no need to check if the string we want to duplicate is not-NULL. Secondly, virDomainNetSetModelString() also accepts NULL. Thirdly, we have VIR_AUTOFREE(). Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_driver.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 0fb90c4049..c443c881d5 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7411,12 +7411,11 @@ static char *qemuConnectDomainXMLToNative(virConnectPtr conn, for (i = 0; i < vm->def->nnets; i++) { virDomainNetDefPtr net = vm->def->nets[i]; unsigned int bootIndex = net->info.bootIndex; - char *model = NULL; + VIR_AUTOFREE(char *) model = NULL; virMacAddr mac = net->mac; char *script = net->script; - if (virDomainNetGetModelString(net) && - VIR_STRDUP(model, virDomainNetGetModelString(net)) < 0) + if (VIR_STRDUP(model, virDomainNetGetModelString(net)) < 0) goto cleanup; net->script = NULL; @@ -7428,11 +7427,8 @@ static char *qemuConnectDomainXMLToNative(virConnectPtr conn, net->mac = mac; net->script = script; - if (model && virDomainNetSetModelString(net, model) < 0) { - VIR_FREE(model); + if (virDomainNetSetModelString(net, model) < 0) goto cleanup; - } - VIR_FREE(model); } if (!(cmd = qemuProcessCreatePretendCmd(driver, vm, NULL, -- 2.21.0

2 1

[libvirt] [PATCH] docs: index.html.in: Deduplicate the link of QEMU and KVM
by Han Han 17 Apr '19

17 Apr '19

Because the page of QEMU and KVM use the same doc drvqemu.html, merge the into one and name it as QEMU/KVM. Signed-off-by: Han Han <hhan(a)redhat.com> --- docs/index.html.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/index.html.in b/docs/index.html.in index f593445d06..97a4e9eef7 100644 --- a/docs/index.html.in +++ b/docs/index.html.in @@ -31,8 +31,8 @@ <li>is a toolkit to manage <a href="platforms.html">virtualization platforms</a></li> <li>is accessible from C, Python, Perl, Java and more</li> <li>is licensed under open source licenses</li> - <li>supports <a href="drvqemu.html">KVM</a>, - <a href="drvqemu.html">QEMU</a>, <a href="drvxen.html">Xen</a>, + <li>supports <a href="drvqemu.html">QEMU/KVM</a>, + <a href="drvxen.html">Xen</a>, <a href="drvvirtuozzo.html">Virtuozzo</a>, <a href="drvesx.html">VMWare ESX</a>, <a href="drvlxc.html">LXC</a>, -- 2.20.1

3 2

[libvirt] [PATCH] qemu: Fix uninitialized variable
by Andrea Bolognani 17 Apr '19

17 Apr '19

It has made Clang very unhappy ever since 6bf7c6769925. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed under the build breaker rule. src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index aac50475ee..0fb90c4049 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7411,7 +7411,7 @@ static char *qemuConnectDomainXMLToNative(virConnectPtr conn, for (i = 0; i < vm->def->nnets; i++) { virDomainNetDefPtr net = vm->def->nets[i]; unsigned int bootIndex = net->info.bootIndex; - char *model; + char *model = NULL; virMacAddr mac = net->mac; char *script = net->script; -- 2.20.1

1 0

[libvirt] [PATCH 0/2] rpc: client: stream bugfix and improvement
by Nikolay Shirokovskiy 17 Apr '19

17 Apr '19

Nikolay Shirokovskiy (2): rpc: client: fix race on stream error and stream creation rpc: client: stream: notify streams of closing connection src/rpc/virnetclient.c | 13 ++++++++++--- src/rpc/virnetclientstream.c | 30 ++++++++++++++++++++++++++++-- src/rpc/virnetclientstream.h | 2 ++ 3 files changed, 40 insertions(+), 5 deletions(-) -- 1.8.3.1

2 6

[libvirt] [PATCH v2 0/6] tests: qemuxml2xml: add DO_TEST_CAPS*
by Cole Robinson 17 Apr '19

17 Apr '19

v1: https://www.redhat.com/archives/libvir-list/2019-April/msg00083.html v2 changes: - Push first series prep work - Split last patch into multiple pieces - Add genid* conversion to demonstrate -active and -inactive names - Address Andrea's review comments Cole Robinson (6): tests: qemuxml2xml: Set name in testQemuInfo tests: qemuxml2xml: Add DO_TEST_CAPS* tests: qemuxml2xml: Convert virtio-*transitional to TEST_CAPS tests: qemuxml2xml: Convert os-firmware* to TEST_CAPS tests: qemuxml2xml: Convert genid* to TEST_CAPS tests: qemuxml2xml: Convert aarch64-os-firmware-efi to TEST_CAPS ...aarch64-os-firmware-efi.aarch64-latest.xml | 31 ++++ .../aarch64-os-firmware-efi.xml | 1 - ...ive.xml => genid-active.x86_64-latest.xml} | 2 +- ...ml => genid-auto-active.x86_64-latest.xml} | 2 +- ... => genid-auto-inactive.x86_64-latest.xml} | 2 +- ...e.xml => genid-inactive.x86_64-latest.xml} | 2 +- .../os-firmware-bios.x86_64-latest.xml | 68 +++++++++ tests/qemuxml2xmloutdata/os-firmware-bios.xml | 1 - .../os-firmware-efi-secboot.x86_64-latest.xml | 68 +++++++++ .../os-firmware-efi-secboot.xml | 1 - .../os-firmware-efi.x86_64-latest.xml | 68 +++++++++ tests/qemuxml2xmloutdata/os-firmware-efi.xml | 1 - ...virtio-non-transitional.x86_64-latest.xml} | 0 ... => virtio-transitional.x86_64-latest.xml} | 0 tests/qemuxml2xmltest.c | 132 ++++++++---------- 15 files changed, 299 insertions(+), 80 deletions(-) create mode 100644 tests/qemuxml2xmloutdata/aarch64-os-firmware-efi.aarch64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/aarch64-os-firmware-efi.xml rename tests/qemuxml2xmloutdata/{genid-active.xml => genid-active.x86_64-latest.xml} (94%) rename tests/qemuxml2xmloutdata/{genid-auto-active.xml => genid-auto-active.x86_64-latest.xml} (94%) rename tests/qemuxml2xmloutdata/{genid-auto-inactive.xml => genid-auto-inactive.x86_64-latest.xml} (94%) rename tests/qemuxml2xmloutdata/{genid-inactive.xml => genid-inactive.x86_64-latest.xml} (94%) create mode 100644 tests/qemuxml2xmloutdata/os-firmware-bios.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/os-firmware-bios.xml create mode 100644 tests/qemuxml2xmloutdata/os-firmware-efi-secboot.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/os-firmware-efi-secboot.xml create mode 100644 tests/qemuxml2xmloutdata/os-firmware-efi.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/os-firmware-efi.xml rename tests/qemuxml2xmloutdata/{virtio-non-transitional.xml => virtio-non-transitional.x86_64-latest.xml} (100%) rename tests/qemuxml2xmloutdata/{virtio-transitional.xml => virtio-transitional.x86_64-latest.xml} (100%) -- 2.21.0

2 14

[libvirt] [PATCH v3] libvirt-domain.c: Convert to virErrorRestore/virErrorPreserveLast
by Syed Humaid 16 Apr '19

16 Apr '19

Replaced all virSaveLastError and virSetError/virFreeError usages to virErrorPreserveLast and virErrorRestore respectively. Signed-off-by: Syed Humaid <syedhumaidbinharoon(a)gmail.com> --- src/libvirt-domain.c | 24 +++++++++--------------- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index baf21824fe..80284a99f0 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -2894,7 +2894,7 @@ virDomainMigrateVersion2(virDomainPtr domain, _("domainMigratePrepare2 did not set uri")); cancelled = 1; /* Make sure Finish doesn't overwrite the error */ - orig_err = virSaveLastError(); + virErrorPreserveLast(&orig_err); goto finish; } if (uri_out) @@ -2909,7 +2909,7 @@ virDomainMigrateVersion2(virDomainPtr domain, /* Perform failed. Make sure Finish doesn't overwrite the error */ if (ret < 0) - orig_err = virSaveLastError(); + virErrorPreserveLast(&orig_err); /* If Perform returns < 0, then we need to cancel the VM * startup on the destination @@ -2929,10 +2929,7 @@ virDomainMigrateVersion2(virDomainPtr domain, VIR_ERROR(_("finish step ignored that migration was cancelled")); done: - if (orig_err) { - virSetError(orig_err); - virFreeError(orig_err); - } + virErrorRestore(&orig_err); VIR_FREE(uri_out); VIR_FREE(cookie); return ddomain; @@ -3076,7 +3073,7 @@ virDomainMigrateVersion3Full(virDomainPtr domain, /* Begin already started a migration job so we need to cancel it by * calling Confirm while making sure it doesn't overwrite the error */ - orig_err = virSaveLastError(); + virErrorPreserveLast(&orig_err); goto confirm; } else { goto done; @@ -3091,7 +3088,7 @@ virDomainMigrateVersion3Full(virDomainPtr domain, VIR_MIGRATE_PARAM_URI, uri_out) < 0) { cancelled = 1; - orig_err = virSaveLastError(); + virErrorPreserveLast(&orig_err); goto finish; } } else if (!uri && @@ -3100,7 +3097,7 @@ virDomainMigrateVersion3Full(virDomainPtr domain, virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("domainMigratePrepare3 did not set uri")); cancelled = 1; - orig_err = virSaveLastError(); + virErrorPreserveLast(&orig_err); goto finish; } @@ -3136,7 +3133,7 @@ virDomainMigrateVersion3Full(virDomainPtr domain, /* Perform failed. Make sure Finish doesn't overwrite the error */ if (ret < 0) { - orig_err = virSaveLastError(); + virErrorPreserveLast(&orig_err); /* Perform failed so we don't need to call confirm to let source know * about the failure. */ @@ -3222,7 +3219,7 @@ virDomainMigrateVersion3Full(virDomainPtr domain, * one we need to preserve it in case confirm3 overwrites */ if (!orig_err) - orig_err = virSaveLastError(); + virErrorPreserveLast(&orig_err); confirm: /* @@ -3256,10 +3253,7 @@ virDomainMigrateVersion3Full(virDomainPtr domain, } done: - if (orig_err) { - virSetError(orig_err); - virFreeError(orig_err); - } + virErrorRestore(&orig_err); VIR_FREE(dom_xml); VIR_FREE(uri_out); VIR_FREE(cookiein); -- 2.20.1

2 1

[libvirt] [PATCH 0/5] snapshot XML parse cleanups (incremental backup saga)
by Eric Blake 16 Apr '19

16 Apr '19

During my checkpoint series, one of the review comments complained that setting the <creationTime> element during XML parsing to the current time is non-deterministic, which in turn makes writing testsuite additions difficult. The recommendation was to split out the non-deterministic defaults to a post-parse handler. Of course, since checkpoints copied from snapshots, I first need to fix snapshots to do the same, hence this series. Eric Blake (5): snapshot: Refactor snapshotxml2xml test snapshot: Don't expose testsuite-only state in snapshot XML snapshot: Factor out post-parse code snapshot: Allow for post-parse override snapshot: Use post-parse instead of regex in testsuite src/conf/domain_conf.h | 9 + src/conf/moment_conf.h | 2 + docs/schemas/domainsnapshot.rng | 1 - src/conf/domain_conf.c | 24 +++ src/conf/moment_conf.c | 19 ++ src/conf/snapshot_conf.c | 22 +-- src/libvirt_private.syms | 1 + .../disk_driver_name_null.xml | 1 + .../disk_snapshot.xml | 1 + tests/domainsnapshotxml2xmlout/empty.xml | 1 - .../domainsnapshotxml2xmlout/external_vm.xml | 1 + .../name_and_description.xml | 1 - tests/domainsnapshotxml2xmlout/noparent.xml | 2 +- tests/domainsnapshotxml2xmltest.c | 170 +++++++----------- 14 files changed, 137 insertions(+), 118 deletions(-) -- 2.20.1

2 7

[libvirt] [PATCH 0/4] tests: Introduce and use TEST_QEMU_CAPS_PATH
by Andrea Bolognani 16 Apr '19

16 Apr '19

Reduce repetition by replacing reutterances with reusable references. Andrea Bolognani (4): tests: Make TEST_QEMU_CAPS_PATH public tests: Drop dirname argument from testQemuGetLatestCapsForArch() tests: Drop dirname argument from testQemuCapsIterate() tests: Use TEST_QEMU_CAPS_PATH wherever possible tests/domaincapstest.c | 4 ++-- tests/qemuargv2xmltest.c | 2 +- tests/qemublocktest.c | 3 +-- tests/qemucapabilitiestest.c | 4 ++-- tests/qemucaps2xmltest.c | 4 ++-- tests/testutilsqemu.c | 25 ++++++++++--------------- tests/testutilsqemu.h | 8 ++++---- tests/testutilsqemuschema.c | 3 +-- 8 files changed, 23 insertions(+), 30 deletions(-) -- 2.20.1

2 5

[libvirt] [ANNOUNCE] virtio-fs v0.2 host<->guest file system released
by Stefan Hajnoczi 16 Apr '19

16 Apr '19

Dear QEMU, KVM, and libvirt communities, virtio-fs is a shared file system that lets virtual machines access a directory tree on the host. Unlike existing approaches, it is designed to offer local file system semantics and performance. The guest can take advantage of Linux DAX to access file contents directly from the host page cache, eliminating the need to copy data into guest memory. We hope virtio-fs will become widely available and easily accessible through libvirt, Kata Containers, and popular management tools. For more information, visit https://virtio-fs.gitlab.io/. Mailing list: https://www.redhat.com/mailman/listinfo/virtio-fs IRC: #virtio-fs on chat.freenode.net The v0.2 release incorporates stabilization, performance, and sandboxing improvements that now make virtio-fs suitable for testing and performance evaluation. Please do not rely on virtio-fs for production data yet. Consider it experimental. Guides are available for: * Manually running QEMU with virtio-fs https://virtio-fs.gitlab.io/howto-qemu.html * Booting from virtio-fs (no disk images!) https://virtio-fs.gitlab.io/howto-boot.html * Running Kata Containers with virtio-fs https://virtio-fs.gitlab.io/howto-kata.html Stefan

1 0

[libvirt] [PATCH for v5.3.0 00/17] Fix and enable owner remembering
by Michal Privoznik 16 Apr '19

16 Apr '19

The basic owner remembering is already merged but was turned off because there were some issues. Well, this is my first attempt to fix those and then enable the feature. Yay! Michal Prívozník (17): tools: Slightly rework libvirt_recover_xattrs.sh virSecuritySELinuxRestoreAllLabel: Print @migrated in the debug message too virfile: Make virFileGetXAttr report errors virFileSetXAttr: Report error on failure virFileRemoveXAttr: Report error on failure security: Don't skip label restore on file systems lacking XATTRs security: Document @restore member of transaction list security_dac: Allow caller to suppress owner remembering security_selinux: Allow caller to suppress owner remembering security: Remember owner only for top level image security: Introduce virSecurityManagerMoveImageMetadata security_util: Introduce virSecurityMoveRememberedLabel security_dac: Implement virSecurityManagerMoveImageMetadata security_selinux: Implement virSecurityManagerMoveImageMetadata qemu_security: Implement qemuSecurityMoveImageMetadata qemu: Move image security metadata on snapshot activity Revert "qemu: Temporary disable owner remembering" docs/news.xml | 21 +++ src/libvirt_private.syms | 2 + src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf | 5 + src/qemu/qemu_blockjob.c | 6 + src/qemu/qemu_conf.c | 4 + src/qemu/qemu_driver.c | 17 +- src/qemu/qemu_security.c | 19 +++ src/qemu/qemu_security.h | 5 + src/qemu/test_libvirtd_qemu.aug.in | 1 + src/security/security_dac.c | 149 +++++++++++++---- src/security/security_driver.h | 5 + src/security/security_manager.c | 39 +++++ src/security/security_manager.h | 4 + src/security/security_nop.c | 10 ++ src/security/security_selinux.c | 249 ++++++++++++++++++++--------- src/security/security_stack.c | 20 +++ src/security/security_util.c | 85 +++++++++- src/security/security_util.h | 5 + src/util/virfile.c | 78 +++++++-- src/util/virfile.h | 5 + tests/qemusecuritymock.c | 6 +- tools/libvirt_recover_xattrs.sh | 49 +++--- 23 files changed, 626 insertions(+), 159 deletions(-) -- 2.19.2

3 34

[libvirt] [PATCH] util: hash: Append to hash buckets when adding new entries
by Peter Krempa 16 Apr '19

16 Apr '19

In cases when the hash function for a name collides with other entry already in the hash we prepend to the bucket. This creates a 'stack effect' on the buckets if we then iterate through the hash. Normally this is not a problem, but in tests we want deterministic results. Since it does not matter where we add the entry and it's usually more probable that a different entry will be accessed next change it to append to the end of the bucket. Luckily we already iterate throught the bucket once thus we can easily find the last entry and just connect the new entry after it. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/util/virhash.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/util/virhash.c b/src/util/virhash.c index 4907c1124f..0e30106041 100644 --- a/src/util/virhash.c +++ b/src/util/virhash.c @@ -316,6 +316,7 @@ virHashAddOrUpdateEntry(virHashTablePtr table, const void *name, { size_t key, len = 0; virHashEntryPtr entry; + virHashEntryPtr last = NULL; void *new_name; if ((table == NULL) || (name == NULL)) @@ -337,6 +338,7 @@ virHashAddOrUpdateEntry(virHashTablePtr table, const void *name, return -1; } } + last = entry; len++; } @@ -347,8 +349,11 @@ virHashAddOrUpdateEntry(virHashTablePtr table, const void *name, entry->name = new_name; entry->payload = userdata; - entry->next = table->table[key]; - table->table[key] = entry; + + if (last) + last->next = entry; + else + table->table[key] = entry; table->nbElems++; -- 2.20.1

2 6

[libvirt] Virtual machine
by Armando Chamusse 16 Apr '19

16 Apr '19

My Ubuntu16.04.5 server is installed qemo-kvm and libvirt-manager but virt-manager is not starting. consequently when I install vncserver the keyboard does not work on the virtual machine. But in ubuntu 14.04 it works perfectly. can my help ?? ERRO when try run : virt-manager Could not connect: Connection refused Failed to connect to Mir: Failed to connect to server socket: No such file or directory Unable to init server: Could not connect: Connection refused (virt-manager:7676): Gtk-CRITICAL **: gtk_settings_get_for_screen: assertion 'GDK_IS_SCREEN (screen)' failed

1 0

[libvirt] [PATCH v2 0/2] qemu: Honor memory mode='strict'
by Michal Privoznik 16 Apr '19

16 Apr '19

v2 of: https://www.redhat.com/archives/libvir-list/2019-April/msg00658.html diff to v1: - Fixed the reported problem. Basically, even though emulator CGroup was created qemu was not running in it. Now qemu is moved into the CGroup even before exec() Michal Prívozník (2): qemuSetupCpusetMems: Use VIR_AUTOFREE() qemu: Set up EMULATOR thread and cpuset.mems before exec()-ing qemu src/qemu/qemu_cgroup.c | 5 ++--- src/qemu/qemu_process.c | 12 ++++++++---- 2 files changed, 10 insertions(+), 7 deletions(-) -- 2.21.0

4 13

[libvirt] [PATCH v2 0/6] Add support for setting the emulator scheduler parameters
by Martin Kletzander 16 Apr '19

16 Apr '19

I/O threads and vCPU threads already support setting schedulers, but until now it was impossible to do so for the main QEMU thread (emulator thread in the libvirt naming). This is, however, requested for some very specific scenarios, for example when vCPU threads are running at such priority that could starve the main thread. v2: - news.xml addition in a separate patch Martin Kletzander (6): conf: Parse common scheduler attributes in separate function conf: Format thread IDs optionally docs: Mention iothreadsched element in the docs and reword conf: Add support for emulatorsched qemu: Add support for emulatorsched docs: Add emulatorsched support to news.xml docs/formatdomain.html.in | 25 +++-- docs/news.xml | 12 +++ docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c | 136 +++++++++++++++++------- src/conf/domain_conf.h | 1 + src/qemu/qemu_process.c | 2 +- tests/genericxml2xmlindata/cputune.xml | 37 +++++++ tests/genericxml2xmloutdata/cputune.xml | 40 +++++++ tests/genericxml2xmltest.c | 2 + 9 files changed, 212 insertions(+), 48 deletions(-) create mode 100644 tests/genericxml2xmlindata/cputune.xml create mode 100644 tests/genericxml2xmloutdata/cputune.xml -- 2.21.0

2 16

[libvirt] [PATCH] qemu: do not set wait:false for client sockets
by marcandre.lureau＠redhat.com 16 Apr '19

16 Apr '19

From: Marc-André Lureau <marcandre.lureau(a)redhat.com> Qemu commit 767abe7 ("chardev: forbid 'wait' option with client sockets") effectively deprecates usage of "wait" with client sockets starting with qemu 4.0, and earlier versions ignored the value. Cc: Daniel P. Berrangé <berrange(a)redhat.com> Signed-off-by: Marc-André Lureau <marcandre.lureau(a)redhat.com> --- src/qemu/qemu_monitor_json.c | 14 ++++++++++---- tests/qemumonitorjsontest.c | 2 -- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 71c452b25b..e7d063a5a8 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -6922,8 +6922,11 @@ qemuMonitorJSONAttachCharDevCommand(const char *chrID, telnet = chr->data.tcp.protocol == VIR_DOMAIN_CHR_TCP_PROTOCOL_TELNET; - if (virJSONValueObjectAppendBoolean(data, "wait", false) < 0 || - virJSONValueObjectAppendBoolean(data, "telnet", telnet) < 0 || + if (chr->data.tcp.listen && + virJSONValueObjectAppendBoolean(data, "wait", false) < 0) + goto cleanup; + + if (virJSONValueObjectAppendBoolean(data, "telnet", telnet) < 0 || virJSONValueObjectAppendBoolean(data, "server", chr->data.tcp.listen) < 0) goto cleanup; if (chr->data.tcp.tlscreds) { @@ -6973,8 +6976,11 @@ qemuMonitorJSONAttachCharDevCommand(const char *chrID, goto cleanup; addr = NULL; - if (virJSONValueObjectAppendBoolean(data, "wait", false) < 0 || - virJSONValueObjectAppendBoolean(data, "server", chr->data.nix.listen) < 0) + if (chr->data.nix.listen && + virJSONValueObjectAppendBoolean(data, "wait", false) < 0) + goto cleanup; + + if (virJSONValueObjectAppendBoolean(data, "server", chr->data.nix.listen) < 0) goto cleanup; if (qemuMonitorJSONBuildChrChardevReconnect(data, &chr->data.nix.reconnect) < 0) diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index 055e201611..f5ad3f6a73 100644 --- a/tests/qemumonitorjsontest.c +++ b/tests/qemumonitorjsontest.c @@ -874,7 +874,6 @@ qemuMonitorJSONTestAttachChardev(virDomainXMLOptionPtr xmlopt) "'data':{'addr':{'type':'inet'," "'data':{'host':'example.com'," "'port':'1234'}}," - "'wait':false," "'telnet':false," "'server':false}}}"); @@ -920,7 +919,6 @@ qemuMonitorJSONTestAttachChardev(virDomainXMLOptionPtr xmlopt) "'backend':{'type':'socket'," "'data':{'addr':{'type':'unix'," "'data':{'path':'/path/to/socket'}}," - "'wait':false," "'server':false}}}"); chr = (virDomainChrSourceDef) { .type = VIR_DOMAIN_CHR_TYPE_SPICEVMC }; -- 2.21.0.313.ge35b8cb8e2

2 2

[libvirt] [PATCH v4] socket: allow wait=false for client socket
by Marc-André Lureau 16 Apr '19

16 Apr '19

Commit 767abe7 ("chardev: forbid 'wait' option with client sockets") is a bit too strict. Current libvirt always set wait=false, and will thus fail to add client chardev. Make the code more permissive, allowing wait=false with client socket chardevs. Deprecate usage of 'wait' with client sockets. Fixes: 767abe7f49e8be14d29da5db3527817b5d696a52 Cc: Daniel P. Berrangé <berrange(a)redhat.com> Signed-off-by: Marc-André Lureau <marcandre.lureau(a)redhat.com> --- chardev/char-socket.c | 12 ++++++++---- qemu-deprecated.texi | 5 +++++ 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/chardev/char-socket.c b/chardev/char-socket.c index 3916505d67..b2cf593107 100644 --- a/chardev/char-socket.c +++ b/chardev/char-socket.c @@ -1263,10 +1263,14 @@ static bool qmp_chardev_validate_socket(ChardevSocket *sock, return false; } if (sock->has_wait) { - error_setg(errp, "%s", - "'wait' option is incompatible with " - "socket in client connect mode"); - return false; + warn_report("'wait' option is deprecated with " + "socket in client connect mode"); + if (sock->wait) { + error_setg(errp, "%s", + "'wait' option is incompatible with " + "socket in client connect mode"); + return false; + } } } diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 2219386769..842e71b11d 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -105,6 +105,11 @@ details. The ``query-events'' command has been superseded by the more powerful and accurate ``query-qmp-schema'' command. +@subsection chardev client socket with 'wait' option (since 4.0) + +Character devices creating sockets in client mode should not specify +the 'wait' field, which is only applicable to sockets in server mode + @section Human Monitor Protocol (HMP) commands @subsection The hub_id parameter of 'hostfwd_add' / 'hostfwd_remove' (since 3.1) -- 2.21.0.313.ge35b8cb8e2

3 2

[libvirt] [PATCH] test_driver: provide virDomainGetTime implementation
by Ilias Stamatis 16 Apr '19

16 Apr '19

Implement testDomainGetTime by returning the current time. Signed-off-by: Ilias Stamatis <stamatis.iliass(a)gmail.com> --- I initially implemented this using clock_gettime, but Pavel suggested that this might not be a good idea since it isn't a cross-platform function. So I used virTimeMillisNow instead and set the nanoseconds part to 0 which can be ok for the test driver. src/test/test_driver.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index d5eecf4b7f..b6f12e784f 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -64,6 +64,7 @@ #include "virinterfaceobj.h" #include "virhostcpu.h" #include "virdomainsnapshotobjlist.h" +#include "virtime.h" #define VIR_FROM_THIS VIR_FROM_TEST @@ -1943,6 +1944,23 @@ testDomainGetState(virDomainPtr domain, return 0; } +static int +testDomainGetTime(virDomainPtr dom ATTRIBUTE_UNUSED, + long long *seconds, + unsigned int *nseconds, + unsigned int flags ATTRIBUTE_UNUSED) +{ + unsigned long long now; + + if (virTimeMillisNow(&now) < 0) + return -1; + + *seconds = now / 1000; + *nseconds = 0; + + return 0; +} + #define TEST_SAVE_MAGIC "TestGuestMagic" static int @@ -6786,6 +6804,7 @@ static virHypervisorDriver testHypervisorDriver = { .domainSetMemory = testDomainSetMemory, /* 0.1.4 */ .domainGetInfo = testDomainGetInfo, /* 0.1.1 */ .domainGetState = testDomainGetState, /* 0.9.2 */ + .domainGetTime = testDomainGetTime, /* 5.3.0 */ .domainSave = testDomainSave, /* 0.3.2 */ .domainSaveFlags = testDomainSaveFlags, /* 0.9.4 */ .domainRestore = testDomainRestore, /* 0.3.2 */ -- 2.21.0

4 5

[libvirt] [PATCH] rpc: Segfaults and memory leak in virNetTLSContextNew function
by Adrian Brzezinski 16 Apr '19

16 Apr '19

Failed new gnutls context allocations in virNetTLSContextNew function results in double free and segfault. Occasional memory leaks may also occur. You can read detailed description at: https://bugzilla.redhat.com/show_bug.cgi?id=1699062 Signed-off-by: Adrian Brzezinski <redhat(a)adrb.pl> --- docs/news.xml | 10 ++++++++++ src/rpc/virnettlscontext.c | 6 ++++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/docs/news.xml b/docs/news.xml index 21807f2..f6157ec 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -350,6 +350,16 @@ <section title="Bug fixes"> <change> <summary> + rpc: Segfaults and memory leak in virNetTLSContextNew function + </summary> + <description> + Failed new gnutls context allocations in virNetTLSContextNew function + results in double free and segfault. Occasional memory leaks may also + occur. + </description> + </change> + <change> + <summary> qemu: Use CAP_DAC_OVERRIDE during QEMU capabilities probing </summary> <description> diff --git a/src/rpc/virnettlscontext.c b/src/rpc/virnettlscontext.c index 72e9ed9..8f6ec8f 100644 --- a/src/rpc/virnettlscontext.c +++ b/src/rpc/virnettlscontext.c @@ -703,14 +703,14 @@ static virNetTLSContextPtr virNetTLSContextNew(const char *cacert, return NULL; if (VIR_STRDUP(ctxt->priority, priority) < 0) - goto error; + goto ctxt_init_error; err = gnutls_certificate_allocate_credentials(&ctxt->x509cred); if (err) { virReportError(VIR_ERR_SYSTEM_ERROR, _("Unable to allocate x509 credentials: %s"), gnutls_strerror(err)); - goto error; + goto ctxt_init_error; } if (sanityCheckCert && @@ -759,6 +759,8 @@ static virNetTLSContextPtr virNetTLSContextNew(const char *cacert, if (isServer) gnutls_dh_params_deinit(ctxt->dhParams); gnutls_certificate_free_credentials(ctxt->x509cred); + ctxt_init_error: + if (ctxt->priority) VIR_FREE(ctxt->priority); VIR_FREE(ctxt); return NULL; } -- 1.8.3.1

3 7

[libvirt] [PATCH] news: document dropping support of VirtualBox versions < 5.0
by Daniel P. Berrangé 16 Apr '19

16 Apr '19

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/news.xml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 86c7734694..79b5658cc3 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -49,6 +49,16 @@ release. </description> </change> + <change> + <summary> + Removed support for VirtualBox versions < 5.0 + </summary> + <description> + Support for managing VirtualBox releases prior to 5.0 has + been dropped. The upstream project has declared that these + versions are end of life several years ago. + </description> + </change> </section> <section title="Bug fixes"> </section> -- 2.20.1

2 4

[libvirt] [PATCH 0/2] refactor virDomainSchedulerFormat
by Ján Tomko 16 Apr '19

16 Apr '19

*** BLURB HERE *** Ján Tomko (2): conf: pass the element/attribute names to virSchedulerFormat conf: switch virDomainSchedulerFormat to use virXMLFormatElement src/conf/domain_conf.c | 36 ++++++++++++++++++++---------------- 1 file changed, 20 insertions(+), 16 deletions(-) -- 2.19.2

2 4

[libvirt] [PATCH 0/1] power: add support for vm,uuid file
by Dimitri John Ledkov 16 Apr '19

16 Apr '19

On POWER systems, qemu exports uuid as a firmware devicetree node vm,uuid. Use that in a similar manner to the product_uuid file as on DMI based (x86) machines. Dimitri John Ledkov (1): viruuid: On POWER, qemu exports uuid as 'vm,uuid' devicetree node. src/util/viruuid.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.20.1

2 2

[libvirt] [dbus PATCH] tests: fix test_connect
by Pavel Hrdina 16 Apr '19

16 Apr '19

Calling fixtures directly was removed in pytest 4.0, we can change the fixture to be a wrapper around the original function and use the original fixture name. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- tests/libvirttest.py | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/tests/libvirttest.py b/tests/libvirttest.py index 14baf5b..a442196 100644 --- a/tests/libvirttest.py +++ b/tests/libvirttest.py @@ -84,13 +84,7 @@ class BaseTestClass(): interface_obj.Create(0) return path, interface_obj - @pytest.fixture def node_device_create(self): - """ Fixture to create dummy node device on the test driver - - This fixture should be used in the setup of every test manipulating - with node devices. - """ # We need a usable parent nodedev: possible candidates are # scsi_host2 (available since libvirt 3.1.0) and # test-scsi-host-vport (available until libvirt 3.0.0). @@ -109,6 +103,15 @@ class BaseTestClass(): path = self.connect.NodeDeviceCreateXML(xml, 0) return path + @pytest.fixture(name="node_device_create") + def fixture_node_device_create(self): + """ Fixture to create dummy node device on the test driver + + This fixture should be used in the setup of every test manipulating + with node devices. + """ + return self.node_device_create() + @pytest.fixture def storage_volume_create(self): """ Fixture to create dummy storage volume on the test driver -- 2.20.1

3 3

[libvirt] [PATCH v2 0/7] vbox: drop support for many old versions
by Daniel P. Berrangé 16 Apr '19

16 Apr '19

Per this link: https://www.virtualbox.org/wiki/Download_Old_Builds VirtualBox 6.0 (active maintenance) VirtualBox 5.2 (active maintenance) VirtualBox 5.1 (no longer supported, support ended 2018/04) VirtualBox 5.0 (no longer supported, support ended 2017/05) VirtualBox 4.3 (no longer supported, support ended 2015/12) VirtualBox 4.2 (no longer supported, support ended 2015/12) VirtualBox 4.1 (no longer supported, support ended 2015/12) VirtualBox 4.0 (no longer supported, support ended 2015/12) We can certainly drop all the 4.x versions. The host OS those are officially supported on are very outdated: eg https://www.virtualbox.org/wiki/Download_Old_Builds_4_3 Linux Hosts: Ubuntu 13.04 ("Raring") / 13.10 ("Saucy") / 14.04 ("Trusty") / 14.10 ("Utopic") i386 | AMD64 Ubuntu 12.10 ("Quantal") i386 | AMD64 Ubuntu 12.04 ("Precise") i386 | AMD64 Ubuntu 10.04 LTS ("Lucid") i386 | AMD64 Debian 7 ("Wheezy") i386 | AMD64 Debian 6 ("Squeeze") i386 | AMD64 openSUSE 12.3 / 13.1 i386 | AMD64 openSUSE 11.4 / 12.1 / 12.2 i386 | AMD64 SUSE Linux Enterprise Server 11 (SLES11) i386 | AMD64 SUSE Linux Enterprise Server 10 (SLES10) i386 | AMD64 Fedora 18 ("Spherical Cow") / Fedora 19 ("Schrödingers Cat") i386 | AMD64 Fedora 17 ("Beefy Miracle") i386 | AMD64 Mandriva 2011.0 i386 | AMD64 Oracle Linux 6 ("OL6") / Red Hat Enterprise Linux 6 ("RHEL6") / CentOS 6 i386 | AMD64 Oracle Linux 5 ("OL5") / Red Hat Enterprise Linux 5 ("RHEL5") / CentOS 5 i386 | AMD64 All distributions i386 | AMD64 Although the catch all "All distributions" suggest it might work with newer distros, they are clearly a second tier from a support POV. All these explicitly targetted distros are outside libvirt's support policy. There is a question as to whether to delete 5.0 and 5.1 support from libvirt. There are no remainining #ifdef VBOX_API_VERSION conditionals in the vbox_tmpl.h file related to code differences between 5.0, 5.1 and 5.2, so keeping them is not a maint burden in code. The main burden is distributing the large vbox_CAPI_v5_0.h and vbox_CAPI_v5_1.h files which are ~1 MB in size (uncompressed) or ~85 kb (xz compressed). IOW versions 5.0 and 5.1 increase the release tarballs by a small amount, but nothing that is too unreasonable vs the overall size of 14 MB for libvirt source. Thus I have kept 5.0 and 5.1 support. VirtualBox 6.0 came out in Dec 2018 and given past practice it would not suprise me if that has API changes impacting libvirt. So some interested party might want to look at supporting that in libvirt. In v2: - Also remove deleted files from the Makefile - Stop including the old deleted 4.0 API file Daniel P. Berrangé (7): vbox: drop support for VirtualBox 4.x releases vbox: drop C API definition for release 4.0 vbox: drop C API definition for release 4.1 vbox: drop C API definition for release 4.2 vbox: drop C API definition for release 4.2.20 vbox: drop C API definition for release 4.3 vbox: drop C API definition for release 4.3.4 src/vbox/Makefile.inc.am | 12 - src/vbox/vbox_CAPI_v4_0.h | 7451 ----------------------- src/vbox/vbox_CAPI_v4_1.h | 7882 ------------------------ src/vbox/vbox_CAPI_v4_2.h | 8855 --------------------------- src/vbox/vbox_CAPI_v4_2_20.h | 9001 ---------------------------- src/vbox/vbox_CAPI_v4_3.h | 10210 ------------------------------- src/vbox/vbox_CAPI_v4_3_4.h | 10321 -------------------------------- src/vbox/vbox_V4_0.c | 37 - src/vbox/vbox_V4_1.c | 37 - src/vbox/vbox_V4_2.c | 13 - src/vbox/vbox_V4_2_20.c | 13 - src/vbox/vbox_V4_3.c | 13 - src/vbox/vbox_V4_3_4.c | 13 - src/vbox/vbox_XPCOMCGlue.h | 2 +- src/vbox/vbox_common.h | 14 +- src/vbox/vbox_storage.c | 14 +- src/vbox/vbox_tmpl.c | 218 +- src/vbox/vbox_uniformed_api.h | 10 +- 18 files changed, 8 insertions(+), 54108 deletions(-) delete mode 100644 src/vbox/vbox_CAPI_v4_0.h delete mode 100644 src/vbox/vbox_CAPI_v4_1.h delete mode 100644 src/vbox/vbox_CAPI_v4_2.h delete mode 100644 src/vbox/vbox_CAPI_v4_2_20.h delete mode 100644 src/vbox/vbox_CAPI_v4_3.h delete mode 100644 src/vbox/vbox_CAPI_v4_3_4.h delete mode 100644 src/vbox/vbox_V4_0.c delete mode 100644 src/vbox/vbox_V4_1.c delete mode 100644 src/vbox/vbox_V4_2.c delete mode 100644 src/vbox/vbox_V4_2_20.c delete mode 100644 src/vbox/vbox_V4_3.c delete mode 100644 src/vbox/vbox_V4_3_4.c -- 2.20.1

2 10

[libvirt] [PATCH] news: Document firmware autoselection exposure in domcaps
by Michal Privoznik 16 Apr '19

16 Apr '19

Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- docs/news.xml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 21807f26d3..eb97d25c80 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -49,6 +49,18 @@ release. </description> </change> + <change> + <summary> + qemu: Advertise firmware autoselection in domain capabilities + </summary> + <description> + The firmware autoselection feature is now exposed in + domain capabilities and management applications can + query for accepted values, i.e. values that are accepted + and for which libvirt found firmware descriptor files. + Among with that support for Secure Boot is advertised. + </description> + </change> </section> <section title="Bug fixes"> </section> -- 2.21.0

2 1

[libvirt] [PATCH 0/3] vmx: add efi firmware attribute
by Pino Toscano 16 Apr '19

16 Apr '19

Use the recently added infrastructure for firmware autoselection, and indicate which firmware is used by a VMware guest. Pino Toscano (3): vmx: convert firmware config for autoselection vmx: write firmware back from autoselection docs: document firmware attribute for VMware guests docs/formatdomain.html.in | 5 ++++- src/vmx/vmx.c | 20 ++++++++++++++++++++ tests/vmx2xmldata/vmx2xml-firmware-efi.vmx | 3 +++ tests/vmx2xmldata/vmx2xml-firmware-efi.xml | 18 ++++++++++++++++++ tests/vmx2xmltest.c | 2 ++ tests/xml2vmxdata/xml2vmx-firmware-efi.vmx | 11 +++++++++++ tests/xml2vmxdata/xml2vmx-firmware-efi.xml | 8 ++++++++ tests/xml2vmxtest.c | 2 ++ 8 files changed, 68 insertions(+), 1 deletion(-) create mode 100644 tests/vmx2xmldata/vmx2xml-firmware-efi.vmx create mode 100644 tests/vmx2xmldata/vmx2xml-firmware-efi.xml create mode 100644 tests/xml2vmxdata/xml2vmx-firmware-efi.vmx create mode 100644 tests/xml2vmxdata/xml2vmx-firmware-efi.xml -- 2.20.1

2 4

[libvirt] [PATCH] virErrorPreserveLast/virErrorRestore conversions
by Syed Humaid 15 Apr '19

15 Apr '19

As per the suggestions regarding the previous patch for virErrorPreserveLast conversions, I have converted all instances to virErrorPreserveLast and virErrorRestore. Signed-off-by: Syed Humaid <syedhumaidbinharoon(a)gmail.com> --- src/libvirt-domain.c | 26 +++++++++++--------------- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index be5b1f6740..8eebb60a2e 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -2894,7 +2894,7 @@ virDomainMigrateVersion2(virDomainPtr domain, _("domainMigratePrepare2 did not set uri")); cancelled = 1; /* Make sure Finish doesn't overwrite the error */ - orig_err = virSaveLastError(); + virErrorPreserveLast(&orig_err); goto finish; } if (uri_out) @@ -2909,7 +2909,7 @@ virDomainMigrateVersion2(virDomainPtr domain, /* Perform failed. Make sure Finish doesn't overwrite the error */ if (ret < 0) - orig_err = virSaveLastError(); + virErrorPreserveLast(&orig_err); /* If Perform returns < 0, then we need to cancel the VM * startup on the destination @@ -2929,10 +2929,8 @@ virDomainMigrateVersion2(virDomainPtr domain, VIR_ERROR(_("finish step ignored that migration was cancelled")); done: - if (orig_err) { - virSetError(orig_err); - virFreeError(orig_err); - } + virErrorRestore(&orig_err); + VIR_FREE(uri_out); VIR_FREE(cookie); return ddomain; @@ -3076,7 +3074,7 @@ virDomainMigrateVersion3Full(virDomainPtr domain, /* Begin already started a migration job so we need to cancel it by * calling Confirm while making sure it doesn't overwrite the error */ - orig_err = virSaveLastError(); + virErrorPreserveLast(&orig_err); goto confirm; } else { goto done; @@ -3091,7 +3089,7 @@ virDomainMigrateVersion3Full(virDomainPtr domain, VIR_MIGRATE_PARAM_URI, uri_out) < 0) { cancelled = 1; - orig_err = virSaveLastError(); + virErrorPreserveLast(&orig_err); goto finish; } } else if (!uri && @@ -3100,7 +3098,7 @@ virDomainMigrateVersion3Full(virDomainPtr domain, virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("domainMigratePrepare3 did not set uri")); cancelled = 1; - orig_err = virSaveLastError(); + virErrorPreserveLast(&orig_err); goto finish; } @@ -3136,7 +3134,7 @@ virDomainMigrateVersion3Full(virDomainPtr domain, /* Perform failed. Make sure Finish doesn't overwrite the error */ if (ret < 0) { - orig_err = virSaveLastError(); + virErrorPreserveLast(&orig_err); /* Perform failed so we don't need to call confirm to let source know * about the failure. */ @@ -3222,7 +3220,7 @@ virDomainMigrateVersion3Full(virDomainPtr domain, * one we need to preserve it in case confirm3 overwrites */ if (!orig_err) - orig_err = virSaveLastError(); + virErrorPreserveLast(&orig_err); confirm: /* @@ -3256,10 +3254,8 @@ virDomainMigrateVersion3Full(virDomainPtr domain, } done: - if (orig_err) { - virSetError(orig_err); - virFreeError(orig_err); - } + virErrorRestore(&orig_err); + VIR_FREE(dom_xml); VIR_FREE(uri_out); VIR_FREE(cookiein); -- 2.20.1

2 1

[libvirt] [PATCH 00/12] tests: qemuxml2xml: add DO_TEST_CAPS*
by Cole Robinson 15 Apr '19

15 Apr '19

This series moves testInfoSetArgs and friends from qemuxml2argvtest.c into testutilsqemu.c, so we can use them in qemuxml2xml and make use of the CAPS handling. It will also make things easier to test xml2xml failures for example if we wanted to. Cole Robinson (12): tests: qemuxml2xml: Break out testInfoSet*Paths tests: qemuxml2xml: Add info->{in,out}file tests: qemuxml2xml: Remove info->outActiveName tests: qemuxml2argv: Add info->{in,out}file tests: qemuxml2argv: add testInfoSetPaths tests: qemuxml2argv: Rename testInfo* to testQemuInfo* tests: Move testQemuInfo* to testutilsqemu tests: add testQemuGetCapsLatest tests: qemuxml2xml: Use struct testQemuInfo tests: qemuxml2xml: Use testQemuInfoSetArgs tests: qemuxml2xml: make GIC handling optional tests: qemuxml2xml: Add DO_TEST_CAPS* tests/qemuxml2argvdata/vhost-vsock.xml | 2 +- tests/qemuxml2argvtest.c | 238 ++----------- .../aarch64-os-firmware-efi.xml | 32 +- tests/qemuxml2xmloutdata/os-firmware-bios.xml | 69 +++- .../os-firmware-efi-secboot.xml | 69 +++- tests/qemuxml2xmloutdata/os-firmware-efi.xml | 69 +++- tests/qemuxml2xmltest.c | 313 ++++++++---------- tests/testutilsqemu.c | 181 ++++++++++ tests/testutilsqemu.h | 40 +++ 9 files changed, 618 insertions(+), 395 deletions(-) mode change 120000 => 100644 tests/qemuxml2xmloutdata/aarch64-os-firmware-efi.xml mode change 120000 => 100644 tests/qemuxml2xmloutdata/os-firmware-bios.xml mode change 120000 => 100644 tests/qemuxml2xmloutdata/os-firmware-efi-secboot.xml mode change 120000 => 100644 tests/qemuxml2xmloutdata/os-firmware-efi.xml -- 2.21.0

3 29

[libvirt] [PATCH] virSecurityDACRestoreChardevLabel: Restore UNIX sockets too
by Michal Privoznik 15 Apr '19

15 Apr '19

We're setting seclabels on unix sockets but never restoring them. Surprisingly, we are in SELinux driver. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/security/security_dac.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/security/security_dac.c b/src/security/security_dac.c index 6f8ca8cd54..0adf71bed6 100644 --- a/src/security/security_dac.c +++ b/src/security/security_dac.c @@ -1457,13 +1457,25 @@ virSecurityDACRestoreChardevLabel(virSecurityManagerPtr mgr, ret = 0; break; + case VIR_DOMAIN_CHR_TYPE_UNIX: + if (!dev_source->data.nix.listen || + (dev_source->data.nix.path && + virFileExists(dev_source->data.nix.path))) { + /* Also label mode='bind' sockets if they exist, + * e.g. because they were created by libvirt + * and passed via FD */ + if (virSecurityDACRestoreFileLabel(mgr, dev_source->data.nix.path) < 0) + goto done; + } + ret = 0; + break; + case VIR_DOMAIN_CHR_TYPE_NULL: case VIR_DOMAIN_CHR_TYPE_VC: case VIR_DOMAIN_CHR_TYPE_PTY: case VIR_DOMAIN_CHR_TYPE_STDIO: case VIR_DOMAIN_CHR_TYPE_UDP: case VIR_DOMAIN_CHR_TYPE_TCP: - case VIR_DOMAIN_CHR_TYPE_UNIX: case VIR_DOMAIN_CHR_TYPE_SPICEVMC: case VIR_DOMAIN_CHR_TYPE_SPICEPORT: case VIR_DOMAIN_CHR_TYPE_NMDM: -- 2.21.0

2 1

[libvirt] Is qemu guestfwd working?
by Marc-André Lureau 15 Apr '19

15 Apr '19

Hi, How is guestfwd working? I am testing with the following domain xml snippet, which should let the guest connect to 10.0.2.1:4600 <channel type='unix'> <source mode='connect' path='/tmp/guestfwd'/> <target type='guestfwd' address='10.0.2.1' port='4600'/> </channel> If I have a domain with bridge networking, adding guestfwd isn't going to work, unless I am missing something. Should libvirt prevent that? But even if I use user networking, guestfwd will create a separate netdev, which isn't connected to any peer (both at cold and hot plug time) How is it supposed to work? thanks -- Marc-André Lureau

1 0

[libvirt] [PATCH v3] socket: allow wait=false for client socket
by Marc-André Lureau 15 Apr '19

15 Apr '19

Commit 767abe7 ("chardev: forbid 'wait' option with client sockets") is a bit too strict. Current libvirt always set wait=false, and will thus fail to add client chardev. Make the code more permissive, allowing wait=false with client socket chardevs. Deprecate usage of 'wait' with client sockets. Fixes: 767abe7f49e8be14d29da5db3527817b5d696a52 Cc: Daniel P. Berrangé <berrange(a)redhat.com> Signed-off-by: Marc-André Lureau <marcandre.lureau(a)redhat.com> --- chardev/char-socket.c | 10 +++++++--- qemu-deprecated.texi | 5 +++++ 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/chardev/char-socket.c b/chardev/char-socket.c index 3916505d67..ebc1adb83e 100644 --- a/chardev/char-socket.c +++ b/chardev/char-socket.c @@ -1263,9 +1263,13 @@ static bool qmp_chardev_validate_socket(ChardevSocket *sock, return false; } if (sock->has_wait) { - error_setg(errp, "%s", - "'wait' option is incompatible with " - "socket in client connect mode"); + warn_report("'wait' option is deprecated with " + "socket in client connect mode"); + if (sock->wait) { + error_setg(errp, "%s", + "'wait' option is incompatible with " + "socket in client connect mode"); + } return false; } } diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 2219386769..842e71b11d 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -105,6 +105,11 @@ details. The ``query-events'' command has been superseded by the more powerful and accurate ``query-qmp-schema'' command. +@subsection chardev client socket with 'wait' option (since 4.0) + +Character devices creating sockets in client mode should not specify +the 'wait' field, which is only applicable to sockets in server mode + @section Human Monitor Protocol (HMP) commands @subsection The hub_id parameter of 'hostfwd_add' / 'hostfwd_remove' (since 3.1) -- 2.21.0.313.ge35b8cb8e2

2 2

[libvirt] [PATCH] tools: Reduce table width in virsh(1)
by Andrea Bolognani 15 Apr '19

15 Apr '19

The table included in the sample output for 'list --title' is unnecessarily wide, which causes man to complain: warning [p 8, 0.5i]: can't break line Make the table narrower. Spotted by Lintian (manpage-has-errors-from-man tag). Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- tools/virsh.pod | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index bb52de3eed..3196636825 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -545,10 +545,10 @@ I<--table> output. Example: B<virsh> list --title - Id Name State Title - -------------------------------------------------------------------------- - 0 Domain-0 running Mailserver 1 - 2 fedora paused + Id Name State Title + ------------------------------------------- + 0 Domain-0 running Mailserver 1 + 2 fedora paused =item B<freecell> [{ [I<--cellno>] B<cellno> | I<--all> }] -- 2.20.1

2 1

[libvirt] [PATCH] tools: Fix grammar
by Andrea Bolognani 15 Apr '19

15 Apr '19

Apparently "allow(s) to frobnicate" is not correct English, and either "allow(s) one to frobnicate" or "allow(s) frobnicating" should be used instead. Spotted by Lintian (spelling-error-in-{binary,manpage} tags). Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- tools/virsh-domain.c | 3 ++- tools/virsh.pod | 20 ++++++++++---------- tools/virt-admin.pod | 4 ++-- 3 files changed, 14 insertions(+), 13 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index d99b9afda9..da57d96d1a 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -8313,7 +8313,8 @@ static const vshCmdInfo info_desc[] = { .data = N_("show or set domain's description or title") }, {.name = "desc", - .data = N_("Allows to show or modify description or title of a domain.") + .data = N_("Allows setting or modifying the description or title of " + "a domain.") }, {.name = NULL} }; diff --git a/tools/virsh.pod b/tools/virsh.pod index 3196636825..afc1684db0 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -778,7 +778,7 @@ effect on the next boot. New description or title message] Show or modify description and title of a domain. These values are user -fields that allow to store arbitrary textual data to allow easy +fields that allow storing arbitrary textual data to allow easy identification of domains. Title should be short, although it's not enforced. (See also B<metadata> that works with XML based domain metadata.) @@ -1303,7 +1303,7 @@ within a certain range. Specifying I<buf-size> will control how much data can be simultaneously in-flight during the copy; larger values use more memory but may allow faster completion (the default value is usually correct). -I<--transient-job> allows to specify that the user does not require the job to +I<--transient-job> allows specifying that the user does not require the job to be recovered if the VM crashes or is turned off before the job completes. This flag removes the restriction of copy jobs to transient domains if that restriction is applied by the hypervisor. @@ -1450,9 +1450,9 @@ bytes/s. Specifying a negative value is interpreted as an unsigned long value or essentially unlimited. The hypervisor can choose whether to reject the value or convert it to the maximum value allowed. Optionally a scaled positive number may be used as bandwidth (see B<NOTES> above). Using -I<--bytes> with a scaled value allows to use finer granularity. A scaled value -used without I<--bytes> will be rounded down to MiB/s. Note that the -I<--bytes> may be unsupported by the hypervisor. +I<--bytes> with a scaled value permits a finer granularity to be selected. +A scaled value used without I<--bytes> will be rounded down to MiB/s. Note +that the I<--bytes> may be unsupported by the hypervisor. =item B<domblkthreshold> I<domain> I<dev> I<threshold> @@ -1876,7 +1876,7 @@ stats. [I<--edit>] [I<uri>] [I<key>] [I<set>] [I<--remove>] Show or modify custom XML metadata of a domain. The metadata is a user -defined XML that allows to store arbitrary XML data in the domain definition. +defined XML that allows storing arbitrary XML data in the domain definition. Multiple separate custom metadata pieces can be stored in the domain XML. The pieces are identified by a private XML namespace provided via the I<uri> argument. (See also B<desc> that works with textual metadata of @@ -2327,8 +2327,8 @@ either parameter is the same as not specifying that parameter. =item B<screenshot> I<domain> [I<imagefilepath>] [I<--screen> B<screenID>] Takes a screenshot of a current domain console and stores it into a file. -Optionally, if hypervisor supports more displays for a domain, I<screenID> -allows to specify which screen will be captured. It is the sequential number +Optionally, if the hypervisor supports more displays for a domain, I<screenID> +allows specifying which screen will be captured. It is the sequential number of screen. In case of multiple graphics cards, heads are enumerated before devices, e.g. having two graphics cards, both with four heads, screen ID 5 addresses the second head on the second card. @@ -3392,8 +3392,8 @@ expected. Change media of CDROM or floppy drive. I<path> can be the fully-qualified path or the unique target name (<target dev='hdc'>) of the disk device. I<source> -specifies the path of the media to be inserted or updated. Flag I<--block> -allows to set the backing type in case a block device is used as media for the +specifies the path of the media to be inserted or updated. The I<--block> flag +allows setting the backing type in case a block device is used as media for the CDROM or floppy drive instead of a file. I<--eject> indicates the media will be ejected. diff --git a/tools/virt-admin.pod b/tools/virt-admin.pod index f06ee9247a..1ea6defa0e 100644 --- a/tools/virt-admin.pod +++ b/tools/virt-admin.pod @@ -149,8 +149,8 @@ libvirtd:///system is used. =head1 DAEMON COMMANDS -The following commands allow to monitor the daemon's state as well as directly -change its internal configuration. +The following commands allow one to monitor the daemon's state as well as +directly change its internal configuration. =over 4 -- 2.20.1

2 1

[libvirt] [PATCH 0/2] util: Fix NAME section for virkey{code, name}-*
by Andrea Bolognani 15 Apr '19

15 Apr '19

Andrea Bolognani (2): keycodemapdb: Update submodule util: Fix NAME section for virkey{code,name}-* src/keycodemapdb | 2 +- src/util/Makefile.inc.am | 8 ++++++-- 2 files changed, 7 insertions(+), 3 deletions(-) -- 2.20.1

2 6

[libvirt] vcpupin reports bogus vcpu affinities
by Allen, John 15 Apr '19

15 Apr '19

For pinned vcpus, vcpupin will report inaccurate affinity values on machines with high core counts (256 cores in my case). The problem is produced as follows: $ virsh vcpupin myguest 0 4 $ virsh vcpupin myguest 0 VCPU CPU Affinity --------------------------- 0 4,192,194,196-197 Running taskset on the qemu threads shows the correct affinity, so this seems to be a reporting problem. Strangely, the value "192" is significant. If I pin a cpu greater than 192, the problem no longer appears. I believe the cause of the problem in my case is that in this case in src/conf/domain_conf.c:virDomainDefGetVcpuPinInfoHelper: ... if (vcpu && vcpu->cpumask) bitmap = vcpu->cpumask; ... vcpu->cpumask is "shortened" in that it is only long enough to contain the last set bit in the mask. However, when we go to copy the mask to the buffer that is returned, we use the masklen passed to the function which is the "full" masklen with a bit for each cpu. So it seems virBitmapToDataBuf copies some extra data past the end of the bitmask. Why the "192" value is always set and I typically see similar bogus bits set is still unknown. What is the function meant to assume in this case? Is it sane to assume that the bitmask is the full length of the buffer here and it's the responsibility of the setter of vcpu->cpumask to provide the length of the bitmap we're expecting? Or should we assume that we may receive a shortened bitmask here and expand the bitmask before copying to the buffer? -John

2 2

[libvirt] [PATCH] Don't hardcode list of git submodules
by Andrea Bolognani 15 Apr '19

15 Apr '19

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Makefile.ci | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.ci b/Makefile.ci index 738da53cc8..864948dc96 100644 --- a/Makefile.ci +++ b/Makefile.ci @@ -44,7 +44,7 @@ CI_CONFIGURE_ARGS = # Avoid pulling submodules over the network by locally # cloning them -CI_SUBMODULES = .gnulib src/keycodemapdb +CI_SUBMODULES = $(shell git submodules | awk '{ print $2 }') # Location of the Docker images we're going to pull # Can be useful to overridde to use a locally built -- 2.20.1

3 4

[libvirt] [PATCH 0/5] Add support for setting the emulator scheduler parameters
by Martin Kletzander 15 Apr '19

15 Apr '19

I/O threads and vCPU threads already support setting schedulers, but until now it was impossible to do so for the main QEMU thread (emulator thread in the libvirt naming). This is, however, requested for some very specific scenarios, for example when vCPU threads are running at such priority that could starve the main thread. Martin Kletzander (5): conf: Parse common scheduler attributes in separate function conf: Format thread IDs optionally docs: Mention iothreadsched element in the docs and reword conf: Add support for emulatorsched qemu: Add support for emulatorsched docs/formatdomain.html.in | 25 +++-- docs/news.xml | 12 +++ docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c | 136 +++++++++++++++++------- src/conf/domain_conf.h | 1 + src/qemu/qemu_process.c | 2 +- tests/genericxml2xmlindata/cputune.xml | 37 +++++++ tests/genericxml2xmloutdata/cputune.xml | 40 +++++++ tests/genericxml2xmltest.c | 2 + 9 files changed, 212 insertions(+), 48 deletions(-) create mode 100644 tests/genericxml2xmlindata/cputune.xml create mode 100644 tests/genericxml2xmloutdata/cputune.xml -- 2.21.0

1 6

[libvirt] [keycodemapdb PATCH] keymap-gen: Name sections in pod output
by Andrea Bolognani 15 Apr '19

15 Apr '19

Properly formatted man pages have at least a NAME section, which tools like apropos(1) parse and index. The current implementation of PodLanguageGenerator doesn't generate this section, and even if the user were to try and work around the limitation by passing --varname=NAME, there would still be nothing in the section to actually parse. Change the generator so that varname will be used as the contents of the NAME section, add a DESCRIPTION section in which values are listed. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Dan said on IRC he would accept keycodemapdb patches sent to the mailing list of any project using the module, so here we are :) I need this to fix generation of virkey{code,name}-* man pages anyway. tools/keymap-gen | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/tools/keymap-gen b/tools/keymap-gen index 7965d37..78676a9 100755 --- a/tools/keymap-gen +++ b/tools/keymap-gen @@ -873,7 +873,11 @@ class PodLanguageGenerator(LanguageDocGenerator): print("#") def _array_start_name_doc(self, varname, namemap): - print("=head1 %s" % varname) + print("=head1 NAME") + print("") + print("%s" % varname) + print("") + print("=head1 DESCRIPTION") print("") print("List of %s key code names, with corresponding key code values" % namemap) print("") @@ -881,7 +885,11 @@ class PodLanguageGenerator(LanguageDocGenerator): print("") def _array_start_code_doc(self, varname, codemap, namemap): - print("=head1 %s" % varname) + print("=head1 NAME") + print("") + print("%s" % varname) + print("") + print("=head1 DESCRIPTION") print("") print("List of %s key code values, with corresponding %s key code names" % (codemap, namemap)) print("") -- 2.20.1

2 1

[libvirt] [PATCH] qemu: Don't cache microcode version
by Jiri Denemark 15 Apr '19

15 Apr '19

My earlier commit be46f61326 was incomplete. It removed caching of microcode version in the CPU driver, which means the capabilities XML will see the correct microcode version. But it is also cached in the QEMU capabilities cache where it is used to detect whether we need to reprobe QEMU. By missing the second place, the original commit be46f61326 made the situation even worse since libvirt would report correct microcode version while still using the old host CPU model (visible in domain capabilities XML). Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_capabilities.c | 12 ++++++++---- src/qemu/qemu_capabilities.h | 3 +-- src/qemu/qemu_driver.c | 9 +-------- tests/testutilsqemu.c | 2 +- 4 files changed, 11 insertions(+), 15 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index da90cd666e..a74dc84056 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -4542,7 +4542,7 @@ virQEMUCapsNewData(const char *binary, priv->libDir, priv->runUid, priv->runGid, - priv->microcodeVersion, + virHostCPUGetMicrocodeVersion(), priv->kernelVersion); } @@ -4625,8 +4625,7 @@ virFileCachePtr virQEMUCapsCacheNew(const char *libDir, const char *cacheDir, uid_t runUid, - gid_t runGid, - unsigned int microcodeVersion) + gid_t runGid) { char *capsCacheDir = NULL; virFileCachePtr cache = NULL; @@ -4650,7 +4649,6 @@ virQEMUCapsCacheNew(const char *libDir, priv->runUid = runUid; priv->runGid = runGid; - priv->microcodeVersion = microcodeVersion; priv->kvmUsable = VIR_TRISTATE_BOOL_ABSENT; if (uname(&uts) == 0 && @@ -4672,8 +4670,11 @@ virQEMUCapsPtr virQEMUCapsCacheLookup(virFileCachePtr cache, const char *binary) { + virQEMUCapsCachePrivPtr priv = virFileCacheGetPriv(cache); virQEMUCapsPtr ret = NULL; + priv->microcodeVersion = virHostCPUGetMicrocodeVersion(); + ret = virFileCacheLookup(cache, binary); VIR_DEBUG("Returning caps %p for %s", ret, binary); @@ -4727,6 +4728,7 @@ virQEMUCapsPtr virQEMUCapsCacheLookupByArch(virFileCachePtr cache, virArch arch) { + virQEMUCapsCachePrivPtr priv = virFileCacheGetPriv(cache); virQEMUCapsPtr ret = NULL; const char *binaryFilters[] = { "qemu-system-", @@ -4739,6 +4741,8 @@ virQEMUCapsCacheLookupByArch(virFileCachePtr cache, size_t i; size_t j; + priv->microcodeVersion = virHostCPUGetMicrocodeVersion(); + for (i = 0; i < ARRAY_CARDINALITY(binaryFilters); i++) { for (j = 0; j < ARRAY_CARDINALITY(archs); j++) { struct virQEMUCapsSearchData data = { diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h index fd7bec7589..8f5656a89b 100644 --- a/src/qemu/qemu_capabilities.h +++ b/src/qemu/qemu_capabilities.h @@ -590,8 +590,7 @@ void virQEMUCapsFilterByMachineType(virQEMUCapsPtr qemuCaps, virFileCachePtr virQEMUCapsCacheNew(const char *libDir, const char *cacheDir, uid_t uid, - gid_t gid, - unsigned int microcodeVersion); + gid_t gid); virQEMUCapsPtr virQEMUCapsCacheLookup(virFileCachePtr cache, const char *binary); virQEMUCapsPtr virQEMUCapsCacheLookupCopy(virFileCachePtr cache, diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 7e334d0d8d..4510b0ce60 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -584,8 +584,6 @@ qemuStateInitialize(bool privileged, char *hugepagePath = NULL; char *memoryBackingPath = NULL; size_t i; - virCPUDefPtr hostCPU = NULL; - unsigned int microcodeVersion = 0; if (VIR_ALLOC(qemu_driver) < 0) return -1; @@ -808,15 +806,10 @@ qemuStateInitialize(bool privileged, run_gid = cfg->group; } - if ((hostCPU = virCPUProbeHost(virArchFromHost()))) - microcodeVersion = hostCPU->microcodeVersion; - virCPUDefFree(hostCPU); - qemu_driver->qemuCapsCache = virQEMUCapsCacheNew(cfg->libDir, cfg->cacheDir, run_uid, - run_gid, - microcodeVersion); + run_gid); if (!qemu_driver->qemuCapsCache) goto error; diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c index 3ee8a0c6c6..763f511bcf 100644 --- a/tests/testutilsqemu.c +++ b/tests/testutilsqemu.c @@ -740,7 +740,7 @@ int qemuTestDriverInit(virQEMUDriver *driver) /* Using /dev/null for libDir and cacheDir automatically produces errors * upon attempt to use any of them */ - driver->qemuCapsCache = virQEMUCapsCacheNew("/dev/null", "/dev/null", 0, 0, 0); + driver->qemuCapsCache = virQEMUCapsCacheNew("/dev/null", "/dev/null", 0, 0); if (!driver->qemuCapsCache) goto error; -- 2.21.0

2 1

[libvirt] Cleaning up libvirt.git tags
by Andrea Bolognani 15 Apr '19

15 Apr '19

We have four types of tags in libvirt.git right now: * vX.Y.Z: we have one of these per release, starting with v0.1.0 from April 2006 and going all the way to v5.2.0 from April 2019 (but see below). Most of them[1] are PGP-signed. * LIBVIR(T)_X_Y_Z: these point to the same commit as the ones above, but the last one we created is for v0.6.5 from July 2009; not a single one is PGP-signed. * CVE-YYYY-*: these point to the commit fixing the corresponding vulnerability. We seem to have stopped creating them in 2017, even though we definitely have had to deal with CVEs since ;) * LIBXEN_FIRST_COMMIT: one-of-a-kind tag pointing to the second ever (!) libvirt (!) commit. Of course the project was still called libxen back then, but this is the only surviving tag to reference the old name. Interestingly[2] enough, a few releases seem to have partially or completely slipped through the cracks: version commit tag tarball --------- -------------- ----- --------- v0.1.2 | 567b42ce6a07 | no | no v0.1.5 | 786e029cd743 | no | yes v0.4.0 | 6cb028991705 | no | yes v0.4.3 | 7db4c905d745 | no | yes v0.4.5 | 9d3d43436eac | no | yes Note that I stopped checking at v0.6.5, so there might actually be more. Anyway, since the LIBVIR(T)_X_Y_Z tags are a strict subset of the vX.Y.Z tags, and we have abandoned that naming scheme a decade ago, all they're doing right now is clutter the output of 'git tag' and I would suggest getting rid of them; same goes for that lonely, lonely LIBXEN_FIRST_COMMIT tag, which serves no real purpose other than reminding us that the project was named differently for, like, an entire month. As for the missing release commits, I see no harm in creating them retroactively for completeness' sake, but if nobody can be bothered doing that I'll also fully understand :) The CVE tags... I really don't have an opinion there. Thoughts? [1] Though not all of them: I'm pointing my finger at you, Cole! :P [2] Well, to me at least. -- Andrea Bolognani / Red Hat / Virtualization

3 4