- Devel - libvirt List Archives

[PATCH] esx: Accept empty "path" URI component same way as "/"
by Peter Krempa 09 Apr '25

09 Apr '25

From: Peter Krempa <pkrempa(a)redhat.com> When connecting to "esx://" URI there's code which prints a warning that the path is not "empty". The check validates that "uri->path" is "/". In case when the user uses URI such as: esx://hostname the warning is printed as well. Since there is no effective difference betweeen the two allow empty strings as well. Resolves: https://issues.redhat.com/browse/RHEL-86459 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/esx/esx_driver.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index 6ae4ef9658..512ca6c028 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -687,7 +687,9 @@ esxConnectToVCenter(esxPrivate *priv, g_autofree char *url = NULL; if (!hostSystemIPAddress && - (!priv->parsedUri->path || STREQ(priv->parsedUri->path, "/"))) { + (!priv->parsedUri->path || + STREQ(priv->parsedUri->path, "") || + STREQ(priv->parsedUri->path, "/"))) { virReportError(VIR_ERR_INVALID_ARG, "%s", _("Path has to specify the datacenter and compute resource")); return -1; @@ -799,6 +801,7 @@ esxConnectOpen(virConnectPtr conn, virConnectAuthPtr auth, virCheckFlags(VIR_CONNECT_RO, VIR_DRV_OPEN_ERROR); if (STRCASENEQ(conn->uri->scheme, "vpx") && + STRNEQ(conn->uri->path, "") && STRNEQ(conn->uri->path, "/")) { VIR_WARN("Ignoring unexpected path '%s' for non-vpx scheme '%s'", conn->uri->path, conn->uri->scheme); -- 2.49.0

2 1

[PATCH 0/5] virNodeGetInfo: Fix docs and propagate them to 'virsh nodeinfo'
by Peter Krempa 09 Apr '25

09 Apr '25

Patches 1,2 cleanup the code the rest deals with docs. Peter Krempa (5): virHostCPUGetInfoPopulateLinux: Use automatic memory freeing virHostCPUGetInfoPopulateLinux: Remove 'cleanup' libvirt-host: Clarify/fix description of the CPU frequency field virNodeGetInfo: Improve description of the case when fake data is reported manpages: virsh: Use disclaimer from 'virNodeGetInfo()' for 'virsh nodeinfo' docs/manpages/virsh.rst | 23 ++++++++++++++++---- src/libvirt-host.c | 21 ++++++++++-------- src/util/virhostcpu.c | 47 +++++++++++++++++------------------------ 3 files changed, 50 insertions(+), 41 deletions(-) -- 2.49.0

2 7

[PATCH] bhyve: support interface type 'network'
by Roman Bogorodskiy 09 Apr '25

09 Apr '25

Add support for interface type 'network'. While bridge remains the only supported options for networks in bhyve, supporting interface type 'network' allows easier configuration and makes domain XMLs more compatible with the other drivers. While here, update the error message for the unsupported interface type to print the requested network type string instead of an integer to make it more user-friendly. Signed-off-by: Roman Bogorodskiy <bogorodskiy(a)gmail.com> --- src/bhyve/bhyve_command.c | 44 ++++++++++++++++++++++++++++++++++----- src/bhyve/bhyve_process.c | 30 +++++++++++++++++++------- 2 files changed, 62 insertions(+), 12 deletions(-) diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index bc287307c8..123d81699f 100644 --- a/src/bhyve/bhyve_command.c +++ b/src/bhyve/bhyve_command.c @@ -2,6 +2,7 @@ * bhyve_command.c: bhyve command generation * * Copyright (C) 2014 Roman Bogorodskiy + * Copyright (C) 2025 The FreeBSD Foundation * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -26,6 +27,7 @@ #include "bhyve_domain.h" #include "bhyve_conf.h" #include "bhyve_driver.h" +#include "domain_validate.h" #include "datatypes.h" #include "viralloc.h" #include "virfile.h" @@ -40,7 +42,7 @@ VIR_LOG_INIT("bhyve.bhyve_command"); static int -bhyveBuildNetArgStr(const virDomainDef *def, +bhyveBuildNetArgStr(virDomainDef *def, virDomainNetDef *net, struct _bhyveConn *driver, virCommand *cmd, @@ -52,6 +54,7 @@ bhyveBuildNetArgStr(const virDomainDef *def, char *nic_model = NULL; int ret = -1; virDomainNetType actualType = virDomainNetGetActualType(net); + g_autoptr(virConnect) netconn = NULL; if (net->model == VIR_DOMAIN_NET_MODEL_VIRTIO) { nic_model = g_strdup("virtio-net"); @@ -69,12 +72,43 @@ bhyveBuildNetArgStr(const virDomainDef *def, return -1; } - if (actualType == VIR_DOMAIN_NET_TYPE_BRIDGE) { + if (net->type == VIR_DOMAIN_NET_TYPE_NETWORK) { + if (!netconn && !(netconn = virGetConnectNetwork())) + goto cleanup; + if (virDomainNetAllocateActualDevice(netconn, def, net) < 0) + goto cleanup; + } + /* final validation now that actual type is known */ + if (virDomainActualNetDefValidate(net) < 0) + return -1; + + switch (actualType) { + case VIR_DOMAIN_NET_TYPE_NETWORK: + case VIR_DOMAIN_NET_TYPE_BRIDGE: brname = g_strdup(virDomainNetGetActualBridgeName(net)); - } else { + if (!brname) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("No bridge name specified")); + goto cleanup; + } + break; + case VIR_DOMAIN_NET_TYPE_ETHERNET: + case VIR_DOMAIN_NET_TYPE_DIRECT: + case VIR_DOMAIN_NET_TYPE_USER: + case VIR_DOMAIN_NET_TYPE_VHOSTUSER: + case VIR_DOMAIN_NET_TYPE_SERVER: + case VIR_DOMAIN_NET_TYPE_CLIENT: + case VIR_DOMAIN_NET_TYPE_MCAST: + case VIR_DOMAIN_NET_TYPE_UDP: + case VIR_DOMAIN_NET_TYPE_INTERNAL: + case VIR_DOMAIN_NET_TYPE_HOSTDEV: + case VIR_DOMAIN_NET_TYPE_VDPA: + case VIR_DOMAIN_NET_TYPE_NULL: + case VIR_DOMAIN_NET_TYPE_VDS: + case VIR_DOMAIN_NET_TYPE_LAST: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("Network type %1$d is not supported"), - virDomainNetGetActualType(net)); + _("Unsupported network type %1$s"), + virDomainNetTypeToString(actualType)); goto cleanup; } diff --git a/src/bhyve/bhyve_process.c b/src/bhyve/bhyve_process.c index 3e6f678cf5..a17994e2a0 100644 --- a/src/bhyve/bhyve_process.c +++ b/src/bhyve/bhyve_process.c @@ -2,6 +2,7 @@ * bhyve_process.c: bhyve process management * * Copyright (C) 2014 Roman Bogorodskiy + * Copyright (C) 2025 The FreeBSD Foundation * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -71,18 +72,23 @@ static void bhyveNetCleanup(virDomainObj *vm) { size_t i; + g_autoptr(virConnect) conn = NULL; for (i = 0; i < vm->def->nnets; i++) { virDomainNetDef *net = vm->def->nets[i]; virDomainNetType actualType = virDomainNetGetActualType(net); - if (actualType == VIR_DOMAIN_NET_TYPE_BRIDGE) { - if (net->ifname) { - ignore_value(virNetDevBridgeRemovePort( - virDomainNetGetActualBridgeName(net), - net->ifname)); - ignore_value(virNetDevTapDelete(net->ifname, NULL)); - } + if (net->ifname) { + ignore_value(virNetDevBridgeRemovePort( + virDomainNetGetActualBridgeName(net), + net->ifname)); + ignore_value(virNetDevTapDelete(net->ifname, NULL)); + } + if (actualType == VIR_DOMAIN_NET_TYPE_NETWORK) { + if (conn || (conn = virGetConnectNetwork())) + virDomainNetReleaseActualDevice(conn, net); + else + VIR_WARN("Unable to release network device '%s'", NULLSTR(net->ifname)); } } } @@ -437,6 +443,8 @@ virBhyveProcessReconnect(virDomainObj *vm, char **proc_argv; char *expected_proctitle = NULL; bhyveDomainObjPrivate *priv = vm->privateData; + g_autoptr(virConnect) conn = NULL; + size_t i; int ret = -1; if (!virDomainObjIsActive(vm)) @@ -469,6 +477,14 @@ virBhyveProcessReconnect(virDomainObj *vm, } } + for (i = 0; i < vm->def->nnets; i++) { + virDomainNetDef *net = vm->def->nets[i]; + if (net->type == VIR_DOMAIN_NET_TYPE_NETWORK && !conn) + conn = virGetConnectNetwork(); + + virDomainNetNotifyActualDevice(conn, vm->def, net); + } + cleanup: if (ret < 0) { /* If VM is reported to be in active state, but we cannot find -- 2.49.0

2 1

[PATCH 0/3] bhyve: support random number generator device
by Roman Bogorodskiy 09 Apr '25

09 Apr '25

Roman Bogorodskiy (3): bhyve: support random number generator device bhyve: argv2xml: support virtio-rnd devices bhyve: extend RNG device validation src/bhyve/bhyve_capabilities.c | 15 ++++++++ src/bhyve/bhyve_capabilities.h | 2 + src/bhyve/bhyve_command.c | 23 ++++++++++++ src/bhyve/bhyve_device.c | 11 ++++++ src/bhyve/bhyve_domain.c | 21 +++++++++++ src/bhyve/bhyve_parse_command.c | 29 +++++++++++++++ .../bhyveargv2xml-virtio-rnd.args | 8 ++++ .../bhyveargv2xml-virtio-rnd.xml | 20 ++++++++++ tests/bhyveargv2xmltest.c | 1 + ...yvexml2argv-virtio-rnd-backend-builtin.xml | 26 +++++++++++++ ...io-rnd-backend-random-non-default-file.xml | 26 +++++++++++++ .../bhyvexml2argv-virtio-rnd-transitional.xml | 26 +++++++++++++ .../bhyvexml2argv-virtio-rnd.args | 11 ++++++ .../bhyvexml2argv-virtio-rnd.ldargs | 4 ++ .../bhyvexml2argv-virtio-rnd.xml | 26 +++++++++++++ tests/bhyvexml2argvtest.c | 6 +++ .../bhyvexml2xmlout-virtio-rnd.xml | 37 +++++++++++++++++++ tests/bhyvexml2xmltest.c | 1 + 18 files changed, 293 insertions(+) create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-virtio-rnd.args create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-virtio-rnd.xml create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-virtio-rnd-backend-builtin.xml create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-virtio-rnd-backend-random-non-default-file.xml create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-virtio-rnd-transitional.xml create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-virtio-rnd.args create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-virtio-rnd.ldargs create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-virtio-rnd.xml create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-virtio-rnd.xml -- 2.49.0

2 4

[PATCH] NEWS: Mention fix for 'qemu-rdp' error being logged
by Peter Krempa 09 Apr '25

09 Apr '25

From: Peter Krempa <pkrempa(a)redhat.com> Add the news entry stating that it's safe to ignore the error. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 2608086717..18b873abe9 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -34,6 +34,16 @@ v11.3.0 (unreleased) installed and thus every attempt to start an ARM domain with custom CPU definition would fail. + * Don't spam logs with with error about ``qemu-rdp`` when starting a qemu VM + + On hosts where the ``qemu-rdp`` binary is not installed a start of a VM + would cause an error such as :: + + error : qemuRdpNewForHelper:103 : 'qemu-rdp' is not a suitable qemu-rdp helper name: No such file or directory + + To be logged in the system log. It is safe to ignore the error. The code + was fixed to avoid the message when probing for support. + v11.2.0 (2025-04-01) ==================== -- 2.49.0

2 1

[PATCH] storage: virStorageVolDefParse and storageVolCreateXML flags fix
by Kirill Shchetiniuk 08 Apr '25

08 Apr '25

When the new storage was created using virsh with --validate option following errors occurred: # virsh vol-create default --file vol-def.xml --validate error: Failed to create vol from vol-def.xml error: unsupported flags (0x4) in function virStorageVolDefParseXML and after virStorageVolDefParse fix: # virsh vol-create default --file vol-def.xml --validate error: Failed to create vol from vol-def.xml error: unsupported flags (0x4) in function storageBackendCreateQemuImg Clear the VIR_STORAGE_VOL_CREATE_VALIDATE flag before virStorageVolDefParseXML and backend->buildVol (traces down to storageBackendCreateQemuImg) calls, as the XML schema validation is already complete within previous steps and there is no validation later. Signed-off-by: Kirill Shchetiniuk <kshcheti(a)redhat.com> --- NEWS.rst | 5 +++++ src/conf/storage_conf.c | 2 ++ src/storage/storage_driver.c | 4 +++- 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS.rst b/NEWS.rst index e2dc4e508b..dd345bad7b 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -28,6 +28,11 @@ v11.3.0 (unreleased) * **Bug fixes** + * storage: Fix new volume creation + + No more errors occur when new storage volume is being created + using ``vol-create`` with ``--validate`` option. + v11.2.0 (2025-04-01) ==================== diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 68842004b7..f6d804bb39 100644 --- a/src/conf/storage_conf.c +++ b/src/conf/storage_conf.c @@ -1409,6 +1409,8 @@ virStorageVolDefParse(virStoragePoolDef *pool, "volume", &ctxt, "storagevol.rng", validate))) return NULL; + flags &= ~(VIR_STORAGE_VOL_CREATE_VALIDATE); + return virStorageVolDefParseXML(pool, ctxt, flags); } diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 86c03762d2..2f5a26bbef 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -1877,6 +1877,7 @@ storageVolCreateXML(virStoragePoolPtr pool, virStorageVolPtr vol = NULL, newvol = NULL; g_autoptr(virStorageVolDef) voldef = NULL; unsigned int parseFlags = VIR_VOL_XML_PARSE_OPT_CAPACITY; + unsigned int buildFlags = flags; virCheckFlags(VIR_STORAGE_VOL_CREATE_PREALLOC_METADATA | VIR_STORAGE_VOL_CREATE_VALIDATE, NULL); @@ -1953,8 +1954,8 @@ storageVolCreateXML(virStoragePoolPtr pool, voldef->building = true; virObjectUnlock(obj); - buildret = backend->buildVol(obj, buildvoldef, flags); + buildFlags &= ~(VIR_STORAGE_VOL_CREATE_VALIDATE); + buildret = backend->buildVol(obj, buildvoldef, buildFlags); VIR_FREE(buildvoldef); -- 2.48.1

3 8

[PATCH 0/4] qemu: Remove legacy 'nbd-export-add' code and deprecate corresponding capabilities
by Peter Krempa 08 Apr '25

08 Apr '25

Peter Krempa (4): qemu: block: Always assume support for 'block-export-add' qemu: monitor: Drop wrappers for 'nbd-server-add' qemu: capabilities: Retire QEMU_CAPS_BLOCK_EXPORT_ADD qemu: capabilities: Retire QEMU_CAPS_NBD_BITMAP src/qemu/qemu_block.c | 7 ----- src/qemu/qemu_capabilities.c | 6 ++-- src/qemu/qemu_capabilities.h | 4 +-- src/qemu/qemu_monitor.c | 17 ----------- src/qemu/qemu_monitor.h | 5 ---- src/qemu/qemu_monitor_json.c | 28 ------------------- src/qemu/qemu_monitor_json.h | 6 ---- .../caps_10.0.0_s390x.xml | 2 -- .../caps_10.0.0_x86_64+amdsev.xml | 2 -- .../caps_10.0.0_x86_64.xml | 2 -- .../qemucapabilitiesdata/caps_6.2.0_ppc64.xml | 2 -- .../caps_6.2.0_x86_64.xml | 2 -- .../qemucapabilitiesdata/caps_7.0.0_ppc64.xml | 2 -- .../caps_7.0.0_x86_64.xml | 2 -- .../qemucapabilitiesdata/caps_7.1.0_ppc64.xml | 2 -- .../caps_7.1.0_x86_64.xml | 2 -- tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml | 2 -- .../caps_7.2.0_x86_64+hvf.xml | 2 -- .../caps_7.2.0_x86_64.xml | 2 -- .../caps_8.0.0_x86_64.xml | 2 -- .../qemucapabilitiesdata/caps_8.1.0_s390x.xml | 2 -- .../caps_8.1.0_x86_64.xml | 2 -- .../caps_8.2.0_aarch64.xml | 2 -- .../caps_8.2.0_armv7l.xml | 2 -- .../caps_8.2.0_loongarch64.xml | 2 -- .../qemucapabilitiesdata/caps_8.2.0_s390x.xml | 2 -- .../caps_8.2.0_x86_64.xml | 2 -- .../qemucapabilitiesdata/caps_9.0.0_sparc.xml | 2 -- .../caps_9.0.0_x86_64.xml | 2 -- .../caps_9.1.0_riscv64.xml | 2 -- .../qemucapabilitiesdata/caps_9.1.0_s390x.xml | 2 -- .../caps_9.1.0_x86_64.xml | 2 -- .../caps_9.2.0_aarch64+hvf.xml | 2 -- .../qemucapabilitiesdata/caps_9.2.0_s390x.xml | 2 -- .../caps_9.2.0_x86_64+amdsev.xml | 2 -- .../caps_9.2.0_x86_64.xml | 2 -- tests/qemumonitorjsontest.c | 2 -- 37 files changed, 4 insertions(+), 129 deletions(-) -- 2.49.0

2 5

[PATCH] docs: drvqemu: Fix required minimum qemu version to 6.2.0
by Peter Krempa 08 Apr '25

08 Apr '25

From: Peter Krempa <pkrempa(a)redhat.com> Commit 8824af826d3 (and also commit 073bf167843 before it) which bumped minimu, qemu version forgot to update the qemu driver documentation page Fixes: 8824af826d3 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- docs/drvqemu.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/drvqemu.rst b/docs/drvqemu.rst index e52d9ffd47..796aae587c 100644 --- a/docs/drvqemu.rst +++ b/docs/drvqemu.rst @@ -5,7 +5,7 @@ QEMU/KVM/HVF hypervisor driver ============================== -The libvirt KVM/QEMU driver can manage any QEMU emulator from version 4.2.0 or +The libvirt KVM/QEMU driver can manage any QEMU emulator from version 6.2.0 or later. It supports multiple QEMU accelerators: software -- 2.49.0

2 1

[PATCH v2 0/2] derpecate some block-job- APIs
by Vladimir Sementsov-Ogievskiy 08 Apr '25

08 Apr '25

v2: Update documentation: add patch 01 v1 was: [PATCH] [for-10.1] qapi/block-core: derpecate some block-job- APIs Supersedes: <20250401155730.103718-1-vsementsov(a)yandex-team.ru> Vladimir Sementsov-Ogievskiy (2): qapi: synchronize jobs and block-jobs documentation qapi/block-core: derpecate some block-job- APIs docs/about/deprecated.rst | 31 ++++++++++++++ qapi/block-core.json | 89 ++++++++++++++++++++++++++++----------- qapi/job.json | 29 ++++++++++++- 3 files changed, 122 insertions(+), 27 deletions(-) -- 2.48.1

3 7

[PATCH] qemu: rdp: Fix 'qemuRdpAvailable()'
by Peter Krempa 08 Apr '25

08 Apr '25

From: Peter Krempa <pkrempa(a)redhat.com> qemuRdpAvailable() is called from the capability filing code, thus: - it must not report spurious errors - it should not call any extra processes We can solve the above by just checking existance of 'qemu-rdp' in the path as: - at the time of adding of qemuRdpAvailable() there was only one 'qemu-rdp' release - it supported all the features - the check can't change as we'd drop the capability Add comments and gut the check to only check existance of the file. Fixes: f5e5a9bec9ec3e6c762f5000e3b8a0ba6a3a8c8d Closes: https://gitlab.com/libvirt/libvirt/-/issues/763 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_rdp.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_rdp.c b/src/qemu/qemu_rdp.c index 984795d599..0c48b87e7b 100644 --- a/src/qemu/qemu_rdp.c +++ b/src/qemu/qemu_rdp.c @@ -413,12 +413,25 @@ qemuRdpSetCredentials(virDomainObj *vm, } +/** + * qemuRdpAvailable: + * @helper: name (or path to) 'qemu-rdp' binary + * + * Returns whether 'qemu-rdp' is available. + * + * Important: + * This function is called from 'virQEMUDriverGetDomainCapabilities'. It must + * not report any errors and must not add any additional checks. + * + * This function is mocked from 'tests/testutilsqemu.c' + * + */ bool qemuRdpAvailable(const char *helper) { - g_autoptr(qemuRdp) rdp = NULL; - - rdp = qemuRdpNewForHelper(helper); + g_autofree char *helperPath = NULL; - return rdp && qemuRdpHasFeature(rdp, QEMU_RDP_FEATURE_DBUS_ADDRESS); + /* This function was added corresponding to the first release of 'qemu-rdp' + * thus checking existance of the helper binary is sufficient. */ + return !!(helperPath = virFindFileInPath(helper)); } -- 2.49.0

3 2

Re: [PATCH v8 55/55] docs: Add TDX documentation
by Daniel P. Berrangé 08 Apr '25

08 Apr '25

CC libvirt / Jiri, for confirmation about whether the CPUID restrictions listed below will have any possible impact on libvirt CPUID handling... On Tue, Apr 01, 2025 at 09:02:05AM -0400, Xiaoyao Li wrote: > Add docs/system/i386/tdx.rst for TDX support, and add tdx in > confidential-guest-support.rst > > Signed-off-by: Xiaoyao Li <xiaoyao.li(a)intel.com> > --- > Changes in v6: > - Add more information of "Feature configuration" > - Mark TD Attestation as future work because KVM now drops the support > of it. > > Changes in v5: > - Add TD attestation section and update the QEMU parameter; > > Changes since v1: > - Add prerequisite of private gmem; > - update example command to launch TD; > > Changes since RFC v4: > - add the restriction that kernel-irqchip must be split > --- > docs/system/confidential-guest-support.rst | 1 + > docs/system/i386/tdx.rst | 156 +++++++++++++++++++++ > docs/system/target-i386.rst | 1 + > 3 files changed, 158 insertions(+) > create mode 100644 docs/system/i386/tdx.rst > +Feature Configuration > +--------------------- > + > +Unlike non-TDX VM, the CPU features (enumerated by CPU or MSR) of a TD are not > +under full control of VMM. VMM can only configure part of features of a TD on > +``KVM_TDX_INIT_VM`` command of VM scope ``MEMORY_ENCRYPT_OP`` ioctl. > + > +The configurable features have three types: > + > +- Attributes: > + - PKS (bit 30) controls whether Supervisor Protection Keys is exposed to TD, > + which determines related CPUID bit and CR4 bit; > + - PERFMON (bit 63) controls whether PMU is exposed to TD. > + > +- XSAVE related features (XFAM): > + XFAM is a 64b mask, which has the same format as XCR0 or IA32_XSS MSR. It > + determines the set of extended features available for use by the guest TD. > + > +- CPUID features: > + Only some bits of some CPUID leaves are directly configurable by VMM. > + > +What features can be configured is reported via TDX capabilities. > + > +TDX capabilities > +~~~~~~~~~~~~~~~~ > + > +The VM scope ``MEMORY_ENCRYPT_OP`` ioctl provides command ``KVM_TDX_CAPABILITIES`` > +to get the TDX capabilities from KVM. It returns a data structure of > +``struct kvm_tdx_capabilities``, which tells the supported configuration of > +attributes, XFAM and CPUIDs. > + > +TD attributes > +~~~~~~~~~~~~~ > + > +QEMU supports configuring raw 64-bit TD attributes directly via "attributes" > +property of "tdx-guest" object. Note, it's users' responsibility to provide a > +valid value because some bits may not supported by current QEMU or KVM yet. > + > +QEMU also supports the configuration of individual attribute bits that are > +supported by it, via properties of "tdx-guest" object. > +E.g., "sept-ve-disable" (bit 28). > + > +MSR based features > +~~~~~~~~~~~~~~~~~~ > + > +Current KVM doesn't support MSR based feature (e.g., MSR_IA32_ARCH_CAPABILITIES) > +configuration for TDX, and it's a future work to enable it in QEMU when KVM adds > +support of it. > + > +Feature check > +~~~~~~~~~~~~~ > + > +QEMU checks if the final (CPU) features, determined by given cpu model and > +explicit feature adjustment of "+featureA/-featureB", can be supported or not. > +It can produce feature not supported warning like > + > + "warning: host doesn't support requested feature: CPUID.07H:EBX.intel-pt [bit 25]" > + > +It can also produce warning like > + > + "warning: TDX forcibly sets the feature: CPUID.80000007H:EDX.invtsc [bit 8]" > + > +if the fixed-1 feature is requested to be disabled explicitly. This is newly > +added to QEMU for TDX because TDX has fixed-1 features that are forcibly enabled > +by TDX module and VMM cannot disable them. This is where I'm wondering if libvirt has anything to be concerned about. Possibly when libvirt queries the actual CPUID after launching the guest it will just "do the right thing" ? Wondering if there's any need for libvirt to be aware of CPUID restrictions before that point though ? > + > +Launching a TD (TDX VM) > +----------------------- > + > +To launch a TD, the necessary command line options are tdx-guest object and > +split kernel-irqchip, as below: > + > +.. parsed-literal:: > + > + |qemu_system_x86| \\ > + -object tdx-guest,id=tdx0 \\ > + -machine ...,kernel-irqchip=split,confidential-guest-support=tdx0 \\ > + -bios OVMF.fd \\ I don't think we need to show 'kernel-irqchip=split' now that we "do the right thing" by default This surely also ought to include '-accel kvm', as IIUC there's no TCG support for TDX. And presumably '-cpu host', since QEMU's default 'qemu64' CPU model is likely a terrible match for what TDX will force set. > + > +Restrictions > +------------ > + > + - kernel-irqchip must be split; Can append "This is set by default for TDX guests if kernel-irqchip is left on its default 'auto' setting." > + > + - No readonly support for private memory; > + > + - No SMM support: SMM support requires manipulating the guest register states > + which is not allowed; > + With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|

3 2

[PATCH v3 00/20] Add qemu RDP server support
by marcandre.lureau＠redhat.com 07 Apr '25

07 Apr '25

From: Marc-André Lureau <marcandre.lureau(a)redhat.com> Hi, This patch series offers an out-of-process Remote Desktop Protocol (RDP) server solution utilizing QEMU's -display dbus interface, offering improved modularity and potential security benefits compared to built-in server. This initiative was spearheaded by Mihnea Buzatu during the QEMU Summer of Code 2023. The project's goal was to develop an out-of-process RDP server using the -display dbus interface, implemented in Rust. Given that the IronRDP crate lacked some server support at the time, investments in IronRDP were required. I finally released an initial v0.1 version of qemu-rdp on crates.io (https://crates.io/crates/qemu-rdp) That should allow more people to review and evaluate the state of this work. On unix systems, with cargo/rust toolchain installed, it should be as easy as running "cargo install qemu-rdp", apply this patch series for libvirt, set the "rdp_tls_x509_cert_dir" location for your TLS certificates, and configure a VM with both dbus & rdp graphics (run "virsh domdisplay DOMAIN" to get the display connection details). Thanks for the reviews & feedback! v3: thanks to Martin Kletzander review - drop "[PATCH v2 05/21] qemu: fall-through for unsupported graphics" patch - drop extra \n when reporting dbus-daemon log - check password != NULL or VIR_ERR_INTERNAL_ERROR - remove some needless #include/leftover - remove some needless g_auto pointer - rebased - add r-b tags v2: thanks to Daniel review - drop extra error report from "qemu: report an error for unsupported graphics" - replace g_return pre-conditions with ATTRIBUTE_NONNULL - improve "qemu/dbus: keep a connection to the VM D-Bus" to also reconnect - use domainLogContext for logging (for virtiofs as well) - check for qemu-rdp availabilty for setting 'rdp' capability - make dbus-addr qemu-rdp capability mandatory - rebased - add r-b tags Marc-André Lureau (20): build-sys: drop -Winline when optimization=g build: fix -Werror=maybe-uninitialized qemu-slirp: drop unneeded check for OOM util: annotate non-null arguments for virGDBusCallMethod() qemu: add rdp state directory qemu: add qemu RDP configuration conf: parse optional RDP username & password conf: generalize virDomainDefHasSpiceGraphics qemu: use virDomainDefHasGraphics qemu: add RDP ports range allocator qemu: limit to one <graphics type='rdp'> qemu/virtiofs: use domainLogContext qemu/dbus: keep a connection to the VM D-Bus qemu/dbus: log daemon stdout/err, use domainLogContext qemu: validate RDP configuration qemu: add qemu-rdp helper unit qemu: pass virQEMUDriverConfig to capabilities qemu: add 'rdp' capability if qemu-rdp is available qemu: add RDP support tests: add qemu <graphics type='rdp'/> test docs/formatdomain.rst | 25 +- meson.build | 7 +- po/POTFILES | 1 + src/conf/domain_conf.c | 28 +- src/conf/domain_conf.h | 5 +- src/conf/schemas/domaincommon.rng | 10 + src/libvirt_private.syms | 2 +- src/qemu/libvirtd_qemu.aug | 7 + src/qemu/meson.build | 1 + src/qemu/qemu.conf.in | 31 ++ src/qemu/qemu_capabilities.c | 24 +- src/qemu/qemu_capabilities.h | 12 +- src/qemu/qemu_command.c | 8 +- src/qemu/qemu_conf.c | 56 ++- src/qemu/qemu_conf.h | 13 + src/qemu/qemu_dbus.c | 69 ++- src/qemu/qemu_dbus.h | 3 + src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domain.h | 4 + src/qemu/qemu_driver.c | 20 + src/qemu/qemu_extdevice.c | 46 +- src/qemu/qemu_hotplug.c | 51 ++- src/qemu/qemu_hotplug.h | 1 + src/qemu/qemu_process.c | 169 ++++++- src/qemu/qemu_rdp.c | 424 ++++++++++++++++++ src/qemu/qemu_rdp.h | 73 +++ src/qemu/qemu_slirp.c | 6 - src/qemu/qemu_validate.c | 48 +- src/qemu/qemu_virtiofs.c | 53 +-- src/qemu/test_libvirtd_qemu.aug.in | 5 + src/util/virgdbus.h | 13 +- .../qemu_10.0.0-q35.x86_64+amdsev.xml | 1 + .../domaincapsdata/qemu_10.0.0-q35.x86_64.xml | 1 + .../qemu_10.0.0-tcg.x86_64+amdsev.xml | 1 + .../domaincapsdata/qemu_10.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_10.0.0.s390x.xml | 1 + .../qemu_10.0.0.x86_64+amdsev.xml | 1 + tests/domaincapsdata/qemu_10.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_7.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_7.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_7.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_7.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_7.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_7.1.0.x86_64.xml | 1 + .../qemu_7.2.0-hvf.x86_64+hvf.xml | 1 + .../domaincapsdata/qemu_7.2.0-q35.x86_64.xml | 1 + .../qemu_7.2.0-tcg.x86_64+hvf.xml | 1 + .../domaincapsdata/qemu_7.2.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_7.2.0.ppc.xml | 1 + tests/domaincapsdata/qemu_7.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_8.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_8.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_8.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_8.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_8.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_8.1.0.s390x.xml | 1 + tests/domaincapsdata/qemu_8.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_8.2.0-q35.x86_64.xml | 1 + .../qemu_8.2.0-tcg-virt.loongarch64.xml | 1 + .../domaincapsdata/qemu_8.2.0-tcg.x86_64.xml | 1 + .../qemu_8.2.0-virt.aarch64.xml | 1 + .../qemu_8.2.0-virt.loongarch64.xml | 1 + tests/domaincapsdata/qemu_8.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_8.2.0.armv7l.xml | 1 + tests/domaincapsdata/qemu_8.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_8.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_9.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_9.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_9.0.0.sparc.xml | 1 + tests/domaincapsdata/qemu_9.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_9.1.0-q35.x86_64.xml | 1 + .../qemu_9.1.0-tcg-virt.riscv64.xml | 1 + .../domaincapsdata/qemu_9.1.0-tcg.x86_64.xml | 1 + .../qemu_9.1.0-virt.riscv64.xml | 1 + tests/domaincapsdata/qemu_9.1.0.s390x.xml | 1 + tests/domaincapsdata/qemu_9.1.0.x86_64.xml | 1 + .../qemu_9.2.0-hvf.aarch64+hvf.xml | 1 + .../qemu_9.2.0-q35.x86_64+amdsev.xml | 1 + .../domaincapsdata/qemu_9.2.0-q35.x86_64.xml | 1 + .../qemu_9.2.0-tcg.x86_64+amdsev.xml | 1 + .../domaincapsdata/qemu_9.2.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_9.2.0.s390x.xml | 1 + .../qemu_9.2.0.x86_64+amdsev.xml | 1 + tests/domaincapsdata/qemu_9.2.0.x86_64.xml | 1 + tests/domaincapstest.c | 7 +- .../graphics-rdp.x86_64-latest.args | 35 ++ .../graphics-rdp.x86_64-latest.xml | 1 + tests/qemuxmlconfdata/graphics-rdp.xml | 43 ++ tests/qemuxmlconftest.c | 2 + tests/testutilsqemu.c | 10 + tools/nss/libvirt_nss_leases.c | 2 +- tools/nss/libvirt_nss_macs.c | 2 +- 92 files changed, 1234 insertions(+), 137 deletions(-) create mode 100644 src/qemu/qemu_rdp.c create mode 100644 src/qemu/qemu_rdp.h create mode 100644 tests/qemuxmlconfdata/graphics-rdp.x86_64-latest.args create mode 120000 tests/qemuxmlconfdata/graphics-rdp.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/graphics-rdp.xml -- 2.47.0

5 26

[PATCH 0/3] cpu_map: Install Ampere-1 ARM CPU models
by Jiri Denemark 07 Apr '25

07 Apr '25

BTW, the added test will not actually detect similar issues in the future (I'm thinking about such test, though), but it will help with other issues with the ARM CPU map as it hasn't been covered at all. Jiri Denemark (3): tests: Add a basic CPU test for aarch64 cpu_map: Install Ampere-1 ARM CPU models NEWS: Document ARM CPU map bug fix NEWS.rst | 6 +++++ src/cpu_map/meson.build | 2 ++ tests/cputest.c | 35 +++++++++++++++++++++++++++++ tests/cputestdata/aarch64-guest.xml | 4 ++++ 4 files changed, 47 insertions(+) create mode 100644 tests/cputestdata/aarch64-guest.xml -- 2.49.0

4 6

[PATCH v1 00/18] LIBVIRT: X86: TDX support
by Zhenzhong Duan 07 Apr '25

07 Apr '25

Hi, This series brings libvirt the x86 TDX support. * What's TDX? TDX stands for Trust Domain Extensions which isolates VMs from the virtual-machine manager (VMM)/hypervisor and any other software on the platform. This patchset extends libvirt to support TDX, with which one can start a TDX guest from high level rather than running qemu directly. * Misc As QEMU use a software emulated way to reset guest which isn't supported by TDX guest for security reason. We simulate reboot for TDX guest by kill and create a new one in FakeReboot framework. Complete code can be found at [1], matching qemu code can be found at [2]. There is a 'QGS' element for attestation which isn't in matching qemu[2] yet. I keep them intentionally as they will be implemented in qemu as extention series of [2]. * Test start/stop/reboot/reset with virsh stop/reboot trigger in guest stop with on_poweroff=destroy/restart reboot with on_reboot=destroy/restart * Patch organization - patch 1-4: Support query of TDX capabilities - patch 5-11: Add TDX type to launchsecurity framework - patch 12-17: Add reboot/reset support to TDX guest - patch 18: Add docs TODO: - add reconnect logic in virsh command [1] https://github.com/intel/libvirt-tdx/commits/tdx_for_upstream_v1 [2] https://github.com/intel-staging/qemu-tdx/tree/tdx-qemu-upstream-v8 Thanks Zhenzhong Changelog: v1: - s/virQEMUCapsKVMSupportsSecureGuestINTEL/virQEMUCapsKVMSupportsSecureGuestTDX (Daniel) - make policy element optional and expose to QEMU directly (Daniel) - s/qemuProcessSecFakeReboot/qemuProcessFakeRebootViaRecreate (Daniel) - simplify QGS element schema by supporting only UNIX socket (Daniel) - add new events VIR_DOMAIN_EVENT_[STOPPED|STARTED] for control plane (Daniel) - s/quoteGenerationService/quoteGenerationSocket as QEMU - add virsh reset support rfcv4: - add a check to tools/virt-host-validate-qemu.c (Daniel) - remove check of q35 (Daniel) - model 'SocktetAddress' QAPI in xml schema (Daniel) - s/Quote-Generation-Service/quoteGenerationService/ (Daniel) - define bits in tdx->policy and add validating logic (Daniel) - presume QEMU choose split kernel irqchip for TDX guest by default (Daniel) - utilize existing FakeReboot framework to do reboot for TDX guest (Daniel) - drop patch11 'conf: Add support to keep same domid for hard reboot' (Daniel) - add test in tests/ to validate parsing and formatting logic (Daniel) - add doc in docs/formatdomain.rst (Daniel) - add R-B rfcv3: - Change to generate qemu cmdline with -bios - drop firmware auto match as -bios is used - add a hard reboot method to reboot TDX guest rfcv3: https://www.mail-archive.com/devel@lists.libvirt.org/msg00385.html rfcv2: - give up using qmp cmd and check TDX directly on host for TDX capabilities. - use launchsecurity framework to support TDX - use <os>.<loader> for general loader - add auto firmware match feature for TDX A example TDVF fimware description file 70-edk2-x86_64-tdx.json: { "description": "UEFI firmware for x86_64, supporting Intel TDX", "interface-types": [ "uefi" ], "mapping": { "device": "generic", "filename": "/usr/share/OVMF/OVMF_CODE-tdx.fd" }, "targets": [ { "architecture": "x86_64", "machines": [ "pc-q35-*" ] } ], "features": [ "intel-tdx", "verbose-dynamic" ], "tags": [ ] } rfcv2: https://www.mail-archive.com/libvir-list@redhat.com/msg219378.html Zhenzhong Duan (18): tools: Secure guest check for Intel in virt-host-validate qemu: Check if INTEL Trust Domain Extention support is enabled qemu: Add TDX capability conf: Expose TDX feature in domain capabilities conf: Add tdx as launch security type conf: Validate TDX launchSecurity element mrConfigId/mrOwner/mrOwnerConfig qemu: Add command line and validation for TDX type conf: Expose TDX type in domain launch security capability qemu: Force special parameters enabled for TDX guest conf: Add Intel TDX Quote Generation Service(QGS) support qemu: Add command line for TDX Quote Generation Service(QGS) qemu: Add FakeReboot support for TDX guest qemu: Support reboot command in guest qemu: Avoid duplicate FakeReboot for secure guest qemu: Send event VIR_DOMAIN_EVENT_[STOPPED|STARTED] during recreation qemu: Bypass sending VIR_DOMAIN_EVENT_RESUMED event when TD VM reboot qemu: Support domain reset command for TDX guest docs: domain: Add documentation for Intel TDX guest docs/formatdomain.rst | 63 ++++++++++++++++++ docs/formatdomaincaps.rst | 1 + examples/c/misc/event-test.c | 6 ++ include/libvirt/libvirt-domain.h | 2 + src/conf/domain_capabilities.c | 1 + src/conf/domain_capabilities.h | 1 + src/conf/domain_conf.c | 82 +++++++++++++++++++++++ src/conf/domain_conf.h | 21 ++++++ src/conf/domain_validate.c | 11 ++++ src/conf/schemas/domaincaps.rng | 9 +++ src/conf/schemas/domaincommon.rng | 41 ++++++++++++ src/conf/virconftypes.h | 2 + src/qemu/qemu_capabilities.c | 38 ++++++++++- src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_cgroup.c | 1 + src/qemu/qemu_command.c | 54 +++++++++++++++ src/qemu/qemu_driver.c | 7 ++ src/qemu/qemu_firmware.c | 1 + src/qemu/qemu_monitor.c | 28 +++++++- src/qemu/qemu_monitor.h | 2 +- src/qemu/qemu_monitor_json.c | 6 +- src/qemu/qemu_namespace.c | 1 + src/qemu/qemu_process.c | 105 ++++++++++++++++++++++++++++-- src/qemu/qemu_process.h | 2 + src/qemu/qemu_validate.c | 45 +++++++++++++ src/security/security_dac.c | 2 + tools/virsh-domain-event.c | 6 +- tools/virt-host-validate-common.c | 31 ++++++++- tools/virt-host-validate-common.h | 1 + 29 files changed, 558 insertions(+), 13 deletions(-) -- 2.34.1

3 20

[PATCH] [for-10.1] qapi/block-core: derpecate some block-job- APIs
by Vladimir Sementsov-Ogievskiy 05 Apr '25

05 Apr '25

For change, pause, resume, complete, dismiss and finalize actions corresponding job- and block-job commands are almost equal. The difference is in find_block_job_locked() vs find_job_locked() functions. What's different? 1. find_block_job_locked() do check, is found job a block-job. This OK when moving to more generic API, no needs to document this change. 2. find_block_job_locked() reports DeviceNotActive on failure, when find_job_locked() reports GenericError. So, lets document this difference in deprecated.txt. Still, for dismiss and finalize errors are not documented at all, so be silent in deprecated.txt as well. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov(a)yandex-team.ru> --- Hi all! That's a continuation of my "[RFC 00/15] block job API"[1], exactly, the simplest part of it - deprecating block-job-* commands which simply duplicate job-* ones. Note that the old series was started with trying to introduce job-change command as substitution to both block-job-change (which only can change mirror copy-mode parameter), and block-job-set-speed. It was rather complicated and controversial attempt, which latest implemenation was "[PATCH v3 0/7] introduce job-change qmp command"[2]. In [2] Kevin noted, that we'd better follow existing blockdev-reopen approach of changing options (i.e. specify all options) than introduce a new one. But, on the other hand, now I'm afraid, that rewriting in third tools simple call to (old good) block-job-set-speed into job-change(_all_options_ + changed speed) is too much work just for "having nice interface". And too much for the only two options we want to change. So, let's just start from something more obvious. Finally, we can simple keep block-job-set-speed and block-job-change as is, as they (unlike other block-job-* commands) are not duplicated by similar job-* commands. [1] https://patchew.org/QEMU/20240313150907.623462-1-vsementsov@yandex-team.ru/ [2] https://patchew.org/QEMU/20241002140616.561652-1-vsementsov@yandex-team.ru/ docs/about/deprecated.rst | 31 +++++++++++++++++++++++++++++++ qapi/block-core.json | 30 ++++++++++++++++++++++++++++++ 2 files changed, 61 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index e2b4f077d4..eed3356359 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -148,6 +148,37 @@ options are removed in favor of using explicit ``blockdev-create`` and ``blockdev-add`` calls. See :doc:`/interop/live-block-operations` for details. +``block-job-pause`` (since 10.1) +''''''''''''''''''''''''''''''' + +Use ``job-pause`` instead. The only difference is that ``job-pause`` +always reports GenericError on failure when ``block-job-pause`` reports +DeviceNotActive when block-job is not found. + +``block-job-resume`` (since 10.1) +'''''''''''''''''''''''''''''''' + +Use ``job-resume`` instead. The only difference is that ``job-resume`` +always reports GenericError on failure when ``block-job-resume`` reports +DeviceNotActive when block-job is not found. + +``block-job-complete`` (since 10.1) +'''''''''''''''''''''''''''''''''' + +Use ``job-complete`` instead. The only difference is that ``job-complete`` +always reports GenericError on failure when ``block-job-complete`` reports +DeviceNotActive when block-job is not found. + +``block-job-dismiss`` (since 10.1) +''''''''''''''''''''''''''''''''' + +Use ``job-dismiss`` instead. + +``block-job-finalize`` (since 10.1) +'''''''''''''''''''''''''''''''''' + +Use ``job-finalize`` instead. + ``query-migrationthreads`` (since 9.2) '''''''''''''''''''''''''''''''''''''' diff --git a/qapi/block-core.json b/qapi/block-core.json index b1937780e1..264be8413b 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -2968,6 +2968,11 @@ # the name of the parameter), but since QEMU 2.7 it can have other # values. # +# Features: +# +# @deprecated: This command is deprecated. Use @job-pause +# instead. +# # Errors: # - If no background operation is active on this device, # DeviceNotActive @@ -2975,6 +2980,7 @@ # Since: 1.3 ## { 'command': 'block-job-pause', 'data': { 'device': 'str' }, + 'features': ['deprecated'], 'allow-preconfig': true } ## @@ -2992,6 +2998,11 @@ # the name of the parameter), but since QEMU 2.7 it can have other # values. # +# Features: +# +# @deprecated: This command is deprecated. Use @job-resume +# instead. +# # Errors: # - If no background operation is active on this device, # DeviceNotActive @@ -2999,6 +3010,7 @@ # Since: 1.3 ## { 'command': 'block-job-resume', 'data': { 'device': 'str' }, + 'features': ['deprecated'], 'allow-preconfig': true } ## @@ -3023,6 +3035,11 @@ # the name of the parameter), but since QEMU 2.7 it can have other # values. # +# Features: +# +# @deprecated: This command is deprecated. Use @job-complete +# instead. +# # Errors: # - If no background operation is active on this device, # DeviceNotActive @@ -3030,6 +3047,7 @@ # Since: 1.3 ## { 'command': 'block-job-complete', 'data': { 'device': 'str' }, + 'features': ['deprecated'], 'allow-preconfig': true } ## @@ -3047,9 +3065,15 @@ # # @id: The job identifier. # +# Features: +# +# @deprecated: This command is deprecated. Use @job-dismiss +# instead. +# # Since: 2.12 ## { 'command': 'block-job-dismiss', 'data': { 'id': 'str' }, + 'features': ['deprecated'], 'allow-preconfig': true } ## @@ -3064,9 +3088,15 @@ # # @id: The job identifier. # +# Features: +# +# @deprecated: This command is deprecated. Use @job-finalize +# instead. +# # Since: 2.12 ## { 'command': 'block-job-finalize', 'data': { 'id': 'str' }, + 'features': ['deprecated'], 'allow-preconfig': true } ## -- 2.48.1

3 6

[PATCH 0/8] Decrease stack size below 2048 bytes
by Michal Privoznik 04 Apr '25

04 Apr '25

Inspired by Roman's patch: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/FNAF… There are two functions where clang produces stack greater than 2048 bytes (our current limit - see @stack_frame_size in meson.build): 1) doRemoteOpen() 2) vboxSnapshotRedefine() It took me a while to realize why a function with a dozen variables requires ~2300 bytes of stack, until the usual suspect turned in - glib. Anyway, green pipeline: https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1752604895 and I've verified this compiles cleanly on my FreeBSD-14.1-RELEASE-p4 VM. Michal Prívozník (8): remote_driver: Move URI arg extraction into a separate function doRemoteOpen: Move RPC talk to a separate function doRemoteOpen: Drop needless typecast of @transport vbox: Move parts of vboxSnapshotRedefine() into a separate function vbox: Move parts of vboxSnapshotRedefine() into a separate function vbox: Move parts of vboxSnapshotRedefine() into a separate function vbox: Move parts of vboxSnapshotRedefine() into a separate function meson: Drop workaround for -Wframe-larger-than and clang meson.build | 5 - src/remote/remote_driver.c | 182 ++++--- src/vbox/vbox_common.c | 946 ++++++++++++++++++++----------------- 3 files changed, 636 insertions(+), 497 deletions(-) -- 2.49.0

3 10

[PATCH] build: clang stack frame size handling improvement
by Roman Bogorodskiy 04 Apr '25

04 Apr '25

The 'plain' optimization type also triggers the clang stack frame size issues, so increase limit for it as well. Signed-off-by: Roman Bogorodskiy <bogorodskiy(a)gmail.com> --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 56823ca25b..0a402a19a2 100644 --- a/meson.build +++ b/meson.build @@ -259,7 +259,7 @@ alloc_max = run_command( stack_frame_size = 2048 # clang without optimization enlarges stack frames in certain corner cases -if cc.get_id() == 'clang' and get_option('optimization') == '0' +if cc.get_id() == 'clang' and get_option('optimization') in ['plain', '0'] stack_frame_size = 4096 endif -- 2.49.0

3 7

[PATCH 0/2] docs: Improve ability to select proper API/XML section
by Peter Krempa 04 Apr '25

04 Apr '25

Browse the result at: https://pipo.sk.gitlab.io/-/libvirt/-/jobs/9603174377/artifacts/website/doc… (The security warning happens as my username on gitlab contains a dot.) Peter Krempa (2): docs: Re-order XML schema after API documentation on 'docs' page docs: Render API and XML sections one per line in HTML docs/css/libvirt.css | 11 +++++++ docs/docs.rst | 75 +++++++++++++++++++++++--------------------- 2 files changed, 51 insertions(+), 35 deletions(-) -- 2.49.0

2 4

[PATCH 0/3] ch: Misc fixes
by Michal Privoznik 04 Apr '25

04 Apr '25

*** BLURB HERE *** Michal Prívozník (3): ch: Use CH_DOMAIN_PRIVATE() more ch: Drop pid from monitor ch: Fix printf format strings wrt size_t argument src/ch/ch_events.c | 4 ++-- src/ch/ch_monitor.c | 14 ++++---------- src/ch/ch_monitor.h | 2 -- src/ch/ch_process.c | 11 +++++------ 4 files changed, 11 insertions(+), 20 deletions(-) -- 2.49.0

2 4

[PATCH] libxl_conf: Implement hyperv domain flags for Xen
by Will 04 Apr '25

04 Apr '25

Adds support for configuring <hyperv/> flags for domains running under Xen. The following flags, making use of QEMU's existing flags, are now configurable for Xen: vapic, synic, stimer, frequencies, tlbflush and ipi Tests have been added validating translation to libxl's viridian flags Updated docs section on <hyperv/> flags to note support and to specify which flags work with Xen Signed-off-by: Will <tcosprojects(a)gmail.com> --- NEWS.rst | 5 + docs/formatdomain.rst | 20 +-- src/libxl/libxl_conf.c | 90 ++++++++++ .../viridian-hvm-full.json | 101 ++++++++++++ .../viridian-hvm-full.xml | 45 +++++ .../viridian-hvm-none.json | 89 ++++++++++ .../viridian-hvm-none.xml | 36 ++++ .../libxlxml2domconfigdata/viridian-hvm.json | 99 +++++++++++ tests/libxlxml2domconfigdata/viridian-hvm.xml | 42 +++++ .../viridian-passthrough.json | 155 ++++++++++++++++++ .../viridian-passthrough.xml | 37 +++++ tests/libxlxml2domconfigtest.c | 9 + 12 files changed, 718 insertions(+), 10 deletions(-) create mode 100644 tests/libxlxml2domconfigdata/viridian-hvm-full.json create mode 100644 tests/libxlxml2domconfigdata/viridian-hvm-full.xml create mode 100644 tests/libxlxml2domconfigdata/viridian-hvm-none.json create mode 100644 tests/libxlxml2domconfigdata/viridian-hvm-none.xml create mode 100644 tests/libxlxml2domconfigdata/viridian-hvm.json create mode 100644 tests/libxlxml2domconfigdata/viridian-hvm.xml create mode 100644 tests/libxlxml2domconfigdata/viridian-passthrough.json create mode 100644 tests/libxlxml2domconfigdata/viridian-passthrough.xml diff --git a/NEWS.rst b/NEWS.rst index 9c940b1a81..d6ad961f56 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,11 @@ v11.2.0 (unreleased) * **New features** + * Support for configuration of ``<hyperv/>`` flags for Xen domains. + + The following flags are now configurable for Xen: ``vapic``, ``synic``, + ``stimer``, ``frequencies``, ``tlbflush`` and ``ipi``. + * **Improvements** * **Bug fixes** diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index cbe378e61d..4162ae7930 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -2084,31 +2084,31 @@ are: based virtualization drivers, such as LXC. ``hyperv`` Enable various features improving behavior of guests running Microsoft - Windows. + Windows. :since:`Since 11.2.0` some of these flags are also available for Xen domains running Microsoft Windows. =============== ====================================================================== ============================================ ======================================================================== Feature Description Value Since =============== ====================================================================== ============================================ ======================================================================== - relaxed Relax constraints on timers on, off :since:`1.0.0 (QEMU 2.0)` - vapic Enable virtual APIC on, off :since:`1.1.0 (QEMU 2.0)` + relaxed Relax constraints on timers on, off :since:`1.0.0 (QEMU 2.0), 11.2.0 (Xen, always on)` + vapic Enable virtual APIC on, off :since:`1.1.0 (QEMU 2.0), 11.2.0 (Xen)` spinlocks Enable spinlock support on, off; retries - at least 4095 :since:`1.1.0 (QEMU 2.0)` - vpindex Virtual processor index on, off :since:`1.3.3 (QEMU 2.5)` + vpindex Virtual processor index on, off :since:`1.3.3 (QEMU 2.5), 11.2.0 (Xen, always on)` runtime Processor time spent on running guest code and on behalf of guest code on, off :since:`1.3.3 (QEMU 2.5)` - synic Enable Synthetic Interrupt Controller (SynIC) on, off :since:`1.3.3 (QEMU 2.6)` - stimer Enable SynIC timers, optionally with Direct Mode support on, off; direct - on,off :since:`1.3.3 (QEMU 2.6), direct mode 5.7.0 (QEMU 4.1)` + synic Enable Synthetic Interrupt Controller (SynIC) on, off :since:`1.3.3 (QEMU 2.6), 11.2.0 (Xen)` + stimer Enable SynIC timers, optionally with Direct Mode support on, off; direct - on,off :since:`1.3.3 (QEMU 2.6), direct mode 5.7.0 (QEMU 4.1), 11.2.0 (Xen, on/off only)` reset Enable hypervisor reset on, off :since:`1.3.3 (QEMU 2.5)` vendor_id Set hypervisor vendor id on, off; value - string, up to 12 characters :since:`1.3.3 (QEMU 2.5)` - frequencies Expose frequency MSRs on, off :since:`4.7.0 (QEMU 2.12)` + frequencies Expose frequency MSRs on, off :since:`4.7.0 (QEMU 2.12), 11.2.0 (Xen)` reenlightenment Enable re-enlightenment notification on migration on, off :since:`4.7.0 (QEMU 3.0)` - tlbflush Enable PV TLB flush support on, off; direct - on,off; extended - on,off :since:`4.7.0 (QEMU 3.0), direct and extended modes 11.0.0 (QEMU 7.1.0)` - ipi Enable PV IPI support on, off :since:`4.10.0 (QEMU 3.1)` + tlbflush Enable PV TLB flush support on, off; direct - on,off; extended - on,off :since:`4.7.0 (QEMU 3.0), direct and extended modes 11.0.0 (QEMU 7.1.0), 11.2.0 (Xen, on/off only)` + ipi Enable PV IPI support on, off :since:`4.10.0 (QEMU 3.1), 11.2.0 (Xen)` evmcs Enable Enlightened VMCS on, off :since:`4.10.0 (QEMU 3.1)` avic Enable use Hyper-V SynIC with hardware APICv/AVIC on, off :since:`8.10.0 (QEMU 6.2)` emsr_bitmap Avoid unnecessary updates to L2 MSR Bitmap upon vmexits. on, off :since:`10.7.0 (QEMU 7.1)` xmm_input Enable XMM Fast Hypercall Input on, off :since:`10.7.0 (QEMU 7.1)` =============== ====================================================================== ============================================ ======================================================================== - :since:`Since 8.0.0`, the hypervisor can be configured further by setting + :since:`Since 8.0.0 (QEMU) Since 11.2.0 (Xen)`, the hypervisor can be configured further by setting the ``mode`` attribute to one of the following values: ``custom`` diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index c404226e43..d79cf93573 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -582,6 +582,96 @@ libxlMakeDomBuildInfo(virDomainDef *def, VIR_TRISTATE_SWITCH_ON); #endif +#ifdef LIBXL_HAVE_BUILDINFO_HVM_VIRIDIAN_ENABLE_DISABLE + if (def->features[VIR_DOMAIN_FEATURE_HYPERV] != VIR_DOMAIN_HYPERV_MODE_NONE) { + libxl_bitmap_alloc(ctx, &b_info->u.hvm.viridian_enable, + LIBXL_BUILDINFO_HVM_VIRIDIAN_ENABLE_DISABLE_WIDTH); + + switch ((virDomainHyperVMode) def->features[VIR_DOMAIN_FEATURE_HYPERV]) { + case VIR_DOMAIN_HYPERV_MODE_CUSTOM: + // Base is required by Xen to enable any other flag + libxl_bitmap_set(&b_info->u.hvm.viridian_enable, LIBXL_VIRIDIAN_ENLIGHTENMENT_BASE); + // Enable crash ctl register by default to allow guest logs to reach Xen + libxl_bitmap_set(&b_info->u.hvm.viridian_enable, LIBXL_VIRIDIAN_ENLIGHTENMENT_CRASH_CTL); + break; + case VIR_DOMAIN_HYPERV_MODE_PASSTHROUGH: + libxl_bitmap_set_any(&b_info->u.hvm.viridian_enable); + break; + case VIR_DOMAIN_HYPERV_MODE_NONE: + case VIR_DOMAIN_HYPERV_MODE_LAST: + default: + virReportEnumRangeError(virDomainHyperVMode, + def->features[VIR_DOMAIN_FEATURE_HYPERV]); + return -1; + } + + for (i = 0; i < VIR_DOMAIN_HYPERV_LAST; i++) { + switch ((virDomainHyperv) i) { + case VIR_DOMAIN_HYPERV_VPINDEX: + case VIR_DOMAIN_HYPERV_RELAXED: + // Already set by base flag + break; + case VIR_DOMAIN_HYPERV_SYNIC: + if (def->hyperv_features[i] == VIR_TRISTATE_SWITCH_ON) { + libxl_bitmap_set(&b_info->u.hvm.viridian_enable, LIBXL_VIRIDIAN_ENLIGHTENMENT_SYNIC); + } + break; + case VIR_DOMAIN_HYPERV_STIMER: + if (def->hyperv_features[i] == VIR_TRISTATE_SWITCH_ON) { + // STIMER implies synic and clock features + libxl_bitmap_set(&b_info->u.hvm.viridian_enable, LIBXL_VIRIDIAN_ENLIGHTENMENT_STIMER); + libxl_bitmap_set(&b_info->u.hvm.viridian_enable, LIBXL_VIRIDIAN_ENLIGHTENMENT_SYNIC); + libxl_bitmap_set(&b_info->u.hvm.viridian_enable, LIBXL_VIRIDIAN_ENLIGHTENMENT_TIME_REF_COUNT); + libxl_bitmap_set(&b_info->u.hvm.viridian_enable, LIBXL_VIRIDIAN_ENLIGHTENMENT_REFERENCE_TSC); + } + break; + case VIR_DOMAIN_HYPERV_VAPIC: + if (def->hyperv_features[i] == VIR_TRISTATE_SWITCH_ON) { + libxl_bitmap_set(&b_info->u.hvm.viridian_enable, LIBXL_VIRIDIAN_ENLIGHTENMENT_APIC_ASSIST); + } + break; + case VIR_DOMAIN_HYPERV_FREQUENCIES: + if (def->hyperv_features[i] == VIR_TRISTATE_SWITCH_ON) { + libxl_bitmap_set(&b_info->u.hvm.viridian_enable, LIBXL_VIRIDIAN_ENLIGHTENMENT_FREQ); + } + break; + case VIR_DOMAIN_HYPERV_TLBFLUSH: + if (def->hyperv_features[i] == VIR_TRISTATE_SWITCH_ON) { + libxl_bitmap_set(&b_info->u.hvm.viridian_enable, LIBXL_VIRIDIAN_ENLIGHTENMENT_HCALL_REMOTE_TLB_FLUSH); + } + break; + case VIR_DOMAIN_HYPERV_IPI: + if (def->hyperv_features[i] == VIR_TRISTATE_SWITCH_ON) { + libxl_bitmap_set(&b_info->u.hvm.viridian_enable, LIBXL_VIRIDIAN_ENLIGHTENMENT_HCALL_IPI); + } + break; + case VIR_DOMAIN_HYPERV_SPINLOCKS: + case VIR_DOMAIN_HYPERV_VENDOR_ID: + if (def->hyperv_features[i] == VIR_TRISTATE_SWITCH_ON) { + const char *name = virDomainHypervTypeToString(i); + VIR_WARN("Hyper-v flag '%s' is specified per-domain but is a global Xen setting and will be ignored.", name); + } + break; + case VIR_DOMAIN_HYPERV_RUNTIME: + case VIR_DOMAIN_HYPERV_RESET: + case VIR_DOMAIN_HYPERV_REENLIGHTENMENT: + case VIR_DOMAIN_HYPERV_EVMCS: + case VIR_DOMAIN_HYPERV_AVIC: + case VIR_DOMAIN_HYPERV_EMSR_BITMAP: + case VIR_DOMAIN_HYPERV_XMM_INPUT: + if (def->hyperv_features[i] == VIR_TRISTATE_SWITCH_ON) { + const char *name = virDomainHypervTypeToString(i); + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Hyper-v enlightenment feature '%1$s' is not supported for Xen domains."), name); + } + break; + case VIR_DOMAIN_HYPERV_LAST: + break; + } + } + } +#endif + /* copy SLIC table path to acpi_firmware */ b_info->u.hvm.acpi_firmware = g_strdup(def->os.slic_table); diff --git a/tests/libxlxml2domconfigdata/viridian-hvm-full.json b/tests/libxlxml2domconfigdata/viridian-hvm-full.json new file mode 100644 index 0000000000..5cb69f7b5d --- /dev/null +++ b/tests/libxlxml2domconfigdata/viridian-hvm-full.json @@ -0,0 +1,101 @@ +{ + "c_info": { + "type": "hvm", + "name": "test-hvm", + "uuid": "2147d599-9cc6-c0dc-92ab-4064b5446e9b" + }, + "b_info": { + "max_vcpus": 4, + "avail_vcpus": [ + 0, + 1, + 2, + 3 + ], + "max_memkb": 1048576, + "target_memkb": 1048576, + "video_memkb": 8192, + "shadow_memkb": 1234, + "device_model_version": "qemu_xen", + "device_model": "/bin/true", + "sched_params": { + + }, + "apic": "True", + "acpi": "True", + "type.hvm": { + "pae": "True", + "viridian_enable": [ + 0, + 1, + 2, + 3, + 4, + 5, + 6, + 7, + 8, + 9 + ], + "vga": { + "kind": "cirrus" + }, + "vnc": { + "enable": "True", + "listen": "0.0.0.0", + "findunused": "False" + }, + "sdl": { + "enable": "False" + }, + "spice": { + + }, + "boot": "c", + "rdm": { + + } + }, + "arch_arm": { + + } + }, + "disks": [ + { + "pdev_path": "/var/lib/xen/images/test-hvm.img", + "vdev": "hda", + "backend": "qdisk", + "format": "raw", + "removable": 1, + "readwrite": 1 + } + ], + "nics": [ + { + "devid": 0, + "mac": "00:16:3e:66:12:b4", + "bridge": "br0", + "script": "/etc/xen/scripts/vif-bridge", + "nictype": "vif_ioemu" + } + ], + "vfbs": [ + { + "devid": -1, + "vnc": { + "enable": "True", + "listen": "0.0.0.0", + "findunused": "False" + }, + "sdl": { + "enable": "False" + } + } + ], + "vkbs": [ + { + "devid": -1 + } + ], + "on_reboot": "restart" +} diff --git a/tests/libxlxml2domconfigdata/viridian-hvm-full.xml b/tests/libxlxml2domconfigdata/viridian-hvm-full.xml new file mode 100644 index 0000000000..17f5ed5209 --- /dev/null +++ b/tests/libxlxml2domconfigdata/viridian-hvm-full.xml @@ -0,0 +1,45 @@ +<domain type='xen'> + <name>test-hvm</name> + <description>None</description> + <uuid>2147d599-9cc6-c0dc-92ab-4064b5446e9b</uuid> + <memory>1048576</memory> + <currentMemory>1048576</currentMemory> + <vcpu>4</vcpu> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <clock offset='utc'/> + <os> + <type>hvm</type> + <loader>/usr/lib/xen/boot/hvmloader</loader> + <boot dev='hd'/> + </os> + <features> + <apic/> + <acpi/> + <pae/> + <hyperv> + <vapic state='on'/> + <vpindex state='on'/> + <synic state='on'/> + <stimer state='on'/> + <frequencies state='on'/> + <tlbflush state='on'/> + <ipi state='on'/> + </hyperv> + </features> + <devices> + <emulator>/bin/true</emulator> + <disk type='file' device='disk'> + <driver name='qemu'/> + <source file='/var/lib/xen/images/test-hvm.img'/> + <target dev='hda'/> + </disk> + <interface type='bridge'> + <source bridge='br0'/> + <mac address='00:16:3e:66:12:b4'/> + <script path='/etc/xen/scripts/vif-bridge'/> + </interface> + <graphics type='vnc' port='-1' autoport='yes' listen='0.0.0.0'/> + </devices> +</domain> diff --git a/tests/libxlxml2domconfigdata/viridian-hvm-none.json b/tests/libxlxml2domconfigdata/viridian-hvm-none.json new file mode 100644 index 0000000000..d30875420d --- /dev/null +++ b/tests/libxlxml2domconfigdata/viridian-hvm-none.json @@ -0,0 +1,89 @@ +{ + "c_info": { + "type": "hvm", + "name": "test-hvm", + "uuid": "2147d599-9cc6-c0dc-92ab-4064b5446e9b" + }, + "b_info": { + "max_vcpus": 4, + "avail_vcpus": [ + 0, + 1, + 2, + 3 + ], + "max_memkb": 1048576, + "target_memkb": 1048576, + "video_memkb": 8192, + "shadow_memkb": 1234, + "device_model_version": "qemu_xen", + "device_model": "/bin/true", + "sched_params": { + + }, + "apic": "True", + "acpi": "True", + "type.hvm": { + "pae": "True", + "vga": { + "kind": "cirrus" + }, + "vnc": { + "enable": "True", + "listen": "0.0.0.0", + "findunused": "False" + }, + "sdl": { + "enable": "False" + }, + "spice": { + + }, + "boot": "c", + "rdm": { + + } + }, + "arch_arm": { + + } + }, + "disks": [ + { + "pdev_path": "/var/lib/xen/images/test-hvm.img", + "vdev": "hda", + "backend": "qdisk", + "format": "raw", + "removable": 1, + "readwrite": 1 + } + ], + "nics": [ + { + "devid": 0, + "mac": "00:16:3e:66:12:b4", + "bridge": "br0", + "script": "/etc/xen/scripts/vif-bridge", + "nictype": "vif_ioemu" + } + ], + "vfbs": [ + { + "devid": -1, + "vnc": { + "enable": "True", + "listen": "0.0.0.0", + "findunused": "False" + }, + "sdl": { + "enable": "False" + } + } + ], + "vkbs": [ + { + "devid": -1 + } + ], + "on_reboot": "restart" +} diff --git a/tests/libxlxml2domconfigdata/viridian-hvm-none.xml b/tests/libxlxml2domconfigdata/viridian-hvm-none.xml new file mode 100644 index 0000000000..68c2ef08af --- /dev/null +++ b/tests/libxlxml2domconfigdata/viridian-hvm-none.xml @@ -0,0 +1,36 @@ +<domain type='xen'> + <name>test-hvm</name> + <description>None</description> + <uuid>2147d599-9cc6-c0dc-92ab-4064b5446e9b</uuid> + <memory>1048576</memory> + <currentMemory>1048576</currentMemory> + <vcpu>4</vcpu> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <clock offset='utc'/> + <os> + <type>hvm</type> + <loader>/usr/lib/xen/boot/hvmloader</loader> + <boot dev='hd'/> + </os> + <features> + <apic/> + <acpi/> + <pae/> + </features> + <devices> + <emulator>/bin/true</emulator> + <disk type='file' device='disk'> + <driver name='qemu'/> + <source file='/var/lib/xen/images/test-hvm.img'/> + <target dev='hda'/> + </disk> + <interface type='bridge'> + <source bridge='br0'/> + <mac address='00:16:3e:66:12:b4'/> + <script path='/etc/xen/scripts/vif-bridge'/> + </interface> + <graphics type='vnc' port='-1' autoport='yes' listen='0.0.0.0'/> + </devices> +</domain> diff --git a/tests/libxlxml2domconfigdata/viridian-hvm.json b/tests/libxlxml2domconfigdata/viridian-hvm.json new file mode 100644 index 0000000000..4f9a52ed89 --- /dev/null +++ b/tests/libxlxml2domconfigdata/viridian-hvm.json @@ -0,0 +1,99 @@ +{ + "c_info": { + "type": "hvm", + "name": "test-hvm", + "uuid": "2147d599-9cc6-c0dc-92ab-4064b5446e9b" + }, + "b_info": { + "max_vcpus": 4, + "avail_vcpus": [ + 0, + 1, + 2, + 3 + ], + "max_memkb": 1048576, + "target_memkb": 1048576, + "video_memkb": 8192, + "shadow_memkb": 1234, + "device_model_version": "qemu_xen", + "device_model": "/bin/true", + "sched_params": { + + }, + "apic": "True", + "acpi": "True", + "type.hvm": { + "pae": "True", + "viridian_enable": [ + 0, + 2, + 3, + 4, + 6, + 7, + 8, + 9 + ], + "vga": { + "kind": "cirrus" + }, + "vnc": { + "enable": "True", + "listen": "0.0.0.0", + "findunused": "False" + }, + "sdl": { + "enable": "False" + }, + "spice": { + + }, + "boot": "c", + "rdm": { + + } + }, + "arch_arm": { + + } + }, + "disks": [ + { + "pdev_path": "/var/lib/xen/images/test-hvm.img", + "vdev": "hda", + "backend": "qdisk", + "format": "raw", + "removable": 1, + "readwrite": 1 + } + ], + "nics": [ + { + "devid": 0, + "mac": "00:16:3e:66:12:b4", + "bridge": "br0", + "script": "/etc/xen/scripts/vif-bridge", + "nictype": "vif_ioemu" + } + ], + "vfbs": [ + { + "devid": -1, + "vnc": { + "enable": "True", + "listen": "0.0.0.0", + "findunused": "False" + }, + "sdl": { + "enable": "False" + } + } + ], + "vkbs": [ + { + "devid": -1 + } + ], + "on_reboot": "restart" +} diff --git a/tests/libxlxml2domconfigdata/viridian-hvm.xml b/tests/libxlxml2domconfigdata/viridian-hvm.xml new file mode 100644 index 0000000000..c6139885aa --- /dev/null +++ b/tests/libxlxml2domconfigdata/viridian-hvm.xml @@ -0,0 +1,42 @@ +<domain type='xen'> + <name>test-hvm</name> + <description>None</description> + <uuid>2147d599-9cc6-c0dc-92ab-4064b5446e9b</uuid> + <memory>1048576</memory> + <currentMemory>1048576</currentMemory> + <vcpu>4</vcpu> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <clock offset='utc'/> + <os> + <type>hvm</type> + <loader>/usr/lib/xen/boot/hvmloader</loader> + <boot dev='hd'/> + </os> + <features> + <apic/> + <acpi/> + <pae/> + <hyperv mode="custom"> + <synic state='on'/> + <stimer state='on'/> + <tlbflush state='on'/> + <ipi state='on'/> + </hyperv> + </features> + <devices> + <emulator>/bin/true</emulator> + <disk type='file' device='disk'> + <driver name='qemu'/> + <source file='/var/lib/xen/images/test-hvm.img'/> + <target dev='hda'/> + </disk> + <interface type='bridge'> + <source bridge='br0'/> + <mac address='00:16:3e:66:12:b4'/> + <script path='/etc/xen/scripts/vif-bridge'/> + </interface> + <graphics type='vnc' port='-1' autoport='yes' listen='0.0.0.0'/> + </devices> +</domain> diff --git a/tests/libxlxml2domconfigdata/viridian-passthrough.json b/tests/libxlxml2domconfigdata/viridian-passthrough.json new file mode 100644 index 0000000000..66069931f6 --- /dev/null +++ b/tests/libxlxml2domconfigdata/viridian-passthrough.json @@ -0,0 +1,155 @@ +{ + "c_info": { + "type": "hvm", + "name": "test-hvm", + "uuid": "2147d599-9cc6-c0dc-92ab-4064b5446e9b" + }, + "b_info": { + "max_vcpus": 4, + "avail_vcpus": [ + 0, + 1, + 2, + 3 + ], + "max_memkb": 1048576, + "target_memkb": 1048576, + "video_memkb": 8192, + "shadow_memkb": 1234, + "device_model_version": "qemu_xen", + "device_model": "/bin/true", + "sched_params": { + + }, + "apic": "True", + "acpi": "True", + "type.hvm": { + "pae": "True", + "viridian_enable": [ + 0, + 1, + 2, + 3, + 4, + 5, + 6, + 7, + 8, + 9, + 10, + 11, + 12, + 13, + 14, + 15, + 16, + 17, + 18, + 19, + 20, + 21, + 22, + 23, + 24, + 25, + 26, + 27, + 28, + 29, + 30, + 31, + 32, + 33, + 34, + 35, + 36, + 37, + 38, + 39, + 40, + 41, + 42, + 43, + 44, + 45, + 46, + 47, + 48, + 49, + 50, + 51, + 52, + 53, + 54, + 55, + 56, + 57, + 58, + 59, + 60, + 61, + 62, + 63 + ], + "vga": { + "kind": "cirrus" + }, + "vnc": { + "enable": "True", + "listen": "0.0.0.0", + "findunused": "False" + }, + "sdl": { + "enable": "False" + }, + "spice": { + + }, + "boot": "c", + "rdm": { + + } + }, + "arch_arm": { + + } + }, + "disks": [ + { + "pdev_path": "/var/lib/xen/images/test-hvm.img", + "vdev": "hda", + "backend": "qdisk", + "format": "raw", + "removable": 1, + "readwrite": 1 + } + ], + "nics": [ + { + "devid": 0, + "mac": "00:16:3e:66:12:b4", + "bridge": "br0", + "script": "/etc/xen/scripts/vif-bridge", + "nictype": "vif_ioemu" + } + ], + "vfbs": [ + { + "devid": -1, + "vnc": { + "enable": "True", + "listen": "0.0.0.0", + "findunused": "False" + }, + "sdl": { + "enable": "False" + } + } + ], + "vkbs": [ + { + "devid": -1 + } + ], + "on_reboot": "restart" +} diff --git a/tests/libxlxml2domconfigdata/viridian-passthrough.xml b/tests/libxlxml2domconfigdata/viridian-passthrough.xml new file mode 100644 index 0000000000..6d6b7d22cd --- /dev/null +++ b/tests/libxlxml2domconfigdata/viridian-passthrough.xml @@ -0,0 +1,37 @@ +<domain type='xen'> + <name>test-hvm</name> + <description>None</description> + <uuid>2147d599-9cc6-c0dc-92ab-4064b5446e9b</uuid> + <memory>1048576</memory> + <currentMemory>1048576</currentMemory> + <vcpu>4</vcpu> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <clock offset='utc'/> + <os> + <type>hvm</type> + <loader>/usr/lib/xen/boot/hvmloader</loader> + <boot dev='hd'/> + </os> + <features> + <apic/> + <acpi/> + <pae/> + <hyperv mode="passthrough"/> + </features> + <devices> + <emulator>/bin/true</emulator> + <disk type='file' device='disk'> + <driver name='qemu'/> + <source file='/var/lib/xen/images/test-hvm.img'/> + <target dev='hda'/> + </disk> + <interface type='bridge'> + <source bridge='br0'/> + <mac address='00:16:3e:66:12:b4'/> + <script path='/etc/xen/scripts/vif-bridge'/> + </interface> + <graphics type='vnc' port='-1' autoport='yes' listen='0.0.0.0'/> + </devices> +</domain> diff --git a/tests/libxlxml2domconfigtest.c b/tests/libxlxml2domconfigtest.c index 255855b156..4654821c3f 100644 --- a/tests/libxlxml2domconfigtest.c +++ b/tests/libxlxml2domconfigtest.c @@ -211,6 +211,15 @@ mymain(void) DO_TEST("single-serial"); DO_TEST("multiple-serial"); +#ifdef LIBXL_HAVE_BUILDINFO_HVM_VIRIDIAN_ENABLE_DISABLE + DO_TEST("viridian-hvm"); + DO_TEST("viridian-hvm-full"); + DO_TEST("viridian-hvm-none"); +#if LIBXL_BUILDINFO_HVM_VIRIDIAN_ENABLE_DISABLE_WIDTH == 64 + DO_TEST("viridian-passthrough"); +#endif +#endif + unlink("libxl-driver.log"); testXLFreeDriver(driver); -- 2.48.1

2 6

[PATCH 0/3] ch: monitor daemonization, sync after reboot, and shutdown fixes
by Kirill Shchetiniuk 03 Apr '25

03 Apr '25

1. Run CH monitor as a daemon Made the monitor process daemonized to prevent VM termination if the CH driver crashes. Added pidfile for daemon's pid aquiring and tracking as well as its init. 2. Update domain info after reboot Fixed an issue where domain properties (e.g., serial console path) were not updated after VM reboot. Added VIR_CH_EVENT_VM_REBOOTED handling to keep the transient domain definition consistent. 3. Update VM shutdown event handler VM monitor was still up even if VM was shut off, which led to an inability to start the domain again. virsh # shutdown ch-test Domain 'ch-test' is being shutdown virsh # list Id Name State ------------------------------ 722117 ch-test shut off Ensured the CH monitor process terminates along with the VM shutdown (e.g., executed using virsh). Updated virCHEventStopProcess to have proper job type. Kirill Shchetiniuk (3): ch: virCHMonitorNew() run new CH monitor daemonized ch: virCHProcessEvent() update domain info after reboot ch: virCHProcessEvent() vm shutdown event handler fix src/ch/ch_domain.c | 1 + src/ch/ch_domain.h | 1 + src/ch/ch_events.c | 8 ++++---- src/ch/ch_monitor.c | 24 ++++++++++++++++++++++-- src/ch/ch_process.c | 18 +++++++++++++++++- src/ch/ch_process.h | 2 ++ 6 files changed, 47 insertions(+), 7 deletions(-) -- 2.48.1

3 8

[PATCH 1/5] virpci: Switch to an implementation using libpciaccess
by Alexander Shursha 03 Apr '25

03 Apr '25

The current virpci code uses the Linux-specific sysfs subsystem, which makes it impossible to use on other Unix-like systems. The libpciaccess library provides a cross-platform API for accessing the PCI bus. Employ it to make the code portable. This makes libpciaccess a non-optional dependency of libvirt. Signed-off-by: Alexander Shursha <kekek2(a)ya.ru> --- meson.build | 11 +- meson_options.txt | 4 +- src/meson.build | 1 + src/util/virpci.c | 465 +++++++++++---------------------------------- tests/virpcimock.c | 22 ++- 5 files changed, 139 insertions(+), 364 deletions(-) diff --git a/meson.build b/meson.build index 2d76a0846c..85bd882406 100644 --- a/meson.build +++ b/meson.build @@ -1207,7 +1207,10 @@ parallels_sdk_version = '7.0.22' parallels_sdk_dep = dependency('parallels-sdk', version: '>=' + parallels_sdk_version, required: false) pciaccess_version = '0.10.0' -pciaccess_dep = dependency('pciaccess', version: '>=' + pciaccess_version, required: get_option('pciaccess')) +pciaccess_dep = dependency('pciaccess', version: '>=' + pciaccess_version) +if not pciaccess_dep.found() + error('pciaccess is required to build libvirt') +endif rbd_dep = cc.find_library('rbd', required: get_option('storage_rbd')) rados_dep = cc.find_library('rados', required: get_option('storage_rbd')) @@ -1461,11 +1464,6 @@ if not get_option('polkit').disabled() endif endif -if udev_dep.found() and not pciaccess_dep.found() - error('You must install the pciaccess module to build with udev') -endif - - # build driver options remote_default_mode = get_option('remote_default_mode') @@ -2341,7 +2339,6 @@ libs_summary = { 'numactl': numactl_dep.found(), 'openwsman': openwsman_dep.found(), 'parallels-sdk': parallels_sdk_dep.found(), - 'pciaccess': pciaccess_dep.found(), 'polkit': conf.has('WITH_POLKIT'), 'rbd': rbd_dep.found(), 'readline': readline_dep.found(), diff --git a/meson_options.txt b/meson_options.txt index 3dc3e8667b..69605238ba 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -38,7 +38,6 @@ option('netcf', type: 'feature', value: 'auto', description: 'netcf support') option('nls', type: 'feature', value: 'auto', description: 'nls support') option('numactl', type: 'feature', value: 'auto', description: 'numactl support') option('openwsman', type: 'feature', value: 'auto', description: 'openwsman support') -option('pciaccess', type: 'feature', value: 'auto', description: 'pciaccess support') option('polkit', type: 'feature', value: 'auto', description: 'use PolicyKit for UNIX socket access checks') option('readline', type: 'feature', value: 'auto', description: 'readline support') option('sanlock', type: 'feature', value: 'auto', description: 'sanlock support') @@ -46,7 +45,6 @@ option('sasl', type: 'feature', value: 'auto', description: 'sasl support') option('selinux', type: 'feature', value: 'auto', description: 'selinux support') option('selinux_mount', type: 'string', value: '', description: 'set SELinux mount point') option('sshconfdir', type: 'string', value: '', description: 'directory for SSH client configuration') -# dep:pciaccess option('udev', type: 'feature', value: 'auto', description: 'udev support') # dep:driver_remote option('wireshark_dissector', type: 'feature', value: 'auto', description: 'wireshark support') @@ -59,7 +57,7 @@ option('driver_bhyve', type: 'feature', value: 'auto', description: 'bhyve drive option('driver_esx', type: 'feature', value: 'auto', description: 'esx driver') # dep:openwsman option('driver_hyperv', type: 'feature', value: 'auto', description: 'Hyper-V driver') -# dep:pciaccess dep:udev dep:driver_remote dep:driver_libvirtd +# dep:udev dep:driver_remote dep:driver_libvirtd option('driver_interface', type: 'feature', value: 'auto', description: 'host interface driver') # dep:driver_remote option('driver_libvirtd', type: 'feature', value: 'auto', description: 'libvirtd driver') diff --git a/src/meson.build b/src/meson.build index 9413192a55..39788ac4d7 100644 --- a/src/meson.build +++ b/src/meson.build @@ -411,6 +411,7 @@ libvirt_lib = shared_library( dtrace_gen_objects, dependencies: [ src_dep, + pciaccess_dep ], link_args: libvirt_link_args, link_whole: [ diff --git a/src/util/virpci.c b/src/util/virpci.c index 90617e69c6..b5bbe73ece 100644 --- a/src/util/virpci.c +++ b/src/util/virpci.c @@ -2,6 +2,7 @@ * virpci.c: helper APIs for managing host PCI devices * * Copyright (C) 2009-2015 Red Hat, Inc. + * Copyright (C) 2024-2025 Future Crew, LLC * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -29,6 +30,7 @@ #include <sys/types.h> #include <sys/stat.h> #include <unistd.h> +#include <pciaccess.h> #ifdef __linux__ # include <sys/utsname.h> @@ -72,7 +74,7 @@ struct _virPCIDevice { char *name; /* domain:bus:slot.function */ char id[PCI_ID_LEN]; /* product vendor */ - char *path; + struct pci_device *device; /* The driver:domain which uses the device */ char *used_by_drvname; @@ -359,121 +361,6 @@ virPCIDeviceGetCurrentDriverNameAndType(virPCIDevice *dev, } -static int -virPCIDeviceConfigOpenInternal(virPCIDevice *dev, bool readonly, bool fatal) -{ - int fd; - - fd = open(dev->path, readonly ? O_RDONLY : O_RDWR); - - if (fd < 0) { - if (fatal) { - virReportSystemError(errno, - _("Failed to open config space file '%1$s'"), - dev->path); - } else { - VIR_WARN("Failed to open config space file '%s': %s", - dev->path, g_strerror(errno)); - } - return -1; - } - - VIR_DEBUG("%s %s: opened %s", dev->id, dev->name, dev->path); - return fd; -} - -static int -virPCIDeviceConfigOpen(virPCIDevice *dev) -{ - return virPCIDeviceConfigOpenInternal(dev, true, true); -} - -static int -virPCIDeviceConfigOpenTry(virPCIDevice *dev) -{ - return virPCIDeviceConfigOpenInternal(dev, true, false); -} - -static int -virPCIDeviceConfigOpenWrite(virPCIDevice *dev) -{ - return virPCIDeviceConfigOpenInternal(dev, false, true); -} - -static void -virPCIDeviceConfigClose(virPCIDevice *dev, int cfgfd) -{ - if (VIR_CLOSE(cfgfd) < 0) { - VIR_WARN("Failed to close config space file '%s': %s", - dev->path, g_strerror(errno)); - } -} - - -static int -virPCIDeviceRead(virPCIDevice *dev, - int cfgfd, - unsigned int pos, - uint8_t *buf, - unsigned int buflen) -{ - memset(buf, 0, buflen); - errno = 0; - - if (lseek(cfgfd, pos, SEEK_SET) != pos || - saferead(cfgfd, buf, buflen) != buflen) { - VIR_DEBUG("Failed to read %u bytes at %u from '%s' : %s", - buflen, pos, dev->path, g_strerror(errno)); - return -1; - } - return 0; -} - - -/** - * virPCIDeviceReadN: - * @dev: virPCIDevice object (used only to log name of config file) - * @cfgfd: open file descriptor for device config file in sysfs - * @pos: byte offset in the file to read from - * - * read "N" (where "N" is "8", "16", or "32", and appears at the end - * of the function name) bytes from a PCI device's already-opened - * sysfs config file and return them as the return value from the - * function. - * - * Returns the value at @pos in the file, or 0 if there was an - * error. NB: since 0 could be a valid value, occurrence of an error - * must be determined by examining errno. errno is always reset to 0 - * before the seek/read is attempted (see virPCIDeviceRead()), so if - * errno != 0 on return from one of these functions, then either the - * seek or the read operation failed for some reason. If errno == 0 - * and the return value is 0, then the config file really does contain - * the value 0 at @pos. - */ -static uint8_t -virPCIDeviceRead8(virPCIDevice *dev, int cfgfd, unsigned int pos) -{ - uint8_t buf; - virPCIDeviceRead(dev, cfgfd, pos, &buf, sizeof(buf)); - return buf; -} - -static uint16_t -virPCIDeviceRead16(virPCIDevice *dev, int cfgfd, unsigned int pos) -{ - uint8_t buf[2]; - virPCIDeviceRead(dev, cfgfd, pos, &buf[0], sizeof(buf)); - return (buf[0] << 0) | (buf[1] << 8); -} - -static uint32_t -virPCIDeviceRead32(virPCIDevice *dev, int cfgfd, unsigned int pos) -{ - uint8_t buf[4]; - virPCIDeviceRead(dev, cfgfd, pos, &buf[0], sizeof(buf)); - return (buf[0] << 0) | (buf[1] << 8) | (buf[2] << 16) | (buf[3] << 24); -} - static int virPCIDeviceReadClass(virPCIDevice *dev, uint16_t *device_class) { @@ -499,36 +386,6 @@ virPCIDeviceReadClass(virPCIDevice *dev, uint16_t *device_class) return 0; } -static int -virPCIDeviceWrite(virPCIDevice *dev, - int cfgfd, - unsigned int pos, - uint8_t *buf, - unsigned int buflen) -{ - if (lseek(cfgfd, pos, SEEK_SET) != pos || - safewrite(cfgfd, buf, buflen) != buflen) { - VIR_WARN("Failed to write to '%s' : %s", dev->path, - g_strerror(errno)); - return -1; - } - return 0; -} - -static void -virPCIDeviceWrite16(virPCIDevice *dev, int cfgfd, unsigned int pos, uint16_t val) -{ - uint8_t buf[2] = { (val >> 0), (val >> 8) }; - virPCIDeviceWrite(dev, cfgfd, pos, &buf[0], sizeof(buf)); -} - -static void -virPCIDeviceWrite32(virPCIDevice *dev, int cfgfd, unsigned int pos, uint32_t val) -{ - uint8_t buf[4] = { (val >> 0), (val >> 8), (val >> 16), (val >> 24) }; - virPCIDeviceWrite(dev, cfgfd, pos, &buf[0], sizeof(buf)); -} - typedef int (*virPCIDeviceIterPredicate)(virPCIDevice *, virPCIDevice *, void *); @@ -610,7 +467,6 @@ virPCIDeviceIterDevices(virPCIDeviceIterPredicate predicate, */ static int virPCIDeviceFindCapabilityOffset(virPCIDevice *dev, - int cfgfd, unsigned int capability, unsigned int *offset) { @@ -619,11 +475,13 @@ virPCIDeviceFindCapabilityOffset(virPCIDevice *dev, *offset = 0; /* assume failure (*nothing* can be at offset 0) */ - status = virPCIDeviceRead16(dev, cfgfd, PCI_STATUS); + pci_device_cfg_read_u16(dev->device, &status, PCI_STATUS); + if (errno != 0 || !(status & PCI_STATUS_CAP_LIST)) goto error; - pos = virPCIDeviceRead8(dev, cfgfd, PCI_CAPABILITY_LIST); + pci_device_cfg_read_u8(dev->device, &pos, PCI_CAPABILITY_LIST); + if (errno != 0) goto error; @@ -635,7 +493,9 @@ virPCIDeviceFindCapabilityOffset(virPCIDevice *dev, * capabilities here. */ while (pos >= PCI_CONF_HEADER_LEN && pos != 0xff) { - uint8_t capid = virPCIDeviceRead8(dev, cfgfd, pos); + uint8_t capid; + pci_device_cfg_read_u8(dev->device, &capid, pos); + if (errno != 0) goto error; @@ -646,7 +506,8 @@ virPCIDeviceFindCapabilityOffset(virPCIDevice *dev, return 0; } - pos = virPCIDeviceRead8(dev, cfgfd, pos + 1); + pci_device_cfg_read_u8(dev->device, &pos, pos + 1); + if (errno != 0) goto error; } @@ -665,7 +526,6 @@ virPCIDeviceFindCapabilityOffset(virPCIDevice *dev, static unsigned int virPCIDeviceFindExtendedCapabilityOffset(virPCIDevice *dev, - int cfgfd, unsigned int capability) { int ttl; @@ -677,7 +537,7 @@ virPCIDeviceFindExtendedCapabilityOffset(virPCIDevice *dev, pos = PCI_EXT_CAP_BASE; while (ttl > 0 && pos >= PCI_EXT_CAP_BASE) { - header = virPCIDeviceRead32(dev, cfgfd, pos); + header = pci_device_cfg_read_u32(dev->device, &header, pos); if ((header & PCI_EXT_CAP_ID_MASK) == capability) return pos; @@ -693,7 +553,7 @@ virPCIDeviceFindExtendedCapabilityOffset(virPCIDevice *dev, * not have FLR, 1 if it does, and -1 on error */ static bool -virPCIDeviceDetectFunctionLevelReset(virPCIDevice *dev, int cfgfd) +virPCIDeviceDetectFunctionLevelReset(virPCIDevice *dev) { uint32_t caps; unsigned int pos; @@ -707,7 +567,7 @@ virPCIDeviceDetectFunctionLevelReset(virPCIDevice *dev, int cfgfd) * on SR-IOV NICs at the moment. */ if (dev->pcie_cap_pos) { - caps = virPCIDeviceRead32(dev, cfgfd, dev->pcie_cap_pos + PCI_EXP_DEVCAP); + pci_device_cfg_read_u32(dev->device, &caps, dev->pcie_cap_pos + PCI_EXP_DEVCAP); if (caps & PCI_EXP_DEVCAP_FLR) { VIR_DEBUG("%s %s: detected PCIe FLR capability", dev->id, dev->name); return true; @@ -718,11 +578,13 @@ virPCIDeviceDetectFunctionLevelReset(virPCIDevice *dev, int cfgfd) * the same thing, except for conventional PCI * devices. This is not common yet. */ - if (virPCIDeviceFindCapabilityOffset(dev, cfgfd, PCI_CAP_ID_AF, &pos) < 0) + if (virPCIDeviceFindCapabilityOffset(dev, PCI_CAP_ID_AF, &pos) < 0) goto error; if (pos) { - caps = virPCIDeviceRead16(dev, cfgfd, pos + PCI_AF_CAP); + uint16_t caps16; + pci_device_cfg_read_u16(dev->device, &caps16, pos + PCI_AF_CAP); + caps = caps16; if (caps & PCI_AF_CAP_FLR) { VIR_DEBUG("%s %s: detected PCI FLR capability", dev->id, dev->name); return true; @@ -754,13 +616,13 @@ virPCIDeviceDetectFunctionLevelReset(virPCIDevice *dev, int cfgfd) * internal reset, not just a soft reset. */ static bool -virPCIDeviceDetectPowerManagementReset(virPCIDevice *dev, int cfgfd) +virPCIDeviceDetectPowerManagementReset(virPCIDevice *dev) { if (dev->pci_pm_cap_pos) { uint32_t ctl; /* require the NO_SOFT_RESET bit is clear */ - ctl = virPCIDeviceRead32(dev, cfgfd, dev->pci_pm_cap_pos + PCI_PM_CTRL); + pci_device_cfg_read_u32(dev->device, &ctl, dev->pci_pm_cap_pos + PCI_PM_CTRL); if (!(ctl & PCI_PM_CTRL_NO_SOFT_RESET)) { VIR_DEBUG("%s %s: detected PM reset capability", dev->id, dev->name); return true; @@ -811,26 +673,22 @@ virPCIDeviceIsParent(virPCIDevice *dev, virPCIDevice *check, void *data) uint8_t header_type, secondary, subordinate; virPCIDevice **best = data; int ret = 0; - int fd; if (dev->address.domain != check->address.domain) return 0; - if ((fd = virPCIDeviceConfigOpenTry(check)) < 0) - return 0; - /* Is it a bridge? */ ret = virPCIDeviceReadClass(check, &device_class); if (ret < 0 || device_class != PCI_CLASS_BRIDGE_PCI) - goto cleanup; + return ret; /* Is it a plane? */ - header_type = virPCIDeviceRead8(check, fd, PCI_HEADER_TYPE); + pci_device_cfg_read_u8(check->device, &header_type, PCI_HEADER_TYPE); if ((header_type & PCI_HEADER_TYPE_MASK) != PCI_HEADER_TYPE_BRIDGE) - goto cleanup; + return ret; - secondary = virPCIDeviceRead8(check, fd, PCI_SECONDARY_BUS); - subordinate = virPCIDeviceRead8(check, fd, PCI_SUBORDINATE_BUS); + pci_device_cfg_read_u8(check->device, &secondary, PCI_SECONDARY_BUS); + pci_device_cfg_read_u8(check->device, &subordinate, PCI_SUBORDINATE_BUS); VIR_DEBUG("%s %s: found parent device %s", dev->id, dev->name, check->name); @@ -838,8 +696,7 @@ virPCIDeviceIsParent(virPCIDevice *dev, virPCIDevice *check, void *data) * the direct parent. No further work is necessary */ if (dev->address.bus == secondary) { - ret = 1; - goto cleanup; + return 1; } /* otherwise, SRIOV allows VFs to be on different buses than their PFs. @@ -850,35 +707,26 @@ virPCIDeviceIsParent(virPCIDevice *dev, virPCIDevice *check, void *data) if (*best == NULL) { *best = virPCIDeviceNew(&check->address); if (*best == NULL) { - ret = -1; - goto cleanup; + return -1; } } else { /* OK, we had already recorded a previous "best" match for the * parent. See if the current device is more restrictive than the * best, and if so, make it the new best */ - int bestfd; uint8_t best_secondary; - if ((bestfd = virPCIDeviceConfigOpenTry(*best)) < 0) - goto cleanup; - best_secondary = virPCIDeviceRead8(*best, bestfd, PCI_SECONDARY_BUS); - virPCIDeviceConfigClose(*best, bestfd); + pci_device_cfg_read_u8((*best)->device, &best_secondary, PCI_SECONDARY_BUS); if (secondary > best_secondary) { virPCIDeviceFree(*best); *best = virPCIDeviceNew(&check->address); if (*best == NULL) { - ret = -1; - goto cleanup; + return -1; } } } } - - cleanup: - virPCIDeviceConfigClose(check, fd); return ret; } @@ -902,15 +750,14 @@ virPCIDeviceGetParent(virPCIDevice *dev, virPCIDevice **parent) */ static int virPCIDeviceTrySecondaryBusReset(virPCIDevice *dev, - int cfgfd, virPCIDeviceList *inactiveDevs) { g_autoptr(virPCIDevice) parent = NULL; g_autoptr(virPCIDevice) conflict = NULL; uint8_t config_space[PCI_CONF_LEN]; uint16_t ctl; - int ret = -1; - int parentfd; + pciaddr_t bytes_read; + pciaddr_t bytes_written; /* Refuse to do a secondary bus reset if there are other * devices/functions behind the bus are used by the host @@ -932,8 +779,6 @@ virPCIDeviceTrySecondaryBusReset(virPCIDevice *dev, dev->name); return -1; } - if ((parentfd = virPCIDeviceConfigOpenWrite(parent)) < 0) - goto out; VIR_DEBUG("%s %s: doing a secondary bus reset", dev->id, dev->name); @@ -941,38 +786,37 @@ virPCIDeviceTrySecondaryBusReset(virPCIDevice *dev, * for the supplied device since we refuse to do a reset if there * are multiple devices/functions */ - if (virPCIDeviceRead(dev, cfgfd, 0, config_space, PCI_CONF_LEN) < 0) { + pci_device_cfg_read(dev->device, config_space, 0, PCI_CONF_LEN, &bytes_read); + if (bytes_read < PCI_CONF_LEN) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Failed to read PCI config space for %1$s"), dev->name); - goto out; + return -1; } /* Read the control register, set the reset flag, wait 200ms, * unset the reset flag and wait 200ms. */ - ctl = virPCIDeviceRead16(dev, parentfd, PCI_BRIDGE_CONTROL); - virPCIDeviceWrite16(parent, parentfd, PCI_BRIDGE_CONTROL, - ctl | PCI_BRIDGE_CTL_RESET); + pci_device_cfg_read_u16(parent->device, &ctl, PCI_BRIDGE_CONTROL); + + pci_device_cfg_write_u16(parent->device, ctl | PCI_BRIDGE_CTL_RESET, PCI_BRIDGE_CONTROL); g_usleep(200 * 1000); /* sleep 200ms */ - virPCIDeviceWrite16(parent, parentfd, PCI_BRIDGE_CONTROL, ctl); + pci_device_cfg_write_u16(parent->device, ctl, PCI_BRIDGE_CONTROL); g_usleep(200 * 1000); /* sleep 200ms */ - if (virPCIDeviceWrite(dev, cfgfd, 0, config_space, PCI_CONF_LEN) < 0) { + pci_device_cfg_write(dev->device, config_space, 0, PCI_CONF_LEN, &bytes_written); + if (bytes_written < PCI_CONF_LEN) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Failed to restore PCI config space for %1$s"), dev->name); - goto out; + return -1; } - ret = 0; - out: - virPCIDeviceConfigClose(parent, parentfd); - return ret; + return 0; } /* Power management reset attempts to reset a device using a @@ -980,16 +824,19 @@ virPCIDeviceTrySecondaryBusReset(virPCIDevice *dev, * above we require the device supports a full internal reset. */ static int -virPCIDeviceTryPowerManagementReset(virPCIDevice *dev, int cfgfd) +virPCIDeviceTryPowerManagementReset(virPCIDevice *dev) { uint8_t config_space[PCI_CONF_LEN]; uint32_t ctl; + pciaddr_t bytes_read; + pciaddr_t bytes_written; if (!dev->pci_pm_cap_pos) return -1; /* Save and restore the device's config space. */ - if (virPCIDeviceRead(dev, cfgfd, 0, &config_space[0], PCI_CONF_LEN) < 0) { + pci_device_cfg_read(dev->device, config_space, 0, PCI_CONF_LEN, &bytes_read); + if (bytes_read < PCI_CONF_LEN) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Failed to read PCI config space for %1$s"), dev->name); @@ -998,20 +845,19 @@ virPCIDeviceTryPowerManagementReset(virPCIDevice *dev, int cfgfd) VIR_DEBUG("%s %s: doing a power management reset", dev->id, dev->name); - ctl = virPCIDeviceRead32(dev, cfgfd, dev->pci_pm_cap_pos + PCI_PM_CTRL); + pci_device_cfg_read_u32(dev->device, &ctl, dev->pci_pm_cap_pos + PCI_PM_CTRL); ctl &= ~PCI_PM_CTRL_STATE_MASK; - virPCIDeviceWrite32(dev, cfgfd, dev->pci_pm_cap_pos + PCI_PM_CTRL, - ctl | PCI_PM_CTRL_STATE_D3hot); + pci_device_cfg_write_u32(dev->device, ctl | PCI_PM_CTRL_STATE_D3hot, dev->pci_pm_cap_pos + PCI_PM_CTRL); g_usleep(10 * 1000); /* sleep 10ms */ - virPCIDeviceWrite32(dev, cfgfd, dev->pci_pm_cap_pos + PCI_PM_CTRL, - ctl | PCI_PM_CTRL_STATE_D0); + pci_device_cfg_write_u32(dev->device, ctl | PCI_PM_CTRL_STATE_D0, dev->pci_pm_cap_pos + PCI_PM_CTRL); g_usleep(10 * 1000); /* sleep 10ms */ - if (virPCIDeviceWrite(dev, cfgfd, 0, &config_space[0], PCI_CONF_LEN) < 0) { + pci_device_cfg_write(dev->device, config_space, 0, PCI_CONF_LEN, &bytes_written); + if (bytes_written < PCI_CONF_LEN) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Failed to restore PCI config space for %1$s"), dev->name); @@ -1046,10 +892,10 @@ virPCIDeviceTryPowerManagementReset(virPCIDevice *dev, int cfgfd) * Always returns success (0) (for now) */ static int -virPCIDeviceInit(virPCIDevice *dev, int cfgfd) +virPCIDeviceInit(virPCIDevice *dev) { dev->is_pcie = false; - if (virPCIDeviceFindCapabilityOffset(dev, cfgfd, PCI_CAP_ID_EXP, &dev->pcie_cap_pos) < 0) { + if (virPCIDeviceFindCapabilityOffset(dev, PCI_CAP_ID_EXP, &dev->pcie_cap_pos) < 0) { /* an unprivileged process is unable to read *all* of a * device's PCI config (it can only read the first 64 * bytes, which isn't enough for see the Express @@ -1065,18 +911,13 @@ virPCIDeviceInit(virPCIDevice *dev, int cfgfd) * -1), then we blindly assume the most likely outcome - * PCIe. */ - off_t configLen = virFileLength(virPCIDeviceGetConfigPath(dev), -1); - - if (configLen != 256) - dev->is_pcie = true; - } else { dev->is_pcie = (dev->pcie_cap_pos != 0); } - virPCIDeviceFindCapabilityOffset(dev, cfgfd, PCI_CAP_ID_PM, &dev->pci_pm_cap_pos); - dev->has_flr = virPCIDeviceDetectFunctionLevelReset(dev, cfgfd); - dev->has_pm_reset = virPCIDeviceDetectPowerManagementReset(dev, cfgfd); + virPCIDeviceFindCapabilityOffset(dev, PCI_CAP_ID_PM, &dev->pci_pm_cap_pos); + dev->has_flr = virPCIDeviceDetectFunctionLevelReset(dev); + dev->has_pm_reset = virPCIDeviceDetectPowerManagementReset(dev); return 0; } @@ -1089,7 +930,6 @@ virPCIDeviceReset(virPCIDevice *dev, g_autofree char *drvName = NULL; virPCIStubDriver drvType; int ret = -1; - int fd = -1; int hdrType = -1; if (virPCIGetHeaderType(dev, &hdrType) < 0) @@ -1114,29 +954,26 @@ virPCIDeviceReset(virPCIDevice *dev, * be redundant. */ if (virPCIDeviceGetCurrentDriverNameAndType(dev, &drvName, &drvType) < 0) - goto cleanup; + return -1; if (drvType == VIR_PCI_STUB_DRIVER_VFIO) { VIR_DEBUG("Device %s is bound to %s - skip reset", dev->name, drvName); ret = 0; - goto cleanup; + return 0; } VIR_DEBUG("Resetting device %s", dev->name); - if ((fd = virPCIDeviceConfigOpenWrite(dev)) < 0) - goto cleanup; - - if (virPCIDeviceInit(dev, fd) < 0) - goto cleanup; + if (virPCIDeviceInit(dev) < 0) + return -1; /* KVM will perform FLR when starting and stopping * a guest, so there is no need for us to do it here. */ if (dev->has_flr) { ret = 0; - goto cleanup; + return 0; } /* If the device supports PCI power management reset, @@ -1144,11 +981,11 @@ virPCIDeviceReset(virPCIDevice *dev, * the function, not the whole device. */ if (dev->has_pm_reset) - ret = virPCIDeviceTryPowerManagementReset(dev, fd); + ret = virPCIDeviceTryPowerManagementReset(dev); /* Bus reset is not an option with the root bus */ if (ret < 0 && dev->address.bus != 0) - ret = virPCIDeviceTrySecondaryBusReset(dev, fd, inactiveDevs); + ret = virPCIDeviceTrySecondaryBusReset(dev, inactiveDevs); if (ret < 0) { virErrorPtr err = virGetLastError(); @@ -1159,8 +996,6 @@ virPCIDeviceReset(virPCIDevice *dev, _("no FLR, PM reset or bus reset available")); } - cleanup: - virPCIDeviceConfigClose(dev, fd); return ret; } @@ -1756,28 +1591,6 @@ virPCIDeviceReattach(virPCIDevice *dev, return 0; } -static char * -virPCIDeviceReadID(virPCIDevice *dev, const char *id_name) -{ - g_autofree char *path = NULL; - g_autofree char *id_str = NULL; - - path = virPCIFile(dev->name, id_name); - - /* ID string is '0xNNNN\n' ... i.e. 7 bytes */ - if (virFileReadAll(path, 7, &id_str) < 0) - return NULL; - - /* Check for 0x suffix */ - if (id_str[0] != '0' || id_str[1] != 'x') - return NULL; - - /* Chop off the newline; we know the string is 7 bytes */ - id_str[6] = '\0'; - - return g_steal_pointer(&id_str); -} - bool virPCIDeviceAddressIsValid(virPCIDeviceAddress *addr, bool report) @@ -1865,9 +1678,9 @@ virPCIDeviceExists(const virPCIDeviceAddress *addr) virPCIDevice * virPCIDeviceNew(const virPCIDeviceAddress *address) { + struct pci_device * device; + g_autoptr(virPCIDevice) dev = NULL; - g_autofree char *vendor = NULL; - g_autofree char *product = NULL; dev = g_new0(virPCIDevice, 1); @@ -1875,31 +1688,21 @@ virPCIDeviceNew(const virPCIDeviceAddress *address) dev->name = virPCIDeviceAddressAsString(&dev->address); - dev->path = g_strdup_printf(PCI_SYSFS "devices/%s/config", dev->name); - - if (!virFileExists(dev->path)) { - virReportSystemError(errno, - _("Device %1$s not found: could not access %2$s"), - dev->name, dev->path); + pci_system_init(); + device = pci_device_find_by_slot(address->domain, address->bus, address->slot, address->function); + if (!device) return NULL; - } - - vendor = virPCIDeviceReadID(dev, "vendor"); - product = virPCIDeviceReadID(dev, "device"); - - if (!vendor || !product) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Failed to read product/vendor ID for %1$s"), - dev->name); + dev->device = g_memdup(device, sizeof(*dev->device)); + if (!dev->device) { + virReportSystemError(errno, + _("Not found device domain: %1$d, bus: %2$d, slot: %3$d, function: %4$d"), + address->domain, address->bus, address->slot, address->function); return NULL; } - - /* strings contain '0x' prefix */ - if (g_snprintf(dev->id, sizeof(dev->id), "%s %s", &vendor[2], - &product[2]) >= sizeof(dev->id)) { + if (g_snprintf(dev->id, sizeof(dev->id), "%x %x", dev->device->vendor_id, dev->device->device_id) >= sizeof(dev->id)) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("dev->id buffer overflow: %1$s %2$s"), - &vendor[2], &product[2]); + _("dev->id buffer overflow: %1$d %2$d"), + dev->device->vendor_id, dev->device->device_id); return NULL; } @@ -1918,10 +1721,10 @@ virPCIDeviceCopy(virPCIDevice *dev) /* shallow copy to take care of most attributes */ *copy = *dev; - copy->path = NULL; - copy->used_by_drvname = copy->used_by_domname = NULL; + copy->device = NULL; + copy->device = g_memdup(dev->device, sizeof(*dev->device)); + copy->name = copy->used_by_drvname = copy->used_by_domname = copy->stubDriverName = NULL; copy->name = g_strdup(dev->name); - copy->path = g_strdup(dev->path); copy->used_by_drvname = g_strdup(dev->used_by_drvname); copy->used_by_domname = g_strdup(dev->used_by_domname); copy->stubDriverName = g_strdup(dev->stubDriverName); @@ -1936,10 +1739,11 @@ virPCIDeviceFree(virPCIDevice *dev) return; VIR_DEBUG("%s %s: freeing", dev->id, dev->name); g_free(dev->name); - g_free(dev->path); g_free(dev->used_by_drvname); g_free(dev->used_by_domname); g_free(dev->stubDriverName); + if (dev->device) + g_free(dev->device); g_free(dev); } @@ -1971,9 +1775,9 @@ virPCIDeviceGetName(virPCIDevice *dev) * config file. */ const char * -virPCIDeviceGetConfigPath(virPCIDevice *dev) +virPCIDeviceGetConfigPath(virPCIDevice *dev G_GNUC_UNUSED) { - return dev->path; + return NULL; } void virPCIDeviceSetManaged(virPCIDevice *dev, bool managed) @@ -2484,47 +2288,37 @@ virPCIDeviceDownstreamLacksACS(virPCIDevice *dev) uint16_t flags; uint16_t ctrl; unsigned int pos; - int fd; - int ret = 0; uint16_t device_class; - if ((fd = virPCIDeviceConfigOpen(dev)) < 0) + if (virPCIDeviceInit(dev) < 0) { return -1; - - if (virPCIDeviceInit(dev, fd) < 0) { - ret = -1; - goto cleanup; } if (virPCIDeviceReadClass(dev, &device_class) < 0) - goto cleanup; + return 0; pos = dev->pcie_cap_pos; if (!pos || device_class != PCI_CLASS_BRIDGE_PCI) - goto cleanup; + return 0; - flags = virPCIDeviceRead16(dev, fd, pos + PCI_EXP_FLAGS); + pci_device_cfg_read_u16(dev->device, &flags, pos + PCI_EXP_FLAGS); if (((flags & PCI_EXP_FLAGS_TYPE) >> 4) != PCI_EXP_TYPE_DOWNSTREAM) - goto cleanup; + return 0; - pos = virPCIDeviceFindExtendedCapabilityOffset(dev, fd, PCI_EXT_CAP_ID_ACS); + pos = virPCIDeviceFindExtendedCapabilityOffset(dev, PCI_EXT_CAP_ID_ACS); if (!pos) { VIR_DEBUG("%s %s: downstream port lacks ACS", dev->id, dev->name); - ret = 1; - goto cleanup; + return 1; } - ctrl = virPCIDeviceRead16(dev, fd, pos + PCI_EXT_ACS_CTRL); + pci_device_cfg_read_u16(dev->device, &ctrl, pos + PCI_EXT_ACS_CTRL); if ((ctrl & PCI_EXT_CAP_ACS_ENABLED) != PCI_EXT_CAP_ACS_ENABLED) { VIR_DEBUG("%s %s: downstream port has ACS disabled", dev->id, dev->name); - ret = 1; - goto cleanup; + return 1; } - cleanup: - virPCIDeviceConfigClose(dev, fd); - return ret; + return 0; } static int @@ -3189,48 +2983,27 @@ virPCIDeviceGetVPD(virPCIDevice *dev G_GNUC_UNUSED) int virPCIDeviceIsPCIExpress(virPCIDevice *dev) { - int fd; - int ret = -1; - - if ((fd = virPCIDeviceConfigOpen(dev)) < 0) - return ret; - - if (virPCIDeviceInit(dev, fd) < 0) - goto cleanup; - - ret = dev->is_pcie; + if (virPCIDeviceInit(dev) < 0) + return -1; - cleanup: - virPCIDeviceConfigClose(dev, fd); - return ret; + return dev->is_pcie; } int virPCIDeviceHasPCIExpressLink(virPCIDevice *dev) { - int fd; - int ret = -1; uint16_t cap, type; - - if ((fd = virPCIDeviceConfigOpen(dev)) < 0) - return ret; - - if (virPCIDeviceInit(dev, fd) < 0) - goto cleanup; + if (virPCIDeviceInit(dev) < 0) + return -1; if (dev->pcie_cap_pos == 0) { - ret = 0; - goto cleanup; + return 0; } - cap = virPCIDeviceRead16(dev, fd, dev->pcie_cap_pos + PCI_CAP_FLAGS); + pci_device_cfg_read_u16(dev->device, &cap, dev->pcie_cap_pos + PCI_CAP_FLAGS); type = (cap & PCI_EXP_FLAGS_TYPE) >> 4; - ret = type != PCI_EXP_TYPE_ROOT_INT_EP && type != PCI_EXP_TYPE_ROOT_EC; - - cleanup: - virPCIDeviceConfigClose(dev, fd); - return ret; + return type != PCI_EXP_TYPE_ROOT_INT_EP && type != PCI_EXP_TYPE_ROOT_EC; } int @@ -3242,53 +3015,39 @@ virPCIDeviceGetLinkCapSta(virPCIDevice *dev, unsigned int *sta_width) { uint32_t t; - int fd; - int ret = -1; - - if ((fd = virPCIDeviceConfigOpen(dev)) < 0) - return ret; - - if (virPCIDeviceInit(dev, fd) < 0) - goto cleanup; + uint16_t t16; + if (virPCIDeviceInit(dev) < 0) + return -1; if (!dev->pcie_cap_pos) { virReportError(VIR_ERR_INTERNAL_ERROR, _("pci device %1$s is not a PCI-Express device"), dev->name); - goto cleanup; + return -1; } - t = virPCIDeviceRead32(dev, fd, dev->pcie_cap_pos + PCI_EXP_LNKCAP); + pci_device_cfg_read_u32(dev->device, &t, dev->pcie_cap_pos + PCI_EXP_LNKCAP); *cap_port = t >> 24; *cap_speed = t & PCI_EXP_LNKCAP_SPEED; *cap_width = (t & PCI_EXP_LNKCAP_WIDTH) >> 4; - t = virPCIDeviceRead16(dev, fd, dev->pcie_cap_pos + PCI_EXP_LNKSTA); + pci_device_cfg_read_u16(dev->device, &t16, dev->pcie_cap_pos + PCI_EXP_LNKSTA); + t = t16; *sta_speed = t & PCI_EXP_LNKSTA_SPEED; *sta_width = (t & PCI_EXP_LNKSTA_WIDTH) >> 4; - ret = 0; - - cleanup: - virPCIDeviceConfigClose(dev, fd); - return ret; + return 0; } int virPCIGetHeaderType(virPCIDevice *dev, int *hdrType) { - int fd; uint8_t type; *hdrType = -1; - if ((fd = virPCIDeviceConfigOpen(dev)) < 0) - return -1; - - type = virPCIDeviceRead8(dev, fd, PCI_HEADER_TYPE); - - virPCIDeviceConfigClose(dev, fd); + pci_device_cfg_read_u8(dev->device, &type, PCI_HEADER_TYPE); type &= PCI_HEADER_TYPE_MASK; if (type >= VIR_PCI_HEADER_LAST) { diff --git a/tests/virpcimock.c b/tests/virpcimock.c index 5b923c63ce..36bb57edb0 100644 --- a/tests/virpcimock.c +++ b/tests/virpcimock.c @@ -1,5 +1,6 @@ /* * Copyright (C) 2013 Red Hat, Inc. + * Copyright (C) 2024-2025 Future Crew, LLC * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -22,7 +23,7 @@ #include "virpcivpdpriv.h" -#if defined(__linux__) || defined(__FreeBSD__) || defined(__APPLE__) +#if defined(__linux__) || defined(__APPLE__) # define VIR_MOCK_LOOKUP_MAIN # include "virmock.h" # include "virpci.h" @@ -42,6 +43,10 @@ static int (*real___open_2)(const char *path, int flags); static int (*real_close)(int fd); static DIR * (*real_opendir)(const char *name); static char *(*real_virFileCanonicalizePath)(const char *path); +static int (*real_scandir)(const char *restrict dirp, + struct dirent ***restrict namelist, + typeof(int(const struct dirent *)) *filter, + typeof(int(const struct dirent **, const struct dirent **)) *compar); static char *fakerootdir; @@ -955,6 +960,7 @@ init_syms(void) VIR_MOCK_REAL_INIT(opendir); # endif VIR_MOCK_REAL_INIT(virFileCanonicalizePath); + VIR_MOCK_REAL_INIT(scandir); } static void @@ -1172,6 +1178,20 @@ virFileCanonicalizePath(const char *path) return real_virFileCanonicalizePath(newpath); } +int scandir(const char *restrict dirp, struct dirent ***restrict namelist, + typeof(int(const struct dirent *)) *filter, + typeof(int(const struct dirent **, const struct dirent **)) *compar) +{ + g_autofree char *newpath = NULL; + + init_syms(); + + if (getrealpath(&newpath, dirp) < 0) + return -1; + + return real_scandir(newpath, namelist, filter, compar); +} + # include "virmockstathelpers.c" #else -- 2.46.1

2 9

[libvirt PATCH] tools: virsh: metadata: do not report error on missing metadata
by Ján Tomko 02 Apr '25

02 Apr '25

Similarly to `desc` and `net-desc`, return an empty string if there is no metadata to be returned. https://issues.redhat.com/browse/RHEL-27172 Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- tools/virsh-domain.c | 10 ++++++++-- tools/virsh-network.c | 10 ++++++++-- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index f3da2f903f..e104aa909a 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -8480,8 +8480,14 @@ cmdMetadata(vshControl *ctl, const vshCmd *cmd) g_autofree char *data = NULL; /* get */ if (!(data = virDomainGetMetadata(dom, VIR_DOMAIN_METADATA_ELEMENT, - uri, flags))) - return false; + uri, flags))) { + if (virGetLastErrorCode() == VIR_ERR_NO_DOMAIN_METADATA) { + virResetLastError(); + data = g_strdup(""); + } else { + return false; + } + } vshPrint(ctl, "%s\n", data); } diff --git a/tools/virsh-network.c b/tools/virsh-network.c index 6fcc7fd8ee..bcdb76ae36 100644 --- a/tools/virsh-network.c +++ b/tools/virsh-network.c @@ -604,8 +604,14 @@ cmdNetworkMetadata(vshControl *ctl, const vshCmd *cmd) /* get */ if (!(data = virNetworkGetMetadata(net, VIR_NETWORK_METADATA_ELEMENT, - uri, flags))) - return false; + uri, flags))) { + if (virGetLastErrorCode() == VIR_ERR_NO_NETWORK_METADATA) { + virResetLastError(); + data = g_strdup(""); + } else { + return false; + } + } vshPrint(ctl, "%s\n", data); } -- 2.48.1

4 4

[PATCH 0/6] qemu: Remove last HMP commands
by Peter Krempa 02 Apr '25

02 Apr '25

RIP HMP use in libvirt: 2007-02-14 [1] - 2025-04-02 [1] 23ad665cb05ef9ce7d298cc34bff5efb95ef6948 Peter Krempa (6): qemu: domain: Don't check return value of 'virCPUDefCopy' qemuSnapshotCreateActiveInternal: Fix error logic qemu: snapshot: Always assume support for QEMU_CAPS_SNAPSHOT_INTERNAL_QMP qemu: Always revert internal snapshots via QMP rather than '-loadvm' qemu: monitor: Remove HMP monitor code qemu: capabilities: Retire QEMU_CAPS_SNAPSHOT_INTERNAL_QMP po/POTFILES | 1 - src/qemu/meson.build | 1 - src/qemu/qemu_capabilities.c | 3 +- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c | 6 -- src/qemu/qemu_domain.c | 7 +- src/qemu/qemu_monitor.c | 25 ------ src/qemu/qemu_monitor.h | 3 - src/qemu/qemu_monitor_text.c | 88 ------------------- src/qemu/qemu_monitor_text.h | 29 ------ src/qemu/qemu_process.c | 3 +- src/qemu/qemu_snapshot.c | 49 ++--------- .../caps_10.0.0_s390x.xml | 1 - .../caps_10.0.0_x86_64+amdsev.xml | 1 - .../caps_10.0.0_x86_64.xml | 1 - .../qemucapabilitiesdata/caps_6.2.0_ppc64.xml | 1 - .../caps_6.2.0_x86_64.xml | 1 - .../qemucapabilitiesdata/caps_7.0.0_ppc64.xml | 1 - .../caps_7.0.0_x86_64.xml | 1 - .../qemucapabilitiesdata/caps_7.1.0_ppc64.xml | 1 - .../caps_7.1.0_x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml | 1 - .../caps_7.2.0_x86_64+hvf.xml | 1 - .../caps_7.2.0_x86_64.xml | 1 - .../caps_8.0.0_x86_64.xml | 1 - .../qemucapabilitiesdata/caps_8.1.0_s390x.xml | 1 - .../caps_8.1.0_x86_64.xml | 1 - .../caps_8.2.0_aarch64.xml | 1 - .../caps_8.2.0_armv7l.xml | 1 - .../caps_8.2.0_loongarch64.xml | 1 - .../qemucapabilitiesdata/caps_8.2.0_s390x.xml | 1 - .../caps_8.2.0_x86_64.xml | 1 - .../qemucapabilitiesdata/caps_9.0.0_sparc.xml | 1 - .../caps_9.0.0_x86_64.xml | 1 - .../caps_9.1.0_riscv64.xml | 1 - .../qemucapabilitiesdata/caps_9.1.0_s390x.xml | 1 - .../caps_9.1.0_x86_64.xml | 1 - .../caps_9.2.0_aarch64+hvf.xml | 1 - .../qemucapabilitiesdata/caps_9.2.0_s390x.xml | 1 - .../caps_9.2.0_x86_64+amdsev.xml | 1 - .../caps_9.2.0_x86_64.xml | 1 - 41 files changed, 15 insertions(+), 231 deletions(-) delete mode 100644 src/qemu/qemu_monitor_text.c delete mode 100644 src/qemu/qemu_monitor_text.h -- 2.49.0

3 8

[PATCH] meson: Add back prefix path for runstatedir
by Zhenzhong Duan 02 Apr '25

02 Apr '25

Currently libvirt favors /run instead of /var/run, but for local build run test, a prefix path is still needed to avoid interoperating with OS vendor provided binaries. Signed-off-by: Zhenzhong Duan <zhenzhong.duan(a)intel.com> --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index bf4a245dd3..84c9796c2f 100644 --- a/meson.build +++ b/meson.build @@ -82,7 +82,7 @@ endif runstatedir = get_option('runstatedir') if runstatedir == '' - runstatedir = '/run' + runstatedir = prefix / 'run' endif initconfdir = get_option('initconfdir') -- 2.34.1

4 4

Report a build issue
by Duan, Zhenzhong 02 Apr '25

02 Apr '25

Hi, When -Dlibnl=disabled, build failed as below: ../src/util/virnetdevbridge.c: In function 'virNetDevBridgeSetupVlans': ../src/util/virnetdevbridge.c:326:9: error: implicit declaration of function 'virNetlinkBridgeVlanFilterSet'; did you mean 'virNetDevBridgeGetVlanFiltering'? [-Werror=implicit-function-declaration] 326 | if (virNetlinkBridgeVlanFilterSet(ifname, RTM_DELLINK, 0, 1, &error) < 0) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | virNetDevBridgeGetVlanFiltering ../src/util/virnetdevbridge.c:326:9: error: nested extern declaration of 'virNetlinkBridgeVlanFilterSet' [-Werror=nested-externs] ../src/util/virnetdevbridge.c:326:47: error: 'RTM_DELLINK' undeclared (first use in this function) 326 | if (virNetlinkBridgeVlanFilterSet(ifname, RTM_DELLINK, 0, 1, &error) < 0) { | ^~~~~~~~~~~ ../src/util/virnetdevbridge.c:326:47: note: each undeclared identifier is reported only once for each function it appears in ../src/util/virnetdevbridge.c:346:55: error: 'RTM_SETLINK' undeclared (first use in this function) 346 | if (virNetlinkBridgeVlanFilterSet(ifname, RTM_SETLINK, flags, | ^~~~~~~~~~~ cc1: all warnings being treated as errors Thanks Zhenzhong

2 2

[PATCH rfcv4 00/13] LIBVIRT: X86: TDX support
by Zhenzhong Duan 02 Apr '25

02 Apr '25

Hi, This series brings libvirt the x86 TDX support. * What's TDX? TDX stands for Trust Domain Extensions which isolates VMs from the virtual-machine manager (VMM)/hypervisor and any other software on the platform. To support TDX, multiple software components, not only KVM but also QEMU, guest Linux and virtual bios, need to be updated. For more details, please check link[1]. This patchset is another software component to extend libvirt to support TDX, with which one can start a TDX guest from high level rather than running qemu directly. * Misc As QEMU use a software emulated way to reset guest which isn't supported by TDX guest for security reason. We simulate reboot for TDX guest by kill and create a new one in FakeReboot framework. Complete code can be found at [2], matching qemu code can be found at [3]. There is a 'debug' property for tdx-guest object which isn't in matching qemu[3] yet. I keep them intentionally as they will be implemented in qemu as extention series of [3]. * Test start/stop/reboot with virsh stop/reboot trigger in guest stop with on_poweroff=destroy/restart reboot with on_reboot=destroy/restart * Patch organization - patch 1-4: Support query of TDX capabilities. - patch 5-8: Add TDX type to launchsecurity framework. - patch 9-11: Add reboot support to TDX guest - patch 12-13: Add test and docs TODO: - update QEMU capabilities data in tests, depending on qemu TDX merged beforehand - add reconnect logic in virsh command [1] https://lore.kernel.org/kvm/cover.1708933498.git.isaku.yamahata@intel.com [2] https://github.com/intel/libvirt-tdx/commits/tdx_for_upstream_rfcv4 [3] https://github.com/intel/qemu-tdx/tree/tdx-qemu-upstream-v5 Thanks Zhenzhong Changelog: rfcv4: - add a check to tools/virt-host-validate-qemu.c (Daniel) - remove check of q35 (Daniel) - model 'SocktetAddress' QAPI in xml schema (Daniel) - s/Quote-Generation-Service/quoteGenerationService/ (Daniel) - define bits in tdx->policy and add validating logic (Daniel) - presume QEMU choose split kernel irqchip for TDX guest by default (Daniel) - utilize existing FakeReboot framework to do reboot for TDX guest (Daniel) - drop patch11 'conf: Add support to keep same domid for hard reboot' (Daniel) - add test in tests/ to validate parsing and formatting logic (Daniel) - add doc in docs/formatdomain.rst (Daniel) - add R-B rfcv3: - Change to generate qemu cmdline with -bios - drop firmware auto match as -bios is used - add a hard reboot method to reboot TDX guest rfcv3: https://www.mail-archive.com/devel@lists.libvirt.org/msg00385.html rfcv2: - give up using qmp cmd and check TDX directly on host for TDX capabilities. - use launchsecurity framework to support TDX - use <os>.<loader> for general loader - add auto firmware match feature for TDX A example TDVF fimware description file 70-edk2-x86_64-tdx.json: { "description": "UEFI firmware for x86_64, supporting Intel TDX", "interface-types": [ "uefi" ], "mapping": { "device": "generic", "filename": "/usr/share/OVMF/OVMF_CODE-tdx.fd" }, "targets": [ { "architecture": "x86_64", "machines": [ "pc-q35-*" ] } ], "features": [ "intel-tdx", "verbose-dynamic" ], "tags": [ ] } rfcv2: https://www.mail-archive.com/libvir-list@redhat.com/msg219378.html Zhenzhong Duan (13): tools: Secure guest check for Intel in virt-host-validate qemu: Check if INTEL Trust Domain Extention support is enabled qemu: Add TDX capability conf: expose TDX feature in domain capabilities conf: add tdx as launch security type qemu: Add command line and validation for TDX type qemu: force special parameters enabled for TDX guest Add Intel TDX Quote Generation Service(QGS) support qemu: add FakeReboot support for TDX guest qemu: Support reboot command in guest qemu: Avoid duplicate FakeReboot for secure guest Add test cases for Intel TDX docs: domain: Add documentation for Intel TDX guest docs/formatdomain.rst | 68 ++++ docs/formatdomaincaps.rst | 1 + src/conf/domain_capabilities.c | 1 + src/conf/domain_capabilities.h | 1 + src/conf/domain_conf.c | 312 ++++++++++++++++++ src/conf/domain_conf.h | 75 +++++ src/conf/schemas/domaincaps.rng | 9 + src/conf/schemas/domaincommon.rng | 135 ++++++++ src/conf/virconftypes.h | 2 + src/qemu/qemu_capabilities.c | 36 +- src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 139 ++++++++ src/qemu/qemu_firmware.c | 1 + src/qemu/qemu_monitor.c | 28 +- src/qemu/qemu_monitor.h | 2 +- src/qemu/qemu_monitor_json.c | 6 +- src/qemu/qemu_namespace.c | 1 + src/qemu/qemu_process.c | 75 +++++ src/qemu/qemu_validate.c | 44 +++ ...unch-security-tdx-qgs-fd.x86_64-latest.xml | 77 +++++ .../launch-security-tdx-qgs-fd.xml | 30 ++ ...ch-security-tdx-qgs-inet.x86_64-latest.xml | 77 +++++ .../launch-security-tdx-qgs-inet.xml | 30 ++ ...ch-security-tdx-qgs-unix.x86_64-latest.xml | 77 +++++ .../launch-security-tdx-qgs-unix.xml | 30 ++ ...h-security-tdx-qgs-vsock.x86_64-latest.xml | 77 +++++ .../launch-security-tdx-qgs-vsock.xml | 30 ++ tests/qemuxmlconftest.c | 24 ++ tools/virt-host-validate-common.c | 22 +- tools/virt-host-validate-common.h | 1 + 30 files changed, 1407 insertions(+), 5 deletions(-) create mode 100644 tests/qemuxmlconfdata/launch-security-tdx-qgs-fd.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/launch-security-tdx-qgs-fd.xml create mode 100644 tests/qemuxmlconfdata/launch-security-tdx-qgs-inet.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/launch-security-tdx-qgs-inet.xml create mode 100644 tests/qemuxmlconfdata/launch-security-tdx-qgs-unix.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/launch-security-tdx-qgs-unix.xml create mode 100644 tests/qemuxmlconfdata/launch-security-tdx-qgs-vsock.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/launch-security-tdx-qgs-vsock.xml -- 2.34.1

6 45

[PATCH] virt-aa-helper: delete dynamic files
by Alessandro 01 Apr '25

01 Apr '25

We attempted multiple ways to clean up dynamic files; however, we must preserve user overrides, which requires keeping the file /etc/apparmor.d/libvirt/libvirt-uuid This commit proposes to move user overrides into /etc/apparmor.d/libvirt/libvirt-uuid.local and include it, if present, unconditionally. When we stop the domain, we remove libvirt.uuid and libvirt-uuid.files, whereas we preserve libvirt-uuid.local if present. Applying the patch, it produces the following: root@virt-hv-lab002:/etc/apparmor.d/libvirt# ls -1 libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033* libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033 libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033.files root@virt-hv-lab002:/etc/apparmor.d/libvirt# cat libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033 profile libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033 flags=(attach_disconnected) { #include <abstractions/libvirt-qemu> #include if exists <libvirt/libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033.files> #include if exists <libvirt/libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033.local> } root@virt-hv-lab002:/etc/apparmor.d/libvirt# cat libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033.files "/var/log/libvirt/**/testing-9a4be628.log" w, "/var/lib/libvirt/qemu/domain-testing-9a4be628/monitor.sock" rw, "/var/lib/libvirt/qemu/domain-4-testing-9a4be628/*" rw, "/var/run/libvirt/**/testing-9a4be628.pid" rwk, "/var/run/libvirt/**/*.tunnelmigrate.dest.testing-9a4be628" rw, "/var/lib/libvirt/images/testing-9a4be628.qcow2" rwk, "/var/lib/libvirt/images/noble-server-cloudimg-amd64.img" rk, # don't audit writes to readonly files deny "/var/lib/libvirt/images/noble-server-cloudimg-amd64.img" w, "/var/lib/libvirt/images/testing-9a4be628-ds.qcow2" rwk, "/usr/share/OVMF/OVMF_CODE_4M.fd" rk, # don't audit writes to readonly files deny "/usr/share/OVMF/OVMF_CODE_4M.fd" w, "/var/lib/libvirt/qemu/nvram/testing-9a4be628_VARS.fd" rwk, "/dev/vhost-net" rw, "/var/lib/libvirt/qemu/domain-4-testing-9a4be628/{,**}" rwk, "/run/libvirt/qemu/channel/4-testing-9a4be628/{,**}" rwk, "/var/lib/libvirt/qemu/domain-4-testing-9a4be628/master-key.aes" rwk, "/dev/net/tun" rwk, "/dev/userfaultfd" rwk, Fixes: https://gitlab.com/libvirt/libvirt/-/issues/451 Signed-off-by: Alessandro <alessandro(a)0x65c.net> --- src/security/virt-aa-helper.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 034c042..6a1fb85 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -1495,8 +1495,10 @@ main(int argc, char **argv) rc = parserLoad(ctl->uuid); } else if (ctl->cmd == 'R' || ctl->cmd == 'D') { rc = parserRemove(ctl->uuid); - if (ctl->cmd == 'D') + if (ctl->cmd == 'D') { unlink(include_file); + unlink(profile); + } } else if (ctl->cmd == 'c' || ctl->cmd == 'r') { g_autofree char *included_files = NULL; g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; @@ -1561,12 +1563,18 @@ main(int argc, char **argv) /* create the profile from TEMPLATE */ if (ctl->cmd == 'c' || purged) { g_autofree char *tmp = NULL; + g_autofree char *tmp_local = NULL; + char *new_tmp = NULL; #if defined(WITH_APPARMOR_3) const char *ifexists = "if exists "; #else const char *ifexists = ""; #endif tmp = g_strdup_printf(" #include %s<libvirt/%s.files>\n", ifexists, ctl->uuid); + tmp_local = g_strdup_printf(" #include %s<libvirt/%s.local>\n", ifexists, ctl->uuid); + new_tmp = g_strconcat(tmp, tmp_local, NULL); + g_free(tmp); + tmp = g_steal_pointer(&new_tmp); if (ctl->dryrun) { vah_info(profile); -- 2.49.0

3 9

[PATCH] news: document dropping apparmor < 3.0.0
by Daniel P. Berrangé 01 Apr '25

01 Apr '25

From: Daniel P. Berrangé <berrange(a)redhat.com> Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- NEWS.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 0cb11313cd..d359bc5a32 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -15,6 +15,8 @@ v11.3.0 (unreleased) * **Removed features** + * Support for AppArmor versions prior to 3.0.0 has been dropped + * **New features** * **Improvements** -- 2.48.1

2 1

Release of libvirt-11.2.0
by Jiri Denemark 01 Apr '25

01 Apr '25

The 11.2.0 release of both libvirt and libvirt-python is tagged and signed tarballs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is greatly appreciated. * Removed features * Remove support for qemu-6.1 and older Libvirt now requires *qemu-6.2* or newer based on our platform support policy. * New features * qemu: Add new 'image_format' parameter to virDomainSaveParams ``virDomainSaveParams`` now supports an ``image_format`` parameter for specifying the save image format on a per-domain basis. The parameter accepts the same values as the driver-wide ``save_image_format`` setting in ``qemu.conf``. An image format specified via ``virDomainSaveParams`` takes precedence over the driver-wide setting. * qemu: Added guest load averages to the output of virDomainGetGuestInfo This feature will be available with qemu guest agent 10.0 onwards. * qemu: Add support for multiple iothreads for ``virtio-scsi`` controller It's now possible to map multiple iothreads to the ``virtio-scsi`` controller or even map them to specific virtqueues similarly to the ``virtio-blk`` device allowing for better performance in certain scenarios. * qemu: integrate support for VM shutdown on host shutdown It is now possible to instruct the QEMU driver to automatically perform managed save, graceful shutdown, or hard poweroff on running VMs, when a host shutdown is requested. This feature is intended to eventually replace usage of the libvirt-guests script. The new approach improves on the libvirt-guests script, by proactively monitoring logind for a signal that a host shutdown has been requested. It will initiate the chosen action on running guests immediately, allowing shutdown inhibitors to be released sooner. The new solution is also able to iteratively try multiple actions until one of them succeeds in shutting down the VM. Since it must be mutually exclusive with the libvirt-guests script, this feature currently requires a manual opt-in through editing of the /etc/libvirt/qemu.conf configuration file. The libvirt-guests script must be disabled before doing this. * qemu: Add 'sparse' as a new save image format QEMU's ``file`` migration has been supplemented with the new stream format ``mapped-ram``, where RAM pages are mapped directly to offsets in the migration file. ``mapped-ram`` is now supported by augmenting the existing save image formats with the ``sparse`` format. * qemu: Add support for parallel save/restore The ``sparse`` image format can support reading and writing by multiple channels. ``virDomainSaveParams`` and ``virDomainRestoreParams`` now support specifying the number of IO channels used for parallel save and restore. Using multiple channels can reduce the time required to save and restore domains. * virsh: Introduce new hypervisor-cpu-models command Added a new virsh command ``hypervisor-cpu-models``. The command pulls from the existing domcapabilities XML and uses xpath to parse CPU model strings. By default, only models reported as usable by the hypervisor on the host system are printed. A user may specify ``--all`` to also print models which are not supported on the host. * qemu: Introduce os/shim element For secure boot environments where ``<loader/>`` is signed, it may be unfeasible to keep the binary up to date (esp. when revoking certificates contained within). To address that, new ``<shim/>`` element is introduced which allows hypervisor to side load another UEFI binary, which can then contain new certification authorities and/or list of revocations. * ch: Enable SEV SNP support Cloud Hypervisor guests can be now started with SEV SNP enabled. * qemu: Support for Block Disk Along with Throttle Filters Introduce support for multiple throttle groups per block disk in QEMU, enhancing I/O control and performance optimization. This update builds on the existing throttling functionality by allowing more granular control with the ability to assign different throttle groups to multiple block devices, improving shared throttling across devices. * Improvements * qemu: Improved guest agent corner case error reporting The APIs using the guest agent now report two specific error codes aimed at helping management applications/users to differentiate between timeout while libvirt was synchronizing with the guest agent and timeout after a command was already sent. The new error codes are ``VIR_ERR_AGENT_COMMAND_TIMEOUT`` and ``VIR_ERR_AGENT_COMMAND_FAILED``. * qemu: Use common check for shared memory use for ``vhost-user`` network devices Historically libvirt printed only a warning if the ``vhost-user`` network was misconfigured. Since we enforce proper configuration for other device types using ``vhost-user`` it is now enforced also for network devices and prints an actual error on misconfiguration. * Introduce constants for discoverability of entries in bulk stats APIs Libvirt introduced constants exposed by our API description XML which allows discoverability of new entries in typed parameter names returned by ``virConnectGetAllDomainStats``, ``virDomainListGetStats``, and ``virDomainGetGuestInfo``. * qemu: Reflect MAC address change in live domain XML When a guest changes MAC address on one of its vNICs the new MAC address is now visible in the live XML under ``currentAddress`` attribute of ``<mac/>`` element. At the same time, ``VIR_DOMAIN_EVENT_ID_NIC_MAC_CHANGE`` event is emitted so that management applications can update their internal state. * Bug fixes * qemu: attach virtio-mem with CCW address Attaching a virtio-mem device on s390 without an address type now gets a default type CCW address assigned. A specified CCW address is now used for the virtio-mem device instead of getting overwritten by a PCI address. * ch: Various memory leak fixes There were some memory leaks identified in the Cloud Hypervisor driver. They are fixed now. Enjoy. Jirka

1 0

[libvirt PATCH 0/7] Deprecate the QEMU driver
by Ján Tomko 01 Apr '25

01 Apr '25

See patch 3/7 (7/3 for Americans) for the reasoning Ján Tomko (7): Add a copy of the Sandwich license remote: do not generate the qemu protocol header Deprecate the QEMU driver meson: remove all references to QEMU Remove src/qemu/ tests: remove qemu NEWS: Document the QEMU driver removal COPYING.Sandwich | 6 + NEWS.rst | 64 +- docs/html/meson.build | 2 +- docs/manpages/meson.build | 4 - docs/meson.build | 7 +- libvirt.spec.in | 2 +- meson.build | 97 +- src/meson.build | 64 +- src/qemu/libvirt-qemu.sysusers.conf | 4 - src/qemu/libvirt_qemu_probes.d | 22 - [...] src/qemu/qemu_shim.c | 418 - src/qemu/qemu_slirp.c | 348 - src/qemu/qemu_slirp.h | 72 - src/qemu/qemu_snapshot.c | 4661 -- src/qemu/qemu_snapshot.h | 91 - src/qemu/qemu_tpm.c | 1377 - src/qemu/qemu_tpm.h | 70 - src/qemu/qemu_validate.c | 5616 -- src/qemu/qemu_validate.h | 46 - src/qemu/qemu_vhost_user.c | 512 - src/qemu/qemu_vhost_user.h | 59 - src/qemu/qemu_vhost_user_gpu.c | 251 - src/qemu/qemu_vhost_user_gpu.h | 48 - src/qemu/qemu_virtiofs.c | 481 - src/qemu/qemu_virtiofs.h | 45 - src/qemu/test_libvirtd_qemu.aug.in | 138 - src/qemu/virtqemud.init.in | 26 - src/qemu/virtqemud.service.extra.in | 18 - src/qemu/virtqemud.socket.extra.in | 2 - src/remote/meson.build | 12 +- src/remote/qemu_protocol.h | 23 + src/security/apparmor/meson.build | 4 +- tests/meson.build | 101 - tests/qemuagentdata/fsinfo.xml | 39 - tests/qemuagenttest.c | 1442 - tests/qemublocktest.c | 1395 - .../backupmerge/basic-deep-out.json | 25 - .../backupmerge/basic-flat-out.json | 25 - .../backupmerge/basic-intermediate-out.json | 25 - .../backupmerge/empty-out.json | 1 - .../backupmerge/snapshots-deep-out.json | 41 - tests/qemuxmlconfdata/x86_64-pc-graphics.xml | 56 - [...] .../x86_64-pc-headless.x86_64-latest.args | 48 - .../x86_64-pc-headless.x86_64-latest.xml | 78 - tests/qemuxmlconfdata/x86_64-pc-headless.xml | 51 - ...4-pc-minimal.x86_64-latest.abi-update.args | 33 - ...64-pc-minimal.x86_64-latest.abi-update.xml | 31 - .../x86_64-pc-minimal.x86_64-latest.args | 33 - .../x86_64-pc-minimal.x86_64-latest.xml | 31 - tests/qemuxmlconfdata/x86_64-pc-minimal.xml | 12 - ...fault-models.x86_64-latest.abi-update.args | 47 - ...efault-models.x86_64-latest.abi-update.xml | 71 - ...6_64-q35-default-models.x86_64-latest.args | 47 - ...86_64-q35-default-models.x86_64-latest.xml | 71 - .../x86_64-q35-default-models.xml | 24 - .../x86_64-q35-graphics.x86_64-latest.args | 59 - .../x86_64-q35-graphics.x86_64-latest.xml | 125 - tests/qemuxmlconfdata/x86_64-q35-graphics.xml | 56 - .../x86_64-q35-headless.x86_64-latest.args | 57 - .../x86_64-q35-headless.x86_64-latest.xml | 117 - tests/qemuxmlconfdata/x86_64-q35-headless.xml | 51 - ...-q35-minimal.x86_64-latest.abi-update.args | 38 - ...4-q35-minimal.x86_64-latest.abi-update.xml | 50 - .../x86_64-q35-minimal.x86_64-latest.args | 38 - .../x86_64-q35-minimal.x86_64-latest.xml | 50 - tests/qemuxmlconfdata/x86_64-q35-minimal.xml | 12 - tests/qemuxmlconftest.c | 3032 -- tools/meson.build | 16 - tools/wireshark/src/libvirt/meson.build | 2 - 4381 files changed, 82 insertions(+), 1491066 deletions(-) Tell me, isn't that beautiful? create mode 100644 COPYING.Sandwich delete mode 100644 src/qemu/libvirt-qemu.sysusers.conf delete mode 100644 src/qemu/libvirt_qemu_probes.d delete mode 100644 src/qemu/libvirtd_qemu.aug delete mode 100644 src/qemu/meson.build delete mode 100644 src/qemu/postcopy-migration.sysctl delete mode 100644 src/qemu/qemu.conf.in delete mode 100644 src/qemu/qemu_agent.c delete mode 100644 src/qemu/qemu_agent.h delete mode 100644 src/qemu/qemu_alias.c delete mode 100644 src/qemu/qemu_alias.h delete mode 100644 src/qemu/qemu_backup.c delete mode 100644 src/qemu/qemu_backup.h delete mode 100644 src/qemu/qemu_block.c delete mode 100644 src/qemu/qemu_block.h delete mode 100644 src/qemu/qemu_blockjob.c delete mode 100644 src/qemu/qemu_blockjob.h delete mode 100644 src/qemu/qemu_capabilities.c delete mode 100644 src/qemu/qemu_capabilities.h delete mode 100644 src/qemu/qemu_capspriv.h delete mode 100644 src/qemu/qemu_cgroup.c delete mode 100644 src/qemu/qemu_cgroup.h delete mode 100644 src/qemu/qemu_chardev.c delete mode 100644 src/qemu/qemu_chardev.h delete mode 100644 src/qemu/qemu_checkpoint.c delete mode 100644 src/qemu/qemu_checkpoint.h delete mode 100644 src/qemu/qemu_command.c delete mode 100644 src/qemu/qemu_command.h delete mode 100644 src/qemu/qemu_conf.c delete mode 100644 src/qemu/qemu_conf.h delete mode 100644 src/qemu/qemu_dbus.c delete mode 100644 src/qemu/qemu_dbus.h delete mode 100644 src/qemu/qemu_domain.c delete mode 100644 src/qemu/qemu_domain.h delete mode 100644 src/qemu/qemu_domain_address.c delete mode 100644 src/qemu/qemu_domain_address.h delete mode 100644 src/qemu/qemu_domainjob.c delete mode 100644 src/qemu/qemu_domainjob.h delete mode 100644 src/qemu/qemu_driver.c delete mode 100644 src/qemu/qemu_driver.h delete mode 100644 src/qemu/qemu_extdevice.c delete mode 100644 src/qemu/qemu_extdevice.h delete mode 100644 src/qemu/qemu_fd.c delete mode 100644 src/qemu/qemu_fd.h delete mode 100644 src/qemu/qemu_firmware.c delete mode 100644 src/qemu/qemu_firmware.h delete mode 100644 src/qemu/qemu_hostdev.c delete mode 100644 src/qemu/qemu_hostdev.h delete mode 100644 src/qemu/qemu_hotplug.c delete mode 100644 src/qemu/qemu_hotplug.h delete mode 100644 src/qemu/qemu_interface.c delete mode 100644 src/qemu/qemu_interface.h delete mode 100644 src/qemu/qemu_interop_config.c delete mode 100644 src/qemu/qemu_interop_config.h delete mode 100644 src/qemu/qemu_migration.c delete mode 100644 src/qemu/qemu_migration.h delete mode 100644 src/qemu/qemu_migration_cookie.c delete mode 100644 src/qemu/qemu_migration_cookie.h delete mode 100644 src/qemu/qemu_migration_params.c delete mode 100644 src/qemu/qemu_migration_params.h delete mode 100644 src/qemu/qemu_migration_paramspriv.h delete mode 100644 src/qemu/qemu_monitor.c delete mode 100644 src/qemu/qemu_monitor.h delete mode 100644 src/qemu/qemu_monitor_json.c delete mode 100644 src/qemu/qemu_monitor_json.h delete mode 100644 src/qemu/qemu_monitor_priv.h delete mode 100644 src/qemu/qemu_monitor_text.c delete mode 100644 src/qemu/qemu_monitor_text.h delete mode 100644 src/qemu/qemu_namespace.c delete mode 100644 src/qemu/qemu_namespace.h delete mode 100644 src/qemu/qemu_nbdkit.c delete mode 100644 src/qemu/qemu_nbdkit.h delete mode 100644 src/qemu/qemu_nbdkitpriv.h delete mode 100644 src/qemu/qemu_passt.c delete mode 100644 src/qemu/qemu_passt.h delete mode 100644 src/qemu/qemu_postparse.c delete mode 100644 src/qemu/qemu_postparse.h delete mode 100644 src/qemu/qemu_process.c delete mode 100644 src/qemu/qemu_process.h delete mode 100644 src/qemu/qemu_processpriv.h delete mode 100644 src/qemu/qemu_qapi.c delete mode 100644 src/qemu/qemu_qapi.h delete mode 100644 src/qemu/qemu_rdp.c delete mode 100644 src/qemu/qemu_rdp.h delete mode 100644 src/qemu/qemu_saveimage.c delete mode 100644 src/qemu/qemu_saveimage.h delete mode 100644 src/qemu/qemu_security.c delete mode 100644 src/qemu/qemu_security.h delete mode 100644 src/qemu/qemu_shim.c delete mode 100644 src/qemu/qemu_slirp.c delete mode 100644 src/qemu/qemu_slirp.h delete mode 100644 src/qemu/qemu_snapshot.c delete mode 100644 src/qemu/qemu_snapshot.h delete mode 100644 src/qemu/qemu_tpm.c delete mode 100644 src/qemu/qemu_tpm.h delete mode 100644 src/qemu/qemu_validate.c delete mode 100644 src/qemu/qemu_validate.h delete mode 100644 src/qemu/qemu_vhost_user.c delete mode 100644 src/qemu/qemu_vhost_user.h delete mode 100644 src/qemu/qemu_vhost_user_gpu.c delete mode 100644 src/qemu/qemu_vhost_user_gpu.h delete mode 100644 src/qemu/qemu_virtiofs.c delete mode 100644 src/qemu/qemu_virtiofs.h delete mode 100644 src/qemu/test_libvirtd_qemu.aug.in delete mode 100644 src/qemu/virtqemud.init.in delete mode 100644 src/qemu/virtqemud.service.extra.in delete mode 100644 src/qemu/virtqemud.socket.extra.in create mode 100644 src/remote/qemu_protocol.h delete mode 100644 tests/qemuagentdata/fsinfo.xml delete mode 100644 tests/qemuagenttest.c delete mode 100644 tests/qemublocktest.c delete mode 100644 tests/qemublocktestdata/backupmerge/basic-deep-out.json delete mode 100644 tests/qemublocktestdata/backupmerge/basic-flat-out.json delete mode 100644 tests/qemublocktestdata/backupmerge/basic-intermediate-out.json delete mode 100644 tests/qemublocktestdata/backupmerge/empty-out.json delete mode 100644 tests/qemublocktestdata/backupmerge/snapshots-deep-out.json delete mode 100644 tests/qemublocktestdata/backupmerge/snapshots-flat-out.json delete mode 100644 tests/qemublocktestdata/backupmerge/snapshots-intermediate-out.json [...] delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-default-models.x86_64-latest.args delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-default-models.x86_64-latest.xml delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-default-models.xml delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-graphics.x86_64-latest.args delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-graphics.x86_64-latest.xml delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-graphics.xml delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-headless.x86_64-latest.args delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-headless.x86_64-latest.xml delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-headless.xml delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-minimal.x86_64-latest.abi-update.args delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-minimal.x86_64-latest.abi-update.xml delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-minimal.x86_64-latest.args delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-minimal.x86_64-latest.xml delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-minimal.xml delete mode 100644 tests/qemuxmlconftest.c -- 2.49.0

2 8

[PATCH 0/8] Support FD passing for the NBD server socket used for backup
by Peter Krempa 01 Apr '25

01 Apr '25

See 6/8 for justification. Peter Krempa (8): virDomainStorageNetworkParseHost: Remove unpopulated 'transport' variable virDomainStorageNetworkParseHost: Refactor cleanup conf: Introduce VIR_STORAGE_NET_HOST_TRANS_FD virStorageNetHostDefClear: Move into virStorageNetHostDefFree qemu: monitor: Support FD passing of sockets to 'qemuMonitorJSONNBDServerStart' backup: Add support for passing server socket file descriptor to backup NBD server tests: domainbackupxml2xml: Add test case for pull-mode backup with NBD transport='fd' qemu: monitor: Improve field annotations in QEMU_CHECK_MONITOR docs/formatbackup.rst | 21 +++++ src/conf/backup_conf.c | 3 +- src/conf/domain_conf.c | 93 ++++++++++++------- src/conf/domain_conf.h | 3 +- src/conf/schemas/domainbackup.rng | 6 ++ src/conf/storage_source_conf.c | 20 ++-- src/conf/storage_source_conf.h | 7 +- src/libvirt_private.syms | 1 - src/qemu/qemu_backup.c | 28 ++++++ src/qemu/qemu_block.c | 1 + src/qemu/qemu_monitor.c | 2 +- src/qemu/qemu_monitor_json.c | 21 +++++ .../storage_file_backend_gluster.c | 1 + .../domainbackupxml2xmlin/backup-pull-fd.xml | 22 +++++ .../domainbackupxml2xmlout/backup-pull-fd.xml | 23 +++++ tests/genericxml2xmltest.c | 1 + 16 files changed, 198 insertions(+), 55 deletions(-) create mode 100644 tests/domainbackupxml2xmlin/backup-pull-fd.xml create mode 100644 tests/domainbackupxml2xmlout/backup-pull-fd.xml -- 2.49.0

2 12

Re: [PATCH RESEND 0/6] Add support for configuring PCI high memory MMIO size
by Matt Ochs 31 Mar '25

31 Mar '25

Gentle ping. Is there any feedback, comment, or suggestion about this series? -matt

1 0

[PATCH] virt-aa-helper: delete dynamic files
by Alessandro 31 Mar '25

31 Mar '25

We attempted multiple ways to clean up dynamic files; however, we must preserve user overrides, which requires keeping the file /etc/apparmor.d/libvirt/libvirt-uuid This commit proposes to move user overrides into /etc/apparmor.d/libvirt/libvirt-uuid.local and include it, if present, unconditionally. When we stop the domain, we remove libvirt.uuid and libvirt-uuid.files, whereas we preserve libvirt-uuid.local if present. Applying the patch, it produces the following: root@virt-hv-lab002:/etc/apparmor.d/libvirt# ls -1 libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033* libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033 libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033.files root@virt-hv-lab002:/etc/apparmor.d/libvirt# cat libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033 profile libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033 flags=(attach_disconnected) { #include <abstractions/libvirt-qemu> #include if exists <libvirt/libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033.files> #include if exists <libvirt/libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033.local> } root@virt-hv-lab002:/etc/apparmor.d/libvirt# cat libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033.files "/var/log/libvirt/**/testing-9a4be628.log" w, "/var/lib/libvirt/qemu/domain-testing-9a4be628/monitor.sock" rw, "/var/lib/libvirt/qemu/domain-4-testing-9a4be628/*" rw, "/var/run/libvirt/**/testing-9a4be628.pid" rwk, "/var/run/libvirt/**/*.tunnelmigrate.dest.testing-9a4be628" rw, "/var/lib/libvirt/images/testing-9a4be628.qcow2" rwk, "/var/lib/libvirt/images/noble-server-cloudimg-amd64.img" rk, # don't audit writes to readonly files deny "/var/lib/libvirt/images/noble-server-cloudimg-amd64.img" w, "/var/lib/libvirt/images/testing-9a4be628-ds.qcow2" rwk, "/usr/share/OVMF/OVMF_CODE_4M.fd" rk, # don't audit writes to readonly files deny "/usr/share/OVMF/OVMF_CODE_4M.fd" w, "/var/lib/libvirt/qemu/nvram/testing-9a4be628_VARS.fd" rwk, "/dev/vhost-net" rw, "/var/lib/libvirt/qemu/domain-4-testing-9a4be628/{,**}" rwk, "/run/libvirt/qemu/channel/4-testing-9a4be628/{,**}" rwk, "/var/lib/libvirt/qemu/domain-4-testing-9a4be628/master-key.aes" rwk, "/dev/net/tun" rwk, "/dev/userfaultfd" rwk, Fixes: https://gitlab.com/libvirt/libvirt/-/issues/451 Signed-off-by: Alessandro <alessandro(a)0x65c.net> --- src/security/virt-aa-helper.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 034c042..8f044a1 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -1495,8 +1495,10 @@ main(int argc, char **argv) rc = parserLoad(ctl->uuid); } else if (ctl->cmd == 'R' || ctl->cmd == 'D') { rc = parserRemove(ctl->uuid); - if (ctl->cmd == 'D') + if (ctl->cmd == 'D'){ unlink(include_file); + unlink(profile); + } } else if (ctl->cmd == 'c' || ctl->cmd == 'r') { g_autofree char *included_files = NULL; g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; @@ -1561,12 +1563,15 @@ main(int argc, char **argv) /* create the profile from TEMPLATE */ if (ctl->cmd == 'c' || purged) { g_autofree char *tmp = NULL; + g_autofree char *tmp_local = NULL: #if defined(WITH_APPARMOR_3) const char *ifexists = "if exists "; #else const char *ifexists = ""; #endif tmp = g_strdup_printf(" #include %s<libvirt/%s.files>\n", ifexists, ctl->uuid); + tmp_local = g_strdup_printf(" #include %s<libvirt/%s.local>\n", ifexists, ctl->uuid); + tmp = g_strconcat(tmp,tmp_local, NULL); if (ctl->dryrun) { vah_info(profile); -- 2.49.0

2 2

[PATCH 0/4] ch: timeout fix (GitLab issue #743)
by Kirill Shchetiniuk 31 Mar '25

31 Mar '25

This patch series is supposed to fix the following reported issue on GitLab: virtchd times out even with an active guest running https://gitlab.com/libvirt/libvirt/-/issues/743 During further investigation, we found that there are in fact two bugs: 1. The CH driver does not store any domains' XMLs onto disk, and as a result it does not have any information about running domains when it restarts. Previously, the CH driver did not save any XMLs onto the disk, neither transient nor persistent definitions. To address this issue, add transient domain XML saving when a new domain is defined, as well as saving transient domain XML when a domain starts, to enable reconnecting to running domains when the driver restarts. Now all persistent and transient definitions are stored onto the disk. Also add running domain reconnection helper functions to restore the connection between the driver and running VMM when the driver restarts, to be able to continue work with running domains. 2. Timeout should not be active while a client is connected or there is a running domain. The second bug led to a situation where the CH driver timed out (e.g., --timeout 60) even when some domains were still running. Previously, only an active virsh session prevented the driver from timing out. To address this issue, an inhibitor for the CH driver has been added to prevent the timeout. The inhibitor now stores the count of running domains and prevents the timeout if the count is above zero. NOTE: This series patch series is depend on followin patch series: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/O3SK… Kirill Shchetiniuk (4): ch: add persistent definition save and load ch: add transient definition save and load ch: add reconnection to running domains ch: fix timeout while domain is still running src/ch/ch_conf.c | 10 ++- src/ch/ch_conf.h | 6 ++ src/ch/ch_domain.c | 15 +++++ src/ch/ch_domain.h | 3 + src/ch/ch_driver.c | 49 ++++++++++++++- src/ch/ch_monitor.c | 65 ++++++++++++++++++++ src/ch/ch_monitor.h | 2 + src/ch/ch_process.c | 147 ++++++++++++++++++++++++++++++++++++++++++++ src/ch/ch_process.h | 2 + 9 files changed, 293 insertions(+), 6 deletions(-) -- 2.48.1

1 4

[PATCH v2 0/5] apparmor: assume at least version 3
by Daniel P. Berrangé 31 Mar '25

31 Mar '25

In v2: - Do upfront check for apparmor >= 3.0.0 - Add further revert commit Daniel P. Berrangé (5): meson: mandate apparmor >= 3.0.0 apparmor: assume at least apparmor >= 3 Revert "apparmor: Allow version-specific bits in abstractions too" Revert "apparmor: Allow version-specific bits in profiles" meson: drop remaining checks for apparmor version meson.build | 7 +- .../apparmor/{libvirt-lxc.in => libvirt-lxc} | 2 - .../{libvirt-qemu.in => libvirt-qemu} | 4 -- src/security/apparmor/meson.build | 64 ++----------------- .../usr.lib.libvirt.virt-aa-helper.in | 5 -- src/security/apparmor/usr.sbin.libvirtd.in | 2 - src/security/apparmor/usr.sbin.virtqemud.in | 2 - src/security/apparmor/usr.sbin.virtxend.in | 2 - src/security/virt-aa-helper.c | 9 +-- 9 files changed, 10 insertions(+), 87 deletions(-) rename src/security/apparmor/{libvirt-lxc.in => libvirt-lxc} (99%) rename src/security/apparmor/{libvirt-qemu.in => libvirt-qemu} (99%) -- 2.48.1

2 6

[PATCH 0/3] apparmor: assume at least version 3
by Daniel P. Berrangé 31 Mar '25

31 Mar '25

Daniel P. Berrangé (3): apparmor: assume at least apparmor >= 3 Revert "apparmor: Allow version-specific bits in profiles" meson: drop remaining checks for apparmor version meson.build | 3 -- src/security/apparmor/libvirt-lxc.in | 2 - src/security/apparmor/libvirt-qemu.in | 4 -- src/security/apparmor/meson.build | 45 +------------------ .../usr.lib.libvirt.virt-aa-helper.in | 5 --- src/security/apparmor/usr.sbin.libvirtd.in | 2 - src/security/apparmor/usr.sbin.virtqemud.in | 2 - src/security/apparmor/usr.sbin.virtxend.in | 2 - src/security/virt-aa-helper.c | 9 +--- 9 files changed, 3 insertions(+), 71 deletions(-) -- 2.48.1

2 6

[PATCH v2 0/1] NEWS: qemu: Support for Block Disk Along with Throttle Filters
by Harikumar Rajkumar 31 Mar '25

31 Mar '25

NEWS: qemu: Support for Block Disk Along with Throttle Filters Harikumar Rajkumar (1): NEWS: qemu: support block disk along with throttle filters NEWS.rst | 8 ++++++++ 1 file changed, 8 insertions(+) -- 2.48.1

2 4

[PATCH] virDomainDiskDefValidateSourceChainOne: Fix validation of 'data-file' nesting
by Peter Krempa 28 Mar '25

28 Mar '25

From: Peter Krempa <pkrempa(a)redhat.com> As the 'dataStore' is internally represented as a virStorageSource object it has provisions for nesting which is not supported. When I've reviewed and modified the commit adding data file parsing support I've added code that was supposed to reject any 'backingStore' and 'dataStore' structures nested in a source of a 'dataStore'. Unfortunately the check was broken as one of the terms checked the presence of parent's 'backingStore' instead of the nesting. Fix it and add tests. Fixes: b3171cf8da3 Resolves: https://issues.redhat.com/browse/RHEL-85320 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/conf/domain_validate.c | 2 +- ...sk-qcow2-datafile-store.x86_64-latest.args | 43 +++++++++++-------- ...isk-qcow2-datafile-store.x86_64-latest.xml | 22 +++++++++- .../disk-qcow2-datafile-store.xml | 19 ++++++++ 4 files changed, 66 insertions(+), 20 deletions(-) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 396d1e400a..d0d4bc0bf4 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -562,7 +562,7 @@ virDomainDiskDefValidateSourceChainOne(const virStorageSource *src) return -1; } - if (src->dataFileStore->dataFileStore || src->backingStore) { + if (src->dataFileStore->dataFileStore || src->dataFileStore->backingStore) { virReportError(VIR_ERR_XML_ERROR, "%s", _("The <source> of <dataStore> can't have another nested <dataStore> or <backingStore> element")); return -1; diff --git a/tests/qemuxmlconfdata/disk-qcow2-datafile-store.x86_64-latest.args b/tests/qemuxmlconfdata/disk-qcow2-datafile-store.x86_64-latest.args index 5a64246af6..74f2d1a090 100644 --- a/tests/qemuxmlconfdata/disk-qcow2-datafile-store.x86_64-latest.args +++ b/tests/qemuxmlconfdata/disk-qcow2-datafile-store.x86_64-latest.args @@ -27,25 +27,32 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.config \ -no-shutdown \ -boot strict=on \ -device '{"driver":"piix3-usb-uhci","id":"usb","bus":"pci.0","addr":"0x1.0x2"}' \ --blockdev '{"driver":"file","filename":"/tmp/data-file-store","node-name":"libvirt-9-storage","read-only":false}' \ --blockdev '{"driver":"nbd","server":{"type":"unix","path":"/path/to/sock"},"export":"Volume2/Image","node-name":"libvirt-8-storage","auto-read-only":true,"discard":"unmap"}' \ +-blockdev '{"driver":"file","filename":"/tmp/data-file-store","node-name":"libvirt-13-storage","read-only":false}' \ +-blockdev '{"driver":"nbd","server":{"type":"unix","path":"/path/to/sock"},"export":"Volume2/Image","node-name":"libvirt-12-storage","auto-read-only":true,"discard":"unmap"}' \ +-blockdev '{"node-name":"libvirt-12-format","read-only":false,"driver":"qcow2","data-file":"libvirt-13-storage","file":"libvirt-12-storage"}' \ +-device '{"driver":"virtio-blk-pci","bus":"pci.0","addr":"0x2","drive":"libvirt-12-format","id":"virtio-disk0","bootindex":1}' \ +-blockdev '{"driver":"host_device","filename":"/dev/HostVG/QEMUGuest1","node-name":"libvirt-11-storage","read-only":false}' \ +-blockdev '{"driver":"nbd","server":{"type":"unix","path":"/var/run/nbdsock"},"export":"bar","node-name":"libvirt-10-storage","auto-read-only":true,"discard":"unmap"}' \ +-blockdev '{"node-name":"libvirt-10-format","read-only":false,"driver":"qcow2","data-file":"libvirt-11-storage","file":"libvirt-10-storage"}' \ +-device '{"driver":"virtio-blk-pci","bus":"pci.0","addr":"0x3","drive":"libvirt-10-format","id":"virtio-disk1"}' \ +-blockdev '{"driver":"nbd","server":{"type":"unix","path":"/path/to/sock/datafile"},"export":"Volume2/ImageDataFile","node-name":"libvirt-9-storage","read-only":false}' \ +-blockdev '{"driver":"file","filename":"/var/lib/libvirt/images/rhel7.1484071879","node-name":"libvirt-8-storage","auto-read-only":true,"discard":"unmap"}' \ -blockdev '{"node-name":"libvirt-8-format","read-only":false,"driver":"qcow2","data-file":"libvirt-9-storage","file":"libvirt-8-storage"}' \ --device '{"driver":"virtio-blk-pci","bus":"pci.0","addr":"0x2","drive":"libvirt-8-format","id":"virtio-disk0","bootindex":1}' \ --blockdev '{"driver":"host_device","filename":"/dev/HostVG/QEMUGuest1","node-name":"libvirt-7-storage","read-only":false}' \ --blockdev '{"driver":"nbd","server":{"type":"unix","path":"/var/run/nbdsock"},"export":"bar","node-name":"libvirt-6-storage","auto-read-only":true,"discard":"unmap"}' \ --blockdev '{"node-name":"libvirt-6-format","read-only":false,"driver":"qcow2","data-file":"libvirt-7-storage","file":"libvirt-6-storage"}' \ --device '{"driver":"virtio-blk-pci","bus":"pci.0","addr":"0x3","drive":"libvirt-6-format","id":"virtio-disk1"}' \ --blockdev '{"driver":"nbd","server":{"type":"unix","path":"/path/to/sock/datafile"},"export":"Volume2/ImageDataFile","node-name":"libvirt-5-storage","read-only":false}' \ --blockdev '{"driver":"file","filename":"/var/lib/libvirt/images/rhel7.1484071879","node-name":"libvirt-4-storage","auto-read-only":true,"discard":"unmap"}' \ --blockdev '{"node-name":"libvirt-4-format","read-only":false,"driver":"qcow2","data-file":"libvirt-5-storage","file":"libvirt-4-storage"}' \ --device '{"driver":"virtio-blk-pci","bus":"pci.0","addr":"0x4","drive":"libvirt-4-format","id":"virtio-disk2"}' \ --blockdev '{"driver":"file","filename":"/tmp/data-file-store-2","node-name":"libvirt-3-storage","read-only":true}' \ --blockdev '{"driver":"file","filename":"/var/lib/libvirt/images/rhel7.1484071877","node-name":"libvirt-2-storage","auto-read-only":true,"discard":"unmap"}' \ --blockdev '{"node-name":"libvirt-2-format","read-only":true,"driver":"qcow2","data-file":"libvirt-3-storage","file":"libvirt-2-storage"}' \ --blockdev '{"driver":"file","filename":"/var/lib/libvirt/images/rhel7.1484071880","node-name":"libvirt-1-storage","auto-read-only":true,"discard":"unmap"}' \ --blockdev '{"node-name":"libvirt-1-format","read-only":false,"driver":"qcow2","file":"libvirt-1-storage","backing":"libvirt-2-format"}' \ --device '{"driver":"virtio-blk-pci","bus":"pci.0","addr":"0x5","drive":"libvirt-1-format","id":"virtio-disk3"}' \ +-device '{"driver":"virtio-blk-pci","bus":"pci.0","addr":"0x4","drive":"libvirt-8-format","id":"virtio-disk2"}' \ +-blockdev '{"driver":"file","filename":"/tmp/data-file-store-2","node-name":"libvirt-7-storage","read-only":true}' \ +-blockdev '{"driver":"file","filename":"/var/lib/libvirt/images/rhel7.1484071877","node-name":"libvirt-6-storage","auto-read-only":true,"discard":"unmap"}' \ +-blockdev '{"node-name":"libvirt-6-format","read-only":true,"driver":"qcow2","data-file":"libvirt-7-storage","file":"libvirt-6-storage"}' \ +-blockdev '{"driver":"file","filename":"/var/lib/libvirt/images/rhel7.1484071880","node-name":"libvirt-5-storage","auto-read-only":true,"discard":"unmap"}' \ +-blockdev '{"node-name":"libvirt-5-format","read-only":false,"driver":"qcow2","file":"libvirt-5-storage","backing":"libvirt-6-format"}' \ +-device '{"driver":"virtio-blk-pci","bus":"pci.0","addr":"0x5","drive":"libvirt-5-format","id":"virtio-disk3"}' \ +-blockdev '{"driver":"file","filename":"/var/lib/libvirt/images/datastore_1","aio":"native","node-name":"libvirt-4-storage","read-only":true,"discard":"unmap","cache":{"direct":true,"no-flush":false}}' \ +-blockdev '{"driver":"file","filename":"/var/lib/libvirt/images/base-with-data-file.qcow","aio":"native","node-name":"libvirt-3-storage","auto-read-only":true,"discard":"unmap","cache":{"direct":true,"no-flush":false}}' \ +-blockdev '{"node-name":"libvirt-3-format","read-only":true,"discard":"unmap","cache":{"direct":true,"no-flush":false},"driver":"qcow2","data-file":"libvirt-4-storage","file":"libvirt-3-storage"}' \ +-blockdev '{"driver":"file","filename":"/var/lib/libvirt/images/datastore_2","aio":"native","node-name":"libvirt-2-storage","read-only":false,"discard":"unmap","cache":{"direct":true,"no-flush":false}}' \ +-blockdev '{"driver":"file","filename":"/var/lib/libvirt/images/datastore.qcow2","aio":"native","node-name":"libvirt-1-storage","auto-read-only":true,"discard":"unmap","cache":{"direct":true,"no-flush":false}}' \ +-blockdev '{"node-name":"libvirt-1-format","read-only":false,"discard":"unmap","cache":{"direct":true,"no-flush":false},"driver":"qcow2","data-file":"libvirt-2-storage","file":"libvirt-1-storage","backing":"libvirt-3-format"}' \ +-device '{"driver":"virtio-blk-pci","bus":"pci.0","addr":"0x6","drive":"libvirt-1-format","id":"virtio-disk4","write-cache":"on"}' \ -audiodev '{"id":"audio1","driver":"none"}' \ --device '{"driver":"virtio-balloon-pci","id":"balloon0","bus":"pci.0","addr":"0x6"}' \ +-device '{"driver":"virtio-balloon-pci","id":"balloon0","bus":"pci.0","addr":"0x7"}' \ -sandbox on,obsolete=deny,elevateprivileges=deny,spawn=deny,resourcecontrol=deny \ -msg timestamp=on diff --git a/tests/qemuxmlconfdata/disk-qcow2-datafile-store.x86_64-latest.xml b/tests/qemuxmlconfdata/disk-qcow2-datafile-store.x86_64-latest.xml index a026749faf..a4bfcb29e0 100644 --- a/tests/qemuxmlconfdata/disk-qcow2-datafile-store.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/disk-qcow2-datafile-store.x86_64-latest.xml @@ -69,6 +69,26 @@ <target dev='vdd' bus='virtio'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/> </disk> + <disk type='file' device='disk'> + <driver name='qemu' type='qcow2' cache='none' io='native' discard='unmap'/> + <source file='/var/lib/libvirt/images/datastore.qcow2'> + <dataStore type='file'> + <format type='raw'/> + <source file='/var/lib/libvirt/images/datastore_2'/> + </dataStore> + </source> + <backingStore type='file'> + <format type='qcow2'/> + <source file='/var/lib/libvirt/images/base-with-data-file.qcow'> + <dataStore type='file'> + <format type='raw'/> + <source file='/var/lib/libvirt/images/datastore_1'/> + </dataStore> + </source> + </backingStore> + <target dev='vde' bus='virtio'/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x06' function='0x0'/> + </disk> <controller type='usb' index='0' model='piix3-uhci'> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x2'/> </controller> @@ -77,7 +97,7 @@ <input type='keyboard' bus='ps2'/> <audio id='1' type='none'/> <memballoon model='virtio'> - <address type='pci' domain='0x0000' bus='0x00' slot='0x06' function='0x0'/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x07' function='0x0'/> </memballoon> </devices> </domain> diff --git a/tests/qemuxmlconfdata/disk-qcow2-datafile-store.xml b/tests/qemuxmlconfdata/disk-qcow2-datafile-store.xml index dff5f15158..9f2671a3e7 100644 --- a/tests/qemuxmlconfdata/disk-qcow2-datafile-store.xml +++ b/tests/qemuxmlconfdata/disk-qcow2-datafile-store.xml @@ -62,6 +62,25 @@ </backingStore> <target dev='vdd' bus='virtio'/> </disk> + <disk type='file' device='disk'> + <driver name='qemu' type='qcow2' cache='none' io='native' discard='unmap'/> + <source file='/var/lib/libvirt/images/datastore.qcow2'> + <dataStore type='file'> + <format type='raw'/> + <source file='/var/lib/libvirt/images/datastore_2'/> + </dataStore> + </source> + <backingStore type='file'> + <format type='qcow2'/> + <source file='/var/lib/libvirt/images/base-with-data-file.qcow'> + <dataStore type='file'> + <format type='raw'/> + <source file='/var/lib/libvirt/images/datastore_1'/> + </dataStore> + </source> + </backingStore> + <target dev='vde' bus='virtio'/> + </disk> <controller type='usb' index='0'/> <controller type='pci' index='0' model='pci-root'/> <memballoon model='virtio'/> -- 2.49.0

2 1

Plans for 11.2.0 release (freeze on Tuesday 25 Mar)
by Jiri Denemark 28 Mar '25

28 Mar '25

We are getting close to 11.2.0 release of libvirt. To aim for the release on Tuesday 01 Apr I suggest entering the freeze on Tuesday 25 Mar and tagging RC2 on Friday 28 Mar. I hope this works for everyone. Jirka

1 1

[PATCH] NEWS: Document features/improvements/bug fixes I've participated in
by Michal Privoznik 28 Mar '25

28 Mar '25

From: Michal Privoznik <mprivozn(a)redhat.com> There are some features/improvements/bug fixes I've either contributed or reviewed/merged. Document them for upcoming release. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- NEWS.rst | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 18d45656b8..cd5ec4eab2 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -75,6 +75,18 @@ v11.2.0 (unreleased) system are printed. A user may specify ``--all`` to also print models which are not supported on the host. + * qemu: Introduce os/shim element + + For secure boot environments where ``<loader/>`` is signed, it may be + unfeasible to keep the binary up to date (esp. when revoking certificates + contained within). To address that, new ``<shim/>`` element is introduced + which allows hypervisor to side load another UEFI binary, which can then + contain new certification authorities and/or list of revocations. + + * ch: Enable SEV SNP support + + Cloud Hypervisor guests can be now started with SEV SNP enabled. + * **Improvements** * qemu: Improved guest agent corner case error reporting @@ -87,6 +99,14 @@ v11.2.0 (unreleased) The new error codes are ``VIR_ERR_AGENT_COMMAND_TIMEOUT`` and ``VIR_ERR_AGENT_COMMAND_FAILED``. + * qemu: Reflect MAC address change in live domain XML + + When a guest changes MAC address on one of its vNICs the new MAC address is + now visible in the live XML under ``currentAddress`` attribute of + ``<mac/>`` element. At the same time, + ``VIR_DOMAIN_EVENT_ID_NIC_MAC_CHANGE`` event is emitted so that management + applications can update their internal state. + * **Bug fixes** * qemu: attach virtio-mem with CCW address @@ -95,6 +115,11 @@ v11.2.0 (unreleased) default type CCW address assigned. A specified CCW address is now used for the virtio-mem device instead of getting overwritten by a PCI address. + * ch: Various memory leak fixes + + There were some memory leaks identified in the Cloud Hypervisor driver. + They are fixed now. + v11.1.0 (2025-03-03) ==================== -- 2.48.1

2 1

[PATCH] esxConnectListAllDomains: Don't propagate failure to lookup a single domain
by Peter Krempa 26 Mar '25

26 Mar '25

From: Peter Krempa <pkrempa(a)redhat.com> In esxConnectListAllDomains if the lookup of the VM name and UUID fails for a single VM (possible e.g. with broken storage) the whole API would return failure even when there are working VMs. Rework the lookup so that if a subset fails we ignore the failure on those. We report an error only if lookup of all of the objects failed. Failure is reported from the last one. Resolves: https://issues.redhat.com/browse/RHEL-80606 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/esx/esx_driver.c | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index 554fb3e18f..d869481698 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -4792,18 +4792,21 @@ esxConnectListAllDomains(virConnectPtr conn, virtualMachine = virtualMachine->_next) { g_autofree char *name = NULL; - if (needIdentity) { - if (esxVI_GetVirtualMachineIdentity(virtualMachine, &id, - &name, uuid) < 0) { + /* If the lookup of the required properties fails for some of the machines + * in the list it's preferrable to return the valid objects instead of + * failing outright */ + if ((needIdentity && esxVI_GetVirtualMachineIdentity(virtualMachine, &id, &name, uuid) < 0) || + (needPowerState && esxVI_GetVirtualMachinePowerState(virtualMachine, &powerState) < 0)) { + + /* Raise error from last lookup if we didn't successfuly fetch any + * domain objecst yet */ + if (count == 0 && !virtualMachine->_next) goto cleanup; - } - } - if (needPowerState) { - if (esxVI_GetVirtualMachinePowerState(virtualMachine, - &powerState) < 0) { - goto cleanup; - } + /* failure to fetch information of a single VM must not interrupt + * the lookup of the rest */ + virResetLastError(); + continue; } /* filter by active state */ -- 2.49.0

2 3

[PATCH] NEWS: Mention bump to qemu-6.2, vhost-user shmem check and stats params discoverabilty
by Peter Krempa 26 Mar '25

26 Mar '25

From: Peter Krempa <pkrempa(a)redhat.com> Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 18d45656b8..2855ec77e4 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -15,6 +15,11 @@ v11.2.0 (unreleased) * **Removed features** + * Remove support for qemu-6.1 and older + + Libvirt now requires *qemu-6.2* or newer based on our platform support + policy. + * **New features** * qemu: Add new 'image_format' parameter to virDomainSaveParams @@ -87,6 +92,21 @@ v11.2.0 (unreleased) The new error codes are ``VIR_ERR_AGENT_COMMAND_TIMEOUT`` and ``VIR_ERR_AGENT_COMMAND_FAILED``. + * qemu: Use common check for shared memory use for ``vhost-user`` network devices + + Historically libvirt printed only a warning if the ``vhost-user`` network + was misconfigured. Since we enforce proper configuration for other device + types using ``vhost-user`` it is now enforced also for network devices and + prints an actual error on misconfiguration. + + + * Introduce constants for discoverability of entries in bulk stats APIs + + Libvirt introduced constants exposed by our API description XML which allows + discoverability of new entries in typed parameter names returned by + ``virConnectGetAllDomainStats``, ``virDomainListGetStats``, and + ``virDomainGetGuestInfo``. + * **Bug fixes** * qemu: attach virtio-mem with CCW address -- 2.49.0

2 1

[PATCH V4 00/18] qemu: support mapped-ram+directio+mulitfd
by Jim Fehlig 25 Mar '25

25 Mar '25

V4 series adding support for QEMU's mapped-ram stream format [1] and migration capability. The use of mapped-ram is controlled by extending save_image_format setting in qemu.conf with a new 'sparse' option. The 'raw' format continues to be the default. Also included are patches that leverage mapped-ram to add support for parallel save/restore. Changes in V4: * Rebased on latest master, including the series "qemu: Support specifying save image format" V1: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/MNB… V2: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/GNJ… V3: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/SK2… [1] https://gitlab.com/qemu-project/qemu/-/blob/master/docs/devel/migration/map… Claudio Fontana (3): include: Define constants for parallel save/restore tools: add parallel parameter to virsh save command tools: add parallel parameter to virsh restore command Jim Fehlig (15): lib: virDomain{Save,Restore}Params: Ensure absolute path qemu: Add function to get FDPass object from monitor qemu: Add function to check capability in migration params qemu: Add function to get bool value from migration params qemu: Add mapped-ram migration capability qemu: Add function to get migration params for save qemu_saveimage: add "sparse" to supported save image formats qemu: Add helper function for creating save image fd qemu: Add support for mapped-ram on save qemu: Move creation of qemuProcessIncomingDef struct qemu: Apply migration parameters in qemuMigrationDstRun qemu: Add support for mapped-ram on restore qemu: Support O_DIRECT with mapped-ram on save qemu: Support O_DIRECT with mapped-ram on restore qemu: Add support for parallel save and restore docs/manpages/virsh.rst | 21 +++- include/libvirt/libvirt-domain.h | 11 ++ src/libvirt-domain.c | 92 +++++++++++--- src/qemu/qemu.conf.in | 9 +- src/qemu/qemu_driver.c | 78 +++++++++--- src/qemu/qemu_fd.c | 46 +++++++ src/qemu/qemu_fd.h | 4 + src/qemu/qemu_migration.c | 204 ++++++++++++++++++++++--------- src/qemu/qemu_migration.h | 10 +- src/qemu/qemu_migration_params.c | 92 ++++++++++++++ src/qemu/qemu_migration_params.h | 17 +++ src/qemu/qemu_monitor.c | 37 ++++++ src/qemu/qemu_monitor.h | 5 + src/qemu/qemu_process.c | 100 ++++++++++----- src/qemu/qemu_process.h | 19 ++- src/qemu/qemu_saveimage.c | 120 ++++++++++++------ src/qemu/qemu_saveimage.h | 4 + src/qemu/qemu_snapshot.c | 15 ++- tools/virsh-domain.c | 81 ++++++++++-- 19 files changed, 775 insertions(+), 190 deletions(-) -- 2.43.0

3 45

Entering freeze for libvirt-11.2.0
by Jiri Denemark 25 Mar '25

25 Mar '25

I have just tagged v11.2.0-rc1 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Thanks, Jirka

1 0

[PATCH] NEWS: Mention virsh hypervisor-cpu-models command
by Boris Fiuczynski 25 Mar '25

25 Mar '25

Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com> --- NEWS.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 1fc80e2496..18d45656b8 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -67,6 +67,14 @@ v11.2.0 (unreleased) restore. Using multiple channels can reduce the time required to save and restore domains. + * virsh: Introduce new hypervisor-cpu-models command + + Added a new virsh command ``hypervisor-cpu-models``. The command pulls from + the existing domcapabilities XML and uses xpath to parse CPU model strings. + By default, only models reported as usable by the hypervisor on the host + system are printed. A user may specify ``--all`` to also print models which + are not supported on the host. + * **Improvements** * qemu: Improved guest agent corner case error reporting -- 2.47.0

2 1

[PATCH v3 0/3] Reflect MAC change in live domain XML
by Michal Privoznik 25 Mar '25

25 Mar '25

v3 of: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/MW4… or: https://marc.info/?l=libvir-list&m=174230601829060&w=2 since our list archive is giving me some HTTP error currently. diff to v2: - Rebased (there were some public APIs merged meanwhile, creating a conflict in RPC files), - switched from 'guestAddress' to 'currentAddress'. Michal Prívozník (3): qemu: Reflect MAC address change in live domain XML Introduce NIC_MAC_CHANGE event qemu: Emit NIC_MAC_CHANGE event docs/formatdomain.rst | 5 ++ examples/c/misc/event-test.c | 14 +++++ include/libvirt/libvirt-domain.h | 28 +++++++++ src/conf/domain_conf.c | 6 ++ src/conf/domain_conf.h | 3 + src/conf/domain_event.c | 93 +++++++++++++++++++++++++++++ src/conf/domain_event.h | 12 ++++ src/conf/schemas/domaincommon.rng | 5 ++ src/libvirt_private.syms | 2 + src/qemu/qemu_domain.c | 48 ++++++++++++++- src/qemu/qemu_domain.h | 3 +- src/qemu/qemu_driver.c | 11 ++-- src/qemu/qemu_process.c | 2 +- src/remote/remote_daemon_dispatch.c | 32 ++++++++++ src/remote/remote_driver.c | 34 +++++++++++ src/remote/remote_protocol.x | 16 ++++- src/remote_protocol-structs | 8 +++ tools/virsh-domain-event.c | 20 +++++++ 18 files changed, 334 insertions(+), 8 deletions(-) -- 2.48.1

2 4

[PATCH] docs: add table showing guest IP/DNS/gateway settings when using SLIRP
by Laine Stump 25 Mar '25

25 Mar '25

When using the default SLIRP backend for <interface type='user'>, the <ip address='blah' prefix='blur'/> setting doesn't behave as might be expected (i.e. it doesn't set the guest interface IP/prefix to exactly the provided values). This *should* have created questions when users originally encountered it, but instead it has become more apparent as people are contemplating switching from using the SLIRP backend to using passt instead (with passt, the <ip> settings do behave "as expected"). In order to make this difference in behavior less mysterious, Yalan Zhang kindly took the time to test and document the effect of various representative <ip> settings on guest interface config when SLIRP is used (see https://issues.redhat.com/browse/RHEL-46601) this patch adds that same table to libvirt's documentation. Signed-off-by: Laine Stump <laine(a)redhat.com> --- docs/formatdomain.rst | 69 ++++++++++++++++++++++++++++++++++++------- 1 file changed, 58 insertions(+), 11 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index aae58fab60..a6d0660135 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -5239,15 +5239,7 @@ network address by including an ``ip`` element specifying an IPv4 address in its one mandatory attribute, ``address``. Optionally, a second ``ip`` element with a ``family`` attribute set to "ipv6" can be specified to add an IPv6 address to the interface. ``address``. -Optionally, an address ``prefix`` can be specified. These settings are -surprisingly **not** used by SLIRP to set the exact IP address; -instead they are used to determine what network/subnet the guest's IP -address should be on, and the guest will be given an address in that -subnet, but the host portion of the address will still be "2.15". In -the example below, for example, the guest will be given the IP address -172.17.2.15 (**note that the '1.1' in the host portion of the address -has been ignored**), default route of 172.17.2.2, and DNS server -172.17.2.3. +Optionally, an address ``prefix`` can be specified. :: @@ -5263,6 +5255,59 @@ has been ignored**), default route of 172.17.2.2, and DNS server </devices> ... +These settings are surprisingly **not** used by SLIRP to set the exact +IP address; instead they are used to determine what **network/subnet** +the guest's IP address should be on, and the guest will be given an +address in that subnet, but the host portion of the address will still +be the host portion of "10.0.2.15" (based on the configured prefix (or +a prefix of 24 if no prefix is specified). The DNS and default gateway +addresses given to the guest will be similarly based on the network +portion of the configuration-provided <ip> combined with the host +portion of SLIRPs default settings for DNS/gateway +(10.0.2.3/10.0.2.2). To help resolve the confusion of the previous +sentences, the table below shows examples of the settings that will be +provided to the guest (via a DHCP response) to use for its interface +config (ip/prefix, DNS, default gateway) for various settings of <ip> +element address and prefix in libvirt's <interface type='user'> +config: + +.. list-table:: + :header-rows: 1 + + * - libvirt <ip> element + - guest ip/prefix + - guest DNS + - guest default gateway + + * - (unspecified) + - 10.0.2.15/24 + - 10.0.2.3 + - 10.0.2.2 + + * - address='172.17.1.1' + prefix='16' + - 172.17.2.15/16 + - 172.17.2.3 + - 172.17.2.2 + + * - address='172.17.1.1' + prefix='24' + - 172.17.1.15/24 + - 172.17.1.3 + - 172.17.1.2 + + * - address='172.17.1.1' + prefix='8' + - 172.0.2.15/16 + - 172.0.2.3 + - 172.0.2.2 + + * - address='172.17.1.1' + prefix='23' + - 172.17.0.15/23 + - 172.17.0.3 + - 172.17.0.2 + Userspace connection using passt ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -5304,8 +5349,10 @@ any conflict). Also different from SLIRP's behavior: if you do specify IP address(es), the exact address and netmask/prefix you specify will be provided to the guest (i.e. passt doesn't interpret the <ip> settings -as a network address like SLIRP does, but as a host address). In -example given above, the guest IP would be set to exactly 172.17.1.1. +as a network address like SLIRP does, but as a host address). In the +table of examples given above, the guest IP would be set to exactly +172.17.1.1 in all cases (the DNS and default gateway will be set +the same as they are on the host). Just as with SLIRP, though, once traffic from the guest leaves the host towards the rest of the network, it will always appear as if it -- 2.48.1

2 1

[PATCH] NEWS: qemu: Support for Block Disk Along with Throttle Filters
by Harikumar Rajkumar 25 Mar '25

25 Mar '25

NEWS: qemu: Support for Block Disk Along with Throttle Filters Harikumar Rajkumar (1): NEWS: Support block disk along with throttle filters NEWS.rst | 6 ++++++ 1 file changed, 6 insertions(+) -- 2.48.1

2 2

[libvirt PATCH] qemu_driver: Fix virDomainSaveImageDefineXML
by Pavel Hrdina 24 Mar '25

24 Mar '25

From: Pavel Hrdina <phrdina(a)redhat.com> Commit 28a06215280b99708ed8dc2d183f62ba7b34ccf8 added support to restore sparse images but changed the boolean that controls if we open the file as read-only or read-write. Editing XML in the save image resulted in following error message: failed to write header to domain save file '/data/images/fedora40.save': Bad file descriptor Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 3cf21380ed..056a9e579d 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -5945,7 +5945,7 @@ qemuDomainSaveImageDefineXML(virConnectPtr conn, const char *path, if (qemuSaveImageGetMetadata(driver, NULL, path, &def, &data) < 0) goto cleanup; - fd = qemuSaveImageOpen(driver, path, false, false, NULL, false); + fd = qemuSaveImageOpen(driver, path, false, false, NULL, true); if (fd < 0) goto cleanup; -- 2.49.0

2 1

[libvirt PATCH 0/6] cleanup and fixes of the mapped-ram feature
by Pavel Hrdina 24 Mar '25

24 Mar '25

Pavel Hrdina (6): tools: remove --parallel from virsh restore command tools: remote --parallel from virsh save command qemu: remove VIR_DOMAIN_SAVE_PARALLEL flag tools: use virDomainRestoreParams only when necessary tools: use virDomainSaveParams only when necessary virsh: add --image-format option to the save command docs/manpages/virsh.rst | 24 +++++---- include/libvirt/libvirt-domain.h | 1 - src/qemu/qemu_driver.c | 6 +-- src/qemu/qemu_migration_params.c | 34 ++++++------ tools/virsh-domain.c | 93 ++++++++++++++++---------------- 5 files changed, 80 insertions(+), 78 deletions(-) -- 2.48.1

4 11

[PATCH] NEWS: hotplug virtio-mem device
by Boris Fiuczynski 21 Mar '25

21 Mar '25

Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com> --- NEWS.rst | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 484333e55a..1de0231c57 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -56,6 +56,12 @@ v11.2.0 (unreleased) * **Bug fixes** + * qemu: attach virtio-mem with CCW address + + Attaching a virtio-mem device on s390 without an address type now gets a + default type CCW address assigned. A specified CCW address is now used for + the virtio-mem device instead of getting overwritten by a PCI address. + v11.1.0 (2025-03-03) ==================== -- 2.47.0

3 2

[libvirt PATCH] NEWS: fix even more typos
by Ján Tomko 21 Mar '25

21 Mar '25

From: Ján Tomko <jtomko(a)redhat.com> The 'editting one' was: Reported-by: Martin Kletzander <mkletzan(a)redhat.com> I found the rest myself. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed as trivial. NEWS.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index 484333e55a..6ab34aa756 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -31,7 +31,7 @@ v11.2.0 (unreleased) * qemu: Add support for multiple iothreads for ``virtio-scsi`` controller - It's now possible to map multiple iotreads to the ``virtio-scsi`` controller + It's now possible to map multiple iothreads to the ``virtio-scsi`` controller or even map them to specific virtqueues similarly to the ``virtio-blk`` device allowing for better performance in certain scenarios. @@ -45,10 +45,10 @@ v11.2.0 (unreleased) a host shutdown has been requested. It will initiate the chosen action on running guests immediately, allowing shutdown inhibitors to be released sooner. The new solution is also able to iteratively try multiple actions - until one of them succeeeds in shutting down the VM. + until one of them succeeds in shutting down the VM. Since it must be mutually exclusive with the libvirt-guests script, this - feature currently requires an manual opt-in through editting of the + feature currently requires an manual opt-in through editing of the /etc/libvirt/qemu.conf configuration file. The libvirt-guests script must be disabled before doing this. -- 2.49.0

2 2

[PATCH 0/8] qemu: Improve guest agent corner case errors
by Peter Krempa 21 Mar '25

21 Mar '25

This series introduces two new error codes aimed to help management applications to better in deciding when corner cases of guest agent interaction are encountered. Peter Krempa (8): lib: error: Introduce 'VIR_ERR_AGENT_COMMAND_TIMEOUT' qemu: agent: Differentiate timeouts when syncing from command timeout qemuAgentCommandFull: Use VIR_ERR_AGENT_COMMAND_TIMEOUT when agent disappears docs: Point to VIR_ERR_AGENT_COMMAND_TIMEOUT when setting timeout lib: error: Introduce 'VIR_ERR_AGENT_COMMAND_FAILED' qemuAgentCheckError: Use 'VIR_ERR_AGENT_COMMAND_FAILED' qemuAgentCheckError: Rewort error if neither return nor error is found NEWS: Mention guest agent error code improvements NEWS.rst | 10 ++++++++++ docs/manpages/virsh.rst | 3 +++ include/libvirt/virterror.h | 4 ++++ src/libvirt-domain.c | 4 ++++ src/qemu/qemu_agent.c | 32 +++++++++++++++++++++----------- src/util/virerror.c | 6 ++++++ 6 files changed, 48 insertions(+), 11 deletions(-) -- 2.48.1

3 16

[PATCH] NEWS: Mention support for mapped-ram
by Jim Fehlig 21 Mar '25

21 Mar '25

Add a 'New features' entry for mapped-ram itself, and another for the parallel save/restore feature built on top. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- NEWS.rst | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 484333e55a..76f7ea65b1 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -52,6 +52,21 @@ v11.2.0 (unreleased) /etc/libvirt/qemu.conf configuration file. The libvirt-guests script must be disabled before doing this. + * qemu: Add 'sparse' as a new save image format + + QEMU's ``file`` migration has been supplemented with the new stream format + ``mapped-ram``, where RAM pages are mapped directly to offsets in the + migration file. ``mapped-ram`` is now supported by augmenting the existing + save image formats with the ``sparse`` format. + + * qemu: Add support for parallel save/restore + + The ``sparse`` image format can support reading and writing by multiple + channels. ``virDomainSaveParams`` and ``virDomainRestoreParams`` now + support specifying the number of IO channels used for parallel save and + restore. Using multiple channels can reduce the time required to save + and restore domains. + * **Improvements** * **Bug fixes** -- 2.43.0

2 1

[PATCH 0/2] qemu: Build fixes following merge of mapped-ram
by Jim Fehlig 21 Mar '25

21 Mar '25

Patches to fix the recent build failures caused by merging the mapped-ram series. They get a green light from a CI run in my fork https://gitlab.com/jfehlig/libvirt/-/pipelines/1727301916 I would push them as build-breakers, but the first one does raise a question that should be answered beforehand IMO. See the individual patches for more commentary. Also, feel free to push if the patches are fine and it's outside of MDT timezone working hours :-). Jim Fehlig (2): qemu: Fix CLang build qemu: Fix build on 32-bit platforms src/qemu/qemu_migration_params.c | 2 +- src/qemu/qemu_monitor.c | 4 ++-- src/qemu/qemu_process.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) -- 2.43.0

2 4

[PATCH] Add NEWS item for auto-shutdown feature
by Daniel P. Berrangé 21 Mar '25

21 Mar '25

From: Daniel P. Berrangé <berrange(a)redhat.com> Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- NEWS.rst | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 98ca838642..45d48c1485 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -35,6 +35,23 @@ v11.2.0 (unreleased) or even map them to specific virtqueues similarly to the ``virtio-blk`` device allowing for better performance in certain scenarios. + * qemu: integrate support for VM shutdown on host shutdown + + It is now possible to instruct the QEMU driver to automatically perform + managed save, graceful shutdown, or hard poweroff on running VMs, when a + host shutdown is requested. This feature is intended to eventually replace + usage of the libvirt-guests script. The new approach improves on the + libvirt-guests script, by proactively monitor logind for a signal that a + host shutdown has been requested. It will initiate the chosen action on + running guests immediately, allowing shutdown inhibitors to be released + sooner. The new solution is also able to iteratively try multiple actions + until one of them succeeeds in shutting down the VM. + + Since it must be mutually exclusive with the libvirt-guests script, this + feature currently requires an manual opt-in through editting of the + /etc/libvirt/qemu.conf configuration file. The libvirt-guests script must + be disabled before doing this. + * **Improvements** * **Bug fixes** -- 2.48.1

5 5

[PATCH] virsh: make virshPrintJobProgress tty-aware
by Vincent Caron 21 Mar '25

21 Mar '25

virshPrintJobProgress pretty-prints a migration progress indicator on stderr presuming it's tied to a tty, which is not always true. In the case without the tty, I still find the progress indication useful (for instance it ends in a timestamped log, which is useful for debug/perf analysis). And most log processings are line-buffered, thus it won't properly work until every progress update ends with a newline. I had a quick glance and did not find any other place in virsh code where a tty was assumed, thus I thought this tty-awareness could be narrowed to this single function. This was originally submited as https://gitlab.com/libvirt/libvirt/-/issues/756 Signed-off-by: Vincent Caron <vcaron(a)bearstech.com> --- tools/virsh-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 1bee969824..577ab57158 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -2108,7 +2108,7 @@ virshPrintJobProgress(const char *label, unsigned long long remaining, /* see comments in vshError about why we must flush */ fflush(stdout); /* avoid auto-round-off of double by keeping only 2 decimals */ - fprintf(stderr, "\r%s: [%5.2f %%]", label, (int)(progress*100)/100.0); + fprintf(stderr, isatty(STDERR_FILENO) ? "\r%s: [%5.2f %%]" : "%s: [%5.2f %%]\n", label, (int)(progress*100)/100.0); fflush(stderr); } -- 2.39.5

1 0

[PATCH v9 reviewed 00/17] qemu: block: Support block disk along with throttle filters
by Peter Krempa 20 Mar '25

20 Mar '25

v9 of the throttle filtering series with my reviews and R-b tags applied. Requires [PATCH 0/5] qemu: Two block job fixes https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/TX2… to be applied to work properly. Posting for tracking and possibly final review of API. I'll push it before the freeze if there won't be further comments. Changes (most recorded in commit messages): - removed leftover code after deletion of some of the APIs - fixed numerous memleaks - simplified virsh code - dropped test driver pach Chun Feng Wu (16): schema: Add new domain elements to support multiple throttle groups schema: Add new domain elements to support multiple throttle filters config: Introduce ThrottleGroup and corresponding XML parsing config: Introduce ThrottleFilter and corresponding XML parsing qemu: monitor: Add support for ThrottleGroup operations tests: Test qemuMonitorJSONGetThrottleGroup and qemuMonitorJSONUpdateThrottleGroup remote: New APIs for ThrottleGroup lifecycle management qemu: Refactor qemuDomainSetBlockIoTune to extract common methods qemu: Implement qemu driver for throttle API qemu: helper: throttle filter nodename and preparation processing qemu: block: Support block disk along with throttle filters config: validate: Verify iotune, throttle group and filter qemuxmlconftest: Add 'throttlefilter' tests virsh: Refactor iotune options for re-use virsh: Add support for throttle group operations virsh: Add option "throttle-groups" to "attach_disk" Harikumar Rajkumar (1): qemustatusxml2xmldata: Add 'throttlefilter' tests docs/formatdomain.rst | 47 ++ docs/manpages/virsh.rst | 137 +++- include/libvirt/libvirt-domain.h | 14 + src/conf/domain_conf.c | 409 +++++++++++ src/conf/domain_conf.h | 47 ++ src/conf/domain_validate.c | 124 +++- src/conf/schemas/domaincommon.rng | 293 ++++---- src/conf/virconftypes.h | 4 + src/driver-hypervisor.h | 14 + src/libvirt-domain.c | 122 +++ src/libvirt_private.syms | 8 + src/libvirt_public.syms | 6 + src/qemu/qemu_block.c | 136 ++++ src/qemu/qemu_block.h | 49 ++ src/qemu/qemu_command.c | 171 +++++ src/qemu/qemu_command.h | 6 + src/qemu/qemu_domain.c | 77 +- src/qemu/qemu_driver.c | 467 +++++++++--- src/qemu/qemu_hotplug.c | 16 + src/qemu/qemu_monitor.c | 21 + src/qemu/qemu_monitor.h | 9 + src/qemu/qemu_monitor_json.c | 61 ++ src/qemu/qemu_monitor_json.h | 9 + src/remote/remote_driver.c | 2 + src/remote/remote_protocol.x | 31 +- src/remote_protocol-structs | 16 + tests/qemumonitorjsontest.c | 51 ++ .../throttlefilter-in.xml | 392 ++++++++++ .../throttlefilter-out.xml | 393 ++++++++++ tests/qemuxmlactivetest.c | 1 + .../throttlefilter-invalid.x86_64-latest.err | 1 + .../throttlefilter-invalid.xml | 89 +++ .../throttlefilter.x86_64-latest.args | 56 ++ .../throttlefilter.x86_64-latest.xml | 105 +++ tests/qemuxmlconfdata/throttlefilter.xml | 95 +++ tests/qemuxmlconftest.c | 2 + tools/virsh-completer-domain.c | 63 ++ tools/virsh-completer-domain.h | 14 + tools/virsh-domain.c | 695 ++++++++++++++---- 39 files changed, 3845 insertions(+), 408 deletions(-) create mode 100644 tests/qemustatusxml2xmldata/throttlefilter-in.xml create mode 100644 tests/qemustatusxml2xmldata/throttlefilter-out.xml create mode 100644 tests/qemuxmlconfdata/throttlefilter-invalid.x86_64-latest.err create mode 100644 tests/qemuxmlconfdata/throttlefilter-invalid.xml create mode 100644 tests/qemuxmlconfdata/throttlefilter.x86_64-latest.args create mode 100644 tests/qemuxmlconfdata/throttlefilter.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/throttlefilter.xml -- 2.48.1

2 20

[PATCH] qemu/dbus: Allow connections from root to the dbus-daemon
by Martin Kletzander 20 Mar '25

20 Mar '25

From: Martin Kletzander <mkletzan(a)redhat.com> In commit dbfb96d18c04 libvirt started connecting to the daemon to set RDP credentials, but our configuration file did not allow connections from the root user, so the connection failed and the VM failed to start. In order to avoid such issue allow root to connect if the daemon is running privileged. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- src/qemu/qemu_dbus.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_dbus.c b/src/qemu/qemu_dbus.c index a9e2fb0fe231..625884ad467f 100644 --- a/src/qemu/qemu_dbus.c +++ b/src/qemu/qemu_dbus.c @@ -116,7 +116,7 @@ qemuDBusConnect(virQEMUDriver *driver, static int -qemuDBusWriteConfig(const char *filename, const char *path) +qemuDBusWriteConfig(const char *filename, const char *path, bool privileged) { g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; g_autofree char *config = NULL; @@ -138,6 +138,9 @@ qemuDBusWriteConfig(const char *filename, const char *path) virBufferAddLit(&buf, "<allow eavesdrop='true'/>\n"); virBufferAddLit(&buf, "\n"); virBufferAddLit(&buf, "<allow own='*'/>\n"); + if (privileged) + virBufferAddLit(&buf, "<allow user='root'/>\n"); + virBufferAdjustIndent(&buf, -2); virBufferAddLit(&buf, "</policy>\n"); @@ -242,7 +245,7 @@ qemuDBusStart(virQEMUDriver *driver, configfile = qemuDBusCreateConfPath(cfg, shortName); sockpath = qemuDBusCreateSocketPath(cfg, shortName); - if (qemuDBusWriteConfig(configfile, sockpath) < 0) { + if (qemuDBusWriteConfig(configfile, sockpath, driver->privileged) < 0) { virReportSystemError(errno, _("Failed to write '%1$s'"), configfile); return -1; } -- 2.48.1

2 1

[PATCH v2] virsh: Introduce new hypervisor-cpu-models command
by Collin Walling 20 Mar '25

20 Mar '25

From: David Judkovics <djudkovi(a)linux.ibm.com> Add new virsh command 'hypervisor-cpu-models'. Command pulls from the existing domcapabilities XML and uses xpath to parse CPU model strings. By default, only models reported as usable by the hypervisor on the host system are printed. User may specify "--all" to also print models which are not supported on the host. Signed-off-by: David Judkovics <djudkovi(a)linux.ibm.com> Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com> Signed-off-by: Collin Walling <walling(a)linux.ibm.com> Reviewed-by: Ján Tomko <jtomko(a)redhat.com> --- Changelog: v2 - Corrected virsh.rst documentation - Removed unwanted_positional from emulator option - Adjusted xpath string based on feedback --- docs/manpages/virsh.rst | 25 ++++++++++++++ tools/virsh-host.c | 75 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 100 insertions(+) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index baced15dec..612c567ff4 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -1034,6 +1034,31 @@ listed in the XML description. If *--migratable* is specified, features that block migration will not be included in the resulting CPU. +hypervisor-cpu-models +--------------------- + +**Syntax:** + +:: + + hypervisor-cpu-models [--virttype virttype] [--emulator emulator] + [--arch arch] [--machine machine] [--all] + +Print the list of CPU models known by the hypervisor for the specified architecture. +It is not guaranteed that a listed CPU will run on the host. To determine CPU +model compatibility with the host, see ``virsh hypervisor-cpu-baseline`` and +``virsh hypervisor-cpu-compare``. + +The *virttype* option specifies the virtualization type (usable in the 'type' +attribute of the <domain> top level element from the domain XML). *emulator* +specifies the path to the emulator, *arch* specifies the CPU architecture, and +*machine* specifies the machine type. + +By default, only the models that are claimed to be "usable" by the hypervisor +on the host are reported. The option *--all* will report every CPU model known +to the hypervisor, including ones that are not supported on the hypervisor (e.g. +newer generation models). + DOMAIN COMMANDS =============== diff --git a/tools/virsh-host.c b/tools/virsh-host.c index 9e8f542c96..f4e34fb146 100644 --- a/tools/virsh-host.c +++ b/tools/virsh-host.c @@ -1766,6 +1766,75 @@ cmdHypervisorCPUBaseline(vshControl *ctl, } +/* + * "hypervisor-cpu-models" command + */ +static const vshCmdInfo info_hypervisor_cpu_models = { + .help = N_("Hypervisor reported CPU models"), + .desc = N_("Get the CPU models reported by the hypervisor."), +}; + +static const vshCmdOptDef opts_hypervisor_cpu_models[] = { + {.name = "virttype", + .type = VSH_OT_STRING, + .completer = virshDomainVirtTypeCompleter, + .help = N_("virtualization type (/domain/@type)"), + }, + {.name = "emulator", + .type = VSH_OT_STRING, + .help = N_("path to emulator binary (/domain/devices/emulator)"), + }, + {.name = "arch", + .type = VSH_OT_STRING, + .completer = virshArchCompleter, + .help = N_("CPU architecture (/domain/os/type/@arch)"), + }, + {.name = "machine", + .type = VSH_OT_STRING, + .help = N_("machine type (/domain/os/type/@machine)"), + }, + {.name = "all", + .type = VSH_OT_BOOL, + .help = N_("include all CPU models known to the hypervisor for the architecture") + }, + {.name = NULL} +}; + +static bool +cmdHypervisorCPUModelNames(vshControl *ctl, + const vshCmd *cmd) +{ + g_autofree char *caps_xml = NULL; + const char *virttype = NULL; + const char *emulator = NULL; + const char *arch = NULL; + const char *machine = NULL; + const char *xpath = NULL; + virshControl *priv = ctl->privData; + + if (vshCommandOptString(ctl, cmd, "virttype", &virttype) < 0 || + vshCommandOptString(ctl, cmd, "emulator", &emulator) < 0 || + vshCommandOptString(ctl, cmd, "arch", &arch) < 0 || + vshCommandOptString(ctl, cmd, "machine", &machine) < 0) + return false; + + if (vshCommandOptBool(cmd, "all")) + xpath = "//cpu//model[@usable]/text()"; + else + xpath = "//cpu//model[@usable='yes']/text()"; + + caps_xml = virConnectGetDomainCapabilities(priv->conn, emulator, arch, + machine, virttype, 0); + + if (!caps_xml) { + vshError(ctl, "%s", _("failed to get hypervisor CPU model names")); + return false; + } + + return virshDumpXML(ctl, caps_xml, "domcapabilities", xpath, false); +} + + const vshCmdDef hostAndHypervisorCmds[] = { {.name = "allocpages", .handler = cmdAllocpages, @@ -1833,6 +1902,12 @@ const vshCmdDef hostAndHypervisorCmds[] = { .info = &info_hypervisor_cpu_compare, .flags = 0 }, + {.name = "hypervisor-cpu-models", + .handler = cmdHypervisorCPUModelNames, + .opts = opts_hypervisor_cpu_models, + .info = &info_hypervisor_cpu_models, + .flags = 0 + }, {.name = "maxvcpus", .handler = cmdMaxvcpus, .opts = opts_maxvcpus, -- 2.47.1

2 1

Questions regarding potential resize implementation in libvirt
by Maximilian Immanuel Brandtner 20 Mar '25

20 Mar '25

I've been working on an RFC patch-set to implement resizing for consoles in QEMU. Now that the patch-set is in review I've turned my attention to bringing this feature to libvirt. With the QEMU patch-set there are two ways to resize a pty chardev. 1. send a TIOCSWINSZ ioctl 2. send a QMP msg The first approach doesn't work under Libvirt. Pty chardevs are proxied over a FIFO meaning the ioctl wouldn't get to libvirt. Furthermore, this approach is incompatible with remote management which libvirt seems to go to great lengths to support. Sending a QMP message is a QEMU specific feature. It seems to me that adding a new handle (something like domainResizeConsole) would have to be added to the virHypervisorDriver struct. It would be really nifty if the resize handle could be implemented in the virStream, however it seems that all the virStreamDriver handlers are common code (aka shared across all hypervisors). From what I've seen it seems that the only way to switch from common code to hypervisor specific code would be over the virHypervisorDriver. As it stands it seems to me that the best course of action would be adding a new handle to the virHypervisorDriver, but I'm unsure whether that's really the right call. Furthermore, if we don't want to broadcast a QMP message to every chardev, the handle needs to determine the alias with which the chardev can be adressed in QMP. in qemuDomainOpenConsole the alias for the console is set and added as the callback argument for the internal close function. There doesn't seem to be a way to get the alias of a console from virStream. It seems that I need to add an alias string field to the virStream or the virStreamFDData. I could however be mistaken and there is already a way to get the alias for a virStream, hence this email TLDR I have the following 2 questions: - Should the resize handle be implemented in the virHypervisorDriver directly or in the virStreamDriver? - Is there a way to get the QMP alias of a chardev from a virStream? Thanks in advance Max

3 7

[PATCH] virsh: Introduce new hypervisor-cpu-models command
by Collin Walling 20 Mar '25

20 Mar '25

From: David Judkovics <djudkovi(a)linux.ibm.com> Add new virsh command 'hypervisor-cpu-models'. Command pulls from the existing domcapabilities XML and uses xpath to parse CPU model strings. By default, only models reported as usable by the hypervisor on the host system are printed. User may specify "--all" to also print models which are not supported on the host. Signed-off-by: David Judkovics <djudkovi(a)linux.ibm.com> Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com> Signed-off-by: Collin Walling <walling(a)linux.ibm.com> --- This is a continuation of a previous series found here: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/I4Y… --- docs/manpages/virsh.rst | 24 +++++++++++++ tools/virsh-host.c | 74 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 98 insertions(+) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index baced15dec..48b667736d 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -1034,6 +1034,30 @@ listed in the XML description. If *--migratable* is specified, features that block migration will not be included in the resulting CPU. +hypervisor-cpu-models +--------------------- + +**Syntax:** + +:: + + hypervisor-cpu-models [virttype] [emulator] [arch] [machine] [--all] + +Print the list of CPU models known by the hypervisor for the specified architecture. +It is not guaranteed that a listed CPU will run on the host. To determine CPU +model compatibility with the host, see ``virsh hypervisor-cpu-baseline`` and +``virsh hypervisor-cpu-compare``. + +The *virttype* option specifies the virtualization type (usable in the 'type' +attribute of the <domain> top level element from the domain XML). *emulator* +specifies the path to the emulator, *arch* specifies the CPU architecture, and +*machine* specifies the machine type. + +By default, only the models that are claimed to be "usable" by the hypervisor +on the host are reported. The option *--all* will report every CPU model known +to the hypervisor, including ones that are not supported on the hypervisor (e.g. +newer generation models). + DOMAIN COMMANDS =============== diff --git a/tools/virsh-host.c b/tools/virsh-host.c index 9e8f542c96..2884067bbb 100644 --- a/tools/virsh-host.c +++ b/tools/virsh-host.c @@ -1766,6 +1766,74 @@ cmdHypervisorCPUBaseline(vshControl *ctl, } +/* + * "hypervisor-cpu-models" command + */ +static const vshCmdInfo info_hypervisor_cpu_models = { + .help = N_("Hypervisor reported CPU models"), + .desc = N_("Get the CPU models reported by the hypervisor."), +}; + +static const vshCmdOptDef opts_hypervisor_cpu_models[] = { + {.name = "virttype", + .type = VSH_OT_STRING, + .completer = virshDomainVirtTypeCompleter, + .help = N_("virtualization type (/domain/@type)"), + }, + {.name = "emulator", + .type = VSH_OT_STRING, + .unwanted_positional = true, + .help = N_("path to emulator binary (/domain/devices/emulator)"), + }, + {.name = "arch", + .type = VSH_OT_STRING, + .completer = virshArchCompleter, + .help = N_("CPU architecture (/domain/os/type/@arch)"), + }, + {.name = "machine", + .type = VSH_OT_STRING, + .help = N_("machine type (/domain/os/type/@machine)"), + }, + {.name = "all", + .type = VSH_OT_BOOL, + .help = N_("include all CPU models known to the hypervisor for the architecture") + }, + {.name = NULL} +}; + +static bool +cmdHypervisorCPUModelNames(vshControl *ctl, + const vshCmd *cmd) +{ + g_autofree char *caps_xml = NULL; + const char *virttype = NULL; + const char *emulator = NULL; + const char *arch = NULL; + const char *machine = NULL; + const char *xpath_all = "//cpu//model[@usable]/text()"; + const char *xpath_usable = "//cpu//model[@usable='yes']/text()"; + virshControl *priv = ctl->privData; + + if (vshCommandOptString(ctl, cmd, "virttype", &virttype) < 0 || + vshCommandOptString(ctl, cmd, "emulator", &emulator) < 0 || + vshCommandOptString(ctl, cmd, "arch", &arch) < 0 || + vshCommandOptString(ctl, cmd, "machine", &machine) < 0) + return false; + + caps_xml = virConnectGetDomainCapabilities(priv->conn, emulator, arch, + machine, virttype, 0); + + if (!caps_xml) { + vshError(ctl, "%s", _("failed to get hypervisor CPU model names")); + return false; + } + + return virshDumpXML(ctl, caps_xml, "domcapabilities", + vshCommandOptBool(cmd, "all") ? xpath_all : xpath_usable, + false); +} + + const vshCmdDef hostAndHypervisorCmds[] = { {.name = "allocpages", .handler = cmdAllocpages, @@ -1833,6 +1901,12 @@ const vshCmdDef hostAndHypervisorCmds[] = { .info = &info_hypervisor_cpu_compare, .flags = 0 }, + {.name = "hypervisor-cpu-models", + .handler = cmdHypervisorCPUModelNames, + .opts = opts_hypervisor_cpu_models, + .info = &info_hypervisor_cpu_models, + .flags = 0 + }, {.name = "maxvcpus", .handler = cmdMaxvcpus, .opts = opts_maxvcpus, -- 2.47.1

3 6

[PATCH 0/5] qemu: Two block job fixes
by Peter Krempa 19 Mar '25

19 Mar '25

Peter Krempa (5): qemu: monitor: Wire up 'replaces' attribute for 'blockdev-mirror' qemu: Do not replace filter nodes with virDomainBlockCopy qemu: Remove return value from 'qemuHotplugRemoveManagedPR' qemuDomainChangeEjectableMedia: Separate rollback and success code paths qemuHotplugRemoveManagedPR: Integrate check whether removal is needed src/qemu/qemu_blockjob.c | 2 +- src/qemu/qemu_driver.c | 3 +- src/qemu/qemu_hotplug.c | 58 +++++++++++++++--------------------- src/qemu/qemu_hotplug.h | 3 +- src/qemu/qemu_migration.c | 1 + src/qemu/qemu_monitor.c | 9 +++--- src/qemu/qemu_monitor.h | 1 + src/qemu/qemu_monitor_json.c | 2 ++ src/qemu/qemu_monitor_json.h | 1 + tests/qemumonitorjsontest.c | 2 +- 10 files changed, 40 insertions(+), 42 deletions(-) -- 2.48.1

2 6

[libvirt PATCH 0/7] qemu: introduce amd-iommu support
by Ján Tomko 19 Mar '25

19 Mar '25

To the cc'd QEMU developers - I'd appreciate guidance on how/whether to document and expose the 'xtsup' and 'pt' parameters to libvirt users. Based on QEMU series: Subject: [PATCH v4 0/2] hw/i386/amd_iommu: Add migration support From: Suravee Suthikulpanit <suravee.suthikulpanit(a)amd.com> Message-ID: <20250304141716.638880-1-suravee.suthikulpanit(a)amd.com> (not yet merged in upstream QEMU) Ján Tomko (7): qemu: introduce QEMU_CAPS_AMD_IOMMU qemu: introduce QEMU_CAPS_PCI_ID qemu: add IOMMU model amd docs: formatdomain: document intel-only IOMMU attributes conf: add passthrough and xtsup attributes for IOMMU conf: reject some attributes not applicable to intel IOMMU qemu: format pt and xstup on the command line docs/formatdomain.rst | 22 +++- src/conf/domain_conf.c | 31 +++++ src/conf/domain_conf.h | 3 + src/conf/domain_validate.c | 22 ++++ src/conf/schemas/domaincommon.rng | 11 ++ src/qemu/qemu_capabilities.c | 12 ++ src/qemu/qemu_capabilities.h | 4 + src/qemu/qemu_command.c | 30 +++++ src/qemu/qemu_domain_address.c | 4 + src/qemu/qemu_validate.c | 29 +++++ .../caps_10.0.0_x86_64+amdsev.replies | 102 +++++++++++------ .../caps_10.0.0_x86_64+amdsev.xml | 1 + .../caps_10.0.0_x86_64.replies | 106 ++++++++++++------ .../caps_10.0.0_x86_64.xml | 2 + .../caps_6.2.0_x86_64.replies | 102 +++++++++++------ .../caps_6.2.0_x86_64.xml | 1 + .../caps_7.0.0_x86_64.replies | 80 +++++++------ .../caps_7.0.0_x86_64.xml | 1 + .../caps_7.1.0_x86_64.replies | 102 +++++++++++------ .../caps_7.1.0_x86_64.xml | 1 + .../caps_7.2.0_x86_64+hvf.replies | 102 +++++++++++------ .../caps_7.2.0_x86_64+hvf.xml | 1 + .../caps_7.2.0_x86_64.replies | 102 +++++++++++------ .../caps_7.2.0_x86_64.xml | 1 + .../caps_8.0.0_x86_64.replies | 80 +++++++------ .../caps_8.0.0_x86_64.xml | 1 + .../caps_8.1.0_x86_64.replies | 102 +++++++++++------ .../caps_8.1.0_x86_64.xml | 1 + .../caps_8.2.0_x86_64.replies | 102 +++++++++++------ .../caps_8.2.0_x86_64.xml | 1 + .../caps_9.0.0_x86_64.replies | 80 +++++++------ .../caps_9.0.0_x86_64.xml | 1 + .../caps_9.1.0_x86_64.replies | 102 +++++++++++------ .../caps_9.1.0_x86_64.xml | 1 + .../caps_9.2.0_x86_64+amdsev.replies | 102 +++++++++++------ .../caps_9.2.0_x86_64+amdsev.xml | 1 + .../caps_9.2.0_x86_64.replies | 102 +++++++++++------ .../caps_9.2.0_x86_64.xml | 1 + .../amd-iommu.x86_64-latest.args | 35 ++++++ .../amd-iommu.x86_64-latest.xml | 1 + tests/qemuxmlconfdata/amd-iommu.xml | 39 +++++++ tests/qemuxmlconftest.c | 2 + 42 files changed, 1172 insertions(+), 454 deletions(-) create mode 100644 tests/qemuxmlconfdata/amd-iommu.x86_64-latest.args create mode 120000 tests/qemuxmlconfdata/amd-iommu.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/amd-iommu.xml -- 2.48.1

1 8

[PATCH 0/6] qemu: Add support for iothread to virtqueue mapping for 'virtio-scsi'
by Peter Krempa 19 Mar '25

19 Mar '25

The qemu part was now merged. Diff to rfc-v2: - The 'ctrl' and 'event' queues are not exposed to be mapped: - dropped patch for named queue support - adapted validation logic - adapted docs Peter Krempa (6): qemucapabilitiestest: Update 'caps_10.0.0_x86_64' to v9.2.0-2799-g0462a32b4f qemu: capabilities: Introduce QEMU_CAPS_VIRTIO_SCSI_IOTHREAD_MAPPING conf: Add support for iothread to queue mapping config for 'virtio-scsi' qemu: Implement support for iothread <-> virtqueue mapping for 'virtio-scsi' controllers qemuxmlconftest: Add 'iothreads-virtio-scsi-mapping' case NEWS: Mention multiple iothread support for 'virtio-scsi' controller NEWS.rst | 6 + docs/formatdomain.rst | 39 ++++ src/conf/domain_conf.c | 10 +- src/conf/domain_conf.h | 1 + src/conf/domain_validate.c | 10 +- src/conf/schemas/domaincommon.rng | 3 + src/hypervisor/domain_driver.c | 3 +- src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_command.c | 6 + src/qemu/qemu_validate.c | 30 ++- .../caps_10.0.0_x86_64.replies | 193 ++++++++++-------- .../caps_10.0.0_x86_64.xml | 7 +- ...ads-virtio-scsi-mapping.x86_64-latest.args | 40 ++++ ...eads-virtio-scsi-mapping.x86_64-latest.xml | 61 ++++++ .../iothreads-virtio-scsi-mapping.xml | 53 +++++ tests/qemuxmlconftest.c | 1 + 17 files changed, 369 insertions(+), 101 deletions(-) create mode 100644 tests/qemuxmlconfdata/iothreads-virtio-scsi-mapping.x86_64-latest.args create mode 100644 tests/qemuxmlconfdata/iothreads-virtio-scsi-mapping.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/iothreads-virtio-scsi-mapping.xml -- 2.48.1

2 7

[PATCH v2 0/3] Reflect MAC change in live domain XML
by Michal Privoznik 18 Mar '25

18 Mar '25

v2 of https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/AVMO… diff to v1: - If the MAC address is changed to its original the proper event is emitted. - In 3/3 some variables were renamed to avoid ambiguity. Michal Prívozník (3): qemu: Reflect MAC address change in live domain XML Introduce NIC_MAC_CHANGE event qemu: Emit NIC_MAC_CHANGE event docs/formatdomain.rst | 5 ++ examples/c/misc/event-test.c | 14 +++++ include/libvirt/libvirt-domain.h | 28 +++++++++ src/conf/domain_conf.c | 6 ++ src/conf/domain_conf.h | 3 + src/conf/domain_event.c | 93 +++++++++++++++++++++++++++++ src/conf/domain_event.h | 12 ++++ src/conf/schemas/domaincommon.rng | 5 ++ src/libvirt_private.syms | 2 + src/qemu/qemu_domain.c | 48 ++++++++++++++- src/qemu/qemu_domain.h | 3 +- src/qemu/qemu_driver.c | 11 ++-- src/qemu/qemu_process.c | 2 +- src/remote/remote_daemon_dispatch.c | 32 ++++++++++ src/remote/remote_driver.c | 34 +++++++++++ src/remote/remote_protocol.x | 17 +++++- src/remote_protocol-structs | 8 +++ tools/virsh-domain-event.c | 20 +++++++ 18 files changed, 335 insertions(+), 8 deletions(-) -- 2.48.1

3 7

[libvirt PATCH] conf: also free auth for rdp in virDomainGraphicsDefFree
by Ján Tomko 18 Mar '25

18 Mar '25

Signed-off-by: Ján Tomko <jtomko(a)redhat.com> Fixes: bfa7d5aaa8834c6801cacbfc6c6ea83a8ecaca9c --- Pushed as a trivial CI fix src/conf/domain_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 5748a89bd1..d05e68dd41 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -2032,6 +2032,7 @@ void virDomainGraphicsDefFree(virDomainGraphicsDef *def) break; case VIR_DOMAIN_GRAPHICS_TYPE_RDP: + virDomainGraphicsAuthDefClear(&def->data.rdp.auth); break; case VIR_DOMAIN_GRAPHICS_TYPE_DESKTOP: -- 2.48.1

1 0

[libvirt PATCH] qemu: remove unreachable breaks in qemuDomainAssignMemoryDeviceSlot
by Ján Tomko 18 Mar '25

18 Mar '25

Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed as trivial src/qemu/qemu_domain_address.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c index 5b94c27679..e89cdee487 100644 --- a/src/qemu/qemu_domain_address.c +++ b/src/qemu/qemu_domain_address.c @@ -3077,12 +3077,10 @@ qemuDomainAssignMemoryDeviceSlot(virDomainObj *vm, return -1; return qemuAssignMemoryDeviceSlot(mem, slotmap); - break; case VIR_DOMAIN_MEMORY_MODEL_VIRTIO_PMEM: case VIR_DOMAIN_MEMORY_MODEL_VIRTIO_MEM: return qemuDomainEnsureVirtioAddress(&releaseaddr, vm, &dev); - break; case VIR_DOMAIN_MEMORY_MODEL_SGX_EPC: case VIR_DOMAIN_MEMORY_MODEL_NONE: -- 2.48.1

1 0

[PATCH v2] qemu_domain_address: fix CCW virtio-mem hotplug
by Boris Fiuczynski 18 Mar '25

18 Mar '25

Since commit f23f8ff91a virtio-mem supports also CCW. When hotplugging a virtio-mem device with a CCW address results in a PCI device getting attached. The method qemuDomainAssignMemoryDeviceSlot is only considering PCI as address type and overwriting the CCW address. Adding support for address type CCW. Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com> --- src/qemu/qemu_domain_address.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c index d38983bf63..5b94c27679 100644 --- a/src/qemu/qemu_domain_address.c +++ b/src/qemu/qemu_domain_address.c @@ -3067,6 +3067,7 @@ qemuDomainAssignMemoryDeviceSlot(virDomainObj *vm, virDomainMemoryDef *mem) { g_autoptr(virBitmap) slotmap = NULL; + bool releaseaddr = false; virDomainDeviceDef dev = {.type = VIR_DOMAIN_DEVICE_MEMORY, .data.memory = mem}; switch (mem->model) { @@ -3080,7 +3081,7 @@ qemuDomainAssignMemoryDeviceSlot(virDomainObj *vm, case VIR_DOMAIN_MEMORY_MODEL_VIRTIO_PMEM: case VIR_DOMAIN_MEMORY_MODEL_VIRTIO_MEM: - return qemuDomainEnsurePCIAddress(vm, &dev); + return qemuDomainEnsureVirtioAddress(&releaseaddr, vm, &dev); break; case VIR_DOMAIN_MEMORY_MODEL_SGX_EPC: -- 2.47.0

2 1

[PATCH 0/3] Reflect MAC change in live domain XML
by Michal Privoznik 18 Mar '25

18 Mar '25

Original RFC: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/U274… Changes since: 1) instead of overwriting the original `address` attribute, new attribute (`guestAddress`) is invented so that both new and old MAC addresses can be shown, eventually. 2) rebase, libvirt version change, ... Michal Prívozník (3): qemu: Reflect MAC address change in live domain XML Introduce NIC_MAC_CHANGE event qemu: Emit NIC_MAC_CHANGE event docs/formatdomain.rst | 5 ++ examples/c/misc/event-test.c | 14 +++++ include/libvirt/libvirt-domain.h | 28 +++++++++ src/conf/domain_conf.c | 6 ++ src/conf/domain_conf.h | 3 + src/conf/domain_event.c | 93 +++++++++++++++++++++++++++++ src/conf/domain_event.h | 12 ++++ src/conf/schemas/domaincommon.rng | 5 ++ src/libvirt_private.syms | 2 + src/qemu/qemu_domain.c | 48 ++++++++++++++- src/qemu/qemu_domain.h | 3 +- src/qemu/qemu_driver.c | 11 ++-- src/qemu/qemu_process.c | 2 +- src/remote/remote_daemon_dispatch.c | 32 ++++++++++ src/remote/remote_driver.c | 34 +++++++++++ src/remote/remote_protocol.x | 17 +++++- tools/virsh-domain-event.c | 20 +++++++ 17 files changed, 327 insertions(+), 8 deletions(-) -- 2.48.1

3 7

[PATCH] qemu_domain_address: fix CCW virtio-mem hotplug
by Boris Fiuczynski 18 Mar '25

18 Mar '25

Since commit f23f8ff91a virtio-mem supports also CCW. When hotplugging a virtio-mem device with a CCW address results in a PCI device getting attached. The method qemuDomainAssignMemoryDeviceSlot is only considering PCI as address type and overwriting the CCW address. Adding support for address type CCW. Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com> --- src/qemu/qemu_domain_address.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c index d38983bf63..b0289c2337 100644 --- a/src/qemu/qemu_domain_address.c +++ b/src/qemu/qemu_domain_address.c @@ -3067,6 +3067,7 @@ qemuDomainAssignMemoryDeviceSlot(virDomainObj *vm, virDomainMemoryDef *mem) { g_autoptr(virBitmap) slotmap = NULL; + virDomainCCWAddressSet *ccwaddrs = NULL; virDomainDeviceDef dev = {.type = VIR_DOMAIN_DEVICE_MEMORY, .data.memory = mem}; switch (mem->model) { @@ -3080,7 +3081,20 @@ qemuDomainAssignMemoryDeviceSlot(virDomainObj *vm, case VIR_DOMAIN_MEMORY_MODEL_VIRTIO_PMEM: case VIR_DOMAIN_MEMORY_MODEL_VIRTIO_MEM: - return qemuDomainEnsurePCIAddress(vm, &dev); + if (mem->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE) { + if (qemuDomainIsS390CCW(vm->def)) + mem->info.type = VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW; + } + + if (mem->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE || + mem->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) { + return qemuDomainEnsurePCIAddress(vm, &dev); + } else if (mem->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW) { + if (!(ccwaddrs = virDomainCCWAddressSetCreateFromDomain(vm->def))) + return -1; + return virDomainCCWAddressAssign(&mem->info, ccwaddrs, + !mem->info.addr.ccw.assigned); + } break; case VIR_DOMAIN_MEMORY_MODEL_SGX_EPC: -- 2.47.0

2 2

[PATCH v2 00/22] integrate auto-shutdown of VMs with daemons
by Daniel P. Berrangé 18 Mar '25

18 Mar '25

This series starts the work needed to obsolete the libvirt-guests.sh script which has grown a surprisingly large amount of functionality. Currently the virt daemons will acquire inhibitors to delay OS shutdown when VMs are running. The libvirt-guests.service unit can be used to call libvirt-guests.sh to shutdown running VMs on system shutdown. This split is a bad architecture because libvirt-guests.service will only run once the system has decided to initiate the shutdown sequence. When the user requests as shutdown while inhibitors are present, logind will emit a "PrepareForShutdown" signal over dbus. Applications are supposed to respond to this by preserving state & releasing their inhibitors, which in turns allows shutdown to be initiated. The remote daemon already has support for listening for the "PrepareForShutdown" signal, but only does this for session instances, not system instances. This series essentially takes that logic and expands it to run in the system instances too, thus conceptually making libvirt-guests.service obsolete. It is slightly more complicated than that though for many reasons... Saving running VMs can take a very long time. The inhibitor delay can be as low as 5 seconds, and when killing a service, systemd may not wait very long for it to terminate. libvirt-guests.service deals with this by setting TimeoutStopSecs=0 to make systemd wait forever. This is undesirable to set in libvirtd.service though, as we would like systemd to kill the daemon aggressively if it hangs. The series thus uses the notification protocol to request systemd give it more time to shutdown, as long as we're in the phase of saving running VMs. A bug in this code will still result in systemd waiting forever, which is no different from libvirt-guests.service, but a bug in any other part of the libvirt daemon shutdown code will result in systemd killing us. The existing logic for saving VMs in the session daemons had many feature gaps compared to libvirt-guests.sh. Thus there is code to add support * Requesting graceful OS shutdown if managed save failed * Force poweroff of VMs if no other action worked * Optionally enabling/disabling use of managed save, graceful shutdown and force poweroff, which is more flexible than ON_SHUTDOWN=nnn, as we can try the whole sequence of options * Ability to bypass cache in managed save * Support for one-time autostart of VMs as an official API To aid in testing this logic, virt-admin gains a new command 'virt-admin daemon-shutdown --preserve' All this new functionality is wired up into the QEMU driver, and is made easily accessible to other hypervisor drivers, so would easily be extendable to Xen, CH, LXC drivers, but this is not done in this series. IOW, libvirt-guests.service is not yet fully obsolete. The new functionality is also not enabled by default for the system daemon, it requires explicit admin changes to /etc/libvirt/qemu.conf to enable it. This is because it would clash with execution of the libvirt-guests.service if both were enabled. It is highly desirable that we enable this by default though, so we need to figure out a upgrade story wrt libvirt-guests.service. The only libvirt-guests.sh features not implemented are: * PARALLEL_SHUTDOWN=nn. When doing a graceful shutdown we initiate it on every single VM at once, and then monitor progress of all of them in parallel. * SYNC_TIME=nn When make not attempt to sync guest time when restoring from managed save. This ought to be fixed Daniel P. Berrangé (22): hypervisor: move support for auto-shutdown out of QEMU driver remote: always invoke virStateStop for all daemons hypervisor: expand available shutdown actions hypervisor: custom shutdown actions for transient vs persistent VMs qemu: support automatic VM managed save in system daemon qemu: improve shutdown defaults for session daemon qemu: configurable delay for shutdown before poweroff hypervisor: support bypassing cache for managed save qemu: add config parameter to control auto-save bypass cache src: add new APIs for marking a domain to autostart once conf: implement support for autostart once feature hypervisor: wire up support for auto restore of running domains qemu: wire up support for once only autostart qemu: add config to control if auto-shutdown VMs are restored src: clarify semantics of the various virStateNNN methods rpc: rename virNetDaemonSetShutdownCallbacks rpc: move state stop into virNetDaemon class rpc: don't unconditionally quit after preserving state rpc: fix shutdown sequence when preserving state admin: add 'daemon-shutdown' command rpc: don't let systemd shutdown daemon while saving VMs hypervisor: emit systemd status & log messages while saving docs/manpages/virt-admin.rst | 13 ++ include/libvirt/libvirt-admin.h | 13 ++ include/libvirt/libvirt-domain.h | 4 + src/admin/admin_protocol.x | 11 +- src/admin/admin_server_dispatch.c | 13 ++ src/admin/libvirt-admin.c | 33 ++++ src/admin/libvirt_admin_public.syms | 5 + src/conf/domain_conf.c | 7 +- src/conf/domain_conf.h | 2 + src/conf/virdomainobjlist.c | 8 + src/driver-hypervisor.h | 10 ++ src/hypervisor/domain_driver.c | 246 +++++++++++++++++++++++++++- src/hypervisor/domain_driver.h | 27 +++ src/libvirt-domain.c | 87 ++++++++++ src/libvirt.c | 44 ++++- src/libvirt_private.syms | 3 + src/libvirt_public.syms | 6 + src/libvirt_remote.syms | 4 +- src/qemu/libvirtd_qemu.aug | 6 + src/qemu/qemu.conf.in | 62 +++++++ src/qemu/qemu_conf.c | 75 +++++++++ src/qemu/qemu_conf.h | 7 + src/qemu/qemu_driver.c | 150 ++++++++++++----- src/qemu/test_libvirtd_qemu.aug.in | 6 + src/remote/remote_daemon.c | 84 +++------- src/remote/remote_driver.c | 2 + src/remote/remote_protocol.x | 30 +++- src/remote_protocol-structs | 12 ++ src/rpc/gendispatch.pl | 4 +- src/rpc/virnetdaemon.c | 218 +++++++++++++++++++----- src/rpc/virnetdaemon.h | 35 +++- tools/virsh-domain-monitor.c | 7 + tools/virsh-domain.c | 39 ++++- tools/virt-admin.c | 41 +++++ 34 files changed, 1146 insertions(+), 168 deletions(-) -- 2.48.1

3 39

[PATCH v8 00/18] *** qemu: block: Support block disk along with throttle filters ***
by Harikumar Rajkumar 17 Mar '25

17 Mar '25

*** Support block disk along with throttle filters *** Chun Feng Wu (17): schema: Add new domain elements to support multiple throttle groups schema: Add new domain elements to support multiple throttle filters config: Introduce ThrottleGroup and corresponding XML parsing config: Introduce ThrottleFilter and corresponding XML parsing qemu: monitor: Add support for ThrottleGroup operations tests: Test qemuMonitorJSONGetThrottleGroup and qemuMonitorJSONUpdateThrottleGroup remote: New APIs for ThrottleGroup lifecycle management qemu: Refactor qemuDomainSetBlockIoTune to extract common methods qemu: Implement qemu driver for throttle API qemu: helper: throttle filter nodename and preparation processing qemu: block: Support block disk along with throttle filters config: validate: Verify iotune, throttle group and filter qemuxmlconftest: Add 'throttlefilter' tests test_driver: Test throttle group lifecycle APIs virsh: Refactor iotune options for re-use virsh: Add support for throttle group operations virsh: Add option "throttle-groups" to "attach_disk" Harikumar Rajkumar (1): qemustatusxml2xmldata: Add 'throttlefilter' tests This patch version addresses the feedback provided on patch v5, which includes the following modifications: * Reimplementation of the "get throttle group" to query from the XML. * Allowing the SET API to reset the throttle group config fields to its default in QEMU. * Updating the version to 11.1.0. * Implementing various coding style changes as suggested. * Removal of unnecessary comments. docs/formatdomain.rst | 47 ++ docs/manpages/virsh.rst | 137 +++- include/libvirt/libvirt-domain.h | 14 + src/conf/domain_conf.c | 407 ++++++++++ src/conf/domain_conf.h | 47 ++ src/conf/domain_validate.c | 118 ++- src/conf/schemas/domaincommon.rng | 293 ++++--- src/conf/virconftypes.h | 4 + src/driver-hypervisor.h | 14 + src/libvirt-domain.c | 122 +++ src/libvirt_private.syms | 8 + src/libvirt_public.syms | 6 + src/qemu/qemu_block.c | 136 ++++ src/qemu/qemu_block.h | 49 ++ src/qemu/qemu_command.c | 180 +++++ src/qemu/qemu_command.h | 6 + src/qemu/qemu_domain.c | 77 +- src/qemu/qemu_driver.c | 485 +++++++++--- src/qemu/qemu_hotplug.c | 29 + src/qemu/qemu_monitor.c | 21 + src/qemu/qemu_monitor.h | 9 + src/qemu/qemu_monitor_json.c | 129 +++ src/qemu/qemu_monitor_json.h | 14 + src/remote/remote_daemon_dispatch.c | 105 +++ src/remote/remote_driver.c | 3 + src/remote/remote_protocol.x | 50 +- src/remote_protocol-structs | 28 + src/test/test_driver.c | 367 ++++++--- tests/qemumonitorjsontest.c | 86 ++ .../throttlefilter-in.xml | 392 ++++++++++ .../throttlefilter-out.xml | 393 ++++++++++ tests/qemuxmlactivetest.c | 1 + .../throttlefilter-invalid.x86_64-latest.err | 1 + .../throttlefilter-invalid.xml | 89 +++ .../throttlefilter.x86_64-latest.args | 55 ++ .../throttlefilter.x86_64-latest.xml | 105 +++ tests/qemuxmlconfdata/throttlefilter.xml | 95 +++ tests/qemuxmlconftest.c | 2 + tools/virsh-completer-domain.c | 82 ++ tools/virsh-completer-domain.h | 16 + tools/virsh-domain.c | 736 ++++++++++++++---- 41 files changed, 4428 insertions(+), 530 deletions(-) create mode 100644 tests/qemustatusxml2xmldata/throttlefilter-in.xml create mode 100644 tests/qemustatusxml2xmldata/throttlefilter-out.xml create mode 100644 tests/qemuxmlconfdata/throttlefilter-invalid.x86_64-latest.err create mode 100644 tests/qemuxmlconfdata/throttlefilter-invalid.xml create mode 100644 tests/qemuxmlconfdata/throttlefilter.x86_64-latest.args create mode 100644 tests/qemuxmlconfdata/throttlefilter.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/throttlefilter.xml -- 2.39.5 (Apple Git-154)

2 48

[PATCH v2 00/21] Add qemu RDP server support
by marcandre.lureau＠redhat.com 17 Mar '25

17 Mar '25

From: Marc-André Lureau <marcandre.lureau(a)redhat.com> Hi, This patch series offers an out-of-process Remote Desktop Protocol (RDP) server solution utilizing QEMU's -display dbus interface, offering improved modularity and potential security benefits compared to built-in server. This initiative was spearheaded by Mihnea Buzatu during the QEMU Summer of Code 2023. The project's goal was to develop an out-of-process RDP server using the -display dbus interface, implemented in Rust. Given that the IronRDP crate lacked some server support at the time, investments in IronRDP were required. I finally released an initial v0.1 version of qemu-rdp on crates.io (https://crates.io/crates/qemu-rdp) That should allow more people to review and evaluate the state of this work. On unix systems, with cargo/rust toolchain installed, it should be as easy as running "cargo install qemu-rdp", apply this patch series for libvirt, set the "rdp_tls_x509_cert_dir" location for your TLS certificates, and configure a VM with both dbus & rdp graphics (run "virsh domdisplay DOMAIN" to get the display connection details). Thanks for the reviews & feedback! v2: thanks to Daniel review - drop extra error report from "qemu: report an error for unsupported graphics" - replace g_return pre-conditions with ATTRIBUTE_NONNULL - improve "qemu/dbus: keep a connection to the VM D-Bus" to also reconnect - use domainLogContext for logging (for virtiofs as well) - check for qemu-rdp availabilty for setting 'rdp' capability - make dbus-addr qemu-rdp capability mandatory - rebased - add r-b tags Marc-André Lureau (21): build-sys: drop -Winline when optimization=g build: fix -Werror=maybe-uninitialized qemu-slirp: drop unneeded check for OOM util: annotate non-null arguments for virGDBusCallMethod() qemu: fall-through for unsupported graphics qemu: add rdp state directory qemu: add qemu RDP configuration conf: parse optional RDP username & password conf: generalize virDomainDefHasSpiceGraphics qemu: use virDomainDefHasGraphics qemu: add RDP ports range allocator qemu: limit to one <graphics type='rdp'> qemu/virtiofs: use domainLogContext qemu/dbus: keep a connection to the VM D-Bus qemu/dbus: log daemon stdout/err, use domainLogContext qemu: validate RDP configuration qemu: add qemu-rdp helper unit qemu: pass virQEMUDriverConfig to capabilities qemu: add 'rdp' capability if qemu-rdp is available qemu: add RDP support tests: add qemu <graphics type='rdp'/> test docs/formatdomain.rst | 25 +- meson.build | 7 +- po/POTFILES | 1 + src/conf/domain_conf.c | 28 +- src/conf/domain_conf.h | 5 +- src/conf/schemas/domaincommon.rng | 10 + src/libvirt_private.syms | 2 +- src/qemu/libvirtd_qemu.aug | 7 + src/qemu/meson.build | 1 + src/qemu/qemu.conf.in | 31 ++ src/qemu/qemu_capabilities.c | 24 +- src/qemu/qemu_capabilities.h | 12 +- src/qemu/qemu_command.c | 9 +- src/qemu/qemu_conf.c | 56 ++- src/qemu/qemu_conf.h | 13 + src/qemu/qemu_dbus.c | 69 ++- src/qemu/qemu_dbus.h | 3 + src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domain.h | 4 + src/qemu/qemu_driver.c | 20 + src/qemu/qemu_extdevice.c | 46 +- src/qemu/qemu_hotplug.c | 49 ++- src/qemu/qemu_hotplug.h | 1 + src/qemu/qemu_process.c | 170 ++++++- src/qemu/qemu_rdp.c | 416 ++++++++++++++++++ src/qemu/qemu_rdp.h | 73 +++ src/qemu/qemu_slirp.c | 6 - src/qemu/qemu_validate.c | 48 +- src/qemu/qemu_virtiofs.c | 53 +-- src/qemu/test_libvirtd_qemu.aug.in | 5 + src/util/virgdbus.h | 13 +- .../domaincapsdata/qemu_10.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_10.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_10.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_10.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_7.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_7.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_7.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_7.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_7.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_7.1.0.x86_64.xml | 1 + .../qemu_7.2.0-hvf.x86_64+hvf.xml | 1 + .../domaincapsdata/qemu_7.2.0-q35.x86_64.xml | 1 + .../qemu_7.2.0-tcg.x86_64+hvf.xml | 1 + .../domaincapsdata/qemu_7.2.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_7.2.0.ppc.xml | 1 + tests/domaincapsdata/qemu_7.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_8.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_8.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_8.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_8.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_8.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_8.1.0.s390x.xml | 1 + tests/domaincapsdata/qemu_8.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_8.2.0-q35.x86_64.xml | 1 + .../qemu_8.2.0-tcg-virt.loongarch64.xml | 1 + .../domaincapsdata/qemu_8.2.0-tcg.x86_64.xml | 1 + .../qemu_8.2.0-virt.aarch64.xml | 1 + .../qemu_8.2.0-virt.loongarch64.xml | 1 + tests/domaincapsdata/qemu_8.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_8.2.0.armv7l.xml | 1 + tests/domaincapsdata/qemu_8.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_8.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_9.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_9.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_9.0.0.sparc.xml | 1 + tests/domaincapsdata/qemu_9.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_9.1.0-q35.x86_64.xml | 1 + .../qemu_9.1.0-tcg-virt.riscv64.xml | 1 + .../domaincapsdata/qemu_9.1.0-tcg.x86_64.xml | 1 + .../qemu_9.1.0-virt.riscv64.xml | 1 + tests/domaincapsdata/qemu_9.1.0.s390x.xml | 1 + tests/domaincapsdata/qemu_9.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_9.2.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_9.2.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_9.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_9.2.0.x86_64.xml | 1 + tests/domaincapstest.c | 7 +- .../graphics-rdp.x86_64-latest.args | 35 ++ .../graphics-rdp.x86_64-latest.xml | 1 + tests/qemuxmlconfdata/graphics-rdp.xml | 43 ++ tests/qemuxmlconftest.c | 2 + tests/testutilsqemu.c | 10 + tools/nss/libvirt_nss_leases.c | 2 +- tools/nss/libvirt_nss_macs.c | 2 +- 85 files changed, 1218 insertions(+), 138 deletions(-) create mode 100644 src/qemu/qemu_rdp.c create mode 100644 src/qemu/qemu_rdp.h create mode 100644 tests/qemuxmlconfdata/graphics-rdp.x86_64-latest.args create mode 120000 tests/qemuxmlconfdata/graphics-rdp.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/graphics-rdp.xml -- 2.47.0

4 42

[PATCH] news: Add item for guest load averages
by Martin Kletzander 17 Mar '25

17 Mar '25

Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- NEWS.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 9c940b1a8176..d7d40cf5546d 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,8 @@ v11.2.0 (unreleased) * **New features** + * qemu: Added guest load averages to the output of virDomainGetGuestInfo + * **Improvements** * **Bug fixes** -- 2.48.1

2 2

[PATCH] docs: document workaround for DMARC countermeasures
by Daniel P. Berrangé 17 Mar '25

17 Mar '25

From: Daniel P. Berrangé <berrange(a)redhat.com> If a contributor's email domain has a DMARC policy of 'p=quarantine' or 'p=reject', mailman will apply DMARC countermeasures on all mails sent to lists.libvirt.org rewriting the "From" header to remove the sender's email address. e.g. From: Your Name via <lists.libvirt.org> If these countermeasures were not applied, affected mail would either have gon directly to SPAM, or have been entirely rejected. Mailman3 is unable to be configured to guarantee no mangling of the mail body so these countermeasures are unavoidable for lists.libvirt.org. Amongst the various downsides, the From address rewriting has the bad effect of mangling git commit author attribution. To avoid this it is required to add two additional git config settings: $ git config --global format.from "Your Name <your(a)email.com>" $ git config --global format.forceInBodyFrom true Note, *both* are required, even if your ``format.from`` matches your existing git identity, because the latter only takes effect once the former is set. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/submitting-patches.rst | 66 ++++++++++++++++++++++++++++--------- 1 file changed, 51 insertions(+), 15 deletions(-) diff --git a/docs/submitting-patches.rst b/docs/submitting-patches.rst index a5e108550a..b22e4e03b4 100644 --- a/docs/submitting-patches.rst +++ b/docs/submitting-patches.rst @@ -43,21 +43,7 @@ series of two or more patches needs a cover letter. Note that the ``git send-email`` subcommand may not be in the main git package and using it may require installation of a separate package, for example the "git-email" package in Fedora -and Debian. If this is your first time using -``git send-email``, you might need to configure it to point it -to your SMTP server with something like: - -:: - - $ git config --global sendemail.smtpServer stmp.youremailprovider.net - -If you get tired of typing ``--to=devel(a)lists.libvirt.org`` all -the time, you can configure that to be automatically handled as -well: - -:: - - $ git config sendemail.to devel(a)lists.libvirt.org +and Debian. Avoid using mail clients for sending patches, as most of them will mangle the messages in some way, making them unusable for @@ -88,6 +74,56 @@ Moreover, such patch needs to be prefixed correctly with ``git send-email`` (substitute ``v2`` with the correct version if needed though). +Git Configuration +----------------- + +If this is your first time using ``git send-email``, you will probably +need to setup your global git configuration, to point to your outgoing +SMTP server with something like: + +:: + + $ git config --global sendemail.smtpServer stmp.youremailprovider.net + +If your email provider (often your employer) has configured a DMARC +policy for their domain, there are some additional settings that will +be required. Before doing this, check the DMARC policy with + +:: + + $ host -t txt _dmarc.$YOURDOMAIN.COM + +If this returns no output, or contains ``p=none`` then no configuration +is required. If it reports ``p=quarantine`` or ``p=reject``, then the +libvirt lists will apply DMARC countermeasures to your email. To ensure +that git authorship is preserved add + +:: + + $ git config --global format.from "Your Name <your(a)email.com>" + $ git config --global format.forceInBodyFrom true + +This will force git to always add an additional line + +:: + + From: Your Name <your(a)email.com> + +in the body of the patch, guaranteeing correct author records even +when the main ``From`` header is rewritten by mailman. + +If you get tired of typing ``--to=devel(a)lists.libvirt.org`` all +the time, you can configure that to be automatically handled by +adding a local repository setting: + +:: + + $ git config sendemail.to devel(a)lists.libvirt.org + +This last setting is not required if using ``git-publish`` to send +patches, as that auto-identifies the mailing list address from its +config file stored in git. + Review process -------------- -- 2.48.1

3 3

[PATCHv2 0/2] ch: minor fixes - segfault and last meaningful error preservation
by Kirill Shchetiniuk 17 Mar '25

17 Mar '25

During fixing some other issue found out a few minor bugs related to CH driver. First bug is related to monitor object ref count in virCHStartEventHandler and virCHEventHandlerLoop, as object was unrefed by parent while is still used by child thread. Moved object unref to the correct place to the correct thread. Second bug is related to v object ref count in virCHStartEventHandler, as vm object was unrefed, while is still used later, move object unref to after its last usage. Third bug is related to error handling and propagation. Last meaninful error was reset by virCHProcessStop, which have led to unknown error message in virsh. Add error preservation at the begining of the function and restoring it at the end to keep consistent error output Kirill Shchetiniuk (2): ch: virCHProcessStop preserve last meaningful error ch: ref count fix in virCHEventHandlerLoop and virCHStartEventHandler src/ch/ch_events.c | 4 ++-- src/ch/ch_process.c | 5 +++++ 2 files changed, 7 insertions(+), 2 deletions(-) -- 2.48.1

2 3

[PATCH] docs: Fix some types
by Thomas Huth 17 Mar '25

17 Mar '25

From: Thomas Huth <thuth(a)redhat.com> Found with the codespell utility. Signed-off-by: Thomas Huth <thuth(a)redhat.com> --- docs/formatcaps.rst | 2 +- docs/formatdomain.rst | 4 ++-- docs/glib-adoption.rst | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/formatcaps.rst b/docs/formatcaps.rst index da6b215780..7e525487e7 100644 --- a/docs/formatcaps.rst +++ b/docs/formatcaps.rst @@ -39,7 +39,7 @@ The ``<host/>`` element consists of the following child elements: The host CPU architecture and features. Note that, while this element contains a ``topology`` sub-element, - the information contained therein is farily high-level and likely + the information contained therein is fairly high-level and likely not very useful when it comes to optimizing guest vCPU placement. Look into the ``topology`` *element*, described below, for more detailed information. diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index c1876ad467..4bc6a318f5 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -3468,7 +3468,7 @@ paravirtualized driver is specified via the ``disk`` element. automatically distributed among the configured iothreads. Optionally the ``iothread`` element can have multiple ``queue`` - subelements with mandatory ``id`` atribute specifying that the iothread + subelements with mandatory ``id`` attribute specifying that the iothread should be used to handle given virt queue. If queue mapping is present the ``queues`` attribute of ``driver`` must be configured and all configured virt queues must be included in the mapping. The @@ -8423,7 +8423,7 @@ Example: usage of external TPM emulator :since:`Since 9.0.0` This element does not work with the ``passthrough`` backend. - When specified, it is the user's responsability to prevent files from being + When specified, it is the user's responsibility to prevent files from being used by multiple VMs or emulators (swtpm will also use advisory locking). If not specified, the storage configuration is left to libvirt discretion. diff --git a/docs/glib-adoption.rst b/docs/glib-adoption.rst index f969ac80a1..c2cec80eea 100644 --- a/docs/glib-adoption.rst +++ b/docs/glib-adoption.rst @@ -32,7 +32,7 @@ Array operations https://developer.gnome.org/glib/stable/glib-Arrays.html - Instead of using plain C arrays, it is preferrable to use one of + Instead of using plain C arrays, it is preferable to use one of the GLib types, ``GArray``, ``GPtrArray`` or ``GByteArray``. These all use a struct to track the array memory and size together and efficiently resize. -- 2.48.1

3 3

[PATCH] docs: remove references to removed APIs
by Daniel P. Berrangé 17 Mar '25

17 Mar '25

The glib adoption docs was suggesting avoidance of certain APIs that were obsoleted by glib, during the transition period. Now that the referenced APIs no longer exist in libvirt code, they can also be removed from the docs. NB, the virStringListRemoveDuplicates method remains since there is no glib equivalent. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/glib-adoption.rst | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/docs/glib-adoption.rst b/docs/glib-adoption.rst index f969ac80a1..046cd821f7 100644 --- a/docs/glib-adoption.rst +++ b/docs/glib-adoption.rst @@ -14,19 +14,6 @@ the GLib APIs straight away where possible. The following is a list of libvirt APIs that should no longer be used in new code, and their suggested GLib replacements: -Memory allocation - ``VIR_ALLOC``, ``VIR_REALLOC``, ``VIR_RESIZE_N``, - ``VIR_EXPAND_N``, ``VIR_SHRINK_N``, ``VIR_FREE`` - - https://developer.gnome.org/glib/stable/glib-Memory-Allocation.html - - Prefer the GLib APIs ``g_new0``/``g_renew``/ ``g_free`` in most - cases. There should rarely be a need to use - ``g_malloc``/``g_realloc``. **NEVER MIX** use of the classic - libvirt memory allocation APIs and GLib APIs within a single - method. Keep the style consistent, converting existing code to - GLib style in a separate, prior commit. - Array operations ``VIR_APPEND_ELEMENT``, ``VIR_INSERT_ELEMENT``, ``VIR_DELETE_ELEMENT`` @@ -37,15 +24,6 @@ Array operations These all use a struct to track the array memory and size together and efficiently resize. -String arrays - ``virStringList*``, ``virStringListCount*`` - - https://developer.gnome.org/glib/stable/glib-String-Utility-Functions.html - - Prefer the NULL-terminated variant instead of storing the count - separately. Prefer ``g_str*v`` functions instead of their ``vir*`` - counterparts. For use with ``g_auto`` GLib provides the ``GStrv`` type. - Objects ``virObject`` -- 2.48.1

2 1

[PATCH] scripts: add execute permission to several files
by Daniel P. Berrangé 17 Mar '25

17 Mar '25

From: Daniel P. Berrangé <berrange(a)redhat.com> Most, but not all, files in scripts have execute permission. While we don't need this in order to launch them via meson/ninja build rules, it is nice to direct execution if they have execution permission. This makes the practice consistent across all scripts. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- scripts/check-drivername.py | 0 scripts/check-remote-protocol.py | 0 scripts/header-ifdef.py | 0 scripts/meson-install-dirs.py | 0 scripts/meson-install-symlink.py | 0 scripts/mock-noinline.py | 0 scripts/prohibit-duplicate-header.py | 0 7 files changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 scripts/check-drivername.py mode change 100644 => 100755 scripts/check-remote-protocol.py mode change 100644 => 100755 scripts/header-ifdef.py mode change 100644 => 100755 scripts/meson-install-dirs.py mode change 100644 => 100755 scripts/meson-install-symlink.py mode change 100644 => 100755 scripts/mock-noinline.py mode change 100644 => 100755 scripts/prohibit-duplicate-header.py diff --git a/scripts/check-drivername.py b/scripts/check-drivername.py old mode 100644 new mode 100755 diff --git a/scripts/check-remote-protocol.py b/scripts/check-remote-protocol.py old mode 100644 new mode 100755 diff --git a/scripts/header-ifdef.py b/scripts/header-ifdef.py old mode 100644 new mode 100755 diff --git a/scripts/meson-install-dirs.py b/scripts/meson-install-dirs.py old mode 100644 new mode 100755 diff --git a/scripts/meson-install-symlink.py b/scripts/meson-install-symlink.py old mode 100644 new mode 100755 diff --git a/scripts/mock-noinline.py b/scripts/mock-noinline.py old mode 100644 new mode 100755 diff --git a/scripts/prohibit-duplicate-header.py b/scripts/prohibit-duplicate-header.py old mode 100644 new mode 100755 -- 2.48.1

2 1

Fwd: system cache dropped
by matus valentin 17 Mar '25

17 Mar '25

Hi, I have a setup with multiple virtual machines (VMs) running on one host, each with a saved state. All VMs share the same parent, which is located on a shared drive. Whenever I restore any VM using virsh restore, the parent is dropped from the system cache, causing all data to be downloaded from the shared drive again. This results in unnecessary network traffic, even though the parent changes very rarely. However, if I create a child from the parent and call virsh create to create a new VM, the parent is never dropped from the system cache. Is this expected behavior? Should the parent be retained in the system cache during a virsh restore operation? Are there any configurations or settings that can prevent the parent from being dropped from the cache? thanks

1 0

[PATCH] NEWS: Mention new 'image_format' parameter for virDomainSaveParams
by Jim Fehlig 14 Mar '25

14 Mar '25

Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- NEWS.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 9c940b1a81..d08a18dc02 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,14 @@ v11.2.0 (unreleased) * **New features** + * qemu: Add new 'image_format' parameter to virDomainSaveParams + + ``virDomainSaveParams`` now supports an ``image_format`` parameter for + specifying the save image format on a per-domain basis. The parameter + accepts the same values as the driver-wide ``save_image_format`` setting + in ``qemu.conf``. An image format specified via ``virDomainSaveParams`` + takes precedence over the driver-wide setting. + * **Improvements** * **Bug fixes** -- 2.43.0

2 2

[libvirt PATCH 00/10] Unused cleanups
by Ján Tomko 13 Mar '25

13 Mar '25

Patches 4-9/10 all depend on patch 3/10 10/10 can be pushed independently Ján Tomko (10): qemu: seccomp sandbox: remove incorect G_GNUC_UNUSED marker qemu: validate: fs: remove unneeded parameter qemu: remove qemuCaps from qemuBuildObjectCommandlineFromJSON qemu: remove qemuCaps from qemuBuildObjectSecretCommandLine qemu: remove qemuCaps from qemuBuildTLSx509CommandLine qemu: remove qemuCaps from qemuBuildObjectCommandline qemu: remove qemuCaps from qemuBuildIOThreadCommandLine qemu: remove unused vm from qemuBuildSEVSNPCommandLine qemu: remove unused vm from qemuBuildPVCommandLine Remove unreachable breaks right after return src/qemu/qemu_cgroup.c | 2 - src/qemu/qemu_command.c | 110 +++++++++++++------------------ src/qemu/qemu_driver.c | 1 - src/qemu/qemu_hotplug.c | 1 - src/qemu/qemu_monitor_json.c | 1 - src/qemu/qemu_validate.c | 3 +- src/security/security_apparmor.c | 1 - src/vmx/vmx.c | 2 - tools/virsh-domain.c | 1 - tools/virsh-host.c | 2 - tools/vsh.c | 7 -- 11 files changed, 48 insertions(+), 83 deletions(-) -- 2.48.1

4 16

[PATCH 0/2] src: make it easier to updat the protocol structs files
by Daniel P. Berrangé 13 Mar '25

13 Mar '25

This introduces a new target: ninja -C build regen-admin_protocol and equiv for other protocol files Daniel P. Berrangé (2): src: normalize whitespace in protocol structs files src: add new target for regenerating protocol structs files scripts/check-remote-protocol.py | 27 ++++++++++++++++++++++++++- src/admin_protocol-structs | 2 +- src/meson.build | 14 ++++++++++++++ src/qemu_protocol-structs | 2 +- src/remote_protocol-structs | 6 +++--- 5 files changed, 45 insertions(+), 6 deletions(-) -- 2.48.1

2 4

[PATCH 0/6] Couple of memleak fixes
by Michal Privoznik 13 Mar '25

13 Mar '25

*** BLURB HERE *** Michal Prívozník (6): network: Free inhibitor in networkStateCleanup() ch: Free retval of curl_slist_append() ch: Don't leak virCHDomainObjPrivate struct members ch: Free @iothreads array in virCHProcessSetupIOThreads() ch: Unref @cfg in virCHProcessStop() ch: Rework virCHProcessConnectMonitor() src/ch/ch_domain.c | 3 +++ src/ch/ch_monitor.c | 3 +++ src/ch/ch_process.c | 22 +++++++++++++--------- src/network/bridge_driver.c | 2 ++ 4 files changed, 21 insertions(+), 9 deletions(-) -- 2.48.1

2 13

[PATCH 00/17] qemu: Clean up various unneeded capabilities
by Peter Krempa 13 Mar '25

13 Mar '25

The recent bump of minimum qemu version resulted into some capabilities always being present. I've noticed one while doing a review and from there I removed a few others, mostly storage related ones as well. Peter Krempa (17): qemuBuildCompatDeprecatedCommandLine: Assume that QEMU_CAPS_COMPAT_DEPRECATED is supported qemu: capabilities: Retire QEMU_CAPS_COMPAT_DEPRECATED qemuBuildObjectCommandlineFromJSON: Assume all qemus support QEMU_CAPS_OBJECT_JSON qemu: monitor: Drop support for extra wrapper for 'object_add' util: Drop 'virQEMUBuildCommandLineJSONArrayBitmap' qemu: capabilities: Retire QEMU_CAPS_OBJECT_JSON qemu: monitor: Always assume support for QEMU_CAPS_QMP_QUERY_NAMED_BLOCK_NODES_FLAT qemu: capabilities: Retire QEMU_CAPS_QMP_QUERY_NAMED_BLOCK_NODES_FLAT qemu: Always assume supprot for QEMU_CAPS_BLOCKDEV_REOPEN qemu: capabilities: Retire QEMU_CAPS_BLOCKDEV_REOPEN qemu: Always assume support for QEMU_CAPS_BLOCKDEV_SNAPSHOT_ALLOW_WRITE_ONLY qemu: capabilities: Retire QEMU_CAPS_BLOCKDEV_SNAPSHOT_ALLOW_WRITE_ONLY qemu: Always assume support for QEMU_CAPS_INCREMENTAL_BACKUP qemu: capabilites: Retire QEMU_CAPS_INCREMENTAL_BACKUP qemu: domain: Remove qemuDomainSupportsCheckpointsBlockjobs qemu: migration: Always assume support for QEMU_CAPS_MIGRATION_PARAM_BLOCK_BITMAP_MAPPING qemu: capabilites: Retire QEMU_CAPS_MIGRATION_PARAM_BLOCK_BITMAP_MAPPING src/libvirt_private.syms | 1 - src/qemu/qemu_backup.c | 18 --------- src/qemu/qemu_block.c | 4 -- src/qemu/qemu_blockjob.c | 20 ++-------- src/qemu/qemu_capabilities.c | 33 +++++------------ src/qemu/qemu_capabilities.h | 14 +++---- src/qemu/qemu_checkpoint.c | 18 +-------- src/qemu/qemu_command.c | 31 +++------------- src/qemu/qemu_domain.c | 23 ------------ src/qemu/qemu_domain.h | 4 -- src/qemu/qemu_driver.c | 37 +++++-------------- src/qemu/qemu_migration.c | 10 +---- src/qemu/qemu_monitor.c | 28 +------------- src/qemu/qemu_monitor_json.c | 2 +- src/qemu/qemu_monitor_priv.h | 4 -- src/qemu/qemu_snapshot.c | 4 -- src/util/virqemu.c | 36 ------------------ src/util/virqemu.h | 3 -- .../caps_10.0.0_s390x.xml | 7 ---- .../caps_10.0.0_x86_64+amdsev.xml | 7 ---- .../caps_10.0.0_x86_64.xml | 7 ---- .../qemucapabilitiesdata/caps_6.2.0_ppc64.xml | 7 ---- .../caps_6.2.0_x86_64.xml | 7 ---- .../qemucapabilitiesdata/caps_7.0.0_ppc64.xml | 7 ---- .../caps_7.0.0_x86_64.xml | 7 ---- .../qemucapabilitiesdata/caps_7.1.0_ppc64.xml | 7 ---- .../caps_7.1.0_x86_64.xml | 7 ---- tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml | 7 ---- .../caps_7.2.0_x86_64+hvf.xml | 7 ---- .../caps_7.2.0_x86_64.xml | 7 ---- .../caps_8.0.0_x86_64.xml | 7 ---- .../qemucapabilitiesdata/caps_8.1.0_s390x.xml | 7 ---- .../caps_8.1.0_x86_64.xml | 7 ---- .../caps_8.2.0_aarch64.xml | 7 ---- .../caps_8.2.0_armv7l.xml | 7 ---- .../caps_8.2.0_loongarch64.xml | 7 ---- .../qemucapabilitiesdata/caps_8.2.0_s390x.xml | 7 ---- .../caps_8.2.0_x86_64.xml | 7 ---- .../qemucapabilitiesdata/caps_9.0.0_sparc.xml | 7 ---- .../caps_9.0.0_x86_64.xml | 7 ---- .../caps_9.1.0_riscv64.xml | 7 ---- .../qemucapabilitiesdata/caps_9.1.0_s390x.xml | 7 ---- .../caps_9.1.0_x86_64.xml | 7 ---- .../caps_9.2.0_aarch64+hvf.xml | 7 ---- .../qemucapabilitiesdata/caps_9.2.0_s390x.xml | 7 ---- .../caps_9.2.0_x86_64+amdsev.xml | 7 ---- .../caps_9.2.0_x86_64.xml | 7 ---- tests/qemucommandutiltest.c | 30 --------------- 48 files changed, 40 insertions(+), 483 deletions(-) -- 2.48.1

3 21

[PATCH v4 0/1] add RAPL feature in libvirt
by Anthony Harivel 13 Mar '25

13 Mar '25

Hi, The enhancement in this new version based on last feedback are: * add more documentation on limitation of the feature * no more double check of the vmsr socket, once is enough * virQEMUBuildBufferEscapeComma() is used for user input Path Because there is no garantie at the moment that the helper will be one day managed by libvirt, I decided not adding any preparation about this to avoid any confusion but add more documentation. If the helper is managed in libvirt, the patch introducing it will also add the necessary API like mention on the previous review (i.e mode='unmanaged'). Thanks Anthony Anthony Harivel (1): qemu: Add support for RAPL MSRs feature docs/formatdomain.rst | 15 +++++++++++++++ src/conf/domain_conf.c | 18 ++++++++++++++++++ src/conf/domain_conf.h | 2 ++ src/conf/schemas/domaincommon.rng | 10 ++++++++++ src/qemu/qemu_command.c | 9 +++++++++ tests/qemuxmlconfdata/kvm-features-off.xml | 1 + .../kvm-features.x86_64-latest.args | 2 +- tests/qemuxmlconfdata/kvm-features.xml | 1 + 8 files changed, 57 insertions(+), 1 deletion(-) -- 2.48.1

2 2

[PATCH] domainbackupxml2xml: Add test case with unix socket server for pull mode backup
by Peter Krempa 12 Mar '25

12 Mar '25

While we show the example in the docs we don't have an example XML for exrecrcising the parser/formatter and schema. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- .../backup-pull-unix.xml | 22 ++++++++++++++++++ .../backup-pull-unix.xml | 23 +++++++++++++++++++ tests/genericxml2xmltest.c | 1 + 3 files changed, 46 insertions(+) create mode 100644 tests/domainbackupxml2xmlin/backup-pull-unix.xml create mode 100644 tests/domainbackupxml2xmlout/backup-pull-unix.xml diff --git a/tests/domainbackupxml2xmlin/backup-pull-unix.xml b/tests/domainbackupxml2xmlin/backup-pull-unix.xml new file mode 100644 index 0000000000..cde9ceafc9 --- /dev/null +++ b/tests/domainbackupxml2xmlin/backup-pull-unix.xml @@ -0,0 +1,22 @@ +<domainbackup mode='pull'> + <incremental>1525889631</incremental> + <server transport='unix' socket='/path/to/server'/> + <disks> + <disk name='vda' type='file'> + <scratch file='/path/to/file'/> + </disk> + <disk name='hda' backup='no'/> + <disk name='vdc' type='file' backupmode='full'> + <scratch file='/path/to/file'/> + </disk> + <disk name='vdd' type='file' backupmode='incremental'> + <scratch file='/path/to/file'/> + </disk> + <disk name='vde' type='file' backupmode='incremental' incremental='blah'> + <scratch file='/path/to/file'/> + </disk> + <disk name='vdf' type='file' incremental='bleh'> + <scratch file='/path/to/file'/> + </disk> + </disks> +</domainbackup> diff --git a/tests/domainbackupxml2xmlout/backup-pull-unix.xml b/tests/domainbackupxml2xmlout/backup-pull-unix.xml new file mode 100644 index 0000000000..811edfdf39 --- /dev/null +++ b/tests/domainbackupxml2xmlout/backup-pull-unix.xml @@ -0,0 +1,23 @@ +<domainbackup mode='pull'> + <incremental>1525889631</incremental> + <server transport='unix' socket='/path/to/server'/> + <disks> + <disk name='vda' backup='yes' type='file' backupmode='incremental' incremental='1525889631'> + <scratch file='/path/to/file'/> + </disk> + <disk name='hda' backup='no'/> + <disk name='vdc' backup='yes' type='file' backupmode='full'> + <scratch file='/path/to/file'/> + </disk> + <disk name='vdd' backup='yes' type='file' backupmode='incremental' incremental='1525889631'> + <scratch file='/path/to/file'/> + </disk> + <disk name='vde' backup='yes' type='file' backupmode='incremental' incremental='blah'> + <scratch file='/path/to/file'/> + </disk> + <disk name='vdf' backup='yes' type='file' backupmode='incremental' incremental='bleh'> + <scratch file='/path/to/file'/> + </disk> + <disk name='vdextradisk' backup='no'/> + </disks> +</domainbackup> diff --git a/tests/genericxml2xmltest.c b/tests/genericxml2xmltest.c index 61613d21f9..b46b9515c3 100644 --- a/tests/genericxml2xmltest.c +++ b/tests/genericxml2xmltest.c @@ -244,6 +244,7 @@ mymain(void) DO_TEST_BACKUP("empty"); DO_TEST_BACKUP("backup-pull"); + DO_TEST_BACKUP("backup-pull-unix"); DO_TEST_BACKUP("backup-pull-seclabel"); DO_TEST_BACKUP("backup-pull-encrypted"); DO_TEST_BACKUP("backup-push"); -- 2.48.1

2 1

[PATCH 0/2] Remove libnl checks specific to Linux
by Akihiko Odaki 12 Mar '25

12 Mar '25

Supersedes: <20250308-require-v1-1-fe6850bf3f30(a)daynix.com> ("[PATCH] util: Require libnl for Linux") Based on previous discussions, this implements yet another approach to fix builds without libnl for Linux. Signed-off-by: Akihiko Odaki <akihiko.odaki(a)daynix.com> --- Akihiko Odaki (2): Remove libnl checks specific to Linux virnetlink: Remove stub functions src/libvirt_libnl.syms | 23 ++++++ src/libvirt_private.syms | 19 ----- src/meson.build | 6 ++ src/remote/remote_daemon.c | 10 ++- src/util/meson.build | 5 +- src/util/virarptable.c | 2 +- src/util/virnetdev.c | 44 +--------- src/util/virnetdevbridge.c | 33 ++------ src/util/virnetlink.c | 196 +++------------------------------------------ src/util/virnetlink.h | 11 +-- tests/virnetdevtest.c | 10 +-- 11 files changed, 65 insertions(+), 294 deletions(-) --- base-commit: e5299ddf86121d3c792ca271ffcb54900eb19dc3 change-id: 20250312-linux-30e6e1af51a5 Best regards, -- Akihiko Odaki <akihiko.odaki(a)daynix.com>

1 2

[PATCH 0/5] qemu: Introduce nvme disk emulation support
by honglei.wang＠smartx.com 12 Mar '25

12 Mar '25

From: hongleiwang <honglei.wang(a)smartx.com> QEMU has supported nvme disk emulation for a long time, see: https://qemu-project.gitlab.io/qemu/system/devices/nvme.html. The following patches introduce nvme and nvme-ns disk bus type: A disk with nvme as bus is represented as nvme disk that contains only one nvme namespace. In XML, it can be used like this: <devices> ... <disk type='file' device='disk'> <driver name='qemu' type='raw'/> <source file='/tmp/data.img'/> <target dev='nvmea' bus='nvme'/> <serial>nvme-serial-value</serial> </disk> ... </devices> A disk with nvme-ns as bus is represented as an nvme namespace and needs to be attached to an nvme controller. In XML, it can be used like this: <devices> ... <disk type='file' device='disk'> <driver name='qemu' type='raw'/> <source file='/tmp/data.img'/> <target dev='nvmensa' bus='nvme-ns'/> <address type='drive' controller='0' bus='0' target='0' unit='0'/> </disk> <controller type='nvme' index='0'> <serial>nvme-controller-serial-value</serial> <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/> </controller> ... </devices> ray (5): qemu: Add support for NVMe disk bus type qemu: Add support for NVMe namespace disk bus type qemu_capabilities: Add support for NVMe disk capabilities docs: Add NVMe and NVMe namespace disk bus types to documentation tests: Add test case for NVMe device configuration docs/formatdomain.rst | 5 ++- src/conf/domain_conf.c | 42 +++++++++++++++++++ src/conf/domain_conf.h | 8 ++++ src/conf/domain_postparse.c | 4 ++ src/conf/domain_validate.c | 5 ++- src/conf/schemas/domaincommon.rng | 12 +++++- src/conf/virconftypes.h | 2 + src/hyperv/hyperv_driver.c | 4 ++ src/qemu/qemu_alias.c | 2 + src/qemu/qemu_capabilities.c | 10 +++++ src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_command.c | 31 ++++++++++++++ src/qemu/qemu_domain_address.c | 30 +++++++++++-- src/qemu/qemu_domain_address.h | 4 ++ src/qemu/qemu_hotplug.c | 14 +++++++ src/qemu/qemu_postparse.c | 1 + src/qemu/qemu_validate.c | 40 ++++++++++++++++++ src/test/test_driver.c | 4 ++ src/util/virutil.c | 2 +- src/vbox/vbox_common.c | 3 ++ src/vmx/vmx.c | 2 + tests/domaincapsdata/qemu_10.0.0-q35.x86_64.xml | 2 + tests/domaincapsdata/qemu_10.0.0-tcg.x86_64.xml | 2 + tests/domaincapsdata/qemu_10.0.0.s390x.xml | 2 + tests/domaincapsdata/qemu_10.0.0.x86_64.xml | 2 + tests/domaincapsdata/qemu_5.2.0-q35.x86_64.xml | 2 + .../domaincapsdata/qemu_5.2.0-tcg-virt.riscv64.xml | 2 + tests/domaincapsdata/qemu_5.2.0-tcg.x86_64.xml | 2 + tests/domaincapsdata/qemu_5.2.0-virt.aarch64.xml | 2 + tests/domaincapsdata/qemu_5.2.0-virt.riscv64.xml | 2 + tests/domaincapsdata/qemu_5.2.0.aarch64.xml | 2 + tests/domaincapsdata/qemu_5.2.0.ppc64.xml | 2 + tests/domaincapsdata/qemu_5.2.0.x86_64.xml | 2 + tests/domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 2 + tests/domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 2 + tests/domaincapsdata/qemu_6.0.0-virt.aarch64.xml | 2 + tests/domaincapsdata/qemu_6.0.0.aarch64.xml | 2 + tests/domaincapsdata/qemu_6.0.0.x86_64.xml | 2 + tests/domaincapsdata/qemu_6.1.0-q35.x86_64.xml | 2 + tests/domaincapsdata/qemu_6.1.0-tcg.x86_64.xml | 2 + tests/domaincapsdata/qemu_6.1.0.x86_64.xml | 2 + tests/domaincapsdata/qemu_6.2.0-q35.x86_64.xml | 2 + tests/domaincapsdata/qemu_6.2.0-tcg.x86_64.xml | 2 + tests/domaincapsdata/qemu_6.2.0-virt.aarch64.xml | 2 + tests/domaincapsdata/qemu_6.2.0.aarch64.xml | 2 + tests/domaincapsdata/qemu_6.2.0.ppc64.xml | 2 + tests/domaincapsdata/qemu_6.2.0.x86_64.xml | 2 + .../domaincapsdata/qemu_7.0.0-hvf.aarch64+hvf.xml | 2 + tests/domaincapsdata/qemu_7.0.0-q35.x86_64.xml | 2 + tests/domaincapsdata/qemu_7.0.0-tcg.x86_64.xml | 2 + tests/domaincapsdata/qemu_7.0.0-virt.aarch64.xml | 2 + tests/domaincapsdata/qemu_7.0.0.aarch64.xml | 2 + tests/domaincapsdata/qemu_7.0.0.ppc64.xml | 2 + tests/domaincapsdata/qemu_7.0.0.x86_64.xml | 2 + tests/domaincapsdata/qemu_7.1.0-q35.x86_64.xml | 2 + tests/domaincapsdata/qemu_7.1.0-tcg.x86_64.xml | 2 + tests/domaincapsdata/qemu_7.1.0.ppc64.xml | 2 + tests/domaincapsdata/qemu_7.1.0.x86_64.xml | 2 + tests/domaincapsdata/qemu_7.2.0-hvf.x86_64+hvf.xml | 2 + tests/domaincapsdata/qemu_7.2.0-q35.x86_64.xml | 2 + tests/domaincapsdata/qemu_7.2.0-tcg.x86_64+hvf.xml | 2 + tests/domaincapsdata/qemu_7.2.0-tcg.x86_64.xml | 2 + tests/domaincapsdata/qemu_7.2.0.ppc.xml | 2 + tests/domaincapsdata/qemu_7.2.0.x86_64.xml | 2 + tests/domaincapsdata/qemu_8.0.0-q35.x86_64.xml | 2 + .../domaincapsdata/qemu_8.0.0-tcg-virt.riscv64.xml | 2 + tests/domaincapsdata/qemu_8.0.0-tcg.x86_64.xml | 2 + tests/domaincapsdata/qemu_8.0.0-virt.riscv64.xml | 2 + tests/domaincapsdata/qemu_8.0.0.x86_64.xml | 2 + tests/domaincapsdata/qemu_8.1.0-q35.x86_64.xml | 2 + tests/domaincapsdata/qemu_8.1.0-tcg.x86_64.xml | 2 + tests/domaincapsdata/qemu_8.1.0.x86_64.xml | 2 + tests/domaincapsdata/qemu_8.2.0-q35.x86_64.xml | 2 + .../qemu_8.2.0-tcg-virt.loongarch64.xml | 2 + tests/domaincapsdata/qemu_8.2.0-tcg.x86_64.xml | 2 + tests/domaincapsdata/qemu_8.2.0-virt.aarch64.xml | 2 + .../domaincapsdata/qemu_8.2.0-virt.loongarch64.xml | 2 + tests/domaincapsdata/qemu_8.2.0.aarch64.xml | 2 + tests/domaincapsdata/qemu_8.2.0.armv7l.xml | 2 + tests/domaincapsdata/qemu_8.2.0.s390x.xml | 2 + tests/domaincapsdata/qemu_8.2.0.x86_64.xml | 2 + tests/domaincapsdata/qemu_9.0.0-q35.x86_64.xml | 2 + tests/domaincapsdata/qemu_9.0.0-tcg.x86_64.xml | 2 + tests/domaincapsdata/qemu_9.0.0.x86_64.xml | 2 + tests/domaincapsdata/qemu_9.1.0-q35.x86_64.xml | 2 + .../domaincapsdata/qemu_9.1.0-tcg-virt.riscv64.xml | 2 + tests/domaincapsdata/qemu_9.1.0-tcg.x86_64.xml | 2 + tests/domaincapsdata/qemu_9.1.0-virt.riscv64.xml | 2 + tests/domaincapsdata/qemu_9.1.0.s390x.xml | 2 + tests/domaincapsdata/qemu_9.1.0.x86_64.xml | 2 + tests/domaincapsdata/qemu_9.2.0-q35.x86_64.xml | 2 + tests/domaincapsdata/qemu_9.2.0-tcg.x86_64.xml | 2 + tests/domaincapsdata/qemu_9.2.0.s390x.xml | 2 + tests/domaincapsdata/qemu_9.2.0.x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_10.0.0_s390x.xml | 2 + tests/qemucapabilitiesdata/caps_10.0.0_x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_5.2.0_aarch64.xml | 2 + tests/qemucapabilitiesdata/caps_5.2.0_ppc64.xml | 2 + tests/qemucapabilitiesdata/caps_5.2.0_riscv64.xml | 2 + tests/qemucapabilitiesdata/caps_5.2.0_x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_6.0.0_aarch64.xml | 2 + tests/qemucapabilitiesdata/caps_6.0.0_x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_6.1.0_x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_6.2.0_aarch64.xml | 2 + tests/qemucapabilitiesdata/caps_6.2.0_ppc64.xml | 2 + tests/qemucapabilitiesdata/caps_6.2.0_x86_64.xml | 2 + .../caps_7.0.0_aarch64+hvf.xml | 2 + tests/qemucapabilitiesdata/caps_7.0.0_aarch64.xml | 2 + tests/qemucapabilitiesdata/caps_7.0.0_ppc64.xml | 2 + tests/qemucapabilitiesdata/caps_7.0.0_x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_7.1.0_ppc64.xml | 2 + tests/qemucapabilitiesdata/caps_7.1.0_x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml | 2 + .../qemucapabilitiesdata/caps_7.2.0_x86_64+hvf.xml | 2 + tests/qemucapabilitiesdata/caps_7.2.0_x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_8.0.0_riscv64.xml | 2 + tests/qemucapabilitiesdata/caps_8.0.0_x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_8.1.0_x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_8.2.0_aarch64.xml | 2 + tests/qemucapabilitiesdata/caps_8.2.0_armv7l.xml | 2 + .../caps_8.2.0_loongarch64.xml | 2 + tests/qemucapabilitiesdata/caps_8.2.0_s390x.xml | 2 + tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_9.0.0_x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_9.1.0_riscv64.xml | 2 + tests/qemucapabilitiesdata/caps_9.1.0_s390x.xml | 2 + tests/qemucapabilitiesdata/caps_9.1.0_x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_9.2.0_s390x.xml | 2 + tests/qemucapabilitiesdata/caps_9.2.0_x86_64.xml | 2 + .../disk-nvme-device.x86_64-latest.args | 38 +++++++++++++++++ .../disk-nvme-device.x86_64-latest.xml | 49 ++++++++++++++++++++++ tests/qemuxmlconfdata/disk-nvme-device.xml | 46 ++++++++++++++++++++ tests/qemuxmlconftest.c | 1 + 133 files changed, 569 insertions(+), 8 deletions(-) create mode 100644 tests/qemuxmlconfdata/disk-nvme-device.x86_64-latest.args create mode 100644 tests/qemuxmlconfdata/disk-nvme-device.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/disk-nvme-device.xml -- 2.11.0

3 9

[PATCH v1] tests: update capabilities for QEMU 9.2.0 on s390x
by Shalini Chellathurai Saroja 12 Mar '25

12 Mar '25

Update the replies and xml files for QEMU 9.2.0 on s390x based on the released QEMU tag v9.2.0 with commit Id ae35f033b874c627d81d51070187fbf55f0bf1a7. Signed-off-by: Shalini Chellathurai Saroja <shalini(a)linux.ibm.com> Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com> --- .../caps_9.2.0_s390x.replies | 3496 +++++++++-------- .../qemucapabilitiesdata/caps_9.2.0_s390x.xml | 8 +- 2 files changed, 1824 insertions(+), 1680 deletions(-) diff --git a/tests/qemucapabilitiesdata/caps_9.2.0_s390x.replies b/tests/qemucapabilitiesdata/caps_9.2.0_s390x.replies index 9a58acaf08..d328e83a61 100644 --- a/tests/qemucapabilitiesdata/caps_9.2.0_s390x.replies +++ b/tests/qemucapabilitiesdata/caps_9.2.0_s390x.replies @@ -16,11 +16,11 @@ { "return": { "qemu": { - "micro": 50, - "minor": 1, + "micro": 0, + "minor": 2, "major": 9 }, - "package": "v9.1.0-1348-g11b8920ed2" + "package": "v9.2.0" }, "id": "libvirt-2" } @@ -1193,39 +1193,48 @@ "meta-type": "event", "arg-type": "193" }, + { + "name": "device-sync-config", + "ret-type": "0", + "meta-type": "command", + "arg-type": "194", + "features": [ + "unstable" + ] + }, { "name": "query-cpus-fast", - "ret-type": "[194]", + "ret-type": "[195]", "meta-type": "command", "arg-type": "0" }, { "name": "query-machines", - "ret-type": "[196]", + "ret-type": "[197]", "meta-type": "command", - "arg-type": "195" + "arg-type": "196" }, { "name": "query-current-machine", - "ret-type": "197", + "ret-type": "198", "meta-type": "command", "arg-type": "0" }, { "name": "query-target", - "ret-type": "198", + "ret-type": "199", "meta-type": "command", "arg-type": "0" }, { "name": "query-uuid", - "ret-type": "199", + "ret-type": "200", "meta-type": "command", "arg-type": "0" }, { "name": "query-vm-generation-id", - "ret-type": "200", + "ret-type": "201", "meta-type": "command", "arg-type": "0" }, @@ -1255,7 +1264,7 @@ }, { "name": "query-kvm", - "ret-type": "201", + "ret-type": "202", "meta-type": "command", "arg-type": "0" }, @@ -1263,23 +1272,23 @@ "name": "memsave", "ret-type": "0", "meta-type": "command", - "arg-type": "202" + "arg-type": "203" }, { "name": "pmemsave", "ret-type": "0", "meta-type": "command", - "arg-type": "203" + "arg-type": "204" }, { "name": "query-memdev", - "ret-type": "[204]", + "ret-type": "[205]", "meta-type": "command", "arg-type": "0" }, { "name": "query-hotpluggable-cpus", - "ret-type": "[205]", + "ret-type": "[206]", "meta-type": "command", "arg-type": "0" }, @@ -1287,56 +1296,56 @@ "name": "set-numa-node", "ret-type": "0", "meta-type": "command", - "arg-type": "206" + "arg-type": "207" }, { "name": "balloon", "ret-type": "0", "meta-type": "command", - "arg-type": "207" + "arg-type": "208" }, { "name": "query-balloon", - "ret-type": "208", + "ret-type": "209", "meta-type": "command", "arg-type": "0" }, { "name": "BALLOON_CHANGE", "meta-type": "event", - "arg-type": "209" + "arg-type": "210" }, { "name": "query-hv-balloon-status-report", - "ret-type": "210", + "ret-type": "211", "meta-type": "command", "arg-type": "0" }, { "name": "HV_BALLOON_STATUS_REPORT", "meta-type": "event", - "arg-type": "210" + "arg-type": "211" }, { "name": "query-memory-size-summary", - "ret-type": "211", + "ret-type": "212", "meta-type": "command", "arg-type": "0" }, { "name": "query-memory-devices", - "ret-type": "[212]", + "ret-type": "[213]", "meta-type": "command", "arg-type": "0" }, { "name": "MEMORY_DEVICE_SIZE_CHANGE", "meta-type": "event", - "arg-type": "213" + "arg-type": "214" }, { "name": "x-query-irq", - "ret-type": "214", + "ret-type": "215", "meta-type": "command", "arg-type": "0", "features": [ @@ -1345,7 +1354,7 @@ }, { "name": "x-query-jit", - "ret-type": "214", + "ret-type": "215", "meta-type": "command", "arg-type": "0", "features": [ @@ -1354,7 +1363,7 @@ }, { "name": "x-query-numa", - "ret-type": "214", + "ret-type": "215", "meta-type": "command", "arg-type": "0", "features": [ @@ -1363,7 +1372,7 @@ }, { "name": "x-query-opcount", - "ret-type": "214", + "ret-type": "215", "meta-type": "command", "arg-type": "0", "features": [ @@ -1372,7 +1381,7 @@ }, { "name": "x-query-ramblock", - "ret-type": "214", + "ret-type": "215", "meta-type": "command", "arg-type": "0", "features": [ @@ -1381,7 +1390,7 @@ }, { "name": "x-query-roms", - "ret-type": "214", + "ret-type": "215", "meta-type": "command", "arg-type": "0", "features": [ @@ -1390,7 +1399,7 @@ }, { "name": "x-query-usb", - "ret-type": "214", + "ret-type": "215", "meta-type": "command", "arg-type": "0", "features": [ @@ -1401,11 +1410,11 @@ "name": "dumpdtb", "ret-type": "0", "meta-type": "command", - "arg-type": "215" + "arg-type": "216" }, { "name": "x-query-interrupt-controllers", - "ret-type": "214", + "ret-type": "215", "meta-type": "command", "arg-type": "0", "features": [ @@ -1414,25 +1423,25 @@ }, { "name": "query-cpu-model-comparison", - "ret-type": "217", + "ret-type": "218", "meta-type": "command", - "arg-type": "216" + "arg-type": "217" }, { "name": "query-cpu-model-baseline", - "ret-type": "219", + "ret-type": "220", "meta-type": "command", - "arg-type": "218" + "arg-type": "219" }, { "name": "query-cpu-model-expansion", - "ret-type": "221", + "ret-type": "222", "meta-type": "command", - "arg-type": "220" + "arg-type": "221" }, { "name": "query-cpu-definitions", - "ret-type": "[222]", + "ret-type": "[223]", "meta-type": "command", "arg-type": "0" }, @@ -1440,7 +1449,7 @@ "name": "set-cpu-topology", "ret-type": "0", "meta-type": "command", - "arg-type": "223", + "arg-type": "224", "features": [ "unstable" ] @@ -1448,14 +1457,14 @@ { "name": "CPU_POLARIZATION_CHANGE", "meta-type": "event", - "arg-type": "224", + "arg-type": "225", "features": [ "unstable" ] }, { "name": "query-s390x-cpu-polarization", - "ret-type": "225", + "ret-type": "226", "meta-type": "command", "arg-type": "0", "features": [ @@ -1464,7 +1473,7 @@ }, { "name": "query-replay", - "ret-type": "226", + "ret-type": "227", "meta-type": "command", "arg-type": "0" }, @@ -1472,7 +1481,7 @@ "name": "replay-break", "ret-type": "0", "meta-type": "command", - "arg-type": "227" + "arg-type": "228" }, { "name": "replay-delete-break", @@ -1484,18 +1493,18 @@ "name": "replay-seek", "ret-type": "0", "meta-type": "command", - "arg-type": "228" + "arg-type": "229" }, { "name": "yank", "ret-type": "0", "allow-oob": true, "meta-type": "command", - "arg-type": "229" + "arg-type": "230" }, { "name": "query-yank", - "ret-type": "[230]", + "ret-type": "[231]", "allow-oob": true, "meta-type": "command", "arg-type": "0" @@ -1504,17 +1513,17 @@ "name": "add_client", "ret-type": "0", "meta-type": "command", - "arg-type": "231" + "arg-type": "232" }, { "name": "query-name", - "ret-type": "232", + "ret-type": "233", "meta-type": "command", "arg-type": "0" }, { "name": "query-iothreads", - "ret-type": "[233]", + "ret-type": "[234]", "meta-type": "command", "arg-type": "0" }, @@ -1543,7 +1552,7 @@ "name": "human-monitor-command", "ret-type": "str", "meta-type": "command", - "arg-type": "234", + "arg-type": "235", "features": [ "savevm-monitor-nodes" ] @@ -1552,92 +1561,92 @@ "name": "getfd", "ret-type": "0", "meta-type": "command", - "arg-type": "235" + "arg-type": "236" }, { "name": "closefd", "ret-type": "0", "meta-type": "command", - "arg-type": "237" + "arg-type": "238" }, { "name": "add-fd", - "ret-type": "239", + "ret-type": "240", "meta-type": "command", - "arg-type": "238" + "arg-type": "239" }, { "name": "remove-fd", "ret-type": "0", "meta-type": "command", - "arg-type": "240" + "arg-type": "241" }, { "name": "query-fdsets", - "ret-type": "[241]", + "ret-type": "[242]", "meta-type": "command", "arg-type": "0" }, { "name": "query-command-line-options", - "ret-type": "[243]", + "ret-type": "[244]", "meta-type": "command", - "arg-type": "242" + "arg-type": "243" }, { "name": "RTC_CHANGE", "meta-type": "event", - "arg-type": "244" + "arg-type": "245" }, { "name": "VFU_CLIENT_HANGUP", "meta-type": "event", - "arg-type": "245" + "arg-type": "246" }, { "name": "dump-skeys", "ret-type": "0", "meta-type": "command", - "arg-type": "252" + "arg-type": "253" }, { "name": "query-audiodevs", - "ret-type": "[257]", + "ret-type": "[258]", "meta-type": "command", "arg-type": "0" }, { "name": "query-acpi-ospm-status", - "ret-type": "[258]", + "ret-type": "[259]", "meta-type": "command", "arg-type": "0" }, { "name": "ACPI_DEVICE_OST", "meta-type": "event", - "arg-type": "259" + "arg-type": "260" }, { "name": "query-pci", - "ret-type": "[260]", + "ret-type": "[261]", "meta-type": "command", "arg-type": "0" }, { "name": "query-stats", - "ret-type": "[262]", + "ret-type": "[263]", "meta-type": "command", - "arg-type": "261" + "arg-type": "262" }, { "name": "query-stats-schemas", - "ret-type": "[264]", + "ret-type": "[265]", "meta-type": "command", - "arg-type": "263" + "arg-type": "264" }, { "name": "x-query-virtio", - "ret-type": "[265]", + "ret-type": "[266]", "meta-type": "command", "arg-type": "0", "features": [ @@ -1646,36 +1655,36 @@ }, { "name": "x-query-virtio-status", - "ret-type": "267", + "ret-type": "268", "meta-type": "command", - "arg-type": "266", + "arg-type": "267", "features": [ "unstable" ] }, { "name": "x-query-virtio-queue-status", - "ret-type": "269", + "ret-type": "270", "meta-type": "command", - "arg-type": "268", + "arg-type": "269", "features": [ "unstable" ] }, { "name": "x-query-virtio-vhost-queue-status", - "ret-type": "271", + "ret-type": "272", "meta-type": "command", - "arg-type": "270", + "arg-type": "271", "features": [ "unstable" ] }, { "name": "x-query-virtio-queue-element", - "ret-type": "273", + "ret-type": "274", "meta-type": "command", - "arg-type": "272", + "arg-type": "273", "features": [ "unstable" ] @@ -1683,11 +1692,11 @@ { "name": "VFIO_MIGRATION", "meta-type": "event", - "arg-type": "274" + "arg-type": "275" }, { "name": "query-cryptodev", - "ret-type": "[275]", + "ret-type": "[276]", "meta-type": "command", "arg-type": "0" }, @@ -1695,43 +1704,43 @@ "name": "cxl-inject-general-media-event", "ret-type": "0", "meta-type": "command", - "arg-type": "276" + "arg-type": "277" }, { "name": "cxl-inject-dram-event", "ret-type": "0", "meta-type": "command", - "arg-type": "277" + "arg-type": "278" }, { "name": "cxl-inject-memory-module-event", "ret-type": "0", "meta-type": "command", - "arg-type": "278" + "arg-type": "279" }, { "name": "cxl-inject-poison", "ret-type": "0", "meta-type": "command", - "arg-type": "279" + "arg-type": "280" }, { "name": "cxl-inject-uncorrectable-errors", "ret-type": "0", "meta-type": "command", - "arg-type": "280" + "arg-type": "281" }, { "name": "cxl-inject-correctable-error", "ret-type": "0", "meta-type": "command", - "arg-type": "281" + "arg-type": "282" }, { "name": "cxl-add-dynamic-capacity", "ret-type": "0", "meta-type": "command", - "arg-type": "282", + "arg-type": "283", "features": [ "unstable" ] @@ -1740,7 +1749,7 @@ "name": "cxl-release-dynamic-capacity", "ret-type": "0", "meta-type": "command", - "arg-type": "283", + "arg-type": "284", "features": [ "unstable" ] @@ -1759,7 +1768,7 @@ }, { "name": "status", - "type": "284" + "type": "285" } ], "meta-type": "object" @@ -1773,7 +1782,7 @@ }, { "name": "reason", - "type": "285" + "type": "286" } ], "meta-type": "object" @@ -1787,7 +1796,7 @@ }, { "name": "reason", - "type": "285" + "type": "286" } ], "meta-type": "object" @@ -1797,7 +1806,7 @@ "members": [ { "name": "action", - "type": "286" + "type": "287" } ], "meta-type": "object" @@ -1807,7 +1816,7 @@ "members": [ { "name": "action", - "type": "286" + "type": "287" } ], "meta-type": "object" @@ -1818,22 +1827,22 @@ { "name": "reboot", "default": null, - "type": "287" + "type": "288" }, { "name": "shutdown", "default": null, - "type": "288" + "type": "289" }, { "name": "panic", "default": null, - "type": "289" + "type": "290" }, { "name": "watchdog", "default": null, - "type": "286" + "type": "287" } ], "meta-type": "object" @@ -1843,12 +1852,12 @@ "members": [ { "name": "action", - "type": "290" + "type": "291" }, { "name": "info", "default": null, - "type": "291" + "type": "292" } ], "meta-type": "object" @@ -1858,12 +1867,12 @@ "members": [ { "name": "action", - "type": "290" + "type": "291" }, { "name": "info", "default": null, - "type": "291" + "type": "292" } ], "meta-type": "object" @@ -1873,15 +1882,15 @@ "members": [ { "name": "recipient", - "type": "292" + "type": "293" }, { "name": "action", - "type": "293" + "type": "294" }, { "name": "flags", - "type": "294" + "type": "295" } ], "meta-type": "object" @@ -1895,7 +1904,7 @@ }, { "name": "status", - "type": "295" + "type": "296" } ], "meta-type": "object" @@ -1974,11 +1983,11 @@ }, { "name": "type", - "type": "296" + "type": "297" }, { "name": "status", - "type": "295" + "type": "296" }, { "name": "current-progress", @@ -2139,7 +2148,7 @@ { "name": "read-only-mode", "default": null, - "type": "297" + "type": "298" } ], "meta-type": "object" @@ -2366,7 +2375,7 @@ { "name": "io-status", "default": null, - "type": "298" + "type": "299" } ], "meta-type": "object" @@ -2407,12 +2416,12 @@ }, { "name": "stats", - "type": "299" + "type": "300" }, { "name": "driver-specific", "default": null, - "type": "300" + "type": "301" }, { "name": "parent", @@ -2438,7 +2447,7 @@ "variants": [ { "case": "mirror", - "type": "301" + "type": "302" }, { "case": "commit", @@ -2476,7 +2485,7 @@ "members": [ { "name": "type", - "type": "296" + "type": "297" }, { "name": "device", @@ -2504,7 +2513,7 @@ }, { "name": "io-status", - "type": "298" + "type": "299" }, { "name": "ready", @@ -2512,7 +2521,7 @@ }, { "name": "status", - "type": "295" + "type": "296" }, { "name": "auto-finalize", @@ -2580,7 +2589,7 @@ { "name": "mode", "default": null, - "type": "302" + "type": "303" } ], "meta-type": "object" @@ -2673,7 +2682,7 @@ { "name": "on-error", "default": null, - "type": "303" + "type": "304" }, { "name": "filter-node-name", @@ -2707,7 +2716,7 @@ }, { "name": "sync", - "type": "304" + "type": "305" }, { "name": "speed", @@ -2722,7 +2731,7 @@ { "name": "bitmap-mode", "default": null, - "type": "305" + "type": "306" }, { "name": "compress", @@ -2732,12 +2741,12 @@ { "name": "on-source-error", "default": null, - "type": "303" + "type": "304" }, { "name": "on-target-error", "default": null, - "type": "303" + "type": "304" }, { "name": "auto-finalize", @@ -2762,7 +2771,7 @@ { "name": "x-perf", "default": null, - "type": "306", + "type": "307", "features": [ "unstable" ] @@ -2779,7 +2788,7 @@ { "name": "mode", "default": null, - "type": "302" + "type": "303" } ], "meta-type": "object" @@ -2798,7 +2807,7 @@ }, { "name": "sync", - "type": "304" + "type": "305" }, { "name": "speed", @@ -2813,7 +2822,7 @@ { "name": "bitmap-mode", "default": null, - "type": "305" + "type": "306" }, { "name": "compress", @@ -2823,12 +2832,12 @@ { "name": "on-source-error", "default": null, - "type": "303" + "type": "304" }, { "name": "on-target-error", "default": null, - "type": "303" + "type": "304" }, { "name": "auto-finalize", @@ -2853,7 +2862,7 @@ { "name": "x-perf", "default": null, - "type": "306", + "type": "307", "features": [ "unstable" ] @@ -2916,7 +2925,7 @@ }, { "name": "detect_zeroes", - "type": "307" + "type": "308" }, { "name": "bps", @@ -2944,7 +2953,7 @@ }, { "name": "image", - "type": "308" + "type": "309" }, { "name": "bps_max", @@ -3018,7 +3027,7 @@ }, { "name": "cache", - "type": "309" + "type": "310" }, { "name": "write_threshold", @@ -3027,7 +3036,7 @@ { "name": "dirty-bitmaps", "default": null, - "type": "[310]" + "type": "[311]" } ], "meta-type": "object" @@ -3037,11 +3046,11 @@ "members": [ { "name": "nodes", - "type": "[311]" + "type": "[312]" }, { "name": "edges", - "type": "[312]" + "type": "[313]" } ], "meta-type": "object" @@ -3079,12 +3088,12 @@ }, { "name": "sync", - "type": "304" + "type": "305" }, { "name": "mode", "default": null, - "type": "302" + "type": "303" }, { "name": "speed", @@ -3104,12 +3113,12 @@ { "name": "on-source-error", "default": null, - "type": "303" + "type": "304" }, { "name": "on-target-error", "default": null, - "type": "303" + "type": "304" }, { "name": "unmap", @@ -3119,7 +3128,7 @@ { "name": "copy-mode", "default": null, - "type": "313" + "type": "314" }, { "name": "auto-finalize", @@ -3190,7 +3199,7 @@ }, { "name": "bitmaps", - "type": "[314]" + "type": "[315]" } ], "meta-type": "object" @@ -3228,7 +3237,7 @@ }, { "name": "sync", - "type": "304" + "type": "305" }, { "name": "speed", @@ -3248,12 +3257,12 @@ { "name": "on-source-error", "default": null, - "type": "303" + "type": "304" }, { "name": "on-target-error", "default": null, - "type": "303" + "type": "304" }, { "name": "filter-node-name", @@ -3263,7 +3272,7 @@ { "name": "copy-mode", "default": null, - "type": "313" + "type": "314" }, { "name": "auto-finalize", @@ -3323,7 +3332,7 @@ { "name": "on-error", "default": null, - "type": "303" + "type": "304" }, { "name": "filter-node-name", @@ -3428,7 +3437,7 @@ "variants": [ { "case": "mirror", - "type": "315" + "type": "316" }, { "case": "commit", @@ -3470,7 +3479,7 @@ }, { "name": "type", - "type": "296" + "type": "297" } ], "meta-type": "object" @@ -3481,197 +3490,197 @@ "variants": [ { "case": "blkdebug", - "type": "319" + "type": "320" }, { "case": "blklogwrites", - "type": "320" + "type": "321" }, { "case": "blkverify", - "type": "321" + "type": "322" }, { "case": "blkreplay", - "type": "322" + "type": "323" }, { "case": "bochs", - "type": "323" + "type": "324" }, { "case": "cloop", - "type": "323" + "type": "324" }, { "case": "compress", - "type": "323" + "type": "324" }, { "case": "copy-before-write", - "type": "324" + "type": "325" }, { "case": "copy-on-read", - "type": "325" + "type": "326" }, { "case": "dmg", - "type": "323" + "type": "324" }, { "case": "file", - "type": "326" + "type": "327" }, { "case": "ftp", - "type": "327" + "type": "328" }, { "case": "ftps", - "type": "328" + "type": "329" }, { "case": "gluster", - "type": "329" + "type": "330" }, { "case": "host_cdrom", - "type": "326" + "type": "327" }, { "case": "host_device", - "type": "326" + "type": "327" }, { "case": "http", - "type": "330" + "type": "331" }, { "case": "https", - "type": "331" + "type": "332" }, { "case": "io_uring", - "type": "332" + "type": "333" }, { "case": "iscsi", - "type": "333" + "type": "334" }, { "case": "luks", - "type": "334" + "type": "335" }, { "case": "nbd", - "type": "335" + "type": "336" }, { "case": "nfs", - "type": "336" + "type": "337" }, { "case": "null-aio", - "type": "337" + "type": "338" }, { "case": "null-co", - "type": "337" + "type": "338" }, { "case": "nvme", - "type": "338" + "type": "339" }, { "case": "nvme-io_uring", - "type": "339" + "type": "340" }, { "case": "parallels", - "type": "323" + "type": "324" }, { "case": "preallocate", - "type": "340" + "type": "341" }, { "case": "qcow2", - "type": "341" + "type": "342" }, { "case": "qcow", - "type": "342" + "type": "343" }, { "case": "qed", - "type": "343" + "type": "344" }, { "case": "quorum", - "type": "344" + "type": "345" }, { "case": "raw", - "type": "345" + "type": "346" }, { "case": "rbd", - "type": "346" + "type": "347" }, { "case": "replication", - "type": "347" + "type": "348" }, { "case": "snapshot-access", - "type": "323" + "type": "324" }, { "case": "ssh", - "type": "348" + "type": "349" }, { "case": "throttle", - "type": "349" + "type": "350" }, { "case": "vdi", - "type": "323" + "type": "324" }, { "case": "vhdx", - "type": "323" + "type": "324" }, { "case": "virtio-blk-vfio-pci", - "type": "350" + "type": "351" }, { "case": "virtio-blk-vhost-user", - "type": "351" + "type": "352" }, { "case": "virtio-blk-vhost-vdpa", - "type": "352" + "type": "353" }, { "case": "vmdk", - "type": "343" + "type": "344" }, { "case": "vpc", - "type": "323" + "type": "324" }, { "case": "vvfat", - "type": "353" + "type": "354" } ], "members": [ { "name": "driver", - "type": "316" + "type": "317" }, { "name": "node-name", @@ -3681,12 +3690,12 @@ { "name": "discard", "default": null, - "type": "317" + "type": "318" }, { "name": "cache", "default": null, - "type": "318" + "type": "319" }, { "name": "read-only", @@ -3706,7 +3715,7 @@ { "name": "detect-zeroes", "default": null, - "type": "307" + "type": "308" } ], "meta-type": "object" @@ -3740,7 +3749,7 @@ }, { "name": "options", - "type": "354" + "type": "355" } ], "meta-type": "object" @@ -3758,7 +3767,7 @@ }, { "name": "options", - "type": "355" + "type": "356" }, { "name": "force", @@ -3819,11 +3828,11 @@ }, { "name": "operation", - "type": "356" + "type": "357" }, { "name": "action", - "type": "357" + "type": "358" }, { "name": "nospace", @@ -3842,7 +3851,7 @@ "members": [ { "name": "type", - "type": "296" + "type": "297" }, { "name": "device", @@ -3873,7 +3882,7 @@ "members": [ { "name": "type", - "type": "296" + "type": "297" }, { "name": "device", @@ -3903,11 +3912,11 @@ }, { "name": "operation", - "type": "356" + "type": "357" }, { "name": "action", - "type": "357" + "type": "358" } ], "meta-type": "object" @@ -3917,7 +3926,7 @@ "members": [ { "name": "type", - "type": "296" + "type": "297" }, { "name": "device", @@ -3943,7 +3952,7 @@ "members": [ { "name": "type", - "type": "296" + "type": "297" }, { "name": "id", @@ -4013,7 +4022,7 @@ }, { "name": "iothread", - "type": "358" + "type": "359" }, { "name": "force", @@ -4046,7 +4055,7 @@ "members": [ { "name": "type", - "type": "359" + "type": "360" }, { "name": "error", @@ -4146,7 +4155,7 @@ "members": [ { "name": "addr", - "type": "360" + "type": "361" }, { "name": "tls-creds", @@ -4206,7 +4215,7 @@ { "name": "mode", "default": null, - "type": "361" + "type": "362" } ], "meta-type": "object" @@ -4217,25 +4226,25 @@ "variants": [ { "case": "nbd", - "type": "363" + "type": "364" }, { "case": "vhost-user-blk", - "type": "364" + "type": "365" }, { "case": "fuse", - "type": "365" + "type": "366" }, { "case": "vduse-blk", - "type": "366" + "type": "367" } ], "members": [ { "name": "type", - "type": "362" + "type": "363" }, { "name": "id", @@ -4278,7 +4287,7 @@ { "name": "mode", "default": null, - "type": "361" + "type": "362" } ], "meta-type": "object" @@ -4307,7 +4316,7 @@ }, { "name": "type", - "type": "362" + "type": "363" }, { "name": "node-name", @@ -4372,7 +4381,7 @@ { "name": "format", "default": null, - "type": "367" + "type": "368" } ], "meta-type": "object" @@ -4391,7 +4400,7 @@ { "name": "format", "default": null, - "type": "367" + "type": "368" } ], "meta-type": "object" @@ -4410,7 +4419,7 @@ }, { "name": "backend", - "type": "368" + "type": "369" } ], "meta-type": "object" @@ -4435,7 +4444,7 @@ }, { "name": "backend", - "type": "368" + "type": "369" } ], "meta-type": "object" @@ -4503,7 +4512,7 @@ { "name": "format", "default": null, - "type": "369" + "type": "370" } ], "meta-type": "object" @@ -4513,7 +4522,7 @@ "members": [ { "name": "status", - "type": "370" + "type": "371" }, { "name": "completed", @@ -4546,7 +4555,7 @@ "members": [ { "name": "formats", - "type": "[369]" + "type": "[370]" } ], "meta-type": "object" @@ -4571,59 +4580,59 @@ "variants": [ { "case": "nic", - "type": "372" + "type": "373" }, { "case": "user", - "type": "373" + "type": "374" }, { "case": "tap", - "type": "374" + "type": "375" }, { "case": "l2tpv3", - "type": "375" + "type": "376" }, { "case": "socket", - "type": "376" + "type": "377" }, { "case": "stream", - "type": "377" + "type": "378" }, { "case": "dgram", - "type": "378" + "type": "379" }, { "case": "vde", - "type": "379" + "type": "380" }, { "case": "bridge", - "type": "380" + "type": "381" }, { "case": "hubport", - "type": "381" + "type": "382" }, { "case": "netmap", - "type": "382" + "type": "383" }, { "case": "af-xdp", - "type": "383" + "type": "384" }, { "case": "vhost-user", - "type": "384" + "type": "385" }, { "case": "vhost-vdpa", - "type": "385" + "type": "386" }, { "case": "none", @@ -4637,7 +4646,7 @@ }, { "name": "type", - "type": "371" + "type": "372" } ], "meta-type": "object" @@ -4681,15 +4690,15 @@ }, { "name": "multicast", - "type": "389" + "type": "390" }, { "name": "unicast", - "type": "389" + "type": "390" }, { "name": "vlan", - "type": "389" + "type": "390" }, { "name": "broadcast-allowed", @@ -4788,7 +4797,7 @@ }, { "name": "addr", - "type": "390" + "type": "391" } ], "meta-type": "object" @@ -4808,7 +4817,7 @@ "members": [ { "name": "id", - "type": "391" + "type": "392" } ], "meta-type": "object" @@ -4887,11 +4896,11 @@ }, { "name": "duplex", - "type": "392" + "type": "393" }, { "name": "autoneg", - "type": "393" + "type": "394" } ], "meta-type": "object" @@ -4929,15 +4938,15 @@ }, { "name": "key", - "type": "394" + "type": "395" }, { "name": "mask", - "type": "395" + "type": "396" }, { "name": "action", - "type": "396" + "type": "397" } ], "meta-type": "object" @@ -5095,7 +5104,7 @@ }, { "name": "options", - "type": "397" + "type": "398" } ], "meta-type": "object" @@ -5106,7 +5115,7 @@ "variants": [ { "case": "vnc", - "type": "400" + "type": "401" }, { "case": "spice", @@ -5116,7 +5125,7 @@ "members": [ { "name": "protocol", - "type": "398" + "type": "399" }, { "name": "password", @@ -5125,7 +5134,7 @@ { "name": "connected", "default": null, - "type": "399" + "type": "400" } ], "meta-type": "object" @@ -5136,7 +5145,7 @@ "variants": [ { "case": "vnc", - "type": "401" + "type": "402" }, { "case": "spice", @@ -5146,7 +5155,7 @@ "members": [ { "name": "protocol", - "type": "398" + "type": "399" }, { "name": "time", @@ -5175,7 +5184,7 @@ { "name": "format", "default": null, - "type": "402" + "type": "403" } ], "meta-type": "object" @@ -5195,7 +5204,7 @@ { "name": "family", "default": null, - "type": "407" + "type": "408" }, { "name": "service", @@ -5210,7 +5219,7 @@ { "name": "clients", "default": null, - "type": "[408]" + "type": "[409]" } ], "meta-type": "object" @@ -5229,20 +5238,20 @@ }, { "name": "server", - "type": "[409]" + "type": "[410]" }, { "name": "clients", - "type": "[408]" + "type": "[409]" }, { "name": "auth", - "type": "410" + "type": "411" }, { "name": "vencrypt", "default": null, - "type": "411" + "type": "412" }, { "name": "display", @@ -5267,11 +5276,11 @@ "members": [ { "name": "server", - "type": "412" + "type": "413" }, { "name": "client", - "type": "413" + "type": "414" } ], "meta-type": "object" @@ -5281,11 +5290,11 @@ "members": [ { "name": "server", - "type": "412" + "type": "413" }, { "name": "client", - "type": "408" + "type": "409" } ], "meta-type": "object" @@ -5295,11 +5304,11 @@ "members": [ { "name": "server", - "type": "412" + "type": "413" }, { "name": "client", - "type": "408" + "type": "409" } ], "meta-type": "object" @@ -5336,7 +5345,7 @@ "members": [ { "name": "keys", - "type": "[414]" + "type": "[415]" }, { "name": "hold-time", @@ -5361,7 +5370,7 @@ }, { "name": "events", - "type": "[415]" + "type": "[416]" } ], "meta-type": "object" @@ -5372,23 +5381,23 @@ "variants": [ { "case": "gtk", - "type": "418" + "type": "419" }, { "case": "curses", - "type": "420" + "type": "421" }, { "case": "egl-headless", - "type": "421" + "type": "422" }, { "case": "dbus", - "type": "422" + "type": "423" }, { "case": "sdl", - "type": "423" + "type": "424" }, { "case": "default", @@ -5402,7 +5411,7 @@ "members": [ { "name": "type", - "type": "416" + "type": "417" }, { "name": "full-screen", @@ -5422,7 +5431,7 @@ { "name": "gl", "default": null, - "type": "417" + "type": "418" } ], "meta-type": "object" @@ -5433,13 +5442,13 @@ "variants": [ { "case": "vnc", - "type": "425" + "type": "426" } ], "members": [ { "name": "type", - "type": "424" + "type": "425" } ], "meta-type": "object" @@ -5450,13 +5459,13 @@ "variants": [ { "case": "vnc", - "type": "427" + "type": "428" } ], "members": [ { "name": "type", - "type": "426" + "type": "427" } ], "meta-type": "object" @@ -5496,22 +5505,22 @@ { "name": "status", "default": null, - "type": "428" + "type": "429" }, { "name": "ram", "default": null, - "type": "429" + "type": "430" }, { "name": "vfio", "default": null, - "type": "430" + "type": "431" }, { "name": "xbzrle-cache", "default": null, - "type": "431" + "type": "432" }, { "name": "total-time", @@ -5561,7 +5570,7 @@ { "name": "socket-address", "default": null, - "type": "[390]" + "type": "[391]" }, { "name": "dirty-limit-throttle-time-per-round", @@ -5596,7 +5605,7 @@ "members": [ { "name": "capability", - "type": "432" + "type": "433" }, { "name": "state", @@ -5651,17 +5660,17 @@ { "name": "tls-creds", "default": null, - "type": "358" + "type": "359" }, { "name": "tls-hostname", "default": null, - "type": "358" + "type": "359" }, { "name": "tls-authz", "default": null, - "type": "358" + "type": "359" }, { "name": "max-bandwidth", @@ -5709,7 +5718,7 @@ { "name": "multifd-compression", "default": null, - "type": "433" + "type": "434" }, { "name": "multifd-zlib-level", @@ -5729,7 +5738,7 @@ { "name": "block-bitmap-mapping", "default": null, - "type": "[434]" + "type": "[435]" }, { "name": "x-vcpu-dirty-limit-period", @@ -5747,12 +5756,12 @@ { "name": "mode", "default": null, - "type": "435" + "type": "436" }, { "name": "zero-page-detection", "default": null, - "type": "436" + "type": "437" }, { "name": "direct-io", @@ -5866,7 +5875,7 @@ { "name": "multifd-compression", "default": null, - "type": "433" + "type": "434" }, { "name": "multifd-zlib-level", @@ -5886,7 +5895,7 @@ { "name": "block-bitmap-mapping", "default": null, - "type": "[434]" + "type": "[435]" }, { "name": "x-vcpu-dirty-limit-period", @@ -5904,12 +5913,12 @@ { "name": "mode", "default": null, - "type": "435" + "type": "436" }, { "name": "zero-page-detection", "default": null, - "type": "436" + "type": "437" }, { "name": "direct-io", @@ -5924,7 +5933,7 @@ "members": [ { "name": "status", - "type": "428" + "type": "429" } ], "meta-type": "object" @@ -5944,11 +5953,11 @@ "members": [ { "name": "mode", - "type": "437" + "type": "438" }, { "name": "reason", - "type": "438" + "type": "439" } ], "meta-type": "object" @@ -5958,7 +5967,7 @@ "members": [ { "name": "state", - "type": "428" + "type": "429" } ], "meta-type": "object" @@ -5974,7 +5983,7 @@ { "name": "channels", "default": null, - "type": "[439]" + "type": "[440]" }, { "name": "detach", @@ -6000,7 +6009,7 @@ { "name": "channels", "default": null, - "type": "[439]" + "type": "[440]" }, { "name": "exit-on-error", @@ -6084,15 +6093,15 @@ "members": [ { "name": "mode", - "type": "437" + "type": "438" }, { "name": "last-mode", - "type": "437" + "type": "438" }, { "name": "reason", - "type": "438" + "type": "439" } ], "meta-type": "object" @@ -6127,7 +6136,7 @@ { "name": "calc-time-unit", "default": null, - "type": "440" + "type": "441" }, { "name": "sample-pages", @@ -6137,7 +6146,7 @@ { "name": "mode", "default": null, - "type": "441" + "type": "442" } ], "meta-type": "object" @@ -6148,7 +6157,7 @@ { "name": "calc-time-unit", "default": null, - "type": "440" + "type": "441" } ], "meta-type": "object" @@ -6163,7 +6172,7 @@ }, { "name": "status", - "type": "442" + "type": "443" }, { "name": "start-time", @@ -6175,7 +6184,7 @@ }, { "name": "calc-time-unit", - "type": "440" + "type": "441" }, { "name": "sample-pages", @@ -6183,12 +6192,12 @@ }, { "name": "mode", - "type": "441" + "type": "442" }, { "name": "vcpu-dirty-rate", "default": null, - "type": "[443]" + "type": "[444]" } ], "meta-type": "object" @@ -6328,12 +6337,12 @@ "members": [ { "name": "actions", - "type": "[444]" + "type": "[445]" }, { "name": "properties", "default": null, - "type": "445" + "type": "446" } ], "meta-type": "object" @@ -6362,7 +6371,7 @@ }, { "name": "state", - "type": "446" + "type": "447" } ], "meta-type": "object" @@ -6392,7 +6401,7 @@ { "name": "enable", "default": null, - "type": "[447]" + "type": "[448]" } ], "meta-type": "object" @@ -6402,7 +6411,7 @@ "members": [ { "name": "qemu", - "type": "448" + "type": "449" }, { "name": "package", @@ -6437,31 +6446,31 @@ "variants": [ { "case": "builtin", - "type": "450" + "type": "451" }, { "case": "enum", - "type": "451" + "type": "452" }, { "case": "array", - "type": "452" + "type": "453" }, { "case": "object", - "type": "453" + "type": "454" }, { "case": "alternate", - "type": "454" + "type": "455" }, { "case": "command", - "type": "455" + "type": "456" }, { "case": "event", - "type": "456" + "type": "457" } ], "members": [ @@ -6471,7 +6480,7 @@ }, { "name": "meta-type", - "type": "449" + "type": "450" }, { "name": "features", @@ -6614,183 +6623,187 @@ "variants": [ { "case": "acpi-generic-initiator", - "type": "458" + "type": "459" + }, + { + "case": "acpi-generic-port", + "type": "460" }, { "case": "authz-list", - "type": "459" + "type": "461" }, { "case": "authz-listfile", - "type": "460" + "type": "462" }, { "case": "authz-pam", - "type": "461" + "type": "463" }, { "case": "authz-simple", - "type": "462" + "type": "464" }, { "case": "can-host-socketcan", - "type": "463" + "type": "465" }, { "case": "colo-compare", - "type": "464" + "type": "466" }, { "case": "cryptodev-backend", - "type": "465" + "type": "467" }, { "case": "cryptodev-backend-builtin", - "type": "465" + "type": "467" }, { "case": "cryptodev-backend-lkcf", - "type": "465" + "type": "467" }, { "case": "cryptodev-vhost-user", - "type": "466" + "type": "468" }, { "case": "dbus-vmstate", - "type": "467" + "type": "469" }, { "case": "filter-buffer", - "type": "468" + "type": "470" }, { "case": "filter-dump", - "type": "469" + "type": "471" }, { "case": "filter-mirror", - "type": "470" + "type": "472" }, { "case": "filter-redirector", - "type": "471" + "type": "473" }, { "case": "filter-replay", - "type": "472" + "type": "474" }, { "case": "filter-rewriter", - "type": "473" + "type": "475" }, { "case": "input-barrier", - "type": "474" + "type": "476" }, { "case": "input-linux", - "type": "475" + "type": "477" }, { "case": "iommufd", - "type": "476" + "type": "478" }, { "case": "iothread", - "type": "477" + "type": "479" }, { "case": "main-loop", - "type": "478" + "type": "480" }, { "case": "memory-backend-epc", - "type": "479" + "type": "481" }, { "case": "memory-backend-file", - "type": "480" + "type": "482" }, { "case": "memory-backend-memfd", - "type": "481" + "type": "483" }, { "case": "memory-backend-ram", - "type": "482" + "type": "484" }, { "case": "memory-backend-shm", - "type": "483" + "type": "485" }, { "case": "pr-manager-helper", - "type": "484" + "type": "486" }, { "case": "qtest", - "type": "485" + "type": "487" }, { "case": "rng-builtin", - "type": "486" + "type": "488" }, { "case": "rng-egd", - "type": "487" + "type": "489" }, { "case": "rng-random", - "type": "488" + "type": "490" }, { "case": "secret", - "type": "489" + "type": "491" }, { "case": "secret_keyring", - "type": "490" + "type": "492" }, { "case": "sev-guest", - "type": "491" + "type": "493" }, { "case": "sev-snp-guest", - "type": "492" + "type": "494" }, { "case": "thread-context", - "type": "493" + "type": "495" }, { "case": "throttle-group", - "type": "494" + "type": "496" }, { "case": "tls-creds-anon", - "type": "495" + "type": "497" }, { "case": "tls-creds-psk", - "type": "496" + "type": "498" }, { "case": "tls-creds-x509", - "type": "497" + "type": "499" }, { "case": "tls-cipher-suites", - "type": "498" + "type": "500" }, { "case": "x-remote-object", - "type": "499" + "type": "501" }, { "case": "x-vfio-user-server", - "type": "500" + "type": "502" }, { "case": "can-bus", @@ -6808,7 +6821,7 @@ "members": [ { "name": "qom-type", - "type": "457" + "type": "458" }, { "name": "id", @@ -6898,17 +6911,27 @@ "meta-type": "object" }, { - "name": "[194]", - "element-type": "194", + "name": "194", + "members": [ + { + "name": "id", + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "[195]", + "element-type": "195", "meta-type": "array" }, { - "name": "194", + "name": "195", "tag": "target", "variants": [ { "case": "s390x", - "type": "503" + "type": "505" }, { "case": "aarch64", @@ -7039,17 +7062,17 @@ { "name": "props", "default": null, - "type": "501" + "type": "503" }, { "name": "target", - "type": "502" + "type": "504" } ], "meta-type": "object" }, { - "name": "195", + "name": "196", "members": [ { "name": "compat-props", @@ -7063,12 +7086,12 @@ "meta-type": "object" }, { - "name": "[196]", - "element-type": "196", + "name": "[197]", + "element-type": "197", "meta-type": "array" }, { - "name": "196", + "name": "197", "members": [ { "name": "name", @@ -7117,7 +7140,7 @@ { "name": "compat-props", "default": null, - "type": "[504]", + "type": "[506]", "features": [ "unstable" ] @@ -7126,7 +7149,7 @@ "meta-type": "object" }, { - "name": "197", + "name": "198", "members": [ { "name": "wakeup-suspend-support", @@ -7136,17 +7159,17 @@ "meta-type": "object" }, { - "name": "198", + "name": "199", "members": [ { "name": "arch", - "type": "502" + "type": "504" } ], "meta-type": "object" }, { - "name": "199", + "name": "200", "members": [ { "name": "UUID", @@ -7156,7 +7179,7 @@ "meta-type": "object" }, { - "name": "200", + "name": "201", "members": [ { "name": "guid", @@ -7166,7 +7189,7 @@ "meta-type": "object" }, { - "name": "201", + "name": "202", "members": [ { "name": "enabled", @@ -7180,7 +7203,7 @@ "meta-type": "object" }, { - "name": "202", + "name": "203", "members": [ { "name": "val", @@ -7203,7 +7226,7 @@ "meta-type": "object" }, { - "name": "203", + "name": "204", "members": [ { "name": "val", @@ -7221,12 +7244,12 @@ "meta-type": "object" }, { - "name": "[204]", - "element-type": "204", + "name": "[205]", + "element-type": "205", "meta-type": "array" }, { - "name": "204", + "name": "205", "members": [ { "name": "id", @@ -7264,18 +7287,18 @@ }, { "name": "policy", - "type": "505" + "type": "507" } ], "meta-type": "object" }, { - "name": "[205]", - "element-type": "205", + "name": "[206]", + "element-type": "206", "meta-type": "array" }, { - "name": "205", + "name": "206", "members": [ { "name": "type", @@ -7287,7 +7310,7 @@ }, { "name": "props", - "type": "501" + "type": "503" }, { "name": "qom-path", @@ -7298,40 +7321,40 @@ "meta-type": "object" }, { - "name": "206", + "name": "207", "tag": "type", "variants": [ { "case": "node", - "type": "507" + "type": "509" }, { "case": "dist", - "type": "508" + "type": "510" }, { "case": "cpu", - "type": "509" + "type": "511" }, { "case": "hmat-lb", - "type": "510" + "type": "512" }, { "case": "hmat-cache", - "type": "511" + "type": "513" } ], "members": [ { "name": "type", - "type": "506" + "type": "508" } ], "meta-type": "object" }, { - "name": "207", + "name": "208", "members": [ { "name": "value", @@ -7341,7 +7364,7 @@ "meta-type": "object" }, { - "name": "208", + "name": "209", "members": [ { "name": "actual", @@ -7351,7 +7374,7 @@ "meta-type": "object" }, { - "name": "209", + "name": "210", "members": [ { "name": "actual", @@ -7361,7 +7384,7 @@ "meta-type": "object" }, { - "name": "210", + "name": "211", "members": [ { "name": "committed", @@ -7375,7 +7398,7 @@ "meta-type": "object" }, { - "name": "211", + "name": "212", "members": [ { "name": "base-memory", @@ -7390,49 +7413,49 @@ "meta-type": "object" }, { - "name": "[212]", - "element-type": "212", + "name": "[213]", + "element-type": "213", "meta-type": "array" }, { - "name": "212", + "name": "213", "tag": "type", "variants": [ { "case": "dimm", - "type": "513" + "type": "515" }, { "case": "nvdimm", - "type": "513" + "type": "515" }, { "case": "virtio-pmem", - "type": "514" + "type": "516" }, { "case": "virtio-mem", - "type": "515" + "type": "517" }, { "case": "sgx-epc", - "type": "516" + "type": "518" }, { "case": "hv-balloon", - "type": "517" + "type": "519" } ], "members": [ { "name": "type", - "type": "512" + "type": "514" } ], "meta-type": "object" }, { - "name": "213", + "name": "214", "members": [ { "name": "id", @@ -7451,7 +7474,7 @@ "meta-type": "object" }, { - "name": "214", + "name": "215", "members": [ { "name": "human-readable-text", @@ -7461,7 +7484,7 @@ "meta-type": "object" }, { - "name": "215", + "name": "216", "members": [ { "name": "filename", @@ -7471,25 +7494,25 @@ "meta-type": "object" }, { - "name": "216", + "name": "217", "members": [ { "name": "modela", - "type": "518" + "type": "520" }, { "name": "modelb", - "type": "518" + "type": "520" } ], "meta-type": "object" }, { - "name": "217", + "name": "218", "members": [ { "name": "result", - "type": "519" + "type": "521" }, { "name": "responsible-properties", @@ -7499,49 +7522,49 @@ "meta-type": "object" }, { - "name": "218", + "name": "219", "members": [ { "name": "modela", - "type": "518" + "type": "520" }, { "name": "modelb", - "type": "518" + "type": "520" } ], "meta-type": "object" }, { - "name": "219", + "name": "220", "members": [ { "name": "model", - "type": "518" + "type": "520" } ], "meta-type": "object" }, { - "name": "220", + "name": "221", "members": [ { "name": "type", - "type": "520" + "type": "522" }, { "name": "model", - "type": "518" + "type": "520" } ], "meta-type": "object" }, { - "name": "221", + "name": "222", "members": [ { "name": "model", - "type": "518" + "type": "520" }, { "name": "deprecated-props", @@ -7551,12 +7574,12 @@ "meta-type": "object" }, { - "name": "[222]", - "element-type": "222", + "name": "[223]", + "element-type": "223", "meta-type": "array" }, { - "name": "222", + "name": "223", "members": [ { "name": "name", @@ -7593,7 +7616,7 @@ "meta-type": "object" }, { - "name": "223", + "name": "224", "members": [ { "name": "core-id", @@ -7617,7 +7640,7 @@ { "name": "entitlement", "default": null, - "type": "521" + "type": "523" }, { "name": "dedicated", @@ -7628,31 +7651,31 @@ "meta-type": "object" }, { - "name": "224", + "name": "225", "members": [ { "name": "polarization", - "type": "522" + "type": "524" } ], "meta-type": "object" }, { - "name": "225", + "name": "226", "members": [ { "name": "polarization", - "type": "522" + "type": "524" } ], "meta-type": "object" }, { - "name": "226", + "name": "227", "members": [ { "name": "mode", - "type": "523" + "type": "525" }, { "name": "filename", @@ -7667,7 +7690,7 @@ "meta-type": "object" }, { - "name": "227", + "name": "228", "members": [ { "name": "icount", @@ -7677,7 +7700,7 @@ "meta-type": "object" }, { - "name": "228", + "name": "229", "members": [ { "name": "icount", @@ -7687,31 +7710,31 @@ "meta-type": "object" }, { - "name": "229", + "name": "230", "members": [ { "name": "instances", - "type": "[230]" + "type": "[231]" } ], "meta-type": "object" }, { - "name": "[230]", - "element-type": "230", + "name": "[231]", + "element-type": "231", "meta-type": "array" }, { - "name": "230", + "name": "231", "tag": "type", "variants": [ { "case": "block-node", - "type": "525" + "type": "527" }, { "case": "chardev", - "type": "526" + "type": "528" }, { "case": "migration", @@ -7721,13 +7744,13 @@ "members": [ { "name": "type", - "type": "524" + "type": "526" } ], "meta-type": "object" }, { - "name": "231", + "name": "232", "members": [ { "name": "protocol", @@ -7751,7 +7774,7 @@ "meta-type": "object" }, { - "name": "232", + "name": "233", "members": [ { "name": "name", @@ -7762,12 +7785,12 @@ "meta-type": "object" }, { - "name": "[233]", - "element-type": "233", + "name": "[234]", + "element-type": "234", "meta-type": "array" }, { - "name": "233", + "name": "234", "members": [ { "name": "id", @@ -7797,7 +7820,7 @@ "meta-type": "object" }, { - "name": "234", + "name": "235", "members": [ { "name": "command-line", @@ -7812,7 +7835,7 @@ "meta-type": "object" }, { - "name": "235", + "name": "236", "members": [ { "name": "fdname", @@ -7822,7 +7845,7 @@ "meta-type": "object" }, { - "name": "237", + "name": "238", "members": [ { "name": "fdname", @@ -7832,7 +7855,7 @@ "meta-type": "object" }, { - "name": "238", + "name": "239", "members": [ { "name": "fdset-id", @@ -7848,7 +7871,7 @@ "meta-type": "object" }, { - "name": "239", + "name": "240", "members": [ { "name": "fdset-id", @@ -7862,7 +7885,7 @@ "meta-type": "object" }, { - "name": "240", + "name": "241", "members": [ { "name": "fdset-id", @@ -7877,12 +7900,12 @@ "meta-type": "object" }, { - "name": "[241]", - "element-type": "241", + "name": "[242]", + "element-type": "242", "meta-type": "array" }, { - "name": "241", + "name": "242", "members": [ { "name": "fdset-id", @@ -7890,13 +7913,13 @@ }, { "name": "fds", - "type": "[527]" + "type": "[529]" } ], "meta-type": "object" }, { - "name": "242", + "name": "243", "members": [ { "name": "option", @@ -7907,12 +7930,12 @@ "meta-type": "object" }, { - "name": "[243]", - "element-type": "243", + "name": "[244]", + "element-type": "244", "meta-type": "array" }, { - "name": "243", + "name": "244", "members": [ { "name": "option", @@ -7920,13 +7943,13 @@ }, { "name": "parameters", - "type": "[528]" + "type": "[530]" } ], "meta-type": "object" }, { - "name": "244", + "name": "245", "members": [ { "name": "offset", @@ -7940,7 +7963,7 @@ "meta-type": "object" }, { - "name": "245", + "name": "246", "members": [ { "name": "vfu-id", @@ -7962,7 +7985,7 @@ "meta-type": "object" }, { - "name": "252", + "name": "253", "members": [ { "name": "filename", @@ -7972,49 +7995,49 @@ "meta-type": "object" }, { - "name": "[257]", - "element-type": "257", + "name": "[258]", + "element-type": "258", "meta-type": "array" }, { - "name": "257", + "name": "258", "tag": "driver", "variants": [ { "case": "none", - "type": "536" + "type": "538" }, { "case": "alsa", - "type": "537" + "type": "539" }, { "case": "dbus", - "type": "536" + "type": "538" }, { "case": "jack", - "type": "540" + "type": "542" }, { "case": "oss", - "type": "541" + "type": "543" }, { "case": "pa", - "type": "542" + "type": "544" }, { "case": "pipewire", - "type": "543" + "type": "545" }, { "case": "sdl", - "type": "544" + "type": "546" }, { "case": "wav", - "type": "546" + "type": "548" } ], "members": [ @@ -8024,7 +8047,7 @@ }, { "name": "driver", - "type": "535" + "type": "537" }, { "name": "timer-period", @@ -8035,12 +8058,12 @@ "meta-type": "object" }, { - "name": "[258]", - "element-type": "258", + "name": "[259]", + "element-type": "259", "meta-type": "array" }, { - "name": "258", + "name": "259", "members": [ { "name": "device", @@ -8053,7 +8076,7 @@ }, { "name": "slot-type", - "type": "547" + "type": "549" }, { "name": "source", @@ -8067,22 +8090,22 @@ "meta-type": "object" }, { - "name": "259", + "name": "260", "members": [ { "name": "info", - "type": "258" + "type": "259" } ], "meta-type": "object" }, { - "name": "[260]", - "element-type": "260", + "name": "[261]", + "element-type": "261", "meta-type": "array" }, { - "name": "260", + "name": "261", "members": [ { "name": "bus", @@ -8090,18 +8113,18 @@ }, { "name": "devices", - "type": "[548]" + "type": "[550]" } ], "meta-type": "object" }, { - "name": "261", + "name": "262", "tag": "target", "variants": [ { "case": "vcpu", - "type": "551" + "type": "553" }, { "case": "vm", @@ -8115,27 +8138,27 @@ "members": [ { "name": "target", - "type": "549" + "type": "551" }, { "name": "providers", "default": null, - "type": "[550]" + "type": "[552]" } ], "meta-type": "object" }, { - "name": "[262]", - "element-type": "262", + "name": "[263]", + "element-type": "263", "meta-type": "array" }, { - "name": "262", + "name": "263", "members": [ { "name": "provider", - "type": "552" + "type": "554" }, { "name": "qom-path", @@ -8144,52 +8167,52 @@ }, { "name": "stats", - "type": "[553]" + "type": "[555]" } ], "meta-type": "object" }, { - "name": "263", + "name": "264", "members": [ { "name": "provider", "default": null, - "type": "552" + "type": "554" } ], "meta-type": "object" }, { - "name": "[264]", - "element-type": "264", + "name": "[265]", + "element-type": "265", "meta-type": "array" }, { - "name": "264", + "name": "265", "members": [ { "name": "provider", - "type": "552" + "type": "554" }, { "name": "target", - "type": "549" + "type": "551" }, { "name": "stats", - "type": "[554]" + "type": "[556]" } ], "meta-type": "object" }, { - "name": "[265]", - "element-type": "265", + "name": "[266]", + "element-type": "266", "meta-type": "array" }, { - "name": "265", + "name": "266", "members": [ { "name": "path", @@ -8203,7 +8226,7 @@ "meta-type": "object" }, { - "name": "266", + "name": "267", "members": [ { "name": "path", @@ -8213,7 +8236,7 @@ "meta-type": "object" }, { - "name": "267", + "name": "268", "members": [ { "name": "name", @@ -8233,15 +8256,15 @@ }, { "name": "guest-features", - "type": "555" + "type": "557" }, { "name": "host-features", - "type": "555" + "type": "557" }, { "name": "backend-features", - "type": "555" + "type": "557" }, { "name": "num-vqs", @@ -8249,7 +8272,7 @@ }, { "name": "status", - "type": "556" + "type": "558" }, { "name": "isr", @@ -8298,13 +8321,13 @@ { "name": "vhost-dev", "default": null, - "type": "557" + "type": "559" } ], "meta-type": "object" }, { - "name": "268", + "name": "269", "members": [ { "name": "path", @@ -8318,7 +8341,7 @@ "meta-type": "object" }, { - "name": "269", + "name": "270", "members": [ { "name": "name", @@ -8382,7 +8405,7 @@ "meta-type": "object" }, { - "name": "270", + "name": "271", "members": [ { "name": "path", @@ -8396,7 +8419,7 @@ "meta-type": "object" }, { - "name": "271", + "name": "272", "members": [ { "name": "name", @@ -8454,7 +8477,7 @@ "meta-type": "object" }, { - "name": "272", + "name": "273", "members": [ { "name": "path", @@ -8473,7 +8496,7 @@ "meta-type": "object" }, { - "name": "273", + "name": "274", "members": [ { "name": "name", @@ -8485,21 +8508,21 @@ }, { "name": "descs", - "type": "[558]" + "type": "[560]" }, { "name": "avail", - "type": "559" + "type": "561" }, { "name": "used", - "type": "560" + "type": "562" } ], "meta-type": "object" }, { - "name": "274", + "name": "275", "members": [ { "name": "device-id", @@ -8511,18 +8534,18 @@ }, { "name": "device-state", - "type": "561" + "type": "563" } ], "meta-type": "object" }, { - "name": "[275]", - "element-type": "275", + "name": "[276]", + "element-type": "276", "meta-type": "array" }, { - "name": "275", + "name": "276", "members": [ { "name": "id", @@ -8530,17 +8553,17 @@ }, { "name": "service", - "type": "[562]" + "type": "[564]" }, { "name": "client", - "type": "[563]" + "type": "[565]" } ], "meta-type": "object" }, { - "name": "276", + "name": "277", "members": [ { "name": "path", @@ -8548,7 +8571,7 @@ }, { "name": "log", - "type": "564" + "type": "566" }, { "name": "flags", @@ -8594,7 +8617,7 @@ "meta-type": "object" }, { - "name": "277", + "name": "278", "members": [ { "name": "path", @@ -8602,7 +8625,7 @@ }, { "name": "log", - "type": "564" + "type": "566" }, { "name": "flags", @@ -8668,7 +8691,7 @@ "meta-type": "object" }, { - "name": "278", + "name": "279", "members": [ { "name": "path", @@ -8676,7 +8699,7 @@ }, { "name": "log", - "type": "564" + "type": "566" }, { "name": "flags", @@ -8722,7 +8745,7 @@ "meta-type": "object" }, { - "name": "279", + "name": "280", "members": [ { "name": "path", @@ -8740,7 +8763,7 @@ "meta-type": "object" }, { - "name": "280", + "name": "281", "members": [ { "name": "path", @@ -8748,13 +8771,13 @@ }, { "name": "errors", - "type": "[565]" + "type": "[567]" } ], "meta-type": "object" }, { - "name": "281", + "name": "282", "members": [ { "name": "path", @@ -8762,13 +8785,13 @@ }, { "name": "type", - "type": "566" + "type": "568" } ], "meta-type": "object" }, { - "name": "282", + "name": "283", "members": [ { "name": "path", @@ -8780,7 +8803,7 @@ }, { "name": "selection-policy", - "type": "567" + "type": "569" }, { "name": "region", @@ -8793,13 +8816,13 @@ }, { "name": "extents", - "type": "[568]" + "type": "[570]" } ], "meta-type": "object" }, { - "name": "283", + "name": "284", "members": [ { "name": "path", @@ -8811,7 +8834,7 @@ }, { "name": "removal-policy", - "type": "569" + "type": "571" }, { "name": "forced-removal", @@ -8834,7 +8857,7 @@ }, { "name": "extents", - "type": "[568]" + "type": "[570]" } ], "meta-type": "object" @@ -8845,7 +8868,7 @@ "meta-type": "builtin" }, { - "name": "284", + "name": "285", "members": [ { "name": "debug" @@ -8917,7 +8940,7 @@ ] }, { - "name": "285", + "name": "286", "members": [ { "name": "none" @@ -8969,7 +8992,7 @@ ] }, { - "name": "286", + "name": "287", "members": [ { "name": "reset" @@ -9005,7 +9028,7 @@ ] }, { - "name": "287", + "name": "288", "members": [ { "name": "reset" @@ -9021,7 +9044,7 @@ ] }, { - "name": "288", + "name": "289", "members": [ { "name": "poweroff" @@ -9037,7 +9060,7 @@ ] }, { - "name": "289", + "name": "290", "members": [ { "name": "pause" @@ -9061,7 +9084,7 @@ ] }, { - "name": "290", + "name": "291", "members": [ { "name": "pause" @@ -9081,28 +9104,28 @@ ] }, { - "name": "291", + "name": "292", "tag": "type", "variants": [ { "case": "hyper-v", - "type": "571" + "type": "573" }, { "case": "s390", - "type": "572" + "type": "574" } ], "members": [ { "name": "type", - "type": "570" + "type": "572" } ], "meta-type": "object" }, { - "name": "292", + "name": "293", "members": [ { "name": "hypervisor" @@ -9118,7 +9141,7 @@ ] }, { - "name": "293", + "name": "294", "members": [ { "name": "ignore" @@ -9142,7 +9165,7 @@ ] }, { - "name": "294", + "name": "295", "members": [ { "name": "action-required", @@ -9156,7 +9179,7 @@ "meta-type": "object" }, { - "name": "295", + "name": "296", "members": [ { "name": "undefined" @@ -9208,7 +9231,7 @@ ] }, { - "name": "296", + "name": "297", "members": [ { "name": "commit" @@ -9257,7 +9280,7 @@ "meta-type": "builtin" }, { - "name": "297", + "name": "298", "members": [ { "name": "retain" @@ -9282,7 +9305,7 @@ "meta-type": "array" }, { - "name": "298", + "name": "299", "members": [ { "name": "ok" @@ -9302,7 +9325,7 @@ ] }, { - "name": "299", + "name": "300", "members": [ { "name": "rd_bytes", @@ -9435,46 +9458,46 @@ }, { "name": "timed_stats", - "type": "[573]" + "type": "[575]" }, { "name": "rd_latency_histogram", "default": null, - "type": "574" + "type": "576" }, { "name": "wr_latency_histogram", "default": null, - "type": "574" + "type": "576" }, { "name": "zone_append_latency_histogram", "default": null, - "type": "574" + "type": "576" }, { "name": "flush_latency_histogram", "default": null, - "type": "574" + "type": "576" } ], "meta-type": "object" }, { - "name": "300", + "name": "301", "tag": "driver", "variants": [ { "case": "file", - "type": "575" + "type": "577" }, { "case": "host_device", - "type": "575" + "type": "577" }, { "case": "nvme", - "type": "576" + "type": "578" }, { "case": "blkdebug", @@ -9656,13 +9679,13 @@ "members": [ { "name": "driver", - "type": "316" + "type": "317" } ], "meta-type": "object" }, { - "name": "301", + "name": "302", "members": [ { "name": "actively-synced", @@ -9672,7 +9695,7 @@ "meta-type": "object" }, { - "name": "302", + "name": "303", "members": [ { "name": "existing" @@ -9688,7 +9711,7 @@ ] }, { - "name": "303", + "name": "304", "members": [ { "name": "report" @@ -9716,7 +9739,7 @@ ] }, { - "name": "304", + "name": "305", "members": [ { "name": "top" @@ -9744,7 +9767,7 @@ ] }, { - "name": "305", + "name": "306", "members": [ { "name": "on-success" @@ -9764,7 +9787,7 @@ ] }, { - "name": "306", + "name": "307", "members": [ { "name": "use-copy-range", @@ -9790,7 +9813,7 @@ "meta-type": "object" }, { - "name": "307", + "name": "308", "members": [ { "name": "off" @@ -9810,7 +9833,7 @@ ] }, { - "name": "308", + "name": "309", "members": [ { "name": "filename", @@ -9872,18 +9895,18 @@ { "name": "format-specific", "default": null, - "type": "577" + "type": "579" }, { "name": "backing-image", "default": null, - "type": "308" + "type": "309" } ], "meta-type": "object" }, { - "name": "309", + "name": "310", "members": [ { "name": "writeback", @@ -9901,12 +9924,12 @@ "meta-type": "object" }, { - "name": "[310]", - "element-type": "310", + "name": "[311]", + "element-type": "311", "meta-type": "array" }, { - "name": "310", + "name": "311", "members": [ { "name": "name", @@ -9942,12 +9965,12 @@ "meta-type": "object" }, { - "name": "[311]", - "element-type": "311", + "name": "[312]", + "element-type": "312", "meta-type": "array" }, { - "name": "311", + "name": "312", "members": [ { "name": "id", @@ -9955,7 +9978,7 @@ }, { "name": "type", - "type": "578" + "type": "580" }, { "name": "name", @@ -9965,12 +9988,12 @@ "meta-type": "object" }, { - "name": "[312]", - "element-type": "312", + "name": "[313]", + "element-type": "313", "meta-type": "array" }, { - "name": "312", + "name": "313", "members": [ { "name": "parent", @@ -9986,17 +10009,17 @@ }, { "name": "perm", - "type": "[579]" + "type": "[581]" }, { "name": "shared-perm", - "type": "[579]" + "type": "[581]" } ], "meta-type": "object" }, { - "name": "313", + "name": "314", "members": [ { "name": "background" @@ -10012,12 +10035,12 @@ ] }, { - "name": "[314]", - "element-type": "314", + "name": "[315]", + "element-type": "315", "meta-type": "array" }, { - "name": "314", + "name": "315", "members": [ { "type": "str" @@ -10029,17 +10052,17 @@ "meta-type": "alternate" }, { - "name": "315", + "name": "316", "members": [ { "name": "copy-mode", - "type": "313" + "type": "314" } ], "meta-type": "object" }, { - "name": "316", + "name": "317", "members": [ { "name": "blkdebug" @@ -10238,7 +10261,7 @@ ] }, { - "name": "317", + "name": "318", "members": [ { "name": "ignore" @@ -10254,7 +10277,7 @@ ] }, { - "name": "318", + "name": "319", "members": [ { "name": "direct", @@ -10270,11 +10293,11 @@ "meta-type": "object" }, { - "name": "319", + "name": "320", "members": [ { "name": "image", - "type": "580" + "type": "582" }, { "name": "config", @@ -10314,36 +10337,36 @@ { "name": "inject-error", "default": null, - "type": "[581]" + "type": "[583]" }, { "name": "set-state", "default": null, - "type": "[582]" + "type": "[584]" }, { "name": "take-child-perms", "default": null, - "type": "[579]" + "type": "[581]" }, { "name": "unshare-child-perms", "default": null, - "type": "[579]" + "type": "[581]" } ], "meta-type": "object" }, { - "name": "320", + "name": "321", "members": [ { "name": "file", - "type": "580" + "type": "582" }, { "name": "log", - "type": "580" + "type": "582" }, { "name": "log-sector-size", @@ -10364,49 +10387,49 @@ "meta-type": "object" }, { - "name": "321", + "name": "322", "members": [ { "name": "test", - "type": "580" + "type": "582" }, { "name": "raw", - "type": "580" + "type": "582" } ], "meta-type": "object" }, { - "name": "322", + "name": "323", "members": [ { "name": "image", - "type": "580" + "type": "582" } ], "meta-type": "object" }, { - "name": "323", + "name": "324", "members": [ { "name": "file", - "type": "580" + "type": "582" } ], "meta-type": "object" }, { - "name": "324", + "name": "325", "members": [ { "name": "file", - "type": "580" + "type": "582" }, { "name": "target", - "type": "580" + "type": "582" }, { "name": "bitmap", @@ -10416,7 +10439,7 @@ { "name": "on-cbw-error", "default": null, - "type": "583" + "type": "585" }, { "name": "cbw-timeout", @@ -10432,11 +10455,11 @@ "meta-type": "object" }, { - "name": "325", + "name": "326", "members": [ { "name": "file", - "type": "580" + "type": "582" }, { "name": "bottom", @@ -10447,7 +10470,7 @@ "meta-type": "object" }, { - "name": "326", + "name": "327", "members": [ { "name": "filename", @@ -10461,12 +10484,12 @@ { "name": "locking", "default": null, - "type": "584" + "type": "586" }, { "name": "aio", "default": null, - "type": "585" + "type": "587" }, { "name": "aio-max-batch", @@ -10493,7 +10516,7 @@ ] }, { - "name": "327", + "name": "328", "members": [ { "name": "url", @@ -10533,7 +10556,7 @@ "meta-type": "object" }, { - "name": "328", + "name": "329", "members": [ { "name": "url", @@ -10578,7 +10601,7 @@ "meta-type": "object" }, { - "name": "329", + "name": "330", "members": [ { "name": "volume", @@ -10590,7 +10613,7 @@ }, { "name": "server", - "type": "[390]" + "type": "[391]" }, { "name": "debug", @@ -10606,7 +10629,7 @@ "meta-type": "object" }, { - "name": "330", + "name": "331", "members": [ { "name": "url", @@ -10656,7 +10679,7 @@ "meta-type": "object" }, { - "name": "331", + "name": "332", "members": [ { "name": "url", @@ -10711,7 +10734,7 @@ "meta-type": "object" }, { - "name": "332", + "name": "333", "members": [ { "name": "filename", @@ -10721,11 +10744,11 @@ "meta-type": "object" }, { - "name": "333", + "name": "334", "members": [ { "name": "transport", - "type": "586" + "type": "588" }, { "name": "portal", @@ -10758,7 +10781,7 @@ { "name": "header-digest", "default": null, - "type": "587" + "type": "589" }, { "name": "timeout", @@ -10769,11 +10792,11 @@ "meta-type": "object" }, { - "name": "334", + "name": "335", "members": [ { "name": "file", - "type": "580" + "type": "582" }, { "name": "key-secret", @@ -10783,17 +10806,17 @@ { "name": "header", "default": null, - "type": "580" + "type": "582" } ], "meta-type": "object" }, { - "name": "335", + "name": "336", "members": [ { "name": "server", - "type": "390" + "type": "391" }, { "name": "export", @@ -10832,11 +10855,11 @@ "meta-type": "object" }, { - "name": "336", + "name": "337", "members": [ { "name": "server", - "type": "588" + "type": "590" }, { "name": "path", @@ -10876,7 +10899,7 @@ "meta-type": "object" }, { - "name": "337", + "name": "338", "members": [ { "name": "size", @@ -10897,7 +10920,7 @@ "meta-type": "object" }, { - "name": "338", + "name": "339", "members": [ { "name": "device", @@ -10911,7 +10934,7 @@ "meta-type": "object" }, { - "name": "339", + "name": "340", "members": [ { "name": "path", @@ -10921,11 +10944,11 @@ "meta-type": "object" }, { - "name": "340", + "name": "341", "members": [ { "name": "file", - "type": "580" + "type": "582" }, { "name": "prealloc-align", @@ -10941,16 +10964,16 @@ "meta-type": "object" }, { - "name": "341", + "name": "342", "members": [ { "name": "file", - "type": "580" + "type": "582" }, { "name": "backing", "default": null, - "type": "589" + "type": "591" }, { "name": "lazy-refcounts", @@ -10980,7 +11003,7 @@ { "name": "overlap-check", "default": null, - "type": "590" + "type": "592" }, { "name": "cache-size", @@ -11010,53 +11033,53 @@ { "name": "encrypt", "default": null, - "type": "591" + "type": "593" }, { "name": "data-file", "default": null, - "type": "580" + "type": "582" } ], "meta-type": "object" }, { - "name": "342", + "name": "343", "members": [ { "name": "file", - "type": "580" + "type": "582" }, { "name": "backing", "default": null, - "type": "589" + "type": "591" }, { "name": "encrypt", "default": null, - "type": "592" + "type": "594" } ], "meta-type": "object" }, { - "name": "343", + "name": "344", "members": [ { "name": "file", - "type": "580" + "type": "582" }, { "name": "backing", "default": null, - "type": "589" + "type": "591" } ], "meta-type": "object" }, { - "name": "344", + "name": "345", "members": [ { "name": "blkverify", @@ -11065,7 +11088,7 @@ }, { "name": "children", - "type": "[580]" + "type": "[582]" }, { "name": "vote-threshold", @@ -11079,17 +11102,17 @@ { "name": "read-pattern", "default": null, - "type": "593" + "type": "595" } ], "meta-type": "object" }, { - "name": "345", + "name": "346", "members": [ { "name": "file", - "type": "580" + "type": "582" }, { "name": "offset", @@ -11105,7 +11128,7 @@ "meta-type": "object" }, { - "name": "346", + "name": "347", "members": [ { "name": "pool", @@ -11133,7 +11156,7 @@ { "name": "encrypt", "default": null, - "type": "594" + "type": "596" }, { "name": "user", @@ -11143,7 +11166,7 @@ { "name": "auth-client-required", "default": null, - "type": "[595]" + "type": "[597]" }, { "name": "key-secret", @@ -11153,21 +11176,21 @@ { "name": "server", "default": null, - "type": "[596]" + "type": "[598]" } ], "meta-type": "object" }, { - "name": "347", + "name": "348", "members": [ { "name": "file", - "type": "580" + "type": "582" }, { "name": "mode", - "type": "597" + "type": "599" }, { "name": "top-id", @@ -11178,11 +11201,11 @@ "meta-type": "object" }, { - "name": "348", + "name": "349", "members": [ { "name": "server", - "type": "598" + "type": "600" }, { "name": "path", @@ -11196,13 +11219,13 @@ { "name": "host-key-check", "default": null, - "type": "599" + "type": "601" } ], "meta-type": "object" }, { - "name": "349", + "name": "350", "members": [ { "name": "throttle-group", @@ -11210,13 +11233,13 @@ }, { "name": "file", - "type": "580" + "type": "582" } ], "meta-type": "object" }, { - "name": "350", + "name": "351", "members": [ { "name": "path", @@ -11226,7 +11249,7 @@ "meta-type": "object" }, { - "name": "351", + "name": "352", "members": [ { "name": "path", @@ -11236,7 +11259,7 @@ "meta-type": "object" }, { - "name": "352", + "name": "353", "members": [ { "name": "path", @@ -11249,7 +11272,7 @@ ] }, { - "name": "353", + "name": "354", "members": [ { "name": "dir", @@ -11284,64 +11307,64 @@ "meta-type": "array" }, { - "name": "354", + "name": "355", "tag": "driver", "variants": [ { "case": "file", - "type": "600" + "type": "602" }, { "case": "gluster", - "type": "601" + "type": "603" }, { "case": "luks", - "type": "602" + "type": "604" }, { "case": "nfs", - "type": "603" + "type": "605" }, { "case": "parallels", - "type": "604" + "type": "606" }, { "case": "qcow", - "type": "605" + "type": "607" }, { "case": "qcow2", - "type": "606" + "type": "608" }, { "case": "qed", - "type": "607" + "type": "609" }, { "case": "rbd", - "type": "608" + "type": "610" }, { "case": "ssh", - "type": "609" + "type": "611" }, { "case": "vdi", - "type": "610" + "type": "612" }, { "case": "vhdx", - "type": "611" + "type": "613" }, { "case": "vmdk", - "type": "612" + "type": "614" }, { "case": "vpc", - "type": "613" + "type": "615" }, { "case": "blkdebug", @@ -11479,22 +11502,22 @@ "members": [ { "name": "driver", - "type": "316" + "type": "317" } ], "meta-type": "object" }, { - "name": "355", + "name": "356", "tag": "driver", "variants": [ { "case": "luks", - "type": "614" + "type": "616" }, { "case": "qcow2", - "type": "615" + "type": "617" }, { "case": "blkdebug", @@ -11680,13 +11703,13 @@ "members": [ { "name": "driver", - "type": "316" + "type": "317" } ], "meta-type": "object" }, { - "name": "356", + "name": "357", "members": [ { "name": "read" @@ -11702,7 +11725,7 @@ ] }, { - "name": "357", + "name": "358", "members": [ { "name": "ignore" @@ -11722,7 +11745,7 @@ ] }, { - "name": "358", + "name": "359", "members": [ { "type": "str" @@ -11734,7 +11757,7 @@ "meta-type": "alternate" }, { - "name": "359", + "name": "360", "members": [ { "name": "read" @@ -11754,36 +11777,36 @@ ] }, { - "name": "360", + "name": "361", "tag": "type", "variants": [ { "case": "inet", - "type": "617" + "type": "619" }, { "case": "unix", - "type": "618" + "type": "620" }, { "case": "vsock", - "type": "619" + "type": "621" }, { "case": "fd", - "type": "620" + "type": "622" } ], "members": [ { "name": "type", - "type": "616" + "type": "618" } ], "meta-type": "object" }, { - "name": "361", + "name": "362", "members": [ { "name": "safe" @@ -11799,7 +11822,7 @@ ] }, { - "name": "362", + "name": "363", "members": [ { "name": "nbd" @@ -11823,7 +11846,7 @@ ] }, { - "name": "363", + "name": "364", "members": [ { "name": "name", @@ -11838,7 +11861,7 @@ { "name": "bitmaps", "default": null, - "type": "[314]" + "type": "[315]" }, { "name": "allocation-depth", @@ -11849,11 +11872,11 @@ "meta-type": "object" }, { - "name": "364", + "name": "365", "members": [ { "name": "addr", - "type": "390" + "type": "391" }, { "name": "logical-block-size", @@ -11869,7 +11892,7 @@ "meta-type": "object" }, { - "name": "365", + "name": "366", "members": [ { "name": "mountpoint", @@ -11883,13 +11906,13 @@ { "name": "allow-other", "default": null, - "type": "621" + "type": "623" } ], "meta-type": "object" }, { - "name": "366", + "name": "367", "members": [ { "name": "name", @@ -11919,7 +11942,7 @@ "meta-type": "object" }, { - "name": "367", + "name": "368", "members": [ { "name": "utf8" @@ -11935,92 +11958,92 @@ ] }, { - "name": "368", + "name": "369", "tag": "type", "variants": [ { "case": "file", - "type": "623" + "type": "625" }, { "case": "serial", - "type": "624" + "type": "626" }, { "case": "parallel", - "type": "624" + "type": "626" }, { "case": "pipe", - "type": "624" + "type": "626" }, { "case": "socket", - "type": "625" + "type": "627" }, { "case": "udp", - "type": "626" + "type": "628" }, { "case": "pty", - "type": "627" + "type": "629" }, { "case": "null", - "type": "628" + "type": "630" }, { "case": "mux", - "type": "629" + "type": "631" }, { "case": "msmouse", - "type": "628" + "type": "630" }, { "case": "wctablet", - "type": "628" + "type": "630" }, { "case": "braille", - "type": "628" + "type": "630" }, { "case": "testdev", - "type": "628" + "type": "630" }, { "case": "stdio", - "type": "630" + "type": "632" }, { "case": "dbus", - "type": "634" + "type": "636" }, { "case": "vc", - "type": "635" + "type": "637" }, { "case": "ringbuf", - "type": "636" + "type": "638" }, { "case": "memory", - "type": "636" + "type": "638" } ], "members": [ { "name": "type", - "type": "622" + "type": "624" } ], "meta-type": "object" }, { - "name": "369", + "name": "370", "members": [ { "name": "elf" @@ -12060,7 +12083,7 @@ ] }, { - "name": "370", + "name": "371", "members": [ { "name": "none" @@ -12084,12 +12107,12 @@ ] }, { - "name": "[369]", - "element-type": "369", + "name": "[370]", + "element-type": "370", "meta-type": "array" }, { - "name": "371", + "name": "372", "members": [ { "name": "none" @@ -12157,7 +12180,7 @@ ] }, { - "name": "372", + "name": "373", "members": [ { "name": "netdev", @@ -12188,7 +12211,7 @@ "meta-type": "object" }, { - "name": "373", + "name": "374", "members": [ { "name": "hostname", @@ -12248,7 +12271,7 @@ { "name": "dnssearch", "default": null, - "type": "[637]" + "type": "[639]" }, { "name": "domainname", @@ -12288,12 +12311,12 @@ { "name": "hostfwd", "default": null, - "type": "[637]" + "type": "[639]" }, { "name": "guestfwd", "default": null, - "type": "[637]" + "type": "[639]" }, { "name": "tftp-server-name", @@ -12304,7 +12327,7 @@ "meta-type": "object" }, { - "name": "374", + "name": "375", "members": [ { "name": "ifname", @@ -12385,7 +12408,7 @@ "meta-type": "object" }, { - "name": "375", + "name": "376", "members": [ { "name": "src", @@ -12458,7 +12481,7 @@ "meta-type": "object" }, { - "name": "376", + "name": "377", "members": [ { "name": "fd", @@ -12494,11 +12517,11 @@ "meta-type": "object" }, { - "name": "377", + "name": "378", "members": [ { "name": "addr", - "type": "390" + "type": "391" }, { "name": "server", @@ -12522,23 +12545,23 @@ "meta-type": "object" }, { - "name": "378", + "name": "379", "members": [ { "name": "local", "default": null, - "type": "390" + "type": "391" }, { "name": "remote", "default": null, - "type": "390" + "type": "391" } ], "meta-type": "object" }, { - "name": "379", + "name": "380", "members": [ { "name": "sock", @@ -12564,7 +12587,7 @@ "meta-type": "object" }, { - "name": "380", + "name": "381", "members": [ { "name": "br", @@ -12580,7 +12603,7 @@ "meta-type": "object" }, { - "name": "381", + "name": "382", "members": [ { "name": "hubid", @@ -12595,7 +12618,7 @@ "meta-type": "object" }, { - "name": "382", + "name": "383", "members": [ { "name": "ifname", @@ -12610,7 +12633,7 @@ "meta-type": "object" }, { - "name": "383", + "name": "384", "members": [ { "name": "ifname", @@ -12619,7 +12642,7 @@ { "name": "mode", "default": null, - "type": "638" + "type": "640" }, { "name": "force-copy", @@ -12650,7 +12673,7 @@ "meta-type": "object" }, { - "name": "384", + "name": "385", "members": [ { "name": "chardev", @@ -12670,7 +12693,7 @@ "meta-type": "object" }, { - "name": "385", + "name": "386", "members": [ { "name": "vhostdev", @@ -12699,7 +12722,7 @@ "meta-type": "object" }, { - "name": "389", + "name": "390", "members": [ { "name": "normal" @@ -12724,36 +12747,36 @@ "meta-type": "array" }, { - "name": "390", + "name": "391", "tag": "type", "variants": [ { "case": "inet", - "type": "598" + "type": "600" }, { "case": "unix", - "type": "639" + "type": "641" }, { "case": "vsock", - "type": "640" + "type": "642" }, { "case": "fd", - "type": "641" + "type": "643" } ], "members": [ { "name": "type", - "type": "616" + "type": "618" } ], "meta-type": "object" }, { - "name": "391", + "name": "392", "members": [ { "name": "rss" @@ -12765,7 +12788,7 @@ ] }, { - "name": "392", + "name": "393", "members": [ { "name": "half" @@ -12781,7 +12804,7 @@ ] }, { - "name": "393", + "name": "394", "members": [ { "name": "off" @@ -12797,7 +12820,7 @@ ] }, { - "name": "394", + "name": "395", "members": [ { "name": "priority", @@ -12856,7 +12879,7 @@ "meta-type": "object" }, { - "name": "395", + "name": "396", "members": [ { "name": "in-pport", @@ -12897,7 +12920,7 @@ "meta-type": "object" }, { - "name": "396", + "name": "397", "members": [ { "name": "goto-tbl", @@ -12933,16 +12956,16 @@ "meta-type": "object" }, { - "name": "397", + "name": "398", "tag": "type", "variants": [ { "case": "passthrough", - "type": "642" + "type": "644" }, { "case": "emulator", - "type": "643" + "type": "645" } ], "members": [ @@ -12954,7 +12977,7 @@ "meta-type": "object" }, { - "name": "398", + "name": "399", "members": [ { "name": "vnc" @@ -12970,7 +12993,7 @@ ] }, { - "name": "399", + "name": "400", "members": [ { "name": "keep" @@ -12990,7 +13013,7 @@ ] }, { - "name": "400", + "name": "401", "members": [ { "name": "display", @@ -13001,7 +13024,7 @@ "meta-type": "object" }, { - "name": "401", + "name": "402", "members": [ { "name": "display", @@ -13012,7 +13035,7 @@ "meta-type": "object" }, { - "name": "402", + "name": "403", "members": [ { "name": "ppm" @@ -13028,7 +13051,7 @@ ] }, { - "name": "407", + "name": "408", "members": [ { "name": "ipv4" @@ -13056,12 +13079,12 @@ ] }, { - "name": "[408]", - "element-type": "408", + "name": "[409]", + "element-type": "409", "meta-type": "array" }, { - "name": "408", + "name": "409", "members": [ { "name": "host", @@ -13073,7 +13096,7 @@ }, { "name": "family", - "type": "407" + "type": "408" }, { "name": "websocket", @@ -13093,12 +13116,12 @@ "meta-type": "object" }, { - "name": "[409]", - "element-type": "409", + "name": "[410]", + "element-type": "410", "meta-type": "array" }, { - "name": "409", + "name": "410", "members": [ { "name": "host", @@ -13110,7 +13133,7 @@ }, { "name": "family", - "type": "407" + "type": "408" }, { "name": "websocket", @@ -13118,18 +13141,18 @@ }, { "name": "auth", - "type": "410" + "type": "411" }, { "name": "vencrypt", "default": null, - "type": "411" + "type": "412" } ], "meta-type": "object" }, { - "name": "410", + "name": "411", "members": [ { "name": "none" @@ -13173,7 +13196,7 @@ ] }, { - "name": "411", + "name": "412", "members": [ { "name": "plain" @@ -13217,7 +13240,7 @@ ] }, { - "name": "412", + "name": "413", "members": [ { "name": "host", @@ -13229,7 +13252,7 @@ }, { "name": "family", - "type": "407" + "type": "408" }, { "name": "websocket", @@ -13244,7 +13267,7 @@ "meta-type": "object" }, { - "name": "413", + "name": "414", "members": [ { "name": "host", @@ -13256,7 +13279,7 @@ }, { "name": "family", - "type": "407" + "type": "408" }, { "name": "websocket", @@ -13266,71 +13289,71 @@ "meta-type": "object" }, { - "name": "[414]", - "element-type": "414", + "name": "[415]", + "element-type": "415", "meta-type": "array" }, { - "name": "414", + "name": "415", "tag": "type", "variants": [ { "case": "number", - "type": "645" + "type": "647" }, { "case": "qcode", - "type": "646" + "type": "648" } ], "members": [ { "name": "type", - "type": "644" + "type": "646" } ], "meta-type": "object" }, { - "name": "[415]", - "element-type": "415", + "name": "[416]", + "element-type": "416", "meta-type": "array" }, { - "name": "415", + "name": "416", "tag": "type", "variants": [ { "case": "key", - "type": "648" + "type": "650" }, { "case": "btn", - "type": "649" + "type": "651" }, { "case": "rel", - "type": "650" + "type": "652" }, { "case": "abs", - "type": "650" + "type": "652" }, { "case": "mtt", - "type": "651" + "type": "653" } ], "members": [ { "name": "type", - "type": "647" + "type": "649" } ], "meta-type": "object" }, { - "name": "416", + "name": "417", "members": [ { "name": "default" @@ -13366,7 +13389,7 @@ ] }, { - "name": "417", + "name": "418", "members": [ { "name": "off" @@ -13390,7 +13413,7 @@ ] }, { - "name": "418", + "name": "419", "members": [ { "name": "grab-on-hover", @@ -13416,7 +13439,7 @@ "meta-type": "object" }, { - "name": "419", + "name": "420", "members": [ { "name": "left-command-key", @@ -13447,7 +13470,7 @@ "meta-type": "object" }, { - "name": "420", + "name": "421", "members": [ { "name": "charset", @@ -13458,7 +13481,7 @@ "meta-type": "object" }, { - "name": "421", + "name": "422", "members": [ { "name": "rendernode", @@ -13469,7 +13492,7 @@ "meta-type": "object" }, { - "name": "422", + "name": "423", "members": [ { "name": "rendernode", @@ -13495,18 +13518,18 @@ "meta-type": "object" }, { - "name": "423", + "name": "424", "members": [ { "name": "grab-mod", "default": null, - "type": "652" + "type": "654" } ], "meta-type": "object" }, { - "name": "424", + "name": "425", "members": [ { "name": "vnc" @@ -13518,7 +13541,7 @@ ] }, { - "name": "425", + "name": "426", "members": [ { "name": "tls-certs", @@ -13529,7 +13552,7 @@ "meta-type": "object" }, { - "name": "426", + "name": "427", "members": [ { "name": "vnc" @@ -13541,18 +13564,18 @@ ] }, { - "name": "427", + "name": "428", "members": [ { "name": "addresses", "default": null, - "type": "[390]" + "type": "[391]" } ], "meta-type": "object" }, { - "name": "428", + "name": "429", "members": [ { "name": "none" @@ -13620,7 +13643,7 @@ ] }, { - "name": "429", + "name": "430", "members": [ { "name": "transferred", @@ -13694,7 +13717,7 @@ "meta-type": "object" }, { - "name": "430", + "name": "431", "members": [ { "name": "transferred", @@ -13704,7 +13727,7 @@ "meta-type": "object" }, { - "name": "431", + "name": "432", "members": [ { "name": "cache-size", @@ -13738,12 +13761,12 @@ "meta-type": "object" }, { - "name": "[390]", - "element-type": "390", + "name": "[391]", + "element-type": "391", "meta-type": "array" }, { - "name": "432", + "name": "433", "members": [ { "name": "xbzrle" @@ -13848,7 +13871,7 @@ ] }, { - "name": "433", + "name": "434", "members": [ { "name": "none" @@ -13868,12 +13891,12 @@ ] }, { - "name": "[434]", - "element-type": "434", + "name": "[435]", + "element-type": "435", "meta-type": "array" }, { - "name": "434", + "name": "435", "members": [ { "name": "node-name", @@ -13885,13 +13908,13 @@ }, { "name": "bitmaps", - "type": "[653]" + "type": "[655]" } ], "meta-type": "object" }, { - "name": "435", + "name": "436", "members": [ { "name": "normal" @@ -13907,7 +13930,7 @@ ] }, { - "name": "436", + "name": "437", "members": [ { "name": "none" @@ -13927,7 +13950,7 @@ ] }, { - "name": "437", + "name": "438", "members": [ { "name": "none" @@ -13947,7 +13970,7 @@ ] }, { - "name": "438", + "name": "439", "members": [ { "name": "none" @@ -13971,26 +13994,26 @@ ] }, { - "name": "[439]", - "element-type": "439", + "name": "[440]", + "element-type": "440", "meta-type": "array" }, { - "name": "439", + "name": "440", "members": [ { "name": "channel-type", - "type": "654" + "type": "656" }, { "name": "addr", - "type": "655" + "type": "657" } ], "meta-type": "object" }, { - "name": "440", + "name": "441", "members": [ { "name": "second" @@ -14006,7 +14029,7 @@ ] }, { - "name": "441", + "name": "442", "members": [ { "name": "page-sampling" @@ -14026,7 +14049,7 @@ ] }, { - "name": "442", + "name": "443", "members": [ { "name": "unstarted" @@ -14046,12 +14069,12 @@ ] }, { - "name": "[443]", - "element-type": "443", + "name": "[444]", + "element-type": "444", "meta-type": "array" }, { - "name": "443", + "name": "444", "members": [ { "name": "id", @@ -14065,84 +14088,84 @@ "meta-type": "object" }, { - "name": "[444]", - "element-type": "444", + "name": "[445]", + "element-type": "445", "meta-type": "array" }, { - "name": "444", + "name": "445", "tag": "type", "variants": [ { "case": "abort", - "type": "657" + "type": "659" }, { "case": "block-dirty-bitmap-add", - "type": "658" + "type": "660" }, { "case": "block-dirty-bitmap-remove", - "type": "659" + "type": "661" }, { "case": "block-dirty-bitmap-clear", - "type": "659" + "type": "661" }, { "case": "block-dirty-bitmap-enable", - "type": "659" + "type": "661" }, { "case": "block-dirty-bitmap-disable", - "type": "659" + "type": "661" }, { "case": "block-dirty-bitmap-merge", - "type": "660" + "type": "662" }, { "case": "blockdev-backup", - "type": "661" + "type": "663" }, { "case": "blockdev-snapshot", - "type": "662" + "type": "664" }, { "case": "blockdev-snapshot-internal-sync", - "type": "663" + "type": "665" }, { "case": "blockdev-snapshot-sync", - "type": "664" + "type": "666" }, { "case": "drive-backup", - "type": "665" + "type": "667" } ], "members": [ { "name": "type", - "type": "656" + "type": "658" } ], "meta-type": "object" }, { - "name": "445", + "name": "446", "members": [ { "name": "completion-mode", "default": null, - "type": "666" + "type": "668" } ], "meta-type": "object" }, { - "name": "446", + "name": "447", "members": [ { "name": "unavailable" @@ -14162,12 +14185,12 @@ ] }, { - "name": "[447]", - "element-type": "447", + "name": "[448]", + "element-type": "448", "meta-type": "array" }, { - "name": "447", + "name": "448", "members": [ { "name": "oob" @@ -14179,7 +14202,7 @@ ] }, { - "name": "448", + "name": "449", "members": [ { "name": "major", @@ -14197,7 +14220,7 @@ "meta-type": "object" }, { - "name": "449", + "name": "450", "members": [ { "name": "builtin" @@ -14233,21 +14256,21 @@ ] }, { - "name": "450", + "name": "451", "members": [ { "name": "json-type", - "type": "667" + "type": "669" } ], "meta-type": "object" }, { - "name": "451", + "name": "452", "members": [ { "name": "members", - "type": "[668]" + "type": "[670]" }, { "name": "values", @@ -14260,7 +14283,7 @@ "meta-type": "object" }, { - "name": "452", + "name": "453", "members": [ { "name": "element-type", @@ -14270,11 +14293,11 @@ "meta-type": "object" }, { - "name": "453", + "name": "454", "members": [ { "name": "members", - "type": "[669]" + "type": "[671]" }, { "name": "tag", @@ -14284,23 +14307,23 @@ { "name": "variants", "default": null, - "type": "[670]" + "type": "[672]" } ], "meta-type": "object" }, { - "name": "454", + "name": "455", "members": [ { "name": "members", - "type": "[671]" + "type": "[673]" } ], "meta-type": "object" }, { - "name": "455", + "name": "456", "members": [ { "name": "arg-type", @@ -14319,7 +14342,7 @@ "meta-type": "object" }, { - "name": "456", + "name": "457", "members": [ { "name": "arg-type", @@ -14329,11 +14352,14 @@ "meta-type": "object" }, { - "name": "457", + "name": "458", "members": [ { "name": "acpi-generic-initiator" }, + { + "name": "acpi-generic-port" + }, { "name": "authz-list" }, @@ -14485,6 +14511,7 @@ "meta-type": "enum", "values": [ "acpi-generic-initiator", + "acpi-generic-port", "authz-list", "authz-listfile", "authz-pam", @@ -14535,7 +14562,7 @@ ] }, { - "name": "458", + "name": "459", "members": [ { "name": "pci-dev", @@ -14549,23 +14576,37 @@ "meta-type": "object" }, { - "name": "459", + "name": "460", + "members": [ + { + "name": "pci-bus", + "type": "str" + }, + { + "name": "node", + "type": "int" + } + ], + "meta-type": "object" + }, + { + "name": "461", "members": [ { "name": "policy", "default": null, - "type": "672" + "type": "674" }, { "name": "rules", "default": null, - "type": "[673]" + "type": "[675]" } ], "meta-type": "object" }, { - "name": "460", + "name": "462", "members": [ { "name": "filename", @@ -14580,7 +14621,7 @@ "meta-type": "object" }, { - "name": "461", + "name": "463", "members": [ { "name": "service", @@ -14590,7 +14631,7 @@ "meta-type": "object" }, { - "name": "462", + "name": "464", "members": [ { "name": "identity", @@ -14600,7 +14641,7 @@ "meta-type": "object" }, { - "name": "463", + "name": "465", "members": [ { "name": "if", @@ -14614,7 +14655,7 @@ "meta-type": "object" }, { - "name": "464", + "name": "466", "members": [ { "name": "primary_in", @@ -14661,7 +14702,7 @@ "meta-type": "object" }, { - "name": "465", + "name": "467", "members": [ { "name": "queues", @@ -14682,7 +14723,7 @@ "meta-type": "object" }, { - "name": "466", + "name": "468", "members": [ { "name": "queues", @@ -14707,7 +14748,7 @@ "meta-type": "object" }, { - "name": "467", + "name": "469", "members": [ { "name": "addr", @@ -14722,7 +14763,7 @@ "meta-type": "object" }, { - "name": "468", + "name": "470", "members": [ { "name": "netdev", @@ -14731,7 +14772,7 @@ { "name": "queue", "default": null, - "type": "674" + "type": "676" }, { "name": "status", @@ -14746,7 +14787,7 @@ { "name": "insert", "default": null, - "type": "675" + "type": "677" }, { "name": "interval", @@ -14756,7 +14797,7 @@ "meta-type": "object" }, { - "name": "469", + "name": "471", "members": [ { "name": "netdev", @@ -14765,7 +14806,7 @@ { "name": "queue", "default": null, - "type": "674" + "type": "676" }, { "name": "status", @@ -14780,7 +14821,7 @@ { "name": "insert", "default": null, - "type": "675" + "type": "677" }, { "name": "file", @@ -14795,7 +14836,7 @@ "meta-type": "object" }, { - "name": "470", + "name": "472", "members": [ { "name": "netdev", @@ -14804,7 +14845,7 @@ { "name": "queue", "default": null, - "type": "674" + "type": "676" }, { "name": "status", @@ -14819,7 +14860,7 @@ { "name": "insert", "default": null, - "type": "675" + "type": "677" }, { "name": "outdev", @@ -14834,7 +14875,7 @@ "meta-type": "object" }, { - "name": "471", + "name": "473", "members": [ { "name": "netdev", @@ -14843,7 +14884,7 @@ { "name": "queue", "default": null, - "type": "674" + "type": "676" }, { "name": "status", @@ -14858,7 +14899,7 @@ { "name": "insert", "default": null, - "type": "675" + "type": "677" }, { "name": "indev", @@ -14879,7 +14920,7 @@ "meta-type": "object" }, { - "name": "472", + "name": "474", "members": [ { "name": "netdev", @@ -14888,7 +14929,7 @@ { "name": "queue", "default": null, - "type": "674" + "type": "676" }, { "name": "status", @@ -14903,13 +14944,13 @@ { "name": "insert", "default": null, - "type": "675" + "type": "677" } ], "meta-type": "object" }, { - "name": "473", + "name": "475", "members": [ { "name": "netdev", @@ -14918,7 +14959,7 @@ { "name": "queue", "default": null, - "type": "674" + "type": "676" }, { "name": "status", @@ -14933,7 +14974,7 @@ { "name": "insert", "default": null, - "type": "675" + "type": "677" }, { "name": "vnet_hdr_support", @@ -14944,7 +14985,7 @@ "meta-type": "object" }, { - "name": "474", + "name": "476", "members": [ { "name": "name", @@ -14984,7 +15025,7 @@ "meta-type": "object" }, { - "name": "475", + "name": "477", "members": [ { "name": "evdev", @@ -15003,13 +15044,13 @@ { "name": "grab-toggle", "default": null, - "type": "676" + "type": "678" } ], "meta-type": "object" }, { - "name": "476", + "name": "478", "members": [ { "name": "fd", @@ -15020,7 +15061,7 @@ "meta-type": "object" }, { - "name": "477", + "name": "479", "members": [ { "name": "aio-max-batch", @@ -15056,7 +15097,7 @@ "meta-type": "object" }, { - "name": "478", + "name": "480", "members": [ { "name": "aio-max-batch", @@ -15077,7 +15118,7 @@ "meta-type": "object" }, { - "name": "479", + "name": "481", "members": [ { "name": "dump", @@ -15097,7 +15138,7 @@ { "name": "policy", "default": null, - "type": "505" + "type": "507" }, { "name": "prealloc", @@ -15137,7 +15178,7 @@ "meta-type": "object" }, { - "name": "480", + "name": "482", "members": [ { "name": "dump", @@ -15157,7 +15198,7 @@ { "name": "policy", "default": null, - "type": "505" + "type": "507" }, { "name": "prealloc", @@ -15220,13 +15261,13 @@ { "name": "rom", "default": null, - "type": "584" + "type": "586" } ], "meta-type": "object" }, { - "name": "481", + "name": "483", "members": [ { "name": "dump", @@ -15246,7 +15287,7 @@ { "name": "policy", "default": null, - "type": "505" + "type": "507" }, { "name": "prealloc", @@ -15301,7 +15342,7 @@ "meta-type": "object" }, { - "name": "482", + "name": "484", "members": [ { "name": "dump", @@ -15321,7 +15362,7 @@ { "name": "policy", "default": null, - "type": "505" + "type": "507" }, { "name": "prealloc", @@ -15361,7 +15402,7 @@ "meta-type": "object" }, { - "name": "483", + "name": "485", "members": [ { "name": "dump", @@ -15381,7 +15422,7 @@ { "name": "policy", "default": null, - "type": "505" + "type": "507" }, { "name": "prealloc", @@ -15421,7 +15462,7 @@ "meta-type": "object" }, { - "name": "484", + "name": "486", "members": [ { "name": "path", @@ -15431,7 +15472,7 @@ "meta-type": "object" }, { - "name": "485", + "name": "487", "members": [ { "name": "chardev", @@ -15446,7 +15487,7 @@ "meta-type": "object" }, { - "name": "486", + "name": "488", "members": [ { "name": "opened", @@ -15460,7 +15501,7 @@ "meta-type": "object" }, { - "name": "487", + "name": "489", "members": [ { "name": "opened", @@ -15478,7 +15519,7 @@ "meta-type": "object" }, { - "name": "488", + "name": "490", "members": [ { "name": "opened", @@ -15497,20 +15538,12 @@ "meta-type": "object" }, { - "name": "489", + "name": "491", "members": [ - { - "name": "loaded", - "default": null, - "type": "bool", - "features": [ - "deprecated" - ] - }, { "name": "format", "default": null, - "type": "677" + "type": "679" }, { "name": "keyid", @@ -15536,20 +15569,12 @@ "meta-type": "object" }, { - "name": "490", + "name": "492", "members": [ - { - "name": "loaded", - "default": null, - "type": "bool", - "features": [ - "deprecated" - ] - }, { "name": "format", "default": null, - "type": "677" + "type": "679" }, { "name": "keyid", @@ -15569,7 +15594,7 @@ "meta-type": "object" }, { - "name": "491", + "name": "493", "members": [ { "name": "sev-device", @@ -15613,13 +15638,13 @@ { "name": "legacy-vm-type", "default": null, - "type": "584" + "type": "586" } ], "meta-type": "object" }, { - "name": "492", + "name": "494", "members": [ { "name": "sev-device", @@ -15679,7 +15704,7 @@ "meta-type": "object" }, { - "name": "493", + "name": "495", "members": [ { "name": "cpu-affinity", @@ -15695,12 +15720,12 @@ "meta-type": "object" }, { - "name": "494", + "name": "496", "members": [ { "name": "limits", "default": null, - "type": "678" + "type": "680" }, { "name": "x-iops-total", @@ -15858,7 +15883,7 @@ "meta-type": "object" }, { - "name": "495", + "name": "497", "members": [ { "name": "verify-peer", @@ -15873,26 +15898,18 @@ { "name": "endpoint", "default": null, - "type": "679" + "type": "681" }, { "name": "priority", "default": null, "type": "str" - }, - { - "name": "loaded", - "default": null, - "type": "bool", - "features": [ - "deprecated" - ] } ], "meta-type": "object" }, { - "name": "496", + "name": "498", "members": [ { "name": "verify-peer", @@ -15907,21 +15924,13 @@ { "name": "endpoint", "default": null, - "type": "679" + "type": "681" }, { "name": "priority", "default": null, "type": "str" }, - { - "name": "loaded", - "default": null, - "type": "bool", - "features": [ - "deprecated" - ] - }, { "name": "username", "default": null, @@ -15931,7 +15940,7 @@ "meta-type": "object" }, { - "name": "497", + "name": "499", "members": [ { "name": "verify-peer", @@ -15946,21 +15955,13 @@ { "name": "endpoint", "default": null, - "type": "679" + "type": "681" }, { "name": "priority", "default": null, "type": "str" }, - { - "name": "loaded", - "default": null, - "type": "bool", - "features": [ - "deprecated" - ] - }, { "name": "sanity-check", "default": null, @@ -15975,7 +15976,7 @@ "meta-type": "object" }, { - "name": "498", + "name": "500", "members": [ { "name": "verify-peer", @@ -15990,7 +15991,7 @@ { "name": "endpoint", "default": null, - "type": "679" + "type": "681" }, { "name": "priority", @@ -16001,7 +16002,7 @@ "meta-type": "object" }, { - "name": "499", + "name": "501", "members": [ { "name": "fd", @@ -16015,11 +16016,11 @@ "meta-type": "object" }, { - "name": "500", + "name": "502", "members": [ { "name": "socket", - "type": "390" + "type": "391" }, { "name": "device", @@ -16029,7 +16030,7 @@ "meta-type": "object" }, { - "name": "501", + "name": "503", "members": [ { "name": "node-id", @@ -16080,7 +16081,7 @@ "meta-type": "object" }, { - "name": "502", + "name": "504", "members": [ { "name": "aarch64" @@ -16204,11 +16205,11 @@ ] }, { - "name": "503", + "name": "505", "members": [ { "name": "cpu-state", - "type": "680" + "type": "682" }, { "name": "dedicated", @@ -16218,18 +16219,18 @@ { "name": "entitlement", "default": null, - "type": "521" + "type": "523" } ], "meta-type": "object" }, { - "name": "[504]", - "element-type": "504", + "name": "[506]", + "element-type": "506", "meta-type": "array" }, { - "name": "504", + "name": "506", "members": [ { "name": "qom-type", @@ -16247,7 +16248,7 @@ "meta-type": "object" }, { - "name": "505", + "name": "507", "members": [ { "name": "default" @@ -16271,7 +16272,7 @@ ] }, { - "name": "506", + "name": "508", "members": [ { "name": "node" @@ -16299,7 +16300,7 @@ ] }, { - "name": "507", + "name": "509", "members": [ { "name": "nodeid", @@ -16330,7 +16331,7 @@ "meta-type": "object" }, { - "name": "508", + "name": "510", "members": [ { "name": "src", @@ -16348,7 +16349,7 @@ "meta-type": "object" }, { - "name": "509", + "name": "511", "members": [ { "name": "node-id", @@ -16399,7 +16400,7 @@ "meta-type": "object" }, { - "name": "510", + "name": "512", "members": [ { "name": "initiator", @@ -16411,11 +16412,11 @@ }, { "name": "hierarchy", - "type": "681" + "type": "683" }, { "name": "data-type", - "type": "682" + "type": "684" }, { "name": "latency", @@ -16431,7 +16432,7 @@ "meta-type": "object" }, { - "name": "511", + "name": "513", "members": [ { "name": "node-id", @@ -16447,11 +16448,11 @@ }, { "name": "associativity", - "type": "683" + "type": "685" }, { "name": "policy", - "type": "684" + "type": "686" }, { "name": "line", @@ -16461,7 +16462,7 @@ "meta-type": "object" }, { - "name": "512", + "name": "514", "members": [ { "name": "dimm" @@ -16493,57 +16494,57 @@ ] }, { - "name": "513", + "name": "515", "members": [ { "name": "data", - "type": "685" + "type": "687" } ], "meta-type": "object" }, { - "name": "514", + "name": "516", "members": [ { "name": "data", - "type": "686" + "type": "688" } ], "meta-type": "object" }, { - "name": "515", + "name": "517", "members": [ { "name": "data", - "type": "687" + "type": "689" } ], "meta-type": "object" }, { - "name": "516", + "name": "518", "members": [ { "name": "data", - "type": "688" + "type": "690" } ], "meta-type": "object" }, { - "name": "517", + "name": "519", "members": [ { "name": "data", - "type": "689" + "type": "691" } ], "meta-type": "object" }, { - "name": "518", + "name": "520", "members": [ { "name": "name", @@ -16558,7 +16559,7 @@ "meta-type": "object" }, { - "name": "519", + "name": "521", "members": [ { "name": "incompatible" @@ -16582,7 +16583,7 @@ ] }, { - "name": "520", + "name": "522", "members": [ { "name": "static" @@ -16598,7 +16599,7 @@ ] }, { - "name": "521", + "name": "523", "members": [ { "name": "auto" @@ -16622,7 +16623,7 @@ ] }, { - "name": "522", + "name": "524", "members": [ { "name": "horizontal" @@ -16638,7 +16639,7 @@ ] }, { - "name": "523", + "name": "525", "members": [ { "name": "none" @@ -16658,7 +16659,7 @@ ] }, { - "name": "524", + "name": "526", "members": [ { "name": "block-node" @@ -16678,7 +16679,7 @@ ] }, { - "name": "525", + "name": "527", "members": [ { "name": "node-name", @@ -16688,7 +16689,7 @@ "meta-type": "object" }, { - "name": "526", + "name": "528", "members": [ { "name": "id", @@ -16698,12 +16699,12 @@ "meta-type": "object" }, { - "name": "[527]", - "element-type": "527", + "name": "[529]", + "element-type": "529", "meta-type": "array" }, { - "name": "527", + "name": "529", "members": [ { "name": "fd", @@ -16718,12 +16719,12 @@ "meta-type": "object" }, { - "name": "[528]", - "element-type": "528", + "name": "[530]", + "element-type": "530", "meta-type": "array" }, { - "name": "528", + "name": "530", "members": [ { "name": "name", @@ -16731,7 +16732,7 @@ }, { "name": "type", - "type": "690" + "type": "692" }, { "name": "help", @@ -16747,12 +16748,12 @@ "meta-type": "object" }, { - "name": "[533]", - "element-type": "533", + "name": "[535]", + "element-type": "535", "meta-type": "array" }, { - "name": "533", + "name": "535", "members": [ { "name": "node", @@ -16766,7 +16767,7 @@ "meta-type": "object" }, { - "name": "535", + "name": "537", "members": [ { "name": "none" @@ -16809,43 +16810,6 @@ "wav" ] }, - { - "name": "536", - "members": [ - { - "name": "in", - "default": null, - "type": "691" - }, - { - "name": "out", - "default": null, - "type": "691" - } - ], - "meta-type": "object" - }, - { - "name": "537", - "members": [ - { - "name": "in", - "default": null, - "type": "692" - }, - { - "name": "out", - "default": null, - "type": "692" - }, - { - "name": "threshold", - "default": null, - "type": "int" - } - ], - "meta-type": "object" - }, { "name": "538", "members": [ @@ -16868,15 +16832,15 @@ { "name": "in", "default": null, - "type": "691" + "type": "694" }, { "name": "out", "default": null, - "type": "691" + "type": "694" }, { - "name": "latency", + "name": "threshold", "default": null, "type": "int" } @@ -16889,12 +16853,12 @@ { "name": "in", "default": null, - "type": "694" + "type": "695" }, { "name": "out", "default": null, - "type": "694" + "type": "695" } ], "meta-type": "object" @@ -16905,12 +16869,49 @@ { "name": "in", "default": null, - "type": "695" + "type": "693" }, { "name": "out", "default": null, - "type": "695" + "type": "693" + }, + { + "name": "latency", + "default": null, + "type": "int" + } + ], + "meta-type": "object" + }, + { + "name": "542", + "members": [ + { + "name": "in", + "default": null, + "type": "696" + }, + { + "name": "out", + "default": null, + "type": "696" + } + ], + "meta-type": "object" + }, + { + "name": "543", + "members": [ + { + "name": "in", + "default": null, + "type": "697" + }, + { + "name": "out", + "default": null, + "type": "697" }, { "name": "try-mmap", @@ -16931,17 +16932,17 @@ "meta-type": "object" }, { - "name": "542", + "name": "544", "members": [ { "name": "in", "default": null, - "type": "696" + "type": "698" }, { "name": "out", "default": null, - "type": "696" + "type": "698" }, { "name": "server", @@ -16952,49 +16953,49 @@ "meta-type": "object" }, { - "name": "543", + "name": "545", "members": [ { "name": "in", "default": null, - "type": "697" + "type": "699" }, { "name": "out", "default": null, - "type": "697" + "type": "699" } ], "meta-type": "object" }, { - "name": "544", + "name": "546", "members": [ { "name": "in", "default": null, - "type": "698" + "type": "700" }, { "name": "out", "default": null, - "type": "698" + "type": "700" } ], "meta-type": "object" }, { - "name": "545", + "name": "547", "members": [ { "name": "in", "default": null, - "type": "691" + "type": "693" }, { "name": "out", "default": null, - "type": "691" + "type": "693" }, { "name": "dev", @@ -17010,17 +17011,17 @@ "meta-type": "object" }, { - "name": "546", + "name": "548", "members": [ { "name": "in", "default": null, - "type": "691" + "type": "693" }, { "name": "out", "default": null, - "type": "691" + "type": "693" }, { "name": "path", @@ -17031,7 +17032,7 @@ "meta-type": "object" }, { - "name": "547", + "name": "549", "members": [ { "name": "DIMM" @@ -17047,12 +17048,12 @@ ] }, { - "name": "[548]", - "element-type": "548", + "name": "[550]", + "element-type": "550", "meta-type": "array" }, { - "name": "548", + "name": "550", "members": [ { "name": "bus", @@ -17068,11 +17069,11 @@ }, { "name": "class_info", - "type": "699" + "type": "701" }, { "name": "id", - "type": "700" + "type": "702" }, { "name": "irq", @@ -17090,17 +17091,17 @@ { "name": "pci_bridge", "default": null, - "type": "701" + "type": "703" }, { "name": "regions", - "type": "[702]" + "type": "[704]" } ], "meta-type": "object" }, { - "name": "549", + "name": "551", "members": [ { "name": "vm" @@ -17120,16 +17121,16 @@ ] }, { - "name": "[550]", - "element-type": "550", + "name": "[552]", + "element-type": "552", "meta-type": "array" }, { - "name": "550", + "name": "552", "members": [ { "name": "provider", - "type": "552" + "type": "554" }, { "name": "names", @@ -17140,7 +17141,7 @@ "meta-type": "object" }, { - "name": "551", + "name": "553", "members": [ { "name": "vcpus", @@ -17151,7 +17152,7 @@ "meta-type": "object" }, { - "name": "552", + "name": "554", "members": [ { "name": "kvm" @@ -17167,12 +17168,12 @@ ] }, { - "name": "[553]", - "element-type": "553", + "name": "[555]", + "element-type": "555", "meta-type": "array" }, { - "name": "553", + "name": "555", "members": [ { "name": "name", @@ -17180,18 +17181,18 @@ }, { "name": "value", - "type": "703" + "type": "705" } ], "meta-type": "object" }, { - "name": "[554]", - "element-type": "554", + "name": "[556]", + "element-type": "556", "meta-type": "array" }, { - "name": "554", + "name": "556", "members": [ { "name": "name", @@ -17199,12 +17200,12 @@ }, { "name": "type", - "type": "704" + "type": "706" }, { "name": "unit", "default": null, - "type": "705" + "type": "707" }, { "name": "base", @@ -17224,7 +17225,7 @@ "meta-type": "object" }, { - "name": "555", + "name": "557", "members": [ { "name": "transports", @@ -17244,7 +17245,7 @@ "meta-type": "object" }, { - "name": "556", + "name": "558", "members": [ { "name": "statuses", @@ -17259,7 +17260,7 @@ "meta-type": "object" }, { - "name": "557", + "name": "559", "members": [ { "name": "n-mem-sections", @@ -17279,19 +17280,19 @@ }, { "name": "features", - "type": "555" + "type": "557" }, { "name": "acked-features", - "type": "555" + "type": "557" }, { "name": "backend-features", - "type": "555" + "type": "557" }, { "name": "protocol-features", - "type": "706" + "type": "708" }, { "name": "max-queues", @@ -17313,12 +17314,12 @@ "meta-type": "object" }, { - "name": "[558]", - "element-type": "558", + "name": "[560]", + "element-type": "560", "meta-type": "array" }, { - "name": "558", + "name": "560", "members": [ { "name": "addr", @@ -17336,7 +17337,7 @@ "meta-type": "object" }, { - "name": "559", + "name": "561", "members": [ { "name": "flags", @@ -17354,7 +17355,7 @@ "meta-type": "object" }, { - "name": "560", + "name": "562", "members": [ { "name": "flags", @@ -17368,7 +17369,7 @@ "meta-type": "object" }, { - "name": "561", + "name": "563", "members": [ { "name": "stop" @@ -17404,12 +17405,12 @@ ] }, { - "name": "[562]", - "element-type": "562", + "name": "[564]", + "element-type": "564", "meta-type": "array" }, { - "name": "562", + "name": "564", "members": [ { "name": "cipher" @@ -17437,12 +17438,12 @@ ] }, { - "name": "[563]", - "element-type": "563", + "name": "[565]", + "element-type": "565", "meta-type": "array" }, { - "name": "563", + "name": "565", "members": [ { "name": "queue", @@ -17450,13 +17451,13 @@ }, { "name": "type", - "type": "707" + "type": "709" } ], "meta-type": "object" }, { - "name": "564", + "name": "566", "members": [ { "name": "informational" @@ -17480,16 +17481,16 @@ ] }, { - "name": "[565]", - "element-type": "565", + "name": "[567]", + "element-type": "567", "meta-type": "array" }, { - "name": "565", + "name": "567", "members": [ { "name": "type", - "type": "708" + "type": "710" }, { "name": "header", @@ -17499,7 +17500,7 @@ "meta-type": "object" }, { - "name": "566", + "name": "568", "members": [ { "name": "cache-data-ecc" @@ -17535,7 +17536,7 @@ ] }, { - "name": "567", + "name": "569", "members": [ { "name": "free" @@ -17559,12 +17560,12 @@ ] }, { - "name": "[568]", - "element-type": "568", + "name": "[570]", + "element-type": "570", "meta-type": "array" }, { - "name": "568", + "name": "570", "members": [ { "name": "offset", @@ -17578,7 +17579,7 @@ "meta-type": "object" }, { - "name": "569", + "name": "571", "members": [ { "name": "tag-based" @@ -17594,7 +17595,7 @@ ] }, { - "name": "570", + "name": "572", "members": [ { "name": "hyper-v" @@ -17610,7 +17611,7 @@ ] }, { - "name": "571", + "name": "573", "members": [ { "name": "arg1", @@ -17636,7 +17637,7 @@ "meta-type": "object" }, { - "name": "572", + "name": "574", "members": [ { "name": "core", @@ -17652,18 +17653,18 @@ }, { "name": "reason", - "type": "709" + "type": "711" } ], "meta-type": "object" }, { - "name": "[573]", - "element-type": "573", + "name": "[575]", + "element-type": "575", "meta-type": "array" }, { - "name": "573", + "name": "575", "members": [ { "name": "interval_length", @@ -17733,7 +17734,7 @@ "meta-type": "object" }, { - "name": "574", + "name": "576", "members": [ { "name": "boundaries", @@ -17747,7 +17748,7 @@ "meta-type": "object" }, { - "name": "575", + "name": "577", "members": [ { "name": "discard-nb-ok", @@ -17765,7 +17766,7 @@ "meta-type": "object" }, { - "name": "576", + "name": "578", "members": [ { "name": "completion-errors", @@ -17788,40 +17789,40 @@ "meta-type": "array" }, { - "name": "577", + "name": "579", "tag": "type", "variants": [ { "case": "qcow2", - "type": "711" + "type": "713" }, { "case": "vmdk", - "type": "712" + "type": "714" }, { "case": "luks", - "type": "713" + "type": "715" }, { "case": "rbd", - "type": "714" + "type": "716" }, { "case": "file", - "type": "715" + "type": "717" } ], "members": [ { "name": "type", - "type": "710" + "type": "712" } ], "meta-type": "object" }, { - "name": "578", + "name": "580", "members": [ { "name": "block-backend" @@ -17841,12 +17842,12 @@ ] }, { - "name": "[579]", - "element-type": "579", + "name": "[581]", + "element-type": "581", "meta-type": "array" }, { - "name": "579", + "name": "581", "members": [ { "name": "consistent-read" @@ -17870,7 +17871,7 @@ ] }, { - "name": "580", + "name": "582", "members": [ { "type": "58" @@ -17882,16 +17883,16 @@ "meta-type": "alternate" }, { - "name": "[581]", - "element-type": "581", + "name": "[583]", + "element-type": "583", "meta-type": "array" }, { - "name": "581", + "name": "583", "members": [ { "name": "event", - "type": "716" + "type": "718" }, { "name": "state", @@ -17901,7 +17902,7 @@ { "name": "iotype", "default": null, - "type": "717" + "type": "719" }, { "name": "errno", @@ -17927,16 +17928,16 @@ "meta-type": "object" }, { - "name": "[582]", - "element-type": "582", + "name": "[584]", + "element-type": "584", "meta-type": "array" }, { - "name": "582", + "name": "584", "members": [ { "name": "event", - "type": "716" + "type": "718" }, { "name": "state", @@ -17951,7 +17952,7 @@ "meta-type": "object" }, { - "name": "583", + "name": "585", "members": [ { "name": "break-guest-write" @@ -17967,7 +17968,7 @@ ] }, { - "name": "584", + "name": "586", "members": [ { "name": "auto" @@ -17987,7 +17988,7 @@ ] }, { - "name": "585", + "name": "587", "members": [ { "name": "threads" @@ -18007,7 +18008,7 @@ ] }, { - "name": "586", + "name": "588", "members": [ { "name": "tcp" @@ -18023,7 +18024,7 @@ ] }, { - "name": "587", + "name": "589", "members": [ { "name": "crc32c" @@ -18047,11 +18048,11 @@ ] }, { - "name": "588", + "name": "590", "members": [ { "name": "type", - "type": "718" + "type": "720" }, { "name": "host", @@ -18061,7 +18062,7 @@ "meta-type": "object" }, { - "name": "589", + "name": "591", "members": [ { "type": "58" @@ -18076,62 +18077,62 @@ "meta-type": "alternate" }, { - "name": "590", + "name": "592", "members": [ { - "type": "719" + "type": "721" }, { - "type": "720" + "type": "722" } ], "meta-type": "alternate" }, { - "name": "591", + "name": "593", "tag": "format", "variants": [ { "case": "aes", - "type": "722" + "type": "724" }, { "case": "luks", - "type": "723" + "type": "725" } ], "members": [ { "name": "format", - "type": "721" + "type": "723" } ], "meta-type": "object" }, { - "name": "592", + "name": "594", "tag": "format", "variants": [ { "case": "aes", - "type": "722" + "type": "724" } ], "members": [ { "name": "format", - "type": "724" + "type": "726" } ], "meta-type": "object" }, { - "name": "[580]", - "element-type": "580", + "name": "[582]", + "element-type": "582", "meta-type": "array" }, { - "name": "593", + "name": "595", "members": [ { "name": "quorum" @@ -18147,42 +18148,42 @@ ] }, { - "name": "594", + "name": "596", "tag": "format", "variants": [ { "case": "luks", - "type": "726" + "type": "728" }, { "case": "luks2", - "type": "727" + "type": "729" }, { "case": "luks-any", - "type": "728" + "type": "730" } ], "members": [ { "name": "format", - "type": "725" + "type": "727" }, { "name": "parent", "default": null, - "type": "594" + "type": "596" } ], "meta-type": "object" }, { - "name": "[595]", - "element-type": "595", + "name": "[597]", + "element-type": "597", "meta-type": "array" }, { - "name": "595", + "name": "597", "members": [ { "name": "cephx" @@ -18198,12 +18199,12 @@ ] }, { - "name": "[596]", - "element-type": "596", + "name": "[598]", + "element-type": "598", "meta-type": "array" }, { - "name": "596", + "name": "598", "members": [ { "name": "host", @@ -18217,7 +18218,7 @@ "meta-type": "object" }, { - "name": "597", + "name": "599", "members": [ { "name": "primary" @@ -18233,7 +18234,7 @@ ] }, { - "name": "598", + "name": "600", "members": [ { "name": "host", @@ -18277,12 +18278,12 @@ "meta-type": "object" }, { - "name": "599", + "name": "601", "tag": "mode", "variants": [ { "case": "hash", - "type": "730" + "type": "732" }, { "case": "none", @@ -18296,13 +18297,13 @@ "members": [ { "name": "mode", - "type": "729" + "type": "731" } ], "meta-type": "object" }, { - "name": "600", + "name": "602", "members": [ { "name": "filename", @@ -18315,7 +18316,7 @@ { "name": "preallocation", "default": null, - "type": "731" + "type": "733" }, { "name": "nocow", @@ -18331,11 +18332,11 @@ "meta-type": "object" }, { - "name": "601", + "name": "603", "members": [ { "name": "location", - "type": "329" + "type": "330" }, { "name": "size", @@ -18344,13 +18345,13 @@ { "name": "preallocation", "default": null, - "type": "731" + "type": "733" } ], "meta-type": "object" }, { - "name": "602", + "name": "604", "members": [ { "name": "key-secret", @@ -18360,27 +18361,27 @@ { "name": "cipher-alg", "default": null, - "type": "732" + "type": "734" }, { "name": "cipher-mode", "default": null, - "type": "733" + "type": "735" }, { "name": "ivgen-alg", "default": null, - "type": "734" + "type": "736" }, { "name": "ivgen-hash-alg", "default": null, - "type": "735" + "type": "737" }, { "name": "hash-alg", "default": null, - "type": "735" + "type": "737" }, { "name": "iter-time", @@ -18390,12 +18391,12 @@ { "name": "file", "default": null, - "type": "580" + "type": "582" }, { "name": "header", "default": null, - "type": "580" + "type": "582" }, { "name": "size", @@ -18404,17 +18405,17 @@ { "name": "preallocation", "default": null, - "type": "731" + "type": "733" } ], "meta-type": "object" }, { - "name": "603", + "name": "605", "members": [ { "name": "location", - "type": "336" + "type": "337" }, { "name": "size", @@ -18424,11 +18425,11 @@ "meta-type": "object" }, { - "name": "604", + "name": "606", "members": [ { "name": "file", - "type": "580" + "type": "582" }, { "name": "size", @@ -18443,11 +18444,11 @@ "meta-type": "object" }, { - "name": "605", + "name": "607", "members": [ { "name": "file", - "type": "580" + "type": "582" }, { "name": "size", @@ -18461,22 +18462,22 @@ { "name": "encrypt", "default": null, - "type": "736" + "type": "738" } ], "meta-type": "object" }, { - "name": "606", + "name": "608", "members": [ { "name": "file", - "type": "580" + "type": "582" }, { "name": "data-file", "default": null, - "type": "580" + "type": "582" }, { "name": "data-file-raw", @@ -18495,7 +18496,7 @@ { "name": "version", "default": null, - "type": "737" + "type": "739" }, { "name": "backing-file", @@ -18505,12 +18506,12 @@ { "name": "backing-fmt", "default": null, - "type": "316" + "type": "317" }, { "name": "encrypt", "default": null, - "type": "736" + "type": "738" }, { "name": "cluster-size", @@ -18520,7 +18521,7 @@ { "name": "preallocation", "default": null, - "type": "731" + "type": "733" }, { "name": "lazy-refcounts", @@ -18535,17 +18536,17 @@ { "name": "compression-type", "default": null, - "type": "738" + "type": "740" } ], "meta-type": "object" }, { - "name": "607", + "name": "609", "members": [ { "name": "file", - "type": "580" + "type": "582" }, { "name": "size", @@ -18559,7 +18560,7 @@ { "name": "backing-fmt", "default": null, - "type": "316" + "type": "317" }, { "name": "cluster-size", @@ -18575,11 +18576,11 @@ "meta-type": "object" }, { - "name": "608", + "name": "610", "members": [ { "name": "location", - "type": "346" + "type": "347" }, { "name": "size", @@ -18593,17 +18594,17 @@ { "name": "encrypt", "default": null, - "type": "739" + "type": "741" } ], "meta-type": "object" }, { - "name": "609", + "name": "611", "members": [ { "name": "location", - "type": "348" + "type": "349" }, { "name": "size", @@ -18613,11 +18614,11 @@ "meta-type": "object" }, { - "name": "610", + "name": "612", "members": [ { "name": "file", - "type": "580" + "type": "582" }, { "name": "size", @@ -18626,17 +18627,17 @@ { "name": "preallocation", "default": null, - "type": "731" + "type": "733" } ], "meta-type": "object" }, { - "name": "611", + "name": "613", "members": [ { "name": "file", - "type": "580" + "type": "582" }, { "name": "size", @@ -18655,7 +18656,7 @@ { "name": "subformat", "default": null, - "type": "740" + "type": "742" }, { "name": "block-state-zero", @@ -18666,11 +18667,11 @@ "meta-type": "object" }, { - "name": "612", + "name": "614", "members": [ { "name": "file", - "type": "580" + "type": "582" }, { "name": "size", @@ -18679,12 +18680,12 @@ { "name": "extents", "default": null, - "type": "[580]" + "type": "[582]" }, { "name": "subformat", "default": null, - "type": "741" + "type": "743" }, { "name": "backing-file", @@ -18694,7 +18695,7 @@ { "name": "adapter-type", "default": null, - "type": "742" + "type": "744" }, { "name": "hwversion", @@ -18715,11 +18716,11 @@ "meta-type": "object" }, { - "name": "613", + "name": "615", "members": [ { "name": "file", - "type": "580" + "type": "582" }, { "name": "size", @@ -18728,7 +18729,7 @@ { "name": "subformat", "default": null, - "type": "743" + "type": "745" }, { "name": "force-size", @@ -18739,11 +18740,11 @@ "meta-type": "object" }, { - "name": "614", + "name": "616", "members": [ { "name": "state", - "type": "744" + "type": "746" }, { "name": "new-secret", @@ -18774,12 +18775,12 @@ "meta-type": "object" }, { - "name": "615", + "name": "617", "members": [ { "name": "encrypt", "default": null, - "type": "745" + "type": "747" } ], "meta-type": "object" @@ -18790,7 +18791,7 @@ "meta-type": "builtin" }, { - "name": "616", + "name": "618", "members": [ { "name": "inet" @@ -18814,47 +18815,47 @@ ] }, { - "name": "617", + "name": "619", "members": [ { "name": "data", - "type": "598" + "type": "600" } ], "meta-type": "object" }, { - "name": "618", + "name": "620", "members": [ { "name": "data", - "type": "639" + "type": "641" } ], "meta-type": "object" }, { - "name": "619", + "name": "621", "members": [ { "name": "data", - "type": "640" + "type": "642" } ], "meta-type": "object" }, { - "name": "620", + "name": "622", "members": [ { "name": "data", - "type": "641" + "type": "643" } ], "meta-type": "object" }, { - "name": "621", + "name": "623", "members": [ { "name": "off" @@ -18874,7 +18875,7 @@ ] }, { - "name": "622", + "name": "624", "members": [ { "name": "file" @@ -18957,122 +18958,122 @@ ] }, { - "name": "623", + "name": "625", "members": [ { "name": "data", - "type": "746" + "type": "748" } ], "meta-type": "object" }, { - "name": "624", + "name": "626", "members": [ { "name": "data", - "type": "747" + "type": "749" } ], "meta-type": "object" }, { - "name": "625", + "name": "627", "members": [ { "name": "data", - "type": "748" + "type": "750" } ], "meta-type": "object" }, { - "name": "626", + "name": "628", "members": [ { "name": "data", - "type": "749" + "type": "751" } ], "meta-type": "object" }, { - "name": "627", + "name": "629", "members": [ { "name": "data", - "type": "750" + "type": "752" } ], "meta-type": "object" }, { - "name": "628", + "name": "630", "members": [ { "name": "data", - "type": "751" + "type": "753" } ], "meta-type": "object" }, { - "name": "629", + "name": "631", "members": [ { "name": "data", - "type": "752" + "type": "754" } ], "meta-type": "object" }, { - "name": "630", + "name": "632", "members": [ { "name": "data", - "type": "753" + "type": "755" } ], "meta-type": "object" }, { - "name": "634", + "name": "636", "members": [ { "name": "data", - "type": "757" + "type": "759" } ], "meta-type": "object" }, { - "name": "635", + "name": "637", "members": [ { "name": "data", - "type": "758" + "type": "760" } ], "meta-type": "object" }, { - "name": "636", + "name": "638", "members": [ { "name": "data", - "type": "759" + "type": "761" } ], "meta-type": "object" }, { - "name": "[637]", - "element-type": "637", + "name": "[639]", + "element-type": "639", "meta-type": "array" }, { - "name": "637", + "name": "639", "members": [ { "name": "str", @@ -19082,7 +19083,7 @@ "meta-type": "object" }, { - "name": "638", + "name": "640", "members": [ { "name": "native" @@ -19098,7 +19099,7 @@ ] }, { - "name": "639", + "name": "641", "members": [ { "name": "path", @@ -19118,7 +19119,7 @@ "meta-type": "object" }, { - "name": "640", + "name": "642", "members": [ { "name": "cid", @@ -19132,7 +19133,7 @@ "meta-type": "object" }, { - "name": "641", + "name": "643", "members": [ { "name": "str", @@ -19142,27 +19143,27 @@ "meta-type": "object" }, { - "name": "642", + "name": "644", "members": [ { "name": "data", - "type": "760" + "type": "762" } ], "meta-type": "object" }, { - "name": "643", + "name": "645", "members": [ { "name": "data", - "type": "761" + "type": "763" } ], "meta-type": "object" }, { - "name": "644", + "name": "646", "members": [ { "name": "number" @@ -19178,7 +19179,7 @@ ] }, { - "name": "645", + "name": "647", "members": [ { "name": "data", @@ -19188,17 +19189,17 @@ "meta-type": "object" }, { - "name": "646", + "name": "648", "members": [ { "name": "data", - "type": "762" + "type": "764" } ], "meta-type": "object" }, { - "name": "647", + "name": "649", "members": [ { "name": "key" @@ -19226,47 +19227,47 @@ ] }, { - "name": "648", + "name": "650", "members": [ { "name": "data", - "type": "763" + "type": "765" } ], "meta-type": "object" }, { - "name": "649", + "name": "651", "members": [ { "name": "data", - "type": "764" + "type": "766" } ], "meta-type": "object" }, { - "name": "650", + "name": "652", "members": [ { "name": "data", - "type": "765" + "type": "767" } ], "meta-type": "object" }, { - "name": "651", + "name": "653", "members": [ { "name": "data", - "type": "766" + "type": "768" } ], "meta-type": "object" }, { - "name": "652", + "name": "654", "members": [ { "name": "lctrl-lalt" @@ -19291,12 +19292,12 @@ "meta-type": "builtin" }, { - "name": "[653]", - "element-type": "653", + "name": "[655]", + "element-type": "655", "meta-type": "array" }, { - "name": "653", + "name": "655", "members": [ { "name": "name", @@ -19309,13 +19310,13 @@ { "name": "transform", "default": null, - "type": "767" + "type": "769" } ], "meta-type": "object" }, { - "name": "654", + "name": "656", "members": [ { "name": "main" @@ -19327,36 +19328,36 @@ ] }, { - "name": "655", + "name": "657", "tag": "transport", "variants": [ { "case": "socket", - "type": "390" + "type": "391" }, { "case": "exec", - "type": "769" + "type": "771" }, { "case": "rdma", - "type": "598" + "type": "600" }, { "case": "file", - "type": "770" + "type": "772" } ], "members": [ { "name": "transport", - "type": "768" + "type": "770" } ], "meta-type": "object" }, { - "name": "656", + "name": "658", "members": [ { "name": "abort" @@ -19415,17 +19416,17 @@ ] }, { - "name": "657", + "name": "659", "members": [ { "name": "data", - "type": "771" + "type": "773" } ], "meta-type": "object" }, { - "name": "658", + "name": "660", "members": [ { "name": "data", @@ -19435,7 +19436,7 @@ "meta-type": "object" }, { - "name": "659", + "name": "661", "members": [ { "name": "data", @@ -19445,7 +19446,7 @@ "meta-type": "object" }, { - "name": "660", + "name": "662", "members": [ { "name": "data", @@ -19455,7 +19456,7 @@ "meta-type": "object" }, { - "name": "661", + "name": "663", "members": [ { "name": "data", @@ -19465,7 +19466,7 @@ "meta-type": "object" }, { - "name": "662", + "name": "664", "members": [ { "name": "data", @@ -19475,7 +19476,7 @@ "meta-type": "object" }, { - "name": "663", + "name": "665", "members": [ { "name": "data", @@ -19485,7 +19486,7 @@ "meta-type": "object" }, { - "name": "664", + "name": "666", "members": [ { "name": "data", @@ -19495,7 +19496,7 @@ "meta-type": "object" }, { - "name": "665", + "name": "667", "members": [ { "name": "data", @@ -19505,7 +19506,7 @@ "meta-type": "object" }, { - "name": "666", + "name": "668", "members": [ { "name": "individual" @@ -19521,7 +19522,7 @@ ] }, { - "name": "667", + "name": "669", "members": [ { "name": "string" @@ -19561,12 +19562,12 @@ ] }, { - "name": "[668]", - "element-type": "668", + "name": "[670]", + "element-type": "670", "meta-type": "array" }, { - "name": "668", + "name": "670", "members": [ { "name": "name", @@ -19581,12 +19582,12 @@ "meta-type": "object" }, { - "name": "[669]", - "element-type": "669", + "name": "[671]", + "element-type": "671", "meta-type": "array" }, { - "name": "669", + "name": "671", "members": [ { "name": "name", @@ -19610,12 +19611,12 @@ "meta-type": "object" }, { - "name": "[670]", - "element-type": "670", + "name": "[672]", + "element-type": "672", "meta-type": "array" }, { - "name": "670", + "name": "672", "members": [ { "name": "case", @@ -19629,12 +19630,12 @@ "meta-type": "object" }, { - "name": "[671]", - "element-type": "671", + "name": "[673]", + "element-type": "673", "meta-type": "array" }, { - "name": "671", + "name": "673", "members": [ { "name": "type", @@ -19644,7 +19645,7 @@ "meta-type": "object" }, { - "name": "672", + "name": "674", "members": [ { "name": "deny" @@ -19660,12 +19661,12 @@ ] }, { - "name": "[673]", - "element-type": "673", + "name": "[675]", + "element-type": "675", "meta-type": "array" }, { - "name": "673", + "name": "675", "members": [ { "name": "match", @@ -19673,18 +19674,18 @@ }, { "name": "policy", - "type": "672" + "type": "674" }, { "name": "format", "default": null, - "type": "772" + "type": "774" } ], "meta-type": "object" }, { - "name": "674", + "name": "676", "members": [ { "name": "all" @@ -19704,7 +19705,7 @@ ] }, { - "name": "675", + "name": "677", "members": [ { "name": "before" @@ -19720,7 +19721,7 @@ ] }, { - "name": "676", + "name": "678", "members": [ { "name": "ctrl-ctrl" @@ -19752,7 +19753,7 @@ ] }, { - "name": "677", + "name": "679", "members": [ { "name": "raw" @@ -19768,7 +19769,7 @@ ] }, { - "name": "678", + "name": "680", "members": [ { "name": "iops-total", @@ -19869,7 +19870,7 @@ "meta-type": "object" }, { - "name": "679", + "name": "681", "members": [ { "name": "client" @@ -19885,7 +19886,7 @@ ] }, { - "name": "680", + "name": "682", "members": [ { "name": "uninitialized" @@ -19913,7 +19914,7 @@ ] }, { - "name": "681", + "name": "683", "members": [ { "name": "memory" @@ -19937,7 +19938,7 @@ ] }, { - "name": "682", + "name": "684", "members": [ { "name": "access-latency" @@ -19969,7 +19970,7 @@ ] }, { - "name": "683", + "name": "685", "members": [ { "name": "none" @@ -19989,7 +19990,7 @@ ] }, { - "name": "684", + "name": "686", "members": [ { "name": "none" @@ -20009,7 +20010,7 @@ ] }, { - "name": "685", + "name": "687", "members": [ { "name": "id", @@ -20048,7 +20049,7 @@ "meta-type": "object" }, { - "name": "686", + "name": "688", "members": [ { "name": "id", @@ -20071,7 +20072,7 @@ "meta-type": "object" }, { - "name": "687", + "name": "689", "members": [ { "name": "id", @@ -20110,7 +20111,7 @@ "meta-type": "object" }, { - "name": "688", + "name": "690", "members": [ { "name": "id", @@ -20137,7 +20138,7 @@ "meta-type": "object" }, { - "name": "689", + "name": "691", "members": [ { "name": "id", @@ -20162,7 +20163,7 @@ "meta-type": "object" }, { - "name": "690", + "name": "692", "members": [ { "name": "string" @@ -20186,7 +20187,7 @@ ] }, { - "name": "691", + "name": "693", "members": [ { "name": "mixing-engine", @@ -20216,7 +20217,7 @@ { "name": "format", "default": null, - "type": "773" + "type": "775" }, { "name": "buffer-length", @@ -20227,7 +20228,7 @@ "meta-type": "object" }, { - "name": "692", + "name": "694", "members": [ { "name": "mixing-engine", @@ -20257,7 +20258,7 @@ { "name": "format", "default": null, - "type": "773" + "type": "775" }, { "name": "buffer-length", @@ -20283,7 +20284,7 @@ "meta-type": "object" }, { - "name": "693", + "name": "695", "members": [ { "name": "mixing-engine", @@ -20313,7 +20314,7 @@ { "name": "format", "default": null, - "type": "773" + "type": "775" }, { "name": "buffer-length", @@ -20329,7 +20330,7 @@ "meta-type": "object" }, { - "name": "694", + "name": "696", "members": [ { "name": "mixing-engine", @@ -20359,7 +20360,7 @@ { "name": "format", "default": null, - "type": "773" + "type": "775" }, { "name": "buffer-length", @@ -20395,7 +20396,7 @@ "meta-type": "object" }, { - "name": "695", + "name": "697", "members": [ { "name": "mixing-engine", @@ -20425,7 +20426,7 @@ { "name": "format", "default": null, - "type": "773" + "type": "775" }, { "name": "buffer-length", @@ -20451,7 +20452,7 @@ "meta-type": "object" }, { - "name": "696", + "name": "698", "members": [ { "name": "mixing-engine", @@ -20481,7 +20482,7 @@ { "name": "format", "default": null, - "type": "773" + "type": "775" }, { "name": "buffer-length", @@ -20507,7 +20508,7 @@ "meta-type": "object" }, { - "name": "697", + "name": "699", "members": [ { "name": "mixing-engine", @@ -20537,7 +20538,7 @@ { "name": "format", "default": null, - "type": "773" + "type": "775" }, { "name": "buffer-length", @@ -20563,7 +20564,7 @@ "meta-type": "object" }, { - "name": "698", + "name": "700", "members": [ { "name": "mixing-engine", @@ -20593,7 +20594,7 @@ { "name": "format", "default": null, - "type": "773" + "type": "775" }, { "name": "buffer-length", @@ -20609,7 +20610,7 @@ "meta-type": "object" }, { - "name": "699", + "name": "701", "members": [ { "name": "desc", @@ -20624,7 +20625,7 @@ "meta-type": "object" }, { - "name": "700", + "name": "702", "members": [ { "name": "device", @@ -20648,27 +20649,27 @@ "meta-type": "object" }, { - "name": "701", + "name": "703", "members": [ { "name": "bus", - "type": "774" + "type": "776" }, { "name": "devices", "default": null, - "type": "[548]" + "type": "[550]" } ], "meta-type": "object" }, { - "name": "[702]", - "element-type": "702", + "name": "[704]", + "element-type": "704", "meta-type": "array" }, { - "name": "702", + "name": "704", "members": [ { "name": "bar", @@ -20700,7 +20701,7 @@ "meta-type": "object" }, { - "name": "703", + "name": "705", "members": [ { "type": "int" @@ -20715,7 +20716,7 @@ "meta-type": "alternate" }, { - "name": "704", + "name": "706", "members": [ { "name": "cumulative" @@ -20743,7 +20744,7 @@ ] }, { - "name": "705", + "name": "707", "members": [ { "name": "bytes" @@ -20767,7 +20768,7 @@ ] }, { - "name": "706", + "name": "708", "members": [ { "name": "protocols", @@ -20782,7 +20783,7 @@ "meta-type": "object" }, { - "name": "707", + "name": "709", "members": [ { "name": "builtin" @@ -20802,7 +20803,7 @@ ] }, { - "name": "708", + "name": "710", "members": [ { "name": "cache-data-parity" @@ -20870,7 +20871,7 @@ ] }, { - "name": "709", + "name": "711", "members": [ { "name": "unknown" @@ -20898,7 +20899,7 @@ ] }, { - "name": "710", + "name": "712", "members": [ { "name": "qcow2" @@ -20926,57 +20927,57 @@ ] }, { - "name": "711", + "name": "713", "members": [ { "name": "data", - "type": "775" + "type": "777" } ], "meta-type": "object" }, { - "name": "712", + "name": "714", "members": [ { "name": "data", - "type": "776" + "type": "778" } ], "meta-type": "object" }, { - "name": "713", + "name": "715", "members": [ { "name": "data", - "type": "777" + "type": "779" } ], "meta-type": "object" }, { - "name": "714", + "name": "716", "members": [ { "name": "data", - "type": "778" + "type": "780" } ], "meta-type": "object" }, { - "name": "715", + "name": "717", "members": [ { "name": "data", - "type": "779" + "type": "781" } ], "meta-type": "object" }, { - "name": "716", + "name": "718", "members": [ { "name": "l1_update" @@ -21176,7 +21177,7 @@ ] }, { - "name": "717", + "name": "719", "members": [ { "name": "read" @@ -21208,7 +21209,7 @@ ] }, { - "name": "718", + "name": "720", "members": [ { "name": "inet" @@ -21220,12 +21221,12 @@ ] }, { - "name": "719", + "name": "721", "members": [ { "name": "template", "default": null, - "type": "720" + "type": "722" }, { "name": "main-header", @@ -21276,7 +21277,7 @@ "meta-type": "object" }, { - "name": "720", + "name": "722", "members": [ { "name": "none" @@ -21300,7 +21301,7 @@ ] }, { - "name": "721", + "name": "723", "members": [ { "name": "aes" @@ -21316,7 +21317,7 @@ ] }, { - "name": "722", + "name": "724", "members": [ { "name": "key-secret", @@ -21327,7 +21328,7 @@ "meta-type": "object" }, { - "name": "723", + "name": "725", "members": [ { "name": "key-secret", @@ -21338,7 +21339,7 @@ "meta-type": "object" }, { - "name": "724", + "name": "726", "members": [ { "name": "aes" @@ -21350,7 +21351,7 @@ ] }, { - "name": "725", + "name": "727", "members": [ { "name": "luks" @@ -21370,7 +21371,7 @@ ] }, { - "name": "726", + "name": "728", "members": [ { "name": "key-secret", @@ -21380,7 +21381,7 @@ "meta-type": "object" }, { - "name": "727", + "name": "729", "members": [ { "name": "key-secret", @@ -21390,7 +21391,7 @@ "meta-type": "object" }, { - "name": "728", + "name": "730", "members": [ { "name": "key-secret", @@ -21400,7 +21401,7 @@ "meta-type": "object" }, { - "name": "729", + "name": "731", "members": [ { "name": "none" @@ -21420,11 +21421,11 @@ ] }, { - "name": "730", + "name": "732", "members": [ { "name": "type", - "type": "780" + "type": "782" }, { "name": "hash", @@ -21434,7 +21435,7 @@ "meta-type": "object" }, { - "name": "731", + "name": "733", "members": [ { "name": "off" @@ -21458,7 +21459,7 @@ ] }, { - "name": "732", + "name": "734", "members": [ { "name": "aes-128" @@ -21518,7 +21519,7 @@ ] }, { - "name": "733", + "name": "735", "members": [ { "name": "ecb" @@ -21542,7 +21543,7 @@ ] }, { - "name": "734", + "name": "736", "members": [ { "name": "plain" @@ -21562,7 +21563,7 @@ ] }, { - "name": "735", + "name": "737", "members": [ { "name": "md5" @@ -21584,6 +21585,9 @@ }, { "name": "ripemd160" + }, + { + "name": "sm3" } ], "meta-type": "enum", @@ -21594,32 +21598,33 @@ "sha256", "sha384", "sha512", - "ripemd160" + "ripemd160", + "sm3" ] }, { - "name": "736", + "name": "738", "tag": "format", "variants": [ { "case": "qcow", - "type": "722" + "type": "724" }, { "case": "luks", - "type": "782" + "type": "784" } ], "members": [ { "name": "format", - "type": "781" + "type": "783" } ], "meta-type": "object" }, { - "name": "737", + "name": "739", "members": [ { "name": "v2" @@ -21635,7 +21640,7 @@ ] }, { - "name": "738", + "name": "740", "members": [ { "name": "zlib" @@ -21651,16 +21656,16 @@ ] }, { - "name": "739", + "name": "741", "tag": "format", "variants": [ { "case": "luks", - "type": "783" + "type": "785" }, { "case": "luks2", - "type": "784" + "type": "786" }, { "case": "luks-any", @@ -21670,13 +21675,13 @@ "members": [ { "name": "format", - "type": "725" + "type": "727" } ], "meta-type": "object" }, { - "name": "740", + "name": "742", "members": [ { "name": "dynamic" @@ -21692,7 +21697,7 @@ ] }, { - "name": "741", + "name": "743", "members": [ { "name": "monolithicSparse" @@ -21720,7 +21725,7 @@ ] }, { - "name": "742", + "name": "744", "members": [ { "name": "ide" @@ -21744,7 +21749,7 @@ ] }, { - "name": "743", + "name": "745", "members": [ { "name": "dynamic" @@ -21760,7 +21765,7 @@ ] }, { - "name": "744", + "name": "746", "members": [ { "name": "active" @@ -21776,12 +21781,12 @@ ] }, { - "name": "745", + "name": "747", "tag": "format", "variants": [ { "case": "luks", - "type": "785" + "type": "787" }, { "case": "qcow", @@ -21791,13 +21796,13 @@ "members": [ { "name": "format", - "type": "781" + "type": "783" } ], "meta-type": "object" }, { - "name": "746", + "name": "748", "members": [ { "name": "logfile", @@ -21827,7 +21832,7 @@ "meta-type": "object" }, { - "name": "747", + "name": "749", "members": [ { "name": "logfile", @@ -21847,7 +21852,7 @@ "meta-type": "object" }, { - "name": "748", + "name": "750", "members": [ { "name": "logfile", @@ -21861,7 +21866,7 @@ }, { "name": "addr", - "type": "360" + "type": "361" }, { "name": "tls-creds", @@ -21920,7 +21925,7 @@ "meta-type": "object" }, { - "name": "749", + "name": "751", "members": [ { "name": "logfile", @@ -21934,18 +21939,18 @@ }, { "name": "remote", - "type": "360" + "type": "361" }, { "name": "local", "default": null, - "type": "360" + "type": "361" } ], "meta-type": "object" }, { - "name": "750", + "name": "752", "members": [ { "name": "logfile", @@ -21966,7 +21971,7 @@ "meta-type": "object" }, { - "name": "751", + "name": "753", "members": [ { "name": "logfile", @@ -21982,7 +21987,7 @@ "meta-type": "object" }, { - "name": "752", + "name": "754", "members": [ { "name": "logfile", @@ -22002,7 +22007,7 @@ "meta-type": "object" }, { - "name": "753", + "name": "755", "members": [ { "name": "logfile", @@ -22023,7 +22028,7 @@ "meta-type": "object" }, { - "name": "757", + "name": "759", "members": [ { "name": "logfile", @@ -22043,7 +22048,7 @@ "meta-type": "object" }, { - "name": "758", + "name": "760", "members": [ { "name": "logfile", @@ -22079,7 +22084,7 @@ "meta-type": "object" }, { - "name": "759", + "name": "761", "members": [ { "name": "logfile", @@ -22100,7 +22105,7 @@ "meta-type": "object" }, { - "name": "760", + "name": "762", "members": [ { "name": "path", @@ -22116,7 +22121,7 @@ "meta-type": "object" }, { - "name": "761", + "name": "763", "members": [ { "name": "chardev", @@ -22126,7 +22131,7 @@ "meta-type": "object" }, { - "name": "762", + "name": "764", "members": [ { "name": "unmapped" @@ -22782,11 +22787,11 @@ ] }, { - "name": "763", + "name": "765", "members": [ { "name": "key", - "type": "414" + "type": "415" }, { "name": "down", @@ -22796,11 +22801,11 @@ "meta-type": "object" }, { - "name": "764", + "name": "766", "members": [ { "name": "button", - "type": "786" + "type": "788" }, { "name": "down", @@ -22810,11 +22815,11 @@ "meta-type": "object" }, { - "name": "765", + "name": "767", "members": [ { "name": "axis", - "type": "787" + "type": "789" }, { "name": "value", @@ -22824,11 +22829,11 @@ "meta-type": "object" }, { - "name": "766", + "name": "768", "members": [ { "name": "type", - "type": "788" + "type": "790" }, { "name": "slot", @@ -22840,7 +22845,7 @@ }, { "name": "axis", - "type": "787" + "type": "789" }, { "name": "value", @@ -22850,7 +22855,7 @@ "meta-type": "object" }, { - "name": "767", + "name": "769", "members": [ { "name": "persistent", @@ -22861,7 +22866,7 @@ "meta-type": "object" }, { - "name": "768", + "name": "770", "members": [ { "name": "socket" @@ -22885,7 +22890,7 @@ ] }, { - "name": "769", + "name": "771", "members": [ { "name": "args", @@ -22895,7 +22900,7 @@ "meta-type": "object" }, { - "name": "770", + "name": "772", "members": [ { "name": "filename", @@ -22909,12 +22914,12 @@ "meta-type": "object" }, { - "name": "771", + "name": "773", "members": [], "meta-type": "object" }, { - "name": "772", + "name": "774", "members": [ { "name": "exact" @@ -22930,7 +22935,7 @@ ] }, { - "name": "773", + "name": "775", "members": [ { "name": "u8" @@ -22966,7 +22971,7 @@ ] }, { - "name": "774", + "name": "776", "members": [ { "name": "number", @@ -22982,21 +22987,21 @@ }, { "name": "io_range", - "type": "789" + "type": "791" }, { "name": "memory_range", - "type": "789" + "type": "791" }, { "name": "prefetchable_range", - "type": "789" + "type": "791" } ], "meta-type": "object" }, { - "name": "775", + "name": "777", "members": [ { "name": "compat", @@ -23034,22 +23039,22 @@ { "name": "encrypt", "default": null, - "type": "790" + "type": "792" }, { "name": "bitmaps", "default": null, - "type": "[791]" + "type": "[793]" }, { "name": "compression-type", - "type": "738" + "type": "740" } ], "meta-type": "object" }, { - "name": "776", + "name": "778", "members": [ { "name": "create-type", @@ -23065,34 +23070,34 @@ }, { "name": "extents", - "type": "[792]" + "type": "[794]" } ], "meta-type": "object" }, { - "name": "777", + "name": "779", "members": [ { "name": "cipher-alg", - "type": "732" + "type": "734" }, { "name": "cipher-mode", - "type": "733" + "type": "735" }, { "name": "ivgen-alg", - "type": "734" + "type": "736" }, { "name": "ivgen-hash-alg", "default": null, - "type": "735" + "type": "737" }, { "name": "hash-alg", - "type": "735" + "type": "737" }, { "name": "detached-header", @@ -23112,24 +23117,24 @@ }, { "name": "slots", - "type": "[793]" + "type": "[795]" } ], "meta-type": "object" }, { - "name": "778", + "name": "780", "members": [ { "name": "encryption-format", "default": null, - "type": "725" + "type": "727" } ], "meta-type": "object" }, { - "name": "779", + "name": "781", "members": [ { "name": "extent-size-hint", @@ -23140,7 +23145,7 @@ "meta-type": "object" }, { - "name": "780", + "name": "782", "members": [ { "name": "md5" @@ -23160,7 +23165,7 @@ ] }, { - "name": "781", + "name": "783", "members": [ { "name": "qcow" @@ -23176,7 +23181,7 @@ ] }, { - "name": "782", + "name": "784", "members": [ { "name": "key-secret", @@ -23186,27 +23191,27 @@ { "name": "cipher-alg", "default": null, - "type": "732" + "type": "734" }, { "name": "cipher-mode", "default": null, - "type": "733" + "type": "735" }, { "name": "ivgen-alg", "default": null, - "type": "734" + "type": "736" }, { "name": "ivgen-hash-alg", "default": null, - "type": "735" + "type": "737" }, { "name": "hash-alg", "default": null, - "type": "735" + "type": "737" }, { "name": "iter-time", @@ -23217,7 +23222,7 @@ "meta-type": "object" }, { - "name": "783", + "name": "785", "members": [ { "name": "key-secret", @@ -23226,13 +23231,13 @@ { "name": "cipher-alg", "default": null, - "type": "732" + "type": "734" } ], "meta-type": "object" }, { - "name": "784", + "name": "786", "members": [ { "name": "key-secret", @@ -23241,17 +23246,17 @@ { "name": "cipher-alg", "default": null, - "type": "732" + "type": "734" } ], "meta-type": "object" }, { - "name": "785", + "name": "787", "members": [ { "name": "state", - "type": "744" + "type": "746" }, { "name": "new-secret", @@ -23282,7 +23287,7 @@ "meta-type": "object" }, { - "name": "786", + "name": "788", "members": [ { "name": "left" @@ -23330,7 +23335,7 @@ ] }, { - "name": "787", + "name": "789", "members": [ { "name": "x" @@ -23346,7 +23351,7 @@ ] }, { - "name": "788", + "name": "790", "members": [ { "name": "begin" @@ -23374,7 +23379,7 @@ ] }, { - "name": "789", + "name": "791", "members": [ { "name": "base", @@ -23388,12 +23393,12 @@ "meta-type": "object" }, { - "name": "790", + "name": "792", "tag": "format", "variants": [ { "case": "luks", - "type": "777" + "type": "779" }, { "case": "aes", @@ -23403,18 +23408,18 @@ "members": [ { "name": "format", - "type": "721" + "type": "723" } ], "meta-type": "object" }, { - "name": "[791]", - "element-type": "791", + "name": "[793]", + "element-type": "793", "meta-type": "array" }, { - "name": "791", + "name": "793", "members": [ { "name": "name", @@ -23426,18 +23431,18 @@ }, { "name": "flags", - "type": "[794]" + "type": "[796]" } ], "meta-type": "object" }, { - "name": "[792]", - "element-type": "792", + "name": "[794]", + "element-type": "794", "meta-type": "array" }, { - "name": "792", + "name": "794", "members": [ { "name": "filename", @@ -23465,12 +23470,12 @@ "meta-type": "object" }, { - "name": "[793]", - "element-type": "793", + "name": "[795]", + "element-type": "795", "meta-type": "array" }, { - "name": "793", + "name": "795", "members": [ { "name": "active", @@ -23494,12 +23499,12 @@ "meta-type": "object" }, { - "name": "[794]", - "element-type": "794", + "name": "[796]", + "element-type": "796", "meta-type": "array" }, { - "name": "794", + "name": "796", "members": [ { "name": "in-use" @@ -25112,6 +25117,12 @@ "name": "romfile", "type": "str" }, + { + "default-value": true, + "name": "x-pcie-ext-tag", + "description": "on/off", + "type": "bool" + }, { "default-value": -1, "name": "addr", @@ -25158,6 +25169,10 @@ "description": "on/off", "type": "bool" }, + { + "name": "busnr", + "type": "busnr" + }, { "default-value": 0, "name": "acpi-index", @@ -25547,6 +25562,12 @@ "name": "romfile", "type": "str" }, + { + "default-value": true, + "name": "x-pcie-ext-tag", + "description": "on/off", + "type": "bool" + }, { "default-value": -1, "name": "addr", @@ -25593,6 +25614,10 @@ "description": "on/off", "type": "bool" }, + { + "name": "busnr", + "type": "busnr" + }, { "default-value": 0, "name": "acpi-index", @@ -26032,6 +26057,12 @@ "name": "romfile", "type": "str" }, + { + "default-value": true, + "name": "x-pcie-ext-tag", + "description": "on/off", + "type": "bool" + }, { "default-value": -1, "name": "addr", @@ -26078,6 +26109,10 @@ "description": "on/off", "type": "bool" }, + { + "name": "busnr", + "type": "busnr" + }, { "default-value": 0, "name": "acpi-index", @@ -26316,11 +26351,6 @@ { "return": [ - { - "name": "loadparm", - "description": "Up to 8 chars in set of [A-Za-z0-9. ] to pass to the guest loader/kernel", - "type": "ccw_loadparm" - }, { "name": "dev_id", "description": "Read-only identifier of an I/O device in the channel subsystem, example: fe.1.23ab", @@ -26336,6 +26366,11 @@ "description": "Read-only identifier of an I/O device in the channel subsystem, example: fe.1.23ab", "type": "str" }, + { + "name": "loadparm", + "description": "Up to 8 chars in set of [A-Za-z0-9. ] to pass to the guest loader/kernel", + "type": "ccw_loadparm" + }, { "default-value": 2, "name": "max_revision", @@ -26607,11 +26642,6 @@ { "return": [ - { - "name": "loadparm", - "description": "Up to 8 chars in set of [A-Za-z0-9. ] to pass to the guest loader/kernel", - "type": "ccw_loadparm" - }, { "name": "dev_id", "description": "Read-only identifier of an I/O device in the channel subsystem, example: fe.1.23ab", @@ -26627,6 +26657,11 @@ "description": "Read-only identifier of an I/O device in the channel subsystem, example: fe.1.23ab", "type": "str" }, + { + "name": "loadparm", + "description": "Up to 8 chars in set of [A-Za-z0-9. ] to pass to the guest loader/kernel", + "type": "ccw_loadparm" + }, { "default-value": 2, "name": "max_revision", @@ -26953,11 +26988,6 @@ { "return": [ - { - "name": "loadparm", - "description": "Up to 8 chars in set of [A-Za-z0-9. ] to pass to the guest loader/kernel", - "type": "ccw_loadparm" - }, { "name": "dev_id", "description": "Read-only identifier of an I/O device in the channel subsystem, example: fe.1.23ab", @@ -27114,6 +27144,12 @@ "name": "romfile", "type": "str" }, + { + "default-value": true, + "name": "x-pcie-ext-tag", + "description": "on/off", + "type": "bool" + }, { "default-value": -1, "name": "addr", @@ -27160,6 +27196,10 @@ "description": "on/off", "type": "bool" }, + { + "name": "busnr", + "type": "busnr" + }, { "default-value": 0, "name": "acpi-index", @@ -27509,6 +27549,11 @@ "description": "A power of two between 512 B and 2 MiB", "type": "size" }, + { + "name": "loadparm", + "description": "load parameter (s390x only)", + "type": "string" + }, { "default-value": true, "name": "migrate-emulated-scsi-request", @@ -27811,6 +27856,12 @@ "name": "romfile", "type": "str" }, + { + "default-value": true, + "name": "x-pcie-ext-tag", + "description": "on/off", + "type": "bool" + }, { "default-value": -1, "name": "addr", @@ -27857,6 +27908,10 @@ "description": "on/off", "type": "bool" }, + { + "name": "busnr", + "type": "busnr" + }, { "default-value": 0, "name": "acpi-index", @@ -28239,6 +28294,12 @@ "name": "romfile", "type": "str" }, + { + "default-value": true, + "name": "x-pcie-ext-tag", + "description": "on/off", + "type": "bool" + }, { "default-value": -1, "name": "addr", @@ -28285,6 +28346,10 @@ "description": "on/off", "type": "bool" }, + { + "name": "busnr", + "type": "busnr" + }, { "default-value": 0, "name": "acpi-index", @@ -28512,11 +28577,6 @@ { "return": [ - { - "name": "loadparm", - "description": "Up to 8 chars in set of [A-Za-z0-9. ] to pass to the guest loader/kernel", - "type": "ccw_loadparm" - }, { "name": "dev_id", "description": "Read-only identifier of an I/O device in the channel subsystem, example: fe.1.23ab", @@ -28783,11 +28843,6 @@ { "return": [ - { - "name": "loadparm", - "description": "Up to 8 chars in set of [A-Za-z0-9. ] to pass to the guest loader/kernel", - "type": "ccw_loadparm" - }, { "name": "dev_id", "description": "Read-only identifier of an I/O device in the channel subsystem, example: fe.1.23ab", @@ -29149,6 +29204,12 @@ "name": "romfile", "type": "str" }, + { + "default-value": true, + "name": "x-pcie-ext-tag", + "description": "on/off", + "type": "bool" + }, { "default-value": -1, "name": "addr", @@ -29195,6 +29256,10 @@ "description": "on/off", "type": "bool" }, + { + "name": "busnr", + "type": "busnr" + }, { "default-value": 0, "name": "acpi-index", @@ -29411,11 +29476,6 @@ { "return": [ - { - "name": "loadparm", - "description": "Up to 8 chars in set of [A-Za-z0-9. ] to pass to the guest loader/kernel", - "type": "ccw_loadparm" - }, { "name": "dev_id", "description": "Read-only identifier of an I/O device in the channel subsystem, example: fe.1.23ab", @@ -29431,6 +29491,11 @@ "description": "Read-only identifier of an I/O device in the channel subsystem, example: fe.1.23ab", "type": "str" }, + { + "name": "loadparm", + "description": "Up to 8 chars in set of [A-Za-z0-9. ] to pass to the guest loader/kernel", + "type": "ccw_loadparm" + }, { "default-value": 2, "name": "max_revision", @@ -29992,7 +30057,7 @@ "default-cpu-type": "host-s390x-cpu", "acpi": false, "cpu-max": 248, - "deprecated": false, + "deprecated": true, "default-ram-id": "s390.ram" }, { @@ -30221,6 +30286,11 @@ "description": "Overrides the \"compatible\" property of the dt root node", "type": "string" }, + { + "name": "suppress-vmdesc", + "description": "Set on to disable self-describing migration", + "type": "bool" + }, { "name": "boot", "description": "Boot configuration", @@ -30272,39 +30342,39 @@ "type": "bool" }, { - "name": "phandle-start", - "description": "The first phandle ID we may generate dynamically", - "type": "int" + "name": "smp-cache", + "description": "Cache properties list for SMP machine", + "type": "SmpCachePropertiesWrapper" }, { "name": "dumpdtb", "description": "Dump current dtb to a file and quit", "type": "string" }, + { + "name": "phandle-start", + "description": "The first phandle ID we may generate dynamically", + "type": "int" + }, { "name": "memory-backend", "description": "Set RAM backendValid value is ID of hostmem based backend", "type": "link<memory-backend>" }, - { - "name": "dtb", - "description": "Linux kernel device tree file", - "type": "string" - }, { "name": "mem-merge", "description": "Enable/disable memory merge support", "type": "bool" }, { - "name": "append", - "description": "Linux kernel command line", + "name": "dtb", + "description": "Linux kernel device tree file", "type": "string" }, { - "name": "suppress-vmdesc", - "description": "Set on to disable self-describing migration", - "type": "bool" + "name": "append", + "description": "Linux kernel command line", + "type": "string" }, { "name": "peripheral-anon", @@ -31013,6 +31083,11 @@ "help": "Overrides the \"compatible\" property of the dt root node", "type": "string" }, + { + "name": "suppress-vmdesc", + "help": "Set on to disable self-describing migration", + "type": "boolean" + }, { "name": "boot", "help": "Boot configuration", @@ -31064,9 +31139,9 @@ "type": "boolean" }, { - "name": "phandle-start", - "help": "The first phandle ID we may generate dynamically", - "type": "number" + "name": "smp-cache", + "help": "Cache properties list for SMP machine", + "type": "string" }, { "name": "dumpdtb", @@ -31074,13 +31149,13 @@ "type": "string" }, { - "name": "memory-backend", - "help": "Set RAM backendValid value is ID of hostmem based backend", - "type": "string" + "name": "phandle-start", + "help": "The first phandle ID we may generate dynamically", + "type": "number" }, { - "name": "dtb", - "help": "Linux kernel device tree file", + "name": "memory-backend", + "help": "Set RAM backendValid value is ID of hostmem based backend", "type": "string" }, { @@ -31089,14 +31164,14 @@ "type": "boolean" }, { - "name": "append", - "help": "Linux kernel command line", + "name": "dtb", + "help": "Linux kernel device tree file", "type": "string" }, { - "name": "suppress-vmdesc", - "help": "Set on to disable self-describing migration", - "type": "boolean" + "name": "append", + "help": "Linux kernel command line", + "type": "string" }, { "name": "loadparm", @@ -32433,12 +32508,27 @@ "model": { "name": "gen16a-base", "props": { + "pfmfi": false, + "exrl": true, + "stfle45": true, "nnpa": true, + "cmma": false, + "dateh2": true, "aen": true, + "gen13ptff": true, + "dateh": true, "cmmnt": true, + "iacc2": true, + "parseh": true, + "csst": true, + "idter": false, + "idtes": true, + "msa": true, "vxpdeh": true, "aefsi": true, "diag318": true, + "hpma2": false, + "csst2": true, "csske": true, "mepoch": true, "msa9": true, @@ -32451,42 +32541,96 @@ "msa2": true, "msa1": true, "sthyi": true, + "stckf": true, + "stfle": true, + "etf3": true, + "etf2": true, "edat": true, + "hfpm": true, "ri": true, "deflate": true, "edat2": true, + "hfpue": true, + "unpack": false, + "dfp": true, + "mvcos": true, "etoken": true, + "sprogp": true, + "sigpif": false, + "ldisphp": true, "vx": true, "ipter": true, "pai": true, + "emon": true, + "cei": false, + "cmpsceh": true, + "ginste": true, "paie": true, + "dfppc": true, + "dfpzc": true, + "dfphp": true, + "stfle49": true, "mepochptff": true, + "opc": true, "ap": true, + "asnlxr": true, + "gpereh": false, + "minste2": true, "vxeh": true, "vxpd": true, "esop": true, + "ectg": true, + "ib": false, "msa9_pckmo": true, + "siif": false, "vxeh2": true, + "tsi": true, + "tpei": false, + "esan3": true, "esort": true, + "fpe": true, + "ibs": false, + "zarch": true, "appv": true, "apqi": true, "apft": true, + "stfle53": true, "els": true, + "sief2": false, + "eimm": true, "iep": true, + "irbm": false, + "srs": true, "appvi": true, "apqci": true, + "kss": false, "cte": true, "ais": true, + "fpseh": true, + "ltlbc": true, + "ldisp": true, "bpb": true, + "64bscao": false, "ctop": true, "gs": true, + "sema": true, + "etf3eh": true, + "etf2eh": true, + "eec": true, "ppa15": true, "zpci": true, "rdp": true, + "nonqks": true, "sea_esop2": true, + "minste3": true, "beareh": true, + "pfpo": true, "te": true, "cmm": true, + "tods": true, + "plo": true, + "gsls": false, + "skey": false, "vxpdeh2": true } } @@ -36879,7 +37023,7 @@ "default-cpu-type": "qemu-s390x-cpu", "acpi": false, "cpu-max": 248, - "deprecated": false, + "deprecated": true, "default-ram-id": "s390.ram" }, { diff --git a/tests/qemucapabilitiesdata/caps_9.2.0_s390x.xml b/tests/qemucapabilitiesdata/caps_9.2.0_s390x.xml index 767a95bd3e..49a4a14dc1 100644 --- a/tests/qemucapabilitiesdata/caps_9.2.0_s390x.xml +++ b/tests/qemucapabilitiesdata/caps_9.2.0_s390x.xml @@ -138,9 +138,9 @@ <flag name='netdev-stream-reconnect-miliseconds'/> <flag name='query-cpu-model-expansion.deprecated-props'/> <flag name='migrate-incoming.exit-on-error'/> - <version>9001050</version> + <version>9002000</version> <microcodeVersion>39100247</microcodeVersion> - <package>v9.1.0-1348-g11b8920ed2</package> + <package>v9.2.0</package> <arch>s390x</arch> <hostCPU type='kvm' model='gen16a-base' migratability='no'> <property name='nnpa' type='boolean' value='true'/> @@ -293,7 +293,7 @@ <machine type='kvm' name='s390-ccw-virtio-2.8' hotplugCpus='yes' maxCpus='248' defaultCPU='host-s390x-cpu' defaultRAMid='s390.ram' deprecated='yes' acpi='no'/> <machine type='kvm' name='s390-ccw-virtio-4.0' hotplugCpus='yes' maxCpus='248' defaultCPU='host-s390x-cpu' defaultRAMid='s390.ram' deprecated='yes' acpi='no'/> <machine type='kvm' name='s390-ccw-virtio-8.2' hotplugCpus='yes' maxCpus='248' defaultCPU='host-s390x-cpu' defaultRAMid='s390.ram' acpi='no'/> - <machine type='kvm' name='s390-ccw-virtio-6.2' hotplugCpus='yes' maxCpus='248' defaultCPU='host-s390x-cpu' defaultRAMid='s390.ram' acpi='no'/> + <machine type='kvm' name='s390-ccw-virtio-6.2' hotplugCpus='yes' maxCpus='248' defaultCPU='host-s390x-cpu' defaultRAMid='s390.ram' deprecated='yes' acpi='no'/> <machine type='kvm' name='s390-ccw-virtio-3.0' hotplugCpus='yes' maxCpus='248' defaultCPU='host-s390x-cpu' defaultRAMid='s390.ram' deprecated='yes' acpi='no'/> <machine type='kvm' name='s390-ccw-virtio-2.5' hotplugCpus='yes' maxCpus='248' defaultCPU='host-s390x-cpu' defaultRAMid='s390.ram' deprecated='yes' acpi='no'/> <machine type='kvm' name='s390-ccw-virtio-7.2' hotplugCpus='yes' maxCpus='248' defaultCPU='host-s390x-cpu' defaultRAMid='s390.ram' acpi='no'/> @@ -3743,7 +3743,7 @@ <machine type='tcg' name='s390-ccw-virtio-2.8' hotplugCpus='yes' maxCpus='248' defaultCPU='qemu-s390x-cpu' defaultRAMid='s390.ram' deprecated='yes' acpi='no'/> <machine type='tcg' name='s390-ccw-virtio-4.0' hotplugCpus='yes' maxCpus='248' defaultCPU='qemu-s390x-cpu' defaultRAMid='s390.ram' deprecated='yes' acpi='no'/> <machine type='tcg' name='s390-ccw-virtio-8.2' hotplugCpus='yes' maxCpus='248' defaultCPU='qemu-s390x-cpu' defaultRAMid='s390.ram' acpi='no'/> - <machine type='tcg' name='s390-ccw-virtio-6.2' hotplugCpus='yes' maxCpus='248' defaultCPU='qemu-s390x-cpu' defaultRAMid='s390.ram' acpi='no'/> + <machine type='tcg' name='s390-ccw-virtio-6.2' hotplugCpus='yes' maxCpus='248' defaultCPU='qemu-s390x-cpu' defaultRAMid='s390.ram' deprecated='yes' acpi='no'/> <machine type='tcg' name='s390-ccw-virtio-3.0' hotplugCpus='yes' maxCpus='248' defaultCPU='qemu-s390x-cpu' defaultRAMid='s390.ram' deprecated='yes' acpi='no'/> <machine type='tcg' name='s390-ccw-virtio-2.5' hotplugCpus='yes' maxCpus='248' defaultCPU='qemu-s390x-cpu' defaultRAMid='s390.ram' deprecated='yes' acpi='no'/> <machine type='tcg' name='s390-ccw-virtio-7.2' hotplugCpus='yes' maxCpus='248' defaultCPU='qemu-s390x-cpu' defaultRAMid='s390.ram' acpi='no'/> -- 2.47.0

2 2

[PATCH 00/26] integrate auto-shutdown of VMs with daemons
by Daniel P. Berrangé 11 Mar '25

11 Mar '25

This series starts the work needed to obsolete the libvirt-guests.sh script which has grown a surprisingly large amount of functionality. Currently the virt daemons will acquire inhibitors to delay OS shutdown when VMs are running. The libvirt-guests.service unit can be used to call libvirt-guests.sh to shutdown running VMs on system shutdown. This split is a bad architecture because libvirt-guests.service will only run once the system has decided to initiate the shutdown sequence. When the user requests as shutdown while inhibitors are present, logind will emit a "PrepareForShutdown" signal over dbus. Applications are supposed to respond to this by preserving state & releasing their inhibitors, which in turns allows shutdown to be initiated. The remote daemon already has support for listening for the "PrepareForShutdown" signal, but only does this for session instances, not system instances. This series essentially takes that logic and expands it to run in the system instances too, thus conceptually making libvirt-guests.service obsolete. It is slightly more complicated than that though for many reasons... Saving running VMs can take a very long time. The inhibitor delay can be as low as 5 seconds, and when killing a service, systemd may not wait very long for it to terminate. libvirt-guests.service deals with this by setting TimeoutStopSecs=0 to make systemd wait forever. This is undesirable to set in libvirtd.service though, as we would like systemd to kill the daemon aggressively if it hangs. The series thus uses the notification protocol to request systemd give it more time to shutdown, as long as we're in the phase of saving running VMs. A bug in this code will still result in systemd waiting forever, which is no different from libvirt-guests.service, but a bug in any other part of the libvirt daemon shutdown code will result in systemd killing us. The existing logic for saving VMs in the session daemons had many feature gaps compared to libvirt-guests.sh. Thus there is code to add support * Requesting graceful OS shutdown if managed save failed * Force poweroff of VMs if no other action worked * Optionally enabling/disabling use of managed save, graceful shutdown and force poweroff, which is more flexible than ON_SHUTDOWN=nnn, as we can try the whole sequence of options * Ability to bypass cache in managed save * Support for one-time autostart of VMs as an official API To aid in testing this logic, virt-admin gains a new command 'virt-admin daemon-shutdown --preserve' All this new functionality is wired up into the QEMU driver, and is made easily accessible to other hypervisor drivers, so would easily be extendable to Xen, CH, LXC drivers, but this is not done in this series. IOW, libvirt-guests.service is not yet fully obsolete. The new functionality is also not enabled by default for the system daemon, it requires explicit admin changes to /etc/libvirt/qemu.conf to enable it. This is because it would clash with execution of the libvirt-guests.service if both were enabled. It is highly desirable that we enable this by default though, so we need to figure out a upgrade story wrt libvirt-guests.service. The only libvirt-guests.sh features not implemented are: * PARALLEL_SHUTDOWN=nn. When doing a graceful shutdown we initiate it on every single VM at once, and then monitor progress of all of them in parallel. * SYNC_TIME=nn When make not attempt to sync guest time when restoring from managed save. This ought to be fixed Daniel P. Berrangé (26): util: add APIs for more systemd notifications remote: notify systemd when reloading config hypervisor: introduce helper for autostart src: convert drivers over to use new autostart helper hypervisor: add support for delay interval during autostart qemu: add 'auto_start_delay' configuration parameter hypervisor: move support for auto-shutdown out of QEMU driver remote: always invoke virStateStop for all daemons hypervisor: expand available shutdown actions hypervisor: custom shutdown actions for transient vs persistent VMs qemu: support automatic VM managed save in system daemon qemu: improve shutdown defaults for session daemon qemu: configurable delay for shutdown before poweroff hypervisor: support bypassing cache for managed save qemu: add config parameter to control auto-save bypass cache src: add new APIs for marking a domain to autostart once conf: implement support for autostart once feature hypervisor: wire up support for auto restore of running domains qemu: wire up support for once only autostart qemu: add config to control if auto-shutdown VMs are restored rpc: move state stop into virNetDaemon class rpc: don't unconditionally quit after preserving state rpc: fix shutdown sequence when preserving state admin: add 'daemon-shutdown' command rpc: don't let systemd shutdown daemon while saving VMs hypervisor: send systemd status messages while saving include/libvirt/libvirt-admin.h | 13 ++ include/libvirt/libvirt-domain.h | 4 + src/admin/admin_protocol.x | 11 +- src/admin/admin_server_dispatch.c | 13 ++ src/admin/libvirt-admin.c | 33 ++++ src/admin/libvirt_admin_public.syms | 5 + src/bhyve/bhyve_driver.c | 53 ++---- src/conf/domain_conf.c | 6 +- src/conf/domain_conf.h | 1 + src/conf/virdomainobjlist.c | 7 +- src/driver-hypervisor.h | 10 ++ src/hypervisor/domain_driver.c | 250 ++++++++++++++++++++++++++++ src/hypervisor/domain_driver.h | 42 +++++ src/libvirt-domain.c | 87 ++++++++++ src/libvirt_private.syms | 10 +- src/libvirt_public.syms | 6 + src/libvirt_remote.syms | 2 +- src/libxl/libxl_driver.c | 36 ++-- src/lxc/lxc_driver.c | 13 +- src/lxc/lxc_process.c | 18 +- src/lxc/lxc_process.h | 2 + src/qemu/libvirtd_qemu.aug | 7 + src/qemu/qemu.conf.in | 59 +++++++ src/qemu/qemu_conf.c | 63 +++++++ src/qemu/qemu_conf.h | 7 + src/qemu/qemu_driver.c | 203 +++++++++++++--------- src/qemu/test_libvirtd_qemu.aug.in | 7 + src/remote/libvirtd.service.in | 2 +- src/remote/remote_daemon.c | 78 +++------ src/remote/remote_driver.c | 2 + src/remote/remote_protocol.x | 30 +++- src/remote_protocol-structs | 12 ++ src/rpc/gendispatch.pl | 4 +- src/rpc/virnetdaemon.c | 212 +++++++++++++++++++---- src/rpc/virnetdaemon.h | 20 ++- src/util/virsystemd.c | 41 ++++- src/util/virsystemd.h | 6 +- src/virtd.service.in | 2 +- tools/virsh-domain-monitor.c | 5 + tools/virsh-domain.c | 39 ++++- tools/virt-admin.c | 41 +++++ 41 files changed, 1181 insertions(+), 281 deletions(-) -- 2.47.1

2 73

[PATCH] util: Require libnl for Linux
by Akihiko Odaki 11 Mar '25

11 Mar '25

Builds for Linux without libnl is broken since commit 582f0966f9b9e2148d8887d072364e2a91aed000 so make libnl mandatory for Linux. Another option is to fix such builds, but it can bring more problems than benefits. libnl is available on all supported distributions so the only practical situation to lack libnl is that a developer does not have a development package of libnl installed. Enabling builds in such a situation make developers use builds divergent from CI and end-user scenarios, which has some implications. Builds without libnl lack several features such as SR-IOV, bridge/tap, switchdev, macvlan, veth, and vlan. Some part of libvirt may expect these features are readily available on Linux, and the lack of libnl may cause a build failure like one mentioned earlier or runtime errors even harder to debug. Developers will then be forced to debug such bugs and to choose either fixing the build configuration that has no real user or work around the issue by installing the development package. In any case, the bridge/tap configuration is one of the fundamental features and developers are likely to want libnl for it. Save the potential trouble for developers by requiring libnl for Linux and let Meson direct them to install libnl. Signed-off-by: Akihiko Odaki <akihiko.odaki(a)daynix.com> --- Supersedes: <20250307-nl-v1-1-c66fc2bf8703(a)daynix.com> ("[PATCH] util: Check libnl function availability") --- libvirt.spec.in | 2 - meson.build | 16 +-- meson_options.txt | 1 - src/util/virnetdev.c | 223 +++++++++++++++---------------------- src/util/virnetdevbridge.c | 27 +---- src/util/virnetdevip.c | 230 +++++++++++++++++++-------------------- src/util/virnetdevmacvlan.c | 6 +- src/util/virnetdevveth.c | 35 ------ src/util/virnetdevvportprofile.c | 8 +- src/util/virnetlink.c | 8 +- src/util/virnetlink.h | 4 +- tests/virnetdevtest.c | 8 -- 12 files changed, 222 insertions(+), 346 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index cb41ea1de1c6cd3d3d5f8c810d0df7be4f7d490f..9396029dd394d218f2c1c01740ad41754786dd04 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1421,7 +1421,6 @@ export SOURCE_DATE_EPOCH=$(stat --printf='%Y' %{_specdir}/libvirt.spec) -Dlibpcap=enabled \ %{?arg_nbdkit} \ %{?arg_nbdkit_config_default} \ - -Dlibnl=enabled \ -Daudit=enabled \ -Ddtrace=enabled \ -Dfirewalld=enabled \ @@ -1493,7 +1492,6 @@ export SOURCE_DATE_EPOCH=$(stat --printf='%Y' %{_specdir}/libvirt.spec) -Dlibiscsi=disabled \ -Dnbdkit=disabled \ -Dnbdkit_config_default=disabled \ - -Dlibnl=disabled \ -Dlibpcap=disabled \ -Dlibssh2=disabled \ -Dlibssh=disabled \ diff --git a/meson.build b/meson.build index 2d76a0846c6b94f8d168d25f09dd60954db770cb..fd90bb5b3005ac7ece24da4432fad78bdffdefe7 100644 --- a/meson.build +++ b/meson.build @@ -1086,18 +1086,10 @@ endif conf.set10('USE_NBDKIT_DEFAULT', use_nbdkit_default) libnl_version = '3.0' -if not get_option('libnl').disabled() and host_machine.system() == 'linux' - libnl_dep = dependency('libnl-3.0', version: '>=' + libnl_version, required: get_option('libnl')) - libnl_route_dep = dependency('libnl-route-3.0', version: '>=' + libnl_version, required: get_option('libnl')) - - if libnl_dep.found() and libnl_route_dep.found() - libnl_dep = declare_dependency( - dependencies: [ libnl_dep, libnl_route_dep ], - ) - conf.set('WITH_LIBNL', 1) - endif -elif get_option('libnl').enabled() - error('libnl can be enabled only on linux') +if host_machine.system() == 'linux' + libnl_dep = dependency('libnl-3.0', version: '>=' + libnl_version) + libnl_route_dep = dependency('libnl-route-3.0', version: '>=' + libnl_version) + libnl_dep = declare_dependency(dependencies: [ libnl_dep, libnl_route_dep ]) else libnl_dep = dependency('', required: false) endif diff --git a/meson_options.txt b/meson_options.txt index 3dc3e8667bb2cf73d96cd1ebe046590be55a5df8..bbcc13e8d8efa4c56cc3e0dc17386ccfd45b2b50 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -30,7 +30,6 @@ option('fuse', type: 'feature', value: 'auto', description: 'fuse support') option('glusterfs', type: 'feature', value: 'auto', description: 'glusterfs support') option('json_c', type: 'feature', value: 'auto', description: 'JSON-C support') option('libiscsi', type: 'feature', value: 'auto', description: 'libiscsi support') -option('libnl', type: 'feature', value: 'auto', description: 'libnl support') option('libpcap', type: 'feature', value: 'auto', description: 'libpcap support') option('libssh', type: 'feature', value: 'auto', description: 'libssh support') option('libssh2', type: 'feature', value: 'auto', description: 'libssh2 support') diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 8ae854245ed99dc1a3aa4c225b614ddbb449caf8..4129768bd42e7b1b2a9e7b24148627d1abe5458a 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -884,7 +884,7 @@ int virNetDevGetIndex(const char *ifname G_GNUC_UNUSED, #endif /* ! SIOCGIFINDEX */ -#if defined(WITH_LIBNL) +#if defined(__linux__) /** * virNetDevGetMaster: * @ifname: name of interface we're interested in @@ -914,29 +914,6 @@ virNetDevGetMaster(const char *ifname, char **master) return 0; } -#elif defined(__linux__) - -/* libnl isn't available, so we can't use netlink. - * Fall back to using sysfs - */ -int -virNetDevGetMaster(const char *ifname, char **master) -{ - g_autofree char *path = NULL; - g_autofree char *canonical = NULL; - - if (virNetDevSysfsFile(&path, ifname, "master") < 0) - return -1; - - if (!(canonical = virFileCanonicalizePath(path))) - return -1; - - *master = g_path_get_basename(canonical); - - VIR_DEBUG("IFLA_MASTER for %s is %s", ifname, *master ? *master : "(none)"); - return 0; -} - #else int @@ -949,7 +926,7 @@ virNetDevGetMaster(const char *ifname G_GNUC_UNUSED, } -#endif /* defined(WITH_LIBNL) */ +#endif /* defined(__linux__) */ #if __linux__ @@ -1079,8 +1056,6 @@ virNetDevSysfsDeviceFile(char **pf_sysfs_device_link, const char *ifname, } -# if defined(WITH_LIBNL) - /** * Determine if the device path specified in devpath is a PCI Device * by resolving the 'subsystem'-link in devpath and looking for @@ -1133,7 +1108,6 @@ virNetDevGetPCIDevice(const char *devName) return virPCIDeviceNew(vfPCIAddr); } -# endif /* A wrapper to get content of file from ifname SYSFS_NET_DIR @@ -1381,99 +1355,6 @@ virNetDevGetVirtualFunctionInfo(const char *vfname, char **pfname, return ret; } -#else /* !__linux__ */ -int -virNetDevGetPhysPortID(const char *ifname G_GNUC_UNUSED, - char **physPortID) -{ - /* this actually should never be called, and is just here to - * satisfy the linker. - */ - *physPortID = NULL; - return 0; -} - -int -virNetDevGetPhysPortName(const char *ifname G_GNUC_UNUSED, - char **physPortName) -{ - /* this actually should never be called, and is just here to - * satisfy the linker. - */ - *physPortName = NULL; - return 0; -} - -int -virNetDevGetVirtualFunctions(const char *pfname G_GNUC_UNUSED, - virPCIVirtualFunctionList **vfs G_GNUC_UNUSED) -{ - virReportSystemError(ENOSYS, "%s", - _("Unable to get virtual functions on this platform")); - return -1; -} - -int -virNetDevIsVirtualFunction(const char *ifname G_GNUC_UNUSED) -{ - virReportSystemError(ENOSYS, "%s", - _("Unable to check virtual function status on this platform")); - return -1; -} - -int -virNetDevGetVirtualFunctionIndex(const char *pfname G_GNUC_UNUSED, - const char *vfname G_GNUC_UNUSED, - int *vf_index G_GNUC_UNUSED) -{ - virReportSystemError(ENOSYS, "%s", - _("Unable to get virtual function index on this platform")); - return -1; -} - -int -virNetDevGetPhysicalFunction(const char *ifname G_GNUC_UNUSED, - char **pfname G_GNUC_UNUSED) -{ - virReportSystemError(ENOSYS, "%s", - _("Unable to get physical function status on this platform")); - return -1; -} - -int -virNetDevPFGetVF(const char *pfname G_GNUC_UNUSED, - int vf G_GNUC_UNUSED, - char **vfname G_GNUC_UNUSED) -{ - virReportSystemError(ENOSYS, "%s", - _("Unable to get virtual function name on this platform")); - return -1; -} - -int -virNetDevGetVirtualFunctionInfo(const char *vfname G_GNUC_UNUSED, - char **pfname G_GNUC_UNUSED, - int *vf G_GNUC_UNUSED) -{ - virReportSystemError(ENOSYS, "%s", - _("Unable to get virtual function info on this platform")); - return -1; -} - -int -virNetDevSysfsFile(char **pf_sysfs_device_link G_GNUC_UNUSED, - const char *ifname G_GNUC_UNUSED, - const char *file G_GNUC_UNUSED) -{ - virReportSystemError(ENOSYS, "%s", - _("Unable to get sysfs info on this platform")); - return -1; -} - - -#endif /* !__linux__ */ -#if defined(WITH_LIBNL) - static virMacAddr zeroMAC = { .addr = { 0, 0, 0, 0, 0, 0 } }; @@ -2379,8 +2260,94 @@ virNetDevSetNetConfig(const char *linkdev, int vf, return 0; } +#else /* !__linux__ */ +int +virNetDevGetPhysPortID(const char *ifname G_GNUC_UNUSED, + char **physPortID) +{ + /* this actually should never be called, and is just here to + * satisfy the linker. + */ + *physPortID = NULL; + return 0; +} + +int +virNetDevGetPhysPortName(const char *ifname G_GNUC_UNUSED, + char **physPortName) +{ + /* this actually should never be called, and is just here to + * satisfy the linker. + */ + *physPortName = NULL; + return 0; +} + +int +virNetDevGetVirtualFunctions(const char *pfname G_GNUC_UNUSED, + virPCIVirtualFunctionList **vfs G_GNUC_UNUSED) +{ + virReportSystemError(ENOSYS, "%s", + _("Unable to get virtual functions on this platform")); + return -1; +} + +int +virNetDevIsVirtualFunction(const char *ifname G_GNUC_UNUSED) +{ + virReportSystemError(ENOSYS, "%s", + _("Unable to check virtual function status on this platform")); + return -1; +} + +int +virNetDevGetVirtualFunctionIndex(const char *pfname G_GNUC_UNUSED, + const char *vfname G_GNUC_UNUSED, + int *vf_index G_GNUC_UNUSED) +{ + virReportSystemError(ENOSYS, "%s", + _("Unable to get virtual function index on this platform")); + return -1; +} + +int +virNetDevGetPhysicalFunction(const char *ifname G_GNUC_UNUSED, + char **pfname G_GNUC_UNUSED) +{ + virReportSystemError(ENOSYS, "%s", + _("Unable to get physical function status on this platform")); + return -1; +} -#else /* defined(WITH_LIBNL) */ +int +virNetDevPFGetVF(const char *pfname G_GNUC_UNUSED, + int vf G_GNUC_UNUSED, + char **vfname G_GNUC_UNUSED) +{ + virReportSystemError(ENOSYS, "%s", + _("Unable to get virtual function name on this platform")); + return -1; +} + +int +virNetDevGetVirtualFunctionInfo(const char *vfname G_GNUC_UNUSED, + char **pfname G_GNUC_UNUSED, + int *vf G_GNUC_UNUSED) +{ + virReportSystemError(ENOSYS, "%s", + _("Unable to get virtual function info on this platform")); + return -1; +} + +int +virNetDevSysfsFile(char **pf_sysfs_device_link G_GNUC_UNUSED, + const char *ifname G_GNUC_UNUSED, + const char *file G_GNUC_UNUSED) +{ + virReportSystemError(ENOSYS, "%s", + _("Unable to get sysfs info on this platform")); + return -1; +} int @@ -2477,7 +2444,7 @@ virNetDevSetVfConfig(const char *ifname G_GNUC_UNUSED, } -#endif /* defined(WITH_LIBNL) */ +#endif /* defined(__linux__) */ VIR_ENUM_IMPL(virNetDevIfState, VIR_NETDEV_IF_STATE_LAST, @@ -3095,8 +3062,6 @@ virNetDevGetEthtoolFeatures(const char *ifname, } -# if defined(WITH_LIBNL) - /** * virNetDevGetFamilyId: * This function supplies the devlink family id @@ -3237,14 +3202,6 @@ virNetDevSwitchdevFeature(const char *ifname, nlmsg_free(nl_msg); return ret; } -# else -static int -virNetDevSwitchdevFeature(const char *ifname G_GNUC_UNUSED, - virBitmap **out G_GNUC_UNUSED) -{ - return 0; -} -# endif /** diff --git a/src/util/virnetdevbridge.c b/src/util/virnetdevbridge.c index c79d0c79b7b16a0a070b5013ed7df9d0a63b1c38..45f8dd7e15286b875f5b54ad147b32323886e1f0 100644 --- a/src/util/virnetdevbridge.c +++ b/src/util/virnetdevbridge.c @@ -30,9 +30,7 @@ #endif #ifdef __linux__ -# if defined(WITH_LIBNL) -# include "virnetlink.h" -# endif +# include "virnetlink.h" # include <linux/sockios.h> # include <linux/param.h> /* HZ */ # include <linux/in6.h> @@ -479,7 +477,7 @@ virNetDevBridgeCreateWithIoctl(const char *brname, } #endif -#if defined(WITH_LIBNL) +#if defined(__linux__) int virNetDevBridgeCreate(const char *brname, const virMacAddr *mac) @@ -509,15 +507,6 @@ virNetDevBridgeCreate(const char *brname, } -#elif defined(WITH_STRUCT_IFREQ) && defined(SIOCBRADDBR) -int -virNetDevBridgeCreate(const char *brname, - const virMacAddr *mac) -{ - return virNetDevBridgeCreateWithIoctl(brname, mac); -} - - #elif defined(WITH_STRUCT_IFREQ) && defined(SIOCIFCREATE2) int virNetDevBridgeCreate(const char *brname, @@ -590,7 +579,7 @@ virNetDevBridgeDeleteWithIoctl(const char *brname) #endif -#if defined(WITH_LIBNL) +#if defined(__linux__) int virNetDevBridgeDelete(const char *brname) { @@ -606,14 +595,6 @@ virNetDevBridgeDelete(const char *brname) } -#elif defined(WITH_STRUCT_IFREQ) && defined(SIOCBRDELBR) -int -virNetDevBridgeDelete(const char *brname) -{ - return virNetDevBridgeDeleteWithIoctl(brname); -} - - #elif defined(WITH_STRUCT_IFREQ) && defined(SIOCIFDESTROY) int virNetDevBridgeDelete(const char *brname) @@ -1020,7 +1001,7 @@ virNetDevBridgeSetVlanFiltering(const char *brname G_GNUC_UNUSED, #endif -#if defined(WITH_LIBNL) +#if defined(__linux__) # ifndef NTF_SELF # define NTF_SELF 0x02 diff --git a/src/util/virnetdevip.c b/src/util/virnetdevip.c index f365c1999c3d358a6a7b56ebda9f318c25fe96fd..acb0f41321b3d1d0f83fcf808ea9f95ffd9ddd46 100644 --- a/src/util/virnetdevip.c +++ b/src/util/virnetdevip.c @@ -52,7 +52,7 @@ VIR_LOG_INIT("util.netdevip"); -#if defined(WITH_LIBNL) +#if defined(__linux__) static int virNetDevGetIPAddressBinary(virSocketAddr *addr, void **data, size_t *len) @@ -361,7 +361,118 @@ virNetDevIPRouteAdd(const char *ifname, } -#else /* defined(WITH_LIBNL) */ +static int +virNetDevIPGetAcceptRA(const char *ifname) +{ + g_autofree char *path = NULL; + g_autofree char *buf = NULL; + char *suffix; + int accept_ra = -1; + + path = g_strdup_printf("/proc/sys/net/ipv6/conf/%s/accept_ra", + ifname ? ifname : "all"); + + if ((virFileReadAll(path, 512, &buf) < 0) || + (virStrToLong_i(buf, &suffix, 10, &accept_ra) < 0)) + return -1; + + return accept_ra; +} + +/** + * virNetDevIPCheckIPv6Forwarding + * + * This function checks if IPv6 routes have the RTF_ADDRCONF flag set, + * indicating they have been created by the kernel's RA configuration + * handling. These routes are subject to being flushed when ipv6 + * forwarding is enabled unless accept_ra is explicitly set to "2". + * This will most likely result in ipv6 networking being broken. + * + * Returns: true if it is safe to enable forwarding, or false if + * breakable routes are found. + * + **/ +bool +virNetDevIPCheckIPv6Forwarding(void) +{ + int len; + char *cur; + g_autofree char *buf = NULL; + /* lines are 150 chars */ + enum {MAX_ROUTE_SIZE = 150*1000000}; + + /* This is /proc/sys/net/ipv6/conf/all/accept_ra */ + int all_accept_ra = virNetDevIPGetAcceptRA(NULL); + + /* Read ipv6 routes */ + if ((len = virFileReadAll(PROC_NET_IPV6_ROUTE, + MAX_ROUTE_SIZE, &buf)) < 0) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Unable to read %1$s for ipv6 forwarding checks"), + PROC_NET_IPV6_ROUTE); + return false; + } + + /* Dropping the last character to stop the loop */ + if (len > 0) + buf[len-1] = '\0'; + + cur = buf; + while (cur) { + char route[33], flags[9], iface[9]; + unsigned int flags_val; + char *iface_val; + int num; + char *nl = strchr(cur, '\n'); + + if (nl) + *nl++ = '\0'; + + num = sscanf(cur, "%32s %*s %*s %*s %*s %*s %*s %*s %8s %8s", + route, flags, iface); + + cur = nl; + if (num != 3) { + VIR_DEBUG("Failed to parse route line: %s", cur); + continue; + } + + if (virStrToLong_ui(flags, NULL, 16, &flags_val)) { + VIR_DEBUG("Failed to parse flags: %s", flags); + continue; + } + + /* This is right justified, strip leading spaces */ + iface_val = &iface[0]; + while (*iface_val && g_ascii_isspace(*iface_val)) + iface_val++; + + VIR_DEBUG("%s iface %s flags %s : RTF_ADDRCONF %sset", + route, iface_val, flags, + (flags_val & RTF_ADDRCONF ? "" : "not ")); + + if (flags_val & RTF_ADDRCONF) { + int ret = virNetDevIPGetAcceptRA(iface_val); + VIR_DEBUG("%s reports accept_ra of %d", + iface_val, ret); + /* If the interface for this autoconfigured route + * has accept_ra == 1, or it is default and the "all" + * value of accept_ra == 1, it will be subject to + * flushing if forwarding is enabled. + */ + if (ret == 1 || (ret == 0 && all_accept_ra == 1)) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Check the host setup: interface %1$s has kernel autoconfigured IPv6 routes and enabling forwarding without accept_ra set to 2 will cause the kernel to flush them, breaking networking."), + iface_val); + return false; + } + } + } + return true; +} + + +#else /* defined(__linux__) */ int @@ -482,121 +593,6 @@ virNetDevIPRouteAdd(const char *ifname, return 0; } -#endif /* defined(HAVE_LIBNL) */ - - -#if defined(__linux__) - -static int -virNetDevIPGetAcceptRA(const char *ifname) -{ - g_autofree char *path = NULL; - g_autofree char *buf = NULL; - char *suffix; - int accept_ra = -1; - - path = g_strdup_printf("/proc/sys/net/ipv6/conf/%s/accept_ra", - ifname ? ifname : "all"); - - if ((virFileReadAll(path, 512, &buf) < 0) || - (virStrToLong_i(buf, &suffix, 10, &accept_ra) < 0)) - return -1; - - return accept_ra; -} - -/** - * virNetDevIPCheckIPv6Forwarding - * - * This function checks if IPv6 routes have the RTF_ADDRCONF flag set, - * indicating they have been created by the kernel's RA configuration - * handling. These routes are subject to being flushed when ipv6 - * forwarding is enabled unless accept_ra is explicitly set to "2". - * This will most likely result in ipv6 networking being broken. - * - * Returns: true if it is safe to enable forwarding, or false if - * breakable routes are found. - * - **/ -bool -virNetDevIPCheckIPv6Forwarding(void) -{ - int len; - char *cur; - g_autofree char *buf = NULL; - /* lines are 150 chars */ - enum {MAX_ROUTE_SIZE = 150*1000000}; - - /* This is /proc/sys/net/ipv6/conf/all/accept_ra */ - int all_accept_ra = virNetDevIPGetAcceptRA(NULL); - - /* Read ipv6 routes */ - if ((len = virFileReadAll(PROC_NET_IPV6_ROUTE, - MAX_ROUTE_SIZE, &buf)) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unable to read %1$s for ipv6 forwarding checks"), - PROC_NET_IPV6_ROUTE); - return false; - } - - /* Dropping the last character to stop the loop */ - if (len > 0) - buf[len-1] = '\0'; - - cur = buf; - while (cur) { - char route[33], flags[9], iface[9]; - unsigned int flags_val; - char *iface_val; - int num; - char *nl = strchr(cur, '\n'); - - if (nl) - *nl++ = '\0'; - - num = sscanf(cur, "%32s %*s %*s %*s %*s %*s %*s %*s %8s %8s", - route, flags, iface); - - cur = nl; - if (num != 3) { - VIR_DEBUG("Failed to parse route line: %s", cur); - continue; - } - - if (virStrToLong_ui(flags, NULL, 16, &flags_val)) { - VIR_DEBUG("Failed to parse flags: %s", flags); - continue; - } - - /* This is right justified, strip leading spaces */ - iface_val = &iface[0]; - while (*iface_val && g_ascii_isspace(*iface_val)) - iface_val++; - - VIR_DEBUG("%s iface %s flags %s : RTF_ADDRCONF %sset", - route, iface_val, flags, - (flags_val & RTF_ADDRCONF ? "" : "not ")); - - if (flags_val & RTF_ADDRCONF) { - int ret = virNetDevIPGetAcceptRA(iface_val); - VIR_DEBUG("%s reports accept_ra of %d", - iface_val, ret); - /* If the interface for this autoconfigured route - * has accept_ra == 1, or it is default and the "all" - * value of accept_ra == 1, it will be subject to - * flushing if forwarding is enabled. - */ - if (ret == 1 || (ret == 0 && all_accept_ra == 1)) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Check the host setup: interface %1$s has kernel autoconfigured IPv6 routes and enabling forwarding without accept_ra set to 2 will cause the kernel to flush them, breaking networking."), - iface_val); - return false; - } - } - } - return true; -} -#else bool virNetDevIPCheckIPv6Forwarding(void) diff --git a/src/util/virnetdevmacvlan.c b/src/util/virnetdevmacvlan.c index cde9d70eefd047dc5c16056f6697cf4d05bc0795..c8a7a92eb6d8bedc3b1a838ac867e9b104cc5cb0 100644 --- a/src/util/virnetdevmacvlan.c +++ b/src/util/virnetdevmacvlan.c @@ -35,7 +35,7 @@ VIR_ENUM_IMPL(virNetDevMacVLanMode, "passthrough", ); -#if defined(WITH_LIBNL) +#if defined(__linux__) # include <fcntl.h> # include <net/if.h> @@ -859,7 +859,7 @@ int virNetDevMacVLanRestartWithVPortProfile(const char *cr_ifname, } -#else /* ! WITH_LIBNL */ +#else /* ! __linux__ */ bool virNetDevMacVLanIsMacvtap(const char *ifname G_GNUC_UNUSED) { virReportSystemError(ENOSYS, "%s", @@ -959,4 +959,4 @@ int virNetDevMacVLanVPortProfileRegisterCallback(const char *ifname G_GNUC_UNUSE _("Cannot create macvlan devices on this platform")); return -1; } -#endif /* ! WITH_LIBNL */ +#endif /* ! __linux__ */ diff --git a/src/util/virnetdevveth.c b/src/util/virnetdevveth.c index 4365345664c50f47680d5fdb74d616ac989a57c9..7c4a36d3d54c4da34cb2049966d142f1b6974278 100644 --- a/src/util/virnetdevveth.c +++ b/src/util/virnetdevveth.c @@ -32,7 +32,6 @@ VIR_LOG_INIT("util.netdevveth"); -#if defined(WITH_LIBNL) static int virNetDevVethCreateInternal(const char *veth1, const char *veth2) { @@ -56,40 +55,6 @@ virNetDevVethDeleteInternal(const char *veth) { return virNetlinkDelLink(veth, NULL); } -#else -static int -virNetDevVethCreateInternal(const char *veth1, const char *veth2) -{ - g_autoptr(virCommand) cmd = virCommandNew("ip"); - virCommandAddArgList(cmd, "link", "add", veth1, "type", "veth", - "peer", "name", veth2, NULL); - - return virCommandRun(cmd, NULL); -} - -static int -virNetDevVethDeleteInternal(const char *veth) -{ - int status; - g_autoptr(virCommand) cmd = virCommandNewArgList("ip", "link", - "del", veth, NULL); - - if (virCommandRun(cmd, &status) < 0) - return -1; - - if (status != 0) { - if (!virNetDevExists(veth)) { - VIR_DEBUG("Device %s already deleted (by kernel namespace cleanup)", veth); - return 0; - } - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Failed to delete veth device %1$s"), veth); - return -1; - } - - return 0; -} -#endif /* WITH_LIBNL */ /** * virNetDevVethCreate: diff --git a/src/util/virnetdevvportprofile.c b/src/util/virnetdevvportprofile.c index c755fa79ec02e0e77b06bf6a3b6f42e24421e7dc..26be6e91319b98539927e6079596b976af207642 100644 --- a/src/util/virnetdevvportprofile.c +++ b/src/util/virnetdevvportprofile.c @@ -46,7 +46,7 @@ VIR_ENUM_IMPL(virNetDevVPortProfileOp, "no-op", ); -#if defined(WITH_LIBNL) +#if defined(__linux__) # include <fcntl.h> @@ -446,7 +446,7 @@ int virNetDevVPortProfileMerge3(virNetDevVPortProfile **result, } -#if defined(WITH_LIBNL) +#if defined(__linux__) static struct nla_policy ifla_port_policy[IFLA_PORT_MAX + 1] = { @@ -1327,7 +1327,7 @@ virNetDevVPortProfileDisassociate(const char *macvtap_ifname, return rc; } -#else /* !WITH_LIBNL */ +#else /* !__linux__ */ int virNetDevVPortProfileAssociate(const char *macvtap_ifname G_GNUC_UNUSED, const virNetDevVPortProfile *virtPort G_GNUC_UNUSED, const virMacAddr *macvtap_macaddr G_GNUC_UNUSED, @@ -1353,4 +1353,4 @@ int virNetDevVPortProfileDisassociate(const char *macvtap_ifname G_GNUC_UNUSED, _("Virtual port profile association not supported on this platform")); return -1; } -#endif /* !WITH_LIBNL */ +#endif /* !__linux__ */ diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index 206646d9d794d833de90266d4ab7cec015552137..0bb0ef23da28f2810d4e31c1bf9017545f11d0b9 100644 --- a/src/util/virnetlink.c +++ b/src/util/virnetlink.c @@ -37,7 +37,7 @@ VIR_LOG_INIT("util.netlink"); #define NETLINK_ACK_TIMEOUT_S (2*1000) -#if defined(WITH_LIBNL) +#if defined(__linux__) # include <linux/veth.h> @@ -1267,11 +1267,7 @@ virNetlinkEventRemoveClient(int watch, const virMacAddr *macaddr, #else -# if defined(__linux__) -static const char *unsupported = N_("libnl was not available at build time"); -# else static const char *unsupported = N_("not supported on non-linux platforms"); -# endif int virNetlinkStartup(void) @@ -1435,4 +1431,4 @@ virNetlinkGetErrorCode(struct nlmsghdr *resp G_GNUC_UNUSED, return -EINVAL; } -#endif /* WITH_LIBNL */ +#endif /* __linux__ */ diff --git a/src/util/virnetlink.h b/src/util/virnetlink.h index 327fb426a1d898398a60e46d3ee8fc554a2db548..56ee48161ada307e8af0bd2d4b8d7497a43e075c 100644 --- a/src/util/virnetlink.h +++ b/src/util/virnetlink.h @@ -22,7 +22,7 @@ #include "internal.h" #include "virmacaddr.h" -#if defined(WITH_LIBNL) +#if defined(__linux__) # include <netlink/msg.h> # include <linux/if_bridge.h> @@ -41,7 +41,7 @@ struct sockaddr_nl; struct nlattr; struct nlmsghdr; -#endif /* WITH_LIBNL */ +#endif /* __linux__ */ int virNetlinkStartup(void); void virNetlinkShutdown(void); diff --git a/tests/virnetdevtest.c b/tests/virnetdevtest.c index 42f1a74ee9ad66f40150920670a4f71518c9d610..99cf347934911aa4ae40bf61145e7817efbee97b 100644 --- a/tests/virnetdevtest.c +++ b/tests/virnetdevtest.c @@ -63,8 +63,6 @@ testVirNetDevGetLinkInfo(const void *opaque) return 0; } -# if defined(WITH_LIBNL) - int (*real_virNetDevSendVfSetLinkRequest)(const char *ifname, int vfInfoType, @@ -301,8 +299,6 @@ testVirNetDevSetVfConfig(const void *opaque G_GNUC_UNUSED) return 0; } -# endif /* defined(WITH_LIBNL) */ - static int mymain(void) { @@ -320,8 +316,6 @@ mymain(void) DO_TEST_LINK("lo", VIR_NETDEV_IF_STATE_UNKNOWN, 0); DO_TEST_LINK("eth0-broken", VIR_NETDEV_IF_STATE_DOWN, 0); -# if defined(WITH_LIBNL) - if (virTestRun("Set VF MAC", testVirNetDevSetVfMac, NULL) < 0) ret = -1; if (virTestRun("Set VF MAC: missing MAC pointer", testVirNetDevSetVfMissingMac, NULL) < 0) @@ -331,8 +325,6 @@ mymain(void) if (virTestRun("Set VF Config", testVirNetDevSetVfConfig, NULL) < 0) ret = -1; -# endif /* defined(WITH_LIBNL) */ - return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } --- base-commit: e5299ddf86121d3c792ca271ffcb54900eb19dc3 change-id: 20250308-require-289966671f9d Best regards, -- Akihiko Odaki <akihiko.odaki(a)daynix.com>

3 2

[PATCH v2 00/23] Add typed param constants for guest info and domain stats APIs
by Daniel P. Berrangé 11 Mar '25

11 Mar '25

Contrary to most APIs returning typed parameters, there are no constants defined for the domain stats data keys. This is was because many of the keys needs to be dynamically constructed using one or more array index values. It is possible to define constants while still supporting dynamic array indexes by simply defining the prefixes and suffixes as constants. The consuming code can then combine the constants with array index value. With this approach, it is practical to add constants for the domain stats API keys. The pattern for array entries is as follows * VIR_DOMAIN_GUEST_INFO_blah_COUNT - the number of items in the array * VIR_DOMAIN_GUEST_INFO_blah_PREFIX - the key prefix, including the trailing '.' - eg "disk." * VIR_DOMAIN_GUEST_INFO_blah_SUFFIX_blah - the key suffix, including the leading '.' - eg ".name" Where there are nested arrays, this repeats in the natural way * VIR_DOMAIN_GUEST_INFO_blah_SUFFIX_blah_COUNT - the number of items in the array * VIR_DOMAIN_GUEST_INFO_blah_SUFFIX_blah_PREFIX - the key prefix, including the leading and trailing '.' - eg ".addr." * VIR_DOMAIN_GUEST_INFO_blah_SUFFIX_blah_SUFFIX_blah - the key suffix, including the leading '.' - eg ".name" A usage of this would look like, relying on CPP string concatenation asprintf(&str, VIR_DOMAIN_STATS_VCPU_PREFIX "%d" VIR_DOMAIN_STATS_VCPU_SUFFIX_DELAY, idx); Or in language bindings such as Golang fmt.Sprintf(C.VIR_DOMAIN_STATS_VCPU_PREFIX+"%d"+C.VIR_DOMAIN_STATS_VCPU_SUFFIX_HALTED, idx) Adding these constants has a few benefits: * We can ensure that different drivers are all consistent in keys used for typed parameters * Language bindings can query the API XML to identify any gaps in their API coverage A note on "Since" tags. We use the "Since" tags to express when an API was added to libvirt. In this case we're adding constants long /after/ we first introduced these APIs. So the question is whether the Since tags reflect when the typed parameter key was first used or when the API constant was added. For convenience I chose the latter, because the Golang bnidings use the Since tags to auto generate code with #if !LIBVIRT_CHECK_VERSION() around its usage of the constants. This would break if we retroactively dated the Since tags to when the keys were first used. As proof of the value, adding these constants has lead to be find sooooooooooo many mistakes in the Golang bindings where we forgot to add new domain stats/guest info data items, and one place where we typod the name. https://gitlab.com/libvirt/libvirt-go-module/-/merge_requests/67 Changes in v2: * Don't line wrap concatenation of the macros * Fix a couple of typos in constants * Rebase for changes to virt typed paramater list API usage in guest info * Add docs explaining the usage pattern * Add docs explaining the 11.2.0 version number caveat vs historical introduction Daniel P. Berrangé (23): src: add constants for guest info 'user.' parameters src: add constants for guest info 'os.' parameters src: add constants for guest info 'timezone.' parameters src: add constant for the guest info 'hostname' parameter src: add constants for guest info 'fs.' parameters src: add constants for guest info 'disk.' parameters src: add constants for guest info 'if.' parameters src: add constants for guest info 'load.' parameters src: expand docs for guest info array handling src: expand docs for guest info constant version handling src: add constants for domain stats 'state.' parameters src: add constants for domain stats 'cpu.' parameters src: add constants for domain stats 'balloon.' parameters src: add constants for domain stats 'vcpu.' parameters src: add constants for domain stats 'net.' parameters src: add constants for domain stats 'block.' parameters src: add constants for domain stats 'perf.' parameters src: add constants for domain stats 'iothread.' parameters src: add constants for domain stats 'memory.' parameters src: add constants for domain stats 'dirtyrate.' parameters src: document that no constants are provided for custom VM stats src: expand docs for guest info array handling src: expand docs for guest stats constant version handling include/libvirt/libvirt-domain.h | 6605 +++++++++++++++++++----------- src/libvirt-domain.c | 547 +-- src/qemu/qemu_agent.c | 35 +- src/qemu/qemu_driver.c | 377 +- 4 files changed, 4573 insertions(+), 2991 deletions(-) -- 2.48.1

2 35

[libvirt PATCH v2] qemu: snapshot: error out early when reverting snapshot for VM with non-file disk
by Pavel Hrdina 11 Mar '25

11 Mar '25

Before this patch the code would start the revert process by destroying the VM and preparing to revert where it would fail with following error: error: unsupported configuration: source for disk 'sdb' is not a regular file; refusing to generate external snapshot name and leaving user with offline VM even if it was running. Make the check before we start the revert process to not destroy VMs. Resolves: https://issues.redhat.com/browse/RHEL-30971 Resolves: https://issues.redhat.com/browse/RHEL-79928 Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- Changes in v2: - add comments - limit the check for external snapshots src/qemu/qemu_snapshot.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index 891e67e98b..dab841ef5b 100644 --- a/src/qemu/qemu_snapshot.c +++ b/src/qemu/qemu_snapshot.c @@ -2203,6 +2203,8 @@ qemuSnapshotRevertValidate(virDomainObj *vm, virDomainSnapshotDef *snapdef, unsigned int flags) { + size_t i; + if (!vm->persistent && snapdef->state != VIR_DOMAIN_SNAPSHOT_RUNNING && snapdef->state != VIR_DOMAIN_SNAPSHOT_PAUSED && @@ -2230,6 +2232,22 @@ qemuSnapshotRevertValidate(virDomainObj *vm, } } + /* Reverting to external snapshot creates overlay files for every disk and + * it would fail for non-file based disks. + * See qemuSnapshotRevertExternalPrepare for more details. */ + if (virDomainSnapshotIsExternal(snap)) { + for (i = 0; i < snap->def->dom->ndisks; i++) { + virDomainDiskDef *disk = snap->def->dom->disks[i]; + + if (disk->src->type != VIR_STORAGE_TYPE_FILE) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, + _("source disk for '%1$s' is not a regular file, reverting to snapshot is not supported"), + disk->dst); + return -1; + } + } + } + return 0; } @@ -2381,6 +2399,9 @@ qemuSnapshotRevertExternalPrepare(virDomainObj *vm, if (virDomainMomentDefPostParse(&tmpsnapdef->parent) < 0) return -1; + /* Force default location to be external in order to create overlay files + * for every disk. In qemuSnapshotRevertValidate we make sure that each + * disk is regular file otherwise this would fail. */ if (virDomainSnapshotAlignDisks(tmpsnapdef, domdef, VIR_DOMAIN_SNAPSHOT_LOCATION_EXTERNAL, false, true) < 0) { -- 2.48.1

2 1

[PATCH RFC-v2 00/11] qemu: Add support for iothread to virtqueue mapping for 'virtio-scsi'
by Peter Krempa 11 Mar '25

11 Mar '25

Unfortunately still RFC as the qemu support is still not merged. Once again there are a few patches that are applicable: qemu: Use modern header formatting in 'qemu_command.h' virXMLNodeGetSubelementList: Document return value semantics virDomainIothreadMappingDefParse: Fix usage of virXMLNodeGetSubelementList docs: formatdomain: Clarify configuration of iothread <-> virtqueue mapping The patches below are RFC: qemucapabilitiestest: Update 'caps_10.0.0_x86_64' to XXXXXX qemu: capabilities: Introduce QEMU_CAPS_VIRTIO_SCSI_IOTHREAD_MAPPING virDomainIothreadMapping: Add support for naming certain virt queues conf: Add support for iothread to queue mapping config for 'virtio-scsi' qemu: Implement support for iothread <-> virtqueue mapping for 'virtio-scsi' controllers qemuxmlconftest: Add 'iothreads-virtio-scsi-mapping' case NEWS: Mention multiple iothread support for 'virtio-scsi' controller Changes to v1: - pushed the non-RFC refactors - few new cleanups added - new docs patch emphasizing the auto-assignment (in example XML and description) in qemu and improved wording of docs for 'virtio-blk' miltiqueue mapping - changed code to use names for 'ctrl' and 'event' virtqueues of 'virtio-scsi' - used the improved docs also for virtio scsi - added NEWS NEWS.rst | 6 + docs/formatdomain.rst | 66 ++++++++++- src/conf/domain_conf.c | 32 ++++-- src/conf/domain_conf.h | 4 +- src/conf/domain_validate.c | 10 +- src/conf/schemas/domaincommon.rng | 9 +- src/hypervisor/domain_driver.c | 3 +- src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 86 ++++++++++++-- src/qemu/qemu_command.h | 95 ++++++++++------ src/qemu/qemu_domain.c | 10 +- src/qemu/qemu_validate.c | 105 ++++++++++++------ src/util/virxml.c | 2 + .../caps_10.0.0_x86_64.replies | 7 +- .../caps_10.0.0_x86_64.xml | 3 +- ...ads-virtio-scsi-mapping.x86_64-latest.args | 40 +++++++ ...eads-virtio-scsi-mapping.x86_64-latest.xml | 65 +++++++++++ .../iothreads-virtio-scsi-mapping.xml | 57 ++++++++++ tests/qemuxmlconftest.c | 1 + 20 files changed, 495 insertions(+), 109 deletions(-) create mode 100644 tests/qemuxmlconfdata/iothreads-virtio-scsi-mapping.x86_64-latest.args create mode 100644 tests/qemuxmlconfdata/iothreads-virtio-scsi-mapping.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/iothreads-virtio-scsi-mapping.xml -- 2.48.1

2 16

[PATCH 00/19] Add typed param constants for guest info and domain stats APIs
by Daniel P. Berrangé 11 Mar '25

11 Mar '25

Contrary to most APIs returning typed parameters, there are no constants defined for the domain stats data keys. This is was because many of the keys needs to be dynamically constructed using one or more array index values. It is possible to define constants while still supporting dynamic array indexes by simply defining the prefixes and suffixes as constants. The consuming code can then combine the constants with array index value. With this approach, it is practical to add constants for the domain stats API keys. The pattern for array entries is as follows * VIR_DOMAIN_GUEST_INFO_blah_COUNT - the number of items in the array * VIR_DOMAIN_GUEST_INFO_blah_PREFIX - the key prefix, including the trailing '.' - eg "disk." * VIR_DOMAIN_GUEST_INFO_blah_SUFFIX_blah - the key suffix, including the leading '.' - eg ".name" Where there are nested arrays, this repeats in the natural way * VIR_DOMAIN_GUEST_INFO_blah_SUFFIX_blah_COUNT - the number of items in the array * VIR_DOMAIN_GUEST_INFO_blah_SUFFIX_blah_PREFIX - the key prefix, including the leading and trailing '.' - eg ".addr." * VIR_DOMAIN_GUEST_INFO_blah_SUFFIX_blah_SUFFIX_blah - the key suffix, including the leading '.' - eg ".name" A usage of this would look like, relying on CPP string concatenation asprintf(&str, VIR_DOMAIN_STATS_VCPU_PREFIX "%d" VIR_DOMAIN_STATS_VCPU_SUFFIX_DELAY, idx); Or in language bindings such as Golang fmt.Sprintf(C.VIR_DOMAIN_STATS_VCPU_PREFIX+"%d"+C.VIR_DOMAIN_STATS_VCPU_SUFFIX_HALTED, idx) Adding these constants has a few benefits: * We can ensure that different drivers are all consistent in keys used for typed parameters * Language bindings can query the API XML to identify any gaps in their API coverage A note on "Since" tags. We use the "Since" tags to express when an API was added to libvirt. In this case we're adding constants long /after/ we first introduced these APIs. So the question is whether the Since tags reflect when the typed parameter key was first used or when the API constant was added. For convenience I chose the latter, because the Golang bnidings use the Since tags to auto generate code with #if !LIBVIRT_CHECK_VERSION() around its usage of the constants. This would break if we retroactively dated the Since tags to when the keys were first used. As proof of the value, adding these constants has lead to be find sooooooooooo many mistakes in the Golang bindings where we forgot to add new domain stats/guest info data items, and one place where we typod the name. Daniel P. Berrangé (19): src: add constants for guest info 'user.' parameters src: add constants for guest info 'os.' parameters src: add constants for guest info 'timezone.' parameters src: add constant for the guest info 'hostname' parameter src: add constants for guest info 'fs.' parameters src: add constants for guest info 'disk.' parameters src: add constants for guest info 'if.' parameters src: add constants for domain stats 'state.' parameters src: add constants for domain stats 'cpu.' parameters src: add constants for domain stats 'balloon.' parameters src: add constants for domain stats 'vcpu.' parameters src: add constants for domain stats 'net.' parameters src: add constants for domain stats 'block.' parameters src: add constants for domain stats 'perf.' parameters src: add constants for domain stats 'iothread.' parameters src: add constants for domain stats 'memory.' parameters src: add constants for domain stats 'dirtyrate.' parameters src: add constants for domain stats 'dirtyrate.' parameters src: document that no constants are provided for custom VM stats include/libvirt/libvirt-domain.h | 1614 ++++++++++++++++++++++++++++++ src/libvirt-domain.c | 424 ++------ src/qemu/qemu_agent.c | 36 +- src/qemu/qemu_driver.c | 425 +++++--- 4 files changed, 1996 insertions(+), 503 deletions(-) -- 2.48.1

2 41

[PATCH] security: Don't stop restoring labels too early
by Michal Privoznik 11 Mar '25

11 Mar '25

The point of virSecurityManagerRestoreAllLabel() function is to restore ALL labels and be tolerant to possible errors, i.e. continue restoring seclabels and NOT return early. Well, in two implementations of this internal API this type of problem was found: 1) virSecurityDACRestoreAllLabel() returned early if virSecurityDACRestoreGraphicsLabel() failed, or when def->sec->sectype equals to an impossible value. 2) virSecuritySELinuxRestoreAllLabel() returned early if virSecuritySELinuxRestoreMemoryLabel() failed. Fix all three places. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Inspired by this Peter's patch: https://marc.info/?l=libvir-list&m=174169408218982&w=2 src/security/security_dac.c | 4 ++-- src/security/security_selinux.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/security/security_dac.c b/src/security/security_dac.c index e07977300f..3ecbc7277d 100644 --- a/src/security/security_dac.c +++ b/src/security/security_dac.c @@ -1973,7 +1973,7 @@ virSecurityDACRestoreAllLabel(virSecurityManager *mgr, for (i = 0; i < def->ngraphics; i++) { if (virSecurityDACRestoreGraphicsLabel(mgr, def, def->graphics[i]) < 0) - return -1; + rc = -1; } for (i = 0; i < def->ninputs; i++) { @@ -2021,7 +2021,7 @@ virSecurityDACRestoreAllLabel(virSecurityManager *mgr, case VIR_DOMAIN_LAUNCH_SECURITY_NONE: case VIR_DOMAIN_LAUNCH_SECURITY_LAST: virReportEnumRangeError(virDomainLaunchSecurity, def->sec->sectype); - return -1; + rc = -1; } } diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 38e611f567..64e7f41ce0 100644 --- a/src/security/security_selinux.c +++ b/src/security/security_selinux.c @@ -2969,7 +2969,7 @@ virSecuritySELinuxRestoreAllLabel(virSecurityManager *mgr, for (i = 0; i < def->nmems; i++) { if (virSecuritySELinuxRestoreMemoryLabel(mgr, def, def->mems[i]) < 0) - return -1; + rc = -1; } for (i = 0; i < def->ntpms; i++) { -- 2.48.1

2 1

[PATCH 0/3] qemu: Refactor typed parameter list construction in SEV apis
by Peter Krempa 11 Mar '25

11 Mar '25

Peter Krempa (3): qemuDomainGetLaunchSecurityInfo: Don't forget unlock VM object on (impossible) error qemuDomainGetLaunchSecurityInfo: Use virTypedParamList to construct return value qemuNodeGetSEVInfo: Use virTypedParamList to construct return value src/qemu/qemu_driver.c | 107 ++++++++++++----------------------------- 1 file changed, 31 insertions(+), 76 deletions(-) -- 2.48.1

2 5