- Devel - libvirt List Archives

[libvirt PATCH] qemu_driver: Fix virDomainSaveImageDefineXML
by Pavel Hrdina 24 Mar '25

24 Mar '25

From: Pavel Hrdina <phrdina(a)redhat.com> Commit 28a06215280b99708ed8dc2d183f62ba7b34ccf8 added support to restore sparse images but changed the boolean that controls if we open the file as read-only or read-write. Editing XML in the save image resulted in following error message: failed to write header to domain save file '/data/images/fedora40.save': Bad file descriptor Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 3cf21380ed..056a9e579d 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -5945,7 +5945,7 @@ qemuDomainSaveImageDefineXML(virConnectPtr conn, const char *path, if (qemuSaveImageGetMetadata(driver, NULL, path, &def, &data) < 0) goto cleanup; - fd = qemuSaveImageOpen(driver, path, false, false, NULL, false); + fd = qemuSaveImageOpen(driver, path, false, false, NULL, true); if (fd < 0) goto cleanup; -- 2.49.0

2 1

[libvirt PATCH 0/6] cleanup and fixes of the mapped-ram feature
by Pavel Hrdina 24 Mar '25

24 Mar '25

Pavel Hrdina (6): tools: remove --parallel from virsh restore command tools: remote --parallel from virsh save command qemu: remove VIR_DOMAIN_SAVE_PARALLEL flag tools: use virDomainRestoreParams only when necessary tools: use virDomainSaveParams only when necessary virsh: add --image-format option to the save command docs/manpages/virsh.rst | 24 +++++---- include/libvirt/libvirt-domain.h | 1 - src/qemu/qemu_driver.c | 6 +-- src/qemu/qemu_migration_params.c | 34 ++++++------ tools/virsh-domain.c | 93 ++++++++++++++++---------------- 5 files changed, 80 insertions(+), 78 deletions(-) -- 2.48.1

4 11

[PATCH] NEWS: hotplug virtio-mem device
by Boris Fiuczynski 21 Mar '25

21 Mar '25

Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com> --- NEWS.rst | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 484333e55a..1de0231c57 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -56,6 +56,12 @@ v11.2.0 (unreleased) * **Bug fixes** + * qemu: attach virtio-mem with CCW address + + Attaching a virtio-mem device on s390 without an address type now gets a + default type CCW address assigned. A specified CCW address is now used for + the virtio-mem device instead of getting overwritten by a PCI address. + v11.1.0 (2025-03-03) ==================== -- 2.47.0

3 2

[libvirt PATCH] NEWS: fix even more typos
by Ján Tomko 21 Mar '25

21 Mar '25

From: Ján Tomko <jtomko(a)redhat.com> The 'editting one' was: Reported-by: Martin Kletzander <mkletzan(a)redhat.com> I found the rest myself. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed as trivial. NEWS.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index 484333e55a..6ab34aa756 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -31,7 +31,7 @@ v11.2.0 (unreleased) * qemu: Add support for multiple iothreads for ``virtio-scsi`` controller - It's now possible to map multiple iotreads to the ``virtio-scsi`` controller + It's now possible to map multiple iothreads to the ``virtio-scsi`` controller or even map them to specific virtqueues similarly to the ``virtio-blk`` device allowing for better performance in certain scenarios. @@ -45,10 +45,10 @@ v11.2.0 (unreleased) a host shutdown has been requested. It will initiate the chosen action on running guests immediately, allowing shutdown inhibitors to be released sooner. The new solution is also able to iteratively try multiple actions - until one of them succeeeds in shutting down the VM. + until one of them succeeds in shutting down the VM. Since it must be mutually exclusive with the libvirt-guests script, this - feature currently requires an manual opt-in through editting of the + feature currently requires an manual opt-in through editing of the /etc/libvirt/qemu.conf configuration file. The libvirt-guests script must be disabled before doing this. -- 2.49.0

2 2

[PATCH 0/8] qemu: Improve guest agent corner case errors
by Peter Krempa 21 Mar '25

21 Mar '25

This series introduces two new error codes aimed to help management applications to better in deciding when corner cases of guest agent interaction are encountered. Peter Krempa (8): lib: error: Introduce 'VIR_ERR_AGENT_COMMAND_TIMEOUT' qemu: agent: Differentiate timeouts when syncing from command timeout qemuAgentCommandFull: Use VIR_ERR_AGENT_COMMAND_TIMEOUT when agent disappears docs: Point to VIR_ERR_AGENT_COMMAND_TIMEOUT when setting timeout lib: error: Introduce 'VIR_ERR_AGENT_COMMAND_FAILED' qemuAgentCheckError: Use 'VIR_ERR_AGENT_COMMAND_FAILED' qemuAgentCheckError: Rewort error if neither return nor error is found NEWS: Mention guest agent error code improvements NEWS.rst | 10 ++++++++++ docs/manpages/virsh.rst | 3 +++ include/libvirt/virterror.h | 4 ++++ src/libvirt-domain.c | 4 ++++ src/qemu/qemu_agent.c | 32 +++++++++++++++++++++----------- src/util/virerror.c | 6 ++++++ 6 files changed, 48 insertions(+), 11 deletions(-) -- 2.48.1

3 16

[PATCH] NEWS: Mention support for mapped-ram
by Jim Fehlig 21 Mar '25

21 Mar '25

Add a 'New features' entry for mapped-ram itself, and another for the parallel save/restore feature built on top. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- NEWS.rst | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 484333e55a..76f7ea65b1 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -52,6 +52,21 @@ v11.2.0 (unreleased) /etc/libvirt/qemu.conf configuration file. The libvirt-guests script must be disabled before doing this. + * qemu: Add 'sparse' as a new save image format + + QEMU's ``file`` migration has been supplemented with the new stream format + ``mapped-ram``, where RAM pages are mapped directly to offsets in the + migration file. ``mapped-ram`` is now supported by augmenting the existing + save image formats with the ``sparse`` format. + + * qemu: Add support for parallel save/restore + + The ``sparse`` image format can support reading and writing by multiple + channels. ``virDomainSaveParams`` and ``virDomainRestoreParams`` now + support specifying the number of IO channels used for parallel save and + restore. Using multiple channels can reduce the time required to save + and restore domains. + * **Improvements** * **Bug fixes** -- 2.43.0

2 1

[PATCH 0/2] qemu: Build fixes following merge of mapped-ram
by Jim Fehlig 21 Mar '25

21 Mar '25

Patches to fix the recent build failures caused by merging the mapped-ram series. They get a green light from a CI run in my fork https://gitlab.com/jfehlig/libvirt/-/pipelines/1727301916 I would push them as build-breakers, but the first one does raise a question that should be answered beforehand IMO. See the individual patches for more commentary. Also, feel free to push if the patches are fine and it's outside of MDT timezone working hours :-). Jim Fehlig (2): qemu: Fix CLang build qemu: Fix build on 32-bit platforms src/qemu/qemu_migration_params.c | 2 +- src/qemu/qemu_monitor.c | 4 ++-- src/qemu/qemu_process.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) -- 2.43.0

2 4

[PATCH] Add NEWS item for auto-shutdown feature
by Daniel P. Berrangé 21 Mar '25

21 Mar '25

From: Daniel P. Berrangé <berrange(a)redhat.com> Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- NEWS.rst | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 98ca838642..45d48c1485 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -35,6 +35,23 @@ v11.2.0 (unreleased) or even map them to specific virtqueues similarly to the ``virtio-blk`` device allowing for better performance in certain scenarios. + * qemu: integrate support for VM shutdown on host shutdown + + It is now possible to instruct the QEMU driver to automatically perform + managed save, graceful shutdown, or hard poweroff on running VMs, when a + host shutdown is requested. This feature is intended to eventually replace + usage of the libvirt-guests script. The new approach improves on the + libvirt-guests script, by proactively monitor logind for a signal that a + host shutdown has been requested. It will initiate the chosen action on + running guests immediately, allowing shutdown inhibitors to be released + sooner. The new solution is also able to iteratively try multiple actions + until one of them succeeeds in shutting down the VM. + + Since it must be mutually exclusive with the libvirt-guests script, this + feature currently requires an manual opt-in through editting of the + /etc/libvirt/qemu.conf configuration file. The libvirt-guests script must + be disabled before doing this. + * **Improvements** * **Bug fixes** -- 2.48.1

5 5

[PATCH] virsh: make virshPrintJobProgress tty-aware
by Vincent Caron 21 Mar '25

21 Mar '25

virshPrintJobProgress pretty-prints a migration progress indicator on stderr presuming it's tied to a tty, which is not always true. In the case without the tty, I still find the progress indication useful (for instance it ends in a timestamped log, which is useful for debug/perf analysis). And most log processings are line-buffered, thus it won't properly work until every progress update ends with a newline. I had a quick glance and did not find any other place in virsh code where a tty was assumed, thus I thought this tty-awareness could be narrowed to this single function. This was originally submited as https://gitlab.com/libvirt/libvirt/-/issues/756 Signed-off-by: Vincent Caron <vcaron(a)bearstech.com> --- tools/virsh-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 1bee969824..577ab57158 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -2108,7 +2108,7 @@ virshPrintJobProgress(const char *label, unsigned long long remaining, /* see comments in vshError about why we must flush */ fflush(stdout); /* avoid auto-round-off of double by keeping only 2 decimals */ - fprintf(stderr, "\r%s: [%5.2f %%]", label, (int)(progress*100)/100.0); + fprintf(stderr, isatty(STDERR_FILENO) ? "\r%s: [%5.2f %%]" : "%s: [%5.2f %%]\n", label, (int)(progress*100)/100.0); fflush(stderr); } -- 2.39.5

1 0

[PATCH v9 reviewed 00/17] qemu: block: Support block disk along with throttle filters
by Peter Krempa 20 Mar '25

20 Mar '25

v9 of the throttle filtering series with my reviews and R-b tags applied. Requires [PATCH 0/5] qemu: Two block job fixes https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/TX2… to be applied to work properly. Posting for tracking and possibly final review of API. I'll push it before the freeze if there won't be further comments. Changes (most recorded in commit messages): - removed leftover code after deletion of some of the APIs - fixed numerous memleaks - simplified virsh code - dropped test driver pach Chun Feng Wu (16): schema: Add new domain elements to support multiple throttle groups schema: Add new domain elements to support multiple throttle filters config: Introduce ThrottleGroup and corresponding XML parsing config: Introduce ThrottleFilter and corresponding XML parsing qemu: monitor: Add support for ThrottleGroup operations tests: Test qemuMonitorJSONGetThrottleGroup and qemuMonitorJSONUpdateThrottleGroup remote: New APIs for ThrottleGroup lifecycle management qemu: Refactor qemuDomainSetBlockIoTune to extract common methods qemu: Implement qemu driver for throttle API qemu: helper: throttle filter nodename and preparation processing qemu: block: Support block disk along with throttle filters config: validate: Verify iotune, throttle group and filter qemuxmlconftest: Add 'throttlefilter' tests virsh: Refactor iotune options for re-use virsh: Add support for throttle group operations virsh: Add option "throttle-groups" to "attach_disk" Harikumar Rajkumar (1): qemustatusxml2xmldata: Add 'throttlefilter' tests docs/formatdomain.rst | 47 ++ docs/manpages/virsh.rst | 137 +++- include/libvirt/libvirt-domain.h | 14 + src/conf/domain_conf.c | 409 +++++++++++ src/conf/domain_conf.h | 47 ++ src/conf/domain_validate.c | 124 +++- src/conf/schemas/domaincommon.rng | 293 ++++---- src/conf/virconftypes.h | 4 + src/driver-hypervisor.h | 14 + src/libvirt-domain.c | 122 +++ src/libvirt_private.syms | 8 + src/libvirt_public.syms | 6 + src/qemu/qemu_block.c | 136 ++++ src/qemu/qemu_block.h | 49 ++ src/qemu/qemu_command.c | 171 +++++ src/qemu/qemu_command.h | 6 + src/qemu/qemu_domain.c | 77 +- src/qemu/qemu_driver.c | 467 +++++++++--- src/qemu/qemu_hotplug.c | 16 + src/qemu/qemu_monitor.c | 21 + src/qemu/qemu_monitor.h | 9 + src/qemu/qemu_monitor_json.c | 61 ++ src/qemu/qemu_monitor_json.h | 9 + src/remote/remote_driver.c | 2 + src/remote/remote_protocol.x | 31 +- src/remote_protocol-structs | 16 + tests/qemumonitorjsontest.c | 51 ++ .../throttlefilter-in.xml | 392 ++++++++++ .../throttlefilter-out.xml | 393 ++++++++++ tests/qemuxmlactivetest.c | 1 + .../throttlefilter-invalid.x86_64-latest.err | 1 + .../throttlefilter-invalid.xml | 89 +++ .../throttlefilter.x86_64-latest.args | 56 ++ .../throttlefilter.x86_64-latest.xml | 105 +++ tests/qemuxmlconfdata/throttlefilter.xml | 95 +++ tests/qemuxmlconftest.c | 2 + tools/virsh-completer-domain.c | 63 ++ tools/virsh-completer-domain.h | 14 + tools/virsh-domain.c | 695 ++++++++++++++---- 39 files changed, 3845 insertions(+), 408 deletions(-) create mode 100644 tests/qemustatusxml2xmldata/throttlefilter-in.xml create mode 100644 tests/qemustatusxml2xmldata/throttlefilter-out.xml create mode 100644 tests/qemuxmlconfdata/throttlefilter-invalid.x86_64-latest.err create mode 100644 tests/qemuxmlconfdata/throttlefilter-invalid.xml create mode 100644 tests/qemuxmlconfdata/throttlefilter.x86_64-latest.args create mode 100644 tests/qemuxmlconfdata/throttlefilter.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/throttlefilter.xml -- 2.48.1

2 20